lisp/makefile.w32-in (COMPILE_FIRST): Synch with changes in 2008-06-22T13:57:28Z...
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2b570124
PE
12012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2
e93864f9
PE
3 * .gdbinit (xgetint): Fix recently-introduced paren typo.
4 Assume USE_2_TAGS_FOR_INTS.
5 (xreload): Adjust $tagmask width to match recent lisp.h change.
6
2b570124
PE
7 Simplify lisp.h in minor ways that should not affect code.
8 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
9 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
10 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
11 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
12 (INTTYPEBITS): New macro, for clarity.
13 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
14 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P): Simplify
15 now that USE_LSB_TAG is always defined.
16 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
17 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
18
81755f69
JB
192012-06-13 Juanma Barranquero <lekktu@gmail.com>
20
21 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
22
16192a57
GM
232012-06-13 Glenn Morris <rgm@gnu.org>
24
25 * s/bsd-common.h (BSD4_3):
26 * s/usg5-4-common.h (USG5_4): No longer define; unused.
27
646b5f55
AS
282012-06-13 Andreas Schwab <schwab@linux-m68k.org>
29
30 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
31 instead of union.
32 (XLI, XIL): Define.
33 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
34 them.
35 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
36 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
37 * alloc.c (widen_to_Lisp_Object): Removed.
38 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
39 * frame.c (delete_frame): Remove outdated comment.
40 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
41 USE_LISP_UNION_TYPE.
42 (Fw32_unregister_hot_key): Likewise.
43 (Fw32_toggle_lock_key): Likewise.
44 * w32menu.c (add_menu_item): Likewise.
45 (w32_menu_display_help): Use XIL instead of checking
46 USE_LISP_UNION_TYPE.
47 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
48 (init_heap): Likewise.
49 * w32term.c (w32_read_socket): Update comment.
50
1d3823c9
GM
512012-06-13 Glenn Morris <rgm@gnu.org>
52
c62ff706
GM
53 * s/usg5-4-common.h, src/s/unixware.h:
54 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
55
1d3823c9
GM
56 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
57
bfe3e0a2
PE
582012-06-13 Paul Eggert <eggert@cs.ucla.edu>
59
60 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
61 * alloc.c (make_number) [!defined make_number]:
62 Remove, as lisp.h always defines this now.
63 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
64 (roundup_size): Verify that it is a power of 2.
65 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
66 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
67 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
68 -DUSE_LSB_TAG=0, to override the automatically-selected default.
69 USE_LSB_TAG now is always defined to be either 0 or 1.
70 All uses changed.
71 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
72 code works fine either way, and efficiency is not a concern here,
73 as the union type is for debugging, not for production.
74 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
75 Use an inline function on all platforms when using the union type,
76 since this is simpler and 'static inline' can be used portably
77 within Emacs now.
78 (LISP_INITIALLY_ZERO): New macro.
79 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
80 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
81
45fa9c0f
GM
822012-06-12 Glenn Morris <rgm@gnu.org>
83
b4492cba
GM
84 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
85
86 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 87
45fa9c0f
GM
88 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
89 Move BROKEN_SIGIO to configure.
90
91 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
92 Move NO_TERMIO to configure.
93
0e25d334
CY
942012-06-12 Chong Yidong <cyd@gnu.org>
95
96 * image.c (imagemagick_load_image): Use MagickFlattenImage if
97 MagickMergeImageLayers is undefined. Use pixel pusher loop if
98 MagickExportImagePixels is undefined.
99
43682bb6
PE
1002012-06-12 Paul Eggert <eggert@cs.ucla.edu>
101
102 * image.c (imagemagick_load_image): Remove unused label.
103
a9be7d2b
GM
1042012-06-11 Glenn Morris <rgm@gnu.org>
105
106 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
107 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
108 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
109 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
110
3017f87f
SM
1112012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
112
113 * alloc.c (make_byte_code): New function.
114 (Fmake_byte_code): Use it. Don't purify here.
115 * lread.c (read1): Use it as well to avoid extra allocation.
116
1b9b4cf4
CY
1172012-06-11 Chong Yidong <cyd@gnu.org>
118
119 * image.c (imagemagick_load_image): Implement transparency.
120
95988fcf
AS
1212012-06-10 Andreas Schwab <schwab@linux-m68k.org>
122
123 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
124 account for preceding backslashes. (Bug#11663)
125
cd4eb164
CY
1262012-06-09 Chong Yidong <cyd@gnu.org>
127
128 * term.c: Support italics in capable terminals (Bug#9652).
129 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
130 (turn_on_face): Output using TS_enter_italic_mode if available.
131 Don't handle unused blinking and alt-charset cases.
132 (turn_off_face): Handle italic case; discard unused tty_blinking_p
133 and tty_alt_charset_p cases.
134 (tty_capable_p, init_tty): Support italics.
135
136 * termchar.h (struct tty_display_info): Add field for italics.
137 Remove unused blink field.
138
139 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
140 Handle slant.
141
142 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
143 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
144 tty_alt_charset_p. Add tty_italic_p.
145
ff88beb8
MA
1462012-06-09 Michael Albinus <michael.albinus@gmx.de>
147
148 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
149 dbus_type_is_basic if available.
150 (xd_extract_signed, xd_extract_unsigned): Rename from
151 extract_signed and extract_unsigned, respectively. Adapt callers.
152
44286096
CY
1532012-06-09 Chong Yidong <cyd@gnu.org>
154
1682701f
CY
155 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
156
44286096
CY
157 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
158 case (Bug#9752).
159
d86feb17
PE
1602012-06-08 Paul Eggert <eggert@cs.ucla.edu>
161
162 * xdisp.c (vmessage): Treat frame message as multibyte.
163 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
164 would generate the diagnostic "Making \302\247 buffer-local while
165 let-bound!".
166
d5c20fe8
EZ
1672012-06-08 Eli Zaretskii <eliz@gnu.org>
168
169 * dispnew.c (showing_window_margins_p): Undo last change, which
170 was done due to an inadvertent commit.
171 (adjust_frame_glyphs_for_frame_redisplay): Do call
172 showing_window_margins_p.
173
513749ee
SM
1742012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
175
176 * eval.c (Fmake_var_non_special): New primitive.
177 (syms_of_eval): Defsubr it.
178 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
179
d4a8f5c1
JB
1802012-06-08 Juanma Barranquero <lekktu@gmail.com>
181
182 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
183 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
184
8bbbc977
EZ
1852012-06-08 Eli Zaretskii <eliz@gnu.org>
186
187 * alloc.c (allocate_vectorlike): Fix last change.
188
f3372c87
DA
1892012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
190
191 Block-based vector allocation of small vectors.
192 * lisp.h (struct vectorlike_header): New field `nbytes',
193 adjust comment accordingly.
194 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
195 to denote vector blocks. Adjust users (live_vector_p,
196 mark_maybe_pointer, valid_lisp_object_p) accordingly.
197 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
198 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
199 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
200 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
201 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
202 (roundup_size): New constant.
203 (struct vector_block): New data type.
204 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 205 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
206 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
207 (sweep_vectors): New functions.
208 (allocate_vectorlike): Return `zero_vector' as the only vector of
209 0 items. Allocate new vector from block if vector size is less than
210 or equal to VBLOCK_BYTES_MAX.
211 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
212 (init_alloc_once): Add call to init_vectors.
213
4f18a4ed
SM
2142012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
215
216 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
217
86f158bc
PE
2182012-06-07 Paul Eggert <eggert@cs.ucla.edu>
219
220 * doprnt.c (doprnt): Truncate multibyte char correctly.
221 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
222 would mishandle a string argument "Xc" if X was a multibyte
223 character of length 2: it would truncate after X's first byte
224 rather than including all of X.
225
c5cfcbe0
CY
2262012-06-06 Chong Yidong <cyd@gnu.org>
227
228 * buffer.c (word_wrap): Doc fix.
229
c05cf390
PE
2302012-06-04 Paul Eggert <eggert@cs.ucla.edu>
231
232 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
233
0c3461de
GM
2342012-06-03 Glenn Morris <rgm@gnu.org>
235
236 * xdisp.c (tool-bar-style): Doc fix.
237
c71232db
UM
2382012-06-03 Ulrich Müller <ulm@gentoo.org>
239
240 * Makefile.in (PAXCTL): Define.
241 (temacs$(EXEEXT)): Disable memory randomization for the temacs
242 binary via PaX flags if the paxctl utility is available.
243 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
244 Restore PaX flags to their default. (Bug#11398)
245
383f7350
CY
2462012-06-03 Chong Yidong <cyd@gnu.org>
247
248 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
249 buffer (Bug#11226).
250
5f2c76c6
CY
2512012-06-03 Chong Yidong <cyd@gnu.org>
252
253 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
254 (note_mode_line_or_margin_highlight): If there is no help echo,
255 use mode-line-default-help-echo. Handle the case where the mouse
256 position is past the end of the mode line string.
257
258 * buffer.c (buffer_local_value_1): New function, split from
259 Fbuffer_local_value; can return Qunbound.
260 (Fbuffer_local_value): Use it.
261 (Vmode_line_format): Docstring tweaks.
262
773d47f6
PE
2632012-06-02 Paul Eggert <eggert@cs.ucla.edu>
264
265 * sysdep.c (system_process_attributes): Improve comment.
266
f2d6a3df
SM
2672012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
268
269 * keyboard.c: Export real-this-command to Elisp.
270 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
271 and DEFVAR it. Update all users.
272
63810350
PE
2732012-06-02 Paul Eggert <eggert@cs.ucla.edu>
274
7bd5c1f4
PE
275 * minibuf.c (Fassoc_string): Remove duplicate declaration.
276
63810350
PE
277 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
278 Convert pctcpu and pctmem to Lisp float properly.
279 Let the compiler fold better, as 100.0/0x8000 is exact.
280
a2821611
AS
2812012-06-02 Andreas Schwab <schwab@linux-m68k.org>
282
283 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
284 cons_block.
285
5fceba1d
PE
2862012-06-01 Paul Eggert <eggert@cs.ucla.edu>
287
288 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
289
c98ff5dd
DA
2902012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
291
292 For a 'struct window', replace some Lisp_Object fields to
293 bitfields where appropriate, remove unused fields.
294 * window.h (struct window): Remove unused 'last_mark_x' and
295 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
296 change it's type from Lisp_Object to bitfield.
297 Change type of 'force_start', 'optional_new_start',
298 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
299 fields from Lisp_Object to bitfield. Adjust users accordingly.
300
ca34e0be
PE
3012012-05-31 Paul Eggert <eggert@cs.ucla.edu>
302
303 Pacify gcc -Wdouble-precision when using Xaw.
304 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
305 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
306 Use 'float' consistently, rather than 'float' in most places
307 and 'double' in a couple of places.
308
efc00ab1 3092012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
310
311 * xdisp.c (handle_stop): Detect whether we have overlay strings
312 loaded by testing it->current.overlay_string_index to be
313 non-negative, instead of checking whether n_overlay_strings is
314 positive. (Bug#11587)
315
efc00ab1 3162012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
317
318 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
319
320 * doc.c (Fsubstitute_command_keys): Doc fix.
321
efc00ab1 3222012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
323
324 * search.c (search_buffer): Remove calls to
325 r_alloc_inhibit_buffer_relocation, as it is now called by
326 maybe_unify_char, which was the cause of relocation of buffer text
327 in bug#11519.
328
efc00ab1 3292012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
330
331 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
332 for the duration of call to load_charset, to avoid problems with
333 callers of maybe_unify_char that access buffer text through C
334 pointers.
335
336 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
337 decrement the inhibition flag, instead of just setting or
338 resetting it.
339
ba93a187
PE
3402012-05-31 Paul Eggert <eggert@cs.ucla.edu>
341
342 Remove obsolete '#define static' cruft.
343 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
344 This #undef was "temporary" in 2000; it is no longer needed
345 now that '#define static' has gone away.
346 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
347 (gray_bitmap_bits): Remove; no longer needed.
348 All uses replaced with definiens.
349 * xterm.c: Include "bitmaps/gray.xbm".
350
9e4bf381
PE
3512012-05-30 Paul Eggert <eggert@cs.ucla.edu>
352
353 Clean up __executable_start, monstartup when --enable-profiling.
354 The following changes affect the code only when profiling.
355 * dispnew.c (__executable_start): Rename from safe_bcopy.
356 Define only on platforms that need it.
357 * emacs.c: Include <sys/gmon.h> when profiling.
358 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
359 (__executable_start): Remove decl, since lisp.h does it now.
360 (safe_bcopy): Remove decl; no longer has that name.
361 (main): Coalesce #if into single bit of code, for simplicity.
362 Cast pointers to uintptr_t, since standard libraries want integers
363 and not pointers.
364 * lisp.h (__executable_start): New decl.
365
32d72c2f
GM
3662012-05-31 Glenn Morris <rgm@gnu.org>
367
368 * image.c (Fimagemagick_types): Doc fix.
369
baac5bc7
JM
3702012-05-30 Jim Meyering <meyering@redhat.com>
371
372 * callproc.c (Fcall_process_region): Include directory component
373 in mkstemp error message (Bug#11586).
374
72cb32cf
PE
3752012-05-30 Paul Eggert <eggert@cs.ucla.edu>
376
377 * alloc.c, lisp.h (make_pure_vector): Now static.
378
61b108cc
SM
3792012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
380
381 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
382 Move to byte-run.el.
383 (Fautoload): Do the hash-doc more carefully.
384 * data.c (Fdefalias): Purify definition, except for keymaps.
385 (Qdefun): Move from eval.c.
386 * lisp.h (Qdefun): Remove.
387 * lread.c (read1): Tiny simplification.
388
471fe23d
TN
3892012-05-29 Troels Nielsen <bn.troels@gmail.com>
390
934f3f58 391 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
392 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
393 Bug#9642, but explicitly check that the buffer the overlay would
394 be moved to is live and rearrange lines to make sure that errors
395 will not put the overlay in an inconsistent state.
396 (Fdelete_overlay): Cosmetics.
397
85d0efd1
EZ
3982012-05-28 Eli Zaretskii <eliz@gnu.org>
399
400 * w32term.c (my_bring_window_to_top): New function.
401 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
402 could be different from the original one.
403 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
404 (Bug#11513)
405
406 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
407 by calling BringWindowToTop.
408
409 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
410 (WM_EMACS_END): Increase by one.
411
da92a98c
PE
4122012-05-28 Paul Eggert <eggert@cs.ucla.edu>
413
414 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
415 This avoids undefined behavior that might cause the eassert
416 to not catch an out-of-range value.
417
74d1f848
JB
4182012-05-28 Juanma Barranquero <lekktu@gmail.com>
419
420 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
421 Update dependencies.
422
9e1a06fc
EZ
4232012-05-27 Eli Zaretskii <eliz@gnu.org>
424
425 * bidi.c (bidi_mirror_char): Fix last change.
426
f3dd7312
AS
4272012-05-27 Andreas Schwab <schwab@linux-m68k.org>
428
429 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
430 when referring to sectname field in printf format.
431
81899c91
PE
4322012-05-27 Paul Eggert <eggert@cs.ucla.edu>
433
57b81a9f
PE
434 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
435 Only r_alloc_inhibit_buffer_relocation needed to be added;
436 the others were already declared.
437
81899c91
PE
438 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
439 before checking whether it's out of range. Put the check inside
440 eassert. See
441 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
442
33017faf 4432012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
444
445 * callproc.c (Fcall_process): Restore a line that was accidentally
446 commented out in the 2011-02-13 change (bug#11547).
447
33017faf 4482012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
449
450 * lisp.h [REL_ALLOC]: Add prototypes for external functions
451 defined on ralloc.c.
452
453 * buffer.c [REL_ALLOC]: Remove prototypes of
454 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
455 they are now on lisp.h.
456
457 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
458
459 * search.c (search_buffer): Use it to inhibit relocation of buffer
460 text while re_search_2 is doing its job, because re_search_2 is
461 passed C pointers to buffer text. (Bug#11519)
462
23415acf
EZ
463 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
464 Update value to 24.
465
44e27368
EZ
466 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
467 state after an additional call to move_it_in_display_line_to, keep
468 the values of it->max_ascent and it->max_descent found for the
469 entire line.
470 (pos_visible_p): Revert the comparison against bottom_y to what it
471 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
472 (Bug#11464)
473
c1892f11
PE
4742012-05-26 Paul Eggert <eggert@cs.ucla.edu>
475
476 Fix coding-related core dumps with gcc -ftrapv.
477 The code was computing A - B, where A and B are pointers, and B is
478 random garbage. This can lead to core dumps on platforms that
479 have special pointer registers, and it also leads to core dumps on
480 x86-64 when compiled with gcc -ftrapv. The fix is to compute
481 A - B only when B is initialized properly.
482 * coding.c (coding_set_source, coding_set_destination): Return void.
483 (coding_change_source, coding_change_destinations): New functions,
484 with the old behaviors of coding_set_source and coding_set_destination.
485 All callers that need an offset changed to use these new functions.
486
eb7afdad
GM
4872012-05-26 Glenn Morris <rgm@gnu.org>
488
489 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
490
f12fdf02
EZ
4912012-05-26 Eli Zaretskii <eliz@gnu.org>
492
53a63be6 493 Extend mouse support on W32 text-mode console.
61b108cc
SM
494 * xdisp.c (draw_row_with_mouse_face):
495 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 496
eb3f6f01 497 * w32console.c: Include window.h.
61b108cc
SM
498 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
499 New functions.
eb3f6f01
EZ
500 (initialize_w32_display): Initialize mouse-highlight data.
501
53a63be6
EZ
502 * w32inevt.c: Include termchar.h and window.h.
503 (do_mouse_event): Support mouse-autoselect-window. When the mouse
504 moves, call note_mouse_highlight. If help_echo changed, call
505 gen_help_event to produce help-echo message in the echo area.
506 Call clear_mouse_face if mouse_face_hidden is set in the mouse
507 highlight info.
508
4cfd81f6
PE
5092012-05-26 Paul Eggert <eggert@cs.ucla.edu>
510
511 * lread.c (read1): Simplify slightly to avoid an overflow warning
512 with GCC 4.7.0 on x86-64.
513
4446092a
EZ
5142012-05-26 Eli Zaretskii <eliz@gnu.org>
515
516 * bidi.c (bidi_mirror_char): Revert last change: an int is
517 definitely wide enough here.
518
42b2a986 5192012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 520
42b2a986 521 Fix integer width and related bugs (Bug#9874).
eb106a49 522 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
523 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
524 (string_bytes, check_sblock, allocate_string_data):
525 (compact_small_strings, Fmake_bool_vector, make_string)
526 (make_unibyte_string, make_multibyte_string)
527 (make_string_from_bytes, make_specified_string)
528 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
529 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
530 (mark_vectorlike):
531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
532 (allocate_pseudovector):
533 Use int, not EMACS_INT, where int is wide enough.
534 (inhibit_garbage_collection, Fgarbage_collect):
535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
536 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
537 int might not be wide enough.
538 (bidi_cache_search, bidi_cache_find, bidi_init_it)
539 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
540 (bidi_at_paragraph_end, bidi_find_paragraph_start)
541 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
542 (bidi_level_of_next_char, bidi_move_to_visually_next):
543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
544 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
545 (Fkill_buffer, Fset_buffer_major_mode)
546 (advance_to_char_boundary, Fbuffer_swap_text)
547 (Fset_buffer_multibyte, overlays_at, overlays_in)
548 (overlay_touches_p, struct sortvec, record_overlay_string)
549 (overlay_strings, recenter_overlay_lists)
550 (adjust_overlays_for_insert, adjust_overlays_for_delete)
551 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
552 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
553 (Foverlay_recenter, last_overlay_modification_hooks_used)
554 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
556 (validate_region): Omit unnecessary test for b <= e,
557 since that's guaranteed by the previous test.
d311d28c
PE
558 (adjust_overlays_for_delete): Avoid pos + length overflow.
559 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
560 (report_overlay_modification):
561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
562 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
563 Omit pointer cast, which isn't needed anyway, and doesn't work
564 after the EMACS_INT -> ptrdiff_t change.
02481186 565 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
566 * buffer.h: Adjust decls to match defn changes elsewhere.
567 (struct buffer_text, struct buffer):
568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
569 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
570 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
571 not int, to avoid needless 32-bit limit on 64-bit hosts.
572 (exec_byte_code): Use tighter memory-full test, one that checks
573 for alloca overflow. Don't compute the address of the object just
574 before an array, as that's not portable. Use EMACS_INT, not
575 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
576 * callint.c (Fcall_interactively):
577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
578 * callproc.c (call_process_kill, Fcall_process):
579 Don't assume pid_t fits into an Emacs fixnum.
580 (call_process_cleanup, Fcall_process, child_setup):
581 Don't assume pid_t fits into int.
582 (call_process_cleanup, Fcall_process, delete_temp_file)
583 (Fcall_process_region):
584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
585 (Fcall_process): Simplify handling of volatile integers.
586 Use int, not EMACS_INT, where int will do.
587 * casefiddle.c (casify_object, casify_region, operate_on_word)
588 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
590 (casify_object): Avoid integer overflow when overallocating buffer.
591 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 592 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
593 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
594 * category.h (CATEGORYP): Don't assume arg is nonnegative.
595 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
596 integers are now checked earlier. All uses replaced with XINT.
597 (ccl_driver):
598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
599 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
600 (ccl_driver, Fregister_code_conversion_map):
601 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
602 (resolve_symbol_ccl_program): Check that vector header is in range.
603 Always copy the vector, so that we can check its contents reliably
604 now rather than having to recheck each instruction as it's being
605 executed. Check that vector words fit in 'int'.
606 (ccl_get_compiled_code, Fregister_ccl_program)
607 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
608 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
609 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
610 contents are in range.
611 (Fccl_execute_on_string): Check that status is in range.
612 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
613 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
614 Accept and return EMACS_INT, not int, because callers can pass values
615 out of 'int' range.
616 (c_string_width, strwidth, lisp_string_width, chars_in_text)
617 (multibyte_chars_in_text, parse_str_as_multibyte)
618 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
619 (str_as_unibyte, str_to_unibyte, string_count_byte8)
620 (string_escape_byte8, Fget_byte):
621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 622 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
623 avoid mishandling large integers.
624 * character.h: Adjust decls to match defn changes elsewhere.
625 * charset.c (load_charset_map_from_file, find_charsets_in_text)
626 (Ffind_charset_region):
627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
628 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
629 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 630 Don't assume fixnum fits in int.
d311d28c
PE
631 (load_charset_map_from_vector, Fmap_charset_chars):
632 Remove now-unnecessary CHECK_NATNUMs.
633 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
634 Don't rely on undefined behavior with signed left shift overflow.
635 Don't assume unsigned int fits into fixnum, or that fixnum fits
636 into unsigned int. Don't require max_code to be a valid fixnum;
637 that's not true for gb10830 4-byte on a 32-bit host. Allow
638 invalid_code to be a cons, for the same reason. Require code_offset
639 to be a character. Avoid int overflow if max_char is close
640 to INT_MAX.
641 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
642 this is intended anyway and avoids some undefined behavior.
643 (load_charset_map): Pass unsigned, not int, as 2nd arg of
644 INDEX_TO_CODE_POINT, as that's what it expects.
645 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
646 * charset.h (DECODE_CHAR): Return int, not unsigned;
647 this is what was intended anyway, and it avoids undefined behavior.
648 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
649 integer-overflow issues.
650 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
651 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
652 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
653 * chartab.c (Fmake_char_table, Fset_char_table_range)
654 (uniprop_get_decoder, uniprop_get_encoder):
655 Don't assume fixnum fits in int.
656 * cmds.c (move_point): New function, that does the gist of
657 Fforward_char and Fbackward_char, but does so while checking
658 for integer overflow more accurately.
c96e5d6a 659 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
660 (Fforward_line, Fend_of_line, internal_self_insert)
661 (internal_self_insert):
662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
663 Fix a FIXME, by checking for integer overflow when calculating
664 target_clm and actual_clm.
665 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 666 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
667 (ASSURE_DESTINATION, coding_alloc_by_realloc)
668 (coding_alloc_by_making_gap, alloc_destination)
669 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
670 (encode_coding_utf_16, detect_coding_emacs_mule)
671 (decode_coding_emacs_mule, encode_coding_emacs_mule)
672 (detect_coding_iso_2022, decode_coding_iso_2022)
673 (encode_invocation_designation, encode_designation_at_bol)
674 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
675 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
676 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
677 (encode_coding_ccl, encode_coding_raw_text)
678 (detect_coding_charset, decode_coding_charset)
679 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
680 (produce_composition, produce_charset, produce_annotation)
681 (decode_coding, handle_composition_annotation)
682 (handle_charset_annotation, consume_chars, decode_coding_gap)
683 (decode_coding_object, encode_coding_object, detect_coding_system)
684 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
685 (code_convert_region, code_convert_string)
8f50130c
PE
686 (Fdefine_coding_system_internal)
687 (coding_set_source, coding_set_destination):
d311d28c
PE
688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
689 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
690 (Fdefine_coding_system_internal):
691 Don't assume fixnums fit in int.
692 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 693 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
694 (Funencodable_char_position, Fcheck_coding_systems_region)
695 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 697 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 698 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 699 Don't access memory outside of the args array.
d311d28c 700 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
701 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
702 result of ENCODE_CHAR.
d311d28c
PE
703 * coding.h: Adjust decls to match defn changes elsewhere.
704 (struct coding_system):
705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
706 * composite.c (get_composition_id, find_composition)
707 (run_composition_function, update_compositions)
708 (compose_text, composition_gstring_put_cache)
709 (composition_gstring_p, composition_gstring_width)
710 (fill_gstring_header, fill_gstring_body, autocmp_chars)
711 (composition_compute_stop_pos, composition_reseat_it)
712 (composition_update_it, struct position_record)
713 (find_automatic_composition, composition_adjust_point)
714 (Fcomposition_get_gstring, Ffind_composition_internal):
715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
716 (update_compositions):
717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
718 * composite.h: Adjust decls to match defn changes elsewhere.
719 (struct composition):
720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
721 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
722 Do not attempt to compute the address of the object just before a
723 buffer; this is not portable.
724 (Faref, Faset):
725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
726 (Faset): Use int, not EMACS_INT, where int is wide enough.
727 (Fstring_to_number): Don't assume fixnums fit in int.
728 (Frem): Don't assume arg is nonnegative.
729 * dbusbind.c (xd_append_arg): Check for integers out of range.
730 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 731 (extract_signed, extract_unsigned): New functions.
243e0530
PE
732 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
733 (xd_get_connection_references): Return ptrdiff_t, not int.
734 All uses changed.
735 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
736 (xd_read_message_1):
737 Use int, not unsigned, where the dbus API uses int.
738 (Fdbus_message_internal): Don't overflow mtype.
739 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
740 * dired.c (directory_files_internal, file_name_completion, scmp)
741 (file_name_completion_stat):
742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
743 (file_name_completion): Don't overflow matchcount.
744 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
745 * dispextern.h: Adjust decls to match defn changes elsewhere.
746 (struct text_pos, struct glyph, struct bidi_saved_info)
747 (struct bidi_string_data, struct bidi_it, struct composition_it)
748 (struct it):
749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
750 (struct display_pos, struct composition_it, struct it):
751 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
752 * dispnew.c (increment_matrix_positions)
753 (increment_row_positions, mode_line_string)
754 (marginal_area_string):
755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 756 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
758 (duration_to_sec_usec): New function, to check for overflow better.
759 (Fsleep_for, sit_for): Use it.
760 * doc.c (get_doc_string, store_function_docstring):
761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
762 (get_doc_string, Fsnarf_documentation):
763 Use int, not EMACS_INT, where int is wide enough.
764 (get_doc_string):
765 Use SAFE_ALLOCA, not alloca.
766 Check for overflow when converting EMACS_INT to off_t.
767 * doprnt.c (doprnt):
768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
769 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
770 Don't assume uid_t fits into fixnum.
771 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
772 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
773 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
774 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
775 (general_insert_function)
776 (Finsert_char, make_buffer_string, make_buffer_string_both)
777 (update_buffer_properties, Fbuffer_substring)
778 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
779 (Fsubst_char_in_region, check_translation)
780 (Ftranslate_region_internal, save_restriction_restore, Fformat)
781 (transpose_markers, Ftranspose_regions):
782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
783 (clip_to_bounds): Move to lisp.h as an inline function).
784 (Fconstrain_to_field): Don't assume integers are nonnegative.
785 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
786 (Fsubst_char_in_region, Fsave_restriction):
787 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
788 (Femacs_pid): Don't assume pid_t fits into fixnum.
789 (lo_time): Use int, not EMACS_INT, when int suffices.
790 (lisp_time_argument): Check for usec out of range.
791 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
792 (Fuser_login_name, Fuser_full_name): Signal an error
793 if a uid argument is out of range, rather than relying on
794 undefined behavior.
c8d5c857
PE
795 (Fformat_time_string): Remove now-unnecessary check.
796 lisp_time_argument checks for out-of-range usec now.
243e0530 797 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
798 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
799 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
800 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
801 (init_cmdargs, Fdump_emacs):
802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
803 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
804 the bottom (typically) 32 bits of the fixnum.
805 * eval.c (specpdl_size, call_debugger):
806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
807 (when_entered_debugger, Fbacktrace_debug):
808 Don't assume fixnum can fit in int.
809 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
810 the object just before a buffer; this is not portable.
811 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
812 (grow_specpdl, unbind_to):
813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
814 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
815 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 816 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
817 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
818 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
820 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
821 (a_write, e_write):
822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
823 (Fcopy_file, non_regular_nbytes, read_non_regular)
824 (Finsert_file_contents):
825 Use int, not EMACS_INT, where int is wide enough.
826 (READ_BUF_SIZE): Verify that it fits in int.
827 (Finsert_file_contents): Check that counts are in proper range,
828 rather than assuming fixnums fit into ptrdiff_t etc.
829 Don't assume fixnums fit into int.
125b3835 830 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
831 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
832 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
833 (string_char_to_byte, string_byte_to_char)
834 (string_make_multibyte, string_to_multibyte)
835 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
836 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
837 (substring_both, Fdelete, internal_equal, Ffillarray)
838 (Fclear_string, mapcar1)
839 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
840 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
841 (larger_vector, make_hash_table, maybe_resize_hash_table)
842 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
843 (Fmaphash, secure_hash):
844 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
845 (concat): Check for string index and length overflow.
846 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
847 (Frequire):
848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
849 (larger_vector): New API (vec, incr_min, size_max) replaces old
850 one (vec, new_size, init). This catches size overflow.
851 INIT was removed because it was always Qnil.
852 All callers changed.
853 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
854 the upper bound on a hash table index size.
855 (make_hash_table, maybe_resize_hash_table): Use it.
856 (secure_hash): Computer start_byte and end_byte only after
857 they're known to be in ptrdiff_t range.
858 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
859 (Ffont_get_glyphs, Ffont_at):
860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
861 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
862 (Flist_fonts, Fopen_font):
863 Don't assume fixnum can fit in int.
864 (check_gstring): Don't assume index can fit in int.
865 (font_match_p): Check that fixnum is a character, not a nonnegative
866 fixnum, since the later code needs to stuff it into an int.
867 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
868 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
869 conversion overflow issues.
870 (Fopen_font): Check for integer out of range.
871 (Ffont_get_glyphs): Don't assume index can fit in int.
872 * font.h: Adjust decls to match defn changes elsewhere.
873 * fontset.c (reorder_font_vector): Redo score calculation to avoid
874 integer overflow.
875 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
876 printmax_t, where ptrdiff_t is wide enough.
877 (Finternal_char_font):
878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
879 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
880 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
881 (Fset_frame_position, x_set_frame_parameters)
882 (x_set_line_spacing, x_set_border_width)
883 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
884 Check that fixnums are in proper range for system types.
885 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
887 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
888 Use SAFE_ALLOCA_LISP, not alloca.
889 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
890 intptr_t is wide enough.
891 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
892 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
893 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
894 Check for fixnum out of range.
895 * ftfont.c (ftfont_list): Don't assume index fits in int.
896 Check that fixnums are in proper range for system types.
897 (ftfont_shape_by_flt):
898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
899 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
901 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
902 Check that fixnums are in proper range for system types.
903 * gnutls.h: Adjust decls to match defn changes elsewhere.
904 * gtkutil.c (xg_dialog_run):
905 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
906 (update_frame_tool_bar):
907 Check that fixnums are in proper range for system types.
908 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 909 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
910 * indent.c (last_known_column, last_known_column_point):
911 (current_column_bol_cache):
912 (skip_invisible, current_column, check_display_width):
913 (check_display_width, scan_for_column, current_column_1)
914 (Findent_to, Fcurrent_indentation, position_indentation)
915 (indented_beyond_p, Fmove_to_column, compute_motion):
916 (Fcompute_motion, Fvertical_motion):
917 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
918 (last_known_column_modified): Use EMACS_INT, not int.
919 (check_display_width):
920 (Fcompute_motion):
921 Check that fixnums and floats are in proper range for system types.
922 (compute_motion): Don't assume index or fixnum fits in int.
923 (compute_motion, Fcompute_motion):
924 Use int, not EMACS_INT, when it is wide enough.
925 (vmotion): Omit local var start_hpos that is always 0; that way
926 we don't need to worry about overflow in expressions involving it.
927 * indent.h: Adjust decls to match defn changes elsewhere.
928 (struct position):
929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
930 Use int, not EMACS_INT, where int is wide enough.
931 Remove unused members ovstring_chars_done and tab_offset;
932 all uses removed.
933 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
934 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
935 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
936 (make_gap, copy_text, insert, insert_and_inherit)
937 (insert_before_markers, insert_before_markers_and_inherit)
938 (insert_1, count_combining_before, count_combining_after)
939 (insert_1_both, insert_from_string)
940 (insert_from_string_before_markers, insert_from_string_1)
941 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
942 (adjust_after_replace, adjust_after_insert, replace_range)
943 (replace_range_2, del_range, del_range_1, del_range_byte)
944 (del_range_both, del_range_2, modify_region)
945 (prepare_to_modify_buffer, signal_before_change)
946 (signal_after_change, Fcombine_after_change_execute):
947 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
948 * intervals.c (traverse_intervals, rotate_right, rotate_left)
949 (balance_an_interval, split_interval_right, split_interval_left)
950 (find_interval, next_interval, update_interval)
951 (adjust_intervals_for_insertion, delete_node, delete_interval)
952 (interval_deletion_adjustment, adjust_intervals_for_deletion)
953 (static_offset_intervals, offset_intervals)
954 (merge_interval_right, merge_interval_left, make_new_interval)
955 (graft_intervals_into_buffer, temp_set_point_both)
956 (temp_set_point, set_point, adjust_for_invis_intang)
957 (set_point_both, move_if_not_intangible, get_property_and_range)
958 (get_local_map, copy_intervals, copy_intervals_to_string)
959 (compare_string_intervals, set_intervals_multibyte_1):
960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
961 * intervals.h: Adjust decls to match defn changes elsewhere.
962 (struct interval):
963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
964 * keyboard.c (this_command_key_count, this_single_command_key_start)
965 (before_command_key_count, before_command_echo_length, echo_now)
966 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
967 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
968 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
969 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
970 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
971 (last_non_minibuf_size, last_point_position, echo_truncate)
972 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
973 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
974 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
975 (stuff_buffered_input):
976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977 (last_auto_save, command_loop_1, read_char):
978 Use EMACS_INT, not int, to avoid integer overflow.
979 (record_char): Avoid overflow in total_keys computation.
980 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
981 * keyboard.h: Adjust decls to match defn changes elsewhere.
982 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
983 (Fkey_description, Fdescribe_vector, Flookup_key):
984 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
985 (click_position): New function, to check that positions are in range.
986 (Fcurrent_active_maps):
987 (describe_command):
988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
989 (Faccessible_keymaps, Fkey_description):
990 (preferred_sequence_p):
991 Don't assume fixnum can fit into int.
992 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
993 Check for integer overflow in size calculations.
994 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
995 avoid mishandling large integers.
996 * lisp.h: Adjust decls to match defn changes elsewhere.
997 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
998 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
999 (struct Lisp_Marker):
1000 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1001 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1002 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1003 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1004 All callers changed.
1005 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1006 Assume the arg has valid form, since it always does.
1007 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1008 unsigned integer system type.
1009 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1010 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1012 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1013 (duration_to_sec_usec): New decl.
1014 * lread.c (read_from_string_index, read_from_string_index_byte)
1015 (read_from_string_limit, readchar, unreadchar, openp)
1016 (read_internal_start, read1, oblookup):
1017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1018 (Fload, readevalloop, Feval_buffer, Feval_region):
1019 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1020 (openp): Check for out-of-range argument to 'access'.
1021 (read1): Use int, not EMACS_INT, where int is wide enough.
1022 Don't assume fixnum fits into int.
6efdadfd 1023 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1024 (read_filtered_event): Use duration_to_sec_usec
1025 to do proper overflow checking on durations.
d311d28c
PE
1026 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1027 in size calculation.
1028 (Fexecute_kbd_macro):
1029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1030 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1031 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1032 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1033 (set_marker_both, set_marker_restricted_both, marker_position)
1034 (marker_byte_position, Fbuffer_has_markers_at):
1035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1036 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1037 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1038 It now merely ensures that the menu is large enough, without
1039 necessarily growing it, as this avoids some integer overflow issues.
1040 All callers changed.
1041 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1043 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1044 Use SAFE_ALLOCA_LISP, not alloca.
1045 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1046 to EMACS_INT. Check that fixnums are in proper range for system types.
1047 * minibuf.c (minibuf_prompt_width, string_to_object)
1048 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1049 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1050 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1051 (get_minibuffer, read_minibuf_unwind):
1052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1053 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1054 this simplifies overflow checking. All callers changed.
1055 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1056 (Ftest_completion):
1057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1058 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1059 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1060 Check that fixnums are in proper range for system types.
1061 (Fx_create_frame, Fx_show_tip):
1062 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1063 * nsfont.m (ns_findfonts, nsfont_list_family):
1064 Don't assume fixnum fits in long.
1065 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1067 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1068 wide enough.
17fdb222 1069 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1070 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1071 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1072 (PRINTDECLARE, PRINTPREPARE):
1073 (strout, print_string):
1074 (print, print_preprocess, print_check_string_charset_prop)
1075 (print_object):
1076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1077 (PRINTDECLARE):
1078 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1079 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1080 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1081 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1082 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1083 (print_error_message): Use SAFE_ALLOCA, not alloca.
1084 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1085 (print_depth, new_backquote_output, print_number_index):
1086 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1087 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1088 (Fset_process_window_size, Fformat_network_address)
1089 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1090 (sigchld_handler):
d311d28c 1091 Check that fixnums are in proper range for system types.
d44287d4 1092 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1093 Check for process-ids out of pid_t range rather than relying on
1094 undefined behavior.
e4d81efc 1095 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1096 (Fformat_network_address, read_process_output, send_process)
1097 (Fprocess_send_region, status_notify):
1098 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1099 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1100 (wait_reading_process_output, read_process_output, exec_sentinel):
1101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1102 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1103 (Faccept_process_output): Use duration_to_sec_usec to do proper
1104 overflow checking on durations.
dde14581
PE
1105 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1106 Don't assume pid_t fits in int.
02481186
PE
1107 * process.h (struct Lisp_Process): Members tick and update_tick
1108 are now of type EMACS_INT, not int.
b62b53e8
PE
1109 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1110 configured --with-wide-int.
d311d28c
PE
1111 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1112 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1113 * search.c (looking_at_1, string_match_1):
1114 (fast_string_match, fast_c_string_match_ignore_case)
1115 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1116 (scan_newline, find_before_next_newline, search_command)
1117 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1118 (set_search_regs, wordify):
1119 (Freplace_match):
1120 (Fmatch_data):
1121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1122 (string_match_1, search_buffer, set_search_regs):
1123 (Fmatch_data):
1124 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1125 (wordify): Check for overflow in size calculation.
1126 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1127 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1128 Check that fixnums are in proper range for system types.
1129 * sound.c (struct sound_device)
1130 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1131 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1132 (Fplay_sound_internal):
1133 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1134 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1135 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1136 (Fparse_partial_sexp):
1137 Don't assume fixnums can fit in int.
1138 (struct lisp_parse_state, find_start_pos, find_start_value)
1139 (find_start_value_byte, find_start_begv)
1140 (update_syntax_table, char_quoted, dec_bytepos)
1141 (find_defun_start, prev_char_comend_first, back_comment):
1142 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1143 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1145 (Finternal_describe_syntax_value): Check that match_lisp is a
1146 character, not an integer, since the code stuffs it into int.
1147 (scan_words, scan_sexps_forward):
1148 Check that fixnums are in proper range for system types.
1149 (Fforward_word):
1150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1151 (scan_sexps_forward):
1152 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1153 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1154 * syntax.h: Adjust decls to match defn changes elsewhere.
1155 (struct gl_state_s):
1156 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1157 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1158 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1159 * sysdep.c (wait_for_termination_1, wait_for_termination)
1160 (interruptible_wait_for_termination, mkdir):
1161 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1162 (emacs_read, emacs_write):
1163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1164 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1165 and double all fit in int.
d311d28c
PE
1166 * term.c (set_tty_color_mode):
1167 Check that fixnums are in proper range for system types.
1168 * termhooks.h (struct input_event):
1169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1170 * textprop.c (validate_interval_range, interval_of)
1171 (Fadd_text_properties, set_text_properties_1)
1172 (Fremove_text_properties, Fremove_list_of_text_properties)
1173 (Ftext_property_any, Ftext_property_not_all)
1174 (copy_text_properties, text_property_list, extend_property_ranges)
1175 (verify_interval_modification):
1176 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1177 (Fnext_single_char_property_change)
1178 (Fprevious_single_char_property_change):
1179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1180 (copy_text_properties):
1181 Check for integer overflow in index calculation.
d311d28c
PE
1182 * undo.c (last_boundary_position, record_point, record_insert)
1183 (record_delete, record_marker_adjustment, record_change)
1184 (record_property_change):
1185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1186 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1188 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1189 (Fx_hide_tip, Fx_file_dialog):
1190 * w32menu.c (set_frame_menubar):
1191 Use ptrdiff_t, not int, for consistency with rest of code.
1192 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1193 (select_window, Fdelete_other_windows_internal)
1194 (window_scroll_pixel_based, window_scroll_line_based)
1195 (Frecenter, Fset_window_configuration):
1196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1197 (Fset_window_hscroll, run_window_configuration_change_hook)
1198 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1199 (Fscroll_other_window, Frecenter):
d311d28c
PE
1200 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1201 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1202 Don't assume fixnum fits in int.
1203 (Fset_window_scroll_bars):
1204 Check that fixnums are in proper range for system types.
1205 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1206 (string_pos, c_string_pos, number_of_chars, init_iterator)
1207 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1208 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1209 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1210 (face_before_or_after_it_pos, handle_invisible_prop)
1211 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1212 (display_prop_intangible_p, string_buffer_position_lim)
1213 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1214 (get_overlay_strings_1, get_overlay_strings)
1215 (iterate_out_of_display_property, forward_to_next_line_start)
1216 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1217 (get_next_display_element, set_iterator_to_next)
1218 (get_visually_first_element, compute_stop_pos_backwards)
1219 (handle_stop_backwards, next_element_from_buffer)
1220 (move_it_in_display_line_to, move_it_in_display_line)
1221 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1222 (add_to_log, message_dolog, message_log_check_duplicate)
1223 (message2, message2_nolog, message3, message3_nolog
1224 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1225 (current_message_1, truncate_echo_area, truncate_message_1)
1226 (set_message, set_message_1, store_mode_line_noprop)
1227 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1228 (text_outside_line_unchanged_p, check_point_in_composition)
1229 (reconsider_clip_changes)
1230 (redisplay_internal, set_cursor_from_row, try_scrolling)
1231 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1232 (redisplay_window, find_last_unchanged_at_beg_row)
1233 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1234 (trailing_whitespace_p, find_row_edges, display_line)
1235 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1236 (display_mode_element, store_mode_line_string)
1237 (pint2str, pint2hrstr, decode_mode_spec)
1238 (display_count_lines, display_string, draw_glyphs)
1239 (x_produce_glyphs, x_insert_glyphs)
1240 (rows_from_pos_range, mouse_face_from_buffer_pos)
1241 (fast_find_string_pos, mouse_face_from_string_pos)
1242 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1243 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1244 (safe_call, init_from_display_pos, handle_fontified_prop)
1245 (handle_single_display_spec, load_overlay_strings)
1246 (with_echo_area_buffer, setup_echo_area_for_printing)
1247 (display_echo_area, echo_area_display)
1248 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1249 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1250 (redisplay_window, dump_glyph_row, display_mode_line)
1251 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1252 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1253 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1254 (handle_single_display_spec, build_desired_tool_bar_string)
1255 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1256 (get_specified_cursor_type):
1257 Check that fixnums are in proper range for system types.
1258 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1259 (Flookup_image_map):
1260 Don't assume fixnums fit in int.
1261 (compare_overlay_entries):
1262 Avoid mishandling comparisons due to subtraction overflow.
1263 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1264 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1265 (handle_tool_bar_click):
1266 Use int, not unsigned, since we prefer signed and the signedness
1267 doesn't matter here.
1268 (get_next_display_element, next_element_from_display_vector):
1269 Use int, not EMACS_INT, when int is wide enough.
1270 (start_hourglass): Use duration_to_sec_usec to do proper
1271 overflow checking on durations.
1272 * xfaces.c (Fbitmap_spec_p):
1273 Check that fixnums are in proper range for system types.
1274 (compare_fonts_by_sort_order):
1275 Avoid mishandling comparisons due to subtraction overflow.
1276 (Fx_family_fonts, realize_basic_faces):
1277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1278 (Fx_family_fonts):
1279 Don't assume fixnum fits in int.
1280 Use SAFE_ALLOCA_LISP, not alloca.
1281 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1282 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1283 (face_at_buffer_position, face_for_overlay_string)
1284 (face_at_string_position):
1285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1286 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1287 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1288 (Fx_show_tip):
1289 Check that fixnums are in proper range for system types.
1290 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1291 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1293 (Fx_change_window_property): Don't assume fixnums fit in int.
1294 * xfont.c (xfont_chars_supported):
1295 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1296 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1297 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1298 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1299 * xml.c (parse_region):
1300 * xrdb.c (magic_file_p):
1301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1302 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1303 (x_get_local_selection, x_reply_selection_request)
1304 (x_handle_selection_request, wait_for_property_change):
1305 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1306 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1307 short is wide enough.
1308 (x_send_client_event): Don't assume fixnum fits in int.
1309 * xterm.c (x_x_to_emacs_modifiers):
1310 Don't assume EMACS_INT overflows nicely into int.
1311 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1312 may come from Lisp.
1313 (handle_one_xevent): NATNUMP can eval its arg twice.
1314 (x_connection_closed):
1315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1316 * xterm.h: Adjust decls to match defn changes elsewhere.
1317 (struct scroll_bar): Use struct vectorlike_header
1318 rather than rolling our own approximation.
1319 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1320
c6574eb5
GM
13212012-05-25 Glenn Morris <rgm@gnu.org>
1322
1323 * lisp.mk (lisp): Update for more files being compiled now.
1324
e8d32c7e
SM
13252012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1326
48def666
SM
1327 * lread.c: Remove `read_pure' which makes no difference.
1328 (read_pure): Remove var.
1329 (unreadpure): Remove function.
1330 (readevalloop): Don't call read_list with -1 flag.
1331 (read1, read_vector): Don't test read_pure any more.
1332 (read_list): Simplify.
1333
e8d32c7e
SM
1334 * fileio.c, character.h: Minor style tweaks.
1335
4b2addb7
DA
13362012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1337
1338 * window.h (clip_changed): Remove useless declaration.
1339
584461b2
JB
13402012-05-22 Juanma Barranquero <lekktu@gmail.com>
1341
1342 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1343 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1344
34374650
PE
13452012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1346
1347 Remove src/m/*.
1348 This directory predates autoconf and is no longer needed nowadays.
1349 Move its few remaining bits of functionality to where they're needed.
1350 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1351 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1352 * m/template.h: Remove.
1353 * Makefile.in (M_FILE): Remove. All uses removed.
1354 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1355 * lisp.h (USE_LSB_TAG):
1356 * mem-limits.h (EXCEEDS_LISP_PTR):
1357 Use VAL_MAX, not VALBITS, in #if.
1358 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1359 (EMACS_UINT): Define unconditionally now.
1360 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1361 (BITS_PER_EMACS_INT): New constants, replacing
1362 what used to be in config.h, but not useful in #if.
1363 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1364 define them any more.
1365 (VAL_MAX): New macro.
1366 (VALMASK): Use it.
1367 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1368 BITS_PER_EMACS_INT, in #if.
1369 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1370 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1371 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1372 * s/ms-w32.h (DATA_START):
1373 Move here from removed file m/intel386.h.
1374 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1375 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1376
261cb4bb
PE
13772012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1378
1379 Assume C89 or later.
1380 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1381 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1382 (xrealloc):
1383 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1384 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1385 * textprop.c, tparam.c (NULL): Remove.
1386 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1387 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1388 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1389 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1390 * xterm.c (input_signal_count): Assume volatile works.
1391
ff23cd9f
KB
13922012-05-21 Ken Brown <kbrown@cornell.edu>
1393
1394 * xgselect.c (xg_select): Fix first argument in call to 'select'
1395 (bug#11508).
1396
1b170bc6
KB
13972012-05-20 Ken Brown <kbrown@cornell.edu>
1398
1399 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1400 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1401
b2f4d39f
KB
14022012-05-19 Ken Brown <kbrown@cornell.edu>
1403
1404 * xfns.c (x_in_use): Remove `static' qualifier.
1405 * xterm.h (x_in_use): Declare.
1406 * xgselect.c: Include xterm.h.
1407 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1408 and `display_arg' (bug#9754).
1409
003fdae2
PE
14102012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1411
9232a6d9
PE
1412 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1413
003fdae2
PE
1414 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1415 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1416
784b56e2
EZ
14172012-05-18 Eli Zaretskii <eliz@gnu.org>
1418
1419 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1420
1421 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1422 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1423
1424 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1425 reference to image_cache->refcount.
1426 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1427
a0a79cde
JL
14282012-05-17 Juri Linkov <juri@jurta.org>
1429
1430 * search.c (Fword_search_regexp, Fword_search_backward)
1431 (Fword_search_forward, Fword_search_backward_lax)
1432 (Fword_search_forward_lax): Move functions to isearch.el
1433 (bug#10145, bug#11381).
1434
b0572523
PE
14352012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1438
9660f5fc
SM
14392012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1440
1441 * lread.c (init_obarray): Declare Qt and Qnil as special.
1442
4374de83
GM
14432012-05-14 Glenn Morris <rgm@gnu.org>
1444
1445 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1446 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1447
dc44c39a
PE
14482012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1449
078c97cb
PE
1450 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1451
dc44c39a
PE
1452 * unexaix.c: Port to more-recent AIX compilers.
1453 (report_error, report_error_1, make_hdr, copy_sym)
1454 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1455 Make arguments const char *, not char *, to avoid violations of C
1456 standard and to fix some AIX warnings reported by Gilles Pion.
1457
e18afed7 14582012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1459
1460 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1461 already have overlays loaded.
1462 (handle_single_display_spec): Before returning without displaying
1463 fringe bitmap, synchronize the bidi iterator with the main display
1464 iterator, by calling iterate_out_of_display_property.
1465 (iterate_out_of_display_property): Detect buffer iteration by
1466 testing that it->string is a Lisp string.
1467 (get_next_display_element): When the current object is exhausted,
1468 and there's something on it->stack, call set_iterator_to_next to
1469 proceed with what's on the stack, instead of returning zero.
1470 (set_iterator_to_next): If called at the end of a Lisp string,
1471 proceed to consider_string_end without incrementing string
1472 position. Don't increment display vector index past the end of
1473 the display vector. (Bug#11417)
c8fb9dc6
EZ
1474 (pos_visible_p): Don't report a position visible when move_it_to
1475 stopped at the last line of window, which happens to be scanned
1476 backwards by the bidi iteration. (Bug#11464)
ac268e67 1477
e18afed7 14782012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1479
1480 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1481 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1482 are on a TTY, and thus unable to display on the fringes.
1483 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1484 so we need to signal to the caller that this is a "replacing"
1485 display spec. This fixes display when the spec is invalid or we
1486 are on a TTY.
1487
e18afed7 14882012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1489
1490 * unexaix.c (make_hdr): Fix typo in prototype.
1491 This bug broke the build on AIX. Problem reported by Gilles Pion.
1492
9d0a235a
MA
14932012-05-14 Michael Albinus <michael.albinus@gmx.de>
1494
1495 * keyboard.c (kbd_buffer_get_event): Read special events also in
1496 batch mode. (Bug#11415)
1497
9e6b06ed
GM
14982012-05-12 Glenn Morris <rgm@gnu.org>
1499
1500 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1501
c1a1d7a3
EZ
15022012-05-12 Eli Zaretskii <eliz@gnu.org>
1503
1504 * lisp.mk (lisp): Add newcomment.elc.
1505
3fe7cdc8
GM
15062012-05-12 Glenn Morris <rgm@gnu.org>
1507
1508 * Makefile.in (MKDIR_P): New, set by configure.
1509 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1510
53f7d2c0
PE
15112012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1512
1513 Remove unused function hourglass_started.
1514 * dispextern.h (hourglass_started):
1515 * w32fns.c (hourglass_started):
1516 * xdisp.c (hourglass_started): Remove.
1517
75aafb17
JB
15182012-05-10 Juanma Barranquero <lekktu@gmail.com>
1519
1520 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1521 Update dependencies.
1522
12959e8e
PE
15232012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1524
97107e2e
PE
1525 * xgselect.c (xg_select): Put maxfds+1 into a var.
1526 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1527
12959e8e
PE
1528 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1529
836d29b3
DA
15302012-05-10 Dave Abrahams <dave@boostpro.com>
1531
1532 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1533 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1534
5cb67954
MA
15352012-05-09 Michael Albinus <michael.albinus@gmx.de>
1536
1537 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1538 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1539 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1540 Initialize xd_registered_buses.
1541
3478ec45
PE
15422012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1543
b263a6b0
PE
1544 Untag more efficiently if USE_LSB_TAG.
1545 This is based on a proposal by YAMAMOTO Mitsuharu in
1546 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1547 For an admittedly artificial (nth 8000 longlist) benchmark on
1548 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1549 Emacs's overall text size by 1%.
1550 * lisp.h (XUNTAG): New macro.
1551 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1552 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1553 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1554 * eval.c (Fautoload):
1555 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1556 * frame.h (XFRAME): Use XUNTAG.
1557
3478ec45
PE
1558 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1559 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1560 Remove unportable assumptions about print widths of types like
1561 dbus_uint32_t.
1562 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1563 intptr_t when converting between pointer and integer, to avoid GCC
1564 warnings about wrong width.
1565
666b903b 15662012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1567
1568 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1569 stack for each reader_thread, instead of defaulting to 8MB
1570 determined by the linker. This avoids failures in creating
1571 subprocesses on Windows 7, see the discussion in this thread:
1572 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1573
b120cc17
JC
15742012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1575
1576 Fix up display of the *Minibuf-0* buffer in the mini window.
1577 * keyboard.c (read_char): Don't clear the echo area if there's no
1578 message to clear.
1579 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1580 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1581
9a4b36f8
MA
15822012-05-07 Michael Albinus <michael.albinus@gmx.de>
1583
1584 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1585 batch mode.
1586
e5f9458f
CY
15872012-05-06 Chong Yidong <cyd@gnu.org>
1588
1589 * lisp.mk (lisp): Update.
1590
eceeb5fc 15912012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1592
1593 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1594
71873e2b
SM
15952012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1596
1597 * data.c (PUT_ERROR): New macro.
1598 (syms_of_data): Use it. Add new error type `user-error'.
1599 * undo.c (user_error): New function.
1600 (Fprimitive_undo): Use it.
1601 * print.c (print_error_message): Adjust print style for `user-error'.
1602 * keyboard.c (user_error): New function.
1603 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1604
ab0fa4e4
PE
16052012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1606
1607 Do not limit current-time-string to years 1000..9999.
1608 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1609 (Fcurrent_time_string): Support any year that is supported by the
1610 underlying localtime representation. Don't use asctime, as it
1611 has undefined behavior for years outside the range -999..9999.
1612
7ed806a7
PE
16132012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1614
1615 Fix race conditions involving setenv, gmtime, localtime, asctime.
1616 Without this fix, interrupts could mess up code that uses these
1617 nonreentrant functions, since setting TZ invalidates existing
1618 tm_zone or tzname values, and since most of these functions return
1619 pointers to static storage.
1620 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1621 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1622 Grow the critical sections to include not just invoking
1623 localtime/gmtime, but also accessing these functions' results
1624 including their tm_zone values if any, and any related TZ setting.
1625 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1626 so that the struct tm is saved in the critical section.
1627 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1628 motivated by the fact that memory allocation needs to be outside
1629 the critical section.
1630
0c16dfed
DA
16312012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1632
1633 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1634 with RESET_INTERVAL.
1635
1636 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1637 Remove duplicated buffer name initialization.
1638
3f83ace8
JM
16392012-05-02 Jim Meyering <jim@meyering.net>
1640
1641 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1642
c7b8541e
JM
1643 * xfns.c (x_window): Use xstrdup (Bug#11375).
1644
90207a15 16452012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1646
1647 * xdisp.c (pos_visible_p): If already at a newline from the
1648 display string before the 'while' loop, don't walk back the glyphs
1649 from it3.glyph_row. Solves assertion violation when the display
1650 string begins with a newline (egg.el). (Bug#11367)
1651
b593d6a9
AH
16522012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1653
1654 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1655 Move to simple.el.
1656
4737362e
GM
16572012-05-01 Glenn Morris <rgm@gnu.org>
1658
99cf43f9
GM
1659 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1660 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1661 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1662 All were removed before 23.1.
1663
9311dcff
GM
1664 * dispnew.c: Remove HAVE_LIBNCURSES test;
1665 it is always true on relevant platforms.
1666
4d5c6349
GM
1667 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1668 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1669
4737362e
GM
1670 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1671
74dd3a6b
AS
16722012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1673
1674 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1675 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1676 Remove.
1677
13c379ee
PE
16782012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1679
1680 Do not avoid creating empty evaporating overlays (Bug#9642).
1681 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1682 That is, do not delete an evaporating overlay if it becomes
1683 empty after its bounds are adjusted to fit within its buffer.
1684 This fix caused other problems, and I'm reverting it until we get
1685 to the bottom of them.
1686
a8e7d6d7 16872012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1688
1689 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1690
a8e7d6d7 16912012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1692
1693 * xdisp.c (pos_visible_p): If the window start position is beyond
1694 ZV, start the display from buffer beginning. Prevents assertion
1695 violation in init_iterator when the minibuffer window is scrolled
1696 via the scroll bar.
1697
1698 * window.c (window_scroll_pixel_based): Likewise.
1699
a8e7d6d7 17002012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1701
1702 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1703
a8e7d6d7 17042012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1705
1706 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1707 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1708
a8e7d6d7 17092012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1710
b593d6a9
AH
1711 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1712 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1713
1c6900d9
EZ
17142012-04-26 Eli Zaretskii <eliz@gnu.org>
1715
4c3fa1d9
EZ
1716 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1717 display element, check also the underlying string or buffer
1718 character. (Bug#11341)
1719
1c6900d9
EZ
1720 * w32menu.c: Include w32heap.h.
1721 (add_menu_item): If the call to AppendMenuW (via
1722 unicode_append_menu) fails, disable Unicode menus only if we are
1723 running on Windows 9X/Me.
1724
42bf8205
AS
17252012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1726
1727 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1728 (xgetint): Add missing shift for LSB tags.
1729
b1bac16e
MR
17302012-04-24 Martin Rudalics <rudalics@gmx.at>
1731
1732 * keyboard.c (read_char): Don't wipe echo area for select window
1733 events: These might get delayed via `mouse-autoselect-window'
1734 (Bug#11304).
1735
d69621cc
JB
17362012-04-24 Juanma Barranquero <lekktu@gmail.com>
1737
1738 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1739 manipulation of :loaded-from data.
1740
02fd101b
JB
17412012-04-23 Juanma Barranquero <lekktu@gmail.com>
1742
1743 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1744 now a cons (bug#11311).
1745
888bec30
PE
17462012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1747
89a438bd
PE
1748 Do not create empty overlays with the evaporate property (Bug#9642).
1749 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1750 if it becomes empty after its bounds are adjusted to fit within
1751 its buffer. Without this fix, in a nonempty buffer (let ((o
1752 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1753 yields an empty overlay that has the evaporate property, which is
1754 not supposed to happen.
1755
1068fe4d
PE
1756 Fix minor GTK3 problems found by static checking.
1757 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1758 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1759 (struct _EmacsFixedClass, emacs_fixed_get_type):
1760 Move decls here from emacsgtkfixed.h, since they needn't be public.
1761 (emacs_fixed_get_type): Now static.
1762 (emacs_fixed_class_init): Omit unused local.
1763 (emacs_fixed_child_type): Remove; unused.
1764 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1765 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1766 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1767 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1768 (EMACS_FIXED_GET_CLASS): Remove; unused.
1769 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1770
888bec30
PE
1771 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1772 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1773
de85e130
PE
17742012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1775
d0baac98 1776 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1777 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1778 (__malloc_size_t, __malloc_ptrdiff_t):
1779 Remove. All uses removed, replaced by the definiens if needed,
1780 since we can assume C89 or better now.
1781 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1782 (protect_malloc_state, align, get_contiguous_space)
1783 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1784 (malloc_atfork_handler_child, malloc_enable_thread)
1785 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1786 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1787 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1788 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1789 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1790 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1791 Define using prototypes, not old style.
1792 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1793 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1794 (align): Don't assume that signed integer overflow wraps around.
1795 Omit unused local var.
1796 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1797 (_free_internal_nolock, memalign, mallochook, reallochook):
1798 Omit no-longer-needed casts.
1799 (valloc): Use getpagesize, not __getpagesize.
1800 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1801 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1802
de85e130
PE
1803 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1804
dcbf5805
MA
18052012-04-22 Michael Albinus <michael.albinus@gmx.de>
1806
1807 Move functions from C to Lisp. Make non-blocking method calls
1808 the default. Implement further D-Bus standard interfaces.
1809
1810 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1811 (QCdbus_request_name_allow_replacement)
1812 (QCdbus_request_name_replace_existing)
1813 (QCdbus_request_name_do_not_queue)
1814 (QCdbus_request_name_reply_primary_owner)
1815 (QCdbus_request_name_reply_in_queue)
1816 (QCdbus_request_name_reply_exists)
1817 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1818 (QCdbus_registered_serial, QCdbus_registered_method)
1819 (QCdbus_registered_signal): New Lisp objects.
1820 (XD_DEBUG_MESSAGE): Use sizeof.
1821 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1822 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1823 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1824 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1825 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1826 (xd_signature, xd_append_arg): Allow float for integer types.
1827 (xd_get_connection_references): New function.
b593d6a9
AH
1828 (xd_get_connection_address): Rename from xd_initialize.
1829 Return cached address.
dcbf5805
MA
1830 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1831 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1832 level.
1833 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1834 Return number of refcounts.
dcbf5805
MA
1835 (Fdbus_get_unique_name): Make stronger parameter check.
1836 (Fdbus_message_internal): New defun.
1837 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1838 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1839 (Fdbus_send_signal, Fdbus_register_service)
1840 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1841 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1842 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1843 (Vdbus_compiled_version, Vdbus_runtime_version)
1844 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1845 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1846 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1847 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1848 Adapt docstring.
dcbf5805 1849
52828e02
PE
18502012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1851
da05bc4c
PE
1852 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1853 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1854 Do not assume ptrdiff_t is the same width as 'int'.
1855
52828e02
PE
1856 * alloc.c: Handle unusual debugging option combinations.
1857 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1858 since the two debugging options are incompatible.
1859 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1860 is defined.
1861 (mem_init, mem_insert, mem_insert_fixup):
1862 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1863 (NEED_MEM_INSERT): Remove; no longer needed.
1864
f01769f9
LL
18652012-04-22 Leo Liu <sdl.web@gmail.com>
1866
1867 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1868
5790543d
PE
18692012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1870
1871 * sysdep.c [__FreeBSD__]: Minor cleanups.
1872 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1873 Use Emacs indenting style more consistently. Avoid some casts.
1874 Use 'double' consistently rather than mixing 'float' and 'double'.
1875
b91b7e4d
EW
18762012-04-21 Eduard Wiebe <usenet@pusto.de>
1877
b593d6a9
AH
1878 * sysdep.c (list_system_processes, system_process_attributes):
1879 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1880
6114eb15
AS
18812012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1882
1883 * lisp.mk (lisp): Update.
1884
2f38dff7
PE
18852012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1886
1887 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1888 It is never used otherwise.
1889
4ae29f89
SM
18902012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1891
1892 * print.c (print_preprocess): Only check print_depth if print-circle
1893 is nil.
1894 (print_object): Check for cycles even when print-circle is nil and
1895 print-gensym is t, but only check print_depth if print-circle is nil.
1896
f30d612a
CY
18972012-04-20 Chong Yidong <cyd@gnu.org>
1898
1899 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1900 set the status to "failed" and ensure that sentinel is run.
1901
c07a4c0b 19022012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1903
1904 * process.c (Fset_process_inherit_coding_system_flag)
1905 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1906 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1907
c07a4c0b 19082012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1909
1910 * xdisp.c (string_buffer_position_lim): Limit starting position to
1911 BEGV.
1912 (set_cursor_from_row): If called for a mode-line or header-line
1913 row, return zero immediately.
1914 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1915 farther than the first row after the header line, if any.
1916 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1917 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1918
c07a4c0b 19192012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1920
4ae29f89
SM
1921 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1922 (bug#11238).
ad3a2b41 1923
c07a4c0b 19242012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 19252012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1926
1927 configure: new option --enable-gcc-warnings (Bug#11207)
1928 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1929 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1930 (ALL_CFLAGS): Use new macros rather than old.
1931 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1932 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1933 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1934 -Wunused-result, -Wunused-variable. This should go away once
1935 the Emacs and Gnulib regex code is merged.
1936 (xmalloc, xrealloc): Now static.
1937
aba027e8
PE
19382012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1939
1940 * dired.c (Fsystem_groups): Remove unused local.
1941
e5a36063
GM
19422012-04-17 Glenn Morris <rgm@gnu.org>
1943
1944 * dired.c (Fsystem_users): Doc fix.
1945
316411f0
DA
19462012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1947
1948 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1949 (syms_of_dired): Add them.
1950
9426aba4
PE
19512012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1952
b62a57be
PE
1953 Fix minor alloc.c problems found by static checking.
1954 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1955 New extern decls, to avoid calling undeclared functions.
1956 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1957 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1958 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1959 (NEED_MEM_INSERT): New macro.
1960 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1961 Remove one incorrect comment and fix another.
b62a57be 1962
3539f31f
PE
1963 Fix minor ralloc.c problems found by static checking.
1964 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1965 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1966 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1967 (r_alloc_sbrk): Now static.
1968
a041960a
PE
1969 Improve ralloc.c interface checking.
1970 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1971 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1972 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1973 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1974 [REL_ALLOC]: ... to here, to check interface.
1975 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1976 Remove decls. This fixes an "It stinks!".
1977
9426aba4
PE
1978 * alloc.c (which_symbols): Fix alignment issue / type clash.
1979
d55c12ed
AS
19802012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1981
1982 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1983 (struct Lisp_Misc_Any): Likewise.
1984 (struct Lisp_Free): Likewise.
1985 * alloc.c (union aligned_Lisp_Symbol): Define.
1986 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1987 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1988 (union aligned_Lisp_Misc): Define.
1989 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1990 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1991 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1992
b948ce8b
PE
19932012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1994
1995 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1996 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1997 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1998 * s/netbsd.h, s/sol2-6.h:
1999 Remove definition of GC_MARK_STACK, since the default now works.
2000 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2001 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2002 no longer the default.
2003 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2004
35dc09a1 20052012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2006
35dc09a1
GM
2007 * lread.c (lisp_file_lexically_bound_p):
2008 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2009
35dc09a1
GM
20102012-04-14 Eli Zaretskii <eliz@gnu.org>
2011
2012 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2013 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2014
20152012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2016
2017 * nsterm.m (constrainFrameRect): Always constrain when there is only
2018 one screen (Bug#10962).
2019
bcd86815
KB
20202012-04-13 Ken Brown <kbrown@cornell.edu>
2021
2022 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2023
c25df26e
RT
20242012-04-13 Reuben Thomas <rrt@sc3d.org>
2025
2026 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2027
0fc59f1e
DC
20282012-04-11 Daniel Colascione <dancol@dancol.org>
2029
2030 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2031 against is gone. It's better to use vfork now so that when Cygwin
2032 gains a new, working vfork, we use it automatically (bug#10398).
2033
de8c03dc
SM
20342012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2035
2036 * window.c (save_window_save): Obey window-point-insertion-type.
2037
2f097256
GM
20382012-04-11 Glenn Morris <rgm@gnu.org>
2039
2040 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2041
453b951e
SM
20422012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2043
2044 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2045
75f1671a 20462012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2047
2048 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2049 (force_quit_count): New var.
2050 (handle_interrupt): Use it.
2051
2a8ce227
JB
20522012-04-10 Juanma Barranquero <lekktu@gmail.com>
2053
2054 * w32.c (w32_delayed_load): Record the full path of the library
2055 being loaded (bug#10424).
2056
935396c0
GM
20572012-04-09 Glenn Morris <rgm@gnu.org>
2058
05920a43
GM
2059 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2060 not just in the obarray, before snarfing them. (Bug#11036)
2061
935396c0
GM
2062 * Makefile.in ($(leimdir)/leim-list.el):
2063 Pass EMACS rather than BUILT_EMACS.
2064
a18ecafa
TZ
20652012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2066
2067 * process.c (make_process):
2068 * process.h: Add integer `gnutls_handshakes_tried' member to
2069 process struct.
2070
6bbef4e5
JC
2071 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2072 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2073
2074 * gnutls.c (gnutls_log_function2i): Convenience log function.
2075 (emacs_gnutls_read): Use new log functions,
2076 `gnutls_handshakes_tried' process member, and
2077 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2078 attempts per process (connection).
2079
b4d3bc10
CY
20802012-04-09 Chong Yidong <cyd@gnu.org>
2081
2082 * eval.c (Fuser_variable_p, user_variable_p_eh)
2083 (lisp_indirect_variable): Functions deleted.
2084 (Fdefvar): Caller changed.
2085
2086 * callint.c (Finteractive, Fcall_interactively):
2087 * minibuf.c (Fread_variable): Callers changed.
2088
70f4d973
EZ
20892012-04-09 Eli Zaretskii <eliz@gnu.org>
2090
2091 * xdisp.c (set_cursor_from_row): If the display string appears in
2092 the buffer at position that is closer to point than the position
2093 after the display string, display the cursor on the first glyph of
2094 the display string. Fixes cursor display when a 'display' text
2095 property immediately follows invisible text. (Bug#11094)
2096
cb3c2e3e
PE
20972012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2098
2099 composite.c: use 'double' consistently
2100 * composite.c (get_composition_id): Use 'double' consistently
2101 instead of converting 'float' to 'double' and vice versa; this is
2102 easier to understand and avoids a GCC warning.
2103
fd06db5d
GM
21042012-04-09 Glenn Morris <rgm@gnu.org>
2105
50fe702a
GM
2106 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2107 preparation for dumping it with emacs. (Bug#4789)
2108 (leimdir): New variable.
2109 ($(leimdir)/leim-list.el): New rule.
2110 (emacs$(EXEEXT)): Depend on leim-list.el.
2111
fd06db5d
GM
2112 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2113 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2114 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2115
55c131ee
AS
21162012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2117
2118 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2119 proper alignment.
2120
9209588f
JB
21212012-04-07 Juanma Barranquero <lekktu@gmail.com>
2122
2123 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2124 Remove unused local variable.
2125
e3fb2efb
PE
21262012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2127
2128 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2129 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2130 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2131 objects, as mark_maybe_pointer will catch them otherwise.
2132 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2133 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2134
b5385551
PE
21352012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2136
2137 Fix typo that broke non-Windows builds.
2138 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2139
9078ead6
EZ
21402012-04-07 Eli Zaretskii <eliz@gnu.org>
2141
2142 Support building on MS-Windows with libxml2.
2143
2144 * makefile.w32-in (OBJ2): Add xml.$(O).
2145 (GLOBAL_SOURCES): Add xml.c.
2146 ($(BLD)/xml.$(O)): New dependency list.
2147
2148 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2149 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2150 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2151 [!WINDOWSNT]: New macros.
2152 (init_libxml2_functions, libxml2_loaded_p): New functions.
2153 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2154 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2155 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2156 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2157 linked in).
6bbef4e5
JC
2158 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2159 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2160 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2161
2162 * emacs.c: Don't include libxml/parser.h.
2163 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2164 xmlCleanupParser directly.
2165
2166 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2167
3811fdf3
EZ
21682012-04-07 Eli Zaretskii <eliz@gnu.org>
2169
2170 * indent.c (Fvertical_motion): If there is a display string at
2171 point, use it.vpos to compute how many lines to backtrack after
2172 move_it_to point. (Bug#11133)
2173
2f8e16b2
EZ
21742012-04-06 Eli Zaretskii <eliz@gnu.org>
2175
2176 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2177 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2178 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2179 macros related to unification of CJK characters. For the details,
2180 see the discussion following the message here:
2181 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2182
3d439cd1
CY
21832012-04-04 Chong Yidong <cyd@gnu.org>
2184
2185 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2186
8bc53d00
EZ
21872012-04-01 Eli Zaretskii <eliz@gnu.org>
2188
2189 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2190 instead of alloca. (Bug#11138)
2191
3b0512a3
AS
21922012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2193
2194 * w32menu.c (is_simple_dialog): Properly check lisp types.
2195 (Bug#11141)
2196
8427ddd2
EZ
21972012-03-31 Eli Zaretskii <eliz@gnu.org>
2198
979022ef
EZ
2199 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2200 position we get to after a call to move_it_to fails the
2201 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2202 only if we wind up in a string from display property. (Bug#11063)
2203
a6b1c7cc
EZ
2204 * window.c (Fdelete_other_windows_internal): Invalidate the row
2205 and column information about mouse highlight, so that redisplay
2206 restores it after reallocating the glyph matrices. (Bug#7464)
2207
8427ddd2
EZ
2208 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2209 string comes from a `display' text property, use the buffer
2210 position of that property as if we actually saw that position in
2211 the row's glyphs.
697ba24b
EZ
2212 (move_it_by_lines): Remove the assertion that
2213 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2214 violated when there's a before-string at the beginning of a line.
2215 (Bug#11063)
8427ddd2 2216
65a0a738
EZ
22172012-03-30 Eli Zaretskii <eliz@gnu.org>
2218
2219 * xdisp.c (append_space_for_newline): If the default face was
2220 remapped, use the remapped face for the appended newline.
2221 (extend_face_to_end_of_line): Use the remapped default face for
2222 extending the face to the end of the line.
2223 (display_line): Call extend_face_to_end_of_line when the default
2224 face was remapped. (Bug#11068)
2225
581355cc
EZ
22262012-03-29 Eli Zaretskii <eliz@gnu.org>
2227
2228 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2229
e8fc049f
SM
22302012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2231
2232 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2233
4fb9a543
GM
22342012-03-27 Glenn Morris <rgm@gnu.org>
2235
2236 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2237 Doc fixes.
2238
679910f1
KH
22392012-03-26 Kenichi Handa <handa@m17n.org>
2240
2241 * dispextern.h (struct glyph): Fix previous change. Change the
2242 bit length of glyphless.ch to 25 (Bug#11082).
2243
90d49b7f
CY
22442012-03-26 Chong Yidong <cyd@gnu.org>
2245
2246 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2247 (command_loop_1): Use it; inhibit selection update for
2248 handle-select-window too (Bug#8996).
2249
f514f6f0
FP
22502012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2251
e8fc049f 2252 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2253
bf43fa51
KH
22542012-03-25 Kenichi Handa <handa@m17n.org>
2255
2256 * dispextern.h (struct glyph): Change the bit length of
2257 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2258
8a0c01dd
EZ
22592012-03-24 Eli Zaretskii <eliz@gnu.org>
2260
2261 * s/ms-w32.h (tzname): Include time.h before redirecting to
2262 _tzname. Fixes the MSVC build. (Bug#9960)
2263
7d1c3a76
AS
22642012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2265
8ed79523
AS
2266 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2267 characters.
2268
7d1c3a76
AS
2269 * xterm.c (XTread_socket): Only modify handling_signal if
2270 !SYNC_INPUT. (Bug#11080)
2271
e99a9b8b
EZ
22722012-03-23 Eli Zaretskii <eliz@gnu.org>
2273
2274 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2275 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2276 when fetching a multibyte character consumes more bytes than
2277 CHAR_BYTES returns, due to unification of CJK characters in
2278 string_char. (Bug#11073)
2279
5063c0e1
TN
22802012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2281
2282 * process.c (wait_reading_process_output): Handle pty disconnect
2283 by refraining from sending oneself a SIGCHLD (bug#10933).
2284
9f851fbd
CY
22852012-03-22 Chong Yidong <cyd@gnu.org>
2286
2287 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2288
5063c0e1 2289 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2290 Mark string as coming from a prefix property.
2291 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2292 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2293
fb5b8aca
CY
22942012-03-21 Chong Yidong <cyd@gnu.org>
2295
2296 * xfaces.c (Vface_remapping_alist): Doc fix.
2297
62356a1b
EZ
22982012-03-20 Eli Zaretskii <eliz@gnu.org>
2299
2300 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2301 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2302 Doc fixes.
62356a1b 2303
025de85b
CY
23042012-03-20 Chong Yidong <cyd@gnu.org>
2305
2306 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2307 to reflect default non-nil value of redisplay-dont-pause.
2308
4827f94e
KH
23092012-03-19 Kenichi Handa <handa@m17n.org>
2310
2311 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2312 it fit in a valid range (Bug#11003).
2313
e50a24a2
EZ
23142012-03-18 Eli Zaretskii <eliz@gnu.org>
2315
2316 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2317 that is not from display property, accept the row as a "cursor
2318 row" if one of the string's character has a non-nil `cursor'
2319 property. Fixes cursor positioning when there are newlines in
2320 overlay strings, e.g. in icomplete.el. (Bug#11035)
2321
9af5ed87
PE
23222012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2323
2324 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2325
d1f55f16
CY
23262012-03-12 Chong Yidong <cyd@gnu.org>
2327
2328 * eval.c (inhibit_lisp_code): Rename from
2329 inhibit_window_configuration_change_hook; move from window.c.
2330
2331 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2332 * window.c (run_window_configuration_change_hook)
2333 (syms_of_window): Callers changed.
2334
66c5eebd
CY
23352012-03-11 Chong Yidong <cyd@gnu.org>
2336
413df973
CY
2337 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2338
66c5eebd
CY
2339 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2340
1de11f56
CY
23412012-03-10 Chong Yidong <cyd@gnu.org>
2342
2343 * frame.c (other_visible_frames): Don't assume the selected frame
2344 is visible (Bug#10955).
2345
cae07000
SM
23462012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2347
2348 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2349
89c94350
JD
23502012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2351
2352 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2353 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2354 zero (Bug#10954).
2355
999dd333
GM
23562012-03-03 Glenn Morris <rgm@gnu.org>
2357
01a6dcc8 2358 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2359
de0100f2
EZ
23602012-03-02 Eli Zaretskii <eliz@gnu.org>
2361
2362 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2363 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2364 (redisplay_window, next_element_from_string): Fix typos in
2365 comments.
3e441275
EZ
2366 (redisplay_window): Pass to move_it_vertically the margin in
2367 pixels, not in screen lines.
de0100f2 2368
96a72ee9
GM
23692012-03-02 Glenn Morris <rgm@gnu.org>
2370
2371 * buffer.c (buffer-list-update-hook): Doc fix.
2372
312508d7
EZ
23732012-02-29 Eli Zaretskii <eliz@gnu.org>
2374
2375 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2376 push_it before setting up the iterator for the first overlay
2377 string, even if we have an empty string loaded.
2378 (next_overlay_string): If there's an empty string on the iterator
2379 stack, pop the stack. (Bug#10903)
2380
27f3c637
PE
23812012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2382
2383 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2384 Suggested by Stefan Monnier in
2385 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2386 * alloc.c (widen_to_Lisp_Object): New static function.
2387 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2388 and widening them to Lisp_Objects. This would work even if
2389 USE_LSB_TAG is defined and wide integers are used, which might
2390 happen in a future version of Emacs.
2391
3c9dfce6
CY
23922012-02-25 Chong Yidong <cyd@gnu.org>
2393
fa74b241
CY
2394 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2395 Doc fix.
2396
3c9dfce6
CY
2397 * xselect.c (Fx_selection_exists_p): Doc fix.
2398 (x_clipboard_manager_save_all): Print an informative message
2399 before saving to clipboard manager.
2400
9486df08
CY
24012012-02-24 Chong Yidong <cyd@gnu.org>
2402
2403 * keyboard.c (process_special_events): Handle all X selection
2404 requests in kbd_buffer, not just the next one (Bug#8869).
2405
f01d3321
CY
24062012-02-23 Chong Yidong <cyd@gnu.org>
2407
2408 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2409 call when setting menu-bar-lines and tool-bar-lines parameters.
2410 (unwind_create_frame_1): New helper function.
2411
2412 * window.c (inhibit_window_configuration_change_hook): New var.
2413 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2414 (syms_of_window): Initialize it.
f01d3321 2415
86b847b6
CY
24162012-02-22 Chong Yidong <cyd@gnu.org>
2417
2418 * xterm.c (x_draw_image_relief): Add missing type check for
2419 Vtool_bar_button_margin (Bug#10743).
2420
a59225b1
CY
24212012-02-21 Chong Yidong <cyd@gnu.org>
2422
2423 * fileio.c (Vfile_name_handler_alist): Doc fix.
2424
2425 * buffer.c (Fget_file_buffer): Protect against invalid file
2426 handler return value.
2427
310f5bd4
PE
24282012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2429
cb3a28cc
PE
2430 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2431 when computing $valmask.
2432
310f5bd4
PE
2433 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2434 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2435 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2436 It's useless in that case, and it can cause problems on hosts
2437 that allocate halves of EMACS_INT values separately.
2438 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2439 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2440 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2441 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2442 it avoids undefined behavior on hosts where shifting right by more
2443 than the word width has undefined behavior.
2444
2375c96a
CY
24452012-02-19 Chong Yidong <cyd@gnu.org>
2446
2447 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2448 (Funhandled_file_name_directory, Ffile_name_as_directory)
2449 (Fdirectory_file_name, Fexpand_file_name)
2450 (Fsubstitute_in_file_name): Protect against invalid file handler
2451 return values (Bug#10845).
2452
3eb49e71
EZ
24532012-02-18 Eli Zaretskii <eliz@gnu.org>
2454
2455 * .gdbinit (pitx): Fix incorrect references to fields of the
2456 iterator stack.
2457
7b926f3f
CY
24582012-02-17 Chong Yidong <cyd@gnu.org>
2459
2460 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2461
11273115
PE
24622012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2465 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2466
c3a70e2b
CY
24672012-02-15 Chong Yidong <cyd@gnu.org>
2468
2469 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2470 marked as special. Also, starting docstrings with * is obsolete.
2471
0ca43699
AS
24722012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2473
2474 * gnutls.c (emacs_gnutls_write): Fix last change.
2475
2e8f3c56
LI
24762012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2477
2478 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2479 send_process.
2480
af70074f
SM
24812012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2482
2483 * keymap.c (Fsingle_key_description): Handle char ranges.
2484
95986d52
CY
24852012-02-12 Chong Yidong <cyd@gnu.org>
2486
afd83bd1
CY
2487 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2488 as that creates a dangerous corner case.
2489
95986d52
CY
2490 * window.c (Fdelete_window_internal): Invalidate the mouse
2491 highlight (Bug#9904).
2492
bd7da63e
GM
24932012-02-12 Glenn Morris <rgm@gnu.org>
2494
2495 * xselect.c (Fx_own_selection_internal)
2496 (Fx_get_selection_internal, Fx_disown_selection_internal)
2497 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2498 * nsselect.m (Fx_own_selection_internal)
2499 (Fx_disown_selection_internal, Fx_selection_exists_p)
2500 (Fx_selection_owner_p, Fx_get_selection_internal):
2501 Sync docs and argument specs with the xselect.c versions.
2502
77abcbc2
LI
25032012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2504
2505 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2506
90b671e2
EZ
25072012-02-11 Eli Zaretskii <eliz@gnu.org>
2508
1c0ca0b7
EZ
2509 * w32select.c (Fx_selection_exists_p): Sync doc string and
2510 argument list with xselect.c. (Bug#10783)
2511
2512 * w16select.c (Fx_selection_exists_p): Sync doc string and
2513 argument list with xselect.c. (Bug#10783)
90b671e2 2514
49241268
GM
25152012-02-10 Glenn Morris <rgm@gnu.org>
2516
2517 * fns.c (Fsecure_hash): Doc fix.
2518
f998bbe7 25192012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2520
2521 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2522
0992bd9c
CY
25232012-02-07 Chong Yidong <cyd@gnu.org>
2524
2525 * buffer.c (Fbuffer_local_variables)
2526 (buffer_lisp_local_variables): Handle unbound vars correctly;
2527 don't let Qunbound leak into Lisp.
2528
af008560
GM
25292012-02-07 Glenn Morris <rgm@gnu.org>
2530
dd605cc4
GM
2531 * image.c (Fimagemagick_types): Doc fix.
2532
af008560
GM
2533 * image.c (imagemagick-render-type): Change it from a lisp object
2534 to an integer. Move the doc here from the lisp manual.
2535 Treat all values not equal to 0 the same.
2536
1449fa1d
CY
25372012-02-06 Chong Yidong <cyd@gnu.org>
2538
2539 * doc.c (store_function_docstring): Avoid applying docstring of
2540 alias to base function (Bug#2603).
2541
3723ec07
AS
25422012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2543
2544 * .gdbinit (pp1, pv1): Remove redundant defines.
2545 (pr): Use pp.
2546
79c1cc1e
CY
25472012-02-04 Chong Yidong <cyd@gnu.org>
2548
2549 * nsterm.m: Declare a global (Bug#10694).
2550
d7f29f8e
EZ
25512012-02-04 Eli Zaretskii <eliz@gnu.org>
2552
cae07000
SM
2553 * w32.c (get_emacs_configuration_options):
2554 Include --enable-checking, if specified, in the return value.
d7f29f8e 2555
3b95a6f9
MR
25562012-02-04 Martin Rudalics <rudalics@gmx.at>
2557
2558 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2559 after rounding frame sizes. (Bug#9723)
2560
d6fa96a6
EZ
25612012-02-04 Eli Zaretskii <eliz@gnu.org>
2562
2563 * keyboard.c (adjust_point_for_property): Don't position point
2564 before BEGV. (Bug#10696)
2565
df0b2940
PE
25662012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2567
2568 Handle overflow when computing char display width (Bug#9496).
2569 * character.c (char_width): Return EMACS_INT, not int.
2570 (char_width, c_string_width): Check for overflow when
2571 computing the width; this is possible now that individual
2572 characters can have unbounded width. Problem introduced
2573 by merge from Emacs 23 on 2012-01-19.
2574
6bee44d6
MA
25752012-02-02 Michael Albinus <michael.albinus@gmx.de>
2576
2577 * dbusbind.c (Fdbus_register_method): Mention the return value
2578 :ignore in the docstring.
2579
44f92739
GM
25802012-02-02 Glenn Morris <rgm@gnu.org>
2581
1b9f60cc
GM
2582 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2583
44f92739
GM
2584 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2585 Unconditionally set to t. (Bug#10673)
2586 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2587 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2588 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2589
c5d3843c
KH
25902012-02-02 Kenichi Handa <handa@m17n.org>
2591
2592 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2593 0, do not call append_composite_glyph.
2594
159462d4 25952012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2596
2597 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2598 NULL (Bug#6988).
2599 (x_produce_glyphs): If the component of a composition is a null
2600 string, set it->pixel_width to 1 to avoid zero-width glyph.
2601
78cef877
EZ
26022012-02-01 Eli Zaretskii <eliz@gnu.org>
2603
2604 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2605 first 2 arguments are identical. This makes inserting large
2606 output from a subprocess an order of magnitude faster on
2607 MS-Windows, where all sbrk'ed memory is always contiguous.
2608
97897668
GM
26092012-01-31 Glenn Morris <rgm@gnu.org>
2610
2611 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2612 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2613 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2614
31fd3586
GM
26152012-01-29 Glenn Morris <rgm@gnu.org>
2616
2617 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2618
0e24a8b2
CY
26192012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2620
2621 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2622
cc0adcb0
CY
26232012-01-28 Chong Yidong <cyd@gnu.org>
2624
2625 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2626
acc28cb9
CY
26272012-01-26 Chong Yidong <cyd@gnu.org>
2628
9c69cfb7
CY
2629 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2630
acc28cb9
CY
2631 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2632 repeat counts (Bug#10507).
2633
48da7392
GM
26342012-01-26 Glenn Morris <rgm@gnu.org>
2635
2636 * lread.c (syms_of_lread): Doc fix.
2637
14af5f7f
CY
26382012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2639
2640 * coding.c (encode_designation_at_bol): Change return value to
2641 EMACS_INT.
2642
0b21c100
CY
26432012-01-25 Chong Yidong <cyd@gnu.org>
2644
2645 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2646
3c2907f7
CY
26472012-01-21 Chong Yidong <cyd@gnu.org>
2648
2649 * floatfns.c (Fcopysign): Make the second argument non-optional,
2650 since nil is not allowed anyway.
2651
959ad23f
AS
26522012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2653
2654 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2655 (send_process): Likewise.
2656
34a02f46
MR
26572012-01-19 Martin Rudalics <rudalics@gmx.at>
2658
2659 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2660 (Vwindow_persistent_parameters): Do not use Qstate.
2661 Rewrite doc-strings.
34a02f46 2662
1259009a 26632012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2664
2665 * character.c (char_width): New function.
70d4fdf6
GM
2666 (Fchar_width, c_string_width, lisp_string_width):
2667 Use char_width (Bug#9496).
25ed9e61 2668
6a6ee00d
MR
26692012-01-16 Martin Rudalics <rudalics@gmx.at>
2670
2671 * window.c (Vwindow_persistent_parameters): New variable.
2672 (Fset_window_configuration, save_window_save): Handle persistent
2673 window parameters.
2674
c85efaf7
EZ
26752012-01-14 Eli Zaretskii <eliz@gnu.org>
2676
2677 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2678 thrashing the stack of the thread. (Bug#9087)
2679
5944709e
PE
26802012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2681
2682 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2683
e71f5d99
EZ
26842012-01-11 Eli Zaretskii <eliz@gnu.org>
2685
2686 * xdisp.c (rows_from_pos_range): Handle the case where the
2687 highlight ends on a newline. (Bug#10464)
2688 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2689 he end column for display of highlight that ends on a newline
2690 before a R2L line.
2691
ce316182
GM
26922012-01-11 Glenn Morris <rgm@gnu.org>
2693
2694 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2695 from load-path also when installation-directory is nil. (Bug#10208)
2696
5b43da69
GM
26972012-01-10 Glenn Morris <rgm@gnu.org>
2698
74cc8ff9
GM
2699 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2700
7d8d6e4e
GM
2701 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2702 Update template values to be closer to their typical values these days.
5b43da69 2703
a0db8d43
EZ
27042012-01-09 Eli Zaretskii <eliz@gnu.org>
2705
2706 * xdisp.c (rows_from_pos_range): Accept additional argument
2707 DISP_STRING, and accept any glyph in a row whose object is that
2708 string as eligible for mouse highlight. Fixes mouse highlight of
2709 display strings from overlays. (Bug#10464)
2710
9a0115ab 27112012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2712
b9110d6a 2713 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2714 * fileio.c (auto_saving_dir_umask): New static var.
2715 (Fmake_directory_internal): Use it.
2716 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2717 creating the directory. The old code temporarily assigns
2718 too-generous permissions to the directory.
2719 (do_auto_save_eh): Clear it.
b9110d6a 2720 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2721 that the var is always cleared.
2722
6c1bd3f3
EZ
27232012-01-07 Eli Zaretskii <eliz@gnu.org>
2724
2725 * search.c (scan_buffer): Pass character positions to
2726 know_region_cache, not byte positions. (Bug#6540)
2727
069d2b50
L
27282012-01-07 LynX <_LynX@bk.ru> (tiny change)
2729
2730 * w32.c (sys_rename): Report EXDEV when rename of a directory
2731 fails because the target is on another logical disk. (Bug#10284)
2732
75bf0d33
DB
27332012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2734
2735 * xterm.c (x_embed_request_focus): New function.
2736
2737 * xterm.h: Add prototype.
2738
2739 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2740
1c6e5a32
GM
27412012-01-05 Glenn Morris <rgm@gnu.org>
2742
2743 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2744
651e947e
EZ
27452012-01-01 Eli Zaretskii <eliz@gnu.org>
2746
2747 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2748 Load gnutls_transport_set_lowat only if GnuTLS version is below
2749 2.11.1.
2750 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2751 GnuTLS versions below 2.11.1.
2752
3778cdd8
AL
27532011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2754
2755 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2756 to the doc string advising against its use for altering the way
2757 windows are scrolled.
2758
0e5317f7
KH
27592011-12-28 Kenichi Handa <handa@m17n.org>
2760
2761 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2762 coding-system ASCII compatible only when it does not produce BOM
2763 on encoding (Bug#10383).
2764
93d5ca1f
JD
27652011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2766
2767 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2768 can scroll.
2769 (create_and_show_popup_menu): Always use menu_position_func for
2770 Gtk3 (Bug#10361).
2771
ca22b785
AS
27722011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2773
2774 * callint.c (Fcall_interactively): Don't truncate prompt string.
2775
d048e1e6
EZ
27762011-12-23 Eli Zaretskii <eliz@gnu.org>
2777
2778 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2779 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2780 resumed from there (after widening). (Bug#10360)
d048e1e6 2781
5ccaba1f
JD
27822011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2783
2784 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2785
204ee57f
JD
27862011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2787
b81d40f0
JB
2788 * nsterm.m (x_free_frame_resources):
2789 Release f->output_data.ns->miniimage.
204ee57f
JD
2790 (ns_index_color): Fix indentation. Do not retain
2791 color_table->colors[i].
2792
2793 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2794 before returning.
2795
2796 * nsfns.m (x_set_background_color): Assign return value from
2797 ns_index_color to face-background instead of NSColor*.
2798 (ns_implicitly_set_icon_type): Fix indentation.
2799 Change assignment in for loop to comparison.
2800
2801 * emacs.c (ns_pool): New variable.
2802 (main): Assign ns_pool.
2803 (Fkill_emacs): Call ns_release_autorelease_pool.
2804
2805 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2806 autorelease fdesc, release fdAttrs and tdict.
2807 (ns_get_covering_families): Release charset.
2808 (ns_findfonts): Release NSFontDescriptor created with new.
2809 (ns_uni_to_glyphs): Fix indentation.
2810 (setString): Release attrStr before assigning new value.
2811
c803b2b7
JD
28122011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2813
678f4426
JD
2814 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2815 and NS_IMPL_COCOA.
2816 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2817 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2818
cd394be1 28192011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2820
5fecd5fc
JD
2821 * nsterm.m (ns_term_init): Subscribe for notifications
2822 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2823 to method trackingNotification in EmacsMenu.
2824
2825 * nsmenu.m (trackingMenu): New variable.
3771cb17 2826 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2827 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2828 from Aquamacs (Bug#7030).
678f4426
JD
2829
28302011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2831
c803b2b7
JD
2832 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2833 (symbol_to_nsstring): Fix indentation.
2834 (ns_symbol_to_pb): New function.
cae07000
SM
2835 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2836 (Fns_rotate_cut_buffers_internal): Remove.
2837 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2838 Fns_store_cut_buffer_internal.
2839 (ns_get_foreign_selection, Fx_own_selection_internal)
2840 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2841 (Fns_get_selection_internal, Fns_store_selection_internal):
2842 Use ns_symbol_to_pb and check if return value is nil.
2843 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2844 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2845 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2846 renamed to Sns_store_selection_internal.
2847 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2848 and remove this function.
2849 (ns_handle_selection_clear): Remove, never used.
2850 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2851 here.
2852
e1b01a3a
KB
28532011-12-17 Ken Brown <kbrown@cornell.edu>
2854
2855 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2856 GID is unknown (Bug#10257).
2857
2adb6e85
PE
28582011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2859
2860 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2861 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2862 which caused a build failure on GNU/Linux IA-64. This problem was
2863 introduced by my 2011-10-07 patch.
2864
d1d7b339
JL
28652011-12-15 Juri Linkov <juri@jurta.org>
2866
2867 * image.c (imagemagick_error): New function. (Bug#10112)
2868 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2869 Use `imagemagick_error' where ImageMagick functions return
2870 `MagickFalse'.
2871 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2872 proper order.
2873
100d5755
KH
28742011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2875
2876 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2877 fill background (Bug#8992).
2878
454592a6
MR
28792011-12-13 Martin Rudalics <rudalics@gmx.at>
2880
2881 * window.c (Vwindow_combination_resize)
2882 (Vwindow_combination_limit): Use t instead of non-nil in
2883 doc-strings.
61d4b438
MR
2884 (Vrecenter_redisplay): Add first sentence of doc-string on
2885 separate line.
53524d93 2886 (Frecenter): Fix doc-string typo.
454592a6 2887
3633e3aa
KH
28882011-12-11 Kenichi Handa <handa@m17n.org>
2889
2890 * coding.c (Funencodable_char_position): Pay attention to the
2891 buffer text relocation (Bug#9389).
2892
7b9d523a 28932011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2894
7b9d523a
JD
2895 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2896 gtk_init (Bug#10100).
2897
b73189c6
EZ
28982011-12-10 Eli Zaretskii <eliz@gnu.org>
2899
2900 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2901 IT->string is nil. (Bug#10263)
2902
f7dfe5d6
JD
29032011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2904
83faebb4
JD
2905 * nsterm.h (x_free_frame_resources): Declare.
2906
f7dfe5d6
JD
2907 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2908 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2909
2910 * nsterm.h (ns_get_defaults_value): Declare.
2911
2912 * nsterm.m (ns_default): Call ns_get_defaults_value.
2913
7cd4e72c
EZ
29142011-12-09 Eli Zaretskii <eliz@gnu.org>
2915
2916 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2917 (Bug#10170)
2918
b34d7317
YM
29192011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2920
2921 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2922 that where the value of an _OBJC_* symbol points to is in the .bss
2923 section (Bug#10240).
2924
76470ad1
KH
29252011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2926
2927 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2928 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2929
745fff94
KH
29302011-12-08 Kenichi Handa <handa@m17n.org>
2931
2932 * ftfont.c (get_adstyle_property): Fix previous change
2933 (Bug#10233).
2934
6e44397c
JB
29352011-12-07 Juanma Barranquero <lekktu@gmail.com>
2936
2937 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2938 dirs from the default value of EMACSLOADPATH (bug#10208).
2939
7efa6272
GM
29402011-12-07 Glenn Morris <rgm@gnu.org>
2941
2942 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2943 installation and source directories as well. (Bug#10208)
2944
f6fc4d87
CY
29452011-12-06 Chong Yidong <cyd@gnu.org>
2946
2947 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2948
2bf26180
GM
29492011-12-06 Glenn Morris <rgm@gnu.org>
2950
2951 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2952 as an error, not just -1. (Bug#10217)
2953
3a6ad4f0
CY
29542011-12-05 Chong Yidong <cyd@gnu.org>
2955
2956 * keyboard.c (process_special_events): New function.
2957 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2958
75a3b399
PE
29592011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2960
2961 * coding.c (encode_designation_at_bol): Don't use uninitialized
2962 local variable (Bug#9318).
2963
c3c9e25e
KH
29642011-12-05 Kenichi Handa <handa@m17n.org>
2965
2966 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2967 return Qnil (Bug#8046, Bug#10193).
2968
5eb05ea3
KH
29692011-12-05 Kenichi Handa <handa@m17n.org>
2970
2971 * coding.c (encode_designation_at_bol): New args charbuf_end and
2972 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2973 (coding_set_source): Return how many bytes coding->source was
2974 relocated.
2975 (coding_set_destination): Return how many bytes
2976 coding->destination was relocated.
2977 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2978 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2979
29802011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2981
2982 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2983 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2984 macro (Bug#9318).
2985
29862011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2987
2988 The following changes are to fix Bug#9318.
2989
a79703f5 2990 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2991 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2992 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2993 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2994
7dbda6df
JB
29952011-12-05 Juanma Barranquero <lekktu@gmail.com>
2996
2997 * lisp.h (process_quit_flag): Fix external declaration.
2998
6d5eb5b0
SM
29992011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3000
3001 Don't macro-inline non-performance-critical code.
3002 * eval.c (process_quit_flag): New function.
3003 * lisp.h (QUIT): Use it.
3004
a0c3fad0
JD
30052011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3006
3007 * nsfns.m (get_geometry_from_preferences): New function.
3008 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3009
6c07aac2
AS
30102011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3011
3012 * emacs.c (Qkill_emacs): Define.
3013 (syms_of_emacs): Initialize it.
3014 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3015 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3016 (quit_throw_to_read_char): Add parameter `from_signal'.
3017 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3018 * lisp.h (QUIT): Call Fkill_emacs if requested.
3019
c052ead4
JD
30202011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3021
3022 * widget.c (update_wm_hints): Return if wmshell is null.
3023 (widget_update_wm_size_hints): New function.
3024
3025 * widget.h (widget_update_wm_size_hints): Declare.
3026
3027 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3028 widget_update_wm_size_hints (Bug#10104).
3029
9e49252b
EZ
30302011-12-03 Eli Zaretskii <eliz@gnu.org>
3031
3032 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3033 before a newline, prepare the bidi iterator for consuming the
3034 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3035 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3036
02b16839
JL
30372011-12-02 Juri Linkov <juri@jurta.org>
3038
3039 * search.c (Fword_search_regexp): New Lisp function created from
3040 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3041 (Fword_search_backward, Fword_search_forward)
3042 (Fword_search_backward_lax, Fword_search_forward_lax):
3043 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3044 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3045
0068070e
SM
30462011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3047
3048 * fileio.c (Finsert_file_contents): Move after-change-function call
3049 to before the "handled:" label, since all "goto handled" appear in
3050 cases where the *-change-functions have already been properly called
3051 (bug#10117).
3052
3360a3fc
AS
30532011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3054
3055 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3056 waiting for input. (Bug#10169)
3057
73d6c093
EZ
30582011-11-30 Eli Zaretskii <eliz@gnu.org>
3059
3060 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3061 verifies glyph row's hash code--we have just reallocated the
3062 glyphs, so their contents can be complete garbage. (Bug#10164)
3063
febe6bea
JB
30642011-11-30 Juanma Barranquero <lekktu@gmail.com>
3065
3066 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3067
801a4313
EZ
30682011-11-30 Eli Zaretskii <eliz@gnu.org>
3069
3070 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3071 attributes are tested _before_ calling verify_row_hash, to protect
3072 against GCC re-ordering of the tests. (Bug#10164)
3073
2b56b87e
JD
30742011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3075
3076 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3077
3078 * xterm.c (handle_one_xevent): Only set async_visible and friends
3079 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3080 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3081 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3082
dbf31225
PE
30832011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3084
3085 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3086 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3087 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3088 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3089 All uses changed to use GCPRO1 etc.
3090 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3091 Revert to old implementation (i.e., before 2011-03-11).
3092
1305621b
YM
30932011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3094
3095 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3096 of scroll runs so as to avoid assigning disabled bogus rows and
3097 unnecessary graphics copy operations.
3098
8c9afb46
EZ
30992011-11-27 Eli Zaretskii <eliz@gnu.org>
3100
3101 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3102 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3103 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3104 (malloc, free, realloc, calloc): Redirect to e_* only when
3105 compiling Emacs.
3106
3107 * lisp.h (GCTYPEBITS): Move before first use.
3108 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3109 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3110 this macro definition.
3111
3112 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3113 _MSC_VER.
3114
54e9e3bf
JD
31152011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3116
6d5eb5b0
SM
3117 * gtkutil.c (xg_create_frame_widgets):
3118 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3119 present with Gtk+ 2.0.
3120
83aca1cb
PE
31212011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3122
3123 * fileio.c (Finsert_file_contents): Undo previous change; see
3124 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3125
5b76caa4
PE
31262011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3127
3128 Rename locals to avoid shadowing.
3129 * fileio.c (Finsert_file_contents):
3130 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3131 * process.c (wait_reading_process_output):
3132 Rename inner 'proc' to 'p' to avoid shadowing.
3133 Indent for consistency with usual Emacs style.
3134
8c535114
EZ
31352011-11-25 Eli Zaretskii <eliz@gnu.org>
3136
3137 * xdisp.c (redisplay_window): If cursor row is not fully visible
3138 after recentering, and scroll-conservatively is set to a large
3139 number, scroll window by a few more lines to make the cursor fully
3140 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3141 (start_display): Don't move to the next line if the display should
3142 start at a newline that is part of a display vector or an overlay
3143 string. (Bug#10119)
8c535114 3144
fa4fdb5c
JL
31452011-11-24 Juri Linkov <juri@jurta.org>
3146
3147 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3148 after the `MagickPingImage' call. (Bug#10112)
3149
90ec88df
CY
31502011-11-23 Chong Yidong <cyd@gnu.org>
3151
3152 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3153
56e2e794
MR
31542011-11-23 Martin Rudalics <rudalics@gmx.at>
3155
3156 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3157 making another buffer current. (Bug#10114)
3158
b6e64c41
GM
31592011-11-23 Glenn Morris <rgm@gnu.org>
3160
3161 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3162
6b21de18
CY
31632011-11-23 Chong Yidong <cyd@gnu.org>
3164
3165 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3166 using it (Bug#5984).
3167
b12cd789
EZ
31682011-11-22 Eli Zaretskii <eliz@gnu.org>
3169
3170 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3171 and header-lines, as they don't have one computed for them.
3172 (Bug#10098)
3173
3174 * .gdbinit (prow): Make displayed values more self-explaining.
3175 Add row's hash code.
3176
261b6fd4
LMI
31772011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3178
3179 * process.c (wait_reading_process_output): Fix asynchrounous
3180 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3181 (wait_reading_process_output): Add comment and URL.
261b6fd4 3182
e7cfd277
JD
31832011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3184
3185 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3186
a9b9b7f5
CY
31872011-11-21 Chong Yidong <cyd@gnu.org>
3188
3189 * window.c (Fnext_window, Fprevious_window): Doc fix.
3190
b0d15b4f
SM
31912011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3192
3193 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3194
fe7a3057
JB
31952011-11-20 Juanma Barranquero <lekktu@gmail.com>
3196
3197 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3198
d2999b1a
MR
31992011-11-20 Martin Rudalics <rudalics@gmx.at>
3200
3201 * window.c (Fset_window_combination_limit): Rename argument
3202 STATUS to LIMIT.
3203 (Vwindow_combination_limit): Remove "status" from doc-string.
3204
d5ff9cd0
AS
32052011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3206
3207 * m/ibms390.h: Remove.
3208 * m/ibms390x.h: Don't include "ibms390.h".
3209
a5bb9bd3
SM
32102011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3211
3212 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3213 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3214
cd1181db
JB
32152011-11-20 Juanma Barranquero <lekktu@gmail.com>
3216
3217 * casetab.c (Fset_case_table):
3218 * charset.c (Fcharset_after): Fix typos.
3219
615a3b8d 32202011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3221
17e845af
PE
3222 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3223 Otherwise, valgrind does not work on some platforms.
3224 Problem reported by Andreas Schwab in
6a0bf43d
PE
3225 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3226 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3227 is set, removing the need for VIRT_ADDRESS_VARIES.
3228 (PURE_P): Use a more-efficient implementation that needs just one
3229 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3230 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3231 to 4 (xorl, subq, cmpq, setbe).
3232 * alloc.c (pure): Always extern now, since that's the
3233 VIRT_ADDR_VARIES behavior.
3234 (PURE_POINTER_P): Use a single comparison, not two, for
3235 consistency with the new puresize.h.
3236 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3237 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3238 Remove VIRT_ADDR_VARIES no longer needed.
3239
f8fe6f96
EZ
32402011-11-19 Eli Zaretskii <eliz@gnu.org>
3241
3242 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3243 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3244 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3245 behave as if the cursor position were at the window margin.
3246
3247 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3248 and the cursor position is out of bounds, behave as if the cursor
3249 position were at the window margin. (Bug#10075)
3250
df05a53c
CY
32512011-11-18 Chong Yidong <cyd@gnu.org>
3252
3253 * window.c (Fwindow_combination_limit): Make first argument
3254 non-optional, since it is meaningless for live windows like the
3255 selected window.
61ccba97 3256
2071918e
DA
32572011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3258
3259 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3260
b50a28de
SM
32612011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3262
3263 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3264 (graft_intervals_into_buffer): Simplify.
3265
015137db
EZ
32662011-11-18 Eli Zaretskii <eliz@gnu.org>
3267
3268 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3269 hash values of the two rows.
3270 (copy_row_except_pointers): Preserve the used[] arrays and the
3271 hash values of the two rows. (Bug#10035)
68c95424 3272 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3273
3274 * xdisp.c (row_hash): New function, body extracted from
3275 compute_line_metrics.
3276 (compute_line_metrics): Call row_hash, instead of computing the
3277 hash code inline.
3278
3279 * dispnew.c (verify_row_hash): Call row_hash for computing the
3280 hash code of a row, instead of duplicating code from xdisp.c.
3281
3282 * dispextern.h (row_hash): Add prototype.
3283
a2addb04
TH
32842011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3285
3286 * frame.c (delete_frame): Don't delete the terminal when the last
3287 X frame is closed if emacs is built with GTK toolkit.
3288
df85d315
JB
32892011-11-17 Juanma Barranquero <lekktu@gmail.com>
3290
3291 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3292
a0c2d0ae
MR
32932011-11-17 Martin Rudalics <rudalics@gmx.at>
3294
3295 * window.c (Vwindow_splits): Rename to
3296 Vwindow_combination_resize. Suggested by Juri Linkov.
3297 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3298 of Vwindow_splits.
3299
58179cce
JB
33002011-11-16 Juanma Barranquero <lekktu@gmail.com>
3301
7877f373
JB
3302 * nsfns.m (Fns_font_name):
3303 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3304
b6f67890
MR
33052011-11-16 Martin Rudalics <rudalics@gmx.at>
3306
3307 * window.h (window): Rename slot "nest" to "combination_limit".
3308 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3309 (Fset_window_nest): Rename to Fset_window_combination_limit.
3310 (Vwindow_nest): Rename to Vwindow_combination_limit.
3311 (recombine_windows, make_parent_window, make_window)
3312 (Fsplit_window_internal, saved_window)
3313 (Fset_window_configuration, save_window_save): Rename all
3314 occurrences of window_nest to window_combination_limit.
3315
c7015153
JB
33162011-11-15 Juanma Barranquero <lekktu@gmail.com>
3317
3318 * image.c (imagemagick_load_image): Fix typo.
3319
322ad6ec
EZ
33202011-11-14 Eli Zaretskii <eliz@gnu.org>
3321
3322 * xdisp.c (display_line): Move the call to
3323 highlight_trailing_whitespace before the call to
3324 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3325 faces of all the glyphs to compute ROW's hash value.
3326 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3327
f067b8ec
JB
33282011-11-14 Juanma Barranquero <lekktu@gmail.com>
3329
3330 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3331 just return (bug#10044).
3332
1e5b2111
EZ
33332011-11-12 Eli Zaretskii <eliz@gnu.org>
3334
7ef3cbd5
EZ
3335 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3336 with user-defined heap size. Bump the default size of the temacs
3337 heap to 27MB, to avoid memory warning when running temacs.
3338 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3339
1e5b2111
EZ
3340 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3341 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3342 (verify_row_hash) [XASSERTS]: New function.
3343 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3344 that the hash value of glyph rows is correct.
1e5b2111 3345
89d61221
MR
33462011-11-12 Martin Rudalics <rudalics@gmx.at>
3347
3348 * window.h (window): Remove splits slot.
3349 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3350 (Fdelete_other_windows_internal, make_parent_window)
3351 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3352 (Fset_window_configuration, save_window_save): Don't deal with
3353 split status of windows.
3354 (saved_window): Remove splits slot.
3355 (Vwindow_splits): Rewrite doc-string.
3356
97f18cc8
JD
33572011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3358
3359 * xfns.c (unwind_create_frame):
3360 * nsfns.m (unwind_create_frame):
3361 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3362 Vframe_list (Bug#9999).
3363
22a648b4
DA
33642011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3365
0b381c7e 3366 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3367
659afede
KH
33682011-11-11 Kenichi Handa <handa@m17n.org>
3369
3370 * callproc.c (Fcall_process): Set the member dst_multibyte of
3371 process_coding.
3372
9ac0394b
KH
33732011-11-11 Johan Bockgård <bojohan@gnu.org>
3374
3375 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3376 avoid a crash (bug#9496).
3377
2fbdc249
CY
33782011-11-09 Chong Yidong <cyd@gnu.org>
3379
3380 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3381 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3382
ac6b1f81
PE
33832011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3384
3385 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3386
09db192c
PE
33872011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3388
3389 Avoid some portability problems by eschewing 'extern inline' functions.
3390 The trivial performance wins aren't worth the portability hassles; see
3391 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3392 et seq.
3393 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3394 (window_box_width, window_box_left, window_box_left_offset)
3395 (window_box_right, window_box_right_offset): Undo previous change,
3396 by removing the "extern"s.
3397 * intervals.c (adjust_intervals_for_insertion)
3398 (adjust_intervals_for_deletion): Undo previous change,
3399 making these static again.
3400 (offset_intervals, temp_set_point_both, temp_set_point)
3401 (copy_intervals_to_string): No longer inline.
3402 * xdisp.c (window_text_bottom_y, window_box_width)
3403 (window_box_height, window_box_left_offset)
3404 (window_box_right_offset, window_box_left, window_box_right)
3405 (window_box): No longer inline.
3406
105216ed
CY
34072011-11-08 Chong Yidong <cyd@gnu.org>
3408
3409 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3410 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3411 Signal an error if not a live window.
105216ed
CY
3412 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3413 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3414
ae9e237f
JB
34152011-11-07 Juanma Barranquero <lekktu@gmail.com>
3416
3417 * lisp.h (syms_of_abbrev): Remove declaration.
3418 Reported by CHENG Gao <chenggao@royau.me>.
3419
c7aa8333
EZ
34202011-11-07 Eli Zaretskii <eliz@gnu.org>
3421
3422 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3423 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3424 of temacs in GUI mode.
3425
be7f5545
MR
34262011-11-07 Martin Rudalics <rudalics@gmx.at>
3427
3428 * window.h: Declare delete_all_child_windows instead of
3429 delete_all_subwindows.
3430 * window.c (Fwindow_nest, Fset_window_nest)
3431 (Fset_window_new_total, Fset_window_new_normal)
3432 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3433 (delete_all_subwindows): Rename to delete_all_child_windows.
3434 (Fdelete_other_windows_internal, Fset_window_configuration):
3435 Call delete_all_child_windows instead of delete_all_subwindows.
3436 * frame.c (delete_frame): Call delete_all_child_windows instead
3437 of delete_all_subwindows.
3438
ca78dc43
PE
34392011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3440
3441 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3442 This is also needed for porting to any host where GC_MARK_STACK is
3443 not GC_MAKE_GCPROS_NOOPS.
3444 (which_symbols): Use it.
3445
a0241d01
KH
34462011-11-07 Kenichi Handa <handa@m17n.org>
3447
3448 * coding.c (coding_set_destination): Check coding->src_pos only
3449 when coding->src_object is a buffer (bug#9910).
3450
3451 * process.c (send_process): Set the member src_multibyte of coding
3452 to 0 (bug#9911) when sending a unibyte text.
3453
3454 * callproc.c (Fcall_process): Set the member src_multibyte of
3455 process_coding to 0 (bug#9912).
3456
a64bfdfa 34572011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3458
3459 * xmenu.c (cleanup_widget_value_tree): New function.
3460 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3461 calling free_menubar_widget_value_tree directly (Bug#9830).
3462
cb41b32a
PE
34632011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3464
3465 Fix some portability problems with 'inline'.
3466 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3467 (window_box_width, window_box_left, window_box_left_offset)
3468 (window_box_right, window_box_right_offset): Declare extern.
3469 Otherwise, these inline functions do not conform to C99 and
3470 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3471 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3472 * intervals.c (adjust_intervals_for_insertion)
3473 (adjust_intervals_for_deletion): Now extern, because otherwise the
3474 extern inline functions 'offset_intervals' couldn't refer to it.
3475 (static_offset_intervals): Remove.
3476 (offset_intervals): Rewrite using the old contents of
3477 static_offset_intervals. The old version didn't conform to C99
3478 because an extern inline function contained a reference to an
3479 identifier with static linkage.
3480
b7041366
AS
34812011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3482
3483 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3484 GC.
3485
88a37c4d
EZ
34862011-11-06 Eli Zaretskii <eliz@gnu.org>
3487
3488 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3489 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3490 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3491 return Qleft_to_right.
3492
49745b39
CY
34932011-11-06 Chong Yidong <cyd@gnu.org>
3494
3495 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3496 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3497 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3498 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3499 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3500 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3501 (Fwindow_vscroll): Doc fix.
3502 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3503 argument, since it makes no sense to pass a live window and for
3504 consistency with window-child.
3505
1f05cd82
CS
35062011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3507
3508 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3509 support MSVC.
3510
22610910
JR
35112011-11-05 Jason Rumney <jasonr@gnu.org>
3512
3513 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3514 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3515 fonts (Bug#6029).
3516 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3517 bitwise arithmetic preventing use of unicode-sip and non-truetype
3518 opentype fonts.
3519
a06776b2
EZ
35202011-11-05 Eli Zaretskii <eliz@gnu.org>
3521
3ad924ba
EZ
3522 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3523 "emacs"-only part.
3524
a06776b2
EZ
3525 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3526 initialization code to keep similarity to xfns.c after changes
3527 from 2011-11-05.
3528
c9e7db78
JD
35292011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3530
a97f8f3f
JD
3531 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3532 (unwind_create_frame): New function (Bug#9943).
3533 (Fx_create_frame): Restructure code to be more similar to the one in
3534 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3535 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3536 Move terminal->reference_count++ just before making the frame official
3537 (Bug#9943).
3538
3539 * nsterm.m (x_free_frame_resources): New function.
3540 (x_destroy_window): Move code to x_free_frame_resources.
3541
c9e7db78 3542 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3543 (Fx_create_frame, x_create_tip_frame):
3544 Move terminal->reference_count++ just before making the frame
75f1671a 3545 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3546 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3547
a6fc3b5c
EZ
35482011-11-05 Eli Zaretskii <eliz@gnu.org>
3549
3550 Support MSVC build with newer versions of Visual Studio.
3551 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3552 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3553 nt/gmake.defs.
3554
3555 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3556 which are not supported by MSVC.
3557 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3558 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3559 bitfields.
3560 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3561 types in bitfields.
3562 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3563
3564 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3565
58179cce 35662011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3567
3568 Support MSVC build with newer versions of Visual Studio.
3569 * w32.c: Don't include w32api.h for MSVC.
3570 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3571
3572 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3573 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3574 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3575 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3576 e_* cousins.
3577 (alloca) [_MSC_VER]: Define to _alloca.
3578
3579 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3580
3581 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3582
a58c13ed
EZ
35832011-11-04 Eli Zaretskii <eliz@gnu.org>
3584
3585 * xdisp.c (note_mouse_highlight): If either of
3586 previous/next-single-property-change returns nil, treat that as
3587 the beginning or the end of the buffer. (Bug#9955)
3588
fe0b6370
JD
35892011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3590
a58c13ed 3591 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3592 label is not null (Bug#9951).
3593 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3594 may be NULL.
3595
89bd5ee1
EZ
35962011-11-04 Eli Zaretskii <eliz@gnu.org>
3597
3598 * window.c (Fwindow_body_size): Mention in the doc string that the
3599 return value is in frame's canonical units. (Bug#9949)
3600
84c3edb9
EZ
36012011-11-03 Eli Zaretskii <eliz@gnu.org>
3602
4e2fb5c7
EZ
3603 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3604
84c3edb9 3605 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3606 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3607 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3608
bc17a887
EZ
36092011-11-01 Eli Zaretskii <eliz@gnu.org>
3610
3611 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3612 Don't stop backward scan on the continuation glyph, even though
3613 its CHARPOS is positive.
6d5eb5b0
SM
3614 (mouse_face_from_buffer_pos, note_mouse_highlight):
3615 Rename cover_string to disp_string.
bc17a887 3616
4ee88440
MR
36172011-11-01 Martin Rudalics <rudalics@gmx.at>
3618
3619 * window.c (temp_output_buffer_show): Don't use
3620 Vtemp_buffer_show_specifiers.
3621 (Vtemp_buffer_show_specifiers): Remove unused variable.
3622
c2ff3c02
EZ
36232011-10-30 Eli Zaretskii <eliz@gnu.org>
3624
3625 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3626 past the beginning of the current glyph matrix.
3627
58179cce 36282011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3629
3630 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3631 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3632 HAVE_GTK3 (Bug#9869).
b77a6a7f 3633
3b574623
JD
3634 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3635 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3636
b77a6a7f
JD
3637 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3638
3639 * xterm.c: Declare x_handle_net_wm_state to return int.
3640 (handle_one_xevent): Check if we are iconified but don't have
3641 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3642 (get_current_wm_state): Return non-zero if not hidden,
3643 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3644 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3645 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3646 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3647
196e41e4
PE
36482011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3649
3650 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3651 so that this new function doesn't get optimized away by a
3652 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3653
021f2e1a
AS
36542011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3655
3656 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3657
8b058d44
EZ
36582011-10-29 Eli Zaretskii <eliz@gnu.org>
3659
3660 Fix the `xbytecode' command.
3661 * .gdbinit (xprintbytestr): New command.
b50a28de 3662 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3663 (xbytecode): Print the byte-code string as well.
3664
4452fb80
EZ
36652011-10-29 Kim Storm <storm@cua.dk>
3666
8b058d44
EZ
3667 * alloc.c (which_symbols): New function.
3668
21b72067
AS
36692011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3670
3671 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3672 line. (Bug#9903)
3673
83ed7b5c
GM
36742011-10-29 Glenn Morris <rgm@gnu.org>
3675
3676 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3677 Not clear what it was for, and it causes various bugs. (Bug#9839)
3678
5a7a728b
EZ
36792011-10-28 Eli Zaretskii <eliz@gnu.org>
3680
3681 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3682 possible random value that matches one of those tested as
3683 condition to clear the mouse face.
3684
d3d0842f
CY
36852011-10-28 Chong Yidong <cyd@gnu.org>
3686
3687 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3688
31b39d13
DN
36892011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3690
3691 * window.c (make_window): Initialize phys_cursor_on_p.
3692
9aba6043
SM
36932011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3694
3695 * lisp.h (struct Lisp_Symbol): Update comments.
3696
c20992f4
JB
36972011-10-28 Juanma Barranquero <lekktu@gmail.com>
3698
3699 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3700
db4f02f2
EZ
37012011-10-28 Eli Zaretskii <eliz@gnu.org>
3702
3703 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3704 <oslsachem@gmail.com> for helping to debug this.
3705
3706 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3707 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3708 (g_b_init_get_glyph_outline_w): New static variables.
3709 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3710 (GetGlyphOutlineW_Proc): New typedefs.
3711 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3712 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3713 New functions.
3714 (w32font_open_internal, compute_metrics):
3715 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3716 instead of calling the "wide" APIs directly.
3717
3718 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3719
3720 * w32.h (syms_of_w32font): Add prototype.
3721
87e68db4
JB
37222011-10-27 Juanma Barranquero <lekktu@gmail.com>
3723
3724 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3725 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3726 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3727 (Fmove_to_window_line): Doc fix.
3728
435c1d67
CY
37292011-10-27 Chong Yidong <cyd@gnu.org>
3730
3731 * process.c (make_process): Set gnutls_state to NULL.
3732
3733 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3734 non-NULL, regardless of GNUTLS_INITSTAGE.
3735 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3736 an error. Set process slots as soon as we allocate them.
3737
3738 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3739
9c6c6f49
CY
37402011-10-27 Chong Yidong <cyd@gnu.org>
3741
9aba6043
SM
3742 * gnutls.c (emacs_gnutls_deinit): New function.
3743 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3744 (Fgnutls_deinit, Fgnutls_boot): Use it.
3745
3746 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3747 (deactivate_process): Call emacs_gnutls_deinit.
3748
657d08d3
JB
37492011-10-27 Juanma Barranquero <lekktu@gmail.com>
3750
3751 * image.c (x_create_x_image_and_pixmap):
3752 * w32.c (sys_rename, w32_delayed_load):
3753 * w32font.c (fill_in_logfont):
3754 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3755
5430d399
JB
37562011-10-26 Juanma Barranquero <lekktu@gmail.com>
3757
3758 * w32fns.c (w32_default_color_map): New function,
3759 extracted from Fw32_default_color_map.
a7ef684b 3760 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3761
fe0055fa
PE
37622011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3763
3764 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3765
e6346438
SM
37662011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3767
3768 * keyboard.c (test_undefined): New function (bug#9751).
3769 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3770
e112cc37
ET
37712011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3772
3773 * sysdep.c (init_sys_modes): Fix the check for the controlling
3774 terminal (Bug#6649).
3775
7b5d6677
EZ
37762011-10-20 Eli Zaretskii <eliz@gnu.org>
3777
3778 * dispextern.h (struct bidi_it): New member next_en_type.
3779
3780 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3781 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3782 current character, check also for next_en_type being WEAK_EN.
3783 (bidi_resolve_weak): Don't enter the expensive loop if the current
3784 position is before next_en_pos. Record the bidi type of the first
3785 non-ET, non-BN character we find, in addition to its position.
3786 (bidi_level_of_next_char): Invalidate next_en_type when
3787 next_en_pos is over-stepped.
3788
7da0b018
PE
37892011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3790
3791 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3792 * editfns.c: Rewrite current-time-zone so that it invokes
3793 the equivalent of (format-time-string "%Z") to get the time zone name.
3794 This fixes a bug when the time zone name contains characters that
3795 need converting from the system time locale to Emacs internal format.
3796 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3797 that patch fixed format-time-string to do the conversion, but
3798 I forgot to fix current-time-zone.
3799 (format_time_string): New function, containing most of
3800 what Fformat_time_string used to contain.
3801 (Fformat_time_string): Rewrite in terms of format_time_string.
3802 This doesn't change this function's behavior.
3803 (current-time-zone): Rewrite to use format_time_string.
3804 This fixes the bug reported by Michael Schierl in
3805 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3806 Jason Rumney's 2007-06-07 change worked around this bug, but
3807 didn't fix it.
3808 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3809
8547b010
EZ
38102011-10-19 Eli Zaretskii <eliz@gnu.org>
3811
3812 * xdisp.c (start_display): If the character at POS is displayed
3813 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3814 (try_window_reusing_current_matrix): If a line ends in a display
3815 vector or the next line starts in a display vector, continue
3816 redrawing the window even though the character position of
3817 start_row was reached.
8547b010
EZ
3818 (Bug#9771, part 2)
3819
4e948d15
CY
38202011-10-18 Chong Yidong <cyd@gnu.org>
3821
3822 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3823 with nobreak-char-display too.
3824
4787455f
EZ
38252011-10-18 Eli Zaretskii <eliz@gnu.org>
3826
3827 Fix part 3 of bug#9771.
3828 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3829 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3830 non-neutral characters if the current character is a paragraph
3831 separator (a.k.a. Newline). This avoids running the same
3832 expensive loop twice, once when we consume the preceding newline
3833 and the other time when the line actually needs to be displayed.
3834 Avoid the loop when we see neutrals on the base embedding level
3835 following a character whose directionality is the same as the
3836 paragraph's. This avoids running the expensive loop when a line
3837 ends in a long sequence of neutrals, like control characters.
3838 Add assertion against STRONG_AL type. Slightly rearrange code
3839 that determines the type of a neutral given the first non-neutral
3840 that follows it.
3841 (bidi_level_of_next_char): Set next_en_pos to zero when
3842 invalidating its info.
3843
2c91f553
EZ
38442011-10-17 Eli Zaretskii <eliz@gnu.org>
3845
3846 * xdisp.c (push_display_prop): Determine whether to record string
3847 or buffer position by IT->string, not by IT->method. Allow
3848 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3849 (move_it_vertically_backward): Don't look for character position
3850 immediately after the newline when in a continuation line.
3851 (Bug#9771, part 1)
2c91f553 3852
c7b08b0d
MR
38532011-10-15 Martin Rudalics <rudalics@gmx.at>
3854
3855 * window.c (coordinates_in_window): Rewrite and delabelize
3856 vertical border check. (Bug#5357) (Bug#9618)
3857
6b02f655
SM
38582011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3859
3860 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3861 errors in XSetWindowBorder (bug#9310).
3862
81d40c92
DA
38632011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3864
3865 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3866 avoid crash when xmalloc overrun checking is enabled.
3867
d4172c3b
EZ
38682011-10-13 Eli Zaretskii <eliz@gnu.org>
3869
3870 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3871 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3872 cursor motion with <left> and <right> arrow keys.
3873
3874 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3875 some callers set that themselves.
3876
b00eea75
EZ
38772011-10-12 Eli Zaretskii <eliz@gnu.org>
3878
3879 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3880 display string and the previous row comes from the same string and
3881 is empty. (Bug#9739) (Bug#9738)
3882
8fe012c4
SM
38832011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3884
3885 * doc.c (get_doc_string): Encode file name (bug#9735).
3886
0074aef2
EZ
38872011-10-12 Eli Zaretskii <eliz@gnu.org>
3888
79beb178
EZ
3889 * bidi.c (bidi_level_of_next_char):
3890 * xdisp.c (get_visually_first_element): Remove old incorrect
3891 comments regarding the Unicode Line Separator character.
3892
0074aef2
EZ
3893 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3894
6e4b3fbe
DA
38952011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3896
3897 * alloc.c (Fgc_status): Do not access beyond zombies array
3898 boundary if nzombies > MAX_ZOMBIES.
3899 * alloc.c (dump_zombies): Add missing format specifier.
3900
0324f3af
PE
39012011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3902
b5525cac
PE
3903 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3904 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3905
0324f3af
PE
3906 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3907 Some packages use them to denote characters with modifiers.
3908
e9b5f888
AS
39092011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3910
3911 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3912 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3913 matching a pp-number. Rename parameter var to var1.
3914
127827c0
SM
39152011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3916
3917 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3918
c8fd3bd0
GM
39192011-10-08 Glenn Morris <rgm@gnu.org>
3920
3921 * callint.c (Fcall_interactively): Give a more explicit error for the
3922 'c' case with a non-character input. (Bug#8479)
3923
352ec8ff
EZ
39242011-10-08 Eli Zaretskii <eliz@gnu.org>
3925
03669ccb
EZ
3926 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3927 lines.
7061c986
EZ
3928 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3929 lines that are hscrolled on the left.
03669ccb 3930
352ec8ff
EZ
3931 * dispnew.c (buffer_posn_from_coords): Account for a possible
3932 presence of header-line. (Bug#4426)
3933
a66cfb1c
SM
39342011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3935
6b02f655
SM
3936 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3937 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3938
7c5ee88e
PE
39392011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3940
3941 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3942 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3943 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3944 this makes Emacs dump core during garbage collection on rare
3945 occasions. sizeof is obviously inferior to offsetof here, so
3946 stick with offsetof.
3947 (GC_POINTER_ALIGNMENT): New macro.
3948 (mark_memory): Omit 3rd (offset) arg; caller changed.
3949 Don't assume EMACS_INT alignment is the same as pointer alignment.
3950
df1bbe5b
SM
39512011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3952
3953 * keyboard.c (read_key_sequence_remapped): New var.
3954 (read_key_sequence): Compute remapping in the right buffer.
3955 (command_loop_1): Use read_key_sequence's remapping directly.
3956
51553db6
SM
39572011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3958
32c1fffd
SM
3959 * dired.c (file_name_completion): Don't expand file name.
3960 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3961 before checking file name handler.
3962
51553db6
SM
3963 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3964 they've been requested explicitly (bug#9591).
3965
b6bd1599 39662011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3967
3968 * keymap.c (Fsingle_key_description): Use make_specified_string
3969 instead of build_string to build string from push_key_description.
3970 (Bug#5193)
3971
f701dc2a
PE
39722011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3973
4222c55d
PE
3974 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3975 This fixes a Y2038 bug on 64-bit hosts.
3976 * buffer.c (reset_buffer):
3977 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3978 (Fclear_buffer_auto_save_failure):
3979 Use 0, not -1, to represent an unset failure time, since time_t
3980 might not be signed.
3981
f701dc2a
PE
3982 Remove dependency on glibc malloc internals.
3983 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3984 Move back here from lisp.h, but with their new implementations.
3985 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3986 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3987 * charset.c (charset_table_init): New static var.
3988 (syms_of_charset): Use it instead of xmalloc. This removes a
3989 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3990 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3991 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3992 Move back to alloc.c.
3993 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3994 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3995
9ceebf39
JD
39962011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3997
3998 * nsterm.m (windowDidResize): Call x_set_window_size only when
3999 ns_in_resize is true. Otherwise set pixelwidth/height and
4000 call change_frame_size (Bug#9628).
4001
cb993c58
PE
40022011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4003
3930c88b
PE
4004 Port --enable-checking=all to Fedora 14 x86-64.
4005 * charset.c (syms_of_charset): Also account for glibc malloc's
4006 internal overhead when calculating the initial malloc maximum.
4007
cb993c58
PE
4008 Port --enable-checking=all to Fedora 14 x86.
4009 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4010 Move to lisp.h.
4011 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4012 (overrun_check_realloc, overrun_check_free):
4013 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4014 That way, xmalloc returns a properly-aligned pointer even if
4015 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4016 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4017 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4018 into account when calculating the initial malloc maximum.
4019 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4020 Move here from alloc.c, so that charset.c can use it too.
4021 Properly align; the old code wasn't right for common 32-bit hosts
4022 when configured with --enable-checking=all.
4023 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4024 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4025
31bed486
EZ
40262011-09-29 Eli Zaretskii <eliz@gnu.org>
4027
04c70788 4028 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4029 use EDOM.
4030
fbcaa2f3
EZ
40312011-09-28 Eli Zaretskii <eliz@gnu.org>
4032
4033 * xdisp.c (compute_display_string_end): If there's no display
4034 string at CHARPOS, return -1.
4035
4036 * bidi.c (bidi_fetch_char): When compute_display_string_end
4037 returns a negative value, treat the character as a normal
4038 character not covered by a display string. (Bug#9624)
4039
a239d4e9
JB
40402011-09-28 Juanma Barranquero <lekktu@gmail.com>
4041
4042 * lread.c (Fread_from_string): Fix typo in docstring.
4043
88652fd5
EZ
40442011-09-27 Eli Zaretskii <eliz@gnu.org>
4045
4046 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4047 newline, reseat the iterator instead of bidi-iterating there one
4048 character at a time. (Bug#9610)
32c1fffd
SM
4049 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4050 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4051
ed497dd4
AS
40522011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4053
4054 * lread.c (readevalloop): Use correct code for NBSP.
4055 (read1): Likewise. (Bug#9608)
4056
b2bf61aa
MA
40572011-09-25 Michael Albinus <michael.albinus@gmx.de>
4058
4059 * dbusbind.c (Fdbus_register_signal): When service is not
4060 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4061
32bbb17c
GM
40622011-09-25 Glenn Morris <rgm@gnu.org>
4063
4064 * buffer.c (truncate-lines): Doc fix.
4065
94e0933e
CY
40662011-09-24 Chong Yidong <cyd@stupidchicken.com>
4067
4068 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4069 (Fset_window_next_buffers): Doc fix.
4070
cddde921
GM
40712011-09-24 Glenn Morris <rgm@gnu.org>
4072
4073 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4074
1260aef1
PE
40752011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4076
25b4bfa0
PE
4077 Fix minor problems found by static checking.
4078 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4079 * indent.c (Fvertical_motion): Fix == vs = typo.
4080
e3cbd34b
EZ
40812011-09-24 Eli Zaretskii <eliz@gnu.org>
4082
a66cfb1c
SM
4083 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4084 Default value is now t. Doc fix.
6bf7006f 4085
e3cbd34b 4086 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4087 logic when moving up, not only when moving down. Fix the
e3cbd34b 4088 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4089 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4090
4091 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4092 CHARPOS is covered by a display string which includes newlines.
4093 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4094 is covered by a display string with embedded newlines.
4095
a3de0cbd
MA
40962011-09-24 Michael Albinus <michael.albinus@gmx.de>
4097
4098 * dbusbind.c (Fdbus_register_signal): Add match rule to
4099 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4100 (Fdbus_register_method, Vdbus_registered_objects_table):
4101 Fix docstring.
a3de0cbd 4102
b260039d
JM
41032011-09-24 Jim Meyering <meyering@redhat.com>
4104
32c1fffd 4105 do not ignore write error for any output size
b260039d
JM
4106 The previous change was incomplete.
4107 While it makes emacs --batch detect the vast majority of stdout
4108 write failures, errors were still ignored whenever the output size is
4109 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4110 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4111 && echo FAIL: ignored write error
4112 FAIL: ignored write error
4113 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4114 && echo FAIL: ignored write error
4115 FAIL: ignored write error
4116 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4117
8eca8a7c
AS
41182011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4119
4120 * emacs.c (Fkill_emacs): In noninteractive mode exit
4121 non-successfully if a write error occurred on stdout. (Bug#9574)
4122
3341db62
EZ
41232011-09-21 Eli Zaretskii <eliz@gnu.org>
4124
4125 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4126 the xassert test.
4127
4128 * dispextern.h (struct it): Update the comment documenting what
4129 can it->OBJECT be.
4130
8c203dbf
EZ
41312011-09-20 Eli Zaretskii <eliz@gnu.org>
4132
4133 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4134 a display string, extend search for cursor position to end of row.
4135 (find_row_edges): If the row ends in a newline from a display
4136 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4137 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4138 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4139 non-empty line. Fixes confusing cursor motion with arrow keys at
4140 the beginning of a line that starts with whitespace.
8c203dbf 4141
a4824228
LMI
41422011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4143
4144 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4145 (bug#9493).
4146
33ed493b
CY
41472011-09-18 Chong Yidong <cyd@stupidchicken.com>
4148
4149 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4150 boolean (Bug#9154).
4151
56cd55c8
EZ
41522011-09-18 Eli Zaretskii <eliz@gnu.org>
4153
4154 * xdisp.c (display_line): Record maximum and minimum buffer
4155 positions even if no glyphs were produced (e.g., by a zero-width
4156 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4157 buffer positions that will be removed from the glyph row because
4158 they don't fit.
c02dcedf
EZ
4159 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4160 column is beyond frame width: don't subtract 1 "pixel" when
4161 computing width of the stretch.
3e62b7e0
EZ
4162 (reseat_at_next_visible_line_start): Undo the change made on
4163 2011-09-17 that saved paragraph information and restored it after
4164 the call to `reseat'. (Bug#9545)
56cd55c8 4165
5ed99d36 41662011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4167
4168 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4169 and turn window cursor on if cleared (Bug#9415).
4170
5ed99d36 41712011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4172
4173 * search.c (boyer_moore): Take unibyte characters from pattern
4174 literally. (Bug#9458)
4175
9bade7b2
EZ
41762011-09-18 Eli Zaretskii <eliz@gnu.org>
4177
4178 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4179
e5e9d610
PE
41802011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4181
87e4427a
PE
4182 Fix minor problem found by static checking.
4183 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4184 initialized, to pacify gcc -Wuninitialized.
4185
e5e9d610
PE
4186 * fileio.c: Report proper errno when syscall falls.
4187 (Finsert_file_contents): Save and restore errno,
4188 so that report_file_error outputs the correct diagnostic.
4189 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4190
a1674f0b
EZ
41912011-09-18 Eli Zaretskii <eliz@gnu.org>
4192
4193 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4194
fbfb6dd4
EZ
41952011-09-17 Eli Zaretskii <eliz@gnu.org>
4196
4197 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4198 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4199
bb187662
EZ
42002011-09-17 Eli Zaretskii <eliz@gnu.org>
4201
1137e8b8 4202 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4203 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4204
4205 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4206 (bidi_find_paragraph_start): Search back for paragraph beginning
4207 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4208 (bidi_move_to_visually_next): Only trigger paragraph-related
4209 computations when the last character is a newline or at EOB, not
4210 just any NEUTRAL_B. (Bug#9470)
4211
bb187662
EZ
4212 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4213 truncated lines if point is covered by a display string. (Bug#9524)
4214
2e621251
PE
42152011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4216
4217 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4218 (cons_to_x_long): New function.
4219 (lisp_data_to_selection_data): Use it. Correct the test for
4220 short-versus-long data; it was negated. Break out of vector
4221 loop, for efficiency, when a long datum is discovered.
4222
91a15bc6
SM
42232011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4224
4225 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4226
b41c3a35
EZ
42272011-09-16 Eli Zaretskii <eliz@gnu.org>
4228
4229 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4230 GCC PR/17406) by declaring this function with external scope.
4231
7812ba2d
PE
42322011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4233
4234 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4235 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4236
cf7edc2a
AS
42372011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4238
4239 * editfns.c (Fformat): Correctly handle text properties on "%%".
4240
bd01620e
EZ
42412011-09-15 Eli Zaretskii <eliz@gnu.org>
4242
4243 * xterm.c (x_draw_composite_glyph_string_foreground):
4244 * w32term.c (x_draw_composite_glyph_string_foreground):
4245 * term.c (encode_terminal_code):
4246 * composite.c (composition_update_it, get_composition_id):
4247 * xdisp.c (get_next_display_element)
4248 (fill_composite_glyph_string): Add comments about special meaning
4249 of TAB characters in a composition.
4250
a02719a3
PE
42512011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4252
4253 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4254 This occurs when processing a multibyte format.
4255 Problem reported by Wolfgang Jenker.
a02719a3 4256
72589a3c
JB
42572011-09-15 Johan Bockgård <bojohan@gnu.org>
4258
4259 * xdisp.c (try_cursor_movement): Only check for exact match if
4260 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4261
1c14176c
PE
42622011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4263
4264 Remove unused external symbols.
4265 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4266 * xdisp.c (calc_pixel_width_or_height): Now static.
4267 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4268 * indent.c (check_display_width):
4269 * w32term.c: Fix comment to match code.
4270 * xterm.c, xterm.h (x_catching_errors): Remove.
4271
d2eea5b5
PE
42722011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4273
4274 * xselect.c: Use signed conversions more consistently (Bug#9498).
4275 (selection_data_to_lisp_data): Assume incoming selection data are
4276 signed integers, not unsigned. This is to be consistent with
4277 outgoing selection data, which was modified to use signed integers
4278 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4279 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4280 expects long, not unsigned long.
4281
46888499
EZ
42822011-09-14 Eli Zaretskii <eliz@gnu.org>
4283
4284 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4285 computation of loop end. Reported by Johan Bockgård
4286 <bojohan@gnu.org>.
4287
ef8ef9fb
CY
42882011-09-13 Chong Yidong <cyd@stupidchicken.com>
4289
4290 * frame.c (Fother_visible_frames_p): Function deleted.
4291
fa819fed
EZ
42922011-09-12 Eli Zaretskii <eliz@gnu.org>
4293
4294 * indent.c (compute_motion): Process display vector front to back
4295 rather than the other way around. (Bug#2496)
4296
2ba8e008
SM
42972011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4298
4299 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4300
20f53c69
CY
43012011-09-11 Chong Yidong <cyd@stupidchicken.com>
4302
4303 * minibuf.c (Fread_from_minibuffer): Doc fix.
4304
d562d7a4
EZ
43052011-09-11 Eli Zaretskii <eliz@gnu.org>
4306
4307 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4308 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4309
1c4d7f3d
LMI
43102011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4311
4312 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4313 value for non-existent files.
4314
b885bf36
EZ
43152011-09-11 Eli Zaretskii <eliz@gnu.org>
4316
4317 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4318 set its "size" to -1. This will set the modtime_size field of
4319 the corresponding buffer to -1, which is what
4320 verify-visited-file-modtime expects for files that do not exist.
4321 (Bug#9139)
4322
6612f0bf
PE
43232011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4324
4325 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4326 here ...
4327 * lisp.h: ... from here. push_key_description is no longer
4328 defined in keyboard.c, so its declaration should not be in
4329 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4330 logically belongs with push_key_description.
4331
dfb3f755
PE
43322011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4333
4334 * buffer.h: Include <sys/types.h> instead of <time.h>.
4335 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4336 Problem reported by Herbert J. Skuhra.
4337
3134906c
LMI
43382011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4339
4340 * xml.c (parse_region): Make the parsing work for
4341 non-comment-starting XML files again (bug#9144).
4342
8d903f4e
AS
43432011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4344
4345 * image.c (gif_load): Fix calculation of bottom and right corner.
4346 (Bug#9468)
4347
80ad64f4
EZ
43482011-09-10 Eli Zaretskii <eliz@gnu.org>
4349
4350 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4351 redisplay in small windows.
4352
208a048d
EZ
43532011-09-09 Eli Zaretskii <eliz@gnu.org>
4354
4355 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4356
9b1c252e
MR
43572011-09-08 Martin Rudalics <rudalics@gmx.at>
4358
4359 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4360 Operate on live windows only.
4361
2949f33b
JB
43622011-09-08 Juanma Barranquero <lekktu@gmail.com>
4363
4364 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4365
e08dcafd
EZ
43662011-09-07 Eli Zaretskii <eliz@gnu.org>
4367
4368 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4369 only under bidi iteration.
4370
115b96bd
JD
43712011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4372
4373 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4374
c8199d0f
PE
43752011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4376
4377 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4378 Without this fix, the command to link temacs failed due to an
4379 undefined symbol __builtin_isnan. This is because
4380 /usr/include/iso/math_c99.h #defines isnan(x) to
4381 __builtin_isnan(x), but the bundled gcc, which identifies itself
4382 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4383 a __builtin_isnan.
4384 * floatfns.c (isnan): #undef, and then #define to a clone of
4385 what's in data.c.
4386 (Fisnan): Always define, since it's always available now.
4387 (syms_of_floatfns): Always define isnan at the Lisp level.
4388
e39b275c 43892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4390
4391 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4392
b2db44d9 43932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4394
f4af5137 4395 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4396 The previous code assumed that file offsets (off_t values) fit in
4397 EMACS_INT variables, which is not true on typical 32-bit hosts.
4398 The code messed up by falsely reporting buffer overflow in cases
4399 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4400 when "big" contains more than 2**29 bytes, even though this
4401 inserts just one byte and does not overflow the buffer.
4402 (Finsert_file_contents): Store file offsets as off_t
4403 values, not as EMACS_INT values. Check for overflow when
4404 converting between EMACS_INT and off_t. When checking for
4405 buffer overflow or for overlap, take the offsets into account.
4406 Don't use EMACS_INT for small values where int suffices.
4407 When checking for overlap, fix a typo: ZV was used where
4408 ZV_BYTE was intended.
4409 (Fwrite_region): Don't assume off_t fits into 'long'.
4410 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4411
ecfc0a49
MA
44122011-09-05 Michael Albinus <michael.albinus@gmx.de>
4413
4414 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4415
6511acf2 44162011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4417
0999621a 4418 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4419
4420 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4421 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4422 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4423 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4424 (modify_event_symbol): Do not assume that the length of
4425 name_alist_or_stem is safe to alloca and fits in int.
4426 (Fexecute_extended_command): Likewise for function name and binding.
4427 (Frecursion_depth): Wrap around reliably on integer overflow.
4428 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4429 since some callers pass EMACS_INT values.
4430 (Fsingle_key_description): Don't crash if symbol name contains more
4431 than MAX_ALLOCA bytes.
4432 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4433 (get_minibuffer): Arg is now EMACS_INT, not int.
4434 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4435 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4436 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4437
2be7d702
PE
4438 * dbusbind.c (signature_cat): New function.
4439 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4440 Do not overrun buffer; instead, report string overflow.
4441
9d1df220
PE
4442 * dispnew.c (add_window_display_history): Don't overrun buffer.
4443 Truncate instead; this is OK since it's just a log.
4444
33ef5c64
PE
4445 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4446 even if the time zone offset is outlandishly large.
4447 Don't mishandle offset == INT_MIN.
4448
66c6fdd5
PE
4449 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4450 when creating daemon; the previous buffer-overflow check was incorrect.
4451
d749b01b
PE
4452 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4453 which has the guts of the old verror function.
4454
b5cd1905
PE
4455 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4456 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4457
6e1a67fb
PE
4458 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4459 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4460 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4461 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4462 length of string rather than counting it via multiple sprintfs;
4463 that's simpler and more reliable.
c21721cc
PE
4464 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4465 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4466 sprintf, in case result does not fit in int.
4467
c57b67fc
PE
4468 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4469 (fontset_from_font): Print it.
4470
8a401434
PE
4471 * frame.c (tty_frame_count): Now printmax_t, not int.
4472 (make_terminal_frame, set_term_frame_name): Print it.
4473 (x_report_frame_params): In X, window IDs are unsigned long,
4474 not signed long, so print them as unsigned.
4475 (validate_x_resource_name): Check for implausibly long names,
4476 and don't assume name length fits in 'int'.
4477 (x_get_resource_string): Don't blindly alloca invocation name;
4478 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4479 not fit in int.
4480
6e1a67fb
PE
4481 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4482 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4483 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4484
0df02bf3
PE
4485 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4486 Use esprintf, not sprintf, in case result does not fit in int.
4487
48e30793
PE
4488 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4489 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4490 it as a large positive number.
4491 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4492 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4493
a66ff6d8
PE
4494 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4495 in case result does not fit in int.
4496
aca216ff
PE
4497 * print.c (float_to_string): Detect width overflow more reliably.
4498 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4499 buffer overrun. Don't assume list length fits in 'int'. Treat
4500 print length of 0 as 0, not as infinity; to be consistent with other
4501 uses of print length in this function. Don't overflow print length
4502 index. Don't assume hash table size fits in 'long', or that
4503 vectorlike size fits in 'unsigned long'.
4504
31c286f7
PE
4505 * process.c (make_process): Use printmax_t, not int, to format
4506 process-name gensyms.
4507
55e5faa1
PE
4508 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4509
80f2e268
PE
4510 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4511 to avoid potential buffer overrun.
4512
670741ab
PE
4513 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4514 if X resource line is longer than 512 bytes.
4515
b7163a50
PE
4516 * xfns.c (x_window): Make sprintf buffer a bit bigger
4517 to avoid potential buffer overrun.
4518
ae58ff1f
PE
4519 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4520
c43c8a6a
PE
4521 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4522
3f8236f4
PE
45232011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4524
53e9fe90 4525 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4526 Without these, Emacs silently mishandles large integers sometimes.
4527 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4528 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4529
6511acf2
PE
4530 * xdisp.c (try_window_id): Check Emacs fixnum range before
4531 converting to 'int'.
806add1d 4532
6511acf2 4533 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4534 Check that an Emacs fixnum is in range before assigning it to 'int'.
4535 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4536 values converted from Emacs fixnums.
4537 (Frecenter): Don't wrap around a line count if it is out of 'int'
4538 range; instead, treat it as an extreme value.
4539 (Fset_window_configuration, compare_window_configurations):
4540 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4541
6511acf2
PE
4542 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4543 that can exceed INT_MAX. Check that EMACS_INT value is in range
4544 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4545 (match_limit): Don't assume that a fixnum can fit in 'int'.
4546
6511acf2 4547 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4548 exceed INT_MAX.
4549
6511acf2 4550 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4551 (Fvertical_motion): Don't wrap around LINES values that don't fit
4552 in 'int'. Instead, treat them as extreme values. This is good
4553 enough for windows, which can't have more than INT_MAX lines anyway.
4554
fcb901a7
LMI
45552011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4556
0f2f6b6d
LMI
4557 * Require libxml/parser.h to avoid compilation warning.
4558
fcb901a7
LMI
4559 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4560
4561 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4562 since this reportedly can destroy thread storage.
4563
6e20a0d4
CY
45642011-08-30 Chong Yidong <cyd@stupidchicken.com>
4565
4566 * syntax.c (find_defun_start): Update all cache variables if
4567 exiting early (Bug#9401).
4568
148ae00e
EZ
45692011-08-30 Eli Zaretskii <eliz@gnu.org>
4570
f6cfbd8f
EZ
4571 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4572
148ae00e
EZ
4573 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4574 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4575 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4576
4577 * term.c (tty_append_glyph): New function.
4578 (produce_stretch_glyph): Static function and its prototype deleted.
4579
a66cfb1c
SM
4580 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4581 Add prototypes.
148ae00e 4582
c4a07a4c
PE
45832011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4584
4585 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4586 when checking :margin (Bug#9390).
4587 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4588 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4589 so that the name doesn't mislead. All uses changed.
4590
6bc8cd65
JB
45912011-08-28 Johan Bockgård <bojohan@gnu.org>
4592
4593 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4594 set_tty_hooks.
4595
dca4927e
EZ
45962011-08-27 Eli Zaretskii <eliz@gnu.org>
4597
4598 * xdisp.c (move_it_to): Don't bail out early when reaching
4599 position beyond to_charpos, if we are scanning backwards.
4600 (move_it_vertically_backward): When DY == 0, make sure we get to
4601 the first character in the line after the newline.
4602
f2cad773
PE
46032011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4604
4605 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4606 (ccl_driver): Do not generate an out-of-range pointer.
4607 (Fccl_execute_on_string): Remove unnecessary check for
4608 integer overflow, noted by Stefan Monnier in
4609 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4610 Remove a FIXME that didn't need fixing.
4611 Simplify the newly-introduced buffer reallocation code.
4612
0cae2cdb
JB
46132011-08-27 Juanma Barranquero <lekktu@gmail.com>
4614
4615 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4616
5fc295a4 46172011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4618
70c60eb2 4619 Integer and memory overflow issues (Bug#9196).
726e0ab1 4620
d31850da
PE
4621 * doc.c (get_doc_string): Rework so that
4622 get_doc_string_buffer_size is the actual buffer size, rather than
4623 being 1 less than the actual buffer size; this makes xpalloc more
4624 convenient.
4625
a69fbedb
PE
4626 * image.c (x_allocate_bitmap_record, cache_image):
4627 * xselect.c (Fx_register_dnd_atom):
4628 Simplify previous changes by using xpalloc.
4629
fe5c5d37
PE
4630 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4631 since either will do and ptrdiff_t is convenient with xpalloc.
4632
0065d054
PE
4633 * charset.c (charset_table_size)
4634 (struct charset_sort_data.priority): Now ptrdiff_t.
4635 (charset_compare): Don't overflow if priorities differ greatly.
4636 (Fsort_charsets): Don't assume list length fits in int.
4637 Check for size-calculation overflow when allocating sort data.
4638 (syms_of_charset): Allocate an initial charset table that is
4639 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4640
4641 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4642
4643 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4644 The actual value is always <= INT_MAX, and leaving it unsigned made
4645 overflow checking harder.
4646
4647 * dispextern.h (struct glyph_matrix.rows_allocated)
4648 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4649 with xpalloc. The values are still always <= INT_MAX.
4650
4651 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4652
4653 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4654 (SAFE_NALLOCA): New macro.
4655
4656 * region-cache.c (struct boundary.pos, find_cache_boundary)
4657 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4658 (set_cache_region, invalidate_region_cache)
4659 (revalidate_region_cache, know_region_cache, region_cache_forward)
4660 (region_cache_backward, pp_cache):
4661 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4662 so that ptrdiff_t * can be passed to xpalloc.
4663 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4664 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4665 (pp_cache): Don't assume cache_len fits in int.
4666 * region-cache.h: Adjust extern decls to match.
4667
4668 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4669 EMACS_INT, since either will do, for xpalloc.
4670
4671 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4672 (xnmalloc, xnrealloc, xpalloc): New functions.
4673
726e0ab1
PE
4674 * bidi.c (bidi_shelve_header_size): New constant.
4675 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4676 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4677
51f30bc5 4678 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4679 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4680 (overlay_strings):
4681 Don't update size of array until after memory allocation succeeds,
4682 because xmalloc/xrealloc may not return.
0065d054
PE
4683 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4684 now that we have proper integer overflow checking.
4685 (record_overlay_string, overlay_strings): Catch overflows when
4686 calculating size of overlay_str_buf.
726e0ab1 4687
0065d054
PE
4688 * callproc.c (Fcall_process): Check for size overflow when
4689 calculating size of args2.
4690 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4691 Normally we prefer signed values, but sticking with ptrdiff_t would
4692 require adding more-complicated checks.
726e0ab1
PE
4693
4694 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4695 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4696 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4697 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4698
4699 * character.c (Fstring): Check for size-calculation overflow.
4700
4701 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4702 unnecessary integer overflow. Check for size overflow.
4703 (encode_coding_object): Don't update size until xmalloc succeeds.
4704
4705 * composite.c (get_composition_id): Check for overflow in glyph
4706 length calculations.
4707
4708 Integer and memory overflow fixes for display code.
4709 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4710 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4711 (scrolling_window): Check for overflow in size calculations.
4712 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4713 Don't assume glyph table len fits in int.
4714 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4715 (row_table_size): Now ptrdiff_t, not int.
4716 (scrolling_window): Avoid overflow in size calculations.
4717 Don't update size until allocation succeeds.
4718 * fns.c (concat): Check for overflow in size calculations.
4719 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4720 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4721 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4722
4723 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4724 (get_doc_string): Check for size calculation overflow.
4725 Don't update size until allocation succeeds.
4726 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4727 EMACS_INT, where ptrdiff_t will do.
4728 (Fsubstitute_command_keys): Check for string overflow.
4729
4730 * editfns.c (set_time_zone_rule): Don't assume environment length
4731 fits in int.
4732 (message_length): Now ptrdiff_t, not int.
4733 (Fmessage_box): Don't update size until allocation succeeds.
4734 Don't assume message length fits in int.
4735 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4736
0065d054
PE
4737 * emacs.c (main): Do not reallocate argv, since there is a null at
4738 the end that can be overwritten, and this way there's no need to
4739 worry about size-calculation overflow.
4740 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4741
4742 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4743 alloc succeeds.
4744 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4745
4746 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4747 (x_set_scroll_bar_width, x_figure_window_size):
4748 Check for integer overflow.
4749 (x_set_alpha): Do not assume XINT fits in int.
4750
4751 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4752 This is for the members text_lines, text_cols, total_lines, total_cols,
4753 where the system imposes an 'int' limit.
4754
4755 * fringe.c (Fdefine_fringe_bitmap):
4756 Don't update size until alloc works.
4757
4758 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4759 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4760
4761 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4762 Check for size-calculation overflow.
4763 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4764 do, as we prefer signed integers.
4765 (id_to_widget.max_size, id_to_widget.used)
4766 (xg_store_widget_in_map, xg_remove_widget_from_map)
4767 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4768 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4769 Use and return ptrdiff_t, not int.
4770 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4771 * gtkutil.h: Change prototypes to match the above.
4772
4773 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4774 are duplicate now that they've been promoted to lisp.h.
4775 (x_allocate_bitmap_record, x_alloc_image_color)
4776 (make_image_cache, cache_image, xpm_load):
4777 Don't update size until alloc is done.
4778 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4779 (x_detect_edges):
3256efce 4780 Check for size calculation overflow.
726e0ab1
PE
4781 (ct_colors_allocated_max): New constant.
4782 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4783 overflow.
3256efce 4784
726e0ab1
PE
4785 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4786 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4787 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4788 Use ptrdiff_t, not int, to count maps.
4789 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4790 calculations. Don't update size until allocation succeeds.
4791 Redo calculations to avoid overflow.
726e0ab1
PE
4792 * keyboard.h: Change prototypes to match the above.
4793
4794 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4795 to count maps.
4796 (current_minor_maps): Check for size calculation overflow.
4797 * keymap.h: Change prototypes to match the above.
4798
4799 * lread.c (read1, init_obarray): Don't update size until alloc done.
4800
4801 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4802 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4803
726e0ab1
PE
4804 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4805 Now ptrdiff_t, not int.
4806 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4807 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4808
4809 * process.c (Fnetwork_interface_list): Check for overflow
4810 in size calculation.
4811
4812 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4813
4814 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4815 overflow. Don't bother calling xmalloc when xrealloc will do.
4816
4817 * search.c (Freplace_match): Check for size calculation overflow.
4818 (Fset_match_data): Don't assume list lengths fit in 'int'.
4819
4820 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4821 for command line length. Do not attempt to address one before the
4822 beginning of an array, as that's not portable.
4823
4824 * term.c (max_frame_lines): Remove; unused.
4825 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4826 not int.
4827 (encode_terminal_code, calculate_costs): Check for size
4828 calculation overflow.
4829 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4830 table lengths and related sizes. Don't update size until alloc
4831 done. Redo calculations to avoid overflow.
4832 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4833
4834 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4835 subtracting pointers.
4836 (gobble_line): Check for overflow more carefully. Don't update size
4837 until alloc done.
4838
4839 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4840 Don't update size until alloc done.
4841 Redo size calculations to avoid overflow.
4842 Check for size calculation overflow.
0065d054 4843 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4844
4845 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4846 Use ptrdiff_t, not int, for sizes.
4847 (store_mode_line_noprop_char): Don't update size until alloc done.
4848
0065d054
PE
4849 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4850 Use ptrdiff_t, not int, for sizes.
4851 (Finternal_make_lisp_face, cache_face):
4852 Check for size calculation overflow.
4853 (cache_face): Treat size calculation overflows as if they were
4854 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4855
4856 * xfns.c (x_encode_text, x_set_name_internal)
4857 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4858 sizes, since they can exceed INT_MAX in size. Check for size
4859 calculation overflow.
4860
0065d054
PE
4861 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4862 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4863 Don't update size until alloc done.
4864
0065d054 4865 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4866 as sprintf is limited to int lengths.
1d526e2f 4867
252c5ee1
PE
4868 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4869 (X_LONG_MIN): New macros.
864d7ce7
PE
4870 Use them to make the following changes clearer.
4871 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4872 This change doesn't affect the value now, but it may help remind
4873 future maintainers not to raise the value too much later.
4874 (SELECTION_QUANTUM): Remove, replacing with ...
4875 (selection_quantum): ... new function, which avoids overflow.
4876 All uses changed.
4877 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4878 assumption that selection length fits in 'int'.
4879 (x_reply_selection_request, x_handle_selection_request)
4880 (x_get_window_property, receive_incremental_selection)
4881 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4882 (lisp_data_to_selection_data, clean_local_selection_data):
4883 Use ptrdiff_t, not int, to record length of selection.
4884 (x_reply_selection_request, x_get_window_property)
4885 (receive_incremental_selection, x_property_data_to_lisp):
4886 Redo calculations to avoid overflow.
4887 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4888 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4889 something.
4890 (x_get_window_property, receive_incremental_selection)
4891 (lisp_data_to_selection_data, x_property_data_to_lisp):
4892 Check for size-calculation overflow.
4893 (x_get_window_property, receive_incremental_selection)
4894 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4895 Don't store size until memory allocation succeeds.
4896 (x_get_window_property): Plug memory leak on memory exhaustion.
4897 Don't double-block input; malloc is safe here. Don't assume 2**34
4898 - 4 fits in unsigned long. Add an xassert to check
4899 XGetWindowProperty overflow. Be more careful about overflow
4900 calculations, and distinguish size from memory overflow better.
4901 (receive_incremental_selection): When tracing, don't assume
4902 unsigned int is less than INT_MAX.
4903 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4904 harmful) conversions of unsigned short to int.
4905 (lisp_data_to_selection_data): Don't assume that integers
4906 in the range -65535 through -1 fit in an X unsigned short.
4907 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4908 result parameters unless successful. Rely on cons_to_unsigned
4909 to report problems with elements; the old code wasn't right anyway.
4910 (x_check_property_data): Check for int overflow; we cannot use
4911 a wider type due to X limits.
4912 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4913
726e0ab1 4914 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4915
0065d054
PE
4916 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4917 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4918 (x_color_cells): Don't store size until memory allocation succeeds.
4919 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4920 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4921 (x_term_init): Don't assume length fits in int (sprintf is limited
4922 to int size).
bc18e09d 4923
ebfa62c0
PE
4924 Use ptrdiff_t for composition IDs.
4925 * character.c (lisp_string_width):
4926 * composite.c (composition_table_size, n_compositions)
4927 (get_composition_id, composition_gstring_from_id):
4928 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4929 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4930 * window.c (Frecenter):
4931 Use ptrdiff_t, not int, for composition IDs.
4932 * composite.c (get_composition_id): Check for integer overflow.
4933 * composite.h: Adjust prototypes to match the above changes.
4934
d3411f89
PE
4935 Use ptrdiff_t for hash table indexes.
4936 * category.c (hash_get_category_set):
4937 * ccl.c (ccl_driver):
4938 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4939 * coding.c (coding_system_charset_list, detect_coding_system):
4940 * coding.h (struct coding_system.id):
4941 * composite.c (get_composition_id, gstring_lookup_cache):
4942 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4943 * image.c (xpm_get_color_table_h):
4944 * lisp.h (hash_lookup, hash_put):
4945 * minibuf.c (Ftest_completion):
4946 Use ptrdiff_t for hash table indexes, not int (which is too
4947 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4948 32-bit --with-wide-int hosts).
4949
e097a6fa
PE
4950 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4951 Add a FIXME comment about memory leaks.
4952 (syms_of_charset): Don't assume xmalloc returns.
4953
5637687f
PE
4954 Don't assume that stated character widths fit in int.
4955 * character.c (Fchar_width, c_string_width, lisp_string_width):
4956 * character.h (CHAR_WIDTH):
4957 * indent.c (MULTIBYTE_BYTES_WIDTH):
4958 Use sanitize_char_width to avoid undefined and/or bad behavior
4959 with outlandish widths.
a66cfb1c 4960 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4961 now that we have two such functions. All uses changed.
4962 (sanitize_char_width): New inline function.
4963
a2271ba2
PE
4964 Don't assume that tab-width fits in int.
4965 * character.h (sanitize_width): New inline function.
4966 (SANE_TAB_WIDTH): New macro.
4967 (ASCII_CHAR_WIDTH): Use it.
4968 * indent.c (sane_tab_width): Remove. All uses replaced by
4969 SANE_TAB_WIDTH (current_buffer).
4970 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4971
18c52557
PE
4972 * fileio.c: Integer overflow issues with file modes.
4973 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4974
caeeedc1
PE
4975 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4976 Remove unreachable code.
4977 (read_hex, load_charset_map_from_file): Check for integer overflow.
4978
6df6ae42 4979 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4980 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4981 (x_send_scroll_bar_event): Likewise. Check that the size does not
4982 exceed limits imposed by XClientMessageEvent, as well as the usual
4983 ptrdiff_t and size_t limits.
4984
b13995db
PE
4985 * keyboard.c: Overflow, signedness and related fixes.
4986 (make_lispy_movement): Use same integer type in forward decl
4987 that is used in the definition.
4988 (read_key_sequence, keyremap_step):
4989 Change bufsize argument back to int, undoing my 2011-03-30 change.
4990 We prefer signed types, and int is wide enough here.
4991 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4992 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4993 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4994 length, not size_t. Use ptrdiff_t for index, not int.
4995 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4996 possibility of integer overflow.
4997
13464394
PE
4998 Overflow, signedness and related fixes for images.
4999
5000 * dispextern.h (struct it.stack[0].u.image.image_id)
5001 (struct_it.image_id, struct image.id, struct image_cache.size)
5002 (struct image_cache.used, struct image_cache.ref_count):
5003 * gtkutil.c (update_frame_tool_bar):
5004 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5005 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5006 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5007 * nsmenu.m (update_frame_tool_bar):
5008 * xdisp.c (calc_pixel_width_or_height):
5009 * xfns.c (image_cache_refcount):
5010 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5011 on typical 64-bit hosts.
5012
5013 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5014 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5015 Omit unnecessary casts to int.
5016 (parse_image_spec): Check that integers fall into 'int' range
5017 when the callers expect that.
5018 (image_ascent): Redo ascent calculation to avoid int overflow.
5019 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5020 (lookup_image): Remove unnecessary tests.
5021 (xbm_image_p): Locals are now of int, not EMACS_INT,
5022 since parse_image_check makes sure they fit into int.
5023 (png_load, gif_load, svg_load_image):
5024 Prefer int to unsigned where either will do.
5025 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5026 old tiff_error_handler and tiff_warning_handler.
5027 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5028 stack buffer overflows. It uses only the features of vsnprintf
5029 that are common to both POSIX and native Microsoft.
5030 (tiff_error_handler, tiff_warning_handler): Use it.
5031 (tiff_load, gif_load, imagemagick_load_image):
5032 Don't assume :index value fits in 'int'.
5033 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5034 (imagemagick_load_image): Check that crop parameters fit into
5035 the integer types that MagickCropImage accepts. Don't assume
5036 Vimagemagick_render_type has a nonnegative value. Don't assume
5037 size_t fits in 'long'.
5038 (gs_load): Use printmax_t to print the widest integers possible.
5039 Check for integer overflow when computing image height and width.
5040
c11821d4
EZ
50412011-08-26 Eli Zaretskii <eliz@gnu.org>
5042
5043 * xdisp.c (redisplay_window): Don't force window start if point
5044 will be invisible in the resulting window. (Bug#9324)
5045
0c95fcf7
EZ
50462011-08-25 Eli Zaretskii <eliz@gnu.org>
5047
5048 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5049 the display spec is of the form `(space ...)'.
5050 (handle_display_spec): Return the value returned by
5051 handle_single_display_spec, not just 1 or zero.
5052 (handle_single_display_spec): If the display spec is of the form
5053 `(space ...)', and specifies display in the text area, return 2
5054 rather than 1.
fee65a97 5055 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5056 accurately, and prefer exact match for point under bidi.
5057 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5058
5059 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5060 into disp_prop; all users changed.
5061
5062 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5063 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5064 for the text covered by the display property.
5065
e4ed06f1
CY
50662011-08-25 Chong Yidong <cyd@stupidchicken.com>
5067
5068 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5069 Change return value to nil.
5070 (Frecord_buffer): Delete unused function.
5071
f67cdd7f
EZ
50722011-08-24 Eli Zaretskii <eliz@gnu.org>
5073
5980d4c6
EZ
5074 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5075 buffers, return left-to-right.
8610fe8b
EZ
5076 (set_cursor_from_row): Consider candidate row a win if its glyph
5077 represents a newline and point is on that newline. Fixes cursor
5078 positioning on the newline at EOL of R2L text within L2R
5079 paragraph, and vice versa.
5080 (try_cursor_movement): Check continued rows, in addition to
5081 continuation rows. Fixes unwarranted scroll when point enters a
5082 continued line of R2L text within an L2R paragraph, or vice versa.
5083 (cursor_row_p): Consider the case of point being equal to
5084 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5085 from the end of a short line to the beginning of a continued line
5086 of R2L text within L2R paragraph.
5087 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5088 composed characters.
5980d4c6 5089
f67cdd7f
EZ
5090 * bidi.c (bidi_check_type): Use xassert.
5091 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5092 members.
5093
bca633fb
EZ
50942011-08-23 Eli Zaretskii <eliz@gnu.org>
5095
5096 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5097 a character.
5098
4a5885a7
CY
50992011-08-23 Chong Yidong <cyd@stupidchicken.com>
5100
5101 * nsfont.m (ns_otf_to_script): Fix typo.
5102
0902a04e
KH
51032011-08-22 Kenichi Handa <handa@m17n.org>
5104
5105 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5106 extra slot even if the purpose is char-code-property-table.
5107
1a2e6670
EZ
51082011-08-23 Eli Zaretskii <eliz@gnu.org>
5109
8ddde651
EZ
5110 * xdisp.c (redisplay_window): When computing centering_position,
5111 account for the height of the header line. (Bug#8874)
5112
425cc014
EZ
5113 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5114 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5115 candidate is selected by the mouse, and that candidate has a
5116 composed character under the mouse.
5117
1a2e6670
EZ
5118 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5119 coordinates reported by pos-visible-in-window-p for a composed
5120 character in column zero.
5121
8b76d6f8
SM
51222011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5123
5124 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5125
dac347dd
EZ
51262011-08-22 Eli Zaretskii <eliz@gnu.org>
5127
5128 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5129 consider it a hit if to_charpos is anywhere in the range of the
5130 composed buffer positions.
5131
e013fb34
CY
51322011-08-22 Chong Yidong <cyd@stupidchicken.com>
5133
5134 * image.c (gif_load): Don't assume that each subimage has the same
5135 dimensions as the base image. Handle disposal method that is
5136 "undefined" by the gif spec (Bug#9335).
5137
bd1ba3e8
CY
51382011-08-20 Chong Yidong <cyd@stupidchicken.com>
5139
5140 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5141 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5142
54a1215b
EZ
51432011-08-19 Eli Zaretskii <eliz@gnu.org>
5144
823564e5
EZ
5145 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5146 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5147 from an Org mode buffer to a Speedbar frame.
5148
54a1215b
EZ
5149 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5150 a composition, take its buffer position from IT->cmp_it.charpos.
5151 Fixes cursor positioning at the beginning of a line that begins
5152 with a composed character.
5153
9778ebcc
EZ
51542011-08-18 Eli Zaretskii <eliz@gnu.org>
5155
0be6ee06
EZ
5156 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5157 character bidirectional type, use STRONG_L instead. Fixes crashes
5158 in a buffer produced by `describe-categories'.
5159
9778ebcc
EZ
5160 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5161 members before the level stack, so they would be saved and
5162 restored when copying iterator state. Fixes incorrect reordering
5163 around TABs covered by display properties.
5164
156bffbe
AS
51652011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5166
6b02f655 5167 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5168
72ad093b
CY
51692011-08-17 Chong Yidong <cyd@stupidchicken.com>
5170
5171 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5172 (internal_condition_case_2, internal_condition_case_n):
5173 Remove unnecessary aborts (Bug#9081).
72ad093b 5174
35774242
EZ
51752011-08-17 Eli Zaretskii <eliz@gnu.org>
5176
5177 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5178 has no `load' handler, try opening the file locally. (Bug#9311)
5179
db76dd85
KB
51802011-08-16 Ken Brown <kbrown@cornell.edu>
5181
5182 * gmalloc.c: Expand comment.
5183
b215eee5
EZ
51842011-08-16 Eli Zaretskii <eliz@gnu.org>
5185
5186 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5187 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5188
a4579d33
KB
51892011-08-16 Ken Brown <kbrown@cornell.edu>
5190
5191 Fix memory allocation problems in Cygwin build (Bug#9273).
5192
5193 * unexcw.c ( __malloc_initialized): Declare external variable.
5194 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5195
8b76d6f8
SM
5196 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5197 New variables.
a4579d33
KB
5198 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5199 dumped emacs.
5200 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5201 in the static heap.
5202 [CYGWIN] (special_realloc): New function.
5203 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5204 requests to realloc storage in the static heap.
5205
3ebec551
PE
52062011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5207
5208 * bidi.c (bidi_initialize): Remove unused local.
5209
9fd8be00
EZ
52102011-08-15 Eli Zaretskii <eliz@gnu.org>
5211
6b02f655
SM
5212 * bidimirror.h:
5213 * biditype.h: Remove file.
5214 * makefile.w32-in ($(BLD)/bidi.$(O)):
5215 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5216
5217 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5218
5219 * chartab.c: Improve commentary for the uniprop_table API.
5220
32413314
EZ
5221 * bidi.c (bidi_paragraph_init): Support zero value of
5222 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5223 (bidi_initialize): Use uniprop_table instead of including
5224 biditype.h and bidimirror.h.
32413314 5225
9fd8be00
EZ
5226 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5227 coordinates of the iterator when restoring from ppos_it.
5228 (Bug#9296)
5229
5cf2b69b
KH
52302011-08-14 Kenichi Handa <handa@m17n.org>
5231
5232 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5233 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5234
daf17d00
EZ
52352011-08-14 Eli Zaretskii <eliz@gnu.org>
5236
5237 * xdisp.c (move_it_in_display_line_to): Don't invoke
5238 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5239 ppos_it. Fixes vertical cursor motion when line beginning is
5240 covered by an image. (Bug#9296)
5241
08e3161a
JD
52422011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5243
5244 * nsterm.h (ns_run_ascript): Declare.
5245 (NSAPP_DATA2_RUNASSCRIPT): Define.
5246
5247 * nsfns.m (as_script, as_result, as_status): New static variables.
5248 (ns_run_ascript): New function.
5e617bc2 5249 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5250 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5251 the event loop. Get status from as_status (Bug#7276).
5252
5253 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5254 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5255 the event loop (Bug#7276).
5256
a3720aa2
AS
52572011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5258
5259 * gnutls.c (QCgnutls_bootprop_priority)
5260 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5261 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5262 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5263 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5264 (QCgnutls_bootprop_verify_hostname_error)
5265 (QCgnutls_bootprop_callbacks_verify): Rename from
5266 Qgnutls_bootprop_..., all uses changed.
5267
5268 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5269 uses changed.
5270
0a0d27fb
PE
52712011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5272
19d5c50c
PE
5273 * xfaces.c (Qframe_set_background_mode): Now static.
5274 * dispextern.h (Qframe_set_background_mode): Remove decl.
5275
0a0d27fb
PE
5276 * process.c (Fnetwork_interface_info): Declare local only if needed.
5277
377538cb
JD
52782011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5279
5280 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5281 (Fnetwork_interface_list): Allocate in increments of bytes instead
5282 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5283 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5284 sockaddr.
5285 (struct ifflag_def): notrailers is smart on OSX.
5286 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5287 Get hardware address with getifaddrs if available.
5288
08fff70c
EZ
52892011-08-12 Eli Zaretskii <eliz@gnu.org>
5290
5291 * xdisp.c (iterate_out_of_display_property): xassert that
5292 IT->position is set to within IT->object's boundaries. Break from
5293 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5294 when IT->position is set up wrongly due to some bug.
5295 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5296 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5297 entry. Force push_it to save on the stack the current
5298 buffer/string position, to be restored by pop_it. Fix flags in
5299 the iterator structure wrt the object coming from a display
5300 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5301 properties. (Bug#9284)
5302
7be1c708 53032011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5304
7be1c708
CY
5305 * fontset.c (fontset_get_font_group): Add proper type checks.
5306 (Bug#9172)
aac0c6e3 5307
7be1c708 53082011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5309
7be1c708
CY
5310 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5311 and LC_VERSION_MIN_MACOSX.
5312 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5313 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5314
97bb72a6
EZ
53152011-08-08 Eli Zaretskii <eliz@gnu.org>
5316
5317 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5318 no-display-properties-and-no-overlays under bidi display.
5319 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5320 properties and overlays.
97bb72a6 5321
d5617611
CY
53222011-08-08 Chong Yidong <cyd@stupidchicken.com>
5323
37e11a63
CY
5324 * editfns.c (Fset_time_zone_rule): Document relationship with the
5325 setenv function.
5326
d5617611
CY
5327 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5328 the font entity extracted from the cache (Bug#8109).
5329
58872834
CY
53302011-08-07 Chong Yidong <cyd@stupidchicken.com>
5331
5332 * composite.c (autocmp_chars): Don't reset point. That is done by
5333 restore_point_unwind (Bug#5984).
5334
75bfc667
JL
53352011-08-07 Juri Linkov <juri@jurta.org>
5336
5337 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5338 to show the arg `TIME' instead of `TIMEVAL'.
5339
d1410150
EZ
53402011-08-06 Eli Zaretskii <eliz@gnu.org>
5341
5342 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5343 display property strides EOL and includes a newline, as in
5344 longlines-mode. (Bug#9254)
75b771e4
EZ
5345 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5346 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5347
5348 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5349 is non-zero, even if the data buffer is NULL. Fixes a crash in
5350 vertical-motion with longlines-mode. (Bug#9254)
5351
35928349
EZ
53522011-08-05 Eli Zaretskii <eliz@gnu.org>
5353
ec7cc85b
EZ
5354 * bidi.c <bidi_cache_total_alloc>: Now static.
5355 (bidi_initialize): Initialize bidi_cache_total_alloc.
5356
8b76d6f8 5357 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5358 cache. (Bug#9221)
5359
5360 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5361 amount allocated this far in `bidi_cache_total_alloc'.
5362 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5363 non-zero, only free the data buffer without restoring the cache
5364 contents. All callers changed.
5365
5366 * dispextern.h (bidi_unshelve_cache): Update prototype.
5367
5368 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5369 (move_it_in_display_line, move_it_to)
5370 (move_it_vertically_backward, move_it_by_lines): Replace the call
5371 to xfree to an equivalent call to bidi_unshelve_cache.
5372 (move_it_in_display_line_to): Fix logic of returning
412b6358 5373 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5374
e2e2423b
EZ
53752011-08-05 Eli Zaretskii <eliz@gnu.org>
5376
5377 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5378 came from a string character with a `cursor' property. (Bug#9229)
5379
ae9e757a
JD
53802011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5381
5382 * Makefile.in (LIB_PTHREAD): New variable.
5383 (LIBES): Add LIB_PTHREAD (Bug#9216).
5384
5385 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5386 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5387
213bd7f2
AS
53882011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5389
6b02f655 5390 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5391
99aaf75f
JD
53922011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5393
5394 * xterm.c (x_find_topmost_parent): New function.
5395 (x_set_frame_alpha): Find topmost parent window with
5396 x_find_topmost_parent and set the property there also (bug#9181).
5397 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5398
c74e9d86
PE
53992011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5400
5401 * callproc.c (Fcall_process): Avoid vfork clobbering
5402 the local vars buffer, coding_systems, current_dir.
5403
640c8776
SM
54042011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5405
5406 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5407
f26d0e4c
PE
54082011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5409
8a10d76c
PE
5410 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5411 so that it is not optimized away.
5412
f26d0e4c
PE
5413 * xdisp.c (compute_display_string_pos): Remove unused local.
5414
55439c61
EZ
54152011-08-02 Eli Zaretskii <eliz@gnu.org>
5416
5417 Fix slow cursor motion and scrolling in large buffers with
5418 selective display, like Org Mode buffers. (Bug#9218)
5419
5420 * dispextern.h (struct bidi_it): New member disp_prop_p.
5421
5422 * xdisp.c: Remove one-slot cache of display string positions.
5423 (compute_display_string_pos): Accept an additional argument
5e617bc2 5424 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5425 for a display string or property. If found, set DISP_PROP_P
5426 non-zero.
5427
5428 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5429 DISP_PROP_P, and pass it to compute_display_string_pos.
5430 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5431 non-zero. All callers of bidi_fetch_char changed.
5432
fb33fa43
SM
54332011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5434
5435 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5436
b099e063
DM
54372010-12-03 Don March <don@ohspite.net>
5438
5439 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5440 last character M-[char] is translated to ESC [char] (bug#7541).
5441
5cc7f7af
KH
54422011-08-02 Kenichi Handa <handa@m17n.org>
5443
d0fffa3f 5444 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5445
5446 * chartab.c (uniprop_table): Make it non-static.
5447
525d5e6e
EZ
54482011-08-01 Eli Zaretskii <eliz@gnu.org>
5449
5450 * xdisp.c (forward_to_next_line_start): Accept additional argument
5451 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5452 on the newline.
5453 (reseat_at_next_visible_line_start): Use the bidi iterator state
5454 returned by forward_to_next_line_start to restore the state of
5455 it->bidi_it after backing up to previous newline. (Bug#9212)
5456
31011111
AS
54572011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5458
5459 * regex.c (re_comp): Protoize.
5460 (re_exec): Fix return type.
5461 (regexec): Fix type of `ret'. (Bug#9203)
5462
476371c4
PE
54632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5464
e5d76069
PE
5465 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5466 This is needed if max-image-size is a floating-point number.
5467
9a79b20c
AS
54682011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5469
5470 * print.c (print_object): Print empty symbol as ##.
5471
5472 * lread.c (read1): Read ## as empty symbol.
5473
d8c2fa78
AA
54742011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5475
5476 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5477 setting frame foreground color (Bug#9175).
5478 (x_set_background_color): Likewise.
5479
ffe57a7a
AA
5480 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5481 contents (Bug#9176).
5482 (EmacsTooltip -init): Remove bezels and add shadows to
5483 tooltip windows.
5484
bf3492a5
AA
5485 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5486 or scroll bar (Bug#8470).
5487
d55e9c53
AA
5488 * nsfont.m (nsfont_open): Remove assignment to voffset and
5489 unnecessary vars hshink, expand, hd, full_height, min_height.
5490 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5491
5492 * nsterm.h (nsfont_info): Remove voffset field.
5493
d8c2fa78 54942011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5495
5496 Implement strike-through and overline on NextStep (Bug#8863).
5497
5498 * nsfont.m (nsfont_open): Use underline position provided by font,
5499 instead of hard-coded value of 2.
5500 (nsfont_draw): Call ns_draw_text_decoration instead.
5501
5502 * nsterm.h: Add declaration for ns_draw_text_decoration.
5503
5504 * nsterm.m (ns_draw_text_decoration): New function for drawing
5505 underline, overline, and strike-through.
5506 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5507 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5508 accommodate underlining, etc.
4843aac3 5509
4cc60b9b
EZ
55102011-07-28 Eli Zaretskii <eliz@gnu.org>
5511
bc7ece87
EZ
5512 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5513 default.
4cc60b9b 5514
476371c4
PE
55152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5516
66606eea
PE
5517 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5518 Without this fix, if a signal arrives just after memory fills up,
5519 'malloc' might be invoked reentrantly.
5520
476371c4
PE
5521 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5522 In other words, assume that every image size is allowed, on non-X
5523 hosts. This assumption is probably wrong, but it lets Emacs compile.
5524
f3fcc40d
AS
55252011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5526
5527 * regex.c (re_iswctype): Convert return values to boolean.
5528
350c992f
EZ
55292011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5530
5531 * xdisp.c (compute_display_string_pos): Don't use cached display
5532 string position if the buffer had its restriction changed.
5533 (Bug#9184)
5534
5266b4bb
PE
55352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5536
5537 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5538
2573a837 55392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5540
41f55ccd 5541 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5542
39e378da
PE
5543 * bidi.c: Integer size and overflow fixes.
5544 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5545 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5546 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5547 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5548 (bidi_find_other_level_edge):
5549 Use ptrdiff_t instead of EMACS_INT where either will do.
5550 This works better on 32-bit hosts configured --with-wide-int.
5551 (bidi_cache_ensure_space): Check for size-calculation overflow.
5552 Use % rather than repeated addition, for better worst-case speed.
5553 Don't set bidi_cache_size until after xrealloc returns, because it
5554 might not return.
5555 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5556 (bidi_cache_ensure_space): Also check that the bidi cache size
5557 does not exceed that of the largest Lisp string or buffer. See Eli
5558 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5559
5e927815
PE
5560 * alloc.c (__malloc_size_t): Remove.
5561 All uses replaced by size_t. See Andreas Schwab's note
5562 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5563
ca4aa935
PE
5564 * image.c: Improve checking for integer overflow.
5565 (check_image_size): Assume that f is nonnull, since
5566 it is always nonnull in practice. This is one less thing to
5567 worry about when checking for integer overflow later.
5568 (x_check_image_size): New function, which checks for integer
5569 overflow issues inside X.
5570 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5571 This removes the need for a memory_full check.
5572 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5573 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5574 (xbm_read_bitmap_data): Change locals back to 'int', since
5575 their values must fit in 'int'.
5576 (xpm_load_image, png_load, tiff_load):
5577 Invoke x_create_x_image_and_pixmap earlier,
5578 to avoid much needless work if the image is too large.
5579 (tiff_load): Treat overly large images as if
5580 x_create_x_image_and_pixmap failed, not as malloc failures.
5581 (gs_load): Use x_check_image_size.
5582
5f8f9cc2
PE
5583 * gtkutil.c: Omit integer casts.
5584 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5585 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5586
5adf60bc
PE
5587 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5588
c8907a93
PE
5589 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5590 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5591 would wrongly return t on a 64-bit host.
5592
e3c25c68
PE
5593 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5594 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5595 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5596 and therefore cause GCC to emit a bogus diagnostic in some cases.
5597
3f791afe
PE
5598 * image.c: Integer signedness and overflow and related fixes.
5599 This is not an exhaustive set of fixes, but it's time to
5600 record what I've got.
5601 (lookup_pixel_color, check_image_size): Remove redundant decls.
5602 (check_image_size): Don't assume that arbitrary EMACS_INT values
5603 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5604 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5605 (tiff_load, imagemagick_load_image):
5606 Check for overflow in size calculations.
5607 (x_create_x_image_and_pixmap): Remove unnecessary test for
5608 xmalloc returning NULL; that can't happen.
5609 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5610 (xpm_color_bucket): Use better integer hashing function.
5611 (xpm_cache_color): Don't possibly over-allocate memory.
5612 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5613 (gif_memory_source):
5614 Use ptrdiff_t, not int or size_t, to record sizes.
5615 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5616 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5617 either works, as we prefer signed integers.
5618 (tiff_read_from_memory, tiff_write_from_memory):
5619 Return tsize_t, not size_t, since that's what the TIFF API wants.
5620 (tiff_read_from_memory): Don't fail simply because the read would
5621 go past EOF; instead, return a short read.
5622 (tiff_load): Omit no-longer-needed casts.
5623 (Fimagemagick_types): Don't assume size fits into 'int'.
5624
3cc5a532
PE
5625 Improve hashing quality when configured --with-wide-int.
5626 * fns.c (hash_string): New function, taken from sxhash_string.
5627 Do not discard information about ASCII character case; this
5628 discarding is no longer needed.
5629 (sxhash-string): Use it. Change sig to match it. Caller changed.
5630 * lisp.h: Declare it.
5631 * lread.c (hash_string): Remove, since we now use fns.c's version.
5632 The fns.c version returns a wider integer if --with-wide-int is
5633 specified, so this should help the quality of the hashing a bit.
5634
b312a492
PE
5635 * emacs.c: Integer overflow minor fix.
5636 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5637 Define only if GNU_LINUX.
5638 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5639
dfd153ae
PE
5640 * dispnew.c: Integer signedness and overflow fixes.
5641 Remove unnecessary forward decls, that were a maintenance hassle.
5642 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5643 All uses changed.
5644 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5645 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5646 (prepare_desired_row, line_draw_cost):
5647 Use int, not unsigned, where either works.
5648 (save_current_matrix, restore_current_matrix):
5649 Use ptrdiff_t, not size_t, where either works.
5650 (init_display): Check for overflow more accurately, and without
5651 relying on undefined behavior.
5652
a81d11a3
PE
5653 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5654 Remove, replacing with the new symbols in lisp.h. All uses changed.
5655 * fileio.c (make_temp_name):
5656 * filelock.c (lock_file_1, lock_file):
5657 * xdisp.c (message_dolog):
5658 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5659 Use pMd etc. instead.
5660 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5661 replacing the pWIDE etc. symbols removed from editfns.c.
5662
3300e6fd
PE
5663 * keyboard.h (num_input_events): Now uintmax_t.
5664 This is (very slightly) less likely to mess up due to wraparound.
5665 All uses changed.
5666
fd05c7e9
PE
5667 * buffer.c: Integer signedness fixes.
5668 (alloc_buffer_text, enlarge_buffer_text):
5669 Use ptrdiff_t rather than size_t when either will do, as we prefer
5670 signed integers.
5671
903fe15d
PE
5672 * alloc.c: Integer signedness and overflow fixes.
5673 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5674 (__malloc_size_t): Default to size_t, not to int.
5675 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5676 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5677 Prefer ptrdiff_t to size_t when either would do, as we prefer
5678 signed integers.
5679 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5680 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5681 Now const. Initialize with values that are in range even if char
5682 is signed.
5683 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5684 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5685 These functions do the right thing with sizes > 2**32.
5686 (check_depth): Now ptrdiff_t, not int.
5687 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5688 Adjust to new way of storing sizes. Check for size overflow bugs
5689 in rest of code.
5690 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5691 slightly wrong anyway, as it missed one instance of
5692 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5693 (refill_memory_reserve): Omit needless cast to size_t.
5694 (mark_object_loop_halt): Mark as externally visible.
5695
ac82cc6a
PE
5696 * xselect.c: Integer signedness and overflow fixes.
5697 (Fx_register_dnd_atom, x_handle_dnd_message):
5698 Use ptrdiff_t, not size_t, since we prefer signed.
5699 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5700 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5701 x_dnd_atoms_size and x_dnd_atoms_length.
5702
c2d1e36d
PE
5703 * doprnt.c: Prefer signed to unsigned when either works.
5704 * eval.c (verror):
5705 * doprnt.c (doprnt):
5706 * lisp.h (doprnt):
5707 * xdisp.c (vmessage):
5708 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5709 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5710 prefer signed arithmetic to avoid comparison confusion.
5711 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5712 but is a bit tricky.
5713
0e926e56
PE
5714 Assume freestanding C89 headers, string.h, stdlib.h.
5715 * data.c, doprnt.c, floatfns.c, print.c:
5716 Include float.h unconditionally.
5717 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5718 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5719 * regex.c: Likewise for stddef.h, string.h.
5720 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5721 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5722 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5723 (STDC_HEADERS): Remove obsolete defines.
5724 * sysdep.c: Include limits.h unconditionally.
5725
9cfdb3ec
PE
5726 Assume support for memcmp, memcpy, memmove, memset.
5727 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5728 * regex.c (memcmp, memcpy):
5729 Remove; we assume C89 now.
5730
5731 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5732 (__malloc_safe_bcopy): Remove; no longer needed.
5733
cf950e6b 5734 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5735 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5736 well either way, and we prefer signed to unsigned.
5737
dbf38e02
LMI
57382011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5739
5740 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5741 closes the connection while we're reading (bug#9182).
5742
d6f0886c 57432011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5744
d6f0886c
JD
5745 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5746 are specified (Bug#9168).
24e0f6b1 5747
2eb1f9e6
PE
57482011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5749
5750 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5751 Found by GCC static checking and --with-wide-int on a 32-bit host.
5752
22381272 57532011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5754
5755 * xdisp.c (compute_display_string_pos): Fix logic of caching
5756 previous display string position. Initialize cached_prev_pos to
5757 -1. Fixes slow-down at the beginning of a buffer.
5758
f25e39b4
EZ
57592011-07-24 Eli Zaretskii <eliz@gnu.org>
5760
5761 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5762 for attrs[LFACE_FONTSET_INDEX].
5763
04c4b52e
PE
57642011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5765
5766 * xml.c (parse_region): Remove unused local
5767 that was recently introduced.
5768
c1734fbd
EZ
57692011-07-23 Eli Zaretskii <eliz@gnu.org>
5770
be18c5a5
EZ
5771 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5772 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5773
c1734fbd
EZ
5774 * xdisp.c (move_it_in_display_line_to): Record the best matching
5775 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5776 exit if none of the characters scanned was an exact match.
5777 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5778 when exact match is impossible due to invisible text, and the
5779 lines are truncated.
5780
a258d627
JD
57812011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5782
5783 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5784 for OSX >= 10.7.
5785
b6d5a689
EZ
57862011-07-22 Eli Zaretskii <eliz@gnu.org>
5787
0f74f785
EZ
5788 Fix a significant slow-down of cursor motion with C-n, C-p,
5789 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5790 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5791 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5792 (next_element_from_buffer): Call compute_stop_pos_backwards to
5793 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5794 base_level_stop.
5795 (reseat): Don't look for prev_stop, as that could mean a very long
5796 run.
5797 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5798 <cached_disp_overlay_modiff>: Cache for last found display string
5799 position.
551918c1 5800 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5801 about the same buffer in the same area of character positions, and
5802 the buffer wasn't changed since the time the display string
5803 position was cached.
551918c1 5804
b2d0c91a
EZ
58052011-07-22 Eli Zaretskii <eliz@gnu.org>
5806
5807 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5808 is an integer, which is important for empty lines. (Bug#9149)
5809
043604ee
CY
58102011-07-22 Chong Yidong <cyd@stupidchicken.com>
5811
5812 * frame.c (Fmodify_frame_parameters): In tty case, update the
5813 default face if necessary (Bug#4238).
5814
da4adb04
CY
58152011-07-21 Chong Yidong <cyd@stupidchicken.com>
5816
5817 * editfns.c (Fstring_to_char): No need to explain what a character
5818 is in the docstring (Bug#6576).
5819
9abd0532
LMI
58202011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5821
5822 * xml.c (parse_region): Make sure we always return a tree.
5823
36881d16
HK
58242011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5825
5826 * xml.c (parse_region): If a document contains only comments,
5827 return that, too.
5828
1e98674d
LMI
58292011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5830
5831 * xml.c (make_dom): Return comments, too.
5832
590bd467
PE
58332011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5834
5835 Port to OpenBSD.
5836 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5837 and the surrounding thread.
5838 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5839 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5840 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5841 timer goes off.
5842 * s/openbsd.h (BROKEN_SIGIO): Define.
5843 * unexelf.c (unexec) [__OpenBSD__]:
5844 Don't update the .mdebug section of the Alpha COFF symbol table.
5845
f41628b2
LMI
58462011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5847
5848 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5849 (bug#8460).
5850
b59b67c5
PE
58512011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5852
15e3a074
PE
5853 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5854 This fixes some race conditions on the permissions of any newly
5855 created file.
5856
41bed37d
PE
5857 * alloc.c (valid_pointer_p): Use pipe, not open.
5858 This fixes some permissions issues when debugging.
5859
b59b67c5
PE
5860 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5861 If fchown fails to set both uid and gid, try to set just gid,
5862 as that is sometimes allowed. Adjust the file's mode to eliminate
5863 setuid or setgid bits that are inappropriate if fchown fails.
5864
925a6be7
SM
58652011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5866
5867 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5868 to compare Lisp_Objects.
5869 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5870 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5871 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5872
52968808
AS
58732011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5874
0a6a104b
AS
5875 * lread.c (read_integer): Unread even EOF character.
5876 (read1): Likewise. Properly record start position of symbol.
5877
52968808
AS
5878 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5879 symbol character follows.
5880
9e381cdd
PE
58812011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5882
5883 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5884 This works around a problem with the previous change to Fcopy_file.
5885 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5886 and without this change, GCC might complain about discarding
5887 fchown's return value.
5888
b5641435
JB
58892011-07-16 Juanma Barranquero <lekktu@gmail.com>
5890
5891 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5892
a8031457
PE
58932011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5894
5895 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5896
dd889327
LMI
58972011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5898
750c33f7
LMI
5899 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5900 it's used from the C level.
5901
dd889327
LMI
5902 * process.c: Use the same condition for POLL_FOR_INPUT in both
5903 keyboard.c and process.c (bug#1858).
5904
87e86684
LM
59052011-07-09 Lawrence Mitchell <wence@gmx.li>
5906
5907 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5908 (Fgnutls_boot): Use it.
5909
64348f40
AS
59102011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5911
5912 * doc.c (Fsubstitute_command_keys): Revert last change.
5913
1d698799
LMI
59142011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5915
f863868c
LMI
5916 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5917 quotes the next character, and doesn't affect other longer
5918 sequences (bug#8935).
5919
1d698799
LMI
5920 * lread.c (syms_of_lread): Clarify that is isn't only
5921 `eval-buffer' and `eval-defun' that's affected by
5922 `lexical-binding' (bug#8460).
5923
aa4b6df6
EZ
59242011-07-15 Eli Zaretskii <eliz@gnu.org>
5925
5926 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5927 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5928
5d856da6
PE
59292011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5930
ad6042bb
PE
5931 Fix minor problems found by static checking.
5932 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5933 (elsz): Now a signed constant, not a size_t var. We prefer signed
5934 types to unsigned, to avoid integer comparison confusion. Without
5935 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5936 "cannot optimize loop, the loop counter may overflow", a symptom
5937 of the confusion.
f00bbb22 5938 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5939 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5940
6468f31c
LMI
59412011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5942
49080b10
LMI
5943 * search.c (Fre_search_backward): Mention `case-fold-search' in
5944 all the re_search_* functions (bug#8138).
5945
6468f31c
LMI
5946 * keyboard.c (Fopen_dribble_file): Document when the file is
5947 closed (bug#8056).
5948
c965adc5
EZ
59492011-07-14 Eli Zaretskii <eliz@gnu.org>
5950
df9733bf
EZ
5951 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5952 bidi_cache_idx.
5953
0bb23927
EZ
5954 Support bidi reordering of display and overlay strings.
5955 * xdisp.c (compute_display_string_pos)
5956 (compute_display_string_end): Accept additional argument STRING.
5957 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5958 (reseat_to_string): Initialize bidi_it->string.s and
5959 bidi_it->string.schars.
5960 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5961 NULL (avoids a crash in bidi_paragraph_init).
5962 Initialize itb.string.lstring.
0bb23927
EZ
5963 (init_iterator): Call bidi_init_it only of a valid
5964 buffer position was specified. Initialize paragraph_embedding to
5965 L2R.
5966 (reseat_to_string): Initialize the bidi iterator.
5967 (display_string): If we need to ignore text properties of
5968 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5969 original value of -1 will not work with bidi.)
5970 (compute_display_string_pos): First arg is now struct
5971 `text_pos *'; all callers changed. Support display properties on
5972 Lisp strings.
5973 (compute_display_string_end): Support display properties on Lisp
5974 strings.
5975 (init_iterator, reseat_1, reseat_to_string): Initialize the
5976 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5977 when iterating on a string not from display properties).
640c8776
SM
5978 (compute_display_string_pos, compute_display_string_end):
5979 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5980 arrow keys.
5981 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5982 base_level_stop; instead, set base_level_stop to BEGV.
5983 Fixes crashes in vertical-motion.
0bb23927
EZ
5984 (next_element_from_buffer): Improve commentary for when
5985 the iterator is before prev_stop.
5986 (init_iterator): Initialize bidi_p from the default value of
5987 bidi-display-reordering, not from buffer-local value. Use the
5988 buffer-local value only if initializing for buffer iteration.
5989 (handle_invisible_prop): Support invisible properties on strings
5990 that are being bidi-reordered.
5991 (set_iterator_to_next): Support bidi reordering of C strings and
5992 Lisp strings.
5993 (next_element_from_string): Support bidi reordering of Lisp
5994 strings.
5995 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5996 (display_string): Support display of R2L glyph rows.
5997 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5998 (init_iterator): Don't initialize it->bidi_p for strings
5999 here.
6000 (reseat_to_string): Initialize it->bidi_p for strings here.
6001 (next_element_from_string, next_element_from_c_string)
6002 (next_element_from_buffer): Add xassert's for correspondence
6003 between IT's object being iterated and it->bidi_it.string
6004 structure.
6005 (face_before_or_after_it_pos): Support bidi iteration.
6006 (next_element_from_c_string): Handle the case of the first string
6007 character that is not the first one in the visual order.
6008 (get_visually_first_element): New function, refactored from common
6009 parts of next_element_from_buffer, next_element_from_string, and
6010 next_element_from_c_string.
6011 (tool_bar_lines_needed, redisplay_tool_bar)
6012 (display_menu_bar): Force left-to-right direction. Add a FIXME
6013 comment for making that be controlled by a user option.
6014 (push_it, pop_it): Save and restore the state of the
6015 bidi iterator. Save and restore the bidi_p flag.
6016 (pop_it): Iterate out of display property for string iteration as
6017 well.
6018 (iterate_out_of_display_property): Support iteration over strings.
6019 (handle_single_display_spec): Set up it->bidi_it for iteration
6020 over a display string, and call bidi_init_it.
6021 (handle_single_display_spec, next_overlay_string)
6022 (get_overlay_strings_1, push_display_prop): Set up the bidi
6023 iterator for displaying display or overlay strings.
6024 (forward_to_next_line_start): Don't use the shortcut if
6025 bidi-iterating.
6026 (back_to_previous_visible_line_start): If handle_display_prop
6027 pushed the iterator stack, restore the internal state of the bidi
6028 iterator by calling bidi_pop_it same number of times.
6029 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6030 and we are bidi-iterating, don't decrement the iterator position;
6031 instead, set the first_elt flag in the bidi iterator, to produce
6032 the same effect.
6033 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6034 (push_display_prop): xassert that we are iterating a buffer.
6035 (push_it, pop_it): Save and restore paragraph_embedding member.
6036 (handle_single_display_spec, next_overlay_string)
6037 (get_overlay_strings_1, reseat_1, reseat_to_string)
6038 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6039 correctly. Don't assume unibyte strings are not bidi-reordered.
6040 (compute_display_string_pos)
6041 (compute_display_string_end): Fix handling the case of C string.
6042 (push_it, pop_it): Save and restore from_disp_prop_p.
6043 (handle_single_display_spec, push_display_prop): Set the
6044 from_disp_prop_p flag.
6045 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6046 (pop_it): Call iterate_out_of_display_property only if we are
6047 popping after iteration over a string that came from a display
6048 property. Fix a typo in popping stretch info. Add an assertion
6049 for verifying that the iterator position is in sync with the bidi
6050 iterator.
6051 (handle_single_display_spec, get_overlay_strings_1)
6052 (push_display_prop): Fix initialization of paragraph direction for
6053 string when that of the parent object is not yet determined.
6054 (reseat_1): Call bidi_init_it to resync the bidi
6055 iterator with IT's position. (Bug#7616)
6056 (find_row_edges): If ROW->start.pos gives position
6057 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6058 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6059 Reset the from_disp_prop_p flag.
6060 (SAVE_IT, RESTORE_IT): New macros.
6061 (pos_visible_p, face_before_or_after_it_pos)
6062 (back_to_previous_visible_line_start)
6063 (move_it_in_display_line_to, move_it_in_display_line)
6064 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6065 (try_scrolling, redisplay_window, display_line): Use them when
6066 saving a temporary copy of the iterator and restoring it back.
6067 (back_to_previous_visible_line_start, reseat_1)
6068 (init_iterator): Empty the bidi cache "stack".
6069 (move_it_in_display_line_to): If iterator ended up at
6070 EOL, but we never saw any buffer positions smaller than
6071 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6072 motion in bidi-reordered lines.
6073 (move_it_in_display_line_to): Record prev_method and prev_pos
6074 immediately before the call to set_iterator_to_next. Fixes cursor
6075 motion in bidi-reordered lines with stretch glyphs and strings
6076 displayed in margins. (Bug#8133) (Bug#8867)
6077 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6078 TO_CHARPOS.
640c8776
SM
6079 (pos_visible_p): Support positions in bidi-reordered lines.
6080 Save and restore bidi cache.
0bb23927
EZ
6081
6082 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6083 (bidi_paragraph_info): Delete unused struct.
6084 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6085 (bidi_cache_start): New variable.
6086 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6087 to zero.
6088 (bidi_cache_fetch_state, bidi_cache_search)
6089 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6090 (bidi_cache_find, bidi_peek_at_next_level)
6091 (bidi_level_of_next_char, bidi_find_other_level_edge)
6092 (bidi_move_to_visually_next): Compare cache index with
6093 bidi_cache_start rather than with zero.
6094 (bidi_fetch_char): Accept new argument STRING; all callers
6095 changed. Support iteration over a string. Support strings with
6096 display properties. Support unibyte strings. Fix the type of
6097 `len' according to what STRING_CHAR_AND_LENGTH expects.
6098 (bidi_paragraph_init, bidi_resolve_explicit_1)
6099 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6100 (bidi_level_of_next_char, bidi_move_to_visually_next):
6101 Support iteration over a string.
0bb23927
EZ
6102 (bidi_set_sor_type, bidi_resolve_explicit_1)
6103 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6104 can now be zero (for strings); special values 0 and -1 were
6105 changed to -1 and -2, respectively.
6106 (bidi_char_at_pos): New function.
6107 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6108 Call it instead of FETCH_MULTIBYTE_CHAR.
6109 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6110 initialized to valid values.
6111 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6112 values.
6113 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6114 the test for valid cached positions. Fix the logic for looking up
6115 the sentinel state in the cache. GCPRO the Lisp string we are
6116 iterating.
6117 (bidi_push_it, bidi_pop_it): New functions.
6118 (bidi_initialize): Initialize the bidi cache start stack pointer.
6119 (bidi_cache_ensure_space): New function, refactored from part of
6120 bidi_cache_iterator_state. Don't assume the required size is just
6121 one BIDI_CACHE_CHUNK away.
6122 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6123 (bidi_count_bytes, bidi_char_at_pos): New functions.
6124 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6125 always valid if bidi_cache_idx is valid.
6126 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6127 is valid if it's going to be used.
6128 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6129 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6130 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6131 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6132 (bidi_find_other_level_edge, bidi_cache_start_stack):
6133 All variables related to cache indices are now EMACS_INT.
c965adc5 6134
0bb23927
EZ
6135 * dispextern.h (struct bidi_string_data): New structure.
6136 (struct bidi_it): New member `string'. Make flag members be 1-bit
6137 fields, and put them last in the struct.
640c8776
SM
6138 (compute_display_string_pos, compute_display_string_end):
6139 Update prototypes.
0bb23927
EZ
6140 (bidi_push_it, bidi_pop_it): Add prototypes.
6141 (struct iterator_stack_entry): New members bidi_p,
6142 paragraph_embedding, and from_disp_prop_p.
6143 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6144 (bidi_shelve_cache, bidi_unshelve_cache):
6145 Declare prototypes.
0bb23927
EZ
6146
6147 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6148 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6149 and vector-like objects.
6150
6151 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6152 cache around display iteration.
6153
6154 * window.c (Fwindow_end, window_scroll_pixel_based)
6155 (displayed_window_lines, Frecenter): Save and restore the bidi
6156 cache around display iteration.
6157
3bbd2265
LMI
61582011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6159
6160 * editfns.c (Fdelete_region): Clarify the use of the named
6161 parameters (bug#6788).
6162
adc47434
MR
61632011-07-14 Martin Rudalics <rudalics@gmx.at>
6164
6165 * indent.c (Fvertical_motion): Set and restore w->pointm when
6166 saving and restoring the window's buffer (Bug#9006).
6167
837c31f8
LMI
61682011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6169
6170 * editfns.c (Fstring_to_char): Clarify just what is returned
6171 (bug#6576). Text by Eli Zaretskii.
6172
ac389d0c
JB
61732011-07-13 Juanma Barranquero <lekktu@gmail.com>
6174
6175 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6176
0be0ce47
EZ
61772011-07-13 Eli Zaretskii <eliz@gnu.org>
6178
6179 * buffer.c (mmap_find): Fix a typo.
6180
cd18e7e3
JB
61812011-07-13 Johan Bockgård <bojohan@gnu.org>
6182
6183 Fix execution of x selection hooks.
6184 * xselect.c (Qx_lost_selection_functions)
6185 (Qx_sent_selection_functions): New vars.
6186 (syms_of_xselect): DEFSYM them.
6187 (x_handle_selection_request): Pass Qx_sent_selection_functions
6188 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6189 (x_handle_selection_clear,x_clear_frame_selections):
6190 Pass Qx_lost_selection_functions rather than
6191 Vx_lost_selection_functions to Frun_hook_with_args.
6192
47ea7f44
PE
61932011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6194
ac389d0c 6195 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6196 The old code sometimes used this field without initializing it.
6197
47ea7f44
PE
6198 * alloc.c (gc_sweep): Don't read past end of array.
6199 In theory, the old code could also have corrupted Emacs internals,
6200 though it'd be very unlikely.
6201
bc985c87
AS
62022011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6203
6204 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6205 argument. (Bug#4026)
bc985c87 6206
0cf34688
LMI
62072011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6208
b3dadd76
LMI
6209 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6210 key" (bug#4257).
6211
0cf34688
LMI
6212 * window.c (Fset_window_start): Doc fix (bug#4199).
6213 (Fset_window_hscroll): Ditto.
6214
270768cd
PE
62152011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6216
077e3dda 6217 Fix minor new problems caught by GCC 4.6.1.
270768cd 6218 * term.c (init_tty): Remove unused local.
490011a6 6219 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6220 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6221 not used otherwise.
270768cd 6222
b1f58454
CY
62232011-07-12 Chong Yidong <cyd@stupidchicken.com>
6224
6225 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6226
22b9578d
LMI
62272011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6228
6e70ab07
LMI
6229 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6230 are the mini-buffer and the echo area (bug#3320).
6231
22b9578d
LMI
6232 * term.c (init_tty): Remove support for supdup, c10 and perq
6233 terminals, which are no longer supported (bug#1482).
6234
8974cc9f
JB
62352011-07-10 Johan Bockgård <bojohan@gnu.org>
6236
6237 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6238
a560d974
JD
62392011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6240
6241 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6242 for non-popups (Bug#3642).
6243
1dae0f0a
AS
62442011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6245
268c2c36 6246 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6247 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6248 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6249 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6250 * data.c (fmod): Likewise.
6251 * dispnew.c (swap_glyphs_in_rows): Likewise.
6252 * emacs.c (memory_warning_signal): Likewise.
6253 * floatfns.c (float_error): Likewise.
6254 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6255 (otf_open, font_otf_capability, generate_otf_features)
6256 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6257 Likewise.
6258 * image.c (pbm_read_file): Likewise.
6259 * indent.c (string_display_width): Likewise.
6260 * intervals.c (check_for_interval, search_for_interval)
6261 (inc_interval_count, count_intervals, root_interval)
6262 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6263 * lread.c (defalias): Likewise.
268c2c36 6264 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6265 * regex.c (set_image_of_range_1, set_image_of_range)
6266 (regex_grow_registers): Likewise.
6267 * sysdep.c (strerror): Likewise.
6268 * termcap.c (valid_filename_p, tprint, main): Likewise.
6269 * tparam.c (main): Likewise.
6270 * unexhp9k800.c (run_time_remap, save_data_space)
6271 (update_file_ptrs, read_header, write_header, calculate_checksum)
6272 (copy_file, copy_rest, display_header): Likewise.
6273 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6274 Likewise.
6275 * xdisp.c (check_it): Likewise.
6276 * xfaces.c (register_color, unregister_color, unregister_colors):
6277 Likewise.
6278 * xfns.c (print_fontset_result): Likewise.
6279 * xrdb.c (member, fatal, main): Likewise.
6280
99033785
PE
62812011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6282
6283 Fix minor problems found by static checking (Bug#9031).
6284 * chartab.c (char_table_set_range, map_sub_char_table):
6285 Remove unused locals.
6286 (uniprop_table): Now static.
6287 * composite.c (_work_char): Remove unused static var.
6288
9cb2ac56
JB
62892011-07-09 Juanma Barranquero <lekktu@gmail.com>
6290
6291 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6292
f25661f0
JD
62932011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6294
6295 * gtkutil.c (qttip_cb): Remove code without function.
6296
8278c4fe
EZ
62972011-07-09 Eli Zaretskii <eliz@gnu.org>
6298
6299 * w32.c (pthread_sigmask): New stub.
6300
1692ae2d 63012011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6302
8a6ebd58 6303 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6304 sigprocmask is portable only for single-threaded applications, and
6305 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6306 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6307 (LIBES): Use it.
6308 * callproc.c (Fcall_process):
6309 * process.c (create_process):
6310 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6311 Use pthread_sigmask, not sigprocmask.
123403e4 6312
1b854618
JD
63132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6314
6315 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6316 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6317 wrong (Bug#8591).
6318
3fe4b549
JD
63192011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6320
0ce7e563
JD
6321 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6322 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6323 (xg_hide_tooltip): Fix comment.
6324
3fe4b549
JD
6325 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6326 in registerServicesMenuSendTypes.
6327 (validRequestorForSendType): Don't check ns_return_types.
6328
6329 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6330 ns_return_type.
6331
5df75e47
JR
63322011-07-08 Jason Rumney <jasonr@gnu.org>
6333
22610910
JR
6334 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6335 SH_SHOW for hidden windows (Bug#5482).
6336
5df75e47
JR
6337 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6338 frame struct members of non-existent frames (Bug#6284).
6339
699c10bd
JD
63402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6341
4393663b
JD
6342 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6343 variable firstTime not needed on OSX >= 10.6.
6344 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6345 >= 10.5. Use setKnobProportion, setDoubleValue.
6346
6347 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6348 (MAC_OS_X_VERSION_10_5): Define if not defined.
6349 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6350 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6351 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6352
6353 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6354 cString and lossyCString on OSX >= 10.4
6355
58179cce 6356 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6357 sizeToFit on OSX >= 10.2.
6358
6359 * nsimage.m (allocInitFromFile): Don't use deprecated method
6360 bestRepresentationForDevice on OSX >= 10.6.
6361
6362 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6363 to avoid warning.
6364
6365 * emacs.c: Declare unexec_init_emacs_zone.
6366
a63e0781
JD
6367 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6368
699c10bd
JD
6369 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6370
6371 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6372 on svcsMenu (Bug#8842).
6373
6374 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6375 ns_return_types.
6376 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6377
6378 * nsterm.m (QUTF8_STRING): Declare.
6379 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6380 (validRequestorForSendType): Return type is (id).
6381 Change indexOfObjectIdenticalTo to indexOfObject.
6382 Check if we have local selection before returning self (Bug#8842).
6383 (writeSelectionToPasteboard): Put local selection into paste board
6384 if we have a local selection (Bug#8842).
6385 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6386
6387 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6388 (ns_get_local_selection): Declare.
6389
54e10184
LMI
63902011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6391
9888ff71
LMI
6392 * keymap.c (describe_map_tree): Don't insert a double newline at
6393 the end of the buffer (bug#1169) and return whether we inserted
6394 something.
6395
54e10184
LMI
6396 * callint.c (Fcall_interactively): Change "reading args" to
6397 "providing args" to try to clarify what it does (bug#1010).
6398
15fa4783
KH
63992011-07-07 Kenichi Handa <handa@m17n.org>
6400
6401 * composite.c (composition_compute_stop_pos): Ignore a static
6402 composition starting before CHARPOS (Bug#8915).
6403
6404 * xdisp.c (handle_composition_prop): Likewise.
6405
a8815b00
EZ
64062011-07-07 Eli Zaretskii <eliz@gnu.org>
6407
6408 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6409 (Bug#9015)
6410
ef7b981d 64112011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6412
6413 * character.h (unicode_category_t): New enum type.
6414
6415 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6416 (Qchar_code_property_table): New variable.
6417 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6418 (UNIPROP_COMPRESSED_FORM_P): New macros.
6419 (char_table_ascii): Uncompress the compressed values.
6420 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6421 Uncompress the compressed values.
ac389d0c 6422 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6423 (char_table_ref_and_range): Uncompress the compressed values.
6424 (sub_char_table_set): New arg is_uniprop. Callers changed.
6425 Uncompress the compressed values.
6426 (sub_char_table_set_range): Args changed. Callers changed.
6427 (char_table_set_range): Adjuted for the above change.
6428 (map_sub_char_table): Delete args default_val and parent. Add arg
6429 top. Give decoded values to a Lisp function.
640c8776 6430 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6431 values to a Lisp function. Gcpro more variables.
6432 (uniprop_table_uncompress)
6433 (uniprop_decode_value_run_length): New functions.
6434 (uniprop_decoder, uniprop_decoder_count): New variables.
6435 (uniprop_get_decoder, uniprop_encode_value_character)
6436 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6437 New functions.
6438 (uniprop_encoder, uniprop_encoder_count): New variables.
6439 (uniprop_get_encoder, uniprop_table)
6440 (Funicode_property_table_internal, Fget_unicode_property_internal)
6441 (Fput_unicode_property_internal): New functions.
6442 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6443 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6444 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6445 char-code-property-alist.
6446
640c8776 6447 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6448 Vunicode_category_table.
6449
640c8776 6450 * font.c (font_range): Adjust for the change of
c805dec0
KH
6451 Vunicode_category_table.
6452
76b397fb
DN
64532011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6454
6455 * m/iris4d.h: Remove file, move contents ...
6456 * s/irix6-5.h: ... here.
6457
22b4128e
PE
64582011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6459
6460 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6461 * alloc.c (mark_buffer):
6462 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6463 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6464 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6465 This isn't true in general, and it's particularly not true
6466 if Emacs is configured with --with-wide-int.
6467 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6468 New macros, used in the buffer.c change.
6469
869795d6
JD
64702011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6471
6472 * xsettings.c: Use both GConf and GSettings if both are available.
6473 (store_config_changed_event): Add comment.
6474 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6475 (store_tool_bar_style_changed): New functions.
5e617bc2 6476 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6477 (struct xsettings): Move font inside HAVE_XFT.
6478 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6479 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6480 Move inside HAVE_XFT.
640c8776 6481 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6482 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6483 also.
6484 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6485 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6486 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6487 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6488 (parse_settings): Move check for font inside HAVE_XFT.
6489 (read_settings, apply_xft_settings): Add comment.
6490 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6491 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6492 call store_font_name_changed.
6493 (xft_settings_event): Add comment.
6494 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6495 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6496 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6497 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6498 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6499 (xsettings_get_system_font, xsettings_get_system_normal_font):
6500 Add comment.
869795d6 6501
d8ed26bd
PE
65022011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6503
6504 Random fixes. E.g., (random) never returned negative values.
6505 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6506 subseconds part to the entropy, as that's a bit more random.
6507 Prefer signed to unsigned, since the signedness doesn't matter and
6508 in general we prefer signed. When given a limit, use a
6509 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6510 latter isn't right if USE_2_TAGS_FOR_INTS.
6511 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6512 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6513
cabf1cac
SM
65142011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6515
6516 * textprop.c (text_property_stickiness):
6517 Obey Vtext_property_default_nonsticky.
6518 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6519 * w32fns.c (syms_of_w32fns):
6520 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6521
6e9b2be9
PE
65222011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6523
6524 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6525 This is more efficient than Ffile_directory_p and avoids a minor race.
6526
90186c68
LMI
65272011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6528
7c301272
LMI
6529 * buffer.c (Foverlay_put): Say what the return value is
6530 (bug#7835).
6531
c4f2d8d4
LMI
6532 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6533 is a directory before asking whether to use the file name
6534 (bug#7564).
ad637907
LMI
6535 (barf_or_query_if_file_exists): Make the "File is a directory"
6536 error be more correct.
c4f2d8d4 6537
90186c68
LMI
6538 * fns.c (Frequire): Remove the mention of the .gz files, since
6539 that's installation-specific, but keep the mention of
6540 `get-load-suffixes'.
6541
da64016e
PE
65422011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6543
6544 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6545 Report string overflow if the output is too long.
6546
7d47b580
JB
65472011-07-04 Juanma Barranquero <lekktu@gmail.com>
6548
a555cb87
JB
6549 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6550 (syms_of_gnutls): Remove duplicate DEFSYM for
6551 Qgnutls_bootprop_verify_hostname_error, an error for
6552 Qgnutls_bootprop_verify_error (which is no longer used).
6553
7d47b580
JB
6554 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6555 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6556 Also (re)move comments that are misplaced or no longer relevant.
6557
1e49bfab
LMI
65582011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6559
6560 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6561
1485f4c0
CY
65622011-07-03 Chong Yidong <cyd@stupidchicken.com>
6563
6564 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6565 and background color parameters if they have been changed.
6566
a9ab721e
LMI
65672011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6568
6569 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6570
cf7cff57
PE
65712011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6572
2e13213d
PE
6573 * xsettings.c (SYSTEM_FONT): Define only when used.
6574 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6575
cf7cff57
PE
6576 * keymap.c (access_keymap_1): Now static.
6577
7a8e04f7
CY
65782011-07-02 Chong Yidong <cyd@stupidchicken.com>
6579
6580 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6581 leave any prefix arg for the up event (Bug#1586).
6582
61352f62
LMI
65832011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6584
69bb1ef7
LMI
6585 * lread.c (syms_of_lread): Mention single symbols defined by
6586 `defvar' or `defconst' (bug#7154).
6587
61352f62 6588 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6589 (Frequire): Mention get-load-suffixes.
61352f62 6590
28545e04
MR
65912011-07-02 Martin Rudalics <rudalics@gmx.at>
6592
6593 * window.h (window): Remove clone_number slot.
6594 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6595 Remove.
6596 (make_parent_window, make_window, saved_window)
6597 (Fset_window_configuration, save_window_save): Don't deal with
6598 clone numbers.
6599 * buffer.c (Qclone_number): Remove declaration.
6600 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6601
3349e122
SM
66022011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6603
6604 Add multiple inheritance to keymaps.
6605 * keymap.c (Fmake_composed_keymap): New function.
6606 (Fset_keymap_parent): Simplify.
6607 (fix_submap_inheritance): Remove.
6608 (access_keymap_1): New function extracted from access_keymap to handle
6609 embedded parents and handle lists of maps.
6610 (access_keymap): Use it.
6611 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6612 (Fcopy_keymap): Handle embedded parents.
6613 (Fcommand_remapping, define_as_prefix): Simplify.
6614 (Fkey_binding): Simplify.
6615 (syms_of_keymap): Move minibuffer-local-completion-map,
6616 minibuffer-local-filename-completion-map,
6617 minibuffer-local-must-match-map, and
6618 minibuffer-local-filename-must-match-map to Elisp.
6619 (syms_of_keymap): Defsubr make-composed-keymap.
6620 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6621 (parse_menu_item): Trivial simplification.
6622
3279eb87
GM
66232011-07-01 Glenn Morris <rgm@gnu.org>
6624
6625 * Makefile.in (SETTINGS_LIBS): Fix typo.
6626
4550efdf
KI
66272011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6628
6629 * coding.c (Fencode_coding_string): Record the last coding system
6630 used, as the function doc string says (bug#8738).
6631
0949d2b6
JD
66322011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6633
6634 * xsettings.c (store_monospaced_changed): Take new font as arg and
6635 check for change against current_mono_font.
6636 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6637 (emacs_settings_constructor, emacs_settings_get_property)
6638 (emacs_settings_set_property, emacs_settings_class_init)
6639 (emacs_settings_init, gsettings_obj): Remove.
6640 (something_changedCB): New function for HAVE_GSETTINGS.
6641 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6642 with value as argument.
6643 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6644 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6645 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6646 "changed".
6647
6648 * xgselect.c: Add defined (HAVE_GSETTINGS).
6649 (xgselect_initialize): Ditto.
6650
6651 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6652 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6653 xg_select.
6654
bbc6b304
PE
66552011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6656
6657 * eval.c (struct backtrace): Simplify and port the data structure.
6658 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6659 signed bit field, as this assumption is not portable and it makes
6660 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6661 "char debug_on_exit : 1" as this is not portable either; instead,
6662 use the portable "unsigned int debug_on_exit : 1". Remove unused
6663 member evalargs. Remove obsolete comments about cc bombing out.
6664
9851bfc5
JD
66652011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6666
51bb811f 6667 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6668 Let HAVE_GSETTINGS override HAVE_GCONF.
6669 (store_monospaced_changed): New function.
6670 (EMACS_SETTINGS): A new type derived from GObject to handle
6671 GSettings notifications.
6672 (emacs_settings_constructor, emacs_settings_get_property)
6673 (emacs_settings_set_property, emacs_settings_class_init):
6674 New functions.
6675 (gsettings_client, gsettings_obj): New variables.
6676 (GSETTINGS_SCHEMA): New define.
6677 (something_changedCB): Call store_monospaced_changed.
6678 (init_gsettings): New function.
6679 (xsettings_initialize): Call init_gsettings.
6680 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6681 to NULL.
6682
640c8776 6683 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6684 GCONF_CFLAGS/LIBS.
6685
5386012d
MR
66862011-06-29 Martin Rudalics <rudalics@gmx.at>
6687
6688 * window.c (resize_root_window, grow_mini_window)
6689 (shrink_mini_window): Rename Qresize_root_window to
6690 Qwindow_resize_root_window and Qresize_root_window_vertically to
6691 Qwindow_resize_root_window_vertically.
6692
f13e0b08
PE
66932011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6694
6695 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6696
94515237
JB
66972011-06-27 Juanma Barranquero <lekktu@gmail.com>
6698
6699 * makefile.w32-in: Redesign dependencies so they reflect more
6700 clearly which files are directly included by each source file,
6701 and not through other includes.
6702
e43b6e43
MR
67032011-06-27 Martin Rudalics <rudalics@gmx.at>
6704
6705 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6706 (sort_overlays, overlay_strings): When an overlay's clone number
6707 matches the window's clone number process the overlay even if
6708 the overlay's window property doesn't match the current window.
6709
d68443dc
MR
6710 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6711 (Fwindow_hchild): Rename to Fwindow_left_child.
6712 (Fwindow_next): Rename to Fwindow_next_sibling.
6713 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6714 (resize_window_check): Rename to window_resize_check.
6715 (resize_window_apply): Rename to window_resize_apply.
6716 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6717 (Fdelete_other_windows_internal, resize_frame_windows)
6718 (Fsplit_window_internal, Fdelete_window_internal)
6719 (grow_mini_window, shrink_mini_window)
6720 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6721
c7e73be5
JD
67222011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6723
6724 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6725 (emacs_fixed_set_min_size): Remove.
6726 (emacs_fixed_new): Take frame as argument.
6727
6728 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6729 (_EmacsFixedPrivate): Remove minwidth/height.
6730 Add struct frame *f.
6731 (emacs_fixed_init): Initialize priv->f.
6732 (get_parent_class, emacs_fixed_set_min_size): Remove.
6733 (emacs_fixed_new): Set priv->f to argument.
6734 (emacs_fixed_get_preferred_width)
6735 (emacs_fixed_get_preferred_height): Use min_width/height from
6736 frames size_hint to set minimum and natural (Bug#8919).
6737 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6738 and use min_width/height from frames size_hint to set
6739 min_width/height (Bug#8919).
6740
6741 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6742 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6743 Fix indentation.
c7e73be5 6744
cf99dcf8
EZ
67452011-06-26 Eli Zaretskii <eliz@gnu.org>
6746
6747 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6748 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6749 called at ZV.
6750
029529ac
CY
67512011-06-26 Chong Yidong <cyd@stupidchicken.com>
6752
6753 * process.c (wait_reading_process_output): Bypass select if
6754 waiting for a cell while ignoring keyboard input, and input is
6755 pending. Suggested by Jan Djärv (Bug#8869).
6756
7a7ef429
PE
67572011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6758
6759 Use gnulib's dup2 module instead of rolling our own.
6760 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6761
11fdef7d 67622011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6763
6764 * dispnew.c (scrolling_window): Before scrolling, turn off a
6765 mouse-highlight in the window being scrolled.
6766
cd3520a4
JB
67672011-06-24 Juanma Barranquero <lekktu@gmail.com>
6768
6769 Move DEFSYM to lisp.h and use everywhere.
6770
6771 * character.h (DEFSYM): Move declaration...
6772 * lisp.h (DEFSYM): ...here.
6773
6774 * gnutls.c:
6775 * minibuf.c:
6776 * w32menu.c:
6777 * w32proc.c:
6778 * w32select.c: Don't include character.h.
6779
6780 * alloc.c (syms_of_alloc):
6781 * buffer.c (syms_of_buffer):
6782 * bytecode.c (syms_of_bytecode):
6783 * callint.c (syms_of_callint):
6784 * casefiddle.c (syms_of_casefiddle):
6785 * casetab.c (init_casetab_once):
6786 * category.c (init_category_once, syms_of_category):
6787 * ccl.c (syms_of_ccl):
6788 * cmds.c (syms_of_cmds):
6789 * composite.c (syms_of_composite):
6790 * dbusbind.c (syms_of_dbusbind):
6791 * dired.c (syms_of_dired):
6792 * dispnew.c (syms_of_display):
6793 * doc.c (syms_of_doc):
6794 * editfns.c (syms_of_editfns):
6795 * emacs.c (syms_of_emacs):
6796 * eval.c (syms_of_eval):
6797 * fileio.c (syms_of_fileio):
6798 * fns.c (syms_of_fns):
6799 * frame.c (syms_of_frame):
6800 * fringe.c (syms_of_fringe):
6801 * insdel.c (syms_of_insdel):
6802 * keymap.c (syms_of_keymap):
6803 * lread.c (init_obarray, syms_of_lread):
6804 * macros.c (syms_of_macros):
6805 * msdos.c (syms_of_msdos):
6806 * print.c (syms_of_print):
6807 * process.c (syms_of_process):
6808 * search.c (syms_of_search):
6809 * sound.c (syms_of_sound):
6810 * syntax.c (init_syntax_once, syms_of_syntax):
6811 * terminal.c (syms_of_terminal):
6812 * textprop.c (syms_of_textprop):
6813 * undo.c (syms_of_undo):
6814 * w32.c (globals_of_w32):
6815 * window.c (syms_of_window):
6816 * xdisp.c (syms_of_xdisp):
6817 * xfaces.c (syms_of_xfaces):
6818 * xfns.c (syms_of_xfns):
6819 * xmenu.c (syms_of_xmenu):
6820 * xsettings.c (syms_of_xsettings):
6821 * xterm.c (syms_of_xterm): Use DEFSYM.
6822
4228cf16
TZ
68232011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6824
cd3520a4 6825 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6826
7fcccf1e
PE
68272011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6828
7efb4e0e
PE
6829 Integer and buffer overflow fixes (Bug#8873).
6830
ff5844ad
PE
6831 * print.c (printchar, strout): Check for string overflow.
6832 (PRINTPREPARE, printchar, strout):
6833 Don't set size unless allocation succeeds.
6834
90532f02
PE
6835 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6836 for sizes. Check for string overflow more accurately.
6837 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6838
6d84508d
PE
6839 * macros.c: Integer and buffer overflow fixes.
6840 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6841 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6842 Use ptrdiff_t, not int, for sizes.
6843 Don't increment bufsize until after realloc succeeds.
6844 Check for size-calculation overflow.
6845 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6846
437b2cb4
PE
6847 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6848
8b9ac8b4
PE
6849 * lread.c: Integer overflow fixes.
6850 (read_integer): Radix is now EMACS_INT, not int,
6851 to improve quality of diagnostics for out-of-range radices.
6852 Calculate buffer size correctly for out-of-range radices.
6853 (read1): Check for integer overflow in radices, and in
6854 read-circle numbers.
82cb60d3
PE
6855 (read_escape): Avoid int overflow.
6856 (Fload, openp, read_buffer_size, read1)
6857 (substitute_object_recurse, read_vector, read_list, map_obarray):
6858 Use ptrdiff_t, not int, for sizes.
6859 (read1): Use EMACS_INT, not int, for sizes.
20270765 6860 Check for size overflow.
8b9ac8b4 6861
7fcccf1e
PE
6862 * image.c (cache_image): Check for size arithmetic overflow.
6863
bfbbd7e7
PE
6864 * lread.c: Integer overflow issues.
6865 (saved_doc_string_size, saved_doc_string_length)
6866 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6867 Now ptrdiff_t, not int.
6868 (read1): Don't assume doc string length fits in int. Check for
6869 out-of-range doc string lengths.
6870 (read_list): Don't assume file position fits in int.
39019e54 6871 (read_escape): Check for hex character overflow.
bfbbd7e7 6872
4e323265
LL
68732011-06-22 Leo Liu <sdl.web@gmail.com>
6874
6875 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6876 Move to minibuffer.el.
6877
85fece3e
PE
68782011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6879
20b84ce9 6880 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6881 The following patches are for when GLYPH_DEBUG && !XASSERT.
6882 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6883 * dispnew.c (flush_stdout):
6884 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6885 Mark as externally visible.
6886 * dispnew.c (check_window_matrix_pointers): Now static.
6887 * dispnew.c (window_to_frame_vpos):
6888 * xfns.c (unwind_create_frame):
6889 * xterm.c (x_check_font): Remove unused local.
6890 * scroll.c (CHECK_BOUNDS):
6891 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6892 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6893 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6894 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6895 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6896 Now static.
6897 (debug_method_add): Use va_list and vsprintf rather than relying
6898 on undefined behavior with wrong number of arguments.
6899 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6900 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6901 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6902 since we're not interested in debugging glyphs with old libraries.
6903 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6904 GCC 4.6.0's static checking.
6905
0766b489
PE
69062011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6907
31fd4b32
PE
6908 Integer overflow and signedness fixes (Bug#8873).
6909 A few related buffer overrun fixes, too.
6910
b79e8648
PE
6911 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6912
0766b489
PE
6913 * dispextern.h (struct face.stipple):
6914 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6915 (x_bitmap_mask, x_allocate_bitmap_record)
6916 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6917 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6918 (x_create_bitmap_from_xpm_data):
6919 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6920 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6921 (.bitmaps_last):
6922 * xfaces.c (load_pixmap):
6923 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6924 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6925 (.bitmaps_last, struct x_output.icon_bitmap):
6926 Use ptrdiff_t, not int, for bitmap indexes.
6927 (x_allocate_bitmap_record): Check for size overflow.
6928 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6929
b081724f
PE
6930 Use ptrdiff_t, not int, for overlay counts.
6931 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6932 * editfns.c (overlays_around, get_pos_property):
6933 * textprop.c (get_char_property_and_overlay):
6934 * xdisp.c (next_overlay_change, note_mouse_highlight):
6935 * xfaces.c (face_at_buffer_position):
21514da7
PE
6936 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6937 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6938 (Fnext_overlay_change, Fprevious_overlay_change)
6939 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6940 Use ptrdiff_t, not int, for sizes.
21514da7 6941 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6942
3de73e5e
PE
6943 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6944
2606c57b
PE
6945 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6946 (x_session_initialize): Do not assume string length fits in int.
6947
aaafe47a
PE
6948 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6949 This is unlikely, but can occur if DPI is outlandish.
6950
2674ddc8 6951 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6952 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6953
28154962
PE
6954 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6955 * xrdb.c (magic_file_p, search_magic_path):
6956 Omit last arg SUFFIX; it was always 0. All callers changed.
6957 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6958
7de51af5
PE
6959 * xfont.c (xfont_match): Avoid need for strlen.
6960
25ed6cc3
PE
6961 * xfns.c: Don't assume strlen fits in int.
6962 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6963
4eab31dd
PE
6964 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6965 not unsigned long, as we prefer signed integers. All callers changed.
6966 Detect integer overflow in repeat count.
6967 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6968 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6969
171e2a58
PE
6970 * termcap.c: Don't assume sizes fit in int and never overflow.
6971 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6972 (gobble_line): Check for size-calculation overflow.
6973
ad39faca 6974 * minibuf.c (Fread_buffer):
6e5bb2dc 6975 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6976 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6977 Don't assume string length fits in int.
6978
52c61c22 6979 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6980 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6981
b5b8c9e5
PE
6982 * font.c: Don't assume string length fits in int.
6983 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6984 Use ptrdiff_t, not int.
ccd6111c
PE
6985 (font_intern_prop): Don't assume string length fits in int.
6986 Don't assume integer property fits in fixnum.
6987 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6988
882f0d81 6989 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6990 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6991 Reformulate so as not to need the command string.
6992 Invoke gzip -cd rather than gunzip, as it's more portable.
6993 (lock_info_type, lock_file_1, lock_file):
6994 Don't assume pid_t and time_t fit in unsigned long.
6995 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6996 (current_lock_owner): Prefer signed type for sizes.
6997 Use memcpy, not strncpy, where memcpy is what is really wanted.
6998 Don't assume (via atoi) that time_t and pid_t fit in int.
6999 Check for time_t and/or pid_t out of range, e.g., via a network share.
7000 Don't alloca where an auto var works fine.
7001
93f4cf88
PE
7002 * fileio.c: Fix some integer overflow issues.
7003 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7004 Don't assume string length fits in int.
7005 (directory_file_name): Don't assume string length fits in long.
7006 (make_temp_name): Don't assume pid fits in int, or that its print
7007 length is less than 20.
7008
f3e92b69
PE
7009 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7010
1bfdaf10
PE
7011 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7012
35016e9a
PE
7013 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7014
3d1e65a1
PE
7015 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7016 We prefer signed integers, even for size calculations.
7017
0b963a93
PE
7018 * emacs.c: Don't assume string length fits in 'int'.
7019 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7020 (main): Don't invoke strlen when not needed.
7021
573f4b54
PE
7022 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7023 (XD_DEBUG_MESSAGE): Don't waste a byte.
7024
989f33ba
PE
7025 * callproc.c (getenv_internal_1, getenv_internal)
7026 (Fgetenv_internal):
965d34eb
PE
7027 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7028
e4d29b33
PE
7029 * lread.c (invalid_syntax): Omit length argument.
7030 All uses changed. This doesn't fix a bug, but it simplifies the
7031 code away from its former Hollerith-constant appearance, and it's
7032 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7033 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7034
eb49b136
PE
7035 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7036 This didn't break anything, but it didn't help either.
7037 It's confusing to put a bogus integer in a place where the actual
7038 value does not matter.
9f62aeb1 7039 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7040 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7041
15375a22
PE
7042 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7043 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7044 implementation.
b61cc01c
PE
7045 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7046 We prefer signed types, and the value cannot exceed the EMACS_INT
7047 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7048 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7049 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7050 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7051
53b2623d
PE
7052 * indent.c (sane_tab_width): New function.
7053 (current_column, scan_for_column, Findent_to, position_indentation)
7054 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7055 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7056
51cab52b 7057 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7058
f2ed8a70
PE
7059 * lisp.h (lint_assume): New macro.
7060 * composite.c (composition_gstring_put_cache):
7061 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7062
abe80cc6
PE
7063 * editfns.c, insdel.c:
7064 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7065
b02c740e
PE
7066 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7067
ebc96716
PE
7068 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7069
b4e50fa0 7070 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7071 Use much-faster test for byte-length change.
311d5d7c 7072 Don't assume string byte-length fits in 'int'.
a4cf38e4 7073 Check that character arg fits in 'int'.
85461888 7074 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7075
c0c1ee9f
PE
7076 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7077
a498d7f4
PE
7078 * fns.c (concat): Catch string overflow earlier.
7079 Do not rely on integer wraparound.
7080
51cab52b
PE
7081 * dispextern.h (struct it.overlay_strings_charpos)
7082 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7083 * xdisp.c (forward_to_next_line_start)
7084 (back_to_previous_visible_line_start)
7085 (reseat_at_next_visible_line_start, next_element_from_buffer):
7086 Don't arbitrarily truncate the value of 'selective' to int.
7087
76031fad
PE
7088 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7089
5eb55db9
PE
7090 * composite.c: Don't truncate sizes to 'int'.
7091 (composition_gstring_p, composition_reseat_it)
7092 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7093 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7094 not EMACS_UINT, for indexes.
5eb55db9 7095
0703a717
PE
7096 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7097
d6202519
PE
7098 * buffer.c: Include <verify.h>.
7099 (struct sortvec.priority, struct sortstr.priority):
8961a454 7100 Now EMACS_INT, not int.
c20998a7 7101 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7102 (struct sortstr.size, record_overlay_string)
7103 (struct sortstrlist.size, struct sortlist.used):
7104 Don't truncate size to int.
7105 (record_overlay_string): Check for size-calculation overflow.
d6202519 7106 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7107
d5a19415
JM
71082011-06-22 Jim Meyering <meyering@redhat.com>
7109
029529ac 7110 Don't leak an XBM-image-sized buffer
d5a19415
JM
7111 * image.c (xbm_load): Free the image buffer after using it.
7112
a9041e6c
PE
71132011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7114
7115 Port to Sun C.
7116 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7117 that Sun C diagnosed.
7118 * fns.c (secure_hash): Fix pointer signedness issue.
7119 * intervals.c (static_offset_intervals): New function.
7120 (offset_intervals): Use it.
7121
7f3f739f
LL
71222011-06-21 Leo Liu <sdl.web@gmail.com>
7123
7124 * deps.mk (fns.o):
7125 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7126 sha512.h.
7127
7128 * fns.c (secure_hash): Rename from crypto_hash_function and change
7129 the first arg to accept symbols.
5b66d427 7130 (Fsecure_hash): New primitive.
7f3f739f
LL
7131 (syms_of_fns): New symbols.
7132
76147d94
DD
71332011-06-20 Deniz Dogan <deniz@dogan.se>
7134
7135 * process.c (Fset_process_buffer): Clarify return value in
7136 docstring.
7137
7d7d0045
CY
71382011-06-18 Chong Yidong <cyd@stupidchicken.com>
7139
7140 * dispnew.c (add_window_display_history): Use BVAR.
7141
7142 * xdisp.c (debug_method_add): Use BVAR.
7143 (check_window_end, dump_glyph_matrix, dump_glyph)
7144 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7145
7146 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7147 Likewise.
7148
7149 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7150 check till after the cache is created in init_frame_faces.
7151
ff2bc410
SM
71522011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7153
7154 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7155
28177add
PE
71562011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7157
dd3482fe
PE
7158 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7159 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7160 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7161
393d71f3 7162 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7163 * fileio.c (Finsert_file_contents):
7164 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7165 Remove the old (too-loose) buffer overflow checks.
7166 They weren't needed, since make_gap checks for buffer overflow.
7167 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7168 The old code merely checked for Emacs fixnum overflow, and relied
7169 on undefined (wraparound) behavior. The new code avoids undefined
7170 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7171
2e6813b0 7172 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7173 Tune. Don't use wider integers than needed. Don't use alloca.
7174 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7175
599a9e4f
PE
7176 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7177
99561444
PE
7178 * insdel.c, lisp.h (buffer_overflow): New function.
7179 (insert_from_buffer_1, replace_range, replace_range_2):
7180 * insdel.c (make_gap_larger):
7181 * editfns.c (Finsert_char):
7182 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7183
28177add
PE
7184 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7185
e69dafad
PE
71862011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7187
4baa020d 7188 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7189
b1c46f02
PE
7190 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7191 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7192
e69dafad
PE
7193 * fileio.c: Don't assume EMACS_INT fits in off_t.
7194 (emacs_lseek): New static function.
7195 (Finsert_file_contents, Fwrite_region): Use it.
7196 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7197
566684ea
PE
7198 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7199
e6966cd6
PE
7200 * fns.c: Don't overflow int when computing a list length.
7201 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7202 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7203 truncation on 64-bit hosts. Check for QUIT every
7204 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7205 faster and is responsive enough.
7206 (Flength): Report an error instead of overflowing an integer.
7207 (Fsafe_length): Return a float if the value is not representable
7208 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7209 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7210 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7211
dd0b0efb
PE
7212 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7213 (header_size, word_size): New constants.
7214 (allocate_vectorlike): Don't check size overflow here.
7215 (allocate_vector): Check it here instead, since this is the only
7216 caller of allocate_vectorlike that could cause overflow.
7217 Check that the new vector's length is representable as a fixnum.
7218
86fe5cfe
PE
7219 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7220 The previous code was bogus. For example, next_almost_prime (32)
7221 returned 39, which is undesirable as it is a multiple of 3; and
7222 next_almost_prime (24) returned 25, which is a multiple of 5 so
7223 why was the code bothering to check for multiples of 7?
7224
80e88859
PE
7225 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7226
4a2f0ad6
PE
7227 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7228
f66c7cf8
PE
7229 Variadic C functions now count arguments with ptrdiff_t.
7230 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7231 Back then I didn't know that the Emacs coding style prefers signed int.
7232 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7233 were being counted with int, which may truncate counts on 64-bit
7234 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7235 * lisp.h (struct Lisp_Subr.function.aMANY)
7236 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7237 Arg counts are now ptrdiff_t, not size_t.
7238 All variadic functions and their callers changed accordingly.
7239 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7240 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7241 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7242 * callint.c (Fcall_interactively): Check arg count for overflow,
7243 to avoid potential buffer overrun. Use signed char, not 'int',
7244 for 'varies' array, so that we needn't bother to check its size
7245 calculation for overflow.
7246 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7247 * eval.c (apply_lambda):
7248 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7249 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7250 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7251
a1759b76
PE
7252 * callint.c (Fcall_interactively): Don't use index var as event count.
7253
d96be9fc
PE
7254 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7255 * mem-limits.h (SIZE): Remove; no longer used.
7256
a690a978 7257 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7258
578c21e6
PE
7259 Remove unnecessary casts.
7260 * xterm.c (x_term_init):
7261 * xfns.c (x_set_border_pixel):
7262 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7263 These aren't needed now that we assume ANSI C.
7264
96f53c6c
PE
7265 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7266 It's more likely to cause problems (due to unsigned overflow)
7267 than to cure them.
7268
83c77d31
PE
7269 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7270
ee2079f1
PE
7271 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7272
6da65536
PE
7273 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7274
7147c4a4
PE
7275 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7276
193e32d9
PE
7277 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7278
e5533da6
PE
7279 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7280
9910e595
PE
7281 GLYPH_CODE_FACE returns EMACS_INT, not int.
7282 * dispextern.h (merge_faces):
7283 * xfaces.c (merge_faces):
01103c44
PE
7284 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7285 Don't assume EMACS_INT fits in int.
9910e595 7286
2638320e
PE
7287 * character.h (CHAR_VALID_P): Remove unused parameter.
7288 * fontset.c, lisp.h, xdisp.c: All uses changed.
7289
045eb8d9
PE
7290 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7291
c1f134b5
PE
7292 * fns.c (concat): Minor tuning based on overflow analysis.
7293 This doesn't fix any bugs. Use int to hold character, instead
7294 of constantly refetching from Emacs object. Use XFASTINT, not
7295 XINT, for value known to be a character. Don't bother comparing
7296 a single byte to 0400, as it's always less.
7297
395fcb93 7298 * floatfns.c (Fexpt):
327eeec8
PE
7299 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7300
abbd3d23
PE
7301 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7302 for characters.
7303
684a03ef
PE
7304 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7305
0fed43f3
PE
7306 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7307 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7308 incorrectly succeed when S was a string, because 4294967386 was
7309 truncated before it was used.
7310
8fd02eb7
PE
7311 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7312 Otherwise, an out-of-range integer could cause undefined behavior
7313 on a 64-bit host.
7314
f8c86b69
PE
7315 * composite.c: Use int, not EMACS_INT, for characters.
7316 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7317 EMACS_INT, for values that are known to be in character range.
7318 This doesn't fix any bugs but is the usual style inside Emacs and
7319 may generate better code on 32-bit machines.
7320
34206dd2
PE
7321 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7322 This is for reasons similar to the recent CHAR_STRING fix.
7323 * charset.c (Fencode_char): Check that character arg is actually
7324 a character. Pass an int to ENCODE_CHAR.
7325 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7326 wider than 'int', as a compile-time check to prevent future regressions
7327 in this area.
7328
c5958d4c 7329 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7330
7331 Make sure a 64-bit char is never passed to CHAR_STRING.
7332 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7333 by silently ignoring the top 32 bits, allowing some values
7334 that were far too large to be valid characters.
7335 * character.h: Include <verify.h>.
7336 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7337 arguments are no wider than unsigned, as a compile-time check
7338 to prevent future regressions in this area.
7339 * data.c (Faset):
01103c44 7340 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7341 (Fsubst_char_in_region):
7342 * fns.c (concat):
7343 * xdisp.c (decode_mode_spec_coding):
7344 Adjust to CHAR_STRING's new requirement.
7345 * editfns.c (Finsert_char, Fsubst_char_in_region):
7346 * fns.c (concat): Check that character args are actually
7347 characters. Without this test, these functions did the wrong
7348 thing with wildly out-of-range values on 64-bit hosts.
7349
d37ca623
PE
7350 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7351 These casts should not be needed on 32-bit hosts, either.
7352 * keyboard.c (read_char):
7353 * lread.c (Fload): Remove casts to unsigned.
7354
ea204efb
PE
7355 * lisp.h (UNSIGNED_CMP): New macro.
7356 This fixes comparison bugs on 64-bit hosts.
7357 (ASCII_CHAR_P): Use it.
7358 * casefiddle.c (casify_object):
01103c44 7359 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7360 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7361 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7362 * dispextern.h (FACE_FROM_ID):
7363 * keyboard.c (read_char): Use UNSIGNED_CMP.
7364
41cb286c
PE
7365 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7366 not to EMACS_INT, to avoid GCC warning.
7367
4a1b9832
PE
7368 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7369
55daad71
PE
7370 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7371 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7372 isn't needed on 32-bit machines.
8f95c75c 7373
01103c44
PE
7374 * buffer.c (Fgenerate_new_buffer_name):
7375 Use EMACS_INT for count, not int.
0ceccced 7376 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7377
7378 * data.c (Qcompiled_function): Now static.
7379
c6f072e7
PE
7380 * window.c (window_body_lines): Now static.
7381
20ce5912
PE
7382 * image.c (gif_load): Rename local to avoid shadowing.
7383
9c4c5f81
PE
7384 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7385 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7386 * alloc.c (make_save_value): Integer argument is now of type
7387 ptrdiff_t, not int.
7388 (mark_object): Use ptrdiff_t, not int.
7389 * lisp.h (pD): New macro.
7390 * print.c (print_object): Use it.
7391
c0c5c8ae
PE
7392 * alloc.c: Use EMACS_INT, not int, to count objects.
7393 (total_conses, total_markers, total_symbols, total_vector_size)
7394 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7395 (total_free_floats, total_floats, total_free_intervals)
7396 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7397 Now EMACS_INT, not int. All uses changed.
7398 (Fgarbage_collect): Compute overall total using a double, so that
7399 integer overflow is less likely to be a problem. Check for overflow
7400 when converting back to an integer.
5a25e253
PE
7401 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7402 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7403 These were 'int' variables that could overflow on 64-bit hosts;
7404 they were never used, so remove them instead of repairing them.
211a0b2a 7405 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7406 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7407 Previously, this ceilinged at INT_MAX, but that doesn't work on
7408 64-bit machines.
e46bb31a 7409 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7410
c78baabf 7411 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7412 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7413 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7414 when a (possibly-narrower) signed value would do just as well.
7415 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7416
c9d624c6
PE
7417 * alloc.c: Catch some string size overflows that we were missing.
7418 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7419 for convenience in STRING_BYTES_MAX.
7420 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7421 The definition here is exact; the one in lisp.h was approximate.
7422 (allocate_string_data): Check for string overflow. This catches
7423 some instances we weren't catching before. Also, it catches
7424 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7425 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7426 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7427
c9d624c6
PE
7428 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7429 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7430 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7431
353032ce
PE
7432 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7433
2bccce07
PE
7434 * alloc.c (Fmake_string): Check for out-of-range init.
7435
0ac30604
SM
74362011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7437
7438 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7439
c195f2de
JD
74402011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7441
7442 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7443 xg_get_default_scrollbar_width.
7444
7445 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7446 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7447 (style_changed_cb): Call update_theme_scrollbar_width and call
7448 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7449 all frames (Bug#8505).
7450 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7451 Call gtk_window_set_resizable if HAVE_GTK3.
7452 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7453 and height if HAVE_GTK3 (Bug#8505).
7454 (scroll_bar_width_for_theme): New variable.
7455 (update_theme_scrollbar_width): New function.
7456 (xg_get_default_scrollbar_width): Move code to
7457 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7458 (xg_initialize): Call update_theme_scrollbar_width.
7459
7460 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7461
7462 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7463
e10ac9f1
MR
74642011-06-12 Martin Rudalics <rudalics@gmx.at>
7465
7466 * frame.c (make_frame): Call other_buffer_safely instead of
7467 other_buffer.
7468
7469 * window.c (temp_output_buffer_show): Call display_buffer with
7470 second argument Vtemp_buffer_show_specifiers and reset latter
7471 immediately after the call.
7472 (Vtemp_buffer_show_specifiers): New variable.
7473 (auto_window_vscroll_p, next_screen_context_lines)
7474 (Vscroll_preserve_screen_position): Remove leading asterisks from
7475 doc-strings.
7476
2d3c217e 74772011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7478
7b7f97e8 7479 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7480 * buffer.c (Qclone_number): Remove for now, as it's unused.
7481 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7482 (record_buffer): Remove unused local.
7483 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7484 (set_frame_buffer_list): Remove; unused.
7485 * frame.h (other_visible_frames): Remove decl.
7486 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7487 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7488 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7489 if HAVE_GPM.
7490 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7491 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7492 Define only if HAVE_GPM.
7493 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7494 (update_hints_inhibit): Remove; never set. All uses removed.
7495 * widgetprv.h (emacsFrameClassRec): Remove decl.
7496 * window.c (delete_deletable_window): Now returns void, since it
7497 wasn't returning anything.
7498 (compare_window_configurations): Remove unused locals.
7499 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7500 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7501 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7502 the same widths as pointers. This follows up on the 2011-05-06 patch.
7503 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7504 * xterm.h: Likewise.
7505 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7506
1384b89e
JB
75072011-06-12 Juanma Barranquero <lekktu@gmail.com>
7508
7509 * makefile.w32-in: Update dependencies.
7510 (LISP_H): Add lib/intprops.h.
7511
1100a63c
CY
75122011-06-11 Chong Yidong <cyd@stupidchicken.com>
7513
7514 * image.c (gif_load): Add animation frame delay to the metadata.
7515 (syms_of_image): Use DEFSYM. New symbol `delay'.
7516
6198ccd0
MR
75172011-06-11 Martin Rudalics <rudalics@gmx.at>
7518
7519 * window.c (delete_deletable_window): Re-add.
7520 (Fset_window_configuration): Rewrite to handle dead buffers and
7521 consequently deletable windows.
7522 (window_tree, Fwindow_tree): Remove. Supply functionality in
7523 window.el.
7524 (compare_window_configurations): Simplify code.
7525
b6e3633c
AS
75262011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7527
1ab0dee5
AS
7528 * image.c (imagemagick_load_image): Fix type mismatch.
7529 (Fimagemagick_types): Likewise.
7530
b6e3633c
AS
7531 * window.h (replace_buffer_in_windows): Declare.
7532
9397e56f
MR
75332011-06-11 Martin Rudalics <rudalics@gmx.at>
7534
7535 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7536 Qclone_number. Remove external declaration of Qdelete_window.
7537 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7538 code.
640c8776
SM
7539 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7540 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7541 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7542 buffer list implementation.
7543 (other_buffer_safely): New function.
7544 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7545 calls to replace_buffer_in_windows and
7546 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7547 if allowed.
7548 (record_buffer): Inhibit quitting and rewrite using quittable
7549 functions. Run Qbuffer_list_update_hook if allowed.
7550 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7551 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7552 Move switch-to-buffer to window.el.
9397e56f
MR
7553 (bury-buffer): Move to window.el.
7554 (Vbuffer_list_update_hook): New variable.
7555
7556 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7557 section.
7558
7559 * window.h (resize_frame_windows): Move up in code.
7560 (Fwindow_frame): Remove EXFUN.
7561 (replace_buffer_in_all_windows): Remove prototype.
7562 (replace_buffer_in_windows_safely): Add prototype.
7563
7564 * window.c: Declare Qdelete_window static again. Move down
7565 declaration of select_count.
7566 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7567 (Fother_window): Move to window.el.
7568 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7569 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7570 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7571 window.el.
7572 (replace_buffer_in_windows): Implement by calling
7573 Qreplace_buffer_in_windows.
7574 (replace_buffer_in_all_windows): Remove with some functionality
7575 moved into replace_buffer_in_windows_safely.
7576 (replace_buffer_in_windows_safely): New function.
7577 (select_window_norecord, select_frame_norecord): Move in front
7578 of run_window_configuration_change_hook. Remove now obsolete
7579 declarations.
640c8776
SM
7580 (Fset_window_buffer): Rewrite doc-string.
7581 Call Qrecord_window_buffer.
9397e56f
MR
7582 (keys_of_window): Move binding for other-window to window.el.
7583
b50691aa
CY
75842011-06-11 Chong Yidong <cyd@stupidchicken.com>
7585
7586 * dispextern.h (struct image): Replace data member, whose int_val
7587 and ptr_val fields were not used by anything, with a single
7588 lisp_val object.
7589
7590 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7591 (gif_clear_image, gif_load, imagemagick_load_image)
7592 (gs_clear_image, gs_load): Callers changed.
7593
3f754b86
PE
75942011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7595
cca69397
PE
7596 * buffer.h: Include <time.h>, for time_t.
7597 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7598
109e28d0
PE
7599 Fix minor problems found by static checking.
7600
60737f02
PE
7601 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7602
4b66faf3
PE
7603 Make identifiers static if they are not used in other modules.
7604 * data.c (Qcompiled_function, Qframe, Qvector):
7605 * image.c (QimageMagick, Qsvg):
7606 * minibuf.c (Qmetadata):
7607 * window.c (resize_window_check, resize_root_window): Now static.
7608 * window.h (resize_window_check, resize_root_window): Remove decls.
7609
109e28d0
PE
7610 * window.c (window_deletion_count, delete_deletable_window):
7611 Remove; unused.
46a4ce9e
PE
7612 (window_body_lines): Now static.
7613 (Fdelete_other_windows_internal): Mark vars as initialized.
7614 Make sure 'resize_failed' is initialized.
7615 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7616 (resize_window_apply): Remove unused local.
7617 * window.h (delete_deletable_window): Remove decl.
7618
109e28d0 7619 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7620 (imagemagick_load_image): Fix pointer signedness problem by changing
7621 last arg from unsigned char * to char *. All uses changed.
7622 Also, fix a local for similar reasons.
7623 Remove unused locals. Remove locals to avoid shadowing.
7624 (fn_rsvg_handle_free): Remove; unused.
7625 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7626 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7627
3f754b86
PE
7628 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7629
2547adb1
CY
76302011-06-10 Chong Yidong <cyd@stupidchicken.com>
7631
7632 * image.c (gif_load): Fix omitted cast error introduced by
7633 2011-06-06 change.
7634
2c8e37d4
MR
76352011-06-10 Martin Rudalics <rudalics@gmx.at>
7636
7637 * window.h (resize_proportionally, orig_total_lines)
7638 (orig_top_line): Remove from window structure.
7639 (set_window_height, set_window_width, change_window_heights)
7640 (Fdelete_window): Remove prototypes.
7641 (resize_frame_windows): Remove duplicate declaration.
7642
440a42e3
EZ
76432011-06-10 Eli Zaretskii <eliz@gnu.org>
7644
7645 * window.h (resize_frame_windows, resize_window_check)
7646 (delete_deletable_window, resize_root_window)
7647 (resize_frame_windows): Declare prototypes.
7648
7649 * window.c (resize_window_apply): Make definition be "static" to
7650 match the prototype.
7651
562dd5e9
MR
76522011-06-10 Martin Rudalics <rudalics@gmx.at>
7653
7654 * window.c: Remove declarations of Qwindow_size_fixed,
7655 window_min_size_1, window_min_size_2, window_min_size,
7656 size_window, window_fixed_size_p, enlarge_window, delete_window.
7657 Remove static from declaration of Qdelete_window, it's
7658 temporarily needed by Fbury_buffer.
7659 (replace_window): Don't assign orig_top_line and
7660 orig_total_lines.
7661 (Fdelete_window, delete_window): Remove. Window deletion is
7662 handled by window.el.
640c8776
SM
7663 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7664 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7665 (Fdelete_other_windows): Remove. Deleting other windows is
7666 handled by window.el.
7667 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7668 handled in window.el.
7669 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7670 Window minimum sizes are handled in window.el.
7671 (shrink_windows, size_window, set_window_height)
7672 (set_window_width, change_window_heights, window_height)
7673 (window_width, CURBEG, CURSIZE, enlarge_window)
7674 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7675 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7676 handled in window.el.
7677 (make_dummy_parent): Rename to make_parent_window and give it a
7678 second argument horflag.
7679 (make_window): Don't set resize_proportionally any more.
7680 (Fsplit_window): Remove. Windows are split in window.el.
7681 (save_restore_action, save_restore_orig_size)
7682 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7683 Resize mini windows in window.el.
7684 (grow_mini_window, shrink_mini_window): Implement by calling
7685 Qresize_root_window_vertically, resize_window_check and
7686 resize_window_apply.
640c8776
SM
7687 (saved_window, Fset_window_configuration, save_window_save):
7688 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7689 resize_proportionally.
7690 (window_min_height, window_min_width): Move to window.el.
7691 (keys_of_window): Move bindings for delete-other-windows,
7692 split-window, delete-window and enlarge-window to window.el.
7693
7694 * buffer.c: Temporarily extern Qdelete_window.
7695 (Fbury_buffer): Temporarily call Qdelete_window instead of
7696 Fdelete_window (Fbury_buffer will move to window.el soon).
7697
7698 * frame.c (set_menu_bar_lines_1): Remove code handling
7699 orig_top_line and orig_total_lines.
7700
7701 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7702 set_window_height but set heights directly.
7703 (change_frame_size_1): Use resize_frame_windows.
7704
7705 * xdisp.c (init_xdisp): Don't use set_window_height but set
7706 heights directly.
7707
640c8776
SM
7708 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7709 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7710 run_window_configuration_change_hook.
7711
7712 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7713 instead of change_window_heights and run
7714 run_window_configuration_change_hook.
7715
1a13852e
MR
77162011-06-09 Martin Rudalics <rudalics@gmx.at>
7717
7718 * window.c (replace_window): Rename second argument REPLACEMENT to
7719 NEW. New third argument SETFLAG. Rewrite.
7720 (delete_window, make_dummy_parent): Call replace_window with
7721 third argument 1.
7722 (window_list_1): Move down in code.
7723 (run_window_configuration_change_hook): Move set_buffer part
7724 before select_frame_norecord part in order to unwind correctly.
7725 Rename count1 to count.
7726 (recombine_windows, delete_deletable_window, resize_root_window)
7727 (Fdelete_other_windows_internal)
7728 (Frun_window_configuration_change_hook, make_parent_window)
7729 (resize_window_check, resize_window_apply, Fresize_window_apply)
7730 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7731 (Fdelete_window_internal, Fresize_mini_window_internal):
7732 New functions.
1a13852e
MR
7733 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7734
f3d1777e
MR
77352011-06-08 Martin Rudalics <rudalics@gmx.at>
7736
496e208e
MR
7737 * window.h (window): Add some new members to window structure -
7738 normal_lines, normal_cols, new_total, new_normal, clone_number,
7739 splits, nest, prev_buffers, next_buffers.
7740 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7741 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7742
f3d1777e
MR
7743 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7744 Remove.
496e208e
MR
7745 (make_dummy_parent): Set new members of windows structure.
7746 (make_window): Move down in code. Handle new members of window
7747 structure.
7748 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7749 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7750 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7751 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7752 (Fset_window_next_buffers, Fset_window_clone_number):
7753 New functions.
496e208e
MR
7754 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7755 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7756 Doc-string fixes.
7757 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7758 Argument WINDOW can be now internal window too.
7759 (Fwindow_use_time): Move up in code.
7760 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7761 Rewrite doc-string.
7762 (Fset_window_configuration, saved_window)
7763 (Fcurrent_window_configuration, save_window_save): Handle new
7764 members of window structure.
b9e809c2
MR
7765 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7766 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7767 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7768 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7769 Qget_mru_window, Qresize_root_window,
7770 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7771 Qauto_buffer_name; staticpro them.
f3d1777e 7772
abde8f8c
MR
77732011-06-07 Martin Rudalics <rudalics@gmx.at>
7774
7775 * window.c (Fwindow_total_size, Fwindow_left_column)
7776 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7777 (Fwindow_list_1): New functions.
7778 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7779 (Fwindow_width, Fscroll_left, Fscroll_right):
7780 Use window_body_cols instead of window_box_text_cols.
7781 (delete_window, Fset_window_configuration):
7782 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7783 (delete_all_subwindows): Take a window as argument and not a
7784 structure. Rewrite.
190b47e6
MR
7785 (window_loop): Remove handling of GET_LRU_WINDOW and
7786 GET_LARGEST_WINDOW.
7787 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7788
7789 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7790 window_box_text_cols. delete_all_subwindows now takes a
7791 Lisp_Object as argument.
abde8f8c 7792
640c8776
SM
7793 * indent.c (compute_motion, Fcompute_motion):
7794 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7795
fa8a67e6
MR
7796 * frame.c (delete_frame): Call delete_all_subwindows with root
7797 window as argument.
7798
a54e3482
DC
77992011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7800
7801 * fns.c (Fputhash): Document return value.
7802
60002bf5
CY
78032011-06-06 Chong Yidong <cyd@stupidchicken.com>
7804
7805 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7806
0c671da6 78072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7808
b862a52a 7809 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7810
be44ca6c
PE
7811 Check for overflow when converting integer to cons and back.
7812 * charset.c (Fdefine_charset_internal, Fdecode_char):
7813 Use cons_to_unsigned to catch overflow.
7814 (Fencode_char): Use INTEGER_TO_CONS.
7815 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7816 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7817 * data.c (long_to_cons, cons_to_long): Remove.
7818 (cons_to_unsigned, cons_to_signed): New functions.
7819 These signal an error for invalid or out-of-range values.
7820 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7821 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7822 * font.c (Ffont_variation_glyphs):
7823 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7824 * lisp.h: Include <intprops.h>.
7825 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7826 (cons_to_signed, cons_to_unsigned): New decls.
7827 (long_to_cons, cons_to_long): Remove decls.
7828 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7829 (Fprimitive_undo): Use CONS_TO_INTEGER.
7830 * xfns.c (Fx_window_property): Likewise.
7831 * xselect.c: Include <limits.h>.
7832 (x_own_selection, selection_data_to_lisp_data):
7833 Use INTEGER_TO_CONS.
7834 (x_handle_selection_request, x_handle_selection_clear)
7835 (x_get_foreign_selection, Fx_disown_selection_internal)
7836 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7837 (lisp_data_to_selection_data): Use cons_to_unsigned.
7838 (x_fill_property_data): Use cons_to_signed.
7839 Report values out of range.
7840
d1f3d2af
PE
7841 Check for buffer and string overflow more precisely.
7842 * buffer.h (BUF_BYTES_MAX): New macro.
7843 * lisp.h (STRING_BYTES_MAX): New macro.
7844 * alloc.c (Fmake_string):
7845 * character.c (string_escape_byte8):
7846 * coding.c (coding_alloc_by_realloc):
7847 * doprnt.c (doprnt):
7848 * editfns.c (Fformat):
7849 * eval.c (verror):
7850 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7851 since they may not be the same number.
7852 * editfns.c (Finsert_char):
7853 * fileio.c (Finsert_file_contents):
7854 Likewise for BUF_BYTES_MAX.
7855
dd52fcea
PE
7856 * image.c: Use ptrdiff_t, not int, for sizes.
7857 (slurp_file): Switch from int to ptrdiff_t.
7858 All uses changed.
7859 (slurp_file): Check that file size fits in both size_t (for
7860 malloc) and ptrdiff_t (for sanity and safety).
7861
7f9bbdbb
PE
7862 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7863 if b->modtime has its maximal value.
7864
dfe18f82
PE
7865 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7866
84acfcf0
PE
7867 Don't assume time_t can fit into int.
7868 * buffer.h (struct buffer.modtime): Now time_t, not int.
7869 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7870 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7871
ccd9a01a
PE
7872 Minor fixes for signed vs unsigned integers.
7873 * character.h (MAYBE_UNIFY_CHAR):
7874 * charset.c (maybe_unify_char):
7875 * keyboard.c (read_char, reorder_modifiers):
7876 XINT -> XFASTINT, since the integer must be nonnegative.
7877 * ftfont.c (ftfont_spec_pattern):
7878 * keymap.c (access_keymap, silly_event_symbol_error):
7879 XUINT -> XFASTINT, since the integer must be nonnegative.
7880 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7881 since it makes no difference and we prefer signed.
7882 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7883 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7884 nonnegative.
7885
d6d100dd
SM
78862011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7887
7888 * window.h (Fwindow_frame): Declare.
7889
2b6148e4
PE
78902011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7891
7892 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7893 (SPARE_MEMORY): Always define.
7894 (LARGE_REQUEST): Remove.
7895 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7896
f230ecc9
MR
78972011-06-06 Martin Rudalics <rudalics@gmx.at>
7898
727e958e
MR
7899 * lisp.h: Move EXFUNS for Fframe_root_window,
7900 Fframe_first_window and Fset_frame_selected_window to window.h.
7901
7902 * window.h: Move EXFUNS for Fframe_root_window,
7903 Fframe_first_window and Fset_frame_selected_window here from
7904 lisp.h.
7905
7906 * frame.c (Fwindow_frame, Fframe_first_window)
7907 (Fframe_root_window, Fframe_selected_window)
7908 (Fset_frame_selected_window): Move to window.c.
7909 (Factive_minibuffer_window): Move to minibuf.c.
7910 (Fother_visible_frames_p): New function.
7911
7912 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7913
f230ecc9
MR
7914 * window.c (decode_window, decode_any_window): Move up in code.
7915 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7916 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7917 (Fwindow_buffer): Move up and rewrite doc-string.
7918 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7919 (Fwindow_prev): New functions.
727e958e
MR
7920 (Fwindow_frame): Move here from frame.c. Accept any window as
7921 argument.
7922 (Fframe_root_window, Fframe_first_window)
7923 (Fframe_selected_window): Move here from frame.c. Accept frame
7924 or arbitrary window as argument. Update doc-strings.
7925 (Fminibuffer_window): Move up in code.
7926 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7927 (Fset_frame_selected_window): Move here from frame.c.
7928 Marginal rewrite.
727e958e
MR
7929 (Fselected_window, select_window, Fselect_window): Move up in
7930 code. Minor doc-string fixes.
f230ecc9 7931
4d09bcf6
PE
79322011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7933
7934 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7935 Do not assume that spare memory exists; that assumption is valid
7936 only if SYSTEM_MALLOC.
7937 (LARGE_REQUEST): New macro, so that the issue of large requests
7938 is separated from the issue of spare memory.
7939
810928a2
AS
79402011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7941
172418ad
AS
7942 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7943 format. (Bug#8806)
7944
43f862f7
AS
7945 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7946
810928a2
AS
7947 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7948 before statements.
7949
a059fe24
JD
79502011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7951
7952 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7953
7954 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7955
7956 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7957 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7958
989bf368
JB
79592011-06-05 Juanma Barranquero <lekktu@gmail.com>
7960
7961 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7962
4b80f674
CY
79632011-06-04 Chong Yidong <cyd@stupidchicken.com>
7964
7965 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7966 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7967 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7968 New error handlers.
4b80f674
CY
7969 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7970 Obey Vx_select_enable_clipboard_manager. Catch errors in
7971 x_clipboard_manager_save (Bug#8779).
7972 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7973 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7974
99a33b77 79752011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7976
7977 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7978
99a33b77 79792011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7980
7981 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7982 in the current matrix if keep_current_p is non-zero.
7983
8264569d
EZ
79842011-06-04 Eli Zaretskii <eliz@gnu.org>
7985
7986 * bidi.c (bidi_level_of_next_char): Fix last change.
7987
57f97249
EZ
79882011-06-03 Eli Zaretskii <eliz@gnu.org>
7989
fec2107c 7990 Support bidi reordering of text covered by display properties.
57f97249 7991
fec2107c
EZ
7992 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7993 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7994 (bidi_cache_search, bidi_cache_iterator_state)
7995 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7996 (bidi_level_of_next_char, bidi_move_to_visually_next):
7997 Support character positions inside a run of characters covered by a
fec2107c
EZ
7998 display string.
7999 (bidi_paragraph_init, bidi_resolve_explicit_1)
8000 (bidi_level_of_next_char): Call bidi_fetch_char and
8001 bidi_fetch_char_advance instead of FETCH_CHAR and
8002 FETCH_CHAR_ADVANCE.
8003 (bidi_init_it): Initialize new members.
8004 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8005 definitions.
8006 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8007 instead of using explicit *_CHAR codes.
d6d100dd
SM
8008 (bidi_resolve_explicit, bidi_resolve_weak):
8009 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8010 bidirectional text is supported only in multibyte buffers.
8011 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8012 it to initialize the frame_window_p member of struct bidi_it.
8013 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8014 (bidi_resolve_explicit, bidi_resolve_weak)
8015 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8016 bidi_it->nchars is non-positive.
8017 (bidi_level_of_next_char): Don't try to lookup the cache for the
8018 next/previous character if nothing is cached there yet, or if we
8019 were just reseat()'ed to a new position.
c40e2fb2 8020
0e14fe90
EZ
8021 * xdisp.c (set_cursor_from_row): Set start and stop points
8022 according to the row's direction when priming the loop that looks
8023 for the glyph on which to display cursor.
8024 (single_display_spec_intangible_p): Function deleted.
8025 (display_prop_intangible_p): Reimplement to call
8026 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8027 Accept 3 additional arguments needed by handle_display_spec.
8028 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8029 values: lists, `(when COND...)' forms, etc.
8030 (single_display_spec_string_p): Support property values that are
8031 lists with the argument STRING its top-level element.
8032 (display_prop_string_p): Fix the condition for processing a
8033 property that is a list to be consistent with handle_display_spec.
fec2107c 8034 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8035 last portion of handle_display_prop.
8036 (compute_display_string_pos): Accept additional argument
8037 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8038 value of a `display' property is a "replacing spec".
8039 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8040 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8041 the display property, but just return a value indicating whether
8042 the display property will replace the characters it covers.
8043 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8044 frame_window_p members of struct bidi_it.
d6d100dd
SM
8045 (compute_display_string_pos, compute_display_string_end):
8046 New functions.
fec2107c
EZ
8047 (push_it): Accept second argument POSITION, where pop_it should
8048 jump to continue iteration.
8049 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8050
fec2107c
EZ
8051 * keyboard.c (adjust_point_for_property): Adjust the call to
8052 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8053
8054 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8055 (bidi_init_it): Update prototypes.
8056 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8057 (compute_display_string_pos, compute_display_string_end):
8058 Declare prototypes.
fec2107c
EZ
8059 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8060 EMACS_INT.
fc6f18ce 8061
40087514 80622011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8063
57f53182
PE
8064 Malloc failure behavior now depends on size of allocation.
8065 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8066 * lisp.h: Change signatures accordingly.
8067 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8068 All callers changed. (Bug#8762)
8069
8070 * gnutls.c: Use Emacs's memory allocators.
8071 Without this change, the gnutls library would invoke malloc etc.
8072 directly, which causes problems on non-SYNC_INPUT hosts, and which
8073 runs afoul of improving memory_full behavior. (Bug#8761)
8074 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8075 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8076 xfree instead of the default malloc, realloc, free.
8077 (Fgnutls_boot): No need to check for memory allocation failure,
8078 since xmalloc does that for us.
8079
ac32cd99 8080 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8081 * category.c (hash_get_category_set):
8082 * ccl.c (ccl_driver):
8083 * charset.c (Fdefine_charset_internal):
8084 * charset.h (struct charset.hash_index):
8085 * composite.c (get_composition_id, gstring_lookup_cache)
8086 (composition_gstring_put_cache):
8087 * composite.h (struct composition.hash_index):
8088 * dispextern.h (struct image.hash):
8089 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8090 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8091 (hashfn_equal, hashfn_user_defined, make_hash_table)
8092 (maybe_resize_hash_table, hash_lookup, hash_put)
8093 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8094 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8095 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8096 * image.c (make_image, search_image_cache, lookup_image)
8097 (xpm_put_color_table_h):
8098 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8099 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8100 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8101 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8102 * alloc.c (allocate_vectorlike):
8103 Check for overflow in vector size calculations.
8104 * ccl.c (ccl_driver):
8105 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8106 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8107 need to be updated by these changes.
40087514
PE
8108 * fns.c (make_hash_table, maybe_resize_hash_table):
8109 Check for integer overflow with large hash tables.
0de4bb68
PE
8110 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8111 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8112 (SXHASH_REDUCE): New macro.
8113 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8114 Use it instead of discarding useful hash info with large hash values.
8115 (sxhash_float): New function.
8116 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8117 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8118 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8119 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8120 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8121 Adjust signatures to match updated version of code.
8122 (consing_since_gc): Now EMACS_INT, since a single hash table can
8123 use more than INT_MAX bytes.
8124
698d32e2
DN
81252011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8126
8127 Make it possible to build with GCC-4.6+ -O2 -flto.
8128
8129 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8130
fd6fa53f
SM
81312011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8132
8133 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8134 Call minibuffer-inactive-mode.
8135
864db017
JB
81362011-05-31 Juanma Barranquero <lekktu@gmail.com>
8137
8138 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8139 Update dependencies.
8140
2ad0baf4
DN
81412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8142
8143 * data.c (init_data): Remove code for UTS, this system is not
8144 supported anymore.
8145
4fcc2638
DN
81462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8147
8148 Don't force ./temacs to start in terminal mode.
8149
8150 * frame.c (make_initial_frame): Initialize faces in all cases, not
8151 only when CANNOT_DUMP is defined.
8152 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8153
c56e0fd5
DN
81542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8155
8156 * dispnew.c (add_window_display_history): Use const for the string
8157 pointer. Remove declaration, not needed.
8158
333d54da 81592011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8160
55d4c1b2 8161 Use 'inline', not 'INLINE'.
333d54da 8162 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8163 * alloc.c, fontset.c (INLINE): Remove.
8164 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8165 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8166 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8167 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8168 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8169
738db178
DN
81702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8171
8172 Make it possible to run ./temacs.
8173
8174 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8175 syms_of_callproc does the same thing. Remove test for
8176 "initialized", do it in the caller.
8177 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8178
620c53a6
SM
81792011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8180
8181 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8182 (read_minibuf): Use get_minibuffer.
8183 (syms_of_minibuf): Use DEFSYM.
8184 (Qmetadata): New var.
8185 * data.c (Qbuffer): Don't make it static.
8186 (syms_of_data): Use DEFSYM.
8187
e003a292
PE
81882011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8189
8190 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8191 (CCL_CODE_MIN): New macro.
8192
ed008a6d
PE
81932011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8194
3687c2ef
PE
8195 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8196
ed008a6d
PE
8197 * eval.c (Qdebug): Now static.
8198 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8199 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8200 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8201
d66c4c7c
CY
82022011-05-29 Chong Yidong <cyd@stupidchicken.com>
8203
8204 * image.c: Various fixes to ImageMagick code comments.
8205 (Fimagemagick_types): Doc fix.
8206
5fbc2025
PE
82072011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8208
0196f88a
PE
8209 Minor fixes prompted by GCC 4.6.0 warnings.
8210
8211 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8212
5fbc2025
PE
8213 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8214 (x_clipboard_manager_save_all): Move extern decl to ...
8215 * xterm.h: ... here, so that it can be checked for consistency.
8216
1dd3c2d9
CY
82172011-05-29 Chong Yidong <cyd@stupidchicken.com>
8218
8219 * xselect.c (x_clipboard_manager_save_frame)
8220 (x_clipboard_manager_save_all): New functions.
8221 (Fx_clipboard_manager_save): Lisp function deleted.
8222
8223 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8224 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8225
8226 * xterm.h: Update prototype.
8227
5ba6571d
WX
82282011-05-28 William Xu <william.xwl@gmail.com>
8229
8230 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8231 exiting (Bug#8239).
8232
3eaff834
JM
82332011-05-28 Jim Meyering <meyering@redhat.com>
8234
e1900994 8235 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8236 * fns.c (to_uchar): Define.
8237 (crypto_hash_function): Use it to convert some newly-signed
8238 variables to unsigned, to avoid sign-extension bugs. For example,
8239 without this change, (md5 "truc") would evaluate to
8240 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8241 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8242 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8243
0f6990a7
PE
82442011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8245
8246 Integer overflow fixes.
c8a9ca5a 8247
08686060
PE
8248 * dbusbind.c: Serial number integer overflow fixes.
8249 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8250 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8251 to hold a serial number that is too large for a fixnum.
8252 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8253 Check for serial numbers out of range. Decode any serial number
59568bf0 8254 that was so large that it became a float. (Bug#8722)
08686060 8255
2d1fc3c7
PE
8256 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8257 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8258 Use XFASTINT rather than XUINT when numbers are nonnegative.
8259 (xd_append_arg, Fdbus_method_return_internal):
8260 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8261 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8262 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8263 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8264 (Bug#8722)
2d1fc3c7 8265
c8a9ca5a
PE
8266 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8267
519e1d69
PE
8268 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8269
6df6ae42 8270 ccl: Add integer overflow checks.
30569699
PE
8271 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8272 (IN_INT_RANGE): New macros.
8273 (ccl_driver): Use them to check for integer overflow when
8274 decoding a CCL program. Many of the new checks are whether XINT (x)
8275 fits in int; it doesn't always, on 64-bit hosts. The new version
8276 doesn't catch all possible integer overflows, but it's an
847044ea 8277 improvement. (Bug#8719)
30569699 8278
c11285dc
PE
8279 * alloc.c (make_event_array): Use XINT, not XUINT.
8280 There's no need for unsigned here.
8281
fdccd48e
PE
8282 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8283 This follows up to the 2011-05-06 change that substituted uintptr_t
8284 for EMACS_INT. This case wasn't caught back then.
8285
37910ab2
PE
8286 Rework Fformat to avoid integer overflow issues.
8287 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8288 now (part of C89). Include <verify.h>.
8289 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8290 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8291 (Fformat): Avoid the prepass trying to compute sizes; it was only
8292 approximate and thus did not catch overflow reliably. Instead, walk
8293 through the format just once, formatting and computing sizes as we go,
8294 checking for integer overflow at every step, and allocating a larger
8295 buffer as needed. Keep track separately whether the format is
8296 multibyte. Keep only the most-recently calculated precision, rather
8297 than them all. Record whether each argument has been converted to
8298 string. Use EMACS_INT, not int, for byte and char and arg counts.
8299 Support field widths and precisions larger than INT_MAX. Avoid
8300 sprintf's undefined behavior with conversion specifications such as %#d
8301 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8302 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8303 formatting out-of-range floating point numbers with int
9173deec 8304 formats. (Bug#8668)
37910ab2 8305
2e6578fb
PE
8306 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8307
0ae6bdee
PE
8308 * data.c: Avoid integer truncation in expressions involving floats.
8309 * data.c: Include <intprops.h>.
8310 (arith_driver): When there's an integer overflow in an expression
8311 involving floating point, convert the integers to floating point
8312 so that the resulting value does not suffer from catastrophic
8313 integer truncation. For example, on a 64-bit host (* 4
8314 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8315 Do not rely on undefined behavior after integer overflow.
8316
de883a70
PE
8317 merge count_size_as_multibyte, parse_str_to_multibyte
8318 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8319 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8320 Check for integer overflow.
8321 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8322 since it's now a duplicate of the other. This is more of
8323 a character than a buffer op, so better that it's in character.c.
8324 * fns.c, print.c: Adjust to above changes.
8325
2ff916cb
PE
83262011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8327
8328 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8329
f1b54466
PE
83302011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8331
fb1ac845
PE
8332 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8333 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8334 (x_clipboard_manager_save): Now static.
8335 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8336
f1b54466
PE
8337 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8338 (crypto_hash_function): Now static.
8339 Fix pointer signedness problems. Avoid unnecessary initializations.
8340
a9f737ee
CY
83412011-05-27 Chong Yidong <cyd@stupidchicken.com>
8342
8343 * termhooks.h (Vselection_alist): Make it terminal-local.
8344
8345 * terminal.c (create_terminal): Initialize it.
8346
8347 * xselect.c: Support for clipboard managers.
8348 (Vselection_alist): Move to termhooks.h as terminal-local var.
8349 (LOCAL_SELECTION): New macro.
8350 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8351 (symbol_to_x_atom): Remove gratuitous arg.
8352 (x_handle_selection_request, lisp_data_to_selection_data)
8353 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8354 (x_own_selection, x_get_local_selection, x_convert_selection):
8355 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8356 (some_frame_on_display): Delete unused function.
8357 (Fx_own_selection_internal, Fx_get_selection_internal)
8358 (Fx_disown_selection_internal, Fx_selection_owner_p)
8359 (Fx_selection_exists_p): New optional frame arg.
8360 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8361 (x_handle_selection_clear): Don't treat other terminals with the
8362 same keyboard specially. Use the terminal-local Vselection_alist.
8363 (x_clear_frame_selections): Use Frun_hook_with_args.
8364
8365 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8366
8367 * xterm.h: Add support for those atoms.
8368
e067f0c1
CY
83692011-05-26 Chong Yidong <cyd@stupidchicken.com>
8370
8371 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8372 (converted_selections, conversion_fail_tag): New global variables.
8373 (x_selection_request_lisp_error): Free the above.
8374 (x_get_local_selection): Remove unnecessary code.
8375 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8376 of converted selections stored in converted_selections.
8377 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8378 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8379 (x_convert_selection): New function.
8380 (x_handle_selection_event): Simplify.
8381 (x_get_foreign_selection): Don't ignore incoming requests while
8382 waiting for an answer; this will fail when we implement
8383 SAVE_TARGETS, and seems unnecessary anyway.
8384 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8385 (Vx_sent_selection_functions): Doc fix.
8386
0f4aebc0
LL
83872011-05-26 Leo Liu <sdl.web@gmail.com>
8388
8389 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8390
e61124cd
YM
83912011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8392
8393 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8394
8395 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8396 for fringe update if it has periodic bitmap.
ac389d0c 8397 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8398 and fringe_bitmap_periodic_p.
8399
8400 * fringe.c (get_fringe_bitmap_data): New function.
8401 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8402 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8403 row. Mark glyph row for fringe update if periodicity changed.
8404
8405 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8406 for fringe update unless it has periodic bitmap.
8407
f16d9837
KH
84082011-05-25 Kenichi Handa <handa@m17n.org>
8409
8410 * xdisp.c (get_next_display_element): Set correct it->face_id for
8411 a static composition.
8412
e1b90ef6
LL
84132011-05-24 Leo Liu <sdl.web@gmail.com>
8414
8415 * deps.mk (fns.o):
8416 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8417
8418 * fns.c (crypto_hash_function, Fsha1): New function.
8419 (Fmd5): Use crypto_hash_function.
8420 (syms_of_fns): Add Ssha1.
8421
7400048f
PE
84222011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8423
8424 * gnutls.c: Remove unused macros.
8425 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8426 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8427 Remove macros that are defined and never used.
8428 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8429
abb71cf4
CY
84302011-05-22 Chong Yidong <cyd@stupidchicken.com>
8431
8432 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8433 (Fx_get_selection_internal): Minor cleanup.
8434 (Fx_own_selection_internal): Rename arguments for consistency with
8435 select.el.
8436
6307db39
PE
84372011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8438
8439 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8440
f3d4e0a4
CY
84412011-05-22 Chong Yidong <cyd@stupidchicken.com>
8442
8443 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8444
4d8ade89
YM
84452011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8446
8447 * dispnew.c (scrolling_window): Don't exclude the case that the
8448 last enabled row in the desired matrix touches the bottom boundary.
8449
32078c8d
GM
84502011-05-21 Glenn Morris <rgm@gnu.org>
8451
8452 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8453 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8454 and add some more files.
32078c8d 8455
7285dc67
EZ
84562011-05-20 Eli Zaretskii <eliz@gnu.org>
8457
8458 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8459 report_file_error introduced by the change from 2011-05-07.
8460
89d1bd22
PE
84612011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8462
8463 * systime.h (Time): Define only if emacs is defined.
8464 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8465 where the include path doesn't have X11/X.h by default. See
8466 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8467
cd394be1 84682011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8469
8470 * composite.c (find_automatic_composition): Fix previous change.
8471
b9704ad9
GM
84722011-05-20 Glenn Morris <rgm@gnu.org>
8473
8474 * lisp.mk: New file, split from Makefile.in.
8475 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8476 (shortlisp): Remove.
8477 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8478
4a720484
GM
84792011-05-19 Glenn Morris <rgm@gnu.org>
8480
8481 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8482 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8483 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8484 (lisp): Set the order to that of loadup.el.
8485 (shortlisp): Make it a copy of $lisp.
8486 (SOME_MACHINE_LISP): Remove.
8487 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8488 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8489
a28d4396
KH
84902011-05-18 Kenichi Handa <handa@m17n.org>
8491
8492 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8493 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8494 (find_automatic_composition): Mostly rewrite for efficiency.
8495
a2b1fa8e
JB
84962011-05-18 Juanma Barranquero <lekktu@gmail.com>
8497
8498 * makefile.w32-in: Update dependencies.
8499
8e1f5610
CS
85002011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8501
8502 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8503 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8504
7025ee00 85052011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8506
cdfa6eab
PE
8507 Fix some integer overflow issues, such as string length overflow.
8508
06d6db33
PE
8509 * insdel.c (count_size_as_multibyte): Check for string overflow.
8510
2b4560a8
PE
8511 * character.c (lisp_string_width): Check for string overflow.
8512 Use EMACS_INT, not int, for string indexes and lengths; in
8513 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8514 the resulting string length overflows an EMACS_INT; instead,
8515 report a string overflow if no precision given. When checking for
8516 precision exhaustion, use a check that cannot possibly have
8517 integer overflow. (Bug#8675)
8518 * character.h (lisp_string_width): Adjust to new signature.
8519
cb93f9be
PE
8520 * alloc.c (string_overflow): New function.
8521 (Fmake_string): Use it. This doesn't change behavior, but saves
8522 a few bytes and will simplify future changes.
8523 * character.c (string_escape_byte8): Likewise.
8524 * lisp.h (string_overflow): New decl.
8525
1a1f3366
PE
8526 Fixups, following up to the user-interface timestamp change.
8527 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8528 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8529 * msdos.c (mouse_get_pos): Likewise.
8530 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8531 * w32gui.h (Time): Define by including "systime.h" rather than by
8532 declaring it ourselves. (Bug#8664)
8533
d4e3e4d3
PE
8534 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8535 * image.c (clear_image_cache): Likewise.
8536
f6a24d19
PE
8537 * term.c (term_mouse_position): Don't assume time_t wraparound.
8538
08dc5ae6
PE
8539 Be more systematic about user-interface timestamps.
8540 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8541 and sometimes 'EMACS_UINT', to represent these timestamps.
8542 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8543 This makes the code easier to follow, and makes it easier to catch
8544 integer overflow bugs such as Bug#8664.
8545 * frame.c (Fmouse_position, Fmouse_pixel_position):
8546 Use Time, not unsigned long, for user-interface timestamps.
8547 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8548 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8549 * keyboard.h (last_event_timestamp): Likewise.
8550 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8551 * menu.h (xmenu_show): Likewise.
8552 * term.c (term_mouse_position): Likewise.
8553 * termhooks.h (struct input_event.timestamp): Likewise.
8554 (struct terminal.mouse_position_hook): Likewise.
8555 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8556 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8557 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8558 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8559 what it was before.
8560 * menu.h, termhooks.h: Include "systime.h", for Time.
8561
8e55734a
PE
8562 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8563 Don't assume that the difference between two unsigned long values
8564 can fit into an integer. At this point, we know button_down_time
8565 <= event->timestamp, so the difference must be nonnegative, so
8566 there's no need to cast the result if double-click-time is
8567 nonnegative, as it should be; check that it's nonnegative, just in
8568 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8569 apart (about 25 days). (Bug#8664)
8e55734a 8570
841f1b75 8571 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8572 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8573
3e26f69c
PE
8574 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8575 that always fit in int. Use a sentinel instead of a counter, to
8576 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8577 * frame.h (struct frame): Use int for menu_bar_items_used
8578 instead of EMACS_INT, since it always fits in int.
3e26f69c 8579
5cc152c0
PE
8580 * menu.c (grow_menu_items): Check for int overflow.
8581
d89eb65e
PE
8582 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8583
5235bd3e
PE
8584 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8585 Before, the code was not consistent. These values cannot exceed
8586 2**31 - 1 so there's no need to make them unsigned.
8587 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8588 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8589 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8590 as modifiers.
8591 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8592
bc827e23
PE
8593 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8594 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8595 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8596 presumably because the widths might not match.
8597
78eb494e
PE
8598 * window.c (size_window): Avoid needless test at loop start.
8599
04f2d78b
CB
86002011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8601
8602 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8603
d2fc7e3d 86042011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8605
8606 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8607
d2fc7e3d 86082011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8609
8610 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8611 `width' to `bar_area_x' and `bar_area_width', respectively.
8612 (x_scroll_run): Take account of fringe background extension.
8613
04f2d78b
CB
8614 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8615 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8616 `bar_area_width', respectively.
8617 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8618 background extension.
8619
79b70037
GM
86202011-05-10 Jim Meyering <meyering@redhat.com>
8621
8622 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8623
2f142cc5
JB
86242011-05-10 Juanma Barranquero <lekktu@gmail.com>
8625
8626 * image.c (Finit_image_library): Return t for built-in image types,
8627 like pbm and xbm. (Bug#8640)
8628
57679c86
AS
86292011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8630
8631 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8632
888c9e86
EZ
86332011-05-07 Eli Zaretskii <eliz@gnu.org>
8634
b0512a1d
EZ
8635 * w32console.c (Fset_screen_color): Doc fix.
8636 (Fget_screen_color): New function.
8637 (syms_of_ntterm): Defsubr it.
8638
7285dc67
EZ
8639 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8640 unlink the temporary file if Fcall_process didn't create it in the
8641 first place.
8642 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8643 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8644 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8645 cue to call_process_cleanup not to close that handle.
8646
4d3fcc8e
BK
86472011-05-07 Ben Key <bkey76@gmail.com>
8648
8649 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8650 one of two shell specific rules, either bootstrap-temacs-CMD or
8651 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8652 to the previous implementation of the bootstrap-temacs rule.
8653 The bootstrap-temacs-CMD rule is similar to the previous
8654 implementation of the bootstrap-temacs rule except that it
8655 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8656 variable.
8657
8658 These changes, along with some changes to nt/configure.bat,
8659 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8660 earlier fix to add support for --cflags and --ldflags options
8661 that include quotes so that it works whether make uses cmd or
8662 sh as the shell.
8663
b4289b64
MA
86642011-05-06 Michael Albinus <michael.albinus@gmx.de>
8665
8666 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8667 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8668 is a constant.
8669 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8670 a string. Handle both cases.
8671 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8672 (Fdbus_register_method): Use Qinvalid_function.
8673
af4c0e28
JB
86742011-05-06 Juanma Barranquero <lekktu@gmail.com>
8675
8676 * makefile.w32-in: Update dependencies.
8677 (LISP_H): Add inttypes.h and stdin.h.
8678 (PROCESS_H): Add unistd.h.
8679
c51453d9
EZ
86802011-05-06 Eli Zaretskii <eliz@gnu.org>
8681
8682 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8683 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8684
8ff0ac3c 86852011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8686
4c4b566b
PE
8687 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8688
aab2b9b5
PE
8689 * term.c (vfatal): Remove stray call to va_end.
8690 It's not needed and the C Standard doesn't allow it here anyway.
8691
c378da0b
PE
8692 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8693 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8694
288b08c7
PE
8695 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8696 bytes.
8697
e3601888
PE
8698 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8699
db6c0e74
PE
8700 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8701
dd5963ea
PE
8702 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8703
88c9450f
PE
8704 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8705
2f9442b8
PE
8706 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8707
c032b5f8
PE
8708 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8709 * charset.c (Fdefine_charset_internal): Don't initialize
8710 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8711 32-bit int (Bug#8600).
a108c10b
PE
8712
8713 * lread.c (read_integer): Be more consistent with string-to-number.
8714 Use string_to_number to do the actual conversion; this avoids
8715 rounding errors and fixes some other screwups. Without this fix,
8716 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8717 (digit_to_number): Move earlier, for benefit of read_integer.
8718 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8719 not a digit in any supported base. (Bug#8602)
a108c10b 8720
ad5f9eea
PE
8721 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8722
aec1708a
PE
8723 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8724 to match comment at start of function. This also removes a
8725 GCC warning about overflow in a 32+64-bit port.
8726
47be4ab5
PE
8727 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8728
371cac43
PE
8729 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8730 Reported by Stefan Monnier in
8731 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8732 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8733 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8734
d01a7826
PE
8735 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8736 (EMACS_UINTPTR): Likewise, with uintptr_t.
8737
7fd47d5c
PE
8738 * lisp.h: Prefer 64-bit EMACS_INT if available.
8739 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8740 on 32-bit hosts that have 64-bit int, so that they can access
8741 large files.
122b0c86
PE
8742 However, temporarily disable this change unless the temporary
8743 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8744
8727937b
PE
8745 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8746
8ac068ac
PE
8747 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8748 This removes an assumption that EMACS_INT and long are the same
8749 width as pointers. The assumption is true for Emacs porting targets
8750 now, but we want to make other targets possible.
8751 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8752 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8753 In the rest of the code, change types of integers that hold casted
8754 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8755 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8756 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8757 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8758 No need to cast type when ORing.
8759 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8760 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8761 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8762 assume EMACS_INT is the same width as char *.
8763 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8764 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8765 Remove no-longer-needed casts.
8766 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8767 (xg_tool_bar_help_callback, xg_make_tool_item):
8768 Use EMACS_INTPTR to hold an integer
8769 that will be cast to void *; this can avoid a GCC warning
8770 if EMACS_INT is not the same width as void *.
8771 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8772 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8773 (current_message_1, set_message_1):
8774 Use a local to convert to proper width without a cast.
8775 * xmenu.c (dialog_selection_callback): Likewise.
8776
ede49d71
PE
8777 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8778 Also, don't assume VALBITS / RAND_BITS is less than 5,
8779 and don't rely on undefined behavior when shifting a 1 left into
8780 the sign bit.
8781 * lisp.h (get_random): Change signature to match.
8782
2f30ecd0
PE
8783 * lread.c (hash_string): Use size_t, not int, for hash computation.
8784 Normally we prefer signed values; but hashing is special, because
8785 it's better to use unsigned division on hash table sizes so that
8786 the remainder is nonnegative. Also, size_t is the natural width
8787 for hashing into memory. The previous code used 'int', which doesn't
8788 retain enough info to hash well into very large tables.
8789 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8790
2a866e7b
PE
8791 * dbusbind.c: Don't possibly lose pointer info when converting.
8792 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8793 Use XPNTR rather than XHASH, so that the high-order bits of
8794 the pointer aren't lost when converting through void *.
8795
51639eac
PE
8796 * eval.c (Fautoload): Don't double-shift a pointer.
8797
92394119
PE
8798 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8799
dbdb9a7c
JB
88002011-05-06 Juanma Barranquero <lekktu@gmail.com>
8801
8802 * gnutls.c (DEF_GNUTLS_FN):
8803 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8804
db7a0b4f
AS
88052011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8806
8807 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8808 marker. (Bug#8610)
8809
cd394be1 88102011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8811
8812 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8813 New version that can reserve upto 2GB of heap space.
8814
f7ff1b0f 88152011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8816
8817 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8818
639c109b
TZ
88192011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8820
8821 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8822 `gnutls_certificate_set_x509_key_file'.
8823
d2127135
JB
88242011-05-05 Juanma Barranquero <lekktu@gmail.com>
8825
8826 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8827 Update dependencies.
8828
e968f4f3
JB
88292011-05-04 Juanma Barranquero <lekktu@gmail.com>
8830
8831 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8832 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8833 Remove unused parameter `fildes'.
8834 * process.c (read_process_output, send_process): Don't pass it.
8835
84d358f0
JB
88362011-05-04 Juanma Barranquero <lekktu@gmail.com>
8837
8838 Fix previous change: the library cache is defined in w32.c.
8839 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8840 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8841
0898ca10
JB
88422011-05-04 Juanma Barranquero <lekktu@gmail.com>
8843
8844 Implement dynamic loading of GnuTLS on Windows.
8845
8846 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8847 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8848 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8849 Declare.
8850
8851 * gnutls.c (Qgnutls_dll): Define.
8852 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8853 (gnutls_*): Declare function pointers.
8854 (init_gnutls_functions): New function to initialize function pointers.
8855 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8856 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8857 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8858 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8859 (emacs_gnutls_write, emacs_gnutls_read)
8860 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8861 (Fgnutls_available_p): New function.
8862 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8863 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8864 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8865
8866 * image.c: Include w32.h.
8867 (Vimage_type_cache): Delete.
8868 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8869 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8870 (w32_delayed_load): Move to w32.c.
8871
8872 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8873
8874 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8875 (w32_delayed_load): Move from image.c. When loading a library, record
8876 its filename in the :loaded-from property of the library id.
8877 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8878 Initialize and staticpro them.
8879 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8880
8881 * process.c: Include lisp.h before w32.h, not after.
8882 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8883 instead of gnutls_record_check_pending.
8884
8885 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8886
ff4de4aa
TZ
88872011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8888
8889 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8890 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8891 as passed in.
8892
abe95abb
JD
88932011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8894
8895 * xterm.c (x_set_frame_alpha): Do not set property on anything
8896 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8897
e16e55d4
JB
88982011-05-02 Juanma Barranquero <lekktu@gmail.com>
8899
8900 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8901
bafcf6a5
JB
89022011-05-02 Juanma Barranquero <lekktu@gmail.com>
8903
8904 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8905 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8906 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8907 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8908 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8909 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8910 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8911 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8912 (Qgnutls_bootprop_callbacks_verify): Make static.
8913
e7a6747f
AS
89142011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8915
19ed11ba
AS
8916 * callproc.c: Indentation fixup.
8917
e7a6747f 8918 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8919 (wait_for_termination, interruptible_wait_for_termination):
8920 Move after wait_for_termination_1.
e7a6747f 8921
1ef14cb4
LMI
89222011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8923
8924 * sysdep.c (interruptible_wait_for_termination): New function
8925 which is like wait_for_termination, but allows keyboard
8926 interruptions.
8927
8928 * callproc.c (Fcall_process): Add (:file "file") as an option for
8929 the STDOUT buffer.
8930 (Fcall_process_region): Ditto.
8931
330d880c
EZ
89322011-04-30 Eli Zaretskii <eliz@gnu.org>
8933
8db90b73
EZ
8934 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8935 rather than `XVECTOR (FOO)->size'.
8936
330d880c
EZ
8937 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8938 inttypes.h, as a gnulib replacement is used if it not available in
8939 system headers.
8940
15cbd324
EZ
89412011-04-21 Eli Zaretskii <eliz@gnu.org>
8942
8943 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8944 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8945 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8946
8947 * coding.c (coding_alloc_by_realloc): Error out if destination
8948 will grow beyond MOST_POSITIVE_FIXNUM.
8949 (decode_coding_emacs_mule): Abort if there isn't enough place in
8950 charbuf for the composition carryover bytes. Reserve an extra
8951 space for up to 2 characters produced in a loop.
8952 (decode_coding_iso_2022): Abort if there isn't enough place in
8953 charbuf for the composition carryover bytes.
8954
89552011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8956
ae940cca
EZ
8957 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8958 aborting when %lld or %lll format is passed.
8959 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8960 %llo or %llx format is passed. (Bug#8545)
8961
03ab8921
EZ
8962 * window.c (window_scroll_line_based): Use a marker instead of
8963 simple variables to record original value of point. (Bug#7952)
8964
afda1437
EZ
8965 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8966 produced by %s or %c overflows available buffer space. (Bug#8545)
8967
f76dee0c
PE
89682011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8969
8970 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8971 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8972
fdc5744d
JB
89732011-04-28 Juanma Barranquero <lekktu@gmail.com>
8974
8975 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8976
638f053a
JB
89772011-04-28 Juanma Barranquero <lekktu@gmail.com>
8978
8979 * keyboard.c (Qdelayed_warnings_hook): Define.
8980 (command_loop_1): Run `delayed-warnings-hook'
8981 if Vdelayed_warnings_list is non-nil.
8982 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8983 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8984
d178f871
EZ
89852011-04-28 Eli Zaretskii <eliz@gnu.org>
8986
8987 * doprnt.c (doprnt): Don't return value smaller than the buffer
8988 size if the message was truncated. (Bug#8545).
8989
b124fd93
JB
89902011-04-28 Juanma Barranquero <lekktu@gmail.com>
8991
8992 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8993 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8994
e810457d
PE
89952011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8996
8997 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8998
ea51cceb
JB
89992011-04-27 Juanma Barranquero <lekktu@gmail.com>
9000
9001 * makefile.w32-in: Update dependencies.
9002
94dcfacf
EZ
90032011-04-27 Eli Zaretskii <eliz@gnu.org>
9004
9005 Improve `doprnt' and its usage. (Bug#8545)
9006 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9007 `format_end'. Remove support for %l as a conversion specifier.
9008 Don't use xrealloc. Improve diagnostics when the %l size modifier
9009 is used. Update the commentary.
9010
9011 * eval.c (verror): Simplify calculation of size_t.
9012
9013 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9014 messages.
9015
f61f41d7
PE
90162011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9017
9018 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9019 change.
9020
96fb4434
PE
90212011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9022
9023 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9024 This makes this file independent of the recent pseudovector change.
9025
671875da 90262011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9027
69e9b5a3
PE
9028 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9029
b5f869a7 9030 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9031 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9032 Remove unused local.
c8926152 9033 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9034
841a1577 9035 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9036 GCC 4.6.0 optimizes based on type-based alias analysis.
9037 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9038 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9039 != &v->size, and therefore "v->size = 1; b->size = 2; return
9040 v->size;" must therefore return 1. This assumption is incorrect
9041 for Emacs, since it type-puns struct Lisp_Vector * with many other
9042 types. To fix this problem, this patch adds a new type struct
f904488f 9043 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9044 and pseudovectors, and helps optimizing compilers not get fooled
9045 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9046 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9047 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9048 the size member.
eab3844f
PE
9049 (XSETPVECTYPE): Rewrite in terms of new macro.
9050 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9051 This is a bit clearer, and further avoids the possibility of
9052 undesirable aliasing.
9053 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9054 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9055 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9056 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9057 (ASIZE): Now uses header.size rather than size.
9058 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9059 to avoid the hassle of writing XVECTOR (foo)->header.size.
9060 (struct vectorlike_header): New type.
eab3844f
PE
9061 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9062 object, to help avoid aliasing.
9063 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9064 (SUBRP): Likewise, since Lisp_Subr is a special case.
9065 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9066 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9067 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9068 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9069 changed to be "header.size" and "header.next".
9070 * buffer.h (struct buffer): Likewise.
9071 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9072 * frame.h (struct frame): Likewise.
9073 * process.h (struct Lisp_Process): Likewise.
9074 * termhooks.h (struct terminal): Likewise.
9075 * window.c (struct save_window_data, struct saved_window): Likewise.
9076 * window.h (struct window): Likewise.
9077 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9078 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9079 * buffer.c (init_buffer_once): Likewise.
9080 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9081 special case.
9082 * process.c (Fformat_network_address): Use local var for size,
9083 for brevity.
9084
0df1eac5
PE
9085 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9086
847ab9d1 9087 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9088 * data.c (atof): Remove decl; no longer used or needed.
9089 (digit_to_number): Move to lread.c.
9090 (Fstring_to_number): Use new string_to_number function, to be
9091 consistent with how the Lisp reader treats infinities and NaNs.
9092 Do not assume that floating-point numbers represent EMACS_INT
9093 without losing information; this is not true on most 64-bit hosts.
9094 Avoid double-rounding errors, by insisting on integers when
9095 parsing non-base-10 numbers, as the documentation specifies.
9096 * lisp.h (string_to_number): New decl, replacing ...
9097 (isfloat_string): Remove.
bc0a5c13 9098 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9099 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9100 appears to have been a coding error. Similarly, do not accept
9101 strings like +-1e0 as floating point numbers. Do not report
9102 overflow for integer overflows unless the base is not 10 which
9103 means we have no simple and reliable way to continue.
9104 Break out the floating-point parsing into a new
9105 function string_to_number, so that Fstring_to_number parses
9106 floating point numbers consistently with the Lisp reader.
04f2d78b 9107 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9108 (E_CHAR, EXP_INT): Remove, replacing with ...
9109 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9110 (string_to_number): New function, replacing isfloat_string.
9111 This function checks for valid syntax and produces the resulting
9112 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9113 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9114 so that overflow for non-base-10 numbers is reported only when
9115 there's no portable and simple way to convert to floating point.
452f4150 9116
67769ffc
PE
9117 * textprop.c (set_text_properties_1): Rewrite for clarity,
9118 and to avoid GCC warning about integer overflow.
9119
c20db43f
PE
9120 * intervals.h (struct interval): Use EMACS_INT for members
9121 where EMACS_UINT might cause problems. See
9122 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9123 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9124 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9125 All uses changed.
37aa2f85
PE
9126 (offset_intervals): Tell GCC not to worry about length overflow
9127 when negating a negative length.
c20db43f 9128
2538aa2f
PE
9129 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9130 (overrun_check_free): Likewise.
9131
f2d3008d
PE
9132 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9133 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9134 word size.
9135
ec8df744
PE
9136 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9137 (gnutls_make_error): Rename local to avoid shadowing.
9138 (gnutls_emacs_global_deinit): ifdef out; not used.
9139 (Fgnutls_boot): Use const for pointer to readonly storage.
9140 Comment out unused local. Fix pointer signedness problems.
9141
640ee02d
PE
9142 * lread.c (openp): Don't stuff size_t into an 'int'.
9143 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9144 about possible signed overflow.
9145
6048fb2a
PE
9146 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9147 (GDK_KEY_g): Don't define if already defined.
9148 (xg_prepare_tooltip): Avoid pointer signedness problem.
9149 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9150
fa3c87e1
PE
9151 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9152 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9153
2172544b
PE
9154 * xfns.c (Fx_window_property): Simplify a bit,
9155 to make a bit faster and to avoid GCC 4.6.0 warning.
9156 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9157
9b821a21
PE
9158 * fns.c (internal_equal): Don't assume size_t fits in int.
9159
3c616cfa
PE
9160 * alloc.c (compact_small_strings): Tighten assertion a little.
9161
c2982e87
PE
9162 Replace pEd with more-general pI, and fix some printf arg casts.
9163 * lisp.h (pI): New macro, generalizing old pEd macro to other
9164 conversion specifiers. For example, use "...%"pI"d..." rather
9165 than "...%"pEd"...".
9166 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9167 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9168 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9169 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9170 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9171 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9172 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9173 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9174 64-bit hosts.
9175 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9176 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9177 * print.c (safe_debug_print, print_object): Likewise.
9178 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9179 to int.
6f04d126
PE
9180 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9181 avoiding the 0 flag, which is not portable.
c2982e87
PE
9182 * process.c (Fmake_network_process): Use pI to avoid cast.
9183 * region-cache.c (pp_cache): Likewise.
9184 * xdisp.c (decode_mode_spec): Likewise.
9185 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9186 behavior on 64-bit hosts with printf arg.
6f04d126 9187 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9188 (x_stop_queuing_selection_requests): Likewise.
9189 (x_get_window_property): Don't truncate byte count to an 'int'
9190 when tracing.
0b432f21 9191
5e073ec7
PE
9192 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9193 here, since it parses constructs like leading '-' and spaces,
9194 which are not wanted; and it overflows with large numbers.
9195 Instead, simply match F[0-9]+, which is what is wanted anyway.
9196
36372bf9
PE
9197 * alloc.c: Remove unportable assumptions about struct layout.
9198 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9199 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9200 (allocate_vectorlike, make_pure_vector): Use the new macros,
9201 plus offsetof, to remove unportable assumptions about struct layout.
9202 These assumptions hold on all porting targets that I know of, but
9203 they are not guaranteed, they're easy to remove, and removing them
9204 makes further changes easier.
9205
0b432f21
PE
9206 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9207 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9208 (string_overrun_cookie): Now const. Use initializers that
9209 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9210 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9211 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9212 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9213 multiple of sizeof (EMACS_INT); it need not be, if
9214 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9215 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9216
895009e1
JB
92172011-04-26 Juanma Barranquero <lekktu@gmail.com>
9218
9219 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9220
6a7a1b0b
TZ
92212011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9222
9223 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9224 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9225 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9226
841a1577 92272011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9228
9229 * lisp.h (Qdebug): List symbol.
895009e1 9230 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9231 * keyboard.c (debug-on-event): New variable.
9232 (handle_user_signal): Break into debugger when debug-on-event
9233 matches the current signal symbol.
9234
f2d3ba6f
DN
92352011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9236
9237 * alloc.c (check_sblock, check_string_bytes)
9238 (check_string_free_list): Convert to standard C.
9239
42ce4c63
TZ
92402011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9241
9242 * w32.c (emacs_gnutls_push): Fix typo.
9243
825cd63c
EZ
92442011-04-25 Eli Zaretskii <eliz@gnu.org>
9245
fb11d64d
EZ
9246 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9247 "cast to pointer from integer of different size".
9248
825cd63c
EZ
9249 Improve doprnt and its use in verror. (Bug#8545)
9250 * doprnt.c (doprnt): Document the set of format control sequences
9251 supported by the function. Use SAFE_ALLOCA instead of always
9252 using `alloca'.
9253
9254 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9255 is one byte too soon. Don't use xrealloc; instead xfree and
9256 xmalloc anew.
9257
e061a11b
TZ
92582011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9259
9260 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9261 callbacks stage.
9262
9263 * gnutls.c: Renamed global_initialized to
9264 gnutls_global_initialized. Added internals for the
9265 :verify-hostname-error, :verify-error, and :verify-flags
9266 parameters of `gnutls-boot' and documented those parameters in the
9267 docstring. Start callback support.
9173deec
JB
9268 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9269 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9270 on error. Return error code.
e061a11b
TZ
9271 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9272 (emacs_gnutls_read): Likewise.
9273 (Fgnutls_boot): Return handshake error code.
9274 (emacs_gnutls_handle_error): New function.
9275 (wsaerror_to_errno): Likewise.
9276
9277 * w32.h (emacs_gnutls_pull): Add prototype.
9278 (emacs_gnutls_push): Likewise.
9279
9280 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9281 (emacs_gnutls_push): Likewise.
9282
92832011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9284
9285 * process.c (wait_reading_process_output): Check if GnuTLS
9286 buffered some data internally if no FDs are set for TLS
9287 connections.
9288
9289 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9290 (LIBS): Link to USER_LIBS.
9291 ($(BLD)/gnutls.$(0)): New target.
9292
fa6996bc
EZ
92932011-04-24 Eli Zaretskii <eliz@gnu.org>
9294
eb35682e
EZ
9295 * xdisp.c (handle_single_display_spec): Rename the
9296 display_replaced_before_p argument into display_replaced_p, to
9297 make it consistent with the commentary. Fix typos in the
9298 commentary.
9299
e2ad650c
EZ
9300 * textprop.c (syms_of_textprop): Remove dead code.
9301 (copy_text_properties): Delete obsolete commentary about an
9302 interface that was deleted long ago. Fix typos in the description
9303 of arguments.
9304
1b2de274
EZ
9305 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9306 to changes in oldXMenu/XMenu.h from 2011-04-16.
9307 <menu_help_message, prev_menu_help_message>: Constify.
9308 (IT_menu_make_room): menu->help_text is now `const char **';
9309 adjust.
9310
9311 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9312 to changes in oldXMenu/XMenu.h from 2011-04-16.
9313 (struct XMenu): Declare `help_text' `const char **'.
9314
9315 * xfaces.c <Qunspecified>: Make extern again.
9316
9317 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9318 required by POSIX.
1b2de274 9319
762b15be
EZ
9320 * doc.c (get_doc_string): Improve the format passed to `error'.
9321
9322 * doprnt.c (doprnt): Improve commentary.
9323
9324 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9325
9326 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9327 them with etags.
9328
f1052e5d
EZ
9329 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9330 changes in globals.h immediately force recompilation.
762b15be
EZ
9331 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9332 $(CURDIR)/s/ms-w32.h.
9333 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9334
fa6996bc
EZ
9335 * character.c (Fchar_direction): Function deleted.
9336 (syms_of_character): Don't defsubr it.
9337 <char-direction-table>: Deleted.
9338
e6c3da20
EZ
93392011-04-23 Eli Zaretskii <eliz@gnu.org>
9340
9341 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9342 * doprnt.c: Include limits.h.
9343 (SIZE_MAX): New macro.
04f2d78b
CB
9344 (doprnt): Return a size_t value. 2nd arg is now size_t.
9345 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9346 Improve overflow protection. Support `l' modifier for integer
9347 conversions. Support %l conversion. Don't assume an EMACS_INT
9348 argument for integer conversions and for %c.
9349
9350 * lisp.h (doprnt): Restore prototype.
9351
9352 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9353 $(SRC)/character.h.
9354
9355 * Makefile.in (base_obj): Add back doprnt.o.
9356
9357 * deps.mk (doprnt.o): Add back prerequisites.
9358 (callint.o): Depend on character.h.
9359
9360 * eval.c (internal_lisp_condition_case): Include the handler
9361 representation in the error message.
9362 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9363 when breaking from the loop.
9364
9365 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9366
9367 * callint.c (Fcall_interactively): When displaying error message
9368 about invalid control letter, pass the character's codepoint, not
9369 a pointer to its multibyte form. Improve display of the character
9370 in octal and display also its hex code.
9371
9372 * character.c (char_string): Use %x to display the (unsigned)
9373 codepoint of an invalid character, to avoid displaying a bogus
9374 negative value.
9375
9376 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9377 `error', not SYMBOL_NAME itself.
9378
9379 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9380 character arguments to `error'.
9381
9382 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9383 to `error' in error message about FINAL_CHAR argument. Make sure
9384 FINAL_CHAR is a character, and use %c when it is passed as
9385 argument to `error'.
9386
4ffd0d6b 93872011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9388
9389 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9390
9391 * w32.c: Include <time.h>.
9392 (sys_localtime): New function.
9393
4ffd0d6b 93942011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9395
9396 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9397
4ffd0d6b 9398 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9399
4ffd0d6b 94002011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9401
4ffd0d6b
GM
9402 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9403 zombies (Bug#8467).
aac0c6e3 9404
04c56954
EZ
94052011-04-19 Eli Zaretskii <eliz@gnu.org>
9406
9407 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9408 gl_state.e_property when gl_state.object is Qt.
9409
9410 * insdel.c (make_gap_larger): Remove limitation of buffer size
9411 to <= INT_MAX.
9412
16a43933
CY
94132011-04-18 Chong Yidong <cyd@stupidchicken.com>
9414
9415 * xdisp.c (lookup_glyphless_char_display)
9416 (produce_glyphless_glyph): Handle cons cell entry in
9417 glyphless-char-display.
9418 (Vglyphless_char_display): Document it.
9419
9420 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9421 glyphless-char-display.
9422
4581706e
CY
94232011-04-17 Chong Yidong <cyd@stupidchicken.com>
9424
9425 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9426
9427 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9428
9429 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9430 definition for no-X builds.
9431
4887c6e2 94322011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9433
fd35b6f9
PE
9434 Static checks with GCC 4.6.0 and non-default toolkits.
9435
5c1ccb01
PE
9436 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9437
006c5daa
PE
9438 * process.c (keyboard_bit_set): Define only if SIGIO.
9439 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9440 (send_process): Repair possible setjmp clobbering.
9441
efc736d3
PE
9442 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9443
4e2fe2e6
PE
9444 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9445
f97334a2
PE
9446 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9447
4e75f29d
PE
9448 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9449 Define only if needed.
9450
90efadd1
PE
9451 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9452 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9453 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9454
3c647824
PE
9455 * dispextern.h (struct redisplay_interface): Rename param
9456 to avoid shadowing.
e264f262 9457 * termhooks.h (struct terminal): Likewise.
761383f4 9458 * xterm.c (xembed_send_message): Likewise.
3c647824 9459
b58c5c4a
PE
9460 * insdel.c (make_gap_smaller): Define only if
9461 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9462
cad59032
PE
9463 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9464 it.
9465
c339dc2e
PE
9466 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9467 so that we aren't warned about unused symbols.
9468
91a3e27b
PE
9469 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9470
399c71d3 9471 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9472
8ffc96f5
PE
9473 * xfns.c (x_real_positions): Mark locals as initialized.
9474
eef9bc79
PE
9475 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9476
098db9dd
PE
9477 * xterm.c: Fix problems found by static analysis with other toolkits.
9478 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9479 (x_dispatch_event): Declare static if USE_GTK, and
9480 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9481 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9482 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9483 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9484 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9485
eb18f6cc
PE
9486 * xmenu.c (menu_help_callback): Pointer type fixes.
9487 Use const pointers when pointing at readonly data. Avoid pointer
9488 signedness clashes.
9489 (FALSE): Remove unused macro.
9490 (update_frame_menubar): Remove unused decl.
9491
1fe72bf8
PE
9492 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9493
60d9e1db
PE
9494 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9495 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9496 (single_menu_item): Rename local to avoid shadowing.
9497
39261c26
PE
9498 * keyboard.c (make_lispy_event): Remove unused local var.
9499
018c5e19
PE
9500 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9501 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9502
63d2b86e
PE
9503 * bitmaps: Change bitmaps from unsigned char back to the X11
9504 compatible char. Avoid the old compiler warnings about
9505 out-of-range initializers by using, for example, '\xab' rather
9506 than 0xab.
9507
aefd87e1
PE
9508 * xgselect.c (xgselect_initialize): Check vs interface
9509 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9510
bf501fb9
PE
9511 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9512
e9829fdf
PE
9513 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9514 to read-only memory.
9515
1086c095
PE
9516 * fns.c (vector): Remove; this old hack is no longer needed.
9517
2baccd04 9518 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9519 Remove unused var.
dde42981 9520 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9521
72391843 9522 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9523
436c16df 9524 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9525 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9526 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9527
92bb796d 9528 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9529 (x_term_init): Remove local to avoid shadowing.
92bb796d 9530
764430a3 9531 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9532
9533 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9534 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9535
d1dfb56c
EZ
95362011-04-16 Eli Zaretskii <eliz@gnu.org>
9537
c4354cb4
EZ
9538 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9539
d1dfb56c
EZ
9540 Fix regex.c, syntax.c and friends for buffers > 2GB.
9541 * syntax.h (struct gl_state_s): Declare character position members
9542 EMACS_INT.
9543
9544 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9545
04f2d78b
CB
9546 * textprop.c (verify_interval_modification, interval_of):
9547 Declare arguments EMACS_INT.
d1dfb56c
EZ
9548
9549 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9550 EMACS_INT.
9551
9552 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9553
9554 * indent.c (Fvertical_motion): Local variable it_start is now
9555 EMACS_INT.
9556
9557 * regex.c (re_match, re_match_2, re_match_2_internal)
9558 (bcmp_translate, regcomp, regexec, print_double_string)
9559 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9560 (re_compile_pattern, re_exec): Declare arguments and local
9561 variables `size_t' and `ssize_t' and return values `regoff_t', as
9562 appropriate.
9563 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9564 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9565 <compile_stack_type>: `size' and `avail' are now `size_t'.
9566
9567 * regex.h <regoff_t>: Use ssize_t, not int.
9568 (re_search, re_search_2, re_match, re_match_2): Arguments that
9569 specify buffer/string position and length are now ssize_t and
9570 size_t. Return type is regoff_t.
9571
613052cd
BK
95722011-04-16 Ben Key <bkey76@gmail.com>
9573
9574 * nsfont.m: Fixed bugs in ns_get_family and
9575 ns_descriptor_to_entity that were caused by using free to
9576 deallocate memory blocks that were allocated by xmalloc (via
9577 xstrdup). This caused Emacs to crash when compiled with
9578 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9579 --enable-checking=xmallocoverrun). xfree is now used to
9580 deallocate these memory blocks.
9581
4170f62f 95822011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9583
71b41406
PE
9584 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9585
9587a89d
PE
9586 emacs_write: Accept and return EMACS_INT for sizes.
9587 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9588 et seq.
9589 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9590 Accept and return EMACS_INT.
9591 (emacs_gnutls_write): Return the number of bytes written on
9592 partial writes.
9593 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9594 (emacs_read, emacs_write): Remove check for negative size, as the
9595 Emacs source code has been audited now.
9587a89d
PE
9596 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9597 (emacs_read, emacs_write): Use it.
273a5f82
PE
9598 * process.c (send_process): Adjust to the new signatures of
9599 emacs_write and emacs_gnutls_write. Do not attempt to store
9600 a byte offset into an 'int'; it might overflow.
9587a89d 9601 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9602
3e047f51
PE
9603 * sound.c: Don't assume sizes fit in 'int'.
9604 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9605 Return EMACS_INT, not int.
3e047f51 9606 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9607 Accept EMACS_INT, not int.
9608 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9609 record read return values.
9610
cc39a9db
BK
96112011-04-15 Ben Key <bkey76@gmail.com>
9612
c9d0ec6d
JB
9613 * keyboard.c (Qundefined): Don't declare static since it is used
9614 in nsfns.m.
9615 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9616 static since they are used in nsfont.m.
cc39a9db 9617
6c60eb9f
SM
96182011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9619
9620 * process.c (Qprocessp): Don't declare static.
9621 * lisp.h (Qprocessp): Declare again.
9622
7990b61a
JB
96232011-04-15 Juanma Barranquero <lekktu@gmail.com>
9624
9625 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9626
5d4cb038
PE
96272011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9628
8bd7b830 9629 Improve C-level modularity by making more things 'static'.
cd64ea1d 9630
e3b27b31
PE
9631 Don't publish debugger-only interfaces to other modules.
9632 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9633 (verify_bytepos, count_markers): Move decls to the only modules
9634 that need them.
9635 * region-cache.h (pp_cache): Likewise.
9636 * window.h (check_all_windows): Likewise.
9637 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9638
5d4cb038
PE
9639 * sysdep.c (croak): Now static, if
9640 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9641 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9642
9643 * alloc.c (refill_memory_reserve): Now static if
9644 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9645 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9646
e87b6180
PE
9647 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9648 Define only if USE_LUCID.
9649
ac64929e
PE
9650 * xrdb.c (x_customization_string, x_rm_string): Now static.
9651
6f37259d
PE
9652 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9653 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9654
1683e3ab
PE
9655 * xdisp.c (draw_row_with_mouse_face): Now static.
9656 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9657
de9c2632
PE
9658 * window.h (check_all_windows): Mark externally visible.
9659
2b96acb7
PE
9660 * window.c (window_deletion_count): Now static.
9661
9662 * undo.c: Make symbols static if they're not exported.
9663 (last_undo_buffer, last_boundary_position, pending_boundary):
9664 Now static.
9665
50436f33
PE
9666 * textprop.c (interval_insert_behind_hooks): Now static.
9667 (interval_insert_in_front_hooks): Likewise.
9668
64520e5c
PE
9669 * term.c: Make symbols static if they're not exported.
9670 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9671 (max_frame_lines, tty_set_terminal_modes):
9672 (tty_reset_terminal_modes, tty_turn_off_highlight):
9673 (get_tty_terminal): Now static.
9674 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9675 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9676 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9677 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9678 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9679
1fa53021
PE
9680 * sysdep.c: Make symbols static if they're not exported.
9681 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9682 Now static.
9683 (sigprocmask_set, full_mask): Remove; unused.
9684 (wait_debugging): Mark as visible.
9685 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9686 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9687
d4b43b22
PE
9688 * syntax.c (syntax_temp): Define only if !__GNUC__.
9689
b7c513d0
PE
9690 * sound.c (current_sound_device, current_sound): Now static.
9691
989b29ad
PE
9692 * search.c (searchbufs, searchbuf_head): Now static.
9693
13a55a78
PE
9694 * scroll.c (scroll_cost): Remove; unused.
9695 * dispextern.h (scroll_cost): Remove decl.
9696
de68a1fc
PE
9697 * region-cache.h (pp_cache): Mark as externally visible.
9698
40ccffa6
PE
9699 * process.c: Make symbols static if they're not exported.
9700 (process_tick, update_tick, create_process, chan_process):
9701 (Vprocess_alist, proc_buffered_char, datagram_access):
9702 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9703 (deactivate_process): Mark defn as static, as well as decl.
9704 * lisp.h (create_process): Remove decl.
9705 * process.h (chan_process, Vprocess_alist): Remove decls.
9706
ad64fc97
PE
9707 * print.c: Make symbols static if they're not exported.
9708 (print_depth, new_backquote_output, being_printed, print_buffer):
9709 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9710 (print_interval, print_number_index, initial_stderr_stream):
9711 Now static.
9712 * lisp.h (Fprinc): Remove decl.
9713 (debug_output_compilation_hack): Mark as externally visible.
9714
adddb265
PE
9715 * sysdep.c (croak): Move decl from here to syssignal.h.
9716 * syssignal.h (croak): Put it here, so the API can be checked when
9717 'croak' is called from dissociate_if_controlling_tty.
9718
1717ede2
PE
9719 * minibuf.c: Make symbols static if they're not exported.
9720 (minibuf_save_list, choose_minibuf_frame): Now static.
9721 * lisp.h (choose_minibuf_frame): Remove decl.
9722
fa5fb2bc
PE
9723 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9724
1e3890d1
PE
9725 * lread.c: Make symbols static if they're not exported.
9726 (read_objects, initial_obarray, oblookup_last_bucket_number):
9727 Now static.
9728 (make_symbol): Remove; unused.
9729 * lisp.h (initial_obarray, make_symbol): Remove decls.
9730
8a1414fa
PE
9731 * keyboard.c: Make symbols static if they're not exported.
9732 (single_kboard, recent_keys_index, total_keys, recent_keys):
9733 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9734 (this_single_command_key_start, echoing, last_auto_save):
9735 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9736 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9737 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9738 (Vlispy_mouse_stem, double_click_count):
9739 Now static.
9740 (force_auto_save_soon): Define only if SIGDANGER.
9741 (ignore_mouse_drag_p): Now static if
9742 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9743 (print_help): Remove; unused.
9744 (stop_character, last_timer_event): Mark as externally visible.
9745 * keyboard.h (ignore_mouse_drag_p): Declare only if
9746 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9747 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9748 * lisp.h (echoing): Remove decl.
9749 (force_auto_save_soon): Declare only if SIGDANGER.
9750 * xdisp.c (redisplay_window): Simplify code, to make it more
9751 obvious that ignore_mouse_drag_p is not accessed if !defined
9752 USE_GTK && !defined HAVE_NS.
9753
93ea6e8f
PE
9754 * intervals.c: Make symbols static if they're not exported.
9755 (merge_properties_sticky, merge_interval_right, delete_interval):
9756 Now static.
9757 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9758
77382fcc
PE
9759 * insdel.c: Make symbols static if they're not exported.
9760 However, leave prepare_to_modify_buffer alone. It's never
9761 called from outside this function, but that appears to be a bug.
9762 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9763 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9764 (adjust_after_replace_noundo): Remove; unused.
9765 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9766 (signal_before_change): Remove decls.
77382fcc 9767
9306c32e
PE
9768 * indent.c (val_compute_motion, val_vmotion): Now static.
9769
cd44d2eb
PE
9770 * image.c: Make symbols static if they're not exported.
9771 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9772 if USE_GTK.
9773 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9774 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9775
ad9a7a06
PE
9776 * fringe.c (standard_bitmaps): Now static.
9777 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9778
81626931
PE
9779 * frame.c: Make symbols static if they're not exported.
9780 (x_report_frame_params, make_terminal_frame): Now static.
9781 (get_frame_param): Now static, unless HAVE_NS.
9782 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9783 (x_get_resource_string): Remove; not used.
9784 * frame.h (make_terminal_frame, x_report_frame_params):
9785 (x_get_resource_string); Remove decls.
9786 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9787 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9788
239f9db9
PE
9789 * font.c, fontset.c: Make symbols static if they're not exported.
9790 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9791 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9792 * font.c (font_close_object): Now static.
9793 * font.h (font_close_object): Remove.
9794 * fontset.c (FONTSET_OBJLIST): Remove.
9795 (free_realized_fontset) #if-0 the body, which does nothing.
9796 (face_suitable_for_char_p): #if-0, as it's never called.
9797 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9798 * xfaces.c (face_at_string_position):
9799 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9800 since 0 is always ASCII.
9801
dfcf3579
PE
9802 * fns.c (weak_hash_tables): Now static.
9803
5045092b
PE
9804 * fileio.c: Make symbols static if they're not exported.
9805 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9806 (Vwrite_region_annotation_buffers): Now static.
9807
57a96f5c
PE
9808 * eval.c: Make symbols static if they're not exported.
9809 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9810 * lisp.h (backtrace_list): Remove decl.
9811
35f08c38
PE
9812 * emacs.c: Make symbols static if they're not exported.
9813 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9814 (fatal_error_code, fatal_error_signal_hook, standard_args):
9815 Now static.
9816 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9817 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9818 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9819 * lisp.h (fatal_error_signal_hook): Remove decl.
9820 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9821
f44bd759
PE
9822 * editfns.c: Move a (normally-unused) function to its only use.
9823 * editfns.c, lisp.h (get_operating_system_release): Remove.
9824 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9825 worth the hassle of breaking this out.
9826
b532497d
PE
9827 * xterm.c: Make symbols static if they're not exported.
9828 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9829 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9830 (x_destroy_window, x_delete_display):
9831 Now static.
9832 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9833 (x_mouse_leave): Remove; unused.
9834 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9835 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9836 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9837 Remove decls.
9838 (x_mouse_leave): Declare only if WINDOWSNT.
9839 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9840 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9841 USE_X_TOOLKIT.
9842
1675728f
PE
9843 * ftxfont.c: Make symbols static if they're not exported.
9844 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9845 HAVE_FREETYPE.
9846 * font.h (ftxfont_driver): Likewise.
9847
e4cebfca
PE
9848 * xfns.c: Make symbols static if they're not exported.
9849 (x_last_font_name, x_display_info_for_name):
9850 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9851 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9852 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9853 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9854 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9855 (last_show_tip_args): Now static.
9856 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9857 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9858 (x_screen_planes): Remove; unused.
9859 * dispextern.h (x_screen_planes): Remove decl.
9860
5bf46f05
PE
9861 * dispnew.c: Make symbols static if they're not exported.
9862 * dispextern.h (redraw_garbaged_frames, scrolling):
9863 (increment_row_positions): Remove.
9864 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9865 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9866 Now static.
9867 (redraw_garbaged_frames): Remove; unused.
9868
435f4c28
PE
9869 * xfaces.c: Make symbols static if they're not exported.
9870 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9871 Remove decls.
9872 * xterm.h (defined_color): Remove decls.
9873 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9874 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9875 (menu_face_changed_default, defined_color, free_realized_face):
9876 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9877 (ascii_face_of_lisp_face): Remove; unused.
9878
8524aef3
PE
9879 * xdisp.c: Make symbols static if they're not exported.
9880 * dispextern.h (scratch_glyph_row, window_box_edges):
9881 (glyph_to_pixel_coords, set_cursor_from_row):
9882 (get_next_display_element, set_iterator_to_next):
9883 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9884 (show_mouse_face): Remove decls
9885 * frame.h (message_buf_print): Likewise.
9886 * lisp.h (pop_message, set_message, check_point_in_composition):
9887 Likewise.
9888 * xterm.h (set_vertical_scroll_bar): Likewise.
9889 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9890 (message_buf_print, scratch_glyph_row, displayed_buffer):
9891 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9892 (get_next_display_element, show_mouse_face, window_box_edges):
9893 (frame_to_window_pixel_xy, check_point_in_composition):
9894 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9895 (glyph_to_pixel_coords): Remove; unused.
9896
16390cd2
PE
9897 * dired.c (file_name_completion): Now static.
9898
9899 * dbusbind.c (xd_in_read_queued_messages): Now static.
9900
a25f4dfa
PE
9901 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9902 * data.c (circular_list_error): Remove.
9903
14a9c8df
PE
9904 * commands.h (last_point_position, last_point_position_buffer):
9905 (last_point_position_window): Remove decls.
9906 * keyboard.c: Make these variables static.
9907
04f2d78b
CB
9908 * coding.h (coding, code_convert_region, encode_coding_gap):
9909 Remove decls.
74ab6df5
PE
9910 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9911 (iso_code_class, detect_coding, code_convert_region): Now static.
9912 (encode_coding_gap): Remove; unused.
9913
38dfbee1
PE
9914 * chartab.c (chartab_chars, chartab_bits): Now static.
9915
a2cb4e63
PE
9916 * charset.h (charset_iso_8859_1): Remove decl.
9917 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9918 Now static.
9919
127198fd
PE
9920 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9921 * ccl.c (Vccl_program_table): Now static.
9922 (check_ccl_update): Remove; unused.
9923
d85b608f
PE
9924 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9925 * category.h: ... from here.
9926 * category.c (check_category_table, set_category_set): Now static.
9927
31cd66f3
PE
9928 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9929 * lisp.h: Remove these decls.
9930
c358e587
PE
9931 * buffer.c (buffer_count): Remove unused var.
9932
e78aecca
PE
9933 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9934 so that it's not optimized away.
9935 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9936 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9937 exported only to the debugger.
9938
e192d7d3 9939 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9940 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9941
92470028
PE
9942 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9943 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9944 was inaccessible from Lisp.
9945 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9946 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9947
244ed907
PE
9948 alloc.c: Import and export fewer symbols, and remove unused items.
9949 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9950 is defined.
9951 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9952 it's not optimized away by whole-program optimization.
9953 (message_enable_multibyte, free_misc): Remove.
9954 (catchlist, handlerlist, mark_backtrace):
9955 Declare only if BYTE_MARK_STACK.
9956 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9957 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9958 (message_enable_multibyte): Remove decl.
9959 (free_misc, interval_free_list, float_block, float_block_index):
9960 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9961 (cons_free_list, last_marked_index):
9962 Now static.
9963 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9964 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9965 (mark_backtrace): Define only if BYTE_MARK_STACK.
9966 * xdisp.c (message_enable_multibyte): Now static.
9967
61c2b50e 9968 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9969 This makes it easier for human readers (and static analyzers)
9970 to see whether these variables are used from other modules.
9971 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9972 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9973 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9974 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9975 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9976 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9977 * xmenu.c, xselect.c:
9978 Declare Q* vars static if they are not used in other modules.
9979 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9980 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9981 Remove decls of unexported vars.
9982 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9983
95c82688
PE
9984 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9985
16a97296
PE
9986 Make Emacs functions such as Fatom 'static' by default.
9987 This makes it easier for human readers (and static analyzers)
9988 to see whether these functions can be called from other modules.
9989 DEFUN now defines a static function. To make the function external
9990 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9991 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9992 (Finit_image_library):
16a97296
PE
9993 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9994 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9995 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9996 Remove decls, since these functions are now static.
9997 (Funintern, Fget_internal_run_time): New decls, since these functions
9998 were already external.
95c82688 9999
16a97296
PE
10000 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10001 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10002 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10003 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10004 * keyboard.c, keymap.c, lread.c:
10005 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10006 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10007 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10008 Mark functions with DEFUE instead of DEFUN,
10009 if they are used in other modules.
10010 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10011 decls for now-static functions.
10012 * buffer.h (Fdelete_overlay): Remove decl.
10013 * callproc.c (Fgetenv_internal): Mark as internal.
10014 * composite.c (Fremove_list_of_text_properties): Remove decl.
10015 (Fcomposition_get_gstring): New forward static decl.
10016 * composite.h (Fcomposite_get_gstring): Remove decl.
10017 * dired.c (Ffile_attributes): New forward static decl.
10018 * doc.c (Fdocumntation_property): New forward static decl.
10019 * eval.c (Ffetch_bytecode): New forward static decl.
10020 (Funintern): Remove extern decl; now in .h file where it belongs.
10021 * fileio.c (Fmake_symbolic_link): New forward static decl.
10022 * image.c (Finit_image_library): New forward static decl.
10023 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10024 * intervals.h (Fprevious_property_change):
10025 (Fremove_list_of_text_properties): Remove decls.
10026 * keyboard.c (Fthis_command_keys): Remove decl.
10027 (Fcommand_execute): New forward static decl.
10028 * keymap.c (Flookup_key): New forward static decl.
10029 (Fcopy_keymap): Now static.
10030 * keymap.h (Flookup_key): Remove decl.
10031 * process.c (Fget_process): New forward static decl.
10032 (Fprocess_datagram_address): Mark as internal.
10033 * syntax.c (Fsyntax_table_p): New forward static decl.
10034 (skip_chars): Remove duplicate decl.
10035 * textprop.c (Fprevious_property_change): New forward static decl.
10036 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10037 Now internal.
10038 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10039 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10040
785bbd42
PE
10041 * editfns.c (Fformat): Remove unreachable code.
10042
8b913b57
AS
100432011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10044
10045 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10046 change. (Bug#8496)
10047
a6744a35
EZ
100482011-04-13 Eli Zaretskii <eliz@gnu.org>
10049
10050 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10051 when at ZV. (Bug#8487)
10052
e7974947
AS
100532011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10054
baad03f0
AS
10055 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10056 (Bug#8437)
10057 * keyboard.c (parse_tool_bar_item): Likewise.
10058 * sound.c (sound_cleanup, alsa_close): Likewise.
10059 * termcap.c (tgetent): Likewise.
10060 * xfns.c (x_default_font_parameter): Likewise.
10061 * xsettings.c (read_and_apply_settings): Likewise.
10062
e7974947
AS
10063 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10064 (overrun_check_free): Protoize.
10065
28272684
PE
100662011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10067
10068 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10069 since callers should never pass a negative size.
10070 Change the signature to match that of plain 'read' and 'write'; see
10071 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10072 * lisp.h: Update prototypes of emacs_write and emacs_read.
10073
11997c76
EZ
100742011-04-11 Eli Zaretskii <eliz@gnu.org>
10075
10076 * xdisp.c (redisplay_window): Don't try to determine the character
10077 position of the scroll margin if the window start point w->startp
e896f03c 10078 is outside the buffer's accessible region. (Bug#8468)
11997c76 10079
8a2cbd72
EZ
100802011-04-10 Eli Zaretskii <eliz@gnu.org>
10081
10082 Fix write-region and its subroutines for buffers > 2GB.
10083 * fileio.c (a_write, e_write): Modify declaration of arguments and
10084 local variables to support buffers larger than 2GB.
10085 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10086
10087 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10088 argument, local variables, and return value.
10089
10090 * lisp.h: Update prototypes of emacs_write and emacs_read.
10091
10092 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10093
4073e537 100942011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10095
1ebfdcb6
PE
10096 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10097
b2ded58d
PE
10098 Fix more problems found by GCC 4.6.0's static checks.
10099
7d66342c
PE
10100 * xdisp.c (vmessage): Use a better test for character truncation.
10101
bbf47d44
PE
10102 * charset.c (load_charset_map): <, not <=, for optimization,
10103 and to avoid potential problems with integer overflow.
9248994d 10104 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10105 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10106 * editfns.c (Fformat): Likewise.
1e69125e 10107 * syntax.c (skip_chars): Likewise.
3befa583 10108
e3019616
PE
10109 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10110 This also lets GCC 4.6.0 generate slightly better loop code.
10111
becfa255
PE
10112 * callint.c (Fcall_interactively): <, not <=, for optimization.
10113 (Fcall_interactively): Count the number of arguments produced,
10114 not the number of arguments given. This is simpler and lets GCC
10115 4.6.0 generate slightly better code.
10116
dae0cd48
PE
10117 * ftfont.c: Distingish more carefully between FcChar8 and char.
10118 The previous code passed unsigned char * to a functions like
10119 strlen and xstrcasecmp that expect char *, which does not
10120 conform to the C standard.
10121 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10122 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10123 char * when the C standard requires it.
10124
76032d70
PE
10125 * keyboard.c (read_char): Remove unused var.
10126
eb3f1cc8
PE
10127 * eval.c: Port to Windows vsnprintf (Bug#8435).
10128 Include <limits.h>.
10129 (SIZE_MAX): Define if the headers do not.
10130 (verror): Do not give up if vsnprintf returns a negative count.
10131 Instead, grow the buffer. This ports to Windows vsnprintf, which
10132 does not conform to C99. Problem reported by Eli Zaretskii.
10133 Also, simplify the allocation scheme, by avoiding the need for
10134 calling realloc, and removing the ALLOCATED variable.
10135
70476b54
PE
10136 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10137
12020a9e
PE
10138 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10139 But keep the doprint source code for now, as we might revamp it
10140 and use it again (Bug#8435).
ea6c7ae6
PE
10141 * lisp.h (doprnt): Remove.
10142 * Makefile.in (base_obj): Remove doprnt.o.
10143 * deps.mk (doprnt.o): Remove.
10144
5fdb398c
PE
10145 error: Print 32- and 64-bit integers portably (Bug#8435).
10146 Without this change, on typical 64-bit hosts error ("...%d...", N)
10147 was used to print both 32- and 64-bit integers N, which relied on
10148 undefined behavior.
61bdb816 10149 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10150 * lisp.h (error, verror): Mark as printf-like functions.
10151 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10152 Report overflow in size calculations when allocating printf buffer.
10153 Do not truncate output string at its first null byte.
10154 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10155 Truncate the output at a character boundary, since vsnprintf does not
10156 do that.
10157 * charset.c (check_iso_charset_parameter): Convert internal
10158 character to string before calling 'error', since %c now has the
10159 printf meaning.
10160 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10161 overflow when computing char to be passed to 'error'. Do not
10162 pass Lisp_Object to 'error'; pass the integer instead.
10163 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10164 formatted with plain %d.
10165
b189fa66
PE
10166 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10167
bff87ef0
PE
10168 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10169
7e2cac20
PE
10170 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10171
ce4d90b5
PE
10172 * xterm.c (x_catch_errors): Remove duplicate declaration.
10173
266c9547
PE
10174 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10175
79c49ad2
PE
10176 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10177
368f4090
JM
101782011-04-10 Jim Meyering <meyering@redhat.com>
10179
10180 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10181 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10182 return ssize_t not "int", and use size_t as the buffer length.
10183 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10184 * gnutls.h: Update declarations.
10185 * process.c (read_process_output): Use ssize_t, to match.
10186 (send_process): Likewise.
10187
a32d4040
CY
101882011-04-09 Chong Yidong <cyd@stupidchicken.com>
10189
10190 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10191
8546720e 101922011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10193
04f2d78b
CB
10194 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10195 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10196
8546720e
GM
10197 * xterm.c (handle_one_xevent):
10198 * xmenu.c (create_and_show_popup_menu):
10199 * xselect.c (x_decline_selection_request)
10200 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10201
0a2f5c1a 102022011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10203
10204 Fix some uses of `int' instead of EMACS_INT.
10205 * search.c (string_match_1, fast_string_match)
10206 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10207 (scan_buffer, find_next_newline_no_quit)
10208 (find_before_next_newline, search_command, Freplace_match)
10209 (Fmatch_data): Make some `int' variables be EMACS_INT.
10210
10211 * xdisp.c (display_count_lines): 3rd argument and return value now
10212 EMACS_INT. All callers changed.
10213 (pint2hrstr): Last argument is now EMACS_INT.
10214
10215 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10216 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10217 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10218 (decode_coding_utf_16, decode_coding_emacs_mule)
10219 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10220 (decode_coding_ccl, decode_coding_charset)
10221 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10222 (decode_coding_iso_2022, decode_coding_emacs_mule)
10223 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10224 <char_offset, last_offset>: Declare EMACS_INT.
10225 (encode_coding_utf_8, encode_coding_utf_16)
10226 (encode_coding_emacs_mule, encode_invocation_designation)
10227 (encode_designation_at_bol, encode_coding_iso_2022)
10228 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10229 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10230 Declare EMACS_INT.
10231 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10232 (encode_invocation_designation): Last argument P_NCHARS is now
10233 EMACS_INT.
10234 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10235 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10236
10237 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10238 All users changed.
10239
10240 * ccl.c (Fccl_execute_on_string): Declare some variables
10241 EMACS_INT.
10242
8546720e 102432011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10244
10245 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10246
4e19a977
CS
102472011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10248
10249 * process.c (Fformat_network_address): Doc fix.
10250
87302331
R
102512011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10252
ee7683eb 10253 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10254
cbb59342
CY
102552011-04-08 Chong Yidong <cyd@stupidchicken.com>
10256
10257 * keyboard.c (read_char): Call Lisp function help-form-show,
10258 instead of using internal_with_output_to_temp_buffer.
10259 (Qhelp_form_show): New var.
e0d38eeb 10260 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10261
10262 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10263
10264 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10265
e67a13ab
CY
102662011-04-06 Chong Yidong <cyd@stupidchicken.com>
10267
04f2d78b
CB
10268 * process.c (Flist_processes): Remove to Lisp.
10269 (list_processes_1): Delete.
e67a13ab 10270
973f782d
EZ
102712011-04-06 Eli Zaretskii <eliz@gnu.org>
10272
7c106b1e
EZ
10273 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10274
973f782d
EZ
10275 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10276
41cf7d1a 102772011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10278
ca23cc88
PE
10279 Fix more problems found by GCC 4.6.0's static checks.
10280
f390e2d5
PE
10281 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10282
42eea0d0
PE
10283 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10284
b69769da 10285 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10286
f9541e84
PE
10287 * xdisp.c (vmessage): Mark as a printf-like function.
10288
13841b55
PE
10289 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10290
c136c10f
PE
10291 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10292
5e2d4a30
PE
10293 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10294 printf-like functions.
10295 (tiff_load): Add casts to remove these marks before passing them
10296 to system-supplied API.
10297
583f48b9
PE
10298 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10299
b25d760e
PE
10300 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10301 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10302 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10303 directly, rather than having caller test rule sign. This avoids
10304 some unnecessary tests.
10305 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10306 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10307 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10308
bc7b6697 10309 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10310 (xfont_open): Avoid unnecessary tests.
bc7b6697 10311
27ccc379
PE
10312 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10313
dcd5c89a
PE
10314 * composite.h, composite.c (composition_gstring_put_cache):
10315 Use EMACS_INT, not int, for length.
10316
b13a45c6
PE
10317 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10318 breaking out part of COMPOSITION_DECODE_RULE.
10319 (COMPOSITION_DECODE_RULE): Use it.
10320 * composite.c (get_composition_id): Remove unused local vars,
10321 by using the new macro.
10322
1e792e4d
PE
10323 * textprop.c (set_text_properties_1): Change while to do-while,
10324 since the condition is always true at first.
10325
dc6c6455 10326 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10327 (interval_deletion_adjustment): Return unsigned value.
10328 All uses changed.
dc6c6455 10329
aba7731a
PE
10330 * process.c (list_processes_1, create_pty, read_process_output):
10331 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10332 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10333 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10334 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10335 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10336
fdfc4bf3
PE
10337 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10338
fca8fe46 10339 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10340 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10341
06a0259a 10342 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10343 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10344 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10345
e7b9e80f
PE
10346 * print.c (print_error_message): Avoid int overflow.
10347
56201685
PE
10348 * font.c (font_list_entities): Redo for clarity,
10349 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10350
78834453 10351 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10352 (font_score): Avoid potential overflow in diff calculation.
78834453 10353
0bc0b309 10354 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10355 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10356
e610eaca
PE
10357 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10358
b895abce
PE
10359 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10360 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10361 can always succeed if overflow has undefined behavior.
10362
1f1d9321 10363 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10364 (wordify): Omit three unnecessary tests.
1f1d9321 10365
c59478bc
PE
10366 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10367 All callers changed. This avoids the need for an unused var.
10368
79b73827
PE
10369 * casefiddle.c (casify_region): Remove var that is set but not used.
10370
a4db5dfe
PE
10371 * dired.c (file_name_completion): Remove var that is set but not used.
10372
43aae36e
PE
10373 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10374
2a47c44d 10375 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10376 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10377
a37c69bf
PE
10378 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10379 Check for integer overflow on size calculations.
10380
328ab8e7
PE
10381 * buffer.c (Fprevious_overlay_change): Remove var that is set
10382 but not used.
10383
e5a2a5cb
PE
10384 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10385 Remove vars that are set but not used.
8d84a6eb 10386 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10387 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10388
a60e5f68
PE
10389 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10390
f661cb61 10391 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10392 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10393
f0397f5a
PE
10394 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10395 that are set but not used.
10396
8664db06 10397 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10398 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10399
6abdaa4a
PE
10400 * xselect.c (x_get_local_selection, x_handle_property_notify):
10401 Remove vars that are set but not used.
10402
0ce7538d 10403 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10404 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10405
9ae848fc
PE
10406 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10407 Remove var that is set but not used.
0b918413
PE
10408 (scroll_bar_windows_size): Now size_t, not int.
10409 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10410 Check for overflow.
9ae848fc 10411
a5a62657
PE
10412 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10413 (map_tty_color) [!defined MSDOS]: Likewise.
10414
5c5cdd39
PE
10415 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10416
66ebf983
PE
10417 * coding.c: Remove vars that are set but not used.
10418 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10419 All callers changed.
10420 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10421 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10422 (decode_coding_charset): Remove vars that are set but not used.
10423
1be4d761
PE
10424 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10425 that is set but not used.
10426
47553fa8
PE
10427 * print.c (print_object): Remove var that is set but not used.
10428
1f7196bf 10429 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10430 The gnulib version avoids calling malloc in the usual case,
10431 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10432 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10433 * filelock.c (current_lock_owner): Likewise.
10434 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10435 * sysdep.c: Include allocator.h, careadlinkat.h.
10436 (emacs_no_realloc_allocator): New static constant.
10437 (emacs_readlink): New function.
fdb61804
PE
10438 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10439 ../lib/careadlinkat.h.
d1fdcab7 10440
f84c17c7
SM
104412011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10442
10443 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10444 first non-nil return value).
10445
ef3862ad
JD
104462011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10447
10448 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10449 if not defined (Bug#8403).
10450
376a7006
JB
104512011-04-02 Juanma Barranquero <lekktu@gmail.com>
10452
10453 * xdisp.c (display_count_lines): Remove parameter `start',
10454 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10455 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10456 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10457 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10458 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10459 and thereabouts. All callers changed.
10460 (get_per_char_metric): Remove parameter `f', unused since
10461 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10462
6ca3801d
JM
104632011-04-02 Jim Meyering <meyering@redhat.com>
10464
10465 do not dereference NULL upon failed strdup
10466 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10467 (ns_get_family): Likewise.
10468
d8e2b5ba
JB
104692011-04-02 Juanma Barranquero <lekktu@gmail.com>
10470
10471 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10472
8c74fcbd
JD
104732011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10474
10475 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10476 later (Bug#8403).
10477
7200d79c
SM
104782011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10479
03408648 10480 Add lexical binding.
7200d79c 10481
03408648
SM
10482 * window.c (Ftemp_output_buffer_show): New fun.
10483 (Fsave_window_excursion):
10484 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10485
10486 * lread.c (lisp_file_lexically_bound_p): New function.
10487 (Fload): Bind Qlexical_binding.
10488 (readevalloop): Remove `evalfun' arg.
10489 Bind Qinternal_interpreter_environment.
10490 (Feval_buffer): Bind Qlexical_binding.
10491 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10492 Mark as dynamic.
10493 (syms_of_lread): Declare `lexical-binding'.
10494
10495 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10496
10497 * keyboard.c (eval_dyn): New fun.
10498 (menu_item_eval_property): Use it.
ca105506
SM
10499
10500 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10501
03408648
SM
10502 * fns.c (concat, mapcar1): Accept byte-code-functions.
10503
10504 * eval.c (Fsetq): Handle lexical vars.
10505 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10506 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10507 (FletX, Flet): Obey lexical binding.
10508 (Fcommandp): Handle closures.
10509 (Feval): New `lexical' arg.
10510 (eval_sub): New function extracted from Feval. Use it almost
10511 everywhere where Feval was used. Look up vars in lexical env.
10512 Handle closures.
10513 (Ffunctionp): Move from subr.el.
10514 (Ffuncall): Handle closures.
10515 (apply_lambda): Remove `eval_flags'.
10516 (funcall_lambda): Handle closures and new byte-code-functions.
10517 (Fspecial_variable_p): New function.
10518 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10519 but without exporting it to Lisp.
23aba0ea 10520
23aba0ea 10521 * doc.c (Fdocumentation, store_function_docstring):
03408648 10522 * data.c (Finteractive_form): Handle closures.
23aba0ea 10523
03408648
SM
10524 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10525 interactive spec.
ba83908c 10526
04f2d78b
CB
10527 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10528 New byte-codes.
03408648
SM
10529 (exec_byte_code): New function extracted from Fbyte_code to handle new
10530 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10531
03408648 10532 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10533
03408648 10534 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10535
e2abce01
JB
105362011-03-31 Juanma Barranquero <lekktu@gmail.com>
10537
10538 * xdisp.c (redisplay_internal): Fix prototype.
10539
63696a73 105402011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10541
63696a73 10542 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10543 (try_scrolling): Use it when setting scroll_limit.
10544 Limit scrolling to 100 screen lines.
63696a73
EZ
10545 (redisplay_window): Even when falling back on "recentering",
10546 position point in the window according to scroll-conservatively,
10547 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10548
10549 (try_scrolling): When point is above the window, allow searching
10550 as far as scroll_max, or one screenful, to compute vertical
10551 distance from PT to the scroll margin position. This prevents
10552 try_scrolling from unnecessarily failing when
10553 scroll-conservatively is set to a value slightly larger than the
10554 window height. Clean up the case of PT below the margin at bottom
10555 of window: scroll_max can no longer be INT_MAX. When aggressive
10556 scrolling is in use, don't let point enter the opposite scroll
10557 margin as result of the scroll.
10558 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10559 threshold of 100 lines for never-recentering scrolling.
10560
e4cc2dfc
JB
105612011-03-31 Juanma Barranquero <lekktu@gmail.com>
10562
10563 * dispextern.h (move_it_by_lines):
10564 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10565 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10566 (message_log_check_duplicate): Remove parameters `prev_bol' and
10567 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10568 (redisplay_internal): Remove parameter `preserve_echo_area',
10569 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10570
10571 * indent.c (Fvertical_motion):
10572 * window.c (window_scroll_pixel_based, Frecenter):
10573 Don't pass `need_y_p' to `move_it_by_lines'.
10574
1c470562
SM
105752011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10576
44f230aa
SM
10577 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10578 steal a few bits to be more compact.
10579 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10580 Remove unneeded casts.
10581
1c470562
SM
10582 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10583
888adce9
ZK
105842011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10585
10586 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10587 binding" message (bug#7967).
10588
f838ed7b
PE
105892011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10590
77861b95
PE
10591 Fix more problems found by GCC 4.6.0's static checks.
10592
de6dbc14
PE
10593 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10594 Remove unused local var.
10595
f838ed7b
PE
10596 * editfns.c (Fmessage_box): Remove unused local var.
10597
792c7b2b
PE
10598 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10599 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10600 Omit unused local vars.
c499e557 10601 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10602 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10603 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10604 Omit unused local var.
10605
ba0165e1
PE
10606 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10607 Don't assume string length fits in int.
32ad8845 10608 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10609 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10610
3c59b4c9
PE
10611 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10612 instead of alloca (Bug#8344).
10613
a3eed478 10614 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10615 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10616
eb4d412d
PE
10617 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10618
1658b401
PE
10619 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10620 concerns.
10621
10622 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10623
10624 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10625
9a2c6e05
PE
10626 * keyboard.c (syms_of_keyboard): Use the same style as later
10627 in this function when indexing through an array. This also
10628 works around GCC bug 48267.
10629
03d0a109
PE
10630 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10631
44f730c8
PE
10632 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10633
fe75f926
PE
10634 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10635 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10636
ffa8c828
PE
10637 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10638 This avoids undefined behavior on integer overflow, and is a bit
10639 more convenient anyway since it is compared to a size_t variable.
10640
c5101a77
PE
10641 Variadic C functions now count arguments with size_t, not int.
10642 This avoids an unnecessary limitation on 64-bit machines, which
10643 caused (substring ...) to crash on large vectors (Bug#8344).
10644 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10645 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10646 All variadic functions and their callers changed accordingly.
c5101a77
PE
10647 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10648 * data.c (arith_driver, float_arith_driver): Likewise.
10649 * editfns.c (general_insert_function): Likewise.
10650 * eval.c (struct backtrace.nargs, interactive_p)
10651 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10652 (funcall_lambda, mark_backtrace): Likewise.
10653 * fns.c (concat): Likewise.
10654 * frame.c (x_set_frame_parameters): Likewise.
10655 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10656 0 if not found, not -1. All callers changed.
10657
dd3f25f7
PE
10658 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10659 (stack_copy_size): Now size_t, not int.
10660 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10661
461c2ab9
JB
106622011-03-28 Juanma Barranquero <lekktu@gmail.com>
10663
10664 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10665 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10666 All callers changed.
10667
10668 * lisp.h (multibyte_char_to_unibyte):
10669 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10670 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10671 * character.h (CHAR_TO_BYTE8):
10672 * cmds.c (internal_self_insert):
10673 * editfns.c (general_insert_function):
10674 * keymap.c (push_key_description):
10675 * search.c (Freplace_match):
10676 * xdisp.c (message_dolog, set_message_1): All callers changed.
10677
f6d62986
SM
106782011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10679
10680 * keyboard.c (safe_run_hook_funcall): New function.
10681 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10682 don't set the hook to nil, but remove the offending function instead.
10683 (Qcommand_hook_internal): Remove, unused.
10684 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10685 Vcommand_hook_internal.
10686
10687 * eval.c (enum run_hooks_condition): Remove.
10688 (funcall_nil, funcall_not): New functions.
10689 (run_hook_with_args): Call each function through a `funcall' argument.
10690 Remove `cond' argument, now redundant.
10691 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10692 (Frun_hook_with_args_until_failure): Adjust accordingly.
10693 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10694
1db5b1ad
JB
106952011-03-28 Juanma Barranquero <lekktu@gmail.com>
10696
10697 * dispextern.h (string_buffer_position): Remove declaration.
10698
10699 * print.c (strout): Remove parameter `multibyte', unused since
10700 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10701
10702 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10703 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10704 All callers changed.
10705
10706 * w32.c (_wsa_errlist): Use braces for struct initializers.
10707
10708 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10709 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10710 All callers changed.
10711 (string_buffer_position): Likewise. Also, make static (it's never
10712 used outside xdisp.c).
10713 (cursor_row_p): Remove parameter `w', unused since
10714 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10715 (decode_mode_spec): Remove parameter `precision', introduced during
10716 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10717 All callers changed.
10718
5ffb62aa
JD
107192011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10720
10721 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10722
461c2ab9 107232011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10724
10725 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10726 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10727 (ns_update_auto_hide_menu_bar): New functions.
10728 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10729 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10730 ns_constrain_all_frames.
10731 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10732 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10733
5c380ffb
JD
107342011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10735
10736 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10737
9af30bdf
GM
107382011-03-27 Glenn Morris <rgm@gnu.org>
10739
10740 * syssignal.h: Replace RETSIGTYPE with void.
10741 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10742 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10743 Replace SIGTYPE with void everywhere.
10744 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10745 * s/template.h (SIGTYPE): Remove commented out definition.
10746
e2abce01
JB
107472011-03-26 Eli Zaretskii <eliz@gnu.org>
10748
10749 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10750 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10751
f868cd8a
JB
107522011-03-26 Juanma Barranquero <lekktu@gmail.com>
10753
59eb0929
JB
10754 * w32.c (read_unc_volume): Use parameter `henum', instead of
10755 global variable `wget_enum_handle'.
10756
10757 * keymap.c (describe_vector): Remove parameters `indices' and
10758 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10759 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10760
f868cd8a
JB
10761 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10762
10763 * keyboard.c (timer_check): Remove parameter `do_it_now',
10764 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10765 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10766 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10767
10768 * keyboard.c (read_char):
10769 * w32menu.c (w32_menu_display_help):
10770 * xmenu.c (show_help_event, menu_help_callback):
10771 Adjust calls to `show_help_echo'.
10772
10773 * gtkutil.c (xg_maybe_add_timer):
10774 * keyboard.c (readable_events):
10775 * process.c (wait_reading_process_output):
10776 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10777
10778 * insdel.c (adjust_markers_gap_motion):
10779 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10780 (gap_left, gap_right): Don't call it.
10781
2ecf6fdb
CY
107822011-03-25 Chong Yidong <cyd@stupidchicken.com>
10783
10784 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10785 incurred during fontification.
10786
6b1f9ba4
JB
107872011-03-25 Juanma Barranquero <lekktu@gmail.com>
10788
10789 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10790 (DEFVAR_PER_BUFFER): Don't pass it.
10791
10792 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10793 (scrolling_window): Don't pass it.
10794
0f4a96b5
JB
107952011-03-25 Juanma Barranquero <lekktu@gmail.com>
10796
10797 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10798
10799 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10800 and `suffix'.
10801 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10802 of variables specific to SELinux and computation of `encoded_absname'.
10803
10804 * image.c (XPutPixel): Remove unused variable `height'.
10805
10806 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10807
10808 * unexw32.c (get_section_info): Remove unused variable `section'.
10809
10810 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10811 (system_process_attributes): Remove unused variable `sess'.
10812 (sys_read): Remove unused variable `err'.
10813
10814 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10815 (w32_wnd_proc): Remove unused variable `isdead'.
10816 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10817 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10818 (x_create_tip_frame): Remove unused variable `tem'.
10819
10820 * w32inevt.c (w32_console_read_socket):
10821 Remove unused variable `no_events'.
10822
10823 * w32term.c (x_draw_composite_glyph_string_foreground):
10824 Remove unused variable `width'.
10825
1149507c
JB
108262011-03-24 Juanma Barranquero <lekktu@gmail.com>
10827
10828 * w32term.c (x_set_glyph_string_clipping):
10829 Don't pass uninitialized region to CombineRgn.
10830
9c88f339
JB
108312011-03-23 Juanma Barranquero <lekktu@gmail.com>
10832
10833 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10834 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10835 (Fx_close_connection): Remove unused variable `i'.
10836
10837 * w32font.c (w32font_draw): Return number of glyphs.
10838 (w32font_open_internal): Remove unused variable `i'.
10839 (w32font_driver): Add missing initializer.
10840
10841 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10842 (fill_in_menu): Remove unused variable `items_added'.
10843
10844 * w32term.c (last_mouse_press_frame): Remove static global variable.
10845 (w32_clip_to_row): Remove unused variable `f'.
10846 (x_delete_terminal): Remove unused variable `i'.
10847
10848 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10849 (NOTHING): Remove unused static global variable.
10850 (uniscribe_check_otf): Remove unused variable `table'.
10851 (uniscribe_font_driver): Add missing initializers.
10852
dee091a3
JD
108532011-03-23 Julien Danjou <julien@danjou.info>
10854
10855 * term.c (Fsuspend_tty, Fresume_tty):
10856 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10857 * window.c (temp_output_buffer_show):
10858 * insdel.c (signal_before_change):
10859 * frame.c (Fhandle_switch_frame):
10860 * fileio.c (Fdo_auto_save):
10861 * emacs.c (Fkill_emacs):
10862 * editfns.c (save_excursion_restore):
10863 * cmds.c (internal_self_insert):
10864 * callint.c (Fcall_interactively):
10865 * buffer.c (Fkill_all_local_variables):
10866 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10867 Use Frun_hooks.
0f4a96b5 10868 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10869 unconditionally since it does the check itself.
dee091a3 10870
2c520ab5 108712011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10872
c9c49752
PE
10873 Fix more problems found by GCC 4.5.2's static checks.
10874
8abc3f12
PE
10875 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10876 the first time through the loop, since we know p0 < p1 then.
10877 This also avoids a gcc -Wstrict-overflow warning.
10878
a2d26660
PE
10879 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10880 leading to a memory leak, possible in functions like
10881 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10882 of objects (Bug#8318).
a2d26660 10883
916c72e9
PE
10884 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10885 that could (at least in theory) be that large.
10886
19ab8a18
PE
10887 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10888 This is less likely to overflow, and avoids undefined behavior if
10889 overflow does occur. All callers changed. Use strtoul to scan
10890 for the unsigned long integer.
b7cbbd6f
PE
10891 (pint2hrstr): Simplify and tune code slightly.
10892 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10893
f0641eff
PE
10894 * scroll.c (do_scrolling): Work around GCC bug 48228.
10895 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10896
7f650bb9
PE
10897 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10898 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10899 (validate_x_resource_name): Simplify count usage.
10900 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10901
37dd57d1
PE
10902 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10903 fail (Bug#8306).
81e56e61 10904
699979fc 10905 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10906
401bf9b4
PE
10907 * process.c (Fmake_network_process): Use socklen_t, not int,
10908 where POSIX says socklen_t is required in portable programs.
10909 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10910 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10911 (Fmake_network_process, server_accept_connection):
10912 (wait_reading_process_output, read_process_output):
10913 Likewise.
10914
b93aacde
PE
10915 * process.c: Rename or move locals to avoid shadowing.
10916 (list_processes_1, Fmake_network_process):
10917 (read_process_output_error_handler, exec_sentinel_error_handler):
10918 Rename or move locals.
4dc343ee 10919 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10920 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10921 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10922 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10923 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10924
af8a867c 10925 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10926 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10927 Include tparam.h instead, since it declares them.
af8a867c
PE
10928 * cm.h (PC): Remove extern decl; tparam.h now does this.
10929 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10930 * terminfo.c: Include tparam.h, to check interfaces.
10931 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10932 (tparam): Adjust signature to match interface in tparam.h;
10933 this removes some undefined behavior. Check that outstring and len
10934 are zero, which they always are with Emacs.
10935 * tparam.h (PC, BC, UP): New extern decls.
10936
0248044d 10937 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10938 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10939
8ff096c1 10940 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10941 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10942 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10943 (ftfont_list): Remove unused local.
49eaafba
PE
10944 (get_adstyle_property, ftfont_pattern_entity):
10945 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10946 Rename locals to avoid shadowing.
8ff096c1 10947
e2be39f6
PE
10948 * xfont.c (xfont_list_family): Mark var as initialized.
10949
c9735e30
PE
10950 * xml.c (make_dom): Now static.
10951
8f5201ae
PE
10952 * composite.c (composition_compute_stop_pos): Rename local to
10953 avoid shadowing.
b246f932
PE
10954 (composition_reseat_it): Remove unused locals.
10955 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10956 (composition_update_it): Mark var as initialized.
11b61122
PE
10957 (find_automatic_composition): Mark vars as initialized,
10958 with a FIXME (Bug#8290).
8f5201ae 10959
760fbc2c
PE
10960 character.h: Rename locals to avoid shadowing.
10961 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10962 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10963 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10964 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10965 to avoid shadowing.
10966
ff08eb85
PE
10967 * textprop.c (property_change_between_p): Remove; unused.
10968
fc7bf025
PE
10969 * intervals.c (interval_start_pos): Now static.
10970
235d7abc
PE
10971 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10972
44f230aa
SM
10973 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10974 Rename locals to avoid shadowing.
3e7d6594 10975
50060332
PE
10976 * sound.c (wav_play, au_play, Fplay_sound_internal):
10977 Fix pointer signedness.
d01f234b 10978 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10979 (wav_play): Initialize a variable to 0, to prevent undefined
10980 behavior (Bug#8278).
50060332 10981
c4fc4e30
PE
10982 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10983
918436ed
PE
10984 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10985
c939f91b
PE
10986 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10987 clobbering (Bug#8298).
b9c7f648
PE
10988 * sysdep.c (sys_subshell): Likewise.
10989 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10990
6bd8c144
PE
10991 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10992 This should get cleaned up, so that child_setup has the
10993 same signature on all platforms.
10994
7710357c 10995 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10996 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10997
c59da222
CY
109982011-03-22 Chong Yidong <cyd@stupidchicken.com>
10999
11000 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11001 not to be necessary, and produces flickering.
11002
66b87493
GM
110032011-03-20 Glenn Morris <rgm@gnu.org>
11004
11005 * config.in: Remove file.
11006
45b6f6d5
JB
110072011-03-20 Juanma Barranquero <lekktu@gmail.com>
11008
11009 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11010 are now in src/globals.h.
11011 (syms_of_minibuf): Remove spurious & from previous change.
11012
cd394be1 110132011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11014
11015 * minibuf.c (completing-read-function): New variable.
11016 (completing-read-default): Rename from completing-read.
11017 (completing-read): Call completing-read-function.
11018
b14e3e21
CY
110192011-03-19 Juanma Barranquero <lekktu@gmail.com>
11020
11021 * xfaces.c (Fx_load_color_file):
11022 Read color file from absolute filename (bug#8250).
11023
f2b726e6
JB
110242011-03-19 Juanma Barranquero <lekktu@gmail.com>
11025
11026 * makefile.w32-in: Update dependencies.
11027
09f6ff02
EZ
110282011-03-17 Eli Zaretskii <eliz@gnu.org>
11029
11030 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11031
29a6015a
PE
110322011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11033
a3a6c54e
PE
11034 Fix more problems found by GCC 4.5.2's static checks.
11035
b766f867
PE
11036 * process.c (make_serial_process_unwind, send_process_trap):
11037 (sigchld_handler): Now static.
11038
be02381c
PE
11039 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11040 That way, the code declares only the vars that it needs.
11041 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11042 * s/cygwin.h (PTY_ITERATION): Likewise.
11043 * s/darwin.h (PTY_ITERATION): Likewise.
11044 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11045
57048744
PE
11046 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11047 * process.c (allocate_pty): Don't declare stb unless it's needed.
11048
7914961c 11049 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11050 (CONSTANTLIM): Remove; unused.
11051 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11052 Define only if needed.
7914961c 11053
b3967b18
PE
11054 * unexelf.c (unexec): Name an expression,
11055 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11056 Use a different way to cause a compilation error if anyone uses
11057 n rather than nn, a way that does not involve shadowing.
73366a00 11058 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11059
29a6015a
PE
11060 * deps.mk (unexalpha.o): Remove; unused.
11061
43cfc33e 11062 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11063 * unexec.h: New file.
ce701a33
PE
11064 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11065 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11066 Depend on unexec.h.
11067 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11068 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11069 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11070 Change as necessary to match prototype in unexec.h.
ce701a33 11071
01f44d5a
PE
11072 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11073 shadowing.
4f63c6bb 11074 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11075
a6670b0b
PE
11076 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11077 Rename locals to avoid shadowing.
11078
cef2010d 11079 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11080 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11081
d4d7173a
PE
11082 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11083
f08b802a
PE
11084 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11085 warning when compiling print.c.
11086
3ddb0639
PE
11087 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11088 instead of using an uninitialized var.
5ad03b97 11089 (font_sort_entities): Mark var as initialized.
3ddb0639 11090
170a2692
PE
11091 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11092
e663c700
PE
11093 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11094 pointers to constants.
89bc529a 11095 (font_parse_fcname): Remove unused vars.
7b81e2d0 11096 (font_delete_unmatched): Now static.
ea838e10 11097 (font_get_spec): Remove; unused.
13a547c6
PE
11098 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11099 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11100 Rename or move locals to avoid shadowing.
e663c700 11101
2a80c887 11102 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11103 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11104
1384fa33 11105 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11106 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11107
8b2c52e9
PE
11108 * alloc.c (mark_backtrace): Move decl from here ...
11109 * lisp.h: ... to here, so that it can be checked.
11110
475545b5 11111 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11112 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11113 (lisp_indirect_variable): Name an expression,
11114 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11115 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11116
b1349114 11117 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11118 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11119 Use const pointer when appropriate.
b1349114 11120
a2928364
PE
11121 * lisp.h (get_system_name, get_operating_system_release):
11122 Move decls here, to check interfaces.
11123 * process.c (get_operating_system_release): Move decl to lisp.h.
11124 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11125 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11126 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11127 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11128 (Fformat_time_string, Fencode_time, Finsert_char):
11129 (Ftranslate_region_internal, Fformat):
11130 Rename or remove local vars to avoid shadowing.
9710023e 11131 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11132
a415e694
PE
11133 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11134 avoid shadowing.
11135
8ef4622d
PE
11136 * lisp.h (eassert): Check that the argument compiles, even if
11137 ENABLE_CHECKING is not defined.
11138
946f9a5b
PE
11139 * data.c (Findirect_variable): Name an expression, to avoid
11140 gcc -Wbad-function-cast warning.
112396d6 11141 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11142 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11143 (Fmake_variable_buffer_local, Fmake_local_variable):
11144 Mark variables as initialized.
52746918 11145 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11146
e5aab7e7 11147 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11148 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11149 Rename locals to avoid shadowing.
dff45157
PE
11150 (mark_stack): Move local variables into the #ifdef region where
11151 they're used.
7bc26fdb
PE
11152 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11153 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11154 needed otherwise.
11155 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11156 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11157 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11158
e5aab7e7
PE
11159 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11160 avoids undefined behavior in theory.
11161
4da60324
PE
11162 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11163
88043301
PE
11164 Use functions, not macros, for up- and down-casing (Bug#8254).
11165 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11166 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11167 to use the following functions instead of these macros.
11168 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11169 EMACS_INT, since callers assume the returned value fits in int.
11170 (upcase1): Likewise, for UPCASE_TABLE.
11171 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11172 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11173 the race-condition problem in the old DOWNCASE.
88043301 11174
19ed5445
PE
11175 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11176 Rename locals to avoid shadowing.
11177 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11178 (regex_compile, re_search_2, re_match_2_internal):
11179 Remove unused local vars.
952db0d7
PE
11180 (FREE_VAR): Rewrite so as not to use empty "else",
11181 which gcc can warn about.
da053e48 11182 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11183 (RETALLOC_IF): Define only if needed.
11184 (WORDCHAR_P): Likewise. This one is never needed, but is used
11185 only in a comment talking about a compiler bug, so put inside
11186 the #if 0 of that comment.
11187 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11188 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11189 Remove; unused.
19ed5445 11190
1f3561e4 11191 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11192 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11193 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11194
ded6f8f7
PE
11195 * search.c (simple_search): Remove unused var.
11196
dbd37a95
PE
11197 * dired.c (compile_pattern): Move decl from here ...
11198 * lisp.h: ... to here, so that it can be checked.
11199 (struct re_registers): New forward decl.
11200
7e47afad
PE
11201 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11202
85f24f61
PE
11203 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11204 All uses changed.
11205 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11206 Rename locals to avoid shadowing.
5671df8f 11207 (Fvertical_motion): Mark locals as initialized.
85f24f61 11208
181aa2be 11209 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11210 (casify_region): Mark local as initialized.
181aa2be 11211
930d429c
PE
11212 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11213
7082eac6
PE
11214 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11215 New macros, so that the caller can use some names other than
11216 gcpro1, gcpro2, etc.
11217 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11218 of the new macros.
11219 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11220 argument, for consistency with GCPRO2_VAR, etc: it is now the
11221 prefix of the variable, not the variable itself. All uses
11222 changed.
38b2c076
PE
11223 * dired.c (directory_files_internal, file_name_completion):
11224 Rename locals to avoid shadowing.
11225
15206ed9
PE
11226 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11227 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11228 dired.c's scmp function, had undefined behavior.
11229 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11230 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11231 * buffer.h: ... to here, because these macros use current_buffer,
11232 and the new implementation with inline functions needs to have
11233 current_buffer in scope now, rather than later when the macros
11234 are used.
11235 (downcase, upcase1): New static inline functions.
11236 (DOWNCASE, UPCASE1): Reimplement using these functions.
11237 This avoids undefined behavior in expressions like
11238 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11239 from race conditions in accessing the global variables
11240 case_temp1 and case_temp2.
11241 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11242 * lisp.h (case_temp1, case_temp2): Remove their decls.
11243 * character.h (ASCII_CHAR_P): Move from here ...
11244 * lisp.h: ... to here, so that the inline functions mentioned
11245 above can use them.
11246
4a6bea26
PE
11247 * dired.c (directory_files_internal_unwind): Now static.
11248
f14b7e14
PE
11249 * fileio.c (file_name_as_directory, directory_file_name):
11250 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11251 Now static.
2893f146
PE
11252 (file_name_as_directory): Use const pointers when appropriate.
11253 (Fexpand_file_name): Likewise. In particular, newdir might
11254 point at constant storage, so make it a const pointer.
fd4ead52 11255 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11256 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11257 signedness issues.
f839df0c
PE
11258 (Fset_file_times, Finsert_file_contents, auto_save_error):
11259 Rename locals to avoid shadowing.
f14b7e14 11260
5716756e 11261 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11262 (Ftry_completion, Fall_completions): Rename or remove locals
11263 to avoid shadowing.
5716756e 11264
b4c3046a
PE
11265 * marker.c (bytepos_to_charpos): Remove; unused.
11266
b45db522
PE
11267 * lisp.h (verify_bytepos, count_markers): New decls,
11268 so that gcc does not warn that these functions aren't declared.
11269
85876d07
PE
11270 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11271 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11272 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11273 (copy_text): Remove unused local var.
85876d07 11274
03d78a21 11275 * filelock.c (within_one_second): Now static.
b3dd38ab 11276 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11277
5df8f01b
PE
11278 * buffer.c (fix_overlays_before): Mark locals as initialized.
11279 (fix_start_end_in_overlays): Likewise. This function should be
11280 simplified by using pointers-to-pointers, but that's a different
11281 matter.
b1d876f1 11282 (switch_to_buffer_1): Now static.
8f54f30a
PE
11283 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11284 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11285
a70072c9 11286 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11287 Fix pointer signedness issue.
edced198
PE
11288 (sys_subshell): Mark local as volatile if checking for lint,
11289 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11290 (MAXPATHLEN): Define only if needed.
a70072c9 11291
a0977c44
PE
11292 * process.c (serial_open, serial_configure): Move decls from here ...
11293 * systty.h: ... to here, so that they can be checked.
11294
a884fdcc
PE
11295 * fns.c (get_random, seed_random): Move extern decls from here ...
11296 * lisp.h: ... to here, so that they can be checked.
11297
604efe86 11298 * sysdep.c (reset_io): Now static.
b8950c94 11299 (wait_for_termination_signal): Remove; unused.
604efe86 11300
38fc62d9
PE
11301 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11302 (copy_keymap_item, append_key, push_text_char_description):
11303 Now static.
1004a21a 11304 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11305 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11306 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11307 (describe_map_tree):
11308 Rename locals to avoid shadowing.
38fc62d9 11309
2f2650da
PE
11310 * keyboard.c: Declare functions static if they are not used elsewhere.
11311 (echo_char, echo_dash, cmd_error, top_level_2):
11312 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11313 (read_char, kbd_buffer_get_event, make_lispy_position):
11314 (make_lispy_event, make_lispy_movement, apply_modifiers):
11315 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11316 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11317 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11318 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11319 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11320
a053e86c 11321 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11322 (mark_kboards): Move decl here ...
11323 * alloc.c (mark_kboards): ... from here.
a053e86c 11324
4752793e
PE
11325 * lisp.h (force_auto_save_soon): New decl.
11326
74f10ca7 11327 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11328 (DEFINE_DUMMY_FUNCTION): New macro.
11329 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11330 Use it.
c03cd23f
PE
11331 (main): Add casts to avoid warnings
11332 if GCC considers string literals to be constants.
74f10ca7 11333
022e70d4
PE
11334 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11335
59d6fe83
PE
11336 * dbusbind.c: Pointer signedness fixes.
11337 (xd_signature, xd_append_arg, xd_initialize):
11338 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11339 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11340 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11341 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11342
78320123
PE
11343 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11344 if GCC considers string literals to be constants.
49cebcca 11345 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11346
35ac2a97
SM
113472011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11348
fb103ca9
SM
11349 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11350 (print_preprocess, print_object): New macro to fix last change.
11351
35ac2a97
SM
11352 * print.c (print_preprocess): Don't forget font objects.
11353
62973b41
JB
113542011-03-16 Juanma Barranquero <lekktu@gmail.com>
11355
11356 * emacs.c (USAGE3): Doc fixes.
11357
0e48bb22
AS
113582011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11359
11360 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11361 structure.
11362
7684e57b
JB
113632011-03-14 Juanma Barranquero <lekktu@gmail.com>
11364
11365 * lisp.h (VWindow_system, Qfile_name_history):
11366 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11367 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11368 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11369
11370 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11371 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11372
11373 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11374 * w32console.c (detect_input_pending, read_input_pending)
11375 (encode_terminal_code):
11376 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11377 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11378 (w32_system_caret_y, Qfile_name_history):
11379 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11380 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11381 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11382 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11383 * w32proc.c (Qlocal, report_file_error):
11384 * w32term.c (Vwindow_system, updating_frame):
11385 * w32uniscribe.c (initialized, uniscribe_font_driver):
11386 Remove unneeded extern declarations.
11387
2aa46d6c
CY
113882011-03-14 Chong Yidong <cyd@stupidchicken.com>
11389
c96bbc66 11390 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11391
cffc6f3b
CY
113922011-03-13 Chong Yidong <cyd@stupidchicken.com>
11393
11394 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11395 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11396 These macros can no longer be used for assignment.
11397
44f230aa
SM
11398 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11399 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11400 (record_buffer_markers, fetch_buffer_markers): New functions for
11401 recording and fetching special buffer markers.
11402 (set_buffer_internal_1, set_buffer_temp): Use them.
11403
11404 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11405
11406 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11407
11408 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11409 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11410
11411 * xdisp.c (hscroll_window_tree):
11412 (reconsider_clip_changes): Use PT instead of BUF_PT.
11413
d251f04b
EZ
114142011-03-13 Eli Zaretskii <eliz@gnu.org>
11415
11416 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11417 $(EMACS_ROOT)/lib/intprops.h.
11418
f0c77cd1
PE
114192011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11420
3eca4629
PE
11421 Fix more problems found by GCC 4.5.2's static checks.
11422
7c86ee98
PE
11423 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11424 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11425 (xg_free_frame_widgets): Make it clear that a local variable is
11426 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11427 (gdk_window_get_screen): Make it clear that this macro is needed
11428 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11429 (int_gtk_range_get_value): New function, which avoids a diagnostic
11430 from gcc -Wbad-function-cast.
11431 (xg_set_toolkit_scroll_bar_thumb): Use it.
11432 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11433 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11434 (get_utf8_string, xg_get_file_with_chooser):
11435 Rename locals to avoid shadowing.
11436 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11437
41729b81
PE
11438 * xgselect.c (xg_select): Remove unused var.
11439
f0c77cd1
PE
11440 * image.c (four_corners_best): Mark locals as initialized.
11441 (gif_load): Initialize transparent_p to zero (Bug#8238).
11442 Mark another local as initialized.
ec6cf4c6 11443 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11444
ce0ad53d 11445 * image.c (clear_image_cache): Now static.
d5d5a617 11446 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11447 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11448 (x_edge_detection): Remove unnecessary cast that
11449 gcc -Wbad-function-cast diagnoses.
2037898d 11450 (gif_load): Fix pointer signedness.
6ae141d6
PE
11451 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11452 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11453
33383987 114542011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11455
d32df629
PE
11456 Improve quality of tests for time stamp overflow.
11457 For example, without this patch (encode-time 0 0 0 1 1
11458 1152921504606846976) returns the obviously-bogus value (-948597
11459 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11460 reports time overflow. See
11461 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11462 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11463 * editfns.c: Include limits.h and intprops.h.
11464 (TIME_T_MIN, TIME_T_MAX): New macros.
11465 (time_overflow): Move earlier, to before first use.
11466 (hi_time, lo_time): New functions, for an accurate test for
11467 out-of-range times.
11468 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11469 (Fget_internal_run_time): Don't assume time_t fits in int.
11470 (make_time): Use list2 instead of Fcons twice.
11471 (Fdecode_time): More accurate test for out-of-range times.
11472 (check_tm_member): New function.
11473 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11474 (lisp_time_argument): Don't rely on undefined left-shift and
11475 right-shift behavior when checking for time stamp overflow.
8be6f318 11476
fe31d94c
PE
11477 * editfns.c (time_overflow): New function, refactoring common code.
11478 (Fformat_time_string, Fdecode_time, Fencode_time):
11479 (Fcurrent_time_string): Use it.
11480
8be6f318
PE
11481 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11482 * dired.c (make_time): Move to ...
11483 * editfns.c (make_time): ... here.
11484 * systime.h: Note the move.
11485
09d9db2c 114862011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11487
126bc0dc
YM
11488 * fringe.c (update_window_fringes): Remove unused variables.
11489
c47cbdfd
YM
11490 * unexmacosx.c (copy_data_segment): Also copy __got section.
11491 (Bug#8223)
11492
7ac80be9
EZ
114932011-03-12 Eli Zaretskii <eliz@gnu.org>
11494
c96bbc66 11495 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11496 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11497 Constify `char *' arguments and their references according to
11498 prototypes in tparam.h.
11499
ecb0f94d 11500 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11501
7ac80be9
EZ
11502 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11503 Adapt all references accordingly.
11504
11505 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11506
ef1fd07e
TT
115072011-03-11 Tom Tromey <tromey@redhat.com>
11508
11509 * buffer.c (syms_of_buffer): Remove obsolete comment.
11510
7ef4b50c
EZ
115112011-03-11 Eli Zaretskii <eliz@gnu.org>
11512
11513 * termhooks.h (encode_terminal_code): Declare prototype.
11514
11515 * msdos.c (encode_terminal_code): Don't declare prototype.
11516
11517 * term.c (encode_terminal_code): Now external again, used by
11518 w32console.c and msdos.c.
11519
44f230aa
SM
11520 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11521 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11522
4b1ec863 115232011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11524
1714f52b 11525 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11526
4b1ec863
PE
11527 * fringe.c (update_window_fringes): Mark locals as initialized
11528 (Bug#8227).
11529 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11530
524c7aa6
PE
11531 * alloc.c (mark_fringe_data): Move decl from here ...
11532 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11533 to check its interface.
11534 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11535
a5c0af81 11536 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11537 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11538 (fontset_font): Mark local as initialized.
a9a06e0b 11539 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11540
b4716021
PE
11541 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11542
811e9bac 11543 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11544 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11545 (x_own_selection, Fx_disown_selection_internal): Rename locals
11546 to avoid shadowing.
11547 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11548
7e3ab302
PE
11549 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11550 so that the caller can use some name other than gcpro1.
11551 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11552 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11553 (Fx_backspace_delete_keys_p):
11554 Use them to avoid shadowing, and rename vars to avoid shadowing.
11555 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11556 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11557 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11558 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11559 Remove unused locals.
7e3ab302
PE
11560 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11561 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11562 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11563 macros.
f78faa98 11564
e2b13473
PE
11565 * xterm.h (x_mouse_leave): New decl.
11566
77f23912
PE
11567 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11568 Remove unused functions.
cdf4ba58
PE
11569 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11570 (x_calc_absolute_position): Now static.
7411c686 11571 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11572 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11573 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11574 unless they are used.
38d0b34a
PE
11575 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11576 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11577 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11578 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11579 (x_error_catcher, x_connection_closed, x_error_handler):
11580 (x_error_quitter, xembed_send_message, x_iconify_frame):
11581 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11582 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11583 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11584
44f230aa
SM
11585 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11586 Rename or move locals to avoid shadowing.
6b463e58 11587 (tty_defined_color, merge_face_heights): Now static.
5967d051 11588 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11589 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11590 does not deduce is never used uninitialized.
73719eba
PE
11591 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11592 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11593
426994c3 11594 * terminal.c (store_terminal_param): Now static.
5489860b 11595
032f1620 11596 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11597 (set_frame_menubar): Remove unused local.
d4323972 11598 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11599 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11600 since they might point to immutable storage.
281585b0
PE
11601 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11602 since it's unused otherwise.
032f1620 11603
367c19e5 11604 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11605 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11606 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11607 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11608 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11609 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11610 does not deduce are never used uninitialized.
70739cbe 11611
07b48fa9
PE
11612 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11613
8868a238 11614 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11615 * window.c (window_loop, size_window):
11616 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11617
7e5cf297 11618 * window.c (display_buffer): Now static.
d6550a9f
PE
11619 (size_window): Mark variables that gcc -Wuninitialized
11620 does not deduce are never used uninitialized.
a586633d
PE
11621 * window.h (check_all_windows): New decl, to forestall
11622 gcc -Wmissing-prototypes diagnostic.
5b555da1 11623 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11624
f6095868
PE
11625 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11626 shadowing.
11627 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11628 Include <limits.h>.
11629 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11630 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11631 (load_charset_map): Mark variables that gcc -Wuninitialized
11632 does not deduce are never used uninitialized.
53df7c11 11633 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11634
f38b440c
PE
11635 * coding.c (coding_set_source, coding_set_destination):
11636 Use "else { /* comment */ }" rather than "else /* comment */;"
11637 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11638 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11639 a block, when the outer 'i' will do.
11640 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11641 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11642 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11643 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11644 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11645 Rename locals to avoid shadowing.
11646 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11647 * coding.c (emacs_mule_char, encode_invocation_designation):
11648 Now static, since they're not used elsewhere.
413bb2db 11649 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11650 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11651 (decode_coding_emacs_mule): Mark variables that gcc
11652 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11653 (detect_coding_iso_2022): Initialize a local variable that might
11654 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11655 this initialization is needed. (Bug#8211)
5f58e762
PE
11656 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11657 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11658 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11659 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11660 Remove unused macros.
f38b440c 11661
232b38b9 11662 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11663 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11664 * character.c (string_count_byte8): Likewise.
232b38b9 11665
fb90da1b
PE
11666 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11667 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11668
fb93dbc2
PE
11669 * chartab.c (copy_sub_char_table): Now static, since it's not used
11670 elsewhere.
5c156ace
PE
11671 (sub_char_table_ref_and_range, char_table_ref_and_range):
11672 Rename locals to avoid shadowing.
bbcd0949 11673 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11674
7d3b3862 11675 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11676 (BIDI_BOB): Remove unused macro.
7d3b3862 11677
6be7d3da
PE
11678 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11679 deduce are never used uninitialized.
c2ed9c8b 11680 * term.c (encode_terminal_code): Likewise.
6be7d3da 11681
75f8807f 11682 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11683
50938595
PE
11684 * tparam.h: New file.
11685 * term.c, tparam.h: Include it.
11686 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11687 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11688 Move these decls to tparam.h, and make them agree with what
11689 is actually in tparam.c. The previous trick of using incompatible
11690 decls in different modules does not conform to the C standard.
11691 All callers of tparam changed to use tparam's actual API.
11692 * tparam.c (tparam1, tparam, tgoto):
11693 Use const pointers where appropriate.
11694
fbceeba2
PE
11695 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11696 * cm.h (struct cm): Likewise.
11697 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11698 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11699 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11700 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11701 (turn_on_face, init_tty): Likewise.
11702 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11703
7f3f1250
PE
11704 * term.c (term_mouse_position): Rename local to avoid shadowing.
11705
e6ca6543
PE
11706 * alloc.c (mark_ttys): Move decl from here ...
11707 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11708
c40f8d15
AS
117092011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11710
11711 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11712
cfe0661d
JB
117132011-03-09 Juanma Barranquero <lekktu@gmail.com>
11714
11715 * search.c (compile_pattern_1): Remove argument regp, unused since
11716 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11717 (compile_pattern): Don't pass it.
11718
0afb4571
J
117192011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11720
11721 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11722 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11723 for ! HAVE_GTK3.
11724 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11725
11726 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11727
11728 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11729 gdk_window_get_screen, gdk_window_get_geometry,
11730 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11731 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11732 (xg_get_pixbuf_from_pixmap): New function.
11733 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11734 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11735 Call xg_get_pixbuf_from_pixmap instead of
11736 gdk_pixbuf_get_from_drawable.
11737 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11738 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11739 (xg_check_special_colors): Use GtkStyleContext and its functions
11740 for HAVE_GTK3.
11741 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11742 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11743 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11744 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11745 Call gtk_widget_get_preferred_size.
0afb4571
J
11746 (xg_frame_resized): gdk_window_get_geometry only takes 5
11747 parameters.
44f230aa
SM
11748 (xg_win_to_widget, xg_event_is_for_menubar):
11749 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11750 (xg_set_widget_bg): New function.
11751 (delete_cb): New function.
895009e1 11752 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11753 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11754 (xg_set_background_color): Call xg_set_widget_bg.
11755 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11756 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11757 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11758 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11759 if ! HAVE_GTK3.
11760 (update_frame_tool_bar): Call gtk_widget_hide.
11761 (xg_initialize): Use GDK_KEY_g.
11762
11763 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11764 if ! HAVE_GTK3
11765 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11766
11767 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11768 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11769 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11770
1c2cc4ef
JB
117712011-03-08 Juanma Barranquero <lekktu@gmail.com>
11772
11773 * w32xfns.c (select_palette): Check success of RealizePalette against
11774 GDI_ERROR, not zero.
11775
33383987 11776See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11777
11778;; Local Variables:
11779;; coding: utf-8
aac0c6e3
MR
11780;; End:
11781
2f097256 11782 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11783
11784 This file is part of GNU Emacs.
11785
11786 GNU Emacs is free software: you can redistribute it and/or modify
11787 it under the terms of the GNU General Public License as published by
11788 the Free Software Foundation, either version 3 of the License, or
11789 (at your option) any later version.
11790
11791 GNU Emacs is distributed in the hope that it will be useful,
11792 but WITHOUT ANY WARRANTY; without even the implied warranty of
11793 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11794 GNU General Public License for more details.
11795
11796 You should have received a copy of the GNU General Public License
11797 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.