* xdisp.c (display_mode_element): Don't assume strlen fits in int.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
51cab52b 12011-06-21 Paul Eggert <eggert@cs.ucla.edu>
882f0d81 2
4eab31dd
PE
3 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4 not unsigned long, as we prefer signed integers. All callers changed.
5 Detect integer overflow in repeat count.
6 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8
171e2a58
PE
9 * termcap.c: Don't assume sizes fit in int and never overflow.
10 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
11 (gobble_line): Check for size-calculation overflow.
12
ad39faca 13 * minibuf.c (Fread_buffer):
6e5bb2dc 14 * lread.c (intern, intern_c_string):
74ca2eb3
PE
15 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
16 Don't assume string length fits in int.
17
52c61c22 18 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
19 * gtkutil.c (style_changed_cb): Avoid need for strlen.
20
b5b8c9e5
PE
21 * font.c: Don't assume string length fits in int.
22 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
23 Use ptrdiff_t, not int.
ccd6111c
PE
24 (font_intern_prop): Don't assume string length fits in int.
25 Don't assume integer property fits in fixnum.
26 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 27
882f0d81 28 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 29 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
30 Reformulate so as not to need the command string.
31 Invoke gzip -cd rather than gunzip, as it's more portable.
32 (lock_info_type, lock_file_1, lock_file):
33 Don't assume pid_t and time_t fit in unsigned long.
34 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
35 (current_lock_owner): Prefer signed type for sizes.
36 Use memcpy, not strncpy, where memcpy is what is really wanted.
37 Don't assume (via atoi) that time_t and pid_t fit in int.
38 Check for time_t and/or pid_t out of range, e.g., via a network share.
39 Don't alloca where an auto var works fine.
40
93f4cf88
PE
41 * fileio.c: Fix some integer overflow issues.
42 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
43 Don't assume string length fits in int.
44 (directory_file_name): Don't assume string length fits in long.
45 (make_temp_name): Don't assume pid fits in int, or that its print
46 length is less than 20.
47
f3e92b69
PE
48 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
49
1bfdaf10
PE
50 * coding.c (make_subsidiaries): Don't assume string length fits in int.
51
35016e9a
PE
52 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
53
3d1e65a1
PE
54 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
55 We prefer signed integers, even for size calculations.
56
0b963a93
PE
57 * emacs.c: Don't assume string length fits in 'int'.
58 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
59 (main): Don't invoke strlen when not needed.
60
573f4b54
PE
61 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
62 (XD_DEBUG_MESSAGE): Don't waste a byte.
63
989f33ba
PE
64 * callproc.c (getenv_internal_1, getenv_internal)
65 (Fgetenv_internal):
965d34eb
PE
66 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
67
e4d29b33
PE
68 * lread.c (invalid_syntax): Omit length argument.
69 All uses changed. This doesn't fix a bug, but it simplifies the
70 code away from its former Hollerith-constant appearance, and it's
71 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 72 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 73
eb49b136
PE
74 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
75 This didn't break anything, but it didn't help either.
76 It's confusing to put a bogus integer in a place where the actual
77 value does not matter.
9f62aeb1 78 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 79 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 80
15375a22
PE
81 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
82 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
83 implementation.
b61cc01c
PE
84 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
85 We prefer signed types, and the value cannot exceed the EMACS_INT
86 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
87 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
88 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
89 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 90
53b2623d
PE
91 * indent.c (sane_tab_width): New function.
92 (current_column, scan_for_column, Findent_to, position_indentation)
93 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 94 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 95
51cab52b 96 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 97
f2ed8a70
PE
98 * lisp.h (lint_assume): New macro.
99 * composite.c (composition_gstring_put_cache):
100 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
101
abe80cc6
PE
102 * editfns.c, insdel.c:
103 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 104
b02c740e
PE
105 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
106
ebc96716
PE
107 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
108
b4e50fa0 109 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 110 Use much-faster test for byte-length change.
311d5d7c 111 Don't assume string byte-length fits in 'int'.
a4cf38e4 112 Check that character arg fits in 'int'.
85461888 113 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 114
c0c1ee9f
PE
115 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
116
a498d7f4
PE
117 * fns.c (concat): Catch string overflow earlier.
118 Do not rely on integer wraparound.
119
51cab52b
PE
120 * dispextern.h (struct it.overlay_strings_charpos)
121 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
122 * xdisp.c (forward_to_next_line_start)
123 (back_to_previous_visible_line_start)
124 (reseat_at_next_visible_line_start, next_element_from_buffer):
125 Don't arbitrarily truncate the value of 'selective' to int.
126
76031fad
PE
127 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
128
5eb55db9
PE
129 * composite.c: Don't truncate sizes to 'int'.
130 (composition_gstring_p, composition_reseat_it)
131 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
132 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
133 not EMACS_UINT, for indexes.
5eb55db9 134
0703a717
PE
135 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
136
d6202519
PE
137 * buffer.c: Include <verify.h>.
138 (struct sortvec.priority, struct sortstr.priority):
8961a454 139 Now EMACS_INT, not int.
c20998a7 140 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
141 (struct sortstr.size, record_overlay_string)
142 (struct sortstrlist.size, struct sortlist.used):
143 Don't truncate size to int.
144 (record_overlay_string): Check for size-calculation overflow.
d6202519 145 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 146
76147d94
DD
1472011-06-20 Deniz Dogan <deniz@dogan.se>
148
149 * process.c (Fset_process_buffer): Clarify return value in
150 docstring.
151
7d7d0045
CY
1522011-06-18 Chong Yidong <cyd@stupidchicken.com>
153
154 * dispnew.c (add_window_display_history): Use BVAR.
155
156 * xdisp.c (debug_method_add): Use BVAR.
157 (check_window_end, dump_glyph_matrix, dump_glyph)
158 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
159
160 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
161 Likewise.
162
163 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
164 check till after the cache is created in init_frame_faces.
165
ff2bc410
SM
1662011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
167
168 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
169
28177add
PE
1702011-06-16 Paul Eggert <eggert@cs.ucla.edu>
171
dd3482fe
PE
172 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
173 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
174 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
175
393d71f3 176 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
177 * fileio.c (Finsert_file_contents):
178 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
179 Remove the old (too-loose) buffer overflow checks.
180 They weren't needed, since make_gap checks for buffer overflow.
181 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
182 The old code merely checked for Emacs fixnum overflow, and relied
183 on undefined (wraparound) behavior. The new code avoids undefined
184 behavior, and also checks for ptrdiff_t and/or size_t overflow.
185
2e6813b0 186 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
187 Tune. Don't use wider integers than needed. Don't use alloca.
188 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 189
599a9e4f
PE
190 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
191
99561444
PE
192 * insdel.c, lisp.h (buffer_overflow): New function.
193 (insert_from_buffer_1, replace_range, replace_range_2):
194 * insdel.c (make_gap_larger):
195 * editfns.c (Finsert_char):
196 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
197
28177add
PE
198 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
199
e69dafad
PE
2002011-06-15 Paul Eggert <eggert@cs.ucla.edu>
201
a7af7fde 202 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 203
b1c46f02
PE
204 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
205 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
206
e69dafad
PE
207 * fileio.c: Don't assume EMACS_INT fits in off_t.
208 (emacs_lseek): New static function.
209 (Finsert_file_contents, Fwrite_region): Use it.
210 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
211
566684ea
PE
212 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
213
e6966cd6
PE
214 * fns.c: Don't overflow int when computing a list length.
215 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
216 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
217 truncation on 64-bit hosts. Check for QUIT every
218 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
219 faster and is responsive enough.
220 (Flength): Report an error instead of overflowing an integer.
221 (Fsafe_length): Return a float if the value is not representable
222 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 223 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 224 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 225
dd0b0efb
PE
226 * alloc.c: Check that resized vectors' lengths fit in fixnums.
227 (header_size, word_size): New constants.
228 (allocate_vectorlike): Don't check size overflow here.
229 (allocate_vector): Check it here instead, since this is the only
230 caller of allocate_vectorlike that could cause overflow.
231 Check that the new vector's length is representable as a fixnum.
232
86fe5cfe
PE
233 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
234 The previous code was bogus. For example, next_almost_prime (32)
235 returned 39, which is undesirable as it is a multiple of 3; and
236 next_almost_prime (24) returned 25, which is a multiple of 5 so
237 why was the code bothering to check for multiples of 7?
238
80e88859
PE
239 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
240
4a2f0ad6
PE
241 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
242
f66c7cf8
PE
243 Variadic C functions now count arguments with ptrdiff_t.
244 This partly undoes my 2011-03-30 change, which replaced int with size_t.
245 Back then I didn't know that the Emacs coding style prefers signed int.
246 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
247 were being counted with int, which may truncate counts on 64-bit
248 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
249 * lisp.h (struct Lisp_Subr.function.aMANY)
250 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
251 Arg counts are now ptrdiff_t, not size_t.
252 All variadic functions and their callers changed accordingly.
253 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
254 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
255 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
256 * callint.c (Fcall_interactively): Check arg count for overflow,
257 to avoid potential buffer overrun. Use signed char, not 'int',
258 for 'varies' array, so that we needn't bother to check its size
259 calculation for overflow.
260 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
261 * eval.c (apply_lambda):
262 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
263 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
264 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
265
a1759b76
PE
266 * callint.c (Fcall_interactively): Don't use index var as event count.
267
d96be9fc
PE
268 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
269 * mem-limits.h (SIZE): Remove; no longer used.
270
a690a978 271 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 272
578c21e6
PE
273 Remove unnecessary casts.
274 * xterm.c (x_term_init):
275 * xfns.c (x_set_border_pixel):
276 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
277 These aren't needed now that we assume ANSI C.
278
96f53c6c
PE
279 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
280 It's more likely to cause problems (due to unsigned overflow)
281 than to cure them.
282
83c77d31
PE
283 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
284
ee2079f1
PE
285 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
286
6da65536
PE
287 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
288
7147c4a4
PE
289 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
290
193e32d9
PE
291 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
292
e5533da6
PE
293 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
294
9910e595
PE
295 GLYPH_CODE_FACE returns EMACS_INT, not int.
296 * dispextern.h (merge_faces):
297 * xfaces.c (merge_faces):
01103c44
PE
298 * xdisp.c (get_next_display_element, next_element_from_display_vector):
299 Don't assume EMACS_INT fits in int.
9910e595 300
2638320e
PE
301 * character.h (CHAR_VALID_P): Remove unused parameter.
302 * fontset.c, lisp.h, xdisp.c: All uses changed.
303
045eb8d9
PE
304 * editfns.c (Ftranslate_region_internal): Omit redundant test.
305
c1f134b5
PE
306 * fns.c (concat): Minor tuning based on overflow analysis.
307 This doesn't fix any bugs. Use int to hold character, instead
308 of constantly refetching from Emacs object. Use XFASTINT, not
309 XINT, for value known to be a character. Don't bother comparing
310 a single byte to 0400, as it's always less.
311
395fcb93 312 * floatfns.c (Fexpt):
327eeec8
PE
313 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
314
abbd3d23
PE
315 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
316 for characters.
317
684a03ef
PE
318 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
319
0fed43f3
PE
320 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
321 Without this fix, on a 64-bit host (aset S 0 4294967386) would
322 incorrectly succeed when S was a string, because 4294967386 was
323 truncated before it was used.
324
8fd02eb7
PE
325 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
326 Otherwise, an out-of-range integer could cause undefined behavior
327 on a 64-bit host.
328
f8c86b69
PE
329 * composite.c: Use int, not EMACS_INT, for characters.
330 (fill_gstring_body, composition_compute_stop_pos): Use int, not
331 EMACS_INT, for values that are known to be in character range.
332 This doesn't fix any bugs but is the usual style inside Emacs and
333 may generate better code on 32-bit machines.
334
34206dd2
PE
335 Make sure a 64-bit char is never passed to ENCODE_CHAR.
336 This is for reasons similar to the recent CHAR_STRING fix.
337 * charset.c (Fencode_char): Check that character arg is actually
338 a character. Pass an int to ENCODE_CHAR.
339 * charset.h (ENCODE_CHAR): Verify that the character argument is no
340 wider than 'int', as a compile-time check to prevent future regressions
341 in this area.
342
c5958d4c 343 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
344
345 Make sure a 64-bit char is never passed to CHAR_STRING.
346 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
347 by silently ignoring the top 32 bits, allowing some values
348 that were far too large to be valid characters.
349 * character.h: Include <verify.h>.
350 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
351 arguments are no wider than unsigned, as a compile-time check
352 to prevent future regressions in this area.
353 * data.c (Faset):
01103c44 354 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
355 (Fsubst_char_in_region):
356 * fns.c (concat):
357 * xdisp.c (decode_mode_spec_coding):
358 Adjust to CHAR_STRING's new requirement.
359 * editfns.c (Finsert_char, Fsubst_char_in_region):
360 * fns.c (concat): Check that character args are actually
361 characters. Without this test, these functions did the wrong
362 thing with wildly out-of-range values on 64-bit hosts.
363
d37ca623
PE
364 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
365 These casts should not be needed on 32-bit hosts, either.
366 * keyboard.c (read_char):
367 * lread.c (Fload): Remove casts to unsigned.
368
ea204efb
PE
369 * lisp.h (UNSIGNED_CMP): New macro.
370 This fixes comparison bugs on 64-bit hosts.
371 (ASCII_CHAR_P): Use it.
372 * casefiddle.c (casify_object):
01103c44 373 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
374 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
375 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
376 * dispextern.h (FACE_FROM_ID):
377 * keyboard.c (read_char): Use UNSIGNED_CMP.
378
41cb286c
PE
379 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
380 not to EMACS_INT, to avoid GCC warning.
381
4a1b9832
PE
382 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
383
55daad71
PE
384 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
385 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
386 isn't needed on 32-bit machines.
8f95c75c 387
01103c44
PE
388 * buffer.c (Fgenerate_new_buffer_name):
389 Use EMACS_INT for count, not int.
0ceccced 390 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
391
392 * data.c (Qcompiled_function): Now static.
393
c6f072e7
PE
394 * window.c (window_body_lines): Now static.
395
20ce5912
PE
396 * image.c (gif_load): Rename local to avoid shadowing.
397
9c4c5f81
PE
398 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
399 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
400 * alloc.c (make_save_value): Integer argument is now of type
401 ptrdiff_t, not int.
402 (mark_object): Use ptrdiff_t, not int.
403 * lisp.h (pD): New macro.
404 * print.c (print_object): Use it.
405
c0c5c8ae
PE
406 * alloc.c: Use EMACS_INT, not int, to count objects.
407 (total_conses, total_markers, total_symbols, total_vector_size)
408 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
409 (total_free_floats, total_floats, total_free_intervals)
410 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
411 Now EMACS_INT, not int. All uses changed.
412 (Fgarbage_collect): Compute overall total using a double, so that
413 integer overflow is less likely to be a problem. Check for overflow
414 when converting back to an integer.
5a25e253
PE
415 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
416 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
417 These were 'int' variables that could overflow on 64-bit hosts;
418 they were never used, so remove them instead of repairing them.
211a0b2a 419 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
420 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
421 Previously, this ceilinged at INT_MAX, but that doesn't work on
422 64-bit machines.
e46bb31a 423 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 424
c78baabf 425 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 426 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
427 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
428 when a (possibly-narrower) signed value would do just as well.
429 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 430
c9d624c6
PE
431 * alloc.c: Catch some string size overflows that we were missing.
432 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
433 for convenience in STRING_BYTES_MAX.
434 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
435 The definition here is exact; the one in lisp.h was approximate.
436 (allocate_string_data): Check for string overflow. This catches
437 some instances we weren't catching before. Also, it catches
438 size_t overflow on (unusual) hosts where SIZE_MAX <= min
439 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
440 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 441
c9d624c6
PE
442 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
443 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
444 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
445
353032ce
PE
446 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
447
2bccce07
PE
448 * alloc.c (Fmake_string): Check for out-of-range init.
449
0ac30604
SM
4502011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
451
452 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
453
c195f2de
JD
4542011-06-14 Jan Djärv <jan.h.d@swipnet.se>
455
456 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
457 xg_get_default_scrollbar_width.
458
459 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
460 (int_gtk_range_get_value): Move to the scroll bar part of the file.
461 (style_changed_cb): Call update_theme_scrollbar_width and call
462 x_set_scroll_bar_default_width and xg_frame_set_char_size for
463 all frames (Bug#8505).
464 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
465 Call gtk_window_set_resizable if HAVE_GTK3.
466 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
467 and height if HAVE_GTK3 (Bug#8505).
468 (scroll_bar_width_for_theme): New variable.
469 (update_theme_scrollbar_width): New function.
470 (xg_get_default_scrollbar_width): Move code to
471 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
472 (xg_initialize): Call update_theme_scrollbar_width.
473
474 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
475
476 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
477
e10ac9f1
MR
4782011-06-12 Martin Rudalics <rudalics@gmx.at>
479
480 * frame.c (make_frame): Call other_buffer_safely instead of
481 other_buffer.
482
483 * window.c (temp_output_buffer_show): Call display_buffer with
484 second argument Vtemp_buffer_show_specifiers and reset latter
485 immediately after the call.
486 (Vtemp_buffer_show_specifiers): New variable.
487 (auto_window_vscroll_p, next_screen_context_lines)
488 (Vscroll_preserve_screen_position): Remove leading asterisks from
489 doc-strings.
490
2d3c217e 4912011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 492
7b7f97e8 493 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
494 * buffer.c (Qclone_number): Remove for now, as it's unused.
495 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
496 (record_buffer): Remove unused local.
497 * frame.c (other_visible_frames, frame_buffer_list): Now static.
498 (set_frame_buffer_list): Remove; unused.
499 * frame.h (other_visible_frames): Remove decl.
500 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
501 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
502 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
503 if HAVE_GPM.
504 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
505 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
506 Define only if HAVE_GPM.
507 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
508 (update_hints_inhibit): Remove; never set. All uses removed.
509 * widgetprv.h (emacsFrameClassRec): Remove decl.
510 * window.c (delete_deletable_window): Now returns void, since it
511 wasn't returning anything.
512 (compare_window_configurations): Remove unused locals.
513 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
514 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
515 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
516 the same widths as pointers. This follows up on the 2011-05-06 patch.
517 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
518 * xterm.h: Likewise.
519 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
520
1384b89e
JB
5212011-06-12 Juanma Barranquero <lekktu@gmail.com>
522
523 * makefile.w32-in: Update dependencies.
524 (LISP_H): Add lib/intprops.h.
525
1100a63c
CY
5262011-06-11 Chong Yidong <cyd@stupidchicken.com>
527
528 * image.c (gif_load): Add animation frame delay to the metadata.
529 (syms_of_image): Use DEFSYM. New symbol `delay'.
530
6198ccd0
MR
5312011-06-11 Martin Rudalics <rudalics@gmx.at>
532
533 * window.c (delete_deletable_window): Re-add.
534 (Fset_window_configuration): Rewrite to handle dead buffers and
535 consequently deletable windows.
536 (window_tree, Fwindow_tree): Remove. Supply functionality in
537 window.el.
538 (compare_window_configurations): Simplify code.
539
b6e3633c
AS
5402011-06-11 Andreas Schwab <schwab@linux-m68k.org>
541
1ab0dee5
AS
542 * image.c (imagemagick_load_image): Fix type mismatch.
543 (Fimagemagick_types): Likewise.
544
b6e3633c
AS
545 * window.h (replace_buffer_in_windows): Declare.
546
9397e56f
MR
5472011-06-11 Martin Rudalics <rudalics@gmx.at>
548
549 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
550 Qclone_number. Remove external declaration of Qdelete_window.
551 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
552 code.
553 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
554 Qbuffer_list_update_hook if allowed.
555 (Fother_buffer): Rewrite doc-string. Major rewrite for new
556 buffer list implementation.
557 (other_buffer_safely): New function.
558 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
559 calls to replace_buffer_in_windows and
560 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
561 if allowed.
562 (record_buffer): Inhibit quitting and rewrite using quittable
563 functions. Run Qbuffer_list_update_hook if allowed.
564 (Frecord_buffer, Funrecord_buffer): New functions.
565 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
566 switch-to-buffer to window.el.
567 (bury-buffer): Move to window.el.
568 (Vbuffer_list_update_hook): New variable.
569
570 * lisp.h (other_buffer_safely): Add prototype in buffer.c
571 section.
572
573 * window.h (resize_frame_windows): Move up in code.
574 (Fwindow_frame): Remove EXFUN.
575 (replace_buffer_in_all_windows): Remove prototype.
576 (replace_buffer_in_windows_safely): Add prototype.
577
578 * window.c: Declare Qdelete_window static again. Move down
579 declaration of select_count.
580 (Fnext_window, Fprevious_window): Rewrite doc-strings.
581 (Fother_window): Move to window.el.
582 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
583 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
584 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
585 window.el.
586 (replace_buffer_in_windows): Implement by calling
587 Qreplace_buffer_in_windows.
588 (replace_buffer_in_all_windows): Remove with some functionality
589 moved into replace_buffer_in_windows_safely.
590 (replace_buffer_in_windows_safely): New function.
591 (select_window_norecord, select_frame_norecord): Move in front
592 of run_window_configuration_change_hook. Remove now obsolete
593 declarations.
594 (Fset_window_buffer): Rewrite doc-string. Call
595 Qrecord_window_buffer.
596 (keys_of_window): Move binding for other-window to window.el.
597
b50691aa
CY
5982011-06-11 Chong Yidong <cyd@stupidchicken.com>
599
600 * dispextern.h (struct image): Replace data member, whose int_val
601 and ptr_val fields were not used by anything, with a single
602 lisp_val object.
603
604 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
605 (gif_clear_image, gif_load, imagemagick_load_image)
606 (gs_clear_image, gs_load): Callers changed.
607
3f754b86
PE
6082011-06-10 Paul Eggert <eggert@cs.ucla.edu>
609
cca69397
PE
610 * buffer.h: Include <time.h>, for time_t.
611 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
612
109e28d0
PE
613 Fix minor problems found by static checking.
614
60737f02
PE
615 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
616
4b66faf3
PE
617 Make identifiers static if they are not used in other modules.
618 * data.c (Qcompiled_function, Qframe, Qvector):
619 * image.c (QimageMagick, Qsvg):
620 * minibuf.c (Qmetadata):
621 * window.c (resize_window_check, resize_root_window): Now static.
622 * window.h (resize_window_check, resize_root_window): Remove decls.
623
109e28d0
PE
624 * window.c (window_deletion_count, delete_deletable_window):
625 Remove; unused.
46a4ce9e
PE
626 (window_body_lines): Now static.
627 (Fdelete_other_windows_internal): Mark vars as initialized.
628 Make sure 'resize_failed' is initialized.
629 (run_window_configuration_change_hook): Rename local to avoid shadowing.
630 (resize_window_apply): Remove unused local.
631 * window.h (delete_deletable_window): Remove decl.
632
109e28d0 633 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
634 (imagemagick_load_image): Fix pointer signedness problem by changing
635 last arg from unsigned char * to char *. All uses changed.
636 Also, fix a local for similar reasons.
637 Remove unused locals. Remove locals to avoid shadowing.
638 (fn_rsvg_handle_free): Remove; unused.
639 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 640 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 641
3f754b86
PE
642 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
643
2547adb1
CY
6442011-06-10 Chong Yidong <cyd@stupidchicken.com>
645
646 * image.c (gif_load): Fix omitted cast error introduced by
647 2011-06-06 change.
648
2c8e37d4
MR
6492011-06-10 Martin Rudalics <rudalics@gmx.at>
650
651 * window.h (resize_proportionally, orig_total_lines)
652 (orig_top_line): Remove from window structure.
653 (set_window_height, set_window_width, change_window_heights)
654 (Fdelete_window): Remove prototypes.
655 (resize_frame_windows): Remove duplicate declaration.
656
440a42e3
EZ
6572011-06-10 Eli Zaretskii <eliz@gnu.org>
658
659 * window.h (resize_frame_windows, resize_window_check)
660 (delete_deletable_window, resize_root_window)
661 (resize_frame_windows): Declare prototypes.
662
663 * window.c (resize_window_apply): Make definition be "static" to
664 match the prototype.
665
562dd5e9
MR
6662011-06-10 Martin Rudalics <rudalics@gmx.at>
667
668 * window.c: Remove declarations of Qwindow_size_fixed,
669 window_min_size_1, window_min_size_2, window_min_size,
670 size_window, window_fixed_size_p, enlarge_window, delete_window.
671 Remove static from declaration of Qdelete_window, it's
672 temporarily needed by Fbury_buffer.
673 (replace_window): Don't assign orig_top_line and
674 orig_total_lines.
675 (Fdelete_window, delete_window): Remove. Window deletion is
676 handled by window.el.
677 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
678 Fdelete_window calls with calls to Qdelete_window.
679 (Fdelete_other_windows): Remove. Deleting other windows is
680 handled by window.el.
681 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
682 handled in window.el.
683 (window_min_size_2, window_min_size_1, window_min_size): Remove.
684 Window minimum sizes are handled in window.el.
685 (shrink_windows, size_window, set_window_height)
686 (set_window_width, change_window_heights, window_height)
687 (window_width, CURBEG, CURSIZE, enlarge_window)
688 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
689 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
690 handled in window.el.
691 (make_dummy_parent): Rename to make_parent_window and give it a
692 second argument horflag.
693 (make_window): Don't set resize_proportionally any more.
694 (Fsplit_window): Remove. Windows are split in window.el.
695 (save_restore_action, save_restore_orig_size)
696 (shrink_window_lowest_first, save_restore_orig_size): Remove.
697 Resize mini windows in window.el.
698 (grow_mini_window, shrink_mini_window): Implement by calling
699 Qresize_root_window_vertically, resize_window_check and
700 resize_window_apply.
701 (saved_window, Fset_window_configuration, save_window_save): Do
702 not handle orig_top_line, orig_total_lines, and
703 resize_proportionally.
704 (window_min_height, window_min_width): Move to window.el.
705 (keys_of_window): Move bindings for delete-other-windows,
706 split-window, delete-window and enlarge-window to window.el.
707
708 * buffer.c: Temporarily extern Qdelete_window.
709 (Fbury_buffer): Temporarily call Qdelete_window instead of
710 Fdelete_window (Fbury_buffer will move to window.el soon).
711
712 * frame.c (set_menu_bar_lines_1): Remove code handling
713 orig_top_line and orig_total_lines.
714
715 * dispnew.c (adjust_frame_glyphs_initially): Don't use
716 set_window_height but set heights directly.
717 (change_frame_size_1): Use resize_frame_windows.
718
719 * xdisp.c (init_xdisp): Don't use set_window_height but set
720 heights directly.
721
722 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
723 resize_frame_windows instead of change_window_heights and run
724 run_window_configuration_change_hook.
725
726 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
727 instead of change_window_heights and run
728 run_window_configuration_change_hook.
729
1a13852e
MR
7302011-06-09 Martin Rudalics <rudalics@gmx.at>
731
732 * window.c (replace_window): Rename second argument REPLACEMENT to
733 NEW. New third argument SETFLAG. Rewrite.
734 (delete_window, make_dummy_parent): Call replace_window with
735 third argument 1.
736 (window_list_1): Move down in code.
737 (run_window_configuration_change_hook): Move set_buffer part
738 before select_frame_norecord part in order to unwind correctly.
739 Rename count1 to count.
740 (recombine_windows, delete_deletable_window, resize_root_window)
741 (Fdelete_other_windows_internal)
742 (Frun_window_configuration_change_hook, make_parent_window)
743 (resize_window_check, resize_window_apply, Fresize_window_apply)
744 (resize_frame_windows, Fsplit_window_internal)
745 (Fdelete_window_internal, Fresize_mini_window_internal): New
746 functions.
747 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
748
f3d1777e
MR
7492011-06-08 Martin Rudalics <rudalics@gmx.at>
750
496e208e
MR
751 * window.h (window): Add some new members to window structure -
752 normal_lines, normal_cols, new_total, new_normal, clone_number,
753 splits, nest, prev_buffers, next_buffers.
754 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 755 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 756
f3d1777e
MR
757 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
758 Remove.
496e208e
MR
759 (make_dummy_parent): Set new members of windows structure.
760 (make_window): Move down in code. Handle new members of window
761 structure.
762 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
763 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
764 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
765 (Fset_window_prev_buffers, Fwindow_next_buffers)
766 (Fset_window_next_buffers, Fset_window_clone_number): New
767 functions.
768 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
769 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
770 Doc-string fixes.
771 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
772 Argument WINDOW can be now internal window too.
773 (Fwindow_use_time): Move up in code.
774 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
775 Rewrite doc-string.
776 (Fset_window_configuration, saved_window)
777 (Fcurrent_window_configuration, save_window_save): Handle new
778 members of window structure.
b9e809c2
MR
779 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
780 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
781 (syms_of_window): New Lisp objects Qrecord_window_buffer,
782 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
783 Qget_mru_window, Qresize_root_window,
784 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
785 Qauto_buffer_name; staticpro them.
f3d1777e 786
abde8f8c
MR
7872011-06-07 Martin Rudalics <rudalics@gmx.at>
788
789 * window.c (Fwindow_total_size, Fwindow_left_column)
790 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
791 (Fwindow_list_1): New functions.
792 (window_box_text_cols): Replace with window_body_cols.
793 (Fwindow_width, Fscroll_left, Fscroll_right): Use
794 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
795 (delete_window, Fset_window_configuration): Call
796 delete_all_subwindows with window as argument.
797 (delete_all_subwindows): Take a window as argument and not a
798 structure. Rewrite.
190b47e6
MR
799 (window_loop): Remove handling of GET_LRU_WINDOW and
800 GET_LARGEST_WINDOW.
801 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
802
803 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
804 window_box_text_cols. delete_all_subwindows now takes a
805 Lisp_Object as argument.
abde8f8c
MR
806
807 * indent.c (compute_motion, Fcompute_motion): Use
808 window_body_cols instead of window_box_text_cols.
809
fa8a67e6
MR
810 * frame.c (delete_frame): Call delete_all_subwindows with root
811 window as argument.
812
a54e3482
DC
8132011-06-07 Daniel Colascione <dan.colascione@gmail.com>
814
815 * fns.c (Fputhash): Document return value.
816
60002bf5
CY
8172011-06-06 Chong Yidong <cyd@stupidchicken.com>
818
819 * image.c (gif_load): Implement gif89a spec "no disposal" method.
820
0c671da6 8212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 822
b862a52a 823 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 824
be44ca6c
PE
825 Check for overflow when converting integer to cons and back.
826 * charset.c (Fdefine_charset_internal, Fdecode_char):
827 Use cons_to_unsigned to catch overflow.
828 (Fencode_char): Use INTEGER_TO_CONS.
829 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
830 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
831 * data.c (long_to_cons, cons_to_long): Remove.
832 (cons_to_unsigned, cons_to_signed): New functions.
833 These signal an error for invalid or out-of-range values.
834 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
835 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
836 * font.c (Ffont_variation_glyphs):
837 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
838 * lisp.h: Include <intprops.h>.
839 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
840 (cons_to_signed, cons_to_unsigned): New decls.
841 (long_to_cons, cons_to_long): Remove decls.
842 * undo.c (record_first_change): Use INTEGER_TO_CONS.
843 (Fprimitive_undo): Use CONS_TO_INTEGER.
844 * xfns.c (Fx_window_property): Likewise.
845 * xselect.c: Include <limits.h>.
846 (x_own_selection, selection_data_to_lisp_data):
847 Use INTEGER_TO_CONS.
848 (x_handle_selection_request, x_handle_selection_clear)
849 (x_get_foreign_selection, Fx_disown_selection_internal)
850 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
851 (lisp_data_to_selection_data): Use cons_to_unsigned.
852 (x_fill_property_data): Use cons_to_signed.
853 Report values out of range.
854
d1f3d2af
PE
855 Check for buffer and string overflow more precisely.
856 * buffer.h (BUF_BYTES_MAX): New macro.
857 * lisp.h (STRING_BYTES_MAX): New macro.
858 * alloc.c (Fmake_string):
859 * character.c (string_escape_byte8):
860 * coding.c (coding_alloc_by_realloc):
861 * doprnt.c (doprnt):
862 * editfns.c (Fformat):
863 * eval.c (verror):
864 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
865 since they may not be the same number.
866 * editfns.c (Finsert_char):
867 * fileio.c (Finsert_file_contents):
868 Likewise for BUF_BYTES_MAX.
869
dd52fcea
PE
870 * image.c: Use ptrdiff_t, not int, for sizes.
871 (slurp_file): Switch from int to ptrdiff_t.
872 All uses changed.
873 (slurp_file): Check that file size fits in both size_t (for
874 malloc) and ptrdiff_t (for sanity and safety).
875
7f9bbdbb
PE
876 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
877 if b->modtime has its maximal value.
878
dfe18f82
PE
879 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
880
84acfcf0
PE
881 Don't assume time_t can fit into int.
882 * buffer.h (struct buffer.modtime): Now time_t, not int.
883 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
884 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
885
ccd9a01a
PE
886 Minor fixes for signed vs unsigned integers.
887 * character.h (MAYBE_UNIFY_CHAR):
888 * charset.c (maybe_unify_char):
889 * keyboard.c (read_char, reorder_modifiers):
890 XINT -> XFASTINT, since the integer must be nonnegative.
891 * ftfont.c (ftfont_spec_pattern):
892 * keymap.c (access_keymap, silly_event_symbol_error):
893 XUINT -> XFASTINT, since the integer must be nonnegative.
894 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
895 since it makes no difference and we prefer signed.
896 * keyboard.c (record_char): Use XUINT when all the neighbors do.
897 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
898 nonnegative.
899
d6d100dd
SM
9002011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
901
902 * window.h (Fwindow_frame): Declare.
903
2b6148e4
PE
9042011-06-06 Paul Eggert <eggert@cs.ucla.edu>
905
906 * alloc.c: Simplify handling of large-request failures (Bug#8800).
907 (SPARE_MEMORY): Always define.
908 (LARGE_REQUEST): Remove.
909 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
910
f230ecc9
MR
9112011-06-06 Martin Rudalics <rudalics@gmx.at>
912
727e958e
MR
913 * lisp.h: Move EXFUNS for Fframe_root_window,
914 Fframe_first_window and Fset_frame_selected_window to window.h.
915
916 * window.h: Move EXFUNS for Fframe_root_window,
917 Fframe_first_window and Fset_frame_selected_window here from
918 lisp.h.
919
920 * frame.c (Fwindow_frame, Fframe_first_window)
921 (Fframe_root_window, Fframe_selected_window)
922 (Fset_frame_selected_window): Move to window.c.
923 (Factive_minibuffer_window): Move to minibuf.c.
924 (Fother_visible_frames_p): New function.
925
926 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
927
f230ecc9
MR
928 * window.c (decode_window, decode_any_window): Move up in code.
929 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
930 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
931 (Fwindow_buffer): Move up and rewrite doc-string.
932 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
933 (Fwindow_prev): New functions.
727e958e
MR
934 (Fwindow_frame): Move here from frame.c. Accept any window as
935 argument.
936 (Fframe_root_window, Fframe_first_window)
937 (Fframe_selected_window): Move here from frame.c. Accept frame
938 or arbitrary window as argument. Update doc-strings.
939 (Fminibuffer_window): Move up in code.
940 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
941 (Fset_frame_selected_window): Move here from frame.c.
942 Marginal rewrite.
727e958e
MR
943 (Fselected_window, select_window, Fselect_window): Move up in
944 code. Minor doc-string fixes.
f230ecc9 945
4d09bcf6
PE
9462011-06-06 Paul Eggert <eggert@cs.ucla.edu>
947
948 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
949 Do not assume that spare memory exists; that assumption is valid
950 only if SYSTEM_MALLOC.
951 (LARGE_REQUEST): New macro, so that the issue of large requests
952 is separated from the issue of spare memory.
953
810928a2
AS
9542011-06-05 Andreas Schwab <schwab@linux-m68k.org>
955
172418ad
AS
956 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
957 format. (Bug#8806)
958
43f862f7
AS
959 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
960
810928a2
AS
961 * xfns.c (x_set_scroll_bar_default_width): Move declarations
962 before statements.
963
a059fe24
JD
9642011-06-05 Jan Djärv <jan.h.d@swipnet.se>
965
966 * gtkutil.c (xg_get_default_scrollbar_width): New function.
967
968 * gtkutil.h: Declare xg_get_default_scrollbar_width.
969
970 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
971 min width by calling x_set_scroll_bar_default_width (Bug#8505).
972
989bf368
JB
9732011-06-05 Juanma Barranquero <lekktu@gmail.com>
974
975 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
976
4b80f674
CY
9772011-06-04 Chong Yidong <cyd@stupidchicken.com>
978
979 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
980 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
981 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
982 New error handlers.
4b80f674
CY
983 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
984 Obey Vx_select_enable_clipboard_manager. Catch errors in
985 x_clipboard_manager_save (Bug#8779).
986 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 987 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 988
99a33b77 9892011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
990
991 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
992
99a33b77 9932011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
994
995 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
996 in the current matrix if keep_current_p is non-zero.
997
8264569d
EZ
9982011-06-04 Eli Zaretskii <eliz@gnu.org>
999
1000 * bidi.c (bidi_level_of_next_char): Fix last change.
1001
57f97249
EZ
10022011-06-03 Eli Zaretskii <eliz@gnu.org>
1003
fec2107c 1004 Support bidi reordering of text covered by display properties.
57f97249 1005
fec2107c
EZ
1006 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1007 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1008 (bidi_cache_search, bidi_cache_iterator_state)
1009 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1010 (bidi_level_of_next_char, bidi_move_to_visually_next):
1011 Support character positions inside a run of characters covered by a
fec2107c
EZ
1012 display string.
1013 (bidi_paragraph_init, bidi_resolve_explicit_1)
1014 (bidi_level_of_next_char): Call bidi_fetch_char and
1015 bidi_fetch_char_advance instead of FETCH_CHAR and
1016 FETCH_CHAR_ADVANCE.
1017 (bidi_init_it): Initialize new members.
1018 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1019 definitions.
1020 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1021 instead of using explicit *_CHAR codes.
d6d100dd
SM
1022 (bidi_resolve_explicit, bidi_resolve_weak):
1023 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1024 bidirectional text is supported only in multibyte buffers.
1025 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1026 it to initialize the frame_window_p member of struct bidi_it.
1027 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1028 (bidi_resolve_explicit, bidi_resolve_weak)
1029 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1030 bidi_it->nchars is non-positive.
1031 (bidi_level_of_next_char): Don't try to lookup the cache for the
1032 next/previous character if nothing is cached there yet, or if we
1033 were just reseat()'ed to a new position.
c40e2fb2 1034
0e14fe90
EZ
1035 * xdisp.c (set_cursor_from_row): Set start and stop points
1036 according to the row's direction when priming the loop that looks
1037 for the glyph on which to display cursor.
1038 (single_display_spec_intangible_p): Function deleted.
1039 (display_prop_intangible_p): Reimplement to call
1040 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1041 Accept 3 additional arguments needed by handle_display_spec.
1042 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1043 values: lists, `(when COND...)' forms, etc.
1044 (single_display_spec_string_p): Support property values that are
1045 lists with the argument STRING its top-level element.
1046 (display_prop_string_p): Fix the condition for processing a
1047 property that is a list to be consistent with handle_display_spec.
fec2107c 1048 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1049 last portion of handle_display_prop.
1050 (compute_display_string_pos): Accept additional argument
1051 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1052 value of a `display' property is a "replacing spec".
1053 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1054 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1055 the display property, but just return a value indicating whether
1056 the display property will replace the characters it covers.
1057 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1058 frame_window_p members of struct bidi_it.
d6d100dd
SM
1059 (compute_display_string_pos, compute_display_string_end):
1060 New functions.
fec2107c
EZ
1061 (push_it): Accept second argument POSITION, where pop_it should
1062 jump to continue iteration.
1063 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1064
fec2107c
EZ
1065 * keyboard.c (adjust_point_for_property): Adjust the call to
1066 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1067
1068 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1069 (bidi_init_it): Update prototypes.
1070 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1071 (compute_display_string_pos, compute_display_string_end):
1072 Declare prototypes.
fec2107c
EZ
1073 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1074 EMACS_INT.
fc6f18ce 1075
40087514 10762011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1077
57f53182
PE
1078 Malloc failure behavior now depends on size of allocation.
1079 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1080 * lisp.h: Change signatures accordingly.
1081 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1082 All callers changed. (Bug#8762)
1083
1084 * gnutls.c: Use Emacs's memory allocators.
1085 Without this change, the gnutls library would invoke malloc etc.
1086 directly, which causes problems on non-SYNC_INPUT hosts, and which
1087 runs afoul of improving memory_full behavior. (Bug#8761)
1088 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1089 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1090 xfree instead of the default malloc, realloc, free.
1091 (Fgnutls_boot): No need to check for memory allocation failure,
1092 since xmalloc does that for us.
1093
ac32cd99 1094 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1095 * category.c (hash_get_category_set):
1096 * ccl.c (ccl_driver):
1097 * charset.c (Fdefine_charset_internal):
1098 * charset.h (struct charset.hash_index):
1099 * composite.c (get_composition_id, gstring_lookup_cache)
1100 (composition_gstring_put_cache):
1101 * composite.h (struct composition.hash_index):
1102 * dispextern.h (struct image.hash):
1103 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1104 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1105 (hashfn_equal, hashfn_user_defined, make_hash_table)
1106 (maybe_resize_hash_table, hash_lookup, hash_put)
1107 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1108 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1109 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1110 * image.c (make_image, search_image_cache, lookup_image)
1111 (xpm_put_color_table_h):
1112 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1113 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1114 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1115 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1116 * alloc.c (allocate_vectorlike):
1117 Check for overflow in vector size calculations.
1118 * ccl.c (ccl_driver):
1119 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1120 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1121 need to be updated by these changes.
40087514
PE
1122 * fns.c (make_hash_table, maybe_resize_hash_table):
1123 Check for integer overflow with large hash tables.
0de4bb68
PE
1124 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1125 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1126 (SXHASH_REDUCE): New macro.
1127 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1128 Use it instead of discarding useful hash info with large hash values.
1129 (sxhash_float): New function.
1130 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1131 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1132 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1133 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1134 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1135 Adjust signatures to match updated version of code.
1136 (consing_since_gc): Now EMACS_INT, since a single hash table can
1137 use more than INT_MAX bytes.
1138
698d32e2
DN
11392011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1140
1141 Make it possible to build with GCC-4.6+ -O2 -flto.
1142
1143 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1144
fd6fa53f
SM
11452011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1146
1147 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1148 Call minibuffer-inactive-mode.
1149
864db017
JB
11502011-05-31 Juanma Barranquero <lekktu@gmail.com>
1151
1152 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1153 Update dependencies.
1154
2ad0baf4
DN
11552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1156
1157 * data.c (init_data): Remove code for UTS, this system is not
1158 supported anymore.
1159
4fcc2638
DN
11602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1161
1162 Don't force ./temacs to start in terminal mode.
1163
1164 * frame.c (make_initial_frame): Initialize faces in all cases, not
1165 only when CANNOT_DUMP is defined.
1166 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1167
c56e0fd5
DN
11682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1169
1170 * dispnew.c (add_window_display_history): Use const for the string
1171 pointer. Remove declaration, not needed.
1172
333d54da 11732011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1174
55d4c1b2 1175 Use 'inline', not 'INLINE'.
333d54da 1176 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1177 * alloc.c, fontset.c (INLINE): Remove.
1178 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1179 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1180 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1181 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1182 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1183
738db178
DN
11842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1185
1186 Make it possible to run ./temacs.
1187
1188 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1189 syms_of_callproc does the same thing. Remove test for
1190 "initialized", do it in the caller.
1191 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1192
620c53a6
SM
11932011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1194
1195 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1196 (read_minibuf): Use get_minibuffer.
1197 (syms_of_minibuf): Use DEFSYM.
1198 (Qmetadata): New var.
1199 * data.c (Qbuffer): Don't make it static.
1200 (syms_of_data): Use DEFSYM.
1201
e003a292
PE
12022011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1205 (CCL_CODE_MIN): New macro.
1206
ed008a6d
PE
12072011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1208
3687c2ef
PE
1209 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1210
ed008a6d
PE
1211 * eval.c (Qdebug): Now static.
1212 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1213 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1214 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1215
d66c4c7c
CY
12162011-05-29 Chong Yidong <cyd@stupidchicken.com>
1217
1218 * image.c: Various fixes to ImageMagick code comments.
1219 (Fimagemagick_types): Doc fix.
1220
5fbc2025
PE
12212011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1222
0196f88a
PE
1223 Minor fixes prompted by GCC 4.6.0 warnings.
1224
1225 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1226
5fbc2025
PE
1227 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1228 (x_clipboard_manager_save_all): Move extern decl to ...
1229 * xterm.h: ... here, so that it can be checked for consistency.
1230
1dd3c2d9
CY
12312011-05-29 Chong Yidong <cyd@stupidchicken.com>
1232
1233 * xselect.c (x_clipboard_manager_save_frame)
1234 (x_clipboard_manager_save_all): New functions.
1235 (Fx_clipboard_manager_save): Lisp function deleted.
1236
1237 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1238 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1239
1240 * xterm.h: Update prototype.
1241
5ba6571d
WX
12422011-05-28 William Xu <william.xwl@gmail.com>
1243
1244 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1245 exiting (Bug#8239).
1246
3eaff834
JM
12472011-05-28 Jim Meyering <meyering@redhat.com>
1248
e1900994 1249 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1250 * fns.c (to_uchar): Define.
1251 (crypto_hash_function): Use it to convert some newly-signed
1252 variables to unsigned, to avoid sign-extension bugs. For example,
1253 without this change, (md5 "truc") would evaluate to
1254 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1255 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1256 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1257
0f6990a7
PE
12582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1259
1260 Integer overflow fixes.
c8a9ca5a 1261
08686060
PE
1262 * dbusbind.c: Serial number integer overflow fixes.
1263 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1264 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1265 to hold a serial number that is too large for a fixnum.
1266 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1267 Check for serial numbers out of range. Decode any serial number
59568bf0 1268 that was so large that it became a float. (Bug#8722)
08686060 1269
2d1fc3c7
PE
1270 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1271 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1272 Use XFASTINT rather than XUINT when numbers are nonnegative.
1273 (xd_append_arg, Fdbus_method_return_internal):
1274 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1275 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1276 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1277 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1278 (Bug#8722)
2d1fc3c7 1279
c8a9ca5a
PE
1280 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1281
519e1d69
PE
1282 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1283
30569699
PE
1284 ccl: add integer overflow checks
1285 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1286 (IN_INT_RANGE): New macros.
1287 (ccl_driver): Use them to check for integer overflow when
1288 decoding a CCL program. Many of the new checks are whether XINT (x)
1289 fits in int; it doesn't always, on 64-bit hosts. The new version
1290 doesn't catch all possible integer overflows, but it's an
847044ea 1291 improvement. (Bug#8719)
30569699 1292
c11285dc
PE
1293 * alloc.c (make_event_array): Use XINT, not XUINT.
1294 There's no need for unsigned here.
1295
fdccd48e
PE
1296 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1297 This follows up to the 2011-05-06 change that substituted uintptr_t
1298 for EMACS_INT. This case wasn't caught back then.
1299
37910ab2
PE
1300 Rework Fformat to avoid integer overflow issues.
1301 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1302 now (part of C89). Include <verify.h>.
1303 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1304 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1305 (Fformat): Avoid the prepass trying to compute sizes; it was only
1306 approximate and thus did not catch overflow reliably. Instead, walk
1307 through the format just once, formatting and computing sizes as we go,
1308 checking for integer overflow at every step, and allocating a larger
1309 buffer as needed. Keep track separately whether the format is
1310 multibyte. Keep only the most-recently calculated precision, rather
1311 than them all. Record whether each argument has been converted to
1312 string. Use EMACS_INT, not int, for byte and char and arg counts.
1313 Support field widths and precisions larger than INT_MAX. Avoid
1314 sprintf's undefined behavior with conversion specifications such as %#d
1315 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1316 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1317 formatting out-of-range floating point numbers with int
1318 formats. (Bug#8668)
1319
2e6578fb
PE
1320 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1321
0ae6bdee
PE
1322 * data.c: Avoid integer truncation in expressions involving floats.
1323 * data.c: Include <intprops.h>.
1324 (arith_driver): When there's an integer overflow in an expression
1325 involving floating point, convert the integers to floating point
1326 so that the resulting value does not suffer from catastrophic
1327 integer truncation. For example, on a 64-bit host (* 4
1328 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1329 Do not rely on undefined behavior after integer overflow.
1330
de883a70
PE
1331 merge count_size_as_multibyte, parse_str_to_multibyte
1332 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1333 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1334 Check for integer overflow.
1335 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1336 since it's now a duplicate of the other. This is more of
1337 a character than a buffer op, so better that it's in character.c.
1338 * fns.c, print.c: Adjust to above changes.
1339
2ff916cb
PE
13402011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1341
1342 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1343
f1b54466
PE
13442011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1345
fb1ac845
PE
1346 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1347 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1348 (x_clipboard_manager_save): Now static.
1349 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1350
f1b54466
PE
1351 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1352 (crypto_hash_function): Now static.
1353 Fix pointer signedness problems. Avoid unnecessary initializations.
1354
a9f737ee
CY
13552011-05-27 Chong Yidong <cyd@stupidchicken.com>
1356
1357 * termhooks.h (Vselection_alist): Make it terminal-local.
1358
1359 * terminal.c (create_terminal): Initialize it.
1360
1361 * xselect.c: Support for clipboard managers.
1362 (Vselection_alist): Move to termhooks.h as terminal-local var.
1363 (LOCAL_SELECTION): New macro.
1364 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1365 (symbol_to_x_atom): Remove gratuitous arg.
1366 (x_handle_selection_request, lisp_data_to_selection_data)
1367 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1368 (x_own_selection, x_get_local_selection, x_convert_selection):
1369 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1370 (some_frame_on_display): Delete unused function.
1371 (Fx_own_selection_internal, Fx_get_selection_internal)
1372 (Fx_disown_selection_internal, Fx_selection_owner_p)
1373 (Fx_selection_exists_p): New optional frame arg.
1374 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1375 (x_handle_selection_clear): Don't treat other terminals with the
1376 same keyboard specially. Use the terminal-local Vselection_alist.
1377 (x_clear_frame_selections): Use Frun_hook_with_args.
1378
1379 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1380
1381 * xterm.h: Add support for those atoms.
1382
e067f0c1
CY
13832011-05-26 Chong Yidong <cyd@stupidchicken.com>
1384
1385 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1386 (converted_selections, conversion_fail_tag): New global variables.
1387 (x_selection_request_lisp_error): Free the above.
1388 (x_get_local_selection): Remove unnecessary code.
1389 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1390 of converted selections stored in converted_selections.
1391 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1392 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1393 (x_convert_selection): New function.
1394 (x_handle_selection_event): Simplify.
1395 (x_get_foreign_selection): Don't ignore incoming requests while
1396 waiting for an answer; this will fail when we implement
1397 SAVE_TARGETS, and seems unnecessary anyway.
1398 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1399 (Vx_sent_selection_functions): Doc fix.
1400
0f4aebc0
LL
14012011-05-26 Leo Liu <sdl.web@gmail.com>
1402
1403 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1404
e61124cd
YM
14052011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1406
1407 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1408
1409 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1410 for fringe update if it has periodic bitmap.
1411 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1412 and fringe_bitmap_periodic_p.
1413
1414 * fringe.c (get_fringe_bitmap_data): New function.
1415 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1416 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1417 row. Mark glyph row for fringe update if periodicity changed.
1418
1419 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1420 for fringe update unless it has periodic bitmap.
1421
f16d9837
KH
14222011-05-25 Kenichi Handa <handa@m17n.org>
1423
1424 * xdisp.c (get_next_display_element): Set correct it->face_id for
1425 a static composition.
1426
e1b90ef6
LL
14272011-05-24 Leo Liu <sdl.web@gmail.com>
1428
1429 * deps.mk (fns.o):
1430 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1431
1432 * fns.c (crypto_hash_function, Fsha1): New function.
1433 (Fmd5): Use crypto_hash_function.
1434 (syms_of_fns): Add Ssha1.
1435
7400048f
PE
14362011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1437
1438 * gnutls.c: Remove unused macros.
1439 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1440 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1441 Remove macros that are defined and never used.
1442 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1443
abb71cf4
CY
14442011-05-22 Chong Yidong <cyd@stupidchicken.com>
1445
1446 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1447 (Fx_get_selection_internal): Minor cleanup.
1448 (Fx_own_selection_internal): Rename arguments for consistency with
1449 select.el.
1450
6307db39
PE
14512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1452
1453 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1454
f3d4e0a4
CY
14552011-05-22 Chong Yidong <cyd@stupidchicken.com>
1456
1457 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1458
4d8ade89
YM
14592011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1460
1461 * dispnew.c (scrolling_window): Don't exclude the case that the
1462 last enabled row in the desired matrix touches the bottom boundary.
1463
32078c8d
GM
14642011-05-21 Glenn Morris <rgm@gnu.org>
1465
1466 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1467 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1468 and add some more files.
32078c8d 1469
7285dc67
EZ
14702011-05-20 Eli Zaretskii <eliz@gnu.org>
1471
1472 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1473 report_file_error introduced by the change from 2011-05-07.
1474
89d1bd22
PE
14752011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1476
1477 * systime.h (Time): Define only if emacs is defined.
1478 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1479 where the include path doesn't have X11/X.h by default. See
1480 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1481
e23640bb 14822011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1483
1484 * composite.c (find_automatic_composition): Fix previous change.
1485
b9704ad9
GM
14862011-05-20 Glenn Morris <rgm@gnu.org>
1487
1488 * lisp.mk: New file, split from Makefile.in.
1489 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1490 (shortlisp): Remove.
1491 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1492
4a720484
GM
14932011-05-19 Glenn Morris <rgm@gnu.org>
1494
1495 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1496 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1497 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1498 (lisp): Set the order to that of loadup.el.
1499 (shortlisp): Make it a copy of $lisp.
1500 (SOME_MACHINE_LISP): Remove.
1501 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1502 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1503
a28d4396
KH
15042011-05-18 Kenichi Handa <handa@m17n.org>
1505
1506 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1507 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1508 (find_automatic_composition): Mostly rewrite for efficiency.
1509
a2b1fa8e
JB
15102011-05-18 Juanma Barranquero <lekktu@gmail.com>
1511
1512 * makefile.w32-in: Update dependencies.
1513
8e1f5610
CS
15142011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1515
1516 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1517 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1518
7025ee00 15192011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1520
cdfa6eab
PE
1521 Fix some integer overflow issues, such as string length overflow.
1522
06d6db33
PE
1523 * insdel.c (count_size_as_multibyte): Check for string overflow.
1524
2b4560a8
PE
1525 * character.c (lisp_string_width): Check for string overflow.
1526 Use EMACS_INT, not int, for string indexes and lengths; in
1527 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1528 the resulting string length overflows an EMACS_INT; instead,
1529 report a string overflow if no precision given. When checking for
1530 precision exhaustion, use a check that cannot possibly have
1531 integer overflow. (Bug#8675)
1532 * character.h (lisp_string_width): Adjust to new signature.
1533
cb93f9be
PE
1534 * alloc.c (string_overflow): New function.
1535 (Fmake_string): Use it. This doesn't change behavior, but saves
1536 a few bytes and will simplify future changes.
1537 * character.c (string_escape_byte8): Likewise.
1538 * lisp.h (string_overflow): New decl.
1539
1a1f3366
PE
1540 Fixups, following up to the user-interface timestamp change.
1541 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1542 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1543 * msdos.c (mouse_get_pos): Likewise.
1544 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1545 * w32gui.h (Time): Define by including "systime.h" rather than by
1546 declaring it ourselves. (Bug#8664)
1547
d4e3e4d3
PE
1548 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1549 * image.c (clear_image_cache): Likewise.
1550
f6a24d19
PE
1551 * term.c (term_mouse_position): Don't assume time_t wraparound.
1552
08dc5ae6
PE
1553 Be more systematic about user-interface timestamps.
1554 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1555 and sometimes 'EMACS_UINT', to represent these timestamps.
1556 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1557 This makes the code easier to follow, and makes it easier to catch
1558 integer overflow bugs such as Bug#8664.
1559 * frame.c (Fmouse_position, Fmouse_pixel_position):
1560 Use Time, not unsigned long, for user-interface timestamps.
1561 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1562 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1563 * keyboard.h (last_event_timestamp): Likewise.
1564 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1565 * menu.h (xmenu_show): Likewise.
1566 * term.c (term_mouse_position): Likewise.
1567 * termhooks.h (struct input_event.timestamp): Likewise.
1568 (struct terminal.mouse_position_hook): Likewise.
1569 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1570 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1571 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1572 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1573 what it was before.
1574 * menu.h, termhooks.h: Include "systime.h", for Time.
1575
8e55734a
PE
1576 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1577 Don't assume that the difference between two unsigned long values
1578 can fit into an integer. At this point, we know button_down_time
1579 <= event->timestamp, so the difference must be nonnegative, so
1580 there's no need to cast the result if double-click-time is
1581 nonnegative, as it should be; check that it's nonnegative, just in
1582 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1583 apart (about 25 days). (Bug#8664)
8e55734a 1584
841f1b75 1585 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1586 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1587
3e26f69c
PE
1588 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1589 that always fit in int. Use a sentinel instead of a counter, to
1590 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1591 * frame.h (struct frame): Use int for menu_bar_items_used
1592 instead of EMACS_INT, since it always fits in int.
3e26f69c 1593
5cc152c0
PE
1594 * menu.c (grow_menu_items): Check for int overflow.
1595
d89eb65e
PE
1596 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1597
5235bd3e
PE
1598 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1599 Before, the code was not consistent. These values cannot exceed
1600 2**31 - 1 so there's no need to make them unsigned.
1601 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1602 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1603 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1604 as modifiers.
1605 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1606
bc827e23
PE
1607 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1608 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1609 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1610 presumably because the widths might not match.
1611
78eb494e
PE
1612 * window.c (size_window): Avoid needless test at loop start.
1613
04f2d78b
CB
16142011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1615
1616 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1617
d2fc7e3d 16182011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1619
1620 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1621
d2fc7e3d 16222011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1623
1624 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1625 `width' to `bar_area_x' and `bar_area_width', respectively.
1626 (x_scroll_run): Take account of fringe background extension.
1627
04f2d78b
CB
1628 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1629 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1630 `bar_area_width', respectively.
1631 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1632 background extension.
1633
79b70037
GM
16342011-05-10 Jim Meyering <meyering@redhat.com>
1635
1636 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1637
2f142cc5
JB
16382011-05-10 Juanma Barranquero <lekktu@gmail.com>
1639
1640 * image.c (Finit_image_library): Return t for built-in image types,
1641 like pbm and xbm. (Bug#8640)
1642
57679c86
AS
16432011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1644
1645 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1646
888c9e86
EZ
16472011-05-07 Eli Zaretskii <eliz@gnu.org>
1648
b0512a1d
EZ
1649 * w32console.c (Fset_screen_color): Doc fix.
1650 (Fget_screen_color): New function.
1651 (syms_of_ntterm): Defsubr it.
1652
7285dc67
EZ
1653 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1654 unlink the temporary file if Fcall_process didn't create it in the
1655 first place.
1656 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1657 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1658 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1659 cue to call_process_cleanup not to close that handle.
1660
4d3fcc8e
BK
16612011-05-07 Ben Key <bkey76@gmail.com>
1662
1663 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1664 one of two shell specific rules, either bootstrap-temacs-CMD or
1665 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1666 to the previous implementation of the bootstrap-temacs rule.
1667 The bootstrap-temacs-CMD rule is similar to the previous
1668 implementation of the bootstrap-temacs rule except that it
1669 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1670 variable.
1671
1672 These changes, along with some changes to nt/configure.bat,
1673 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1674 earlier fix to add support for --cflags and --ldflags options
1675 that include quotes so that it works whether make uses cmd or
1676 sh as the shell.
1677
b4289b64
MA
16782011-05-06 Michael Albinus <michael.albinus@gmx.de>
1679
1680 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1681 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1682 is a constant.
1683 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1684 a string. Handle both cases.
1685 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1686 (Fdbus_register_method): Use Qinvalid_function.
1687
af4c0e28
JB
16882011-05-06 Juanma Barranquero <lekktu@gmail.com>
1689
1690 * makefile.w32-in: Update dependencies.
1691 (LISP_H): Add inttypes.h and stdin.h.
1692 (PROCESS_H): Add unistd.h.
1693
c51453d9
EZ
16942011-05-06 Eli Zaretskii <eliz@gnu.org>
1695
1696 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1697 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1698
8ff0ac3c 16992011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1700
4c4b566b
PE
1701 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1702
aab2b9b5
PE
1703 * term.c (vfatal): Remove stray call to va_end.
1704 It's not needed and the C Standard doesn't allow it here anyway.
1705
c378da0b
PE
1706 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1707 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1708
288b08c7
PE
1709 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1710 bytes.
1711
e3601888
PE
1712 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1713
db6c0e74
PE
1714 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1715
dd5963ea
PE
1716 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1717
88c9450f
PE
1718 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1719
2f9442b8
PE
1720 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1721
c032b5f8
PE
1722 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1723 * charset.c (Fdefine_charset_internal): Don't initialize
1724 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1725 32-bit int (Bug#8600).
a108c10b
PE
1726
1727 * lread.c (read_integer): Be more consistent with string-to-number.
1728 Use string_to_number to do the actual conversion; this avoids
1729 rounding errors and fixes some other screwups. Without this fix,
1730 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1731 (digit_to_number): Move earlier, for benefit of read_integer.
1732 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1733 not a digit in any supported base. (Bug#8602)
a108c10b 1734
ad5f9eea
PE
1735 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1736
aec1708a
PE
1737 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1738 to match comment at start of function. This also removes a
1739 GCC warning about overflow in a 32+64-bit port.
1740
47be4ab5
PE
1741 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1742
371cac43
PE
1743 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1744 Reported by Stefan Monnier in
1745 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1746 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1747 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1748
d01a7826
PE
1749 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1750 (EMACS_UINTPTR): Likewise, with uintptr_t.
1751
7fd47d5c
PE
1752 * lisp.h: Prefer 64-bit EMACS_INT if available.
1753 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1754 on 32-bit hosts that have 64-bit int, so that they can access
1755 large files.
122b0c86
PE
1756 However, temporarily disable this change unless the temporary
1757 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1758
8727937b
PE
1759 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1760
8ac068ac
PE
1761 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1762 This removes an assumption that EMACS_INT and long are the same
1763 width as pointers. The assumption is true for Emacs porting targets
1764 now, but we want to make other targets possible.
1765 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1766 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1767 In the rest of the code, change types of integers that hold casted
1768 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1769 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1770 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1771 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1772 No need to cast type when ORing.
1773 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1774 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1775 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1776 assume EMACS_INT is the same width as char *.
1777 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1778 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1779 Remove no-longer-needed casts.
1780 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1781 (xg_tool_bar_help_callback, xg_make_tool_item):
1782 Use EMACS_INTPTR to hold an integer
1783 that will be cast to void *; this can avoid a GCC warning
1784 if EMACS_INT is not the same width as void *.
1785 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1786 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1787 (current_message_1, set_message_1):
1788 Use a local to convert to proper width without a cast.
1789 * xmenu.c (dialog_selection_callback): Likewise.
1790
ede49d71
PE
1791 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1792 Also, don't assume VALBITS / RAND_BITS is less than 5,
1793 and don't rely on undefined behavior when shifting a 1 left into
1794 the sign bit.
1795 * lisp.h (get_random): Change signature to match.
1796
2f30ecd0
PE
1797 * lread.c (hash_string): Use size_t, not int, for hash computation.
1798 Normally we prefer signed values; but hashing is special, because
1799 it's better to use unsigned division on hash table sizes so that
1800 the remainder is nonnegative. Also, size_t is the natural width
1801 for hashing into memory. The previous code used 'int', which doesn't
1802 retain enough info to hash well into very large tables.
1803 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1804
2a866e7b
PE
1805 * dbusbind.c: Don't possibly lose pointer info when converting.
1806 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1807 Use XPNTR rather than XHASH, so that the high-order bits of
1808 the pointer aren't lost when converting through void *.
1809
51639eac
PE
1810 * eval.c (Fautoload): Don't double-shift a pointer.
1811
92394119
PE
1812 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1813
dbdb9a7c
JB
18142011-05-06 Juanma Barranquero <lekktu@gmail.com>
1815
1816 * gnutls.c (DEF_GNUTLS_FN):
1817 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1818
db7a0b4f
AS
18192011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1820
1821 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1822 marker. (Bug#8610)
1823
f7ff1b0f 18242011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1825
1826 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1827 New version that can reserve upto 2GB of heap space.
1828
f7ff1b0f 18292011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1830
1831 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1832
639c109b
TZ
18332011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1834
1835 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1836 `gnutls_certificate_set_x509_key_file'.
1837
d2127135
JB
18382011-05-05 Juanma Barranquero <lekktu@gmail.com>
1839
1840 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1841 Update dependencies.
1842
e968f4f3
JB
18432011-05-04 Juanma Barranquero <lekktu@gmail.com>
1844
1845 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1846 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1847 Remove unused parameter `fildes'.
1848 * process.c (read_process_output, send_process): Don't pass it.
1849
84d358f0
JB
18502011-05-04 Juanma Barranquero <lekktu@gmail.com>
1851
1852 Fix previous change: the library cache is defined in w32.c.
1853 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1854 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1855
0898ca10
JB
18562011-05-04 Juanma Barranquero <lekktu@gmail.com>
1857
1858 Implement dynamic loading of GnuTLS on Windows.
1859
1860 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1861 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1862 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1863 Declare.
1864
1865 * gnutls.c (Qgnutls_dll): Define.
1866 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1867 (gnutls_*): Declare function pointers.
1868 (init_gnutls_functions): New function to initialize function pointers.
1869 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1870 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1871 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1872 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1873 (emacs_gnutls_write, emacs_gnutls_read)
1874 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1875 (Fgnutls_available_p): New function.
1876 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1877 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1878 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1879
1880 * image.c: Include w32.h.
1881 (Vimage_type_cache): Delete.
1882 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1883 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1884 (w32_delayed_load): Move to w32.c.
1885
1886 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1887
1888 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1889 (w32_delayed_load): Move from image.c. When loading a library, record
1890 its filename in the :loaded-from property of the library id.
1891 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1892 Initialize and staticpro them.
1893 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1894
1895 * process.c: Include lisp.h before w32.h, not after.
1896 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1897 instead of gnutls_record_check_pending.
1898
1899 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1900
ff4de4aa
TZ
19012011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1902
1903 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1904 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1905 as passed in.
1906
abe95abb
JD
19072011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1908
1909 * xterm.c (x_set_frame_alpha): Do not set property on anything
1910 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1911
e16e55d4
JB
19122011-05-02 Juanma Barranquero <lekktu@gmail.com>
1913
1914 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1915
bafcf6a5
JB
19162011-05-02 Juanma Barranquero <lekktu@gmail.com>
1917
1918 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1919 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1920 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1921 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1922 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1923 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1924 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1925 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1926 (Qgnutls_bootprop_callbacks_verify): Make static.
1927
e7a6747f
AS
19282011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1929
19ed11ba
AS
1930 * callproc.c: Indentation fixup.
1931
e7a6747f 1932 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1933 (wait_for_termination, interruptible_wait_for_termination):
1934 Move after wait_for_termination_1.
e7a6747f 1935
1ef14cb4
LMI
19362011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1937
1938 * sysdep.c (interruptible_wait_for_termination): New function
1939 which is like wait_for_termination, but allows keyboard
1940 interruptions.
1941
1942 * callproc.c (Fcall_process): Add (:file "file") as an option for
1943 the STDOUT buffer.
1944 (Fcall_process_region): Ditto.
1945
330d880c
EZ
19462011-04-30 Eli Zaretskii <eliz@gnu.org>
1947
8db90b73
EZ
1948 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1949 rather than `XVECTOR (FOO)->size'.
1950
330d880c
EZ
1951 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1952 inttypes.h, as a gnulib replacement is used if it not available in
1953 system headers.
1954
15cbd324
EZ
19552011-04-21 Eli Zaretskii <eliz@gnu.org>
1956
1957 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1958 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1959 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1960
1961 * coding.c (coding_alloc_by_realloc): Error out if destination
1962 will grow beyond MOST_POSITIVE_FIXNUM.
1963 (decode_coding_emacs_mule): Abort if there isn't enough place in
1964 charbuf for the composition carryover bytes. Reserve an extra
1965 space for up to 2 characters produced in a loop.
1966 (decode_coding_iso_2022): Abort if there isn't enough place in
1967 charbuf for the composition carryover bytes.
1968
19692011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1970
ae940cca
EZ
1971 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1972 aborting when %lld or %lll format is passed.
1973 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1974 %llo or %llx format is passed. (Bug#8545)
1975
03ab8921
EZ
1976 * window.c (window_scroll_line_based): Use a marker instead of
1977 simple variables to record original value of point. (Bug#7952)
1978
afda1437
EZ
1979 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1980 produced by %s or %c overflows available buffer space. (Bug#8545)
1981
f76dee0c
PE
19822011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1983
1984 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1985 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1986
fdc5744d
JB
19872011-04-28 Juanma Barranquero <lekktu@gmail.com>
1988
1989 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1990
638f053a
JB
19912011-04-28 Juanma Barranquero <lekktu@gmail.com>
1992
1993 * keyboard.c (Qdelayed_warnings_hook): Define.
1994 (command_loop_1): Run `delayed-warnings-hook'
1995 if Vdelayed_warnings_list is non-nil.
1996 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1997 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1998
d178f871
EZ
19992011-04-28 Eli Zaretskii <eliz@gnu.org>
2000
2001 * doprnt.c (doprnt): Don't return value smaller than the buffer
2002 size if the message was truncated. (Bug#8545).
2003
b124fd93
JB
20042011-04-28 Juanma Barranquero <lekktu@gmail.com>
2005
2006 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2007 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2008
e810457d
PE
20092011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2010
2011 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2012
ea51cceb
JB
20132011-04-27 Juanma Barranquero <lekktu@gmail.com>
2014
2015 * makefile.w32-in: Update dependencies.
2016
94dcfacf
EZ
20172011-04-27 Eli Zaretskii <eliz@gnu.org>
2018
2019 Improve `doprnt' and its usage. (Bug#8545)
2020 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2021 `format_end'. Remove support for %l as a conversion specifier.
2022 Don't use xrealloc. Improve diagnostics when the %l size modifier
2023 is used. Update the commentary.
2024
2025 * eval.c (verror): Simplify calculation of size_t.
2026
2027 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2028 messages.
2029
f61f41d7
PE
20302011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2031
2032 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2033 change.
2034
96fb4434
PE
20352011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2036
2037 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2038 This makes this file independent of the recent pseudovector change.
2039
671875da 20402011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2041
69e9b5a3
PE
2042 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2043
b5f869a7 2044 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2045 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2046 Remove unused local.
c8926152 2047 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2048
841a1577 2049 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2050 GCC 4.6.0 optimizes based on type-based alias analysis.
2051 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2052 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2053 != &v->size, and therefore "v->size = 1; b->size = 2; return
2054 v->size;" must therefore return 1. This assumption is incorrect
2055 for Emacs, since it type-puns struct Lisp_Vector * with many other
2056 types. To fix this problem, this patch adds a new type struct
f904488f 2057 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2058 and pseudovectors, and helps optimizing compilers not get fooled
2059 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2060 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2061 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2062 the size member.
eab3844f
PE
2063 (XSETPVECTYPE): Rewrite in terms of new macro.
2064 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2065 This is a bit clearer, and further avoids the possibility of
2066 undesirable aliasing.
2067 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2068 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2069 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2070 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2071 (ASIZE): Now uses header.size rather than size.
2072 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2073 to avoid the hassle of writing XVECTOR (foo)->header.size.
2074 (struct vectorlike_header): New type.
eab3844f
PE
2075 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2076 object, to help avoid aliasing.
2077 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2078 (SUBRP): Likewise, since Lisp_Subr is a special case.
2079 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2080 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2081 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2082 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2083 changed to be "header.size" and "header.next".
2084 * buffer.h (struct buffer): Likewise.
2085 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2086 * frame.h (struct frame): Likewise.
2087 * process.h (struct Lisp_Process): Likewise.
2088 * termhooks.h (struct terminal): Likewise.
2089 * window.c (struct save_window_data, struct saved_window): Likewise.
2090 * window.h (struct window): Likewise.
2091 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2092 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2093 * buffer.c (init_buffer_once): Likewise.
2094 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2095 special case.
2096 * process.c (Fformat_network_address): Use local var for size,
2097 for brevity.
2098
0df1eac5
PE
2099 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2100
847ab9d1 2101 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2102 * data.c (atof): Remove decl; no longer used or needed.
2103 (digit_to_number): Move to lread.c.
2104 (Fstring_to_number): Use new string_to_number function, to be
2105 consistent with how the Lisp reader treats infinities and NaNs.
2106 Do not assume that floating-point numbers represent EMACS_INT
2107 without losing information; this is not true on most 64-bit hosts.
2108 Avoid double-rounding errors, by insisting on integers when
2109 parsing non-base-10 numbers, as the documentation specifies.
2110 * lisp.h (string_to_number): New decl, replacing ...
2111 (isfloat_string): Remove.
bc0a5c13 2112 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2113 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2114 appears to have been a coding error. Similarly, do not accept
2115 strings like +-1e0 as floating point numbers. Do not report
2116 overflow for integer overflows unless the base is not 10 which
2117 means we have no simple and reliable way to continue.
2118 Break out the floating-point parsing into a new
2119 function string_to_number, so that Fstring_to_number parses
2120 floating point numbers consistently with the Lisp reader.
04f2d78b 2121 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2122 (E_CHAR, EXP_INT): Remove, replacing with ...
2123 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2124 (string_to_number): New function, replacing isfloat_string.
2125 This function checks for valid syntax and produces the resulting
2126 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2127 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2128 so that overflow for non-base-10 numbers is reported only when
2129 there's no portable and simple way to convert to floating point.
452f4150 2130
67769ffc
PE
2131 * textprop.c (set_text_properties_1): Rewrite for clarity,
2132 and to avoid GCC warning about integer overflow.
2133
c20db43f
PE
2134 * intervals.h (struct interval): Use EMACS_INT for members
2135 where EMACS_UINT might cause problems. See
2136 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2137 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2138 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2139 All uses changed.
37aa2f85
PE
2140 (offset_intervals): Tell GCC not to worry about length overflow
2141 when negating a negative length.
c20db43f 2142
2538aa2f
PE
2143 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2144 (overrun_check_free): Likewise.
2145
f2d3008d
PE
2146 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2147 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2148 word size.
2149
ec8df744
PE
2150 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2151 (gnutls_make_error): Rename local to avoid shadowing.
2152 (gnutls_emacs_global_deinit): ifdef out; not used.
2153 (Fgnutls_boot): Use const for pointer to readonly storage.
2154 Comment out unused local. Fix pointer signedness problems.
2155
640ee02d
PE
2156 * lread.c (openp): Don't stuff size_t into an 'int'.
2157 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2158 about possible signed overflow.
2159
6048fb2a
PE
2160 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2161 (GDK_KEY_g): Don't define if already defined.
2162 (xg_prepare_tooltip): Avoid pointer signedness problem.
2163 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2164
fa3c87e1
PE
2165 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2166 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2167
2172544b
PE
2168 * xfns.c (Fx_window_property): Simplify a bit,
2169 to make a bit faster and to avoid GCC 4.6.0 warning.
2170 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2171
9b821a21
PE
2172 * fns.c (internal_equal): Don't assume size_t fits in int.
2173
3c616cfa
PE
2174 * alloc.c (compact_small_strings): Tighten assertion a little.
2175
c2982e87
PE
2176 Replace pEd with more-general pI, and fix some printf arg casts.
2177 * lisp.h (pI): New macro, generalizing old pEd macro to other
2178 conversion specifiers. For example, use "...%"pI"d..." rather
2179 than "...%"pEd"...".
2180 (pEd): Remove. All uses replaced with similar uses of pI.
2181 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2182 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2183 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2184 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2185 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2186 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2187 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2188 64-bit hosts.
2189 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2190 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2191 * print.c (safe_debug_print, print_object): Likewise.
2192 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2193 to int.
6f04d126
PE
2194 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2195 avoiding the 0 flag, which is not portable.
c2982e87
PE
2196 * process.c (Fmake_network_process): Use pI to avoid cast.
2197 * region-cache.c (pp_cache): Likewise.
2198 * xdisp.c (decode_mode_spec): Likewise.
2199 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2200 behavior on 64-bit hosts with printf arg.
6f04d126 2201 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2202 (x_stop_queuing_selection_requests): Likewise.
2203 (x_get_window_property): Don't truncate byte count to an 'int'
2204 when tracing.
0b432f21 2205
5e073ec7
PE
2206 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2207 here, since it parses constructs like leading '-' and spaces,
2208 which are not wanted; and it overflows with large numbers.
2209 Instead, simply match F[0-9]+, which is what is wanted anyway.
2210
36372bf9
PE
2211 * alloc.c: Remove unportable assumptions about struct layout.
2212 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2213 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2214 (allocate_vectorlike, make_pure_vector): Use the new macros,
2215 plus offsetof, to remove unportable assumptions about struct layout.
2216 These assumptions hold on all porting targets that I know of, but
2217 they are not guaranteed, they're easy to remove, and removing them
2218 makes further changes easier.
2219
0b432f21
PE
2220 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2221 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2222 (string_overrun_cookie): Now const. Use initializers that
2223 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2224 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2225 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2226 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2227 multiple of sizeof (EMACS_INT); it need not be, if
2228 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2229 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2230
895009e1
JB
22312011-04-26 Juanma Barranquero <lekktu@gmail.com>
2232
2233 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2234
6a7a1b0b
TZ
22352011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2236
2237 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2238 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2239 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2240
841a1577 22412011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2242
2243 * lisp.h (Qdebug): List symbol.
895009e1 2244 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2245 * keyboard.c (debug-on-event): New variable.
2246 (handle_user_signal): Break into debugger when debug-on-event
2247 matches the current signal symbol.
2248
f2d3ba6f
DN
22492011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2250
2251 * alloc.c (check_sblock, check_string_bytes)
2252 (check_string_free_list): Convert to standard C.
2253
42ce4c63
TZ
22542011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2255
2256 * w32.c (emacs_gnutls_push): Fix typo.
2257
825cd63c
EZ
22582011-04-25 Eli Zaretskii <eliz@gnu.org>
2259
fb11d64d
EZ
2260 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2261 "cast to pointer from integer of different size".
2262
825cd63c
EZ
2263 Improve doprnt and its use in verror. (Bug#8545)
2264 * doprnt.c (doprnt): Document the set of format control sequences
2265 supported by the function. Use SAFE_ALLOCA instead of always
2266 using `alloca'.
2267
2268 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2269 is one byte too soon. Don't use xrealloc; instead xfree and
2270 xmalloc anew.
2271
e061a11b
TZ
22722011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2273
2274 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2275 callbacks stage.
2276
2277 * gnutls.c: Renamed global_initialized to
2278 gnutls_global_initialized. Added internals for the
2279 :verify-hostname-error, :verify-error, and :verify-flags
2280 parameters of `gnutls-boot' and documented those parameters in the
2281 docstring. Start callback support.
2282 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2283 unless a fatal error occured. Call gnutls_alert_send_appropriate
2284 on error. Return error code.
2285 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2286 (emacs_gnutls_read): Likewise.
2287 (Fgnutls_boot): Return handshake error code.
2288 (emacs_gnutls_handle_error): New function.
2289 (wsaerror_to_errno): Likewise.
2290
2291 * w32.h (emacs_gnutls_pull): Add prototype.
2292 (emacs_gnutls_push): Likewise.
2293
2294 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2295 (emacs_gnutls_push): Likewise.
2296
22972011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2298
2299 * process.c (wait_reading_process_output): Check if GnuTLS
2300 buffered some data internally if no FDs are set for TLS
2301 connections.
2302
2303 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2304 (LIBS): Link to USER_LIBS.
2305 ($(BLD)/gnutls.$(0)): New target.
2306
fa6996bc
EZ
23072011-04-24 Eli Zaretskii <eliz@gnu.org>
2308
eb35682e
EZ
2309 * xdisp.c (handle_single_display_spec): Rename the
2310 display_replaced_before_p argument into display_replaced_p, to
2311 make it consistent with the commentary. Fix typos in the
2312 commentary.
2313
e2ad650c
EZ
2314 * textprop.c (syms_of_textprop): Remove dead code.
2315 (copy_text_properties): Delete obsolete commentary about an
2316 interface that was deleted long ago. Fix typos in the description
2317 of arguments.
2318
1b2de274
EZ
2319 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2320 to changes in oldXMenu/XMenu.h from 2011-04-16.
2321 <menu_help_message, prev_menu_help_message>: Constify.
2322 (IT_menu_make_room): menu->help_text is now `const char **';
2323 adjust.
2324
2325 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2326 to changes in oldXMenu/XMenu.h from 2011-04-16.
2327 (struct XMenu): Declare `help_text' `const char **'.
2328
2329 * xfaces.c <Qunspecified>: Make extern again.
2330
2331 * syntax.c: Include sys/types.h before including regex.h, as
2332 required by Posix.
2333
762b15be
EZ
2334 * doc.c (get_doc_string): Improve the format passed to `error'.
2335
2336 * doprnt.c (doprnt): Improve commentary.
2337
2338 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2339
2340 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2341 them with etags.
2342
f1052e5d
EZ
2343 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2344 changes in globals.h immediately force recompilation.
762b15be
EZ
2345 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2346 $(CURDIR)/s/ms-w32.h.
2347 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2348
fa6996bc
EZ
2349 * character.c (Fchar_direction): Function deleted.
2350 (syms_of_character): Don't defsubr it.
2351 <char-direction-table>: Deleted.
2352
e6c3da20
EZ
23532011-04-23 Eli Zaretskii <eliz@gnu.org>
2354
2355 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2356 * doprnt.c: Include limits.h.
2357 (SIZE_MAX): New macro.
04f2d78b
CB
2358 (doprnt): Return a size_t value. 2nd arg is now size_t.
2359 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2360 Improve overflow protection. Support `l' modifier for integer
2361 conversions. Support %l conversion. Don't assume an EMACS_INT
2362 argument for integer conversions and for %c.
2363
2364 * lisp.h (doprnt): Restore prototype.
2365
2366 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2367 $(SRC)/character.h.
2368
2369 * Makefile.in (base_obj): Add back doprnt.o.
2370
2371 * deps.mk (doprnt.o): Add back prerequisites.
2372 (callint.o): Depend on character.h.
2373
2374 * eval.c (internal_lisp_condition_case): Include the handler
2375 representation in the error message.
2376 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2377 when breaking from the loop.
2378
2379 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2380
2381 * callint.c (Fcall_interactively): When displaying error message
2382 about invalid control letter, pass the character's codepoint, not
2383 a pointer to its multibyte form. Improve display of the character
2384 in octal and display also its hex code.
2385
2386 * character.c (char_string): Use %x to display the (unsigned)
2387 codepoint of an invalid character, to avoid displaying a bogus
2388 negative value.
2389
2390 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2391 `error', not SYMBOL_NAME itself.
2392
2393 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2394 character arguments to `error'.
2395
2396 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2397 to `error' in error message about FINAL_CHAR argument. Make sure
2398 FINAL_CHAR is a character, and use %c when it is passed as
2399 argument to `error'.
2400
4ffd0d6b 24012011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2402
2403 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2404
2405 * w32.c: Include <time.h>.
2406 (sys_localtime): New function.
2407
4ffd0d6b 24082011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2409
2410 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2411
4ffd0d6b 2412 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2413
4ffd0d6b 24142011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2415
4ffd0d6b
GM
2416 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2417 zombies (Bug#8467).
aac0c6e3 2418
04c56954
EZ
24192011-04-19 Eli Zaretskii <eliz@gnu.org>
2420
2421 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2422 gl_state.e_property when gl_state.object is Qt.
2423
2424 * insdel.c (make_gap_larger): Remove limitation of buffer size
2425 to <= INT_MAX.
2426
16a43933
CY
24272011-04-18 Chong Yidong <cyd@stupidchicken.com>
2428
2429 * xdisp.c (lookup_glyphless_char_display)
2430 (produce_glyphless_glyph): Handle cons cell entry in
2431 glyphless-char-display.
2432 (Vglyphless_char_display): Document it.
2433
2434 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2435 glyphless-char-display.
2436
4581706e
CY
24372011-04-17 Chong Yidong <cyd@stupidchicken.com>
2438
2439 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2440
2441 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2442
2443 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2444 definition for no-X builds.
2445
4887c6e2 24462011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2447
fd35b6f9
PE
2448 Static checks with GCC 4.6.0 and non-default toolkits.
2449
5c1ccb01
PE
2450 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2451
006c5daa
PE
2452 * process.c (keyboard_bit_set): Define only if SIGIO.
2453 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2454 (send_process): Repair possible setjmp clobbering.
2455
efc736d3
PE
2456 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2457
4e2fe2e6
PE
2458 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2459
f97334a2
PE
2460 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2461
4e75f29d
PE
2462 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2463 Define only if needed.
2464
90efadd1
PE
2465 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2466 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2467 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2468
3c647824
PE
2469 * dispextern.h (struct redisplay_interface): Rename param
2470 to avoid shadowing.
e264f262 2471 * termhooks.h (struct terminal): Likewise.
761383f4 2472 * xterm.c (xembed_send_message): Likewise.
3c647824 2473
b58c5c4a
PE
2474 * insdel.c (make_gap_smaller): Define only if
2475 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2476
cad59032
PE
2477 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2478 it.
2479
c339dc2e
PE
2480 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2481 so that we aren't warned about unused symbols.
2482
91a3e27b
PE
2483 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2484
399c71d3 2485 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2486
8ffc96f5
PE
2487 * xfns.c (x_real_positions): Mark locals as initialized.
2488
eef9bc79
PE
2489 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2490
098db9dd
PE
2491 * xterm.c: Fix problems found by static analysis with other toolkits.
2492 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2493 (x_dispatch_event): Declare static if USE_GTK, and
2494 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2495 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2496 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2497 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2498 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2499
eb18f6cc
PE
2500 * xmenu.c (menu_help_callback): Pointer type fixes.
2501 Use const pointers when pointing at readonly data. Avoid pointer
2502 signedness clashes.
2503 (FALSE): Remove unused macro.
2504 (update_frame_menubar): Remove unused decl.
2505
1fe72bf8
PE
2506 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2507
60d9e1db
PE
2508 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2509 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2510 (single_menu_item): Rename local to avoid shadowing.
2511
39261c26
PE
2512 * keyboard.c (make_lispy_event): Remove unused local var.
2513
018c5e19
PE
2514 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2515 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2516
63d2b86e
PE
2517 * bitmaps: Change bitmaps from unsigned char back to the X11
2518 compatible char. Avoid the old compiler warnings about
2519 out-of-range initializers by using, for example, '\xab' rather
2520 than 0xab.
2521
aefd87e1
PE
2522 * xgselect.c (xgselect_initialize): Check vs interface
2523 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2524
bf501fb9
PE
2525 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2526
e9829fdf
PE
2527 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2528 to read-only memory.
2529
1086c095
PE
2530 * fns.c (vector): Remove; this old hack is no longer needed.
2531
2baccd04 2532 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2533 Remove unused var.
dde42981 2534 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2535
72391843 2536 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2537
436c16df 2538 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2539 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2540 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2541
92bb796d 2542 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2543 (x_term_init): Remove local to avoid shadowing.
92bb796d 2544
764430a3 2545 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2546
2547 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2548 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2549
d1dfb56c
EZ
25502011-04-16 Eli Zaretskii <eliz@gnu.org>
2551
c4354cb4
EZ
2552 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2553
d1dfb56c
EZ
2554 Fix regex.c, syntax.c and friends for buffers > 2GB.
2555 * syntax.h (struct gl_state_s): Declare character position members
2556 EMACS_INT.
2557
2558 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2559
04f2d78b
CB
2560 * textprop.c (verify_interval_modification, interval_of):
2561 Declare arguments EMACS_INT.
d1dfb56c
EZ
2562
2563 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2564 EMACS_INT.
2565
2566 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2567
2568 * indent.c (Fvertical_motion): Local variable it_start is now
2569 EMACS_INT.
2570
2571 * regex.c (re_match, re_match_2, re_match_2_internal)
2572 (bcmp_translate, regcomp, regexec, print_double_string)
2573 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2574 (re_compile_pattern, re_exec): Declare arguments and local
2575 variables `size_t' and `ssize_t' and return values `regoff_t', as
2576 appropriate.
2577 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2578 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2579 <compile_stack_type>: `size' and `avail' are now `size_t'.
2580
2581 * regex.h <regoff_t>: Use ssize_t, not int.
2582 (re_search, re_search_2, re_match, re_match_2): Arguments that
2583 specify buffer/string position and length are now ssize_t and
2584 size_t. Return type is regoff_t.
2585
613052cd
BK
25862011-04-16 Ben Key <bkey76@gmail.com>
2587
2588 * nsfont.m: Fixed bugs in ns_get_family and
2589 ns_descriptor_to_entity that were caused by using free to
2590 deallocate memory blocks that were allocated by xmalloc (via
2591 xstrdup). This caused Emacs to crash when compiled with
2592 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2593 --enable-checking=xmallocoverrun). xfree is now used to
2594 deallocate these memory blocks.
2595
4170f62f 25962011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2597
71b41406
PE
2598 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2599
9587a89d
PE
2600 emacs_write: Accept and return EMACS_INT for sizes.
2601 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2602 et seq.
2603 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2604 Accept and return EMACS_INT.
2605 (emacs_gnutls_write): Return the number of bytes written on
2606 partial writes.
2607 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2608 (emacs_read, emacs_write): Remove check for negative size, as the
2609 Emacs source code has been audited now.
9587a89d
PE
2610 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2611 (emacs_read, emacs_write): Use it.
273a5f82
PE
2612 * process.c (send_process): Adjust to the new signatures of
2613 emacs_write and emacs_gnutls_write. Do not attempt to store
2614 a byte offset into an 'int'; it might overflow.
9587a89d 2615 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2616
3e047f51
PE
2617 * sound.c: Don't assume sizes fit in 'int'.
2618 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2619 Return EMACS_INT, not int.
3e047f51 2620 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2621 Accept EMACS_INT, not int.
2622 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2623 record read return values.
2624
cc39a9db
BK
26252011-04-15 Ben Key <bkey76@gmail.com>
2626
c9d0ec6d
JB
2627 * keyboard.c (Qundefined): Don't declare static since it is used
2628 in nsfns.m.
2629 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2630 static since they are used in nsfont.m.
cc39a9db 2631
6c60eb9f
SM
26322011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2633
2634 * process.c (Qprocessp): Don't declare static.
2635 * lisp.h (Qprocessp): Declare again.
2636
7990b61a
JB
26372011-04-15 Juanma Barranquero <lekktu@gmail.com>
2638
2639 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2640
5d4cb038
PE
26412011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2642
8bd7b830 2643 Improve C-level modularity by making more things 'static'.
cd64ea1d 2644
e3b27b31
PE
2645 Don't publish debugger-only interfaces to other modules.
2646 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2647 (verify_bytepos, count_markers): Move decls to the only modules
2648 that need them.
2649 * region-cache.h (pp_cache): Likewise.
2650 * window.h (check_all_windows): Likewise.
2651 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2652
5d4cb038
PE
2653 * sysdep.c (croak): Now static, if
2654 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2655 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2656
2657 * alloc.c (refill_memory_reserve): Now static if
2658 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2659 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2660
e87b6180
PE
2661 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2662 Define only if USE_LUCID.
2663
ac64929e
PE
2664 * xrdb.c (x_customization_string, x_rm_string): Now static.
2665
6f37259d
PE
2666 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2667 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2668
1683e3ab
PE
2669 * xdisp.c (draw_row_with_mouse_face): Now static.
2670 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2671
de9c2632
PE
2672 * window.h (check_all_windows): Mark externally visible.
2673
2b96acb7
PE
2674 * window.c (window_deletion_count): Now static.
2675
2676 * undo.c: Make symbols static if they're not exported.
2677 (last_undo_buffer, last_boundary_position, pending_boundary):
2678 Now static.
2679
50436f33
PE
2680 * textprop.c (interval_insert_behind_hooks): Now static.
2681 (interval_insert_in_front_hooks): Likewise.
2682
64520e5c
PE
2683 * term.c: Make symbols static if they're not exported.
2684 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2685 (max_frame_lines, tty_set_terminal_modes):
2686 (tty_reset_terminal_modes, tty_turn_off_highlight):
2687 (get_tty_terminal): Now static.
2688 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2689 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2690 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2691 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2692 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2693
1fa53021
PE
2694 * sysdep.c: Make symbols static if they're not exported.
2695 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2696 Now static.
2697 (sigprocmask_set, full_mask): Remove; unused.
2698 (wait_debugging): Mark as visible.
2699 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2700 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2701
d4b43b22
PE
2702 * syntax.c (syntax_temp): Define only if !__GNUC__.
2703
b7c513d0
PE
2704 * sound.c (current_sound_device, current_sound): Now static.
2705
989b29ad
PE
2706 * search.c (searchbufs, searchbuf_head): Now static.
2707
13a55a78
PE
2708 * scroll.c (scroll_cost): Remove; unused.
2709 * dispextern.h (scroll_cost): Remove decl.
2710
de68a1fc
PE
2711 * region-cache.h (pp_cache): Mark as externally visible.
2712
40ccffa6
PE
2713 * process.c: Make symbols static if they're not exported.
2714 (process_tick, update_tick, create_process, chan_process):
2715 (Vprocess_alist, proc_buffered_char, datagram_access):
2716 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2717 (deactivate_process): Mark defn as static, as well as decl.
2718 * lisp.h (create_process): Remove decl.
2719 * process.h (chan_process, Vprocess_alist): Remove decls.
2720
ad64fc97
PE
2721 * print.c: Make symbols static if they're not exported.
2722 (print_depth, new_backquote_output, being_printed, print_buffer):
2723 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2724 (print_interval, print_number_index, initial_stderr_stream):
2725 Now static.
2726 * lisp.h (Fprinc): Remove decl.
2727 (debug_output_compilation_hack): Mark as externally visible.
2728
adddb265
PE
2729 * sysdep.c (croak): Move decl from here to syssignal.h.
2730 * syssignal.h (croak): Put it here, so the API can be checked when
2731 'croak' is called from dissociate_if_controlling_tty.
2732
1717ede2
PE
2733 * minibuf.c: Make symbols static if they're not exported.
2734 (minibuf_save_list, choose_minibuf_frame): Now static.
2735 * lisp.h (choose_minibuf_frame): Remove decl.
2736
fa5fb2bc
PE
2737 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2738
1e3890d1
PE
2739 * lread.c: Make symbols static if they're not exported.
2740 (read_objects, initial_obarray, oblookup_last_bucket_number):
2741 Now static.
2742 (make_symbol): Remove; unused.
2743 * lisp.h (initial_obarray, make_symbol): Remove decls.
2744
8a1414fa
PE
2745 * keyboard.c: Make symbols static if they're not exported.
2746 (single_kboard, recent_keys_index, total_keys, recent_keys):
2747 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2748 (this_single_command_key_start, echoing, last_auto_save):
2749 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2750 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2751 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2752 (Vlispy_mouse_stem, double_click_count):
2753 Now static.
2754 (force_auto_save_soon): Define only if SIGDANGER.
2755 (ignore_mouse_drag_p): Now static if
2756 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2757 (print_help): Remove; unused.
2758 (stop_character, last_timer_event): Mark as externally visible.
2759 * keyboard.h (ignore_mouse_drag_p): Declare only if
2760 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2761 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2762 * lisp.h (echoing): Remove decl.
2763 (force_auto_save_soon): Declare only if SIGDANGER.
2764 * xdisp.c (redisplay_window): Simplify code, to make it more
2765 obvious that ignore_mouse_drag_p is not accessed if !defined
2766 USE_GTK && !defined HAVE_NS.
2767
93ea6e8f
PE
2768 * intervals.c: Make symbols static if they're not exported.
2769 (merge_properties_sticky, merge_interval_right, delete_interval):
2770 Now static.
2771 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2772
77382fcc
PE
2773 * insdel.c: Make symbols static if they're not exported.
2774 However, leave prepare_to_modify_buffer alone. It's never
2775 called from outside this function, but that appears to be a bug.
2776 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2777 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2778 (adjust_after_replace_noundo): Remove; unused.
2779 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2780 (signal_before_change): Remove decls.
77382fcc 2781
9306c32e
PE
2782 * indent.c (val_compute_motion, val_vmotion): Now static.
2783
cd44d2eb
PE
2784 * image.c: Make symbols static if they're not exported.
2785 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2786 if USE_GTK.
2787 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2788 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2789
ad9a7a06
PE
2790 * fringe.c (standard_bitmaps): Now static.
2791 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2792
81626931
PE
2793 * frame.c: Make symbols static if they're not exported.
2794 (x_report_frame_params, make_terminal_frame): Now static.
2795 (get_frame_param): Now static, unless HAVE_NS.
2796 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2797 (x_get_resource_string): Remove; not used.
2798 * frame.h (make_terminal_frame, x_report_frame_params):
2799 (x_get_resource_string); Remove decls.
2800 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2801 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2802
239f9db9
PE
2803 * font.c, fontset.c: Make symbols static if they're not exported.
2804 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2805 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2806 * font.c (font_close_object): Now static.
2807 * font.h (font_close_object): Remove.
2808 * fontset.c (FONTSET_OBJLIST): Remove.
2809 (free_realized_fontset) #if-0 the body, which does nothing.
2810 (face_suitable_for_char_p): #if-0, as it's never called.
2811 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2812 * xfaces.c (face_at_string_position):
2813 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2814 since 0 is always ASCII.
2815
dfcf3579
PE
2816 * fns.c (weak_hash_tables): Now static.
2817
5045092b
PE
2818 * fileio.c: Make symbols static if they're not exported.
2819 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2820 (Vwrite_region_annotation_buffers): Now static.
2821
57a96f5c
PE
2822 * eval.c: Make symbols static if they're not exported.
2823 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2824 * lisp.h (backtrace_list): Remove decl.
2825
35f08c38
PE
2826 * emacs.c: Make symbols static if they're not exported.
2827 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2828 (fatal_error_code, fatal_error_signal_hook, standard_args):
2829 Now static.
2830 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2831 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2832 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2833 * lisp.h (fatal_error_signal_hook): Remove decl.
2834 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2835
f44bd759
PE
2836 * editfns.c: Move a (normally-unused) function to its only use.
2837 * editfns.c, lisp.h (get_operating_system_release): Remove.
2838 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2839 worth the hassle of breaking this out.
2840
b532497d
PE
2841 * xterm.c: Make symbols static if they're not exported.
2842 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2843 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2844 (x_destroy_window, x_delete_display):
2845 Now static.
2846 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2847 (x_mouse_leave): Remove; unused.
2848 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2849 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2850 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2851 Remove decls.
2852 (x_mouse_leave): Declare only if WINDOWSNT.
2853 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2854 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2855 USE_X_TOOLKIT.
2856
1675728f
PE
2857 * ftxfont.c: Make symbols static if they're not exported.
2858 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2859 HAVE_FREETYPE.
2860 * font.h (ftxfont_driver): Likewise.
2861
e4cebfca
PE
2862 * xfns.c: Make symbols static if they're not exported.
2863 (x_last_font_name, x_display_info_for_name):
2864 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2865 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2866 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2867 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2868 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2869 (last_show_tip_args): Now static.
2870 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2871 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2872 (x_screen_planes): Remove; unused.
2873 * dispextern.h (x_screen_planes): Remove decl.
2874
5bf46f05
PE
2875 * dispnew.c: Make symbols static if they're not exported.
2876 * dispextern.h (redraw_garbaged_frames, scrolling):
2877 (increment_row_positions): Remove.
2878 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2879 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2880 Now static.
2881 (redraw_garbaged_frames): Remove; unused.
2882
435f4c28
PE
2883 * xfaces.c: Make symbols static if they're not exported.
2884 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2885 Remove decls.
2886 * xterm.h (defined_color): Remove decls.
2887 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2888 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2889 (menu_face_changed_default, defined_color, free_realized_face):
2890 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2891 (ascii_face_of_lisp_face): Remove; unused.
2892
8524aef3
PE
2893 * xdisp.c: Make symbols static if they're not exported.
2894 * dispextern.h (scratch_glyph_row, window_box_edges):
2895 (glyph_to_pixel_coords, set_cursor_from_row):
2896 (get_next_display_element, set_iterator_to_next):
2897 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2898 (show_mouse_face): Remove decls
2899 * frame.h (message_buf_print): Likewise.
2900 * lisp.h (pop_message, set_message, check_point_in_composition):
2901 Likewise.
2902 * xterm.h (set_vertical_scroll_bar): Likewise.
2903 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2904 (message_buf_print, scratch_glyph_row, displayed_buffer):
2905 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2906 (get_next_display_element, show_mouse_face, window_box_edges):
2907 (frame_to_window_pixel_xy, check_point_in_composition):
2908 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2909 (glyph_to_pixel_coords): Remove; unused.
2910
16390cd2
PE
2911 * dired.c (file_name_completion): Now static.
2912
2913 * dbusbind.c (xd_in_read_queued_messages): Now static.
2914
a25f4dfa
PE
2915 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2916 * data.c (circular_list_error): Remove.
2917
14a9c8df
PE
2918 * commands.h (last_point_position, last_point_position_buffer):
2919 (last_point_position_window): Remove decls.
2920 * keyboard.c: Make these variables static.
2921
04f2d78b
CB
2922 * coding.h (coding, code_convert_region, encode_coding_gap):
2923 Remove decls.
74ab6df5
PE
2924 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2925 (iso_code_class, detect_coding, code_convert_region): Now static.
2926 (encode_coding_gap): Remove; unused.
2927
38dfbee1
PE
2928 * chartab.c (chartab_chars, chartab_bits): Now static.
2929
a2cb4e63
PE
2930 * charset.h (charset_iso_8859_1): Remove decl.
2931 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2932 Now static.
2933
127198fd
PE
2934 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2935 * ccl.c (Vccl_program_table): Now static.
2936 (check_ccl_update): Remove; unused.
2937
d85b608f
PE
2938 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2939 * category.h: ... from here.
2940 * category.c (check_category_table, set_category_set): Now static.
2941
31cd66f3
PE
2942 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2943 * lisp.h: Remove these decls.
2944
c358e587
PE
2945 * buffer.c (buffer_count): Remove unused var.
2946
e78aecca
PE
2947 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2948 so that it's not optimized away.
2949 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2950 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2951 exported only to the debugger.
2952
e192d7d3 2953 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2954 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2955
92470028
PE
2956 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2957 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2958 was inaccessible from Lisp.
2959 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2960 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2961
244ed907
PE
2962 alloc.c: Import and export fewer symbols, and remove unused items.
2963 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2964 is defined.
2965 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2966 it's not optimized away by whole-program optimization.
2967 (message_enable_multibyte, free_misc): Remove.
2968 (catchlist, handlerlist, mark_backtrace):
2969 Declare only if BYTE_MARK_STACK.
2970 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2971 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2972 (message_enable_multibyte): Remove decl.
2973 (free_misc, interval_free_list, float_block, float_block_index):
2974 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2975 (cons_free_list, last_marked_index):
2976 Now static.
2977 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2978 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2979 (mark_backtrace): Define only if BYTE_MARK_STACK.
2980 * xdisp.c (message_enable_multibyte): Now static.
2981
61c2b50e 2982 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2983 This makes it easier for human readers (and static analyzers)
2984 to see whether these variables are used from other modules.
2985 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2986 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2987 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2988 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2989 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2990 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2991 * xmenu.c, xselect.c:
2992 Declare Q* vars static if they are not used in other modules.
2993 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2994 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2995 Remove decls of unexported vars.
2996 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2997
95c82688
PE
2998 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2999
16a97296
PE
3000 Make Emacs functions such as Fatom 'static' by default.
3001 This makes it easier for human readers (and static analyzers)
3002 to see whether these functions can be called from other modules.
3003 DEFUN now defines a static function. To make the function external
3004 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3005 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3006 (Finit_image_library):
16a97296
PE
3007 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3008 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3009 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3010 Remove decls, since these functions are now static.
3011 (Funintern, Fget_internal_run_time): New decls, since these functions
3012 were already external.
95c82688 3013
16a97296
PE
3014 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3015 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3016 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3017 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3018 * keyboard.c, keymap.c, lread.c:
3019 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3020 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3021 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3022 Mark functions with DEFUE instead of DEFUN,
3023 if they are used in other modules.
3024 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3025 decls for now-static functions.
3026 * buffer.h (Fdelete_overlay): Remove decl.
3027 * callproc.c (Fgetenv_internal): Mark as internal.
3028 * composite.c (Fremove_list_of_text_properties): Remove decl.
3029 (Fcomposition_get_gstring): New forward static decl.
3030 * composite.h (Fcomposite_get_gstring): Remove decl.
3031 * dired.c (Ffile_attributes): New forward static decl.
3032 * doc.c (Fdocumntation_property): New forward static decl.
3033 * eval.c (Ffetch_bytecode): New forward static decl.
3034 (Funintern): Remove extern decl; now in .h file where it belongs.
3035 * fileio.c (Fmake_symbolic_link): New forward static decl.
3036 * image.c (Finit_image_library): New forward static decl.
3037 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3038 * intervals.h (Fprevious_property_change):
3039 (Fremove_list_of_text_properties): Remove decls.
3040 * keyboard.c (Fthis_command_keys): Remove decl.
3041 (Fcommand_execute): New forward static decl.
3042 * keymap.c (Flookup_key): New forward static decl.
3043 (Fcopy_keymap): Now static.
3044 * keymap.h (Flookup_key): Remove decl.
3045 * process.c (Fget_process): New forward static decl.
3046 (Fprocess_datagram_address): Mark as internal.
3047 * syntax.c (Fsyntax_table_p): New forward static decl.
3048 (skip_chars): Remove duplicate decl.
3049 * textprop.c (Fprevious_property_change): New forward static decl.
3050 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3051 Now internal.
3052 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3053 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3054
785bbd42
PE
3055 * editfns.c (Fformat): Remove unreachable code.
3056
8b913b57
AS
30572011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3058
3059 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3060 change. (Bug#8496)
3061
a6744a35
EZ
30622011-04-13 Eli Zaretskii <eliz@gnu.org>
3063
3064 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3065 when at ZV. (Bug#8487)
3066
e7974947
AS
30672011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3068
baad03f0
AS
3069 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3070 (Bug#8437)
3071 * keyboard.c (parse_tool_bar_item): Likewise.
3072 * sound.c (sound_cleanup, alsa_close): Likewise.
3073 * termcap.c (tgetent): Likewise.
3074 * xfns.c (x_default_font_parameter): Likewise.
3075 * xsettings.c (read_and_apply_settings): Likewise.
3076
e7974947
AS
3077 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3078 (overrun_check_free): Protoize.
3079
28272684
PE
30802011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3081
3082 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3083 since callers should never pass a negative size.
3084 Change the signature to match that of plain 'read' and 'write'; see
3085 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3086 * lisp.h: Update prototypes of emacs_write and emacs_read.
3087
11997c76
EZ
30882011-04-11 Eli Zaretskii <eliz@gnu.org>
3089
3090 * xdisp.c (redisplay_window): Don't try to determine the character
3091 position of the scroll margin if the window start point w->startp
e896f03c 3092 is outside the buffer's accessible region. (Bug#8468)
11997c76 3093
8a2cbd72
EZ
30942011-04-10 Eli Zaretskii <eliz@gnu.org>
3095
3096 Fix write-region and its subroutines for buffers > 2GB.
3097 * fileio.c (a_write, e_write): Modify declaration of arguments and
3098 local variables to support buffers larger than 2GB.
3099 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3100
3101 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3102 argument, local variables, and return value.
3103
3104 * lisp.h: Update prototypes of emacs_write and emacs_read.
3105
3106 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3107
4073e537 31082011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3109
1ebfdcb6
PE
3110 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3111
b2ded58d
PE
3112 Fix more problems found by GCC 4.6.0's static checks.
3113
7d66342c
PE
3114 * xdisp.c (vmessage): Use a better test for character truncation.
3115
bbf47d44
PE
3116 * charset.c (load_charset_map): <, not <=, for optimization,
3117 and to avoid potential problems with integer overflow.
9248994d 3118 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3119 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3120 * editfns.c (Fformat): Likewise.
1e69125e 3121 * syntax.c (skip_chars): Likewise.
3befa583 3122
e3019616
PE
3123 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3124 This also lets GCC 4.6.0 generate slightly better loop code.
3125
becfa255
PE
3126 * callint.c (Fcall_interactively): <, not <=, for optimization.
3127 (Fcall_interactively): Count the number of arguments produced,
3128 not the number of arguments given. This is simpler and lets GCC
3129 4.6.0 generate slightly better code.
3130
dae0cd48
PE
3131 * ftfont.c: Distingish more carefully between FcChar8 and char.
3132 The previous code passed unsigned char * to a functions like
3133 strlen and xstrcasecmp that expect char *, which does not
3134 conform to the C standard.
3135 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3136 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3137 char * when the C standard requires it.
3138
76032d70
PE
3139 * keyboard.c (read_char): Remove unused var.
3140
eb3f1cc8
PE
3141 * eval.c: Port to Windows vsnprintf (Bug#8435).
3142 Include <limits.h>.
3143 (SIZE_MAX): Define if the headers do not.
3144 (verror): Do not give up if vsnprintf returns a negative count.
3145 Instead, grow the buffer. This ports to Windows vsnprintf, which
3146 does not conform to C99. Problem reported by Eli Zaretskii.
3147 Also, simplify the allocation scheme, by avoiding the need for
3148 calling realloc, and removing the ALLOCATED variable.
3149
70476b54
PE
3150 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3151
12020a9e
PE
3152 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3153 But keep the doprint source code for now, as we might revamp it
3154 and use it again (Bug#8435).
ea6c7ae6
PE
3155 * lisp.h (doprnt): Remove.
3156 * Makefile.in (base_obj): Remove doprnt.o.
3157 * deps.mk (doprnt.o): Remove.
3158
5fdb398c
PE
3159 error: Print 32- and 64-bit integers portably (Bug#8435).
3160 Without this change, on typical 64-bit hosts error ("...%d...", N)
3161 was used to print both 32- and 64-bit integers N, which relied on
3162 undefined behavior.
3163 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3164 New macro.
3165 * lisp.h (error, verror): Mark as printf-like functions.
3166 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3167 Report overflow in size calculations when allocating printf buffer.
3168 Do not truncate output string at its first null byte.
3169 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3170 Truncate the output at a character boundary, since vsnprintf does not
3171 do that.
3172 * charset.c (check_iso_charset_parameter): Convert internal
3173 character to string before calling 'error', since %c now has the
3174 printf meaning.
3175 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3176 overflow when computing char to be passed to 'error'. Do not
3177 pass Lisp_Object to 'error'; pass the integer instead.
3178 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3179 formatted with plain %d.
3180
b189fa66
PE
3181 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3182
bff87ef0
PE
3183 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3184
7e2cac20
PE
3185 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3186
ce4d90b5
PE
3187 * xterm.c (x_catch_errors): Remove duplicate declaration.
3188
266c9547
PE
3189 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3190
79c49ad2
PE
3191 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3192
368f4090
JM
31932011-04-10 Jim Meyering <meyering@redhat.com>
3194
3195 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3196 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3197 return ssize_t not "int", and use size_t as the buffer length.
3198 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3199 * gnutls.h: Update declarations.
3200 * process.c (read_process_output): Use ssize_t, to match.
3201 (send_process): Likewise.
3202
a32d4040
CY
32032011-04-09 Chong Yidong <cyd@stupidchicken.com>
3204
3205 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3206
8546720e 32072011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3208
04f2d78b
CB
3209 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3210 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3211
8546720e
GM
3212 * xterm.c (handle_one_xevent):
3213 * xmenu.c (create_and_show_popup_menu):
3214 * xselect.c (x_decline_selection_request)
3215 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3216
0a2f5c1a 32172011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3218
3219 Fix some uses of `int' instead of EMACS_INT.
3220 * search.c (string_match_1, fast_string_match)
3221 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3222 (scan_buffer, find_next_newline_no_quit)
3223 (find_before_next_newline, search_command, Freplace_match)
3224 (Fmatch_data): Make some `int' variables be EMACS_INT.
3225
3226 * xdisp.c (display_count_lines): 3rd argument and return value now
3227 EMACS_INT. All callers changed.
3228 (pint2hrstr): Last argument is now EMACS_INT.
3229
3230 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3231 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3232 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3233 (decode_coding_utf_16, decode_coding_emacs_mule)
3234 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3235 (decode_coding_ccl, decode_coding_charset)
3236 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3237 (decode_coding_iso_2022, decode_coding_emacs_mule)
3238 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3239 <char_offset, last_offset>: Declare EMACS_INT.
3240 (encode_coding_utf_8, encode_coding_utf_16)
3241 (encode_coding_emacs_mule, encode_invocation_designation)
3242 (encode_designation_at_bol, encode_coding_iso_2022)
3243 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3244 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3245 Declare EMACS_INT.
3246 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3247 (encode_invocation_designation): Last argument P_NCHARS is now
3248 EMACS_INT.
3249 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3250 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3251
3252 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3253 All users changed.
3254
3255 * ccl.c (Fccl_execute_on_string): Declare some variables
3256 EMACS_INT.
3257
8546720e 32582011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3259
3260 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3261
4e19a977
CS
32622011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3263
3264 * process.c (Fformat_network_address): Doc fix.
3265
87302331
R
32662011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3267
3268 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3269
cbb59342
CY
32702011-04-08 Chong Yidong <cyd@stupidchicken.com>
3271
3272 * keyboard.c (read_char): Call Lisp function help-form-show,
3273 instead of using internal_with_output_to_temp_buffer.
3274 (Qhelp_form_show): New var.
e0d38eeb 3275 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3276
3277 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3278
3279 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3280
e67a13ab
CY
32812011-04-06 Chong Yidong <cyd@stupidchicken.com>
3282
04f2d78b
CB
3283 * process.c (Flist_processes): Remove to Lisp.
3284 (list_processes_1): Delete.
e67a13ab 3285
973f782d
EZ
32862011-04-06 Eli Zaretskii <eliz@gnu.org>
3287
7c106b1e
EZ
3288 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3289
973f782d
EZ
3290 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3291
41cf7d1a 32922011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3293
ca23cc88
PE
3294 Fix more problems found by GCC 4.6.0's static checks.
3295
f390e2d5
PE
3296 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3297
42eea0d0
PE
3298 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3299
b69769da 3300 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3301
f9541e84
PE
3302 * xdisp.c (vmessage): Mark as a printf-like function.
3303
13841b55
PE
3304 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3305
c136c10f
PE
3306 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3307
5e2d4a30
PE
3308 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3309 printf-like functions.
3310 (tiff_load): Add casts to remove these marks before passing them
3311 to system-supplied API.
3312
583f48b9
PE
3313 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3314
b25d760e
PE
3315 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3316 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3317 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3318 directly, rather than having caller test rule sign. This avoids
3319 some unnecessary tests.
3320 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3321 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3322 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3323
bc7b6697 3324 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3325 (xfont_open): Avoid unnecessary tests.
bc7b6697 3326
27ccc379
PE
3327 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3328
dcd5c89a
PE
3329 * composite.h, composite.c (composition_gstring_put_cache):
3330 Use EMACS_INT, not int, for length.
3331
b13a45c6
PE
3332 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3333 breaking out part of COMPOSITION_DECODE_RULE.
3334 (COMPOSITION_DECODE_RULE): Use it.
3335 * composite.c (get_composition_id): Remove unused local vars,
3336 by using the new macro.
3337
1e792e4d
PE
3338 * textprop.c (set_text_properties_1): Change while to do-while,
3339 since the condition is always true at first.
3340
dc6c6455 3341 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3342 (interval_deletion_adjustment): Return unsigned value.
3343 All uses changed.
dc6c6455 3344
aba7731a
PE
3345 * process.c (list_processes_1, create_pty, read_process_output):
3346 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3347 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3348 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3349 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3350 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3351
fdfc4bf3
PE
3352 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3353
fca8fe46 3354 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3355 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3356
06a0259a 3357 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3358 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3359 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3360
e7b9e80f
PE
3361 * print.c (print_error_message): Avoid int overflow.
3362
56201685
PE
3363 * font.c (font_list_entities): Redo for clarity,
3364 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3365
78834453 3366 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3367 (font_score): Avoid potential overflow in diff calculation.
78834453 3368
0bc0b309 3369 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3370 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3371
e610eaca
PE
3372 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3373
b895abce
PE
3374 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3375 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3376 can always succeed if overflow has undefined behavior.
3377
1f1d9321 3378 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3379 (wordify): Omit three unnecessary tests.
1f1d9321 3380
c59478bc
PE
3381 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3382 All callers changed. This avoids the need for an unused var.
3383
79b73827
PE
3384 * casefiddle.c (casify_region): Remove var that is set but not used.
3385
a4db5dfe
PE
3386 * dired.c (file_name_completion): Remove var that is set but not used.
3387
43aae36e
PE
3388 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3389
2a47c44d 3390 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3391 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3392
a37c69bf
PE
3393 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3394 Check for integer overflow on size calculations.
3395
328ab8e7
PE
3396 * buffer.c (Fprevious_overlay_change): Remove var that is set
3397 but not used.
3398
e5a2a5cb
PE
3399 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3400 Remove vars that are set but not used.
8d84a6eb 3401 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3402 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3403
a60e5f68
PE
3404 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3405
f661cb61 3406 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3407 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3408
f0397f5a
PE
3409 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3410 that are set but not used.
3411
8664db06 3412 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3413 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3414
6abdaa4a
PE
3415 * xselect.c (x_get_local_selection, x_handle_property_notify):
3416 Remove vars that are set but not used.
3417
0ce7538d 3418 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3419 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3420
9ae848fc
PE
3421 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3422 Remove var that is set but not used.
0b918413
PE
3423 (scroll_bar_windows_size): Now size_t, not int.
3424 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3425 Check for overflow.
9ae848fc 3426
a5a62657
PE
3427 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3428 (map_tty_color) [!defined MSDOS]: Likewise.
3429
5c5cdd39
PE
3430 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3431
66ebf983
PE
3432 * coding.c: Remove vars that are set but not used.
3433 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3434 All callers changed.
3435 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3436 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3437 (decode_coding_charset): Remove vars that are set but not used.
3438
1be4d761
PE
3439 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3440 that is set but not used.
3441
47553fa8
PE
3442 * print.c (print_object): Remove var that is set but not used.
3443
1f7196bf 3444 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3445 The gnulib version avoids calling malloc in the usual case,
3446 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3447 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3448 * filelock.c (current_lock_owner): Likewise.
3449 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3450 * sysdep.c: Include allocator.h, careadlinkat.h.
3451 (emacs_no_realloc_allocator): New static constant.
3452 (emacs_readlink): New function.
fdb61804
PE
3453 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3454 ../lib/careadlinkat.h.
d1fdcab7 3455
f84c17c7
SM
34562011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3457
3458 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3459 first non-nil return value).
3460
ef3862ad
JD
34612011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3462
3463 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3464 if not defined (Bug#8403).
3465
376a7006
JB
34662011-04-02 Juanma Barranquero <lekktu@gmail.com>
3467
3468 * xdisp.c (display_count_lines): Remove parameter `start',
3469 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3470 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3471 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3472 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3473 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3474 and thereabouts. All callers changed.
3475 (get_per_char_metric): Remove parameter `f', unused since
3476 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3477
6ca3801d
JM
34782011-04-02 Jim Meyering <meyering@redhat.com>
3479
3480 do not dereference NULL upon failed strdup
3481 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3482 (ns_get_family): Likewise.
3483
d8e2b5ba
JB
34842011-04-02 Juanma Barranquero <lekktu@gmail.com>
3485
3486 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3487
8c74fcbd
JD
34882011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3489
3490 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3491 later (Bug#8403).
3492
7200d79c
SM
34932011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3494
03408648 3495 Add lexical binding.
7200d79c 3496
03408648
SM
3497 * window.c (Ftemp_output_buffer_show): New fun.
3498 (Fsave_window_excursion):
3499 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3500
3501 * lread.c (lisp_file_lexically_bound_p): New function.
3502 (Fload): Bind Qlexical_binding.
3503 (readevalloop): Remove `evalfun' arg.
3504 Bind Qinternal_interpreter_environment.
3505 (Feval_buffer): Bind Qlexical_binding.
3506 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3507 Mark as dynamic.
3508 (syms_of_lread): Declare `lexical-binding'.
3509
3510 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3511
3512 * keyboard.c (eval_dyn): New fun.
3513 (menu_item_eval_property): Use it.
ca105506
SM
3514
3515 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3516
03408648
SM
3517 * fns.c (concat, mapcar1): Accept byte-code-functions.
3518
3519 * eval.c (Fsetq): Handle lexical vars.
3520 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3521 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3522 (FletX, Flet): Obey lexical binding.
3523 (Fcommandp): Handle closures.
3524 (Feval): New `lexical' arg.
3525 (eval_sub): New function extracted from Feval. Use it almost
3526 everywhere where Feval was used. Look up vars in lexical env.
3527 Handle closures.
3528 (Ffunctionp): Move from subr.el.
3529 (Ffuncall): Handle closures.
3530 (apply_lambda): Remove `eval_flags'.
3531 (funcall_lambda): Handle closures and new byte-code-functions.
3532 (Fspecial_variable_p): New function.
3533 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3534 but without exporting it to Lisp.
23aba0ea 3535
23aba0ea 3536 * doc.c (Fdocumentation, store_function_docstring):
03408648 3537 * data.c (Finteractive_form): Handle closures.
23aba0ea 3538
03408648
SM
3539 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3540 interactive spec.
ba83908c 3541
04f2d78b
CB
3542 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3543 New byte-codes.
03408648
SM
3544 (exec_byte_code): New function extracted from Fbyte_code to handle new
3545 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3546
03408648 3547 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3548
03408648 3549 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3550
e2abce01
JB
35512011-03-31 Juanma Barranquero <lekktu@gmail.com>
3552
3553 * xdisp.c (redisplay_internal): Fix prototype.
3554
63696a73 35552011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3556
63696a73 3557 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3558 (try_scrolling): Use it when setting scroll_limit.
3559 Limit scrolling to 100 screen lines.
63696a73
EZ
3560 (redisplay_window): Even when falling back on "recentering",
3561 position point in the window according to scroll-conservatively,
3562 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3563
3564 (try_scrolling): When point is above the window, allow searching
3565 as far as scroll_max, or one screenful, to compute vertical
3566 distance from PT to the scroll margin position. This prevents
3567 try_scrolling from unnecessarily failing when
3568 scroll-conservatively is set to a value slightly larger than the
3569 window height. Clean up the case of PT below the margin at bottom
3570 of window: scroll_max can no longer be INT_MAX. When aggressive
3571 scrolling is in use, don't let point enter the opposite scroll
3572 margin as result of the scroll.
3573 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3574 threshold of 100 lines for never-recentering scrolling.
3575
e4cc2dfc
JB
35762011-03-31 Juanma Barranquero <lekktu@gmail.com>
3577
3578 * dispextern.h (move_it_by_lines):
3579 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3580 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3581 (message_log_check_duplicate): Remove parameters `prev_bol' and
3582 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3583 (redisplay_internal): Remove parameter `preserve_echo_area',
3584 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3585
3586 * indent.c (Fvertical_motion):
3587 * window.c (window_scroll_pixel_based, Frecenter):
3588 Don't pass `need_y_p' to `move_it_by_lines'.
3589
1c470562
SM
35902011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3591
44f230aa
SM
3592 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3593 steal a few bits to be more compact.
3594 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3595 Remove unneeded casts.
3596
1c470562
SM
3597 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3598
888adce9
ZK
35992011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3600
3601 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3602 binding" message (bug#7967).
3603
f838ed7b
PE
36042011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3605
77861b95
PE
3606 Fix more problems found by GCC 4.6.0's static checks.
3607
de6dbc14
PE
3608 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3609 Remove unused local var.
3610
f838ed7b
PE
3611 * editfns.c (Fmessage_box): Remove unused local var.
3612
792c7b2b
PE
3613 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3614 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3615 Omit unused local vars.
c499e557 3616 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3617 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3618 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3619 Omit unused local var.
3620
ba0165e1
PE
3621 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3622 Don't assume string length fits in int.
32ad8845 3623 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3624 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3625
3c59b4c9
PE
3626 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3627 instead of alloca (Bug#8344).
3628
a3eed478 3629 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3630 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3631
eb4d412d
PE
3632 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3633
1658b401
PE
3634 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3635 concerns.
3636
3637 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3638
3639 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3640
9a2c6e05
PE
3641 * keyboard.c (syms_of_keyboard): Use the same style as later
3642 in this function when indexing through an array. This also
3643 works around GCC bug 48267.
3644
03d0a109
PE
3645 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3646
44f730c8
PE
3647 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3648
fe75f926
PE
3649 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3650 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3651
ffa8c828
PE
3652 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3653 This avoids undefined behavior on integer overflow, and is a bit
3654 more convenient anyway since it is compared to a size_t variable.
3655
c5101a77
PE
3656 Variadic C functions now count arguments with size_t, not int.
3657 This avoids an unnecessary limitation on 64-bit machines, which
3658 caused (substring ...) to crash on large vectors (Bug#8344).
3659 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3660 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3661 All variadic functions and their callers changed accordingly.
c5101a77
PE
3662 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3663 * data.c (arith_driver, float_arith_driver): Likewise.
3664 * editfns.c (general_insert_function): Likewise.
3665 * eval.c (struct backtrace.nargs, interactive_p)
3666 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3667 (funcall_lambda, mark_backtrace): Likewise.
3668 * fns.c (concat): Likewise.
3669 * frame.c (x_set_frame_parameters): Likewise.
3670 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3671 0 if not found, not -1. All callers changed.
3672
dd3f25f7
PE
3673 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3674 (stack_copy_size): Now size_t, not int.
3675 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3676
461c2ab9
JB
36772011-03-28 Juanma Barranquero <lekktu@gmail.com>
3678
3679 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3680 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3681 All callers changed.
3682
3683 * lisp.h (multibyte_char_to_unibyte):
3684 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3685 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3686 * character.h (CHAR_TO_BYTE8):
3687 * cmds.c (internal_self_insert):
3688 * editfns.c (general_insert_function):
3689 * keymap.c (push_key_description):
3690 * search.c (Freplace_match):
3691 * xdisp.c (message_dolog, set_message_1): All callers changed.
3692
f6d62986
SM
36932011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3694
3695 * keyboard.c (safe_run_hook_funcall): New function.
3696 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3697 don't set the hook to nil, but remove the offending function instead.
3698 (Qcommand_hook_internal): Remove, unused.
3699 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3700 Vcommand_hook_internal.
3701
3702 * eval.c (enum run_hooks_condition): Remove.
3703 (funcall_nil, funcall_not): New functions.
3704 (run_hook_with_args): Call each function through a `funcall' argument.
3705 Remove `cond' argument, now redundant.
3706 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3707 (Frun_hook_with_args_until_failure): Adjust accordingly.
3708 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3709
1db5b1ad
JB
37102011-03-28 Juanma Barranquero <lekktu@gmail.com>
3711
3712 * dispextern.h (string_buffer_position): Remove declaration.
3713
3714 * print.c (strout): Remove parameter `multibyte', unused since
3715 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3716
3717 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3718 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3719 All callers changed.
3720
3721 * w32.c (_wsa_errlist): Use braces for struct initializers.
3722
3723 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3724 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3725 All callers changed.
3726 (string_buffer_position): Likewise. Also, make static (it's never
3727 used outside xdisp.c).
3728 (cursor_row_p): Remove parameter `w', unused since
3729 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3730 (decode_mode_spec): Remove parameter `precision', introduced during
3731 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3732 All callers changed.
3733
5ffb62aa
JD
37342011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3735
3736 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3737
461c2ab9 37382011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3739
3740 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3741 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3742 (ns_update_auto_hide_menu_bar): New functions.
3743 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3744 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3745 ns_constrain_all_frames.
3746 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3747 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3748
5c380ffb
JD
37492011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3750
3751 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3752
9af30bdf
GM
37532011-03-27 Glenn Morris <rgm@gnu.org>
3754
3755 * syssignal.h: Replace RETSIGTYPE with void.
3756 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3757 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3758 Replace SIGTYPE with void everywhere.
3759 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3760 * s/template.h (SIGTYPE): Remove commented out definition.
3761
e2abce01
JB
37622011-03-26 Eli Zaretskii <eliz@gnu.org>
3763
3764 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3765 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3766
f868cd8a
JB
37672011-03-26 Juanma Barranquero <lekktu@gmail.com>
3768
59eb0929
JB
3769 * w32.c (read_unc_volume): Use parameter `henum', instead of
3770 global variable `wget_enum_handle'.
3771
3772 * keymap.c (describe_vector): Remove parameters `indices' and
3773 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3774 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3775
f868cd8a
JB
3776 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3777
3778 * keyboard.c (timer_check): Remove parameter `do_it_now',
3779 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3780 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3781 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3782
3783 * keyboard.c (read_char):
3784 * w32menu.c (w32_menu_display_help):
3785 * xmenu.c (show_help_event, menu_help_callback):
3786 Adjust calls to `show_help_echo'.
3787
3788 * gtkutil.c (xg_maybe_add_timer):
3789 * keyboard.c (readable_events):
3790 * process.c (wait_reading_process_output):
3791 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3792
3793 * insdel.c (adjust_markers_gap_motion):
3794 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3795 (gap_left, gap_right): Don't call it.
3796
2ecf6fdb
CY
37972011-03-25 Chong Yidong <cyd@stupidchicken.com>
3798
3799 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3800 incurred during fontification.
3801
6b1f9ba4
JB
38022011-03-25 Juanma Barranquero <lekktu@gmail.com>
3803
3804 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3805 (DEFVAR_PER_BUFFER): Don't pass it.
3806
3807 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3808 (scrolling_window): Don't pass it.
3809
0f4a96b5
JB
38102011-03-25 Juanma Barranquero <lekktu@gmail.com>
3811
3812 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3813
3814 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3815 and `suffix'.
3816 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3817 of variables specific to SELinux and computation of `encoded_absname'.
3818
3819 * image.c (XPutPixel): Remove unused variable `height'.
3820
3821 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3822
3823 * unexw32.c (get_section_info): Remove unused variable `section'.
3824
3825 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3826 (system_process_attributes): Remove unused variable `sess'.
3827 (sys_read): Remove unused variable `err'.
3828
3829 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3830 (w32_wnd_proc): Remove unused variable `isdead'.
3831 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3832 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3833 (x_create_tip_frame): Remove unused variable `tem'.
3834
3835 * w32inevt.c (w32_console_read_socket):
3836 Remove unused variable `no_events'.
3837
3838 * w32term.c (x_draw_composite_glyph_string_foreground):
3839 Remove unused variable `width'.
3840
1149507c
JB
38412011-03-24 Juanma Barranquero <lekktu@gmail.com>
3842
3843 * w32term.c (x_set_glyph_string_clipping):
3844 Don't pass uninitialized region to CombineRgn.
3845
9c88f339
JB
38462011-03-23 Juanma Barranquero <lekktu@gmail.com>
3847
3848 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3849 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3850 (Fx_close_connection): Remove unused variable `i'.
3851
3852 * w32font.c (w32font_draw): Return number of glyphs.
3853 (w32font_open_internal): Remove unused variable `i'.
3854 (w32font_driver): Add missing initializer.
3855
3856 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3857 (fill_in_menu): Remove unused variable `items_added'.
3858
3859 * w32term.c (last_mouse_press_frame): Remove static global variable.
3860 (w32_clip_to_row): Remove unused variable `f'.
3861 (x_delete_terminal): Remove unused variable `i'.
3862
3863 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3864 (NOTHING): Remove unused static global variable.
3865 (uniscribe_check_otf): Remove unused variable `table'.
3866 (uniscribe_font_driver): Add missing initializers.
3867
dee091a3
JD
38682011-03-23 Julien Danjou <julien@danjou.info>
3869
3870 * term.c (Fsuspend_tty, Fresume_tty):
3871 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3872 * window.c (temp_output_buffer_show):
3873 * insdel.c (signal_before_change):
3874 * frame.c (Fhandle_switch_frame):
3875 * fileio.c (Fdo_auto_save):
3876 * emacs.c (Fkill_emacs):
3877 * editfns.c (save_excursion_restore):
3878 * cmds.c (internal_self_insert):
3879 * callint.c (Fcall_interactively):
3880 * buffer.c (Fkill_all_local_variables):
3881 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3882 Use Frun_hooks.
0f4a96b5 3883 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3884 unconditionnaly since it does the check itself.
3885
2c520ab5 38862011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3887
c9c49752
PE
3888 Fix more problems found by GCC 4.5.2's static checks.
3889
8abc3f12
PE
3890 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3891 the first time through the loop, since we know p0 < p1 then.
3892 This also avoids a gcc -Wstrict-overflow warning.
3893
a2d26660
PE
3894 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3895 leading to a memory leak, possible in functions like
3896 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3897 of objects (Bug#8318).
a2d26660 3898
916c72e9
PE
3899 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3900 that could (at least in theory) be that large.
3901
19ab8a18
PE
3902 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3903 This is less likely to overflow, and avoids undefined behavior if
3904 overflow does occur. All callers changed. Use strtoul to scan
3905 for the unsigned long integer.
b7cbbd6f
PE
3906 (pint2hrstr): Simplify and tune code slightly.
3907 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3908
f0641eff
PE
3909 * scroll.c (do_scrolling): Work around GCC bug 48228.
3910 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3911
7f650bb9
PE
3912 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3913 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3914 (validate_x_resource_name): Simplify count usage.
3915 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3916
37dd57d1
PE
3917 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3918 fail (Bug#8306).
81e56e61 3919
699979fc 3920 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3921
401bf9b4
PE
3922 * process.c (Fmake_network_process): Use socklen_t, not int,
3923 where POSIX says socklen_t is required in portable programs.
3924 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3925 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3926 (Fmake_network_process, server_accept_connection):
3927 (wait_reading_process_output, read_process_output):
3928 Likewise.
3929
b93aacde
PE
3930 * process.c: Rename or move locals to avoid shadowing.
3931 (list_processes_1, Fmake_network_process):
3932 (read_process_output_error_handler, exec_sentinel_error_handler):
3933 Rename or move locals.
4dc343ee 3934 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3935 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3936 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3937 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3938 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3939
af8a867c 3940 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3941 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3942 Include tparam.h instead, since it declares them.
af8a867c
PE
3943 * cm.h (PC): Remove extern decl; tparam.h now does this.
3944 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3945 * terminfo.c: Include tparam.h, to check interfaces.
3946 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3947 (tparam): Adjust signature to match interface in tparam.h;
3948 this removes some undefined behavior. Check that outstring and len
3949 are zero, which they always are with Emacs.
3950 * tparam.h (PC, BC, UP): New extern decls.
3951
0248044d 3952 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3953 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3954
8ff096c1 3955 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3956 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3957 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3958 (ftfont_list): Remove unused local.
49eaafba
PE
3959 (get_adstyle_property, ftfont_pattern_entity):
3960 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3961 Rename locals to avoid shadowing.
8ff096c1 3962
e2be39f6
PE
3963 * xfont.c (xfont_list_family): Mark var as initialized.
3964
c9735e30
PE
3965 * xml.c (make_dom): Now static.
3966
8f5201ae
PE
3967 * composite.c (composition_compute_stop_pos): Rename local to
3968 avoid shadowing.
b246f932
PE
3969 (composition_reseat_it): Remove unused locals.
3970 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3971 (composition_update_it): Mark var as initialized.
11b61122
PE
3972 (find_automatic_composition): Mark vars as initialized,
3973 with a FIXME (Bug#8290).
8f5201ae 3974
760fbc2c
PE
3975 character.h: Rename locals to avoid shadowing.
3976 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3977 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3978 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3979 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3980 to avoid shadowing.
3981
ff08eb85
PE
3982 * textprop.c (property_change_between_p): Remove; unused.
3983
fc7bf025
PE
3984 * intervals.c (interval_start_pos): Now static.
3985
235d7abc
PE
3986 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3987
44f230aa
SM
3988 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3989 Rename locals to avoid shadowing.
3e7d6594 3990
50060332
PE
3991 * sound.c (wav_play, au_play, Fplay_sound_internal):
3992 Fix pointer signedness.
d01f234b 3993 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3994 (wav_play): Initialize a variable to 0, to prevent undefined
3995 behavior (Bug#8278).
50060332 3996
c4fc4e30
PE
3997 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3998
918436ed
PE
3999 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4000
c939f91b
PE
4001 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4002 clobbering (Bug#8298).
b9c7f648
PE
4003 * sysdep.c (sys_subshell): Likewise.
4004 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4005
6bd8c144
PE
4006 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4007 This should get cleaned up, so that child_setup has the
4008 same signature on all platforms.
4009
7710357c 4010 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4011 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4012
c59da222
CY
40132011-03-22 Chong Yidong <cyd@stupidchicken.com>
4014
4015 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4016 not to be necessary, and produces flickering.
4017
66b87493
GM
40182011-03-20 Glenn Morris <rgm@gnu.org>
4019
4020 * config.in: Remove file.
4021
45b6f6d5
JB
40222011-03-20 Juanma Barranquero <lekktu@gmail.com>
4023
4024 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4025 are now in src/globals.h.
4026 (syms_of_minibuf): Remove spurious & from previous change.
4027
3ec03f7e
LL
40282011-03-20 Leo <sdl.web@gmail.com>
4029
4030 * minibuf.c (completing-read-function): New variable.
4031 (completing-read-default): Rename from completing-read.
4032 (completing-read): Call completing-read-function.
4033
b14e3e21
CY
40342011-03-19 Juanma Barranquero <lekktu@gmail.com>
4035
4036 * xfaces.c (Fx_load_color_file):
4037 Read color file from absolute filename (bug#8250).
4038
f2b726e6
JB
40392011-03-19 Juanma Barranquero <lekktu@gmail.com>
4040
4041 * makefile.w32-in: Update dependencies.
4042
09f6ff02
EZ
40432011-03-17 Eli Zaretskii <eliz@gnu.org>
4044
4045 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4046
29a6015a
PE
40472011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4048
a3a6c54e
PE
4049 Fix more problems found by GCC 4.5.2's static checks.
4050
b766f867
PE
4051 * process.c (make_serial_process_unwind, send_process_trap):
4052 (sigchld_handler): Now static.
4053
be02381c
PE
4054 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4055 That way, the code declares only the vars that it needs.
4056 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4057 * s/cygwin.h (PTY_ITERATION): Likewise.
4058 * s/darwin.h (PTY_ITERATION): Likewise.
4059 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4060
57048744
PE
4061 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4062 * process.c (allocate_pty): Don't declare stb unless it's needed.
4063
7914961c 4064 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4065 (CONSTANTLIM): Remove; unused.
4066 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4067 Define only if needed.
7914961c 4068
b3967b18
PE
4069 * unexelf.c (unexec): Name an expression,
4070 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4071 Use a different way to cause a compilation error if anyone uses
4072 n rather than nn, a way that does not involve shadowing.
73366a00 4073 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4074
29a6015a
PE
4075 * deps.mk (unexalpha.o): Remove; unused.
4076
43cfc33e 4077 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4078 * unexec.h: New file.
ce701a33
PE
4079 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4080 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4081 Depend on unexec.h.
4082 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4083 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4084 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4085 Change as necessary to match prototype in unexec.h.
ce701a33 4086
01f44d5a
PE
4087 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4088 shadowing.
4f63c6bb 4089 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4090
a6670b0b
PE
4091 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4092 Rename locals to avoid shadowing.
4093
cef2010d 4094 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4095 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4096
d4d7173a
PE
4097 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4098
f08b802a
PE
4099 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4100 warning when compiling print.c.
4101
3ddb0639
PE
4102 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4103 instead of using an uninitialized var.
5ad03b97 4104 (font_sort_entities): Mark var as initialized.
3ddb0639 4105
170a2692
PE
4106 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4107
e663c700
PE
4108 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4109 pointers to constants.
89bc529a 4110 (font_parse_fcname): Remove unused vars.
7b81e2d0 4111 (font_delete_unmatched): Now static.
ea838e10 4112 (font_get_spec): Remove; unused.
13a547c6
PE
4113 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4114 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4115 Rename or move locals to avoid shadowing.
e663c700 4116
2a80c887 4117 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4118 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4119
1384fa33 4120 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4121 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4122
8b2c52e9
PE
4123 * alloc.c (mark_backtrace): Move decl from here ...
4124 * lisp.h: ... to here, so that it can be checked.
4125
475545b5 4126 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4127 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4128 (lisp_indirect_variable): Name an expression,
4129 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4130 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4131
b1349114 4132 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4133 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4134 Use const pointer when appropriate.
b1349114 4135
a2928364
PE
4136 * lisp.h (get_system_name, get_operating_system_release):
4137 Move decls here, to check interfaces.
4138 * process.c (get_operating_system_release): Move decl to lisp.h.
4139 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4140 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4141 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4142 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4143 (Fformat_time_string, Fencode_time, Finsert_char):
4144 (Ftranslate_region_internal, Fformat):
4145 Rename or remove local vars to avoid shadowing.
9710023e 4146 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4147
a415e694
PE
4148 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4149 avoid shadowing.
4150
8ef4622d
PE
4151 * lisp.h (eassert): Check that the argument compiles, even if
4152 ENABLE_CHECKING is not defined.
4153
946f9a5b
PE
4154 * data.c (Findirect_variable): Name an expression, to avoid
4155 gcc -Wbad-function-cast warning.
112396d6 4156 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4157 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4158 (Fmake_variable_buffer_local, Fmake_local_variable):
4159 Mark variables as initialized.
52746918 4160 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4161
e5aab7e7 4162 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4163 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4164 Rename locals to avoid shadowing.
dff45157
PE
4165 (mark_stack): Move local variables into the #ifdef region where
4166 they're used.
7bc26fdb
PE
4167 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4168 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4169 needed otherwise.
4170 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4171 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4172 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4173
e5aab7e7
PE
4174 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4175 avoids undefined behavior in theory.
4176
4da60324
PE
4177 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4178
88043301
PE
4179 Use functions, not macros, for up- and down-casing (Bug#8254).
4180 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4181 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4182 to use the following functions instead of these macros.
4183 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4184 EMACS_INT, since callers assume the returned value fits in int.
4185 (upcase1): Likewise, for UPCASE_TABLE.
4186 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4187 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4188 the race-condition problem in the old DOWNCASE.
88043301 4189
19ed5445
PE
4190 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4191 Rename locals to avoid shadowing.
4192 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4193 (regex_compile, re_search_2, re_match_2_internal):
4194 Remove unused local vars.
952db0d7
PE
4195 (FREE_VAR): Rewrite so as not to use empty "else",
4196 which gcc can warn about.
da053e48 4197 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4198 (RETALLOC_IF): Define only if needed.
4199 (WORDCHAR_P): Likewise. This one is never needed, but is used
4200 only in a comment talking about a compiler bug, so put inside
4201 the #if 0 of that comment.
4202 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4203 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4204 Remove; unused.
19ed5445 4205
1f3561e4 4206 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4207 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4208 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4209
ded6f8f7
PE
4210 * search.c (simple_search): Remove unused var.
4211
dbd37a95
PE
4212 * dired.c (compile_pattern): Move decl from here ...
4213 * lisp.h: ... to here, so that it can be checked.
4214 (struct re_registers): New forward decl.
4215
7e47afad
PE
4216 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4217
85f24f61
PE
4218 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4219 All uses changed.
4220 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4221 Rename locals to avoid shadowing.
5671df8f 4222 (Fvertical_motion): Mark locals as initialized.
85f24f61 4223
181aa2be 4224 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4225 (casify_region): Mark local as initialized.
181aa2be 4226
930d429c
PE
4227 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4228
7082eac6
PE
4229 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4230 New macros, so that the caller can use some names other than
4231 gcpro1, gcpro2, etc.
4232 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4233 of the new macros.
4234 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4235 argument, for consistency with GCPRO2_VAR, etc: it is now the
4236 prefix of the variable, not the variable itself. All uses
4237 changed.
38b2c076
PE
4238 * dired.c (directory_files_internal, file_name_completion):
4239 Rename locals to avoid shadowing.
4240
15206ed9
PE
4241 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4242 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4243 dired.c's scmp function, had undefined behavior.
4244 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4245 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4246 * buffer.h: ... to here, because these macros use current_buffer,
4247 and the new implementation with inline functions needs to have
4248 current_buffer in scope now, rather than later when the macros
4249 are used.
4250 (downcase, upcase1): New static inline functions.
4251 (DOWNCASE, UPCASE1): Reimplement using these functions.
4252 This avoids undefined behavior in expressions like
4253 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4254 from race conditions in accessing the global variables
4255 case_temp1 and case_temp2.
4256 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4257 * lisp.h (case_temp1, case_temp2): Remove their decls.
4258 * character.h (ASCII_CHAR_P): Move from here ...
4259 * lisp.h: ... to here, so that the inline functions mentioned
4260 above can use them.
4261
4a6bea26
PE
4262 * dired.c (directory_files_internal_unwind): Now static.
4263
f14b7e14
PE
4264 * fileio.c (file_name_as_directory, directory_file_name):
4265 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4266 Now static.
2893f146
PE
4267 (file_name_as_directory): Use const pointers when appropriate.
4268 (Fexpand_file_name): Likewise. In particular, newdir might
4269 point at constant storage, so make it a const pointer.
fd4ead52 4270 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4271 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4272 signedness issues.
f839df0c
PE
4273 (Fset_file_times, Finsert_file_contents, auto_save_error):
4274 Rename locals to avoid shadowing.
f14b7e14 4275
5716756e 4276 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4277 (Ftry_completion, Fall_completions): Rename or remove locals
4278 to avoid shadowing.
5716756e 4279
b4c3046a
PE
4280 * marker.c (bytepos_to_charpos): Remove; unused.
4281
b45db522
PE
4282 * lisp.h (verify_bytepos, count_markers): New decls,
4283 so that gcc does not warn that these functions aren't declared.
4284
85876d07
PE
4285 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4286 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4287 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4288 (copy_text): Remove unused local var.
85876d07 4289
03d78a21 4290 * filelock.c (within_one_second): Now static.
b3dd38ab 4291 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4292
5df8f01b
PE
4293 * buffer.c (fix_overlays_before): Mark locals as initialized.
4294 (fix_start_end_in_overlays): Likewise. This function should be
4295 simplified by using pointers-to-pointers, but that's a different
4296 matter.
b1d876f1 4297 (switch_to_buffer_1): Now static.
8f54f30a
PE
4298 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4299 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4300
a70072c9 4301 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4302 Fix pointer signedness issue.
edced198
PE
4303 (sys_subshell): Mark local as volatile if checking for lint,
4304 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4305 (MAXPATHLEN): Define only if needed.
a70072c9 4306
a0977c44
PE
4307 * process.c (serial_open, serial_configure): Move decls from here ...
4308 * systty.h: ... to here, so that they can be checked.
4309
a884fdcc
PE
4310 * fns.c (get_random, seed_random): Move extern decls from here ...
4311 * lisp.h: ... to here, so that they can be checked.
4312
604efe86 4313 * sysdep.c (reset_io): Now static.
b8950c94 4314 (wait_for_termination_signal): Remove; unused.
604efe86 4315
38fc62d9
PE
4316 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4317 (copy_keymap_item, append_key, push_text_char_description):
4318 Now static.
1004a21a 4319 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4320 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4321 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4322 (describe_map_tree):
4323 Rename locals to avoid shadowing.
38fc62d9 4324
2f2650da
PE
4325 * keyboard.c: Declare functions static if they are not used elsewhere.
4326 (echo_char, echo_dash, cmd_error, top_level_2):
4327 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4328 (read_char, kbd_buffer_get_event, make_lispy_position):
4329 (make_lispy_event, make_lispy_movement, apply_modifiers):
4330 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4331 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4332 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4333 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4334 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4335
a053e86c 4336 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4337 (mark_kboards): Move decl here ...
4338 * alloc.c (mark_kboards): ... from here.
a053e86c 4339
4752793e
PE
4340 * lisp.h (force_auto_save_soon): New decl.
4341
74f10ca7 4342 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4343 (DEFINE_DUMMY_FUNCTION): New macro.
4344 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4345 Use it.
c03cd23f
PE
4346 (main): Add casts to avoid warnings
4347 if GCC considers string literals to be constants.
74f10ca7 4348
022e70d4
PE
4349 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4350
59d6fe83
PE
4351 * dbusbind.c: Pointer signedness fixes.
4352 (xd_signature, xd_append_arg, xd_initialize):
4353 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4354 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4355 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4356 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4357
78320123
PE
4358 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4359 if GCC considers string literals to be constants.
49cebcca 4360 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4361
35ac2a97
SM
43622011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4363
fb103ca9
SM
4364 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4365 (print_preprocess, print_object): New macro to fix last change.
4366
35ac2a97
SM
4367 * print.c (print_preprocess): Don't forget font objects.
4368
62973b41
JB
43692011-03-16 Juanma Barranquero <lekktu@gmail.com>
4370
4371 * emacs.c (USAGE3): Doc fixes.
4372
0e48bb22
AS
43732011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4374
4375 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4376 structure.
4377
7684e57b
JB
43782011-03-14 Juanma Barranquero <lekktu@gmail.com>
4379
4380 * lisp.h (VWindow_system, Qfile_name_history):
4381 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4382 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4383 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4384
4385 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4386 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4387
4388 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4389 * w32console.c (detect_input_pending, read_input_pending)
4390 (encode_terminal_code):
4391 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4392 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4393 (w32_system_caret_y, Qfile_name_history):
4394 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4395 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4396 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4397 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4398 * w32proc.c (Qlocal, report_file_error):
4399 * w32term.c (Vwindow_system, updating_frame):
4400 * w32uniscribe.c (initialized, uniscribe_font_driver):
4401 Remove unneeded extern declarations.
4402
2aa46d6c
CY
44032011-03-14 Chong Yidong <cyd@stupidchicken.com>
4404
c96bbc66 4405 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4406
cffc6f3b
CY
44072011-03-13 Chong Yidong <cyd@stupidchicken.com>
4408
4409 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4410 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4411 These macros can no longer be used for assignment.
4412
44f230aa
SM
4413 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4414 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4415 (record_buffer_markers, fetch_buffer_markers): New functions for
4416 recording and fetching special buffer markers.
4417 (set_buffer_internal_1, set_buffer_temp): Use them.
4418
4419 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4420
4421 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4422
4423 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4424 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4425
4426 * xdisp.c (hscroll_window_tree):
4427 (reconsider_clip_changes): Use PT instead of BUF_PT.
4428
d251f04b
EZ
44292011-03-13 Eli Zaretskii <eliz@gnu.org>
4430
4431 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4432 $(EMACS_ROOT)/lib/intprops.h.
4433
f0c77cd1
PE
44342011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4435
3eca4629
PE
4436 Fix more problems found by GCC 4.5.2's static checks.
4437
7c86ee98
PE
4438 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4439 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4440 (xg_free_frame_widgets): Make it clear that a local variable is
4441 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4442 (gdk_window_get_screen): Make it clear that this macro is needed
4443 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4444 (int_gtk_range_get_value): New function, which avoids a diagnostic
4445 from gcc -Wbad-function-cast.
4446 (xg_set_toolkit_scroll_bar_thumb): Use it.
4447 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4448 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4449 (get_utf8_string, xg_get_file_with_chooser):
4450 Rename locals to avoid shadowing.
4451 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4452
41729b81
PE
4453 * xgselect.c (xg_select): Remove unused var.
4454
f0c77cd1
PE
4455 * image.c (four_corners_best): Mark locals as initialized.
4456 (gif_load): Initialize transparent_p to zero (Bug#8238).
4457 Mark another local as initialized.
ec6cf4c6 4458 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4459
ce0ad53d 4460 * image.c (clear_image_cache): Now static.
d5d5a617 4461 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4462 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4463 (x_edge_detection): Remove unnecessary cast that
4464 gcc -Wbad-function-cast diagnoses.
2037898d 4465 (gif_load): Fix pointer signedness.
6ae141d6
PE
4466 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4467 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4468
33383987 44692011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4470
d32df629
PE
4471 Improve quality of tests for time stamp overflow.
4472 For example, without this patch (encode-time 0 0 0 1 1
4473 1152921504606846976) returns the obviously-bogus value (-948597
4474 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4475 reports time overflow. See
4476 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4477 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4478 * editfns.c: Include limits.h and intprops.h.
4479 (TIME_T_MIN, TIME_T_MAX): New macros.
4480 (time_overflow): Move earlier, to before first use.
4481 (hi_time, lo_time): New functions, for an accurate test for
4482 out-of-range times.
4483 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4484 (Fget_internal_run_time): Don't assume time_t fits in int.
4485 (make_time): Use list2 instead of Fcons twice.
4486 (Fdecode_time): More accurate test for out-of-range times.
4487 (check_tm_member): New function.
4488 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4489 (lisp_time_argument): Don't rely on undefined left-shift and
4490 right-shift behavior when checking for time stamp overflow.
8be6f318 4491
fe31d94c
PE
4492 * editfns.c (time_overflow): New function, refactoring common code.
4493 (Fformat_time_string, Fdecode_time, Fencode_time):
4494 (Fcurrent_time_string): Use it.
4495
8be6f318
PE
4496 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4497 * dired.c (make_time): Move to ...
4498 * editfns.c (make_time): ... here.
4499 * systime.h: Note the move.
4500
09d9db2c 45012011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4502
126bc0dc
YM
4503 * fringe.c (update_window_fringes): Remove unused variables.
4504
c47cbdfd
YM
4505 * unexmacosx.c (copy_data_segment): Also copy __got section.
4506 (Bug#8223)
4507
7ac80be9
EZ
45082011-03-12 Eli Zaretskii <eliz@gnu.org>
4509
c96bbc66 4510 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4511 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4512 Constify `char *' arguments and their references according to
4513 prototypes in tparam.h.
4514
ecb0f94d 4515 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4516
7ac80be9
EZ
4517 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4518 Adapt all references accordingly.
4519
4520 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4521
ef1fd07e
TT
45222011-03-11 Tom Tromey <tromey@redhat.com>
4523
4524 * buffer.c (syms_of_buffer): Remove obsolete comment.
4525
7ef4b50c
EZ
45262011-03-11 Eli Zaretskii <eliz@gnu.org>
4527
4528 * termhooks.h (encode_terminal_code): Declare prototype.
4529
4530 * msdos.c (encode_terminal_code): Don't declare prototype.
4531
4532 * term.c (encode_terminal_code): Now external again, used by
4533 w32console.c and msdos.c.
4534
44f230aa
SM
4535 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4536 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4537
4b1ec863 45382011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4539
1714f52b 4540 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4541
4b1ec863
PE
4542 * fringe.c (update_window_fringes): Mark locals as initialized
4543 (Bug#8227).
4544 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4545
524c7aa6
PE
4546 * alloc.c (mark_fringe_data): Move decl from here ...
4547 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4548 to check its interface.
4549 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4550
a5c0af81 4551 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4552 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4553 (fontset_font): Mark local as initialized.
a9a06e0b 4554 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4555
b4716021
PE
4556 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4557
811e9bac 4558 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4559 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4560 (x_own_selection, Fx_disown_selection_internal): Rename locals
4561 to avoid shadowing.
4562 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4563
7e3ab302
PE
4564 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4565 so that the caller can use some name other than gcpro1.
4566 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4567 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4568 (Fx_backspace_delete_keys_p):
4569 Use them to avoid shadowing, and rename vars to avoid shadowing.
4570 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4571 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4572 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4573 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4574 Remove unused locals.
7e3ab302
PE
4575 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4576 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4577 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4578 macros.
f78faa98 4579
e2b13473
PE
4580 * xterm.h (x_mouse_leave): New decl.
4581
77f23912
PE
4582 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4583 Remove unused functions.
cdf4ba58
PE
4584 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4585 (x_calc_absolute_position): Now static.
7411c686 4586 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4587 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4588 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4589 unless they are used.
38d0b34a
PE
4590 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4591 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4592 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4593 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4594 (x_error_catcher, x_connection_closed, x_error_handler):
4595 (x_error_quitter, xembed_send_message, x_iconify_frame):
4596 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4597 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4598 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4599
44f230aa
SM
4600 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4601 Rename or move locals to avoid shadowing.
6b463e58 4602 (tty_defined_color, merge_face_heights): Now static.
5967d051 4603 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4604 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4605 does not deduce is never used uninitialized.
73719eba
PE
4606 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4607 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4608
426994c3 4609 * terminal.c (store_terminal_param): Now static.
5489860b 4610
032f1620 4611 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4612 (set_frame_menubar): Remove unused local.
d4323972 4613 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4614 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4615 since they might point to immutable storage.
281585b0
PE
4616 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4617 since it's unused otherwise.
032f1620 4618
367c19e5 4619 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4620 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4621 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4622 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4623 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4624 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4625 does not deduce are never used uninitialized.
70739cbe 4626
07b48fa9
PE
4627 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4628
8868a238 4629 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4630 * window.c (window_loop, size_window):
4631 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4632
7e5cf297 4633 * window.c (display_buffer): Now static.
d6550a9f
PE
4634 (size_window): Mark variables that gcc -Wuninitialized
4635 does not deduce are never used uninitialized.
a586633d
PE
4636 * window.h (check_all_windows): New decl, to forestall
4637 gcc -Wmissing-prototypes diagnostic.
5b555da1 4638 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4639
f6095868
PE
4640 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4641 shadowing.
4642 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4643 Include <limits.h>.
4644 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4645 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4646 (load_charset_map): Mark variables that gcc -Wuninitialized
4647 does not deduce are never used uninitialized.
53df7c11 4648 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4649
f38b440c
PE
4650 * coding.c (coding_set_source, coding_set_destination):
4651 Use "else { /* comment */ }" rather than "else /* comment */;"
4652 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4653 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4654 a block, when the outer 'i' will do.
4655 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4656 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4657 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4658 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4659 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4660 Rename locals to avoid shadowing.
4661 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4662 * coding.c (emacs_mule_char, encode_invocation_designation):
4663 Now static, since they're not used elsewhere.
413bb2db 4664 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4665 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4666 (decode_coding_emacs_mule): Mark variables that gcc
4667 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4668 (detect_coding_iso_2022): Initialize a local variable that might
4669 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4670 this initialization is needed. (Bug#8211)
5f58e762
PE
4671 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4672 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4673 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4674 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4675 Remove unused macros.
f38b440c 4676
232b38b9 4677 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4678 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4679 * character.c (string_count_byte8): Likewise.
232b38b9 4680
fb90da1b
PE
4681 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4682 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4683
fb93dbc2
PE
4684 * chartab.c (copy_sub_char_table): Now static, since it's not used
4685 elsewhere.
5c156ace
PE
4686 (sub_char_table_ref_and_range, char_table_ref_and_range):
4687 Rename locals to avoid shadowing.
bbcd0949 4688 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4689
7d3b3862 4690 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4691 (BIDI_BOB): Remove unused macro.
7d3b3862 4692
6be7d3da
PE
4693 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4694 deduce are never used uninitialized.
c2ed9c8b 4695 * term.c (encode_terminal_code): Likewise.
6be7d3da 4696
75f8807f 4697 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4698
50938595
PE
4699 * tparam.h: New file.
4700 * term.c, tparam.h: Include it.
4701 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4702 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4703 Move these decls to tparam.h, and make them agree with what
4704 is actually in tparam.c. The previous trick of using incompatible
4705 decls in different modules does not conform to the C standard.
4706 All callers of tparam changed to use tparam's actual API.
4707 * tparam.c (tparam1, tparam, tgoto):
4708 Use const pointers where appropriate.
4709
fbceeba2
PE
4710 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4711 * cm.h (struct cm): Likewise.
4712 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4713 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4714 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4715 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4716 (turn_on_face, init_tty): Likewise.
4717 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4718
7f3f1250
PE
4719 * term.c (term_mouse_position): Rename local to avoid shadowing.
4720
e6ca6543
PE
4721 * alloc.c (mark_ttys): Move decl from here ...
4722 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4723
c40f8d15
AS
47242011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4725
4726 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4727
cfe0661d
JB
47282011-03-09 Juanma Barranquero <lekktu@gmail.com>
4729
4730 * search.c (compile_pattern_1): Remove argument regp, unused since
4731 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4732 (compile_pattern): Don't pass it.
4733
0afb4571
J
47342011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4735
4736 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4737 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4738 for ! HAVE_GTK3.
4739 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4740
4741 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4742
4743 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4744 gdk_window_get_screen, gdk_window_get_geometry,
4745 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4746 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4747 (xg_get_pixbuf_from_pixmap): New function.
4748 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4749 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4750 Call xg_get_pixbuf_from_pixmap instead of
4751 gdk_pixbuf_get_from_drawable.
4752 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4753 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4754 (xg_check_special_colors): Use GtkStyleContext and its functions
4755 for HAVE_GTK3.
4756 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4757 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4758 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4759 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4760 Call gtk_widget_get_preferred_size.
0afb4571
J
4761 (xg_frame_resized): gdk_window_get_geometry only takes 5
4762 parameters.
44f230aa
SM
4763 (xg_win_to_widget, xg_event_is_for_menubar):
4764 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4765 (xg_set_widget_bg): New function.
4766 (delete_cb): New function.
895009e1 4767 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4768 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4769 (xg_set_background_color): Call xg_set_widget_bg.
4770 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4771 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4772 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4773 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4774 if ! HAVE_GTK3.
4775 (update_frame_tool_bar): Call gtk_widget_hide.
4776 (xg_initialize): Use GDK_KEY_g.
4777
4778 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4779 if ! HAVE_GTK3
4780 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4781
4782 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4783 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4784 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4785
1c2cc4ef
JB
47862011-03-08 Juanma Barranquero <lekktu@gmail.com>
4787
4788 * w32xfns.c (select_palette): Check success of RealizePalette against
4789 GDI_ERROR, not zero.
4790
33383987 4791See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4792
4793;; Local Variables:
4794;; coding: utf-8
aac0c6e3
MR
4795;; End:
4796
33383987 4797 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4798
4799 This file is part of GNU Emacs.
4800
4801 GNU Emacs is free software: you can redistribute it and/or modify
4802 it under the terms of the GNU General Public License as published by
4803 the Free Software Foundation, either version 3 of the License, or
4804 (at your option) any later version.
4805
4806 GNU Emacs is distributed in the hope that it will be useful,
4807 but WITHOUT ANY WARRANTY; without even the implied warranty of
4808 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4809 GNU General Public License for more details.
4810
4811 You should have received a copy of the GNU General Public License
4812 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.