auth-source.el (auth-source-netrc-cache): Move forward.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7fcccf1e
PE
12011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2
7efb4e0e
PE
3 Integer and buffer overflow fixes (Bug#8873).
4
ff5844ad
PE
5 * print.c (printchar, strout): Check for string overflow.
6 (PRINTPREPARE, printchar, strout):
7 Don't set size unless allocation succeeds.
8
90532f02
PE
9 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10 for sizes. Check for string overflow more accurately.
11 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
12
6d84508d
PE
13 * macros.c: Integer and buffer overflow fixes.
14 * keyboard.h (struct keyboard.kbd_macro_bufsize):
15 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
16 Use ptrdiff_t, not int, for sizes.
17 Don't increment bufsize until after realloc succeeds.
18 Check for size-calculation overflow.
19 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
20
437b2cb4
PE
21 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
22
8b9ac8b4
PE
23 * lread.c: Integer overflow fixes.
24 (read_integer): Radix is now EMACS_INT, not int,
25 to improve quality of diagnostics for out-of-range radices.
26 Calculate buffer size correctly for out-of-range radices.
27 (read1): Check for integer overflow in radices, and in
28 read-circle numbers.
82cb60d3
PE
29 (read_escape): Avoid int overflow.
30 (Fload, openp, read_buffer_size, read1)
31 (substitute_object_recurse, read_vector, read_list, map_obarray):
32 Use ptrdiff_t, not int, for sizes.
33 (read1): Use EMACS_INT, not int, for sizes.
20270765 34 Check for size overflow.
8b9ac8b4 35
7fcccf1e
PE
36 * image.c (cache_image): Check for size arithmetic overflow.
37
bfbbd7e7
PE
38 * lread.c: Integer overflow issues.
39 (saved_doc_string_size, saved_doc_string_length)
40 (prev_saved_doc_string_size, prev_saved_doc_string_length):
41 Now ptrdiff_t, not int.
42 (read1): Don't assume doc string length fits in int. Check for
43 out-of-range doc string lengths.
44 (read_list): Don't assume file position fits in int.
39019e54 45 (read_escape): Check for hex character overflow.
bfbbd7e7 46
4e323265
LL
472011-06-22 Leo Liu <sdl.web@gmail.com>
48
49 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
50 Move to minibuffer.el.
51
85fece3e
PE
522011-06-22 Paul Eggert <eggert@cs.ucla.edu>
53
20b84ce9 54 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
55 The following patches are for when GLYPH_DEBUG && !XASSERT.
56 * dispextern.h (trace_redisplay_p, dump_glyph_string):
57 * dispnew.c (flush_stdout):
58 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
59 Mark as externally visible.
60 * dispnew.c (check_window_matrix_pointers): Now static.
61 * dispnew.c (window_to_frame_vpos):
62 * xfns.c (unwind_create_frame):
63 * xterm.c (x_check_font): Remove unused local.
64 * scroll.c (CHECK_BOUNDS):
65 * xfaces.c (cache_fache): Rename local to avoid shadowing.
66 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
67 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
68 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
69 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
70 Now static.
71 (debug_method_add): Use va_list and vsprintf rather than relying
72 on undefined behavior with wrong number of arguments.
73 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
74 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
75 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
76 since we're not interested in debugging glyphs with old libraries.
77 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
78 GCC 4.6.0's static checking.
79
0766b489
PE
802011-06-22 Paul Eggert <eggert@cs.ucla.edu>
81
31fd4b32
PE
82 Integer overflow and signedness fixes (Bug#8873).
83 A few related buffer overrun fixes, too.
84
b79e8648
PE
85 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
86
0766b489
PE
87 * dispextern.h (struct face.stipple):
88 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
89 (x_bitmap_mask, x_allocate_bitmap_record)
90 (x_create_bitmap_from_data, x_create_bitmap_from_file)
91 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
92 (x_create_bitmap_from_xpm_data):
93 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
94 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
95 (.bitmaps_last):
96 * xfaces.c (load_pixmap):
97 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
98 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
99 (.bitmaps_last, struct x_output.icon_bitmap):
100 Use ptrdiff_t, not int, for bitmap indexes.
101 (x_allocate_bitmap_record): Check for size overflow.
102 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
103
b081724f
PE
104 Use ptrdiff_t, not int, for overlay counts.
105 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
106 * editfns.c (overlays_around, get_pos_property):
107 * textprop.c (get_char_property_and_overlay):
108 * xdisp.c (next_overlay_change, note_mouse_highlight):
109 * xfaces.c (face_at_buffer_position):
21514da7
PE
110 * buffer.c (OVERLAY_COUNT_MAX): New macro.
111 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
112 (Fnext_overlay_change, Fprevious_overlay_change)
113 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 114 Use ptrdiff_t, not int, for sizes.
21514da7 115 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 116
3de73e5e
PE
117 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
118
2606c57b
PE
119 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
120 (x_session_initialize): Do not assume string length fits in int.
121
aaafe47a
PE
122 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
123 This is unlikely, but can occur if DPI is outlandish.
124
2674ddc8 125 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
126 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
127
28154962
PE
128 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
129 * xrdb.c (magic_file_p, search_magic_path):
130 Omit last arg SUFFIX; it was always 0. All callers changed.
131 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
132
7de51af5
PE
133 * xfont.c (xfont_match): Avoid need for strlen.
134
25ed6cc3
PE
135 * xfns.c: Don't assume strlen fits in int.
136 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
137
4eab31dd
PE
138 * xdisp.c (message_log_check_duplicate): Return intmax_t,
139 not unsigned long, as we prefer signed integers. All callers changed.
140 Detect integer overflow in repeat count.
141 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 142 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 143
171e2a58
PE
144 * termcap.c: Don't assume sizes fit in int and never overflow.
145 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
146 (gobble_line): Check for size-calculation overflow.
147
ad39faca 148 * minibuf.c (Fread_buffer):
6e5bb2dc 149 * lread.c (intern, intern_c_string):
74ca2eb3
PE
150 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
151 Don't assume string length fits in int.
152
52c61c22 153 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
154 * gtkutil.c (style_changed_cb): Avoid need for strlen.
155
b5b8c9e5
PE
156 * font.c: Don't assume string length fits in int.
157 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
158 Use ptrdiff_t, not int.
ccd6111c
PE
159 (font_intern_prop): Don't assume string length fits in int.
160 Don't assume integer property fits in fixnum.
161 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 162
882f0d81 163 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 164 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
165 Reformulate so as not to need the command string.
166 Invoke gzip -cd rather than gunzip, as it's more portable.
167 (lock_info_type, lock_file_1, lock_file):
168 Don't assume pid_t and time_t fit in unsigned long.
169 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
170 (current_lock_owner): Prefer signed type for sizes.
171 Use memcpy, not strncpy, where memcpy is what is really wanted.
172 Don't assume (via atoi) that time_t and pid_t fit in int.
173 Check for time_t and/or pid_t out of range, e.g., via a network share.
174 Don't alloca where an auto var works fine.
175
93f4cf88
PE
176 * fileio.c: Fix some integer overflow issues.
177 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
178 Don't assume string length fits in int.
179 (directory_file_name): Don't assume string length fits in long.
180 (make_temp_name): Don't assume pid fits in int, or that its print
181 length is less than 20.
182
f3e92b69
PE
183 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
184
1bfdaf10
PE
185 * coding.c (make_subsidiaries): Don't assume string length fits in int.
186
35016e9a
PE
187 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
188
3d1e65a1
PE
189 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
190 We prefer signed integers, even for size calculations.
191
0b963a93
PE
192 * emacs.c: Don't assume string length fits in 'int'.
193 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
194 (main): Don't invoke strlen when not needed.
195
573f4b54
PE
196 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
197 (XD_DEBUG_MESSAGE): Don't waste a byte.
198
989f33ba
PE
199 * callproc.c (getenv_internal_1, getenv_internal)
200 (Fgetenv_internal):
965d34eb
PE
201 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
202
e4d29b33
PE
203 * lread.c (invalid_syntax): Omit length argument.
204 All uses changed. This doesn't fix a bug, but it simplifies the
205 code away from its former Hollerith-constant appearance, and it's
206 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 207 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 208
eb49b136
PE
209 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
210 This didn't break anything, but it didn't help either.
211 It's confusing to put a bogus integer in a place where the actual
212 value does not matter.
9f62aeb1 213 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 214 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 215
15375a22
PE
216 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
217 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
218 implementation.
b61cc01c
PE
219 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
220 We prefer signed types, and the value cannot exceed the EMACS_INT
221 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
222 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
223 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
224 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 225
53b2623d
PE
226 * indent.c (sane_tab_width): New function.
227 (current_column, scan_for_column, Findent_to, position_indentation)
228 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 229 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 230
51cab52b 231 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 232
f2ed8a70
PE
233 * lisp.h (lint_assume): New macro.
234 * composite.c (composition_gstring_put_cache):
235 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
236
abe80cc6
PE
237 * editfns.c, insdel.c:
238 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 239
b02c740e
PE
240 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
241
ebc96716
PE
242 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
243
b4e50fa0 244 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 245 Use much-faster test for byte-length change.
311d5d7c 246 Don't assume string byte-length fits in 'int'.
a4cf38e4 247 Check that character arg fits in 'int'.
85461888 248 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 249
c0c1ee9f
PE
250 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
251
a498d7f4
PE
252 * fns.c (concat): Catch string overflow earlier.
253 Do not rely on integer wraparound.
254
51cab52b
PE
255 * dispextern.h (struct it.overlay_strings_charpos)
256 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
257 * xdisp.c (forward_to_next_line_start)
258 (back_to_previous_visible_line_start)
259 (reseat_at_next_visible_line_start, next_element_from_buffer):
260 Don't arbitrarily truncate the value of 'selective' to int.
261
76031fad
PE
262 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
263
5eb55db9
PE
264 * composite.c: Don't truncate sizes to 'int'.
265 (composition_gstring_p, composition_reseat_it)
266 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
267 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
268 not EMACS_UINT, for indexes.
5eb55db9 269
0703a717
PE
270 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
271
d6202519
PE
272 * buffer.c: Include <verify.h>.
273 (struct sortvec.priority, struct sortstr.priority):
8961a454 274 Now EMACS_INT, not int.
c20998a7 275 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
276 (struct sortstr.size, record_overlay_string)
277 (struct sortstrlist.size, struct sortlist.used):
278 Don't truncate size to int.
279 (record_overlay_string): Check for size-calculation overflow.
d6202519 280 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 281
d5a19415
JM
2822011-06-22 Jim Meyering <meyering@redhat.com>
283
284 don't leak an XBM-image-sized buffer
285 * image.c (xbm_load): Free the image buffer after using it.
286
a9041e6c
PE
2872011-06-21 Paul Eggert <eggert@cs.ucla.edu>
288
289 Port to Sun C.
290 * composite.c (find_automatic_composition): Omit needless 'return 0;'
291 that Sun C diagnosed.
292 * fns.c (secure_hash): Fix pointer signedness issue.
293 * intervals.c (static_offset_intervals): New function.
294 (offset_intervals): Use it.
295
7f3f739f
LL
2962011-06-21 Leo Liu <sdl.web@gmail.com>
297
298 * deps.mk (fns.o):
299 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
300 sha512.h.
301
302 * fns.c (secure_hash): Rename from crypto_hash_function and change
303 the first arg to accept symbols.
304 (Fsecure_hash): New primtive.
305 (syms_of_fns): New symbols.
306
76147d94
DD
3072011-06-20 Deniz Dogan <deniz@dogan.se>
308
309 * process.c (Fset_process_buffer): Clarify return value in
310 docstring.
311
7d7d0045
CY
3122011-06-18 Chong Yidong <cyd@stupidchicken.com>
313
314 * dispnew.c (add_window_display_history): Use BVAR.
315
316 * xdisp.c (debug_method_add): Use BVAR.
317 (check_window_end, dump_glyph_matrix, dump_glyph)
318 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
319
320 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
321 Likewise.
322
323 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
324 check till after the cache is created in init_frame_faces.
325
ff2bc410
SM
3262011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
327
328 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
329
28177add
PE
3302011-06-16 Paul Eggert <eggert@cs.ucla.edu>
331
dd3482fe
PE
332 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
333 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
334 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
335
393d71f3 336 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
337 * fileio.c (Finsert_file_contents):
338 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
339 Remove the old (too-loose) buffer overflow checks.
340 They weren't needed, since make_gap checks for buffer overflow.
341 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
342 The old code merely checked for Emacs fixnum overflow, and relied
343 on undefined (wraparound) behavior. The new code avoids undefined
344 behavior, and also checks for ptrdiff_t and/or size_t overflow.
345
2e6813b0 346 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
347 Tune. Don't use wider integers than needed. Don't use alloca.
348 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 349
599a9e4f
PE
350 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
351
99561444
PE
352 * insdel.c, lisp.h (buffer_overflow): New function.
353 (insert_from_buffer_1, replace_range, replace_range_2):
354 * insdel.c (make_gap_larger):
355 * editfns.c (Finsert_char):
356 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
357
28177add
PE
358 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
359
e69dafad
PE
3602011-06-15 Paul Eggert <eggert@cs.ucla.edu>
361
a7af7fde 362 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 363
b1c46f02
PE
364 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
365 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
366
e69dafad
PE
367 * fileio.c: Don't assume EMACS_INT fits in off_t.
368 (emacs_lseek): New static function.
369 (Finsert_file_contents, Fwrite_region): Use it.
370 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
371
566684ea
PE
372 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
373
e6966cd6
PE
374 * fns.c: Don't overflow int when computing a list length.
375 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
376 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
377 truncation on 64-bit hosts. Check for QUIT every
378 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
379 faster and is responsive enough.
380 (Flength): Report an error instead of overflowing an integer.
381 (Fsafe_length): Return a float if the value is not representable
382 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 383 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 384 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 385
dd0b0efb
PE
386 * alloc.c: Check that resized vectors' lengths fit in fixnums.
387 (header_size, word_size): New constants.
388 (allocate_vectorlike): Don't check size overflow here.
389 (allocate_vector): Check it here instead, since this is the only
390 caller of allocate_vectorlike that could cause overflow.
391 Check that the new vector's length is representable as a fixnum.
392
86fe5cfe
PE
393 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
394 The previous code was bogus. For example, next_almost_prime (32)
395 returned 39, which is undesirable as it is a multiple of 3; and
396 next_almost_prime (24) returned 25, which is a multiple of 5 so
397 why was the code bothering to check for multiples of 7?
398
80e88859
PE
399 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
400
4a2f0ad6
PE
401 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
402
f66c7cf8
PE
403 Variadic C functions now count arguments with ptrdiff_t.
404 This partly undoes my 2011-03-30 change, which replaced int with size_t.
405 Back then I didn't know that the Emacs coding style prefers signed int.
406 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
407 were being counted with int, which may truncate counts on 64-bit
408 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
409 * lisp.h (struct Lisp_Subr.function.aMANY)
410 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
411 Arg counts are now ptrdiff_t, not size_t.
412 All variadic functions and their callers changed accordingly.
413 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
414 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
415 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
416 * callint.c (Fcall_interactively): Check arg count for overflow,
417 to avoid potential buffer overrun. Use signed char, not 'int',
418 for 'varies' array, so that we needn't bother to check its size
419 calculation for overflow.
420 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
421 * eval.c (apply_lambda):
422 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
423 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
424 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
425
a1759b76
PE
426 * callint.c (Fcall_interactively): Don't use index var as event count.
427
d96be9fc
PE
428 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
429 * mem-limits.h (SIZE): Remove; no longer used.
430
a690a978 431 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 432
578c21e6
PE
433 Remove unnecessary casts.
434 * xterm.c (x_term_init):
435 * xfns.c (x_set_border_pixel):
436 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
437 These aren't needed now that we assume ANSI C.
438
96f53c6c
PE
439 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
440 It's more likely to cause problems (due to unsigned overflow)
441 than to cure them.
442
83c77d31
PE
443 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
444
ee2079f1
PE
445 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
446
6da65536
PE
447 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
448
7147c4a4
PE
449 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
450
193e32d9
PE
451 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
452
e5533da6
PE
453 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
454
9910e595
PE
455 GLYPH_CODE_FACE returns EMACS_INT, not int.
456 * dispextern.h (merge_faces):
457 * xfaces.c (merge_faces):
01103c44
PE
458 * xdisp.c (get_next_display_element, next_element_from_display_vector):
459 Don't assume EMACS_INT fits in int.
9910e595 460
2638320e
PE
461 * character.h (CHAR_VALID_P): Remove unused parameter.
462 * fontset.c, lisp.h, xdisp.c: All uses changed.
463
045eb8d9
PE
464 * editfns.c (Ftranslate_region_internal): Omit redundant test.
465
c1f134b5
PE
466 * fns.c (concat): Minor tuning based on overflow analysis.
467 This doesn't fix any bugs. Use int to hold character, instead
468 of constantly refetching from Emacs object. Use XFASTINT, not
469 XINT, for value known to be a character. Don't bother comparing
470 a single byte to 0400, as it's always less.
471
395fcb93 472 * floatfns.c (Fexpt):
327eeec8
PE
473 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
474
abbd3d23
PE
475 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
476 for characters.
477
684a03ef
PE
478 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
479
0fed43f3
PE
480 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
481 Without this fix, on a 64-bit host (aset S 0 4294967386) would
482 incorrectly succeed when S was a string, because 4294967386 was
483 truncated before it was used.
484
8fd02eb7
PE
485 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
486 Otherwise, an out-of-range integer could cause undefined behavior
487 on a 64-bit host.
488
f8c86b69
PE
489 * composite.c: Use int, not EMACS_INT, for characters.
490 (fill_gstring_body, composition_compute_stop_pos): Use int, not
491 EMACS_INT, for values that are known to be in character range.
492 This doesn't fix any bugs but is the usual style inside Emacs and
493 may generate better code on 32-bit machines.
494
34206dd2
PE
495 Make sure a 64-bit char is never passed to ENCODE_CHAR.
496 This is for reasons similar to the recent CHAR_STRING fix.
497 * charset.c (Fencode_char): Check that character arg is actually
498 a character. Pass an int to ENCODE_CHAR.
499 * charset.h (ENCODE_CHAR): Verify that the character argument is no
500 wider than 'int', as a compile-time check to prevent future regressions
501 in this area.
502
c5958d4c 503 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
504
505 Make sure a 64-bit char is never passed to CHAR_STRING.
506 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
507 by silently ignoring the top 32 bits, allowing some values
508 that were far too large to be valid characters.
509 * character.h: Include <verify.h>.
510 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
511 arguments are no wider than unsigned, as a compile-time check
512 to prevent future regressions in this area.
513 * data.c (Faset):
01103c44 514 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
515 (Fsubst_char_in_region):
516 * fns.c (concat):
517 * xdisp.c (decode_mode_spec_coding):
518 Adjust to CHAR_STRING's new requirement.
519 * editfns.c (Finsert_char, Fsubst_char_in_region):
520 * fns.c (concat): Check that character args are actually
521 characters. Without this test, these functions did the wrong
522 thing with wildly out-of-range values on 64-bit hosts.
523
d37ca623
PE
524 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
525 These casts should not be needed on 32-bit hosts, either.
526 * keyboard.c (read_char):
527 * lread.c (Fload): Remove casts to unsigned.
528
ea204efb
PE
529 * lisp.h (UNSIGNED_CMP): New macro.
530 This fixes comparison bugs on 64-bit hosts.
531 (ASCII_CHAR_P): Use it.
532 * casefiddle.c (casify_object):
01103c44 533 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
534 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
535 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
536 * dispextern.h (FACE_FROM_ID):
537 * keyboard.c (read_char): Use UNSIGNED_CMP.
538
41cb286c
PE
539 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
540 not to EMACS_INT, to avoid GCC warning.
541
4a1b9832
PE
542 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
543
55daad71
PE
544 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
545 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
546 isn't needed on 32-bit machines.
8f95c75c 547
01103c44
PE
548 * buffer.c (Fgenerate_new_buffer_name):
549 Use EMACS_INT for count, not int.
0ceccced 550 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
551
552 * data.c (Qcompiled_function): Now static.
553
c6f072e7
PE
554 * window.c (window_body_lines): Now static.
555
20ce5912
PE
556 * image.c (gif_load): Rename local to avoid shadowing.
557
9c4c5f81
PE
558 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
559 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
560 * alloc.c (make_save_value): Integer argument is now of type
561 ptrdiff_t, not int.
562 (mark_object): Use ptrdiff_t, not int.
563 * lisp.h (pD): New macro.
564 * print.c (print_object): Use it.
565
c0c5c8ae
PE
566 * alloc.c: Use EMACS_INT, not int, to count objects.
567 (total_conses, total_markers, total_symbols, total_vector_size)
568 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
569 (total_free_floats, total_floats, total_free_intervals)
570 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
571 Now EMACS_INT, not int. All uses changed.
572 (Fgarbage_collect): Compute overall total using a double, so that
573 integer overflow is less likely to be a problem. Check for overflow
574 when converting back to an integer.
5a25e253
PE
575 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
576 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
577 These were 'int' variables that could overflow on 64-bit hosts;
578 they were never used, so remove them instead of repairing them.
211a0b2a 579 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
580 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
581 Previously, this ceilinged at INT_MAX, but that doesn't work on
582 64-bit machines.
e46bb31a 583 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 584
c78baabf 585 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 586 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
587 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
588 when a (possibly-narrower) signed value would do just as well.
589 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 590
c9d624c6
PE
591 * alloc.c: Catch some string size overflows that we were missing.
592 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
593 for convenience in STRING_BYTES_MAX.
594 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
595 The definition here is exact; the one in lisp.h was approximate.
596 (allocate_string_data): Check for string overflow. This catches
597 some instances we weren't catching before. Also, it catches
598 size_t overflow on (unusual) hosts where SIZE_MAX <= min
599 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
600 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 601
c9d624c6
PE
602 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
603 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
604 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
605
353032ce
PE
606 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
607
2bccce07
PE
608 * alloc.c (Fmake_string): Check for out-of-range init.
609
0ac30604
SM
6102011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
611
612 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
613
c195f2de
JD
6142011-06-14 Jan Djärv <jan.h.d@swipnet.se>
615
616 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
617 xg_get_default_scrollbar_width.
618
619 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
620 (int_gtk_range_get_value): Move to the scroll bar part of the file.
621 (style_changed_cb): Call update_theme_scrollbar_width and call
622 x_set_scroll_bar_default_width and xg_frame_set_char_size for
623 all frames (Bug#8505).
624 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
625 Call gtk_window_set_resizable if HAVE_GTK3.
626 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
627 and height if HAVE_GTK3 (Bug#8505).
628 (scroll_bar_width_for_theme): New variable.
629 (update_theme_scrollbar_width): New function.
630 (xg_get_default_scrollbar_width): Move code to
631 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
632 (xg_initialize): Call update_theme_scrollbar_width.
633
634 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
635
636 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
637
e10ac9f1
MR
6382011-06-12 Martin Rudalics <rudalics@gmx.at>
639
640 * frame.c (make_frame): Call other_buffer_safely instead of
641 other_buffer.
642
643 * window.c (temp_output_buffer_show): Call display_buffer with
644 second argument Vtemp_buffer_show_specifiers and reset latter
645 immediately after the call.
646 (Vtemp_buffer_show_specifiers): New variable.
647 (auto_window_vscroll_p, next_screen_context_lines)
648 (Vscroll_preserve_screen_position): Remove leading asterisks from
649 doc-strings.
650
2d3c217e 6512011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 652
7b7f97e8 653 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
654 * buffer.c (Qclone_number): Remove for now, as it's unused.
655 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
656 (record_buffer): Remove unused local.
657 * frame.c (other_visible_frames, frame_buffer_list): Now static.
658 (set_frame_buffer_list): Remove; unused.
659 * frame.h (other_visible_frames): Remove decl.
660 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
661 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
662 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
663 if HAVE_GPM.
664 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
665 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
666 Define only if HAVE_GPM.
667 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
668 (update_hints_inhibit): Remove; never set. All uses removed.
669 * widgetprv.h (emacsFrameClassRec): Remove decl.
670 * window.c (delete_deletable_window): Now returns void, since it
671 wasn't returning anything.
672 (compare_window_configurations): Remove unused locals.
673 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
674 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
675 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
676 the same widths as pointers. This follows up on the 2011-05-06 patch.
677 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
678 * xterm.h: Likewise.
679 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
680
1384b89e
JB
6812011-06-12 Juanma Barranquero <lekktu@gmail.com>
682
683 * makefile.w32-in: Update dependencies.
684 (LISP_H): Add lib/intprops.h.
685
1100a63c
CY
6862011-06-11 Chong Yidong <cyd@stupidchicken.com>
687
688 * image.c (gif_load): Add animation frame delay to the metadata.
689 (syms_of_image): Use DEFSYM. New symbol `delay'.
690
6198ccd0
MR
6912011-06-11 Martin Rudalics <rudalics@gmx.at>
692
693 * window.c (delete_deletable_window): Re-add.
694 (Fset_window_configuration): Rewrite to handle dead buffers and
695 consequently deletable windows.
696 (window_tree, Fwindow_tree): Remove. Supply functionality in
697 window.el.
698 (compare_window_configurations): Simplify code.
699
b6e3633c
AS
7002011-06-11 Andreas Schwab <schwab@linux-m68k.org>
701
1ab0dee5
AS
702 * image.c (imagemagick_load_image): Fix type mismatch.
703 (Fimagemagick_types): Likewise.
704
b6e3633c
AS
705 * window.h (replace_buffer_in_windows): Declare.
706
9397e56f
MR
7072011-06-11 Martin Rudalics <rudalics@gmx.at>
708
709 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
710 Qclone_number. Remove external declaration of Qdelete_window.
711 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
712 code.
713 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
714 Qbuffer_list_update_hook if allowed.
715 (Fother_buffer): Rewrite doc-string. Major rewrite for new
716 buffer list implementation.
717 (other_buffer_safely): New function.
718 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
719 calls to replace_buffer_in_windows and
720 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
721 if allowed.
722 (record_buffer): Inhibit quitting and rewrite using quittable
723 functions. Run Qbuffer_list_update_hook if allowed.
724 (Frecord_buffer, Funrecord_buffer): New functions.
725 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
726 switch-to-buffer to window.el.
727 (bury-buffer): Move to window.el.
728 (Vbuffer_list_update_hook): New variable.
729
730 * lisp.h (other_buffer_safely): Add prototype in buffer.c
731 section.
732
733 * window.h (resize_frame_windows): Move up in code.
734 (Fwindow_frame): Remove EXFUN.
735 (replace_buffer_in_all_windows): Remove prototype.
736 (replace_buffer_in_windows_safely): Add prototype.
737
738 * window.c: Declare Qdelete_window static again. Move down
739 declaration of select_count.
740 (Fnext_window, Fprevious_window): Rewrite doc-strings.
741 (Fother_window): Move to window.el.
742 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
743 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
744 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
745 window.el.
746 (replace_buffer_in_windows): Implement by calling
747 Qreplace_buffer_in_windows.
748 (replace_buffer_in_all_windows): Remove with some functionality
749 moved into replace_buffer_in_windows_safely.
750 (replace_buffer_in_windows_safely): New function.
751 (select_window_norecord, select_frame_norecord): Move in front
752 of run_window_configuration_change_hook. Remove now obsolete
753 declarations.
754 (Fset_window_buffer): Rewrite doc-string. Call
755 Qrecord_window_buffer.
756 (keys_of_window): Move binding for other-window to window.el.
757
b50691aa
CY
7582011-06-11 Chong Yidong <cyd@stupidchicken.com>
759
760 * dispextern.h (struct image): Replace data member, whose int_val
761 and ptr_val fields were not used by anything, with a single
762 lisp_val object.
763
764 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
765 (gif_clear_image, gif_load, imagemagick_load_image)
766 (gs_clear_image, gs_load): Callers changed.
767
3f754b86
PE
7682011-06-10 Paul Eggert <eggert@cs.ucla.edu>
769
cca69397
PE
770 * buffer.h: Include <time.h>, for time_t.
771 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
772
109e28d0
PE
773 Fix minor problems found by static checking.
774
60737f02
PE
775 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
776
4b66faf3
PE
777 Make identifiers static if they are not used in other modules.
778 * data.c (Qcompiled_function, Qframe, Qvector):
779 * image.c (QimageMagick, Qsvg):
780 * minibuf.c (Qmetadata):
781 * window.c (resize_window_check, resize_root_window): Now static.
782 * window.h (resize_window_check, resize_root_window): Remove decls.
783
109e28d0
PE
784 * window.c (window_deletion_count, delete_deletable_window):
785 Remove; unused.
46a4ce9e
PE
786 (window_body_lines): Now static.
787 (Fdelete_other_windows_internal): Mark vars as initialized.
788 Make sure 'resize_failed' is initialized.
789 (run_window_configuration_change_hook): Rename local to avoid shadowing.
790 (resize_window_apply): Remove unused local.
791 * window.h (delete_deletable_window): Remove decl.
792
109e28d0 793 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
794 (imagemagick_load_image): Fix pointer signedness problem by changing
795 last arg from unsigned char * to char *. All uses changed.
796 Also, fix a local for similar reasons.
797 Remove unused locals. Remove locals to avoid shadowing.
798 (fn_rsvg_handle_free): Remove; unused.
799 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 800 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 801
3f754b86
PE
802 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
803
2547adb1
CY
8042011-06-10 Chong Yidong <cyd@stupidchicken.com>
805
806 * image.c (gif_load): Fix omitted cast error introduced by
807 2011-06-06 change.
808
2c8e37d4
MR
8092011-06-10 Martin Rudalics <rudalics@gmx.at>
810
811 * window.h (resize_proportionally, orig_total_lines)
812 (orig_top_line): Remove from window structure.
813 (set_window_height, set_window_width, change_window_heights)
814 (Fdelete_window): Remove prototypes.
815 (resize_frame_windows): Remove duplicate declaration.
816
440a42e3
EZ
8172011-06-10 Eli Zaretskii <eliz@gnu.org>
818
819 * window.h (resize_frame_windows, resize_window_check)
820 (delete_deletable_window, resize_root_window)
821 (resize_frame_windows): Declare prototypes.
822
823 * window.c (resize_window_apply): Make definition be "static" to
824 match the prototype.
825
562dd5e9
MR
8262011-06-10 Martin Rudalics <rudalics@gmx.at>
827
828 * window.c: Remove declarations of Qwindow_size_fixed,
829 window_min_size_1, window_min_size_2, window_min_size,
830 size_window, window_fixed_size_p, enlarge_window, delete_window.
831 Remove static from declaration of Qdelete_window, it's
832 temporarily needed by Fbury_buffer.
833 (replace_window): Don't assign orig_top_line and
834 orig_total_lines.
835 (Fdelete_window, delete_window): Remove. Window deletion is
836 handled by window.el.
837 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
838 Fdelete_window calls with calls to Qdelete_window.
839 (Fdelete_other_windows): Remove. Deleting other windows is
840 handled by window.el.
841 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
842 handled in window.el.
843 (window_min_size_2, window_min_size_1, window_min_size): Remove.
844 Window minimum sizes are handled in window.el.
845 (shrink_windows, size_window, set_window_height)
846 (set_window_width, change_window_heights, window_height)
847 (window_width, CURBEG, CURSIZE, enlarge_window)
848 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
849 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
850 handled in window.el.
851 (make_dummy_parent): Rename to make_parent_window and give it a
852 second argument horflag.
853 (make_window): Don't set resize_proportionally any more.
854 (Fsplit_window): Remove. Windows are split in window.el.
855 (save_restore_action, save_restore_orig_size)
856 (shrink_window_lowest_first, save_restore_orig_size): Remove.
857 Resize mini windows in window.el.
858 (grow_mini_window, shrink_mini_window): Implement by calling
859 Qresize_root_window_vertically, resize_window_check and
860 resize_window_apply.
861 (saved_window, Fset_window_configuration, save_window_save): Do
862 not handle orig_top_line, orig_total_lines, and
863 resize_proportionally.
864 (window_min_height, window_min_width): Move to window.el.
865 (keys_of_window): Move bindings for delete-other-windows,
866 split-window, delete-window and enlarge-window to window.el.
867
868 * buffer.c: Temporarily extern Qdelete_window.
869 (Fbury_buffer): Temporarily call Qdelete_window instead of
870 Fdelete_window (Fbury_buffer will move to window.el soon).
871
872 * frame.c (set_menu_bar_lines_1): Remove code handling
873 orig_top_line and orig_total_lines.
874
875 * dispnew.c (adjust_frame_glyphs_initially): Don't use
876 set_window_height but set heights directly.
877 (change_frame_size_1): Use resize_frame_windows.
878
879 * xdisp.c (init_xdisp): Don't use set_window_height but set
880 heights directly.
881
882 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
883 resize_frame_windows instead of change_window_heights and run
884 run_window_configuration_change_hook.
885
886 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
887 instead of change_window_heights and run
888 run_window_configuration_change_hook.
889
1a13852e
MR
8902011-06-09 Martin Rudalics <rudalics@gmx.at>
891
892 * window.c (replace_window): Rename second argument REPLACEMENT to
893 NEW. New third argument SETFLAG. Rewrite.
894 (delete_window, make_dummy_parent): Call replace_window with
895 third argument 1.
896 (window_list_1): Move down in code.
897 (run_window_configuration_change_hook): Move set_buffer part
898 before select_frame_norecord part in order to unwind correctly.
899 Rename count1 to count.
900 (recombine_windows, delete_deletable_window, resize_root_window)
901 (Fdelete_other_windows_internal)
902 (Frun_window_configuration_change_hook, make_parent_window)
903 (resize_window_check, resize_window_apply, Fresize_window_apply)
904 (resize_frame_windows, Fsplit_window_internal)
905 (Fdelete_window_internal, Fresize_mini_window_internal): New
906 functions.
907 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
908
f3d1777e
MR
9092011-06-08 Martin Rudalics <rudalics@gmx.at>
910
496e208e
MR
911 * window.h (window): Add some new members to window structure -
912 normal_lines, normal_cols, new_total, new_normal, clone_number,
913 splits, nest, prev_buffers, next_buffers.
914 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 915 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 916
f3d1777e
MR
917 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
918 Remove.
496e208e
MR
919 (make_dummy_parent): Set new members of windows structure.
920 (make_window): Move down in code. Handle new members of window
921 structure.
922 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
923 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
924 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
925 (Fset_window_prev_buffers, Fwindow_next_buffers)
926 (Fset_window_next_buffers, Fset_window_clone_number): New
927 functions.
928 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
929 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
930 Doc-string fixes.
931 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
932 Argument WINDOW can be now internal window too.
933 (Fwindow_use_time): Move up in code.
934 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
935 Rewrite doc-string.
936 (Fset_window_configuration, saved_window)
937 (Fcurrent_window_configuration, save_window_save): Handle new
938 members of window structure.
b9e809c2
MR
939 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
940 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
941 (syms_of_window): New Lisp objects Qrecord_window_buffer,
942 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
943 Qget_mru_window, Qresize_root_window,
944 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
945 Qauto_buffer_name; staticpro them.
f3d1777e 946
abde8f8c
MR
9472011-06-07 Martin Rudalics <rudalics@gmx.at>
948
949 * window.c (Fwindow_total_size, Fwindow_left_column)
950 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
951 (Fwindow_list_1): New functions.
952 (window_box_text_cols): Replace with window_body_cols.
953 (Fwindow_width, Fscroll_left, Fscroll_right): Use
954 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
955 (delete_window, Fset_window_configuration): Call
956 delete_all_subwindows with window as argument.
957 (delete_all_subwindows): Take a window as argument and not a
958 structure. Rewrite.
190b47e6
MR
959 (window_loop): Remove handling of GET_LRU_WINDOW and
960 GET_LARGEST_WINDOW.
961 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
962
963 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
964 window_box_text_cols. delete_all_subwindows now takes a
965 Lisp_Object as argument.
abde8f8c
MR
966
967 * indent.c (compute_motion, Fcompute_motion): Use
968 window_body_cols instead of window_box_text_cols.
969
fa8a67e6
MR
970 * frame.c (delete_frame): Call delete_all_subwindows with root
971 window as argument.
972
a54e3482
DC
9732011-06-07 Daniel Colascione <dan.colascione@gmail.com>
974
975 * fns.c (Fputhash): Document return value.
976
60002bf5
CY
9772011-06-06 Chong Yidong <cyd@stupidchicken.com>
978
979 * image.c (gif_load): Implement gif89a spec "no disposal" method.
980
0c671da6 9812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 982
b862a52a 983 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 984
be44ca6c
PE
985 Check for overflow when converting integer to cons and back.
986 * charset.c (Fdefine_charset_internal, Fdecode_char):
987 Use cons_to_unsigned to catch overflow.
988 (Fencode_char): Use INTEGER_TO_CONS.
989 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
990 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
991 * data.c (long_to_cons, cons_to_long): Remove.
992 (cons_to_unsigned, cons_to_signed): New functions.
993 These signal an error for invalid or out-of-range values.
994 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
995 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
996 * font.c (Ffont_variation_glyphs):
997 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
998 * lisp.h: Include <intprops.h>.
999 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1000 (cons_to_signed, cons_to_unsigned): New decls.
1001 (long_to_cons, cons_to_long): Remove decls.
1002 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1003 (Fprimitive_undo): Use CONS_TO_INTEGER.
1004 * xfns.c (Fx_window_property): Likewise.
1005 * xselect.c: Include <limits.h>.
1006 (x_own_selection, selection_data_to_lisp_data):
1007 Use INTEGER_TO_CONS.
1008 (x_handle_selection_request, x_handle_selection_clear)
1009 (x_get_foreign_selection, Fx_disown_selection_internal)
1010 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1011 (lisp_data_to_selection_data): Use cons_to_unsigned.
1012 (x_fill_property_data): Use cons_to_signed.
1013 Report values out of range.
1014
d1f3d2af
PE
1015 Check for buffer and string overflow more precisely.
1016 * buffer.h (BUF_BYTES_MAX): New macro.
1017 * lisp.h (STRING_BYTES_MAX): New macro.
1018 * alloc.c (Fmake_string):
1019 * character.c (string_escape_byte8):
1020 * coding.c (coding_alloc_by_realloc):
1021 * doprnt.c (doprnt):
1022 * editfns.c (Fformat):
1023 * eval.c (verror):
1024 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1025 since they may not be the same number.
1026 * editfns.c (Finsert_char):
1027 * fileio.c (Finsert_file_contents):
1028 Likewise for BUF_BYTES_MAX.
1029
dd52fcea
PE
1030 * image.c: Use ptrdiff_t, not int, for sizes.
1031 (slurp_file): Switch from int to ptrdiff_t.
1032 All uses changed.
1033 (slurp_file): Check that file size fits in both size_t (for
1034 malloc) and ptrdiff_t (for sanity and safety).
1035
7f9bbdbb
PE
1036 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1037 if b->modtime has its maximal value.
1038
dfe18f82
PE
1039 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1040
84acfcf0
PE
1041 Don't assume time_t can fit into int.
1042 * buffer.h (struct buffer.modtime): Now time_t, not int.
1043 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1044 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1045
ccd9a01a
PE
1046 Minor fixes for signed vs unsigned integers.
1047 * character.h (MAYBE_UNIFY_CHAR):
1048 * charset.c (maybe_unify_char):
1049 * keyboard.c (read_char, reorder_modifiers):
1050 XINT -> XFASTINT, since the integer must be nonnegative.
1051 * ftfont.c (ftfont_spec_pattern):
1052 * keymap.c (access_keymap, silly_event_symbol_error):
1053 XUINT -> XFASTINT, since the integer must be nonnegative.
1054 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1055 since it makes no difference and we prefer signed.
1056 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1057 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1058 nonnegative.
1059
d6d100dd
SM
10602011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1061
1062 * window.h (Fwindow_frame): Declare.
1063
2b6148e4
PE
10642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1065
1066 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1067 (SPARE_MEMORY): Always define.
1068 (LARGE_REQUEST): Remove.
1069 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1070
f230ecc9
MR
10712011-06-06 Martin Rudalics <rudalics@gmx.at>
1072
727e958e
MR
1073 * lisp.h: Move EXFUNS for Fframe_root_window,
1074 Fframe_first_window and Fset_frame_selected_window to window.h.
1075
1076 * window.h: Move EXFUNS for Fframe_root_window,
1077 Fframe_first_window and Fset_frame_selected_window here from
1078 lisp.h.
1079
1080 * frame.c (Fwindow_frame, Fframe_first_window)
1081 (Fframe_root_window, Fframe_selected_window)
1082 (Fset_frame_selected_window): Move to window.c.
1083 (Factive_minibuffer_window): Move to minibuf.c.
1084 (Fother_visible_frames_p): New function.
1085
1086 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1087
f230ecc9
MR
1088 * window.c (decode_window, decode_any_window): Move up in code.
1089 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1090 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1091 (Fwindow_buffer): Move up and rewrite doc-string.
1092 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1093 (Fwindow_prev): New functions.
727e958e
MR
1094 (Fwindow_frame): Move here from frame.c. Accept any window as
1095 argument.
1096 (Fframe_root_window, Fframe_first_window)
1097 (Fframe_selected_window): Move here from frame.c. Accept frame
1098 or arbitrary window as argument. Update doc-strings.
1099 (Fminibuffer_window): Move up in code.
1100 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1101 (Fset_frame_selected_window): Move here from frame.c.
1102 Marginal rewrite.
727e958e
MR
1103 (Fselected_window, select_window, Fselect_window): Move up in
1104 code. Minor doc-string fixes.
f230ecc9 1105
4d09bcf6
PE
11062011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1107
1108 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1109 Do not assume that spare memory exists; that assumption is valid
1110 only if SYSTEM_MALLOC.
1111 (LARGE_REQUEST): New macro, so that the issue of large requests
1112 is separated from the issue of spare memory.
1113
810928a2
AS
11142011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1115
172418ad
AS
1116 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1117 format. (Bug#8806)
1118
43f862f7
AS
1119 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1120
810928a2
AS
1121 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1122 before statements.
1123
a059fe24
JD
11242011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1125
1126 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1127
1128 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1129
1130 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1131 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1132
989bf368
JB
11332011-06-05 Juanma Barranquero <lekktu@gmail.com>
1134
1135 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1136
4b80f674
CY
11372011-06-04 Chong Yidong <cyd@stupidchicken.com>
1138
1139 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1140 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1141 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1142 New error handlers.
4b80f674
CY
1143 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1144 Obey Vx_select_enable_clipboard_manager. Catch errors in
1145 x_clipboard_manager_save (Bug#8779).
1146 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1147 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1148
99a33b77 11492011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1150
1151 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1152
99a33b77 11532011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1154
1155 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1156 in the current matrix if keep_current_p is non-zero.
1157
8264569d
EZ
11582011-06-04 Eli Zaretskii <eliz@gnu.org>
1159
1160 * bidi.c (bidi_level_of_next_char): Fix last change.
1161
57f97249
EZ
11622011-06-03 Eli Zaretskii <eliz@gnu.org>
1163
fec2107c 1164 Support bidi reordering of text covered by display properties.
57f97249 1165
fec2107c
EZ
1166 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1167 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1168 (bidi_cache_search, bidi_cache_iterator_state)
1169 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1170 (bidi_level_of_next_char, bidi_move_to_visually_next):
1171 Support character positions inside a run of characters covered by a
fec2107c
EZ
1172 display string.
1173 (bidi_paragraph_init, bidi_resolve_explicit_1)
1174 (bidi_level_of_next_char): Call bidi_fetch_char and
1175 bidi_fetch_char_advance instead of FETCH_CHAR and
1176 FETCH_CHAR_ADVANCE.
1177 (bidi_init_it): Initialize new members.
1178 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1179 definitions.
1180 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1181 instead of using explicit *_CHAR codes.
d6d100dd
SM
1182 (bidi_resolve_explicit, bidi_resolve_weak):
1183 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1184 bidirectional text is supported only in multibyte buffers.
1185 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1186 it to initialize the frame_window_p member of struct bidi_it.
1187 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1188 (bidi_resolve_explicit, bidi_resolve_weak)
1189 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1190 bidi_it->nchars is non-positive.
1191 (bidi_level_of_next_char): Don't try to lookup the cache for the
1192 next/previous character if nothing is cached there yet, or if we
1193 were just reseat()'ed to a new position.
c40e2fb2 1194
0e14fe90
EZ
1195 * xdisp.c (set_cursor_from_row): Set start and stop points
1196 according to the row's direction when priming the loop that looks
1197 for the glyph on which to display cursor.
1198 (single_display_spec_intangible_p): Function deleted.
1199 (display_prop_intangible_p): Reimplement to call
1200 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1201 Accept 3 additional arguments needed by handle_display_spec.
1202 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1203 values: lists, `(when COND...)' forms, etc.
1204 (single_display_spec_string_p): Support property values that are
1205 lists with the argument STRING its top-level element.
1206 (display_prop_string_p): Fix the condition for processing a
1207 property that is a list to be consistent with handle_display_spec.
fec2107c 1208 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1209 last portion of handle_display_prop.
1210 (compute_display_string_pos): Accept additional argument
1211 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1212 value of a `display' property is a "replacing spec".
1213 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1214 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1215 the display property, but just return a value indicating whether
1216 the display property will replace the characters it covers.
1217 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1218 frame_window_p members of struct bidi_it.
d6d100dd
SM
1219 (compute_display_string_pos, compute_display_string_end):
1220 New functions.
fec2107c
EZ
1221 (push_it): Accept second argument POSITION, where pop_it should
1222 jump to continue iteration.
1223 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1224
fec2107c
EZ
1225 * keyboard.c (adjust_point_for_property): Adjust the call to
1226 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1227
1228 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1229 (bidi_init_it): Update prototypes.
1230 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1231 (compute_display_string_pos, compute_display_string_end):
1232 Declare prototypes.
fec2107c
EZ
1233 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1234 EMACS_INT.
fc6f18ce 1235
40087514 12362011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1237
57f53182
PE
1238 Malloc failure behavior now depends on size of allocation.
1239 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1240 * lisp.h: Change signatures accordingly.
1241 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1242 All callers changed. (Bug#8762)
1243
1244 * gnutls.c: Use Emacs's memory allocators.
1245 Without this change, the gnutls library would invoke malloc etc.
1246 directly, which causes problems on non-SYNC_INPUT hosts, and which
1247 runs afoul of improving memory_full behavior. (Bug#8761)
1248 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1249 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1250 xfree instead of the default malloc, realloc, free.
1251 (Fgnutls_boot): No need to check for memory allocation failure,
1252 since xmalloc does that for us.
1253
ac32cd99 1254 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1255 * category.c (hash_get_category_set):
1256 * ccl.c (ccl_driver):
1257 * charset.c (Fdefine_charset_internal):
1258 * charset.h (struct charset.hash_index):
1259 * composite.c (get_composition_id, gstring_lookup_cache)
1260 (composition_gstring_put_cache):
1261 * composite.h (struct composition.hash_index):
1262 * dispextern.h (struct image.hash):
1263 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1264 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1265 (hashfn_equal, hashfn_user_defined, make_hash_table)
1266 (maybe_resize_hash_table, hash_lookup, hash_put)
1267 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1268 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1269 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1270 * image.c (make_image, search_image_cache, lookup_image)
1271 (xpm_put_color_table_h):
1272 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1273 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1274 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1275 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1276 * alloc.c (allocate_vectorlike):
1277 Check for overflow in vector size calculations.
1278 * ccl.c (ccl_driver):
1279 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1280 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1281 need to be updated by these changes.
40087514
PE
1282 * fns.c (make_hash_table, maybe_resize_hash_table):
1283 Check for integer overflow with large hash tables.
0de4bb68
PE
1284 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1285 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1286 (SXHASH_REDUCE): New macro.
1287 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1288 Use it instead of discarding useful hash info with large hash values.
1289 (sxhash_float): New function.
1290 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1291 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1292 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1293 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1294 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1295 Adjust signatures to match updated version of code.
1296 (consing_since_gc): Now EMACS_INT, since a single hash table can
1297 use more than INT_MAX bytes.
1298
698d32e2
DN
12992011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1300
1301 Make it possible to build with GCC-4.6+ -O2 -flto.
1302
1303 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1304
fd6fa53f
SM
13052011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1306
1307 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1308 Call minibuffer-inactive-mode.
1309
864db017
JB
13102011-05-31 Juanma Barranquero <lekktu@gmail.com>
1311
1312 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1313 Update dependencies.
1314
2ad0baf4
DN
13152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1316
1317 * data.c (init_data): Remove code for UTS, this system is not
1318 supported anymore.
1319
4fcc2638
DN
13202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1321
1322 Don't force ./temacs to start in terminal mode.
1323
1324 * frame.c (make_initial_frame): Initialize faces in all cases, not
1325 only when CANNOT_DUMP is defined.
1326 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1327
c56e0fd5
DN
13282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1329
1330 * dispnew.c (add_window_display_history): Use const for the string
1331 pointer. Remove declaration, not needed.
1332
333d54da 13332011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1334
55d4c1b2 1335 Use 'inline', not 'INLINE'.
333d54da 1336 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1337 * alloc.c, fontset.c (INLINE): Remove.
1338 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1339 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1340 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1341 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1342 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1343
738db178
DN
13442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1345
1346 Make it possible to run ./temacs.
1347
1348 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1349 syms_of_callproc does the same thing. Remove test for
1350 "initialized", do it in the caller.
1351 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1352
620c53a6
SM
13532011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1354
1355 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1356 (read_minibuf): Use get_minibuffer.
1357 (syms_of_minibuf): Use DEFSYM.
1358 (Qmetadata): New var.
1359 * data.c (Qbuffer): Don't make it static.
1360 (syms_of_data): Use DEFSYM.
1361
e003a292
PE
13622011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1363
1364 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1365 (CCL_CODE_MIN): New macro.
1366
ed008a6d
PE
13672011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1368
3687c2ef
PE
1369 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1370
ed008a6d
PE
1371 * eval.c (Qdebug): Now static.
1372 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1373 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1374 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1375
d66c4c7c
CY
13762011-05-29 Chong Yidong <cyd@stupidchicken.com>
1377
1378 * image.c: Various fixes to ImageMagick code comments.
1379 (Fimagemagick_types): Doc fix.
1380
5fbc2025
PE
13812011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1382
0196f88a
PE
1383 Minor fixes prompted by GCC 4.6.0 warnings.
1384
1385 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1386
5fbc2025
PE
1387 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1388 (x_clipboard_manager_save_all): Move extern decl to ...
1389 * xterm.h: ... here, so that it can be checked for consistency.
1390
1dd3c2d9
CY
13912011-05-29 Chong Yidong <cyd@stupidchicken.com>
1392
1393 * xselect.c (x_clipboard_manager_save_frame)
1394 (x_clipboard_manager_save_all): New functions.
1395 (Fx_clipboard_manager_save): Lisp function deleted.
1396
1397 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1398 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1399
1400 * xterm.h: Update prototype.
1401
5ba6571d
WX
14022011-05-28 William Xu <william.xwl@gmail.com>
1403
1404 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1405 exiting (Bug#8239).
1406
3eaff834
JM
14072011-05-28 Jim Meyering <meyering@redhat.com>
1408
e1900994 1409 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1410 * fns.c (to_uchar): Define.
1411 (crypto_hash_function): Use it to convert some newly-signed
1412 variables to unsigned, to avoid sign-extension bugs. For example,
1413 without this change, (md5 "truc") would evaluate to
1414 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1415 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1416 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1417
0f6990a7
PE
14182011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1419
1420 Integer overflow fixes.
c8a9ca5a 1421
08686060
PE
1422 * dbusbind.c: Serial number integer overflow fixes.
1423 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1424 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1425 to hold a serial number that is too large for a fixnum.
1426 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1427 Check for serial numbers out of range. Decode any serial number
59568bf0 1428 that was so large that it became a float. (Bug#8722)
08686060 1429
2d1fc3c7
PE
1430 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1431 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1432 Use XFASTINT rather than XUINT when numbers are nonnegative.
1433 (xd_append_arg, Fdbus_method_return_internal):
1434 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1435 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1436 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1437 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1438 (Bug#8722)
2d1fc3c7 1439
c8a9ca5a
PE
1440 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1441
519e1d69
PE
1442 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1443
30569699
PE
1444 ccl: add integer overflow checks
1445 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1446 (IN_INT_RANGE): New macros.
1447 (ccl_driver): Use them to check for integer overflow when
1448 decoding a CCL program. Many of the new checks are whether XINT (x)
1449 fits in int; it doesn't always, on 64-bit hosts. The new version
1450 doesn't catch all possible integer overflows, but it's an
847044ea 1451 improvement. (Bug#8719)
30569699 1452
c11285dc
PE
1453 * alloc.c (make_event_array): Use XINT, not XUINT.
1454 There's no need for unsigned here.
1455
fdccd48e
PE
1456 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1457 This follows up to the 2011-05-06 change that substituted uintptr_t
1458 for EMACS_INT. This case wasn't caught back then.
1459
37910ab2
PE
1460 Rework Fformat to avoid integer overflow issues.
1461 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1462 now (part of C89). Include <verify.h>.
1463 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1464 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1465 (Fformat): Avoid the prepass trying to compute sizes; it was only
1466 approximate and thus did not catch overflow reliably. Instead, walk
1467 through the format just once, formatting and computing sizes as we go,
1468 checking for integer overflow at every step, and allocating a larger
1469 buffer as needed. Keep track separately whether the format is
1470 multibyte. Keep only the most-recently calculated precision, rather
1471 than them all. Record whether each argument has been converted to
1472 string. Use EMACS_INT, not int, for byte and char and arg counts.
1473 Support field widths and precisions larger than INT_MAX. Avoid
1474 sprintf's undefined behavior with conversion specifications such as %#d
1475 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1476 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1477 formatting out-of-range floating point numbers with int
1478 formats. (Bug#8668)
1479
2e6578fb
PE
1480 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1481
0ae6bdee
PE
1482 * data.c: Avoid integer truncation in expressions involving floats.
1483 * data.c: Include <intprops.h>.
1484 (arith_driver): When there's an integer overflow in an expression
1485 involving floating point, convert the integers to floating point
1486 so that the resulting value does not suffer from catastrophic
1487 integer truncation. For example, on a 64-bit host (* 4
1488 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1489 Do not rely on undefined behavior after integer overflow.
1490
de883a70
PE
1491 merge count_size_as_multibyte, parse_str_to_multibyte
1492 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1493 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1494 Check for integer overflow.
1495 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1496 since it's now a duplicate of the other. This is more of
1497 a character than a buffer op, so better that it's in character.c.
1498 * fns.c, print.c: Adjust to above changes.
1499
2ff916cb
PE
15002011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1501
1502 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1503
f1b54466
PE
15042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1505
fb1ac845
PE
1506 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1507 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1508 (x_clipboard_manager_save): Now static.
1509 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1510
f1b54466
PE
1511 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1512 (crypto_hash_function): Now static.
1513 Fix pointer signedness problems. Avoid unnecessary initializations.
1514
a9f737ee
CY
15152011-05-27 Chong Yidong <cyd@stupidchicken.com>
1516
1517 * termhooks.h (Vselection_alist): Make it terminal-local.
1518
1519 * terminal.c (create_terminal): Initialize it.
1520
1521 * xselect.c: Support for clipboard managers.
1522 (Vselection_alist): Move to termhooks.h as terminal-local var.
1523 (LOCAL_SELECTION): New macro.
1524 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1525 (symbol_to_x_atom): Remove gratuitous arg.
1526 (x_handle_selection_request, lisp_data_to_selection_data)
1527 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1528 (x_own_selection, x_get_local_selection, x_convert_selection):
1529 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1530 (some_frame_on_display): Delete unused function.
1531 (Fx_own_selection_internal, Fx_get_selection_internal)
1532 (Fx_disown_selection_internal, Fx_selection_owner_p)
1533 (Fx_selection_exists_p): New optional frame arg.
1534 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1535 (x_handle_selection_clear): Don't treat other terminals with the
1536 same keyboard specially. Use the terminal-local Vselection_alist.
1537 (x_clear_frame_selections): Use Frun_hook_with_args.
1538
1539 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1540
1541 * xterm.h: Add support for those atoms.
1542
e067f0c1
CY
15432011-05-26 Chong Yidong <cyd@stupidchicken.com>
1544
1545 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1546 (converted_selections, conversion_fail_tag): New global variables.
1547 (x_selection_request_lisp_error): Free the above.
1548 (x_get_local_selection): Remove unnecessary code.
1549 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1550 of converted selections stored in converted_selections.
1551 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1552 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1553 (x_convert_selection): New function.
1554 (x_handle_selection_event): Simplify.
1555 (x_get_foreign_selection): Don't ignore incoming requests while
1556 waiting for an answer; this will fail when we implement
1557 SAVE_TARGETS, and seems unnecessary anyway.
1558 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1559 (Vx_sent_selection_functions): Doc fix.
1560
0f4aebc0
LL
15612011-05-26 Leo Liu <sdl.web@gmail.com>
1562
1563 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1564
e61124cd
YM
15652011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1566
1567 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1568
1569 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1570 for fringe update if it has periodic bitmap.
1571 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1572 and fringe_bitmap_periodic_p.
1573
1574 * fringe.c (get_fringe_bitmap_data): New function.
1575 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1576 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1577 row. Mark glyph row for fringe update if periodicity changed.
1578
1579 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1580 for fringe update unless it has periodic bitmap.
1581
f16d9837
KH
15822011-05-25 Kenichi Handa <handa@m17n.org>
1583
1584 * xdisp.c (get_next_display_element): Set correct it->face_id for
1585 a static composition.
1586
e1b90ef6
LL
15872011-05-24 Leo Liu <sdl.web@gmail.com>
1588
1589 * deps.mk (fns.o):
1590 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1591
1592 * fns.c (crypto_hash_function, Fsha1): New function.
1593 (Fmd5): Use crypto_hash_function.
1594 (syms_of_fns): Add Ssha1.
1595
7400048f
PE
15962011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1597
1598 * gnutls.c: Remove unused macros.
1599 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1600 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1601 Remove macros that are defined and never used.
1602 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1603
abb71cf4
CY
16042011-05-22 Chong Yidong <cyd@stupidchicken.com>
1605
1606 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1607 (Fx_get_selection_internal): Minor cleanup.
1608 (Fx_own_selection_internal): Rename arguments for consistency with
1609 select.el.
1610
6307db39
PE
16112011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1612
1613 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1614
f3d4e0a4
CY
16152011-05-22 Chong Yidong <cyd@stupidchicken.com>
1616
1617 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1618
4d8ade89
YM
16192011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1620
1621 * dispnew.c (scrolling_window): Don't exclude the case that the
1622 last enabled row in the desired matrix touches the bottom boundary.
1623
32078c8d
GM
16242011-05-21 Glenn Morris <rgm@gnu.org>
1625
1626 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1627 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1628 and add some more files.
32078c8d 1629
7285dc67
EZ
16302011-05-20 Eli Zaretskii <eliz@gnu.org>
1631
1632 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1633 report_file_error introduced by the change from 2011-05-07.
1634
89d1bd22
PE
16352011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1636
1637 * systime.h (Time): Define only if emacs is defined.
1638 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1639 where the include path doesn't have X11/X.h by default. See
1640 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1641
e23640bb 16422011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1643
1644 * composite.c (find_automatic_composition): Fix previous change.
1645
b9704ad9
GM
16462011-05-20 Glenn Morris <rgm@gnu.org>
1647
1648 * lisp.mk: New file, split from Makefile.in.
1649 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1650 (shortlisp): Remove.
1651 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1652
4a720484
GM
16532011-05-19 Glenn Morris <rgm@gnu.org>
1654
1655 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1656 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1657 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1658 (lisp): Set the order to that of loadup.el.
1659 (shortlisp): Make it a copy of $lisp.
1660 (SOME_MACHINE_LISP): Remove.
1661 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1662 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1663
a28d4396
KH
16642011-05-18 Kenichi Handa <handa@m17n.org>
1665
1666 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1667 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1668 (find_automatic_composition): Mostly rewrite for efficiency.
1669
a2b1fa8e
JB
16702011-05-18 Juanma Barranquero <lekktu@gmail.com>
1671
1672 * makefile.w32-in: Update dependencies.
1673
8e1f5610
CS
16742011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1675
1676 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1677 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1678
7025ee00 16792011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1680
cdfa6eab
PE
1681 Fix some integer overflow issues, such as string length overflow.
1682
06d6db33
PE
1683 * insdel.c (count_size_as_multibyte): Check for string overflow.
1684
2b4560a8
PE
1685 * character.c (lisp_string_width): Check for string overflow.
1686 Use EMACS_INT, not int, for string indexes and lengths; in
1687 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1688 the resulting string length overflows an EMACS_INT; instead,
1689 report a string overflow if no precision given. When checking for
1690 precision exhaustion, use a check that cannot possibly have
1691 integer overflow. (Bug#8675)
1692 * character.h (lisp_string_width): Adjust to new signature.
1693
cb93f9be
PE
1694 * alloc.c (string_overflow): New function.
1695 (Fmake_string): Use it. This doesn't change behavior, but saves
1696 a few bytes and will simplify future changes.
1697 * character.c (string_escape_byte8): Likewise.
1698 * lisp.h (string_overflow): New decl.
1699
1a1f3366
PE
1700 Fixups, following up to the user-interface timestamp change.
1701 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1702 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1703 * msdos.c (mouse_get_pos): Likewise.
1704 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1705 * w32gui.h (Time): Define by including "systime.h" rather than by
1706 declaring it ourselves. (Bug#8664)
1707
d4e3e4d3
PE
1708 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1709 * image.c (clear_image_cache): Likewise.
1710
f6a24d19
PE
1711 * term.c (term_mouse_position): Don't assume time_t wraparound.
1712
08dc5ae6
PE
1713 Be more systematic about user-interface timestamps.
1714 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1715 and sometimes 'EMACS_UINT', to represent these timestamps.
1716 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1717 This makes the code easier to follow, and makes it easier to catch
1718 integer overflow bugs such as Bug#8664.
1719 * frame.c (Fmouse_position, Fmouse_pixel_position):
1720 Use Time, not unsigned long, for user-interface timestamps.
1721 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1722 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1723 * keyboard.h (last_event_timestamp): Likewise.
1724 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1725 * menu.h (xmenu_show): Likewise.
1726 * term.c (term_mouse_position): Likewise.
1727 * termhooks.h (struct input_event.timestamp): Likewise.
1728 (struct terminal.mouse_position_hook): Likewise.
1729 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1730 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1731 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1732 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1733 what it was before.
1734 * menu.h, termhooks.h: Include "systime.h", for Time.
1735
8e55734a
PE
1736 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1737 Don't assume that the difference between two unsigned long values
1738 can fit into an integer. At this point, we know button_down_time
1739 <= event->timestamp, so the difference must be nonnegative, so
1740 there's no need to cast the result if double-click-time is
1741 nonnegative, as it should be; check that it's nonnegative, just in
1742 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1743 apart (about 25 days). (Bug#8664)
8e55734a 1744
841f1b75 1745 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1746 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1747
3e26f69c
PE
1748 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1749 that always fit in int. Use a sentinel instead of a counter, to
1750 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1751 * frame.h (struct frame): Use int for menu_bar_items_used
1752 instead of EMACS_INT, since it always fits in int.
3e26f69c 1753
5cc152c0
PE
1754 * menu.c (grow_menu_items): Check for int overflow.
1755
d89eb65e
PE
1756 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1757
5235bd3e
PE
1758 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1759 Before, the code was not consistent. These values cannot exceed
1760 2**31 - 1 so there's no need to make them unsigned.
1761 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1762 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1763 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1764 as modifiers.
1765 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1766
bc827e23
PE
1767 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1768 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1769 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1770 presumably because the widths might not match.
1771
78eb494e
PE
1772 * window.c (size_window): Avoid needless test at loop start.
1773
04f2d78b
CB
17742011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1775
1776 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1777
d2fc7e3d 17782011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1779
1780 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1781
d2fc7e3d 17822011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1783
1784 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1785 `width' to `bar_area_x' and `bar_area_width', respectively.
1786 (x_scroll_run): Take account of fringe background extension.
1787
04f2d78b
CB
1788 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1789 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1790 `bar_area_width', respectively.
1791 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1792 background extension.
1793
79b70037
GM
17942011-05-10 Jim Meyering <meyering@redhat.com>
1795
1796 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1797
2f142cc5
JB
17982011-05-10 Juanma Barranquero <lekktu@gmail.com>
1799
1800 * image.c (Finit_image_library): Return t for built-in image types,
1801 like pbm and xbm. (Bug#8640)
1802
57679c86
AS
18032011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1804
1805 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1806
888c9e86
EZ
18072011-05-07 Eli Zaretskii <eliz@gnu.org>
1808
b0512a1d
EZ
1809 * w32console.c (Fset_screen_color): Doc fix.
1810 (Fget_screen_color): New function.
1811 (syms_of_ntterm): Defsubr it.
1812
7285dc67
EZ
1813 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1814 unlink the temporary file if Fcall_process didn't create it in the
1815 first place.
1816 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1817 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1818 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1819 cue to call_process_cleanup not to close that handle.
1820
4d3fcc8e
BK
18212011-05-07 Ben Key <bkey76@gmail.com>
1822
1823 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1824 one of two shell specific rules, either bootstrap-temacs-CMD or
1825 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1826 to the previous implementation of the bootstrap-temacs rule.
1827 The bootstrap-temacs-CMD rule is similar to the previous
1828 implementation of the bootstrap-temacs rule except that it
1829 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1830 variable.
1831
1832 These changes, along with some changes to nt/configure.bat,
1833 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1834 earlier fix to add support for --cflags and --ldflags options
1835 that include quotes so that it works whether make uses cmd or
1836 sh as the shell.
1837
b4289b64
MA
18382011-05-06 Michael Albinus <michael.albinus@gmx.de>
1839
1840 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1841 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1842 is a constant.
1843 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1844 a string. Handle both cases.
1845 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1846 (Fdbus_register_method): Use Qinvalid_function.
1847
af4c0e28
JB
18482011-05-06 Juanma Barranquero <lekktu@gmail.com>
1849
1850 * makefile.w32-in: Update dependencies.
1851 (LISP_H): Add inttypes.h and stdin.h.
1852 (PROCESS_H): Add unistd.h.
1853
c51453d9
EZ
18542011-05-06 Eli Zaretskii <eliz@gnu.org>
1855
1856 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1857 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1858
8ff0ac3c 18592011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1860
4c4b566b
PE
1861 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1862
aab2b9b5
PE
1863 * term.c (vfatal): Remove stray call to va_end.
1864 It's not needed and the C Standard doesn't allow it here anyway.
1865
c378da0b
PE
1866 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1867 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1868
288b08c7
PE
1869 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1870 bytes.
1871
e3601888
PE
1872 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1873
db6c0e74
PE
1874 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1875
dd5963ea
PE
1876 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1877
88c9450f
PE
1878 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1879
2f9442b8
PE
1880 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1881
c032b5f8
PE
1882 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1883 * charset.c (Fdefine_charset_internal): Don't initialize
1884 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1885 32-bit int (Bug#8600).
a108c10b
PE
1886
1887 * lread.c (read_integer): Be more consistent with string-to-number.
1888 Use string_to_number to do the actual conversion; this avoids
1889 rounding errors and fixes some other screwups. Without this fix,
1890 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1891 (digit_to_number): Move earlier, for benefit of read_integer.
1892 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1893 not a digit in any supported base. (Bug#8602)
a108c10b 1894
ad5f9eea
PE
1895 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1896
aec1708a
PE
1897 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1898 to match comment at start of function. This also removes a
1899 GCC warning about overflow in a 32+64-bit port.
1900
47be4ab5
PE
1901 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1902
371cac43
PE
1903 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1904 Reported by Stefan Monnier in
1905 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1906 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1907 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1908
d01a7826
PE
1909 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1910 (EMACS_UINTPTR): Likewise, with uintptr_t.
1911
7fd47d5c
PE
1912 * lisp.h: Prefer 64-bit EMACS_INT if available.
1913 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1914 on 32-bit hosts that have 64-bit int, so that they can access
1915 large files.
122b0c86
PE
1916 However, temporarily disable this change unless the temporary
1917 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1918
8727937b
PE
1919 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1920
8ac068ac
PE
1921 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1922 This removes an assumption that EMACS_INT and long are the same
1923 width as pointers. The assumption is true for Emacs porting targets
1924 now, but we want to make other targets possible.
1925 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1926 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1927 In the rest of the code, change types of integers that hold casted
1928 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1929 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1930 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1931 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1932 No need to cast type when ORing.
1933 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1934 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1935 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1936 assume EMACS_INT is the same width as char *.
1937 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1938 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1939 Remove no-longer-needed casts.
1940 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1941 (xg_tool_bar_help_callback, xg_make_tool_item):
1942 Use EMACS_INTPTR to hold an integer
1943 that will be cast to void *; this can avoid a GCC warning
1944 if EMACS_INT is not the same width as void *.
1945 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1946 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1947 (current_message_1, set_message_1):
1948 Use a local to convert to proper width without a cast.
1949 * xmenu.c (dialog_selection_callback): Likewise.
1950
ede49d71
PE
1951 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1952 Also, don't assume VALBITS / RAND_BITS is less than 5,
1953 and don't rely on undefined behavior when shifting a 1 left into
1954 the sign bit.
1955 * lisp.h (get_random): Change signature to match.
1956
2f30ecd0
PE
1957 * lread.c (hash_string): Use size_t, not int, for hash computation.
1958 Normally we prefer signed values; but hashing is special, because
1959 it's better to use unsigned division on hash table sizes so that
1960 the remainder is nonnegative. Also, size_t is the natural width
1961 for hashing into memory. The previous code used 'int', which doesn't
1962 retain enough info to hash well into very large tables.
1963 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1964
2a866e7b
PE
1965 * dbusbind.c: Don't possibly lose pointer info when converting.
1966 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1967 Use XPNTR rather than XHASH, so that the high-order bits of
1968 the pointer aren't lost when converting through void *.
1969
51639eac
PE
1970 * eval.c (Fautoload): Don't double-shift a pointer.
1971
92394119
PE
1972 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1973
dbdb9a7c
JB
19742011-05-06 Juanma Barranquero <lekktu@gmail.com>
1975
1976 * gnutls.c (DEF_GNUTLS_FN):
1977 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1978
db7a0b4f
AS
19792011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1980
1981 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1982 marker. (Bug#8610)
1983
f7ff1b0f 19842011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1985
1986 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1987 New version that can reserve upto 2GB of heap space.
1988
f7ff1b0f 19892011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1990
1991 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1992
639c109b
TZ
19932011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1994
1995 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1996 `gnutls_certificate_set_x509_key_file'.
1997
d2127135
JB
19982011-05-05 Juanma Barranquero <lekktu@gmail.com>
1999
2000 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2001 Update dependencies.
2002
e968f4f3
JB
20032011-05-04 Juanma Barranquero <lekktu@gmail.com>
2004
2005 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2006 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2007 Remove unused parameter `fildes'.
2008 * process.c (read_process_output, send_process): Don't pass it.
2009
84d358f0
JB
20102011-05-04 Juanma Barranquero <lekktu@gmail.com>
2011
2012 Fix previous change: the library cache is defined in w32.c.
2013 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2014 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2015
0898ca10
JB
20162011-05-04 Juanma Barranquero <lekktu@gmail.com>
2017
2018 Implement dynamic loading of GnuTLS on Windows.
2019
2020 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2021 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2022 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2023 Declare.
2024
2025 * gnutls.c (Qgnutls_dll): Define.
2026 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2027 (gnutls_*): Declare function pointers.
2028 (init_gnutls_functions): New function to initialize function pointers.
2029 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2030 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2031 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2032 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2033 (emacs_gnutls_write, emacs_gnutls_read)
2034 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2035 (Fgnutls_available_p): New function.
2036 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2037 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2038 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2039
2040 * image.c: Include w32.h.
2041 (Vimage_type_cache): Delete.
2042 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2043 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2044 (w32_delayed_load): Move to w32.c.
2045
2046 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2047
2048 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2049 (w32_delayed_load): Move from image.c. When loading a library, record
2050 its filename in the :loaded-from property of the library id.
2051 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2052 Initialize and staticpro them.
2053 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2054
2055 * process.c: Include lisp.h before w32.h, not after.
2056 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2057 instead of gnutls_record_check_pending.
2058
2059 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2060
ff4de4aa
TZ
20612011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2062
2063 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2064 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2065 as passed in.
2066
abe95abb
JD
20672011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2068
2069 * xterm.c (x_set_frame_alpha): Do not set property on anything
2070 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2071
e16e55d4
JB
20722011-05-02 Juanma Barranquero <lekktu@gmail.com>
2073
2074 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2075
bafcf6a5
JB
20762011-05-02 Juanma Barranquero <lekktu@gmail.com>
2077
2078 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2079 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2080 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2081 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2082 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2083 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2084 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2085 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2086 (Qgnutls_bootprop_callbacks_verify): Make static.
2087
e7a6747f
AS
20882011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2089
19ed11ba
AS
2090 * callproc.c: Indentation fixup.
2091
e7a6747f 2092 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2093 (wait_for_termination, interruptible_wait_for_termination):
2094 Move after wait_for_termination_1.
e7a6747f 2095
1ef14cb4
LMI
20962011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2097
2098 * sysdep.c (interruptible_wait_for_termination): New function
2099 which is like wait_for_termination, but allows keyboard
2100 interruptions.
2101
2102 * callproc.c (Fcall_process): Add (:file "file") as an option for
2103 the STDOUT buffer.
2104 (Fcall_process_region): Ditto.
2105
330d880c
EZ
21062011-04-30 Eli Zaretskii <eliz@gnu.org>
2107
8db90b73
EZ
2108 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2109 rather than `XVECTOR (FOO)->size'.
2110
330d880c
EZ
2111 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2112 inttypes.h, as a gnulib replacement is used if it not available in
2113 system headers.
2114
15cbd324
EZ
21152011-04-21 Eli Zaretskii <eliz@gnu.org>
2116
2117 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2118 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2119 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2120
2121 * coding.c (coding_alloc_by_realloc): Error out if destination
2122 will grow beyond MOST_POSITIVE_FIXNUM.
2123 (decode_coding_emacs_mule): Abort if there isn't enough place in
2124 charbuf for the composition carryover bytes. Reserve an extra
2125 space for up to 2 characters produced in a loop.
2126 (decode_coding_iso_2022): Abort if there isn't enough place in
2127 charbuf for the composition carryover bytes.
2128
21292011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2130
ae940cca
EZ
2131 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2132 aborting when %lld or %lll format is passed.
2133 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2134 %llo or %llx format is passed. (Bug#8545)
2135
03ab8921
EZ
2136 * window.c (window_scroll_line_based): Use a marker instead of
2137 simple variables to record original value of point. (Bug#7952)
2138
afda1437
EZ
2139 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2140 produced by %s or %c overflows available buffer space. (Bug#8545)
2141
f76dee0c
PE
21422011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2143
2144 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2145 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2146
fdc5744d
JB
21472011-04-28 Juanma Barranquero <lekktu@gmail.com>
2148
2149 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2150
638f053a
JB
21512011-04-28 Juanma Barranquero <lekktu@gmail.com>
2152
2153 * keyboard.c (Qdelayed_warnings_hook): Define.
2154 (command_loop_1): Run `delayed-warnings-hook'
2155 if Vdelayed_warnings_list is non-nil.
2156 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2157 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2158
d178f871
EZ
21592011-04-28 Eli Zaretskii <eliz@gnu.org>
2160
2161 * doprnt.c (doprnt): Don't return value smaller than the buffer
2162 size if the message was truncated. (Bug#8545).
2163
b124fd93
JB
21642011-04-28 Juanma Barranquero <lekktu@gmail.com>
2165
2166 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2167 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2168
e810457d
PE
21692011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2170
2171 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2172
ea51cceb
JB
21732011-04-27 Juanma Barranquero <lekktu@gmail.com>
2174
2175 * makefile.w32-in: Update dependencies.
2176
94dcfacf
EZ
21772011-04-27 Eli Zaretskii <eliz@gnu.org>
2178
2179 Improve `doprnt' and its usage. (Bug#8545)
2180 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2181 `format_end'. Remove support for %l as a conversion specifier.
2182 Don't use xrealloc. Improve diagnostics when the %l size modifier
2183 is used. Update the commentary.
2184
2185 * eval.c (verror): Simplify calculation of size_t.
2186
2187 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2188 messages.
2189
f61f41d7
PE
21902011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2191
2192 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2193 change.
2194
96fb4434
PE
21952011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2196
2197 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2198 This makes this file independent of the recent pseudovector change.
2199
671875da 22002011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2201
69e9b5a3
PE
2202 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2203
b5f869a7 2204 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2205 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2206 Remove unused local.
c8926152 2207 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2208
841a1577 2209 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2210 GCC 4.6.0 optimizes based on type-based alias analysis.
2211 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2212 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2213 != &v->size, and therefore "v->size = 1; b->size = 2; return
2214 v->size;" must therefore return 1. This assumption is incorrect
2215 for Emacs, since it type-puns struct Lisp_Vector * with many other
2216 types. To fix this problem, this patch adds a new type struct
f904488f 2217 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2218 and pseudovectors, and helps optimizing compilers not get fooled
2219 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2220 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2221 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2222 the size member.
eab3844f
PE
2223 (XSETPVECTYPE): Rewrite in terms of new macro.
2224 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2225 This is a bit clearer, and further avoids the possibility of
2226 undesirable aliasing.
2227 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2228 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2229 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2230 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2231 (ASIZE): Now uses header.size rather than size.
2232 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2233 to avoid the hassle of writing XVECTOR (foo)->header.size.
2234 (struct vectorlike_header): New type.
eab3844f
PE
2235 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2236 object, to help avoid aliasing.
2237 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2238 (SUBRP): Likewise, since Lisp_Subr is a special case.
2239 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2240 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2241 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2242 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2243 changed to be "header.size" and "header.next".
2244 * buffer.h (struct buffer): Likewise.
2245 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2246 * frame.h (struct frame): Likewise.
2247 * process.h (struct Lisp_Process): Likewise.
2248 * termhooks.h (struct terminal): Likewise.
2249 * window.c (struct save_window_data, struct saved_window): Likewise.
2250 * window.h (struct window): Likewise.
2251 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2252 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2253 * buffer.c (init_buffer_once): Likewise.
2254 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2255 special case.
2256 * process.c (Fformat_network_address): Use local var for size,
2257 for brevity.
2258
0df1eac5
PE
2259 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2260
847ab9d1 2261 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2262 * data.c (atof): Remove decl; no longer used or needed.
2263 (digit_to_number): Move to lread.c.
2264 (Fstring_to_number): Use new string_to_number function, to be
2265 consistent with how the Lisp reader treats infinities and NaNs.
2266 Do not assume that floating-point numbers represent EMACS_INT
2267 without losing information; this is not true on most 64-bit hosts.
2268 Avoid double-rounding errors, by insisting on integers when
2269 parsing non-base-10 numbers, as the documentation specifies.
2270 * lisp.h (string_to_number): New decl, replacing ...
2271 (isfloat_string): Remove.
bc0a5c13 2272 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2273 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2274 appears to have been a coding error. Similarly, do not accept
2275 strings like +-1e0 as floating point numbers. Do not report
2276 overflow for integer overflows unless the base is not 10 which
2277 means we have no simple and reliable way to continue.
2278 Break out the floating-point parsing into a new
2279 function string_to_number, so that Fstring_to_number parses
2280 floating point numbers consistently with the Lisp reader.
04f2d78b 2281 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2282 (E_CHAR, EXP_INT): Remove, replacing with ...
2283 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2284 (string_to_number): New function, replacing isfloat_string.
2285 This function checks for valid syntax and produces the resulting
2286 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2287 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2288 so that overflow for non-base-10 numbers is reported only when
2289 there's no portable and simple way to convert to floating point.
452f4150 2290
67769ffc
PE
2291 * textprop.c (set_text_properties_1): Rewrite for clarity,
2292 and to avoid GCC warning about integer overflow.
2293
c20db43f
PE
2294 * intervals.h (struct interval): Use EMACS_INT for members
2295 where EMACS_UINT might cause problems. See
2296 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2297 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2298 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2299 All uses changed.
37aa2f85
PE
2300 (offset_intervals): Tell GCC not to worry about length overflow
2301 when negating a negative length.
c20db43f 2302
2538aa2f
PE
2303 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2304 (overrun_check_free): Likewise.
2305
f2d3008d
PE
2306 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2307 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2308 word size.
2309
ec8df744
PE
2310 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2311 (gnutls_make_error): Rename local to avoid shadowing.
2312 (gnutls_emacs_global_deinit): ifdef out; not used.
2313 (Fgnutls_boot): Use const for pointer to readonly storage.
2314 Comment out unused local. Fix pointer signedness problems.
2315
640ee02d
PE
2316 * lread.c (openp): Don't stuff size_t into an 'int'.
2317 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2318 about possible signed overflow.
2319
6048fb2a
PE
2320 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2321 (GDK_KEY_g): Don't define if already defined.
2322 (xg_prepare_tooltip): Avoid pointer signedness problem.
2323 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2324
fa3c87e1
PE
2325 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2326 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2327
2172544b
PE
2328 * xfns.c (Fx_window_property): Simplify a bit,
2329 to make a bit faster and to avoid GCC 4.6.0 warning.
2330 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2331
9b821a21
PE
2332 * fns.c (internal_equal): Don't assume size_t fits in int.
2333
3c616cfa
PE
2334 * alloc.c (compact_small_strings): Tighten assertion a little.
2335
c2982e87
PE
2336 Replace pEd with more-general pI, and fix some printf arg casts.
2337 * lisp.h (pI): New macro, generalizing old pEd macro to other
2338 conversion specifiers. For example, use "...%"pI"d..." rather
2339 than "...%"pEd"...".
2340 (pEd): Remove. All uses replaced with similar uses of pI.
2341 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2342 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2343 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2344 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2345 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2346 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2347 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2348 64-bit hosts.
2349 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2350 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2351 * print.c (safe_debug_print, print_object): Likewise.
2352 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2353 to int.
6f04d126
PE
2354 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2355 avoiding the 0 flag, which is not portable.
c2982e87
PE
2356 * process.c (Fmake_network_process): Use pI to avoid cast.
2357 * region-cache.c (pp_cache): Likewise.
2358 * xdisp.c (decode_mode_spec): Likewise.
2359 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2360 behavior on 64-bit hosts with printf arg.
6f04d126 2361 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2362 (x_stop_queuing_selection_requests): Likewise.
2363 (x_get_window_property): Don't truncate byte count to an 'int'
2364 when tracing.
0b432f21 2365
5e073ec7
PE
2366 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2367 here, since it parses constructs like leading '-' and spaces,
2368 which are not wanted; and it overflows with large numbers.
2369 Instead, simply match F[0-9]+, which is what is wanted anyway.
2370
36372bf9
PE
2371 * alloc.c: Remove unportable assumptions about struct layout.
2372 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2373 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2374 (allocate_vectorlike, make_pure_vector): Use the new macros,
2375 plus offsetof, to remove unportable assumptions about struct layout.
2376 These assumptions hold on all porting targets that I know of, but
2377 they are not guaranteed, they're easy to remove, and removing them
2378 makes further changes easier.
2379
0b432f21
PE
2380 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2381 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2382 (string_overrun_cookie): Now const. Use initializers that
2383 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2384 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2385 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2386 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2387 multiple of sizeof (EMACS_INT); it need not be, if
2388 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2389 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2390
895009e1
JB
23912011-04-26 Juanma Barranquero <lekktu@gmail.com>
2392
2393 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2394
6a7a1b0b
TZ
23952011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2396
2397 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2398 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2399 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2400
841a1577 24012011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2402
2403 * lisp.h (Qdebug): List symbol.
895009e1 2404 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2405 * keyboard.c (debug-on-event): New variable.
2406 (handle_user_signal): Break into debugger when debug-on-event
2407 matches the current signal symbol.
2408
f2d3ba6f
DN
24092011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2410
2411 * alloc.c (check_sblock, check_string_bytes)
2412 (check_string_free_list): Convert to standard C.
2413
42ce4c63
TZ
24142011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2415
2416 * w32.c (emacs_gnutls_push): Fix typo.
2417
825cd63c
EZ
24182011-04-25 Eli Zaretskii <eliz@gnu.org>
2419
fb11d64d
EZ
2420 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2421 "cast to pointer from integer of different size".
2422
825cd63c
EZ
2423 Improve doprnt and its use in verror. (Bug#8545)
2424 * doprnt.c (doprnt): Document the set of format control sequences
2425 supported by the function. Use SAFE_ALLOCA instead of always
2426 using `alloca'.
2427
2428 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2429 is one byte too soon. Don't use xrealloc; instead xfree and
2430 xmalloc anew.
2431
e061a11b
TZ
24322011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2433
2434 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2435 callbacks stage.
2436
2437 * gnutls.c: Renamed global_initialized to
2438 gnutls_global_initialized. Added internals for the
2439 :verify-hostname-error, :verify-error, and :verify-flags
2440 parameters of `gnutls-boot' and documented those parameters in the
2441 docstring. Start callback support.
2442 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2443 unless a fatal error occured. Call gnutls_alert_send_appropriate
2444 on error. Return error code.
2445 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2446 (emacs_gnutls_read): Likewise.
2447 (Fgnutls_boot): Return handshake error code.
2448 (emacs_gnutls_handle_error): New function.
2449 (wsaerror_to_errno): Likewise.
2450
2451 * w32.h (emacs_gnutls_pull): Add prototype.
2452 (emacs_gnutls_push): Likewise.
2453
2454 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2455 (emacs_gnutls_push): Likewise.
2456
24572011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2458
2459 * process.c (wait_reading_process_output): Check if GnuTLS
2460 buffered some data internally if no FDs are set for TLS
2461 connections.
2462
2463 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2464 (LIBS): Link to USER_LIBS.
2465 ($(BLD)/gnutls.$(0)): New target.
2466
fa6996bc
EZ
24672011-04-24 Eli Zaretskii <eliz@gnu.org>
2468
eb35682e
EZ
2469 * xdisp.c (handle_single_display_spec): Rename the
2470 display_replaced_before_p argument into display_replaced_p, to
2471 make it consistent with the commentary. Fix typos in the
2472 commentary.
2473
e2ad650c
EZ
2474 * textprop.c (syms_of_textprop): Remove dead code.
2475 (copy_text_properties): Delete obsolete commentary about an
2476 interface that was deleted long ago. Fix typos in the description
2477 of arguments.
2478
1b2de274
EZ
2479 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2480 to changes in oldXMenu/XMenu.h from 2011-04-16.
2481 <menu_help_message, prev_menu_help_message>: Constify.
2482 (IT_menu_make_room): menu->help_text is now `const char **';
2483 adjust.
2484
2485 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2486 to changes in oldXMenu/XMenu.h from 2011-04-16.
2487 (struct XMenu): Declare `help_text' `const char **'.
2488
2489 * xfaces.c <Qunspecified>: Make extern again.
2490
2491 * syntax.c: Include sys/types.h before including regex.h, as
2492 required by Posix.
2493
762b15be
EZ
2494 * doc.c (get_doc_string): Improve the format passed to `error'.
2495
2496 * doprnt.c (doprnt): Improve commentary.
2497
2498 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2499
2500 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2501 them with etags.
2502
f1052e5d
EZ
2503 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2504 changes in globals.h immediately force recompilation.
762b15be
EZ
2505 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2506 $(CURDIR)/s/ms-w32.h.
2507 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2508
fa6996bc
EZ
2509 * character.c (Fchar_direction): Function deleted.
2510 (syms_of_character): Don't defsubr it.
2511 <char-direction-table>: Deleted.
2512
e6c3da20
EZ
25132011-04-23 Eli Zaretskii <eliz@gnu.org>
2514
2515 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2516 * doprnt.c: Include limits.h.
2517 (SIZE_MAX): New macro.
04f2d78b
CB
2518 (doprnt): Return a size_t value. 2nd arg is now size_t.
2519 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2520 Improve overflow protection. Support `l' modifier for integer
2521 conversions. Support %l conversion. Don't assume an EMACS_INT
2522 argument for integer conversions and for %c.
2523
2524 * lisp.h (doprnt): Restore prototype.
2525
2526 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2527 $(SRC)/character.h.
2528
2529 * Makefile.in (base_obj): Add back doprnt.o.
2530
2531 * deps.mk (doprnt.o): Add back prerequisites.
2532 (callint.o): Depend on character.h.
2533
2534 * eval.c (internal_lisp_condition_case): Include the handler
2535 representation in the error message.
2536 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2537 when breaking from the loop.
2538
2539 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2540
2541 * callint.c (Fcall_interactively): When displaying error message
2542 about invalid control letter, pass the character's codepoint, not
2543 a pointer to its multibyte form. Improve display of the character
2544 in octal and display also its hex code.
2545
2546 * character.c (char_string): Use %x to display the (unsigned)
2547 codepoint of an invalid character, to avoid displaying a bogus
2548 negative value.
2549
2550 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2551 `error', not SYMBOL_NAME itself.
2552
2553 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2554 character arguments to `error'.
2555
2556 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2557 to `error' in error message about FINAL_CHAR argument. Make sure
2558 FINAL_CHAR is a character, and use %c when it is passed as
2559 argument to `error'.
2560
4ffd0d6b 25612011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2562
2563 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2564
2565 * w32.c: Include <time.h>.
2566 (sys_localtime): New function.
2567
4ffd0d6b 25682011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2569
2570 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2571
4ffd0d6b 2572 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2573
4ffd0d6b 25742011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2575
4ffd0d6b
GM
2576 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2577 zombies (Bug#8467).
aac0c6e3 2578
04c56954
EZ
25792011-04-19 Eli Zaretskii <eliz@gnu.org>
2580
2581 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2582 gl_state.e_property when gl_state.object is Qt.
2583
2584 * insdel.c (make_gap_larger): Remove limitation of buffer size
2585 to <= INT_MAX.
2586
16a43933
CY
25872011-04-18 Chong Yidong <cyd@stupidchicken.com>
2588
2589 * xdisp.c (lookup_glyphless_char_display)
2590 (produce_glyphless_glyph): Handle cons cell entry in
2591 glyphless-char-display.
2592 (Vglyphless_char_display): Document it.
2593
2594 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2595 glyphless-char-display.
2596
4581706e
CY
25972011-04-17 Chong Yidong <cyd@stupidchicken.com>
2598
2599 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2600
2601 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2602
2603 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2604 definition for no-X builds.
2605
4887c6e2 26062011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2607
fd35b6f9
PE
2608 Static checks with GCC 4.6.0 and non-default toolkits.
2609
5c1ccb01
PE
2610 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2611
006c5daa
PE
2612 * process.c (keyboard_bit_set): Define only if SIGIO.
2613 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2614 (send_process): Repair possible setjmp clobbering.
2615
efc736d3
PE
2616 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2617
4e2fe2e6
PE
2618 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2619
f97334a2
PE
2620 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2621
4e75f29d
PE
2622 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2623 Define only if needed.
2624
90efadd1
PE
2625 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2626 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2627 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2628
3c647824
PE
2629 * dispextern.h (struct redisplay_interface): Rename param
2630 to avoid shadowing.
e264f262 2631 * termhooks.h (struct terminal): Likewise.
761383f4 2632 * xterm.c (xembed_send_message): Likewise.
3c647824 2633
b58c5c4a
PE
2634 * insdel.c (make_gap_smaller): Define only if
2635 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2636
cad59032
PE
2637 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2638 it.
2639
c339dc2e
PE
2640 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2641 so that we aren't warned about unused symbols.
2642
91a3e27b
PE
2643 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2644
399c71d3 2645 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2646
8ffc96f5
PE
2647 * xfns.c (x_real_positions): Mark locals as initialized.
2648
eef9bc79
PE
2649 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2650
098db9dd
PE
2651 * xterm.c: Fix problems found by static analysis with other toolkits.
2652 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2653 (x_dispatch_event): Declare static if USE_GTK, and
2654 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2655 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2656 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2657 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2658 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2659
eb18f6cc
PE
2660 * xmenu.c (menu_help_callback): Pointer type fixes.
2661 Use const pointers when pointing at readonly data. Avoid pointer
2662 signedness clashes.
2663 (FALSE): Remove unused macro.
2664 (update_frame_menubar): Remove unused decl.
2665
1fe72bf8
PE
2666 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2667
60d9e1db
PE
2668 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2669 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2670 (single_menu_item): Rename local to avoid shadowing.
2671
39261c26
PE
2672 * keyboard.c (make_lispy_event): Remove unused local var.
2673
018c5e19
PE
2674 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2675 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2676
63d2b86e
PE
2677 * bitmaps: Change bitmaps from unsigned char back to the X11
2678 compatible char. Avoid the old compiler warnings about
2679 out-of-range initializers by using, for example, '\xab' rather
2680 than 0xab.
2681
aefd87e1
PE
2682 * xgselect.c (xgselect_initialize): Check vs interface
2683 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2684
bf501fb9
PE
2685 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2686
e9829fdf
PE
2687 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2688 to read-only memory.
2689
1086c095
PE
2690 * fns.c (vector): Remove; this old hack is no longer needed.
2691
2baccd04 2692 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2693 Remove unused var.
dde42981 2694 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2695
72391843 2696 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2697
436c16df 2698 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2699 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2700 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2701
92bb796d 2702 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2703 (x_term_init): Remove local to avoid shadowing.
92bb796d 2704
764430a3 2705 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2706
2707 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2708 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2709
d1dfb56c
EZ
27102011-04-16 Eli Zaretskii <eliz@gnu.org>
2711
c4354cb4
EZ
2712 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2713
d1dfb56c
EZ
2714 Fix regex.c, syntax.c and friends for buffers > 2GB.
2715 * syntax.h (struct gl_state_s): Declare character position members
2716 EMACS_INT.
2717
2718 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2719
04f2d78b
CB
2720 * textprop.c (verify_interval_modification, interval_of):
2721 Declare arguments EMACS_INT.
d1dfb56c
EZ
2722
2723 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2724 EMACS_INT.
2725
2726 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2727
2728 * indent.c (Fvertical_motion): Local variable it_start is now
2729 EMACS_INT.
2730
2731 * regex.c (re_match, re_match_2, re_match_2_internal)
2732 (bcmp_translate, regcomp, regexec, print_double_string)
2733 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2734 (re_compile_pattern, re_exec): Declare arguments and local
2735 variables `size_t' and `ssize_t' and return values `regoff_t', as
2736 appropriate.
2737 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2738 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2739 <compile_stack_type>: `size' and `avail' are now `size_t'.
2740
2741 * regex.h <regoff_t>: Use ssize_t, not int.
2742 (re_search, re_search_2, re_match, re_match_2): Arguments that
2743 specify buffer/string position and length are now ssize_t and
2744 size_t. Return type is regoff_t.
2745
613052cd
BK
27462011-04-16 Ben Key <bkey76@gmail.com>
2747
2748 * nsfont.m: Fixed bugs in ns_get_family and
2749 ns_descriptor_to_entity that were caused by using free to
2750 deallocate memory blocks that were allocated by xmalloc (via
2751 xstrdup). This caused Emacs to crash when compiled with
2752 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2753 --enable-checking=xmallocoverrun). xfree is now used to
2754 deallocate these memory blocks.
2755
4170f62f 27562011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2757
71b41406
PE
2758 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2759
9587a89d
PE
2760 emacs_write: Accept and return EMACS_INT for sizes.
2761 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2762 et seq.
2763 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2764 Accept and return EMACS_INT.
2765 (emacs_gnutls_write): Return the number of bytes written on
2766 partial writes.
2767 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2768 (emacs_read, emacs_write): Remove check for negative size, as the
2769 Emacs source code has been audited now.
9587a89d
PE
2770 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2771 (emacs_read, emacs_write): Use it.
273a5f82
PE
2772 * process.c (send_process): Adjust to the new signatures of
2773 emacs_write and emacs_gnutls_write. Do not attempt to store
2774 a byte offset into an 'int'; it might overflow.
9587a89d 2775 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2776
3e047f51
PE
2777 * sound.c: Don't assume sizes fit in 'int'.
2778 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2779 Return EMACS_INT, not int.
3e047f51 2780 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2781 Accept EMACS_INT, not int.
2782 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2783 record read return values.
2784
cc39a9db
BK
27852011-04-15 Ben Key <bkey76@gmail.com>
2786
c9d0ec6d
JB
2787 * keyboard.c (Qundefined): Don't declare static since it is used
2788 in nsfns.m.
2789 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2790 static since they are used in nsfont.m.
cc39a9db 2791
6c60eb9f
SM
27922011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2793
2794 * process.c (Qprocessp): Don't declare static.
2795 * lisp.h (Qprocessp): Declare again.
2796
7990b61a
JB
27972011-04-15 Juanma Barranquero <lekktu@gmail.com>
2798
2799 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2800
5d4cb038
PE
28012011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2802
8bd7b830 2803 Improve C-level modularity by making more things 'static'.
cd64ea1d 2804
e3b27b31
PE
2805 Don't publish debugger-only interfaces to other modules.
2806 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2807 (verify_bytepos, count_markers): Move decls to the only modules
2808 that need them.
2809 * region-cache.h (pp_cache): Likewise.
2810 * window.h (check_all_windows): Likewise.
2811 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2812
5d4cb038
PE
2813 * sysdep.c (croak): Now static, if
2814 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2815 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2816
2817 * alloc.c (refill_memory_reserve): Now static if
2818 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2819 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2820
e87b6180
PE
2821 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2822 Define only if USE_LUCID.
2823
ac64929e
PE
2824 * xrdb.c (x_customization_string, x_rm_string): Now static.
2825
6f37259d
PE
2826 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2827 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2828
1683e3ab
PE
2829 * xdisp.c (draw_row_with_mouse_face): Now static.
2830 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2831
de9c2632
PE
2832 * window.h (check_all_windows): Mark externally visible.
2833
2b96acb7
PE
2834 * window.c (window_deletion_count): Now static.
2835
2836 * undo.c: Make symbols static if they're not exported.
2837 (last_undo_buffer, last_boundary_position, pending_boundary):
2838 Now static.
2839
50436f33
PE
2840 * textprop.c (interval_insert_behind_hooks): Now static.
2841 (interval_insert_in_front_hooks): Likewise.
2842
64520e5c
PE
2843 * term.c: Make symbols static if they're not exported.
2844 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2845 (max_frame_lines, tty_set_terminal_modes):
2846 (tty_reset_terminal_modes, tty_turn_off_highlight):
2847 (get_tty_terminal): Now static.
2848 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2849 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2850 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2851 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2852 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2853
1fa53021
PE
2854 * sysdep.c: Make symbols static if they're not exported.
2855 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2856 Now static.
2857 (sigprocmask_set, full_mask): Remove; unused.
2858 (wait_debugging): Mark as visible.
2859 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2860 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2861
d4b43b22
PE
2862 * syntax.c (syntax_temp): Define only if !__GNUC__.
2863
b7c513d0
PE
2864 * sound.c (current_sound_device, current_sound): Now static.
2865
989b29ad
PE
2866 * search.c (searchbufs, searchbuf_head): Now static.
2867
13a55a78
PE
2868 * scroll.c (scroll_cost): Remove; unused.
2869 * dispextern.h (scroll_cost): Remove decl.
2870
de68a1fc
PE
2871 * region-cache.h (pp_cache): Mark as externally visible.
2872
40ccffa6
PE
2873 * process.c: Make symbols static if they're not exported.
2874 (process_tick, update_tick, create_process, chan_process):
2875 (Vprocess_alist, proc_buffered_char, datagram_access):
2876 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2877 (deactivate_process): Mark defn as static, as well as decl.
2878 * lisp.h (create_process): Remove decl.
2879 * process.h (chan_process, Vprocess_alist): Remove decls.
2880
ad64fc97
PE
2881 * print.c: Make symbols static if they're not exported.
2882 (print_depth, new_backquote_output, being_printed, print_buffer):
2883 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2884 (print_interval, print_number_index, initial_stderr_stream):
2885 Now static.
2886 * lisp.h (Fprinc): Remove decl.
2887 (debug_output_compilation_hack): Mark as externally visible.
2888
adddb265
PE
2889 * sysdep.c (croak): Move decl from here to syssignal.h.
2890 * syssignal.h (croak): Put it here, so the API can be checked when
2891 'croak' is called from dissociate_if_controlling_tty.
2892
1717ede2
PE
2893 * minibuf.c: Make symbols static if they're not exported.
2894 (minibuf_save_list, choose_minibuf_frame): Now static.
2895 * lisp.h (choose_minibuf_frame): Remove decl.
2896
fa5fb2bc
PE
2897 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2898
1e3890d1
PE
2899 * lread.c: Make symbols static if they're not exported.
2900 (read_objects, initial_obarray, oblookup_last_bucket_number):
2901 Now static.
2902 (make_symbol): Remove; unused.
2903 * lisp.h (initial_obarray, make_symbol): Remove decls.
2904
8a1414fa
PE
2905 * keyboard.c: Make symbols static if they're not exported.
2906 (single_kboard, recent_keys_index, total_keys, recent_keys):
2907 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2908 (this_single_command_key_start, echoing, last_auto_save):
2909 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2910 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2911 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2912 (Vlispy_mouse_stem, double_click_count):
2913 Now static.
2914 (force_auto_save_soon): Define only if SIGDANGER.
2915 (ignore_mouse_drag_p): Now static if
2916 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2917 (print_help): Remove; unused.
2918 (stop_character, last_timer_event): Mark as externally visible.
2919 * keyboard.h (ignore_mouse_drag_p): Declare only if
2920 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2921 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2922 * lisp.h (echoing): Remove decl.
2923 (force_auto_save_soon): Declare only if SIGDANGER.
2924 * xdisp.c (redisplay_window): Simplify code, to make it more
2925 obvious that ignore_mouse_drag_p is not accessed if !defined
2926 USE_GTK && !defined HAVE_NS.
2927
93ea6e8f
PE
2928 * intervals.c: Make symbols static if they're not exported.
2929 (merge_properties_sticky, merge_interval_right, delete_interval):
2930 Now static.
2931 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2932
77382fcc
PE
2933 * insdel.c: Make symbols static if they're not exported.
2934 However, leave prepare_to_modify_buffer alone. It's never
2935 called from outside this function, but that appears to be a bug.
2936 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2937 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2938 (adjust_after_replace_noundo): Remove; unused.
2939 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2940 (signal_before_change): Remove decls.
77382fcc 2941
9306c32e
PE
2942 * indent.c (val_compute_motion, val_vmotion): Now static.
2943
cd44d2eb
PE
2944 * image.c: Make symbols static if they're not exported.
2945 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2946 if USE_GTK.
2947 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2948 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2949
ad9a7a06
PE
2950 * fringe.c (standard_bitmaps): Now static.
2951 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2952
81626931
PE
2953 * frame.c: Make symbols static if they're not exported.
2954 (x_report_frame_params, make_terminal_frame): Now static.
2955 (get_frame_param): Now static, unless HAVE_NS.
2956 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2957 (x_get_resource_string): Remove; not used.
2958 * frame.h (make_terminal_frame, x_report_frame_params):
2959 (x_get_resource_string); Remove decls.
2960 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2961 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2962
239f9db9
PE
2963 * font.c, fontset.c: Make symbols static if they're not exported.
2964 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2965 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2966 * font.c (font_close_object): Now static.
2967 * font.h (font_close_object): Remove.
2968 * fontset.c (FONTSET_OBJLIST): Remove.
2969 (free_realized_fontset) #if-0 the body, which does nothing.
2970 (face_suitable_for_char_p): #if-0, as it's never called.
2971 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2972 * xfaces.c (face_at_string_position):
2973 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2974 since 0 is always ASCII.
2975
dfcf3579
PE
2976 * fns.c (weak_hash_tables): Now static.
2977
5045092b
PE
2978 * fileio.c: Make symbols static if they're not exported.
2979 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2980 (Vwrite_region_annotation_buffers): Now static.
2981
57a96f5c
PE
2982 * eval.c: Make symbols static if they're not exported.
2983 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2984 * lisp.h (backtrace_list): Remove decl.
2985
35f08c38
PE
2986 * emacs.c: Make symbols static if they're not exported.
2987 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2988 (fatal_error_code, fatal_error_signal_hook, standard_args):
2989 Now static.
2990 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2991 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2992 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2993 * lisp.h (fatal_error_signal_hook): Remove decl.
2994 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2995
f44bd759
PE
2996 * editfns.c: Move a (normally-unused) function to its only use.
2997 * editfns.c, lisp.h (get_operating_system_release): Remove.
2998 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2999 worth the hassle of breaking this out.
3000
b532497d
PE
3001 * xterm.c: Make symbols static if they're not exported.
3002 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3003 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3004 (x_destroy_window, x_delete_display):
3005 Now static.
3006 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3007 (x_mouse_leave): Remove; unused.
3008 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3009 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3010 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3011 Remove decls.
3012 (x_mouse_leave): Declare only if WINDOWSNT.
3013 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3014 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3015 USE_X_TOOLKIT.
3016
1675728f
PE
3017 * ftxfont.c: Make symbols static if they're not exported.
3018 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3019 HAVE_FREETYPE.
3020 * font.h (ftxfont_driver): Likewise.
3021
e4cebfca
PE
3022 * xfns.c: Make symbols static if they're not exported.
3023 (x_last_font_name, x_display_info_for_name):
3024 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3025 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3026 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3027 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3028 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3029 (last_show_tip_args): Now static.
3030 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3031 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3032 (x_screen_planes): Remove; unused.
3033 * dispextern.h (x_screen_planes): Remove decl.
3034
5bf46f05
PE
3035 * dispnew.c: Make symbols static if they're not exported.
3036 * dispextern.h (redraw_garbaged_frames, scrolling):
3037 (increment_row_positions): Remove.
3038 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3039 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3040 Now static.
3041 (redraw_garbaged_frames): Remove; unused.
3042
435f4c28
PE
3043 * xfaces.c: Make symbols static if they're not exported.
3044 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3045 Remove decls.
3046 * xterm.h (defined_color): Remove decls.
3047 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3048 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3049 (menu_face_changed_default, defined_color, free_realized_face):
3050 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3051 (ascii_face_of_lisp_face): Remove; unused.
3052
8524aef3
PE
3053 * xdisp.c: Make symbols static if they're not exported.
3054 * dispextern.h (scratch_glyph_row, window_box_edges):
3055 (glyph_to_pixel_coords, set_cursor_from_row):
3056 (get_next_display_element, set_iterator_to_next):
3057 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3058 (show_mouse_face): Remove decls
3059 * frame.h (message_buf_print): Likewise.
3060 * lisp.h (pop_message, set_message, check_point_in_composition):
3061 Likewise.
3062 * xterm.h (set_vertical_scroll_bar): Likewise.
3063 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3064 (message_buf_print, scratch_glyph_row, displayed_buffer):
3065 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3066 (get_next_display_element, show_mouse_face, window_box_edges):
3067 (frame_to_window_pixel_xy, check_point_in_composition):
3068 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3069 (glyph_to_pixel_coords): Remove; unused.
3070
16390cd2
PE
3071 * dired.c (file_name_completion): Now static.
3072
3073 * dbusbind.c (xd_in_read_queued_messages): Now static.
3074
a25f4dfa
PE
3075 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3076 * data.c (circular_list_error): Remove.
3077
14a9c8df
PE
3078 * commands.h (last_point_position, last_point_position_buffer):
3079 (last_point_position_window): Remove decls.
3080 * keyboard.c: Make these variables static.
3081
04f2d78b
CB
3082 * coding.h (coding, code_convert_region, encode_coding_gap):
3083 Remove decls.
74ab6df5
PE
3084 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3085 (iso_code_class, detect_coding, code_convert_region): Now static.
3086 (encode_coding_gap): Remove; unused.
3087
38dfbee1
PE
3088 * chartab.c (chartab_chars, chartab_bits): Now static.
3089
a2cb4e63
PE
3090 * charset.h (charset_iso_8859_1): Remove decl.
3091 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3092 Now static.
3093
127198fd
PE
3094 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3095 * ccl.c (Vccl_program_table): Now static.
3096 (check_ccl_update): Remove; unused.
3097
d85b608f
PE
3098 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3099 * category.h: ... from here.
3100 * category.c (check_category_table, set_category_set): Now static.
3101
31cd66f3
PE
3102 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3103 * lisp.h: Remove these decls.
3104
c358e587
PE
3105 * buffer.c (buffer_count): Remove unused var.
3106
e78aecca
PE
3107 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3108 so that it's not optimized away.
3109 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3110 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3111 exported only to the debugger.
3112
e192d7d3 3113 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3114 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3115
92470028
PE
3116 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3117 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3118 was inaccessible from Lisp.
3119 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3120 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3121
244ed907
PE
3122 alloc.c: Import and export fewer symbols, and remove unused items.
3123 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3124 is defined.
3125 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3126 it's not optimized away by whole-program optimization.
3127 (message_enable_multibyte, free_misc): Remove.
3128 (catchlist, handlerlist, mark_backtrace):
3129 Declare only if BYTE_MARK_STACK.
3130 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3131 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3132 (message_enable_multibyte): Remove decl.
3133 (free_misc, interval_free_list, float_block, float_block_index):
3134 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3135 (cons_free_list, last_marked_index):
3136 Now static.
3137 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3138 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3139 (mark_backtrace): Define only if BYTE_MARK_STACK.
3140 * xdisp.c (message_enable_multibyte): Now static.
3141
61c2b50e 3142 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3143 This makes it easier for human readers (and static analyzers)
3144 to see whether these variables are used from other modules.
3145 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3146 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3147 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3148 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3149 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3150 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3151 * xmenu.c, xselect.c:
3152 Declare Q* vars static if they are not used in other modules.
3153 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3154 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3155 Remove decls of unexported vars.
3156 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3157
95c82688
PE
3158 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3159
16a97296
PE
3160 Make Emacs functions such as Fatom 'static' by default.
3161 This makes it easier for human readers (and static analyzers)
3162 to see whether these functions can be called from other modules.
3163 DEFUN now defines a static function. To make the function external
3164 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3165 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3166 (Finit_image_library):
16a97296
PE
3167 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3168 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3169 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3170 Remove decls, since these functions are now static.
3171 (Funintern, Fget_internal_run_time): New decls, since these functions
3172 were already external.
95c82688 3173
16a97296
PE
3174 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3175 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3176 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3177 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3178 * keyboard.c, keymap.c, lread.c:
3179 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3180 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3181 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3182 Mark functions with DEFUE instead of DEFUN,
3183 if they are used in other modules.
3184 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3185 decls for now-static functions.
3186 * buffer.h (Fdelete_overlay): Remove decl.
3187 * callproc.c (Fgetenv_internal): Mark as internal.
3188 * composite.c (Fremove_list_of_text_properties): Remove decl.
3189 (Fcomposition_get_gstring): New forward static decl.
3190 * composite.h (Fcomposite_get_gstring): Remove decl.
3191 * dired.c (Ffile_attributes): New forward static decl.
3192 * doc.c (Fdocumntation_property): New forward static decl.
3193 * eval.c (Ffetch_bytecode): New forward static decl.
3194 (Funintern): Remove extern decl; now in .h file where it belongs.
3195 * fileio.c (Fmake_symbolic_link): New forward static decl.
3196 * image.c (Finit_image_library): New forward static decl.
3197 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3198 * intervals.h (Fprevious_property_change):
3199 (Fremove_list_of_text_properties): Remove decls.
3200 * keyboard.c (Fthis_command_keys): Remove decl.
3201 (Fcommand_execute): New forward static decl.
3202 * keymap.c (Flookup_key): New forward static decl.
3203 (Fcopy_keymap): Now static.
3204 * keymap.h (Flookup_key): Remove decl.
3205 * process.c (Fget_process): New forward static decl.
3206 (Fprocess_datagram_address): Mark as internal.
3207 * syntax.c (Fsyntax_table_p): New forward static decl.
3208 (skip_chars): Remove duplicate decl.
3209 * textprop.c (Fprevious_property_change): New forward static decl.
3210 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3211 Now internal.
3212 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3213 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3214
785bbd42
PE
3215 * editfns.c (Fformat): Remove unreachable code.
3216
8b913b57
AS
32172011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3218
3219 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3220 change. (Bug#8496)
3221
a6744a35
EZ
32222011-04-13 Eli Zaretskii <eliz@gnu.org>
3223
3224 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3225 when at ZV. (Bug#8487)
3226
e7974947
AS
32272011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3228
baad03f0
AS
3229 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3230 (Bug#8437)
3231 * keyboard.c (parse_tool_bar_item): Likewise.
3232 * sound.c (sound_cleanup, alsa_close): Likewise.
3233 * termcap.c (tgetent): Likewise.
3234 * xfns.c (x_default_font_parameter): Likewise.
3235 * xsettings.c (read_and_apply_settings): Likewise.
3236
e7974947
AS
3237 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3238 (overrun_check_free): Protoize.
3239
28272684
PE
32402011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3241
3242 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3243 since callers should never pass a negative size.
3244 Change the signature to match that of plain 'read' and 'write'; see
3245 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3246 * lisp.h: Update prototypes of emacs_write and emacs_read.
3247
11997c76
EZ
32482011-04-11 Eli Zaretskii <eliz@gnu.org>
3249
3250 * xdisp.c (redisplay_window): Don't try to determine the character
3251 position of the scroll margin if the window start point w->startp
e896f03c 3252 is outside the buffer's accessible region. (Bug#8468)
11997c76 3253
8a2cbd72
EZ
32542011-04-10 Eli Zaretskii <eliz@gnu.org>
3255
3256 Fix write-region and its subroutines for buffers > 2GB.
3257 * fileio.c (a_write, e_write): Modify declaration of arguments and
3258 local variables to support buffers larger than 2GB.
3259 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3260
3261 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3262 argument, local variables, and return value.
3263
3264 * lisp.h: Update prototypes of emacs_write and emacs_read.
3265
3266 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3267
4073e537 32682011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3269
1ebfdcb6
PE
3270 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3271
b2ded58d
PE
3272 Fix more problems found by GCC 4.6.0's static checks.
3273
7d66342c
PE
3274 * xdisp.c (vmessage): Use a better test for character truncation.
3275
bbf47d44
PE
3276 * charset.c (load_charset_map): <, not <=, for optimization,
3277 and to avoid potential problems with integer overflow.
9248994d 3278 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3279 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3280 * editfns.c (Fformat): Likewise.
1e69125e 3281 * syntax.c (skip_chars): Likewise.
3befa583 3282
e3019616
PE
3283 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3284 This also lets GCC 4.6.0 generate slightly better loop code.
3285
becfa255
PE
3286 * callint.c (Fcall_interactively): <, not <=, for optimization.
3287 (Fcall_interactively): Count the number of arguments produced,
3288 not the number of arguments given. This is simpler and lets GCC
3289 4.6.0 generate slightly better code.
3290
dae0cd48
PE
3291 * ftfont.c: Distingish more carefully between FcChar8 and char.
3292 The previous code passed unsigned char * to a functions like
3293 strlen and xstrcasecmp that expect char *, which does not
3294 conform to the C standard.
3295 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3296 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3297 char * when the C standard requires it.
3298
76032d70
PE
3299 * keyboard.c (read_char): Remove unused var.
3300
eb3f1cc8
PE
3301 * eval.c: Port to Windows vsnprintf (Bug#8435).
3302 Include <limits.h>.
3303 (SIZE_MAX): Define if the headers do not.
3304 (verror): Do not give up if vsnprintf returns a negative count.
3305 Instead, grow the buffer. This ports to Windows vsnprintf, which
3306 does not conform to C99. Problem reported by Eli Zaretskii.
3307 Also, simplify the allocation scheme, by avoiding the need for
3308 calling realloc, and removing the ALLOCATED variable.
3309
70476b54
PE
3310 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3311
12020a9e
PE
3312 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3313 But keep the doprint source code for now, as we might revamp it
3314 and use it again (Bug#8435).
ea6c7ae6
PE
3315 * lisp.h (doprnt): Remove.
3316 * Makefile.in (base_obj): Remove doprnt.o.
3317 * deps.mk (doprnt.o): Remove.
3318
5fdb398c
PE
3319 error: Print 32- and 64-bit integers portably (Bug#8435).
3320 Without this change, on typical 64-bit hosts error ("...%d...", N)
3321 was used to print both 32- and 64-bit integers N, which relied on
3322 undefined behavior.
3323 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3324 New macro.
3325 * lisp.h (error, verror): Mark as printf-like functions.
3326 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3327 Report overflow in size calculations when allocating printf buffer.
3328 Do not truncate output string at its first null byte.
3329 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3330 Truncate the output at a character boundary, since vsnprintf does not
3331 do that.
3332 * charset.c (check_iso_charset_parameter): Convert internal
3333 character to string before calling 'error', since %c now has the
3334 printf meaning.
3335 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3336 overflow when computing char to be passed to 'error'. Do not
3337 pass Lisp_Object to 'error'; pass the integer instead.
3338 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3339 formatted with plain %d.
3340
b189fa66
PE
3341 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3342
bff87ef0
PE
3343 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3344
7e2cac20
PE
3345 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3346
ce4d90b5
PE
3347 * xterm.c (x_catch_errors): Remove duplicate declaration.
3348
266c9547
PE
3349 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3350
79c49ad2
PE
3351 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3352
368f4090
JM
33532011-04-10 Jim Meyering <meyering@redhat.com>
3354
3355 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3356 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3357 return ssize_t not "int", and use size_t as the buffer length.
3358 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3359 * gnutls.h: Update declarations.
3360 * process.c (read_process_output): Use ssize_t, to match.
3361 (send_process): Likewise.
3362
a32d4040
CY
33632011-04-09 Chong Yidong <cyd@stupidchicken.com>
3364
3365 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3366
8546720e 33672011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3368
04f2d78b
CB
3369 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3370 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3371
8546720e
GM
3372 * xterm.c (handle_one_xevent):
3373 * xmenu.c (create_and_show_popup_menu):
3374 * xselect.c (x_decline_selection_request)
3375 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3376
0a2f5c1a 33772011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3378
3379 Fix some uses of `int' instead of EMACS_INT.
3380 * search.c (string_match_1, fast_string_match)
3381 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3382 (scan_buffer, find_next_newline_no_quit)
3383 (find_before_next_newline, search_command, Freplace_match)
3384 (Fmatch_data): Make some `int' variables be EMACS_INT.
3385
3386 * xdisp.c (display_count_lines): 3rd argument and return value now
3387 EMACS_INT. All callers changed.
3388 (pint2hrstr): Last argument is now EMACS_INT.
3389
3390 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3391 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3392 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3393 (decode_coding_utf_16, decode_coding_emacs_mule)
3394 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3395 (decode_coding_ccl, decode_coding_charset)
3396 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3397 (decode_coding_iso_2022, decode_coding_emacs_mule)
3398 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3399 <char_offset, last_offset>: Declare EMACS_INT.
3400 (encode_coding_utf_8, encode_coding_utf_16)
3401 (encode_coding_emacs_mule, encode_invocation_designation)
3402 (encode_designation_at_bol, encode_coding_iso_2022)
3403 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3404 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3405 Declare EMACS_INT.
3406 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3407 (encode_invocation_designation): Last argument P_NCHARS is now
3408 EMACS_INT.
3409 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3410 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3411
3412 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3413 All users changed.
3414
3415 * ccl.c (Fccl_execute_on_string): Declare some variables
3416 EMACS_INT.
3417
8546720e 34182011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3419
3420 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3421
4e19a977
CS
34222011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3423
3424 * process.c (Fformat_network_address): Doc fix.
3425
87302331
R
34262011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3427
3428 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3429
cbb59342
CY
34302011-04-08 Chong Yidong <cyd@stupidchicken.com>
3431
3432 * keyboard.c (read_char): Call Lisp function help-form-show,
3433 instead of using internal_with_output_to_temp_buffer.
3434 (Qhelp_form_show): New var.
e0d38eeb 3435 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3436
3437 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3438
3439 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3440
e67a13ab
CY
34412011-04-06 Chong Yidong <cyd@stupidchicken.com>
3442
04f2d78b
CB
3443 * process.c (Flist_processes): Remove to Lisp.
3444 (list_processes_1): Delete.
e67a13ab 3445
973f782d
EZ
34462011-04-06 Eli Zaretskii <eliz@gnu.org>
3447
7c106b1e
EZ
3448 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3449
973f782d
EZ
3450 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3451
41cf7d1a 34522011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3453
ca23cc88
PE
3454 Fix more problems found by GCC 4.6.0's static checks.
3455
f390e2d5
PE
3456 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3457
42eea0d0
PE
3458 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3459
b69769da 3460 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3461
f9541e84
PE
3462 * xdisp.c (vmessage): Mark as a printf-like function.
3463
13841b55
PE
3464 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3465
c136c10f
PE
3466 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3467
5e2d4a30
PE
3468 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3469 printf-like functions.
3470 (tiff_load): Add casts to remove these marks before passing them
3471 to system-supplied API.
3472
583f48b9
PE
3473 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3474
b25d760e
PE
3475 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3476 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3477 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3478 directly, rather than having caller test rule sign. This avoids
3479 some unnecessary tests.
3480 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3481 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3482 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3483
bc7b6697 3484 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3485 (xfont_open): Avoid unnecessary tests.
bc7b6697 3486
27ccc379
PE
3487 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3488
dcd5c89a
PE
3489 * composite.h, composite.c (composition_gstring_put_cache):
3490 Use EMACS_INT, not int, for length.
3491
b13a45c6
PE
3492 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3493 breaking out part of COMPOSITION_DECODE_RULE.
3494 (COMPOSITION_DECODE_RULE): Use it.
3495 * composite.c (get_composition_id): Remove unused local vars,
3496 by using the new macro.
3497
1e792e4d
PE
3498 * textprop.c (set_text_properties_1): Change while to do-while,
3499 since the condition is always true at first.
3500
dc6c6455 3501 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3502 (interval_deletion_adjustment): Return unsigned value.
3503 All uses changed.
dc6c6455 3504
aba7731a
PE
3505 * process.c (list_processes_1, create_pty, read_process_output):
3506 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3507 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3508 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3509 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3510 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3511
fdfc4bf3
PE
3512 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3513
fca8fe46 3514 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3515 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3516
06a0259a 3517 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3518 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3519 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3520
e7b9e80f
PE
3521 * print.c (print_error_message): Avoid int overflow.
3522
56201685
PE
3523 * font.c (font_list_entities): Redo for clarity,
3524 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3525
78834453 3526 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3527 (font_score): Avoid potential overflow in diff calculation.
78834453 3528
0bc0b309 3529 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3530 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3531
e610eaca
PE
3532 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3533
b895abce
PE
3534 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3535 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3536 can always succeed if overflow has undefined behavior.
3537
1f1d9321 3538 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3539 (wordify): Omit three unnecessary tests.
1f1d9321 3540
c59478bc
PE
3541 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3542 All callers changed. This avoids the need for an unused var.
3543
79b73827
PE
3544 * casefiddle.c (casify_region): Remove var that is set but not used.
3545
a4db5dfe
PE
3546 * dired.c (file_name_completion): Remove var that is set but not used.
3547
43aae36e
PE
3548 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3549
2a47c44d 3550 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3551 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3552
a37c69bf
PE
3553 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3554 Check for integer overflow on size calculations.
3555
328ab8e7
PE
3556 * buffer.c (Fprevious_overlay_change): Remove var that is set
3557 but not used.
3558
e5a2a5cb
PE
3559 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3560 Remove vars that are set but not used.
8d84a6eb 3561 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3562 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3563
a60e5f68
PE
3564 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3565
f661cb61 3566 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3567 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3568
f0397f5a
PE
3569 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3570 that are set but not used.
3571
8664db06 3572 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3573 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3574
6abdaa4a
PE
3575 * xselect.c (x_get_local_selection, x_handle_property_notify):
3576 Remove vars that are set but not used.
3577
0ce7538d 3578 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3579 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3580
9ae848fc
PE
3581 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3582 Remove var that is set but not used.
0b918413
PE
3583 (scroll_bar_windows_size): Now size_t, not int.
3584 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3585 Check for overflow.
9ae848fc 3586
a5a62657
PE
3587 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3588 (map_tty_color) [!defined MSDOS]: Likewise.
3589
5c5cdd39
PE
3590 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3591
66ebf983
PE
3592 * coding.c: Remove vars that are set but not used.
3593 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3594 All callers changed.
3595 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3596 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3597 (decode_coding_charset): Remove vars that are set but not used.
3598
1be4d761
PE
3599 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3600 that is set but not used.
3601
47553fa8
PE
3602 * print.c (print_object): Remove var that is set but not used.
3603
1f7196bf 3604 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3605 The gnulib version avoids calling malloc in the usual case,
3606 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3607 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3608 * filelock.c (current_lock_owner): Likewise.
3609 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3610 * sysdep.c: Include allocator.h, careadlinkat.h.
3611 (emacs_no_realloc_allocator): New static constant.
3612 (emacs_readlink): New function.
fdb61804
PE
3613 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3614 ../lib/careadlinkat.h.
d1fdcab7 3615
f84c17c7
SM
36162011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3617
3618 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3619 first non-nil return value).
3620
ef3862ad
JD
36212011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3622
3623 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3624 if not defined (Bug#8403).
3625
376a7006
JB
36262011-04-02 Juanma Barranquero <lekktu@gmail.com>
3627
3628 * xdisp.c (display_count_lines): Remove parameter `start',
3629 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3630 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3631 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3632 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3633 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3634 and thereabouts. All callers changed.
3635 (get_per_char_metric): Remove parameter `f', unused since
3636 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3637
6ca3801d
JM
36382011-04-02 Jim Meyering <meyering@redhat.com>
3639
3640 do not dereference NULL upon failed strdup
3641 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3642 (ns_get_family): Likewise.
3643
d8e2b5ba
JB
36442011-04-02 Juanma Barranquero <lekktu@gmail.com>
3645
3646 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3647
8c74fcbd
JD
36482011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3649
3650 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3651 later (Bug#8403).
3652
7200d79c
SM
36532011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3654
03408648 3655 Add lexical binding.
7200d79c 3656
03408648
SM
3657 * window.c (Ftemp_output_buffer_show): New fun.
3658 (Fsave_window_excursion):
3659 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3660
3661 * lread.c (lisp_file_lexically_bound_p): New function.
3662 (Fload): Bind Qlexical_binding.
3663 (readevalloop): Remove `evalfun' arg.
3664 Bind Qinternal_interpreter_environment.
3665 (Feval_buffer): Bind Qlexical_binding.
3666 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3667 Mark as dynamic.
3668 (syms_of_lread): Declare `lexical-binding'.
3669
3670 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3671
3672 * keyboard.c (eval_dyn): New fun.
3673 (menu_item_eval_property): Use it.
ca105506
SM
3674
3675 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3676
03408648
SM
3677 * fns.c (concat, mapcar1): Accept byte-code-functions.
3678
3679 * eval.c (Fsetq): Handle lexical vars.
3680 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3681 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3682 (FletX, Flet): Obey lexical binding.
3683 (Fcommandp): Handle closures.
3684 (Feval): New `lexical' arg.
3685 (eval_sub): New function extracted from Feval. Use it almost
3686 everywhere where Feval was used. Look up vars in lexical env.
3687 Handle closures.
3688 (Ffunctionp): Move from subr.el.
3689 (Ffuncall): Handle closures.
3690 (apply_lambda): Remove `eval_flags'.
3691 (funcall_lambda): Handle closures and new byte-code-functions.
3692 (Fspecial_variable_p): New function.
3693 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3694 but without exporting it to Lisp.
23aba0ea 3695
23aba0ea 3696 * doc.c (Fdocumentation, store_function_docstring):
03408648 3697 * data.c (Finteractive_form): Handle closures.
23aba0ea 3698
03408648
SM
3699 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3700 interactive spec.
ba83908c 3701
04f2d78b
CB
3702 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3703 New byte-codes.
03408648
SM
3704 (exec_byte_code): New function extracted from Fbyte_code to handle new
3705 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3706
03408648 3707 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3708
03408648 3709 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3710
e2abce01
JB
37112011-03-31 Juanma Barranquero <lekktu@gmail.com>
3712
3713 * xdisp.c (redisplay_internal): Fix prototype.
3714
63696a73 37152011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3716
63696a73 3717 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3718 (try_scrolling): Use it when setting scroll_limit.
3719 Limit scrolling to 100 screen lines.
63696a73
EZ
3720 (redisplay_window): Even when falling back on "recentering",
3721 position point in the window according to scroll-conservatively,
3722 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3723
3724 (try_scrolling): When point is above the window, allow searching
3725 as far as scroll_max, or one screenful, to compute vertical
3726 distance from PT to the scroll margin position. This prevents
3727 try_scrolling from unnecessarily failing when
3728 scroll-conservatively is set to a value slightly larger than the
3729 window height. Clean up the case of PT below the margin at bottom
3730 of window: scroll_max can no longer be INT_MAX. When aggressive
3731 scrolling is in use, don't let point enter the opposite scroll
3732 margin as result of the scroll.
3733 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3734 threshold of 100 lines for never-recentering scrolling.
3735
e4cc2dfc
JB
37362011-03-31 Juanma Barranquero <lekktu@gmail.com>
3737
3738 * dispextern.h (move_it_by_lines):
3739 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3740 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3741 (message_log_check_duplicate): Remove parameters `prev_bol' and
3742 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3743 (redisplay_internal): Remove parameter `preserve_echo_area',
3744 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3745
3746 * indent.c (Fvertical_motion):
3747 * window.c (window_scroll_pixel_based, Frecenter):
3748 Don't pass `need_y_p' to `move_it_by_lines'.
3749
1c470562
SM
37502011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3751
44f230aa
SM
3752 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3753 steal a few bits to be more compact.
3754 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3755 Remove unneeded casts.
3756
1c470562
SM
3757 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3758
888adce9
ZK
37592011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3760
3761 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3762 binding" message (bug#7967).
3763
f838ed7b
PE
37642011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3765
77861b95
PE
3766 Fix more problems found by GCC 4.6.0's static checks.
3767
de6dbc14
PE
3768 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3769 Remove unused local var.
3770
f838ed7b
PE
3771 * editfns.c (Fmessage_box): Remove unused local var.
3772
792c7b2b
PE
3773 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3774 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3775 Omit unused local vars.
c499e557 3776 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3777 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3778 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3779 Omit unused local var.
3780
ba0165e1
PE
3781 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3782 Don't assume string length fits in int.
32ad8845 3783 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3784 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3785
3c59b4c9
PE
3786 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3787 instead of alloca (Bug#8344).
3788
a3eed478 3789 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3790 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3791
eb4d412d
PE
3792 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3793
1658b401
PE
3794 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3795 concerns.
3796
3797 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3798
3799 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3800
9a2c6e05
PE
3801 * keyboard.c (syms_of_keyboard): Use the same style as later
3802 in this function when indexing through an array. This also
3803 works around GCC bug 48267.
3804
03d0a109
PE
3805 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3806
44f730c8
PE
3807 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3808
fe75f926
PE
3809 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3810 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3811
ffa8c828
PE
3812 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3813 This avoids undefined behavior on integer overflow, and is a bit
3814 more convenient anyway since it is compared to a size_t variable.
3815
c5101a77
PE
3816 Variadic C functions now count arguments with size_t, not int.
3817 This avoids an unnecessary limitation on 64-bit machines, which
3818 caused (substring ...) to crash on large vectors (Bug#8344).
3819 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3820 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3821 All variadic functions and their callers changed accordingly.
c5101a77
PE
3822 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3823 * data.c (arith_driver, float_arith_driver): Likewise.
3824 * editfns.c (general_insert_function): Likewise.
3825 * eval.c (struct backtrace.nargs, interactive_p)
3826 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3827 (funcall_lambda, mark_backtrace): Likewise.
3828 * fns.c (concat): Likewise.
3829 * frame.c (x_set_frame_parameters): Likewise.
3830 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3831 0 if not found, not -1. All callers changed.
3832
dd3f25f7
PE
3833 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3834 (stack_copy_size): Now size_t, not int.
3835 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3836
461c2ab9
JB
38372011-03-28 Juanma Barranquero <lekktu@gmail.com>
3838
3839 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3840 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3841 All callers changed.
3842
3843 * lisp.h (multibyte_char_to_unibyte):
3844 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3845 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3846 * character.h (CHAR_TO_BYTE8):
3847 * cmds.c (internal_self_insert):
3848 * editfns.c (general_insert_function):
3849 * keymap.c (push_key_description):
3850 * search.c (Freplace_match):
3851 * xdisp.c (message_dolog, set_message_1): All callers changed.
3852
f6d62986
SM
38532011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3854
3855 * keyboard.c (safe_run_hook_funcall): New function.
3856 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3857 don't set the hook to nil, but remove the offending function instead.
3858 (Qcommand_hook_internal): Remove, unused.
3859 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3860 Vcommand_hook_internal.
3861
3862 * eval.c (enum run_hooks_condition): Remove.
3863 (funcall_nil, funcall_not): New functions.
3864 (run_hook_with_args): Call each function through a `funcall' argument.
3865 Remove `cond' argument, now redundant.
3866 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3867 (Frun_hook_with_args_until_failure): Adjust accordingly.
3868 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3869
1db5b1ad
JB
38702011-03-28 Juanma Barranquero <lekktu@gmail.com>
3871
3872 * dispextern.h (string_buffer_position): Remove declaration.
3873
3874 * print.c (strout): Remove parameter `multibyte', unused since
3875 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3876
3877 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3878 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3879 All callers changed.
3880
3881 * w32.c (_wsa_errlist): Use braces for struct initializers.
3882
3883 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3884 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3885 All callers changed.
3886 (string_buffer_position): Likewise. Also, make static (it's never
3887 used outside xdisp.c).
3888 (cursor_row_p): Remove parameter `w', unused since
3889 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3890 (decode_mode_spec): Remove parameter `precision', introduced during
3891 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3892 All callers changed.
3893
5ffb62aa
JD
38942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3895
3896 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3897
461c2ab9 38982011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3899
3900 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3901 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3902 (ns_update_auto_hide_menu_bar): New functions.
3903 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3904 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3905 ns_constrain_all_frames.
3906 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3907 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3908
5c380ffb
JD
39092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3910
3911 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3912
9af30bdf
GM
39132011-03-27 Glenn Morris <rgm@gnu.org>
3914
3915 * syssignal.h: Replace RETSIGTYPE with void.
3916 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3917 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3918 Replace SIGTYPE with void everywhere.
3919 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3920 * s/template.h (SIGTYPE): Remove commented out definition.
3921
e2abce01
JB
39222011-03-26 Eli Zaretskii <eliz@gnu.org>
3923
3924 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3925 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3926
f868cd8a
JB
39272011-03-26 Juanma Barranquero <lekktu@gmail.com>
3928
59eb0929
JB
3929 * w32.c (read_unc_volume): Use parameter `henum', instead of
3930 global variable `wget_enum_handle'.
3931
3932 * keymap.c (describe_vector): Remove parameters `indices' and
3933 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3934 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3935
f868cd8a
JB
3936 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3937
3938 * keyboard.c (timer_check): Remove parameter `do_it_now',
3939 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3940 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3941 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3942
3943 * keyboard.c (read_char):
3944 * w32menu.c (w32_menu_display_help):
3945 * xmenu.c (show_help_event, menu_help_callback):
3946 Adjust calls to `show_help_echo'.
3947
3948 * gtkutil.c (xg_maybe_add_timer):
3949 * keyboard.c (readable_events):
3950 * process.c (wait_reading_process_output):
3951 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3952
3953 * insdel.c (adjust_markers_gap_motion):
3954 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3955 (gap_left, gap_right): Don't call it.
3956
2ecf6fdb
CY
39572011-03-25 Chong Yidong <cyd@stupidchicken.com>
3958
3959 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3960 incurred during fontification.
3961
6b1f9ba4
JB
39622011-03-25 Juanma Barranquero <lekktu@gmail.com>
3963
3964 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3965 (DEFVAR_PER_BUFFER): Don't pass it.
3966
3967 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3968 (scrolling_window): Don't pass it.
3969
0f4a96b5
JB
39702011-03-25 Juanma Barranquero <lekktu@gmail.com>
3971
3972 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3973
3974 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3975 and `suffix'.
3976 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3977 of variables specific to SELinux and computation of `encoded_absname'.
3978
3979 * image.c (XPutPixel): Remove unused variable `height'.
3980
3981 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3982
3983 * unexw32.c (get_section_info): Remove unused variable `section'.
3984
3985 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3986 (system_process_attributes): Remove unused variable `sess'.
3987 (sys_read): Remove unused variable `err'.
3988
3989 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3990 (w32_wnd_proc): Remove unused variable `isdead'.
3991 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3992 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3993 (x_create_tip_frame): Remove unused variable `tem'.
3994
3995 * w32inevt.c (w32_console_read_socket):
3996 Remove unused variable `no_events'.
3997
3998 * w32term.c (x_draw_composite_glyph_string_foreground):
3999 Remove unused variable `width'.
4000
1149507c
JB
40012011-03-24 Juanma Barranquero <lekktu@gmail.com>
4002
4003 * w32term.c (x_set_glyph_string_clipping):
4004 Don't pass uninitialized region to CombineRgn.
4005
9c88f339
JB
40062011-03-23 Juanma Barranquero <lekktu@gmail.com>
4007
4008 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4009 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4010 (Fx_close_connection): Remove unused variable `i'.
4011
4012 * w32font.c (w32font_draw): Return number of glyphs.
4013 (w32font_open_internal): Remove unused variable `i'.
4014 (w32font_driver): Add missing initializer.
4015
4016 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4017 (fill_in_menu): Remove unused variable `items_added'.
4018
4019 * w32term.c (last_mouse_press_frame): Remove static global variable.
4020 (w32_clip_to_row): Remove unused variable `f'.
4021 (x_delete_terminal): Remove unused variable `i'.
4022
4023 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4024 (NOTHING): Remove unused static global variable.
4025 (uniscribe_check_otf): Remove unused variable `table'.
4026 (uniscribe_font_driver): Add missing initializers.
4027
dee091a3
JD
40282011-03-23 Julien Danjou <julien@danjou.info>
4029
4030 * term.c (Fsuspend_tty, Fresume_tty):
4031 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4032 * window.c (temp_output_buffer_show):
4033 * insdel.c (signal_before_change):
4034 * frame.c (Fhandle_switch_frame):
4035 * fileio.c (Fdo_auto_save):
4036 * emacs.c (Fkill_emacs):
4037 * editfns.c (save_excursion_restore):
4038 * cmds.c (internal_self_insert):
4039 * callint.c (Fcall_interactively):
4040 * buffer.c (Fkill_all_local_variables):
4041 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4042 Use Frun_hooks.
0f4a96b5 4043 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4044 unconditionnaly since it does the check itself.
4045
2c520ab5 40462011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4047
c9c49752
PE
4048 Fix more problems found by GCC 4.5.2's static checks.
4049
8abc3f12
PE
4050 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4051 the first time through the loop, since we know p0 < p1 then.
4052 This also avoids a gcc -Wstrict-overflow warning.
4053
a2d26660
PE
4054 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4055 leading to a memory leak, possible in functions like
4056 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4057 of objects (Bug#8318).
a2d26660 4058
916c72e9
PE
4059 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4060 that could (at least in theory) be that large.
4061
19ab8a18
PE
4062 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4063 This is less likely to overflow, and avoids undefined behavior if
4064 overflow does occur. All callers changed. Use strtoul to scan
4065 for the unsigned long integer.
b7cbbd6f
PE
4066 (pint2hrstr): Simplify and tune code slightly.
4067 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4068
f0641eff
PE
4069 * scroll.c (do_scrolling): Work around GCC bug 48228.
4070 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4071
7f650bb9
PE
4072 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4073 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4074 (validate_x_resource_name): Simplify count usage.
4075 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4076
37dd57d1
PE
4077 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4078 fail (Bug#8306).
81e56e61 4079
699979fc 4080 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4081
401bf9b4
PE
4082 * process.c (Fmake_network_process): Use socklen_t, not int,
4083 where POSIX says socklen_t is required in portable programs.
4084 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4085 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4086 (Fmake_network_process, server_accept_connection):
4087 (wait_reading_process_output, read_process_output):
4088 Likewise.
4089
b93aacde
PE
4090 * process.c: Rename or move locals to avoid shadowing.
4091 (list_processes_1, Fmake_network_process):
4092 (read_process_output_error_handler, exec_sentinel_error_handler):
4093 Rename or move locals.
4dc343ee 4094 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4095 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4096 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4097 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4098 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4099
af8a867c 4100 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4101 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4102 Include tparam.h instead, since it declares them.
af8a867c
PE
4103 * cm.h (PC): Remove extern decl; tparam.h now does this.
4104 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4105 * terminfo.c: Include tparam.h, to check interfaces.
4106 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4107 (tparam): Adjust signature to match interface in tparam.h;
4108 this removes some undefined behavior. Check that outstring and len
4109 are zero, which they always are with Emacs.
4110 * tparam.h (PC, BC, UP): New extern decls.
4111
0248044d 4112 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4113 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4114
8ff096c1 4115 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4116 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4117 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4118 (ftfont_list): Remove unused local.
49eaafba
PE
4119 (get_adstyle_property, ftfont_pattern_entity):
4120 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4121 Rename locals to avoid shadowing.
8ff096c1 4122
e2be39f6
PE
4123 * xfont.c (xfont_list_family): Mark var as initialized.
4124
c9735e30
PE
4125 * xml.c (make_dom): Now static.
4126
8f5201ae
PE
4127 * composite.c (composition_compute_stop_pos): Rename local to
4128 avoid shadowing.
b246f932
PE
4129 (composition_reseat_it): Remove unused locals.
4130 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4131 (composition_update_it): Mark var as initialized.
11b61122
PE
4132 (find_automatic_composition): Mark vars as initialized,
4133 with a FIXME (Bug#8290).
8f5201ae 4134
760fbc2c
PE
4135 character.h: Rename locals to avoid shadowing.
4136 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4137 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4138 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4139 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4140 to avoid shadowing.
4141
ff08eb85
PE
4142 * textprop.c (property_change_between_p): Remove; unused.
4143
fc7bf025
PE
4144 * intervals.c (interval_start_pos): Now static.
4145
235d7abc
PE
4146 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4147
44f230aa
SM
4148 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4149 Rename locals to avoid shadowing.
3e7d6594 4150
50060332
PE
4151 * sound.c (wav_play, au_play, Fplay_sound_internal):
4152 Fix pointer signedness.
d01f234b 4153 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4154 (wav_play): Initialize a variable to 0, to prevent undefined
4155 behavior (Bug#8278).
50060332 4156
c4fc4e30
PE
4157 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4158
918436ed
PE
4159 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4160
c939f91b
PE
4161 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4162 clobbering (Bug#8298).
b9c7f648
PE
4163 * sysdep.c (sys_subshell): Likewise.
4164 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4165
6bd8c144
PE
4166 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4167 This should get cleaned up, so that child_setup has the
4168 same signature on all platforms.
4169
7710357c 4170 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4171 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4172
c59da222
CY
41732011-03-22 Chong Yidong <cyd@stupidchicken.com>
4174
4175 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4176 not to be necessary, and produces flickering.
4177
66b87493
GM
41782011-03-20 Glenn Morris <rgm@gnu.org>
4179
4180 * config.in: Remove file.
4181
45b6f6d5
JB
41822011-03-20 Juanma Barranquero <lekktu@gmail.com>
4183
4184 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4185 are now in src/globals.h.
4186 (syms_of_minibuf): Remove spurious & from previous change.
4187
3ec03f7e
LL
41882011-03-20 Leo <sdl.web@gmail.com>
4189
4190 * minibuf.c (completing-read-function): New variable.
4191 (completing-read-default): Rename from completing-read.
4192 (completing-read): Call completing-read-function.
4193
b14e3e21
CY
41942011-03-19 Juanma Barranquero <lekktu@gmail.com>
4195
4196 * xfaces.c (Fx_load_color_file):
4197 Read color file from absolute filename (bug#8250).
4198
f2b726e6
JB
41992011-03-19 Juanma Barranquero <lekktu@gmail.com>
4200
4201 * makefile.w32-in: Update dependencies.
4202
09f6ff02
EZ
42032011-03-17 Eli Zaretskii <eliz@gnu.org>
4204
4205 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4206
29a6015a
PE
42072011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4208
a3a6c54e
PE
4209 Fix more problems found by GCC 4.5.2's static checks.
4210
b766f867
PE
4211 * process.c (make_serial_process_unwind, send_process_trap):
4212 (sigchld_handler): Now static.
4213
be02381c
PE
4214 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4215 That way, the code declares only the vars that it needs.
4216 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4217 * s/cygwin.h (PTY_ITERATION): Likewise.
4218 * s/darwin.h (PTY_ITERATION): Likewise.
4219 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4220
57048744
PE
4221 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4222 * process.c (allocate_pty): Don't declare stb unless it's needed.
4223
7914961c 4224 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4225 (CONSTANTLIM): Remove; unused.
4226 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4227 Define only if needed.
7914961c 4228
b3967b18
PE
4229 * unexelf.c (unexec): Name an expression,
4230 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4231 Use a different way to cause a compilation error if anyone uses
4232 n rather than nn, a way that does not involve shadowing.
73366a00 4233 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4234
29a6015a
PE
4235 * deps.mk (unexalpha.o): Remove; unused.
4236
43cfc33e 4237 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4238 * unexec.h: New file.
ce701a33
PE
4239 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4240 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4241 Depend on unexec.h.
4242 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4243 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4244 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4245 Change as necessary to match prototype in unexec.h.
ce701a33 4246
01f44d5a
PE
4247 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4248 shadowing.
4f63c6bb 4249 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4250
a6670b0b
PE
4251 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4252 Rename locals to avoid shadowing.
4253
cef2010d 4254 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4255 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4256
d4d7173a
PE
4257 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4258
f08b802a
PE
4259 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4260 warning when compiling print.c.
4261
3ddb0639
PE
4262 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4263 instead of using an uninitialized var.
5ad03b97 4264 (font_sort_entities): Mark var as initialized.
3ddb0639 4265
170a2692
PE
4266 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4267
e663c700
PE
4268 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4269 pointers to constants.
89bc529a 4270 (font_parse_fcname): Remove unused vars.
7b81e2d0 4271 (font_delete_unmatched): Now static.
ea838e10 4272 (font_get_spec): Remove; unused.
13a547c6
PE
4273 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4274 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4275 Rename or move locals to avoid shadowing.
e663c700 4276
2a80c887 4277 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4278 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4279
1384fa33 4280 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4281 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4282
8b2c52e9
PE
4283 * alloc.c (mark_backtrace): Move decl from here ...
4284 * lisp.h: ... to here, so that it can be checked.
4285
475545b5 4286 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4287 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4288 (lisp_indirect_variable): Name an expression,
4289 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4290 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4291
b1349114 4292 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4293 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4294 Use const pointer when appropriate.
b1349114 4295
a2928364
PE
4296 * lisp.h (get_system_name, get_operating_system_release):
4297 Move decls here, to check interfaces.
4298 * process.c (get_operating_system_release): Move decl to lisp.h.
4299 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4300 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4301 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4302 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4303 (Fformat_time_string, Fencode_time, Finsert_char):
4304 (Ftranslate_region_internal, Fformat):
4305 Rename or remove local vars to avoid shadowing.
9710023e 4306 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4307
a415e694
PE
4308 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4309 avoid shadowing.
4310
8ef4622d
PE
4311 * lisp.h (eassert): Check that the argument compiles, even if
4312 ENABLE_CHECKING is not defined.
4313
946f9a5b
PE
4314 * data.c (Findirect_variable): Name an expression, to avoid
4315 gcc -Wbad-function-cast warning.
112396d6 4316 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4317 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4318 (Fmake_variable_buffer_local, Fmake_local_variable):
4319 Mark variables as initialized.
52746918 4320 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4321
e5aab7e7 4322 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4323 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4324 Rename locals to avoid shadowing.
dff45157
PE
4325 (mark_stack): Move local variables into the #ifdef region where
4326 they're used.
7bc26fdb
PE
4327 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4328 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4329 needed otherwise.
4330 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4331 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4332 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4333
e5aab7e7
PE
4334 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4335 avoids undefined behavior in theory.
4336
4da60324
PE
4337 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4338
88043301
PE
4339 Use functions, not macros, for up- and down-casing (Bug#8254).
4340 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4341 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4342 to use the following functions instead of these macros.
4343 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4344 EMACS_INT, since callers assume the returned value fits in int.
4345 (upcase1): Likewise, for UPCASE_TABLE.
4346 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4347 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4348 the race-condition problem in the old DOWNCASE.
88043301 4349
19ed5445
PE
4350 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4351 Rename locals to avoid shadowing.
4352 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4353 (regex_compile, re_search_2, re_match_2_internal):
4354 Remove unused local vars.
952db0d7
PE
4355 (FREE_VAR): Rewrite so as not to use empty "else",
4356 which gcc can warn about.
da053e48 4357 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4358 (RETALLOC_IF): Define only if needed.
4359 (WORDCHAR_P): Likewise. This one is never needed, but is used
4360 only in a comment talking about a compiler bug, so put inside
4361 the #if 0 of that comment.
4362 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4363 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4364 Remove; unused.
19ed5445 4365
1f3561e4 4366 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4367 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4368 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4369
ded6f8f7
PE
4370 * search.c (simple_search): Remove unused var.
4371
dbd37a95
PE
4372 * dired.c (compile_pattern): Move decl from here ...
4373 * lisp.h: ... to here, so that it can be checked.
4374 (struct re_registers): New forward decl.
4375
7e47afad
PE
4376 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4377
85f24f61
PE
4378 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4379 All uses changed.
4380 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4381 Rename locals to avoid shadowing.
5671df8f 4382 (Fvertical_motion): Mark locals as initialized.
85f24f61 4383
181aa2be 4384 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4385 (casify_region): Mark local as initialized.
181aa2be 4386
930d429c
PE
4387 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4388
7082eac6
PE
4389 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4390 New macros, so that the caller can use some names other than
4391 gcpro1, gcpro2, etc.
4392 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4393 of the new macros.
4394 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4395 argument, for consistency with GCPRO2_VAR, etc: it is now the
4396 prefix of the variable, not the variable itself. All uses
4397 changed.
38b2c076
PE
4398 * dired.c (directory_files_internal, file_name_completion):
4399 Rename locals to avoid shadowing.
4400
15206ed9
PE
4401 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4402 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4403 dired.c's scmp function, had undefined behavior.
4404 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4405 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4406 * buffer.h: ... to here, because these macros use current_buffer,
4407 and the new implementation with inline functions needs to have
4408 current_buffer in scope now, rather than later when the macros
4409 are used.
4410 (downcase, upcase1): New static inline functions.
4411 (DOWNCASE, UPCASE1): Reimplement using these functions.
4412 This avoids undefined behavior in expressions like
4413 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4414 from race conditions in accessing the global variables
4415 case_temp1 and case_temp2.
4416 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4417 * lisp.h (case_temp1, case_temp2): Remove their decls.
4418 * character.h (ASCII_CHAR_P): Move from here ...
4419 * lisp.h: ... to here, so that the inline functions mentioned
4420 above can use them.
4421
4a6bea26
PE
4422 * dired.c (directory_files_internal_unwind): Now static.
4423
f14b7e14
PE
4424 * fileio.c (file_name_as_directory, directory_file_name):
4425 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4426 Now static.
2893f146
PE
4427 (file_name_as_directory): Use const pointers when appropriate.
4428 (Fexpand_file_name): Likewise. In particular, newdir might
4429 point at constant storage, so make it a const pointer.
fd4ead52 4430 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4431 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4432 signedness issues.
f839df0c
PE
4433 (Fset_file_times, Finsert_file_contents, auto_save_error):
4434 Rename locals to avoid shadowing.
f14b7e14 4435
5716756e 4436 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4437 (Ftry_completion, Fall_completions): Rename or remove locals
4438 to avoid shadowing.
5716756e 4439
b4c3046a
PE
4440 * marker.c (bytepos_to_charpos): Remove; unused.
4441
b45db522
PE
4442 * lisp.h (verify_bytepos, count_markers): New decls,
4443 so that gcc does not warn that these functions aren't declared.
4444
85876d07
PE
4445 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4446 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4447 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4448 (copy_text): Remove unused local var.
85876d07 4449
03d78a21 4450 * filelock.c (within_one_second): Now static.
b3dd38ab 4451 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4452
5df8f01b
PE
4453 * buffer.c (fix_overlays_before): Mark locals as initialized.
4454 (fix_start_end_in_overlays): Likewise. This function should be
4455 simplified by using pointers-to-pointers, but that's a different
4456 matter.
b1d876f1 4457 (switch_to_buffer_1): Now static.
8f54f30a
PE
4458 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4459 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4460
a70072c9 4461 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4462 Fix pointer signedness issue.
edced198
PE
4463 (sys_subshell): Mark local as volatile if checking for lint,
4464 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4465 (MAXPATHLEN): Define only if needed.
a70072c9 4466
a0977c44
PE
4467 * process.c (serial_open, serial_configure): Move decls from here ...
4468 * systty.h: ... to here, so that they can be checked.
4469
a884fdcc
PE
4470 * fns.c (get_random, seed_random): Move extern decls from here ...
4471 * lisp.h: ... to here, so that they can be checked.
4472
604efe86 4473 * sysdep.c (reset_io): Now static.
b8950c94 4474 (wait_for_termination_signal): Remove; unused.
604efe86 4475
38fc62d9
PE
4476 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4477 (copy_keymap_item, append_key, push_text_char_description):
4478 Now static.
1004a21a 4479 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4480 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4481 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4482 (describe_map_tree):
4483 Rename locals to avoid shadowing.
38fc62d9 4484
2f2650da
PE
4485 * keyboard.c: Declare functions static if they are not used elsewhere.
4486 (echo_char, echo_dash, cmd_error, top_level_2):
4487 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4488 (read_char, kbd_buffer_get_event, make_lispy_position):
4489 (make_lispy_event, make_lispy_movement, apply_modifiers):
4490 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4491 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4492 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4493 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4494 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4495
a053e86c 4496 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4497 (mark_kboards): Move decl here ...
4498 * alloc.c (mark_kboards): ... from here.
a053e86c 4499
4752793e
PE
4500 * lisp.h (force_auto_save_soon): New decl.
4501
74f10ca7 4502 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4503 (DEFINE_DUMMY_FUNCTION): New macro.
4504 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4505 Use it.
c03cd23f
PE
4506 (main): Add casts to avoid warnings
4507 if GCC considers string literals to be constants.
74f10ca7 4508
022e70d4
PE
4509 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4510
59d6fe83
PE
4511 * dbusbind.c: Pointer signedness fixes.
4512 (xd_signature, xd_append_arg, xd_initialize):
4513 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4514 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4515 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4516 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4517
78320123
PE
4518 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4519 if GCC considers string literals to be constants.
49cebcca 4520 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4521
35ac2a97
SM
45222011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4523
fb103ca9
SM
4524 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4525 (print_preprocess, print_object): New macro to fix last change.
4526
35ac2a97
SM
4527 * print.c (print_preprocess): Don't forget font objects.
4528
62973b41
JB
45292011-03-16 Juanma Barranquero <lekktu@gmail.com>
4530
4531 * emacs.c (USAGE3): Doc fixes.
4532
0e48bb22
AS
45332011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4534
4535 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4536 structure.
4537
7684e57b
JB
45382011-03-14 Juanma Barranquero <lekktu@gmail.com>
4539
4540 * lisp.h (VWindow_system, Qfile_name_history):
4541 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4542 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4543 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4544
4545 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4546 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4547
4548 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4549 * w32console.c (detect_input_pending, read_input_pending)
4550 (encode_terminal_code):
4551 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4552 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4553 (w32_system_caret_y, Qfile_name_history):
4554 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4555 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4556 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4557 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4558 * w32proc.c (Qlocal, report_file_error):
4559 * w32term.c (Vwindow_system, updating_frame):
4560 * w32uniscribe.c (initialized, uniscribe_font_driver):
4561 Remove unneeded extern declarations.
4562
2aa46d6c
CY
45632011-03-14 Chong Yidong <cyd@stupidchicken.com>
4564
c96bbc66 4565 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4566
cffc6f3b
CY
45672011-03-13 Chong Yidong <cyd@stupidchicken.com>
4568
4569 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4570 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4571 These macros can no longer be used for assignment.
4572
44f230aa
SM
4573 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4574 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4575 (record_buffer_markers, fetch_buffer_markers): New functions for
4576 recording and fetching special buffer markers.
4577 (set_buffer_internal_1, set_buffer_temp): Use them.
4578
4579 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4580
4581 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4582
4583 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4584 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4585
4586 * xdisp.c (hscroll_window_tree):
4587 (reconsider_clip_changes): Use PT instead of BUF_PT.
4588
d251f04b
EZ
45892011-03-13 Eli Zaretskii <eliz@gnu.org>
4590
4591 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4592 $(EMACS_ROOT)/lib/intprops.h.
4593
f0c77cd1
PE
45942011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4595
3eca4629
PE
4596 Fix more problems found by GCC 4.5.2's static checks.
4597
7c86ee98
PE
4598 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4599 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4600 (xg_free_frame_widgets): Make it clear that a local variable is
4601 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4602 (gdk_window_get_screen): Make it clear that this macro is needed
4603 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4604 (int_gtk_range_get_value): New function, which avoids a diagnostic
4605 from gcc -Wbad-function-cast.
4606 (xg_set_toolkit_scroll_bar_thumb): Use it.
4607 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4608 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4609 (get_utf8_string, xg_get_file_with_chooser):
4610 Rename locals to avoid shadowing.
4611 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4612
41729b81
PE
4613 * xgselect.c (xg_select): Remove unused var.
4614
f0c77cd1
PE
4615 * image.c (four_corners_best): Mark locals as initialized.
4616 (gif_load): Initialize transparent_p to zero (Bug#8238).
4617 Mark another local as initialized.
ec6cf4c6 4618 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4619
ce0ad53d 4620 * image.c (clear_image_cache): Now static.
d5d5a617 4621 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4622 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4623 (x_edge_detection): Remove unnecessary cast that
4624 gcc -Wbad-function-cast diagnoses.
2037898d 4625 (gif_load): Fix pointer signedness.
6ae141d6
PE
4626 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4627 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4628
33383987 46292011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4630
d32df629
PE
4631 Improve quality of tests for time stamp overflow.
4632 For example, without this patch (encode-time 0 0 0 1 1
4633 1152921504606846976) returns the obviously-bogus value (-948597
4634 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4635 reports time overflow. See
4636 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4637 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4638 * editfns.c: Include limits.h and intprops.h.
4639 (TIME_T_MIN, TIME_T_MAX): New macros.
4640 (time_overflow): Move earlier, to before first use.
4641 (hi_time, lo_time): New functions, for an accurate test for
4642 out-of-range times.
4643 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4644 (Fget_internal_run_time): Don't assume time_t fits in int.
4645 (make_time): Use list2 instead of Fcons twice.
4646 (Fdecode_time): More accurate test for out-of-range times.
4647 (check_tm_member): New function.
4648 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4649 (lisp_time_argument): Don't rely on undefined left-shift and
4650 right-shift behavior when checking for time stamp overflow.
8be6f318 4651
fe31d94c
PE
4652 * editfns.c (time_overflow): New function, refactoring common code.
4653 (Fformat_time_string, Fdecode_time, Fencode_time):
4654 (Fcurrent_time_string): Use it.
4655
8be6f318
PE
4656 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4657 * dired.c (make_time): Move to ...
4658 * editfns.c (make_time): ... here.
4659 * systime.h: Note the move.
4660
09d9db2c 46612011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4662
126bc0dc
YM
4663 * fringe.c (update_window_fringes): Remove unused variables.
4664
c47cbdfd
YM
4665 * unexmacosx.c (copy_data_segment): Also copy __got section.
4666 (Bug#8223)
4667
7ac80be9
EZ
46682011-03-12 Eli Zaretskii <eliz@gnu.org>
4669
c96bbc66 4670 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4671 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4672 Constify `char *' arguments and their references according to
4673 prototypes in tparam.h.
4674
ecb0f94d 4675 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4676
7ac80be9
EZ
4677 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4678 Adapt all references accordingly.
4679
4680 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4681
ef1fd07e
TT
46822011-03-11 Tom Tromey <tromey@redhat.com>
4683
4684 * buffer.c (syms_of_buffer): Remove obsolete comment.
4685
7ef4b50c
EZ
46862011-03-11 Eli Zaretskii <eliz@gnu.org>
4687
4688 * termhooks.h (encode_terminal_code): Declare prototype.
4689
4690 * msdos.c (encode_terminal_code): Don't declare prototype.
4691
4692 * term.c (encode_terminal_code): Now external again, used by
4693 w32console.c and msdos.c.
4694
44f230aa
SM
4695 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4696 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4697
4b1ec863 46982011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4699
1714f52b 4700 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4701
4b1ec863
PE
4702 * fringe.c (update_window_fringes): Mark locals as initialized
4703 (Bug#8227).
4704 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4705
524c7aa6
PE
4706 * alloc.c (mark_fringe_data): Move decl from here ...
4707 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4708 to check its interface.
4709 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4710
a5c0af81 4711 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4712 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4713 (fontset_font): Mark local as initialized.
a9a06e0b 4714 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4715
b4716021
PE
4716 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4717
811e9bac 4718 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4719 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4720 (x_own_selection, Fx_disown_selection_internal): Rename locals
4721 to avoid shadowing.
4722 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4723
7e3ab302
PE
4724 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4725 so that the caller can use some name other than gcpro1.
4726 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4727 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4728 (Fx_backspace_delete_keys_p):
4729 Use them to avoid shadowing, and rename vars to avoid shadowing.
4730 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4731 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4732 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4733 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4734 Remove unused locals.
7e3ab302
PE
4735 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4736 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4737 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4738 macros.
f78faa98 4739
e2b13473
PE
4740 * xterm.h (x_mouse_leave): New decl.
4741
77f23912
PE
4742 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4743 Remove unused functions.
cdf4ba58
PE
4744 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4745 (x_calc_absolute_position): Now static.
7411c686 4746 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4747 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4748 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4749 unless they are used.
38d0b34a
PE
4750 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4751 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4752 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4753 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4754 (x_error_catcher, x_connection_closed, x_error_handler):
4755 (x_error_quitter, xembed_send_message, x_iconify_frame):
4756 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4757 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4758 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4759
44f230aa
SM
4760 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4761 Rename or move locals to avoid shadowing.
6b463e58 4762 (tty_defined_color, merge_face_heights): Now static.
5967d051 4763 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4764 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4765 does not deduce is never used uninitialized.
73719eba
PE
4766 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4767 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4768
426994c3 4769 * terminal.c (store_terminal_param): Now static.
5489860b 4770
032f1620 4771 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4772 (set_frame_menubar): Remove unused local.
d4323972 4773 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4774 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4775 since they might point to immutable storage.
281585b0
PE
4776 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4777 since it's unused otherwise.
032f1620 4778
367c19e5 4779 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4780 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4781 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4782 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4783 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4784 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4785 does not deduce are never used uninitialized.
70739cbe 4786
07b48fa9
PE
4787 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4788
8868a238 4789 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4790 * window.c (window_loop, size_window):
4791 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4792
7e5cf297 4793 * window.c (display_buffer): Now static.
d6550a9f
PE
4794 (size_window): Mark variables that gcc -Wuninitialized
4795 does not deduce are never used uninitialized.
a586633d
PE
4796 * window.h (check_all_windows): New decl, to forestall
4797 gcc -Wmissing-prototypes diagnostic.
5b555da1 4798 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4799
f6095868
PE
4800 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4801 shadowing.
4802 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4803 Include <limits.h>.
4804 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4805 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4806 (load_charset_map): Mark variables that gcc -Wuninitialized
4807 does not deduce are never used uninitialized.
53df7c11 4808 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4809
f38b440c
PE
4810 * coding.c (coding_set_source, coding_set_destination):
4811 Use "else { /* comment */ }" rather than "else /* comment */;"
4812 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4813 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4814 a block, when the outer 'i' will do.
4815 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4816 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4817 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4818 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4819 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4820 Rename locals to avoid shadowing.
4821 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4822 * coding.c (emacs_mule_char, encode_invocation_designation):
4823 Now static, since they're not used elsewhere.
413bb2db 4824 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4825 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4826 (decode_coding_emacs_mule): Mark variables that gcc
4827 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4828 (detect_coding_iso_2022): Initialize a local variable that might
4829 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4830 this initialization is needed. (Bug#8211)
5f58e762
PE
4831 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4832 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4833 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4834 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4835 Remove unused macros.
f38b440c 4836
232b38b9 4837 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4838 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4839 * character.c (string_count_byte8): Likewise.
232b38b9 4840
fb90da1b
PE
4841 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4842 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4843
fb93dbc2
PE
4844 * chartab.c (copy_sub_char_table): Now static, since it's not used
4845 elsewhere.
5c156ace
PE
4846 (sub_char_table_ref_and_range, char_table_ref_and_range):
4847 Rename locals to avoid shadowing.
bbcd0949 4848 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4849
7d3b3862 4850 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4851 (BIDI_BOB): Remove unused macro.
7d3b3862 4852
6be7d3da
PE
4853 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4854 deduce are never used uninitialized.
c2ed9c8b 4855 * term.c (encode_terminal_code): Likewise.
6be7d3da 4856
75f8807f 4857 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4858
50938595
PE
4859 * tparam.h: New file.
4860 * term.c, tparam.h: Include it.
4861 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4862 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4863 Move these decls to tparam.h, and make them agree with what
4864 is actually in tparam.c. The previous trick of using incompatible
4865 decls in different modules does not conform to the C standard.
4866 All callers of tparam changed to use tparam's actual API.
4867 * tparam.c (tparam1, tparam, tgoto):
4868 Use const pointers where appropriate.
4869
fbceeba2
PE
4870 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4871 * cm.h (struct cm): Likewise.
4872 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4873 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4874 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4875 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4876 (turn_on_face, init_tty): Likewise.
4877 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4878
7f3f1250
PE
4879 * term.c (term_mouse_position): Rename local to avoid shadowing.
4880
e6ca6543
PE
4881 * alloc.c (mark_ttys): Move decl from here ...
4882 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4883
c40f8d15
AS
48842011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4885
4886 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4887
cfe0661d
JB
48882011-03-09 Juanma Barranquero <lekktu@gmail.com>
4889
4890 * search.c (compile_pattern_1): Remove argument regp, unused since
4891 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4892 (compile_pattern): Don't pass it.
4893
0afb4571
J
48942011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4895
4896 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4897 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4898 for ! HAVE_GTK3.
4899 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4900
4901 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4902
4903 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4904 gdk_window_get_screen, gdk_window_get_geometry,
4905 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4906 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4907 (xg_get_pixbuf_from_pixmap): New function.
4908 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4909 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4910 Call xg_get_pixbuf_from_pixmap instead of
4911 gdk_pixbuf_get_from_drawable.
4912 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4913 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4914 (xg_check_special_colors): Use GtkStyleContext and its functions
4915 for HAVE_GTK3.
4916 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4917 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4918 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4919 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4920 Call gtk_widget_get_preferred_size.
0afb4571
J
4921 (xg_frame_resized): gdk_window_get_geometry only takes 5
4922 parameters.
44f230aa
SM
4923 (xg_win_to_widget, xg_event_is_for_menubar):
4924 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4925 (xg_set_widget_bg): New function.
4926 (delete_cb): New function.
895009e1 4927 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4928 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4929 (xg_set_background_color): Call xg_set_widget_bg.
4930 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4931 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4932 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4933 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4934 if ! HAVE_GTK3.
4935 (update_frame_tool_bar): Call gtk_widget_hide.
4936 (xg_initialize): Use GDK_KEY_g.
4937
4938 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4939 if ! HAVE_GTK3
4940 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4941
4942 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4943 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4944 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4945
1c2cc4ef
JB
49462011-03-08 Juanma Barranquero <lekktu@gmail.com>
4947
4948 * w32xfns.c (select_palette): Check success of RealizePalette against
4949 GDI_ERROR, not zero.
4950
33383987 4951See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4952
4953;; Local Variables:
4954;; coding: utf-8
aac0c6e3
MR
4955;; End:
4956
33383987 4957 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4958
4959 This file is part of GNU Emacs.
4960
4961 GNU Emacs is free software: you can redistribute it and/or modify
4962 it under the terms of the GNU General Public License as published by
4963 the Free Software Foundation, either version 3 of the License, or
4964 (at your option) any later version.
4965
4966 GNU Emacs is distributed in the hope that it will be useful,
4967 but WITHOUT ANY WARRANTY; without even the implied warranty of
4968 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4969 GNU General Public License for more details.
4970
4971 You should have received a copy of the GNU General Public License
4972 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.