Error message fix in `describe-specified-language-support'
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1d698799
LMI
12011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * lread.c (syms_of_lread): Clarify that is isn't only
4 `eval-buffer' and `eval-defun' that's affected by
5 `lexical-binding' (bug#8460).
6
aa4b6df6
EZ
72011-07-15 Eli Zaretskii <eliz@gnu.org>
8
9 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
10 bidi redisplay when a line includes both an image and is
11 truncated.
12
5d856da6
PE
132011-07-14 Paul Eggert <eggert@cs.ucla.edu>
14
ad6042bb
PE
15 Fix minor problems found by static checking.
16 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
17 (elsz): Now a signed constant, not a size_t var. We prefer signed
18 types to unsigned, to avoid integer comparison confusion. Without
19 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
20 "cannot optimize loop, the loop counter may overflow", a symptom
21 of the confusion.
f00bbb22 22 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
23 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
24
6468f31c
LMI
252011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
26
49080b10
LMI
27 * search.c (Fre_search_backward): Mention `case-fold-search' in
28 all the re_search_* functions (bug#8138).
29
6468f31c
LMI
30 * keyboard.c (Fopen_dribble_file): Document when the file is
31 closed (bug#8056).
32
c965adc5
EZ
332011-07-14 Eli Zaretskii <eliz@gnu.org>
34
df9733bf
EZ
35 * bidi.c (bidi_dump_cached_states): Fix format of displaying
36 bidi_cache_idx.
37
0bb23927
EZ
38 Support bidi reordering of display and overlay strings.
39 * xdisp.c (compute_display_string_pos)
40 (compute_display_string_end): Accept additional argument STRING.
41 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
42 (reseat_to_string): Initialize bidi_it->string.s and
43 bidi_it->string.schars.
44 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
45 NULL (avoids a crash in bidi_paragraph_init). Initialize
46 itb.string.lstring.
47 (init_iterator): Call bidi_init_it only of a valid
48 buffer position was specified. Initialize paragraph_embedding to
49 L2R.
50 (reseat_to_string): Initialize the bidi iterator.
51 (display_string): If we need to ignore text properties of
52 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
53 original value of -1 will not work with bidi.)
54 (compute_display_string_pos): First arg is now struct
55 `text_pos *'; all callers changed. Support display properties on
56 Lisp strings.
57 (compute_display_string_end): Support display properties on Lisp
58 strings.
59 (init_iterator, reseat_1, reseat_to_string): Initialize the
60 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
61 when iterating on a string not from display properties).
62 (compute_display_string_pos, compute_display_string_end): Fix
63 calculation of the object to scan. Fixes an error when using
64 arrow keys.
65 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
66 base_level_stop; instead, set base_level_stop to BEGV. Fixes
67 crashes in vertical-motion.
68 (next_element_from_buffer): Improve commentary for when
69 the iterator is before prev_stop.
70 (init_iterator): Initialize bidi_p from the default value of
71 bidi-display-reordering, not from buffer-local value. Use the
72 buffer-local value only if initializing for buffer iteration.
73 (handle_invisible_prop): Support invisible properties on strings
74 that are being bidi-reordered.
75 (set_iterator_to_next): Support bidi reordering of C strings and
76 Lisp strings.
77 (next_element_from_string): Support bidi reordering of Lisp
78 strings.
79 (handle_stop_backwards): Support Lisp strings as well.
80 (display_string): Support display of R2L glyph rows. Use
81 IT_STRING_CHARPOS when displaying from a Lisp string.
82 (init_iterator): Don't initialize it->bidi_p for strings
83 here.
84 (reseat_to_string): Initialize it->bidi_p for strings here.
85 (next_element_from_string, next_element_from_c_string)
86 (next_element_from_buffer): Add xassert's for correspondence
87 between IT's object being iterated and it->bidi_it.string
88 structure.
89 (face_before_or_after_it_pos): Support bidi iteration.
90 (next_element_from_c_string): Handle the case of the first string
91 character that is not the first one in the visual order.
92 (get_visually_first_element): New function, refactored from common
93 parts of next_element_from_buffer, next_element_from_string, and
94 next_element_from_c_string.
95 (tool_bar_lines_needed, redisplay_tool_bar)
96 (display_menu_bar): Force left-to-right direction. Add a FIXME
97 comment for making that be controlled by a user option.
98 (push_it, pop_it): Save and restore the state of the
99 bidi iterator. Save and restore the bidi_p flag.
100 (pop_it): Iterate out of display property for string iteration as
101 well.
102 (iterate_out_of_display_property): Support iteration over strings.
103 (handle_single_display_spec): Set up it->bidi_it for iteration
104 over a display string, and call bidi_init_it.
105 (handle_single_display_spec, next_overlay_string)
106 (get_overlay_strings_1, push_display_prop): Set up the bidi
107 iterator for displaying display or overlay strings.
108 (forward_to_next_line_start): Don't use the shortcut if
109 bidi-iterating.
110 (back_to_previous_visible_line_start): If handle_display_prop
111 pushed the iterator stack, restore the internal state of the bidi
112 iterator by calling bidi_pop_it same number of times.
113 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
114 and we are bidi-iterating, don't decrement the iterator position;
115 instead, set the first_elt flag in the bidi iterator, to produce
116 the same effect.
117 (reseat_1): Remove redundant setting of string_from_display_prop_p.
118 (push_display_prop): xassert that we are iterating a buffer.
119 (push_it, pop_it): Save and restore paragraph_embedding member.
120 (handle_single_display_spec, next_overlay_string)
121 (get_overlay_strings_1, reseat_1, reseat_to_string)
122 (push_display_prop): Set up the `unibyte' member of bidi_it.string
123 correctly. Don't assume unibyte strings are not bidi-reordered.
124 (compute_display_string_pos)
125 (compute_display_string_end): Fix handling the case of C string.
126 (push_it, pop_it): Save and restore from_disp_prop_p.
127 (handle_single_display_spec, push_display_prop): Set the
128 from_disp_prop_p flag.
129 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
130 (pop_it): Call iterate_out_of_display_property only if we are
131 popping after iteration over a string that came from a display
132 property. Fix a typo in popping stretch info. Add an assertion
133 for verifying that the iterator position is in sync with the bidi
134 iterator.
135 (handle_single_display_spec, get_overlay_strings_1)
136 (push_display_prop): Fix initialization of paragraph direction for
137 string when that of the parent object is not yet determined.
138 (reseat_1): Call bidi_init_it to resync the bidi
139 iterator with IT's position. (Bug#7616)
140 (find_row_edges): If ROW->start.pos gives position
141 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
142 (handle_stop, back_to_previous_visible_line_start, reseat_1):
143 Reset the from_disp_prop_p flag.
144 (SAVE_IT, RESTORE_IT): New macros.
145 (pos_visible_p, face_before_or_after_it_pos)
146 (back_to_previous_visible_line_start)
147 (move_it_in_display_line_to, move_it_in_display_line)
148 (move_it_to, move_it_vertically_backward, move_it_by_lines)
149 (try_scrolling, redisplay_window, display_line): Use them when
150 saving a temporary copy of the iterator and restoring it back.
151 (back_to_previous_visible_line_start, reseat_1)
152 (init_iterator): Empty the bidi cache "stack".
153 (move_it_in_display_line_to): If iterator ended up at
154 EOL, but we never saw any buffer positions smaller than
155 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
156 motion in bidi-reordered lines.
157 (move_it_in_display_line_to): Record prev_method and prev_pos
158 immediately before the call to set_iterator_to_next. Fixes cursor
159 motion in bidi-reordered lines with stretch glyphs and strings
160 displayed in margins. (Bug#8133) (Bug#8867)
161 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
162 TO_CHARPOS.
163 (pos_visible_p): Support positions in bidi-reordered lines. Save
164 and restore bidi cache.
165
166 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
167 (bidi_paragraph_info): Delete unused struct.
168 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
169 (bidi_cache_start): New variable.
170 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
171 to zero.
172 (bidi_cache_fetch_state, bidi_cache_search)
173 (bidi_cache_find_level_change, bidi_cache_iterator_state)
174 (bidi_cache_find, bidi_peek_at_next_level)
175 (bidi_level_of_next_char, bidi_find_other_level_edge)
176 (bidi_move_to_visually_next): Compare cache index with
177 bidi_cache_start rather than with zero.
178 (bidi_fetch_char): Accept new argument STRING; all callers
179 changed. Support iteration over a string. Support strings with
180 display properties. Support unibyte strings. Fix the type of
181 `len' according to what STRING_CHAR_AND_LENGTH expects.
182 (bidi_paragraph_init, bidi_resolve_explicit_1)
183 (bidi_resolve_explicit, bidi_resolve_weak)
184 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
185 iteration over a string.
186 (bidi_set_sor_type, bidi_resolve_explicit_1)
187 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
188 can now be zero (for strings); special values 0 and -1 were
189 changed to -1 and -2, respectively.
190 (bidi_char_at_pos): New function.
191 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
192 Call it instead of FETCH_MULTIBYTE_CHAR.
193 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
194 initialized to valid values.
195 (bidi_init_it): Don't initialize charpos and bytepos with invalid
196 values.
197 (bidi_level_of_next_char): Allow the sentinel "position" to pass
198 the test for valid cached positions. Fix the logic for looking up
199 the sentinel state in the cache. GCPRO the Lisp string we are
200 iterating.
201 (bidi_push_it, bidi_pop_it): New functions.
202 (bidi_initialize): Initialize the bidi cache start stack pointer.
203 (bidi_cache_ensure_space): New function, refactored from part of
204 bidi_cache_iterator_state. Don't assume the required size is just
205 one BIDI_CACHE_CHUNK away.
206 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
207 (bidi_count_bytes, bidi_char_at_pos): New functions.
208 (bidi_cache_search): Don't assume bidi_cache_last_idx is
209 always valid if bidi_cache_idx is valid.
210 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
211 is valid if it's going to be used.
212 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
213 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
214 (bidi_cache_find_level_change, bidi_cache_ensure_space)
215 (bidi_cache_iterator_state, bidi_cache_find)
216 (bidi_find_other_level_edge, bidi_cache_start_stack): All
217 variables related to cache indices are now EMACS_INT.
218
0bb23927
EZ
219 * dispextern.h (struct bidi_string_data): New structure.
220 (struct bidi_it): New member `string'. Make flag members be 1-bit
221 fields, and put them last in the struct.
222 (compute_display_string_pos, compute_display_string_end): Update
223 prototypes.
224 (bidi_push_it, bidi_pop_it): Add prototypes.
225 (struct iterator_stack_entry): New members bidi_p,
226 paragraph_embedding, and from_disp_prop_p.
227 (struct it): Member bidi_p is now a bit field 1 bit wide.
228 (bidi_shelve_cache, bidi_unshelve_cache): Declare
229 prototypes.
230
231 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
232 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
233 and vector-like objects.
234
235 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
236 cache around display iteration.
237
238 * window.c (Fwindow_end, window_scroll_pixel_based)
239 (displayed_window_lines, Frecenter): Save and restore the bidi
240 cache around display iteration.
241
3bbd2265
LMI
2422011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
243
244 * editfns.c (Fdelete_region): Clarify the use of the named
245 parameters (bug#6788).
246
adc47434
MR
2472011-07-14 Martin Rudalics <rudalics@gmx.at>
248
249 * indent.c (Fvertical_motion): Set and restore w->pointm when
250 saving and restoring the window's buffer (Bug#9006).
251
837c31f8
LMI
2522011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
253
254 * editfns.c (Fstring_to_char): Clarify just what is returned
255 (bug#6576). Text by Eli Zaretskii.
256
ac389d0c
JB
2572011-07-13 Juanma Barranquero <lekktu@gmail.com>
258
259 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
260
0be0ce47
EZ
2612011-07-13 Eli Zaretskii <eliz@gnu.org>
262
263 * buffer.c (mmap_find): Fix a typo.
264
cd18e7e3
JB
2652011-07-13 Johan Bockgård <bojohan@gnu.org>
266
267 Fix execution of x selection hooks.
268 * xselect.c (Qx_lost_selection_functions)
269 (Qx_sent_selection_functions): New vars.
270 (syms_of_xselect): DEFSYM them.
271 (x_handle_selection_request): Pass Qx_sent_selection_functions
272 rather than Vx_sent_selection_functions to Frun_hook_with_args.
273 (x_handle_selection_clear,x_clear_frame_selections):
274 Pass Qx_lost_selection_functions rather than
275 Vx_lost_selection_functions to Frun_hook_with_args.
276
47ea7f44
PE
2772011-07-13 Paul Eggert <eggert@cs.ucla.edu>
278
ac389d0c 279 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
280 The old code sometimes used this field without initializing it.
281
47ea7f44
PE
282 * alloc.c (gc_sweep): Don't read past end of array.
283 In theory, the old code could also have corrupted Emacs internals,
284 though it'd be very unlikely.
285
bc985c87
AS
2862011-07-12 Andreas Schwab <schwab@linux-m68k.org>
287
288 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 289 argument. (Bug#4026)
bc985c87 290
0cf34688
LMI
2912011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
292
b3dadd76
LMI
293 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
294 key" (bug#4257).
295
0cf34688
LMI
296 * window.c (Fset_window_start): Doc fix (bug#4199).
297 (Fset_window_hscroll): Ditto.
298
270768cd
PE
2992011-07-12 Paul Eggert <eggert@cs.ucla.edu>
300
077e3dda 301 Fix minor new problems caught by GCC 4.6.1.
270768cd 302 * term.c (init_tty): Remove unused local.
490011a6 303 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 304 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 305 not used otherwise.
270768cd 306
b1f58454
CY
3072011-07-12 Chong Yidong <cyd@stupidchicken.com>
308
309 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
310
22b9578d
LMI
3112011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
312
6e70ab07
LMI
313 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
314 are the mini-buffer and the echo area (bug#3320).
315
22b9578d
LMI
316 * term.c (init_tty): Remove support for supdup, c10 and perq
317 terminals, which are no longer supported (bug#1482).
318
8974cc9f
JB
3192011-07-10 Johan Bockgård <bojohan@gnu.org>
320
321 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
322
a560d974
JD
3232011-07-10 Jan Djärv <jan.h.d@swipnet.se>
324
325 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
326 for non-popups (Bug#3642).
327
1dae0f0a
AS
3282011-07-10 Andreas Schwab <schwab@linux-m68k.org>
329
268c2c36 330 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 331 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
332 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
333 * cm.c (losecursor): Likewise.
1dae0f0a
AS
334 * data.c (fmod): Likewise.
335 * dispnew.c (swap_glyphs_in_rows): Likewise.
336 * emacs.c (memory_warning_signal): Likewise.
337 * floatfns.c (float_error): Likewise.
338 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
339 (otf_open, font_otf_capability, generate_otf_features)
340 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
341 Likewise.
342 * image.c (pbm_read_file): Likewise.
343 * indent.c (string_display_width): Likewise.
344 * intervals.c (check_for_interval, search_for_interval)
345 (inc_interval_count, count_intervals, root_interval)
346 (adjust_intervals_for_insertion, make_new_interval): Likewise.
347 * lread.c (defalias): Likewise.
268c2c36 348 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
349 * regex.c (set_image_of_range_1, set_image_of_range)
350 (regex_grow_registers): Likewise.
351 * sysdep.c (strerror): Likewise.
352 * termcap.c (valid_filename_p, tprint, main): Likewise.
353 * tparam.c (main): Likewise.
354 * unexhp9k800.c (run_time_remap, save_data_space)
355 (update_file_ptrs, read_header, write_header, calculate_checksum)
356 (copy_file, copy_rest, display_header): Likewise.
357 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
358 Likewise.
359 * xdisp.c (check_it): Likewise.
360 * xfaces.c (register_color, unregister_color, unregister_colors):
361 Likewise.
362 * xfns.c (print_fontset_result): Likewise.
363 * xrdb.c (member, fatal, main): Likewise.
364
99033785
PE
3652011-07-10 Paul Eggert <eggert@cs.ucla.edu>
366
367 Fix minor problems found by static checking (Bug#9031).
368 * chartab.c (char_table_set_range, map_sub_char_table):
369 Remove unused locals.
370 (uniprop_table): Now static.
371 * composite.c (_work_char): Remove unused static var.
372
9cb2ac56
JB
3732011-07-09 Juanma Barranquero <lekktu@gmail.com>
374
375 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
376
f25661f0
JD
3772011-07-09 Jan Djärv <jan.h.d@swipnet.se>
378
379 * gtkutil.c (qttip_cb): Remove code without function.
380
8278c4fe
EZ
3812011-07-09 Eli Zaretskii <eliz@gnu.org>
382
383 * w32.c (pthread_sigmask): New stub.
384
1692ae2d 3852011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 386
8a6ebd58 387 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
388 sigprocmask is portable only for single-threaded applications, and
389 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
390 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
391 (LIBES): Use it.
392 * callproc.c (Fcall_process):
393 * process.c (create_process):
394 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
395 Use pthread_sigmask, not sigprocmask.
123403e4 396
1b854618
JD
3972011-07-08 Jan Djärv <jan.h.d@swipnet.se>
398
399 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
400 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
401 wrong (Bug#8591).
402
3fe4b549
JD
4032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
404
0ce7e563
JD
405 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
406 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
407 (xg_hide_tooltip): Fix comment.
408
3fe4b549
JD
409 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
410 in registerServicesMenuSendTypes.
411 (validRequestorForSendType): Don't check ns_return_types.
412
413 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
414 ns_return_type.
415
5df75e47
JR
4162011-07-08 Jason Rumney <jasonr@gnu.org>
417
418 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
419 frame struct members of non-existent frames (Bug#6284).
420
699c10bd
JD
4212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
422
4393663b
JD
423 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
424 variable firstTime not needed on OSX >= 10.6.
425 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
426 >= 10.5. Use setKnobProportion, setDoubleValue.
427
428 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
429 (MAC_OS_X_VERSION_10_5): Define if not defined.
430 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
431 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
432 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
433
434 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
435 cString and lossyCString on OSX >= 10.4
436
437 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
438 sizeToFit on OSX >= 10.2.
439
440 * nsimage.m (allocInitFromFile): Don't use deprecated method
441 bestRepresentationForDevice on OSX >= 10.6.
442
443 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
444 to avoid warning.
445
446 * emacs.c: Declare unexec_init_emacs_zone.
447
a63e0781
JD
448 * nsgui.h: Fix compiler warning about gnulib redefining verify.
449
699c10bd
JD
450 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
451
452 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
453 on svcsMenu (Bug#8842).
454
455 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
456 ns_return_types.
457 (Fns_list_services): Just return Qnil on 10.6, code not working there.
458
459 * nsterm.m (QUTF8_STRING): Declare.
460 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
461 (validRequestorForSendType): Return type is (id).
462 Change indexOfObjectIdenticalTo to indexOfObject.
463 Check if we have local selection before returning self (Bug#8842).
464 (writeSelectionToPasteboard): Put local selection into paste board
465 if we have a local selection (Bug#8842).
466 (syms_of_nsterm): DEFSYM QUTF8_STRING.
467
468 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
469 (ns_get_local_selection): Declare.
470
54e10184
LMI
4712011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
472
9888ff71
LMI
473 * keymap.c (describe_map_tree): Don't insert a double newline at
474 the end of the buffer (bug#1169) and return whether we inserted
475 something.
476
54e10184
LMI
477 * callint.c (Fcall_interactively): Change "reading args" to
478 "providing args" to try to clarify what it does (bug#1010).
479
15fa4783
KH
4802011-07-07 Kenichi Handa <handa@m17n.org>
481
482 * composite.c (composition_compute_stop_pos): Ignore a static
483 composition starting before CHARPOS (Bug#8915).
484
485 * xdisp.c (handle_composition_prop): Likewise.
486
a8815b00
EZ
4872011-07-07 Eli Zaretskii <eliz@gnu.org>
488
489 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
490 (Bug#9015)
491
ef7b981d 4922011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
493
494 * character.h (unicode_category_t): New enum type.
495
496 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
497 (Qchar_code_property_table): New variable.
498 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
499 (UNIPROP_COMPRESSED_FORM_P): New macros.
500 (char_table_ascii): Uncompress the compressed values.
501 (sub_char_table_ref): New arg is_uniprop. Callers changed.
502 Uncompress the compressed values.
ac389d0c 503 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
504 (char_table_ref_and_range): Uncompress the compressed values.
505 (sub_char_table_set): New arg is_uniprop. Callers changed.
506 Uncompress the compressed values.
507 (sub_char_table_set_range): Args changed. Callers changed.
508 (char_table_set_range): Adjuted for the above change.
509 (map_sub_char_table): Delete args default_val and parent. Add arg
510 top. Give decoded values to a Lisp function.
511 (map_char_table): Adjusted for the above change. Give decoded
512 values to a Lisp function. Gcpro more variables.
513 (uniprop_table_uncompress)
514 (uniprop_decode_value_run_length): New functions.
515 (uniprop_decoder, uniprop_decoder_count): New variables.
516 (uniprop_get_decoder, uniprop_encode_value_character)
517 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
518 New functions.
519 (uniprop_encoder, uniprop_encoder_count): New variables.
520 (uniprop_get_encoder, uniprop_table)
521 (Funicode_property_table_internal, Fget_unicode_property_internal)
522 (Fput_unicode_property_internal): New functions.
523 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
524 Sunicode_property_table_internal, Sget_unicode_property_internal,
525 and Sput_unicode_property_internal. Defvar_lisp
526 char-code-property-alist.
527
528 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
529 Vunicode_category_table.
530
531 * font.c (font_range): Adjusted for the change of
532 Vunicode_category_table.
533
76b397fb
DN
5342011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
535
536 * m/iris4d.h: Remove file, move contents ...
537 * s/irix6-5.h: ... here.
538
22b4128e
PE
5392011-07-06 Paul Eggert <eggert@cs.ucla.edu>
540
541 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
542 * alloc.c (mark_buffer):
543 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
544 (clone_per_buffer_values): Don't assume that
22b4128e
PE
545 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
546 This isn't true in general, and it's particularly not true
547 if Emacs is configured with --with-wide-int.
548 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
549 New macros, used in the buffer.c change.
550
869795d6
JD
5512011-07-05 Jan Djärv <jan.h.d@swipnet.se>
552
553 * xsettings.c: Use both GConf and GSettings if both are available.
554 (store_config_changed_event): Add comment.
555 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
556 (store_tool_bar_style_changed): New functions.
557 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
558 (struct xsettings): Move font inside HAVE_XFT.
559 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
560 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
561 Move inside HAVE_XFT.
562 (something_changed_gsettingsCB): Renamed from something_changedCB.
563 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
564 also.
565 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
566 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
567 (something_changed_gconfCB): Renamed from something_changedCB.
568 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
569 (parse_settings): Move check for font inside HAVE_XFT.
570 (read_settings, apply_xft_settings): Add comment.
571 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
572 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
573 call store_font_name_changed.
574 (xft_settings_event): Add comment.
575 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
576 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
577 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
578 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
579 (xsettings_initialize): Call init_gsettings last.
580 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
581 comment.
582
d8ed26bd
PE
5832011-07-05 Paul Eggert <eggert@cs.ucla.edu>
584
585 Random fixes. E.g., (random) never returned negative values.
586 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
587 subseconds part to the entropy, as that's a bit more random.
588 Prefer signed to unsigned, since the signedness doesn't matter and
589 in general we prefer signed. When given a limit, use a
590 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
591 latter isn't right if USE_2_TAGS_FOR_INTS.
592 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
593 not 0..VALMASK. Don't discard "excess" bits that random () returns.
594
cabf1cac
SM
5952011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
596
597 * textprop.c (text_property_stickiness):
598 Obey Vtext_property_default_nonsticky.
599 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
600 * w32fns.c (syms_of_w32fns):
601 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
602
6e9b2be9
PE
6032011-07-04 Paul Eggert <eggert@cs.ucla.edu>
604
605 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
606 This is more efficient than Ffile_directory_p and avoids a minor race.
607
90186c68
LMI
6082011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
609
7c301272
LMI
610 * buffer.c (Foverlay_put): Say what the return value is
611 (bug#7835).
612
c4f2d8d4
LMI
613 * fileio.c (barf_or_query_if_file_exists): Check first if the file
614 is a directory before asking whether to use the file name
615 (bug#7564).
ad637907
LMI
616 (barf_or_query_if_file_exists): Make the "File is a directory"
617 error be more correct.
c4f2d8d4 618
90186c68
LMI
619 * fns.c (Frequire): Remove the mention of the .gz files, since
620 that's installation-specific, but keep the mention of
621 `get-load-suffixes'.
622
da64016e
PE
6232011-07-04 Paul Eggert <eggert@cs.ucla.edu>
624
625 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
626 Report string overflow if the output is too long.
627
7d47b580
JB
6282011-07-04 Juanma Barranquero <lekktu@gmail.com>
629
a555cb87
JB
630 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
631 (syms_of_gnutls): Remove duplicate DEFSYM for
632 Qgnutls_bootprop_verify_hostname_error, an error for
633 Qgnutls_bootprop_verify_error (which is no longer used).
634
7d47b580
JB
635 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
636 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
637 Also (re)move comments that are misplaced or no longer relevant.
638
1e49bfab
LMI
6392011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
640
641 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
642
1485f4c0
CY
6432011-07-03 Chong Yidong <cyd@stupidchicken.com>
644
645 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
646 and background color parameters if they have been changed.
647
a9ab721e
LMI
6482011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
649
650 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
651
cf7cff57
PE
6522011-07-03 Paul Eggert <eggert@cs.ucla.edu>
653
2e13213d
PE
654 * xsettings.c (SYSTEM_FONT): Define only when used.
655 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
656
cf7cff57
PE
657 * keymap.c (access_keymap_1): Now static.
658
7a8e04f7
CY
6592011-07-02 Chong Yidong <cyd@stupidchicken.com>
660
661 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
662 leave any prefix arg for the up event (Bug#1586).
663
61352f62
LMI
6642011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
665
69bb1ef7
LMI
666 * lread.c (syms_of_lread): Mention single symbols defined by
667 `defvar' or `defconst' (bug#7154).
668
61352f62 669 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 670 (Frequire): Mention get-load-suffixes.
61352f62 671
28545e04
MR
6722011-07-02 Martin Rudalics <rudalics@gmx.at>
673
674 * window.h (window): Remove clone_number slot.
675 * window.c (Fwindow_clone_number, Fset_window_clone_number):
676 Remove.
677 (make_parent_window, make_window, saved_window)
678 (Fset_window_configuration, save_window_save): Don't deal with
679 clone numbers.
680 * buffer.c (Qclone_number): Remove declaration.
681 (sort_overlays, overlay_strings): Don't deal with clone numbers.
682
3349e122
SM
6832011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
684
685 Add multiple inheritance to keymaps.
686 * keymap.c (Fmake_composed_keymap): New function.
687 (Fset_keymap_parent): Simplify.
688 (fix_submap_inheritance): Remove.
689 (access_keymap_1): New function extracted from access_keymap to handle
690 embedded parents and handle lists of maps.
691 (access_keymap): Use it.
692 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
693 (Fcopy_keymap): Handle embedded parents.
694 (Fcommand_remapping, define_as_prefix): Simplify.
695 (Fkey_binding): Simplify.
696 (syms_of_keymap): Move minibuffer-local-completion-map,
697 minibuffer-local-filename-completion-map,
698 minibuffer-local-must-match-map, and
699 minibuffer-local-filename-must-match-map to Elisp.
700 (syms_of_keymap): Defsubr make-composed-keymap.
701 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
702 (parse_menu_item): Trivial simplification.
703
3279eb87
GM
7042011-07-01 Glenn Morris <rgm@gnu.org>
705
706 * Makefile.in (SETTINGS_LIBS): Fix typo.
707
4550efdf
KI
7082011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
709
710 * coding.c (Fencode_coding_string): Record the last coding system
711 used, as the function doc string says (bug#8738).
712
0949d2b6
JD
7132011-07-01 Jan Djärv <jan.h.d@swipnet.se>
714
715 * xsettings.c (store_monospaced_changed): Take new font as arg and
716 check for change against current_mono_font.
717 (EMACS_TYPE_SETTINGS): Remove this and related defines.
718 (emacs_settings_constructor, emacs_settings_get_property)
719 (emacs_settings_set_property, emacs_settings_class_init)
720 (emacs_settings_init, gsettings_obj): Remove.
721 (something_changedCB): New function for HAVE_GSETTINGS.
722 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
723 with value as argument.
724 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
725 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 726 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
727 "changed".
728
729 * xgselect.c: Add defined (HAVE_GSETTINGS).
730 (xgselect_initialize): Ditto.
731
732 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
733 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
734 xg_select.
735
bbc6b304
PE
7362011-07-01 Paul Eggert <eggert@cs.ucla.edu>
737
738 * eval.c (struct backtrace): Simplify and port the data structure.
739 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
740 signed bit field, as this assumption is not portable and it makes
741 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
742 "char debug_on_exit : 1" as this is not portable either; instead,
743 use the portable "unsigned int debug_on_exit : 1". Remove unused
744 member evalargs. Remove obsolete comments about cc bombing out.
745
9851bfc5
JD
7462011-06-30 Jan Djärv <jan.h.d@swipnet.se>
747
51bb811f 748 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
749 Let HAVE_GSETTINGS override HAVE_GCONF.
750 (store_monospaced_changed): New function.
751 (EMACS_SETTINGS): A new type derived from GObject to handle
752 GSettings notifications.
753 (emacs_settings_constructor, emacs_settings_get_property)
754 (emacs_settings_set_property, emacs_settings_class_init):
755 New functions.
756 (gsettings_client, gsettings_obj): New variables.
757 (GSETTINGS_SCHEMA): New define.
758 (something_changedCB): Call store_monospaced_changed.
759 (init_gsettings): New function.
760 (xsettings_initialize): Call init_gsettings.
761 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
762 to NULL.
763
764 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
765 GCONF_CFLAGS/LIBS.
766
5386012d
MR
7672011-06-29 Martin Rudalics <rudalics@gmx.at>
768
769 * window.c (resize_root_window, grow_mini_window)
770 (shrink_mini_window): Rename Qresize_root_window to
771 Qwindow_resize_root_window and Qresize_root_window_vertically to
772 Qwindow_resize_root_window_vertically.
773
f13e0b08
PE
7742011-06-28 Paul Eggert <eggert@cs.ucla.edu>
775
776 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
777
94515237
JB
7782011-06-27 Juanma Barranquero <lekktu@gmail.com>
779
780 * makefile.w32-in: Redesign dependencies so they reflect more
781 clearly which files are directly included by each source file,
782 and not through other includes.
783
e43b6e43
MR
7842011-06-27 Martin Rudalics <rudalics@gmx.at>
785
786 * buffer.c (Qclone_number): Declare static and DEFSYM it.
787 (sort_overlays, overlay_strings): When an overlay's clone number
788 matches the window's clone number process the overlay even if
789 the overlay's window property doesn't match the current window.
790
d68443dc
MR
791 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
792 (Fwindow_hchild): Rename to Fwindow_left_child.
793 (Fwindow_next): Rename to Fwindow_next_sibling.
794 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
795 (resize_window_check): Rename to window_resize_check.
796 (resize_window_apply): Rename to window_resize_apply.
797 (Fresize_window_apply): Rename to Fwindow_resize_apply.
798 (Fdelete_other_windows_internal, resize_frame_windows)
799 (Fsplit_window_internal, Fdelete_window_internal)
800 (grow_mini_window, shrink_mini_window)
801 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 802
c7e73be5
JD
8032011-06-26 Jan Djärv <jan.h.d@swipnet.se>
804
805 * emacsgtkfixed.h: State that this is only used with Gtk+3.
806 (emacs_fixed_set_min_size): Remove.
807 (emacs_fixed_new): Take frame as argument.
808
809 * emacsgtkfixed.c: State that this is only used with Gtk+3.
810 (_EmacsFixedPrivate): Remove minwidth/height.
811 Add struct frame *f.
812 (emacs_fixed_init): Initialize priv->f.
813 (get_parent_class, emacs_fixed_set_min_size): Remove.
814 (emacs_fixed_new): Set priv->f to argument.
815 (emacs_fixed_get_preferred_width)
816 (emacs_fixed_get_preferred_height): Use min_width/height from
817 frames size_hint to set minimum and natural (Bug#8919).
818 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
819 and use min_width/height from frames size_hint to set
820 min_width/height (Bug#8919).
821
822 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
823 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
824 Fix indentation.
c7e73be5 825
cf99dcf8
EZ
8262011-06-26 Eli Zaretskii <eliz@gnu.org>
827
828 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
829 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
830 called at ZV.
831
029529ac
CY
8322011-06-26 Chong Yidong <cyd@stupidchicken.com>
833
834 * process.c (wait_reading_process_output): Bypass select if
835 waiting for a cell while ignoring keyboard input, and input is
836 pending. Suggested by Jan Djärv (Bug#8869).
837
7a7ef429
PE
8382011-06-25 Paul Eggert <eggert@cs.ucla.edu>
839
840 Use gnulib's dup2 module instead of rolling our own.
841 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
842
11fdef7d 8432011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
844
845 * dispnew.c (scrolling_window): Before scrolling, turn off a
846 mouse-highlight in the window being scrolled.
847
cd3520a4
JB
8482011-06-24 Juanma Barranquero <lekktu@gmail.com>
849
850 Move DEFSYM to lisp.h and use everywhere.
851
852 * character.h (DEFSYM): Move declaration...
853 * lisp.h (DEFSYM): ...here.
854
855 * gnutls.c:
856 * minibuf.c:
857 * w32menu.c:
858 * w32proc.c:
859 * w32select.c: Don't include character.h.
860
861 * alloc.c (syms_of_alloc):
862 * buffer.c (syms_of_buffer):
863 * bytecode.c (syms_of_bytecode):
864 * callint.c (syms_of_callint):
865 * casefiddle.c (syms_of_casefiddle):
866 * casetab.c (init_casetab_once):
867 * category.c (init_category_once, syms_of_category):
868 * ccl.c (syms_of_ccl):
869 * cmds.c (syms_of_cmds):
870 * composite.c (syms_of_composite):
871 * dbusbind.c (syms_of_dbusbind):
872 * dired.c (syms_of_dired):
873 * dispnew.c (syms_of_display):
874 * doc.c (syms_of_doc):
875 * editfns.c (syms_of_editfns):
876 * emacs.c (syms_of_emacs):
877 * eval.c (syms_of_eval):
878 * fileio.c (syms_of_fileio):
879 * fns.c (syms_of_fns):
880 * frame.c (syms_of_frame):
881 * fringe.c (syms_of_fringe):
882 * insdel.c (syms_of_insdel):
883 * keymap.c (syms_of_keymap):
884 * lread.c (init_obarray, syms_of_lread):
885 * macros.c (syms_of_macros):
886 * msdos.c (syms_of_msdos):
887 * print.c (syms_of_print):
888 * process.c (syms_of_process):
889 * search.c (syms_of_search):
890 * sound.c (syms_of_sound):
891 * syntax.c (init_syntax_once, syms_of_syntax):
892 * terminal.c (syms_of_terminal):
893 * textprop.c (syms_of_textprop):
894 * undo.c (syms_of_undo):
895 * w32.c (globals_of_w32):
896 * window.c (syms_of_window):
897 * xdisp.c (syms_of_xdisp):
898 * xfaces.c (syms_of_xfaces):
899 * xfns.c (syms_of_xfns):
900 * xmenu.c (syms_of_xmenu):
901 * xsettings.c (syms_of_xsettings):
902 * xterm.c (syms_of_xterm): Use DEFSYM.
903
4228cf16
TZ
9042011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
905
cd3520a4 906 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 907
7fcccf1e
PE
9082011-06-23 Paul Eggert <eggert@cs.ucla.edu>
909
7efb4e0e
PE
910 Integer and buffer overflow fixes (Bug#8873).
911
ff5844ad
PE
912 * print.c (printchar, strout): Check for string overflow.
913 (PRINTPREPARE, printchar, strout):
914 Don't set size unless allocation succeeds.
915
90532f02
PE
916 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
917 for sizes. Check for string overflow more accurately.
918 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
919
6d84508d
PE
920 * macros.c: Integer and buffer overflow fixes.
921 * keyboard.h (struct keyboard.kbd_macro_bufsize):
922 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
923 Use ptrdiff_t, not int, for sizes.
924 Don't increment bufsize until after realloc succeeds.
925 Check for size-calculation overflow.
926 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
927
437b2cb4
PE
928 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
929
8b9ac8b4
PE
930 * lread.c: Integer overflow fixes.
931 (read_integer): Radix is now EMACS_INT, not int,
932 to improve quality of diagnostics for out-of-range radices.
933 Calculate buffer size correctly for out-of-range radices.
934 (read1): Check for integer overflow in radices, and in
935 read-circle numbers.
82cb60d3
PE
936 (read_escape): Avoid int overflow.
937 (Fload, openp, read_buffer_size, read1)
938 (substitute_object_recurse, read_vector, read_list, map_obarray):
939 Use ptrdiff_t, not int, for sizes.
940 (read1): Use EMACS_INT, not int, for sizes.
20270765 941 Check for size overflow.
8b9ac8b4 942
7fcccf1e
PE
943 * image.c (cache_image): Check for size arithmetic overflow.
944
bfbbd7e7
PE
945 * lread.c: Integer overflow issues.
946 (saved_doc_string_size, saved_doc_string_length)
947 (prev_saved_doc_string_size, prev_saved_doc_string_length):
948 Now ptrdiff_t, not int.
949 (read1): Don't assume doc string length fits in int. Check for
950 out-of-range doc string lengths.
951 (read_list): Don't assume file position fits in int.
39019e54 952 (read_escape): Check for hex character overflow.
bfbbd7e7 953
4e323265
LL
9542011-06-22 Leo Liu <sdl.web@gmail.com>
955
956 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
957 Move to minibuffer.el.
958
85fece3e
PE
9592011-06-22 Paul Eggert <eggert@cs.ucla.edu>
960
20b84ce9 961 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
962 The following patches are for when GLYPH_DEBUG && !XASSERT.
963 * dispextern.h (trace_redisplay_p, dump_glyph_string):
964 * dispnew.c (flush_stdout):
965 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
966 Mark as externally visible.
967 * dispnew.c (check_window_matrix_pointers): Now static.
968 * dispnew.c (window_to_frame_vpos):
969 * xfns.c (unwind_create_frame):
970 * xterm.c (x_check_font): Remove unused local.
971 * scroll.c (CHECK_BOUNDS):
972 * xfaces.c (cache_fache): Rename local to avoid shadowing.
973 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
974 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
975 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
976 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
977 Now static.
978 (debug_method_add): Use va_list and vsprintf rather than relying
979 on undefined behavior with wrong number of arguments.
980 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
981 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
982 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
983 since we're not interested in debugging glyphs with old libraries.
984 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
985 GCC 4.6.0's static checking.
986
0766b489
PE
9872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
988
31fd4b32
PE
989 Integer overflow and signedness fixes (Bug#8873).
990 A few related buffer overrun fixes, too.
991
b79e8648
PE
992 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
993
0766b489
PE
994 * dispextern.h (struct face.stipple):
995 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
996 (x_bitmap_mask, x_allocate_bitmap_record)
997 (x_create_bitmap_from_data, x_create_bitmap_from_file)
998 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
999 (x_create_bitmap_from_xpm_data):
1000 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1001 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1002 (.bitmaps_last):
1003 * xfaces.c (load_pixmap):
1004 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1005 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1006 (.bitmaps_last, struct x_output.icon_bitmap):
1007 Use ptrdiff_t, not int, for bitmap indexes.
1008 (x_allocate_bitmap_record): Check for size overflow.
1009 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1010
b081724f
PE
1011 Use ptrdiff_t, not int, for overlay counts.
1012 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1013 * editfns.c (overlays_around, get_pos_property):
1014 * textprop.c (get_char_property_and_overlay):
1015 * xdisp.c (next_overlay_change, note_mouse_highlight):
1016 * xfaces.c (face_at_buffer_position):
21514da7
PE
1017 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1018 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1019 (Fnext_overlay_change, Fprevious_overlay_change)
1020 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1021 Use ptrdiff_t, not int, for sizes.
21514da7 1022 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1023
3de73e5e
PE
1024 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1025
2606c57b
PE
1026 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1027 (x_session_initialize): Do not assume string length fits in int.
1028
aaafe47a
PE
1029 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1030 This is unlikely, but can occur if DPI is outlandish.
1031
2674ddc8 1032 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1033 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1034
28154962
PE
1035 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1036 * xrdb.c (magic_file_p, search_magic_path):
1037 Omit last arg SUFFIX; it was always 0. All callers changed.
1038 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1039
7de51af5
PE
1040 * xfont.c (xfont_match): Avoid need for strlen.
1041
25ed6cc3
PE
1042 * xfns.c: Don't assume strlen fits in int.
1043 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1044
4eab31dd
PE
1045 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1046 not unsigned long, as we prefer signed integers. All callers changed.
1047 Detect integer overflow in repeat count.
1048 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1049 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1050
171e2a58
PE
1051 * termcap.c: Don't assume sizes fit in int and never overflow.
1052 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1053 (gobble_line): Check for size-calculation overflow.
1054
ad39faca 1055 * minibuf.c (Fread_buffer):
6e5bb2dc 1056 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1057 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1058 Don't assume string length fits in int.
1059
52c61c22 1060 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1061 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1062
b5b8c9e5
PE
1063 * font.c: Don't assume string length fits in int.
1064 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1065 Use ptrdiff_t, not int.
ccd6111c
PE
1066 (font_intern_prop): Don't assume string length fits in int.
1067 Don't assume integer property fits in fixnum.
1068 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1069
882f0d81 1070 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1071 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1072 Reformulate so as not to need the command string.
1073 Invoke gzip -cd rather than gunzip, as it's more portable.
1074 (lock_info_type, lock_file_1, lock_file):
1075 Don't assume pid_t and time_t fit in unsigned long.
1076 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1077 (current_lock_owner): Prefer signed type for sizes.
1078 Use memcpy, not strncpy, where memcpy is what is really wanted.
1079 Don't assume (via atoi) that time_t and pid_t fit in int.
1080 Check for time_t and/or pid_t out of range, e.g., via a network share.
1081 Don't alloca where an auto var works fine.
1082
93f4cf88
PE
1083 * fileio.c: Fix some integer overflow issues.
1084 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1085 Don't assume string length fits in int.
1086 (directory_file_name): Don't assume string length fits in long.
1087 (make_temp_name): Don't assume pid fits in int, or that its print
1088 length is less than 20.
1089
f3e92b69
PE
1090 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1091
1bfdaf10
PE
1092 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1093
35016e9a
PE
1094 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1095
3d1e65a1
PE
1096 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1097 We prefer signed integers, even for size calculations.
1098
0b963a93
PE
1099 * emacs.c: Don't assume string length fits in 'int'.
1100 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1101 (main): Don't invoke strlen when not needed.
1102
573f4b54
PE
1103 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1104 (XD_DEBUG_MESSAGE): Don't waste a byte.
1105
989f33ba
PE
1106 * callproc.c (getenv_internal_1, getenv_internal)
1107 (Fgetenv_internal):
965d34eb
PE
1108 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1109
e4d29b33
PE
1110 * lread.c (invalid_syntax): Omit length argument.
1111 All uses changed. This doesn't fix a bug, but it simplifies the
1112 code away from its former Hollerith-constant appearance, and it's
1113 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1114 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1115
eb49b136
PE
1116 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1117 This didn't break anything, but it didn't help either.
1118 It's confusing to put a bogus integer in a place where the actual
1119 value does not matter.
9f62aeb1 1120 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1121 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1122
15375a22
PE
1123 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1124 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1125 implementation.
b61cc01c
PE
1126 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1127 We prefer signed types, and the value cannot exceed the EMACS_INT
1128 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1129 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1130 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1131 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1132
53b2623d
PE
1133 * indent.c (sane_tab_width): New function.
1134 (current_column, scan_for_column, Findent_to, position_indentation)
1135 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1136 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1137
51cab52b 1138 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1139
f2ed8a70
PE
1140 * lisp.h (lint_assume): New macro.
1141 * composite.c (composition_gstring_put_cache):
1142 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1143
abe80cc6
PE
1144 * editfns.c, insdel.c:
1145 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1146
b02c740e
PE
1147 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1148
ebc96716
PE
1149 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1150
b4e50fa0 1151 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1152 Use much-faster test for byte-length change.
311d5d7c 1153 Don't assume string byte-length fits in 'int'.
a4cf38e4 1154 Check that character arg fits in 'int'.
85461888 1155 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1156
c0c1ee9f
PE
1157 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1158
a498d7f4
PE
1159 * fns.c (concat): Catch string overflow earlier.
1160 Do not rely on integer wraparound.
1161
51cab52b
PE
1162 * dispextern.h (struct it.overlay_strings_charpos)
1163 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1164 * xdisp.c (forward_to_next_line_start)
1165 (back_to_previous_visible_line_start)
1166 (reseat_at_next_visible_line_start, next_element_from_buffer):
1167 Don't arbitrarily truncate the value of 'selective' to int.
1168
76031fad
PE
1169 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1170
5eb55db9
PE
1171 * composite.c: Don't truncate sizes to 'int'.
1172 (composition_gstring_p, composition_reseat_it)
1173 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1174 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1175 not EMACS_UINT, for indexes.
5eb55db9 1176
0703a717
PE
1177 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1178
d6202519
PE
1179 * buffer.c: Include <verify.h>.
1180 (struct sortvec.priority, struct sortstr.priority):
8961a454 1181 Now EMACS_INT, not int.
c20998a7 1182 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1183 (struct sortstr.size, record_overlay_string)
1184 (struct sortstrlist.size, struct sortlist.used):
1185 Don't truncate size to int.
1186 (record_overlay_string): Check for size-calculation overflow.
d6202519 1187 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1188
d5a19415
JM
11892011-06-22 Jim Meyering <meyering@redhat.com>
1190
029529ac 1191 Don't leak an XBM-image-sized buffer
d5a19415
JM
1192 * image.c (xbm_load): Free the image buffer after using it.
1193
a9041e6c
PE
11942011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1195
1196 Port to Sun C.
1197 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1198 that Sun C diagnosed.
1199 * fns.c (secure_hash): Fix pointer signedness issue.
1200 * intervals.c (static_offset_intervals): New function.
1201 (offset_intervals): Use it.
1202
7f3f739f
LL
12032011-06-21 Leo Liu <sdl.web@gmail.com>
1204
1205 * deps.mk (fns.o):
1206 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1207 sha512.h.
1208
1209 * fns.c (secure_hash): Rename from crypto_hash_function and change
1210 the first arg to accept symbols.
5b66d427 1211 (Fsecure_hash): New primitive.
7f3f739f
LL
1212 (syms_of_fns): New symbols.
1213
76147d94
DD
12142011-06-20 Deniz Dogan <deniz@dogan.se>
1215
1216 * process.c (Fset_process_buffer): Clarify return value in
1217 docstring.
1218
7d7d0045
CY
12192011-06-18 Chong Yidong <cyd@stupidchicken.com>
1220
1221 * dispnew.c (add_window_display_history): Use BVAR.
1222
1223 * xdisp.c (debug_method_add): Use BVAR.
1224 (check_window_end, dump_glyph_matrix, dump_glyph)
1225 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1226
1227 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1228 Likewise.
1229
1230 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1231 check till after the cache is created in init_frame_faces.
1232
ff2bc410
SM
12332011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1234
1235 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1236
28177add
PE
12372011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1238
dd3482fe
PE
1239 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1240 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1241 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1242
393d71f3 1243 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1244 * fileio.c (Finsert_file_contents):
1245 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1246 Remove the old (too-loose) buffer overflow checks.
1247 They weren't needed, since make_gap checks for buffer overflow.
1248 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1249 The old code merely checked for Emacs fixnum overflow, and relied
1250 on undefined (wraparound) behavior. The new code avoids undefined
1251 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1252
2e6813b0 1253 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1254 Tune. Don't use wider integers than needed. Don't use alloca.
1255 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1256
599a9e4f
PE
1257 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1258
99561444
PE
1259 * insdel.c, lisp.h (buffer_overflow): New function.
1260 (insert_from_buffer_1, replace_range, replace_range_2):
1261 * insdel.c (make_gap_larger):
1262 * editfns.c (Finsert_char):
1263 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1264
28177add
PE
1265 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1266
e69dafad
PE
12672011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1268
a7af7fde 1269 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1270
b1c46f02
PE
1271 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1272 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1273
e69dafad
PE
1274 * fileio.c: Don't assume EMACS_INT fits in off_t.
1275 (emacs_lseek): New static function.
1276 (Finsert_file_contents, Fwrite_region): Use it.
1277 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1278
566684ea
PE
1279 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1280
e6966cd6
PE
1281 * fns.c: Don't overflow int when computing a list length.
1282 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1283 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1284 truncation on 64-bit hosts. Check for QUIT every
1285 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1286 faster and is responsive enough.
1287 (Flength): Report an error instead of overflowing an integer.
1288 (Fsafe_length): Return a float if the value is not representable
1289 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1290 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1291 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1292
dd0b0efb
PE
1293 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1294 (header_size, word_size): New constants.
1295 (allocate_vectorlike): Don't check size overflow here.
1296 (allocate_vector): Check it here instead, since this is the only
1297 caller of allocate_vectorlike that could cause overflow.
1298 Check that the new vector's length is representable as a fixnum.
1299
86fe5cfe
PE
1300 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1301 The previous code was bogus. For example, next_almost_prime (32)
1302 returned 39, which is undesirable as it is a multiple of 3; and
1303 next_almost_prime (24) returned 25, which is a multiple of 5 so
1304 why was the code bothering to check for multiples of 7?
1305
80e88859
PE
1306 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1307
4a2f0ad6
PE
1308 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1309
f66c7cf8
PE
1310 Variadic C functions now count arguments with ptrdiff_t.
1311 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1312 Back then I didn't know that the Emacs coding style prefers signed int.
1313 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1314 were being counted with int, which may truncate counts on 64-bit
1315 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1316 * lisp.h (struct Lisp_Subr.function.aMANY)
1317 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1318 Arg counts are now ptrdiff_t, not size_t.
1319 All variadic functions and their callers changed accordingly.
1320 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1321 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1322 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1323 * callint.c (Fcall_interactively): Check arg count for overflow,
1324 to avoid potential buffer overrun. Use signed char, not 'int',
1325 for 'varies' array, so that we needn't bother to check its size
1326 calculation for overflow.
1327 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1328 * eval.c (apply_lambda):
1329 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1330 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1331 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1332
a1759b76
PE
1333 * callint.c (Fcall_interactively): Don't use index var as event count.
1334
d96be9fc
PE
1335 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1336 * mem-limits.h (SIZE): Remove; no longer used.
1337
a690a978 1338 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1339
578c21e6
PE
1340 Remove unnecessary casts.
1341 * xterm.c (x_term_init):
1342 * xfns.c (x_set_border_pixel):
1343 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1344 These aren't needed now that we assume ANSI C.
1345
96f53c6c
PE
1346 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1347 It's more likely to cause problems (due to unsigned overflow)
1348 than to cure them.
1349
83c77d31
PE
1350 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1351
ee2079f1
PE
1352 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1353
6da65536
PE
1354 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1355
7147c4a4
PE
1356 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1357
193e32d9
PE
1358 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1359
e5533da6
PE
1360 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1361
9910e595
PE
1362 GLYPH_CODE_FACE returns EMACS_INT, not int.
1363 * dispextern.h (merge_faces):
1364 * xfaces.c (merge_faces):
01103c44
PE
1365 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1366 Don't assume EMACS_INT fits in int.
9910e595 1367
2638320e
PE
1368 * character.h (CHAR_VALID_P): Remove unused parameter.
1369 * fontset.c, lisp.h, xdisp.c: All uses changed.
1370
045eb8d9
PE
1371 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1372
c1f134b5
PE
1373 * fns.c (concat): Minor tuning based on overflow analysis.
1374 This doesn't fix any bugs. Use int to hold character, instead
1375 of constantly refetching from Emacs object. Use XFASTINT, not
1376 XINT, for value known to be a character. Don't bother comparing
1377 a single byte to 0400, as it's always less.
1378
395fcb93 1379 * floatfns.c (Fexpt):
327eeec8
PE
1380 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1381
abbd3d23
PE
1382 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1383 for characters.
1384
684a03ef
PE
1385 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1386
0fed43f3
PE
1387 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1388 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1389 incorrectly succeed when S was a string, because 4294967386 was
1390 truncated before it was used.
1391
8fd02eb7
PE
1392 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1393 Otherwise, an out-of-range integer could cause undefined behavior
1394 on a 64-bit host.
1395
f8c86b69
PE
1396 * composite.c: Use int, not EMACS_INT, for characters.
1397 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1398 EMACS_INT, for values that are known to be in character range.
1399 This doesn't fix any bugs but is the usual style inside Emacs and
1400 may generate better code on 32-bit machines.
1401
34206dd2
PE
1402 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1403 This is for reasons similar to the recent CHAR_STRING fix.
1404 * charset.c (Fencode_char): Check that character arg is actually
1405 a character. Pass an int to ENCODE_CHAR.
1406 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1407 wider than 'int', as a compile-time check to prevent future regressions
1408 in this area.
1409
c5958d4c 1410 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1411
1412 Make sure a 64-bit char is never passed to CHAR_STRING.
1413 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1414 by silently ignoring the top 32 bits, allowing some values
1415 that were far too large to be valid characters.
1416 * character.h: Include <verify.h>.
1417 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1418 arguments are no wider than unsigned, as a compile-time check
1419 to prevent future regressions in this area.
1420 * data.c (Faset):
01103c44 1421 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1422 (Fsubst_char_in_region):
1423 * fns.c (concat):
1424 * xdisp.c (decode_mode_spec_coding):
1425 Adjust to CHAR_STRING's new requirement.
1426 * editfns.c (Finsert_char, Fsubst_char_in_region):
1427 * fns.c (concat): Check that character args are actually
1428 characters. Without this test, these functions did the wrong
1429 thing with wildly out-of-range values on 64-bit hosts.
1430
d37ca623
PE
1431 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1432 These casts should not be needed on 32-bit hosts, either.
1433 * keyboard.c (read_char):
1434 * lread.c (Fload): Remove casts to unsigned.
1435
ea204efb
PE
1436 * lisp.h (UNSIGNED_CMP): New macro.
1437 This fixes comparison bugs on 64-bit hosts.
1438 (ASCII_CHAR_P): Use it.
1439 * casefiddle.c (casify_object):
01103c44 1440 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1441 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1442 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1443 * dispextern.h (FACE_FROM_ID):
1444 * keyboard.c (read_char): Use UNSIGNED_CMP.
1445
41cb286c
PE
1446 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1447 not to EMACS_INT, to avoid GCC warning.
1448
4a1b9832
PE
1449 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1450
55daad71
PE
1451 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1452 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1453 isn't needed on 32-bit machines.
8f95c75c 1454
01103c44
PE
1455 * buffer.c (Fgenerate_new_buffer_name):
1456 Use EMACS_INT for count, not int.
0ceccced 1457 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1458
1459 * data.c (Qcompiled_function): Now static.
1460
c6f072e7
PE
1461 * window.c (window_body_lines): Now static.
1462
20ce5912
PE
1463 * image.c (gif_load): Rename local to avoid shadowing.
1464
9c4c5f81
PE
1465 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1466 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1467 * alloc.c (make_save_value): Integer argument is now of type
1468 ptrdiff_t, not int.
1469 (mark_object): Use ptrdiff_t, not int.
1470 * lisp.h (pD): New macro.
1471 * print.c (print_object): Use it.
1472
c0c5c8ae
PE
1473 * alloc.c: Use EMACS_INT, not int, to count objects.
1474 (total_conses, total_markers, total_symbols, total_vector_size)
1475 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1476 (total_free_floats, total_floats, total_free_intervals)
1477 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1478 Now EMACS_INT, not int. All uses changed.
1479 (Fgarbage_collect): Compute overall total using a double, so that
1480 integer overflow is less likely to be a problem. Check for overflow
1481 when converting back to an integer.
5a25e253
PE
1482 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1483 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1484 These were 'int' variables that could overflow on 64-bit hosts;
1485 they were never used, so remove them instead of repairing them.
211a0b2a 1486 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1487 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1488 Previously, this ceilinged at INT_MAX, but that doesn't work on
1489 64-bit machines.
e46bb31a 1490 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1491
c78baabf 1492 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1493 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1494 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1495 when a (possibly-narrower) signed value would do just as well.
1496 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1497
c9d624c6
PE
1498 * alloc.c: Catch some string size overflows that we were missing.
1499 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1500 for convenience in STRING_BYTES_MAX.
1501 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1502 The definition here is exact; the one in lisp.h was approximate.
1503 (allocate_string_data): Check for string overflow. This catches
1504 some instances we weren't catching before. Also, it catches
1505 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1506 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1507 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1508
c9d624c6
PE
1509 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1510 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1511 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1512
353032ce
PE
1513 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1514
2bccce07
PE
1515 * alloc.c (Fmake_string): Check for out-of-range init.
1516
0ac30604
SM
15172011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1518
1519 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1520
c195f2de
JD
15212011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1522
1523 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1524 xg_get_default_scrollbar_width.
1525
1526 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1527 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1528 (style_changed_cb): Call update_theme_scrollbar_width and call
1529 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1530 all frames (Bug#8505).
1531 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1532 Call gtk_window_set_resizable if HAVE_GTK3.
1533 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1534 and height if HAVE_GTK3 (Bug#8505).
1535 (scroll_bar_width_for_theme): New variable.
1536 (update_theme_scrollbar_width): New function.
1537 (xg_get_default_scrollbar_width): Move code to
1538 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1539 (xg_initialize): Call update_theme_scrollbar_width.
1540
1541 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1542
1543 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1544
e10ac9f1
MR
15452011-06-12 Martin Rudalics <rudalics@gmx.at>
1546
1547 * frame.c (make_frame): Call other_buffer_safely instead of
1548 other_buffer.
1549
1550 * window.c (temp_output_buffer_show): Call display_buffer with
1551 second argument Vtemp_buffer_show_specifiers and reset latter
1552 immediately after the call.
1553 (Vtemp_buffer_show_specifiers): New variable.
1554 (auto_window_vscroll_p, next_screen_context_lines)
1555 (Vscroll_preserve_screen_position): Remove leading asterisks from
1556 doc-strings.
1557
2d3c217e 15582011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1559
7b7f97e8 1560 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1561 * buffer.c (Qclone_number): Remove for now, as it's unused.
1562 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1563 (record_buffer): Remove unused local.
1564 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1565 (set_frame_buffer_list): Remove; unused.
1566 * frame.h (other_visible_frames): Remove decl.
1567 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1568 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1569 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1570 if HAVE_GPM.
1571 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1572 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1573 Define only if HAVE_GPM.
1574 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1575 (update_hints_inhibit): Remove; never set. All uses removed.
1576 * widgetprv.h (emacsFrameClassRec): Remove decl.
1577 * window.c (delete_deletable_window): Now returns void, since it
1578 wasn't returning anything.
1579 (compare_window_configurations): Remove unused locals.
1580 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1581 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1582 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1583 the same widths as pointers. This follows up on the 2011-05-06 patch.
1584 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1585 * xterm.h: Likewise.
1586 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1587
1384b89e
JB
15882011-06-12 Juanma Barranquero <lekktu@gmail.com>
1589
1590 * makefile.w32-in: Update dependencies.
1591 (LISP_H): Add lib/intprops.h.
1592
1100a63c
CY
15932011-06-11 Chong Yidong <cyd@stupidchicken.com>
1594
1595 * image.c (gif_load): Add animation frame delay to the metadata.
1596 (syms_of_image): Use DEFSYM. New symbol `delay'.
1597
6198ccd0
MR
15982011-06-11 Martin Rudalics <rudalics@gmx.at>
1599
1600 * window.c (delete_deletable_window): Re-add.
1601 (Fset_window_configuration): Rewrite to handle dead buffers and
1602 consequently deletable windows.
1603 (window_tree, Fwindow_tree): Remove. Supply functionality in
1604 window.el.
1605 (compare_window_configurations): Simplify code.
1606
b6e3633c
AS
16072011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1608
1ab0dee5
AS
1609 * image.c (imagemagick_load_image): Fix type mismatch.
1610 (Fimagemagick_types): Likewise.
1611
b6e3633c
AS
1612 * window.h (replace_buffer_in_windows): Declare.
1613
9397e56f
MR
16142011-06-11 Martin Rudalics <rudalics@gmx.at>
1615
1616 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1617 Qclone_number. Remove external declaration of Qdelete_window.
1618 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1619 code.
1620 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1621 Qbuffer_list_update_hook if allowed.
1622 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1623 buffer list implementation.
1624 (other_buffer_safely): New function.
1625 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1626 calls to replace_buffer_in_windows and
1627 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1628 if allowed.
1629 (record_buffer): Inhibit quitting and rewrite using quittable
1630 functions. Run Qbuffer_list_update_hook if allowed.
1631 (Frecord_buffer, Funrecord_buffer): New functions.
1632 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1633 switch-to-buffer to window.el.
1634 (bury-buffer): Move to window.el.
1635 (Vbuffer_list_update_hook): New variable.
1636
1637 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1638 section.
1639
1640 * window.h (resize_frame_windows): Move up in code.
1641 (Fwindow_frame): Remove EXFUN.
1642 (replace_buffer_in_all_windows): Remove prototype.
1643 (replace_buffer_in_windows_safely): Add prototype.
1644
1645 * window.c: Declare Qdelete_window static again. Move down
1646 declaration of select_count.
1647 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1648 (Fother_window): Move to window.el.
1649 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1650 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1651 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1652 window.el.
1653 (replace_buffer_in_windows): Implement by calling
1654 Qreplace_buffer_in_windows.
1655 (replace_buffer_in_all_windows): Remove with some functionality
1656 moved into replace_buffer_in_windows_safely.
1657 (replace_buffer_in_windows_safely): New function.
1658 (select_window_norecord, select_frame_norecord): Move in front
1659 of run_window_configuration_change_hook. Remove now obsolete
1660 declarations.
1661 (Fset_window_buffer): Rewrite doc-string. Call
1662 Qrecord_window_buffer.
1663 (keys_of_window): Move binding for other-window to window.el.
1664
b50691aa
CY
16652011-06-11 Chong Yidong <cyd@stupidchicken.com>
1666
1667 * dispextern.h (struct image): Replace data member, whose int_val
1668 and ptr_val fields were not used by anything, with a single
1669 lisp_val object.
1670
1671 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1672 (gif_clear_image, gif_load, imagemagick_load_image)
1673 (gs_clear_image, gs_load): Callers changed.
1674
3f754b86
PE
16752011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1676
cca69397
PE
1677 * buffer.h: Include <time.h>, for time_t.
1678 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1679
109e28d0
PE
1680 Fix minor problems found by static checking.
1681
60737f02
PE
1682 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1683
4b66faf3
PE
1684 Make identifiers static if they are not used in other modules.
1685 * data.c (Qcompiled_function, Qframe, Qvector):
1686 * image.c (QimageMagick, Qsvg):
1687 * minibuf.c (Qmetadata):
1688 * window.c (resize_window_check, resize_root_window): Now static.
1689 * window.h (resize_window_check, resize_root_window): Remove decls.
1690
109e28d0
PE
1691 * window.c (window_deletion_count, delete_deletable_window):
1692 Remove; unused.
46a4ce9e
PE
1693 (window_body_lines): Now static.
1694 (Fdelete_other_windows_internal): Mark vars as initialized.
1695 Make sure 'resize_failed' is initialized.
1696 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1697 (resize_window_apply): Remove unused local.
1698 * window.h (delete_deletable_window): Remove decl.
1699
109e28d0 1700 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1701 (imagemagick_load_image): Fix pointer signedness problem by changing
1702 last arg from unsigned char * to char *. All uses changed.
1703 Also, fix a local for similar reasons.
1704 Remove unused locals. Remove locals to avoid shadowing.
1705 (fn_rsvg_handle_free): Remove; unused.
1706 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1707 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1708
3f754b86
PE
1709 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1710
2547adb1
CY
17112011-06-10 Chong Yidong <cyd@stupidchicken.com>
1712
1713 * image.c (gif_load): Fix omitted cast error introduced by
1714 2011-06-06 change.
1715
2c8e37d4
MR
17162011-06-10 Martin Rudalics <rudalics@gmx.at>
1717
1718 * window.h (resize_proportionally, orig_total_lines)
1719 (orig_top_line): Remove from window structure.
1720 (set_window_height, set_window_width, change_window_heights)
1721 (Fdelete_window): Remove prototypes.
1722 (resize_frame_windows): Remove duplicate declaration.
1723
440a42e3
EZ
17242011-06-10 Eli Zaretskii <eliz@gnu.org>
1725
1726 * window.h (resize_frame_windows, resize_window_check)
1727 (delete_deletable_window, resize_root_window)
1728 (resize_frame_windows): Declare prototypes.
1729
1730 * window.c (resize_window_apply): Make definition be "static" to
1731 match the prototype.
1732
562dd5e9
MR
17332011-06-10 Martin Rudalics <rudalics@gmx.at>
1734
1735 * window.c: Remove declarations of Qwindow_size_fixed,
1736 window_min_size_1, window_min_size_2, window_min_size,
1737 size_window, window_fixed_size_p, enlarge_window, delete_window.
1738 Remove static from declaration of Qdelete_window, it's
1739 temporarily needed by Fbury_buffer.
1740 (replace_window): Don't assign orig_top_line and
1741 orig_total_lines.
1742 (Fdelete_window, delete_window): Remove. Window deletion is
1743 handled by window.el.
1744 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1745 Fdelete_window calls with calls to Qdelete_window.
1746 (Fdelete_other_windows): Remove. Deleting other windows is
1747 handled by window.el.
1748 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1749 handled in window.el.
1750 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1751 Window minimum sizes are handled in window.el.
1752 (shrink_windows, size_window, set_window_height)
1753 (set_window_width, change_window_heights, window_height)
1754 (window_width, CURBEG, CURSIZE, enlarge_window)
1755 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1756 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1757 handled in window.el.
1758 (make_dummy_parent): Rename to make_parent_window and give it a
1759 second argument horflag.
1760 (make_window): Don't set resize_proportionally any more.
1761 (Fsplit_window): Remove. Windows are split in window.el.
1762 (save_restore_action, save_restore_orig_size)
1763 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1764 Resize mini windows in window.el.
1765 (grow_mini_window, shrink_mini_window): Implement by calling
1766 Qresize_root_window_vertically, resize_window_check and
1767 resize_window_apply.
1768 (saved_window, Fset_window_configuration, save_window_save): Do
1769 not handle orig_top_line, orig_total_lines, and
1770 resize_proportionally.
1771 (window_min_height, window_min_width): Move to window.el.
1772 (keys_of_window): Move bindings for delete-other-windows,
1773 split-window, delete-window and enlarge-window to window.el.
1774
1775 * buffer.c: Temporarily extern Qdelete_window.
1776 (Fbury_buffer): Temporarily call Qdelete_window instead of
1777 Fdelete_window (Fbury_buffer will move to window.el soon).
1778
1779 * frame.c (set_menu_bar_lines_1): Remove code handling
1780 orig_top_line and orig_total_lines.
1781
1782 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1783 set_window_height but set heights directly.
1784 (change_frame_size_1): Use resize_frame_windows.
1785
1786 * xdisp.c (init_xdisp): Don't use set_window_height but set
1787 heights directly.
1788
1789 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1790 resize_frame_windows instead of change_window_heights and run
1791 run_window_configuration_change_hook.
1792
1793 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1794 instead of change_window_heights and run
1795 run_window_configuration_change_hook.
1796
1a13852e
MR
17972011-06-09 Martin Rudalics <rudalics@gmx.at>
1798
1799 * window.c (replace_window): Rename second argument REPLACEMENT to
1800 NEW. New third argument SETFLAG. Rewrite.
1801 (delete_window, make_dummy_parent): Call replace_window with
1802 third argument 1.
1803 (window_list_1): Move down in code.
1804 (run_window_configuration_change_hook): Move set_buffer part
1805 before select_frame_norecord part in order to unwind correctly.
1806 Rename count1 to count.
1807 (recombine_windows, delete_deletable_window, resize_root_window)
1808 (Fdelete_other_windows_internal)
1809 (Frun_window_configuration_change_hook, make_parent_window)
1810 (resize_window_check, resize_window_apply, Fresize_window_apply)
1811 (resize_frame_windows, Fsplit_window_internal)
1812 (Fdelete_window_internal, Fresize_mini_window_internal): New
1813 functions.
1814 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1815
f3d1777e
MR
18162011-06-08 Martin Rudalics <rudalics@gmx.at>
1817
496e208e
MR
1818 * window.h (window): Add some new members to window structure -
1819 normal_lines, normal_cols, new_total, new_normal, clone_number,
1820 splits, nest, prev_buffers, next_buffers.
1821 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1822 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1823
f3d1777e
MR
1824 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1825 Remove.
496e208e
MR
1826 (make_dummy_parent): Set new members of windows structure.
1827 (make_window): Move down in code. Handle new members of window
1828 structure.
1829 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1830 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1831 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1832 (Fset_window_prev_buffers, Fwindow_next_buffers)
1833 (Fset_window_next_buffers, Fset_window_clone_number): New
1834 functions.
1835 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1836 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1837 Doc-string fixes.
1838 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1839 Argument WINDOW can be now internal window too.
1840 (Fwindow_use_time): Move up in code.
1841 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1842 Rewrite doc-string.
1843 (Fset_window_configuration, saved_window)
1844 (Fcurrent_window_configuration, save_window_save): Handle new
1845 members of window structure.
b9e809c2
MR
1846 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1847 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1848 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1849 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1850 Qget_mru_window, Qresize_root_window,
1851 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1852 Qauto_buffer_name; staticpro them.
f3d1777e 1853
abde8f8c
MR
18542011-06-07 Martin Rudalics <rudalics@gmx.at>
1855
1856 * window.c (Fwindow_total_size, Fwindow_left_column)
1857 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1858 (Fwindow_list_1): New functions.
1859 (window_box_text_cols): Replace with window_body_cols.
1860 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1861 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1862 (delete_window, Fset_window_configuration): Call
1863 delete_all_subwindows with window as argument.
1864 (delete_all_subwindows): Take a window as argument and not a
1865 structure. Rewrite.
190b47e6
MR
1866 (window_loop): Remove handling of GET_LRU_WINDOW and
1867 GET_LARGEST_WINDOW.
1868 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1869
1870 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1871 window_box_text_cols. delete_all_subwindows now takes a
1872 Lisp_Object as argument.
abde8f8c
MR
1873
1874 * indent.c (compute_motion, Fcompute_motion): Use
1875 window_body_cols instead of window_box_text_cols.
1876
fa8a67e6
MR
1877 * frame.c (delete_frame): Call delete_all_subwindows with root
1878 window as argument.
1879
a54e3482
DC
18802011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1881
1882 * fns.c (Fputhash): Document return value.
1883
60002bf5
CY
18842011-06-06 Chong Yidong <cyd@stupidchicken.com>
1885
1886 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1887
0c671da6 18882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1889
b862a52a 1890 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1891
be44ca6c
PE
1892 Check for overflow when converting integer to cons and back.
1893 * charset.c (Fdefine_charset_internal, Fdecode_char):
1894 Use cons_to_unsigned to catch overflow.
1895 (Fencode_char): Use INTEGER_TO_CONS.
1896 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1897 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1898 * data.c (long_to_cons, cons_to_long): Remove.
1899 (cons_to_unsigned, cons_to_signed): New functions.
1900 These signal an error for invalid or out-of-range values.
1901 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1902 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1903 * font.c (Ffont_variation_glyphs):
1904 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1905 * lisp.h: Include <intprops.h>.
1906 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1907 (cons_to_signed, cons_to_unsigned): New decls.
1908 (long_to_cons, cons_to_long): Remove decls.
1909 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1910 (Fprimitive_undo): Use CONS_TO_INTEGER.
1911 * xfns.c (Fx_window_property): Likewise.
1912 * xselect.c: Include <limits.h>.
1913 (x_own_selection, selection_data_to_lisp_data):
1914 Use INTEGER_TO_CONS.
1915 (x_handle_selection_request, x_handle_selection_clear)
1916 (x_get_foreign_selection, Fx_disown_selection_internal)
1917 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1918 (lisp_data_to_selection_data): Use cons_to_unsigned.
1919 (x_fill_property_data): Use cons_to_signed.
1920 Report values out of range.
1921
d1f3d2af
PE
1922 Check for buffer and string overflow more precisely.
1923 * buffer.h (BUF_BYTES_MAX): New macro.
1924 * lisp.h (STRING_BYTES_MAX): New macro.
1925 * alloc.c (Fmake_string):
1926 * character.c (string_escape_byte8):
1927 * coding.c (coding_alloc_by_realloc):
1928 * doprnt.c (doprnt):
1929 * editfns.c (Fformat):
1930 * eval.c (verror):
1931 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1932 since they may not be the same number.
1933 * editfns.c (Finsert_char):
1934 * fileio.c (Finsert_file_contents):
1935 Likewise for BUF_BYTES_MAX.
1936
dd52fcea
PE
1937 * image.c: Use ptrdiff_t, not int, for sizes.
1938 (slurp_file): Switch from int to ptrdiff_t.
1939 All uses changed.
1940 (slurp_file): Check that file size fits in both size_t (for
1941 malloc) and ptrdiff_t (for sanity and safety).
1942
7f9bbdbb
PE
1943 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1944 if b->modtime has its maximal value.
1945
dfe18f82
PE
1946 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1947
84acfcf0
PE
1948 Don't assume time_t can fit into int.
1949 * buffer.h (struct buffer.modtime): Now time_t, not int.
1950 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1951 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1952
ccd9a01a
PE
1953 Minor fixes for signed vs unsigned integers.
1954 * character.h (MAYBE_UNIFY_CHAR):
1955 * charset.c (maybe_unify_char):
1956 * keyboard.c (read_char, reorder_modifiers):
1957 XINT -> XFASTINT, since the integer must be nonnegative.
1958 * ftfont.c (ftfont_spec_pattern):
1959 * keymap.c (access_keymap, silly_event_symbol_error):
1960 XUINT -> XFASTINT, since the integer must be nonnegative.
1961 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1962 since it makes no difference and we prefer signed.
1963 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1964 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1965 nonnegative.
1966
d6d100dd
SM
19672011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1968
1969 * window.h (Fwindow_frame): Declare.
1970
2b6148e4
PE
19712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1972
1973 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1974 (SPARE_MEMORY): Always define.
1975 (LARGE_REQUEST): Remove.
1976 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1977
f230ecc9
MR
19782011-06-06 Martin Rudalics <rudalics@gmx.at>
1979
727e958e
MR
1980 * lisp.h: Move EXFUNS for Fframe_root_window,
1981 Fframe_first_window and Fset_frame_selected_window to window.h.
1982
1983 * window.h: Move EXFUNS for Fframe_root_window,
1984 Fframe_first_window and Fset_frame_selected_window here from
1985 lisp.h.
1986
1987 * frame.c (Fwindow_frame, Fframe_first_window)
1988 (Fframe_root_window, Fframe_selected_window)
1989 (Fset_frame_selected_window): Move to window.c.
1990 (Factive_minibuffer_window): Move to minibuf.c.
1991 (Fother_visible_frames_p): New function.
1992
1993 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1994
f230ecc9
MR
1995 * window.c (decode_window, decode_any_window): Move up in code.
1996 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1997 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1998 (Fwindow_buffer): Move up and rewrite doc-string.
1999 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2000 (Fwindow_prev): New functions.
727e958e
MR
2001 (Fwindow_frame): Move here from frame.c. Accept any window as
2002 argument.
2003 (Fframe_root_window, Fframe_first_window)
2004 (Fframe_selected_window): Move here from frame.c. Accept frame
2005 or arbitrary window as argument. Update doc-strings.
2006 (Fminibuffer_window): Move up in code.
2007 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2008 (Fset_frame_selected_window): Move here from frame.c.
2009 Marginal rewrite.
727e958e
MR
2010 (Fselected_window, select_window, Fselect_window): Move up in
2011 code. Minor doc-string fixes.
f230ecc9 2012
4d09bcf6
PE
20132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2014
2015 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2016 Do not assume that spare memory exists; that assumption is valid
2017 only if SYSTEM_MALLOC.
2018 (LARGE_REQUEST): New macro, so that the issue of large requests
2019 is separated from the issue of spare memory.
2020
810928a2
AS
20212011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2022
172418ad
AS
2023 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2024 format. (Bug#8806)
2025
43f862f7
AS
2026 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2027
810928a2
AS
2028 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2029 before statements.
2030
a059fe24
JD
20312011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2032
2033 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2034
2035 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2036
2037 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2038 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2039
989bf368
JB
20402011-06-05 Juanma Barranquero <lekktu@gmail.com>
2041
2042 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2043
4b80f674
CY
20442011-06-04 Chong Yidong <cyd@stupidchicken.com>
2045
2046 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2047 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2048 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2049 New error handlers.
4b80f674
CY
2050 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2051 Obey Vx_select_enable_clipboard_manager. Catch errors in
2052 x_clipboard_manager_save (Bug#8779).
2053 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2054 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2055
99a33b77 20562011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2057
2058 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2059
99a33b77 20602011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2061
2062 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2063 in the current matrix if keep_current_p is non-zero.
2064
8264569d
EZ
20652011-06-04 Eli Zaretskii <eliz@gnu.org>
2066
2067 * bidi.c (bidi_level_of_next_char): Fix last change.
2068
57f97249
EZ
20692011-06-03 Eli Zaretskii <eliz@gnu.org>
2070
fec2107c 2071 Support bidi reordering of text covered by display properties.
57f97249 2072
fec2107c
EZ
2073 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2074 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2075 (bidi_cache_search, bidi_cache_iterator_state)
2076 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2077 (bidi_level_of_next_char, bidi_move_to_visually_next):
2078 Support character positions inside a run of characters covered by a
fec2107c
EZ
2079 display string.
2080 (bidi_paragraph_init, bidi_resolve_explicit_1)
2081 (bidi_level_of_next_char): Call bidi_fetch_char and
2082 bidi_fetch_char_advance instead of FETCH_CHAR and
2083 FETCH_CHAR_ADVANCE.
2084 (bidi_init_it): Initialize new members.
2085 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2086 definitions.
2087 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2088 instead of using explicit *_CHAR codes.
d6d100dd
SM
2089 (bidi_resolve_explicit, bidi_resolve_weak):
2090 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2091 bidirectional text is supported only in multibyte buffers.
2092 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2093 it to initialize the frame_window_p member of struct bidi_it.
2094 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2095 (bidi_resolve_explicit, bidi_resolve_weak)
2096 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2097 bidi_it->nchars is non-positive.
2098 (bidi_level_of_next_char): Don't try to lookup the cache for the
2099 next/previous character if nothing is cached there yet, or if we
2100 were just reseat()'ed to a new position.
c40e2fb2 2101
0e14fe90
EZ
2102 * xdisp.c (set_cursor_from_row): Set start and stop points
2103 according to the row's direction when priming the loop that looks
2104 for the glyph on which to display cursor.
2105 (single_display_spec_intangible_p): Function deleted.
2106 (display_prop_intangible_p): Reimplement to call
2107 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2108 Accept 3 additional arguments needed by handle_display_spec.
2109 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2110 values: lists, `(when COND...)' forms, etc.
2111 (single_display_spec_string_p): Support property values that are
2112 lists with the argument STRING its top-level element.
2113 (display_prop_string_p): Fix the condition for processing a
2114 property that is a list to be consistent with handle_display_spec.
fec2107c 2115 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2116 last portion of handle_display_prop.
2117 (compute_display_string_pos): Accept additional argument
2118 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2119 value of a `display' property is a "replacing spec".
2120 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2121 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2122 the display property, but just return a value indicating whether
2123 the display property will replace the characters it covers.
2124 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2125 frame_window_p members of struct bidi_it.
d6d100dd
SM
2126 (compute_display_string_pos, compute_display_string_end):
2127 New functions.
fec2107c
EZ
2128 (push_it): Accept second argument POSITION, where pop_it should
2129 jump to continue iteration.
2130 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2131
fec2107c
EZ
2132 * keyboard.c (adjust_point_for_property): Adjust the call to
2133 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2134
2135 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2136 (bidi_init_it): Update prototypes.
2137 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2138 (compute_display_string_pos, compute_display_string_end):
2139 Declare prototypes.
fec2107c
EZ
2140 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2141 EMACS_INT.
fc6f18ce 2142
40087514 21432011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2144
57f53182
PE
2145 Malloc failure behavior now depends on size of allocation.
2146 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2147 * lisp.h: Change signatures accordingly.
2148 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2149 All callers changed. (Bug#8762)
2150
2151 * gnutls.c: Use Emacs's memory allocators.
2152 Without this change, the gnutls library would invoke malloc etc.
2153 directly, which causes problems on non-SYNC_INPUT hosts, and which
2154 runs afoul of improving memory_full behavior. (Bug#8761)
2155 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2156 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2157 xfree instead of the default malloc, realloc, free.
2158 (Fgnutls_boot): No need to check for memory allocation failure,
2159 since xmalloc does that for us.
2160
ac32cd99 2161 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2162 * category.c (hash_get_category_set):
2163 * ccl.c (ccl_driver):
2164 * charset.c (Fdefine_charset_internal):
2165 * charset.h (struct charset.hash_index):
2166 * composite.c (get_composition_id, gstring_lookup_cache)
2167 (composition_gstring_put_cache):
2168 * composite.h (struct composition.hash_index):
2169 * dispextern.h (struct image.hash):
2170 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2171 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2172 (hashfn_equal, hashfn_user_defined, make_hash_table)
2173 (maybe_resize_hash_table, hash_lookup, hash_put)
2174 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2175 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2176 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2177 * image.c (make_image, search_image_cache, lookup_image)
2178 (xpm_put_color_table_h):
2179 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2180 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2181 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2182 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2183 * alloc.c (allocate_vectorlike):
2184 Check for overflow in vector size calculations.
2185 * ccl.c (ccl_driver):
2186 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2187 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2188 need to be updated by these changes.
40087514
PE
2189 * fns.c (make_hash_table, maybe_resize_hash_table):
2190 Check for integer overflow with large hash tables.
0de4bb68
PE
2191 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2192 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2193 (SXHASH_REDUCE): New macro.
2194 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2195 Use it instead of discarding useful hash info with large hash values.
2196 (sxhash_float): New function.
2197 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2198 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2199 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2200 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2201 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2202 Adjust signatures to match updated version of code.
2203 (consing_since_gc): Now EMACS_INT, since a single hash table can
2204 use more than INT_MAX bytes.
2205
698d32e2
DN
22062011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2207
2208 Make it possible to build with GCC-4.6+ -O2 -flto.
2209
2210 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2211
fd6fa53f
SM
22122011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2213
2214 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2215 Call minibuffer-inactive-mode.
2216
864db017
JB
22172011-05-31 Juanma Barranquero <lekktu@gmail.com>
2218
2219 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2220 Update dependencies.
2221
2ad0baf4
DN
22222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2223
2224 * data.c (init_data): Remove code for UTS, this system is not
2225 supported anymore.
2226
4fcc2638
DN
22272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2228
2229 Don't force ./temacs to start in terminal mode.
2230
2231 * frame.c (make_initial_frame): Initialize faces in all cases, not
2232 only when CANNOT_DUMP is defined.
2233 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2234
c56e0fd5
DN
22352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2236
2237 * dispnew.c (add_window_display_history): Use const for the string
2238 pointer. Remove declaration, not needed.
2239
333d54da 22402011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2241
55d4c1b2 2242 Use 'inline', not 'INLINE'.
333d54da 2243 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2244 * alloc.c, fontset.c (INLINE): Remove.
2245 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2246 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2247 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2248 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2249 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2250
738db178
DN
22512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2252
2253 Make it possible to run ./temacs.
2254
2255 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2256 syms_of_callproc does the same thing. Remove test for
2257 "initialized", do it in the caller.
2258 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2259
620c53a6
SM
22602011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2261
2262 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2263 (read_minibuf): Use get_minibuffer.
2264 (syms_of_minibuf): Use DEFSYM.
2265 (Qmetadata): New var.
2266 * data.c (Qbuffer): Don't make it static.
2267 (syms_of_data): Use DEFSYM.
2268
e003a292
PE
22692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2270
2271 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2272 (CCL_CODE_MIN): New macro.
2273
ed008a6d
PE
22742011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2275
3687c2ef
PE
2276 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2277
ed008a6d
PE
2278 * eval.c (Qdebug): Now static.
2279 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2280 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2281 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2282
d66c4c7c
CY
22832011-05-29 Chong Yidong <cyd@stupidchicken.com>
2284
2285 * image.c: Various fixes to ImageMagick code comments.
2286 (Fimagemagick_types): Doc fix.
2287
5fbc2025
PE
22882011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2289
0196f88a
PE
2290 Minor fixes prompted by GCC 4.6.0 warnings.
2291
2292 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2293
5fbc2025
PE
2294 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2295 (x_clipboard_manager_save_all): Move extern decl to ...
2296 * xterm.h: ... here, so that it can be checked for consistency.
2297
1dd3c2d9
CY
22982011-05-29 Chong Yidong <cyd@stupidchicken.com>
2299
2300 * xselect.c (x_clipboard_manager_save_frame)
2301 (x_clipboard_manager_save_all): New functions.
2302 (Fx_clipboard_manager_save): Lisp function deleted.
2303
2304 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2305 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2306
2307 * xterm.h: Update prototype.
2308
5ba6571d
WX
23092011-05-28 William Xu <william.xwl@gmail.com>
2310
2311 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2312 exiting (Bug#8239).
2313
3eaff834
JM
23142011-05-28 Jim Meyering <meyering@redhat.com>
2315
e1900994 2316 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2317 * fns.c (to_uchar): Define.
2318 (crypto_hash_function): Use it to convert some newly-signed
2319 variables to unsigned, to avoid sign-extension bugs. For example,
2320 without this change, (md5 "truc") would evaluate to
2321 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2322 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2323 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2324
0f6990a7
PE
23252011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2326
2327 Integer overflow fixes.
c8a9ca5a 2328
08686060
PE
2329 * dbusbind.c: Serial number integer overflow fixes.
2330 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2331 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2332 to hold a serial number that is too large for a fixnum.
2333 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2334 Check for serial numbers out of range. Decode any serial number
59568bf0 2335 that was so large that it became a float. (Bug#8722)
08686060 2336
2d1fc3c7
PE
2337 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2338 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2339 Use XFASTINT rather than XUINT when numbers are nonnegative.
2340 (xd_append_arg, Fdbus_method_return_internal):
2341 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2342 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2343 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2344 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2345 (Bug#8722)
2d1fc3c7 2346
c8a9ca5a
PE
2347 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2348
519e1d69
PE
2349 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2350
30569699
PE
2351 ccl: add integer overflow checks
2352 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2353 (IN_INT_RANGE): New macros.
2354 (ccl_driver): Use them to check for integer overflow when
2355 decoding a CCL program. Many of the new checks are whether XINT (x)
2356 fits in int; it doesn't always, on 64-bit hosts. The new version
2357 doesn't catch all possible integer overflows, but it's an
847044ea 2358 improvement. (Bug#8719)
30569699 2359
c11285dc
PE
2360 * alloc.c (make_event_array): Use XINT, not XUINT.
2361 There's no need for unsigned here.
2362
fdccd48e
PE
2363 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2364 This follows up to the 2011-05-06 change that substituted uintptr_t
2365 for EMACS_INT. This case wasn't caught back then.
2366
37910ab2
PE
2367 Rework Fformat to avoid integer overflow issues.
2368 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2369 now (part of C89). Include <verify.h>.
2370 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2371 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2372 (Fformat): Avoid the prepass trying to compute sizes; it was only
2373 approximate and thus did not catch overflow reliably. Instead, walk
2374 through the format just once, formatting and computing sizes as we go,
2375 checking for integer overflow at every step, and allocating a larger
2376 buffer as needed. Keep track separately whether the format is
2377 multibyte. Keep only the most-recently calculated precision, rather
2378 than them all. Record whether each argument has been converted to
2379 string. Use EMACS_INT, not int, for byte and char and arg counts.
2380 Support field widths and precisions larger than INT_MAX. Avoid
2381 sprintf's undefined behavior with conversion specifications such as %#d
2382 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2383 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2384 formatting out-of-range floating point numbers with int
9173deec 2385 formats. (Bug#8668)
37910ab2 2386
2e6578fb
PE
2387 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2388
0ae6bdee
PE
2389 * data.c: Avoid integer truncation in expressions involving floats.
2390 * data.c: Include <intprops.h>.
2391 (arith_driver): When there's an integer overflow in an expression
2392 involving floating point, convert the integers to floating point
2393 so that the resulting value does not suffer from catastrophic
2394 integer truncation. For example, on a 64-bit host (* 4
2395 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2396 Do not rely on undefined behavior after integer overflow.
2397
de883a70
PE
2398 merge count_size_as_multibyte, parse_str_to_multibyte
2399 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2400 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2401 Check for integer overflow.
2402 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2403 since it's now a duplicate of the other. This is more of
2404 a character than a buffer op, so better that it's in character.c.
2405 * fns.c, print.c: Adjust to above changes.
2406
2ff916cb
PE
24072011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2408
2409 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2410
f1b54466
PE
24112011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2412
fb1ac845
PE
2413 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2414 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2415 (x_clipboard_manager_save): Now static.
2416 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2417
f1b54466
PE
2418 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2419 (crypto_hash_function): Now static.
2420 Fix pointer signedness problems. Avoid unnecessary initializations.
2421
a9f737ee
CY
24222011-05-27 Chong Yidong <cyd@stupidchicken.com>
2423
2424 * termhooks.h (Vselection_alist): Make it terminal-local.
2425
2426 * terminal.c (create_terminal): Initialize it.
2427
2428 * xselect.c: Support for clipboard managers.
2429 (Vselection_alist): Move to termhooks.h as terminal-local var.
2430 (LOCAL_SELECTION): New macro.
2431 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2432 (symbol_to_x_atom): Remove gratuitous arg.
2433 (x_handle_selection_request, lisp_data_to_selection_data)
2434 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2435 (x_own_selection, x_get_local_selection, x_convert_selection):
2436 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2437 (some_frame_on_display): Delete unused function.
2438 (Fx_own_selection_internal, Fx_get_selection_internal)
2439 (Fx_disown_selection_internal, Fx_selection_owner_p)
2440 (Fx_selection_exists_p): New optional frame arg.
2441 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2442 (x_handle_selection_clear): Don't treat other terminals with the
2443 same keyboard specially. Use the terminal-local Vselection_alist.
2444 (x_clear_frame_selections): Use Frun_hook_with_args.
2445
2446 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2447
2448 * xterm.h: Add support for those atoms.
2449
e067f0c1
CY
24502011-05-26 Chong Yidong <cyd@stupidchicken.com>
2451
2452 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2453 (converted_selections, conversion_fail_tag): New global variables.
2454 (x_selection_request_lisp_error): Free the above.
2455 (x_get_local_selection): Remove unnecessary code.
2456 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2457 of converted selections stored in converted_selections.
2458 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2459 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2460 (x_convert_selection): New function.
2461 (x_handle_selection_event): Simplify.
2462 (x_get_foreign_selection): Don't ignore incoming requests while
2463 waiting for an answer; this will fail when we implement
2464 SAVE_TARGETS, and seems unnecessary anyway.
2465 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2466 (Vx_sent_selection_functions): Doc fix.
2467
0f4aebc0
LL
24682011-05-26 Leo Liu <sdl.web@gmail.com>
2469
2470 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2471
e61124cd
YM
24722011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2473
2474 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2475
2476 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2477 for fringe update if it has periodic bitmap.
ac389d0c 2478 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2479 and fringe_bitmap_periodic_p.
2480
2481 * fringe.c (get_fringe_bitmap_data): New function.
2482 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2483 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2484 row. Mark glyph row for fringe update if periodicity changed.
2485
2486 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2487 for fringe update unless it has periodic bitmap.
2488
f16d9837
KH
24892011-05-25 Kenichi Handa <handa@m17n.org>
2490
2491 * xdisp.c (get_next_display_element): Set correct it->face_id for
2492 a static composition.
2493
e1b90ef6
LL
24942011-05-24 Leo Liu <sdl.web@gmail.com>
2495
2496 * deps.mk (fns.o):
2497 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2498
2499 * fns.c (crypto_hash_function, Fsha1): New function.
2500 (Fmd5): Use crypto_hash_function.
2501 (syms_of_fns): Add Ssha1.
2502
7400048f
PE
25032011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2504
2505 * gnutls.c: Remove unused macros.
2506 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2507 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2508 Remove macros that are defined and never used.
2509 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2510
abb71cf4
CY
25112011-05-22 Chong Yidong <cyd@stupidchicken.com>
2512
2513 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2514 (Fx_get_selection_internal): Minor cleanup.
2515 (Fx_own_selection_internal): Rename arguments for consistency with
2516 select.el.
2517
6307db39
PE
25182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2519
2520 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2521
f3d4e0a4
CY
25222011-05-22 Chong Yidong <cyd@stupidchicken.com>
2523
2524 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2525
4d8ade89
YM
25262011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2527
2528 * dispnew.c (scrolling_window): Don't exclude the case that the
2529 last enabled row in the desired matrix touches the bottom boundary.
2530
32078c8d
GM
25312011-05-21 Glenn Morris <rgm@gnu.org>
2532
2533 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2534 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2535 and add some more files.
32078c8d 2536
7285dc67
EZ
25372011-05-20 Eli Zaretskii <eliz@gnu.org>
2538
2539 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2540 report_file_error introduced by the change from 2011-05-07.
2541
89d1bd22
PE
25422011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2543
2544 * systime.h (Time): Define only if emacs is defined.
2545 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2546 where the include path doesn't have X11/X.h by default. See
2547 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2548
e23640bb 25492011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2550
2551 * composite.c (find_automatic_composition): Fix previous change.
2552
b9704ad9
GM
25532011-05-20 Glenn Morris <rgm@gnu.org>
2554
2555 * lisp.mk: New file, split from Makefile.in.
2556 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2557 (shortlisp): Remove.
2558 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2559
4a720484
GM
25602011-05-19 Glenn Morris <rgm@gnu.org>
2561
2562 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2563 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2564 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2565 (lisp): Set the order to that of loadup.el.
2566 (shortlisp): Make it a copy of $lisp.
2567 (SOME_MACHINE_LISP): Remove.
2568 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2569 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2570
a28d4396
KH
25712011-05-18 Kenichi Handa <handa@m17n.org>
2572
2573 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2574 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2575 (find_automatic_composition): Mostly rewrite for efficiency.
2576
a2b1fa8e
JB
25772011-05-18 Juanma Barranquero <lekktu@gmail.com>
2578
2579 * makefile.w32-in: Update dependencies.
2580
8e1f5610
CS
25812011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2582
2583 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2584 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2585
7025ee00 25862011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2587
cdfa6eab
PE
2588 Fix some integer overflow issues, such as string length overflow.
2589
06d6db33
PE
2590 * insdel.c (count_size_as_multibyte): Check for string overflow.
2591
2b4560a8
PE
2592 * character.c (lisp_string_width): Check for string overflow.
2593 Use EMACS_INT, not int, for string indexes and lengths; in
2594 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2595 the resulting string length overflows an EMACS_INT; instead,
2596 report a string overflow if no precision given. When checking for
2597 precision exhaustion, use a check that cannot possibly have
2598 integer overflow. (Bug#8675)
2599 * character.h (lisp_string_width): Adjust to new signature.
2600
cb93f9be
PE
2601 * alloc.c (string_overflow): New function.
2602 (Fmake_string): Use it. This doesn't change behavior, but saves
2603 a few bytes and will simplify future changes.
2604 * character.c (string_escape_byte8): Likewise.
2605 * lisp.h (string_overflow): New decl.
2606
1a1f3366
PE
2607 Fixups, following up to the user-interface timestamp change.
2608 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2609 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2610 * msdos.c (mouse_get_pos): Likewise.
2611 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2612 * w32gui.h (Time): Define by including "systime.h" rather than by
2613 declaring it ourselves. (Bug#8664)
2614
d4e3e4d3
PE
2615 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2616 * image.c (clear_image_cache): Likewise.
2617
f6a24d19
PE
2618 * term.c (term_mouse_position): Don't assume time_t wraparound.
2619
08dc5ae6
PE
2620 Be more systematic about user-interface timestamps.
2621 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2622 and sometimes 'EMACS_UINT', to represent these timestamps.
2623 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2624 This makes the code easier to follow, and makes it easier to catch
2625 integer overflow bugs such as Bug#8664.
2626 * frame.c (Fmouse_position, Fmouse_pixel_position):
2627 Use Time, not unsigned long, for user-interface timestamps.
2628 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2629 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2630 * keyboard.h (last_event_timestamp): Likewise.
2631 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2632 * menu.h (xmenu_show): Likewise.
2633 * term.c (term_mouse_position): Likewise.
2634 * termhooks.h (struct input_event.timestamp): Likewise.
2635 (struct terminal.mouse_position_hook): Likewise.
2636 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2637 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2638 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2639 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2640 what it was before.
2641 * menu.h, termhooks.h: Include "systime.h", for Time.
2642
8e55734a
PE
2643 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2644 Don't assume that the difference between two unsigned long values
2645 can fit into an integer. At this point, we know button_down_time
2646 <= event->timestamp, so the difference must be nonnegative, so
2647 there's no need to cast the result if double-click-time is
2648 nonnegative, as it should be; check that it's nonnegative, just in
2649 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2650 apart (about 25 days). (Bug#8664)
8e55734a 2651
841f1b75 2652 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2653 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2654
3e26f69c
PE
2655 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2656 that always fit in int. Use a sentinel instead of a counter, to
2657 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2658 * frame.h (struct frame): Use int for menu_bar_items_used
2659 instead of EMACS_INT, since it always fits in int.
3e26f69c 2660
5cc152c0
PE
2661 * menu.c (grow_menu_items): Check for int overflow.
2662
d89eb65e
PE
2663 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2664
5235bd3e
PE
2665 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2666 Before, the code was not consistent. These values cannot exceed
2667 2**31 - 1 so there's no need to make them unsigned.
2668 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2669 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2670 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2671 as modifiers.
2672 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2673
bc827e23
PE
2674 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2675 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2676 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2677 presumably because the widths might not match.
2678
78eb494e
PE
2679 * window.c (size_window): Avoid needless test at loop start.
2680
04f2d78b
CB
26812011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2682
2683 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2684
d2fc7e3d 26852011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2686
2687 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2688
d2fc7e3d 26892011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2690
2691 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2692 `width' to `bar_area_x' and `bar_area_width', respectively.
2693 (x_scroll_run): Take account of fringe background extension.
2694
04f2d78b
CB
2695 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2696 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2697 `bar_area_width', respectively.
2698 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2699 background extension.
2700
79b70037
GM
27012011-05-10 Jim Meyering <meyering@redhat.com>
2702
2703 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2704
2f142cc5
JB
27052011-05-10 Juanma Barranquero <lekktu@gmail.com>
2706
2707 * image.c (Finit_image_library): Return t for built-in image types,
2708 like pbm and xbm. (Bug#8640)
2709
57679c86
AS
27102011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2711
2712 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2713
888c9e86
EZ
27142011-05-07 Eli Zaretskii <eliz@gnu.org>
2715
b0512a1d
EZ
2716 * w32console.c (Fset_screen_color): Doc fix.
2717 (Fget_screen_color): New function.
2718 (syms_of_ntterm): Defsubr it.
2719
7285dc67
EZ
2720 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2721 unlink the temporary file if Fcall_process didn't create it in the
2722 first place.
2723 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2724 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2725 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2726 cue to call_process_cleanup not to close that handle.
2727
4d3fcc8e
BK
27282011-05-07 Ben Key <bkey76@gmail.com>
2729
2730 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2731 one of two shell specific rules, either bootstrap-temacs-CMD or
2732 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2733 to the previous implementation of the bootstrap-temacs rule.
2734 The bootstrap-temacs-CMD rule is similar to the previous
2735 implementation of the bootstrap-temacs rule except that it
2736 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2737 variable.
2738
2739 These changes, along with some changes to nt/configure.bat,
2740 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2741 earlier fix to add support for --cflags and --ldflags options
2742 that include quotes so that it works whether make uses cmd or
2743 sh as the shell.
2744
b4289b64
MA
27452011-05-06 Michael Albinus <michael.albinus@gmx.de>
2746
2747 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2748 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2749 is a constant.
2750 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2751 a string. Handle both cases.
2752 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2753 (Fdbus_register_method): Use Qinvalid_function.
2754
af4c0e28
JB
27552011-05-06 Juanma Barranquero <lekktu@gmail.com>
2756
2757 * makefile.w32-in: Update dependencies.
2758 (LISP_H): Add inttypes.h and stdin.h.
2759 (PROCESS_H): Add unistd.h.
2760
c51453d9
EZ
27612011-05-06 Eli Zaretskii <eliz@gnu.org>
2762
2763 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2764 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2765
8ff0ac3c 27662011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2767
4c4b566b
PE
2768 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2769
aab2b9b5
PE
2770 * term.c (vfatal): Remove stray call to va_end.
2771 It's not needed and the C Standard doesn't allow it here anyway.
2772
c378da0b
PE
2773 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2774 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2775
288b08c7
PE
2776 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2777 bytes.
2778
e3601888
PE
2779 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2780
db6c0e74
PE
2781 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2782
dd5963ea
PE
2783 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2784
88c9450f
PE
2785 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2786
2f9442b8
PE
2787 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2788
c032b5f8
PE
2789 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2790 * charset.c (Fdefine_charset_internal): Don't initialize
2791 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2792 32-bit int (Bug#8600).
a108c10b
PE
2793
2794 * lread.c (read_integer): Be more consistent with string-to-number.
2795 Use string_to_number to do the actual conversion; this avoids
2796 rounding errors and fixes some other screwups. Without this fix,
2797 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2798 (digit_to_number): Move earlier, for benefit of read_integer.
2799 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2800 not a digit in any supported base. (Bug#8602)
a108c10b 2801
ad5f9eea
PE
2802 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2803
aec1708a
PE
2804 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2805 to match comment at start of function. This also removes a
2806 GCC warning about overflow in a 32+64-bit port.
2807
47be4ab5
PE
2808 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2809
371cac43
PE
2810 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2811 Reported by Stefan Monnier in
2812 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2813 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2814 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2815
d01a7826
PE
2816 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2817 (EMACS_UINTPTR): Likewise, with uintptr_t.
2818
7fd47d5c
PE
2819 * lisp.h: Prefer 64-bit EMACS_INT if available.
2820 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2821 on 32-bit hosts that have 64-bit int, so that they can access
2822 large files.
122b0c86
PE
2823 However, temporarily disable this change unless the temporary
2824 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2825
8727937b
PE
2826 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2827
8ac068ac
PE
2828 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2829 This removes an assumption that EMACS_INT and long are the same
2830 width as pointers. The assumption is true for Emacs porting targets
2831 now, but we want to make other targets possible.
2832 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2833 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2834 In the rest of the code, change types of integers that hold casted
2835 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2836 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2837 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2838 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2839 No need to cast type when ORing.
2840 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2841 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2842 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2843 assume EMACS_INT is the same width as char *.
2844 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2845 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2846 Remove no-longer-needed casts.
2847 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2848 (xg_tool_bar_help_callback, xg_make_tool_item):
2849 Use EMACS_INTPTR to hold an integer
2850 that will be cast to void *; this can avoid a GCC warning
2851 if EMACS_INT is not the same width as void *.
2852 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2853 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2854 (current_message_1, set_message_1):
2855 Use a local to convert to proper width without a cast.
2856 * xmenu.c (dialog_selection_callback): Likewise.
2857
ede49d71
PE
2858 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2859 Also, don't assume VALBITS / RAND_BITS is less than 5,
2860 and don't rely on undefined behavior when shifting a 1 left into
2861 the sign bit.
2862 * lisp.h (get_random): Change signature to match.
2863
2f30ecd0
PE
2864 * lread.c (hash_string): Use size_t, not int, for hash computation.
2865 Normally we prefer signed values; but hashing is special, because
2866 it's better to use unsigned division on hash table sizes so that
2867 the remainder is nonnegative. Also, size_t is the natural width
2868 for hashing into memory. The previous code used 'int', which doesn't
2869 retain enough info to hash well into very large tables.
2870 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2871
2a866e7b
PE
2872 * dbusbind.c: Don't possibly lose pointer info when converting.
2873 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2874 Use XPNTR rather than XHASH, so that the high-order bits of
2875 the pointer aren't lost when converting through void *.
2876
51639eac
PE
2877 * eval.c (Fautoload): Don't double-shift a pointer.
2878
92394119
PE
2879 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2880
dbdb9a7c
JB
28812011-05-06 Juanma Barranquero <lekktu@gmail.com>
2882
2883 * gnutls.c (DEF_GNUTLS_FN):
2884 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2885
db7a0b4f
AS
28862011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2887
2888 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2889 marker. (Bug#8610)
2890
f7ff1b0f 28912011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2892
2893 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2894 New version that can reserve upto 2GB of heap space.
2895
f7ff1b0f 28962011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2897
2898 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2899
639c109b
TZ
29002011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2901
2902 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2903 `gnutls_certificate_set_x509_key_file'.
2904
d2127135
JB
29052011-05-05 Juanma Barranquero <lekktu@gmail.com>
2906
2907 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2908 Update dependencies.
2909
e968f4f3
JB
29102011-05-04 Juanma Barranquero <lekktu@gmail.com>
2911
2912 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2913 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2914 Remove unused parameter `fildes'.
2915 * process.c (read_process_output, send_process): Don't pass it.
2916
84d358f0
JB
29172011-05-04 Juanma Barranquero <lekktu@gmail.com>
2918
2919 Fix previous change: the library cache is defined in w32.c.
2920 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2921 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2922
0898ca10
JB
29232011-05-04 Juanma Barranquero <lekktu@gmail.com>
2924
2925 Implement dynamic loading of GnuTLS on Windows.
2926
2927 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2928 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2929 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2930 Declare.
2931
2932 * gnutls.c (Qgnutls_dll): Define.
2933 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2934 (gnutls_*): Declare function pointers.
2935 (init_gnutls_functions): New function to initialize function pointers.
2936 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2937 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2938 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2939 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2940 (emacs_gnutls_write, emacs_gnutls_read)
2941 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2942 (Fgnutls_available_p): New function.
2943 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2944 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2945 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2946
2947 * image.c: Include w32.h.
2948 (Vimage_type_cache): Delete.
2949 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2950 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2951 (w32_delayed_load): Move to w32.c.
2952
2953 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2954
2955 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2956 (w32_delayed_load): Move from image.c. When loading a library, record
2957 its filename in the :loaded-from property of the library id.
2958 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2959 Initialize and staticpro them.
2960 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2961
2962 * process.c: Include lisp.h before w32.h, not after.
2963 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2964 instead of gnutls_record_check_pending.
2965
2966 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2967
ff4de4aa
TZ
29682011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2969
2970 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2971 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2972 as passed in.
2973
abe95abb
JD
29742011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2975
2976 * xterm.c (x_set_frame_alpha): Do not set property on anything
2977 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2978
e16e55d4
JB
29792011-05-02 Juanma Barranquero <lekktu@gmail.com>
2980
2981 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2982
bafcf6a5
JB
29832011-05-02 Juanma Barranquero <lekktu@gmail.com>
2984
2985 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2986 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2987 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2988 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2989 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2990 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2991 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2992 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2993 (Qgnutls_bootprop_callbacks_verify): Make static.
2994
e7a6747f
AS
29952011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2996
19ed11ba
AS
2997 * callproc.c: Indentation fixup.
2998
e7a6747f 2999 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3000 (wait_for_termination, interruptible_wait_for_termination):
3001 Move after wait_for_termination_1.
e7a6747f 3002
1ef14cb4
LMI
30032011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3004
3005 * sysdep.c (interruptible_wait_for_termination): New function
3006 which is like wait_for_termination, but allows keyboard
3007 interruptions.
3008
3009 * callproc.c (Fcall_process): Add (:file "file") as an option for
3010 the STDOUT buffer.
3011 (Fcall_process_region): Ditto.
3012
330d880c
EZ
30132011-04-30 Eli Zaretskii <eliz@gnu.org>
3014
8db90b73
EZ
3015 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3016 rather than `XVECTOR (FOO)->size'.
3017
330d880c
EZ
3018 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3019 inttypes.h, as a gnulib replacement is used if it not available in
3020 system headers.
3021
15cbd324
EZ
30222011-04-21 Eli Zaretskii <eliz@gnu.org>
3023
3024 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3025 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3026 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3027
3028 * coding.c (coding_alloc_by_realloc): Error out if destination
3029 will grow beyond MOST_POSITIVE_FIXNUM.
3030 (decode_coding_emacs_mule): Abort if there isn't enough place in
3031 charbuf for the composition carryover bytes. Reserve an extra
3032 space for up to 2 characters produced in a loop.
3033 (decode_coding_iso_2022): Abort if there isn't enough place in
3034 charbuf for the composition carryover bytes.
3035
30362011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3037
ae940cca
EZ
3038 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3039 aborting when %lld or %lll format is passed.
3040 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3041 %llo or %llx format is passed. (Bug#8545)
3042
03ab8921
EZ
3043 * window.c (window_scroll_line_based): Use a marker instead of
3044 simple variables to record original value of point. (Bug#7952)
3045
afda1437
EZ
3046 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3047 produced by %s or %c overflows available buffer space. (Bug#8545)
3048
f76dee0c
PE
30492011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3050
3051 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3052 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3053
fdc5744d
JB
30542011-04-28 Juanma Barranquero <lekktu@gmail.com>
3055
3056 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3057
638f053a
JB
30582011-04-28 Juanma Barranquero <lekktu@gmail.com>
3059
3060 * keyboard.c (Qdelayed_warnings_hook): Define.
3061 (command_loop_1): Run `delayed-warnings-hook'
3062 if Vdelayed_warnings_list is non-nil.
3063 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3064 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3065
d178f871
EZ
30662011-04-28 Eli Zaretskii <eliz@gnu.org>
3067
3068 * doprnt.c (doprnt): Don't return value smaller than the buffer
3069 size if the message was truncated. (Bug#8545).
3070
b124fd93
JB
30712011-04-28 Juanma Barranquero <lekktu@gmail.com>
3072
3073 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3074 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3075
e810457d
PE
30762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3077
3078 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3079
ea51cceb
JB
30802011-04-27 Juanma Barranquero <lekktu@gmail.com>
3081
3082 * makefile.w32-in: Update dependencies.
3083
94dcfacf
EZ
30842011-04-27 Eli Zaretskii <eliz@gnu.org>
3085
3086 Improve `doprnt' and its usage. (Bug#8545)
3087 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3088 `format_end'. Remove support for %l as a conversion specifier.
3089 Don't use xrealloc. Improve diagnostics when the %l size modifier
3090 is used. Update the commentary.
3091
3092 * eval.c (verror): Simplify calculation of size_t.
3093
3094 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3095 messages.
3096
f61f41d7
PE
30972011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3098
3099 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3100 change.
3101
96fb4434
PE
31022011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3103
3104 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3105 This makes this file independent of the recent pseudovector change.
3106
671875da 31072011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3108
69e9b5a3
PE
3109 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3110
b5f869a7 3111 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3112 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3113 Remove unused local.
c8926152 3114 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3115
841a1577 3116 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3117 GCC 4.6.0 optimizes based on type-based alias analysis.
3118 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3119 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3120 != &v->size, and therefore "v->size = 1; b->size = 2; return
3121 v->size;" must therefore return 1. This assumption is incorrect
3122 for Emacs, since it type-puns struct Lisp_Vector * with many other
3123 types. To fix this problem, this patch adds a new type struct
f904488f 3124 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3125 and pseudovectors, and helps optimizing compilers not get fooled
3126 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3127 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3128 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3129 the size member.
eab3844f
PE
3130 (XSETPVECTYPE): Rewrite in terms of new macro.
3131 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3132 This is a bit clearer, and further avoids the possibility of
3133 undesirable aliasing.
3134 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3135 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3136 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3137 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3138 (ASIZE): Now uses header.size rather than size.
3139 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3140 to avoid the hassle of writing XVECTOR (foo)->header.size.
3141 (struct vectorlike_header): New type.
eab3844f
PE
3142 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3143 object, to help avoid aliasing.
3144 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3145 (SUBRP): Likewise, since Lisp_Subr is a special case.
3146 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3147 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3148 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3149 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3150 changed to be "header.size" and "header.next".
3151 * buffer.h (struct buffer): Likewise.
3152 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3153 * frame.h (struct frame): Likewise.
3154 * process.h (struct Lisp_Process): Likewise.
3155 * termhooks.h (struct terminal): Likewise.
3156 * window.c (struct save_window_data, struct saved_window): Likewise.
3157 * window.h (struct window): Likewise.
3158 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3159 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3160 * buffer.c (init_buffer_once): Likewise.
3161 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3162 special case.
3163 * process.c (Fformat_network_address): Use local var for size,
3164 for brevity.
3165
0df1eac5
PE
3166 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3167
847ab9d1 3168 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3169 * data.c (atof): Remove decl; no longer used or needed.
3170 (digit_to_number): Move to lread.c.
3171 (Fstring_to_number): Use new string_to_number function, to be
3172 consistent with how the Lisp reader treats infinities and NaNs.
3173 Do not assume that floating-point numbers represent EMACS_INT
3174 without losing information; this is not true on most 64-bit hosts.
3175 Avoid double-rounding errors, by insisting on integers when
3176 parsing non-base-10 numbers, as the documentation specifies.
3177 * lisp.h (string_to_number): New decl, replacing ...
3178 (isfloat_string): Remove.
bc0a5c13 3179 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3180 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3181 appears to have been a coding error. Similarly, do not accept
3182 strings like +-1e0 as floating point numbers. Do not report
3183 overflow for integer overflows unless the base is not 10 which
3184 means we have no simple and reliable way to continue.
3185 Break out the floating-point parsing into a new
3186 function string_to_number, so that Fstring_to_number parses
3187 floating point numbers consistently with the Lisp reader.
04f2d78b 3188 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3189 (E_CHAR, EXP_INT): Remove, replacing with ...
3190 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3191 (string_to_number): New function, replacing isfloat_string.
3192 This function checks for valid syntax and produces the resulting
3193 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3194 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3195 so that overflow for non-base-10 numbers is reported only when
3196 there's no portable and simple way to convert to floating point.
452f4150 3197
67769ffc
PE
3198 * textprop.c (set_text_properties_1): Rewrite for clarity,
3199 and to avoid GCC warning about integer overflow.
3200
c20db43f
PE
3201 * intervals.h (struct interval): Use EMACS_INT for members
3202 where EMACS_UINT might cause problems. See
3203 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3204 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3205 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3206 All uses changed.
37aa2f85
PE
3207 (offset_intervals): Tell GCC not to worry about length overflow
3208 when negating a negative length.
c20db43f 3209
2538aa2f
PE
3210 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3211 (overrun_check_free): Likewise.
3212
f2d3008d
PE
3213 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3214 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3215 word size.
3216
ec8df744
PE
3217 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3218 (gnutls_make_error): Rename local to avoid shadowing.
3219 (gnutls_emacs_global_deinit): ifdef out; not used.
3220 (Fgnutls_boot): Use const for pointer to readonly storage.
3221 Comment out unused local. Fix pointer signedness problems.
3222
640ee02d
PE
3223 * lread.c (openp): Don't stuff size_t into an 'int'.
3224 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3225 about possible signed overflow.
3226
6048fb2a
PE
3227 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3228 (GDK_KEY_g): Don't define if already defined.
3229 (xg_prepare_tooltip): Avoid pointer signedness problem.
3230 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3231
fa3c87e1
PE
3232 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3233 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3234
2172544b
PE
3235 * xfns.c (Fx_window_property): Simplify a bit,
3236 to make a bit faster and to avoid GCC 4.6.0 warning.
3237 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3238
9b821a21
PE
3239 * fns.c (internal_equal): Don't assume size_t fits in int.
3240
3c616cfa
PE
3241 * alloc.c (compact_small_strings): Tighten assertion a little.
3242
c2982e87
PE
3243 Replace pEd with more-general pI, and fix some printf arg casts.
3244 * lisp.h (pI): New macro, generalizing old pEd macro to other
3245 conversion specifiers. For example, use "...%"pI"d..." rather
3246 than "...%"pEd"...".
3247 (pEd): Remove. All uses replaced with similar uses of pI.
3248 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3249 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3250 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3251 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3252 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3253 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3254 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3255 64-bit hosts.
3256 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3257 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3258 * print.c (safe_debug_print, print_object): Likewise.
3259 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3260 to int.
6f04d126
PE
3261 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3262 avoiding the 0 flag, which is not portable.
c2982e87
PE
3263 * process.c (Fmake_network_process): Use pI to avoid cast.
3264 * region-cache.c (pp_cache): Likewise.
3265 * xdisp.c (decode_mode_spec): Likewise.
3266 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3267 behavior on 64-bit hosts with printf arg.
6f04d126 3268 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3269 (x_stop_queuing_selection_requests): Likewise.
3270 (x_get_window_property): Don't truncate byte count to an 'int'
3271 when tracing.
0b432f21 3272
5e073ec7
PE
3273 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3274 here, since it parses constructs like leading '-' and spaces,
3275 which are not wanted; and it overflows with large numbers.
3276 Instead, simply match F[0-9]+, which is what is wanted anyway.
3277
36372bf9
PE
3278 * alloc.c: Remove unportable assumptions about struct layout.
3279 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3280 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3281 (allocate_vectorlike, make_pure_vector): Use the new macros,
3282 plus offsetof, to remove unportable assumptions about struct layout.
3283 These assumptions hold on all porting targets that I know of, but
3284 they are not guaranteed, they're easy to remove, and removing them
3285 makes further changes easier.
3286
0b432f21
PE
3287 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3288 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3289 (string_overrun_cookie): Now const. Use initializers that
3290 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3291 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3292 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3293 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3294 multiple of sizeof (EMACS_INT); it need not be, if
3295 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3296 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3297
895009e1
JB
32982011-04-26 Juanma Barranquero <lekktu@gmail.com>
3299
3300 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3301
6a7a1b0b
TZ
33022011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3303
3304 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3305 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3306 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3307
841a1577 33082011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3309
3310 * lisp.h (Qdebug): List symbol.
895009e1 3311 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3312 * keyboard.c (debug-on-event): New variable.
3313 (handle_user_signal): Break into debugger when debug-on-event
3314 matches the current signal symbol.
3315
f2d3ba6f
DN
33162011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3317
3318 * alloc.c (check_sblock, check_string_bytes)
3319 (check_string_free_list): Convert to standard C.
3320
42ce4c63
TZ
33212011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3322
3323 * w32.c (emacs_gnutls_push): Fix typo.
3324
825cd63c
EZ
33252011-04-25 Eli Zaretskii <eliz@gnu.org>
3326
fb11d64d
EZ
3327 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3328 "cast to pointer from integer of different size".
3329
825cd63c
EZ
3330 Improve doprnt and its use in verror. (Bug#8545)
3331 * doprnt.c (doprnt): Document the set of format control sequences
3332 supported by the function. Use SAFE_ALLOCA instead of always
3333 using `alloca'.
3334
3335 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3336 is one byte too soon. Don't use xrealloc; instead xfree and
3337 xmalloc anew.
3338
e061a11b
TZ
33392011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3340
3341 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3342 callbacks stage.
3343
3344 * gnutls.c: Renamed global_initialized to
3345 gnutls_global_initialized. Added internals for the
3346 :verify-hostname-error, :verify-error, and :verify-flags
3347 parameters of `gnutls-boot' and documented those parameters in the
3348 docstring. Start callback support.
9173deec
JB
3349 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3350 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3351 on error. Return error code.
e061a11b
TZ
3352 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3353 (emacs_gnutls_read): Likewise.
3354 (Fgnutls_boot): Return handshake error code.
3355 (emacs_gnutls_handle_error): New function.
3356 (wsaerror_to_errno): Likewise.
3357
3358 * w32.h (emacs_gnutls_pull): Add prototype.
3359 (emacs_gnutls_push): Likewise.
3360
3361 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3362 (emacs_gnutls_push): Likewise.
3363
33642011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3365
3366 * process.c (wait_reading_process_output): Check if GnuTLS
3367 buffered some data internally if no FDs are set for TLS
3368 connections.
3369
3370 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3371 (LIBS): Link to USER_LIBS.
3372 ($(BLD)/gnutls.$(0)): New target.
3373
fa6996bc
EZ
33742011-04-24 Eli Zaretskii <eliz@gnu.org>
3375
eb35682e
EZ
3376 * xdisp.c (handle_single_display_spec): Rename the
3377 display_replaced_before_p argument into display_replaced_p, to
3378 make it consistent with the commentary. Fix typos in the
3379 commentary.
3380
e2ad650c
EZ
3381 * textprop.c (syms_of_textprop): Remove dead code.
3382 (copy_text_properties): Delete obsolete commentary about an
3383 interface that was deleted long ago. Fix typos in the description
3384 of arguments.
3385
1b2de274
EZ
3386 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3387 to changes in oldXMenu/XMenu.h from 2011-04-16.
3388 <menu_help_message, prev_menu_help_message>: Constify.
3389 (IT_menu_make_room): menu->help_text is now `const char **';
3390 adjust.
3391
3392 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3393 to changes in oldXMenu/XMenu.h from 2011-04-16.
3394 (struct XMenu): Declare `help_text' `const char **'.
3395
3396 * xfaces.c <Qunspecified>: Make extern again.
3397
3398 * syntax.c: Include sys/types.h before including regex.h, as
3399 required by Posix.
3400
762b15be
EZ
3401 * doc.c (get_doc_string): Improve the format passed to `error'.
3402
3403 * doprnt.c (doprnt): Improve commentary.
3404
3405 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3406
3407 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3408 them with etags.
3409
f1052e5d
EZ
3410 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3411 changes in globals.h immediately force recompilation.
762b15be
EZ
3412 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3413 $(CURDIR)/s/ms-w32.h.
3414 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3415
fa6996bc
EZ
3416 * character.c (Fchar_direction): Function deleted.
3417 (syms_of_character): Don't defsubr it.
3418 <char-direction-table>: Deleted.
3419
e6c3da20
EZ
34202011-04-23 Eli Zaretskii <eliz@gnu.org>
3421
3422 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3423 * doprnt.c: Include limits.h.
3424 (SIZE_MAX): New macro.
04f2d78b
CB
3425 (doprnt): Return a size_t value. 2nd arg is now size_t.
3426 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3427 Improve overflow protection. Support `l' modifier for integer
3428 conversions. Support %l conversion. Don't assume an EMACS_INT
3429 argument for integer conversions and for %c.
3430
3431 * lisp.h (doprnt): Restore prototype.
3432
3433 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3434 $(SRC)/character.h.
3435
3436 * Makefile.in (base_obj): Add back doprnt.o.
3437
3438 * deps.mk (doprnt.o): Add back prerequisites.
3439 (callint.o): Depend on character.h.
3440
3441 * eval.c (internal_lisp_condition_case): Include the handler
3442 representation in the error message.
3443 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3444 when breaking from the loop.
3445
3446 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3447
3448 * callint.c (Fcall_interactively): When displaying error message
3449 about invalid control letter, pass the character's codepoint, not
3450 a pointer to its multibyte form. Improve display of the character
3451 in octal and display also its hex code.
3452
3453 * character.c (char_string): Use %x to display the (unsigned)
3454 codepoint of an invalid character, to avoid displaying a bogus
3455 negative value.
3456
3457 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3458 `error', not SYMBOL_NAME itself.
3459
3460 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3461 character arguments to `error'.
3462
3463 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3464 to `error' in error message about FINAL_CHAR argument. Make sure
3465 FINAL_CHAR is a character, and use %c when it is passed as
3466 argument to `error'.
3467
4ffd0d6b 34682011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3469
3470 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3471
3472 * w32.c: Include <time.h>.
3473 (sys_localtime): New function.
3474
4ffd0d6b 34752011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3476
3477 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3478
4ffd0d6b 3479 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3480
4ffd0d6b 34812011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3482
4ffd0d6b
GM
3483 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3484 zombies (Bug#8467).
aac0c6e3 3485
04c56954
EZ
34862011-04-19 Eli Zaretskii <eliz@gnu.org>
3487
3488 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3489 gl_state.e_property when gl_state.object is Qt.
3490
3491 * insdel.c (make_gap_larger): Remove limitation of buffer size
3492 to <= INT_MAX.
3493
16a43933
CY
34942011-04-18 Chong Yidong <cyd@stupidchicken.com>
3495
3496 * xdisp.c (lookup_glyphless_char_display)
3497 (produce_glyphless_glyph): Handle cons cell entry in
3498 glyphless-char-display.
3499 (Vglyphless_char_display): Document it.
3500
3501 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3502 glyphless-char-display.
3503
4581706e
CY
35042011-04-17 Chong Yidong <cyd@stupidchicken.com>
3505
3506 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3507
3508 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3509
3510 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3511 definition for no-X builds.
3512
4887c6e2 35132011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3514
fd35b6f9
PE
3515 Static checks with GCC 4.6.0 and non-default toolkits.
3516
5c1ccb01
PE
3517 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3518
006c5daa
PE
3519 * process.c (keyboard_bit_set): Define only if SIGIO.
3520 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3521 (send_process): Repair possible setjmp clobbering.
3522
efc736d3
PE
3523 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3524
4e2fe2e6
PE
3525 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3526
f97334a2
PE
3527 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3528
4e75f29d
PE
3529 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3530 Define only if needed.
3531
90efadd1
PE
3532 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3533 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3534 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3535
3c647824
PE
3536 * dispextern.h (struct redisplay_interface): Rename param
3537 to avoid shadowing.
e264f262 3538 * termhooks.h (struct terminal): Likewise.
761383f4 3539 * xterm.c (xembed_send_message): Likewise.
3c647824 3540
b58c5c4a
PE
3541 * insdel.c (make_gap_smaller): Define only if
3542 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3543
cad59032
PE
3544 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3545 it.
3546
c339dc2e
PE
3547 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3548 so that we aren't warned about unused symbols.
3549
91a3e27b
PE
3550 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3551
399c71d3 3552 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3553
8ffc96f5
PE
3554 * xfns.c (x_real_positions): Mark locals as initialized.
3555
eef9bc79
PE
3556 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3557
098db9dd
PE
3558 * xterm.c: Fix problems found by static analysis with other toolkits.
3559 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3560 (x_dispatch_event): Declare static if USE_GTK, and
3561 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3562 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3563 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3564 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3565 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3566
eb18f6cc
PE
3567 * xmenu.c (menu_help_callback): Pointer type fixes.
3568 Use const pointers when pointing at readonly data. Avoid pointer
3569 signedness clashes.
3570 (FALSE): Remove unused macro.
3571 (update_frame_menubar): Remove unused decl.
3572
1fe72bf8
PE
3573 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3574
60d9e1db
PE
3575 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3576 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3577 (single_menu_item): Rename local to avoid shadowing.
3578
39261c26
PE
3579 * keyboard.c (make_lispy_event): Remove unused local var.
3580
018c5e19
PE
3581 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3582 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3583
63d2b86e
PE
3584 * bitmaps: Change bitmaps from unsigned char back to the X11
3585 compatible char. Avoid the old compiler warnings about
3586 out-of-range initializers by using, for example, '\xab' rather
3587 than 0xab.
3588
aefd87e1
PE
3589 * xgselect.c (xgselect_initialize): Check vs interface
3590 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3591
bf501fb9
PE
3592 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3593
e9829fdf
PE
3594 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3595 to read-only memory.
3596
1086c095
PE
3597 * fns.c (vector): Remove; this old hack is no longer needed.
3598
2baccd04 3599 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3600 Remove unused var.
dde42981 3601 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3602
72391843 3603 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3604
436c16df 3605 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3606 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3607 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3608
92bb796d 3609 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3610 (x_term_init): Remove local to avoid shadowing.
92bb796d 3611
764430a3 3612 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3613
3614 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3615 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3616
d1dfb56c
EZ
36172011-04-16 Eli Zaretskii <eliz@gnu.org>
3618
c4354cb4
EZ
3619 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3620
d1dfb56c
EZ
3621 Fix regex.c, syntax.c and friends for buffers > 2GB.
3622 * syntax.h (struct gl_state_s): Declare character position members
3623 EMACS_INT.
3624
3625 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3626
04f2d78b
CB
3627 * textprop.c (verify_interval_modification, interval_of):
3628 Declare arguments EMACS_INT.
d1dfb56c
EZ
3629
3630 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3631 EMACS_INT.
3632
3633 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3634
3635 * indent.c (Fvertical_motion): Local variable it_start is now
3636 EMACS_INT.
3637
3638 * regex.c (re_match, re_match_2, re_match_2_internal)
3639 (bcmp_translate, regcomp, regexec, print_double_string)
3640 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3641 (re_compile_pattern, re_exec): Declare arguments and local
3642 variables `size_t' and `ssize_t' and return values `regoff_t', as
3643 appropriate.
3644 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3645 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3646 <compile_stack_type>: `size' and `avail' are now `size_t'.
3647
3648 * regex.h <regoff_t>: Use ssize_t, not int.
3649 (re_search, re_search_2, re_match, re_match_2): Arguments that
3650 specify buffer/string position and length are now ssize_t and
3651 size_t. Return type is regoff_t.
3652
613052cd
BK
36532011-04-16 Ben Key <bkey76@gmail.com>
3654
3655 * nsfont.m: Fixed bugs in ns_get_family and
3656 ns_descriptor_to_entity that were caused by using free to
3657 deallocate memory blocks that were allocated by xmalloc (via
3658 xstrdup). This caused Emacs to crash when compiled with
3659 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3660 --enable-checking=xmallocoverrun). xfree is now used to
3661 deallocate these memory blocks.
3662
4170f62f 36632011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3664
71b41406
PE
3665 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3666
9587a89d
PE
3667 emacs_write: Accept and return EMACS_INT for sizes.
3668 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3669 et seq.
3670 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3671 Accept and return EMACS_INT.
3672 (emacs_gnutls_write): Return the number of bytes written on
3673 partial writes.
3674 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3675 (emacs_read, emacs_write): Remove check for negative size, as the
3676 Emacs source code has been audited now.
9587a89d
PE
3677 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3678 (emacs_read, emacs_write): Use it.
273a5f82
PE
3679 * process.c (send_process): Adjust to the new signatures of
3680 emacs_write and emacs_gnutls_write. Do not attempt to store
3681 a byte offset into an 'int'; it might overflow.
9587a89d 3682 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3683
3e047f51
PE
3684 * sound.c: Don't assume sizes fit in 'int'.
3685 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3686 Return EMACS_INT, not int.
3e047f51 3687 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3688 Accept EMACS_INT, not int.
3689 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3690 record read return values.
3691
cc39a9db
BK
36922011-04-15 Ben Key <bkey76@gmail.com>
3693
c9d0ec6d
JB
3694 * keyboard.c (Qundefined): Don't declare static since it is used
3695 in nsfns.m.
3696 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3697 static since they are used in nsfont.m.
cc39a9db 3698
6c60eb9f
SM
36992011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3700
3701 * process.c (Qprocessp): Don't declare static.
3702 * lisp.h (Qprocessp): Declare again.
3703
7990b61a
JB
37042011-04-15 Juanma Barranquero <lekktu@gmail.com>
3705
3706 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3707
5d4cb038
PE
37082011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3709
8bd7b830 3710 Improve C-level modularity by making more things 'static'.
cd64ea1d 3711
e3b27b31
PE
3712 Don't publish debugger-only interfaces to other modules.
3713 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3714 (verify_bytepos, count_markers): Move decls to the only modules
3715 that need them.
3716 * region-cache.h (pp_cache): Likewise.
3717 * window.h (check_all_windows): Likewise.
3718 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3719
5d4cb038
PE
3720 * sysdep.c (croak): Now static, if
3721 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3722 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3723
3724 * alloc.c (refill_memory_reserve): Now static if
3725 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3726 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3727
e87b6180
PE
3728 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3729 Define only if USE_LUCID.
3730
ac64929e
PE
3731 * xrdb.c (x_customization_string, x_rm_string): Now static.
3732
6f37259d
PE
3733 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3734 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3735
1683e3ab
PE
3736 * xdisp.c (draw_row_with_mouse_face): Now static.
3737 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3738
de9c2632
PE
3739 * window.h (check_all_windows): Mark externally visible.
3740
2b96acb7
PE
3741 * window.c (window_deletion_count): Now static.
3742
3743 * undo.c: Make symbols static if they're not exported.
3744 (last_undo_buffer, last_boundary_position, pending_boundary):
3745 Now static.
3746
50436f33
PE
3747 * textprop.c (interval_insert_behind_hooks): Now static.
3748 (interval_insert_in_front_hooks): Likewise.
3749
64520e5c
PE
3750 * term.c: Make symbols static if they're not exported.
3751 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3752 (max_frame_lines, tty_set_terminal_modes):
3753 (tty_reset_terminal_modes, tty_turn_off_highlight):
3754 (get_tty_terminal): Now static.
3755 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3756 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3757 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3758 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3759 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3760
1fa53021
PE
3761 * sysdep.c: Make symbols static if they're not exported.
3762 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3763 Now static.
3764 (sigprocmask_set, full_mask): Remove; unused.
3765 (wait_debugging): Mark as visible.
3766 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3767 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3768
d4b43b22
PE
3769 * syntax.c (syntax_temp): Define only if !__GNUC__.
3770
b7c513d0
PE
3771 * sound.c (current_sound_device, current_sound): Now static.
3772
989b29ad
PE
3773 * search.c (searchbufs, searchbuf_head): Now static.
3774
13a55a78
PE
3775 * scroll.c (scroll_cost): Remove; unused.
3776 * dispextern.h (scroll_cost): Remove decl.
3777
de68a1fc
PE
3778 * region-cache.h (pp_cache): Mark as externally visible.
3779
40ccffa6
PE
3780 * process.c: Make symbols static if they're not exported.
3781 (process_tick, update_tick, create_process, chan_process):
3782 (Vprocess_alist, proc_buffered_char, datagram_access):
3783 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3784 (deactivate_process): Mark defn as static, as well as decl.
3785 * lisp.h (create_process): Remove decl.
3786 * process.h (chan_process, Vprocess_alist): Remove decls.
3787
ad64fc97
PE
3788 * print.c: Make symbols static if they're not exported.
3789 (print_depth, new_backquote_output, being_printed, print_buffer):
3790 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3791 (print_interval, print_number_index, initial_stderr_stream):
3792 Now static.
3793 * lisp.h (Fprinc): Remove decl.
3794 (debug_output_compilation_hack): Mark as externally visible.
3795
adddb265
PE
3796 * sysdep.c (croak): Move decl from here to syssignal.h.
3797 * syssignal.h (croak): Put it here, so the API can be checked when
3798 'croak' is called from dissociate_if_controlling_tty.
3799
1717ede2
PE
3800 * minibuf.c: Make symbols static if they're not exported.
3801 (minibuf_save_list, choose_minibuf_frame): Now static.
3802 * lisp.h (choose_minibuf_frame): Remove decl.
3803
fa5fb2bc
PE
3804 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3805
1e3890d1
PE
3806 * lread.c: Make symbols static if they're not exported.
3807 (read_objects, initial_obarray, oblookup_last_bucket_number):
3808 Now static.
3809 (make_symbol): Remove; unused.
3810 * lisp.h (initial_obarray, make_symbol): Remove decls.
3811
8a1414fa
PE
3812 * keyboard.c: Make symbols static if they're not exported.
3813 (single_kboard, recent_keys_index, total_keys, recent_keys):
3814 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3815 (this_single_command_key_start, echoing, last_auto_save):
3816 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3817 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3818 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3819 (Vlispy_mouse_stem, double_click_count):
3820 Now static.
3821 (force_auto_save_soon): Define only if SIGDANGER.
3822 (ignore_mouse_drag_p): Now static if
3823 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3824 (print_help): Remove; unused.
3825 (stop_character, last_timer_event): Mark as externally visible.
3826 * keyboard.h (ignore_mouse_drag_p): Declare only if
3827 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3828 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3829 * lisp.h (echoing): Remove decl.
3830 (force_auto_save_soon): Declare only if SIGDANGER.
3831 * xdisp.c (redisplay_window): Simplify code, to make it more
3832 obvious that ignore_mouse_drag_p is not accessed if !defined
3833 USE_GTK && !defined HAVE_NS.
3834
93ea6e8f
PE
3835 * intervals.c: Make symbols static if they're not exported.
3836 (merge_properties_sticky, merge_interval_right, delete_interval):
3837 Now static.
3838 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3839
77382fcc
PE
3840 * insdel.c: Make symbols static if they're not exported.
3841 However, leave prepare_to_modify_buffer alone. It's never
3842 called from outside this function, but that appears to be a bug.
3843 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3844 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3845 (adjust_after_replace_noundo): Remove; unused.
3846 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3847 (signal_before_change): Remove decls.
77382fcc 3848
9306c32e
PE
3849 * indent.c (val_compute_motion, val_vmotion): Now static.
3850
cd44d2eb
PE
3851 * image.c: Make symbols static if they're not exported.
3852 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3853 if USE_GTK.
3854 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3855 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3856
ad9a7a06
PE
3857 * fringe.c (standard_bitmaps): Now static.
3858 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3859
81626931
PE
3860 * frame.c: Make symbols static if they're not exported.
3861 (x_report_frame_params, make_terminal_frame): Now static.
3862 (get_frame_param): Now static, unless HAVE_NS.
3863 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3864 (x_get_resource_string): Remove; not used.
3865 * frame.h (make_terminal_frame, x_report_frame_params):
3866 (x_get_resource_string); Remove decls.
3867 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3868 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3869
239f9db9
PE
3870 * font.c, fontset.c: Make symbols static if they're not exported.
3871 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3872 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3873 * font.c (font_close_object): Now static.
3874 * font.h (font_close_object): Remove.
3875 * fontset.c (FONTSET_OBJLIST): Remove.
3876 (free_realized_fontset) #if-0 the body, which does nothing.
3877 (face_suitable_for_char_p): #if-0, as it's never called.
3878 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3879 * xfaces.c (face_at_string_position):
3880 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3881 since 0 is always ASCII.
3882
dfcf3579
PE
3883 * fns.c (weak_hash_tables): Now static.
3884
5045092b
PE
3885 * fileio.c: Make symbols static if they're not exported.
3886 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3887 (Vwrite_region_annotation_buffers): Now static.
3888
57a96f5c
PE
3889 * eval.c: Make symbols static if they're not exported.
3890 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3891 * lisp.h (backtrace_list): Remove decl.
3892
35f08c38
PE
3893 * emacs.c: Make symbols static if they're not exported.
3894 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3895 (fatal_error_code, fatal_error_signal_hook, standard_args):
3896 Now static.
3897 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3898 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3899 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3900 * lisp.h (fatal_error_signal_hook): Remove decl.
3901 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3902
f44bd759
PE
3903 * editfns.c: Move a (normally-unused) function to its only use.
3904 * editfns.c, lisp.h (get_operating_system_release): Remove.
3905 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3906 worth the hassle of breaking this out.
3907
b532497d
PE
3908 * xterm.c: Make symbols static if they're not exported.
3909 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3910 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3911 (x_destroy_window, x_delete_display):
3912 Now static.
3913 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3914 (x_mouse_leave): Remove; unused.
3915 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3916 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3917 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3918 Remove decls.
3919 (x_mouse_leave): Declare only if WINDOWSNT.
3920 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3921 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3922 USE_X_TOOLKIT.
3923
1675728f
PE
3924 * ftxfont.c: Make symbols static if they're not exported.
3925 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3926 HAVE_FREETYPE.
3927 * font.h (ftxfont_driver): Likewise.
3928
e4cebfca
PE
3929 * xfns.c: Make symbols static if they're not exported.
3930 (x_last_font_name, x_display_info_for_name):
3931 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3932 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3933 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3934 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3935 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3936 (last_show_tip_args): Now static.
3937 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3938 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3939 (x_screen_planes): Remove; unused.
3940 * dispextern.h (x_screen_planes): Remove decl.
3941
5bf46f05
PE
3942 * dispnew.c: Make symbols static if they're not exported.
3943 * dispextern.h (redraw_garbaged_frames, scrolling):
3944 (increment_row_positions): Remove.
3945 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3946 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3947 Now static.
3948 (redraw_garbaged_frames): Remove; unused.
3949
435f4c28
PE
3950 * xfaces.c: Make symbols static if they're not exported.
3951 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3952 Remove decls.
3953 * xterm.h (defined_color): Remove decls.
3954 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3955 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3956 (menu_face_changed_default, defined_color, free_realized_face):
3957 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3958 (ascii_face_of_lisp_face): Remove; unused.
3959
8524aef3
PE
3960 * xdisp.c: Make symbols static if they're not exported.
3961 * dispextern.h (scratch_glyph_row, window_box_edges):
3962 (glyph_to_pixel_coords, set_cursor_from_row):
3963 (get_next_display_element, set_iterator_to_next):
3964 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3965 (show_mouse_face): Remove decls
3966 * frame.h (message_buf_print): Likewise.
3967 * lisp.h (pop_message, set_message, check_point_in_composition):
3968 Likewise.
3969 * xterm.h (set_vertical_scroll_bar): Likewise.
3970 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3971 (message_buf_print, scratch_glyph_row, displayed_buffer):
3972 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3973 (get_next_display_element, show_mouse_face, window_box_edges):
3974 (frame_to_window_pixel_xy, check_point_in_composition):
3975 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3976 (glyph_to_pixel_coords): Remove; unused.
3977
16390cd2
PE
3978 * dired.c (file_name_completion): Now static.
3979
3980 * dbusbind.c (xd_in_read_queued_messages): Now static.
3981
a25f4dfa
PE
3982 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3983 * data.c (circular_list_error): Remove.
3984
14a9c8df
PE
3985 * commands.h (last_point_position, last_point_position_buffer):
3986 (last_point_position_window): Remove decls.
3987 * keyboard.c: Make these variables static.
3988
04f2d78b
CB
3989 * coding.h (coding, code_convert_region, encode_coding_gap):
3990 Remove decls.
74ab6df5
PE
3991 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3992 (iso_code_class, detect_coding, code_convert_region): Now static.
3993 (encode_coding_gap): Remove; unused.
3994
38dfbee1
PE
3995 * chartab.c (chartab_chars, chartab_bits): Now static.
3996
a2cb4e63
PE
3997 * charset.h (charset_iso_8859_1): Remove decl.
3998 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3999 Now static.
4000
127198fd
PE
4001 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4002 * ccl.c (Vccl_program_table): Now static.
4003 (check_ccl_update): Remove; unused.
4004
d85b608f
PE
4005 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4006 * category.h: ... from here.
4007 * category.c (check_category_table, set_category_set): Now static.
4008
31cd66f3
PE
4009 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4010 * lisp.h: Remove these decls.
4011
c358e587
PE
4012 * buffer.c (buffer_count): Remove unused var.
4013
e78aecca
PE
4014 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4015 so that it's not optimized away.
4016 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4017 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4018 exported only to the debugger.
4019
e192d7d3 4020 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4021 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4022
92470028
PE
4023 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4024 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4025 was inaccessible from Lisp.
4026 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4027 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4028
244ed907
PE
4029 alloc.c: Import and export fewer symbols, and remove unused items.
4030 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4031 is defined.
4032 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4033 it's not optimized away by whole-program optimization.
4034 (message_enable_multibyte, free_misc): Remove.
4035 (catchlist, handlerlist, mark_backtrace):
4036 Declare only if BYTE_MARK_STACK.
4037 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4038 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4039 (message_enable_multibyte): Remove decl.
4040 (free_misc, interval_free_list, float_block, float_block_index):
4041 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4042 (cons_free_list, last_marked_index):
4043 Now static.
4044 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4045 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4046 (mark_backtrace): Define only if BYTE_MARK_STACK.
4047 * xdisp.c (message_enable_multibyte): Now static.
4048
61c2b50e 4049 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4050 This makes it easier for human readers (and static analyzers)
4051 to see whether these variables are used from other modules.
4052 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4053 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4054 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4055 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4056 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4057 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4058 * xmenu.c, xselect.c:
4059 Declare Q* vars static if they are not used in other modules.
4060 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4061 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4062 Remove decls of unexported vars.
4063 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4064
95c82688
PE
4065 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4066
16a97296
PE
4067 Make Emacs functions such as Fatom 'static' by default.
4068 This makes it easier for human readers (and static analyzers)
4069 to see whether these functions can be called from other modules.
4070 DEFUN now defines a static function. To make the function external
4071 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4072 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4073 (Finit_image_library):
16a97296
PE
4074 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4075 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4076 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4077 Remove decls, since these functions are now static.
4078 (Funintern, Fget_internal_run_time): New decls, since these functions
4079 were already external.
95c82688 4080
16a97296
PE
4081 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4082 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4083 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4084 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4085 * keyboard.c, keymap.c, lread.c:
4086 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4087 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4088 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4089 Mark functions with DEFUE instead of DEFUN,
4090 if they are used in other modules.
4091 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4092 decls for now-static functions.
4093 * buffer.h (Fdelete_overlay): Remove decl.
4094 * callproc.c (Fgetenv_internal): Mark as internal.
4095 * composite.c (Fremove_list_of_text_properties): Remove decl.
4096 (Fcomposition_get_gstring): New forward static decl.
4097 * composite.h (Fcomposite_get_gstring): Remove decl.
4098 * dired.c (Ffile_attributes): New forward static decl.
4099 * doc.c (Fdocumntation_property): New forward static decl.
4100 * eval.c (Ffetch_bytecode): New forward static decl.
4101 (Funintern): Remove extern decl; now in .h file where it belongs.
4102 * fileio.c (Fmake_symbolic_link): New forward static decl.
4103 * image.c (Finit_image_library): New forward static decl.
4104 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4105 * intervals.h (Fprevious_property_change):
4106 (Fremove_list_of_text_properties): Remove decls.
4107 * keyboard.c (Fthis_command_keys): Remove decl.
4108 (Fcommand_execute): New forward static decl.
4109 * keymap.c (Flookup_key): New forward static decl.
4110 (Fcopy_keymap): Now static.
4111 * keymap.h (Flookup_key): Remove decl.
4112 * process.c (Fget_process): New forward static decl.
4113 (Fprocess_datagram_address): Mark as internal.
4114 * syntax.c (Fsyntax_table_p): New forward static decl.
4115 (skip_chars): Remove duplicate decl.
4116 * textprop.c (Fprevious_property_change): New forward static decl.
4117 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4118 Now internal.
4119 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4120 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4121
785bbd42
PE
4122 * editfns.c (Fformat): Remove unreachable code.
4123
8b913b57
AS
41242011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4125
4126 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4127 change. (Bug#8496)
4128
a6744a35
EZ
41292011-04-13 Eli Zaretskii <eliz@gnu.org>
4130
4131 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4132 when at ZV. (Bug#8487)
4133
e7974947
AS
41342011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4135
baad03f0
AS
4136 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4137 (Bug#8437)
4138 * keyboard.c (parse_tool_bar_item): Likewise.
4139 * sound.c (sound_cleanup, alsa_close): Likewise.
4140 * termcap.c (tgetent): Likewise.
4141 * xfns.c (x_default_font_parameter): Likewise.
4142 * xsettings.c (read_and_apply_settings): Likewise.
4143
e7974947
AS
4144 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4145 (overrun_check_free): Protoize.
4146
28272684
PE
41472011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4148
4149 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4150 since callers should never pass a negative size.
4151 Change the signature to match that of plain 'read' and 'write'; see
4152 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4153 * lisp.h: Update prototypes of emacs_write and emacs_read.
4154
11997c76
EZ
41552011-04-11 Eli Zaretskii <eliz@gnu.org>
4156
4157 * xdisp.c (redisplay_window): Don't try to determine the character
4158 position of the scroll margin if the window start point w->startp
e896f03c 4159 is outside the buffer's accessible region. (Bug#8468)
11997c76 4160
8a2cbd72
EZ
41612011-04-10 Eli Zaretskii <eliz@gnu.org>
4162
4163 Fix write-region and its subroutines for buffers > 2GB.
4164 * fileio.c (a_write, e_write): Modify declaration of arguments and
4165 local variables to support buffers larger than 2GB.
4166 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4167
4168 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4169 argument, local variables, and return value.
4170
4171 * lisp.h: Update prototypes of emacs_write and emacs_read.
4172
4173 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4174
4073e537 41752011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4176
1ebfdcb6
PE
4177 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4178
b2ded58d
PE
4179 Fix more problems found by GCC 4.6.0's static checks.
4180
7d66342c
PE
4181 * xdisp.c (vmessage): Use a better test for character truncation.
4182
bbf47d44
PE
4183 * charset.c (load_charset_map): <, not <=, for optimization,
4184 and to avoid potential problems with integer overflow.
9248994d 4185 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4186 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4187 * editfns.c (Fformat): Likewise.
1e69125e 4188 * syntax.c (skip_chars): Likewise.
3befa583 4189
e3019616
PE
4190 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4191 This also lets GCC 4.6.0 generate slightly better loop code.
4192
becfa255
PE
4193 * callint.c (Fcall_interactively): <, not <=, for optimization.
4194 (Fcall_interactively): Count the number of arguments produced,
4195 not the number of arguments given. This is simpler and lets GCC
4196 4.6.0 generate slightly better code.
4197
dae0cd48
PE
4198 * ftfont.c: Distingish more carefully between FcChar8 and char.
4199 The previous code passed unsigned char * to a functions like
4200 strlen and xstrcasecmp that expect char *, which does not
4201 conform to the C standard.
4202 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4203 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4204 char * when the C standard requires it.
4205
76032d70
PE
4206 * keyboard.c (read_char): Remove unused var.
4207
eb3f1cc8
PE
4208 * eval.c: Port to Windows vsnprintf (Bug#8435).
4209 Include <limits.h>.
4210 (SIZE_MAX): Define if the headers do not.
4211 (verror): Do not give up if vsnprintf returns a negative count.
4212 Instead, grow the buffer. This ports to Windows vsnprintf, which
4213 does not conform to C99. Problem reported by Eli Zaretskii.
4214 Also, simplify the allocation scheme, by avoiding the need for
4215 calling realloc, and removing the ALLOCATED variable.
4216
70476b54
PE
4217 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4218
12020a9e
PE
4219 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4220 But keep the doprint source code for now, as we might revamp it
4221 and use it again (Bug#8435).
ea6c7ae6
PE
4222 * lisp.h (doprnt): Remove.
4223 * Makefile.in (base_obj): Remove doprnt.o.
4224 * deps.mk (doprnt.o): Remove.
4225
5fdb398c
PE
4226 error: Print 32- and 64-bit integers portably (Bug#8435).
4227 Without this change, on typical 64-bit hosts error ("...%d...", N)
4228 was used to print both 32- and 64-bit integers N, which relied on
4229 undefined behavior.
4230 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4231 New macro.
4232 * lisp.h (error, verror): Mark as printf-like functions.
4233 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4234 Report overflow in size calculations when allocating printf buffer.
4235 Do not truncate output string at its first null byte.
4236 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4237 Truncate the output at a character boundary, since vsnprintf does not
4238 do that.
4239 * charset.c (check_iso_charset_parameter): Convert internal
4240 character to string before calling 'error', since %c now has the
4241 printf meaning.
4242 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4243 overflow when computing char to be passed to 'error'. Do not
4244 pass Lisp_Object to 'error'; pass the integer instead.
4245 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4246 formatted with plain %d.
4247
b189fa66
PE
4248 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4249
bff87ef0
PE
4250 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4251
7e2cac20
PE
4252 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4253
ce4d90b5
PE
4254 * xterm.c (x_catch_errors): Remove duplicate declaration.
4255
266c9547
PE
4256 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4257
79c49ad2
PE
4258 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4259
368f4090
JM
42602011-04-10 Jim Meyering <meyering@redhat.com>
4261
4262 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4263 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4264 return ssize_t not "int", and use size_t as the buffer length.
4265 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4266 * gnutls.h: Update declarations.
4267 * process.c (read_process_output): Use ssize_t, to match.
4268 (send_process): Likewise.
4269
a32d4040
CY
42702011-04-09 Chong Yidong <cyd@stupidchicken.com>
4271
4272 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4273
8546720e 42742011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4275
04f2d78b
CB
4276 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4277 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4278
8546720e
GM
4279 * xterm.c (handle_one_xevent):
4280 * xmenu.c (create_and_show_popup_menu):
4281 * xselect.c (x_decline_selection_request)
4282 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4283
0a2f5c1a 42842011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4285
4286 Fix some uses of `int' instead of EMACS_INT.
4287 * search.c (string_match_1, fast_string_match)
4288 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4289 (scan_buffer, find_next_newline_no_quit)
4290 (find_before_next_newline, search_command, Freplace_match)
4291 (Fmatch_data): Make some `int' variables be EMACS_INT.
4292
4293 * xdisp.c (display_count_lines): 3rd argument and return value now
4294 EMACS_INT. All callers changed.
4295 (pint2hrstr): Last argument is now EMACS_INT.
4296
4297 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4298 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4299 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4300 (decode_coding_utf_16, decode_coding_emacs_mule)
4301 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4302 (decode_coding_ccl, decode_coding_charset)
4303 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4304 (decode_coding_iso_2022, decode_coding_emacs_mule)
4305 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4306 <char_offset, last_offset>: Declare EMACS_INT.
4307 (encode_coding_utf_8, encode_coding_utf_16)
4308 (encode_coding_emacs_mule, encode_invocation_designation)
4309 (encode_designation_at_bol, encode_coding_iso_2022)
4310 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4311 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4312 Declare EMACS_INT.
4313 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4314 (encode_invocation_designation): Last argument P_NCHARS is now
4315 EMACS_INT.
4316 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4317 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4318
4319 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4320 All users changed.
4321
4322 * ccl.c (Fccl_execute_on_string): Declare some variables
4323 EMACS_INT.
4324
8546720e 43252011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4326
4327 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4328
4e19a977
CS
43292011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4330
4331 * process.c (Fformat_network_address): Doc fix.
4332
87302331
R
43332011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4334
4335 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4336
cbb59342
CY
43372011-04-08 Chong Yidong <cyd@stupidchicken.com>
4338
4339 * keyboard.c (read_char): Call Lisp function help-form-show,
4340 instead of using internal_with_output_to_temp_buffer.
4341 (Qhelp_form_show): New var.
e0d38eeb 4342 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4343
4344 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4345
4346 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4347
e67a13ab
CY
43482011-04-06 Chong Yidong <cyd@stupidchicken.com>
4349
04f2d78b
CB
4350 * process.c (Flist_processes): Remove to Lisp.
4351 (list_processes_1): Delete.
e67a13ab 4352
973f782d
EZ
43532011-04-06 Eli Zaretskii <eliz@gnu.org>
4354
7c106b1e
EZ
4355 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4356
973f782d
EZ
4357 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4358
41cf7d1a 43592011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4360
ca23cc88
PE
4361 Fix more problems found by GCC 4.6.0's static checks.
4362
f390e2d5
PE
4363 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4364
42eea0d0
PE
4365 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4366
b69769da 4367 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4368
f9541e84
PE
4369 * xdisp.c (vmessage): Mark as a printf-like function.
4370
13841b55
PE
4371 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4372
c136c10f
PE
4373 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4374
5e2d4a30
PE
4375 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4376 printf-like functions.
4377 (tiff_load): Add casts to remove these marks before passing them
4378 to system-supplied API.
4379
583f48b9
PE
4380 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4381
b25d760e
PE
4382 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4383 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4384 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4385 directly, rather than having caller test rule sign. This avoids
4386 some unnecessary tests.
4387 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4388 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4389 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4390
bc7b6697 4391 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4392 (xfont_open): Avoid unnecessary tests.
bc7b6697 4393
27ccc379
PE
4394 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4395
dcd5c89a
PE
4396 * composite.h, composite.c (composition_gstring_put_cache):
4397 Use EMACS_INT, not int, for length.
4398
b13a45c6
PE
4399 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4400 breaking out part of COMPOSITION_DECODE_RULE.
4401 (COMPOSITION_DECODE_RULE): Use it.
4402 * composite.c (get_composition_id): Remove unused local vars,
4403 by using the new macro.
4404
1e792e4d
PE
4405 * textprop.c (set_text_properties_1): Change while to do-while,
4406 since the condition is always true at first.
4407
dc6c6455 4408 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4409 (interval_deletion_adjustment): Return unsigned value.
4410 All uses changed.
dc6c6455 4411
aba7731a
PE
4412 * process.c (list_processes_1, create_pty, read_process_output):
4413 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4414 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4415 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4416 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4417 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4418
fdfc4bf3
PE
4419 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4420
fca8fe46 4421 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4422 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4423
06a0259a 4424 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4425 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4426 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4427
e7b9e80f
PE
4428 * print.c (print_error_message): Avoid int overflow.
4429
56201685
PE
4430 * font.c (font_list_entities): Redo for clarity,
4431 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4432
78834453 4433 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4434 (font_score): Avoid potential overflow in diff calculation.
78834453 4435
0bc0b309 4436 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4437 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4438
e610eaca
PE
4439 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4440
b895abce
PE
4441 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4442 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4443 can always succeed if overflow has undefined behavior.
4444
1f1d9321 4445 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4446 (wordify): Omit three unnecessary tests.
1f1d9321 4447
c59478bc
PE
4448 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4449 All callers changed. This avoids the need for an unused var.
4450
79b73827
PE
4451 * casefiddle.c (casify_region): Remove var that is set but not used.
4452
a4db5dfe
PE
4453 * dired.c (file_name_completion): Remove var that is set but not used.
4454
43aae36e
PE
4455 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4456
2a47c44d 4457 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4458 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4459
a37c69bf
PE
4460 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4461 Check for integer overflow on size calculations.
4462
328ab8e7
PE
4463 * buffer.c (Fprevious_overlay_change): Remove var that is set
4464 but not used.
4465
e5a2a5cb
PE
4466 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4467 Remove vars that are set but not used.
8d84a6eb 4468 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4469 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4470
a60e5f68
PE
4471 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4472
f661cb61 4473 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4474 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4475
f0397f5a
PE
4476 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4477 that are set but not used.
4478
8664db06 4479 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4480 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4481
6abdaa4a
PE
4482 * xselect.c (x_get_local_selection, x_handle_property_notify):
4483 Remove vars that are set but not used.
4484
0ce7538d 4485 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4486 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4487
9ae848fc
PE
4488 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4489 Remove var that is set but not used.
0b918413
PE
4490 (scroll_bar_windows_size): Now size_t, not int.
4491 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4492 Check for overflow.
9ae848fc 4493
a5a62657
PE
4494 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4495 (map_tty_color) [!defined MSDOS]: Likewise.
4496
5c5cdd39
PE
4497 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4498
66ebf983
PE
4499 * coding.c: Remove vars that are set but not used.
4500 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4501 All callers changed.
4502 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4503 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4504 (decode_coding_charset): Remove vars that are set but not used.
4505
1be4d761
PE
4506 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4507 that is set but not used.
4508
47553fa8
PE
4509 * print.c (print_object): Remove var that is set but not used.
4510
1f7196bf 4511 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4512 The gnulib version avoids calling malloc in the usual case,
4513 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4514 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4515 * filelock.c (current_lock_owner): Likewise.
4516 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4517 * sysdep.c: Include allocator.h, careadlinkat.h.
4518 (emacs_no_realloc_allocator): New static constant.
4519 (emacs_readlink): New function.
fdb61804
PE
4520 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4521 ../lib/careadlinkat.h.
d1fdcab7 4522
f84c17c7
SM
45232011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4524
4525 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4526 first non-nil return value).
4527
ef3862ad
JD
45282011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4529
4530 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4531 if not defined (Bug#8403).
4532
376a7006
JB
45332011-04-02 Juanma Barranquero <lekktu@gmail.com>
4534
4535 * xdisp.c (display_count_lines): Remove parameter `start',
4536 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4537 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4538 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4539 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4540 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4541 and thereabouts. All callers changed.
4542 (get_per_char_metric): Remove parameter `f', unused since
4543 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4544
6ca3801d
JM
45452011-04-02 Jim Meyering <meyering@redhat.com>
4546
4547 do not dereference NULL upon failed strdup
4548 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4549 (ns_get_family): Likewise.
4550
d8e2b5ba
JB
45512011-04-02 Juanma Barranquero <lekktu@gmail.com>
4552
4553 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4554
8c74fcbd
JD
45552011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4556
4557 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4558 later (Bug#8403).
4559
7200d79c
SM
45602011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4561
03408648 4562 Add lexical binding.
7200d79c 4563
03408648
SM
4564 * window.c (Ftemp_output_buffer_show): New fun.
4565 (Fsave_window_excursion):
4566 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4567
4568 * lread.c (lisp_file_lexically_bound_p): New function.
4569 (Fload): Bind Qlexical_binding.
4570 (readevalloop): Remove `evalfun' arg.
4571 Bind Qinternal_interpreter_environment.
4572 (Feval_buffer): Bind Qlexical_binding.
4573 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4574 Mark as dynamic.
4575 (syms_of_lread): Declare `lexical-binding'.
4576
4577 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4578
4579 * keyboard.c (eval_dyn): New fun.
4580 (menu_item_eval_property): Use it.
ca105506
SM
4581
4582 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4583
03408648
SM
4584 * fns.c (concat, mapcar1): Accept byte-code-functions.
4585
4586 * eval.c (Fsetq): Handle lexical vars.
4587 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4588 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4589 (FletX, Flet): Obey lexical binding.
4590 (Fcommandp): Handle closures.
4591 (Feval): New `lexical' arg.
4592 (eval_sub): New function extracted from Feval. Use it almost
4593 everywhere where Feval was used. Look up vars in lexical env.
4594 Handle closures.
4595 (Ffunctionp): Move from subr.el.
4596 (Ffuncall): Handle closures.
4597 (apply_lambda): Remove `eval_flags'.
4598 (funcall_lambda): Handle closures and new byte-code-functions.
4599 (Fspecial_variable_p): New function.
4600 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4601 but without exporting it to Lisp.
23aba0ea 4602
23aba0ea 4603 * doc.c (Fdocumentation, store_function_docstring):
03408648 4604 * data.c (Finteractive_form): Handle closures.
23aba0ea 4605
03408648
SM
4606 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4607 interactive spec.
ba83908c 4608
04f2d78b
CB
4609 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4610 New byte-codes.
03408648
SM
4611 (exec_byte_code): New function extracted from Fbyte_code to handle new
4612 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4613
03408648 4614 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4615
03408648 4616 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4617
e2abce01
JB
46182011-03-31 Juanma Barranquero <lekktu@gmail.com>
4619
4620 * xdisp.c (redisplay_internal): Fix prototype.
4621
63696a73 46222011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4623
63696a73 4624 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4625 (try_scrolling): Use it when setting scroll_limit.
4626 Limit scrolling to 100 screen lines.
63696a73
EZ
4627 (redisplay_window): Even when falling back on "recentering",
4628 position point in the window according to scroll-conservatively,
4629 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4630
4631 (try_scrolling): When point is above the window, allow searching
4632 as far as scroll_max, or one screenful, to compute vertical
4633 distance from PT to the scroll margin position. This prevents
4634 try_scrolling from unnecessarily failing when
4635 scroll-conservatively is set to a value slightly larger than the
4636 window height. Clean up the case of PT below the margin at bottom
4637 of window: scroll_max can no longer be INT_MAX. When aggressive
4638 scrolling is in use, don't let point enter the opposite scroll
4639 margin as result of the scroll.
4640 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4641 threshold of 100 lines for never-recentering scrolling.
4642
e4cc2dfc
JB
46432011-03-31 Juanma Barranquero <lekktu@gmail.com>
4644
4645 * dispextern.h (move_it_by_lines):
4646 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4647 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4648 (message_log_check_duplicate): Remove parameters `prev_bol' and
4649 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4650 (redisplay_internal): Remove parameter `preserve_echo_area',
4651 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4652
4653 * indent.c (Fvertical_motion):
4654 * window.c (window_scroll_pixel_based, Frecenter):
4655 Don't pass `need_y_p' to `move_it_by_lines'.
4656
1c470562
SM
46572011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4658
44f230aa
SM
4659 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4660 steal a few bits to be more compact.
4661 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4662 Remove unneeded casts.
4663
1c470562
SM
4664 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4665
888adce9
ZK
46662011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4667
4668 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4669 binding" message (bug#7967).
4670
f838ed7b
PE
46712011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4672
77861b95
PE
4673 Fix more problems found by GCC 4.6.0's static checks.
4674
de6dbc14
PE
4675 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4676 Remove unused local var.
4677
f838ed7b
PE
4678 * editfns.c (Fmessage_box): Remove unused local var.
4679
792c7b2b
PE
4680 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4681 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4682 Omit unused local vars.
c499e557 4683 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4684 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4685 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4686 Omit unused local var.
4687
ba0165e1
PE
4688 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4689 Don't assume string length fits in int.
32ad8845 4690 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4691 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4692
3c59b4c9
PE
4693 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4694 instead of alloca (Bug#8344).
4695
a3eed478 4696 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4697 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4698
eb4d412d
PE
4699 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4700
1658b401
PE
4701 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4702 concerns.
4703
4704 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4705
4706 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4707
9a2c6e05
PE
4708 * keyboard.c (syms_of_keyboard): Use the same style as later
4709 in this function when indexing through an array. This also
4710 works around GCC bug 48267.
4711
03d0a109
PE
4712 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4713
44f730c8
PE
4714 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4715
fe75f926
PE
4716 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4717 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4718
ffa8c828
PE
4719 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4720 This avoids undefined behavior on integer overflow, and is a bit
4721 more convenient anyway since it is compared to a size_t variable.
4722
c5101a77
PE
4723 Variadic C functions now count arguments with size_t, not int.
4724 This avoids an unnecessary limitation on 64-bit machines, which
4725 caused (substring ...) to crash on large vectors (Bug#8344).
4726 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4727 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4728 All variadic functions and their callers changed accordingly.
c5101a77
PE
4729 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4730 * data.c (arith_driver, float_arith_driver): Likewise.
4731 * editfns.c (general_insert_function): Likewise.
4732 * eval.c (struct backtrace.nargs, interactive_p)
4733 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4734 (funcall_lambda, mark_backtrace): Likewise.
4735 * fns.c (concat): Likewise.
4736 * frame.c (x_set_frame_parameters): Likewise.
4737 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4738 0 if not found, not -1. All callers changed.
4739
dd3f25f7
PE
4740 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4741 (stack_copy_size): Now size_t, not int.
4742 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4743
461c2ab9
JB
47442011-03-28 Juanma Barranquero <lekktu@gmail.com>
4745
4746 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4747 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4748 All callers changed.
4749
4750 * lisp.h (multibyte_char_to_unibyte):
4751 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4752 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4753 * character.h (CHAR_TO_BYTE8):
4754 * cmds.c (internal_self_insert):
4755 * editfns.c (general_insert_function):
4756 * keymap.c (push_key_description):
4757 * search.c (Freplace_match):
4758 * xdisp.c (message_dolog, set_message_1): All callers changed.
4759
f6d62986
SM
47602011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4761
4762 * keyboard.c (safe_run_hook_funcall): New function.
4763 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4764 don't set the hook to nil, but remove the offending function instead.
4765 (Qcommand_hook_internal): Remove, unused.
4766 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4767 Vcommand_hook_internal.
4768
4769 * eval.c (enum run_hooks_condition): Remove.
4770 (funcall_nil, funcall_not): New functions.
4771 (run_hook_with_args): Call each function through a `funcall' argument.
4772 Remove `cond' argument, now redundant.
4773 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4774 (Frun_hook_with_args_until_failure): Adjust accordingly.
4775 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4776
1db5b1ad
JB
47772011-03-28 Juanma Barranquero <lekktu@gmail.com>
4778
4779 * dispextern.h (string_buffer_position): Remove declaration.
4780
4781 * print.c (strout): Remove parameter `multibyte', unused since
4782 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4783
4784 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4785 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4786 All callers changed.
4787
4788 * w32.c (_wsa_errlist): Use braces for struct initializers.
4789
4790 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4791 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4792 All callers changed.
4793 (string_buffer_position): Likewise. Also, make static (it's never
4794 used outside xdisp.c).
4795 (cursor_row_p): Remove parameter `w', unused since
4796 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4797 (decode_mode_spec): Remove parameter `precision', introduced during
4798 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4799 All callers changed.
4800
5ffb62aa
JD
48012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4802
4803 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4804
461c2ab9 48052011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4806
4807 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4808 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4809 (ns_update_auto_hide_menu_bar): New functions.
4810 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4811 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4812 ns_constrain_all_frames.
4813 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4814 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4815
5c380ffb
JD
48162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4817
4818 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4819
9af30bdf
GM
48202011-03-27 Glenn Morris <rgm@gnu.org>
4821
4822 * syssignal.h: Replace RETSIGTYPE with void.
4823 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4824 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4825 Replace SIGTYPE with void everywhere.
4826 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4827 * s/template.h (SIGTYPE): Remove commented out definition.
4828
e2abce01
JB
48292011-03-26 Eli Zaretskii <eliz@gnu.org>
4830
4831 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4832 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4833
f868cd8a
JB
48342011-03-26 Juanma Barranquero <lekktu@gmail.com>
4835
59eb0929
JB
4836 * w32.c (read_unc_volume): Use parameter `henum', instead of
4837 global variable `wget_enum_handle'.
4838
4839 * keymap.c (describe_vector): Remove parameters `indices' and
4840 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4841 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4842
f868cd8a
JB
4843 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4844
4845 * keyboard.c (timer_check): Remove parameter `do_it_now',
4846 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4847 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4848 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4849
4850 * keyboard.c (read_char):
4851 * w32menu.c (w32_menu_display_help):
4852 * xmenu.c (show_help_event, menu_help_callback):
4853 Adjust calls to `show_help_echo'.
4854
4855 * gtkutil.c (xg_maybe_add_timer):
4856 * keyboard.c (readable_events):
4857 * process.c (wait_reading_process_output):
4858 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4859
4860 * insdel.c (adjust_markers_gap_motion):
4861 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4862 (gap_left, gap_right): Don't call it.
4863
2ecf6fdb
CY
48642011-03-25 Chong Yidong <cyd@stupidchicken.com>
4865
4866 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4867 incurred during fontification.
4868
6b1f9ba4
JB
48692011-03-25 Juanma Barranquero <lekktu@gmail.com>
4870
4871 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4872 (DEFVAR_PER_BUFFER): Don't pass it.
4873
4874 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4875 (scrolling_window): Don't pass it.
4876
0f4a96b5
JB
48772011-03-25 Juanma Barranquero <lekktu@gmail.com>
4878
4879 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4880
4881 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4882 and `suffix'.
4883 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4884 of variables specific to SELinux and computation of `encoded_absname'.
4885
4886 * image.c (XPutPixel): Remove unused variable `height'.
4887
4888 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4889
4890 * unexw32.c (get_section_info): Remove unused variable `section'.
4891
4892 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4893 (system_process_attributes): Remove unused variable `sess'.
4894 (sys_read): Remove unused variable `err'.
4895
4896 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4897 (w32_wnd_proc): Remove unused variable `isdead'.
4898 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4899 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4900 (x_create_tip_frame): Remove unused variable `tem'.
4901
4902 * w32inevt.c (w32_console_read_socket):
4903 Remove unused variable `no_events'.
4904
4905 * w32term.c (x_draw_composite_glyph_string_foreground):
4906 Remove unused variable `width'.
4907
1149507c
JB
49082011-03-24 Juanma Barranquero <lekktu@gmail.com>
4909
4910 * w32term.c (x_set_glyph_string_clipping):
4911 Don't pass uninitialized region to CombineRgn.
4912
9c88f339
JB
49132011-03-23 Juanma Barranquero <lekktu@gmail.com>
4914
4915 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4916 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4917 (Fx_close_connection): Remove unused variable `i'.
4918
4919 * w32font.c (w32font_draw): Return number of glyphs.
4920 (w32font_open_internal): Remove unused variable `i'.
4921 (w32font_driver): Add missing initializer.
4922
4923 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4924 (fill_in_menu): Remove unused variable `items_added'.
4925
4926 * w32term.c (last_mouse_press_frame): Remove static global variable.
4927 (w32_clip_to_row): Remove unused variable `f'.
4928 (x_delete_terminal): Remove unused variable `i'.
4929
4930 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4931 (NOTHING): Remove unused static global variable.
4932 (uniscribe_check_otf): Remove unused variable `table'.
4933 (uniscribe_font_driver): Add missing initializers.
4934
dee091a3
JD
49352011-03-23 Julien Danjou <julien@danjou.info>
4936
4937 * term.c (Fsuspend_tty, Fresume_tty):
4938 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4939 * window.c (temp_output_buffer_show):
4940 * insdel.c (signal_before_change):
4941 * frame.c (Fhandle_switch_frame):
4942 * fileio.c (Fdo_auto_save):
4943 * emacs.c (Fkill_emacs):
4944 * editfns.c (save_excursion_restore):
4945 * cmds.c (internal_self_insert):
4946 * callint.c (Fcall_interactively):
4947 * buffer.c (Fkill_all_local_variables):
4948 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4949 Use Frun_hooks.
0f4a96b5 4950 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4951 unconditionnaly since it does the check itself.
4952
2c520ab5 49532011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4954
c9c49752
PE
4955 Fix more problems found by GCC 4.5.2's static checks.
4956
8abc3f12
PE
4957 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4958 the first time through the loop, since we know p0 < p1 then.
4959 This also avoids a gcc -Wstrict-overflow warning.
4960
a2d26660
PE
4961 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4962 leading to a memory leak, possible in functions like
4963 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4964 of objects (Bug#8318).
a2d26660 4965
916c72e9
PE
4966 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4967 that could (at least in theory) be that large.
4968
19ab8a18
PE
4969 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4970 This is less likely to overflow, and avoids undefined behavior if
4971 overflow does occur. All callers changed. Use strtoul to scan
4972 for the unsigned long integer.
b7cbbd6f
PE
4973 (pint2hrstr): Simplify and tune code slightly.
4974 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4975
f0641eff
PE
4976 * scroll.c (do_scrolling): Work around GCC bug 48228.
4977 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4978
7f650bb9
PE
4979 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4980 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4981 (validate_x_resource_name): Simplify count usage.
4982 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4983
37dd57d1
PE
4984 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4985 fail (Bug#8306).
81e56e61 4986
699979fc 4987 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4988
401bf9b4
PE
4989 * process.c (Fmake_network_process): Use socklen_t, not int,
4990 where POSIX says socklen_t is required in portable programs.
4991 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4992 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4993 (Fmake_network_process, server_accept_connection):
4994 (wait_reading_process_output, read_process_output):
4995 Likewise.
4996
b93aacde
PE
4997 * process.c: Rename or move locals to avoid shadowing.
4998 (list_processes_1, Fmake_network_process):
4999 (read_process_output_error_handler, exec_sentinel_error_handler):
5000 Rename or move locals.
4dc343ee 5001 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5002 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5003 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5004 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5005 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5006
af8a867c 5007 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5008 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5009 Include tparam.h instead, since it declares them.
af8a867c
PE
5010 * cm.h (PC): Remove extern decl; tparam.h now does this.
5011 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5012 * terminfo.c: Include tparam.h, to check interfaces.
5013 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5014 (tparam): Adjust signature to match interface in tparam.h;
5015 this removes some undefined behavior. Check that outstring and len
5016 are zero, which they always are with Emacs.
5017 * tparam.h (PC, BC, UP): New extern decls.
5018
0248044d 5019 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5020 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5021
8ff096c1 5022 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5023 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5024 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5025 (ftfont_list): Remove unused local.
49eaafba
PE
5026 (get_adstyle_property, ftfont_pattern_entity):
5027 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5028 Rename locals to avoid shadowing.
8ff096c1 5029
e2be39f6
PE
5030 * xfont.c (xfont_list_family): Mark var as initialized.
5031
c9735e30
PE
5032 * xml.c (make_dom): Now static.
5033
8f5201ae
PE
5034 * composite.c (composition_compute_stop_pos): Rename local to
5035 avoid shadowing.
b246f932
PE
5036 (composition_reseat_it): Remove unused locals.
5037 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5038 (composition_update_it): Mark var as initialized.
11b61122
PE
5039 (find_automatic_composition): Mark vars as initialized,
5040 with a FIXME (Bug#8290).
8f5201ae 5041
760fbc2c
PE
5042 character.h: Rename locals to avoid shadowing.
5043 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5044 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5045 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5046 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5047 to avoid shadowing.
5048
ff08eb85
PE
5049 * textprop.c (property_change_between_p): Remove; unused.
5050
fc7bf025
PE
5051 * intervals.c (interval_start_pos): Now static.
5052
235d7abc
PE
5053 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5054
44f230aa
SM
5055 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5056 Rename locals to avoid shadowing.
3e7d6594 5057
50060332
PE
5058 * sound.c (wav_play, au_play, Fplay_sound_internal):
5059 Fix pointer signedness.
d01f234b 5060 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5061 (wav_play): Initialize a variable to 0, to prevent undefined
5062 behavior (Bug#8278).
50060332 5063
c4fc4e30
PE
5064 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5065
918436ed
PE
5066 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5067
c939f91b
PE
5068 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5069 clobbering (Bug#8298).
b9c7f648
PE
5070 * sysdep.c (sys_subshell): Likewise.
5071 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5072
6bd8c144
PE
5073 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5074 This should get cleaned up, so that child_setup has the
5075 same signature on all platforms.
5076
7710357c 5077 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5078 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5079
c59da222
CY
50802011-03-22 Chong Yidong <cyd@stupidchicken.com>
5081
5082 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5083 not to be necessary, and produces flickering.
5084
66b87493
GM
50852011-03-20 Glenn Morris <rgm@gnu.org>
5086
5087 * config.in: Remove file.
5088
45b6f6d5
JB
50892011-03-20 Juanma Barranquero <lekktu@gmail.com>
5090
5091 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5092 are now in src/globals.h.
5093 (syms_of_minibuf): Remove spurious & from previous change.
5094
3ec03f7e
LL
50952011-03-20 Leo <sdl.web@gmail.com>
5096
5097 * minibuf.c (completing-read-function): New variable.
5098 (completing-read-default): Rename from completing-read.
5099 (completing-read): Call completing-read-function.
5100
b14e3e21
CY
51012011-03-19 Juanma Barranquero <lekktu@gmail.com>
5102
5103 * xfaces.c (Fx_load_color_file):
5104 Read color file from absolute filename (bug#8250).
5105
f2b726e6
JB
51062011-03-19 Juanma Barranquero <lekktu@gmail.com>
5107
5108 * makefile.w32-in: Update dependencies.
5109
09f6ff02
EZ
51102011-03-17 Eli Zaretskii <eliz@gnu.org>
5111
5112 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5113
29a6015a
PE
51142011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5115
a3a6c54e
PE
5116 Fix more problems found by GCC 4.5.2's static checks.
5117
b766f867
PE
5118 * process.c (make_serial_process_unwind, send_process_trap):
5119 (sigchld_handler): Now static.
5120
be02381c
PE
5121 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5122 That way, the code declares only the vars that it needs.
5123 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5124 * s/cygwin.h (PTY_ITERATION): Likewise.
5125 * s/darwin.h (PTY_ITERATION): Likewise.
5126 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5127
57048744
PE
5128 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5129 * process.c (allocate_pty): Don't declare stb unless it's needed.
5130
7914961c 5131 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5132 (CONSTANTLIM): Remove; unused.
5133 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5134 Define only if needed.
7914961c 5135
b3967b18
PE
5136 * unexelf.c (unexec): Name an expression,
5137 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5138 Use a different way to cause a compilation error if anyone uses
5139 n rather than nn, a way that does not involve shadowing.
73366a00 5140 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5141
29a6015a
PE
5142 * deps.mk (unexalpha.o): Remove; unused.
5143
43cfc33e 5144 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5145 * unexec.h: New file.
ce701a33
PE
5146 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5147 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5148 Depend on unexec.h.
5149 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5150 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5151 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5152 Change as necessary to match prototype in unexec.h.
ce701a33 5153
01f44d5a
PE
5154 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5155 shadowing.
4f63c6bb 5156 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5157
a6670b0b
PE
5158 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5159 Rename locals to avoid shadowing.
5160
cef2010d 5161 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5162 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5163
d4d7173a
PE
5164 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5165
f08b802a
PE
5166 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5167 warning when compiling print.c.
5168
3ddb0639
PE
5169 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5170 instead of using an uninitialized var.
5ad03b97 5171 (font_sort_entities): Mark var as initialized.
3ddb0639 5172
170a2692
PE
5173 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5174
e663c700
PE
5175 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5176 pointers to constants.
89bc529a 5177 (font_parse_fcname): Remove unused vars.
7b81e2d0 5178 (font_delete_unmatched): Now static.
ea838e10 5179 (font_get_spec): Remove; unused.
13a547c6
PE
5180 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5181 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5182 Rename or move locals to avoid shadowing.
e663c700 5183
2a80c887 5184 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5185 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5186
1384fa33 5187 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5188 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5189
8b2c52e9
PE
5190 * alloc.c (mark_backtrace): Move decl from here ...
5191 * lisp.h: ... to here, so that it can be checked.
5192
475545b5 5193 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5194 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5195 (lisp_indirect_variable): Name an expression,
5196 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5197 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5198
b1349114 5199 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5200 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5201 Use const pointer when appropriate.
b1349114 5202
a2928364
PE
5203 * lisp.h (get_system_name, get_operating_system_release):
5204 Move decls here, to check interfaces.
5205 * process.c (get_operating_system_release): Move decl to lisp.h.
5206 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5207 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5208 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5209 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5210 (Fformat_time_string, Fencode_time, Finsert_char):
5211 (Ftranslate_region_internal, Fformat):
5212 Rename or remove local vars to avoid shadowing.
9710023e 5213 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5214
a415e694
PE
5215 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5216 avoid shadowing.
5217
8ef4622d
PE
5218 * lisp.h (eassert): Check that the argument compiles, even if
5219 ENABLE_CHECKING is not defined.
5220
946f9a5b
PE
5221 * data.c (Findirect_variable): Name an expression, to avoid
5222 gcc -Wbad-function-cast warning.
112396d6 5223 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5224 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5225 (Fmake_variable_buffer_local, Fmake_local_variable):
5226 Mark variables as initialized.
52746918 5227 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5228
e5aab7e7 5229 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5230 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5231 Rename locals to avoid shadowing.
dff45157
PE
5232 (mark_stack): Move local variables into the #ifdef region where
5233 they're used.
7bc26fdb
PE
5234 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5235 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5236 needed otherwise.
5237 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5238 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5239 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5240
e5aab7e7
PE
5241 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5242 avoids undefined behavior in theory.
5243
4da60324
PE
5244 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5245
88043301
PE
5246 Use functions, not macros, for up- and down-casing (Bug#8254).
5247 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5248 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5249 to use the following functions instead of these macros.
5250 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5251 EMACS_INT, since callers assume the returned value fits in int.
5252 (upcase1): Likewise, for UPCASE_TABLE.
5253 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5254 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5255 the race-condition problem in the old DOWNCASE.
88043301 5256
19ed5445
PE
5257 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5258 Rename locals to avoid shadowing.
5259 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5260 (regex_compile, re_search_2, re_match_2_internal):
5261 Remove unused local vars.
952db0d7
PE
5262 (FREE_VAR): Rewrite so as not to use empty "else",
5263 which gcc can warn about.
da053e48 5264 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5265 (RETALLOC_IF): Define only if needed.
5266 (WORDCHAR_P): Likewise. This one is never needed, but is used
5267 only in a comment talking about a compiler bug, so put inside
5268 the #if 0 of that comment.
5269 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5270 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5271 Remove; unused.
19ed5445 5272
1f3561e4 5273 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5274 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5275 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5276
ded6f8f7
PE
5277 * search.c (simple_search): Remove unused var.
5278
dbd37a95
PE
5279 * dired.c (compile_pattern): Move decl from here ...
5280 * lisp.h: ... to here, so that it can be checked.
5281 (struct re_registers): New forward decl.
5282
7e47afad
PE
5283 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5284
85f24f61
PE
5285 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5286 All uses changed.
5287 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5288 Rename locals to avoid shadowing.
5671df8f 5289 (Fvertical_motion): Mark locals as initialized.
85f24f61 5290
181aa2be 5291 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5292 (casify_region): Mark local as initialized.
181aa2be 5293
930d429c
PE
5294 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5295
7082eac6
PE
5296 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5297 New macros, so that the caller can use some names other than
5298 gcpro1, gcpro2, etc.
5299 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5300 of the new macros.
5301 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5302 argument, for consistency with GCPRO2_VAR, etc: it is now the
5303 prefix of the variable, not the variable itself. All uses
5304 changed.
38b2c076
PE
5305 * dired.c (directory_files_internal, file_name_completion):
5306 Rename locals to avoid shadowing.
5307
15206ed9
PE
5308 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5309 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5310 dired.c's scmp function, had undefined behavior.
5311 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5312 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5313 * buffer.h: ... to here, because these macros use current_buffer,
5314 and the new implementation with inline functions needs to have
5315 current_buffer in scope now, rather than later when the macros
5316 are used.
5317 (downcase, upcase1): New static inline functions.
5318 (DOWNCASE, UPCASE1): Reimplement using these functions.
5319 This avoids undefined behavior in expressions like
5320 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5321 from race conditions in accessing the global variables
5322 case_temp1 and case_temp2.
5323 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5324 * lisp.h (case_temp1, case_temp2): Remove their decls.
5325 * character.h (ASCII_CHAR_P): Move from here ...
5326 * lisp.h: ... to here, so that the inline functions mentioned
5327 above can use them.
5328
4a6bea26
PE
5329 * dired.c (directory_files_internal_unwind): Now static.
5330
f14b7e14
PE
5331 * fileio.c (file_name_as_directory, directory_file_name):
5332 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5333 Now static.
2893f146
PE
5334 (file_name_as_directory): Use const pointers when appropriate.
5335 (Fexpand_file_name): Likewise. In particular, newdir might
5336 point at constant storage, so make it a const pointer.
fd4ead52 5337 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5338 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5339 signedness issues.
f839df0c
PE
5340 (Fset_file_times, Finsert_file_contents, auto_save_error):
5341 Rename locals to avoid shadowing.
f14b7e14 5342
5716756e 5343 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5344 (Ftry_completion, Fall_completions): Rename or remove locals
5345 to avoid shadowing.
5716756e 5346
b4c3046a
PE
5347 * marker.c (bytepos_to_charpos): Remove; unused.
5348
b45db522
PE
5349 * lisp.h (verify_bytepos, count_markers): New decls,
5350 so that gcc does not warn that these functions aren't declared.
5351
85876d07
PE
5352 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5353 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5354 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5355 (copy_text): Remove unused local var.
85876d07 5356
03d78a21 5357 * filelock.c (within_one_second): Now static.
b3dd38ab 5358 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5359
5df8f01b
PE
5360 * buffer.c (fix_overlays_before): Mark locals as initialized.
5361 (fix_start_end_in_overlays): Likewise. This function should be
5362 simplified by using pointers-to-pointers, but that's a different
5363 matter.
b1d876f1 5364 (switch_to_buffer_1): Now static.
8f54f30a
PE
5365 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5366 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5367
a70072c9 5368 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5369 Fix pointer signedness issue.
edced198
PE
5370 (sys_subshell): Mark local as volatile if checking for lint,
5371 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5372 (MAXPATHLEN): Define only if needed.
a70072c9 5373
a0977c44
PE
5374 * process.c (serial_open, serial_configure): Move decls from here ...
5375 * systty.h: ... to here, so that they can be checked.
5376
a884fdcc
PE
5377 * fns.c (get_random, seed_random): Move extern decls from here ...
5378 * lisp.h: ... to here, so that they can be checked.
5379
604efe86 5380 * sysdep.c (reset_io): Now static.
b8950c94 5381 (wait_for_termination_signal): Remove; unused.
604efe86 5382
38fc62d9
PE
5383 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5384 (copy_keymap_item, append_key, push_text_char_description):
5385 Now static.
1004a21a 5386 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5387 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5388 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5389 (describe_map_tree):
5390 Rename locals to avoid shadowing.
38fc62d9 5391
2f2650da
PE
5392 * keyboard.c: Declare functions static if they are not used elsewhere.
5393 (echo_char, echo_dash, cmd_error, top_level_2):
5394 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5395 (read_char, kbd_buffer_get_event, make_lispy_position):
5396 (make_lispy_event, make_lispy_movement, apply_modifiers):
5397 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5398 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5399 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5400 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5401 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5402
a053e86c 5403 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5404 (mark_kboards): Move decl here ...
5405 * alloc.c (mark_kboards): ... from here.
a053e86c 5406
4752793e
PE
5407 * lisp.h (force_auto_save_soon): New decl.
5408
74f10ca7 5409 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5410 (DEFINE_DUMMY_FUNCTION): New macro.
5411 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5412 Use it.
c03cd23f
PE
5413 (main): Add casts to avoid warnings
5414 if GCC considers string literals to be constants.
74f10ca7 5415
022e70d4
PE
5416 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5417
59d6fe83
PE
5418 * dbusbind.c: Pointer signedness fixes.
5419 (xd_signature, xd_append_arg, xd_initialize):
5420 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5421 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5422 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5423 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5424
78320123
PE
5425 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5426 if GCC considers string literals to be constants.
49cebcca 5427 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5428
35ac2a97
SM
54292011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5430
fb103ca9
SM
5431 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5432 (print_preprocess, print_object): New macro to fix last change.
5433
35ac2a97
SM
5434 * print.c (print_preprocess): Don't forget font objects.
5435
62973b41
JB
54362011-03-16 Juanma Barranquero <lekktu@gmail.com>
5437
5438 * emacs.c (USAGE3): Doc fixes.
5439
0e48bb22
AS
54402011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5441
5442 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5443 structure.
5444
7684e57b
JB
54452011-03-14 Juanma Barranquero <lekktu@gmail.com>
5446
5447 * lisp.h (VWindow_system, Qfile_name_history):
5448 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5449 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5450 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5451
5452 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5453 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5454
5455 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5456 * w32console.c (detect_input_pending, read_input_pending)
5457 (encode_terminal_code):
5458 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5459 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5460 (w32_system_caret_y, Qfile_name_history):
5461 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5462 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5463 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5464 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5465 * w32proc.c (Qlocal, report_file_error):
5466 * w32term.c (Vwindow_system, updating_frame):
5467 * w32uniscribe.c (initialized, uniscribe_font_driver):
5468 Remove unneeded extern declarations.
5469
2aa46d6c
CY
54702011-03-14 Chong Yidong <cyd@stupidchicken.com>
5471
c96bbc66 5472 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5473
cffc6f3b
CY
54742011-03-13 Chong Yidong <cyd@stupidchicken.com>
5475
5476 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5477 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5478 These macros can no longer be used for assignment.
5479
44f230aa
SM
5480 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5481 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5482 (record_buffer_markers, fetch_buffer_markers): New functions for
5483 recording and fetching special buffer markers.
5484 (set_buffer_internal_1, set_buffer_temp): Use them.
5485
5486 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5487
5488 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5489
5490 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5491 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5492
5493 * xdisp.c (hscroll_window_tree):
5494 (reconsider_clip_changes): Use PT instead of BUF_PT.
5495
d251f04b
EZ
54962011-03-13 Eli Zaretskii <eliz@gnu.org>
5497
5498 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5499 $(EMACS_ROOT)/lib/intprops.h.
5500
f0c77cd1
PE
55012011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5502
3eca4629
PE
5503 Fix more problems found by GCC 4.5.2's static checks.
5504
7c86ee98
PE
5505 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5506 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5507 (xg_free_frame_widgets): Make it clear that a local variable is
5508 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5509 (gdk_window_get_screen): Make it clear that this macro is needed
5510 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5511 (int_gtk_range_get_value): New function, which avoids a diagnostic
5512 from gcc -Wbad-function-cast.
5513 (xg_set_toolkit_scroll_bar_thumb): Use it.
5514 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5515 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5516 (get_utf8_string, xg_get_file_with_chooser):
5517 Rename locals to avoid shadowing.
5518 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5519
41729b81
PE
5520 * xgselect.c (xg_select): Remove unused var.
5521
f0c77cd1
PE
5522 * image.c (four_corners_best): Mark locals as initialized.
5523 (gif_load): Initialize transparent_p to zero (Bug#8238).
5524 Mark another local as initialized.
ec6cf4c6 5525 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5526
ce0ad53d 5527 * image.c (clear_image_cache): Now static.
d5d5a617 5528 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5529 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5530 (x_edge_detection): Remove unnecessary cast that
5531 gcc -Wbad-function-cast diagnoses.
2037898d 5532 (gif_load): Fix pointer signedness.
6ae141d6
PE
5533 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5534 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5535
33383987 55362011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5537
d32df629
PE
5538 Improve quality of tests for time stamp overflow.
5539 For example, without this patch (encode-time 0 0 0 1 1
5540 1152921504606846976) returns the obviously-bogus value (-948597
5541 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5542 reports time overflow. See
5543 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5544 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5545 * editfns.c: Include limits.h and intprops.h.
5546 (TIME_T_MIN, TIME_T_MAX): New macros.
5547 (time_overflow): Move earlier, to before first use.
5548 (hi_time, lo_time): New functions, for an accurate test for
5549 out-of-range times.
5550 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5551 (Fget_internal_run_time): Don't assume time_t fits in int.
5552 (make_time): Use list2 instead of Fcons twice.
5553 (Fdecode_time): More accurate test for out-of-range times.
5554 (check_tm_member): New function.
5555 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5556 (lisp_time_argument): Don't rely on undefined left-shift and
5557 right-shift behavior when checking for time stamp overflow.
8be6f318 5558
fe31d94c
PE
5559 * editfns.c (time_overflow): New function, refactoring common code.
5560 (Fformat_time_string, Fdecode_time, Fencode_time):
5561 (Fcurrent_time_string): Use it.
5562
8be6f318
PE
5563 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5564 * dired.c (make_time): Move to ...
5565 * editfns.c (make_time): ... here.
5566 * systime.h: Note the move.
5567
09d9db2c 55682011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5569
126bc0dc
YM
5570 * fringe.c (update_window_fringes): Remove unused variables.
5571
c47cbdfd
YM
5572 * unexmacosx.c (copy_data_segment): Also copy __got section.
5573 (Bug#8223)
5574
7ac80be9
EZ
55752011-03-12 Eli Zaretskii <eliz@gnu.org>
5576
c96bbc66 5577 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5578 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5579 Constify `char *' arguments and their references according to
5580 prototypes in tparam.h.
5581
ecb0f94d 5582 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5583
7ac80be9
EZ
5584 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5585 Adapt all references accordingly.
5586
5587 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5588
ef1fd07e
TT
55892011-03-11 Tom Tromey <tromey@redhat.com>
5590
5591 * buffer.c (syms_of_buffer): Remove obsolete comment.
5592
7ef4b50c
EZ
55932011-03-11 Eli Zaretskii <eliz@gnu.org>
5594
5595 * termhooks.h (encode_terminal_code): Declare prototype.
5596
5597 * msdos.c (encode_terminal_code): Don't declare prototype.
5598
5599 * term.c (encode_terminal_code): Now external again, used by
5600 w32console.c and msdos.c.
5601
44f230aa
SM
5602 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5603 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5604
4b1ec863 56052011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5606
1714f52b 5607 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5608
4b1ec863
PE
5609 * fringe.c (update_window_fringes): Mark locals as initialized
5610 (Bug#8227).
5611 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5612
524c7aa6
PE
5613 * alloc.c (mark_fringe_data): Move decl from here ...
5614 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5615 to check its interface.
5616 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5617
a5c0af81 5618 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5619 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5620 (fontset_font): Mark local as initialized.
a9a06e0b 5621 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5622
b4716021
PE
5623 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5624
811e9bac 5625 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5626 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5627 (x_own_selection, Fx_disown_selection_internal): Rename locals
5628 to avoid shadowing.
5629 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5630
7e3ab302
PE
5631 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5632 so that the caller can use some name other than gcpro1.
5633 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5634 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5635 (Fx_backspace_delete_keys_p):
5636 Use them to avoid shadowing, and rename vars to avoid shadowing.
5637 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5638 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5639 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5640 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5641 Remove unused locals.
7e3ab302
PE
5642 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5643 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5644 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5645 macros.
f78faa98 5646
e2b13473
PE
5647 * xterm.h (x_mouse_leave): New decl.
5648
77f23912
PE
5649 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5650 Remove unused functions.
cdf4ba58
PE
5651 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5652 (x_calc_absolute_position): Now static.
7411c686 5653 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5654 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5655 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5656 unless they are used.
38d0b34a
PE
5657 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5658 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5659 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5660 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5661 (x_error_catcher, x_connection_closed, x_error_handler):
5662 (x_error_quitter, xembed_send_message, x_iconify_frame):
5663 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5664 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5665 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5666
44f230aa
SM
5667 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5668 Rename or move locals to avoid shadowing.
6b463e58 5669 (tty_defined_color, merge_face_heights): Now static.
5967d051 5670 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5671 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5672 does not deduce is never used uninitialized.
73719eba
PE
5673 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5674 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5675
426994c3 5676 * terminal.c (store_terminal_param): Now static.
5489860b 5677
032f1620 5678 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5679 (set_frame_menubar): Remove unused local.
d4323972 5680 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5681 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5682 since they might point to immutable storage.
281585b0
PE
5683 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5684 since it's unused otherwise.
032f1620 5685
367c19e5 5686 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5687 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5688 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5689 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5690 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5691 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5692 does not deduce are never used uninitialized.
70739cbe 5693
07b48fa9
PE
5694 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5695
8868a238 5696 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5697 * window.c (window_loop, size_window):
5698 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5699
7e5cf297 5700 * window.c (display_buffer): Now static.
d6550a9f
PE
5701 (size_window): Mark variables that gcc -Wuninitialized
5702 does not deduce are never used uninitialized.
a586633d
PE
5703 * window.h (check_all_windows): New decl, to forestall
5704 gcc -Wmissing-prototypes diagnostic.
5b555da1 5705 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5706
f6095868
PE
5707 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5708 shadowing.
5709 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5710 Include <limits.h>.
5711 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5712 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5713 (load_charset_map): Mark variables that gcc -Wuninitialized
5714 does not deduce are never used uninitialized.
53df7c11 5715 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5716
f38b440c
PE
5717 * coding.c (coding_set_source, coding_set_destination):
5718 Use "else { /* comment */ }" rather than "else /* comment */;"
5719 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5720 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5721 a block, when the outer 'i' will do.
5722 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5723 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5724 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5725 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5726 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5727 Rename locals to avoid shadowing.
5728 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5729 * coding.c (emacs_mule_char, encode_invocation_designation):
5730 Now static, since they're not used elsewhere.
413bb2db 5731 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5732 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5733 (decode_coding_emacs_mule): Mark variables that gcc
5734 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5735 (detect_coding_iso_2022): Initialize a local variable that might
5736 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5737 this initialization is needed. (Bug#8211)
5f58e762
PE
5738 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5739 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5740 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5741 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5742 Remove unused macros.
f38b440c 5743
232b38b9 5744 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5745 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5746 * character.c (string_count_byte8): Likewise.
232b38b9 5747
fb90da1b
PE
5748 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5749 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5750
fb93dbc2
PE
5751 * chartab.c (copy_sub_char_table): Now static, since it's not used
5752 elsewhere.
5c156ace
PE
5753 (sub_char_table_ref_and_range, char_table_ref_and_range):
5754 Rename locals to avoid shadowing.
bbcd0949 5755 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5756
7d3b3862 5757 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5758 (BIDI_BOB): Remove unused macro.
7d3b3862 5759
6be7d3da
PE
5760 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5761 deduce are never used uninitialized.
c2ed9c8b 5762 * term.c (encode_terminal_code): Likewise.
6be7d3da 5763
75f8807f 5764 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5765
50938595
PE
5766 * tparam.h: New file.
5767 * term.c, tparam.h: Include it.
5768 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5769 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5770 Move these decls to tparam.h, and make them agree with what
5771 is actually in tparam.c. The previous trick of using incompatible
5772 decls in different modules does not conform to the C standard.
5773 All callers of tparam changed to use tparam's actual API.
5774 * tparam.c (tparam1, tparam, tgoto):
5775 Use const pointers where appropriate.
5776
fbceeba2
PE
5777 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5778 * cm.h (struct cm): Likewise.
5779 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5780 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5781 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5782 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5783 (turn_on_face, init_tty): Likewise.
5784 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5785
7f3f1250
PE
5786 * term.c (term_mouse_position): Rename local to avoid shadowing.
5787
e6ca6543
PE
5788 * alloc.c (mark_ttys): Move decl from here ...
5789 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5790
c40f8d15
AS
57912011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5792
5793 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5794
cfe0661d
JB
57952011-03-09 Juanma Barranquero <lekktu@gmail.com>
5796
5797 * search.c (compile_pattern_1): Remove argument regp, unused since
5798 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5799 (compile_pattern): Don't pass it.
5800
0afb4571
J
58012011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5802
5803 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5804 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5805 for ! HAVE_GTK3.
5806 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5807
5808 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5809
5810 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5811 gdk_window_get_screen, gdk_window_get_geometry,
5812 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5813 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5814 (xg_get_pixbuf_from_pixmap): New function.
5815 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5816 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5817 Call xg_get_pixbuf_from_pixmap instead of
5818 gdk_pixbuf_get_from_drawable.
5819 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5820 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5821 (xg_check_special_colors): Use GtkStyleContext and its functions
5822 for HAVE_GTK3.
5823 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5824 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5825 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5826 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5827 Call gtk_widget_get_preferred_size.
0afb4571
J
5828 (xg_frame_resized): gdk_window_get_geometry only takes 5
5829 parameters.
44f230aa
SM
5830 (xg_win_to_widget, xg_event_is_for_menubar):
5831 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5832 (xg_set_widget_bg): New function.
5833 (delete_cb): New function.
895009e1 5834 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5835 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5836 (xg_set_background_color): Call xg_set_widget_bg.
5837 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5838 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5839 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5840 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5841 if ! HAVE_GTK3.
5842 (update_frame_tool_bar): Call gtk_widget_hide.
5843 (xg_initialize): Use GDK_KEY_g.
5844
5845 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5846 if ! HAVE_GTK3
5847 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5848
5849 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5850 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5851 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5852
1c2cc4ef
JB
58532011-03-08 Juanma Barranquero <lekktu@gmail.com>
5854
5855 * w32xfns.c (select_palette): Check success of RealizePalette against
5856 GDI_ERROR, not zero.
5857
33383987 5858See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5859
5860;; Local Variables:
5861;; coding: utf-8
aac0c6e3
MR
5862;; End:
5863
33383987 5864 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5865
5866 This file is part of GNU Emacs.
5867
5868 GNU Emacs is free software: you can redistribute it and/or modify
5869 it under the terms of the GNU General Public License as published by
5870 the Free Software Foundation, either version 3 of the License, or
5871 (at your option) any later version.
5872
5873 GNU Emacs is distributed in the hope that it will be useful,
5874 but WITHOUT ANY WARRANTY; without even the implied warranty of
5875 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5876 GNU General Public License for more details.
5877
5878 You should have received a copy of the GNU General Public License
5879 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.