* lisp/progmodes/js.el: Add notes in comments.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e8d32c7e
SM
12012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * fileio.c, character.h: Minor style tweaks.
4
4b2addb7
DA
52012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
6
7 * window.h (clip_changed): Remove useless declaration.
8
584461b2
JB
92012-05-22 Juanma Barranquero <lekktu@gmail.com>
10
11 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
12 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
13
34374650
PE
142012-05-22 Paul Eggert <eggert@cs.ucla.edu>
15
16 Remove src/m/*.
17 This directory predates autoconf and is no longer needed nowadays.
18 Move its few remaining bits of functionality to where they're needed.
19 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
20 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
21 * m/template.h: Remove.
22 * Makefile.in (M_FILE): Remove. All uses removed.
23 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
24 * lisp.h (USE_LSB_TAG):
25 * mem-limits.h (EXCEEDS_LISP_PTR):
26 Use VAL_MAX, not VALBITS, in #if.
27 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
28 (EMACS_UINT): Define unconditionally now.
29 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
30 (BITS_PER_EMACS_INT): New constants, replacing
31 what used to be in config.h, but not useful in #if.
32 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
33 define them any more.
34 (VAL_MAX): New macro.
35 (VALMASK): Use it.
36 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
37 BITS_PER_EMACS_INT, in #if.
38 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
39 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
40 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
41 * s/ms-w32.h (DATA_START):
42 Move here from removed file m/intel386.h.
43 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
44 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
45
261cb4bb
PE
462012-05-21 Paul Eggert <eggert@cs.ucla.edu>
47
48 Assume C89 or later.
49 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
50 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
51 (xrealloc):
52 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
53 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
54 * textprop.c, tparam.c (NULL): Remove.
55 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
56 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
57 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
58 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
59 * xterm.c (input_signal_count): Assume volatile works.
60
ff23cd9f
KB
612012-05-21 Ken Brown <kbrown@cornell.edu>
62
63 * xgselect.c (xg_select): Fix first argument in call to 'select'
64 (bug#11508).
65
1b170bc6
KB
662012-05-20 Ken Brown <kbrown@cornell.edu>
67
68 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 69 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 70
b2f4d39f
KB
712012-05-19 Ken Brown <kbrown@cornell.edu>
72
73 * xfns.c (x_in_use): Remove `static' qualifier.
74 * xterm.h (x_in_use): Declare.
75 * xgselect.c: Include xterm.h.
76 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
77 and `display_arg' (bug#9754).
78
003fdae2
PE
792012-05-19 Paul Eggert <eggert@cs.ucla.edu>
80
9232a6d9
PE
81 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
82
003fdae2
PE
83 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
84 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
85
784b56e2
EZ
862012-05-18 Eli Zaretskii <eliz@gnu.org>
87
88 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
89
90 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
91 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
92
93 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
94 reference to image_cache->refcount.
95 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
96
a0a79cde
JL
972012-05-17 Juri Linkov <juri@jurta.org>
98
99 * search.c (Fword_search_regexp, Fword_search_backward)
100 (Fword_search_forward, Fword_search_backward_lax)
101 (Fword_search_forward_lax): Move functions to isearch.el
102 (bug#10145, bug#11381).
103
b0572523
PE
1042012-05-16 Paul Eggert <eggert@cs.ucla.edu>
105
106 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
107
9660f5fc
SM
1082012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
109
110 * lread.c (init_obarray): Declare Qt and Qnil as special.
111
4374de83
GM
1122012-05-14 Glenn Morris <rgm@gnu.org>
113
114 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 115 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 116
dc44c39a
PE
1172012-05-14 Paul Eggert <eggert@cs.ucla.edu>
118
078c97cb
PE
119 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
120
dc44c39a
PE
121 * unexaix.c: Port to more-recent AIX compilers.
122 (report_error, report_error_1, make_hdr, copy_sym)
123 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
124 Make arguments const char *, not char *, to avoid violations of C
125 standard and to fix some AIX warnings reported by Gilles Pion.
126
e18afed7 1272012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
128
129 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
130 already have overlays loaded.
131 (handle_single_display_spec): Before returning without displaying
132 fringe bitmap, synchronize the bidi iterator with the main display
133 iterator, by calling iterate_out_of_display_property.
134 (iterate_out_of_display_property): Detect buffer iteration by
135 testing that it->string is a Lisp string.
136 (get_next_display_element): When the current object is exhausted,
137 and there's something on it->stack, call set_iterator_to_next to
138 proceed with what's on the stack, instead of returning zero.
139 (set_iterator_to_next): If called at the end of a Lisp string,
140 proceed to consider_string_end without incrementing string
141 position. Don't increment display vector index past the end of
142 the display vector. (Bug#11417)
c8fb9dc6
EZ
143 (pos_visible_p): Don't report a position visible when move_it_to
144 stopped at the last line of window, which happens to be scanned
145 backwards by the bidi iteration. (Bug#11464)
ac268e67 146
e18afed7 1472012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
148
149 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
150 and right-margin display specs even if the spec is invalid or we
151 are on a TTY, and thus unable to display on the fringes. That's
152 because the text with the property will not be displayed anyway,
153 so we need to signal to the caller that this is a "replacing"
154 display spec. This fixes display when the spec is invalid or we
155 are on a TTY.
156
e18afed7 1572012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
158
159 * unexaix.c (make_hdr): Fix typo in prototype.
160 This bug broke the build on AIX. Problem reported by Gilles Pion.
161
9d0a235a
MA
1622012-05-14 Michael Albinus <michael.albinus@gmx.de>
163
164 * keyboard.c (kbd_buffer_get_event): Read special events also in
165 batch mode. (Bug#11415)
166
9e6b06ed
GM
1672012-05-12 Glenn Morris <rgm@gnu.org>
168
169 * ns.mk: Update for ns_appbindir no longer having trailing "/".
170
c1a1d7a3
EZ
1712012-05-12 Eli Zaretskii <eliz@gnu.org>
172
173 * lisp.mk (lisp): Add newcomment.elc.
174
3fe7cdc8
GM
1752012-05-12 Glenn Morris <rgm@gnu.org>
176
177 * Makefile.in (MKDIR_P): New, set by configure.
178 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
179
53f7d2c0
PE
1802012-05-11 Paul Eggert <eggert@cs.ucla.edu>
181
182 Remove unused function hourglass_started.
183 * dispextern.h (hourglass_started):
184 * w32fns.c (hourglass_started):
185 * xdisp.c (hourglass_started): Remove.
186
75aafb17
JB
1872012-05-10 Juanma Barranquero <lekktu@gmail.com>
188
189 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
190 Update dependencies.
191
12959e8e
PE
1922012-05-10 Paul Eggert <eggert@cs.ucla.edu>
193
97107e2e
PE
194 * xgselect.c (xg_select): Put maxfds+1 into a var.
195 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
196
12959e8e
PE
197 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
198
836d29b3
DA
1992012-05-10 Dave Abrahams <dave@boostpro.com>
200
201 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
202 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
203
5cb67954
MA
2042012-05-09 Michael Albinus <michael.albinus@gmx.de>
205
206 * dbusbind.c (xd_registered_buses): New internal Lisp object.
207 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
208 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
209 Initialize xd_registered_buses.
210
3478ec45
PE
2112012-05-09 Paul Eggert <eggert@cs.ucla.edu>
212
b263a6b0
PE
213 Untag more efficiently if USE_LSB_TAG.
214 This is based on a proposal by YAMAMOTO Mitsuharu in
215 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
216 For an admittedly artificial (nth 8000 longlist) benchmark on
217 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
218 Emacs's overall text size by 1%.
219 * lisp.h (XUNTAG): New macro.
220 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
221 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
222 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
223 * eval.c (Fautoload):
224 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
225 * frame.h (XFRAME): Use XUNTAG.
226
3478ec45
PE
227 Port recent dbusbind.c changes to 32-bit --with-wide-int.
228 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
229 Remove unportable assumptions about print widths of types like
230 dbus_uint32_t.
231 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
232 intptr_t when converting between pointer and integer, to avoid GCC
233 warnings about wrong width.
234
666b903b 2352012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
236
237 * w32proc.c (new_child): Force Windows to reserve only 64KB of
238 stack for each reader_thread, instead of defaulting to 8MB
239 determined by the linker. This avoids failures in creating
240 subprocesses on Windows 7, see the discussion in this thread:
241 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
242
b120cc17
JC
2432012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
244
245 Fix up display of the *Minibuf-0* buffer in the mini window.
246 * keyboard.c (read_char): Don't clear the echo area if there's no
247 message to clear.
248 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 249 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 250
9a4b36f8
MA
2512012-05-07 Michael Albinus <michael.albinus@gmx.de>
252
253 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
254 batch mode.
255
e5f9458f
CY
2562012-05-06 Chong Yidong <cyd@gnu.org>
257
258 * lisp.mk (lisp): Update.
259
eceeb5fc 2602012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
261
262 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
263
71873e2b
SM
2642012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
265
266 * data.c (PUT_ERROR): New macro.
267 (syms_of_data): Use it. Add new error type `user-error'.
268 * undo.c (user_error): New function.
269 (Fprimitive_undo): Use it.
270 * print.c (print_error_message): Adjust print style for `user-error'.
271 * keyboard.c (user_error): New function.
272 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
273
ab0fa4e4
PE
2742012-05-03 Paul Eggert <eggert@cs.ucla.edu>
275
276 Do not limit current-time-string to years 1000..9999.
277 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
278 (Fcurrent_time_string): Support any year that is supported by the
279 underlying localtime representation. Don't use asctime, as it
280 has undefined behavior for years outside the range -999..9999.
281
7ed806a7
PE
2822012-05-02 Paul Eggert <eggert@cs.ucla.edu>
283
284 Fix race conditions involving setenv, gmtime, localtime, asctime.
285 Without this fix, interrupts could mess up code that uses these
286 nonreentrant functions, since setting TZ invalidates existing
287 tm_zone or tzname values, and since most of these functions return
288 pointers to static storage.
289 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
290 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
291 Grow the critical sections to include not just invoking
292 localtime/gmtime, but also accessing these functions' results
293 including their tm_zone values if any, and any related TZ setting.
294 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
295 so that the struct tm is saved in the critical section.
296 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
297 motivated by the fact that memory allocation needs to be outside
298 the critical section.
299
0c16dfed
DA
3002012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
301
302 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
303 with RESET_INTERVAL.
304
305 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
306 Remove duplicated buffer name initialization.
307
3f83ace8
JM
3082012-05-02 Jim Meyering <jim@meyering.net>
309
310 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
311
c7b8541e
JM
312 * xfns.c (x_window): Use xstrdup (Bug#11375).
313
90207a15 3142012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
315
316 * xdisp.c (pos_visible_p): If already at a newline from the
317 display string before the 'while' loop, don't walk back the glyphs
318 from it3.glyph_row. Solves assertion violation when the display
319 string begins with a newline (egg.el). (Bug#11367)
320
b593d6a9
AH
3212012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
322
323 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
324 Move to simple.el.
325
4737362e
GM
3262012-05-01 Glenn Morris <rgm@gnu.org>
327
99cf43f9
GM
328 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
329 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
330 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
331 All were removed before 23.1.
332
9311dcff
GM
333 * dispnew.c: Remove HAVE_LIBNCURSES test;
334 it is always true on relevant platforms.
335
4d5c6349
GM
336 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
337 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
338
4737362e
GM
339 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
340
74dd3a6b
AS
3412012-04-30 Andreas Schwab <schwab@linux-m68k.org>
342
343 * .gdbinit (xpr): Remove checks for no longer existing misc types.
344 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
345 Remove.
346
13c379ee
PE
3472012-04-28 Paul Eggert <eggert@cs.ucla.edu>
348
349 Do not avoid creating empty evaporating overlays (Bug#9642).
350 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
351 That is, do not delete an evaporating overlay if it becomes
352 empty after its bounds are adjusted to fit within its buffer.
353 This fix caused other problems, and I'm reverting it until we get
354 to the bottom of them.
355
a8e7d6d7 3562012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
357
358 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
359
a8e7d6d7 3602012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
361
362 * xdisp.c (pos_visible_p): If the window start position is beyond
363 ZV, start the display from buffer beginning. Prevents assertion
364 violation in init_iterator when the minibuffer window is scrolled
365 via the scroll bar.
366
367 * window.c (window_scroll_pixel_based): Likewise.
368
a8e7d6d7 3692012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
370
371 * keymap.c (where_is_internal): Doc fix (Bug#10872).
372
a8e7d6d7 3732012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
374
375 * fileio.c (Fcopy_file, Fset_file_selinux_context):
376 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
377
a8e7d6d7 3782012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 379
b593d6a9
AH
380 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
381 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 382
1c6900d9
EZ
3832012-04-26 Eli Zaretskii <eliz@gnu.org>
384
4c3fa1d9
EZ
385 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
386 display element, check also the underlying string or buffer
387 character. (Bug#11341)
388
1c6900d9
EZ
389 * w32menu.c: Include w32heap.h.
390 (add_menu_item): If the call to AppendMenuW (via
391 unicode_append_menu) fails, disable Unicode menus only if we are
392 running on Windows 9X/Me.
393
42bf8205
AS
3942012-04-24 Andreas Schwab <schwab@linux-m68k.org>
395
396 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
397 (xgetint): Add missing shift for LSB tags.
398
b1bac16e
MR
3992012-04-24 Martin Rudalics <rudalics@gmx.at>
400
401 * keyboard.c (read_char): Don't wipe echo area for select window
402 events: These might get delayed via `mouse-autoselect-window'
403 (Bug#11304).
404
d69621cc
JB
4052012-04-24 Juanma Barranquero <lekktu@gmail.com>
406
407 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
408 manipulation of :loaded-from data.
409
02fd101b
JB
4102012-04-23 Juanma Barranquero <lekktu@gmail.com>
411
412 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
413 now a cons (bug#11311).
414
888bec30
PE
4152012-04-23 Paul Eggert <eggert@cs.ucla.edu>
416
89a438bd
PE
417 Do not create empty overlays with the evaporate property (Bug#9642).
418 * buffer.c (Fmove_overlay): Delete an evaporating overlay
419 if it becomes empty after its bounds are adjusted to fit within
420 its buffer. Without this fix, in a nonempty buffer (let ((o
421 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
422 yields an empty overlay that has the evaporate property, which is
423 not supposed to happen.
424
1068fe4d
PE
425 Fix minor GTK3 problems found by static checking.
426 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
427 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
428 (struct _EmacsFixedClass, emacs_fixed_get_type):
429 Move decls here from emacsgtkfixed.h, since they needn't be public.
430 (emacs_fixed_get_type): Now static.
431 (emacs_fixed_class_init): Omit unused local.
432 (emacs_fixed_child_type): Remove; unused.
433 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
434 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
435 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
436 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
437 (EMACS_FIXED_GET_CLASS): Remove; unused.
438 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
439
888bec30
PE
440 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
441 Problem reported by Juanma Barranquero for Windows -Wunused-function.
442
de85e130
PE
4432012-04-22 Paul Eggert <eggert@cs.ucla.edu>
444
d0baac98 445 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 446 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
447 (__malloc_size_t, __malloc_ptrdiff_t):
448 Remove. All uses removed, replaced by the definiens if needed,
449 since we can assume C89 or better now.
450 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
451 (protect_malloc_state, align, get_contiguous_space)
452 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
453 (malloc_atfork_handler_child, malloc_enable_thread)
454 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
455 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
456 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
457 (special_realloc, _realloc_internal_nolock, _realloc_internal)
458 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
459 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
460 Define using prototypes, not old style.
461 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
462 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
463 (align): Don't assume that signed integer overflow wraps around.
464 Omit unused local var.
465 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
466 (_free_internal_nolock, memalign, mallochook, reallochook):
467 Omit no-longer-needed casts.
468 (valloc): Use getpagesize, not __getpagesize.
469 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
470 (struct hdr): The 'magic' member is now size_t, not unsigned long.
471
de85e130
PE
472 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
473
dcbf5805
MA
4742012-04-22 Michael Albinus <michael.albinus@gmx.de>
475
476 Move functions from C to Lisp. Make non-blocking method calls
477 the default. Implement further D-Bus standard interfaces.
478
479 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
480 (QCdbus_request_name_allow_replacement)
481 (QCdbus_request_name_replace_existing)
482 (QCdbus_request_name_do_not_queue)
483 (QCdbus_request_name_reply_primary_owner)
484 (QCdbus_request_name_reply_in_queue)
485 (QCdbus_request_name_reply_exists)
486 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
487 (QCdbus_registered_serial, QCdbus_registered_method)
488 (QCdbus_registered_signal): New Lisp objects.
489 (XD_DEBUG_MESSAGE): Use sizeof.
490 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
491 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
492 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
493 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
494 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
495 (xd_signature, xd_append_arg): Allow float for integer types.
496 (xd_get_connection_references): New function.
b593d6a9
AH
497 (xd_get_connection_address): Rename from xd_initialize.
498 Return cached address.
dcbf5805
MA
499 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
500 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
501 level.
502 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 503 Return number of refcounts.
dcbf5805
MA
504 (Fdbus_get_unique_name): Make stronger parameter check.
505 (Fdbus_message_internal): New defun.
506 (Fdbus_call_method, Fdbus_call_method_asynchronously)
507 (Fdbus_method_return_internal, Fdbus_method_error_internal)
508 (Fdbus_send_signal, Fdbus_register_service)
509 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
510 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
511 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
512 (Vdbus_compiled_version, Vdbus_runtime_version)
513 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
514 (Vdbus_message_type_method_return, Vdbus_message_type_error)
515 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
516 (Vdbus_registered_buses, Vdbus_registered_objects_table):
517 Adapt docstring.
dcbf5805 518
52828e02
PE
5192012-04-22 Paul Eggert <eggert@cs.ucla.edu>
520
da05bc4c
PE
521 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
522 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
523 Do not assume ptrdiff_t is the same width as 'int'.
524
52828e02
PE
525 * alloc.c: Handle unusual debugging option combinations.
526 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
527 since the two debugging options are incompatible.
528 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
529 is defined.
530 (mem_init, mem_insert, mem_insert_fixup):
531 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
532 (NEED_MEM_INSERT): Remove; no longer needed.
533
f01769f9
LL
5342012-04-22 Leo Liu <sdl.web@gmail.com>
535
536 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
537
5790543d
PE
5382012-04-22 Paul Eggert <eggert@cs.ucla.edu>
539
540 * sysdep.c [__FreeBSD__]: Minor cleanups.
541 (list_system_processes, system_process_attributes) [__FreeBSD__]:
542 Use Emacs indenting style more consistently. Avoid some casts.
543 Use 'double' consistently rather than mixing 'float' and 'double'.
544
b91b7e4d
EW
5452012-04-21 Eduard Wiebe <usenet@pusto.de>
546
b593d6a9
AH
547 * sysdep.c (list_system_processes, system_process_attributes):
548 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 549
6114eb15
AS
5502012-04-21 Andreas Schwab <schwab@linux-m68k.org>
551
552 * lisp.mk (lisp): Update.
553
2f38dff7
PE
5542012-04-20 Paul Eggert <eggert@cs.ucla.edu>
555
556 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
557 It is never used otherwise.
558
4ae29f89
SM
5592012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
560
561 * print.c (print_preprocess): Only check print_depth if print-circle
562 is nil.
563 (print_object): Check for cycles even when print-circle is nil and
564 print-gensym is t, but only check print_depth if print-circle is nil.
565
f30d612a
CY
5662012-04-20 Chong Yidong <cyd@gnu.org>
567
568 * process.c (wait_reading_process_output): If EIO occurs on a pty,
569 set the status to "failed" and ensure that sentinel is run.
570
c07a4c0b 5712012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
572
573 * process.c (Fset_process_inherit_coding_system_flag)
574 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 575 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 576
c07a4c0b 5772012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
578
579 * xdisp.c (string_buffer_position_lim): Limit starting position to
580 BEGV.
581 (set_cursor_from_row): If called for a mode-line or header-line
582 row, return zero immediately.
583 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
584 farther than the first row after the header line, if any.
585 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
586 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
587
c07a4c0b 5882012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 589
4ae29f89
SM
590 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
591 (bug#11238).
ad3a2b41 592
c07a4c0b 5932012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 5942012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
595
596 configure: new option --enable-gcc-warnings (Bug#11207)
597 * Makefile.in (C_WARNINGS_SWITCH): Remove.
598 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
599 (ALL_CFLAGS): Use new macros rather than old.
600 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
601 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
602 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
603 -Wunused-result, -Wunused-variable. This should go away once
604 the Emacs and Gnulib regex code is merged.
605 (xmalloc, xrealloc): Now static.
606
aba027e8
PE
6072012-04-17 Paul Eggert <eggert@cs.ucla.edu>
608
609 * dired.c (Fsystem_groups): Remove unused local.
610
e5a36063
GM
6112012-04-17 Glenn Morris <rgm@gnu.org>
612
613 * dired.c (Fsystem_users): Doc fix.
614
316411f0
DA
6152012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
616
617 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
618 (syms_of_dired): Add them.
619
9426aba4
PE
6202012-04-16 Paul Eggert <eggert@cs.ucla.edu>
621
b62a57be
PE
622 Fix minor alloc.c problems found by static checking.
623 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
624 New extern decls, to avoid calling undeclared functions.
625 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
626 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
627 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
628 (NEED_MEM_INSERT): New macro.
629 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 630 Remove one incorrect comment and fix another.
b62a57be 631
3539f31f
PE
632 Fix minor ralloc.c problems found by static checking.
633 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
634 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
635 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
636 (r_alloc_sbrk): Now static.
637
a041960a
PE
638 Improve ralloc.c interface checking.
639 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
640 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
641 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
642 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
643 [REL_ALLOC]: ... to here, to check interface.
644 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
645 Remove decls. This fixes an "It stinks!".
646
9426aba4
PE
647 * alloc.c (which_symbols): Fix alignment issue / type clash.
648
d55c12ed
AS
6492012-04-15 Andreas Schwab <schwab@linux-m68k.org>
650
651 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
652 (struct Lisp_Misc_Any): Likewise.
653 (struct Lisp_Free): Likewise.
654 * alloc.c (union aligned_Lisp_Symbol): Define.
655 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
656 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
657 (union aligned_Lisp_Misc): Define.
658 (MARKER_BLOCK_SIZE, struct marker_block): Use union
659 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 660 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 661
b948ce8b
PE
6622012-04-14 Paul Eggert <eggert@cs.ucla.edu>
663
664 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
665 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
666 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
667 * s/netbsd.h, s/sol2-6.h:
668 Remove definition of GC_MARK_STACK, since the default now works.
669 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
670 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
671 no longer the default.
672 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
673
35dc09a1 6742012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 675
35dc09a1
GM
676 * lread.c (lisp_file_lexically_bound_p):
677 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 678
35dc09a1
GM
6792012-04-14 Eli Zaretskii <eliz@gnu.org>
680
681 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
682 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
683
6842012-04-14 Jan Djärv <jan.h.d@swipnet.se>
685
686 * nsterm.m (constrainFrameRect): Always constrain when there is only
687 one screen (Bug#10962).
688
bcd86815
KB
6892012-04-13 Ken Brown <kbrown@cornell.edu>
690
691 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
692
c25df26e
RT
6932012-04-13 Reuben Thomas <rrt@sc3d.org>
694
695 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
696
0fc59f1e
DC
6972012-04-11 Daniel Colascione <dancol@dancol.org>
698
699 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
700 against is gone. It's better to use vfork now so that when Cygwin
701 gains a new, working vfork, we use it automatically (bug#10398).
702
de8c03dc
SM
7032012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
704
705 * window.c (save_window_save): Obey window-point-insertion-type.
706
2f097256
GM
7072012-04-11 Glenn Morris <rgm@gnu.org>
708
709 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
710
453b951e
SM
7112012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
712
713 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
714
75f1671a 7152012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
716
717 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
718 (force_quit_count): New var.
719 (handle_interrupt): Use it.
720
2a8ce227
JB
7212012-04-10 Juanma Barranquero <lekktu@gmail.com>
722
723 * w32.c (w32_delayed_load): Record the full path of the library
724 being loaded (bug#10424).
725
935396c0
GM
7262012-04-09 Glenn Morris <rgm@gnu.org>
727
05920a43
GM
728 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
729 not just in the obarray, before snarfing them. (Bug#11036)
730
935396c0
GM
731 * Makefile.in ($(leimdir)/leim-list.el):
732 Pass EMACS rather than BUILT_EMACS.
733
a18ecafa
TZ
7342012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
735
736 * process.c (make_process):
737 * process.h: Add integer `gnutls_handshakes_tried' member to
738 process struct.
739
6bbef4e5
JC
740 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
741 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
742
743 * gnutls.c (gnutls_log_function2i): Convenience log function.
744 (emacs_gnutls_read): Use new log functions,
745 `gnutls_handshakes_tried' process member, and
746 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
747 attempts per process (connection).
748
b4d3bc10
CY
7492012-04-09 Chong Yidong <cyd@gnu.org>
750
751 * eval.c (Fuser_variable_p, user_variable_p_eh)
752 (lisp_indirect_variable): Functions deleted.
753 (Fdefvar): Caller changed.
754
755 * callint.c (Finteractive, Fcall_interactively):
756 * minibuf.c (Fread_variable): Callers changed.
757
70f4d973
EZ
7582012-04-09 Eli Zaretskii <eliz@gnu.org>
759
760 * xdisp.c (set_cursor_from_row): If the display string appears in
761 the buffer at position that is closer to point than the position
762 after the display string, display the cursor on the first glyph of
763 the display string. Fixes cursor display when a 'display' text
764 property immediately follows invisible text. (Bug#11094)
765
cb3c2e3e
PE
7662012-04-09 Paul Eggert <eggert@cs.ucla.edu>
767
768 composite.c: use 'double' consistently
769 * composite.c (get_composition_id): Use 'double' consistently
770 instead of converting 'float' to 'double' and vice versa; this is
771 easier to understand and avoids a GCC warning.
772
fd06db5d
GM
7732012-04-09 Glenn Morris <rgm@gnu.org>
774
50fe702a
GM
775 * Makefile.in: Generate leim-list with bootstrap-emacs, in
776 preparation for dumping it with emacs. (Bug#4789)
777 (leimdir): New variable.
778 ($(leimdir)/leim-list.el): New rule.
779 (emacs$(EXEEXT)): Depend on leim-list.el.
780
fd06db5d
GM
781 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
782 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
783 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
784
55c131ee
AS
7852012-04-08 Andreas Schwab <schwab@linux-m68k.org>
786
787 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
788 proper alignment.
789
9209588f
JB
7902012-04-07 Juanma Barranquero <lekktu@gmail.com>
791
792 * xml.c (init_libxml2_functions) [WINDOWSNT]:
793 Remove unused local variable.
794
e3fb2efb
PE
7952012-04-07 Paul Eggert <eggert@cs.ucla.edu>
796
797 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
798 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
799 (mark_memory): Mark Lisp_Objects only if pointers might hide in
800 objects, as mark_maybe_pointer will catch them otherwise.
801 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
802 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
803
b5385551
PE
8042012-04-07 Paul Eggert <eggert@cs.ucla.edu>
805
806 Fix typo that broke non-Windows builds.
807 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
808
9078ead6
EZ
8092012-04-07 Eli Zaretskii <eliz@gnu.org>
810
811 Support building on MS-Windows with libxml2.
812
813 * makefile.w32-in (OBJ2): Add xml.$(O).
814 (GLOBAL_SOURCES): Add xml.c.
815 ($(BLD)/xml.$(O)): New dependency list.
816
817 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
818 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
819 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
820 [!WINDOWSNT]: New macros.
821 (init_libxml2_functions, libxml2_loaded_p): New functions.
822 (parse_region): Call fn_xmlCheckVersion instead of using the macro
823 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
824 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
825 Calls xmlCleanupParser only if libxml2 was loaded (or statically
826 linked in).
6bbef4e5
JC
827 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
828 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
829 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
830
831 * emacs.c: Don't include libxml/parser.h.
832 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
833 xmlCleanupParser directly.
834
835 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
836
3811fdf3
EZ
8372012-04-07 Eli Zaretskii <eliz@gnu.org>
838
839 * indent.c (Fvertical_motion): If there is a display string at
840 point, use it.vpos to compute how many lines to backtrack after
841 move_it_to point. (Bug#11133)
842
2f8e16b2
EZ
8432012-04-06 Eli Zaretskii <eliz@gnu.org>
844
845 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
846 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
847 about subtle differences between FETCH_CHAR* and STRING_CHAR*
848 macros related to unification of CJK characters. For the details,
849 see the discussion following the message here:
850 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
851
3d439cd1
CY
8522012-04-04 Chong Yidong <cyd@gnu.org>
853
854 * keyboard.c (Vdelayed_warnings_list): Doc fix.
855
8bc53d00
EZ
8562012-04-01 Eli Zaretskii <eliz@gnu.org>
857
858 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
859 instead of alloca. (Bug#11138)
860
3b0512a3
AS
8612012-04-01 Andreas Schwab <schwab@linux-m68k.org>
862
863 * w32menu.c (is_simple_dialog): Properly check lisp types.
864 (Bug#11141)
865
8427ddd2
EZ
8662012-03-31 Eli Zaretskii <eliz@gnu.org>
867
979022ef
EZ
868 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
869 position we get to after a call to move_it_to fails the
870 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
871 only if we wind up in a string from display property. (Bug#11063)
872
a6b1c7cc
EZ
873 * window.c (Fdelete_other_windows_internal): Invalidate the row
874 and column information about mouse highlight, so that redisplay
875 restores it after reallocating the glyph matrices. (Bug#7464)
876
8427ddd2
EZ
877 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
878 string comes from a `display' text property, use the buffer
879 position of that property as if we actually saw that position in
880 the row's glyphs.
697ba24b
EZ
881 (move_it_by_lines): Remove the assertion that
882 "it->current_x == 0 && it->hpos == 0" which can be legitimately
883 violated when there's a before-string at the beginning of a line.
884 (Bug#11063)
8427ddd2 885
65a0a738
EZ
8862012-03-30 Eli Zaretskii <eliz@gnu.org>
887
888 * xdisp.c (append_space_for_newline): If the default face was
889 remapped, use the remapped face for the appended newline.
890 (extend_face_to_end_of_line): Use the remapped default face for
891 extending the face to the end of the line.
892 (display_line): Call extend_face_to_end_of_line when the default
893 face was remapped. (Bug#11068)
894
581355cc
EZ
8952012-03-29 Eli Zaretskii <eliz@gnu.org>
896
897 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
898
e8fc049f
SM
8992012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
900
901 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
902
4fb9a543
GM
9032012-03-27 Glenn Morris <rgm@gnu.org>
904
905 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
906 Doc fixes.
907
679910f1
KH
9082012-03-26 Kenichi Handa <handa@m17n.org>
909
910 * dispextern.h (struct glyph): Fix previous change. Change the
911 bit length of glyphless.ch to 25 (Bug#11082).
912
90d49b7f
CY
9132012-03-26 Chong Yidong <cyd@gnu.org>
914
915 * keyboard.c (Vselection_inhibit_update_commands): New variable.
916 (command_loop_1): Use it; inhibit selection update for
917 handle-select-window too (Bug#8996).
918
f514f6f0
FP
9192012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
920
e8fc049f 921 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 922
bf43fa51
KH
9232012-03-25 Kenichi Handa <handa@m17n.org>
924
925 * dispextern.h (struct glyph): Change the bit length of
926 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
927
8a0c01dd
EZ
9282012-03-24 Eli Zaretskii <eliz@gnu.org>
929
930 * s/ms-w32.h (tzname): Include time.h before redirecting to
931 _tzname. Fixes the MSVC build. (Bug#9960)
932
7d1c3a76
AS
9332012-03-24 Andreas Schwab <schwab@linux-m68k.org>
934
8ed79523
AS
935 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
936 characters.
937
7d1c3a76
AS
938 * xterm.c (XTread_socket): Only modify handling_signal if
939 !SYNC_INPUT. (Bug#11080)
940
e99a9b8b
EZ
9412012-03-23 Eli Zaretskii <eliz@gnu.org>
942
943 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
944 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
945 when fetching a multibyte character consumes more bytes than
946 CHAR_BYTES returns, due to unification of CJK characters in
947 string_char. (Bug#11073)
948
5063c0e1
TN
9492012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
950
951 * process.c (wait_reading_process_output): Handle pty disconnect
952 by refraining from sending oneself a SIGCHLD (bug#10933).
953
9f851fbd
CY
9542012-03-22 Chong Yidong <cyd@gnu.org>
955
956 * dispextern.h (struct it): New member string_from_prefix_prop_p.
957
5063c0e1 958 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
959 Mark string as coming from a prefix property.
960 (handle_face_prop): Use default face for prefix strings (Bug#4281).
961 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
962
fb5b8aca
CY
9632012-03-21 Chong Yidong <cyd@gnu.org>
964
965 * xfaces.c (Vface_remapping_alist): Doc fix.
966
62356a1b
EZ
9672012-03-20 Eli Zaretskii <eliz@gnu.org>
968
969 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
970 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
971 Doc fixes.
62356a1b 972
025de85b
CY
9732012-03-20 Chong Yidong <cyd@gnu.org>
974
975 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
976 to reflect default non-nil value of redisplay-dont-pause.
977
4827f94e
KH
9782012-03-19 Kenichi Handa <handa@m17n.org>
979
980 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
981 it fit in a valid range (Bug#11003).
982
e50a24a2
EZ
9832012-03-18 Eli Zaretskii <eliz@gnu.org>
984
985 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
986 that is not from display property, accept the row as a "cursor
987 row" if one of the string's character has a non-nil `cursor'
988 property. Fixes cursor positioning when there are newlines in
989 overlay strings, e.g. in icomplete.el. (Bug#11035)
990
9af5ed87
PE
9912012-03-12 Paul Eggert <eggert@cs.ucla.edu>
992
993 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
994
d1f55f16
CY
9952012-03-12 Chong Yidong <cyd@gnu.org>
996
997 * eval.c (inhibit_lisp_code): Rename from
998 inhibit_window_configuration_change_hook; move from window.c.
999
1000 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1001 * window.c (run_window_configuration_change_hook)
1002 (syms_of_window): Callers changed.
1003
66c5eebd
CY
10042012-03-11 Chong Yidong <cyd@gnu.org>
1005
413df973
CY
1006 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1007
66c5eebd
CY
1008 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1009
1de11f56
CY
10102012-03-10 Chong Yidong <cyd@gnu.org>
1011
1012 * frame.c (other_visible_frames): Don't assume the selected frame
1013 is visible (Bug#10955).
1014
cae07000
SM
10152012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1016
1017 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1018
89c94350
JD
10192012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1020
1021 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1022 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1023 zero (Bug#10954).
1024
999dd333
GM
10252012-03-03 Glenn Morris <rgm@gnu.org>
1026
01a6dcc8 1027 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 1028
de0100f2
EZ
10292012-03-02 Eli Zaretskii <eliz@gnu.org>
1030
1031 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1032 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
1033 (redisplay_window, next_element_from_string): Fix typos in
1034 comments.
3e441275
EZ
1035 (redisplay_window): Pass to move_it_vertically the margin in
1036 pixels, not in screen lines.
de0100f2 1037
96a72ee9
GM
10382012-03-02 Glenn Morris <rgm@gnu.org>
1039
1040 * buffer.c (buffer-list-update-hook): Doc fix.
1041
312508d7
EZ
10422012-02-29 Eli Zaretskii <eliz@gnu.org>
1043
1044 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1045 push_it before setting up the iterator for the first overlay
1046 string, even if we have an empty string loaded.
1047 (next_overlay_string): If there's an empty string on the iterator
1048 stack, pop the stack. (Bug#10903)
1049
27f3c637
PE
10502012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1051
1052 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1053 Suggested by Stefan Monnier in
1054 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1055 * alloc.c (widen_to_Lisp_Object): New static function.
1056 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1057 and widening them to Lisp_Objects. This would work even if
1058 USE_LSB_TAG is defined and wide integers are used, which might
1059 happen in a future version of Emacs.
1060
3c9dfce6
CY
10612012-02-25 Chong Yidong <cyd@gnu.org>
1062
fa74b241
CY
1063 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1064 Doc fix.
1065
3c9dfce6
CY
1066 * xselect.c (Fx_selection_exists_p): Doc fix.
1067 (x_clipboard_manager_save_all): Print an informative message
1068 before saving to clipboard manager.
1069
9486df08
CY
10702012-02-24 Chong Yidong <cyd@gnu.org>
1071
1072 * keyboard.c (process_special_events): Handle all X selection
1073 requests in kbd_buffer, not just the next one (Bug#8869).
1074
f01d3321
CY
10752012-02-23 Chong Yidong <cyd@gnu.org>
1076
1077 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1078 call when setting menu-bar-lines and tool-bar-lines parameters.
1079 (unwind_create_frame_1): New helper function.
1080
1081 * window.c (inhibit_window_configuration_change_hook): New var.
1082 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 1083 (syms_of_window): Initialize it.
f01d3321 1084
86b847b6
CY
10852012-02-22 Chong Yidong <cyd@gnu.org>
1086
1087 * xterm.c (x_draw_image_relief): Add missing type check for
1088 Vtool_bar_button_margin (Bug#10743).
1089
a59225b1
CY
10902012-02-21 Chong Yidong <cyd@gnu.org>
1091
1092 * fileio.c (Vfile_name_handler_alist): Doc fix.
1093
1094 * buffer.c (Fget_file_buffer): Protect against invalid file
1095 handler return value.
1096
310f5bd4
PE
10972012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1098
cb3a28cc
PE
1099 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1100 when computing $valmask.
1101
310f5bd4
PE
1102 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1103 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1104 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1105 It's useless in that case, and it can cause problems on hosts
1106 that allocate halves of EMACS_INT values separately.
1107 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1108 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1109 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1110 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1111 it avoids undefined behavior on hosts where shifting right by more
1112 than the word width has undefined behavior.
1113
2375c96a
CY
11142012-02-19 Chong Yidong <cyd@gnu.org>
1115
1116 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1117 (Funhandled_file_name_directory, Ffile_name_as_directory)
1118 (Fdirectory_file_name, Fexpand_file_name)
1119 (Fsubstitute_in_file_name): Protect against invalid file handler
1120 return values (Bug#10845).
1121
3eb49e71
EZ
11222012-02-18 Eli Zaretskii <eliz@gnu.org>
1123
1124 * .gdbinit (pitx): Fix incorrect references to fields of the
1125 iterator stack.
1126
7b926f3f
CY
11272012-02-17 Chong Yidong <cyd@gnu.org>
1128
1129 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1130
11273115
PE
11312012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1132
1133 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1134 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1135
c3a70e2b
CY
11362012-02-15 Chong Yidong <cyd@gnu.org>
1137
1138 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1139 marked as special. Also, starting docstrings with * is obsolete.
1140
0ca43699
AS
11412012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1142
1143 * gnutls.c (emacs_gnutls_write): Fix last change.
1144
2e8f3c56
LI
11452012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1146
1147 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1148 send_process.
1149
af70074f
SM
11502012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1151
1152 * keymap.c (Fsingle_key_description): Handle char ranges.
1153
95986d52
CY
11542012-02-12 Chong Yidong <cyd@gnu.org>
1155
afd83bd1
CY
1156 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1157 as that creates a dangerous corner case.
1158
95986d52
CY
1159 * window.c (Fdelete_window_internal): Invalidate the mouse
1160 highlight (Bug#9904).
1161
bd7da63e
GM
11622012-02-12 Glenn Morris <rgm@gnu.org>
1163
1164 * xselect.c (Fx_own_selection_internal)
1165 (Fx_get_selection_internal, Fx_disown_selection_internal)
1166 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1167 * nsselect.m (Fx_own_selection_internal)
1168 (Fx_disown_selection_internal, Fx_selection_exists_p)
1169 (Fx_selection_owner_p, Fx_get_selection_internal):
1170 Sync docs and argument specs with the xselect.c versions.
1171
77abcbc2
LI
11722012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1173
1174 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1175
90b671e2
EZ
11762012-02-11 Eli Zaretskii <eliz@gnu.org>
1177
1c0ca0b7
EZ
1178 * w32select.c (Fx_selection_exists_p): Sync doc string and
1179 argument list with xselect.c. (Bug#10783)
1180
1181 * w16select.c (Fx_selection_exists_p): Sync doc string and
1182 argument list with xselect.c. (Bug#10783)
90b671e2 1183
49241268
GM
11842012-02-10 Glenn Morris <rgm@gnu.org>
1185
1186 * fns.c (Fsecure_hash): Doc fix.
1187
f998bbe7 11882012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
1189
1190 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1191
0992bd9c
CY
11922012-02-07 Chong Yidong <cyd@gnu.org>
1193
1194 * buffer.c (Fbuffer_local_variables)
1195 (buffer_lisp_local_variables): Handle unbound vars correctly;
1196 don't let Qunbound leak into Lisp.
1197
af008560
GM
11982012-02-07 Glenn Morris <rgm@gnu.org>
1199
dd605cc4
GM
1200 * image.c (Fimagemagick_types): Doc fix.
1201
af008560
GM
1202 * image.c (imagemagick-render-type): Change it from a lisp object
1203 to an integer. Move the doc here from the lisp manual.
1204 Treat all values not equal to 0 the same.
1205
1449fa1d
CY
12062012-02-06 Chong Yidong <cyd@gnu.org>
1207
1208 * doc.c (store_function_docstring): Avoid applying docstring of
1209 alias to base function (Bug#2603).
1210
3723ec07
AS
12112012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1212
1213 * .gdbinit (pp1, pv1): Remove redundant defines.
1214 (pr): Use pp.
1215
79c1cc1e
CY
12162012-02-04 Chong Yidong <cyd@gnu.org>
1217
1218 * nsterm.m: Declare a global (Bug#10694).
1219
d7f29f8e
EZ
12202012-02-04 Eli Zaretskii <eliz@gnu.org>
1221
cae07000
SM
1222 * w32.c (get_emacs_configuration_options):
1223 Include --enable-checking, if specified, in the return value.
d7f29f8e 1224
3b95a6f9
MR
12252012-02-04 Martin Rudalics <rudalics@gmx.at>
1226
1227 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1228 after rounding frame sizes. (Bug#9723)
1229
d6fa96a6
EZ
12302012-02-04 Eli Zaretskii <eliz@gnu.org>
1231
1232 * keyboard.c (adjust_point_for_property): Don't position point
1233 before BEGV. (Bug#10696)
1234
df0b2940
PE
12352012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1236
1237 Handle overflow when computing char display width (Bug#9496).
1238 * character.c (char_width): Return EMACS_INT, not int.
1239 (char_width, c_string_width): Check for overflow when
1240 computing the width; this is possible now that individual
1241 characters can have unbounded width. Problem introduced
1242 by merge from Emacs 23 on 2012-01-19.
1243
6bee44d6
MA
12442012-02-02 Michael Albinus <michael.albinus@gmx.de>
1245
1246 * dbusbind.c (Fdbus_register_method): Mention the return value
1247 :ignore in the docstring.
1248
44f92739
GM
12492012-02-02 Glenn Morris <rgm@gnu.org>
1250
1b9f60cc
GM
1251 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1252
44f92739
GM
1253 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1254 Unconditionally set to t. (Bug#10673)
1255 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1256 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1257 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1258
c5d3843c
KH
12592012-02-02 Kenichi Handa <handa@m17n.org>
1260
1261 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1262 0, do not call append_composite_glyph.
1263
159462d4 12642012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
1265
1266 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1267 NULL (Bug#6988).
1268 (x_produce_glyphs): If the component of a composition is a null
1269 string, set it->pixel_width to 1 to avoid zero-width glyph.
1270
78cef877
EZ
12712012-02-01 Eli Zaretskii <eliz@gnu.org>
1272
1273 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1274 first 2 arguments are identical. This makes inserting large
1275 output from a subprocess an order of magnitude faster on
1276 MS-Windows, where all sbrk'ed memory is always contiguous.
1277
97897668
GM
12782012-01-31 Glenn Morris <rgm@gnu.org>
1279
1280 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 1281 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
1282 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1283
31fd3586
GM
12842012-01-29 Glenn Morris <rgm@gnu.org>
1285
1286 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1287
0e24a8b2
CY
12882012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1289
1290 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1291
cc0adcb0
CY
12922012-01-28 Chong Yidong <cyd@gnu.org>
1293
1294 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1295
acc28cb9
CY
12962012-01-26 Chong Yidong <cyd@gnu.org>
1297
9c69cfb7
CY
1298 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1299
acc28cb9
CY
1300 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1301 repeat counts (Bug#10507).
1302
48da7392
GM
13032012-01-26 Glenn Morris <rgm@gnu.org>
1304
1305 * lread.c (syms_of_lread): Doc fix.
1306
14af5f7f
CY
13072012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1308
1309 * coding.c (encode_designation_at_bol): Change return value to
1310 EMACS_INT.
1311
0b21c100
CY
13122012-01-25 Chong Yidong <cyd@gnu.org>
1313
1314 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1315
3c2907f7
CY
13162012-01-21 Chong Yidong <cyd@gnu.org>
1317
1318 * floatfns.c (Fcopysign): Make the second argument non-optional,
1319 since nil is not allowed anyway.
1320
959ad23f
AS
13212012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1322
1323 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1324 (send_process): Likewise.
1325
34a02f46
MR
13262012-01-19 Martin Rudalics <rudalics@gmx.at>
1327
1328 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
1329 (Vwindow_persistent_parameters): Do not use Qstate.
1330 Rewrite doc-strings.
34a02f46 1331
1259009a 13322012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
1333
1334 * character.c (char_width): New function.
70d4fdf6
GM
1335 (Fchar_width, c_string_width, lisp_string_width):
1336 Use char_width (Bug#9496).
25ed9e61 1337
6a6ee00d
MR
13382012-01-16 Martin Rudalics <rudalics@gmx.at>
1339
1340 * window.c (Vwindow_persistent_parameters): New variable.
1341 (Fset_window_configuration, save_window_save): Handle persistent
1342 window parameters.
1343
c85efaf7
EZ
13442012-01-14 Eli Zaretskii <eliz@gnu.org>
1345
1346 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1347 thrashing the stack of the thread. (Bug#9087)
1348
5944709e
PE
13492012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1350
1351 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1352
e71f5d99
EZ
13532012-01-11 Eli Zaretskii <eliz@gnu.org>
1354
1355 * xdisp.c (rows_from_pos_range): Handle the case where the
1356 highlight ends on a newline. (Bug#10464)
1357 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1358 he end column for display of highlight that ends on a newline
1359 before a R2L line.
1360
ce316182
GM
13612012-01-11 Glenn Morris <rgm@gnu.org>
1362
1363 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1364 from load-path also when installation-directory is nil. (Bug#10208)
1365
5b43da69
GM
13662012-01-10 Glenn Morris <rgm@gnu.org>
1367
74cc8ff9
GM
1368 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1369
7d8d6e4e
GM
1370 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1371 Update template values to be closer to their typical values these days.
5b43da69 1372
a0db8d43
EZ
13732012-01-09 Eli Zaretskii <eliz@gnu.org>
1374
1375 * xdisp.c (rows_from_pos_range): Accept additional argument
1376 DISP_STRING, and accept any glyph in a row whose object is that
1377 string as eligible for mouse highlight. Fixes mouse highlight of
1378 display strings from overlays. (Bug#10464)
1379
9a0115ab 13802012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1381
b9110d6a 1382 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1383 * fileio.c (auto_saving_dir_umask): New static var.
1384 (Fmake_directory_internal): Use it.
1385 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1386 creating the directory. The old code temporarily assigns
1387 too-generous permissions to the directory.
1388 (do_auto_save_eh): Clear it.
b9110d6a 1389 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1390 that the var is always cleared.
1391
6c1bd3f3
EZ
13922012-01-07 Eli Zaretskii <eliz@gnu.org>
1393
1394 * search.c (scan_buffer): Pass character positions to
1395 know_region_cache, not byte positions. (Bug#6540)
1396
069d2b50
L
13972012-01-07 LynX <_LynX@bk.ru> (tiny change)
1398
1399 * w32.c (sys_rename): Report EXDEV when rename of a directory
1400 fails because the target is on another logical disk. (Bug#10284)
1401
75bf0d33
DB
14022012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1403
1404 * xterm.c (x_embed_request_focus): New function.
1405
1406 * xterm.h: Add prototype.
1407
1408 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1409
1c6e5a32
GM
14102012-01-05 Glenn Morris <rgm@gnu.org>
1411
1412 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1413
651e947e
EZ
14142012-01-01 Eli Zaretskii <eliz@gnu.org>
1415
1416 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1417 Load gnutls_transport_set_lowat only if GnuTLS version is below
1418 2.11.1.
1419 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1420 GnuTLS versions below 2.11.1.
1421
3778cdd8
AL
14222011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1423
1424 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1425 to the doc string advising against its use for altering the way
1426 windows are scrolled.
1427
0e5317f7
KH
14282011-12-28 Kenichi Handa <handa@m17n.org>
1429
1430 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1431 coding-system ASCII compatible only when it does not produce BOM
1432 on encoding (Bug#10383).
1433
93d5ca1f
JD
14342011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1435
1436 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1437 can scroll.
1438 (create_and_show_popup_menu): Always use menu_position_func for
1439 Gtk3 (Bug#10361).
1440
ca22b785
AS
14412011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1442
1443 * callint.c (Fcall_interactively): Don't truncate prompt string.
1444
d048e1e6
EZ
14452011-12-23 Eli Zaretskii <eliz@gnu.org>
1446
1447 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1448 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1449 resumed from there (after widening). (Bug#10360)
d048e1e6 1450
5ccaba1f
JD
14512011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1452
1453 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1454
204ee57f
JD
14552011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1456
b81d40f0
JB
1457 * nsterm.m (x_free_frame_resources):
1458 Release f->output_data.ns->miniimage.
204ee57f
JD
1459 (ns_index_color): Fix indentation. Do not retain
1460 color_table->colors[i].
1461
1462 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1463 before returning.
1464
1465 * nsfns.m (x_set_background_color): Assign return value from
1466 ns_index_color to face-background instead of NSColor*.
1467 (ns_implicitly_set_icon_type): Fix indentation.
1468 Change assignment in for loop to comparison.
1469
1470 * emacs.c (ns_pool): New variable.
1471 (main): Assign ns_pool.
1472 (Fkill_emacs): Call ns_release_autorelease_pool.
1473
1474 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1475 autorelease fdesc, release fdAttrs and tdict.
1476 (ns_get_covering_families): Release charset.
1477 (ns_findfonts): Release NSFontDescriptor created with new.
1478 (ns_uni_to_glyphs): Fix indentation.
1479 (setString): Release attrStr before assigning new value.
1480
c803b2b7
JD
14812011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1482
678f4426
JD
1483 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1484 and NS_IMPL_COCOA.
1485 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1486 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1487
cd394be1 14882011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1489
5fecd5fc
JD
1490 * nsterm.m (ns_term_init): Subscribe for notifications
1491 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1492 to method trackingNotification in EmacsMenu.
1493
1494 * nsmenu.m (trackingMenu): New variable.
3771cb17 1495 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1496 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1497 from Aquamacs (Bug#7030).
678f4426
JD
1498
14992011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1500
c803b2b7
JD
1501 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1502 (symbol_to_nsstring): Fix indentation.
1503 (ns_symbol_to_pb): New function.
cae07000
SM
1504 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1505 (Fns_rotate_cut_buffers_internal): Remove.
1506 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1507 Fns_store_cut_buffer_internal.
1508 (ns_get_foreign_selection, Fx_own_selection_internal)
1509 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1510 (Fns_get_selection_internal, Fns_store_selection_internal):
1511 Use ns_symbol_to_pb and check if return value is nil.
1512 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1513 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1514 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1515 renamed to Sns_store_selection_internal.
1516 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1517 and remove this function.
1518 (ns_handle_selection_clear): Remove, never used.
1519 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1520 here.
1521
e1b01a3a
KB
15222011-12-17 Ken Brown <kbrown@cornell.edu>
1523
1524 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1525 GID is unknown (Bug#10257).
1526
2adb6e85
PE
15272011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1528
1529 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1530 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1531 which caused a build failure on GNU/Linux IA-64. This problem was
1532 introduced by my 2011-10-07 patch.
1533
d1d7b339
JL
15342011-12-15 Juri Linkov <juri@jurta.org>
1535
1536 * image.c (imagemagick_error): New function. (Bug#10112)
1537 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1538 Use `imagemagick_error' where ImageMagick functions return
1539 `MagickFalse'.
1540 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1541 proper order.
1542
100d5755
KH
15432011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1544
1545 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1546 fill background (Bug#8992).
1547
454592a6
MR
15482011-12-13 Martin Rudalics <rudalics@gmx.at>
1549
1550 * window.c (Vwindow_combination_resize)
1551 (Vwindow_combination_limit): Use t instead of non-nil in
1552 doc-strings.
61d4b438
MR
1553 (Vrecenter_redisplay): Add first sentence of doc-string on
1554 separate line.
53524d93 1555 (Frecenter): Fix doc-string typo.
454592a6 1556
3633e3aa
KH
15572011-12-11 Kenichi Handa <handa@m17n.org>
1558
1559 * coding.c (Funencodable_char_position): Pay attention to the
1560 buffer text relocation (Bug#9389).
1561
7b9d523a
JD
15622011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1563
1564 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1565 gtk_init (Bug#10100).
1566
b73189c6
EZ
15672011-12-10 Eli Zaretskii <eliz@gnu.org>
1568
1569 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1570 IT->string is nil. (Bug#10263)
1571
f7dfe5d6
JD
15722011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1573
83faebb4
JD
1574 * nsterm.h (x_free_frame_resources): Declare.
1575
f7dfe5d6
JD
1576 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1577 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1578
1579 * nsterm.h (ns_get_defaults_value): Declare.
1580
1581 * nsterm.m (ns_default): Call ns_get_defaults_value.
1582
7cd4e72c
EZ
15832011-12-09 Eli Zaretskii <eliz@gnu.org>
1584
1585 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1586 (Bug#10170)
1587
b34d7317
YM
15882011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1589
1590 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1591 that where the value of an _OBJC_* symbol points to is in the .bss
1592 section (Bug#10240).
1593
76470ad1
KH
15942011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1595
1596 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1597 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1598
745fff94
KH
15992011-12-08 Kenichi Handa <handa@m17n.org>
1600
1601 * ftfont.c (get_adstyle_property): Fix previous change
1602 (Bug#10233).
1603
6e44397c
JB
16042011-12-07 Juanma Barranquero <lekktu@gmail.com>
1605
1606 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1607 dirs from the default value of EMACSLOADPATH (bug#10208).
1608
7efa6272
GM
16092011-12-07 Glenn Morris <rgm@gnu.org>
1610
1611 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1612 installation and source directories as well. (Bug#10208)
1613
f6fc4d87
CY
16142011-12-06 Chong Yidong <cyd@gnu.org>
1615
1616 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1617
2bf26180
GM
16182011-12-06 Glenn Morris <rgm@gnu.org>
1619
1620 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1621 as an error, not just -1. (Bug#10217)
1622
3a6ad4f0
CY
16232011-12-05 Chong Yidong <cyd@gnu.org>
1624
1625 * keyboard.c (process_special_events): New function.
1626 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1627
75a3b399
PE
16282011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1629
1630 * coding.c (encode_designation_at_bol): Don't use uninitialized
1631 local variable (Bug#9318).
1632
c3c9e25e
KH
16332011-12-05 Kenichi Handa <handa@m17n.org>
1634
1635 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1636 return Qnil (Bug#8046, Bug#10193).
1637
5eb05ea3
KH
16382011-12-05 Kenichi Handa <handa@m17n.org>
1639
1640 * coding.c (encode_designation_at_bol): New args charbuf_end and
1641 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1642 (coding_set_source): Return how many bytes coding->source was
1643 relocated.
1644 (coding_set_destination): Return how many bytes
1645 coding->destination was relocated.
1646 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1647 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1648
16492011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1650
1651 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1652 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1653 macro (Bug#9318).
1654
16552011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1656
1657 The following changes are to fix Bug#9318.
1658
a79703f5 1659 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1660 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1661 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1662 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1663
7dbda6df
JB
16642011-12-05 Juanma Barranquero <lekktu@gmail.com>
1665
1666 * lisp.h (process_quit_flag): Fix external declaration.
1667
6d5eb5b0
SM
16682011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1669
1670 Don't macro-inline non-performance-critical code.
1671 * eval.c (process_quit_flag): New function.
1672 * lisp.h (QUIT): Use it.
1673
a0c3fad0
JD
16742011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1675
1676 * nsfns.m (get_geometry_from_preferences): New function.
1677 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1678
6c07aac2
AS
16792011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1680
1681 * emacs.c (Qkill_emacs): Define.
1682 (syms_of_emacs): Initialize it.
1683 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1684 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1685 (quit_throw_to_read_char): Add parameter `from_signal'.
1686 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1687 * lisp.h (QUIT): Call Fkill_emacs if requested.
1688
c052ead4
JD
16892011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1690
1691 * widget.c (update_wm_hints): Return if wmshell is null.
1692 (widget_update_wm_size_hints): New function.
1693
1694 * widget.h (widget_update_wm_size_hints): Declare.
1695
1696 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1697 widget_update_wm_size_hints (Bug#10104).
1698
9e49252b
EZ
16992011-12-03 Eli Zaretskii <eliz@gnu.org>
1700
1701 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1702 before a newline, prepare the bidi iterator for consuming the
1703 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1704 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1705
02b16839
JL
17062011-12-02 Juri Linkov <juri@jurta.org>
1707
1708 * search.c (Fword_search_regexp): New Lisp function created from
1709 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1710 (Fword_search_backward, Fword_search_forward)
1711 (Fword_search_backward_lax, Fword_search_forward_lax):
1712 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1713 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1714
0068070e
SM
17152011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1716
1717 * fileio.c (Finsert_file_contents): Move after-change-function call
1718 to before the "handled:" label, since all "goto handled" appear in
1719 cases where the *-change-functions have already been properly called
1720 (bug#10117).
1721
3360a3fc
AS
17222011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1723
1724 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1725 waiting for input. (Bug#10169)
1726
73d6c093
EZ
17272011-11-30 Eli Zaretskii <eliz@gnu.org>
1728
1729 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1730 verifies glyph row's hash code--we have just reallocated the
1731 glyphs, so their contents can be complete garbage. (Bug#10164)
1732
febe6bea
JB
17332011-11-30 Juanma Barranquero <lekktu@gmail.com>
1734
1735 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1736
801a4313
EZ
17372011-11-30 Eli Zaretskii <eliz@gnu.org>
1738
1739 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1740 attributes are tested _before_ calling verify_row_hash, to protect
1741 against GCC re-ordering of the tests. (Bug#10164)
1742
2b56b87e
JD
17432011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1744
1745 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1746
1747 * xterm.c (handle_one_xevent): Only set async_visible and friends
1748 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1749 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1750 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1751
dbf31225
PE
17522011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1753
1754 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1755 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1756 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1757 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1758 All uses changed to use GCPRO1 etc.
1759 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1760 Revert to old implementation (i.e., before 2011-03-11).
1761
1305621b
YM
17622011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1763
1764 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1765 of scroll runs so as to avoid assigning disabled bogus rows and
1766 unnecessary graphics copy operations.
1767
8c9afb46
EZ
17682011-11-27 Eli Zaretskii <eliz@gnu.org>
1769
1770 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1771 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1772 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1773 (malloc, free, realloc, calloc): Redirect to e_* only when
1774 compiling Emacs.
1775
1776 * lisp.h (GCTYPEBITS): Move before first use.
1777 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1778 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1779 this macro definition.
1780
1781 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1782 _MSC_VER.
1783
54e9e3bf
JD
17842011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1785
6d5eb5b0
SM
1786 * gtkutil.c (xg_create_frame_widgets):
1787 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1788 present with Gtk+ 2.0.
1789
83aca1cb
PE
17902011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1791
1792 * fileio.c (Finsert_file_contents): Undo previous change; see
1793 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1794
5b76caa4
PE
17952011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1796
1797 Rename locals to avoid shadowing.
1798 * fileio.c (Finsert_file_contents):
1799 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1800 * process.c (wait_reading_process_output):
1801 Rename inner 'proc' to 'p' to avoid shadowing.
1802 Indent for consistency with usual Emacs style.
1803
8c535114
EZ
18042011-11-25 Eli Zaretskii <eliz@gnu.org>
1805
1806 * xdisp.c (redisplay_window): If cursor row is not fully visible
1807 after recentering, and scroll-conservatively is set to a large
1808 number, scroll window by a few more lines to make the cursor fully
1809 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1810 (start_display): Don't move to the next line if the display should
1811 start at a newline that is part of a display vector or an overlay
1812 string. (Bug#10119)
8c535114 1813
fa4fdb5c
JL
18142011-11-24 Juri Linkov <juri@jurta.org>
1815
1816 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1817 after the `MagickPingImage' call. (Bug#10112)
1818
90ec88df
CY
18192011-11-23 Chong Yidong <cyd@gnu.org>
1820
1821 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1822
56e2e794
MR
18232011-11-23 Martin Rudalics <rudalics@gmx.at>
1824
1825 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1826 making another buffer current. (Bug#10114)
1827
b6e64c41
GM
18282011-11-23 Glenn Morris <rgm@gnu.org>
1829
1830 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1831
6b21de18
CY
18322011-11-23 Chong Yidong <cyd@gnu.org>
1833
1834 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1835 using it (Bug#5984).
1836
b12cd789
EZ
18372011-11-22 Eli Zaretskii <eliz@gnu.org>
1838
1839 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1840 and header-lines, as they don't have one computed for them.
1841 (Bug#10098)
1842
1843 * .gdbinit (prow): Make displayed values more self-explaining.
1844 Add row's hash code.
1845
261b6fd4
LMI
18462011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1847
1848 * process.c (wait_reading_process_output): Fix asynchrounous
1849 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1850 (wait_reading_process_output): Add comment and URL.
261b6fd4 1851
e7cfd277
JD
18522011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1853
1854 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1855
a9b9b7f5
CY
18562011-11-21 Chong Yidong <cyd@gnu.org>
1857
1858 * window.c (Fnext_window, Fprevious_window): Doc fix.
1859
b0d15b4f
SM
18602011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1861
1862 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1863
fe7a3057
JB
18642011-11-20 Juanma Barranquero <lekktu@gmail.com>
1865
1866 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1867
d2999b1a
MR
18682011-11-20 Martin Rudalics <rudalics@gmx.at>
1869
1870 * window.c (Fset_window_combination_limit): Rename argument
1871 STATUS to LIMIT.
1872 (Vwindow_combination_limit): Remove "status" from doc-string.
1873
d5ff9cd0
AS
18742011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1875
1876 * m/ibms390.h: Remove.
1877 * m/ibms390x.h: Don't include "ibms390.h".
1878
a5bb9bd3
SM
18792011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1880
1881 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1882 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1883
cd1181db
JB
18842011-11-20 Juanma Barranquero <lekktu@gmail.com>
1885
1886 * casetab.c (Fset_case_table):
1887 * charset.c (Fcharset_after): Fix typos.
1888
615a3b8d 18892011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1890
17e845af
PE
1891 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1892 Otherwise, valgrind does not work on some platforms.
1893 Problem reported by Andreas Schwab in
6a0bf43d
PE
1894 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1895 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1896 is set, removing the need for VIRT_ADDRESS_VARIES.
1897 (PURE_P): Use a more-efficient implementation that needs just one
1898 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1899 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1900 to 4 (xorl, subq, cmpq, setbe).
1901 * alloc.c (pure): Always extern now, since that's the
1902 VIRT_ADDR_VARIES behavior.
1903 (PURE_POINTER_P): Use a single comparison, not two, for
1904 consistency with the new puresize.h.
1905 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1906 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1907 Remove VIRT_ADDR_VARIES no longer needed.
1908
f8fe6f96
EZ
19092011-11-19 Eli Zaretskii <eliz@gnu.org>
1910
1911 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1912 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1913 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1914 behave as if the cursor position were at the window margin.
1915
1916 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1917 and the cursor position is out of bounds, behave as if the cursor
1918 position were at the window margin. (Bug#10075)
1919
df05a53c
CY
19202011-11-18 Chong Yidong <cyd@gnu.org>
1921
1922 * window.c (Fwindow_combination_limit): Make first argument
1923 non-optional, since it is meaningless for live windows like the
1924 selected window.
1925
2071918e
DA
19262011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1927
1928 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1929
b50a28de
SM
19302011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1931
1932 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1933 (graft_intervals_into_buffer): Simplify.
1934
015137db
EZ
19352011-11-18 Eli Zaretskii <eliz@gnu.org>
1936
1937 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1938 hash values of the two rows.
1939 (copy_row_except_pointers): Preserve the used[] arrays and the
1940 hash values of the two rows. (Bug#10035)
68c95424 1941 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1942
1943 * xdisp.c (row_hash): New function, body extracted from
1944 compute_line_metrics.
1945 (compute_line_metrics): Call row_hash, instead of computing the
1946 hash code inline.
1947
1948 * dispnew.c (verify_row_hash): Call row_hash for computing the
1949 hash code of a row, instead of duplicating code from xdisp.c.
1950
1951 * dispextern.h (row_hash): Add prototype.
1952
a2addb04
TH
19532011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1954
1955 * frame.c (delete_frame): Don't delete the terminal when the last
1956 X frame is closed if emacs is built with GTK toolkit.
1957
df85d315
JB
19582011-11-17 Juanma Barranquero <lekktu@gmail.com>
1959
1960 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1961
a0c2d0ae
MR
19622011-11-17 Martin Rudalics <rudalics@gmx.at>
1963
1964 * window.c (Vwindow_splits): Rename to
1965 Vwindow_combination_resize. Suggested by Juri Linkov.
1966 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1967 of Vwindow_splits.
1968
58179cce
JB
19692011-11-16 Juanma Barranquero <lekktu@gmail.com>
1970
7877f373
JB
1971 * nsfns.m (Fns_font_name):
1972 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1973
b6f67890
MR
19742011-11-16 Martin Rudalics <rudalics@gmx.at>
1975
1976 * window.h (window): Rename slot "nest" to "combination_limit".
1977 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1978 (Fset_window_nest): Rename to Fset_window_combination_limit.
1979 (Vwindow_nest): Rename to Vwindow_combination_limit.
1980 (recombine_windows, make_parent_window, make_window)
1981 (Fsplit_window_internal, saved_window)
1982 (Fset_window_configuration, save_window_save): Rename all
1983 occurrences of window_nest to window_combination_limit.
1984
c7015153
JB
19852011-11-15 Juanma Barranquero <lekktu@gmail.com>
1986
1987 * image.c (imagemagick_load_image): Fix typo.
1988
322ad6ec
EZ
19892011-11-14 Eli Zaretskii <eliz@gnu.org>
1990
1991 * xdisp.c (display_line): Move the call to
1992 highlight_trailing_whitespace before the call to
1993 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1994 faces of all the glyphs to compute ROW's hash value.
1995 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1996
f067b8ec
JB
19972011-11-14 Juanma Barranquero <lekktu@gmail.com>
1998
1999 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2000 just return (bug#10044).
2001
1e5b2111
EZ
20022011-11-12 Eli Zaretskii <eliz@gnu.org>
2003
7ef3cbd5
EZ
2004 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2005 with user-defined heap size. Bump the default size of the temacs
2006 heap to 27MB, to avoid memory warning when running temacs.
2007 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2008
1e5b2111
EZ
2009 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2010 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
2011 (verify_row_hash) [XASSERTS]: New function.
2012 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2013 that the hash value of glyph rows is correct.
1e5b2111 2014
89d61221
MR
20152011-11-12 Martin Rudalics <rudalics@gmx.at>
2016
2017 * window.h (window): Remove splits slot.
2018 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2019 (Fdelete_other_windows_internal, make_parent_window)
2020 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2021 (Fset_window_configuration, save_window_save): Don't deal with
2022 split status of windows.
2023 (saved_window): Remove splits slot.
2024 (Vwindow_splits): Rewrite doc-string.
2025
97f18cc8
JD
20262011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2027
2028 * xfns.c (unwind_create_frame):
2029 * nsfns.m (unwind_create_frame):
2030 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2031 Vframe_list (Bug#9999).
2032
22a648b4
DA
20332011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2034
0b381c7e 2035 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 2036
659afede
KH
20372011-11-11 Kenichi Handa <handa@m17n.org>
2038
2039 * callproc.c (Fcall_process): Set the member dst_multibyte of
2040 process_coding.
2041
9ac0394b
KH
20422011-11-11 Johan Bockgård <bojohan@gnu.org>
2043
2044 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2045 avoid a crash (bug#9496).
2046
2fbdc249
CY
20472011-11-09 Chong Yidong <cyd@gnu.org>
2048
2049 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2050 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2051
ac6b1f81
PE
20522011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2053
2054 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2055
09db192c
PE
20562011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2057
2058 Avoid some portability problems by eschewing 'extern inline' functions.
2059 The trivial performance wins aren't worth the portability hassles; see
2060 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2061 et seq.
2062 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2063 (window_box_width, window_box_left, window_box_left_offset)
2064 (window_box_right, window_box_right_offset): Undo previous change,
2065 by removing the "extern"s.
2066 * intervals.c (adjust_intervals_for_insertion)
2067 (adjust_intervals_for_deletion): Undo previous change,
2068 making these static again.
2069 (offset_intervals, temp_set_point_both, temp_set_point)
2070 (copy_intervals_to_string): No longer inline.
2071 * xdisp.c (window_text_bottom_y, window_box_width)
2072 (window_box_height, window_box_left_offset)
2073 (window_box_right_offset, window_box_left, window_box_right)
2074 (window_box): No longer inline.
2075
105216ed
CY
20762011-11-08 Chong Yidong <cyd@gnu.org>
2077
2078 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
2079 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2080 Signal an error if not a live window.
105216ed
CY
2081 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2082 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2083
ae9e237f
JB
20842011-11-07 Juanma Barranquero <lekktu@gmail.com>
2085
2086 * lisp.h (syms_of_abbrev): Remove declaration.
2087 Reported by CHENG Gao <chenggao@royau.me>.
2088
c7aa8333
EZ
20892011-11-07 Eli Zaretskii <eliz@gnu.org>
2090
2091 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2092 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2093 of temacs in GUI mode.
2094
be7f5545
MR
20952011-11-07 Martin Rudalics <rudalics@gmx.at>
2096
2097 * window.h: Declare delete_all_child_windows instead of
2098 delete_all_subwindows.
2099 * window.c (Fwindow_nest, Fset_window_nest)
2100 (Fset_window_new_total, Fset_window_new_normal)
2101 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2102 (delete_all_subwindows): Rename to delete_all_child_windows.
2103 (Fdelete_other_windows_internal, Fset_window_configuration):
2104 Call delete_all_child_windows instead of delete_all_subwindows.
2105 * frame.c (delete_frame): Call delete_all_child_windows instead
2106 of delete_all_subwindows.
2107
ca78dc43
PE
21082011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2109
2110 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2111 This is also needed for porting to any host where GC_MARK_STACK is
2112 not GC_MAKE_GCPROS_NOOPS.
2113 (which_symbols): Use it.
2114
a0241d01
KH
21152011-11-07 Kenichi Handa <handa@m17n.org>
2116
2117 * coding.c (coding_set_destination): Check coding->src_pos only
2118 when coding->src_object is a buffer (bug#9910).
2119
2120 * process.c (send_process): Set the member src_multibyte of coding
2121 to 0 (bug#9911) when sending a unibyte text.
2122
2123 * callproc.c (Fcall_process): Set the member src_multibyte of
2124 process_coding to 0 (bug#9912).
2125
a64bfdfa 21262011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
2127
2128 * xmenu.c (cleanup_widget_value_tree): New function.
2129 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2130 calling free_menubar_widget_value_tree directly (Bug#9830).
2131
cb41b32a
PE
21322011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2133
2134 Fix some portability problems with 'inline'.
2135 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2136 (window_box_width, window_box_left, window_box_left_offset)
2137 (window_box_right, window_box_right_offset): Declare extern.
2138 Otherwise, these inline functions do not conform to C99 and
2139 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2140 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2141 * intervals.c (adjust_intervals_for_insertion)
2142 (adjust_intervals_for_deletion): Now extern, because otherwise the
2143 extern inline functions 'offset_intervals' couldn't refer to it.
2144 (static_offset_intervals): Remove.
2145 (offset_intervals): Rewrite using the old contents of
2146 static_offset_intervals. The old version didn't conform to C99
2147 because an extern inline function contained a reference to an
2148 identifier with static linkage.
2149
b7041366
AS
21502011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2151
2152 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2153 GC.
2154
88a37c4d
EZ
21552011-11-06 Eli Zaretskii <eliz@gnu.org>
2156
2157 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2158 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2159 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2160 return Qleft_to_right.
2161
49745b39
CY
21622011-11-06 Chong Yidong <cyd@gnu.org>
2163
2164 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2165 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2166 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2167 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2168 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2169 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2170 (Fwindow_vscroll): Doc fix.
2171 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2172 argument, since it makes no sense to pass a live window and for
2173 consistency with window-child.
2174
1f05cd82
CS
21752011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2176
2177 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2178 support MSVC.
2179
22610910
JR
21802011-11-05 Jason Rumney <jasonr@gnu.org>
2181
2182 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2183 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2184 fonts (Bug#6029).
2185 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2186 bitwise arithmetic preventing use of unicode-sip and non-truetype
2187 opentype fonts.
2188
a06776b2
EZ
21892011-11-05 Eli Zaretskii <eliz@gnu.org>
2190
3ad924ba
EZ
2191 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2192 "emacs"-only part.
2193
a06776b2
EZ
2194 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2195 initialization code to keep similarity to xfns.c after changes
2196 from 2011-11-05.
2197
c9e7db78
JD
21982011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2199
a97f8f3f
JD
2200 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2201 (unwind_create_frame): New function (Bug#9943).
2202 (Fx_create_frame): Restructure code to be more similar to the one in
2203 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2204 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2205 Move terminal->reference_count++ just before making the frame official
2206 (Bug#9943).
2207
2208 * nsterm.m (x_free_frame_resources): New function.
2209 (x_destroy_window): Move code to x_free_frame_resources.
2210
c9e7db78 2211 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
2212 (Fx_create_frame, x_create_tip_frame):
2213 Move terminal->reference_count++ just before making the frame
75f1671a 2214 official. Move initialization of image_cache_refcount and
c9e7db78
JD
2215 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2216
a6fc3b5c
EZ
22172011-11-05 Eli Zaretskii <eliz@gnu.org>
2218
2219 Support MSVC build with newer versions of Visual Studio.
2220 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2221 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2222 nt/gmake.defs.
2223
2224 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2225 which are not supported by MSVC.
2226 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2227 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2228 bitfields.
2229 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2230 types in bitfields.
2231 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2232
2233 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2234
58179cce 22352011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
2236
2237 Support MSVC build with newer versions of Visual Studio.
2238 * w32.c: Don't include w32api.h for MSVC.
2239 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2240
2241 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2242 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2243 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2244 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2245 e_* cousins.
2246 (alloca) [_MSC_VER]: Define to _alloca.
2247
2248 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2249
2250 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2251
a58c13ed
EZ
22522011-11-04 Eli Zaretskii <eliz@gnu.org>
2253
2254 * xdisp.c (note_mouse_highlight): If either of
2255 previous/next-single-property-change returns nil, treat that as
2256 the beginning or the end of the buffer. (Bug#9955)
2257
fe0b6370
JD
22582011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2259
a58c13ed 2260 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
2261 label is not null (Bug#9951).
2262 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2263 may be NULL.
2264
89bd5ee1
EZ
22652011-11-04 Eli Zaretskii <eliz@gnu.org>
2266
2267 * window.c (Fwindow_body_size): Mention in the doc string that the
2268 return value is in frame's canonical units. (Bug#9949)
2269
84c3edb9
EZ
22702011-11-03 Eli Zaretskii <eliz@gnu.org>
2271
4e2fb5c7
EZ
2272 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2273
84c3edb9 2274 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 2275 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 2276 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 2277
bc17a887
EZ
22782011-11-01 Eli Zaretskii <eliz@gnu.org>
2279
2280 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2281 Don't stop backward scan on the continuation glyph, even though
2282 its CHARPOS is positive.
6d5eb5b0
SM
2283 (mouse_face_from_buffer_pos, note_mouse_highlight):
2284 Rename cover_string to disp_string.
bc17a887 2285
4ee88440
MR
22862011-11-01 Martin Rudalics <rudalics@gmx.at>
2287
2288 * window.c (temp_output_buffer_show): Don't use
2289 Vtemp_buffer_show_specifiers.
2290 (Vtemp_buffer_show_specifiers): Remove unused variable.
2291
c2ff3c02
EZ
22922011-10-30 Eli Zaretskii <eliz@gnu.org>
2293
2294 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2295 past the beginning of the current glyph matrix.
2296
58179cce 22972011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
2298
2299 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2300 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2301 HAVE_GTK3 (Bug#9869).
b77a6a7f 2302
3b574623
JD
2303 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2304 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2305
b77a6a7f
JD
2306 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2307
2308 * xterm.c: Declare x_handle_net_wm_state to return int.
2309 (handle_one_xevent): Check if we are iconified but don't have
2310 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2311 (get_current_wm_state): Return non-zero if not hidden,
2312 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2313 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2314 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2315 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2316
196e41e4
PE
23172011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2318
2319 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2320 so that this new function doesn't get optimized away by a
2321 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2322
021f2e1a
AS
23232011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2324
2325 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2326
8b058d44
EZ
23272011-10-29 Eli Zaretskii <eliz@gnu.org>
2328
2329 Fix the `xbytecode' command.
2330 * .gdbinit (xprintbytestr): New command.
b50a28de 2331 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
2332 (xbytecode): Print the byte-code string as well.
2333
4452fb80
EZ
23342011-10-29 Kim Storm <storm@cua.dk>
2335
8b058d44
EZ
2336 * alloc.c (which_symbols): New function.
2337
21b72067
AS
23382011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2339
2340 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2341 line. (Bug#9903)
2342
83ed7b5c
GM
23432011-10-29 Glenn Morris <rgm@gnu.org>
2344
2345 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2346 Not clear what it was for, and it causes various bugs. (Bug#9839)
2347
5a7a728b
EZ
23482011-10-28 Eli Zaretskii <eliz@gnu.org>
2349
2350 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2351 possible random value that matches one of those tested as
2352 condition to clear the mouse face.
2353
d3d0842f
CY
23542011-10-28 Chong Yidong <cyd@gnu.org>
2355
2356 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2357
31b39d13
DN
23582011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2359
2360 * window.c (make_window): Initialize phys_cursor_on_p.
2361
9aba6043
SM
23622011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2363
2364 * lisp.h (struct Lisp_Symbol): Update comments.
2365
c20992f4
JB
23662011-10-28 Juanma Barranquero <lekktu@gmail.com>
2367
2368 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2369
db4f02f2
EZ
23702011-10-28 Eli Zaretskii <eliz@gnu.org>
2371
2372 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2373 <oslsachem@gmail.com> for helping to debug this.
2374
2375 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2376 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2377 (g_b_init_get_glyph_outline_w): New static variables.
2378 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2379 (GetGlyphOutlineW_Proc): New typedefs.
2380 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2381 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2382 New functions.
2383 (w32font_open_internal, compute_metrics):
2384 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2385 instead of calling the "wide" APIs directly.
2386
2387 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2388
2389 * w32.h (syms_of_w32font): Add prototype.
2390
87e68db4
JB
23912011-10-27 Juanma Barranquero <lekktu@gmail.com>
2392
2393 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2394 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2395 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2396 (Fmove_to_window_line): Doc fix.
2397
435c1d67
CY
23982011-10-27 Chong Yidong <cyd@gnu.org>
2399
2400 * process.c (make_process): Set gnutls_state to NULL.
2401
2402 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2403 non-NULL, regardless of GNUTLS_INITSTAGE.
2404 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2405 an error. Set process slots as soon as we allocate them.
2406
2407 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2408
9c6c6f49
CY
24092011-10-27 Chong Yidong <cyd@gnu.org>
2410
9aba6043
SM
2411 * gnutls.c (emacs_gnutls_deinit): New function.
2412 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2413 (Fgnutls_deinit, Fgnutls_boot): Use it.
2414
2415 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2416 (deactivate_process): Call emacs_gnutls_deinit.
2417
657d08d3
JB
24182011-10-27 Juanma Barranquero <lekktu@gmail.com>
2419
2420 * image.c (x_create_x_image_and_pixmap):
2421 * w32.c (sys_rename, w32_delayed_load):
2422 * w32font.c (fill_in_logfont):
2423 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2424
5430d399
JB
24252011-10-26 Juanma Barranquero <lekktu@gmail.com>
2426
2427 * w32fns.c (w32_default_color_map): New function,
2428 extracted from Fw32_default_color_map.
a7ef684b 2429 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2430
fe0055fa
PE
24312011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2432
2433 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2434
e6346438
SM
24352011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2436
2437 * keyboard.c (test_undefined): New function (bug#9751).
2438 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2439
e112cc37
ET
24402011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2441
2442 * sysdep.c (init_sys_modes): Fix the check for the controlling
2443 terminal (Bug#6649).
2444
7b5d6677
EZ
24452011-10-20 Eli Zaretskii <eliz@gnu.org>
2446
2447 * dispextern.h (struct bidi_it): New member next_en_type.
2448
2449 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2450 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2451 current character, check also for next_en_type being WEAK_EN.
2452 (bidi_resolve_weak): Don't enter the expensive loop if the current
2453 position is before next_en_pos. Record the bidi type of the first
2454 non-ET, non-BN character we find, in addition to its position.
2455 (bidi_level_of_next_char): Invalidate next_en_type when
2456 next_en_pos is over-stepped.
2457
7da0b018
PE
24582011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2459
2460 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2461 * editfns.c: Rewrite current-time-zone so that it invokes
2462 the equivalent of (format-time-string "%Z") to get the time zone name.
2463 This fixes a bug when the time zone name contains characters that
2464 need converting from the system time locale to Emacs internal format.
2465 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2466 that patch fixed format-time-string to do the conversion, but
2467 I forgot to fix current-time-zone.
2468 (format_time_string): New function, containing most of
2469 what Fformat_time_string used to contain.
2470 (Fformat_time_string): Rewrite in terms of format_time_string.
2471 This doesn't change this function's behavior.
2472 (current-time-zone): Rewrite to use format_time_string.
2473 This fixes the bug reported by Michael Schierl in
2474 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2475 Jason Rumney's 2007-06-07 change worked around this bug, but
2476 didn't fix it.
2477 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2478
8547b010
EZ
24792011-10-19 Eli Zaretskii <eliz@gnu.org>
2480
2481 * xdisp.c (start_display): If the character at POS is displayed
2482 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2483 (try_window_reusing_current_matrix): If a line ends in a display
2484 vector or the next line starts in a display vector, continue
2485 redrawing the window even though the character position of
2486 start_row was reached.
8547b010
EZ
2487 (Bug#9771, part 2)
2488
4e948d15
CY
24892011-10-18 Chong Yidong <cyd@gnu.org>
2490
2491 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2492 with nobreak-char-display too.
2493
4787455f
EZ
24942011-10-18 Eli Zaretskii <eliz@gnu.org>
2495
2496 Fix part 3 of bug#9771.
2497 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2498 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2499 non-neutral characters if the current character is a paragraph
2500 separator (a.k.a. Newline). This avoids running the same
2501 expensive loop twice, once when we consume the preceding newline
2502 and the other time when the line actually needs to be displayed.
2503 Avoid the loop when we see neutrals on the base embedding level
2504 following a character whose directionality is the same as the
2505 paragraph's. This avoids running the expensive loop when a line
2506 ends in a long sequence of neutrals, like control characters.
2507 Add assertion against STRONG_AL type. Slightly rearrange code
2508 that determines the type of a neutral given the first non-neutral
2509 that follows it.
2510 (bidi_level_of_next_char): Set next_en_pos to zero when
2511 invalidating its info.
2512
2c91f553
EZ
25132011-10-17 Eli Zaretskii <eliz@gnu.org>
2514
2515 * xdisp.c (push_display_prop): Determine whether to record string
2516 or buffer position by IT->string, not by IT->method. Allow
2517 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2518 (move_it_vertically_backward): Don't look for character position
2519 immediately after the newline when in a continuation line.
2520 (Bug#9771, part 1)
2c91f553 2521
c7b08b0d
MR
25222011-10-15 Martin Rudalics <rudalics@gmx.at>
2523
2524 * window.c (coordinates_in_window): Rewrite and delabelize
2525 vertical border check. (Bug#5357) (Bug#9618)
2526
6b02f655
SM
25272011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2528
2529 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2530 errors in XSetWindowBorder (bug#9310).
2531
81d40c92
DA
25322011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2533
2534 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2535 avoid crash when xmalloc overrun checking is enabled.
2536
d4172c3b
EZ
25372011-10-13 Eli Zaretskii <eliz@gnu.org>
2538
2539 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2540 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2541 cursor motion with <left> and <right> arrow keys.
2542
2543 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2544 some callers set that themselves.
2545
b00eea75
EZ
25462011-10-12 Eli Zaretskii <eliz@gnu.org>
2547
2548 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2549 display string and the previous row comes from the same string and
2550 is empty. (Bug#9739) (Bug#9738)
2551
8fe012c4
SM
25522011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2553
2554 * doc.c (get_doc_string): Encode file name (bug#9735).
2555
0074aef2
EZ
25562011-10-12 Eli Zaretskii <eliz@gnu.org>
2557
79beb178
EZ
2558 * bidi.c (bidi_level_of_next_char):
2559 * xdisp.c (get_visually_first_element): Remove old incorrect
2560 comments regarding the Unicode Line Separator character.
2561
0074aef2
EZ
2562 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2563
6e4b3fbe
DA
25642011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2565
2566 * alloc.c (Fgc_status): Do not access beyond zombies array
2567 boundary if nzombies > MAX_ZOMBIES.
2568 * alloc.c (dump_zombies): Add missing format specifier.
2569
0324f3af
PE
25702011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2571
b5525cac
PE
2572 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2573 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2574
0324f3af
PE
2575 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2576 Some packages use them to denote characters with modifiers.
2577
e9b5f888
AS
25782011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2579
2580 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2581 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2582 matching a pp-number. Rename parameter var to var1.
2583
127827c0
SM
25842011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2585
2586 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2587
c8fd3bd0
GM
25882011-10-08 Glenn Morris <rgm@gnu.org>
2589
2590 * callint.c (Fcall_interactively): Give a more explicit error for the
2591 'c' case with a non-character input. (Bug#8479)
2592
352ec8ff
EZ
25932011-10-08 Eli Zaretskii <eliz@gnu.org>
2594
03669ccb
EZ
2595 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2596 lines.
7061c986
EZ
2597 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2598 lines that are hscrolled on the left.
03669ccb 2599
352ec8ff
EZ
2600 * dispnew.c (buffer_posn_from_coords): Account for a possible
2601 presence of header-line. (Bug#4426)
2602
a66cfb1c
SM
26032011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2604
6b02f655
SM
2605 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2606 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2607
7c5ee88e
PE
26082011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2609
2610 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2611 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2612 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2613 this makes Emacs dump core during garbage collection on rare
2614 occasions. sizeof is obviously inferior to offsetof here, so
2615 stick with offsetof.
2616 (GC_POINTER_ALIGNMENT): New macro.
2617 (mark_memory): Omit 3rd (offset) arg; caller changed.
2618 Don't assume EMACS_INT alignment is the same as pointer alignment.
2619
df1bbe5b
SM
26202011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2621
2622 * keyboard.c (read_key_sequence_remapped): New var.
2623 (read_key_sequence): Compute remapping in the right buffer.
2624 (command_loop_1): Use read_key_sequence's remapping directly.
2625
51553db6
SM
26262011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2627
32c1fffd
SM
2628 * dired.c (file_name_completion): Don't expand file name.
2629 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2630 before checking file name handler.
2631
51553db6
SM
2632 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2633 they've been requested explicitly (bug#9591).
2634
b6bd1599 26352011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2636
2637 * keymap.c (Fsingle_key_description): Use make_specified_string
2638 instead of build_string to build string from push_key_description.
2639 (Bug#5193)
2640
f701dc2a
PE
26412011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2642
4222c55d
PE
2643 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2644 This fixes a Y2038 bug on 64-bit hosts.
2645 * buffer.c (reset_buffer):
2646 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2647 (Fclear_buffer_auto_save_failure):
2648 Use 0, not -1, to represent an unset failure time, since time_t
2649 might not be signed.
2650
f701dc2a
PE
2651 Remove dependency on glibc malloc internals.
2652 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2653 Move back here from lisp.h, but with their new implementations.
2654 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2655 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2656 * charset.c (charset_table_init): New static var.
2657 (syms_of_charset): Use it instead of xmalloc. This removes a
2658 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2659 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2660 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2661 Move back to alloc.c.
2662 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2663 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2664
9ceebf39
JD
26652011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2666
2667 * nsterm.m (windowDidResize): Call x_set_window_size only when
2668 ns_in_resize is true. Otherwise set pixelwidth/height and
2669 call change_frame_size (Bug#9628).
2670
cb993c58
PE
26712011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2672
3930c88b
PE
2673 Port --enable-checking=all to Fedora 14 x86-64.
2674 * charset.c (syms_of_charset): Also account for glibc malloc's
2675 internal overhead when calculating the initial malloc maximum.
2676
cb993c58
PE
2677 Port --enable-checking=all to Fedora 14 x86.
2678 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2679 Move to lisp.h.
2680 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2681 (overrun_check_realloc, overrun_check_free):
2682 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2683 That way, xmalloc returns a properly-aligned pointer even if
2684 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2685 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2686 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2687 into account when calculating the initial malloc maximum.
2688 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2689 Move here from alloc.c, so that charset.c can use it too.
2690 Properly align; the old code wasn't right for common 32-bit hosts
2691 when configured with --enable-checking=all.
2692 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2693 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2694
31bed486
EZ
26952011-09-29 Eli Zaretskii <eliz@gnu.org>
2696
04c70788 2697 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2698 use EDOM.
2699
fbcaa2f3
EZ
27002011-09-28 Eli Zaretskii <eliz@gnu.org>
2701
2702 * xdisp.c (compute_display_string_end): If there's no display
2703 string at CHARPOS, return -1.
2704
2705 * bidi.c (bidi_fetch_char): When compute_display_string_end
2706 returns a negative value, treat the character as a normal
2707 character not covered by a display string. (Bug#9624)
2708
a239d4e9
JB
27092011-09-28 Juanma Barranquero <lekktu@gmail.com>
2710
2711 * lread.c (Fread_from_string): Fix typo in docstring.
2712
88652fd5
EZ
27132011-09-27 Eli Zaretskii <eliz@gnu.org>
2714
2715 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2716 newline, reseat the iterator instead of bidi-iterating there one
2717 character at a time. (Bug#9610)
32c1fffd
SM
2718 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2719 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2720
ed497dd4
AS
27212011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2722
2723 * lread.c (readevalloop): Use correct code for NBSP.
2724 (read1): Likewise. (Bug#9608)
2725
b2bf61aa
MA
27262011-09-25 Michael Albinus <michael.albinus@gmx.de>
2727
2728 * dbusbind.c (Fdbus_register_signal): When service is not
2729 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2730
32bbb17c
GM
27312011-09-25 Glenn Morris <rgm@gnu.org>
2732
2733 * buffer.c (truncate-lines): Doc fix.
2734
94e0933e
CY
27352011-09-24 Chong Yidong <cyd@stupidchicken.com>
2736
2737 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2738 (Fset_window_next_buffers): Doc fix.
2739
cddde921
GM
27402011-09-24 Glenn Morris <rgm@gnu.org>
2741
2742 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2743
1260aef1
PE
27442011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2745
25b4bfa0
PE
2746 Fix minor problems found by static checking.
2747 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2748 * indent.c (Fvertical_motion): Fix == vs = typo.
2749
e3cbd34b
EZ
27502011-09-24 Eli Zaretskii <eliz@gnu.org>
2751
a66cfb1c
SM
2752 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2753 Default value is now t. Doc fix.
6bf7006f 2754
e3cbd34b 2755 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2756 logic when moving up, not only when moving down. Fix the
e3cbd34b 2757 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2758 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2759
2760 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2761 CHARPOS is covered by a display string which includes newlines.
2762 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2763 is covered by a display string with embedded newlines.
2764
a3de0cbd
MA
27652011-09-24 Michael Albinus <michael.albinus@gmx.de>
2766
2767 * dbusbind.c (Fdbus_register_signal): Add match rule to
2768 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2769 (Fdbus_register_method, Vdbus_registered_objects_table):
2770 Fix docstring.
a3de0cbd 2771
b260039d
JM
27722011-09-24 Jim Meyering <meyering@redhat.com>
2773
32c1fffd 2774 do not ignore write error for any output size
b260039d
JM
2775 The previous change was incomplete.
2776 While it makes emacs --batch detect the vast majority of stdout
2777 write failures, errors were still ignored whenever the output size is
2778 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2779 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2780 && echo FAIL: ignored write error
2781 FAIL: ignored write error
2782 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2783 && echo FAIL: ignored write error
2784 FAIL: ignored write error
2785 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2786
8eca8a7c
AS
27872011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2788
2789 * emacs.c (Fkill_emacs): In noninteractive mode exit
2790 non-successfully if a write error occurred on stdout. (Bug#9574)
2791
3341db62
EZ
27922011-09-21 Eli Zaretskii <eliz@gnu.org>
2793
2794 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2795 the xassert test.
2796
2797 * dispextern.h (struct it): Update the comment documenting what
2798 can it->OBJECT be.
2799
8c203dbf
EZ
28002011-09-20 Eli Zaretskii <eliz@gnu.org>
2801
2802 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2803 a display string, extend search for cursor position to end of row.
2804 (find_row_edges): If the row ends in a newline from a display
2805 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2806 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2807 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2808 non-empty line. Fixes confusing cursor motion with arrow keys at
2809 the beginning of a line that starts with whitespace.
8c203dbf 2810
a4824228
LMI
28112011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2812
2813 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2814 (bug#9493).
2815
33ed493b
CY
28162011-09-18 Chong Yidong <cyd@stupidchicken.com>
2817
2818 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2819 boolean (Bug#9154).
2820
56cd55c8
EZ
28212011-09-18 Eli Zaretskii <eliz@gnu.org>
2822
2823 * xdisp.c (display_line): Record maximum and minimum buffer
2824 positions even if no glyphs were produced (e.g., by a zero-width
2825 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2826 buffer positions that will be removed from the glyph row because
2827 they don't fit.
c02dcedf
EZ
2828 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2829 column is beyond frame width: don't subtract 1 "pixel" when
2830 computing width of the stretch.
3e62b7e0
EZ
2831 (reseat_at_next_visible_line_start): Undo the change made on
2832 2011-09-17 that saved paragraph information and restored it after
2833 the call to `reseat'. (Bug#9545)
56cd55c8 2834
5ed99d36 28352011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2836
2837 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2838 and turn window cursor on if cleared (Bug#9415).
2839
5ed99d36 28402011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2841
2842 * search.c (boyer_moore): Take unibyte characters from pattern
2843 literally. (Bug#9458)
2844
9bade7b2
EZ
28452011-09-18 Eli Zaretskii <eliz@gnu.org>
2846
2847 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2848
e5e9d610
PE
28492011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2850
87e4427a
PE
2851 Fix minor problem found by static checking.
2852 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2853 initialized, to pacify gcc -Wuninitialized.
2854
e5e9d610
PE
2855 * fileio.c: Report proper errno when syscall falls.
2856 (Finsert_file_contents): Save and restore errno,
2857 so that report_file_error outputs the correct diagnostic.
2858 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2859
a1674f0b
EZ
28602011-09-18 Eli Zaretskii <eliz@gnu.org>
2861
2862 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2863
fbfb6dd4
EZ
28642011-09-17 Eli Zaretskii <eliz@gnu.org>
2865
2866 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2867 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2868
bb187662
EZ
28692011-09-17 Eli Zaretskii <eliz@gnu.org>
2870
1137e8b8 2871 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2872 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2873
2874 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2875 (bidi_find_paragraph_start): Search back for paragraph beginning
2876 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2877 (bidi_move_to_visually_next): Only trigger paragraph-related
2878 computations when the last character is a newline or at EOB, not
2879 just any NEUTRAL_B. (Bug#9470)
2880
bb187662
EZ
2881 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2882 truncated lines if point is covered by a display string. (Bug#9524)
2883
2e621251
PE
28842011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2885
2886 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2887 (cons_to_x_long): New function.
2888 (lisp_data_to_selection_data): Use it. Correct the test for
2889 short-versus-long data; it was negated. Break out of vector
2890 loop, for efficiency, when a long datum is discovered.
2891
91a15bc6
SM
28922011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2893
2894 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2895
b41c3a35
EZ
28962011-09-16 Eli Zaretskii <eliz@gnu.org>
2897
2898 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2899 GCC PR/17406) by declaring this function with external scope.
2900
7812ba2d
PE
29012011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2902
2903 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2904 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2905
cf7edc2a
AS
29062011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2907
2908 * editfns.c (Fformat): Correctly handle text properties on "%%".
2909
bd01620e
EZ
29102011-09-15 Eli Zaretskii <eliz@gnu.org>
2911
2912 * xterm.c (x_draw_composite_glyph_string_foreground):
2913 * w32term.c (x_draw_composite_glyph_string_foreground):
2914 * term.c (encode_terminal_code):
2915 * composite.c (composition_update_it, get_composition_id):
2916 * xdisp.c (get_next_display_element)
2917 (fill_composite_glyph_string): Add comments about special meaning
2918 of TAB characters in a composition.
2919
a02719a3
PE
29202011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2921
2922 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2923 This occurs when processing a multibyte format.
2924 Problem reported by Wolfgang Jenker.
a02719a3 2925
72589a3c
JB
29262011-09-15 Johan Bockgård <bojohan@gnu.org>
2927
2928 * xdisp.c (try_cursor_movement): Only check for exact match if
2929 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2930
1c14176c
PE
29312011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2932
2933 Remove unused external symbols.
2934 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2935 * xdisp.c (calc_pixel_width_or_height): Now static.
2936 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2937 * indent.c (check_display_width):
2938 * w32term.c: Fix comment to match code.
2939 * xterm.c, xterm.h (x_catching_errors): Remove.
2940
d2eea5b5
PE
29412011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2942
2943 * xselect.c: Use signed conversions more consistently (Bug#9498).
2944 (selection_data_to_lisp_data): Assume incoming selection data are
2945 signed integers, not unsigned. This is to be consistent with
2946 outgoing selection data, which was modified to use signed integers
2947 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2948 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2949 expects long, not unsigned long.
2950
46888499
EZ
29512011-09-14 Eli Zaretskii <eliz@gnu.org>
2952
2953 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2954 computation of loop end. Reported by Johan Bockgård
2955 <bojohan@gnu.org>.
2956
ef8ef9fb
CY
29572011-09-13 Chong Yidong <cyd@stupidchicken.com>
2958
2959 * frame.c (Fother_visible_frames_p): Function deleted.
2960
fa819fed
EZ
29612011-09-12 Eli Zaretskii <eliz@gnu.org>
2962
2963 * indent.c (compute_motion): Process display vector front to back
2964 rather than the other way around. (Bug#2496)
2965
2ba8e008
SM
29662011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2967
2968 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2969
20f53c69
CY
29702011-09-11 Chong Yidong <cyd@stupidchicken.com>
2971
2972 * minibuf.c (Fread_from_minibuffer): Doc fix.
2973
d562d7a4
EZ
29742011-09-11 Eli Zaretskii <eliz@gnu.org>
2975
2976 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2977 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2978
1c4d7f3d
LMI
29792011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2980
2981 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2982 value for non-existent files.
2983
b885bf36
EZ
29842011-09-11 Eli Zaretskii <eliz@gnu.org>
2985
2986 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2987 set its "size" to -1. This will set the modtime_size field of
2988 the corresponding buffer to -1, which is what
2989 verify-visited-file-modtime expects for files that do not exist.
2990 (Bug#9139)
2991
6612f0bf
PE
29922011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2993
2994 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2995 here ...
2996 * lisp.h: ... from here. push_key_description is no longer
2997 defined in keyboard.c, so its declaration should not be in
2998 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2999 logically belongs with push_key_description.
3000
dfb3f755
PE
30012011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3002
3003 * buffer.h: Include <sys/types.h> instead of <time.h>.
3004 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3005 Problem reported by Herbert J. Skuhra.
3006
3134906c
LMI
30072011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3008
3009 * xml.c (parse_region): Make the parsing work for
3010 non-comment-starting XML files again (bug#9144).
3011
8d903f4e
AS
30122011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3013
3014 * image.c (gif_load): Fix calculation of bottom and right corner.
3015 (Bug#9468)
3016
80ad64f4
EZ
30172011-09-10 Eli Zaretskii <eliz@gnu.org>
3018
3019 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3020 redisplay in small windows.
3021
208a048d
EZ
30222011-09-09 Eli Zaretskii <eliz@gnu.org>
3023
3024 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3025
9b1c252e
MR
30262011-09-08 Martin Rudalics <rudalics@gmx.at>
3027
3028 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3029 Operate on live windows only.
3030
2949f33b
JB
30312011-09-08 Juanma Barranquero <lekktu@gmail.com>
3032
3033 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3034
e08dcafd
EZ
30352011-09-07 Eli Zaretskii <eliz@gnu.org>
3036
3037 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3038 only under bidi iteration.
3039
115b96bd
JD
30402011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3041
3042 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3043
c8199d0f
PE
30442011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3045
3046 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3047 Without this fix, the command to link temacs failed due to an
3048 undefined symbol __builtin_isnan. This is because
3049 /usr/include/iso/math_c99.h #defines isnan(x) to
3050 __builtin_isnan(x), but the bundled gcc, which identifies itself
3051 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3052 a __builtin_isnan.
3053 * floatfns.c (isnan): #undef, and then #define to a clone of
3054 what's in data.c.
3055 (Fisnan): Always define, since it's always available now.
3056 (syms_of_floatfns): Always define isnan at the Lisp level.
3057
e39b275c 30582011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
3059
3060 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3061
b2db44d9 30622011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 3063
f4af5137 3064 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
3065 The previous code assumed that file offsets (off_t values) fit in
3066 EMACS_INT variables, which is not true on typical 32-bit hosts.
3067 The code messed up by falsely reporting buffer overflow in cases
3068 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3069 when "big" contains more than 2**29 bytes, even though this
3070 inserts just one byte and does not overflow the buffer.
3071 (Finsert_file_contents): Store file offsets as off_t
3072 values, not as EMACS_INT values. Check for overflow when
3073 converting between EMACS_INT and off_t. When checking for
3074 buffer overflow or for overlap, take the offsets into account.
3075 Don't use EMACS_INT for small values where int suffices.
3076 When checking for overlap, fix a typo: ZV was used where
3077 ZV_BYTE was intended.
3078 (Fwrite_region): Don't assume off_t fits into 'long'.
3079 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3080
ecfc0a49
MA
30812011-09-05 Michael Albinus <michael.albinus@gmx.de>
3082
3083 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3084
6511acf2 30852011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 3086
0999621a 3087 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
3088
3089 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 3090 (esprintf, exprintf, evxprintf): New functions.
62f19c19 3091 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 3092 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
3093 (modify_event_symbol): Do not assume that the length of
3094 name_alist_or_stem is safe to alloca and fits in int.
3095 (Fexecute_extended_command): Likewise for function name and binding.
3096 (Frecursion_depth): Wrap around reliably on integer overflow.
3097 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3098 since some callers pass EMACS_INT values.
3099 (Fsingle_key_description): Don't crash if symbol name contains more
3100 than MAX_ALLOCA bytes.
3101 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3102 (get_minibuffer): Arg is now EMACS_INT, not int.
3103 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 3104 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
3105 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3106
2be7d702
PE
3107 * dbusbind.c (signature_cat): New function.
3108 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
3109 Do not overrun buffer; instead, report string overflow.
3110
9d1df220
PE
3111 * dispnew.c (add_window_display_history): Don't overrun buffer.
3112 Truncate instead; this is OK since it's just a log.
3113
33ef5c64
PE
3114 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3115 even if the time zone offset is outlandishly large.
3116 Don't mishandle offset == INT_MIN.
3117
66c6fdd5
PE
3118 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3119 when creating daemon; the previous buffer-overflow check was incorrect.
3120
d749b01b
PE
3121 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3122 which has the guts of the old verror function.
3123
b5cd1905
PE
3124 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3125 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3126
6e1a67fb
PE
3127 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3128 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 3129 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 3130 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
3131 length of string rather than counting it via multiple sprintfs;
3132 that's simpler and more reliable.
c21721cc
PE
3133 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3134 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3135 sprintf, in case result does not fit in int.
3136
c57b67fc
PE
3137 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3138 (fontset_from_font): Print it.
3139
8a401434
PE
3140 * frame.c (tty_frame_count): Now printmax_t, not int.
3141 (make_terminal_frame, set_term_frame_name): Print it.
3142 (x_report_frame_params): In X, window IDs are unsigned long,
3143 not signed long, so print them as unsigned.
3144 (validate_x_resource_name): Check for implausibly long names,
3145 and don't assume name length fits in 'int'.
3146 (x_get_resource_string): Don't blindly alloca invocation name;
3147 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3148 not fit in int.
3149
6e1a67fb
PE
3150 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3151 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
3152 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3153
0df02bf3
PE
3154 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3155 Use esprintf, not sprintf, in case result does not fit in int.
3156
48e30793
PE
3157 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3158 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3159 it as a large positive number.
3160 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3161 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3162
a66ff6d8
PE
3163 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3164 in case result does not fit in int.
3165
aca216ff
PE
3166 * print.c (float_to_string): Detect width overflow more reliably.
3167 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3168 buffer overrun. Don't assume list length fits in 'int'. Treat
3169 print length of 0 as 0, not as infinity; to be consistent with other
3170 uses of print length in this function. Don't overflow print length
3171 index. Don't assume hash table size fits in 'long', or that
3172 vectorlike size fits in 'unsigned long'.
3173
31c286f7
PE
3174 * process.c (make_process): Use printmax_t, not int, to format
3175 process-name gensyms.
3176
55e5faa1
PE
3177 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3178
80f2e268
PE
3179 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3180 to avoid potential buffer overrun.
3181
670741ab
PE
3182 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3183 if X resource line is longer than 512 bytes.
3184
b7163a50
PE
3185 * xfns.c (x_window): Make sprintf buffer a bit bigger
3186 to avoid potential buffer overrun.
3187
ae58ff1f
PE
3188 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3189
c43c8a6a
PE
3190 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3191
3f8236f4
PE
31922011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3193
53e9fe90 3194 Integer overflow fixes for scrolling, etc.
6511acf2
PE
3195 Without these, Emacs silently mishandles large integers sometimes.
3196 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
3197 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3198
6511acf2
PE
3199 * xdisp.c (try_window_id): Check Emacs fixnum range before
3200 converting to 'int'.
806add1d 3201
6511acf2 3202 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
3203 Check that an Emacs fixnum is in range before assigning it to 'int'.
3204 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3205 values converted from Emacs fixnums.
3206 (Frecenter): Don't wrap around a line count if it is out of 'int'
3207 range; instead, treat it as an extreme value.
3208 (Fset_window_configuration, compare_window_configurations):
3209 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3210
6511acf2
PE
3211 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3212 that can exceed INT_MAX. Check that EMACS_INT value is in range
3213 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
3214 (match_limit): Don't assume that a fixnum can fit in 'int'.
3215
6511acf2 3216 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
3217 exceed INT_MAX.
3218
6511acf2 3219 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
3220 (Fvertical_motion): Don't wrap around LINES values that don't fit
3221 in 'int'. Instead, treat them as extreme values. This is good
3222 enough for windows, which can't have more than INT_MAX lines anyway.
3223
fcb901a7
LMI
32242011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3225
0f2f6b6d
LMI
3226 * Require libxml/parser.h to avoid compilation warning.
3227
fcb901a7
LMI
3228 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3229
3230 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3231 since this reportedly can destroy thread storage.
3232
6e20a0d4
CY
32332011-08-30 Chong Yidong <cyd@stupidchicken.com>
3234
3235 * syntax.c (find_defun_start): Update all cache variables if
3236 exiting early (Bug#9401).
3237
148ae00e
EZ
32382011-08-30 Eli Zaretskii <eliz@gnu.org>
3239
f6cfbd8f
EZ
3240 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3241
148ae00e
EZ
3242 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3243 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3244 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3245
3246 * term.c (tty_append_glyph): New function.
3247 (produce_stretch_glyph): Static function and its prototype deleted.
3248
a66cfb1c
SM
3249 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3250 Add prototypes.
148ae00e 3251
c4a07a4c
PE
32522011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3253
3254 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3255 when checking :margin (Bug#9390).
3256 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 3257 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
3258 so that the name doesn't mislead. All uses changed.
3259
6bc8cd65
JB
32602011-08-28 Johan Bockgård <bojohan@gnu.org>
3261
3262 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3263 set_tty_hooks.
3264
dca4927e
EZ
32652011-08-27 Eli Zaretskii <eliz@gnu.org>
3266
3267 * xdisp.c (move_it_to): Don't bail out early when reaching
3268 position beyond to_charpos, if we are scanning backwards.
3269 (move_it_vertically_backward): When DY == 0, make sure we get to
3270 the first character in the line after the newline.
3271
f2cad773
PE
32722011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3273
3274 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3275 (ccl_driver): Do not generate an out-of-range pointer.
3276 (Fccl_execute_on_string): Remove unnecessary check for
3277 integer overflow, noted by Stefan Monnier in
3278 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3279 Remove a FIXME that didn't need fixing.
3280 Simplify the newly-introduced buffer reallocation code.
3281
0cae2cdb
JB
32822011-08-27 Juanma Barranquero <lekktu@gmail.com>
3283
3284 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3285
5fc295a4 32862011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 3287
70c60eb2 3288 Integer and memory overflow issues (Bug#9196).
726e0ab1 3289
d31850da
PE
3290 * doc.c (get_doc_string): Rework so that
3291 get_doc_string_buffer_size is the actual buffer size, rather than
3292 being 1 less than the actual buffer size; this makes xpalloc more
3293 convenient.
3294
a69fbedb
PE
3295 * image.c (x_allocate_bitmap_record, cache_image):
3296 * xselect.c (Fx_register_dnd_atom):
3297 Simplify previous changes by using xpalloc.
3298
fe5c5d37
PE
3299 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3300 since either will do and ptrdiff_t is convenient with xpalloc.
3301
0065d054
PE
3302 * charset.c (charset_table_size)
3303 (struct charset_sort_data.priority): Now ptrdiff_t.
3304 (charset_compare): Don't overflow if priorities differ greatly.
3305 (Fsort_charsets): Don't assume list length fits in int.
3306 Check for size-calculation overflow when allocating sort data.
3307 (syms_of_charset): Allocate an initial charset table that is
3308 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3309
3310 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3311
3312 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3313 The actual value is always <= INT_MAX, and leaving it unsigned made
3314 overflow checking harder.
3315
3316 * dispextern.h (struct glyph_matrix.rows_allocated)
3317 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3318 with xpalloc. The values are still always <= INT_MAX.
3319
3320 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3321
3322 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3323 (SAFE_NALLOCA): New macro.
3324
3325 * region-cache.c (struct boundary.pos, find_cache_boundary)
3326 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3327 (set_cache_region, invalidate_region_cache)
3328 (revalidate_region_cache, know_region_cache, region_cache_forward)
3329 (region_cache_backward, pp_cache):
3330 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3331 so that ptrdiff_t * can be passed to xpalloc.
3332 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3333 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3334 (pp_cache): Don't assume cache_len fits in int.
3335 * region-cache.h: Adjust extern decls to match.
3336
3337 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3338 EMACS_INT, since either will do, for xpalloc.
3339
3340 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3341 (xnmalloc, xnrealloc, xpalloc): New functions.
3342
726e0ab1
PE
3343 * bidi.c (bidi_shelve_header_size): New constant.
3344 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3345 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3346
51f30bc5 3347 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
3348 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3349 (overlay_strings):
3350 Don't update size of array until after memory allocation succeeds,
3351 because xmalloc/xrealloc may not return.
0065d054
PE
3352 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3353 now that we have proper integer overflow checking.
3354 (record_overlay_string, overlay_strings): Catch overflows when
3355 calculating size of overlay_str_buf.
726e0ab1 3356
0065d054
PE
3357 * callproc.c (Fcall_process): Check for size overflow when
3358 calculating size of args2.
3359 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3360 Normally we prefer signed values, but sticking with ptrdiff_t would
3361 require adding more-complicated checks.
726e0ab1
PE
3362
3363 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3364 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3365 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3366 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3367
3368 * character.c (Fstring): Check for size-calculation overflow.
3369
3370 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3371 unnecessary integer overflow. Check for size overflow.
3372 (encode_coding_object): Don't update size until xmalloc succeeds.
3373
3374 * composite.c (get_composition_id): Check for overflow in glyph
3375 length calculations.
3376
3377 Integer and memory overflow fixes for display code.
3378 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3379 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3380 (scrolling_window): Check for overflow in size calculations.
3381 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3382 Don't assume glyph table len fits in int.
3383 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3384 (row_table_size): Now ptrdiff_t, not int.
3385 (scrolling_window): Avoid overflow in size calculations.
3386 Don't update size until allocation succeeds.
3387 * fns.c (concat): Check for overflow in size calculations.
3388 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3389 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3390 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3391
3392 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3393 (get_doc_string): Check for size calculation overflow.
3394 Don't update size until allocation succeeds.
3395 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3396 EMACS_INT, where ptrdiff_t will do.
3397 (Fsubstitute_command_keys): Check for string overflow.
3398
3399 * editfns.c (set_time_zone_rule): Don't assume environment length
3400 fits in int.
3401 (message_length): Now ptrdiff_t, not int.
3402 (Fmessage_box): Don't update size until allocation succeeds.
3403 Don't assume message length fits in int.
3404 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3405
0065d054
PE
3406 * emacs.c (main): Do not reallocate argv, since there is a null at
3407 the end that can be overwritten, and this way there's no need to
3408 worry about size-calculation overflow.
3409 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3410
3411 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3412 alloc succeeds.
3413 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3414
3415 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3416 (x_set_scroll_bar_width, x_figure_window_size):
3417 Check for integer overflow.
3418 (x_set_alpha): Do not assume XINT fits in int.
3419
3420 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3421 This is for the members text_lines, text_cols, total_lines, total_cols,
3422 where the system imposes an 'int' limit.
3423
3424 * fringe.c (Fdefine_fringe_bitmap):
3425 Don't update size until alloc works.
3426
3427 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3428 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3429
3430 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3431 Check for size-calculation overflow.
3432 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3433 do, as we prefer signed integers.
3434 (id_to_widget.max_size, id_to_widget.used)
3435 (xg_store_widget_in_map, xg_remove_widget_from_map)
3436 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3437 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3438 Use and return ptrdiff_t, not int.
3439 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3440 * gtkutil.h: Change prototypes to match the above.
3441
3442 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3443 are duplicate now that they've been promoted to lisp.h.
3444 (x_allocate_bitmap_record, x_alloc_image_color)
3445 (make_image_cache, cache_image, xpm_load):
3446 Don't update size until alloc is done.
3447 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3448 (x_detect_edges):
3256efce 3449 Check for size calculation overflow.
726e0ab1
PE
3450 (ct_colors_allocated_max): New constant.
3451 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3452 overflow.
3256efce 3453
726e0ab1
PE
3454 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3455 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3456 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3457 Use ptrdiff_t, not int, to count maps.
3458 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3459 calculations. Don't update size until allocation succeeds.
3460 Redo calculations to avoid overflow.
726e0ab1
PE
3461 * keyboard.h: Change prototypes to match the above.
3462
3463 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3464 to count maps.
3465 (current_minor_maps): Check for size calculation overflow.
3466 * keymap.h: Change prototypes to match the above.
3467
3468 * lread.c (read1, init_obarray): Don't update size until alloc done.
3469
3470 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3471 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3472
726e0ab1
PE
3473 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3474 Now ptrdiff_t, not int.
3475 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3476 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3477
3478 * process.c (Fnetwork_interface_list): Check for overflow
3479 in size calculation.
3480
3481 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3482
3483 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3484 overflow. Don't bother calling xmalloc when xrealloc will do.
3485
3486 * search.c (Freplace_match): Check for size calculation overflow.
3487 (Fset_match_data): Don't assume list lengths fit in 'int'.
3488
3489 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3490 for command line length. Do not attempt to address one before the
3491 beginning of an array, as that's not portable.
3492
3493 * term.c (max_frame_lines): Remove; unused.
3494 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3495 not int.
3496 (encode_terminal_code, calculate_costs): Check for size
3497 calculation overflow.
3498 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3499 table lengths and related sizes. Don't update size until alloc
3500 done. Redo calculations to avoid overflow.
3501 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3502
3503 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3504 subtracting pointers.
3505 (gobble_line): Check for overflow more carefully. Don't update size
3506 until alloc done.
3507
3508 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3509 Don't update size until alloc done.
3510 Redo size calculations to avoid overflow.
3511 Check for size calculation overflow.
0065d054 3512 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3513
3514 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3515 Use ptrdiff_t, not int, for sizes.
3516 (store_mode_line_noprop_char): Don't update size until alloc done.
3517
0065d054
PE
3518 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3519 Use ptrdiff_t, not int, for sizes.
3520 (Finternal_make_lisp_face, cache_face):
3521 Check for size calculation overflow.
3522 (cache_face): Treat size calculation overflows as if they were
3523 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3524
3525 * xfns.c (x_encode_text, x_set_name_internal)
3526 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3527 sizes, since they can exceed INT_MAX in size. Check for size
3528 calculation overflow.
3529
0065d054
PE
3530 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3531 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3532 Don't update size until alloc done.
3533
0065d054 3534 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3535 as sprintf is limited to int lengths.
1d526e2f 3536
252c5ee1
PE
3537 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3538 (X_LONG_MIN): New macros.
864d7ce7
PE
3539 Use them to make the following changes clearer.
3540 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3541 This change doesn't affect the value now, but it may help remind
3542 future maintainers not to raise the value too much later.
3543 (SELECTION_QUANTUM): Remove, replacing with ...
3544 (selection_quantum): ... new function, which avoids overflow.
3545 All uses changed.
3546 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3547 assumption that selection length fits in 'int'.
3548 (x_reply_selection_request, x_handle_selection_request)
3549 (x_get_window_property, receive_incremental_selection)
3550 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3551 (lisp_data_to_selection_data, clean_local_selection_data):
3552 Use ptrdiff_t, not int, to record length of selection.
3553 (x_reply_selection_request, x_get_window_property)
3554 (receive_incremental_selection, x_property_data_to_lisp):
3555 Redo calculations to avoid overflow.
3556 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3557 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3558 something.
3559 (x_get_window_property, receive_incremental_selection)
3560 (lisp_data_to_selection_data, x_property_data_to_lisp):
3561 Check for size-calculation overflow.
3562 (x_get_window_property, receive_incremental_selection)
3563 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3564 Don't store size until memory allocation succeeds.
3565 (x_get_window_property): Plug memory leak on memory exhaustion.
3566 Don't double-block input; malloc is safe here. Don't assume 2**34
3567 - 4 fits in unsigned long. Add an xassert to check
3568 XGetWindowProperty overflow. Be more careful about overflow
3569 calculations, and distinguish size from memory overflow better.
3570 (receive_incremental_selection): When tracing, don't assume
3571 unsigned int is less than INT_MAX.
3572 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3573 harmful) conversions of unsigned short to int.
3574 (lisp_data_to_selection_data): Don't assume that integers
3575 in the range -65535 through -1 fit in an X unsigned short.
3576 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3577 result parameters unless successful. Rely on cons_to_unsigned
3578 to report problems with elements; the old code wasn't right anyway.
3579 (x_check_property_data): Check for int overflow; we cannot use
3580 a wider type due to X limits.
3581 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3582
726e0ab1 3583 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3584
0065d054
PE
3585 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3586 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3587 (x_color_cells): Don't store size until memory allocation succeeds.
3588 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3589 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3590 (x_term_init): Don't assume length fits in int (sprintf is limited
3591 to int size).
bc18e09d 3592
ebfa62c0
PE
3593 Use ptrdiff_t for composition IDs.
3594 * character.c (lisp_string_width):
3595 * composite.c (composition_table_size, n_compositions)
3596 (get_composition_id, composition_gstring_from_id):
3597 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3598 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3599 * window.c (Frecenter):
3600 Use ptrdiff_t, not int, for composition IDs.
3601 * composite.c (get_composition_id): Check for integer overflow.
3602 * composite.h: Adjust prototypes to match the above changes.
3603
d3411f89
PE
3604 Use ptrdiff_t for hash table indexes.
3605 * category.c (hash_get_category_set):
3606 * ccl.c (ccl_driver):
3607 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3608 * coding.c (coding_system_charset_list, detect_coding_system):
3609 * coding.h (struct coding_system.id):
3610 * composite.c (get_composition_id, gstring_lookup_cache):
3611 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3612 * image.c (xpm_get_color_table_h):
3613 * lisp.h (hash_lookup, hash_put):
3614 * minibuf.c (Ftest_completion):
3615 Use ptrdiff_t for hash table indexes, not int (which is too
3616 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3617 32-bit --with-wide-int hosts).
3618
e097a6fa
PE
3619 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3620 Add a FIXME comment about memory leaks.
3621 (syms_of_charset): Don't assume xmalloc returns.
3622
5637687f
PE
3623 Don't assume that stated character widths fit in int.
3624 * character.c (Fchar_width, c_string_width, lisp_string_width):
3625 * character.h (CHAR_WIDTH):
3626 * indent.c (MULTIBYTE_BYTES_WIDTH):
3627 Use sanitize_char_width to avoid undefined and/or bad behavior
3628 with outlandish widths.
a66cfb1c 3629 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3630 now that we have two such functions. All uses changed.
3631 (sanitize_char_width): New inline function.
3632
a2271ba2
PE
3633 Don't assume that tab-width fits in int.
3634 * character.h (sanitize_width): New inline function.
3635 (SANE_TAB_WIDTH): New macro.
3636 (ASCII_CHAR_WIDTH): Use it.
3637 * indent.c (sane_tab_width): Remove. All uses replaced by
3638 SANE_TAB_WIDTH (current_buffer).
3639 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3640
18c52557
PE
3641 * fileio.c: Integer overflow issues with file modes.
3642 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3643
caeeedc1
PE
3644 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3645 Remove unreachable code.
3646 (read_hex, load_charset_map_from_file): Check for integer overflow.
3647
6df6ae42 3648 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3649 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3650 (x_send_scroll_bar_event): Likewise. Check that the size does not
3651 exceed limits imposed by XClientMessageEvent, as well as the usual
3652 ptrdiff_t and size_t limits.
3653
b13995db
PE
3654 * keyboard.c: Overflow, signedness and related fixes.
3655 (make_lispy_movement): Use same integer type in forward decl
3656 that is used in the definition.
3657 (read_key_sequence, keyremap_step):
3658 Change bufsize argument back to int, undoing my 2011-03-30 change.
3659 We prefer signed types, and int is wide enough here.
3660 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3661 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3662 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3663 length, not size_t. Use ptrdiff_t for index, not int.
3664 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3665 possibility of integer overflow.
3666
13464394
PE
3667 Overflow, signedness and related fixes for images.
3668
3669 * dispextern.h (struct it.stack[0].u.image.image_id)
3670 (struct_it.image_id, struct image.id, struct image_cache.size)
3671 (struct image_cache.used, struct image_cache.ref_count):
3672 * gtkutil.c (update_frame_tool_bar):
3673 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3674 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3675 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3676 * nsmenu.m (update_frame_tool_bar):
3677 * xdisp.c (calc_pixel_width_or_height):
3678 * xfns.c (image_cache_refcount):
3679 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3680 on typical 64-bit hosts.
3681
3682 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3683 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3684 Omit unnecessary casts to int.
3685 (parse_image_spec): Check that integers fall into 'int' range
3686 when the callers expect that.
3687 (image_ascent): Redo ascent calculation to avoid int overflow.
3688 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3689 (lookup_image): Remove unnecessary tests.
3690 (xbm_image_p): Locals are now of int, not EMACS_INT,
3691 since parse_image_check makes sure they fit into int.
3692 (png_load, gif_load, svg_load_image):
3693 Prefer int to unsigned where either will do.
3694 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3695 old tiff_error_handler and tiff_warning_handler.
3696 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3697 stack buffer overflows. It uses only the features of vsnprintf
3698 that are common to both POSIX and native Microsoft.
3699 (tiff_error_handler, tiff_warning_handler): Use it.
3700 (tiff_load, gif_load, imagemagick_load_image):
3701 Don't assume :index value fits in 'int'.
3702 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3703 (imagemagick_load_image): Check that crop parameters fit into
3704 the integer types that MagickCropImage accepts. Don't assume
3705 Vimagemagick_render_type has a nonnegative value. Don't assume
3706 size_t fits in 'long'.
3707 (gs_load): Use printmax_t to print the widest integers possible.
3708 Check for integer overflow when computing image height and width.
3709
c11821d4
EZ
37102011-08-26 Eli Zaretskii <eliz@gnu.org>
3711
3712 * xdisp.c (redisplay_window): Don't force window start if point
3713 will be invisible in the resulting window. (Bug#9324)
3714
0c95fcf7
EZ
37152011-08-25 Eli Zaretskii <eliz@gnu.org>
3716
3717 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3718 the display spec is of the form `(space ...)'.
3719 (handle_display_spec): Return the value returned by
3720 handle_single_display_spec, not just 1 or zero.
3721 (handle_single_display_spec): If the display spec is of the form
3722 `(space ...)', and specifies display in the text area, return 2
3723 rather than 1.
fee65a97 3724 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3725 accurately, and prefer exact match for point under bidi.
3726 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3727
3728 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3729 into disp_prop; all users changed.
3730
3731 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3732 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3733 for the text covered by the display property.
3734
e4ed06f1
CY
37352011-08-25 Chong Yidong <cyd@stupidchicken.com>
3736
3737 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3738 Change return value to nil.
3739 (Frecord_buffer): Delete unused function.
3740
f67cdd7f
EZ
37412011-08-24 Eli Zaretskii <eliz@gnu.org>
3742
5980d4c6
EZ
3743 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3744 buffers, return left-to-right.
8610fe8b
EZ
3745 (set_cursor_from_row): Consider candidate row a win if its glyph
3746 represents a newline and point is on that newline. Fixes cursor
3747 positioning on the newline at EOL of R2L text within L2R
3748 paragraph, and vice versa.
3749 (try_cursor_movement): Check continued rows, in addition to
3750 continuation rows. Fixes unwarranted scroll when point enters a
3751 continued line of R2L text within an L2R paragraph, or vice versa.
3752 (cursor_row_p): Consider the case of point being equal to
3753 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3754 from the end of a short line to the beginning of a continued line
3755 of R2L text within L2R paragraph.
3756 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3757 composed characters.
5980d4c6 3758
f67cdd7f
EZ
3759 * bidi.c (bidi_check_type): Use xassert.
3760 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3761 members.
3762
bca633fb
EZ
37632011-08-23 Eli Zaretskii <eliz@gnu.org>
3764
3765 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3766 a character.
3767
4a5885a7
CY
37682011-08-23 Chong Yidong <cyd@stupidchicken.com>
3769
3770 * nsfont.m (ns_otf_to_script): Fix typo.
3771
0902a04e
KH
37722011-08-22 Kenichi Handa <handa@m17n.org>
3773
3774 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3775 extra slot even if the purpose is char-code-property-table.
3776
1a2e6670
EZ
37772011-08-23 Eli Zaretskii <eliz@gnu.org>
3778
8ddde651
EZ
3779 * xdisp.c (redisplay_window): When computing centering_position,
3780 account for the height of the header line. (Bug#8874)
3781
425cc014
EZ
3782 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3783 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3784 candidate is selected by the mouse, and that candidate has a
3785 composed character under the mouse.
3786
1a2e6670
EZ
3787 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3788 coordinates reported by pos-visible-in-window-p for a composed
3789 character in column zero.
3790
8b76d6f8
SM
37912011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3792
3793 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3794
dac347dd
EZ
37952011-08-22 Eli Zaretskii <eliz@gnu.org>
3796
3797 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3798 consider it a hit if to_charpos is anywhere in the range of the
3799 composed buffer positions.
3800
e013fb34
CY
38012011-08-22 Chong Yidong <cyd@stupidchicken.com>
3802
3803 * image.c (gif_load): Don't assume that each subimage has the same
3804 dimensions as the base image. Handle disposal method that is
3805 "undefined" by the gif spec (Bug#9335).
3806
bd1ba3e8
CY
38072011-08-20 Chong Yidong <cyd@stupidchicken.com>
3808
3809 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3810 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3811
54a1215b
EZ
38122011-08-19 Eli Zaretskii <eliz@gnu.org>
3813
823564e5
EZ
3814 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3815 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3816 from an Org mode buffer to a Speedbar frame.
3817
54a1215b
EZ
3818 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3819 a composition, take its buffer position from IT->cmp_it.charpos.
3820 Fixes cursor positioning at the beginning of a line that begins
3821 with a composed character.
3822
9778ebcc
EZ
38232011-08-18 Eli Zaretskii <eliz@gnu.org>
3824
0be6ee06
EZ
3825 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3826 character bidirectional type, use STRONG_L instead. Fixes crashes
3827 in a buffer produced by `describe-categories'.
3828
9778ebcc
EZ
3829 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3830 members before the level stack, so they would be saved and
3831 restored when copying iterator state. Fixes incorrect reordering
3832 around TABs covered by display properties.
3833
156bffbe
AS
38342011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3835
6b02f655 3836 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3837
72ad093b
CY
38382011-08-17 Chong Yidong <cyd@stupidchicken.com>
3839
3840 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3841 (internal_condition_case_2, internal_condition_case_n):
3842 Remove unnecessary aborts (Bug#9081).
72ad093b 3843
35774242
EZ
38442011-08-17 Eli Zaretskii <eliz@gnu.org>
3845
3846 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3847 has no `load' handler, try opening the file locally. (Bug#9311)
3848
db76dd85
KB
38492011-08-16 Ken Brown <kbrown@cornell.edu>
3850
3851 * gmalloc.c: Expand comment.
3852
b215eee5
EZ
38532011-08-16 Eli Zaretskii <eliz@gnu.org>
3854
3855 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3856 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3857
a4579d33
KB
38582011-08-16 Ken Brown <kbrown@cornell.edu>
3859
3860 Fix memory allocation problems in Cygwin build (Bug#9273).
3861
3862 * unexcw.c ( __malloc_initialized): Declare external variable.
3863 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3864
8b76d6f8
SM
3865 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3866 New variables.
a4579d33
KB
3867 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3868 dumped emacs.
3869 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3870 in the static heap.
3871 [CYGWIN] (special_realloc): New function.
3872 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3873 requests to realloc storage in the static heap.
3874
3ebec551
PE
38752011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3876
3877 * bidi.c (bidi_initialize): Remove unused local.
3878
9fd8be00
EZ
38792011-08-15 Eli Zaretskii <eliz@gnu.org>
3880
6b02f655
SM
3881 * bidimirror.h:
3882 * biditype.h: Remove file.
3883 * makefile.w32-in ($(BLD)/bidi.$(O)):
3884 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3885
3886 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3887
3888 * chartab.c: Improve commentary for the uniprop_table API.
3889
32413314
EZ
3890 * bidi.c (bidi_paragraph_init): Support zero value of
3891 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3892 (bidi_initialize): Use uniprop_table instead of including
3893 biditype.h and bidimirror.h.
32413314 3894
9fd8be00
EZ
3895 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3896 coordinates of the iterator when restoring from ppos_it.
3897 (Bug#9296)
3898
5cf2b69b
KH
38992011-08-14 Kenichi Handa <handa@m17n.org>
3900
3901 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3902 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3903
daf17d00
EZ
39042011-08-14 Eli Zaretskii <eliz@gnu.org>
3905
3906 * xdisp.c (move_it_in_display_line_to): Don't invoke
3907 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3908 ppos_it. Fixes vertical cursor motion when line beginning is
3909 covered by an image. (Bug#9296)
3910
08e3161a
JD
39112011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3912
3913 * nsterm.h (ns_run_ascript): Declare.
3914 (NSAPP_DATA2_RUNASSCRIPT): Define.
3915
3916 * nsfns.m (as_script, as_result, as_status): New static variables.
3917 (ns_run_ascript): New function.
5e617bc2 3918 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3919 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3920 the event loop. Get status from as_status (Bug#7276).
3921
3922 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3923 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3924 the event loop (Bug#7276).
3925
a3720aa2
AS
39262011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3927
3928 * gnutls.c (QCgnutls_bootprop_priority)
3929 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3930 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3931 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3932 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3933 (QCgnutls_bootprop_verify_hostname_error)
3934 (QCgnutls_bootprop_callbacks_verify): Rename from
3935 Qgnutls_bootprop_..., all uses changed.
3936
3937 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3938 uses changed.
3939
0a0d27fb
PE
39402011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3941
19d5c50c
PE
3942 * xfaces.c (Qframe_set_background_mode): Now static.
3943 * dispextern.h (Qframe_set_background_mode): Remove decl.
3944
0a0d27fb
PE
3945 * process.c (Fnetwork_interface_info): Declare local only if needed.
3946
377538cb
JD
39472011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3948
3949 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3950 (Fnetwork_interface_list): Allocate in increments of bytes instead
3951 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3952 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3953 sockaddr.
3954 (struct ifflag_def): notrailers is smart on OSX.
3955 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3956 Get hardware address with getifaddrs if available.
3957
08fff70c
EZ
39582011-08-12 Eli Zaretskii <eliz@gnu.org>
3959
3960 * xdisp.c (iterate_out_of_display_property): xassert that
3961 IT->position is set to within IT->object's boundaries. Break from
3962 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3963 when IT->position is set up wrongly due to some bug.
3964 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3965 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3966 entry. Force push_it to save on the stack the current
3967 buffer/string position, to be restored by pop_it. Fix flags in
3968 the iterator structure wrt the object coming from a display
3969 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3970 properties. (Bug#9284)
3971
7be1c708 39722011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3973
7be1c708
CY
3974 * fontset.c (fontset_get_font_group): Add proper type checks.
3975 (Bug#9172)
aac0c6e3 3976
7be1c708 39772011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3978
7be1c708
CY
3979 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3980 and LC_VERSION_MIN_MACOSX.
3981 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3982 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3983
97bb72a6
EZ
39842011-08-08 Eli Zaretskii <eliz@gnu.org>
3985
3986 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3987 no-display-properties-and-no-overlays under bidi display.
3988 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3989 properties and overlays.
97bb72a6 3990
d5617611
CY
39912011-08-08 Chong Yidong <cyd@stupidchicken.com>
3992
37e11a63
CY
3993 * editfns.c (Fset_time_zone_rule): Document relationship with the
3994 setenv function.
3995
d5617611
CY
3996 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3997 the font entity extracted from the cache (Bug#8109).
3998
58872834
CY
39992011-08-07 Chong Yidong <cyd@stupidchicken.com>
4000
4001 * composite.c (autocmp_chars): Don't reset point. That is done by
4002 restore_point_unwind (Bug#5984).
4003
75bfc667
JL
40042011-08-07 Juri Linkov <juri@jurta.org>
4005
4006 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4007 to show the arg `TIME' instead of `TIMEVAL'.
4008
d1410150
EZ
40092011-08-06 Eli Zaretskii <eliz@gnu.org>
4010
4011 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4012 display property strides EOL and includes a newline, as in
4013 longlines-mode. (Bug#9254)
75b771e4
EZ
4014 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4015 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
4016
4017 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4018 is non-zero, even if the data buffer is NULL. Fixes a crash in
4019 vertical-motion with longlines-mode. (Bug#9254)
4020
35928349
EZ
40212011-08-05 Eli Zaretskii <eliz@gnu.org>
4022
ec7cc85b
EZ
4023 * bidi.c <bidi_cache_total_alloc>: Now static.
4024 (bidi_initialize): Initialize bidi_cache_total_alloc.
4025
8b76d6f8 4026 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
4027 cache. (Bug#9221)
4028
4029 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4030 amount allocated this far in `bidi_cache_total_alloc'.
4031 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4032 non-zero, only free the data buffer without restoring the cache
4033 contents. All callers changed.
4034
4035 * dispextern.h (bidi_unshelve_cache): Update prototype.
4036
4037 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4038 (move_it_in_display_line, move_it_to)
4039 (move_it_vertically_backward, move_it_by_lines): Replace the call
4040 to xfree to an equivalent call to bidi_unshelve_cache.
4041 (move_it_in_display_line_to): Fix logic of returning
412b6358 4042 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 4043
e2e2423b
EZ
40442011-08-05 Eli Zaretskii <eliz@gnu.org>
4045
4046 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4047 came from a string character with a `cursor' property. (Bug#9229)
4048
ae9e757a
JD
40492011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4050
4051 * Makefile.in (LIB_PTHREAD): New variable.
4052 (LIBES): Add LIB_PTHREAD (Bug#9216).
4053
4054 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4055 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4056
213bd7f2
AS
40572011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4058
6b02f655 4059 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 4060
99aaf75f
JD
40612011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4062
4063 * xterm.c (x_find_topmost_parent): New function.
4064 (x_set_frame_alpha): Find topmost parent window with
4065 x_find_topmost_parent and set the property there also (bug#9181).
4066 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4067
c74e9d86
PE
40682011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4069
4070 * callproc.c (Fcall_process): Avoid vfork clobbering
4071 the local vars buffer, coding_systems, current_dir.
4072
640c8776
SM
40732011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4074
4075 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4076
f26d0e4c
PE
40772011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4078
8a10d76c
PE
4079 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4080 so that it is not optimized away.
4081
f26d0e4c
PE
4082 * xdisp.c (compute_display_string_pos): Remove unused local.
4083
55439c61
EZ
40842011-08-02 Eli Zaretskii <eliz@gnu.org>
4085
4086 Fix slow cursor motion and scrolling in large buffers with
4087 selective display, like Org Mode buffers. (Bug#9218)
4088
4089 * dispextern.h (struct bidi_it): New member disp_prop_p.
4090
4091 * xdisp.c: Remove one-slot cache of display string positions.
4092 (compute_display_string_pos): Accept an additional argument
5e617bc2 4093 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
4094 for a display string or property. If found, set DISP_PROP_P
4095 non-zero.
4096
4097 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
4098 DISP_PROP_P, and pass it to compute_display_string_pos.
4099 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
4100 non-zero. All callers of bidi_fetch_char changed.
4101
fb33fa43
SM
41022011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4103
4104 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4105
b099e063
DM
41062010-12-03 Don March <don@ohspite.net>
4107
4108 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4109 last character M-[char] is translated to ESC [char] (bug#7541).
4110
5cc7f7af
KH
41112011-08-02 Kenichi Handa <handa@m17n.org>
4112
d0fffa3f 4113 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
4114
4115 * chartab.c (uniprop_table): Make it non-static.
4116
525d5e6e
EZ
41172011-08-01 Eli Zaretskii <eliz@gnu.org>
4118
4119 * xdisp.c (forward_to_next_line_start): Accept additional argument
4120 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4121 on the newline.
4122 (reseat_at_next_visible_line_start): Use the bidi iterator state
4123 returned by forward_to_next_line_start to restore the state of
4124 it->bidi_it after backing up to previous newline. (Bug#9212)
4125
31011111
AS
41262011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4127
4128 * regex.c (re_comp): Protoize.
4129 (re_exec): Fix return type.
4130 (regexec): Fix type of `ret'. (Bug#9203)
4131
476371c4
PE
41322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4133
e5d76069
PE
4134 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4135 This is needed if max-image-size is a floating-point number.
4136
9a79b20c
AS
41372011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4138
4139 * print.c (print_object): Print empty symbol as ##.
4140
4141 * lread.c (read1): Read ## as empty symbol.
4142
d8c2fa78
AA
41432011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4144
4145 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4146 setting frame foreground color (Bug#9175).
4147 (x_set_background_color): Likewise.
4148
ffe57a7a
AA
4149 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4150 contents (Bug#9176).
4151 (EmacsTooltip -init): Remove bezels and add shadows to
4152 tooltip windows.
4153
bf3492a5
AA
4154 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4155 or scroll bar (Bug#8470).
4156
d55e9c53
AA
4157 * nsfont.m (nsfont_open): Remove assignment to voffset and
4158 unnecessary vars hshink, expand, hd, full_height, min_height.
4159 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4160
4161 * nsterm.h (nsfont_info): Remove voffset field.
4162
d8c2fa78 41632011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
4164
4165 Implement strike-through and overline on NextStep (Bug#8863).
4166
4167 * nsfont.m (nsfont_open): Use underline position provided by font,
4168 instead of hard-coded value of 2.
4169 (nsfont_draw): Call ns_draw_text_decoration instead.
4170
4171 * nsterm.h: Add declaration for ns_draw_text_decoration.
4172
4173 * nsterm.m (ns_draw_text_decoration): New function for drawing
4174 underline, overline, and strike-through.
4175 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4176 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 4177 accommodate underlining, etc.
4843aac3 4178
4cc60b9b
EZ
41792011-07-28 Eli Zaretskii <eliz@gnu.org>
4180
bc7ece87
EZ
4181 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4182 default.
4cc60b9b 4183
476371c4
PE
41842011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4185
66606eea
PE
4186 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4187 Without this fix, if a signal arrives just after memory fills up,
4188 'malloc' might be invoked reentrantly.
4189
476371c4
PE
4190 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4191 In other words, assume that every image size is allowed, on non-X
4192 hosts. This assumption is probably wrong, but it lets Emacs compile.
4193
f3fcc40d
AS
41942011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4195
4196 * regex.c (re_iswctype): Convert return values to boolean.
4197
350c992f
EZ
41982011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4199
4200 * xdisp.c (compute_display_string_pos): Don't use cached display
4201 string position if the buffer had its restriction changed.
4202 (Bug#9184)
4203
5266b4bb
PE
42042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4205
4206 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4207
2573a837 42082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 4209
41f55ccd 4210 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 4211
39e378da
PE
4212 * bidi.c: Integer size and overflow fixes.
4213 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4214 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4215 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4216 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4217 (bidi_find_other_level_edge):
4218 Use ptrdiff_t instead of EMACS_INT where either will do.
4219 This works better on 32-bit hosts configured --with-wide-int.
4220 (bidi_cache_ensure_space): Check for size-calculation overflow.
4221 Use % rather than repeated addition, for better worst-case speed.
4222 Don't set bidi_cache_size until after xrealloc returns, because it
4223 might not return.
4224 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
4225 (bidi_cache_ensure_space): Also check that the bidi cache size
4226 does not exceed that of the largest Lisp string or buffer. See Eli
4227 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 4228
5e927815
PE
4229 * alloc.c (__malloc_size_t): Remove.
4230 All uses replaced by size_t. See Andreas Schwab's note
4231 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4232
ca4aa935
PE
4233 * image.c: Improve checking for integer overflow.
4234 (check_image_size): Assume that f is nonnull, since
4235 it is always nonnull in practice. This is one less thing to
4236 worry about when checking for integer overflow later.
4237 (x_check_image_size): New function, which checks for integer
4238 overflow issues inside X.
4239 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4240 This removes the need for a memory_full check.
4241 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4242 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4243 (xbm_read_bitmap_data): Change locals back to 'int', since
4244 their values must fit in 'int'.
4245 (xpm_load_image, png_load, tiff_load):
4246 Invoke x_create_x_image_and_pixmap earlier,
4247 to avoid much needless work if the image is too large.
4248 (tiff_load): Treat overly large images as if
4249 x_create_x_image_and_pixmap failed, not as malloc failures.
4250 (gs_load): Use x_check_image_size.
4251
5f8f9cc2
PE
4252 * gtkutil.c: Omit integer casts.
4253 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4254 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4255
5adf60bc
PE
4256 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4257
c8907a93
PE
4258 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4259 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4260 would wrongly return t on a 64-bit host.
4261
e3c25c68
PE
4262 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4263 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4264 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4265 and therefore cause GCC to emit a bogus diagnostic in some cases.
4266
3f791afe
PE
4267 * image.c: Integer signedness and overflow and related fixes.
4268 This is not an exhaustive set of fixes, but it's time to
4269 record what I've got.
4270 (lookup_pixel_color, check_image_size): Remove redundant decls.
4271 (check_image_size): Don't assume that arbitrary EMACS_INT values
4272 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4273 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4274 (tiff_load, imagemagick_load_image):
4275 Check for overflow in size calculations.
4276 (x_create_x_image_and_pixmap): Remove unnecessary test for
4277 xmalloc returning NULL; that can't happen.
4278 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4279 (xpm_color_bucket): Use better integer hashing function.
4280 (xpm_cache_color): Don't possibly over-allocate memory.
4281 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4282 (gif_memory_source):
4283 Use ptrdiff_t, not int or size_t, to record sizes.
4284 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4285 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4286 either works, as we prefer signed integers.
4287 (tiff_read_from_memory, tiff_write_from_memory):
4288 Return tsize_t, not size_t, since that's what the TIFF API wants.
4289 (tiff_read_from_memory): Don't fail simply because the read would
4290 go past EOF; instead, return a short read.
4291 (tiff_load): Omit no-longer-needed casts.
4292 (Fimagemagick_types): Don't assume size fits into 'int'.
4293
3cc5a532
PE
4294 Improve hashing quality when configured --with-wide-int.
4295 * fns.c (hash_string): New function, taken from sxhash_string.
4296 Do not discard information about ASCII character case; this
4297 discarding is no longer needed.
4298 (sxhash-string): Use it. Change sig to match it. Caller changed.
4299 * lisp.h: Declare it.
4300 * lread.c (hash_string): Remove, since we now use fns.c's version.
4301 The fns.c version returns a wider integer if --with-wide-int is
4302 specified, so this should help the quality of the hashing a bit.
4303
b312a492
PE
4304 * emacs.c: Integer overflow minor fix.
4305 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4306 Define only if GNU_LINUX.
4307 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4308
dfd153ae
PE
4309 * dispnew.c: Integer signedness and overflow fixes.
4310 Remove unnecessary forward decls, that were a maintenance hassle.
4311 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4312 All uses changed.
4313 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4314 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4315 (prepare_desired_row, line_draw_cost):
4316 Use int, not unsigned, where either works.
4317 (save_current_matrix, restore_current_matrix):
4318 Use ptrdiff_t, not size_t, where either works.
4319 (init_display): Check for overflow more accurately, and without
4320 relying on undefined behavior.
4321
a81d11a3
PE
4322 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4323 Remove, replacing with the new symbols in lisp.h. All uses changed.
4324 * fileio.c (make_temp_name):
4325 * filelock.c (lock_file_1, lock_file):
4326 * xdisp.c (message_dolog):
4327 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4328 Use pMd etc. instead.
4329 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4330 replacing the pWIDE etc. symbols removed from editfns.c.
4331
3300e6fd
PE
4332 * keyboard.h (num_input_events): Now uintmax_t.
4333 This is (very slightly) less likely to mess up due to wraparound.
4334 All uses changed.
4335
fd05c7e9
PE
4336 * buffer.c: Integer signedness fixes.
4337 (alloc_buffer_text, enlarge_buffer_text):
4338 Use ptrdiff_t rather than size_t when either will do, as we prefer
4339 signed integers.
4340
903fe15d
PE
4341 * alloc.c: Integer signedness and overflow fixes.
4342 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4343 (__malloc_size_t): Default to size_t, not to int.
4344 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4345 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4346 Prefer ptrdiff_t to size_t when either would do, as we prefer
4347 signed integers.
4348 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4349 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4350 Now const. Initialize with values that are in range even if char
4351 is signed.
4352 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4353 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4354 These functions do the right thing with sizes > 2**32.
4355 (check_depth): Now ptrdiff_t, not int.
4356 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4357 Adjust to new way of storing sizes. Check for size overflow bugs
4358 in rest of code.
4359 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4360 slightly wrong anyway, as it missed one instance of
4361 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4362 (refill_memory_reserve): Omit needless cast to size_t.
4363 (mark_object_loop_halt): Mark as externally visible.
4364
ac82cc6a
PE
4365 * xselect.c: Integer signedness and overflow fixes.
4366 (Fx_register_dnd_atom, x_handle_dnd_message):
4367 Use ptrdiff_t, not size_t, since we prefer signed.
4368 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4369 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4370 x_dnd_atoms_size and x_dnd_atoms_length.
4371
c2d1e36d
PE
4372 * doprnt.c: Prefer signed to unsigned when either works.
4373 * eval.c (verror):
4374 * doprnt.c (doprnt):
4375 * lisp.h (doprnt):
4376 * xdisp.c (vmessage):
4377 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4378 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4379 prefer signed arithmetic to avoid comparison confusion.
4380 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4381 but is a bit tricky.
4382
0e926e56
PE
4383 Assume freestanding C89 headers, string.h, stdlib.h.
4384 * data.c, doprnt.c, floatfns.c, print.c:
4385 Include float.h unconditionally.
4386 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4387 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4388 * regex.c: Likewise for stddef.h, string.h.
4389 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4390 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4391 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4392 (STDC_HEADERS): Remove obsolete defines.
4393 * sysdep.c: Include limits.h unconditionally.
4394
9cfdb3ec
PE
4395 Assume support for memcmp, memcpy, memmove, memset.
4396 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4397 * regex.c (memcmp, memcpy):
4398 Remove; we assume C89 now.
4399
4400 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4401 (__malloc_safe_bcopy): Remove; no longer needed.
4402
cf950e6b 4403 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4404 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4405 well either way, and we prefer signed to unsigned.
4406
dbf38e02
LMI
44072011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4408
4409 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4410 closes the connection while we're reading (bug#9182).
4411
d6f0886c 44122011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4413
d6f0886c
JD
4414 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4415 are specified (Bug#9168).
24e0f6b1 4416
2eb1f9e6
PE
44172011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4418
4419 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4420 Found by GCC static checking and --with-wide-int on a 32-bit host.
4421
22381272 44222011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4423
4424 * xdisp.c (compute_display_string_pos): Fix logic of caching
4425 previous display string position. Initialize cached_prev_pos to
4426 -1. Fixes slow-down at the beginning of a buffer.
4427
f25e39b4
EZ
44282011-07-24 Eli Zaretskii <eliz@gnu.org>
4429
4430 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4431 for attrs[LFACE_FONTSET_INDEX].
4432
04c4b52e
PE
44332011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4434
4435 * xml.c (parse_region): Remove unused local
4436 that was recently introduced.
4437
c1734fbd
EZ
44382011-07-23 Eli Zaretskii <eliz@gnu.org>
4439
be18c5a5
EZ
4440 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4441 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4442
c1734fbd
EZ
4443 * xdisp.c (move_it_in_display_line_to): Record the best matching
4444 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4445 exit if none of the characters scanned was an exact match.
4446 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4447 when exact match is impossible due to invisible text, and the
4448 lines are truncated.
4449
a258d627
JD
44502011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4451
4452 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4453 for OSX >= 10.7.
4454
b6d5a689
EZ
44552011-07-22 Eli Zaretskii <eliz@gnu.org>
4456
0f74f785
EZ
4457 Fix a significant slow-down of cursor motion with C-n, C-p,
4458 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4459 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4460 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4461 (next_element_from_buffer): Call compute_stop_pos_backwards to
4462 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4463 base_level_stop.
4464 (reseat): Don't look for prev_stop, as that could mean a very long
4465 run.
4466 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4467 <cached_disp_overlay_modiff>: Cache for last found display string
4468 position.
551918c1 4469 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4470 about the same buffer in the same area of character positions, and
4471 the buffer wasn't changed since the time the display string
4472 position was cached.
551918c1 4473
b2d0c91a
EZ
44742011-07-22 Eli Zaretskii <eliz@gnu.org>
4475
4476 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4477 is an integer, which is important for empty lines. (Bug#9149)
4478
043604ee
CY
44792011-07-22 Chong Yidong <cyd@stupidchicken.com>
4480
4481 * frame.c (Fmodify_frame_parameters): In tty case, update the
4482 default face if necessary (Bug#4238).
4483
da4adb04
CY
44842011-07-21 Chong Yidong <cyd@stupidchicken.com>
4485
4486 * editfns.c (Fstring_to_char): No need to explain what a character
4487 is in the docstring (Bug#6576).
4488
9abd0532
LMI
44892011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4490
4491 * xml.c (parse_region): Make sure we always return a tree.
4492
36881d16
HK
44932011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4494
4495 * xml.c (parse_region): If a document contains only comments,
4496 return that, too.
4497
1e98674d
LMI
44982011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4499
4500 * xml.c (make_dom): Return comments, too.
4501
590bd467
PE
45022011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4503
4504 Port to OpenBSD.
4505 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4506 and the surrounding thread.
4507 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4508 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4509 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4510 timer goes off.
4511 * s/openbsd.h (BROKEN_SIGIO): Define.
4512 * unexelf.c (unexec) [__OpenBSD__]:
4513 Don't update the .mdebug section of the Alpha COFF symbol table.
4514
f41628b2
LMI
45152011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4516
4517 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4518 (bug#8460).
4519
b59b67c5
PE
45202011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4521
15e3a074
PE
4522 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4523 This fixes some race conditions on the permissions of any newly
4524 created file.
4525
41bed37d
PE
4526 * alloc.c (valid_pointer_p): Use pipe, not open.
4527 This fixes some permissions issues when debugging.
4528
b59b67c5
PE
4529 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4530 If fchown fails to set both uid and gid, try to set just gid,
4531 as that is sometimes allowed. Adjust the file's mode to eliminate
4532 setuid or setgid bits that are inappropriate if fchown fails.
4533
925a6be7
SM
45342011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4535
4536 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4537 to compare Lisp_Objects.
4538 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4539 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4540 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4541
52968808
AS
45422011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4543
0a6a104b
AS
4544 * lread.c (read_integer): Unread even EOF character.
4545 (read1): Likewise. Properly record start position of symbol.
4546
52968808
AS
4547 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4548 symbol character follows.
4549
9e381cdd
PE
45502011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4551
4552 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4553 This works around a problem with the previous change to Fcopy_file.
4554 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4555 and without this change, GCC might complain about discarding
4556 fchown's return value.
4557
b5641435
JB
45582011-07-16 Juanma Barranquero <lekktu@gmail.com>
4559
4560 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4561
a8031457
PE
45622011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4563
4564 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4565
dd889327
LMI
45662011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4567
750c33f7
LMI
4568 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4569 it's used from the C level.
4570
dd889327
LMI
4571 * process.c: Use the same condition for POLL_FOR_INPUT in both
4572 keyboard.c and process.c (bug#1858).
4573
87e86684
LM
45742011-07-09 Lawrence Mitchell <wence@gmx.li>
4575
4576 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4577 (Fgnutls_boot): Use it.
4578
64348f40
AS
45792011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4580
4581 * doc.c (Fsubstitute_command_keys): Revert last change.
4582
1d698799
LMI
45832011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4584
f863868c
LMI
4585 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4586 quotes the next character, and doesn't affect other longer
4587 sequences (bug#8935).
4588
1d698799
LMI
4589 * lread.c (syms_of_lread): Clarify that is isn't only
4590 `eval-buffer' and `eval-defun' that's affected by
4591 `lexical-binding' (bug#8460).
4592
aa4b6df6
EZ
45932011-07-15 Eli Zaretskii <eliz@gnu.org>
4594
4595 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4596 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4597
5d856da6
PE
45982011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4599
ad6042bb
PE
4600 Fix minor problems found by static checking.
4601 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4602 (elsz): Now a signed constant, not a size_t var. We prefer signed
4603 types to unsigned, to avoid integer comparison confusion. Without
4604 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4605 "cannot optimize loop, the loop counter may overflow", a symptom
4606 of the confusion.
f00bbb22 4607 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4608 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4609
6468f31c
LMI
46102011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4611
49080b10
LMI
4612 * search.c (Fre_search_backward): Mention `case-fold-search' in
4613 all the re_search_* functions (bug#8138).
4614
6468f31c
LMI
4615 * keyboard.c (Fopen_dribble_file): Document when the file is
4616 closed (bug#8056).
4617
c965adc5
EZ
46182011-07-14 Eli Zaretskii <eliz@gnu.org>
4619
df9733bf
EZ
4620 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4621 bidi_cache_idx.
4622
0bb23927
EZ
4623 Support bidi reordering of display and overlay strings.
4624 * xdisp.c (compute_display_string_pos)
4625 (compute_display_string_end): Accept additional argument STRING.
4626 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4627 (reseat_to_string): Initialize bidi_it->string.s and
4628 bidi_it->string.schars.
4629 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4630 NULL (avoids a crash in bidi_paragraph_init).
4631 Initialize itb.string.lstring.
0bb23927
EZ
4632 (init_iterator): Call bidi_init_it only of a valid
4633 buffer position was specified. Initialize paragraph_embedding to
4634 L2R.
4635 (reseat_to_string): Initialize the bidi iterator.
4636 (display_string): If we need to ignore text properties of
4637 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4638 original value of -1 will not work with bidi.)
4639 (compute_display_string_pos): First arg is now struct
4640 `text_pos *'; all callers changed. Support display properties on
4641 Lisp strings.
4642 (compute_display_string_end): Support display properties on Lisp
4643 strings.
4644 (init_iterator, reseat_1, reseat_to_string): Initialize the
4645 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4646 when iterating on a string not from display properties).
640c8776
SM
4647 (compute_display_string_pos, compute_display_string_end):
4648 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4649 arrow keys.
4650 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4651 base_level_stop; instead, set base_level_stop to BEGV.
4652 Fixes crashes in vertical-motion.
0bb23927
EZ
4653 (next_element_from_buffer): Improve commentary for when
4654 the iterator is before prev_stop.
4655 (init_iterator): Initialize bidi_p from the default value of
4656 bidi-display-reordering, not from buffer-local value. Use the
4657 buffer-local value only if initializing for buffer iteration.
4658 (handle_invisible_prop): Support invisible properties on strings
4659 that are being bidi-reordered.
4660 (set_iterator_to_next): Support bidi reordering of C strings and
4661 Lisp strings.
4662 (next_element_from_string): Support bidi reordering of Lisp
4663 strings.
4664 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4665 (display_string): Support display of R2L glyph rows.
4666 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4667 (init_iterator): Don't initialize it->bidi_p for strings
4668 here.
4669 (reseat_to_string): Initialize it->bidi_p for strings here.
4670 (next_element_from_string, next_element_from_c_string)
4671 (next_element_from_buffer): Add xassert's for correspondence
4672 between IT's object being iterated and it->bidi_it.string
4673 structure.
4674 (face_before_or_after_it_pos): Support bidi iteration.
4675 (next_element_from_c_string): Handle the case of the first string
4676 character that is not the first one in the visual order.
4677 (get_visually_first_element): New function, refactored from common
4678 parts of next_element_from_buffer, next_element_from_string, and
4679 next_element_from_c_string.
4680 (tool_bar_lines_needed, redisplay_tool_bar)
4681 (display_menu_bar): Force left-to-right direction. Add a FIXME
4682 comment for making that be controlled by a user option.
4683 (push_it, pop_it): Save and restore the state of the
4684 bidi iterator. Save and restore the bidi_p flag.
4685 (pop_it): Iterate out of display property for string iteration as
4686 well.
4687 (iterate_out_of_display_property): Support iteration over strings.
4688 (handle_single_display_spec): Set up it->bidi_it for iteration
4689 over a display string, and call bidi_init_it.
4690 (handle_single_display_spec, next_overlay_string)
4691 (get_overlay_strings_1, push_display_prop): Set up the bidi
4692 iterator for displaying display or overlay strings.
4693 (forward_to_next_line_start): Don't use the shortcut if
4694 bidi-iterating.
4695 (back_to_previous_visible_line_start): If handle_display_prop
4696 pushed the iterator stack, restore the internal state of the bidi
4697 iterator by calling bidi_pop_it same number of times.
4698 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4699 and we are bidi-iterating, don't decrement the iterator position;
4700 instead, set the first_elt flag in the bidi iterator, to produce
4701 the same effect.
4702 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4703 (push_display_prop): xassert that we are iterating a buffer.
4704 (push_it, pop_it): Save and restore paragraph_embedding member.
4705 (handle_single_display_spec, next_overlay_string)
4706 (get_overlay_strings_1, reseat_1, reseat_to_string)
4707 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4708 correctly. Don't assume unibyte strings are not bidi-reordered.
4709 (compute_display_string_pos)
4710 (compute_display_string_end): Fix handling the case of C string.
4711 (push_it, pop_it): Save and restore from_disp_prop_p.
4712 (handle_single_display_spec, push_display_prop): Set the
4713 from_disp_prop_p flag.
4714 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4715 (pop_it): Call iterate_out_of_display_property only if we are
4716 popping after iteration over a string that came from a display
4717 property. Fix a typo in popping stretch info. Add an assertion
4718 for verifying that the iterator position is in sync with the bidi
4719 iterator.
4720 (handle_single_display_spec, get_overlay_strings_1)
4721 (push_display_prop): Fix initialization of paragraph direction for
4722 string when that of the parent object is not yet determined.
4723 (reseat_1): Call bidi_init_it to resync the bidi
4724 iterator with IT's position. (Bug#7616)
4725 (find_row_edges): If ROW->start.pos gives position
4726 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4727 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4728 Reset the from_disp_prop_p flag.
4729 (SAVE_IT, RESTORE_IT): New macros.
4730 (pos_visible_p, face_before_or_after_it_pos)
4731 (back_to_previous_visible_line_start)
4732 (move_it_in_display_line_to, move_it_in_display_line)
4733 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4734 (try_scrolling, redisplay_window, display_line): Use them when
4735 saving a temporary copy of the iterator and restoring it back.
4736 (back_to_previous_visible_line_start, reseat_1)
4737 (init_iterator): Empty the bidi cache "stack".
4738 (move_it_in_display_line_to): If iterator ended up at
4739 EOL, but we never saw any buffer positions smaller than
4740 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4741 motion in bidi-reordered lines.
4742 (move_it_in_display_line_to): Record prev_method and prev_pos
4743 immediately before the call to set_iterator_to_next. Fixes cursor
4744 motion in bidi-reordered lines with stretch glyphs and strings
4745 displayed in margins. (Bug#8133) (Bug#8867)
4746 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4747 TO_CHARPOS.
640c8776
SM
4748 (pos_visible_p): Support positions in bidi-reordered lines.
4749 Save and restore bidi cache.
0bb23927
EZ
4750
4751 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4752 (bidi_paragraph_info): Delete unused struct.
4753 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4754 (bidi_cache_start): New variable.
4755 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4756 to zero.
4757 (bidi_cache_fetch_state, bidi_cache_search)
4758 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4759 (bidi_cache_find, bidi_peek_at_next_level)
4760 (bidi_level_of_next_char, bidi_find_other_level_edge)
4761 (bidi_move_to_visually_next): Compare cache index with
4762 bidi_cache_start rather than with zero.
4763 (bidi_fetch_char): Accept new argument STRING; all callers
4764 changed. Support iteration over a string. Support strings with
4765 display properties. Support unibyte strings. Fix the type of
4766 `len' according to what STRING_CHAR_AND_LENGTH expects.
4767 (bidi_paragraph_init, bidi_resolve_explicit_1)
4768 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4769 (bidi_level_of_next_char, bidi_move_to_visually_next):
4770 Support iteration over a string.
0bb23927
EZ
4771 (bidi_set_sor_type, bidi_resolve_explicit_1)
4772 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4773 can now be zero (for strings); special values 0 and -1 were
4774 changed to -1 and -2, respectively.
4775 (bidi_char_at_pos): New function.
4776 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4777 Call it instead of FETCH_MULTIBYTE_CHAR.
4778 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4779 initialized to valid values.
4780 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4781 values.
4782 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4783 the test for valid cached positions. Fix the logic for looking up
4784 the sentinel state in the cache. GCPRO the Lisp string we are
4785 iterating.
4786 (bidi_push_it, bidi_pop_it): New functions.
4787 (bidi_initialize): Initialize the bidi cache start stack pointer.
4788 (bidi_cache_ensure_space): New function, refactored from part of
4789 bidi_cache_iterator_state. Don't assume the required size is just
4790 one BIDI_CACHE_CHUNK away.
4791 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4792 (bidi_count_bytes, bidi_char_at_pos): New functions.
4793 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4794 always valid if bidi_cache_idx is valid.
4795 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4796 is valid if it's going to be used.
4797 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4798 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4799 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4800 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4801 (bidi_find_other_level_edge, bidi_cache_start_stack):
4802 All variables related to cache indices are now EMACS_INT.
c965adc5 4803
0bb23927
EZ
4804 * dispextern.h (struct bidi_string_data): New structure.
4805 (struct bidi_it): New member `string'. Make flag members be 1-bit
4806 fields, and put them last in the struct.
640c8776
SM
4807 (compute_display_string_pos, compute_display_string_end):
4808 Update prototypes.
0bb23927
EZ
4809 (bidi_push_it, bidi_pop_it): Add prototypes.
4810 (struct iterator_stack_entry): New members bidi_p,
4811 paragraph_embedding, and from_disp_prop_p.
4812 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4813 (bidi_shelve_cache, bidi_unshelve_cache):
4814 Declare prototypes.
0bb23927
EZ
4815
4816 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4817 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4818 and vector-like objects.
4819
4820 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4821 cache around display iteration.
4822
4823 * window.c (Fwindow_end, window_scroll_pixel_based)
4824 (displayed_window_lines, Frecenter): Save and restore the bidi
4825 cache around display iteration.
4826
3bbd2265
LMI
48272011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4828
4829 * editfns.c (Fdelete_region): Clarify the use of the named
4830 parameters (bug#6788).
4831
adc47434
MR
48322011-07-14 Martin Rudalics <rudalics@gmx.at>
4833
4834 * indent.c (Fvertical_motion): Set and restore w->pointm when
4835 saving and restoring the window's buffer (Bug#9006).
4836
837c31f8
LMI
48372011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4838
4839 * editfns.c (Fstring_to_char): Clarify just what is returned
4840 (bug#6576). Text by Eli Zaretskii.
4841
ac389d0c
JB
48422011-07-13 Juanma Barranquero <lekktu@gmail.com>
4843
4844 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4845
0be0ce47
EZ
48462011-07-13 Eli Zaretskii <eliz@gnu.org>
4847
4848 * buffer.c (mmap_find): Fix a typo.
4849
cd18e7e3
JB
48502011-07-13 Johan Bockgård <bojohan@gnu.org>
4851
4852 Fix execution of x selection hooks.
4853 * xselect.c (Qx_lost_selection_functions)
4854 (Qx_sent_selection_functions): New vars.
4855 (syms_of_xselect): DEFSYM them.
4856 (x_handle_selection_request): Pass Qx_sent_selection_functions
4857 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4858 (x_handle_selection_clear,x_clear_frame_selections):
4859 Pass Qx_lost_selection_functions rather than
4860 Vx_lost_selection_functions to Frun_hook_with_args.
4861
47ea7f44
PE
48622011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4863
ac389d0c 4864 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4865 The old code sometimes used this field without initializing it.
4866
47ea7f44
PE
4867 * alloc.c (gc_sweep): Don't read past end of array.
4868 In theory, the old code could also have corrupted Emacs internals,
4869 though it'd be very unlikely.
4870
bc985c87
AS
48712011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4872
4873 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4874 argument. (Bug#4026)
bc985c87 4875
0cf34688
LMI
48762011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4877
b3dadd76
LMI
4878 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4879 key" (bug#4257).
4880
0cf34688
LMI
4881 * window.c (Fset_window_start): Doc fix (bug#4199).
4882 (Fset_window_hscroll): Ditto.
4883
270768cd
PE
48842011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4885
077e3dda 4886 Fix minor new problems caught by GCC 4.6.1.
270768cd 4887 * term.c (init_tty): Remove unused local.
490011a6 4888 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4889 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4890 not used otherwise.
270768cd 4891
b1f58454
CY
48922011-07-12 Chong Yidong <cyd@stupidchicken.com>
4893
4894 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4895
22b9578d
LMI
48962011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4897
6e70ab07
LMI
4898 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4899 are the mini-buffer and the echo area (bug#3320).
4900
22b9578d
LMI
4901 * term.c (init_tty): Remove support for supdup, c10 and perq
4902 terminals, which are no longer supported (bug#1482).
4903
8974cc9f
JB
49042011-07-10 Johan Bockgård <bojohan@gnu.org>
4905
4906 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4907
a560d974
JD
49082011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4909
4910 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4911 for non-popups (Bug#3642).
4912
1dae0f0a
AS
49132011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4914
268c2c36 4915 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4916 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4917 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4918 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4919 * data.c (fmod): Likewise.
4920 * dispnew.c (swap_glyphs_in_rows): Likewise.
4921 * emacs.c (memory_warning_signal): Likewise.
4922 * floatfns.c (float_error): Likewise.
4923 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4924 (otf_open, font_otf_capability, generate_otf_features)
4925 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4926 Likewise.
4927 * image.c (pbm_read_file): Likewise.
4928 * indent.c (string_display_width): Likewise.
4929 * intervals.c (check_for_interval, search_for_interval)
4930 (inc_interval_count, count_intervals, root_interval)
4931 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4932 * lread.c (defalias): Likewise.
268c2c36 4933 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4934 * regex.c (set_image_of_range_1, set_image_of_range)
4935 (regex_grow_registers): Likewise.
4936 * sysdep.c (strerror): Likewise.
4937 * termcap.c (valid_filename_p, tprint, main): Likewise.
4938 * tparam.c (main): Likewise.
4939 * unexhp9k800.c (run_time_remap, save_data_space)
4940 (update_file_ptrs, read_header, write_header, calculate_checksum)
4941 (copy_file, copy_rest, display_header): Likewise.
4942 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4943 Likewise.
4944 * xdisp.c (check_it): Likewise.
4945 * xfaces.c (register_color, unregister_color, unregister_colors):
4946 Likewise.
4947 * xfns.c (print_fontset_result): Likewise.
4948 * xrdb.c (member, fatal, main): Likewise.
4949
99033785
PE
49502011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4951
4952 Fix minor problems found by static checking (Bug#9031).
4953 * chartab.c (char_table_set_range, map_sub_char_table):
4954 Remove unused locals.
4955 (uniprop_table): Now static.
4956 * composite.c (_work_char): Remove unused static var.
4957
9cb2ac56
JB
49582011-07-09 Juanma Barranquero <lekktu@gmail.com>
4959
4960 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4961
f25661f0
JD
49622011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4963
4964 * gtkutil.c (qttip_cb): Remove code without function.
4965
8278c4fe
EZ
49662011-07-09 Eli Zaretskii <eliz@gnu.org>
4967
4968 * w32.c (pthread_sigmask): New stub.
4969
1692ae2d 49702011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4971
8a6ebd58 4972 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4973 sigprocmask is portable only for single-threaded applications, and
4974 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4975 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4976 (LIBES): Use it.
4977 * callproc.c (Fcall_process):
4978 * process.c (create_process):
4979 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4980 Use pthread_sigmask, not sigprocmask.
123403e4 4981
1b854618
JD
49822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4983
4984 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4985 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4986 wrong (Bug#8591).
4987
3fe4b549
JD
49882011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4989
0ce7e563
JD
4990 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4991 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4992 (xg_hide_tooltip): Fix comment.
4993
3fe4b549
JD
4994 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4995 in registerServicesMenuSendTypes.
4996 (validRequestorForSendType): Don't check ns_return_types.
4997
4998 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4999 ns_return_type.
5000
5df75e47
JR
50012011-07-08 Jason Rumney <jasonr@gnu.org>
5002
22610910
JR
5003 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5004 SH_SHOW for hidden windows (Bug#5482).
5005
5df75e47
JR
5006 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5007 frame struct members of non-existent frames (Bug#6284).
5008
699c10bd
JD
50092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5010
4393663b
JD
5011 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5012 variable firstTime not needed on OSX >= 10.6.
5013 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5014 >= 10.5. Use setKnobProportion, setDoubleValue.
5015
5016 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5017 (MAC_OS_X_VERSION_10_5): Define if not defined.
5018 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5019 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5020 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5021
5022 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5023 cString and lossyCString on OSX >= 10.4
5024
58179cce 5025 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
5026 sizeToFit on OSX >= 10.2.
5027
5028 * nsimage.m (allocInitFromFile): Don't use deprecated method
5029 bestRepresentationForDevice on OSX >= 10.6.
5030
5031 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5032 to avoid warning.
5033
5034 * emacs.c: Declare unexec_init_emacs_zone.
5035
a63e0781
JD
5036 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5037
699c10bd
JD
5038 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5039
5040 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5041 on svcsMenu (Bug#8842).
5042
5043 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5044 ns_return_types.
5045 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5046
5047 * nsterm.m (QUTF8_STRING): Declare.
5048 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5049 (validRequestorForSendType): Return type is (id).
5050 Change indexOfObjectIdenticalTo to indexOfObject.
5051 Check if we have local selection before returning self (Bug#8842).
5052 (writeSelectionToPasteboard): Put local selection into paste board
5053 if we have a local selection (Bug#8842).
5054 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5055
5056 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5057 (ns_get_local_selection): Declare.
5058
54e10184
LMI
50592011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5060
9888ff71
LMI
5061 * keymap.c (describe_map_tree): Don't insert a double newline at
5062 the end of the buffer (bug#1169) and return whether we inserted
5063 something.
5064
54e10184
LMI
5065 * callint.c (Fcall_interactively): Change "reading args" to
5066 "providing args" to try to clarify what it does (bug#1010).
5067
15fa4783
KH
50682011-07-07 Kenichi Handa <handa@m17n.org>
5069
5070 * composite.c (composition_compute_stop_pos): Ignore a static
5071 composition starting before CHARPOS (Bug#8915).
5072
5073 * xdisp.c (handle_composition_prop): Likewise.
5074
a8815b00
EZ
50752011-07-07 Eli Zaretskii <eliz@gnu.org>
5076
5077 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5078 (Bug#9015)
5079
ef7b981d 50802011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
5081
5082 * character.h (unicode_category_t): New enum type.
5083
5084 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5085 (Qchar_code_property_table): New variable.
5086 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5087 (UNIPROP_COMPRESSED_FORM_P): New macros.
5088 (char_table_ascii): Uncompress the compressed values.
5089 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5090 Uncompress the compressed values.
ac389d0c 5091 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
5092 (char_table_ref_and_range): Uncompress the compressed values.
5093 (sub_char_table_set): New arg is_uniprop. Callers changed.
5094 Uncompress the compressed values.
5095 (sub_char_table_set_range): Args changed. Callers changed.
5096 (char_table_set_range): Adjuted for the above change.
5097 (map_sub_char_table): Delete args default_val and parent. Add arg
5098 top. Give decoded values to a Lisp function.
640c8776 5099 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
5100 values to a Lisp function. Gcpro more variables.
5101 (uniprop_table_uncompress)
5102 (uniprop_decode_value_run_length): New functions.
5103 (uniprop_decoder, uniprop_decoder_count): New variables.
5104 (uniprop_get_decoder, uniprop_encode_value_character)
5105 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5106 New functions.
5107 (uniprop_encoder, uniprop_encoder_count): New variables.
5108 (uniprop_get_encoder, uniprop_table)
5109 (Funicode_property_table_internal, Fget_unicode_property_internal)
5110 (Fput_unicode_property_internal): New functions.
5111 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5112 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 5113 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
5114 char-code-property-alist.
5115
640c8776 5116 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
5117 Vunicode_category_table.
5118
640c8776 5119 * font.c (font_range): Adjust for the change of
c805dec0
KH
5120 Vunicode_category_table.
5121
76b397fb
DN
51222011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5123
5124 * m/iris4d.h: Remove file, move contents ...
5125 * s/irix6-5.h: ... here.
5126
22b4128e
PE
51272011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5128
5129 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
5130 * alloc.c (mark_buffer):
5131 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5132 (clone_per_buffer_values): Don't assume that
22b4128e
PE
5133 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5134 This isn't true in general, and it's particularly not true
5135 if Emacs is configured with --with-wide-int.
5136 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5137 New macros, used in the buffer.c change.
5138
869795d6
JD
51392011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5140
5141 * xsettings.c: Use both GConf and GSettings if both are available.
5142 (store_config_changed_event): Add comment.
5143 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5144 (store_tool_bar_style_changed): New functions.
5e617bc2 5145 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
5146 (struct xsettings): Move font inside HAVE_XFT.
5147 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 5148 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 5149 Move inside HAVE_XFT.
640c8776 5150 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
5151 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5152 also.
5153 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 5154 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 5155 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
5156 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5157 (parse_settings): Move check for font inside HAVE_XFT.
5158 (read_settings, apply_xft_settings): Add comment.
5159 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5160 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5161 call store_font_name_changed.
5162 (xft_settings_event): Add comment.
5163 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5164 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5165 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5166 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5167 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
5168 (xsettings_get_system_font, xsettings_get_system_normal_font):
5169 Add comment.
869795d6 5170
d8ed26bd
PE
51712011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5172
5173 Random fixes. E.g., (random) never returned negative values.
5174 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5175 subseconds part to the entropy, as that's a bit more random.
5176 Prefer signed to unsigned, since the signedness doesn't matter and
5177 in general we prefer signed. When given a limit, use a
5178 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5179 latter isn't right if USE_2_TAGS_FOR_INTS.
5180 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5181 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5182
cabf1cac
SM
51832011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5184
5185 * textprop.c (text_property_stickiness):
5186 Obey Vtext_property_default_nonsticky.
5187 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5188 * w32fns.c (syms_of_w32fns):
5189 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5190
6e9b2be9
PE
51912011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5192
5193 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5194 This is more efficient than Ffile_directory_p and avoids a minor race.
5195
90186c68
LMI
51962011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5197
7c301272
LMI
5198 * buffer.c (Foverlay_put): Say what the return value is
5199 (bug#7835).
5200
c4f2d8d4
LMI
5201 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5202 is a directory before asking whether to use the file name
5203 (bug#7564).
ad637907
LMI
5204 (barf_or_query_if_file_exists): Make the "File is a directory"
5205 error be more correct.
c4f2d8d4 5206
90186c68
LMI
5207 * fns.c (Frequire): Remove the mention of the .gz files, since
5208 that's installation-specific, but keep the mention of
5209 `get-load-suffixes'.
5210
da64016e
PE
52112011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5212
5213 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5214 Report string overflow if the output is too long.
5215
7d47b580
JB
52162011-07-04 Juanma Barranquero <lekktu@gmail.com>
5217
a555cb87
JB
5218 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5219 (syms_of_gnutls): Remove duplicate DEFSYM for
5220 Qgnutls_bootprop_verify_hostname_error, an error for
5221 Qgnutls_bootprop_verify_error (which is no longer used).
5222
7d47b580
JB
5223 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5224 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5225 Also (re)move comments that are misplaced or no longer relevant.
5226
1e49bfab
LMI
52272011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5228
5229 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5230
1485f4c0
CY
52312011-07-03 Chong Yidong <cyd@stupidchicken.com>
5232
5233 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5234 and background color parameters if they have been changed.
5235
a9ab721e
LMI
52362011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5237
5238 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5239
cf7cff57
PE
52402011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5241
2e13213d
PE
5242 * xsettings.c (SYSTEM_FONT): Define only when used.
5243 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5244
cf7cff57
PE
5245 * keymap.c (access_keymap_1): Now static.
5246
7a8e04f7
CY
52472011-07-02 Chong Yidong <cyd@stupidchicken.com>
5248
5249 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5250 leave any prefix arg for the up event (Bug#1586).
5251
61352f62
LMI
52522011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5253
69bb1ef7
LMI
5254 * lread.c (syms_of_lread): Mention single symbols defined by
5255 `defvar' or `defconst' (bug#7154).
5256
61352f62 5257 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 5258 (Frequire): Mention get-load-suffixes.
61352f62 5259
28545e04
MR
52602011-07-02 Martin Rudalics <rudalics@gmx.at>
5261
5262 * window.h (window): Remove clone_number slot.
5263 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5264 Remove.
5265 (make_parent_window, make_window, saved_window)
5266 (Fset_window_configuration, save_window_save): Don't deal with
5267 clone numbers.
5268 * buffer.c (Qclone_number): Remove declaration.
5269 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5270
3349e122
SM
52712011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5272
5273 Add multiple inheritance to keymaps.
5274 * keymap.c (Fmake_composed_keymap): New function.
5275 (Fset_keymap_parent): Simplify.
5276 (fix_submap_inheritance): Remove.
5277 (access_keymap_1): New function extracted from access_keymap to handle
5278 embedded parents and handle lists of maps.
5279 (access_keymap): Use it.
5280 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5281 (Fcopy_keymap): Handle embedded parents.
5282 (Fcommand_remapping, define_as_prefix): Simplify.
5283 (Fkey_binding): Simplify.
5284 (syms_of_keymap): Move minibuffer-local-completion-map,
5285 minibuffer-local-filename-completion-map,
5286 minibuffer-local-must-match-map, and
5287 minibuffer-local-filename-must-match-map to Elisp.
5288 (syms_of_keymap): Defsubr make-composed-keymap.
5289 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5290 (parse_menu_item): Trivial simplification.
5291
3279eb87
GM
52922011-07-01 Glenn Morris <rgm@gnu.org>
5293
5294 * Makefile.in (SETTINGS_LIBS): Fix typo.
5295
4550efdf
KI
52962011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5297
5298 * coding.c (Fencode_coding_string): Record the last coding system
5299 used, as the function doc string says (bug#8738).
5300
0949d2b6
JD
53012011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5302
5303 * xsettings.c (store_monospaced_changed): Take new font as arg and
5304 check for change against current_mono_font.
5305 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5306 (emacs_settings_constructor, emacs_settings_get_property)
5307 (emacs_settings_set_property, emacs_settings_class_init)
5308 (emacs_settings_init, gsettings_obj): Remove.
5309 (something_changedCB): New function for HAVE_GSETTINGS.
5310 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5311 with value as argument.
5312 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5313 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 5314 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
5315 "changed".
5316
5317 * xgselect.c: Add defined (HAVE_GSETTINGS).
5318 (xgselect_initialize): Ditto.
5319
5320 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5321 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5322 xg_select.
5323
bbc6b304
PE
53242011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5325
5326 * eval.c (struct backtrace): Simplify and port the data structure.
5327 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5328 signed bit field, as this assumption is not portable and it makes
5329 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5330 "char debug_on_exit : 1" as this is not portable either; instead,
5331 use the portable "unsigned int debug_on_exit : 1". Remove unused
5332 member evalargs. Remove obsolete comments about cc bombing out.
5333
9851bfc5
JD
53342011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5335
51bb811f 5336 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
5337 Let HAVE_GSETTINGS override HAVE_GCONF.
5338 (store_monospaced_changed): New function.
5339 (EMACS_SETTINGS): A new type derived from GObject to handle
5340 GSettings notifications.
5341 (emacs_settings_constructor, emacs_settings_get_property)
5342 (emacs_settings_set_property, emacs_settings_class_init):
5343 New functions.
5344 (gsettings_client, gsettings_obj): New variables.
5345 (GSETTINGS_SCHEMA): New define.
5346 (something_changedCB): Call store_monospaced_changed.
5347 (init_gsettings): New function.
5348 (xsettings_initialize): Call init_gsettings.
5349 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5350 to NULL.
5351
640c8776 5352 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
5353 GCONF_CFLAGS/LIBS.
5354
5386012d
MR
53552011-06-29 Martin Rudalics <rudalics@gmx.at>
5356
5357 * window.c (resize_root_window, grow_mini_window)
5358 (shrink_mini_window): Rename Qresize_root_window to
5359 Qwindow_resize_root_window and Qresize_root_window_vertically to
5360 Qwindow_resize_root_window_vertically.
5361
f13e0b08
PE
53622011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5363
5364 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5365
94515237
JB
53662011-06-27 Juanma Barranquero <lekktu@gmail.com>
5367
5368 * makefile.w32-in: Redesign dependencies so they reflect more
5369 clearly which files are directly included by each source file,
5370 and not through other includes.
5371
e43b6e43
MR
53722011-06-27 Martin Rudalics <rudalics@gmx.at>
5373
5374 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5375 (sort_overlays, overlay_strings): When an overlay's clone number
5376 matches the window's clone number process the overlay even if
5377 the overlay's window property doesn't match the current window.
5378
d68443dc
MR
5379 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5380 (Fwindow_hchild): Rename to Fwindow_left_child.
5381 (Fwindow_next): Rename to Fwindow_next_sibling.
5382 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5383 (resize_window_check): Rename to window_resize_check.
5384 (resize_window_apply): Rename to window_resize_apply.
5385 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5386 (Fdelete_other_windows_internal, resize_frame_windows)
5387 (Fsplit_window_internal, Fdelete_window_internal)
5388 (grow_mini_window, shrink_mini_window)
5389 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5390
c7e73be5
JD
53912011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5392
5393 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5394 (emacs_fixed_set_min_size): Remove.
5395 (emacs_fixed_new): Take frame as argument.
5396
5397 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5398 (_EmacsFixedPrivate): Remove minwidth/height.
5399 Add struct frame *f.
5400 (emacs_fixed_init): Initialize priv->f.
5401 (get_parent_class, emacs_fixed_set_min_size): Remove.
5402 (emacs_fixed_new): Set priv->f to argument.
5403 (emacs_fixed_get_preferred_width)
5404 (emacs_fixed_get_preferred_height): Use min_width/height from
5405 frames size_hint to set minimum and natural (Bug#8919).
5406 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5407 and use min_width/height from frames size_hint to set
5408 min_width/height (Bug#8919).
5409
5410 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5411 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5412 Fix indentation.
c7e73be5 5413
cf99dcf8
EZ
54142011-06-26 Eli Zaretskii <eliz@gnu.org>
5415
5416 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5417 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5418 called at ZV.
5419
029529ac
CY
54202011-06-26 Chong Yidong <cyd@stupidchicken.com>
5421
5422 * process.c (wait_reading_process_output): Bypass select if
5423 waiting for a cell while ignoring keyboard input, and input is
5424 pending. Suggested by Jan Djärv (Bug#8869).
5425
7a7ef429
PE
54262011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5427
5428 Use gnulib's dup2 module instead of rolling our own.
5429 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5430
11fdef7d 54312011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5432
5433 * dispnew.c (scrolling_window): Before scrolling, turn off a
5434 mouse-highlight in the window being scrolled.
5435
cd3520a4
JB
54362011-06-24 Juanma Barranquero <lekktu@gmail.com>
5437
5438 Move DEFSYM to lisp.h and use everywhere.
5439
5440 * character.h (DEFSYM): Move declaration...
5441 * lisp.h (DEFSYM): ...here.
5442
5443 * gnutls.c:
5444 * minibuf.c:
5445 * w32menu.c:
5446 * w32proc.c:
5447 * w32select.c: Don't include character.h.
5448
5449 * alloc.c (syms_of_alloc):
5450 * buffer.c (syms_of_buffer):
5451 * bytecode.c (syms_of_bytecode):
5452 * callint.c (syms_of_callint):
5453 * casefiddle.c (syms_of_casefiddle):
5454 * casetab.c (init_casetab_once):
5455 * category.c (init_category_once, syms_of_category):
5456 * ccl.c (syms_of_ccl):
5457 * cmds.c (syms_of_cmds):
5458 * composite.c (syms_of_composite):
5459 * dbusbind.c (syms_of_dbusbind):
5460 * dired.c (syms_of_dired):
5461 * dispnew.c (syms_of_display):
5462 * doc.c (syms_of_doc):
5463 * editfns.c (syms_of_editfns):
5464 * emacs.c (syms_of_emacs):
5465 * eval.c (syms_of_eval):
5466 * fileio.c (syms_of_fileio):
5467 * fns.c (syms_of_fns):
5468 * frame.c (syms_of_frame):
5469 * fringe.c (syms_of_fringe):
5470 * insdel.c (syms_of_insdel):
5471 * keymap.c (syms_of_keymap):
5472 * lread.c (init_obarray, syms_of_lread):
5473 * macros.c (syms_of_macros):
5474 * msdos.c (syms_of_msdos):
5475 * print.c (syms_of_print):
5476 * process.c (syms_of_process):
5477 * search.c (syms_of_search):
5478 * sound.c (syms_of_sound):
5479 * syntax.c (init_syntax_once, syms_of_syntax):
5480 * terminal.c (syms_of_terminal):
5481 * textprop.c (syms_of_textprop):
5482 * undo.c (syms_of_undo):
5483 * w32.c (globals_of_w32):
5484 * window.c (syms_of_window):
5485 * xdisp.c (syms_of_xdisp):
5486 * xfaces.c (syms_of_xfaces):
5487 * xfns.c (syms_of_xfns):
5488 * xmenu.c (syms_of_xmenu):
5489 * xsettings.c (syms_of_xsettings):
5490 * xterm.c (syms_of_xterm): Use DEFSYM.
5491
4228cf16
TZ
54922011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5493
cd3520a4 5494 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5495
7fcccf1e
PE
54962011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5497
7efb4e0e
PE
5498 Integer and buffer overflow fixes (Bug#8873).
5499
ff5844ad
PE
5500 * print.c (printchar, strout): Check for string overflow.
5501 (PRINTPREPARE, printchar, strout):
5502 Don't set size unless allocation succeeds.
5503
90532f02
PE
5504 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5505 for sizes. Check for string overflow more accurately.
5506 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5507
6d84508d
PE
5508 * macros.c: Integer and buffer overflow fixes.
5509 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5510 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5511 Use ptrdiff_t, not int, for sizes.
5512 Don't increment bufsize until after realloc succeeds.
5513 Check for size-calculation overflow.
5514 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5515
437b2cb4
PE
5516 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5517
8b9ac8b4
PE
5518 * lread.c: Integer overflow fixes.
5519 (read_integer): Radix is now EMACS_INT, not int,
5520 to improve quality of diagnostics for out-of-range radices.
5521 Calculate buffer size correctly for out-of-range radices.
5522 (read1): Check for integer overflow in radices, and in
5523 read-circle numbers.
82cb60d3
PE
5524 (read_escape): Avoid int overflow.
5525 (Fload, openp, read_buffer_size, read1)
5526 (substitute_object_recurse, read_vector, read_list, map_obarray):
5527 Use ptrdiff_t, not int, for sizes.
5528 (read1): Use EMACS_INT, not int, for sizes.
20270765 5529 Check for size overflow.
8b9ac8b4 5530
7fcccf1e
PE
5531 * image.c (cache_image): Check for size arithmetic overflow.
5532
bfbbd7e7
PE
5533 * lread.c: Integer overflow issues.
5534 (saved_doc_string_size, saved_doc_string_length)
5535 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5536 Now ptrdiff_t, not int.
5537 (read1): Don't assume doc string length fits in int. Check for
5538 out-of-range doc string lengths.
5539 (read_list): Don't assume file position fits in int.
39019e54 5540 (read_escape): Check for hex character overflow.
bfbbd7e7 5541
4e323265
LL
55422011-06-22 Leo Liu <sdl.web@gmail.com>
5543
5544 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5545 Move to minibuffer.el.
5546
85fece3e
PE
55472011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5548
20b84ce9 5549 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5550 The following patches are for when GLYPH_DEBUG && !XASSERT.
5551 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5552 * dispnew.c (flush_stdout):
5553 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5554 Mark as externally visible.
5555 * dispnew.c (check_window_matrix_pointers): Now static.
5556 * dispnew.c (window_to_frame_vpos):
5557 * xfns.c (unwind_create_frame):
5558 * xterm.c (x_check_font): Remove unused local.
5559 * scroll.c (CHECK_BOUNDS):
5560 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5561 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5562 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5563 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5564 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5565 Now static.
5566 (debug_method_add): Use va_list and vsprintf rather than relying
5567 on undefined behavior with wrong number of arguments.
5568 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5569 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5570 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5571 since we're not interested in debugging glyphs with old libraries.
5572 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5573 GCC 4.6.0's static checking.
5574
0766b489
PE
55752011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5576
31fd4b32
PE
5577 Integer overflow and signedness fixes (Bug#8873).
5578 A few related buffer overrun fixes, too.
5579
b79e8648
PE
5580 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5581
0766b489
PE
5582 * dispextern.h (struct face.stipple):
5583 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5584 (x_bitmap_mask, x_allocate_bitmap_record)
5585 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5586 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5587 (x_create_bitmap_from_xpm_data):
5588 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5589 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5590 (.bitmaps_last):
5591 * xfaces.c (load_pixmap):
5592 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5593 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5594 (.bitmaps_last, struct x_output.icon_bitmap):
5595 Use ptrdiff_t, not int, for bitmap indexes.
5596 (x_allocate_bitmap_record): Check for size overflow.
5597 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5598
b081724f
PE
5599 Use ptrdiff_t, not int, for overlay counts.
5600 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5601 * editfns.c (overlays_around, get_pos_property):
5602 * textprop.c (get_char_property_and_overlay):
5603 * xdisp.c (next_overlay_change, note_mouse_highlight):
5604 * xfaces.c (face_at_buffer_position):
21514da7
PE
5605 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5606 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5607 (Fnext_overlay_change, Fprevious_overlay_change)
5608 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5609 Use ptrdiff_t, not int, for sizes.
21514da7 5610 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5611
3de73e5e
PE
5612 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5613
2606c57b
PE
5614 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5615 (x_session_initialize): Do not assume string length fits in int.
5616
aaafe47a
PE
5617 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5618 This is unlikely, but can occur if DPI is outlandish.
5619
2674ddc8 5620 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5621 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5622
28154962
PE
5623 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5624 * xrdb.c (magic_file_p, search_magic_path):
5625 Omit last arg SUFFIX; it was always 0. All callers changed.
5626 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5627
7de51af5
PE
5628 * xfont.c (xfont_match): Avoid need for strlen.
5629
25ed6cc3
PE
5630 * xfns.c: Don't assume strlen fits in int.
5631 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5632
4eab31dd
PE
5633 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5634 not unsigned long, as we prefer signed integers. All callers changed.
5635 Detect integer overflow in repeat count.
5636 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5637 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5638
171e2a58
PE
5639 * termcap.c: Don't assume sizes fit in int and never overflow.
5640 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5641 (gobble_line): Check for size-calculation overflow.
5642
ad39faca 5643 * minibuf.c (Fread_buffer):
6e5bb2dc 5644 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5645 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5646 Don't assume string length fits in int.
5647
52c61c22 5648 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5649 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5650
b5b8c9e5
PE
5651 * font.c: Don't assume string length fits in int.
5652 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5653 Use ptrdiff_t, not int.
ccd6111c
PE
5654 (font_intern_prop): Don't assume string length fits in int.
5655 Don't assume integer property fits in fixnum.
5656 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5657
882f0d81 5658 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5659 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5660 Reformulate so as not to need the command string.
5661 Invoke gzip -cd rather than gunzip, as it's more portable.
5662 (lock_info_type, lock_file_1, lock_file):
5663 Don't assume pid_t and time_t fit in unsigned long.
5664 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5665 (current_lock_owner): Prefer signed type for sizes.
5666 Use memcpy, not strncpy, where memcpy is what is really wanted.
5667 Don't assume (via atoi) that time_t and pid_t fit in int.
5668 Check for time_t and/or pid_t out of range, e.g., via a network share.
5669 Don't alloca where an auto var works fine.
5670
93f4cf88
PE
5671 * fileio.c: Fix some integer overflow issues.
5672 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5673 Don't assume string length fits in int.
5674 (directory_file_name): Don't assume string length fits in long.
5675 (make_temp_name): Don't assume pid fits in int, or that its print
5676 length is less than 20.
5677
f3e92b69
PE
5678 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5679
1bfdaf10
PE
5680 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5681
35016e9a
PE
5682 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5683
3d1e65a1
PE
5684 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5685 We prefer signed integers, even for size calculations.
5686
0b963a93
PE
5687 * emacs.c: Don't assume string length fits in 'int'.
5688 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5689 (main): Don't invoke strlen when not needed.
5690
573f4b54
PE
5691 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5692 (XD_DEBUG_MESSAGE): Don't waste a byte.
5693
989f33ba
PE
5694 * callproc.c (getenv_internal_1, getenv_internal)
5695 (Fgetenv_internal):
965d34eb
PE
5696 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5697
e4d29b33
PE
5698 * lread.c (invalid_syntax): Omit length argument.
5699 All uses changed. This doesn't fix a bug, but it simplifies the
5700 code away from its former Hollerith-constant appearance, and it's
5701 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5702 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5703
eb49b136
PE
5704 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5705 This didn't break anything, but it didn't help either.
5706 It's confusing to put a bogus integer in a place where the actual
5707 value does not matter.
9f62aeb1 5708 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5709 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5710
15375a22
PE
5711 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5712 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5713 implementation.
b61cc01c
PE
5714 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5715 We prefer signed types, and the value cannot exceed the EMACS_INT
5716 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5717 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5718 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5719 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5720
53b2623d
PE
5721 * indent.c (sane_tab_width): New function.
5722 (current_column, scan_for_column, Findent_to, position_indentation)
5723 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5724 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5725
51cab52b 5726 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5727
f2ed8a70
PE
5728 * lisp.h (lint_assume): New macro.
5729 * composite.c (composition_gstring_put_cache):
5730 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5731
abe80cc6
PE
5732 * editfns.c, insdel.c:
5733 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5734
b02c740e
PE
5735 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5736
ebc96716
PE
5737 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5738
b4e50fa0 5739 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5740 Use much-faster test for byte-length change.
311d5d7c 5741 Don't assume string byte-length fits in 'int'.
a4cf38e4 5742 Check that character arg fits in 'int'.
85461888 5743 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5744
c0c1ee9f
PE
5745 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5746
a498d7f4
PE
5747 * fns.c (concat): Catch string overflow earlier.
5748 Do not rely on integer wraparound.
5749
51cab52b
PE
5750 * dispextern.h (struct it.overlay_strings_charpos)
5751 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5752 * xdisp.c (forward_to_next_line_start)
5753 (back_to_previous_visible_line_start)
5754 (reseat_at_next_visible_line_start, next_element_from_buffer):
5755 Don't arbitrarily truncate the value of 'selective' to int.
5756
76031fad
PE
5757 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5758
5eb55db9
PE
5759 * composite.c: Don't truncate sizes to 'int'.
5760 (composition_gstring_p, composition_reseat_it)
5761 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5762 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5763 not EMACS_UINT, for indexes.
5eb55db9 5764
0703a717
PE
5765 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5766
d6202519
PE
5767 * buffer.c: Include <verify.h>.
5768 (struct sortvec.priority, struct sortstr.priority):
8961a454 5769 Now EMACS_INT, not int.
c20998a7 5770 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5771 (struct sortstr.size, record_overlay_string)
5772 (struct sortstrlist.size, struct sortlist.used):
5773 Don't truncate size to int.
5774 (record_overlay_string): Check for size-calculation overflow.
d6202519 5775 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5776
d5a19415
JM
57772011-06-22 Jim Meyering <meyering@redhat.com>
5778
029529ac 5779 Don't leak an XBM-image-sized buffer
d5a19415
JM
5780 * image.c (xbm_load): Free the image buffer after using it.
5781
a9041e6c
PE
57822011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5783
5784 Port to Sun C.
5785 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5786 that Sun C diagnosed.
5787 * fns.c (secure_hash): Fix pointer signedness issue.
5788 * intervals.c (static_offset_intervals): New function.
5789 (offset_intervals): Use it.
5790
7f3f739f
LL
57912011-06-21 Leo Liu <sdl.web@gmail.com>
5792
5793 * deps.mk (fns.o):
5794 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5795 sha512.h.
5796
5797 * fns.c (secure_hash): Rename from crypto_hash_function and change
5798 the first arg to accept symbols.
5b66d427 5799 (Fsecure_hash): New primitive.
7f3f739f
LL
5800 (syms_of_fns): New symbols.
5801
76147d94
DD
58022011-06-20 Deniz Dogan <deniz@dogan.se>
5803
5804 * process.c (Fset_process_buffer): Clarify return value in
5805 docstring.
5806
7d7d0045
CY
58072011-06-18 Chong Yidong <cyd@stupidchicken.com>
5808
5809 * dispnew.c (add_window_display_history): Use BVAR.
5810
5811 * xdisp.c (debug_method_add): Use BVAR.
5812 (check_window_end, dump_glyph_matrix, dump_glyph)
5813 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5814
5815 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5816 Likewise.
5817
5818 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5819 check till after the cache is created in init_frame_faces.
5820
ff2bc410
SM
58212011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5822
5823 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5824
28177add
PE
58252011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5826
dd3482fe
PE
5827 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5828 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5829 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5830
393d71f3 5831 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5832 * fileio.c (Finsert_file_contents):
5833 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5834 Remove the old (too-loose) buffer overflow checks.
5835 They weren't needed, since make_gap checks for buffer overflow.
5836 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5837 The old code merely checked for Emacs fixnum overflow, and relied
5838 on undefined (wraparound) behavior. The new code avoids undefined
5839 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5840
2e6813b0 5841 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5842 Tune. Don't use wider integers than needed. Don't use alloca.
5843 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5844
599a9e4f
PE
5845 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5846
99561444
PE
5847 * insdel.c, lisp.h (buffer_overflow): New function.
5848 (insert_from_buffer_1, replace_range, replace_range_2):
5849 * insdel.c (make_gap_larger):
5850 * editfns.c (Finsert_char):
5851 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5852
28177add
PE
5853 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5854
e69dafad
PE
58552011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5856
4baa020d 5857 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5858
b1c46f02
PE
5859 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5860 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5861
e69dafad
PE
5862 * fileio.c: Don't assume EMACS_INT fits in off_t.
5863 (emacs_lseek): New static function.
5864 (Finsert_file_contents, Fwrite_region): Use it.
5865 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5866
566684ea
PE
5867 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5868
e6966cd6
PE
5869 * fns.c: Don't overflow int when computing a list length.
5870 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5871 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5872 truncation on 64-bit hosts. Check for QUIT every
5873 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5874 faster and is responsive enough.
5875 (Flength): Report an error instead of overflowing an integer.
5876 (Fsafe_length): Return a float if the value is not representable
5877 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5878 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5879 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5880
dd0b0efb
PE
5881 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5882 (header_size, word_size): New constants.
5883 (allocate_vectorlike): Don't check size overflow here.
5884 (allocate_vector): Check it here instead, since this is the only
5885 caller of allocate_vectorlike that could cause overflow.
5886 Check that the new vector's length is representable as a fixnum.
5887
86fe5cfe
PE
5888 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5889 The previous code was bogus. For example, next_almost_prime (32)
5890 returned 39, which is undesirable as it is a multiple of 3; and
5891 next_almost_prime (24) returned 25, which is a multiple of 5 so
5892 why was the code bothering to check for multiples of 7?
5893
80e88859
PE
5894 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5895
4a2f0ad6
PE
5896 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5897
f66c7cf8
PE
5898 Variadic C functions now count arguments with ptrdiff_t.
5899 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5900 Back then I didn't know that the Emacs coding style prefers signed int.
5901 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5902 were being counted with int, which may truncate counts on 64-bit
5903 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5904 * lisp.h (struct Lisp_Subr.function.aMANY)
5905 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5906 Arg counts are now ptrdiff_t, not size_t.
5907 All variadic functions and their callers changed accordingly.
5908 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5909 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5910 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5911 * callint.c (Fcall_interactively): Check arg count for overflow,
5912 to avoid potential buffer overrun. Use signed char, not 'int',
5913 for 'varies' array, so that we needn't bother to check its size
5914 calculation for overflow.
5915 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5916 * eval.c (apply_lambda):
5917 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5918 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5919 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5920
a1759b76
PE
5921 * callint.c (Fcall_interactively): Don't use index var as event count.
5922
d96be9fc
PE
5923 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5924 * mem-limits.h (SIZE): Remove; no longer used.
5925
a690a978 5926 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5927
578c21e6
PE
5928 Remove unnecessary casts.
5929 * xterm.c (x_term_init):
5930 * xfns.c (x_set_border_pixel):
5931 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5932 These aren't needed now that we assume ANSI C.
5933
96f53c6c
PE
5934 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5935 It's more likely to cause problems (due to unsigned overflow)
5936 than to cure them.
5937
83c77d31
PE
5938 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5939
ee2079f1
PE
5940 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5941
6da65536
PE
5942 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5943
7147c4a4
PE
5944 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5945
193e32d9
PE
5946 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5947
e5533da6
PE
5948 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5949
9910e595
PE
5950 GLYPH_CODE_FACE returns EMACS_INT, not int.
5951 * dispextern.h (merge_faces):
5952 * xfaces.c (merge_faces):
01103c44
PE
5953 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5954 Don't assume EMACS_INT fits in int.
9910e595 5955
2638320e
PE
5956 * character.h (CHAR_VALID_P): Remove unused parameter.
5957 * fontset.c, lisp.h, xdisp.c: All uses changed.
5958
045eb8d9
PE
5959 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5960
c1f134b5
PE
5961 * fns.c (concat): Minor tuning based on overflow analysis.
5962 This doesn't fix any bugs. Use int to hold character, instead
5963 of constantly refetching from Emacs object. Use XFASTINT, not
5964 XINT, for value known to be a character. Don't bother comparing
5965 a single byte to 0400, as it's always less.
5966
395fcb93 5967 * floatfns.c (Fexpt):
327eeec8
PE
5968 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5969
abbd3d23
PE
5970 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5971 for characters.
5972
684a03ef
PE
5973 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5974
0fed43f3
PE
5975 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5976 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5977 incorrectly succeed when S was a string, because 4294967386 was
5978 truncated before it was used.
5979
8fd02eb7
PE
5980 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5981 Otherwise, an out-of-range integer could cause undefined behavior
5982 on a 64-bit host.
5983
f8c86b69
PE
5984 * composite.c: Use int, not EMACS_INT, for characters.
5985 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5986 EMACS_INT, for values that are known to be in character range.
5987 This doesn't fix any bugs but is the usual style inside Emacs and
5988 may generate better code on 32-bit machines.
5989
34206dd2
PE
5990 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5991 This is for reasons similar to the recent CHAR_STRING fix.
5992 * charset.c (Fencode_char): Check that character arg is actually
5993 a character. Pass an int to ENCODE_CHAR.
5994 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5995 wider than 'int', as a compile-time check to prevent future regressions
5996 in this area.
5997
c5958d4c 5998 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5999
6000 Make sure a 64-bit char is never passed to CHAR_STRING.
6001 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6002 by silently ignoring the top 32 bits, allowing some values
6003 that were far too large to be valid characters.
6004 * character.h: Include <verify.h>.
6005 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6006 arguments are no wider than unsigned, as a compile-time check
6007 to prevent future regressions in this area.
6008 * data.c (Faset):
01103c44 6009 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
6010 (Fsubst_char_in_region):
6011 * fns.c (concat):
6012 * xdisp.c (decode_mode_spec_coding):
6013 Adjust to CHAR_STRING's new requirement.
6014 * editfns.c (Finsert_char, Fsubst_char_in_region):
6015 * fns.c (concat): Check that character args are actually
6016 characters. Without this test, these functions did the wrong
6017 thing with wildly out-of-range values on 64-bit hosts.
6018
d37ca623
PE
6019 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6020 These casts should not be needed on 32-bit hosts, either.
6021 * keyboard.c (read_char):
6022 * lread.c (Fload): Remove casts to unsigned.
6023
ea204efb
PE
6024 * lisp.h (UNSIGNED_CMP): New macro.
6025 This fixes comparison bugs on 64-bit hosts.
6026 (ASCII_CHAR_P): Use it.
6027 * casefiddle.c (casify_object):
01103c44 6028 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
6029 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6030 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6031 * dispextern.h (FACE_FROM_ID):
6032 * keyboard.c (read_char): Use UNSIGNED_CMP.
6033
41cb286c
PE
6034 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6035 not to EMACS_INT, to avoid GCC warning.
6036
4a1b9832
PE
6037 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6038
55daad71
PE
6039 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6040 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6041 isn't needed on 32-bit machines.
8f95c75c 6042
01103c44
PE
6043 * buffer.c (Fgenerate_new_buffer_name):
6044 Use EMACS_INT for count, not int.
0ceccced 6045 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
6046
6047 * data.c (Qcompiled_function): Now static.
6048
c6f072e7
PE
6049 * window.c (window_body_lines): Now static.
6050
20ce5912
PE
6051 * image.c (gif_load): Rename local to avoid shadowing.
6052
9c4c5f81
PE
6053 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6054 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6055 * alloc.c (make_save_value): Integer argument is now of type
6056 ptrdiff_t, not int.
6057 (mark_object): Use ptrdiff_t, not int.
6058 * lisp.h (pD): New macro.
6059 * print.c (print_object): Use it.
6060
c0c5c8ae
PE
6061 * alloc.c: Use EMACS_INT, not int, to count objects.
6062 (total_conses, total_markers, total_symbols, total_vector_size)
6063 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
6064 (total_free_floats, total_floats, total_free_intervals)
6065 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
6066 Now EMACS_INT, not int. All uses changed.
6067 (Fgarbage_collect): Compute overall total using a double, so that
6068 integer overflow is less likely to be a problem. Check for overflow
6069 when converting back to an integer.
5a25e253
PE
6070 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6071 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6072 These were 'int' variables that could overflow on 64-bit hosts;
6073 they were never used, so remove them instead of repairing them.
211a0b2a 6074 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
6075 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6076 Previously, this ceilinged at INT_MAX, but that doesn't work on
6077 64-bit machines.
e46bb31a 6078 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 6079
c78baabf 6080 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 6081 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
6082 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6083 when a (possibly-narrower) signed value would do just as well.
6084 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 6085
c9d624c6
PE
6086 * alloc.c: Catch some string size overflows that we were missing.
6087 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6088 for convenience in STRING_BYTES_MAX.
6089 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6090 The definition here is exact; the one in lisp.h was approximate.
6091 (allocate_string_data): Check for string overflow. This catches
6092 some instances we weren't catching before. Also, it catches
6093 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6094 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6095 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 6096
c9d624c6
PE
6097 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6098 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 6099 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 6100
353032ce
PE
6101 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6102
2bccce07
PE
6103 * alloc.c (Fmake_string): Check for out-of-range init.
6104
0ac30604
SM
61052011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6106
6107 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6108
c195f2de
JD
61092011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6110
6111 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6112 xg_get_default_scrollbar_width.
6113
6114 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6115 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6116 (style_changed_cb): Call update_theme_scrollbar_width and call
6117 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6118 all frames (Bug#8505).
6119 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6120 Call gtk_window_set_resizable if HAVE_GTK3.
6121 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6122 and height if HAVE_GTK3 (Bug#8505).
6123 (scroll_bar_width_for_theme): New variable.
6124 (update_theme_scrollbar_width): New function.
6125 (xg_get_default_scrollbar_width): Move code to
6126 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6127 (xg_initialize): Call update_theme_scrollbar_width.
6128
6129 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6130
6131 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6132
e10ac9f1
MR
61332011-06-12 Martin Rudalics <rudalics@gmx.at>
6134
6135 * frame.c (make_frame): Call other_buffer_safely instead of
6136 other_buffer.
6137
6138 * window.c (temp_output_buffer_show): Call display_buffer with
6139 second argument Vtemp_buffer_show_specifiers and reset latter
6140 immediately after the call.
6141 (Vtemp_buffer_show_specifiers): New variable.
6142 (auto_window_vscroll_p, next_screen_context_lines)
6143 (Vscroll_preserve_screen_position): Remove leading asterisks from
6144 doc-strings.
6145
2d3c217e 61462011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 6147
7b7f97e8 6148 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
6149 * buffer.c (Qclone_number): Remove for now, as it's unused.
6150 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6151 (record_buffer): Remove unused local.
6152 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6153 (set_frame_buffer_list): Remove; unused.
6154 * frame.h (other_visible_frames): Remove decl.
6155 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6156 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6157 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6158 if HAVE_GPM.
6159 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6160 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6161 Define only if HAVE_GPM.
6162 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6163 (update_hints_inhibit): Remove; never set. All uses removed.
6164 * widgetprv.h (emacsFrameClassRec): Remove decl.
6165 * window.c (delete_deletable_window): Now returns void, since it
6166 wasn't returning anything.
6167 (compare_window_configurations): Remove unused locals.
6168 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6169 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
6170 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6171 the same widths as pointers. This follows up on the 2011-05-06 patch.
6172 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6173 * xterm.h: Likewise.
6174 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6175
1384b89e
JB
61762011-06-12 Juanma Barranquero <lekktu@gmail.com>
6177
6178 * makefile.w32-in: Update dependencies.
6179 (LISP_H): Add lib/intprops.h.
6180
1100a63c
CY
61812011-06-11 Chong Yidong <cyd@stupidchicken.com>
6182
6183 * image.c (gif_load): Add animation frame delay to the metadata.
6184 (syms_of_image): Use DEFSYM. New symbol `delay'.
6185
6198ccd0
MR
61862011-06-11 Martin Rudalics <rudalics@gmx.at>
6187
6188 * window.c (delete_deletable_window): Re-add.
6189 (Fset_window_configuration): Rewrite to handle dead buffers and
6190 consequently deletable windows.
6191 (window_tree, Fwindow_tree): Remove. Supply functionality in
6192 window.el.
6193 (compare_window_configurations): Simplify code.
6194
b6e3633c
AS
61952011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6196
1ab0dee5
AS
6197 * image.c (imagemagick_load_image): Fix type mismatch.
6198 (Fimagemagick_types): Likewise.
6199
b6e3633c
AS
6200 * window.h (replace_buffer_in_windows): Declare.
6201
9397e56f
MR
62022011-06-11 Martin Rudalics <rudalics@gmx.at>
6203
6204 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6205 Qclone_number. Remove external declaration of Qdelete_window.
6206 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6207 code.
640c8776
SM
6208 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6209 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
6210 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6211 buffer list implementation.
6212 (other_buffer_safely): New function.
6213 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6214 calls to replace_buffer_in_windows and
6215 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6216 if allowed.
6217 (record_buffer): Inhibit quitting and rewrite using quittable
6218 functions. Run Qbuffer_list_update_hook if allowed.
6219 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
6220 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6221 Move switch-to-buffer to window.el.
9397e56f
MR
6222 (bury-buffer): Move to window.el.
6223 (Vbuffer_list_update_hook): New variable.
6224
6225 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6226 section.
6227
6228 * window.h (resize_frame_windows): Move up in code.
6229 (Fwindow_frame): Remove EXFUN.
6230 (replace_buffer_in_all_windows): Remove prototype.
6231 (replace_buffer_in_windows_safely): Add prototype.
6232
6233 * window.c: Declare Qdelete_window static again. Move down
6234 declaration of select_count.
6235 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6236 (Fother_window): Move to window.el.
6237 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6238 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6239 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6240 window.el.
6241 (replace_buffer_in_windows): Implement by calling
6242 Qreplace_buffer_in_windows.
6243 (replace_buffer_in_all_windows): Remove with some functionality
6244 moved into replace_buffer_in_windows_safely.
6245 (replace_buffer_in_windows_safely): New function.
6246 (select_window_norecord, select_frame_norecord): Move in front
6247 of run_window_configuration_change_hook. Remove now obsolete
6248 declarations.
640c8776
SM
6249 (Fset_window_buffer): Rewrite doc-string.
6250 Call Qrecord_window_buffer.
9397e56f
MR
6251 (keys_of_window): Move binding for other-window to window.el.
6252
b50691aa
CY
62532011-06-11 Chong Yidong <cyd@stupidchicken.com>
6254
6255 * dispextern.h (struct image): Replace data member, whose int_val
6256 and ptr_val fields were not used by anything, with a single
6257 lisp_val object.
6258
6259 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6260 (gif_clear_image, gif_load, imagemagick_load_image)
6261 (gs_clear_image, gs_load): Callers changed.
6262
3f754b86
PE
62632011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6264
cca69397
PE
6265 * buffer.h: Include <time.h>, for time_t.
6266 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6267
109e28d0
PE
6268 Fix minor problems found by static checking.
6269
60737f02
PE
6270 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6271
4b66faf3
PE
6272 Make identifiers static if they are not used in other modules.
6273 * data.c (Qcompiled_function, Qframe, Qvector):
6274 * image.c (QimageMagick, Qsvg):
6275 * minibuf.c (Qmetadata):
6276 * window.c (resize_window_check, resize_root_window): Now static.
6277 * window.h (resize_window_check, resize_root_window): Remove decls.
6278
109e28d0
PE
6279 * window.c (window_deletion_count, delete_deletable_window):
6280 Remove; unused.
46a4ce9e
PE
6281 (window_body_lines): Now static.
6282 (Fdelete_other_windows_internal): Mark vars as initialized.
6283 Make sure 'resize_failed' is initialized.
6284 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6285 (resize_window_apply): Remove unused local.
6286 * window.h (delete_deletable_window): Remove decl.
6287
109e28d0 6288 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
6289 (imagemagick_load_image): Fix pointer signedness problem by changing
6290 last arg from unsigned char * to char *. All uses changed.
6291 Also, fix a local for similar reasons.
6292 Remove unused locals. Remove locals to avoid shadowing.
6293 (fn_rsvg_handle_free): Remove; unused.
6294 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 6295 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 6296
3f754b86
PE
6297 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6298
2547adb1
CY
62992011-06-10 Chong Yidong <cyd@stupidchicken.com>
6300
6301 * image.c (gif_load): Fix omitted cast error introduced by
6302 2011-06-06 change.
6303
2c8e37d4
MR
63042011-06-10 Martin Rudalics <rudalics@gmx.at>
6305
6306 * window.h (resize_proportionally, orig_total_lines)
6307 (orig_top_line): Remove from window structure.
6308 (set_window_height, set_window_width, change_window_heights)
6309 (Fdelete_window): Remove prototypes.
6310 (resize_frame_windows): Remove duplicate declaration.
6311
440a42e3
EZ
63122011-06-10 Eli Zaretskii <eliz@gnu.org>
6313
6314 * window.h (resize_frame_windows, resize_window_check)
6315 (delete_deletable_window, resize_root_window)
6316 (resize_frame_windows): Declare prototypes.
6317
6318 * window.c (resize_window_apply): Make definition be "static" to
6319 match the prototype.
6320
562dd5e9
MR
63212011-06-10 Martin Rudalics <rudalics@gmx.at>
6322
6323 * window.c: Remove declarations of Qwindow_size_fixed,
6324 window_min_size_1, window_min_size_2, window_min_size,
6325 size_window, window_fixed_size_p, enlarge_window, delete_window.
6326 Remove static from declaration of Qdelete_window, it's
6327 temporarily needed by Fbury_buffer.
6328 (replace_window): Don't assign orig_top_line and
6329 orig_total_lines.
6330 (Fdelete_window, delete_window): Remove. Window deletion is
6331 handled by window.el.
640c8776
SM
6332 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6333 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
6334 (Fdelete_other_windows): Remove. Deleting other windows is
6335 handled by window.el.
6336 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6337 handled in window.el.
6338 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6339 Window minimum sizes are handled in window.el.
6340 (shrink_windows, size_window, set_window_height)
6341 (set_window_width, change_window_heights, window_height)
6342 (window_width, CURBEG, CURSIZE, enlarge_window)
6343 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6344 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6345 handled in window.el.
6346 (make_dummy_parent): Rename to make_parent_window and give it a
6347 second argument horflag.
6348 (make_window): Don't set resize_proportionally any more.
6349 (Fsplit_window): Remove. Windows are split in window.el.
6350 (save_restore_action, save_restore_orig_size)
6351 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6352 Resize mini windows in window.el.
6353 (grow_mini_window, shrink_mini_window): Implement by calling
6354 Qresize_root_window_vertically, resize_window_check and
6355 resize_window_apply.
640c8776
SM
6356 (saved_window, Fset_window_configuration, save_window_save):
6357 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6358 resize_proportionally.
6359 (window_min_height, window_min_width): Move to window.el.
6360 (keys_of_window): Move bindings for delete-other-windows,
6361 split-window, delete-window and enlarge-window to window.el.
6362
6363 * buffer.c: Temporarily extern Qdelete_window.
6364 (Fbury_buffer): Temporarily call Qdelete_window instead of
6365 Fdelete_window (Fbury_buffer will move to window.el soon).
6366
6367 * frame.c (set_menu_bar_lines_1): Remove code handling
6368 orig_top_line and orig_total_lines.
6369
6370 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6371 set_window_height but set heights directly.
6372 (change_frame_size_1): Use resize_frame_windows.
6373
6374 * xdisp.c (init_xdisp): Don't use set_window_height but set
6375 heights directly.
6376
640c8776
SM
6377 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6378 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6379 run_window_configuration_change_hook.
6380
6381 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6382 instead of change_window_heights and run
6383 run_window_configuration_change_hook.
6384
1a13852e
MR
63852011-06-09 Martin Rudalics <rudalics@gmx.at>
6386
6387 * window.c (replace_window): Rename second argument REPLACEMENT to
6388 NEW. New third argument SETFLAG. Rewrite.
6389 (delete_window, make_dummy_parent): Call replace_window with
6390 third argument 1.
6391 (window_list_1): Move down in code.
6392 (run_window_configuration_change_hook): Move set_buffer part
6393 before select_frame_norecord part in order to unwind correctly.
6394 Rename count1 to count.
6395 (recombine_windows, delete_deletable_window, resize_root_window)
6396 (Fdelete_other_windows_internal)
6397 (Frun_window_configuration_change_hook, make_parent_window)
6398 (resize_window_check, resize_window_apply, Fresize_window_apply)
6399 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6400 (Fdelete_window_internal, Fresize_mini_window_internal):
6401 New functions.
1a13852e
MR
6402 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6403
f3d1777e
MR
64042011-06-08 Martin Rudalics <rudalics@gmx.at>
6405
496e208e
MR
6406 * window.h (window): Add some new members to window structure -
6407 normal_lines, normal_cols, new_total, new_normal, clone_number,
6408 splits, nest, prev_buffers, next_buffers.
6409 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6410 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6411
f3d1777e
MR
6412 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6413 Remove.
496e208e
MR
6414 (make_dummy_parent): Set new members of windows structure.
6415 (make_window): Move down in code. Handle new members of window
6416 structure.
6417 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6418 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6419 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6420 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6421 (Fset_window_next_buffers, Fset_window_clone_number):
6422 New functions.
496e208e
MR
6423 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6424 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6425 Doc-string fixes.
6426 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6427 Argument WINDOW can be now internal window too.
6428 (Fwindow_use_time): Move up in code.
6429 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6430 Rewrite doc-string.
6431 (Fset_window_configuration, saved_window)
6432 (Fcurrent_window_configuration, save_window_save): Handle new
6433 members of window structure.
b9e809c2
MR
6434 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6435 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6436 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6437 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6438 Qget_mru_window, Qresize_root_window,
6439 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6440 Qauto_buffer_name; staticpro them.
f3d1777e 6441
abde8f8c
MR
64422011-06-07 Martin Rudalics <rudalics@gmx.at>
6443
6444 * window.c (Fwindow_total_size, Fwindow_left_column)
6445 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6446 (Fwindow_list_1): New functions.
6447 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6448 (Fwindow_width, Fscroll_left, Fscroll_right):
6449 Use window_body_cols instead of window_box_text_cols.
6450 (delete_window, Fset_window_configuration):
6451 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6452 (delete_all_subwindows): Take a window as argument and not a
6453 structure. Rewrite.
190b47e6
MR
6454 (window_loop): Remove handling of GET_LRU_WINDOW and
6455 GET_LARGEST_WINDOW.
6456 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6457
6458 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6459 window_box_text_cols. delete_all_subwindows now takes a
6460 Lisp_Object as argument.
abde8f8c 6461
640c8776
SM
6462 * indent.c (compute_motion, Fcompute_motion):
6463 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6464
fa8a67e6
MR
6465 * frame.c (delete_frame): Call delete_all_subwindows with root
6466 window as argument.
6467
a54e3482
DC
64682011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6469
6470 * fns.c (Fputhash): Document return value.
6471
60002bf5
CY
64722011-06-06 Chong Yidong <cyd@stupidchicken.com>
6473
6474 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6475
0c671da6 64762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6477
b862a52a 6478 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6479
be44ca6c
PE
6480 Check for overflow when converting integer to cons and back.
6481 * charset.c (Fdefine_charset_internal, Fdecode_char):
6482 Use cons_to_unsigned to catch overflow.
6483 (Fencode_char): Use INTEGER_TO_CONS.
6484 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6485 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6486 * data.c (long_to_cons, cons_to_long): Remove.
6487 (cons_to_unsigned, cons_to_signed): New functions.
6488 These signal an error for invalid or out-of-range values.
6489 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6490 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6491 * font.c (Ffont_variation_glyphs):
6492 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6493 * lisp.h: Include <intprops.h>.
6494 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6495 (cons_to_signed, cons_to_unsigned): New decls.
6496 (long_to_cons, cons_to_long): Remove decls.
6497 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6498 (Fprimitive_undo): Use CONS_TO_INTEGER.
6499 * xfns.c (Fx_window_property): Likewise.
6500 * xselect.c: Include <limits.h>.
6501 (x_own_selection, selection_data_to_lisp_data):
6502 Use INTEGER_TO_CONS.
6503 (x_handle_selection_request, x_handle_selection_clear)
6504 (x_get_foreign_selection, Fx_disown_selection_internal)
6505 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6506 (lisp_data_to_selection_data): Use cons_to_unsigned.
6507 (x_fill_property_data): Use cons_to_signed.
6508 Report values out of range.
6509
d1f3d2af
PE
6510 Check for buffer and string overflow more precisely.
6511 * buffer.h (BUF_BYTES_MAX): New macro.
6512 * lisp.h (STRING_BYTES_MAX): New macro.
6513 * alloc.c (Fmake_string):
6514 * character.c (string_escape_byte8):
6515 * coding.c (coding_alloc_by_realloc):
6516 * doprnt.c (doprnt):
6517 * editfns.c (Fformat):
6518 * eval.c (verror):
6519 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6520 since they may not be the same number.
6521 * editfns.c (Finsert_char):
6522 * fileio.c (Finsert_file_contents):
6523 Likewise for BUF_BYTES_MAX.
6524
dd52fcea
PE
6525 * image.c: Use ptrdiff_t, not int, for sizes.
6526 (slurp_file): Switch from int to ptrdiff_t.
6527 All uses changed.
6528 (slurp_file): Check that file size fits in both size_t (for
6529 malloc) and ptrdiff_t (for sanity and safety).
6530
7f9bbdbb
PE
6531 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6532 if b->modtime has its maximal value.
6533
dfe18f82
PE
6534 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6535
84acfcf0
PE
6536 Don't assume time_t can fit into int.
6537 * buffer.h (struct buffer.modtime): Now time_t, not int.
6538 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6539 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6540
ccd9a01a
PE
6541 Minor fixes for signed vs unsigned integers.
6542 * character.h (MAYBE_UNIFY_CHAR):
6543 * charset.c (maybe_unify_char):
6544 * keyboard.c (read_char, reorder_modifiers):
6545 XINT -> XFASTINT, since the integer must be nonnegative.
6546 * ftfont.c (ftfont_spec_pattern):
6547 * keymap.c (access_keymap, silly_event_symbol_error):
6548 XUINT -> XFASTINT, since the integer must be nonnegative.
6549 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6550 since it makes no difference and we prefer signed.
6551 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6552 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6553 nonnegative.
6554
d6d100dd
SM
65552011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6556
6557 * window.h (Fwindow_frame): Declare.
6558
2b6148e4
PE
65592011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6560
6561 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6562 (SPARE_MEMORY): Always define.
6563 (LARGE_REQUEST): Remove.
6564 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6565
f230ecc9
MR
65662011-06-06 Martin Rudalics <rudalics@gmx.at>
6567
727e958e
MR
6568 * lisp.h: Move EXFUNS for Fframe_root_window,
6569 Fframe_first_window and Fset_frame_selected_window to window.h.
6570
6571 * window.h: Move EXFUNS for Fframe_root_window,
6572 Fframe_first_window and Fset_frame_selected_window here from
6573 lisp.h.
6574
6575 * frame.c (Fwindow_frame, Fframe_first_window)
6576 (Fframe_root_window, Fframe_selected_window)
6577 (Fset_frame_selected_window): Move to window.c.
6578 (Factive_minibuffer_window): Move to minibuf.c.
6579 (Fother_visible_frames_p): New function.
6580
6581 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6582
f230ecc9
MR
6583 * window.c (decode_window, decode_any_window): Move up in code.
6584 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6585 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6586 (Fwindow_buffer): Move up and rewrite doc-string.
6587 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6588 (Fwindow_prev): New functions.
727e958e
MR
6589 (Fwindow_frame): Move here from frame.c. Accept any window as
6590 argument.
6591 (Fframe_root_window, Fframe_first_window)
6592 (Fframe_selected_window): Move here from frame.c. Accept frame
6593 or arbitrary window as argument. Update doc-strings.
6594 (Fminibuffer_window): Move up in code.
6595 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6596 (Fset_frame_selected_window): Move here from frame.c.
6597 Marginal rewrite.
727e958e
MR
6598 (Fselected_window, select_window, Fselect_window): Move up in
6599 code. Minor doc-string fixes.
f230ecc9 6600
4d09bcf6
PE
66012011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6602
6603 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6604 Do not assume that spare memory exists; that assumption is valid
6605 only if SYSTEM_MALLOC.
6606 (LARGE_REQUEST): New macro, so that the issue of large requests
6607 is separated from the issue of spare memory.
6608
810928a2
AS
66092011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6610
172418ad
AS
6611 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6612 format. (Bug#8806)
6613
43f862f7
AS
6614 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6615
810928a2
AS
6616 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6617 before statements.
6618
a059fe24
JD
66192011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6620
6621 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6622
6623 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6624
6625 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6626 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6627
989bf368
JB
66282011-06-05 Juanma Barranquero <lekktu@gmail.com>
6629
6630 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6631
4b80f674
CY
66322011-06-04 Chong Yidong <cyd@stupidchicken.com>
6633
6634 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6635 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6636 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6637 New error handlers.
4b80f674
CY
6638 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6639 Obey Vx_select_enable_clipboard_manager. Catch errors in
6640 x_clipboard_manager_save (Bug#8779).
6641 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6642 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6643
99a33b77 66442011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6645
6646 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6647
99a33b77 66482011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6649
6650 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6651 in the current matrix if keep_current_p is non-zero.
6652
8264569d
EZ
66532011-06-04 Eli Zaretskii <eliz@gnu.org>
6654
6655 * bidi.c (bidi_level_of_next_char): Fix last change.
6656
57f97249
EZ
66572011-06-03 Eli Zaretskii <eliz@gnu.org>
6658
fec2107c 6659 Support bidi reordering of text covered by display properties.
57f97249 6660
fec2107c
EZ
6661 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6662 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6663 (bidi_cache_search, bidi_cache_iterator_state)
6664 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6665 (bidi_level_of_next_char, bidi_move_to_visually_next):
6666 Support character positions inside a run of characters covered by a
fec2107c
EZ
6667 display string.
6668 (bidi_paragraph_init, bidi_resolve_explicit_1)
6669 (bidi_level_of_next_char): Call bidi_fetch_char and
6670 bidi_fetch_char_advance instead of FETCH_CHAR and
6671 FETCH_CHAR_ADVANCE.
6672 (bidi_init_it): Initialize new members.
6673 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6674 definitions.
6675 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6676 instead of using explicit *_CHAR codes.
d6d100dd
SM
6677 (bidi_resolve_explicit, bidi_resolve_weak):
6678 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6679 bidirectional text is supported only in multibyte buffers.
6680 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6681 it to initialize the frame_window_p member of struct bidi_it.
6682 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6683 (bidi_resolve_explicit, bidi_resolve_weak)
6684 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6685 bidi_it->nchars is non-positive.
6686 (bidi_level_of_next_char): Don't try to lookup the cache for the
6687 next/previous character if nothing is cached there yet, or if we
6688 were just reseat()'ed to a new position.
c40e2fb2 6689
0e14fe90
EZ
6690 * xdisp.c (set_cursor_from_row): Set start and stop points
6691 according to the row's direction when priming the loop that looks
6692 for the glyph on which to display cursor.
6693 (single_display_spec_intangible_p): Function deleted.
6694 (display_prop_intangible_p): Reimplement to call
6695 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6696 Accept 3 additional arguments needed by handle_display_spec.
6697 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6698 values: lists, `(when COND...)' forms, etc.
6699 (single_display_spec_string_p): Support property values that are
6700 lists with the argument STRING its top-level element.
6701 (display_prop_string_p): Fix the condition for processing a
6702 property that is a list to be consistent with handle_display_spec.
fec2107c 6703 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6704 last portion of handle_display_prop.
6705 (compute_display_string_pos): Accept additional argument
6706 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6707 value of a `display' property is a "replacing spec".
6708 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6709 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6710 the display property, but just return a value indicating whether
6711 the display property will replace the characters it covers.
6712 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6713 frame_window_p members of struct bidi_it.
d6d100dd
SM
6714 (compute_display_string_pos, compute_display_string_end):
6715 New functions.
fec2107c
EZ
6716 (push_it): Accept second argument POSITION, where pop_it should
6717 jump to continue iteration.
6718 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6719
fec2107c
EZ
6720 * keyboard.c (adjust_point_for_property): Adjust the call to
6721 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6722
6723 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6724 (bidi_init_it): Update prototypes.
6725 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6726 (compute_display_string_pos, compute_display_string_end):
6727 Declare prototypes.
fec2107c
EZ
6728 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6729 EMACS_INT.
fc6f18ce 6730
40087514 67312011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6732
57f53182
PE
6733 Malloc failure behavior now depends on size of allocation.
6734 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6735 * lisp.h: Change signatures accordingly.
6736 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6737 All callers changed. (Bug#8762)
6738
6739 * gnutls.c: Use Emacs's memory allocators.
6740 Without this change, the gnutls library would invoke malloc etc.
6741 directly, which causes problems on non-SYNC_INPUT hosts, and which
6742 runs afoul of improving memory_full behavior. (Bug#8761)
6743 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6744 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6745 xfree instead of the default malloc, realloc, free.
6746 (Fgnutls_boot): No need to check for memory allocation failure,
6747 since xmalloc does that for us.
6748
ac32cd99 6749 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6750 * category.c (hash_get_category_set):
6751 * ccl.c (ccl_driver):
6752 * charset.c (Fdefine_charset_internal):
6753 * charset.h (struct charset.hash_index):
6754 * composite.c (get_composition_id, gstring_lookup_cache)
6755 (composition_gstring_put_cache):
6756 * composite.h (struct composition.hash_index):
6757 * dispextern.h (struct image.hash):
6758 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6759 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6760 (hashfn_equal, hashfn_user_defined, make_hash_table)
6761 (maybe_resize_hash_table, hash_lookup, hash_put)
6762 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6763 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6764 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6765 * image.c (make_image, search_image_cache, lookup_image)
6766 (xpm_put_color_table_h):
6767 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6768 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6769 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6770 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6771 * alloc.c (allocate_vectorlike):
6772 Check for overflow in vector size calculations.
6773 * ccl.c (ccl_driver):
6774 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6775 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6776 need to be updated by these changes.
40087514
PE
6777 * fns.c (make_hash_table, maybe_resize_hash_table):
6778 Check for integer overflow with large hash tables.
0de4bb68
PE
6779 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6780 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6781 (SXHASH_REDUCE): New macro.
6782 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6783 Use it instead of discarding useful hash info with large hash values.
6784 (sxhash_float): New function.
6785 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6786 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6787 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6788 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6789 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6790 Adjust signatures to match updated version of code.
6791 (consing_since_gc): Now EMACS_INT, since a single hash table can
6792 use more than INT_MAX bytes.
6793
698d32e2
DN
67942011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6795
6796 Make it possible to build with GCC-4.6+ -O2 -flto.
6797
6798 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6799
fd6fa53f
SM
68002011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6801
6802 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6803 Call minibuffer-inactive-mode.
6804
864db017
JB
68052011-05-31 Juanma Barranquero <lekktu@gmail.com>
6806
6807 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6808 Update dependencies.
6809
2ad0baf4
DN
68102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6811
6812 * data.c (init_data): Remove code for UTS, this system is not
6813 supported anymore.
6814
4fcc2638
DN
68152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6816
6817 Don't force ./temacs to start in terminal mode.
6818
6819 * frame.c (make_initial_frame): Initialize faces in all cases, not
6820 only when CANNOT_DUMP is defined.
6821 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6822
c56e0fd5
DN
68232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6824
6825 * dispnew.c (add_window_display_history): Use const for the string
6826 pointer. Remove declaration, not needed.
6827
333d54da 68282011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6829
55d4c1b2 6830 Use 'inline', not 'INLINE'.
333d54da 6831 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6832 * alloc.c, fontset.c (INLINE): Remove.
6833 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6834 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6835 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6836 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6837 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6838
738db178
DN
68392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6840
6841 Make it possible to run ./temacs.
6842
6843 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6844 syms_of_callproc does the same thing. Remove test for
6845 "initialized", do it in the caller.
6846 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6847
620c53a6
SM
68482011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6849
6850 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6851 (read_minibuf): Use get_minibuffer.
6852 (syms_of_minibuf): Use DEFSYM.
6853 (Qmetadata): New var.
6854 * data.c (Qbuffer): Don't make it static.
6855 (syms_of_data): Use DEFSYM.
6856
e003a292
PE
68572011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6858
6859 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6860 (CCL_CODE_MIN): New macro.
6861
ed008a6d
PE
68622011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6863
3687c2ef
PE
6864 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6865
ed008a6d
PE
6866 * eval.c (Qdebug): Now static.
6867 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6868 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6869 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6870
d66c4c7c
CY
68712011-05-29 Chong Yidong <cyd@stupidchicken.com>
6872
6873 * image.c: Various fixes to ImageMagick code comments.
6874 (Fimagemagick_types): Doc fix.
6875
5fbc2025
PE
68762011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6877
0196f88a
PE
6878 Minor fixes prompted by GCC 4.6.0 warnings.
6879
6880 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6881
5fbc2025
PE
6882 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6883 (x_clipboard_manager_save_all): Move extern decl to ...
6884 * xterm.h: ... here, so that it can be checked for consistency.
6885
1dd3c2d9
CY
68862011-05-29 Chong Yidong <cyd@stupidchicken.com>
6887
6888 * xselect.c (x_clipboard_manager_save_frame)
6889 (x_clipboard_manager_save_all): New functions.
6890 (Fx_clipboard_manager_save): Lisp function deleted.
6891
6892 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6893 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6894
6895 * xterm.h: Update prototype.
6896
5ba6571d
WX
68972011-05-28 William Xu <william.xwl@gmail.com>
6898
6899 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6900 exiting (Bug#8239).
6901
3eaff834
JM
69022011-05-28 Jim Meyering <meyering@redhat.com>
6903
e1900994 6904 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6905 * fns.c (to_uchar): Define.
6906 (crypto_hash_function): Use it to convert some newly-signed
6907 variables to unsigned, to avoid sign-extension bugs. For example,
6908 without this change, (md5 "truc") would evaluate to
6909 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6910 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6911 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6912
0f6990a7
PE
69132011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6914
6915 Integer overflow fixes.
c8a9ca5a 6916
08686060
PE
6917 * dbusbind.c: Serial number integer overflow fixes.
6918 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6919 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6920 to hold a serial number that is too large for a fixnum.
6921 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6922 Check for serial numbers out of range. Decode any serial number
59568bf0 6923 that was so large that it became a float. (Bug#8722)
08686060 6924
2d1fc3c7
PE
6925 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6926 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6927 Use XFASTINT rather than XUINT when numbers are nonnegative.
6928 (xd_append_arg, Fdbus_method_return_internal):
6929 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6930 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6931 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6932 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6933 (Bug#8722)
2d1fc3c7 6934
c8a9ca5a
PE
6935 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6936
519e1d69
PE
6937 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6938
6df6ae42 6939 ccl: Add integer overflow checks.
30569699
PE
6940 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6941 (IN_INT_RANGE): New macros.
6942 (ccl_driver): Use them to check for integer overflow when
6943 decoding a CCL program. Many of the new checks are whether XINT (x)
6944 fits in int; it doesn't always, on 64-bit hosts. The new version
6945 doesn't catch all possible integer overflows, but it's an
847044ea 6946 improvement. (Bug#8719)
30569699 6947
c11285dc
PE
6948 * alloc.c (make_event_array): Use XINT, not XUINT.
6949 There's no need for unsigned here.
6950
fdccd48e
PE
6951 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6952 This follows up to the 2011-05-06 change that substituted uintptr_t
6953 for EMACS_INT. This case wasn't caught back then.
6954
37910ab2
PE
6955 Rework Fformat to avoid integer overflow issues.
6956 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6957 now (part of C89). Include <verify.h>.
6958 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6959 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6960 (Fformat): Avoid the prepass trying to compute sizes; it was only
6961 approximate and thus did not catch overflow reliably. Instead, walk
6962 through the format just once, formatting and computing sizes as we go,
6963 checking for integer overflow at every step, and allocating a larger
6964 buffer as needed. Keep track separately whether the format is
6965 multibyte. Keep only the most-recently calculated precision, rather
6966 than them all. Record whether each argument has been converted to
6967 string. Use EMACS_INT, not int, for byte and char and arg counts.
6968 Support field widths and precisions larger than INT_MAX. Avoid
6969 sprintf's undefined behavior with conversion specifications such as %#d
6970 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6971 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6972 formatting out-of-range floating point numbers with int
9173deec 6973 formats. (Bug#8668)
37910ab2 6974
2e6578fb
PE
6975 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6976
0ae6bdee
PE
6977 * data.c: Avoid integer truncation in expressions involving floats.
6978 * data.c: Include <intprops.h>.
6979 (arith_driver): When there's an integer overflow in an expression
6980 involving floating point, convert the integers to floating point
6981 so that the resulting value does not suffer from catastrophic
6982 integer truncation. For example, on a 64-bit host (* 4
6983 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6984 Do not rely on undefined behavior after integer overflow.
6985
de883a70
PE
6986 merge count_size_as_multibyte, parse_str_to_multibyte
6987 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6988 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6989 Check for integer overflow.
6990 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6991 since it's now a duplicate of the other. This is more of
6992 a character than a buffer op, so better that it's in character.c.
6993 * fns.c, print.c: Adjust to above changes.
6994
2ff916cb
PE
69952011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6996
6997 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6998
f1b54466
PE
69992011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7000
fb1ac845
PE
7001 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7002 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7003 (x_clipboard_manager_save): Now static.
7004 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7005
f1b54466
PE
7006 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7007 (crypto_hash_function): Now static.
7008 Fix pointer signedness problems. Avoid unnecessary initializations.
7009
a9f737ee
CY
70102011-05-27 Chong Yidong <cyd@stupidchicken.com>
7011
7012 * termhooks.h (Vselection_alist): Make it terminal-local.
7013
7014 * terminal.c (create_terminal): Initialize it.
7015
7016 * xselect.c: Support for clipboard managers.
7017 (Vselection_alist): Move to termhooks.h as terminal-local var.
7018 (LOCAL_SELECTION): New macro.
7019 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7020 (symbol_to_x_atom): Remove gratuitous arg.
7021 (x_handle_selection_request, lisp_data_to_selection_data)
7022 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
7023 (x_own_selection, x_get_local_selection, x_convert_selection):
7024 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
7025 (some_frame_on_display): Delete unused function.
7026 (Fx_own_selection_internal, Fx_get_selection_internal)
7027 (Fx_disown_selection_internal, Fx_selection_owner_p)
7028 (Fx_selection_exists_p): New optional frame arg.
7029 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7030 (x_handle_selection_clear): Don't treat other terminals with the
7031 same keyboard specially. Use the terminal-local Vselection_alist.
7032 (x_clear_frame_selections): Use Frun_hook_with_args.
7033
7034 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7035
7036 * xterm.h: Add support for those atoms.
7037
e067f0c1
CY
70382011-05-26 Chong Yidong <cyd@stupidchicken.com>
7039
7040 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7041 (converted_selections, conversion_fail_tag): New global variables.
7042 (x_selection_request_lisp_error): Free the above.
7043 (x_get_local_selection): Remove unnecessary code.
7044 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
7045 of converted selections stored in converted_selections.
7046 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
7047 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7048 (x_convert_selection): New function.
7049 (x_handle_selection_event): Simplify.
7050 (x_get_foreign_selection): Don't ignore incoming requests while
7051 waiting for an answer; this will fail when we implement
7052 SAVE_TARGETS, and seems unnecessary anyway.
7053 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7054 (Vx_sent_selection_functions): Doc fix.
7055
0f4aebc0
LL
70562011-05-26 Leo Liu <sdl.web@gmail.com>
7057
7058 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7059
e61124cd
YM
70602011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7061
7062 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7063
7064 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7065 for fringe update if it has periodic bitmap.
ac389d0c 7066 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
7067 and fringe_bitmap_periodic_p.
7068
7069 * fringe.c (get_fringe_bitmap_data): New function.
7070 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7071 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7072 row. Mark glyph row for fringe update if periodicity changed.
7073
7074 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7075 for fringe update unless it has periodic bitmap.
7076
f16d9837
KH
70772011-05-25 Kenichi Handa <handa@m17n.org>
7078
7079 * xdisp.c (get_next_display_element): Set correct it->face_id for
7080 a static composition.
7081
e1b90ef6
LL
70822011-05-24 Leo Liu <sdl.web@gmail.com>
7083
7084 * deps.mk (fns.o):
7085 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7086
7087 * fns.c (crypto_hash_function, Fsha1): New function.
7088 (Fmd5): Use crypto_hash_function.
7089 (syms_of_fns): Add Ssha1.
7090
7400048f
PE
70912011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7092
7093 * gnutls.c: Remove unused macros.
7094 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7095 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7096 Remove macros that are defined and never used.
7097 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7098
abb71cf4
CY
70992011-05-22 Chong Yidong <cyd@stupidchicken.com>
7100
7101 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7102 (Fx_get_selection_internal): Minor cleanup.
7103 (Fx_own_selection_internal): Rename arguments for consistency with
7104 select.el.
7105
6307db39
PE
71062011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7107
7108 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7109
f3d4e0a4
CY
71102011-05-22 Chong Yidong <cyd@stupidchicken.com>
7111
7112 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7113
4d8ade89
YM
71142011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7115
7116 * dispnew.c (scrolling_window): Don't exclude the case that the
7117 last enabled row in the desired matrix touches the bottom boundary.
7118
32078c8d
GM
71192011-05-21 Glenn Morris <rgm@gnu.org>
7120
7121 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
7122 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7123 and add some more files.
32078c8d 7124
7285dc67
EZ
71252011-05-20 Eli Zaretskii <eliz@gnu.org>
7126
7127 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7128 report_file_error introduced by the change from 2011-05-07.
7129
89d1bd22
PE
71302011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7131
7132 * systime.h (Time): Define only if emacs is defined.
7133 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7134 where the include path doesn't have X11/X.h by default. See
7135 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7136
cd394be1 71372011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
7138
7139 * composite.c (find_automatic_composition): Fix previous change.
7140
b9704ad9
GM
71412011-05-20 Glenn Morris <rgm@gnu.org>
7142
7143 * lisp.mk: New file, split from Makefile.in.
7144 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7145 (shortlisp): Remove.
7146 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7147
4a720484
GM
71482011-05-19 Glenn Morris <rgm@gnu.org>
7149
7150 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7151 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7152 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7153 (lisp): Set the order to that of loadup.el.
7154 (shortlisp): Make it a copy of $lisp.
7155 (SOME_MACHINE_LISP): Remove.
7156 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7157 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7158
a28d4396
KH
71592011-05-18 Kenichi Handa <handa@m17n.org>
7160
7161 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7162 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7163 (find_automatic_composition): Mostly rewrite for efficiency.
7164
a2b1fa8e
JB
71652011-05-18 Juanma Barranquero <lekktu@gmail.com>
7166
7167 * makefile.w32-in: Update dependencies.
7168
8e1f5610
CS
71692011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7170
7171 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 7172 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 7173
7025ee00 71742011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 7175
cdfa6eab
PE
7176 Fix some integer overflow issues, such as string length overflow.
7177
06d6db33
PE
7178 * insdel.c (count_size_as_multibyte): Check for string overflow.
7179
2b4560a8
PE
7180 * character.c (lisp_string_width): Check for string overflow.
7181 Use EMACS_INT, not int, for string indexes and lengths; in
7182 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7183 the resulting string length overflows an EMACS_INT; instead,
7184 report a string overflow if no precision given. When checking for
7185 precision exhaustion, use a check that cannot possibly have
7186 integer overflow. (Bug#8675)
7187 * character.h (lisp_string_width): Adjust to new signature.
7188
cb93f9be
PE
7189 * alloc.c (string_overflow): New function.
7190 (Fmake_string): Use it. This doesn't change behavior, but saves
7191 a few bytes and will simplify future changes.
7192 * character.c (string_escape_byte8): Likewise.
7193 * lisp.h (string_overflow): New decl.
7194
1a1f3366
PE
7195 Fixups, following up to the user-interface timestamp change.
7196 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7197 for UI timestamps, instead of unsigned long.
9fbd6841
PE
7198 * msdos.c (mouse_get_pos): Likewise.
7199 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
7200 * w32gui.h (Time): Define by including "systime.h" rather than by
7201 declaring it ourselves. (Bug#8664)
7202
d4e3e4d3
PE
7203 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7204 * image.c (clear_image_cache): Likewise.
7205
f6a24d19
PE
7206 * term.c (term_mouse_position): Don't assume time_t wraparound.
7207
08dc5ae6
PE
7208 Be more systematic about user-interface timestamps.
7209 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
7210 and sometimes 'EMACS_UINT', to represent these timestamps.
7211 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
7212 This makes the code easier to follow, and makes it easier to catch
7213 integer overflow bugs such as Bug#8664.
7214 * frame.c (Fmouse_position, Fmouse_pixel_position):
7215 Use Time, not unsigned long, for user-interface timestamps.
7216 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7217 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7218 * keyboard.h (last_event_timestamp): Likewise.
7219 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7220 * menu.h (xmenu_show): Likewise.
7221 * term.c (term_mouse_position): Likewise.
7222 * termhooks.h (struct input_event.timestamp): Likewise.
7223 (struct terminal.mouse_position_hook): Likewise.
7224 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7225 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7226 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7227 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7228 what it was before.
7229 * menu.h, termhooks.h: Include "systime.h", for Time.
7230
8e55734a
PE
7231 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7232 Don't assume that the difference between two unsigned long values
7233 can fit into an integer. At this point, we know button_down_time
7234 <= event->timestamp, so the difference must be nonnegative, so
7235 there's no need to cast the result if double-click-time is
7236 nonnegative, as it should be; check that it's nonnegative, just in
7237 case. This bug is triggered when events are more than 2**31 ms
86db42d2 7238 apart (about 25 days). (Bug#8664)
8e55734a 7239
841f1b75 7240 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 7241 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 7242
3e26f69c
PE
7243 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7244 that always fit in int. Use a sentinel instead of a counter, to
7245 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
7246 * frame.h (struct frame): Use int for menu_bar_items_used
7247 instead of EMACS_INT, since it always fits in int.
3e26f69c 7248
5cc152c0
PE
7249 * menu.c (grow_menu_items): Check for int overflow.
7250
d89eb65e
PE
7251 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7252
5235bd3e
PE
7253 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7254 Before, the code was not consistent. These values cannot exceed
7255 2**31 - 1 so there's no need to make them unsigned.
7256 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7257 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7258 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7259 as modifiers.
7260 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7261
bc827e23
PE
7262 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7263 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7264 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7265 presumably because the widths might not match.
7266
78eb494e
PE
7267 * window.c (size_window): Avoid needless test at loop start.
7268
04f2d78b
CB
72692011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7270
7271 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7272
d2fc7e3d 72732011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
7274
7275 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7276
d2fc7e3d 72772011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
7278
7279 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7280 `width' to `bar_area_x' and `bar_area_width', respectively.
7281 (x_scroll_run): Take account of fringe background extension.
7282
04f2d78b
CB
7283 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7284 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
7285 `bar_area_width', respectively.
7286 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7287 background extension.
7288
79b70037
GM
72892011-05-10 Jim Meyering <meyering@redhat.com>
7290
7291 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7292
2f142cc5
JB
72932011-05-10 Juanma Barranquero <lekktu@gmail.com>
7294
7295 * image.c (Finit_image_library): Return t for built-in image types,
7296 like pbm and xbm. (Bug#8640)
7297
57679c86
AS
72982011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7299
7300 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7301
888c9e86
EZ
73022011-05-07 Eli Zaretskii <eliz@gnu.org>
7303
b0512a1d
EZ
7304 * w32console.c (Fset_screen_color): Doc fix.
7305 (Fget_screen_color): New function.
7306 (syms_of_ntterm): Defsubr it.
7307
7285dc67
EZ
7308 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7309 unlink the temporary file if Fcall_process didn't create it in the
7310 first place.
7311 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7312 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
7313 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7314 cue to call_process_cleanup not to close that handle.
7315
4d3fcc8e
BK
73162011-05-07 Ben Key <bkey76@gmail.com>
7317
7318 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7319 one of two shell specific rules, either bootstrap-temacs-CMD or
7320 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7321 to the previous implementation of the bootstrap-temacs rule.
7322 The bootstrap-temacs-CMD rule is similar to the previous
7323 implementation of the bootstrap-temacs rule except that it
7324 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7325 variable.
7326
7327 These changes, along with some changes to nt/configure.bat,
7328 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7329 earlier fix to add support for --cflags and --ldflags options
7330 that include quotes so that it works whether make uses cmd or
7331 sh as the shell.
7332
b4289b64
MA
73332011-05-06 Michael Albinus <michael.albinus@gmx.de>
7334
7335 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7336 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7337 is a constant.
7338 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7339 a string. Handle both cases.
7340 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7341 (Fdbus_register_method): Use Qinvalid_function.
7342
af4c0e28
JB
73432011-05-06 Juanma Barranquero <lekktu@gmail.com>
7344
7345 * makefile.w32-in: Update dependencies.
7346 (LISP_H): Add inttypes.h and stdin.h.
7347 (PROCESS_H): Add unistd.h.
7348
c51453d9
EZ
73492011-05-06 Eli Zaretskii <eliz@gnu.org>
7350
7351 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7352 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7353
8ff0ac3c 73542011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7355
4c4b566b
PE
7356 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7357
aab2b9b5
PE
7358 * term.c (vfatal): Remove stray call to va_end.
7359 It's not needed and the C Standard doesn't allow it here anyway.
7360
c378da0b
PE
7361 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7362 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7363
288b08c7
PE
7364 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7365 bytes.
7366
e3601888
PE
7367 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7368
db6c0e74
PE
7369 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7370
dd5963ea
PE
7371 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7372
88c9450f
PE
7373 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7374
2f9442b8
PE
7375 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7376
c032b5f8
PE
7377 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7378 * charset.c (Fdefine_charset_internal): Don't initialize
7379 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7380 32-bit int (Bug#8600).
a108c10b
PE
7381
7382 * lread.c (read_integer): Be more consistent with string-to-number.
7383 Use string_to_number to do the actual conversion; this avoids
7384 rounding errors and fixes some other screwups. Without this fix,
7385 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7386 (digit_to_number): Move earlier, for benefit of read_integer.
7387 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7388 not a digit in any supported base. (Bug#8602)
a108c10b 7389
ad5f9eea
PE
7390 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7391
aec1708a
PE
7392 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7393 to match comment at start of function. This also removes a
7394 GCC warning about overflow in a 32+64-bit port.
7395
47be4ab5
PE
7396 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7397
371cac43
PE
7398 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7399 Reported by Stefan Monnier in
7400 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7401 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7402 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7403
d01a7826
PE
7404 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7405 (EMACS_UINTPTR): Likewise, with uintptr_t.
7406
7fd47d5c
PE
7407 * lisp.h: Prefer 64-bit EMACS_INT if available.
7408 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7409 on 32-bit hosts that have 64-bit int, so that they can access
7410 large files.
122b0c86
PE
7411 However, temporarily disable this change unless the temporary
7412 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7413
8727937b
PE
7414 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7415
8ac068ac
PE
7416 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7417 This removes an assumption that EMACS_INT and long are the same
7418 width as pointers. The assumption is true for Emacs porting targets
7419 now, but we want to make other targets possible.
7420 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7421 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7422 In the rest of the code, change types of integers that hold casted
7423 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7424 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7425 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7426 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7427 No need to cast type when ORing.
7428 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7429 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7430 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7431 assume EMACS_INT is the same width as char *.
7432 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7433 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7434 Remove no-longer-needed casts.
7435 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7436 (xg_tool_bar_help_callback, xg_make_tool_item):
7437 Use EMACS_INTPTR to hold an integer
7438 that will be cast to void *; this can avoid a GCC warning
7439 if EMACS_INT is not the same width as void *.
7440 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7441 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7442 (current_message_1, set_message_1):
7443 Use a local to convert to proper width without a cast.
7444 * xmenu.c (dialog_selection_callback): Likewise.
7445
ede49d71
PE
7446 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7447 Also, don't assume VALBITS / RAND_BITS is less than 5,
7448 and don't rely on undefined behavior when shifting a 1 left into
7449 the sign bit.
7450 * lisp.h (get_random): Change signature to match.
7451
2f30ecd0
PE
7452 * lread.c (hash_string): Use size_t, not int, for hash computation.
7453 Normally we prefer signed values; but hashing is special, because
7454 it's better to use unsigned division on hash table sizes so that
7455 the remainder is nonnegative. Also, size_t is the natural width
7456 for hashing into memory. The previous code used 'int', which doesn't
7457 retain enough info to hash well into very large tables.
7458 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7459
2a866e7b
PE
7460 * dbusbind.c: Don't possibly lose pointer info when converting.
7461 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7462 Use XPNTR rather than XHASH, so that the high-order bits of
7463 the pointer aren't lost when converting through void *.
7464
51639eac
PE
7465 * eval.c (Fautoload): Don't double-shift a pointer.
7466
92394119
PE
7467 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7468
dbdb9a7c
JB
74692011-05-06 Juanma Barranquero <lekktu@gmail.com>
7470
7471 * gnutls.c (DEF_GNUTLS_FN):
7472 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7473
db7a0b4f
AS
74742011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7475
7476 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7477 marker. (Bug#8610)
7478
cd394be1 74792011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7480
7481 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7482 New version that can reserve upto 2GB of heap space.
7483
f7ff1b0f 74842011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7485
7486 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7487
639c109b
TZ
74882011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7489
7490 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7491 `gnutls_certificate_set_x509_key_file'.
7492
d2127135
JB
74932011-05-05 Juanma Barranquero <lekktu@gmail.com>
7494
7495 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7496 Update dependencies.
7497
e968f4f3
JB
74982011-05-04 Juanma Barranquero <lekktu@gmail.com>
7499
7500 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7501 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7502 Remove unused parameter `fildes'.
7503 * process.c (read_process_output, send_process): Don't pass it.
7504
84d358f0
JB
75052011-05-04 Juanma Barranquero <lekktu@gmail.com>
7506
7507 Fix previous change: the library cache is defined in w32.c.
7508 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7509 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7510
0898ca10
JB
75112011-05-04 Juanma Barranquero <lekktu@gmail.com>
7512
7513 Implement dynamic loading of GnuTLS on Windows.
7514
7515 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7516 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7517 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7518 Declare.
7519
7520 * gnutls.c (Qgnutls_dll): Define.
7521 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7522 (gnutls_*): Declare function pointers.
7523 (init_gnutls_functions): New function to initialize function pointers.
7524 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7525 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7526 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7527 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7528 (emacs_gnutls_write, emacs_gnutls_read)
7529 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7530 (Fgnutls_available_p): New function.
7531 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7532 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7533 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7534
7535 * image.c: Include w32.h.
7536 (Vimage_type_cache): Delete.
7537 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7538 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7539 (w32_delayed_load): Move to w32.c.
7540
7541 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7542
7543 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7544 (w32_delayed_load): Move from image.c. When loading a library, record
7545 its filename in the :loaded-from property of the library id.
7546 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7547 Initialize and staticpro them.
7548 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7549
7550 * process.c: Include lisp.h before w32.h, not after.
7551 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7552 instead of gnutls_record_check_pending.
7553
7554 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7555
ff4de4aa
TZ
75562011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7557
7558 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7559 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7560 as passed in.
7561
abe95abb
JD
75622011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7563
7564 * xterm.c (x_set_frame_alpha): Do not set property on anything
7565 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7566
e16e55d4
JB
75672011-05-02 Juanma Barranquero <lekktu@gmail.com>
7568
7569 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7570
bafcf6a5
JB
75712011-05-02 Juanma Barranquero <lekktu@gmail.com>
7572
7573 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7574 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7575 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7576 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7577 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7578 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7579 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7580 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7581 (Qgnutls_bootprop_callbacks_verify): Make static.
7582
e7a6747f
AS
75832011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7584
19ed11ba
AS
7585 * callproc.c: Indentation fixup.
7586
e7a6747f 7587 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7588 (wait_for_termination, interruptible_wait_for_termination):
7589 Move after wait_for_termination_1.
e7a6747f 7590
1ef14cb4
LMI
75912011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7592
7593 * sysdep.c (interruptible_wait_for_termination): New function
7594 which is like wait_for_termination, but allows keyboard
7595 interruptions.
7596
7597 * callproc.c (Fcall_process): Add (:file "file") as an option for
7598 the STDOUT buffer.
7599 (Fcall_process_region): Ditto.
7600
330d880c
EZ
76012011-04-30 Eli Zaretskii <eliz@gnu.org>
7602
8db90b73
EZ
7603 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7604 rather than `XVECTOR (FOO)->size'.
7605
330d880c
EZ
7606 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7607 inttypes.h, as a gnulib replacement is used if it not available in
7608 system headers.
7609
15cbd324
EZ
76102011-04-21 Eli Zaretskii <eliz@gnu.org>
7611
7612 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7613 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7614 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7615
7616 * coding.c (coding_alloc_by_realloc): Error out if destination
7617 will grow beyond MOST_POSITIVE_FIXNUM.
7618 (decode_coding_emacs_mule): Abort if there isn't enough place in
7619 charbuf for the composition carryover bytes. Reserve an extra
7620 space for up to 2 characters produced in a loop.
7621 (decode_coding_iso_2022): Abort if there isn't enough place in
7622 charbuf for the composition carryover bytes.
7623
76242011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7625
ae940cca
EZ
7626 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7627 aborting when %lld or %lll format is passed.
7628 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7629 %llo or %llx format is passed. (Bug#8545)
7630
03ab8921
EZ
7631 * window.c (window_scroll_line_based): Use a marker instead of
7632 simple variables to record original value of point. (Bug#7952)
7633
afda1437
EZ
7634 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7635 produced by %s or %c overflows available buffer space. (Bug#8545)
7636
f76dee0c
PE
76372011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7638
7639 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7640 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7641
fdc5744d
JB
76422011-04-28 Juanma Barranquero <lekktu@gmail.com>
7643
7644 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7645
638f053a
JB
76462011-04-28 Juanma Barranquero <lekktu@gmail.com>
7647
7648 * keyboard.c (Qdelayed_warnings_hook): Define.
7649 (command_loop_1): Run `delayed-warnings-hook'
7650 if Vdelayed_warnings_list is non-nil.
7651 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7652 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7653
d178f871
EZ
76542011-04-28 Eli Zaretskii <eliz@gnu.org>
7655
7656 * doprnt.c (doprnt): Don't return value smaller than the buffer
7657 size if the message was truncated. (Bug#8545).
7658
b124fd93
JB
76592011-04-28 Juanma Barranquero <lekktu@gmail.com>
7660
7661 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7662 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7663
e810457d
PE
76642011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7665
7666 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7667
ea51cceb
JB
76682011-04-27 Juanma Barranquero <lekktu@gmail.com>
7669
7670 * makefile.w32-in: Update dependencies.
7671
94dcfacf
EZ
76722011-04-27 Eli Zaretskii <eliz@gnu.org>
7673
7674 Improve `doprnt' and its usage. (Bug#8545)
7675 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7676 `format_end'. Remove support for %l as a conversion specifier.
7677 Don't use xrealloc. Improve diagnostics when the %l size modifier
7678 is used. Update the commentary.
7679
7680 * eval.c (verror): Simplify calculation of size_t.
7681
7682 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7683 messages.
7684
f61f41d7
PE
76852011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7686
7687 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7688 change.
7689
96fb4434
PE
76902011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7691
7692 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7693 This makes this file independent of the recent pseudovector change.
7694
671875da 76952011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7696
69e9b5a3
PE
7697 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7698
b5f869a7 7699 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7700 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7701 Remove unused local.
c8926152 7702 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7703
841a1577 7704 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7705 GCC 4.6.0 optimizes based on type-based alias analysis.
7706 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7707 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7708 != &v->size, and therefore "v->size = 1; b->size = 2; return
7709 v->size;" must therefore return 1. This assumption is incorrect
7710 for Emacs, since it type-puns struct Lisp_Vector * with many other
7711 types. To fix this problem, this patch adds a new type struct
f904488f 7712 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7713 and pseudovectors, and helps optimizing compilers not get fooled
7714 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7715 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7716 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7717 the size member.
eab3844f
PE
7718 (XSETPVECTYPE): Rewrite in terms of new macro.
7719 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7720 This is a bit clearer, and further avoids the possibility of
7721 undesirable aliasing.
7722 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7723 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7724 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7725 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7726 (ASIZE): Now uses header.size rather than size.
7727 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7728 to avoid the hassle of writing XVECTOR (foo)->header.size.
7729 (struct vectorlike_header): New type.
eab3844f
PE
7730 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7731 object, to help avoid aliasing.
7732 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7733 (SUBRP): Likewise, since Lisp_Subr is a special case.
7734 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7735 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7736 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7737 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7738 changed to be "header.size" and "header.next".
7739 * buffer.h (struct buffer): Likewise.
7740 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7741 * frame.h (struct frame): Likewise.
7742 * process.h (struct Lisp_Process): Likewise.
7743 * termhooks.h (struct terminal): Likewise.
7744 * window.c (struct save_window_data, struct saved_window): Likewise.
7745 * window.h (struct window): Likewise.
7746 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7747 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7748 * buffer.c (init_buffer_once): Likewise.
7749 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7750 special case.
7751 * process.c (Fformat_network_address): Use local var for size,
7752 for brevity.
7753
0df1eac5
PE
7754 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7755
847ab9d1 7756 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7757 * data.c (atof): Remove decl; no longer used or needed.
7758 (digit_to_number): Move to lread.c.
7759 (Fstring_to_number): Use new string_to_number function, to be
7760 consistent with how the Lisp reader treats infinities and NaNs.
7761 Do not assume that floating-point numbers represent EMACS_INT
7762 without losing information; this is not true on most 64-bit hosts.
7763 Avoid double-rounding errors, by insisting on integers when
7764 parsing non-base-10 numbers, as the documentation specifies.
7765 * lisp.h (string_to_number): New decl, replacing ...
7766 (isfloat_string): Remove.
bc0a5c13 7767 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7768 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7769 appears to have been a coding error. Similarly, do not accept
7770 strings like +-1e0 as floating point numbers. Do not report
7771 overflow for integer overflows unless the base is not 10 which
7772 means we have no simple and reliable way to continue.
7773 Break out the floating-point parsing into a new
7774 function string_to_number, so that Fstring_to_number parses
7775 floating point numbers consistently with the Lisp reader.
04f2d78b 7776 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7777 (E_CHAR, EXP_INT): Remove, replacing with ...
7778 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7779 (string_to_number): New function, replacing isfloat_string.
7780 This function checks for valid syntax and produces the resulting
7781 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7782 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7783 so that overflow for non-base-10 numbers is reported only when
7784 there's no portable and simple way to convert to floating point.
452f4150 7785
67769ffc
PE
7786 * textprop.c (set_text_properties_1): Rewrite for clarity,
7787 and to avoid GCC warning about integer overflow.
7788
c20db43f
PE
7789 * intervals.h (struct interval): Use EMACS_INT for members
7790 where EMACS_UINT might cause problems. See
7791 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7792 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7793 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7794 All uses changed.
37aa2f85
PE
7795 (offset_intervals): Tell GCC not to worry about length overflow
7796 when negating a negative length.
c20db43f 7797
2538aa2f
PE
7798 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7799 (overrun_check_free): Likewise.
7800
f2d3008d
PE
7801 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7802 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7803 word size.
7804
ec8df744
PE
7805 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7806 (gnutls_make_error): Rename local to avoid shadowing.
7807 (gnutls_emacs_global_deinit): ifdef out; not used.
7808 (Fgnutls_boot): Use const for pointer to readonly storage.
7809 Comment out unused local. Fix pointer signedness problems.
7810
640ee02d
PE
7811 * lread.c (openp): Don't stuff size_t into an 'int'.
7812 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7813 about possible signed overflow.
7814
6048fb2a
PE
7815 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7816 (GDK_KEY_g): Don't define if already defined.
7817 (xg_prepare_tooltip): Avoid pointer signedness problem.
7818 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7819
fa3c87e1
PE
7820 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7821 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7822
2172544b
PE
7823 * xfns.c (Fx_window_property): Simplify a bit,
7824 to make a bit faster and to avoid GCC 4.6.0 warning.
7825 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7826
9b821a21
PE
7827 * fns.c (internal_equal): Don't assume size_t fits in int.
7828
3c616cfa
PE
7829 * alloc.c (compact_small_strings): Tighten assertion a little.
7830
c2982e87
PE
7831 Replace pEd with more-general pI, and fix some printf arg casts.
7832 * lisp.h (pI): New macro, generalizing old pEd macro to other
7833 conversion specifiers. For example, use "...%"pI"d..." rather
7834 than "...%"pEd"...".
7835 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7836 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7837 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7838 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7839 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7840 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7841 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7842 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7843 64-bit hosts.
7844 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7845 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7846 * print.c (safe_debug_print, print_object): Likewise.
7847 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7848 to int.
6f04d126
PE
7849 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7850 avoiding the 0 flag, which is not portable.
c2982e87
PE
7851 * process.c (Fmake_network_process): Use pI to avoid cast.
7852 * region-cache.c (pp_cache): Likewise.
7853 * xdisp.c (decode_mode_spec): Likewise.
7854 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7855 behavior on 64-bit hosts with printf arg.
6f04d126 7856 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7857 (x_stop_queuing_selection_requests): Likewise.
7858 (x_get_window_property): Don't truncate byte count to an 'int'
7859 when tracing.
0b432f21 7860
5e073ec7
PE
7861 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7862 here, since it parses constructs like leading '-' and spaces,
7863 which are not wanted; and it overflows with large numbers.
7864 Instead, simply match F[0-9]+, which is what is wanted anyway.
7865
36372bf9
PE
7866 * alloc.c: Remove unportable assumptions about struct layout.
7867 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7868 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7869 (allocate_vectorlike, make_pure_vector): Use the new macros,
7870 plus offsetof, to remove unportable assumptions about struct layout.
7871 These assumptions hold on all porting targets that I know of, but
7872 they are not guaranteed, they're easy to remove, and removing them
7873 makes further changes easier.
7874
0b432f21
PE
7875 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7876 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7877 (string_overrun_cookie): Now const. Use initializers that
7878 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7879 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7880 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7881 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7882 multiple of sizeof (EMACS_INT); it need not be, if
7883 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7884 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7885
895009e1
JB
78862011-04-26 Juanma Barranquero <lekktu@gmail.com>
7887
7888 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7889
6a7a1b0b
TZ
78902011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7891
7892 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7893 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7894 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7895
841a1577 78962011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7897
7898 * lisp.h (Qdebug): List symbol.
895009e1 7899 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7900 * keyboard.c (debug-on-event): New variable.
7901 (handle_user_signal): Break into debugger when debug-on-event
7902 matches the current signal symbol.
7903
f2d3ba6f
DN
79042011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7905
7906 * alloc.c (check_sblock, check_string_bytes)
7907 (check_string_free_list): Convert to standard C.
7908
42ce4c63
TZ
79092011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7910
7911 * w32.c (emacs_gnutls_push): Fix typo.
7912
825cd63c
EZ
79132011-04-25 Eli Zaretskii <eliz@gnu.org>
7914
fb11d64d
EZ
7915 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7916 "cast to pointer from integer of different size".
7917
825cd63c
EZ
7918 Improve doprnt and its use in verror. (Bug#8545)
7919 * doprnt.c (doprnt): Document the set of format control sequences
7920 supported by the function. Use SAFE_ALLOCA instead of always
7921 using `alloca'.
7922
7923 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7924 is one byte too soon. Don't use xrealloc; instead xfree and
7925 xmalloc anew.
7926
e061a11b
TZ
79272011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7928
7929 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7930 callbacks stage.
7931
7932 * gnutls.c: Renamed global_initialized to
7933 gnutls_global_initialized. Added internals for the
7934 :verify-hostname-error, :verify-error, and :verify-flags
7935 parameters of `gnutls-boot' and documented those parameters in the
7936 docstring. Start callback support.
9173deec
JB
7937 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7938 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7939 on error. Return error code.
e061a11b
TZ
7940 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7941 (emacs_gnutls_read): Likewise.
7942 (Fgnutls_boot): Return handshake error code.
7943 (emacs_gnutls_handle_error): New function.
7944 (wsaerror_to_errno): Likewise.
7945
7946 * w32.h (emacs_gnutls_pull): Add prototype.
7947 (emacs_gnutls_push): Likewise.
7948
7949 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7950 (emacs_gnutls_push): Likewise.
7951
79522011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7953
7954 * process.c (wait_reading_process_output): Check if GnuTLS
7955 buffered some data internally if no FDs are set for TLS
7956 connections.
7957
7958 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7959 (LIBS): Link to USER_LIBS.
7960 ($(BLD)/gnutls.$(0)): New target.
7961
fa6996bc
EZ
79622011-04-24 Eli Zaretskii <eliz@gnu.org>
7963
eb35682e
EZ
7964 * xdisp.c (handle_single_display_spec): Rename the
7965 display_replaced_before_p argument into display_replaced_p, to
7966 make it consistent with the commentary. Fix typos in the
7967 commentary.
7968
e2ad650c
EZ
7969 * textprop.c (syms_of_textprop): Remove dead code.
7970 (copy_text_properties): Delete obsolete commentary about an
7971 interface that was deleted long ago. Fix typos in the description
7972 of arguments.
7973
1b2de274
EZ
7974 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7975 to changes in oldXMenu/XMenu.h from 2011-04-16.
7976 <menu_help_message, prev_menu_help_message>: Constify.
7977 (IT_menu_make_room): menu->help_text is now `const char **';
7978 adjust.
7979
7980 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7981 to changes in oldXMenu/XMenu.h from 2011-04-16.
7982 (struct XMenu): Declare `help_text' `const char **'.
7983
7984 * xfaces.c <Qunspecified>: Make extern again.
7985
7986 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7987 required by POSIX.
1b2de274 7988
762b15be
EZ
7989 * doc.c (get_doc_string): Improve the format passed to `error'.
7990
7991 * doprnt.c (doprnt): Improve commentary.
7992
7993 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7994
7995 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7996 them with etags.
7997
f1052e5d
EZ
7998 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7999 changes in globals.h immediately force recompilation.
762b15be
EZ
8000 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8001 $(CURDIR)/s/ms-w32.h.
8002 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 8003
fa6996bc
EZ
8004 * character.c (Fchar_direction): Function deleted.
8005 (syms_of_character): Don't defsubr it.
8006 <char-direction-table>: Deleted.
8007
e6c3da20
EZ
80082011-04-23 Eli Zaretskii <eliz@gnu.org>
8009
8010 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8011 * doprnt.c: Include limits.h.
8012 (SIZE_MAX): New macro.
04f2d78b
CB
8013 (doprnt): Return a size_t value. 2nd arg is now size_t.
8014 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
8015 Improve overflow protection. Support `l' modifier for integer
8016 conversions. Support %l conversion. Don't assume an EMACS_INT
8017 argument for integer conversions and for %c.
8018
8019 * lisp.h (doprnt): Restore prototype.
8020
8021 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8022 $(SRC)/character.h.
8023
8024 * Makefile.in (base_obj): Add back doprnt.o.
8025
8026 * deps.mk (doprnt.o): Add back prerequisites.
8027 (callint.o): Depend on character.h.
8028
8029 * eval.c (internal_lisp_condition_case): Include the handler
8030 representation in the error message.
8031 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8032 when breaking from the loop.
8033
8034 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8035
8036 * callint.c (Fcall_interactively): When displaying error message
8037 about invalid control letter, pass the character's codepoint, not
8038 a pointer to its multibyte form. Improve display of the character
8039 in octal and display also its hex code.
8040
8041 * character.c (char_string): Use %x to display the (unsigned)
8042 codepoint of an invalid character, to avoid displaying a bogus
8043 negative value.
8044
8045 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8046 `error', not SYMBOL_NAME itself.
8047
8048 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8049 character arguments to `error'.
8050
8051 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8052 to `error' in error message about FINAL_CHAR argument. Make sure
8053 FINAL_CHAR is a character, and use %c when it is passed as
8054 argument to `error'.
8055
4ffd0d6b 80562011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
8057
8058 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8059
8060 * w32.c: Include <time.h>.
8061 (sys_localtime): New function.
8062
4ffd0d6b 80632011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
8064
8065 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8066
4ffd0d6b 8067 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 8068
4ffd0d6b 80692011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 8070
4ffd0d6b
GM
8071 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8072 zombies (Bug#8467).
aac0c6e3 8073
04c56954
EZ
80742011-04-19 Eli Zaretskii <eliz@gnu.org>
8075
8076 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8077 gl_state.e_property when gl_state.object is Qt.
8078
8079 * insdel.c (make_gap_larger): Remove limitation of buffer size
8080 to <= INT_MAX.
8081
16a43933
CY
80822011-04-18 Chong Yidong <cyd@stupidchicken.com>
8083
8084 * xdisp.c (lookup_glyphless_char_display)
8085 (produce_glyphless_glyph): Handle cons cell entry in
8086 glyphless-char-display.
8087 (Vglyphless_char_display): Document it.
8088
8089 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8090 glyphless-char-display.
8091
4581706e
CY
80922011-04-17 Chong Yidong <cyd@stupidchicken.com>
8093
8094 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8095
8096 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8097
8098 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8099 definition for no-X builds.
8100
4887c6e2 81012011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 8102
fd35b6f9
PE
8103 Static checks with GCC 4.6.0 and non-default toolkits.
8104
5c1ccb01
PE
8105 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8106
006c5daa
PE
8107 * process.c (keyboard_bit_set): Define only if SIGIO.
8108 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8109 (send_process): Repair possible setjmp clobbering.
8110
efc736d3
PE
8111 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8112
4e2fe2e6
PE
8113 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8114
f97334a2
PE
8115 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8116
4e75f29d
PE
8117 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8118 Define only if needed.
8119
90efadd1
PE
8120 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8121 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 8122 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 8123
3c647824
PE
8124 * dispextern.h (struct redisplay_interface): Rename param
8125 to avoid shadowing.
e264f262 8126 * termhooks.h (struct terminal): Likewise.
761383f4 8127 * xterm.c (xembed_send_message): Likewise.
3c647824 8128
b58c5c4a
PE
8129 * insdel.c (make_gap_smaller): Define only if
8130 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8131
cad59032
PE
8132 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8133 it.
8134
c339dc2e
PE
8135 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8136 so that we aren't warned about unused symbols.
8137
91a3e27b
PE
8138 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8139
399c71d3 8140 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 8141
8ffc96f5
PE
8142 * xfns.c (x_real_positions): Mark locals as initialized.
8143
eef9bc79
PE
8144 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8145
098db9dd
PE
8146 * xterm.c: Fix problems found by static analysis with other toolkits.
8147 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
8148 (x_dispatch_event): Declare static if USE_GTK, and
8149 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 8150 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 8151 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
8152 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8153 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 8154
eb18f6cc
PE
8155 * xmenu.c (menu_help_callback): Pointer type fixes.
8156 Use const pointers when pointing at readonly data. Avoid pointer
8157 signedness clashes.
8158 (FALSE): Remove unused macro.
8159 (update_frame_menubar): Remove unused decl.
8160
1fe72bf8
PE
8161 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8162
60d9e1db
PE
8163 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8164 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8165 (single_menu_item): Rename local to avoid shadowing.
8166
39261c26
PE
8167 * keyboard.c (make_lispy_event): Remove unused local var.
8168
018c5e19
PE
8169 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8170 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8171
63d2b86e
PE
8172 * bitmaps: Change bitmaps from unsigned char back to the X11
8173 compatible char. Avoid the old compiler warnings about
8174 out-of-range initializers by using, for example, '\xab' rather
8175 than 0xab.
8176
aefd87e1
PE
8177 * xgselect.c (xgselect_initialize): Check vs interface
8178 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8179
bf501fb9
PE
8180 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8181
e9829fdf
PE
8182 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8183 to read-only memory.
8184
1086c095
PE
8185 * fns.c (vector): Remove; this old hack is no longer needed.
8186
2baccd04 8187 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 8188 Remove unused var.
dde42981 8189 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 8190
72391843 8191 * xrdb.c (x_load_resources): Omit unused local.
3565b346 8192
436c16df 8193 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 8194 (x_window): Rename locals to avoid shadowing.
dc5ddd85 8195 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 8196
92bb796d 8197 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 8198 (x_term_init): Remove local to avoid shadowing.
92bb796d 8199
764430a3 8200 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
8201
8202 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8203 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8204
d1dfb56c
EZ
82052011-04-16 Eli Zaretskii <eliz@gnu.org>
8206
c4354cb4
EZ
8207 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8208
d1dfb56c
EZ
8209 Fix regex.c, syntax.c and friends for buffers > 2GB.
8210 * syntax.h (struct gl_state_s): Declare character position members
8211 EMACS_INT.
8212
8213 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8214
04f2d78b
CB
8215 * textprop.c (verify_interval_modification, interval_of):
8216 Declare arguments EMACS_INT.
d1dfb56c
EZ
8217
8218 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8219 EMACS_INT.
8220
8221 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8222
8223 * indent.c (Fvertical_motion): Local variable it_start is now
8224 EMACS_INT.
8225
8226 * regex.c (re_match, re_match_2, re_match_2_internal)
8227 (bcmp_translate, regcomp, regexec, print_double_string)
8228 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8229 (re_compile_pattern, re_exec): Declare arguments and local
8230 variables `size_t' and `ssize_t' and return values `regoff_t', as
8231 appropriate.
8232 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8233 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8234 <compile_stack_type>: `size' and `avail' are now `size_t'.
8235
8236 * regex.h <regoff_t>: Use ssize_t, not int.
8237 (re_search, re_search_2, re_match, re_match_2): Arguments that
8238 specify buffer/string position and length are now ssize_t and
8239 size_t. Return type is regoff_t.
8240
613052cd
BK
82412011-04-16 Ben Key <bkey76@gmail.com>
8242
8243 * nsfont.m: Fixed bugs in ns_get_family and
8244 ns_descriptor_to_entity that were caused by using free to
8245 deallocate memory blocks that were allocated by xmalloc (via
8246 xstrdup). This caused Emacs to crash when compiled with
8247 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8248 --enable-checking=xmallocoverrun). xfree is now used to
8249 deallocate these memory blocks.
8250
4170f62f 82512011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 8252
71b41406
PE
8253 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8254
9587a89d
PE
8255 emacs_write: Accept and return EMACS_INT for sizes.
8256 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8257 et seq.
8258 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8259 Accept and return EMACS_INT.
8260 (emacs_gnutls_write): Return the number of bytes written on
8261 partial writes.
8262 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
8263 (emacs_read, emacs_write): Remove check for negative size, as the
8264 Emacs source code has been audited now.
9587a89d
PE
8265 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8266 (emacs_read, emacs_write): Use it.
273a5f82
PE
8267 * process.c (send_process): Adjust to the new signatures of
8268 emacs_write and emacs_gnutls_write. Do not attempt to store
8269 a byte offset into an 'int'; it might overflow.
9587a89d 8270 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 8271
3e047f51
PE
8272 * sound.c: Don't assume sizes fit in 'int'.
8273 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 8274 Return EMACS_INT, not int.
3e047f51 8275 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
8276 Accept EMACS_INT, not int.
8277 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
8278 record read return values.
8279
cc39a9db
BK
82802011-04-15 Ben Key <bkey76@gmail.com>
8281
c9d0ec6d
JB
8282 * keyboard.c (Qundefined): Don't declare static since it is used
8283 in nsfns.m.
8284 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8285 static since they are used in nsfont.m.
cc39a9db 8286
6c60eb9f
SM
82872011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8288
8289 * process.c (Qprocessp): Don't declare static.
8290 * lisp.h (Qprocessp): Declare again.
8291
7990b61a
JB
82922011-04-15 Juanma Barranquero <lekktu@gmail.com>
8293
8294 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8295
5d4cb038
PE
82962011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8297
8bd7b830 8298 Improve C-level modularity by making more things 'static'.
cd64ea1d 8299
e3b27b31
PE
8300 Don't publish debugger-only interfaces to other modules.
8301 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8302 (verify_bytepos, count_markers): Move decls to the only modules
8303 that need them.
8304 * region-cache.h (pp_cache): Likewise.
8305 * window.h (check_all_windows): Likewise.
8306 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8307
5d4cb038
PE
8308 * sysdep.c (croak): Now static, if
8309 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8310 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
8311
8312 * alloc.c (refill_memory_reserve): Now static if
8313 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8314 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 8315
e87b6180
PE
8316 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8317 Define only if USE_LUCID.
8318
ac64929e
PE
8319 * xrdb.c (x_customization_string, x_rm_string): Now static.
8320
6f37259d
PE
8321 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8322 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8323
1683e3ab
PE
8324 * xdisp.c (draw_row_with_mouse_face): Now static.
8325 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8326
de9c2632
PE
8327 * window.h (check_all_windows): Mark externally visible.
8328
2b96acb7
PE
8329 * window.c (window_deletion_count): Now static.
8330
8331 * undo.c: Make symbols static if they're not exported.
8332 (last_undo_buffer, last_boundary_position, pending_boundary):
8333 Now static.
8334
50436f33
PE
8335 * textprop.c (interval_insert_behind_hooks): Now static.
8336 (interval_insert_in_front_hooks): Likewise.
8337
64520e5c
PE
8338 * term.c: Make symbols static if they're not exported.
8339 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8340 (max_frame_lines, tty_set_terminal_modes):
8341 (tty_reset_terminal_modes, tty_turn_off_highlight):
8342 (get_tty_terminal): Now static.
8343 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8344 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 8345 HAVE_WINDOW_SYSTEM.
64520e5c
PE
8346 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8347 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8348
1fa53021
PE
8349 * sysdep.c: Make symbols static if they're not exported.
8350 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8351 Now static.
8352 (sigprocmask_set, full_mask): Remove; unused.
8353 (wait_debugging): Mark as visible.
8354 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8355 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8356
d4b43b22
PE
8357 * syntax.c (syntax_temp): Define only if !__GNUC__.
8358
b7c513d0
PE
8359 * sound.c (current_sound_device, current_sound): Now static.
8360
989b29ad
PE
8361 * search.c (searchbufs, searchbuf_head): Now static.
8362
13a55a78
PE
8363 * scroll.c (scroll_cost): Remove; unused.
8364 * dispextern.h (scroll_cost): Remove decl.
8365
de68a1fc
PE
8366 * region-cache.h (pp_cache): Mark as externally visible.
8367
40ccffa6
PE
8368 * process.c: Make symbols static if they're not exported.
8369 (process_tick, update_tick, create_process, chan_process):
8370 (Vprocess_alist, proc_buffered_char, datagram_access):
8371 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8372 (deactivate_process): Mark defn as static, as well as decl.
8373 * lisp.h (create_process): Remove decl.
8374 * process.h (chan_process, Vprocess_alist): Remove decls.
8375
ad64fc97
PE
8376 * print.c: Make symbols static if they're not exported.
8377 (print_depth, new_backquote_output, being_printed, print_buffer):
8378 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8379 (print_interval, print_number_index, initial_stderr_stream):
8380 Now static.
8381 * lisp.h (Fprinc): Remove decl.
8382 (debug_output_compilation_hack): Mark as externally visible.
8383
adddb265
PE
8384 * sysdep.c (croak): Move decl from here to syssignal.h.
8385 * syssignal.h (croak): Put it here, so the API can be checked when
8386 'croak' is called from dissociate_if_controlling_tty.
8387
1717ede2
PE
8388 * minibuf.c: Make symbols static if they're not exported.
8389 (minibuf_save_list, choose_minibuf_frame): Now static.
8390 * lisp.h (choose_minibuf_frame): Remove decl.
8391
fa5fb2bc
PE
8392 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8393
1e3890d1
PE
8394 * lread.c: Make symbols static if they're not exported.
8395 (read_objects, initial_obarray, oblookup_last_bucket_number):
8396 Now static.
8397 (make_symbol): Remove; unused.
8398 * lisp.h (initial_obarray, make_symbol): Remove decls.
8399
8a1414fa
PE
8400 * keyboard.c: Make symbols static if they're not exported.
8401 (single_kboard, recent_keys_index, total_keys, recent_keys):
8402 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8403 (this_single_command_key_start, echoing, last_auto_save):
8404 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8405 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8406 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8407 (Vlispy_mouse_stem, double_click_count):
8408 Now static.
8409 (force_auto_save_soon): Define only if SIGDANGER.
8410 (ignore_mouse_drag_p): Now static if
8411 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8412 (print_help): Remove; unused.
8413 (stop_character, last_timer_event): Mark as externally visible.
8414 * keyboard.h (ignore_mouse_drag_p): Declare only if
8415 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8416 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8417 * lisp.h (echoing): Remove decl.
8418 (force_auto_save_soon): Declare only if SIGDANGER.
8419 * xdisp.c (redisplay_window): Simplify code, to make it more
8420 obvious that ignore_mouse_drag_p is not accessed if !defined
8421 USE_GTK && !defined HAVE_NS.
8422
93ea6e8f
PE
8423 * intervals.c: Make symbols static if they're not exported.
8424 (merge_properties_sticky, merge_interval_right, delete_interval):
8425 Now static.
8426 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8427
77382fcc
PE
8428 * insdel.c: Make symbols static if they're not exported.
8429 However, leave prepare_to_modify_buffer alone. It's never
8430 called from outside this function, but that appears to be a bug.
8431 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8432 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8433 (adjust_after_replace_noundo): Remove; unused.
8434 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8435 (signal_before_change): Remove decls.
77382fcc 8436
9306c32e
PE
8437 * indent.c (val_compute_motion, val_vmotion): Now static.
8438
cd44d2eb
PE
8439 * image.c: Make symbols static if they're not exported.
8440 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8441 if USE_GTK.
8442 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8443 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8444
ad9a7a06
PE
8445 * fringe.c (standard_bitmaps): Now static.
8446 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8447
81626931
PE
8448 * frame.c: Make symbols static if they're not exported.
8449 (x_report_frame_params, make_terminal_frame): Now static.
8450 (get_frame_param): Now static, unless HAVE_NS.
8451 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8452 (x_get_resource_string): Remove; not used.
8453 * frame.h (make_terminal_frame, x_report_frame_params):
8454 (x_get_resource_string); Remove decls.
8455 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8456 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8457
239f9db9
PE
8458 * font.c, fontset.c: Make symbols static if they're not exported.
8459 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8460 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8461 * font.c (font_close_object): Now static.
8462 * font.h (font_close_object): Remove.
8463 * fontset.c (FONTSET_OBJLIST): Remove.
8464 (free_realized_fontset) #if-0 the body, which does nothing.
8465 (face_suitable_for_char_p): #if-0, as it's never called.
8466 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8467 * xfaces.c (face_at_string_position):
8468 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8469 since 0 is always ASCII.
8470
dfcf3579
PE
8471 * fns.c (weak_hash_tables): Now static.
8472
5045092b
PE
8473 * fileio.c: Make symbols static if they're not exported.
8474 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8475 (Vwrite_region_annotation_buffers): Now static.
8476
57a96f5c
PE
8477 * eval.c: Make symbols static if they're not exported.
8478 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8479 * lisp.h (backtrace_list): Remove decl.
8480
35f08c38
PE
8481 * emacs.c: Make symbols static if they're not exported.
8482 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8483 (fatal_error_code, fatal_error_signal_hook, standard_args):
8484 Now static.
8485 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8486 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8487 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8488 * lisp.h (fatal_error_signal_hook): Remove decl.
8489 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8490
f44bd759
PE
8491 * editfns.c: Move a (normally-unused) function to its only use.
8492 * editfns.c, lisp.h (get_operating_system_release): Remove.
8493 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8494 worth the hassle of breaking this out.
8495
b532497d
PE
8496 * xterm.c: Make symbols static if they're not exported.
8497 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8498 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8499 (x_destroy_window, x_delete_display):
8500 Now static.
8501 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8502 (x_mouse_leave): Remove; unused.
8503 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8504 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8505 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8506 Remove decls.
8507 (x_mouse_leave): Declare only if WINDOWSNT.
8508 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8509 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8510 USE_X_TOOLKIT.
8511
1675728f
PE
8512 * ftxfont.c: Make symbols static if they're not exported.
8513 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8514 HAVE_FREETYPE.
8515 * font.h (ftxfont_driver): Likewise.
8516
e4cebfca
PE
8517 * xfns.c: Make symbols static if they're not exported.
8518 (x_last_font_name, x_display_info_for_name):
8519 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8520 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8521 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8522 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8523 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8524 (last_show_tip_args): Now static.
8525 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8526 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8527 (x_screen_planes): Remove; unused.
8528 * dispextern.h (x_screen_planes): Remove decl.
8529
5bf46f05
PE
8530 * dispnew.c: Make symbols static if they're not exported.
8531 * dispextern.h (redraw_garbaged_frames, scrolling):
8532 (increment_row_positions): Remove.
8533 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8534 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8535 Now static.
8536 (redraw_garbaged_frames): Remove; unused.
8537
435f4c28
PE
8538 * xfaces.c: Make symbols static if they're not exported.
8539 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8540 Remove decls.
8541 * xterm.h (defined_color): Remove decls.
8542 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8543 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8544 (menu_face_changed_default, defined_color, free_realized_face):
8545 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8546 (ascii_face_of_lisp_face): Remove; unused.
8547
8524aef3
PE
8548 * xdisp.c: Make symbols static if they're not exported.
8549 * dispextern.h (scratch_glyph_row, window_box_edges):
8550 (glyph_to_pixel_coords, set_cursor_from_row):
8551 (get_next_display_element, set_iterator_to_next):
8552 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8553 (show_mouse_face): Remove decls
8554 * frame.h (message_buf_print): Likewise.
8555 * lisp.h (pop_message, set_message, check_point_in_composition):
8556 Likewise.
8557 * xterm.h (set_vertical_scroll_bar): Likewise.
8558 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8559 (message_buf_print, scratch_glyph_row, displayed_buffer):
8560 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8561 (get_next_display_element, show_mouse_face, window_box_edges):
8562 (frame_to_window_pixel_xy, check_point_in_composition):
8563 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8564 (glyph_to_pixel_coords): Remove; unused.
8565
16390cd2
PE
8566 * dired.c (file_name_completion): Now static.
8567
8568 * dbusbind.c (xd_in_read_queued_messages): Now static.
8569
a25f4dfa
PE
8570 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8571 * data.c (circular_list_error): Remove.
8572
14a9c8df
PE
8573 * commands.h (last_point_position, last_point_position_buffer):
8574 (last_point_position_window): Remove decls.
8575 * keyboard.c: Make these variables static.
8576
04f2d78b
CB
8577 * coding.h (coding, code_convert_region, encode_coding_gap):
8578 Remove decls.
74ab6df5
PE
8579 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8580 (iso_code_class, detect_coding, code_convert_region): Now static.
8581 (encode_coding_gap): Remove; unused.
8582
38dfbee1
PE
8583 * chartab.c (chartab_chars, chartab_bits): Now static.
8584
a2cb4e63
PE
8585 * charset.h (charset_iso_8859_1): Remove decl.
8586 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8587 Now static.
8588
127198fd
PE
8589 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8590 * ccl.c (Vccl_program_table): Now static.
8591 (check_ccl_update): Remove; unused.
8592
d85b608f
PE
8593 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8594 * category.h: ... from here.
8595 * category.c (check_category_table, set_category_set): Now static.
8596
31cd66f3
PE
8597 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8598 * lisp.h: Remove these decls.
8599
c358e587
PE
8600 * buffer.c (buffer_count): Remove unused var.
8601
e78aecca
PE
8602 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8603 so that it's not optimized away.
8604 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8605 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8606 exported only to the debugger.
8607
e192d7d3 8608 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8609 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8610
92470028
PE
8611 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8612 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8613 was inaccessible from Lisp.
8614 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8615 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8616
244ed907
PE
8617 alloc.c: Import and export fewer symbols, and remove unused items.
8618 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8619 is defined.
8620 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8621 it's not optimized away by whole-program optimization.
8622 (message_enable_multibyte, free_misc): Remove.
8623 (catchlist, handlerlist, mark_backtrace):
8624 Declare only if BYTE_MARK_STACK.
8625 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8626 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8627 (message_enable_multibyte): Remove decl.
8628 (free_misc, interval_free_list, float_block, float_block_index):
8629 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8630 (cons_free_list, last_marked_index):
8631 Now static.
8632 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8633 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8634 (mark_backtrace): Define only if BYTE_MARK_STACK.
8635 * xdisp.c (message_enable_multibyte): Now static.
8636
61c2b50e 8637 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8638 This makes it easier for human readers (and static analyzers)
8639 to see whether these variables are used from other modules.
8640 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8641 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8642 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8643 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8644 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8645 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8646 * xmenu.c, xselect.c:
8647 Declare Q* vars static if they are not used in other modules.
8648 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8649 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8650 Remove decls of unexported vars.
8651 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8652
95c82688
PE
8653 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8654
16a97296
PE
8655 Make Emacs functions such as Fatom 'static' by default.
8656 This makes it easier for human readers (and static analyzers)
8657 to see whether these functions can be called from other modules.
8658 DEFUN now defines a static function. To make the function external
8659 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8660 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8661 (Finit_image_library):
16a97296
PE
8662 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8663 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8664 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8665 Remove decls, since these functions are now static.
8666 (Funintern, Fget_internal_run_time): New decls, since these functions
8667 were already external.
95c82688 8668
16a97296
PE
8669 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8670 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8671 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8672 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8673 * keyboard.c, keymap.c, lread.c:
8674 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8675 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8676 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8677 Mark functions with DEFUE instead of DEFUN,
8678 if they are used in other modules.
8679 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8680 decls for now-static functions.
8681 * buffer.h (Fdelete_overlay): Remove decl.
8682 * callproc.c (Fgetenv_internal): Mark as internal.
8683 * composite.c (Fremove_list_of_text_properties): Remove decl.
8684 (Fcomposition_get_gstring): New forward static decl.
8685 * composite.h (Fcomposite_get_gstring): Remove decl.
8686 * dired.c (Ffile_attributes): New forward static decl.
8687 * doc.c (Fdocumntation_property): New forward static decl.
8688 * eval.c (Ffetch_bytecode): New forward static decl.
8689 (Funintern): Remove extern decl; now in .h file where it belongs.
8690 * fileio.c (Fmake_symbolic_link): New forward static decl.
8691 * image.c (Finit_image_library): New forward static decl.
8692 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8693 * intervals.h (Fprevious_property_change):
8694 (Fremove_list_of_text_properties): Remove decls.
8695 * keyboard.c (Fthis_command_keys): Remove decl.
8696 (Fcommand_execute): New forward static decl.
8697 * keymap.c (Flookup_key): New forward static decl.
8698 (Fcopy_keymap): Now static.
8699 * keymap.h (Flookup_key): Remove decl.
8700 * process.c (Fget_process): New forward static decl.
8701 (Fprocess_datagram_address): Mark as internal.
8702 * syntax.c (Fsyntax_table_p): New forward static decl.
8703 (skip_chars): Remove duplicate decl.
8704 * textprop.c (Fprevious_property_change): New forward static decl.
8705 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8706 Now internal.
8707 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8708 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8709
785bbd42
PE
8710 * editfns.c (Fformat): Remove unreachable code.
8711
8b913b57
AS
87122011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8713
8714 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8715 change. (Bug#8496)
8716
a6744a35
EZ
87172011-04-13 Eli Zaretskii <eliz@gnu.org>
8718
8719 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8720 when at ZV. (Bug#8487)
8721
e7974947
AS
87222011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8723
baad03f0
AS
8724 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8725 (Bug#8437)
8726 * keyboard.c (parse_tool_bar_item): Likewise.
8727 * sound.c (sound_cleanup, alsa_close): Likewise.
8728 * termcap.c (tgetent): Likewise.
8729 * xfns.c (x_default_font_parameter): Likewise.
8730 * xsettings.c (read_and_apply_settings): Likewise.
8731
e7974947
AS
8732 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8733 (overrun_check_free): Protoize.
8734
28272684
PE
87352011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8736
8737 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8738 since callers should never pass a negative size.
8739 Change the signature to match that of plain 'read' and 'write'; see
8740 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8741 * lisp.h: Update prototypes of emacs_write and emacs_read.
8742
11997c76
EZ
87432011-04-11 Eli Zaretskii <eliz@gnu.org>
8744
8745 * xdisp.c (redisplay_window): Don't try to determine the character
8746 position of the scroll margin if the window start point w->startp
e896f03c 8747 is outside the buffer's accessible region. (Bug#8468)
11997c76 8748
8a2cbd72
EZ
87492011-04-10 Eli Zaretskii <eliz@gnu.org>
8750
8751 Fix write-region and its subroutines for buffers > 2GB.
8752 * fileio.c (a_write, e_write): Modify declaration of arguments and
8753 local variables to support buffers larger than 2GB.
8754 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8755
8756 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8757 argument, local variables, and return value.
8758
8759 * lisp.h: Update prototypes of emacs_write and emacs_read.
8760
8761 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8762
4073e537 87632011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8764
1ebfdcb6
PE
8765 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8766
b2ded58d
PE
8767 Fix more problems found by GCC 4.6.0's static checks.
8768
7d66342c
PE
8769 * xdisp.c (vmessage): Use a better test for character truncation.
8770
bbf47d44
PE
8771 * charset.c (load_charset_map): <, not <=, for optimization,
8772 and to avoid potential problems with integer overflow.
9248994d 8773 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8774 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8775 * editfns.c (Fformat): Likewise.
1e69125e 8776 * syntax.c (skip_chars): Likewise.
3befa583 8777
e3019616
PE
8778 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8779 This also lets GCC 4.6.0 generate slightly better loop code.
8780
becfa255
PE
8781 * callint.c (Fcall_interactively): <, not <=, for optimization.
8782 (Fcall_interactively): Count the number of arguments produced,
8783 not the number of arguments given. This is simpler and lets GCC
8784 4.6.0 generate slightly better code.
8785
dae0cd48
PE
8786 * ftfont.c: Distingish more carefully between FcChar8 and char.
8787 The previous code passed unsigned char * to a functions like
8788 strlen and xstrcasecmp that expect char *, which does not
8789 conform to the C standard.
8790 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8791 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8792 char * when the C standard requires it.
8793
76032d70
PE
8794 * keyboard.c (read_char): Remove unused var.
8795
eb3f1cc8
PE
8796 * eval.c: Port to Windows vsnprintf (Bug#8435).
8797 Include <limits.h>.
8798 (SIZE_MAX): Define if the headers do not.
8799 (verror): Do not give up if vsnprintf returns a negative count.
8800 Instead, grow the buffer. This ports to Windows vsnprintf, which
8801 does not conform to C99. Problem reported by Eli Zaretskii.
8802 Also, simplify the allocation scheme, by avoiding the need for
8803 calling realloc, and removing the ALLOCATED variable.
8804
70476b54
PE
8805 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8806
12020a9e
PE
8807 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8808 But keep the doprint source code for now, as we might revamp it
8809 and use it again (Bug#8435).
ea6c7ae6
PE
8810 * lisp.h (doprnt): Remove.
8811 * Makefile.in (base_obj): Remove doprnt.o.
8812 * deps.mk (doprnt.o): Remove.
8813
5fdb398c
PE
8814 error: Print 32- and 64-bit integers portably (Bug#8435).
8815 Without this change, on typical 64-bit hosts error ("...%d...", N)
8816 was used to print both 32- and 64-bit integers N, which relied on
8817 undefined behavior.
61bdb816 8818 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8819 * lisp.h (error, verror): Mark as printf-like functions.
8820 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8821 Report overflow in size calculations when allocating printf buffer.
8822 Do not truncate output string at its first null byte.
8823 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8824 Truncate the output at a character boundary, since vsnprintf does not
8825 do that.
8826 * charset.c (check_iso_charset_parameter): Convert internal
8827 character to string before calling 'error', since %c now has the
8828 printf meaning.
8829 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8830 overflow when computing char to be passed to 'error'. Do not
8831 pass Lisp_Object to 'error'; pass the integer instead.
8832 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8833 formatted with plain %d.
8834
b189fa66
PE
8835 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8836
bff87ef0
PE
8837 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8838
7e2cac20
PE
8839 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8840
ce4d90b5
PE
8841 * xterm.c (x_catch_errors): Remove duplicate declaration.
8842
266c9547
PE
8843 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8844
79c49ad2
PE
8845 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8846
368f4090
JM
88472011-04-10 Jim Meyering <meyering@redhat.com>
8848
8849 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8850 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8851 return ssize_t not "int", and use size_t as the buffer length.
8852 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8853 * gnutls.h: Update declarations.
8854 * process.c (read_process_output): Use ssize_t, to match.
8855 (send_process): Likewise.
8856
a32d4040
CY
88572011-04-09 Chong Yidong <cyd@stupidchicken.com>
8858
8859 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8860
8546720e 88612011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8862
04f2d78b
CB
8863 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8864 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8865
8546720e
GM
8866 * xterm.c (handle_one_xevent):
8867 * xmenu.c (create_and_show_popup_menu):
8868 * xselect.c (x_decline_selection_request)
8869 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8870
0a2f5c1a 88712011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8872
8873 Fix some uses of `int' instead of EMACS_INT.
8874 * search.c (string_match_1, fast_string_match)
8875 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8876 (scan_buffer, find_next_newline_no_quit)
8877 (find_before_next_newline, search_command, Freplace_match)
8878 (Fmatch_data): Make some `int' variables be EMACS_INT.
8879
8880 * xdisp.c (display_count_lines): 3rd argument and return value now
8881 EMACS_INT. All callers changed.
8882 (pint2hrstr): Last argument is now EMACS_INT.
8883
8884 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8885 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8886 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8887 (decode_coding_utf_16, decode_coding_emacs_mule)
8888 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8889 (decode_coding_ccl, decode_coding_charset)
8890 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8891 (decode_coding_iso_2022, decode_coding_emacs_mule)
8892 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8893 <char_offset, last_offset>: Declare EMACS_INT.
8894 (encode_coding_utf_8, encode_coding_utf_16)
8895 (encode_coding_emacs_mule, encode_invocation_designation)
8896 (encode_designation_at_bol, encode_coding_iso_2022)
8897 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8898 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8899 Declare EMACS_INT.
8900 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8901 (encode_invocation_designation): Last argument P_NCHARS is now
8902 EMACS_INT.
8903 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8904 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8905
8906 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8907 All users changed.
8908
8909 * ccl.c (Fccl_execute_on_string): Declare some variables
8910 EMACS_INT.
8911
8546720e 89122011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8913
8914 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8915
4e19a977
CS
89162011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8917
8918 * process.c (Fformat_network_address): Doc fix.
8919
87302331
R
89202011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8921
ee7683eb 8922 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8923
cbb59342
CY
89242011-04-08 Chong Yidong <cyd@stupidchicken.com>
8925
8926 * keyboard.c (read_char): Call Lisp function help-form-show,
8927 instead of using internal_with_output_to_temp_buffer.
8928 (Qhelp_form_show): New var.
e0d38eeb 8929 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8930
8931 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8932
8933 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8934
e67a13ab
CY
89352011-04-06 Chong Yidong <cyd@stupidchicken.com>
8936
04f2d78b
CB
8937 * process.c (Flist_processes): Remove to Lisp.
8938 (list_processes_1): Delete.
e67a13ab 8939
973f782d
EZ
89402011-04-06 Eli Zaretskii <eliz@gnu.org>
8941
7c106b1e
EZ
8942 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8943
973f782d
EZ
8944 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8945
41cf7d1a 89462011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8947
ca23cc88
PE
8948 Fix more problems found by GCC 4.6.0's static checks.
8949
f390e2d5
PE
8950 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8951
42eea0d0
PE
8952 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8953
b69769da 8954 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8955
f9541e84
PE
8956 * xdisp.c (vmessage): Mark as a printf-like function.
8957
13841b55
PE
8958 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8959
c136c10f
PE
8960 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8961
5e2d4a30
PE
8962 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8963 printf-like functions.
8964 (tiff_load): Add casts to remove these marks before passing them
8965 to system-supplied API.
8966
583f48b9
PE
8967 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8968
b25d760e
PE
8969 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8970 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8971 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8972 directly, rather than having caller test rule sign. This avoids
8973 some unnecessary tests.
8974 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8975 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8976 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8977
bc7b6697 8978 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8979 (xfont_open): Avoid unnecessary tests.
bc7b6697 8980
27ccc379
PE
8981 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8982
dcd5c89a
PE
8983 * composite.h, composite.c (composition_gstring_put_cache):
8984 Use EMACS_INT, not int, for length.
8985
b13a45c6
PE
8986 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8987 breaking out part of COMPOSITION_DECODE_RULE.
8988 (COMPOSITION_DECODE_RULE): Use it.
8989 * composite.c (get_composition_id): Remove unused local vars,
8990 by using the new macro.
8991
1e792e4d
PE
8992 * textprop.c (set_text_properties_1): Change while to do-while,
8993 since the condition is always true at first.
8994
dc6c6455 8995 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8996 (interval_deletion_adjustment): Return unsigned value.
8997 All uses changed.
dc6c6455 8998
aba7731a
PE
8999 * process.c (list_processes_1, create_pty, read_process_output):
9000 (exec_sentinel): Remove vars that were set but not used.
afd4052b 9001 (create_pty): Remove unnecessary "volatile"s.
bc57d757 9002 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 9003 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 9004 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 9005
fdfc4bf3
PE
9006 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9007
fca8fe46 9008 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 9009 (update_syntax_table): Use unsigned instead of int.
fca8fe46 9010
06a0259a 9011 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 9012 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 9013 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 9014
e7b9e80f
PE
9015 * print.c (print_error_message): Avoid int overflow.
9016
56201685
PE
9017 * font.c (font_list_entities): Redo for clarity,
9018 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9019
78834453 9020 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 9021 (font_score): Avoid potential overflow in diff calculation.
78834453 9022
0bc0b309 9023 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 9024 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 9025
e610eaca
PE
9026 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9027
b895abce
PE
9028 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9029 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9030 can always succeed if overflow has undefined behavior.
9031
1f1d9321 9032 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 9033 (wordify): Omit three unnecessary tests.
1f1d9321 9034
c59478bc
PE
9035 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9036 All callers changed. This avoids the need for an unused var.
9037
79b73827
PE
9038 * casefiddle.c (casify_region): Remove var that is set but not used.
9039
a4db5dfe
PE
9040 * dired.c (file_name_completion): Remove var that is set but not used.
9041
43aae36e
PE
9042 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9043
2a47c44d 9044 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 9045 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 9046
a37c69bf
PE
9047 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9048 Check for integer overflow on size calculations.
9049
328ab8e7
PE
9050 * buffer.c (Fprevious_overlay_change): Remove var that is set
9051 but not used.
9052
e5a2a5cb
PE
9053 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9054 Remove vars that are set but not used.
8d84a6eb 9055 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 9056 (timer_check_2): Mark vars as initialized.
e5a2a5cb 9057
a60e5f68
PE
9058 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9059
f661cb61 9060 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 9061 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 9062
f0397f5a
PE
9063 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9064 that are set but not used.
9065
8664db06 9066 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 9067 if XCreateBitmapFromData fails (Bug#8410).
8664db06 9068
6abdaa4a
PE
9069 * xselect.c (x_get_local_selection, x_handle_property_notify):
9070 Remove vars that are set but not used.
9071
0ce7538d 9072 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 9073 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 9074
9ae848fc
PE
9075 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9076 Remove var that is set but not used.
0b918413
PE
9077 (scroll_bar_windows_size): Now size_t, not int.
9078 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9079 Check for overflow.
9ae848fc 9080
a5a62657
PE
9081 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9082 (map_tty_color) [!defined MSDOS]: Likewise.
9083
5c5cdd39
PE
9084 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9085
66ebf983
PE
9086 * coding.c: Remove vars that are set but not used.
9087 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9088 All callers changed.
9089 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9090 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9091 (decode_coding_charset): Remove vars that are set but not used.
9092
1be4d761
PE
9093 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9094 that is set but not used.
9095
47553fa8
PE
9096 * print.c (print_object): Remove var that is set but not used.
9097
1f7196bf 9098 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
9099 The gnulib version avoids calling malloc in the usual case,
9100 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9101 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9102 * filelock.c (current_lock_owner): Likewise.
9103 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9104 * sysdep.c: Include allocator.h, careadlinkat.h.
9105 (emacs_no_realloc_allocator): New static constant.
9106 (emacs_readlink): New function.
fdb61804
PE
9107 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9108 ../lib/careadlinkat.h.
d1fdcab7 9109
f84c17c7
SM
91102011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9111
9112 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9113 first non-nil return value).
9114
ef3862ad
JD
91152011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9116
9117 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9118 if not defined (Bug#8403).
9119
376a7006
JB
91202011-04-02 Juanma Barranquero <lekktu@gmail.com>
9121
9122 * xdisp.c (display_count_lines): Remove parameter `start',
9123 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9124 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9125 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9126 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9127 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9128 and thereabouts. All callers changed.
9129 (get_per_char_metric): Remove parameter `f', unused since
9130 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9131
6ca3801d
JM
91322011-04-02 Jim Meyering <meyering@redhat.com>
9133
9134 do not dereference NULL upon failed strdup
9135 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9136 (ns_get_family): Likewise.
9137
d8e2b5ba
JB
91382011-04-02 Juanma Barranquero <lekktu@gmail.com>
9139
9140 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9141
8c74fcbd
JD
91422011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9143
9144 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9145 later (Bug#8403).
9146
7200d79c
SM
91472011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9148
03408648 9149 Add lexical binding.
7200d79c 9150
03408648
SM
9151 * window.c (Ftemp_output_buffer_show): New fun.
9152 (Fsave_window_excursion):
9153 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9154
9155 * lread.c (lisp_file_lexically_bound_p): New function.
9156 (Fload): Bind Qlexical_binding.
9157 (readevalloop): Remove `evalfun' arg.
9158 Bind Qinternal_interpreter_environment.
9159 (Feval_buffer): Bind Qlexical_binding.
9160 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9161 Mark as dynamic.
9162 (syms_of_lread): Declare `lexical-binding'.
9163
9164 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9165
9166 * keyboard.c (eval_dyn): New fun.
9167 (menu_item_eval_property): Use it.
ca105506
SM
9168
9169 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 9170
03408648
SM
9171 * fns.c (concat, mapcar1): Accept byte-code-functions.
9172
9173 * eval.c (Fsetq): Handle lexical vars.
9174 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9175 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9176 (FletX, Flet): Obey lexical binding.
9177 (Fcommandp): Handle closures.
9178 (Feval): New `lexical' arg.
9179 (eval_sub): New function extracted from Feval. Use it almost
9180 everywhere where Feval was used. Look up vars in lexical env.
9181 Handle closures.
9182 (Ffunctionp): Move from subr.el.
9183 (Ffuncall): Handle closures.
9184 (apply_lambda): Remove `eval_flags'.
9185 (funcall_lambda): Handle closures and new byte-code-functions.
9186 (Fspecial_variable_p): New function.
9187 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9188 but without exporting it to Lisp.
23aba0ea 9189
23aba0ea 9190 * doc.c (Fdocumentation, store_function_docstring):
03408648 9191 * data.c (Finteractive_form): Handle closures.
23aba0ea 9192
03408648
SM
9193 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9194 interactive spec.
ba83908c 9195
04f2d78b
CB
9196 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9197 New byte-codes.
03408648
SM
9198 (exec_byte_code): New function extracted from Fbyte_code to handle new
9199 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 9200
03408648 9201 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 9202
03408648 9203 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 9204
e2abce01
JB
92052011-03-31 Juanma Barranquero <lekktu@gmail.com>
9206
9207 * xdisp.c (redisplay_internal): Fix prototype.
9208
63696a73 92092011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 9210
63696a73 9211 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
9212 (try_scrolling): Use it when setting scroll_limit.
9213 Limit scrolling to 100 screen lines.
63696a73
EZ
9214 (redisplay_window): Even when falling back on "recentering",
9215 position point in the window according to scroll-conservatively,
9216 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9217
9218 (try_scrolling): When point is above the window, allow searching
9219 as far as scroll_max, or one screenful, to compute vertical
9220 distance from PT to the scroll margin position. This prevents
9221 try_scrolling from unnecessarily failing when
9222 scroll-conservatively is set to a value slightly larger than the
9223 window height. Clean up the case of PT below the margin at bottom
9224 of window: scroll_max can no longer be INT_MAX. When aggressive
9225 scrolling is in use, don't let point enter the opposite scroll
9226 margin as result of the scroll.
9227 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
9228 threshold of 100 lines for never-recentering scrolling.
9229
e4cc2dfc
JB
92302011-03-31 Juanma Barranquero <lekktu@gmail.com>
9231
9232 * dispextern.h (move_it_by_lines):
9233 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9234 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9235 (message_log_check_duplicate): Remove parameters `prev_bol' and
9236 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9237 (redisplay_internal): Remove parameter `preserve_echo_area',
9238 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9239
9240 * indent.c (Fvertical_motion):
9241 * window.c (window_scroll_pixel_based, Frecenter):
9242 Don't pass `need_y_p' to `move_it_by_lines'.
9243
1c470562
SM
92442011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9245
44f230aa
SM
9246 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9247 steal a few bits to be more compact.
9248 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9249 Remove unneeded casts.
9250
1c470562
SM
9251 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9252
888adce9
ZK
92532011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9254
9255 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9256 binding" message (bug#7967).
9257
f838ed7b
PE
92582011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9259
77861b95
PE
9260 Fix more problems found by GCC 4.6.0's static checks.
9261
de6dbc14
PE
9262 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9263 Remove unused local var.
9264
f838ed7b
PE
9265 * editfns.c (Fmessage_box): Remove unused local var.
9266
792c7b2b
PE
9267 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9268 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9269 Omit unused local vars.
c499e557 9270 * window.c (shrink_windows): Omit unused local var.
b01a1c29 9271 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
9272 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9273 Omit unused local var.
9274
ba0165e1
PE
9275 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9276 Don't assume string length fits in int.
32ad8845 9277 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 9278 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 9279
3c59b4c9
PE
9280 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9281 instead of alloca (Bug#8344).
9282
a3eed478 9283 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 9284 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 9285
eb4d412d
PE
9286 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9287
1658b401
PE
9288 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9289 concerns.
9290
9291 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9292
9293 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 9294
9a2c6e05
PE
9295 * keyboard.c (syms_of_keyboard): Use the same style as later
9296 in this function when indexing through an array. This also
9297 works around GCC bug 48267.
9298
03d0a109
PE
9299 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9300
44f730c8
PE
9301 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9302
fe75f926
PE
9303 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9304 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9305
ffa8c828
PE
9306 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9307 This avoids undefined behavior on integer overflow, and is a bit
9308 more convenient anyway since it is compared to a size_t variable.
9309
c5101a77
PE
9310 Variadic C functions now count arguments with size_t, not int.
9311 This avoids an unnecessary limitation on 64-bit machines, which
9312 caused (substring ...) to crash on large vectors (Bug#8344).
9313 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9314 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 9315 All variadic functions and their callers changed accordingly.
c5101a77
PE
9316 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9317 * data.c (arith_driver, float_arith_driver): Likewise.
9318 * editfns.c (general_insert_function): Likewise.
9319 * eval.c (struct backtrace.nargs, interactive_p)
9320 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9321 (funcall_lambda, mark_backtrace): Likewise.
9322 * fns.c (concat): Likewise.
9323 * frame.c (x_set_frame_parameters): Likewise.
9324 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9325 0 if not found, not -1. All callers changed.
9326
dd3f25f7
PE
9327 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9328 (stack_copy_size): Now size_t, not int.
9329 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9330
461c2ab9
JB
93312011-03-28 Juanma Barranquero <lekktu@gmail.com>
9332
9333 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9334 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9335 All callers changed.
9336
9337 * lisp.h (multibyte_char_to_unibyte):
9338 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9339 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9340 * character.h (CHAR_TO_BYTE8):
9341 * cmds.c (internal_self_insert):
9342 * editfns.c (general_insert_function):
9343 * keymap.c (push_key_description):
9344 * search.c (Freplace_match):
9345 * xdisp.c (message_dolog, set_message_1): All callers changed.
9346
f6d62986
SM
93472011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9348
9349 * keyboard.c (safe_run_hook_funcall): New function.
9350 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9351 don't set the hook to nil, but remove the offending function instead.
9352 (Qcommand_hook_internal): Remove, unused.
9353 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9354 Vcommand_hook_internal.
9355
9356 * eval.c (enum run_hooks_condition): Remove.
9357 (funcall_nil, funcall_not): New functions.
9358 (run_hook_with_args): Call each function through a `funcall' argument.
9359 Remove `cond' argument, now redundant.
9360 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9361 (Frun_hook_with_args_until_failure): Adjust accordingly.
9362 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9363
1db5b1ad
JB
93642011-03-28 Juanma Barranquero <lekktu@gmail.com>
9365
9366 * dispextern.h (string_buffer_position): Remove declaration.
9367
9368 * print.c (strout): Remove parameter `multibyte', unused since
9369 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9370
9371 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9372 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9373 All callers changed.
9374
9375 * w32.c (_wsa_errlist): Use braces for struct initializers.
9376
9377 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9378 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9379 All callers changed.
9380 (string_buffer_position): Likewise. Also, make static (it's never
9381 used outside xdisp.c).
9382 (cursor_row_p): Remove parameter `w', unused since
9383 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9384 (decode_mode_spec): Remove parameter `precision', introduced during
9385 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9386 All callers changed.
9387
5ffb62aa
JD
93882011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9389
9390 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9391
461c2ab9 93922011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9393
9394 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9395 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9396 (ns_update_auto_hide_menu_bar): New functions.
9397 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9398 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9399 ns_constrain_all_frames.
9400 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9401 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9402
5c380ffb
JD
94032011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9404
9405 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9406
9af30bdf
GM
94072011-03-27 Glenn Morris <rgm@gnu.org>
9408
9409 * syssignal.h: Replace RETSIGTYPE with void.
9410 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9411 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9412 Replace SIGTYPE with void everywhere.
9413 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9414 * s/template.h (SIGTYPE): Remove commented out definition.
9415
e2abce01
JB
94162011-03-26 Eli Zaretskii <eliz@gnu.org>
9417
9418 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9419 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9420
f868cd8a
JB
94212011-03-26 Juanma Barranquero <lekktu@gmail.com>
9422
59eb0929
JB
9423 * w32.c (read_unc_volume): Use parameter `henum', instead of
9424 global variable `wget_enum_handle'.
9425
9426 * keymap.c (describe_vector): Remove parameters `indices' and
9427 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9428 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9429
f868cd8a
JB
9430 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9431
9432 * keyboard.c (timer_check): Remove parameter `do_it_now',
9433 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9434 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9435 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9436
9437 * keyboard.c (read_char):
9438 * w32menu.c (w32_menu_display_help):
9439 * xmenu.c (show_help_event, menu_help_callback):
9440 Adjust calls to `show_help_echo'.
9441
9442 * gtkutil.c (xg_maybe_add_timer):
9443 * keyboard.c (readable_events):
9444 * process.c (wait_reading_process_output):
9445 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9446
9447 * insdel.c (adjust_markers_gap_motion):
9448 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9449 (gap_left, gap_right): Don't call it.
9450
2ecf6fdb
CY
94512011-03-25 Chong Yidong <cyd@stupidchicken.com>
9452
9453 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9454 incurred during fontification.
9455
6b1f9ba4
JB
94562011-03-25 Juanma Barranquero <lekktu@gmail.com>
9457
9458 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9459 (DEFVAR_PER_BUFFER): Don't pass it.
9460
9461 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9462 (scrolling_window): Don't pass it.
9463
0f4a96b5
JB
94642011-03-25 Juanma Barranquero <lekktu@gmail.com>
9465
9466 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9467
9468 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9469 and `suffix'.
9470 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9471 of variables specific to SELinux and computation of `encoded_absname'.
9472
9473 * image.c (XPutPixel): Remove unused variable `height'.
9474
9475 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9476
9477 * unexw32.c (get_section_info): Remove unused variable `section'.
9478
9479 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9480 (system_process_attributes): Remove unused variable `sess'.
9481 (sys_read): Remove unused variable `err'.
9482
9483 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9484 (w32_wnd_proc): Remove unused variable `isdead'.
9485 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9486 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9487 (x_create_tip_frame): Remove unused variable `tem'.
9488
9489 * w32inevt.c (w32_console_read_socket):
9490 Remove unused variable `no_events'.
9491
9492 * w32term.c (x_draw_composite_glyph_string_foreground):
9493 Remove unused variable `width'.
9494
1149507c
JB
94952011-03-24 Juanma Barranquero <lekktu@gmail.com>
9496
9497 * w32term.c (x_set_glyph_string_clipping):
9498 Don't pass uninitialized region to CombineRgn.
9499
9c88f339
JB
95002011-03-23 Juanma Barranquero <lekktu@gmail.com>
9501
9502 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9503 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9504 (Fx_close_connection): Remove unused variable `i'.
9505
9506 * w32font.c (w32font_draw): Return number of glyphs.
9507 (w32font_open_internal): Remove unused variable `i'.
9508 (w32font_driver): Add missing initializer.
9509
9510 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9511 (fill_in_menu): Remove unused variable `items_added'.
9512
9513 * w32term.c (last_mouse_press_frame): Remove static global variable.
9514 (w32_clip_to_row): Remove unused variable `f'.
9515 (x_delete_terminal): Remove unused variable `i'.
9516
9517 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9518 (NOTHING): Remove unused static global variable.
9519 (uniscribe_check_otf): Remove unused variable `table'.
9520 (uniscribe_font_driver): Add missing initializers.
9521
dee091a3
JD
95222011-03-23 Julien Danjou <julien@danjou.info>
9523
9524 * term.c (Fsuspend_tty, Fresume_tty):
9525 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9526 * window.c (temp_output_buffer_show):
9527 * insdel.c (signal_before_change):
9528 * frame.c (Fhandle_switch_frame):
9529 * fileio.c (Fdo_auto_save):
9530 * emacs.c (Fkill_emacs):
9531 * editfns.c (save_excursion_restore):
9532 * cmds.c (internal_self_insert):
9533 * callint.c (Fcall_interactively):
9534 * buffer.c (Fkill_all_local_variables):
9535 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9536 Use Frun_hooks.
0f4a96b5 9537 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9538 unconditionally since it does the check itself.
dee091a3 9539
2c520ab5 95402011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9541
c9c49752
PE
9542 Fix more problems found by GCC 4.5.2's static checks.
9543
8abc3f12
PE
9544 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9545 the first time through the loop, since we know p0 < p1 then.
9546 This also avoids a gcc -Wstrict-overflow warning.
9547
a2d26660
PE
9548 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9549 leading to a memory leak, possible in functions like
9550 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9551 of objects (Bug#8318).
a2d26660 9552
916c72e9
PE
9553 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9554 that could (at least in theory) be that large.
9555
19ab8a18
PE
9556 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9557 This is less likely to overflow, and avoids undefined behavior if
9558 overflow does occur. All callers changed. Use strtoul to scan
9559 for the unsigned long integer.
b7cbbd6f
PE
9560 (pint2hrstr): Simplify and tune code slightly.
9561 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9562
f0641eff
PE
9563 * scroll.c (do_scrolling): Work around GCC bug 48228.
9564 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9565
7f650bb9
PE
9566 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9567 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9568 (validate_x_resource_name): Simplify count usage.
9569 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9570
37dd57d1
PE
9571 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9572 fail (Bug#8306).
81e56e61 9573
699979fc 9574 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9575
401bf9b4
PE
9576 * process.c (Fmake_network_process): Use socklen_t, not int,
9577 where POSIX says socklen_t is required in portable programs.
9578 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9579 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9580 (Fmake_network_process, server_accept_connection):
9581 (wait_reading_process_output, read_process_output):
9582 Likewise.
9583
b93aacde
PE
9584 * process.c: Rename or move locals to avoid shadowing.
9585 (list_processes_1, Fmake_network_process):
9586 (read_process_output_error_handler, exec_sentinel_error_handler):
9587 Rename or move locals.
4dc343ee 9588 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9589 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9590 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9591 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9592 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9593
af8a867c 9594 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9595 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9596 Include tparam.h instead, since it declares them.
af8a867c
PE
9597 * cm.h (PC): Remove extern decl; tparam.h now does this.
9598 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9599 * terminfo.c: Include tparam.h, to check interfaces.
9600 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9601 (tparam): Adjust signature to match interface in tparam.h;
9602 this removes some undefined behavior. Check that outstring and len
9603 are zero, which they always are with Emacs.
9604 * tparam.h (PC, BC, UP): New extern decls.
9605
0248044d 9606 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9607 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9608
8ff096c1 9609 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9610 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9611 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9612 (ftfont_list): Remove unused local.
49eaafba
PE
9613 (get_adstyle_property, ftfont_pattern_entity):
9614 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9615 Rename locals to avoid shadowing.
8ff096c1 9616
e2be39f6
PE
9617 * xfont.c (xfont_list_family): Mark var as initialized.
9618
c9735e30
PE
9619 * xml.c (make_dom): Now static.
9620
8f5201ae
PE
9621 * composite.c (composition_compute_stop_pos): Rename local to
9622 avoid shadowing.
b246f932
PE
9623 (composition_reseat_it): Remove unused locals.
9624 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9625 (composition_update_it): Mark var as initialized.
11b61122
PE
9626 (find_automatic_composition): Mark vars as initialized,
9627 with a FIXME (Bug#8290).
8f5201ae 9628
760fbc2c
PE
9629 character.h: Rename locals to avoid shadowing.
9630 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9631 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9632 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9633 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9634 to avoid shadowing.
9635
ff08eb85
PE
9636 * textprop.c (property_change_between_p): Remove; unused.
9637
fc7bf025
PE
9638 * intervals.c (interval_start_pos): Now static.
9639
235d7abc
PE
9640 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9641
44f230aa
SM
9642 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9643 Rename locals to avoid shadowing.
3e7d6594 9644
50060332
PE
9645 * sound.c (wav_play, au_play, Fplay_sound_internal):
9646 Fix pointer signedness.
d01f234b 9647 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9648 (wav_play): Initialize a variable to 0, to prevent undefined
9649 behavior (Bug#8278).
50060332 9650
c4fc4e30
PE
9651 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9652
918436ed
PE
9653 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9654
c939f91b
PE
9655 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9656 clobbering (Bug#8298).
b9c7f648
PE
9657 * sysdep.c (sys_subshell): Likewise.
9658 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9659
6bd8c144
PE
9660 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9661 This should get cleaned up, so that child_setup has the
9662 same signature on all platforms.
9663
7710357c 9664 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9665 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9666
c59da222
CY
96672011-03-22 Chong Yidong <cyd@stupidchicken.com>
9668
9669 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9670 not to be necessary, and produces flickering.
9671
66b87493
GM
96722011-03-20 Glenn Morris <rgm@gnu.org>
9673
9674 * config.in: Remove file.
9675
45b6f6d5
JB
96762011-03-20 Juanma Barranquero <lekktu@gmail.com>
9677
9678 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9679 are now in src/globals.h.
9680 (syms_of_minibuf): Remove spurious & from previous change.
9681
cd394be1 96822011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9683
9684 * minibuf.c (completing-read-function): New variable.
9685 (completing-read-default): Rename from completing-read.
9686 (completing-read): Call completing-read-function.
9687
b14e3e21
CY
96882011-03-19 Juanma Barranquero <lekktu@gmail.com>
9689
9690 * xfaces.c (Fx_load_color_file):
9691 Read color file from absolute filename (bug#8250).
9692
f2b726e6
JB
96932011-03-19 Juanma Barranquero <lekktu@gmail.com>
9694
9695 * makefile.w32-in: Update dependencies.
9696
09f6ff02
EZ
96972011-03-17 Eli Zaretskii <eliz@gnu.org>
9698
9699 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9700
29a6015a
PE
97012011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9702
a3a6c54e
PE
9703 Fix more problems found by GCC 4.5.2's static checks.
9704
b766f867
PE
9705 * process.c (make_serial_process_unwind, send_process_trap):
9706 (sigchld_handler): Now static.
9707
be02381c
PE
9708 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9709 That way, the code declares only the vars that it needs.
9710 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9711 * s/cygwin.h (PTY_ITERATION): Likewise.
9712 * s/darwin.h (PTY_ITERATION): Likewise.
9713 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9714
57048744
PE
9715 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9716 * process.c (allocate_pty): Don't declare stb unless it's needed.
9717
7914961c 9718 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9719 (CONSTANTLIM): Remove; unused.
9720 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9721 Define only if needed.
7914961c 9722
b3967b18
PE
9723 * unexelf.c (unexec): Name an expression,
9724 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9725 Use a different way to cause a compilation error if anyone uses
9726 n rather than nn, a way that does not involve shadowing.
73366a00 9727 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9728
29a6015a
PE
9729 * deps.mk (unexalpha.o): Remove; unused.
9730
43cfc33e 9731 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9732 * unexec.h: New file.
ce701a33
PE
9733 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9734 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9735 Depend on unexec.h.
9736 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9737 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9738 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9739 Change as necessary to match prototype in unexec.h.
ce701a33 9740
01f44d5a
PE
9741 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9742 shadowing.
4f63c6bb 9743 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9744
a6670b0b
PE
9745 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9746 Rename locals to avoid shadowing.
9747
cef2010d 9748 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9749 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9750
d4d7173a
PE
9751 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9752
f08b802a
PE
9753 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9754 warning when compiling print.c.
9755
3ddb0639
PE
9756 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9757 instead of using an uninitialized var.
5ad03b97 9758 (font_sort_entities): Mark var as initialized.
3ddb0639 9759
170a2692
PE
9760 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9761
e663c700
PE
9762 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9763 pointers to constants.
89bc529a 9764 (font_parse_fcname): Remove unused vars.
7b81e2d0 9765 (font_delete_unmatched): Now static.
ea838e10 9766 (font_get_spec): Remove; unused.
13a547c6
PE
9767 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9768 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9769 Rename or move locals to avoid shadowing.
e663c700 9770
2a80c887 9771 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9772 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9773
1384fa33 9774 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9775 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9776
8b2c52e9
PE
9777 * alloc.c (mark_backtrace): Move decl from here ...
9778 * lisp.h: ... to here, so that it can be checked.
9779
475545b5 9780 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9781 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9782 (lisp_indirect_variable): Name an expression,
9783 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9784 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9785
b1349114 9786 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9787 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9788 Use const pointer when appropriate.
b1349114 9789
a2928364
PE
9790 * lisp.h (get_system_name, get_operating_system_release):
9791 Move decls here, to check interfaces.
9792 * process.c (get_operating_system_release): Move decl to lisp.h.
9793 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9794 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9795 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9796 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9797 (Fformat_time_string, Fencode_time, Finsert_char):
9798 (Ftranslate_region_internal, Fformat):
9799 Rename or remove local vars to avoid shadowing.
9710023e 9800 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9801
a415e694
PE
9802 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9803 avoid shadowing.
9804
8ef4622d
PE
9805 * lisp.h (eassert): Check that the argument compiles, even if
9806 ENABLE_CHECKING is not defined.
9807
946f9a5b
PE
9808 * data.c (Findirect_variable): Name an expression, to avoid
9809 gcc -Wbad-function-cast warning.
112396d6 9810 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9811 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9812 (Fmake_variable_buffer_local, Fmake_local_variable):
9813 Mark variables as initialized.
52746918 9814 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9815
e5aab7e7 9816 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9817 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9818 Rename locals to avoid shadowing.
dff45157
PE
9819 (mark_stack): Move local variables into the #ifdef region where
9820 they're used.
7bc26fdb
PE
9821 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9822 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9823 needed otherwise.
9824 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9825 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9826 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9827
e5aab7e7
PE
9828 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9829 avoids undefined behavior in theory.
9830
4da60324
PE
9831 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9832
88043301
PE
9833 Use functions, not macros, for up- and down-casing (Bug#8254).
9834 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9835 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9836 to use the following functions instead of these macros.
9837 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9838 EMACS_INT, since callers assume the returned value fits in int.
9839 (upcase1): Likewise, for UPCASE_TABLE.
9840 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9841 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9842 the race-condition problem in the old DOWNCASE.
88043301 9843
19ed5445
PE
9844 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9845 Rename locals to avoid shadowing.
9846 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9847 (regex_compile, re_search_2, re_match_2_internal):
9848 Remove unused local vars.
952db0d7
PE
9849 (FREE_VAR): Rewrite so as not to use empty "else",
9850 which gcc can warn about.
da053e48 9851 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9852 (RETALLOC_IF): Define only if needed.
9853 (WORDCHAR_P): Likewise. This one is never needed, but is used
9854 only in a comment talking about a compiler bug, so put inside
9855 the #if 0 of that comment.
9856 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9857 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9858 Remove; unused.
19ed5445 9859
1f3561e4 9860 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9861 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9862 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9863
ded6f8f7
PE
9864 * search.c (simple_search): Remove unused var.
9865
dbd37a95
PE
9866 * dired.c (compile_pattern): Move decl from here ...
9867 * lisp.h: ... to here, so that it can be checked.
9868 (struct re_registers): New forward decl.
9869
7e47afad
PE
9870 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9871
85f24f61
PE
9872 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9873 All uses changed.
9874 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9875 Rename locals to avoid shadowing.
5671df8f 9876 (Fvertical_motion): Mark locals as initialized.
85f24f61 9877
181aa2be 9878 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9879 (casify_region): Mark local as initialized.
181aa2be 9880
930d429c
PE
9881 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9882
7082eac6
PE
9883 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9884 New macros, so that the caller can use some names other than
9885 gcpro1, gcpro2, etc.
9886 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9887 of the new macros.
9888 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9889 argument, for consistency with GCPRO2_VAR, etc: it is now the
9890 prefix of the variable, not the variable itself. All uses
9891 changed.
38b2c076
PE
9892 * dired.c (directory_files_internal, file_name_completion):
9893 Rename locals to avoid shadowing.
9894
15206ed9
PE
9895 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9896 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9897 dired.c's scmp function, had undefined behavior.
9898 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9899 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9900 * buffer.h: ... to here, because these macros use current_buffer,
9901 and the new implementation with inline functions needs to have
9902 current_buffer in scope now, rather than later when the macros
9903 are used.
9904 (downcase, upcase1): New static inline functions.
9905 (DOWNCASE, UPCASE1): Reimplement using these functions.
9906 This avoids undefined behavior in expressions like
9907 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9908 from race conditions in accessing the global variables
9909 case_temp1 and case_temp2.
9910 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9911 * lisp.h (case_temp1, case_temp2): Remove their decls.
9912 * character.h (ASCII_CHAR_P): Move from here ...
9913 * lisp.h: ... to here, so that the inline functions mentioned
9914 above can use them.
9915
4a6bea26
PE
9916 * dired.c (directory_files_internal_unwind): Now static.
9917
f14b7e14
PE
9918 * fileio.c (file_name_as_directory, directory_file_name):
9919 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9920 Now static.
2893f146
PE
9921 (file_name_as_directory): Use const pointers when appropriate.
9922 (Fexpand_file_name): Likewise. In particular, newdir might
9923 point at constant storage, so make it a const pointer.
fd4ead52 9924 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9925 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9926 signedness issues.
f839df0c
PE
9927 (Fset_file_times, Finsert_file_contents, auto_save_error):
9928 Rename locals to avoid shadowing.
f14b7e14 9929
5716756e 9930 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9931 (Ftry_completion, Fall_completions): Rename or remove locals
9932 to avoid shadowing.
5716756e 9933
b4c3046a
PE
9934 * marker.c (bytepos_to_charpos): Remove; unused.
9935
b45db522
PE
9936 * lisp.h (verify_bytepos, count_markers): New decls,
9937 so that gcc does not warn that these functions aren't declared.
9938
85876d07
PE
9939 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9940 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9941 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9942 (copy_text): Remove unused local var.
85876d07 9943
03d78a21 9944 * filelock.c (within_one_second): Now static.
b3dd38ab 9945 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9946
5df8f01b
PE
9947 * buffer.c (fix_overlays_before): Mark locals as initialized.
9948 (fix_start_end_in_overlays): Likewise. This function should be
9949 simplified by using pointers-to-pointers, but that's a different
9950 matter.
b1d876f1 9951 (switch_to_buffer_1): Now static.
8f54f30a
PE
9952 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9953 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9954
a70072c9 9955 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9956 Fix pointer signedness issue.
edced198
PE
9957 (sys_subshell): Mark local as volatile if checking for lint,
9958 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9959 (MAXPATHLEN): Define only if needed.
a70072c9 9960
a0977c44
PE
9961 * process.c (serial_open, serial_configure): Move decls from here ...
9962 * systty.h: ... to here, so that they can be checked.
9963
a884fdcc
PE
9964 * fns.c (get_random, seed_random): Move extern decls from here ...
9965 * lisp.h: ... to here, so that they can be checked.
9966
604efe86 9967 * sysdep.c (reset_io): Now static.
b8950c94 9968 (wait_for_termination_signal): Remove; unused.
604efe86 9969
38fc62d9
PE
9970 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9971 (copy_keymap_item, append_key, push_text_char_description):
9972 Now static.
1004a21a 9973 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9974 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9975 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9976 (describe_map_tree):
9977 Rename locals to avoid shadowing.
38fc62d9 9978
2f2650da
PE
9979 * keyboard.c: Declare functions static if they are not used elsewhere.
9980 (echo_char, echo_dash, cmd_error, top_level_2):
9981 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9982 (read_char, kbd_buffer_get_event, make_lispy_position):
9983 (make_lispy_event, make_lispy_movement, apply_modifiers):
9984 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9985 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9986 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9987 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9988 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9989
a053e86c 9990 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9991 (mark_kboards): Move decl here ...
9992 * alloc.c (mark_kboards): ... from here.
a053e86c 9993
4752793e
PE
9994 * lisp.h (force_auto_save_soon): New decl.
9995
74f10ca7 9996 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9997 (DEFINE_DUMMY_FUNCTION): New macro.
9998 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9999 Use it.
c03cd23f
PE
10000 (main): Add casts to avoid warnings
10001 if GCC considers string literals to be constants.
74f10ca7 10002
022e70d4
PE
10003 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10004
59d6fe83
PE
10005 * dbusbind.c: Pointer signedness fixes.
10006 (xd_signature, xd_append_arg, xd_initialize):
10007 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10008 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10009 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10010 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10011
78320123
PE
10012 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10013 if GCC considers string literals to be constants.
49cebcca 10014 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 10015
35ac2a97
SM
100162011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10017
fb103ca9
SM
10018 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10019 (print_preprocess, print_object): New macro to fix last change.
10020
35ac2a97
SM
10021 * print.c (print_preprocess): Don't forget font objects.
10022
62973b41
JB
100232011-03-16 Juanma Barranquero <lekktu@gmail.com>
10024
10025 * emacs.c (USAGE3): Doc fixes.
10026
0e48bb22
AS
100272011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10028
10029 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10030 structure.
10031
7684e57b
JB
100322011-03-14 Juanma Barranquero <lekktu@gmail.com>
10033
10034 * lisp.h (VWindow_system, Qfile_name_history):
10035 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10036 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10037 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10038
10039 * w32select.c: Don't #include "keyboard.h".
c96bbc66 10040 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
10041
10042 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10043 * w32console.c (detect_input_pending, read_input_pending)
10044 (encode_terminal_code):
10045 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10046 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10047 (w32_system_caret_y, Qfile_name_history):
10048 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10049 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10050 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10051 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10052 * w32proc.c (Qlocal, report_file_error):
10053 * w32term.c (Vwindow_system, updating_frame):
10054 * w32uniscribe.c (initialized, uniscribe_font_driver):
10055 Remove unneeded extern declarations.
10056
2aa46d6c
CY
100572011-03-14 Chong Yidong <cyd@stupidchicken.com>
10058
c96bbc66 10059 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 10060
cffc6f3b
CY
100612011-03-13 Chong Yidong <cyd@stupidchicken.com>
10062
10063 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10064 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10065 These macros can no longer be used for assignment.
10066
44f230aa
SM
10067 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10068 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
10069 (record_buffer_markers, fetch_buffer_markers): New functions for
10070 recording and fetching special buffer markers.
10071 (set_buffer_internal_1, set_buffer_temp): Use them.
10072
10073 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10074
10075 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10076
10077 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10078 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10079
10080 * xdisp.c (hscroll_window_tree):
10081 (reconsider_clip_changes): Use PT instead of BUF_PT.
10082
d251f04b
EZ
100832011-03-13 Eli Zaretskii <eliz@gnu.org>
10084
10085 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10086 $(EMACS_ROOT)/lib/intprops.h.
10087
f0c77cd1
PE
100882011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10089
3eca4629
PE
10090 Fix more problems found by GCC 4.5.2's static checks.
10091
7c86ee98
PE
10092 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10093 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
10094 (xg_free_frame_widgets): Make it clear that a local variable is
10095 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
10096 (gdk_window_get_screen): Make it clear that this macro is needed
10097 only if USE_GTK_TOOLTIP.
1e5524e7
PE
10098 (int_gtk_range_get_value): New function, which avoids a diagnostic
10099 from gcc -Wbad-function-cast.
10100 (xg_set_toolkit_scroll_bar_thumb): Use it.
10101 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10102 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
10103 (get_utf8_string, xg_get_file_with_chooser):
10104 Rename locals to avoid shadowing.
10105 (create_dialog): Move locals to avoid shadowing.
7c86ee98 10106
41729b81
PE
10107 * xgselect.c (xg_select): Remove unused var.
10108
f0c77cd1
PE
10109 * image.c (four_corners_best): Mark locals as initialized.
10110 (gif_load): Initialize transparent_p to zero (Bug#8238).
10111 Mark another local as initialized.
ec6cf4c6 10112 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 10113
ce0ad53d 10114 * image.c (clear_image_cache): Now static.
d5d5a617 10115 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 10116 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
10117 (x_edge_detection): Remove unnecessary cast that
10118 gcc -Wbad-function-cast diagnoses.
2037898d 10119 (gif_load): Fix pointer signedness.
6ae141d6
PE
10120 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10121 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 10122
33383987 101232011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 10124
d32df629
PE
10125 Improve quality of tests for time stamp overflow.
10126 For example, without this patch (encode-time 0 0 0 1 1
10127 1152921504606846976) returns the obviously-bogus value (-948597
10128 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10129 reports time overflow. See
10130 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
10131 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10132 * editfns.c: Include limits.h and intprops.h.
10133 (TIME_T_MIN, TIME_T_MAX): New macros.
10134 (time_overflow): Move earlier, to before first use.
10135 (hi_time, lo_time): New functions, for an accurate test for
10136 out-of-range times.
10137 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10138 (Fget_internal_run_time): Don't assume time_t fits in int.
10139 (make_time): Use list2 instead of Fcons twice.
10140 (Fdecode_time): More accurate test for out-of-range times.
10141 (check_tm_member): New function.
10142 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
10143 (lisp_time_argument): Don't rely on undefined left-shift and
10144 right-shift behavior when checking for time stamp overflow.
8be6f318 10145
fe31d94c
PE
10146 * editfns.c (time_overflow): New function, refactoring common code.
10147 (Fformat_time_string, Fdecode_time, Fencode_time):
10148 (Fcurrent_time_string): Use it.
10149
8be6f318
PE
10150 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10151 * dired.c (make_time): Move to ...
10152 * editfns.c (make_time): ... here.
10153 * systime.h: Note the move.
10154
09d9db2c 101552011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 10156
126bc0dc
YM
10157 * fringe.c (update_window_fringes): Remove unused variables.
10158
c47cbdfd
YM
10159 * unexmacosx.c (copy_data_segment): Also copy __got section.
10160 (Bug#8223)
10161
7ac80be9
EZ
101622011-03-12 Eli Zaretskii <eliz@gnu.org>
10163
c96bbc66 10164 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
10165 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10166 Constify `char *' arguments and their references according to
10167 prototypes in tparam.h.
10168
ecb0f94d 10169 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 10170
7ac80be9
EZ
10171 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10172 Adapt all references accordingly.
10173
10174 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10175
ef1fd07e
TT
101762011-03-11 Tom Tromey <tromey@redhat.com>
10177
10178 * buffer.c (syms_of_buffer): Remove obsolete comment.
10179
7ef4b50c
EZ
101802011-03-11 Eli Zaretskii <eliz@gnu.org>
10181
10182 * termhooks.h (encode_terminal_code): Declare prototype.
10183
10184 * msdos.c (encode_terminal_code): Don't declare prototype.
10185
10186 * term.c (encode_terminal_code): Now external again, used by
10187 w32console.c and msdos.c.
10188
44f230aa
SM
10189 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10190 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 10191
4b1ec863 101922011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 10193
1714f52b 10194 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 10195
4b1ec863
PE
10196 * fringe.c (update_window_fringes): Mark locals as initialized
10197 (Bug#8227).
10198 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 10199
524c7aa6
PE
10200 * alloc.c (mark_fringe_data): Move decl from here ...
10201 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10202 to check its interface.
10203 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10204
a5c0af81 10205 * fontset.c (free_realized_fontset): Now static.
7519b8cd 10206 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 10207 (fontset_font): Mark local as initialized.
a9a06e0b 10208 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 10209
b4716021
PE
10210 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10211
811e9bac 10212 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 10213 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
10214 (x_own_selection, Fx_disown_selection_internal): Rename locals
10215 to avoid shadowing.
10216 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 10217
7e3ab302
PE
10218 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10219 so that the caller can use some name other than gcpro1.
10220 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
10221 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10222 (Fx_backspace_delete_keys_p):
10223 Use them to avoid shadowing, and rename vars to avoid shadowing.
10224 (x_decode_color, x_set_name, x_window): Now static.
6b437900 10225 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 10226 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
10227 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10228 Remove unused locals.
7e3ab302
PE
10229 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10230 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10231 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10232 macros.
f78faa98 10233
e2b13473
PE
10234 * xterm.h (x_mouse_leave): New decl.
10235
77f23912
PE
10236 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10237 Remove unused functions.
cdf4ba58
PE
10238 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10239 (x_calc_absolute_position): Now static.
7411c686 10240 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 10241 Don't declare local "event" unless it's used.
ed7bf3a5
PE
10242 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10243 unless they are used.
38d0b34a
PE
10244 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10245 (x_fatal_error_signal): Remove; not used.
a6067996
PE
10246 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10247 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10248 (x_error_catcher, x_connection_closed, x_error_handler):
10249 (x_error_quitter, xembed_send_message, x_iconify_frame):
10250 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 10251 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 10252 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 10253
44f230aa
SM
10254 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10255 Rename or move locals to avoid shadowing.
6b463e58 10256 (tty_defined_color, merge_face_heights): Now static.
5967d051 10257 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
10258 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10259 does not deduce is never used uninitialized.
73719eba
PE
10260 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10261 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 10262
426994c3 10263 * terminal.c (store_terminal_param): Now static.
5489860b 10264
032f1620 10265 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 10266 (set_frame_menubar): Remove unused local.
d4323972 10267 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
10268 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10269 since they might point to immutable storage.
281585b0
PE
10270 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10271 since it's unused otherwise.
032f1620 10272
367c19e5 10273 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 10274 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
10275 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10276 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 10277 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
10278 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10279 does not deduce are never used uninitialized.
70739cbe 10280
07b48fa9
PE
10281 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10282
8868a238 10283 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
10284 * window.c (window_loop, size_window):
10285 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 10286
7e5cf297 10287 * window.c (display_buffer): Now static.
d6550a9f
PE
10288 (size_window): Mark variables that gcc -Wuninitialized
10289 does not deduce are never used uninitialized.
a586633d
PE
10290 * window.h (check_all_windows): New decl, to forestall
10291 gcc -Wmissing-prototypes diagnostic.
5b555da1 10292 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 10293
f6095868
PE
10294 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10295 shadowing.
10296 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
10297 Include <limits.h>.
10298 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10299 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
10300 (load_charset_map): Mark variables that gcc -Wuninitialized
10301 does not deduce are never used uninitialized.
53df7c11 10302 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 10303
f38b440c
PE
10304 * coding.c (coding_set_source, coding_set_destination):
10305 Use "else { /* comment */ }" rather than "else /* comment */;"
10306 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
10307 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10308 a block, when the outer 'i' will do.
10309 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10310 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10311 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10312 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10313 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10314 Rename locals to avoid shadowing.
10315 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
10316 * coding.c (emacs_mule_char, encode_invocation_designation):
10317 Now static, since they're not used elsewhere.
413bb2db 10318 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 10319 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
10320 (decode_coding_emacs_mule): Mark variables that gcc
10321 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
10322 (detect_coding_iso_2022): Initialize a local variable that might
10323 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 10324 this initialization is needed. (Bug#8211)
5f58e762
PE
10325 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10326 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10327 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10328 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10329 Remove unused macros.
f38b440c 10330
232b38b9 10331 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 10332 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 10333 * character.c (string_count_byte8): Likewise.
232b38b9 10334
fb90da1b
PE
10335 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10336 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10337
fb93dbc2
PE
10338 * chartab.c (copy_sub_char_table): Now static, since it's not used
10339 elsewhere.
5c156ace
PE
10340 (sub_char_table_ref_and_range, char_table_ref_and_range):
10341 Rename locals to avoid shadowing.
bbcd0949 10342 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 10343
7d3b3862 10344 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 10345 (BIDI_BOB): Remove unused macro.
7d3b3862 10346
6be7d3da
PE
10347 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10348 deduce are never used uninitialized.
c2ed9c8b 10349 * term.c (encode_terminal_code): Likewise.
6be7d3da 10350
75f8807f 10351 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 10352
50938595
PE
10353 * tparam.h: New file.
10354 * term.c, tparam.h: Include it.
10355 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10356 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10357 Move these decls to tparam.h, and make them agree with what
10358 is actually in tparam.c. The previous trick of using incompatible
10359 decls in different modules does not conform to the C standard.
10360 All callers of tparam changed to use tparam's actual API.
10361 * tparam.c (tparam1, tparam, tgoto):
10362 Use const pointers where appropriate.
10363
fbceeba2
PE
10364 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10365 * cm.h (struct cm): Likewise.
10366 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10367 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10368 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10369 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10370 (turn_on_face, init_tty): Likewise.
10371 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10372
7f3f1250
PE
10373 * term.c (term_mouse_position): Rename local to avoid shadowing.
10374
e6ca6543
PE
10375 * alloc.c (mark_ttys): Move decl from here ...
10376 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10377
c40f8d15
AS
103782011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10379
10380 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10381
cfe0661d
JB
103822011-03-09 Juanma Barranquero <lekktu@gmail.com>
10383
10384 * search.c (compile_pattern_1): Remove argument regp, unused since
10385 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10386 (compile_pattern): Don't pass it.
10387
0afb4571
J
103882011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10389
10390 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10391 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10392 for ! HAVE_GTK3.
10393 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10394
10395 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10396
10397 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10398 gdk_window_get_screen, gdk_window_get_geometry,
10399 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10400 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10401 (xg_get_pixbuf_from_pixmap): New function.
10402 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10403 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10404 Call xg_get_pixbuf_from_pixmap instead of
10405 gdk_pixbuf_get_from_drawable.
10406 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10407 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10408 (xg_check_special_colors): Use GtkStyleContext and its functions
10409 for HAVE_GTK3.
10410 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10411 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10412 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10413 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10414 Call gtk_widget_get_preferred_size.
0afb4571
J
10415 (xg_frame_resized): gdk_window_get_geometry only takes 5
10416 parameters.
44f230aa
SM
10417 (xg_win_to_widget, xg_event_is_for_menubar):
10418 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10419 (xg_set_widget_bg): New function.
10420 (delete_cb): New function.
895009e1 10421 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10422 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10423 (xg_set_background_color): Call xg_set_widget_bg.
10424 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10425 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10426 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10427 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10428 if ! HAVE_GTK3.
10429 (update_frame_tool_bar): Call gtk_widget_hide.
10430 (xg_initialize): Use GDK_KEY_g.
10431
10432 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10433 if ! HAVE_GTK3
10434 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10435
10436 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10437 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10438 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10439
1c2cc4ef
JB
104402011-03-08 Juanma Barranquero <lekktu@gmail.com>
10441
10442 * w32xfns.c (select_palette): Check success of RealizePalette against
10443 GDI_ERROR, not zero.
10444
33383987 10445See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10446
10447;; Local Variables:
10448;; coding: utf-8
aac0c6e3
MR
10449;; End:
10450
2f097256 10451 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10452
10453 This file is part of GNU Emacs.
10454
10455 GNU Emacs is free software: you can redistribute it and/or modify
10456 it under the terms of the GNU General Public License as published by
10457 the Free Software Foundation, either version 3 of the License, or
10458 (at your option) any later version.
10459
10460 GNU Emacs is distributed in the hope that it will be useful,
10461 but WITHOUT ANY WARRANTY; without even the implied warranty of
10462 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10463 GNU General Public License for more details.
10464
10465 You should have received a copy of the GNU General Public License
10466 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.