Merge from gnulib (comment changes only).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
fb9ea40f
PE
12012-07-22 Paul Eggert <eggert@cs.ucla.edu>
2
3 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
4 as it's limited by the amount of memory, not by INT_MAX.
5
2d5c5f7d
EZ
62012-07-21 Eli Zaretskii <eliz@gnu.org>
7
07fb592e
EZ
8 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
9 in special-event-map. See the discussion at
10 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
11 for the reasons.
12
37a9eac8 13 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
14 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
15 Fabrice Popineau <fabrice.popineau@supelec.fr>.
16
c4328746
JD
172012-07-21 Jan Djärv <jan.h.d@swipnet.se>
18
19 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 20 (conversationIdentifier): Return value is NSInteger.
784051c4 21 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 22
6e5d1c12
CY
232012-07-21 Chong Yidong <cyd@gnu.org>
24
25 * window.c (decode_any_window): Signal an error if the window is
26 on a dead frame (Bug#11984).
27
9928463d
DA
282012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
29
30 Add indirection counting to speed up Fkill_buffer.
31 * buffer.h (struct buffer): New member.
32 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
33 (Fmake_indirect_buffer): Set indirection counter to -1, increment
34 base buffer indirection counter.
35 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
36 (Fkill_buffer): Adjust indirection counters as needed, don't walk
37 through buffer list if indirection counter is 0.
38
f8643a6b
DA
392012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
40
41 Extend the value returned by Fgarbage_collect with heap statistics.
42 * alloc.c (Qheap): New symbol.
43 (syms_of_alloc): DEFSYM it.
44 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
45 (Fmemory_free): Remove.
46 (syms_of_alloc): Don't defsubr it.
47 * buffer.c (Fcompact_buffer): Remove.
48 (syms_of_buffer): Don't defsubr it.
49
dac616ff
DA
502012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
51
52 Make maybe_gc inline.
53 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
54 * lisp.h (consing_since_gc, gc_relative_threshold)
55 (memory_full_cons_threshold): Revert declaration.
56 (maybe_gc): Remove prototype, define as inline.
57 * alloc.c: Remove old commented-out code.
58 (consing_since_gc, gc_relative_threshold)
59 (memory_full_cons_threshold): Revert to global.
60 (maybe_gc): Remove.
61
d7ea76b4
DA
622012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
63
64 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
65 * lisp.h (build_unibyte_string): New function.
66 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
67 * sysdep.c, w32fns.c, xfns.c: Use it.
68 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
69 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
70 Adjust users accordingly.
71 * font.h (font_open_by_name): Adjust prototype.
72
765e61e3
DA
732012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
74
75 Cleanup calls to Fgarbage_collect.
76 * lisp.h (maybe_gc): New prototype.
77 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
78 Remove declarations.
79 * alloc.c (maybe_gc): New function.
80 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
81 Make them static.
82 * bytecode.c (MAYBE_GC): Use maybe_gc.
83 * eval.c (eval_sub, Ffuncall): Likewise.
84 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
85 to avoid dependency from auto-save feature.
86
52b852c7
PE
872012-07-19 Paul Eggert <eggert@cs.ucla.edu>
88
89 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
90 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
91 'for_each_per_buffer_object_at'.
92 All uses changed. It's better to use upper-case for macros that
93 cannot be implemented as functions, to give the reader a clue
94 that they're special.
95
5db81e33
SM
962012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
97
98 * alloc.c (Fgarbage_collect): Tweak docstring.
99
5b835e1d
DA
1002012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
101
102 Tweak the value returned from Fgarbage_collect again.
103 * alloc.c (Fgarbage_collect): New return value, as confirmed in
104 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
105 Adjust documentation.
106 (total_vector_bytes): Rename to total_vector_slots, adjust
107 accounting.
108 (total_free_vector_bytes): Rename to total_free_vector_slots,
109 adjust accounting.
110 (Qstring_bytes, Qvector_slots): New symbols.
111 (syms_of_alloc): DEFSYM them.
112
9cd47b72
DA
1132012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
114
115 Buffer compaction primitive which may be used from Lisp.
116 * buffer.c (compact_buffer, Fcompact_buffer): New function.
117 (syms_of_buffer): Register Fcompact_buffer.
118 * alloc.c (Fgarbage_collect): Use compact_buffer.
119 * buffer.h (compact_buffer): New prototype.
120 (struct buffer_text): New member.
121
d17337e5
DA
1222012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
123
124 New macro to iterate over all buffers, miscellaneous cleanups.
125 * lisp.h (all_buffers): Remove declaration.
126 * buffer.h (all_buffers): Add declaration, with comment.
127 (for_each_buffer): New macro.
128 * alloc.c (Fgarbage_collect, mark_object): Use it.
129 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
130 (init_buffer): Likewise.
131 * data.c (Fset_default): Likewise.
132 * coding.c (code_conversion_restore): Remove redundant check
133 for dead buffer.
134 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
135
60cfd278
AS
1362012-07-18 Andreas Schwab <schwab@linux-m68k.org>
137
138 Fix bug that created negative-length intervals.
139 * intervals.c (merge_interval_right, merge_interval_left):
140 Do not zero out this interval if it is absorbed by its children,
141 as this interval's total length doesn't change in that case. See
142 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
143
d06714cb
PE
1442012-07-18 Paul Eggert <eggert@cs.ucla.edu>
145
83713154
PE
146 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
147 when invoking (make-bool-vector N t) and N is a positive
148 multiple of 8 -- the last 8 bits were mistakenly cleared.
149
d06714cb
PE
150 Remove some struct layout assumptions in bool vectors.
151 * alloc.c (bool_header_size): New constant.
152 (header_size, word_size): Move earlier, as they're now used earlier.
153 Use 'word_size' in a few more places, where it's appropriate.
154 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
155 padding before the data member of a bool vector.
156 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
157 than doing the check by hand with an abort ().
158
464d5a5e
SM
1592012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
160
5fbc0409
SM
161 * eval.c (Fdefvar): Don't check constants since we only set the var if
162 it's not yet defined anyway (bug#11904).
163
464d5a5e
SM
164 * lisp.h (last_undo_boundary): Declare new var.
165 * keyboard.c (command_loop_1): Set it.
166 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
167 were auto-added by the command loop (bug#11774).
168
8dc2e44a
AS
1692012-07-18 Andreas Schwab <schwab@linux-m68k.org>
170
171 * w32font.c (Qsymbol): Remove local definition.
172 (syms_of_w32font): Don't DEFSYM it.
173
169925ec
DA
1742012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
175
176 Fix sweep_vectors to handle large bool vectors correctly.
177 * alloc.c (sweep_vectors): Account total_vector_bytes for
178 bool vectors larger than VBLOCK_BYTES_MAX.
179
5fbfb018
CY
1802012-07-18 Chong Yidong <cyd@gnu.org>
181
182 * frame.c (x_set_frame_parameters): Revert bogus change introduced
183 in 2012-05-25 commit by Paul Eggert (Bug#11738).
184
3ab6e069
DA
1852012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
186
187 Return more descriptive data from Fgarbage_collect.
188 Suggested by Stefan Monnier in
189 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
190 * alloc.c (bounded_number): New function.
191 (total_buffers, total_vectors): New variable.
192 (total_string_size): Rename to total_string_bytes, adjust users.
193 (total_vector_size): Rename to total_vector_bytes, adjust users.
194 (sweep_vectors): Account total_vectors and total_vector_bytes.
195 (Fgarbage_collect): New return value. Adjust documentation.
196 (gc_sweep): Account total_buffers.
197 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
198 (VECTOR_SIZE): Remove.
199 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
200 (Qinterval, Qmisc): New symbols.
201 (syms_of_data): Initialize them.
202 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
203 (Qcons, Qbuffer): New declarations.
204
6d02fe5b
PE
2052012-07-17 Paul Eggert <eggert@cs.ucla.edu>
206
207 * alloc.c (Fmemory_free): Account for memory-free's own storage.
208 Round up, not down. Improve doc.
209
b7ffe040
DA
2102012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
211
212 Restore old code in allocate_string_data to avoid Faset breakage.
213 Reported by Julien Danjou <julien@danjou.info> in
214 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
215 * alloc.c (allocate_string_data): Restore old code with minor
216 adjustments, fix comment to explain this subtle issue.
217
4dc7c8d5
SM
2182012-07-17 Eli Zaretskii <eliz@gnu.org>
219
220 Remove FILE_SYSTEM_CASE.
221 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
222
223 * fileio.c (FILE_SYSTEM_CASE): Don't define.
224 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
225 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
226 call-process-region passes it through expand-file-name.
227
228 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
229
2302012-07-17 Andreas Schwab <schwab@linux-m68k.org>
231
232 Fix crash when creating indirect buffer (Bug#11917)
233 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
234 Don't handle unbound variables specially if non-zero.
235 (Fbuffer_local_variables): Pass zero.
236 (clone_per_buffer_values): Pass non-zero.
237
2382012-07-17 Andreas Schwab <schwab@linux-m68k.org>
239
240 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
241 to make the loop interruptible.
242
2432012-07-17 Andreas Schwab <schwab@linux-m68k.org>
244
245 * gnutls.c (emacs_gnutls_handshake): Only retry if
246 GNUTLS_E_INTERRUPTED.
247
cce7fefc
DA
2482012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
249
250 Cleanup and convert miscellaneous checks to eassert.
251 * alloc.c (mark_interval): Fix comment, partially rephrase
252 old comment from intervals.h (see below).
253 * intervals.c (find_interval, adjust_intervals_for_insertion)
254 (delete_interval, adjust_intervals_for_deletion)
255 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
256 Convert to eassert.
257 (adjust_intervals_for_insertion, make_new_interval):
258 Remove obsolete and unused code.
259 * intervals.h (struct interval): Remove obsolete comment.
260 * textprotp.c (erase_properties): Remove unused code.
261 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
262 (Fremove_list_of_text_properties): Convert to eassert.
263
9ea10cc3
CY
2642012-07-17 Chong Yidong <cyd@gnu.org>
265
266 * editfns.c (Finsert_char): Doc fix.
267
3900d5de
DA
2682012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
269
270 Fix previous change to make Fmemory_free always accurate.
271 * alloc.c (make_interval): Update total_free_intervals.
272 (make_float): Likewise for total_free_floats.
273 (free_cons, Fcons): Likewise for total_free_conses.
274 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
275 Likewise for total_free_vector_bytes.
276 (Fmake_symbol): Likewise for total_free_symbols.
277 (bytes_free): Remove.
278
7098646f
DA
2792012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
280
281 Simple free memory accounting feature.
282 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
283 (sweep_vectors): Accumulate size of free vectors.
284 (Fgarbage_collect): Setup bytes_free.
285 (Fmemory_free): New function.
286 (syms_of_alloc): Register it.
287
22657b40
DA
2882012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
289
290 Cleanup overlays checking.
291 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
292 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
293 eassert and OVERLAYP.
294 (sort_overlays): Change to use OVERLAYP.
295
ddfc8813
RK
2962012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
297
298 * editfns.c (Finsert_char): Make it interactive, and make the
299 second arg optional. Copy interactive spec and docstring from
300 ucs-insert.
301
7c26cf3c
PE
3022012-07-17 Paul Eggert <eggert@cs.ucla.edu>
303
304 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
305 Unlike the other wrapped functions, fabs has an unspecified
306 effect on errno.
307
5d127af9
JD
3082012-07-16 Jan Djärv <jan.h.d@swipnet.se>
309
310 * nsterm.m (keyDown): Interpret flags without left/right bits
311 as the left key (Bug#11670).
312
6a0dd1d7
DA
3132012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
314
315 Remove empty and useless init functions.
316 * lisp.h (init_character_once, init_fns, init_image)
317 (init_filelock, init_sound): Remove prototype.
318 * character.c (init_character_once): Remove.
319 * filelock.c (init_filelock): Likewise.
320 * fns.c (init_fns): Likewise.
321 * image.c (init_image): Likewise.
322 * sound.c (init_sound): Likewise.
323 * emacs.c (main): Adjust accordingly.
324
7a6136fd
DA
3252012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
326
327 * gtkutil.h: Tiny cleanups.
328 (use_old_gtk_file_dialog): Remove useless declaration.
329 (xg_uses_old_file_dialog): Add suggested const attribute.
330
ce811ad9
EZ
3312012-07-15 Eli Zaretskii <eliz@gnu.org>
332
333 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
334 (bidi_paragraph_init): Use it to limit search forward for a strong
335 directional character in abnormally large paragraphs full of
336 neutral or weak characters. (Bug#11943)
337
c9adfeaa
SF
3382012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
339
340 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
341 the toolbar (Bug#9451).
342 (xg_make_tool_item): Give the widget event box a transparent
343 background.
344
fff62aa9
DA
3452012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
346
347 Cleanup basic allocation variables and functions.
348 * alloc.c (ignore_warnings, init_intervals, init_float)
349 (init_cons, init_symbol, init_marker): Remove.
350 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
351 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
352 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
353 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
354 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
355 (staticidx, init_alloc_once, init_strings, free_ablock):
356 Remove redundant initialization.
357 * fns.c (init_weak_hash_tables): Remove.
358 * lisp.h (init_weak_hash_tables): Remove prototype.
359
9730daca
DA
3602012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
361
362 Use zero_vector where appropriate.
363 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
364 accordingly.
365 * lisp.h (zero_vector): New declaration.
366 * font.c (null_vector): Remove.
367 (syms_of_font): Remove initialization and staticpro.
368 (font_list_entities, font_find_for_lface): Change to use zero_vector.
369 * keymap.c (Faccessible_keymaps): Likewise.
370
2e2d2a13
LL
3712012-07-15 Leo Liu <sdl.web@gmail.com>
372
373 * fringe.c: Fix typo in comments.
374
cd276f6e
LL
3752012-07-14 Leo Liu <sdl.web@gmail.com>
376
377 * fringe.c: Add a new bitmap exclamation-mark.
378
5a1131d9
EZ
3792012-07-14 Eli Zaretskii <eliz@gnu.org>
380
381 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
382
383 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
384 (HAVE_MENUS): Don't define, defined by editing config.in with
385 msdos/sed2v2.inp.
386 (GMALLOC_INHIBIT_VALLOC): Don't define.
387 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
388
22e983b7
JB
3892012-07-14 Juanma Barranquero <lekktu@gmail.com>
390
391 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
392
5b3f250f
GM
3932012-07-14 Glenn Morris <rgm@gnu.org>
394
395 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
396 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
397 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
398
33d63ff4
GM
3992012-07-13 Glenn Morris <rgm@gnu.org>
400
5b633342
GM
401 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
402
33d63ff4
GM
403 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
404 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
405
b55b9f85
JD
4062012-07-13 Jan Djärv <jan.h.d@swipnet.se>
407
0dc8cf50
JD
408 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
409 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
410 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
411 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
412 where appropriate.
413 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
414 as boolean expression.
415 (x_set_window_size): Remove unused variable toolbar.
416 (ns_get_color_default, ns_mod_to_lisp): Remove.
417 (ns_mouse_position): Remove unused variables xchar and ychar.
418 (ns_compute_glyph_string_overhangs): Remove unused variable face.
419 (ns_set_vertical_scroll_bar): Remove unused variable count.
420 (ns_delete_terminal): Remove unused variable i.
421 (ns_term_init): Remove unused variables r, g and b.
422 (mouseDown): Remove unused variable window.
423 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
424 (initFrameFromEmacs): Remove unused variable vbextra.
425 (mouseEntered): Remove unused variables p and dpyinfo.
426 (mouseExited): Remove unused variables p and r.
427 (ns_define_frame_cursor, ns_clear_frame_area)
428 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
429 (menuDown): Assign [sender tag] to variable and cast the variable.
430
431 * nsterm.h (menuDown): Add id as type to argument sender.
432 (ns_display_info_for_name): Add Lisp_Object argument.
433 (ns_term_init): Add Lisp_Object argument.
434 (ns_map_event_to_object): Add void argument.
435 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
436 prototype with arguments and only declare if __OBJC__.
437 (nxatoms_of_nsselect): Add void argument.
438 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
439 (ns_alloc_autorelease_pool): Add void argument.
440 (ns_release_autorelease_pool): Add void* argument.
441 (ns_get_defaults_value): Add const char* argument.
442
443 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
444 (initFromContents): Use SSDATA where appropriate.
445 (ns_update_menubar): Add braces to ambigous if-else.
446 (initWithTitle): Put () around assignment in if statement.
447 (ns_menu_show): Remove unused variables window and keymap.
448 (update_frame_tool_bar): Remove unused variable selected_p.
449 (initWithContentRect): Remove unused variable this_cmd_name.
450
451 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
452 appropriate.
453 (setXBMColor): Remove unused variable len.
454 (setPixmapData): Put () around assignment in loop statement.
455
456 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
457 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
458 where appropriate.
459 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
460 around assignment in loop statement.
461 (nsfont_open): Remove unused variable i.
462 (nsfont_open): Remove unused variable len.
463 (nsfont_draw): Remove unused variable cs.
464
465 * nsfns.m (x_set_icon_name, ns_set_name_internal)
466 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
467 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
468 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
469 (Fns_font_name, Fns_perform_service)
470 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
471 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
472 (ns_set_name): Remove unused variable view.
473 (x_set_menu_bar_lines): Remove unused variable olines.
474 (x_set_tool_bar_lines): Remove unused variable root_window.
475 (Fns_list_colors): Put () around assignment in while statement.
476 (Fns_perform_service): Remove unused variable len.
477 (Fns_display_usable_bounds): Remove unused variable top.
478 (syms_of_nsfns): Remove unused variable i.
479
b55b9f85
JD
480 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
481 memcpy (Bug#11907).
482
ed9265fc 4832012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
484
485 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
486 and free it with DestroyExceptionInfo (Bug#11558).
487
ef099b57
JB
4882012-07-13 Juanma Barranquero <lekktu@gmail.com>
489
490 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
491 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
492 Set here, not in nt/config.nt.
493
ea814a5d
EZ
4942012-07-13 Eli Zaretskii <eliz@gnu.org>
495
496 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
497 cursor overflow into the last glyph on display line when the right
498 fringe is off. (Bug#11832)
499
1a952767
PE
5002012-07-13 Paul Eggert <eggert@cs.ucla.edu>
501
502 * xdisp.c (produce_special_glyphs): Now static.
503 * dispextern.h (produce_special_glyphs): Remove decl.
504
983188fd
GM
5052012-07-13 Glenn Morris <rgm@gnu.org>
506
32fb4bb6
GM
507 * s/bsd-common, s/cygwin.h: Remove empty files.
508 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
509
983188fd
GM
510 * s/usg5-4-common.h (USG, USG5):
511 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
512 * s/sol2-6.h (SOLARIS2):
513 * s/irix6-5.h (IRIX6_5):
514 * s/hpux10-20.h (USG, USG5, HPUX):
515 * s/gnu-linux.h (USG, GNU_LINUX):
516 * s/freebsd.h (BSD_SYSTEM):
517 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
518 * s/cygwin.h (CYGWIN):
519 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
520 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
521
d1e68667 5222012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
523
524 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 525
6de0e799
GM
5262012-07-13 Glenn Morris <rgm@gnu.org>
527
739ae010
GM
528 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
529
dbee5793
GM
530 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
531
6de0e799
GM
532 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
533 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
534
b82da769
GM
5352012-07-12 Glenn Morris <rgm@gnu.org>
536
4fae5a7a 537 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
538
539 * process.c (init_process_emacs): Rename from init_process.
540 The old name is also the name of a Mach system call.
541 * lisp.h, emacs.c: Update for this name change.
542 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
543 longer needed.
544
5a979817
EZ
5452012-07-12 Eli Zaretskii <eliz@gnu.org>
546
547 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
548 memmove call that removes glyphs covered by the left truncation
549 glyph. Improve commentary.
550 (display_line): Fix display of continuation glyphs on GUI frames
551 when the right fringe is turned off and variable-size fonts are
552 used in the window. Move the code that appends a stretch glyph to
553 produce_special_glyphs, so that it could be used for truncation
554 and continuation glyphs alike.
555 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
556 glyph of a suitably computed width, to align the special glyphs at
557 the window margin. Code moved from display_line. (Bug#11832)
558
3e91a053
GM
5592012-07-12 Glenn Morris <rgm@gnu.org>
560
ba9e4b84
GM
561 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
562
563 * s/gnu-linux.h, s/hpux10-20.h:
564 Do not unconditionally define HAVE_XRMSETDATABASE.
565
3e91a053
GM
566 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
567
b300b1f4
PE
5682012-07-12 Paul Eggert <eggert@cs.ucla.edu>
569
570 Fix typos that broke OS X build.
571 Reported by Randal L. Schwartz in
572 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
573 * nsterm.m (ns_timeout): Add missing local decl.
574 (ns_get_color): snprintf -> sprintf, to fix typo.
575
6e777848
GM
5762012-07-12 Glenn Morris <rgm@gnu.org>
577
3f922c37
GM
578 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
579 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
580 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
581 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
582
0ab7b23a
GM
583 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
584 Move PTY_OPEN to configure.
585
6e777848
GM
586 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
587 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
588 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
589
4a7edc24
DA
5902012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
591
592 Use empty_unibyte_string where applicable.
593 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
594 * lread.c (read1): Likewise.
595 * xsettings.c (syms_of_xsettings): Likewise.
596
308aab79
GM
5972012-07-12 Glenn Morris <rgm@gnu.org>
598
42bd1719
GM
599 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
600 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
601 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
602 * s/hpux10-20.h (RUN_TIME_REMAP):
603 * s/bsd-common.h (TABDLY): Move to configure.
604
605 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
606
607 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
608
ea0bbd17 609 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 610 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
611
612 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 613
308aab79
GM
614 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
615 * s/template.h: Move NARROWPROTO to configure.
616
ee1cf5cf
GM
6172012-07-11 Glenn Morris <rgm@gnu.org>
618
30fe9bf4
GM
619 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
620 unused since 2011-01-17 change to systty.h.
621
ee1cf5cf
GM
622 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
623 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
624 Move HAVE_PTYS and HAVE_SOCKETS to configure.
625
63e47e07
PE
6262012-07-11 Paul Eggert <eggert@cs.ucla.edu>
627
628 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
629
c43fb4c3
GM
6302012-07-11 Glenn Morris <rgm@gnu.org>
631
632 * s/darwin.h, s/gnu-linux.h, s/template.h:
633 Move INTERRUPT_INPUT to configure.
634
e8df9267
DA
6352012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
636
637 Minor adjustments to interning code.
638 * lisp.h (intern, intern_c_string): Redefine as static inline
639 wrappers for intern_1 and intern_c_string_1, respectively.
640 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
641 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
642 Vobarray checking.
e8df9267
DA
643 * font.c (font_intern_prop): Likewise. Adjust comment.
644 * w32font.c (intern_font_name): Likewise.
645
34348bd4
AS
6462012-07-11 Andreas Schwab <schwab@linux-m68k.org>
647
d96a1e0c
AS
648 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
649
34348bd4
AS
650 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
651 of Fcar/Fcdr if possible.
652 * font.c (check_otf_features): Likewise.
653 * fontset.c (Fnew_fontset): Likewise.
654 * gnutls.c (Fgnutls_boot): Likewise.
655 * minibuf.c (read_minibuf): Likewise.
656 * msdos.c (IT_set_frame_parameters): Likewise.
657 * xmenu.c (Fx_popup_dialog): Likewise.
658 * w32menu.c (Fx_popup_dialog): Likewise.
659
c8add24e
GM
6602012-07-11 Glenn Morris <rgm@gnu.org>
661
4b575b3c
GM
662 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
663 since nothing has defined it on these platforms.
664
09f4e3b0
GM
665 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
666 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
667
172bedef
GM
668 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
669 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
670 Move CLASH_DETECTION to configure.
671
249685df
GM
672 * s/gnu.h: Remove file, which is now empty.
673
c8add24e
GM
674 * s/gnu.h, s/gnu-linux.h:
675 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
676
b41253a3
JW
6772012-07-11 John Wiegley <johnw@newartisans.com>
678
679 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
680 function attribute, so we only use it if it exists in the
681 compiler.
682
d923b542
DA
6832012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
684
685 Avoid call to strlen in fast_c_string_match_ignore_case.
686 * search.c (fast_c_string_match_ignore_case): Change to use
687 length argument. Adjust users accordingly.
688 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
689
5ebbef1d
PE
6902012-07-11 Paul Eggert <eggert@cs.ucla.edu>
691
bb352260
PE
692 Assume mkdir, rmdir.
693 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
694 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
695
57054ddd
PE
696 Assume rename.
697 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
698
b747d3f7
PE
699 Assume perror.
700 * s/hpux10-20.h (HAVE_PERROR): Remove.
701 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
702 Remove dummy definition, as this problem was obsolete long ago.
703
5ebbef1d
PE
704 Assume strerror.
705 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
706
984e7f30
DA
7072012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
708
709 Avoid calls to strlen in font processing functions.
710 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 711 (font_open_by_name): Change to use length argument. Adjust
984e7f30 712 users accordingly.
d923b542
DA
713 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
714 Adjust prototypes.
715 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
716 Change to return ptrdiff_t.
984e7f30
DA
717 (xfont_list_pattern, xfont_match): Use length returned by
718 xfont_decode_coding_xlfd.
719 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
720
20e94fdd
GM
7212012-07-11 Glenn Morris <rgm@gnu.org>
722
9d596af3
GM
723 * s/darwin.h, s/freebsd.h, s/netbsd.h:
724 Move DONT_REOPEN_PTY to configure.
725
20e94fdd
GM
726 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
727 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
728
e99a530f
PE
7292012-07-10 Paul Eggert <eggert@cs.ucla.edu>
730
22ffb973
PE
731 Remove "#define unix" that is no longer needed (Bug#11905).
732 * s/aix4-2.h (unix): Remove; no longer needed.
733
e9a9ae03
PE
734 EMACS_TIME simplification (Bug#11875).
735 This replaces macros (which typically do not work in GDB)
736 with functions, typedefs and enums, making the code easier to debug.
737 The functional style also makes code easier to read and maintain.
738 * systime.h: Include <sys/time.h> on all hosts, not just if
739 WINDOWSNT, since 'struct timeval' is needed in general.
740 (EMACS_TIME): Now a typedef, not a macro.
741 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
742 not macros.
743 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
744 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
745 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
746 (EMACS_TIME_LE): Now functions, not macros.
747 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
748 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
749 which are not functions. All uses rewritten to use:
750 (make_emacs_time): New function.
751 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
752 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
753 not functions. All uses rewritten to use the following, respectively:
754 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
755 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 756 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
757 * fileio.c (Fcopy_file):
758 * xterm.c (XTflash): Get the current time closer to when it's used.
759 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
760
ffacb126
PE
761 * bytecode.c (targets): Suppress -Woverride-init warnings.
762
e99a530f
PE
763 Simplify by avoiding confusing use of strncpy etc.
764 * doc.c (Fsnarf_documentation):
765 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
766 * frame.c (Fmake_terminal_frame):
767 * gtkutil.c (get_utf8_string):
768 * lread.c (openp):
769 * nsmenu.m (ns_update_menubar):
770 * regex.c (regerror):
771 Prefer memcpy to strncpy and strncat when either will do.
772 * fileio.c (Fsubstitute_in_file_name):
773 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
774 (menu_separator_name_p):
775 * nsmenu.m (ns_update_menubar):
776 Prefer memcmp to strncmp when either will do.
777 * nsterm.m: Include <ftoastr.h>.
778 (ns_get_color):
779 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
780 Prefer snprintf to strncpy.
781 * nsterm.m (ns_term_init):
782 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
783 * nsterm.m (ns_term_init):
784 Avoid the need for strncpy, by using build_string or
785 make_unibyte_string directly. Use dtoastr, not snprintf.
786 * process.c (Fmake_network_process): Diagnose service names that
787 are too long, rather than silently truncating them or creating
788 non-null-terminated names.
789 (Fnetwork_interface_info): Likewise, for interface names.
790 * sysdep.c (system_process_attributes) [GNU_LINUX]:
791 Prefer sprintf to strncat.
792 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
793 Prefer vsnprintf to vsprintf + strncpy.
794
c59592b3
GM
7952012-07-10 Glenn Morris <rgm@gnu.org>
796
797 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
798 Clarify fallback case.
799
7d7bbefd
DA
8002012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
801
802 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
803 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
804 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 805 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
806 where argument type is known to be a Lisp_Cons.
807
3a4c8000
TT
8082012-07-10 Tom Tromey <tromey@redhat.com>
809
810 * bytecode.c (BYTE_CODE_THREADED): New macro.
811 (BYTE_CODES): New macro. Replaces all old byte-code defines.
812 (enum byte_code_op): New type.
813 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
814 (exec_byte_code): Use them. Use token threading when applicable.
815
2a0213a6
DA
8162012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
817
818 Optimize pure C strings initialization.
819 * lisp.h (make_pure_string): Fix prototype.
820 (build_pure_c_string): New function, defined as static inline. This
821 provides a better opportunity to optimize away calls to strlen when
822 the function is called with compile-time constant argument.
823 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
824 argument, adjust users accordingly. Use build_pure_c_string where
825 appropriate.
826 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
827 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
828 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
829
cb1caeaf
DA
8302012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
831
832 Avoid calls to strlen in miscellaneous functions.
833 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
834 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
835 * lread.c (openp): Likewise.
836
c293e30c
DA
8372012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
838
839 Avoid calls to strlen in path processing functions.
840 * fileio.c (file_name_as_directory): Add comment. Change to add
841 srclen argument and return the length of result. Adjust users
842 accordingly.
843 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 844 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
845 users accordingly.
846 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
847
9e059e3f
GM
8482012-07-10 Glenn Morris <rgm@gnu.org>
849
d02eb359
GM
850 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
851 Move PENDING_OUTPUT_COUNT definition to configure.
852
882cf227
GM
853 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
854 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
855 * s/gnu.h (DATA_START): Move definitions to configure.
856
af6e839f
GM
857 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
858 We include usg5-4-common.h, which defines them both.
859
40289a12
GM
860 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
861 O_RDONLY already includes it).
862
9e059e3f
GM
863 Stop ns builds setting the EMACSLOADPATH environment variable.
864 * nsterm.m (ns_load_path): Rename from ns_init_paths.
865 Now it does not set EMACSLOADPATH, just returns the load-path string.
866 * nsterm.h: Update accordingly.
867 * lread.c [HAVE_NS]: Include nsterm.h.
868 (init_lread) [HAVE_NS]: Use ns_load_path.
869 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
870
7c4e8ec0
GM
8712012-07-09 Glenn Morris <rgm@gnu.org>
872
d4f600ff
GM
873 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
874 since the included bsd-common.h does so.
875
cbb31951
GM
876 Stop ns builds setting the EMACSPATH environment variable.
877 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
878 (ns_init_paths): Do not set EMACSPATH.
879 * nsterm.h (ns_exec_path): Add it.
880 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
881 Use ns_exec_path.
882
7c4e8ec0
GM
883 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
884
26bccfae
PE
8852012-07-09 Paul Eggert <eggert@cs.ucla.edu>
886
a0bee46f
PE
887 * process.c (wait_reading_process_output): 'waitchannels' was unset
888 when read_kbd || !NILP (wait_for_cell); fix this.
889
5994c183
PE
890 Add GCC-style 'const' attribute to functions that can use it.
891 * character.h (char_resolve_modifier_mask):
892 * keyboard.h (make_ctrl_char):
893 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
894 (init_character_once, next_almost_prime, init_fns, init_image)
895 (flush_pending_output, init_sound):
896 * mem-limits.h (start_of_data):
897 * menu.h (finish_menu_items):
898 Add ATTRIBUTE_CONST.
899 * emacs.c (DEFINE_DUMMY_FUNCTION):
900 Declare the dummy function with ATTRIBUTE_CONST.
901 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
902 Add decls with ATTRIBUTE_CONST.
903
26bccfae
PE
904 Minor improvements to make_formatted_string.
905 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
906 where int is good enough, as vsprintf returns an int.
907 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
908
a8290ec3
DA
9092012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
910
911 Use make_formatted_string to avoid double length calculation.
912 * lisp.h (make_formatted_string): New prototype.
913 * alloc.c (make_formatted_string): New function.
914 * buffer.c (Fgenerate_new_buffer_name): Use it.
915 * dbus.c (syms_of_dbusbind): Likewise.
916 * editfns.c (Fcurrent_time_zone): Likewise.
917 * filelock.c (get_boot_time): Likewise.
918 * frame.c (make_terminal_frame, set_term_frame_name)
919 (x_report_frame_params): Likewise.
920 * image.c (gs_load): Likewise.
921 * minibuf.c (get_minibuffer): Likewise.
922 * msdos.c (dos_set_window_size): Likewise.
923 * process.c (make_process): Likewise.
924 * xdisp.c (ensure_echo_area_buffers): Likewise.
925 * xsettings.c (apply_xft_settings): Likewise.
926
d01ba2f1
GM
9272012-07-09 Glenn Morris <rgm@gnu.org>
928
929 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
930 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
931 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
932 * nsterm.h (ns_etc_directory): Add it.
933 * callproc.c [HAVE_NS]: Include nsterm.h.
934 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
935
f1f924b6
DA
9362012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
937
938 Move marker debugging code under MARKER_DEBUG.
939 * marker.c (MARKER_DEBUG): Move marker debugging code under
940 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
941 for bootstrap with --enable-checking (~3x slowdown reported
942 by Juanma Barranquero <lekktu@gmail.com>).
943 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
944
ab531b66
PE
9452012-07-08 Paul Eggert <eggert@cs.ucla.edu>
946
947 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
948 See <http://bugs.gnu.org/11825#29>.
949
c4b3bc8a
EZ
9502012-07-08 Eli Zaretskii <eliz@gnu.org>
951
952 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
953 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
954 (display_line): Add commentary about displaying truncation glyphs
955 on GUI frames.
956 (produce_special_glyphs): Move here from term.c.
957
958 * term.c (produce_special_glyphs): Move to xdisp.c.
959
960 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
961 section.
c4b3bc8a 962
b676b881
AS
9632012-07-07 Andreas Schwab <schwab@linux-m68k.org>
964
f17c5273
AS
965 * xdisp.c (display_line): Avoid warning about implicit declaration
966 of FRAME_FONT.
967
298819b9
AS
968 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
969
b676b881
AS
970 * lisp.h: Remove empty conditional.
971
6045c4fd
PE
9722012-07-07 Paul Eggert <eggert@cs.ucla.edu>
973
b3350bf9
PE
974 * lread.c (load_path_check): Now static.
975
6045c4fd
PE
976 Fix some minor --with-ns problems found by static checking.
977 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
978 (x_set_font) [!HAVE_X_WINDOWS]:
979 * image.c (xpm_load_image) [HAVE_NS]:
980 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
981 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
982 Remove unused local.
983 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
984 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
985 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
986 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
987 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
988 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
989 Fix pointer signedness problem.
990 * xfaces.c (FRAME_X_FONT_TABLE):
991 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
992
929e7845
GM
9932012-07-07 Glenn Morris <rgm@gnu.org>
994
995 * lread.c (load_path_check): New function, split from init_lread.
996 (init_lread): Reorganize. Motivation:
997 If EMACSLOADPATH is set, check/warn about that rather than the
998 defaults, which we are not going to use. Hence we can remove
999 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1000 Don't warn if site-lisp directories are missing.
1001 If not installed, start from a blank load-path, since
1002 PATH_LOADSEARCH refers to the eventual installation directories.
1003
58dd0aa4
EZ
10042012-07-07 Eli Zaretskii <eliz@gnu.org>
1005
1006 Support truncation and continuation glyphs on GUI frames, when
1007 fringes are disabled. (Bug#11832)
1008 * xdisp.c (init_iterator): Get dimensions of truncation and
1009 continuation glyphs even if on GUI frames. Adjust
1010 it->last_visible_x on GUI frames when the left or right fringes,
1011 or both, are absent.
1012 (start_display, move_it_in_display_line_to): Handle the case of a
1013 GUI frame without a fringe to display continuation or truncation
1014 glyphs.
1015 (insert_left_trunc_glyphs): Support GUI frames: make sure
1016 truncation glyphs overwrite enough glyphs from the current line to
1017 have sufficient space in pixels.
1018 (display_line): Support truncation and continuation glyphs on GUI
1019 frames. If some spare pixels are left on the line after inserting
1020 the truncation glyphs, fill that space with a stretch glyph of a
1021 suitably computed width.
1022
1023 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1024 produce_glyphs, to support GUI sessions.
1025
31571fd7
PE
10262012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1027
5a16b9bc
PE
1028 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1029
f3047c75
PE
1030 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1031
31571fd7
PE
1032 Do not require float-time's arg to fit in time_t (Bug#11825).
1033 This works better on hosts where time_t is unsigned, and where
1034 float-time is applied to the (negative) difference between two times.
1035 * editfns.c (decode_time_components): Last arg is now double *,
1036 not int *, and means to store all the result as a double, without
1037 worrying about whether the seconds part fits in time_t.
1038 All callers changed.
1039 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1040 All callers changed.
1041 (Ffloat_time): Do not fail merely because the specified time falls
1042 outside of time_t range.
1043
4516fbef
GM
10442012-07-07 Glenn Morris <rgm@gnu.org>
1045
1046 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1047 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1048 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1049
07adc2c6
JB
10502012-07-07 Juanma Barranquero <lekktu@gmail.com>
1051
1052 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1053 Update dependencies.
1054
1055 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1056
fd573f31
PE
10572012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1058
fee5959d
PE
1059 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1060 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1061 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1062 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1063 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1064 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1065
fd573f31
PE
1066 * xfont.c (compare_font_names): Redo to omit the need for casts.
1067
ddadbc0e
AS
10682012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1069
fca8d6b6
AS
1070 * xfns.c (Fx_change_window_property): Doc fix.
1071 * w32fns.c (Fx_change_window_property): Doc fix.
1072
ddadbc0e
AS
1073 * w32fns.c (Fx_window_property): Accept the same arguments as the
1074 X Windows version. Doc fix.
1075 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1076
ed9265fc 10772012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1078 Eli Zaretskii <eliz@gnu.org>
1079
1080 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1081 Windows-specific code from nt/config.nt moved here.
1082 Obsolete settings removed.
1083
216ee680
PE
10842012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1085
1086 * process.c: Avoid unnecessary calls to gettime.
1087 (wait_reading_process_output): Don't get the time of day
1088 when gobbling data immediately and not waiting, as there's no need
1089 for it in that case. This removes a FIXME.
1090
bdd091e4
JD
10912012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1092
1093 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1094 is defined (Bug#11768).
1095
9d44f8ce
DA
10962012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1097
1098 Fix marker debugging code.
1099 * marker.c (byte_char_debug_check): Do not perform the check
1100 if buffer is not multibyte.
090bd7cb
JB
1101 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1102 Call byte_char_debug_check with correct arguments.
9d44f8ce 1103
90fc4786
DA
11042012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1105
1106 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1107 * marker.c (byte_char_debug_check, count_markers):
1108 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1109 (byte_debug_flag): Remove.
1110 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1111 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1112
7b7ae965
DA
11132012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1114
4e57b342
DA
1115 Avoid code repetition in marker-related functions.
1116 * marker.c (attach_marker): New function.
1117 (Fset_marker, set_marker_restricted, set_marker_both)
1118 (set_marker_restricted_both): Use it.
1119 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1120 Consistently rename charno to charpos.
1121 (marker_position): Add eassert.
1122 (marker_byte_position): Convert to eassert.
1123
11242012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1125
1126 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1127 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1128 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1129
657924ff
DA
11302012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1131
1132 Introduce fast path for the widely used marker operation.
1133 * alloc.c (build_marker): New function.
1134 * lisp.h (build_marker): New prototype.
1135 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1136 * composite.c (autocmp_chars): Likewise.
1137 * editfns.c (buildmark): Remove.
1138 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1139 (save_restriction_save): Use build_marker.
1140 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1141 * window.c (save_window_save): Likewise.
1142
041a49a6
DA
11432012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1144
1145 Do not use Fdelete_overlay in delete_all_overlays
1146 to avoid redundant calls to unchain_overlay.
1147 * buffer.c (drop_overlay): New function.
1148 (delete_all_overlays, Fdelete_overlay): Use it.
1149 * minibuf.c (get_minibuffer): Fix comment.
1150
7dca65a4
PE
11512012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1152
1153 Port to OpenBSD 5.1 amd64.
1154 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1155 This is needed for OpenBSD, and should be harmless on all BSD systems.
1156 Also, include <sys/sysctl.h>, as it should be available on all
1157 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1158 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1159 use p_pid member, not kp_proc.pid.
1160
8eb876e2
GM
11612012-07-06 Glenn Morris <rgm@gnu.org>
1162
1163 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1164
38182d90
PE
11652012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1166
1167 More xmalloc and related cleanup.
1168 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1169 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1170 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1171 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1172 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1173 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1174 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1175 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1176 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1177 * xterm.c:
1178 Omit needless casts involving void * pointers and allocation.
1179 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1180 as the former is more robust if P's type is changed.
1181 Prefer xzalloc to xmalloc + memset 0.
1182 Simplify malloc-or-realloc to realloc.
1183 Don't worry about xmalloc returning a null pointer.
1184 Prefer xstrdup to xmalloc + strcpy.
1185 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1186 growing it.
1187 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1188 alloca of a constant.
1189
6dd5a677
EZ
11902012-07-05 Eli Zaretskii <eliz@gnu.org>
1191
1192 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1193 hscroll is larger than the line width. Fixes long and futile
1194 looping inside extend_face_to_end_of_line (on a TTY) producing
1195 glyphs that are not needed and thrown away.
1196
6b312f0f
DA
11972012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1198
1199 * marker.c (set_marker_restricted_both): Simplify by using
1200 clip_to_bounds.
1201
f520ef9b
PE
12022012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1205
383b7c95
JD
12062012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1207
1208 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1209 not defined (Bug#11768).
1210 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1211 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1212 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1213 followed by gtk_box_set_homogeneous (Bug#11768).
1214 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1215 (update_theme_scrollbar_width, xg_create_scroll_bar):
1216 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1217 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1218 (is_box_type): New function (Bug#11768).
1219 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1220 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1221 with default display (Bug#11768).
1222
d6e7bf45
EZ
12232012-07-05 Eli Zaretskii <eliz@gnu.org>
1224
1225 * xdisp.c (window_hscroll_limited): New function.
1226 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1227 coordinates when window's hscroll is set to insanely large
1228 values. (Bug#11857)
1229
431391ec
JB
12302012-07-05 Juanma Barranquero <lekktu@gmail.com>
1231
1232 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1233 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1234
23f86fce
DA
12352012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1236
1237 Cleanup xmalloc.
1238 * lisp.h (xzalloc): New prototype. Omit needless casts.
1239 * alloc.c (xzalloc): New function. Omit needless casts.
1240 * charset.c: Omit needless casts. Convert all calls to
1241 xmalloc with following memset to xzalloc.
1242 * dispnew.c: Likewise.
1243 * fringe.c: Likewise.
1244 * image.c: Likewise.
1245 * sound.c: Likewise.
1246 * term.c: Likewise.
1247 * w32fns.c: Likewise.
1248 * w32font.c: Likewise.
1249 * w32term.c: Likewise.
1250 * xfaces.c: Likewise.
1251 * xfns.c: Likewise.
1252 * xterm.c: Likewise.
1253 * atimer.c: Omit needless casts.
1254 * buffer.c: Likewise.
1255 * callproc.c: Likewise.
1256 * ccl.c: Likewise.
1257 * coding.c: Likewise.
1258 * composite.c: Likewise.
1259 * doc.c: Likewise.
1260 * doprnt.c: Likewise.
1261 * editfns.c: Likewise.
1262 * emacs.c: Likewise.
1263 * eval.c: Likewise.
1264 * filelock.c: Likewise.
1265 * fns.c: Likewise.
1266 * gtkutil.c: Likewise.
1267 * keyboard.c: Likewise.
1268 * lisp.h: Likewise.
1269 * lread.c: Likewise.
1270 * minibuf.c: Likewise.
1271 * msdos.c: Likewise.
1272 * print.c: Likewise.
1273 * process.c: Likewise.
1274 * region-cache.c: Likewise.
1275 * search.c: Likewise.
1276 * sysdep.c: Likewise.
1277 * termcap.c: Likewise.
1278 * terminal.c: Likewise.
1279 * tparam.c: Likewise.
1280 * w16select.c: Likewise.
1281 * w32.c: Likewise.
1282 * w32reg.c: Likewise.
1283 * w32select.c: Likewise.
1284 * w32uniscribe.c: Likewise.
1285 * widget.c: Likewise.
1286 * xdisp.c: Likewise.
1287 * xmenu.c: Likewise.
1288 * xrdb.c: Likewise.
1289 * xselect.c: Likewise.
1290
0497dc44
PE
12912012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1292
1293 * fileio.c (time_error_value): Check the right error number.
1294 Problem reported by Troels Nielsen in
1295 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1296
356e7178
PE
12972012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1298
4e71fd89
PE
1299 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1300 This should be fixed in a better way; see Eli Zaretskii in
1301 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1302 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1303
f0941253
PE
1304 * fileio.c (time_error_value): Rename from special_mtime.
1305 The old name's problems were noted by Eli Zaretskii in
1306 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1307
065c9eb4
PE
1308 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1309 This variable's comment says Emacs needs at least one GDB-visible
1310 symbol of type enum pvec_type, to work around GDB problems.
1311 The symbol's value doesn't matter.
1312
356e7178
PE
1313 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1314 that causes compilation to fail on pre-C99 compilers.
1315
ed9265fc 13162012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1317
1318 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1319 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1320
3884d954
DA
13212012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1322
d209e2fb 1323 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1324 headers for buffer_defaults and buffer_local_symbols.
1325 Reported by Juanma Barranquero <lekktu@gmail.com>.
1326
ee28be33
SM
13272012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1328
1329 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1330 * lisp.h (enum pvec_type): Use fewer bits.
1331 (PSEUDOVECTOR_SIZE_BITS): New constant.
1332 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1333 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1334 change in pvec_type.
1335 (PSEUDOVECTOR_TYPEP): New macro.
1336 (TYPED_PSEUDOVECTORP): Use it.
1337 * fns.c (internal_equal): Adapt code to extract pvectype.
1338 * emacs.c (gdb_pvec_type): Update type.
1339 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1340 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1341 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1342 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1343 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1344 abusing vector->header.next.nbytes.
1345 (live_vector_p): Use PVEC_TYPE.
1346 (mark_object): Adapt code to extract pvectype. Use switch.
1347
c7f2cd7f
PE
13482012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1349
1350 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1351 Tighten new eassert a bit.
1352
8ce70ed2
DA
13532012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1354
1355 Fix compilation with --enable-gcc-warnings and -O1
1356 optimization level.
1357 * doprnt.c (doprnt): Change type of tem to int, initialize
1358 to avoid compiler warning. Add eassert.
1359 * search.c (simple_search): Initialize match_byte to avoid
1360 compiler warning. Add eassert.
1361
dea7f1e5
PE
13622012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1363
24a212eb
PE
1364 Avoid weird behavior with large horizontal scrolls.
1365 Without this change, for example, large hscroll values would
1366 mess up Emacs's display on Fedora 15 x86, presumably due to
1367 overflows in int calculations in the display code.
1368 Also, if buffers had long lines, Emacs would freeze.
1369 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1370 (set_window_hscroll): New function, containing the old guts of
1371 Fset_window_hscroll. Return the clipped value.
1372 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1373 This avoids the need to check against PTRDIFF_MAX.
1374
dea7f1e5
PE
1375 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1376
76046526
DA
13772012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1378
1379 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1380
39adff0d
PE
13812012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1382
63807d47
PE
1383 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1384 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1385 since GCC 4.4.6 issues a bogus warning for them.
1386
39adff0d
PE
1387 Fix bugs in file timestamp newness comparisons.
1388 * fileio.c (Ffile_newer_than_file_p):
1389 * lread.c (Fload): Use full timestamp resolution of files,
1390 not just the 1-second resolution, so that files that are only
1391 slightly newer still count as newer.
1392 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1393 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1394
dbeed9a6
PE
13952012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1396
1397 * fileio.c: Improve handling of file time marker. (Bug#11852)
1398 (special_mtime): New function.
1399 (Finsert_file_contents, Fverify_visited_file_modtime):
1400 Use it to set special mtime values consistently.
1401
636334d6
AS
14022012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1403
1404 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1405 marker for non-existing file. (Bug#11852)
1406
e2017fe2
GM
14072012-07-03 Glenn Morris <rgm@gnu.org>
1408
1409 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1410 and did not make it into globals.h).
1411
404dbd37
TT
14122012-07-03 Tom Tromey <tromey@redhat.com>
1413
1414 * window.c (Fset_window_margins, Fset_window_fringes)
1415 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1416 * textprop.c (Fprevious_property_change): No longer static.
1417 * syntax.c (Fsyntax_table_p): No longer static.
1418 * process.c (Fget_process, Fprocess_datagram_address): No longer
1419 static.
1420 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1421 * keyboard.c (Fcommand_execute): No longer static.
1422 Remove EXFUN.
1423 * insdel.c (Fcombine_after_change_execute): No longer static.
1424 * image.c (Finit_image_library): No longer static.
1425 * fileio.c (Fmake_symbolic_link): No longer static.
1426 * eval.c (Ffetch_bytecode): No longer static.
1427 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1428 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1429 No longer static.
404dbd37
TT
1430 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1431 static.
1432 * dired.c (Ffile_attributes): No longer static.
1433 * composite.c (Fcomposition_get_gstring): No longer static.
1434 * callproc.c (Fgetenv_internal): No longer static.
1435
1436 * ccl.h: Remove EXFUNs.
1437 * buffer.h: Remove EXFUNs.
1438 * dispextern.h: Remove EXFUNs.
1439 * intervals.h: Remove EXFUNs.
1440 * fontset.h: Remove EXFUN.
1441 * font.h: Remove EXFUNs.
1442 * dosfns.c (system_process_attributes): Remove EXFUN.
1443 * keymap.h: Remove EXFUNs.
1444 * lisp.h: Remove EXFUNs.
1445 * w32term.h: Remove EXFUNs.
1446 * window.h: Remove EXFUNs.
1447 * xsettings.h: Remove EXFUN.
1448 * xterm.h: Remove EXFUN.
1449
8e4fd1e1
GM
14502012-07-03 Glenn Morris <rgm@gnu.org>
1451
1452 * lisp.h (Frandom): Make it visible to C.
1453 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1454 buffer for invisible buffers. (Bug#1229)
1455
ca95b3eb
DA
14562012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1457
1458 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1459 values which aren't power of 2.
1460 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1461 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1462 accordingly.
1463
7555c33f
SM
14642012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1465
1466 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1467
1468 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1469
d12e8f5a
DA
14702012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1471
1472 * alloc.c (allocate_vector_block): Remove redundant
1473 calls to mallopt if DOUG_LEA_MALLOC is defined.
1474 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1475 avoid calls to mallopt if zero_vector is returned.
1476
296094c3
DA
14772012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1478
1479 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1480 is enabled, avoid dereferencing NULL current_sblock if
1481 running undumped.
1482
36429c89
DA
14832012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1484
1485 Cleanup basic buffer management.
1486 * buffer.h (struct buffer): Change layout to use generic vector
1487 marking code. Fix some comments. Change type of 'clip_changed'
1488 to bitfield. Remove unused #ifndef old.
1489 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1490 (GET_OVERLAYS_AT): Fix indentation.
1491 (for_each_per_buffer_object_at): New macro.
1492 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1493 (Fbuffer_local_variables): Use it.
1494 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1495 * alloc.c (allocate_buffer): Adjust to match new layout of
1496 struct buffer. Fix comment.
1497 (mark_overlay): New function.
1498 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1499 Lisp area of struct buffer.
1500 (mark_object): Use it. Adjust marking of misc objects
1501 and related comments.
1502
3b3e4cac
PE
15032012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1504
1505 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1506 wrapper that is not needed because the wrapped code is a no-op (zero
1507 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1508 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1509
cf5c0175
DA
15102012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1511
1512 * alloc.c (mark_buffer): Simplify. Remove prototype.
1513 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1514 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1515 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1516 redundant calls to mark_vectorlike for bool vectors.
1517
ca26824c
GM
15182012-06-30 Glenn Morris <rgm@gnu.org>
1519
2e4c5312
GM
1520 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1521
ca26824c
GM
1522 * epaths.in (PATH_SITELOADSEARCH): New.
1523 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1524 This is rather than relying on --enable-locallisppath elements
1525 having "site-lisp" in their names. (Bug#10208#25, 11658)
1526
0d23c240
EZ
15272012-06-30 Eli Zaretskii <eliz@gnu.org>
1528
c9240d7a
EZ
1529 * w32proc.c (sys_select): Accept and ignore one more argument.
1530
1531 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1532
0d23c240 1533 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1534 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1535
1536 * sysdep.c: Don't include dos.h and dosfns.h.
1537
1538 * process.c (sys_select):
1539 * msdos.c (sys_select): Accept one more argument and ignore it.
1540
1541 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1542 adapt data types and code to that.
1543
1544 * dosfns.c:
1545 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1546 which clashes with the gnulib function of the same name.
1547
af5a5a98
AS
15482012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1549
c5e4379c
AS
1550 * font.c (font_style_to_value, font_style_symbolic)
1551 (font_prop_validate_style): Add type checks for values in
1552 font_style_table.
1553
af5a5a98
AS
1554 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1555 argument.
1556 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1557 uses.
1558
8d38f461
EZ
15592012-06-29 Eli Zaretskii <eliz@gnu.org>
1560
2e5a6631
EZ
1561 * xdisp.c (try_window_id): Undo last change.
1562
8d38f461
EZ
1563 * w32.c (getwd): Adjust commentary about startup_dir.
1564 (init_environment): Always call sys_access, even in non-MSVC
1565 builds. Don't chdir to the directory of the Emacs executable.
1566 This undoes code from 1997 which was justified by the need to
1567 "avoid conflicts when removing and renaming directories". But its
1568 downside was that every relative file name was being interpreted
1569 relative to the directory of the Emacs executable, which can never
1570 be TRT. In particular, it broke sys_access when called with
1571 relative file names.
1572 (sys_access): Map GetLastError to errno.
1573
2af3565e
DA
15742012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1575
1576 * window.h (struct window): Change type of 'fringes_outside_margins'
1577 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1578 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1579 Adjust comment.
1580 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1581 to ptrdiff_t.
1582
c8d3a25c 15832012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1584
c8d3a25c
GM
1585 * gnutls.c (emacs_gnutls_handshake):
1586 Add QUIT to make the loop interruptible.
57570cd3 1587
c8d3a25c 15882012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1589
c8d3a25c
GM
1590 * charset.c (init_charset): Make lack of etc/charsets fatal.
1591
3e984ee8
DA
15922012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1593
1594 * editfns.c (region_limit): Fix type mismatch.
1595
ef884f23
DA
15962012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1597
1598 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1599 undefined. Convert from xassert to eassert.
1600 * nsmenu.m: Convert from xassert to eassert.
1601 * nsterm.m: Likewise.
1602
7d7e0027
SM
16032012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1604
1605 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1606
aa754e6a
PE
16072012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1608
1609 Avoid integer overflow on scroll-left and scroll-right.
1610 * window.c (HSCROLL_MAX): New macro.
1611 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1612 overflow when requested scroll falls outside ptrdiff_t range.
1613
80b00b08
DA
16142012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1615
1616 * window.h (struct window): Change type of 'hscroll',
1617 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1618 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1619 Adjust users accordingly.
1620 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1621 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1622 from EMACS_INT to ptrdiff_t.
1623 (make_window): Omit redundant initialization.
1624
62b2bcf6
JB
16252012-06-28 Juanma Barranquero <lekktu@gmail.com>
1626
1627 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1628
45942c7d
DA
16292012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1630
1631 * window.h (struct window): Change type of 'use_time' and
1632 'sequence_number' from Lisp_Object to int.
1633 * frame.c (make_frame): Adjust users accordingly.
1634 * print.c (print_object): Likewise.
1635 * window.c (select_window, Fwindow_use_time, make_parent_window)
1636 (make_window): Likewise.
1637
e509cfa6
DA
16382012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1639
1640 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1641 enabled with --enable-checking=[all,glyphs] configure option.
1642 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1643 adjust comments accordingly.
1644 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1645 undefined, adjust comments accordingly.
1646 * image.c: Likewise.
1647 * scroll.c: Likewise.
1648 * w32fns.c: Likewise.
1649 * w32term.c: Likewise.
1650 * xdisp.c: Likewise.
1651 * xfaces.c: Likewise.
1652 * xfns.c: Likewise.
1653 * xterm.c: Likewise.
1654
a54e2c05
DA
16552012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1656
1657 Generalize run-time debugging checks.
1658 * dispextern.h (XASSERTS): Remove.
1659 * fontset.c (xassert): Remove.
1660 Convert from xassert to eassert.
1661 * alloc.c: Convert from xassert to eassert.
1662 * bidi.c: Likewise.
1663 * dispnew.c: Likewise.
1664 * fns.c: Likewise.
1665 * fringe.c: Likewise.
1666 * ftfont.c: Likewise.
1667 * gtkutil.c: Likewise.
1668 * image.c: Likewise.
1669 * keyboard.c: Likewise.
1670 * menu.c: Likewise.
1671 * process.c: Likewise.
1672 * scroll.c: Likewise.
1673 * sound.c: Likewise.
1674 * term.c: Likewise.
1675 * w32console.c: Likewise.
1676 * w32fns.c: Likewise.
1677 * w32term.c: Likewise.
1678 * window.c: Likewise.
1679 * xdisp.c: Likewise.
1680 * xfaces.c: Likewise.
1681 * xfns.c: Likewise.
1682 * xselect.c: Likewise.
1683 * xterm.c: Likewise.
1684
1ec4b7b2
SM
16852012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1686
1687 * fns.c (maybe_resize_hash_table): Output message when growing the
1688 purify-hashtable.
1689
2014308a
DA
16902012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1691
1692 * alloc.c (allocate_string_data): Remove dead code.
1693 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1694 avoid GCC warning about unused macro.
1695
246155eb
DA
16962012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1697
1698 * alloc.c (allocate_string): Omit intervals initialization.
1699 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1700 as in make_pure_string and make_pure_c_string.
1701
43184b7b
DA
17022012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1703
d209e2fb 1704 * alloc.c (allocate_string): Fix last change.
43184b7b 1705
3fe6dd74
DA
17062012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1707
d209e2fb 1708 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1709 to memset, add explicit initialization where appropriate.
1710
1ba6038a
GM
17112012-06-27 Glenn Morris <rgm@gnu.org>
1712
1713 * lisp.mk (lisp): Remove paths.elc.
1714
c89926a5
CY
17152012-06-27 Chong Yidong <cyd@gnu.org>
1716
1717 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1718
ed6b3510
JW
17192012-06-26 John Wiegley <johnw@newartisans.com>
1720
1ec4b7b2 1721 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1722 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1723
ed6b3510
JW
1724 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1725 when building with Clang.
1726
8edd4a2b
SM
17272012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1728
1729 * eval.c (Fapply): Allow calling it with a single argument.
1730
f6f62d1b
EZ
17312012-06-26 Eli Zaretskii <eliz@gnu.org>
1732
1733 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1734 _stricmp and _strnicmp.
1735 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1736
62efea5e
DA
17372012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1738
1739 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1740 allocated window.
1741 (allocate_process): Likewise for new process.
8edd4a2b 1742 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1743 (allocate_frame): Likewise.
1744 * frame.c (make_frame): Omit redundant initialization.
1745 * window.c (make_parent_window): Use memset.
1746 (make_window): Omit redundant initialization.
1747 * process.c (make_process): Omit redundant initialization.
1748 * terminal.c (create_terminal): Likewise.
1749
42997f4d
DA
17502012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1751
1752 * term.c (delete_tty): Remove redundant call to memset.
1753
1130ecfc
DA
17542012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1755
1756 * alloc.c: Remove build_string.
1757 * lisp.h: Define build_string as static inline. This provides
1758 a better opportunity to optimize away calls to strlen when the
1759 function is called with compile-time constant argument.
1760 * image.c (imagemagick_error): Convert to build_string.
1761 * w32proc.c (sys_spawnve): Likewise.
1762 * xterm.c (x_term_init): Likewise.
1763
cf38a720
PE
17642012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1765
99027bdd
PE
1766 Use sprintf return value instead of invoking strlen on result.
1767 In the old days this wasn't portable, since some sprintf
1768 implementations returned char *. But they died out years ago and
1769 Emacs already assumes sprintf returns int.
1770 Similarly for float_to_string.
1771 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1772 * ccl.c (ccl_driver):
1773 * character.c (string_escape_byte8):
1774 * data.c (Fnumber_to_string):
1775 * doprnt.c (doprnt):
1776 * print.c (print_object):
1777 * xdisp.c (message_dolog):
1778 * xfns.c (syms_of_xfns):
1779 Use sprintf or float_to_string result to avoid need to call strlen.
1780 * data.c (Fnumber_to_string):
1781 Use make_unibyte_string, since the string must be ASCII.
1782 * lisp.h, print.c (float_to_string): Now returns int length.
1783 * term.c (produce_glyphless_glyph):
1784 Use sprintf result rather than recomputing it.
1785
cf38a720
PE
1786 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1787 * Makefile.in (ALL_CFLAGS):
1788 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1789 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1790
3511c784
DA
17912012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1792
0a08eb21 1793 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1794 strcasecmp if available.
1795 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1796
fb7da12e
AS
17972012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1798
1799 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1800 Avoid comma operator.
1801 * menu.c (push_submenu_start, push_submenu_end)
1802 (push_left_right_boundary, push_menu_pane): Likewise.
1803 * msdos.c (dos_rawgetc): Likewise.
1804
afa2ffd8
DA
18052012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1806
1807 * xfns.c (xic_create_fontsetname): Remove redundant calls
1808 to memset.
1809
b3b4476b
PE
18102012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1811
4495ff38
PE
1812 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1813 sprintf already null-terminates its output.
1814
b3b4476b
PE
1815 * xfns.c (x_window): Remove redundant cast.
1816
b00876c9
DA
18172012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1818
1819 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1820 `const char *' to `char *' to avoid compiler warning.
1821
d188e26b
PE
18222012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1823
885d1d74
PE
1824 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1825 instead of truncating it to 63 (admittedly a generous limit).
1826
d188e26b
PE
1827 * process.c: Fix spelling and caps in comments.
1828
e2f560b1
DN
18292012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1830
e86db54b 1831 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1832 * sysdep.c (setpgrp): Remove definition, not used in this file.
1833
7583a3a1
JB
18342012-06-24 Juanma Barranquero <lekktu@gmail.com>
1835
1836 * makefile.w32-in: Update dependencies.
1837
696056c2
EZ
18382012-06-24 Eli Zaretskii <eliz@gnu.org>
1839
1840 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1841 (SYSTIME_H): Add nt/inc/sys/time.h.
1842
1843 * systime.h [WINDOWSNT]: Include sys/time.h.
1844
1845 * s/ms-w32.h (struct timespec): Definition moved from
1846 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1847
845ca893
PE
18482012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1849
1850 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1851 * buffer.h (buffer_slot_type_mismatch):
1852 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1853 * eval.c (unwind_to_catch):
1854 * image.c (my_png_error, my_error_exit):
1855 * keyboard.c (quit_throw_to_read_char, user_error)
1856 (Fexit_recursive_edit, Fabort_recursive_edit):
1857 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1858 (wrong_type_argument, buffer_overflow, __executable_start)
1859 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1860 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1861 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1862 (fatal):
1863 (child_setup) [!DOS_NT]:
1864 * lread.c (end_of_file_error, invalid_syntax):
1865 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1866 * puresize.h (pure_write_error):
1867 * search.c (matcher_overflow):
1868 * sound.c (sound_perror, alsa_sound_perror):
1869 * sysdep.c, syssignal.h (croak):
1870 * term.c (maybe_fatal, vfatal):
1871 * textprop.c (text_read_only):
1872 * undo.c (user_error):
1873 * unexmacosx.c (unexec_error):
1874 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1875 Use _Noreturn rather than NO_RETURN.
1876 No need for separate decl merely because of _Noreturn.
1877 * sound.c (sound_warning, parse_sound):
1878 Remove unnecessary forward decls.
1879
f1dd8073
PE
18802012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1881
1882 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1883 * lisp.h (WAIT_READING_MAX): New macro.
1884 * dispnew.c (Fsleep_for, sit_for):
1885 * keyboard.c (kbd_buffer_get_event):
1886 * process.c (Faccept_process_output):
1887 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1888 This improves on the previous patch, which introduced a bug
1889 when time_t is unsigned and as wide as intmax_t.
1890 See <http://bugs.gnu.org/9000#51>.
1891
b82c1755
EZ
18922012-06-23 Eli Zaretskii <eliz@gnu.org>
1893
1894 * dispnew.c (sit_for, Fsleep_for):
1895 * keyboard.c (kbd_buffer_get_event):
1896 * process.c (Faccept_process_output): Avoid compiler warnings when
1897 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1898
ca300656
JB
18992012-06-23 Juanma Barranquero <lekktu@gmail.com>
1900
049ec95b
JB
1901 * makefile.w32-in: Update dependencies.
1902
ca300656
JB
1903 * w32.c (ltime): Add return type and declare static.
1904 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1905
db7b8d06
PE
19062012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1907
1908 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1909 Privately reported by Herbert J. Skuhra.
1910 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1911 All uses changed.
1912 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1913 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1914
0bd8297f
EZ
19152012-06-23 Eli Zaretskii <eliz@gnu.org>
1916
96512555
EZ
1917 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1918 last argument of make_unibyte_string.
1919
0bd8297f
EZ
1920 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1921 language ID in the event parameters.
1922
1923 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1924 event.code, not the obscure "character set ID".
1925
63def6b6
CY
19262012-06-23 Chong Yidong <cyd@gnu.org>
1927
1928 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1929
e8a02204
EZ
19302012-06-23 Eli Zaretskii <eliz@gnu.org>
1931
388cdec0
EZ
1932 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1933 * w32.c (fdutimens): New function.
1934
1935 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1936
1937 * s/ms-w32.h (pselect): Redirect to sys_select.
1938
1939 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1940
e8a02204
EZ
1941 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1942 in the logic of incrementing and decrementing the value of
1943 use_relocatable_buffers.
1944
d054f3fb
PE
19452012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1946
1947 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1948 Privately reported by Herbert J. Skuhra.
1949 [__FreeBSD__]: Remove "*/" typo after "#include".
1950 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1951 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1952 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1953 Don't assume EMACS_TIME and struct timeval are the same type.
1954
d35af63c
PE
19552012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1956
1957 Support higher-resolution time stamps (Bug#9000).
1958 The time stamps are only nanosecond-resolution at the C level,
1959 since that's the best that any real-world system supports now.
1960 But they are picosecond-resolution at the Lisp level, as that's
1961 easy, and leaves room for future OS improvements.
1962
1963 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1964 (LIBES): Use it.
1965
1966 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1967 Don't get current time unless it's needed.
1968
1969 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1970 now provides it if it's absent.
1971 (start_atimer): Port to higher-res time stamps.
1972 Check for time stamp overflow. Don't get current time more
1973 often than is needed.
1974
1975 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1976 Include systime.h, not time.h.
1977 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1978
1979 * dired.c: Include stat-time.h.
1980 (Ffile-attributes): File times now have higher resolution.
1981
1982 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1983 (struct image): Timestamp now has higher resolution.
1984
1985 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1986 has at least microseconds now. All uses removed.
1987 (update_frame, update_single_window, update_window, update_frame_1)
1988 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1989
1990 * editfns.c (time_overflow): Now extern.
1991 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1992 (float-time, Fformat_time_string, Fcurrent_time_string)
1993 (Fcurrent_time_zone): Accept and generate higher-resolution
1994 time stamps.
1995 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1996 (decode_time_components, lisp_seconds_argument): New functions.
1997 (make_time): Now static.
1998 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1999 Report an error if the time is invalid, rather than having the caller
2000 do that.
2001
2002 * fileio.c: Include <stat-time.h>
2003 (Fcopy_file): Copy higher-resolution time stamps.
2004 Prefer to set the time stamp via a file descriptor if that works.
2005 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2006 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2007 (Fvisited_file_modtime, Fset_visited_file_modtime):
2008 Support higher-resolution time stamps.
2009
2010 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2011
2012 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2013
2014 * image.c (prepare_image_for_display, clear_image_cache)
2015 (lookup_image): Port to higer-resolution time stamps.
2016
2017 * keyboard.c (start_polling, bind_polling_period):
2018 Check for time stamp overflow.
2019 (read_char, kbd_buffer_get_event, timer_start_idle)
2020 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2021 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2022 Port to higher-resolution time stamps. Do not assume time_t is signed.
2023 (decode_timer): New function. Timers are now vectors of length 9,
2024 not 8, to accommodate the picosecond component.
2025 (timer_check_2): Use it.
2026
2027 * nsterm.m (select_timeout, timeval_subtract): Remove.
2028 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2029 as they're a bit more accurate and handle overflow better.
2030 (ns_select): Change prototype to be compatible with pselect.
2031 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2032 * nsterm.h (ns_select): Adjust prototype.
2033
2034 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2035 us-resolution time stamps.
2036 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2037
2038 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2039
2040 * lisp.h (time_overflow): New decl.
2041 (wait_reading_process_output): First arg is now intmax_t, not int,
2042 to accommodate larger waits.
2043
2044 * process.h (struct Lisp_Process.read_output_delay):
2045 Now counts nanoseconds, not microseconds.
2046 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2047 EMACS_HAS_USECS.
2048 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2049 (wait_reading_process_output):
2050 Port to ns-resolution time stamps.
2051 (Faccept_process_output, wait_reading_process_output):
2052 Check for time stamp overflow. Do not assume time_t is signed.
2053 (select_wrapper): Remove; we now use pselect.
2054 (Fprocess_attributes): Now generates ns-resolution time stamps.
2055
2056 * sysdep.c: Include utimens.h. Don't include utime.h
2057 or worry about struct utimbuf; gnulib does that for us now.
2058 (gettimeofday): Remove; gnulib provides a substitute.
2059 (make_timeval): New function.
2060 (set_file_times): Now sets ns-resolution time stamps.
2061 New arg FD; all uses changed.
2062 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2063 (system_process_attributes):
2064 Now returns ns-resolution time stamp. All uses changed.
2065 Check for time stamp overflow.
2066
2067 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2068 provides a substitute now.
2069
2070 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2071 since it guarantees struct timespec.
2072 (EMACS_TIME): Now struct timespec, so that we can support
2073 ns-resolution time stamps.
2074 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2075 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2076 (EMACS_USECS): Remove.
2077 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2078 so multiply the arg by 1000 before storing it.
2079 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2080 New macros.
2081 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2082 Port to ns-resolution time stamps.
2083 (EMACS_TIME_NEG_P): Remove; replaced by....
2084 (EMACS_TIME_SIGN): New macro.
2085 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2086 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2087 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2088 (make_timeval, make_lisp_time, decode_time_components): New decls.
2089 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2090 that it mishandled time_t overflow. You can't compare by subtracting!
2091 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2092 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2093
2094 * term.c: Include <sys/time.h>.
2095 (timeval_to_Time): New function, for proper overflow wraparound.
2096 (term_mouse_position, term_mouse_click): Use it.
2097
2098 * undo.c (record_first_change): Support higher-resolution time stamps
2099 in the undo buffer.
2100 (Fprimitive_undo): Use them when restoring time stamps.
2101
2102 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2103 (w32_get_internal_run_time):
2104 Port to higher-resolution Emacs time stamps.
2105 (ltime): Now accepts single 64-bit integer, as that's more convenient
2106 for callers.
2107
2108 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2109
2110 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2111 for compatibility with pselect. Support ns-resolution time stamps.
2112
2113 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2114
2115 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2116 Check for time stamp overflow, and support ns-resolution time stamps.
2117
2118 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2119 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2120 (timeval_subtract): Remove; no longer needed.
2121 (XTflash, XTring_bell, x_wait_for_event):
2122 Port to ns-resolution time stamps. Don't assume time_t is signed.
2123
b6a92dfe
CY
21242012-06-22 Chong Yidong <cyd@gnu.org>
2125
2126 * xdisp.c (x_consider_frame_title): Revert last change.
2127
d251c37c
EZ
21282012-06-22 Eli Zaretskii <eliz@gnu.org>
2129
2130 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2131 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2132 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2133 staticidx goes up to 1597 out of 1600 = 0x640.)
2134
f10deafb
PE
21352012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2136
2137 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2138 Otherwise, the umask might be mistakenly 0 while handling input signals.
2139
ec6de1e2
SM
21402012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2141
2142 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2143
28be1ada
DA
21442012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2145
2146 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2147 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2148 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2149 access to `contents' member of Lisp_Vector objects with AREF and ASET
2150 where appropriate.
2151
c6bf3022
CY
21522012-06-19 Chong Yidong <cyd@gnu.org>
2153
2154 * frame.c (delete_frame): When selecting a frame on a different
2155 text terminal, do not alter the terminal's top-frame.
2156
2157 * xdisp.c (format_mode_line_unwind_data): Record the target
2158 frame's selected window and its terminal's top-frame.
2159 (unwind_format_mode_line): Restore them.
2160 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2161 Callers changed.
2162 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2163 since tty frames can be explicitly named.
2164 (prepare_menu_bars): Likewise.
2165
2166 * term.c (Ftty_top_frame): New function.
2167
defd4196
PE
21682012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2169
2170 Port byte-code-meter to modern targets.
2171 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2172 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2173 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2174 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2175 (METER_1, METER_2): Simplify.
2176
1053a871
SM
21772012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2178
2179 * data.c (Fdefalias): Return `symbol' (bug#11686).
2180
b7e8d081
MR
21812012-06-18 Martin Rudalics <rudalics@gmx.at>
2182
2183 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2184 gets killed during executing of this function (Bug#11665).
2185 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2186 (Vkill_buffer_query_functions): In doc-string say that functions
2187 run by this hook should not change the current buffer.
2188
7ea2b339
PE
21892012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2190
2191 Fix recently-introduced process.c problems found by static checking.
2192 * process.c (write_queue_push, write_queue_pop, send_process):
2193 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2194 (write_queue_pop): Fix pointer signedness problem.
2195 (send_process): Remove unused local.
2196
96a313a1
CY
21972012-06-17 Chong Yidong <cyd@gnu.org>
2198
2199 * xdisp.c (redisplay_internal): No need to redisplay terminal
2200 frames that are not on top.
2201
20ca2e94
TN
22022012-06-17 Troels Nielsen <bn.troels@gmail.com>
2203
2204 * process.c (make_process): Initialize write_queue.
2205 (write_queue_push, write_queue_pop): New functions.
2206 (send_process): Use them to maintain correct ordering of process
2207 writes (Bug#10815).
2208
9a900ca9
PE
22092012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2210
310fbfa8
PE
2211 * lisp.h (eassert): Assume C89 or later.
2212 This removes the need for CHECK.
2213 (CHECK): Remove. Its comments about always evaluating its
2214 argument were confusing, as 'eassert' typically does not evaluate
2215 its argument.
2216
27bb1ca4
PE
2217 * coding.c (produce_chars): Use ptrdiff_t, not int.
2218
9a900ca9
PE
2219 * xterm.c (x_draw_underwave): Check for integer overflow.
2220 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2221
41b7f8bc 22222012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2223
2224 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2225 referenced (Bug#11583).
2226
9b0e3eba
AA
22272012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2228
2229 Implement wave-style variant of underlining.
2230 * dispextern.h (face_underline_type): New enum.
2231 (face): Add field for underline type.
2232 * nsterm.m (ns_draw_underwave): New function.
2233 (ns_draw_text_decoration): Use it.
2234 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2235 New functions.
2236 (x_draw_glyph_string): Use them.
2237 * xfaces.c (Qline, Qwave): New Lisp objects.
2238 (check_lface_attrs, merge_face_ref)
1053a871
SM
2239 (Finternal_set_lisp_face_attribute, realize_x_face):
2240 Handle wave-style underline face attributes.
9b0e3eba
AA
2241 * xterm.c (x_draw_underwave): New function.
2242 (x_draw_glyph_string): Use it.
2243
0fb52f11
JB
22442012-06-16 Juanma Barranquero <lekktu@gmail.com>
2245
2246 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2247 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2248 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2249 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2250 ($(BLD)/w32select.$(O)): Update dependencies.
2251
e5560ff7
AS
22522012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2253
2254 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2255 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2256 * character.c (_fetch_multibyte_char_p): Remove.
2257 * alloc.c: Include "character.h" before "buffer.h".
2258 * bidi.c: Likewise.
2259 * buffer.c: Likewise.
2260 * bytecode.c: Likewise.
2261 * callint.c: Likewise.
2262 * callproc.c: Likewise.
2263 * casefiddle.c: Likewise.
2264 * casetab.c: Likewise.
2265 * category.c: Likewise.
2266 * cmds.c: Likewise.
2267 * coding.c: Likewise.
2268 * composite.c: Likewise.
2269 * dired.c: Likewise.
2270 * dispnew.c: Likewise.
2271 * doc.c: Likewise.
2272 * dosfns.c: Likewise.
2273 * editfns.c: Likewise.
2274 * emacs.c: Likewise.
2275 * fileio.c: Likewise.
2276 * filelock.c: Likewise.
2277 * font.c: Likewise.
2278 * fontset.c: Likewise.
2279 * fringe.c: Likewise.
2280 * indent.c: Likewise.
2281 * insdel.c: Likewise.
2282 * intervals.c: Likewise.
2283 * keyboard.c: Likewise.
2284 * keymap.c: Likewise.
2285 * lread.c: Likewise.
2286 * macros.c: Likewise.
2287 * marker.c: Likewise.
2288 * minibuf.c: Likewise.
2289 * nsfns.m: Likewise.
2290 * nsmenu.m: Likewise.
2291 * print.c: Likewise.
2292 * process.c: Likewise.
2293 * regex.c: Likewise.
2294 * region-cache.c: Likewise.
2295 * search.c: Likewise.
2296 * syntax.c: Likewise.
2297 * term.c: Likewise.
2298 * textprop.c: Likewise.
2299 * undo.c: Likewise.
2300 * unexsol.c: Likewise.
2301 * w16select.c: Likewise.
2302 * w32fns.c: Likewise.
2303 * w32menu.c: Likewise.
2304 * window.c: Likewise.
2305 * xdisp.c: Likewise.
2306 * xfns.c: Likewise.
2307 * xmenu.c: Likewise.
2308 * xml.c: Likewise.
2309 * xselect.c: Likewise.
2310
2f07e6af
EZ
23112012-06-16 Eli Zaretskii <eliz@gnu.org>
2312
1053a871
SM
2313 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2314 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2315 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2316 row.
2317 (handle_face_prop): Use chunk-relative overlay string index when
2318 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2319 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2320 the rightmost. (Bug#11720)
2f07e6af 2321
29b83cec
AS
23222012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2323
2324 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2325 (CATEGORY_MEMBER): Enforce 1/0 value.
2326 * category.c (_temp_category_set): Remove.
2327
4c5501e9
EZ
23282012-06-16 Eli Zaretskii <eliz@gnu.org>
2329
2330 * window.c (Fdelete_other_windows_internal)
2331 (Fdelete_window_internal): Don't access frame's mouse highlight
2332 info of the initial frame. (Bug#11677)
2333
2b570124
PE
23342012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2335
e93864f9
PE
2336 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2337 Assume USE_2_TAGS_FOR_INTS.
2338 (xreload): Adjust $tagmask width to match recent lisp.h change.
2339
2b570124
PE
2340 Simplify lisp.h in minor ways that should not affect code.
2341 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2342 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2343 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2344 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2345 (INTTYPEBITS): New macro, for clarity.
2346 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2347 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2348 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2349 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2350 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2351
81755f69
JB
23522012-06-13 Juanma Barranquero <lekktu@gmail.com>
2353
2354 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2355
16192a57
GM
23562012-06-13 Glenn Morris <rgm@gnu.org>
2357
2358 * s/bsd-common.h (BSD4_3):
2359 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2360
646b5f55
AS
23612012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2362
2363 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2364 instead of union.
2365 (XLI, XIL): Define.
1053a871
SM
2366 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2367 Use them.
2368 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2369 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2370 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2371 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2372 * frame.c (delete_frame): Remove outdated comment.
2373 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2374 USE_LISP_UNION_TYPE.
2375 (Fw32_unregister_hot_key): Likewise.
2376 (Fw32_toggle_lock_key): Likewise.
2377 * w32menu.c (add_menu_item): Likewise.
2378 (w32_menu_display_help): Use XIL instead of checking
2379 USE_LISP_UNION_TYPE.
2380 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2381 (init_heap): Likewise.
2382 * w32term.c (w32_read_socket): Update comment.
2383
1d3823c9
GM
23842012-06-13 Glenn Morris <rgm@gnu.org>
2385
c62ff706
GM
2386 * s/usg5-4-common.h, src/s/unixware.h:
2387 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2388
1d3823c9
GM
2389 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2390
bfe3e0a2
PE
23912012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2394 * alloc.c (make_number) [!defined make_number]:
2395 Remove, as lisp.h always defines this now.
2396 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2397 (roundup_size): Verify that it is a power of 2.
2398 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2399 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2400 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2401 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2402 USE_LSB_TAG now is always defined to be either 0 or 1.
2403 All uses changed.
2404 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2405 code works fine either way, and efficiency is not a concern here,
2406 as the union type is for debugging, not for production.
2407 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2408 Use an inline function on all platforms when using the union type,
2409 since this is simpler and 'static inline' can be used portably
2410 within Emacs now.
2411 (LISP_INITIALLY_ZERO): New macro.
2412 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2413 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2414
45fa9c0f
GM
24152012-06-12 Glenn Morris <rgm@gnu.org>
2416
b4492cba
GM
2417 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2418
2419 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2420
45fa9c0f
GM
2421 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2422 Move BROKEN_SIGIO to configure.
2423
2424 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2425 Move NO_TERMIO to configure.
2426
0e25d334
CY
24272012-06-12 Chong Yidong <cyd@gnu.org>
2428
2429 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2430 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2431 MagickExportImagePixels is undefined.
2432
43682bb6
PE
24332012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2434
2435 * image.c (imagemagick_load_image): Remove unused label.
2436
a9be7d2b
GM
24372012-06-11 Glenn Morris <rgm@gnu.org>
2438
2439 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2440 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2441 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2442 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2443
3017f87f
SM
24442012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2445
2446 * alloc.c (make_byte_code): New function.
2447 (Fmake_byte_code): Use it. Don't purify here.
2448 * lread.c (read1): Use it as well to avoid extra allocation.
2449
1b9b4cf4
CY
24502012-06-11 Chong Yidong <cyd@gnu.org>
2451
2452 * image.c (imagemagick_load_image): Implement transparency.
2453
95988fcf
AS
24542012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2455
2456 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2457 account for preceding backslashes. (Bug#11663)
2458
cd4eb164
CY
24592012-06-09 Chong Yidong <cyd@gnu.org>
2460
2461 * term.c: Support italics in capable terminals (Bug#9652).
2462 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2463 (turn_on_face): Output using TS_enter_italic_mode if available.
2464 Don't handle unused blinking and alt-charset cases.
2465 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2466 and tty_alt_charset_p cases.
2467 (tty_capable_p, init_tty): Support italics.
2468
2469 * termchar.h (struct tty_display_info): Add field for italics.
2470 Remove unused blink field.
2471
2472 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2473 Handle slant.
2474
2475 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2476 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2477 tty_alt_charset_p. Add tty_italic_p.
2478
ff88beb8
MA
24792012-06-09 Michael Albinus <michael.albinus@gmx.de>
2480
2481 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2482 dbus_type_is_basic if available.
2483 (xd_extract_signed, xd_extract_unsigned): Rename from
2484 extract_signed and extract_unsigned, respectively. Adapt callers.
2485
44286096
CY
24862012-06-09 Chong Yidong <cyd@gnu.org>
2487
1682701f
CY
2488 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2489
44286096
CY
2490 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2491 case (Bug#9752).
2492
d86feb17
PE
24932012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2494
2495 * xdisp.c (vmessage): Treat frame message as multibyte.
2496 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2497 would generate the diagnostic "Making \302\247 buffer-local while
2498 let-bound!".
2499
d5c20fe8
EZ
25002012-06-08 Eli Zaretskii <eliz@gnu.org>
2501
2502 * dispnew.c (showing_window_margins_p): Undo last change, which
2503 was done due to an inadvertent commit.
2504 (adjust_frame_glyphs_for_frame_redisplay): Do call
2505 showing_window_margins_p.
2506
513749ee
SM
25072012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2508
2509 * eval.c (Fmake_var_non_special): New primitive.
2510 (syms_of_eval): Defsubr it.
2511 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2512
d4a8f5c1
JB
25132012-06-08 Juanma Barranquero <lekktu@gmail.com>
2514
2515 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2516 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2517
8bbbc977
EZ
25182012-06-08 Eli Zaretskii <eliz@gnu.org>
2519
2520 * alloc.c (allocate_vectorlike): Fix last change.
2521
f3372c87
DA
25222012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2523
2524 Block-based vector allocation of small vectors.
2525 * lisp.h (struct vectorlike_header): New field `nbytes',
2526 adjust comment accordingly.
2527 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2528 to denote vector blocks. Adjust users (live_vector_p,
2529 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2530 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2531 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2532 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2533 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2534 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2535 (roundup_size): New constant.
2536 (struct vector_block): New data type.
2537 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2538 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2539 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2540 (sweep_vectors): New functions.
2541 (allocate_vectorlike): Return `zero_vector' as the only vector of
2542 0 items. Allocate new vector from block if vector size is less than
2543 or equal to VBLOCK_BYTES_MAX.
2544 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2545 (init_alloc_once): Add call to init_vectors.
2546
4f18a4ed
SM
25472012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2548
2549 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2550
86f158bc
PE
25512012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2552
2553 * doprnt.c (doprnt): Truncate multibyte char correctly.
2554 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2555 would mishandle a string argument "Xc" if X was a multibyte
2556 character of length 2: it would truncate after X's first byte
2557 rather than including all of X.
2558
c5cfcbe0
CY
25592012-06-06 Chong Yidong <cyd@gnu.org>
2560
2561 * buffer.c (word_wrap): Doc fix.
2562
c05cf390
PE
25632012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2564
2565 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2566
0c3461de
GM
25672012-06-03 Glenn Morris <rgm@gnu.org>
2568
2569 * xdisp.c (tool-bar-style): Doc fix.
2570
c71232db
UM
25712012-06-03 Ulrich Müller <ulm@gentoo.org>
2572
2573 * Makefile.in (PAXCTL): Define.
2574 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2575 binary via PaX flags if the paxctl utility is available.
2576 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2577 Restore PaX flags to their default. (Bug#11398)
2578
383f7350
CY
25792012-06-03 Chong Yidong <cyd@gnu.org>
2580
2581 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2582 buffer (Bug#11226).
2583
5f2c76c6
CY
25842012-06-03 Chong Yidong <cyd@gnu.org>
2585
2586 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2587 (note_mode_line_or_margin_highlight): If there is no help echo,
2588 use mode-line-default-help-echo. Handle the case where the mouse
2589 position is past the end of the mode line string.
2590
2591 * buffer.c (buffer_local_value_1): New function, split from
2592 Fbuffer_local_value; can return Qunbound.
2593 (Fbuffer_local_value): Use it.
2594 (Vmode_line_format): Docstring tweaks.
2595
773d47f6
PE
25962012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2597
2598 * sysdep.c (system_process_attributes): Improve comment.
2599
f2d6a3df
SM
26002012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2601
2602 * keyboard.c: Export real-this-command to Elisp.
2603 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2604 and DEFVAR it. Update all users.
2605
63810350
PE
26062012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2607
7bd5c1f4
PE
2608 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2609
63810350
PE
2610 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2611 Convert pctcpu and pctmem to Lisp float properly.
2612 Let the compiler fold better, as 100.0/0x8000 is exact.
2613
a2821611
AS
26142012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2615
2616 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2617 cons_block.
2618
5fceba1d
PE
26192012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2620
2621 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2622
c98ff5dd
DA
26232012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2624
2625 For a 'struct window', replace some Lisp_Object fields to
2626 bitfields where appropriate, remove unused fields.
2627 * window.h (struct window): Remove unused 'last_mark_x' and
2628 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2629 change it's type from Lisp_Object to bitfield.
2630 Change type of 'force_start', 'optional_new_start',
2631 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2632 fields from Lisp_Object to bitfield. Adjust users accordingly.
2633
ca34e0be
PE
26342012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2635
2636 Pacify gcc -Wdouble-precision when using Xaw.
2637 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2638 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2639 Use 'float' consistently, rather than 'float' in most places
2640 and 'double' in a couple of places.
2641
efc00ab1 26422012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2643
2644 * xdisp.c (handle_stop): Detect whether we have overlay strings
2645 loaded by testing it->current.overlay_string_index to be
2646 non-negative, instead of checking whether n_overlay_strings is
2647 positive. (Bug#11587)
2648
efc00ab1 26492012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2650
2651 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2652
2653 * doc.c (Fsubstitute_command_keys): Doc fix.
2654
efc00ab1 26552012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2656
2657 * search.c (search_buffer): Remove calls to
2658 r_alloc_inhibit_buffer_relocation, as it is now called by
2659 maybe_unify_char, which was the cause of relocation of buffer text
2660 in bug#11519.
2661
efc00ab1 26622012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2663
2664 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2665 for the duration of call to load_charset, to avoid problems with
2666 callers of maybe_unify_char that access buffer text through C
2667 pointers.
2668
2669 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2670 decrement the inhibition flag, instead of just setting or
2671 resetting it.
2672
ba93a187
PE
26732012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2674
2675 Remove obsolete '#define static' cruft.
2676 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2677 This #undef was "temporary" in 2000; it is no longer needed
2678 now that '#define static' has gone away.
2679 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2680 (gray_bitmap_bits): Remove; no longer needed.
2681 All uses replaced with definiens.
2682 * xterm.c: Include "bitmaps/gray.xbm".
2683
9e4bf381
PE
26842012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2685
2686 Clean up __executable_start, monstartup when --enable-profiling.
2687 The following changes affect the code only when profiling.
2688 * dispnew.c (__executable_start): Rename from safe_bcopy.
2689 Define only on platforms that need it.
2690 * emacs.c: Include <sys/gmon.h> when profiling.
2691 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2692 (__executable_start): Remove decl, since lisp.h does it now.
2693 (safe_bcopy): Remove decl; no longer has that name.
2694 (main): Coalesce #if into single bit of code, for simplicity.
2695 Cast pointers to uintptr_t, since standard libraries want integers
2696 and not pointers.
2697 * lisp.h (__executable_start): New decl.
2698
32d72c2f
GM
26992012-05-31 Glenn Morris <rgm@gnu.org>
2700
2701 * image.c (Fimagemagick_types): Doc fix.
2702
baac5bc7
JM
27032012-05-30 Jim Meyering <meyering@redhat.com>
2704
2705 * callproc.c (Fcall_process_region): Include directory component
2706 in mkstemp error message (Bug#11586).
2707
72cb32cf
PE
27082012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2709
2710 * alloc.c, lisp.h (make_pure_vector): Now static.
2711
61b108cc
SM
27122012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2713
2714 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2715 Move to byte-run.el.
2716 (Fautoload): Do the hash-doc more carefully.
2717 * data.c (Fdefalias): Purify definition, except for keymaps.
2718 (Qdefun): Move from eval.c.
2719 * lisp.h (Qdefun): Remove.
2720 * lread.c (read1): Tiny simplification.
2721
471fe23d
TN
27222012-05-29 Troels Nielsen <bn.troels@gmail.com>
2723
934f3f58 2724 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2725 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2726 Bug#9642, but explicitly check that the buffer the overlay would
2727 be moved to is live and rearrange lines to make sure that errors
2728 will not put the overlay in an inconsistent state.
2729 (Fdelete_overlay): Cosmetics.
2730
85d0efd1
EZ
27312012-05-28 Eli Zaretskii <eliz@gnu.org>
2732
2733 * w32term.c (my_bring_window_to_top): New function.
2734 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2735 could be different from the original one.
2736 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2737 (Bug#11513)
2738
2739 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2740 by calling BringWindowToTop.
2741
2742 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2743 (WM_EMACS_END): Increase by one.
2744
da92a98c
PE
27452012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2746
2747 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2748 This avoids undefined behavior that might cause the eassert
2749 to not catch an out-of-range value.
2750
74d1f848
JB
27512012-05-28 Juanma Barranquero <lekktu@gmail.com>
2752
2753 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2754 Update dependencies.
2755
9e1a06fc
EZ
27562012-05-27 Eli Zaretskii <eliz@gnu.org>
2757
2758 * bidi.c (bidi_mirror_char): Fix last change.
2759
f3dd7312
AS
27602012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2761
2762 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2763 when referring to sectname field in printf format.
2764
81899c91
PE
27652012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2766
57b81a9f
PE
2767 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2768 Only r_alloc_inhibit_buffer_relocation needed to be added;
2769 the others were already declared.
2770
81899c91
PE
2771 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2772 before checking whether it's out of range. Put the check inside
2773 eassert. See
2774 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2775
33017faf 27762012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2777
2778 * callproc.c (Fcall_process): Restore a line that was accidentally
2779 commented out in the 2011-02-13 change (bug#11547).
2780
33017faf 27812012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2782
2783 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2784 defined on ralloc.c.
2785
2786 * buffer.c [REL_ALLOC]: Remove prototypes of
2787 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2788 they are now on lisp.h.
2789
2790 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2791
2792 * search.c (search_buffer): Use it to inhibit relocation of buffer
2793 text while re_search_2 is doing its job, because re_search_2 is
2794 passed C pointers to buffer text. (Bug#11519)
2795
23415acf
EZ
2796 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2797 Update value to 24.
2798
44e27368
EZ
2799 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2800 state after an additional call to move_it_in_display_line_to, keep
2801 the values of it->max_ascent and it->max_descent found for the
2802 entire line.
2803 (pos_visible_p): Revert the comparison against bottom_y to what it
2804 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2805 (Bug#11464)
2806
c1892f11
PE
28072012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2808
2809 Fix coding-related core dumps with gcc -ftrapv.
2810 The code was computing A - B, where A and B are pointers, and B is
2811 random garbage. This can lead to core dumps on platforms that
2812 have special pointer registers, and it also leads to core dumps on
2813 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2814 A - B only when B is initialized properly.
2815 * coding.c (coding_set_source, coding_set_destination): Return void.
2816 (coding_change_source, coding_change_destinations): New functions,
2817 with the old behaviors of coding_set_source and coding_set_destination.
2818 All callers that need an offset changed to use these new functions.
2819
eb7afdad
GM
28202012-05-26 Glenn Morris <rgm@gnu.org>
2821
2822 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2823
f12fdf02
EZ
28242012-05-26 Eli Zaretskii <eliz@gnu.org>
2825
53a63be6 2826 Extend mouse support on W32 text-mode console.
61b108cc
SM
2827 * xdisp.c (draw_row_with_mouse_face):
2828 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2829
eb3f6f01 2830 * w32console.c: Include window.h.
61b108cc
SM
2831 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2832 New functions.
eb3f6f01
EZ
2833 (initialize_w32_display): Initialize mouse-highlight data.
2834
53a63be6
EZ
2835 * w32inevt.c: Include termchar.h and window.h.
2836 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2837 moves, call note_mouse_highlight. If help_echo changed, call
2838 gen_help_event to produce help-echo message in the echo area.
2839 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2840 highlight info.
2841
4cfd81f6
PE
28422012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2843
2844 * lread.c (read1): Simplify slightly to avoid an overflow warning
2845 with GCC 4.7.0 on x86-64.
2846
4446092a
EZ
28472012-05-26 Eli Zaretskii <eliz@gnu.org>
2848
2849 * bidi.c (bidi_mirror_char): Revert last change: an int is
2850 definitely wide enough here.
2851
42b2a986 28522012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2853
42b2a986 2854 Fix integer width and related bugs (Bug#9874).
eb106a49 2855 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2856 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2857 (string_bytes, check_sblock, allocate_string_data):
2858 (compact_small_strings, Fmake_bool_vector, make_string)
2859 (make_unibyte_string, make_multibyte_string)
2860 (make_string_from_bytes, make_specified_string)
2861 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2862 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2863 (mark_vectorlike):
2864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2865 (allocate_pseudovector):
2866 Use int, not EMACS_INT, where int is wide enough.
2867 (inhibit_garbage_collection, Fgarbage_collect):
2868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2869 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2870 int might not be wide enough.
2871 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2872 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2873 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2874 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2875 (bidi_level_of_next_char, bidi_move_to_visually_next):
2876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2877 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2878 (Fkill_buffer, Fset_buffer_major_mode)
2879 (advance_to_char_boundary, Fbuffer_swap_text)
2880 (Fset_buffer_multibyte, overlays_at, overlays_in)
2881 (overlay_touches_p, struct sortvec, record_overlay_string)
2882 (overlay_strings, recenter_overlay_lists)
2883 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2884 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2885 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2886 (Foverlay_recenter, last_overlay_modification_hooks_used)
2887 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2888 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2889 (validate_region): Omit unnecessary test for b <= e,
2890 since that's guaranteed by the previous test.
d311d28c
PE
2891 (adjust_overlays_for_delete): Avoid pos + length overflow.
2892 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2893 (report_overlay_modification):
2894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2895 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2896 Omit pointer cast, which isn't needed anyway, and doesn't work
2897 after the EMACS_INT -> ptrdiff_t change.
02481186 2898 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2899 * buffer.h: Adjust decls to match defn changes elsewhere.
2900 (struct buffer_text, struct buffer):
2901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2902 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2903 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2904 not int, to avoid needless 32-bit limit on 64-bit hosts.
2905 (exec_byte_code): Use tighter memory-full test, one that checks
2906 for alloca overflow. Don't compute the address of the object just
2907 before an array, as that's not portable. Use EMACS_INT, not
2908 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2909 * callint.c (Fcall_interactively):
2910 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2911 * callproc.c (call_process_kill, Fcall_process):
2912 Don't assume pid_t fits into an Emacs fixnum.
2913 (call_process_cleanup, Fcall_process, child_setup):
2914 Don't assume pid_t fits into int.
2915 (call_process_cleanup, Fcall_process, delete_temp_file)
2916 (Fcall_process_region):
2917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2918 (Fcall_process): Simplify handling of volatile integers.
2919 Use int, not EMACS_INT, where int will do.
2920 * casefiddle.c (casify_object, casify_region, operate_on_word)
2921 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2922 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2923 (casify_object): Avoid integer overflow when overallocating buffer.
2924 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2925 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2926 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2927 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2928 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2929 integers are now checked earlier. All uses replaced with XINT.
2930 (ccl_driver):
2931 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2932 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2933 (ccl_driver, Fregister_code_conversion_map):
2934 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2935 (resolve_symbol_ccl_program): Check that vector header is in range.
2936 Always copy the vector, so that we can check its contents reliably
2937 now rather than having to recheck each instruction as it's being
2938 executed. Check that vector words fit in 'int'.
2939 (ccl_get_compiled_code, Fregister_ccl_program)
2940 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2941 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2942 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2943 contents are in range.
2944 (Fccl_execute_on_string): Check that status is in range.
2945 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2946 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2947 Accept and return EMACS_INT, not int, because callers can pass values
2948 out of 'int' range.
2949 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2950 (multibyte_chars_in_text, parse_str_as_multibyte)
2951 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2952 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2953 (string_escape_byte8, Fget_byte):
2954 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2955 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2956 avoid mishandling large integers.
2957 * character.h: Adjust decls to match defn changes elsewhere.
2958 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2959 (Ffind_charset_region):
2960 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2961 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2962 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2963 Don't assume fixnum fits in int.
d311d28c
PE
2964 (load_charset_map_from_vector, Fmap_charset_chars):
2965 Remove now-unnecessary CHECK_NATNUMs.
2966 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2967 Don't rely on undefined behavior with signed left shift overflow.
2968 Don't assume unsigned int fits into fixnum, or that fixnum fits
2969 into unsigned int. Don't require max_code to be a valid fixnum;
2970 that's not true for gb10830 4-byte on a 32-bit host. Allow
2971 invalid_code to be a cons, for the same reason. Require code_offset
2972 to be a character. Avoid int overflow if max_char is close
2973 to INT_MAX.
2974 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2975 this is intended anyway and avoids some undefined behavior.
2976 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2977 INDEX_TO_CODE_POINT, as that's what it expects.
2978 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2979 * charset.h (DECODE_CHAR): Return int, not unsigned;
2980 this is what was intended anyway, and it avoids undefined behavior.
2981 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2982 integer-overflow issues.
2983 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2984 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2985 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2986 * chartab.c (Fmake_char_table, Fset_char_table_range)
2987 (uniprop_get_decoder, uniprop_get_encoder):
2988 Don't assume fixnum fits in int.
2989 * cmds.c (move_point): New function, that does the gist of
2990 Fforward_char and Fbackward_char, but does so while checking
2991 for integer overflow more accurately.
c96e5d6a 2992 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2993 (Fforward_line, Fend_of_line, internal_self_insert)
2994 (internal_self_insert):
2995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2996 Fix a FIXME, by checking for integer overflow when calculating
2997 target_clm and actual_clm.
2998 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2999 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3000 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3001 (coding_alloc_by_making_gap, alloc_destination)
3002 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3003 (encode_coding_utf_16, detect_coding_emacs_mule)
3004 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3005 (detect_coding_iso_2022, decode_coding_iso_2022)
3006 (encode_invocation_designation, encode_designation_at_bol)
3007 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3008 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3009 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3010 (encode_coding_ccl, encode_coding_raw_text)
3011 (detect_coding_charset, decode_coding_charset)
3012 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3013 (produce_composition, produce_charset, produce_annotation)
3014 (decode_coding, handle_composition_annotation)
3015 (handle_charset_annotation, consume_chars, decode_coding_gap)
3016 (decode_coding_object, encode_coding_object, detect_coding_system)
3017 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3018 (code_convert_region, code_convert_string)
8f50130c
PE
3019 (Fdefine_coding_system_internal)
3020 (coding_set_source, coding_set_destination):
d311d28c
PE
3021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3022 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3023 (Fdefine_coding_system_internal):
3024 Don't assume fixnums fit in int.
3025 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3026 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3027 (Funencodable_char_position, Fcheck_coding_systems_region)
3028 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3030 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3031 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3032 Don't access memory outside of the args array.
d311d28c 3033 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3034 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3035 result of ENCODE_CHAR.
d311d28c
PE
3036 * coding.h: Adjust decls to match defn changes elsewhere.
3037 (struct coding_system):
3038 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3039 * composite.c (get_composition_id, find_composition)
3040 (run_composition_function, update_compositions)
3041 (compose_text, composition_gstring_put_cache)
3042 (composition_gstring_p, composition_gstring_width)
3043 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3044 (composition_compute_stop_pos, composition_reseat_it)
3045 (composition_update_it, struct position_record)
3046 (find_automatic_composition, composition_adjust_point)
3047 (Fcomposition_get_gstring, Ffind_composition_internal):
3048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3049 (update_compositions):
3050 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3051 * composite.h: Adjust decls to match defn changes elsewhere.
3052 (struct composition):
3053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3054 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3055 Do not attempt to compute the address of the object just before a
3056 buffer; this is not portable.
3057 (Faref, Faset):
3058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3059 (Faset): Use int, not EMACS_INT, where int is wide enough.
3060 (Fstring_to_number): Don't assume fixnums fit in int.
3061 (Frem): Don't assume arg is nonnegative.
3062 * dbusbind.c (xd_append_arg): Check for integers out of range.
3063 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3064 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3065 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3066 (xd_get_connection_references): Return ptrdiff_t, not int.
3067 All uses changed.
3068 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3069 (xd_read_message_1):
3070 Use int, not unsigned, where the dbus API uses int.
3071 (Fdbus_message_internal): Don't overflow mtype.
3072 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3073 * dired.c (directory_files_internal, file_name_completion, scmp)
3074 (file_name_completion_stat):
3075 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3076 (file_name_completion): Don't overflow matchcount.
3077 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3078 * dispextern.h: Adjust decls to match defn changes elsewhere.
3079 (struct text_pos, struct glyph, struct bidi_saved_info)
3080 (struct bidi_string_data, struct bidi_it, struct composition_it)
3081 (struct it):
3082 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3083 (struct display_pos, struct composition_it, struct it):
3084 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3085 * dispnew.c (increment_matrix_positions)
3086 (increment_row_positions, mode_line_string)
3087 (marginal_area_string):
3088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3089 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3090 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3091 (duration_to_sec_usec): New function, to check for overflow better.
3092 (Fsleep_for, sit_for): Use it.
3093 * doc.c (get_doc_string, store_function_docstring):
3094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3095 (get_doc_string, Fsnarf_documentation):
3096 Use int, not EMACS_INT, where int is wide enough.
3097 (get_doc_string):
3098 Use SAFE_ALLOCA, not alloca.
3099 Check for overflow when converting EMACS_INT to off_t.
3100 * doprnt.c (doprnt):
3101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3102 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3103 Don't assume uid_t fits into fixnum.
3104 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3105 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3106 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3107 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3108 (general_insert_function)
3109 (Finsert_char, make_buffer_string, make_buffer_string_both)
3110 (update_buffer_properties, Fbuffer_substring)
3111 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3112 (Fsubst_char_in_region, check_translation)
3113 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3114 (transpose_markers, Ftranspose_regions):
3115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3116 (clip_to_bounds): Move to lisp.h as an inline function).
3117 (Fconstrain_to_field): Don't assume integers are nonnegative.
3118 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3119 (Fsubst_char_in_region, Fsave_restriction):
3120 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3121 (Femacs_pid): Don't assume pid_t fits into fixnum.
3122 (lo_time): Use int, not EMACS_INT, when int suffices.
3123 (lisp_time_argument): Check for usec out of range.
3124 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3125 (Fuser_login_name, Fuser_full_name): Signal an error
3126 if a uid argument is out of range, rather than relying on
3127 undefined behavior.
c8d5c857
PE
3128 (Fformat_time_string): Remove now-unnecessary check.
3129 lisp_time_argument checks for out-of-range usec now.
243e0530 3130 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3131 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3132 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3133 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3134 (init_cmdargs, Fdump_emacs):
3135 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3136 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3137 the bottom (typically) 32 bits of the fixnum.
3138 * eval.c (specpdl_size, call_debugger):
3139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3140 (when_entered_debugger, Fbacktrace_debug):
3141 Don't assume fixnum can fit in int.
3142 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3143 the object just before a buffer; this is not portable.
3144 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3145 (grow_specpdl, unbind_to):
3146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3147 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3148 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3149 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3150 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3151 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3153 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3154 (a_write, e_write):
3155 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3156 (Fcopy_file, non_regular_nbytes, read_non_regular)
3157 (Finsert_file_contents):
3158 Use int, not EMACS_INT, where int is wide enough.
3159 (READ_BUF_SIZE): Verify that it fits in int.
3160 (Finsert_file_contents): Check that counts are in proper range,
3161 rather than assuming fixnums fit into ptrdiff_t etc.
3162 Don't assume fixnums fit into int.
125b3835 3163 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3164 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3165 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3166 (string_char_to_byte, string_byte_to_char)
3167 (string_make_multibyte, string_to_multibyte)
3168 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3169 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3170 (substring_both, Fdelete, internal_equal, Ffillarray)
3171 (Fclear_string, mapcar1)
3172 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3173 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3174 (larger_vector, make_hash_table, maybe_resize_hash_table)
3175 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3176 (Fmaphash, secure_hash):
3177 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3178 (concat): Check for string index and length overflow.
3179 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3180 (Frequire):
3181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3182 (larger_vector): New API (vec, incr_min, size_max) replaces old
3183 one (vec, new_size, init). This catches size overflow.
3184 INIT was removed because it was always Qnil.
3185 All callers changed.
3186 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3187 the upper bound on a hash table index size.
3188 (make_hash_table, maybe_resize_hash_table): Use it.
3189 (secure_hash): Computer start_byte and end_byte only after
3190 they're known to be in ptrdiff_t range.
3191 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3192 (Ffont_get_glyphs, Ffont_at):
3193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3194 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3195 (Flist_fonts, Fopen_font):
3196 Don't assume fixnum can fit in int.
3197 (check_gstring): Don't assume index can fit in int.
3198 (font_match_p): Check that fixnum is a character, not a nonnegative
3199 fixnum, since the later code needs to stuff it into an int.
3200 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3201 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3202 conversion overflow issues.
3203 (Fopen_font): Check for integer out of range.
3204 (Ffont_get_glyphs): Don't assume index can fit in int.
3205 * font.h: Adjust decls to match defn changes elsewhere.
3206 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3207 integer overflow.
3208 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3209 printmax_t, where ptrdiff_t is wide enough.
3210 (Finternal_char_font):
3211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3212 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3213 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3214 (Fset_frame_position, x_set_frame_parameters)
3215 (x_set_line_spacing, x_set_border_width)
3216 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3217 Check that fixnums are in proper range for system types.
3218 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3220 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3221 Use SAFE_ALLOCA_LISP, not alloca.
3222 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3223 intptr_t is wide enough.
3224 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3225 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3226 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3227 Check for fixnum out of range.
3228 * ftfont.c (ftfont_list): Don't assume index fits in int.
3229 Check that fixnums are in proper range for system types.
3230 (ftfont_shape_by_flt):
3231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3232 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3233 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3234 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3235 Check that fixnums are in proper range for system types.
3236 * gnutls.h: Adjust decls to match defn changes elsewhere.
3237 * gtkutil.c (xg_dialog_run):
3238 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3239 (update_frame_tool_bar):
3240 Check that fixnums are in proper range for system types.
3241 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3242 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3243 * indent.c (last_known_column, last_known_column_point):
3244 (current_column_bol_cache):
3245 (skip_invisible, current_column, check_display_width):
3246 (check_display_width, scan_for_column, current_column_1)
3247 (Findent_to, Fcurrent_indentation, position_indentation)
3248 (indented_beyond_p, Fmove_to_column, compute_motion):
3249 (Fcompute_motion, Fvertical_motion):
3250 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3251 (last_known_column_modified): Use EMACS_INT, not int.
3252 (check_display_width):
3253 (Fcompute_motion):
3254 Check that fixnums and floats are in proper range for system types.
3255 (compute_motion): Don't assume index or fixnum fits in int.
3256 (compute_motion, Fcompute_motion):
3257 Use int, not EMACS_INT, when it is wide enough.
3258 (vmotion): Omit local var start_hpos that is always 0; that way
3259 we don't need to worry about overflow in expressions involving it.
3260 * indent.h: Adjust decls to match defn changes elsewhere.
3261 (struct position):
3262 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3263 Use int, not EMACS_INT, where int is wide enough.
3264 Remove unused members ovstring_chars_done and tab_offset;
3265 all uses removed.
3266 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3267 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3268 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3269 (make_gap, copy_text, insert, insert_and_inherit)
3270 (insert_before_markers, insert_before_markers_and_inherit)
3271 (insert_1, count_combining_before, count_combining_after)
3272 (insert_1_both, insert_from_string)
3273 (insert_from_string_before_markers, insert_from_string_1)
3274 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3275 (adjust_after_replace, adjust_after_insert, replace_range)
3276 (replace_range_2, del_range, del_range_1, del_range_byte)
3277 (del_range_both, del_range_2, modify_region)
3278 (prepare_to_modify_buffer, signal_before_change)
3279 (signal_after_change, Fcombine_after_change_execute):
3280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3281 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3282 (balance_an_interval, split_interval_right, split_interval_left)
3283 (find_interval, next_interval, update_interval)
3284 (adjust_intervals_for_insertion, delete_node, delete_interval)
3285 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3286 (static_offset_intervals, offset_intervals)
3287 (merge_interval_right, merge_interval_left, make_new_interval)
3288 (graft_intervals_into_buffer, temp_set_point_both)
3289 (temp_set_point, set_point, adjust_for_invis_intang)
3290 (set_point_both, move_if_not_intangible, get_property_and_range)
3291 (get_local_map, copy_intervals, copy_intervals_to_string)
3292 (compare_string_intervals, set_intervals_multibyte_1):
3293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3294 * intervals.h: Adjust decls to match defn changes elsewhere.
3295 (struct interval):
3296 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3297 * keyboard.c (this_command_key_count, this_single_command_key_start)
3298 (before_command_key_count, before_command_echo_length, echo_now)
3299 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3300 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3301 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3302 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3303 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3304 (last_non_minibuf_size, last_point_position, echo_truncate)
3305 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3306 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3307 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3308 (stuff_buffered_input):
3309 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3310 (last_auto_save, command_loop_1, read_char):
3311 Use EMACS_INT, not int, to avoid integer overflow.
3312 (record_char): Avoid overflow in total_keys computation.
3313 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3314 * keyboard.h: Adjust decls to match defn changes elsewhere.
3315 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3316 (Fkey_description, Fdescribe_vector, Flookup_key):
3317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3318 (click_position): New function, to check that positions are in range.
3319 (Fcurrent_active_maps):
3320 (describe_command):
3321 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3322 (Faccessible_keymaps, Fkey_description):
3323 (preferred_sequence_p):
3324 Don't assume fixnum can fit into int.
3325 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3326 Check for integer overflow in size calculations.
3327 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3328 avoid mishandling large integers.
3329 * lisp.h: Adjust decls to match defn changes elsewhere.
3330 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3331 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3332 (struct Lisp_Marker):
3333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3334 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3335 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3336 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3337 All callers changed.
3338 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3339 Assume the arg has valid form, since it always does.
3340 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3341 unsigned integer system type.
3342 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3343 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3345 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3346 (duration_to_sec_usec): New decl.
3347 * lread.c (read_from_string_index, read_from_string_index_byte)
3348 (read_from_string_limit, readchar, unreadchar, openp)
3349 (read_internal_start, read1, oblookup):
3350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3351 (Fload, readevalloop, Feval_buffer, Feval_region):
3352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3353 (openp): Check for out-of-range argument to 'access'.
3354 (read1): Use int, not EMACS_INT, where int is wide enough.
3355 Don't assume fixnum fits into int.
6efdadfd 3356 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3357 (read_filtered_event): Use duration_to_sec_usec
3358 to do proper overflow checking on durations.
d311d28c
PE
3359 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3360 in size calculation.
3361 (Fexecute_kbd_macro):
3362 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3363 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3364 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3365 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3366 (set_marker_both, set_marker_restricted_both, marker_position)
3367 (marker_byte_position, Fbuffer_has_markers_at):
3368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3369 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3370 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3371 It now merely ensures that the menu is large enough, without
3372 necessarily growing it, as this avoids some integer overflow issues.
3373 All callers changed.
3374 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3376 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3377 Use SAFE_ALLOCA_LISP, not alloca.
3378 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3379 to EMACS_INT. Check that fixnums are in proper range for system types.
3380 * minibuf.c (minibuf_prompt_width, string_to_object)
3381 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3382 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3384 (get_minibuffer, read_minibuf_unwind):
3385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3386 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3387 this simplifies overflow checking. All callers changed.
3388 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3389 (Ftest_completion):
3390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3391 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3392 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3393 Check that fixnums are in proper range for system types.
3394 (Fx_create_frame, Fx_show_tip):
3395 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3396 * nsfont.m (ns_findfonts, nsfont_list_family):
3397 Don't assume fixnum fits in long.
3398 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3399 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3400 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3401 wide enough.
17fdb222 3402 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3403 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3404 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3405 (PRINTDECLARE, PRINTPREPARE):
3406 (strout, print_string):
3407 (print, print_preprocess, print_check_string_charset_prop)
3408 (print_object):
3409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3410 (PRINTDECLARE):
3411 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3413 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3414 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3415 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3416 (print_error_message): Use SAFE_ALLOCA, not alloca.
3417 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3418 (print_depth, new_backquote_output, print_number_index):
3419 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3420 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3421 (Fset_process_window_size, Fformat_network_address)
3422 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3423 (sigchld_handler):
d311d28c 3424 Check that fixnums are in proper range for system types.
d44287d4 3425 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3426 Check for process-ids out of pid_t range rather than relying on
3427 undefined behavior.
e4d81efc 3428 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3429 (Fformat_network_address, read_process_output, send_process)
3430 (Fprocess_send_region, status_notify):
3431 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3432 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3433 (wait_reading_process_output, read_process_output, exec_sentinel):
3434 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3435 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3436 (Faccept_process_output): Use duration_to_sec_usec to do proper
3437 overflow checking on durations.
dde14581
PE
3438 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3439 Don't assume pid_t fits in int.
02481186
PE
3440 * process.h (struct Lisp_Process): Members tick and update_tick
3441 are now of type EMACS_INT, not int.
b62b53e8
PE
3442 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3443 configured --with-wide-int.
d311d28c
PE
3444 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3445 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3446 * search.c (looking_at_1, string_match_1):
3447 (fast_string_match, fast_c_string_match_ignore_case)
3448 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3449 (scan_newline, find_before_next_newline, search_command)
3450 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3451 (set_search_regs, wordify):
3452 (Freplace_match):
3453 (Fmatch_data):
3454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3455 (string_match_1, search_buffer, set_search_regs):
3456 (Fmatch_data):
3457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3458 (wordify): Check for overflow in size calculation.
3459 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3460 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3461 Check that fixnums are in proper range for system types.
3462 * sound.c (struct sound_device)
3463 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3465 (Fplay_sound_internal):
3466 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3467 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3468 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3469 (Fparse_partial_sexp):
3470 Don't assume fixnums can fit in int.
3471 (struct lisp_parse_state, find_start_pos, find_start_value)
3472 (find_start_value_byte, find_start_begv)
3473 (update_syntax_table, char_quoted, dec_bytepos)
3474 (find_defun_start, prev_char_comend_first, back_comment):
3475 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3476 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3478 (Finternal_describe_syntax_value): Check that match_lisp is a
3479 character, not an integer, since the code stuffs it into int.
3480 (scan_words, scan_sexps_forward):
3481 Check that fixnums are in proper range for system types.
3482 (Fforward_word):
3483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3484 (scan_sexps_forward):
3485 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3486 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3487 * syntax.h: Adjust decls to match defn changes elsewhere.
3488 (struct gl_state_s):
3489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3490 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3491 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3492 * sysdep.c (wait_for_termination_1, wait_for_termination)
3493 (interruptible_wait_for_termination, mkdir):
3494 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3495 (emacs_read, emacs_write):
3496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3497 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3498 and double all fit in int.
d311d28c
PE
3499 * term.c (set_tty_color_mode):
3500 Check that fixnums are in proper range for system types.
3501 * termhooks.h (struct input_event):
3502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3503 * textprop.c (validate_interval_range, interval_of)
3504 (Fadd_text_properties, set_text_properties_1)
3505 (Fremove_text_properties, Fremove_list_of_text_properties)
3506 (Ftext_property_any, Ftext_property_not_all)
3507 (copy_text_properties, text_property_list, extend_property_ranges)
3508 (verify_interval_modification):
3509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3510 (Fnext_single_char_property_change)
3511 (Fprevious_single_char_property_change):
3512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3513 (copy_text_properties):
3514 Check for integer overflow in index calculation.
d311d28c
PE
3515 * undo.c (last_boundary_position, record_point, record_insert)
3516 (record_delete, record_marker_adjustment, record_change)
3517 (record_property_change):
3518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3519 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3521 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3522 (Fx_hide_tip, Fx_file_dialog):
3523 * w32menu.c (set_frame_menubar):
3524 Use ptrdiff_t, not int, for consistency with rest of code.
3525 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3526 (select_window, Fdelete_other_windows_internal)
3527 (window_scroll_pixel_based, window_scroll_line_based)
3528 (Frecenter, Fset_window_configuration):
3529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3530 (Fset_window_hscroll, run_window_configuration_change_hook)
3531 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3532 (Fscroll_other_window, Frecenter):
d311d28c
PE
3533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3534 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3535 Don't assume fixnum fits in int.
3536 (Fset_window_scroll_bars):
3537 Check that fixnums are in proper range for system types.
3538 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3539 (string_pos, c_string_pos, number_of_chars, init_iterator)
3540 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3541 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3542 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3543 (face_before_or_after_it_pos, handle_invisible_prop)
3544 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3545 (display_prop_intangible_p, string_buffer_position_lim)
3546 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3547 (get_overlay_strings_1, get_overlay_strings)
3548 (iterate_out_of_display_property, forward_to_next_line_start)
3549 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3550 (get_next_display_element, set_iterator_to_next)
3551 (get_visually_first_element, compute_stop_pos_backwards)
3552 (handle_stop_backwards, next_element_from_buffer)
3553 (move_it_in_display_line_to, move_it_in_display_line)
3554 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3555 (add_to_log, message_dolog, message_log_check_duplicate)
3556 (message2, message2_nolog, message3, message3_nolog
3557 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3558 (current_message_1, truncate_echo_area, truncate_message_1)
3559 (set_message, set_message_1, store_mode_line_noprop)
3560 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3561 (text_outside_line_unchanged_p, check_point_in_composition)
3562 (reconsider_clip_changes)
3563 (redisplay_internal, set_cursor_from_row, try_scrolling)
3564 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3565 (redisplay_window, find_last_unchanged_at_beg_row)
3566 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3567 (trailing_whitespace_p, find_row_edges, display_line)
3568 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3569 (display_mode_element, store_mode_line_string)
3570 (pint2str, pint2hrstr, decode_mode_spec)
3571 (display_count_lines, display_string, draw_glyphs)
3572 (x_produce_glyphs, x_insert_glyphs)
3573 (rows_from_pos_range, mouse_face_from_buffer_pos)
3574 (fast_find_string_pos, mouse_face_from_string_pos)
3575 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3577 (safe_call, init_from_display_pos, handle_fontified_prop)
3578 (handle_single_display_spec, load_overlay_strings)
3579 (with_echo_area_buffer, setup_echo_area_for_printing)
3580 (display_echo_area, echo_area_display)
3581 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3582 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3583 (redisplay_window, dump_glyph_row, display_mode_line)
3584 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3585 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3586 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3587 (handle_single_display_spec, build_desired_tool_bar_string)
3588 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3589 (get_specified_cursor_type):
3590 Check that fixnums are in proper range for system types.
3591 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3592 (Flookup_image_map):
3593 Don't assume fixnums fit in int.
3594 (compare_overlay_entries):
3595 Avoid mishandling comparisons due to subtraction overflow.
3596 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3597 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3598 (handle_tool_bar_click):
3599 Use int, not unsigned, since we prefer signed and the signedness
3600 doesn't matter here.
3601 (get_next_display_element, next_element_from_display_vector):
3602 Use int, not EMACS_INT, when int is wide enough.
3603 (start_hourglass): Use duration_to_sec_usec to do proper
3604 overflow checking on durations.
3605 * xfaces.c (Fbitmap_spec_p):
3606 Check that fixnums are in proper range for system types.
3607 (compare_fonts_by_sort_order):
3608 Avoid mishandling comparisons due to subtraction overflow.
3609 (Fx_family_fonts, realize_basic_faces):
3610 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3611 (Fx_family_fonts):
3612 Don't assume fixnum fits in int.
3613 Use SAFE_ALLOCA_LISP, not alloca.
3614 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3615 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3616 (face_at_buffer_position, face_for_overlay_string)
3617 (face_at_string_position):
3618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3619 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3620 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3621 (Fx_show_tip):
3622 Check that fixnums are in proper range for system types.
3623 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3624 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3626 (Fx_change_window_property): Don't assume fixnums fit in int.
3627 * xfont.c (xfont_chars_supported):
3628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3629 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3630 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3631 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3632 * xml.c (parse_region):
3633 * xrdb.c (magic_file_p):
3634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3635 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3636 (x_get_local_selection, x_reply_selection_request)
3637 (x_handle_selection_request, wait_for_property_change):
3638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3639 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3640 short is wide enough.
3641 (x_send_client_event): Don't assume fixnum fits in int.
3642 * xterm.c (x_x_to_emacs_modifiers):
3643 Don't assume EMACS_INT overflows nicely into int.
3644 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3645 may come from Lisp.
3646 (handle_one_xevent): NATNUMP can eval its arg twice.
3647 (x_connection_closed):
3648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3649 * xterm.h: Adjust decls to match defn changes elsewhere.
3650 (struct scroll_bar): Use struct vectorlike_header
3651 rather than rolling our own approximation.
3652 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3653
c6574eb5
GM
36542012-05-25 Glenn Morris <rgm@gnu.org>
3655
3656 * lisp.mk (lisp): Update for more files being compiled now.
3657
e8d32c7e
SM
36582012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3659
48def666
SM
3660 * lread.c: Remove `read_pure' which makes no difference.
3661 (read_pure): Remove var.
3662 (unreadpure): Remove function.
3663 (readevalloop): Don't call read_list with -1 flag.
3664 (read1, read_vector): Don't test read_pure any more.
3665 (read_list): Simplify.
3666
e8d32c7e
SM
3667 * fileio.c, character.h: Minor style tweaks.
3668
4b2addb7
DA
36692012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3670
3671 * window.h (clip_changed): Remove useless declaration.
3672
584461b2
JB
36732012-05-22 Juanma Barranquero <lekktu@gmail.com>
3674
3675 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3676 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3677
34374650
PE
36782012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3679
3680 Remove src/m/*.
3681 This directory predates autoconf and is no longer needed nowadays.
3682 Move its few remaining bits of functionality to where they're needed.
3683 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3684 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3685 * m/template.h: Remove.
3686 * Makefile.in (M_FILE): Remove. All uses removed.
3687 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3688 * lisp.h (USE_LSB_TAG):
3689 * mem-limits.h (EXCEEDS_LISP_PTR):
3690 Use VAL_MAX, not VALBITS, in #if.
3691 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3692 (EMACS_UINT): Define unconditionally now.
3693 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3694 (BITS_PER_EMACS_INT): New constants, replacing
3695 what used to be in config.h, but not useful in #if.
3696 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3697 define them any more.
3698 (VAL_MAX): New macro.
3699 (VALMASK): Use it.
3700 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3701 BITS_PER_EMACS_INT, in #if.
3702 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3703 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3704 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3705 * s/ms-w32.h (DATA_START):
3706 Move here from removed file m/intel386.h.
3707 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3708 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3709
261cb4bb
PE
37102012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3711
3712 Assume C89 or later.
3713 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3714 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3715 (xrealloc):
3716 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3717 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3718 * textprop.c, tparam.c (NULL): Remove.
3719 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3720 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3721 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3722 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3723 * xterm.c (input_signal_count): Assume volatile works.
3724
ff23cd9f
KB
37252012-05-21 Ken Brown <kbrown@cornell.edu>
3726
3727 * xgselect.c (xg_select): Fix first argument in call to 'select'
3728 (bug#11508).
3729
1b170bc6
KB
37302012-05-20 Ken Brown <kbrown@cornell.edu>
3731
3732 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3733 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3734
b2f4d39f
KB
37352012-05-19 Ken Brown <kbrown@cornell.edu>
3736
3737 * xfns.c (x_in_use): Remove `static' qualifier.
3738 * xterm.h (x_in_use): Declare.
3739 * xgselect.c: Include xterm.h.
3740 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3741 and `display_arg' (bug#9754).
3742
003fdae2
PE
37432012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3744
9232a6d9
PE
3745 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3746
003fdae2
PE
3747 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3748 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3749
784b56e2
EZ
37502012-05-18 Eli Zaretskii <eliz@gnu.org>
3751
3752 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3753
3754 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3755 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3756
3757 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3758 reference to image_cache->refcount.
3759 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3760
a0a79cde
JL
37612012-05-17 Juri Linkov <juri@jurta.org>
3762
3763 * search.c (Fword_search_regexp, Fword_search_backward)
3764 (Fword_search_forward, Fword_search_backward_lax)
3765 (Fword_search_forward_lax): Move functions to isearch.el
3766 (bug#10145, bug#11381).
3767
b0572523
PE
37682012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3769
3770 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3771
9660f5fc
SM
37722012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3773
3774 * lread.c (init_obarray): Declare Qt and Qnil as special.
3775
4374de83
GM
37762012-05-14 Glenn Morris <rgm@gnu.org>
3777
3778 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3779 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3780
dc44c39a
PE
37812012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3782
078c97cb
PE
3783 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3784
dc44c39a
PE
3785 * unexaix.c: Port to more-recent AIX compilers.
3786 (report_error, report_error_1, make_hdr, copy_sym)
3787 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3788 Make arguments const char *, not char *, to avoid violations of C
3789 standard and to fix some AIX warnings reported by Gilles Pion.
3790
e18afed7 37912012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3792
3793 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3794 already have overlays loaded.
3795 (handle_single_display_spec): Before returning without displaying
3796 fringe bitmap, synchronize the bidi iterator with the main display
3797 iterator, by calling iterate_out_of_display_property.
3798 (iterate_out_of_display_property): Detect buffer iteration by
3799 testing that it->string is a Lisp string.
3800 (get_next_display_element): When the current object is exhausted,
3801 and there's something on it->stack, call set_iterator_to_next to
3802 proceed with what's on the stack, instead of returning zero.
3803 (set_iterator_to_next): If called at the end of a Lisp string,
3804 proceed to consider_string_end without incrementing string
3805 position. Don't increment display vector index past the end of
3806 the display vector. (Bug#11417)
c8fb9dc6
EZ
3807 (pos_visible_p): Don't report a position visible when move_it_to
3808 stopped at the last line of window, which happens to be scanned
3809 backwards by the bidi iteration. (Bug#11464)
ac268e67 3810
e18afed7 38112012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3812
3813 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3814 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3815 are on a TTY, and thus unable to display on the fringes.
3816 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3817 so we need to signal to the caller that this is a "replacing"
3818 display spec. This fixes display when the spec is invalid or we
3819 are on a TTY.
3820
e18afed7 38212012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3822
3823 * unexaix.c (make_hdr): Fix typo in prototype.
3824 This bug broke the build on AIX. Problem reported by Gilles Pion.
3825
9d0a235a
MA
38262012-05-14 Michael Albinus <michael.albinus@gmx.de>
3827
3828 * keyboard.c (kbd_buffer_get_event): Read special events also in
3829 batch mode. (Bug#11415)
3830
9e6b06ed
GM
38312012-05-12 Glenn Morris <rgm@gnu.org>
3832
3833 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3834
c1a1d7a3
EZ
38352012-05-12 Eli Zaretskii <eliz@gnu.org>
3836
3837 * lisp.mk (lisp): Add newcomment.elc.
3838
3fe7cdc8
GM
38392012-05-12 Glenn Morris <rgm@gnu.org>
3840
3841 * Makefile.in (MKDIR_P): New, set by configure.
3842 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3843
53f7d2c0
PE
38442012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3845
3846 Remove unused function hourglass_started.
3847 * dispextern.h (hourglass_started):
3848 * w32fns.c (hourglass_started):
3849 * xdisp.c (hourglass_started): Remove.
3850
75aafb17
JB
38512012-05-10 Juanma Barranquero <lekktu@gmail.com>
3852
3853 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3854 Update dependencies.
3855
12959e8e
PE
38562012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3857
97107e2e
PE
3858 * xgselect.c (xg_select): Put maxfds+1 into a var.
3859 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3860
12959e8e
PE
3861 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3862
836d29b3
DA
38632012-05-10 Dave Abrahams <dave@boostpro.com>
3864
3865 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3866 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3867
5cb67954
MA
38682012-05-09 Michael Albinus <michael.albinus@gmx.de>
3869
3870 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3871 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3872 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3873 Initialize xd_registered_buses.
3874
3478ec45
PE
38752012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3876
b263a6b0
PE
3877 Untag more efficiently if USE_LSB_TAG.
3878 This is based on a proposal by YAMAMOTO Mitsuharu in
3879 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3880 For an admittedly artificial (nth 8000 longlist) benchmark on
3881 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3882 Emacs's overall text size by 1%.
3883 * lisp.h (XUNTAG): New macro.
3884 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3885 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3886 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3887 * eval.c (Fautoload):
3888 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3889 * frame.h (XFRAME): Use XUNTAG.
3890
3478ec45
PE
3891 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3892 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3893 Remove unportable assumptions about print widths of types like
3894 dbus_uint32_t.
3895 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3896 intptr_t when converting between pointer and integer, to avoid GCC
3897 warnings about wrong width.
3898
666b903b 38992012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3900
3901 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3902 stack for each reader_thread, instead of defaulting to 8MB
3903 determined by the linker. This avoids failures in creating
3904 subprocesses on Windows 7, see the discussion in this thread:
3905 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3906
b120cc17
JC
39072012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3908
3909 Fix up display of the *Minibuf-0* buffer in the mini window.
3910 * keyboard.c (read_char): Don't clear the echo area if there's no
3911 message to clear.
3912 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3913 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3914
9a4b36f8
MA
39152012-05-07 Michael Albinus <michael.albinus@gmx.de>
3916
3917 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3918 batch mode.
3919
e5f9458f
CY
39202012-05-06 Chong Yidong <cyd@gnu.org>
3921
3922 * lisp.mk (lisp): Update.
3923
eceeb5fc 39242012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3925
3926 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3927
71873e2b
SM
39282012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3929
3930 * data.c (PUT_ERROR): New macro.
3931 (syms_of_data): Use it. Add new error type `user-error'.
3932 * undo.c (user_error): New function.
3933 (Fprimitive_undo): Use it.
3934 * print.c (print_error_message): Adjust print style for `user-error'.
3935 * keyboard.c (user_error): New function.
3936 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3937
ab0fa4e4
PE
39382012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3939
3940 Do not limit current-time-string to years 1000..9999.
3941 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3942 (Fcurrent_time_string): Support any year that is supported by the
3943 underlying localtime representation. Don't use asctime, as it
3944 has undefined behavior for years outside the range -999..9999.
3945
7ed806a7
PE
39462012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3947
3948 Fix race conditions involving setenv, gmtime, localtime, asctime.
3949 Without this fix, interrupts could mess up code that uses these
3950 nonreentrant functions, since setting TZ invalidates existing
3951 tm_zone or tzname values, and since most of these functions return
3952 pointers to static storage.
3953 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3954 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3955 Grow the critical sections to include not just invoking
3956 localtime/gmtime, but also accessing these functions' results
3957 including their tm_zone values if any, and any related TZ setting.
3958 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3959 so that the struct tm is saved in the critical section.
3960 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3961 motivated by the fact that memory allocation needs to be outside
3962 the critical section.
3963
0c16dfed
DA
39642012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3965
3966 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3967 with RESET_INTERVAL.
3968
3969 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3970 Remove duplicated buffer name initialization.
3971
3f83ace8
JM
39722012-05-02 Jim Meyering <jim@meyering.net>
3973
3974 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3975
c7b8541e
JM
3976 * xfns.c (x_window): Use xstrdup (Bug#11375).
3977
90207a15 39782012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3979
3980 * xdisp.c (pos_visible_p): If already at a newline from the
3981 display string before the 'while' loop, don't walk back the glyphs
3982 from it3.glyph_row. Solves assertion violation when the display
3983 string begins with a newline (egg.el). (Bug#11367)
3984
b593d6a9
AH
39852012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3986
3987 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3988 Move to simple.el.
3989
4737362e
GM
39902012-05-01 Glenn Morris <rgm@gnu.org>
3991
99cf43f9
GM
3992 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3993 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3994 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3995 All were removed before 23.1.
3996
9311dcff
GM
3997 * dispnew.c: Remove HAVE_LIBNCURSES test;
3998 it is always true on relevant platforms.
3999
4d5c6349
GM
4000 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4001 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4002
4737362e
GM
4003 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4004
74dd3a6b
AS
40052012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4006
4007 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4008 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4009 Remove.
4010
13c379ee
PE
40112012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4012
4013 Do not avoid creating empty evaporating overlays (Bug#9642).
4014 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4015 That is, do not delete an evaporating overlay if it becomes
4016 empty after its bounds are adjusted to fit within its buffer.
4017 This fix caused other problems, and I'm reverting it until we get
4018 to the bottom of them.
4019
a8e7d6d7 40202012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4021
4022 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4023
a8e7d6d7 40242012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4025
4026 * xdisp.c (pos_visible_p): If the window start position is beyond
4027 ZV, start the display from buffer beginning. Prevents assertion
4028 violation in init_iterator when the minibuffer window is scrolled
4029 via the scroll bar.
4030
4031 * window.c (window_scroll_pixel_based): Likewise.
4032
a8e7d6d7 40332012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4034
4035 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4036
a8e7d6d7 40372012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4038
4039 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4040 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4041
a8e7d6d7 40422012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4043
b593d6a9
AH
4044 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4045 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4046
1c6900d9
EZ
40472012-04-26 Eli Zaretskii <eliz@gnu.org>
4048
4c3fa1d9
EZ
4049 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4050 display element, check also the underlying string or buffer
4051 character. (Bug#11341)
4052
1c6900d9
EZ
4053 * w32menu.c: Include w32heap.h.
4054 (add_menu_item): If the call to AppendMenuW (via
4055 unicode_append_menu) fails, disable Unicode menus only if we are
4056 running on Windows 9X/Me.
4057
42bf8205
AS
40582012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4059
4060 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4061 (xgetint): Add missing shift for LSB tags.
4062
b1bac16e
MR
40632012-04-24 Martin Rudalics <rudalics@gmx.at>
4064
4065 * keyboard.c (read_char): Don't wipe echo area for select window
4066 events: These might get delayed via `mouse-autoselect-window'
4067 (Bug#11304).
4068
d69621cc
JB
40692012-04-24 Juanma Barranquero <lekktu@gmail.com>
4070
4071 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4072 manipulation of :loaded-from data.
4073
02fd101b
JB
40742012-04-23 Juanma Barranquero <lekktu@gmail.com>
4075
4076 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4077 now a cons (bug#11311).
4078
888bec30
PE
40792012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4080
89a438bd
PE
4081 Do not create empty overlays with the evaporate property (Bug#9642).
4082 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4083 if it becomes empty after its bounds are adjusted to fit within
4084 its buffer. Without this fix, in a nonempty buffer (let ((o
4085 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4086 yields an empty overlay that has the evaporate property, which is
4087 not supposed to happen.
4088
1068fe4d
PE
4089 Fix minor GTK3 problems found by static checking.
4090 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4091 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4092 (struct _EmacsFixedClass, emacs_fixed_get_type):
4093 Move decls here from emacsgtkfixed.h, since they needn't be public.
4094 (emacs_fixed_get_type): Now static.
4095 (emacs_fixed_class_init): Omit unused local.
4096 (emacs_fixed_child_type): Remove; unused.
4097 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4098 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4099 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4100 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4101 (EMACS_FIXED_GET_CLASS): Remove; unused.
4102 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4103
888bec30
PE
4104 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4105 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4106
de85e130
PE
41072012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4108
d0baac98 4109 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4110 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4111 (__malloc_size_t, __malloc_ptrdiff_t):
4112 Remove. All uses removed, replaced by the definiens if needed,
4113 since we can assume C89 or better now.
4114 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4115 (protect_malloc_state, align, get_contiguous_space)
4116 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4117 (malloc_atfork_handler_child, malloc_enable_thread)
4118 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4119 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4120 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4121 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4122 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4123 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4124 Define using prototypes, not old style.
4125 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4126 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4127 (align): Don't assume that signed integer overflow wraps around.
4128 Omit unused local var.
4129 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4130 (_free_internal_nolock, memalign, mallochook, reallochook):
4131 Omit no-longer-needed casts.
4132 (valloc): Use getpagesize, not __getpagesize.
4133 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4134 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4135
de85e130
PE
4136 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4137
dcbf5805
MA
41382012-04-22 Michael Albinus <michael.albinus@gmx.de>
4139
4140 Move functions from C to Lisp. Make non-blocking method calls
4141 the default. Implement further D-Bus standard interfaces.
4142
4143 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4144 (QCdbus_request_name_allow_replacement)
4145 (QCdbus_request_name_replace_existing)
4146 (QCdbus_request_name_do_not_queue)
4147 (QCdbus_request_name_reply_primary_owner)
4148 (QCdbus_request_name_reply_in_queue)
4149 (QCdbus_request_name_reply_exists)
4150 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4151 (QCdbus_registered_serial, QCdbus_registered_method)
4152 (QCdbus_registered_signal): New Lisp objects.
4153 (XD_DEBUG_MESSAGE): Use sizeof.
4154 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4155 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4156 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4157 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4158 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4159 (xd_signature, xd_append_arg): Allow float for integer types.
4160 (xd_get_connection_references): New function.
b593d6a9
AH
4161 (xd_get_connection_address): Rename from xd_initialize.
4162 Return cached address.
dcbf5805
MA
4163 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4164 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4165 level.
4166 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4167 Return number of refcounts.
dcbf5805
MA
4168 (Fdbus_get_unique_name): Make stronger parameter check.
4169 (Fdbus_message_internal): New defun.
4170 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4171 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4172 (Fdbus_send_signal, Fdbus_register_service)
4173 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4174 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4175 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4176 (Vdbus_compiled_version, Vdbus_runtime_version)
4177 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4178 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4179 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4180 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4181 Adapt docstring.
dcbf5805 4182
52828e02
PE
41832012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4184
da05bc4c
PE
4185 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4186 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4187 Do not assume ptrdiff_t is the same width as 'int'.
4188
52828e02
PE
4189 * alloc.c: Handle unusual debugging option combinations.
4190 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4191 since the two debugging options are incompatible.
4192 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4193 is defined.
4194 (mem_init, mem_insert, mem_insert_fixup):
4195 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4196 (NEED_MEM_INSERT): Remove; no longer needed.
4197
f01769f9
LL
41982012-04-22 Leo Liu <sdl.web@gmail.com>
4199
4200 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4201
5790543d
PE
42022012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4203
4204 * sysdep.c [__FreeBSD__]: Minor cleanups.
4205 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4206 Use Emacs indenting style more consistently. Avoid some casts.
4207 Use 'double' consistently rather than mixing 'float' and 'double'.
4208
b91b7e4d
EW
42092012-04-21 Eduard Wiebe <usenet@pusto.de>
4210
b593d6a9
AH
4211 * sysdep.c (list_system_processes, system_process_attributes):
4212 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4213
6114eb15
AS
42142012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4215
4216 * lisp.mk (lisp): Update.
4217
2f38dff7
PE
42182012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4219
4220 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4221 It is never used otherwise.
4222
4ae29f89
SM
42232012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4224
4225 * print.c (print_preprocess): Only check print_depth if print-circle
4226 is nil.
4227 (print_object): Check for cycles even when print-circle is nil and
4228 print-gensym is t, but only check print_depth if print-circle is nil.
4229
f30d612a
CY
42302012-04-20 Chong Yidong <cyd@gnu.org>
4231
4232 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4233 set the status to "failed" and ensure that sentinel is run.
4234
c07a4c0b 42352012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4236
4237 * process.c (Fset_process_inherit_coding_system_flag)
4238 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4239 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4240
c07a4c0b 42412012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4242
4243 * xdisp.c (string_buffer_position_lim): Limit starting position to
4244 BEGV.
4245 (set_cursor_from_row): If called for a mode-line or header-line
4246 row, return zero immediately.
4247 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4248 farther than the first row after the header line, if any.
4249 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4250 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4251
c07a4c0b 42522012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4253
4ae29f89
SM
4254 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4255 (bug#11238).
ad3a2b41 4256
c07a4c0b 42572012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 42582012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4259
4260 configure: new option --enable-gcc-warnings (Bug#11207)
4261 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4262 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4263 (ALL_CFLAGS): Use new macros rather than old.
4264 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4265 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4266 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4267 -Wunused-result, -Wunused-variable. This should go away once
4268 the Emacs and Gnulib regex code is merged.
4269 (xmalloc, xrealloc): Now static.
4270
aba027e8
PE
42712012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4272
4273 * dired.c (Fsystem_groups): Remove unused local.
4274
e5a36063
GM
42752012-04-17 Glenn Morris <rgm@gnu.org>
4276
4277 * dired.c (Fsystem_users): Doc fix.
4278
316411f0
DA
42792012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4280
4281 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4282 (syms_of_dired): Add them.
4283
9426aba4
PE
42842012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4285
b62a57be
PE
4286 Fix minor alloc.c problems found by static checking.
4287 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4288 New extern decls, to avoid calling undeclared functions.
4289 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4290 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4291 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4292 (NEED_MEM_INSERT): New macro.
4293 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4294 Remove one incorrect comment and fix another.
b62a57be 4295
3539f31f
PE
4296 Fix minor ralloc.c problems found by static checking.
4297 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4298 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4299 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4300 (r_alloc_sbrk): Now static.
4301
a041960a
PE
4302 Improve ralloc.c interface checking.
4303 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4304 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4305 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4306 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4307 [REL_ALLOC]: ... to here, to check interface.
4308 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4309 Remove decls. This fixes an "It stinks!".
4310
9426aba4
PE
4311 * alloc.c (which_symbols): Fix alignment issue / type clash.
4312
d55c12ed
AS
43132012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4314
4315 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4316 (struct Lisp_Misc_Any): Likewise.
4317 (struct Lisp_Free): Likewise.
4318 * alloc.c (union aligned_Lisp_Symbol): Define.
4319 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4320 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4321 (union aligned_Lisp_Misc): Define.
4322 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4323 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4324 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4325
b948ce8b
PE
43262012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4327
4328 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4329 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4330 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4331 * s/netbsd.h, s/sol2-6.h:
4332 Remove definition of GC_MARK_STACK, since the default now works.
4333 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4334 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4335 no longer the default.
4336 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4337
35dc09a1 43382012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4339
35dc09a1
GM
4340 * lread.c (lisp_file_lexically_bound_p):
4341 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4342
35dc09a1
GM
43432012-04-14 Eli Zaretskii <eliz@gnu.org>
4344
4345 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4346 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4347
43482012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4349
4350 * nsterm.m (constrainFrameRect): Always constrain when there is only
4351 one screen (Bug#10962).
4352
bcd86815
KB
43532012-04-13 Ken Brown <kbrown@cornell.edu>
4354
4355 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4356
c25df26e
RT
43572012-04-13 Reuben Thomas <rrt@sc3d.org>
4358
4359 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4360
0fc59f1e
DC
43612012-04-11 Daniel Colascione <dancol@dancol.org>
4362
4363 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4364 against is gone. It's better to use vfork now so that when Cygwin
4365 gains a new, working vfork, we use it automatically (bug#10398).
4366
de8c03dc
SM
43672012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4368
4369 * window.c (save_window_save): Obey window-point-insertion-type.
4370
2f097256
GM
43712012-04-11 Glenn Morris <rgm@gnu.org>
4372
4373 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4374
453b951e
SM
43752012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4376
4377 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4378
75f1671a 43792012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4380
4381 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4382 (force_quit_count): New var.
4383 (handle_interrupt): Use it.
4384
2a8ce227
JB
43852012-04-10 Juanma Barranquero <lekktu@gmail.com>
4386
4387 * w32.c (w32_delayed_load): Record the full path of the library
4388 being loaded (bug#10424).
4389
935396c0
GM
43902012-04-09 Glenn Morris <rgm@gnu.org>
4391
05920a43
GM
4392 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4393 not just in the obarray, before snarfing them. (Bug#11036)
4394
935396c0
GM
4395 * Makefile.in ($(leimdir)/leim-list.el):
4396 Pass EMACS rather than BUILT_EMACS.
4397
a18ecafa
TZ
43982012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4399
4400 * process.c (make_process):
4401 * process.h: Add integer `gnutls_handshakes_tried' member to
4402 process struct.
4403
6bbef4e5
JC
4404 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4405 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4406
4407 * gnutls.c (gnutls_log_function2i): Convenience log function.
4408 (emacs_gnutls_read): Use new log functions,
4409 `gnutls_handshakes_tried' process member, and
4410 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4411 attempts per process (connection).
4412
b4d3bc10
CY
44132012-04-09 Chong Yidong <cyd@gnu.org>
4414
4415 * eval.c (Fuser_variable_p, user_variable_p_eh)
4416 (lisp_indirect_variable): Functions deleted.
4417 (Fdefvar): Caller changed.
4418
4419 * callint.c (Finteractive, Fcall_interactively):
4420 * minibuf.c (Fread_variable): Callers changed.
4421
70f4d973
EZ
44222012-04-09 Eli Zaretskii <eliz@gnu.org>
4423
4424 * xdisp.c (set_cursor_from_row): If the display string appears in
4425 the buffer at position that is closer to point than the position
4426 after the display string, display the cursor on the first glyph of
4427 the display string. Fixes cursor display when a 'display' text
4428 property immediately follows invisible text. (Bug#11094)
4429
cb3c2e3e
PE
44302012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4431
4432 composite.c: use 'double' consistently
4433 * composite.c (get_composition_id): Use 'double' consistently
4434 instead of converting 'float' to 'double' and vice versa; this is
4435 easier to understand and avoids a GCC warning.
4436
fd06db5d
GM
44372012-04-09 Glenn Morris <rgm@gnu.org>
4438
50fe702a
GM
4439 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4440 preparation for dumping it with emacs. (Bug#4789)
4441 (leimdir): New variable.
4442 ($(leimdir)/leim-list.el): New rule.
4443 (emacs$(EXEEXT)): Depend on leim-list.el.
4444
fd06db5d
GM
4445 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4446 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4447 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4448
55c131ee
AS
44492012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4450
4451 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4452 proper alignment.
4453
9209588f
JB
44542012-04-07 Juanma Barranquero <lekktu@gmail.com>
4455
4456 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4457 Remove unused local variable.
4458
e3fb2efb
PE
44592012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4460
4461 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4462 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4463 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4464 objects, as mark_maybe_pointer will catch them otherwise.
4465 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4466 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4467
b5385551
PE
44682012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4469
4470 Fix typo that broke non-Windows builds.
4471 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4472
9078ead6
EZ
44732012-04-07 Eli Zaretskii <eliz@gnu.org>
4474
4475 Support building on MS-Windows with libxml2.
4476
4477 * makefile.w32-in (OBJ2): Add xml.$(O).
4478 (GLOBAL_SOURCES): Add xml.c.
4479 ($(BLD)/xml.$(O)): New dependency list.
4480
4481 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4482 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4483 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4484 [!WINDOWSNT]: New macros.
4485 (init_libxml2_functions, libxml2_loaded_p): New functions.
4486 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4487 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4488 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4489 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4490 linked in).
6bbef4e5
JC
4491 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4492 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4493 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4494
4495 * emacs.c: Don't include libxml/parser.h.
4496 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4497 xmlCleanupParser directly.
4498
4499 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4500
3811fdf3
EZ
45012012-04-07 Eli Zaretskii <eliz@gnu.org>
4502
4503 * indent.c (Fvertical_motion): If there is a display string at
4504 point, use it.vpos to compute how many lines to backtrack after
4505 move_it_to point. (Bug#11133)
4506
2f8e16b2
EZ
45072012-04-06 Eli Zaretskii <eliz@gnu.org>
4508
4509 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4510 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4511 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4512 macros related to unification of CJK characters. For the details,
4513 see the discussion following the message here:
4514 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4515
3d439cd1
CY
45162012-04-04 Chong Yidong <cyd@gnu.org>
4517
4518 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4519
8bc53d00
EZ
45202012-04-01 Eli Zaretskii <eliz@gnu.org>
4521
4522 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4523 instead of alloca. (Bug#11138)
4524
3b0512a3
AS
45252012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4526
4527 * w32menu.c (is_simple_dialog): Properly check lisp types.
4528 (Bug#11141)
4529
8427ddd2
EZ
45302012-03-31 Eli Zaretskii <eliz@gnu.org>
4531
979022ef
EZ
4532 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4533 position we get to after a call to move_it_to fails the
4534 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4535 only if we wind up in a string from display property. (Bug#11063)
4536
a6b1c7cc
EZ
4537 * window.c (Fdelete_other_windows_internal): Invalidate the row
4538 and column information about mouse highlight, so that redisplay
4539 restores it after reallocating the glyph matrices. (Bug#7464)
4540
8427ddd2
EZ
4541 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4542 string comes from a `display' text property, use the buffer
4543 position of that property as if we actually saw that position in
4544 the row's glyphs.
697ba24b
EZ
4545 (move_it_by_lines): Remove the assertion that
4546 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4547 violated when there's a before-string at the beginning of a line.
4548 (Bug#11063)
8427ddd2 4549
65a0a738
EZ
45502012-03-30 Eli Zaretskii <eliz@gnu.org>
4551
4552 * xdisp.c (append_space_for_newline): If the default face was
4553 remapped, use the remapped face for the appended newline.
4554 (extend_face_to_end_of_line): Use the remapped default face for
4555 extending the face to the end of the line.
4556 (display_line): Call extend_face_to_end_of_line when the default
4557 face was remapped. (Bug#11068)
4558
581355cc
EZ
45592012-03-29 Eli Zaretskii <eliz@gnu.org>
4560
4561 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4562
e8fc049f
SM
45632012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4564
4565 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4566
4fb9a543
GM
45672012-03-27 Glenn Morris <rgm@gnu.org>
4568
4569 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4570 Doc fixes.
4571
679910f1
KH
45722012-03-26 Kenichi Handa <handa@m17n.org>
4573
4574 * dispextern.h (struct glyph): Fix previous change. Change the
4575 bit length of glyphless.ch to 25 (Bug#11082).
4576
90d49b7f
CY
45772012-03-26 Chong Yidong <cyd@gnu.org>
4578
4579 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4580 (command_loop_1): Use it; inhibit selection update for
4581 handle-select-window too (Bug#8996).
4582
f514f6f0
FP
45832012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4584
e8fc049f 4585 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4586
bf43fa51
KH
45872012-03-25 Kenichi Handa <handa@m17n.org>
4588
4589 * dispextern.h (struct glyph): Change the bit length of
4590 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4591
8a0c01dd
EZ
45922012-03-24 Eli Zaretskii <eliz@gnu.org>
4593
4594 * s/ms-w32.h (tzname): Include time.h before redirecting to
4595 _tzname. Fixes the MSVC build. (Bug#9960)
4596
7d1c3a76
AS
45972012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4598
8ed79523
AS
4599 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4600 characters.
4601
7d1c3a76
AS
4602 * xterm.c (XTread_socket): Only modify handling_signal if
4603 !SYNC_INPUT. (Bug#11080)
4604
e99a9b8b
EZ
46052012-03-23 Eli Zaretskii <eliz@gnu.org>
4606
4607 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4608 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4609 when fetching a multibyte character consumes more bytes than
4610 CHAR_BYTES returns, due to unification of CJK characters in
4611 string_char. (Bug#11073)
4612
5063c0e1
TN
46132012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4614
4615 * process.c (wait_reading_process_output): Handle pty disconnect
4616 by refraining from sending oneself a SIGCHLD (bug#10933).
4617
9f851fbd
CY
46182012-03-22 Chong Yidong <cyd@gnu.org>
4619
4620 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4621
5063c0e1 4622 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4623 Mark string as coming from a prefix property.
4624 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4625 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4626
fb5b8aca
CY
46272012-03-21 Chong Yidong <cyd@gnu.org>
4628
4629 * xfaces.c (Vface_remapping_alist): Doc fix.
4630
62356a1b
EZ
46312012-03-20 Eli Zaretskii <eliz@gnu.org>
4632
4633 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4634 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4635 Doc fixes.
62356a1b 4636
025de85b
CY
46372012-03-20 Chong Yidong <cyd@gnu.org>
4638
4639 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4640 to reflect default non-nil value of redisplay-dont-pause.
4641
4827f94e
KH
46422012-03-19 Kenichi Handa <handa@m17n.org>
4643
4644 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4645 it fit in a valid range (Bug#11003).
4646
e50a24a2
EZ
46472012-03-18 Eli Zaretskii <eliz@gnu.org>
4648
4649 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4650 that is not from display property, accept the row as a "cursor
4651 row" if one of the string's character has a non-nil `cursor'
4652 property. Fixes cursor positioning when there are newlines in
4653 overlay strings, e.g. in icomplete.el. (Bug#11035)
4654
9af5ed87
PE
46552012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4656
4657 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4658
d1f55f16
CY
46592012-03-12 Chong Yidong <cyd@gnu.org>
4660
4661 * eval.c (inhibit_lisp_code): Rename from
4662 inhibit_window_configuration_change_hook; move from window.c.
4663
4664 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4665 * window.c (run_window_configuration_change_hook)
4666 (syms_of_window): Callers changed.
4667
66c5eebd
CY
46682012-03-11 Chong Yidong <cyd@gnu.org>
4669
413df973
CY
4670 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4671
66c5eebd
CY
4672 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4673
1de11f56
CY
46742012-03-10 Chong Yidong <cyd@gnu.org>
4675
4676 * frame.c (other_visible_frames): Don't assume the selected frame
4677 is visible (Bug#10955).
4678
cae07000
SM
46792012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4680
4681 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4682
89c94350
JD
46832012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4684
4685 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4686 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4687 zero (Bug#10954).
4688
999dd333
GM
46892012-03-03 Glenn Morris <rgm@gnu.org>
4690
01a6dcc8 4691 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4692
de0100f2
EZ
46932012-03-02 Eli Zaretskii <eliz@gnu.org>
4694
4695 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4696 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4697 (redisplay_window, next_element_from_string): Fix typos in
4698 comments.
3e441275
EZ
4699 (redisplay_window): Pass to move_it_vertically the margin in
4700 pixels, not in screen lines.
de0100f2 4701
96a72ee9
GM
47022012-03-02 Glenn Morris <rgm@gnu.org>
4703
4704 * buffer.c (buffer-list-update-hook): Doc fix.
4705
312508d7
EZ
47062012-02-29 Eli Zaretskii <eliz@gnu.org>
4707
4708 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4709 push_it before setting up the iterator for the first overlay
4710 string, even if we have an empty string loaded.
4711 (next_overlay_string): If there's an empty string on the iterator
4712 stack, pop the stack. (Bug#10903)
4713
27f3c637
PE
47142012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4715
4716 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4717 Suggested by Stefan Monnier in
4718 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4719 * alloc.c (widen_to_Lisp_Object): New static function.
4720 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4721 and widening them to Lisp_Objects. This would work even if
4722 USE_LSB_TAG is defined and wide integers are used, which might
4723 happen in a future version of Emacs.
4724
3c9dfce6
CY
47252012-02-25 Chong Yidong <cyd@gnu.org>
4726
fa74b241
CY
4727 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4728 Doc fix.
4729
3c9dfce6
CY
4730 * xselect.c (Fx_selection_exists_p): Doc fix.
4731 (x_clipboard_manager_save_all): Print an informative message
4732 before saving to clipboard manager.
4733
9486df08
CY
47342012-02-24 Chong Yidong <cyd@gnu.org>
4735
4736 * keyboard.c (process_special_events): Handle all X selection
4737 requests in kbd_buffer, not just the next one (Bug#8869).
4738
f01d3321
CY
47392012-02-23 Chong Yidong <cyd@gnu.org>
4740
4741 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4742 call when setting menu-bar-lines and tool-bar-lines parameters.
4743 (unwind_create_frame_1): New helper function.
4744
4745 * window.c (inhibit_window_configuration_change_hook): New var.
4746 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4747 (syms_of_window): Initialize it.
f01d3321 4748
86b847b6
CY
47492012-02-22 Chong Yidong <cyd@gnu.org>
4750
4751 * xterm.c (x_draw_image_relief): Add missing type check for
4752 Vtool_bar_button_margin (Bug#10743).
4753
a59225b1
CY
47542012-02-21 Chong Yidong <cyd@gnu.org>
4755
4756 * fileio.c (Vfile_name_handler_alist): Doc fix.
4757
4758 * buffer.c (Fget_file_buffer): Protect against invalid file
4759 handler return value.
4760
310f5bd4
PE
47612012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4762
cb3a28cc
PE
4763 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4764 when computing $valmask.
4765
310f5bd4
PE
4766 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4767 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4768 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4769 It's useless in that case, and it can cause problems on hosts
4770 that allocate halves of EMACS_INT values separately.
4771 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4772 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4773 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4774 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4775 it avoids undefined behavior on hosts where shifting right by more
4776 than the word width has undefined behavior.
4777
2375c96a
CY
47782012-02-19 Chong Yidong <cyd@gnu.org>
4779
4780 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4781 (Funhandled_file_name_directory, Ffile_name_as_directory)
4782 (Fdirectory_file_name, Fexpand_file_name)
4783 (Fsubstitute_in_file_name): Protect against invalid file handler
4784 return values (Bug#10845).
4785
3eb49e71
EZ
47862012-02-18 Eli Zaretskii <eliz@gnu.org>
4787
4788 * .gdbinit (pitx): Fix incorrect references to fields of the
4789 iterator stack.
4790
7b926f3f
CY
47912012-02-17 Chong Yidong <cyd@gnu.org>
4792
4793 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4794
11273115
PE
47952012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4796
4797 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4798 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4799
c3a70e2b
CY
48002012-02-15 Chong Yidong <cyd@gnu.org>
4801
4802 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4803 marked as special. Also, starting docstrings with * is obsolete.
4804
0ca43699
AS
48052012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4806
4807 * gnutls.c (emacs_gnutls_write): Fix last change.
4808
2e8f3c56
LI
48092012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4810
4811 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4812 send_process.
4813
af70074f
SM
48142012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4815
4816 * keymap.c (Fsingle_key_description): Handle char ranges.
4817
95986d52
CY
48182012-02-12 Chong Yidong <cyd@gnu.org>
4819
afd83bd1
CY
4820 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4821 as that creates a dangerous corner case.
4822
95986d52
CY
4823 * window.c (Fdelete_window_internal): Invalidate the mouse
4824 highlight (Bug#9904).
4825
bd7da63e
GM
48262012-02-12 Glenn Morris <rgm@gnu.org>
4827
4828 * xselect.c (Fx_own_selection_internal)
4829 (Fx_get_selection_internal, Fx_disown_selection_internal)
4830 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4831 * nsselect.m (Fx_own_selection_internal)
4832 (Fx_disown_selection_internal, Fx_selection_exists_p)
4833 (Fx_selection_owner_p, Fx_get_selection_internal):
4834 Sync docs and argument specs with the xselect.c versions.
4835
77abcbc2
LI
48362012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4837
4838 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4839
90b671e2
EZ
48402012-02-11 Eli Zaretskii <eliz@gnu.org>
4841
1c0ca0b7
EZ
4842 * w32select.c (Fx_selection_exists_p): Sync doc string and
4843 argument list with xselect.c. (Bug#10783)
4844
4845 * w16select.c (Fx_selection_exists_p): Sync doc string and
4846 argument list with xselect.c. (Bug#10783)
90b671e2 4847
49241268
GM
48482012-02-10 Glenn Morris <rgm@gnu.org>
4849
4850 * fns.c (Fsecure_hash): Doc fix.
4851
f998bbe7 48522012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4853
4854 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4855
0992bd9c
CY
48562012-02-07 Chong Yidong <cyd@gnu.org>
4857
4858 * buffer.c (Fbuffer_local_variables)
4859 (buffer_lisp_local_variables): Handle unbound vars correctly;
4860 don't let Qunbound leak into Lisp.
4861
af008560
GM
48622012-02-07 Glenn Morris <rgm@gnu.org>
4863
dd605cc4
GM
4864 * image.c (Fimagemagick_types): Doc fix.
4865
af008560
GM
4866 * image.c (imagemagick-render-type): Change it from a lisp object
4867 to an integer. Move the doc here from the lisp manual.
4868 Treat all values not equal to 0 the same.
4869
1449fa1d
CY
48702012-02-06 Chong Yidong <cyd@gnu.org>
4871
4872 * doc.c (store_function_docstring): Avoid applying docstring of
4873 alias to base function (Bug#2603).
4874
3723ec07
AS
48752012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4876
4877 * .gdbinit (pp1, pv1): Remove redundant defines.
4878 (pr): Use pp.
4879
79c1cc1e
CY
48802012-02-04 Chong Yidong <cyd@gnu.org>
4881
4882 * nsterm.m: Declare a global (Bug#10694).
4883
d7f29f8e
EZ
48842012-02-04 Eli Zaretskii <eliz@gnu.org>
4885
cae07000
SM
4886 * w32.c (get_emacs_configuration_options):
4887 Include --enable-checking, if specified, in the return value.
d7f29f8e 4888
3b95a6f9
MR
48892012-02-04 Martin Rudalics <rudalics@gmx.at>
4890
4891 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4892 after rounding frame sizes. (Bug#9723)
4893
d6fa96a6
EZ
48942012-02-04 Eli Zaretskii <eliz@gnu.org>
4895
4896 * keyboard.c (adjust_point_for_property): Don't position point
4897 before BEGV. (Bug#10696)
4898
df0b2940
PE
48992012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4900
4901 Handle overflow when computing char display width (Bug#9496).
4902 * character.c (char_width): Return EMACS_INT, not int.
4903 (char_width, c_string_width): Check for overflow when
4904 computing the width; this is possible now that individual
4905 characters can have unbounded width. Problem introduced
4906 by merge from Emacs 23 on 2012-01-19.
4907
6bee44d6
MA
49082012-02-02 Michael Albinus <michael.albinus@gmx.de>
4909
4910 * dbusbind.c (Fdbus_register_method): Mention the return value
4911 :ignore in the docstring.
4912
44f92739
GM
49132012-02-02 Glenn Morris <rgm@gnu.org>
4914
1b9f60cc
GM
4915 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4916
44f92739
GM
4917 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4918 Unconditionally set to t. (Bug#10673)
4919 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4920 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4921 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4922
c5d3843c
KH
49232012-02-02 Kenichi Handa <handa@m17n.org>
4924
4925 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4926 0, do not call append_composite_glyph.
4927
159462d4 49282012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4929
4930 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4931 NULL (Bug#6988).
4932 (x_produce_glyphs): If the component of a composition is a null
4933 string, set it->pixel_width to 1 to avoid zero-width glyph.
4934
78cef877
EZ
49352012-02-01 Eli Zaretskii <eliz@gnu.org>
4936
4937 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4938 first 2 arguments are identical. This makes inserting large
4939 output from a subprocess an order of magnitude faster on
4940 MS-Windows, where all sbrk'ed memory is always contiguous.
4941
97897668
GM
49422012-01-31 Glenn Morris <rgm@gnu.org>
4943
4944 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4945 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4946 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4947
31fd3586
GM
49482012-01-29 Glenn Morris <rgm@gnu.org>
4949
4950 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4951
0e24a8b2
CY
49522012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4953
4954 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4955
cc0adcb0
CY
49562012-01-28 Chong Yidong <cyd@gnu.org>
4957
4958 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4959
acc28cb9
CY
49602012-01-26 Chong Yidong <cyd@gnu.org>
4961
9c69cfb7
CY
4962 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4963
acc28cb9
CY
4964 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4965 repeat counts (Bug#10507).
4966
48da7392
GM
49672012-01-26 Glenn Morris <rgm@gnu.org>
4968
4969 * lread.c (syms_of_lread): Doc fix.
4970
14af5f7f
CY
49712012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4972
4973 * coding.c (encode_designation_at_bol): Change return value to
4974 EMACS_INT.
4975
0b21c100
CY
49762012-01-25 Chong Yidong <cyd@gnu.org>
4977
4978 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4979
3c2907f7
CY
49802012-01-21 Chong Yidong <cyd@gnu.org>
4981
4982 * floatfns.c (Fcopysign): Make the second argument non-optional,
4983 since nil is not allowed anyway.
4984
959ad23f
AS
49852012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4986
4987 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4988 (send_process): Likewise.
4989
34a02f46
MR
49902012-01-19 Martin Rudalics <rudalics@gmx.at>
4991
4992 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4993 (Vwindow_persistent_parameters): Do not use Qstate.
4994 Rewrite doc-strings.
34a02f46 4995
1259009a 49962012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4997
4998 * character.c (char_width): New function.
70d4fdf6
GM
4999 (Fchar_width, c_string_width, lisp_string_width):
5000 Use char_width (Bug#9496).
25ed9e61 5001
6a6ee00d
MR
50022012-01-16 Martin Rudalics <rudalics@gmx.at>
5003
5004 * window.c (Vwindow_persistent_parameters): New variable.
5005 (Fset_window_configuration, save_window_save): Handle persistent
5006 window parameters.
5007
c85efaf7
EZ
50082012-01-14 Eli Zaretskii <eliz@gnu.org>
5009
5010 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5011 thrashing the stack of the thread. (Bug#9087)
5012
5944709e
PE
50132012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5014
5015 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5016
e71f5d99
EZ
50172012-01-11 Eli Zaretskii <eliz@gnu.org>
5018
5019 * xdisp.c (rows_from_pos_range): Handle the case where the
5020 highlight ends on a newline. (Bug#10464)
5021 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5022 he end column for display of highlight that ends on a newline
5023 before a R2L line.
5024
ce316182
GM
50252012-01-11 Glenn Morris <rgm@gnu.org>
5026
5027 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5028 from load-path also when installation-directory is nil. (Bug#10208)
5029
5b43da69
GM
50302012-01-10 Glenn Morris <rgm@gnu.org>
5031
74cc8ff9
GM
5032 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5033
7d8d6e4e
GM
5034 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5035 Update template values to be closer to their typical values these days.
5b43da69 5036
a0db8d43
EZ
50372012-01-09 Eli Zaretskii <eliz@gnu.org>
5038
5039 * xdisp.c (rows_from_pos_range): Accept additional argument
5040 DISP_STRING, and accept any glyph in a row whose object is that
5041 string as eligible for mouse highlight. Fixes mouse highlight of
5042 display strings from overlays. (Bug#10464)
5043
9a0115ab 50442012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5045
b9110d6a 5046 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5047 * fileio.c (auto_saving_dir_umask): New static var.
5048 (Fmake_directory_internal): Use it.
5049 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5050 creating the directory. The old code temporarily assigns
5051 too-generous permissions to the directory.
5052 (do_auto_save_eh): Clear it.
b9110d6a 5053 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5054 that the var is always cleared.
5055
6c1bd3f3
EZ
50562012-01-07 Eli Zaretskii <eliz@gnu.org>
5057
5058 * search.c (scan_buffer): Pass character positions to
5059 know_region_cache, not byte positions. (Bug#6540)
5060
069d2b50
L
50612012-01-07 LynX <_LynX@bk.ru> (tiny change)
5062
5063 * w32.c (sys_rename): Report EXDEV when rename of a directory
5064 fails because the target is on another logical disk. (Bug#10284)
5065
75bf0d33
DB
50662012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5067
5068 * xterm.c (x_embed_request_focus): New function.
5069
5070 * xterm.h: Add prototype.
5071
5072 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5073
1c6e5a32
GM
50742012-01-05 Glenn Morris <rgm@gnu.org>
5075
5076 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5077
651e947e
EZ
50782012-01-01 Eli Zaretskii <eliz@gnu.org>
5079
5080 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5081 Load gnutls_transport_set_lowat only if GnuTLS version is below
5082 2.11.1.
5083 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5084 GnuTLS versions below 2.11.1.
5085
3778cdd8
AL
50862011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5087
5088 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5089 to the doc string advising against its use for altering the way
5090 windows are scrolled.
5091
0e5317f7
KH
50922011-12-28 Kenichi Handa <handa@m17n.org>
5093
5094 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5095 coding-system ASCII compatible only when it does not produce BOM
5096 on encoding (Bug#10383).
5097
93d5ca1f
JD
50982011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5099
5100 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5101 can scroll.
5102 (create_and_show_popup_menu): Always use menu_position_func for
5103 Gtk3 (Bug#10361).
5104
ca22b785
AS
51052011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5106
5107 * callint.c (Fcall_interactively): Don't truncate prompt string.
5108
d048e1e6
EZ
51092011-12-23 Eli Zaretskii <eliz@gnu.org>
5110
5111 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5112 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5113 resumed from there (after widening). (Bug#10360)
d048e1e6 5114
5ccaba1f
JD
51152011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5116
5117 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5118
204ee57f
JD
51192011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5120
b81d40f0
JB
5121 * nsterm.m (x_free_frame_resources):
5122 Release f->output_data.ns->miniimage.
204ee57f
JD
5123 (ns_index_color): Fix indentation. Do not retain
5124 color_table->colors[i].
5125
5126 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5127 before returning.
5128
5129 * nsfns.m (x_set_background_color): Assign return value from
5130 ns_index_color to face-background instead of NSColor*.
5131 (ns_implicitly_set_icon_type): Fix indentation.
5132 Change assignment in for loop to comparison.
5133
5134 * emacs.c (ns_pool): New variable.
5135 (main): Assign ns_pool.
5136 (Fkill_emacs): Call ns_release_autorelease_pool.
5137
5138 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5139 autorelease fdesc, release fdAttrs and tdict.
5140 (ns_get_covering_families): Release charset.
5141 (ns_findfonts): Release NSFontDescriptor created with new.
5142 (ns_uni_to_glyphs): Fix indentation.
5143 (setString): Release attrStr before assigning new value.
5144
c803b2b7
JD
51452011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5146
678f4426
JD
5147 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5148 and NS_IMPL_COCOA.
5149 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5150 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5151
cd394be1 51522011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5153
5fecd5fc
JD
5154 * nsterm.m (ns_term_init): Subscribe for notifications
5155 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5156 to method trackingNotification in EmacsMenu.
5157
5158 * nsmenu.m (trackingMenu): New variable.
3771cb17 5159 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5160 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5161 from Aquamacs (Bug#7030).
678f4426
JD
5162
51632011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5164
c803b2b7
JD
5165 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5166 (symbol_to_nsstring): Fix indentation.
5167 (ns_symbol_to_pb): New function.
cae07000
SM
5168 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5169 (Fns_rotate_cut_buffers_internal): Remove.
5170 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5171 Fns_store_cut_buffer_internal.
5172 (ns_get_foreign_selection, Fx_own_selection_internal)
5173 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5174 (Fns_get_selection_internal, Fns_store_selection_internal):
5175 Use ns_symbol_to_pb and check if return value is nil.
5176 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5177 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5178 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5179 renamed to Sns_store_selection_internal.
5180 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5181 and remove this function.
5182 (ns_handle_selection_clear): Remove, never used.
5183 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5184 here.
5185
e1b01a3a
KB
51862011-12-17 Ken Brown <kbrown@cornell.edu>
5187
5188 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5189 GID is unknown (Bug#10257).
5190
2adb6e85
PE
51912011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5192
5193 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5194 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5195 which caused a build failure on GNU/Linux IA-64. This problem was
5196 introduced by my 2011-10-07 patch.
5197
d1d7b339
JL
51982011-12-15 Juri Linkov <juri@jurta.org>
5199
5200 * image.c (imagemagick_error): New function. (Bug#10112)
5201 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5202 Use `imagemagick_error' where ImageMagick functions return
5203 `MagickFalse'.
5204 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5205 proper order.
5206
100d5755
KH
52072011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5208
5209 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5210 fill background (Bug#8992).
5211
454592a6
MR
52122011-12-13 Martin Rudalics <rudalics@gmx.at>
5213
5214 * window.c (Vwindow_combination_resize)
5215 (Vwindow_combination_limit): Use t instead of non-nil in
5216 doc-strings.
61d4b438
MR
5217 (Vrecenter_redisplay): Add first sentence of doc-string on
5218 separate line.
53524d93 5219 (Frecenter): Fix doc-string typo.
454592a6 5220
3633e3aa
KH
52212011-12-11 Kenichi Handa <handa@m17n.org>
5222
5223 * coding.c (Funencodable_char_position): Pay attention to the
5224 buffer text relocation (Bug#9389).
5225
7b9d523a 52262011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5227
7b9d523a
JD
5228 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5229 gtk_init (Bug#10100).
5230
b73189c6
EZ
52312011-12-10 Eli Zaretskii <eliz@gnu.org>
5232
5233 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5234 IT->string is nil. (Bug#10263)
5235
f7dfe5d6
JD
52362011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5237
83faebb4
JD
5238 * nsterm.h (x_free_frame_resources): Declare.
5239
f7dfe5d6
JD
5240 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5241 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5242
5243 * nsterm.h (ns_get_defaults_value): Declare.
5244
5245 * nsterm.m (ns_default): Call ns_get_defaults_value.
5246
7cd4e72c
EZ
52472011-12-09 Eli Zaretskii <eliz@gnu.org>
5248
5249 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5250 (Bug#10170)
5251
b34d7317
YM
52522011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5253
5254 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5255 that where the value of an _OBJC_* symbol points to is in the .bss
5256 section (Bug#10240).
5257
76470ad1
KH
52582011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5259
5260 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5261 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5262
745fff94
KH
52632011-12-08 Kenichi Handa <handa@m17n.org>
5264
5265 * ftfont.c (get_adstyle_property): Fix previous change
5266 (Bug#10233).
5267
6e44397c
JB
52682011-12-07 Juanma Barranquero <lekktu@gmail.com>
5269
5270 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5271 dirs from the default value of EMACSLOADPATH (bug#10208).
5272
7efa6272
GM
52732011-12-07 Glenn Morris <rgm@gnu.org>
5274
5275 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5276 installation and source directories as well. (Bug#10208)
5277
f6fc4d87
CY
52782011-12-06 Chong Yidong <cyd@gnu.org>
5279
5280 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5281
2bf26180
GM
52822011-12-06 Glenn Morris <rgm@gnu.org>
5283
5284 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5285 as an error, not just -1. (Bug#10217)
5286
3a6ad4f0
CY
52872011-12-05 Chong Yidong <cyd@gnu.org>
5288
5289 * keyboard.c (process_special_events): New function.
5290 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5291
75a3b399
PE
52922011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5293
5294 * coding.c (encode_designation_at_bol): Don't use uninitialized
5295 local variable (Bug#9318).
5296
c3c9e25e
KH
52972011-12-05 Kenichi Handa <handa@m17n.org>
5298
5299 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5300 return Qnil (Bug#8046, Bug#10193).
5301
5eb05ea3
KH
53022011-12-05 Kenichi Handa <handa@m17n.org>
5303
5304 * coding.c (encode_designation_at_bol): New args charbuf_end and
5305 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5306 (coding_set_source): Return how many bytes coding->source was
5307 relocated.
5308 (coding_set_destination): Return how many bytes
5309 coding->destination was relocated.
5310 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5311 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5312
53132011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5314
5315 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5316 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5317 macro (Bug#9318).
5318
53192011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5320
5321 The following changes are to fix Bug#9318.
5322
a79703f5 5323 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5324 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5325 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5326 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5327
7dbda6df
JB
53282011-12-05 Juanma Barranquero <lekktu@gmail.com>
5329
5330 * lisp.h (process_quit_flag): Fix external declaration.
5331
6d5eb5b0
SM
53322011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5333
5334 Don't macro-inline non-performance-critical code.
5335 * eval.c (process_quit_flag): New function.
5336 * lisp.h (QUIT): Use it.
5337
a0c3fad0
JD
53382011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5339
5340 * nsfns.m (get_geometry_from_preferences): New function.
5341 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5342
6c07aac2
AS
53432011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5344
5345 * emacs.c (Qkill_emacs): Define.
5346 (syms_of_emacs): Initialize it.
5347 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5348 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5349 (quit_throw_to_read_char): Add parameter `from_signal'.
5350 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5351 * lisp.h (QUIT): Call Fkill_emacs if requested.
5352
c052ead4
JD
53532011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5354
5355 * widget.c (update_wm_hints): Return if wmshell is null.
5356 (widget_update_wm_size_hints): New function.
5357
5358 * widget.h (widget_update_wm_size_hints): Declare.
5359
5360 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5361 widget_update_wm_size_hints (Bug#10104).
5362
9e49252b
EZ
53632011-12-03 Eli Zaretskii <eliz@gnu.org>
5364
5365 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5366 before a newline, prepare the bidi iterator for consuming the
5367 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5368 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5369
02b16839
JL
53702011-12-02 Juri Linkov <juri@jurta.org>
5371
5372 * search.c (Fword_search_regexp): New Lisp function created from
5373 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5374 (Fword_search_backward, Fword_search_forward)
5375 (Fword_search_backward_lax, Fword_search_forward_lax):
5376 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5377 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5378
0068070e
SM
53792011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5380
5381 * fileio.c (Finsert_file_contents): Move after-change-function call
5382 to before the "handled:" label, since all "goto handled" appear in
5383 cases where the *-change-functions have already been properly called
5384 (bug#10117).
5385
3360a3fc
AS
53862011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5387
5388 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5389 waiting for input. (Bug#10169)
5390
73d6c093
EZ
53912011-11-30 Eli Zaretskii <eliz@gnu.org>
5392
5393 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5394 verifies glyph row's hash code--we have just reallocated the
5395 glyphs, so their contents can be complete garbage. (Bug#10164)
5396
febe6bea
JB
53972011-11-30 Juanma Barranquero <lekktu@gmail.com>
5398
5399 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5400
801a4313
EZ
54012011-11-30 Eli Zaretskii <eliz@gnu.org>
5402
5403 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5404 attributes are tested _before_ calling verify_row_hash, to protect
5405 against GCC re-ordering of the tests. (Bug#10164)
5406
2b56b87e
JD
54072011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5408
5409 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5410
5411 * xterm.c (handle_one_xevent): Only set async_visible and friends
5412 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5413 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5414 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5415
dbf31225
PE
54162011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5417
5418 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5419 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5420 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5421 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5422 All uses changed to use GCPRO1 etc.
5423 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5424 Revert to old implementation (i.e., before 2011-03-11).
5425
1305621b
YM
54262011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5427
5428 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5429 of scroll runs so as to avoid assigning disabled bogus rows and
5430 unnecessary graphics copy operations.
5431
8c9afb46
EZ
54322011-11-27 Eli Zaretskii <eliz@gnu.org>
5433
5434 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5435 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5436 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5437 (malloc, free, realloc, calloc): Redirect to e_* only when
5438 compiling Emacs.
5439
5440 * lisp.h (GCTYPEBITS): Move before first use.
5441 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5442 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5443 this macro definition.
5444
5445 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5446 _MSC_VER.
5447
54e9e3bf
JD
54482011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5449
6d5eb5b0
SM
5450 * gtkutil.c (xg_create_frame_widgets):
5451 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5452 present with Gtk+ 2.0.
5453
83aca1cb
PE
54542011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5455
5456 * fileio.c (Finsert_file_contents): Undo previous change; see
5457 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5458
5b76caa4
PE
54592011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5460
5461 Rename locals to avoid shadowing.
5462 * fileio.c (Finsert_file_contents):
5463 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5464 * process.c (wait_reading_process_output):
5465 Rename inner 'proc' to 'p' to avoid shadowing.
5466 Indent for consistency with usual Emacs style.
5467
8c535114
EZ
54682011-11-25 Eli Zaretskii <eliz@gnu.org>
5469
5470 * xdisp.c (redisplay_window): If cursor row is not fully visible
5471 after recentering, and scroll-conservatively is set to a large
5472 number, scroll window by a few more lines to make the cursor fully
5473 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5474 (start_display): Don't move to the next line if the display should
5475 start at a newline that is part of a display vector or an overlay
5476 string. (Bug#10119)
8c535114 5477
fa4fdb5c
JL
54782011-11-24 Juri Linkov <juri@jurta.org>
5479
5480 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5481 after the `MagickPingImage' call. (Bug#10112)
5482
90ec88df
CY
54832011-11-23 Chong Yidong <cyd@gnu.org>
5484
5485 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5486
56e2e794
MR
54872011-11-23 Martin Rudalics <rudalics@gmx.at>
5488
5489 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5490 making another buffer current. (Bug#10114)
5491
b6e64c41
GM
54922011-11-23 Glenn Morris <rgm@gnu.org>
5493
5494 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5495
6b21de18
CY
54962011-11-23 Chong Yidong <cyd@gnu.org>
5497
5498 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5499 using it (Bug#5984).
5500
b12cd789
EZ
55012011-11-22 Eli Zaretskii <eliz@gnu.org>
5502
5503 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5504 and header-lines, as they don't have one computed for them.
5505 (Bug#10098)
5506
5507 * .gdbinit (prow): Make displayed values more self-explaining.
5508 Add row's hash code.
5509
261b6fd4
LMI
55102011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5511
5512 * process.c (wait_reading_process_output): Fix asynchrounous
5513 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5514 (wait_reading_process_output): Add comment and URL.
261b6fd4 5515
e7cfd277
JD
55162011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5517
5518 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5519
a9b9b7f5
CY
55202011-11-21 Chong Yidong <cyd@gnu.org>
5521
5522 * window.c (Fnext_window, Fprevious_window): Doc fix.
5523
b0d15b4f
SM
55242011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5525
5526 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5527
fe7a3057
JB
55282011-11-20 Juanma Barranquero <lekktu@gmail.com>
5529
5530 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5531
d2999b1a
MR
55322011-11-20 Martin Rudalics <rudalics@gmx.at>
5533
5534 * window.c (Fset_window_combination_limit): Rename argument
5535 STATUS to LIMIT.
5536 (Vwindow_combination_limit): Remove "status" from doc-string.
5537
d5ff9cd0
AS
55382011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5539
5540 * m/ibms390.h: Remove.
5541 * m/ibms390x.h: Don't include "ibms390.h".
5542
a5bb9bd3
SM
55432011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5544
5545 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5546 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5547
cd1181db
JB
55482011-11-20 Juanma Barranquero <lekktu@gmail.com>
5549
5550 * casetab.c (Fset_case_table):
5551 * charset.c (Fcharset_after): Fix typos.
5552
615a3b8d 55532011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5554
17e845af
PE
5555 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5556 Otherwise, valgrind does not work on some platforms.
5557 Problem reported by Andreas Schwab in
6a0bf43d
PE
5558 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5559 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5560 is set, removing the need for VIRT_ADDRESS_VARIES.
5561 (PURE_P): Use a more-efficient implementation that needs just one
5562 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5563 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5564 to 4 (xorl, subq, cmpq, setbe).
5565 * alloc.c (pure): Always extern now, since that's the
5566 VIRT_ADDR_VARIES behavior.
5567 (PURE_POINTER_P): Use a single comparison, not two, for
5568 consistency with the new puresize.h.
5569 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5570 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5571 Remove VIRT_ADDR_VARIES no longer needed.
5572
f8fe6f96
EZ
55732011-11-19 Eli Zaretskii <eliz@gnu.org>
5574
5575 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5576 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5577 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5578 behave as if the cursor position were at the window margin.
5579
5580 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5581 and the cursor position is out of bounds, behave as if the cursor
5582 position were at the window margin. (Bug#10075)
5583
df05a53c
CY
55842011-11-18 Chong Yidong <cyd@gnu.org>
5585
5586 * window.c (Fwindow_combination_limit): Make first argument
5587 non-optional, since it is meaningless for live windows like the
5588 selected window.
61ccba97 5589
2071918e
DA
55902011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5591
5592 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5593
b50a28de
SM
55942011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5595
5596 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5597 (graft_intervals_into_buffer): Simplify.
5598
015137db
EZ
55992011-11-18 Eli Zaretskii <eliz@gnu.org>
5600
5601 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5602 hash values of the two rows.
5603 (copy_row_except_pointers): Preserve the used[] arrays and the
5604 hash values of the two rows. (Bug#10035)
68c95424 5605 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5606
5607 * xdisp.c (row_hash): New function, body extracted from
5608 compute_line_metrics.
5609 (compute_line_metrics): Call row_hash, instead of computing the
5610 hash code inline.
5611
5612 * dispnew.c (verify_row_hash): Call row_hash for computing the
5613 hash code of a row, instead of duplicating code from xdisp.c.
5614
5615 * dispextern.h (row_hash): Add prototype.
5616
a2addb04
TH
56172011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5618
5619 * frame.c (delete_frame): Don't delete the terminal when the last
5620 X frame is closed if emacs is built with GTK toolkit.
5621
df85d315
JB
56222011-11-17 Juanma Barranquero <lekktu@gmail.com>
5623
5624 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5625
a0c2d0ae
MR
56262011-11-17 Martin Rudalics <rudalics@gmx.at>
5627
5628 * window.c (Vwindow_splits): Rename to
5629 Vwindow_combination_resize. Suggested by Juri Linkov.
5630 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5631 of Vwindow_splits.
5632
58179cce
JB
56332011-11-16 Juanma Barranquero <lekktu@gmail.com>
5634
7877f373
JB
5635 * nsfns.m (Fns_font_name):
5636 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5637
b6f67890
MR
56382011-11-16 Martin Rudalics <rudalics@gmx.at>
5639
5640 * window.h (window): Rename slot "nest" to "combination_limit".
5641 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5642 (Fset_window_nest): Rename to Fset_window_combination_limit.
5643 (Vwindow_nest): Rename to Vwindow_combination_limit.
5644 (recombine_windows, make_parent_window, make_window)
5645 (Fsplit_window_internal, saved_window)
5646 (Fset_window_configuration, save_window_save): Rename all
5647 occurrences of window_nest to window_combination_limit.
5648
c7015153
JB
56492011-11-15 Juanma Barranquero <lekktu@gmail.com>
5650
5651 * image.c (imagemagick_load_image): Fix typo.
5652
322ad6ec
EZ
56532011-11-14 Eli Zaretskii <eliz@gnu.org>
5654
5655 * xdisp.c (display_line): Move the call to
5656 highlight_trailing_whitespace before the call to
5657 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5658 faces of all the glyphs to compute ROW's hash value.
5659 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5660
f067b8ec
JB
56612011-11-14 Juanma Barranquero <lekktu@gmail.com>
5662
5663 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5664 just return (bug#10044).
5665
1e5b2111
EZ
56662011-11-12 Eli Zaretskii <eliz@gnu.org>
5667
7ef3cbd5
EZ
5668 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5669 with user-defined heap size. Bump the default size of the temacs
5670 heap to 27MB, to avoid memory warning when running temacs.
5671 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5672
1e5b2111
EZ
5673 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5674 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5675 (verify_row_hash) [XASSERTS]: New function.
5676 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5677 that the hash value of glyph rows is correct.
1e5b2111 5678
89d61221
MR
56792011-11-12 Martin Rudalics <rudalics@gmx.at>
5680
5681 * window.h (window): Remove splits slot.
5682 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5683 (Fdelete_other_windows_internal, make_parent_window)
5684 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5685 (Fset_window_configuration, save_window_save): Don't deal with
5686 split status of windows.
5687 (saved_window): Remove splits slot.
5688 (Vwindow_splits): Rewrite doc-string.
5689
97f18cc8
JD
56902011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5691
5692 * xfns.c (unwind_create_frame):
5693 * nsfns.m (unwind_create_frame):
5694 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5695 Vframe_list (Bug#9999).
5696
22a648b4
DA
56972011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5698
0b381c7e 5699 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5700
659afede
KH
57012011-11-11 Kenichi Handa <handa@m17n.org>
5702
5703 * callproc.c (Fcall_process): Set the member dst_multibyte of
5704 process_coding.
5705
9ac0394b
KH
57062011-11-11 Johan Bockgård <bojohan@gnu.org>
5707
5708 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5709 avoid a crash (bug#9496).
5710
2fbdc249
CY
57112011-11-09 Chong Yidong <cyd@gnu.org>
5712
5713 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5714 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5715
ac6b1f81
PE
57162011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5717
5718 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5719
09db192c
PE
57202011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5721
5722 Avoid some portability problems by eschewing 'extern inline' functions.
5723 The trivial performance wins aren't worth the portability hassles; see
5724 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5725 et seq.
5726 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5727 (window_box_width, window_box_left, window_box_left_offset)
5728 (window_box_right, window_box_right_offset): Undo previous change,
5729 by removing the "extern"s.
5730 * intervals.c (adjust_intervals_for_insertion)
5731 (adjust_intervals_for_deletion): Undo previous change,
5732 making these static again.
5733 (offset_intervals, temp_set_point_both, temp_set_point)
5734 (copy_intervals_to_string): No longer inline.
5735 * xdisp.c (window_text_bottom_y, window_box_width)
5736 (window_box_height, window_box_left_offset)
5737 (window_box_right_offset, window_box_left, window_box_right)
5738 (window_box): No longer inline.
5739
105216ed
CY
57402011-11-08 Chong Yidong <cyd@gnu.org>
5741
5742 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5743 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5744 Signal an error if not a live window.
105216ed
CY
5745 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5746 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5747
ae9e237f
JB
57482011-11-07 Juanma Barranquero <lekktu@gmail.com>
5749
5750 * lisp.h (syms_of_abbrev): Remove declaration.
5751 Reported by CHENG Gao <chenggao@royau.me>.
5752
c7aa8333
EZ
57532011-11-07 Eli Zaretskii <eliz@gnu.org>
5754
5755 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5756 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5757 of temacs in GUI mode.
5758
be7f5545
MR
57592011-11-07 Martin Rudalics <rudalics@gmx.at>
5760
5761 * window.h: Declare delete_all_child_windows instead of
5762 delete_all_subwindows.
5763 * window.c (Fwindow_nest, Fset_window_nest)
5764 (Fset_window_new_total, Fset_window_new_normal)
5765 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5766 (delete_all_subwindows): Rename to delete_all_child_windows.
5767 (Fdelete_other_windows_internal, Fset_window_configuration):
5768 Call delete_all_child_windows instead of delete_all_subwindows.
5769 * frame.c (delete_frame): Call delete_all_child_windows instead
5770 of delete_all_subwindows.
5771
ca78dc43
PE
57722011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5773
5774 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5775 This is also needed for porting to any host where GC_MARK_STACK is
5776 not GC_MAKE_GCPROS_NOOPS.
5777 (which_symbols): Use it.
5778
a0241d01
KH
57792011-11-07 Kenichi Handa <handa@m17n.org>
5780
5781 * coding.c (coding_set_destination): Check coding->src_pos only
5782 when coding->src_object is a buffer (bug#9910).
5783
5784 * process.c (send_process): Set the member src_multibyte of coding
5785 to 0 (bug#9911) when sending a unibyte text.
5786
5787 * callproc.c (Fcall_process): Set the member src_multibyte of
5788 process_coding to 0 (bug#9912).
5789
a64bfdfa 57902011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5791
5792 * xmenu.c (cleanup_widget_value_tree): New function.
5793 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5794 calling free_menubar_widget_value_tree directly (Bug#9830).
5795
cb41b32a
PE
57962011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5797
5798 Fix some portability problems with 'inline'.
5799 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5800 (window_box_width, window_box_left, window_box_left_offset)
5801 (window_box_right, window_box_right_offset): Declare extern.
5802 Otherwise, these inline functions do not conform to C99 and
5803 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5804 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5805 * intervals.c (adjust_intervals_for_insertion)
5806 (adjust_intervals_for_deletion): Now extern, because otherwise the
5807 extern inline functions 'offset_intervals' couldn't refer to it.
5808 (static_offset_intervals): Remove.
5809 (offset_intervals): Rewrite using the old contents of
5810 static_offset_intervals. The old version didn't conform to C99
5811 because an extern inline function contained a reference to an
5812 identifier with static linkage.
5813
b7041366
AS
58142011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5815
5816 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5817 GC.
5818
88a37c4d
EZ
58192011-11-06 Eli Zaretskii <eliz@gnu.org>
5820
5821 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5822 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5823 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5824 return Qleft_to_right.
5825
49745b39
CY
58262011-11-06 Chong Yidong <cyd@gnu.org>
5827
5828 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5829 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5830 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5831 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5832 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5833 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5834 (Fwindow_vscroll): Doc fix.
5835 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5836 argument, since it makes no sense to pass a live window and for
5837 consistency with window-child.
5838
1f05cd82
CS
58392011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5840
5841 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5842 support MSVC.
5843
22610910
JR
58442011-11-05 Jason Rumney <jasonr@gnu.org>
5845
5846 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5847 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5848 fonts (Bug#6029).
5849 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5850 bitwise arithmetic preventing use of unicode-sip and non-truetype
5851 opentype fonts.
5852
a06776b2
EZ
58532011-11-05 Eli Zaretskii <eliz@gnu.org>
5854
3ad924ba
EZ
5855 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5856 "emacs"-only part.
5857
a06776b2
EZ
5858 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5859 initialization code to keep similarity to xfns.c after changes
5860 from 2011-11-05.
5861
c9e7db78
JD
58622011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5863
a97f8f3f
JD
5864 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5865 (unwind_create_frame): New function (Bug#9943).
5866 (Fx_create_frame): Restructure code to be more similar to the one in
5867 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5868 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5869 Move terminal->reference_count++ just before making the frame official
5870 (Bug#9943).
5871
5872 * nsterm.m (x_free_frame_resources): New function.
5873 (x_destroy_window): Move code to x_free_frame_resources.
5874
c9e7db78 5875 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5876 (Fx_create_frame, x_create_tip_frame):
5877 Move terminal->reference_count++ just before making the frame
75f1671a 5878 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5879 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5880
a6fc3b5c
EZ
58812011-11-05 Eli Zaretskii <eliz@gnu.org>
5882
5883 Support MSVC build with newer versions of Visual Studio.
5884 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5885 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5886 nt/gmake.defs.
5887
5888 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5889 which are not supported by MSVC.
5890 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5891 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5892 bitfields.
5893 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5894 types in bitfields.
5895 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5896
5897 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5898
58179cce 58992011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5900
5901 Support MSVC build with newer versions of Visual Studio.
5902 * w32.c: Don't include w32api.h for MSVC.
5903 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5904
5905 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5906 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5907 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5908 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5909 e_* cousins.
5910 (alloca) [_MSC_VER]: Define to _alloca.
5911
5912 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5913
5914 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5915
a58c13ed
EZ
59162011-11-04 Eli Zaretskii <eliz@gnu.org>
5917
5918 * xdisp.c (note_mouse_highlight): If either of
5919 previous/next-single-property-change returns nil, treat that as
5920 the beginning or the end of the buffer. (Bug#9955)
5921
fe0b6370
JD
59222011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5923
a58c13ed 5924 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5925 label is not null (Bug#9951).
5926 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5927 may be NULL.
5928
89bd5ee1
EZ
59292011-11-04 Eli Zaretskii <eliz@gnu.org>
5930
5931 * window.c (Fwindow_body_size): Mention in the doc string that the
5932 return value is in frame's canonical units. (Bug#9949)
5933
84c3edb9
EZ
59342011-11-03 Eli Zaretskii <eliz@gnu.org>
5935
4e2fb5c7
EZ
5936 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5937
84c3edb9 5938 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5939 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5940 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5941
bc17a887
EZ
59422011-11-01 Eli Zaretskii <eliz@gnu.org>
5943
5944 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5945 Don't stop backward scan on the continuation glyph, even though
5946 its CHARPOS is positive.
6d5eb5b0
SM
5947 (mouse_face_from_buffer_pos, note_mouse_highlight):
5948 Rename cover_string to disp_string.
bc17a887 5949
4ee88440
MR
59502011-11-01 Martin Rudalics <rudalics@gmx.at>
5951
5952 * window.c (temp_output_buffer_show): Don't use
5953 Vtemp_buffer_show_specifiers.
5954 (Vtemp_buffer_show_specifiers): Remove unused variable.
5955
c2ff3c02
EZ
59562011-10-30 Eli Zaretskii <eliz@gnu.org>
5957
5958 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5959 past the beginning of the current glyph matrix.
5960
58179cce 59612011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5962
5963 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5964 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5965 HAVE_GTK3 (Bug#9869).
b77a6a7f 5966
3b574623
JD
5967 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5968 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5969
b77a6a7f
JD
5970 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5971
5972 * xterm.c: Declare x_handle_net_wm_state to return int.
5973 (handle_one_xevent): Check if we are iconified but don't have
5974 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5975 (get_current_wm_state): Return non-zero if not hidden,
5976 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5977 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5978 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5979 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5980
196e41e4
PE
59812011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5982
5983 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5984 so that this new function doesn't get optimized away by a
5985 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5986
021f2e1a
AS
59872011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5988
5989 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5990
8b058d44
EZ
59912011-10-29 Eli Zaretskii <eliz@gnu.org>
5992
5993 Fix the `xbytecode' command.
5994 * .gdbinit (xprintbytestr): New command.
b50a28de 5995 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5996 (xbytecode): Print the byte-code string as well.
5997
4452fb80
EZ
59982011-10-29 Kim Storm <storm@cua.dk>
5999
8b058d44
EZ
6000 * alloc.c (which_symbols): New function.
6001
21b72067
AS
60022011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6003
6004 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6005 line. (Bug#9903)
6006
83ed7b5c
GM
60072011-10-29 Glenn Morris <rgm@gnu.org>
6008
6009 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6010 Not clear what it was for, and it causes various bugs. (Bug#9839)
6011
5a7a728b
EZ
60122011-10-28 Eli Zaretskii <eliz@gnu.org>
6013
6014 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6015 possible random value that matches one of those tested as
6016 condition to clear the mouse face.
6017
d3d0842f
CY
60182011-10-28 Chong Yidong <cyd@gnu.org>
6019
6020 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6021
31b39d13
DN
60222011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6023
6024 * window.c (make_window): Initialize phys_cursor_on_p.
6025
9aba6043
SM
60262011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6027
6028 * lisp.h (struct Lisp_Symbol): Update comments.
6029
c20992f4
JB
60302011-10-28 Juanma Barranquero <lekktu@gmail.com>
6031
6032 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6033
db4f02f2
EZ
60342011-10-28 Eli Zaretskii <eliz@gnu.org>
6035
6036 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6037 <oslsachem@gmail.com> for helping to debug this.
6038
6039 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6040 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6041 (g_b_init_get_glyph_outline_w): New static variables.
6042 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6043 (GetGlyphOutlineW_Proc): New typedefs.
6044 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6045 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6046 New functions.
6047 (w32font_open_internal, compute_metrics):
6048 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6049 instead of calling the "wide" APIs directly.
6050
6051 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6052
6053 * w32.h (syms_of_w32font): Add prototype.
6054
87e68db4
JB
60552011-10-27 Juanma Barranquero <lekktu@gmail.com>
6056
6057 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6058 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6059 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6060 (Fmove_to_window_line): Doc fix.
6061
435c1d67
CY
60622011-10-27 Chong Yidong <cyd@gnu.org>
6063
6064 * process.c (make_process): Set gnutls_state to NULL.
6065
6066 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6067 non-NULL, regardless of GNUTLS_INITSTAGE.
6068 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6069 an error. Set process slots as soon as we allocate them.
6070
6071 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6072
9c6c6f49
CY
60732011-10-27 Chong Yidong <cyd@gnu.org>
6074
9aba6043
SM
6075 * gnutls.c (emacs_gnutls_deinit): New function.
6076 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6077 (Fgnutls_deinit, Fgnutls_boot): Use it.
6078
6079 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6080 (deactivate_process): Call emacs_gnutls_deinit.
6081
657d08d3
JB
60822011-10-27 Juanma Barranquero <lekktu@gmail.com>
6083
6084 * image.c (x_create_x_image_and_pixmap):
6085 * w32.c (sys_rename, w32_delayed_load):
6086 * w32font.c (fill_in_logfont):
6087 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6088
5430d399
JB
60892011-10-26 Juanma Barranquero <lekktu@gmail.com>
6090
6091 * w32fns.c (w32_default_color_map): New function,
6092 extracted from Fw32_default_color_map.
a7ef684b 6093 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6094
fe0055fa
PE
60952011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6096
6097 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6098
e6346438
SM
60992011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6100
6101 * keyboard.c (test_undefined): New function (bug#9751).
6102 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6103
e112cc37
ET
61042011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6105
6106 * sysdep.c (init_sys_modes): Fix the check for the controlling
6107 terminal (Bug#6649).
6108
7b5d6677
EZ
61092011-10-20 Eli Zaretskii <eliz@gnu.org>
6110
6111 * dispextern.h (struct bidi_it): New member next_en_type.
6112
6113 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6114 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6115 current character, check also for next_en_type being WEAK_EN.
6116 (bidi_resolve_weak): Don't enter the expensive loop if the current
6117 position is before next_en_pos. Record the bidi type of the first
6118 non-ET, non-BN character we find, in addition to its position.
6119 (bidi_level_of_next_char): Invalidate next_en_type when
6120 next_en_pos is over-stepped.
6121
7da0b018
PE
61222011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6123
6124 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6125 * editfns.c: Rewrite current-time-zone so that it invokes
6126 the equivalent of (format-time-string "%Z") to get the time zone name.
6127 This fixes a bug when the time zone name contains characters that
6128 need converting from the system time locale to Emacs internal format.
6129 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6130 that patch fixed format-time-string to do the conversion, but
6131 I forgot to fix current-time-zone.
6132 (format_time_string): New function, containing most of
6133 what Fformat_time_string used to contain.
6134 (Fformat_time_string): Rewrite in terms of format_time_string.
6135 This doesn't change this function's behavior.
6136 (current-time-zone): Rewrite to use format_time_string.
6137 This fixes the bug reported by Michael Schierl in
6138 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6139 Jason Rumney's 2007-06-07 change worked around this bug, but
6140 didn't fix it.
6141 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6142
8547b010
EZ
61432011-10-19 Eli Zaretskii <eliz@gnu.org>
6144
6145 * xdisp.c (start_display): If the character at POS is displayed
6146 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6147 (try_window_reusing_current_matrix): If a line ends in a display
6148 vector or the next line starts in a display vector, continue
6149 redrawing the window even though the character position of
6150 start_row was reached.
8547b010
EZ
6151 (Bug#9771, part 2)
6152
4e948d15
CY
61532011-10-18 Chong Yidong <cyd@gnu.org>
6154
6155 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6156 with nobreak-char-display too.
6157
4787455f
EZ
61582011-10-18 Eli Zaretskii <eliz@gnu.org>
6159
6160 Fix part 3 of bug#9771.
6161 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6162 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6163 non-neutral characters if the current character is a paragraph
6164 separator (a.k.a. Newline). This avoids running the same
6165 expensive loop twice, once when we consume the preceding newline
6166 and the other time when the line actually needs to be displayed.
6167 Avoid the loop when we see neutrals on the base embedding level
6168 following a character whose directionality is the same as the
6169 paragraph's. This avoids running the expensive loop when a line
6170 ends in a long sequence of neutrals, like control characters.
6171 Add assertion against STRONG_AL type. Slightly rearrange code
6172 that determines the type of a neutral given the first non-neutral
6173 that follows it.
6174 (bidi_level_of_next_char): Set next_en_pos to zero when
6175 invalidating its info.
6176
2c91f553
EZ
61772011-10-17 Eli Zaretskii <eliz@gnu.org>
6178
6179 * xdisp.c (push_display_prop): Determine whether to record string
6180 or buffer position by IT->string, not by IT->method. Allow
6181 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6182 (move_it_vertically_backward): Don't look for character position
6183 immediately after the newline when in a continuation line.
6184 (Bug#9771, part 1)
2c91f553 6185
c7b08b0d
MR
61862011-10-15 Martin Rudalics <rudalics@gmx.at>
6187
6188 * window.c (coordinates_in_window): Rewrite and delabelize
6189 vertical border check. (Bug#5357) (Bug#9618)
6190
6b02f655
SM
61912011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6192
6193 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6194 errors in XSetWindowBorder (bug#9310).
6195
81d40c92
DA
61962011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6197
6198 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6199 avoid crash when xmalloc overrun checking is enabled.
6200
d4172c3b
EZ
62012011-10-13 Eli Zaretskii <eliz@gnu.org>
6202
6203 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6204 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6205 cursor motion with <left> and <right> arrow keys.
6206
6207 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6208 some callers set that themselves.
6209
b00eea75
EZ
62102011-10-12 Eli Zaretskii <eliz@gnu.org>
6211
6212 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6213 display string and the previous row comes from the same string and
6214 is empty. (Bug#9739) (Bug#9738)
6215
8fe012c4
SM
62162011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6217
6218 * doc.c (get_doc_string): Encode file name (bug#9735).
6219
0074aef2
EZ
62202011-10-12 Eli Zaretskii <eliz@gnu.org>
6221
79beb178
EZ
6222 * bidi.c (bidi_level_of_next_char):
6223 * xdisp.c (get_visually_first_element): Remove old incorrect
6224 comments regarding the Unicode Line Separator character.
6225
0074aef2
EZ
6226 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6227
6e4b3fbe
DA
62282011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6229
6230 * alloc.c (Fgc_status): Do not access beyond zombies array
6231 boundary if nzombies > MAX_ZOMBIES.
6232 * alloc.c (dump_zombies): Add missing format specifier.
6233
0324f3af
PE
62342011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6235
b5525cac
PE
6236 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6237 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6238
0324f3af
PE
6239 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6240 Some packages use them to denote characters with modifiers.
6241
e9b5f888
AS
62422011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6243
6244 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6245 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6246 matching a pp-number. Rename parameter var to var1.
6247
127827c0
SM
62482011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6249
6250 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6251
c8fd3bd0
GM
62522011-10-08 Glenn Morris <rgm@gnu.org>
6253
6254 * callint.c (Fcall_interactively): Give a more explicit error for the
6255 'c' case with a non-character input. (Bug#8479)
6256
352ec8ff
EZ
62572011-10-08 Eli Zaretskii <eliz@gnu.org>
6258
03669ccb
EZ
6259 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6260 lines.
7061c986
EZ
6261 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6262 lines that are hscrolled on the left.
03669ccb 6263
352ec8ff
EZ
6264 * dispnew.c (buffer_posn_from_coords): Account for a possible
6265 presence of header-line. (Bug#4426)
6266
a66cfb1c
SM
62672011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6268
6b02f655
SM
6269 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6270 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6271
7c5ee88e
PE
62722011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6273
6274 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6275 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6276 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6277 this makes Emacs dump core during garbage collection on rare
6278 occasions. sizeof is obviously inferior to offsetof here, so
6279 stick with offsetof.
6280 (GC_POINTER_ALIGNMENT): New macro.
6281 (mark_memory): Omit 3rd (offset) arg; caller changed.
6282 Don't assume EMACS_INT alignment is the same as pointer alignment.
6283
df1bbe5b
SM
62842011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6285
6286 * keyboard.c (read_key_sequence_remapped): New var.
6287 (read_key_sequence): Compute remapping in the right buffer.
6288 (command_loop_1): Use read_key_sequence's remapping directly.
6289
51553db6
SM
62902011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6291
32c1fffd
SM
6292 * dired.c (file_name_completion): Don't expand file name.
6293 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6294 before checking file name handler.
6295
51553db6
SM
6296 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6297 they've been requested explicitly (bug#9591).
6298
b6bd1599 62992011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6300
6301 * keymap.c (Fsingle_key_description): Use make_specified_string
6302 instead of build_string to build string from push_key_description.
6303 (Bug#5193)
6304
f701dc2a
PE
63052011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6306
4222c55d
PE
6307 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6308 This fixes a Y2038 bug on 64-bit hosts.
6309 * buffer.c (reset_buffer):
6310 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6311 (Fclear_buffer_auto_save_failure):
6312 Use 0, not -1, to represent an unset failure time, since time_t
6313 might not be signed.
6314
f701dc2a
PE
6315 Remove dependency on glibc malloc internals.
6316 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6317 Move back here from lisp.h, but with their new implementations.
6318 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6319 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6320 * charset.c (charset_table_init): New static var.
6321 (syms_of_charset): Use it instead of xmalloc. This removes a
6322 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6323 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6324 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6325 Move back to alloc.c.
6326 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6327 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6328
9ceebf39
JD
63292011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6330
6331 * nsterm.m (windowDidResize): Call x_set_window_size only when
6332 ns_in_resize is true. Otherwise set pixelwidth/height and
6333 call change_frame_size (Bug#9628).
6334
cb993c58
PE
63352011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6336
3930c88b
PE
6337 Port --enable-checking=all to Fedora 14 x86-64.
6338 * charset.c (syms_of_charset): Also account for glibc malloc's
6339 internal overhead when calculating the initial malloc maximum.
6340
cb993c58
PE
6341 Port --enable-checking=all to Fedora 14 x86.
6342 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6343 Move to lisp.h.
6344 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6345 (overrun_check_realloc, overrun_check_free):
6346 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6347 That way, xmalloc returns a properly-aligned pointer even if
6348 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6349 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6350 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6351 into account when calculating the initial malloc maximum.
6352 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6353 Move here from alloc.c, so that charset.c can use it too.
6354 Properly align; the old code wasn't right for common 32-bit hosts
6355 when configured with --enable-checking=all.
6356 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6357 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6358
31bed486
EZ
63592011-09-29 Eli Zaretskii <eliz@gnu.org>
6360
04c70788 6361 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6362 use EDOM.
6363
fbcaa2f3
EZ
63642011-09-28 Eli Zaretskii <eliz@gnu.org>
6365
6366 * xdisp.c (compute_display_string_end): If there's no display
6367 string at CHARPOS, return -1.
6368
6369 * bidi.c (bidi_fetch_char): When compute_display_string_end
6370 returns a negative value, treat the character as a normal
6371 character not covered by a display string. (Bug#9624)
6372
a239d4e9
JB
63732011-09-28 Juanma Barranquero <lekktu@gmail.com>
6374
6375 * lread.c (Fread_from_string): Fix typo in docstring.
6376
88652fd5
EZ
63772011-09-27 Eli Zaretskii <eliz@gnu.org>
6378
6379 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6380 newline, reseat the iterator instead of bidi-iterating there one
6381 character at a time. (Bug#9610)
32c1fffd
SM
6382 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6383 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6384
ed497dd4
AS
63852011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6386
6387 * lread.c (readevalloop): Use correct code for NBSP.
6388 (read1): Likewise. (Bug#9608)
6389
b2bf61aa
MA
63902011-09-25 Michael Albinus <michael.albinus@gmx.de>
6391
6392 * dbusbind.c (Fdbus_register_signal): When service is not
6393 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6394
32bbb17c
GM
63952011-09-25 Glenn Morris <rgm@gnu.org>
6396
6397 * buffer.c (truncate-lines): Doc fix.
6398
94e0933e
CY
63992011-09-24 Chong Yidong <cyd@stupidchicken.com>
6400
6401 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6402 (Fset_window_next_buffers): Doc fix.
6403
cddde921
GM
64042011-09-24 Glenn Morris <rgm@gnu.org>
6405
6406 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6407
1260aef1
PE
64082011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6409
25b4bfa0
PE
6410 Fix minor problems found by static checking.
6411 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6412 * indent.c (Fvertical_motion): Fix == vs = typo.
6413
e3cbd34b
EZ
64142011-09-24 Eli Zaretskii <eliz@gnu.org>
6415
a66cfb1c
SM
6416 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6417 Default value is now t. Doc fix.
6bf7006f 6418
e3cbd34b 6419 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6420 logic when moving up, not only when moving down. Fix the
e3cbd34b 6421 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6422 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6423
6424 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6425 CHARPOS is covered by a display string which includes newlines.
6426 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6427 is covered by a display string with embedded newlines.
6428
a3de0cbd
MA
64292011-09-24 Michael Albinus <michael.albinus@gmx.de>
6430
6431 * dbusbind.c (Fdbus_register_signal): Add match rule to
6432 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6433 (Fdbus_register_method, Vdbus_registered_objects_table):
6434 Fix docstring.
a3de0cbd 6435
b260039d
JM
64362011-09-24 Jim Meyering <meyering@redhat.com>
6437
32c1fffd 6438 do not ignore write error for any output size
b260039d
JM
6439 The previous change was incomplete.
6440 While it makes emacs --batch detect the vast majority of stdout
6441 write failures, errors were still ignored whenever the output size is
6442 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6443 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6444 && echo FAIL: ignored write error
6445 FAIL: ignored write error
6446 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6447 && echo FAIL: ignored write error
6448 FAIL: ignored write error
6449 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6450
8eca8a7c
AS
64512011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6452
6453 * emacs.c (Fkill_emacs): In noninteractive mode exit
6454 non-successfully if a write error occurred on stdout. (Bug#9574)
6455
3341db62
EZ
64562011-09-21 Eli Zaretskii <eliz@gnu.org>
6457
6458 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6459 the xassert test.
6460
6461 * dispextern.h (struct it): Update the comment documenting what
6462 can it->OBJECT be.
6463
8c203dbf
EZ
64642011-09-20 Eli Zaretskii <eliz@gnu.org>
6465
6466 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6467 a display string, extend search for cursor position to end of row.
6468 (find_row_edges): If the row ends in a newline from a display
6469 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6470 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6471 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6472 non-empty line. Fixes confusing cursor motion with arrow keys at
6473 the beginning of a line that starts with whitespace.
8c203dbf 6474
a4824228
LMI
64752011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6476
6477 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6478 (bug#9493).
6479
33ed493b
CY
64802011-09-18 Chong Yidong <cyd@stupidchicken.com>
6481
6482 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6483 boolean (Bug#9154).
6484
56cd55c8
EZ
64852011-09-18 Eli Zaretskii <eliz@gnu.org>
6486
6487 * xdisp.c (display_line): Record maximum and minimum buffer
6488 positions even if no glyphs were produced (e.g., by a zero-width
6489 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6490 buffer positions that will be removed from the glyph row because
6491 they don't fit.
c02dcedf
EZ
6492 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6493 column is beyond frame width: don't subtract 1 "pixel" when
6494 computing width of the stretch.
3e62b7e0
EZ
6495 (reseat_at_next_visible_line_start): Undo the change made on
6496 2011-09-17 that saved paragraph information and restored it after
6497 the call to `reseat'. (Bug#9545)
56cd55c8 6498
5ed99d36 64992011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6500
6501 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6502 and turn window cursor on if cleared (Bug#9415).
6503
5ed99d36 65042011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6505
6506 * search.c (boyer_moore): Take unibyte characters from pattern
6507 literally. (Bug#9458)
6508
9bade7b2
EZ
65092011-09-18 Eli Zaretskii <eliz@gnu.org>
6510
6511 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6512
e5e9d610
PE
65132011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6514
87e4427a
PE
6515 Fix minor problem found by static checking.
6516 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6517 initialized, to pacify gcc -Wuninitialized.
6518
e5e9d610
PE
6519 * fileio.c: Report proper errno when syscall falls.
6520 (Finsert_file_contents): Save and restore errno,
6521 so that report_file_error outputs the correct diagnostic.
6522 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6523
a1674f0b
EZ
65242011-09-18 Eli Zaretskii <eliz@gnu.org>
6525
6526 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6527
fbfb6dd4
EZ
65282011-09-17 Eli Zaretskii <eliz@gnu.org>
6529
6530 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6531 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6532
bb187662
EZ
65332011-09-17 Eli Zaretskii <eliz@gnu.org>
6534
1137e8b8 6535 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6536 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6537
6538 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6539 (bidi_find_paragraph_start): Search back for paragraph beginning
6540 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6541 (bidi_move_to_visually_next): Only trigger paragraph-related
6542 computations when the last character is a newline or at EOB, not
6543 just any NEUTRAL_B. (Bug#9470)
6544
bb187662
EZ
6545 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6546 truncated lines if point is covered by a display string. (Bug#9524)
6547
2e621251
PE
65482011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6549
6550 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6551 (cons_to_x_long): New function.
6552 (lisp_data_to_selection_data): Use it. Correct the test for
6553 short-versus-long data; it was negated. Break out of vector
6554 loop, for efficiency, when a long datum is discovered.
6555
91a15bc6
SM
65562011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6557
6558 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6559
b41c3a35
EZ
65602011-09-16 Eli Zaretskii <eliz@gnu.org>
6561
6562 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6563 GCC PR/17406) by declaring this function with external scope.
6564
7812ba2d
PE
65652011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6566
6567 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6568 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6569
cf7edc2a
AS
65702011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6571
6572 * editfns.c (Fformat): Correctly handle text properties on "%%".
6573
bd01620e
EZ
65742011-09-15 Eli Zaretskii <eliz@gnu.org>
6575
6576 * xterm.c (x_draw_composite_glyph_string_foreground):
6577 * w32term.c (x_draw_composite_glyph_string_foreground):
6578 * term.c (encode_terminal_code):
6579 * composite.c (composition_update_it, get_composition_id):
6580 * xdisp.c (get_next_display_element)
6581 (fill_composite_glyph_string): Add comments about special meaning
6582 of TAB characters in a composition.
6583
a02719a3
PE
65842011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6585
6586 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6587 This occurs when processing a multibyte format.
6588 Problem reported by Wolfgang Jenker.
a02719a3 6589
72589a3c
JB
65902011-09-15 Johan Bockgård <bojohan@gnu.org>
6591
6592 * xdisp.c (try_cursor_movement): Only check for exact match if
6593 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6594
1c14176c
PE
65952011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6596
6597 Remove unused external symbols.
6598 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6599 * xdisp.c (calc_pixel_width_or_height): Now static.
6600 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6601 * indent.c (check_display_width):
6602 * w32term.c: Fix comment to match code.
6603 * xterm.c, xterm.h (x_catching_errors): Remove.
6604
d2eea5b5
PE
66052011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6606
6607 * xselect.c: Use signed conversions more consistently (Bug#9498).
6608 (selection_data_to_lisp_data): Assume incoming selection data are
6609 signed integers, not unsigned. This is to be consistent with
6610 outgoing selection data, which was modified to use signed integers
6611 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6612 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6613 expects long, not unsigned long.
6614
46888499
EZ
66152011-09-14 Eli Zaretskii <eliz@gnu.org>
6616
6617 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6618 computation of loop end. Reported by Johan Bockgård
6619 <bojohan@gnu.org>.
6620
ef8ef9fb
CY
66212011-09-13 Chong Yidong <cyd@stupidchicken.com>
6622
6623 * frame.c (Fother_visible_frames_p): Function deleted.
6624
fa819fed
EZ
66252011-09-12 Eli Zaretskii <eliz@gnu.org>
6626
6627 * indent.c (compute_motion): Process display vector front to back
6628 rather than the other way around. (Bug#2496)
6629
2ba8e008
SM
66302011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6631
6632 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6633
20f53c69
CY
66342011-09-11 Chong Yidong <cyd@stupidchicken.com>
6635
6636 * minibuf.c (Fread_from_minibuffer): Doc fix.
6637
d562d7a4
EZ
66382011-09-11 Eli Zaretskii <eliz@gnu.org>
6639
6640 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6641 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6642
1c4d7f3d
LMI
66432011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6644
6645 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6646 value for non-existent files.
6647
b885bf36
EZ
66482011-09-11 Eli Zaretskii <eliz@gnu.org>
6649
6650 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6651 set its "size" to -1. This will set the modtime_size field of
6652 the corresponding buffer to -1, which is what
6653 verify-visited-file-modtime expects for files that do not exist.
6654 (Bug#9139)
6655
6612f0bf
PE
66562011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6657
6658 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6659 here ...
6660 * lisp.h: ... from here. push_key_description is no longer
6661 defined in keyboard.c, so its declaration should not be in
6662 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6663 logically belongs with push_key_description.
6664
dfb3f755
PE
66652011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6666
6667 * buffer.h: Include <sys/types.h> instead of <time.h>.
6668 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6669 Problem reported by Herbert J. Skuhra.
6670
3134906c
LMI
66712011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6672
6673 * xml.c (parse_region): Make the parsing work for
6674 non-comment-starting XML files again (bug#9144).
6675
8d903f4e
AS
66762011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6677
6678 * image.c (gif_load): Fix calculation of bottom and right corner.
6679 (Bug#9468)
6680
80ad64f4
EZ
66812011-09-10 Eli Zaretskii <eliz@gnu.org>
6682
6683 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6684 redisplay in small windows.
6685
208a048d
EZ
66862011-09-09 Eli Zaretskii <eliz@gnu.org>
6687
6688 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6689
9b1c252e
MR
66902011-09-08 Martin Rudalics <rudalics@gmx.at>
6691
6692 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6693 Operate on live windows only.
6694
2949f33b
JB
66952011-09-08 Juanma Barranquero <lekktu@gmail.com>
6696
6697 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6698
e08dcafd
EZ
66992011-09-07 Eli Zaretskii <eliz@gnu.org>
6700
6701 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6702 only under bidi iteration.
6703
115b96bd
JD
67042011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6705
6706 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6707
c8199d0f
PE
67082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6709
6710 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6711 Without this fix, the command to link temacs failed due to an
6712 undefined symbol __builtin_isnan. This is because
6713 /usr/include/iso/math_c99.h #defines isnan(x) to
6714 __builtin_isnan(x), but the bundled gcc, which identifies itself
6715 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6716 a __builtin_isnan.
6717 * floatfns.c (isnan): #undef, and then #define to a clone of
6718 what's in data.c.
6719 (Fisnan): Always define, since it's always available now.
6720 (syms_of_floatfns): Always define isnan at the Lisp level.
6721
e39b275c 67222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6723
6724 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6725
b2db44d9 67262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6727
f4af5137 6728 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6729 The previous code assumed that file offsets (off_t values) fit in
6730 EMACS_INT variables, which is not true on typical 32-bit hosts.
6731 The code messed up by falsely reporting buffer overflow in cases
6732 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6733 when "big" contains more than 2**29 bytes, even though this
6734 inserts just one byte and does not overflow the buffer.
6735 (Finsert_file_contents): Store file offsets as off_t
6736 values, not as EMACS_INT values. Check for overflow when
6737 converting between EMACS_INT and off_t. When checking for
6738 buffer overflow or for overlap, take the offsets into account.
6739 Don't use EMACS_INT for small values where int suffices.
6740 When checking for overlap, fix a typo: ZV was used where
6741 ZV_BYTE was intended.
6742 (Fwrite_region): Don't assume off_t fits into 'long'.
6743 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6744
ecfc0a49
MA
67452011-09-05 Michael Albinus <michael.albinus@gmx.de>
6746
6747 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6748
6511acf2 67492011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6750
0999621a 6751 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6752
6753 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6754 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6755 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6756 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6757 (modify_event_symbol): Do not assume that the length of
6758 name_alist_or_stem is safe to alloca and fits in int.
6759 (Fexecute_extended_command): Likewise for function name and binding.
6760 (Frecursion_depth): Wrap around reliably on integer overflow.
6761 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6762 since some callers pass EMACS_INT values.
6763 (Fsingle_key_description): Don't crash if symbol name contains more
6764 than MAX_ALLOCA bytes.
6765 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6766 (get_minibuffer): Arg is now EMACS_INT, not int.
6767 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6768 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6769 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6770
2be7d702
PE
6771 * dbusbind.c (signature_cat): New function.
6772 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6773 Do not overrun buffer; instead, report string overflow.
6774
9d1df220
PE
6775 * dispnew.c (add_window_display_history): Don't overrun buffer.
6776 Truncate instead; this is OK since it's just a log.
6777
33ef5c64
PE
6778 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6779 even if the time zone offset is outlandishly large.
6780 Don't mishandle offset == INT_MIN.
6781
66c6fdd5
PE
6782 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6783 when creating daemon; the previous buffer-overflow check was incorrect.
6784
d749b01b
PE
6785 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6786 which has the guts of the old verror function.
6787
b5cd1905
PE
6788 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6789 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6790
6e1a67fb
PE
6791 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6792 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6793 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6794 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6795 length of string rather than counting it via multiple sprintfs;
6796 that's simpler and more reliable.
c21721cc
PE
6797 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6798 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6799 sprintf, in case result does not fit in int.
6800
c57b67fc
PE
6801 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6802 (fontset_from_font): Print it.
6803
8a401434
PE
6804 * frame.c (tty_frame_count): Now printmax_t, not int.
6805 (make_terminal_frame, set_term_frame_name): Print it.
6806 (x_report_frame_params): In X, window IDs are unsigned long,
6807 not signed long, so print them as unsigned.
6808 (validate_x_resource_name): Check for implausibly long names,
6809 and don't assume name length fits in 'int'.
6810 (x_get_resource_string): Don't blindly alloca invocation name;
6811 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6812 not fit in int.
6813
6e1a67fb
PE
6814 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6815 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6816 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6817
0df02bf3
PE
6818 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6819 Use esprintf, not sprintf, in case result does not fit in int.
6820
48e30793
PE
6821 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6822 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6823 it as a large positive number.
6824 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6825 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6826
a66ff6d8
PE
6827 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6828 in case result does not fit in int.
6829
aca216ff
PE
6830 * print.c (float_to_string): Detect width overflow more reliably.
6831 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6832 buffer overrun. Don't assume list length fits in 'int'. Treat
6833 print length of 0 as 0, not as infinity; to be consistent with other
6834 uses of print length in this function. Don't overflow print length
6835 index. Don't assume hash table size fits in 'long', or that
6836 vectorlike size fits in 'unsigned long'.
6837
31c286f7
PE
6838 * process.c (make_process): Use printmax_t, not int, to format
6839 process-name gensyms.
6840
55e5faa1
PE
6841 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6842
80f2e268
PE
6843 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6844 to avoid potential buffer overrun.
6845
670741ab
PE
6846 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6847 if X resource line is longer than 512 bytes.
6848
b7163a50
PE
6849 * xfns.c (x_window): Make sprintf buffer a bit bigger
6850 to avoid potential buffer overrun.
6851
ae58ff1f
PE
6852 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6853
c43c8a6a
PE
6854 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6855
3f8236f4
PE
68562011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6857
53e9fe90 6858 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6859 Without these, Emacs silently mishandles large integers sometimes.
6860 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6861 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6862
6511acf2
PE
6863 * xdisp.c (try_window_id): Check Emacs fixnum range before
6864 converting to 'int'.
806add1d 6865
6511acf2 6866 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6867 Check that an Emacs fixnum is in range before assigning it to 'int'.
6868 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6869 values converted from Emacs fixnums.
6870 (Frecenter): Don't wrap around a line count if it is out of 'int'
6871 range; instead, treat it as an extreme value.
6872 (Fset_window_configuration, compare_window_configurations):
6873 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6874
6511acf2
PE
6875 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6876 that can exceed INT_MAX. Check that EMACS_INT value is in range
6877 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6878 (match_limit): Don't assume that a fixnum can fit in 'int'.
6879
6511acf2 6880 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6881 exceed INT_MAX.
6882
6511acf2 6883 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6884 (Fvertical_motion): Don't wrap around LINES values that don't fit
6885 in 'int'. Instead, treat them as extreme values. This is good
6886 enough for windows, which can't have more than INT_MAX lines anyway.
6887
fcb901a7
LMI
68882011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6889
0f2f6b6d
LMI
6890 * Require libxml/parser.h to avoid compilation warning.
6891
fcb901a7
LMI
6892 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6893
6894 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6895 since this reportedly can destroy thread storage.
6896
6e20a0d4
CY
68972011-08-30 Chong Yidong <cyd@stupidchicken.com>
6898
6899 * syntax.c (find_defun_start): Update all cache variables if
6900 exiting early (Bug#9401).
6901
148ae00e
EZ
69022011-08-30 Eli Zaretskii <eliz@gnu.org>
6903
f6cfbd8f
EZ
6904 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6905
148ae00e
EZ
6906 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6907 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6908 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6909
6910 * term.c (tty_append_glyph): New function.
6911 (produce_stretch_glyph): Static function and its prototype deleted.
6912
a66cfb1c
SM
6913 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6914 Add prototypes.
148ae00e 6915
c4a07a4c
PE
69162011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6917
6918 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6919 when checking :margin (Bug#9390).
6920 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6921 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6922 so that the name doesn't mislead. All uses changed.
6923
6bc8cd65
JB
69242011-08-28 Johan Bockgård <bojohan@gnu.org>
6925
6926 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6927 set_tty_hooks.
6928
dca4927e
EZ
69292011-08-27 Eli Zaretskii <eliz@gnu.org>
6930
6931 * xdisp.c (move_it_to): Don't bail out early when reaching
6932 position beyond to_charpos, if we are scanning backwards.
6933 (move_it_vertically_backward): When DY == 0, make sure we get to
6934 the first character in the line after the newline.
6935
f2cad773
PE
69362011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6937
6938 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6939 (ccl_driver): Do not generate an out-of-range pointer.
6940 (Fccl_execute_on_string): Remove unnecessary check for
6941 integer overflow, noted by Stefan Monnier in
6942 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6943 Remove a FIXME that didn't need fixing.
6944 Simplify the newly-introduced buffer reallocation code.
6945
0cae2cdb
JB
69462011-08-27 Juanma Barranquero <lekktu@gmail.com>
6947
6948 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6949
5fc295a4 69502011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6951
70c60eb2 6952 Integer and memory overflow issues (Bug#9196).
726e0ab1 6953
d31850da
PE
6954 * doc.c (get_doc_string): Rework so that
6955 get_doc_string_buffer_size is the actual buffer size, rather than
6956 being 1 less than the actual buffer size; this makes xpalloc more
6957 convenient.
6958
a69fbedb
PE
6959 * image.c (x_allocate_bitmap_record, cache_image):
6960 * xselect.c (Fx_register_dnd_atom):
6961 Simplify previous changes by using xpalloc.
6962
fe5c5d37
PE
6963 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6964 since either will do and ptrdiff_t is convenient with xpalloc.
6965
0065d054
PE
6966 * charset.c (charset_table_size)
6967 (struct charset_sort_data.priority): Now ptrdiff_t.
6968 (charset_compare): Don't overflow if priorities differ greatly.
6969 (Fsort_charsets): Don't assume list length fits in int.
6970 Check for size-calculation overflow when allocating sort data.
6971 (syms_of_charset): Allocate an initial charset table that is
6972 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6973
6974 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6975
6976 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6977 The actual value is always <= INT_MAX, and leaving it unsigned made
6978 overflow checking harder.
6979
6980 * dispextern.h (struct glyph_matrix.rows_allocated)
6981 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6982 with xpalloc. The values are still always <= INT_MAX.
6983
6984 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6985
6986 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6987 (SAFE_NALLOCA): New macro.
6988
6989 * region-cache.c (struct boundary.pos, find_cache_boundary)
6990 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6991 (set_cache_region, invalidate_region_cache)
6992 (revalidate_region_cache, know_region_cache, region_cache_forward)
6993 (region_cache_backward, pp_cache):
6994 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6995 so that ptrdiff_t * can be passed to xpalloc.
6996 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6997 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6998 (pp_cache): Don't assume cache_len fits in int.
6999 * region-cache.h: Adjust extern decls to match.
7000
7001 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7002 EMACS_INT, since either will do, for xpalloc.
7003
7004 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7005 (xnmalloc, xnrealloc, xpalloc): New functions.
7006
726e0ab1
PE
7007 * bidi.c (bidi_shelve_header_size): New constant.
7008 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7009 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7010
51f30bc5 7011 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7012 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7013 (overlay_strings):
7014 Don't update size of array until after memory allocation succeeds,
7015 because xmalloc/xrealloc may not return.
0065d054
PE
7016 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7017 now that we have proper integer overflow checking.
7018 (record_overlay_string, overlay_strings): Catch overflows when
7019 calculating size of overlay_str_buf.
726e0ab1 7020
0065d054
PE
7021 * callproc.c (Fcall_process): Check for size overflow when
7022 calculating size of args2.
7023 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7024 Normally we prefer signed values, but sticking with ptrdiff_t would
7025 require adding more-complicated checks.
726e0ab1
PE
7026
7027 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7028 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7029 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7030 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7031
7032 * character.c (Fstring): Check for size-calculation overflow.
7033
7034 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7035 unnecessary integer overflow. Check for size overflow.
7036 (encode_coding_object): Don't update size until xmalloc succeeds.
7037
7038 * composite.c (get_composition_id): Check for overflow in glyph
7039 length calculations.
7040
7041 Integer and memory overflow fixes for display code.
7042 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7043 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7044 (scrolling_window): Check for overflow in size calculations.
7045 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7046 Don't assume glyph table len fits in int.
7047 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7048 (row_table_size): Now ptrdiff_t, not int.
7049 (scrolling_window): Avoid overflow in size calculations.
7050 Don't update size until allocation succeeds.
7051 * fns.c (concat): Check for overflow in size calculations.
7052 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7053 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7054 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7055
7056 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7057 (get_doc_string): Check for size calculation overflow.
7058 Don't update size until allocation succeeds.
7059 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7060 EMACS_INT, where ptrdiff_t will do.
7061 (Fsubstitute_command_keys): Check for string overflow.
7062
7063 * editfns.c (set_time_zone_rule): Don't assume environment length
7064 fits in int.
7065 (message_length): Now ptrdiff_t, not int.
7066 (Fmessage_box): Don't update size until allocation succeeds.
7067 Don't assume message length fits in int.
7068 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7069
0065d054
PE
7070 * emacs.c (main): Do not reallocate argv, since there is a null at
7071 the end that can be overwritten, and this way there's no need to
7072 worry about size-calculation overflow.
7073 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7074
7075 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7076 alloc succeeds.
7077 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7078
7079 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7080 (x_set_scroll_bar_width, x_figure_window_size):
7081 Check for integer overflow.
7082 (x_set_alpha): Do not assume XINT fits in int.
7083
7084 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7085 This is for the members text_lines, text_cols, total_lines, total_cols,
7086 where the system imposes an 'int' limit.
7087
7088 * fringe.c (Fdefine_fringe_bitmap):
7089 Don't update size until alloc works.
7090
7091 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7092 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7093
7094 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7095 Check for size-calculation overflow.
7096 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7097 do, as we prefer signed integers.
7098 (id_to_widget.max_size, id_to_widget.used)
7099 (xg_store_widget_in_map, xg_remove_widget_from_map)
7100 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7101 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7102 Use and return ptrdiff_t, not int.
7103 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7104 * gtkutil.h: Change prototypes to match the above.
7105
7106 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7107 are duplicate now that they've been promoted to lisp.h.
7108 (x_allocate_bitmap_record, x_alloc_image_color)
7109 (make_image_cache, cache_image, xpm_load):
7110 Don't update size until alloc is done.
7111 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7112 (x_detect_edges):
3256efce 7113 Check for size calculation overflow.
726e0ab1
PE
7114 (ct_colors_allocated_max): New constant.
7115 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7116 overflow.
3256efce 7117
726e0ab1
PE
7118 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7119 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7120 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7121 Use ptrdiff_t, not int, to count maps.
7122 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7123 calculations. Don't update size until allocation succeeds.
7124 Redo calculations to avoid overflow.
726e0ab1
PE
7125 * keyboard.h: Change prototypes to match the above.
7126
7127 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7128 to count maps.
7129 (current_minor_maps): Check for size calculation overflow.
7130 * keymap.h: Change prototypes to match the above.
7131
7132 * lread.c (read1, init_obarray): Don't update size until alloc done.
7133
7134 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7135 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7136
726e0ab1
PE
7137 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7138 Now ptrdiff_t, not int.
7139 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7140 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7141
7142 * process.c (Fnetwork_interface_list): Check for overflow
7143 in size calculation.
7144
7145 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7146
7147 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7148 overflow. Don't bother calling xmalloc when xrealloc will do.
7149
7150 * search.c (Freplace_match): Check for size calculation overflow.
7151 (Fset_match_data): Don't assume list lengths fit in 'int'.
7152
7153 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7154 for command line length. Do not attempt to address one before the
7155 beginning of an array, as that's not portable.
7156
7157 * term.c (max_frame_lines): Remove; unused.
7158 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7159 not int.
7160 (encode_terminal_code, calculate_costs): Check for size
7161 calculation overflow.
7162 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7163 table lengths and related sizes. Don't update size until alloc
7164 done. Redo calculations to avoid overflow.
7165 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7166
7167 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7168 subtracting pointers.
7169 (gobble_line): Check for overflow more carefully. Don't update size
7170 until alloc done.
7171
7172 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7173 Don't update size until alloc done.
7174 Redo size calculations to avoid overflow.
7175 Check for size calculation overflow.
0065d054 7176 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7177
7178 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7179 Use ptrdiff_t, not int, for sizes.
7180 (store_mode_line_noprop_char): Don't update size until alloc done.
7181
0065d054
PE
7182 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7183 Use ptrdiff_t, not int, for sizes.
7184 (Finternal_make_lisp_face, cache_face):
7185 Check for size calculation overflow.
7186 (cache_face): Treat size calculation overflows as if they were
7187 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7188
7189 * xfns.c (x_encode_text, x_set_name_internal)
7190 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7191 sizes, since they can exceed INT_MAX in size. Check for size
7192 calculation overflow.
7193
0065d054
PE
7194 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7195 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7196 Don't update size until alloc done.
7197
0065d054 7198 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7199 as sprintf is limited to int lengths.
1d526e2f 7200
252c5ee1
PE
7201 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7202 (X_LONG_MIN): New macros.
864d7ce7
PE
7203 Use them to make the following changes clearer.
7204 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7205 This change doesn't affect the value now, but it may help remind
7206 future maintainers not to raise the value too much later.
7207 (SELECTION_QUANTUM): Remove, replacing with ...
7208 (selection_quantum): ... new function, which avoids overflow.
7209 All uses changed.
7210 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7211 assumption that selection length fits in 'int'.
7212 (x_reply_selection_request, x_handle_selection_request)
7213 (x_get_window_property, receive_incremental_selection)
7214 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7215 (lisp_data_to_selection_data, clean_local_selection_data):
7216 Use ptrdiff_t, not int, to record length of selection.
7217 (x_reply_selection_request, x_get_window_property)
7218 (receive_incremental_selection, x_property_data_to_lisp):
7219 Redo calculations to avoid overflow.
7220 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7221 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7222 something.
7223 (x_get_window_property, receive_incremental_selection)
7224 (lisp_data_to_selection_data, x_property_data_to_lisp):
7225 Check for size-calculation overflow.
7226 (x_get_window_property, receive_incremental_selection)
7227 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7228 Don't store size until memory allocation succeeds.
7229 (x_get_window_property): Plug memory leak on memory exhaustion.
7230 Don't double-block input; malloc is safe here. Don't assume 2**34
7231 - 4 fits in unsigned long. Add an xassert to check
7232 XGetWindowProperty overflow. Be more careful about overflow
7233 calculations, and distinguish size from memory overflow better.
7234 (receive_incremental_selection): When tracing, don't assume
7235 unsigned int is less than INT_MAX.
7236 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7237 harmful) conversions of unsigned short to int.
7238 (lisp_data_to_selection_data): Don't assume that integers
7239 in the range -65535 through -1 fit in an X unsigned short.
7240 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7241 result parameters unless successful. Rely on cons_to_unsigned
7242 to report problems with elements; the old code wasn't right anyway.
7243 (x_check_property_data): Check for int overflow; we cannot use
7244 a wider type due to X limits.
7245 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7246
726e0ab1 7247 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7248
0065d054
PE
7249 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7250 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7251 (x_color_cells): Don't store size until memory allocation succeeds.
7252 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7253 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7254 (x_term_init): Don't assume length fits in int (sprintf is limited
7255 to int size).
bc18e09d 7256
ebfa62c0
PE
7257 Use ptrdiff_t for composition IDs.
7258 * character.c (lisp_string_width):
7259 * composite.c (composition_table_size, n_compositions)
7260 (get_composition_id, composition_gstring_from_id):
7261 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7262 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7263 * window.c (Frecenter):
7264 Use ptrdiff_t, not int, for composition IDs.
7265 * composite.c (get_composition_id): Check for integer overflow.
7266 * composite.h: Adjust prototypes to match the above changes.
7267
d3411f89
PE
7268 Use ptrdiff_t for hash table indexes.
7269 * category.c (hash_get_category_set):
7270 * ccl.c (ccl_driver):
7271 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7272 * coding.c (coding_system_charset_list, detect_coding_system):
7273 * coding.h (struct coding_system.id):
7274 * composite.c (get_composition_id, gstring_lookup_cache):
7275 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7276 * image.c (xpm_get_color_table_h):
7277 * lisp.h (hash_lookup, hash_put):
7278 * minibuf.c (Ftest_completion):
7279 Use ptrdiff_t for hash table indexes, not int (which is too
7280 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7281 32-bit --with-wide-int hosts).
7282
e097a6fa
PE
7283 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7284 Add a FIXME comment about memory leaks.
7285 (syms_of_charset): Don't assume xmalloc returns.
7286
5637687f
PE
7287 Don't assume that stated character widths fit in int.
7288 * character.c (Fchar_width, c_string_width, lisp_string_width):
7289 * character.h (CHAR_WIDTH):
7290 * indent.c (MULTIBYTE_BYTES_WIDTH):
7291 Use sanitize_char_width to avoid undefined and/or bad behavior
7292 with outlandish widths.
a66cfb1c 7293 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7294 now that we have two such functions. All uses changed.
7295 (sanitize_char_width): New inline function.
7296
a2271ba2
PE
7297 Don't assume that tab-width fits in int.
7298 * character.h (sanitize_width): New inline function.
7299 (SANE_TAB_WIDTH): New macro.
7300 (ASCII_CHAR_WIDTH): Use it.
7301 * indent.c (sane_tab_width): Remove. All uses replaced by
7302 SANE_TAB_WIDTH (current_buffer).
7303 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7304
18c52557
PE
7305 * fileio.c: Integer overflow issues with file modes.
7306 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7307
caeeedc1
PE
7308 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7309 Remove unreachable code.
7310 (read_hex, load_charset_map_from_file): Check for integer overflow.
7311
6df6ae42 7312 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7313 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7314 (x_send_scroll_bar_event): Likewise. Check that the size does not
7315 exceed limits imposed by XClientMessageEvent, as well as the usual
7316 ptrdiff_t and size_t limits.
7317
b13995db
PE
7318 * keyboard.c: Overflow, signedness and related fixes.
7319 (make_lispy_movement): Use same integer type in forward decl
7320 that is used in the definition.
7321 (read_key_sequence, keyremap_step):
7322 Change bufsize argument back to int, undoing my 2011-03-30 change.
7323 We prefer signed types, and int is wide enough here.
7324 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7325 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7326 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7327 length, not size_t. Use ptrdiff_t for index, not int.
7328 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7329 possibility of integer overflow.
7330
13464394
PE
7331 Overflow, signedness and related fixes for images.
7332
7333 * dispextern.h (struct it.stack[0].u.image.image_id)
7334 (struct_it.image_id, struct image.id, struct image_cache.size)
7335 (struct image_cache.used, struct image_cache.ref_count):
7336 * gtkutil.c (update_frame_tool_bar):
7337 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7338 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7339 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7340 * nsmenu.m (update_frame_tool_bar):
7341 * xdisp.c (calc_pixel_width_or_height):
7342 * xfns.c (image_cache_refcount):
7343 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7344 on typical 64-bit hosts.
7345
7346 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7347 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7348 Omit unnecessary casts to int.
7349 (parse_image_spec): Check that integers fall into 'int' range
7350 when the callers expect that.
7351 (image_ascent): Redo ascent calculation to avoid int overflow.
7352 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7353 (lookup_image): Remove unnecessary tests.
7354 (xbm_image_p): Locals are now of int, not EMACS_INT,
7355 since parse_image_check makes sure they fit into int.
7356 (png_load, gif_load, svg_load_image):
7357 Prefer int to unsigned where either will do.
7358 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7359 old tiff_error_handler and tiff_warning_handler.
7360 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7361 stack buffer overflows. It uses only the features of vsnprintf
7362 that are common to both POSIX and native Microsoft.
7363 (tiff_error_handler, tiff_warning_handler): Use it.
7364 (tiff_load, gif_load, imagemagick_load_image):
7365 Don't assume :index value fits in 'int'.
7366 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7367 (imagemagick_load_image): Check that crop parameters fit into
7368 the integer types that MagickCropImage accepts. Don't assume
7369 Vimagemagick_render_type has a nonnegative value. Don't assume
7370 size_t fits in 'long'.
7371 (gs_load): Use printmax_t to print the widest integers possible.
7372 Check for integer overflow when computing image height and width.
7373
c11821d4
EZ
73742011-08-26 Eli Zaretskii <eliz@gnu.org>
7375
7376 * xdisp.c (redisplay_window): Don't force window start if point
7377 will be invisible in the resulting window. (Bug#9324)
7378
0c95fcf7
EZ
73792011-08-25 Eli Zaretskii <eliz@gnu.org>
7380
7381 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7382 the display spec is of the form `(space ...)'.
7383 (handle_display_spec): Return the value returned by
7384 handle_single_display_spec, not just 1 or zero.
7385 (handle_single_display_spec): If the display spec is of the form
7386 `(space ...)', and specifies display in the text area, return 2
7387 rather than 1.
fee65a97 7388 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7389 accurately, and prefer exact match for point under bidi.
7390 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7391
7392 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7393 into disp_prop; all users changed.
7394
7395 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7396 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7397 for the text covered by the display property.
7398
e4ed06f1
CY
73992011-08-25 Chong Yidong <cyd@stupidchicken.com>
7400
7401 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7402 Change return value to nil.
7403 (Frecord_buffer): Delete unused function.
7404
f67cdd7f
EZ
74052011-08-24 Eli Zaretskii <eliz@gnu.org>
7406
5980d4c6
EZ
7407 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7408 buffers, return left-to-right.
8610fe8b
EZ
7409 (set_cursor_from_row): Consider candidate row a win if its glyph
7410 represents a newline and point is on that newline. Fixes cursor
7411 positioning on the newline at EOL of R2L text within L2R
7412 paragraph, and vice versa.
7413 (try_cursor_movement): Check continued rows, in addition to
7414 continuation rows. Fixes unwarranted scroll when point enters a
7415 continued line of R2L text within an L2R paragraph, or vice versa.
7416 (cursor_row_p): Consider the case of point being equal to
7417 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7418 from the end of a short line to the beginning of a continued line
7419 of R2L text within L2R paragraph.
7420 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7421 composed characters.
5980d4c6 7422
f67cdd7f
EZ
7423 * bidi.c (bidi_check_type): Use xassert.
7424 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7425 members.
7426
bca633fb
EZ
74272011-08-23 Eli Zaretskii <eliz@gnu.org>
7428
7429 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7430 a character.
7431
4a5885a7
CY
74322011-08-23 Chong Yidong <cyd@stupidchicken.com>
7433
7434 * nsfont.m (ns_otf_to_script): Fix typo.
7435
0902a04e
KH
74362011-08-22 Kenichi Handa <handa@m17n.org>
7437
7438 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7439 extra slot even if the purpose is char-code-property-table.
7440
1a2e6670
EZ
74412011-08-23 Eli Zaretskii <eliz@gnu.org>
7442
8ddde651
EZ
7443 * xdisp.c (redisplay_window): When computing centering_position,
7444 account for the height of the header line. (Bug#8874)
7445
425cc014
EZ
7446 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7447 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7448 candidate is selected by the mouse, and that candidate has a
7449 composed character under the mouse.
7450
1a2e6670
EZ
7451 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7452 coordinates reported by pos-visible-in-window-p for a composed
7453 character in column zero.
7454
8b76d6f8
SM
74552011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7456
7457 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7458
dac347dd
EZ
74592011-08-22 Eli Zaretskii <eliz@gnu.org>
7460
7461 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7462 consider it a hit if to_charpos is anywhere in the range of the
7463 composed buffer positions.
7464
e013fb34
CY
74652011-08-22 Chong Yidong <cyd@stupidchicken.com>
7466
7467 * image.c (gif_load): Don't assume that each subimage has the same
7468 dimensions as the base image. Handle disposal method that is
7469 "undefined" by the gif spec (Bug#9335).
7470
bd1ba3e8
CY
74712011-08-20 Chong Yidong <cyd@stupidchicken.com>
7472
7473 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7474 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7475
54a1215b
EZ
74762011-08-19 Eli Zaretskii <eliz@gnu.org>
7477
823564e5
EZ
7478 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7479 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7480 from an Org mode buffer to a Speedbar frame.
7481
54a1215b
EZ
7482 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7483 a composition, take its buffer position from IT->cmp_it.charpos.
7484 Fixes cursor positioning at the beginning of a line that begins
7485 with a composed character.
7486
9778ebcc
EZ
74872011-08-18 Eli Zaretskii <eliz@gnu.org>
7488
0be6ee06
EZ
7489 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7490 character bidirectional type, use STRONG_L instead. Fixes crashes
7491 in a buffer produced by `describe-categories'.
7492
9778ebcc
EZ
7493 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7494 members before the level stack, so they would be saved and
7495 restored when copying iterator state. Fixes incorrect reordering
7496 around TABs covered by display properties.
7497
156bffbe
AS
74982011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7499
6b02f655 7500 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7501
72ad093b
CY
75022011-08-17 Chong Yidong <cyd@stupidchicken.com>
7503
7504 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7505 (internal_condition_case_2, internal_condition_case_n):
7506 Remove unnecessary aborts (Bug#9081).
72ad093b 7507
35774242
EZ
75082011-08-17 Eli Zaretskii <eliz@gnu.org>
7509
7510 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7511 has no `load' handler, try opening the file locally. (Bug#9311)
7512
db76dd85
KB
75132011-08-16 Ken Brown <kbrown@cornell.edu>
7514
7515 * gmalloc.c: Expand comment.
7516
b215eee5
EZ
75172011-08-16 Eli Zaretskii <eliz@gnu.org>
7518
7519 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7520 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7521
a4579d33
KB
75222011-08-16 Ken Brown <kbrown@cornell.edu>
7523
7524 Fix memory allocation problems in Cygwin build (Bug#9273).
7525
7526 * unexcw.c ( __malloc_initialized): Declare external variable.
7527 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7528
8b76d6f8
SM
7529 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7530 New variables.
a4579d33
KB
7531 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7532 dumped emacs.
7533 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7534 in the static heap.
7535 [CYGWIN] (special_realloc): New function.
7536 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7537 requests to realloc storage in the static heap.
7538
3ebec551
PE
75392011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7540
7541 * bidi.c (bidi_initialize): Remove unused local.
7542
9fd8be00
EZ
75432011-08-15 Eli Zaretskii <eliz@gnu.org>
7544
6b02f655
SM
7545 * bidimirror.h:
7546 * biditype.h: Remove file.
7547 * makefile.w32-in ($(BLD)/bidi.$(O)):
7548 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7549
7550 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7551
7552 * chartab.c: Improve commentary for the uniprop_table API.
7553
32413314
EZ
7554 * bidi.c (bidi_paragraph_init): Support zero value of
7555 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7556 (bidi_initialize): Use uniprop_table instead of including
7557 biditype.h and bidimirror.h.
32413314 7558
9fd8be00
EZ
7559 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7560 coordinates of the iterator when restoring from ppos_it.
7561 (Bug#9296)
7562
5cf2b69b
KH
75632011-08-14 Kenichi Handa <handa@m17n.org>
7564
7565 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7566 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7567
daf17d00
EZ
75682011-08-14 Eli Zaretskii <eliz@gnu.org>
7569
7570 * xdisp.c (move_it_in_display_line_to): Don't invoke
7571 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7572 ppos_it. Fixes vertical cursor motion when line beginning is
7573 covered by an image. (Bug#9296)
7574
08e3161a
JD
75752011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7576
7577 * nsterm.h (ns_run_ascript): Declare.
7578 (NSAPP_DATA2_RUNASSCRIPT): Define.
7579
7580 * nsfns.m (as_script, as_result, as_status): New static variables.
7581 (ns_run_ascript): New function.
5e617bc2 7582 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7583 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7584 the event loop. Get status from as_status (Bug#7276).
7585
7586 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7587 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7588 the event loop (Bug#7276).
7589
a3720aa2
AS
75902011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7591
7592 * gnutls.c (QCgnutls_bootprop_priority)
7593 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7594 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7595 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7596 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7597 (QCgnutls_bootprop_verify_hostname_error)
7598 (QCgnutls_bootprop_callbacks_verify): Rename from
7599 Qgnutls_bootprop_..., all uses changed.
7600
7601 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7602 uses changed.
7603
0a0d27fb
PE
76042011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7605
19d5c50c
PE
7606 * xfaces.c (Qframe_set_background_mode): Now static.
7607 * dispextern.h (Qframe_set_background_mode): Remove decl.
7608
0a0d27fb
PE
7609 * process.c (Fnetwork_interface_info): Declare local only if needed.
7610
377538cb
JD
76112011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7612
7613 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7614 (Fnetwork_interface_list): Allocate in increments of bytes instead
7615 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7616 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7617 sockaddr.
7618 (struct ifflag_def): notrailers is smart on OSX.
7619 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7620 Get hardware address with getifaddrs if available.
7621
08fff70c
EZ
76222011-08-12 Eli Zaretskii <eliz@gnu.org>
7623
7624 * xdisp.c (iterate_out_of_display_property): xassert that
7625 IT->position is set to within IT->object's boundaries. Break from
7626 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7627 when IT->position is set up wrongly due to some bug.
7628 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7629 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7630 entry. Force push_it to save on the stack the current
7631 buffer/string position, to be restored by pop_it. Fix flags in
7632 the iterator structure wrt the object coming from a display
7633 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7634 properties. (Bug#9284)
7635
7be1c708 76362011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7637
7be1c708
CY
7638 * fontset.c (fontset_get_font_group): Add proper type checks.
7639 (Bug#9172)
aac0c6e3 7640
7be1c708 76412011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7642
7be1c708
CY
7643 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7644 and LC_VERSION_MIN_MACOSX.
7645 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7646 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7647
97bb72a6
EZ
76482011-08-08 Eli Zaretskii <eliz@gnu.org>
7649
7650 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7651 no-display-properties-and-no-overlays under bidi display.
7652 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7653 properties and overlays.
97bb72a6 7654
d5617611
CY
76552011-08-08 Chong Yidong <cyd@stupidchicken.com>
7656
37e11a63
CY
7657 * editfns.c (Fset_time_zone_rule): Document relationship with the
7658 setenv function.
7659
d5617611
CY
7660 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7661 the font entity extracted from the cache (Bug#8109).
7662
58872834
CY
76632011-08-07 Chong Yidong <cyd@stupidchicken.com>
7664
7665 * composite.c (autocmp_chars): Don't reset point. That is done by
7666 restore_point_unwind (Bug#5984).
7667
75bfc667
JL
76682011-08-07 Juri Linkov <juri@jurta.org>
7669
7670 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7671 to show the arg `TIME' instead of `TIMEVAL'.
7672
d1410150
EZ
76732011-08-06 Eli Zaretskii <eliz@gnu.org>
7674
7675 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7676 display property strides EOL and includes a newline, as in
7677 longlines-mode. (Bug#9254)
75b771e4
EZ
7678 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7679 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7680
7681 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7682 is non-zero, even if the data buffer is NULL. Fixes a crash in
7683 vertical-motion with longlines-mode. (Bug#9254)
7684
35928349
EZ
76852011-08-05 Eli Zaretskii <eliz@gnu.org>
7686
ec7cc85b
EZ
7687 * bidi.c <bidi_cache_total_alloc>: Now static.
7688 (bidi_initialize): Initialize bidi_cache_total_alloc.
7689
8b76d6f8 7690 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7691 cache. (Bug#9221)
7692
7693 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7694 amount allocated this far in `bidi_cache_total_alloc'.
7695 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7696 non-zero, only free the data buffer without restoring the cache
7697 contents. All callers changed.
7698
7699 * dispextern.h (bidi_unshelve_cache): Update prototype.
7700
7701 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7702 (move_it_in_display_line, move_it_to)
7703 (move_it_vertically_backward, move_it_by_lines): Replace the call
7704 to xfree to an equivalent call to bidi_unshelve_cache.
7705 (move_it_in_display_line_to): Fix logic of returning
412b6358 7706 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7707
e2e2423b
EZ
77082011-08-05 Eli Zaretskii <eliz@gnu.org>
7709
7710 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7711 came from a string character with a `cursor' property. (Bug#9229)
7712
ae9e757a
JD
77132011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7714
7715 * Makefile.in (LIB_PTHREAD): New variable.
7716 (LIBES): Add LIB_PTHREAD (Bug#9216).
7717
7718 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7719 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7720
213bd7f2
AS
77212011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7722
6b02f655 7723 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7724
99aaf75f
JD
77252011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7726
7727 * xterm.c (x_find_topmost_parent): New function.
7728 (x_set_frame_alpha): Find topmost parent window with
7729 x_find_topmost_parent and set the property there also (bug#9181).
7730 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7731
c74e9d86
PE
77322011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7733
7734 * callproc.c (Fcall_process): Avoid vfork clobbering
7735 the local vars buffer, coding_systems, current_dir.
7736
640c8776
SM
77372011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7738
7739 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7740
f26d0e4c
PE
77412011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7742
8a10d76c
PE
7743 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7744 so that it is not optimized away.
7745
f26d0e4c
PE
7746 * xdisp.c (compute_display_string_pos): Remove unused local.
7747
55439c61
EZ
77482011-08-02 Eli Zaretskii <eliz@gnu.org>
7749
7750 Fix slow cursor motion and scrolling in large buffers with
7751 selective display, like Org Mode buffers. (Bug#9218)
7752
7753 * dispextern.h (struct bidi_it): New member disp_prop_p.
7754
7755 * xdisp.c: Remove one-slot cache of display string positions.
7756 (compute_display_string_pos): Accept an additional argument
5e617bc2 7757 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7758 for a display string or property. If found, set DISP_PROP_P
7759 non-zero.
7760
7761 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7762 DISP_PROP_P, and pass it to compute_display_string_pos.
7763 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7764 non-zero. All callers of bidi_fetch_char changed.
7765
fb33fa43
SM
77662011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7767
7768 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7769
b099e063
DM
77702010-12-03 Don March <don@ohspite.net>
7771
7772 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7773 last character M-[char] is translated to ESC [char] (bug#7541).
7774
5cc7f7af
KH
77752011-08-02 Kenichi Handa <handa@m17n.org>
7776
d0fffa3f 7777 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7778
7779 * chartab.c (uniprop_table): Make it non-static.
7780
525d5e6e
EZ
77812011-08-01 Eli Zaretskii <eliz@gnu.org>
7782
7783 * xdisp.c (forward_to_next_line_start): Accept additional argument
7784 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7785 on the newline.
7786 (reseat_at_next_visible_line_start): Use the bidi iterator state
7787 returned by forward_to_next_line_start to restore the state of
7788 it->bidi_it after backing up to previous newline. (Bug#9212)
7789
31011111
AS
77902011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7791
7792 * regex.c (re_comp): Protoize.
7793 (re_exec): Fix return type.
7794 (regexec): Fix type of `ret'. (Bug#9203)
7795
476371c4
PE
77962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7797
e5d76069
PE
7798 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7799 This is needed if max-image-size is a floating-point number.
7800
9a79b20c
AS
78012011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7802
7803 * print.c (print_object): Print empty symbol as ##.
7804
7805 * lread.c (read1): Read ## as empty symbol.
7806
d8c2fa78
AA
78072011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7808
7809 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7810 setting frame foreground color (Bug#9175).
7811 (x_set_background_color): Likewise.
7812
ffe57a7a
AA
7813 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7814 contents (Bug#9176).
7815 (EmacsTooltip -init): Remove bezels and add shadows to
7816 tooltip windows.
7817
bf3492a5
AA
7818 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7819 or scroll bar (Bug#8470).
7820
d55e9c53
AA
7821 * nsfont.m (nsfont_open): Remove assignment to voffset and
7822 unnecessary vars hshink, expand, hd, full_height, min_height.
7823 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7824
7825 * nsterm.h (nsfont_info): Remove voffset field.
7826
d8c2fa78 78272011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7828
7829 Implement strike-through and overline on NextStep (Bug#8863).
7830
7831 * nsfont.m (nsfont_open): Use underline position provided by font,
7832 instead of hard-coded value of 2.
7833 (nsfont_draw): Call ns_draw_text_decoration instead.
7834
7835 * nsterm.h: Add declaration for ns_draw_text_decoration.
7836
7837 * nsterm.m (ns_draw_text_decoration): New function for drawing
7838 underline, overline, and strike-through.
7839 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7840 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7841 accommodate underlining, etc.
4843aac3 7842
4cc60b9b
EZ
78432011-07-28 Eli Zaretskii <eliz@gnu.org>
7844
bc7ece87
EZ
7845 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7846 default.
4cc60b9b 7847
476371c4
PE
78482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7849
66606eea
PE
7850 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7851 Without this fix, if a signal arrives just after memory fills up,
7852 'malloc' might be invoked reentrantly.
7853
476371c4
PE
7854 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7855 In other words, assume that every image size is allowed, on non-X
7856 hosts. This assumption is probably wrong, but it lets Emacs compile.
7857
f3fcc40d
AS
78582011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7859
7860 * regex.c (re_iswctype): Convert return values to boolean.
7861
350c992f
EZ
78622011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7863
7864 * xdisp.c (compute_display_string_pos): Don't use cached display
7865 string position if the buffer had its restriction changed.
7866 (Bug#9184)
7867
5266b4bb
PE
78682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7869
7870 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7871
2573a837 78722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7873
41f55ccd 7874 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7875
39e378da
PE
7876 * bidi.c: Integer size and overflow fixes.
7877 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7878 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7879 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7880 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7881 (bidi_find_other_level_edge):
7882 Use ptrdiff_t instead of EMACS_INT where either will do.
7883 This works better on 32-bit hosts configured --with-wide-int.
7884 (bidi_cache_ensure_space): Check for size-calculation overflow.
7885 Use % rather than repeated addition, for better worst-case speed.
7886 Don't set bidi_cache_size until after xrealloc returns, because it
7887 might not return.
7888 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7889 (bidi_cache_ensure_space): Also check that the bidi cache size
7890 does not exceed that of the largest Lisp string or buffer. See Eli
7891 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7892
5e927815
PE
7893 * alloc.c (__malloc_size_t): Remove.
7894 All uses replaced by size_t. See Andreas Schwab's note
7895 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7896
ca4aa935
PE
7897 * image.c: Improve checking for integer overflow.
7898 (check_image_size): Assume that f is nonnull, since
7899 it is always nonnull in practice. This is one less thing to
7900 worry about when checking for integer overflow later.
7901 (x_check_image_size): New function, which checks for integer
7902 overflow issues inside X.
7903 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7904 This removes the need for a memory_full check.
7905 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7906 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7907 (xbm_read_bitmap_data): Change locals back to 'int', since
7908 their values must fit in 'int'.
7909 (xpm_load_image, png_load, tiff_load):
7910 Invoke x_create_x_image_and_pixmap earlier,
7911 to avoid much needless work if the image is too large.
7912 (tiff_load): Treat overly large images as if
7913 x_create_x_image_and_pixmap failed, not as malloc failures.
7914 (gs_load): Use x_check_image_size.
7915
5f8f9cc2
PE
7916 * gtkutil.c: Omit integer casts.
7917 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7918 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7919
5adf60bc
PE
7920 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7921
c8907a93
PE
7922 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7923 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7924 would wrongly return t on a 64-bit host.
7925
e3c25c68
PE
7926 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7927 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7928 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7929 and therefore cause GCC to emit a bogus diagnostic in some cases.
7930
3f791afe
PE
7931 * image.c: Integer signedness and overflow and related fixes.
7932 This is not an exhaustive set of fixes, but it's time to
7933 record what I've got.
7934 (lookup_pixel_color, check_image_size): Remove redundant decls.
7935 (check_image_size): Don't assume that arbitrary EMACS_INT values
7936 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7937 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7938 (tiff_load, imagemagick_load_image):
7939 Check for overflow in size calculations.
7940 (x_create_x_image_and_pixmap): Remove unnecessary test for
7941 xmalloc returning NULL; that can't happen.
7942 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7943 (xpm_color_bucket): Use better integer hashing function.
7944 (xpm_cache_color): Don't possibly over-allocate memory.
7945 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7946 (gif_memory_source):
7947 Use ptrdiff_t, not int or size_t, to record sizes.
7948 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7949 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7950 either works, as we prefer signed integers.
7951 (tiff_read_from_memory, tiff_write_from_memory):
7952 Return tsize_t, not size_t, since that's what the TIFF API wants.
7953 (tiff_read_from_memory): Don't fail simply because the read would
7954 go past EOF; instead, return a short read.
7955 (tiff_load): Omit no-longer-needed casts.
7956 (Fimagemagick_types): Don't assume size fits into 'int'.
7957
3cc5a532
PE
7958 Improve hashing quality when configured --with-wide-int.
7959 * fns.c (hash_string): New function, taken from sxhash_string.
7960 Do not discard information about ASCII character case; this
7961 discarding is no longer needed.
7962 (sxhash-string): Use it. Change sig to match it. Caller changed.
7963 * lisp.h: Declare it.
7964 * lread.c (hash_string): Remove, since we now use fns.c's version.
7965 The fns.c version returns a wider integer if --with-wide-int is
7966 specified, so this should help the quality of the hashing a bit.
7967
b312a492
PE
7968 * emacs.c: Integer overflow minor fix.
7969 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7970 Define only if GNU_LINUX.
7971 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7972
dfd153ae
PE
7973 * dispnew.c: Integer signedness and overflow fixes.
7974 Remove unnecessary forward decls, that were a maintenance hassle.
7975 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7976 All uses changed.
7977 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7978 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7979 (prepare_desired_row, line_draw_cost):
7980 Use int, not unsigned, where either works.
7981 (save_current_matrix, restore_current_matrix):
7982 Use ptrdiff_t, not size_t, where either works.
7983 (init_display): Check for overflow more accurately, and without
7984 relying on undefined behavior.
7985
a81d11a3
PE
7986 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7987 Remove, replacing with the new symbols in lisp.h. All uses changed.
7988 * fileio.c (make_temp_name):
7989 * filelock.c (lock_file_1, lock_file):
7990 * xdisp.c (message_dolog):
7991 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7992 Use pMd etc. instead.
7993 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7994 replacing the pWIDE etc. symbols removed from editfns.c.
7995
3300e6fd
PE
7996 * keyboard.h (num_input_events): Now uintmax_t.
7997 This is (very slightly) less likely to mess up due to wraparound.
7998 All uses changed.
7999
fd05c7e9
PE
8000 * buffer.c: Integer signedness fixes.
8001 (alloc_buffer_text, enlarge_buffer_text):
8002 Use ptrdiff_t rather than size_t when either will do, as we prefer
8003 signed integers.
8004
903fe15d
PE
8005 * alloc.c: Integer signedness and overflow fixes.
8006 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8007 (__malloc_size_t): Default to size_t, not to int.
8008 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8009 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8010 Prefer ptrdiff_t to size_t when either would do, as we prefer
8011 signed integers.
8012 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8013 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8014 Now const. Initialize with values that are in range even if char
8015 is signed.
8016 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8017 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8018 These functions do the right thing with sizes > 2**32.
8019 (check_depth): Now ptrdiff_t, not int.
8020 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8021 Adjust to new way of storing sizes. Check for size overflow bugs
8022 in rest of code.
8023 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8024 slightly wrong anyway, as it missed one instance of
8025 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8026 (refill_memory_reserve): Omit needless cast to size_t.
8027 (mark_object_loop_halt): Mark as externally visible.
8028
ac82cc6a
PE
8029 * xselect.c: Integer signedness and overflow fixes.
8030 (Fx_register_dnd_atom, x_handle_dnd_message):
8031 Use ptrdiff_t, not size_t, since we prefer signed.
8032 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8033 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8034 x_dnd_atoms_size and x_dnd_atoms_length.
8035
c2d1e36d
PE
8036 * doprnt.c: Prefer signed to unsigned when either works.
8037 * eval.c (verror):
8038 * doprnt.c (doprnt):
8039 * lisp.h (doprnt):
8040 * xdisp.c (vmessage):
8041 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8042 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8043 prefer signed arithmetic to avoid comparison confusion.
8044 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8045 but is a bit tricky.
8046
0e926e56
PE
8047 Assume freestanding C89 headers, string.h, stdlib.h.
8048 * data.c, doprnt.c, floatfns.c, print.c:
8049 Include float.h unconditionally.
8050 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8051 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8052 * regex.c: Likewise for stddef.h, string.h.
8053 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8054 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8055 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8056 (STDC_HEADERS): Remove obsolete defines.
8057 * sysdep.c: Include limits.h unconditionally.
8058
9cfdb3ec
PE
8059 Assume support for memcmp, memcpy, memmove, memset.
8060 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8061 * regex.c (memcmp, memcpy):
8062 Remove; we assume C89 now.
8063
8064 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8065 (__malloc_safe_bcopy): Remove; no longer needed.
8066
cf950e6b 8067 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8068 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8069 well either way, and we prefer signed to unsigned.
8070
dbf38e02
LMI
80712011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8072
8073 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8074 closes the connection while we're reading (bug#9182).
8075
d6f0886c 80762011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8077
d6f0886c
JD
8078 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8079 are specified (Bug#9168).
24e0f6b1 8080
2eb1f9e6
PE
80812011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8082
8083 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8084 Found by GCC static checking and --with-wide-int on a 32-bit host.
8085
22381272 80862011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8087
8088 * xdisp.c (compute_display_string_pos): Fix logic of caching
8089 previous display string position. Initialize cached_prev_pos to
8090 -1. Fixes slow-down at the beginning of a buffer.
8091
f25e39b4
EZ
80922011-07-24 Eli Zaretskii <eliz@gnu.org>
8093
8094 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8095 for attrs[LFACE_FONTSET_INDEX].
8096
04c4b52e
PE
80972011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8098
8099 * xml.c (parse_region): Remove unused local
8100 that was recently introduced.
8101
c1734fbd
EZ
81022011-07-23 Eli Zaretskii <eliz@gnu.org>
8103
be18c5a5
EZ
8104 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8105 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8106
c1734fbd
EZ
8107 * xdisp.c (move_it_in_display_line_to): Record the best matching
8108 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8109 exit if none of the characters scanned was an exact match.
8110 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8111 when exact match is impossible due to invisible text, and the
8112 lines are truncated.
8113
a258d627
JD
81142011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8115
8116 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8117 for OSX >= 10.7.
8118
b6d5a689
EZ
81192011-07-22 Eli Zaretskii <eliz@gnu.org>
8120
0f74f785
EZ
8121 Fix a significant slow-down of cursor motion with C-n, C-p,
8122 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8123 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8124 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8125 (next_element_from_buffer): Call compute_stop_pos_backwards to
8126 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8127 base_level_stop.
8128 (reseat): Don't look for prev_stop, as that could mean a very long
8129 run.
8130 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8131 <cached_disp_overlay_modiff>: Cache for last found display string
8132 position.
551918c1 8133 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8134 about the same buffer in the same area of character positions, and
8135 the buffer wasn't changed since the time the display string
8136 position was cached.
551918c1 8137
b2d0c91a
EZ
81382011-07-22 Eli Zaretskii <eliz@gnu.org>
8139
8140 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8141 is an integer, which is important for empty lines. (Bug#9149)
8142
043604ee
CY
81432011-07-22 Chong Yidong <cyd@stupidchicken.com>
8144
8145 * frame.c (Fmodify_frame_parameters): In tty case, update the
8146 default face if necessary (Bug#4238).
8147
da4adb04
CY
81482011-07-21 Chong Yidong <cyd@stupidchicken.com>
8149
8150 * editfns.c (Fstring_to_char): No need to explain what a character
8151 is in the docstring (Bug#6576).
8152
9abd0532
LMI
81532011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8154
8155 * xml.c (parse_region): Make sure we always return a tree.
8156
36881d16
HK
81572011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8158
8159 * xml.c (parse_region): If a document contains only comments,
8160 return that, too.
8161
1e98674d
LMI
81622011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8163
8164 * xml.c (make_dom): Return comments, too.
8165
590bd467
PE
81662011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8167
8168 Port to OpenBSD.
8169 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8170 and the surrounding thread.
8171 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8172 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8173 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8174 timer goes off.
8175 * s/openbsd.h (BROKEN_SIGIO): Define.
8176 * unexelf.c (unexec) [__OpenBSD__]:
8177 Don't update the .mdebug section of the Alpha COFF symbol table.
8178
f41628b2
LMI
81792011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8180
8181 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8182 (bug#8460).
8183
b59b67c5
PE
81842011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8185
15e3a074
PE
8186 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8187 This fixes some race conditions on the permissions of any newly
8188 created file.
8189
41bed37d
PE
8190 * alloc.c (valid_pointer_p): Use pipe, not open.
8191 This fixes some permissions issues when debugging.
8192
b59b67c5
PE
8193 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8194 If fchown fails to set both uid and gid, try to set just gid,
8195 as that is sometimes allowed. Adjust the file's mode to eliminate
8196 setuid or setgid bits that are inappropriate if fchown fails.
8197
925a6be7
SM
81982011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8199
8200 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8201 to compare Lisp_Objects.
8202 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8203 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8204 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8205
52968808
AS
82062011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8207
0a6a104b
AS
8208 * lread.c (read_integer): Unread even EOF character.
8209 (read1): Likewise. Properly record start position of symbol.
8210
52968808
AS
8211 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8212 symbol character follows.
8213
9e381cdd
PE
82142011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8215
8216 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8217 This works around a problem with the previous change to Fcopy_file.
8218 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8219 and without this change, GCC might complain about discarding
8220 fchown's return value.
8221
b5641435
JB
82222011-07-16 Juanma Barranquero <lekktu@gmail.com>
8223
8224 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8225
a8031457
PE
82262011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8227
8228 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8229
dd889327
LMI
82302011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8231
750c33f7
LMI
8232 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8233 it's used from the C level.
8234
dd889327
LMI
8235 * process.c: Use the same condition for POLL_FOR_INPUT in both
8236 keyboard.c and process.c (bug#1858).
8237
87e86684
LM
82382011-07-09 Lawrence Mitchell <wence@gmx.li>
8239
8240 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8241 (Fgnutls_boot): Use it.
8242
64348f40
AS
82432011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8244
8245 * doc.c (Fsubstitute_command_keys): Revert last change.
8246
1d698799
LMI
82472011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8248
f863868c
LMI
8249 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8250 quotes the next character, and doesn't affect other longer
8251 sequences (bug#8935).
8252
1d698799
LMI
8253 * lread.c (syms_of_lread): Clarify that is isn't only
8254 `eval-buffer' and `eval-defun' that's affected by
8255 `lexical-binding' (bug#8460).
8256
aa4b6df6
EZ
82572011-07-15 Eli Zaretskii <eliz@gnu.org>
8258
8259 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8260 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8261
5d856da6
PE
82622011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8263
ad6042bb
PE
8264 Fix minor problems found by static checking.
8265 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8266 (elsz): Now a signed constant, not a size_t var. We prefer signed
8267 types to unsigned, to avoid integer comparison confusion. Without
8268 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8269 "cannot optimize loop, the loop counter may overflow", a symptom
8270 of the confusion.
f00bbb22 8271 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8272 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8273
6468f31c
LMI
82742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8275
49080b10
LMI
8276 * search.c (Fre_search_backward): Mention `case-fold-search' in
8277 all the re_search_* functions (bug#8138).
8278
6468f31c
LMI
8279 * keyboard.c (Fopen_dribble_file): Document when the file is
8280 closed (bug#8056).
8281
c965adc5
EZ
82822011-07-14 Eli Zaretskii <eliz@gnu.org>
8283
df9733bf
EZ
8284 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8285 bidi_cache_idx.
8286
0bb23927
EZ
8287 Support bidi reordering of display and overlay strings.
8288 * xdisp.c (compute_display_string_pos)
8289 (compute_display_string_end): Accept additional argument STRING.
8290 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8291 (reseat_to_string): Initialize bidi_it->string.s and
8292 bidi_it->string.schars.
8293 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8294 NULL (avoids a crash in bidi_paragraph_init).
8295 Initialize itb.string.lstring.
0bb23927
EZ
8296 (init_iterator): Call bidi_init_it only of a valid
8297 buffer position was specified. Initialize paragraph_embedding to
8298 L2R.
8299 (reseat_to_string): Initialize the bidi iterator.
8300 (display_string): If we need to ignore text properties of
8301 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8302 original value of -1 will not work with bidi.)
8303 (compute_display_string_pos): First arg is now struct
8304 `text_pos *'; all callers changed. Support display properties on
8305 Lisp strings.
8306 (compute_display_string_end): Support display properties on Lisp
8307 strings.
8308 (init_iterator, reseat_1, reseat_to_string): Initialize the
8309 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8310 when iterating on a string not from display properties).
640c8776
SM
8311 (compute_display_string_pos, compute_display_string_end):
8312 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8313 arrow keys.
8314 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8315 base_level_stop; instead, set base_level_stop to BEGV.
8316 Fixes crashes in vertical-motion.
0bb23927
EZ
8317 (next_element_from_buffer): Improve commentary for when
8318 the iterator is before prev_stop.
8319 (init_iterator): Initialize bidi_p from the default value of
8320 bidi-display-reordering, not from buffer-local value. Use the
8321 buffer-local value only if initializing for buffer iteration.
8322 (handle_invisible_prop): Support invisible properties on strings
8323 that are being bidi-reordered.
8324 (set_iterator_to_next): Support bidi reordering of C strings and
8325 Lisp strings.
8326 (next_element_from_string): Support bidi reordering of Lisp
8327 strings.
8328 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8329 (display_string): Support display of R2L glyph rows.
8330 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8331 (init_iterator): Don't initialize it->bidi_p for strings
8332 here.
8333 (reseat_to_string): Initialize it->bidi_p for strings here.
8334 (next_element_from_string, next_element_from_c_string)
8335 (next_element_from_buffer): Add xassert's for correspondence
8336 between IT's object being iterated and it->bidi_it.string
8337 structure.
8338 (face_before_or_after_it_pos): Support bidi iteration.
8339 (next_element_from_c_string): Handle the case of the first string
8340 character that is not the first one in the visual order.
8341 (get_visually_first_element): New function, refactored from common
8342 parts of next_element_from_buffer, next_element_from_string, and
8343 next_element_from_c_string.
8344 (tool_bar_lines_needed, redisplay_tool_bar)
8345 (display_menu_bar): Force left-to-right direction. Add a FIXME
8346 comment for making that be controlled by a user option.
8347 (push_it, pop_it): Save and restore the state of the
8348 bidi iterator. Save and restore the bidi_p flag.
8349 (pop_it): Iterate out of display property for string iteration as
8350 well.
8351 (iterate_out_of_display_property): Support iteration over strings.
8352 (handle_single_display_spec): Set up it->bidi_it for iteration
8353 over a display string, and call bidi_init_it.
8354 (handle_single_display_spec, next_overlay_string)
8355 (get_overlay_strings_1, push_display_prop): Set up the bidi
8356 iterator for displaying display or overlay strings.
8357 (forward_to_next_line_start): Don't use the shortcut if
8358 bidi-iterating.
8359 (back_to_previous_visible_line_start): If handle_display_prop
8360 pushed the iterator stack, restore the internal state of the bidi
8361 iterator by calling bidi_pop_it same number of times.
8362 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8363 and we are bidi-iterating, don't decrement the iterator position;
8364 instead, set the first_elt flag in the bidi iterator, to produce
8365 the same effect.
8366 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8367 (push_display_prop): xassert that we are iterating a buffer.
8368 (push_it, pop_it): Save and restore paragraph_embedding member.
8369 (handle_single_display_spec, next_overlay_string)
8370 (get_overlay_strings_1, reseat_1, reseat_to_string)
8371 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8372 correctly. Don't assume unibyte strings are not bidi-reordered.
8373 (compute_display_string_pos)
8374 (compute_display_string_end): Fix handling the case of C string.
8375 (push_it, pop_it): Save and restore from_disp_prop_p.
8376 (handle_single_display_spec, push_display_prop): Set the
8377 from_disp_prop_p flag.
8378 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8379 (pop_it): Call iterate_out_of_display_property only if we are
8380 popping after iteration over a string that came from a display
8381 property. Fix a typo in popping stretch info. Add an assertion
8382 for verifying that the iterator position is in sync with the bidi
8383 iterator.
8384 (handle_single_display_spec, get_overlay_strings_1)
8385 (push_display_prop): Fix initialization of paragraph direction for
8386 string when that of the parent object is not yet determined.
8387 (reseat_1): Call bidi_init_it to resync the bidi
8388 iterator with IT's position. (Bug#7616)
8389 (find_row_edges): If ROW->start.pos gives position
8390 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8391 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8392 Reset the from_disp_prop_p flag.
8393 (SAVE_IT, RESTORE_IT): New macros.
8394 (pos_visible_p, face_before_or_after_it_pos)
8395 (back_to_previous_visible_line_start)
8396 (move_it_in_display_line_to, move_it_in_display_line)
8397 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8398 (try_scrolling, redisplay_window, display_line): Use them when
8399 saving a temporary copy of the iterator and restoring it back.
8400 (back_to_previous_visible_line_start, reseat_1)
8401 (init_iterator): Empty the bidi cache "stack".
8402 (move_it_in_display_line_to): If iterator ended up at
8403 EOL, but we never saw any buffer positions smaller than
8404 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8405 motion in bidi-reordered lines.
8406 (move_it_in_display_line_to): Record prev_method and prev_pos
8407 immediately before the call to set_iterator_to_next. Fixes cursor
8408 motion in bidi-reordered lines with stretch glyphs and strings
8409 displayed in margins. (Bug#8133) (Bug#8867)
8410 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8411 TO_CHARPOS.
640c8776
SM
8412 (pos_visible_p): Support positions in bidi-reordered lines.
8413 Save and restore bidi cache.
0bb23927
EZ
8414
8415 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8416 (bidi_paragraph_info): Delete unused struct.
8417 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8418 (bidi_cache_start): New variable.
8419 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8420 to zero.
8421 (bidi_cache_fetch_state, bidi_cache_search)
8422 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8423 (bidi_cache_find, bidi_peek_at_next_level)
8424 (bidi_level_of_next_char, bidi_find_other_level_edge)
8425 (bidi_move_to_visually_next): Compare cache index with
8426 bidi_cache_start rather than with zero.
8427 (bidi_fetch_char): Accept new argument STRING; all callers
8428 changed. Support iteration over a string. Support strings with
8429 display properties. Support unibyte strings. Fix the type of
8430 `len' according to what STRING_CHAR_AND_LENGTH expects.
8431 (bidi_paragraph_init, bidi_resolve_explicit_1)
8432 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8433 (bidi_level_of_next_char, bidi_move_to_visually_next):
8434 Support iteration over a string.
0bb23927
EZ
8435 (bidi_set_sor_type, bidi_resolve_explicit_1)
8436 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8437 can now be zero (for strings); special values 0 and -1 were
8438 changed to -1 and -2, respectively.
8439 (bidi_char_at_pos): New function.
8440 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8441 Call it instead of FETCH_MULTIBYTE_CHAR.
8442 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8443 initialized to valid values.
8444 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8445 values.
8446 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8447 the test for valid cached positions. Fix the logic for looking up
8448 the sentinel state in the cache. GCPRO the Lisp string we are
8449 iterating.
8450 (bidi_push_it, bidi_pop_it): New functions.
8451 (bidi_initialize): Initialize the bidi cache start stack pointer.
8452 (bidi_cache_ensure_space): New function, refactored from part of
8453 bidi_cache_iterator_state. Don't assume the required size is just
8454 one BIDI_CACHE_CHUNK away.
8455 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8456 (bidi_count_bytes, bidi_char_at_pos): New functions.
8457 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8458 always valid if bidi_cache_idx is valid.
8459 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8460 is valid if it's going to be used.
8461 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8462 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8463 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8464 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8465 (bidi_find_other_level_edge, bidi_cache_start_stack):
8466 All variables related to cache indices are now EMACS_INT.
c965adc5 8467
0bb23927
EZ
8468 * dispextern.h (struct bidi_string_data): New structure.
8469 (struct bidi_it): New member `string'. Make flag members be 1-bit
8470 fields, and put them last in the struct.
640c8776
SM
8471 (compute_display_string_pos, compute_display_string_end):
8472 Update prototypes.
0bb23927
EZ
8473 (bidi_push_it, bidi_pop_it): Add prototypes.
8474 (struct iterator_stack_entry): New members bidi_p,
8475 paragraph_embedding, and from_disp_prop_p.
8476 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8477 (bidi_shelve_cache, bidi_unshelve_cache):
8478 Declare prototypes.
0bb23927
EZ
8479
8480 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8481 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8482 and vector-like objects.
8483
8484 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8485 cache around display iteration.
8486
8487 * window.c (Fwindow_end, window_scroll_pixel_based)
8488 (displayed_window_lines, Frecenter): Save and restore the bidi
8489 cache around display iteration.
8490
3bbd2265
LMI
84912011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8492
8493 * editfns.c (Fdelete_region): Clarify the use of the named
8494 parameters (bug#6788).
8495
adc47434
MR
84962011-07-14 Martin Rudalics <rudalics@gmx.at>
8497
8498 * indent.c (Fvertical_motion): Set and restore w->pointm when
8499 saving and restoring the window's buffer (Bug#9006).
8500
837c31f8
LMI
85012011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8502
8503 * editfns.c (Fstring_to_char): Clarify just what is returned
8504 (bug#6576). Text by Eli Zaretskii.
8505
ac389d0c
JB
85062011-07-13 Juanma Barranquero <lekktu@gmail.com>
8507
8508 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8509
0be0ce47
EZ
85102011-07-13 Eli Zaretskii <eliz@gnu.org>
8511
8512 * buffer.c (mmap_find): Fix a typo.
8513
cd18e7e3
JB
85142011-07-13 Johan Bockgård <bojohan@gnu.org>
8515
8516 Fix execution of x selection hooks.
8517 * xselect.c (Qx_lost_selection_functions)
8518 (Qx_sent_selection_functions): New vars.
8519 (syms_of_xselect): DEFSYM them.
8520 (x_handle_selection_request): Pass Qx_sent_selection_functions
8521 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8522 (x_handle_selection_clear,x_clear_frame_selections):
8523 Pass Qx_lost_selection_functions rather than
8524 Vx_lost_selection_functions to Frun_hook_with_args.
8525
47ea7f44
PE
85262011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8527
ac389d0c 8528 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8529 The old code sometimes used this field without initializing it.
8530
47ea7f44
PE
8531 * alloc.c (gc_sweep): Don't read past end of array.
8532 In theory, the old code could also have corrupted Emacs internals,
8533 though it'd be very unlikely.
8534
bc985c87
AS
85352011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8536
8537 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8538 argument. (Bug#4026)
bc985c87 8539
0cf34688
LMI
85402011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8541
b3dadd76
LMI
8542 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8543 key" (bug#4257).
8544
0cf34688
LMI
8545 * window.c (Fset_window_start): Doc fix (bug#4199).
8546 (Fset_window_hscroll): Ditto.
8547
270768cd
PE
85482011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8549
077e3dda 8550 Fix minor new problems caught by GCC 4.6.1.
270768cd 8551 * term.c (init_tty): Remove unused local.
490011a6 8552 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8553 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8554 not used otherwise.
270768cd 8555
b1f58454
CY
85562011-07-12 Chong Yidong <cyd@stupidchicken.com>
8557
8558 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8559
22b9578d
LMI
85602011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8561
6e70ab07
LMI
8562 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8563 are the mini-buffer and the echo area (bug#3320).
8564
22b9578d
LMI
8565 * term.c (init_tty): Remove support for supdup, c10 and perq
8566 terminals, which are no longer supported (bug#1482).
8567
8974cc9f
JB
85682011-07-10 Johan Bockgård <bojohan@gnu.org>
8569
8570 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8571
a560d974
JD
85722011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8573
8574 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8575 for non-popups (Bug#3642).
8576
1dae0f0a
AS
85772011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8578
268c2c36 8579 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8580 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8581 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8582 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8583 * data.c (fmod): Likewise.
8584 * dispnew.c (swap_glyphs_in_rows): Likewise.
8585 * emacs.c (memory_warning_signal): Likewise.
8586 * floatfns.c (float_error): Likewise.
8587 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8588 (otf_open, font_otf_capability, generate_otf_features)
8589 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8590 Likewise.
8591 * image.c (pbm_read_file): Likewise.
8592 * indent.c (string_display_width): Likewise.
8593 * intervals.c (check_for_interval, search_for_interval)
8594 (inc_interval_count, count_intervals, root_interval)
8595 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8596 * lread.c (defalias): Likewise.
268c2c36 8597 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8598 * regex.c (set_image_of_range_1, set_image_of_range)
8599 (regex_grow_registers): Likewise.
8600 * sysdep.c (strerror): Likewise.
8601 * termcap.c (valid_filename_p, tprint, main): Likewise.
8602 * tparam.c (main): Likewise.
8603 * unexhp9k800.c (run_time_remap, save_data_space)
8604 (update_file_ptrs, read_header, write_header, calculate_checksum)
8605 (copy_file, copy_rest, display_header): Likewise.
8606 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8607 Likewise.
8608 * xdisp.c (check_it): Likewise.
8609 * xfaces.c (register_color, unregister_color, unregister_colors):
8610 Likewise.
8611 * xfns.c (print_fontset_result): Likewise.
8612 * xrdb.c (member, fatal, main): Likewise.
8613
99033785
PE
86142011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8615
8616 Fix minor problems found by static checking (Bug#9031).
8617 * chartab.c (char_table_set_range, map_sub_char_table):
8618 Remove unused locals.
8619 (uniprop_table): Now static.
8620 * composite.c (_work_char): Remove unused static var.
8621
9cb2ac56
JB
86222011-07-09 Juanma Barranquero <lekktu@gmail.com>
8623
8624 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8625
f25661f0
JD
86262011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8627
8628 * gtkutil.c (qttip_cb): Remove code without function.
8629
8278c4fe
EZ
86302011-07-09 Eli Zaretskii <eliz@gnu.org>
8631
8632 * w32.c (pthread_sigmask): New stub.
8633
1692ae2d 86342011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8635
8a6ebd58 8636 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8637 sigprocmask is portable only for single-threaded applications, and
8638 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8639 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8640 (LIBES): Use it.
8641 * callproc.c (Fcall_process):
8642 * process.c (create_process):
8643 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8644 Use pthread_sigmask, not sigprocmask.
123403e4 8645
1b854618
JD
86462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8647
8648 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8649 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8650 wrong (Bug#8591).
8651
3fe4b549
JD
86522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8653
0ce7e563
JD
8654 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8655 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8656 (xg_hide_tooltip): Fix comment.
8657
3fe4b549
JD
8658 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8659 in registerServicesMenuSendTypes.
8660 (validRequestorForSendType): Don't check ns_return_types.
8661
8662 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8663 ns_return_type.
8664
5df75e47
JR
86652011-07-08 Jason Rumney <jasonr@gnu.org>
8666
22610910
JR
8667 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8668 SH_SHOW for hidden windows (Bug#5482).
8669
5df75e47
JR
8670 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8671 frame struct members of non-existent frames (Bug#6284).
8672
699c10bd
JD
86732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8674
4393663b
JD
8675 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8676 variable firstTime not needed on OSX >= 10.6.
8677 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8678 >= 10.5. Use setKnobProportion, setDoubleValue.
8679
8680 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8681 (MAC_OS_X_VERSION_10_5): Define if not defined.
8682 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8683 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8684 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8685
8686 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8687 cString and lossyCString on OSX >= 10.4.
4393663b 8688
58179cce 8689 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8690 sizeToFit on OSX >= 10.2.
8691
8692 * nsimage.m (allocInitFromFile): Don't use deprecated method
8693 bestRepresentationForDevice on OSX >= 10.6.
8694
8695 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8696 to avoid warning.
8697
8698 * emacs.c: Declare unexec_init_emacs_zone.
8699
a63e0781
JD
8700 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8701
699c10bd
JD
8702 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8703
8704 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8705 on svcsMenu (Bug#8842).
8706
8707 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8708 ns_return_types.
8709 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8710
8711 * nsterm.m (QUTF8_STRING): Declare.
8712 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8713 (validRequestorForSendType): Return type is (id).
8714 Change indexOfObjectIdenticalTo to indexOfObject.
8715 Check if we have local selection before returning self (Bug#8842).
8716 (writeSelectionToPasteboard): Put local selection into paste board
8717 if we have a local selection (Bug#8842).
8718 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8719
8720 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8721 (ns_get_local_selection): Declare.
8722
54e10184
LMI
87232011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8724
9888ff71
LMI
8725 * keymap.c (describe_map_tree): Don't insert a double newline at
8726 the end of the buffer (bug#1169) and return whether we inserted
8727 something.
8728
54e10184
LMI
8729 * callint.c (Fcall_interactively): Change "reading args" to
8730 "providing args" to try to clarify what it does (bug#1010).
8731
15fa4783
KH
87322011-07-07 Kenichi Handa <handa@m17n.org>
8733
8734 * composite.c (composition_compute_stop_pos): Ignore a static
8735 composition starting before CHARPOS (Bug#8915).
8736
8737 * xdisp.c (handle_composition_prop): Likewise.
8738
a8815b00
EZ
87392011-07-07 Eli Zaretskii <eliz@gnu.org>
8740
8741 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8742 (Bug#9015)
8743
ef7b981d 87442011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8745
8746 * character.h (unicode_category_t): New enum type.
8747
8748 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8749 (Qchar_code_property_table): New variable.
8750 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8751 (UNIPROP_COMPRESSED_FORM_P): New macros.
8752 (char_table_ascii): Uncompress the compressed values.
8753 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8754 Uncompress the compressed values.
ac389d0c 8755 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8756 (char_table_ref_and_range): Uncompress the compressed values.
8757 (sub_char_table_set): New arg is_uniprop. Callers changed.
8758 Uncompress the compressed values.
8759 (sub_char_table_set_range): Args changed. Callers changed.
8760 (char_table_set_range): Adjuted for the above change.
8761 (map_sub_char_table): Delete args default_val and parent. Add arg
8762 top. Give decoded values to a Lisp function.
640c8776 8763 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8764 values to a Lisp function. Gcpro more variables.
8765 (uniprop_table_uncompress)
8766 (uniprop_decode_value_run_length): New functions.
8767 (uniprop_decoder, uniprop_decoder_count): New variables.
8768 (uniprop_get_decoder, uniprop_encode_value_character)
8769 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8770 New functions.
8771 (uniprop_encoder, uniprop_encoder_count): New variables.
8772 (uniprop_get_encoder, uniprop_table)
8773 (Funicode_property_table_internal, Fget_unicode_property_internal)
8774 (Fput_unicode_property_internal): New functions.
8775 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8776 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8777 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8778 char-code-property-alist.
8779
640c8776 8780 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8781 Vunicode_category_table.
8782
640c8776 8783 * font.c (font_range): Adjust for the change of
c805dec0
KH
8784 Vunicode_category_table.
8785
76b397fb
DN
87862011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8787
8788 * m/iris4d.h: Remove file, move contents ...
8789 * s/irix6-5.h: ... here.
8790
22b4128e
PE
87912011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8792
8793 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8794 * alloc.c (mark_buffer):
8795 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8796 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8797 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8798 This isn't true in general, and it's particularly not true
8799 if Emacs is configured with --with-wide-int.
8800 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8801 New macros, used in the buffer.c change.
8802
869795d6
JD
88032011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8804
8805 * xsettings.c: Use both GConf and GSettings if both are available.
8806 (store_config_changed_event): Add comment.
8807 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8808 (store_tool_bar_style_changed): New functions.
5e617bc2 8809 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8810 (struct xsettings): Move font inside HAVE_XFT.
8811 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8812 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8813 Move inside HAVE_XFT.
640c8776 8814 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8815 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8816 also.
8817 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8818 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8819 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8820 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8821 (parse_settings): Move check for font inside HAVE_XFT.
8822 (read_settings, apply_xft_settings): Add comment.
8823 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8824 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8825 call store_font_name_changed.
8826 (xft_settings_event): Add comment.
8827 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8828 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8829 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8830 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8831 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8832 (xsettings_get_system_font, xsettings_get_system_normal_font):
8833 Add comment.
869795d6 8834
d8ed26bd
PE
88352011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8836
8837 Random fixes. E.g., (random) never returned negative values.
8838 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8839 subseconds part to the entropy, as that's a bit more random.
8840 Prefer signed to unsigned, since the signedness doesn't matter and
8841 in general we prefer signed. When given a limit, use a
8842 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8843 latter isn't right if USE_2_TAGS_FOR_INTS.
8844 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8845 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8846
cabf1cac
SM
88472011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8848
8849 * textprop.c (text_property_stickiness):
8850 Obey Vtext_property_default_nonsticky.
8851 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8852 * w32fns.c (syms_of_w32fns):
8853 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8854
6e9b2be9
PE
88552011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8856
8857 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8858 This is more efficient than Ffile_directory_p and avoids a minor race.
8859
90186c68
LMI
88602011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8861
7c301272
LMI
8862 * buffer.c (Foverlay_put): Say what the return value is
8863 (bug#7835).
8864
c4f2d8d4
LMI
8865 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8866 is a directory before asking whether to use the file name
8867 (bug#7564).
ad637907
LMI
8868 (barf_or_query_if_file_exists): Make the "File is a directory"
8869 error be more correct.
c4f2d8d4 8870
90186c68
LMI
8871 * fns.c (Frequire): Remove the mention of the .gz files, since
8872 that's installation-specific, but keep the mention of
8873 `get-load-suffixes'.
8874
da64016e
PE
88752011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8876
8877 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8878 Report string overflow if the output is too long.
8879
7d47b580
JB
88802011-07-04 Juanma Barranquero <lekktu@gmail.com>
8881
a555cb87
JB
8882 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8883 (syms_of_gnutls): Remove duplicate DEFSYM for
8884 Qgnutls_bootprop_verify_hostname_error, an error for
8885 Qgnutls_bootprop_verify_error (which is no longer used).
8886
7d47b580
JB
8887 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8888 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8889 Also (re)move comments that are misplaced or no longer relevant.
8890
1e49bfab
LMI
88912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8892
8893 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8894
1485f4c0
CY
88952011-07-03 Chong Yidong <cyd@stupidchicken.com>
8896
8897 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8898 and background color parameters if they have been changed.
8899
a9ab721e
LMI
89002011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8901
8902 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8903
cf7cff57
PE
89042011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8905
2e13213d
PE
8906 * xsettings.c (SYSTEM_FONT): Define only when used.
8907 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8908
cf7cff57
PE
8909 * keymap.c (access_keymap_1): Now static.
8910
7a8e04f7
CY
89112011-07-02 Chong Yidong <cyd@stupidchicken.com>
8912
8913 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8914 leave any prefix arg for the up event (Bug#1586).
8915
61352f62
LMI
89162011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8917
69bb1ef7
LMI
8918 * lread.c (syms_of_lread): Mention single symbols defined by
8919 `defvar' or `defconst' (bug#7154).
8920
61352f62 8921 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8922 (Frequire): Mention get-load-suffixes.
61352f62 8923
28545e04
MR
89242011-07-02 Martin Rudalics <rudalics@gmx.at>
8925
8926 * window.h (window): Remove clone_number slot.
8927 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8928 Remove.
8929 (make_parent_window, make_window, saved_window)
8930 (Fset_window_configuration, save_window_save): Don't deal with
8931 clone numbers.
8932 * buffer.c (Qclone_number): Remove declaration.
8933 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8934
3349e122
SM
89352011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8936
8937 Add multiple inheritance to keymaps.
8938 * keymap.c (Fmake_composed_keymap): New function.
8939 (Fset_keymap_parent): Simplify.
8940 (fix_submap_inheritance): Remove.
8941 (access_keymap_1): New function extracted from access_keymap to handle
8942 embedded parents and handle lists of maps.
8943 (access_keymap): Use it.
8944 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8945 (Fcopy_keymap): Handle embedded parents.
8946 (Fcommand_remapping, define_as_prefix): Simplify.
8947 (Fkey_binding): Simplify.
8948 (syms_of_keymap): Move minibuffer-local-completion-map,
8949 minibuffer-local-filename-completion-map,
8950 minibuffer-local-must-match-map, and
8951 minibuffer-local-filename-must-match-map to Elisp.
8952 (syms_of_keymap): Defsubr make-composed-keymap.
8953 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8954 (parse_menu_item): Trivial simplification.
8955
3279eb87
GM
89562011-07-01 Glenn Morris <rgm@gnu.org>
8957
8958 * Makefile.in (SETTINGS_LIBS): Fix typo.
8959
4550efdf
KI
89602011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8961
8962 * coding.c (Fencode_coding_string): Record the last coding system
8963 used, as the function doc string says (bug#8738).
8964
0949d2b6
JD
89652011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8966
8967 * xsettings.c (store_monospaced_changed): Take new font as arg and
8968 check for change against current_mono_font.
8969 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8970 (emacs_settings_constructor, emacs_settings_get_property)
8971 (emacs_settings_set_property, emacs_settings_class_init)
8972 (emacs_settings_init, gsettings_obj): Remove.
8973 (something_changedCB): New function for HAVE_GSETTINGS.
8974 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8975 with value as argument.
8976 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8977 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8978 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8979 "changed".
8980
8981 * xgselect.c: Add defined (HAVE_GSETTINGS).
8982 (xgselect_initialize): Ditto.
8983
8984 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8985 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8986 xg_select.
8987
bbc6b304
PE
89882011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8989
8990 * eval.c (struct backtrace): Simplify and port the data structure.
8991 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8992 signed bit field, as this assumption is not portable and it makes
8993 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8994 "char debug_on_exit : 1" as this is not portable either; instead,
8995 use the portable "unsigned int debug_on_exit : 1". Remove unused
8996 member evalargs. Remove obsolete comments about cc bombing out.
8997
9851bfc5
JD
89982011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8999
51bb811f 9000 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9001 Let HAVE_GSETTINGS override HAVE_GCONF.
9002 (store_monospaced_changed): New function.
9003 (EMACS_SETTINGS): A new type derived from GObject to handle
9004 GSettings notifications.
9005 (emacs_settings_constructor, emacs_settings_get_property)
9006 (emacs_settings_set_property, emacs_settings_class_init):
9007 New functions.
9008 (gsettings_client, gsettings_obj): New variables.
9009 (GSETTINGS_SCHEMA): New define.
9010 (something_changedCB): Call store_monospaced_changed.
9011 (init_gsettings): New function.
9012 (xsettings_initialize): Call init_gsettings.
9013 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9014 to NULL.
9015
640c8776 9016 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9017 GCONF_CFLAGS/LIBS.
9018
5386012d
MR
90192011-06-29 Martin Rudalics <rudalics@gmx.at>
9020
9021 * window.c (resize_root_window, grow_mini_window)
9022 (shrink_mini_window): Rename Qresize_root_window to
9023 Qwindow_resize_root_window and Qresize_root_window_vertically to
9024 Qwindow_resize_root_window_vertically.
9025
f13e0b08
PE
90262011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9027
9028 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9029
94515237
JB
90302011-06-27 Juanma Barranquero <lekktu@gmail.com>
9031
9032 * makefile.w32-in: Redesign dependencies so they reflect more
9033 clearly which files are directly included by each source file,
9034 and not through other includes.
9035
e43b6e43
MR
90362011-06-27 Martin Rudalics <rudalics@gmx.at>
9037
9038 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9039 (sort_overlays, overlay_strings): When an overlay's clone number
9040 matches the window's clone number process the overlay even if
9041 the overlay's window property doesn't match the current window.
9042
d68443dc
MR
9043 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9044 (Fwindow_hchild): Rename to Fwindow_left_child.
9045 (Fwindow_next): Rename to Fwindow_next_sibling.
9046 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9047 (resize_window_check): Rename to window_resize_check.
9048 (resize_window_apply): Rename to window_resize_apply.
9049 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9050 (Fdelete_other_windows_internal, resize_frame_windows)
9051 (Fsplit_window_internal, Fdelete_window_internal)
9052 (grow_mini_window, shrink_mini_window)
9053 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9054
c7e73be5
JD
90552011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9056
9057 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9058 (emacs_fixed_set_min_size): Remove.
9059 (emacs_fixed_new): Take frame as argument.
9060
9061 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9062 (_EmacsFixedPrivate): Remove minwidth/height.
9063 Add struct frame *f.
9064 (emacs_fixed_init): Initialize priv->f.
9065 (get_parent_class, emacs_fixed_set_min_size): Remove.
9066 (emacs_fixed_new): Set priv->f to argument.
9067 (emacs_fixed_get_preferred_width)
9068 (emacs_fixed_get_preferred_height): Use min_width/height from
9069 frames size_hint to set minimum and natural (Bug#8919).
9070 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9071 and use min_width/height from frames size_hint to set
9072 min_width/height (Bug#8919).
9073
9074 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9075 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9076 Fix indentation.
c7e73be5 9077
cf99dcf8
EZ
90782011-06-26 Eli Zaretskii <eliz@gnu.org>
9079
9080 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9081 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9082 called at ZV.
9083
029529ac
CY
90842011-06-26 Chong Yidong <cyd@stupidchicken.com>
9085
9086 * process.c (wait_reading_process_output): Bypass select if
9087 waiting for a cell while ignoring keyboard input, and input is
9088 pending. Suggested by Jan Djärv (Bug#8869).
9089
7a7ef429
PE
90902011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9091
9092 Use gnulib's dup2 module instead of rolling our own.
9093 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9094
11fdef7d 90952011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9096
9097 * dispnew.c (scrolling_window): Before scrolling, turn off a
9098 mouse-highlight in the window being scrolled.
9099
cd3520a4
JB
91002011-06-24 Juanma Barranquero <lekktu@gmail.com>
9101
9102 Move DEFSYM to lisp.h and use everywhere.
9103
9104 * character.h (DEFSYM): Move declaration...
9105 * lisp.h (DEFSYM): ...here.
9106
9107 * gnutls.c:
9108 * minibuf.c:
9109 * w32menu.c:
9110 * w32proc.c:
9111 * w32select.c: Don't include character.h.
9112
9113 * alloc.c (syms_of_alloc):
9114 * buffer.c (syms_of_buffer):
9115 * bytecode.c (syms_of_bytecode):
9116 * callint.c (syms_of_callint):
9117 * casefiddle.c (syms_of_casefiddle):
9118 * casetab.c (init_casetab_once):
9119 * category.c (init_category_once, syms_of_category):
9120 * ccl.c (syms_of_ccl):
9121 * cmds.c (syms_of_cmds):
9122 * composite.c (syms_of_composite):
9123 * dbusbind.c (syms_of_dbusbind):
9124 * dired.c (syms_of_dired):
9125 * dispnew.c (syms_of_display):
9126 * doc.c (syms_of_doc):
9127 * editfns.c (syms_of_editfns):
9128 * emacs.c (syms_of_emacs):
9129 * eval.c (syms_of_eval):
9130 * fileio.c (syms_of_fileio):
9131 * fns.c (syms_of_fns):
9132 * frame.c (syms_of_frame):
9133 * fringe.c (syms_of_fringe):
9134 * insdel.c (syms_of_insdel):
9135 * keymap.c (syms_of_keymap):
9136 * lread.c (init_obarray, syms_of_lread):
9137 * macros.c (syms_of_macros):
9138 * msdos.c (syms_of_msdos):
9139 * print.c (syms_of_print):
9140 * process.c (syms_of_process):
9141 * search.c (syms_of_search):
9142 * sound.c (syms_of_sound):
9143 * syntax.c (init_syntax_once, syms_of_syntax):
9144 * terminal.c (syms_of_terminal):
9145 * textprop.c (syms_of_textprop):
9146 * undo.c (syms_of_undo):
9147 * w32.c (globals_of_w32):
9148 * window.c (syms_of_window):
9149 * xdisp.c (syms_of_xdisp):
9150 * xfaces.c (syms_of_xfaces):
9151 * xfns.c (syms_of_xfns):
9152 * xmenu.c (syms_of_xmenu):
9153 * xsettings.c (syms_of_xsettings):
9154 * xterm.c (syms_of_xterm): Use DEFSYM.
9155
4228cf16
TZ
91562011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9157
cd3520a4 9158 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9159
7fcccf1e
PE
91602011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9161
7efb4e0e
PE
9162 Integer and buffer overflow fixes (Bug#8873).
9163
ff5844ad
PE
9164 * print.c (printchar, strout): Check for string overflow.
9165 (PRINTPREPARE, printchar, strout):
9166 Don't set size unless allocation succeeds.
9167
90532f02
PE
9168 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9169 for sizes. Check for string overflow more accurately.
9170 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9171
6d84508d
PE
9172 * macros.c: Integer and buffer overflow fixes.
9173 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9174 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9175 Use ptrdiff_t, not int, for sizes.
9176 Don't increment bufsize until after realloc succeeds.
9177 Check for size-calculation overflow.
9178 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9179
437b2cb4
PE
9180 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9181
8b9ac8b4
PE
9182 * lread.c: Integer overflow fixes.
9183 (read_integer): Radix is now EMACS_INT, not int,
9184 to improve quality of diagnostics for out-of-range radices.
9185 Calculate buffer size correctly for out-of-range radices.
9186 (read1): Check for integer overflow in radices, and in
9187 read-circle numbers.
82cb60d3
PE
9188 (read_escape): Avoid int overflow.
9189 (Fload, openp, read_buffer_size, read1)
9190 (substitute_object_recurse, read_vector, read_list, map_obarray):
9191 Use ptrdiff_t, not int, for sizes.
9192 (read1): Use EMACS_INT, not int, for sizes.
20270765 9193 Check for size overflow.
8b9ac8b4 9194
7fcccf1e
PE
9195 * image.c (cache_image): Check for size arithmetic overflow.
9196
bfbbd7e7
PE
9197 * lread.c: Integer overflow issues.
9198 (saved_doc_string_size, saved_doc_string_length)
9199 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9200 Now ptrdiff_t, not int.
9201 (read1): Don't assume doc string length fits in int. Check for
9202 out-of-range doc string lengths.
9203 (read_list): Don't assume file position fits in int.
39019e54 9204 (read_escape): Check for hex character overflow.
bfbbd7e7 9205
4e323265
LL
92062011-06-22 Leo Liu <sdl.web@gmail.com>
9207
9208 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9209 Move to minibuffer.el.
9210
85fece3e
PE
92112011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9212
20b84ce9 9213 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9214 The following patches are for when GLYPH_DEBUG && !XASSERT.
9215 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9216 * dispnew.c (flush_stdout):
9217 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9218 Mark as externally visible.
9219 * dispnew.c (check_window_matrix_pointers): Now static.
9220 * dispnew.c (window_to_frame_vpos):
9221 * xfns.c (unwind_create_frame):
9222 * xterm.c (x_check_font): Remove unused local.
9223 * scroll.c (CHECK_BOUNDS):
9224 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9225 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9226 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9227 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9228 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9229 Now static.
9230 (debug_method_add): Use va_list and vsprintf rather than relying
9231 on undefined behavior with wrong number of arguments.
9232 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9233 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9234 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9235 since we're not interested in debugging glyphs with old libraries.
9236 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9237 GCC 4.6.0's static checking.
9238
0766b489
PE
92392011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9240
31fd4b32
PE
9241 Integer overflow and signedness fixes (Bug#8873).
9242 A few related buffer overrun fixes, too.
9243
b79e8648
PE
9244 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9245
0766b489
PE
9246 * dispextern.h (struct face.stipple):
9247 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9248 (x_bitmap_mask, x_allocate_bitmap_record)
9249 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9250 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9251 (x_create_bitmap_from_xpm_data):
9252 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9253 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9254 (.bitmaps_last):
9255 * xfaces.c (load_pixmap):
9256 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9257 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9258 (.bitmaps_last, struct x_output.icon_bitmap):
9259 Use ptrdiff_t, not int, for bitmap indexes.
9260 (x_allocate_bitmap_record): Check for size overflow.
9261 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9262
b081724f
PE
9263 Use ptrdiff_t, not int, for overlay counts.
9264 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9265 * editfns.c (overlays_around, get_pos_property):
9266 * textprop.c (get_char_property_and_overlay):
9267 * xdisp.c (next_overlay_change, note_mouse_highlight):
9268 * xfaces.c (face_at_buffer_position):
21514da7
PE
9269 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9270 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9271 (Fnext_overlay_change, Fprevious_overlay_change)
9272 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9273 Use ptrdiff_t, not int, for sizes.
21514da7 9274 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9275
3de73e5e
PE
9276 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9277
2606c57b
PE
9278 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9279 (x_session_initialize): Do not assume string length fits in int.
9280
aaafe47a
PE
9281 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9282 This is unlikely, but can occur if DPI is outlandish.
9283
2674ddc8 9284 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9285 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9286
28154962
PE
9287 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9288 * xrdb.c (magic_file_p, search_magic_path):
9289 Omit last arg SUFFIX; it was always 0. All callers changed.
9290 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9291
7de51af5
PE
9292 * xfont.c (xfont_match): Avoid need for strlen.
9293
25ed6cc3
PE
9294 * xfns.c: Don't assume strlen fits in int.
9295 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9296
4eab31dd
PE
9297 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9298 not unsigned long, as we prefer signed integers. All callers changed.
9299 Detect integer overflow in repeat count.
9300 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9301 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9302
171e2a58
PE
9303 * termcap.c: Don't assume sizes fit in int and never overflow.
9304 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9305 (gobble_line): Check for size-calculation overflow.
9306
ad39faca 9307 * minibuf.c (Fread_buffer):
6e5bb2dc 9308 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9309 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9310 Don't assume string length fits in int.
9311
52c61c22 9312 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9313 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9314
b5b8c9e5
PE
9315 * font.c: Don't assume string length fits in int.
9316 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9317 Use ptrdiff_t, not int.
ccd6111c
PE
9318 (font_intern_prop): Don't assume string length fits in int.
9319 Don't assume integer property fits in fixnum.
9320 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9321
882f0d81 9322 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9323 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9324 Reformulate so as not to need the command string.
9325 Invoke gzip -cd rather than gunzip, as it's more portable.
9326 (lock_info_type, lock_file_1, lock_file):
9327 Don't assume pid_t and time_t fit in unsigned long.
9328 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9329 (current_lock_owner): Prefer signed type for sizes.
9330 Use memcpy, not strncpy, where memcpy is what is really wanted.
9331 Don't assume (via atoi) that time_t and pid_t fit in int.
9332 Check for time_t and/or pid_t out of range, e.g., via a network share.
9333 Don't alloca where an auto var works fine.
9334
93f4cf88
PE
9335 * fileio.c: Fix some integer overflow issues.
9336 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9337 Don't assume string length fits in int.
9338 (directory_file_name): Don't assume string length fits in long.
9339 (make_temp_name): Don't assume pid fits in int, or that its print
9340 length is less than 20.
9341
f3e92b69
PE
9342 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9343
1bfdaf10
PE
9344 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9345
35016e9a
PE
9346 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9347
3d1e65a1
PE
9348 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9349 We prefer signed integers, even for size calculations.
9350
0b963a93
PE
9351 * emacs.c: Don't assume string length fits in 'int'.
9352 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9353 (main): Don't invoke strlen when not needed.
9354
573f4b54
PE
9355 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9356 (XD_DEBUG_MESSAGE): Don't waste a byte.
9357
989f33ba
PE
9358 * callproc.c (getenv_internal_1, getenv_internal)
9359 (Fgetenv_internal):
965d34eb
PE
9360 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9361
e4d29b33
PE
9362 * lread.c (invalid_syntax): Omit length argument.
9363 All uses changed. This doesn't fix a bug, but it simplifies the
9364 code away from its former Hollerith-constant appearance, and it's
9365 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9366 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9367
eb49b136
PE
9368 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9369 This didn't break anything, but it didn't help either.
9370 It's confusing to put a bogus integer in a place where the actual
9371 value does not matter.
9f62aeb1 9372 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9373 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9374
15375a22
PE
9375 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9376 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9377 implementation.
b61cc01c
PE
9378 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9379 We prefer signed types, and the value cannot exceed the EMACS_INT
9380 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9381 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9382 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9383 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9384
53b2623d
PE
9385 * indent.c (sane_tab_width): New function.
9386 (current_column, scan_for_column, Findent_to, position_indentation)
9387 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9388 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9389
51cab52b 9390 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9391
f2ed8a70
PE
9392 * lisp.h (lint_assume): New macro.
9393 * composite.c (composition_gstring_put_cache):
9394 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9395
abe80cc6
PE
9396 * editfns.c, insdel.c:
9397 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9398
b02c740e
PE
9399 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9400
ebc96716
PE
9401 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9402
b4e50fa0 9403 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9404 Use much-faster test for byte-length change.
311d5d7c 9405 Don't assume string byte-length fits in 'int'.
a4cf38e4 9406 Check that character arg fits in 'int'.
85461888 9407 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9408
c0c1ee9f
PE
9409 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9410
a498d7f4
PE
9411 * fns.c (concat): Catch string overflow earlier.
9412 Do not rely on integer wraparound.
9413
51cab52b
PE
9414 * dispextern.h (struct it.overlay_strings_charpos)
9415 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9416 * xdisp.c (forward_to_next_line_start)
9417 (back_to_previous_visible_line_start)
9418 (reseat_at_next_visible_line_start, next_element_from_buffer):
9419 Don't arbitrarily truncate the value of 'selective' to int.
9420
76031fad
PE
9421 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9422
5eb55db9
PE
9423 * composite.c: Don't truncate sizes to 'int'.
9424 (composition_gstring_p, composition_reseat_it)
9425 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9426 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9427 not EMACS_UINT, for indexes.
5eb55db9 9428
0703a717
PE
9429 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9430
d6202519
PE
9431 * buffer.c: Include <verify.h>.
9432 (struct sortvec.priority, struct sortstr.priority):
8961a454 9433 Now EMACS_INT, not int.
c20998a7 9434 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9435 (struct sortstr.size, record_overlay_string)
9436 (struct sortstrlist.size, struct sortlist.used):
9437 Don't truncate size to int.
9438 (record_overlay_string): Check for size-calculation overflow.
d6202519 9439 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9440
d5a19415
JM
94412011-06-22 Jim Meyering <meyering@redhat.com>
9442
029529ac 9443 Don't leak an XBM-image-sized buffer
d5a19415
JM
9444 * image.c (xbm_load): Free the image buffer after using it.
9445
a9041e6c
PE
94462011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9447
9448 Port to Sun C.
9449 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9450 that Sun C diagnosed.
9451 * fns.c (secure_hash): Fix pointer signedness issue.
9452 * intervals.c (static_offset_intervals): New function.
9453 (offset_intervals): Use it.
9454
7f3f739f
LL
94552011-06-21 Leo Liu <sdl.web@gmail.com>
9456
9457 * deps.mk (fns.o):
9458 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9459 sha512.h.
9460
9461 * fns.c (secure_hash): Rename from crypto_hash_function and change
9462 the first arg to accept symbols.
5b66d427 9463 (Fsecure_hash): New primitive.
7f3f739f
LL
9464 (syms_of_fns): New symbols.
9465
76147d94
DD
94662011-06-20 Deniz Dogan <deniz@dogan.se>
9467
9468 * process.c (Fset_process_buffer): Clarify return value in
9469 docstring.
9470
7d7d0045
CY
94712011-06-18 Chong Yidong <cyd@stupidchicken.com>
9472
9473 * dispnew.c (add_window_display_history): Use BVAR.
9474
9475 * xdisp.c (debug_method_add): Use BVAR.
9476 (check_window_end, dump_glyph_matrix, dump_glyph)
9477 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9478
9479 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9480 Likewise.
9481
9482 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9483 check till after the cache is created in init_frame_faces.
9484
ff2bc410
SM
94852011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9486
9487 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9488
28177add
PE
94892011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9490
dd3482fe
PE
9491 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9492 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9493 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9494
393d71f3 9495 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9496 * fileio.c (Finsert_file_contents):
9497 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9498 Remove the old (too-loose) buffer overflow checks.
9499 They weren't needed, since make_gap checks for buffer overflow.
9500 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9501 The old code merely checked for Emacs fixnum overflow, and relied
9502 on undefined (wraparound) behavior. The new code avoids undefined
9503 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9504
2e6813b0 9505 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9506 Tune. Don't use wider integers than needed. Don't use alloca.
9507 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9508
599a9e4f
PE
9509 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9510
99561444
PE
9511 * insdel.c, lisp.h (buffer_overflow): New function.
9512 (insert_from_buffer_1, replace_range, replace_range_2):
9513 * insdel.c (make_gap_larger):
9514 * editfns.c (Finsert_char):
9515 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9516
28177add
PE
9517 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9518
e69dafad
PE
95192011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9520
4baa020d 9521 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9522
b1c46f02
PE
9523 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9524 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9525
e69dafad
PE
9526 * fileio.c: Don't assume EMACS_INT fits in off_t.
9527 (emacs_lseek): New static function.
9528 (Finsert_file_contents, Fwrite_region): Use it.
9529 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9530
566684ea
PE
9531 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9532
e6966cd6
PE
9533 * fns.c: Don't overflow int when computing a list length.
9534 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9535 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9536 truncation on 64-bit hosts. Check for QUIT every
9537 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9538 faster and is responsive enough.
9539 (Flength): Report an error instead of overflowing an integer.
9540 (Fsafe_length): Return a float if the value is not representable
9541 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9542 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9543 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9544
dd0b0efb
PE
9545 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9546 (header_size, word_size): New constants.
9547 (allocate_vectorlike): Don't check size overflow here.
9548 (allocate_vector): Check it here instead, since this is the only
9549 caller of allocate_vectorlike that could cause overflow.
9550 Check that the new vector's length is representable as a fixnum.
9551
86fe5cfe
PE
9552 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9553 The previous code was bogus. For example, next_almost_prime (32)
9554 returned 39, which is undesirable as it is a multiple of 3; and
9555 next_almost_prime (24) returned 25, which is a multiple of 5 so
9556 why was the code bothering to check for multiples of 7?
9557
80e88859
PE
9558 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9559
4a2f0ad6
PE
9560 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9561
f66c7cf8
PE
9562 Variadic C functions now count arguments with ptrdiff_t.
9563 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9564 Back then I didn't know that the Emacs coding style prefers signed int.
9565 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9566 were being counted with int, which may truncate counts on 64-bit
9567 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9568 * lisp.h (struct Lisp_Subr.function.aMANY)
9569 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9570 Arg counts are now ptrdiff_t, not size_t.
9571 All variadic functions and their callers changed accordingly.
9572 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9573 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9574 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9575 * callint.c (Fcall_interactively): Check arg count for overflow,
9576 to avoid potential buffer overrun. Use signed char, not 'int',
9577 for 'varies' array, so that we needn't bother to check its size
9578 calculation for overflow.
9579 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9580 * eval.c (apply_lambda):
9581 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9582 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9583 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9584
a1759b76
PE
9585 * callint.c (Fcall_interactively): Don't use index var as event count.
9586
d96be9fc
PE
9587 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9588 * mem-limits.h (SIZE): Remove; no longer used.
9589
a690a978 9590 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9591
578c21e6
PE
9592 Remove unnecessary casts.
9593 * xterm.c (x_term_init):
9594 * xfns.c (x_set_border_pixel):
9595 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9596 These aren't needed now that we assume ANSI C.
9597
96f53c6c
PE
9598 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9599 It's more likely to cause problems (due to unsigned overflow)
9600 than to cure them.
9601
83c77d31
PE
9602 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9603
ee2079f1
PE
9604 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9605
6da65536
PE
9606 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9607
7147c4a4
PE
9608 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9609
193e32d9
PE
9610 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9611
e5533da6
PE
9612 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9613
9910e595
PE
9614 GLYPH_CODE_FACE returns EMACS_INT, not int.
9615 * dispextern.h (merge_faces):
9616 * xfaces.c (merge_faces):
01103c44
PE
9617 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9618 Don't assume EMACS_INT fits in int.
9910e595 9619
2638320e
PE
9620 * character.h (CHAR_VALID_P): Remove unused parameter.
9621 * fontset.c, lisp.h, xdisp.c: All uses changed.
9622
045eb8d9
PE
9623 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9624
c1f134b5
PE
9625 * fns.c (concat): Minor tuning based on overflow analysis.
9626 This doesn't fix any bugs. Use int to hold character, instead
9627 of constantly refetching from Emacs object. Use XFASTINT, not
9628 XINT, for value known to be a character. Don't bother comparing
9629 a single byte to 0400, as it's always less.
9630
395fcb93 9631 * floatfns.c (Fexpt):
327eeec8
PE
9632 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9633
abbd3d23
PE
9634 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9635 for characters.
9636
684a03ef
PE
9637 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9638
0fed43f3
PE
9639 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9640 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9641 incorrectly succeed when S was a string, because 4294967386 was
9642 truncated before it was used.
9643
8fd02eb7
PE
9644 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9645 Otherwise, an out-of-range integer could cause undefined behavior
9646 on a 64-bit host.
9647
f8c86b69
PE
9648 * composite.c: Use int, not EMACS_INT, for characters.
9649 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9650 EMACS_INT, for values that are known to be in character range.
9651 This doesn't fix any bugs but is the usual style inside Emacs and
9652 may generate better code on 32-bit machines.
9653
34206dd2
PE
9654 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9655 This is for reasons similar to the recent CHAR_STRING fix.
9656 * charset.c (Fencode_char): Check that character arg is actually
9657 a character. Pass an int to ENCODE_CHAR.
9658 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9659 wider than 'int', as a compile-time check to prevent future regressions
9660 in this area.
9661
c5958d4c 9662 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9663
9664 Make sure a 64-bit char is never passed to CHAR_STRING.
9665 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9666 by silently ignoring the top 32 bits, allowing some values
9667 that were far too large to be valid characters.
9668 * character.h: Include <verify.h>.
9669 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9670 arguments are no wider than unsigned, as a compile-time check
9671 to prevent future regressions in this area.
9672 * data.c (Faset):
01103c44 9673 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9674 (Fsubst_char_in_region):
9675 * fns.c (concat):
9676 * xdisp.c (decode_mode_spec_coding):
9677 Adjust to CHAR_STRING's new requirement.
9678 * editfns.c (Finsert_char, Fsubst_char_in_region):
9679 * fns.c (concat): Check that character args are actually
9680 characters. Without this test, these functions did the wrong
9681 thing with wildly out-of-range values on 64-bit hosts.
9682
d37ca623
PE
9683 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9684 These casts should not be needed on 32-bit hosts, either.
9685 * keyboard.c (read_char):
9686 * lread.c (Fload): Remove casts to unsigned.
9687
ea204efb
PE
9688 * lisp.h (UNSIGNED_CMP): New macro.
9689 This fixes comparison bugs on 64-bit hosts.
9690 (ASCII_CHAR_P): Use it.
9691 * casefiddle.c (casify_object):
01103c44 9692 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9693 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9694 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9695 * dispextern.h (FACE_FROM_ID):
9696 * keyboard.c (read_char): Use UNSIGNED_CMP.
9697
41cb286c
PE
9698 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9699 not to EMACS_INT, to avoid GCC warning.
9700
4a1b9832
PE
9701 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9702
55daad71
PE
9703 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9704 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9705 isn't needed on 32-bit machines.
8f95c75c 9706
01103c44
PE
9707 * buffer.c (Fgenerate_new_buffer_name):
9708 Use EMACS_INT for count, not int.
0ceccced 9709 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9710
9711 * data.c (Qcompiled_function): Now static.
9712
c6f072e7
PE
9713 * window.c (window_body_lines): Now static.
9714
20ce5912
PE
9715 * image.c (gif_load): Rename local to avoid shadowing.
9716
9c4c5f81
PE
9717 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9718 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9719 * alloc.c (make_save_value): Integer argument is now of type
9720 ptrdiff_t, not int.
9721 (mark_object): Use ptrdiff_t, not int.
9722 * lisp.h (pD): New macro.
9723 * print.c (print_object): Use it.
9724
c0c5c8ae
PE
9725 * alloc.c: Use EMACS_INT, not int, to count objects.
9726 (total_conses, total_markers, total_symbols, total_vector_size)
9727 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9728 (total_free_floats, total_floats, total_free_intervals)
9729 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9730 Now EMACS_INT, not int. All uses changed.
9731 (Fgarbage_collect): Compute overall total using a double, so that
9732 integer overflow is less likely to be a problem. Check for overflow
9733 when converting back to an integer.
5a25e253
PE
9734 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9735 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9736 These were 'int' variables that could overflow on 64-bit hosts;
9737 they were never used, so remove them instead of repairing them.
211a0b2a 9738 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9739 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9740 Previously, this ceilinged at INT_MAX, but that doesn't work on
9741 64-bit machines.
e46bb31a 9742 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9743
c78baabf 9744 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9745 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9746 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9747 when a (possibly-narrower) signed value would do just as well.
9748 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9749
c9d624c6
PE
9750 * alloc.c: Catch some string size overflows that we were missing.
9751 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9752 for convenience in STRING_BYTES_MAX.
9753 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9754 The definition here is exact; the one in lisp.h was approximate.
9755 (allocate_string_data): Check for string overflow. This catches
9756 some instances we weren't catching before. Also, it catches
9757 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9758 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9759 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9760
c9d624c6
PE
9761 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9762 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9763 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9764
353032ce
PE
9765 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9766
2bccce07
PE
9767 * alloc.c (Fmake_string): Check for out-of-range init.
9768
0ac30604
SM
97692011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9770
9771 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9772
c195f2de
JD
97732011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9774
9775 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9776 xg_get_default_scrollbar_width.
9777
9778 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9779 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9780 (style_changed_cb): Call update_theme_scrollbar_width and call
9781 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9782 all frames (Bug#8505).
9783 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9784 Call gtk_window_set_resizable if HAVE_GTK3.
9785 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9786 and height if HAVE_GTK3 (Bug#8505).
9787 (scroll_bar_width_for_theme): New variable.
9788 (update_theme_scrollbar_width): New function.
9789 (xg_get_default_scrollbar_width): Move code to
9790 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9791 (xg_initialize): Call update_theme_scrollbar_width.
9792
9793 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9794
9795 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9796
e10ac9f1
MR
97972011-06-12 Martin Rudalics <rudalics@gmx.at>
9798
9799 * frame.c (make_frame): Call other_buffer_safely instead of
9800 other_buffer.
9801
9802 * window.c (temp_output_buffer_show): Call display_buffer with
9803 second argument Vtemp_buffer_show_specifiers and reset latter
9804 immediately after the call.
9805 (Vtemp_buffer_show_specifiers): New variable.
9806 (auto_window_vscroll_p, next_screen_context_lines)
9807 (Vscroll_preserve_screen_position): Remove leading asterisks from
9808 doc-strings.
9809
2d3c217e 98102011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9811
7b7f97e8 9812 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9813 * buffer.c (Qclone_number): Remove for now, as it's unused.
9814 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9815 (record_buffer): Remove unused local.
9816 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9817 (set_frame_buffer_list): Remove; unused.
9818 * frame.h (other_visible_frames): Remove decl.
9819 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9820 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9821 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9822 if HAVE_GPM.
9823 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9824 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9825 Define only if HAVE_GPM.
9826 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9827 (update_hints_inhibit): Remove; never set. All uses removed.
9828 * widgetprv.h (emacsFrameClassRec): Remove decl.
9829 * window.c (delete_deletable_window): Now returns void, since it
9830 wasn't returning anything.
9831 (compare_window_configurations): Remove unused locals.
9832 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9833 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9834 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9835 the same widths as pointers. This follows up on the 2011-05-06 patch.
9836 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9837 * xterm.h: Likewise.
9838 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9839
1384b89e
JB
98402011-06-12 Juanma Barranquero <lekktu@gmail.com>
9841
9842 * makefile.w32-in: Update dependencies.
9843 (LISP_H): Add lib/intprops.h.
9844
1100a63c
CY
98452011-06-11 Chong Yidong <cyd@stupidchicken.com>
9846
9847 * image.c (gif_load): Add animation frame delay to the metadata.
9848 (syms_of_image): Use DEFSYM. New symbol `delay'.
9849
6198ccd0
MR
98502011-06-11 Martin Rudalics <rudalics@gmx.at>
9851
9852 * window.c (delete_deletable_window): Re-add.
9853 (Fset_window_configuration): Rewrite to handle dead buffers and
9854 consequently deletable windows.
9855 (window_tree, Fwindow_tree): Remove. Supply functionality in
9856 window.el.
9857 (compare_window_configurations): Simplify code.
9858
b6e3633c
AS
98592011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9860
1ab0dee5
AS
9861 * image.c (imagemagick_load_image): Fix type mismatch.
9862 (Fimagemagick_types): Likewise.
9863
b6e3633c
AS
9864 * window.h (replace_buffer_in_windows): Declare.
9865
9397e56f
MR
98662011-06-11 Martin Rudalics <rudalics@gmx.at>
9867
9868 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9869 Qclone_number. Remove external declaration of Qdelete_window.
9870 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9871 code.
640c8776
SM
9872 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9873 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9874 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9875 buffer list implementation.
9876 (other_buffer_safely): New function.
9877 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9878 calls to replace_buffer_in_windows and
9879 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9880 if allowed.
9881 (record_buffer): Inhibit quitting and rewrite using quittable
9882 functions. Run Qbuffer_list_update_hook if allowed.
9883 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9884 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9885 Move switch-to-buffer to window.el.
9397e56f
MR
9886 (bury-buffer): Move to window.el.
9887 (Vbuffer_list_update_hook): New variable.
9888
9889 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9890 section.
9891
9892 * window.h (resize_frame_windows): Move up in code.
9893 (Fwindow_frame): Remove EXFUN.
9894 (replace_buffer_in_all_windows): Remove prototype.
9895 (replace_buffer_in_windows_safely): Add prototype.
9896
9897 * window.c: Declare Qdelete_window static again. Move down
9898 declaration of select_count.
9899 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9900 (Fother_window): Move to window.el.
9901 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9902 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9903 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9904 window.el.
9905 (replace_buffer_in_windows): Implement by calling
9906 Qreplace_buffer_in_windows.
9907 (replace_buffer_in_all_windows): Remove with some functionality
9908 moved into replace_buffer_in_windows_safely.
9909 (replace_buffer_in_windows_safely): New function.
9910 (select_window_norecord, select_frame_norecord): Move in front
9911 of run_window_configuration_change_hook. Remove now obsolete
9912 declarations.
640c8776
SM
9913 (Fset_window_buffer): Rewrite doc-string.
9914 Call Qrecord_window_buffer.
9397e56f
MR
9915 (keys_of_window): Move binding for other-window to window.el.
9916
b50691aa
CY
99172011-06-11 Chong Yidong <cyd@stupidchicken.com>
9918
9919 * dispextern.h (struct image): Replace data member, whose int_val
9920 and ptr_val fields were not used by anything, with a single
9921 lisp_val object.
9922
9923 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9924 (gif_clear_image, gif_load, imagemagick_load_image)
9925 (gs_clear_image, gs_load): Callers changed.
9926
3f754b86
PE
99272011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9928
cca69397
PE
9929 * buffer.h: Include <time.h>, for time_t.
9930 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9931
109e28d0
PE
9932 Fix minor problems found by static checking.
9933
60737f02
PE
9934 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9935
4b66faf3
PE
9936 Make identifiers static if they are not used in other modules.
9937 * data.c (Qcompiled_function, Qframe, Qvector):
9938 * image.c (QimageMagick, Qsvg):
9939 * minibuf.c (Qmetadata):
9940 * window.c (resize_window_check, resize_root_window): Now static.
9941 * window.h (resize_window_check, resize_root_window): Remove decls.
9942
109e28d0
PE
9943 * window.c (window_deletion_count, delete_deletable_window):
9944 Remove; unused.
46a4ce9e
PE
9945 (window_body_lines): Now static.
9946 (Fdelete_other_windows_internal): Mark vars as initialized.
9947 Make sure 'resize_failed' is initialized.
9948 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9949 (resize_window_apply): Remove unused local.
9950 * window.h (delete_deletable_window): Remove decl.
9951
109e28d0 9952 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9953 (imagemagick_load_image): Fix pointer signedness problem by changing
9954 last arg from unsigned char * to char *. All uses changed.
9955 Also, fix a local for similar reasons.
9956 Remove unused locals. Remove locals to avoid shadowing.
9957 (fn_rsvg_handle_free): Remove; unused.
9958 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9959 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9960
3f754b86
PE
9961 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9962
2547adb1
CY
99632011-06-10 Chong Yidong <cyd@stupidchicken.com>
9964
9965 * image.c (gif_load): Fix omitted cast error introduced by
9966 2011-06-06 change.
9967
2c8e37d4
MR
99682011-06-10 Martin Rudalics <rudalics@gmx.at>
9969
9970 * window.h (resize_proportionally, orig_total_lines)
9971 (orig_top_line): Remove from window structure.
9972 (set_window_height, set_window_width, change_window_heights)
9973 (Fdelete_window): Remove prototypes.
9974 (resize_frame_windows): Remove duplicate declaration.
9975
440a42e3
EZ
99762011-06-10 Eli Zaretskii <eliz@gnu.org>
9977
9978 * window.h (resize_frame_windows, resize_window_check)
9979 (delete_deletable_window, resize_root_window)
9980 (resize_frame_windows): Declare prototypes.
9981
9982 * window.c (resize_window_apply): Make definition be "static" to
9983 match the prototype.
9984
562dd5e9
MR
99852011-06-10 Martin Rudalics <rudalics@gmx.at>
9986
9987 * window.c: Remove declarations of Qwindow_size_fixed,
9988 window_min_size_1, window_min_size_2, window_min_size,
9989 size_window, window_fixed_size_p, enlarge_window, delete_window.
9990 Remove static from declaration of Qdelete_window, it's
9991 temporarily needed by Fbury_buffer.
9992 (replace_window): Don't assign orig_top_line and
9993 orig_total_lines.
9994 (Fdelete_window, delete_window): Remove. Window deletion is
9995 handled by window.el.
640c8776
SM
9996 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9997 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9998 (Fdelete_other_windows): Remove. Deleting other windows is
9999 handled by window.el.
10000 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10001 handled in window.el.
10002 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10003 Window minimum sizes are handled in window.el.
10004 (shrink_windows, size_window, set_window_height)
10005 (set_window_width, change_window_heights, window_height)
10006 (window_width, CURBEG, CURSIZE, enlarge_window)
10007 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10008 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10009 handled in window.el.
10010 (make_dummy_parent): Rename to make_parent_window and give it a
10011 second argument horflag.
10012 (make_window): Don't set resize_proportionally any more.
10013 (Fsplit_window): Remove. Windows are split in window.el.
10014 (save_restore_action, save_restore_orig_size)
10015 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10016 Resize mini windows in window.el.
10017 (grow_mini_window, shrink_mini_window): Implement by calling
10018 Qresize_root_window_vertically, resize_window_check and
10019 resize_window_apply.
640c8776
SM
10020 (saved_window, Fset_window_configuration, save_window_save):
10021 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10022 resize_proportionally.
10023 (window_min_height, window_min_width): Move to window.el.
10024 (keys_of_window): Move bindings for delete-other-windows,
10025 split-window, delete-window and enlarge-window to window.el.
10026
10027 * buffer.c: Temporarily extern Qdelete_window.
10028 (Fbury_buffer): Temporarily call Qdelete_window instead of
10029 Fdelete_window (Fbury_buffer will move to window.el soon).
10030
10031 * frame.c (set_menu_bar_lines_1): Remove code handling
10032 orig_top_line and orig_total_lines.
10033
10034 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10035 set_window_height but set heights directly.
10036 (change_frame_size_1): Use resize_frame_windows.
10037
10038 * xdisp.c (init_xdisp): Don't use set_window_height but set
10039 heights directly.
10040
640c8776
SM
10041 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10042 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10043 run_window_configuration_change_hook.
10044
10045 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10046 instead of change_window_heights and run
10047 run_window_configuration_change_hook.
10048
1a13852e
MR
100492011-06-09 Martin Rudalics <rudalics@gmx.at>
10050
10051 * window.c (replace_window): Rename second argument REPLACEMENT to
10052 NEW. New third argument SETFLAG. Rewrite.
10053 (delete_window, make_dummy_parent): Call replace_window with
10054 third argument 1.
10055 (window_list_1): Move down in code.
10056 (run_window_configuration_change_hook): Move set_buffer part
10057 before select_frame_norecord part in order to unwind correctly.
10058 Rename count1 to count.
10059 (recombine_windows, delete_deletable_window, resize_root_window)
10060 (Fdelete_other_windows_internal)
10061 (Frun_window_configuration_change_hook, make_parent_window)
10062 (resize_window_check, resize_window_apply, Fresize_window_apply)
10063 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10064 (Fdelete_window_internal, Fresize_mini_window_internal):
10065 New functions.
1a13852e
MR
10066 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10067
f3d1777e
MR
100682011-06-08 Martin Rudalics <rudalics@gmx.at>
10069
496e208e
MR
10070 * window.h (window): Add some new members to window structure -
10071 normal_lines, normal_cols, new_total, new_normal, clone_number,
10072 splits, nest, prev_buffers, next_buffers.
10073 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10074 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10075
f3d1777e
MR
10076 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10077 Remove.
496e208e
MR
10078 (make_dummy_parent): Set new members of windows structure.
10079 (make_window): Move down in code. Handle new members of window
10080 structure.
10081 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10082 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10083 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10084 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10085 (Fset_window_next_buffers, Fset_window_clone_number):
10086 New functions.
496e208e
MR
10087 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10088 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10089 Doc-string fixes.
10090 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10091 Argument WINDOW can be now internal window too.
10092 (Fwindow_use_time): Move up in code.
10093 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10094 Rewrite doc-string.
10095 (Fset_window_configuration, saved_window)
10096 (Fcurrent_window_configuration, save_window_save): Handle new
10097 members of window structure.
b9e809c2
MR
10098 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10099 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10100 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10101 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10102 Qget_mru_window, Qresize_root_window,
10103 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10104 Qauto_buffer_name; staticpro them.
f3d1777e 10105
abde8f8c
MR
101062011-06-07 Martin Rudalics <rudalics@gmx.at>
10107
10108 * window.c (Fwindow_total_size, Fwindow_left_column)
10109 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10110 (Fwindow_list_1): New functions.
10111 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10112 (Fwindow_width, Fscroll_left, Fscroll_right):
10113 Use window_body_cols instead of window_box_text_cols.
10114 (delete_window, Fset_window_configuration):
10115 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10116 (delete_all_subwindows): Take a window as argument and not a
10117 structure. Rewrite.
190b47e6
MR
10118 (window_loop): Remove handling of GET_LRU_WINDOW and
10119 GET_LARGEST_WINDOW.
10120 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10121
10122 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10123 window_box_text_cols. delete_all_subwindows now takes a
10124 Lisp_Object as argument.
abde8f8c 10125
640c8776
SM
10126 * indent.c (compute_motion, Fcompute_motion):
10127 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10128
fa8a67e6
MR
10129 * frame.c (delete_frame): Call delete_all_subwindows with root
10130 window as argument.
10131
a54e3482
DC
101322011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10133
10134 * fns.c (Fputhash): Document return value.
10135
60002bf5
CY
101362011-06-06 Chong Yidong <cyd@stupidchicken.com>
10137
10138 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10139
0c671da6 101402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10141
b862a52a 10142 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10143
be44ca6c
PE
10144 Check for overflow when converting integer to cons and back.
10145 * charset.c (Fdefine_charset_internal, Fdecode_char):
10146 Use cons_to_unsigned to catch overflow.
10147 (Fencode_char): Use INTEGER_TO_CONS.
10148 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10149 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10150 * data.c (long_to_cons, cons_to_long): Remove.
10151 (cons_to_unsigned, cons_to_signed): New functions.
10152 These signal an error for invalid or out-of-range values.
10153 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10154 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10155 * font.c (Ffont_variation_glyphs):
10156 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10157 * lisp.h: Include <intprops.h>.
10158 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10159 (cons_to_signed, cons_to_unsigned): New decls.
10160 (long_to_cons, cons_to_long): Remove decls.
10161 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10162 (Fprimitive_undo): Use CONS_TO_INTEGER.
10163 * xfns.c (Fx_window_property): Likewise.
10164 * xselect.c: Include <limits.h>.
10165 (x_own_selection, selection_data_to_lisp_data):
10166 Use INTEGER_TO_CONS.
10167 (x_handle_selection_request, x_handle_selection_clear)
10168 (x_get_foreign_selection, Fx_disown_selection_internal)
10169 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10170 (lisp_data_to_selection_data): Use cons_to_unsigned.
10171 (x_fill_property_data): Use cons_to_signed.
10172 Report values out of range.
10173
d1f3d2af
PE
10174 Check for buffer and string overflow more precisely.
10175 * buffer.h (BUF_BYTES_MAX): New macro.
10176 * lisp.h (STRING_BYTES_MAX): New macro.
10177 * alloc.c (Fmake_string):
10178 * character.c (string_escape_byte8):
10179 * coding.c (coding_alloc_by_realloc):
10180 * doprnt.c (doprnt):
10181 * editfns.c (Fformat):
10182 * eval.c (verror):
10183 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10184 since they may not be the same number.
10185 * editfns.c (Finsert_char):
10186 * fileio.c (Finsert_file_contents):
10187 Likewise for BUF_BYTES_MAX.
10188
dd52fcea
PE
10189 * image.c: Use ptrdiff_t, not int, for sizes.
10190 (slurp_file): Switch from int to ptrdiff_t.
10191 All uses changed.
10192 (slurp_file): Check that file size fits in both size_t (for
10193 malloc) and ptrdiff_t (for sanity and safety).
10194
7f9bbdbb
PE
10195 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10196 if b->modtime has its maximal value.
10197
dfe18f82
PE
10198 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10199
84acfcf0
PE
10200 Don't assume time_t can fit into int.
10201 * buffer.h (struct buffer.modtime): Now time_t, not int.
10202 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10203 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10204
ccd9a01a
PE
10205 Minor fixes for signed vs unsigned integers.
10206 * character.h (MAYBE_UNIFY_CHAR):
10207 * charset.c (maybe_unify_char):
10208 * keyboard.c (read_char, reorder_modifiers):
10209 XINT -> XFASTINT, since the integer must be nonnegative.
10210 * ftfont.c (ftfont_spec_pattern):
10211 * keymap.c (access_keymap, silly_event_symbol_error):
10212 XUINT -> XFASTINT, since the integer must be nonnegative.
10213 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10214 since it makes no difference and we prefer signed.
10215 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10216 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10217 nonnegative.
10218
d6d100dd
SM
102192011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10220
10221 * window.h (Fwindow_frame): Declare.
10222
2b6148e4
PE
102232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10224
10225 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10226 (SPARE_MEMORY): Always define.
10227 (LARGE_REQUEST): Remove.
10228 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10229
f230ecc9
MR
102302011-06-06 Martin Rudalics <rudalics@gmx.at>
10231
727e958e
MR
10232 * lisp.h: Move EXFUNS for Fframe_root_window,
10233 Fframe_first_window and Fset_frame_selected_window to window.h.
10234
10235 * window.h: Move EXFUNS for Fframe_root_window,
10236 Fframe_first_window and Fset_frame_selected_window here from
10237 lisp.h.
10238
10239 * frame.c (Fwindow_frame, Fframe_first_window)
10240 (Fframe_root_window, Fframe_selected_window)
10241 (Fset_frame_selected_window): Move to window.c.
10242 (Factive_minibuffer_window): Move to minibuf.c.
10243 (Fother_visible_frames_p): New function.
10244
10245 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10246
f230ecc9
MR
10247 * window.c (decode_window, decode_any_window): Move up in code.
10248 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10249 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10250 (Fwindow_buffer): Move up and rewrite doc-string.
10251 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10252 (Fwindow_prev): New functions.
727e958e
MR
10253 (Fwindow_frame): Move here from frame.c. Accept any window as
10254 argument.
10255 (Fframe_root_window, Fframe_first_window)
10256 (Fframe_selected_window): Move here from frame.c. Accept frame
10257 or arbitrary window as argument. Update doc-strings.
10258 (Fminibuffer_window): Move up in code.
10259 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10260 (Fset_frame_selected_window): Move here from frame.c.
10261 Marginal rewrite.
727e958e
MR
10262 (Fselected_window, select_window, Fselect_window): Move up in
10263 code. Minor doc-string fixes.
f230ecc9 10264
4d09bcf6
PE
102652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10266
10267 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10268 Do not assume that spare memory exists; that assumption is valid
10269 only if SYSTEM_MALLOC.
10270 (LARGE_REQUEST): New macro, so that the issue of large requests
10271 is separated from the issue of spare memory.
10272
810928a2
AS
102732011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10274
172418ad
AS
10275 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10276 format. (Bug#8806)
10277
43f862f7
AS
10278 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10279
810928a2
AS
10280 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10281 before statements.
10282
a059fe24
JD
102832011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10284
10285 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10286
10287 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10288
10289 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10290 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10291
989bf368
JB
102922011-06-05 Juanma Barranquero <lekktu@gmail.com>
10293
10294 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10295
4b80f674
CY
102962011-06-04 Chong Yidong <cyd@stupidchicken.com>
10297
10298 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10299 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10300 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10301 New error handlers.
4b80f674
CY
10302 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10303 Obey Vx_select_enable_clipboard_manager. Catch errors in
10304 x_clipboard_manager_save (Bug#8779).
10305 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10306 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10307
99a33b77 103082011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10309
10310 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10311
99a33b77 103122011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10313
10314 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10315 in the current matrix if keep_current_p is non-zero.
10316
8264569d
EZ
103172011-06-04 Eli Zaretskii <eliz@gnu.org>
10318
10319 * bidi.c (bidi_level_of_next_char): Fix last change.
10320
57f97249
EZ
103212011-06-03 Eli Zaretskii <eliz@gnu.org>
10322
fec2107c 10323 Support bidi reordering of text covered by display properties.
57f97249 10324
fec2107c
EZ
10325 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10326 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10327 (bidi_cache_search, bidi_cache_iterator_state)
10328 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10329 (bidi_level_of_next_char, bidi_move_to_visually_next):
10330 Support character positions inside a run of characters covered by a
fec2107c
EZ
10331 display string.
10332 (bidi_paragraph_init, bidi_resolve_explicit_1)
10333 (bidi_level_of_next_char): Call bidi_fetch_char and
10334 bidi_fetch_char_advance instead of FETCH_CHAR and
10335 FETCH_CHAR_ADVANCE.
10336 (bidi_init_it): Initialize new members.
10337 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10338 definitions.
10339 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10340 instead of using explicit *_CHAR codes.
d6d100dd
SM
10341 (bidi_resolve_explicit, bidi_resolve_weak):
10342 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10343 bidirectional text is supported only in multibyte buffers.
10344 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10345 it to initialize the frame_window_p member of struct bidi_it.
10346 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10347 (bidi_resolve_explicit, bidi_resolve_weak)
10348 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10349 bidi_it->nchars is non-positive.
10350 (bidi_level_of_next_char): Don't try to lookup the cache for the
10351 next/previous character if nothing is cached there yet, or if we
10352 were just reseat()'ed to a new position.
c40e2fb2 10353
0e14fe90
EZ
10354 * xdisp.c (set_cursor_from_row): Set start and stop points
10355 according to the row's direction when priming the loop that looks
10356 for the glyph on which to display cursor.
10357 (single_display_spec_intangible_p): Function deleted.
10358 (display_prop_intangible_p): Reimplement to call
10359 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10360 Accept 3 additional arguments needed by handle_display_spec.
10361 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10362 values: lists, `(when COND...)' forms, etc.
10363 (single_display_spec_string_p): Support property values that are
10364 lists with the argument STRING its top-level element.
10365 (display_prop_string_p): Fix the condition for processing a
10366 property that is a list to be consistent with handle_display_spec.
fec2107c 10367 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10368 last portion of handle_display_prop.
10369 (compute_display_string_pos): Accept additional argument
10370 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10371 value of a `display' property is a "replacing spec".
10372 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10373 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10374 the display property, but just return a value indicating whether
10375 the display property will replace the characters it covers.
10376 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10377 frame_window_p members of struct bidi_it.
d6d100dd
SM
10378 (compute_display_string_pos, compute_display_string_end):
10379 New functions.
fec2107c
EZ
10380 (push_it): Accept second argument POSITION, where pop_it should
10381 jump to continue iteration.
10382 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10383
fec2107c
EZ
10384 * keyboard.c (adjust_point_for_property): Adjust the call to
10385 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10386
10387 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10388 (bidi_init_it): Update prototypes.
10389 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10390 (compute_display_string_pos, compute_display_string_end):
10391 Declare prototypes.
fec2107c
EZ
10392 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10393 EMACS_INT.
fc6f18ce 10394
40087514 103952011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10396
57f53182
PE
10397 Malloc failure behavior now depends on size of allocation.
10398 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10399 * lisp.h: Change signatures accordingly.
10400 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10401 All callers changed. (Bug#8762)
10402
10403 * gnutls.c: Use Emacs's memory allocators.
10404 Without this change, the gnutls library would invoke malloc etc.
10405 directly, which causes problems on non-SYNC_INPUT hosts, and which
10406 runs afoul of improving memory_full behavior. (Bug#8761)
10407 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10408 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10409 xfree instead of the default malloc, realloc, free.
10410 (Fgnutls_boot): No need to check for memory allocation failure,
10411 since xmalloc does that for us.
10412
ac32cd99 10413 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10414 * category.c (hash_get_category_set):
10415 * ccl.c (ccl_driver):
10416 * charset.c (Fdefine_charset_internal):
10417 * charset.h (struct charset.hash_index):
10418 * composite.c (get_composition_id, gstring_lookup_cache)
10419 (composition_gstring_put_cache):
10420 * composite.h (struct composition.hash_index):
10421 * dispextern.h (struct image.hash):
10422 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10423 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10424 (hashfn_equal, hashfn_user_defined, make_hash_table)
10425 (maybe_resize_hash_table, hash_lookup, hash_put)
10426 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10427 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10428 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10429 * image.c (make_image, search_image_cache, lookup_image)
10430 (xpm_put_color_table_h):
10431 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10432 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10433 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10434 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10435 * alloc.c (allocate_vectorlike):
10436 Check for overflow in vector size calculations.
10437 * ccl.c (ccl_driver):
10438 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10439 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10440 need to be updated by these changes.
40087514
PE
10441 * fns.c (make_hash_table, maybe_resize_hash_table):
10442 Check for integer overflow with large hash tables.
0de4bb68
PE
10443 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10444 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10445 (SXHASH_REDUCE): New macro.
10446 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10447 Use it instead of discarding useful hash info with large hash values.
10448 (sxhash_float): New function.
10449 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10450 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10451 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10452 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10453 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10454 Adjust signatures to match updated version of code.
10455 (consing_since_gc): Now EMACS_INT, since a single hash table can
10456 use more than INT_MAX bytes.
10457
698d32e2
DN
104582011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10459
10460 Make it possible to build with GCC-4.6+ -O2 -flto.
10461
10462 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10463
fd6fa53f
SM
104642011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10465
10466 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10467 Call minibuffer-inactive-mode.
10468
864db017
JB
104692011-05-31 Juanma Barranquero <lekktu@gmail.com>
10470
10471 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10472 Update dependencies.
10473
2ad0baf4
DN
104742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10475
10476 * data.c (init_data): Remove code for UTS, this system is not
10477 supported anymore.
10478
4fcc2638
DN
104792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10480
10481 Don't force ./temacs to start in terminal mode.
10482
10483 * frame.c (make_initial_frame): Initialize faces in all cases, not
10484 only when CANNOT_DUMP is defined.
10485 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10486
c56e0fd5
DN
104872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10488
10489 * dispnew.c (add_window_display_history): Use const for the string
10490 pointer. Remove declaration, not needed.
10491
333d54da 104922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10493
55d4c1b2 10494 Use 'inline', not 'INLINE'.
333d54da 10495 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10496 * alloc.c, fontset.c (INLINE): Remove.
10497 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10498 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10499 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10500 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10501 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10502
738db178
DN
105032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10504
10505 Make it possible to run ./temacs.
10506
10507 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10508 syms_of_callproc does the same thing. Remove test for
10509 "initialized", do it in the caller.
10510 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10511
620c53a6
SM
105122011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10513
10514 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10515 (read_minibuf): Use get_minibuffer.
10516 (syms_of_minibuf): Use DEFSYM.
10517 (Qmetadata): New var.
10518 * data.c (Qbuffer): Don't make it static.
10519 (syms_of_data): Use DEFSYM.
10520
e003a292
PE
105212011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10522
10523 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10524 (CCL_CODE_MIN): New macro.
10525
ed008a6d
PE
105262011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10527
3687c2ef
PE
10528 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10529
ed008a6d
PE
10530 * eval.c (Qdebug): Now static.
10531 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10532 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10533 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10534
d66c4c7c
CY
105352011-05-29 Chong Yidong <cyd@stupidchicken.com>
10536
10537 * image.c: Various fixes to ImageMagick code comments.
10538 (Fimagemagick_types): Doc fix.
10539
5fbc2025
PE
105402011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10541
0196f88a
PE
10542 Minor fixes prompted by GCC 4.6.0 warnings.
10543
10544 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10545
5fbc2025
PE
10546 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10547 (x_clipboard_manager_save_all): Move extern decl to ...
10548 * xterm.h: ... here, so that it can be checked for consistency.
10549
1dd3c2d9
CY
105502011-05-29 Chong Yidong <cyd@stupidchicken.com>
10551
10552 * xselect.c (x_clipboard_manager_save_frame)
10553 (x_clipboard_manager_save_all): New functions.
10554 (Fx_clipboard_manager_save): Lisp function deleted.
10555
10556 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10557 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10558
10559 * xterm.h: Update prototype.
10560
5ba6571d
WX
105612011-05-28 William Xu <william.xwl@gmail.com>
10562
10563 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10564 exiting (Bug#8239).
10565
3eaff834
JM
105662011-05-28 Jim Meyering <meyering@redhat.com>
10567
e1900994 10568 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10569 * fns.c (to_uchar): Define.
10570 (crypto_hash_function): Use it to convert some newly-signed
10571 variables to unsigned, to avoid sign-extension bugs. For example,
10572 without this change, (md5 "truc") would evaluate to
10573 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10574 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10575 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10576
0f6990a7
PE
105772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10578
10579 Integer overflow fixes.
c8a9ca5a 10580
08686060
PE
10581 * dbusbind.c: Serial number integer overflow fixes.
10582 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10583 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10584 to hold a serial number that is too large for a fixnum.
10585 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10586 Check for serial numbers out of range. Decode any serial number
59568bf0 10587 that was so large that it became a float. (Bug#8722)
08686060 10588
2d1fc3c7
PE
10589 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10590 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10591 Use XFASTINT rather than XUINT when numbers are nonnegative.
10592 (xd_append_arg, Fdbus_method_return_internal):
10593 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10594 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10595 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10596 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10597 (Bug#8722)
2d1fc3c7 10598
c8a9ca5a
PE
10599 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10600
519e1d69
PE
10601 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10602
6df6ae42 10603 ccl: Add integer overflow checks.
30569699
PE
10604 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10605 (IN_INT_RANGE): New macros.
10606 (ccl_driver): Use them to check for integer overflow when
10607 decoding a CCL program. Many of the new checks are whether XINT (x)
10608 fits in int; it doesn't always, on 64-bit hosts. The new version
10609 doesn't catch all possible integer overflows, but it's an
847044ea 10610 improvement. (Bug#8719)
30569699 10611
c11285dc
PE
10612 * alloc.c (make_event_array): Use XINT, not XUINT.
10613 There's no need for unsigned here.
10614
fdccd48e
PE
10615 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10616 This follows up to the 2011-05-06 change that substituted uintptr_t
10617 for EMACS_INT. This case wasn't caught back then.
10618
37910ab2
PE
10619 Rework Fformat to avoid integer overflow issues.
10620 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10621 now (part of C89). Include <verify.h>.
10622 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10623 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10624 (Fformat): Avoid the prepass trying to compute sizes; it was only
10625 approximate and thus did not catch overflow reliably. Instead, walk
10626 through the format just once, formatting and computing sizes as we go,
10627 checking for integer overflow at every step, and allocating a larger
10628 buffer as needed. Keep track separately whether the format is
10629 multibyte. Keep only the most-recently calculated precision, rather
10630 than them all. Record whether each argument has been converted to
10631 string. Use EMACS_INT, not int, for byte and char and arg counts.
10632 Support field widths and precisions larger than INT_MAX. Avoid
10633 sprintf's undefined behavior with conversion specifications such as %#d
10634 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10635 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10636 formatting out-of-range floating point numbers with int
9173deec 10637 formats. (Bug#8668)
37910ab2 10638
2e6578fb
PE
10639 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10640
0ae6bdee
PE
10641 * data.c: Avoid integer truncation in expressions involving floats.
10642 * data.c: Include <intprops.h>.
10643 (arith_driver): When there's an integer overflow in an expression
10644 involving floating point, convert the integers to floating point
10645 so that the resulting value does not suffer from catastrophic
10646 integer truncation. For example, on a 64-bit host (* 4
10647 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10648 Do not rely on undefined behavior after integer overflow.
10649
de883a70
PE
10650 merge count_size_as_multibyte, parse_str_to_multibyte
10651 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10652 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10653 Check for integer overflow.
10654 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10655 since it's now a duplicate of the other. This is more of
10656 a character than a buffer op, so better that it's in character.c.
10657 * fns.c, print.c: Adjust to above changes.
10658
2ff916cb
PE
106592011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10660
10661 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10662
f1b54466
PE
106632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10664
fb1ac845
PE
10665 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10666 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10667 (x_clipboard_manager_save): Now static.
10668 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10669
f1b54466
PE
10670 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10671 (crypto_hash_function): Now static.
10672 Fix pointer signedness problems. Avoid unnecessary initializations.
10673
a9f737ee
CY
106742011-05-27 Chong Yidong <cyd@stupidchicken.com>
10675
10676 * termhooks.h (Vselection_alist): Make it terminal-local.
10677
10678 * terminal.c (create_terminal): Initialize it.
10679
10680 * xselect.c: Support for clipboard managers.
10681 (Vselection_alist): Move to termhooks.h as terminal-local var.
10682 (LOCAL_SELECTION): New macro.
10683 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10684 (symbol_to_x_atom): Remove gratuitous arg.
10685 (x_handle_selection_request, lisp_data_to_selection_data)
10686 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10687 (x_own_selection, x_get_local_selection, x_convert_selection):
10688 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10689 (some_frame_on_display): Delete unused function.
10690 (Fx_own_selection_internal, Fx_get_selection_internal)
10691 (Fx_disown_selection_internal, Fx_selection_owner_p)
10692 (Fx_selection_exists_p): New optional frame arg.
10693 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10694 (x_handle_selection_clear): Don't treat other terminals with the
10695 same keyboard specially. Use the terminal-local Vselection_alist.
10696 (x_clear_frame_selections): Use Frun_hook_with_args.
10697
10698 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10699
10700 * xterm.h: Add support for those atoms.
10701
e067f0c1
CY
107022011-05-26 Chong Yidong <cyd@stupidchicken.com>
10703
10704 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10705 (converted_selections, conversion_fail_tag): New global variables.
10706 (x_selection_request_lisp_error): Free the above.
10707 (x_get_local_selection): Remove unnecessary code.
10708 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10709 of converted selections stored in converted_selections.
10710 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10711 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10712 (x_convert_selection): New function.
10713 (x_handle_selection_event): Simplify.
10714 (x_get_foreign_selection): Don't ignore incoming requests while
10715 waiting for an answer; this will fail when we implement
10716 SAVE_TARGETS, and seems unnecessary anyway.
10717 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10718 (Vx_sent_selection_functions): Doc fix.
10719
0f4aebc0
LL
107202011-05-26 Leo Liu <sdl.web@gmail.com>
10721
10722 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10723
e61124cd
YM
107242011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10725
10726 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10727
10728 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10729 for fringe update if it has periodic bitmap.
ac389d0c 10730 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10731 and fringe_bitmap_periodic_p.
10732
10733 * fringe.c (get_fringe_bitmap_data): New function.
10734 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10735 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10736 row. Mark glyph row for fringe update if periodicity changed.
10737
10738 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10739 for fringe update unless it has periodic bitmap.
10740
f16d9837
KH
107412011-05-25 Kenichi Handa <handa@m17n.org>
10742
10743 * xdisp.c (get_next_display_element): Set correct it->face_id for
10744 a static composition.
10745
e1b90ef6
LL
107462011-05-24 Leo Liu <sdl.web@gmail.com>
10747
10748 * deps.mk (fns.o):
10749 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10750
10751 * fns.c (crypto_hash_function, Fsha1): New function.
10752 (Fmd5): Use crypto_hash_function.
10753 (syms_of_fns): Add Ssha1.
10754
7400048f
PE
107552011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10756
10757 * gnutls.c: Remove unused macros.
10758 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10759 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10760 Remove macros that are defined and never used.
10761 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10762
abb71cf4
CY
107632011-05-22 Chong Yidong <cyd@stupidchicken.com>
10764
10765 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10766 (Fx_get_selection_internal): Minor cleanup.
10767 (Fx_own_selection_internal): Rename arguments for consistency with
10768 select.el.
10769
6307db39
PE
107702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10771
10772 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10773
f3d4e0a4
CY
107742011-05-22 Chong Yidong <cyd@stupidchicken.com>
10775
10776 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10777
4d8ade89
YM
107782011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10779
10780 * dispnew.c (scrolling_window): Don't exclude the case that the
10781 last enabled row in the desired matrix touches the bottom boundary.
10782
32078c8d
GM
107832011-05-21 Glenn Morris <rgm@gnu.org>
10784
10785 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10786 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10787 and add some more files.
32078c8d 10788
7285dc67
EZ
107892011-05-20 Eli Zaretskii <eliz@gnu.org>
10790
10791 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10792 report_file_error introduced by the change from 2011-05-07.
10793
89d1bd22
PE
107942011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10795
10796 * systime.h (Time): Define only if emacs is defined.
10797 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10798 where the include path doesn't have X11/X.h by default. See
10799 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10800
cd394be1 108012011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10802
10803 * composite.c (find_automatic_composition): Fix previous change.
10804
b9704ad9
GM
108052011-05-20 Glenn Morris <rgm@gnu.org>
10806
10807 * lisp.mk: New file, split from Makefile.in.
10808 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10809 (shortlisp): Remove.
10810 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10811
4a720484
GM
108122011-05-19 Glenn Morris <rgm@gnu.org>
10813
10814 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10815 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10816 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10817 (lisp): Set the order to that of loadup.el.
10818 (shortlisp): Make it a copy of $lisp.
10819 (SOME_MACHINE_LISP): Remove.
10820 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10821 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10822
a28d4396
KH
108232011-05-18 Kenichi Handa <handa@m17n.org>
10824
10825 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10826 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10827 (find_automatic_composition): Mostly rewrite for efficiency.
10828
a2b1fa8e
JB
108292011-05-18 Juanma Barranquero <lekktu@gmail.com>
10830
10831 * makefile.w32-in: Update dependencies.
10832
8e1f5610
CS
108332011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10834
10835 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10836 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10837
7025ee00 108382011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10839
cdfa6eab
PE
10840 Fix some integer overflow issues, such as string length overflow.
10841
06d6db33
PE
10842 * insdel.c (count_size_as_multibyte): Check for string overflow.
10843
2b4560a8
PE
10844 * character.c (lisp_string_width): Check for string overflow.
10845 Use EMACS_INT, not int, for string indexes and lengths; in
10846 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10847 the resulting string length overflows an EMACS_INT; instead,
10848 report a string overflow if no precision given. When checking for
10849 precision exhaustion, use a check that cannot possibly have
10850 integer overflow. (Bug#8675)
10851 * character.h (lisp_string_width): Adjust to new signature.
10852
cb93f9be
PE
10853 * alloc.c (string_overflow): New function.
10854 (Fmake_string): Use it. This doesn't change behavior, but saves
10855 a few bytes and will simplify future changes.
10856 * character.c (string_escape_byte8): Likewise.
10857 * lisp.h (string_overflow): New decl.
10858
1a1f3366
PE
10859 Fixups, following up to the user-interface timestamp change.
10860 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10861 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10862 * msdos.c (mouse_get_pos): Likewise.
10863 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10864 * w32gui.h (Time): Define by including "systime.h" rather than by
10865 declaring it ourselves. (Bug#8664)
10866
d4e3e4d3
PE
10867 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10868 * image.c (clear_image_cache): Likewise.
10869
f6a24d19
PE
10870 * term.c (term_mouse_position): Don't assume time_t wraparound.
10871
08dc5ae6
PE
10872 Be more systematic about user-interface timestamps.
10873 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10874 and sometimes 'EMACS_UINT', to represent these timestamps.
10875 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10876 This makes the code easier to follow, and makes it easier to catch
10877 integer overflow bugs such as Bug#8664.
10878 * frame.c (Fmouse_position, Fmouse_pixel_position):
10879 Use Time, not unsigned long, for user-interface timestamps.
10880 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10881 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10882 * keyboard.h (last_event_timestamp): Likewise.
10883 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10884 * menu.h (xmenu_show): Likewise.
10885 * term.c (term_mouse_position): Likewise.
10886 * termhooks.h (struct input_event.timestamp): Likewise.
10887 (struct terminal.mouse_position_hook): Likewise.
10888 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10889 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10890 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10891 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10892 what it was before.
10893 * menu.h, termhooks.h: Include "systime.h", for Time.
10894
8e55734a
PE
10895 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10896 Don't assume that the difference between two unsigned long values
10897 can fit into an integer. At this point, we know button_down_time
10898 <= event->timestamp, so the difference must be nonnegative, so
10899 there's no need to cast the result if double-click-time is
10900 nonnegative, as it should be; check that it's nonnegative, just in
10901 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10902 apart (about 25 days). (Bug#8664)
8e55734a 10903
841f1b75 10904 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10905 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10906
3e26f69c
PE
10907 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10908 that always fit in int. Use a sentinel instead of a counter, to
10909 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10910 * frame.h (struct frame): Use int for menu_bar_items_used
10911 instead of EMACS_INT, since it always fits in int.
3e26f69c 10912
5cc152c0
PE
10913 * menu.c (grow_menu_items): Check for int overflow.
10914
d89eb65e
PE
10915 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10916
5235bd3e
PE
10917 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10918 Before, the code was not consistent. These values cannot exceed
10919 2**31 - 1 so there's no need to make them unsigned.
10920 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10921 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10922 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10923 as modifiers.
10924 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10925
bc827e23
PE
10926 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10927 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10928 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10929 presumably because the widths might not match.
10930
78eb494e
PE
10931 * window.c (size_window): Avoid needless test at loop start.
10932
04f2d78b
CB
109332011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10934
10935 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10936
d2fc7e3d 109372011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10938
10939 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10940
d2fc7e3d 109412011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10942
10943 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10944 `width' to `bar_area_x' and `bar_area_width', respectively.
10945 (x_scroll_run): Take account of fringe background extension.
10946
04f2d78b
CB
10947 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10948 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10949 `bar_area_width', respectively.
10950 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10951 background extension.
10952
79b70037
GM
109532011-05-10 Jim Meyering <meyering@redhat.com>
10954
10955 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10956
2f142cc5
JB
109572011-05-10 Juanma Barranquero <lekktu@gmail.com>
10958
10959 * image.c (Finit_image_library): Return t for built-in image types,
10960 like pbm and xbm. (Bug#8640)
10961
57679c86
AS
109622011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10963
10964 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10965
888c9e86
EZ
109662011-05-07 Eli Zaretskii <eliz@gnu.org>
10967
b0512a1d
EZ
10968 * w32console.c (Fset_screen_color): Doc fix.
10969 (Fget_screen_color): New function.
10970 (syms_of_ntterm): Defsubr it.
10971
7285dc67
EZ
10972 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10973 unlink the temporary file if Fcall_process didn't create it in the
10974 first place.
10975 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10976 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10977 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10978 cue to call_process_cleanup not to close that handle.
10979
4d3fcc8e
BK
109802011-05-07 Ben Key <bkey76@gmail.com>
10981
10982 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10983 one of two shell specific rules, either bootstrap-temacs-CMD or
10984 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10985 to the previous implementation of the bootstrap-temacs rule.
10986 The bootstrap-temacs-CMD rule is similar to the previous
10987 implementation of the bootstrap-temacs rule except that it
10988 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10989 variable.
10990
10991 These changes, along with some changes to nt/configure.bat,
10992 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10993 earlier fix to add support for --cflags and --ldflags options
10994 that include quotes so that it works whether make uses cmd or
10995 sh as the shell.
10996
b4289b64
MA
109972011-05-06 Michael Albinus <michael.albinus@gmx.de>
10998
10999 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11000 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11001 is a constant.
11002 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11003 a string. Handle both cases.
11004 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11005 (Fdbus_register_method): Use Qinvalid_function.
11006
af4c0e28
JB
110072011-05-06 Juanma Barranquero <lekktu@gmail.com>
11008
11009 * makefile.w32-in: Update dependencies.
11010 (LISP_H): Add inttypes.h and stdin.h.
11011 (PROCESS_H): Add unistd.h.
11012
c51453d9
EZ
110132011-05-06 Eli Zaretskii <eliz@gnu.org>
11014
11015 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11016 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11017
8ff0ac3c 110182011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11019
4c4b566b
PE
11020 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11021
aab2b9b5
PE
11022 * term.c (vfatal): Remove stray call to va_end.
11023 It's not needed and the C Standard doesn't allow it here anyway.
11024
c378da0b
PE
11025 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11026 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11027
288b08c7
PE
11028 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11029 bytes.
11030
e3601888
PE
11031 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11032
db6c0e74
PE
11033 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11034
dd5963ea
PE
11035 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11036
88c9450f
PE
11037 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11038
2f9442b8
PE
11039 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11040
c032b5f8
PE
11041 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11042 * charset.c (Fdefine_charset_internal): Don't initialize
11043 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11044 32-bit int (Bug#8600).
a108c10b
PE
11045
11046 * lread.c (read_integer): Be more consistent with string-to-number.
11047 Use string_to_number to do the actual conversion; this avoids
11048 rounding errors and fixes some other screwups. Without this fix,
11049 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11050 (digit_to_number): Move earlier, for benefit of read_integer.
11051 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11052 not a digit in any supported base. (Bug#8602)
a108c10b 11053
ad5f9eea
PE
11054 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11055
aec1708a
PE
11056 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11057 to match comment at start of function. This also removes a
11058 GCC warning about overflow in a 32+64-bit port.
11059
47be4ab5
PE
11060 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11061
371cac43
PE
11062 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11063 Reported by Stefan Monnier in
11064 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11065 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11066 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11067
d01a7826
PE
11068 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11069 (EMACS_UINTPTR): Likewise, with uintptr_t.
11070
7fd47d5c
PE
11071 * lisp.h: Prefer 64-bit EMACS_INT if available.
11072 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11073 on 32-bit hosts that have 64-bit int, so that they can access
11074 large files.
122b0c86
PE
11075 However, temporarily disable this change unless the temporary
11076 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11077
8727937b
PE
11078 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11079
8ac068ac
PE
11080 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11081 This removes an assumption that EMACS_INT and long are the same
11082 width as pointers. The assumption is true for Emacs porting targets
11083 now, but we want to make other targets possible.
11084 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11085 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11086 In the rest of the code, change types of integers that hold casted
11087 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11088 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11089 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11090 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11091 No need to cast type when ORing.
11092 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11093 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11094 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11095 assume EMACS_INT is the same width as char *.
11096 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11097 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11098 Remove no-longer-needed casts.
11099 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11100 (xg_tool_bar_help_callback, xg_make_tool_item):
11101 Use EMACS_INTPTR to hold an integer
11102 that will be cast to void *; this can avoid a GCC warning
11103 if EMACS_INT is not the same width as void *.
11104 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11105 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11106 (current_message_1, set_message_1):
11107 Use a local to convert to proper width without a cast.
11108 * xmenu.c (dialog_selection_callback): Likewise.
11109
ede49d71
PE
11110 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11111 Also, don't assume VALBITS / RAND_BITS is less than 5,
11112 and don't rely on undefined behavior when shifting a 1 left into
11113 the sign bit.
11114 * lisp.h (get_random): Change signature to match.
11115
2f30ecd0
PE
11116 * lread.c (hash_string): Use size_t, not int, for hash computation.
11117 Normally we prefer signed values; but hashing is special, because
11118 it's better to use unsigned division on hash table sizes so that
11119 the remainder is nonnegative. Also, size_t is the natural width
11120 for hashing into memory. The previous code used 'int', which doesn't
11121 retain enough info to hash well into very large tables.
11122 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11123
2a866e7b
PE
11124 * dbusbind.c: Don't possibly lose pointer info when converting.
11125 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11126 Use XPNTR rather than XHASH, so that the high-order bits of
11127 the pointer aren't lost when converting through void *.
11128
51639eac
PE
11129 * eval.c (Fautoload): Don't double-shift a pointer.
11130
92394119
PE
11131 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11132
dbdb9a7c
JB
111332011-05-06 Juanma Barranquero <lekktu@gmail.com>
11134
11135 * gnutls.c (DEF_GNUTLS_FN):
11136 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11137
db7a0b4f
AS
111382011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11139
11140 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11141 marker. (Bug#8610)
11142
cd394be1 111432011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11144
11145 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11146 New version that can reserve upto 2GB of heap space.
11147
f7ff1b0f 111482011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11149
11150 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11151
639c109b
TZ
111522011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11153
11154 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11155 `gnutls_certificate_set_x509_key_file'.
11156
d2127135
JB
111572011-05-05 Juanma Barranquero <lekktu@gmail.com>
11158
11159 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11160 Update dependencies.
11161
e968f4f3
JB
111622011-05-04 Juanma Barranquero <lekktu@gmail.com>
11163
11164 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11165 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11166 Remove unused parameter `fildes'.
11167 * process.c (read_process_output, send_process): Don't pass it.
11168
84d358f0
JB
111692011-05-04 Juanma Barranquero <lekktu@gmail.com>
11170
11171 Fix previous change: the library cache is defined in w32.c.
11172 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11173 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11174
0898ca10
JB
111752011-05-04 Juanma Barranquero <lekktu@gmail.com>
11176
11177 Implement dynamic loading of GnuTLS on Windows.
11178
11179 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11180 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11181 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11182 Declare.
11183
11184 * gnutls.c (Qgnutls_dll): Define.
11185 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11186 (gnutls_*): Declare function pointers.
11187 (init_gnutls_functions): New function to initialize function pointers.
11188 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11189 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11190 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11191 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11192 (emacs_gnutls_write, emacs_gnutls_read)
11193 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11194 (Fgnutls_available_p): New function.
11195 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11196 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11197 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11198
11199 * image.c: Include w32.h.
11200 (Vimage_type_cache): Delete.
11201 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11202 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11203 (w32_delayed_load): Move to w32.c.
11204
11205 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11206
11207 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11208 (w32_delayed_load): Move from image.c. When loading a library, record
11209 its filename in the :loaded-from property of the library id.
11210 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11211 Initialize and staticpro them.
11212 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11213
11214 * process.c: Include lisp.h before w32.h, not after.
11215 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11216 instead of gnutls_record_check_pending.
11217
11218 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11219
ff4de4aa
TZ
112202011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11221
11222 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11223 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11224 as passed in.
11225
abe95abb
JD
112262011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11227
11228 * xterm.c (x_set_frame_alpha): Do not set property on anything
11229 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11230
e16e55d4
JB
112312011-05-02 Juanma Barranquero <lekktu@gmail.com>
11232
11233 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11234
bafcf6a5
JB
112352011-05-02 Juanma Barranquero <lekktu@gmail.com>
11236
11237 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11238 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11239 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11240 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11241 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11242 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11243 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11244 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11245 (Qgnutls_bootprop_callbacks_verify): Make static.
11246
e7a6747f
AS
112472011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11248
19ed11ba
AS
11249 * callproc.c: Indentation fixup.
11250
e7a6747f 11251 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11252 (wait_for_termination, interruptible_wait_for_termination):
11253 Move after wait_for_termination_1.
e7a6747f 11254
1ef14cb4
LMI
112552011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11256
11257 * sysdep.c (interruptible_wait_for_termination): New function
11258 which is like wait_for_termination, but allows keyboard
11259 interruptions.
11260
11261 * callproc.c (Fcall_process): Add (:file "file") as an option for
11262 the STDOUT buffer.
11263 (Fcall_process_region): Ditto.
11264
330d880c
EZ
112652011-04-30 Eli Zaretskii <eliz@gnu.org>
11266
8db90b73
EZ
11267 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11268 rather than `XVECTOR (FOO)->size'.
11269
330d880c
EZ
11270 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11271 inttypes.h, as a gnulib replacement is used if it not available in
11272 system headers.
11273
15cbd324
EZ
112742011-04-21 Eli Zaretskii <eliz@gnu.org>
11275
11276 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11277 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11278 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11279
11280 * coding.c (coding_alloc_by_realloc): Error out if destination
11281 will grow beyond MOST_POSITIVE_FIXNUM.
11282 (decode_coding_emacs_mule): Abort if there isn't enough place in
11283 charbuf for the composition carryover bytes. Reserve an extra
11284 space for up to 2 characters produced in a loop.
11285 (decode_coding_iso_2022): Abort if there isn't enough place in
11286 charbuf for the composition carryover bytes.
11287
112882011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11289
ae940cca
EZ
11290 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11291 aborting when %lld or %lll format is passed.
11292 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11293 %llo or %llx format is passed. (Bug#8545)
11294
03ab8921
EZ
11295 * window.c (window_scroll_line_based): Use a marker instead of
11296 simple variables to record original value of point. (Bug#7952)
11297
afda1437
EZ
11298 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11299 produced by %s or %c overflows available buffer space. (Bug#8545)
11300
f76dee0c
PE
113012011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11302
11303 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11304 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11305
fdc5744d
JB
113062011-04-28 Juanma Barranquero <lekktu@gmail.com>
11307
11308 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11309
638f053a
JB
113102011-04-28 Juanma Barranquero <lekktu@gmail.com>
11311
11312 * keyboard.c (Qdelayed_warnings_hook): Define.
11313 (command_loop_1): Run `delayed-warnings-hook'
11314 if Vdelayed_warnings_list is non-nil.
11315 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11316 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11317
d178f871
EZ
113182011-04-28 Eli Zaretskii <eliz@gnu.org>
11319
11320 * doprnt.c (doprnt): Don't return value smaller than the buffer
11321 size if the message was truncated. (Bug#8545).
11322
b124fd93
JB
113232011-04-28 Juanma Barranquero <lekktu@gmail.com>
11324
11325 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11326 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11327
e810457d
PE
113282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11329
11330 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11331
ea51cceb
JB
113322011-04-27 Juanma Barranquero <lekktu@gmail.com>
11333
11334 * makefile.w32-in: Update dependencies.
11335
94dcfacf
EZ
113362011-04-27 Eli Zaretskii <eliz@gnu.org>
11337
11338 Improve `doprnt' and its usage. (Bug#8545)
11339 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11340 `format_end'. Remove support for %l as a conversion specifier.
11341 Don't use xrealloc. Improve diagnostics when the %l size modifier
11342 is used. Update the commentary.
11343
11344 * eval.c (verror): Simplify calculation of size_t.
11345
11346 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11347 messages.
11348
f61f41d7
PE
113492011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11350
11351 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11352 change.
11353
96fb4434
PE
113542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11355
11356 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11357 This makes this file independent of the recent pseudovector change.
11358
671875da 113592011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11360
69e9b5a3
PE
11361 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11362
b5f869a7 11363 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11364 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11365 Remove unused local.
c8926152 11366 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11367
841a1577 11368 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11369 GCC 4.6.0 optimizes based on type-based alias analysis.
11370 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11371 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11372 != &v->size, and therefore "v->size = 1; b->size = 2; return
11373 v->size;" must therefore return 1. This assumption is incorrect
11374 for Emacs, since it type-puns struct Lisp_Vector * with many other
11375 types. To fix this problem, this patch adds a new type struct
f904488f 11376 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11377 and pseudovectors, and helps optimizing compilers not get fooled
11378 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11379 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11380 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11381 the size member.
eab3844f
PE
11382 (XSETPVECTYPE): Rewrite in terms of new macro.
11383 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11384 This is a bit clearer, and further avoids the possibility of
11385 undesirable aliasing.
11386 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11387 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11388 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11389 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11390 (ASIZE): Now uses header.size rather than size.
11391 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11392 to avoid the hassle of writing XVECTOR (foo)->header.size.
11393 (struct vectorlike_header): New type.
eab3844f
PE
11394 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11395 object, to help avoid aliasing.
11396 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11397 (SUBRP): Likewise, since Lisp_Subr is a special case.
11398 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11399 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11400 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11401 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11402 changed to be "header.size" and "header.next".
11403 * buffer.h (struct buffer): Likewise.
11404 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11405 * frame.h (struct frame): Likewise.
11406 * process.h (struct Lisp_Process): Likewise.
11407 * termhooks.h (struct terminal): Likewise.
11408 * window.c (struct save_window_data, struct saved_window): Likewise.
11409 * window.h (struct window): Likewise.
11410 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11411 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11412 * buffer.c (init_buffer_once): Likewise.
11413 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11414 special case.
11415 * process.c (Fformat_network_address): Use local var for size,
11416 for brevity.
11417
0df1eac5
PE
11418 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11419
847ab9d1 11420 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11421 * data.c (atof): Remove decl; no longer used or needed.
11422 (digit_to_number): Move to lread.c.
11423 (Fstring_to_number): Use new string_to_number function, to be
11424 consistent with how the Lisp reader treats infinities and NaNs.
11425 Do not assume that floating-point numbers represent EMACS_INT
11426 without losing information; this is not true on most 64-bit hosts.
11427 Avoid double-rounding errors, by insisting on integers when
11428 parsing non-base-10 numbers, as the documentation specifies.
11429 * lisp.h (string_to_number): New decl, replacing ...
11430 (isfloat_string): Remove.
bc0a5c13 11431 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11432 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11433 appears to have been a coding error. Similarly, do not accept
11434 strings like +-1e0 as floating point numbers. Do not report
11435 overflow for integer overflows unless the base is not 10 which
11436 means we have no simple and reliable way to continue.
11437 Break out the floating-point parsing into a new
11438 function string_to_number, so that Fstring_to_number parses
11439 floating point numbers consistently with the Lisp reader.
04f2d78b 11440 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11441 (E_CHAR, EXP_INT): Remove, replacing with ...
11442 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11443 (string_to_number): New function, replacing isfloat_string.
11444 This function checks for valid syntax and produces the resulting
11445 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11446 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11447 so that overflow for non-base-10 numbers is reported only when
11448 there's no portable and simple way to convert to floating point.
452f4150 11449
67769ffc
PE
11450 * textprop.c (set_text_properties_1): Rewrite for clarity,
11451 and to avoid GCC warning about integer overflow.
11452
c20db43f
PE
11453 * intervals.h (struct interval): Use EMACS_INT for members
11454 where EMACS_UINT might cause problems. See
11455 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11456 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11457 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11458 All uses changed.
37aa2f85
PE
11459 (offset_intervals): Tell GCC not to worry about length overflow
11460 when negating a negative length.
c20db43f 11461
2538aa2f
PE
11462 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11463 (overrun_check_free): Likewise.
11464
f2d3008d
PE
11465 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11466 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11467 word size.
11468
ec8df744
PE
11469 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11470 (gnutls_make_error): Rename local to avoid shadowing.
11471 (gnutls_emacs_global_deinit): ifdef out; not used.
11472 (Fgnutls_boot): Use const for pointer to readonly storage.
11473 Comment out unused local. Fix pointer signedness problems.
11474
640ee02d
PE
11475 * lread.c (openp): Don't stuff size_t into an 'int'.
11476 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11477 about possible signed overflow.
11478
6048fb2a
PE
11479 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11480 (GDK_KEY_g): Don't define if already defined.
11481 (xg_prepare_tooltip): Avoid pointer signedness problem.
11482 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11483
fa3c87e1
PE
11484 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11485 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11486
2172544b
PE
11487 * xfns.c (Fx_window_property): Simplify a bit,
11488 to make a bit faster and to avoid GCC 4.6.0 warning.
11489 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11490
9b821a21
PE
11491 * fns.c (internal_equal): Don't assume size_t fits in int.
11492
3c616cfa
PE
11493 * alloc.c (compact_small_strings): Tighten assertion a little.
11494
c2982e87
PE
11495 Replace pEd with more-general pI, and fix some printf arg casts.
11496 * lisp.h (pI): New macro, generalizing old pEd macro to other
11497 conversion specifiers. For example, use "...%"pI"d..." rather
11498 than "...%"pEd"...".
11499 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11500 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11501 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11502 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11503 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11504 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11505 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11506 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11507 64-bit hosts.
11508 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11509 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11510 * print.c (safe_debug_print, print_object): Likewise.
11511 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11512 to int.
6f04d126
PE
11513 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11514 avoiding the 0 flag, which is not portable.
c2982e87
PE
11515 * process.c (Fmake_network_process): Use pI to avoid cast.
11516 * region-cache.c (pp_cache): Likewise.
11517 * xdisp.c (decode_mode_spec): Likewise.
11518 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11519 behavior on 64-bit hosts with printf arg.
6f04d126 11520 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11521 (x_stop_queuing_selection_requests): Likewise.
11522 (x_get_window_property): Don't truncate byte count to an 'int'
11523 when tracing.
0b432f21 11524
5e073ec7
PE
11525 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11526 here, since it parses constructs like leading '-' and spaces,
11527 which are not wanted; and it overflows with large numbers.
11528 Instead, simply match F[0-9]+, which is what is wanted anyway.
11529
36372bf9
PE
11530 * alloc.c: Remove unportable assumptions about struct layout.
11531 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11532 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11533 (allocate_vectorlike, make_pure_vector): Use the new macros,
11534 plus offsetof, to remove unportable assumptions about struct layout.
11535 These assumptions hold on all porting targets that I know of, but
11536 they are not guaranteed, they're easy to remove, and removing them
11537 makes further changes easier.
11538
0b432f21
PE
11539 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11540 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11541 (string_overrun_cookie): Now const. Use initializers that
11542 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11543 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11544 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11545 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11546 multiple of sizeof (EMACS_INT); it need not be, if
11547 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11548 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11549
895009e1
JB
115502011-04-26 Juanma Barranquero <lekktu@gmail.com>
11551
11552 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11553
6a7a1b0b
TZ
115542011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11555
11556 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11557 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11558 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11559
841a1577 115602011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11561
11562 * lisp.h (Qdebug): List symbol.
895009e1 11563 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11564 * keyboard.c (debug-on-event): New variable.
11565 (handle_user_signal): Break into debugger when debug-on-event
11566 matches the current signal symbol.
11567
f2d3ba6f
DN
115682011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11569
11570 * alloc.c (check_sblock, check_string_bytes)
11571 (check_string_free_list): Convert to standard C.
11572
42ce4c63
TZ
115732011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11574
11575 * w32.c (emacs_gnutls_push): Fix typo.
11576
825cd63c
EZ
115772011-04-25 Eli Zaretskii <eliz@gnu.org>
11578
fb11d64d
EZ
11579 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11580 "cast to pointer from integer of different size".
11581
825cd63c
EZ
11582 Improve doprnt and its use in verror. (Bug#8545)
11583 * doprnt.c (doprnt): Document the set of format control sequences
11584 supported by the function. Use SAFE_ALLOCA instead of always
11585 using `alloca'.
11586
11587 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11588 is one byte too soon. Don't use xrealloc; instead xfree and
11589 xmalloc anew.
11590
e061a11b
TZ
115912011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11592
11593 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11594 callbacks stage.
11595
11596 * gnutls.c: Renamed global_initialized to
11597 gnutls_global_initialized. Added internals for the
11598 :verify-hostname-error, :verify-error, and :verify-flags
11599 parameters of `gnutls-boot' and documented those parameters in the
11600 docstring. Start callback support.
9173deec
JB
11601 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11602 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11603 on error. Return error code.
e061a11b
TZ
11604 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11605 (emacs_gnutls_read): Likewise.
11606 (Fgnutls_boot): Return handshake error code.
11607 (emacs_gnutls_handle_error): New function.
11608 (wsaerror_to_errno): Likewise.
11609
11610 * w32.h (emacs_gnutls_pull): Add prototype.
11611 (emacs_gnutls_push): Likewise.
11612
11613 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11614 (emacs_gnutls_push): Likewise.
11615
116162011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11617
11618 * process.c (wait_reading_process_output): Check if GnuTLS
11619 buffered some data internally if no FDs are set for TLS
11620 connections.
11621
11622 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11623 (LIBS): Link to USER_LIBS.
11624 ($(BLD)/gnutls.$(0)): New target.
11625
fa6996bc
EZ
116262011-04-24 Eli Zaretskii <eliz@gnu.org>
11627
eb35682e
EZ
11628 * xdisp.c (handle_single_display_spec): Rename the
11629 display_replaced_before_p argument into display_replaced_p, to
11630 make it consistent with the commentary. Fix typos in the
11631 commentary.
11632
e2ad650c
EZ
11633 * textprop.c (syms_of_textprop): Remove dead code.
11634 (copy_text_properties): Delete obsolete commentary about an
11635 interface that was deleted long ago. Fix typos in the description
11636 of arguments.
11637
1b2de274
EZ
11638 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11639 to changes in oldXMenu/XMenu.h from 2011-04-16.
11640 <menu_help_message, prev_menu_help_message>: Constify.
11641 (IT_menu_make_room): menu->help_text is now `const char **';
11642 adjust.
11643
11644 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11645 to changes in oldXMenu/XMenu.h from 2011-04-16.
11646 (struct XMenu): Declare `help_text' `const char **'.
11647
11648 * xfaces.c <Qunspecified>: Make extern again.
11649
11650 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11651 required by POSIX.
1b2de274 11652
762b15be
EZ
11653 * doc.c (get_doc_string): Improve the format passed to `error'.
11654
11655 * doprnt.c (doprnt): Improve commentary.
11656
11657 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11658
11659 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11660 them with etags.
11661
f1052e5d
EZ
11662 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11663 changes in globals.h immediately force recompilation.
762b15be
EZ
11664 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11665 $(CURDIR)/s/ms-w32.h.
11666 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11667
fa6996bc
EZ
11668 * character.c (Fchar_direction): Function deleted.
11669 (syms_of_character): Don't defsubr it.
11670 <char-direction-table>: Deleted.
11671
e6c3da20
EZ
116722011-04-23 Eli Zaretskii <eliz@gnu.org>
11673
11674 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11675 * doprnt.c: Include limits.h.
11676 (SIZE_MAX): New macro.
04f2d78b
CB
11677 (doprnt): Return a size_t value. 2nd arg is now size_t.
11678 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11679 Improve overflow protection. Support `l' modifier for integer
11680 conversions. Support %l conversion. Don't assume an EMACS_INT
11681 argument for integer conversions and for %c.
11682
11683 * lisp.h (doprnt): Restore prototype.
11684
11685 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11686 $(SRC)/character.h.
11687
11688 * Makefile.in (base_obj): Add back doprnt.o.
11689
11690 * deps.mk (doprnt.o): Add back prerequisites.
11691 (callint.o): Depend on character.h.
11692
11693 * eval.c (internal_lisp_condition_case): Include the handler
11694 representation in the error message.
11695 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11696 when breaking from the loop.
11697
11698 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11699
11700 * callint.c (Fcall_interactively): When displaying error message
11701 about invalid control letter, pass the character's codepoint, not
11702 a pointer to its multibyte form. Improve display of the character
11703 in octal and display also its hex code.
11704
11705 * character.c (char_string): Use %x to display the (unsigned)
11706 codepoint of an invalid character, to avoid displaying a bogus
11707 negative value.
11708
11709 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11710 `error', not SYMBOL_NAME itself.
11711
11712 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11713 character arguments to `error'.
11714
11715 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11716 to `error' in error message about FINAL_CHAR argument. Make sure
11717 FINAL_CHAR is a character, and use %c when it is passed as
11718 argument to `error'.
11719
4ffd0d6b 117202011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11721
11722 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11723
11724 * w32.c: Include <time.h>.
11725 (sys_localtime): New function.
11726
4ffd0d6b 117272011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11728
11729 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11730
4ffd0d6b 11731 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11732
4ffd0d6b 117332011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11734
4ffd0d6b
GM
11735 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11736 zombies (Bug#8467).
aac0c6e3 11737
04c56954
EZ
117382011-04-19 Eli Zaretskii <eliz@gnu.org>
11739
11740 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11741 gl_state.e_property when gl_state.object is Qt.
11742
11743 * insdel.c (make_gap_larger): Remove limitation of buffer size
11744 to <= INT_MAX.
11745
16a43933
CY
117462011-04-18 Chong Yidong <cyd@stupidchicken.com>
11747
11748 * xdisp.c (lookup_glyphless_char_display)
11749 (produce_glyphless_glyph): Handle cons cell entry in
11750 glyphless-char-display.
11751 (Vglyphless_char_display): Document it.
11752
11753 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11754 glyphless-char-display.
11755
4581706e
CY
117562011-04-17 Chong Yidong <cyd@stupidchicken.com>
11757
11758 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11759
11760 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11761
11762 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11763 definition for no-X builds.
11764
4887c6e2 117652011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11766
fd35b6f9
PE
11767 Static checks with GCC 4.6.0 and non-default toolkits.
11768
5c1ccb01
PE
11769 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11770
006c5daa
PE
11771 * process.c (keyboard_bit_set): Define only if SIGIO.
11772 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11773 (send_process): Repair possible setjmp clobbering.
11774
efc736d3
PE
11775 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11776
4e2fe2e6
PE
11777 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11778
f97334a2
PE
11779 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11780
4e75f29d
PE
11781 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11782 Define only if needed.
11783
90efadd1
PE
11784 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11785 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11786 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11787
3c647824
PE
11788 * dispextern.h (struct redisplay_interface): Rename param
11789 to avoid shadowing.
e264f262 11790 * termhooks.h (struct terminal): Likewise.
761383f4 11791 * xterm.c (xembed_send_message): Likewise.
3c647824 11792
b58c5c4a
PE
11793 * insdel.c (make_gap_smaller): Define only if
11794 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11795
cad59032
PE
11796 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11797 it.
11798
c339dc2e
PE
11799 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11800 so that we aren't warned about unused symbols.
11801
91a3e27b
PE
11802 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11803
399c71d3 11804 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11805
8ffc96f5
PE
11806 * xfns.c (x_real_positions): Mark locals as initialized.
11807
eef9bc79
PE
11808 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11809
098db9dd
PE
11810 * xterm.c: Fix problems found by static analysis with other toolkits.
11811 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11812 (x_dispatch_event): Declare static if USE_GTK, and
11813 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11814 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11815 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11816 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11817 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11818
eb18f6cc
PE
11819 * xmenu.c (menu_help_callback): Pointer type fixes.
11820 Use const pointers when pointing at readonly data. Avoid pointer
11821 signedness clashes.
11822 (FALSE): Remove unused macro.
11823 (update_frame_menubar): Remove unused decl.
11824
1fe72bf8
PE
11825 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11826
60d9e1db
PE
11827 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11828 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11829 (single_menu_item): Rename local to avoid shadowing.
11830
39261c26
PE
11831 * keyboard.c (make_lispy_event): Remove unused local var.
11832
018c5e19
PE
11833 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11834 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11835
63d2b86e
PE
11836 * bitmaps: Change bitmaps from unsigned char back to the X11
11837 compatible char. Avoid the old compiler warnings about
11838 out-of-range initializers by using, for example, '\xab' rather
11839 than 0xab.
11840
aefd87e1
PE
11841 * xgselect.c (xgselect_initialize): Check vs interface
11842 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11843
bf501fb9
PE
11844 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11845
e9829fdf
PE
11846 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11847 to read-only memory.
11848
1086c095
PE
11849 * fns.c (vector): Remove; this old hack is no longer needed.
11850
2baccd04 11851 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11852 Remove unused var.
dde42981 11853 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11854
72391843 11855 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11856
436c16df 11857 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11858 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11859 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11860
92bb796d 11861 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11862 (x_term_init): Remove local to avoid shadowing.
92bb796d 11863
764430a3 11864 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11865
11866 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11867 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11868
d1dfb56c
EZ
118692011-04-16 Eli Zaretskii <eliz@gnu.org>
11870
c4354cb4
EZ
11871 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11872
d1dfb56c
EZ
11873 Fix regex.c, syntax.c and friends for buffers > 2GB.
11874 * syntax.h (struct gl_state_s): Declare character position members
11875 EMACS_INT.
11876
11877 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11878
04f2d78b
CB
11879 * textprop.c (verify_interval_modification, interval_of):
11880 Declare arguments EMACS_INT.
d1dfb56c
EZ
11881
11882 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11883 EMACS_INT.
11884
11885 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11886
11887 * indent.c (Fvertical_motion): Local variable it_start is now
11888 EMACS_INT.
11889
11890 * regex.c (re_match, re_match_2, re_match_2_internal)
11891 (bcmp_translate, regcomp, regexec, print_double_string)
11892 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11893 (re_compile_pattern, re_exec): Declare arguments and local
11894 variables `size_t' and `ssize_t' and return values `regoff_t', as
11895 appropriate.
11896 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11897 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11898 <compile_stack_type>: `size' and `avail' are now `size_t'.
11899
11900 * regex.h <regoff_t>: Use ssize_t, not int.
11901 (re_search, re_search_2, re_match, re_match_2): Arguments that
11902 specify buffer/string position and length are now ssize_t and
11903 size_t. Return type is regoff_t.
11904
613052cd
BK
119052011-04-16 Ben Key <bkey76@gmail.com>
11906
11907 * nsfont.m: Fixed bugs in ns_get_family and
11908 ns_descriptor_to_entity that were caused by using free to
11909 deallocate memory blocks that were allocated by xmalloc (via
11910 xstrdup). This caused Emacs to crash when compiled with
11911 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11912 --enable-checking=xmallocoverrun). xfree is now used to
11913 deallocate these memory blocks.
11914
4170f62f 119152011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11916
71b41406
PE
11917 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11918
9587a89d
PE
11919 emacs_write: Accept and return EMACS_INT for sizes.
11920 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11921 et seq.
11922 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11923 Accept and return EMACS_INT.
11924 (emacs_gnutls_write): Return the number of bytes written on
11925 partial writes.
11926 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11927 (emacs_read, emacs_write): Remove check for negative size, as the
11928 Emacs source code has been audited now.
9587a89d
PE
11929 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11930 (emacs_read, emacs_write): Use it.
273a5f82
PE
11931 * process.c (send_process): Adjust to the new signatures of
11932 emacs_write and emacs_gnutls_write. Do not attempt to store
11933 a byte offset into an 'int'; it might overflow.
9587a89d 11934 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11935
3e047f51
PE
11936 * sound.c: Don't assume sizes fit in 'int'.
11937 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11938 Return EMACS_INT, not int.
3e047f51 11939 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11940 Accept EMACS_INT, not int.
11941 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11942 record read return values.
11943
cc39a9db
BK
119442011-04-15 Ben Key <bkey76@gmail.com>
11945
c9d0ec6d
JB
11946 * keyboard.c (Qundefined): Don't declare static since it is used
11947 in nsfns.m.
11948 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11949 static since they are used in nsfont.m.
cc39a9db 11950
6c60eb9f
SM
119512011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11952
11953 * process.c (Qprocessp): Don't declare static.
11954 * lisp.h (Qprocessp): Declare again.
11955
7990b61a
JB
119562011-04-15 Juanma Barranquero <lekktu@gmail.com>
11957
11958 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11959
5d4cb038
PE
119602011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11961
8bd7b830 11962 Improve C-level modularity by making more things 'static'.
cd64ea1d 11963
e3b27b31
PE
11964 Don't publish debugger-only interfaces to other modules.
11965 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11966 (verify_bytepos, count_markers): Move decls to the only modules
11967 that need them.
11968 * region-cache.h (pp_cache): Likewise.
11969 * window.h (check_all_windows): Likewise.
11970 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11971
5d4cb038
PE
11972 * sysdep.c (croak): Now static, if
11973 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11974 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11975
11976 * alloc.c (refill_memory_reserve): Now static if
11977 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11978 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11979
e87b6180
PE
11980 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11981 Define only if USE_LUCID.
11982
ac64929e
PE
11983 * xrdb.c (x_customization_string, x_rm_string): Now static.
11984
6f37259d
PE
11985 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11986 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11987
1683e3ab
PE
11988 * xdisp.c (draw_row_with_mouse_face): Now static.
11989 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11990
de9c2632
PE
11991 * window.h (check_all_windows): Mark externally visible.
11992
2b96acb7
PE
11993 * window.c (window_deletion_count): Now static.
11994
11995 * undo.c: Make symbols static if they're not exported.
11996 (last_undo_buffer, last_boundary_position, pending_boundary):
11997 Now static.
11998
50436f33
PE
11999 * textprop.c (interval_insert_behind_hooks): Now static.
12000 (interval_insert_in_front_hooks): Likewise.
12001
64520e5c
PE
12002 * term.c: Make symbols static if they're not exported.
12003 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12004 (max_frame_lines, tty_set_terminal_modes):
12005 (tty_reset_terminal_modes, tty_turn_off_highlight):
12006 (get_tty_terminal): Now static.
12007 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12008 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12009 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12010 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12011 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12012
1fa53021
PE
12013 * sysdep.c: Make symbols static if they're not exported.
12014 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12015 Now static.
12016 (sigprocmask_set, full_mask): Remove; unused.
12017 (wait_debugging): Mark as visible.
12018 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12019 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12020
d4b43b22
PE
12021 * syntax.c (syntax_temp): Define only if !__GNUC__.
12022
b7c513d0
PE
12023 * sound.c (current_sound_device, current_sound): Now static.
12024
989b29ad
PE
12025 * search.c (searchbufs, searchbuf_head): Now static.
12026
13a55a78
PE
12027 * scroll.c (scroll_cost): Remove; unused.
12028 * dispextern.h (scroll_cost): Remove decl.
12029
de68a1fc
PE
12030 * region-cache.h (pp_cache): Mark as externally visible.
12031
40ccffa6
PE
12032 * process.c: Make symbols static if they're not exported.
12033 (process_tick, update_tick, create_process, chan_process):
12034 (Vprocess_alist, proc_buffered_char, datagram_access):
12035 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12036 (deactivate_process): Mark defn as static, as well as decl.
12037 * lisp.h (create_process): Remove decl.
12038 * process.h (chan_process, Vprocess_alist): Remove decls.
12039
ad64fc97
PE
12040 * print.c: Make symbols static if they're not exported.
12041 (print_depth, new_backquote_output, being_printed, print_buffer):
12042 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12043 (print_interval, print_number_index, initial_stderr_stream):
12044 Now static.
12045 * lisp.h (Fprinc): Remove decl.
12046 (debug_output_compilation_hack): Mark as externally visible.
12047
adddb265
PE
12048 * sysdep.c (croak): Move decl from here to syssignal.h.
12049 * syssignal.h (croak): Put it here, so the API can be checked when
12050 'croak' is called from dissociate_if_controlling_tty.
12051
1717ede2
PE
12052 * minibuf.c: Make symbols static if they're not exported.
12053 (minibuf_save_list, choose_minibuf_frame): Now static.
12054 * lisp.h (choose_minibuf_frame): Remove decl.
12055
fa5fb2bc
PE
12056 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12057
1e3890d1
PE
12058 * lread.c: Make symbols static if they're not exported.
12059 (read_objects, initial_obarray, oblookup_last_bucket_number):
12060 Now static.
12061 (make_symbol): Remove; unused.
12062 * lisp.h (initial_obarray, make_symbol): Remove decls.
12063
8a1414fa
PE
12064 * keyboard.c: Make symbols static if they're not exported.
12065 (single_kboard, recent_keys_index, total_keys, recent_keys):
12066 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12067 (this_single_command_key_start, echoing, last_auto_save):
12068 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12069 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12070 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12071 (Vlispy_mouse_stem, double_click_count):
12072 Now static.
12073 (force_auto_save_soon): Define only if SIGDANGER.
12074 (ignore_mouse_drag_p): Now static if
12075 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12076 (print_help): Remove; unused.
12077 (stop_character, last_timer_event): Mark as externally visible.
12078 * keyboard.h (ignore_mouse_drag_p): Declare only if
12079 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12080 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12081 * lisp.h (echoing): Remove decl.
12082 (force_auto_save_soon): Declare only if SIGDANGER.
12083 * xdisp.c (redisplay_window): Simplify code, to make it more
12084 obvious that ignore_mouse_drag_p is not accessed if !defined
12085 USE_GTK && !defined HAVE_NS.
12086
93ea6e8f
PE
12087 * intervals.c: Make symbols static if they're not exported.
12088 (merge_properties_sticky, merge_interval_right, delete_interval):
12089 Now static.
12090 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12091
77382fcc
PE
12092 * insdel.c: Make symbols static if they're not exported.
12093 However, leave prepare_to_modify_buffer alone. It's never
12094 called from outside this function, but that appears to be a bug.
12095 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12096 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12097 (adjust_after_replace_noundo): Remove; unused.
12098 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12099 (signal_before_change): Remove decls.
77382fcc 12100
9306c32e
PE
12101 * indent.c (val_compute_motion, val_vmotion): Now static.
12102
cd44d2eb
PE
12103 * image.c: Make symbols static if they're not exported.
12104 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12105 if USE_GTK.
12106 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12107 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12108
ad9a7a06
PE
12109 * fringe.c (standard_bitmaps): Now static.
12110 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12111
81626931
PE
12112 * frame.c: Make symbols static if they're not exported.
12113 (x_report_frame_params, make_terminal_frame): Now static.
12114 (get_frame_param): Now static, unless HAVE_NS.
12115 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12116 (x_get_resource_string): Remove; not used.
12117 * frame.h (make_terminal_frame, x_report_frame_params):
12118 (x_get_resource_string); Remove decls.
12119 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12120 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12121
239f9db9
PE
12122 * font.c, fontset.c: Make symbols static if they're not exported.
12123 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12124 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12125 * font.c (font_close_object): Now static.
12126 * font.h (font_close_object): Remove.
12127 * fontset.c (FONTSET_OBJLIST): Remove.
12128 (free_realized_fontset) #if-0 the body, which does nothing.
12129 (face_suitable_for_char_p): #if-0, as it's never called.
12130 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12131 * xfaces.c (face_at_string_position):
12132 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12133 since 0 is always ASCII.
12134
dfcf3579
PE
12135 * fns.c (weak_hash_tables): Now static.
12136
5045092b
PE
12137 * fileio.c: Make symbols static if they're not exported.
12138 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12139 (Vwrite_region_annotation_buffers): Now static.
12140
57a96f5c
PE
12141 * eval.c: Make symbols static if they're not exported.
12142 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12143 * lisp.h (backtrace_list): Remove decl.
12144
35f08c38
PE
12145 * emacs.c: Make symbols static if they're not exported.
12146 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12147 (fatal_error_code, fatal_error_signal_hook, standard_args):
12148 Now static.
12149 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12150 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12151 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12152 * lisp.h (fatal_error_signal_hook): Remove decl.
12153 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12154
f44bd759
PE
12155 * editfns.c: Move a (normally-unused) function to its only use.
12156 * editfns.c, lisp.h (get_operating_system_release): Remove.
12157 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12158 worth the hassle of breaking this out.
12159
b532497d
PE
12160 * xterm.c: Make symbols static if they're not exported.
12161 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12162 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12163 (x_destroy_window, x_delete_display):
12164 Now static.
12165 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12166 (x_mouse_leave): Remove; unused.
12167 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12168 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12169 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12170 Remove decls.
12171 (x_mouse_leave): Declare only if WINDOWSNT.
12172 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12173 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12174 USE_X_TOOLKIT.
12175
1675728f
PE
12176 * ftxfont.c: Make symbols static if they're not exported.
12177 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12178 HAVE_FREETYPE.
12179 * font.h (ftxfont_driver): Likewise.
12180
e4cebfca
PE
12181 * xfns.c: Make symbols static if they're not exported.
12182 (x_last_font_name, x_display_info_for_name):
12183 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12184 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12185 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12186 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12187 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12188 (last_show_tip_args): Now static.
12189 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12190 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12191 (x_screen_planes): Remove; unused.
12192 * dispextern.h (x_screen_planes): Remove decl.
12193
5bf46f05
PE
12194 * dispnew.c: Make symbols static if they're not exported.
12195 * dispextern.h (redraw_garbaged_frames, scrolling):
12196 (increment_row_positions): Remove.
12197 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12198 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12199 Now static.
12200 (redraw_garbaged_frames): Remove; unused.
12201
435f4c28
PE
12202 * xfaces.c: Make symbols static if they're not exported.
12203 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12204 Remove decls.
12205 * xterm.h (defined_color): Remove decls.
12206 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12207 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12208 (menu_face_changed_default, defined_color, free_realized_face):
12209 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12210 (ascii_face_of_lisp_face): Remove; unused.
12211
8524aef3
PE
12212 * xdisp.c: Make symbols static if they're not exported.
12213 * dispextern.h (scratch_glyph_row, window_box_edges):
12214 (glyph_to_pixel_coords, set_cursor_from_row):
12215 (get_next_display_element, set_iterator_to_next):
12216 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12217 (show_mouse_face): Remove decls
12218 * frame.h (message_buf_print): Likewise.
12219 * lisp.h (pop_message, set_message, check_point_in_composition):
12220 Likewise.
12221 * xterm.h (set_vertical_scroll_bar): Likewise.
12222 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12223 (message_buf_print, scratch_glyph_row, displayed_buffer):
12224 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12225 (get_next_display_element, show_mouse_face, window_box_edges):
12226 (frame_to_window_pixel_xy, check_point_in_composition):
12227 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12228 (glyph_to_pixel_coords): Remove; unused.
12229
16390cd2
PE
12230 * dired.c (file_name_completion): Now static.
12231
12232 * dbusbind.c (xd_in_read_queued_messages): Now static.
12233
a25f4dfa
PE
12234 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12235 * data.c (circular_list_error): Remove.
12236
14a9c8df
PE
12237 * commands.h (last_point_position, last_point_position_buffer):
12238 (last_point_position_window): Remove decls.
12239 * keyboard.c: Make these variables static.
12240
04f2d78b
CB
12241 * coding.h (coding, code_convert_region, encode_coding_gap):
12242 Remove decls.
74ab6df5
PE
12243 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12244 (iso_code_class, detect_coding, code_convert_region): Now static.
12245 (encode_coding_gap): Remove; unused.
12246
38dfbee1
PE
12247 * chartab.c (chartab_chars, chartab_bits): Now static.
12248
a2cb4e63
PE
12249 * charset.h (charset_iso_8859_1): Remove decl.
12250 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12251 Now static.
12252
127198fd
PE
12253 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12254 * ccl.c (Vccl_program_table): Now static.
12255 (check_ccl_update): Remove; unused.
12256
d85b608f
PE
12257 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12258 * category.h: ... from here.
12259 * category.c (check_category_table, set_category_set): Now static.
12260
31cd66f3
PE
12261 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12262 * lisp.h: Remove these decls.
12263
c358e587
PE
12264 * buffer.c (buffer_count): Remove unused var.
12265
e78aecca
PE
12266 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12267 so that it's not optimized away.
12268 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12269 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12270 exported only to the debugger.
12271
e192d7d3 12272 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12273 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12274
92470028
PE
12275 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12276 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12277 was inaccessible from Lisp.
12278 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12279 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12280
244ed907
PE
12281 alloc.c: Import and export fewer symbols, and remove unused items.
12282 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12283 is defined.
12284 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12285 it's not optimized away by whole-program optimization.
12286 (message_enable_multibyte, free_misc): Remove.
12287 (catchlist, handlerlist, mark_backtrace):
12288 Declare only if BYTE_MARK_STACK.
12289 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12290 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12291 (message_enable_multibyte): Remove decl.
12292 (free_misc, interval_free_list, float_block, float_block_index):
12293 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12294 (cons_free_list, last_marked_index):
12295 Now static.
12296 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12297 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12298 (mark_backtrace): Define only if BYTE_MARK_STACK.
12299 * xdisp.c (message_enable_multibyte): Now static.
12300
61c2b50e 12301 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12302 This makes it easier for human readers (and static analyzers)
12303 to see whether these variables are used from other modules.
12304 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12305 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12306 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12307 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12308 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12309 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12310 * xmenu.c, xselect.c:
12311 Declare Q* vars static if they are not used in other modules.
12312 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12313 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12314 Remove decls of unexported vars.
12315 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12316
95c82688
PE
12317 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12318
16a97296
PE
12319 Make Emacs functions such as Fatom 'static' by default.
12320 This makes it easier for human readers (and static analyzers)
12321 to see whether these functions can be called from other modules.
12322 DEFUN now defines a static function. To make the function external
12323 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12324 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12325 (Finit_image_library):
16a97296
PE
12326 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12327 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12328 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12329 Remove decls, since these functions are now static.
12330 (Funintern, Fget_internal_run_time): New decls, since these functions
12331 were already external.
95c82688 12332
16a97296
PE
12333 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12334 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12335 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12336 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12337 * keyboard.c, keymap.c, lread.c:
12338 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12339 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12340 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12341 Mark functions with DEFUE instead of DEFUN,
12342 if they are used in other modules.
12343 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12344 decls for now-static functions.
12345 * buffer.h (Fdelete_overlay): Remove decl.
12346 * callproc.c (Fgetenv_internal): Mark as internal.
12347 * composite.c (Fremove_list_of_text_properties): Remove decl.
12348 (Fcomposition_get_gstring): New forward static decl.
12349 * composite.h (Fcomposite_get_gstring): Remove decl.
12350 * dired.c (Ffile_attributes): New forward static decl.
12351 * doc.c (Fdocumntation_property): New forward static decl.
12352 * eval.c (Ffetch_bytecode): New forward static decl.
12353 (Funintern): Remove extern decl; now in .h file where it belongs.
12354 * fileio.c (Fmake_symbolic_link): New forward static decl.
12355 * image.c (Finit_image_library): New forward static decl.
12356 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12357 * intervals.h (Fprevious_property_change):
12358 (Fremove_list_of_text_properties): Remove decls.
12359 * keyboard.c (Fthis_command_keys): Remove decl.
12360 (Fcommand_execute): New forward static decl.
12361 * keymap.c (Flookup_key): New forward static decl.
12362 (Fcopy_keymap): Now static.
12363 * keymap.h (Flookup_key): Remove decl.
12364 * process.c (Fget_process): New forward static decl.
12365 (Fprocess_datagram_address): Mark as internal.
12366 * syntax.c (Fsyntax_table_p): New forward static decl.
12367 (skip_chars): Remove duplicate decl.
12368 * textprop.c (Fprevious_property_change): New forward static decl.
12369 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12370 Now internal.
12371 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12372 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12373
785bbd42
PE
12374 * editfns.c (Fformat): Remove unreachable code.
12375
8b913b57
AS
123762011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12377
12378 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12379 change. (Bug#8496)
12380
a6744a35
EZ
123812011-04-13 Eli Zaretskii <eliz@gnu.org>
12382
12383 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12384 when at ZV. (Bug#8487)
12385
e7974947
AS
123862011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12387
baad03f0
AS
12388 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12389 (Bug#8437)
12390 * keyboard.c (parse_tool_bar_item): Likewise.
12391 * sound.c (sound_cleanup, alsa_close): Likewise.
12392 * termcap.c (tgetent): Likewise.
12393 * xfns.c (x_default_font_parameter): Likewise.
12394 * xsettings.c (read_and_apply_settings): Likewise.
12395
e7974947
AS
12396 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12397 (overrun_check_free): Protoize.
12398
28272684
PE
123992011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12400
12401 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12402 since callers should never pass a negative size.
12403 Change the signature to match that of plain 'read' and 'write'; see
12404 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12405 * lisp.h: Update prototypes of emacs_write and emacs_read.
12406
11997c76
EZ
124072011-04-11 Eli Zaretskii <eliz@gnu.org>
12408
12409 * xdisp.c (redisplay_window): Don't try to determine the character
12410 position of the scroll margin if the window start point w->startp
e896f03c 12411 is outside the buffer's accessible region. (Bug#8468)
11997c76 12412
8a2cbd72
EZ
124132011-04-10 Eli Zaretskii <eliz@gnu.org>
12414
12415 Fix write-region and its subroutines for buffers > 2GB.
12416 * fileio.c (a_write, e_write): Modify declaration of arguments and
12417 local variables to support buffers larger than 2GB.
12418 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12419
12420 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12421 argument, local variables, and return value.
12422
12423 * lisp.h: Update prototypes of emacs_write and emacs_read.
12424
12425 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12426
4073e537 124272011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12428
1ebfdcb6
PE
12429 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12430
b2ded58d
PE
12431 Fix more problems found by GCC 4.6.0's static checks.
12432
7d66342c
PE
12433 * xdisp.c (vmessage): Use a better test for character truncation.
12434
bbf47d44
PE
12435 * charset.c (load_charset_map): <, not <=, for optimization,
12436 and to avoid potential problems with integer overflow.
9248994d 12437 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12438 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12439 * editfns.c (Fformat): Likewise.
1e69125e 12440 * syntax.c (skip_chars): Likewise.
3befa583 12441
e3019616
PE
12442 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12443 This also lets GCC 4.6.0 generate slightly better loop code.
12444
becfa255
PE
12445 * callint.c (Fcall_interactively): <, not <=, for optimization.
12446 (Fcall_interactively): Count the number of arguments produced,
12447 not the number of arguments given. This is simpler and lets GCC
12448 4.6.0 generate slightly better code.
12449
dae0cd48
PE
12450 * ftfont.c: Distingish more carefully between FcChar8 and char.
12451 The previous code passed unsigned char * to a functions like
12452 strlen and xstrcasecmp that expect char *, which does not
12453 conform to the C standard.
12454 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12455 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12456 char * when the C standard requires it.
12457
76032d70
PE
12458 * keyboard.c (read_char): Remove unused var.
12459
eb3f1cc8
PE
12460 * eval.c: Port to Windows vsnprintf (Bug#8435).
12461 Include <limits.h>.
12462 (SIZE_MAX): Define if the headers do not.
12463 (verror): Do not give up if vsnprintf returns a negative count.
12464 Instead, grow the buffer. This ports to Windows vsnprintf, which
12465 does not conform to C99. Problem reported by Eli Zaretskii.
12466 Also, simplify the allocation scheme, by avoiding the need for
12467 calling realloc, and removing the ALLOCATED variable.
12468
70476b54
PE
12469 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12470
12020a9e
PE
12471 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12472 But keep the doprint source code for now, as we might revamp it
12473 and use it again (Bug#8435).
ea6c7ae6
PE
12474 * lisp.h (doprnt): Remove.
12475 * Makefile.in (base_obj): Remove doprnt.o.
12476 * deps.mk (doprnt.o): Remove.
12477
5fdb398c
PE
12478 error: Print 32- and 64-bit integers portably (Bug#8435).
12479 Without this change, on typical 64-bit hosts error ("...%d...", N)
12480 was used to print both 32- and 64-bit integers N, which relied on
12481 undefined behavior.
61bdb816 12482 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12483 * lisp.h (error, verror): Mark as printf-like functions.
12484 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12485 Report overflow in size calculations when allocating printf buffer.
12486 Do not truncate output string at its first null byte.
12487 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12488 Truncate the output at a character boundary, since vsnprintf does not
12489 do that.
12490 * charset.c (check_iso_charset_parameter): Convert internal
12491 character to string before calling 'error', since %c now has the
12492 printf meaning.
12493 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12494 overflow when computing char to be passed to 'error'. Do not
12495 pass Lisp_Object to 'error'; pass the integer instead.
12496 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12497 formatted with plain %d.
12498
b189fa66
PE
12499 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12500
bff87ef0
PE
12501 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12502
7e2cac20
PE
12503 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12504
ce4d90b5
PE
12505 * xterm.c (x_catch_errors): Remove duplicate declaration.
12506
266c9547
PE
12507 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12508
79c49ad2
PE
12509 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12510
368f4090
JM
125112011-04-10 Jim Meyering <meyering@redhat.com>
12512
12513 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12514 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12515 return ssize_t not "int", and use size_t as the buffer length.
12516 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12517 * gnutls.h: Update declarations.
12518 * process.c (read_process_output): Use ssize_t, to match.
12519 (send_process): Likewise.
12520
a32d4040
CY
125212011-04-09 Chong Yidong <cyd@stupidchicken.com>
12522
12523 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12524
8546720e 125252011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12526
04f2d78b
CB
12527 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12528 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12529
8546720e
GM
12530 * xterm.c (handle_one_xevent):
12531 * xmenu.c (create_and_show_popup_menu):
12532 * xselect.c (x_decline_selection_request)
12533 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12534
0a2f5c1a 125352011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12536
12537 Fix some uses of `int' instead of EMACS_INT.
12538 * search.c (string_match_1, fast_string_match)
12539 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12540 (scan_buffer, find_next_newline_no_quit)
12541 (find_before_next_newline, search_command, Freplace_match)
12542 (Fmatch_data): Make some `int' variables be EMACS_INT.
12543
12544 * xdisp.c (display_count_lines): 3rd argument and return value now
12545 EMACS_INT. All callers changed.
12546 (pint2hrstr): Last argument is now EMACS_INT.
12547
12548 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12549 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12550 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12551 (decode_coding_utf_16, decode_coding_emacs_mule)
12552 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12553 (decode_coding_ccl, decode_coding_charset)
12554 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12555 (decode_coding_iso_2022, decode_coding_emacs_mule)
12556 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12557 <char_offset, last_offset>: Declare EMACS_INT.
12558 (encode_coding_utf_8, encode_coding_utf_16)
12559 (encode_coding_emacs_mule, encode_invocation_designation)
12560 (encode_designation_at_bol, encode_coding_iso_2022)
12561 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12562 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12563 Declare EMACS_INT.
12564 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12565 (encode_invocation_designation): Last argument P_NCHARS is now
12566 EMACS_INT.
12567 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12568 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12569
12570 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12571 All users changed.
12572
12573 * ccl.c (Fccl_execute_on_string): Declare some variables
12574 EMACS_INT.
12575
8546720e 125762011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12577
12578 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12579
4e19a977
CS
125802011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12581
12582 * process.c (Fformat_network_address): Doc fix.
12583
87302331
R
125842011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12585
ee7683eb 12586 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12587
cbb59342
CY
125882011-04-08 Chong Yidong <cyd@stupidchicken.com>
12589
12590 * keyboard.c (read_char): Call Lisp function help-form-show,
12591 instead of using internal_with_output_to_temp_buffer.
12592 (Qhelp_form_show): New var.
e0d38eeb 12593 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12594
12595 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12596
12597 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12598
e67a13ab
CY
125992011-04-06 Chong Yidong <cyd@stupidchicken.com>
12600
04f2d78b
CB
12601 * process.c (Flist_processes): Remove to Lisp.
12602 (list_processes_1): Delete.
e67a13ab 12603
973f782d
EZ
126042011-04-06 Eli Zaretskii <eliz@gnu.org>
12605
7c106b1e
EZ
12606 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12607
973f782d
EZ
12608 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12609
41cf7d1a 126102011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12611
ca23cc88
PE
12612 Fix more problems found by GCC 4.6.0's static checks.
12613
f390e2d5
PE
12614 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12615
42eea0d0
PE
12616 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12617
b69769da 12618 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12619
f9541e84
PE
12620 * xdisp.c (vmessage): Mark as a printf-like function.
12621
13841b55
PE
12622 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12623
c136c10f
PE
12624 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12625
5e2d4a30
PE
12626 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12627 printf-like functions.
12628 (tiff_load): Add casts to remove these marks before passing them
12629 to system-supplied API.
12630
583f48b9
PE
12631 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12632
b25d760e
PE
12633 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12634 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12635 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12636 directly, rather than having caller test rule sign. This avoids
12637 some unnecessary tests.
12638 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12639 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12640 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12641
bc7b6697 12642 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12643 (xfont_open): Avoid unnecessary tests.
bc7b6697 12644
27ccc379
PE
12645 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12646
dcd5c89a
PE
12647 * composite.h, composite.c (composition_gstring_put_cache):
12648 Use EMACS_INT, not int, for length.
12649
b13a45c6
PE
12650 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12651 breaking out part of COMPOSITION_DECODE_RULE.
12652 (COMPOSITION_DECODE_RULE): Use it.
12653 * composite.c (get_composition_id): Remove unused local vars,
12654 by using the new macro.
12655
1e792e4d
PE
12656 * textprop.c (set_text_properties_1): Change while to do-while,
12657 since the condition is always true at first.
12658
dc6c6455 12659 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12660 (interval_deletion_adjustment): Return unsigned value.
12661 All uses changed.
dc6c6455 12662
aba7731a
PE
12663 * process.c (list_processes_1, create_pty, read_process_output):
12664 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12665 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12666 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12667 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12668 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12669
fdfc4bf3
PE
12670 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12671
fca8fe46 12672 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12673 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12674
06a0259a 12675 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12676 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12677 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12678
e7b9e80f
PE
12679 * print.c (print_error_message): Avoid int overflow.
12680
56201685
PE
12681 * font.c (font_list_entities): Redo for clarity,
12682 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12683
78834453 12684 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12685 (font_score): Avoid potential overflow in diff calculation.
78834453 12686
0bc0b309 12687 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12688 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12689
e610eaca
PE
12690 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12691
b895abce
PE
12692 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12693 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12694 can always succeed if overflow has undefined behavior.
12695
1f1d9321 12696 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12697 (wordify): Omit three unnecessary tests.
1f1d9321 12698
c59478bc
PE
12699 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12700 All callers changed. This avoids the need for an unused var.
12701
79b73827
PE
12702 * casefiddle.c (casify_region): Remove var that is set but not used.
12703
a4db5dfe
PE
12704 * dired.c (file_name_completion): Remove var that is set but not used.
12705
43aae36e
PE
12706 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12707
2a47c44d 12708 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12709 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12710
a37c69bf
PE
12711 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12712 Check for integer overflow on size calculations.
12713
328ab8e7
PE
12714 * buffer.c (Fprevious_overlay_change): Remove var that is set
12715 but not used.
12716
e5a2a5cb
PE
12717 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12718 Remove vars that are set but not used.
8d84a6eb 12719 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12720 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12721
a60e5f68
PE
12722 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12723
f661cb61 12724 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12725 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12726
f0397f5a
PE
12727 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12728 that are set but not used.
12729
8664db06 12730 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12731 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12732
6abdaa4a
PE
12733 * xselect.c (x_get_local_selection, x_handle_property_notify):
12734 Remove vars that are set but not used.
12735
0ce7538d 12736 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12737 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12738
9ae848fc
PE
12739 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12740 Remove var that is set but not used.
0b918413
PE
12741 (scroll_bar_windows_size): Now size_t, not int.
12742 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12743 Check for overflow.
9ae848fc 12744
a5a62657
PE
12745 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12746 (map_tty_color) [!defined MSDOS]: Likewise.
12747
5c5cdd39
PE
12748 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12749
66ebf983
PE
12750 * coding.c: Remove vars that are set but not used.
12751 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12752 All callers changed.
12753 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12754 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12755 (decode_coding_charset): Remove vars that are set but not used.
12756
1be4d761
PE
12757 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12758 that is set but not used.
12759
47553fa8
PE
12760 * print.c (print_object): Remove var that is set but not used.
12761
1f7196bf 12762 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12763 The gnulib version avoids calling malloc in the usual case,
12764 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12765 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12766 * filelock.c (current_lock_owner): Likewise.
12767 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12768 * sysdep.c: Include allocator.h, careadlinkat.h.
12769 (emacs_no_realloc_allocator): New static constant.
12770 (emacs_readlink): New function.
fdb61804
PE
12771 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12772 ../lib/careadlinkat.h.
d1fdcab7 12773
f84c17c7
SM
127742011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12775
12776 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12777 first non-nil return value).
12778
ef3862ad
JD
127792011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12780
12781 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12782 if not defined (Bug#8403).
12783
376a7006
JB
127842011-04-02 Juanma Barranquero <lekktu@gmail.com>
12785
12786 * xdisp.c (display_count_lines): Remove parameter `start',
12787 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12788 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12789 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12790 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12791 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12792 and thereabouts. All callers changed.
12793 (get_per_char_metric): Remove parameter `f', unused since
12794 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12795
6ca3801d
JM
127962011-04-02 Jim Meyering <meyering@redhat.com>
12797
12798 do not dereference NULL upon failed strdup
12799 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12800 (ns_get_family): Likewise.
12801
d8e2b5ba
JB
128022011-04-02 Juanma Barranquero <lekktu@gmail.com>
12803
12804 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12805
8c74fcbd
JD
128062011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12807
12808 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12809 later (Bug#8403).
12810
7200d79c
SM
128112011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12812
03408648 12813 Add lexical binding.
7200d79c 12814
03408648
SM
12815 * window.c (Ftemp_output_buffer_show): New fun.
12816 (Fsave_window_excursion):
12817 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12818
12819 * lread.c (lisp_file_lexically_bound_p): New function.
12820 (Fload): Bind Qlexical_binding.
12821 (readevalloop): Remove `evalfun' arg.
12822 Bind Qinternal_interpreter_environment.
12823 (Feval_buffer): Bind Qlexical_binding.
12824 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12825 Mark as dynamic.
12826 (syms_of_lread): Declare `lexical-binding'.
12827
12828 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12829
12830 * keyboard.c (eval_dyn): New fun.
12831 (menu_item_eval_property): Use it.
ca105506
SM
12832
12833 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12834
03408648
SM
12835 * fns.c (concat, mapcar1): Accept byte-code-functions.
12836
12837 * eval.c (Fsetq): Handle lexical vars.
12838 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12839 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12840 (FletX, Flet): Obey lexical binding.
12841 (Fcommandp): Handle closures.
12842 (Feval): New `lexical' arg.
12843 (eval_sub): New function extracted from Feval. Use it almost
12844 everywhere where Feval was used. Look up vars in lexical env.
12845 Handle closures.
12846 (Ffunctionp): Move from subr.el.
12847 (Ffuncall): Handle closures.
12848 (apply_lambda): Remove `eval_flags'.
12849 (funcall_lambda): Handle closures and new byte-code-functions.
12850 (Fspecial_variable_p): New function.
12851 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12852 but without exporting it to Lisp.
23aba0ea 12853
23aba0ea 12854 * doc.c (Fdocumentation, store_function_docstring):
03408648 12855 * data.c (Finteractive_form): Handle closures.
23aba0ea 12856
03408648
SM
12857 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12858 interactive spec.
ba83908c 12859
04f2d78b
CB
12860 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12861 New byte-codes.
03408648
SM
12862 (exec_byte_code): New function extracted from Fbyte_code to handle new
12863 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12864
03408648 12865 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12866
03408648 12867 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12868
e2abce01
JB
128692011-03-31 Juanma Barranquero <lekktu@gmail.com>
12870
12871 * xdisp.c (redisplay_internal): Fix prototype.
12872
63696a73 128732011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12874
63696a73 12875 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12876 (try_scrolling): Use it when setting scroll_limit.
12877 Limit scrolling to 100 screen lines.
63696a73
EZ
12878 (redisplay_window): Even when falling back on "recentering",
12879 position point in the window according to scroll-conservatively,
12880 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12881
12882 (try_scrolling): When point is above the window, allow searching
12883 as far as scroll_max, or one screenful, to compute vertical
12884 distance from PT to the scroll margin position. This prevents
12885 try_scrolling from unnecessarily failing when
12886 scroll-conservatively is set to a value slightly larger than the
12887 window height. Clean up the case of PT below the margin at bottom
12888 of window: scroll_max can no longer be INT_MAX. When aggressive
12889 scrolling is in use, don't let point enter the opposite scroll
12890 margin as result of the scroll.
12891 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12892 threshold of 100 lines for never-recentering scrolling.
12893
e4cc2dfc
JB
128942011-03-31 Juanma Barranquero <lekktu@gmail.com>
12895
12896 * dispextern.h (move_it_by_lines):
12897 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12898 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12899 (message_log_check_duplicate): Remove parameters `prev_bol' and
12900 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12901 (redisplay_internal): Remove parameter `preserve_echo_area',
12902 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12903
12904 * indent.c (Fvertical_motion):
12905 * window.c (window_scroll_pixel_based, Frecenter):
12906 Don't pass `need_y_p' to `move_it_by_lines'.
12907
1c470562
SM
129082011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12909
44f230aa
SM
12910 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12911 steal a few bits to be more compact.
12912 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12913 Remove unneeded casts.
12914
1c470562
SM
12915 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12916
888adce9
ZK
129172011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12918
12919 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12920 binding" message (bug#7967).
12921
f838ed7b
PE
129222011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12923
77861b95
PE
12924 Fix more problems found by GCC 4.6.0's static checks.
12925
de6dbc14
PE
12926 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12927 Remove unused local var.
12928
f838ed7b
PE
12929 * editfns.c (Fmessage_box): Remove unused local var.
12930
792c7b2b
PE
12931 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12932 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12933 Omit unused local vars.
c499e557 12934 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12935 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12936 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12937 Omit unused local var.
12938
ba0165e1
PE
12939 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12940 Don't assume string length fits in int.
32ad8845 12941 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12942 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12943
3c59b4c9
PE
12944 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12945 instead of alloca (Bug#8344).
12946
a3eed478 12947 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12948 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12949
eb4d412d
PE
12950 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12951
1658b401
PE
12952 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12953 concerns.
12954
12955 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12956
12957 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12958
9a2c6e05
PE
12959 * keyboard.c (syms_of_keyboard): Use the same style as later
12960 in this function when indexing through an array. This also
12961 works around GCC bug 48267.
12962
03d0a109
PE
12963 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12964
44f730c8
PE
12965 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12966
fe75f926
PE
12967 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12968 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12969
ffa8c828
PE
12970 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12971 This avoids undefined behavior on integer overflow, and is a bit
12972 more convenient anyway since it is compared to a size_t variable.
12973
c5101a77
PE
12974 Variadic C functions now count arguments with size_t, not int.
12975 This avoids an unnecessary limitation on 64-bit machines, which
12976 caused (substring ...) to crash on large vectors (Bug#8344).
12977 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12978 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12979 All variadic functions and their callers changed accordingly.
c5101a77
PE
12980 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12981 * data.c (arith_driver, float_arith_driver): Likewise.
12982 * editfns.c (general_insert_function): Likewise.
12983 * eval.c (struct backtrace.nargs, interactive_p)
12984 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12985 (funcall_lambda, mark_backtrace): Likewise.
12986 * fns.c (concat): Likewise.
12987 * frame.c (x_set_frame_parameters): Likewise.
12988 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12989 0 if not found, not -1. All callers changed.
12990
dd3f25f7
PE
12991 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12992 (stack_copy_size): Now size_t, not int.
12993 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12994
461c2ab9
JB
129952011-03-28 Juanma Barranquero <lekktu@gmail.com>
12996
12997 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12998 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12999 All callers changed.
13000
13001 * lisp.h (multibyte_char_to_unibyte):
13002 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13003 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13004 * character.h (CHAR_TO_BYTE8):
13005 * cmds.c (internal_self_insert):
13006 * editfns.c (general_insert_function):
13007 * keymap.c (push_key_description):
13008 * search.c (Freplace_match):
13009 * xdisp.c (message_dolog, set_message_1): All callers changed.
13010
f6d62986
SM
130112011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13012
13013 * keyboard.c (safe_run_hook_funcall): New function.
13014 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13015 don't set the hook to nil, but remove the offending function instead.
13016 (Qcommand_hook_internal): Remove, unused.
13017 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13018 Vcommand_hook_internal.
13019
13020 * eval.c (enum run_hooks_condition): Remove.
13021 (funcall_nil, funcall_not): New functions.
13022 (run_hook_with_args): Call each function through a `funcall' argument.
13023 Remove `cond' argument, now redundant.
13024 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13025 (Frun_hook_with_args_until_failure): Adjust accordingly.
13026 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13027
1db5b1ad
JB
130282011-03-28 Juanma Barranquero <lekktu@gmail.com>
13029
13030 * dispextern.h (string_buffer_position): Remove declaration.
13031
13032 * print.c (strout): Remove parameter `multibyte', unused since
13033 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13034
13035 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13036 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13037 All callers changed.
13038
13039 * w32.c (_wsa_errlist): Use braces for struct initializers.
13040
13041 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13042 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13043 All callers changed.
13044 (string_buffer_position): Likewise. Also, make static (it's never
13045 used outside xdisp.c).
13046 (cursor_row_p): Remove parameter `w', unused since
13047 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13048 (decode_mode_spec): Remove parameter `precision', introduced during
13049 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13050 All callers changed.
13051
5ffb62aa
JD
130522011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13053
13054 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13055
461c2ab9 130562011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13057
13058 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13059 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13060 (ns_update_auto_hide_menu_bar): New functions.
13061 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13062 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13063 ns_constrain_all_frames.
13064 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13065 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13066
5c380ffb
JD
130672011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13068
13069 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13070
9af30bdf
GM
130712011-03-27 Glenn Morris <rgm@gnu.org>
13072
13073 * syssignal.h: Replace RETSIGTYPE with void.
13074 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13075 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13076 Replace SIGTYPE with void everywhere.
13077 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13078 * s/template.h (SIGTYPE): Remove commented out definition.
13079
e2abce01
JB
130802011-03-26 Eli Zaretskii <eliz@gnu.org>
13081
13082 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13083 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13084
f868cd8a
JB
130852011-03-26 Juanma Barranquero <lekktu@gmail.com>
13086
59eb0929
JB
13087 * w32.c (read_unc_volume): Use parameter `henum', instead of
13088 global variable `wget_enum_handle'.
13089
13090 * keymap.c (describe_vector): Remove parameters `indices' and
13091 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13092 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13093
f868cd8a
JB
13094 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13095
13096 * keyboard.c (timer_check): Remove parameter `do_it_now',
13097 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13098 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13099 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13100
13101 * keyboard.c (read_char):
13102 * w32menu.c (w32_menu_display_help):
13103 * xmenu.c (show_help_event, menu_help_callback):
13104 Adjust calls to `show_help_echo'.
13105
13106 * gtkutil.c (xg_maybe_add_timer):
13107 * keyboard.c (readable_events):
13108 * process.c (wait_reading_process_output):
13109 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13110
13111 * insdel.c (adjust_markers_gap_motion):
13112 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13113 (gap_left, gap_right): Don't call it.
13114
2ecf6fdb
CY
131152011-03-25 Chong Yidong <cyd@stupidchicken.com>
13116
13117 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13118 incurred during fontification.
13119
6b1f9ba4
JB
131202011-03-25 Juanma Barranquero <lekktu@gmail.com>
13121
13122 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13123 (DEFVAR_PER_BUFFER): Don't pass it.
13124
13125 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13126 (scrolling_window): Don't pass it.
13127
0f4a96b5
JB
131282011-03-25 Juanma Barranquero <lekktu@gmail.com>
13129
13130 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13131
13132 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13133 and `suffix'.
13134 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13135 of variables specific to SELinux and computation of `encoded_absname'.
13136
13137 * image.c (XPutPixel): Remove unused variable `height'.
13138
13139 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13140
13141 * unexw32.c (get_section_info): Remove unused variable `section'.
13142
13143 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13144 (system_process_attributes): Remove unused variable `sess'.
13145 (sys_read): Remove unused variable `err'.
13146
13147 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13148 (w32_wnd_proc): Remove unused variable `isdead'.
13149 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13150 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13151 (x_create_tip_frame): Remove unused variable `tem'.
13152
13153 * w32inevt.c (w32_console_read_socket):
13154 Remove unused variable `no_events'.
13155
13156 * w32term.c (x_draw_composite_glyph_string_foreground):
13157 Remove unused variable `width'.
13158
1149507c
JB
131592011-03-24 Juanma Barranquero <lekktu@gmail.com>
13160
13161 * w32term.c (x_set_glyph_string_clipping):
13162 Don't pass uninitialized region to CombineRgn.
13163
9c88f339
JB
131642011-03-23 Juanma Barranquero <lekktu@gmail.com>
13165
13166 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13167 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13168 (Fx_close_connection): Remove unused variable `i'.
13169
13170 * w32font.c (w32font_draw): Return number of glyphs.
13171 (w32font_open_internal): Remove unused variable `i'.
13172 (w32font_driver): Add missing initializer.
13173
13174 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13175 (fill_in_menu): Remove unused variable `items_added'.
13176
13177 * w32term.c (last_mouse_press_frame): Remove static global variable.
13178 (w32_clip_to_row): Remove unused variable `f'.
13179 (x_delete_terminal): Remove unused variable `i'.
13180
13181 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13182 (NOTHING): Remove unused static global variable.
13183 (uniscribe_check_otf): Remove unused variable `table'.
13184 (uniscribe_font_driver): Add missing initializers.
13185
dee091a3
JD
131862011-03-23 Julien Danjou <julien@danjou.info>
13187
13188 * term.c (Fsuspend_tty, Fresume_tty):
13189 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13190 * window.c (temp_output_buffer_show):
13191 * insdel.c (signal_before_change):
13192 * frame.c (Fhandle_switch_frame):
13193 * fileio.c (Fdo_auto_save):
13194 * emacs.c (Fkill_emacs):
13195 * editfns.c (save_excursion_restore):
13196 * cmds.c (internal_self_insert):
13197 * callint.c (Fcall_interactively):
13198 * buffer.c (Fkill_all_local_variables):
13199 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13200 Use Frun_hooks.
0f4a96b5 13201 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13202 unconditionally since it does the check itself.
dee091a3 13203
2c520ab5 132042011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13205
c9c49752
PE
13206 Fix more problems found by GCC 4.5.2's static checks.
13207
8abc3f12
PE
13208 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13209 the first time through the loop, since we know p0 < p1 then.
13210 This also avoids a gcc -Wstrict-overflow warning.
13211
a2d26660
PE
13212 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13213 leading to a memory leak, possible in functions like
13214 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13215 of objects (Bug#8318).
a2d26660 13216
916c72e9
PE
13217 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13218 that could (at least in theory) be that large.
13219
19ab8a18
PE
13220 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13221 This is less likely to overflow, and avoids undefined behavior if
13222 overflow does occur. All callers changed. Use strtoul to scan
13223 for the unsigned long integer.
b7cbbd6f
PE
13224 (pint2hrstr): Simplify and tune code slightly.
13225 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13226
f0641eff
PE
13227 * scroll.c (do_scrolling): Work around GCC bug 48228.
13228 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13229
7f650bb9
PE
13230 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13231 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13232 (validate_x_resource_name): Simplify count usage.
13233 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13234
37dd57d1
PE
13235 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13236 fail (Bug#8306).
81e56e61 13237
699979fc 13238 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13239
401bf9b4
PE
13240 * process.c (Fmake_network_process): Use socklen_t, not int,
13241 where POSIX says socklen_t is required in portable programs.
13242 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13243 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13244 (Fmake_network_process, server_accept_connection):
13245 (wait_reading_process_output, read_process_output):
13246 Likewise.
13247
b93aacde
PE
13248 * process.c: Rename or move locals to avoid shadowing.
13249 (list_processes_1, Fmake_network_process):
13250 (read_process_output_error_handler, exec_sentinel_error_handler):
13251 Rename or move locals.
4dc343ee 13252 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13253 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13254 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13255 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13256 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13257
af8a867c 13258 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13259 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13260 Include tparam.h instead, since it declares them.
af8a867c
PE
13261 * cm.h (PC): Remove extern decl; tparam.h now does this.
13262 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13263 * terminfo.c: Include tparam.h, to check interfaces.
13264 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13265 (tparam): Adjust signature to match interface in tparam.h;
13266 this removes some undefined behavior. Check that outstring and len
13267 are zero, which they always are with Emacs.
13268 * tparam.h (PC, BC, UP): New extern decls.
13269
0248044d 13270 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13271 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13272
8ff096c1 13273 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13274 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13275 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13276 (ftfont_list): Remove unused local.
49eaafba
PE
13277 (get_adstyle_property, ftfont_pattern_entity):
13278 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13279 Rename locals to avoid shadowing.
8ff096c1 13280
e2be39f6
PE
13281 * xfont.c (xfont_list_family): Mark var as initialized.
13282
c9735e30
PE
13283 * xml.c (make_dom): Now static.
13284
8f5201ae
PE
13285 * composite.c (composition_compute_stop_pos): Rename local to
13286 avoid shadowing.
b246f932
PE
13287 (composition_reseat_it): Remove unused locals.
13288 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13289 (composition_update_it): Mark var as initialized.
11b61122
PE
13290 (find_automatic_composition): Mark vars as initialized,
13291 with a FIXME (Bug#8290).
8f5201ae 13292
760fbc2c
PE
13293 character.h: Rename locals to avoid shadowing.
13294 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13295 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13296 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13297 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13298 to avoid shadowing.
13299
ff08eb85
PE
13300 * textprop.c (property_change_between_p): Remove; unused.
13301
fc7bf025
PE
13302 * intervals.c (interval_start_pos): Now static.
13303
235d7abc
PE
13304 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13305
44f230aa
SM
13306 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13307 Rename locals to avoid shadowing.
3e7d6594 13308
50060332
PE
13309 * sound.c (wav_play, au_play, Fplay_sound_internal):
13310 Fix pointer signedness.
d01f234b 13311 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13312 (wav_play): Initialize a variable to 0, to prevent undefined
13313 behavior (Bug#8278).
50060332 13314
c4fc4e30
PE
13315 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13316
918436ed
PE
13317 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13318
c939f91b
PE
13319 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13320 clobbering (Bug#8298).
b9c7f648
PE
13321 * sysdep.c (sys_subshell): Likewise.
13322 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13323
6bd8c144
PE
13324 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13325 This should get cleaned up, so that child_setup has the
13326 same signature on all platforms.
13327
7710357c 13328 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13329 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13330
c59da222
CY
133312011-03-22 Chong Yidong <cyd@stupidchicken.com>
13332
13333 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13334 not to be necessary, and produces flickering.
13335
66b87493
GM
133362011-03-20 Glenn Morris <rgm@gnu.org>
13337
13338 * config.in: Remove file.
13339
45b6f6d5
JB
133402011-03-20 Juanma Barranquero <lekktu@gmail.com>
13341
13342 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13343 are now in src/globals.h.
13344 (syms_of_minibuf): Remove spurious & from previous change.
13345
cd394be1 133462011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13347
13348 * minibuf.c (completing-read-function): New variable.
13349 (completing-read-default): Rename from completing-read.
13350 (completing-read): Call completing-read-function.
13351
b14e3e21
CY
133522011-03-19 Juanma Barranquero <lekktu@gmail.com>
13353
13354 * xfaces.c (Fx_load_color_file):
13355 Read color file from absolute filename (bug#8250).
13356
f2b726e6
JB
133572011-03-19 Juanma Barranquero <lekktu@gmail.com>
13358
13359 * makefile.w32-in: Update dependencies.
13360
09f6ff02
EZ
133612011-03-17 Eli Zaretskii <eliz@gnu.org>
13362
13363 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13364
29a6015a
PE
133652011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13366
a3a6c54e
PE
13367 Fix more problems found by GCC 4.5.2's static checks.
13368
b766f867
PE
13369 * process.c (make_serial_process_unwind, send_process_trap):
13370 (sigchld_handler): Now static.
13371
be02381c
PE
13372 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13373 That way, the code declares only the vars that it needs.
13374 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13375 * s/cygwin.h (PTY_ITERATION): Likewise.
13376 * s/darwin.h (PTY_ITERATION): Likewise.
13377 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13378
57048744
PE
13379 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13380 * process.c (allocate_pty): Don't declare stb unless it's needed.
13381
7914961c 13382 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13383 (CONSTANTLIM): Remove; unused.
13384 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13385 Define only if needed.
7914961c 13386
b3967b18
PE
13387 * unexelf.c (unexec): Name an expression,
13388 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13389 Use a different way to cause a compilation error if anyone uses
13390 n rather than nn, a way that does not involve shadowing.
73366a00 13391 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13392
29a6015a
PE
13393 * deps.mk (unexalpha.o): Remove; unused.
13394
43cfc33e 13395 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13396 * unexec.h: New file.
ce701a33
PE
13397 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13398 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13399 Depend on unexec.h.
13400 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13401 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13402 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13403 Change as necessary to match prototype in unexec.h.
ce701a33 13404
01f44d5a
PE
13405 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13406 shadowing.
4f63c6bb 13407 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13408
a6670b0b
PE
13409 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13410 Rename locals to avoid shadowing.
13411
cef2010d 13412 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13413 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13414
d4d7173a
PE
13415 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13416
f08b802a
PE
13417 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13418 warning when compiling print.c.
13419
3ddb0639
PE
13420 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13421 instead of using an uninitialized var.
5ad03b97 13422 (font_sort_entities): Mark var as initialized.
3ddb0639 13423
170a2692
PE
13424 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13425
e663c700
PE
13426 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13427 pointers to constants.
89bc529a 13428 (font_parse_fcname): Remove unused vars.
7b81e2d0 13429 (font_delete_unmatched): Now static.
ea838e10 13430 (font_get_spec): Remove; unused.
13a547c6
PE
13431 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13432 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13433 Rename or move locals to avoid shadowing.
e663c700 13434
2a80c887 13435 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13436 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13437
1384fa33 13438 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13439 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13440
8b2c52e9
PE
13441 * alloc.c (mark_backtrace): Move decl from here ...
13442 * lisp.h: ... to here, so that it can be checked.
13443
475545b5 13444 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13445 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13446 (lisp_indirect_variable): Name an expression,
13447 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13448 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13449
b1349114 13450 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13451 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13452 Use const pointer when appropriate.
b1349114 13453
a2928364
PE
13454 * lisp.h (get_system_name, get_operating_system_release):
13455 Move decls here, to check interfaces.
13456 * process.c (get_operating_system_release): Move decl to lisp.h.
13457 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13458 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13459 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13460 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13461 (Fformat_time_string, Fencode_time, Finsert_char):
13462 (Ftranslate_region_internal, Fformat):
13463 Rename or remove local vars to avoid shadowing.
9710023e 13464 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13465
a415e694
PE
13466 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13467 avoid shadowing.
13468
8ef4622d
PE
13469 * lisp.h (eassert): Check that the argument compiles, even if
13470 ENABLE_CHECKING is not defined.
13471
946f9a5b
PE
13472 * data.c (Findirect_variable): Name an expression, to avoid
13473 gcc -Wbad-function-cast warning.
112396d6 13474 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13475 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13476 (Fmake_variable_buffer_local, Fmake_local_variable):
13477 Mark variables as initialized.
52746918 13478 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13479
e5aab7e7 13480 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13481 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13482 Rename locals to avoid shadowing.
dff45157
PE
13483 (mark_stack): Move local variables into the #ifdef region where
13484 they're used.
7bc26fdb
PE
13485 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13486 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13487 needed otherwise.
13488 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13489 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13490 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13491
e5aab7e7
PE
13492 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13493 avoids undefined behavior in theory.
13494
4da60324
PE
13495 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13496
88043301
PE
13497 Use functions, not macros, for up- and down-casing (Bug#8254).
13498 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13499 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13500 to use the following functions instead of these macros.
13501 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13502 EMACS_INT, since callers assume the returned value fits in int.
13503 (upcase1): Likewise, for UPCASE_TABLE.
13504 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13505 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13506 the race-condition problem in the old DOWNCASE.
88043301 13507
19ed5445
PE
13508 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13509 Rename locals to avoid shadowing.
13510 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13511 (regex_compile, re_search_2, re_match_2_internal):
13512 Remove unused local vars.
952db0d7
PE
13513 (FREE_VAR): Rewrite so as not to use empty "else",
13514 which gcc can warn about.
da053e48 13515 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13516 (RETALLOC_IF): Define only if needed.
13517 (WORDCHAR_P): Likewise. This one is never needed, but is used
13518 only in a comment talking about a compiler bug, so put inside
13519 the #if 0 of that comment.
13520 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13521 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13522 Remove; unused.
19ed5445 13523
1f3561e4 13524 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13525 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13526 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13527
ded6f8f7
PE
13528 * search.c (simple_search): Remove unused var.
13529
dbd37a95
PE
13530 * dired.c (compile_pattern): Move decl from here ...
13531 * lisp.h: ... to here, so that it can be checked.
13532 (struct re_registers): New forward decl.
13533
7e47afad
PE
13534 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13535
85f24f61
PE
13536 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13537 All uses changed.
13538 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13539 Rename locals to avoid shadowing.
5671df8f 13540 (Fvertical_motion): Mark locals as initialized.
85f24f61 13541
181aa2be 13542 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13543 (casify_region): Mark local as initialized.
181aa2be 13544
930d429c
PE
13545 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13546
7082eac6
PE
13547 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13548 New macros, so that the caller can use some names other than
13549 gcpro1, gcpro2, etc.
13550 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13551 of the new macros.
13552 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13553 argument, for consistency with GCPRO2_VAR, etc: it is now the
13554 prefix of the variable, not the variable itself. All uses
13555 changed.
38b2c076
PE
13556 * dired.c (directory_files_internal, file_name_completion):
13557 Rename locals to avoid shadowing.
13558
15206ed9
PE
13559 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13560 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13561 dired.c's scmp function, had undefined behavior.
13562 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13563 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13564 * buffer.h: ... to here, because these macros use current_buffer,
13565 and the new implementation with inline functions needs to have
13566 current_buffer in scope now, rather than later when the macros
13567 are used.
13568 (downcase, upcase1): New static inline functions.
13569 (DOWNCASE, UPCASE1): Reimplement using these functions.
13570 This avoids undefined behavior in expressions like
13571 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13572 from race conditions in accessing the global variables
13573 case_temp1 and case_temp2.
13574 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13575 * lisp.h (case_temp1, case_temp2): Remove their decls.
13576 * character.h (ASCII_CHAR_P): Move from here ...
13577 * lisp.h: ... to here, so that the inline functions mentioned
13578 above can use them.
13579
4a6bea26
PE
13580 * dired.c (directory_files_internal_unwind): Now static.
13581
f14b7e14
PE
13582 * fileio.c (file_name_as_directory, directory_file_name):
13583 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13584 Now static.
2893f146
PE
13585 (file_name_as_directory): Use const pointers when appropriate.
13586 (Fexpand_file_name): Likewise. In particular, newdir might
13587 point at constant storage, so make it a const pointer.
fd4ead52 13588 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13589 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13590 signedness issues.
f839df0c
PE
13591 (Fset_file_times, Finsert_file_contents, auto_save_error):
13592 Rename locals to avoid shadowing.
f14b7e14 13593
5716756e 13594 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13595 (Ftry_completion, Fall_completions): Rename or remove locals
13596 to avoid shadowing.
5716756e 13597
b4c3046a
PE
13598 * marker.c (bytepos_to_charpos): Remove; unused.
13599
b45db522
PE
13600 * lisp.h (verify_bytepos, count_markers): New decls,
13601 so that gcc does not warn that these functions aren't declared.
13602
85876d07
PE
13603 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13604 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13605 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13606 (copy_text): Remove unused local var.
85876d07 13607
03d78a21 13608 * filelock.c (within_one_second): Now static.
b3dd38ab 13609 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13610
5df8f01b
PE
13611 * buffer.c (fix_overlays_before): Mark locals as initialized.
13612 (fix_start_end_in_overlays): Likewise. This function should be
13613 simplified by using pointers-to-pointers, but that's a different
13614 matter.
b1d876f1 13615 (switch_to_buffer_1): Now static.
8f54f30a
PE
13616 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13617 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13618
a70072c9 13619 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13620 Fix pointer signedness issue.
edced198
PE
13621 (sys_subshell): Mark local as volatile if checking for lint,
13622 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13623 (MAXPATHLEN): Define only if needed.
a70072c9 13624
a0977c44
PE
13625 * process.c (serial_open, serial_configure): Move decls from here ...
13626 * systty.h: ... to here, so that they can be checked.
13627
a884fdcc
PE
13628 * fns.c (get_random, seed_random): Move extern decls from here ...
13629 * lisp.h: ... to here, so that they can be checked.
13630
604efe86 13631 * sysdep.c (reset_io): Now static.
b8950c94 13632 (wait_for_termination_signal): Remove; unused.
604efe86 13633
38fc62d9
PE
13634 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13635 (copy_keymap_item, append_key, push_text_char_description):
13636 Now static.
1004a21a 13637 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13638 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13639 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13640 (describe_map_tree):
13641 Rename locals to avoid shadowing.
38fc62d9 13642
2f2650da
PE
13643 * keyboard.c: Declare functions static if they are not used elsewhere.
13644 (echo_char, echo_dash, cmd_error, top_level_2):
13645 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13646 (read_char, kbd_buffer_get_event, make_lispy_position):
13647 (make_lispy_event, make_lispy_movement, apply_modifiers):
13648 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13649 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13650 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13651 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13652 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13653
a053e86c 13654 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13655 (mark_kboards): Move decl here ...
13656 * alloc.c (mark_kboards): ... from here.
a053e86c 13657
4752793e
PE
13658 * lisp.h (force_auto_save_soon): New decl.
13659
74f10ca7 13660 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13661 (DEFINE_DUMMY_FUNCTION): New macro.
13662 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13663 Use it.
c03cd23f
PE
13664 (main): Add casts to avoid warnings
13665 if GCC considers string literals to be constants.
74f10ca7 13666
022e70d4
PE
13667 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13668
59d6fe83
PE
13669 * dbusbind.c: Pointer signedness fixes.
13670 (xd_signature, xd_append_arg, xd_initialize):
13671 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13672 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13673 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13674 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13675
78320123
PE
13676 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13677 if GCC considers string literals to be constants.
49cebcca 13678 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13679
35ac2a97
SM
136802011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13681
fb103ca9
SM
13682 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13683 (print_preprocess, print_object): New macro to fix last change.
13684
35ac2a97
SM
13685 * print.c (print_preprocess): Don't forget font objects.
13686
62973b41
JB
136872011-03-16 Juanma Barranquero <lekktu@gmail.com>
13688
13689 * emacs.c (USAGE3): Doc fixes.
13690
0e48bb22
AS
136912011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13692
13693 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13694 structure.
13695
7684e57b
JB
136962011-03-14 Juanma Barranquero <lekktu@gmail.com>
13697
13698 * lisp.h (VWindow_system, Qfile_name_history):
13699 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13700 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13701 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13702
13703 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13704 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13705
13706 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13707 * w32console.c (detect_input_pending, read_input_pending)
13708 (encode_terminal_code):
13709 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13710 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13711 (w32_system_caret_y, Qfile_name_history):
13712 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13713 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13714 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13715 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13716 * w32proc.c (Qlocal, report_file_error):
13717 * w32term.c (Vwindow_system, updating_frame):
13718 * w32uniscribe.c (initialized, uniscribe_font_driver):
13719 Remove unneeded extern declarations.
13720
2aa46d6c
CY
137212011-03-14 Chong Yidong <cyd@stupidchicken.com>
13722
c96bbc66 13723 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13724
cffc6f3b
CY
137252011-03-13 Chong Yidong <cyd@stupidchicken.com>
13726
13727 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13728 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13729 These macros can no longer be used for assignment.
13730
44f230aa
SM
13731 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13732 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13733 (record_buffer_markers, fetch_buffer_markers): New functions for
13734 recording and fetching special buffer markers.
13735 (set_buffer_internal_1, set_buffer_temp): Use them.
13736
13737 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13738
13739 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13740
13741 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13742 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13743
13744 * xdisp.c (hscroll_window_tree):
13745 (reconsider_clip_changes): Use PT instead of BUF_PT.
13746
d251f04b
EZ
137472011-03-13 Eli Zaretskii <eliz@gnu.org>
13748
13749 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13750 $(EMACS_ROOT)/lib/intprops.h.
13751
f0c77cd1
PE
137522011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13753
3eca4629
PE
13754 Fix more problems found by GCC 4.5.2's static checks.
13755
7c86ee98
PE
13756 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13757 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13758 (xg_free_frame_widgets): Make it clear that a local variable is
13759 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13760 (gdk_window_get_screen): Make it clear that this macro is needed
13761 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13762 (int_gtk_range_get_value): New function, which avoids a diagnostic
13763 from gcc -Wbad-function-cast.
13764 (xg_set_toolkit_scroll_bar_thumb): Use it.
13765 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13766 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13767 (get_utf8_string, xg_get_file_with_chooser):
13768 Rename locals to avoid shadowing.
13769 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13770
41729b81
PE
13771 * xgselect.c (xg_select): Remove unused var.
13772
f0c77cd1
PE
13773 * image.c (four_corners_best): Mark locals as initialized.
13774 (gif_load): Initialize transparent_p to zero (Bug#8238).
13775 Mark another local as initialized.
ec6cf4c6 13776 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13777
ce0ad53d 13778 * image.c (clear_image_cache): Now static.
d5d5a617 13779 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13780 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13781 (x_edge_detection): Remove unnecessary cast that
13782 gcc -Wbad-function-cast diagnoses.
2037898d 13783 (gif_load): Fix pointer signedness.
6ae141d6
PE
13784 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13785 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13786
33383987 137872011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13788
d32df629
PE
13789 Improve quality of tests for time stamp overflow.
13790 For example, without this patch (encode-time 0 0 0 1 1
13791 1152921504606846976) returns the obviously-bogus value (-948597
13792 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13793 reports time overflow. See
13794 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13795 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13796 * editfns.c: Include limits.h and intprops.h.
13797 (TIME_T_MIN, TIME_T_MAX): New macros.
13798 (time_overflow): Move earlier, to before first use.
13799 (hi_time, lo_time): New functions, for an accurate test for
13800 out-of-range times.
13801 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13802 (Fget_internal_run_time): Don't assume time_t fits in int.
13803 (make_time): Use list2 instead of Fcons twice.
13804 (Fdecode_time): More accurate test for out-of-range times.
13805 (check_tm_member): New function.
13806 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13807 (lisp_time_argument): Don't rely on undefined left-shift and
13808 right-shift behavior when checking for time stamp overflow.
8be6f318 13809
fe31d94c
PE
13810 * editfns.c (time_overflow): New function, refactoring common code.
13811 (Fformat_time_string, Fdecode_time, Fencode_time):
13812 (Fcurrent_time_string): Use it.
13813
8be6f318
PE
13814 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13815 * dired.c (make_time): Move to ...
13816 * editfns.c (make_time): ... here.
13817 * systime.h: Note the move.
13818
09d9db2c 138192011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13820
126bc0dc
YM
13821 * fringe.c (update_window_fringes): Remove unused variables.
13822
c47cbdfd
YM
13823 * unexmacosx.c (copy_data_segment): Also copy __got section.
13824 (Bug#8223)
13825
7ac80be9
EZ
138262011-03-12 Eli Zaretskii <eliz@gnu.org>
13827
c96bbc66 13828 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13829 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13830 Constify `char *' arguments and their references according to
13831 prototypes in tparam.h.
13832
ecb0f94d 13833 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13834
7ac80be9
EZ
13835 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13836 Adapt all references accordingly.
13837
13838 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13839
ef1fd07e
TT
138402011-03-11 Tom Tromey <tromey@redhat.com>
13841
13842 * buffer.c (syms_of_buffer): Remove obsolete comment.
13843
7ef4b50c
EZ
138442011-03-11 Eli Zaretskii <eliz@gnu.org>
13845
13846 * termhooks.h (encode_terminal_code): Declare prototype.
13847
13848 * msdos.c (encode_terminal_code): Don't declare prototype.
13849
13850 * term.c (encode_terminal_code): Now external again, used by
13851 w32console.c and msdos.c.
13852
44f230aa
SM
13853 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13854 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13855
4b1ec863 138562011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13857
1714f52b 13858 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13859
4b1ec863
PE
13860 * fringe.c (update_window_fringes): Mark locals as initialized
13861 (Bug#8227).
13862 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13863
524c7aa6
PE
13864 * alloc.c (mark_fringe_data): Move decl from here ...
13865 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13866 to check its interface.
13867 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13868
a5c0af81 13869 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13870 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13871 (fontset_font): Mark local as initialized.
a9a06e0b 13872 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13873
b4716021
PE
13874 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13875
811e9bac 13876 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13877 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13878 (x_own_selection, Fx_disown_selection_internal): Rename locals
13879 to avoid shadowing.
13880 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13881
7e3ab302
PE
13882 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13883 so that the caller can use some name other than gcpro1.
13884 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13885 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13886 (Fx_backspace_delete_keys_p):
13887 Use them to avoid shadowing, and rename vars to avoid shadowing.
13888 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13889 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13890 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13891 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13892 Remove unused locals.
7e3ab302
PE
13893 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13894 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13895 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13896 macros.
f78faa98 13897
e2b13473
PE
13898 * xterm.h (x_mouse_leave): New decl.
13899
77f23912
PE
13900 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13901 Remove unused functions.
cdf4ba58
PE
13902 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13903 (x_calc_absolute_position): Now static.
7411c686 13904 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13905 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13906 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13907 unless they are used.
38d0b34a
PE
13908 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13909 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13910 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13911 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13912 (x_error_catcher, x_connection_closed, x_error_handler):
13913 (x_error_quitter, xembed_send_message, x_iconify_frame):
13914 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13915 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13916 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13917
44f230aa
SM
13918 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13919 Rename or move locals to avoid shadowing.
6b463e58 13920 (tty_defined_color, merge_face_heights): Now static.
5967d051 13921 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13922 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13923 does not deduce is never used uninitialized.
73719eba
PE
13924 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13925 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13926
426994c3 13927 * terminal.c (store_terminal_param): Now static.
5489860b 13928
032f1620 13929 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13930 (set_frame_menubar): Remove unused local.
d4323972 13931 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13932 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13933 since they might point to immutable storage.
281585b0
PE
13934 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13935 since it's unused otherwise.
032f1620 13936
367c19e5 13937 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13938 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13939 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13940 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13941 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13942 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13943 does not deduce are never used uninitialized.
70739cbe 13944
07b48fa9
PE
13945 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13946
8868a238 13947 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13948 * window.c (window_loop, size_window):
13949 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13950
7e5cf297 13951 * window.c (display_buffer): Now static.
d6550a9f
PE
13952 (size_window): Mark variables that gcc -Wuninitialized
13953 does not deduce are never used uninitialized.
a586633d
PE
13954 * window.h (check_all_windows): New decl, to forestall
13955 gcc -Wmissing-prototypes diagnostic.
5b555da1 13956 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13957
f6095868
PE
13958 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13959 shadowing.
13960 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13961 Include <limits.h>.
13962 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13963 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13964 (load_charset_map): Mark variables that gcc -Wuninitialized
13965 does not deduce are never used uninitialized.
53df7c11 13966 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13967
f38b440c
PE
13968 * coding.c (coding_set_source, coding_set_destination):
13969 Use "else { /* comment */ }" rather than "else /* comment */;"
13970 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13971 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13972 a block, when the outer 'i' will do.
13973 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13974 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13975 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13976 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13977 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13978 Rename locals to avoid shadowing.
13979 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13980 * coding.c (emacs_mule_char, encode_invocation_designation):
13981 Now static, since they're not used elsewhere.
413bb2db 13982 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13983 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13984 (decode_coding_emacs_mule): Mark variables that gcc
13985 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13986 (detect_coding_iso_2022): Initialize a local variable that might
13987 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13988 this initialization is needed. (Bug#8211)
5f58e762
PE
13989 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13990 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13991 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13992 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13993 Remove unused macros.
f38b440c 13994
232b38b9 13995 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13996 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13997 * character.c (string_count_byte8): Likewise.
232b38b9 13998
fb90da1b
PE
13999 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14000 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14001
fb93dbc2
PE
14002 * chartab.c (copy_sub_char_table): Now static, since it's not used
14003 elsewhere.
5c156ace
PE
14004 (sub_char_table_ref_and_range, char_table_ref_and_range):
14005 Rename locals to avoid shadowing.
bbcd0949 14006 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14007
7d3b3862 14008 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14009 (BIDI_BOB): Remove unused macro.
7d3b3862 14010
6be7d3da
PE
14011 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14012 deduce are never used uninitialized.
c2ed9c8b 14013 * term.c (encode_terminal_code): Likewise.
6be7d3da 14014
75f8807f 14015 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14016
50938595
PE
14017 * tparam.h: New file.
14018 * term.c, tparam.h: Include it.
14019 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14020 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14021 Move these decls to tparam.h, and make them agree with what
14022 is actually in tparam.c. The previous trick of using incompatible
14023 decls in different modules does not conform to the C standard.
14024 All callers of tparam changed to use tparam's actual API.
14025 * tparam.c (tparam1, tparam, tgoto):
14026 Use const pointers where appropriate.
14027
fbceeba2
PE
14028 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14029 * cm.h (struct cm): Likewise.
14030 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14031 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14032 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14033 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14034 (turn_on_face, init_tty): Likewise.
14035 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14036
7f3f1250
PE
14037 * term.c (term_mouse_position): Rename local to avoid shadowing.
14038
e6ca6543
PE
14039 * alloc.c (mark_ttys): Move decl from here ...
14040 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14041
c40f8d15
AS
140422011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14043
14044 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14045
cfe0661d
JB
140462011-03-09 Juanma Barranquero <lekktu@gmail.com>
14047
14048 * search.c (compile_pattern_1): Remove argument regp, unused since
14049 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14050 (compile_pattern): Don't pass it.
14051
0afb4571
J
140522011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14053
14054 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14055 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14056 for ! HAVE_GTK3.
14057 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14058
14059 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14060
14061 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14062 gdk_window_get_screen, gdk_window_get_geometry,
14063 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14064 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14065 (xg_get_pixbuf_from_pixmap): New function.
14066 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14067 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14068 Call xg_get_pixbuf_from_pixmap instead of
14069 gdk_pixbuf_get_from_drawable.
14070 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14071 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14072 (xg_check_special_colors): Use GtkStyleContext and its functions
14073 for HAVE_GTK3.
14074 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14075 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14076 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14077 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14078 Call gtk_widget_get_preferred_size.
0afb4571
J
14079 (xg_frame_resized): gdk_window_get_geometry only takes 5
14080 parameters.
44f230aa
SM
14081 (xg_win_to_widget, xg_event_is_for_menubar):
14082 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14083 (xg_set_widget_bg): New function.
14084 (delete_cb): New function.
895009e1 14085 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14086 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14087 (xg_set_background_color): Call xg_set_widget_bg.
14088 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14089 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14090 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14091 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14092 if ! HAVE_GTK3.
14093 (update_frame_tool_bar): Call gtk_widget_hide.
14094 (xg_initialize): Use GDK_KEY_g.
14095
14096 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14097 if ! HAVE_GTK3
14098 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14099
14100 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14101 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14102 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14103
1c2cc4ef
JB
141042011-03-08 Juanma Barranquero <lekktu@gmail.com>
14105
14106 * w32xfns.c (select_palette): Check success of RealizePalette against
14107 GDI_ERROR, not zero.
14108
33383987 14109See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14110
14111;; Local Variables:
14112;; coding: utf-8
aac0c6e3
MR
14113;; End:
14114
2f097256 14115 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14116
14117 This file is part of GNU Emacs.
14118
14119 GNU Emacs is free software: you can redistribute it and/or modify
14120 it under the terms of the GNU General Public License as published by
14121 the Free Software Foundation, either version 3 of the License, or
14122 (at your option) any later version.
14123
14124 GNU Emacs is distributed in the hope that it will be useful,
14125 but WITHOUT ANY WARRANTY; without even the implied warranty of
14126 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14127 GNU General Public License for more details.
14128
14129 You should have received a copy of the GNU General Public License
14130 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.