Fix an error message glitch in network-stream.el.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5b43da69
GM
12012-01-10 Glenn Morris <rgm@gnu.org>
2
7d8d6e4e
GM
3 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4 Update template values to be closer to their typical values these days.
5b43da69 5
a0db8d43
EZ
62012-01-09 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (rows_from_pos_range): Accept additional argument
9 DISP_STRING, and accept any glyph in a row whose object is that
10 string as eligible for mouse highlight. Fixes mouse highlight of
11 display strings from overlays. (Bug#10464)
12
9a0115ab 132012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 14
b9110d6a 15 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
16 * fileio.c (auto_saving_dir_umask): New static var.
17 (Fmake_directory_internal): Use it.
18 (do_auto_save_make_dir): Set it, instead of invoking chmod after
19 creating the directory. The old code temporarily assigns
20 too-generous permissions to the directory.
21 (do_auto_save_eh): Clear it.
b9110d6a 22 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
23 that the var is always cleared.
24
6c1bd3f3
EZ
252012-01-07 Eli Zaretskii <eliz@gnu.org>
26
27 * search.c (scan_buffer): Pass character positions to
28 know_region_cache, not byte positions. (Bug#6540)
29
069d2b50
L
302012-01-07 LynX <_LynX@bk.ru> (tiny change)
31
32 * w32.c (sys_rename): Report EXDEV when rename of a directory
33 fails because the target is on another logical disk. (Bug#10284)
34
75bf0d33
DB
352012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
36
37 * xterm.c (x_embed_request_focus): New function.
38
39 * xterm.h: Add prototype.
40
41 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
42
1c6e5a32
GM
432012-01-05 Glenn Morris <rgm@gnu.org>
44
45 * emacs.c (emacs_copyright): Update short copyright year to 2012.
46
651e947e
EZ
472012-01-01 Eli Zaretskii <eliz@gnu.org>
48
49 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
50 Load gnutls_transport_set_lowat only if GnuTLS version is below
51 2.11.1.
52 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
53 GnuTLS versions below 2.11.1.
54
3778cdd8
AL
552011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
56
57 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
58 to the doc string advising against its use for altering the way
59 windows are scrolled.
60
0e5317f7
KH
612011-12-28 Kenichi Handa <handa@m17n.org>
62
63 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
64 coding-system ASCII compatible only when it does not produce BOM
65 on encoding (Bug#10383).
66
93d5ca1f
JD
672011-12-26 Jan Djärv <jan.h.d@swipnet.se>
68
69 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
70 can scroll.
71 (create_and_show_popup_menu): Always use menu_position_func for
72 Gtk3 (Bug#10361).
73
ca22b785
AS
742011-12-24 Andreas Schwab <schwab@linux-m68k.org>
75
76 * callint.c (Fcall_interactively): Don't truncate prompt string.
77
d048e1e6
EZ
782011-12-23 Eli Zaretskii <eliz@gnu.org>
79
80 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
81 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 82 resumed from there (after widening). (Bug#10360)
d048e1e6 83
5ccaba1f
JD
842011-12-22 Jan Djärv <jan.h.d@swipnet.se>
85
86 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
87
204ee57f
JD
882011-12-21 Jan Djärv <jan.h.d@swipnet.se>
89
b81d40f0
JB
90 * nsterm.m (x_free_frame_resources):
91 Release f->output_data.ns->miniimage.
204ee57f
JD
92 (ns_index_color): Fix indentation. Do not retain
93 color_table->colors[i].
94
95 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
96 before returning.
97
98 * nsfns.m (x_set_background_color): Assign return value from
99 ns_index_color to face-background instead of NSColor*.
100 (ns_implicitly_set_icon_type): Fix indentation.
101 Change assignment in for loop to comparison.
102
103 * emacs.c (ns_pool): New variable.
104 (main): Assign ns_pool.
105 (Fkill_emacs): Call ns_release_autorelease_pool.
106
107 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
108 autorelease fdesc, release fdAttrs and tdict.
109 (ns_get_covering_families): Release charset.
110 (ns_findfonts): Release NSFontDescriptor created with new.
111 (ns_uni_to_glyphs): Fix indentation.
112 (setString): Release attrStr before assigning new value.
113
c803b2b7
JD
1142011-12-18 Jan Djärv <jan.h.d@swipnet.se>
115
678f4426
JD
116 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
117 and NS_IMPL_COCOA.
118 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
119 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
120
1212011-12-18 David Reitter <reitter@cmu.edu>
122
5fecd5fc
JD
123 * nsterm.m (ns_term_init): Subscribe for notifications
124 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
125 to method trackingNotification in EmacsMenu.
126
127 * nsmenu.m (trackingMenu): New variable.
3771cb17 128 (trackingNotification): New method (from Aquamacs).
5fecd5fc 129 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 130 from Aquamacs (Bug#7030).
678f4426
JD
131
1322011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 133
c803b2b7
JD
134 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
135 (symbol_to_nsstring): Fix indentation.
136 (ns_symbol_to_pb): New function.
137 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
138 (Fns_rotate_cut_buffers_internal): Removed.
139 (Fns_store_selection_internal): Renamed from
140 Fns_store_cut_buffer_internal.
141 (ns_get_foreign_selection, Fx_own_selection_internal)
142 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
143 (Fns_get_selection_internal, Fns_store_selection_internal):
144 Use ns_symbol_to_pb and check if return value is nil.
145 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
146 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
147 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
148 renamed to Sns_store_selection_internal.
149 (ns_handle_selection_request): Move code to Fx_own_selection_internal
150 and remove this function.
151 (ns_handle_selection_clear): Remove, never used.
152 (Fx_own_selection_internal): Move code from ns_handle_selection_request
153 here.
154
e1b01a3a
KB
1552011-12-17 Ken Brown <kbrown@cornell.edu>
156
157 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
158 GID is unknown (Bug#10257).
159
2adb6e85
PE
1602011-12-17 Paul Eggert <eggert@cs.ucla.edu>
161
162 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
163 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
164 which caused a build failure on GNU/Linux IA-64. This problem was
165 introduced by my 2011-10-07 patch.
166
d1d7b339
JL
1672011-12-15 Juri Linkov <juri@jurta.org>
168
169 * image.c (imagemagick_error): New function. (Bug#10112)
170 (imagemagick_load_image): Comment out `MagickSetResolution' call.
171 Use `imagemagick_error' where ImageMagick functions return
172 `MagickFalse'.
173 (Fimagemagick_types): Add `Fnreverse' to return the list in the
174 proper order.
175
100d5755
KH
1762011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
177
178 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
179 fill background (Bug#8992).
180
454592a6
MR
1812011-12-13 Martin Rudalics <rudalics@gmx.at>
182
183 * window.c (Vwindow_combination_resize)
184 (Vwindow_combination_limit): Use t instead of non-nil in
185 doc-strings.
61d4b438
MR
186 (Vrecenter_redisplay): Add first sentence of doc-string on
187 separate line.
53524d93 188 (Frecenter): Fix doc-string typo.
454592a6 189
3633e3aa
KH
1902011-12-11 Kenichi Handa <handa@m17n.org>
191
192 * coding.c (Funencodable_char_position): Pay attention to the
193 buffer text relocation (Bug#9389).
194
7b9d523a
JD
1952011-12-10 Jan Djärv <jan.h.d@swipnet.se>
196
197 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
198 gtk_init (Bug#10100).
199
b73189c6
EZ
2002011-12-10 Eli Zaretskii <eliz@gnu.org>
201
202 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
203 IT->string is nil. (Bug#10263)
204
f7dfe5d6
JD
2052011-12-10 Jan Djärv <jan.h.d@swipnet.se>
206
83faebb4
JD
207 * nsterm.h (x_free_frame_resources): Declare.
208
f7dfe5d6
JD
209 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
210 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
211
212 * nsterm.h (ns_get_defaults_value): Declare.
213
214 * nsterm.m (ns_default): Call ns_get_defaults_value.
215
7cd4e72c
EZ
2162011-12-09 Eli Zaretskii <eliz@gnu.org>
217
218 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
219 (Bug#10170)
220
b34d7317
YM
2212011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
222
223 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
224 that where the value of an _OBJC_* symbol points to is in the .bss
225 section (Bug#10240).
226
76470ad1
KH
2272011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
228
229 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 230 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 231
745fff94
KH
2322011-12-08 Kenichi Handa <handa@m17n.org>
233
234 * ftfont.c (get_adstyle_property): Fix previous change
235 (Bug#10233).
236
6e44397c
JB
2372011-12-07 Juanma Barranquero <lekktu@gmail.com>
238
239 * w32.c (init_environment): If no_site_lisp, remove site-lisp
240 dirs from the default value of EMACSLOADPATH (bug#10208).
241
7efa6272
GM
2422011-12-07 Glenn Morris <rgm@gnu.org>
243
244 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
245 installation and source directories as well. (Bug#10208)
246
f6fc4d87
CY
2472011-12-06 Chong Yidong <cyd@gnu.org>
248
249 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
250
2bf26180
GM
2512011-12-06 Glenn Morris <rgm@gnu.org>
252
253 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
254 as an error, not just -1. (Bug#10217)
255
3a6ad4f0
CY
2562011-12-05 Chong Yidong <cyd@gnu.org>
257
258 * keyboard.c (process_special_events): New function.
259 (swallow_events, Finput_pending_p): Use it (Bug#10195).
260
75a3b399
PE
2612011-12-05 Paul Eggert <eggert@cs.ucla.edu>
262
263 * coding.c (encode_designation_at_bol): Don't use uninitialized
264 local variable (Bug#9318).
265
c3c9e25e
KH
2662011-12-05 Kenichi Handa <handa@m17n.org>
267
268 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
269 return Qnil (Bug#8046, Bug#10193).
270
5eb05ea3
KH
2712011-12-05 Kenichi Handa <handa@m17n.org>
272
273 * coding.c (encode_designation_at_bol): New args charbuf_end and
274 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
275 (coding_set_source): Return how many bytes coding->source was
276 relocated.
277 (coding_set_destination): Return how many bytes
278 coding->destination was relocated.
279 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
280 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
281
2822011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
283
284 * coding.c (CODING_CHAR_CHARSET_P): New macro.
285 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
286 macro (Bug#9318).
287
2882011-12-05 Andreas Schwab <schwab@linux-m68k.org>
289
290 The following changes are to fix Bug#9318.
291
a79703f5 292 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
293 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
294 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 295 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 296
7dbda6df
JB
2972011-12-05 Juanma Barranquero <lekktu@gmail.com>
298
299 * lisp.h (process_quit_flag): Fix external declaration.
300
6d5eb5b0
SM
3012011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
302
303 Don't macro-inline non-performance-critical code.
304 * eval.c (process_quit_flag): New function.
305 * lisp.h (QUIT): Use it.
306
a0c3fad0
JD
3072011-12-04 Jan Djärv <jan.h.d@swipnet.se>
308
309 * nsfns.m (get_geometry_from_preferences): New function.
310 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
311
6c07aac2
AS
3122011-12-04 Andreas Schwab <schwab@linux-m68k.org>
313
314 * emacs.c (Qkill_emacs): Define.
315 (syms_of_emacs): Initialize it.
316 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
317 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
318 (quit_throw_to_read_char): Add parameter `from_signal'.
319 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
320 * lisp.h (QUIT): Call Fkill_emacs if requested.
321
c052ead4
JD
3222011-12-03 Jan Djärv <jan.h.d@swipnet.se>
323
324 * widget.c (update_wm_hints): Return if wmshell is null.
325 (widget_update_wm_size_hints): New function.
326
327 * widget.h (widget_update_wm_size_hints): Declare.
328
329 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
330 widget_update_wm_size_hints (Bug#10104).
331
9e49252b
EZ
3322011-12-03 Eli Zaretskii <eliz@gnu.org>
333
334 * xdisp.c (handle_invisible_prop): If the invisible text ends just
335 before a newline, prepare the bidi iterator for consuming the
336 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 337 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 338
02b16839
JL
3392011-12-02 Juri Linkov <juri@jurta.org>
340
341 * search.c (Fword_search_regexp): New Lisp function created from
342 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
343 (Fword_search_backward, Fword_search_forward)
344 (Fword_search_backward_lax, Fword_search_forward_lax):
345 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
346 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
347
0068070e
SM
3482011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
349
350 * fileio.c (Finsert_file_contents): Move after-change-function call
351 to before the "handled:" label, since all "goto handled" appear in
352 cases where the *-change-functions have already been properly called
353 (bug#10117).
354
3360a3fc
AS
3552011-12-01 Andreas Schwab <schwab@linux-m68k.org>
356
357 * keyboard.c (interrupt_signal): Don't call kill-emacs when
358 waiting for input. (Bug#10169)
359
73d6c093
EZ
3602011-11-30 Eli Zaretskii <eliz@gnu.org>
361
362 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
363 verifies glyph row's hash code--we have just reallocated the
364 glyphs, so their contents can be complete garbage. (Bug#10164)
365
febe6bea
JB
3662011-11-30 Juanma Barranquero <lekktu@gmail.com>
367
368 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
369
801a4313
EZ
3702011-11-30 Eli Zaretskii <eliz@gnu.org>
371
372 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
373 attributes are tested _before_ calling verify_row_hash, to protect
374 against GCC re-ordering of the tests. (Bug#10164)
375
2b56b87e
JD
3762011-11-29 Jan Djärv <jan.h.d@swipnet.se>
377
378 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
379
380 * xterm.c (handle_one_xevent): Only set async_visible and friends
381 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 382 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
383 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
384
dbf31225
PE
3852011-11-28 Paul Eggert <eggert@cs.ucla.edu>
386
387 Remove GCPRO-related macros that exist only to avoid shadowing locals.
388 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
389 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
390 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
391 All uses changed to use GCPRO1 etc.
392 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
393 Revert to old implementation (i.e., before 2011-03-11).
394
1305621b
YM
3952011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
396
397 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
398 of scroll runs so as to avoid assigning disabled bogus rows and
399 unnecessary graphics copy operations.
400
8c9afb46
EZ
4012011-11-27 Eli Zaretskii <eliz@gnu.org>
402
403 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
404 (snprintf) [_MSC_VER]: Redirect to _snprintf.
405 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
406 (malloc, free, realloc, calloc): Redirect to e_* only when
407 compiling Emacs.
408
409 * lisp.h (GCTYPEBITS): Move before first use.
410 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
411 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
412 this macro definition.
413
414 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
415 _MSC_VER.
416
54e9e3bf
JD
4172011-11-27 Jan Djärv <jan.h.d@swipnet.se>
418
6d5eb5b0
SM
419 * gtkutil.c (xg_create_frame_widgets):
420 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
421 present with Gtk+ 2.0.
422
83aca1cb
PE
4232011-11-26 Paul Eggert <eggert@cs.ucla.edu>
424
425 * fileio.c (Finsert_file_contents): Undo previous change; see
426 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
427
5b76caa4
PE
4282011-11-26 Paul Eggert <eggert@cs.ucla.edu>
429
430 Rename locals to avoid shadowing.
431 * fileio.c (Finsert_file_contents):
432 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
433 * process.c (wait_reading_process_output):
434 Rename inner 'proc' to 'p' to avoid shadowing.
435 Indent for consistency with usual Emacs style.
436
8c535114
EZ
4372011-11-25 Eli Zaretskii <eliz@gnu.org>
438
439 * xdisp.c (redisplay_window): If cursor row is not fully visible
440 after recentering, and scroll-conservatively is set to a large
441 number, scroll window by a few more lines to make the cursor fully
442 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
443 (start_display): Don't move to the next line if the display should
444 start at a newline that is part of a display vector or an overlay
445 string. (Bug#10119)
8c535114 446
fa4fdb5c
JL
4472011-11-24 Juri Linkov <juri@jurta.org>
448
449 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
450 after the `MagickPingImage' call. (Bug#10112)
451
90ec88df
CY
4522011-11-23 Chong Yidong <cyd@gnu.org>
453
454 * window.c (Fcoordinates_in_window_p): Accept only live windows.
455
56e2e794
MR
4562011-11-23 Martin Rudalics <rudalics@gmx.at>
457
458 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
459 making another buffer current. (Bug#10114)
460
b6e64c41
GM
4612011-11-23 Glenn Morris <rgm@gnu.org>
462
463 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
464
6b21de18
CY
4652011-11-23 Chong Yidong <cyd@gnu.org>
466
467 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
468 using it (Bug#5984).
469
b12cd789
EZ
4702011-11-22 Eli Zaretskii <eliz@gnu.org>
471
472 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
473 and header-lines, as they don't have one computed for them.
474 (Bug#10098)
475
476 * .gdbinit (prow): Make displayed values more self-explaining.
477 Add row's hash code.
478
261b6fd4
LMI
4792011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
480
481 * process.c (wait_reading_process_output): Fix asynchrounous
482 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 483 (wait_reading_process_output): Add comment and URL.
261b6fd4 484
e7cfd277
JD
4852011-11-21 Jan Djärv <jan.h.d@swipnet.se>
486
487 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
488
a9b9b7f5
CY
4892011-11-21 Chong Yidong <cyd@gnu.org>
490
491 * window.c (Fnext_window, Fprevious_window): Doc fix.
492
b0d15b4f
SM
4932011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
494
495 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
496
fe7a3057
JB
4972011-11-20 Juanma Barranquero <lekktu@gmail.com>
498
499 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
500
d2999b1a
MR
5012011-11-20 Martin Rudalics <rudalics@gmx.at>
502
503 * window.c (Fset_window_combination_limit): Rename argument
504 STATUS to LIMIT.
505 (Vwindow_combination_limit): Remove "status" from doc-string.
506
d5ff9cd0
AS
5072011-11-20 Andreas Schwab <schwab@linux-m68k.org>
508
509 * m/ibms390.h: Remove.
510 * m/ibms390x.h: Don't include "ibms390.h".
511
a5bb9bd3
SM
5122011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
513
514 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
515 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
516
cd1181db
JB
5172011-11-20 Juanma Barranquero <lekktu@gmail.com>
518
519 * casetab.c (Fset_case_table):
520 * charset.c (Fcharset_after): Fix typos.
521
615a3b8d 5222011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 523
17e845af
PE
524 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
525 Otherwise, valgrind does not work on some platforms.
526 Problem reported by Andreas Schwab in
6a0bf43d
PE
527 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
528 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
529 is set, removing the need for VIRT_ADDRESS_VARIES.
530 (PURE_P): Use a more-efficient implementation that needs just one
531 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
532 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
533 to 4 (xorl, subq, cmpq, setbe).
534 * alloc.c (pure): Always extern now, since that's the
535 VIRT_ADDR_VARIES behavior.
536 (PURE_POINTER_P): Use a single comparison, not two, for
537 consistency with the new puresize.h.
538 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
539 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
540 Remove VIRT_ADDR_VARIES no longer needed.
541
f8fe6f96
EZ
5422011-11-19 Eli Zaretskii <eliz@gnu.org>
543
544 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
545 (erase_phys_cursor, update_window_cursor, show_mouse_face)
546 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
547 behave as if the cursor position were at the window margin.
548
549 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
550 and the cursor position is out of bounds, behave as if the cursor
551 position were at the window margin. (Bug#10075)
552
df05a53c
CY
5532011-11-18 Chong Yidong <cyd@gnu.org>
554
555 * window.c (Fwindow_combination_limit): Make first argument
556 non-optional, since it is meaningless for live windows like the
557 selected window.
558
2071918e
DA
5592011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
560
561 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
562
b50a28de
SM
5632011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
564
565 * intervals.c: Fix grafting over the whole buffer (bug#10071).
566 (graft_intervals_into_buffer): Simplify.
567
015137db
EZ
5682011-11-18 Eli Zaretskii <eliz@gnu.org>
569
570 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
571 hash values of the two rows.
572 (copy_row_except_pointers): Preserve the used[] arrays and the
573 hash values of the two rows. (Bug#10035)
68c95424 574 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
575
576 * xdisp.c (row_hash): New function, body extracted from
577 compute_line_metrics.
578 (compute_line_metrics): Call row_hash, instead of computing the
579 hash code inline.
580
581 * dispnew.c (verify_row_hash): Call row_hash for computing the
582 hash code of a row, instead of duplicating code from xdisp.c.
583
584 * dispextern.h (row_hash): Add prototype.
585
a2addb04
TH
5862011-11-18 Tassilo Horn <tassilo@member.fsf.org>
587
588 * frame.c (delete_frame): Don't delete the terminal when the last
589 X frame is closed if emacs is built with GTK toolkit.
590
df85d315
JB
5912011-11-17 Juanma Barranquero <lekktu@gmail.com>
592
593 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
594
a0c2d0ae
MR
5952011-11-17 Martin Rudalics <rudalics@gmx.at>
596
597 * window.c (Vwindow_splits): Rename to
598 Vwindow_combination_resize. Suggested by Juri Linkov.
599 (Fsplit_window_internal): Use Vwindow_combination_resize instead
600 of Vwindow_splits.
601
58179cce
JB
6022011-11-16 Juanma Barranquero <lekktu@gmail.com>
603
7877f373
JB
604 * nsfns.m (Fns_font_name):
605 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 606
b6f67890
MR
6072011-11-16 Martin Rudalics <rudalics@gmx.at>
608
609 * window.h (window): Rename slot "nest" to "combination_limit".
610 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
611 (Fset_window_nest): Rename to Fset_window_combination_limit.
612 (Vwindow_nest): Rename to Vwindow_combination_limit.
613 (recombine_windows, make_parent_window, make_window)
614 (Fsplit_window_internal, saved_window)
615 (Fset_window_configuration, save_window_save): Rename all
616 occurrences of window_nest to window_combination_limit.
617
c7015153
JB
6182011-11-15 Juanma Barranquero <lekktu@gmail.com>
619
620 * image.c (imagemagick_load_image): Fix typo.
621
322ad6ec
EZ
6222011-11-14 Eli Zaretskii <eliz@gnu.org>
623
624 * xdisp.c (display_line): Move the call to
625 highlight_trailing_whitespace before the call to
626 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
627 faces of all the glyphs to compute ROW's hash value.
628 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 629
f067b8ec
JB
6302011-11-14 Juanma Barranquero <lekktu@gmail.com>
631
632 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
633 just return (bug#10044).
634
1e5b2111
EZ
6352011-11-12 Eli Zaretskii <eliz@gnu.org>
636
7ef3cbd5
EZ
637 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
638 with user-defined heap size. Bump the default size of the temacs
639 heap to 27MB, to avoid memory warning when running temacs.
640 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
641
1e5b2111
EZ
642 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
643 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
644 (verify_row_hash) [XASSERTS]: New function.
645 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
646 that the hash value of glyph rows is correct.
1e5b2111 647
89d61221
MR
6482011-11-12 Martin Rudalics <rudalics@gmx.at>
649
650 * window.h (window): Remove splits slot.
651 * window.c (Fwindow_splits, Fset_window_splits): Remove.
652 (Fdelete_other_windows_internal, make_parent_window)
653 (make_window, Fsplit_window_internal, Fdelete_window_internal)
654 (Fset_window_configuration, save_window_save): Don't deal with
655 split status of windows.
656 (saved_window): Remove splits slot.
657 (Vwindow_splits): Rewrite doc-string.
658
97f18cc8
JD
6592011-11-11 Jan Djärv <jan.h.d@swipnet.se>
660
661 * xfns.c (unwind_create_frame):
662 * nsfns.m (unwind_create_frame):
663 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
664 Vframe_list (Bug#9999).
665
22a648b4
DA
6662011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
667
0b381c7e 668 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 669
659afede
KH
6702011-11-11 Kenichi Handa <handa@m17n.org>
671
672 * callproc.c (Fcall_process): Set the member dst_multibyte of
673 process_coding.
674
9ac0394b
KH
6752011-11-11 Johan Bockgård <bojohan@gnu.org>
676
677 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
678 avoid a crash (bug#9496).
679
2fbdc249
CY
6802011-11-09 Chong Yidong <cyd@gnu.org>
681
682 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
683 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
684
ac6b1f81
PE
6852011-11-08 Paul Eggert <eggert@cs.ucla.edu>
686
687 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
688
09db192c
PE
6892011-11-08 Paul Eggert <eggert@cs.ucla.edu>
690
691 Avoid some portability problems by eschewing 'extern inline' functions.
692 The trivial performance wins aren't worth the portability hassles; see
693 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
694 et seq.
695 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
696 (window_box_width, window_box_left, window_box_left_offset)
697 (window_box_right, window_box_right_offset): Undo previous change,
698 by removing the "extern"s.
699 * intervals.c (adjust_intervals_for_insertion)
700 (adjust_intervals_for_deletion): Undo previous change,
701 making these static again.
702 (offset_intervals, temp_set_point_both, temp_set_point)
703 (copy_intervals_to_string): No longer inline.
704 * xdisp.c (window_text_bottom_y, window_box_width)
705 (window_box_height, window_box_left_offset)
706 (window_box_right_offset, window_box_left, window_box_right)
707 (window_box): No longer inline.
708
105216ed
CY
7092011-11-08 Chong Yidong <cyd@gnu.org>
710
711 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
712 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
713 Signal an error if not a live window.
105216ed
CY
714 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
715 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
716
ae9e237f
JB
7172011-11-07 Juanma Barranquero <lekktu@gmail.com>
718
719 * lisp.h (syms_of_abbrev): Remove declaration.
720 Reported by CHENG Gao <chenggao@royau.me>.
721
c7aa8333
EZ
7222011-11-07 Eli Zaretskii <eliz@gnu.org>
723
724 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
725 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
726 of temacs in GUI mode.
727
be7f5545
MR
7282011-11-07 Martin Rudalics <rudalics@gmx.at>
729
730 * window.h: Declare delete_all_child_windows instead of
731 delete_all_subwindows.
732 * window.c (Fwindow_nest, Fset_window_nest)
733 (Fset_window_new_total, Fset_window_new_normal)
734 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
735 (delete_all_subwindows): Rename to delete_all_child_windows.
736 (Fdelete_other_windows_internal, Fset_window_configuration):
737 Call delete_all_child_windows instead of delete_all_subwindows.
738 * frame.c (delete_frame): Call delete_all_child_windows instead
739 of delete_all_subwindows.
740
ca78dc43
PE
7412011-11-07 Paul Eggert <eggert@cs.ucla.edu>
742
743 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
744 This is also needed for porting to any host where GC_MARK_STACK is
745 not GC_MAKE_GCPROS_NOOPS.
746 (which_symbols): Use it.
747
a0241d01
KH
7482011-11-07 Kenichi Handa <handa@m17n.org>
749
750 * coding.c (coding_set_destination): Check coding->src_pos only
751 when coding->src_object is a buffer (bug#9910).
752
753 * process.c (send_process): Set the member src_multibyte of coding
754 to 0 (bug#9911) when sending a unibyte text.
755
756 * callproc.c (Fcall_process): Set the member src_multibyte of
757 process_coding to 0 (bug#9912).
758
a64bfdfa 7592011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
760
761 * xmenu.c (cleanup_widget_value_tree): New function.
762 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
763 calling free_menubar_widget_value_tree directly (Bug#9830).
764
cb41b32a
PE
7652011-11-06 Paul Eggert <eggert@cs.ucla.edu>
766
767 Fix some portability problems with 'inline'.
768 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
769 (window_box_width, window_box_left, window_box_left_offset)
770 (window_box_right, window_box_right_offset): Declare extern.
771 Otherwise, these inline functions do not conform to C99 and
772 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
773 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
774 * intervals.c (adjust_intervals_for_insertion)
775 (adjust_intervals_for_deletion): Now extern, because otherwise the
776 extern inline functions 'offset_intervals' couldn't refer to it.
777 (static_offset_intervals): Remove.
778 (offset_intervals): Rewrite using the old contents of
779 static_offset_intervals. The old version didn't conform to C99
780 because an extern inline function contained a reference to an
781 identifier with static linkage.
782
b7041366
AS
7832011-11-06 Andreas Schwab <schwab@linux-m68k.org>
784
785 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
786 GC.
787
88a37c4d
EZ
7882011-11-06 Eli Zaretskii <eliz@gnu.org>
789
790 * xdisp.c (init_iterator, reseat_to_string): Don't set the
791 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
792 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
793 return Qleft_to_right.
794
49745b39
CY
7952011-11-06 Chong Yidong <cyd@gnu.org>
796
797 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
798 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
799 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
800 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
801 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
802 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
803 (Fwindow_vscroll): Doc fix.
804 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
805 argument, since it makes no sense to pass a live window and for
806 consistency with window-child.
807
1f05cd82
CS
8082011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
809
810 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
811 support MSVC.
812
22610910
JR
8132011-11-05 Jason Rumney <jasonr@gnu.org>
814
815 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
816 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
817 fonts (Bug#6029).
818 (add_font_entity_to_list): Fix logic errors in mixed boolean and
819 bitwise arithmetic preventing use of unicode-sip and non-truetype
820 opentype fonts.
821
a06776b2
EZ
8222011-11-05 Eli Zaretskii <eliz@gnu.org>
823
3ad924ba
EZ
824 * s/ms-w32.h (fstat, stat, utime): Move redirections to
825 "emacs"-only part.
826
a06776b2
EZ
827 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
828 initialization code to keep similarity to xfns.c after changes
829 from 2011-11-05.
830
c9e7db78
JD
8312011-11-05 Jan Djärv <jan.h.d@swipnet.se>
832
a97f8f3f
JD
833 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
834 (unwind_create_frame): New function (Bug#9943).
835 (Fx_create_frame): Restructure code to be more similar to the one in
836 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
837 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
838 Move terminal->reference_count++ just before making the frame official
839 (Bug#9943).
840
841 * nsterm.m (x_free_frame_resources): New function.
842 (x_destroy_window): Move code to x_free_frame_resources.
843
c9e7db78 844 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
845 (Fx_create_frame, x_create_tip_frame):
846 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
847 official. Move initialization of image_cache_refcount and
848 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
849
a6fc3b5c
EZ
8502011-11-05 Eli Zaretskii <eliz@gnu.org>
851
852 Support MSVC build with newer versions of Visual Studio.
853 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
854 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
855 nt/gmake.defs.
856
857 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
858 which are not supported by MSVC.
859 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
860 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
861 bitfields.
862 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
863 types in bitfields.
864 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
865
866 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
867
58179cce 8682011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
869
870 Support MSVC build with newer versions of Visual Studio.
871 * w32.c: Don't include w32api.h for MSVC.
872 (init_environment) [_MSC_VER]: Call sys_access, not _access.
873
874 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
875 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
876 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
877 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
878 e_* cousins.
879 (alloca) [_MSC_VER]: Define to _alloca.
880
881 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
882
883 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
884
a58c13ed
EZ
8852011-11-04 Eli Zaretskii <eliz@gnu.org>
886
887 * xdisp.c (note_mouse_highlight): If either of
888 previous/next-single-property-change returns nil, treat that as
889 the beginning or the end of the buffer. (Bug#9955)
890
fe0b6370
JD
8912011-11-04 Jan Djärv <jan.h.d@swipnet.se>
892
a58c13ed 893 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
894 label is not null (Bug#9951).
895 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
896 may be NULL.
897
89bd5ee1
EZ
8982011-11-04 Eli Zaretskii <eliz@gnu.org>
899
900 * window.c (Fwindow_body_size): Mention in the doc string that the
901 return value is in frame's canonical units. (Bug#9949)
902
84c3edb9
EZ
9032011-11-03 Eli Zaretskii <eliz@gnu.org>
904
4e2fb5c7
EZ
905 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
906
84c3edb9 907 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 908 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 909 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 910
bc17a887
EZ
9112011-11-01 Eli Zaretskii <eliz@gnu.org>
912
913 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
914 Don't stop backward scan on the continuation glyph, even though
915 its CHARPOS is positive.
6d5eb5b0
SM
916 (mouse_face_from_buffer_pos, note_mouse_highlight):
917 Rename cover_string to disp_string.
bc17a887 918
4ee88440
MR
9192011-11-01 Martin Rudalics <rudalics@gmx.at>
920
921 * window.c (temp_output_buffer_show): Don't use
922 Vtemp_buffer_show_specifiers.
923 (Vtemp_buffer_show_specifiers): Remove unused variable.
924
c2ff3c02
EZ
9252011-10-30 Eli Zaretskii <eliz@gnu.org>
926
927 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
928 past the beginning of the current glyph matrix.
929
58179cce 9302011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
931
932 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
933 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
934 HAVE_GTK3 (Bug#9869).
b77a6a7f 935
3b574623
JD
936 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
937 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
938
b77a6a7f
JD
939 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
940
941 * xterm.c: Declare x_handle_net_wm_state to return int.
942 (handle_one_xevent): Check if we are iconified but don't have
943 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
944 (get_current_wm_state): Return non-zero if not hidden,
945 check for _NET_WM_STATE_HIDDEN (Bug#9893).
946 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
947 (x_handle_net_wm_state): Return what get_current_wm_state returns.
948 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
949
196e41e4
PE
9502011-10-29 Paul Eggert <eggert@cs.ucla.edu>
951
952 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
953 so that this new function doesn't get optimized away by a
954 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
955
021f2e1a
AS
9562011-10-29 Andreas Schwab <schwab@linux-m68k.org>
957
958 * frame.h (MOUSE_HL_INFO): Remove excess parens.
959
8b058d44
EZ
9602011-10-29 Eli Zaretskii <eliz@gnu.org>
961
962 Fix the `xbytecode' command.
963 * .gdbinit (xprintbytestr): New command.
b50a28de 964 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
965 (xbytecode): Print the byte-code string as well.
966
4452fb80
EZ
9672011-10-29 Kim Storm <storm@cua.dk>
968
8b058d44
EZ
969 * alloc.c (which_symbols): New function.
970
21b72067
AS
9712011-10-29 Andreas Schwab <schwab@linux-m68k.org>
972
973 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
974 line. (Bug#9903)
975
83ed7b5c
GM
9762011-10-29 Glenn Morris <rgm@gnu.org>
977
978 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
979 Not clear what it was for, and it causes various bugs. (Bug#9839)
980
5a7a728b
EZ
9812011-10-28 Eli Zaretskii <eliz@gnu.org>
982
983 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
984 possible random value that matches one of those tested as
985 condition to clear the mouse face.
986
d3d0842f
CY
9872011-10-28 Chong Yidong <cyd@gnu.org>
988
989 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
990
31b39d13
DN
9912011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
992
993 * window.c (make_window): Initialize phys_cursor_on_p.
994
9aba6043
SM
9952011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
996
997 * lisp.h (struct Lisp_Symbol): Update comments.
998
c20992f4
JB
9992011-10-28 Juanma Barranquero <lekktu@gmail.com>
1000
1001 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1002
db4f02f2
EZ
10032011-10-28 Eli Zaretskii <eliz@gnu.org>
1004
1005 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1006 <oslsachem@gmail.com> for helping to debug this.
1007
1008 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1009 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1010 (g_b_init_get_glyph_outline_w): New static variables.
1011 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1012 (GetGlyphOutlineW_Proc): New typedefs.
1013 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1014 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1015 New functions.
1016 (w32font_open_internal, compute_metrics):
1017 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1018 instead of calling the "wide" APIs directly.
1019
1020 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1021
1022 * w32.h (syms_of_w32font): Add prototype.
1023
87e68db4
JB
10242011-10-27 Juanma Barranquero <lekktu@gmail.com>
1025
1026 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1027 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1028 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1029 (Fmove_to_window_line): Doc fix.
1030
435c1d67
CY
10312011-10-27 Chong Yidong <cyd@gnu.org>
1032
1033 * process.c (make_process): Set gnutls_state to NULL.
1034
1035 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1036 non-NULL, regardless of GNUTLS_INITSTAGE.
1037 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1038 an error. Set process slots as soon as we allocate them.
1039
1040 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1041
9c6c6f49
CY
10422011-10-27 Chong Yidong <cyd@gnu.org>
1043
9aba6043
SM
1044 * gnutls.c (emacs_gnutls_deinit): New function.
1045 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1046 (Fgnutls_deinit, Fgnutls_boot): Use it.
1047
1048 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1049 (deactivate_process): Call emacs_gnutls_deinit.
1050
657d08d3
JB
10512011-10-27 Juanma Barranquero <lekktu@gmail.com>
1052
1053 * image.c (x_create_x_image_and_pixmap):
1054 * w32.c (sys_rename, w32_delayed_load):
1055 * w32font.c (fill_in_logfont):
1056 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1057
5430d399
JB
10582011-10-26 Juanma Barranquero <lekktu@gmail.com>
1059
1060 * w32fns.c (w32_default_color_map): New function,
1061 extracted from Fw32_default_color_map.
a7ef684b 1062 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1063
fe0055fa
PE
10642011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1065
1066 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1067
e6346438
SM
10682011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1069
1070 * keyboard.c (test_undefined): New function (bug#9751).
1071 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1072
e112cc37
ET
10732011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1074
1075 * sysdep.c (init_sys_modes): Fix the check for the controlling
1076 terminal (Bug#6649).
1077
7b5d6677
EZ
10782011-10-20 Eli Zaretskii <eliz@gnu.org>
1079
1080 * dispextern.h (struct bidi_it): New member next_en_type.
1081
1082 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1083 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1084 current character, check also for next_en_type being WEAK_EN.
1085 (bidi_resolve_weak): Don't enter the expensive loop if the current
1086 position is before next_en_pos. Record the bidi type of the first
1087 non-ET, non-BN character we find, in addition to its position.
1088 (bidi_level_of_next_char): Invalidate next_en_type when
1089 next_en_pos is over-stepped.
1090
7da0b018
PE
10912011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1092
1093 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1094 * editfns.c: Rewrite current-time-zone so that it invokes
1095 the equivalent of (format-time-string "%Z") to get the time zone name.
1096 This fixes a bug when the time zone name contains characters that
1097 need converting from the system time locale to Emacs internal format.
1098 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1099 that patch fixed format-time-string to do the conversion, but
1100 I forgot to fix current-time-zone.
1101 (format_time_string): New function, containing most of
1102 what Fformat_time_string used to contain.
1103 (Fformat_time_string): Rewrite in terms of format_time_string.
1104 This doesn't change this function's behavior.
1105 (current-time-zone): Rewrite to use format_time_string.
1106 This fixes the bug reported by Michael Schierl in
1107 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1108 Jason Rumney's 2007-06-07 change worked around this bug, but
1109 didn't fix it.
1110 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1111
8547b010
EZ
11122011-10-19 Eli Zaretskii <eliz@gnu.org>
1113
1114 * xdisp.c (start_display): If the character at POS is displayed
1115 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1116 (try_window_reusing_current_matrix): If a line ends in a display
1117 vector or the next line starts in a display vector, continue
1118 redrawing the window even though the character position of
1119 start_row was reached.
8547b010
EZ
1120 (Bug#9771, part 2)
1121
4e948d15
CY
11222011-10-18 Chong Yidong <cyd@gnu.org>
1123
1124 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1125 with nobreak-char-display too.
1126
4787455f
EZ
11272011-10-18 Eli Zaretskii <eliz@gnu.org>
1128
1129 Fix part 3 of bug#9771.
1130 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1131 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1132 non-neutral characters if the current character is a paragraph
1133 separator (a.k.a. Newline). This avoids running the same
1134 expensive loop twice, once when we consume the preceding newline
1135 and the other time when the line actually needs to be displayed.
1136 Avoid the loop when we see neutrals on the base embedding level
1137 following a character whose directionality is the same as the
1138 paragraph's. This avoids running the expensive loop when a line
1139 ends in a long sequence of neutrals, like control characters.
1140 Add assertion against STRONG_AL type. Slightly rearrange code
1141 that determines the type of a neutral given the first non-neutral
1142 that follows it.
1143 (bidi_level_of_next_char): Set next_en_pos to zero when
1144 invalidating its info.
1145
2c91f553
EZ
11462011-10-17 Eli Zaretskii <eliz@gnu.org>
1147
1148 * xdisp.c (push_display_prop): Determine whether to record string
1149 or buffer position by IT->string, not by IT->method. Allow
1150 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1151 (move_it_vertically_backward): Don't look for character position
1152 immediately after the newline when in a continuation line.
1153 (Bug#9771, part 1)
2c91f553 1154
c7b08b0d
MR
11552011-10-15 Martin Rudalics <rudalics@gmx.at>
1156
1157 * window.c (coordinates_in_window): Rewrite and delabelize
1158 vertical border check. (Bug#5357) (Bug#9618)
1159
6b02f655
SM
11602011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1161
1162 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1163 errors in XSetWindowBorder (bug#9310).
1164
81d40c92
DA
11652011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1166
1167 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1168 avoid crash when xmalloc overrun checking is enabled.
1169
d4172c3b
EZ
11702011-10-13 Eli Zaretskii <eliz@gnu.org>
1171
1172 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1173 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1174 cursor motion with <left> and <right> arrow keys.
1175
1176 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1177 some callers set that themselves.
1178
b00eea75
EZ
11792011-10-12 Eli Zaretskii <eliz@gnu.org>
1180
1181 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1182 display string and the previous row comes from the same string and
1183 is empty. (Bug#9739) (Bug#9738)
1184
8fe012c4
SM
11852011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1186
1187 * doc.c (get_doc_string): Encode file name (bug#9735).
1188
0074aef2
EZ
11892011-10-12 Eli Zaretskii <eliz@gnu.org>
1190
79beb178
EZ
1191 * bidi.c (bidi_level_of_next_char):
1192 * xdisp.c (get_visually_first_element): Remove old incorrect
1193 comments regarding the Unicode Line Separator character.
1194
0074aef2
EZ
1195 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1196
6e4b3fbe
DA
11972011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1198
1199 * alloc.c (Fgc_status): Do not access beyond zombies array
1200 boundary if nzombies > MAX_ZOMBIES.
1201 * alloc.c (dump_zombies): Add missing format specifier.
1202
0324f3af
PE
12032011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1204
b5525cac
PE
1205 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1206 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1207
0324f3af
PE
1208 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1209 Some packages use them to denote characters with modifiers.
1210
e9b5f888
AS
12112011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1212
1213 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1214 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1215 matching a pp-number. Rename parameter var to var1.
1216
127827c0
SM
12172011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1218
1219 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1220
c8fd3bd0
GM
12212011-10-08 Glenn Morris <rgm@gnu.org>
1222
1223 * callint.c (Fcall_interactively): Give a more explicit error for the
1224 'c' case with a non-character input. (Bug#8479)
1225
352ec8ff
EZ
12262011-10-08 Eli Zaretskii <eliz@gnu.org>
1227
03669ccb
EZ
1228 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1229 lines.
7061c986
EZ
1230 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1231 lines that are hscrolled on the left.
03669ccb 1232
352ec8ff
EZ
1233 * dispnew.c (buffer_posn_from_coords): Account for a possible
1234 presence of header-line. (Bug#4426)
1235
a66cfb1c
SM
12362011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1237
6b02f655
SM
1238 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1239 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1240
7c5ee88e
PE
12412011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1242
1243 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1244 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1245 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1246 this makes Emacs dump core during garbage collection on rare
1247 occasions. sizeof is obviously inferior to offsetof here, so
1248 stick with offsetof.
1249 (GC_POINTER_ALIGNMENT): New macro.
1250 (mark_memory): Omit 3rd (offset) arg; caller changed.
1251 Don't assume EMACS_INT alignment is the same as pointer alignment.
1252
df1bbe5b
SM
12532011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1254
1255 * keyboard.c (read_key_sequence_remapped): New var.
1256 (read_key_sequence): Compute remapping in the right buffer.
1257 (command_loop_1): Use read_key_sequence's remapping directly.
1258
51553db6
SM
12592011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1260
32c1fffd
SM
1261 * dired.c (file_name_completion): Don't expand file name.
1262 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1263 before checking file name handler.
1264
51553db6
SM
1265 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1266 they've been requested explicitly (bug#9591).
1267
b6bd1599 12682011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1269
1270 * keymap.c (Fsingle_key_description): Use make_specified_string
1271 instead of build_string to build string from push_key_description.
1272 (Bug#5193)
1273
f701dc2a
PE
12742011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1275
4222c55d
PE
1276 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1277 This fixes a Y2038 bug on 64-bit hosts.
1278 * buffer.c (reset_buffer):
1279 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1280 (Fclear_buffer_auto_save_failure):
1281 Use 0, not -1, to represent an unset failure time, since time_t
1282 might not be signed.
1283
f701dc2a
PE
1284 Remove dependency on glibc malloc internals.
1285 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1286 Move back here from lisp.h, but with their new implementations.
1287 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1288 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1289 * charset.c (charset_table_init): New static var.
1290 (syms_of_charset): Use it instead of xmalloc. This removes a
1291 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1292 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1293 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1294 Move back to alloc.c.
1295 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1296 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1297
9ceebf39
JD
12982011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1299
1300 * nsterm.m (windowDidResize): Call x_set_window_size only when
1301 ns_in_resize is true. Otherwise set pixelwidth/height and
1302 call change_frame_size (Bug#9628).
1303
cb993c58
PE
13042011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1305
3930c88b
PE
1306 Port --enable-checking=all to Fedora 14 x86-64.
1307 * charset.c (syms_of_charset): Also account for glibc malloc's
1308 internal overhead when calculating the initial malloc maximum.
1309
cb993c58
PE
1310 Port --enable-checking=all to Fedora 14 x86.
1311 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1312 Move to lisp.h.
1313 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1314 (overrun_check_realloc, overrun_check_free):
1315 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1316 That way, xmalloc returns a properly-aligned pointer even if
1317 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1318 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1319 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1320 into account when calculating the initial malloc maximum.
1321 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1322 Move here from alloc.c, so that charset.c can use it too.
1323 Properly align; the old code wasn't right for common 32-bit hosts
1324 when configured with --enable-checking=all.
1325 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1326 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1327
31bed486
EZ
13282011-09-29 Eli Zaretskii <eliz@gnu.org>
1329
04c70788 1330 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1331 use EDOM.
1332
fbcaa2f3
EZ
13332011-09-28 Eli Zaretskii <eliz@gnu.org>
1334
1335 * xdisp.c (compute_display_string_end): If there's no display
1336 string at CHARPOS, return -1.
1337
1338 * bidi.c (bidi_fetch_char): When compute_display_string_end
1339 returns a negative value, treat the character as a normal
1340 character not covered by a display string. (Bug#9624)
1341
a239d4e9
JB
13422011-09-28 Juanma Barranquero <lekktu@gmail.com>
1343
1344 * lread.c (Fread_from_string): Fix typo in docstring.
1345
88652fd5
EZ
13462011-09-27 Eli Zaretskii <eliz@gnu.org>
1347
1348 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1349 newline, reseat the iterator instead of bidi-iterating there one
1350 character at a time. (Bug#9610)
32c1fffd
SM
1351 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1352 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1353
ed497dd4
AS
13542011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1355
1356 * lread.c (readevalloop): Use correct code for NBSP.
1357 (read1): Likewise. (Bug#9608)
1358
b2bf61aa
MA
13592011-09-25 Michael Albinus <michael.albinus@gmx.de>
1360
1361 * dbusbind.c (Fdbus_register_signal): When service is not
1362 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1363
32bbb17c
GM
13642011-09-25 Glenn Morris <rgm@gnu.org>
1365
1366 * buffer.c (truncate-lines): Doc fix.
1367
94e0933e
CY
13682011-09-24 Chong Yidong <cyd@stupidchicken.com>
1369
1370 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1371 (Fset_window_next_buffers): Doc fix.
1372
cddde921
GM
13732011-09-24 Glenn Morris <rgm@gnu.org>
1374
1375 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1376
1260aef1
PE
13772011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1378
25b4bfa0
PE
1379 Fix minor problems found by static checking.
1380 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1381 * indent.c (Fvertical_motion): Fix == vs = typo.
1382
e3cbd34b
EZ
13832011-09-24 Eli Zaretskii <eliz@gnu.org>
1384
a66cfb1c
SM
1385 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1386 Default value is now t. Doc fix.
6bf7006f 1387
e3cbd34b 1388 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1389 logic when moving up, not only when moving down. Fix the
e3cbd34b 1390 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1391 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1392
1393 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1394 CHARPOS is covered by a display string which includes newlines.
1395 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1396 is covered by a display string with embedded newlines.
1397
a3de0cbd
MA
13982011-09-24 Michael Albinus <michael.albinus@gmx.de>
1399
1400 * dbusbind.c (Fdbus_register_signal): Add match rule to
1401 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1402 (Fdbus_register_method, Vdbus_registered_objects_table):
1403 Fix docstring.
a3de0cbd 1404
b260039d
JM
14052011-09-24 Jim Meyering <meyering@redhat.com>
1406
32c1fffd 1407 do not ignore write error for any output size
b260039d
JM
1408 The previous change was incomplete.
1409 While it makes emacs --batch detect the vast majority of stdout
1410 write failures, errors were still ignored whenever the output size is
1411 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1412 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1413 && echo FAIL: ignored write error
1414 FAIL: ignored write error
1415 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1416 && echo FAIL: ignored write error
1417 FAIL: ignored write error
1418 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1419
8eca8a7c
AS
14202011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1421
1422 * emacs.c (Fkill_emacs): In noninteractive mode exit
1423 non-successfully if a write error occurred on stdout. (Bug#9574)
1424
3341db62
EZ
14252011-09-21 Eli Zaretskii <eliz@gnu.org>
1426
1427 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1428 the xassert test.
1429
1430 * dispextern.h (struct it): Update the comment documenting what
1431 can it->OBJECT be.
1432
8c203dbf
EZ
14332011-09-20 Eli Zaretskii <eliz@gnu.org>
1434
1435 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1436 a display string, extend search for cursor position to end of row.
1437 (find_row_edges): If the row ends in a newline from a display
1438 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1439 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1440 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1441 non-empty line. Fixes confusing cursor motion with arrow keys at
1442 the beginning of a line that starts with whitespace.
8c203dbf 1443
a4824228
LMI
14442011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1445
1446 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1447 (bug#9493).
1448
33ed493b
CY
14492011-09-18 Chong Yidong <cyd@stupidchicken.com>
1450
1451 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1452 boolean (Bug#9154).
1453
56cd55c8
EZ
14542011-09-18 Eli Zaretskii <eliz@gnu.org>
1455
1456 * xdisp.c (display_line): Record maximum and minimum buffer
1457 positions even if no glyphs were produced (e.g., by a zero-width
1458 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1459 buffer positions that will be removed from the glyph row because
1460 they don't fit.
c02dcedf
EZ
1461 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1462 column is beyond frame width: don't subtract 1 "pixel" when
1463 computing width of the stretch.
3e62b7e0
EZ
1464 (reseat_at_next_visible_line_start): Undo the change made on
1465 2011-09-17 that saved paragraph information and restored it after
1466 the call to `reseat'. (Bug#9545)
56cd55c8 1467
5ed99d36 14682011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1469
1470 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1471 and turn window cursor on if cleared (Bug#9415).
1472
5ed99d36 14732011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1474
1475 * search.c (boyer_moore): Take unibyte characters from pattern
1476 literally. (Bug#9458)
1477
9bade7b2
EZ
14782011-09-18 Eli Zaretskii <eliz@gnu.org>
1479
1480 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1481
e5e9d610
PE
14822011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1483
87e4427a
PE
1484 Fix minor problem found by static checking.
1485 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1486 initialized, to pacify gcc -Wuninitialized.
1487
e5e9d610
PE
1488 * fileio.c: Report proper errno when syscall falls.
1489 (Finsert_file_contents): Save and restore errno,
1490 so that report_file_error outputs the correct diagnostic.
1491 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1492
a1674f0b
EZ
14932011-09-18 Eli Zaretskii <eliz@gnu.org>
1494
1495 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1496
fbfb6dd4
EZ
14972011-09-17 Eli Zaretskii <eliz@gnu.org>
1498
1499 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1500 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1501
bb187662
EZ
15022011-09-17 Eli Zaretskii <eliz@gnu.org>
1503
1137e8b8 1504 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1505 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1506
1507 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1508 (bidi_find_paragraph_start): Search back for paragraph beginning
1509 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1510 (bidi_move_to_visually_next): Only trigger paragraph-related
1511 computations when the last character is a newline or at EOB, not
1512 just any NEUTRAL_B. (Bug#9470)
1513
bb187662
EZ
1514 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1515 truncated lines if point is covered by a display string. (Bug#9524)
1516
2e621251
PE
15172011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1518
1519 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1520 (cons_to_x_long): New function.
1521 (lisp_data_to_selection_data): Use it. Correct the test for
1522 short-versus-long data; it was negated. Break out of vector
1523 loop, for efficiency, when a long datum is discovered.
1524
91a15bc6
SM
15252011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1526
1527 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1528
b41c3a35
EZ
15292011-09-16 Eli Zaretskii <eliz@gnu.org>
1530
1531 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1532 GCC PR/17406) by declaring this function with external scope.
1533
7812ba2d
PE
15342011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1537 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1538
cf7edc2a
AS
15392011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1540
1541 * editfns.c (Fformat): Correctly handle text properties on "%%".
1542
bd01620e
EZ
15432011-09-15 Eli Zaretskii <eliz@gnu.org>
1544
1545 * xterm.c (x_draw_composite_glyph_string_foreground):
1546 * w32term.c (x_draw_composite_glyph_string_foreground):
1547 * term.c (encode_terminal_code):
1548 * composite.c (composition_update_it, get_composition_id):
1549 * xdisp.c (get_next_display_element)
1550 (fill_composite_glyph_string): Add comments about special meaning
1551 of TAB characters in a composition.
1552
a02719a3
PE
15532011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1556 This occurs when processing a multibyte format.
1557 Problem reported by Wolfgang Jenker.
a02719a3 1558
72589a3c
JB
15592011-09-15 Johan Bockgård <bojohan@gnu.org>
1560
1561 * xdisp.c (try_cursor_movement): Only check for exact match if
1562 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1563
1c14176c
PE
15642011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1565
1566 Remove unused external symbols.
1567 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1568 * xdisp.c (calc_pixel_width_or_height): Now static.
1569 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1570 * indent.c (check_display_width):
1571 * w32term.c: Fix comment to match code.
1572 * xterm.c, xterm.h (x_catching_errors): Remove.
1573
d2eea5b5
PE
15742011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1575
1576 * xselect.c: Use signed conversions more consistently (Bug#9498).
1577 (selection_data_to_lisp_data): Assume incoming selection data are
1578 signed integers, not unsigned. This is to be consistent with
1579 outgoing selection data, which was modified to use signed integers
1580 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1581 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1582 expects long, not unsigned long.
1583
46888499
EZ
15842011-09-14 Eli Zaretskii <eliz@gnu.org>
1585
1586 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1587 computation of loop end. Reported by Johan Bockgård
1588 <bojohan@gnu.org>.
1589
ef8ef9fb
CY
15902011-09-13 Chong Yidong <cyd@stupidchicken.com>
1591
1592 * frame.c (Fother_visible_frames_p): Function deleted.
1593
fa819fed
EZ
15942011-09-12 Eli Zaretskii <eliz@gnu.org>
1595
1596 * indent.c (compute_motion): Process display vector front to back
1597 rather than the other way around. (Bug#2496)
1598
2ba8e008
SM
15992011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1600
1601 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1602
20f53c69
CY
16032011-09-11 Chong Yidong <cyd@stupidchicken.com>
1604
1605 * minibuf.c (Fread_from_minibuffer): Doc fix.
1606
d562d7a4
EZ
16072011-09-11 Eli Zaretskii <eliz@gnu.org>
1608
1609 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1610 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1611
1c4d7f3d
LMI
16122011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1613
1614 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1615 value for non-existent files.
1616
b885bf36
EZ
16172011-09-11 Eli Zaretskii <eliz@gnu.org>
1618
1619 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1620 set its "size" to -1. This will set the modtime_size field of
1621 the corresponding buffer to -1, which is what
1622 verify-visited-file-modtime expects for files that do not exist.
1623 (Bug#9139)
1624
6612f0bf
PE
16252011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1626
1627 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1628 here ...
1629 * lisp.h: ... from here. push_key_description is no longer
1630 defined in keyboard.c, so its declaration should not be in
1631 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1632 logically belongs with push_key_description.
1633
dfb3f755
PE
16342011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1635
1636 * buffer.h: Include <sys/types.h> instead of <time.h>.
1637 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1638 Problem reported by Herbert J. Skuhra.
1639
3134906c
LMI
16402011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1641
1642 * xml.c (parse_region): Make the parsing work for
1643 non-comment-starting XML files again (bug#9144).
1644
8d903f4e
AS
16452011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1646
1647 * image.c (gif_load): Fix calculation of bottom and right corner.
1648 (Bug#9468)
1649
80ad64f4
EZ
16502011-09-10 Eli Zaretskii <eliz@gnu.org>
1651
1652 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1653 redisplay in small windows.
1654
208a048d
EZ
16552011-09-09 Eli Zaretskii <eliz@gnu.org>
1656
1657 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1658
9b1c252e
MR
16592011-09-08 Martin Rudalics <rudalics@gmx.at>
1660
1661 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1662 Operate on live windows only.
1663
2949f33b
JB
16642011-09-08 Juanma Barranquero <lekktu@gmail.com>
1665
1666 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1667
e08dcafd
EZ
16682011-09-07 Eli Zaretskii <eliz@gnu.org>
1669
1670 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1671 only under bidi iteration.
1672
115b96bd
JD
16732011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1674
1675 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1676
c8199d0f
PE
16772011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1678
1679 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1680 Without this fix, the command to link temacs failed due to an
1681 undefined symbol __builtin_isnan. This is because
1682 /usr/include/iso/math_c99.h #defines isnan(x) to
1683 __builtin_isnan(x), but the bundled gcc, which identifies itself
1684 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1685 a __builtin_isnan.
1686 * floatfns.c (isnan): #undef, and then #define to a clone of
1687 what's in data.c.
1688 (Fisnan): Always define, since it's always available now.
1689 (syms_of_floatfns): Always define isnan at the Lisp level.
1690
e39b275c 16912011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1692
1693 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1694
b2db44d9 16952011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1696
f4af5137 1697 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1698 The previous code assumed that file offsets (off_t values) fit in
1699 EMACS_INT variables, which is not true on typical 32-bit hosts.
1700 The code messed up by falsely reporting buffer overflow in cases
1701 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1702 when "big" contains more than 2**29 bytes, even though this
1703 inserts just one byte and does not overflow the buffer.
1704 (Finsert_file_contents): Store file offsets as off_t
1705 values, not as EMACS_INT values. Check for overflow when
1706 converting between EMACS_INT and off_t. When checking for
1707 buffer overflow or for overlap, take the offsets into account.
1708 Don't use EMACS_INT for small values where int suffices.
1709 When checking for overlap, fix a typo: ZV was used where
1710 ZV_BYTE was intended.
1711 (Fwrite_region): Don't assume off_t fits into 'long'.
1712 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1713
ecfc0a49
MA
17142011-09-05 Michael Albinus <michael.albinus@gmx.de>
1715
1716 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1717
6511acf2 17182011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1719
0999621a 1720 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1721
1722 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1723 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1724 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1725 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1726 (modify_event_symbol): Do not assume that the length of
1727 name_alist_or_stem is safe to alloca and fits in int.
1728 (Fexecute_extended_command): Likewise for function name and binding.
1729 (Frecursion_depth): Wrap around reliably on integer overflow.
1730 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1731 since some callers pass EMACS_INT values.
1732 (Fsingle_key_description): Don't crash if symbol name contains more
1733 than MAX_ALLOCA bytes.
1734 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1735 (get_minibuffer): Arg is now EMACS_INT, not int.
1736 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1737 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1738 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1739
2be7d702
PE
1740 * dbusbind.c (signature_cat): New function.
1741 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1742 Do not overrun buffer; instead, report string overflow.
1743
9d1df220
PE
1744 * dispnew.c (add_window_display_history): Don't overrun buffer.
1745 Truncate instead; this is OK since it's just a log.
1746
33ef5c64
PE
1747 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1748 even if the time zone offset is outlandishly large.
1749 Don't mishandle offset == INT_MIN.
1750
66c6fdd5
PE
1751 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1752 when creating daemon; the previous buffer-overflow check was incorrect.
1753
d749b01b
PE
1754 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1755 which has the guts of the old verror function.
1756
b5cd1905
PE
1757 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1758 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1759
6e1a67fb
PE
1760 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1761 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1762 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1763 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1764 length of string rather than counting it via multiple sprintfs;
1765 that's simpler and more reliable.
c21721cc
PE
1766 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1767 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1768 sprintf, in case result does not fit in int.
1769
c57b67fc
PE
1770 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1771 (fontset_from_font): Print it.
1772
8a401434
PE
1773 * frame.c (tty_frame_count): Now printmax_t, not int.
1774 (make_terminal_frame, set_term_frame_name): Print it.
1775 (x_report_frame_params): In X, window IDs are unsigned long,
1776 not signed long, so print them as unsigned.
1777 (validate_x_resource_name): Check for implausibly long names,
1778 and don't assume name length fits in 'int'.
1779 (x_get_resource_string): Don't blindly alloca invocation name;
1780 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1781 not fit in int.
1782
6e1a67fb
PE
1783 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1784 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1785 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1786
0df02bf3
PE
1787 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1788 Use esprintf, not sprintf, in case result does not fit in int.
1789
48e30793
PE
1790 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1791 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1792 it as a large positive number.
1793 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1794 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1795
a66ff6d8
PE
1796 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1797 in case result does not fit in int.
1798
aca216ff
PE
1799 * print.c (float_to_string): Detect width overflow more reliably.
1800 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1801 buffer overrun. Don't assume list length fits in 'int'. Treat
1802 print length of 0 as 0, not as infinity; to be consistent with other
1803 uses of print length in this function. Don't overflow print length
1804 index. Don't assume hash table size fits in 'long', or that
1805 vectorlike size fits in 'unsigned long'.
1806
31c286f7
PE
1807 * process.c (make_process): Use printmax_t, not int, to format
1808 process-name gensyms.
1809
55e5faa1
PE
1810 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1811
80f2e268
PE
1812 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1813 to avoid potential buffer overrun.
1814
670741ab
PE
1815 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1816 if X resource line is longer than 512 bytes.
1817
b7163a50
PE
1818 * xfns.c (x_window): Make sprintf buffer a bit bigger
1819 to avoid potential buffer overrun.
1820
ae58ff1f
PE
1821 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1822
c43c8a6a
PE
1823 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1824
3f8236f4
PE
18252011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1826
53e9fe90 1827 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1828 Without these, Emacs silently mishandles large integers sometimes.
1829 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1830 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1831
6511acf2
PE
1832 * xdisp.c (try_window_id): Check Emacs fixnum range before
1833 converting to 'int'.
806add1d 1834
6511acf2 1835 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1836 Check that an Emacs fixnum is in range before assigning it to 'int'.
1837 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1838 values converted from Emacs fixnums.
1839 (Frecenter): Don't wrap around a line count if it is out of 'int'
1840 range; instead, treat it as an extreme value.
1841 (Fset_window_configuration, compare_window_configurations):
1842 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1843
6511acf2
PE
1844 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1845 that can exceed INT_MAX. Check that EMACS_INT value is in range
1846 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1847 (match_limit): Don't assume that a fixnum can fit in 'int'.
1848
6511acf2 1849 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1850 exceed INT_MAX.
1851
6511acf2 1852 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1853 (Fvertical_motion): Don't wrap around LINES values that don't fit
1854 in 'int'. Instead, treat them as extreme values. This is good
1855 enough for windows, which can't have more than INT_MAX lines anyway.
1856
fcb901a7
LMI
18572011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1858
0f2f6b6d
LMI
1859 * Require libxml/parser.h to avoid compilation warning.
1860
fcb901a7
LMI
1861 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1862
1863 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1864 since this reportedly can destroy thread storage.
1865
6e20a0d4
CY
18662011-08-30 Chong Yidong <cyd@stupidchicken.com>
1867
1868 * syntax.c (find_defun_start): Update all cache variables if
1869 exiting early (Bug#9401).
1870
148ae00e
EZ
18712011-08-30 Eli Zaretskii <eliz@gnu.org>
1872
f6cfbd8f
EZ
1873 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1874
148ae00e
EZ
1875 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1876 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1877 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1878
1879 * term.c (tty_append_glyph): New function.
1880 (produce_stretch_glyph): Static function and its prototype deleted.
1881
a66cfb1c
SM
1882 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1883 Add prototypes.
148ae00e 1884
c4a07a4c
PE
18852011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1886
1887 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1888 when checking :margin (Bug#9390).
1889 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1890 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1891 so that the name doesn't mislead. All uses changed.
1892
6bc8cd65
JB
18932011-08-28 Johan Bockgård <bojohan@gnu.org>
1894
1895 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1896 set_tty_hooks.
1897
dca4927e
EZ
18982011-08-27 Eli Zaretskii <eliz@gnu.org>
1899
1900 * xdisp.c (move_it_to): Don't bail out early when reaching
1901 position beyond to_charpos, if we are scanning backwards.
1902 (move_it_vertically_backward): When DY == 0, make sure we get to
1903 the first character in the line after the newline.
1904
f2cad773
PE
19052011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1906
1907 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1908 (ccl_driver): Do not generate an out-of-range pointer.
1909 (Fccl_execute_on_string): Remove unnecessary check for
1910 integer overflow, noted by Stefan Monnier in
1911 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1912 Remove a FIXME that didn't need fixing.
1913 Simplify the newly-introduced buffer reallocation code.
1914
0cae2cdb
JB
19152011-08-27 Juanma Barranquero <lekktu@gmail.com>
1916
1917 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1918
5fc295a4 19192011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1920
70c60eb2 1921 Integer and memory overflow issues (Bug#9196).
726e0ab1 1922
d31850da
PE
1923 * doc.c (get_doc_string): Rework so that
1924 get_doc_string_buffer_size is the actual buffer size, rather than
1925 being 1 less than the actual buffer size; this makes xpalloc more
1926 convenient.
1927
a69fbedb
PE
1928 * image.c (x_allocate_bitmap_record, cache_image):
1929 * xselect.c (Fx_register_dnd_atom):
1930 Simplify previous changes by using xpalloc.
1931
fe5c5d37
PE
1932 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1933 since either will do and ptrdiff_t is convenient with xpalloc.
1934
0065d054
PE
1935 * charset.c (charset_table_size)
1936 (struct charset_sort_data.priority): Now ptrdiff_t.
1937 (charset_compare): Don't overflow if priorities differ greatly.
1938 (Fsort_charsets): Don't assume list length fits in int.
1939 Check for size-calculation overflow when allocating sort data.
1940 (syms_of_charset): Allocate an initial charset table that is
1941 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1942
1943 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1944
1945 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1946 The actual value is always <= INT_MAX, and leaving it unsigned made
1947 overflow checking harder.
1948
1949 * dispextern.h (struct glyph_matrix.rows_allocated)
1950 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1951 with xpalloc. The values are still always <= INT_MAX.
1952
1953 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1954
1955 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1956 (SAFE_NALLOCA): New macro.
1957
1958 * region-cache.c (struct boundary.pos, find_cache_boundary)
1959 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1960 (set_cache_region, invalidate_region_cache)
1961 (revalidate_region_cache, know_region_cache, region_cache_forward)
1962 (region_cache_backward, pp_cache):
1963 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1964 so that ptrdiff_t * can be passed to xpalloc.
1965 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1966 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1967 (pp_cache): Don't assume cache_len fits in int.
1968 * region-cache.h: Adjust extern decls to match.
1969
1970 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1971 EMACS_INT, since either will do, for xpalloc.
1972
1973 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1974 (xnmalloc, xnrealloc, xpalloc): New functions.
1975
726e0ab1
PE
1976 * bidi.c (bidi_shelve_header_size): New constant.
1977 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1978 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1979
51f30bc5 1980 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1981 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1982 (overlay_strings):
1983 Don't update size of array until after memory allocation succeeds,
1984 because xmalloc/xrealloc may not return.
0065d054
PE
1985 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1986 now that we have proper integer overflow checking.
1987 (record_overlay_string, overlay_strings): Catch overflows when
1988 calculating size of overlay_str_buf.
726e0ab1 1989
0065d054
PE
1990 * callproc.c (Fcall_process): Check for size overflow when
1991 calculating size of args2.
1992 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1993 Normally we prefer signed values, but sticking with ptrdiff_t would
1994 require adding more-complicated checks.
726e0ab1
PE
1995
1996 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1997 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1998 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1999 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2000
2001 * character.c (Fstring): Check for size-calculation overflow.
2002
2003 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2004 unnecessary integer overflow. Check for size overflow.
2005 (encode_coding_object): Don't update size until xmalloc succeeds.
2006
2007 * composite.c (get_composition_id): Check for overflow in glyph
2008 length calculations.
2009
2010 Integer and memory overflow fixes for display code.
2011 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2012 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2013 (scrolling_window): Check for overflow in size calculations.
2014 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2015 Don't assume glyph table len fits in int.
2016 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2017 (row_table_size): Now ptrdiff_t, not int.
2018 (scrolling_window): Avoid overflow in size calculations.
2019 Don't update size until allocation succeeds.
2020 * fns.c (concat): Check for overflow in size calculations.
2021 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2022 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2023 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2024
2025 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2026 (get_doc_string): Check for size calculation overflow.
2027 Don't update size until allocation succeeds.
2028 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2029 EMACS_INT, where ptrdiff_t will do.
2030 (Fsubstitute_command_keys): Check for string overflow.
2031
2032 * editfns.c (set_time_zone_rule): Don't assume environment length
2033 fits in int.
2034 (message_length): Now ptrdiff_t, not int.
2035 (Fmessage_box): Don't update size until allocation succeeds.
2036 Don't assume message length fits in int.
2037 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2038
0065d054
PE
2039 * emacs.c (main): Do not reallocate argv, since there is a null at
2040 the end that can be overwritten, and this way there's no need to
2041 worry about size-calculation overflow.
2042 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2043
2044 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2045 alloc succeeds.
2046 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2047
2048 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2049 (x_set_scroll_bar_width, x_figure_window_size):
2050 Check for integer overflow.
2051 (x_set_alpha): Do not assume XINT fits in int.
2052
2053 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2054 This is for the members text_lines, text_cols, total_lines, total_cols,
2055 where the system imposes an 'int' limit.
2056
2057 * fringe.c (Fdefine_fringe_bitmap):
2058 Don't update size until alloc works.
2059
2060 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2061 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2062
2063 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2064 Check for size-calculation overflow.
2065 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2066 do, as we prefer signed integers.
2067 (id_to_widget.max_size, id_to_widget.used)
2068 (xg_store_widget_in_map, xg_remove_widget_from_map)
2069 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2070 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2071 Use and return ptrdiff_t, not int.
2072 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2073 * gtkutil.h: Change prototypes to match the above.
2074
2075 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2076 are duplicate now that they've been promoted to lisp.h.
2077 (x_allocate_bitmap_record, x_alloc_image_color)
2078 (make_image_cache, cache_image, xpm_load):
2079 Don't update size until alloc is done.
2080 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2081 (x_detect_edges):
3256efce 2082 Check for size calculation overflow.
726e0ab1
PE
2083 (ct_colors_allocated_max): New constant.
2084 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2085 overflow.
3256efce 2086
726e0ab1
PE
2087 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2088 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2089 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2090 Use ptrdiff_t, not int, to count maps.
2091 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2092 calculations. Don't update size until allocation succeeds.
2093 Redo calculations to avoid overflow.
726e0ab1
PE
2094 * keyboard.h: Change prototypes to match the above.
2095
2096 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2097 to count maps.
2098 (current_minor_maps): Check for size calculation overflow.
2099 * keymap.h: Change prototypes to match the above.
2100
2101 * lread.c (read1, init_obarray): Don't update size until alloc done.
2102
2103 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2104 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2105
726e0ab1
PE
2106 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2107 Now ptrdiff_t, not int.
2108 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2109 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2110
2111 * process.c (Fnetwork_interface_list): Check for overflow
2112 in size calculation.
2113
2114 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2115
2116 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2117 overflow. Don't bother calling xmalloc when xrealloc will do.
2118
2119 * search.c (Freplace_match): Check for size calculation overflow.
2120 (Fset_match_data): Don't assume list lengths fit in 'int'.
2121
2122 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2123 for command line length. Do not attempt to address one before the
2124 beginning of an array, as that's not portable.
2125
2126 * term.c (max_frame_lines): Remove; unused.
2127 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2128 not int.
2129 (encode_terminal_code, calculate_costs): Check for size
2130 calculation overflow.
2131 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2132 table lengths and related sizes. Don't update size until alloc
2133 done. Redo calculations to avoid overflow.
2134 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2135
2136 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2137 subtracting pointers.
2138 (gobble_line): Check for overflow more carefully. Don't update size
2139 until alloc done.
2140
2141 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2142 Don't update size until alloc done.
2143 Redo size calculations to avoid overflow.
2144 Check for size calculation overflow.
0065d054 2145 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2146
2147 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2148 Use ptrdiff_t, not int, for sizes.
2149 (store_mode_line_noprop_char): Don't update size until alloc done.
2150
0065d054
PE
2151 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2152 Use ptrdiff_t, not int, for sizes.
2153 (Finternal_make_lisp_face, cache_face):
2154 Check for size calculation overflow.
2155 (cache_face): Treat size calculation overflows as if they were
2156 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2157
2158 * xfns.c (x_encode_text, x_set_name_internal)
2159 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2160 sizes, since they can exceed INT_MAX in size. Check for size
2161 calculation overflow.
2162
0065d054
PE
2163 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2164 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2165 Don't update size until alloc done.
2166
0065d054 2167 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2168 as sprintf is limited to int lengths.
1d526e2f 2169
252c5ee1
PE
2170 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2171 (X_LONG_MIN): New macros.
864d7ce7
PE
2172 Use them to make the following changes clearer.
2173 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2174 This change doesn't affect the value now, but it may help remind
2175 future maintainers not to raise the value too much later.
2176 (SELECTION_QUANTUM): Remove, replacing with ...
2177 (selection_quantum): ... new function, which avoids overflow.
2178 All uses changed.
2179 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2180 assumption that selection length fits in 'int'.
2181 (x_reply_selection_request, x_handle_selection_request)
2182 (x_get_window_property, receive_incremental_selection)
2183 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2184 (lisp_data_to_selection_data, clean_local_selection_data):
2185 Use ptrdiff_t, not int, to record length of selection.
2186 (x_reply_selection_request, x_get_window_property)
2187 (receive_incremental_selection, x_property_data_to_lisp):
2188 Redo calculations to avoid overflow.
2189 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2190 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2191 something.
2192 (x_get_window_property, receive_incremental_selection)
2193 (lisp_data_to_selection_data, x_property_data_to_lisp):
2194 Check for size-calculation overflow.
2195 (x_get_window_property, receive_incremental_selection)
2196 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2197 Don't store size until memory allocation succeeds.
2198 (x_get_window_property): Plug memory leak on memory exhaustion.
2199 Don't double-block input; malloc is safe here. Don't assume 2**34
2200 - 4 fits in unsigned long. Add an xassert to check
2201 XGetWindowProperty overflow. Be more careful about overflow
2202 calculations, and distinguish size from memory overflow better.
2203 (receive_incremental_selection): When tracing, don't assume
2204 unsigned int is less than INT_MAX.
2205 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2206 harmful) conversions of unsigned short to int.
2207 (lisp_data_to_selection_data): Don't assume that integers
2208 in the range -65535 through -1 fit in an X unsigned short.
2209 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2210 result parameters unless successful. Rely on cons_to_unsigned
2211 to report problems with elements; the old code wasn't right anyway.
2212 (x_check_property_data): Check for int overflow; we cannot use
2213 a wider type due to X limits.
2214 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2215
726e0ab1 2216 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2217
0065d054
PE
2218 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2219 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2220 (x_color_cells): Don't store size until memory allocation succeeds.
2221 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2222 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2223 (x_term_init): Don't assume length fits in int (sprintf is limited
2224 to int size).
bc18e09d 2225
ebfa62c0
PE
2226 Use ptrdiff_t for composition IDs.
2227 * character.c (lisp_string_width):
2228 * composite.c (composition_table_size, n_compositions)
2229 (get_composition_id, composition_gstring_from_id):
2230 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2231 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2232 * window.c (Frecenter):
2233 Use ptrdiff_t, not int, for composition IDs.
2234 * composite.c (get_composition_id): Check for integer overflow.
2235 * composite.h: Adjust prototypes to match the above changes.
2236
d3411f89
PE
2237 Use ptrdiff_t for hash table indexes.
2238 * category.c (hash_get_category_set):
2239 * ccl.c (ccl_driver):
2240 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2241 * coding.c (coding_system_charset_list, detect_coding_system):
2242 * coding.h (struct coding_system.id):
2243 * composite.c (get_composition_id, gstring_lookup_cache):
2244 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2245 * image.c (xpm_get_color_table_h):
2246 * lisp.h (hash_lookup, hash_put):
2247 * minibuf.c (Ftest_completion):
2248 Use ptrdiff_t for hash table indexes, not int (which is too
2249 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2250 32-bit --with-wide-int hosts).
2251
e097a6fa
PE
2252 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2253 Add a FIXME comment about memory leaks.
2254 (syms_of_charset): Don't assume xmalloc returns.
2255
5637687f
PE
2256 Don't assume that stated character widths fit in int.
2257 * character.c (Fchar_width, c_string_width, lisp_string_width):
2258 * character.h (CHAR_WIDTH):
2259 * indent.c (MULTIBYTE_BYTES_WIDTH):
2260 Use sanitize_char_width to avoid undefined and/or bad behavior
2261 with outlandish widths.
a66cfb1c 2262 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2263 now that we have two such functions. All uses changed.
2264 (sanitize_char_width): New inline function.
2265
a2271ba2
PE
2266 Don't assume that tab-width fits in int.
2267 * character.h (sanitize_width): New inline function.
2268 (SANE_TAB_WIDTH): New macro.
2269 (ASCII_CHAR_WIDTH): Use it.
2270 * indent.c (sane_tab_width): Remove. All uses replaced by
2271 SANE_TAB_WIDTH (current_buffer).
2272 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2273
18c52557
PE
2274 * fileio.c: Integer overflow issues with file modes.
2275 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2276
caeeedc1
PE
2277 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2278 Remove unreachable code.
2279 (read_hex, load_charset_map_from_file): Check for integer overflow.
2280
50849c52
PE
2281 * xterm.c: don't go over XClientMessageEvent limit
2282 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2283 (x_send_scroll_bar_event): Likewise. Check that the size does not
2284 exceed limits imposed by XClientMessageEvent, as well as the usual
2285 ptrdiff_t and size_t limits.
2286
b13995db
PE
2287 * keyboard.c: Overflow, signedness and related fixes.
2288 (make_lispy_movement): Use same integer type in forward decl
2289 that is used in the definition.
2290 (read_key_sequence, keyremap_step):
2291 Change bufsize argument back to int, undoing my 2011-03-30 change.
2292 We prefer signed types, and int is wide enough here.
2293 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2294 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2295 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2296 length, not size_t. Use ptrdiff_t for index, not int.
2297 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2298 possibility of integer overflow.
2299
13464394
PE
2300 Overflow, signedness and related fixes for images.
2301
2302 * dispextern.h (struct it.stack[0].u.image.image_id)
2303 (struct_it.image_id, struct image.id, struct image_cache.size)
2304 (struct image_cache.used, struct image_cache.ref_count):
2305 * gtkutil.c (update_frame_tool_bar):
2306 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2307 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2308 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2309 * nsmenu.m (update_frame_tool_bar):
2310 * xdisp.c (calc_pixel_width_or_height):
2311 * xfns.c (image_cache_refcount):
2312 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2313 on typical 64-bit hosts.
2314
2315 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2316 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2317 Omit unnecessary casts to int.
2318 (parse_image_spec): Check that integers fall into 'int' range
2319 when the callers expect that.
2320 (image_ascent): Redo ascent calculation to avoid int overflow.
2321 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2322 (lookup_image): Remove unnecessary tests.
2323 (xbm_image_p): Locals are now of int, not EMACS_INT,
2324 since parse_image_check makes sure they fit into int.
2325 (png_load, gif_load, svg_load_image):
2326 Prefer int to unsigned where either will do.
2327 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2328 old tiff_error_handler and tiff_warning_handler.
2329 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2330 stack buffer overflows. It uses only the features of vsnprintf
2331 that are common to both POSIX and native Microsoft.
2332 (tiff_error_handler, tiff_warning_handler): Use it.
2333 (tiff_load, gif_load, imagemagick_load_image):
2334 Don't assume :index value fits in 'int'.
2335 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2336 (imagemagick_load_image): Check that crop parameters fit into
2337 the integer types that MagickCropImage accepts. Don't assume
2338 Vimagemagick_render_type has a nonnegative value. Don't assume
2339 size_t fits in 'long'.
2340 (gs_load): Use printmax_t to print the widest integers possible.
2341 Check for integer overflow when computing image height and width.
2342
c11821d4
EZ
23432011-08-26 Eli Zaretskii <eliz@gnu.org>
2344
2345 * xdisp.c (redisplay_window): Don't force window start if point
2346 will be invisible in the resulting window. (Bug#9324)
2347
0c95fcf7
EZ
23482011-08-25 Eli Zaretskii <eliz@gnu.org>
2349
2350 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2351 the display spec is of the form `(space ...)'.
2352 (handle_display_spec): Return the value returned by
2353 handle_single_display_spec, not just 1 or zero.
2354 (handle_single_display_spec): If the display spec is of the form
2355 `(space ...)', and specifies display in the text area, return 2
2356 rather than 1.
fee65a97 2357 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2358 accurately, and prefer exact match for point under bidi.
2359 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2360
2361 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2362 into disp_prop; all users changed.
2363
2364 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2365 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2366 for the text covered by the display property.
2367
e4ed06f1
CY
23682011-08-25 Chong Yidong <cyd@stupidchicken.com>
2369
2370 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2371 Change return value to nil.
2372 (Frecord_buffer): Delete unused function.
2373
f67cdd7f
EZ
23742011-08-24 Eli Zaretskii <eliz@gnu.org>
2375
5980d4c6
EZ
2376 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2377 buffers, return left-to-right.
8610fe8b
EZ
2378 (set_cursor_from_row): Consider candidate row a win if its glyph
2379 represents a newline and point is on that newline. Fixes cursor
2380 positioning on the newline at EOL of R2L text within L2R
2381 paragraph, and vice versa.
2382 (try_cursor_movement): Check continued rows, in addition to
2383 continuation rows. Fixes unwarranted scroll when point enters a
2384 continued line of R2L text within an L2R paragraph, or vice versa.
2385 (cursor_row_p): Consider the case of point being equal to
2386 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2387 from the end of a short line to the beginning of a continued line
2388 of R2L text within L2R paragraph.
2389 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2390 composed characters.
5980d4c6 2391
f67cdd7f
EZ
2392 * bidi.c (bidi_check_type): Use xassert.
2393 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2394 members.
2395
bca633fb
EZ
23962011-08-23 Eli Zaretskii <eliz@gnu.org>
2397
2398 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2399 a character.
2400
4a5885a7
CY
24012011-08-23 Chong Yidong <cyd@stupidchicken.com>
2402
2403 * nsfont.m (ns_otf_to_script): Fix typo.
2404
0902a04e
KH
24052011-08-22 Kenichi Handa <handa@m17n.org>
2406
2407 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2408 extra slot even if the purpose is char-code-property-table.
2409
1a2e6670
EZ
24102011-08-23 Eli Zaretskii <eliz@gnu.org>
2411
8ddde651
EZ
2412 * xdisp.c (redisplay_window): When computing centering_position,
2413 account for the height of the header line. (Bug#8874)
2414
425cc014
EZ
2415 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2416 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2417 candidate is selected by the mouse, and that candidate has a
2418 composed character under the mouse.
2419
1a2e6670
EZ
2420 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2421 coordinates reported by pos-visible-in-window-p for a composed
2422 character in column zero.
2423
8b76d6f8
SM
24242011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2425
2426 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2427
dac347dd
EZ
24282011-08-22 Eli Zaretskii <eliz@gnu.org>
2429
2430 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2431 consider it a hit if to_charpos is anywhere in the range of the
2432 composed buffer positions.
2433
e013fb34
CY
24342011-08-22 Chong Yidong <cyd@stupidchicken.com>
2435
2436 * image.c (gif_load): Don't assume that each subimage has the same
2437 dimensions as the base image. Handle disposal method that is
2438 "undefined" by the gif spec (Bug#9335).
2439
bd1ba3e8
CY
24402011-08-20 Chong Yidong <cyd@stupidchicken.com>
2441
2442 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2443 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2444
54a1215b
EZ
24452011-08-19 Eli Zaretskii <eliz@gnu.org>
2446
823564e5
EZ
2447 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2448 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2449 from an Org mode buffer to a Speedbar frame.
2450
54a1215b
EZ
2451 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2452 a composition, take its buffer position from IT->cmp_it.charpos.
2453 Fixes cursor positioning at the beginning of a line that begins
2454 with a composed character.
2455
9778ebcc
EZ
24562011-08-18 Eli Zaretskii <eliz@gnu.org>
2457
0be6ee06
EZ
2458 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2459 character bidirectional type, use STRONG_L instead. Fixes crashes
2460 in a buffer produced by `describe-categories'.
2461
9778ebcc
EZ
2462 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2463 members before the level stack, so they would be saved and
2464 restored when copying iterator state. Fixes incorrect reordering
2465 around TABs covered by display properties.
2466
156bffbe
AS
24672011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2468
6b02f655 2469 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2470
72ad093b
CY
24712011-08-17 Chong Yidong <cyd@stupidchicken.com>
2472
2473 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2474 (internal_condition_case_2, internal_condition_case_n):
2475 Remove unnecessary aborts (Bug#9081).
72ad093b 2476
35774242
EZ
24772011-08-17 Eli Zaretskii <eliz@gnu.org>
2478
2479 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2480 has no `load' handler, try opening the file locally. (Bug#9311)
2481
db76dd85
KB
24822011-08-16 Ken Brown <kbrown@cornell.edu>
2483
2484 * gmalloc.c: Expand comment.
2485
b215eee5
EZ
24862011-08-16 Eli Zaretskii <eliz@gnu.org>
2487
2488 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2489 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2490
a4579d33
KB
24912011-08-16 Ken Brown <kbrown@cornell.edu>
2492
2493 Fix memory allocation problems in Cygwin build (Bug#9273).
2494
2495 * unexcw.c ( __malloc_initialized): Declare external variable.
2496 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2497
8b76d6f8
SM
2498 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2499 New variables.
a4579d33
KB
2500 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2501 dumped emacs.
2502 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2503 in the static heap.
2504 [CYGWIN] (special_realloc): New function.
2505 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2506 requests to realloc storage in the static heap.
2507
3ebec551
PE
25082011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2509
2510 * bidi.c (bidi_initialize): Remove unused local.
2511
9fd8be00
EZ
25122011-08-15 Eli Zaretskii <eliz@gnu.org>
2513
6b02f655
SM
2514 * bidimirror.h:
2515 * biditype.h: Remove file.
2516 * makefile.w32-in ($(BLD)/bidi.$(O)):
2517 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2518
2519 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2520
2521 * chartab.c: Improve commentary for the uniprop_table API.
2522
32413314
EZ
2523 * bidi.c (bidi_paragraph_init): Support zero value of
2524 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2525 (bidi_initialize): Use uniprop_table instead of including
2526 biditype.h and bidimirror.h.
32413314 2527
9fd8be00
EZ
2528 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2529 coordinates of the iterator when restoring from ppos_it.
2530 (Bug#9296)
2531
5cf2b69b
KH
25322011-08-14 Kenichi Handa <handa@m17n.org>
2533
2534 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2535 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2536
daf17d00
EZ
25372011-08-14 Eli Zaretskii <eliz@gnu.org>
2538
2539 * xdisp.c (move_it_in_display_line_to): Don't invoke
2540 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2541 ppos_it. Fixes vertical cursor motion when line beginning is
2542 covered by an image. (Bug#9296)
2543
08e3161a
JD
25442011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2545
2546 * nsterm.h (ns_run_ascript): Declare.
2547 (NSAPP_DATA2_RUNASSCRIPT): Define.
2548
2549 * nsfns.m (as_script, as_result, as_status): New static variables.
2550 (ns_run_ascript): New function.
5e617bc2 2551 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2552 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2553 the event loop. Get status from as_status (Bug#7276).
2554
2555 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2556 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2557 the event loop (Bug#7276).
2558
a3720aa2
AS
25592011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2560
2561 * gnutls.c (QCgnutls_bootprop_priority)
2562 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2563 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2564 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2565 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2566 (QCgnutls_bootprop_verify_hostname_error)
2567 (QCgnutls_bootprop_callbacks_verify): Rename from
2568 Qgnutls_bootprop_..., all uses changed.
2569
2570 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2571 uses changed.
2572
0a0d27fb
PE
25732011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2574
19d5c50c
PE
2575 * xfaces.c (Qframe_set_background_mode): Now static.
2576 * dispextern.h (Qframe_set_background_mode): Remove decl.
2577
0a0d27fb
PE
2578 * process.c (Fnetwork_interface_info): Declare local only if needed.
2579
377538cb
JD
25802011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2581
2582 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2583 (Fnetwork_interface_list): Allocate in increments of bytes instead
2584 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2585 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2586 sockaddr.
2587 (struct ifflag_def): notrailers is smart on OSX.
2588 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2589 Get hardware address with getifaddrs if available.
2590
08fff70c
EZ
25912011-08-12 Eli Zaretskii <eliz@gnu.org>
2592
2593 * xdisp.c (iterate_out_of_display_property): xassert that
2594 IT->position is set to within IT->object's boundaries. Break from
2595 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2596 when IT->position is set up wrongly due to some bug.
2597 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2598 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2599 entry. Force push_it to save on the stack the current
2600 buffer/string position, to be restored by pop_it. Fix flags in
2601 the iterator structure wrt the object coming from a display
2602 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2603 properties. (Bug#9284)
2604
7be1c708 26052011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2606
7be1c708
CY
2607 * fontset.c (fontset_get_font_group): Add proper type checks.
2608 (Bug#9172)
aac0c6e3 2609
7be1c708 26102011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2611
7be1c708
CY
2612 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2613 and LC_VERSION_MIN_MACOSX.
2614 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2615 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2616
97bb72a6
EZ
26172011-08-08 Eli Zaretskii <eliz@gnu.org>
2618
2619 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2620 no-display-properties-and-no-overlays under bidi display.
2621 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2622 properties and overlays.
97bb72a6 2623
d5617611
CY
26242011-08-08 Chong Yidong <cyd@stupidchicken.com>
2625
37e11a63
CY
2626 * editfns.c (Fset_time_zone_rule): Document relationship with the
2627 setenv function.
2628
d5617611
CY
2629 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2630 the font entity extracted from the cache (Bug#8109).
2631
58872834
CY
26322011-08-07 Chong Yidong <cyd@stupidchicken.com>
2633
2634 * composite.c (autocmp_chars): Don't reset point. That is done by
2635 restore_point_unwind (Bug#5984).
2636
75bfc667
JL
26372011-08-07 Juri Linkov <juri@jurta.org>
2638
2639 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2640 to show the arg `TIME' instead of `TIMEVAL'.
2641
d1410150
EZ
26422011-08-06 Eli Zaretskii <eliz@gnu.org>
2643
2644 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2645 display property strides EOL and includes a newline, as in
2646 longlines-mode. (Bug#9254)
75b771e4
EZ
2647 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2648 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2649
2650 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2651 is non-zero, even if the data buffer is NULL. Fixes a crash in
2652 vertical-motion with longlines-mode. (Bug#9254)
2653
35928349
EZ
26542011-08-05 Eli Zaretskii <eliz@gnu.org>
2655
ec7cc85b
EZ
2656 * bidi.c <bidi_cache_total_alloc>: Now static.
2657 (bidi_initialize): Initialize bidi_cache_total_alloc.
2658
8b76d6f8 2659 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2660 cache. (Bug#9221)
2661
2662 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2663 amount allocated this far in `bidi_cache_total_alloc'.
2664 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2665 non-zero, only free the data buffer without restoring the cache
2666 contents. All callers changed.
2667
2668 * dispextern.h (bidi_unshelve_cache): Update prototype.
2669
2670 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2671 (move_it_in_display_line, move_it_to)
2672 (move_it_vertically_backward, move_it_by_lines): Replace the call
2673 to xfree to an equivalent call to bidi_unshelve_cache.
2674 (move_it_in_display_line_to): Fix logic of returning
412b6358 2675 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2676
e2e2423b
EZ
26772011-08-05 Eli Zaretskii <eliz@gnu.org>
2678
2679 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2680 came from a string character with a `cursor' property. (Bug#9229)
2681
ae9e757a
JD
26822011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2683
2684 * Makefile.in (LIB_PTHREAD): New variable.
2685 (LIBES): Add LIB_PTHREAD (Bug#9216).
2686
2687 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2688 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2689
213bd7f2
AS
26902011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2691
6b02f655 2692 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2693
99aaf75f
JD
26942011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2695
2696 * xterm.c (x_find_topmost_parent): New function.
2697 (x_set_frame_alpha): Find topmost parent window with
2698 x_find_topmost_parent and set the property there also (bug#9181).
2699 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2700
c74e9d86
PE
27012011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2702
2703 * callproc.c (Fcall_process): Avoid vfork clobbering
2704 the local vars buffer, coding_systems, current_dir.
2705
640c8776
SM
27062011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2707
2708 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2709
f26d0e4c
PE
27102011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2711
8a10d76c
PE
2712 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2713 so that it is not optimized away.
2714
f26d0e4c
PE
2715 * xdisp.c (compute_display_string_pos): Remove unused local.
2716
55439c61
EZ
27172011-08-02 Eli Zaretskii <eliz@gnu.org>
2718
2719 Fix slow cursor motion and scrolling in large buffers with
2720 selective display, like Org Mode buffers. (Bug#9218)
2721
2722 * dispextern.h (struct bidi_it): New member disp_prop_p.
2723
2724 * xdisp.c: Remove one-slot cache of display string positions.
2725 (compute_display_string_pos): Accept an additional argument
5e617bc2 2726 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2727 for a display string or property. If found, set DISP_PROP_P
2728 non-zero.
2729
2730 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2731 DISP_PROP_P, and pass it to compute_display_string_pos.
2732 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2733 non-zero. All callers of bidi_fetch_char changed.
2734
fb33fa43
SM
27352011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2736
2737 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2738
b099e063
DM
27392010-12-03 Don March <don@ohspite.net>
2740
2741 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2742 last character M-[char] is translated to ESC [char] (bug#7541).
2743
5cc7f7af
KH
27442011-08-02 Kenichi Handa <handa@m17n.org>
2745
d0fffa3f 2746 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2747
2748 * chartab.c (uniprop_table): Make it non-static.
2749
525d5e6e
EZ
27502011-08-01 Eli Zaretskii <eliz@gnu.org>
2751
2752 * xdisp.c (forward_to_next_line_start): Accept additional argument
2753 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2754 on the newline.
2755 (reseat_at_next_visible_line_start): Use the bidi iterator state
2756 returned by forward_to_next_line_start to restore the state of
2757 it->bidi_it after backing up to previous newline. (Bug#9212)
2758
31011111
AS
27592011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2760
2761 * regex.c (re_comp): Protoize.
2762 (re_exec): Fix return type.
2763 (regexec): Fix type of `ret'. (Bug#9203)
2764
476371c4
PE
27652011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2766
e5d76069
PE
2767 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2768 This is needed if max-image-size is a floating-point number.
2769
9a79b20c
AS
27702011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2771
2772 * print.c (print_object): Print empty symbol as ##.
2773
2774 * lread.c (read1): Read ## as empty symbol.
2775
d8c2fa78
AA
27762011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2777
2778 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2779 setting frame foreground color (Bug#9175).
2780 (x_set_background_color): Likewise.
2781
ffe57a7a
AA
2782 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2783 contents (Bug#9176).
2784 (EmacsTooltip -init): Remove bezels and add shadows to
2785 tooltip windows.
2786
bf3492a5
AA
2787 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2788 or scroll bar (Bug#8470).
2789
d55e9c53
AA
2790 * nsfont.m (nsfont_open): Remove assignment to voffset and
2791 unnecessary vars hshink, expand, hd, full_height, min_height.
2792 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2793
2794 * nsterm.h (nsfont_info): Remove voffset field.
2795
d8c2fa78 27962011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2797
2798 Implement strike-through and overline on NextStep (Bug#8863).
2799
2800 * nsfont.m (nsfont_open): Use underline position provided by font,
2801 instead of hard-coded value of 2.
2802 (nsfont_draw): Call ns_draw_text_decoration instead.
2803
2804 * nsterm.h: Add declaration for ns_draw_text_decoration.
2805
2806 * nsterm.m (ns_draw_text_decoration): New function for drawing
2807 underline, overline, and strike-through.
2808 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2809 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2810 accommodate underlining, etc.
4843aac3 2811
4cc60b9b
EZ
28122011-07-28 Eli Zaretskii <eliz@gnu.org>
2813
bc7ece87
EZ
2814 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2815 default.
4cc60b9b 2816
476371c4
PE
28172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2818
66606eea
PE
2819 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2820 Without this fix, if a signal arrives just after memory fills up,
2821 'malloc' might be invoked reentrantly.
2822
476371c4
PE
2823 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2824 In other words, assume that every image size is allowed, on non-X
2825 hosts. This assumption is probably wrong, but it lets Emacs compile.
2826
f3fcc40d
AS
28272011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2828
2829 * regex.c (re_iswctype): Convert return values to boolean.
2830
350c992f
EZ
28312011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2832
2833 * xdisp.c (compute_display_string_pos): Don't use cached display
2834 string position if the buffer had its restriction changed.
2835 (Bug#9184)
2836
5266b4bb
PE
28372011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2838
2839 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2840
2573a837 28412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2842
41f55ccd 2843 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2844
39e378da
PE
2845 * bidi.c: Integer size and overflow fixes.
2846 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2847 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2848 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2849 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2850 (bidi_find_other_level_edge):
2851 Use ptrdiff_t instead of EMACS_INT where either will do.
2852 This works better on 32-bit hosts configured --with-wide-int.
2853 (bidi_cache_ensure_space): Check for size-calculation overflow.
2854 Use % rather than repeated addition, for better worst-case speed.
2855 Don't set bidi_cache_size until after xrealloc returns, because it
2856 might not return.
2857 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2858 (bidi_cache_ensure_space): Also check that the bidi cache size
2859 does not exceed that of the largest Lisp string or buffer. See Eli
2860 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2861
5e927815
PE
2862 * alloc.c (__malloc_size_t): Remove.
2863 All uses replaced by size_t. See Andreas Schwab's note
2864 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2865
ca4aa935
PE
2866 * image.c: Improve checking for integer overflow.
2867 (check_image_size): Assume that f is nonnull, since
2868 it is always nonnull in practice. This is one less thing to
2869 worry about when checking for integer overflow later.
2870 (x_check_image_size): New function, which checks for integer
2871 overflow issues inside X.
2872 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2873 This removes the need for a memory_full check.
2874 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2875 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2876 (xbm_read_bitmap_data): Change locals back to 'int', since
2877 their values must fit in 'int'.
2878 (xpm_load_image, png_load, tiff_load):
2879 Invoke x_create_x_image_and_pixmap earlier,
2880 to avoid much needless work if the image is too large.
2881 (tiff_load): Treat overly large images as if
2882 x_create_x_image_and_pixmap failed, not as malloc failures.
2883 (gs_load): Use x_check_image_size.
2884
5f8f9cc2
PE
2885 * gtkutil.c: Omit integer casts.
2886 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2887 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2888
5adf60bc
PE
2889 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2890
c8907a93
PE
2891 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2892 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2893 would wrongly return t on a 64-bit host.
2894
e3c25c68
PE
2895 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2896 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2897 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2898 and therefore cause GCC to emit a bogus diagnostic in some cases.
2899
3f791afe
PE
2900 * image.c: Integer signedness and overflow and related fixes.
2901 This is not an exhaustive set of fixes, but it's time to
2902 record what I've got.
2903 (lookup_pixel_color, check_image_size): Remove redundant decls.
2904 (check_image_size): Don't assume that arbitrary EMACS_INT values
2905 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2906 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2907 (tiff_load, imagemagick_load_image):
2908 Check for overflow in size calculations.
2909 (x_create_x_image_and_pixmap): Remove unnecessary test for
2910 xmalloc returning NULL; that can't happen.
2911 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2912 (xpm_color_bucket): Use better integer hashing function.
2913 (xpm_cache_color): Don't possibly over-allocate memory.
2914 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2915 (gif_memory_source):
2916 Use ptrdiff_t, not int or size_t, to record sizes.
2917 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2918 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2919 either works, as we prefer signed integers.
2920 (tiff_read_from_memory, tiff_write_from_memory):
2921 Return tsize_t, not size_t, since that's what the TIFF API wants.
2922 (tiff_read_from_memory): Don't fail simply because the read would
2923 go past EOF; instead, return a short read.
2924 (tiff_load): Omit no-longer-needed casts.
2925 (Fimagemagick_types): Don't assume size fits into 'int'.
2926
3cc5a532
PE
2927 Improve hashing quality when configured --with-wide-int.
2928 * fns.c (hash_string): New function, taken from sxhash_string.
2929 Do not discard information about ASCII character case; this
2930 discarding is no longer needed.
2931 (sxhash-string): Use it. Change sig to match it. Caller changed.
2932 * lisp.h: Declare it.
2933 * lread.c (hash_string): Remove, since we now use fns.c's version.
2934 The fns.c version returns a wider integer if --with-wide-int is
2935 specified, so this should help the quality of the hashing a bit.
2936
b312a492
PE
2937 * emacs.c: Integer overflow minor fix.
2938 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2939 Define only if GNU_LINUX.
2940 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2941
dfd153ae
PE
2942 * dispnew.c: Integer signedness and overflow fixes.
2943 Remove unnecessary forward decls, that were a maintenance hassle.
2944 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2945 All uses changed.
2946 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2947 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2948 (prepare_desired_row, line_draw_cost):
2949 Use int, not unsigned, where either works.
2950 (save_current_matrix, restore_current_matrix):
2951 Use ptrdiff_t, not size_t, where either works.
2952 (init_display): Check for overflow more accurately, and without
2953 relying on undefined behavior.
2954
a81d11a3
PE
2955 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2956 Remove, replacing with the new symbols in lisp.h. All uses changed.
2957 * fileio.c (make_temp_name):
2958 * filelock.c (lock_file_1, lock_file):
2959 * xdisp.c (message_dolog):
2960 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2961 Use pMd etc. instead.
2962 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2963 replacing the pWIDE etc. symbols removed from editfns.c.
2964
3300e6fd
PE
2965 * keyboard.h (num_input_events): Now uintmax_t.
2966 This is (very slightly) less likely to mess up due to wraparound.
2967 All uses changed.
2968
fd05c7e9
PE
2969 * buffer.c: Integer signedness fixes.
2970 (alloc_buffer_text, enlarge_buffer_text):
2971 Use ptrdiff_t rather than size_t when either will do, as we prefer
2972 signed integers.
2973
903fe15d
PE
2974 * alloc.c: Integer signedness and overflow fixes.
2975 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2976 (__malloc_size_t): Default to size_t, not to int.
2977 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2978 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2979 Prefer ptrdiff_t to size_t when either would do, as we prefer
2980 signed integers.
2981 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2982 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2983 Now const. Initialize with values that are in range even if char
2984 is signed.
2985 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2986 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2987 These functions do the right thing with sizes > 2**32.
2988 (check_depth): Now ptrdiff_t, not int.
2989 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2990 Adjust to new way of storing sizes. Check for size overflow bugs
2991 in rest of code.
2992 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2993 slightly wrong anyway, as it missed one instance of
2994 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2995 (refill_memory_reserve): Omit needless cast to size_t.
2996 (mark_object_loop_halt): Mark as externally visible.
2997
ac82cc6a
PE
2998 * xselect.c: Integer signedness and overflow fixes.
2999 (Fx_register_dnd_atom, x_handle_dnd_message):
3000 Use ptrdiff_t, not size_t, since we prefer signed.
3001 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3002 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3003 x_dnd_atoms_size and x_dnd_atoms_length.
3004
c2d1e36d
PE
3005 * doprnt.c: Prefer signed to unsigned when either works.
3006 * eval.c (verror):
3007 * doprnt.c (doprnt):
3008 * lisp.h (doprnt):
3009 * xdisp.c (vmessage):
3010 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3011 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3012 prefer signed arithmetic to avoid comparison confusion.
3013 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3014 but is a bit tricky.
3015
0e926e56
PE
3016 Assume freestanding C89 headers, string.h, stdlib.h.
3017 * data.c, doprnt.c, floatfns.c, print.c:
3018 Include float.h unconditionally.
3019 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3020 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3021 * regex.c: Likewise for stddef.h, string.h.
3022 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3023 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3024 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3025 (STDC_HEADERS): Remove obsolete defines.
3026 * sysdep.c: Include limits.h unconditionally.
3027
9cfdb3ec
PE
3028 Assume support for memcmp, memcpy, memmove, memset.
3029 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3030 * regex.c (memcmp, memcpy):
3031 Remove; we assume C89 now.
3032
3033 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3034 (__malloc_safe_bcopy): Remove; no longer needed.
3035
cf950e6b 3036 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3037 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3038 well either way, and we prefer signed to unsigned.
3039
dbf38e02
LMI
30402011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3041
3042 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3043 closes the connection while we're reading (bug#9182).
3044
d6f0886c 30452011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3046
d6f0886c
JD
3047 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3048 are specified (Bug#9168).
24e0f6b1 3049
2eb1f9e6
PE
30502011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3051
3052 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3053 Found by GCC static checking and --with-wide-int on a 32-bit host.
3054
22381272 30552011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3056
3057 * xdisp.c (compute_display_string_pos): Fix logic of caching
3058 previous display string position. Initialize cached_prev_pos to
3059 -1. Fixes slow-down at the beginning of a buffer.
3060
f25e39b4
EZ
30612011-07-24 Eli Zaretskii <eliz@gnu.org>
3062
3063 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3064 for attrs[LFACE_FONTSET_INDEX].
3065
04c4b52e
PE
30662011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3067
3068 * xml.c (parse_region): Remove unused local
3069 that was recently introduced.
3070
c1734fbd
EZ
30712011-07-23 Eli Zaretskii <eliz@gnu.org>
3072
be18c5a5
EZ
3073 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3074 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3075
c1734fbd
EZ
3076 * xdisp.c (move_it_in_display_line_to): Record the best matching
3077 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3078 exit if none of the characters scanned was an exact match.
3079 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3080 when exact match is impossible due to invisible text, and the
3081 lines are truncated.
3082
a258d627
JD
30832011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3084
3085 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3086 for OSX >= 10.7.
3087
b6d5a689
EZ
30882011-07-22 Eli Zaretskii <eliz@gnu.org>
3089
0f74f785
EZ
3090 Fix a significant slow-down of cursor motion with C-n, C-p,
3091 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3092 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3093 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3094 (next_element_from_buffer): Call compute_stop_pos_backwards to
3095 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3096 base_level_stop.
3097 (reseat): Don't look for prev_stop, as that could mean a very long
3098 run.
3099 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3100 <cached_disp_overlay_modiff>: Cache for last found display string
3101 position.
551918c1 3102 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3103 about the same buffer in the same area of character positions, and
3104 the buffer wasn't changed since the time the display string
3105 position was cached.
551918c1 3106
b2d0c91a
EZ
31072011-07-22 Eli Zaretskii <eliz@gnu.org>
3108
3109 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3110 is an integer, which is important for empty lines. (Bug#9149)
3111
043604ee
CY
31122011-07-22 Chong Yidong <cyd@stupidchicken.com>
3113
3114 * frame.c (Fmodify_frame_parameters): In tty case, update the
3115 default face if necessary (Bug#4238).
3116
da4adb04
CY
31172011-07-21 Chong Yidong <cyd@stupidchicken.com>
3118
3119 * editfns.c (Fstring_to_char): No need to explain what a character
3120 is in the docstring (Bug#6576).
3121
9abd0532
LMI
31222011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3123
3124 * xml.c (parse_region): Make sure we always return a tree.
3125
36881d16
HK
31262011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3127
3128 * xml.c (parse_region): If a document contains only comments,
3129 return that, too.
3130
1e98674d
LMI
31312011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3132
3133 * xml.c (make_dom): Return comments, too.
3134
590bd467
PE
31352011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3136
3137 Port to OpenBSD.
3138 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3139 and the surrounding thread.
3140 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3141 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3142 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3143 timer goes off.
3144 * s/openbsd.h (BROKEN_SIGIO): Define.
3145 * unexelf.c (unexec) [__OpenBSD__]:
3146 Don't update the .mdebug section of the Alpha COFF symbol table.
3147
f41628b2
LMI
31482011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3149
3150 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3151 (bug#8460).
3152
b59b67c5
PE
31532011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3154
15e3a074
PE
3155 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3156 This fixes some race conditions on the permissions of any newly
3157 created file.
3158
41bed37d
PE
3159 * alloc.c (valid_pointer_p): Use pipe, not open.
3160 This fixes some permissions issues when debugging.
3161
b59b67c5
PE
3162 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3163 If fchown fails to set both uid and gid, try to set just gid,
3164 as that is sometimes allowed. Adjust the file's mode to eliminate
3165 setuid or setgid bits that are inappropriate if fchown fails.
3166
925a6be7
SM
31672011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3168
3169 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3170 to compare Lisp_Objects.
3171 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3172 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3173 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3174
52968808
AS
31752011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3176
0a6a104b
AS
3177 * lread.c (read_integer): Unread even EOF character.
3178 (read1): Likewise. Properly record start position of symbol.
3179
52968808
AS
3180 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3181 symbol character follows.
3182
9e381cdd
PE
31832011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3184
3185 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3186 This works around a problem with the previous change to Fcopy_file.
3187 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3188 and without this change, GCC might complain about discarding
3189 fchown's return value.
3190
b5641435
JB
31912011-07-16 Juanma Barranquero <lekktu@gmail.com>
3192
3193 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3194
a8031457
PE
31952011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3196
3197 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3198
dd889327
LMI
31992011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3200
750c33f7
LMI
3201 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3202 it's used from the C level.
3203
dd889327
LMI
3204 * process.c: Use the same condition for POLL_FOR_INPUT in both
3205 keyboard.c and process.c (bug#1858).
3206
87e86684
LM
32072011-07-09 Lawrence Mitchell <wence@gmx.li>
3208
3209 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3210 (Fgnutls_boot): Use it.
3211
64348f40
AS
32122011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3213
3214 * doc.c (Fsubstitute_command_keys): Revert last change.
3215
1d698799
LMI
32162011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3217
f863868c
LMI
3218 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3219 quotes the next character, and doesn't affect other longer
3220 sequences (bug#8935).
3221
1d698799
LMI
3222 * lread.c (syms_of_lread): Clarify that is isn't only
3223 `eval-buffer' and `eval-defun' that's affected by
3224 `lexical-binding' (bug#8460).
3225
aa4b6df6
EZ
32262011-07-15 Eli Zaretskii <eliz@gnu.org>
3227
3228 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3229 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3230
5d856da6
PE
32312011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3232
ad6042bb
PE
3233 Fix minor problems found by static checking.
3234 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3235 (elsz): Now a signed constant, not a size_t var. We prefer signed
3236 types to unsigned, to avoid integer comparison confusion. Without
3237 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3238 "cannot optimize loop, the loop counter may overflow", a symptom
3239 of the confusion.
f00bbb22 3240 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3241 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3242
6468f31c
LMI
32432011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3244
49080b10
LMI
3245 * search.c (Fre_search_backward): Mention `case-fold-search' in
3246 all the re_search_* functions (bug#8138).
3247
6468f31c
LMI
3248 * keyboard.c (Fopen_dribble_file): Document when the file is
3249 closed (bug#8056).
3250
c965adc5
EZ
32512011-07-14 Eli Zaretskii <eliz@gnu.org>
3252
df9733bf
EZ
3253 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3254 bidi_cache_idx.
3255
0bb23927
EZ
3256 Support bidi reordering of display and overlay strings.
3257 * xdisp.c (compute_display_string_pos)
3258 (compute_display_string_end): Accept additional argument STRING.
3259 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3260 (reseat_to_string): Initialize bidi_it->string.s and
3261 bidi_it->string.schars.
3262 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3263 NULL (avoids a crash in bidi_paragraph_init).
3264 Initialize itb.string.lstring.
0bb23927
EZ
3265 (init_iterator): Call bidi_init_it only of a valid
3266 buffer position was specified. Initialize paragraph_embedding to
3267 L2R.
3268 (reseat_to_string): Initialize the bidi iterator.
3269 (display_string): If we need to ignore text properties of
3270 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3271 original value of -1 will not work with bidi.)
3272 (compute_display_string_pos): First arg is now struct
3273 `text_pos *'; all callers changed. Support display properties on
3274 Lisp strings.
3275 (compute_display_string_end): Support display properties on Lisp
3276 strings.
3277 (init_iterator, reseat_1, reseat_to_string): Initialize the
3278 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3279 when iterating on a string not from display properties).
640c8776
SM
3280 (compute_display_string_pos, compute_display_string_end):
3281 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3282 arrow keys.
3283 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3284 base_level_stop; instead, set base_level_stop to BEGV.
3285 Fixes crashes in vertical-motion.
0bb23927
EZ
3286 (next_element_from_buffer): Improve commentary for when
3287 the iterator is before prev_stop.
3288 (init_iterator): Initialize bidi_p from the default value of
3289 bidi-display-reordering, not from buffer-local value. Use the
3290 buffer-local value only if initializing for buffer iteration.
3291 (handle_invisible_prop): Support invisible properties on strings
3292 that are being bidi-reordered.
3293 (set_iterator_to_next): Support bidi reordering of C strings and
3294 Lisp strings.
3295 (next_element_from_string): Support bidi reordering of Lisp
3296 strings.
3297 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3298 (display_string): Support display of R2L glyph rows.
3299 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3300 (init_iterator): Don't initialize it->bidi_p for strings
3301 here.
3302 (reseat_to_string): Initialize it->bidi_p for strings here.
3303 (next_element_from_string, next_element_from_c_string)
3304 (next_element_from_buffer): Add xassert's for correspondence
3305 between IT's object being iterated and it->bidi_it.string
3306 structure.
3307 (face_before_or_after_it_pos): Support bidi iteration.
3308 (next_element_from_c_string): Handle the case of the first string
3309 character that is not the first one in the visual order.
3310 (get_visually_first_element): New function, refactored from common
3311 parts of next_element_from_buffer, next_element_from_string, and
3312 next_element_from_c_string.
3313 (tool_bar_lines_needed, redisplay_tool_bar)
3314 (display_menu_bar): Force left-to-right direction. Add a FIXME
3315 comment for making that be controlled by a user option.
3316 (push_it, pop_it): Save and restore the state of the
3317 bidi iterator. Save and restore the bidi_p flag.
3318 (pop_it): Iterate out of display property for string iteration as
3319 well.
3320 (iterate_out_of_display_property): Support iteration over strings.
3321 (handle_single_display_spec): Set up it->bidi_it for iteration
3322 over a display string, and call bidi_init_it.
3323 (handle_single_display_spec, next_overlay_string)
3324 (get_overlay_strings_1, push_display_prop): Set up the bidi
3325 iterator for displaying display or overlay strings.
3326 (forward_to_next_line_start): Don't use the shortcut if
3327 bidi-iterating.
3328 (back_to_previous_visible_line_start): If handle_display_prop
3329 pushed the iterator stack, restore the internal state of the bidi
3330 iterator by calling bidi_pop_it same number of times.
3331 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3332 and we are bidi-iterating, don't decrement the iterator position;
3333 instead, set the first_elt flag in the bidi iterator, to produce
3334 the same effect.
3335 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3336 (push_display_prop): xassert that we are iterating a buffer.
3337 (push_it, pop_it): Save and restore paragraph_embedding member.
3338 (handle_single_display_spec, next_overlay_string)
3339 (get_overlay_strings_1, reseat_1, reseat_to_string)
3340 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3341 correctly. Don't assume unibyte strings are not bidi-reordered.
3342 (compute_display_string_pos)
3343 (compute_display_string_end): Fix handling the case of C string.
3344 (push_it, pop_it): Save and restore from_disp_prop_p.
3345 (handle_single_display_spec, push_display_prop): Set the
3346 from_disp_prop_p flag.
3347 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3348 (pop_it): Call iterate_out_of_display_property only if we are
3349 popping after iteration over a string that came from a display
3350 property. Fix a typo in popping stretch info. Add an assertion
3351 for verifying that the iterator position is in sync with the bidi
3352 iterator.
3353 (handle_single_display_spec, get_overlay_strings_1)
3354 (push_display_prop): Fix initialization of paragraph direction for
3355 string when that of the parent object is not yet determined.
3356 (reseat_1): Call bidi_init_it to resync the bidi
3357 iterator with IT's position. (Bug#7616)
3358 (find_row_edges): If ROW->start.pos gives position
3359 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3360 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3361 Reset the from_disp_prop_p flag.
3362 (SAVE_IT, RESTORE_IT): New macros.
3363 (pos_visible_p, face_before_or_after_it_pos)
3364 (back_to_previous_visible_line_start)
3365 (move_it_in_display_line_to, move_it_in_display_line)
3366 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3367 (try_scrolling, redisplay_window, display_line): Use them when
3368 saving a temporary copy of the iterator and restoring it back.
3369 (back_to_previous_visible_line_start, reseat_1)
3370 (init_iterator): Empty the bidi cache "stack".
3371 (move_it_in_display_line_to): If iterator ended up at
3372 EOL, but we never saw any buffer positions smaller than
3373 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3374 motion in bidi-reordered lines.
3375 (move_it_in_display_line_to): Record prev_method and prev_pos
3376 immediately before the call to set_iterator_to_next. Fixes cursor
3377 motion in bidi-reordered lines with stretch glyphs and strings
3378 displayed in margins. (Bug#8133) (Bug#8867)
3379 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3380 TO_CHARPOS.
640c8776
SM
3381 (pos_visible_p): Support positions in bidi-reordered lines.
3382 Save and restore bidi cache.
0bb23927
EZ
3383
3384 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3385 (bidi_paragraph_info): Delete unused struct.
3386 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3387 (bidi_cache_start): New variable.
3388 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3389 to zero.
3390 (bidi_cache_fetch_state, bidi_cache_search)
3391 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3392 (bidi_cache_find, bidi_peek_at_next_level)
3393 (bidi_level_of_next_char, bidi_find_other_level_edge)
3394 (bidi_move_to_visually_next): Compare cache index with
3395 bidi_cache_start rather than with zero.
3396 (bidi_fetch_char): Accept new argument STRING; all callers
3397 changed. Support iteration over a string. Support strings with
3398 display properties. Support unibyte strings. Fix the type of
3399 `len' according to what STRING_CHAR_AND_LENGTH expects.
3400 (bidi_paragraph_init, bidi_resolve_explicit_1)
3401 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3402 (bidi_level_of_next_char, bidi_move_to_visually_next):
3403 Support iteration over a string.
0bb23927
EZ
3404 (bidi_set_sor_type, bidi_resolve_explicit_1)
3405 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3406 can now be zero (for strings); special values 0 and -1 were
3407 changed to -1 and -2, respectively.
3408 (bidi_char_at_pos): New function.
3409 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3410 Call it instead of FETCH_MULTIBYTE_CHAR.
3411 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3412 initialized to valid values.
3413 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3414 values.
3415 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3416 the test for valid cached positions. Fix the logic for looking up
3417 the sentinel state in the cache. GCPRO the Lisp string we are
3418 iterating.
3419 (bidi_push_it, bidi_pop_it): New functions.
3420 (bidi_initialize): Initialize the bidi cache start stack pointer.
3421 (bidi_cache_ensure_space): New function, refactored from part of
3422 bidi_cache_iterator_state. Don't assume the required size is just
3423 one BIDI_CACHE_CHUNK away.
3424 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3425 (bidi_count_bytes, bidi_char_at_pos): New functions.
3426 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3427 always valid if bidi_cache_idx is valid.
3428 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3429 is valid if it's going to be used.
3430 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3431 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3432 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3433 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3434 (bidi_find_other_level_edge, bidi_cache_start_stack):
3435 All variables related to cache indices are now EMACS_INT.
c965adc5 3436
0bb23927
EZ
3437 * dispextern.h (struct bidi_string_data): New structure.
3438 (struct bidi_it): New member `string'. Make flag members be 1-bit
3439 fields, and put them last in the struct.
640c8776
SM
3440 (compute_display_string_pos, compute_display_string_end):
3441 Update prototypes.
0bb23927
EZ
3442 (bidi_push_it, bidi_pop_it): Add prototypes.
3443 (struct iterator_stack_entry): New members bidi_p,
3444 paragraph_embedding, and from_disp_prop_p.
3445 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3446 (bidi_shelve_cache, bidi_unshelve_cache):
3447 Declare prototypes.
0bb23927
EZ
3448
3449 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3450 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3451 and vector-like objects.
3452
3453 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3454 cache around display iteration.
3455
3456 * window.c (Fwindow_end, window_scroll_pixel_based)
3457 (displayed_window_lines, Frecenter): Save and restore the bidi
3458 cache around display iteration.
3459
3bbd2265
LMI
34602011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3461
3462 * editfns.c (Fdelete_region): Clarify the use of the named
3463 parameters (bug#6788).
3464
adc47434
MR
34652011-07-14 Martin Rudalics <rudalics@gmx.at>
3466
3467 * indent.c (Fvertical_motion): Set and restore w->pointm when
3468 saving and restoring the window's buffer (Bug#9006).
3469
837c31f8
LMI
34702011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3471
3472 * editfns.c (Fstring_to_char): Clarify just what is returned
3473 (bug#6576). Text by Eli Zaretskii.
3474
ac389d0c
JB
34752011-07-13 Juanma Barranquero <lekktu@gmail.com>
3476
3477 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3478
0be0ce47
EZ
34792011-07-13 Eli Zaretskii <eliz@gnu.org>
3480
3481 * buffer.c (mmap_find): Fix a typo.
3482
cd18e7e3
JB
34832011-07-13 Johan Bockgård <bojohan@gnu.org>
3484
3485 Fix execution of x selection hooks.
3486 * xselect.c (Qx_lost_selection_functions)
3487 (Qx_sent_selection_functions): New vars.
3488 (syms_of_xselect): DEFSYM them.
3489 (x_handle_selection_request): Pass Qx_sent_selection_functions
3490 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3491 (x_handle_selection_clear,x_clear_frame_selections):
3492 Pass Qx_lost_selection_functions rather than
3493 Vx_lost_selection_functions to Frun_hook_with_args.
3494
47ea7f44
PE
34952011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3496
ac389d0c 3497 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3498 The old code sometimes used this field without initializing it.
3499
47ea7f44
PE
3500 * alloc.c (gc_sweep): Don't read past end of array.
3501 In theory, the old code could also have corrupted Emacs internals,
3502 though it'd be very unlikely.
3503
bc985c87
AS
35042011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3505
3506 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3507 argument. (Bug#4026)
bc985c87 3508
0cf34688
LMI
35092011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3510
b3dadd76
LMI
3511 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3512 key" (bug#4257).
3513
0cf34688
LMI
3514 * window.c (Fset_window_start): Doc fix (bug#4199).
3515 (Fset_window_hscroll): Ditto.
3516
270768cd
PE
35172011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3518
077e3dda 3519 Fix minor new problems caught by GCC 4.6.1.
270768cd 3520 * term.c (init_tty): Remove unused local.
490011a6 3521 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3522 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3523 not used otherwise.
270768cd 3524
b1f58454
CY
35252011-07-12 Chong Yidong <cyd@stupidchicken.com>
3526
3527 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3528
22b9578d
LMI
35292011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3530
6e70ab07
LMI
3531 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3532 are the mini-buffer and the echo area (bug#3320).
3533
22b9578d
LMI
3534 * term.c (init_tty): Remove support for supdup, c10 and perq
3535 terminals, which are no longer supported (bug#1482).
3536
8974cc9f
JB
35372011-07-10 Johan Bockgård <bojohan@gnu.org>
3538
3539 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3540
a560d974
JD
35412011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3542
3543 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3544 for non-popups (Bug#3642).
3545
1dae0f0a
AS
35462011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3547
268c2c36 3548 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3549 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3550 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3551 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3552 * data.c (fmod): Likewise.
3553 * dispnew.c (swap_glyphs_in_rows): Likewise.
3554 * emacs.c (memory_warning_signal): Likewise.
3555 * floatfns.c (float_error): Likewise.
3556 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3557 (otf_open, font_otf_capability, generate_otf_features)
3558 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3559 Likewise.
3560 * image.c (pbm_read_file): Likewise.
3561 * indent.c (string_display_width): Likewise.
3562 * intervals.c (check_for_interval, search_for_interval)
3563 (inc_interval_count, count_intervals, root_interval)
3564 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3565 * lread.c (defalias): Likewise.
268c2c36 3566 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3567 * regex.c (set_image_of_range_1, set_image_of_range)
3568 (regex_grow_registers): Likewise.
3569 * sysdep.c (strerror): Likewise.
3570 * termcap.c (valid_filename_p, tprint, main): Likewise.
3571 * tparam.c (main): Likewise.
3572 * unexhp9k800.c (run_time_remap, save_data_space)
3573 (update_file_ptrs, read_header, write_header, calculate_checksum)
3574 (copy_file, copy_rest, display_header): Likewise.
3575 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3576 Likewise.
3577 * xdisp.c (check_it): Likewise.
3578 * xfaces.c (register_color, unregister_color, unregister_colors):
3579 Likewise.
3580 * xfns.c (print_fontset_result): Likewise.
3581 * xrdb.c (member, fatal, main): Likewise.
3582
99033785
PE
35832011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3584
3585 Fix minor problems found by static checking (Bug#9031).
3586 * chartab.c (char_table_set_range, map_sub_char_table):
3587 Remove unused locals.
3588 (uniprop_table): Now static.
3589 * composite.c (_work_char): Remove unused static var.
3590
9cb2ac56
JB
35912011-07-09 Juanma Barranquero <lekktu@gmail.com>
3592
3593 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3594
f25661f0
JD
35952011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3596
3597 * gtkutil.c (qttip_cb): Remove code without function.
3598
8278c4fe
EZ
35992011-07-09 Eli Zaretskii <eliz@gnu.org>
3600
3601 * w32.c (pthread_sigmask): New stub.
3602
1692ae2d 36032011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3604
8a6ebd58 3605 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3606 sigprocmask is portable only for single-threaded applications, and
3607 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3608 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3609 (LIBES): Use it.
3610 * callproc.c (Fcall_process):
3611 * process.c (create_process):
3612 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3613 Use pthread_sigmask, not sigprocmask.
123403e4 3614
1b854618
JD
36152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3616
3617 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3618 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3619 wrong (Bug#8591).
3620
3fe4b549
JD
36212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3622
0ce7e563
JD
3623 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3624 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3625 (xg_hide_tooltip): Fix comment.
3626
3fe4b549
JD
3627 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3628 in registerServicesMenuSendTypes.
3629 (validRequestorForSendType): Don't check ns_return_types.
3630
3631 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3632 ns_return_type.
3633
5df75e47
JR
36342011-07-08 Jason Rumney <jasonr@gnu.org>
3635
22610910
JR
3636 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3637 SH_SHOW for hidden windows (Bug#5482).
3638
5df75e47
JR
3639 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3640 frame struct members of non-existent frames (Bug#6284).
3641
699c10bd
JD
36422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3643
4393663b
JD
3644 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3645 variable firstTime not needed on OSX >= 10.6.
3646 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3647 >= 10.5. Use setKnobProportion, setDoubleValue.
3648
3649 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3650 (MAC_OS_X_VERSION_10_5): Define if not defined.
3651 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3652 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3653 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3654
3655 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3656 cString and lossyCString on OSX >= 10.4
3657
58179cce 3658 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3659 sizeToFit on OSX >= 10.2.
3660
3661 * nsimage.m (allocInitFromFile): Don't use deprecated method
3662 bestRepresentationForDevice on OSX >= 10.6.
3663
3664 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3665 to avoid warning.
3666
3667 * emacs.c: Declare unexec_init_emacs_zone.
3668
a63e0781
JD
3669 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3670
699c10bd
JD
3671 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3672
3673 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3674 on svcsMenu (Bug#8842).
3675
3676 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3677 ns_return_types.
3678 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3679
3680 * nsterm.m (QUTF8_STRING): Declare.
3681 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3682 (validRequestorForSendType): Return type is (id).
3683 Change indexOfObjectIdenticalTo to indexOfObject.
3684 Check if we have local selection before returning self (Bug#8842).
3685 (writeSelectionToPasteboard): Put local selection into paste board
3686 if we have a local selection (Bug#8842).
3687 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3688
3689 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3690 (ns_get_local_selection): Declare.
3691
54e10184
LMI
36922011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3693
9888ff71
LMI
3694 * keymap.c (describe_map_tree): Don't insert a double newline at
3695 the end of the buffer (bug#1169) and return whether we inserted
3696 something.
3697
54e10184
LMI
3698 * callint.c (Fcall_interactively): Change "reading args" to
3699 "providing args" to try to clarify what it does (bug#1010).
3700
15fa4783
KH
37012011-07-07 Kenichi Handa <handa@m17n.org>
3702
3703 * composite.c (composition_compute_stop_pos): Ignore a static
3704 composition starting before CHARPOS (Bug#8915).
3705
3706 * xdisp.c (handle_composition_prop): Likewise.
3707
a8815b00
EZ
37082011-07-07 Eli Zaretskii <eliz@gnu.org>
3709
3710 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3711 (Bug#9015)
3712
ef7b981d 37132011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3714
3715 * character.h (unicode_category_t): New enum type.
3716
3717 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3718 (Qchar_code_property_table): New variable.
3719 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3720 (UNIPROP_COMPRESSED_FORM_P): New macros.
3721 (char_table_ascii): Uncompress the compressed values.
3722 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3723 Uncompress the compressed values.
ac389d0c 3724 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3725 (char_table_ref_and_range): Uncompress the compressed values.
3726 (sub_char_table_set): New arg is_uniprop. Callers changed.
3727 Uncompress the compressed values.
3728 (sub_char_table_set_range): Args changed. Callers changed.
3729 (char_table_set_range): Adjuted for the above change.
3730 (map_sub_char_table): Delete args default_val and parent. Add arg
3731 top. Give decoded values to a Lisp function.
640c8776 3732 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3733 values to a Lisp function. Gcpro more variables.
3734 (uniprop_table_uncompress)
3735 (uniprop_decode_value_run_length): New functions.
3736 (uniprop_decoder, uniprop_decoder_count): New variables.
3737 (uniprop_get_decoder, uniprop_encode_value_character)
3738 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3739 New functions.
3740 (uniprop_encoder, uniprop_encoder_count): New variables.
3741 (uniprop_get_encoder, uniprop_table)
3742 (Funicode_property_table_internal, Fget_unicode_property_internal)
3743 (Fput_unicode_property_internal): New functions.
3744 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3745 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3746 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3747 char-code-property-alist.
3748
640c8776 3749 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3750 Vunicode_category_table.
3751
640c8776 3752 * font.c (font_range): Adjust for the change of
c805dec0
KH
3753 Vunicode_category_table.
3754
76b397fb
DN
37552011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3756
3757 * m/iris4d.h: Remove file, move contents ...
3758 * s/irix6-5.h: ... here.
3759
22b4128e
PE
37602011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3761
3762 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3763 * alloc.c (mark_buffer):
3764 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3765 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3766 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3767 This isn't true in general, and it's particularly not true
3768 if Emacs is configured with --with-wide-int.
3769 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3770 New macros, used in the buffer.c change.
3771
869795d6
JD
37722011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3773
3774 * xsettings.c: Use both GConf and GSettings if both are available.
3775 (store_config_changed_event): Add comment.
3776 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3777 (store_tool_bar_style_changed): New functions.
5e617bc2 3778 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3779 (struct xsettings): Move font inside HAVE_XFT.
3780 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3781 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3782 Move inside HAVE_XFT.
640c8776 3783 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3784 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3785 also.
3786 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3787 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3788 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3789 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3790 (parse_settings): Move check for font inside HAVE_XFT.
3791 (read_settings, apply_xft_settings): Add comment.
3792 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3793 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3794 call store_font_name_changed.
3795 (xft_settings_event): Add comment.
3796 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3797 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3798 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3799 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3800 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3801 (xsettings_get_system_font, xsettings_get_system_normal_font):
3802 Add comment.
869795d6 3803
d8ed26bd
PE
38042011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3805
3806 Random fixes. E.g., (random) never returned negative values.
3807 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3808 subseconds part to the entropy, as that's a bit more random.
3809 Prefer signed to unsigned, since the signedness doesn't matter and
3810 in general we prefer signed. When given a limit, use a
3811 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3812 latter isn't right if USE_2_TAGS_FOR_INTS.
3813 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3814 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3815
cabf1cac
SM
38162011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3817
3818 * textprop.c (text_property_stickiness):
3819 Obey Vtext_property_default_nonsticky.
3820 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3821 * w32fns.c (syms_of_w32fns):
3822 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3823
6e9b2be9
PE
38242011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3825
3826 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3827 This is more efficient than Ffile_directory_p and avoids a minor race.
3828
90186c68
LMI
38292011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3830
7c301272
LMI
3831 * buffer.c (Foverlay_put): Say what the return value is
3832 (bug#7835).
3833
c4f2d8d4
LMI
3834 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3835 is a directory before asking whether to use the file name
3836 (bug#7564).
ad637907
LMI
3837 (barf_or_query_if_file_exists): Make the "File is a directory"
3838 error be more correct.
c4f2d8d4 3839
90186c68
LMI
3840 * fns.c (Frequire): Remove the mention of the .gz files, since
3841 that's installation-specific, but keep the mention of
3842 `get-load-suffixes'.
3843
da64016e
PE
38442011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3845
3846 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3847 Report string overflow if the output is too long.
3848
7d47b580
JB
38492011-07-04 Juanma Barranquero <lekktu@gmail.com>
3850
a555cb87
JB
3851 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3852 (syms_of_gnutls): Remove duplicate DEFSYM for
3853 Qgnutls_bootprop_verify_hostname_error, an error for
3854 Qgnutls_bootprop_verify_error (which is no longer used).
3855
7d47b580
JB
3856 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3857 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3858 Also (re)move comments that are misplaced or no longer relevant.
3859
1e49bfab
LMI
38602011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3861
3862 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3863
1485f4c0
CY
38642011-07-03 Chong Yidong <cyd@stupidchicken.com>
3865
3866 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3867 and background color parameters if they have been changed.
3868
a9ab721e
LMI
38692011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3870
3871 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3872
cf7cff57
PE
38732011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3874
2e13213d
PE
3875 * xsettings.c (SYSTEM_FONT): Define only when used.
3876 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3877
cf7cff57
PE
3878 * keymap.c (access_keymap_1): Now static.
3879
7a8e04f7
CY
38802011-07-02 Chong Yidong <cyd@stupidchicken.com>
3881
3882 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3883 leave any prefix arg for the up event (Bug#1586).
3884
61352f62
LMI
38852011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3886
69bb1ef7
LMI
3887 * lread.c (syms_of_lread): Mention single symbols defined by
3888 `defvar' or `defconst' (bug#7154).
3889
61352f62 3890 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3891 (Frequire): Mention get-load-suffixes.
61352f62 3892
28545e04
MR
38932011-07-02 Martin Rudalics <rudalics@gmx.at>
3894
3895 * window.h (window): Remove clone_number slot.
3896 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3897 Remove.
3898 (make_parent_window, make_window, saved_window)
3899 (Fset_window_configuration, save_window_save): Don't deal with
3900 clone numbers.
3901 * buffer.c (Qclone_number): Remove declaration.
3902 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3903
3349e122
SM
39042011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3905
3906 Add multiple inheritance to keymaps.
3907 * keymap.c (Fmake_composed_keymap): New function.
3908 (Fset_keymap_parent): Simplify.
3909 (fix_submap_inheritance): Remove.
3910 (access_keymap_1): New function extracted from access_keymap to handle
3911 embedded parents and handle lists of maps.
3912 (access_keymap): Use it.
3913 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3914 (Fcopy_keymap): Handle embedded parents.
3915 (Fcommand_remapping, define_as_prefix): Simplify.
3916 (Fkey_binding): Simplify.
3917 (syms_of_keymap): Move minibuffer-local-completion-map,
3918 minibuffer-local-filename-completion-map,
3919 minibuffer-local-must-match-map, and
3920 minibuffer-local-filename-must-match-map to Elisp.
3921 (syms_of_keymap): Defsubr make-composed-keymap.
3922 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3923 (parse_menu_item): Trivial simplification.
3924
3279eb87
GM
39252011-07-01 Glenn Morris <rgm@gnu.org>
3926
3927 * Makefile.in (SETTINGS_LIBS): Fix typo.
3928
4550efdf
KI
39292011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3930
3931 * coding.c (Fencode_coding_string): Record the last coding system
3932 used, as the function doc string says (bug#8738).
3933
0949d2b6
JD
39342011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3935
3936 * xsettings.c (store_monospaced_changed): Take new font as arg and
3937 check for change against current_mono_font.
3938 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3939 (emacs_settings_constructor, emacs_settings_get_property)
3940 (emacs_settings_set_property, emacs_settings_class_init)
3941 (emacs_settings_init, gsettings_obj): Remove.
3942 (something_changedCB): New function for HAVE_GSETTINGS.
3943 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3944 with value as argument.
3945 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3946 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3947 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3948 "changed".
3949
3950 * xgselect.c: Add defined (HAVE_GSETTINGS).
3951 (xgselect_initialize): Ditto.
3952
3953 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3954 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3955 xg_select.
3956
bbc6b304
PE
39572011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3958
3959 * eval.c (struct backtrace): Simplify and port the data structure.
3960 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3961 signed bit field, as this assumption is not portable and it makes
3962 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3963 "char debug_on_exit : 1" as this is not portable either; instead,
3964 use the portable "unsigned int debug_on_exit : 1". Remove unused
3965 member evalargs. Remove obsolete comments about cc bombing out.
3966
9851bfc5
JD
39672011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3968
51bb811f 3969 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3970 Let HAVE_GSETTINGS override HAVE_GCONF.
3971 (store_monospaced_changed): New function.
3972 (EMACS_SETTINGS): A new type derived from GObject to handle
3973 GSettings notifications.
3974 (emacs_settings_constructor, emacs_settings_get_property)
3975 (emacs_settings_set_property, emacs_settings_class_init):
3976 New functions.
3977 (gsettings_client, gsettings_obj): New variables.
3978 (GSETTINGS_SCHEMA): New define.
3979 (something_changedCB): Call store_monospaced_changed.
3980 (init_gsettings): New function.
3981 (xsettings_initialize): Call init_gsettings.
3982 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3983 to NULL.
3984
640c8776 3985 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3986 GCONF_CFLAGS/LIBS.
3987
5386012d
MR
39882011-06-29 Martin Rudalics <rudalics@gmx.at>
3989
3990 * window.c (resize_root_window, grow_mini_window)
3991 (shrink_mini_window): Rename Qresize_root_window to
3992 Qwindow_resize_root_window and Qresize_root_window_vertically to
3993 Qwindow_resize_root_window_vertically.
3994
f13e0b08
PE
39952011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3996
3997 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3998
94515237
JB
39992011-06-27 Juanma Barranquero <lekktu@gmail.com>
4000
4001 * makefile.w32-in: Redesign dependencies so they reflect more
4002 clearly which files are directly included by each source file,
4003 and not through other includes.
4004
e43b6e43
MR
40052011-06-27 Martin Rudalics <rudalics@gmx.at>
4006
4007 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4008 (sort_overlays, overlay_strings): When an overlay's clone number
4009 matches the window's clone number process the overlay even if
4010 the overlay's window property doesn't match the current window.
4011
d68443dc
MR
4012 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4013 (Fwindow_hchild): Rename to Fwindow_left_child.
4014 (Fwindow_next): Rename to Fwindow_next_sibling.
4015 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4016 (resize_window_check): Rename to window_resize_check.
4017 (resize_window_apply): Rename to window_resize_apply.
4018 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4019 (Fdelete_other_windows_internal, resize_frame_windows)
4020 (Fsplit_window_internal, Fdelete_window_internal)
4021 (grow_mini_window, shrink_mini_window)
4022 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4023
c7e73be5
JD
40242011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4025
4026 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4027 (emacs_fixed_set_min_size): Remove.
4028 (emacs_fixed_new): Take frame as argument.
4029
4030 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4031 (_EmacsFixedPrivate): Remove minwidth/height.
4032 Add struct frame *f.
4033 (emacs_fixed_init): Initialize priv->f.
4034 (get_parent_class, emacs_fixed_set_min_size): Remove.
4035 (emacs_fixed_new): Set priv->f to argument.
4036 (emacs_fixed_get_preferred_width)
4037 (emacs_fixed_get_preferred_height): Use min_width/height from
4038 frames size_hint to set minimum and natural (Bug#8919).
4039 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4040 and use min_width/height from frames size_hint to set
4041 min_width/height (Bug#8919).
4042
4043 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4044 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4045 Fix indentation.
c7e73be5 4046
cf99dcf8
EZ
40472011-06-26 Eli Zaretskii <eliz@gnu.org>
4048
4049 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4050 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4051 called at ZV.
4052
029529ac
CY
40532011-06-26 Chong Yidong <cyd@stupidchicken.com>
4054
4055 * process.c (wait_reading_process_output): Bypass select if
4056 waiting for a cell while ignoring keyboard input, and input is
4057 pending. Suggested by Jan Djärv (Bug#8869).
4058
7a7ef429
PE
40592011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4060
4061 Use gnulib's dup2 module instead of rolling our own.
4062 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4063
11fdef7d 40642011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4065
4066 * dispnew.c (scrolling_window): Before scrolling, turn off a
4067 mouse-highlight in the window being scrolled.
4068
cd3520a4
JB
40692011-06-24 Juanma Barranquero <lekktu@gmail.com>
4070
4071 Move DEFSYM to lisp.h and use everywhere.
4072
4073 * character.h (DEFSYM): Move declaration...
4074 * lisp.h (DEFSYM): ...here.
4075
4076 * gnutls.c:
4077 * minibuf.c:
4078 * w32menu.c:
4079 * w32proc.c:
4080 * w32select.c: Don't include character.h.
4081
4082 * alloc.c (syms_of_alloc):
4083 * buffer.c (syms_of_buffer):
4084 * bytecode.c (syms_of_bytecode):
4085 * callint.c (syms_of_callint):
4086 * casefiddle.c (syms_of_casefiddle):
4087 * casetab.c (init_casetab_once):
4088 * category.c (init_category_once, syms_of_category):
4089 * ccl.c (syms_of_ccl):
4090 * cmds.c (syms_of_cmds):
4091 * composite.c (syms_of_composite):
4092 * dbusbind.c (syms_of_dbusbind):
4093 * dired.c (syms_of_dired):
4094 * dispnew.c (syms_of_display):
4095 * doc.c (syms_of_doc):
4096 * editfns.c (syms_of_editfns):
4097 * emacs.c (syms_of_emacs):
4098 * eval.c (syms_of_eval):
4099 * fileio.c (syms_of_fileio):
4100 * fns.c (syms_of_fns):
4101 * frame.c (syms_of_frame):
4102 * fringe.c (syms_of_fringe):
4103 * insdel.c (syms_of_insdel):
4104 * keymap.c (syms_of_keymap):
4105 * lread.c (init_obarray, syms_of_lread):
4106 * macros.c (syms_of_macros):
4107 * msdos.c (syms_of_msdos):
4108 * print.c (syms_of_print):
4109 * process.c (syms_of_process):
4110 * search.c (syms_of_search):
4111 * sound.c (syms_of_sound):
4112 * syntax.c (init_syntax_once, syms_of_syntax):
4113 * terminal.c (syms_of_terminal):
4114 * textprop.c (syms_of_textprop):
4115 * undo.c (syms_of_undo):
4116 * w32.c (globals_of_w32):
4117 * window.c (syms_of_window):
4118 * xdisp.c (syms_of_xdisp):
4119 * xfaces.c (syms_of_xfaces):
4120 * xfns.c (syms_of_xfns):
4121 * xmenu.c (syms_of_xmenu):
4122 * xsettings.c (syms_of_xsettings):
4123 * xterm.c (syms_of_xterm): Use DEFSYM.
4124
4228cf16
TZ
41252011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4126
cd3520a4 4127 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4128
7fcccf1e
PE
41292011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4130
7efb4e0e
PE
4131 Integer and buffer overflow fixes (Bug#8873).
4132
ff5844ad
PE
4133 * print.c (printchar, strout): Check for string overflow.
4134 (PRINTPREPARE, printchar, strout):
4135 Don't set size unless allocation succeeds.
4136
90532f02
PE
4137 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4138 for sizes. Check for string overflow more accurately.
4139 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4140
6d84508d
PE
4141 * macros.c: Integer and buffer overflow fixes.
4142 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4143 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4144 Use ptrdiff_t, not int, for sizes.
4145 Don't increment bufsize until after realloc succeeds.
4146 Check for size-calculation overflow.
4147 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4148
437b2cb4
PE
4149 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4150
8b9ac8b4
PE
4151 * lread.c: Integer overflow fixes.
4152 (read_integer): Radix is now EMACS_INT, not int,
4153 to improve quality of diagnostics for out-of-range radices.
4154 Calculate buffer size correctly for out-of-range radices.
4155 (read1): Check for integer overflow in radices, and in
4156 read-circle numbers.
82cb60d3
PE
4157 (read_escape): Avoid int overflow.
4158 (Fload, openp, read_buffer_size, read1)
4159 (substitute_object_recurse, read_vector, read_list, map_obarray):
4160 Use ptrdiff_t, not int, for sizes.
4161 (read1): Use EMACS_INT, not int, for sizes.
20270765 4162 Check for size overflow.
8b9ac8b4 4163
7fcccf1e
PE
4164 * image.c (cache_image): Check for size arithmetic overflow.
4165
bfbbd7e7
PE
4166 * lread.c: Integer overflow issues.
4167 (saved_doc_string_size, saved_doc_string_length)
4168 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4169 Now ptrdiff_t, not int.
4170 (read1): Don't assume doc string length fits in int. Check for
4171 out-of-range doc string lengths.
4172 (read_list): Don't assume file position fits in int.
39019e54 4173 (read_escape): Check for hex character overflow.
bfbbd7e7 4174
4e323265
LL
41752011-06-22 Leo Liu <sdl.web@gmail.com>
4176
4177 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4178 Move to minibuffer.el.
4179
85fece3e
PE
41802011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4181
20b84ce9 4182 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4183 The following patches are for when GLYPH_DEBUG && !XASSERT.
4184 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4185 * dispnew.c (flush_stdout):
4186 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4187 Mark as externally visible.
4188 * dispnew.c (check_window_matrix_pointers): Now static.
4189 * dispnew.c (window_to_frame_vpos):
4190 * xfns.c (unwind_create_frame):
4191 * xterm.c (x_check_font): Remove unused local.
4192 * scroll.c (CHECK_BOUNDS):
4193 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4194 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4195 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4196 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4197 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4198 Now static.
4199 (debug_method_add): Use va_list and vsprintf rather than relying
4200 on undefined behavior with wrong number of arguments.
4201 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4202 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4203 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4204 since we're not interested in debugging glyphs with old libraries.
4205 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4206 GCC 4.6.0's static checking.
4207
0766b489
PE
42082011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4209
31fd4b32
PE
4210 Integer overflow and signedness fixes (Bug#8873).
4211 A few related buffer overrun fixes, too.
4212
b79e8648
PE
4213 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4214
0766b489
PE
4215 * dispextern.h (struct face.stipple):
4216 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4217 (x_bitmap_mask, x_allocate_bitmap_record)
4218 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4219 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4220 (x_create_bitmap_from_xpm_data):
4221 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4222 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4223 (.bitmaps_last):
4224 * xfaces.c (load_pixmap):
4225 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4226 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4227 (.bitmaps_last, struct x_output.icon_bitmap):
4228 Use ptrdiff_t, not int, for bitmap indexes.
4229 (x_allocate_bitmap_record): Check for size overflow.
4230 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4231
b081724f
PE
4232 Use ptrdiff_t, not int, for overlay counts.
4233 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4234 * editfns.c (overlays_around, get_pos_property):
4235 * textprop.c (get_char_property_and_overlay):
4236 * xdisp.c (next_overlay_change, note_mouse_highlight):
4237 * xfaces.c (face_at_buffer_position):
21514da7
PE
4238 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4239 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4240 (Fnext_overlay_change, Fprevious_overlay_change)
4241 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4242 Use ptrdiff_t, not int, for sizes.
21514da7 4243 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4244
3de73e5e
PE
4245 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4246
2606c57b
PE
4247 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4248 (x_session_initialize): Do not assume string length fits in int.
4249
aaafe47a
PE
4250 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4251 This is unlikely, but can occur if DPI is outlandish.
4252
2674ddc8 4253 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4254 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4255
28154962
PE
4256 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4257 * xrdb.c (magic_file_p, search_magic_path):
4258 Omit last arg SUFFIX; it was always 0. All callers changed.
4259 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4260
7de51af5
PE
4261 * xfont.c (xfont_match): Avoid need for strlen.
4262
25ed6cc3
PE
4263 * xfns.c: Don't assume strlen fits in int.
4264 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4265
4eab31dd
PE
4266 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4267 not unsigned long, as we prefer signed integers. All callers changed.
4268 Detect integer overflow in repeat count.
4269 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4270 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4271
171e2a58
PE
4272 * termcap.c: Don't assume sizes fit in int and never overflow.
4273 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4274 (gobble_line): Check for size-calculation overflow.
4275
ad39faca 4276 * minibuf.c (Fread_buffer):
6e5bb2dc 4277 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4278 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4279 Don't assume string length fits in int.
4280
52c61c22 4281 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4282 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4283
b5b8c9e5
PE
4284 * font.c: Don't assume string length fits in int.
4285 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4286 Use ptrdiff_t, not int.
ccd6111c
PE
4287 (font_intern_prop): Don't assume string length fits in int.
4288 Don't assume integer property fits in fixnum.
4289 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4290
882f0d81 4291 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4292 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4293 Reformulate so as not to need the command string.
4294 Invoke gzip -cd rather than gunzip, as it's more portable.
4295 (lock_info_type, lock_file_1, lock_file):
4296 Don't assume pid_t and time_t fit in unsigned long.
4297 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4298 (current_lock_owner): Prefer signed type for sizes.
4299 Use memcpy, not strncpy, where memcpy is what is really wanted.
4300 Don't assume (via atoi) that time_t and pid_t fit in int.
4301 Check for time_t and/or pid_t out of range, e.g., via a network share.
4302 Don't alloca where an auto var works fine.
4303
93f4cf88
PE
4304 * fileio.c: Fix some integer overflow issues.
4305 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4306 Don't assume string length fits in int.
4307 (directory_file_name): Don't assume string length fits in long.
4308 (make_temp_name): Don't assume pid fits in int, or that its print
4309 length is less than 20.
4310
f3e92b69
PE
4311 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4312
1bfdaf10
PE
4313 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4314
35016e9a
PE
4315 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4316
3d1e65a1
PE
4317 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4318 We prefer signed integers, even for size calculations.
4319
0b963a93
PE
4320 * emacs.c: Don't assume string length fits in 'int'.
4321 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4322 (main): Don't invoke strlen when not needed.
4323
573f4b54
PE
4324 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4325 (XD_DEBUG_MESSAGE): Don't waste a byte.
4326
989f33ba
PE
4327 * callproc.c (getenv_internal_1, getenv_internal)
4328 (Fgetenv_internal):
965d34eb
PE
4329 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4330
e4d29b33
PE
4331 * lread.c (invalid_syntax): Omit length argument.
4332 All uses changed. This doesn't fix a bug, but it simplifies the
4333 code away from its former Hollerith-constant appearance, and it's
4334 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4335 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4336
eb49b136
PE
4337 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4338 This didn't break anything, but it didn't help either.
4339 It's confusing to put a bogus integer in a place where the actual
4340 value does not matter.
9f62aeb1 4341 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4342 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4343
15375a22
PE
4344 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4345 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4346 implementation.
b61cc01c
PE
4347 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4348 We prefer signed types, and the value cannot exceed the EMACS_INT
4349 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4350 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4351 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4352 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4353
53b2623d
PE
4354 * indent.c (sane_tab_width): New function.
4355 (current_column, scan_for_column, Findent_to, position_indentation)
4356 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4357 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4358
51cab52b 4359 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4360
f2ed8a70
PE
4361 * lisp.h (lint_assume): New macro.
4362 * composite.c (composition_gstring_put_cache):
4363 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4364
abe80cc6
PE
4365 * editfns.c, insdel.c:
4366 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4367
b02c740e
PE
4368 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4369
ebc96716
PE
4370 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4371
b4e50fa0 4372 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4373 Use much-faster test for byte-length change.
311d5d7c 4374 Don't assume string byte-length fits in 'int'.
a4cf38e4 4375 Check that character arg fits in 'int'.
85461888 4376 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4377
c0c1ee9f
PE
4378 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4379
a498d7f4
PE
4380 * fns.c (concat): Catch string overflow earlier.
4381 Do not rely on integer wraparound.
4382
51cab52b
PE
4383 * dispextern.h (struct it.overlay_strings_charpos)
4384 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4385 * xdisp.c (forward_to_next_line_start)
4386 (back_to_previous_visible_line_start)
4387 (reseat_at_next_visible_line_start, next_element_from_buffer):
4388 Don't arbitrarily truncate the value of 'selective' to int.
4389
76031fad
PE
4390 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4391
5eb55db9
PE
4392 * composite.c: Don't truncate sizes to 'int'.
4393 (composition_gstring_p, composition_reseat_it)
4394 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4395 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4396 not EMACS_UINT, for indexes.
5eb55db9 4397
0703a717
PE
4398 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4399
d6202519
PE
4400 * buffer.c: Include <verify.h>.
4401 (struct sortvec.priority, struct sortstr.priority):
8961a454 4402 Now EMACS_INT, not int.
c20998a7 4403 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4404 (struct sortstr.size, record_overlay_string)
4405 (struct sortstrlist.size, struct sortlist.used):
4406 Don't truncate size to int.
4407 (record_overlay_string): Check for size-calculation overflow.
d6202519 4408 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4409
d5a19415
JM
44102011-06-22 Jim Meyering <meyering@redhat.com>
4411
029529ac 4412 Don't leak an XBM-image-sized buffer
d5a19415
JM
4413 * image.c (xbm_load): Free the image buffer after using it.
4414
a9041e6c
PE
44152011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4416
4417 Port to Sun C.
4418 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4419 that Sun C diagnosed.
4420 * fns.c (secure_hash): Fix pointer signedness issue.
4421 * intervals.c (static_offset_intervals): New function.
4422 (offset_intervals): Use it.
4423
7f3f739f
LL
44242011-06-21 Leo Liu <sdl.web@gmail.com>
4425
4426 * deps.mk (fns.o):
4427 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4428 sha512.h.
4429
4430 * fns.c (secure_hash): Rename from crypto_hash_function and change
4431 the first arg to accept symbols.
5b66d427 4432 (Fsecure_hash): New primitive.
7f3f739f
LL
4433 (syms_of_fns): New symbols.
4434
76147d94
DD
44352011-06-20 Deniz Dogan <deniz@dogan.se>
4436
4437 * process.c (Fset_process_buffer): Clarify return value in
4438 docstring.
4439
7d7d0045
CY
44402011-06-18 Chong Yidong <cyd@stupidchicken.com>
4441
4442 * dispnew.c (add_window_display_history): Use BVAR.
4443
4444 * xdisp.c (debug_method_add): Use BVAR.
4445 (check_window_end, dump_glyph_matrix, dump_glyph)
4446 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4447
4448 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4449 Likewise.
4450
4451 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4452 check till after the cache is created in init_frame_faces.
4453
ff2bc410
SM
44542011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4455
4456 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4457
28177add
PE
44582011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4459
dd3482fe
PE
4460 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4461 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4462 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4463
393d71f3 4464 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4465 * fileio.c (Finsert_file_contents):
4466 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4467 Remove the old (too-loose) buffer overflow checks.
4468 They weren't needed, since make_gap checks for buffer overflow.
4469 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4470 The old code merely checked for Emacs fixnum overflow, and relied
4471 on undefined (wraparound) behavior. The new code avoids undefined
4472 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4473
2e6813b0 4474 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4475 Tune. Don't use wider integers than needed. Don't use alloca.
4476 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4477
599a9e4f
PE
4478 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4479
99561444
PE
4480 * insdel.c, lisp.h (buffer_overflow): New function.
4481 (insert_from_buffer_1, replace_range, replace_range_2):
4482 * insdel.c (make_gap_larger):
4483 * editfns.c (Finsert_char):
4484 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4485
28177add
PE
4486 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4487
e69dafad
PE
44882011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4489
4baa020d 4490 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4491
b1c46f02
PE
4492 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4493 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4494
e69dafad
PE
4495 * fileio.c: Don't assume EMACS_INT fits in off_t.
4496 (emacs_lseek): New static function.
4497 (Finsert_file_contents, Fwrite_region): Use it.
4498 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4499
566684ea
PE
4500 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4501
e6966cd6
PE
4502 * fns.c: Don't overflow int when computing a list length.
4503 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4504 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4505 truncation on 64-bit hosts. Check for QUIT every
4506 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4507 faster and is responsive enough.
4508 (Flength): Report an error instead of overflowing an integer.
4509 (Fsafe_length): Return a float if the value is not representable
4510 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4511 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4512 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4513
dd0b0efb
PE
4514 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4515 (header_size, word_size): New constants.
4516 (allocate_vectorlike): Don't check size overflow here.
4517 (allocate_vector): Check it here instead, since this is the only
4518 caller of allocate_vectorlike that could cause overflow.
4519 Check that the new vector's length is representable as a fixnum.
4520
86fe5cfe
PE
4521 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4522 The previous code was bogus. For example, next_almost_prime (32)
4523 returned 39, which is undesirable as it is a multiple of 3; and
4524 next_almost_prime (24) returned 25, which is a multiple of 5 so
4525 why was the code bothering to check for multiples of 7?
4526
80e88859
PE
4527 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4528
4a2f0ad6
PE
4529 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4530
f66c7cf8
PE
4531 Variadic C functions now count arguments with ptrdiff_t.
4532 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4533 Back then I didn't know that the Emacs coding style prefers signed int.
4534 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4535 were being counted with int, which may truncate counts on 64-bit
4536 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4537 * lisp.h (struct Lisp_Subr.function.aMANY)
4538 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4539 Arg counts are now ptrdiff_t, not size_t.
4540 All variadic functions and their callers changed accordingly.
4541 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4542 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4543 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4544 * callint.c (Fcall_interactively): Check arg count for overflow,
4545 to avoid potential buffer overrun. Use signed char, not 'int',
4546 for 'varies' array, so that we needn't bother to check its size
4547 calculation for overflow.
4548 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4549 * eval.c (apply_lambda):
4550 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4551 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4552 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4553
a1759b76
PE
4554 * callint.c (Fcall_interactively): Don't use index var as event count.
4555
d96be9fc
PE
4556 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4557 * mem-limits.h (SIZE): Remove; no longer used.
4558
a690a978 4559 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4560
578c21e6
PE
4561 Remove unnecessary casts.
4562 * xterm.c (x_term_init):
4563 * xfns.c (x_set_border_pixel):
4564 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4565 These aren't needed now that we assume ANSI C.
4566
96f53c6c
PE
4567 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4568 It's more likely to cause problems (due to unsigned overflow)
4569 than to cure them.
4570
83c77d31
PE
4571 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4572
ee2079f1
PE
4573 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4574
6da65536
PE
4575 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4576
7147c4a4
PE
4577 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4578
193e32d9
PE
4579 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4580
e5533da6
PE
4581 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4582
9910e595
PE
4583 GLYPH_CODE_FACE returns EMACS_INT, not int.
4584 * dispextern.h (merge_faces):
4585 * xfaces.c (merge_faces):
01103c44
PE
4586 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4587 Don't assume EMACS_INT fits in int.
9910e595 4588
2638320e
PE
4589 * character.h (CHAR_VALID_P): Remove unused parameter.
4590 * fontset.c, lisp.h, xdisp.c: All uses changed.
4591
045eb8d9
PE
4592 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4593
c1f134b5
PE
4594 * fns.c (concat): Minor tuning based on overflow analysis.
4595 This doesn't fix any bugs. Use int to hold character, instead
4596 of constantly refetching from Emacs object. Use XFASTINT, not
4597 XINT, for value known to be a character. Don't bother comparing
4598 a single byte to 0400, as it's always less.
4599
395fcb93 4600 * floatfns.c (Fexpt):
327eeec8
PE
4601 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4602
abbd3d23
PE
4603 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4604 for characters.
4605
684a03ef
PE
4606 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4607
0fed43f3
PE
4608 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4609 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4610 incorrectly succeed when S was a string, because 4294967386 was
4611 truncated before it was used.
4612
8fd02eb7
PE
4613 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4614 Otherwise, an out-of-range integer could cause undefined behavior
4615 on a 64-bit host.
4616
f8c86b69
PE
4617 * composite.c: Use int, not EMACS_INT, for characters.
4618 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4619 EMACS_INT, for values that are known to be in character range.
4620 This doesn't fix any bugs but is the usual style inside Emacs and
4621 may generate better code on 32-bit machines.
4622
34206dd2
PE
4623 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4624 This is for reasons similar to the recent CHAR_STRING fix.
4625 * charset.c (Fencode_char): Check that character arg is actually
4626 a character. Pass an int to ENCODE_CHAR.
4627 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4628 wider than 'int', as a compile-time check to prevent future regressions
4629 in this area.
4630
c5958d4c 4631 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4632
4633 Make sure a 64-bit char is never passed to CHAR_STRING.
4634 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4635 by silently ignoring the top 32 bits, allowing some values
4636 that were far too large to be valid characters.
4637 * character.h: Include <verify.h>.
4638 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4639 arguments are no wider than unsigned, as a compile-time check
4640 to prevent future regressions in this area.
4641 * data.c (Faset):
01103c44 4642 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4643 (Fsubst_char_in_region):
4644 * fns.c (concat):
4645 * xdisp.c (decode_mode_spec_coding):
4646 Adjust to CHAR_STRING's new requirement.
4647 * editfns.c (Finsert_char, Fsubst_char_in_region):
4648 * fns.c (concat): Check that character args are actually
4649 characters. Without this test, these functions did the wrong
4650 thing with wildly out-of-range values on 64-bit hosts.
4651
d37ca623
PE
4652 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4653 These casts should not be needed on 32-bit hosts, either.
4654 * keyboard.c (read_char):
4655 * lread.c (Fload): Remove casts to unsigned.
4656
ea204efb
PE
4657 * lisp.h (UNSIGNED_CMP): New macro.
4658 This fixes comparison bugs on 64-bit hosts.
4659 (ASCII_CHAR_P): Use it.
4660 * casefiddle.c (casify_object):
01103c44 4661 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4662 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4663 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4664 * dispextern.h (FACE_FROM_ID):
4665 * keyboard.c (read_char): Use UNSIGNED_CMP.
4666
41cb286c
PE
4667 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4668 not to EMACS_INT, to avoid GCC warning.
4669
4a1b9832
PE
4670 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4671
55daad71
PE
4672 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4673 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4674 isn't needed on 32-bit machines.
8f95c75c 4675
01103c44
PE
4676 * buffer.c (Fgenerate_new_buffer_name):
4677 Use EMACS_INT for count, not int.
0ceccced 4678 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4679
4680 * data.c (Qcompiled_function): Now static.
4681
c6f072e7
PE
4682 * window.c (window_body_lines): Now static.
4683
20ce5912
PE
4684 * image.c (gif_load): Rename local to avoid shadowing.
4685
9c4c5f81
PE
4686 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4687 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4688 * alloc.c (make_save_value): Integer argument is now of type
4689 ptrdiff_t, not int.
4690 (mark_object): Use ptrdiff_t, not int.
4691 * lisp.h (pD): New macro.
4692 * print.c (print_object): Use it.
4693
c0c5c8ae
PE
4694 * alloc.c: Use EMACS_INT, not int, to count objects.
4695 (total_conses, total_markers, total_symbols, total_vector_size)
4696 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4697 (total_free_floats, total_floats, total_free_intervals)
4698 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4699 Now EMACS_INT, not int. All uses changed.
4700 (Fgarbage_collect): Compute overall total using a double, so that
4701 integer overflow is less likely to be a problem. Check for overflow
4702 when converting back to an integer.
5a25e253
PE
4703 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4704 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4705 These were 'int' variables that could overflow on 64-bit hosts;
4706 they were never used, so remove them instead of repairing them.
211a0b2a 4707 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4708 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4709 Previously, this ceilinged at INT_MAX, but that doesn't work on
4710 64-bit machines.
e46bb31a 4711 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4712
c78baabf 4713 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4714 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4715 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4716 when a (possibly-narrower) signed value would do just as well.
4717 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4718
c9d624c6
PE
4719 * alloc.c: Catch some string size overflows that we were missing.
4720 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4721 for convenience in STRING_BYTES_MAX.
4722 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4723 The definition here is exact; the one in lisp.h was approximate.
4724 (allocate_string_data): Check for string overflow. This catches
4725 some instances we weren't catching before. Also, it catches
4726 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4727 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4728 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4729
c9d624c6
PE
4730 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4731 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4732 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4733
353032ce
PE
4734 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4735
2bccce07
PE
4736 * alloc.c (Fmake_string): Check for out-of-range init.
4737
0ac30604
SM
47382011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4739
4740 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4741
c195f2de
JD
47422011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4743
4744 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4745 xg_get_default_scrollbar_width.
4746
4747 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4748 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4749 (style_changed_cb): Call update_theme_scrollbar_width and call
4750 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4751 all frames (Bug#8505).
4752 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4753 Call gtk_window_set_resizable if HAVE_GTK3.
4754 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4755 and height if HAVE_GTK3 (Bug#8505).
4756 (scroll_bar_width_for_theme): New variable.
4757 (update_theme_scrollbar_width): New function.
4758 (xg_get_default_scrollbar_width): Move code to
4759 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4760 (xg_initialize): Call update_theme_scrollbar_width.
4761
4762 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4763
4764 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4765
e10ac9f1
MR
47662011-06-12 Martin Rudalics <rudalics@gmx.at>
4767
4768 * frame.c (make_frame): Call other_buffer_safely instead of
4769 other_buffer.
4770
4771 * window.c (temp_output_buffer_show): Call display_buffer with
4772 second argument Vtemp_buffer_show_specifiers and reset latter
4773 immediately after the call.
4774 (Vtemp_buffer_show_specifiers): New variable.
4775 (auto_window_vscroll_p, next_screen_context_lines)
4776 (Vscroll_preserve_screen_position): Remove leading asterisks from
4777 doc-strings.
4778
2d3c217e 47792011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4780
7b7f97e8 4781 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4782 * buffer.c (Qclone_number): Remove for now, as it's unused.
4783 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4784 (record_buffer): Remove unused local.
4785 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4786 (set_frame_buffer_list): Remove; unused.
4787 * frame.h (other_visible_frames): Remove decl.
4788 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4789 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4790 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4791 if HAVE_GPM.
4792 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4793 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4794 Define only if HAVE_GPM.
4795 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4796 (update_hints_inhibit): Remove; never set. All uses removed.
4797 * widgetprv.h (emacsFrameClassRec): Remove decl.
4798 * window.c (delete_deletable_window): Now returns void, since it
4799 wasn't returning anything.
4800 (compare_window_configurations): Remove unused locals.
4801 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4802 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4803 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4804 the same widths as pointers. This follows up on the 2011-05-06 patch.
4805 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4806 * xterm.h: Likewise.
4807 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4808
1384b89e
JB
48092011-06-12 Juanma Barranquero <lekktu@gmail.com>
4810
4811 * makefile.w32-in: Update dependencies.
4812 (LISP_H): Add lib/intprops.h.
4813
1100a63c
CY
48142011-06-11 Chong Yidong <cyd@stupidchicken.com>
4815
4816 * image.c (gif_load): Add animation frame delay to the metadata.
4817 (syms_of_image): Use DEFSYM. New symbol `delay'.
4818
6198ccd0
MR
48192011-06-11 Martin Rudalics <rudalics@gmx.at>
4820
4821 * window.c (delete_deletable_window): Re-add.
4822 (Fset_window_configuration): Rewrite to handle dead buffers and
4823 consequently deletable windows.
4824 (window_tree, Fwindow_tree): Remove. Supply functionality in
4825 window.el.
4826 (compare_window_configurations): Simplify code.
4827
b6e3633c
AS
48282011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4829
1ab0dee5
AS
4830 * image.c (imagemagick_load_image): Fix type mismatch.
4831 (Fimagemagick_types): Likewise.
4832
b6e3633c
AS
4833 * window.h (replace_buffer_in_windows): Declare.
4834
9397e56f
MR
48352011-06-11 Martin Rudalics <rudalics@gmx.at>
4836
4837 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4838 Qclone_number. Remove external declaration of Qdelete_window.
4839 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4840 code.
640c8776
SM
4841 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4842 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4843 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4844 buffer list implementation.
4845 (other_buffer_safely): New function.
4846 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4847 calls to replace_buffer_in_windows and
4848 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4849 if allowed.
4850 (record_buffer): Inhibit quitting and rewrite using quittable
4851 functions. Run Qbuffer_list_update_hook if allowed.
4852 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4853 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4854 Move switch-to-buffer to window.el.
9397e56f
MR
4855 (bury-buffer): Move to window.el.
4856 (Vbuffer_list_update_hook): New variable.
4857
4858 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4859 section.
4860
4861 * window.h (resize_frame_windows): Move up in code.
4862 (Fwindow_frame): Remove EXFUN.
4863 (replace_buffer_in_all_windows): Remove prototype.
4864 (replace_buffer_in_windows_safely): Add prototype.
4865
4866 * window.c: Declare Qdelete_window static again. Move down
4867 declaration of select_count.
4868 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4869 (Fother_window): Move to window.el.
4870 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4871 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4872 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4873 window.el.
4874 (replace_buffer_in_windows): Implement by calling
4875 Qreplace_buffer_in_windows.
4876 (replace_buffer_in_all_windows): Remove with some functionality
4877 moved into replace_buffer_in_windows_safely.
4878 (replace_buffer_in_windows_safely): New function.
4879 (select_window_norecord, select_frame_norecord): Move in front
4880 of run_window_configuration_change_hook. Remove now obsolete
4881 declarations.
640c8776
SM
4882 (Fset_window_buffer): Rewrite doc-string.
4883 Call Qrecord_window_buffer.
9397e56f
MR
4884 (keys_of_window): Move binding for other-window to window.el.
4885
b50691aa
CY
48862011-06-11 Chong Yidong <cyd@stupidchicken.com>
4887
4888 * dispextern.h (struct image): Replace data member, whose int_val
4889 and ptr_val fields were not used by anything, with a single
4890 lisp_val object.
4891
4892 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4893 (gif_clear_image, gif_load, imagemagick_load_image)
4894 (gs_clear_image, gs_load): Callers changed.
4895
3f754b86
PE
48962011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4897
cca69397
PE
4898 * buffer.h: Include <time.h>, for time_t.
4899 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4900
109e28d0
PE
4901 Fix minor problems found by static checking.
4902
60737f02
PE
4903 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4904
4b66faf3
PE
4905 Make identifiers static if they are not used in other modules.
4906 * data.c (Qcompiled_function, Qframe, Qvector):
4907 * image.c (QimageMagick, Qsvg):
4908 * minibuf.c (Qmetadata):
4909 * window.c (resize_window_check, resize_root_window): Now static.
4910 * window.h (resize_window_check, resize_root_window): Remove decls.
4911
109e28d0
PE
4912 * window.c (window_deletion_count, delete_deletable_window):
4913 Remove; unused.
46a4ce9e
PE
4914 (window_body_lines): Now static.
4915 (Fdelete_other_windows_internal): Mark vars as initialized.
4916 Make sure 'resize_failed' is initialized.
4917 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4918 (resize_window_apply): Remove unused local.
4919 * window.h (delete_deletable_window): Remove decl.
4920
109e28d0 4921 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4922 (imagemagick_load_image): Fix pointer signedness problem by changing
4923 last arg from unsigned char * to char *. All uses changed.
4924 Also, fix a local for similar reasons.
4925 Remove unused locals. Remove locals to avoid shadowing.
4926 (fn_rsvg_handle_free): Remove; unused.
4927 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4928 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4929
3f754b86
PE
4930 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4931
2547adb1
CY
49322011-06-10 Chong Yidong <cyd@stupidchicken.com>
4933
4934 * image.c (gif_load): Fix omitted cast error introduced by
4935 2011-06-06 change.
4936
2c8e37d4
MR
49372011-06-10 Martin Rudalics <rudalics@gmx.at>
4938
4939 * window.h (resize_proportionally, orig_total_lines)
4940 (orig_top_line): Remove from window structure.
4941 (set_window_height, set_window_width, change_window_heights)
4942 (Fdelete_window): Remove prototypes.
4943 (resize_frame_windows): Remove duplicate declaration.
4944
440a42e3
EZ
49452011-06-10 Eli Zaretskii <eliz@gnu.org>
4946
4947 * window.h (resize_frame_windows, resize_window_check)
4948 (delete_deletable_window, resize_root_window)
4949 (resize_frame_windows): Declare prototypes.
4950
4951 * window.c (resize_window_apply): Make definition be "static" to
4952 match the prototype.
4953
562dd5e9
MR
49542011-06-10 Martin Rudalics <rudalics@gmx.at>
4955
4956 * window.c: Remove declarations of Qwindow_size_fixed,
4957 window_min_size_1, window_min_size_2, window_min_size,
4958 size_window, window_fixed_size_p, enlarge_window, delete_window.
4959 Remove static from declaration of Qdelete_window, it's
4960 temporarily needed by Fbury_buffer.
4961 (replace_window): Don't assign orig_top_line and
4962 orig_total_lines.
4963 (Fdelete_window, delete_window): Remove. Window deletion is
4964 handled by window.el.
640c8776
SM
4965 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4966 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4967 (Fdelete_other_windows): Remove. Deleting other windows is
4968 handled by window.el.
4969 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4970 handled in window.el.
4971 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4972 Window minimum sizes are handled in window.el.
4973 (shrink_windows, size_window, set_window_height)
4974 (set_window_width, change_window_heights, window_height)
4975 (window_width, CURBEG, CURSIZE, enlarge_window)
4976 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4977 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4978 handled in window.el.
4979 (make_dummy_parent): Rename to make_parent_window and give it a
4980 second argument horflag.
4981 (make_window): Don't set resize_proportionally any more.
4982 (Fsplit_window): Remove. Windows are split in window.el.
4983 (save_restore_action, save_restore_orig_size)
4984 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4985 Resize mini windows in window.el.
4986 (grow_mini_window, shrink_mini_window): Implement by calling
4987 Qresize_root_window_vertically, resize_window_check and
4988 resize_window_apply.
640c8776
SM
4989 (saved_window, Fset_window_configuration, save_window_save):
4990 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4991 resize_proportionally.
4992 (window_min_height, window_min_width): Move to window.el.
4993 (keys_of_window): Move bindings for delete-other-windows,
4994 split-window, delete-window and enlarge-window to window.el.
4995
4996 * buffer.c: Temporarily extern Qdelete_window.
4997 (Fbury_buffer): Temporarily call Qdelete_window instead of
4998 Fdelete_window (Fbury_buffer will move to window.el soon).
4999
5000 * frame.c (set_menu_bar_lines_1): Remove code handling
5001 orig_top_line and orig_total_lines.
5002
5003 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5004 set_window_height but set heights directly.
5005 (change_frame_size_1): Use resize_frame_windows.
5006
5007 * xdisp.c (init_xdisp): Don't use set_window_height but set
5008 heights directly.
5009
640c8776
SM
5010 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5011 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5012 run_window_configuration_change_hook.
5013
5014 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5015 instead of change_window_heights and run
5016 run_window_configuration_change_hook.
5017
1a13852e
MR
50182011-06-09 Martin Rudalics <rudalics@gmx.at>
5019
5020 * window.c (replace_window): Rename second argument REPLACEMENT to
5021 NEW. New third argument SETFLAG. Rewrite.
5022 (delete_window, make_dummy_parent): Call replace_window with
5023 third argument 1.
5024 (window_list_1): Move down in code.
5025 (run_window_configuration_change_hook): Move set_buffer part
5026 before select_frame_norecord part in order to unwind correctly.
5027 Rename count1 to count.
5028 (recombine_windows, delete_deletable_window, resize_root_window)
5029 (Fdelete_other_windows_internal)
5030 (Frun_window_configuration_change_hook, make_parent_window)
5031 (resize_window_check, resize_window_apply, Fresize_window_apply)
5032 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5033 (Fdelete_window_internal, Fresize_mini_window_internal):
5034 New functions.
1a13852e
MR
5035 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5036
f3d1777e
MR
50372011-06-08 Martin Rudalics <rudalics@gmx.at>
5038
496e208e
MR
5039 * window.h (window): Add some new members to window structure -
5040 normal_lines, normal_cols, new_total, new_normal, clone_number,
5041 splits, nest, prev_buffers, next_buffers.
5042 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5043 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5044
f3d1777e
MR
5045 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5046 Remove.
496e208e
MR
5047 (make_dummy_parent): Set new members of windows structure.
5048 (make_window): Move down in code. Handle new members of window
5049 structure.
5050 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5051 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5052 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5053 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5054 (Fset_window_next_buffers, Fset_window_clone_number):
5055 New functions.
496e208e
MR
5056 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5057 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5058 Doc-string fixes.
5059 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5060 Argument WINDOW can be now internal window too.
5061 (Fwindow_use_time): Move up in code.
5062 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5063 Rewrite doc-string.
5064 (Fset_window_configuration, saved_window)
5065 (Fcurrent_window_configuration, save_window_save): Handle new
5066 members of window structure.
b9e809c2
MR
5067 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5068 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5069 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5070 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5071 Qget_mru_window, Qresize_root_window,
5072 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5073 Qauto_buffer_name; staticpro them.
f3d1777e 5074
abde8f8c
MR
50752011-06-07 Martin Rudalics <rudalics@gmx.at>
5076
5077 * window.c (Fwindow_total_size, Fwindow_left_column)
5078 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5079 (Fwindow_list_1): New functions.
5080 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5081 (Fwindow_width, Fscroll_left, Fscroll_right):
5082 Use window_body_cols instead of window_box_text_cols.
5083 (delete_window, Fset_window_configuration):
5084 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5085 (delete_all_subwindows): Take a window as argument and not a
5086 structure. Rewrite.
190b47e6
MR
5087 (window_loop): Remove handling of GET_LRU_WINDOW and
5088 GET_LARGEST_WINDOW.
5089 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5090
5091 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5092 window_box_text_cols. delete_all_subwindows now takes a
5093 Lisp_Object as argument.
abde8f8c 5094
640c8776
SM
5095 * indent.c (compute_motion, Fcompute_motion):
5096 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5097
fa8a67e6
MR
5098 * frame.c (delete_frame): Call delete_all_subwindows with root
5099 window as argument.
5100
a54e3482
DC
51012011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5102
5103 * fns.c (Fputhash): Document return value.
5104
60002bf5
CY
51052011-06-06 Chong Yidong <cyd@stupidchicken.com>
5106
5107 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5108
0c671da6 51092011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5110
b862a52a 5111 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5112
be44ca6c
PE
5113 Check for overflow when converting integer to cons and back.
5114 * charset.c (Fdefine_charset_internal, Fdecode_char):
5115 Use cons_to_unsigned to catch overflow.
5116 (Fencode_char): Use INTEGER_TO_CONS.
5117 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5118 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5119 * data.c (long_to_cons, cons_to_long): Remove.
5120 (cons_to_unsigned, cons_to_signed): New functions.
5121 These signal an error for invalid or out-of-range values.
5122 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5123 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5124 * font.c (Ffont_variation_glyphs):
5125 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5126 * lisp.h: Include <intprops.h>.
5127 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5128 (cons_to_signed, cons_to_unsigned): New decls.
5129 (long_to_cons, cons_to_long): Remove decls.
5130 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5131 (Fprimitive_undo): Use CONS_TO_INTEGER.
5132 * xfns.c (Fx_window_property): Likewise.
5133 * xselect.c: Include <limits.h>.
5134 (x_own_selection, selection_data_to_lisp_data):
5135 Use INTEGER_TO_CONS.
5136 (x_handle_selection_request, x_handle_selection_clear)
5137 (x_get_foreign_selection, Fx_disown_selection_internal)
5138 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5139 (lisp_data_to_selection_data): Use cons_to_unsigned.
5140 (x_fill_property_data): Use cons_to_signed.
5141 Report values out of range.
5142
d1f3d2af
PE
5143 Check for buffer and string overflow more precisely.
5144 * buffer.h (BUF_BYTES_MAX): New macro.
5145 * lisp.h (STRING_BYTES_MAX): New macro.
5146 * alloc.c (Fmake_string):
5147 * character.c (string_escape_byte8):
5148 * coding.c (coding_alloc_by_realloc):
5149 * doprnt.c (doprnt):
5150 * editfns.c (Fformat):
5151 * eval.c (verror):
5152 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5153 since they may not be the same number.
5154 * editfns.c (Finsert_char):
5155 * fileio.c (Finsert_file_contents):
5156 Likewise for BUF_BYTES_MAX.
5157
dd52fcea
PE
5158 * image.c: Use ptrdiff_t, not int, for sizes.
5159 (slurp_file): Switch from int to ptrdiff_t.
5160 All uses changed.
5161 (slurp_file): Check that file size fits in both size_t (for
5162 malloc) and ptrdiff_t (for sanity and safety).
5163
7f9bbdbb
PE
5164 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5165 if b->modtime has its maximal value.
5166
dfe18f82
PE
5167 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5168
84acfcf0
PE
5169 Don't assume time_t can fit into int.
5170 * buffer.h (struct buffer.modtime): Now time_t, not int.
5171 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5172 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5173
ccd9a01a
PE
5174 Minor fixes for signed vs unsigned integers.
5175 * character.h (MAYBE_UNIFY_CHAR):
5176 * charset.c (maybe_unify_char):
5177 * keyboard.c (read_char, reorder_modifiers):
5178 XINT -> XFASTINT, since the integer must be nonnegative.
5179 * ftfont.c (ftfont_spec_pattern):
5180 * keymap.c (access_keymap, silly_event_symbol_error):
5181 XUINT -> XFASTINT, since the integer must be nonnegative.
5182 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5183 since it makes no difference and we prefer signed.
5184 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5185 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5186 nonnegative.
5187
d6d100dd
SM
51882011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5189
5190 * window.h (Fwindow_frame): Declare.
5191
2b6148e4
PE
51922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5193
5194 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5195 (SPARE_MEMORY): Always define.
5196 (LARGE_REQUEST): Remove.
5197 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5198
f230ecc9
MR
51992011-06-06 Martin Rudalics <rudalics@gmx.at>
5200
727e958e
MR
5201 * lisp.h: Move EXFUNS for Fframe_root_window,
5202 Fframe_first_window and Fset_frame_selected_window to window.h.
5203
5204 * window.h: Move EXFUNS for Fframe_root_window,
5205 Fframe_first_window and Fset_frame_selected_window here from
5206 lisp.h.
5207
5208 * frame.c (Fwindow_frame, Fframe_first_window)
5209 (Fframe_root_window, Fframe_selected_window)
5210 (Fset_frame_selected_window): Move to window.c.
5211 (Factive_minibuffer_window): Move to minibuf.c.
5212 (Fother_visible_frames_p): New function.
5213
5214 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5215
f230ecc9
MR
5216 * window.c (decode_window, decode_any_window): Move up in code.
5217 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5218 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5219 (Fwindow_buffer): Move up and rewrite doc-string.
5220 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5221 (Fwindow_prev): New functions.
727e958e
MR
5222 (Fwindow_frame): Move here from frame.c. Accept any window as
5223 argument.
5224 (Fframe_root_window, Fframe_first_window)
5225 (Fframe_selected_window): Move here from frame.c. Accept frame
5226 or arbitrary window as argument. Update doc-strings.
5227 (Fminibuffer_window): Move up in code.
5228 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5229 (Fset_frame_selected_window): Move here from frame.c.
5230 Marginal rewrite.
727e958e
MR
5231 (Fselected_window, select_window, Fselect_window): Move up in
5232 code. Minor doc-string fixes.
f230ecc9 5233
4d09bcf6
PE
52342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5235
5236 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5237 Do not assume that spare memory exists; that assumption is valid
5238 only if SYSTEM_MALLOC.
5239 (LARGE_REQUEST): New macro, so that the issue of large requests
5240 is separated from the issue of spare memory.
5241
810928a2
AS
52422011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5243
172418ad
AS
5244 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5245 format. (Bug#8806)
5246
43f862f7
AS
5247 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5248
810928a2
AS
5249 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5250 before statements.
5251
a059fe24
JD
52522011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5253
5254 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5255
5256 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5257
5258 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5259 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5260
989bf368
JB
52612011-06-05 Juanma Barranquero <lekktu@gmail.com>
5262
5263 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5264
4b80f674
CY
52652011-06-04 Chong Yidong <cyd@stupidchicken.com>
5266
5267 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5268 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5269 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5270 New error handlers.
4b80f674
CY
5271 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5272 Obey Vx_select_enable_clipboard_manager. Catch errors in
5273 x_clipboard_manager_save (Bug#8779).
5274 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5275 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5276
99a33b77 52772011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5278
5279 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5280
99a33b77 52812011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5282
5283 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5284 in the current matrix if keep_current_p is non-zero.
5285
8264569d
EZ
52862011-06-04 Eli Zaretskii <eliz@gnu.org>
5287
5288 * bidi.c (bidi_level_of_next_char): Fix last change.
5289
57f97249
EZ
52902011-06-03 Eli Zaretskii <eliz@gnu.org>
5291
fec2107c 5292 Support bidi reordering of text covered by display properties.
57f97249 5293
fec2107c
EZ
5294 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5295 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5296 (bidi_cache_search, bidi_cache_iterator_state)
5297 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5298 (bidi_level_of_next_char, bidi_move_to_visually_next):
5299 Support character positions inside a run of characters covered by a
fec2107c
EZ
5300 display string.
5301 (bidi_paragraph_init, bidi_resolve_explicit_1)
5302 (bidi_level_of_next_char): Call bidi_fetch_char and
5303 bidi_fetch_char_advance instead of FETCH_CHAR and
5304 FETCH_CHAR_ADVANCE.
5305 (bidi_init_it): Initialize new members.
5306 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5307 definitions.
5308 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5309 instead of using explicit *_CHAR codes.
d6d100dd
SM
5310 (bidi_resolve_explicit, bidi_resolve_weak):
5311 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5312 bidirectional text is supported only in multibyte buffers.
5313 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5314 it to initialize the frame_window_p member of struct bidi_it.
5315 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5316 (bidi_resolve_explicit, bidi_resolve_weak)
5317 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5318 bidi_it->nchars is non-positive.
5319 (bidi_level_of_next_char): Don't try to lookup the cache for the
5320 next/previous character if nothing is cached there yet, or if we
5321 were just reseat()'ed to a new position.
c40e2fb2 5322
0e14fe90
EZ
5323 * xdisp.c (set_cursor_from_row): Set start and stop points
5324 according to the row's direction when priming the loop that looks
5325 for the glyph on which to display cursor.
5326 (single_display_spec_intangible_p): Function deleted.
5327 (display_prop_intangible_p): Reimplement to call
5328 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5329 Accept 3 additional arguments needed by handle_display_spec.
5330 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5331 values: lists, `(when COND...)' forms, etc.
5332 (single_display_spec_string_p): Support property values that are
5333 lists with the argument STRING its top-level element.
5334 (display_prop_string_p): Fix the condition for processing a
5335 property that is a list to be consistent with handle_display_spec.
fec2107c 5336 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5337 last portion of handle_display_prop.
5338 (compute_display_string_pos): Accept additional argument
5339 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5340 value of a `display' property is a "replacing spec".
5341 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5342 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5343 the display property, but just return a value indicating whether
5344 the display property will replace the characters it covers.
5345 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5346 frame_window_p members of struct bidi_it.
d6d100dd
SM
5347 (compute_display_string_pos, compute_display_string_end):
5348 New functions.
fec2107c
EZ
5349 (push_it): Accept second argument POSITION, where pop_it should
5350 jump to continue iteration.
5351 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5352
fec2107c
EZ
5353 * keyboard.c (adjust_point_for_property): Adjust the call to
5354 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5355
5356 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5357 (bidi_init_it): Update prototypes.
5358 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5359 (compute_display_string_pos, compute_display_string_end):
5360 Declare prototypes.
fec2107c
EZ
5361 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5362 EMACS_INT.
fc6f18ce 5363
40087514 53642011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5365
57f53182
PE
5366 Malloc failure behavior now depends on size of allocation.
5367 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5368 * lisp.h: Change signatures accordingly.
5369 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5370 All callers changed. (Bug#8762)
5371
5372 * gnutls.c: Use Emacs's memory allocators.
5373 Without this change, the gnutls library would invoke malloc etc.
5374 directly, which causes problems on non-SYNC_INPUT hosts, and which
5375 runs afoul of improving memory_full behavior. (Bug#8761)
5376 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5377 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5378 xfree instead of the default malloc, realloc, free.
5379 (Fgnutls_boot): No need to check for memory allocation failure,
5380 since xmalloc does that for us.
5381
ac32cd99 5382 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5383 * category.c (hash_get_category_set):
5384 * ccl.c (ccl_driver):
5385 * charset.c (Fdefine_charset_internal):
5386 * charset.h (struct charset.hash_index):
5387 * composite.c (get_composition_id, gstring_lookup_cache)
5388 (composition_gstring_put_cache):
5389 * composite.h (struct composition.hash_index):
5390 * dispextern.h (struct image.hash):
5391 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5392 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5393 (hashfn_equal, hashfn_user_defined, make_hash_table)
5394 (maybe_resize_hash_table, hash_lookup, hash_put)
5395 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5396 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5397 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5398 * image.c (make_image, search_image_cache, lookup_image)
5399 (xpm_put_color_table_h):
5400 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5401 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5402 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5403 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5404 * alloc.c (allocate_vectorlike):
5405 Check for overflow in vector size calculations.
5406 * ccl.c (ccl_driver):
5407 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5408 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5409 need to be updated by these changes.
40087514
PE
5410 * fns.c (make_hash_table, maybe_resize_hash_table):
5411 Check for integer overflow with large hash tables.
0de4bb68
PE
5412 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5413 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5414 (SXHASH_REDUCE): New macro.
5415 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5416 Use it instead of discarding useful hash info with large hash values.
5417 (sxhash_float): New function.
5418 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5419 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5420 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5421 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5422 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5423 Adjust signatures to match updated version of code.
5424 (consing_since_gc): Now EMACS_INT, since a single hash table can
5425 use more than INT_MAX bytes.
5426
698d32e2
DN
54272011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5428
5429 Make it possible to build with GCC-4.6+ -O2 -flto.
5430
5431 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5432
fd6fa53f
SM
54332011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5434
5435 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5436 Call minibuffer-inactive-mode.
5437
864db017
JB
54382011-05-31 Juanma Barranquero <lekktu@gmail.com>
5439
5440 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5441 Update dependencies.
5442
2ad0baf4
DN
54432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5444
5445 * data.c (init_data): Remove code for UTS, this system is not
5446 supported anymore.
5447
4fcc2638
DN
54482011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5449
5450 Don't force ./temacs to start in terminal mode.
5451
5452 * frame.c (make_initial_frame): Initialize faces in all cases, not
5453 only when CANNOT_DUMP is defined.
5454 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5455
c56e0fd5
DN
54562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5457
5458 * dispnew.c (add_window_display_history): Use const for the string
5459 pointer. Remove declaration, not needed.
5460
333d54da 54612011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5462
55d4c1b2 5463 Use 'inline', not 'INLINE'.
333d54da 5464 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5465 * alloc.c, fontset.c (INLINE): Remove.
5466 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5467 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5468 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5469 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5470 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5471
738db178
DN
54722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5473
5474 Make it possible to run ./temacs.
5475
5476 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5477 syms_of_callproc does the same thing. Remove test for
5478 "initialized", do it in the caller.
5479 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5480
620c53a6
SM
54812011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5482
5483 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5484 (read_minibuf): Use get_minibuffer.
5485 (syms_of_minibuf): Use DEFSYM.
5486 (Qmetadata): New var.
5487 * data.c (Qbuffer): Don't make it static.
5488 (syms_of_data): Use DEFSYM.
5489
e003a292
PE
54902011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5491
5492 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5493 (CCL_CODE_MIN): New macro.
5494
ed008a6d
PE
54952011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5496
3687c2ef
PE
5497 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5498
ed008a6d
PE
5499 * eval.c (Qdebug): Now static.
5500 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5501 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5502 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5503
d66c4c7c
CY
55042011-05-29 Chong Yidong <cyd@stupidchicken.com>
5505
5506 * image.c: Various fixes to ImageMagick code comments.
5507 (Fimagemagick_types): Doc fix.
5508
5fbc2025
PE
55092011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5510
0196f88a
PE
5511 Minor fixes prompted by GCC 4.6.0 warnings.
5512
5513 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5514
5fbc2025
PE
5515 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5516 (x_clipboard_manager_save_all): Move extern decl to ...
5517 * xterm.h: ... here, so that it can be checked for consistency.
5518
1dd3c2d9
CY
55192011-05-29 Chong Yidong <cyd@stupidchicken.com>
5520
5521 * xselect.c (x_clipboard_manager_save_frame)
5522 (x_clipboard_manager_save_all): New functions.
5523 (Fx_clipboard_manager_save): Lisp function deleted.
5524
5525 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5526 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5527
5528 * xterm.h: Update prototype.
5529
5ba6571d
WX
55302011-05-28 William Xu <william.xwl@gmail.com>
5531
5532 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5533 exiting (Bug#8239).
5534
3eaff834
JM
55352011-05-28 Jim Meyering <meyering@redhat.com>
5536
e1900994 5537 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5538 * fns.c (to_uchar): Define.
5539 (crypto_hash_function): Use it to convert some newly-signed
5540 variables to unsigned, to avoid sign-extension bugs. For example,
5541 without this change, (md5 "truc") would evaluate to
5542 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5543 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5544 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5545
0f6990a7
PE
55462011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5547
5548 Integer overflow fixes.
c8a9ca5a 5549
08686060
PE
5550 * dbusbind.c: Serial number integer overflow fixes.
5551 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5552 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5553 to hold a serial number that is too large for a fixnum.
5554 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5555 Check for serial numbers out of range. Decode any serial number
59568bf0 5556 that was so large that it became a float. (Bug#8722)
08686060 5557
2d1fc3c7
PE
5558 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5559 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5560 Use XFASTINT rather than XUINT when numbers are nonnegative.
5561 (xd_append_arg, Fdbus_method_return_internal):
5562 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5563 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5564 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5565 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5566 (Bug#8722)
2d1fc3c7 5567
c8a9ca5a
PE
5568 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5569
519e1d69
PE
5570 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5571
30569699
PE
5572 ccl: add integer overflow checks
5573 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5574 (IN_INT_RANGE): New macros.
5575 (ccl_driver): Use them to check for integer overflow when
5576 decoding a CCL program. Many of the new checks are whether XINT (x)
5577 fits in int; it doesn't always, on 64-bit hosts. The new version
5578 doesn't catch all possible integer overflows, but it's an
847044ea 5579 improvement. (Bug#8719)
30569699 5580
c11285dc
PE
5581 * alloc.c (make_event_array): Use XINT, not XUINT.
5582 There's no need for unsigned here.
5583
fdccd48e
PE
5584 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5585 This follows up to the 2011-05-06 change that substituted uintptr_t
5586 for EMACS_INT. This case wasn't caught back then.
5587
37910ab2
PE
5588 Rework Fformat to avoid integer overflow issues.
5589 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5590 now (part of C89). Include <verify.h>.
5591 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5592 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5593 (Fformat): Avoid the prepass trying to compute sizes; it was only
5594 approximate and thus did not catch overflow reliably. Instead, walk
5595 through the format just once, formatting and computing sizes as we go,
5596 checking for integer overflow at every step, and allocating a larger
5597 buffer as needed. Keep track separately whether the format is
5598 multibyte. Keep only the most-recently calculated precision, rather
5599 than them all. Record whether each argument has been converted to
5600 string. Use EMACS_INT, not int, for byte and char and arg counts.
5601 Support field widths and precisions larger than INT_MAX. Avoid
5602 sprintf's undefined behavior with conversion specifications such as %#d
5603 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5604 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5605 formatting out-of-range floating point numbers with int
9173deec 5606 formats. (Bug#8668)
37910ab2 5607
2e6578fb
PE
5608 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5609
0ae6bdee
PE
5610 * data.c: Avoid integer truncation in expressions involving floats.
5611 * data.c: Include <intprops.h>.
5612 (arith_driver): When there's an integer overflow in an expression
5613 involving floating point, convert the integers to floating point
5614 so that the resulting value does not suffer from catastrophic
5615 integer truncation. For example, on a 64-bit host (* 4
5616 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5617 Do not rely on undefined behavior after integer overflow.
5618
de883a70
PE
5619 merge count_size_as_multibyte, parse_str_to_multibyte
5620 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5621 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5622 Check for integer overflow.
5623 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5624 since it's now a duplicate of the other. This is more of
5625 a character than a buffer op, so better that it's in character.c.
5626 * fns.c, print.c: Adjust to above changes.
5627
2ff916cb
PE
56282011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5629
5630 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5631
f1b54466
PE
56322011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5633
fb1ac845
PE
5634 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5635 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5636 (x_clipboard_manager_save): Now static.
5637 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5638
f1b54466
PE
5639 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5640 (crypto_hash_function): Now static.
5641 Fix pointer signedness problems. Avoid unnecessary initializations.
5642
a9f737ee
CY
56432011-05-27 Chong Yidong <cyd@stupidchicken.com>
5644
5645 * termhooks.h (Vselection_alist): Make it terminal-local.
5646
5647 * terminal.c (create_terminal): Initialize it.
5648
5649 * xselect.c: Support for clipboard managers.
5650 (Vselection_alist): Move to termhooks.h as terminal-local var.
5651 (LOCAL_SELECTION): New macro.
5652 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5653 (symbol_to_x_atom): Remove gratuitous arg.
5654 (x_handle_selection_request, lisp_data_to_selection_data)
5655 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5656 (x_own_selection, x_get_local_selection, x_convert_selection):
5657 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5658 (some_frame_on_display): Delete unused function.
5659 (Fx_own_selection_internal, Fx_get_selection_internal)
5660 (Fx_disown_selection_internal, Fx_selection_owner_p)
5661 (Fx_selection_exists_p): New optional frame arg.
5662 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5663 (x_handle_selection_clear): Don't treat other terminals with the
5664 same keyboard specially. Use the terminal-local Vselection_alist.
5665 (x_clear_frame_selections): Use Frun_hook_with_args.
5666
5667 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5668
5669 * xterm.h: Add support for those atoms.
5670
e067f0c1
CY
56712011-05-26 Chong Yidong <cyd@stupidchicken.com>
5672
5673 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5674 (converted_selections, conversion_fail_tag): New global variables.
5675 (x_selection_request_lisp_error): Free the above.
5676 (x_get_local_selection): Remove unnecessary code.
5677 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5678 of converted selections stored in converted_selections.
5679 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5680 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5681 (x_convert_selection): New function.
5682 (x_handle_selection_event): Simplify.
5683 (x_get_foreign_selection): Don't ignore incoming requests while
5684 waiting for an answer; this will fail when we implement
5685 SAVE_TARGETS, and seems unnecessary anyway.
5686 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5687 (Vx_sent_selection_functions): Doc fix.
5688
0f4aebc0
LL
56892011-05-26 Leo Liu <sdl.web@gmail.com>
5690
5691 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5692
e61124cd
YM
56932011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5694
5695 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5696
5697 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5698 for fringe update if it has periodic bitmap.
ac389d0c 5699 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5700 and fringe_bitmap_periodic_p.
5701
5702 * fringe.c (get_fringe_bitmap_data): New function.
5703 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5704 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5705 row. Mark glyph row for fringe update if periodicity changed.
5706
5707 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5708 for fringe update unless it has periodic bitmap.
5709
f16d9837
KH
57102011-05-25 Kenichi Handa <handa@m17n.org>
5711
5712 * xdisp.c (get_next_display_element): Set correct it->face_id for
5713 a static composition.
5714
e1b90ef6
LL
57152011-05-24 Leo Liu <sdl.web@gmail.com>
5716
5717 * deps.mk (fns.o):
5718 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5719
5720 * fns.c (crypto_hash_function, Fsha1): New function.
5721 (Fmd5): Use crypto_hash_function.
5722 (syms_of_fns): Add Ssha1.
5723
7400048f
PE
57242011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5725
5726 * gnutls.c: Remove unused macros.
5727 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5728 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5729 Remove macros that are defined and never used.
5730 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5731
abb71cf4
CY
57322011-05-22 Chong Yidong <cyd@stupidchicken.com>
5733
5734 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5735 (Fx_get_selection_internal): Minor cleanup.
5736 (Fx_own_selection_internal): Rename arguments for consistency with
5737 select.el.
5738
6307db39
PE
57392011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5740
5741 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5742
f3d4e0a4
CY
57432011-05-22 Chong Yidong <cyd@stupidchicken.com>
5744
5745 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5746
4d8ade89
YM
57472011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5748
5749 * dispnew.c (scrolling_window): Don't exclude the case that the
5750 last enabled row in the desired matrix touches the bottom boundary.
5751
32078c8d
GM
57522011-05-21 Glenn Morris <rgm@gnu.org>
5753
5754 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5755 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5756 and add some more files.
32078c8d 5757
7285dc67
EZ
57582011-05-20 Eli Zaretskii <eliz@gnu.org>
5759
5760 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5761 report_file_error introduced by the change from 2011-05-07.
5762
89d1bd22
PE
57632011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5764
5765 * systime.h (Time): Define only if emacs is defined.
5766 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5767 where the include path doesn't have X11/X.h by default. See
5768 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5769
e23640bb 57702011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5771
5772 * composite.c (find_automatic_composition): Fix previous change.
5773
b9704ad9
GM
57742011-05-20 Glenn Morris <rgm@gnu.org>
5775
5776 * lisp.mk: New file, split from Makefile.in.
5777 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5778 (shortlisp): Remove.
5779 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5780
4a720484
GM
57812011-05-19 Glenn Morris <rgm@gnu.org>
5782
5783 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5784 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5785 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5786 (lisp): Set the order to that of loadup.el.
5787 (shortlisp): Make it a copy of $lisp.
5788 (SOME_MACHINE_LISP): Remove.
5789 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5790 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5791
a28d4396
KH
57922011-05-18 Kenichi Handa <handa@m17n.org>
5793
5794 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5795 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5796 (find_automatic_composition): Mostly rewrite for efficiency.
5797
a2b1fa8e
JB
57982011-05-18 Juanma Barranquero <lekktu@gmail.com>
5799
5800 * makefile.w32-in: Update dependencies.
5801
8e1f5610
CS
58022011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5803
5804 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5805 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5806
7025ee00 58072011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5808
cdfa6eab
PE
5809 Fix some integer overflow issues, such as string length overflow.
5810
06d6db33
PE
5811 * insdel.c (count_size_as_multibyte): Check for string overflow.
5812
2b4560a8
PE
5813 * character.c (lisp_string_width): Check for string overflow.
5814 Use EMACS_INT, not int, for string indexes and lengths; in
5815 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5816 the resulting string length overflows an EMACS_INT; instead,
5817 report a string overflow if no precision given. When checking for
5818 precision exhaustion, use a check that cannot possibly have
5819 integer overflow. (Bug#8675)
5820 * character.h (lisp_string_width): Adjust to new signature.
5821
cb93f9be
PE
5822 * alloc.c (string_overflow): New function.
5823 (Fmake_string): Use it. This doesn't change behavior, but saves
5824 a few bytes and will simplify future changes.
5825 * character.c (string_escape_byte8): Likewise.
5826 * lisp.h (string_overflow): New decl.
5827
1a1f3366
PE
5828 Fixups, following up to the user-interface timestamp change.
5829 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5830 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5831 * msdos.c (mouse_get_pos): Likewise.
5832 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5833 * w32gui.h (Time): Define by including "systime.h" rather than by
5834 declaring it ourselves. (Bug#8664)
5835
d4e3e4d3
PE
5836 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5837 * image.c (clear_image_cache): Likewise.
5838
f6a24d19
PE
5839 * term.c (term_mouse_position): Don't assume time_t wraparound.
5840
08dc5ae6
PE
5841 Be more systematic about user-interface timestamps.
5842 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5843 and sometimes 'EMACS_UINT', to represent these timestamps.
5844 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5845 This makes the code easier to follow, and makes it easier to catch
5846 integer overflow bugs such as Bug#8664.
5847 * frame.c (Fmouse_position, Fmouse_pixel_position):
5848 Use Time, not unsigned long, for user-interface timestamps.
5849 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5850 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5851 * keyboard.h (last_event_timestamp): Likewise.
5852 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5853 * menu.h (xmenu_show): Likewise.
5854 * term.c (term_mouse_position): Likewise.
5855 * termhooks.h (struct input_event.timestamp): Likewise.
5856 (struct terminal.mouse_position_hook): Likewise.
5857 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5858 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5859 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5860 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5861 what it was before.
5862 * menu.h, termhooks.h: Include "systime.h", for Time.
5863
8e55734a
PE
5864 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5865 Don't assume that the difference between two unsigned long values
5866 can fit into an integer. At this point, we know button_down_time
5867 <= event->timestamp, so the difference must be nonnegative, so
5868 there's no need to cast the result if double-click-time is
5869 nonnegative, as it should be; check that it's nonnegative, just in
5870 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5871 apart (about 25 days). (Bug#8664)
8e55734a 5872
841f1b75 5873 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5874 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5875
3e26f69c
PE
5876 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5877 that always fit in int. Use a sentinel instead of a counter, to
5878 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5879 * frame.h (struct frame): Use int for menu_bar_items_used
5880 instead of EMACS_INT, since it always fits in int.
3e26f69c 5881
5cc152c0
PE
5882 * menu.c (grow_menu_items): Check for int overflow.
5883
d89eb65e
PE
5884 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5885
5235bd3e
PE
5886 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5887 Before, the code was not consistent. These values cannot exceed
5888 2**31 - 1 so there's no need to make them unsigned.
5889 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5890 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5891 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5892 as modifiers.
5893 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5894
bc827e23
PE
5895 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5896 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5897 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5898 presumably because the widths might not match.
5899
78eb494e
PE
5900 * window.c (size_window): Avoid needless test at loop start.
5901
04f2d78b
CB
59022011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5903
5904 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5905
d2fc7e3d 59062011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5907
5908 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5909
d2fc7e3d 59102011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5911
5912 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5913 `width' to `bar_area_x' and `bar_area_width', respectively.
5914 (x_scroll_run): Take account of fringe background extension.
5915
04f2d78b
CB
5916 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5917 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5918 `bar_area_width', respectively.
5919 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5920 background extension.
5921
79b70037
GM
59222011-05-10 Jim Meyering <meyering@redhat.com>
5923
5924 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5925
2f142cc5
JB
59262011-05-10 Juanma Barranquero <lekktu@gmail.com>
5927
5928 * image.c (Finit_image_library): Return t for built-in image types,
5929 like pbm and xbm. (Bug#8640)
5930
57679c86
AS
59312011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5932
5933 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5934
888c9e86
EZ
59352011-05-07 Eli Zaretskii <eliz@gnu.org>
5936
b0512a1d
EZ
5937 * w32console.c (Fset_screen_color): Doc fix.
5938 (Fget_screen_color): New function.
5939 (syms_of_ntterm): Defsubr it.
5940
7285dc67
EZ
5941 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5942 unlink the temporary file if Fcall_process didn't create it in the
5943 first place.
5944 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5945 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5946 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5947 cue to call_process_cleanup not to close that handle.
5948
4d3fcc8e
BK
59492011-05-07 Ben Key <bkey76@gmail.com>
5950
5951 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5952 one of two shell specific rules, either bootstrap-temacs-CMD or
5953 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5954 to the previous implementation of the bootstrap-temacs rule.
5955 The bootstrap-temacs-CMD rule is similar to the previous
5956 implementation of the bootstrap-temacs rule except that it
5957 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5958 variable.
5959
5960 These changes, along with some changes to nt/configure.bat,
5961 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5962 earlier fix to add support for --cflags and --ldflags options
5963 that include quotes so that it works whether make uses cmd or
5964 sh as the shell.
5965
b4289b64
MA
59662011-05-06 Michael Albinus <michael.albinus@gmx.de>
5967
5968 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5969 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5970 is a constant.
5971 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5972 a string. Handle both cases.
5973 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5974 (Fdbus_register_method): Use Qinvalid_function.
5975
af4c0e28
JB
59762011-05-06 Juanma Barranquero <lekktu@gmail.com>
5977
5978 * makefile.w32-in: Update dependencies.
5979 (LISP_H): Add inttypes.h and stdin.h.
5980 (PROCESS_H): Add unistd.h.
5981
c51453d9
EZ
59822011-05-06 Eli Zaretskii <eliz@gnu.org>
5983
5984 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5985 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5986
8ff0ac3c 59872011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5988
4c4b566b
PE
5989 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5990
aab2b9b5
PE
5991 * term.c (vfatal): Remove stray call to va_end.
5992 It's not needed and the C Standard doesn't allow it here anyway.
5993
c378da0b
PE
5994 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5995 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5996
288b08c7
PE
5997 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5998 bytes.
5999
e3601888
PE
6000 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6001
db6c0e74
PE
6002 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6003
dd5963ea
PE
6004 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6005
88c9450f
PE
6006 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6007
2f9442b8
PE
6008 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6009
c032b5f8
PE
6010 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6011 * charset.c (Fdefine_charset_internal): Don't initialize
6012 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6013 32-bit int (Bug#8600).
a108c10b
PE
6014
6015 * lread.c (read_integer): Be more consistent with string-to-number.
6016 Use string_to_number to do the actual conversion; this avoids
6017 rounding errors and fixes some other screwups. Without this fix,
6018 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6019 (digit_to_number): Move earlier, for benefit of read_integer.
6020 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6021 not a digit in any supported base. (Bug#8602)
a108c10b 6022
ad5f9eea
PE
6023 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6024
aec1708a
PE
6025 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6026 to match comment at start of function. This also removes a
6027 GCC warning about overflow in a 32+64-bit port.
6028
47be4ab5
PE
6029 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6030
371cac43
PE
6031 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6032 Reported by Stefan Monnier in
6033 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6034 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6035 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6036
d01a7826
PE
6037 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6038 (EMACS_UINTPTR): Likewise, with uintptr_t.
6039
7fd47d5c
PE
6040 * lisp.h: Prefer 64-bit EMACS_INT if available.
6041 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6042 on 32-bit hosts that have 64-bit int, so that they can access
6043 large files.
122b0c86
PE
6044 However, temporarily disable this change unless the temporary
6045 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6046
8727937b
PE
6047 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6048
8ac068ac
PE
6049 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6050 This removes an assumption that EMACS_INT and long are the same
6051 width as pointers. The assumption is true for Emacs porting targets
6052 now, but we want to make other targets possible.
6053 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6054 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6055 In the rest of the code, change types of integers that hold casted
6056 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6057 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6058 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6059 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6060 No need to cast type when ORing.
6061 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6062 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6063 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6064 assume EMACS_INT is the same width as char *.
6065 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6066 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6067 Remove no-longer-needed casts.
6068 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6069 (xg_tool_bar_help_callback, xg_make_tool_item):
6070 Use EMACS_INTPTR to hold an integer
6071 that will be cast to void *; this can avoid a GCC warning
6072 if EMACS_INT is not the same width as void *.
6073 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6074 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6075 (current_message_1, set_message_1):
6076 Use a local to convert to proper width without a cast.
6077 * xmenu.c (dialog_selection_callback): Likewise.
6078
ede49d71
PE
6079 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6080 Also, don't assume VALBITS / RAND_BITS is less than 5,
6081 and don't rely on undefined behavior when shifting a 1 left into
6082 the sign bit.
6083 * lisp.h (get_random): Change signature to match.
6084
2f30ecd0
PE
6085 * lread.c (hash_string): Use size_t, not int, for hash computation.
6086 Normally we prefer signed values; but hashing is special, because
6087 it's better to use unsigned division on hash table sizes so that
6088 the remainder is nonnegative. Also, size_t is the natural width
6089 for hashing into memory. The previous code used 'int', which doesn't
6090 retain enough info to hash well into very large tables.
6091 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6092
2a866e7b
PE
6093 * dbusbind.c: Don't possibly lose pointer info when converting.
6094 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6095 Use XPNTR rather than XHASH, so that the high-order bits of
6096 the pointer aren't lost when converting through void *.
6097
51639eac
PE
6098 * eval.c (Fautoload): Don't double-shift a pointer.
6099
92394119
PE
6100 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6101
dbdb9a7c
JB
61022011-05-06 Juanma Barranquero <lekktu@gmail.com>
6103
6104 * gnutls.c (DEF_GNUTLS_FN):
6105 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6106
db7a0b4f
AS
61072011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6108
6109 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6110 marker. (Bug#8610)
6111
f7ff1b0f 61122011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6113
6114 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6115 New version that can reserve upto 2GB of heap space.
6116
f7ff1b0f 61172011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6118
6119 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6120
639c109b
TZ
61212011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6122
6123 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6124 `gnutls_certificate_set_x509_key_file'.
6125
d2127135
JB
61262011-05-05 Juanma Barranquero <lekktu@gmail.com>
6127
6128 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6129 Update dependencies.
6130
e968f4f3
JB
61312011-05-04 Juanma Barranquero <lekktu@gmail.com>
6132
6133 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6134 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6135 Remove unused parameter `fildes'.
6136 * process.c (read_process_output, send_process): Don't pass it.
6137
84d358f0
JB
61382011-05-04 Juanma Barranquero <lekktu@gmail.com>
6139
6140 Fix previous change: the library cache is defined in w32.c.
6141 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6142 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6143
0898ca10
JB
61442011-05-04 Juanma Barranquero <lekktu@gmail.com>
6145
6146 Implement dynamic loading of GnuTLS on Windows.
6147
6148 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6149 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6150 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6151 Declare.
6152
6153 * gnutls.c (Qgnutls_dll): Define.
6154 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6155 (gnutls_*): Declare function pointers.
6156 (init_gnutls_functions): New function to initialize function pointers.
6157 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6158 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6159 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6160 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6161 (emacs_gnutls_write, emacs_gnutls_read)
6162 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6163 (Fgnutls_available_p): New function.
6164 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6165 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6166 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6167
6168 * image.c: Include w32.h.
6169 (Vimage_type_cache): Delete.
6170 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6171 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6172 (w32_delayed_load): Move to w32.c.
6173
6174 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6175
6176 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6177 (w32_delayed_load): Move from image.c. When loading a library, record
6178 its filename in the :loaded-from property of the library id.
6179 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6180 Initialize and staticpro them.
6181 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6182
6183 * process.c: Include lisp.h before w32.h, not after.
6184 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6185 instead of gnutls_record_check_pending.
6186
6187 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6188
ff4de4aa
TZ
61892011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6190
6191 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6192 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6193 as passed in.
6194
abe95abb
JD
61952011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6196
6197 * xterm.c (x_set_frame_alpha): Do not set property on anything
6198 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6199
e16e55d4
JB
62002011-05-02 Juanma Barranquero <lekktu@gmail.com>
6201
6202 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6203
bafcf6a5
JB
62042011-05-02 Juanma Barranquero <lekktu@gmail.com>
6205
6206 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6207 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6208 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6209 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6210 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6211 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6212 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6213 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6214 (Qgnutls_bootprop_callbacks_verify): Make static.
6215
e7a6747f
AS
62162011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6217
19ed11ba
AS
6218 * callproc.c: Indentation fixup.
6219
e7a6747f 6220 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6221 (wait_for_termination, interruptible_wait_for_termination):
6222 Move after wait_for_termination_1.
e7a6747f 6223
1ef14cb4
LMI
62242011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6225
6226 * sysdep.c (interruptible_wait_for_termination): New function
6227 which is like wait_for_termination, but allows keyboard
6228 interruptions.
6229
6230 * callproc.c (Fcall_process): Add (:file "file") as an option for
6231 the STDOUT buffer.
6232 (Fcall_process_region): Ditto.
6233
330d880c
EZ
62342011-04-30 Eli Zaretskii <eliz@gnu.org>
6235
8db90b73
EZ
6236 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6237 rather than `XVECTOR (FOO)->size'.
6238
330d880c
EZ
6239 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6240 inttypes.h, as a gnulib replacement is used if it not available in
6241 system headers.
6242
15cbd324
EZ
62432011-04-21 Eli Zaretskii <eliz@gnu.org>
6244
6245 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6246 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6247 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6248
6249 * coding.c (coding_alloc_by_realloc): Error out if destination
6250 will grow beyond MOST_POSITIVE_FIXNUM.
6251 (decode_coding_emacs_mule): Abort if there isn't enough place in
6252 charbuf for the composition carryover bytes. Reserve an extra
6253 space for up to 2 characters produced in a loop.
6254 (decode_coding_iso_2022): Abort if there isn't enough place in
6255 charbuf for the composition carryover bytes.
6256
62572011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6258
ae940cca
EZ
6259 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6260 aborting when %lld or %lll format is passed.
6261 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6262 %llo or %llx format is passed. (Bug#8545)
6263
03ab8921
EZ
6264 * window.c (window_scroll_line_based): Use a marker instead of
6265 simple variables to record original value of point. (Bug#7952)
6266
afda1437
EZ
6267 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6268 produced by %s or %c overflows available buffer space. (Bug#8545)
6269
f76dee0c
PE
62702011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6271
6272 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6273 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6274
fdc5744d
JB
62752011-04-28 Juanma Barranquero <lekktu@gmail.com>
6276
6277 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6278
638f053a
JB
62792011-04-28 Juanma Barranquero <lekktu@gmail.com>
6280
6281 * keyboard.c (Qdelayed_warnings_hook): Define.
6282 (command_loop_1): Run `delayed-warnings-hook'
6283 if Vdelayed_warnings_list is non-nil.
6284 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6285 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6286
d178f871
EZ
62872011-04-28 Eli Zaretskii <eliz@gnu.org>
6288
6289 * doprnt.c (doprnt): Don't return value smaller than the buffer
6290 size if the message was truncated. (Bug#8545).
6291
b124fd93
JB
62922011-04-28 Juanma Barranquero <lekktu@gmail.com>
6293
6294 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6295 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6296
e810457d
PE
62972011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6298
6299 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6300
ea51cceb
JB
63012011-04-27 Juanma Barranquero <lekktu@gmail.com>
6302
6303 * makefile.w32-in: Update dependencies.
6304
94dcfacf
EZ
63052011-04-27 Eli Zaretskii <eliz@gnu.org>
6306
6307 Improve `doprnt' and its usage. (Bug#8545)
6308 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6309 `format_end'. Remove support for %l as a conversion specifier.
6310 Don't use xrealloc. Improve diagnostics when the %l size modifier
6311 is used. Update the commentary.
6312
6313 * eval.c (verror): Simplify calculation of size_t.
6314
6315 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6316 messages.
6317
f61f41d7
PE
63182011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6319
6320 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6321 change.
6322
96fb4434
PE
63232011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6324
6325 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6326 This makes this file independent of the recent pseudovector change.
6327
671875da 63282011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6329
69e9b5a3
PE
6330 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6331
b5f869a7 6332 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6333 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6334 Remove unused local.
c8926152 6335 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6336
841a1577 6337 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6338 GCC 4.6.0 optimizes based on type-based alias analysis.
6339 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6340 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6341 != &v->size, and therefore "v->size = 1; b->size = 2; return
6342 v->size;" must therefore return 1. This assumption is incorrect
6343 for Emacs, since it type-puns struct Lisp_Vector * with many other
6344 types. To fix this problem, this patch adds a new type struct
f904488f 6345 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6346 and pseudovectors, and helps optimizing compilers not get fooled
6347 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6348 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6349 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6350 the size member.
eab3844f
PE
6351 (XSETPVECTYPE): Rewrite in terms of new macro.
6352 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6353 This is a bit clearer, and further avoids the possibility of
6354 undesirable aliasing.
6355 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6356 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6357 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6358 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6359 (ASIZE): Now uses header.size rather than size.
6360 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6361 to avoid the hassle of writing XVECTOR (foo)->header.size.
6362 (struct vectorlike_header): New type.
eab3844f
PE
6363 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6364 object, to help avoid aliasing.
6365 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6366 (SUBRP): Likewise, since Lisp_Subr is a special case.
6367 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6368 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6369 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6370 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6371 changed to be "header.size" and "header.next".
6372 * buffer.h (struct buffer): Likewise.
6373 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6374 * frame.h (struct frame): Likewise.
6375 * process.h (struct Lisp_Process): Likewise.
6376 * termhooks.h (struct terminal): Likewise.
6377 * window.c (struct save_window_data, struct saved_window): Likewise.
6378 * window.h (struct window): Likewise.
6379 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6380 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6381 * buffer.c (init_buffer_once): Likewise.
6382 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6383 special case.
6384 * process.c (Fformat_network_address): Use local var for size,
6385 for brevity.
6386
0df1eac5
PE
6387 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6388
847ab9d1 6389 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6390 * data.c (atof): Remove decl; no longer used or needed.
6391 (digit_to_number): Move to lread.c.
6392 (Fstring_to_number): Use new string_to_number function, to be
6393 consistent with how the Lisp reader treats infinities and NaNs.
6394 Do not assume that floating-point numbers represent EMACS_INT
6395 without losing information; this is not true on most 64-bit hosts.
6396 Avoid double-rounding errors, by insisting on integers when
6397 parsing non-base-10 numbers, as the documentation specifies.
6398 * lisp.h (string_to_number): New decl, replacing ...
6399 (isfloat_string): Remove.
bc0a5c13 6400 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6401 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6402 appears to have been a coding error. Similarly, do not accept
6403 strings like +-1e0 as floating point numbers. Do not report
6404 overflow for integer overflows unless the base is not 10 which
6405 means we have no simple and reliable way to continue.
6406 Break out the floating-point parsing into a new
6407 function string_to_number, so that Fstring_to_number parses
6408 floating point numbers consistently with the Lisp reader.
04f2d78b 6409 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6410 (E_CHAR, EXP_INT): Remove, replacing with ...
6411 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6412 (string_to_number): New function, replacing isfloat_string.
6413 This function checks for valid syntax and produces the resulting
6414 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6415 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6416 so that overflow for non-base-10 numbers is reported only when
6417 there's no portable and simple way to convert to floating point.
452f4150 6418
67769ffc
PE
6419 * textprop.c (set_text_properties_1): Rewrite for clarity,
6420 and to avoid GCC warning about integer overflow.
6421
c20db43f
PE
6422 * intervals.h (struct interval): Use EMACS_INT for members
6423 where EMACS_UINT might cause problems. See
6424 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6425 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6426 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6427 All uses changed.
37aa2f85
PE
6428 (offset_intervals): Tell GCC not to worry about length overflow
6429 when negating a negative length.
c20db43f 6430
2538aa2f
PE
6431 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6432 (overrun_check_free): Likewise.
6433
f2d3008d
PE
6434 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6435 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6436 word size.
6437
ec8df744
PE
6438 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6439 (gnutls_make_error): Rename local to avoid shadowing.
6440 (gnutls_emacs_global_deinit): ifdef out; not used.
6441 (Fgnutls_boot): Use const for pointer to readonly storage.
6442 Comment out unused local. Fix pointer signedness problems.
6443
640ee02d
PE
6444 * lread.c (openp): Don't stuff size_t into an 'int'.
6445 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6446 about possible signed overflow.
6447
6048fb2a
PE
6448 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6449 (GDK_KEY_g): Don't define if already defined.
6450 (xg_prepare_tooltip): Avoid pointer signedness problem.
6451 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6452
fa3c87e1
PE
6453 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6454 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6455
2172544b
PE
6456 * xfns.c (Fx_window_property): Simplify a bit,
6457 to make a bit faster and to avoid GCC 4.6.0 warning.
6458 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6459
9b821a21
PE
6460 * fns.c (internal_equal): Don't assume size_t fits in int.
6461
3c616cfa
PE
6462 * alloc.c (compact_small_strings): Tighten assertion a little.
6463
c2982e87
PE
6464 Replace pEd with more-general pI, and fix some printf arg casts.
6465 * lisp.h (pI): New macro, generalizing old pEd macro to other
6466 conversion specifiers. For example, use "...%"pI"d..." rather
6467 than "...%"pEd"...".
6468 (pEd): Remove. All uses replaced with similar uses of pI.
6469 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6470 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6471 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6472 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6473 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6474 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6475 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6476 64-bit hosts.
6477 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6478 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6479 * print.c (safe_debug_print, print_object): Likewise.
6480 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6481 to int.
6f04d126
PE
6482 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6483 avoiding the 0 flag, which is not portable.
c2982e87
PE
6484 * process.c (Fmake_network_process): Use pI to avoid cast.
6485 * region-cache.c (pp_cache): Likewise.
6486 * xdisp.c (decode_mode_spec): Likewise.
6487 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6488 behavior on 64-bit hosts with printf arg.
6f04d126 6489 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6490 (x_stop_queuing_selection_requests): Likewise.
6491 (x_get_window_property): Don't truncate byte count to an 'int'
6492 when tracing.
0b432f21 6493
5e073ec7
PE
6494 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6495 here, since it parses constructs like leading '-' and spaces,
6496 which are not wanted; and it overflows with large numbers.
6497 Instead, simply match F[0-9]+, which is what is wanted anyway.
6498
36372bf9
PE
6499 * alloc.c: Remove unportable assumptions about struct layout.
6500 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6501 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6502 (allocate_vectorlike, make_pure_vector): Use the new macros,
6503 plus offsetof, to remove unportable assumptions about struct layout.
6504 These assumptions hold on all porting targets that I know of, but
6505 they are not guaranteed, they're easy to remove, and removing them
6506 makes further changes easier.
6507
0b432f21
PE
6508 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6509 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6510 (string_overrun_cookie): Now const. Use initializers that
6511 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6512 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6513 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6514 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6515 multiple of sizeof (EMACS_INT); it need not be, if
6516 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6517 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6518
895009e1
JB
65192011-04-26 Juanma Barranquero <lekktu@gmail.com>
6520
6521 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6522
6a7a1b0b
TZ
65232011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6524
6525 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6526 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6527 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6528
841a1577 65292011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6530
6531 * lisp.h (Qdebug): List symbol.
895009e1 6532 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6533 * keyboard.c (debug-on-event): New variable.
6534 (handle_user_signal): Break into debugger when debug-on-event
6535 matches the current signal symbol.
6536
f2d3ba6f
DN
65372011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6538
6539 * alloc.c (check_sblock, check_string_bytes)
6540 (check_string_free_list): Convert to standard C.
6541
42ce4c63
TZ
65422011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6543
6544 * w32.c (emacs_gnutls_push): Fix typo.
6545
825cd63c
EZ
65462011-04-25 Eli Zaretskii <eliz@gnu.org>
6547
fb11d64d
EZ
6548 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6549 "cast to pointer from integer of different size".
6550
825cd63c
EZ
6551 Improve doprnt and its use in verror. (Bug#8545)
6552 * doprnt.c (doprnt): Document the set of format control sequences
6553 supported by the function. Use SAFE_ALLOCA instead of always
6554 using `alloca'.
6555
6556 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6557 is one byte too soon. Don't use xrealloc; instead xfree and
6558 xmalloc anew.
6559
e061a11b
TZ
65602011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6561
6562 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6563 callbacks stage.
6564
6565 * gnutls.c: Renamed global_initialized to
6566 gnutls_global_initialized. Added internals for the
6567 :verify-hostname-error, :verify-error, and :verify-flags
6568 parameters of `gnutls-boot' and documented those parameters in the
6569 docstring. Start callback support.
9173deec
JB
6570 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6571 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6572 on error. Return error code.
e061a11b
TZ
6573 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6574 (emacs_gnutls_read): Likewise.
6575 (Fgnutls_boot): Return handshake error code.
6576 (emacs_gnutls_handle_error): New function.
6577 (wsaerror_to_errno): Likewise.
6578
6579 * w32.h (emacs_gnutls_pull): Add prototype.
6580 (emacs_gnutls_push): Likewise.
6581
6582 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6583 (emacs_gnutls_push): Likewise.
6584
65852011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6586
6587 * process.c (wait_reading_process_output): Check if GnuTLS
6588 buffered some data internally if no FDs are set for TLS
6589 connections.
6590
6591 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6592 (LIBS): Link to USER_LIBS.
6593 ($(BLD)/gnutls.$(0)): New target.
6594
fa6996bc
EZ
65952011-04-24 Eli Zaretskii <eliz@gnu.org>
6596
eb35682e
EZ
6597 * xdisp.c (handle_single_display_spec): Rename the
6598 display_replaced_before_p argument into display_replaced_p, to
6599 make it consistent with the commentary. Fix typos in the
6600 commentary.
6601
e2ad650c
EZ
6602 * textprop.c (syms_of_textprop): Remove dead code.
6603 (copy_text_properties): Delete obsolete commentary about an
6604 interface that was deleted long ago. Fix typos in the description
6605 of arguments.
6606
1b2de274
EZ
6607 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6608 to changes in oldXMenu/XMenu.h from 2011-04-16.
6609 <menu_help_message, prev_menu_help_message>: Constify.
6610 (IT_menu_make_room): menu->help_text is now `const char **';
6611 adjust.
6612
6613 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6614 to changes in oldXMenu/XMenu.h from 2011-04-16.
6615 (struct XMenu): Declare `help_text' `const char **'.
6616
6617 * xfaces.c <Qunspecified>: Make extern again.
6618
6619 * syntax.c: Include sys/types.h before including regex.h, as
6620 required by Posix.
6621
762b15be
EZ
6622 * doc.c (get_doc_string): Improve the format passed to `error'.
6623
6624 * doprnt.c (doprnt): Improve commentary.
6625
6626 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6627
6628 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6629 them with etags.
6630
f1052e5d
EZ
6631 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6632 changes in globals.h immediately force recompilation.
762b15be
EZ
6633 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6634 $(CURDIR)/s/ms-w32.h.
6635 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6636
fa6996bc
EZ
6637 * character.c (Fchar_direction): Function deleted.
6638 (syms_of_character): Don't defsubr it.
6639 <char-direction-table>: Deleted.
6640
e6c3da20
EZ
66412011-04-23 Eli Zaretskii <eliz@gnu.org>
6642
6643 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6644 * doprnt.c: Include limits.h.
6645 (SIZE_MAX): New macro.
04f2d78b
CB
6646 (doprnt): Return a size_t value. 2nd arg is now size_t.
6647 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6648 Improve overflow protection. Support `l' modifier for integer
6649 conversions. Support %l conversion. Don't assume an EMACS_INT
6650 argument for integer conversions and for %c.
6651
6652 * lisp.h (doprnt): Restore prototype.
6653
6654 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6655 $(SRC)/character.h.
6656
6657 * Makefile.in (base_obj): Add back doprnt.o.
6658
6659 * deps.mk (doprnt.o): Add back prerequisites.
6660 (callint.o): Depend on character.h.
6661
6662 * eval.c (internal_lisp_condition_case): Include the handler
6663 representation in the error message.
6664 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6665 when breaking from the loop.
6666
6667 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6668
6669 * callint.c (Fcall_interactively): When displaying error message
6670 about invalid control letter, pass the character's codepoint, not
6671 a pointer to its multibyte form. Improve display of the character
6672 in octal and display also its hex code.
6673
6674 * character.c (char_string): Use %x to display the (unsigned)
6675 codepoint of an invalid character, to avoid displaying a bogus
6676 negative value.
6677
6678 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6679 `error', not SYMBOL_NAME itself.
6680
6681 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6682 character arguments to `error'.
6683
6684 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6685 to `error' in error message about FINAL_CHAR argument. Make sure
6686 FINAL_CHAR is a character, and use %c when it is passed as
6687 argument to `error'.
6688
4ffd0d6b 66892011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6690
6691 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6692
6693 * w32.c: Include <time.h>.
6694 (sys_localtime): New function.
6695
4ffd0d6b 66962011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6697
6698 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6699
4ffd0d6b 6700 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6701
4ffd0d6b 67022011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6703
4ffd0d6b
GM
6704 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6705 zombies (Bug#8467).
aac0c6e3 6706
04c56954
EZ
67072011-04-19 Eli Zaretskii <eliz@gnu.org>
6708
6709 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6710 gl_state.e_property when gl_state.object is Qt.
6711
6712 * insdel.c (make_gap_larger): Remove limitation of buffer size
6713 to <= INT_MAX.
6714
16a43933
CY
67152011-04-18 Chong Yidong <cyd@stupidchicken.com>
6716
6717 * xdisp.c (lookup_glyphless_char_display)
6718 (produce_glyphless_glyph): Handle cons cell entry in
6719 glyphless-char-display.
6720 (Vglyphless_char_display): Document it.
6721
6722 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6723 glyphless-char-display.
6724
4581706e
CY
67252011-04-17 Chong Yidong <cyd@stupidchicken.com>
6726
6727 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6728
6729 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6730
6731 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6732 definition for no-X builds.
6733
4887c6e2 67342011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6735
fd35b6f9
PE
6736 Static checks with GCC 4.6.0 and non-default toolkits.
6737
5c1ccb01
PE
6738 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6739
006c5daa
PE
6740 * process.c (keyboard_bit_set): Define only if SIGIO.
6741 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6742 (send_process): Repair possible setjmp clobbering.
6743
efc736d3
PE
6744 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6745
4e2fe2e6
PE
6746 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6747
f97334a2
PE
6748 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6749
4e75f29d
PE
6750 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6751 Define only if needed.
6752
90efadd1
PE
6753 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6754 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6755 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6756
3c647824
PE
6757 * dispextern.h (struct redisplay_interface): Rename param
6758 to avoid shadowing.
e264f262 6759 * termhooks.h (struct terminal): Likewise.
761383f4 6760 * xterm.c (xembed_send_message): Likewise.
3c647824 6761
b58c5c4a
PE
6762 * insdel.c (make_gap_smaller): Define only if
6763 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6764
cad59032
PE
6765 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6766 it.
6767
c339dc2e
PE
6768 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6769 so that we aren't warned about unused symbols.
6770
91a3e27b
PE
6771 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6772
399c71d3 6773 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6774
8ffc96f5
PE
6775 * xfns.c (x_real_positions): Mark locals as initialized.
6776
eef9bc79
PE
6777 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6778
098db9dd
PE
6779 * xterm.c: Fix problems found by static analysis with other toolkits.
6780 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6781 (x_dispatch_event): Declare static if USE_GTK, and
6782 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6783 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6784 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6785 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6786 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6787
eb18f6cc
PE
6788 * xmenu.c (menu_help_callback): Pointer type fixes.
6789 Use const pointers when pointing at readonly data. Avoid pointer
6790 signedness clashes.
6791 (FALSE): Remove unused macro.
6792 (update_frame_menubar): Remove unused decl.
6793
1fe72bf8
PE
6794 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6795
60d9e1db
PE
6796 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6797 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6798 (single_menu_item): Rename local to avoid shadowing.
6799
39261c26
PE
6800 * keyboard.c (make_lispy_event): Remove unused local var.
6801
018c5e19
PE
6802 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6803 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6804
63d2b86e
PE
6805 * bitmaps: Change bitmaps from unsigned char back to the X11
6806 compatible char. Avoid the old compiler warnings about
6807 out-of-range initializers by using, for example, '\xab' rather
6808 than 0xab.
6809
aefd87e1
PE
6810 * xgselect.c (xgselect_initialize): Check vs interface
6811 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6812
bf501fb9
PE
6813 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6814
e9829fdf
PE
6815 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6816 to read-only memory.
6817
1086c095
PE
6818 * fns.c (vector): Remove; this old hack is no longer needed.
6819
2baccd04 6820 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6821 Remove unused var.
dde42981 6822 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6823
72391843 6824 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6825
436c16df 6826 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6827 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6828 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6829
92bb796d 6830 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6831 (x_term_init): Remove local to avoid shadowing.
92bb796d 6832
764430a3 6833 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6834
6835 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6836 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6837
d1dfb56c
EZ
68382011-04-16 Eli Zaretskii <eliz@gnu.org>
6839
c4354cb4
EZ
6840 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6841
d1dfb56c
EZ
6842 Fix regex.c, syntax.c and friends for buffers > 2GB.
6843 * syntax.h (struct gl_state_s): Declare character position members
6844 EMACS_INT.
6845
6846 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6847
04f2d78b
CB
6848 * textprop.c (verify_interval_modification, interval_of):
6849 Declare arguments EMACS_INT.
d1dfb56c
EZ
6850
6851 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6852 EMACS_INT.
6853
6854 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6855
6856 * indent.c (Fvertical_motion): Local variable it_start is now
6857 EMACS_INT.
6858
6859 * regex.c (re_match, re_match_2, re_match_2_internal)
6860 (bcmp_translate, regcomp, regexec, print_double_string)
6861 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6862 (re_compile_pattern, re_exec): Declare arguments and local
6863 variables `size_t' and `ssize_t' and return values `regoff_t', as
6864 appropriate.
6865 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6866 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6867 <compile_stack_type>: `size' and `avail' are now `size_t'.
6868
6869 * regex.h <regoff_t>: Use ssize_t, not int.
6870 (re_search, re_search_2, re_match, re_match_2): Arguments that
6871 specify buffer/string position and length are now ssize_t and
6872 size_t. Return type is regoff_t.
6873
613052cd
BK
68742011-04-16 Ben Key <bkey76@gmail.com>
6875
6876 * nsfont.m: Fixed bugs in ns_get_family and
6877 ns_descriptor_to_entity that were caused by using free to
6878 deallocate memory blocks that were allocated by xmalloc (via
6879 xstrdup). This caused Emacs to crash when compiled with
6880 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6881 --enable-checking=xmallocoverrun). xfree is now used to
6882 deallocate these memory blocks.
6883
4170f62f 68842011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6885
71b41406
PE
6886 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6887
9587a89d
PE
6888 emacs_write: Accept and return EMACS_INT for sizes.
6889 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6890 et seq.
6891 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6892 Accept and return EMACS_INT.
6893 (emacs_gnutls_write): Return the number of bytes written on
6894 partial writes.
6895 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6896 (emacs_read, emacs_write): Remove check for negative size, as the
6897 Emacs source code has been audited now.
9587a89d
PE
6898 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6899 (emacs_read, emacs_write): Use it.
273a5f82
PE
6900 * process.c (send_process): Adjust to the new signatures of
6901 emacs_write and emacs_gnutls_write. Do not attempt to store
6902 a byte offset into an 'int'; it might overflow.
9587a89d 6903 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6904
3e047f51
PE
6905 * sound.c: Don't assume sizes fit in 'int'.
6906 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6907 Return EMACS_INT, not int.
3e047f51 6908 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6909 Accept EMACS_INT, not int.
6910 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6911 record read return values.
6912
cc39a9db
BK
69132011-04-15 Ben Key <bkey76@gmail.com>
6914
c9d0ec6d
JB
6915 * keyboard.c (Qundefined): Don't declare static since it is used
6916 in nsfns.m.
6917 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6918 static since they are used in nsfont.m.
cc39a9db 6919
6c60eb9f
SM
69202011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6921
6922 * process.c (Qprocessp): Don't declare static.
6923 * lisp.h (Qprocessp): Declare again.
6924
7990b61a
JB
69252011-04-15 Juanma Barranquero <lekktu@gmail.com>
6926
6927 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6928
5d4cb038
PE
69292011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6930
8bd7b830 6931 Improve C-level modularity by making more things 'static'.
cd64ea1d 6932
e3b27b31
PE
6933 Don't publish debugger-only interfaces to other modules.
6934 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6935 (verify_bytepos, count_markers): Move decls to the only modules
6936 that need them.
6937 * region-cache.h (pp_cache): Likewise.
6938 * window.h (check_all_windows): Likewise.
6939 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6940
5d4cb038
PE
6941 * sysdep.c (croak): Now static, if
6942 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6943 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6944
6945 * alloc.c (refill_memory_reserve): Now static if
6946 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6947 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6948
e87b6180
PE
6949 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6950 Define only if USE_LUCID.
6951
ac64929e
PE
6952 * xrdb.c (x_customization_string, x_rm_string): Now static.
6953
6f37259d
PE
6954 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6955 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6956
1683e3ab
PE
6957 * xdisp.c (draw_row_with_mouse_face): Now static.
6958 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6959
de9c2632
PE
6960 * window.h (check_all_windows): Mark externally visible.
6961
2b96acb7
PE
6962 * window.c (window_deletion_count): Now static.
6963
6964 * undo.c: Make symbols static if they're not exported.
6965 (last_undo_buffer, last_boundary_position, pending_boundary):
6966 Now static.
6967
50436f33
PE
6968 * textprop.c (interval_insert_behind_hooks): Now static.
6969 (interval_insert_in_front_hooks): Likewise.
6970
64520e5c
PE
6971 * term.c: Make symbols static if they're not exported.
6972 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6973 (max_frame_lines, tty_set_terminal_modes):
6974 (tty_reset_terminal_modes, tty_turn_off_highlight):
6975 (get_tty_terminal): Now static.
6976 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6977 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6978 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6979 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6980 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6981
1fa53021
PE
6982 * sysdep.c: Make symbols static if they're not exported.
6983 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6984 Now static.
6985 (sigprocmask_set, full_mask): Remove; unused.
6986 (wait_debugging): Mark as visible.
6987 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6988 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6989
d4b43b22
PE
6990 * syntax.c (syntax_temp): Define only if !__GNUC__.
6991
b7c513d0
PE
6992 * sound.c (current_sound_device, current_sound): Now static.
6993
989b29ad
PE
6994 * search.c (searchbufs, searchbuf_head): Now static.
6995
13a55a78
PE
6996 * scroll.c (scroll_cost): Remove; unused.
6997 * dispextern.h (scroll_cost): Remove decl.
6998
de68a1fc
PE
6999 * region-cache.h (pp_cache): Mark as externally visible.
7000
40ccffa6
PE
7001 * process.c: Make symbols static if they're not exported.
7002 (process_tick, update_tick, create_process, chan_process):
7003 (Vprocess_alist, proc_buffered_char, datagram_access):
7004 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7005 (deactivate_process): Mark defn as static, as well as decl.
7006 * lisp.h (create_process): Remove decl.
7007 * process.h (chan_process, Vprocess_alist): Remove decls.
7008
ad64fc97
PE
7009 * print.c: Make symbols static if they're not exported.
7010 (print_depth, new_backquote_output, being_printed, print_buffer):
7011 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7012 (print_interval, print_number_index, initial_stderr_stream):
7013 Now static.
7014 * lisp.h (Fprinc): Remove decl.
7015 (debug_output_compilation_hack): Mark as externally visible.
7016
adddb265
PE
7017 * sysdep.c (croak): Move decl from here to syssignal.h.
7018 * syssignal.h (croak): Put it here, so the API can be checked when
7019 'croak' is called from dissociate_if_controlling_tty.
7020
1717ede2
PE
7021 * minibuf.c: Make symbols static if they're not exported.
7022 (minibuf_save_list, choose_minibuf_frame): Now static.
7023 * lisp.h (choose_minibuf_frame): Remove decl.
7024
fa5fb2bc
PE
7025 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7026
1e3890d1
PE
7027 * lread.c: Make symbols static if they're not exported.
7028 (read_objects, initial_obarray, oblookup_last_bucket_number):
7029 Now static.
7030 (make_symbol): Remove; unused.
7031 * lisp.h (initial_obarray, make_symbol): Remove decls.
7032
8a1414fa
PE
7033 * keyboard.c: Make symbols static if they're not exported.
7034 (single_kboard, recent_keys_index, total_keys, recent_keys):
7035 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7036 (this_single_command_key_start, echoing, last_auto_save):
7037 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7038 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7039 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7040 (Vlispy_mouse_stem, double_click_count):
7041 Now static.
7042 (force_auto_save_soon): Define only if SIGDANGER.
7043 (ignore_mouse_drag_p): Now static if
7044 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7045 (print_help): Remove; unused.
7046 (stop_character, last_timer_event): Mark as externally visible.
7047 * keyboard.h (ignore_mouse_drag_p): Declare only if
7048 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7049 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7050 * lisp.h (echoing): Remove decl.
7051 (force_auto_save_soon): Declare only if SIGDANGER.
7052 * xdisp.c (redisplay_window): Simplify code, to make it more
7053 obvious that ignore_mouse_drag_p is not accessed if !defined
7054 USE_GTK && !defined HAVE_NS.
7055
93ea6e8f
PE
7056 * intervals.c: Make symbols static if they're not exported.
7057 (merge_properties_sticky, merge_interval_right, delete_interval):
7058 Now static.
7059 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7060
77382fcc
PE
7061 * insdel.c: Make symbols static if they're not exported.
7062 However, leave prepare_to_modify_buffer alone. It's never
7063 called from outside this function, but that appears to be a bug.
7064 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7065 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7066 (adjust_after_replace_noundo): Remove; unused.
7067 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7068 (signal_before_change): Remove decls.
77382fcc 7069
9306c32e
PE
7070 * indent.c (val_compute_motion, val_vmotion): Now static.
7071
cd44d2eb
PE
7072 * image.c: Make symbols static if they're not exported.
7073 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7074 if USE_GTK.
7075 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7076 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7077
ad9a7a06
PE
7078 * fringe.c (standard_bitmaps): Now static.
7079 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7080
81626931
PE
7081 * frame.c: Make symbols static if they're not exported.
7082 (x_report_frame_params, make_terminal_frame): Now static.
7083 (get_frame_param): Now static, unless HAVE_NS.
7084 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7085 (x_get_resource_string): Remove; not used.
7086 * frame.h (make_terminal_frame, x_report_frame_params):
7087 (x_get_resource_string); Remove decls.
7088 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7089 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7090
239f9db9
PE
7091 * font.c, fontset.c: Make symbols static if they're not exported.
7092 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7093 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7094 * font.c (font_close_object): Now static.
7095 * font.h (font_close_object): Remove.
7096 * fontset.c (FONTSET_OBJLIST): Remove.
7097 (free_realized_fontset) #if-0 the body, which does nothing.
7098 (face_suitable_for_char_p): #if-0, as it's never called.
7099 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7100 * xfaces.c (face_at_string_position):
7101 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7102 since 0 is always ASCII.
7103
dfcf3579
PE
7104 * fns.c (weak_hash_tables): Now static.
7105
5045092b
PE
7106 * fileio.c: Make symbols static if they're not exported.
7107 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7108 (Vwrite_region_annotation_buffers): Now static.
7109
57a96f5c
PE
7110 * eval.c: Make symbols static if they're not exported.
7111 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7112 * lisp.h (backtrace_list): Remove decl.
7113
35f08c38
PE
7114 * emacs.c: Make symbols static if they're not exported.
7115 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7116 (fatal_error_code, fatal_error_signal_hook, standard_args):
7117 Now static.
7118 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7119 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7120 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7121 * lisp.h (fatal_error_signal_hook): Remove decl.
7122 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7123
f44bd759
PE
7124 * editfns.c: Move a (normally-unused) function to its only use.
7125 * editfns.c, lisp.h (get_operating_system_release): Remove.
7126 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7127 worth the hassle of breaking this out.
7128
b532497d
PE
7129 * xterm.c: Make symbols static if they're not exported.
7130 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7131 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7132 (x_destroy_window, x_delete_display):
7133 Now static.
7134 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7135 (x_mouse_leave): Remove; unused.
7136 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7137 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7138 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7139 Remove decls.
7140 (x_mouse_leave): Declare only if WINDOWSNT.
7141 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7142 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7143 USE_X_TOOLKIT.
7144
1675728f
PE
7145 * ftxfont.c: Make symbols static if they're not exported.
7146 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7147 HAVE_FREETYPE.
7148 * font.h (ftxfont_driver): Likewise.
7149
e4cebfca
PE
7150 * xfns.c: Make symbols static if they're not exported.
7151 (x_last_font_name, x_display_info_for_name):
7152 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7153 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7154 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7155 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7156 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7157 (last_show_tip_args): Now static.
7158 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7159 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7160 (x_screen_planes): Remove; unused.
7161 * dispextern.h (x_screen_planes): Remove decl.
7162
5bf46f05
PE
7163 * dispnew.c: Make symbols static if they're not exported.
7164 * dispextern.h (redraw_garbaged_frames, scrolling):
7165 (increment_row_positions): Remove.
7166 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7167 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7168 Now static.
7169 (redraw_garbaged_frames): Remove; unused.
7170
435f4c28
PE
7171 * xfaces.c: Make symbols static if they're not exported.
7172 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7173 Remove decls.
7174 * xterm.h (defined_color): Remove decls.
7175 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7176 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7177 (menu_face_changed_default, defined_color, free_realized_face):
7178 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7179 (ascii_face_of_lisp_face): Remove; unused.
7180
8524aef3
PE
7181 * xdisp.c: Make symbols static if they're not exported.
7182 * dispextern.h (scratch_glyph_row, window_box_edges):
7183 (glyph_to_pixel_coords, set_cursor_from_row):
7184 (get_next_display_element, set_iterator_to_next):
7185 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7186 (show_mouse_face): Remove decls
7187 * frame.h (message_buf_print): Likewise.
7188 * lisp.h (pop_message, set_message, check_point_in_composition):
7189 Likewise.
7190 * xterm.h (set_vertical_scroll_bar): Likewise.
7191 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7192 (message_buf_print, scratch_glyph_row, displayed_buffer):
7193 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7194 (get_next_display_element, show_mouse_face, window_box_edges):
7195 (frame_to_window_pixel_xy, check_point_in_composition):
7196 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7197 (glyph_to_pixel_coords): Remove; unused.
7198
16390cd2
PE
7199 * dired.c (file_name_completion): Now static.
7200
7201 * dbusbind.c (xd_in_read_queued_messages): Now static.
7202
a25f4dfa
PE
7203 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7204 * data.c (circular_list_error): Remove.
7205
14a9c8df
PE
7206 * commands.h (last_point_position, last_point_position_buffer):
7207 (last_point_position_window): Remove decls.
7208 * keyboard.c: Make these variables static.
7209
04f2d78b
CB
7210 * coding.h (coding, code_convert_region, encode_coding_gap):
7211 Remove decls.
74ab6df5
PE
7212 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7213 (iso_code_class, detect_coding, code_convert_region): Now static.
7214 (encode_coding_gap): Remove; unused.
7215
38dfbee1
PE
7216 * chartab.c (chartab_chars, chartab_bits): Now static.
7217
a2cb4e63
PE
7218 * charset.h (charset_iso_8859_1): Remove decl.
7219 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7220 Now static.
7221
127198fd
PE
7222 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7223 * ccl.c (Vccl_program_table): Now static.
7224 (check_ccl_update): Remove; unused.
7225
d85b608f
PE
7226 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7227 * category.h: ... from here.
7228 * category.c (check_category_table, set_category_set): Now static.
7229
31cd66f3
PE
7230 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7231 * lisp.h: Remove these decls.
7232
c358e587
PE
7233 * buffer.c (buffer_count): Remove unused var.
7234
e78aecca
PE
7235 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7236 so that it's not optimized away.
7237 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7238 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7239 exported only to the debugger.
7240
e192d7d3 7241 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7242 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7243
92470028
PE
7244 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7245 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7246 was inaccessible from Lisp.
7247 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7248 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7249
244ed907
PE
7250 alloc.c: Import and export fewer symbols, and remove unused items.
7251 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7252 is defined.
7253 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7254 it's not optimized away by whole-program optimization.
7255 (message_enable_multibyte, free_misc): Remove.
7256 (catchlist, handlerlist, mark_backtrace):
7257 Declare only if BYTE_MARK_STACK.
7258 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7259 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7260 (message_enable_multibyte): Remove decl.
7261 (free_misc, interval_free_list, float_block, float_block_index):
7262 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7263 (cons_free_list, last_marked_index):
7264 Now static.
7265 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7266 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7267 (mark_backtrace): Define only if BYTE_MARK_STACK.
7268 * xdisp.c (message_enable_multibyte): Now static.
7269
61c2b50e 7270 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7271 This makes it easier for human readers (and static analyzers)
7272 to see whether these variables are used from other modules.
7273 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7274 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7275 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7276 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7277 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7278 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7279 * xmenu.c, xselect.c:
7280 Declare Q* vars static if they are not used in other modules.
7281 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7282 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7283 Remove decls of unexported vars.
7284 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7285
95c82688
PE
7286 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7287
16a97296
PE
7288 Make Emacs functions such as Fatom 'static' by default.
7289 This makes it easier for human readers (and static analyzers)
7290 to see whether these functions can be called from other modules.
7291 DEFUN now defines a static function. To make the function external
7292 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7293 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7294 (Finit_image_library):
16a97296
PE
7295 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7296 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7297 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7298 Remove decls, since these functions are now static.
7299 (Funintern, Fget_internal_run_time): New decls, since these functions
7300 were already external.
95c82688 7301
16a97296
PE
7302 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7303 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7304 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7305 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7306 * keyboard.c, keymap.c, lread.c:
7307 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7308 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7309 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7310 Mark functions with DEFUE instead of DEFUN,
7311 if they are used in other modules.
7312 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7313 decls for now-static functions.
7314 * buffer.h (Fdelete_overlay): Remove decl.
7315 * callproc.c (Fgetenv_internal): Mark as internal.
7316 * composite.c (Fremove_list_of_text_properties): Remove decl.
7317 (Fcomposition_get_gstring): New forward static decl.
7318 * composite.h (Fcomposite_get_gstring): Remove decl.
7319 * dired.c (Ffile_attributes): New forward static decl.
7320 * doc.c (Fdocumntation_property): New forward static decl.
7321 * eval.c (Ffetch_bytecode): New forward static decl.
7322 (Funintern): Remove extern decl; now in .h file where it belongs.
7323 * fileio.c (Fmake_symbolic_link): New forward static decl.
7324 * image.c (Finit_image_library): New forward static decl.
7325 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7326 * intervals.h (Fprevious_property_change):
7327 (Fremove_list_of_text_properties): Remove decls.
7328 * keyboard.c (Fthis_command_keys): Remove decl.
7329 (Fcommand_execute): New forward static decl.
7330 * keymap.c (Flookup_key): New forward static decl.
7331 (Fcopy_keymap): Now static.
7332 * keymap.h (Flookup_key): Remove decl.
7333 * process.c (Fget_process): New forward static decl.
7334 (Fprocess_datagram_address): Mark as internal.
7335 * syntax.c (Fsyntax_table_p): New forward static decl.
7336 (skip_chars): Remove duplicate decl.
7337 * textprop.c (Fprevious_property_change): New forward static decl.
7338 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7339 Now internal.
7340 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7341 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7342
785bbd42
PE
7343 * editfns.c (Fformat): Remove unreachable code.
7344
8b913b57
AS
73452011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7346
7347 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7348 change. (Bug#8496)
7349
a6744a35
EZ
73502011-04-13 Eli Zaretskii <eliz@gnu.org>
7351
7352 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7353 when at ZV. (Bug#8487)
7354
e7974947
AS
73552011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7356
baad03f0
AS
7357 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7358 (Bug#8437)
7359 * keyboard.c (parse_tool_bar_item): Likewise.
7360 * sound.c (sound_cleanup, alsa_close): Likewise.
7361 * termcap.c (tgetent): Likewise.
7362 * xfns.c (x_default_font_parameter): Likewise.
7363 * xsettings.c (read_and_apply_settings): Likewise.
7364
e7974947
AS
7365 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7366 (overrun_check_free): Protoize.
7367
28272684
PE
73682011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7369
7370 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7371 since callers should never pass a negative size.
7372 Change the signature to match that of plain 'read' and 'write'; see
7373 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7374 * lisp.h: Update prototypes of emacs_write and emacs_read.
7375
11997c76
EZ
73762011-04-11 Eli Zaretskii <eliz@gnu.org>
7377
7378 * xdisp.c (redisplay_window): Don't try to determine the character
7379 position of the scroll margin if the window start point w->startp
e896f03c 7380 is outside the buffer's accessible region. (Bug#8468)
11997c76 7381
8a2cbd72
EZ
73822011-04-10 Eli Zaretskii <eliz@gnu.org>
7383
7384 Fix write-region and its subroutines for buffers > 2GB.
7385 * fileio.c (a_write, e_write): Modify declaration of arguments and
7386 local variables to support buffers larger than 2GB.
7387 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7388
7389 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7390 argument, local variables, and return value.
7391
7392 * lisp.h: Update prototypes of emacs_write and emacs_read.
7393
7394 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7395
4073e537 73962011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7397
1ebfdcb6
PE
7398 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7399
b2ded58d
PE
7400 Fix more problems found by GCC 4.6.0's static checks.
7401
7d66342c
PE
7402 * xdisp.c (vmessage): Use a better test for character truncation.
7403
bbf47d44
PE
7404 * charset.c (load_charset_map): <, not <=, for optimization,
7405 and to avoid potential problems with integer overflow.
9248994d 7406 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7407 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7408 * editfns.c (Fformat): Likewise.
1e69125e 7409 * syntax.c (skip_chars): Likewise.
3befa583 7410
e3019616
PE
7411 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7412 This also lets GCC 4.6.0 generate slightly better loop code.
7413
becfa255
PE
7414 * callint.c (Fcall_interactively): <, not <=, for optimization.
7415 (Fcall_interactively): Count the number of arguments produced,
7416 not the number of arguments given. This is simpler and lets GCC
7417 4.6.0 generate slightly better code.
7418
dae0cd48
PE
7419 * ftfont.c: Distingish more carefully between FcChar8 and char.
7420 The previous code passed unsigned char * to a functions like
7421 strlen and xstrcasecmp that expect char *, which does not
7422 conform to the C standard.
7423 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7424 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7425 char * when the C standard requires it.
7426
76032d70
PE
7427 * keyboard.c (read_char): Remove unused var.
7428
eb3f1cc8
PE
7429 * eval.c: Port to Windows vsnprintf (Bug#8435).
7430 Include <limits.h>.
7431 (SIZE_MAX): Define if the headers do not.
7432 (verror): Do not give up if vsnprintf returns a negative count.
7433 Instead, grow the buffer. This ports to Windows vsnprintf, which
7434 does not conform to C99. Problem reported by Eli Zaretskii.
7435 Also, simplify the allocation scheme, by avoiding the need for
7436 calling realloc, and removing the ALLOCATED variable.
7437
70476b54
PE
7438 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7439
12020a9e
PE
7440 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7441 But keep the doprint source code for now, as we might revamp it
7442 and use it again (Bug#8435).
ea6c7ae6
PE
7443 * lisp.h (doprnt): Remove.
7444 * Makefile.in (base_obj): Remove doprnt.o.
7445 * deps.mk (doprnt.o): Remove.
7446
5fdb398c
PE
7447 error: Print 32- and 64-bit integers portably (Bug#8435).
7448 Without this change, on typical 64-bit hosts error ("...%d...", N)
7449 was used to print both 32- and 64-bit integers N, which relied on
7450 undefined behavior.
7451 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7452 New macro.
7453 * lisp.h (error, verror): Mark as printf-like functions.
7454 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7455 Report overflow in size calculations when allocating printf buffer.
7456 Do not truncate output string at its first null byte.
7457 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7458 Truncate the output at a character boundary, since vsnprintf does not
7459 do that.
7460 * charset.c (check_iso_charset_parameter): Convert internal
7461 character to string before calling 'error', since %c now has the
7462 printf meaning.
7463 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7464 overflow when computing char to be passed to 'error'. Do not
7465 pass Lisp_Object to 'error'; pass the integer instead.
7466 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7467 formatted with plain %d.
7468
b189fa66
PE
7469 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7470
bff87ef0
PE
7471 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7472
7e2cac20
PE
7473 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7474
ce4d90b5
PE
7475 * xterm.c (x_catch_errors): Remove duplicate declaration.
7476
266c9547
PE
7477 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7478
79c49ad2
PE
7479 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7480
368f4090
JM
74812011-04-10 Jim Meyering <meyering@redhat.com>
7482
7483 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7484 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7485 return ssize_t not "int", and use size_t as the buffer length.
7486 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7487 * gnutls.h: Update declarations.
7488 * process.c (read_process_output): Use ssize_t, to match.
7489 (send_process): Likewise.
7490
a32d4040
CY
74912011-04-09 Chong Yidong <cyd@stupidchicken.com>
7492
7493 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7494
8546720e 74952011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7496
04f2d78b
CB
7497 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7498 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7499
8546720e
GM
7500 * xterm.c (handle_one_xevent):
7501 * xmenu.c (create_and_show_popup_menu):
7502 * xselect.c (x_decline_selection_request)
7503 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7504
0a2f5c1a 75052011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7506
7507 Fix some uses of `int' instead of EMACS_INT.
7508 * search.c (string_match_1, fast_string_match)
7509 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7510 (scan_buffer, find_next_newline_no_quit)
7511 (find_before_next_newline, search_command, Freplace_match)
7512 (Fmatch_data): Make some `int' variables be EMACS_INT.
7513
7514 * xdisp.c (display_count_lines): 3rd argument and return value now
7515 EMACS_INT. All callers changed.
7516 (pint2hrstr): Last argument is now EMACS_INT.
7517
7518 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7519 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7520 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7521 (decode_coding_utf_16, decode_coding_emacs_mule)
7522 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7523 (decode_coding_ccl, decode_coding_charset)
7524 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7525 (decode_coding_iso_2022, decode_coding_emacs_mule)
7526 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7527 <char_offset, last_offset>: Declare EMACS_INT.
7528 (encode_coding_utf_8, encode_coding_utf_16)
7529 (encode_coding_emacs_mule, encode_invocation_designation)
7530 (encode_designation_at_bol, encode_coding_iso_2022)
7531 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7532 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7533 Declare EMACS_INT.
7534 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7535 (encode_invocation_designation): Last argument P_NCHARS is now
7536 EMACS_INT.
7537 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7538 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7539
7540 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7541 All users changed.
7542
7543 * ccl.c (Fccl_execute_on_string): Declare some variables
7544 EMACS_INT.
7545
8546720e 75462011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7547
7548 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7549
4e19a977
CS
75502011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7551
7552 * process.c (Fformat_network_address): Doc fix.
7553
87302331
R
75542011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7555
ee7683eb 7556 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7557
cbb59342
CY
75582011-04-08 Chong Yidong <cyd@stupidchicken.com>
7559
7560 * keyboard.c (read_char): Call Lisp function help-form-show,
7561 instead of using internal_with_output_to_temp_buffer.
7562 (Qhelp_form_show): New var.
e0d38eeb 7563 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7564
7565 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7566
7567 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7568
e67a13ab
CY
75692011-04-06 Chong Yidong <cyd@stupidchicken.com>
7570
04f2d78b
CB
7571 * process.c (Flist_processes): Remove to Lisp.
7572 (list_processes_1): Delete.
e67a13ab 7573
973f782d
EZ
75742011-04-06 Eli Zaretskii <eliz@gnu.org>
7575
7c106b1e
EZ
7576 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7577
973f782d
EZ
7578 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7579
41cf7d1a 75802011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7581
ca23cc88
PE
7582 Fix more problems found by GCC 4.6.0's static checks.
7583
f390e2d5
PE
7584 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7585
42eea0d0
PE
7586 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7587
b69769da 7588 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7589
f9541e84
PE
7590 * xdisp.c (vmessage): Mark as a printf-like function.
7591
13841b55
PE
7592 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7593
c136c10f
PE
7594 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7595
5e2d4a30
PE
7596 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7597 printf-like functions.
7598 (tiff_load): Add casts to remove these marks before passing them
7599 to system-supplied API.
7600
583f48b9
PE
7601 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7602
b25d760e
PE
7603 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7604 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7605 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7606 directly, rather than having caller test rule sign. This avoids
7607 some unnecessary tests.
7608 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7609 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7610 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7611
bc7b6697 7612 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7613 (xfont_open): Avoid unnecessary tests.
bc7b6697 7614
27ccc379
PE
7615 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7616
dcd5c89a
PE
7617 * composite.h, composite.c (composition_gstring_put_cache):
7618 Use EMACS_INT, not int, for length.
7619
b13a45c6
PE
7620 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7621 breaking out part of COMPOSITION_DECODE_RULE.
7622 (COMPOSITION_DECODE_RULE): Use it.
7623 * composite.c (get_composition_id): Remove unused local vars,
7624 by using the new macro.
7625
1e792e4d
PE
7626 * textprop.c (set_text_properties_1): Change while to do-while,
7627 since the condition is always true at first.
7628
dc6c6455 7629 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7630 (interval_deletion_adjustment): Return unsigned value.
7631 All uses changed.
dc6c6455 7632
aba7731a
PE
7633 * process.c (list_processes_1, create_pty, read_process_output):
7634 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7635 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7636 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7637 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7638 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7639
fdfc4bf3
PE
7640 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7641
fca8fe46 7642 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7643 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7644
06a0259a 7645 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7646 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7647 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7648
e7b9e80f
PE
7649 * print.c (print_error_message): Avoid int overflow.
7650
56201685
PE
7651 * font.c (font_list_entities): Redo for clarity,
7652 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7653
78834453 7654 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7655 (font_score): Avoid potential overflow in diff calculation.
78834453 7656
0bc0b309 7657 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7658 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7659
e610eaca
PE
7660 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7661
b895abce
PE
7662 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7663 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7664 can always succeed if overflow has undefined behavior.
7665
1f1d9321 7666 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7667 (wordify): Omit three unnecessary tests.
1f1d9321 7668
c59478bc
PE
7669 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7670 All callers changed. This avoids the need for an unused var.
7671
79b73827
PE
7672 * casefiddle.c (casify_region): Remove var that is set but not used.
7673
a4db5dfe
PE
7674 * dired.c (file_name_completion): Remove var that is set but not used.
7675
43aae36e
PE
7676 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7677
2a47c44d 7678 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7679 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7680
a37c69bf
PE
7681 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7682 Check for integer overflow on size calculations.
7683
328ab8e7
PE
7684 * buffer.c (Fprevious_overlay_change): Remove var that is set
7685 but not used.
7686
e5a2a5cb
PE
7687 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7688 Remove vars that are set but not used.
8d84a6eb 7689 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7690 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7691
a60e5f68
PE
7692 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7693
f661cb61 7694 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7695 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7696
f0397f5a
PE
7697 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7698 that are set but not used.
7699
8664db06 7700 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7701 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7702
6abdaa4a
PE
7703 * xselect.c (x_get_local_selection, x_handle_property_notify):
7704 Remove vars that are set but not used.
7705
0ce7538d 7706 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7707 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7708
9ae848fc
PE
7709 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7710 Remove var that is set but not used.
0b918413
PE
7711 (scroll_bar_windows_size): Now size_t, not int.
7712 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7713 Check for overflow.
9ae848fc 7714
a5a62657
PE
7715 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7716 (map_tty_color) [!defined MSDOS]: Likewise.
7717
5c5cdd39
PE
7718 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7719
66ebf983
PE
7720 * coding.c: Remove vars that are set but not used.
7721 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7722 All callers changed.
7723 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7724 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7725 (decode_coding_charset): Remove vars that are set but not used.
7726
1be4d761
PE
7727 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7728 that is set but not used.
7729
47553fa8
PE
7730 * print.c (print_object): Remove var that is set but not used.
7731
1f7196bf 7732 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7733 The gnulib version avoids calling malloc in the usual case,
7734 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7735 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7736 * filelock.c (current_lock_owner): Likewise.
7737 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7738 * sysdep.c: Include allocator.h, careadlinkat.h.
7739 (emacs_no_realloc_allocator): New static constant.
7740 (emacs_readlink): New function.
fdb61804
PE
7741 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7742 ../lib/careadlinkat.h.
d1fdcab7 7743
f84c17c7
SM
77442011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7745
7746 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7747 first non-nil return value).
7748
ef3862ad
JD
77492011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7750
7751 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7752 if not defined (Bug#8403).
7753
376a7006
JB
77542011-04-02 Juanma Barranquero <lekktu@gmail.com>
7755
7756 * xdisp.c (display_count_lines): Remove parameter `start',
7757 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7758 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7759 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7760 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7761 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7762 and thereabouts. All callers changed.
7763 (get_per_char_metric): Remove parameter `f', unused since
7764 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7765
6ca3801d
JM
77662011-04-02 Jim Meyering <meyering@redhat.com>
7767
7768 do not dereference NULL upon failed strdup
7769 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7770 (ns_get_family): Likewise.
7771
d8e2b5ba
JB
77722011-04-02 Juanma Barranquero <lekktu@gmail.com>
7773
7774 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7775
8c74fcbd
JD
77762011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7777
7778 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7779 later (Bug#8403).
7780
7200d79c
SM
77812011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7782
03408648 7783 Add lexical binding.
7200d79c 7784
03408648
SM
7785 * window.c (Ftemp_output_buffer_show): New fun.
7786 (Fsave_window_excursion):
7787 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7788
7789 * lread.c (lisp_file_lexically_bound_p): New function.
7790 (Fload): Bind Qlexical_binding.
7791 (readevalloop): Remove `evalfun' arg.
7792 Bind Qinternal_interpreter_environment.
7793 (Feval_buffer): Bind Qlexical_binding.
7794 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7795 Mark as dynamic.
7796 (syms_of_lread): Declare `lexical-binding'.
7797
7798 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7799
7800 * keyboard.c (eval_dyn): New fun.
7801 (menu_item_eval_property): Use it.
ca105506
SM
7802
7803 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7804
03408648
SM
7805 * fns.c (concat, mapcar1): Accept byte-code-functions.
7806
7807 * eval.c (Fsetq): Handle lexical vars.
7808 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7809 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7810 (FletX, Flet): Obey lexical binding.
7811 (Fcommandp): Handle closures.
7812 (Feval): New `lexical' arg.
7813 (eval_sub): New function extracted from Feval. Use it almost
7814 everywhere where Feval was used. Look up vars in lexical env.
7815 Handle closures.
7816 (Ffunctionp): Move from subr.el.
7817 (Ffuncall): Handle closures.
7818 (apply_lambda): Remove `eval_flags'.
7819 (funcall_lambda): Handle closures and new byte-code-functions.
7820 (Fspecial_variable_p): New function.
7821 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7822 but without exporting it to Lisp.
23aba0ea 7823
23aba0ea 7824 * doc.c (Fdocumentation, store_function_docstring):
03408648 7825 * data.c (Finteractive_form): Handle closures.
23aba0ea 7826
03408648
SM
7827 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7828 interactive spec.
ba83908c 7829
04f2d78b
CB
7830 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7831 New byte-codes.
03408648
SM
7832 (exec_byte_code): New function extracted from Fbyte_code to handle new
7833 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7834
03408648 7835 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7836
03408648 7837 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7838
e2abce01
JB
78392011-03-31 Juanma Barranquero <lekktu@gmail.com>
7840
7841 * xdisp.c (redisplay_internal): Fix prototype.
7842
63696a73 78432011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7844
63696a73 7845 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7846 (try_scrolling): Use it when setting scroll_limit.
7847 Limit scrolling to 100 screen lines.
63696a73
EZ
7848 (redisplay_window): Even when falling back on "recentering",
7849 position point in the window according to scroll-conservatively,
7850 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7851
7852 (try_scrolling): When point is above the window, allow searching
7853 as far as scroll_max, or one screenful, to compute vertical
7854 distance from PT to the scroll margin position. This prevents
7855 try_scrolling from unnecessarily failing when
7856 scroll-conservatively is set to a value slightly larger than the
7857 window height. Clean up the case of PT below the margin at bottom
7858 of window: scroll_max can no longer be INT_MAX. When aggressive
7859 scrolling is in use, don't let point enter the opposite scroll
7860 margin as result of the scroll.
7861 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7862 threshold of 100 lines for never-recentering scrolling.
7863
e4cc2dfc
JB
78642011-03-31 Juanma Barranquero <lekktu@gmail.com>
7865
7866 * dispextern.h (move_it_by_lines):
7867 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7868 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7869 (message_log_check_duplicate): Remove parameters `prev_bol' and
7870 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7871 (redisplay_internal): Remove parameter `preserve_echo_area',
7872 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7873
7874 * indent.c (Fvertical_motion):
7875 * window.c (window_scroll_pixel_based, Frecenter):
7876 Don't pass `need_y_p' to `move_it_by_lines'.
7877
1c470562
SM
78782011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7879
44f230aa
SM
7880 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7881 steal a few bits to be more compact.
7882 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7883 Remove unneeded casts.
7884
1c470562
SM
7885 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7886
888adce9
ZK
78872011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7888
7889 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7890 binding" message (bug#7967).
7891
f838ed7b
PE
78922011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7893
77861b95
PE
7894 Fix more problems found by GCC 4.6.0's static checks.
7895
de6dbc14
PE
7896 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7897 Remove unused local var.
7898
f838ed7b
PE
7899 * editfns.c (Fmessage_box): Remove unused local var.
7900
792c7b2b
PE
7901 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7902 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7903 Omit unused local vars.
c499e557 7904 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7905 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7906 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7907 Omit unused local var.
7908
ba0165e1
PE
7909 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7910 Don't assume string length fits in int.
32ad8845 7911 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7912 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7913
3c59b4c9
PE
7914 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7915 instead of alloca (Bug#8344).
7916
a3eed478 7917 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7918 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7919
eb4d412d
PE
7920 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7921
1658b401
PE
7922 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7923 concerns.
7924
7925 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7926
7927 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7928
9a2c6e05
PE
7929 * keyboard.c (syms_of_keyboard): Use the same style as later
7930 in this function when indexing through an array. This also
7931 works around GCC bug 48267.
7932
03d0a109
PE
7933 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7934
44f730c8
PE
7935 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7936
fe75f926
PE
7937 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7938 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7939
ffa8c828
PE
7940 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7941 This avoids undefined behavior on integer overflow, and is a bit
7942 more convenient anyway since it is compared to a size_t variable.
7943
c5101a77
PE
7944 Variadic C functions now count arguments with size_t, not int.
7945 This avoids an unnecessary limitation on 64-bit machines, which
7946 caused (substring ...) to crash on large vectors (Bug#8344).
7947 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7948 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7949 All variadic functions and their callers changed accordingly.
c5101a77
PE
7950 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7951 * data.c (arith_driver, float_arith_driver): Likewise.
7952 * editfns.c (general_insert_function): Likewise.
7953 * eval.c (struct backtrace.nargs, interactive_p)
7954 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7955 (funcall_lambda, mark_backtrace): Likewise.
7956 * fns.c (concat): Likewise.
7957 * frame.c (x_set_frame_parameters): Likewise.
7958 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7959 0 if not found, not -1. All callers changed.
7960
dd3f25f7
PE
7961 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7962 (stack_copy_size): Now size_t, not int.
7963 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7964
461c2ab9
JB
79652011-03-28 Juanma Barranquero <lekktu@gmail.com>
7966
7967 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7968 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7969 All callers changed.
7970
7971 * lisp.h (multibyte_char_to_unibyte):
7972 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7973 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7974 * character.h (CHAR_TO_BYTE8):
7975 * cmds.c (internal_self_insert):
7976 * editfns.c (general_insert_function):
7977 * keymap.c (push_key_description):
7978 * search.c (Freplace_match):
7979 * xdisp.c (message_dolog, set_message_1): All callers changed.
7980
f6d62986
SM
79812011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7982
7983 * keyboard.c (safe_run_hook_funcall): New function.
7984 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7985 don't set the hook to nil, but remove the offending function instead.
7986 (Qcommand_hook_internal): Remove, unused.
7987 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7988 Vcommand_hook_internal.
7989
7990 * eval.c (enum run_hooks_condition): Remove.
7991 (funcall_nil, funcall_not): New functions.
7992 (run_hook_with_args): Call each function through a `funcall' argument.
7993 Remove `cond' argument, now redundant.
7994 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7995 (Frun_hook_with_args_until_failure): Adjust accordingly.
7996 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7997
1db5b1ad
JB
79982011-03-28 Juanma Barranquero <lekktu@gmail.com>
7999
8000 * dispextern.h (string_buffer_position): Remove declaration.
8001
8002 * print.c (strout): Remove parameter `multibyte', unused since
8003 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8004
8005 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8006 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8007 All callers changed.
8008
8009 * w32.c (_wsa_errlist): Use braces for struct initializers.
8010
8011 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8012 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8013 All callers changed.
8014 (string_buffer_position): Likewise. Also, make static (it's never
8015 used outside xdisp.c).
8016 (cursor_row_p): Remove parameter `w', unused since
8017 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8018 (decode_mode_spec): Remove parameter `precision', introduced during
8019 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8020 All callers changed.
8021
5ffb62aa
JD
80222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8023
8024 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8025
461c2ab9 80262011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8027
8028 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8029 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8030 (ns_update_auto_hide_menu_bar): New functions.
8031 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8032 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8033 ns_constrain_all_frames.
8034 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8035 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8036
5c380ffb
JD
80372011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8038
8039 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8040
9af30bdf
GM
80412011-03-27 Glenn Morris <rgm@gnu.org>
8042
8043 * syssignal.h: Replace RETSIGTYPE with void.
8044 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8045 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8046 Replace SIGTYPE with void everywhere.
8047 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8048 * s/template.h (SIGTYPE): Remove commented out definition.
8049
e2abce01
JB
80502011-03-26 Eli Zaretskii <eliz@gnu.org>
8051
8052 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8053 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8054
f868cd8a
JB
80552011-03-26 Juanma Barranquero <lekktu@gmail.com>
8056
59eb0929
JB
8057 * w32.c (read_unc_volume): Use parameter `henum', instead of
8058 global variable `wget_enum_handle'.
8059
8060 * keymap.c (describe_vector): Remove parameters `indices' and
8061 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8062 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8063
f868cd8a
JB
8064 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8065
8066 * keyboard.c (timer_check): Remove parameter `do_it_now',
8067 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8068 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8069 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8070
8071 * keyboard.c (read_char):
8072 * w32menu.c (w32_menu_display_help):
8073 * xmenu.c (show_help_event, menu_help_callback):
8074 Adjust calls to `show_help_echo'.
8075
8076 * gtkutil.c (xg_maybe_add_timer):
8077 * keyboard.c (readable_events):
8078 * process.c (wait_reading_process_output):
8079 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8080
8081 * insdel.c (adjust_markers_gap_motion):
8082 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8083 (gap_left, gap_right): Don't call it.
8084
2ecf6fdb
CY
80852011-03-25 Chong Yidong <cyd@stupidchicken.com>
8086
8087 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8088 incurred during fontification.
8089
6b1f9ba4
JB
80902011-03-25 Juanma Barranquero <lekktu@gmail.com>
8091
8092 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8093 (DEFVAR_PER_BUFFER): Don't pass it.
8094
8095 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8096 (scrolling_window): Don't pass it.
8097
0f4a96b5
JB
80982011-03-25 Juanma Barranquero <lekktu@gmail.com>
8099
8100 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8101
8102 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8103 and `suffix'.
8104 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8105 of variables specific to SELinux and computation of `encoded_absname'.
8106
8107 * image.c (XPutPixel): Remove unused variable `height'.
8108
8109 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8110
8111 * unexw32.c (get_section_info): Remove unused variable `section'.
8112
8113 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8114 (system_process_attributes): Remove unused variable `sess'.
8115 (sys_read): Remove unused variable `err'.
8116
8117 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8118 (w32_wnd_proc): Remove unused variable `isdead'.
8119 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8120 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8121 (x_create_tip_frame): Remove unused variable `tem'.
8122
8123 * w32inevt.c (w32_console_read_socket):
8124 Remove unused variable `no_events'.
8125
8126 * w32term.c (x_draw_composite_glyph_string_foreground):
8127 Remove unused variable `width'.
8128
1149507c
JB
81292011-03-24 Juanma Barranquero <lekktu@gmail.com>
8130
8131 * w32term.c (x_set_glyph_string_clipping):
8132 Don't pass uninitialized region to CombineRgn.
8133
9c88f339
JB
81342011-03-23 Juanma Barranquero <lekktu@gmail.com>
8135
8136 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8137 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8138 (Fx_close_connection): Remove unused variable `i'.
8139
8140 * w32font.c (w32font_draw): Return number of glyphs.
8141 (w32font_open_internal): Remove unused variable `i'.
8142 (w32font_driver): Add missing initializer.
8143
8144 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8145 (fill_in_menu): Remove unused variable `items_added'.
8146
8147 * w32term.c (last_mouse_press_frame): Remove static global variable.
8148 (w32_clip_to_row): Remove unused variable `f'.
8149 (x_delete_terminal): Remove unused variable `i'.
8150
8151 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8152 (NOTHING): Remove unused static global variable.
8153 (uniscribe_check_otf): Remove unused variable `table'.
8154 (uniscribe_font_driver): Add missing initializers.
8155
dee091a3
JD
81562011-03-23 Julien Danjou <julien@danjou.info>
8157
8158 * term.c (Fsuspend_tty, Fresume_tty):
8159 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8160 * window.c (temp_output_buffer_show):
8161 * insdel.c (signal_before_change):
8162 * frame.c (Fhandle_switch_frame):
8163 * fileio.c (Fdo_auto_save):
8164 * emacs.c (Fkill_emacs):
8165 * editfns.c (save_excursion_restore):
8166 * cmds.c (internal_self_insert):
8167 * callint.c (Fcall_interactively):
8168 * buffer.c (Fkill_all_local_variables):
8169 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8170 Use Frun_hooks.
0f4a96b5 8171 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8172 unconditionally since it does the check itself.
dee091a3 8173
2c520ab5 81742011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8175
c9c49752
PE
8176 Fix more problems found by GCC 4.5.2's static checks.
8177
8abc3f12
PE
8178 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8179 the first time through the loop, since we know p0 < p1 then.
8180 This also avoids a gcc -Wstrict-overflow warning.
8181
a2d26660
PE
8182 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8183 leading to a memory leak, possible in functions like
8184 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8185 of objects (Bug#8318).
a2d26660 8186
916c72e9
PE
8187 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8188 that could (at least in theory) be that large.
8189
19ab8a18
PE
8190 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8191 This is less likely to overflow, and avoids undefined behavior if
8192 overflow does occur. All callers changed. Use strtoul to scan
8193 for the unsigned long integer.
b7cbbd6f
PE
8194 (pint2hrstr): Simplify and tune code slightly.
8195 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8196
f0641eff
PE
8197 * scroll.c (do_scrolling): Work around GCC bug 48228.
8198 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8199
7f650bb9
PE
8200 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8201 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8202 (validate_x_resource_name): Simplify count usage.
8203 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8204
37dd57d1
PE
8205 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8206 fail (Bug#8306).
81e56e61 8207
699979fc 8208 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8209
401bf9b4
PE
8210 * process.c (Fmake_network_process): Use socklen_t, not int,
8211 where POSIX says socklen_t is required in portable programs.
8212 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8213 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8214 (Fmake_network_process, server_accept_connection):
8215 (wait_reading_process_output, read_process_output):
8216 Likewise.
8217
b93aacde
PE
8218 * process.c: Rename or move locals to avoid shadowing.
8219 (list_processes_1, Fmake_network_process):
8220 (read_process_output_error_handler, exec_sentinel_error_handler):
8221 Rename or move locals.
4dc343ee 8222 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8223 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8224 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8225 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8226 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8227
af8a867c 8228 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8229 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8230 Include tparam.h instead, since it declares them.
af8a867c
PE
8231 * cm.h (PC): Remove extern decl; tparam.h now does this.
8232 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8233 * terminfo.c: Include tparam.h, to check interfaces.
8234 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8235 (tparam): Adjust signature to match interface in tparam.h;
8236 this removes some undefined behavior. Check that outstring and len
8237 are zero, which they always are with Emacs.
8238 * tparam.h (PC, BC, UP): New extern decls.
8239
0248044d 8240 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8241 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8242
8ff096c1 8243 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8244 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8245 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8246 (ftfont_list): Remove unused local.
49eaafba
PE
8247 (get_adstyle_property, ftfont_pattern_entity):
8248 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8249 Rename locals to avoid shadowing.
8ff096c1 8250
e2be39f6
PE
8251 * xfont.c (xfont_list_family): Mark var as initialized.
8252
c9735e30
PE
8253 * xml.c (make_dom): Now static.
8254
8f5201ae
PE
8255 * composite.c (composition_compute_stop_pos): Rename local to
8256 avoid shadowing.
b246f932
PE
8257 (composition_reseat_it): Remove unused locals.
8258 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8259 (composition_update_it): Mark var as initialized.
11b61122
PE
8260 (find_automatic_composition): Mark vars as initialized,
8261 with a FIXME (Bug#8290).
8f5201ae 8262
760fbc2c
PE
8263 character.h: Rename locals to avoid shadowing.
8264 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8265 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8266 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8267 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8268 to avoid shadowing.
8269
ff08eb85
PE
8270 * textprop.c (property_change_between_p): Remove; unused.
8271
fc7bf025
PE
8272 * intervals.c (interval_start_pos): Now static.
8273
235d7abc
PE
8274 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8275
44f230aa
SM
8276 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8277 Rename locals to avoid shadowing.
3e7d6594 8278
50060332
PE
8279 * sound.c (wav_play, au_play, Fplay_sound_internal):
8280 Fix pointer signedness.
d01f234b 8281 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8282 (wav_play): Initialize a variable to 0, to prevent undefined
8283 behavior (Bug#8278).
50060332 8284
c4fc4e30
PE
8285 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8286
918436ed
PE
8287 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8288
c939f91b
PE
8289 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8290 clobbering (Bug#8298).
b9c7f648
PE
8291 * sysdep.c (sys_subshell): Likewise.
8292 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8293
6bd8c144
PE
8294 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8295 This should get cleaned up, so that child_setup has the
8296 same signature on all platforms.
8297
7710357c 8298 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8299 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8300
c59da222
CY
83012011-03-22 Chong Yidong <cyd@stupidchicken.com>
8302
8303 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8304 not to be necessary, and produces flickering.
8305
66b87493
GM
83062011-03-20 Glenn Morris <rgm@gnu.org>
8307
8308 * config.in: Remove file.
8309
45b6f6d5
JB
83102011-03-20 Juanma Barranquero <lekktu@gmail.com>
8311
8312 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8313 are now in src/globals.h.
8314 (syms_of_minibuf): Remove spurious & from previous change.
8315
3ec03f7e
LL
83162011-03-20 Leo <sdl.web@gmail.com>
8317
8318 * minibuf.c (completing-read-function): New variable.
8319 (completing-read-default): Rename from completing-read.
8320 (completing-read): Call completing-read-function.
8321
b14e3e21
CY
83222011-03-19 Juanma Barranquero <lekktu@gmail.com>
8323
8324 * xfaces.c (Fx_load_color_file):
8325 Read color file from absolute filename (bug#8250).
8326
f2b726e6
JB
83272011-03-19 Juanma Barranquero <lekktu@gmail.com>
8328
8329 * makefile.w32-in: Update dependencies.
8330
09f6ff02
EZ
83312011-03-17 Eli Zaretskii <eliz@gnu.org>
8332
8333 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8334
29a6015a
PE
83352011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8336
a3a6c54e
PE
8337 Fix more problems found by GCC 4.5.2's static checks.
8338
b766f867
PE
8339 * process.c (make_serial_process_unwind, send_process_trap):
8340 (sigchld_handler): Now static.
8341
be02381c
PE
8342 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8343 That way, the code declares only the vars that it needs.
8344 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8345 * s/cygwin.h (PTY_ITERATION): Likewise.
8346 * s/darwin.h (PTY_ITERATION): Likewise.
8347 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8348
57048744
PE
8349 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8350 * process.c (allocate_pty): Don't declare stb unless it's needed.
8351
7914961c 8352 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8353 (CONSTANTLIM): Remove; unused.
8354 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8355 Define only if needed.
7914961c 8356
b3967b18
PE
8357 * unexelf.c (unexec): Name an expression,
8358 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8359 Use a different way to cause a compilation error if anyone uses
8360 n rather than nn, a way that does not involve shadowing.
73366a00 8361 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8362
29a6015a
PE
8363 * deps.mk (unexalpha.o): Remove; unused.
8364
43cfc33e 8365 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8366 * unexec.h: New file.
ce701a33
PE
8367 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8368 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8369 Depend on unexec.h.
8370 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8371 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8372 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8373 Change as necessary to match prototype in unexec.h.
ce701a33 8374
01f44d5a
PE
8375 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8376 shadowing.
4f63c6bb 8377 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8378
a6670b0b
PE
8379 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8380 Rename locals to avoid shadowing.
8381
cef2010d 8382 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8383 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8384
d4d7173a
PE
8385 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8386
f08b802a
PE
8387 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8388 warning when compiling print.c.
8389
3ddb0639
PE
8390 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8391 instead of using an uninitialized var.
5ad03b97 8392 (font_sort_entities): Mark var as initialized.
3ddb0639 8393
170a2692
PE
8394 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8395
e663c700
PE
8396 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8397 pointers to constants.
89bc529a 8398 (font_parse_fcname): Remove unused vars.
7b81e2d0 8399 (font_delete_unmatched): Now static.
ea838e10 8400 (font_get_spec): Remove; unused.
13a547c6
PE
8401 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8402 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8403 Rename or move locals to avoid shadowing.
e663c700 8404
2a80c887 8405 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8406 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8407
1384fa33 8408 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8409 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8410
8b2c52e9
PE
8411 * alloc.c (mark_backtrace): Move decl from here ...
8412 * lisp.h: ... to here, so that it can be checked.
8413
475545b5 8414 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8415 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8416 (lisp_indirect_variable): Name an expression,
8417 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8418 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8419
b1349114 8420 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8421 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8422 Use const pointer when appropriate.
b1349114 8423
a2928364
PE
8424 * lisp.h (get_system_name, get_operating_system_release):
8425 Move decls here, to check interfaces.
8426 * process.c (get_operating_system_release): Move decl to lisp.h.
8427 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8428 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8429 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8430 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8431 (Fformat_time_string, Fencode_time, Finsert_char):
8432 (Ftranslate_region_internal, Fformat):
8433 Rename or remove local vars to avoid shadowing.
9710023e 8434 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8435
a415e694
PE
8436 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8437 avoid shadowing.
8438
8ef4622d
PE
8439 * lisp.h (eassert): Check that the argument compiles, even if
8440 ENABLE_CHECKING is not defined.
8441
946f9a5b
PE
8442 * data.c (Findirect_variable): Name an expression, to avoid
8443 gcc -Wbad-function-cast warning.
112396d6 8444 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8445 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8446 (Fmake_variable_buffer_local, Fmake_local_variable):
8447 Mark variables as initialized.
52746918 8448 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8449
e5aab7e7 8450 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8451 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8452 Rename locals to avoid shadowing.
dff45157
PE
8453 (mark_stack): Move local variables into the #ifdef region where
8454 they're used.
7bc26fdb
PE
8455 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8456 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8457 needed otherwise.
8458 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8459 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8460 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8461
e5aab7e7
PE
8462 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8463 avoids undefined behavior in theory.
8464
4da60324
PE
8465 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8466
88043301
PE
8467 Use functions, not macros, for up- and down-casing (Bug#8254).
8468 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8469 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8470 to use the following functions instead of these macros.
8471 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8472 EMACS_INT, since callers assume the returned value fits in int.
8473 (upcase1): Likewise, for UPCASE_TABLE.
8474 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8475 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8476 the race-condition problem in the old DOWNCASE.
88043301 8477
19ed5445
PE
8478 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8479 Rename locals to avoid shadowing.
8480 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8481 (regex_compile, re_search_2, re_match_2_internal):
8482 Remove unused local vars.
952db0d7
PE
8483 (FREE_VAR): Rewrite so as not to use empty "else",
8484 which gcc can warn about.
da053e48 8485 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8486 (RETALLOC_IF): Define only if needed.
8487 (WORDCHAR_P): Likewise. This one is never needed, but is used
8488 only in a comment talking about a compiler bug, so put inside
8489 the #if 0 of that comment.
8490 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8491 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8492 Remove; unused.
19ed5445 8493
1f3561e4 8494 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8495 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8496 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8497
ded6f8f7
PE
8498 * search.c (simple_search): Remove unused var.
8499
dbd37a95
PE
8500 * dired.c (compile_pattern): Move decl from here ...
8501 * lisp.h: ... to here, so that it can be checked.
8502 (struct re_registers): New forward decl.
8503
7e47afad
PE
8504 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8505
85f24f61
PE
8506 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8507 All uses changed.
8508 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8509 Rename locals to avoid shadowing.
5671df8f 8510 (Fvertical_motion): Mark locals as initialized.
85f24f61 8511
181aa2be 8512 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8513 (casify_region): Mark local as initialized.
181aa2be 8514
930d429c
PE
8515 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8516
7082eac6
PE
8517 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8518 New macros, so that the caller can use some names other than
8519 gcpro1, gcpro2, etc.
8520 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8521 of the new macros.
8522 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8523 argument, for consistency with GCPRO2_VAR, etc: it is now the
8524 prefix of the variable, not the variable itself. All uses
8525 changed.
38b2c076
PE
8526 * dired.c (directory_files_internal, file_name_completion):
8527 Rename locals to avoid shadowing.
8528
15206ed9
PE
8529 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8530 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8531 dired.c's scmp function, had undefined behavior.
8532 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8533 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8534 * buffer.h: ... to here, because these macros use current_buffer,
8535 and the new implementation with inline functions needs to have
8536 current_buffer in scope now, rather than later when the macros
8537 are used.
8538 (downcase, upcase1): New static inline functions.
8539 (DOWNCASE, UPCASE1): Reimplement using these functions.
8540 This avoids undefined behavior in expressions like
8541 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8542 from race conditions in accessing the global variables
8543 case_temp1 and case_temp2.
8544 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8545 * lisp.h (case_temp1, case_temp2): Remove their decls.
8546 * character.h (ASCII_CHAR_P): Move from here ...
8547 * lisp.h: ... to here, so that the inline functions mentioned
8548 above can use them.
8549
4a6bea26
PE
8550 * dired.c (directory_files_internal_unwind): Now static.
8551
f14b7e14
PE
8552 * fileio.c (file_name_as_directory, directory_file_name):
8553 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8554 Now static.
2893f146
PE
8555 (file_name_as_directory): Use const pointers when appropriate.
8556 (Fexpand_file_name): Likewise. In particular, newdir might
8557 point at constant storage, so make it a const pointer.
fd4ead52 8558 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8559 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8560 signedness issues.
f839df0c
PE
8561 (Fset_file_times, Finsert_file_contents, auto_save_error):
8562 Rename locals to avoid shadowing.
f14b7e14 8563
5716756e 8564 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8565 (Ftry_completion, Fall_completions): Rename or remove locals
8566 to avoid shadowing.
5716756e 8567
b4c3046a
PE
8568 * marker.c (bytepos_to_charpos): Remove; unused.
8569
b45db522
PE
8570 * lisp.h (verify_bytepos, count_markers): New decls,
8571 so that gcc does not warn that these functions aren't declared.
8572
85876d07
PE
8573 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8574 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8575 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8576 (copy_text): Remove unused local var.
85876d07 8577
03d78a21 8578 * filelock.c (within_one_second): Now static.
b3dd38ab 8579 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8580
5df8f01b
PE
8581 * buffer.c (fix_overlays_before): Mark locals as initialized.
8582 (fix_start_end_in_overlays): Likewise. This function should be
8583 simplified by using pointers-to-pointers, but that's a different
8584 matter.
b1d876f1 8585 (switch_to_buffer_1): Now static.
8f54f30a
PE
8586 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8587 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8588
a70072c9 8589 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8590 Fix pointer signedness issue.
edced198
PE
8591 (sys_subshell): Mark local as volatile if checking for lint,
8592 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8593 (MAXPATHLEN): Define only if needed.
a70072c9 8594
a0977c44
PE
8595 * process.c (serial_open, serial_configure): Move decls from here ...
8596 * systty.h: ... to here, so that they can be checked.
8597
a884fdcc
PE
8598 * fns.c (get_random, seed_random): Move extern decls from here ...
8599 * lisp.h: ... to here, so that they can be checked.
8600
604efe86 8601 * sysdep.c (reset_io): Now static.
b8950c94 8602 (wait_for_termination_signal): Remove; unused.
604efe86 8603
38fc62d9
PE
8604 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8605 (copy_keymap_item, append_key, push_text_char_description):
8606 Now static.
1004a21a 8607 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8608 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8609 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8610 (describe_map_tree):
8611 Rename locals to avoid shadowing.
38fc62d9 8612
2f2650da
PE
8613 * keyboard.c: Declare functions static if they are not used elsewhere.
8614 (echo_char, echo_dash, cmd_error, top_level_2):
8615 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8616 (read_char, kbd_buffer_get_event, make_lispy_position):
8617 (make_lispy_event, make_lispy_movement, apply_modifiers):
8618 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8619 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8620 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8621 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8622 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8623
a053e86c 8624 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8625 (mark_kboards): Move decl here ...
8626 * alloc.c (mark_kboards): ... from here.
a053e86c 8627
4752793e
PE
8628 * lisp.h (force_auto_save_soon): New decl.
8629
74f10ca7 8630 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8631 (DEFINE_DUMMY_FUNCTION): New macro.
8632 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8633 Use it.
c03cd23f
PE
8634 (main): Add casts to avoid warnings
8635 if GCC considers string literals to be constants.
74f10ca7 8636
022e70d4
PE
8637 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8638
59d6fe83
PE
8639 * dbusbind.c: Pointer signedness fixes.
8640 (xd_signature, xd_append_arg, xd_initialize):
8641 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8642 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8643 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8644 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8645
78320123
PE
8646 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8647 if GCC considers string literals to be constants.
49cebcca 8648 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8649
35ac2a97
SM
86502011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8651
fb103ca9
SM
8652 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8653 (print_preprocess, print_object): New macro to fix last change.
8654
35ac2a97
SM
8655 * print.c (print_preprocess): Don't forget font objects.
8656
62973b41
JB
86572011-03-16 Juanma Barranquero <lekktu@gmail.com>
8658
8659 * emacs.c (USAGE3): Doc fixes.
8660
0e48bb22
AS
86612011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8662
8663 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8664 structure.
8665
7684e57b
JB
86662011-03-14 Juanma Barranquero <lekktu@gmail.com>
8667
8668 * lisp.h (VWindow_system, Qfile_name_history):
8669 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8670 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8671 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8672
8673 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8674 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8675
8676 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8677 * w32console.c (detect_input_pending, read_input_pending)
8678 (encode_terminal_code):
8679 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8680 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8681 (w32_system_caret_y, Qfile_name_history):
8682 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8683 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8684 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8685 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8686 * w32proc.c (Qlocal, report_file_error):
8687 * w32term.c (Vwindow_system, updating_frame):
8688 * w32uniscribe.c (initialized, uniscribe_font_driver):
8689 Remove unneeded extern declarations.
8690
2aa46d6c
CY
86912011-03-14 Chong Yidong <cyd@stupidchicken.com>
8692
c96bbc66 8693 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8694
cffc6f3b
CY
86952011-03-13 Chong Yidong <cyd@stupidchicken.com>
8696
8697 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8698 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8699 These macros can no longer be used for assignment.
8700
44f230aa
SM
8701 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8702 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8703 (record_buffer_markers, fetch_buffer_markers): New functions for
8704 recording and fetching special buffer markers.
8705 (set_buffer_internal_1, set_buffer_temp): Use them.
8706
8707 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8708
8709 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8710
8711 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8712 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8713
8714 * xdisp.c (hscroll_window_tree):
8715 (reconsider_clip_changes): Use PT instead of BUF_PT.
8716
d251f04b
EZ
87172011-03-13 Eli Zaretskii <eliz@gnu.org>
8718
8719 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8720 $(EMACS_ROOT)/lib/intprops.h.
8721
f0c77cd1
PE
87222011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8723
3eca4629
PE
8724 Fix more problems found by GCC 4.5.2's static checks.
8725
7c86ee98
PE
8726 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8727 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8728 (xg_free_frame_widgets): Make it clear that a local variable is
8729 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8730 (gdk_window_get_screen): Make it clear that this macro is needed
8731 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8732 (int_gtk_range_get_value): New function, which avoids a diagnostic
8733 from gcc -Wbad-function-cast.
8734 (xg_set_toolkit_scroll_bar_thumb): Use it.
8735 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8736 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8737 (get_utf8_string, xg_get_file_with_chooser):
8738 Rename locals to avoid shadowing.
8739 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8740
41729b81
PE
8741 * xgselect.c (xg_select): Remove unused var.
8742
f0c77cd1
PE
8743 * image.c (four_corners_best): Mark locals as initialized.
8744 (gif_load): Initialize transparent_p to zero (Bug#8238).
8745 Mark another local as initialized.
ec6cf4c6 8746 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8747
ce0ad53d 8748 * image.c (clear_image_cache): Now static.
d5d5a617 8749 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8750 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8751 (x_edge_detection): Remove unnecessary cast that
8752 gcc -Wbad-function-cast diagnoses.
2037898d 8753 (gif_load): Fix pointer signedness.
6ae141d6
PE
8754 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8755 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8756
33383987 87572011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8758
d32df629
PE
8759 Improve quality of tests for time stamp overflow.
8760 For example, without this patch (encode-time 0 0 0 1 1
8761 1152921504606846976) returns the obviously-bogus value (-948597
8762 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8763 reports time overflow. See
8764 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8765 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8766 * editfns.c: Include limits.h and intprops.h.
8767 (TIME_T_MIN, TIME_T_MAX): New macros.
8768 (time_overflow): Move earlier, to before first use.
8769 (hi_time, lo_time): New functions, for an accurate test for
8770 out-of-range times.
8771 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8772 (Fget_internal_run_time): Don't assume time_t fits in int.
8773 (make_time): Use list2 instead of Fcons twice.
8774 (Fdecode_time): More accurate test for out-of-range times.
8775 (check_tm_member): New function.
8776 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8777 (lisp_time_argument): Don't rely on undefined left-shift and
8778 right-shift behavior when checking for time stamp overflow.
8be6f318 8779
fe31d94c
PE
8780 * editfns.c (time_overflow): New function, refactoring common code.
8781 (Fformat_time_string, Fdecode_time, Fencode_time):
8782 (Fcurrent_time_string): Use it.
8783
8be6f318
PE
8784 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8785 * dired.c (make_time): Move to ...
8786 * editfns.c (make_time): ... here.
8787 * systime.h: Note the move.
8788
09d9db2c 87892011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8790
126bc0dc
YM
8791 * fringe.c (update_window_fringes): Remove unused variables.
8792
c47cbdfd
YM
8793 * unexmacosx.c (copy_data_segment): Also copy __got section.
8794 (Bug#8223)
8795
7ac80be9
EZ
87962011-03-12 Eli Zaretskii <eliz@gnu.org>
8797
c96bbc66 8798 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8799 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8800 Constify `char *' arguments and their references according to
8801 prototypes in tparam.h.
8802
ecb0f94d 8803 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8804
7ac80be9
EZ
8805 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8806 Adapt all references accordingly.
8807
8808 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8809
ef1fd07e
TT
88102011-03-11 Tom Tromey <tromey@redhat.com>
8811
8812 * buffer.c (syms_of_buffer): Remove obsolete comment.
8813
7ef4b50c
EZ
88142011-03-11 Eli Zaretskii <eliz@gnu.org>
8815
8816 * termhooks.h (encode_terminal_code): Declare prototype.
8817
8818 * msdos.c (encode_terminal_code): Don't declare prototype.
8819
8820 * term.c (encode_terminal_code): Now external again, used by
8821 w32console.c and msdos.c.
8822
44f230aa
SM
8823 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8824 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8825
4b1ec863 88262011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8827
1714f52b 8828 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8829
4b1ec863
PE
8830 * fringe.c (update_window_fringes): Mark locals as initialized
8831 (Bug#8227).
8832 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8833
524c7aa6
PE
8834 * alloc.c (mark_fringe_data): Move decl from here ...
8835 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8836 to check its interface.
8837 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8838
a5c0af81 8839 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8840 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8841 (fontset_font): Mark local as initialized.
a9a06e0b 8842 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8843
b4716021
PE
8844 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8845
811e9bac 8846 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8847 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8848 (x_own_selection, Fx_disown_selection_internal): Rename locals
8849 to avoid shadowing.
8850 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8851
7e3ab302
PE
8852 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8853 so that the caller can use some name other than gcpro1.
8854 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8855 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8856 (Fx_backspace_delete_keys_p):
8857 Use them to avoid shadowing, and rename vars to avoid shadowing.
8858 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8859 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8860 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8861 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8862 Remove unused locals.
7e3ab302
PE
8863 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8864 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8865 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8866 macros.
f78faa98 8867
e2b13473
PE
8868 * xterm.h (x_mouse_leave): New decl.
8869
77f23912
PE
8870 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8871 Remove unused functions.
cdf4ba58
PE
8872 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8873 (x_calc_absolute_position): Now static.
7411c686 8874 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8875 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8876 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8877 unless they are used.
38d0b34a
PE
8878 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8879 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8880 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8881 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8882 (x_error_catcher, x_connection_closed, x_error_handler):
8883 (x_error_quitter, xembed_send_message, x_iconify_frame):
8884 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8885 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8886 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8887
44f230aa
SM
8888 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8889 Rename or move locals to avoid shadowing.
6b463e58 8890 (tty_defined_color, merge_face_heights): Now static.
5967d051 8891 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8892 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8893 does not deduce is never used uninitialized.
73719eba
PE
8894 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8895 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8896
426994c3 8897 * terminal.c (store_terminal_param): Now static.
5489860b 8898
032f1620 8899 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8900 (set_frame_menubar): Remove unused local.
d4323972 8901 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8902 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8903 since they might point to immutable storage.
281585b0
PE
8904 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8905 since it's unused otherwise.
032f1620 8906
367c19e5 8907 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8908 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8909 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8910 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8911 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8912 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8913 does not deduce are never used uninitialized.
70739cbe 8914
07b48fa9
PE
8915 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8916
8868a238 8917 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8918 * window.c (window_loop, size_window):
8919 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8920
7e5cf297 8921 * window.c (display_buffer): Now static.
d6550a9f
PE
8922 (size_window): Mark variables that gcc -Wuninitialized
8923 does not deduce are never used uninitialized.
a586633d
PE
8924 * window.h (check_all_windows): New decl, to forestall
8925 gcc -Wmissing-prototypes diagnostic.
5b555da1 8926 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8927
f6095868
PE
8928 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8929 shadowing.
8930 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8931 Include <limits.h>.
8932 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8933 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8934 (load_charset_map): Mark variables that gcc -Wuninitialized
8935 does not deduce are never used uninitialized.
53df7c11 8936 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8937
f38b440c
PE
8938 * coding.c (coding_set_source, coding_set_destination):
8939 Use "else { /* comment */ }" rather than "else /* comment */;"
8940 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8941 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8942 a block, when the outer 'i' will do.
8943 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8944 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8945 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8946 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8947 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8948 Rename locals to avoid shadowing.
8949 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8950 * coding.c (emacs_mule_char, encode_invocation_designation):
8951 Now static, since they're not used elsewhere.
413bb2db 8952 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8953 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8954 (decode_coding_emacs_mule): Mark variables that gcc
8955 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8956 (detect_coding_iso_2022): Initialize a local variable that might
8957 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8958 this initialization is needed. (Bug#8211)
5f58e762
PE
8959 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8960 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8961 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8962 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8963 Remove unused macros.
f38b440c 8964
232b38b9 8965 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8966 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8967 * character.c (string_count_byte8): Likewise.
232b38b9 8968
fb90da1b
PE
8969 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8970 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8971
fb93dbc2
PE
8972 * chartab.c (copy_sub_char_table): Now static, since it's not used
8973 elsewhere.
5c156ace
PE
8974 (sub_char_table_ref_and_range, char_table_ref_and_range):
8975 Rename locals to avoid shadowing.
bbcd0949 8976 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8977
7d3b3862 8978 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8979 (BIDI_BOB): Remove unused macro.
7d3b3862 8980
6be7d3da
PE
8981 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8982 deduce are never used uninitialized.
c2ed9c8b 8983 * term.c (encode_terminal_code): Likewise.
6be7d3da 8984
75f8807f 8985 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8986
50938595
PE
8987 * tparam.h: New file.
8988 * term.c, tparam.h: Include it.
8989 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8990 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8991 Move these decls to tparam.h, and make them agree with what
8992 is actually in tparam.c. The previous trick of using incompatible
8993 decls in different modules does not conform to the C standard.
8994 All callers of tparam changed to use tparam's actual API.
8995 * tparam.c (tparam1, tparam, tgoto):
8996 Use const pointers where appropriate.
8997
fbceeba2
PE
8998 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8999 * cm.h (struct cm): Likewise.
9000 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9001 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9002 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9003 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9004 (turn_on_face, init_tty): Likewise.
9005 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9006
7f3f1250
PE
9007 * term.c (term_mouse_position): Rename local to avoid shadowing.
9008
e6ca6543
PE
9009 * alloc.c (mark_ttys): Move decl from here ...
9010 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9011
c40f8d15
AS
90122011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9013
9014 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9015
cfe0661d
JB
90162011-03-09 Juanma Barranquero <lekktu@gmail.com>
9017
9018 * search.c (compile_pattern_1): Remove argument regp, unused since
9019 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9020 (compile_pattern): Don't pass it.
9021
0afb4571
J
90222011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9023
9024 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9025 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9026 for ! HAVE_GTK3.
9027 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9028
9029 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9030
9031 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9032 gdk_window_get_screen, gdk_window_get_geometry,
9033 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9034 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9035 (xg_get_pixbuf_from_pixmap): New function.
9036 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9037 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9038 Call xg_get_pixbuf_from_pixmap instead of
9039 gdk_pixbuf_get_from_drawable.
9040 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9041 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9042 (xg_check_special_colors): Use GtkStyleContext and its functions
9043 for HAVE_GTK3.
9044 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9045 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9046 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9047 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9048 Call gtk_widget_get_preferred_size.
0afb4571
J
9049 (xg_frame_resized): gdk_window_get_geometry only takes 5
9050 parameters.
44f230aa
SM
9051 (xg_win_to_widget, xg_event_is_for_menubar):
9052 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9053 (xg_set_widget_bg): New function.
9054 (delete_cb): New function.
895009e1 9055 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9056 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9057 (xg_set_background_color): Call xg_set_widget_bg.
9058 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9059 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9060 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9061 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9062 if ! HAVE_GTK3.
9063 (update_frame_tool_bar): Call gtk_widget_hide.
9064 (xg_initialize): Use GDK_KEY_g.
9065
9066 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9067 if ! HAVE_GTK3
9068 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9069
9070 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9071 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9072 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9073
1c2cc4ef
JB
90742011-03-08 Juanma Barranquero <lekktu@gmail.com>
9075
9076 * w32xfns.c (select_palette): Check success of RealizePalette against
9077 GDI_ERROR, not zero.
9078
33383987 9079See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9080
9081;; Local Variables:
9082;; coding: utf-8
aac0c6e3
MR
9083;; End:
9084
acaf905b 9085 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9086
9087 This file is part of GNU Emacs.
9088
9089 GNU Emacs is free software: you can redistribute it and/or modify
9090 it under the terms of the GNU General Public License as published by
9091 the Free Software Foundation, either version 3 of the License, or
9092 (at your option) any later version.
9093
9094 GNU Emacs is distributed in the hope that it will be useful,
9095 but WITHOUT ANY WARRANTY; without even the implied warranty of
9096 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9097 GNU General Public License for more details.
9098
9099 You should have received a copy of the GNU General Public License
9100 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.