* term.c: Don't include <stdarg.h>, as <lisp.h> does that.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
13c15c6d 12011-05-04 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2
e3601888
PE
3 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4
7fc4768c 5 Arithmetic overflows now return float rather than wrapping around.
59dba0f4 6 (Bug#8611).
7fc4768c
PE
7 * data.c: Include <intprops.h>.
8 (arith_driver): Use floating point if the accumulator would otherwise
9 go out of EMACS_INT range.
10 (arith_driver, Fadd1, Fsub1): Use floating point if the result is
11 out of Emacs fixnum range.
12 * bytecode.c (exec_byte_code): Likewise, for Bsub1, Badd1, Bnegate.
4ed0cebd 13 * floatfns.c (Fexpt): Likewise.
7fc4768c 14
db6c0e74
PE
15 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
16
dd5963ea
PE
17 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
18
88c9450f
PE
19 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
20
2f9442b8
PE
21 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
22
c032b5f8
PE
23 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
24 * charset.c (Fdefine_charset_internal): Don't initialize
25 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 26 32-bit int (Bug#8600).
a108c10b
PE
27
28 * lread.c (read_integer): Be more consistent with string-to-number.
29 Use string_to_number to do the actual conversion; this avoids
30 rounding errors and fixes some other screwups. Without this fix,
31 for example, #x1fffffffffffffff was misread as -2305843009213693952.
32 (digit_to_number): Move earlier, for benefit of read_integer.
33 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 34 not a digit in any supported base. (Bug#8602)
a108c10b 35
ad5f9eea
PE
36 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
37
aec1708a
PE
38 * dispnew.c (scrolling_window): Return 1 if we scrolled,
39 to match comment at start of function. This also removes a
40 GCC warning about overflow in a 32+64-bit port.
41
47be4ab5
PE
42 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
43
371cac43
PE
44 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
45 Reported by Stefan Monnier in
46 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
47 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
48 SYMBOLP-guarded XSYMBOL, not XPNTR.
49
d01a7826
PE
50 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
51 (EMACS_UINTPTR): Likewise, with uintptr_t.
52
7fd47d5c
PE
53 * lisp.h: Prefer 64-bit EMACS_INT if available.
54 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
55 on 32-bit hosts that have 64-bit int, so that they can access
56 large files.
57
8727937b
PE
58 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
59
8ac068ac
PE
60 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
61 This removes an assumption that EMACS_INT and long are the same
62 width as pointers. The assumption is true for Emacs porting targets
63 now, but we want to make other targets possible.
64 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
65 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
66 In the rest of the code, change types of integers that hold casted
67 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
68 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
69 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
70 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
71 No need to cast type when ORing.
72 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
73 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
74 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
75 assume EMACS_INT is the same width as char *.
76 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
77 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
78 Remove no-longer-needed casts.
79 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
80 (xg_tool_bar_help_callback, xg_make_tool_item):
81 Use EMACS_INTPTR to hold an integer
82 that will be cast to void *; this can avoid a GCC warning
83 if EMACS_INT is not the same width as void *.
84 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
85 * xdisp.c (display_echo_area_1, resize_mini_window_1):
86 (current_message_1, set_message_1):
87 Use a local to convert to proper width without a cast.
88 * xmenu.c (dialog_selection_callback): Likewise.
89
ede49d71
PE
90 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
91 Also, don't assume VALBITS / RAND_BITS is less than 5,
92 and don't rely on undefined behavior when shifting a 1 left into
93 the sign bit.
94 * lisp.h (get_random): Change signature to match.
95
2f30ecd0
PE
96 * lread.c (hash_string): Use size_t, not int, for hash computation.
97 Normally we prefer signed values; but hashing is special, because
98 it's better to use unsigned division on hash table sizes so that
99 the remainder is nonnegative. Also, size_t is the natural width
100 for hashing into memory. The previous code used 'int', which doesn't
101 retain enough info to hash well into very large tables.
102 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
103
2a866e7b
PE
104 * dbusbind.c: Don't possibly lose pointer info when converting.
105 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
106 Use XPNTR rather than XHASH, so that the high-order bits of
107 the pointer aren't lost when converting through void *.
108
51639eac
PE
109 * eval.c (Fautoload): Don't double-shift a pointer.
110
92394119
PE
111 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
112
ff4de4aa
TZ
1132011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
114
115 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
116 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
117 as passed in.
118
abe95abb
JD
1192011-05-03 Jan Djärv <jan.h.d@swipnet.se>
120
121 * xterm.c (x_set_frame_alpha): Do not set property on anything
122 else than FRAME_X_OUTER_WINDOW (Bug#8608).
123
e16e55d4
JB
1242011-05-02 Juanma Barranquero <lekktu@gmail.com>
125
126 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
127
bafcf6a5
JB
1282011-05-02 Juanma Barranquero <lekktu@gmail.com>
129
130 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
131 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
132 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
133 (gnutls_global_initialized, Qgnutls_bootprop_priority)
134 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
135 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
136 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
137 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
138 (Qgnutls_bootprop_callbacks_verify): Make static.
139
e7a6747f
AS
1402011-05-01 Andreas Schwab <schwab@linux-m68k.org>
141
19ed11ba
AS
142 * callproc.c: Indentation fixup.
143
e7a6747f
AS
144 * sysdep.c (wait_for_termination_1): Make static.
145 (wait_for_termination, interruptible_wait_for_termination): Move
146 after wait_for_termination_1.
147
1ef14cb4
LMI
1482011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
149
150 * sysdep.c (interruptible_wait_for_termination): New function
151 which is like wait_for_termination, but allows keyboard
152 interruptions.
153
154 * callproc.c (Fcall_process): Add (:file "file") as an option for
155 the STDOUT buffer.
156 (Fcall_process_region): Ditto.
157
330d880c
EZ
1582011-04-30 Eli Zaretskii <eliz@gnu.org>
159
8db90b73
EZ
160 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
161 rather than `XVECTOR (FOO)->size'.
162
330d880c
EZ
163 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
164 inttypes.h, as a gnulib replacement is used if it not available in
165 system headers.
166
15cbd324
EZ
1672011-04-21 Eli Zaretskii <eliz@gnu.org>
168
169 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
170 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
171 of MOST_POSITIVE_FIXNUM. (Bug#8528)
172
173 * coding.c (coding_alloc_by_realloc): Error out if destination
174 will grow beyond MOST_POSITIVE_FIXNUM.
175 (decode_coding_emacs_mule): Abort if there isn't enough place in
176 charbuf for the composition carryover bytes. Reserve an extra
177 space for up to 2 characters produced in a loop.
178 (decode_coding_iso_2022): Abort if there isn't enough place in
179 charbuf for the composition carryover bytes.
180
1812011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 182
ae940cca
EZ
183 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
184 aborting when %lld or %lll format is passed.
185 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
186 %llo or %llx format is passed. (Bug#8545)
187
03ab8921
EZ
188 * window.c (window_scroll_line_based): Use a marker instead of
189 simple variables to record original value of point. (Bug#7952)
190
afda1437
EZ
191 * doprnt.c (doprnt): Fix the case where a multibyte sequence
192 produced by %s or %c overflows available buffer space. (Bug#8545)
193
f76dee0c
PE
1942011-04-28 Paul Eggert <eggert@cs.ucla.edu>
195
196 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 197 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 198
fdc5744d
JB
1992011-04-28 Juanma Barranquero <lekktu@gmail.com>
200
201 * w32.c (init_environment): Warn about defaulting HOME to C:\.
202
638f053a
JB
2032011-04-28 Juanma Barranquero <lekktu@gmail.com>
204
205 * keyboard.c (Qdelayed_warnings_hook): Define.
206 (command_loop_1): Run `delayed-warnings-hook'
207 if Vdelayed_warnings_list is non-nil.
208 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
209 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
210
d178f871
EZ
2112011-04-28 Eli Zaretskii <eliz@gnu.org>
212
213 * doprnt.c (doprnt): Don't return value smaller than the buffer
214 size if the message was truncated. (Bug#8545).
215
b124fd93
JB
2162011-04-28 Juanma Barranquero <lekktu@gmail.com>
217
218 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
219 (Fx_window_property): #if-0 the whole functions, not just the bodies.
220
e810457d
PE
2212011-04-27 Paul Eggert <eggert@cs.ucla.edu>
222
223 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
224
ea51cceb
JB
2252011-04-27 Juanma Barranquero <lekktu@gmail.com>
226
227 * makefile.w32-in: Update dependencies.
228
94dcfacf
EZ
2292011-04-27 Eli Zaretskii <eliz@gnu.org>
230
231 Improve `doprnt' and its usage. (Bug#8545)
232 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
233 `format_end'. Remove support for %l as a conversion specifier.
234 Don't use xrealloc. Improve diagnostics when the %l size modifier
235 is used. Update the commentary.
236
237 * eval.c (verror): Simplify calculation of size_t.
238
239 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
240 messages.
241
f61f41d7
PE
2422011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
243
244 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
245 change.
246
96fb4434
PE
2472011-04-27 Paul Eggert <eggert@cs.ucla.edu>
248
249 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
250 This makes this file independent of the recent pseudovector change.
251
671875da 2522011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 253
69e9b5a3
PE
254 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
255
b5f869a7 256 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 257 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 258 Remove unused local.
c8926152 259 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 260
841a1577 261 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
262 GCC 4.6.0 optimizes based on type-based alias analysis. For
263 example, if b is of type struct buffer * and v of type struct
264 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
265 != &v->size, and therefore "v->size = 1; b->size = 2; return
266 v->size;" must therefore return 1. This assumption is incorrect
267 for Emacs, since it type-puns struct Lisp_Vector * with many other
268 types. To fix this problem, this patch adds a new type struct
f904488f 269 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
270 and pseudovectors, and helps optimizing compilers not get fooled
271 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
272 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
273 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
274 the size member.
eab3844f
PE
275 (XSETPVECTYPE): Rewrite in terms of new macro.
276 (XSETPVECTYPESIZE): New macro, specifying both type and size.
277 This is a bit clearer, and further avoids the possibility of
278 undesirable aliasing.
279 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 280 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
281 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
282 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
283 (ASIZE): Now uses header.size rather than size. All
284 previous uses of XVECTOR (foo)->size replaced to use this macro,
285 to avoid the hassle of writing XVECTOR (foo)->header.size.
286 (struct vectorlike_header): New type.
eab3844f
PE
287 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
288 object, to help avoid aliasing.
289 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
290 (SUBRP): Likewise, since Lisp_Subr is a special case.
291 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
292 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
293 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 294 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
295 changed to be "header.size" and "header.next".
296 * buffer.h (struct buffer): Likewise.
297 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
298 * frame.h (struct frame): Likewise.
299 * process.h (struct Lisp_Process): Likewise.
300 * termhooks.h (struct terminal): Likewise.
301 * window.c (struct save_window_data, struct saved_window): Likewise.
302 * window.h (struct window): Likewise.
303 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
304 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
305 * buffer.c (init_buffer_once): Likewise.
306 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
307 special case.
308 * process.c (Fformat_network_address): Use local var for size,
309 for brevity.
310
0df1eac5
PE
311 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
312
847ab9d1 313 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
314 * data.c (atof): Remove decl; no longer used or needed.
315 (digit_to_number): Move to lread.c.
316 (Fstring_to_number): Use new string_to_number function, to be
317 consistent with how the Lisp reader treats infinities and NaNs.
318 Do not assume that floating-point numbers represent EMACS_INT
319 without losing information; this is not true on most 64-bit hosts.
320 Avoid double-rounding errors, by insisting on integers when
321 parsing non-base-10 numbers, as the documentation specifies.
322 * lisp.h (string_to_number): New decl, replacing ...
323 (isfloat_string): Remove.
bc0a5c13 324 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 325 (read1): Do not accept +. and -. as integers; this
452f4150
PE
326 appears to have been a coding error. Similarly, do not accept
327 strings like +-1e0 as floating point numbers. Do not report
328 overflow for integer overflows unless the base is not 10 which
329 means we have no simple and reliable way to continue.
330 Break out the floating-point parsing into a new
331 function string_to_number, so that Fstring_to_number parses
332 floating point numbers consistently with the Lisp reader.
333 (digit_to_number): Moved here from data.c. Make it static inline.
334 (E_CHAR, EXP_INT): Remove, replacing with ...
335 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
336 (string_to_number): New function, replacing isfloat_string.
337 This function checks for valid syntax and produces the resulting
338 Lisp float number too. Rework it so that string-to-number
bc0a5c13 339 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
340 so that overflow for non-base-10 numbers is reported only when
341 there's no portable and simple way to convert to floating point.
452f4150 342
67769ffc
PE
343 * textprop.c (set_text_properties_1): Rewrite for clarity,
344 and to avoid GCC warning about integer overflow.
345
c20db43f
PE
346 * intervals.h (struct interval): Use EMACS_INT for members
347 where EMACS_UINT might cause problems. See
348 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
349 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
350 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
351 All uses changed.
37aa2f85
PE
352 (offset_intervals): Tell GCC not to worry about length overflow
353 when negating a negative length.
c20db43f 354
2538aa2f
PE
355 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
356 (overrun_check_free): Likewise.
357
f2d3008d
PE
358 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
359 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
360 word size.
361
ec8df744
PE
362 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
363 (gnutls_make_error): Rename local to avoid shadowing.
364 (gnutls_emacs_global_deinit): ifdef out; not used.
365 (Fgnutls_boot): Use const for pointer to readonly storage.
366 Comment out unused local. Fix pointer signedness problems.
367
640ee02d
PE
368 * lread.c (openp): Don't stuff size_t into an 'int'.
369 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
370 about possible signed overflow.
371
6048fb2a
PE
372 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
373 (GDK_KEY_g): Don't define if already defined.
374 (xg_prepare_tooltip): Avoid pointer signedness problem.
375 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
376
fa3c87e1
PE
377 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
378 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
379
2172544b
PE
380 * xfns.c (Fx_window_property): Simplify a bit,
381 to make a bit faster and to avoid GCC 4.6.0 warning.
382 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
383
9b821a21
PE
384 * fns.c (internal_equal): Don't assume size_t fits in int.
385
3c616cfa
PE
386 * alloc.c (compact_small_strings): Tighten assertion a little.
387
c2982e87
PE
388 Replace pEd with more-general pI, and fix some printf arg casts.
389 * lisp.h (pI): New macro, generalizing old pEd macro to other
390 conversion specifiers. For example, use "...%"pI"d..." rather
391 than "...%"pEd"...".
392 (pEd): Remove. All uses replaced with similar uses of pI.
393 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
394 * alloc.c (check_pure_size): Don't overflow by converting size to int.
395 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
396 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
397 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
398 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
399 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
400 64-bit hosts.
401 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
402 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
403 * print.c (safe_debug_print, print_object): Likewise.
404 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
405 to int.
6f04d126
PE
406 Use pI instead of if-then-else-abort. Use %p to avoid casts,
407 avoiding the 0 flag, which is not portable.
c2982e87
PE
408 * process.c (Fmake_network_process): Use pI to avoid cast.
409 * region-cache.c (pp_cache): Likewise.
410 * xdisp.c (decode_mode_spec): Likewise.
411 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
412 behavior on 64-bit hosts with printf arg.
6f04d126 413 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
414 (x_stop_queuing_selection_requests): Likewise.
415 (x_get_window_property): Don't truncate byte count to an 'int'
416 when tracing.
0b432f21 417
5e073ec7
PE
418 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
419 here, since it parses constructs like leading '-' and spaces,
420 which are not wanted; and it overflows with large numbers.
421 Instead, simply match F[0-9]+, which is what is wanted anyway.
422
36372bf9
PE
423 * alloc.c: Remove unportable assumptions about struct layout.
424 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
425 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
426 (allocate_vectorlike, make_pure_vector): Use the new macros,
427 plus offsetof, to remove unportable assumptions about struct layout.
428 These assumptions hold on all porting targets that I know of, but
429 they are not guaranteed, they're easy to remove, and removing them
430 makes further changes easier.
431
0b432f21
PE
432 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
433 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
434 (string_overrun_cookie): Now const. Use initializers that
435 don't formally overflow signed char, to avoid warnings.
000098c1
PE
436 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
437 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
438 (allocate_buffer): Don't assume sizeof (struct buffer) is a
439 multiple of sizeof (EMACS_INT); it need not be, if
440 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 441 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 442
895009e1
JB
4432011-04-26 Juanma Barranquero <lekktu@gmail.com>
444
445 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
446
6a7a1b0b
TZ
4472011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
448
449 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 450 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
451 Reported by Paul Eggert <eggert@cs.ucla.edu>.
452
841a1577 4532011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
454
455 * lisp.h (Qdebug): List symbol.
895009e1 456 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
457 * keyboard.c (debug-on-event): New variable.
458 (handle_user_signal): Break into debugger when debug-on-event
459 matches the current signal symbol.
460
f2d3ba6f
DN
4612011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
462
463 * alloc.c (check_sblock, check_string_bytes)
464 (check_string_free_list): Convert to standard C.
465
42ce4c63
TZ
4662011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
467
468 * w32.c (emacs_gnutls_push): Fix typo.
469
825cd63c
EZ
4702011-04-25 Eli Zaretskii <eliz@gnu.org>
471
fb11d64d
EZ
472 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
473 "cast to pointer from integer of different size".
474
825cd63c
EZ
475 Improve doprnt and its use in verror. (Bug#8545)
476 * doprnt.c (doprnt): Document the set of format control sequences
477 supported by the function. Use SAFE_ALLOCA instead of always
478 using `alloca'.
479
480 * eval.c (verror): Don't limit the buffer size at size_max-1, that
481 is one byte too soon. Don't use xrealloc; instead xfree and
482 xmalloc anew.
483
e061a11b
TZ
4842011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
485
486 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
487 callbacks stage.
488
489 * gnutls.c: Renamed global_initialized to
490 gnutls_global_initialized. Added internals for the
491 :verify-hostname-error, :verify-error, and :verify-flags
492 parameters of `gnutls-boot' and documented those parameters in the
493 docstring. Start callback support.
494 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
495 unless a fatal error occured. Call gnutls_alert_send_appropriate
496 on error. Return error code.
497 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
498 (emacs_gnutls_read): Likewise.
499 (Fgnutls_boot): Return handshake error code.
500 (emacs_gnutls_handle_error): New function.
501 (wsaerror_to_errno): Likewise.
502
503 * w32.h (emacs_gnutls_pull): Add prototype.
504 (emacs_gnutls_push): Likewise.
505
506 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
507 (emacs_gnutls_push): Likewise.
508
5092011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
510
511 * process.c (wait_reading_process_output): Check if GnuTLS
512 buffered some data internally if no FDs are set for TLS
513 connections.
514
515 * makefile.w32-in (OBJ2): Add gnutls.$(O).
516 (LIBS): Link to USER_LIBS.
517 ($(BLD)/gnutls.$(0)): New target.
518
fa6996bc
EZ
5192011-04-24 Eli Zaretskii <eliz@gnu.org>
520
eb35682e
EZ
521 * xdisp.c (handle_single_display_spec): Rename the
522 display_replaced_before_p argument into display_replaced_p, to
523 make it consistent with the commentary. Fix typos in the
524 commentary.
525
e2ad650c
EZ
526 * textprop.c (syms_of_textprop): Remove dead code.
527 (copy_text_properties): Delete obsolete commentary about an
528 interface that was deleted long ago. Fix typos in the description
529 of arguments.
530
1b2de274
EZ
531 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
532 to changes in oldXMenu/XMenu.h from 2011-04-16.
533 <menu_help_message, prev_menu_help_message>: Constify.
534 (IT_menu_make_room): menu->help_text is now `const char **';
535 adjust.
536
537 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
538 to changes in oldXMenu/XMenu.h from 2011-04-16.
539 (struct XMenu): Declare `help_text' `const char **'.
540
541 * xfaces.c <Qunspecified>: Make extern again.
542
543 * syntax.c: Include sys/types.h before including regex.h, as
544 required by Posix.
545
762b15be
EZ
546 * doc.c (get_doc_string): Improve the format passed to `error'.
547
548 * doprnt.c (doprnt): Improve commentary.
549
550 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
551
552 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
553 them with etags.
554
f1052e5d
EZ
555 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
556 changes in globals.h immediately force recompilation.
762b15be
EZ
557 (TAGS): Depend on $(CURDIR)/m/intel386.h and
558 $(CURDIR)/s/ms-w32.h.
559 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 560
fa6996bc
EZ
561 * character.c (Fchar_direction): Function deleted.
562 (syms_of_character): Don't defsubr it.
563 <char-direction-table>: Deleted.
564
e6c3da20
EZ
5652011-04-23 Eli Zaretskii <eliz@gnu.org>
566
567 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
568 * doprnt.c: Include limits.h.
569 (SIZE_MAX): New macro.
570 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
571 local variables are now size_t instead of int or unsigned.
572 Improve overflow protection. Support `l' modifier for integer
573 conversions. Support %l conversion. Don't assume an EMACS_INT
574 argument for integer conversions and for %c.
575
576 * lisp.h (doprnt): Restore prototype.
577
578 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
579 $(SRC)/character.h.
580
581 * Makefile.in (base_obj): Add back doprnt.o.
582
583 * deps.mk (doprnt.o): Add back prerequisites.
584 (callint.o): Depend on character.h.
585
586 * eval.c (internal_lisp_condition_case): Include the handler
587 representation in the error message.
588 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
589 when breaking from the loop.
590
591 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
592
593 * callint.c (Fcall_interactively): When displaying error message
594 about invalid control letter, pass the character's codepoint, not
595 a pointer to its multibyte form. Improve display of the character
596 in octal and display also its hex code.
597
598 * character.c (char_string): Use %x to display the (unsigned)
599 codepoint of an invalid character, to avoid displaying a bogus
600 negative value.
601
602 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
603 `error', not SYMBOL_NAME itself.
604
605 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
606 character arguments to `error'.
607
608 * charset.c (check_iso_charset_parameter): Fix incorrect argument
609 to `error' in error message about FINAL_CHAR argument. Make sure
610 FINAL_CHAR is a character, and use %c when it is passed as
611 argument to `error'.
612
4ffd0d6b 6132011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
614
615 * s/ms-w32.h (localtime): Redirect to sys_localtime.
616
617 * w32.c: Include <time.h>.
618 (sys_localtime): New function.
619
4ffd0d6b 6202011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
621
622 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
623
4ffd0d6b 624 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 625
4ffd0d6b 6262011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 627
4ffd0d6b
GM
628 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
629 zombies (Bug#8467).
aac0c6e3 630
04c56954
EZ
6312011-04-19 Eli Zaretskii <eliz@gnu.org>
632
633 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
634 gl_state.e_property when gl_state.object is Qt.
635
636 * insdel.c (make_gap_larger): Remove limitation of buffer size
637 to <= INT_MAX.
638
16a43933
CY
6392011-04-18 Chong Yidong <cyd@stupidchicken.com>
640
641 * xdisp.c (lookup_glyphless_char_display)
642 (produce_glyphless_glyph): Handle cons cell entry in
643 glyphless-char-display.
644 (Vglyphless_char_display): Document it.
645
646 * term.c (produce_glyphless_glyph): Handle cons cell entry in
647 glyphless-char-display.
648
4581706e
CY
6492011-04-17 Chong Yidong <cyd@stupidchicken.com>
650
651 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
652
653 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
654
655 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
656 definition for no-X builds.
657
4887c6e2 6582011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 659
fd35b6f9
PE
660 Static checks with GCC 4.6.0 and non-default toolkits.
661
5c1ccb01
PE
662 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
663
006c5daa
PE
664 * process.c (keyboard_bit_set): Define only if SIGIO.
665 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
666 (send_process): Repair possible setjmp clobbering.
667
efc736d3
PE
668 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
669
4e2fe2e6
PE
670 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
671
f97334a2
PE
672 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
673
4e75f29d
PE
674 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
675 Define only if needed.
676
90efadd1
PE
677 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
678 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 679 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 680
3c647824
PE
681 * dispextern.h (struct redisplay_interface): Rename param
682 to avoid shadowing.
e264f262 683 * termhooks.h (struct terminal): Likewise.
761383f4 684 * xterm.c (xembed_send_message): Likewise.
3c647824 685
b58c5c4a
PE
686 * insdel.c (make_gap_smaller): Define only if
687 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
688
cad59032
PE
689 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
690 it.
691
c339dc2e
PE
692 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
693 so that we aren't warned about unused symbols.
694
91a3e27b
PE
695 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
696
399c71d3 697 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 698
8ffc96f5
PE
699 * xfns.c (x_real_positions): Mark locals as initialized.
700
eef9bc79
PE
701 * xmenu.c (xmenu_show): Don't use uninitialized vars.
702
098db9dd
PE
703 * xterm.c: Fix problems found by static analysis with other toolkits.
704 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
705 (x_dispatch_event): Declare static if USE_GTK, and
706 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 707 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 708 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
709 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
710 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 711
eb18f6cc
PE
712 * xmenu.c (menu_help_callback): Pointer type fixes.
713 Use const pointers when pointing at readonly data. Avoid pointer
714 signedness clashes.
715 (FALSE): Remove unused macro.
716 (update_frame_menubar): Remove unused decl.
717
1fe72bf8
PE
718 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
719
60d9e1db
PE
720 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
721 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
722 (single_menu_item): Rename local to avoid shadowing.
723
39261c26
PE
724 * keyboard.c (make_lispy_event): Remove unused local var.
725
018c5e19
PE
726 * frame.c, frame.h (x_get_resource_string): Bring this back, but
727 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
728
63d2b86e
PE
729 * bitmaps: Change bitmaps from unsigned char back to the X11
730 compatible char. Avoid the old compiler warnings about
731 out-of-range initializers by using, for example, '\xab' rather
732 than 0xab.
733
aefd87e1
PE
734 * xgselect.c (xgselect_initialize): Check vs interface
735 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
736
bf501fb9
PE
737 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
738
e9829fdf
PE
739 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
740 to read-only memory.
741
1086c095
PE
742 * fns.c (vector): Remove; this old hack is no longer needed.
743
2baccd04 744 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 745 Remove unused var.
dde42981 746 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 747
72391843 748 * xrdb.c (x_load_resources): Omit unused local.
3565b346 749
436c16df 750 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 751 (x_window): Rename locals to avoid shadowing.
dc5ddd85 752 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 753
92bb796d 754 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 755 (x_term_init): Remove local to avoid shadowing.
92bb796d 756
764430a3 757 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
758
759 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
760 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
761
d1dfb56c
EZ
7622011-04-16 Eli Zaretskii <eliz@gnu.org>
763
c4354cb4
EZ
764 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
765
d1dfb56c
EZ
766 Fix regex.c, syntax.c and friends for buffers > 2GB.
767 * syntax.h (struct gl_state_s): Declare character position members
768 EMACS_INT.
769
770 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
771
772 * textprop.c (verify_interval_modification, interval_of): Declare
773 arguments EMACS_INT.
774
775 * intervals.c (adjust_intervals_for_insertion): Declare arguments
776 EMACS_INT.
777
778 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
779
780 * indent.c (Fvertical_motion): Local variable it_start is now
781 EMACS_INT.
782
783 * regex.c (re_match, re_match_2, re_match_2_internal)
784 (bcmp_translate, regcomp, regexec, print_double_string)
785 (group_in_compile_stack, re_search, re_search_2, regex_compile)
786 (re_compile_pattern, re_exec): Declare arguments and local
787 variables `size_t' and `ssize_t' and return values `regoff_t', as
788 appropriate.
789 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
790 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
791 <compile_stack_type>: `size' and `avail' are now `size_t'.
792
793 * regex.h <regoff_t>: Use ssize_t, not int.
794 (re_search, re_search_2, re_match, re_match_2): Arguments that
795 specify buffer/string position and length are now ssize_t and
796 size_t. Return type is regoff_t.
797
613052cd
BK
7982011-04-16 Ben Key <bkey76@gmail.com>
799
800 * nsfont.m: Fixed bugs in ns_get_family and
801 ns_descriptor_to_entity that were caused by using free to
802 deallocate memory blocks that were allocated by xmalloc (via
803 xstrdup). This caused Emacs to crash when compiled with
804 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
805 --enable-checking=xmallocoverrun). xfree is now used to
806 deallocate these memory blocks.
807
4170f62f 8082011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 809
71b41406
PE
810 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
811
9587a89d
PE
812 emacs_write: Accept and return EMACS_INT for sizes.
813 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
814 et seq.
815 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
816 Accept and return EMACS_INT.
817 (emacs_gnutls_write): Return the number of bytes written on
818 partial writes.
819 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
820 (emacs_read, emacs_write): Remove check for negative size, as the
821 Emacs source code has been audited now.
9587a89d
PE
822 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
823 (emacs_read, emacs_write): Use it.
273a5f82
PE
824 * process.c (send_process): Adjust to the new signatures of
825 emacs_write and emacs_gnutls_write. Do not attempt to store
826 a byte offset into an 'int'; it might overflow.
9587a89d 827 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 828
3e047f51
PE
829 * sound.c: Don't assume sizes fit in 'int'.
830 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 831 Return EMACS_INT, not int.
3e047f51 832 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
833 Accept EMACS_INT, not int.
834 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
835 record read return values.
836
cc39a9db
BK
8372011-04-15 Ben Key <bkey76@gmail.com>
838
c9d0ec6d
JB
839 * keyboard.c (Qundefined): Don't declare static since it is used
840 in nsfns.m.
841 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
842 static since they are used in nsfont.m.
cc39a9db 843
6c60eb9f
SM
8442011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
845
846 * process.c (Qprocessp): Don't declare static.
847 * lisp.h (Qprocessp): Declare again.
848
7990b61a
JB
8492011-04-15 Juanma Barranquero <lekktu@gmail.com>
850
851 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
852
5d4cb038
PE
8532011-04-14 Paul Eggert <eggert@cs.ucla.edu>
854
8bd7b830 855 Improve C-level modularity by making more things 'static'.
cd64ea1d 856
e3b27b31
PE
857 Don't publish debugger-only interfaces to other modules.
858 * lisp.h (safe_debug_print, debug_output_compilation_hack):
859 (verify_bytepos, count_markers): Move decls to the only modules
860 that need them.
861 * region-cache.h (pp_cache): Likewise.
862 * window.h (check_all_windows): Likewise.
863 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
864
5d4cb038
PE
865 * sysdep.c (croak): Now static, if
866 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
867 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
868
869 * alloc.c (refill_memory_reserve): Now static if
870 !defined REL_ALLOC || defined SYSTEM_MALLOC.
871 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 872
e87b6180
PE
873 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
874 Define only if USE_LUCID.
875
ac64929e
PE
876 * xrdb.c (x_customization_string, x_rm_string): Now static.
877
6f37259d
PE
878 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
879 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
880
1683e3ab
PE
881 * xdisp.c (draw_row_with_mouse_face): Now static.
882 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
883
de9c2632
PE
884 * window.h (check_all_windows): Mark externally visible.
885
2b96acb7
PE
886 * window.c (window_deletion_count): Now static.
887
888 * undo.c: Make symbols static if they're not exported.
889 (last_undo_buffer, last_boundary_position, pending_boundary):
890 Now static.
891
50436f33
PE
892 * textprop.c (interval_insert_behind_hooks): Now static.
893 (interval_insert_in_front_hooks): Likewise.
894
64520e5c
PE
895 * term.c: Make symbols static if they're not exported.
896 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
897 (max_frame_lines, tty_set_terminal_modes):
898 (tty_reset_terminal_modes, tty_turn_off_highlight):
899 (get_tty_terminal): Now static.
900 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
901 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 902 HAVE_WINDOW_SYSTEM.
64520e5c
PE
903 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
904 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
905
1fa53021
PE
906 * sysdep.c: Make symbols static if they're not exported.
907 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
908 Now static.
909 (sigprocmask_set, full_mask): Remove; unused.
910 (wait_debugging): Mark as visible.
911 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
912 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
913
d4b43b22
PE
914 * syntax.c (syntax_temp): Define only if !__GNUC__.
915
b7c513d0
PE
916 * sound.c (current_sound_device, current_sound): Now static.
917
989b29ad
PE
918 * search.c (searchbufs, searchbuf_head): Now static.
919
13a55a78
PE
920 * scroll.c (scroll_cost): Remove; unused.
921 * dispextern.h (scroll_cost): Remove decl.
922
de68a1fc
PE
923 * region-cache.h (pp_cache): Mark as externally visible.
924
40ccffa6
PE
925 * process.c: Make symbols static if they're not exported.
926 (process_tick, update_tick, create_process, chan_process):
927 (Vprocess_alist, proc_buffered_char, datagram_access):
928 (fd_callback_data, send_process_frame, process_sent_to): Now static.
929 (deactivate_process): Mark defn as static, as well as decl.
930 * lisp.h (create_process): Remove decl.
931 * process.h (chan_process, Vprocess_alist): Remove decls.
932
ad64fc97
PE
933 * print.c: Make symbols static if they're not exported.
934 (print_depth, new_backquote_output, being_printed, print_buffer):
935 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
936 (print_interval, print_number_index, initial_stderr_stream):
937 Now static.
938 * lisp.h (Fprinc): Remove decl.
939 (debug_output_compilation_hack): Mark as externally visible.
940
adddb265
PE
941 * sysdep.c (croak): Move decl from here to syssignal.h.
942 * syssignal.h (croak): Put it here, so the API can be checked when
943 'croak' is called from dissociate_if_controlling_tty.
944
1717ede2
PE
945 * minibuf.c: Make symbols static if they're not exported.
946 (minibuf_save_list, choose_minibuf_frame): Now static.
947 * lisp.h (choose_minibuf_frame): Remove decl.
948
fa5fb2bc
PE
949 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
950
1e3890d1
PE
951 * lread.c: Make symbols static if they're not exported.
952 (read_objects, initial_obarray, oblookup_last_bucket_number):
953 Now static.
954 (make_symbol): Remove; unused.
955 * lisp.h (initial_obarray, make_symbol): Remove decls.
956
8a1414fa
PE
957 * keyboard.c: Make symbols static if they're not exported.
958 (single_kboard, recent_keys_index, total_keys, recent_keys):
959 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
960 (this_single_command_key_start, echoing, last_auto_save):
961 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
962 (command_loop, echo_now, keyboard_init_hook, help_char_p):
963 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
964 (Vlispy_mouse_stem, double_click_count):
965 Now static.
966 (force_auto_save_soon): Define only if SIGDANGER.
967 (ignore_mouse_drag_p): Now static if
968 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
969 (print_help): Remove; unused.
970 (stop_character, last_timer_event): Mark as externally visible.
971 * keyboard.h (ignore_mouse_drag_p): Declare only if
972 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
973 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
974 * lisp.h (echoing): Remove decl.
975 (force_auto_save_soon): Declare only if SIGDANGER.
976 * xdisp.c (redisplay_window): Simplify code, to make it more
977 obvious that ignore_mouse_drag_p is not accessed if !defined
978 USE_GTK && !defined HAVE_NS.
979
93ea6e8f
PE
980 * intervals.c: Make symbols static if they're not exported.
981 (merge_properties_sticky, merge_interval_right, delete_interval):
982 Now static.
983 * intervals.h (merge_interval_right, delete_interval): Remove decls.
984
77382fcc
PE
985 * insdel.c: Make symbols static if they're not exported.
986 However, leave prepare_to_modify_buffer alone. It's never
987 called from outside this function, but that appears to be a bug.
988 (combine_after_change_list, combine_after_change_buffer):
4889fc82 989 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
990 (adjust_after_replace_noundo): Remove; unused.
991 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 992 (signal_before_change): Remove decls.
77382fcc 993
9306c32e
PE
994 * indent.c (val_compute_motion, val_vmotion): Now static.
995
cd44d2eb
PE
996 * image.c: Make symbols static if they're not exported.
997 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
998 if USE_GTK.
999 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1000 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1001
ad9a7a06
PE
1002 * fringe.c (standard_bitmaps): Now static.
1003 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1004
81626931
PE
1005 * frame.c: Make symbols static if they're not exported.
1006 (x_report_frame_params, make_terminal_frame): Now static.
1007 (get_frame_param): Now static, unless HAVE_NS.
1008 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1009 (x_get_resource_string): Remove; not used.
1010 * frame.h (make_terminal_frame, x_report_frame_params):
1011 (x_get_resource_string); Remove decls.
1012 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1013 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1014
239f9db9
PE
1015 * font.c, fontset.c: Make symbols static if they're not exported.
1016 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1017 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1018 * font.c (font_close_object): Now static.
1019 * font.h (font_close_object): Remove.
1020 * fontset.c (FONTSET_OBJLIST): Remove.
1021 (free_realized_fontset) #if-0 the body, which does nothing.
1022 (face_suitable_for_char_p): #if-0, as it's never called.
1023 * fontset.h (face_suitable_for_char_p): Remove decl.
1024 * xfaces.c (face_at_string_position): Use
1025 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1026 since 0 is always ASCII.
1027
dfcf3579
PE
1028 * fns.c (weak_hash_tables): Now static.
1029
5045092b
PE
1030 * fileio.c: Make symbols static if they're not exported.
1031 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1032 (Vwrite_region_annotation_buffers): Now static.
1033
57a96f5c
PE
1034 * eval.c: Make symbols static if they're not exported.
1035 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1036 * lisp.h (backtrace_list): Remove decl.
1037
35f08c38
PE
1038 * emacs.c: Make symbols static if they're not exported.
1039 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1040 (fatal_error_code, fatal_error_signal_hook, standard_args):
1041 Now static.
1042 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1043 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1044 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1045 * lisp.h (fatal_error_signal_hook): Remove decl.
1046 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1047
f44bd759
PE
1048 * editfns.c: Move a (normally-unused) function to its only use.
1049 * editfns.c, lisp.h (get_operating_system_release): Remove.
1050 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1051 worth the hassle of breaking this out.
1052
b532497d
PE
1053 * xterm.c: Make symbols static if they're not exported.
1054 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1055 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1056 (x_destroy_window, x_delete_display):
1057 Now static.
1058 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1059 (x_mouse_leave): Remove; unused.
1060 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1061 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1062 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1063 Remove decls.
1064 (x_mouse_leave): Declare only if WINDOWSNT.
1065 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1066 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1067 USE_X_TOOLKIT.
1068
1675728f
PE
1069 * ftxfont.c: Make symbols static if they're not exported.
1070 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1071 HAVE_FREETYPE.
1072 * font.h (ftxfont_driver): Likewise.
1073
e4cebfca
PE
1074 * xfns.c: Make symbols static if they're not exported.
1075 (x_last_font_name, x_display_info_for_name):
1076 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1077 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1078 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1079 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1080 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1081 (last_show_tip_args): Now static.
1082 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1083 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1084 (x_screen_planes): Remove; unused.
1085 * dispextern.h (x_screen_planes): Remove decl.
1086
5bf46f05
PE
1087 * dispnew.c: Make symbols static if they're not exported.
1088 * dispextern.h (redraw_garbaged_frames, scrolling):
1089 (increment_row_positions): Remove.
1090 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1091 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1092 Now static.
1093 (redraw_garbaged_frames): Remove; unused.
1094
435f4c28
PE
1095 * xfaces.c: Make symbols static if they're not exported.
1096 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1097 Remove decls.
1098 * xterm.h (defined_color): Remove decls.
1099 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1100 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1101 (menu_face_changed_default, defined_color, free_realized_face):
1102 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1103 (ascii_face_of_lisp_face): Remove; unused.
1104
8524aef3
PE
1105 * xdisp.c: Make symbols static if they're not exported.
1106 * dispextern.h (scratch_glyph_row, window_box_edges):
1107 (glyph_to_pixel_coords, set_cursor_from_row):
1108 (get_next_display_element, set_iterator_to_next):
1109 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1110 (show_mouse_face): Remove decls
1111 * frame.h (message_buf_print): Likewise.
1112 * lisp.h (pop_message, set_message, check_point_in_composition):
1113 Likewise.
1114 * xterm.h (set_vertical_scroll_bar): Likewise.
1115 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1116 (message_buf_print, scratch_glyph_row, displayed_buffer):
1117 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1118 (get_next_display_element, show_mouse_face, window_box_edges):
1119 (frame_to_window_pixel_xy, check_point_in_composition):
1120 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1121 (glyph_to_pixel_coords): Remove; unused.
1122
16390cd2
PE
1123 * dired.c (file_name_completion): Now static.
1124
1125 * dbusbind.c (xd_in_read_queued_messages): Now static.
1126
a25f4dfa
PE
1127 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1128 * data.c (circular_list_error): Remove.
1129
14a9c8df
PE
1130 * commands.h (last_point_position, last_point_position_buffer):
1131 (last_point_position_window): Remove decls.
1132 * keyboard.c: Make these variables static.
1133
74ab6df5
PE
1134 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1135 decls.
1136 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1137 (iso_code_class, detect_coding, code_convert_region): Now static.
1138 (encode_coding_gap): Remove; unused.
1139
38dfbee1
PE
1140 * chartab.c (chartab_chars, chartab_bits): Now static.
1141
a2cb4e63
PE
1142 * charset.h (charset_iso_8859_1): Remove decl.
1143 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1144 Now static.
1145
127198fd
PE
1146 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1147 * ccl.c (Vccl_program_table): Now static.
1148 (check_ccl_update): Remove; unused.
1149
d85b608f
PE
1150 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1151 * category.h: ... from here.
1152 * category.c (check_category_table, set_category_set): Now static.
1153
31cd66f3
PE
1154 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1155 * lisp.h: Remove these decls.
1156
c358e587
PE
1157 * buffer.c (buffer_count): Remove unused var.
1158
e78aecca
PE
1159 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1160 so that it's not optimized away.
1161 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1162 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1163 exported only to the debugger.
1164
e192d7d3
PE
1165 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1166 * atimer.h (run_all_atimers): Removed; not exported.
1167
92470028
PE
1168 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1169 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1170 was inaccessible from Lisp.
1171 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1172 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1173
244ed907
PE
1174 alloc.c: Import and export fewer symbols, and remove unused items.
1175 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1176 is defined.
1177 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1178 it's not optimized away by whole-program optimization.
1179 (message_enable_multibyte, free_misc): Remove.
1180 (catchlist, handlerlist, mark_backtrace):
1181 Declare only if BYTE_MARK_STACK.
1182 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1183 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1184 (message_enable_multibyte): Remove decl.
1185 (free_misc, interval_free_list, float_block, float_block_index):
1186 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1187 (cons_free_list, last_marked_index):
1188 Now static.
1189 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1190 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1191 (mark_backtrace): Define only if BYTE_MARK_STACK.
1192 * xdisp.c (message_enable_multibyte): Now static.
1193
61c2b50e 1194 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1195 This makes it easier for human readers (and static analyzers)
1196 to see whether these variables are used from other modules.
1197 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1198 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1199 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1200 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1201 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1202 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1203 * xmenu.c, xselect.c:
1204 Declare Q* vars static if they are not used in other modules.
1205 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1206 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1207 Remove decls of unexported vars.
1208 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1209
95c82688
PE
1210 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1211
16a97296
PE
1212 Make Emacs functions such as Fatom 'static' by default.
1213 This makes it easier for human readers (and static analyzers)
1214 to see whether these functions can be called from other modules.
1215 DEFUN now defines a static function. To make the function external
1216 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1217 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1218 (Finit_image_library):
16a97296
PE
1219 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1220 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1221 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1222 Remove decls, since these functions are now static.
1223 (Funintern, Fget_internal_run_time): New decls, since these functions
1224 were already external.
95c82688 1225
16a97296
PE
1226 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1227 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1228 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1229 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1230 * keyboard.c, keymap.c, lread.c:
1231 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1232 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1233 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1234 Mark functions with DEFUE instead of DEFUN,
1235 if they are used in other modules.
1236 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1237 decls for now-static functions.
1238 * buffer.h (Fdelete_overlay): Remove decl.
1239 * callproc.c (Fgetenv_internal): Mark as internal.
1240 * composite.c (Fremove_list_of_text_properties): Remove decl.
1241 (Fcomposition_get_gstring): New forward static decl.
1242 * composite.h (Fcomposite_get_gstring): Remove decl.
1243 * dired.c (Ffile_attributes): New forward static decl.
1244 * doc.c (Fdocumntation_property): New forward static decl.
1245 * eval.c (Ffetch_bytecode): New forward static decl.
1246 (Funintern): Remove extern decl; now in .h file where it belongs.
1247 * fileio.c (Fmake_symbolic_link): New forward static decl.
1248 * image.c (Finit_image_library): New forward static decl.
1249 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1250 * intervals.h (Fprevious_property_change):
1251 (Fremove_list_of_text_properties): Remove decls.
1252 * keyboard.c (Fthis_command_keys): Remove decl.
1253 (Fcommand_execute): New forward static decl.
1254 * keymap.c (Flookup_key): New forward static decl.
1255 (Fcopy_keymap): Now static.
1256 * keymap.h (Flookup_key): Remove decl.
1257 * process.c (Fget_process): New forward static decl.
1258 (Fprocess_datagram_address): Mark as internal.
1259 * syntax.c (Fsyntax_table_p): New forward static decl.
1260 (skip_chars): Remove duplicate decl.
1261 * textprop.c (Fprevious_property_change): New forward static decl.
1262 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1263 Now internal.
1264 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1265 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1266
785bbd42
PE
1267 * editfns.c (Fformat): Remove unreachable code.
1268
8b913b57
AS
12692011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1270
1271 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1272 change. (Bug#8496)
1273
a6744a35
EZ
12742011-04-13 Eli Zaretskii <eliz@gnu.org>
1275
1276 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1277 when at ZV. (Bug#8487)
1278
e7974947
AS
12792011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1280
baad03f0
AS
1281 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1282 (Bug#8437)
1283 * keyboard.c (parse_tool_bar_item): Likewise.
1284 * sound.c (sound_cleanup, alsa_close): Likewise.
1285 * termcap.c (tgetent): Likewise.
1286 * xfns.c (x_default_font_parameter): Likewise.
1287 * xsettings.c (read_and_apply_settings): Likewise.
1288
e7974947
AS
1289 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1290 (overrun_check_free): Protoize.
1291
28272684
PE
12922011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1295 since callers should never pass a negative size.
1296 Change the signature to match that of plain 'read' and 'write'; see
1297 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1298 * lisp.h: Update prototypes of emacs_write and emacs_read.
1299
11997c76
EZ
13002011-04-11 Eli Zaretskii <eliz@gnu.org>
1301
1302 * xdisp.c (redisplay_window): Don't try to determine the character
1303 position of the scroll margin if the window start point w->startp
e896f03c 1304 is outside the buffer's accessible region. (Bug#8468)
11997c76 1305
8a2cbd72
EZ
13062011-04-10 Eli Zaretskii <eliz@gnu.org>
1307
1308 Fix write-region and its subroutines for buffers > 2GB.
1309 * fileio.c (a_write, e_write): Modify declaration of arguments and
1310 local variables to support buffers larger than 2GB.
1311 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1312
1313 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1314 argument, local variables, and return value.
1315
1316 * lisp.h: Update prototypes of emacs_write and emacs_read.
1317
1318 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1319
4073e537 13202011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1321
1ebfdcb6
PE
1322 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1323
b2ded58d
PE
1324 Fix more problems found by GCC 4.6.0's static checks.
1325
7d66342c
PE
1326 * xdisp.c (vmessage): Use a better test for character truncation.
1327
bbf47d44
PE
1328 * charset.c (load_charset_map): <, not <=, for optimization,
1329 and to avoid potential problems with integer overflow.
9248994d 1330 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1331 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1332 * editfns.c (Fformat): Likewise.
1e69125e 1333 * syntax.c (skip_chars): Likewise.
3befa583 1334
e3019616
PE
1335 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1336 This also lets GCC 4.6.0 generate slightly better loop code.
1337
becfa255
PE
1338 * callint.c (Fcall_interactively): <, not <=, for optimization.
1339 (Fcall_interactively): Count the number of arguments produced,
1340 not the number of arguments given. This is simpler and lets GCC
1341 4.6.0 generate slightly better code.
1342
dae0cd48
PE
1343 * ftfont.c: Distingish more carefully between FcChar8 and char.
1344 The previous code passed unsigned char * to a functions like
1345 strlen and xstrcasecmp that expect char *, which does not
1346 conform to the C standard.
1347 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1348 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1349 char * when the C standard requires it.
1350
76032d70
PE
1351 * keyboard.c (read_char): Remove unused var.
1352
eb3f1cc8
PE
1353 * eval.c: Port to Windows vsnprintf (Bug#8435).
1354 Include <limits.h>.
1355 (SIZE_MAX): Define if the headers do not.
1356 (verror): Do not give up if vsnprintf returns a negative count.
1357 Instead, grow the buffer. This ports to Windows vsnprintf, which
1358 does not conform to C99. Problem reported by Eli Zaretskii.
1359 Also, simplify the allocation scheme, by avoiding the need for
1360 calling realloc, and removing the ALLOCATED variable.
1361
70476b54
PE
1362 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1363
12020a9e
PE
1364 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1365 But keep the doprint source code for now, as we might revamp it
1366 and use it again (Bug#8435).
ea6c7ae6
PE
1367 * lisp.h (doprnt): Remove.
1368 * Makefile.in (base_obj): Remove doprnt.o.
1369 * deps.mk (doprnt.o): Remove.
1370
5fdb398c
PE
1371 error: Print 32- and 64-bit integers portably (Bug#8435).
1372 Without this change, on typical 64-bit hosts error ("...%d...", N)
1373 was used to print both 32- and 64-bit integers N, which relied on
1374 undefined behavior.
1375 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1376 New macro.
1377 * lisp.h (error, verror): Mark as printf-like functions.
1378 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1379 Report overflow in size calculations when allocating printf buffer.
1380 Do not truncate output string at its first null byte.
1381 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1382 Truncate the output at a character boundary, since vsnprintf does not
1383 do that.
1384 * charset.c (check_iso_charset_parameter): Convert internal
1385 character to string before calling 'error', since %c now has the
1386 printf meaning.
1387 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1388 overflow when computing char to be passed to 'error'. Do not
1389 pass Lisp_Object to 'error'; pass the integer instead.
1390 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1391 formatted with plain %d.
1392
b189fa66
PE
1393 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1394
bff87ef0
PE
1395 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1396
7e2cac20
PE
1397 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1398
ce4d90b5
PE
1399 * xterm.c (x_catch_errors): Remove duplicate declaration.
1400
266c9547
PE
1401 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1402
79c49ad2
PE
1403 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1404
368f4090
JM
14052011-04-10 Jim Meyering <meyering@redhat.com>
1406
1407 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1408 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1409 return ssize_t not "int", and use size_t as the buffer length.
1410 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1411 * gnutls.h: Update declarations.
1412 * process.c (read_process_output): Use ssize_t, to match.
1413 (send_process): Likewise.
1414
a32d4040
CY
14152011-04-09 Chong Yidong <cyd@stupidchicken.com>
1416
1417 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1418
8546720e 14192011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1420
8546720e
GM
1421 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1422 unsigned char, to match FcChar8 type definition.
aac0c6e3 1423
8546720e
GM
1424 * xterm.c (handle_one_xevent):
1425 * xmenu.c (create_and_show_popup_menu):
1426 * xselect.c (x_decline_selection_request)
1427 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1428
0a2f5c1a 14292011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1430
1431 Fix some uses of `int' instead of EMACS_INT.
1432 * search.c (string_match_1, fast_string_match)
1433 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1434 (scan_buffer, find_next_newline_no_quit)
1435 (find_before_next_newline, search_command, Freplace_match)
1436 (Fmatch_data): Make some `int' variables be EMACS_INT.
1437
1438 * xdisp.c (display_count_lines): 3rd argument and return value now
1439 EMACS_INT. All callers changed.
1440 (pint2hrstr): Last argument is now EMACS_INT.
1441
1442 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1443 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1444 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1445 (decode_coding_utf_16, decode_coding_emacs_mule)
1446 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1447 (decode_coding_ccl, decode_coding_charset)
1448 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1449 (decode_coding_iso_2022, decode_coding_emacs_mule)
1450 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1451 <char_offset, last_offset>: Declare EMACS_INT.
1452 (encode_coding_utf_8, encode_coding_utf_16)
1453 (encode_coding_emacs_mule, encode_invocation_designation)
1454 (encode_designation_at_bol, encode_coding_iso_2022)
1455 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1456 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1457 Declare EMACS_INT.
1458 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1459 (encode_invocation_designation): Last argument P_NCHARS is now
1460 EMACS_INT.
1461 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1462 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1463
1464 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1465 All users changed.
1466
1467 * ccl.c (Fccl_execute_on_string): Declare some variables
1468 EMACS_INT.
1469
8546720e 14702011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1471
1472 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1473
4e19a977
CS
14742011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1475
1476 * process.c (Fformat_network_address): Doc fix.
1477
87302331
R
14782011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1479
1480 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1481
cbb59342
CY
14822011-04-08 Chong Yidong <cyd@stupidchicken.com>
1483
1484 * keyboard.c (read_char): Call Lisp function help-form-show,
1485 instead of using internal_with_output_to_temp_buffer.
1486 (Qhelp_form_show): New var.
e0d38eeb 1487 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1488
1489 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1490
1491 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1492
e67a13ab
CY
14932011-04-06 Chong Yidong <cyd@stupidchicken.com>
1494
1495 * process.c (Flist_processes): Removed to Lisp.
1496 (list_processes_1): Deleted.
1497
973f782d
EZ
14982011-04-06 Eli Zaretskii <eliz@gnu.org>
1499
7c106b1e
EZ
1500 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1501
973f782d
EZ
1502 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1503
41cf7d1a 15042011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1505
ca23cc88
PE
1506 Fix more problems found by GCC 4.6.0's static checks.
1507
f390e2d5
PE
1508 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1509
42eea0d0
PE
1510 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1511
b69769da 1512 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1513
f9541e84
PE
1514 * xdisp.c (vmessage): Mark as a printf-like function.
1515
13841b55
PE
1516 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1517
c136c10f
PE
1518 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1519
5e2d4a30
PE
1520 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1521 printf-like functions.
1522 (tiff_load): Add casts to remove these marks before passing them
1523 to system-supplied API.
1524
583f48b9
PE
1525 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1526
b25d760e
PE
1527 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1528 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1529 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1530 directly, rather than having caller test rule sign. This avoids
1531 some unnecessary tests.
1532 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1533 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1534 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1535
bc7b6697 1536 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1537 (xfont_open): Avoid unnecessary tests.
bc7b6697 1538
27ccc379
PE
1539 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1540
dcd5c89a
PE
1541 * composite.h, composite.c (composition_gstring_put_cache):
1542 Use EMACS_INT, not int, for length.
1543
b13a45c6
PE
1544 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1545 breaking out part of COMPOSITION_DECODE_RULE.
1546 (COMPOSITION_DECODE_RULE): Use it.
1547 * composite.c (get_composition_id): Remove unused local vars,
1548 by using the new macro.
1549
1e792e4d
PE
1550 * textprop.c (set_text_properties_1): Change while to do-while,
1551 since the condition is always true at first.
1552
dc6c6455 1553 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1554 (interval_deletion_adjustment): Return unsigned value.
1555 All uses changed.
dc6c6455 1556
aba7731a
PE
1557 * process.c (list_processes_1, create_pty, read_process_output):
1558 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1559 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1560 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1561 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1562 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1563
fdfc4bf3
PE
1564 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1565
fca8fe46 1566 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1567 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1568
06a0259a 1569 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1570 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1571 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1572
e7b9e80f
PE
1573 * print.c (print_error_message): Avoid int overflow.
1574
56201685
PE
1575 * font.c (font_list_entities): Redo for clarity,
1576 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1577
78834453 1578 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1579 (font_score): Avoid potential overflow in diff calculation.
78834453 1580
0bc0b309 1581 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1582 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1583
e610eaca
PE
1584 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1585
b895abce
PE
1586 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1587 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1588 can always succeed if overflow has undefined behavior.
1589
1f1d9321 1590 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1591 (wordify): Omit three unnecessary tests.
1f1d9321 1592
c59478bc
PE
1593 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1594 All callers changed. This avoids the need for an unused var.
1595
79b73827
PE
1596 * casefiddle.c (casify_region): Remove var that is set but not used.
1597
a4db5dfe
PE
1598 * dired.c (file_name_completion): Remove var that is set but not used.
1599
43aae36e
PE
1600 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1601
2a47c44d 1602 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1603 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1604
a37c69bf
PE
1605 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1606 Check for integer overflow on size calculations.
1607
328ab8e7
PE
1608 * buffer.c (Fprevious_overlay_change): Remove var that is set
1609 but not used.
1610
e5a2a5cb
PE
1611 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1612 Remove vars that are set but not used.
8d84a6eb 1613 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1614 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1615
a60e5f68
PE
1616 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1617
f661cb61 1618 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1619 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1620
f0397f5a
PE
1621 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1622 that are set but not used.
1623
8664db06 1624 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1625 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1626
6abdaa4a
PE
1627 * xselect.c (x_get_local_selection, x_handle_property_notify):
1628 Remove vars that are set but not used.
1629
0ce7538d 1630 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1631 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1632
9ae848fc
PE
1633 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1634 Remove var that is set but not used.
0b918413
PE
1635 (scroll_bar_windows_size): Now size_t, not int.
1636 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1637 Check for overflow.
9ae848fc 1638
a5a62657
PE
1639 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1640 (map_tty_color) [!defined MSDOS]: Likewise.
1641
5c5cdd39
PE
1642 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1643
66ebf983
PE
1644 * coding.c: Remove vars that are set but not used.
1645 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1646 All callers changed.
1647 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1648 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1649 (decode_coding_charset): Remove vars that are set but not used.
1650
1be4d761
PE
1651 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1652 that is set but not used.
1653
47553fa8
PE
1654 * print.c (print_object): Remove var that is set but not used.
1655
1f7196bf 1656 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1657 The gnulib version avoids calling malloc in the usual case,
1658 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1659 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1660 * filelock.c (current_lock_owner): Likewise.
1661 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1662 * sysdep.c: Include allocator.h, careadlinkat.h.
1663 (emacs_no_realloc_allocator): New static constant.
1664 (emacs_readlink): New function.
fdb61804
PE
1665 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1666 ../lib/careadlinkat.h.
d1fdcab7 1667
f84c17c7
SM
16682011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1669
1670 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1671 first non-nil return value).
1672
ef3862ad
JD
16732011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1674
1675 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1676 if not defined (Bug#8403).
1677
376a7006
JB
16782011-04-02 Juanma Barranquero <lekktu@gmail.com>
1679
1680 * xdisp.c (display_count_lines): Remove parameter `start',
1681 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1682 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1683 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1684 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1685 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1686 and thereabouts. All callers changed.
1687 (get_per_char_metric): Remove parameter `f', unused since
1688 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1689
6ca3801d
JM
16902011-04-02 Jim Meyering <meyering@redhat.com>
1691
1692 do not dereference NULL upon failed strdup
1693 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1694 (ns_get_family): Likewise.
1695
d8e2b5ba
JB
16962011-04-02 Juanma Barranquero <lekktu@gmail.com>
1697
1698 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1699
8c74fcbd
JD
17002011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1701
1702 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1703 later (Bug#8403).
1704
7200d79c
SM
17052011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1706
03408648 1707 Add lexical binding.
7200d79c 1708
03408648
SM
1709 * window.c (Ftemp_output_buffer_show): New fun.
1710 (Fsave_window_excursion):
1711 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1712
1713 * lread.c (lisp_file_lexically_bound_p): New function.
1714 (Fload): Bind Qlexical_binding.
1715 (readevalloop): Remove `evalfun' arg.
1716 Bind Qinternal_interpreter_environment.
1717 (Feval_buffer): Bind Qlexical_binding.
1718 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1719 Mark as dynamic.
1720 (syms_of_lread): Declare `lexical-binding'.
1721
1722 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1723
1724 * keyboard.c (eval_dyn): New fun.
1725 (menu_item_eval_property): Use it.
ca105506
SM
1726
1727 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1728
03408648
SM
1729 * fns.c (concat, mapcar1): Accept byte-code-functions.
1730
1731 * eval.c (Fsetq): Handle lexical vars.
1732 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1733 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1734 (FletX, Flet): Obey lexical binding.
1735 (Fcommandp): Handle closures.
1736 (Feval): New `lexical' arg.
1737 (eval_sub): New function extracted from Feval. Use it almost
1738 everywhere where Feval was used. Look up vars in lexical env.
1739 Handle closures.
1740 (Ffunctionp): Move from subr.el.
1741 (Ffuncall): Handle closures.
1742 (apply_lambda): Remove `eval_flags'.
1743 (funcall_lambda): Handle closures and new byte-code-functions.
1744 (Fspecial_variable_p): New function.
1745 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1746 but without exporting it to Lisp.
23aba0ea 1747
23aba0ea 1748 * doc.c (Fdocumentation, store_function_docstring):
03408648 1749 * data.c (Finteractive_form): Handle closures.
23aba0ea 1750
03408648
SM
1751 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1752 interactive spec.
ba83908c 1753
03408648
SM
1754 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1755 byte-codes.
1756 (exec_byte_code): New function extracted from Fbyte_code to handle new
1757 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1758
03408648 1759 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1760
03408648 1761 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1762
e2abce01
JB
17632011-03-31 Juanma Barranquero <lekktu@gmail.com>
1764
1765 * xdisp.c (redisplay_internal): Fix prototype.
1766
63696a73 17672011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1768
63696a73
EZ
1769 * xdisp.c (SCROLL_LIMIT): New macro.
1770 (try_scrolling): Use it when setting scroll_limit. Limit
1771 scrolling to 100 screen lines.
1772 (redisplay_window): Even when falling back on "recentering",
1773 position point in the window according to scroll-conservatively,
1774 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1775
1776 (try_scrolling): When point is above the window, allow searching
1777 as far as scroll_max, or one screenful, to compute vertical
1778 distance from PT to the scroll margin position. This prevents
1779 try_scrolling from unnecessarily failing when
1780 scroll-conservatively is set to a value slightly larger than the
1781 window height. Clean up the case of PT below the margin at bottom
1782 of window: scroll_max can no longer be INT_MAX. When aggressive
1783 scrolling is in use, don't let point enter the opposite scroll
1784 margin as result of the scroll.
1785 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1786 threshold of 100 lines for never-recentering scrolling.
1787
e4cc2dfc
JB
17882011-03-31 Juanma Barranquero <lekktu@gmail.com>
1789
1790 * dispextern.h (move_it_by_lines):
1791 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1792 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1793 (message_log_check_duplicate): Remove parameters `prev_bol' and
1794 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1795 (redisplay_internal): Remove parameter `preserve_echo_area',
1796 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1797
1798 * indent.c (Fvertical_motion):
1799 * window.c (window_scroll_pixel_based, Frecenter):
1800 Don't pass `need_y_p' to `move_it_by_lines'.
1801
1c470562
SM
18022011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1803
44f230aa
SM
1804 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1805 steal a few bits to be more compact.
1806 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1807 Remove unneeded casts.
1808
1c470562
SM
1809 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1810
888adce9
ZK
18112011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1812
1813 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1814 binding" message (bug#7967).
1815
f838ed7b
PE
18162011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1817
77861b95
PE
1818 Fix more problems found by GCC 4.6.0's static checks.
1819
de6dbc14
PE
1820 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1821 Remove unused local var.
1822
f838ed7b
PE
1823 * editfns.c (Fmessage_box): Remove unused local var.
1824
792c7b2b
PE
1825 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1826 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1827 Omit unused local vars.
c499e557 1828 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1829 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1830 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1831 Omit unused local var.
1832
ba0165e1
PE
1833 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1834 Don't assume string length fits in int.
32ad8845 1835 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1836 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1837
3c59b4c9
PE
1838 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1839 instead of alloca (Bug#8344).
1840
a3eed478 1841 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1842 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1843
eb4d412d
PE
1844 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1845
1658b401
PE
1846 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1847 concerns.
1848
1849 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1850
1851 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1852
9a2c6e05
PE
1853 * keyboard.c (syms_of_keyboard): Use the same style as later
1854 in this function when indexing through an array. This also
1855 works around GCC bug 48267.
1856
03d0a109
PE
1857 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1858
44f730c8
PE
1859 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1860
fe75f926
PE
1861 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1862 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1863
ffa8c828
PE
1864 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1865 This avoids undefined behavior on integer overflow, and is a bit
1866 more convenient anyway since it is compared to a size_t variable.
1867
c5101a77
PE
1868 Variadic C functions now count arguments with size_t, not int.
1869 This avoids an unnecessary limitation on 64-bit machines, which
1870 caused (substring ...) to crash on large vectors (Bug#8344).
1871 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1872 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1873 All variadic functions and their callers changed accordingly.
c5101a77
PE
1874 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1875 * data.c (arith_driver, float_arith_driver): Likewise.
1876 * editfns.c (general_insert_function): Likewise.
1877 * eval.c (struct backtrace.nargs, interactive_p)
1878 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1879 (funcall_lambda, mark_backtrace): Likewise.
1880 * fns.c (concat): Likewise.
1881 * frame.c (x_set_frame_parameters): Likewise.
1882 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1883 0 if not found, not -1. All callers changed.
1884
dd3f25f7
PE
1885 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1886 (stack_copy_size): Now size_t, not int.
1887 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1888
461c2ab9
JB
18892011-03-28 Juanma Barranquero <lekktu@gmail.com>
1890
1891 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1892 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1893 All callers changed.
1894
1895 * lisp.h (multibyte_char_to_unibyte):
1896 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1897 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1898 * character.h (CHAR_TO_BYTE8):
1899 * cmds.c (internal_self_insert):
1900 * editfns.c (general_insert_function):
1901 * keymap.c (push_key_description):
1902 * search.c (Freplace_match):
1903 * xdisp.c (message_dolog, set_message_1): All callers changed.
1904
f6d62986
SM
19052011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1906
1907 * keyboard.c (safe_run_hook_funcall): New function.
1908 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1909 don't set the hook to nil, but remove the offending function instead.
1910 (Qcommand_hook_internal): Remove, unused.
1911 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1912 Vcommand_hook_internal.
1913
1914 * eval.c (enum run_hooks_condition): Remove.
1915 (funcall_nil, funcall_not): New functions.
1916 (run_hook_with_args): Call each function through a `funcall' argument.
1917 Remove `cond' argument, now redundant.
1918 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1919 (Frun_hook_with_args_until_failure): Adjust accordingly.
1920 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1921
1db5b1ad
JB
19222011-03-28 Juanma Barranquero <lekktu@gmail.com>
1923
1924 * dispextern.h (string_buffer_position): Remove declaration.
1925
1926 * print.c (strout): Remove parameter `multibyte', unused since
1927 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1928
1929 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1930 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1931 All callers changed.
1932
1933 * w32.c (_wsa_errlist): Use braces for struct initializers.
1934
1935 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1936 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1937 All callers changed.
1938 (string_buffer_position): Likewise. Also, make static (it's never
1939 used outside xdisp.c).
1940 (cursor_row_p): Remove parameter `w', unused since
1941 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1942 (decode_mode_spec): Remove parameter `precision', introduced during
1943 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1944 All callers changed.
1945
5ffb62aa
JD
19462011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1947
1948 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1949
461c2ab9 19502011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1951
1952 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1953 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1954 (ns_update_auto_hide_menu_bar): New functions.
1955 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1956 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1957 ns_constrain_all_frames.
1958 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1959 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1960
5c380ffb
JD
19612011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1962
1963 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1964
9af30bdf
GM
19652011-03-27 Glenn Morris <rgm@gnu.org>
1966
1967 * syssignal.h: Replace RETSIGTYPE with void.
1968 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1969 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1970 Replace SIGTYPE with void everywhere.
1971 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1972 * s/template.h (SIGTYPE): Remove commented out definition.
1973
e2abce01
JB
19742011-03-26 Eli Zaretskii <eliz@gnu.org>
1975
1976 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1977 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1978
f868cd8a
JB
19792011-03-26 Juanma Barranquero <lekktu@gmail.com>
1980
59eb0929
JB
1981 * w32.c (read_unc_volume): Use parameter `henum', instead of
1982 global variable `wget_enum_handle'.
1983
1984 * keymap.c (describe_vector): Remove parameters `indices' and
1985 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1986 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1987
f868cd8a
JB
1988 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1989
1990 * keyboard.c (timer_check): Remove parameter `do_it_now',
1991 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1992 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1993 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1994
1995 * keyboard.c (read_char):
1996 * w32menu.c (w32_menu_display_help):
1997 * xmenu.c (show_help_event, menu_help_callback):
1998 Adjust calls to `show_help_echo'.
1999
2000 * gtkutil.c (xg_maybe_add_timer):
2001 * keyboard.c (readable_events):
2002 * process.c (wait_reading_process_output):
2003 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2004
2005 * insdel.c (adjust_markers_gap_motion):
2006 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2007 (gap_left, gap_right): Don't call it.
2008
2ecf6fdb
CY
20092011-03-25 Chong Yidong <cyd@stupidchicken.com>
2010
2011 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2012 incurred during fontification.
2013
6b1f9ba4
JB
20142011-03-25 Juanma Barranquero <lekktu@gmail.com>
2015
2016 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2017 (DEFVAR_PER_BUFFER): Don't pass it.
2018
2019 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2020 (scrolling_window): Don't pass it.
2021
0f4a96b5
JB
20222011-03-25 Juanma Barranquero <lekktu@gmail.com>
2023
2024 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2025
2026 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2027 and `suffix'.
2028 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2029 of variables specific to SELinux and computation of `encoded_absname'.
2030
2031 * image.c (XPutPixel): Remove unused variable `height'.
2032
2033 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2034
2035 * unexw32.c (get_section_info): Remove unused variable `section'.
2036
2037 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2038 (system_process_attributes): Remove unused variable `sess'.
2039 (sys_read): Remove unused variable `err'.
2040
2041 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2042 (w32_wnd_proc): Remove unused variable `isdead'.
2043 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2044 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2045 (x_create_tip_frame): Remove unused variable `tem'.
2046
2047 * w32inevt.c (w32_console_read_socket):
2048 Remove unused variable `no_events'.
2049
2050 * w32term.c (x_draw_composite_glyph_string_foreground):
2051 Remove unused variable `width'.
2052
1149507c
JB
20532011-03-24 Juanma Barranquero <lekktu@gmail.com>
2054
2055 * w32term.c (x_set_glyph_string_clipping):
2056 Don't pass uninitialized region to CombineRgn.
2057
9c88f339
JB
20582011-03-23 Juanma Barranquero <lekktu@gmail.com>
2059
2060 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2061 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2062 (Fx_close_connection): Remove unused variable `i'.
2063
2064 * w32font.c (w32font_draw): Return number of glyphs.
2065 (w32font_open_internal): Remove unused variable `i'.
2066 (w32font_driver): Add missing initializer.
2067
2068 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2069 (fill_in_menu): Remove unused variable `items_added'.
2070
2071 * w32term.c (last_mouse_press_frame): Remove static global variable.
2072 (w32_clip_to_row): Remove unused variable `f'.
2073 (x_delete_terminal): Remove unused variable `i'.
2074
2075 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2076 (NOTHING): Remove unused static global variable.
2077 (uniscribe_check_otf): Remove unused variable `table'.
2078 (uniscribe_font_driver): Add missing initializers.
2079
dee091a3
JD
20802011-03-23 Julien Danjou <julien@danjou.info>
2081
2082 * term.c (Fsuspend_tty, Fresume_tty):
2083 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2084 * window.c (temp_output_buffer_show):
2085 * insdel.c (signal_before_change):
2086 * frame.c (Fhandle_switch_frame):
2087 * fileio.c (Fdo_auto_save):
2088 * emacs.c (Fkill_emacs):
2089 * editfns.c (save_excursion_restore):
2090 * cmds.c (internal_self_insert):
2091 * callint.c (Fcall_interactively):
2092 * buffer.c (Fkill_all_local_variables):
2093 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2094 Use Frun_hooks.
0f4a96b5 2095 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2096 unconditionnaly since it does the check itself.
2097
2c520ab5 20982011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2099
c9c49752
PE
2100 Fix more problems found by GCC 4.5.2's static checks.
2101
8abc3f12
PE
2102 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2103 the first time through the loop, since we know p0 < p1 then.
2104 This also avoids a gcc -Wstrict-overflow warning.
2105
a2d26660
PE
2106 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2107 leading to a memory leak, possible in functions like
2108 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2109 of objects (Bug#8318).
a2d26660 2110
916c72e9
PE
2111 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2112 that could (at least in theory) be that large.
2113
19ab8a18
PE
2114 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2115 This is less likely to overflow, and avoids undefined behavior if
2116 overflow does occur. All callers changed. Use strtoul to scan
2117 for the unsigned long integer.
b7cbbd6f
PE
2118 (pint2hrstr): Simplify and tune code slightly.
2119 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2120
f0641eff
PE
2121 * scroll.c (do_scrolling): Work around GCC bug 48228.
2122 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2123
7f650bb9
PE
2124 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2125 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2126 (validate_x_resource_name): Simplify count usage.
2127 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2128
37dd57d1
PE
2129 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2130 fail (Bug#8306).
81e56e61 2131
699979fc 2132 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2133
401bf9b4
PE
2134 * process.c (Fmake_network_process): Use socklen_t, not int,
2135 where POSIX says socklen_t is required in portable programs.
2136 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2137 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2138 (Fmake_network_process, server_accept_connection):
2139 (wait_reading_process_output, read_process_output):
2140 Likewise.
2141
b93aacde
PE
2142 * process.c: Rename or move locals to avoid shadowing.
2143 (list_processes_1, Fmake_network_process):
2144 (read_process_output_error_handler, exec_sentinel_error_handler):
2145 Rename or move locals.
4dc343ee 2146 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2147 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2148 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2149 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2150 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2151
af8a867c 2152 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2153 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2154 Include tparam.h instead, since it declares them.
af8a867c
PE
2155 * cm.h (PC): Remove extern decl; tparam.h now does this.
2156 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2157 * terminfo.c: Include tparam.h, to check interfaces.
2158 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2159 (tparam): Adjust signature to match interface in tparam.h;
2160 this removes some undefined behavior. Check that outstring and len
2161 are zero, which they always are with Emacs.
2162 * tparam.h (PC, BC, UP): New extern decls.
2163
0248044d 2164 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2165 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2166
8ff096c1 2167 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2168 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2169 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2170 (ftfont_list): Remove unused local.
49eaafba
PE
2171 (get_adstyle_property, ftfont_pattern_entity):
2172 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2173 Rename locals to avoid shadowing.
8ff096c1 2174
e2be39f6
PE
2175 * xfont.c (xfont_list_family): Mark var as initialized.
2176
c9735e30
PE
2177 * xml.c (make_dom): Now static.
2178
8f5201ae
PE
2179 * composite.c (composition_compute_stop_pos): Rename local to
2180 avoid shadowing.
b246f932
PE
2181 (composition_reseat_it): Remove unused locals.
2182 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2183 (composition_update_it): Mark var as initialized.
11b61122
PE
2184 (find_automatic_composition): Mark vars as initialized,
2185 with a FIXME (Bug#8290).
8f5201ae 2186
760fbc2c
PE
2187 character.h: Rename locals to avoid shadowing.
2188 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2189 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2190 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2191 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2192 to avoid shadowing.
2193
ff08eb85
PE
2194 * textprop.c (property_change_between_p): Remove; unused.
2195
fc7bf025
PE
2196 * intervals.c (interval_start_pos): Now static.
2197
235d7abc
PE
2198 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2199
44f230aa
SM
2200 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2201 Rename locals to avoid shadowing.
3e7d6594 2202
50060332
PE
2203 * sound.c (wav_play, au_play, Fplay_sound_internal):
2204 Fix pointer signedness.
d01f234b 2205 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2206 (wav_play): Initialize a variable to 0, to prevent undefined
2207 behavior (Bug#8278).
50060332 2208
c4fc4e30
PE
2209 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2210
918436ed
PE
2211 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2212
c939f91b
PE
2213 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2214 clobbering (Bug#8298).
b9c7f648
PE
2215 * sysdep.c (sys_subshell): Likewise.
2216 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2217
6bd8c144
PE
2218 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2219 This should get cleaned up, so that child_setup has the
2220 same signature on all platforms.
2221
7710357c 2222 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2223 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2224
c59da222
CY
22252011-03-22 Chong Yidong <cyd@stupidchicken.com>
2226
2227 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2228 not to be necessary, and produces flickering.
2229
66b87493
GM
22302011-03-20 Glenn Morris <rgm@gnu.org>
2231
2232 * config.in: Remove file.
2233
45b6f6d5
JB
22342011-03-20 Juanma Barranquero <lekktu@gmail.com>
2235
2236 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2237 are now in src/globals.h.
2238 (syms_of_minibuf): Remove spurious & from previous change.
2239
3ec03f7e
LL
22402011-03-20 Leo <sdl.web@gmail.com>
2241
2242 * minibuf.c (completing-read-function): New variable.
2243 (completing-read-default): Rename from completing-read.
2244 (completing-read): Call completing-read-function.
2245
b14e3e21
CY
22462011-03-19 Juanma Barranquero <lekktu@gmail.com>
2247
2248 * xfaces.c (Fx_load_color_file):
2249 Read color file from absolute filename (bug#8250).
2250
f2b726e6
JB
22512011-03-19 Juanma Barranquero <lekktu@gmail.com>
2252
2253 * makefile.w32-in: Update dependencies.
2254
09f6ff02
EZ
22552011-03-17 Eli Zaretskii <eliz@gnu.org>
2256
2257 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2258
29a6015a
PE
22592011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2260
a3a6c54e
PE
2261 Fix more problems found by GCC 4.5.2's static checks.
2262
b766f867
PE
2263 * process.c (make_serial_process_unwind, send_process_trap):
2264 (sigchld_handler): Now static.
2265
be02381c
PE
2266 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2267 That way, the code declares only the vars that it needs.
2268 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2269 * s/cygwin.h (PTY_ITERATION): Likewise.
2270 * s/darwin.h (PTY_ITERATION): Likewise.
2271 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2272
57048744
PE
2273 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2274 * process.c (allocate_pty): Don't declare stb unless it's needed.
2275
7914961c 2276 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2277 (CONSTANTLIM): Remove; unused.
2278 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2279 Define only if needed.
7914961c 2280
b3967b18
PE
2281 * unexelf.c (unexec): Name an expression,
2282 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2283 Use a different way to cause a compilation error if anyone uses
2284 n rather than nn, a way that does not involve shadowing.
73366a00 2285 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2286
29a6015a
PE
2287 * deps.mk (unexalpha.o): Remove; unused.
2288
43cfc33e 2289 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2290 * unexec.h: New file.
ce701a33
PE
2291 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2292 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2293 Depend on unexec.h.
2294 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2295 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2296 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2297 Change as necessary to match prototype in unexec.h.
ce701a33 2298
01f44d5a
PE
2299 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2300 shadowing.
4f63c6bb 2301 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2302
a6670b0b
PE
2303 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2304 Rename locals to avoid shadowing.
2305
cef2010d 2306 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2307 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2308
d4d7173a
PE
2309 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2310
f08b802a
PE
2311 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2312 warning when compiling print.c.
2313
3ddb0639
PE
2314 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2315 instead of using an uninitialized var.
5ad03b97 2316 (font_sort_entities): Mark var as initialized.
3ddb0639 2317
170a2692
PE
2318 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2319
e663c700
PE
2320 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2321 pointers to constants.
89bc529a 2322 (font_parse_fcname): Remove unused vars.
7b81e2d0 2323 (font_delete_unmatched): Now static.
ea838e10 2324 (font_get_spec): Remove; unused.
13a547c6
PE
2325 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2326 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2327 Rename or move locals to avoid shadowing.
e663c700 2328
2a80c887 2329 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2330 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2331
1384fa33 2332 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2333 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2334
8b2c52e9
PE
2335 * alloc.c (mark_backtrace): Move decl from here ...
2336 * lisp.h: ... to here, so that it can be checked.
2337
475545b5 2338 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2339 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2340 (lisp_indirect_variable): Name an expression,
2341 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2342 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2343
b1349114 2344 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2345 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2346 Use const pointer when appropriate.
b1349114 2347
a2928364
PE
2348 * lisp.h (get_system_name, get_operating_system_release):
2349 Move decls here, to check interfaces.
2350 * process.c (get_operating_system_release): Move decl to lisp.h.
2351 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2352 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2353 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2354 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2355 (Fformat_time_string, Fencode_time, Finsert_char):
2356 (Ftranslate_region_internal, Fformat):
2357 Rename or remove local vars to avoid shadowing.
9710023e 2358 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2359
a415e694
PE
2360 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2361 avoid shadowing.
2362
8ef4622d
PE
2363 * lisp.h (eassert): Check that the argument compiles, even if
2364 ENABLE_CHECKING is not defined.
2365
946f9a5b
PE
2366 * data.c (Findirect_variable): Name an expression, to avoid
2367 gcc -Wbad-function-cast warning.
112396d6 2368 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2369 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2370 (Fmake_variable_buffer_local, Fmake_local_variable):
2371 Mark variables as initialized.
52746918 2372 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2373
e5aab7e7 2374 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2375 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2376 Rename locals to avoid shadowing.
dff45157
PE
2377 (mark_stack): Move local variables into the #ifdef region where
2378 they're used.
7bc26fdb
PE
2379 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2380 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2381 needed otherwise.
2382 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2383 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2384 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2385
e5aab7e7
PE
2386 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2387 avoids undefined behavior in theory.
2388
4da60324
PE
2389 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2390
88043301
PE
2391 Use functions, not macros, for up- and down-casing (Bug#8254).
2392 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2393 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2394 to use the following functions instead of these macros.
2395 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2396 EMACS_INT, since callers assume the returned value fits in int.
2397 (upcase1): Likewise, for UPCASE_TABLE.
2398 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2399 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2400 the race-condition problem in the old DOWNCASE.
88043301 2401
19ed5445
PE
2402 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2403 Rename locals to avoid shadowing.
2404 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2405 (regex_compile, re_search_2, re_match_2_internal):
2406 Remove unused local vars.
952db0d7
PE
2407 (FREE_VAR): Rewrite so as not to use empty "else",
2408 which gcc can warn about.
da053e48 2409 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2410 (RETALLOC_IF): Define only if needed.
2411 (WORDCHAR_P): Likewise. This one is never needed, but is used
2412 only in a comment talking about a compiler bug, so put inside
2413 the #if 0 of that comment.
2414 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2415 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2416 Remove; unused.
19ed5445 2417
1f3561e4 2418 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2419 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2420 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2421
ded6f8f7
PE
2422 * search.c (simple_search): Remove unused var.
2423
dbd37a95
PE
2424 * dired.c (compile_pattern): Move decl from here ...
2425 * lisp.h: ... to here, so that it can be checked.
2426 (struct re_registers): New forward decl.
2427
7e47afad
PE
2428 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2429
85f24f61
PE
2430 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2431 All uses changed.
2432 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2433 Rename locals to avoid shadowing.
5671df8f 2434 (Fvertical_motion): Mark locals as initialized.
85f24f61 2435
181aa2be 2436 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2437 (casify_region): Mark local as initialized.
181aa2be 2438
930d429c
PE
2439 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2440
7082eac6
PE
2441 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2442 New macros, so that the caller can use some names other than
2443 gcpro1, gcpro2, etc.
2444 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2445 of the new macros.
2446 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2447 argument, for consistency with GCPRO2_VAR, etc: it is now the
2448 prefix of the variable, not the variable itself. All uses
2449 changed.
38b2c076
PE
2450 * dired.c (directory_files_internal, file_name_completion):
2451 Rename locals to avoid shadowing.
2452
15206ed9
PE
2453 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2454 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2455 dired.c's scmp function, had undefined behavior.
2456 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2457 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2458 * buffer.h: ... to here, because these macros use current_buffer,
2459 and the new implementation with inline functions needs to have
2460 current_buffer in scope now, rather than later when the macros
2461 are used.
2462 (downcase, upcase1): New static inline functions.
2463 (DOWNCASE, UPCASE1): Reimplement using these functions.
2464 This avoids undefined behavior in expressions like
2465 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2466 from race conditions in accessing the global variables
2467 case_temp1 and case_temp2.
2468 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2469 * lisp.h (case_temp1, case_temp2): Remove their decls.
2470 * character.h (ASCII_CHAR_P): Move from here ...
2471 * lisp.h: ... to here, so that the inline functions mentioned
2472 above can use them.
2473
4a6bea26
PE
2474 * dired.c (directory_files_internal_unwind): Now static.
2475
f14b7e14
PE
2476 * fileio.c (file_name_as_directory, directory_file_name):
2477 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2478 Now static.
2893f146
PE
2479 (file_name_as_directory): Use const pointers when appropriate.
2480 (Fexpand_file_name): Likewise. In particular, newdir might
2481 point at constant storage, so make it a const pointer.
fd4ead52 2482 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2483 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2484 signedness issues.
f839df0c
PE
2485 (Fset_file_times, Finsert_file_contents, auto_save_error):
2486 Rename locals to avoid shadowing.
f14b7e14 2487
5716756e 2488 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2489 (Ftry_completion, Fall_completions): Rename or remove locals
2490 to avoid shadowing.
5716756e 2491
b4c3046a
PE
2492 * marker.c (bytepos_to_charpos): Remove; unused.
2493
b45db522
PE
2494 * lisp.h (verify_bytepos, count_markers): New decls,
2495 so that gcc does not warn that these functions aren't declared.
2496
85876d07
PE
2497 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2498 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2499 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2500 (copy_text): Remove unused local var.
85876d07 2501
03d78a21 2502 * filelock.c (within_one_second): Now static.
b3dd38ab 2503 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2504
5df8f01b
PE
2505 * buffer.c (fix_overlays_before): Mark locals as initialized.
2506 (fix_start_end_in_overlays): Likewise. This function should be
2507 simplified by using pointers-to-pointers, but that's a different
2508 matter.
b1d876f1 2509 (switch_to_buffer_1): Now static.
8f54f30a
PE
2510 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2511 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2512
a70072c9 2513 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2514 Fix pointer signedness issue.
edced198
PE
2515 (sys_subshell): Mark local as volatile if checking for lint,
2516 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2517 (MAXPATHLEN): Define only if needed.
a70072c9 2518
a0977c44
PE
2519 * process.c (serial_open, serial_configure): Move decls from here ...
2520 * systty.h: ... to here, so that they can be checked.
2521
a884fdcc
PE
2522 * fns.c (get_random, seed_random): Move extern decls from here ...
2523 * lisp.h: ... to here, so that they can be checked.
2524
604efe86 2525 * sysdep.c (reset_io): Now static.
b8950c94 2526 (wait_for_termination_signal): Remove; unused.
604efe86 2527
38fc62d9
PE
2528 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2529 (copy_keymap_item, append_key, push_text_char_description):
2530 Now static.
1004a21a 2531 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2532 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2533 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2534 (describe_map_tree):
2535 Rename locals to avoid shadowing.
38fc62d9 2536
2f2650da
PE
2537 * keyboard.c: Declare functions static if they are not used elsewhere.
2538 (echo_char, echo_dash, cmd_error, top_level_2):
2539 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2540 (read_char, kbd_buffer_get_event, make_lispy_position):
2541 (make_lispy_event, make_lispy_movement, apply_modifiers):
2542 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2543 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2544 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2545 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2546 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2547
a053e86c 2548 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2549 (mark_kboards): Move decl here ...
2550 * alloc.c (mark_kboards): ... from here.
a053e86c 2551
4752793e
PE
2552 * lisp.h (force_auto_save_soon): New decl.
2553
74f10ca7 2554 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2555 (DEFINE_DUMMY_FUNCTION): New macro.
2556 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2557 Use it.
c03cd23f
PE
2558 (main): Add casts to avoid warnings
2559 if GCC considers string literals to be constants.
74f10ca7 2560
022e70d4
PE
2561 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2562
59d6fe83
PE
2563 * dbusbind.c: Pointer signedness fixes.
2564 (xd_signature, xd_append_arg, xd_initialize):
2565 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2566 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2567 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2568 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2569
78320123
PE
2570 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2571 if GCC considers string literals to be constants.
49cebcca 2572 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2573
35ac2a97
SM
25742011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2575
fb103ca9
SM
2576 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2577 (print_preprocess, print_object): New macro to fix last change.
2578
35ac2a97
SM
2579 * print.c (print_preprocess): Don't forget font objects.
2580
62973b41
JB
25812011-03-16 Juanma Barranquero <lekktu@gmail.com>
2582
2583 * emacs.c (USAGE3): Doc fixes.
2584
0e48bb22
AS
25852011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2586
2587 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2588 structure.
2589
7684e57b
JB
25902011-03-14 Juanma Barranquero <lekktu@gmail.com>
2591
2592 * lisp.h (VWindow_system, Qfile_name_history):
2593 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2594 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2595 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2596
2597 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2598 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2599
2600 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2601 * w32console.c (detect_input_pending, read_input_pending)
2602 (encode_terminal_code):
2603 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2604 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2605 (w32_system_caret_y, Qfile_name_history):
2606 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2607 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2608 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2609 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2610 * w32proc.c (Qlocal, report_file_error):
2611 * w32term.c (Vwindow_system, updating_frame):
2612 * w32uniscribe.c (initialized, uniscribe_font_driver):
2613 Remove unneeded extern declarations.
2614
2aa46d6c
CY
26152011-03-14 Chong Yidong <cyd@stupidchicken.com>
2616
c96bbc66 2617 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2618
cffc6f3b
CY
26192011-03-13 Chong Yidong <cyd@stupidchicken.com>
2620
2621 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2622 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2623 These macros can no longer be used for assignment.
2624
44f230aa
SM
2625 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2626 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2627 (record_buffer_markers, fetch_buffer_markers): New functions for
2628 recording and fetching special buffer markers.
2629 (set_buffer_internal_1, set_buffer_temp): Use them.
2630
2631 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2632
2633 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2634
2635 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2636 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2637
2638 * xdisp.c (hscroll_window_tree):
2639 (reconsider_clip_changes): Use PT instead of BUF_PT.
2640
d251f04b
EZ
26412011-03-13 Eli Zaretskii <eliz@gnu.org>
2642
2643 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2644 $(EMACS_ROOT)/lib/intprops.h.
2645
f0c77cd1
PE
26462011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2647
3eca4629
PE
2648 Fix more problems found by GCC 4.5.2's static checks.
2649
7c86ee98
PE
2650 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2651 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2652 (xg_free_frame_widgets): Make it clear that a local variable is
2653 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2654 (gdk_window_get_screen): Make it clear that this macro is needed
2655 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2656 (int_gtk_range_get_value): New function, which avoids a diagnostic
2657 from gcc -Wbad-function-cast.
2658 (xg_set_toolkit_scroll_bar_thumb): Use it.
2659 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2660 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2661 (get_utf8_string, xg_get_file_with_chooser):
2662 Rename locals to avoid shadowing.
2663 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2664
41729b81
PE
2665 * xgselect.c (xg_select): Remove unused var.
2666
f0c77cd1
PE
2667 * image.c (four_corners_best): Mark locals as initialized.
2668 (gif_load): Initialize transparent_p to zero (Bug#8238).
2669 Mark another local as initialized.
ec6cf4c6 2670 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2671
ce0ad53d 2672 * image.c (clear_image_cache): Now static.
d5d5a617 2673 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2674 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2675 (x_edge_detection): Remove unnecessary cast that
2676 gcc -Wbad-function-cast diagnoses.
2037898d 2677 (gif_load): Fix pointer signedness.
6ae141d6
PE
2678 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2679 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2680
33383987 26812011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2682
d32df629
PE
2683 Improve quality of tests for time stamp overflow.
2684 For example, without this patch (encode-time 0 0 0 1 1
2685 1152921504606846976) returns the obviously-bogus value (-948597
2686 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2687 reports time overflow. See
2688 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2689 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2690 * editfns.c: Include limits.h and intprops.h.
2691 (TIME_T_MIN, TIME_T_MAX): New macros.
2692 (time_overflow): Move earlier, to before first use.
2693 (hi_time, lo_time): New functions, for an accurate test for
2694 out-of-range times.
2695 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2696 (Fget_internal_run_time): Don't assume time_t fits in int.
2697 (make_time): Use list2 instead of Fcons twice.
2698 (Fdecode_time): More accurate test for out-of-range times.
2699 (check_tm_member): New function.
2700 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2701 (lisp_time_argument): Don't rely on undefined left-shift and
2702 right-shift behavior when checking for time stamp overflow.
8be6f318 2703
fe31d94c
PE
2704 * editfns.c (time_overflow): New function, refactoring common code.
2705 (Fformat_time_string, Fdecode_time, Fencode_time):
2706 (Fcurrent_time_string): Use it.
2707
8be6f318
PE
2708 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2709 * dired.c (make_time): Move to ...
2710 * editfns.c (make_time): ... here.
2711 * systime.h: Note the move.
2712
09d9db2c 27132011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2714
126bc0dc
YM
2715 * fringe.c (update_window_fringes): Remove unused variables.
2716
c47cbdfd
YM
2717 * unexmacosx.c (copy_data_segment): Also copy __got section.
2718 (Bug#8223)
2719
7ac80be9
EZ
27202011-03-12 Eli Zaretskii <eliz@gnu.org>
2721
c96bbc66 2722 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2723 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2724 Constify `char *' arguments and their references according to
2725 prototypes in tparam.h.
2726
ecb0f94d 2727 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2728
7ac80be9
EZ
2729 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2730 Adapt all references accordingly.
2731
2732 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2733
ef1fd07e
TT
27342011-03-11 Tom Tromey <tromey@redhat.com>
2735
2736 * buffer.c (syms_of_buffer): Remove obsolete comment.
2737
7ef4b50c
EZ
27382011-03-11 Eli Zaretskii <eliz@gnu.org>
2739
2740 * termhooks.h (encode_terminal_code): Declare prototype.
2741
2742 * msdos.c (encode_terminal_code): Don't declare prototype.
2743
2744 * term.c (encode_terminal_code): Now external again, used by
2745 w32console.c and msdos.c.
2746
44f230aa
SM
2747 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2748 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2749
4b1ec863 27502011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2751
1714f52b 2752 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2753
4b1ec863
PE
2754 * fringe.c (update_window_fringes): Mark locals as initialized
2755 (Bug#8227).
2756 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2757
524c7aa6
PE
2758 * alloc.c (mark_fringe_data): Move decl from here ...
2759 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2760 to check its interface.
2761 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2762
a5c0af81 2763 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2764 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2765 (fontset_font): Mark local as initialized.
a9a06e0b 2766 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2767
b4716021
PE
2768 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2769
811e9bac 2770 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2771 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2772 (x_own_selection, Fx_disown_selection_internal): Rename locals
2773 to avoid shadowing.
2774 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2775
7e3ab302
PE
2776 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2777 so that the caller can use some name other than gcpro1.
2778 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2779 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2780 (Fx_backspace_delete_keys_p):
2781 Use them to avoid shadowing, and rename vars to avoid shadowing.
2782 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2783 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2784 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2785 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2786 Remove unused locals.
7e3ab302
PE
2787 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2788 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2789 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2790 macros.
f78faa98 2791
e2b13473
PE
2792 * xterm.h (x_mouse_leave): New decl.
2793
77f23912
PE
2794 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2795 Remove unused functions.
cdf4ba58
PE
2796 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2797 (x_calc_absolute_position): Now static.
7411c686 2798 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2799 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2800 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2801 unless they are used.
38d0b34a
PE
2802 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2803 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2804 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2805 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2806 (x_error_catcher, x_connection_closed, x_error_handler):
2807 (x_error_quitter, xembed_send_message, x_iconify_frame):
2808 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2809 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2810 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2811
44f230aa
SM
2812 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2813 Rename or move locals to avoid shadowing.
6b463e58 2814 (tty_defined_color, merge_face_heights): Now static.
5967d051 2815 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2816 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2817 does not deduce is never used uninitialized.
73719eba
PE
2818 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2819 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2820
426994c3 2821 * terminal.c (store_terminal_param): Now static.
5489860b 2822
032f1620 2823 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2824 (set_frame_menubar): Remove unused local.
d4323972 2825 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2826 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2827 since they might point to immutable storage.
281585b0
PE
2828 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2829 since it's unused otherwise.
032f1620 2830
367c19e5 2831 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2832 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2833 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2834 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2835 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2836 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2837 does not deduce are never used uninitialized.
70739cbe 2838
07b48fa9
PE
2839 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2840
8868a238 2841 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2842 * window.c (window_loop, size_window):
2843 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2844
7e5cf297 2845 * window.c (display_buffer): Now static.
d6550a9f
PE
2846 (size_window): Mark variables that gcc -Wuninitialized
2847 does not deduce are never used uninitialized.
a586633d
PE
2848 * window.h (check_all_windows): New decl, to forestall
2849 gcc -Wmissing-prototypes diagnostic.
5b555da1 2850 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2851
f6095868
PE
2852 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2853 shadowing.
2854 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2855 Include <limits.h>.
2856 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2857 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2858 (load_charset_map): Mark variables that gcc -Wuninitialized
2859 does not deduce are never used uninitialized.
53df7c11 2860 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2861
f38b440c
PE
2862 * coding.c (coding_set_source, coding_set_destination):
2863 Use "else { /* comment */ }" rather than "else /* comment */;"
2864 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2865 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2866 a block, when the outer 'i' will do.
2867 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2868 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2869 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2870 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2871 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2872 Rename locals to avoid shadowing.
2873 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2874 * coding.c (emacs_mule_char, encode_invocation_designation):
2875 Now static, since they're not used elsewhere.
413bb2db 2876 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2877 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2878 (decode_coding_emacs_mule): Mark variables that gcc
2879 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2880 (detect_coding_iso_2022): Initialize a local variable that might
2881 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2882 this initialization is needed. (Bug#8211)
5f58e762
PE
2883 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2884 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2885 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2886 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2887 Remove unused macros.
f38b440c 2888
232b38b9 2889 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2890 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2891 * character.c (string_count_byte8): Likewise.
232b38b9 2892
fb90da1b
PE
2893 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2894 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2895
fb93dbc2
PE
2896 * chartab.c (copy_sub_char_table): Now static, since it's not used
2897 elsewhere.
5c156ace
PE
2898 (sub_char_table_ref_and_range, char_table_ref_and_range):
2899 Rename locals to avoid shadowing.
bbcd0949 2900 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2901
7d3b3862 2902 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2903 (BIDI_BOB): Remove unused macro.
7d3b3862 2904
6be7d3da
PE
2905 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2906 deduce are never used uninitialized.
c2ed9c8b 2907 * term.c (encode_terminal_code): Likewise.
6be7d3da 2908
75f8807f 2909 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2910
50938595
PE
2911 * tparam.h: New file.
2912 * term.c, tparam.h: Include it.
2913 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2914 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2915 Move these decls to tparam.h, and make them agree with what
2916 is actually in tparam.c. The previous trick of using incompatible
2917 decls in different modules does not conform to the C standard.
2918 All callers of tparam changed to use tparam's actual API.
2919 * tparam.c (tparam1, tparam, tgoto):
2920 Use const pointers where appropriate.
2921
fbceeba2
PE
2922 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2923 * cm.h (struct cm): Likewise.
2924 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2925 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2926 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2927 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2928 (turn_on_face, init_tty): Likewise.
2929 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2930
7f3f1250
PE
2931 * term.c (term_mouse_position): Rename local to avoid shadowing.
2932
e6ca6543
PE
2933 * alloc.c (mark_ttys): Move decl from here ...
2934 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2935
c40f8d15
AS
29362011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2937
2938 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2939
cfe0661d
JB
29402011-03-09 Juanma Barranquero <lekktu@gmail.com>
2941
2942 * search.c (compile_pattern_1): Remove argument regp, unused since
2943 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2944 (compile_pattern): Don't pass it.
2945
0afb4571
J
29462011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2947
2948 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2949 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2950 for ! HAVE_GTK3.
2951 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2952
2953 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2954
2955 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2956 gdk_window_get_screen, gdk_window_get_geometry,
2957 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2958 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2959 (xg_get_pixbuf_from_pixmap): New function.
2960 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2961 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2962 Call xg_get_pixbuf_from_pixmap instead of
2963 gdk_pixbuf_get_from_drawable.
2964 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2965 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2966 (xg_check_special_colors): Use GtkStyleContext and its functions
2967 for HAVE_GTK3.
2968 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2969 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2970 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2971 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2972 Call gtk_widget_get_preferred_size.
0afb4571
J
2973 (xg_frame_resized): gdk_window_get_geometry only takes 5
2974 parameters.
44f230aa
SM
2975 (xg_win_to_widget, xg_event_is_for_menubar):
2976 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2977 (xg_set_widget_bg): New function.
2978 (delete_cb): New function.
895009e1 2979 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
2980 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2981 (xg_set_background_color): Call xg_set_widget_bg.
2982 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2983 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2984 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2985 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2986 if ! HAVE_GTK3.
2987 (update_frame_tool_bar): Call gtk_widget_hide.
2988 (xg_initialize): Use GDK_KEY_g.
2989
2990 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2991 if ! HAVE_GTK3
2992 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2993
2994 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2995 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2996 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2997
1c2cc4ef
JB
29982011-03-08 Juanma Barranquero <lekktu@gmail.com>
2999
3000 * w32xfns.c (select_palette): Check success of RealizePalette against
3001 GDI_ERROR, not zero.
3002
33383987 3003See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3004
3005;; Local Variables:
3006;; coding: utf-8
aac0c6e3
MR
3007;; End:
3008
33383987 3009 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3010
3011 This file is part of GNU Emacs.
3012
3013 GNU Emacs is free software: you can redistribute it and/or modify
3014 it under the terms of the GNU General Public License as published by
3015 the Free Software Foundation, either version 3 of the License, or
3016 (at your option) any later version.
3017
3018 GNU Emacs is distributed in the hope that it will be useful,
3019 but WITHOUT ANY WARRANTY; without even the implied warranty of
3020 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3021 GNU General Public License for more details.
3022
3023 You should have received a copy of the GNU General Public License
3024 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.