* lisp/image.el (insert-image): Clarifying docstring.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f25e39b4
EZ
12011-07-24 Eli Zaretskii <eliz@gnu.org>
2
3 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4 for attrs[LFACE_FONTSET_INDEX].
5
04c4b52e
PE
62011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7
8 * xml.c (parse_region): Remove unused local
9 that was recently introduced.
10
c1734fbd
EZ
112011-07-23 Eli Zaretskii <eliz@gnu.org>
12
be18c5a5
EZ
13 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
14 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
15
c1734fbd
EZ
16 * xdisp.c (move_it_in_display_line_to): Record the best matching
17 position for TO_CHARPOS while scanning the line, and restore it on
18 exit if none of the characters scanned was an exact match. Fixes
a9269c18
EZ
19 vertical-motion and pos-visible-in-window-p under bidi redisplay
20 when exact match is impossible due to invisible text, and the
21 lines are truncated.
22
a258d627
JD
232011-07-23 Jan Djärv <jan.h.d@swipnet.se>
24
25 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
26 for OSX >= 10.7.
27
b6d5a689
EZ
282011-07-22 Eli Zaretskii <eliz@gnu.org>
29
0f74f785
EZ
30 Fix a significant slow-down of cursor motion with C-n, C-p,
31 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
32 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 33 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
34 (next_element_from_buffer): Call compute_stop_pos_backwards to
35 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
36 base_level_stop.
37 (reseat): Don't look for prev_stop, as that could mean a very long
38 run.
39 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
40 <cached_disp_overlay_modiff>: Cache for last found display string
41 position.
551918c1 42 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
43 about the same buffer in the same area of character positions, and
44 the buffer wasn't changed since the time the display string
45 position was cached.
551918c1 46
b2d0c91a
EZ
472011-07-22 Eli Zaretskii <eliz@gnu.org>
48
49 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
50 is an integer, which is important for empty lines. (Bug#9149)
51
043604ee
CY
522011-07-22 Chong Yidong <cyd@stupidchicken.com>
53
54 * frame.c (Fmodify_frame_parameters): In tty case, update the
55 default face if necessary (Bug#4238).
56
da4adb04
CY
572011-07-21 Chong Yidong <cyd@stupidchicken.com>
58
59 * editfns.c (Fstring_to_char): No need to explain what a character
60 is in the docstring (Bug#6576).
61
9abd0532
LMI
622011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
63
64 * xml.c (parse_region): Make sure we always return a tree.
65
36881d16
HK
662011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
67
68 * xml.c (parse_region): If a document contains only comments,
69 return that, too.
70
1e98674d
LMI
712011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
72
73 * xml.c (make_dom): Return comments, too.
74
590bd467
PE
752011-07-19 Paul Eggert <eggert@cs.ucla.edu>
76
77 Port to OpenBSD.
78 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
79 and the surrounding thread.
80 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
81 rather than fgets, and retry after EINTR. Otherwise, 'emacs
82 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
83 timer goes off.
84 * s/openbsd.h (BROKEN_SIGIO): Define.
85 * unexelf.c (unexec) [__OpenBSD__]:
86 Don't update the .mdebug section of the Alpha COFF symbol table.
87
f41628b2
LMI
882011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
89
90 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
91 (bug#8460).
92
b59b67c5
PE
932011-07-18 Paul Eggert <eggert@cs.ucla.edu>
94
15e3a074
PE
95 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
96 This fixes some race conditions on the permissions of any newly
97 created file.
98
41bed37d
PE
99 * alloc.c (valid_pointer_p): Use pipe, not open.
100 This fixes some permissions issues when debugging.
101
b59b67c5
PE
102 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
103 If fchown fails to set both uid and gid, try to set just gid,
104 as that is sometimes allowed. Adjust the file's mode to eliminate
105 setuid or setgid bits that are inappropriate if fchown fails.
106
925a6be7
SM
1072011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
108
109 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
110 to compare Lisp_Objects.
111 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
112 global_gnutls_log_level, don't mistake it for a Lisp_Object.
113 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
114
52968808
AS
1152011-07-17 Andreas Schwab <schwab@linux-m68k.org>
116
0a6a104b
AS
117 * lread.c (read_integer): Unread even EOF character.
118 (read1): Likewise. Properly record start position of symbol.
119
52968808
AS
120 * lread.c (read1): Read `#:' as empty uninterned symbol if no
121 symbol character follows.
122
9e381cdd
PE
1232011-07-17 Paul Eggert <eggert@cs.ucla.edu>
124
125 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
126 This works around a problem with the previous change to Fcopy_file.
127 Recent glibc declares fchown with __attribute__((warn_unused_result)),
128 and without this change, GCC might complain about discarding
129 fchown's return value.
130
b5641435
JB
1312011-07-16 Juanma Barranquero <lekktu@gmail.com>
132
133 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
134
a8031457
PE
1352011-07-16 Paul Eggert <eggert@cs.ucla.edu>
136
137 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
138
dd889327
LMI
1392011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
140
750c33f7
LMI
141 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
142 it's used from the C level.
143
dd889327
LMI
144 * process.c: Use the same condition for POLL_FOR_INPUT in both
145 keyboard.c and process.c (bug#1858).
146
87e86684
LM
1472011-07-09 Lawrence Mitchell <wence@gmx.li>
148
149 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
150 (Fgnutls_boot): Use it.
151
64348f40
AS
1522011-07-15 Andreas Schwab <schwab@linux-m68k.org>
153
154 * doc.c (Fsubstitute_command_keys): Revert last change.
155
1d698799
LMI
1562011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
157
f863868c
LMI
158 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
159 quotes the next character, and doesn't affect other longer
160 sequences (bug#8935).
161
1d698799
LMI
162 * lread.c (syms_of_lread): Clarify that is isn't only
163 `eval-buffer' and `eval-defun' that's affected by
164 `lexical-binding' (bug#8460).
165
aa4b6df6
EZ
1662011-07-15 Eli Zaretskii <eliz@gnu.org>
167
168 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
169 bidi redisplay when a line includes both an image and is
170 truncated.
171
5d856da6
PE
1722011-07-14 Paul Eggert <eggert@cs.ucla.edu>
173
ad6042bb
PE
174 Fix minor problems found by static checking.
175 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
176 (elsz): Now a signed constant, not a size_t var. We prefer signed
177 types to unsigned, to avoid integer comparison confusion. Without
178 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
179 "cannot optimize loop, the loop counter may overflow", a symptom
180 of the confusion.
f00bbb22 181 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
182 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
183
6468f31c
LMI
1842011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
185
49080b10
LMI
186 * search.c (Fre_search_backward): Mention `case-fold-search' in
187 all the re_search_* functions (bug#8138).
188
6468f31c
LMI
189 * keyboard.c (Fopen_dribble_file): Document when the file is
190 closed (bug#8056).
191
c965adc5
EZ
1922011-07-14 Eli Zaretskii <eliz@gnu.org>
193
df9733bf
EZ
194 * bidi.c (bidi_dump_cached_states): Fix format of displaying
195 bidi_cache_idx.
196
0bb23927
EZ
197 Support bidi reordering of display and overlay strings.
198 * xdisp.c (compute_display_string_pos)
199 (compute_display_string_end): Accept additional argument STRING.
200 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
201 (reseat_to_string): Initialize bidi_it->string.s and
202 bidi_it->string.schars.
203 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
204 NULL (avoids a crash in bidi_paragraph_init). Initialize
205 itb.string.lstring.
206 (init_iterator): Call bidi_init_it only of a valid
207 buffer position was specified. Initialize paragraph_embedding to
208 L2R.
209 (reseat_to_string): Initialize the bidi iterator.
210 (display_string): If we need to ignore text properties of
211 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
212 original value of -1 will not work with bidi.)
213 (compute_display_string_pos): First arg is now struct
214 `text_pos *'; all callers changed. Support display properties on
215 Lisp strings.
216 (compute_display_string_end): Support display properties on Lisp
217 strings.
218 (init_iterator, reseat_1, reseat_to_string): Initialize the
219 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
220 when iterating on a string not from display properties).
221 (compute_display_string_pos, compute_display_string_end): Fix
222 calculation of the object to scan. Fixes an error when using
223 arrow keys.
224 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
225 base_level_stop; instead, set base_level_stop to BEGV. Fixes
226 crashes in vertical-motion.
227 (next_element_from_buffer): Improve commentary for when
228 the iterator is before prev_stop.
229 (init_iterator): Initialize bidi_p from the default value of
230 bidi-display-reordering, not from buffer-local value. Use the
231 buffer-local value only if initializing for buffer iteration.
232 (handle_invisible_prop): Support invisible properties on strings
233 that are being bidi-reordered.
234 (set_iterator_to_next): Support bidi reordering of C strings and
235 Lisp strings.
236 (next_element_from_string): Support bidi reordering of Lisp
237 strings.
238 (handle_stop_backwards): Support Lisp strings as well.
239 (display_string): Support display of R2L glyph rows. Use
240 IT_STRING_CHARPOS when displaying from a Lisp string.
241 (init_iterator): Don't initialize it->bidi_p for strings
242 here.
243 (reseat_to_string): Initialize it->bidi_p for strings here.
244 (next_element_from_string, next_element_from_c_string)
245 (next_element_from_buffer): Add xassert's for correspondence
246 between IT's object being iterated and it->bidi_it.string
247 structure.
248 (face_before_or_after_it_pos): Support bidi iteration.
249 (next_element_from_c_string): Handle the case of the first string
250 character that is not the first one in the visual order.
251 (get_visually_first_element): New function, refactored from common
252 parts of next_element_from_buffer, next_element_from_string, and
253 next_element_from_c_string.
254 (tool_bar_lines_needed, redisplay_tool_bar)
255 (display_menu_bar): Force left-to-right direction. Add a FIXME
256 comment for making that be controlled by a user option.
257 (push_it, pop_it): Save and restore the state of the
258 bidi iterator. Save and restore the bidi_p flag.
259 (pop_it): Iterate out of display property for string iteration as
260 well.
261 (iterate_out_of_display_property): Support iteration over strings.
262 (handle_single_display_spec): Set up it->bidi_it for iteration
263 over a display string, and call bidi_init_it.
264 (handle_single_display_spec, next_overlay_string)
265 (get_overlay_strings_1, push_display_prop): Set up the bidi
266 iterator for displaying display or overlay strings.
267 (forward_to_next_line_start): Don't use the shortcut if
268 bidi-iterating.
269 (back_to_previous_visible_line_start): If handle_display_prop
270 pushed the iterator stack, restore the internal state of the bidi
271 iterator by calling bidi_pop_it same number of times.
272 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
273 and we are bidi-iterating, don't decrement the iterator position;
274 instead, set the first_elt flag in the bidi iterator, to produce
275 the same effect.
276 (reseat_1): Remove redundant setting of string_from_display_prop_p.
277 (push_display_prop): xassert that we are iterating a buffer.
278 (push_it, pop_it): Save and restore paragraph_embedding member.
279 (handle_single_display_spec, next_overlay_string)
280 (get_overlay_strings_1, reseat_1, reseat_to_string)
281 (push_display_prop): Set up the `unibyte' member of bidi_it.string
282 correctly. Don't assume unibyte strings are not bidi-reordered.
283 (compute_display_string_pos)
284 (compute_display_string_end): Fix handling the case of C string.
285 (push_it, pop_it): Save and restore from_disp_prop_p.
286 (handle_single_display_spec, push_display_prop): Set the
287 from_disp_prop_p flag.
288 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
289 (pop_it): Call iterate_out_of_display_property only if we are
290 popping after iteration over a string that came from a display
291 property. Fix a typo in popping stretch info. Add an assertion
292 for verifying that the iterator position is in sync with the bidi
293 iterator.
294 (handle_single_display_spec, get_overlay_strings_1)
295 (push_display_prop): Fix initialization of paragraph direction for
296 string when that of the parent object is not yet determined.
297 (reseat_1): Call bidi_init_it to resync the bidi
298 iterator with IT's position. (Bug#7616)
299 (find_row_edges): If ROW->start.pos gives position
300 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
301 (handle_stop, back_to_previous_visible_line_start, reseat_1):
302 Reset the from_disp_prop_p flag.
303 (SAVE_IT, RESTORE_IT): New macros.
304 (pos_visible_p, face_before_or_after_it_pos)
305 (back_to_previous_visible_line_start)
306 (move_it_in_display_line_to, move_it_in_display_line)
307 (move_it_to, move_it_vertically_backward, move_it_by_lines)
308 (try_scrolling, redisplay_window, display_line): Use them when
309 saving a temporary copy of the iterator and restoring it back.
310 (back_to_previous_visible_line_start, reseat_1)
311 (init_iterator): Empty the bidi cache "stack".
312 (move_it_in_display_line_to): If iterator ended up at
313 EOL, but we never saw any buffer positions smaller than
314 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
315 motion in bidi-reordered lines.
316 (move_it_in_display_line_to): Record prev_method and prev_pos
317 immediately before the call to set_iterator_to_next. Fixes cursor
318 motion in bidi-reordered lines with stretch glyphs and strings
319 displayed in margins. (Bug#8133) (Bug#8867)
320 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
321 TO_CHARPOS.
322 (pos_visible_p): Support positions in bidi-reordered lines. Save
323 and restore bidi cache.
324
325 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
326 (bidi_paragraph_info): Delete unused struct.
327 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
328 (bidi_cache_start): New variable.
329 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
330 to zero.
331 (bidi_cache_fetch_state, bidi_cache_search)
332 (bidi_cache_find_level_change, bidi_cache_iterator_state)
333 (bidi_cache_find, bidi_peek_at_next_level)
334 (bidi_level_of_next_char, bidi_find_other_level_edge)
335 (bidi_move_to_visually_next): Compare cache index with
336 bidi_cache_start rather than with zero.
337 (bidi_fetch_char): Accept new argument STRING; all callers
338 changed. Support iteration over a string. Support strings with
339 display properties. Support unibyte strings. Fix the type of
340 `len' according to what STRING_CHAR_AND_LENGTH expects.
341 (bidi_paragraph_init, bidi_resolve_explicit_1)
342 (bidi_resolve_explicit, bidi_resolve_weak)
343 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
344 iteration over a string.
345 (bidi_set_sor_type, bidi_resolve_explicit_1)
346 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
347 can now be zero (for strings); special values 0 and -1 were
348 changed to -1 and -2, respectively.
349 (bidi_char_at_pos): New function.
350 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
351 Call it instead of FETCH_MULTIBYTE_CHAR.
352 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
353 initialized to valid values.
354 (bidi_init_it): Don't initialize charpos and bytepos with invalid
355 values.
356 (bidi_level_of_next_char): Allow the sentinel "position" to pass
357 the test for valid cached positions. Fix the logic for looking up
358 the sentinel state in the cache. GCPRO the Lisp string we are
359 iterating.
360 (bidi_push_it, bidi_pop_it): New functions.
361 (bidi_initialize): Initialize the bidi cache start stack pointer.
362 (bidi_cache_ensure_space): New function, refactored from part of
363 bidi_cache_iterator_state. Don't assume the required size is just
364 one BIDI_CACHE_CHUNK away.
365 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
366 (bidi_count_bytes, bidi_char_at_pos): New functions.
367 (bidi_cache_search): Don't assume bidi_cache_last_idx is
368 always valid if bidi_cache_idx is valid.
369 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
370 is valid if it's going to be used.
371 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
372 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
373 (bidi_cache_find_level_change, bidi_cache_ensure_space)
374 (bidi_cache_iterator_state, bidi_cache_find)
375 (bidi_find_other_level_edge, bidi_cache_start_stack): All
376 variables related to cache indices are now EMACS_INT.
377
0bb23927
EZ
378 * dispextern.h (struct bidi_string_data): New structure.
379 (struct bidi_it): New member `string'. Make flag members be 1-bit
380 fields, and put them last in the struct.
381 (compute_display_string_pos, compute_display_string_end): Update
382 prototypes.
383 (bidi_push_it, bidi_pop_it): Add prototypes.
384 (struct iterator_stack_entry): New members bidi_p,
385 paragraph_embedding, and from_disp_prop_p.
386 (struct it): Member bidi_p is now a bit field 1 bit wide.
387 (bidi_shelve_cache, bidi_unshelve_cache): Declare
388 prototypes.
389
390 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
391 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
392 and vector-like objects.
393
394 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
395 cache around display iteration.
396
397 * window.c (Fwindow_end, window_scroll_pixel_based)
398 (displayed_window_lines, Frecenter): Save and restore the bidi
399 cache around display iteration.
400
3bbd2265
LMI
4012011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
402
403 * editfns.c (Fdelete_region): Clarify the use of the named
404 parameters (bug#6788).
405
adc47434
MR
4062011-07-14 Martin Rudalics <rudalics@gmx.at>
407
408 * indent.c (Fvertical_motion): Set and restore w->pointm when
409 saving and restoring the window's buffer (Bug#9006).
410
837c31f8
LMI
4112011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
412
413 * editfns.c (Fstring_to_char): Clarify just what is returned
414 (bug#6576). Text by Eli Zaretskii.
415
ac389d0c
JB
4162011-07-13 Juanma Barranquero <lekktu@gmail.com>
417
418 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
419
0be0ce47
EZ
4202011-07-13 Eli Zaretskii <eliz@gnu.org>
421
422 * buffer.c (mmap_find): Fix a typo.
423
cd18e7e3
JB
4242011-07-13 Johan Bockgård <bojohan@gnu.org>
425
426 Fix execution of x selection hooks.
427 * xselect.c (Qx_lost_selection_functions)
428 (Qx_sent_selection_functions): New vars.
429 (syms_of_xselect): DEFSYM them.
430 (x_handle_selection_request): Pass Qx_sent_selection_functions
431 rather than Vx_sent_selection_functions to Frun_hook_with_args.
432 (x_handle_selection_clear,x_clear_frame_selections):
433 Pass Qx_lost_selection_functions rather than
434 Vx_lost_selection_functions to Frun_hook_with_args.
435
47ea7f44
PE
4362011-07-13 Paul Eggert <eggert@cs.ucla.edu>
437
ac389d0c 438 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
439 The old code sometimes used this field without initializing it.
440
47ea7f44
PE
441 * alloc.c (gc_sweep): Don't read past end of array.
442 In theory, the old code could also have corrupted Emacs internals,
443 though it'd be very unlikely.
444
bc985c87
AS
4452011-07-12 Andreas Schwab <schwab@linux-m68k.org>
446
447 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 448 argument. (Bug#4026)
bc985c87 449
0cf34688
LMI
4502011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
451
b3dadd76
LMI
452 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
453 key" (bug#4257).
454
0cf34688
LMI
455 * window.c (Fset_window_start): Doc fix (bug#4199).
456 (Fset_window_hscroll): Ditto.
457
270768cd
PE
4582011-07-12 Paul Eggert <eggert@cs.ucla.edu>
459
077e3dda 460 Fix minor new problems caught by GCC 4.6.1.
270768cd 461 * term.c (init_tty): Remove unused local.
490011a6 462 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 463 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 464 not used otherwise.
270768cd 465
b1f58454
CY
4662011-07-12 Chong Yidong <cyd@stupidchicken.com>
467
468 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
469
22b9578d
LMI
4702011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
471
6e70ab07
LMI
472 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
473 are the mini-buffer and the echo area (bug#3320).
474
22b9578d
LMI
475 * term.c (init_tty): Remove support for supdup, c10 and perq
476 terminals, which are no longer supported (bug#1482).
477
8974cc9f
JB
4782011-07-10 Johan Bockgård <bojohan@gnu.org>
479
480 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
481
a560d974
JD
4822011-07-10 Jan Djärv <jan.h.d@swipnet.se>
483
484 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
485 for non-popups (Bug#3642).
486
1dae0f0a
AS
4872011-07-10 Andreas Schwab <schwab@linux-m68k.org>
488
268c2c36 489 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 490 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
491 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
492 * cm.c (losecursor): Likewise.
1dae0f0a
AS
493 * data.c (fmod): Likewise.
494 * dispnew.c (swap_glyphs_in_rows): Likewise.
495 * emacs.c (memory_warning_signal): Likewise.
496 * floatfns.c (float_error): Likewise.
497 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
498 (otf_open, font_otf_capability, generate_otf_features)
499 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
500 Likewise.
501 * image.c (pbm_read_file): Likewise.
502 * indent.c (string_display_width): Likewise.
503 * intervals.c (check_for_interval, search_for_interval)
504 (inc_interval_count, count_intervals, root_interval)
505 (adjust_intervals_for_insertion, make_new_interval): Likewise.
506 * lread.c (defalias): Likewise.
268c2c36 507 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
508 * regex.c (set_image_of_range_1, set_image_of_range)
509 (regex_grow_registers): Likewise.
510 * sysdep.c (strerror): Likewise.
511 * termcap.c (valid_filename_p, tprint, main): Likewise.
512 * tparam.c (main): Likewise.
513 * unexhp9k800.c (run_time_remap, save_data_space)
514 (update_file_ptrs, read_header, write_header, calculate_checksum)
515 (copy_file, copy_rest, display_header): Likewise.
516 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
517 Likewise.
518 * xdisp.c (check_it): Likewise.
519 * xfaces.c (register_color, unregister_color, unregister_colors):
520 Likewise.
521 * xfns.c (print_fontset_result): Likewise.
522 * xrdb.c (member, fatal, main): Likewise.
523
99033785
PE
5242011-07-10 Paul Eggert <eggert@cs.ucla.edu>
525
526 Fix minor problems found by static checking (Bug#9031).
527 * chartab.c (char_table_set_range, map_sub_char_table):
528 Remove unused locals.
529 (uniprop_table): Now static.
530 * composite.c (_work_char): Remove unused static var.
531
9cb2ac56
JB
5322011-07-09 Juanma Barranquero <lekktu@gmail.com>
533
534 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
535
f25661f0
JD
5362011-07-09 Jan Djärv <jan.h.d@swipnet.se>
537
538 * gtkutil.c (qttip_cb): Remove code without function.
539
8278c4fe
EZ
5402011-07-09 Eli Zaretskii <eliz@gnu.org>
541
542 * w32.c (pthread_sigmask): New stub.
543
1692ae2d 5442011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 545
8a6ebd58 546 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
547 sigprocmask is portable only for single-threaded applications, and
548 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
549 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
550 (LIBES): Use it.
551 * callproc.c (Fcall_process):
552 * process.c (create_process):
553 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
554 Use pthread_sigmask, not sigprocmask.
123403e4 555
1b854618
JD
5562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
557
558 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
559 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
560 wrong (Bug#8591).
561
3fe4b549
JD
5622011-07-08 Jan Djärv <jan.h.d@swipnet.se>
563
0ce7e563
JD
564 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
565 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
566 (xg_hide_tooltip): Fix comment.
567
3fe4b549
JD
568 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
569 in registerServicesMenuSendTypes.
570 (validRequestorForSendType): Don't check ns_return_types.
571
572 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
573 ns_return_type.
574
5df75e47
JR
5752011-07-08 Jason Rumney <jasonr@gnu.org>
576
577 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
578 frame struct members of non-existent frames (Bug#6284).
579
699c10bd
JD
5802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
581
4393663b
JD
582 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
583 variable firstTime not needed on OSX >= 10.6.
584 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
585 >= 10.5. Use setKnobProportion, setDoubleValue.
586
587 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
588 (MAC_OS_X_VERSION_10_5): Define if not defined.
589 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
590 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
591 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
592
593 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
594 cString and lossyCString on OSX >= 10.4
595
596 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
597 sizeToFit on OSX >= 10.2.
598
599 * nsimage.m (allocInitFromFile): Don't use deprecated method
600 bestRepresentationForDevice on OSX >= 10.6.
601
602 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
603 to avoid warning.
604
605 * emacs.c: Declare unexec_init_emacs_zone.
606
a63e0781
JD
607 * nsgui.h: Fix compiler warning about gnulib redefining verify.
608
699c10bd
JD
609 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
610
611 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
612 on svcsMenu (Bug#8842).
613
614 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
615 ns_return_types.
616 (Fns_list_services): Just return Qnil on 10.6, code not working there.
617
618 * nsterm.m (QUTF8_STRING): Declare.
619 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
620 (validRequestorForSendType): Return type is (id).
621 Change indexOfObjectIdenticalTo to indexOfObject.
622 Check if we have local selection before returning self (Bug#8842).
623 (writeSelectionToPasteboard): Put local selection into paste board
624 if we have a local selection (Bug#8842).
625 (syms_of_nsterm): DEFSYM QUTF8_STRING.
626
627 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
628 (ns_get_local_selection): Declare.
629
54e10184
LMI
6302011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
631
9888ff71
LMI
632 * keymap.c (describe_map_tree): Don't insert a double newline at
633 the end of the buffer (bug#1169) and return whether we inserted
634 something.
635
54e10184
LMI
636 * callint.c (Fcall_interactively): Change "reading args" to
637 "providing args" to try to clarify what it does (bug#1010).
638
15fa4783
KH
6392011-07-07 Kenichi Handa <handa@m17n.org>
640
641 * composite.c (composition_compute_stop_pos): Ignore a static
642 composition starting before CHARPOS (Bug#8915).
643
644 * xdisp.c (handle_composition_prop): Likewise.
645
a8815b00
EZ
6462011-07-07 Eli Zaretskii <eliz@gnu.org>
647
648 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
649 (Bug#9015)
650
ef7b981d 6512011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
652
653 * character.h (unicode_category_t): New enum type.
654
655 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
656 (Qchar_code_property_table): New variable.
657 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
658 (UNIPROP_COMPRESSED_FORM_P): New macros.
659 (char_table_ascii): Uncompress the compressed values.
660 (sub_char_table_ref): New arg is_uniprop. Callers changed.
661 Uncompress the compressed values.
ac389d0c 662 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
663 (char_table_ref_and_range): Uncompress the compressed values.
664 (sub_char_table_set): New arg is_uniprop. Callers changed.
665 Uncompress the compressed values.
666 (sub_char_table_set_range): Args changed. Callers changed.
667 (char_table_set_range): Adjuted for the above change.
668 (map_sub_char_table): Delete args default_val and parent. Add arg
669 top. Give decoded values to a Lisp function.
670 (map_char_table): Adjusted for the above change. Give decoded
671 values to a Lisp function. Gcpro more variables.
672 (uniprop_table_uncompress)
673 (uniprop_decode_value_run_length): New functions.
674 (uniprop_decoder, uniprop_decoder_count): New variables.
675 (uniprop_get_decoder, uniprop_encode_value_character)
676 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
677 New functions.
678 (uniprop_encoder, uniprop_encoder_count): New variables.
679 (uniprop_get_encoder, uniprop_table)
680 (Funicode_property_table_internal, Fget_unicode_property_internal)
681 (Fput_unicode_property_internal): New functions.
682 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
683 Sunicode_property_table_internal, Sget_unicode_property_internal,
684 and Sput_unicode_property_internal. Defvar_lisp
685 char-code-property-alist.
686
687 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
688 Vunicode_category_table.
689
690 * font.c (font_range): Adjusted for the change of
691 Vunicode_category_table.
692
76b397fb
DN
6932011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
694
695 * m/iris4d.h: Remove file, move contents ...
696 * s/irix6-5.h: ... here.
697
22b4128e
PE
6982011-07-06 Paul Eggert <eggert@cs.ucla.edu>
699
700 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
701 * alloc.c (mark_buffer):
702 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
703 (clone_per_buffer_values): Don't assume that
22b4128e
PE
704 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
705 This isn't true in general, and it's particularly not true
706 if Emacs is configured with --with-wide-int.
707 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
708 New macros, used in the buffer.c change.
709
869795d6
JD
7102011-07-05 Jan Djärv <jan.h.d@swipnet.se>
711
712 * xsettings.c: Use both GConf and GSettings if both are available.
713 (store_config_changed_event): Add comment.
714 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
715 (store_tool_bar_style_changed): New functions.
716 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
717 (struct xsettings): Move font inside HAVE_XFT.
718 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
719 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
720 Move inside HAVE_XFT.
721 (something_changed_gsettingsCB): Renamed from something_changedCB.
722 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
723 also.
724 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
725 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
726 (something_changed_gconfCB): Renamed from something_changedCB.
727 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
728 (parse_settings): Move check for font inside HAVE_XFT.
729 (read_settings, apply_xft_settings): Add comment.
730 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
731 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
732 call store_font_name_changed.
733 (xft_settings_event): Add comment.
734 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
735 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
736 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
737 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
738 (xsettings_initialize): Call init_gsettings last.
739 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
740 comment.
741
d8ed26bd
PE
7422011-07-05 Paul Eggert <eggert@cs.ucla.edu>
743
744 Random fixes. E.g., (random) never returned negative values.
745 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
746 subseconds part to the entropy, as that's a bit more random.
747 Prefer signed to unsigned, since the signedness doesn't matter and
748 in general we prefer signed. When given a limit, use a
749 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
750 latter isn't right if USE_2_TAGS_FOR_INTS.
751 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
752 not 0..VALMASK. Don't discard "excess" bits that random () returns.
753
cabf1cac
SM
7542011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
755
756 * textprop.c (text_property_stickiness):
757 Obey Vtext_property_default_nonsticky.
758 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
759 * w32fns.c (syms_of_w32fns):
760 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
761
6e9b2be9
PE
7622011-07-04 Paul Eggert <eggert@cs.ucla.edu>
763
764 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
765 This is more efficient than Ffile_directory_p and avoids a minor race.
766
90186c68
LMI
7672011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
768
7c301272
LMI
769 * buffer.c (Foverlay_put): Say what the return value is
770 (bug#7835).
771
c4f2d8d4
LMI
772 * fileio.c (barf_or_query_if_file_exists): Check first if the file
773 is a directory before asking whether to use the file name
774 (bug#7564).
ad637907
LMI
775 (barf_or_query_if_file_exists): Make the "File is a directory"
776 error be more correct.
c4f2d8d4 777
90186c68
LMI
778 * fns.c (Frequire): Remove the mention of the .gz files, since
779 that's installation-specific, but keep the mention of
780 `get-load-suffixes'.
781
da64016e
PE
7822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
783
784 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
785 Report string overflow if the output is too long.
786
7d47b580
JB
7872011-07-04 Juanma Barranquero <lekktu@gmail.com>
788
a555cb87
JB
789 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
790 (syms_of_gnutls): Remove duplicate DEFSYM for
791 Qgnutls_bootprop_verify_hostname_error, an error for
792 Qgnutls_bootprop_verify_error (which is no longer used).
793
7d47b580
JB
794 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
795 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
796 Also (re)move comments that are misplaced or no longer relevant.
797
1e49bfab
LMI
7982011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
799
800 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
801
1485f4c0
CY
8022011-07-03 Chong Yidong <cyd@stupidchicken.com>
803
804 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
805 and background color parameters if they have been changed.
806
a9ab721e
LMI
8072011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
808
809 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
810
cf7cff57
PE
8112011-07-03 Paul Eggert <eggert@cs.ucla.edu>
812
2e13213d
PE
813 * xsettings.c (SYSTEM_FONT): Define only when used.
814 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
815
cf7cff57
PE
816 * keymap.c (access_keymap_1): Now static.
817
7a8e04f7
CY
8182011-07-02 Chong Yidong <cyd@stupidchicken.com>
819
820 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
821 leave any prefix arg for the up event (Bug#1586).
822
61352f62
LMI
8232011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
824
69bb1ef7
LMI
825 * lread.c (syms_of_lread): Mention single symbols defined by
826 `defvar' or `defconst' (bug#7154).
827
61352f62 828 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 829 (Frequire): Mention get-load-suffixes.
61352f62 830
28545e04
MR
8312011-07-02 Martin Rudalics <rudalics@gmx.at>
832
833 * window.h (window): Remove clone_number slot.
834 * window.c (Fwindow_clone_number, Fset_window_clone_number):
835 Remove.
836 (make_parent_window, make_window, saved_window)
837 (Fset_window_configuration, save_window_save): Don't deal with
838 clone numbers.
839 * buffer.c (Qclone_number): Remove declaration.
840 (sort_overlays, overlay_strings): Don't deal with clone numbers.
841
3349e122
SM
8422011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
843
844 Add multiple inheritance to keymaps.
845 * keymap.c (Fmake_composed_keymap): New function.
846 (Fset_keymap_parent): Simplify.
847 (fix_submap_inheritance): Remove.
848 (access_keymap_1): New function extracted from access_keymap to handle
849 embedded parents and handle lists of maps.
850 (access_keymap): Use it.
851 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
852 (Fcopy_keymap): Handle embedded parents.
853 (Fcommand_remapping, define_as_prefix): Simplify.
854 (Fkey_binding): Simplify.
855 (syms_of_keymap): Move minibuffer-local-completion-map,
856 minibuffer-local-filename-completion-map,
857 minibuffer-local-must-match-map, and
858 minibuffer-local-filename-must-match-map to Elisp.
859 (syms_of_keymap): Defsubr make-composed-keymap.
860 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
861 (parse_menu_item): Trivial simplification.
862
3279eb87
GM
8632011-07-01 Glenn Morris <rgm@gnu.org>
864
865 * Makefile.in (SETTINGS_LIBS): Fix typo.
866
4550efdf
KI
8672011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
868
869 * coding.c (Fencode_coding_string): Record the last coding system
870 used, as the function doc string says (bug#8738).
871
0949d2b6
JD
8722011-07-01 Jan Djärv <jan.h.d@swipnet.se>
873
874 * xsettings.c (store_monospaced_changed): Take new font as arg and
875 check for change against current_mono_font.
876 (EMACS_TYPE_SETTINGS): Remove this and related defines.
877 (emacs_settings_constructor, emacs_settings_get_property)
878 (emacs_settings_set_property, emacs_settings_class_init)
879 (emacs_settings_init, gsettings_obj): Remove.
880 (something_changedCB): New function for HAVE_GSETTINGS.
881 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
882 with value as argument.
883 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
884 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 885 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
886 "changed".
887
888 * xgselect.c: Add defined (HAVE_GSETTINGS).
889 (xgselect_initialize): Ditto.
890
891 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
892 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
893 xg_select.
894
bbc6b304
PE
8952011-07-01 Paul Eggert <eggert@cs.ucla.edu>
896
897 * eval.c (struct backtrace): Simplify and port the data structure.
898 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
899 signed bit field, as this assumption is not portable and it makes
900 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
901 "char debug_on_exit : 1" as this is not portable either; instead,
902 use the portable "unsigned int debug_on_exit : 1". Remove unused
903 member evalargs. Remove obsolete comments about cc bombing out.
904
9851bfc5
JD
9052011-06-30 Jan Djärv <jan.h.d@swipnet.se>
906
51bb811f 907 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
908 Let HAVE_GSETTINGS override HAVE_GCONF.
909 (store_monospaced_changed): New function.
910 (EMACS_SETTINGS): A new type derived from GObject to handle
911 GSettings notifications.
912 (emacs_settings_constructor, emacs_settings_get_property)
913 (emacs_settings_set_property, emacs_settings_class_init):
914 New functions.
915 (gsettings_client, gsettings_obj): New variables.
916 (GSETTINGS_SCHEMA): New define.
917 (something_changedCB): Call store_monospaced_changed.
918 (init_gsettings): New function.
919 (xsettings_initialize): Call init_gsettings.
920 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
921 to NULL.
922
923 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
924 GCONF_CFLAGS/LIBS.
925
5386012d
MR
9262011-06-29 Martin Rudalics <rudalics@gmx.at>
927
928 * window.c (resize_root_window, grow_mini_window)
929 (shrink_mini_window): Rename Qresize_root_window to
930 Qwindow_resize_root_window and Qresize_root_window_vertically to
931 Qwindow_resize_root_window_vertically.
932
f13e0b08
PE
9332011-06-28 Paul Eggert <eggert@cs.ucla.edu>
934
935 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
936
94515237
JB
9372011-06-27 Juanma Barranquero <lekktu@gmail.com>
938
939 * makefile.w32-in: Redesign dependencies so they reflect more
940 clearly which files are directly included by each source file,
941 and not through other includes.
942
e43b6e43
MR
9432011-06-27 Martin Rudalics <rudalics@gmx.at>
944
945 * buffer.c (Qclone_number): Declare static and DEFSYM it.
946 (sort_overlays, overlay_strings): When an overlay's clone number
947 matches the window's clone number process the overlay even if
948 the overlay's window property doesn't match the current window.
949
d68443dc
MR
950 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
951 (Fwindow_hchild): Rename to Fwindow_left_child.
952 (Fwindow_next): Rename to Fwindow_next_sibling.
953 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
954 (resize_window_check): Rename to window_resize_check.
955 (resize_window_apply): Rename to window_resize_apply.
956 (Fresize_window_apply): Rename to Fwindow_resize_apply.
957 (Fdelete_other_windows_internal, resize_frame_windows)
958 (Fsplit_window_internal, Fdelete_window_internal)
959 (grow_mini_window, shrink_mini_window)
960 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 961
c7e73be5
JD
9622011-06-26 Jan Djärv <jan.h.d@swipnet.se>
963
964 * emacsgtkfixed.h: State that this is only used with Gtk+3.
965 (emacs_fixed_set_min_size): Remove.
966 (emacs_fixed_new): Take frame as argument.
967
968 * emacsgtkfixed.c: State that this is only used with Gtk+3.
969 (_EmacsFixedPrivate): Remove minwidth/height.
970 Add struct frame *f.
971 (emacs_fixed_init): Initialize priv->f.
972 (get_parent_class, emacs_fixed_set_min_size): Remove.
973 (emacs_fixed_new): Set priv->f to argument.
974 (emacs_fixed_get_preferred_width)
975 (emacs_fixed_get_preferred_height): Use min_width/height from
976 frames size_hint to set minimum and natural (Bug#8919).
977 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
978 and use min_width/height from frames size_hint to set
979 min_width/height (Bug#8919).
980
981 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
982 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
983 Fix indentation.
c7e73be5 984
cf99dcf8
EZ
9852011-06-26 Eli Zaretskii <eliz@gnu.org>
986
987 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
988 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
989 called at ZV.
990
029529ac
CY
9912011-06-26 Chong Yidong <cyd@stupidchicken.com>
992
993 * process.c (wait_reading_process_output): Bypass select if
994 waiting for a cell while ignoring keyboard input, and input is
995 pending. Suggested by Jan Djärv (Bug#8869).
996
7a7ef429
PE
9972011-06-25 Paul Eggert <eggert@cs.ucla.edu>
998
999 Use gnulib's dup2 module instead of rolling our own.
1000 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1001
11fdef7d 10022011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1003
1004 * dispnew.c (scrolling_window): Before scrolling, turn off a
1005 mouse-highlight in the window being scrolled.
1006
cd3520a4
JB
10072011-06-24 Juanma Barranquero <lekktu@gmail.com>
1008
1009 Move DEFSYM to lisp.h and use everywhere.
1010
1011 * character.h (DEFSYM): Move declaration...
1012 * lisp.h (DEFSYM): ...here.
1013
1014 * gnutls.c:
1015 * minibuf.c:
1016 * w32menu.c:
1017 * w32proc.c:
1018 * w32select.c: Don't include character.h.
1019
1020 * alloc.c (syms_of_alloc):
1021 * buffer.c (syms_of_buffer):
1022 * bytecode.c (syms_of_bytecode):
1023 * callint.c (syms_of_callint):
1024 * casefiddle.c (syms_of_casefiddle):
1025 * casetab.c (init_casetab_once):
1026 * category.c (init_category_once, syms_of_category):
1027 * ccl.c (syms_of_ccl):
1028 * cmds.c (syms_of_cmds):
1029 * composite.c (syms_of_composite):
1030 * dbusbind.c (syms_of_dbusbind):
1031 * dired.c (syms_of_dired):
1032 * dispnew.c (syms_of_display):
1033 * doc.c (syms_of_doc):
1034 * editfns.c (syms_of_editfns):
1035 * emacs.c (syms_of_emacs):
1036 * eval.c (syms_of_eval):
1037 * fileio.c (syms_of_fileio):
1038 * fns.c (syms_of_fns):
1039 * frame.c (syms_of_frame):
1040 * fringe.c (syms_of_fringe):
1041 * insdel.c (syms_of_insdel):
1042 * keymap.c (syms_of_keymap):
1043 * lread.c (init_obarray, syms_of_lread):
1044 * macros.c (syms_of_macros):
1045 * msdos.c (syms_of_msdos):
1046 * print.c (syms_of_print):
1047 * process.c (syms_of_process):
1048 * search.c (syms_of_search):
1049 * sound.c (syms_of_sound):
1050 * syntax.c (init_syntax_once, syms_of_syntax):
1051 * terminal.c (syms_of_terminal):
1052 * textprop.c (syms_of_textprop):
1053 * undo.c (syms_of_undo):
1054 * w32.c (globals_of_w32):
1055 * window.c (syms_of_window):
1056 * xdisp.c (syms_of_xdisp):
1057 * xfaces.c (syms_of_xfaces):
1058 * xfns.c (syms_of_xfns):
1059 * xmenu.c (syms_of_xmenu):
1060 * xsettings.c (syms_of_xsettings):
1061 * xterm.c (syms_of_xterm): Use DEFSYM.
1062
4228cf16
TZ
10632011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1064
cd3520a4 1065 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1066
7fcccf1e
PE
10672011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1068
7efb4e0e
PE
1069 Integer and buffer overflow fixes (Bug#8873).
1070
ff5844ad
PE
1071 * print.c (printchar, strout): Check for string overflow.
1072 (PRINTPREPARE, printchar, strout):
1073 Don't set size unless allocation succeeds.
1074
90532f02
PE
1075 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1076 for sizes. Check for string overflow more accurately.
1077 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1078
6d84508d
PE
1079 * macros.c: Integer and buffer overflow fixes.
1080 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1081 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1082 Use ptrdiff_t, not int, for sizes.
1083 Don't increment bufsize until after realloc succeeds.
1084 Check for size-calculation overflow.
1085 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1086
437b2cb4
PE
1087 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1088
8b9ac8b4
PE
1089 * lread.c: Integer overflow fixes.
1090 (read_integer): Radix is now EMACS_INT, not int,
1091 to improve quality of diagnostics for out-of-range radices.
1092 Calculate buffer size correctly for out-of-range radices.
1093 (read1): Check for integer overflow in radices, and in
1094 read-circle numbers.
82cb60d3
PE
1095 (read_escape): Avoid int overflow.
1096 (Fload, openp, read_buffer_size, read1)
1097 (substitute_object_recurse, read_vector, read_list, map_obarray):
1098 Use ptrdiff_t, not int, for sizes.
1099 (read1): Use EMACS_INT, not int, for sizes.
20270765 1100 Check for size overflow.
8b9ac8b4 1101
7fcccf1e
PE
1102 * image.c (cache_image): Check for size arithmetic overflow.
1103
bfbbd7e7
PE
1104 * lread.c: Integer overflow issues.
1105 (saved_doc_string_size, saved_doc_string_length)
1106 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1107 Now ptrdiff_t, not int.
1108 (read1): Don't assume doc string length fits in int. Check for
1109 out-of-range doc string lengths.
1110 (read_list): Don't assume file position fits in int.
39019e54 1111 (read_escape): Check for hex character overflow.
bfbbd7e7 1112
4e323265
LL
11132011-06-22 Leo Liu <sdl.web@gmail.com>
1114
1115 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1116 Move to minibuffer.el.
1117
85fece3e
PE
11182011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1119
20b84ce9 1120 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1121 The following patches are for when GLYPH_DEBUG && !XASSERT.
1122 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1123 * dispnew.c (flush_stdout):
1124 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1125 Mark as externally visible.
1126 * dispnew.c (check_window_matrix_pointers): Now static.
1127 * dispnew.c (window_to_frame_vpos):
1128 * xfns.c (unwind_create_frame):
1129 * xterm.c (x_check_font): Remove unused local.
1130 * scroll.c (CHECK_BOUNDS):
1131 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1132 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1133 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1134 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1135 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1136 Now static.
1137 (debug_method_add): Use va_list and vsprintf rather than relying
1138 on undefined behavior with wrong number of arguments.
1139 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1140 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1141 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1142 since we're not interested in debugging glyphs with old libraries.
1143 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1144 GCC 4.6.0's static checking.
1145
0766b489
PE
11462011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1147
31fd4b32
PE
1148 Integer overflow and signedness fixes (Bug#8873).
1149 A few related buffer overrun fixes, too.
1150
b79e8648
PE
1151 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1152
0766b489
PE
1153 * dispextern.h (struct face.stipple):
1154 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1155 (x_bitmap_mask, x_allocate_bitmap_record)
1156 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1157 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1158 (x_create_bitmap_from_xpm_data):
1159 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1160 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1161 (.bitmaps_last):
1162 * xfaces.c (load_pixmap):
1163 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1164 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1165 (.bitmaps_last, struct x_output.icon_bitmap):
1166 Use ptrdiff_t, not int, for bitmap indexes.
1167 (x_allocate_bitmap_record): Check for size overflow.
1168 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1169
b081724f
PE
1170 Use ptrdiff_t, not int, for overlay counts.
1171 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1172 * editfns.c (overlays_around, get_pos_property):
1173 * textprop.c (get_char_property_and_overlay):
1174 * xdisp.c (next_overlay_change, note_mouse_highlight):
1175 * xfaces.c (face_at_buffer_position):
21514da7
PE
1176 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1177 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1178 (Fnext_overlay_change, Fprevious_overlay_change)
1179 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1180 Use ptrdiff_t, not int, for sizes.
21514da7 1181 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1182
3de73e5e
PE
1183 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1184
2606c57b
PE
1185 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1186 (x_session_initialize): Do not assume string length fits in int.
1187
aaafe47a
PE
1188 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1189 This is unlikely, but can occur if DPI is outlandish.
1190
2674ddc8 1191 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1192 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1193
28154962
PE
1194 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1195 * xrdb.c (magic_file_p, search_magic_path):
1196 Omit last arg SUFFIX; it was always 0. All callers changed.
1197 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1198
7de51af5
PE
1199 * xfont.c (xfont_match): Avoid need for strlen.
1200
25ed6cc3
PE
1201 * xfns.c: Don't assume strlen fits in int.
1202 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1203
4eab31dd
PE
1204 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1205 not unsigned long, as we prefer signed integers. All callers changed.
1206 Detect integer overflow in repeat count.
1207 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1208 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1209
171e2a58
PE
1210 * termcap.c: Don't assume sizes fit in int and never overflow.
1211 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1212 (gobble_line): Check for size-calculation overflow.
1213
ad39faca 1214 * minibuf.c (Fread_buffer):
6e5bb2dc 1215 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1216 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1217 Don't assume string length fits in int.
1218
52c61c22 1219 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1220 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1221
b5b8c9e5
PE
1222 * font.c: Don't assume string length fits in int.
1223 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1224 Use ptrdiff_t, not int.
ccd6111c
PE
1225 (font_intern_prop): Don't assume string length fits in int.
1226 Don't assume integer property fits in fixnum.
1227 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1228
882f0d81 1229 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1230 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1231 Reformulate so as not to need the command string.
1232 Invoke gzip -cd rather than gunzip, as it's more portable.
1233 (lock_info_type, lock_file_1, lock_file):
1234 Don't assume pid_t and time_t fit in unsigned long.
1235 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1236 (current_lock_owner): Prefer signed type for sizes.
1237 Use memcpy, not strncpy, where memcpy is what is really wanted.
1238 Don't assume (via atoi) that time_t and pid_t fit in int.
1239 Check for time_t and/or pid_t out of range, e.g., via a network share.
1240 Don't alloca where an auto var works fine.
1241
93f4cf88
PE
1242 * fileio.c: Fix some integer overflow issues.
1243 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1244 Don't assume string length fits in int.
1245 (directory_file_name): Don't assume string length fits in long.
1246 (make_temp_name): Don't assume pid fits in int, or that its print
1247 length is less than 20.
1248
f3e92b69
PE
1249 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1250
1bfdaf10
PE
1251 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1252
35016e9a
PE
1253 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1254
3d1e65a1
PE
1255 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1256 We prefer signed integers, even for size calculations.
1257
0b963a93
PE
1258 * emacs.c: Don't assume string length fits in 'int'.
1259 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1260 (main): Don't invoke strlen when not needed.
1261
573f4b54
PE
1262 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1263 (XD_DEBUG_MESSAGE): Don't waste a byte.
1264
989f33ba
PE
1265 * callproc.c (getenv_internal_1, getenv_internal)
1266 (Fgetenv_internal):
965d34eb
PE
1267 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1268
e4d29b33
PE
1269 * lread.c (invalid_syntax): Omit length argument.
1270 All uses changed. This doesn't fix a bug, but it simplifies the
1271 code away from its former Hollerith-constant appearance, and it's
1272 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1273 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1274
eb49b136
PE
1275 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1276 This didn't break anything, but it didn't help either.
1277 It's confusing to put a bogus integer in a place where the actual
1278 value does not matter.
9f62aeb1 1279 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1280 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1281
15375a22
PE
1282 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1283 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1284 implementation.
b61cc01c
PE
1285 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1286 We prefer signed types, and the value cannot exceed the EMACS_INT
1287 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1288 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1289 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1290 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1291
53b2623d
PE
1292 * indent.c (sane_tab_width): New function.
1293 (current_column, scan_for_column, Findent_to, position_indentation)
1294 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1295 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1296
51cab52b 1297 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1298
f2ed8a70
PE
1299 * lisp.h (lint_assume): New macro.
1300 * composite.c (composition_gstring_put_cache):
1301 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1302
abe80cc6
PE
1303 * editfns.c, insdel.c:
1304 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1305
b02c740e
PE
1306 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1307
ebc96716
PE
1308 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1309
b4e50fa0 1310 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1311 Use much-faster test for byte-length change.
311d5d7c 1312 Don't assume string byte-length fits in 'int'.
a4cf38e4 1313 Check that character arg fits in 'int'.
85461888 1314 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1315
c0c1ee9f
PE
1316 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1317
a498d7f4
PE
1318 * fns.c (concat): Catch string overflow earlier.
1319 Do not rely on integer wraparound.
1320
51cab52b
PE
1321 * dispextern.h (struct it.overlay_strings_charpos)
1322 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1323 * xdisp.c (forward_to_next_line_start)
1324 (back_to_previous_visible_line_start)
1325 (reseat_at_next_visible_line_start, next_element_from_buffer):
1326 Don't arbitrarily truncate the value of 'selective' to int.
1327
76031fad
PE
1328 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1329
5eb55db9
PE
1330 * composite.c: Don't truncate sizes to 'int'.
1331 (composition_gstring_p, composition_reseat_it)
1332 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1333 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1334 not EMACS_UINT, for indexes.
5eb55db9 1335
0703a717
PE
1336 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1337
d6202519
PE
1338 * buffer.c: Include <verify.h>.
1339 (struct sortvec.priority, struct sortstr.priority):
8961a454 1340 Now EMACS_INT, not int.
c20998a7 1341 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1342 (struct sortstr.size, record_overlay_string)
1343 (struct sortstrlist.size, struct sortlist.used):
1344 Don't truncate size to int.
1345 (record_overlay_string): Check for size-calculation overflow.
d6202519 1346 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1347
d5a19415
JM
13482011-06-22 Jim Meyering <meyering@redhat.com>
1349
029529ac 1350 Don't leak an XBM-image-sized buffer
d5a19415
JM
1351 * image.c (xbm_load): Free the image buffer after using it.
1352
a9041e6c
PE
13532011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1354
1355 Port to Sun C.
1356 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1357 that Sun C diagnosed.
1358 * fns.c (secure_hash): Fix pointer signedness issue.
1359 * intervals.c (static_offset_intervals): New function.
1360 (offset_intervals): Use it.
1361
7f3f739f
LL
13622011-06-21 Leo Liu <sdl.web@gmail.com>
1363
1364 * deps.mk (fns.o):
1365 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1366 sha512.h.
1367
1368 * fns.c (secure_hash): Rename from crypto_hash_function and change
1369 the first arg to accept symbols.
5b66d427 1370 (Fsecure_hash): New primitive.
7f3f739f
LL
1371 (syms_of_fns): New symbols.
1372
76147d94
DD
13732011-06-20 Deniz Dogan <deniz@dogan.se>
1374
1375 * process.c (Fset_process_buffer): Clarify return value in
1376 docstring.
1377
7d7d0045
CY
13782011-06-18 Chong Yidong <cyd@stupidchicken.com>
1379
1380 * dispnew.c (add_window_display_history): Use BVAR.
1381
1382 * xdisp.c (debug_method_add): Use BVAR.
1383 (check_window_end, dump_glyph_matrix, dump_glyph)
1384 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1385
1386 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1387 Likewise.
1388
1389 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1390 check till after the cache is created in init_frame_faces.
1391
ff2bc410
SM
13922011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1393
1394 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1395
28177add
PE
13962011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1397
dd3482fe
PE
1398 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1399 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1400 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1401
393d71f3 1402 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1403 * fileio.c (Finsert_file_contents):
1404 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1405 Remove the old (too-loose) buffer overflow checks.
1406 They weren't needed, since make_gap checks for buffer overflow.
1407 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1408 The old code merely checked for Emacs fixnum overflow, and relied
1409 on undefined (wraparound) behavior. The new code avoids undefined
1410 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1411
2e6813b0 1412 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1413 Tune. Don't use wider integers than needed. Don't use alloca.
1414 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1415
599a9e4f
PE
1416 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1417
99561444
PE
1418 * insdel.c, lisp.h (buffer_overflow): New function.
1419 (insert_from_buffer_1, replace_range, replace_range_2):
1420 * insdel.c (make_gap_larger):
1421 * editfns.c (Finsert_char):
1422 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1423
28177add
PE
1424 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1425
e69dafad
PE
14262011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1427
a7af7fde 1428 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1429
b1c46f02
PE
1430 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1431 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1432
e69dafad
PE
1433 * fileio.c: Don't assume EMACS_INT fits in off_t.
1434 (emacs_lseek): New static function.
1435 (Finsert_file_contents, Fwrite_region): Use it.
1436 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1437
566684ea
PE
1438 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1439
e6966cd6
PE
1440 * fns.c: Don't overflow int when computing a list length.
1441 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1442 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1443 truncation on 64-bit hosts. Check for QUIT every
1444 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1445 faster and is responsive enough.
1446 (Flength): Report an error instead of overflowing an integer.
1447 (Fsafe_length): Return a float if the value is not representable
1448 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1449 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1450 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1451
dd0b0efb
PE
1452 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1453 (header_size, word_size): New constants.
1454 (allocate_vectorlike): Don't check size overflow here.
1455 (allocate_vector): Check it here instead, since this is the only
1456 caller of allocate_vectorlike that could cause overflow.
1457 Check that the new vector's length is representable as a fixnum.
1458
86fe5cfe
PE
1459 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1460 The previous code was bogus. For example, next_almost_prime (32)
1461 returned 39, which is undesirable as it is a multiple of 3; and
1462 next_almost_prime (24) returned 25, which is a multiple of 5 so
1463 why was the code bothering to check for multiples of 7?
1464
80e88859
PE
1465 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1466
4a2f0ad6
PE
1467 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1468
f66c7cf8
PE
1469 Variadic C functions now count arguments with ptrdiff_t.
1470 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1471 Back then I didn't know that the Emacs coding style prefers signed int.
1472 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1473 were being counted with int, which may truncate counts on 64-bit
1474 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1475 * lisp.h (struct Lisp_Subr.function.aMANY)
1476 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1477 Arg counts are now ptrdiff_t, not size_t.
1478 All variadic functions and their callers changed accordingly.
1479 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1480 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1481 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1482 * callint.c (Fcall_interactively): Check arg count for overflow,
1483 to avoid potential buffer overrun. Use signed char, not 'int',
1484 for 'varies' array, so that we needn't bother to check its size
1485 calculation for overflow.
1486 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1487 * eval.c (apply_lambda):
1488 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1489 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1490 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1491
a1759b76
PE
1492 * callint.c (Fcall_interactively): Don't use index var as event count.
1493
d96be9fc
PE
1494 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1495 * mem-limits.h (SIZE): Remove; no longer used.
1496
a690a978 1497 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1498
578c21e6
PE
1499 Remove unnecessary casts.
1500 * xterm.c (x_term_init):
1501 * xfns.c (x_set_border_pixel):
1502 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1503 These aren't needed now that we assume ANSI C.
1504
96f53c6c
PE
1505 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1506 It's more likely to cause problems (due to unsigned overflow)
1507 than to cure them.
1508
83c77d31
PE
1509 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1510
ee2079f1
PE
1511 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1512
6da65536
PE
1513 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1514
7147c4a4
PE
1515 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1516
193e32d9
PE
1517 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1518
e5533da6
PE
1519 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1520
9910e595
PE
1521 GLYPH_CODE_FACE returns EMACS_INT, not int.
1522 * dispextern.h (merge_faces):
1523 * xfaces.c (merge_faces):
01103c44
PE
1524 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1525 Don't assume EMACS_INT fits in int.
9910e595 1526
2638320e
PE
1527 * character.h (CHAR_VALID_P): Remove unused parameter.
1528 * fontset.c, lisp.h, xdisp.c: All uses changed.
1529
045eb8d9
PE
1530 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1531
c1f134b5
PE
1532 * fns.c (concat): Minor tuning based on overflow analysis.
1533 This doesn't fix any bugs. Use int to hold character, instead
1534 of constantly refetching from Emacs object. Use XFASTINT, not
1535 XINT, for value known to be a character. Don't bother comparing
1536 a single byte to 0400, as it's always less.
1537
395fcb93 1538 * floatfns.c (Fexpt):
327eeec8
PE
1539 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1540
abbd3d23
PE
1541 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1542 for characters.
1543
684a03ef
PE
1544 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1545
0fed43f3
PE
1546 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1547 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1548 incorrectly succeed when S was a string, because 4294967386 was
1549 truncated before it was used.
1550
8fd02eb7
PE
1551 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1552 Otherwise, an out-of-range integer could cause undefined behavior
1553 on a 64-bit host.
1554
f8c86b69
PE
1555 * composite.c: Use int, not EMACS_INT, for characters.
1556 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1557 EMACS_INT, for values that are known to be in character range.
1558 This doesn't fix any bugs but is the usual style inside Emacs and
1559 may generate better code on 32-bit machines.
1560
34206dd2
PE
1561 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1562 This is for reasons similar to the recent CHAR_STRING fix.
1563 * charset.c (Fencode_char): Check that character arg is actually
1564 a character. Pass an int to ENCODE_CHAR.
1565 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1566 wider than 'int', as a compile-time check to prevent future regressions
1567 in this area.
1568
c5958d4c 1569 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1570
1571 Make sure a 64-bit char is never passed to CHAR_STRING.
1572 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1573 by silently ignoring the top 32 bits, allowing some values
1574 that were far too large to be valid characters.
1575 * character.h: Include <verify.h>.
1576 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1577 arguments are no wider than unsigned, as a compile-time check
1578 to prevent future regressions in this area.
1579 * data.c (Faset):
01103c44 1580 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1581 (Fsubst_char_in_region):
1582 * fns.c (concat):
1583 * xdisp.c (decode_mode_spec_coding):
1584 Adjust to CHAR_STRING's new requirement.
1585 * editfns.c (Finsert_char, Fsubst_char_in_region):
1586 * fns.c (concat): Check that character args are actually
1587 characters. Without this test, these functions did the wrong
1588 thing with wildly out-of-range values on 64-bit hosts.
1589
d37ca623
PE
1590 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1591 These casts should not be needed on 32-bit hosts, either.
1592 * keyboard.c (read_char):
1593 * lread.c (Fload): Remove casts to unsigned.
1594
ea204efb
PE
1595 * lisp.h (UNSIGNED_CMP): New macro.
1596 This fixes comparison bugs on 64-bit hosts.
1597 (ASCII_CHAR_P): Use it.
1598 * casefiddle.c (casify_object):
01103c44 1599 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1600 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1601 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1602 * dispextern.h (FACE_FROM_ID):
1603 * keyboard.c (read_char): Use UNSIGNED_CMP.
1604
41cb286c
PE
1605 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1606 not to EMACS_INT, to avoid GCC warning.
1607
4a1b9832
PE
1608 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1609
55daad71
PE
1610 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1611 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1612 isn't needed on 32-bit machines.
8f95c75c 1613
01103c44
PE
1614 * buffer.c (Fgenerate_new_buffer_name):
1615 Use EMACS_INT for count, not int.
0ceccced 1616 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1617
1618 * data.c (Qcompiled_function): Now static.
1619
c6f072e7
PE
1620 * window.c (window_body_lines): Now static.
1621
20ce5912
PE
1622 * image.c (gif_load): Rename local to avoid shadowing.
1623
9c4c5f81
PE
1624 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1625 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1626 * alloc.c (make_save_value): Integer argument is now of type
1627 ptrdiff_t, not int.
1628 (mark_object): Use ptrdiff_t, not int.
1629 * lisp.h (pD): New macro.
1630 * print.c (print_object): Use it.
1631
c0c5c8ae
PE
1632 * alloc.c: Use EMACS_INT, not int, to count objects.
1633 (total_conses, total_markers, total_symbols, total_vector_size)
1634 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1635 (total_free_floats, total_floats, total_free_intervals)
1636 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1637 Now EMACS_INT, not int. All uses changed.
1638 (Fgarbage_collect): Compute overall total using a double, so that
1639 integer overflow is less likely to be a problem. Check for overflow
1640 when converting back to an integer.
5a25e253
PE
1641 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1642 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1643 These were 'int' variables that could overflow on 64-bit hosts;
1644 they were never used, so remove them instead of repairing them.
211a0b2a 1645 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1646 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1647 Previously, this ceilinged at INT_MAX, but that doesn't work on
1648 64-bit machines.
e46bb31a 1649 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1650
c78baabf 1651 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1652 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1653 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1654 when a (possibly-narrower) signed value would do just as well.
1655 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1656
c9d624c6
PE
1657 * alloc.c: Catch some string size overflows that we were missing.
1658 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1659 for convenience in STRING_BYTES_MAX.
1660 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1661 The definition here is exact; the one in lisp.h was approximate.
1662 (allocate_string_data): Check for string overflow. This catches
1663 some instances we weren't catching before. Also, it catches
1664 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1665 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1666 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1667
c9d624c6
PE
1668 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1669 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1670 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1671
353032ce
PE
1672 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1673
2bccce07
PE
1674 * alloc.c (Fmake_string): Check for out-of-range init.
1675
0ac30604
SM
16762011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1677
1678 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1679
c195f2de
JD
16802011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1681
1682 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1683 xg_get_default_scrollbar_width.
1684
1685 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1686 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1687 (style_changed_cb): Call update_theme_scrollbar_width and call
1688 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1689 all frames (Bug#8505).
1690 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1691 Call gtk_window_set_resizable if HAVE_GTK3.
1692 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1693 and height if HAVE_GTK3 (Bug#8505).
1694 (scroll_bar_width_for_theme): New variable.
1695 (update_theme_scrollbar_width): New function.
1696 (xg_get_default_scrollbar_width): Move code to
1697 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1698 (xg_initialize): Call update_theme_scrollbar_width.
1699
1700 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1701
1702 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1703
e10ac9f1
MR
17042011-06-12 Martin Rudalics <rudalics@gmx.at>
1705
1706 * frame.c (make_frame): Call other_buffer_safely instead of
1707 other_buffer.
1708
1709 * window.c (temp_output_buffer_show): Call display_buffer with
1710 second argument Vtemp_buffer_show_specifiers and reset latter
1711 immediately after the call.
1712 (Vtemp_buffer_show_specifiers): New variable.
1713 (auto_window_vscroll_p, next_screen_context_lines)
1714 (Vscroll_preserve_screen_position): Remove leading asterisks from
1715 doc-strings.
1716
2d3c217e 17172011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1718
7b7f97e8 1719 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1720 * buffer.c (Qclone_number): Remove for now, as it's unused.
1721 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1722 (record_buffer): Remove unused local.
1723 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1724 (set_frame_buffer_list): Remove; unused.
1725 * frame.h (other_visible_frames): Remove decl.
1726 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1727 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1728 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1729 if HAVE_GPM.
1730 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1731 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1732 Define only if HAVE_GPM.
1733 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1734 (update_hints_inhibit): Remove; never set. All uses removed.
1735 * widgetprv.h (emacsFrameClassRec): Remove decl.
1736 * window.c (delete_deletable_window): Now returns void, since it
1737 wasn't returning anything.
1738 (compare_window_configurations): Remove unused locals.
1739 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1740 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1741 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1742 the same widths as pointers. This follows up on the 2011-05-06 patch.
1743 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1744 * xterm.h: Likewise.
1745 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1746
1384b89e
JB
17472011-06-12 Juanma Barranquero <lekktu@gmail.com>
1748
1749 * makefile.w32-in: Update dependencies.
1750 (LISP_H): Add lib/intprops.h.
1751
1100a63c
CY
17522011-06-11 Chong Yidong <cyd@stupidchicken.com>
1753
1754 * image.c (gif_load): Add animation frame delay to the metadata.
1755 (syms_of_image): Use DEFSYM. New symbol `delay'.
1756
6198ccd0
MR
17572011-06-11 Martin Rudalics <rudalics@gmx.at>
1758
1759 * window.c (delete_deletable_window): Re-add.
1760 (Fset_window_configuration): Rewrite to handle dead buffers and
1761 consequently deletable windows.
1762 (window_tree, Fwindow_tree): Remove. Supply functionality in
1763 window.el.
1764 (compare_window_configurations): Simplify code.
1765
b6e3633c
AS
17662011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1767
1ab0dee5
AS
1768 * image.c (imagemagick_load_image): Fix type mismatch.
1769 (Fimagemagick_types): Likewise.
1770
b6e3633c
AS
1771 * window.h (replace_buffer_in_windows): Declare.
1772
9397e56f
MR
17732011-06-11 Martin Rudalics <rudalics@gmx.at>
1774
1775 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1776 Qclone_number. Remove external declaration of Qdelete_window.
1777 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1778 code.
1779 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1780 Qbuffer_list_update_hook if allowed.
1781 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1782 buffer list implementation.
1783 (other_buffer_safely): New function.
1784 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1785 calls to replace_buffer_in_windows and
1786 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1787 if allowed.
1788 (record_buffer): Inhibit quitting and rewrite using quittable
1789 functions. Run Qbuffer_list_update_hook if allowed.
1790 (Frecord_buffer, Funrecord_buffer): New functions.
1791 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1792 switch-to-buffer to window.el.
1793 (bury-buffer): Move to window.el.
1794 (Vbuffer_list_update_hook): New variable.
1795
1796 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1797 section.
1798
1799 * window.h (resize_frame_windows): Move up in code.
1800 (Fwindow_frame): Remove EXFUN.
1801 (replace_buffer_in_all_windows): Remove prototype.
1802 (replace_buffer_in_windows_safely): Add prototype.
1803
1804 * window.c: Declare Qdelete_window static again. Move down
1805 declaration of select_count.
1806 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1807 (Fother_window): Move to window.el.
1808 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1809 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1810 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1811 window.el.
1812 (replace_buffer_in_windows): Implement by calling
1813 Qreplace_buffer_in_windows.
1814 (replace_buffer_in_all_windows): Remove with some functionality
1815 moved into replace_buffer_in_windows_safely.
1816 (replace_buffer_in_windows_safely): New function.
1817 (select_window_norecord, select_frame_norecord): Move in front
1818 of run_window_configuration_change_hook. Remove now obsolete
1819 declarations.
1820 (Fset_window_buffer): Rewrite doc-string. Call
1821 Qrecord_window_buffer.
1822 (keys_of_window): Move binding for other-window to window.el.
1823
b50691aa
CY
18242011-06-11 Chong Yidong <cyd@stupidchicken.com>
1825
1826 * dispextern.h (struct image): Replace data member, whose int_val
1827 and ptr_val fields were not used by anything, with a single
1828 lisp_val object.
1829
1830 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1831 (gif_clear_image, gif_load, imagemagick_load_image)
1832 (gs_clear_image, gs_load): Callers changed.
1833
3f754b86
PE
18342011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1835
cca69397
PE
1836 * buffer.h: Include <time.h>, for time_t.
1837 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1838
109e28d0
PE
1839 Fix minor problems found by static checking.
1840
60737f02
PE
1841 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1842
4b66faf3
PE
1843 Make identifiers static if they are not used in other modules.
1844 * data.c (Qcompiled_function, Qframe, Qvector):
1845 * image.c (QimageMagick, Qsvg):
1846 * minibuf.c (Qmetadata):
1847 * window.c (resize_window_check, resize_root_window): Now static.
1848 * window.h (resize_window_check, resize_root_window): Remove decls.
1849
109e28d0
PE
1850 * window.c (window_deletion_count, delete_deletable_window):
1851 Remove; unused.
46a4ce9e
PE
1852 (window_body_lines): Now static.
1853 (Fdelete_other_windows_internal): Mark vars as initialized.
1854 Make sure 'resize_failed' is initialized.
1855 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1856 (resize_window_apply): Remove unused local.
1857 * window.h (delete_deletable_window): Remove decl.
1858
109e28d0 1859 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1860 (imagemagick_load_image): Fix pointer signedness problem by changing
1861 last arg from unsigned char * to char *. All uses changed.
1862 Also, fix a local for similar reasons.
1863 Remove unused locals. Remove locals to avoid shadowing.
1864 (fn_rsvg_handle_free): Remove; unused.
1865 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1866 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1867
3f754b86
PE
1868 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1869
2547adb1
CY
18702011-06-10 Chong Yidong <cyd@stupidchicken.com>
1871
1872 * image.c (gif_load): Fix omitted cast error introduced by
1873 2011-06-06 change.
1874
2c8e37d4
MR
18752011-06-10 Martin Rudalics <rudalics@gmx.at>
1876
1877 * window.h (resize_proportionally, orig_total_lines)
1878 (orig_top_line): Remove from window structure.
1879 (set_window_height, set_window_width, change_window_heights)
1880 (Fdelete_window): Remove prototypes.
1881 (resize_frame_windows): Remove duplicate declaration.
1882
440a42e3
EZ
18832011-06-10 Eli Zaretskii <eliz@gnu.org>
1884
1885 * window.h (resize_frame_windows, resize_window_check)
1886 (delete_deletable_window, resize_root_window)
1887 (resize_frame_windows): Declare prototypes.
1888
1889 * window.c (resize_window_apply): Make definition be "static" to
1890 match the prototype.
1891
562dd5e9
MR
18922011-06-10 Martin Rudalics <rudalics@gmx.at>
1893
1894 * window.c: Remove declarations of Qwindow_size_fixed,
1895 window_min_size_1, window_min_size_2, window_min_size,
1896 size_window, window_fixed_size_p, enlarge_window, delete_window.
1897 Remove static from declaration of Qdelete_window, it's
1898 temporarily needed by Fbury_buffer.
1899 (replace_window): Don't assign orig_top_line and
1900 orig_total_lines.
1901 (Fdelete_window, delete_window): Remove. Window deletion is
1902 handled by window.el.
1903 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1904 Fdelete_window calls with calls to Qdelete_window.
1905 (Fdelete_other_windows): Remove. Deleting other windows is
1906 handled by window.el.
1907 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1908 handled in window.el.
1909 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1910 Window minimum sizes are handled in window.el.
1911 (shrink_windows, size_window, set_window_height)
1912 (set_window_width, change_window_heights, window_height)
1913 (window_width, CURBEG, CURSIZE, enlarge_window)
1914 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1915 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1916 handled in window.el.
1917 (make_dummy_parent): Rename to make_parent_window and give it a
1918 second argument horflag.
1919 (make_window): Don't set resize_proportionally any more.
1920 (Fsplit_window): Remove. Windows are split in window.el.
1921 (save_restore_action, save_restore_orig_size)
1922 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1923 Resize mini windows in window.el.
1924 (grow_mini_window, shrink_mini_window): Implement by calling
1925 Qresize_root_window_vertically, resize_window_check and
1926 resize_window_apply.
1927 (saved_window, Fset_window_configuration, save_window_save): Do
1928 not handle orig_top_line, orig_total_lines, and
1929 resize_proportionally.
1930 (window_min_height, window_min_width): Move to window.el.
1931 (keys_of_window): Move bindings for delete-other-windows,
1932 split-window, delete-window and enlarge-window to window.el.
1933
1934 * buffer.c: Temporarily extern Qdelete_window.
1935 (Fbury_buffer): Temporarily call Qdelete_window instead of
1936 Fdelete_window (Fbury_buffer will move to window.el soon).
1937
1938 * frame.c (set_menu_bar_lines_1): Remove code handling
1939 orig_top_line and orig_total_lines.
1940
1941 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1942 set_window_height but set heights directly.
1943 (change_frame_size_1): Use resize_frame_windows.
1944
1945 * xdisp.c (init_xdisp): Don't use set_window_height but set
1946 heights directly.
1947
1948 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1949 resize_frame_windows instead of change_window_heights and run
1950 run_window_configuration_change_hook.
1951
1952 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1953 instead of change_window_heights and run
1954 run_window_configuration_change_hook.
1955
1a13852e
MR
19562011-06-09 Martin Rudalics <rudalics@gmx.at>
1957
1958 * window.c (replace_window): Rename second argument REPLACEMENT to
1959 NEW. New third argument SETFLAG. Rewrite.
1960 (delete_window, make_dummy_parent): Call replace_window with
1961 third argument 1.
1962 (window_list_1): Move down in code.
1963 (run_window_configuration_change_hook): Move set_buffer part
1964 before select_frame_norecord part in order to unwind correctly.
1965 Rename count1 to count.
1966 (recombine_windows, delete_deletable_window, resize_root_window)
1967 (Fdelete_other_windows_internal)
1968 (Frun_window_configuration_change_hook, make_parent_window)
1969 (resize_window_check, resize_window_apply, Fresize_window_apply)
1970 (resize_frame_windows, Fsplit_window_internal)
1971 (Fdelete_window_internal, Fresize_mini_window_internal): New
1972 functions.
1973 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1974
f3d1777e
MR
19752011-06-08 Martin Rudalics <rudalics@gmx.at>
1976
496e208e
MR
1977 * window.h (window): Add some new members to window structure -
1978 normal_lines, normal_cols, new_total, new_normal, clone_number,
1979 splits, nest, prev_buffers, next_buffers.
1980 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1981 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1982
f3d1777e
MR
1983 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1984 Remove.
496e208e
MR
1985 (make_dummy_parent): Set new members of windows structure.
1986 (make_window): Move down in code. Handle new members of window
1987 structure.
1988 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1989 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1990 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1991 (Fset_window_prev_buffers, Fwindow_next_buffers)
1992 (Fset_window_next_buffers, Fset_window_clone_number): New
1993 functions.
1994 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1995 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1996 Doc-string fixes.
1997 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1998 Argument WINDOW can be now internal window too.
1999 (Fwindow_use_time): Move up in code.
2000 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2001 Rewrite doc-string.
2002 (Fset_window_configuration, saved_window)
2003 (Fcurrent_window_configuration, save_window_save): Handle new
2004 members of window structure.
b9e809c2
MR
2005 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2006 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2007 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2008 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2009 Qget_mru_window, Qresize_root_window,
2010 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2011 Qauto_buffer_name; staticpro them.
f3d1777e 2012
abde8f8c
MR
20132011-06-07 Martin Rudalics <rudalics@gmx.at>
2014
2015 * window.c (Fwindow_total_size, Fwindow_left_column)
2016 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2017 (Fwindow_list_1): New functions.
2018 (window_box_text_cols): Replace with window_body_cols.
2019 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2020 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2021 (delete_window, Fset_window_configuration): Call
2022 delete_all_subwindows with window as argument.
2023 (delete_all_subwindows): Take a window as argument and not a
2024 structure. Rewrite.
190b47e6
MR
2025 (window_loop): Remove handling of GET_LRU_WINDOW and
2026 GET_LARGEST_WINDOW.
2027 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2028
2029 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2030 window_box_text_cols. delete_all_subwindows now takes a
2031 Lisp_Object as argument.
abde8f8c
MR
2032
2033 * indent.c (compute_motion, Fcompute_motion): Use
2034 window_body_cols instead of window_box_text_cols.
2035
fa8a67e6
MR
2036 * frame.c (delete_frame): Call delete_all_subwindows with root
2037 window as argument.
2038
a54e3482
DC
20392011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2040
2041 * fns.c (Fputhash): Document return value.
2042
60002bf5
CY
20432011-06-06 Chong Yidong <cyd@stupidchicken.com>
2044
2045 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2046
0c671da6 20472011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2048
b862a52a 2049 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2050
be44ca6c
PE
2051 Check for overflow when converting integer to cons and back.
2052 * charset.c (Fdefine_charset_internal, Fdecode_char):
2053 Use cons_to_unsigned to catch overflow.
2054 (Fencode_char): Use INTEGER_TO_CONS.
2055 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2056 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2057 * data.c (long_to_cons, cons_to_long): Remove.
2058 (cons_to_unsigned, cons_to_signed): New functions.
2059 These signal an error for invalid or out-of-range values.
2060 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2061 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2062 * font.c (Ffont_variation_glyphs):
2063 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2064 * lisp.h: Include <intprops.h>.
2065 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2066 (cons_to_signed, cons_to_unsigned): New decls.
2067 (long_to_cons, cons_to_long): Remove decls.
2068 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2069 (Fprimitive_undo): Use CONS_TO_INTEGER.
2070 * xfns.c (Fx_window_property): Likewise.
2071 * xselect.c: Include <limits.h>.
2072 (x_own_selection, selection_data_to_lisp_data):
2073 Use INTEGER_TO_CONS.
2074 (x_handle_selection_request, x_handle_selection_clear)
2075 (x_get_foreign_selection, Fx_disown_selection_internal)
2076 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2077 (lisp_data_to_selection_data): Use cons_to_unsigned.
2078 (x_fill_property_data): Use cons_to_signed.
2079 Report values out of range.
2080
d1f3d2af
PE
2081 Check for buffer and string overflow more precisely.
2082 * buffer.h (BUF_BYTES_MAX): New macro.
2083 * lisp.h (STRING_BYTES_MAX): New macro.
2084 * alloc.c (Fmake_string):
2085 * character.c (string_escape_byte8):
2086 * coding.c (coding_alloc_by_realloc):
2087 * doprnt.c (doprnt):
2088 * editfns.c (Fformat):
2089 * eval.c (verror):
2090 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2091 since they may not be the same number.
2092 * editfns.c (Finsert_char):
2093 * fileio.c (Finsert_file_contents):
2094 Likewise for BUF_BYTES_MAX.
2095
dd52fcea
PE
2096 * image.c: Use ptrdiff_t, not int, for sizes.
2097 (slurp_file): Switch from int to ptrdiff_t.
2098 All uses changed.
2099 (slurp_file): Check that file size fits in both size_t (for
2100 malloc) and ptrdiff_t (for sanity and safety).
2101
7f9bbdbb
PE
2102 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2103 if b->modtime has its maximal value.
2104
dfe18f82
PE
2105 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2106
84acfcf0
PE
2107 Don't assume time_t can fit into int.
2108 * buffer.h (struct buffer.modtime): Now time_t, not int.
2109 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2110 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2111
ccd9a01a
PE
2112 Minor fixes for signed vs unsigned integers.
2113 * character.h (MAYBE_UNIFY_CHAR):
2114 * charset.c (maybe_unify_char):
2115 * keyboard.c (read_char, reorder_modifiers):
2116 XINT -> XFASTINT, since the integer must be nonnegative.
2117 * ftfont.c (ftfont_spec_pattern):
2118 * keymap.c (access_keymap, silly_event_symbol_error):
2119 XUINT -> XFASTINT, since the integer must be nonnegative.
2120 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2121 since it makes no difference and we prefer signed.
2122 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2123 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2124 nonnegative.
2125
d6d100dd
SM
21262011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2127
2128 * window.h (Fwindow_frame): Declare.
2129
2b6148e4
PE
21302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2131
2132 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2133 (SPARE_MEMORY): Always define.
2134 (LARGE_REQUEST): Remove.
2135 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2136
f230ecc9
MR
21372011-06-06 Martin Rudalics <rudalics@gmx.at>
2138
727e958e
MR
2139 * lisp.h: Move EXFUNS for Fframe_root_window,
2140 Fframe_first_window and Fset_frame_selected_window to window.h.
2141
2142 * window.h: Move EXFUNS for Fframe_root_window,
2143 Fframe_first_window and Fset_frame_selected_window here from
2144 lisp.h.
2145
2146 * frame.c (Fwindow_frame, Fframe_first_window)
2147 (Fframe_root_window, Fframe_selected_window)
2148 (Fset_frame_selected_window): Move to window.c.
2149 (Factive_minibuffer_window): Move to minibuf.c.
2150 (Fother_visible_frames_p): New function.
2151
2152 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2153
f230ecc9
MR
2154 * window.c (decode_window, decode_any_window): Move up in code.
2155 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2156 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2157 (Fwindow_buffer): Move up and rewrite doc-string.
2158 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2159 (Fwindow_prev): New functions.
727e958e
MR
2160 (Fwindow_frame): Move here from frame.c. Accept any window as
2161 argument.
2162 (Fframe_root_window, Fframe_first_window)
2163 (Fframe_selected_window): Move here from frame.c. Accept frame
2164 or arbitrary window as argument. Update doc-strings.
2165 (Fminibuffer_window): Move up in code.
2166 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2167 (Fset_frame_selected_window): Move here from frame.c.
2168 Marginal rewrite.
727e958e
MR
2169 (Fselected_window, select_window, Fselect_window): Move up in
2170 code. Minor doc-string fixes.
f230ecc9 2171
4d09bcf6
PE
21722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2173
2174 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2175 Do not assume that spare memory exists; that assumption is valid
2176 only if SYSTEM_MALLOC.
2177 (LARGE_REQUEST): New macro, so that the issue of large requests
2178 is separated from the issue of spare memory.
2179
810928a2
AS
21802011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2181
172418ad
AS
2182 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2183 format. (Bug#8806)
2184
43f862f7
AS
2185 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2186
810928a2
AS
2187 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2188 before statements.
2189
a059fe24
JD
21902011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2191
2192 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2193
2194 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2195
2196 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2197 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2198
989bf368
JB
21992011-06-05 Juanma Barranquero <lekktu@gmail.com>
2200
2201 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2202
4b80f674
CY
22032011-06-04 Chong Yidong <cyd@stupidchicken.com>
2204
2205 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2206 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2207 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2208 New error handlers.
4b80f674
CY
2209 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2210 Obey Vx_select_enable_clipboard_manager. Catch errors in
2211 x_clipboard_manager_save (Bug#8779).
2212 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2213 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2214
99a33b77 22152011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2216
2217 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2218
99a33b77 22192011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2220
2221 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2222 in the current matrix if keep_current_p is non-zero.
2223
8264569d
EZ
22242011-06-04 Eli Zaretskii <eliz@gnu.org>
2225
2226 * bidi.c (bidi_level_of_next_char): Fix last change.
2227
57f97249
EZ
22282011-06-03 Eli Zaretskii <eliz@gnu.org>
2229
fec2107c 2230 Support bidi reordering of text covered by display properties.
57f97249 2231
fec2107c
EZ
2232 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2233 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2234 (bidi_cache_search, bidi_cache_iterator_state)
2235 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2236 (bidi_level_of_next_char, bidi_move_to_visually_next):
2237 Support character positions inside a run of characters covered by a
fec2107c
EZ
2238 display string.
2239 (bidi_paragraph_init, bidi_resolve_explicit_1)
2240 (bidi_level_of_next_char): Call bidi_fetch_char and
2241 bidi_fetch_char_advance instead of FETCH_CHAR and
2242 FETCH_CHAR_ADVANCE.
2243 (bidi_init_it): Initialize new members.
2244 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2245 definitions.
2246 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2247 instead of using explicit *_CHAR codes.
d6d100dd
SM
2248 (bidi_resolve_explicit, bidi_resolve_weak):
2249 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2250 bidirectional text is supported only in multibyte buffers.
2251 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2252 it to initialize the frame_window_p member of struct bidi_it.
2253 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2254 (bidi_resolve_explicit, bidi_resolve_weak)
2255 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2256 bidi_it->nchars is non-positive.
2257 (bidi_level_of_next_char): Don't try to lookup the cache for the
2258 next/previous character if nothing is cached there yet, or if we
2259 were just reseat()'ed to a new position.
c40e2fb2 2260
0e14fe90
EZ
2261 * xdisp.c (set_cursor_from_row): Set start and stop points
2262 according to the row's direction when priming the loop that looks
2263 for the glyph on which to display cursor.
2264 (single_display_spec_intangible_p): Function deleted.
2265 (display_prop_intangible_p): Reimplement to call
2266 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2267 Accept 3 additional arguments needed by handle_display_spec.
2268 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2269 values: lists, `(when COND...)' forms, etc.
2270 (single_display_spec_string_p): Support property values that are
2271 lists with the argument STRING its top-level element.
2272 (display_prop_string_p): Fix the condition for processing a
2273 property that is a list to be consistent with handle_display_spec.
fec2107c 2274 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2275 last portion of handle_display_prop.
2276 (compute_display_string_pos): Accept additional argument
2277 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2278 value of a `display' property is a "replacing spec".
2279 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2280 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2281 the display property, but just return a value indicating whether
2282 the display property will replace the characters it covers.
2283 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2284 frame_window_p members of struct bidi_it.
d6d100dd
SM
2285 (compute_display_string_pos, compute_display_string_end):
2286 New functions.
fec2107c
EZ
2287 (push_it): Accept second argument POSITION, where pop_it should
2288 jump to continue iteration.
2289 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2290
fec2107c
EZ
2291 * keyboard.c (adjust_point_for_property): Adjust the call to
2292 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2293
2294 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2295 (bidi_init_it): Update prototypes.
2296 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2297 (compute_display_string_pos, compute_display_string_end):
2298 Declare prototypes.
fec2107c
EZ
2299 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2300 EMACS_INT.
fc6f18ce 2301
40087514 23022011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2303
57f53182
PE
2304 Malloc failure behavior now depends on size of allocation.
2305 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2306 * lisp.h: Change signatures accordingly.
2307 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2308 All callers changed. (Bug#8762)
2309
2310 * gnutls.c: Use Emacs's memory allocators.
2311 Without this change, the gnutls library would invoke malloc etc.
2312 directly, which causes problems on non-SYNC_INPUT hosts, and which
2313 runs afoul of improving memory_full behavior. (Bug#8761)
2314 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2315 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2316 xfree instead of the default malloc, realloc, free.
2317 (Fgnutls_boot): No need to check for memory allocation failure,
2318 since xmalloc does that for us.
2319
ac32cd99 2320 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2321 * category.c (hash_get_category_set):
2322 * ccl.c (ccl_driver):
2323 * charset.c (Fdefine_charset_internal):
2324 * charset.h (struct charset.hash_index):
2325 * composite.c (get_composition_id, gstring_lookup_cache)
2326 (composition_gstring_put_cache):
2327 * composite.h (struct composition.hash_index):
2328 * dispextern.h (struct image.hash):
2329 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2330 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2331 (hashfn_equal, hashfn_user_defined, make_hash_table)
2332 (maybe_resize_hash_table, hash_lookup, hash_put)
2333 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2334 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2335 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2336 * image.c (make_image, search_image_cache, lookup_image)
2337 (xpm_put_color_table_h):
2338 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2339 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2340 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2341 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2342 * alloc.c (allocate_vectorlike):
2343 Check for overflow in vector size calculations.
2344 * ccl.c (ccl_driver):
2345 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2346 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2347 need to be updated by these changes.
40087514
PE
2348 * fns.c (make_hash_table, maybe_resize_hash_table):
2349 Check for integer overflow with large hash tables.
0de4bb68
PE
2350 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2351 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2352 (SXHASH_REDUCE): New macro.
2353 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2354 Use it instead of discarding useful hash info with large hash values.
2355 (sxhash_float): New function.
2356 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2357 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2358 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2359 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2360 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2361 Adjust signatures to match updated version of code.
2362 (consing_since_gc): Now EMACS_INT, since a single hash table can
2363 use more than INT_MAX bytes.
2364
698d32e2
DN
23652011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2366
2367 Make it possible to build with GCC-4.6+ -O2 -flto.
2368
2369 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2370
fd6fa53f
SM
23712011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2372
2373 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2374 Call minibuffer-inactive-mode.
2375
864db017
JB
23762011-05-31 Juanma Barranquero <lekktu@gmail.com>
2377
2378 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2379 Update dependencies.
2380
2ad0baf4
DN
23812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2382
2383 * data.c (init_data): Remove code for UTS, this system is not
2384 supported anymore.
2385
4fcc2638
DN
23862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2387
2388 Don't force ./temacs to start in terminal mode.
2389
2390 * frame.c (make_initial_frame): Initialize faces in all cases, not
2391 only when CANNOT_DUMP is defined.
2392 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2393
c56e0fd5
DN
23942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2395
2396 * dispnew.c (add_window_display_history): Use const for the string
2397 pointer. Remove declaration, not needed.
2398
333d54da 23992011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2400
55d4c1b2 2401 Use 'inline', not 'INLINE'.
333d54da 2402 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2403 * alloc.c, fontset.c (INLINE): Remove.
2404 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2405 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2406 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2407 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2408 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2409
738db178
DN
24102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2411
2412 Make it possible to run ./temacs.
2413
2414 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2415 syms_of_callproc does the same thing. Remove test for
2416 "initialized", do it in the caller.
2417 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2418
620c53a6
SM
24192011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2420
2421 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2422 (read_minibuf): Use get_minibuffer.
2423 (syms_of_minibuf): Use DEFSYM.
2424 (Qmetadata): New var.
2425 * data.c (Qbuffer): Don't make it static.
2426 (syms_of_data): Use DEFSYM.
2427
e003a292
PE
24282011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2429
2430 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2431 (CCL_CODE_MIN): New macro.
2432
ed008a6d
PE
24332011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2434
3687c2ef
PE
2435 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2436
ed008a6d
PE
2437 * eval.c (Qdebug): Now static.
2438 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2439 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2440 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2441
d66c4c7c
CY
24422011-05-29 Chong Yidong <cyd@stupidchicken.com>
2443
2444 * image.c: Various fixes to ImageMagick code comments.
2445 (Fimagemagick_types): Doc fix.
2446
5fbc2025
PE
24472011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2448
0196f88a
PE
2449 Minor fixes prompted by GCC 4.6.0 warnings.
2450
2451 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2452
5fbc2025
PE
2453 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2454 (x_clipboard_manager_save_all): Move extern decl to ...
2455 * xterm.h: ... here, so that it can be checked for consistency.
2456
1dd3c2d9
CY
24572011-05-29 Chong Yidong <cyd@stupidchicken.com>
2458
2459 * xselect.c (x_clipboard_manager_save_frame)
2460 (x_clipboard_manager_save_all): New functions.
2461 (Fx_clipboard_manager_save): Lisp function deleted.
2462
2463 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2464 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2465
2466 * xterm.h: Update prototype.
2467
5ba6571d
WX
24682011-05-28 William Xu <william.xwl@gmail.com>
2469
2470 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2471 exiting (Bug#8239).
2472
3eaff834
JM
24732011-05-28 Jim Meyering <meyering@redhat.com>
2474
e1900994 2475 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2476 * fns.c (to_uchar): Define.
2477 (crypto_hash_function): Use it to convert some newly-signed
2478 variables to unsigned, to avoid sign-extension bugs. For example,
2479 without this change, (md5 "truc") would evaluate to
2480 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2481 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2482 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2483
0f6990a7
PE
24842011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2485
2486 Integer overflow fixes.
c8a9ca5a 2487
08686060
PE
2488 * dbusbind.c: Serial number integer overflow fixes.
2489 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2490 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2491 to hold a serial number that is too large for a fixnum.
2492 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2493 Check for serial numbers out of range. Decode any serial number
59568bf0 2494 that was so large that it became a float. (Bug#8722)
08686060 2495
2d1fc3c7
PE
2496 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2497 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2498 Use XFASTINT rather than XUINT when numbers are nonnegative.
2499 (xd_append_arg, Fdbus_method_return_internal):
2500 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2501 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2502 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2503 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2504 (Bug#8722)
2d1fc3c7 2505
c8a9ca5a
PE
2506 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2507
519e1d69
PE
2508 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2509
30569699
PE
2510 ccl: add integer overflow checks
2511 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2512 (IN_INT_RANGE): New macros.
2513 (ccl_driver): Use them to check for integer overflow when
2514 decoding a CCL program. Many of the new checks are whether XINT (x)
2515 fits in int; it doesn't always, on 64-bit hosts. The new version
2516 doesn't catch all possible integer overflows, but it's an
847044ea 2517 improvement. (Bug#8719)
30569699 2518
c11285dc
PE
2519 * alloc.c (make_event_array): Use XINT, not XUINT.
2520 There's no need for unsigned here.
2521
fdccd48e
PE
2522 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2523 This follows up to the 2011-05-06 change that substituted uintptr_t
2524 for EMACS_INT. This case wasn't caught back then.
2525
37910ab2
PE
2526 Rework Fformat to avoid integer overflow issues.
2527 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2528 now (part of C89). Include <verify.h>.
2529 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2530 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2531 (Fformat): Avoid the prepass trying to compute sizes; it was only
2532 approximate and thus did not catch overflow reliably. Instead, walk
2533 through the format just once, formatting and computing sizes as we go,
2534 checking for integer overflow at every step, and allocating a larger
2535 buffer as needed. Keep track separately whether the format is
2536 multibyte. Keep only the most-recently calculated precision, rather
2537 than them all. Record whether each argument has been converted to
2538 string. Use EMACS_INT, not int, for byte and char and arg counts.
2539 Support field widths and precisions larger than INT_MAX. Avoid
2540 sprintf's undefined behavior with conversion specifications such as %#d
2541 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2542 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2543 formatting out-of-range floating point numbers with int
9173deec 2544 formats. (Bug#8668)
37910ab2 2545
2e6578fb
PE
2546 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2547
0ae6bdee
PE
2548 * data.c: Avoid integer truncation in expressions involving floats.
2549 * data.c: Include <intprops.h>.
2550 (arith_driver): When there's an integer overflow in an expression
2551 involving floating point, convert the integers to floating point
2552 so that the resulting value does not suffer from catastrophic
2553 integer truncation. For example, on a 64-bit host (* 4
2554 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2555 Do not rely on undefined behavior after integer overflow.
2556
de883a70
PE
2557 merge count_size_as_multibyte, parse_str_to_multibyte
2558 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2559 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2560 Check for integer overflow.
2561 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2562 since it's now a duplicate of the other. This is more of
2563 a character than a buffer op, so better that it's in character.c.
2564 * fns.c, print.c: Adjust to above changes.
2565
2ff916cb
PE
25662011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2567
2568 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2569
f1b54466
PE
25702011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2571
fb1ac845
PE
2572 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2573 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2574 (x_clipboard_manager_save): Now static.
2575 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2576
f1b54466
PE
2577 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2578 (crypto_hash_function): Now static.
2579 Fix pointer signedness problems. Avoid unnecessary initializations.
2580
a9f737ee
CY
25812011-05-27 Chong Yidong <cyd@stupidchicken.com>
2582
2583 * termhooks.h (Vselection_alist): Make it terminal-local.
2584
2585 * terminal.c (create_terminal): Initialize it.
2586
2587 * xselect.c: Support for clipboard managers.
2588 (Vselection_alist): Move to termhooks.h as terminal-local var.
2589 (LOCAL_SELECTION): New macro.
2590 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2591 (symbol_to_x_atom): Remove gratuitous arg.
2592 (x_handle_selection_request, lisp_data_to_selection_data)
2593 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2594 (x_own_selection, x_get_local_selection, x_convert_selection):
2595 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2596 (some_frame_on_display): Delete unused function.
2597 (Fx_own_selection_internal, Fx_get_selection_internal)
2598 (Fx_disown_selection_internal, Fx_selection_owner_p)
2599 (Fx_selection_exists_p): New optional frame arg.
2600 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2601 (x_handle_selection_clear): Don't treat other terminals with the
2602 same keyboard specially. Use the terminal-local Vselection_alist.
2603 (x_clear_frame_selections): Use Frun_hook_with_args.
2604
2605 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2606
2607 * xterm.h: Add support for those atoms.
2608
e067f0c1
CY
26092011-05-26 Chong Yidong <cyd@stupidchicken.com>
2610
2611 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2612 (converted_selections, conversion_fail_tag): New global variables.
2613 (x_selection_request_lisp_error): Free the above.
2614 (x_get_local_selection): Remove unnecessary code.
2615 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2616 of converted selections stored in converted_selections.
2617 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2618 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2619 (x_convert_selection): New function.
2620 (x_handle_selection_event): Simplify.
2621 (x_get_foreign_selection): Don't ignore incoming requests while
2622 waiting for an answer; this will fail when we implement
2623 SAVE_TARGETS, and seems unnecessary anyway.
2624 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2625 (Vx_sent_selection_functions): Doc fix.
2626
0f4aebc0
LL
26272011-05-26 Leo Liu <sdl.web@gmail.com>
2628
2629 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2630
e61124cd
YM
26312011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2632
2633 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2634
2635 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2636 for fringe update if it has periodic bitmap.
ac389d0c 2637 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2638 and fringe_bitmap_periodic_p.
2639
2640 * fringe.c (get_fringe_bitmap_data): New function.
2641 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2642 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2643 row. Mark glyph row for fringe update if periodicity changed.
2644
2645 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2646 for fringe update unless it has periodic bitmap.
2647
f16d9837
KH
26482011-05-25 Kenichi Handa <handa@m17n.org>
2649
2650 * xdisp.c (get_next_display_element): Set correct it->face_id for
2651 a static composition.
2652
e1b90ef6
LL
26532011-05-24 Leo Liu <sdl.web@gmail.com>
2654
2655 * deps.mk (fns.o):
2656 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2657
2658 * fns.c (crypto_hash_function, Fsha1): New function.
2659 (Fmd5): Use crypto_hash_function.
2660 (syms_of_fns): Add Ssha1.
2661
7400048f
PE
26622011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 * gnutls.c: Remove unused macros.
2665 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2666 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2667 Remove macros that are defined and never used.
2668 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2669
abb71cf4
CY
26702011-05-22 Chong Yidong <cyd@stupidchicken.com>
2671
2672 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2673 (Fx_get_selection_internal): Minor cleanup.
2674 (Fx_own_selection_internal): Rename arguments for consistency with
2675 select.el.
2676
6307db39
PE
26772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2678
2679 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2680
f3d4e0a4
CY
26812011-05-22 Chong Yidong <cyd@stupidchicken.com>
2682
2683 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2684
4d8ade89
YM
26852011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2686
2687 * dispnew.c (scrolling_window): Don't exclude the case that the
2688 last enabled row in the desired matrix touches the bottom boundary.
2689
32078c8d
GM
26902011-05-21 Glenn Morris <rgm@gnu.org>
2691
2692 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2693 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2694 and add some more files.
32078c8d 2695
7285dc67
EZ
26962011-05-20 Eli Zaretskii <eliz@gnu.org>
2697
2698 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2699 report_file_error introduced by the change from 2011-05-07.
2700
89d1bd22
PE
27012011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2702
2703 * systime.h (Time): Define only if emacs is defined.
2704 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2705 where the include path doesn't have X11/X.h by default. See
2706 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2707
e23640bb 27082011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2709
2710 * composite.c (find_automatic_composition): Fix previous change.
2711
b9704ad9
GM
27122011-05-20 Glenn Morris <rgm@gnu.org>
2713
2714 * lisp.mk: New file, split from Makefile.in.
2715 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2716 (shortlisp): Remove.
2717 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2718
4a720484
GM
27192011-05-19 Glenn Morris <rgm@gnu.org>
2720
2721 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2722 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2723 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2724 (lisp): Set the order to that of loadup.el.
2725 (shortlisp): Make it a copy of $lisp.
2726 (SOME_MACHINE_LISP): Remove.
2727 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2728 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2729
a28d4396
KH
27302011-05-18 Kenichi Handa <handa@m17n.org>
2731
2732 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2733 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2734 (find_automatic_composition): Mostly rewrite for efficiency.
2735
a2b1fa8e
JB
27362011-05-18 Juanma Barranquero <lekktu@gmail.com>
2737
2738 * makefile.w32-in: Update dependencies.
2739
8e1f5610
CS
27402011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2741
2742 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2743 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2744
7025ee00 27452011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2746
cdfa6eab
PE
2747 Fix some integer overflow issues, such as string length overflow.
2748
06d6db33
PE
2749 * insdel.c (count_size_as_multibyte): Check for string overflow.
2750
2b4560a8
PE
2751 * character.c (lisp_string_width): Check for string overflow.
2752 Use EMACS_INT, not int, for string indexes and lengths; in
2753 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2754 the resulting string length overflows an EMACS_INT; instead,
2755 report a string overflow if no precision given. When checking for
2756 precision exhaustion, use a check that cannot possibly have
2757 integer overflow. (Bug#8675)
2758 * character.h (lisp_string_width): Adjust to new signature.
2759
cb93f9be
PE
2760 * alloc.c (string_overflow): New function.
2761 (Fmake_string): Use it. This doesn't change behavior, but saves
2762 a few bytes and will simplify future changes.
2763 * character.c (string_escape_byte8): Likewise.
2764 * lisp.h (string_overflow): New decl.
2765
1a1f3366
PE
2766 Fixups, following up to the user-interface timestamp change.
2767 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2768 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2769 * msdos.c (mouse_get_pos): Likewise.
2770 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2771 * w32gui.h (Time): Define by including "systime.h" rather than by
2772 declaring it ourselves. (Bug#8664)
2773
d4e3e4d3
PE
2774 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2775 * image.c (clear_image_cache): Likewise.
2776
f6a24d19
PE
2777 * term.c (term_mouse_position): Don't assume time_t wraparound.
2778
08dc5ae6
PE
2779 Be more systematic about user-interface timestamps.
2780 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2781 and sometimes 'EMACS_UINT', to represent these timestamps.
2782 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2783 This makes the code easier to follow, and makes it easier to catch
2784 integer overflow bugs such as Bug#8664.
2785 * frame.c (Fmouse_position, Fmouse_pixel_position):
2786 Use Time, not unsigned long, for user-interface timestamps.
2787 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2788 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2789 * keyboard.h (last_event_timestamp): Likewise.
2790 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2791 * menu.h (xmenu_show): Likewise.
2792 * term.c (term_mouse_position): Likewise.
2793 * termhooks.h (struct input_event.timestamp): Likewise.
2794 (struct terminal.mouse_position_hook): Likewise.
2795 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2796 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2797 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2798 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2799 what it was before.
2800 * menu.h, termhooks.h: Include "systime.h", for Time.
2801
8e55734a
PE
2802 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2803 Don't assume that the difference between two unsigned long values
2804 can fit into an integer. At this point, we know button_down_time
2805 <= event->timestamp, so the difference must be nonnegative, so
2806 there's no need to cast the result if double-click-time is
2807 nonnegative, as it should be; check that it's nonnegative, just in
2808 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2809 apart (about 25 days). (Bug#8664)
8e55734a 2810
841f1b75 2811 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2812 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2813
3e26f69c
PE
2814 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2815 that always fit in int. Use a sentinel instead of a counter, to
2816 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2817 * frame.h (struct frame): Use int for menu_bar_items_used
2818 instead of EMACS_INT, since it always fits in int.
3e26f69c 2819
5cc152c0
PE
2820 * menu.c (grow_menu_items): Check for int overflow.
2821
d89eb65e
PE
2822 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2823
5235bd3e
PE
2824 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2825 Before, the code was not consistent. These values cannot exceed
2826 2**31 - 1 so there's no need to make them unsigned.
2827 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2828 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2829 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2830 as modifiers.
2831 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2832
bc827e23
PE
2833 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2834 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2835 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2836 presumably because the widths might not match.
2837
78eb494e
PE
2838 * window.c (size_window): Avoid needless test at loop start.
2839
04f2d78b
CB
28402011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2841
2842 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2843
d2fc7e3d 28442011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2845
2846 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2847
d2fc7e3d 28482011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2849
2850 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2851 `width' to `bar_area_x' and `bar_area_width', respectively.
2852 (x_scroll_run): Take account of fringe background extension.
2853
04f2d78b
CB
2854 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2855 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2856 `bar_area_width', respectively.
2857 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2858 background extension.
2859
79b70037
GM
28602011-05-10 Jim Meyering <meyering@redhat.com>
2861
2862 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2863
2f142cc5
JB
28642011-05-10 Juanma Barranquero <lekktu@gmail.com>
2865
2866 * image.c (Finit_image_library): Return t for built-in image types,
2867 like pbm and xbm. (Bug#8640)
2868
57679c86
AS
28692011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2870
2871 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2872
888c9e86
EZ
28732011-05-07 Eli Zaretskii <eliz@gnu.org>
2874
b0512a1d
EZ
2875 * w32console.c (Fset_screen_color): Doc fix.
2876 (Fget_screen_color): New function.
2877 (syms_of_ntterm): Defsubr it.
2878
7285dc67
EZ
2879 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2880 unlink the temporary file if Fcall_process didn't create it in the
2881 first place.
2882 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2883 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2884 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2885 cue to call_process_cleanup not to close that handle.
2886
4d3fcc8e
BK
28872011-05-07 Ben Key <bkey76@gmail.com>
2888
2889 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2890 one of two shell specific rules, either bootstrap-temacs-CMD or
2891 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2892 to the previous implementation of the bootstrap-temacs rule.
2893 The bootstrap-temacs-CMD rule is similar to the previous
2894 implementation of the bootstrap-temacs rule except that it
2895 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2896 variable.
2897
2898 These changes, along with some changes to nt/configure.bat,
2899 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2900 earlier fix to add support for --cflags and --ldflags options
2901 that include quotes so that it works whether make uses cmd or
2902 sh as the shell.
2903
b4289b64
MA
29042011-05-06 Michael Albinus <michael.albinus@gmx.de>
2905
2906 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2907 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2908 is a constant.
2909 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2910 a string. Handle both cases.
2911 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2912 (Fdbus_register_method): Use Qinvalid_function.
2913
af4c0e28
JB
29142011-05-06 Juanma Barranquero <lekktu@gmail.com>
2915
2916 * makefile.w32-in: Update dependencies.
2917 (LISP_H): Add inttypes.h and stdin.h.
2918 (PROCESS_H): Add unistd.h.
2919
c51453d9
EZ
29202011-05-06 Eli Zaretskii <eliz@gnu.org>
2921
2922 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2923 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2924
8ff0ac3c 29252011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2926
4c4b566b
PE
2927 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2928
aab2b9b5
PE
2929 * term.c (vfatal): Remove stray call to va_end.
2930 It's not needed and the C Standard doesn't allow it here anyway.
2931
c378da0b
PE
2932 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2933 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2934
288b08c7
PE
2935 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2936 bytes.
2937
e3601888
PE
2938 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2939
db6c0e74
PE
2940 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2941
dd5963ea
PE
2942 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2943
88c9450f
PE
2944 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2945
2f9442b8
PE
2946 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2947
c032b5f8
PE
2948 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2949 * charset.c (Fdefine_charset_internal): Don't initialize
2950 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2951 32-bit int (Bug#8600).
a108c10b
PE
2952
2953 * lread.c (read_integer): Be more consistent with string-to-number.
2954 Use string_to_number to do the actual conversion; this avoids
2955 rounding errors and fixes some other screwups. Without this fix,
2956 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2957 (digit_to_number): Move earlier, for benefit of read_integer.
2958 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2959 not a digit in any supported base. (Bug#8602)
a108c10b 2960
ad5f9eea
PE
2961 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2962
aec1708a
PE
2963 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2964 to match comment at start of function. This also removes a
2965 GCC warning about overflow in a 32+64-bit port.
2966
47be4ab5
PE
2967 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2968
371cac43
PE
2969 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2970 Reported by Stefan Monnier in
2971 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2972 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2973 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2974
d01a7826
PE
2975 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2976 (EMACS_UINTPTR): Likewise, with uintptr_t.
2977
7fd47d5c
PE
2978 * lisp.h: Prefer 64-bit EMACS_INT if available.
2979 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2980 on 32-bit hosts that have 64-bit int, so that they can access
2981 large files.
122b0c86
PE
2982 However, temporarily disable this change unless the temporary
2983 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2984
8727937b
PE
2985 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2986
8ac068ac
PE
2987 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2988 This removes an assumption that EMACS_INT and long are the same
2989 width as pointers. The assumption is true for Emacs porting targets
2990 now, but we want to make other targets possible.
2991 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2992 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2993 In the rest of the code, change types of integers that hold casted
2994 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2995 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2996 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2997 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2998 No need to cast type when ORing.
2999 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3000 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3001 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3002 assume EMACS_INT is the same width as char *.
3003 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3004 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3005 Remove no-longer-needed casts.
3006 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3007 (xg_tool_bar_help_callback, xg_make_tool_item):
3008 Use EMACS_INTPTR to hold an integer
3009 that will be cast to void *; this can avoid a GCC warning
3010 if EMACS_INT is not the same width as void *.
3011 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3012 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3013 (current_message_1, set_message_1):
3014 Use a local to convert to proper width without a cast.
3015 * xmenu.c (dialog_selection_callback): Likewise.
3016
ede49d71
PE
3017 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3018 Also, don't assume VALBITS / RAND_BITS is less than 5,
3019 and don't rely on undefined behavior when shifting a 1 left into
3020 the sign bit.
3021 * lisp.h (get_random): Change signature to match.
3022
2f30ecd0
PE
3023 * lread.c (hash_string): Use size_t, not int, for hash computation.
3024 Normally we prefer signed values; but hashing is special, because
3025 it's better to use unsigned division on hash table sizes so that
3026 the remainder is nonnegative. Also, size_t is the natural width
3027 for hashing into memory. The previous code used 'int', which doesn't
3028 retain enough info to hash well into very large tables.
3029 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3030
2a866e7b
PE
3031 * dbusbind.c: Don't possibly lose pointer info when converting.
3032 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3033 Use XPNTR rather than XHASH, so that the high-order bits of
3034 the pointer aren't lost when converting through void *.
3035
51639eac
PE
3036 * eval.c (Fautoload): Don't double-shift a pointer.
3037
92394119
PE
3038 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3039
dbdb9a7c
JB
30402011-05-06 Juanma Barranquero <lekktu@gmail.com>
3041
3042 * gnutls.c (DEF_GNUTLS_FN):
3043 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3044
db7a0b4f
AS
30452011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3046
3047 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3048 marker. (Bug#8610)
3049
f7ff1b0f 30502011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3051
3052 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3053 New version that can reserve upto 2GB of heap space.
3054
f7ff1b0f 30552011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3056
3057 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3058
639c109b
TZ
30592011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3060
3061 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3062 `gnutls_certificate_set_x509_key_file'.
3063
d2127135
JB
30642011-05-05 Juanma Barranquero <lekktu@gmail.com>
3065
3066 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3067 Update dependencies.
3068
e968f4f3
JB
30692011-05-04 Juanma Barranquero <lekktu@gmail.com>
3070
3071 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3072 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3073 Remove unused parameter `fildes'.
3074 * process.c (read_process_output, send_process): Don't pass it.
3075
84d358f0
JB
30762011-05-04 Juanma Barranquero <lekktu@gmail.com>
3077
3078 Fix previous change: the library cache is defined in w32.c.
3079 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3080 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3081
0898ca10
JB
30822011-05-04 Juanma Barranquero <lekktu@gmail.com>
3083
3084 Implement dynamic loading of GnuTLS on Windows.
3085
3086 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3087 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3088 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3089 Declare.
3090
3091 * gnutls.c (Qgnutls_dll): Define.
3092 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3093 (gnutls_*): Declare function pointers.
3094 (init_gnutls_functions): New function to initialize function pointers.
3095 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3096 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3097 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3098 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3099 (emacs_gnutls_write, emacs_gnutls_read)
3100 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3101 (Fgnutls_available_p): New function.
3102 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3103 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3104 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3105
3106 * image.c: Include w32.h.
3107 (Vimage_type_cache): Delete.
3108 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3109 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3110 (w32_delayed_load): Move to w32.c.
3111
3112 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3113
3114 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3115 (w32_delayed_load): Move from image.c. When loading a library, record
3116 its filename in the :loaded-from property of the library id.
3117 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3118 Initialize and staticpro them.
3119 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3120
3121 * process.c: Include lisp.h before w32.h, not after.
3122 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3123 instead of gnutls_record_check_pending.
3124
3125 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3126
ff4de4aa
TZ
31272011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3128
3129 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3130 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3131 as passed in.
3132
abe95abb
JD
31332011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3134
3135 * xterm.c (x_set_frame_alpha): Do not set property on anything
3136 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3137
e16e55d4
JB
31382011-05-02 Juanma Barranquero <lekktu@gmail.com>
3139
3140 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3141
bafcf6a5
JB
31422011-05-02 Juanma Barranquero <lekktu@gmail.com>
3143
3144 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3145 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3146 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3147 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3148 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3149 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3150 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3151 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3152 (Qgnutls_bootprop_callbacks_verify): Make static.
3153
e7a6747f
AS
31542011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3155
19ed11ba
AS
3156 * callproc.c: Indentation fixup.
3157
e7a6747f 3158 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3159 (wait_for_termination, interruptible_wait_for_termination):
3160 Move after wait_for_termination_1.
e7a6747f 3161
1ef14cb4
LMI
31622011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3163
3164 * sysdep.c (interruptible_wait_for_termination): New function
3165 which is like wait_for_termination, but allows keyboard
3166 interruptions.
3167
3168 * callproc.c (Fcall_process): Add (:file "file") as an option for
3169 the STDOUT buffer.
3170 (Fcall_process_region): Ditto.
3171
330d880c
EZ
31722011-04-30 Eli Zaretskii <eliz@gnu.org>
3173
8db90b73
EZ
3174 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3175 rather than `XVECTOR (FOO)->size'.
3176
330d880c
EZ
3177 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3178 inttypes.h, as a gnulib replacement is used if it not available in
3179 system headers.
3180
15cbd324
EZ
31812011-04-21 Eli Zaretskii <eliz@gnu.org>
3182
3183 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3184 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3185 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3186
3187 * coding.c (coding_alloc_by_realloc): Error out if destination
3188 will grow beyond MOST_POSITIVE_FIXNUM.
3189 (decode_coding_emacs_mule): Abort if there isn't enough place in
3190 charbuf for the composition carryover bytes. Reserve an extra
3191 space for up to 2 characters produced in a loop.
3192 (decode_coding_iso_2022): Abort if there isn't enough place in
3193 charbuf for the composition carryover bytes.
3194
31952011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3196
ae940cca
EZ
3197 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3198 aborting when %lld or %lll format is passed.
3199 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3200 %llo or %llx format is passed. (Bug#8545)
3201
03ab8921
EZ
3202 * window.c (window_scroll_line_based): Use a marker instead of
3203 simple variables to record original value of point. (Bug#7952)
3204
afda1437
EZ
3205 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3206 produced by %s or %c overflows available buffer space. (Bug#8545)
3207
f76dee0c
PE
32082011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3209
3210 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3211 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3212
fdc5744d
JB
32132011-04-28 Juanma Barranquero <lekktu@gmail.com>
3214
3215 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3216
638f053a
JB
32172011-04-28 Juanma Barranquero <lekktu@gmail.com>
3218
3219 * keyboard.c (Qdelayed_warnings_hook): Define.
3220 (command_loop_1): Run `delayed-warnings-hook'
3221 if Vdelayed_warnings_list is non-nil.
3222 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3223 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3224
d178f871
EZ
32252011-04-28 Eli Zaretskii <eliz@gnu.org>
3226
3227 * doprnt.c (doprnt): Don't return value smaller than the buffer
3228 size if the message was truncated. (Bug#8545).
3229
b124fd93
JB
32302011-04-28 Juanma Barranquero <lekktu@gmail.com>
3231
3232 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3233 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3234
e810457d
PE
32352011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3236
3237 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3238
ea51cceb
JB
32392011-04-27 Juanma Barranquero <lekktu@gmail.com>
3240
3241 * makefile.w32-in: Update dependencies.
3242
94dcfacf
EZ
32432011-04-27 Eli Zaretskii <eliz@gnu.org>
3244
3245 Improve `doprnt' and its usage. (Bug#8545)
3246 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3247 `format_end'. Remove support for %l as a conversion specifier.
3248 Don't use xrealloc. Improve diagnostics when the %l size modifier
3249 is used. Update the commentary.
3250
3251 * eval.c (verror): Simplify calculation of size_t.
3252
3253 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3254 messages.
3255
f61f41d7
PE
32562011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3257
3258 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3259 change.
3260
96fb4434
PE
32612011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3262
3263 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3264 This makes this file independent of the recent pseudovector change.
3265
671875da 32662011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3267
69e9b5a3
PE
3268 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3269
b5f869a7 3270 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3271 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3272 Remove unused local.
c8926152 3273 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3274
841a1577 3275 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3276 GCC 4.6.0 optimizes based on type-based alias analysis.
3277 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3278 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3279 != &v->size, and therefore "v->size = 1; b->size = 2; return
3280 v->size;" must therefore return 1. This assumption is incorrect
3281 for Emacs, since it type-puns struct Lisp_Vector * with many other
3282 types. To fix this problem, this patch adds a new type struct
f904488f 3283 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3284 and pseudovectors, and helps optimizing compilers not get fooled
3285 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3286 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3287 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3288 the size member.
eab3844f
PE
3289 (XSETPVECTYPE): Rewrite in terms of new macro.
3290 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3291 This is a bit clearer, and further avoids the possibility of
3292 undesirable aliasing.
3293 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3294 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3295 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3296 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3297 (ASIZE): Now uses header.size rather than size.
3298 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3299 to avoid the hassle of writing XVECTOR (foo)->header.size.
3300 (struct vectorlike_header): New type.
eab3844f
PE
3301 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3302 object, to help avoid aliasing.
3303 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3304 (SUBRP): Likewise, since Lisp_Subr is a special case.
3305 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3306 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3307 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3308 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3309 changed to be "header.size" and "header.next".
3310 * buffer.h (struct buffer): Likewise.
3311 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3312 * frame.h (struct frame): Likewise.
3313 * process.h (struct Lisp_Process): Likewise.
3314 * termhooks.h (struct terminal): Likewise.
3315 * window.c (struct save_window_data, struct saved_window): Likewise.
3316 * window.h (struct window): Likewise.
3317 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3318 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3319 * buffer.c (init_buffer_once): Likewise.
3320 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3321 special case.
3322 * process.c (Fformat_network_address): Use local var for size,
3323 for brevity.
3324
0df1eac5
PE
3325 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3326
847ab9d1 3327 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3328 * data.c (atof): Remove decl; no longer used or needed.
3329 (digit_to_number): Move to lread.c.
3330 (Fstring_to_number): Use new string_to_number function, to be
3331 consistent with how the Lisp reader treats infinities and NaNs.
3332 Do not assume that floating-point numbers represent EMACS_INT
3333 without losing information; this is not true on most 64-bit hosts.
3334 Avoid double-rounding errors, by insisting on integers when
3335 parsing non-base-10 numbers, as the documentation specifies.
3336 * lisp.h (string_to_number): New decl, replacing ...
3337 (isfloat_string): Remove.
bc0a5c13 3338 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3339 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3340 appears to have been a coding error. Similarly, do not accept
3341 strings like +-1e0 as floating point numbers. Do not report
3342 overflow for integer overflows unless the base is not 10 which
3343 means we have no simple and reliable way to continue.
3344 Break out the floating-point parsing into a new
3345 function string_to_number, so that Fstring_to_number parses
3346 floating point numbers consistently with the Lisp reader.
04f2d78b 3347 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3348 (E_CHAR, EXP_INT): Remove, replacing with ...
3349 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3350 (string_to_number): New function, replacing isfloat_string.
3351 This function checks for valid syntax and produces the resulting
3352 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3353 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3354 so that overflow for non-base-10 numbers is reported only when
3355 there's no portable and simple way to convert to floating point.
452f4150 3356
67769ffc
PE
3357 * textprop.c (set_text_properties_1): Rewrite for clarity,
3358 and to avoid GCC warning about integer overflow.
3359
c20db43f
PE
3360 * intervals.h (struct interval): Use EMACS_INT for members
3361 where EMACS_UINT might cause problems. See
3362 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3363 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3364 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3365 All uses changed.
37aa2f85
PE
3366 (offset_intervals): Tell GCC not to worry about length overflow
3367 when negating a negative length.
c20db43f 3368
2538aa2f
PE
3369 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3370 (overrun_check_free): Likewise.
3371
f2d3008d
PE
3372 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3373 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3374 word size.
3375
ec8df744
PE
3376 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3377 (gnutls_make_error): Rename local to avoid shadowing.
3378 (gnutls_emacs_global_deinit): ifdef out; not used.
3379 (Fgnutls_boot): Use const for pointer to readonly storage.
3380 Comment out unused local. Fix pointer signedness problems.
3381
640ee02d
PE
3382 * lread.c (openp): Don't stuff size_t into an 'int'.
3383 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3384 about possible signed overflow.
3385
6048fb2a
PE
3386 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3387 (GDK_KEY_g): Don't define if already defined.
3388 (xg_prepare_tooltip): Avoid pointer signedness problem.
3389 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3390
fa3c87e1
PE
3391 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3392 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3393
2172544b
PE
3394 * xfns.c (Fx_window_property): Simplify a bit,
3395 to make a bit faster and to avoid GCC 4.6.0 warning.
3396 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3397
9b821a21
PE
3398 * fns.c (internal_equal): Don't assume size_t fits in int.
3399
3c616cfa
PE
3400 * alloc.c (compact_small_strings): Tighten assertion a little.
3401
c2982e87
PE
3402 Replace pEd with more-general pI, and fix some printf arg casts.
3403 * lisp.h (pI): New macro, generalizing old pEd macro to other
3404 conversion specifiers. For example, use "...%"pI"d..." rather
3405 than "...%"pEd"...".
3406 (pEd): Remove. All uses replaced with similar uses of pI.
3407 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3408 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3409 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3410 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3411 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3412 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3413 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3414 64-bit hosts.
3415 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3416 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3417 * print.c (safe_debug_print, print_object): Likewise.
3418 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3419 to int.
6f04d126
PE
3420 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3421 avoiding the 0 flag, which is not portable.
c2982e87
PE
3422 * process.c (Fmake_network_process): Use pI to avoid cast.
3423 * region-cache.c (pp_cache): Likewise.
3424 * xdisp.c (decode_mode_spec): Likewise.
3425 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3426 behavior on 64-bit hosts with printf arg.
6f04d126 3427 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3428 (x_stop_queuing_selection_requests): Likewise.
3429 (x_get_window_property): Don't truncate byte count to an 'int'
3430 when tracing.
0b432f21 3431
5e073ec7
PE
3432 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3433 here, since it parses constructs like leading '-' and spaces,
3434 which are not wanted; and it overflows with large numbers.
3435 Instead, simply match F[0-9]+, which is what is wanted anyway.
3436
36372bf9
PE
3437 * alloc.c: Remove unportable assumptions about struct layout.
3438 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3439 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3440 (allocate_vectorlike, make_pure_vector): Use the new macros,
3441 plus offsetof, to remove unportable assumptions about struct layout.
3442 These assumptions hold on all porting targets that I know of, but
3443 they are not guaranteed, they're easy to remove, and removing them
3444 makes further changes easier.
3445
0b432f21
PE
3446 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3447 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3448 (string_overrun_cookie): Now const. Use initializers that
3449 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3450 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3451 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3452 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3453 multiple of sizeof (EMACS_INT); it need not be, if
3454 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3455 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3456
895009e1
JB
34572011-04-26 Juanma Barranquero <lekktu@gmail.com>
3458
3459 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3460
6a7a1b0b
TZ
34612011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3462
3463 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3464 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3465 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3466
841a1577 34672011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3468
3469 * lisp.h (Qdebug): List symbol.
895009e1 3470 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3471 * keyboard.c (debug-on-event): New variable.
3472 (handle_user_signal): Break into debugger when debug-on-event
3473 matches the current signal symbol.
3474
f2d3ba6f
DN
34752011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3476
3477 * alloc.c (check_sblock, check_string_bytes)
3478 (check_string_free_list): Convert to standard C.
3479
42ce4c63
TZ
34802011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3481
3482 * w32.c (emacs_gnutls_push): Fix typo.
3483
825cd63c
EZ
34842011-04-25 Eli Zaretskii <eliz@gnu.org>
3485
fb11d64d
EZ
3486 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3487 "cast to pointer from integer of different size".
3488
825cd63c
EZ
3489 Improve doprnt and its use in verror. (Bug#8545)
3490 * doprnt.c (doprnt): Document the set of format control sequences
3491 supported by the function. Use SAFE_ALLOCA instead of always
3492 using `alloca'.
3493
3494 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3495 is one byte too soon. Don't use xrealloc; instead xfree and
3496 xmalloc anew.
3497
e061a11b
TZ
34982011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3499
3500 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3501 callbacks stage.
3502
3503 * gnutls.c: Renamed global_initialized to
3504 gnutls_global_initialized. Added internals for the
3505 :verify-hostname-error, :verify-error, and :verify-flags
3506 parameters of `gnutls-boot' and documented those parameters in the
3507 docstring. Start callback support.
9173deec
JB
3508 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3509 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3510 on error. Return error code.
e061a11b
TZ
3511 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3512 (emacs_gnutls_read): Likewise.
3513 (Fgnutls_boot): Return handshake error code.
3514 (emacs_gnutls_handle_error): New function.
3515 (wsaerror_to_errno): Likewise.
3516
3517 * w32.h (emacs_gnutls_pull): Add prototype.
3518 (emacs_gnutls_push): Likewise.
3519
3520 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3521 (emacs_gnutls_push): Likewise.
3522
35232011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3524
3525 * process.c (wait_reading_process_output): Check if GnuTLS
3526 buffered some data internally if no FDs are set for TLS
3527 connections.
3528
3529 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3530 (LIBS): Link to USER_LIBS.
3531 ($(BLD)/gnutls.$(0)): New target.
3532
fa6996bc
EZ
35332011-04-24 Eli Zaretskii <eliz@gnu.org>
3534
eb35682e
EZ
3535 * xdisp.c (handle_single_display_spec): Rename the
3536 display_replaced_before_p argument into display_replaced_p, to
3537 make it consistent with the commentary. Fix typos in the
3538 commentary.
3539
e2ad650c
EZ
3540 * textprop.c (syms_of_textprop): Remove dead code.
3541 (copy_text_properties): Delete obsolete commentary about an
3542 interface that was deleted long ago. Fix typos in the description
3543 of arguments.
3544
1b2de274
EZ
3545 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3546 to changes in oldXMenu/XMenu.h from 2011-04-16.
3547 <menu_help_message, prev_menu_help_message>: Constify.
3548 (IT_menu_make_room): menu->help_text is now `const char **';
3549 adjust.
3550
3551 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3552 to changes in oldXMenu/XMenu.h from 2011-04-16.
3553 (struct XMenu): Declare `help_text' `const char **'.
3554
3555 * xfaces.c <Qunspecified>: Make extern again.
3556
3557 * syntax.c: Include sys/types.h before including regex.h, as
3558 required by Posix.
3559
762b15be
EZ
3560 * doc.c (get_doc_string): Improve the format passed to `error'.
3561
3562 * doprnt.c (doprnt): Improve commentary.
3563
3564 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3565
3566 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3567 them with etags.
3568
f1052e5d
EZ
3569 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3570 changes in globals.h immediately force recompilation.
762b15be
EZ
3571 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3572 $(CURDIR)/s/ms-w32.h.
3573 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3574
fa6996bc
EZ
3575 * character.c (Fchar_direction): Function deleted.
3576 (syms_of_character): Don't defsubr it.
3577 <char-direction-table>: Deleted.
3578
e6c3da20
EZ
35792011-04-23 Eli Zaretskii <eliz@gnu.org>
3580
3581 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3582 * doprnt.c: Include limits.h.
3583 (SIZE_MAX): New macro.
04f2d78b
CB
3584 (doprnt): Return a size_t value. 2nd arg is now size_t.
3585 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3586 Improve overflow protection. Support `l' modifier for integer
3587 conversions. Support %l conversion. Don't assume an EMACS_INT
3588 argument for integer conversions and for %c.
3589
3590 * lisp.h (doprnt): Restore prototype.
3591
3592 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3593 $(SRC)/character.h.
3594
3595 * Makefile.in (base_obj): Add back doprnt.o.
3596
3597 * deps.mk (doprnt.o): Add back prerequisites.
3598 (callint.o): Depend on character.h.
3599
3600 * eval.c (internal_lisp_condition_case): Include the handler
3601 representation in the error message.
3602 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3603 when breaking from the loop.
3604
3605 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3606
3607 * callint.c (Fcall_interactively): When displaying error message
3608 about invalid control letter, pass the character's codepoint, not
3609 a pointer to its multibyte form. Improve display of the character
3610 in octal and display also its hex code.
3611
3612 * character.c (char_string): Use %x to display the (unsigned)
3613 codepoint of an invalid character, to avoid displaying a bogus
3614 negative value.
3615
3616 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3617 `error', not SYMBOL_NAME itself.
3618
3619 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3620 character arguments to `error'.
3621
3622 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3623 to `error' in error message about FINAL_CHAR argument. Make sure
3624 FINAL_CHAR is a character, and use %c when it is passed as
3625 argument to `error'.
3626
4ffd0d6b 36272011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3628
3629 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3630
3631 * w32.c: Include <time.h>.
3632 (sys_localtime): New function.
3633
4ffd0d6b 36342011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3635
3636 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3637
4ffd0d6b 3638 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3639
4ffd0d6b 36402011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3641
4ffd0d6b
GM
3642 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3643 zombies (Bug#8467).
aac0c6e3 3644
04c56954
EZ
36452011-04-19 Eli Zaretskii <eliz@gnu.org>
3646
3647 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3648 gl_state.e_property when gl_state.object is Qt.
3649
3650 * insdel.c (make_gap_larger): Remove limitation of buffer size
3651 to <= INT_MAX.
3652
16a43933
CY
36532011-04-18 Chong Yidong <cyd@stupidchicken.com>
3654
3655 * xdisp.c (lookup_glyphless_char_display)
3656 (produce_glyphless_glyph): Handle cons cell entry in
3657 glyphless-char-display.
3658 (Vglyphless_char_display): Document it.
3659
3660 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3661 glyphless-char-display.
3662
4581706e
CY
36632011-04-17 Chong Yidong <cyd@stupidchicken.com>
3664
3665 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3666
3667 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3668
3669 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3670 definition for no-X builds.
3671
4887c6e2 36722011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3673
fd35b6f9
PE
3674 Static checks with GCC 4.6.0 and non-default toolkits.
3675
5c1ccb01
PE
3676 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3677
006c5daa
PE
3678 * process.c (keyboard_bit_set): Define only if SIGIO.
3679 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3680 (send_process): Repair possible setjmp clobbering.
3681
efc736d3
PE
3682 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3683
4e2fe2e6
PE
3684 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3685
f97334a2
PE
3686 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3687
4e75f29d
PE
3688 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3689 Define only if needed.
3690
90efadd1
PE
3691 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3692 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3693 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3694
3c647824
PE
3695 * dispextern.h (struct redisplay_interface): Rename param
3696 to avoid shadowing.
e264f262 3697 * termhooks.h (struct terminal): Likewise.
761383f4 3698 * xterm.c (xembed_send_message): Likewise.
3c647824 3699
b58c5c4a
PE
3700 * insdel.c (make_gap_smaller): Define only if
3701 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3702
cad59032
PE
3703 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3704 it.
3705
c339dc2e
PE
3706 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3707 so that we aren't warned about unused symbols.
3708
91a3e27b
PE
3709 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3710
399c71d3 3711 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3712
8ffc96f5
PE
3713 * xfns.c (x_real_positions): Mark locals as initialized.
3714
eef9bc79
PE
3715 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3716
098db9dd
PE
3717 * xterm.c: Fix problems found by static analysis with other toolkits.
3718 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3719 (x_dispatch_event): Declare static if USE_GTK, and
3720 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3721 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3722 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3723 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3724 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3725
eb18f6cc
PE
3726 * xmenu.c (menu_help_callback): Pointer type fixes.
3727 Use const pointers when pointing at readonly data. Avoid pointer
3728 signedness clashes.
3729 (FALSE): Remove unused macro.
3730 (update_frame_menubar): Remove unused decl.
3731
1fe72bf8
PE
3732 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3733
60d9e1db
PE
3734 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3735 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3736 (single_menu_item): Rename local to avoid shadowing.
3737
39261c26
PE
3738 * keyboard.c (make_lispy_event): Remove unused local var.
3739
018c5e19
PE
3740 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3741 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3742
63d2b86e
PE
3743 * bitmaps: Change bitmaps from unsigned char back to the X11
3744 compatible char. Avoid the old compiler warnings about
3745 out-of-range initializers by using, for example, '\xab' rather
3746 than 0xab.
3747
aefd87e1
PE
3748 * xgselect.c (xgselect_initialize): Check vs interface
3749 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3750
bf501fb9
PE
3751 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3752
e9829fdf
PE
3753 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3754 to read-only memory.
3755
1086c095
PE
3756 * fns.c (vector): Remove; this old hack is no longer needed.
3757
2baccd04 3758 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3759 Remove unused var.
dde42981 3760 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3761
72391843 3762 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3763
436c16df 3764 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3765 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3766 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3767
92bb796d 3768 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3769 (x_term_init): Remove local to avoid shadowing.
92bb796d 3770
764430a3 3771 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3772
3773 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3774 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3775
d1dfb56c
EZ
37762011-04-16 Eli Zaretskii <eliz@gnu.org>
3777
c4354cb4
EZ
3778 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3779
d1dfb56c
EZ
3780 Fix regex.c, syntax.c and friends for buffers > 2GB.
3781 * syntax.h (struct gl_state_s): Declare character position members
3782 EMACS_INT.
3783
3784 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3785
04f2d78b
CB
3786 * textprop.c (verify_interval_modification, interval_of):
3787 Declare arguments EMACS_INT.
d1dfb56c
EZ
3788
3789 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3790 EMACS_INT.
3791
3792 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3793
3794 * indent.c (Fvertical_motion): Local variable it_start is now
3795 EMACS_INT.
3796
3797 * regex.c (re_match, re_match_2, re_match_2_internal)
3798 (bcmp_translate, regcomp, regexec, print_double_string)
3799 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3800 (re_compile_pattern, re_exec): Declare arguments and local
3801 variables `size_t' and `ssize_t' and return values `regoff_t', as
3802 appropriate.
3803 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3804 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3805 <compile_stack_type>: `size' and `avail' are now `size_t'.
3806
3807 * regex.h <regoff_t>: Use ssize_t, not int.
3808 (re_search, re_search_2, re_match, re_match_2): Arguments that
3809 specify buffer/string position and length are now ssize_t and
3810 size_t. Return type is regoff_t.
3811
613052cd
BK
38122011-04-16 Ben Key <bkey76@gmail.com>
3813
3814 * nsfont.m: Fixed bugs in ns_get_family and
3815 ns_descriptor_to_entity that were caused by using free to
3816 deallocate memory blocks that were allocated by xmalloc (via
3817 xstrdup). This caused Emacs to crash when compiled with
3818 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3819 --enable-checking=xmallocoverrun). xfree is now used to
3820 deallocate these memory blocks.
3821
4170f62f 38222011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3823
71b41406
PE
3824 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3825
9587a89d
PE
3826 emacs_write: Accept and return EMACS_INT for sizes.
3827 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3828 et seq.
3829 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3830 Accept and return EMACS_INT.
3831 (emacs_gnutls_write): Return the number of bytes written on
3832 partial writes.
3833 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3834 (emacs_read, emacs_write): Remove check for negative size, as the
3835 Emacs source code has been audited now.
9587a89d
PE
3836 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3837 (emacs_read, emacs_write): Use it.
273a5f82
PE
3838 * process.c (send_process): Adjust to the new signatures of
3839 emacs_write and emacs_gnutls_write. Do not attempt to store
3840 a byte offset into an 'int'; it might overflow.
9587a89d 3841 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3842
3e047f51
PE
3843 * sound.c: Don't assume sizes fit in 'int'.
3844 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3845 Return EMACS_INT, not int.
3e047f51 3846 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3847 Accept EMACS_INT, not int.
3848 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3849 record read return values.
3850
cc39a9db
BK
38512011-04-15 Ben Key <bkey76@gmail.com>
3852
c9d0ec6d
JB
3853 * keyboard.c (Qundefined): Don't declare static since it is used
3854 in nsfns.m.
3855 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3856 static since they are used in nsfont.m.
cc39a9db 3857
6c60eb9f
SM
38582011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3859
3860 * process.c (Qprocessp): Don't declare static.
3861 * lisp.h (Qprocessp): Declare again.
3862
7990b61a
JB
38632011-04-15 Juanma Barranquero <lekktu@gmail.com>
3864
3865 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3866
5d4cb038
PE
38672011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3868
8bd7b830 3869 Improve C-level modularity by making more things 'static'.
cd64ea1d 3870
e3b27b31
PE
3871 Don't publish debugger-only interfaces to other modules.
3872 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3873 (verify_bytepos, count_markers): Move decls to the only modules
3874 that need them.
3875 * region-cache.h (pp_cache): Likewise.
3876 * window.h (check_all_windows): Likewise.
3877 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3878
5d4cb038
PE
3879 * sysdep.c (croak): Now static, if
3880 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3881 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3882
3883 * alloc.c (refill_memory_reserve): Now static if
3884 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3885 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3886
e87b6180
PE
3887 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3888 Define only if USE_LUCID.
3889
ac64929e
PE
3890 * xrdb.c (x_customization_string, x_rm_string): Now static.
3891
6f37259d
PE
3892 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3893 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3894
1683e3ab
PE
3895 * xdisp.c (draw_row_with_mouse_face): Now static.
3896 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3897
de9c2632
PE
3898 * window.h (check_all_windows): Mark externally visible.
3899
2b96acb7
PE
3900 * window.c (window_deletion_count): Now static.
3901
3902 * undo.c: Make symbols static if they're not exported.
3903 (last_undo_buffer, last_boundary_position, pending_boundary):
3904 Now static.
3905
50436f33
PE
3906 * textprop.c (interval_insert_behind_hooks): Now static.
3907 (interval_insert_in_front_hooks): Likewise.
3908
64520e5c
PE
3909 * term.c: Make symbols static if they're not exported.
3910 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3911 (max_frame_lines, tty_set_terminal_modes):
3912 (tty_reset_terminal_modes, tty_turn_off_highlight):
3913 (get_tty_terminal): Now static.
3914 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3915 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3916 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3917 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3918 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3919
1fa53021
PE
3920 * sysdep.c: Make symbols static if they're not exported.
3921 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3922 Now static.
3923 (sigprocmask_set, full_mask): Remove; unused.
3924 (wait_debugging): Mark as visible.
3925 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3926 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3927
d4b43b22
PE
3928 * syntax.c (syntax_temp): Define only if !__GNUC__.
3929
b7c513d0
PE
3930 * sound.c (current_sound_device, current_sound): Now static.
3931
989b29ad
PE
3932 * search.c (searchbufs, searchbuf_head): Now static.
3933
13a55a78
PE
3934 * scroll.c (scroll_cost): Remove; unused.
3935 * dispextern.h (scroll_cost): Remove decl.
3936
de68a1fc
PE
3937 * region-cache.h (pp_cache): Mark as externally visible.
3938
40ccffa6
PE
3939 * process.c: Make symbols static if they're not exported.
3940 (process_tick, update_tick, create_process, chan_process):
3941 (Vprocess_alist, proc_buffered_char, datagram_access):
3942 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3943 (deactivate_process): Mark defn as static, as well as decl.
3944 * lisp.h (create_process): Remove decl.
3945 * process.h (chan_process, Vprocess_alist): Remove decls.
3946
ad64fc97
PE
3947 * print.c: Make symbols static if they're not exported.
3948 (print_depth, new_backquote_output, being_printed, print_buffer):
3949 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3950 (print_interval, print_number_index, initial_stderr_stream):
3951 Now static.
3952 * lisp.h (Fprinc): Remove decl.
3953 (debug_output_compilation_hack): Mark as externally visible.
3954
adddb265
PE
3955 * sysdep.c (croak): Move decl from here to syssignal.h.
3956 * syssignal.h (croak): Put it here, so the API can be checked when
3957 'croak' is called from dissociate_if_controlling_tty.
3958
1717ede2
PE
3959 * minibuf.c: Make symbols static if they're not exported.
3960 (minibuf_save_list, choose_minibuf_frame): Now static.
3961 * lisp.h (choose_minibuf_frame): Remove decl.
3962
fa5fb2bc
PE
3963 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3964
1e3890d1
PE
3965 * lread.c: Make symbols static if they're not exported.
3966 (read_objects, initial_obarray, oblookup_last_bucket_number):
3967 Now static.
3968 (make_symbol): Remove; unused.
3969 * lisp.h (initial_obarray, make_symbol): Remove decls.
3970
8a1414fa
PE
3971 * keyboard.c: Make symbols static if they're not exported.
3972 (single_kboard, recent_keys_index, total_keys, recent_keys):
3973 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3974 (this_single_command_key_start, echoing, last_auto_save):
3975 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3976 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3977 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3978 (Vlispy_mouse_stem, double_click_count):
3979 Now static.
3980 (force_auto_save_soon): Define only if SIGDANGER.
3981 (ignore_mouse_drag_p): Now static if
3982 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3983 (print_help): Remove; unused.
3984 (stop_character, last_timer_event): Mark as externally visible.
3985 * keyboard.h (ignore_mouse_drag_p): Declare only if
3986 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3987 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3988 * lisp.h (echoing): Remove decl.
3989 (force_auto_save_soon): Declare only if SIGDANGER.
3990 * xdisp.c (redisplay_window): Simplify code, to make it more
3991 obvious that ignore_mouse_drag_p is not accessed if !defined
3992 USE_GTK && !defined HAVE_NS.
3993
93ea6e8f
PE
3994 * intervals.c: Make symbols static if they're not exported.
3995 (merge_properties_sticky, merge_interval_right, delete_interval):
3996 Now static.
3997 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3998
77382fcc
PE
3999 * insdel.c: Make symbols static if they're not exported.
4000 However, leave prepare_to_modify_buffer alone. It's never
4001 called from outside this function, but that appears to be a bug.
4002 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4003 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4004 (adjust_after_replace_noundo): Remove; unused.
4005 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4006 (signal_before_change): Remove decls.
77382fcc 4007
9306c32e
PE
4008 * indent.c (val_compute_motion, val_vmotion): Now static.
4009
cd44d2eb
PE
4010 * image.c: Make symbols static if they're not exported.
4011 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4012 if USE_GTK.
4013 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4014 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4015
ad9a7a06
PE
4016 * fringe.c (standard_bitmaps): Now static.
4017 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4018
81626931
PE
4019 * frame.c: Make symbols static if they're not exported.
4020 (x_report_frame_params, make_terminal_frame): Now static.
4021 (get_frame_param): Now static, unless HAVE_NS.
4022 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4023 (x_get_resource_string): Remove; not used.
4024 * frame.h (make_terminal_frame, x_report_frame_params):
4025 (x_get_resource_string); Remove decls.
4026 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4027 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4028
239f9db9
PE
4029 * font.c, fontset.c: Make symbols static if they're not exported.
4030 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4031 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4032 * font.c (font_close_object): Now static.
4033 * font.h (font_close_object): Remove.
4034 * fontset.c (FONTSET_OBJLIST): Remove.
4035 (free_realized_fontset) #if-0 the body, which does nothing.
4036 (face_suitable_for_char_p): #if-0, as it's never called.
4037 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4038 * xfaces.c (face_at_string_position):
4039 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4040 since 0 is always ASCII.
4041
dfcf3579
PE
4042 * fns.c (weak_hash_tables): Now static.
4043
5045092b
PE
4044 * fileio.c: Make symbols static if they're not exported.
4045 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4046 (Vwrite_region_annotation_buffers): Now static.
4047
57a96f5c
PE
4048 * eval.c: Make symbols static if they're not exported.
4049 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4050 * lisp.h (backtrace_list): Remove decl.
4051
35f08c38
PE
4052 * emacs.c: Make symbols static if they're not exported.
4053 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4054 (fatal_error_code, fatal_error_signal_hook, standard_args):
4055 Now static.
4056 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4057 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4058 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4059 * lisp.h (fatal_error_signal_hook): Remove decl.
4060 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4061
f44bd759
PE
4062 * editfns.c: Move a (normally-unused) function to its only use.
4063 * editfns.c, lisp.h (get_operating_system_release): Remove.
4064 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4065 worth the hassle of breaking this out.
4066
b532497d
PE
4067 * xterm.c: Make symbols static if they're not exported.
4068 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4069 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4070 (x_destroy_window, x_delete_display):
4071 Now static.
4072 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4073 (x_mouse_leave): Remove; unused.
4074 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4075 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4076 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4077 Remove decls.
4078 (x_mouse_leave): Declare only if WINDOWSNT.
4079 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4080 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4081 USE_X_TOOLKIT.
4082
1675728f
PE
4083 * ftxfont.c: Make symbols static if they're not exported.
4084 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4085 HAVE_FREETYPE.
4086 * font.h (ftxfont_driver): Likewise.
4087
e4cebfca
PE
4088 * xfns.c: Make symbols static if they're not exported.
4089 (x_last_font_name, x_display_info_for_name):
4090 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4091 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4092 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4093 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4094 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4095 (last_show_tip_args): Now static.
4096 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4097 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4098 (x_screen_planes): Remove; unused.
4099 * dispextern.h (x_screen_planes): Remove decl.
4100
5bf46f05
PE
4101 * dispnew.c: Make symbols static if they're not exported.
4102 * dispextern.h (redraw_garbaged_frames, scrolling):
4103 (increment_row_positions): Remove.
4104 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4105 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4106 Now static.
4107 (redraw_garbaged_frames): Remove; unused.
4108
435f4c28
PE
4109 * xfaces.c: Make symbols static if they're not exported.
4110 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4111 Remove decls.
4112 * xterm.h (defined_color): Remove decls.
4113 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4114 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4115 (menu_face_changed_default, defined_color, free_realized_face):
4116 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4117 (ascii_face_of_lisp_face): Remove; unused.
4118
8524aef3
PE
4119 * xdisp.c: Make symbols static if they're not exported.
4120 * dispextern.h (scratch_glyph_row, window_box_edges):
4121 (glyph_to_pixel_coords, set_cursor_from_row):
4122 (get_next_display_element, set_iterator_to_next):
4123 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4124 (show_mouse_face): Remove decls
4125 * frame.h (message_buf_print): Likewise.
4126 * lisp.h (pop_message, set_message, check_point_in_composition):
4127 Likewise.
4128 * xterm.h (set_vertical_scroll_bar): Likewise.
4129 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4130 (message_buf_print, scratch_glyph_row, displayed_buffer):
4131 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4132 (get_next_display_element, show_mouse_face, window_box_edges):
4133 (frame_to_window_pixel_xy, check_point_in_composition):
4134 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4135 (glyph_to_pixel_coords): Remove; unused.
4136
16390cd2
PE
4137 * dired.c (file_name_completion): Now static.
4138
4139 * dbusbind.c (xd_in_read_queued_messages): Now static.
4140
a25f4dfa
PE
4141 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4142 * data.c (circular_list_error): Remove.
4143
14a9c8df
PE
4144 * commands.h (last_point_position, last_point_position_buffer):
4145 (last_point_position_window): Remove decls.
4146 * keyboard.c: Make these variables static.
4147
04f2d78b
CB
4148 * coding.h (coding, code_convert_region, encode_coding_gap):
4149 Remove decls.
74ab6df5
PE
4150 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4151 (iso_code_class, detect_coding, code_convert_region): Now static.
4152 (encode_coding_gap): Remove; unused.
4153
38dfbee1
PE
4154 * chartab.c (chartab_chars, chartab_bits): Now static.
4155
a2cb4e63
PE
4156 * charset.h (charset_iso_8859_1): Remove decl.
4157 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4158 Now static.
4159
127198fd
PE
4160 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4161 * ccl.c (Vccl_program_table): Now static.
4162 (check_ccl_update): Remove; unused.
4163
d85b608f
PE
4164 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4165 * category.h: ... from here.
4166 * category.c (check_category_table, set_category_set): Now static.
4167
31cd66f3
PE
4168 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4169 * lisp.h: Remove these decls.
4170
c358e587
PE
4171 * buffer.c (buffer_count): Remove unused var.
4172
e78aecca
PE
4173 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4174 so that it's not optimized away.
4175 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4176 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4177 exported only to the debugger.
4178
e192d7d3 4179 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4180 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4181
92470028
PE
4182 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4183 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4184 was inaccessible from Lisp.
4185 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4186 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4187
244ed907
PE
4188 alloc.c: Import and export fewer symbols, and remove unused items.
4189 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4190 is defined.
4191 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4192 it's not optimized away by whole-program optimization.
4193 (message_enable_multibyte, free_misc): Remove.
4194 (catchlist, handlerlist, mark_backtrace):
4195 Declare only if BYTE_MARK_STACK.
4196 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4197 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4198 (message_enable_multibyte): Remove decl.
4199 (free_misc, interval_free_list, float_block, float_block_index):
4200 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4201 (cons_free_list, last_marked_index):
4202 Now static.
4203 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4204 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4205 (mark_backtrace): Define only if BYTE_MARK_STACK.
4206 * xdisp.c (message_enable_multibyte): Now static.
4207
61c2b50e 4208 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4209 This makes it easier for human readers (and static analyzers)
4210 to see whether these variables are used from other modules.
4211 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4212 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4213 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4214 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4215 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4216 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4217 * xmenu.c, xselect.c:
4218 Declare Q* vars static if they are not used in other modules.
4219 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4220 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4221 Remove decls of unexported vars.
4222 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4223
95c82688
PE
4224 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4225
16a97296
PE
4226 Make Emacs functions such as Fatom 'static' by default.
4227 This makes it easier for human readers (and static analyzers)
4228 to see whether these functions can be called from other modules.
4229 DEFUN now defines a static function. To make the function external
4230 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4231 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4232 (Finit_image_library):
16a97296
PE
4233 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4234 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4235 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4236 Remove decls, since these functions are now static.
4237 (Funintern, Fget_internal_run_time): New decls, since these functions
4238 were already external.
95c82688 4239
16a97296
PE
4240 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4241 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4242 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4243 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4244 * keyboard.c, keymap.c, lread.c:
4245 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4246 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4247 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4248 Mark functions with DEFUE instead of DEFUN,
4249 if they are used in other modules.
4250 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4251 decls for now-static functions.
4252 * buffer.h (Fdelete_overlay): Remove decl.
4253 * callproc.c (Fgetenv_internal): Mark as internal.
4254 * composite.c (Fremove_list_of_text_properties): Remove decl.
4255 (Fcomposition_get_gstring): New forward static decl.
4256 * composite.h (Fcomposite_get_gstring): Remove decl.
4257 * dired.c (Ffile_attributes): New forward static decl.
4258 * doc.c (Fdocumntation_property): New forward static decl.
4259 * eval.c (Ffetch_bytecode): New forward static decl.
4260 (Funintern): Remove extern decl; now in .h file where it belongs.
4261 * fileio.c (Fmake_symbolic_link): New forward static decl.
4262 * image.c (Finit_image_library): New forward static decl.
4263 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4264 * intervals.h (Fprevious_property_change):
4265 (Fremove_list_of_text_properties): Remove decls.
4266 * keyboard.c (Fthis_command_keys): Remove decl.
4267 (Fcommand_execute): New forward static decl.
4268 * keymap.c (Flookup_key): New forward static decl.
4269 (Fcopy_keymap): Now static.
4270 * keymap.h (Flookup_key): Remove decl.
4271 * process.c (Fget_process): New forward static decl.
4272 (Fprocess_datagram_address): Mark as internal.
4273 * syntax.c (Fsyntax_table_p): New forward static decl.
4274 (skip_chars): Remove duplicate decl.
4275 * textprop.c (Fprevious_property_change): New forward static decl.
4276 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4277 Now internal.
4278 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4279 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4280
785bbd42
PE
4281 * editfns.c (Fformat): Remove unreachable code.
4282
8b913b57
AS
42832011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4284
4285 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4286 change. (Bug#8496)
4287
a6744a35
EZ
42882011-04-13 Eli Zaretskii <eliz@gnu.org>
4289
4290 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4291 when at ZV. (Bug#8487)
4292
e7974947
AS
42932011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4294
baad03f0
AS
4295 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4296 (Bug#8437)
4297 * keyboard.c (parse_tool_bar_item): Likewise.
4298 * sound.c (sound_cleanup, alsa_close): Likewise.
4299 * termcap.c (tgetent): Likewise.
4300 * xfns.c (x_default_font_parameter): Likewise.
4301 * xsettings.c (read_and_apply_settings): Likewise.
4302
e7974947
AS
4303 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4304 (overrun_check_free): Protoize.
4305
28272684
PE
43062011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4307
4308 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4309 since callers should never pass a negative size.
4310 Change the signature to match that of plain 'read' and 'write'; see
4311 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4312 * lisp.h: Update prototypes of emacs_write and emacs_read.
4313
11997c76
EZ
43142011-04-11 Eli Zaretskii <eliz@gnu.org>
4315
4316 * xdisp.c (redisplay_window): Don't try to determine the character
4317 position of the scroll margin if the window start point w->startp
e896f03c 4318 is outside the buffer's accessible region. (Bug#8468)
11997c76 4319
8a2cbd72
EZ
43202011-04-10 Eli Zaretskii <eliz@gnu.org>
4321
4322 Fix write-region and its subroutines for buffers > 2GB.
4323 * fileio.c (a_write, e_write): Modify declaration of arguments and
4324 local variables to support buffers larger than 2GB.
4325 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4326
4327 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4328 argument, local variables, and return value.
4329
4330 * lisp.h: Update prototypes of emacs_write and emacs_read.
4331
4332 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4333
4073e537 43342011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4335
1ebfdcb6
PE
4336 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4337
b2ded58d
PE
4338 Fix more problems found by GCC 4.6.0's static checks.
4339
7d66342c
PE
4340 * xdisp.c (vmessage): Use a better test for character truncation.
4341
bbf47d44
PE
4342 * charset.c (load_charset_map): <, not <=, for optimization,
4343 and to avoid potential problems with integer overflow.
9248994d 4344 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4345 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4346 * editfns.c (Fformat): Likewise.
1e69125e 4347 * syntax.c (skip_chars): Likewise.
3befa583 4348
e3019616
PE
4349 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4350 This also lets GCC 4.6.0 generate slightly better loop code.
4351
becfa255
PE
4352 * callint.c (Fcall_interactively): <, not <=, for optimization.
4353 (Fcall_interactively): Count the number of arguments produced,
4354 not the number of arguments given. This is simpler and lets GCC
4355 4.6.0 generate slightly better code.
4356
dae0cd48
PE
4357 * ftfont.c: Distingish more carefully between FcChar8 and char.
4358 The previous code passed unsigned char * to a functions like
4359 strlen and xstrcasecmp that expect char *, which does not
4360 conform to the C standard.
4361 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4362 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4363 char * when the C standard requires it.
4364
76032d70
PE
4365 * keyboard.c (read_char): Remove unused var.
4366
eb3f1cc8
PE
4367 * eval.c: Port to Windows vsnprintf (Bug#8435).
4368 Include <limits.h>.
4369 (SIZE_MAX): Define if the headers do not.
4370 (verror): Do not give up if vsnprintf returns a negative count.
4371 Instead, grow the buffer. This ports to Windows vsnprintf, which
4372 does not conform to C99. Problem reported by Eli Zaretskii.
4373 Also, simplify the allocation scheme, by avoiding the need for
4374 calling realloc, and removing the ALLOCATED variable.
4375
70476b54
PE
4376 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4377
12020a9e
PE
4378 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4379 But keep the doprint source code for now, as we might revamp it
4380 and use it again (Bug#8435).
ea6c7ae6
PE
4381 * lisp.h (doprnt): Remove.
4382 * Makefile.in (base_obj): Remove doprnt.o.
4383 * deps.mk (doprnt.o): Remove.
4384
5fdb398c
PE
4385 error: Print 32- and 64-bit integers portably (Bug#8435).
4386 Without this change, on typical 64-bit hosts error ("...%d...", N)
4387 was used to print both 32- and 64-bit integers N, which relied on
4388 undefined behavior.
4389 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4390 New macro.
4391 * lisp.h (error, verror): Mark as printf-like functions.
4392 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4393 Report overflow in size calculations when allocating printf buffer.
4394 Do not truncate output string at its first null byte.
4395 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4396 Truncate the output at a character boundary, since vsnprintf does not
4397 do that.
4398 * charset.c (check_iso_charset_parameter): Convert internal
4399 character to string before calling 'error', since %c now has the
4400 printf meaning.
4401 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4402 overflow when computing char to be passed to 'error'. Do not
4403 pass Lisp_Object to 'error'; pass the integer instead.
4404 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4405 formatted with plain %d.
4406
b189fa66
PE
4407 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4408
bff87ef0
PE
4409 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4410
7e2cac20
PE
4411 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4412
ce4d90b5
PE
4413 * xterm.c (x_catch_errors): Remove duplicate declaration.
4414
266c9547
PE
4415 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4416
79c49ad2
PE
4417 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4418
368f4090
JM
44192011-04-10 Jim Meyering <meyering@redhat.com>
4420
4421 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4422 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4423 return ssize_t not "int", and use size_t as the buffer length.
4424 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4425 * gnutls.h: Update declarations.
4426 * process.c (read_process_output): Use ssize_t, to match.
4427 (send_process): Likewise.
4428
a32d4040
CY
44292011-04-09 Chong Yidong <cyd@stupidchicken.com>
4430
4431 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4432
8546720e 44332011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4434
04f2d78b
CB
4435 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4436 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4437
8546720e
GM
4438 * xterm.c (handle_one_xevent):
4439 * xmenu.c (create_and_show_popup_menu):
4440 * xselect.c (x_decline_selection_request)
4441 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4442
0a2f5c1a 44432011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4444
4445 Fix some uses of `int' instead of EMACS_INT.
4446 * search.c (string_match_1, fast_string_match)
4447 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4448 (scan_buffer, find_next_newline_no_quit)
4449 (find_before_next_newline, search_command, Freplace_match)
4450 (Fmatch_data): Make some `int' variables be EMACS_INT.
4451
4452 * xdisp.c (display_count_lines): 3rd argument and return value now
4453 EMACS_INT. All callers changed.
4454 (pint2hrstr): Last argument is now EMACS_INT.
4455
4456 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4457 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4458 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4459 (decode_coding_utf_16, decode_coding_emacs_mule)
4460 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4461 (decode_coding_ccl, decode_coding_charset)
4462 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4463 (decode_coding_iso_2022, decode_coding_emacs_mule)
4464 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4465 <char_offset, last_offset>: Declare EMACS_INT.
4466 (encode_coding_utf_8, encode_coding_utf_16)
4467 (encode_coding_emacs_mule, encode_invocation_designation)
4468 (encode_designation_at_bol, encode_coding_iso_2022)
4469 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4470 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4471 Declare EMACS_INT.
4472 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4473 (encode_invocation_designation): Last argument P_NCHARS is now
4474 EMACS_INT.
4475 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4476 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4477
4478 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4479 All users changed.
4480
4481 * ccl.c (Fccl_execute_on_string): Declare some variables
4482 EMACS_INT.
4483
8546720e 44842011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4485
4486 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4487
4e19a977
CS
44882011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4489
4490 * process.c (Fformat_network_address): Doc fix.
4491
87302331
R
44922011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4493
4494 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4495
cbb59342
CY
44962011-04-08 Chong Yidong <cyd@stupidchicken.com>
4497
4498 * keyboard.c (read_char): Call Lisp function help-form-show,
4499 instead of using internal_with_output_to_temp_buffer.
4500 (Qhelp_form_show): New var.
e0d38eeb 4501 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4502
4503 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4504
4505 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4506
e67a13ab
CY
45072011-04-06 Chong Yidong <cyd@stupidchicken.com>
4508
04f2d78b
CB
4509 * process.c (Flist_processes): Remove to Lisp.
4510 (list_processes_1): Delete.
e67a13ab 4511
973f782d
EZ
45122011-04-06 Eli Zaretskii <eliz@gnu.org>
4513
7c106b1e
EZ
4514 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4515
973f782d
EZ
4516 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4517
41cf7d1a 45182011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4519
ca23cc88
PE
4520 Fix more problems found by GCC 4.6.0's static checks.
4521
f390e2d5
PE
4522 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4523
42eea0d0
PE
4524 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4525
b69769da 4526 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4527
f9541e84
PE
4528 * xdisp.c (vmessage): Mark as a printf-like function.
4529
13841b55
PE
4530 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4531
c136c10f
PE
4532 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4533
5e2d4a30
PE
4534 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4535 printf-like functions.
4536 (tiff_load): Add casts to remove these marks before passing them
4537 to system-supplied API.
4538
583f48b9
PE
4539 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4540
b25d760e
PE
4541 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4542 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4543 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4544 directly, rather than having caller test rule sign. This avoids
4545 some unnecessary tests.
4546 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4547 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4548 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4549
bc7b6697 4550 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4551 (xfont_open): Avoid unnecessary tests.
bc7b6697 4552
27ccc379
PE
4553 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4554
dcd5c89a
PE
4555 * composite.h, composite.c (composition_gstring_put_cache):
4556 Use EMACS_INT, not int, for length.
4557
b13a45c6
PE
4558 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4559 breaking out part of COMPOSITION_DECODE_RULE.
4560 (COMPOSITION_DECODE_RULE): Use it.
4561 * composite.c (get_composition_id): Remove unused local vars,
4562 by using the new macro.
4563
1e792e4d
PE
4564 * textprop.c (set_text_properties_1): Change while to do-while,
4565 since the condition is always true at first.
4566
dc6c6455 4567 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4568 (interval_deletion_adjustment): Return unsigned value.
4569 All uses changed.
dc6c6455 4570
aba7731a
PE
4571 * process.c (list_processes_1, create_pty, read_process_output):
4572 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4573 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4574 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4575 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4576 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4577
fdfc4bf3
PE
4578 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4579
fca8fe46 4580 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4581 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4582
06a0259a 4583 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4584 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4585 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4586
e7b9e80f
PE
4587 * print.c (print_error_message): Avoid int overflow.
4588
56201685
PE
4589 * font.c (font_list_entities): Redo for clarity,
4590 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4591
78834453 4592 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4593 (font_score): Avoid potential overflow in diff calculation.
78834453 4594
0bc0b309 4595 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4596 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4597
e610eaca
PE
4598 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4599
b895abce
PE
4600 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4601 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4602 can always succeed if overflow has undefined behavior.
4603
1f1d9321 4604 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4605 (wordify): Omit three unnecessary tests.
1f1d9321 4606
c59478bc
PE
4607 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4608 All callers changed. This avoids the need for an unused var.
4609
79b73827
PE
4610 * casefiddle.c (casify_region): Remove var that is set but not used.
4611
a4db5dfe
PE
4612 * dired.c (file_name_completion): Remove var that is set but not used.
4613
43aae36e
PE
4614 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4615
2a47c44d 4616 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4617 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4618
a37c69bf
PE
4619 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4620 Check for integer overflow on size calculations.
4621
328ab8e7
PE
4622 * buffer.c (Fprevious_overlay_change): Remove var that is set
4623 but not used.
4624
e5a2a5cb
PE
4625 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4626 Remove vars that are set but not used.
8d84a6eb 4627 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4628 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4629
a60e5f68
PE
4630 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4631
f661cb61 4632 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4633 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4634
f0397f5a
PE
4635 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4636 that are set but not used.
4637
8664db06 4638 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4639 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4640
6abdaa4a
PE
4641 * xselect.c (x_get_local_selection, x_handle_property_notify):
4642 Remove vars that are set but not used.
4643
0ce7538d 4644 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4645 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4646
9ae848fc
PE
4647 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4648 Remove var that is set but not used.
0b918413
PE
4649 (scroll_bar_windows_size): Now size_t, not int.
4650 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4651 Check for overflow.
9ae848fc 4652
a5a62657
PE
4653 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4654 (map_tty_color) [!defined MSDOS]: Likewise.
4655
5c5cdd39
PE
4656 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4657
66ebf983
PE
4658 * coding.c: Remove vars that are set but not used.
4659 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4660 All callers changed.
4661 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4662 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4663 (decode_coding_charset): Remove vars that are set but not used.
4664
1be4d761
PE
4665 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4666 that is set but not used.
4667
47553fa8
PE
4668 * print.c (print_object): Remove var that is set but not used.
4669
1f7196bf 4670 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4671 The gnulib version avoids calling malloc in the usual case,
4672 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4673 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4674 * filelock.c (current_lock_owner): Likewise.
4675 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4676 * sysdep.c: Include allocator.h, careadlinkat.h.
4677 (emacs_no_realloc_allocator): New static constant.
4678 (emacs_readlink): New function.
fdb61804
PE
4679 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4680 ../lib/careadlinkat.h.
d1fdcab7 4681
f84c17c7
SM
46822011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4683
4684 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4685 first non-nil return value).
4686
ef3862ad
JD
46872011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4688
4689 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4690 if not defined (Bug#8403).
4691
376a7006
JB
46922011-04-02 Juanma Barranquero <lekktu@gmail.com>
4693
4694 * xdisp.c (display_count_lines): Remove parameter `start',
4695 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4696 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4697 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4698 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4699 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4700 and thereabouts. All callers changed.
4701 (get_per_char_metric): Remove parameter `f', unused since
4702 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4703
6ca3801d
JM
47042011-04-02 Jim Meyering <meyering@redhat.com>
4705
4706 do not dereference NULL upon failed strdup
4707 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4708 (ns_get_family): Likewise.
4709
d8e2b5ba
JB
47102011-04-02 Juanma Barranquero <lekktu@gmail.com>
4711
4712 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4713
8c74fcbd
JD
47142011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4715
4716 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4717 later (Bug#8403).
4718
7200d79c
SM
47192011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4720
03408648 4721 Add lexical binding.
7200d79c 4722
03408648
SM
4723 * window.c (Ftemp_output_buffer_show): New fun.
4724 (Fsave_window_excursion):
4725 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4726
4727 * lread.c (lisp_file_lexically_bound_p): New function.
4728 (Fload): Bind Qlexical_binding.
4729 (readevalloop): Remove `evalfun' arg.
4730 Bind Qinternal_interpreter_environment.
4731 (Feval_buffer): Bind Qlexical_binding.
4732 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4733 Mark as dynamic.
4734 (syms_of_lread): Declare `lexical-binding'.
4735
4736 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4737
4738 * keyboard.c (eval_dyn): New fun.
4739 (menu_item_eval_property): Use it.
ca105506
SM
4740
4741 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4742
03408648
SM
4743 * fns.c (concat, mapcar1): Accept byte-code-functions.
4744
4745 * eval.c (Fsetq): Handle lexical vars.
4746 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4747 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4748 (FletX, Flet): Obey lexical binding.
4749 (Fcommandp): Handle closures.
4750 (Feval): New `lexical' arg.
4751 (eval_sub): New function extracted from Feval. Use it almost
4752 everywhere where Feval was used. Look up vars in lexical env.
4753 Handle closures.
4754 (Ffunctionp): Move from subr.el.
4755 (Ffuncall): Handle closures.
4756 (apply_lambda): Remove `eval_flags'.
4757 (funcall_lambda): Handle closures and new byte-code-functions.
4758 (Fspecial_variable_p): New function.
4759 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4760 but without exporting it to Lisp.
23aba0ea 4761
23aba0ea 4762 * doc.c (Fdocumentation, store_function_docstring):
03408648 4763 * data.c (Finteractive_form): Handle closures.
23aba0ea 4764
03408648
SM
4765 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4766 interactive spec.
ba83908c 4767
04f2d78b
CB
4768 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4769 New byte-codes.
03408648
SM
4770 (exec_byte_code): New function extracted from Fbyte_code to handle new
4771 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4772
03408648 4773 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4774
03408648 4775 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4776
e2abce01
JB
47772011-03-31 Juanma Barranquero <lekktu@gmail.com>
4778
4779 * xdisp.c (redisplay_internal): Fix prototype.
4780
63696a73 47812011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4782
63696a73 4783 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4784 (try_scrolling): Use it when setting scroll_limit.
4785 Limit scrolling to 100 screen lines.
63696a73
EZ
4786 (redisplay_window): Even when falling back on "recentering",
4787 position point in the window according to scroll-conservatively,
4788 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4789
4790 (try_scrolling): When point is above the window, allow searching
4791 as far as scroll_max, or one screenful, to compute vertical
4792 distance from PT to the scroll margin position. This prevents
4793 try_scrolling from unnecessarily failing when
4794 scroll-conservatively is set to a value slightly larger than the
4795 window height. Clean up the case of PT below the margin at bottom
4796 of window: scroll_max can no longer be INT_MAX. When aggressive
4797 scrolling is in use, don't let point enter the opposite scroll
4798 margin as result of the scroll.
4799 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4800 threshold of 100 lines for never-recentering scrolling.
4801
e4cc2dfc
JB
48022011-03-31 Juanma Barranquero <lekktu@gmail.com>
4803
4804 * dispextern.h (move_it_by_lines):
4805 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4806 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4807 (message_log_check_duplicate): Remove parameters `prev_bol' and
4808 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4809 (redisplay_internal): Remove parameter `preserve_echo_area',
4810 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4811
4812 * indent.c (Fvertical_motion):
4813 * window.c (window_scroll_pixel_based, Frecenter):
4814 Don't pass `need_y_p' to `move_it_by_lines'.
4815
1c470562
SM
48162011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4817
44f230aa
SM
4818 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4819 steal a few bits to be more compact.
4820 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4821 Remove unneeded casts.
4822
1c470562
SM
4823 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4824
888adce9
ZK
48252011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4826
4827 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4828 binding" message (bug#7967).
4829
f838ed7b
PE
48302011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4831
77861b95
PE
4832 Fix more problems found by GCC 4.6.0's static checks.
4833
de6dbc14
PE
4834 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4835 Remove unused local var.
4836
f838ed7b
PE
4837 * editfns.c (Fmessage_box): Remove unused local var.
4838
792c7b2b
PE
4839 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4840 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4841 Omit unused local vars.
c499e557 4842 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4843 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4844 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4845 Omit unused local var.
4846
ba0165e1
PE
4847 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4848 Don't assume string length fits in int.
32ad8845 4849 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4850 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4851
3c59b4c9
PE
4852 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4853 instead of alloca (Bug#8344).
4854
a3eed478 4855 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4856 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4857
eb4d412d
PE
4858 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4859
1658b401
PE
4860 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4861 concerns.
4862
4863 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4864
4865 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4866
9a2c6e05
PE
4867 * keyboard.c (syms_of_keyboard): Use the same style as later
4868 in this function when indexing through an array. This also
4869 works around GCC bug 48267.
4870
03d0a109
PE
4871 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4872
44f730c8
PE
4873 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4874
fe75f926
PE
4875 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4876 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4877
ffa8c828
PE
4878 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4879 This avoids undefined behavior on integer overflow, and is a bit
4880 more convenient anyway since it is compared to a size_t variable.
4881
c5101a77
PE
4882 Variadic C functions now count arguments with size_t, not int.
4883 This avoids an unnecessary limitation on 64-bit machines, which
4884 caused (substring ...) to crash on large vectors (Bug#8344).
4885 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4886 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4887 All variadic functions and their callers changed accordingly.
c5101a77
PE
4888 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4889 * data.c (arith_driver, float_arith_driver): Likewise.
4890 * editfns.c (general_insert_function): Likewise.
4891 * eval.c (struct backtrace.nargs, interactive_p)
4892 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4893 (funcall_lambda, mark_backtrace): Likewise.
4894 * fns.c (concat): Likewise.
4895 * frame.c (x_set_frame_parameters): Likewise.
4896 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4897 0 if not found, not -1. All callers changed.
4898
dd3f25f7
PE
4899 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4900 (stack_copy_size): Now size_t, not int.
4901 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4902
461c2ab9
JB
49032011-03-28 Juanma Barranquero <lekktu@gmail.com>
4904
4905 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4906 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4907 All callers changed.
4908
4909 * lisp.h (multibyte_char_to_unibyte):
4910 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4911 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4912 * character.h (CHAR_TO_BYTE8):
4913 * cmds.c (internal_self_insert):
4914 * editfns.c (general_insert_function):
4915 * keymap.c (push_key_description):
4916 * search.c (Freplace_match):
4917 * xdisp.c (message_dolog, set_message_1): All callers changed.
4918
f6d62986
SM
49192011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4920
4921 * keyboard.c (safe_run_hook_funcall): New function.
4922 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4923 don't set the hook to nil, but remove the offending function instead.
4924 (Qcommand_hook_internal): Remove, unused.
4925 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4926 Vcommand_hook_internal.
4927
4928 * eval.c (enum run_hooks_condition): Remove.
4929 (funcall_nil, funcall_not): New functions.
4930 (run_hook_with_args): Call each function through a `funcall' argument.
4931 Remove `cond' argument, now redundant.
4932 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4933 (Frun_hook_with_args_until_failure): Adjust accordingly.
4934 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4935
1db5b1ad
JB
49362011-03-28 Juanma Barranquero <lekktu@gmail.com>
4937
4938 * dispextern.h (string_buffer_position): Remove declaration.
4939
4940 * print.c (strout): Remove parameter `multibyte', unused since
4941 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4942
4943 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4944 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4945 All callers changed.
4946
4947 * w32.c (_wsa_errlist): Use braces for struct initializers.
4948
4949 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4950 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4951 All callers changed.
4952 (string_buffer_position): Likewise. Also, make static (it's never
4953 used outside xdisp.c).
4954 (cursor_row_p): Remove parameter `w', unused since
4955 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4956 (decode_mode_spec): Remove parameter `precision', introduced during
4957 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4958 All callers changed.
4959
5ffb62aa
JD
49602011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4961
4962 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4963
461c2ab9 49642011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4965
4966 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4967 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4968 (ns_update_auto_hide_menu_bar): New functions.
4969 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4970 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4971 ns_constrain_all_frames.
4972 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4973 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4974
5c380ffb
JD
49752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4976
4977 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4978
9af30bdf
GM
49792011-03-27 Glenn Morris <rgm@gnu.org>
4980
4981 * syssignal.h: Replace RETSIGTYPE with void.
4982 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4983 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4984 Replace SIGTYPE with void everywhere.
4985 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4986 * s/template.h (SIGTYPE): Remove commented out definition.
4987
e2abce01
JB
49882011-03-26 Eli Zaretskii <eliz@gnu.org>
4989
4990 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4991 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4992
f868cd8a
JB
49932011-03-26 Juanma Barranquero <lekktu@gmail.com>
4994
59eb0929
JB
4995 * w32.c (read_unc_volume): Use parameter `henum', instead of
4996 global variable `wget_enum_handle'.
4997
4998 * keymap.c (describe_vector): Remove parameters `indices' and
4999 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5000 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5001
f868cd8a
JB
5002 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5003
5004 * keyboard.c (timer_check): Remove parameter `do_it_now',
5005 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5006 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5007 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5008
5009 * keyboard.c (read_char):
5010 * w32menu.c (w32_menu_display_help):
5011 * xmenu.c (show_help_event, menu_help_callback):
5012 Adjust calls to `show_help_echo'.
5013
5014 * gtkutil.c (xg_maybe_add_timer):
5015 * keyboard.c (readable_events):
5016 * process.c (wait_reading_process_output):
5017 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5018
5019 * insdel.c (adjust_markers_gap_motion):
5020 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5021 (gap_left, gap_right): Don't call it.
5022
2ecf6fdb
CY
50232011-03-25 Chong Yidong <cyd@stupidchicken.com>
5024
5025 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5026 incurred during fontification.
5027
6b1f9ba4
JB
50282011-03-25 Juanma Barranquero <lekktu@gmail.com>
5029
5030 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5031 (DEFVAR_PER_BUFFER): Don't pass it.
5032
5033 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5034 (scrolling_window): Don't pass it.
5035
0f4a96b5
JB
50362011-03-25 Juanma Barranquero <lekktu@gmail.com>
5037
5038 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5039
5040 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5041 and `suffix'.
5042 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5043 of variables specific to SELinux and computation of `encoded_absname'.
5044
5045 * image.c (XPutPixel): Remove unused variable `height'.
5046
5047 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5048
5049 * unexw32.c (get_section_info): Remove unused variable `section'.
5050
5051 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5052 (system_process_attributes): Remove unused variable `sess'.
5053 (sys_read): Remove unused variable `err'.
5054
5055 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5056 (w32_wnd_proc): Remove unused variable `isdead'.
5057 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5058 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5059 (x_create_tip_frame): Remove unused variable `tem'.
5060
5061 * w32inevt.c (w32_console_read_socket):
5062 Remove unused variable `no_events'.
5063
5064 * w32term.c (x_draw_composite_glyph_string_foreground):
5065 Remove unused variable `width'.
5066
1149507c
JB
50672011-03-24 Juanma Barranquero <lekktu@gmail.com>
5068
5069 * w32term.c (x_set_glyph_string_clipping):
5070 Don't pass uninitialized region to CombineRgn.
5071
9c88f339
JB
50722011-03-23 Juanma Barranquero <lekktu@gmail.com>
5073
5074 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5075 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5076 (Fx_close_connection): Remove unused variable `i'.
5077
5078 * w32font.c (w32font_draw): Return number of glyphs.
5079 (w32font_open_internal): Remove unused variable `i'.
5080 (w32font_driver): Add missing initializer.
5081
5082 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5083 (fill_in_menu): Remove unused variable `items_added'.
5084
5085 * w32term.c (last_mouse_press_frame): Remove static global variable.
5086 (w32_clip_to_row): Remove unused variable `f'.
5087 (x_delete_terminal): Remove unused variable `i'.
5088
5089 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5090 (NOTHING): Remove unused static global variable.
5091 (uniscribe_check_otf): Remove unused variable `table'.
5092 (uniscribe_font_driver): Add missing initializers.
5093
dee091a3
JD
50942011-03-23 Julien Danjou <julien@danjou.info>
5095
5096 * term.c (Fsuspend_tty, Fresume_tty):
5097 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5098 * window.c (temp_output_buffer_show):
5099 * insdel.c (signal_before_change):
5100 * frame.c (Fhandle_switch_frame):
5101 * fileio.c (Fdo_auto_save):
5102 * emacs.c (Fkill_emacs):
5103 * editfns.c (save_excursion_restore):
5104 * cmds.c (internal_self_insert):
5105 * callint.c (Fcall_interactively):
5106 * buffer.c (Fkill_all_local_variables):
5107 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5108 Use Frun_hooks.
0f4a96b5 5109 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5110 unconditionnaly since it does the check itself.
5111
2c520ab5 51122011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5113
c9c49752
PE
5114 Fix more problems found by GCC 4.5.2's static checks.
5115
8abc3f12
PE
5116 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5117 the first time through the loop, since we know p0 < p1 then.
5118 This also avoids a gcc -Wstrict-overflow warning.
5119
a2d26660
PE
5120 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5121 leading to a memory leak, possible in functions like
5122 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5123 of objects (Bug#8318).
a2d26660 5124
916c72e9
PE
5125 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5126 that could (at least in theory) be that large.
5127
19ab8a18
PE
5128 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5129 This is less likely to overflow, and avoids undefined behavior if
5130 overflow does occur. All callers changed. Use strtoul to scan
5131 for the unsigned long integer.
b7cbbd6f
PE
5132 (pint2hrstr): Simplify and tune code slightly.
5133 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5134
f0641eff
PE
5135 * scroll.c (do_scrolling): Work around GCC bug 48228.
5136 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5137
7f650bb9
PE
5138 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5139 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5140 (validate_x_resource_name): Simplify count usage.
5141 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5142
37dd57d1
PE
5143 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5144 fail (Bug#8306).
81e56e61 5145
699979fc 5146 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5147
401bf9b4
PE
5148 * process.c (Fmake_network_process): Use socklen_t, not int,
5149 where POSIX says socklen_t is required in portable programs.
5150 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5151 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5152 (Fmake_network_process, server_accept_connection):
5153 (wait_reading_process_output, read_process_output):
5154 Likewise.
5155
b93aacde
PE
5156 * process.c: Rename or move locals to avoid shadowing.
5157 (list_processes_1, Fmake_network_process):
5158 (read_process_output_error_handler, exec_sentinel_error_handler):
5159 Rename or move locals.
4dc343ee 5160 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5161 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5162 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5163 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5164 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5165
af8a867c 5166 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5167 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5168 Include tparam.h instead, since it declares them.
af8a867c
PE
5169 * cm.h (PC): Remove extern decl; tparam.h now does this.
5170 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5171 * terminfo.c: Include tparam.h, to check interfaces.
5172 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5173 (tparam): Adjust signature to match interface in tparam.h;
5174 this removes some undefined behavior. Check that outstring and len
5175 are zero, which they always are with Emacs.
5176 * tparam.h (PC, BC, UP): New extern decls.
5177
0248044d 5178 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5179 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5180
8ff096c1 5181 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5182 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5183 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5184 (ftfont_list): Remove unused local.
49eaafba
PE
5185 (get_adstyle_property, ftfont_pattern_entity):
5186 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5187 Rename locals to avoid shadowing.
8ff096c1 5188
e2be39f6
PE
5189 * xfont.c (xfont_list_family): Mark var as initialized.
5190
c9735e30
PE
5191 * xml.c (make_dom): Now static.
5192
8f5201ae
PE
5193 * composite.c (composition_compute_stop_pos): Rename local to
5194 avoid shadowing.
b246f932
PE
5195 (composition_reseat_it): Remove unused locals.
5196 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5197 (composition_update_it): Mark var as initialized.
11b61122
PE
5198 (find_automatic_composition): Mark vars as initialized,
5199 with a FIXME (Bug#8290).
8f5201ae 5200
760fbc2c
PE
5201 character.h: Rename locals to avoid shadowing.
5202 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5203 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5204 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5205 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5206 to avoid shadowing.
5207
ff08eb85
PE
5208 * textprop.c (property_change_between_p): Remove; unused.
5209
fc7bf025
PE
5210 * intervals.c (interval_start_pos): Now static.
5211
235d7abc
PE
5212 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5213
44f230aa
SM
5214 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5215 Rename locals to avoid shadowing.
3e7d6594 5216
50060332
PE
5217 * sound.c (wav_play, au_play, Fplay_sound_internal):
5218 Fix pointer signedness.
d01f234b 5219 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5220 (wav_play): Initialize a variable to 0, to prevent undefined
5221 behavior (Bug#8278).
50060332 5222
c4fc4e30
PE
5223 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5224
918436ed
PE
5225 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5226
c939f91b
PE
5227 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5228 clobbering (Bug#8298).
b9c7f648
PE
5229 * sysdep.c (sys_subshell): Likewise.
5230 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5231
6bd8c144
PE
5232 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5233 This should get cleaned up, so that child_setup has the
5234 same signature on all platforms.
5235
7710357c 5236 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5237 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5238
c59da222
CY
52392011-03-22 Chong Yidong <cyd@stupidchicken.com>
5240
5241 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5242 not to be necessary, and produces flickering.
5243
66b87493
GM
52442011-03-20 Glenn Morris <rgm@gnu.org>
5245
5246 * config.in: Remove file.
5247
45b6f6d5
JB
52482011-03-20 Juanma Barranquero <lekktu@gmail.com>
5249
5250 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5251 are now in src/globals.h.
5252 (syms_of_minibuf): Remove spurious & from previous change.
5253
3ec03f7e
LL
52542011-03-20 Leo <sdl.web@gmail.com>
5255
5256 * minibuf.c (completing-read-function): New variable.
5257 (completing-read-default): Rename from completing-read.
5258 (completing-read): Call completing-read-function.
5259
b14e3e21
CY
52602011-03-19 Juanma Barranquero <lekktu@gmail.com>
5261
5262 * xfaces.c (Fx_load_color_file):
5263 Read color file from absolute filename (bug#8250).
5264
f2b726e6
JB
52652011-03-19 Juanma Barranquero <lekktu@gmail.com>
5266
5267 * makefile.w32-in: Update dependencies.
5268
09f6ff02
EZ
52692011-03-17 Eli Zaretskii <eliz@gnu.org>
5270
5271 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5272
29a6015a
PE
52732011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5274
a3a6c54e
PE
5275 Fix more problems found by GCC 4.5.2's static checks.
5276
b766f867
PE
5277 * process.c (make_serial_process_unwind, send_process_trap):
5278 (sigchld_handler): Now static.
5279
be02381c
PE
5280 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5281 That way, the code declares only the vars that it needs.
5282 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5283 * s/cygwin.h (PTY_ITERATION): Likewise.
5284 * s/darwin.h (PTY_ITERATION): Likewise.
5285 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5286
57048744
PE
5287 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5288 * process.c (allocate_pty): Don't declare stb unless it's needed.
5289
7914961c 5290 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5291 (CONSTANTLIM): Remove; unused.
5292 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5293 Define only if needed.
7914961c 5294
b3967b18
PE
5295 * unexelf.c (unexec): Name an expression,
5296 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5297 Use a different way to cause a compilation error if anyone uses
5298 n rather than nn, a way that does not involve shadowing.
73366a00 5299 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5300
29a6015a
PE
5301 * deps.mk (unexalpha.o): Remove; unused.
5302
43cfc33e 5303 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5304 * unexec.h: New file.
ce701a33
PE
5305 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5306 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5307 Depend on unexec.h.
5308 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5309 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5310 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5311 Change as necessary to match prototype in unexec.h.
ce701a33 5312
01f44d5a
PE
5313 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5314 shadowing.
4f63c6bb 5315 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5316
a6670b0b
PE
5317 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5318 Rename locals to avoid shadowing.
5319
cef2010d 5320 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5321 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5322
d4d7173a
PE
5323 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5324
f08b802a
PE
5325 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5326 warning when compiling print.c.
5327
3ddb0639
PE
5328 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5329 instead of using an uninitialized var.
5ad03b97 5330 (font_sort_entities): Mark var as initialized.
3ddb0639 5331
170a2692
PE
5332 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5333
e663c700
PE
5334 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5335 pointers to constants.
89bc529a 5336 (font_parse_fcname): Remove unused vars.
7b81e2d0 5337 (font_delete_unmatched): Now static.
ea838e10 5338 (font_get_spec): Remove; unused.
13a547c6
PE
5339 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5340 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5341 Rename or move locals to avoid shadowing.
e663c700 5342
2a80c887 5343 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5344 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5345
1384fa33 5346 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5347 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5348
8b2c52e9
PE
5349 * alloc.c (mark_backtrace): Move decl from here ...
5350 * lisp.h: ... to here, so that it can be checked.
5351
475545b5 5352 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5353 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5354 (lisp_indirect_variable): Name an expression,
5355 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5356 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5357
b1349114 5358 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5359 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5360 Use const pointer when appropriate.
b1349114 5361
a2928364
PE
5362 * lisp.h (get_system_name, get_operating_system_release):
5363 Move decls here, to check interfaces.
5364 * process.c (get_operating_system_release): Move decl to lisp.h.
5365 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5366 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5367 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5368 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5369 (Fformat_time_string, Fencode_time, Finsert_char):
5370 (Ftranslate_region_internal, Fformat):
5371 Rename or remove local vars to avoid shadowing.
9710023e 5372 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5373
a415e694
PE
5374 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5375 avoid shadowing.
5376
8ef4622d
PE
5377 * lisp.h (eassert): Check that the argument compiles, even if
5378 ENABLE_CHECKING is not defined.
5379
946f9a5b
PE
5380 * data.c (Findirect_variable): Name an expression, to avoid
5381 gcc -Wbad-function-cast warning.
112396d6 5382 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5383 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5384 (Fmake_variable_buffer_local, Fmake_local_variable):
5385 Mark variables as initialized.
52746918 5386 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5387
e5aab7e7 5388 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5389 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5390 Rename locals to avoid shadowing.
dff45157
PE
5391 (mark_stack): Move local variables into the #ifdef region where
5392 they're used.
7bc26fdb
PE
5393 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5394 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5395 needed otherwise.
5396 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5397 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5398 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5399
e5aab7e7
PE
5400 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5401 avoids undefined behavior in theory.
5402
4da60324
PE
5403 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5404
88043301
PE
5405 Use functions, not macros, for up- and down-casing (Bug#8254).
5406 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5407 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5408 to use the following functions instead of these macros.
5409 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5410 EMACS_INT, since callers assume the returned value fits in int.
5411 (upcase1): Likewise, for UPCASE_TABLE.
5412 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5413 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5414 the race-condition problem in the old DOWNCASE.
88043301 5415
19ed5445
PE
5416 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5417 Rename locals to avoid shadowing.
5418 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5419 (regex_compile, re_search_2, re_match_2_internal):
5420 Remove unused local vars.
952db0d7
PE
5421 (FREE_VAR): Rewrite so as not to use empty "else",
5422 which gcc can warn about.
da053e48 5423 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5424 (RETALLOC_IF): Define only if needed.
5425 (WORDCHAR_P): Likewise. This one is never needed, but is used
5426 only in a comment talking about a compiler bug, so put inside
5427 the #if 0 of that comment.
5428 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5429 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5430 Remove; unused.
19ed5445 5431
1f3561e4 5432 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5433 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5434 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5435
ded6f8f7
PE
5436 * search.c (simple_search): Remove unused var.
5437
dbd37a95
PE
5438 * dired.c (compile_pattern): Move decl from here ...
5439 * lisp.h: ... to here, so that it can be checked.
5440 (struct re_registers): New forward decl.
5441
7e47afad
PE
5442 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5443
85f24f61
PE
5444 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5445 All uses changed.
5446 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5447 Rename locals to avoid shadowing.
5671df8f 5448 (Fvertical_motion): Mark locals as initialized.
85f24f61 5449
181aa2be 5450 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5451 (casify_region): Mark local as initialized.
181aa2be 5452
930d429c
PE
5453 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5454
7082eac6
PE
5455 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5456 New macros, so that the caller can use some names other than
5457 gcpro1, gcpro2, etc.
5458 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5459 of the new macros.
5460 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5461 argument, for consistency with GCPRO2_VAR, etc: it is now the
5462 prefix of the variable, not the variable itself. All uses
5463 changed.
38b2c076
PE
5464 * dired.c (directory_files_internal, file_name_completion):
5465 Rename locals to avoid shadowing.
5466
15206ed9
PE
5467 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5468 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5469 dired.c's scmp function, had undefined behavior.
5470 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5471 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5472 * buffer.h: ... to here, because these macros use current_buffer,
5473 and the new implementation with inline functions needs to have
5474 current_buffer in scope now, rather than later when the macros
5475 are used.
5476 (downcase, upcase1): New static inline functions.
5477 (DOWNCASE, UPCASE1): Reimplement using these functions.
5478 This avoids undefined behavior in expressions like
5479 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5480 from race conditions in accessing the global variables
5481 case_temp1 and case_temp2.
5482 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5483 * lisp.h (case_temp1, case_temp2): Remove their decls.
5484 * character.h (ASCII_CHAR_P): Move from here ...
5485 * lisp.h: ... to here, so that the inline functions mentioned
5486 above can use them.
5487
4a6bea26
PE
5488 * dired.c (directory_files_internal_unwind): Now static.
5489
f14b7e14
PE
5490 * fileio.c (file_name_as_directory, directory_file_name):
5491 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5492 Now static.
2893f146
PE
5493 (file_name_as_directory): Use const pointers when appropriate.
5494 (Fexpand_file_name): Likewise. In particular, newdir might
5495 point at constant storage, so make it a const pointer.
fd4ead52 5496 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5497 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5498 signedness issues.
f839df0c
PE
5499 (Fset_file_times, Finsert_file_contents, auto_save_error):
5500 Rename locals to avoid shadowing.
f14b7e14 5501
5716756e 5502 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5503 (Ftry_completion, Fall_completions): Rename or remove locals
5504 to avoid shadowing.
5716756e 5505
b4c3046a
PE
5506 * marker.c (bytepos_to_charpos): Remove; unused.
5507
b45db522
PE
5508 * lisp.h (verify_bytepos, count_markers): New decls,
5509 so that gcc does not warn that these functions aren't declared.
5510
85876d07
PE
5511 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5512 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5513 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5514 (copy_text): Remove unused local var.
85876d07 5515
03d78a21 5516 * filelock.c (within_one_second): Now static.
b3dd38ab 5517 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5518
5df8f01b
PE
5519 * buffer.c (fix_overlays_before): Mark locals as initialized.
5520 (fix_start_end_in_overlays): Likewise. This function should be
5521 simplified by using pointers-to-pointers, but that's a different
5522 matter.
b1d876f1 5523 (switch_to_buffer_1): Now static.
8f54f30a
PE
5524 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5525 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5526
a70072c9 5527 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5528 Fix pointer signedness issue.
edced198
PE
5529 (sys_subshell): Mark local as volatile if checking for lint,
5530 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5531 (MAXPATHLEN): Define only if needed.
a70072c9 5532
a0977c44
PE
5533 * process.c (serial_open, serial_configure): Move decls from here ...
5534 * systty.h: ... to here, so that they can be checked.
5535
a884fdcc
PE
5536 * fns.c (get_random, seed_random): Move extern decls from here ...
5537 * lisp.h: ... to here, so that they can be checked.
5538
604efe86 5539 * sysdep.c (reset_io): Now static.
b8950c94 5540 (wait_for_termination_signal): Remove; unused.
604efe86 5541
38fc62d9
PE
5542 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5543 (copy_keymap_item, append_key, push_text_char_description):
5544 Now static.
1004a21a 5545 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5546 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5547 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5548 (describe_map_tree):
5549 Rename locals to avoid shadowing.
38fc62d9 5550
2f2650da
PE
5551 * keyboard.c: Declare functions static if they are not used elsewhere.
5552 (echo_char, echo_dash, cmd_error, top_level_2):
5553 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5554 (read_char, kbd_buffer_get_event, make_lispy_position):
5555 (make_lispy_event, make_lispy_movement, apply_modifiers):
5556 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5557 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5558 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5559 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5560 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5561
a053e86c 5562 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5563 (mark_kboards): Move decl here ...
5564 * alloc.c (mark_kboards): ... from here.
a053e86c 5565
4752793e
PE
5566 * lisp.h (force_auto_save_soon): New decl.
5567
74f10ca7 5568 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5569 (DEFINE_DUMMY_FUNCTION): New macro.
5570 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5571 Use it.
c03cd23f
PE
5572 (main): Add casts to avoid warnings
5573 if GCC considers string literals to be constants.
74f10ca7 5574
022e70d4
PE
5575 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5576
59d6fe83
PE
5577 * dbusbind.c: Pointer signedness fixes.
5578 (xd_signature, xd_append_arg, xd_initialize):
5579 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5580 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5581 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5582 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5583
78320123
PE
5584 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5585 if GCC considers string literals to be constants.
49cebcca 5586 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5587
35ac2a97
SM
55882011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5589
fb103ca9
SM
5590 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5591 (print_preprocess, print_object): New macro to fix last change.
5592
35ac2a97
SM
5593 * print.c (print_preprocess): Don't forget font objects.
5594
62973b41
JB
55952011-03-16 Juanma Barranquero <lekktu@gmail.com>
5596
5597 * emacs.c (USAGE3): Doc fixes.
5598
0e48bb22
AS
55992011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5600
5601 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5602 structure.
5603
7684e57b
JB
56042011-03-14 Juanma Barranquero <lekktu@gmail.com>
5605
5606 * lisp.h (VWindow_system, Qfile_name_history):
5607 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5608 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5609 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5610
5611 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5612 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5613
5614 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5615 * w32console.c (detect_input_pending, read_input_pending)
5616 (encode_terminal_code):
5617 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5618 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5619 (w32_system_caret_y, Qfile_name_history):
5620 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5621 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5622 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5623 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5624 * w32proc.c (Qlocal, report_file_error):
5625 * w32term.c (Vwindow_system, updating_frame):
5626 * w32uniscribe.c (initialized, uniscribe_font_driver):
5627 Remove unneeded extern declarations.
5628
2aa46d6c
CY
56292011-03-14 Chong Yidong <cyd@stupidchicken.com>
5630
c96bbc66 5631 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5632
cffc6f3b
CY
56332011-03-13 Chong Yidong <cyd@stupidchicken.com>
5634
5635 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5636 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5637 These macros can no longer be used for assignment.
5638
44f230aa
SM
5639 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5640 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5641 (record_buffer_markers, fetch_buffer_markers): New functions for
5642 recording and fetching special buffer markers.
5643 (set_buffer_internal_1, set_buffer_temp): Use them.
5644
5645 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5646
5647 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5648
5649 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5650 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5651
5652 * xdisp.c (hscroll_window_tree):
5653 (reconsider_clip_changes): Use PT instead of BUF_PT.
5654
d251f04b
EZ
56552011-03-13 Eli Zaretskii <eliz@gnu.org>
5656
5657 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5658 $(EMACS_ROOT)/lib/intprops.h.
5659
f0c77cd1
PE
56602011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5661
3eca4629
PE
5662 Fix more problems found by GCC 4.5.2's static checks.
5663
7c86ee98
PE
5664 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5665 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5666 (xg_free_frame_widgets): Make it clear that a local variable is
5667 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5668 (gdk_window_get_screen): Make it clear that this macro is needed
5669 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5670 (int_gtk_range_get_value): New function, which avoids a diagnostic
5671 from gcc -Wbad-function-cast.
5672 (xg_set_toolkit_scroll_bar_thumb): Use it.
5673 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5674 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5675 (get_utf8_string, xg_get_file_with_chooser):
5676 Rename locals to avoid shadowing.
5677 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5678
41729b81
PE
5679 * xgselect.c (xg_select): Remove unused var.
5680
f0c77cd1
PE
5681 * image.c (four_corners_best): Mark locals as initialized.
5682 (gif_load): Initialize transparent_p to zero (Bug#8238).
5683 Mark another local as initialized.
ec6cf4c6 5684 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5685
ce0ad53d 5686 * image.c (clear_image_cache): Now static.
d5d5a617 5687 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5688 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5689 (x_edge_detection): Remove unnecessary cast that
5690 gcc -Wbad-function-cast diagnoses.
2037898d 5691 (gif_load): Fix pointer signedness.
6ae141d6
PE
5692 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5693 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5694
33383987 56952011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5696
d32df629
PE
5697 Improve quality of tests for time stamp overflow.
5698 For example, without this patch (encode-time 0 0 0 1 1
5699 1152921504606846976) returns the obviously-bogus value (-948597
5700 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5701 reports time overflow. See
5702 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5703 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5704 * editfns.c: Include limits.h and intprops.h.
5705 (TIME_T_MIN, TIME_T_MAX): New macros.
5706 (time_overflow): Move earlier, to before first use.
5707 (hi_time, lo_time): New functions, for an accurate test for
5708 out-of-range times.
5709 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5710 (Fget_internal_run_time): Don't assume time_t fits in int.
5711 (make_time): Use list2 instead of Fcons twice.
5712 (Fdecode_time): More accurate test for out-of-range times.
5713 (check_tm_member): New function.
5714 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5715 (lisp_time_argument): Don't rely on undefined left-shift and
5716 right-shift behavior when checking for time stamp overflow.
8be6f318 5717
fe31d94c
PE
5718 * editfns.c (time_overflow): New function, refactoring common code.
5719 (Fformat_time_string, Fdecode_time, Fencode_time):
5720 (Fcurrent_time_string): Use it.
5721
8be6f318
PE
5722 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5723 * dired.c (make_time): Move to ...
5724 * editfns.c (make_time): ... here.
5725 * systime.h: Note the move.
5726
09d9db2c 57272011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5728
126bc0dc
YM
5729 * fringe.c (update_window_fringes): Remove unused variables.
5730
c47cbdfd
YM
5731 * unexmacosx.c (copy_data_segment): Also copy __got section.
5732 (Bug#8223)
5733
7ac80be9
EZ
57342011-03-12 Eli Zaretskii <eliz@gnu.org>
5735
c96bbc66 5736 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5737 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5738 Constify `char *' arguments and their references according to
5739 prototypes in tparam.h.
5740
ecb0f94d 5741 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5742
7ac80be9
EZ
5743 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5744 Adapt all references accordingly.
5745
5746 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5747
ef1fd07e
TT
57482011-03-11 Tom Tromey <tromey@redhat.com>
5749
5750 * buffer.c (syms_of_buffer): Remove obsolete comment.
5751
7ef4b50c
EZ
57522011-03-11 Eli Zaretskii <eliz@gnu.org>
5753
5754 * termhooks.h (encode_terminal_code): Declare prototype.
5755
5756 * msdos.c (encode_terminal_code): Don't declare prototype.
5757
5758 * term.c (encode_terminal_code): Now external again, used by
5759 w32console.c and msdos.c.
5760
44f230aa
SM
5761 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5762 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5763
4b1ec863 57642011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5765
1714f52b 5766 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5767
4b1ec863
PE
5768 * fringe.c (update_window_fringes): Mark locals as initialized
5769 (Bug#8227).
5770 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5771
524c7aa6
PE
5772 * alloc.c (mark_fringe_data): Move decl from here ...
5773 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5774 to check its interface.
5775 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5776
a5c0af81 5777 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5778 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5779 (fontset_font): Mark local as initialized.
a9a06e0b 5780 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5781
b4716021
PE
5782 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5783
811e9bac 5784 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5785 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5786 (x_own_selection, Fx_disown_selection_internal): Rename locals
5787 to avoid shadowing.
5788 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5789
7e3ab302
PE
5790 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5791 so that the caller can use some name other than gcpro1.
5792 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5793 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5794 (Fx_backspace_delete_keys_p):
5795 Use them to avoid shadowing, and rename vars to avoid shadowing.
5796 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5797 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5798 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5799 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5800 Remove unused locals.
7e3ab302
PE
5801 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5802 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5803 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5804 macros.
f78faa98 5805
e2b13473
PE
5806 * xterm.h (x_mouse_leave): New decl.
5807
77f23912
PE
5808 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5809 Remove unused functions.
cdf4ba58
PE
5810 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5811 (x_calc_absolute_position): Now static.
7411c686 5812 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5813 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5814 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5815 unless they are used.
38d0b34a
PE
5816 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5817 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5818 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5819 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5820 (x_error_catcher, x_connection_closed, x_error_handler):
5821 (x_error_quitter, xembed_send_message, x_iconify_frame):
5822 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5823 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5824 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5825
44f230aa
SM
5826 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5827 Rename or move locals to avoid shadowing.
6b463e58 5828 (tty_defined_color, merge_face_heights): Now static.
5967d051 5829 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5830 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5831 does not deduce is never used uninitialized.
73719eba
PE
5832 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5833 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5834
426994c3 5835 * terminal.c (store_terminal_param): Now static.
5489860b 5836
032f1620 5837 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5838 (set_frame_menubar): Remove unused local.
d4323972 5839 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5840 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5841 since they might point to immutable storage.
281585b0
PE
5842 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5843 since it's unused otherwise.
032f1620 5844
367c19e5 5845 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5846 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5847 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5848 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5849 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5850 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5851 does not deduce are never used uninitialized.
70739cbe 5852
07b48fa9
PE
5853 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5854
8868a238 5855 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5856 * window.c (window_loop, size_window):
5857 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5858
7e5cf297 5859 * window.c (display_buffer): Now static.
d6550a9f
PE
5860 (size_window): Mark variables that gcc -Wuninitialized
5861 does not deduce are never used uninitialized.
a586633d
PE
5862 * window.h (check_all_windows): New decl, to forestall
5863 gcc -Wmissing-prototypes diagnostic.
5b555da1 5864 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5865
f6095868
PE
5866 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5867 shadowing.
5868 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5869 Include <limits.h>.
5870 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5871 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5872 (load_charset_map): Mark variables that gcc -Wuninitialized
5873 does not deduce are never used uninitialized.
53df7c11 5874 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5875
f38b440c
PE
5876 * coding.c (coding_set_source, coding_set_destination):
5877 Use "else { /* comment */ }" rather than "else /* comment */;"
5878 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5879 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5880 a block, when the outer 'i' will do.
5881 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5882 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5883 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5884 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5885 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5886 Rename locals to avoid shadowing.
5887 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5888 * coding.c (emacs_mule_char, encode_invocation_designation):
5889 Now static, since they're not used elsewhere.
413bb2db 5890 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5891 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5892 (decode_coding_emacs_mule): Mark variables that gcc
5893 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5894 (detect_coding_iso_2022): Initialize a local variable that might
5895 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5896 this initialization is needed. (Bug#8211)
5f58e762
PE
5897 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5898 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5899 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5900 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5901 Remove unused macros.
f38b440c 5902
232b38b9 5903 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5904 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5905 * character.c (string_count_byte8): Likewise.
232b38b9 5906
fb90da1b
PE
5907 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5908 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5909
fb93dbc2
PE
5910 * chartab.c (copy_sub_char_table): Now static, since it's not used
5911 elsewhere.
5c156ace
PE
5912 (sub_char_table_ref_and_range, char_table_ref_and_range):
5913 Rename locals to avoid shadowing.
bbcd0949 5914 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5915
7d3b3862 5916 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5917 (BIDI_BOB): Remove unused macro.
7d3b3862 5918
6be7d3da
PE
5919 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5920 deduce are never used uninitialized.
c2ed9c8b 5921 * term.c (encode_terminal_code): Likewise.
6be7d3da 5922
75f8807f 5923 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5924
50938595
PE
5925 * tparam.h: New file.
5926 * term.c, tparam.h: Include it.
5927 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5928 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5929 Move these decls to tparam.h, and make them agree with what
5930 is actually in tparam.c. The previous trick of using incompatible
5931 decls in different modules does not conform to the C standard.
5932 All callers of tparam changed to use tparam's actual API.
5933 * tparam.c (tparam1, tparam, tgoto):
5934 Use const pointers where appropriate.
5935
fbceeba2
PE
5936 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5937 * cm.h (struct cm): Likewise.
5938 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5939 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5940 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5941 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5942 (turn_on_face, init_tty): Likewise.
5943 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5944
7f3f1250
PE
5945 * term.c (term_mouse_position): Rename local to avoid shadowing.
5946
e6ca6543
PE
5947 * alloc.c (mark_ttys): Move decl from here ...
5948 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5949
c40f8d15
AS
59502011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5951
5952 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5953
cfe0661d
JB
59542011-03-09 Juanma Barranquero <lekktu@gmail.com>
5955
5956 * search.c (compile_pattern_1): Remove argument regp, unused since
5957 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5958 (compile_pattern): Don't pass it.
5959
0afb4571
J
59602011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5961
5962 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5963 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5964 for ! HAVE_GTK3.
5965 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5966
5967 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5968
5969 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5970 gdk_window_get_screen, gdk_window_get_geometry,
5971 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5972 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5973 (xg_get_pixbuf_from_pixmap): New function.
5974 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5975 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5976 Call xg_get_pixbuf_from_pixmap instead of
5977 gdk_pixbuf_get_from_drawable.
5978 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5979 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5980 (xg_check_special_colors): Use GtkStyleContext and its functions
5981 for HAVE_GTK3.
5982 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5983 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5984 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5985 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5986 Call gtk_widget_get_preferred_size.
0afb4571
J
5987 (xg_frame_resized): gdk_window_get_geometry only takes 5
5988 parameters.
44f230aa
SM
5989 (xg_win_to_widget, xg_event_is_for_menubar):
5990 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5991 (xg_set_widget_bg): New function.
5992 (delete_cb): New function.
895009e1 5993 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5994 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5995 (xg_set_background_color): Call xg_set_widget_bg.
5996 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5997 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5998 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5999 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6000 if ! HAVE_GTK3.
6001 (update_frame_tool_bar): Call gtk_widget_hide.
6002 (xg_initialize): Use GDK_KEY_g.
6003
6004 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6005 if ! HAVE_GTK3
6006 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6007
6008 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6009 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6010 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6011
1c2cc4ef
JB
60122011-03-08 Juanma Barranquero <lekktu@gmail.com>
6013
6014 * w32xfns.c (select_palette): Check success of RealizePalette against
6015 GDI_ERROR, not zero.
6016
33383987 6017See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6018
6019;; Local Variables:
6020;; coding: utf-8
aac0c6e3
MR
6021;; End:
6022
33383987 6023 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6024
6025 This file is part of GNU Emacs.
6026
6027 GNU Emacs is free software: you can redistribute it and/or modify
6028 it under the terms of the GNU General Public License as published by
6029 the Free Software Foundation, either version 3 of the License, or
6030 (at your option) any later version.
6031
6032 GNU Emacs is distributed in the hope that it will be useful,
6033 but WITHOUT ANY WARRANTY; without even the implied warranty of
6034 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6035 GNU General Public License for more details.
6036
6037 You should have received a copy of the GNU General Public License
6038 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.