Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
12959e8e
PE
12012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2
97107e2e
PE
3 * xgselect.c (xg_select): Put maxfds+1 into a var.
4 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5
12959e8e
PE
6 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
7
836d29b3
DA
82012-05-10 Dave Abrahams <dave@boostpro.com>
9
10 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
11 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
12
5cb67954
MA
132012-05-09 Michael Albinus <michael.albinus@gmx.de>
14
15 * dbusbind.c (xd_registered_buses): New internal Lisp object.
16 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
17 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
18 Initialize xd_registered_buses.
19
3478ec45
PE
202012-05-09 Paul Eggert <eggert@cs.ucla.edu>
21
b263a6b0
PE
22 Untag more efficiently if USE_LSB_TAG.
23 This is based on a proposal by YAMAMOTO Mitsuharu in
24 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
25 For an admittedly artificial (nth 8000 longlist) benchmark on
26 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
27 Emacs's overall text size by 1%.
28 * lisp.h (XUNTAG): New macro.
29 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
30 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
31 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
32 * eval.c (Fautoload):
33 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
34 * frame.h (XFRAME): Use XUNTAG.
35
3478ec45
PE
36 Port recent dbusbind.c changes to 32-bit --with-wide-int.
37 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
38 Remove unportable assumptions about print widths of types like
39 dbus_uint32_t.
40 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
41 intptr_t when converting between pointer and integer, to avoid GCC
42 warnings about wrong width.
43
666b903b 442012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
45
46 * w32proc.c (new_child): Force Windows to reserve only 64KB of
47 stack for each reader_thread, instead of defaulting to 8MB
48 determined by the linker. This avoids failures in creating
49 subprocesses on Windows 7, see the discussion in this thread:
50 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
51
b120cc17
JC
522012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
53
54 Fix up display of the *Minibuf-0* buffer in the mini window.
55 * keyboard.c (read_char): Don't clear the echo area if there's no
56 message to clear.
57 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 58 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 59
9a4b36f8
MA
602012-05-07 Michael Albinus <michael.albinus@gmx.de>
61
62 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
63 batch mode.
64
e5f9458f
CY
652012-05-06 Chong Yidong <cyd@gnu.org>
66
67 * lisp.mk (lisp): Update.
68
eceeb5fc 692012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
70
71 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
72
71873e2b
SM
732012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
74
75 * data.c (PUT_ERROR): New macro.
76 (syms_of_data): Use it. Add new error type `user-error'.
77 * undo.c (user_error): New function.
78 (Fprimitive_undo): Use it.
79 * print.c (print_error_message): Adjust print style for `user-error'.
80 * keyboard.c (user_error): New function.
81 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
82
ab0fa4e4
PE
832012-05-03 Paul Eggert <eggert@cs.ucla.edu>
84
85 Do not limit current-time-string to years 1000..9999.
86 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
87 (Fcurrent_time_string): Support any year that is supported by the
88 underlying localtime representation. Don't use asctime, as it
89 has undefined behavior for years outside the range -999..9999.
90
7ed806a7
PE
912012-05-02 Paul Eggert <eggert@cs.ucla.edu>
92
93 Fix race conditions involving setenv, gmtime, localtime, asctime.
94 Without this fix, interrupts could mess up code that uses these
95 nonreentrant functions, since setting TZ invalidates existing
96 tm_zone or tzname values, and since most of these functions return
97 pointers to static storage.
98 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
99 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
100 Grow the critical sections to include not just invoking
101 localtime/gmtime, but also accessing these functions' results
102 including their tm_zone values if any, and any related TZ setting.
103 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
104 so that the struct tm is saved in the critical section.
105 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
106 motivated by the fact that memory allocation needs to be outside
107 the critical section.
108
0c16dfed
DA
1092012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
110
111 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
112 with RESET_INTERVAL.
113
114 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
115 Remove duplicated buffer name initialization.
116
3f83ace8
JM
1172012-05-02 Jim Meyering <jim@meyering.net>
118
119 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
120
c7b8541e
JM
121 * xfns.c (x_window): Use xstrdup (Bug#11375).
122
90207a15 1232012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
124
125 * xdisp.c (pos_visible_p): If already at a newline from the
126 display string before the 'while' loop, don't walk back the glyphs
127 from it3.glyph_row. Solves assertion violation when the display
128 string begins with a newline (egg.el). (Bug#11367)
129
b593d6a9
AH
1302012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
131
132 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
133 Move to simple.el.
134
4737362e
GM
1352012-05-01 Glenn Morris <rgm@gnu.org>
136
99cf43f9
GM
137 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
138 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
139 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
140 All were removed before 23.1.
141
9311dcff
GM
142 * dispnew.c: Remove HAVE_LIBNCURSES test;
143 it is always true on relevant platforms.
144
4d5c6349
GM
145 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
146 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
147
4737362e
GM
148 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
149
74dd3a6b
AS
1502012-04-30 Andreas Schwab <schwab@linux-m68k.org>
151
152 * .gdbinit (xpr): Remove checks for no longer existing misc types.
153 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
154 Remove.
155
13c379ee
PE
1562012-04-28 Paul Eggert <eggert@cs.ucla.edu>
157
158 Do not avoid creating empty evaporating overlays (Bug#9642).
159 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
160 That is, do not delete an evaporating overlay if it becomes
161 empty after its bounds are adjusted to fit within its buffer.
162 This fix caused other problems, and I'm reverting it until we get
163 to the bottom of them.
164
a8e7d6d7 1652012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
166
167 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
168
a8e7d6d7 1692012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
170
171 * xdisp.c (pos_visible_p): If the window start position is beyond
172 ZV, start the display from buffer beginning. Prevents assertion
173 violation in init_iterator when the minibuffer window is scrolled
174 via the scroll bar.
175
176 * window.c (window_scroll_pixel_based): Likewise.
177
a8e7d6d7 1782012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
179
180 * keymap.c (where_is_internal): Doc fix (Bug#10872).
181
a8e7d6d7 1822012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
183
184 * fileio.c (Fcopy_file, Fset_file_selinux_context):
185 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
186
a8e7d6d7 1872012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 188
b593d6a9
AH
189 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
190 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 191
1c6900d9
EZ
1922012-04-26 Eli Zaretskii <eliz@gnu.org>
193
4c3fa1d9
EZ
194 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
195 display element, check also the underlying string or buffer
196 character. (Bug#11341)
197
1c6900d9
EZ
198 * w32menu.c: Include w32heap.h.
199 (add_menu_item): If the call to AppendMenuW (via
200 unicode_append_menu) fails, disable Unicode menus only if we are
201 running on Windows 9X/Me.
202
42bf8205
AS
2032012-04-24 Andreas Schwab <schwab@linux-m68k.org>
204
205 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
206 (xgetint): Add missing shift for LSB tags.
207
b1bac16e
MR
2082012-04-24 Martin Rudalics <rudalics@gmx.at>
209
210 * keyboard.c (read_char): Don't wipe echo area for select window
211 events: These might get delayed via `mouse-autoselect-window'
212 (Bug#11304).
213
d69621cc
JB
2142012-04-24 Juanma Barranquero <lekktu@gmail.com>
215
216 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
217 manipulation of :loaded-from data.
218
02fd101b
JB
2192012-04-23 Juanma Barranquero <lekktu@gmail.com>
220
221 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
222 now a cons (bug#11311).
223
888bec30
PE
2242012-04-23 Paul Eggert <eggert@cs.ucla.edu>
225
89a438bd
PE
226 Do not create empty overlays with the evaporate property (Bug#9642).
227 * buffer.c (Fmove_overlay): Delete an evaporating overlay
228 if it becomes empty after its bounds are adjusted to fit within
229 its buffer. Without this fix, in a nonempty buffer (let ((o
230 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
231 yields an empty overlay that has the evaporate property, which is
232 not supposed to happen.
233
1068fe4d
PE
234 Fix minor GTK3 problems found by static checking.
235 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
236 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
237 (struct _EmacsFixedClass, emacs_fixed_get_type):
238 Move decls here from emacsgtkfixed.h, since they needn't be public.
239 (emacs_fixed_get_type): Now static.
240 (emacs_fixed_class_init): Omit unused local.
241 (emacs_fixed_child_type): Remove; unused.
242 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
243 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
244 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
245 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
246 (EMACS_FIXED_GET_CLASS): Remove; unused.
247 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
248
888bec30
PE
249 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
250 Problem reported by Juanma Barranquero for Windows -Wunused-function.
251
de85e130
PE
2522012-04-22 Paul Eggert <eggert@cs.ucla.edu>
253
d0baac98
PE
254 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
255 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
256 (__malloc_size_t, __malloc_ptrdiff_t):
257 Remove. All uses removed, replaced by the definiens if needed,
258 since we can assume C89 or better now.
259 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
260 (protect_malloc_state, align, get_contiguous_space)
261 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
262 (malloc_atfork_handler_child, malloc_enable_thread)
263 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
264 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
265 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
266 (special_realloc, _realloc_internal_nolock, _realloc_internal)
267 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
268 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
269 Define using prototypes, not old style.
270 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
271 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
272 (align): Don't assume that signed integer overflow wraps around.
273 Omit unused local var.
274 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
275 (_free_internal_nolock, memalign, mallochook, reallochook):
276 Omit no-longer-needed casts.
277 (valloc): Use getpagesize, not __getpagesize.
278 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
279 (struct hdr): The 'magic' member is now size_t, not unsigned long.
280
de85e130
PE
281 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
282
dcbf5805
MA
2832012-04-22 Michael Albinus <michael.albinus@gmx.de>
284
285 Move functions from C to Lisp. Make non-blocking method calls
286 the default. Implement further D-Bus standard interfaces.
287
288 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
289 (QCdbus_request_name_allow_replacement)
290 (QCdbus_request_name_replace_existing)
291 (QCdbus_request_name_do_not_queue)
292 (QCdbus_request_name_reply_primary_owner)
293 (QCdbus_request_name_reply_in_queue)
294 (QCdbus_request_name_reply_exists)
295 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
296 (QCdbus_registered_serial, QCdbus_registered_method)
297 (QCdbus_registered_signal): New Lisp objects.
298 (XD_DEBUG_MESSAGE): Use sizeof.
299 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
300 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
301 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
302 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
303 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
304 (xd_signature, xd_append_arg): Allow float for integer types.
305 (xd_get_connection_references): New function.
b593d6a9
AH
306 (xd_get_connection_address): Rename from xd_initialize.
307 Return cached address.
dcbf5805
MA
308 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
309 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
310 level.
311 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 312 Return number of refcounts.
dcbf5805
MA
313 (Fdbus_get_unique_name): Make stronger parameter check.
314 (Fdbus_message_internal): New defun.
315 (Fdbus_call_method, Fdbus_call_method_asynchronously)
316 (Fdbus_method_return_internal, Fdbus_method_error_internal)
317 (Fdbus_send_signal, Fdbus_register_service)
318 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
319 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
320 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
321 (Vdbus_compiled_version, Vdbus_runtime_version)
322 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
323 (Vdbus_message_type_method_return, Vdbus_message_type_error)
324 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
325 (Vdbus_registered_buses, Vdbus_registered_objects_table):
326 Adapt docstring.
dcbf5805 327
52828e02
PE
3282012-04-22 Paul Eggert <eggert@cs.ucla.edu>
329
da05bc4c
PE
330 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
331 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
332 Do not assume ptrdiff_t is the same width as 'int'.
333
52828e02
PE
334 * alloc.c: Handle unusual debugging option combinations.
335 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
336 since the two debugging options are incompatible.
337 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
338 is defined.
339 (mem_init, mem_insert, mem_insert_fixup):
340 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
341 (NEED_MEM_INSERT): Remove; no longer needed.
342
f01769f9
LL
3432012-04-22 Leo Liu <sdl.web@gmail.com>
344
345 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
346
5790543d
PE
3472012-04-22 Paul Eggert <eggert@cs.ucla.edu>
348
349 * sysdep.c [__FreeBSD__]: Minor cleanups.
350 (list_system_processes, system_process_attributes) [__FreeBSD__]:
351 Use Emacs indenting style more consistently. Avoid some casts.
352 Use 'double' consistently rather than mixing 'float' and 'double'.
353
b91b7e4d
EW
3542012-04-21 Eduard Wiebe <usenet@pusto.de>
355
b593d6a9
AH
356 * sysdep.c (list_system_processes, system_process_attributes):
357 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 358
6114eb15
AS
3592012-04-21 Andreas Schwab <schwab@linux-m68k.org>
360
361 * lisp.mk (lisp): Update.
362
2f38dff7
PE
3632012-04-20 Paul Eggert <eggert@cs.ucla.edu>
364
365 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
366 It is never used otherwise.
367
4ae29f89
SM
3682012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
369
370 * print.c (print_preprocess): Only check print_depth if print-circle
371 is nil.
372 (print_object): Check for cycles even when print-circle is nil and
373 print-gensym is t, but only check print_depth if print-circle is nil.
374
f30d612a
CY
3752012-04-20 Chong Yidong <cyd@gnu.org>
376
377 * process.c (wait_reading_process_output): If EIO occurs on a pty,
378 set the status to "failed" and ensure that sentinel is run.
379
c07a4c0b 3802012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
381
382 * process.c (Fset_process_inherit_coding_system_flag)
383 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 384 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 385
c07a4c0b 3862012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
387
388 * xdisp.c (string_buffer_position_lim): Limit starting position to
389 BEGV.
390 (set_cursor_from_row): If called for a mode-line or header-line
391 row, return zero immediately.
392 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
393 farther than the first row after the header line, if any.
394 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
395 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
396
c07a4c0b 3972012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 398
4ae29f89
SM
399 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
400 (bug#11238).
ad3a2b41 401
c07a4c0b 4022012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 4032012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
404
405 configure: new option --enable-gcc-warnings (Bug#11207)
406 * Makefile.in (C_WARNINGS_SWITCH): Remove.
407 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
408 (ALL_CFLAGS): Use new macros rather than old.
409 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
410 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
411 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
412 -Wunused-result, -Wunused-variable. This should go away once
413 the Emacs and Gnulib regex code is merged.
414 (xmalloc, xrealloc): Now static.
415
aba027e8
PE
4162012-04-17 Paul Eggert <eggert@cs.ucla.edu>
417
418 * dired.c (Fsystem_groups): Remove unused local.
419
e5a36063
GM
4202012-04-17 Glenn Morris <rgm@gnu.org>
421
422 * dired.c (Fsystem_users): Doc fix.
423
316411f0
DA
4242012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
425
426 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
427 (syms_of_dired): Add them.
428
9426aba4
PE
4292012-04-16 Paul Eggert <eggert@cs.ucla.edu>
430
b62a57be
PE
431 Fix minor alloc.c problems found by static checking.
432 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
433 New extern decls, to avoid calling undeclared functions.
434 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
435 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
436 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
437 (NEED_MEM_INSERT): New macro.
438 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 439 Remove one incorrect comment and fix another.
b62a57be 440
3539f31f
PE
441 Fix minor ralloc.c problems found by static checking.
442 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
443 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
444 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
445 (r_alloc_sbrk): Now static.
446
a041960a
PE
447 Improve ralloc.c interface checking.
448 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
449 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
450 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
451 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
452 [REL_ALLOC]: ... to here, to check interface.
453 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
454 Remove decls. This fixes an "It stinks!".
455
9426aba4
PE
456 * alloc.c (which_symbols): Fix alignment issue / type clash.
457
d55c12ed
AS
4582012-04-15 Andreas Schwab <schwab@linux-m68k.org>
459
460 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
461 (struct Lisp_Misc_Any): Likewise.
462 (struct Lisp_Free): Likewise.
463 * alloc.c (union aligned_Lisp_Symbol): Define.
464 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
465 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
466 (union aligned_Lisp_Misc): Define.
467 (MARKER_BLOCK_SIZE, struct marker_block): Use union
468 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 469 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 470
b948ce8b
PE
4712012-04-14 Paul Eggert <eggert@cs.ucla.edu>
472
473 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
474 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
475 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
476 * s/netbsd.h, s/sol2-6.h:
477 Remove definition of GC_MARK_STACK, since the default now works.
478 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
479 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
480 no longer the default.
481 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
482
35dc09a1 4832012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 484
35dc09a1
GM
485 * lread.c (lisp_file_lexically_bound_p):
486 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 487
35dc09a1
GM
4882012-04-14 Eli Zaretskii <eliz@gnu.org>
489
490 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
491 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
492
4932012-04-14 Jan Djärv <jan.h.d@swipnet.se>
494
495 * nsterm.m (constrainFrameRect): Always constrain when there is only
496 one screen (Bug#10962).
497
bcd86815
KB
4982012-04-13 Ken Brown <kbrown@cornell.edu>
499
500 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
501
c25df26e
RT
5022012-04-13 Reuben Thomas <rrt@sc3d.org>
503
504 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
505
0fc59f1e
DC
5062012-04-11 Daniel Colascione <dancol@dancol.org>
507
508 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
509 against is gone. It's better to use vfork now so that when Cygwin
510 gains a new, working vfork, we use it automatically (bug#10398).
511
de8c03dc
SM
5122012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
513
514 * window.c (save_window_save): Obey window-point-insertion-type.
515
2f097256
GM
5162012-04-11 Glenn Morris <rgm@gnu.org>
517
518 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
519
453b951e
SM
5202012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
521
522 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
523
75f1671a 5242012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
525
526 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
527 (force_quit_count): New var.
528 (handle_interrupt): Use it.
529
2a8ce227
JB
5302012-04-10 Juanma Barranquero <lekktu@gmail.com>
531
532 * w32.c (w32_delayed_load): Record the full path of the library
533 being loaded (bug#10424).
534
935396c0
GM
5352012-04-09 Glenn Morris <rgm@gnu.org>
536
05920a43
GM
537 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
538 not just in the obarray, before snarfing them. (Bug#11036)
539
935396c0
GM
540 * Makefile.in ($(leimdir)/leim-list.el):
541 Pass EMACS rather than BUILT_EMACS.
542
a18ecafa
TZ
5432012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
544
545 * process.c (make_process):
546 * process.h: Add integer `gnutls_handshakes_tried' member to
547 process struct.
548
6bbef4e5
JC
549 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
550 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
551
552 * gnutls.c (gnutls_log_function2i): Convenience log function.
553 (emacs_gnutls_read): Use new log functions,
554 `gnutls_handshakes_tried' process member, and
555 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
556 attempts per process (connection).
557
b4d3bc10
CY
5582012-04-09 Chong Yidong <cyd@gnu.org>
559
560 * eval.c (Fuser_variable_p, user_variable_p_eh)
561 (lisp_indirect_variable): Functions deleted.
562 (Fdefvar): Caller changed.
563
564 * callint.c (Finteractive, Fcall_interactively):
565 * minibuf.c (Fread_variable): Callers changed.
566
70f4d973
EZ
5672012-04-09 Eli Zaretskii <eliz@gnu.org>
568
569 * xdisp.c (set_cursor_from_row): If the display string appears in
570 the buffer at position that is closer to point than the position
571 after the display string, display the cursor on the first glyph of
572 the display string. Fixes cursor display when a 'display' text
573 property immediately follows invisible text. (Bug#11094)
574
cb3c2e3e
PE
5752012-04-09 Paul Eggert <eggert@cs.ucla.edu>
576
577 composite.c: use 'double' consistently
578 * composite.c (get_composition_id): Use 'double' consistently
579 instead of converting 'float' to 'double' and vice versa; this is
580 easier to understand and avoids a GCC warning.
581
fd06db5d
GM
5822012-04-09 Glenn Morris <rgm@gnu.org>
583
50fe702a
GM
584 * Makefile.in: Generate leim-list with bootstrap-emacs, in
585 preparation for dumping it with emacs. (Bug#4789)
586 (leimdir): New variable.
587 ($(leimdir)/leim-list.el): New rule.
588 (emacs$(EXEEXT)): Depend on leim-list.el.
589
fd06db5d
GM
590 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
591 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
592 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
593
55c131ee
AS
5942012-04-08 Andreas Schwab <schwab@linux-m68k.org>
595
596 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
597 proper alignment.
598
9209588f
JB
5992012-04-07 Juanma Barranquero <lekktu@gmail.com>
600
601 * xml.c (init_libxml2_functions) [WINDOWSNT]:
602 Remove unused local variable.
603
e3fb2efb
PE
6042012-04-07 Paul Eggert <eggert@cs.ucla.edu>
605
606 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
607 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
608 (mark_memory): Mark Lisp_Objects only if pointers might hide in
609 objects, as mark_maybe_pointer will catch them otherwise.
610 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
611 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
612
b5385551
PE
6132012-04-07 Paul Eggert <eggert@cs.ucla.edu>
614
615 Fix typo that broke non-Windows builds.
616 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
617
9078ead6
EZ
6182012-04-07 Eli Zaretskii <eliz@gnu.org>
619
620 Support building on MS-Windows with libxml2.
621
622 * makefile.w32-in (OBJ2): Add xml.$(O).
623 (GLOBAL_SOURCES): Add xml.c.
624 ($(BLD)/xml.$(O)): New dependency list.
625
626 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
627 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
628 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
629 [!WINDOWSNT]: New macros.
630 (init_libxml2_functions, libxml2_loaded_p): New functions.
631 (parse_region): Call fn_xmlCheckVersion instead of using the macro
632 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
633 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
634 Calls xmlCleanupParser only if libxml2 was loaded (or statically
635 linked in).
6bbef4e5
JC
636 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
637 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
638 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
639
640 * emacs.c: Don't include libxml/parser.h.
641 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
642 xmlCleanupParser directly.
643
644 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
645
3811fdf3
EZ
6462012-04-07 Eli Zaretskii <eliz@gnu.org>
647
648 * indent.c (Fvertical_motion): If there is a display string at
649 point, use it.vpos to compute how many lines to backtrack after
650 move_it_to point. (Bug#11133)
651
2f8e16b2
EZ
6522012-04-06 Eli Zaretskii <eliz@gnu.org>
653
654 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
655 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
656 about subtle differences between FETCH_CHAR* and STRING_CHAR*
657 macros related to unification of CJK characters. For the details,
658 see the discussion following the message here:
659 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
660
3d439cd1
CY
6612012-04-04 Chong Yidong <cyd@gnu.org>
662
663 * keyboard.c (Vdelayed_warnings_list): Doc fix.
664
8bc53d00
EZ
6652012-04-01 Eli Zaretskii <eliz@gnu.org>
666
667 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
668 instead of alloca. (Bug#11138)
669
3b0512a3
AS
6702012-04-01 Andreas Schwab <schwab@linux-m68k.org>
671
672 * w32menu.c (is_simple_dialog): Properly check lisp types.
673 (Bug#11141)
674
8427ddd2
EZ
6752012-03-31 Eli Zaretskii <eliz@gnu.org>
676
979022ef
EZ
677 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
678 position we get to after a call to move_it_to fails the
679 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
680 only if we wind up in a string from display property. (Bug#11063)
681
a6b1c7cc
EZ
682 * window.c (Fdelete_other_windows_internal): Invalidate the row
683 and column information about mouse highlight, so that redisplay
684 restores it after reallocating the glyph matrices. (Bug#7464)
685
8427ddd2
EZ
686 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
687 string comes from a `display' text property, use the buffer
688 position of that property as if we actually saw that position in
689 the row's glyphs.
697ba24b
EZ
690 (move_it_by_lines): Remove the assertion that
691 "it->current_x == 0 && it->hpos == 0" which can be legitimately
692 violated when there's a before-string at the beginning of a line.
693 (Bug#11063)
8427ddd2 694
65a0a738
EZ
6952012-03-30 Eli Zaretskii <eliz@gnu.org>
696
697 * xdisp.c (append_space_for_newline): If the default face was
698 remapped, use the remapped face for the appended newline.
699 (extend_face_to_end_of_line): Use the remapped default face for
700 extending the face to the end of the line.
701 (display_line): Call extend_face_to_end_of_line when the default
702 face was remapped. (Bug#11068)
703
581355cc
EZ
7042012-03-29 Eli Zaretskii <eliz@gnu.org>
705
706 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
707
e8fc049f
SM
7082012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
709
710 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
711
4fb9a543
GM
7122012-03-27 Glenn Morris <rgm@gnu.org>
713
714 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
715 Doc fixes.
716
679910f1
KH
7172012-03-26 Kenichi Handa <handa@m17n.org>
718
719 * dispextern.h (struct glyph): Fix previous change. Change the
720 bit length of glyphless.ch to 25 (Bug#11082).
721
90d49b7f
CY
7222012-03-26 Chong Yidong <cyd@gnu.org>
723
724 * keyboard.c (Vselection_inhibit_update_commands): New variable.
725 (command_loop_1): Use it; inhibit selection update for
726 handle-select-window too (Bug#8996).
727
f514f6f0
FP
7282012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
729
e8fc049f 730 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 731
bf43fa51
KH
7322012-03-25 Kenichi Handa <handa@m17n.org>
733
734 * dispextern.h (struct glyph): Change the bit length of
735 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
736
8a0c01dd
EZ
7372012-03-24 Eli Zaretskii <eliz@gnu.org>
738
739 * s/ms-w32.h (tzname): Include time.h before redirecting to
740 _tzname. Fixes the MSVC build. (Bug#9960)
741
7d1c3a76
AS
7422012-03-24 Andreas Schwab <schwab@linux-m68k.org>
743
8ed79523
AS
744 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
745 characters.
746
7d1c3a76
AS
747 * xterm.c (XTread_socket): Only modify handling_signal if
748 !SYNC_INPUT. (Bug#11080)
749
e99a9b8b
EZ
7502012-03-23 Eli Zaretskii <eliz@gnu.org>
751
752 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
753 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
754 when fetching a multibyte character consumes more bytes than
755 CHAR_BYTES returns, due to unification of CJK characters in
756 string_char. (Bug#11073)
757
5063c0e1
TN
7582012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
759
760 * process.c (wait_reading_process_output): Handle pty disconnect
761 by refraining from sending oneself a SIGCHLD (bug#10933).
762
9f851fbd
CY
7632012-03-22 Chong Yidong <cyd@gnu.org>
764
765 * dispextern.h (struct it): New member string_from_prefix_prop_p.
766
5063c0e1 767 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
768 Mark string as coming from a prefix property.
769 (handle_face_prop): Use default face for prefix strings (Bug#4281).
770 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
771
fb5b8aca
CY
7722012-03-21 Chong Yidong <cyd@gnu.org>
773
774 * xfaces.c (Vface_remapping_alist): Doc fix.
775
62356a1b
EZ
7762012-03-20 Eli Zaretskii <eliz@gnu.org>
777
778 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
779 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
780 Doc fixes.
62356a1b 781
025de85b
CY
7822012-03-20 Chong Yidong <cyd@gnu.org>
783
784 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
785 to reflect default non-nil value of redisplay-dont-pause.
786
4827f94e
KH
7872012-03-19 Kenichi Handa <handa@m17n.org>
788
789 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
790 it fit in a valid range (Bug#11003).
791
e50a24a2
EZ
7922012-03-18 Eli Zaretskii <eliz@gnu.org>
793
794 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
795 that is not from display property, accept the row as a "cursor
796 row" if one of the string's character has a non-nil `cursor'
797 property. Fixes cursor positioning when there are newlines in
798 overlay strings, e.g. in icomplete.el. (Bug#11035)
799
9af5ed87
PE
8002012-03-12 Paul Eggert <eggert@cs.ucla.edu>
801
802 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
803
d1f55f16
CY
8042012-03-12 Chong Yidong <cyd@gnu.org>
805
806 * eval.c (inhibit_lisp_code): Rename from
807 inhibit_window_configuration_change_hook; move from window.c.
808
809 * xfns.c (unwind_create_frame_1, Fx_create_frame):
810 * window.c (run_window_configuration_change_hook)
811 (syms_of_window): Callers changed.
812
66c5eebd
CY
8132012-03-11 Chong Yidong <cyd@gnu.org>
814
413df973
CY
815 * keymap.c (Fkey_description): Doc fix (Bug#9700).
816
66c5eebd
CY
817 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
818
1de11f56
CY
8192012-03-10 Chong Yidong <cyd@gnu.org>
820
821 * frame.c (other_visible_frames): Don't assume the selected frame
822 is visible (Bug#10955).
823
cae07000
SM
8242012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
825
826 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
827
89c94350
JD
8282012-03-08 Jan Djärv <jan.h.d@swipnet.se>
829
830 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
831 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
832 zero (Bug#10954).
833
999dd333
GM
8342012-03-03 Glenn Morris <rgm@gnu.org>
835
01a6dcc8 836 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 837
de0100f2
EZ
8382012-03-02 Eli Zaretskii <eliz@gnu.org>
839
840 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
841 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
842 (redisplay_window, next_element_from_string): Fix typos in
843 comments.
3e441275
EZ
844 (redisplay_window): Pass to move_it_vertically the margin in
845 pixels, not in screen lines.
de0100f2 846
96a72ee9
GM
8472012-03-02 Glenn Morris <rgm@gnu.org>
848
849 * buffer.c (buffer-list-update-hook): Doc fix.
850
312508d7
EZ
8512012-02-29 Eli Zaretskii <eliz@gnu.org>
852
853 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
854 push_it before setting up the iterator for the first overlay
855 string, even if we have an empty string loaded.
856 (next_overlay_string): If there's an empty string on the iterator
857 stack, pop the stack. (Bug#10903)
858
27f3c637
PE
8592012-02-25 Paul Eggert <eggert@cs.ucla.edu>
860
861 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
862 Suggested by Stefan Monnier in
863 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
864 * alloc.c (widen_to_Lisp_Object): New static function.
865 (mark_memory): Also mark Lisp_Objects by fetching pointer words
866 and widening them to Lisp_Objects. This would work even if
867 USE_LSB_TAG is defined and wide integers are used, which might
868 happen in a future version of Emacs.
869
3c9dfce6
CY
8702012-02-25 Chong Yidong <cyd@gnu.org>
871
fa74b241
CY
872 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
873 Doc fix.
874
3c9dfce6
CY
875 * xselect.c (Fx_selection_exists_p): Doc fix.
876 (x_clipboard_manager_save_all): Print an informative message
877 before saving to clipboard manager.
878
9486df08
CY
8792012-02-24 Chong Yidong <cyd@gnu.org>
880
881 * keyboard.c (process_special_events): Handle all X selection
882 requests in kbd_buffer, not just the next one (Bug#8869).
883
f01d3321
CY
8842012-02-23 Chong Yidong <cyd@gnu.org>
885
886 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
887 call when setting menu-bar-lines and tool-bar-lines parameters.
888 (unwind_create_frame_1): New helper function.
889
890 * window.c (inhibit_window_configuration_change_hook): New var.
891 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 892 (syms_of_window): Initialize it.
f01d3321 893
86b847b6
CY
8942012-02-22 Chong Yidong <cyd@gnu.org>
895
896 * xterm.c (x_draw_image_relief): Add missing type check for
897 Vtool_bar_button_margin (Bug#10743).
898
a59225b1
CY
8992012-02-21 Chong Yidong <cyd@gnu.org>
900
901 * fileio.c (Vfile_name_handler_alist): Doc fix.
902
903 * buffer.c (Fget_file_buffer): Protect against invalid file
904 handler return value.
905
310f5bd4
PE
9062012-02-20 Paul Eggert <eggert@cs.ucla.edu>
907
cb3a28cc
PE
908 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
909 when computing $valmask.
910
310f5bd4
PE
911 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
912 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
913 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
914 It's useless in that case, and it can cause problems on hosts
915 that allocate halves of EMACS_INT values separately.
916 Reported by Dan Horák. Diagnosed by Andreas Schwab in
917 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
918 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
919 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
920 it avoids undefined behavior on hosts where shifting right by more
921 than the word width has undefined behavior.
922
2375c96a
CY
9232012-02-19 Chong Yidong <cyd@gnu.org>
924
925 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
926 (Funhandled_file_name_directory, Ffile_name_as_directory)
927 (Fdirectory_file_name, Fexpand_file_name)
928 (Fsubstitute_in_file_name): Protect against invalid file handler
929 return values (Bug#10845).
930
3eb49e71
EZ
9312012-02-18 Eli Zaretskii <eliz@gnu.org>
932
933 * .gdbinit (pitx): Fix incorrect references to fields of the
934 iterator stack.
935
7b926f3f
CY
9362012-02-17 Chong Yidong <cyd@gnu.org>
937
938 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
939
11273115
PE
9402012-02-15 Paul Eggert <eggert@cs.ucla.edu>
941
942 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
943 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
944
c3a70e2b
CY
9452012-02-15 Chong Yidong <cyd@gnu.org>
946
947 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
948 marked as special. Also, starting docstrings with * is obsolete.
949
0ca43699
AS
9502012-02-13 Andreas Schwab <schwab@linux-m68k.org>
951
952 * gnutls.c (emacs_gnutls_write): Fix last change.
953
2e8f3c56
LI
9542012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
955
956 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
957 send_process.
958
af70074f
SM
9592012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
960
961 * keymap.c (Fsingle_key_description): Handle char ranges.
962
95986d52
CY
9632012-02-12 Chong Yidong <cyd@gnu.org>
964
afd83bd1
CY
965 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
966 as that creates a dangerous corner case.
967
95986d52
CY
968 * window.c (Fdelete_window_internal): Invalidate the mouse
969 highlight (Bug#9904).
970
bd7da63e
GM
9712012-02-12 Glenn Morris <rgm@gnu.org>
972
973 * xselect.c (Fx_own_selection_internal)
974 (Fx_get_selection_internal, Fx_disown_selection_internal)
975 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
976 * nsselect.m (Fx_own_selection_internal)
977 (Fx_disown_selection_internal, Fx_selection_exists_p)
978 (Fx_selection_owner_p, Fx_get_selection_internal):
979 Sync docs and argument specs with the xselect.c versions.
980
77abcbc2
LI
9812012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
982
983 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
984
90b671e2
EZ
9852012-02-11 Eli Zaretskii <eliz@gnu.org>
986
1c0ca0b7
EZ
987 * w32select.c (Fx_selection_exists_p): Sync doc string and
988 argument list with xselect.c. (Bug#10783)
989
990 * w16select.c (Fx_selection_exists_p): Sync doc string and
991 argument list with xselect.c. (Bug#10783)
90b671e2 992
49241268
GM
9932012-02-10 Glenn Morris <rgm@gnu.org>
994
995 * fns.c (Fsecure_hash): Doc fix.
996
f998bbe7 9972012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
998
999 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1000
0992bd9c
CY
10012012-02-07 Chong Yidong <cyd@gnu.org>
1002
1003 * buffer.c (Fbuffer_local_variables)
1004 (buffer_lisp_local_variables): Handle unbound vars correctly;
1005 don't let Qunbound leak into Lisp.
1006
af008560
GM
10072012-02-07 Glenn Morris <rgm@gnu.org>
1008
dd605cc4
GM
1009 * image.c (Fimagemagick_types): Doc fix.
1010
af008560
GM
1011 * image.c (imagemagick-render-type): Change it from a lisp object
1012 to an integer. Move the doc here from the lisp manual.
1013 Treat all values not equal to 0 the same.
1014
1449fa1d
CY
10152012-02-06 Chong Yidong <cyd@gnu.org>
1016
1017 * doc.c (store_function_docstring): Avoid applying docstring of
1018 alias to base function (Bug#2603).
1019
3723ec07
AS
10202012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1021
1022 * .gdbinit (pp1, pv1): Remove redundant defines.
1023 (pr): Use pp.
1024
79c1cc1e
CY
10252012-02-04 Chong Yidong <cyd@gnu.org>
1026
1027 * nsterm.m: Declare a global (Bug#10694).
1028
d7f29f8e
EZ
10292012-02-04 Eli Zaretskii <eliz@gnu.org>
1030
cae07000
SM
1031 * w32.c (get_emacs_configuration_options):
1032 Include --enable-checking, if specified, in the return value.
d7f29f8e 1033
3b95a6f9
MR
10342012-02-04 Martin Rudalics <rudalics@gmx.at>
1035
1036 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1037 after rounding frame sizes. (Bug#9723)
1038
d6fa96a6
EZ
10392012-02-04 Eli Zaretskii <eliz@gnu.org>
1040
1041 * keyboard.c (adjust_point_for_property): Don't position point
1042 before BEGV. (Bug#10696)
1043
df0b2940
PE
10442012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1045
1046 Handle overflow when computing char display width (Bug#9496).
1047 * character.c (char_width): Return EMACS_INT, not int.
1048 (char_width, c_string_width): Check for overflow when
1049 computing the width; this is possible now that individual
1050 characters can have unbounded width. Problem introduced
1051 by merge from Emacs 23 on 2012-01-19.
1052
6bee44d6
MA
10532012-02-02 Michael Albinus <michael.albinus@gmx.de>
1054
1055 * dbusbind.c (Fdbus_register_method): Mention the return value
1056 :ignore in the docstring.
1057
44f92739
GM
10582012-02-02 Glenn Morris <rgm@gnu.org>
1059
1b9f60cc
GM
1060 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1061
44f92739
GM
1062 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1063 Unconditionally set to t. (Bug#10673)
1064 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1065 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1066 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1067
c5d3843c
KH
10682012-02-02 Kenichi Handa <handa@m17n.org>
1069
1070 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1071 0, do not call append_composite_glyph.
1072
159462d4 10732012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
1074
1075 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1076 NULL (Bug#6988).
1077 (x_produce_glyphs): If the component of a composition is a null
1078 string, set it->pixel_width to 1 to avoid zero-width glyph.
1079
78cef877
EZ
10802012-02-01 Eli Zaretskii <eliz@gnu.org>
1081
1082 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1083 first 2 arguments are identical. This makes inserting large
1084 output from a subprocess an order of magnitude faster on
1085 MS-Windows, where all sbrk'ed memory is always contiguous.
1086
97897668
GM
10872012-01-31 Glenn Morris <rgm@gnu.org>
1088
1089 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 1090 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
1091 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1092
31fd3586
GM
10932012-01-29 Glenn Morris <rgm@gnu.org>
1094
1095 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1096
0e24a8b2
CY
10972012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1098
1099 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1100
cc0adcb0
CY
11012012-01-28 Chong Yidong <cyd@gnu.org>
1102
1103 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1104
acc28cb9
CY
11052012-01-26 Chong Yidong <cyd@gnu.org>
1106
9c69cfb7
CY
1107 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1108
acc28cb9
CY
1109 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1110 repeat counts (Bug#10507).
1111
48da7392
GM
11122012-01-26 Glenn Morris <rgm@gnu.org>
1113
1114 * lread.c (syms_of_lread): Doc fix.
1115
14af5f7f
CY
11162012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1117
1118 * coding.c (encode_designation_at_bol): Change return value to
1119 EMACS_INT.
1120
0b21c100
CY
11212012-01-25 Chong Yidong <cyd@gnu.org>
1122
1123 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1124
3c2907f7
CY
11252012-01-21 Chong Yidong <cyd@gnu.org>
1126
1127 * floatfns.c (Fcopysign): Make the second argument non-optional,
1128 since nil is not allowed anyway.
1129
959ad23f
AS
11302012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1131
1132 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1133 (send_process): Likewise.
1134
34a02f46
MR
11352012-01-19 Martin Rudalics <rudalics@gmx.at>
1136
1137 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
1138 (Vwindow_persistent_parameters): Do not use Qstate.
1139 Rewrite doc-strings.
34a02f46 1140
1259009a 11412012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
1142
1143 * character.c (char_width): New function.
70d4fdf6
GM
1144 (Fchar_width, c_string_width, lisp_string_width):
1145 Use char_width (Bug#9496).
25ed9e61 1146
6a6ee00d
MR
11472012-01-16 Martin Rudalics <rudalics@gmx.at>
1148
1149 * window.c (Vwindow_persistent_parameters): New variable.
1150 (Fset_window_configuration, save_window_save): Handle persistent
1151 window parameters.
1152
c85efaf7
EZ
11532012-01-14 Eli Zaretskii <eliz@gnu.org>
1154
1155 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1156 thrashing the stack of the thread. (Bug#9087)
1157
5944709e
PE
11582012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1159
1160 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1161
e71f5d99
EZ
11622012-01-11 Eli Zaretskii <eliz@gnu.org>
1163
1164 * xdisp.c (rows_from_pos_range): Handle the case where the
1165 highlight ends on a newline. (Bug#10464)
1166 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1167 he end column for display of highlight that ends on a newline
1168 before a R2L line.
1169
ce316182
GM
11702012-01-11 Glenn Morris <rgm@gnu.org>
1171
1172 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1173 from load-path also when installation-directory is nil. (Bug#10208)
1174
5b43da69
GM
11752012-01-10 Glenn Morris <rgm@gnu.org>
1176
74cc8ff9
GM
1177 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1178
7d8d6e4e
GM
1179 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1180 Update template values to be closer to their typical values these days.
5b43da69 1181
a0db8d43
EZ
11822012-01-09 Eli Zaretskii <eliz@gnu.org>
1183
1184 * xdisp.c (rows_from_pos_range): Accept additional argument
1185 DISP_STRING, and accept any glyph in a row whose object is that
1186 string as eligible for mouse highlight. Fixes mouse highlight of
1187 display strings from overlays. (Bug#10464)
1188
9a0115ab 11892012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1190
b9110d6a 1191 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1192 * fileio.c (auto_saving_dir_umask): New static var.
1193 (Fmake_directory_internal): Use it.
1194 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1195 creating the directory. The old code temporarily assigns
1196 too-generous permissions to the directory.
1197 (do_auto_save_eh): Clear it.
b9110d6a 1198 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1199 that the var is always cleared.
1200
6c1bd3f3
EZ
12012012-01-07 Eli Zaretskii <eliz@gnu.org>
1202
1203 * search.c (scan_buffer): Pass character positions to
1204 know_region_cache, not byte positions. (Bug#6540)
1205
069d2b50
L
12062012-01-07 LynX <_LynX@bk.ru> (tiny change)
1207
1208 * w32.c (sys_rename): Report EXDEV when rename of a directory
1209 fails because the target is on another logical disk. (Bug#10284)
1210
75bf0d33
DB
12112012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1212
1213 * xterm.c (x_embed_request_focus): New function.
1214
1215 * xterm.h: Add prototype.
1216
1217 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1218
1c6e5a32
GM
12192012-01-05 Glenn Morris <rgm@gnu.org>
1220
1221 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1222
651e947e
EZ
12232012-01-01 Eli Zaretskii <eliz@gnu.org>
1224
1225 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1226 Load gnutls_transport_set_lowat only if GnuTLS version is below
1227 2.11.1.
1228 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1229 GnuTLS versions below 2.11.1.
1230
3778cdd8
AL
12312011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1232
1233 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1234 to the doc string advising against its use for altering the way
1235 windows are scrolled.
1236
0e5317f7
KH
12372011-12-28 Kenichi Handa <handa@m17n.org>
1238
1239 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1240 coding-system ASCII compatible only when it does not produce BOM
1241 on encoding (Bug#10383).
1242
93d5ca1f
JD
12432011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1244
1245 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1246 can scroll.
1247 (create_and_show_popup_menu): Always use menu_position_func for
1248 Gtk3 (Bug#10361).
1249
ca22b785
AS
12502011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1251
1252 * callint.c (Fcall_interactively): Don't truncate prompt string.
1253
d048e1e6
EZ
12542011-12-23 Eli Zaretskii <eliz@gnu.org>
1255
1256 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1257 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1258 resumed from there (after widening). (Bug#10360)
d048e1e6 1259
5ccaba1f
JD
12602011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1261
1262 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1263
204ee57f
JD
12642011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1265
b81d40f0
JB
1266 * nsterm.m (x_free_frame_resources):
1267 Release f->output_data.ns->miniimage.
204ee57f
JD
1268 (ns_index_color): Fix indentation. Do not retain
1269 color_table->colors[i].
1270
1271 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1272 before returning.
1273
1274 * nsfns.m (x_set_background_color): Assign return value from
1275 ns_index_color to face-background instead of NSColor*.
1276 (ns_implicitly_set_icon_type): Fix indentation.
1277 Change assignment in for loop to comparison.
1278
1279 * emacs.c (ns_pool): New variable.
1280 (main): Assign ns_pool.
1281 (Fkill_emacs): Call ns_release_autorelease_pool.
1282
1283 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1284 autorelease fdesc, release fdAttrs and tdict.
1285 (ns_get_covering_families): Release charset.
1286 (ns_findfonts): Release NSFontDescriptor created with new.
1287 (ns_uni_to_glyphs): Fix indentation.
1288 (setString): Release attrStr before assigning new value.
1289
c803b2b7
JD
12902011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1291
678f4426
JD
1292 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1293 and NS_IMPL_COCOA.
1294 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1295 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1296
cd394be1 12972011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1298
5fecd5fc
JD
1299 * nsterm.m (ns_term_init): Subscribe for notifications
1300 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1301 to method trackingNotification in EmacsMenu.
1302
1303 * nsmenu.m (trackingMenu): New variable.
3771cb17 1304 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1305 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1306 from Aquamacs (Bug#7030).
678f4426
JD
1307
13082011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1309
c803b2b7
JD
1310 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1311 (symbol_to_nsstring): Fix indentation.
1312 (ns_symbol_to_pb): New function.
cae07000
SM
1313 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1314 (Fns_rotate_cut_buffers_internal): Remove.
1315 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1316 Fns_store_cut_buffer_internal.
1317 (ns_get_foreign_selection, Fx_own_selection_internal)
1318 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1319 (Fns_get_selection_internal, Fns_store_selection_internal):
1320 Use ns_symbol_to_pb and check if return value is nil.
1321 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1322 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1323 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1324 renamed to Sns_store_selection_internal.
1325 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1326 and remove this function.
1327 (ns_handle_selection_clear): Remove, never used.
1328 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1329 here.
1330
e1b01a3a
KB
13312011-12-17 Ken Brown <kbrown@cornell.edu>
1332
1333 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1334 GID is unknown (Bug#10257).
1335
2adb6e85
PE
13362011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1337
1338 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1339 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1340 which caused a build failure on GNU/Linux IA-64. This problem was
1341 introduced by my 2011-10-07 patch.
1342
d1d7b339
JL
13432011-12-15 Juri Linkov <juri@jurta.org>
1344
1345 * image.c (imagemagick_error): New function. (Bug#10112)
1346 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1347 Use `imagemagick_error' where ImageMagick functions return
1348 `MagickFalse'.
1349 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1350 proper order.
1351
100d5755
KH
13522011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1353
1354 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1355 fill background (Bug#8992).
1356
454592a6
MR
13572011-12-13 Martin Rudalics <rudalics@gmx.at>
1358
1359 * window.c (Vwindow_combination_resize)
1360 (Vwindow_combination_limit): Use t instead of non-nil in
1361 doc-strings.
61d4b438
MR
1362 (Vrecenter_redisplay): Add first sentence of doc-string on
1363 separate line.
53524d93 1364 (Frecenter): Fix doc-string typo.
454592a6 1365
3633e3aa
KH
13662011-12-11 Kenichi Handa <handa@m17n.org>
1367
1368 * coding.c (Funencodable_char_position): Pay attention to the
1369 buffer text relocation (Bug#9389).
1370
7b9d523a
JD
13712011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1372
1373 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1374 gtk_init (Bug#10100).
1375
b73189c6
EZ
13762011-12-10 Eli Zaretskii <eliz@gnu.org>
1377
1378 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1379 IT->string is nil. (Bug#10263)
1380
f7dfe5d6
JD
13812011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1382
83faebb4
JD
1383 * nsterm.h (x_free_frame_resources): Declare.
1384
f7dfe5d6
JD
1385 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1386 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1387
1388 * nsterm.h (ns_get_defaults_value): Declare.
1389
1390 * nsterm.m (ns_default): Call ns_get_defaults_value.
1391
7cd4e72c
EZ
13922011-12-09 Eli Zaretskii <eliz@gnu.org>
1393
1394 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1395 (Bug#10170)
1396
b34d7317
YM
13972011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1398
1399 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1400 that where the value of an _OBJC_* symbol points to is in the .bss
1401 section (Bug#10240).
1402
76470ad1
KH
14032011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1404
1405 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1406 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1407
745fff94
KH
14082011-12-08 Kenichi Handa <handa@m17n.org>
1409
1410 * ftfont.c (get_adstyle_property): Fix previous change
1411 (Bug#10233).
1412
6e44397c
JB
14132011-12-07 Juanma Barranquero <lekktu@gmail.com>
1414
1415 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1416 dirs from the default value of EMACSLOADPATH (bug#10208).
1417
7efa6272
GM
14182011-12-07 Glenn Morris <rgm@gnu.org>
1419
1420 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1421 installation and source directories as well. (Bug#10208)
1422
f6fc4d87
CY
14232011-12-06 Chong Yidong <cyd@gnu.org>
1424
1425 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1426
2bf26180
GM
14272011-12-06 Glenn Morris <rgm@gnu.org>
1428
1429 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1430 as an error, not just -1. (Bug#10217)
1431
3a6ad4f0
CY
14322011-12-05 Chong Yidong <cyd@gnu.org>
1433
1434 * keyboard.c (process_special_events): New function.
1435 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1436
75a3b399
PE
14372011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1438
1439 * coding.c (encode_designation_at_bol): Don't use uninitialized
1440 local variable (Bug#9318).
1441
c3c9e25e
KH
14422011-12-05 Kenichi Handa <handa@m17n.org>
1443
1444 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1445 return Qnil (Bug#8046, Bug#10193).
1446
5eb05ea3
KH
14472011-12-05 Kenichi Handa <handa@m17n.org>
1448
1449 * coding.c (encode_designation_at_bol): New args charbuf_end and
1450 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1451 (coding_set_source): Return how many bytes coding->source was
1452 relocated.
1453 (coding_set_destination): Return how many bytes
1454 coding->destination was relocated.
1455 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1456 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1457
14582011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1459
1460 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1461 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1462 macro (Bug#9318).
1463
14642011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1465
1466 The following changes are to fix Bug#9318.
1467
a79703f5 1468 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1469 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1470 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1471 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1472
7dbda6df
JB
14732011-12-05 Juanma Barranquero <lekktu@gmail.com>
1474
1475 * lisp.h (process_quit_flag): Fix external declaration.
1476
6d5eb5b0
SM
14772011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1478
1479 Don't macro-inline non-performance-critical code.
1480 * eval.c (process_quit_flag): New function.
1481 * lisp.h (QUIT): Use it.
1482
a0c3fad0
JD
14832011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1484
1485 * nsfns.m (get_geometry_from_preferences): New function.
1486 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1487
6c07aac2
AS
14882011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1489
1490 * emacs.c (Qkill_emacs): Define.
1491 (syms_of_emacs): Initialize it.
1492 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1493 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1494 (quit_throw_to_read_char): Add parameter `from_signal'.
1495 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1496 * lisp.h (QUIT): Call Fkill_emacs if requested.
1497
c052ead4
JD
14982011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1499
1500 * widget.c (update_wm_hints): Return if wmshell is null.
1501 (widget_update_wm_size_hints): New function.
1502
1503 * widget.h (widget_update_wm_size_hints): Declare.
1504
1505 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1506 widget_update_wm_size_hints (Bug#10104).
1507
9e49252b
EZ
15082011-12-03 Eli Zaretskii <eliz@gnu.org>
1509
1510 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1511 before a newline, prepare the bidi iterator for consuming the
1512 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1513 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1514
02b16839
JL
15152011-12-02 Juri Linkov <juri@jurta.org>
1516
1517 * search.c (Fword_search_regexp): New Lisp function created from
1518 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1519 (Fword_search_backward, Fword_search_forward)
1520 (Fword_search_backward_lax, Fword_search_forward_lax):
1521 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1522 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1523
0068070e
SM
15242011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1525
1526 * fileio.c (Finsert_file_contents): Move after-change-function call
1527 to before the "handled:" label, since all "goto handled" appear in
1528 cases where the *-change-functions have already been properly called
1529 (bug#10117).
1530
3360a3fc
AS
15312011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1532
1533 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1534 waiting for input. (Bug#10169)
1535
73d6c093
EZ
15362011-11-30 Eli Zaretskii <eliz@gnu.org>
1537
1538 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1539 verifies glyph row's hash code--we have just reallocated the
1540 glyphs, so their contents can be complete garbage. (Bug#10164)
1541
febe6bea
JB
15422011-11-30 Juanma Barranquero <lekktu@gmail.com>
1543
1544 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1545
801a4313
EZ
15462011-11-30 Eli Zaretskii <eliz@gnu.org>
1547
1548 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1549 attributes are tested _before_ calling verify_row_hash, to protect
1550 against GCC re-ordering of the tests. (Bug#10164)
1551
2b56b87e
JD
15522011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1553
1554 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1555
1556 * xterm.c (handle_one_xevent): Only set async_visible and friends
1557 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1558 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1559 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1560
dbf31225
PE
15612011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1562
1563 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1564 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1565 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1566 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1567 All uses changed to use GCPRO1 etc.
1568 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1569 Revert to old implementation (i.e., before 2011-03-11).
1570
1305621b
YM
15712011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1572
1573 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1574 of scroll runs so as to avoid assigning disabled bogus rows and
1575 unnecessary graphics copy operations.
1576
8c9afb46
EZ
15772011-11-27 Eli Zaretskii <eliz@gnu.org>
1578
1579 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1580 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1581 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1582 (malloc, free, realloc, calloc): Redirect to e_* only when
1583 compiling Emacs.
1584
1585 * lisp.h (GCTYPEBITS): Move before first use.
1586 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1587 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1588 this macro definition.
1589
1590 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1591 _MSC_VER.
1592
54e9e3bf
JD
15932011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1594
6d5eb5b0
SM
1595 * gtkutil.c (xg_create_frame_widgets):
1596 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1597 present with Gtk+ 2.0.
1598
83aca1cb
PE
15992011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1600
1601 * fileio.c (Finsert_file_contents): Undo previous change; see
1602 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1603
5b76caa4
PE
16042011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1605
1606 Rename locals to avoid shadowing.
1607 * fileio.c (Finsert_file_contents):
1608 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1609 * process.c (wait_reading_process_output):
1610 Rename inner 'proc' to 'p' to avoid shadowing.
1611 Indent for consistency with usual Emacs style.
1612
8c535114
EZ
16132011-11-25 Eli Zaretskii <eliz@gnu.org>
1614
1615 * xdisp.c (redisplay_window): If cursor row is not fully visible
1616 after recentering, and scroll-conservatively is set to a large
1617 number, scroll window by a few more lines to make the cursor fully
1618 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1619 (start_display): Don't move to the next line if the display should
1620 start at a newline that is part of a display vector or an overlay
1621 string. (Bug#10119)
8c535114 1622
fa4fdb5c
JL
16232011-11-24 Juri Linkov <juri@jurta.org>
1624
1625 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1626 after the `MagickPingImage' call. (Bug#10112)
1627
90ec88df
CY
16282011-11-23 Chong Yidong <cyd@gnu.org>
1629
1630 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1631
56e2e794
MR
16322011-11-23 Martin Rudalics <rudalics@gmx.at>
1633
1634 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1635 making another buffer current. (Bug#10114)
1636
b6e64c41
GM
16372011-11-23 Glenn Morris <rgm@gnu.org>
1638
1639 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1640
6b21de18
CY
16412011-11-23 Chong Yidong <cyd@gnu.org>
1642
1643 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1644 using it (Bug#5984).
1645
b12cd789
EZ
16462011-11-22 Eli Zaretskii <eliz@gnu.org>
1647
1648 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1649 and header-lines, as they don't have one computed for them.
1650 (Bug#10098)
1651
1652 * .gdbinit (prow): Make displayed values more self-explaining.
1653 Add row's hash code.
1654
261b6fd4
LMI
16552011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1656
1657 * process.c (wait_reading_process_output): Fix asynchrounous
1658 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1659 (wait_reading_process_output): Add comment and URL.
261b6fd4 1660
e7cfd277
JD
16612011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1662
1663 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1664
a9b9b7f5
CY
16652011-11-21 Chong Yidong <cyd@gnu.org>
1666
1667 * window.c (Fnext_window, Fprevious_window): Doc fix.
1668
b0d15b4f
SM
16692011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1670
1671 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1672
fe7a3057
JB
16732011-11-20 Juanma Barranquero <lekktu@gmail.com>
1674
1675 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1676
d2999b1a
MR
16772011-11-20 Martin Rudalics <rudalics@gmx.at>
1678
1679 * window.c (Fset_window_combination_limit): Rename argument
1680 STATUS to LIMIT.
1681 (Vwindow_combination_limit): Remove "status" from doc-string.
1682
d5ff9cd0
AS
16832011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1684
1685 * m/ibms390.h: Remove.
1686 * m/ibms390x.h: Don't include "ibms390.h".
1687
a5bb9bd3
SM
16882011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1689
1690 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1691 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1692
cd1181db
JB
16932011-11-20 Juanma Barranquero <lekktu@gmail.com>
1694
1695 * casetab.c (Fset_case_table):
1696 * charset.c (Fcharset_after): Fix typos.
1697
615a3b8d 16982011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1699
17e845af
PE
1700 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1701 Otherwise, valgrind does not work on some platforms.
1702 Problem reported by Andreas Schwab in
6a0bf43d
PE
1703 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1704 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1705 is set, removing the need for VIRT_ADDRESS_VARIES.
1706 (PURE_P): Use a more-efficient implementation that needs just one
1707 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1708 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1709 to 4 (xorl, subq, cmpq, setbe).
1710 * alloc.c (pure): Always extern now, since that's the
1711 VIRT_ADDR_VARIES behavior.
1712 (PURE_POINTER_P): Use a single comparison, not two, for
1713 consistency with the new puresize.h.
1714 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1715 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1716 Remove VIRT_ADDR_VARIES no longer needed.
1717
f8fe6f96
EZ
17182011-11-19 Eli Zaretskii <eliz@gnu.org>
1719
1720 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1721 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1722 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1723 behave as if the cursor position were at the window margin.
1724
1725 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1726 and the cursor position is out of bounds, behave as if the cursor
1727 position were at the window margin. (Bug#10075)
1728
df05a53c
CY
17292011-11-18 Chong Yidong <cyd@gnu.org>
1730
1731 * window.c (Fwindow_combination_limit): Make first argument
1732 non-optional, since it is meaningless for live windows like the
1733 selected window.
1734
2071918e
DA
17352011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1736
1737 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1738
b50a28de
SM
17392011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1740
1741 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1742 (graft_intervals_into_buffer): Simplify.
1743
015137db
EZ
17442011-11-18 Eli Zaretskii <eliz@gnu.org>
1745
1746 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1747 hash values of the two rows.
1748 (copy_row_except_pointers): Preserve the used[] arrays and the
1749 hash values of the two rows. (Bug#10035)
68c95424 1750 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1751
1752 * xdisp.c (row_hash): New function, body extracted from
1753 compute_line_metrics.
1754 (compute_line_metrics): Call row_hash, instead of computing the
1755 hash code inline.
1756
1757 * dispnew.c (verify_row_hash): Call row_hash for computing the
1758 hash code of a row, instead of duplicating code from xdisp.c.
1759
1760 * dispextern.h (row_hash): Add prototype.
1761
a2addb04
TH
17622011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1763
1764 * frame.c (delete_frame): Don't delete the terminal when the last
1765 X frame is closed if emacs is built with GTK toolkit.
1766
df85d315
JB
17672011-11-17 Juanma Barranquero <lekktu@gmail.com>
1768
1769 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1770
a0c2d0ae
MR
17712011-11-17 Martin Rudalics <rudalics@gmx.at>
1772
1773 * window.c (Vwindow_splits): Rename to
1774 Vwindow_combination_resize. Suggested by Juri Linkov.
1775 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1776 of Vwindow_splits.
1777
58179cce
JB
17782011-11-16 Juanma Barranquero <lekktu@gmail.com>
1779
7877f373
JB
1780 * nsfns.m (Fns_font_name):
1781 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1782
b6f67890
MR
17832011-11-16 Martin Rudalics <rudalics@gmx.at>
1784
1785 * window.h (window): Rename slot "nest" to "combination_limit".
1786 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1787 (Fset_window_nest): Rename to Fset_window_combination_limit.
1788 (Vwindow_nest): Rename to Vwindow_combination_limit.
1789 (recombine_windows, make_parent_window, make_window)
1790 (Fsplit_window_internal, saved_window)
1791 (Fset_window_configuration, save_window_save): Rename all
1792 occurrences of window_nest to window_combination_limit.
1793
c7015153
JB
17942011-11-15 Juanma Barranquero <lekktu@gmail.com>
1795
1796 * image.c (imagemagick_load_image): Fix typo.
1797
322ad6ec
EZ
17982011-11-14 Eli Zaretskii <eliz@gnu.org>
1799
1800 * xdisp.c (display_line): Move the call to
1801 highlight_trailing_whitespace before the call to
1802 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1803 faces of all the glyphs to compute ROW's hash value.
1804 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1805
f067b8ec
JB
18062011-11-14 Juanma Barranquero <lekktu@gmail.com>
1807
1808 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1809 just return (bug#10044).
1810
1e5b2111
EZ
18112011-11-12 Eli Zaretskii <eliz@gnu.org>
1812
7ef3cbd5
EZ
1813 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1814 with user-defined heap size. Bump the default size of the temacs
1815 heap to 27MB, to avoid memory warning when running temacs.
1816 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1817
1e5b2111
EZ
1818 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1819 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1820 (verify_row_hash) [XASSERTS]: New function.
1821 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1822 that the hash value of glyph rows is correct.
1e5b2111 1823
89d61221
MR
18242011-11-12 Martin Rudalics <rudalics@gmx.at>
1825
1826 * window.h (window): Remove splits slot.
1827 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1828 (Fdelete_other_windows_internal, make_parent_window)
1829 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1830 (Fset_window_configuration, save_window_save): Don't deal with
1831 split status of windows.
1832 (saved_window): Remove splits slot.
1833 (Vwindow_splits): Rewrite doc-string.
1834
97f18cc8
JD
18352011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1836
1837 * xfns.c (unwind_create_frame):
1838 * nsfns.m (unwind_create_frame):
1839 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1840 Vframe_list (Bug#9999).
1841
22a648b4
DA
18422011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1843
0b381c7e 1844 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1845
659afede
KH
18462011-11-11 Kenichi Handa <handa@m17n.org>
1847
1848 * callproc.c (Fcall_process): Set the member dst_multibyte of
1849 process_coding.
1850
9ac0394b
KH
18512011-11-11 Johan Bockgård <bojohan@gnu.org>
1852
1853 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1854 avoid a crash (bug#9496).
1855
2fbdc249
CY
18562011-11-09 Chong Yidong <cyd@gnu.org>
1857
1858 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1859 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1860
ac6b1f81
PE
18612011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1862
1863 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1864
09db192c
PE
18652011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 Avoid some portability problems by eschewing 'extern inline' functions.
1868 The trivial performance wins aren't worth the portability hassles; see
1869 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1870 et seq.
1871 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1872 (window_box_width, window_box_left, window_box_left_offset)
1873 (window_box_right, window_box_right_offset): Undo previous change,
1874 by removing the "extern"s.
1875 * intervals.c (adjust_intervals_for_insertion)
1876 (adjust_intervals_for_deletion): Undo previous change,
1877 making these static again.
1878 (offset_intervals, temp_set_point_both, temp_set_point)
1879 (copy_intervals_to_string): No longer inline.
1880 * xdisp.c (window_text_bottom_y, window_box_width)
1881 (window_box_height, window_box_left_offset)
1882 (window_box_right_offset, window_box_left, window_box_right)
1883 (window_box): No longer inline.
1884
105216ed
CY
18852011-11-08 Chong Yidong <cyd@gnu.org>
1886
1887 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1888 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1889 Signal an error if not a live window.
105216ed
CY
1890 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1891 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1892
ae9e237f
JB
18932011-11-07 Juanma Barranquero <lekktu@gmail.com>
1894
1895 * lisp.h (syms_of_abbrev): Remove declaration.
1896 Reported by CHENG Gao <chenggao@royau.me>.
1897
c7aa8333
EZ
18982011-11-07 Eli Zaretskii <eliz@gnu.org>
1899
1900 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1901 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1902 of temacs in GUI mode.
1903
be7f5545
MR
19042011-11-07 Martin Rudalics <rudalics@gmx.at>
1905
1906 * window.h: Declare delete_all_child_windows instead of
1907 delete_all_subwindows.
1908 * window.c (Fwindow_nest, Fset_window_nest)
1909 (Fset_window_new_total, Fset_window_new_normal)
1910 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1911 (delete_all_subwindows): Rename to delete_all_child_windows.
1912 (Fdelete_other_windows_internal, Fset_window_configuration):
1913 Call delete_all_child_windows instead of delete_all_subwindows.
1914 * frame.c (delete_frame): Call delete_all_child_windows instead
1915 of delete_all_subwindows.
1916
ca78dc43
PE
19172011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1918
1919 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1920 This is also needed for porting to any host where GC_MARK_STACK is
1921 not GC_MAKE_GCPROS_NOOPS.
1922 (which_symbols): Use it.
1923
a0241d01
KH
19242011-11-07 Kenichi Handa <handa@m17n.org>
1925
1926 * coding.c (coding_set_destination): Check coding->src_pos only
1927 when coding->src_object is a buffer (bug#9910).
1928
1929 * process.c (send_process): Set the member src_multibyte of coding
1930 to 0 (bug#9911) when sending a unibyte text.
1931
1932 * callproc.c (Fcall_process): Set the member src_multibyte of
1933 process_coding to 0 (bug#9912).
1934
a64bfdfa 19352011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1936
1937 * xmenu.c (cleanup_widget_value_tree): New function.
1938 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1939 calling free_menubar_widget_value_tree directly (Bug#9830).
1940
cb41b32a
PE
19412011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1942
1943 Fix some portability problems with 'inline'.
1944 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1945 (window_box_width, window_box_left, window_box_left_offset)
1946 (window_box_right, window_box_right_offset): Declare extern.
1947 Otherwise, these inline functions do not conform to C99 and
1948 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1949 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1950 * intervals.c (adjust_intervals_for_insertion)
1951 (adjust_intervals_for_deletion): Now extern, because otherwise the
1952 extern inline functions 'offset_intervals' couldn't refer to it.
1953 (static_offset_intervals): Remove.
1954 (offset_intervals): Rewrite using the old contents of
1955 static_offset_intervals. The old version didn't conform to C99
1956 because an extern inline function contained a reference to an
1957 identifier with static linkage.
1958
b7041366
AS
19592011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1960
1961 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1962 GC.
1963
88a37c4d
EZ
19642011-11-06 Eli Zaretskii <eliz@gnu.org>
1965
1966 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1967 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1968 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1969 return Qleft_to_right.
1970
49745b39
CY
19712011-11-06 Chong Yidong <cyd@gnu.org>
1972
1973 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1974 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1975 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1976 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1977 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1978 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1979 (Fwindow_vscroll): Doc fix.
1980 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1981 argument, since it makes no sense to pass a live window and for
1982 consistency with window-child.
1983
1f05cd82
CS
19842011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1985
1986 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1987 support MSVC.
1988
22610910
JR
19892011-11-05 Jason Rumney <jasonr@gnu.org>
1990
1991 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1992 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1993 fonts (Bug#6029).
1994 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1995 bitwise arithmetic preventing use of unicode-sip and non-truetype
1996 opentype fonts.
1997
a06776b2
EZ
19982011-11-05 Eli Zaretskii <eliz@gnu.org>
1999
3ad924ba
EZ
2000 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2001 "emacs"-only part.
2002
a06776b2
EZ
2003 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2004 initialization code to keep similarity to xfns.c after changes
2005 from 2011-11-05.
2006
c9e7db78
JD
20072011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2008
a97f8f3f
JD
2009 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2010 (unwind_create_frame): New function (Bug#9943).
2011 (Fx_create_frame): Restructure code to be more similar to the one in
2012 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2013 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2014 Move terminal->reference_count++ just before making the frame official
2015 (Bug#9943).
2016
2017 * nsterm.m (x_free_frame_resources): New function.
2018 (x_destroy_window): Move code to x_free_frame_resources.
2019
c9e7db78 2020 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
2021 (Fx_create_frame, x_create_tip_frame):
2022 Move terminal->reference_count++ just before making the frame
75f1671a 2023 official. Move initialization of image_cache_refcount and
c9e7db78
JD
2024 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2025
a6fc3b5c
EZ
20262011-11-05 Eli Zaretskii <eliz@gnu.org>
2027
2028 Support MSVC build with newer versions of Visual Studio.
2029 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2030 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2031 nt/gmake.defs.
2032
2033 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2034 which are not supported by MSVC.
2035 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2036 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2037 bitfields.
2038 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2039 types in bitfields.
2040 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2041
2042 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2043
58179cce 20442011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
2045
2046 Support MSVC build with newer versions of Visual Studio.
2047 * w32.c: Don't include w32api.h for MSVC.
2048 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2049
2050 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2051 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2052 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2053 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2054 e_* cousins.
2055 (alloca) [_MSC_VER]: Define to _alloca.
2056
2057 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2058
2059 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2060
a58c13ed
EZ
20612011-11-04 Eli Zaretskii <eliz@gnu.org>
2062
2063 * xdisp.c (note_mouse_highlight): If either of
2064 previous/next-single-property-change returns nil, treat that as
2065 the beginning or the end of the buffer. (Bug#9955)
2066
fe0b6370
JD
20672011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2068
a58c13ed 2069 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
2070 label is not null (Bug#9951).
2071 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2072 may be NULL.
2073
89bd5ee1
EZ
20742011-11-04 Eli Zaretskii <eliz@gnu.org>
2075
2076 * window.c (Fwindow_body_size): Mention in the doc string that the
2077 return value is in frame's canonical units. (Bug#9949)
2078
84c3edb9
EZ
20792011-11-03 Eli Zaretskii <eliz@gnu.org>
2080
4e2fb5c7
EZ
2081 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2082
84c3edb9 2083 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 2084 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 2085 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 2086
bc17a887
EZ
20872011-11-01 Eli Zaretskii <eliz@gnu.org>
2088
2089 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2090 Don't stop backward scan on the continuation glyph, even though
2091 its CHARPOS is positive.
6d5eb5b0
SM
2092 (mouse_face_from_buffer_pos, note_mouse_highlight):
2093 Rename cover_string to disp_string.
bc17a887 2094
4ee88440
MR
20952011-11-01 Martin Rudalics <rudalics@gmx.at>
2096
2097 * window.c (temp_output_buffer_show): Don't use
2098 Vtemp_buffer_show_specifiers.
2099 (Vtemp_buffer_show_specifiers): Remove unused variable.
2100
c2ff3c02
EZ
21012011-10-30 Eli Zaretskii <eliz@gnu.org>
2102
2103 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2104 past the beginning of the current glyph matrix.
2105
58179cce 21062011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
2107
2108 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2109 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2110 HAVE_GTK3 (Bug#9869).
b77a6a7f 2111
3b574623
JD
2112 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2113 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2114
b77a6a7f
JD
2115 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2116
2117 * xterm.c: Declare x_handle_net_wm_state to return int.
2118 (handle_one_xevent): Check if we are iconified but don't have
2119 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2120 (get_current_wm_state): Return non-zero if not hidden,
2121 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2122 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2123 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2124 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2125
196e41e4
PE
21262011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2127
2128 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2129 so that this new function doesn't get optimized away by a
2130 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2131
021f2e1a
AS
21322011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2133
2134 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2135
8b058d44
EZ
21362011-10-29 Eli Zaretskii <eliz@gnu.org>
2137
2138 Fix the `xbytecode' command.
2139 * .gdbinit (xprintbytestr): New command.
b50a28de 2140 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
2141 (xbytecode): Print the byte-code string as well.
2142
4452fb80
EZ
21432011-10-29 Kim Storm <storm@cua.dk>
2144
8b058d44
EZ
2145 * alloc.c (which_symbols): New function.
2146
21b72067
AS
21472011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2148
2149 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2150 line. (Bug#9903)
2151
83ed7b5c
GM
21522011-10-29 Glenn Morris <rgm@gnu.org>
2153
2154 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2155 Not clear what it was for, and it causes various bugs. (Bug#9839)
2156
5a7a728b
EZ
21572011-10-28 Eli Zaretskii <eliz@gnu.org>
2158
2159 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2160 possible random value that matches one of those tested as
2161 condition to clear the mouse face.
2162
d3d0842f
CY
21632011-10-28 Chong Yidong <cyd@gnu.org>
2164
2165 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2166
31b39d13
DN
21672011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2168
2169 * window.c (make_window): Initialize phys_cursor_on_p.
2170
9aba6043
SM
21712011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2172
2173 * lisp.h (struct Lisp_Symbol): Update comments.
2174
c20992f4
JB
21752011-10-28 Juanma Barranquero <lekktu@gmail.com>
2176
2177 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2178
db4f02f2
EZ
21792011-10-28 Eli Zaretskii <eliz@gnu.org>
2180
2181 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2182 <oslsachem@gmail.com> for helping to debug this.
2183
2184 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2185 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2186 (g_b_init_get_glyph_outline_w): New static variables.
2187 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2188 (GetGlyphOutlineW_Proc): New typedefs.
2189 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2190 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2191 New functions.
2192 (w32font_open_internal, compute_metrics):
2193 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2194 instead of calling the "wide" APIs directly.
2195
2196 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2197
2198 * w32.h (syms_of_w32font): Add prototype.
2199
87e68db4
JB
22002011-10-27 Juanma Barranquero <lekktu@gmail.com>
2201
2202 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2203 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2204 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2205 (Fmove_to_window_line): Doc fix.
2206
435c1d67
CY
22072011-10-27 Chong Yidong <cyd@gnu.org>
2208
2209 * process.c (make_process): Set gnutls_state to NULL.
2210
2211 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2212 non-NULL, regardless of GNUTLS_INITSTAGE.
2213 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2214 an error. Set process slots as soon as we allocate them.
2215
2216 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2217
9c6c6f49
CY
22182011-10-27 Chong Yidong <cyd@gnu.org>
2219
9aba6043
SM
2220 * gnutls.c (emacs_gnutls_deinit): New function.
2221 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2222 (Fgnutls_deinit, Fgnutls_boot): Use it.
2223
2224 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2225 (deactivate_process): Call emacs_gnutls_deinit.
2226
657d08d3
JB
22272011-10-27 Juanma Barranquero <lekktu@gmail.com>
2228
2229 * image.c (x_create_x_image_and_pixmap):
2230 * w32.c (sys_rename, w32_delayed_load):
2231 * w32font.c (fill_in_logfont):
2232 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2233
5430d399
JB
22342011-10-26 Juanma Barranquero <lekktu@gmail.com>
2235
2236 * w32fns.c (w32_default_color_map): New function,
2237 extracted from Fw32_default_color_map.
a7ef684b 2238 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2239
fe0055fa
PE
22402011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2241
2242 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2243
e6346438
SM
22442011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2245
2246 * keyboard.c (test_undefined): New function (bug#9751).
2247 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2248
e112cc37
ET
22492011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2250
2251 * sysdep.c (init_sys_modes): Fix the check for the controlling
2252 terminal (Bug#6649).
2253
7b5d6677
EZ
22542011-10-20 Eli Zaretskii <eliz@gnu.org>
2255
2256 * dispextern.h (struct bidi_it): New member next_en_type.
2257
2258 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2259 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2260 current character, check also for next_en_type being WEAK_EN.
2261 (bidi_resolve_weak): Don't enter the expensive loop if the current
2262 position is before next_en_pos. Record the bidi type of the first
2263 non-ET, non-BN character we find, in addition to its position.
2264 (bidi_level_of_next_char): Invalidate next_en_type when
2265 next_en_pos is over-stepped.
2266
7da0b018
PE
22672011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2268
2269 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2270 * editfns.c: Rewrite current-time-zone so that it invokes
2271 the equivalent of (format-time-string "%Z") to get the time zone name.
2272 This fixes a bug when the time zone name contains characters that
2273 need converting from the system time locale to Emacs internal format.
2274 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2275 that patch fixed format-time-string to do the conversion, but
2276 I forgot to fix current-time-zone.
2277 (format_time_string): New function, containing most of
2278 what Fformat_time_string used to contain.
2279 (Fformat_time_string): Rewrite in terms of format_time_string.
2280 This doesn't change this function's behavior.
2281 (current-time-zone): Rewrite to use format_time_string.
2282 This fixes the bug reported by Michael Schierl in
2283 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2284 Jason Rumney's 2007-06-07 change worked around this bug, but
2285 didn't fix it.
2286 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2287
8547b010
EZ
22882011-10-19 Eli Zaretskii <eliz@gnu.org>
2289
2290 * xdisp.c (start_display): If the character at POS is displayed
2291 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2292 (try_window_reusing_current_matrix): If a line ends in a display
2293 vector or the next line starts in a display vector, continue
2294 redrawing the window even though the character position of
2295 start_row was reached.
8547b010
EZ
2296 (Bug#9771, part 2)
2297
4e948d15
CY
22982011-10-18 Chong Yidong <cyd@gnu.org>
2299
2300 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2301 with nobreak-char-display too.
2302
4787455f
EZ
23032011-10-18 Eli Zaretskii <eliz@gnu.org>
2304
2305 Fix part 3 of bug#9771.
2306 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2307 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2308 non-neutral characters if the current character is a paragraph
2309 separator (a.k.a. Newline). This avoids running the same
2310 expensive loop twice, once when we consume the preceding newline
2311 and the other time when the line actually needs to be displayed.
2312 Avoid the loop when we see neutrals on the base embedding level
2313 following a character whose directionality is the same as the
2314 paragraph's. This avoids running the expensive loop when a line
2315 ends in a long sequence of neutrals, like control characters.
2316 Add assertion against STRONG_AL type. Slightly rearrange code
2317 that determines the type of a neutral given the first non-neutral
2318 that follows it.
2319 (bidi_level_of_next_char): Set next_en_pos to zero when
2320 invalidating its info.
2321
2c91f553
EZ
23222011-10-17 Eli Zaretskii <eliz@gnu.org>
2323
2324 * xdisp.c (push_display_prop): Determine whether to record string
2325 or buffer position by IT->string, not by IT->method. Allow
2326 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2327 (move_it_vertically_backward): Don't look for character position
2328 immediately after the newline when in a continuation line.
2329 (Bug#9771, part 1)
2c91f553 2330
c7b08b0d
MR
23312011-10-15 Martin Rudalics <rudalics@gmx.at>
2332
2333 * window.c (coordinates_in_window): Rewrite and delabelize
2334 vertical border check. (Bug#5357) (Bug#9618)
2335
6b02f655
SM
23362011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2337
2338 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2339 errors in XSetWindowBorder (bug#9310).
2340
81d40c92
DA
23412011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2342
2343 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2344 avoid crash when xmalloc overrun checking is enabled.
2345
d4172c3b
EZ
23462011-10-13 Eli Zaretskii <eliz@gnu.org>
2347
2348 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2349 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2350 cursor motion with <left> and <right> arrow keys.
2351
2352 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2353 some callers set that themselves.
2354
b00eea75
EZ
23552011-10-12 Eli Zaretskii <eliz@gnu.org>
2356
2357 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2358 display string and the previous row comes from the same string and
2359 is empty. (Bug#9739) (Bug#9738)
2360
8fe012c4
SM
23612011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2362
2363 * doc.c (get_doc_string): Encode file name (bug#9735).
2364
0074aef2
EZ
23652011-10-12 Eli Zaretskii <eliz@gnu.org>
2366
79beb178
EZ
2367 * bidi.c (bidi_level_of_next_char):
2368 * xdisp.c (get_visually_first_element): Remove old incorrect
2369 comments regarding the Unicode Line Separator character.
2370
0074aef2
EZ
2371 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2372
6e4b3fbe
DA
23732011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2374
2375 * alloc.c (Fgc_status): Do not access beyond zombies array
2376 boundary if nzombies > MAX_ZOMBIES.
2377 * alloc.c (dump_zombies): Add missing format specifier.
2378
0324f3af
PE
23792011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2380
b5525cac
PE
2381 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2382 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2383
0324f3af
PE
2384 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2385 Some packages use them to denote characters with modifiers.
2386
e9b5f888
AS
23872011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2388
2389 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2390 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2391 matching a pp-number. Rename parameter var to var1.
2392
127827c0
SM
23932011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2394
2395 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2396
c8fd3bd0
GM
23972011-10-08 Glenn Morris <rgm@gnu.org>
2398
2399 * callint.c (Fcall_interactively): Give a more explicit error for the
2400 'c' case with a non-character input. (Bug#8479)
2401
352ec8ff
EZ
24022011-10-08 Eli Zaretskii <eliz@gnu.org>
2403
03669ccb
EZ
2404 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2405 lines.
7061c986
EZ
2406 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2407 lines that are hscrolled on the left.
03669ccb 2408
352ec8ff
EZ
2409 * dispnew.c (buffer_posn_from_coords): Account for a possible
2410 presence of header-line. (Bug#4426)
2411
a66cfb1c
SM
24122011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2413
6b02f655
SM
2414 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2415 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2416
7c5ee88e
PE
24172011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2418
2419 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2420 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2421 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2422 this makes Emacs dump core during garbage collection on rare
2423 occasions. sizeof is obviously inferior to offsetof here, so
2424 stick with offsetof.
2425 (GC_POINTER_ALIGNMENT): New macro.
2426 (mark_memory): Omit 3rd (offset) arg; caller changed.
2427 Don't assume EMACS_INT alignment is the same as pointer alignment.
2428
df1bbe5b
SM
24292011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2430
2431 * keyboard.c (read_key_sequence_remapped): New var.
2432 (read_key_sequence): Compute remapping in the right buffer.
2433 (command_loop_1): Use read_key_sequence's remapping directly.
2434
51553db6
SM
24352011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2436
32c1fffd
SM
2437 * dired.c (file_name_completion): Don't expand file name.
2438 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2439 before checking file name handler.
2440
51553db6
SM
2441 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2442 they've been requested explicitly (bug#9591).
2443
b6bd1599 24442011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2445
2446 * keymap.c (Fsingle_key_description): Use make_specified_string
2447 instead of build_string to build string from push_key_description.
2448 (Bug#5193)
2449
f701dc2a
PE
24502011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2451
4222c55d
PE
2452 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2453 This fixes a Y2038 bug on 64-bit hosts.
2454 * buffer.c (reset_buffer):
2455 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2456 (Fclear_buffer_auto_save_failure):
2457 Use 0, not -1, to represent an unset failure time, since time_t
2458 might not be signed.
2459
f701dc2a
PE
2460 Remove dependency on glibc malloc internals.
2461 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2462 Move back here from lisp.h, but with their new implementations.
2463 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2464 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2465 * charset.c (charset_table_init): New static var.
2466 (syms_of_charset): Use it instead of xmalloc. This removes a
2467 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2468 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2469 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2470 Move back to alloc.c.
2471 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2472 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2473
9ceebf39
JD
24742011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2475
2476 * nsterm.m (windowDidResize): Call x_set_window_size only when
2477 ns_in_resize is true. Otherwise set pixelwidth/height and
2478 call change_frame_size (Bug#9628).
2479
cb993c58
PE
24802011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2481
3930c88b
PE
2482 Port --enable-checking=all to Fedora 14 x86-64.
2483 * charset.c (syms_of_charset): Also account for glibc malloc's
2484 internal overhead when calculating the initial malloc maximum.
2485
cb993c58
PE
2486 Port --enable-checking=all to Fedora 14 x86.
2487 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2488 Move to lisp.h.
2489 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2490 (overrun_check_realloc, overrun_check_free):
2491 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2492 That way, xmalloc returns a properly-aligned pointer even if
2493 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2494 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2495 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2496 into account when calculating the initial malloc maximum.
2497 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2498 Move here from alloc.c, so that charset.c can use it too.
2499 Properly align; the old code wasn't right for common 32-bit hosts
2500 when configured with --enable-checking=all.
2501 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2502 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2503
31bed486
EZ
25042011-09-29 Eli Zaretskii <eliz@gnu.org>
2505
04c70788 2506 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2507 use EDOM.
2508
fbcaa2f3
EZ
25092011-09-28 Eli Zaretskii <eliz@gnu.org>
2510
2511 * xdisp.c (compute_display_string_end): If there's no display
2512 string at CHARPOS, return -1.
2513
2514 * bidi.c (bidi_fetch_char): When compute_display_string_end
2515 returns a negative value, treat the character as a normal
2516 character not covered by a display string. (Bug#9624)
2517
a239d4e9
JB
25182011-09-28 Juanma Barranquero <lekktu@gmail.com>
2519
2520 * lread.c (Fread_from_string): Fix typo in docstring.
2521
88652fd5
EZ
25222011-09-27 Eli Zaretskii <eliz@gnu.org>
2523
2524 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2525 newline, reseat the iterator instead of bidi-iterating there one
2526 character at a time. (Bug#9610)
32c1fffd
SM
2527 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2528 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2529
ed497dd4
AS
25302011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2531
2532 * lread.c (readevalloop): Use correct code for NBSP.
2533 (read1): Likewise. (Bug#9608)
2534
b2bf61aa
MA
25352011-09-25 Michael Albinus <michael.albinus@gmx.de>
2536
2537 * dbusbind.c (Fdbus_register_signal): When service is not
2538 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2539
32bbb17c
GM
25402011-09-25 Glenn Morris <rgm@gnu.org>
2541
2542 * buffer.c (truncate-lines): Doc fix.
2543
94e0933e
CY
25442011-09-24 Chong Yidong <cyd@stupidchicken.com>
2545
2546 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2547 (Fset_window_next_buffers): Doc fix.
2548
cddde921
GM
25492011-09-24 Glenn Morris <rgm@gnu.org>
2550
2551 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2552
1260aef1
PE
25532011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2554
25b4bfa0
PE
2555 Fix minor problems found by static checking.
2556 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2557 * indent.c (Fvertical_motion): Fix == vs = typo.
2558
e3cbd34b
EZ
25592011-09-24 Eli Zaretskii <eliz@gnu.org>
2560
a66cfb1c
SM
2561 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2562 Default value is now t. Doc fix.
6bf7006f 2563
e3cbd34b 2564 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2565 logic when moving up, not only when moving down. Fix the
e3cbd34b 2566 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2567 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2568
2569 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2570 CHARPOS is covered by a display string which includes newlines.
2571 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2572 is covered by a display string with embedded newlines.
2573
a3de0cbd
MA
25742011-09-24 Michael Albinus <michael.albinus@gmx.de>
2575
2576 * dbusbind.c (Fdbus_register_signal): Add match rule to
2577 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2578 (Fdbus_register_method, Vdbus_registered_objects_table):
2579 Fix docstring.
a3de0cbd 2580
b260039d
JM
25812011-09-24 Jim Meyering <meyering@redhat.com>
2582
32c1fffd 2583 do not ignore write error for any output size
b260039d
JM
2584 The previous change was incomplete.
2585 While it makes emacs --batch detect the vast majority of stdout
2586 write failures, errors were still ignored whenever the output size is
2587 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2588 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2589 && echo FAIL: ignored write error
2590 FAIL: ignored write error
2591 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2592 && echo FAIL: ignored write error
2593 FAIL: ignored write error
2594 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2595
8eca8a7c
AS
25962011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2597
2598 * emacs.c (Fkill_emacs): In noninteractive mode exit
2599 non-successfully if a write error occurred on stdout. (Bug#9574)
2600
3341db62
EZ
26012011-09-21 Eli Zaretskii <eliz@gnu.org>
2602
2603 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2604 the xassert test.
2605
2606 * dispextern.h (struct it): Update the comment documenting what
2607 can it->OBJECT be.
2608
8c203dbf
EZ
26092011-09-20 Eli Zaretskii <eliz@gnu.org>
2610
2611 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2612 a display string, extend search for cursor position to end of row.
2613 (find_row_edges): If the row ends in a newline from a display
2614 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2615 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2616 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2617 non-empty line. Fixes confusing cursor motion with arrow keys at
2618 the beginning of a line that starts with whitespace.
8c203dbf 2619
a4824228
LMI
26202011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2621
2622 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2623 (bug#9493).
2624
33ed493b
CY
26252011-09-18 Chong Yidong <cyd@stupidchicken.com>
2626
2627 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2628 boolean (Bug#9154).
2629
56cd55c8
EZ
26302011-09-18 Eli Zaretskii <eliz@gnu.org>
2631
2632 * xdisp.c (display_line): Record maximum and minimum buffer
2633 positions even if no glyphs were produced (e.g., by a zero-width
2634 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2635 buffer positions that will be removed from the glyph row because
2636 they don't fit.
c02dcedf
EZ
2637 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2638 column is beyond frame width: don't subtract 1 "pixel" when
2639 computing width of the stretch.
3e62b7e0
EZ
2640 (reseat_at_next_visible_line_start): Undo the change made on
2641 2011-09-17 that saved paragraph information and restored it after
2642 the call to `reseat'. (Bug#9545)
56cd55c8 2643
5ed99d36 26442011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2645
2646 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2647 and turn window cursor on if cleared (Bug#9415).
2648
5ed99d36 26492011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2650
2651 * search.c (boyer_moore): Take unibyte characters from pattern
2652 literally. (Bug#9458)
2653
9bade7b2
EZ
26542011-09-18 Eli Zaretskii <eliz@gnu.org>
2655
2656 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2657
e5e9d610
PE
26582011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2659
87e4427a
PE
2660 Fix minor problem found by static checking.
2661 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2662 initialized, to pacify gcc -Wuninitialized.
2663
e5e9d610
PE
2664 * fileio.c: Report proper errno when syscall falls.
2665 (Finsert_file_contents): Save and restore errno,
2666 so that report_file_error outputs the correct diagnostic.
2667 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2668
a1674f0b
EZ
26692011-09-18 Eli Zaretskii <eliz@gnu.org>
2670
2671 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2672
fbfb6dd4
EZ
26732011-09-17 Eli Zaretskii <eliz@gnu.org>
2674
2675 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2676 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2677
bb187662
EZ
26782011-09-17 Eli Zaretskii <eliz@gnu.org>
2679
1137e8b8 2680 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2681 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2682
2683 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2684 (bidi_find_paragraph_start): Search back for paragraph beginning
2685 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2686 (bidi_move_to_visually_next): Only trigger paragraph-related
2687 computations when the last character is a newline or at EOB, not
2688 just any NEUTRAL_B. (Bug#9470)
2689
bb187662
EZ
2690 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2691 truncated lines if point is covered by a display string. (Bug#9524)
2692
2e621251
PE
26932011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2694
2695 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2696 (cons_to_x_long): New function.
2697 (lisp_data_to_selection_data): Use it. Correct the test for
2698 short-versus-long data; it was negated. Break out of vector
2699 loop, for efficiency, when a long datum is discovered.
2700
91a15bc6
SM
27012011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2702
2703 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2704
b41c3a35
EZ
27052011-09-16 Eli Zaretskii <eliz@gnu.org>
2706
2707 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2708 GCC PR/17406) by declaring this function with external scope.
2709
7812ba2d
PE
27102011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2711
2712 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2713 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2714
cf7edc2a
AS
27152011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2716
2717 * editfns.c (Fformat): Correctly handle text properties on "%%".
2718
bd01620e
EZ
27192011-09-15 Eli Zaretskii <eliz@gnu.org>
2720
2721 * xterm.c (x_draw_composite_glyph_string_foreground):
2722 * w32term.c (x_draw_composite_glyph_string_foreground):
2723 * term.c (encode_terminal_code):
2724 * composite.c (composition_update_it, get_composition_id):
2725 * xdisp.c (get_next_display_element)
2726 (fill_composite_glyph_string): Add comments about special meaning
2727 of TAB characters in a composition.
2728
a02719a3
PE
27292011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2730
2731 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2732 This occurs when processing a multibyte format.
2733 Problem reported by Wolfgang Jenker.
a02719a3 2734
72589a3c
JB
27352011-09-15 Johan Bockgård <bojohan@gnu.org>
2736
2737 * xdisp.c (try_cursor_movement): Only check for exact match if
2738 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2739
1c14176c
PE
27402011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2741
2742 Remove unused external symbols.
2743 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2744 * xdisp.c (calc_pixel_width_or_height): Now static.
2745 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2746 * indent.c (check_display_width):
2747 * w32term.c: Fix comment to match code.
2748 * xterm.c, xterm.h (x_catching_errors): Remove.
2749
d2eea5b5
PE
27502011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2751
2752 * xselect.c: Use signed conversions more consistently (Bug#9498).
2753 (selection_data_to_lisp_data): Assume incoming selection data are
2754 signed integers, not unsigned. This is to be consistent with
2755 outgoing selection data, which was modified to use signed integers
2756 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2757 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2758 expects long, not unsigned long.
2759
46888499
EZ
27602011-09-14 Eli Zaretskii <eliz@gnu.org>
2761
2762 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2763 computation of loop end. Reported by Johan Bockgård
2764 <bojohan@gnu.org>.
2765
ef8ef9fb
CY
27662011-09-13 Chong Yidong <cyd@stupidchicken.com>
2767
2768 * frame.c (Fother_visible_frames_p): Function deleted.
2769
fa819fed
EZ
27702011-09-12 Eli Zaretskii <eliz@gnu.org>
2771
2772 * indent.c (compute_motion): Process display vector front to back
2773 rather than the other way around. (Bug#2496)
2774
2ba8e008
SM
27752011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2776
2777 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2778
20f53c69
CY
27792011-09-11 Chong Yidong <cyd@stupidchicken.com>
2780
2781 * minibuf.c (Fread_from_minibuffer): Doc fix.
2782
d562d7a4
EZ
27832011-09-11 Eli Zaretskii <eliz@gnu.org>
2784
2785 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2786 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2787
1c4d7f3d
LMI
27882011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2789
2790 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2791 value for non-existent files.
2792
b885bf36
EZ
27932011-09-11 Eli Zaretskii <eliz@gnu.org>
2794
2795 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2796 set its "size" to -1. This will set the modtime_size field of
2797 the corresponding buffer to -1, which is what
2798 verify-visited-file-modtime expects for files that do not exist.
2799 (Bug#9139)
2800
6612f0bf
PE
28012011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2802
2803 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2804 here ...
2805 * lisp.h: ... from here. push_key_description is no longer
2806 defined in keyboard.c, so its declaration should not be in
2807 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2808 logically belongs with push_key_description.
2809
dfb3f755
PE
28102011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2811
2812 * buffer.h: Include <sys/types.h> instead of <time.h>.
2813 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2814 Problem reported by Herbert J. Skuhra.
2815
3134906c
LMI
28162011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2817
2818 * xml.c (parse_region): Make the parsing work for
2819 non-comment-starting XML files again (bug#9144).
2820
8d903f4e
AS
28212011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2822
2823 * image.c (gif_load): Fix calculation of bottom and right corner.
2824 (Bug#9468)
2825
80ad64f4
EZ
28262011-09-10 Eli Zaretskii <eliz@gnu.org>
2827
2828 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2829 redisplay in small windows.
2830
208a048d
EZ
28312011-09-09 Eli Zaretskii <eliz@gnu.org>
2832
2833 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2834
9b1c252e
MR
28352011-09-08 Martin Rudalics <rudalics@gmx.at>
2836
2837 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2838 Operate on live windows only.
2839
2949f33b
JB
28402011-09-08 Juanma Barranquero <lekktu@gmail.com>
2841
2842 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2843
e08dcafd
EZ
28442011-09-07 Eli Zaretskii <eliz@gnu.org>
2845
2846 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2847 only under bidi iteration.
2848
115b96bd
JD
28492011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2850
2851 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2852
c8199d0f
PE
28532011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2854
2855 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2856 Without this fix, the command to link temacs failed due to an
2857 undefined symbol __builtin_isnan. This is because
2858 /usr/include/iso/math_c99.h #defines isnan(x) to
2859 __builtin_isnan(x), but the bundled gcc, which identifies itself
2860 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2861 a __builtin_isnan.
2862 * floatfns.c (isnan): #undef, and then #define to a clone of
2863 what's in data.c.
2864 (Fisnan): Always define, since it's always available now.
2865 (syms_of_floatfns): Always define isnan at the Lisp level.
2866
e39b275c 28672011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2868
2869 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2870
b2db44d9 28712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2872
f4af5137 2873 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2874 The previous code assumed that file offsets (off_t values) fit in
2875 EMACS_INT variables, which is not true on typical 32-bit hosts.
2876 The code messed up by falsely reporting buffer overflow in cases
2877 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2878 when "big" contains more than 2**29 bytes, even though this
2879 inserts just one byte and does not overflow the buffer.
2880 (Finsert_file_contents): Store file offsets as off_t
2881 values, not as EMACS_INT values. Check for overflow when
2882 converting between EMACS_INT and off_t. When checking for
2883 buffer overflow or for overlap, take the offsets into account.
2884 Don't use EMACS_INT for small values where int suffices.
2885 When checking for overlap, fix a typo: ZV was used where
2886 ZV_BYTE was intended.
2887 (Fwrite_region): Don't assume off_t fits into 'long'.
2888 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2889
ecfc0a49
MA
28902011-09-05 Michael Albinus <michael.albinus@gmx.de>
2891
2892 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2893
6511acf2 28942011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2895
0999621a 2896 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2897
2898 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2899 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2900 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2901 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2902 (modify_event_symbol): Do not assume that the length of
2903 name_alist_or_stem is safe to alloca and fits in int.
2904 (Fexecute_extended_command): Likewise for function name and binding.
2905 (Frecursion_depth): Wrap around reliably on integer overflow.
2906 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2907 since some callers pass EMACS_INT values.
2908 (Fsingle_key_description): Don't crash if symbol name contains more
2909 than MAX_ALLOCA bytes.
2910 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2911 (get_minibuffer): Arg is now EMACS_INT, not int.
2912 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2913 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2914 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2915
2be7d702
PE
2916 * dbusbind.c (signature_cat): New function.
2917 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2918 Do not overrun buffer; instead, report string overflow.
2919
9d1df220
PE
2920 * dispnew.c (add_window_display_history): Don't overrun buffer.
2921 Truncate instead; this is OK since it's just a log.
2922
33ef5c64
PE
2923 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2924 even if the time zone offset is outlandishly large.
2925 Don't mishandle offset == INT_MIN.
2926
66c6fdd5
PE
2927 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2928 when creating daemon; the previous buffer-overflow check was incorrect.
2929
d749b01b
PE
2930 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2931 which has the guts of the old verror function.
2932
b5cd1905
PE
2933 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2934 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2935
6e1a67fb
PE
2936 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2937 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2938 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2939 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2940 length of string rather than counting it via multiple sprintfs;
2941 that's simpler and more reliable.
c21721cc
PE
2942 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2943 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2944 sprintf, in case result does not fit in int.
2945
c57b67fc
PE
2946 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2947 (fontset_from_font): Print it.
2948
8a401434
PE
2949 * frame.c (tty_frame_count): Now printmax_t, not int.
2950 (make_terminal_frame, set_term_frame_name): Print it.
2951 (x_report_frame_params): In X, window IDs are unsigned long,
2952 not signed long, so print them as unsigned.
2953 (validate_x_resource_name): Check for implausibly long names,
2954 and don't assume name length fits in 'int'.
2955 (x_get_resource_string): Don't blindly alloca invocation name;
2956 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2957 not fit in int.
2958
6e1a67fb
PE
2959 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2960 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2961 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2962
0df02bf3
PE
2963 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2964 Use esprintf, not sprintf, in case result does not fit in int.
2965
48e30793
PE
2966 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2967 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2968 it as a large positive number.
2969 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2970 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2971
a66ff6d8
PE
2972 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2973 in case result does not fit in int.
2974
aca216ff
PE
2975 * print.c (float_to_string): Detect width overflow more reliably.
2976 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2977 buffer overrun. Don't assume list length fits in 'int'. Treat
2978 print length of 0 as 0, not as infinity; to be consistent with other
2979 uses of print length in this function. Don't overflow print length
2980 index. Don't assume hash table size fits in 'long', or that
2981 vectorlike size fits in 'unsigned long'.
2982
31c286f7
PE
2983 * process.c (make_process): Use printmax_t, not int, to format
2984 process-name gensyms.
2985
55e5faa1
PE
2986 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2987
80f2e268
PE
2988 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2989 to avoid potential buffer overrun.
2990
670741ab
PE
2991 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2992 if X resource line is longer than 512 bytes.
2993
b7163a50
PE
2994 * xfns.c (x_window): Make sprintf buffer a bit bigger
2995 to avoid potential buffer overrun.
2996
ae58ff1f
PE
2997 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2998
c43c8a6a
PE
2999 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3000
3f8236f4
PE
30012011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3002
53e9fe90 3003 Integer overflow fixes for scrolling, etc.
6511acf2
PE
3004 Without these, Emacs silently mishandles large integers sometimes.
3005 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
3006 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3007
6511acf2
PE
3008 * xdisp.c (try_window_id): Check Emacs fixnum range before
3009 converting to 'int'.
806add1d 3010
6511acf2 3011 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
3012 Check that an Emacs fixnum is in range before assigning it to 'int'.
3013 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3014 values converted from Emacs fixnums.
3015 (Frecenter): Don't wrap around a line count if it is out of 'int'
3016 range; instead, treat it as an extreme value.
3017 (Fset_window_configuration, compare_window_configurations):
3018 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3019
6511acf2
PE
3020 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3021 that can exceed INT_MAX. Check that EMACS_INT value is in range
3022 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
3023 (match_limit): Don't assume that a fixnum can fit in 'int'.
3024
6511acf2 3025 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
3026 exceed INT_MAX.
3027
6511acf2 3028 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
3029 (Fvertical_motion): Don't wrap around LINES values that don't fit
3030 in 'int'. Instead, treat them as extreme values. This is good
3031 enough for windows, which can't have more than INT_MAX lines anyway.
3032
fcb901a7
LMI
30332011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3034
0f2f6b6d
LMI
3035 * Require libxml/parser.h to avoid compilation warning.
3036
fcb901a7
LMI
3037 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3038
3039 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3040 since this reportedly can destroy thread storage.
3041
6e20a0d4
CY
30422011-08-30 Chong Yidong <cyd@stupidchicken.com>
3043
3044 * syntax.c (find_defun_start): Update all cache variables if
3045 exiting early (Bug#9401).
3046
148ae00e
EZ
30472011-08-30 Eli Zaretskii <eliz@gnu.org>
3048
f6cfbd8f
EZ
3049 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3050
148ae00e
EZ
3051 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3052 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3053 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3054
3055 * term.c (tty_append_glyph): New function.
3056 (produce_stretch_glyph): Static function and its prototype deleted.
3057
a66cfb1c
SM
3058 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3059 Add prototypes.
148ae00e 3060
c4a07a4c
PE
30612011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3062
3063 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3064 when checking :margin (Bug#9390).
3065 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 3066 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
3067 so that the name doesn't mislead. All uses changed.
3068
6bc8cd65
JB
30692011-08-28 Johan Bockgård <bojohan@gnu.org>
3070
3071 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3072 set_tty_hooks.
3073
dca4927e
EZ
30742011-08-27 Eli Zaretskii <eliz@gnu.org>
3075
3076 * xdisp.c (move_it_to): Don't bail out early when reaching
3077 position beyond to_charpos, if we are scanning backwards.
3078 (move_it_vertically_backward): When DY == 0, make sure we get to
3079 the first character in the line after the newline.
3080
f2cad773
PE
30812011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3084 (ccl_driver): Do not generate an out-of-range pointer.
3085 (Fccl_execute_on_string): Remove unnecessary check for
3086 integer overflow, noted by Stefan Monnier in
3087 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3088 Remove a FIXME that didn't need fixing.
3089 Simplify the newly-introduced buffer reallocation code.
3090
0cae2cdb
JB
30912011-08-27 Juanma Barranquero <lekktu@gmail.com>
3092
3093 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3094
5fc295a4 30952011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 3096
70c60eb2 3097 Integer and memory overflow issues (Bug#9196).
726e0ab1 3098
d31850da
PE
3099 * doc.c (get_doc_string): Rework so that
3100 get_doc_string_buffer_size is the actual buffer size, rather than
3101 being 1 less than the actual buffer size; this makes xpalloc more
3102 convenient.
3103
a69fbedb
PE
3104 * image.c (x_allocate_bitmap_record, cache_image):
3105 * xselect.c (Fx_register_dnd_atom):
3106 Simplify previous changes by using xpalloc.
3107
fe5c5d37
PE
3108 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3109 since either will do and ptrdiff_t is convenient with xpalloc.
3110
0065d054
PE
3111 * charset.c (charset_table_size)
3112 (struct charset_sort_data.priority): Now ptrdiff_t.
3113 (charset_compare): Don't overflow if priorities differ greatly.
3114 (Fsort_charsets): Don't assume list length fits in int.
3115 Check for size-calculation overflow when allocating sort data.
3116 (syms_of_charset): Allocate an initial charset table that is
3117 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3118
3119 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3120
3121 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3122 The actual value is always <= INT_MAX, and leaving it unsigned made
3123 overflow checking harder.
3124
3125 * dispextern.h (struct glyph_matrix.rows_allocated)
3126 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3127 with xpalloc. The values are still always <= INT_MAX.
3128
3129 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3130
3131 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3132 (SAFE_NALLOCA): New macro.
3133
3134 * region-cache.c (struct boundary.pos, find_cache_boundary)
3135 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3136 (set_cache_region, invalidate_region_cache)
3137 (revalidate_region_cache, know_region_cache, region_cache_forward)
3138 (region_cache_backward, pp_cache):
3139 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3140 so that ptrdiff_t * can be passed to xpalloc.
3141 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3142 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3143 (pp_cache): Don't assume cache_len fits in int.
3144 * region-cache.h: Adjust extern decls to match.
3145
3146 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3147 EMACS_INT, since either will do, for xpalloc.
3148
3149 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3150 (xnmalloc, xnrealloc, xpalloc): New functions.
3151
726e0ab1
PE
3152 * bidi.c (bidi_shelve_header_size): New constant.
3153 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3154 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3155
51f30bc5 3156 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
3157 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3158 (overlay_strings):
3159 Don't update size of array until after memory allocation succeeds,
3160 because xmalloc/xrealloc may not return.
0065d054
PE
3161 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3162 now that we have proper integer overflow checking.
3163 (record_overlay_string, overlay_strings): Catch overflows when
3164 calculating size of overlay_str_buf.
726e0ab1 3165
0065d054
PE
3166 * callproc.c (Fcall_process): Check for size overflow when
3167 calculating size of args2.
3168 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3169 Normally we prefer signed values, but sticking with ptrdiff_t would
3170 require adding more-complicated checks.
726e0ab1
PE
3171
3172 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3173 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3174 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3175 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3176
3177 * character.c (Fstring): Check for size-calculation overflow.
3178
3179 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3180 unnecessary integer overflow. Check for size overflow.
3181 (encode_coding_object): Don't update size until xmalloc succeeds.
3182
3183 * composite.c (get_composition_id): Check for overflow in glyph
3184 length calculations.
3185
3186 Integer and memory overflow fixes for display code.
3187 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3188 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3189 (scrolling_window): Check for overflow in size calculations.
3190 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3191 Don't assume glyph table len fits in int.
3192 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3193 (row_table_size): Now ptrdiff_t, not int.
3194 (scrolling_window): Avoid overflow in size calculations.
3195 Don't update size until allocation succeeds.
3196 * fns.c (concat): Check for overflow in size calculations.
3197 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3198 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3199 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3200
3201 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3202 (get_doc_string): Check for size calculation overflow.
3203 Don't update size until allocation succeeds.
3204 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3205 EMACS_INT, where ptrdiff_t will do.
3206 (Fsubstitute_command_keys): Check for string overflow.
3207
3208 * editfns.c (set_time_zone_rule): Don't assume environment length
3209 fits in int.
3210 (message_length): Now ptrdiff_t, not int.
3211 (Fmessage_box): Don't update size until allocation succeeds.
3212 Don't assume message length fits in int.
3213 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3214
0065d054
PE
3215 * emacs.c (main): Do not reallocate argv, since there is a null at
3216 the end that can be overwritten, and this way there's no need to
3217 worry about size-calculation overflow.
3218 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3219
3220 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3221 alloc succeeds.
3222 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3223
3224 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3225 (x_set_scroll_bar_width, x_figure_window_size):
3226 Check for integer overflow.
3227 (x_set_alpha): Do not assume XINT fits in int.
3228
3229 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3230 This is for the members text_lines, text_cols, total_lines, total_cols,
3231 where the system imposes an 'int' limit.
3232
3233 * fringe.c (Fdefine_fringe_bitmap):
3234 Don't update size until alloc works.
3235
3236 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3237 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3238
3239 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3240 Check for size-calculation overflow.
3241 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3242 do, as we prefer signed integers.
3243 (id_to_widget.max_size, id_to_widget.used)
3244 (xg_store_widget_in_map, xg_remove_widget_from_map)
3245 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3246 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3247 Use and return ptrdiff_t, not int.
3248 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3249 * gtkutil.h: Change prototypes to match the above.
3250
3251 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3252 are duplicate now that they've been promoted to lisp.h.
3253 (x_allocate_bitmap_record, x_alloc_image_color)
3254 (make_image_cache, cache_image, xpm_load):
3255 Don't update size until alloc is done.
3256 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3257 (x_detect_edges):
3256efce 3258 Check for size calculation overflow.
726e0ab1
PE
3259 (ct_colors_allocated_max): New constant.
3260 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3261 overflow.
3256efce 3262
726e0ab1
PE
3263 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3264 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3265 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3266 Use ptrdiff_t, not int, to count maps.
3267 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3268 calculations. Don't update size until allocation succeeds.
3269 Redo calculations to avoid overflow.
726e0ab1
PE
3270 * keyboard.h: Change prototypes to match the above.
3271
3272 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3273 to count maps.
3274 (current_minor_maps): Check for size calculation overflow.
3275 * keymap.h: Change prototypes to match the above.
3276
3277 * lread.c (read1, init_obarray): Don't update size until alloc done.
3278
3279 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3280 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3281
726e0ab1
PE
3282 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3283 Now ptrdiff_t, not int.
3284 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3285 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3286
3287 * process.c (Fnetwork_interface_list): Check for overflow
3288 in size calculation.
3289
3290 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3291
3292 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3293 overflow. Don't bother calling xmalloc when xrealloc will do.
3294
3295 * search.c (Freplace_match): Check for size calculation overflow.
3296 (Fset_match_data): Don't assume list lengths fit in 'int'.
3297
3298 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3299 for command line length. Do not attempt to address one before the
3300 beginning of an array, as that's not portable.
3301
3302 * term.c (max_frame_lines): Remove; unused.
3303 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3304 not int.
3305 (encode_terminal_code, calculate_costs): Check for size
3306 calculation overflow.
3307 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3308 table lengths and related sizes. Don't update size until alloc
3309 done. Redo calculations to avoid overflow.
3310 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3311
3312 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3313 subtracting pointers.
3314 (gobble_line): Check for overflow more carefully. Don't update size
3315 until alloc done.
3316
3317 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3318 Don't update size until alloc done.
3319 Redo size calculations to avoid overflow.
3320 Check for size calculation overflow.
0065d054 3321 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3322
3323 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3324 Use ptrdiff_t, not int, for sizes.
3325 (store_mode_line_noprop_char): Don't update size until alloc done.
3326
0065d054
PE
3327 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3328 Use ptrdiff_t, not int, for sizes.
3329 (Finternal_make_lisp_face, cache_face):
3330 Check for size calculation overflow.
3331 (cache_face): Treat size calculation overflows as if they were
3332 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3333
3334 * xfns.c (x_encode_text, x_set_name_internal)
3335 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3336 sizes, since they can exceed INT_MAX in size. Check for size
3337 calculation overflow.
3338
0065d054
PE
3339 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3340 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3341 Don't update size until alloc done.
3342
0065d054 3343 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3344 as sprintf is limited to int lengths.
1d526e2f 3345
252c5ee1
PE
3346 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3347 (X_LONG_MIN): New macros.
864d7ce7
PE
3348 Use them to make the following changes clearer.
3349 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3350 This change doesn't affect the value now, but it may help remind
3351 future maintainers not to raise the value too much later.
3352 (SELECTION_QUANTUM): Remove, replacing with ...
3353 (selection_quantum): ... new function, which avoids overflow.
3354 All uses changed.
3355 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3356 assumption that selection length fits in 'int'.
3357 (x_reply_selection_request, x_handle_selection_request)
3358 (x_get_window_property, receive_incremental_selection)
3359 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3360 (lisp_data_to_selection_data, clean_local_selection_data):
3361 Use ptrdiff_t, not int, to record length of selection.
3362 (x_reply_selection_request, x_get_window_property)
3363 (receive_incremental_selection, x_property_data_to_lisp):
3364 Redo calculations to avoid overflow.
3365 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3366 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3367 something.
3368 (x_get_window_property, receive_incremental_selection)
3369 (lisp_data_to_selection_data, x_property_data_to_lisp):
3370 Check for size-calculation overflow.
3371 (x_get_window_property, receive_incremental_selection)
3372 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3373 Don't store size until memory allocation succeeds.
3374 (x_get_window_property): Plug memory leak on memory exhaustion.
3375 Don't double-block input; malloc is safe here. Don't assume 2**34
3376 - 4 fits in unsigned long. Add an xassert to check
3377 XGetWindowProperty overflow. Be more careful about overflow
3378 calculations, and distinguish size from memory overflow better.
3379 (receive_incremental_selection): When tracing, don't assume
3380 unsigned int is less than INT_MAX.
3381 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3382 harmful) conversions of unsigned short to int.
3383 (lisp_data_to_selection_data): Don't assume that integers
3384 in the range -65535 through -1 fit in an X unsigned short.
3385 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3386 result parameters unless successful. Rely on cons_to_unsigned
3387 to report problems with elements; the old code wasn't right anyway.
3388 (x_check_property_data): Check for int overflow; we cannot use
3389 a wider type due to X limits.
3390 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3391
726e0ab1 3392 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3393
0065d054
PE
3394 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3395 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3396 (x_color_cells): Don't store size until memory allocation succeeds.
3397 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3398 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3399 (x_term_init): Don't assume length fits in int (sprintf is limited
3400 to int size).
bc18e09d 3401
ebfa62c0
PE
3402 Use ptrdiff_t for composition IDs.
3403 * character.c (lisp_string_width):
3404 * composite.c (composition_table_size, n_compositions)
3405 (get_composition_id, composition_gstring_from_id):
3406 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3407 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3408 * window.c (Frecenter):
3409 Use ptrdiff_t, not int, for composition IDs.
3410 * composite.c (get_composition_id): Check for integer overflow.
3411 * composite.h: Adjust prototypes to match the above changes.
3412
d3411f89
PE
3413 Use ptrdiff_t for hash table indexes.
3414 * category.c (hash_get_category_set):
3415 * ccl.c (ccl_driver):
3416 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3417 * coding.c (coding_system_charset_list, detect_coding_system):
3418 * coding.h (struct coding_system.id):
3419 * composite.c (get_composition_id, gstring_lookup_cache):
3420 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3421 * image.c (xpm_get_color_table_h):
3422 * lisp.h (hash_lookup, hash_put):
3423 * minibuf.c (Ftest_completion):
3424 Use ptrdiff_t for hash table indexes, not int (which is too
3425 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3426 32-bit --with-wide-int hosts).
3427
e097a6fa
PE
3428 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3429 Add a FIXME comment about memory leaks.
3430 (syms_of_charset): Don't assume xmalloc returns.
3431
5637687f
PE
3432 Don't assume that stated character widths fit in int.
3433 * character.c (Fchar_width, c_string_width, lisp_string_width):
3434 * character.h (CHAR_WIDTH):
3435 * indent.c (MULTIBYTE_BYTES_WIDTH):
3436 Use sanitize_char_width to avoid undefined and/or bad behavior
3437 with outlandish widths.
a66cfb1c 3438 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3439 now that we have two such functions. All uses changed.
3440 (sanitize_char_width): New inline function.
3441
a2271ba2
PE
3442 Don't assume that tab-width fits in int.
3443 * character.h (sanitize_width): New inline function.
3444 (SANE_TAB_WIDTH): New macro.
3445 (ASCII_CHAR_WIDTH): Use it.
3446 * indent.c (sane_tab_width): Remove. All uses replaced by
3447 SANE_TAB_WIDTH (current_buffer).
3448 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3449
18c52557
PE
3450 * fileio.c: Integer overflow issues with file modes.
3451 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3452
caeeedc1
PE
3453 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3454 Remove unreachable code.
3455 (read_hex, load_charset_map_from_file): Check for integer overflow.
3456
6df6ae42 3457 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3458 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3459 (x_send_scroll_bar_event): Likewise. Check that the size does not
3460 exceed limits imposed by XClientMessageEvent, as well as the usual
3461 ptrdiff_t and size_t limits.
3462
b13995db
PE
3463 * keyboard.c: Overflow, signedness and related fixes.
3464 (make_lispy_movement): Use same integer type in forward decl
3465 that is used in the definition.
3466 (read_key_sequence, keyremap_step):
3467 Change bufsize argument back to int, undoing my 2011-03-30 change.
3468 We prefer signed types, and int is wide enough here.
3469 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3470 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3471 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3472 length, not size_t. Use ptrdiff_t for index, not int.
3473 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3474 possibility of integer overflow.
3475
13464394
PE
3476 Overflow, signedness and related fixes for images.
3477
3478 * dispextern.h (struct it.stack[0].u.image.image_id)
3479 (struct_it.image_id, struct image.id, struct image_cache.size)
3480 (struct image_cache.used, struct image_cache.ref_count):
3481 * gtkutil.c (update_frame_tool_bar):
3482 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3483 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3484 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3485 * nsmenu.m (update_frame_tool_bar):
3486 * xdisp.c (calc_pixel_width_or_height):
3487 * xfns.c (image_cache_refcount):
3488 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3489 on typical 64-bit hosts.
3490
3491 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3492 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3493 Omit unnecessary casts to int.
3494 (parse_image_spec): Check that integers fall into 'int' range
3495 when the callers expect that.
3496 (image_ascent): Redo ascent calculation to avoid int overflow.
3497 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3498 (lookup_image): Remove unnecessary tests.
3499 (xbm_image_p): Locals are now of int, not EMACS_INT,
3500 since parse_image_check makes sure they fit into int.
3501 (png_load, gif_load, svg_load_image):
3502 Prefer int to unsigned where either will do.
3503 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3504 old tiff_error_handler and tiff_warning_handler.
3505 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3506 stack buffer overflows. It uses only the features of vsnprintf
3507 that are common to both POSIX and native Microsoft.
3508 (tiff_error_handler, tiff_warning_handler): Use it.
3509 (tiff_load, gif_load, imagemagick_load_image):
3510 Don't assume :index value fits in 'int'.
3511 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3512 (imagemagick_load_image): Check that crop parameters fit into
3513 the integer types that MagickCropImage accepts. Don't assume
3514 Vimagemagick_render_type has a nonnegative value. Don't assume
3515 size_t fits in 'long'.
3516 (gs_load): Use printmax_t to print the widest integers possible.
3517 Check for integer overflow when computing image height and width.
3518
c11821d4
EZ
35192011-08-26 Eli Zaretskii <eliz@gnu.org>
3520
3521 * xdisp.c (redisplay_window): Don't force window start if point
3522 will be invisible in the resulting window. (Bug#9324)
3523
0c95fcf7
EZ
35242011-08-25 Eli Zaretskii <eliz@gnu.org>
3525
3526 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3527 the display spec is of the form `(space ...)'.
3528 (handle_display_spec): Return the value returned by
3529 handle_single_display_spec, not just 1 or zero.
3530 (handle_single_display_spec): If the display spec is of the form
3531 `(space ...)', and specifies display in the text area, return 2
3532 rather than 1.
fee65a97 3533 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3534 accurately, and prefer exact match for point under bidi.
3535 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3536
3537 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3538 into disp_prop; all users changed.
3539
3540 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3541 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3542 for the text covered by the display property.
3543
e4ed06f1
CY
35442011-08-25 Chong Yidong <cyd@stupidchicken.com>
3545
3546 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3547 Change return value to nil.
3548 (Frecord_buffer): Delete unused function.
3549
f67cdd7f
EZ
35502011-08-24 Eli Zaretskii <eliz@gnu.org>
3551
5980d4c6
EZ
3552 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3553 buffers, return left-to-right.
8610fe8b
EZ
3554 (set_cursor_from_row): Consider candidate row a win if its glyph
3555 represents a newline and point is on that newline. Fixes cursor
3556 positioning on the newline at EOL of R2L text within L2R
3557 paragraph, and vice versa.
3558 (try_cursor_movement): Check continued rows, in addition to
3559 continuation rows. Fixes unwarranted scroll when point enters a
3560 continued line of R2L text within an L2R paragraph, or vice versa.
3561 (cursor_row_p): Consider the case of point being equal to
3562 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3563 from the end of a short line to the beginning of a continued line
3564 of R2L text within L2R paragraph.
3565 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3566 composed characters.
5980d4c6 3567
f67cdd7f
EZ
3568 * bidi.c (bidi_check_type): Use xassert.
3569 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3570 members.
3571
bca633fb
EZ
35722011-08-23 Eli Zaretskii <eliz@gnu.org>
3573
3574 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3575 a character.
3576
4a5885a7
CY
35772011-08-23 Chong Yidong <cyd@stupidchicken.com>
3578
3579 * nsfont.m (ns_otf_to_script): Fix typo.
3580
0902a04e
KH
35812011-08-22 Kenichi Handa <handa@m17n.org>
3582
3583 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3584 extra slot even if the purpose is char-code-property-table.
3585
1a2e6670
EZ
35862011-08-23 Eli Zaretskii <eliz@gnu.org>
3587
8ddde651
EZ
3588 * xdisp.c (redisplay_window): When computing centering_position,
3589 account for the height of the header line. (Bug#8874)
3590
425cc014
EZ
3591 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3592 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3593 candidate is selected by the mouse, and that candidate has a
3594 composed character under the mouse.
3595
1a2e6670
EZ
3596 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3597 coordinates reported by pos-visible-in-window-p for a composed
3598 character in column zero.
3599
8b76d6f8
SM
36002011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3601
3602 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3603
dac347dd
EZ
36042011-08-22 Eli Zaretskii <eliz@gnu.org>
3605
3606 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3607 consider it a hit if to_charpos is anywhere in the range of the
3608 composed buffer positions.
3609
e013fb34
CY
36102011-08-22 Chong Yidong <cyd@stupidchicken.com>
3611
3612 * image.c (gif_load): Don't assume that each subimage has the same
3613 dimensions as the base image. Handle disposal method that is
3614 "undefined" by the gif spec (Bug#9335).
3615
bd1ba3e8
CY
36162011-08-20 Chong Yidong <cyd@stupidchicken.com>
3617
3618 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3619 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3620
54a1215b
EZ
36212011-08-19 Eli Zaretskii <eliz@gnu.org>
3622
823564e5
EZ
3623 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3624 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3625 from an Org mode buffer to a Speedbar frame.
3626
54a1215b
EZ
3627 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3628 a composition, take its buffer position from IT->cmp_it.charpos.
3629 Fixes cursor positioning at the beginning of a line that begins
3630 with a composed character.
3631
9778ebcc
EZ
36322011-08-18 Eli Zaretskii <eliz@gnu.org>
3633
0be6ee06
EZ
3634 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3635 character bidirectional type, use STRONG_L instead. Fixes crashes
3636 in a buffer produced by `describe-categories'.
3637
9778ebcc
EZ
3638 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3639 members before the level stack, so they would be saved and
3640 restored when copying iterator state. Fixes incorrect reordering
3641 around TABs covered by display properties.
3642
156bffbe
AS
36432011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3644
6b02f655 3645 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3646
72ad093b
CY
36472011-08-17 Chong Yidong <cyd@stupidchicken.com>
3648
3649 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3650 (internal_condition_case_2, internal_condition_case_n):
3651 Remove unnecessary aborts (Bug#9081).
72ad093b 3652
35774242
EZ
36532011-08-17 Eli Zaretskii <eliz@gnu.org>
3654
3655 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3656 has no `load' handler, try opening the file locally. (Bug#9311)
3657
db76dd85
KB
36582011-08-16 Ken Brown <kbrown@cornell.edu>
3659
3660 * gmalloc.c: Expand comment.
3661
b215eee5
EZ
36622011-08-16 Eli Zaretskii <eliz@gnu.org>
3663
3664 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3665 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3666
a4579d33
KB
36672011-08-16 Ken Brown <kbrown@cornell.edu>
3668
3669 Fix memory allocation problems in Cygwin build (Bug#9273).
3670
3671 * unexcw.c ( __malloc_initialized): Declare external variable.
3672 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3673
8b76d6f8
SM
3674 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3675 New variables.
a4579d33
KB
3676 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3677 dumped emacs.
3678 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3679 in the static heap.
3680 [CYGWIN] (special_realloc): New function.
3681 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3682 requests to realloc storage in the static heap.
3683
3ebec551
PE
36842011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3685
3686 * bidi.c (bidi_initialize): Remove unused local.
3687
9fd8be00
EZ
36882011-08-15 Eli Zaretskii <eliz@gnu.org>
3689
6b02f655
SM
3690 * bidimirror.h:
3691 * biditype.h: Remove file.
3692 * makefile.w32-in ($(BLD)/bidi.$(O)):
3693 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3694
3695 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3696
3697 * chartab.c: Improve commentary for the uniprop_table API.
3698
32413314
EZ
3699 * bidi.c (bidi_paragraph_init): Support zero value of
3700 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3701 (bidi_initialize): Use uniprop_table instead of including
3702 biditype.h and bidimirror.h.
32413314 3703
9fd8be00
EZ
3704 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3705 coordinates of the iterator when restoring from ppos_it.
3706 (Bug#9296)
3707
5cf2b69b
KH
37082011-08-14 Kenichi Handa <handa@m17n.org>
3709
3710 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3711 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3712
daf17d00
EZ
37132011-08-14 Eli Zaretskii <eliz@gnu.org>
3714
3715 * xdisp.c (move_it_in_display_line_to): Don't invoke
3716 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3717 ppos_it. Fixes vertical cursor motion when line beginning is
3718 covered by an image. (Bug#9296)
3719
08e3161a
JD
37202011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3721
3722 * nsterm.h (ns_run_ascript): Declare.
3723 (NSAPP_DATA2_RUNASSCRIPT): Define.
3724
3725 * nsfns.m (as_script, as_result, as_status): New static variables.
3726 (ns_run_ascript): New function.
5e617bc2 3727 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3728 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3729 the event loop. Get status from as_status (Bug#7276).
3730
3731 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3732 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3733 the event loop (Bug#7276).
3734
a3720aa2
AS
37352011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3736
3737 * gnutls.c (QCgnutls_bootprop_priority)
3738 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3739 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3740 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3741 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3742 (QCgnutls_bootprop_verify_hostname_error)
3743 (QCgnutls_bootprop_callbacks_verify): Rename from
3744 Qgnutls_bootprop_..., all uses changed.
3745
3746 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3747 uses changed.
3748
0a0d27fb
PE
37492011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3750
19d5c50c
PE
3751 * xfaces.c (Qframe_set_background_mode): Now static.
3752 * dispextern.h (Qframe_set_background_mode): Remove decl.
3753
0a0d27fb
PE
3754 * process.c (Fnetwork_interface_info): Declare local only if needed.
3755
377538cb
JD
37562011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3757
3758 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3759 (Fnetwork_interface_list): Allocate in increments of bytes instead
3760 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3761 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3762 sockaddr.
3763 (struct ifflag_def): notrailers is smart on OSX.
3764 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3765 Get hardware address with getifaddrs if available.
3766
08fff70c
EZ
37672011-08-12 Eli Zaretskii <eliz@gnu.org>
3768
3769 * xdisp.c (iterate_out_of_display_property): xassert that
3770 IT->position is set to within IT->object's boundaries. Break from
3771 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3772 when IT->position is set up wrongly due to some bug.
3773 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3774 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3775 entry. Force push_it to save on the stack the current
3776 buffer/string position, to be restored by pop_it. Fix flags in
3777 the iterator structure wrt the object coming from a display
3778 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3779 properties. (Bug#9284)
3780
7be1c708 37812011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3782
7be1c708
CY
3783 * fontset.c (fontset_get_font_group): Add proper type checks.
3784 (Bug#9172)
aac0c6e3 3785
7be1c708 37862011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3787
7be1c708
CY
3788 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3789 and LC_VERSION_MIN_MACOSX.
3790 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3791 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3792
97bb72a6
EZ
37932011-08-08 Eli Zaretskii <eliz@gnu.org>
3794
3795 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3796 no-display-properties-and-no-overlays under bidi display.
3797 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3798 properties and overlays.
97bb72a6 3799
d5617611
CY
38002011-08-08 Chong Yidong <cyd@stupidchicken.com>
3801
37e11a63
CY
3802 * editfns.c (Fset_time_zone_rule): Document relationship with the
3803 setenv function.
3804
d5617611
CY
3805 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3806 the font entity extracted from the cache (Bug#8109).
3807
58872834
CY
38082011-08-07 Chong Yidong <cyd@stupidchicken.com>
3809
3810 * composite.c (autocmp_chars): Don't reset point. That is done by
3811 restore_point_unwind (Bug#5984).
3812
75bfc667
JL
38132011-08-07 Juri Linkov <juri@jurta.org>
3814
3815 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3816 to show the arg `TIME' instead of `TIMEVAL'.
3817
d1410150
EZ
38182011-08-06 Eli Zaretskii <eliz@gnu.org>
3819
3820 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3821 display property strides EOL and includes a newline, as in
3822 longlines-mode. (Bug#9254)
75b771e4
EZ
3823 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3824 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3825
3826 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3827 is non-zero, even if the data buffer is NULL. Fixes a crash in
3828 vertical-motion with longlines-mode. (Bug#9254)
3829
35928349
EZ
38302011-08-05 Eli Zaretskii <eliz@gnu.org>
3831
ec7cc85b
EZ
3832 * bidi.c <bidi_cache_total_alloc>: Now static.
3833 (bidi_initialize): Initialize bidi_cache_total_alloc.
3834
8b76d6f8 3835 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3836 cache. (Bug#9221)
3837
3838 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3839 amount allocated this far in `bidi_cache_total_alloc'.
3840 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3841 non-zero, only free the data buffer without restoring the cache
3842 contents. All callers changed.
3843
3844 * dispextern.h (bidi_unshelve_cache): Update prototype.
3845
3846 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3847 (move_it_in_display_line, move_it_to)
3848 (move_it_vertically_backward, move_it_by_lines): Replace the call
3849 to xfree to an equivalent call to bidi_unshelve_cache.
3850 (move_it_in_display_line_to): Fix logic of returning
412b6358 3851 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3852
e2e2423b
EZ
38532011-08-05 Eli Zaretskii <eliz@gnu.org>
3854
3855 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3856 came from a string character with a `cursor' property. (Bug#9229)
3857
ae9e757a
JD
38582011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3859
3860 * Makefile.in (LIB_PTHREAD): New variable.
3861 (LIBES): Add LIB_PTHREAD (Bug#9216).
3862
3863 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3864 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3865
213bd7f2
AS
38662011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3867
6b02f655 3868 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3869
99aaf75f
JD
38702011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3871
3872 * xterm.c (x_find_topmost_parent): New function.
3873 (x_set_frame_alpha): Find topmost parent window with
3874 x_find_topmost_parent and set the property there also (bug#9181).
3875 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3876
c74e9d86
PE
38772011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3878
3879 * callproc.c (Fcall_process): Avoid vfork clobbering
3880 the local vars buffer, coding_systems, current_dir.
3881
640c8776
SM
38822011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3883
3884 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3885
f26d0e4c
PE
38862011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3887
8a10d76c
PE
3888 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3889 so that it is not optimized away.
3890
f26d0e4c
PE
3891 * xdisp.c (compute_display_string_pos): Remove unused local.
3892
55439c61
EZ
38932011-08-02 Eli Zaretskii <eliz@gnu.org>
3894
3895 Fix slow cursor motion and scrolling in large buffers with
3896 selective display, like Org Mode buffers. (Bug#9218)
3897
3898 * dispextern.h (struct bidi_it): New member disp_prop_p.
3899
3900 * xdisp.c: Remove one-slot cache of display string positions.
3901 (compute_display_string_pos): Accept an additional argument
5e617bc2 3902 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3903 for a display string or property. If found, set DISP_PROP_P
3904 non-zero.
3905
3906 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3907 DISP_PROP_P, and pass it to compute_display_string_pos.
3908 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3909 non-zero. All callers of bidi_fetch_char changed.
3910
fb33fa43
SM
39112011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3912
3913 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3914
b099e063
DM
39152010-12-03 Don March <don@ohspite.net>
3916
3917 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3918 last character M-[char] is translated to ESC [char] (bug#7541).
3919
5cc7f7af
KH
39202011-08-02 Kenichi Handa <handa@m17n.org>
3921
d0fffa3f 3922 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3923
3924 * chartab.c (uniprop_table): Make it non-static.
3925
525d5e6e
EZ
39262011-08-01 Eli Zaretskii <eliz@gnu.org>
3927
3928 * xdisp.c (forward_to_next_line_start): Accept additional argument
3929 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3930 on the newline.
3931 (reseat_at_next_visible_line_start): Use the bidi iterator state
3932 returned by forward_to_next_line_start to restore the state of
3933 it->bidi_it after backing up to previous newline. (Bug#9212)
3934
31011111
AS
39352011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3936
3937 * regex.c (re_comp): Protoize.
3938 (re_exec): Fix return type.
3939 (regexec): Fix type of `ret'. (Bug#9203)
3940
476371c4
PE
39412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3942
e5d76069
PE
3943 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3944 This is needed if max-image-size is a floating-point number.
3945
9a79b20c
AS
39462011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3947
3948 * print.c (print_object): Print empty symbol as ##.
3949
3950 * lread.c (read1): Read ## as empty symbol.
3951
d8c2fa78
AA
39522011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3953
3954 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3955 setting frame foreground color (Bug#9175).
3956 (x_set_background_color): Likewise.
3957
ffe57a7a
AA
3958 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3959 contents (Bug#9176).
3960 (EmacsTooltip -init): Remove bezels and add shadows to
3961 tooltip windows.
3962
bf3492a5
AA
3963 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3964 or scroll bar (Bug#8470).
3965
d55e9c53
AA
3966 * nsfont.m (nsfont_open): Remove assignment to voffset and
3967 unnecessary vars hshink, expand, hd, full_height, min_height.
3968 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3969
3970 * nsterm.h (nsfont_info): Remove voffset field.
3971
d8c2fa78 39722011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3973
3974 Implement strike-through and overline on NextStep (Bug#8863).
3975
3976 * nsfont.m (nsfont_open): Use underline position provided by font,
3977 instead of hard-coded value of 2.
3978 (nsfont_draw): Call ns_draw_text_decoration instead.
3979
3980 * nsterm.h: Add declaration for ns_draw_text_decoration.
3981
3982 * nsterm.m (ns_draw_text_decoration): New function for drawing
3983 underline, overline, and strike-through.
3984 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3985 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3986 accommodate underlining, etc.
4843aac3 3987
4cc60b9b
EZ
39882011-07-28 Eli Zaretskii <eliz@gnu.org>
3989
bc7ece87
EZ
3990 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3991 default.
4cc60b9b 3992
476371c4
PE
39932011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3994
66606eea
PE
3995 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3996 Without this fix, if a signal arrives just after memory fills up,
3997 'malloc' might be invoked reentrantly.
3998
476371c4
PE
3999 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4000 In other words, assume that every image size is allowed, on non-X
4001 hosts. This assumption is probably wrong, but it lets Emacs compile.
4002
f3fcc40d
AS
40032011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4004
4005 * regex.c (re_iswctype): Convert return values to boolean.
4006
350c992f
EZ
40072011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4008
4009 * xdisp.c (compute_display_string_pos): Don't use cached display
4010 string position if the buffer had its restriction changed.
4011 (Bug#9184)
4012
5266b4bb
PE
40132011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4014
4015 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4016
2573a837 40172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 4018
41f55ccd 4019 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 4020
39e378da
PE
4021 * bidi.c: Integer size and overflow fixes.
4022 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4023 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4024 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4025 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4026 (bidi_find_other_level_edge):
4027 Use ptrdiff_t instead of EMACS_INT where either will do.
4028 This works better on 32-bit hosts configured --with-wide-int.
4029 (bidi_cache_ensure_space): Check for size-calculation overflow.
4030 Use % rather than repeated addition, for better worst-case speed.
4031 Don't set bidi_cache_size until after xrealloc returns, because it
4032 might not return.
4033 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
4034 (bidi_cache_ensure_space): Also check that the bidi cache size
4035 does not exceed that of the largest Lisp string or buffer. See Eli
4036 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 4037
5e927815
PE
4038 * alloc.c (__malloc_size_t): Remove.
4039 All uses replaced by size_t. See Andreas Schwab's note
4040 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4041
ca4aa935
PE
4042 * image.c: Improve checking for integer overflow.
4043 (check_image_size): Assume that f is nonnull, since
4044 it is always nonnull in practice. This is one less thing to
4045 worry about when checking for integer overflow later.
4046 (x_check_image_size): New function, which checks for integer
4047 overflow issues inside X.
4048 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4049 This removes the need for a memory_full check.
4050 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4051 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4052 (xbm_read_bitmap_data): Change locals back to 'int', since
4053 their values must fit in 'int'.
4054 (xpm_load_image, png_load, tiff_load):
4055 Invoke x_create_x_image_and_pixmap earlier,
4056 to avoid much needless work if the image is too large.
4057 (tiff_load): Treat overly large images as if
4058 x_create_x_image_and_pixmap failed, not as malloc failures.
4059 (gs_load): Use x_check_image_size.
4060
5f8f9cc2
PE
4061 * gtkutil.c: Omit integer casts.
4062 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4063 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4064
5adf60bc
PE
4065 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4066
c8907a93
PE
4067 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4068 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4069 would wrongly return t on a 64-bit host.
4070
e3c25c68
PE
4071 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4072 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4073 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4074 and therefore cause GCC to emit a bogus diagnostic in some cases.
4075
3f791afe
PE
4076 * image.c: Integer signedness and overflow and related fixes.
4077 This is not an exhaustive set of fixes, but it's time to
4078 record what I've got.
4079 (lookup_pixel_color, check_image_size): Remove redundant decls.
4080 (check_image_size): Don't assume that arbitrary EMACS_INT values
4081 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4082 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4083 (tiff_load, imagemagick_load_image):
4084 Check for overflow in size calculations.
4085 (x_create_x_image_and_pixmap): Remove unnecessary test for
4086 xmalloc returning NULL; that can't happen.
4087 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4088 (xpm_color_bucket): Use better integer hashing function.
4089 (xpm_cache_color): Don't possibly over-allocate memory.
4090 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4091 (gif_memory_source):
4092 Use ptrdiff_t, not int or size_t, to record sizes.
4093 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4094 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4095 either works, as we prefer signed integers.
4096 (tiff_read_from_memory, tiff_write_from_memory):
4097 Return tsize_t, not size_t, since that's what the TIFF API wants.
4098 (tiff_read_from_memory): Don't fail simply because the read would
4099 go past EOF; instead, return a short read.
4100 (tiff_load): Omit no-longer-needed casts.
4101 (Fimagemagick_types): Don't assume size fits into 'int'.
4102
3cc5a532
PE
4103 Improve hashing quality when configured --with-wide-int.
4104 * fns.c (hash_string): New function, taken from sxhash_string.
4105 Do not discard information about ASCII character case; this
4106 discarding is no longer needed.
4107 (sxhash-string): Use it. Change sig to match it. Caller changed.
4108 * lisp.h: Declare it.
4109 * lread.c (hash_string): Remove, since we now use fns.c's version.
4110 The fns.c version returns a wider integer if --with-wide-int is
4111 specified, so this should help the quality of the hashing a bit.
4112
b312a492
PE
4113 * emacs.c: Integer overflow minor fix.
4114 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4115 Define only if GNU_LINUX.
4116 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4117
dfd153ae
PE
4118 * dispnew.c: Integer signedness and overflow fixes.
4119 Remove unnecessary forward decls, that were a maintenance hassle.
4120 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4121 All uses changed.
4122 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4123 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4124 (prepare_desired_row, line_draw_cost):
4125 Use int, not unsigned, where either works.
4126 (save_current_matrix, restore_current_matrix):
4127 Use ptrdiff_t, not size_t, where either works.
4128 (init_display): Check for overflow more accurately, and without
4129 relying on undefined behavior.
4130
a81d11a3
PE
4131 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4132 Remove, replacing with the new symbols in lisp.h. All uses changed.
4133 * fileio.c (make_temp_name):
4134 * filelock.c (lock_file_1, lock_file):
4135 * xdisp.c (message_dolog):
4136 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4137 Use pMd etc. instead.
4138 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4139 replacing the pWIDE etc. symbols removed from editfns.c.
4140
3300e6fd
PE
4141 * keyboard.h (num_input_events): Now uintmax_t.
4142 This is (very slightly) less likely to mess up due to wraparound.
4143 All uses changed.
4144
fd05c7e9
PE
4145 * buffer.c: Integer signedness fixes.
4146 (alloc_buffer_text, enlarge_buffer_text):
4147 Use ptrdiff_t rather than size_t when either will do, as we prefer
4148 signed integers.
4149
903fe15d
PE
4150 * alloc.c: Integer signedness and overflow fixes.
4151 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4152 (__malloc_size_t): Default to size_t, not to int.
4153 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4154 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4155 Prefer ptrdiff_t to size_t when either would do, as we prefer
4156 signed integers.
4157 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4158 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4159 Now const. Initialize with values that are in range even if char
4160 is signed.
4161 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4162 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4163 These functions do the right thing with sizes > 2**32.
4164 (check_depth): Now ptrdiff_t, not int.
4165 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4166 Adjust to new way of storing sizes. Check for size overflow bugs
4167 in rest of code.
4168 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4169 slightly wrong anyway, as it missed one instance of
4170 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4171 (refill_memory_reserve): Omit needless cast to size_t.
4172 (mark_object_loop_halt): Mark as externally visible.
4173
ac82cc6a
PE
4174 * xselect.c: Integer signedness and overflow fixes.
4175 (Fx_register_dnd_atom, x_handle_dnd_message):
4176 Use ptrdiff_t, not size_t, since we prefer signed.
4177 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4178 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4179 x_dnd_atoms_size and x_dnd_atoms_length.
4180
c2d1e36d
PE
4181 * doprnt.c: Prefer signed to unsigned when either works.
4182 * eval.c (verror):
4183 * doprnt.c (doprnt):
4184 * lisp.h (doprnt):
4185 * xdisp.c (vmessage):
4186 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4187 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4188 prefer signed arithmetic to avoid comparison confusion.
4189 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4190 but is a bit tricky.
4191
0e926e56
PE
4192 Assume freestanding C89 headers, string.h, stdlib.h.
4193 * data.c, doprnt.c, floatfns.c, print.c:
4194 Include float.h unconditionally.
4195 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4196 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4197 * regex.c: Likewise for stddef.h, string.h.
4198 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4199 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4200 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4201 (STDC_HEADERS): Remove obsolete defines.
4202 * sysdep.c: Include limits.h unconditionally.
4203
9cfdb3ec
PE
4204 Assume support for memcmp, memcpy, memmove, memset.
4205 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4206 * regex.c (memcmp, memcpy):
4207 Remove; we assume C89 now.
4208
4209 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4210 (__malloc_safe_bcopy): Remove; no longer needed.
4211
cf950e6b 4212 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4213 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4214 well either way, and we prefer signed to unsigned.
4215
dbf38e02
LMI
42162011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4217
4218 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4219 closes the connection while we're reading (bug#9182).
4220
d6f0886c 42212011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4222
d6f0886c
JD
4223 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4224 are specified (Bug#9168).
24e0f6b1 4225
2eb1f9e6
PE
42262011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4227
4228 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4229 Found by GCC static checking and --with-wide-int on a 32-bit host.
4230
22381272 42312011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4232
4233 * xdisp.c (compute_display_string_pos): Fix logic of caching
4234 previous display string position. Initialize cached_prev_pos to
4235 -1. Fixes slow-down at the beginning of a buffer.
4236
f25e39b4
EZ
42372011-07-24 Eli Zaretskii <eliz@gnu.org>
4238
4239 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4240 for attrs[LFACE_FONTSET_INDEX].
4241
04c4b52e
PE
42422011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4243
4244 * xml.c (parse_region): Remove unused local
4245 that was recently introduced.
4246
c1734fbd
EZ
42472011-07-23 Eli Zaretskii <eliz@gnu.org>
4248
be18c5a5
EZ
4249 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4250 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4251
c1734fbd
EZ
4252 * xdisp.c (move_it_in_display_line_to): Record the best matching
4253 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4254 exit if none of the characters scanned was an exact match.
4255 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4256 when exact match is impossible due to invisible text, and the
4257 lines are truncated.
4258
a258d627
JD
42592011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4260
4261 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4262 for OSX >= 10.7.
4263
b6d5a689
EZ
42642011-07-22 Eli Zaretskii <eliz@gnu.org>
4265
0f74f785
EZ
4266 Fix a significant slow-down of cursor motion with C-n, C-p,
4267 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4268 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4269 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4270 (next_element_from_buffer): Call compute_stop_pos_backwards to
4271 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4272 base_level_stop.
4273 (reseat): Don't look for prev_stop, as that could mean a very long
4274 run.
4275 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4276 <cached_disp_overlay_modiff>: Cache for last found display string
4277 position.
551918c1 4278 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4279 about the same buffer in the same area of character positions, and
4280 the buffer wasn't changed since the time the display string
4281 position was cached.
551918c1 4282
b2d0c91a
EZ
42832011-07-22 Eli Zaretskii <eliz@gnu.org>
4284
4285 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4286 is an integer, which is important for empty lines. (Bug#9149)
4287
043604ee
CY
42882011-07-22 Chong Yidong <cyd@stupidchicken.com>
4289
4290 * frame.c (Fmodify_frame_parameters): In tty case, update the
4291 default face if necessary (Bug#4238).
4292
da4adb04
CY
42932011-07-21 Chong Yidong <cyd@stupidchicken.com>
4294
4295 * editfns.c (Fstring_to_char): No need to explain what a character
4296 is in the docstring (Bug#6576).
4297
9abd0532
LMI
42982011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4299
4300 * xml.c (parse_region): Make sure we always return a tree.
4301
36881d16
HK
43022011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4303
4304 * xml.c (parse_region): If a document contains only comments,
4305 return that, too.
4306
1e98674d
LMI
43072011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4308
4309 * xml.c (make_dom): Return comments, too.
4310
590bd467
PE
43112011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4312
4313 Port to OpenBSD.
4314 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4315 and the surrounding thread.
4316 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4317 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4318 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4319 timer goes off.
4320 * s/openbsd.h (BROKEN_SIGIO): Define.
4321 * unexelf.c (unexec) [__OpenBSD__]:
4322 Don't update the .mdebug section of the Alpha COFF symbol table.
4323
f41628b2
LMI
43242011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4325
4326 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4327 (bug#8460).
4328
b59b67c5
PE
43292011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4330
15e3a074
PE
4331 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4332 This fixes some race conditions on the permissions of any newly
4333 created file.
4334
41bed37d
PE
4335 * alloc.c (valid_pointer_p): Use pipe, not open.
4336 This fixes some permissions issues when debugging.
4337
b59b67c5
PE
4338 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4339 If fchown fails to set both uid and gid, try to set just gid,
4340 as that is sometimes allowed. Adjust the file's mode to eliminate
4341 setuid or setgid bits that are inappropriate if fchown fails.
4342
925a6be7
SM
43432011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4344
4345 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4346 to compare Lisp_Objects.
4347 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4348 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4349 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4350
52968808
AS
43512011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4352
0a6a104b
AS
4353 * lread.c (read_integer): Unread even EOF character.
4354 (read1): Likewise. Properly record start position of symbol.
4355
52968808
AS
4356 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4357 symbol character follows.
4358
9e381cdd
PE
43592011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4360
4361 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4362 This works around a problem with the previous change to Fcopy_file.
4363 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4364 and without this change, GCC might complain about discarding
4365 fchown's return value.
4366
b5641435
JB
43672011-07-16 Juanma Barranquero <lekktu@gmail.com>
4368
4369 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4370
a8031457
PE
43712011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4372
4373 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4374
dd889327
LMI
43752011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4376
750c33f7
LMI
4377 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4378 it's used from the C level.
4379
dd889327
LMI
4380 * process.c: Use the same condition for POLL_FOR_INPUT in both
4381 keyboard.c and process.c (bug#1858).
4382
87e86684
LM
43832011-07-09 Lawrence Mitchell <wence@gmx.li>
4384
4385 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4386 (Fgnutls_boot): Use it.
4387
64348f40
AS
43882011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4389
4390 * doc.c (Fsubstitute_command_keys): Revert last change.
4391
1d698799
LMI
43922011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4393
f863868c
LMI
4394 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4395 quotes the next character, and doesn't affect other longer
4396 sequences (bug#8935).
4397
1d698799
LMI
4398 * lread.c (syms_of_lread): Clarify that is isn't only
4399 `eval-buffer' and `eval-defun' that's affected by
4400 `lexical-binding' (bug#8460).
4401
aa4b6df6
EZ
44022011-07-15 Eli Zaretskii <eliz@gnu.org>
4403
4404 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4405 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4406
5d856da6
PE
44072011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4408
ad6042bb
PE
4409 Fix minor problems found by static checking.
4410 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4411 (elsz): Now a signed constant, not a size_t var. We prefer signed
4412 types to unsigned, to avoid integer comparison confusion. Without
4413 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4414 "cannot optimize loop, the loop counter may overflow", a symptom
4415 of the confusion.
f00bbb22 4416 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4417 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4418
6468f31c
LMI
44192011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4420
49080b10
LMI
4421 * search.c (Fre_search_backward): Mention `case-fold-search' in
4422 all the re_search_* functions (bug#8138).
4423
6468f31c
LMI
4424 * keyboard.c (Fopen_dribble_file): Document when the file is
4425 closed (bug#8056).
4426
c965adc5
EZ
44272011-07-14 Eli Zaretskii <eliz@gnu.org>
4428
df9733bf
EZ
4429 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4430 bidi_cache_idx.
4431
0bb23927
EZ
4432 Support bidi reordering of display and overlay strings.
4433 * xdisp.c (compute_display_string_pos)
4434 (compute_display_string_end): Accept additional argument STRING.
4435 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4436 (reseat_to_string): Initialize bidi_it->string.s and
4437 bidi_it->string.schars.
4438 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4439 NULL (avoids a crash in bidi_paragraph_init).
4440 Initialize itb.string.lstring.
0bb23927
EZ
4441 (init_iterator): Call bidi_init_it only of a valid
4442 buffer position was specified. Initialize paragraph_embedding to
4443 L2R.
4444 (reseat_to_string): Initialize the bidi iterator.
4445 (display_string): If we need to ignore text properties of
4446 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4447 original value of -1 will not work with bidi.)
4448 (compute_display_string_pos): First arg is now struct
4449 `text_pos *'; all callers changed. Support display properties on
4450 Lisp strings.
4451 (compute_display_string_end): Support display properties on Lisp
4452 strings.
4453 (init_iterator, reseat_1, reseat_to_string): Initialize the
4454 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4455 when iterating on a string not from display properties).
640c8776
SM
4456 (compute_display_string_pos, compute_display_string_end):
4457 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4458 arrow keys.
4459 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4460 base_level_stop; instead, set base_level_stop to BEGV.
4461 Fixes crashes in vertical-motion.
0bb23927
EZ
4462 (next_element_from_buffer): Improve commentary for when
4463 the iterator is before prev_stop.
4464 (init_iterator): Initialize bidi_p from the default value of
4465 bidi-display-reordering, not from buffer-local value. Use the
4466 buffer-local value only if initializing for buffer iteration.
4467 (handle_invisible_prop): Support invisible properties on strings
4468 that are being bidi-reordered.
4469 (set_iterator_to_next): Support bidi reordering of C strings and
4470 Lisp strings.
4471 (next_element_from_string): Support bidi reordering of Lisp
4472 strings.
4473 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4474 (display_string): Support display of R2L glyph rows.
4475 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4476 (init_iterator): Don't initialize it->bidi_p for strings
4477 here.
4478 (reseat_to_string): Initialize it->bidi_p for strings here.
4479 (next_element_from_string, next_element_from_c_string)
4480 (next_element_from_buffer): Add xassert's for correspondence
4481 between IT's object being iterated and it->bidi_it.string
4482 structure.
4483 (face_before_or_after_it_pos): Support bidi iteration.
4484 (next_element_from_c_string): Handle the case of the first string
4485 character that is not the first one in the visual order.
4486 (get_visually_first_element): New function, refactored from common
4487 parts of next_element_from_buffer, next_element_from_string, and
4488 next_element_from_c_string.
4489 (tool_bar_lines_needed, redisplay_tool_bar)
4490 (display_menu_bar): Force left-to-right direction. Add a FIXME
4491 comment for making that be controlled by a user option.
4492 (push_it, pop_it): Save and restore the state of the
4493 bidi iterator. Save and restore the bidi_p flag.
4494 (pop_it): Iterate out of display property for string iteration as
4495 well.
4496 (iterate_out_of_display_property): Support iteration over strings.
4497 (handle_single_display_spec): Set up it->bidi_it for iteration
4498 over a display string, and call bidi_init_it.
4499 (handle_single_display_spec, next_overlay_string)
4500 (get_overlay_strings_1, push_display_prop): Set up the bidi
4501 iterator for displaying display or overlay strings.
4502 (forward_to_next_line_start): Don't use the shortcut if
4503 bidi-iterating.
4504 (back_to_previous_visible_line_start): If handle_display_prop
4505 pushed the iterator stack, restore the internal state of the bidi
4506 iterator by calling bidi_pop_it same number of times.
4507 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4508 and we are bidi-iterating, don't decrement the iterator position;
4509 instead, set the first_elt flag in the bidi iterator, to produce
4510 the same effect.
4511 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4512 (push_display_prop): xassert that we are iterating a buffer.
4513 (push_it, pop_it): Save and restore paragraph_embedding member.
4514 (handle_single_display_spec, next_overlay_string)
4515 (get_overlay_strings_1, reseat_1, reseat_to_string)
4516 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4517 correctly. Don't assume unibyte strings are not bidi-reordered.
4518 (compute_display_string_pos)
4519 (compute_display_string_end): Fix handling the case of C string.
4520 (push_it, pop_it): Save and restore from_disp_prop_p.
4521 (handle_single_display_spec, push_display_prop): Set the
4522 from_disp_prop_p flag.
4523 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4524 (pop_it): Call iterate_out_of_display_property only if we are
4525 popping after iteration over a string that came from a display
4526 property. Fix a typo in popping stretch info. Add an assertion
4527 for verifying that the iterator position is in sync with the bidi
4528 iterator.
4529 (handle_single_display_spec, get_overlay_strings_1)
4530 (push_display_prop): Fix initialization of paragraph direction for
4531 string when that of the parent object is not yet determined.
4532 (reseat_1): Call bidi_init_it to resync the bidi
4533 iterator with IT's position. (Bug#7616)
4534 (find_row_edges): If ROW->start.pos gives position
4535 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4536 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4537 Reset the from_disp_prop_p flag.
4538 (SAVE_IT, RESTORE_IT): New macros.
4539 (pos_visible_p, face_before_or_after_it_pos)
4540 (back_to_previous_visible_line_start)
4541 (move_it_in_display_line_to, move_it_in_display_line)
4542 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4543 (try_scrolling, redisplay_window, display_line): Use them when
4544 saving a temporary copy of the iterator and restoring it back.
4545 (back_to_previous_visible_line_start, reseat_1)
4546 (init_iterator): Empty the bidi cache "stack".
4547 (move_it_in_display_line_to): If iterator ended up at
4548 EOL, but we never saw any buffer positions smaller than
4549 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4550 motion in bidi-reordered lines.
4551 (move_it_in_display_line_to): Record prev_method and prev_pos
4552 immediately before the call to set_iterator_to_next. Fixes cursor
4553 motion in bidi-reordered lines with stretch glyphs and strings
4554 displayed in margins. (Bug#8133) (Bug#8867)
4555 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4556 TO_CHARPOS.
640c8776
SM
4557 (pos_visible_p): Support positions in bidi-reordered lines.
4558 Save and restore bidi cache.
0bb23927
EZ
4559
4560 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4561 (bidi_paragraph_info): Delete unused struct.
4562 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4563 (bidi_cache_start): New variable.
4564 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4565 to zero.
4566 (bidi_cache_fetch_state, bidi_cache_search)
4567 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4568 (bidi_cache_find, bidi_peek_at_next_level)
4569 (bidi_level_of_next_char, bidi_find_other_level_edge)
4570 (bidi_move_to_visually_next): Compare cache index with
4571 bidi_cache_start rather than with zero.
4572 (bidi_fetch_char): Accept new argument STRING; all callers
4573 changed. Support iteration over a string. Support strings with
4574 display properties. Support unibyte strings. Fix the type of
4575 `len' according to what STRING_CHAR_AND_LENGTH expects.
4576 (bidi_paragraph_init, bidi_resolve_explicit_1)
4577 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4578 (bidi_level_of_next_char, bidi_move_to_visually_next):
4579 Support iteration over a string.
0bb23927
EZ
4580 (bidi_set_sor_type, bidi_resolve_explicit_1)
4581 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4582 can now be zero (for strings); special values 0 and -1 were
4583 changed to -1 and -2, respectively.
4584 (bidi_char_at_pos): New function.
4585 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4586 Call it instead of FETCH_MULTIBYTE_CHAR.
4587 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4588 initialized to valid values.
4589 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4590 values.
4591 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4592 the test for valid cached positions. Fix the logic for looking up
4593 the sentinel state in the cache. GCPRO the Lisp string we are
4594 iterating.
4595 (bidi_push_it, bidi_pop_it): New functions.
4596 (bidi_initialize): Initialize the bidi cache start stack pointer.
4597 (bidi_cache_ensure_space): New function, refactored from part of
4598 bidi_cache_iterator_state. Don't assume the required size is just
4599 one BIDI_CACHE_CHUNK away.
4600 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4601 (bidi_count_bytes, bidi_char_at_pos): New functions.
4602 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4603 always valid if bidi_cache_idx is valid.
4604 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4605 is valid if it's going to be used.
4606 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4607 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4608 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4609 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4610 (bidi_find_other_level_edge, bidi_cache_start_stack):
4611 All variables related to cache indices are now EMACS_INT.
c965adc5 4612
0bb23927
EZ
4613 * dispextern.h (struct bidi_string_data): New structure.
4614 (struct bidi_it): New member `string'. Make flag members be 1-bit
4615 fields, and put them last in the struct.
640c8776
SM
4616 (compute_display_string_pos, compute_display_string_end):
4617 Update prototypes.
0bb23927
EZ
4618 (bidi_push_it, bidi_pop_it): Add prototypes.
4619 (struct iterator_stack_entry): New members bidi_p,
4620 paragraph_embedding, and from_disp_prop_p.
4621 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4622 (bidi_shelve_cache, bidi_unshelve_cache):
4623 Declare prototypes.
0bb23927
EZ
4624
4625 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4626 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4627 and vector-like objects.
4628
4629 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4630 cache around display iteration.
4631
4632 * window.c (Fwindow_end, window_scroll_pixel_based)
4633 (displayed_window_lines, Frecenter): Save and restore the bidi
4634 cache around display iteration.
4635
3bbd2265
LMI
46362011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4637
4638 * editfns.c (Fdelete_region): Clarify the use of the named
4639 parameters (bug#6788).
4640
adc47434
MR
46412011-07-14 Martin Rudalics <rudalics@gmx.at>
4642
4643 * indent.c (Fvertical_motion): Set and restore w->pointm when
4644 saving and restoring the window's buffer (Bug#9006).
4645
837c31f8
LMI
46462011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4647
4648 * editfns.c (Fstring_to_char): Clarify just what is returned
4649 (bug#6576). Text by Eli Zaretskii.
4650
ac389d0c
JB
46512011-07-13 Juanma Barranquero <lekktu@gmail.com>
4652
4653 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4654
0be0ce47
EZ
46552011-07-13 Eli Zaretskii <eliz@gnu.org>
4656
4657 * buffer.c (mmap_find): Fix a typo.
4658
cd18e7e3
JB
46592011-07-13 Johan Bockgård <bojohan@gnu.org>
4660
4661 Fix execution of x selection hooks.
4662 * xselect.c (Qx_lost_selection_functions)
4663 (Qx_sent_selection_functions): New vars.
4664 (syms_of_xselect): DEFSYM them.
4665 (x_handle_selection_request): Pass Qx_sent_selection_functions
4666 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4667 (x_handle_selection_clear,x_clear_frame_selections):
4668 Pass Qx_lost_selection_functions rather than
4669 Vx_lost_selection_functions to Frun_hook_with_args.
4670
47ea7f44
PE
46712011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4672
ac389d0c 4673 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4674 The old code sometimes used this field without initializing it.
4675
47ea7f44
PE
4676 * alloc.c (gc_sweep): Don't read past end of array.
4677 In theory, the old code could also have corrupted Emacs internals,
4678 though it'd be very unlikely.
4679
bc985c87
AS
46802011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4681
4682 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4683 argument. (Bug#4026)
bc985c87 4684
0cf34688
LMI
46852011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4686
b3dadd76
LMI
4687 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4688 key" (bug#4257).
4689
0cf34688
LMI
4690 * window.c (Fset_window_start): Doc fix (bug#4199).
4691 (Fset_window_hscroll): Ditto.
4692
270768cd
PE
46932011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4694
077e3dda 4695 Fix minor new problems caught by GCC 4.6.1.
270768cd 4696 * term.c (init_tty): Remove unused local.
490011a6 4697 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4698 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4699 not used otherwise.
270768cd 4700
b1f58454
CY
47012011-07-12 Chong Yidong <cyd@stupidchicken.com>
4702
4703 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4704
22b9578d
LMI
47052011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4706
6e70ab07
LMI
4707 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4708 are the mini-buffer and the echo area (bug#3320).
4709
22b9578d
LMI
4710 * term.c (init_tty): Remove support for supdup, c10 and perq
4711 terminals, which are no longer supported (bug#1482).
4712
8974cc9f
JB
47132011-07-10 Johan Bockgård <bojohan@gnu.org>
4714
4715 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4716
a560d974
JD
47172011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4718
4719 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4720 for non-popups (Bug#3642).
4721
1dae0f0a
AS
47222011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4723
268c2c36 4724 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4725 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4726 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4727 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4728 * data.c (fmod): Likewise.
4729 * dispnew.c (swap_glyphs_in_rows): Likewise.
4730 * emacs.c (memory_warning_signal): Likewise.
4731 * floatfns.c (float_error): Likewise.
4732 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4733 (otf_open, font_otf_capability, generate_otf_features)
4734 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4735 Likewise.
4736 * image.c (pbm_read_file): Likewise.
4737 * indent.c (string_display_width): Likewise.
4738 * intervals.c (check_for_interval, search_for_interval)
4739 (inc_interval_count, count_intervals, root_interval)
4740 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4741 * lread.c (defalias): Likewise.
268c2c36 4742 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4743 * regex.c (set_image_of_range_1, set_image_of_range)
4744 (regex_grow_registers): Likewise.
4745 * sysdep.c (strerror): Likewise.
4746 * termcap.c (valid_filename_p, tprint, main): Likewise.
4747 * tparam.c (main): Likewise.
4748 * unexhp9k800.c (run_time_remap, save_data_space)
4749 (update_file_ptrs, read_header, write_header, calculate_checksum)
4750 (copy_file, copy_rest, display_header): Likewise.
4751 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4752 Likewise.
4753 * xdisp.c (check_it): Likewise.
4754 * xfaces.c (register_color, unregister_color, unregister_colors):
4755 Likewise.
4756 * xfns.c (print_fontset_result): Likewise.
4757 * xrdb.c (member, fatal, main): Likewise.
4758
99033785
PE
47592011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4760
4761 Fix minor problems found by static checking (Bug#9031).
4762 * chartab.c (char_table_set_range, map_sub_char_table):
4763 Remove unused locals.
4764 (uniprop_table): Now static.
4765 * composite.c (_work_char): Remove unused static var.
4766
9cb2ac56
JB
47672011-07-09 Juanma Barranquero <lekktu@gmail.com>
4768
4769 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4770
f25661f0
JD
47712011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4772
4773 * gtkutil.c (qttip_cb): Remove code without function.
4774
8278c4fe
EZ
47752011-07-09 Eli Zaretskii <eliz@gnu.org>
4776
4777 * w32.c (pthread_sigmask): New stub.
4778
1692ae2d 47792011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4780
8a6ebd58 4781 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4782 sigprocmask is portable only for single-threaded applications, and
4783 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4784 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4785 (LIBES): Use it.
4786 * callproc.c (Fcall_process):
4787 * process.c (create_process):
4788 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4789 Use pthread_sigmask, not sigprocmask.
123403e4 4790
1b854618
JD
47912011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4792
4793 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4794 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4795 wrong (Bug#8591).
4796
3fe4b549
JD
47972011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4798
0ce7e563
JD
4799 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4800 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4801 (xg_hide_tooltip): Fix comment.
4802
3fe4b549
JD
4803 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4804 in registerServicesMenuSendTypes.
4805 (validRequestorForSendType): Don't check ns_return_types.
4806
4807 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4808 ns_return_type.
4809
5df75e47
JR
48102011-07-08 Jason Rumney <jasonr@gnu.org>
4811
22610910
JR
4812 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4813 SH_SHOW for hidden windows (Bug#5482).
4814
5df75e47
JR
4815 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4816 frame struct members of non-existent frames (Bug#6284).
4817
699c10bd
JD
48182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4819
4393663b
JD
4820 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4821 variable firstTime not needed on OSX >= 10.6.
4822 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4823 >= 10.5. Use setKnobProportion, setDoubleValue.
4824
4825 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4826 (MAC_OS_X_VERSION_10_5): Define if not defined.
4827 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4828 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4829 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4830
4831 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4832 cString and lossyCString on OSX >= 10.4
4833
58179cce 4834 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4835 sizeToFit on OSX >= 10.2.
4836
4837 * nsimage.m (allocInitFromFile): Don't use deprecated method
4838 bestRepresentationForDevice on OSX >= 10.6.
4839
4840 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4841 to avoid warning.
4842
4843 * emacs.c: Declare unexec_init_emacs_zone.
4844
a63e0781
JD
4845 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4846
699c10bd
JD
4847 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4848
4849 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4850 on svcsMenu (Bug#8842).
4851
4852 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4853 ns_return_types.
4854 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4855
4856 * nsterm.m (QUTF8_STRING): Declare.
4857 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4858 (validRequestorForSendType): Return type is (id).
4859 Change indexOfObjectIdenticalTo to indexOfObject.
4860 Check if we have local selection before returning self (Bug#8842).
4861 (writeSelectionToPasteboard): Put local selection into paste board
4862 if we have a local selection (Bug#8842).
4863 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4864
4865 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4866 (ns_get_local_selection): Declare.
4867
54e10184
LMI
48682011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4869
9888ff71
LMI
4870 * keymap.c (describe_map_tree): Don't insert a double newline at
4871 the end of the buffer (bug#1169) and return whether we inserted
4872 something.
4873
54e10184
LMI
4874 * callint.c (Fcall_interactively): Change "reading args" to
4875 "providing args" to try to clarify what it does (bug#1010).
4876
15fa4783
KH
48772011-07-07 Kenichi Handa <handa@m17n.org>
4878
4879 * composite.c (composition_compute_stop_pos): Ignore a static
4880 composition starting before CHARPOS (Bug#8915).
4881
4882 * xdisp.c (handle_composition_prop): Likewise.
4883
a8815b00
EZ
48842011-07-07 Eli Zaretskii <eliz@gnu.org>
4885
4886 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4887 (Bug#9015)
4888
ef7b981d 48892011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4890
4891 * character.h (unicode_category_t): New enum type.
4892
4893 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4894 (Qchar_code_property_table): New variable.
4895 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4896 (UNIPROP_COMPRESSED_FORM_P): New macros.
4897 (char_table_ascii): Uncompress the compressed values.
4898 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4899 Uncompress the compressed values.
ac389d0c 4900 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4901 (char_table_ref_and_range): Uncompress the compressed values.
4902 (sub_char_table_set): New arg is_uniprop. Callers changed.
4903 Uncompress the compressed values.
4904 (sub_char_table_set_range): Args changed. Callers changed.
4905 (char_table_set_range): Adjuted for the above change.
4906 (map_sub_char_table): Delete args default_val and parent. Add arg
4907 top. Give decoded values to a Lisp function.
640c8776 4908 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4909 values to a Lisp function. Gcpro more variables.
4910 (uniprop_table_uncompress)
4911 (uniprop_decode_value_run_length): New functions.
4912 (uniprop_decoder, uniprop_decoder_count): New variables.
4913 (uniprop_get_decoder, uniprop_encode_value_character)
4914 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4915 New functions.
4916 (uniprop_encoder, uniprop_encoder_count): New variables.
4917 (uniprop_get_encoder, uniprop_table)
4918 (Funicode_property_table_internal, Fget_unicode_property_internal)
4919 (Fput_unicode_property_internal): New functions.
4920 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4921 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4922 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4923 char-code-property-alist.
4924
640c8776 4925 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4926 Vunicode_category_table.
4927
640c8776 4928 * font.c (font_range): Adjust for the change of
c805dec0
KH
4929 Vunicode_category_table.
4930
76b397fb
DN
49312011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4932
4933 * m/iris4d.h: Remove file, move contents ...
4934 * s/irix6-5.h: ... here.
4935
22b4128e
PE
49362011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4937
4938 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4939 * alloc.c (mark_buffer):
4940 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4941 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4942 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4943 This isn't true in general, and it's particularly not true
4944 if Emacs is configured with --with-wide-int.
4945 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4946 New macros, used in the buffer.c change.
4947
869795d6
JD
49482011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4949
4950 * xsettings.c: Use both GConf and GSettings if both are available.
4951 (store_config_changed_event): Add comment.
4952 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4953 (store_tool_bar_style_changed): New functions.
5e617bc2 4954 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4955 (struct xsettings): Move font inside HAVE_XFT.
4956 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4957 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4958 Move inside HAVE_XFT.
640c8776 4959 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4960 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4961 also.
4962 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4963 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4964 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4965 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4966 (parse_settings): Move check for font inside HAVE_XFT.
4967 (read_settings, apply_xft_settings): Add comment.
4968 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4969 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4970 call store_font_name_changed.
4971 (xft_settings_event): Add comment.
4972 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4973 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4974 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4975 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4976 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4977 (xsettings_get_system_font, xsettings_get_system_normal_font):
4978 Add comment.
869795d6 4979
d8ed26bd
PE
49802011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4981
4982 Random fixes. E.g., (random) never returned negative values.
4983 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4984 subseconds part to the entropy, as that's a bit more random.
4985 Prefer signed to unsigned, since the signedness doesn't matter and
4986 in general we prefer signed. When given a limit, use a
4987 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4988 latter isn't right if USE_2_TAGS_FOR_INTS.
4989 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4990 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4991
cabf1cac
SM
49922011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4993
4994 * textprop.c (text_property_stickiness):
4995 Obey Vtext_property_default_nonsticky.
4996 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4997 * w32fns.c (syms_of_w32fns):
4998 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4999
6e9b2be9
PE
50002011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5001
5002 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5003 This is more efficient than Ffile_directory_p and avoids a minor race.
5004
90186c68
LMI
50052011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5006
7c301272
LMI
5007 * buffer.c (Foverlay_put): Say what the return value is
5008 (bug#7835).
5009
c4f2d8d4
LMI
5010 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5011 is a directory before asking whether to use the file name
5012 (bug#7564).
ad637907
LMI
5013 (barf_or_query_if_file_exists): Make the "File is a directory"
5014 error be more correct.
c4f2d8d4 5015
90186c68
LMI
5016 * fns.c (Frequire): Remove the mention of the .gz files, since
5017 that's installation-specific, but keep the mention of
5018 `get-load-suffixes'.
5019
da64016e
PE
50202011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5021
5022 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5023 Report string overflow if the output is too long.
5024
7d47b580
JB
50252011-07-04 Juanma Barranquero <lekktu@gmail.com>
5026
a555cb87
JB
5027 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5028 (syms_of_gnutls): Remove duplicate DEFSYM for
5029 Qgnutls_bootprop_verify_hostname_error, an error for
5030 Qgnutls_bootprop_verify_error (which is no longer used).
5031
7d47b580
JB
5032 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5033 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5034 Also (re)move comments that are misplaced or no longer relevant.
5035
1e49bfab
LMI
50362011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5037
5038 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5039
1485f4c0
CY
50402011-07-03 Chong Yidong <cyd@stupidchicken.com>
5041
5042 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5043 and background color parameters if they have been changed.
5044
a9ab721e
LMI
50452011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5046
5047 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5048
cf7cff57
PE
50492011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5050
2e13213d
PE
5051 * xsettings.c (SYSTEM_FONT): Define only when used.
5052 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5053
cf7cff57
PE
5054 * keymap.c (access_keymap_1): Now static.
5055
7a8e04f7
CY
50562011-07-02 Chong Yidong <cyd@stupidchicken.com>
5057
5058 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5059 leave any prefix arg for the up event (Bug#1586).
5060
61352f62
LMI
50612011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5062
69bb1ef7
LMI
5063 * lread.c (syms_of_lread): Mention single symbols defined by
5064 `defvar' or `defconst' (bug#7154).
5065
61352f62 5066 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 5067 (Frequire): Mention get-load-suffixes.
61352f62 5068
28545e04
MR
50692011-07-02 Martin Rudalics <rudalics@gmx.at>
5070
5071 * window.h (window): Remove clone_number slot.
5072 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5073 Remove.
5074 (make_parent_window, make_window, saved_window)
5075 (Fset_window_configuration, save_window_save): Don't deal with
5076 clone numbers.
5077 * buffer.c (Qclone_number): Remove declaration.
5078 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5079
3349e122
SM
50802011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5081
5082 Add multiple inheritance to keymaps.
5083 * keymap.c (Fmake_composed_keymap): New function.
5084 (Fset_keymap_parent): Simplify.
5085 (fix_submap_inheritance): Remove.
5086 (access_keymap_1): New function extracted from access_keymap to handle
5087 embedded parents and handle lists of maps.
5088 (access_keymap): Use it.
5089 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5090 (Fcopy_keymap): Handle embedded parents.
5091 (Fcommand_remapping, define_as_prefix): Simplify.
5092 (Fkey_binding): Simplify.
5093 (syms_of_keymap): Move minibuffer-local-completion-map,
5094 minibuffer-local-filename-completion-map,
5095 minibuffer-local-must-match-map, and
5096 minibuffer-local-filename-must-match-map to Elisp.
5097 (syms_of_keymap): Defsubr make-composed-keymap.
5098 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5099 (parse_menu_item): Trivial simplification.
5100
3279eb87
GM
51012011-07-01 Glenn Morris <rgm@gnu.org>
5102
5103 * Makefile.in (SETTINGS_LIBS): Fix typo.
5104
4550efdf
KI
51052011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5106
5107 * coding.c (Fencode_coding_string): Record the last coding system
5108 used, as the function doc string says (bug#8738).
5109
0949d2b6
JD
51102011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5111
5112 * xsettings.c (store_monospaced_changed): Take new font as arg and
5113 check for change against current_mono_font.
5114 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5115 (emacs_settings_constructor, emacs_settings_get_property)
5116 (emacs_settings_set_property, emacs_settings_class_init)
5117 (emacs_settings_init, gsettings_obj): Remove.
5118 (something_changedCB): New function for HAVE_GSETTINGS.
5119 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5120 with value as argument.
5121 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5122 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 5123 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
5124 "changed".
5125
5126 * xgselect.c: Add defined (HAVE_GSETTINGS).
5127 (xgselect_initialize): Ditto.
5128
5129 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5130 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5131 xg_select.
5132
bbc6b304
PE
51332011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5134
5135 * eval.c (struct backtrace): Simplify and port the data structure.
5136 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5137 signed bit field, as this assumption is not portable and it makes
5138 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5139 "char debug_on_exit : 1" as this is not portable either; instead,
5140 use the portable "unsigned int debug_on_exit : 1". Remove unused
5141 member evalargs. Remove obsolete comments about cc bombing out.
5142
9851bfc5
JD
51432011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5144
51bb811f 5145 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
5146 Let HAVE_GSETTINGS override HAVE_GCONF.
5147 (store_monospaced_changed): New function.
5148 (EMACS_SETTINGS): A new type derived from GObject to handle
5149 GSettings notifications.
5150 (emacs_settings_constructor, emacs_settings_get_property)
5151 (emacs_settings_set_property, emacs_settings_class_init):
5152 New functions.
5153 (gsettings_client, gsettings_obj): New variables.
5154 (GSETTINGS_SCHEMA): New define.
5155 (something_changedCB): Call store_monospaced_changed.
5156 (init_gsettings): New function.
5157 (xsettings_initialize): Call init_gsettings.
5158 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5159 to NULL.
5160
640c8776 5161 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
5162 GCONF_CFLAGS/LIBS.
5163
5386012d
MR
51642011-06-29 Martin Rudalics <rudalics@gmx.at>
5165
5166 * window.c (resize_root_window, grow_mini_window)
5167 (shrink_mini_window): Rename Qresize_root_window to
5168 Qwindow_resize_root_window and Qresize_root_window_vertically to
5169 Qwindow_resize_root_window_vertically.
5170
f13e0b08
PE
51712011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5172
5173 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5174
94515237
JB
51752011-06-27 Juanma Barranquero <lekktu@gmail.com>
5176
5177 * makefile.w32-in: Redesign dependencies so they reflect more
5178 clearly which files are directly included by each source file,
5179 and not through other includes.
5180
e43b6e43
MR
51812011-06-27 Martin Rudalics <rudalics@gmx.at>
5182
5183 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5184 (sort_overlays, overlay_strings): When an overlay's clone number
5185 matches the window's clone number process the overlay even if
5186 the overlay's window property doesn't match the current window.
5187
d68443dc
MR
5188 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5189 (Fwindow_hchild): Rename to Fwindow_left_child.
5190 (Fwindow_next): Rename to Fwindow_next_sibling.
5191 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5192 (resize_window_check): Rename to window_resize_check.
5193 (resize_window_apply): Rename to window_resize_apply.
5194 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5195 (Fdelete_other_windows_internal, resize_frame_windows)
5196 (Fsplit_window_internal, Fdelete_window_internal)
5197 (grow_mini_window, shrink_mini_window)
5198 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5199
c7e73be5
JD
52002011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5201
5202 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5203 (emacs_fixed_set_min_size): Remove.
5204 (emacs_fixed_new): Take frame as argument.
5205
5206 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5207 (_EmacsFixedPrivate): Remove minwidth/height.
5208 Add struct frame *f.
5209 (emacs_fixed_init): Initialize priv->f.
5210 (get_parent_class, emacs_fixed_set_min_size): Remove.
5211 (emacs_fixed_new): Set priv->f to argument.
5212 (emacs_fixed_get_preferred_width)
5213 (emacs_fixed_get_preferred_height): Use min_width/height from
5214 frames size_hint to set minimum and natural (Bug#8919).
5215 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5216 and use min_width/height from frames size_hint to set
5217 min_width/height (Bug#8919).
5218
5219 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5220 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5221 Fix indentation.
c7e73be5 5222
cf99dcf8
EZ
52232011-06-26 Eli Zaretskii <eliz@gnu.org>
5224
5225 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5226 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5227 called at ZV.
5228
029529ac
CY
52292011-06-26 Chong Yidong <cyd@stupidchicken.com>
5230
5231 * process.c (wait_reading_process_output): Bypass select if
5232 waiting for a cell while ignoring keyboard input, and input is
5233 pending. Suggested by Jan Djärv (Bug#8869).
5234
7a7ef429
PE
52352011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5236
5237 Use gnulib's dup2 module instead of rolling our own.
5238 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5239
11fdef7d 52402011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5241
5242 * dispnew.c (scrolling_window): Before scrolling, turn off a
5243 mouse-highlight in the window being scrolled.
5244
cd3520a4
JB
52452011-06-24 Juanma Barranquero <lekktu@gmail.com>
5246
5247 Move DEFSYM to lisp.h and use everywhere.
5248
5249 * character.h (DEFSYM): Move declaration...
5250 * lisp.h (DEFSYM): ...here.
5251
5252 * gnutls.c:
5253 * minibuf.c:
5254 * w32menu.c:
5255 * w32proc.c:
5256 * w32select.c: Don't include character.h.
5257
5258 * alloc.c (syms_of_alloc):
5259 * buffer.c (syms_of_buffer):
5260 * bytecode.c (syms_of_bytecode):
5261 * callint.c (syms_of_callint):
5262 * casefiddle.c (syms_of_casefiddle):
5263 * casetab.c (init_casetab_once):
5264 * category.c (init_category_once, syms_of_category):
5265 * ccl.c (syms_of_ccl):
5266 * cmds.c (syms_of_cmds):
5267 * composite.c (syms_of_composite):
5268 * dbusbind.c (syms_of_dbusbind):
5269 * dired.c (syms_of_dired):
5270 * dispnew.c (syms_of_display):
5271 * doc.c (syms_of_doc):
5272 * editfns.c (syms_of_editfns):
5273 * emacs.c (syms_of_emacs):
5274 * eval.c (syms_of_eval):
5275 * fileio.c (syms_of_fileio):
5276 * fns.c (syms_of_fns):
5277 * frame.c (syms_of_frame):
5278 * fringe.c (syms_of_fringe):
5279 * insdel.c (syms_of_insdel):
5280 * keymap.c (syms_of_keymap):
5281 * lread.c (init_obarray, syms_of_lread):
5282 * macros.c (syms_of_macros):
5283 * msdos.c (syms_of_msdos):
5284 * print.c (syms_of_print):
5285 * process.c (syms_of_process):
5286 * search.c (syms_of_search):
5287 * sound.c (syms_of_sound):
5288 * syntax.c (init_syntax_once, syms_of_syntax):
5289 * terminal.c (syms_of_terminal):
5290 * textprop.c (syms_of_textprop):
5291 * undo.c (syms_of_undo):
5292 * w32.c (globals_of_w32):
5293 * window.c (syms_of_window):
5294 * xdisp.c (syms_of_xdisp):
5295 * xfaces.c (syms_of_xfaces):
5296 * xfns.c (syms_of_xfns):
5297 * xmenu.c (syms_of_xmenu):
5298 * xsettings.c (syms_of_xsettings):
5299 * xterm.c (syms_of_xterm): Use DEFSYM.
5300
4228cf16
TZ
53012011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5302
cd3520a4 5303 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5304
7fcccf1e
PE
53052011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5306
7efb4e0e
PE
5307 Integer and buffer overflow fixes (Bug#8873).
5308
ff5844ad
PE
5309 * print.c (printchar, strout): Check for string overflow.
5310 (PRINTPREPARE, printchar, strout):
5311 Don't set size unless allocation succeeds.
5312
90532f02
PE
5313 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5314 for sizes. Check for string overflow more accurately.
5315 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5316
6d84508d
PE
5317 * macros.c: Integer and buffer overflow fixes.
5318 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5319 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5320 Use ptrdiff_t, not int, for sizes.
5321 Don't increment bufsize until after realloc succeeds.
5322 Check for size-calculation overflow.
5323 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5324
437b2cb4
PE
5325 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5326
8b9ac8b4
PE
5327 * lread.c: Integer overflow fixes.
5328 (read_integer): Radix is now EMACS_INT, not int,
5329 to improve quality of diagnostics for out-of-range radices.
5330 Calculate buffer size correctly for out-of-range radices.
5331 (read1): Check for integer overflow in radices, and in
5332 read-circle numbers.
82cb60d3
PE
5333 (read_escape): Avoid int overflow.
5334 (Fload, openp, read_buffer_size, read1)
5335 (substitute_object_recurse, read_vector, read_list, map_obarray):
5336 Use ptrdiff_t, not int, for sizes.
5337 (read1): Use EMACS_INT, not int, for sizes.
20270765 5338 Check for size overflow.
8b9ac8b4 5339
7fcccf1e
PE
5340 * image.c (cache_image): Check for size arithmetic overflow.
5341
bfbbd7e7
PE
5342 * lread.c: Integer overflow issues.
5343 (saved_doc_string_size, saved_doc_string_length)
5344 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5345 Now ptrdiff_t, not int.
5346 (read1): Don't assume doc string length fits in int. Check for
5347 out-of-range doc string lengths.
5348 (read_list): Don't assume file position fits in int.
39019e54 5349 (read_escape): Check for hex character overflow.
bfbbd7e7 5350
4e323265
LL
53512011-06-22 Leo Liu <sdl.web@gmail.com>
5352
5353 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5354 Move to minibuffer.el.
5355
85fece3e
PE
53562011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5357
20b84ce9 5358 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5359 The following patches are for when GLYPH_DEBUG && !XASSERT.
5360 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5361 * dispnew.c (flush_stdout):
5362 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5363 Mark as externally visible.
5364 * dispnew.c (check_window_matrix_pointers): Now static.
5365 * dispnew.c (window_to_frame_vpos):
5366 * xfns.c (unwind_create_frame):
5367 * xterm.c (x_check_font): Remove unused local.
5368 * scroll.c (CHECK_BOUNDS):
5369 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5370 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5371 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5372 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5373 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5374 Now static.
5375 (debug_method_add): Use va_list and vsprintf rather than relying
5376 on undefined behavior with wrong number of arguments.
5377 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5378 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5379 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5380 since we're not interested in debugging glyphs with old libraries.
5381 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5382 GCC 4.6.0's static checking.
5383
0766b489
PE
53842011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5385
31fd4b32
PE
5386 Integer overflow and signedness fixes (Bug#8873).
5387 A few related buffer overrun fixes, too.
5388
b79e8648
PE
5389 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5390
0766b489
PE
5391 * dispextern.h (struct face.stipple):
5392 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5393 (x_bitmap_mask, x_allocate_bitmap_record)
5394 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5395 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5396 (x_create_bitmap_from_xpm_data):
5397 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5398 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5399 (.bitmaps_last):
5400 * xfaces.c (load_pixmap):
5401 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5402 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5403 (.bitmaps_last, struct x_output.icon_bitmap):
5404 Use ptrdiff_t, not int, for bitmap indexes.
5405 (x_allocate_bitmap_record): Check for size overflow.
5406 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5407
b081724f
PE
5408 Use ptrdiff_t, not int, for overlay counts.
5409 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5410 * editfns.c (overlays_around, get_pos_property):
5411 * textprop.c (get_char_property_and_overlay):
5412 * xdisp.c (next_overlay_change, note_mouse_highlight):
5413 * xfaces.c (face_at_buffer_position):
21514da7
PE
5414 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5415 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5416 (Fnext_overlay_change, Fprevious_overlay_change)
5417 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5418 Use ptrdiff_t, not int, for sizes.
21514da7 5419 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5420
3de73e5e
PE
5421 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5422
2606c57b
PE
5423 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5424 (x_session_initialize): Do not assume string length fits in int.
5425
aaafe47a
PE
5426 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5427 This is unlikely, but can occur if DPI is outlandish.
5428
2674ddc8 5429 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5430 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5431
28154962
PE
5432 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5433 * xrdb.c (magic_file_p, search_magic_path):
5434 Omit last arg SUFFIX; it was always 0. All callers changed.
5435 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5436
7de51af5
PE
5437 * xfont.c (xfont_match): Avoid need for strlen.
5438
25ed6cc3
PE
5439 * xfns.c: Don't assume strlen fits in int.
5440 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5441
4eab31dd
PE
5442 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5443 not unsigned long, as we prefer signed integers. All callers changed.
5444 Detect integer overflow in repeat count.
5445 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5446 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5447
171e2a58
PE
5448 * termcap.c: Don't assume sizes fit in int and never overflow.
5449 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5450 (gobble_line): Check for size-calculation overflow.
5451
ad39faca 5452 * minibuf.c (Fread_buffer):
6e5bb2dc 5453 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5454 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5455 Don't assume string length fits in int.
5456
52c61c22 5457 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5458 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5459
b5b8c9e5
PE
5460 * font.c: Don't assume string length fits in int.
5461 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5462 Use ptrdiff_t, not int.
ccd6111c
PE
5463 (font_intern_prop): Don't assume string length fits in int.
5464 Don't assume integer property fits in fixnum.
5465 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5466
882f0d81 5467 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5468 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5469 Reformulate so as not to need the command string.
5470 Invoke gzip -cd rather than gunzip, as it's more portable.
5471 (lock_info_type, lock_file_1, lock_file):
5472 Don't assume pid_t and time_t fit in unsigned long.
5473 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5474 (current_lock_owner): Prefer signed type for sizes.
5475 Use memcpy, not strncpy, where memcpy is what is really wanted.
5476 Don't assume (via atoi) that time_t and pid_t fit in int.
5477 Check for time_t and/or pid_t out of range, e.g., via a network share.
5478 Don't alloca where an auto var works fine.
5479
93f4cf88
PE
5480 * fileio.c: Fix some integer overflow issues.
5481 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5482 Don't assume string length fits in int.
5483 (directory_file_name): Don't assume string length fits in long.
5484 (make_temp_name): Don't assume pid fits in int, or that its print
5485 length is less than 20.
5486
f3e92b69
PE
5487 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5488
1bfdaf10
PE
5489 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5490
35016e9a
PE
5491 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5492
3d1e65a1
PE
5493 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5494 We prefer signed integers, even for size calculations.
5495
0b963a93
PE
5496 * emacs.c: Don't assume string length fits in 'int'.
5497 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5498 (main): Don't invoke strlen when not needed.
5499
573f4b54
PE
5500 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5501 (XD_DEBUG_MESSAGE): Don't waste a byte.
5502
989f33ba
PE
5503 * callproc.c (getenv_internal_1, getenv_internal)
5504 (Fgetenv_internal):
965d34eb
PE
5505 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5506
e4d29b33
PE
5507 * lread.c (invalid_syntax): Omit length argument.
5508 All uses changed. This doesn't fix a bug, but it simplifies the
5509 code away from its former Hollerith-constant appearance, and it's
5510 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5511 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5512
eb49b136
PE
5513 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5514 This didn't break anything, but it didn't help either.
5515 It's confusing to put a bogus integer in a place where the actual
5516 value does not matter.
9f62aeb1 5517 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5518 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5519
15375a22
PE
5520 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5521 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5522 implementation.
b61cc01c
PE
5523 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5524 We prefer signed types, and the value cannot exceed the EMACS_INT
5525 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5526 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5527 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5528 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5529
53b2623d
PE
5530 * indent.c (sane_tab_width): New function.
5531 (current_column, scan_for_column, Findent_to, position_indentation)
5532 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5533 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5534
51cab52b 5535 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5536
f2ed8a70
PE
5537 * lisp.h (lint_assume): New macro.
5538 * composite.c (composition_gstring_put_cache):
5539 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5540
abe80cc6
PE
5541 * editfns.c, insdel.c:
5542 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5543
b02c740e
PE
5544 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5545
ebc96716
PE
5546 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5547
b4e50fa0 5548 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5549 Use much-faster test for byte-length change.
311d5d7c 5550 Don't assume string byte-length fits in 'int'.
a4cf38e4 5551 Check that character arg fits in 'int'.
85461888 5552 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5553
c0c1ee9f
PE
5554 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5555
a498d7f4
PE
5556 * fns.c (concat): Catch string overflow earlier.
5557 Do not rely on integer wraparound.
5558
51cab52b
PE
5559 * dispextern.h (struct it.overlay_strings_charpos)
5560 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5561 * xdisp.c (forward_to_next_line_start)
5562 (back_to_previous_visible_line_start)
5563 (reseat_at_next_visible_line_start, next_element_from_buffer):
5564 Don't arbitrarily truncate the value of 'selective' to int.
5565
76031fad
PE
5566 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5567
5eb55db9
PE
5568 * composite.c: Don't truncate sizes to 'int'.
5569 (composition_gstring_p, composition_reseat_it)
5570 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5571 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5572 not EMACS_UINT, for indexes.
5eb55db9 5573
0703a717
PE
5574 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5575
d6202519
PE
5576 * buffer.c: Include <verify.h>.
5577 (struct sortvec.priority, struct sortstr.priority):
8961a454 5578 Now EMACS_INT, not int.
c20998a7 5579 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5580 (struct sortstr.size, record_overlay_string)
5581 (struct sortstrlist.size, struct sortlist.used):
5582 Don't truncate size to int.
5583 (record_overlay_string): Check for size-calculation overflow.
d6202519 5584 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5585
d5a19415
JM
55862011-06-22 Jim Meyering <meyering@redhat.com>
5587
029529ac 5588 Don't leak an XBM-image-sized buffer
d5a19415
JM
5589 * image.c (xbm_load): Free the image buffer after using it.
5590
a9041e6c
PE
55912011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5592
5593 Port to Sun C.
5594 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5595 that Sun C diagnosed.
5596 * fns.c (secure_hash): Fix pointer signedness issue.
5597 * intervals.c (static_offset_intervals): New function.
5598 (offset_intervals): Use it.
5599
7f3f739f
LL
56002011-06-21 Leo Liu <sdl.web@gmail.com>
5601
5602 * deps.mk (fns.o):
5603 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5604 sha512.h.
5605
5606 * fns.c (secure_hash): Rename from crypto_hash_function and change
5607 the first arg to accept symbols.
5b66d427 5608 (Fsecure_hash): New primitive.
7f3f739f
LL
5609 (syms_of_fns): New symbols.
5610
76147d94
DD
56112011-06-20 Deniz Dogan <deniz@dogan.se>
5612
5613 * process.c (Fset_process_buffer): Clarify return value in
5614 docstring.
5615
7d7d0045
CY
56162011-06-18 Chong Yidong <cyd@stupidchicken.com>
5617
5618 * dispnew.c (add_window_display_history): Use BVAR.
5619
5620 * xdisp.c (debug_method_add): Use BVAR.
5621 (check_window_end, dump_glyph_matrix, dump_glyph)
5622 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5623
5624 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5625 Likewise.
5626
5627 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5628 check till after the cache is created in init_frame_faces.
5629
ff2bc410
SM
56302011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5631
5632 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5633
28177add
PE
56342011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5635
dd3482fe
PE
5636 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5637 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5638 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5639
393d71f3 5640 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5641 * fileio.c (Finsert_file_contents):
5642 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5643 Remove the old (too-loose) buffer overflow checks.
5644 They weren't needed, since make_gap checks for buffer overflow.
5645 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5646 The old code merely checked for Emacs fixnum overflow, and relied
5647 on undefined (wraparound) behavior. The new code avoids undefined
5648 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5649
2e6813b0 5650 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5651 Tune. Don't use wider integers than needed. Don't use alloca.
5652 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5653
599a9e4f
PE
5654 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5655
99561444
PE
5656 * insdel.c, lisp.h (buffer_overflow): New function.
5657 (insert_from_buffer_1, replace_range, replace_range_2):
5658 * insdel.c (make_gap_larger):
5659 * editfns.c (Finsert_char):
5660 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5661
28177add
PE
5662 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5663
e69dafad
PE
56642011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5665
4baa020d 5666 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5667
b1c46f02
PE
5668 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5669 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5670
e69dafad
PE
5671 * fileio.c: Don't assume EMACS_INT fits in off_t.
5672 (emacs_lseek): New static function.
5673 (Finsert_file_contents, Fwrite_region): Use it.
5674 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5675
566684ea
PE
5676 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5677
e6966cd6
PE
5678 * fns.c: Don't overflow int when computing a list length.
5679 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5680 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5681 truncation on 64-bit hosts. Check for QUIT every
5682 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5683 faster and is responsive enough.
5684 (Flength): Report an error instead of overflowing an integer.
5685 (Fsafe_length): Return a float if the value is not representable
5686 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5687 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5688 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5689
dd0b0efb
PE
5690 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5691 (header_size, word_size): New constants.
5692 (allocate_vectorlike): Don't check size overflow here.
5693 (allocate_vector): Check it here instead, since this is the only
5694 caller of allocate_vectorlike that could cause overflow.
5695 Check that the new vector's length is representable as a fixnum.
5696
86fe5cfe
PE
5697 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5698 The previous code was bogus. For example, next_almost_prime (32)
5699 returned 39, which is undesirable as it is a multiple of 3; and
5700 next_almost_prime (24) returned 25, which is a multiple of 5 so
5701 why was the code bothering to check for multiples of 7?
5702
80e88859
PE
5703 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5704
4a2f0ad6
PE
5705 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5706
f66c7cf8
PE
5707 Variadic C functions now count arguments with ptrdiff_t.
5708 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5709 Back then I didn't know that the Emacs coding style prefers signed int.
5710 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5711 were being counted with int, which may truncate counts on 64-bit
5712 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5713 * lisp.h (struct Lisp_Subr.function.aMANY)
5714 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5715 Arg counts are now ptrdiff_t, not size_t.
5716 All variadic functions and their callers changed accordingly.
5717 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5718 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5719 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5720 * callint.c (Fcall_interactively): Check arg count for overflow,
5721 to avoid potential buffer overrun. Use signed char, not 'int',
5722 for 'varies' array, so that we needn't bother to check its size
5723 calculation for overflow.
5724 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5725 * eval.c (apply_lambda):
5726 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5727 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5728 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5729
a1759b76
PE
5730 * callint.c (Fcall_interactively): Don't use index var as event count.
5731
d96be9fc
PE
5732 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5733 * mem-limits.h (SIZE): Remove; no longer used.
5734
a690a978 5735 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5736
578c21e6
PE
5737 Remove unnecessary casts.
5738 * xterm.c (x_term_init):
5739 * xfns.c (x_set_border_pixel):
5740 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5741 These aren't needed now that we assume ANSI C.
5742
96f53c6c
PE
5743 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5744 It's more likely to cause problems (due to unsigned overflow)
5745 than to cure them.
5746
83c77d31
PE
5747 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5748
ee2079f1
PE
5749 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5750
6da65536
PE
5751 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5752
7147c4a4
PE
5753 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5754
193e32d9
PE
5755 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5756
e5533da6
PE
5757 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5758
9910e595
PE
5759 GLYPH_CODE_FACE returns EMACS_INT, not int.
5760 * dispextern.h (merge_faces):
5761 * xfaces.c (merge_faces):
01103c44
PE
5762 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5763 Don't assume EMACS_INT fits in int.
9910e595 5764
2638320e
PE
5765 * character.h (CHAR_VALID_P): Remove unused parameter.
5766 * fontset.c, lisp.h, xdisp.c: All uses changed.
5767
045eb8d9
PE
5768 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5769
c1f134b5
PE
5770 * fns.c (concat): Minor tuning based on overflow analysis.
5771 This doesn't fix any bugs. Use int to hold character, instead
5772 of constantly refetching from Emacs object. Use XFASTINT, not
5773 XINT, for value known to be a character. Don't bother comparing
5774 a single byte to 0400, as it's always less.
5775
395fcb93 5776 * floatfns.c (Fexpt):
327eeec8
PE
5777 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5778
abbd3d23
PE
5779 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5780 for characters.
5781
684a03ef
PE
5782 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5783
0fed43f3
PE
5784 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5785 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5786 incorrectly succeed when S was a string, because 4294967386 was
5787 truncated before it was used.
5788
8fd02eb7
PE
5789 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5790 Otherwise, an out-of-range integer could cause undefined behavior
5791 on a 64-bit host.
5792
f8c86b69
PE
5793 * composite.c: Use int, not EMACS_INT, for characters.
5794 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5795 EMACS_INT, for values that are known to be in character range.
5796 This doesn't fix any bugs but is the usual style inside Emacs and
5797 may generate better code on 32-bit machines.
5798
34206dd2
PE
5799 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5800 This is for reasons similar to the recent CHAR_STRING fix.
5801 * charset.c (Fencode_char): Check that character arg is actually
5802 a character. Pass an int to ENCODE_CHAR.
5803 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5804 wider than 'int', as a compile-time check to prevent future regressions
5805 in this area.
5806
c5958d4c 5807 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5808
5809 Make sure a 64-bit char is never passed to CHAR_STRING.
5810 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5811 by silently ignoring the top 32 bits, allowing some values
5812 that were far too large to be valid characters.
5813 * character.h: Include <verify.h>.
5814 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5815 arguments are no wider than unsigned, as a compile-time check
5816 to prevent future regressions in this area.
5817 * data.c (Faset):
01103c44 5818 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5819 (Fsubst_char_in_region):
5820 * fns.c (concat):
5821 * xdisp.c (decode_mode_spec_coding):
5822 Adjust to CHAR_STRING's new requirement.
5823 * editfns.c (Finsert_char, Fsubst_char_in_region):
5824 * fns.c (concat): Check that character args are actually
5825 characters. Without this test, these functions did the wrong
5826 thing with wildly out-of-range values on 64-bit hosts.
5827
d37ca623
PE
5828 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5829 These casts should not be needed on 32-bit hosts, either.
5830 * keyboard.c (read_char):
5831 * lread.c (Fload): Remove casts to unsigned.
5832
ea204efb
PE
5833 * lisp.h (UNSIGNED_CMP): New macro.
5834 This fixes comparison bugs on 64-bit hosts.
5835 (ASCII_CHAR_P): Use it.
5836 * casefiddle.c (casify_object):
01103c44 5837 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5838 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5839 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5840 * dispextern.h (FACE_FROM_ID):
5841 * keyboard.c (read_char): Use UNSIGNED_CMP.
5842
41cb286c
PE
5843 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5844 not to EMACS_INT, to avoid GCC warning.
5845
4a1b9832
PE
5846 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5847
55daad71
PE
5848 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5849 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5850 isn't needed on 32-bit machines.
8f95c75c 5851
01103c44
PE
5852 * buffer.c (Fgenerate_new_buffer_name):
5853 Use EMACS_INT for count, not int.
0ceccced 5854 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5855
5856 * data.c (Qcompiled_function): Now static.
5857
c6f072e7
PE
5858 * window.c (window_body_lines): Now static.
5859
20ce5912
PE
5860 * image.c (gif_load): Rename local to avoid shadowing.
5861
9c4c5f81
PE
5862 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5863 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5864 * alloc.c (make_save_value): Integer argument is now of type
5865 ptrdiff_t, not int.
5866 (mark_object): Use ptrdiff_t, not int.
5867 * lisp.h (pD): New macro.
5868 * print.c (print_object): Use it.
5869
c0c5c8ae
PE
5870 * alloc.c: Use EMACS_INT, not int, to count objects.
5871 (total_conses, total_markers, total_symbols, total_vector_size)
5872 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5873 (total_free_floats, total_floats, total_free_intervals)
5874 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5875 Now EMACS_INT, not int. All uses changed.
5876 (Fgarbage_collect): Compute overall total using a double, so that
5877 integer overflow is less likely to be a problem. Check for overflow
5878 when converting back to an integer.
5a25e253
PE
5879 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5880 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5881 These were 'int' variables that could overflow on 64-bit hosts;
5882 they were never used, so remove them instead of repairing them.
211a0b2a 5883 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5884 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5885 Previously, this ceilinged at INT_MAX, but that doesn't work on
5886 64-bit machines.
e46bb31a 5887 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5888
c78baabf 5889 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5890 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5891 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5892 when a (possibly-narrower) signed value would do just as well.
5893 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5894
c9d624c6
PE
5895 * alloc.c: Catch some string size overflows that we were missing.
5896 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5897 for convenience in STRING_BYTES_MAX.
5898 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5899 The definition here is exact; the one in lisp.h was approximate.
5900 (allocate_string_data): Check for string overflow. This catches
5901 some instances we weren't catching before. Also, it catches
5902 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5903 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5904 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5905
c9d624c6
PE
5906 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5907 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5908 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5909
353032ce
PE
5910 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5911
2bccce07
PE
5912 * alloc.c (Fmake_string): Check for out-of-range init.
5913
0ac30604
SM
59142011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5915
5916 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5917
c195f2de
JD
59182011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5919
5920 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5921 xg_get_default_scrollbar_width.
5922
5923 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5924 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5925 (style_changed_cb): Call update_theme_scrollbar_width and call
5926 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5927 all frames (Bug#8505).
5928 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5929 Call gtk_window_set_resizable if HAVE_GTK3.
5930 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5931 and height if HAVE_GTK3 (Bug#8505).
5932 (scroll_bar_width_for_theme): New variable.
5933 (update_theme_scrollbar_width): New function.
5934 (xg_get_default_scrollbar_width): Move code to
5935 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5936 (xg_initialize): Call update_theme_scrollbar_width.
5937
5938 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5939
5940 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5941
e10ac9f1
MR
59422011-06-12 Martin Rudalics <rudalics@gmx.at>
5943
5944 * frame.c (make_frame): Call other_buffer_safely instead of
5945 other_buffer.
5946
5947 * window.c (temp_output_buffer_show): Call display_buffer with
5948 second argument Vtemp_buffer_show_specifiers and reset latter
5949 immediately after the call.
5950 (Vtemp_buffer_show_specifiers): New variable.
5951 (auto_window_vscroll_p, next_screen_context_lines)
5952 (Vscroll_preserve_screen_position): Remove leading asterisks from
5953 doc-strings.
5954
2d3c217e 59552011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5956
7b7f97e8 5957 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5958 * buffer.c (Qclone_number): Remove for now, as it's unused.
5959 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5960 (record_buffer): Remove unused local.
5961 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5962 (set_frame_buffer_list): Remove; unused.
5963 * frame.h (other_visible_frames): Remove decl.
5964 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5965 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5966 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5967 if HAVE_GPM.
5968 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5969 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5970 Define only if HAVE_GPM.
5971 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5972 (update_hints_inhibit): Remove; never set. All uses removed.
5973 * widgetprv.h (emacsFrameClassRec): Remove decl.
5974 * window.c (delete_deletable_window): Now returns void, since it
5975 wasn't returning anything.
5976 (compare_window_configurations): Remove unused locals.
5977 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5978 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5979 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5980 the same widths as pointers. This follows up on the 2011-05-06 patch.
5981 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5982 * xterm.h: Likewise.
5983 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5984
1384b89e
JB
59852011-06-12 Juanma Barranquero <lekktu@gmail.com>
5986
5987 * makefile.w32-in: Update dependencies.
5988 (LISP_H): Add lib/intprops.h.
5989
1100a63c
CY
59902011-06-11 Chong Yidong <cyd@stupidchicken.com>
5991
5992 * image.c (gif_load): Add animation frame delay to the metadata.
5993 (syms_of_image): Use DEFSYM. New symbol `delay'.
5994
6198ccd0
MR
59952011-06-11 Martin Rudalics <rudalics@gmx.at>
5996
5997 * window.c (delete_deletable_window): Re-add.
5998 (Fset_window_configuration): Rewrite to handle dead buffers and
5999 consequently deletable windows.
6000 (window_tree, Fwindow_tree): Remove. Supply functionality in
6001 window.el.
6002 (compare_window_configurations): Simplify code.
6003
b6e3633c
AS
60042011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6005
1ab0dee5
AS
6006 * image.c (imagemagick_load_image): Fix type mismatch.
6007 (Fimagemagick_types): Likewise.
6008
b6e3633c
AS
6009 * window.h (replace_buffer_in_windows): Declare.
6010
9397e56f
MR
60112011-06-11 Martin Rudalics <rudalics@gmx.at>
6012
6013 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6014 Qclone_number. Remove external declaration of Qdelete_window.
6015 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6016 code.
640c8776
SM
6017 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6018 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
6019 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6020 buffer list implementation.
6021 (other_buffer_safely): New function.
6022 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6023 calls to replace_buffer_in_windows and
6024 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6025 if allowed.
6026 (record_buffer): Inhibit quitting and rewrite using quittable
6027 functions. Run Qbuffer_list_update_hook if allowed.
6028 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
6029 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6030 Move switch-to-buffer to window.el.
9397e56f
MR
6031 (bury-buffer): Move to window.el.
6032 (Vbuffer_list_update_hook): New variable.
6033
6034 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6035 section.
6036
6037 * window.h (resize_frame_windows): Move up in code.
6038 (Fwindow_frame): Remove EXFUN.
6039 (replace_buffer_in_all_windows): Remove prototype.
6040 (replace_buffer_in_windows_safely): Add prototype.
6041
6042 * window.c: Declare Qdelete_window static again. Move down
6043 declaration of select_count.
6044 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6045 (Fother_window): Move to window.el.
6046 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6047 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6048 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6049 window.el.
6050 (replace_buffer_in_windows): Implement by calling
6051 Qreplace_buffer_in_windows.
6052 (replace_buffer_in_all_windows): Remove with some functionality
6053 moved into replace_buffer_in_windows_safely.
6054 (replace_buffer_in_windows_safely): New function.
6055 (select_window_norecord, select_frame_norecord): Move in front
6056 of run_window_configuration_change_hook. Remove now obsolete
6057 declarations.
640c8776
SM
6058 (Fset_window_buffer): Rewrite doc-string.
6059 Call Qrecord_window_buffer.
9397e56f
MR
6060 (keys_of_window): Move binding for other-window to window.el.
6061
b50691aa
CY
60622011-06-11 Chong Yidong <cyd@stupidchicken.com>
6063
6064 * dispextern.h (struct image): Replace data member, whose int_val
6065 and ptr_val fields were not used by anything, with a single
6066 lisp_val object.
6067
6068 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6069 (gif_clear_image, gif_load, imagemagick_load_image)
6070 (gs_clear_image, gs_load): Callers changed.
6071
3f754b86
PE
60722011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6073
cca69397
PE
6074 * buffer.h: Include <time.h>, for time_t.
6075 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6076
109e28d0
PE
6077 Fix minor problems found by static checking.
6078
60737f02
PE
6079 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6080
4b66faf3
PE
6081 Make identifiers static if they are not used in other modules.
6082 * data.c (Qcompiled_function, Qframe, Qvector):
6083 * image.c (QimageMagick, Qsvg):
6084 * minibuf.c (Qmetadata):
6085 * window.c (resize_window_check, resize_root_window): Now static.
6086 * window.h (resize_window_check, resize_root_window): Remove decls.
6087
109e28d0
PE
6088 * window.c (window_deletion_count, delete_deletable_window):
6089 Remove; unused.
46a4ce9e
PE
6090 (window_body_lines): Now static.
6091 (Fdelete_other_windows_internal): Mark vars as initialized.
6092 Make sure 'resize_failed' is initialized.
6093 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6094 (resize_window_apply): Remove unused local.
6095 * window.h (delete_deletable_window): Remove decl.
6096
109e28d0 6097 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
6098 (imagemagick_load_image): Fix pointer signedness problem by changing
6099 last arg from unsigned char * to char *. All uses changed.
6100 Also, fix a local for similar reasons.
6101 Remove unused locals. Remove locals to avoid shadowing.
6102 (fn_rsvg_handle_free): Remove; unused.
6103 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 6104 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 6105
3f754b86
PE
6106 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6107
2547adb1
CY
61082011-06-10 Chong Yidong <cyd@stupidchicken.com>
6109
6110 * image.c (gif_load): Fix omitted cast error introduced by
6111 2011-06-06 change.
6112
2c8e37d4
MR
61132011-06-10 Martin Rudalics <rudalics@gmx.at>
6114
6115 * window.h (resize_proportionally, orig_total_lines)
6116 (orig_top_line): Remove from window structure.
6117 (set_window_height, set_window_width, change_window_heights)
6118 (Fdelete_window): Remove prototypes.
6119 (resize_frame_windows): Remove duplicate declaration.
6120
440a42e3
EZ
61212011-06-10 Eli Zaretskii <eliz@gnu.org>
6122
6123 * window.h (resize_frame_windows, resize_window_check)
6124 (delete_deletable_window, resize_root_window)
6125 (resize_frame_windows): Declare prototypes.
6126
6127 * window.c (resize_window_apply): Make definition be "static" to
6128 match the prototype.
6129
562dd5e9
MR
61302011-06-10 Martin Rudalics <rudalics@gmx.at>
6131
6132 * window.c: Remove declarations of Qwindow_size_fixed,
6133 window_min_size_1, window_min_size_2, window_min_size,
6134 size_window, window_fixed_size_p, enlarge_window, delete_window.
6135 Remove static from declaration of Qdelete_window, it's
6136 temporarily needed by Fbury_buffer.
6137 (replace_window): Don't assign orig_top_line and
6138 orig_total_lines.
6139 (Fdelete_window, delete_window): Remove. Window deletion is
6140 handled by window.el.
640c8776
SM
6141 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6142 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
6143 (Fdelete_other_windows): Remove. Deleting other windows is
6144 handled by window.el.
6145 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6146 handled in window.el.
6147 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6148 Window minimum sizes are handled in window.el.
6149 (shrink_windows, size_window, set_window_height)
6150 (set_window_width, change_window_heights, window_height)
6151 (window_width, CURBEG, CURSIZE, enlarge_window)
6152 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6153 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6154 handled in window.el.
6155 (make_dummy_parent): Rename to make_parent_window and give it a
6156 second argument horflag.
6157 (make_window): Don't set resize_proportionally any more.
6158 (Fsplit_window): Remove. Windows are split in window.el.
6159 (save_restore_action, save_restore_orig_size)
6160 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6161 Resize mini windows in window.el.
6162 (grow_mini_window, shrink_mini_window): Implement by calling
6163 Qresize_root_window_vertically, resize_window_check and
6164 resize_window_apply.
640c8776
SM
6165 (saved_window, Fset_window_configuration, save_window_save):
6166 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6167 resize_proportionally.
6168 (window_min_height, window_min_width): Move to window.el.
6169 (keys_of_window): Move bindings for delete-other-windows,
6170 split-window, delete-window and enlarge-window to window.el.
6171
6172 * buffer.c: Temporarily extern Qdelete_window.
6173 (Fbury_buffer): Temporarily call Qdelete_window instead of
6174 Fdelete_window (Fbury_buffer will move to window.el soon).
6175
6176 * frame.c (set_menu_bar_lines_1): Remove code handling
6177 orig_top_line and orig_total_lines.
6178
6179 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6180 set_window_height but set heights directly.
6181 (change_frame_size_1): Use resize_frame_windows.
6182
6183 * xdisp.c (init_xdisp): Don't use set_window_height but set
6184 heights directly.
6185
640c8776
SM
6186 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6187 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6188 run_window_configuration_change_hook.
6189
6190 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6191 instead of change_window_heights and run
6192 run_window_configuration_change_hook.
6193
1a13852e
MR
61942011-06-09 Martin Rudalics <rudalics@gmx.at>
6195
6196 * window.c (replace_window): Rename second argument REPLACEMENT to
6197 NEW. New third argument SETFLAG. Rewrite.
6198 (delete_window, make_dummy_parent): Call replace_window with
6199 third argument 1.
6200 (window_list_1): Move down in code.
6201 (run_window_configuration_change_hook): Move set_buffer part
6202 before select_frame_norecord part in order to unwind correctly.
6203 Rename count1 to count.
6204 (recombine_windows, delete_deletable_window, resize_root_window)
6205 (Fdelete_other_windows_internal)
6206 (Frun_window_configuration_change_hook, make_parent_window)
6207 (resize_window_check, resize_window_apply, Fresize_window_apply)
6208 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6209 (Fdelete_window_internal, Fresize_mini_window_internal):
6210 New functions.
1a13852e
MR
6211 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6212
f3d1777e
MR
62132011-06-08 Martin Rudalics <rudalics@gmx.at>
6214
496e208e
MR
6215 * window.h (window): Add some new members to window structure -
6216 normal_lines, normal_cols, new_total, new_normal, clone_number,
6217 splits, nest, prev_buffers, next_buffers.
6218 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6219 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6220
f3d1777e
MR
6221 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6222 Remove.
496e208e
MR
6223 (make_dummy_parent): Set new members of windows structure.
6224 (make_window): Move down in code. Handle new members of window
6225 structure.
6226 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6227 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6228 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6229 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6230 (Fset_window_next_buffers, Fset_window_clone_number):
6231 New functions.
496e208e
MR
6232 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6233 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6234 Doc-string fixes.
6235 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6236 Argument WINDOW can be now internal window too.
6237 (Fwindow_use_time): Move up in code.
6238 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6239 Rewrite doc-string.
6240 (Fset_window_configuration, saved_window)
6241 (Fcurrent_window_configuration, save_window_save): Handle new
6242 members of window structure.
b9e809c2
MR
6243 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6244 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6245 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6246 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6247 Qget_mru_window, Qresize_root_window,
6248 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6249 Qauto_buffer_name; staticpro them.
f3d1777e 6250
abde8f8c
MR
62512011-06-07 Martin Rudalics <rudalics@gmx.at>
6252
6253 * window.c (Fwindow_total_size, Fwindow_left_column)
6254 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6255 (Fwindow_list_1): New functions.
6256 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6257 (Fwindow_width, Fscroll_left, Fscroll_right):
6258 Use window_body_cols instead of window_box_text_cols.
6259 (delete_window, Fset_window_configuration):
6260 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6261 (delete_all_subwindows): Take a window as argument and not a
6262 structure. Rewrite.
190b47e6
MR
6263 (window_loop): Remove handling of GET_LRU_WINDOW and
6264 GET_LARGEST_WINDOW.
6265 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6266
6267 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6268 window_box_text_cols. delete_all_subwindows now takes a
6269 Lisp_Object as argument.
abde8f8c 6270
640c8776
SM
6271 * indent.c (compute_motion, Fcompute_motion):
6272 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6273
fa8a67e6
MR
6274 * frame.c (delete_frame): Call delete_all_subwindows with root
6275 window as argument.
6276
a54e3482
DC
62772011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6278
6279 * fns.c (Fputhash): Document return value.
6280
60002bf5
CY
62812011-06-06 Chong Yidong <cyd@stupidchicken.com>
6282
6283 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6284
0c671da6 62852011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6286
b862a52a 6287 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6288
be44ca6c
PE
6289 Check for overflow when converting integer to cons and back.
6290 * charset.c (Fdefine_charset_internal, Fdecode_char):
6291 Use cons_to_unsigned to catch overflow.
6292 (Fencode_char): Use INTEGER_TO_CONS.
6293 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6294 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6295 * data.c (long_to_cons, cons_to_long): Remove.
6296 (cons_to_unsigned, cons_to_signed): New functions.
6297 These signal an error for invalid or out-of-range values.
6298 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6299 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6300 * font.c (Ffont_variation_glyphs):
6301 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6302 * lisp.h: Include <intprops.h>.
6303 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6304 (cons_to_signed, cons_to_unsigned): New decls.
6305 (long_to_cons, cons_to_long): Remove decls.
6306 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6307 (Fprimitive_undo): Use CONS_TO_INTEGER.
6308 * xfns.c (Fx_window_property): Likewise.
6309 * xselect.c: Include <limits.h>.
6310 (x_own_selection, selection_data_to_lisp_data):
6311 Use INTEGER_TO_CONS.
6312 (x_handle_selection_request, x_handle_selection_clear)
6313 (x_get_foreign_selection, Fx_disown_selection_internal)
6314 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6315 (lisp_data_to_selection_data): Use cons_to_unsigned.
6316 (x_fill_property_data): Use cons_to_signed.
6317 Report values out of range.
6318
d1f3d2af
PE
6319 Check for buffer and string overflow more precisely.
6320 * buffer.h (BUF_BYTES_MAX): New macro.
6321 * lisp.h (STRING_BYTES_MAX): New macro.
6322 * alloc.c (Fmake_string):
6323 * character.c (string_escape_byte8):
6324 * coding.c (coding_alloc_by_realloc):
6325 * doprnt.c (doprnt):
6326 * editfns.c (Fformat):
6327 * eval.c (verror):
6328 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6329 since they may not be the same number.
6330 * editfns.c (Finsert_char):
6331 * fileio.c (Finsert_file_contents):
6332 Likewise for BUF_BYTES_MAX.
6333
dd52fcea
PE
6334 * image.c: Use ptrdiff_t, not int, for sizes.
6335 (slurp_file): Switch from int to ptrdiff_t.
6336 All uses changed.
6337 (slurp_file): Check that file size fits in both size_t (for
6338 malloc) and ptrdiff_t (for sanity and safety).
6339
7f9bbdbb
PE
6340 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6341 if b->modtime has its maximal value.
6342
dfe18f82
PE
6343 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6344
84acfcf0
PE
6345 Don't assume time_t can fit into int.
6346 * buffer.h (struct buffer.modtime): Now time_t, not int.
6347 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6348 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6349
ccd9a01a
PE
6350 Minor fixes for signed vs unsigned integers.
6351 * character.h (MAYBE_UNIFY_CHAR):
6352 * charset.c (maybe_unify_char):
6353 * keyboard.c (read_char, reorder_modifiers):
6354 XINT -> XFASTINT, since the integer must be nonnegative.
6355 * ftfont.c (ftfont_spec_pattern):
6356 * keymap.c (access_keymap, silly_event_symbol_error):
6357 XUINT -> XFASTINT, since the integer must be nonnegative.
6358 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6359 since it makes no difference and we prefer signed.
6360 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6361 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6362 nonnegative.
6363
d6d100dd
SM
63642011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6365
6366 * window.h (Fwindow_frame): Declare.
6367
2b6148e4
PE
63682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6369
6370 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6371 (SPARE_MEMORY): Always define.
6372 (LARGE_REQUEST): Remove.
6373 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6374
f230ecc9
MR
63752011-06-06 Martin Rudalics <rudalics@gmx.at>
6376
727e958e
MR
6377 * lisp.h: Move EXFUNS for Fframe_root_window,
6378 Fframe_first_window and Fset_frame_selected_window to window.h.
6379
6380 * window.h: Move EXFUNS for Fframe_root_window,
6381 Fframe_first_window and Fset_frame_selected_window here from
6382 lisp.h.
6383
6384 * frame.c (Fwindow_frame, Fframe_first_window)
6385 (Fframe_root_window, Fframe_selected_window)
6386 (Fset_frame_selected_window): Move to window.c.
6387 (Factive_minibuffer_window): Move to minibuf.c.
6388 (Fother_visible_frames_p): New function.
6389
6390 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6391
f230ecc9
MR
6392 * window.c (decode_window, decode_any_window): Move up in code.
6393 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6394 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6395 (Fwindow_buffer): Move up and rewrite doc-string.
6396 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6397 (Fwindow_prev): New functions.
727e958e
MR
6398 (Fwindow_frame): Move here from frame.c. Accept any window as
6399 argument.
6400 (Fframe_root_window, Fframe_first_window)
6401 (Fframe_selected_window): Move here from frame.c. Accept frame
6402 or arbitrary window as argument. Update doc-strings.
6403 (Fminibuffer_window): Move up in code.
6404 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6405 (Fset_frame_selected_window): Move here from frame.c.
6406 Marginal rewrite.
727e958e
MR
6407 (Fselected_window, select_window, Fselect_window): Move up in
6408 code. Minor doc-string fixes.
f230ecc9 6409
4d09bcf6
PE
64102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6411
6412 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6413 Do not assume that spare memory exists; that assumption is valid
6414 only if SYSTEM_MALLOC.
6415 (LARGE_REQUEST): New macro, so that the issue of large requests
6416 is separated from the issue of spare memory.
6417
810928a2
AS
64182011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6419
172418ad
AS
6420 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6421 format. (Bug#8806)
6422
43f862f7
AS
6423 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6424
810928a2
AS
6425 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6426 before statements.
6427
a059fe24
JD
64282011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6429
6430 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6431
6432 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6433
6434 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6435 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6436
989bf368
JB
64372011-06-05 Juanma Barranquero <lekktu@gmail.com>
6438
6439 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6440
4b80f674
CY
64412011-06-04 Chong Yidong <cyd@stupidchicken.com>
6442
6443 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6444 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6445 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6446 New error handlers.
4b80f674
CY
6447 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6448 Obey Vx_select_enable_clipboard_manager. Catch errors in
6449 x_clipboard_manager_save (Bug#8779).
6450 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6451 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6452
99a33b77 64532011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6454
6455 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6456
99a33b77 64572011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6458
6459 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6460 in the current matrix if keep_current_p is non-zero.
6461
8264569d
EZ
64622011-06-04 Eli Zaretskii <eliz@gnu.org>
6463
6464 * bidi.c (bidi_level_of_next_char): Fix last change.
6465
57f97249
EZ
64662011-06-03 Eli Zaretskii <eliz@gnu.org>
6467
fec2107c 6468 Support bidi reordering of text covered by display properties.
57f97249 6469
fec2107c
EZ
6470 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6471 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6472 (bidi_cache_search, bidi_cache_iterator_state)
6473 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6474 (bidi_level_of_next_char, bidi_move_to_visually_next):
6475 Support character positions inside a run of characters covered by a
fec2107c
EZ
6476 display string.
6477 (bidi_paragraph_init, bidi_resolve_explicit_1)
6478 (bidi_level_of_next_char): Call bidi_fetch_char and
6479 bidi_fetch_char_advance instead of FETCH_CHAR and
6480 FETCH_CHAR_ADVANCE.
6481 (bidi_init_it): Initialize new members.
6482 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6483 definitions.
6484 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6485 instead of using explicit *_CHAR codes.
d6d100dd
SM
6486 (bidi_resolve_explicit, bidi_resolve_weak):
6487 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6488 bidirectional text is supported only in multibyte buffers.
6489 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6490 it to initialize the frame_window_p member of struct bidi_it.
6491 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6492 (bidi_resolve_explicit, bidi_resolve_weak)
6493 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6494 bidi_it->nchars is non-positive.
6495 (bidi_level_of_next_char): Don't try to lookup the cache for the
6496 next/previous character if nothing is cached there yet, or if we
6497 were just reseat()'ed to a new position.
c40e2fb2 6498
0e14fe90
EZ
6499 * xdisp.c (set_cursor_from_row): Set start and stop points
6500 according to the row's direction when priming the loop that looks
6501 for the glyph on which to display cursor.
6502 (single_display_spec_intangible_p): Function deleted.
6503 (display_prop_intangible_p): Reimplement to call
6504 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6505 Accept 3 additional arguments needed by handle_display_spec.
6506 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6507 values: lists, `(when COND...)' forms, etc.
6508 (single_display_spec_string_p): Support property values that are
6509 lists with the argument STRING its top-level element.
6510 (display_prop_string_p): Fix the condition for processing a
6511 property that is a list to be consistent with handle_display_spec.
fec2107c 6512 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6513 last portion of handle_display_prop.
6514 (compute_display_string_pos): Accept additional argument
6515 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6516 value of a `display' property is a "replacing spec".
6517 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6518 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6519 the display property, but just return a value indicating whether
6520 the display property will replace the characters it covers.
6521 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6522 frame_window_p members of struct bidi_it.
d6d100dd
SM
6523 (compute_display_string_pos, compute_display_string_end):
6524 New functions.
fec2107c
EZ
6525 (push_it): Accept second argument POSITION, where pop_it should
6526 jump to continue iteration.
6527 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6528
fec2107c
EZ
6529 * keyboard.c (adjust_point_for_property): Adjust the call to
6530 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6531
6532 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6533 (bidi_init_it): Update prototypes.
6534 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6535 (compute_display_string_pos, compute_display_string_end):
6536 Declare prototypes.
fec2107c
EZ
6537 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6538 EMACS_INT.
fc6f18ce 6539
40087514 65402011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6541
57f53182
PE
6542 Malloc failure behavior now depends on size of allocation.
6543 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6544 * lisp.h: Change signatures accordingly.
6545 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6546 All callers changed. (Bug#8762)
6547
6548 * gnutls.c: Use Emacs's memory allocators.
6549 Without this change, the gnutls library would invoke malloc etc.
6550 directly, which causes problems on non-SYNC_INPUT hosts, and which
6551 runs afoul of improving memory_full behavior. (Bug#8761)
6552 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6553 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6554 xfree instead of the default malloc, realloc, free.
6555 (Fgnutls_boot): No need to check for memory allocation failure,
6556 since xmalloc does that for us.
6557
ac32cd99 6558 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6559 * category.c (hash_get_category_set):
6560 * ccl.c (ccl_driver):
6561 * charset.c (Fdefine_charset_internal):
6562 * charset.h (struct charset.hash_index):
6563 * composite.c (get_composition_id, gstring_lookup_cache)
6564 (composition_gstring_put_cache):
6565 * composite.h (struct composition.hash_index):
6566 * dispextern.h (struct image.hash):
6567 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6568 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6569 (hashfn_equal, hashfn_user_defined, make_hash_table)
6570 (maybe_resize_hash_table, hash_lookup, hash_put)
6571 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6572 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6573 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6574 * image.c (make_image, search_image_cache, lookup_image)
6575 (xpm_put_color_table_h):
6576 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6577 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6578 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6579 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6580 * alloc.c (allocate_vectorlike):
6581 Check for overflow in vector size calculations.
6582 * ccl.c (ccl_driver):
6583 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6584 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6585 need to be updated by these changes.
40087514
PE
6586 * fns.c (make_hash_table, maybe_resize_hash_table):
6587 Check for integer overflow with large hash tables.
0de4bb68
PE
6588 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6589 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6590 (SXHASH_REDUCE): New macro.
6591 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6592 Use it instead of discarding useful hash info with large hash values.
6593 (sxhash_float): New function.
6594 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6595 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6596 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6597 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6598 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6599 Adjust signatures to match updated version of code.
6600 (consing_since_gc): Now EMACS_INT, since a single hash table can
6601 use more than INT_MAX bytes.
6602
698d32e2
DN
66032011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6604
6605 Make it possible to build with GCC-4.6+ -O2 -flto.
6606
6607 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6608
fd6fa53f
SM
66092011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6610
6611 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6612 Call minibuffer-inactive-mode.
6613
864db017
JB
66142011-05-31 Juanma Barranquero <lekktu@gmail.com>
6615
6616 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6617 Update dependencies.
6618
2ad0baf4
DN
66192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6620
6621 * data.c (init_data): Remove code for UTS, this system is not
6622 supported anymore.
6623
4fcc2638
DN
66242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6625
6626 Don't force ./temacs to start in terminal mode.
6627
6628 * frame.c (make_initial_frame): Initialize faces in all cases, not
6629 only when CANNOT_DUMP is defined.
6630 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6631
c56e0fd5
DN
66322011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6633
6634 * dispnew.c (add_window_display_history): Use const for the string
6635 pointer. Remove declaration, not needed.
6636
333d54da 66372011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6638
55d4c1b2 6639 Use 'inline', not 'INLINE'.
333d54da 6640 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6641 * alloc.c, fontset.c (INLINE): Remove.
6642 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6643 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6644 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6645 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6646 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6647
738db178
DN
66482011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6649
6650 Make it possible to run ./temacs.
6651
6652 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6653 syms_of_callproc does the same thing. Remove test for
6654 "initialized", do it in the caller.
6655 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6656
620c53a6
SM
66572011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6658
6659 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6660 (read_minibuf): Use get_minibuffer.
6661 (syms_of_minibuf): Use DEFSYM.
6662 (Qmetadata): New var.
6663 * data.c (Qbuffer): Don't make it static.
6664 (syms_of_data): Use DEFSYM.
6665
e003a292
PE
66662011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6667
6668 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6669 (CCL_CODE_MIN): New macro.
6670
ed008a6d
PE
66712011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6672
3687c2ef
PE
6673 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6674
ed008a6d
PE
6675 * eval.c (Qdebug): Now static.
6676 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6677 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6678 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6679
d66c4c7c
CY
66802011-05-29 Chong Yidong <cyd@stupidchicken.com>
6681
6682 * image.c: Various fixes to ImageMagick code comments.
6683 (Fimagemagick_types): Doc fix.
6684
5fbc2025
PE
66852011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6686
0196f88a
PE
6687 Minor fixes prompted by GCC 4.6.0 warnings.
6688
6689 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6690
5fbc2025
PE
6691 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6692 (x_clipboard_manager_save_all): Move extern decl to ...
6693 * xterm.h: ... here, so that it can be checked for consistency.
6694
1dd3c2d9
CY
66952011-05-29 Chong Yidong <cyd@stupidchicken.com>
6696
6697 * xselect.c (x_clipboard_manager_save_frame)
6698 (x_clipboard_manager_save_all): New functions.
6699 (Fx_clipboard_manager_save): Lisp function deleted.
6700
6701 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6702 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6703
6704 * xterm.h: Update prototype.
6705
5ba6571d
WX
67062011-05-28 William Xu <william.xwl@gmail.com>
6707
6708 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6709 exiting (Bug#8239).
6710
3eaff834
JM
67112011-05-28 Jim Meyering <meyering@redhat.com>
6712
e1900994 6713 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6714 * fns.c (to_uchar): Define.
6715 (crypto_hash_function): Use it to convert some newly-signed
6716 variables to unsigned, to avoid sign-extension bugs. For example,
6717 without this change, (md5 "truc") would evaluate to
6718 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6719 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6720 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6721
0f6990a7
PE
67222011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6723
6724 Integer overflow fixes.
c8a9ca5a 6725
08686060
PE
6726 * dbusbind.c: Serial number integer overflow fixes.
6727 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6728 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6729 to hold a serial number that is too large for a fixnum.
6730 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6731 Check for serial numbers out of range. Decode any serial number
59568bf0 6732 that was so large that it became a float. (Bug#8722)
08686060 6733
2d1fc3c7
PE
6734 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6735 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6736 Use XFASTINT rather than XUINT when numbers are nonnegative.
6737 (xd_append_arg, Fdbus_method_return_internal):
6738 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6739 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6740 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6741 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6742 (Bug#8722)
2d1fc3c7 6743
c8a9ca5a
PE
6744 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6745
519e1d69
PE
6746 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6747
6df6ae42 6748 ccl: Add integer overflow checks.
30569699
PE
6749 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6750 (IN_INT_RANGE): New macros.
6751 (ccl_driver): Use them to check for integer overflow when
6752 decoding a CCL program. Many of the new checks are whether XINT (x)
6753 fits in int; it doesn't always, on 64-bit hosts. The new version
6754 doesn't catch all possible integer overflows, but it's an
847044ea 6755 improvement. (Bug#8719)
30569699 6756
c11285dc
PE
6757 * alloc.c (make_event_array): Use XINT, not XUINT.
6758 There's no need for unsigned here.
6759
fdccd48e
PE
6760 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6761 This follows up to the 2011-05-06 change that substituted uintptr_t
6762 for EMACS_INT. This case wasn't caught back then.
6763
37910ab2
PE
6764 Rework Fformat to avoid integer overflow issues.
6765 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6766 now (part of C89). Include <verify.h>.
6767 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6768 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6769 (Fformat): Avoid the prepass trying to compute sizes; it was only
6770 approximate and thus did not catch overflow reliably. Instead, walk
6771 through the format just once, formatting and computing sizes as we go,
6772 checking for integer overflow at every step, and allocating a larger
6773 buffer as needed. Keep track separately whether the format is
6774 multibyte. Keep only the most-recently calculated precision, rather
6775 than them all. Record whether each argument has been converted to
6776 string. Use EMACS_INT, not int, for byte and char and arg counts.
6777 Support field widths and precisions larger than INT_MAX. Avoid
6778 sprintf's undefined behavior with conversion specifications such as %#d
6779 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6780 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6781 formatting out-of-range floating point numbers with int
9173deec 6782 formats. (Bug#8668)
37910ab2 6783
2e6578fb
PE
6784 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6785
0ae6bdee
PE
6786 * data.c: Avoid integer truncation in expressions involving floats.
6787 * data.c: Include <intprops.h>.
6788 (arith_driver): When there's an integer overflow in an expression
6789 involving floating point, convert the integers to floating point
6790 so that the resulting value does not suffer from catastrophic
6791 integer truncation. For example, on a 64-bit host (* 4
6792 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6793 Do not rely on undefined behavior after integer overflow.
6794
de883a70
PE
6795 merge count_size_as_multibyte, parse_str_to_multibyte
6796 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6797 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6798 Check for integer overflow.
6799 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6800 since it's now a duplicate of the other. This is more of
6801 a character than a buffer op, so better that it's in character.c.
6802 * fns.c, print.c: Adjust to above changes.
6803
2ff916cb
PE
68042011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6805
6806 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6807
f1b54466
PE
68082011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6809
fb1ac845
PE
6810 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6811 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6812 (x_clipboard_manager_save): Now static.
6813 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6814
f1b54466
PE
6815 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6816 (crypto_hash_function): Now static.
6817 Fix pointer signedness problems. Avoid unnecessary initializations.
6818
a9f737ee
CY
68192011-05-27 Chong Yidong <cyd@stupidchicken.com>
6820
6821 * termhooks.h (Vselection_alist): Make it terminal-local.
6822
6823 * terminal.c (create_terminal): Initialize it.
6824
6825 * xselect.c: Support for clipboard managers.
6826 (Vselection_alist): Move to termhooks.h as terminal-local var.
6827 (LOCAL_SELECTION): New macro.
6828 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6829 (symbol_to_x_atom): Remove gratuitous arg.
6830 (x_handle_selection_request, lisp_data_to_selection_data)
6831 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6832 (x_own_selection, x_get_local_selection, x_convert_selection):
6833 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6834 (some_frame_on_display): Delete unused function.
6835 (Fx_own_selection_internal, Fx_get_selection_internal)
6836 (Fx_disown_selection_internal, Fx_selection_owner_p)
6837 (Fx_selection_exists_p): New optional frame arg.
6838 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6839 (x_handle_selection_clear): Don't treat other terminals with the
6840 same keyboard specially. Use the terminal-local Vselection_alist.
6841 (x_clear_frame_selections): Use Frun_hook_with_args.
6842
6843 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6844
6845 * xterm.h: Add support for those atoms.
6846
e067f0c1
CY
68472011-05-26 Chong Yidong <cyd@stupidchicken.com>
6848
6849 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6850 (converted_selections, conversion_fail_tag): New global variables.
6851 (x_selection_request_lisp_error): Free the above.
6852 (x_get_local_selection): Remove unnecessary code.
6853 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6854 of converted selections stored in converted_selections.
6855 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6856 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6857 (x_convert_selection): New function.
6858 (x_handle_selection_event): Simplify.
6859 (x_get_foreign_selection): Don't ignore incoming requests while
6860 waiting for an answer; this will fail when we implement
6861 SAVE_TARGETS, and seems unnecessary anyway.
6862 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6863 (Vx_sent_selection_functions): Doc fix.
6864
0f4aebc0
LL
68652011-05-26 Leo Liu <sdl.web@gmail.com>
6866
6867 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6868
e61124cd
YM
68692011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6870
6871 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6872
6873 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6874 for fringe update if it has periodic bitmap.
ac389d0c 6875 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6876 and fringe_bitmap_periodic_p.
6877
6878 * fringe.c (get_fringe_bitmap_data): New function.
6879 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6880 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6881 row. Mark glyph row for fringe update if periodicity changed.
6882
6883 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6884 for fringe update unless it has periodic bitmap.
6885
f16d9837
KH
68862011-05-25 Kenichi Handa <handa@m17n.org>
6887
6888 * xdisp.c (get_next_display_element): Set correct it->face_id for
6889 a static composition.
6890
e1b90ef6
LL
68912011-05-24 Leo Liu <sdl.web@gmail.com>
6892
6893 * deps.mk (fns.o):
6894 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6895
6896 * fns.c (crypto_hash_function, Fsha1): New function.
6897 (Fmd5): Use crypto_hash_function.
6898 (syms_of_fns): Add Ssha1.
6899
7400048f
PE
69002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6901
6902 * gnutls.c: Remove unused macros.
6903 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6904 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6905 Remove macros that are defined and never used.
6906 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6907
abb71cf4
CY
69082011-05-22 Chong Yidong <cyd@stupidchicken.com>
6909
6910 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6911 (Fx_get_selection_internal): Minor cleanup.
6912 (Fx_own_selection_internal): Rename arguments for consistency with
6913 select.el.
6914
6307db39
PE
69152011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6916
6917 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6918
f3d4e0a4
CY
69192011-05-22 Chong Yidong <cyd@stupidchicken.com>
6920
6921 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6922
4d8ade89
YM
69232011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6924
6925 * dispnew.c (scrolling_window): Don't exclude the case that the
6926 last enabled row in the desired matrix touches the bottom boundary.
6927
32078c8d
GM
69282011-05-21 Glenn Morris <rgm@gnu.org>
6929
6930 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6931 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6932 and add some more files.
32078c8d 6933
7285dc67
EZ
69342011-05-20 Eli Zaretskii <eliz@gnu.org>
6935
6936 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6937 report_file_error introduced by the change from 2011-05-07.
6938
89d1bd22
PE
69392011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6940
6941 * systime.h (Time): Define only if emacs is defined.
6942 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6943 where the include path doesn't have X11/X.h by default. See
6944 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6945
cd394be1 69462011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6947
6948 * composite.c (find_automatic_composition): Fix previous change.
6949
b9704ad9
GM
69502011-05-20 Glenn Morris <rgm@gnu.org>
6951
6952 * lisp.mk: New file, split from Makefile.in.
6953 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6954 (shortlisp): Remove.
6955 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6956
4a720484
GM
69572011-05-19 Glenn Morris <rgm@gnu.org>
6958
6959 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6960 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6961 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6962 (lisp): Set the order to that of loadup.el.
6963 (shortlisp): Make it a copy of $lisp.
6964 (SOME_MACHINE_LISP): Remove.
6965 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6966 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6967
a28d4396
KH
69682011-05-18 Kenichi Handa <handa@m17n.org>
6969
6970 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6971 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6972 (find_automatic_composition): Mostly rewrite for efficiency.
6973
a2b1fa8e
JB
69742011-05-18 Juanma Barranquero <lekktu@gmail.com>
6975
6976 * makefile.w32-in: Update dependencies.
6977
8e1f5610
CS
69782011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6979
6980 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6981 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6982
7025ee00 69832011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6984
cdfa6eab
PE
6985 Fix some integer overflow issues, such as string length overflow.
6986
06d6db33
PE
6987 * insdel.c (count_size_as_multibyte): Check for string overflow.
6988
2b4560a8
PE
6989 * character.c (lisp_string_width): Check for string overflow.
6990 Use EMACS_INT, not int, for string indexes and lengths; in
6991 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6992 the resulting string length overflows an EMACS_INT; instead,
6993 report a string overflow if no precision given. When checking for
6994 precision exhaustion, use a check that cannot possibly have
6995 integer overflow. (Bug#8675)
6996 * character.h (lisp_string_width): Adjust to new signature.
6997
cb93f9be
PE
6998 * alloc.c (string_overflow): New function.
6999 (Fmake_string): Use it. This doesn't change behavior, but saves
7000 a few bytes and will simplify future changes.
7001 * character.c (string_escape_byte8): Likewise.
7002 * lisp.h (string_overflow): New decl.
7003
1a1f3366
PE
7004 Fixups, following up to the user-interface timestamp change.
7005 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7006 for UI timestamps, instead of unsigned long.
9fbd6841
PE
7007 * msdos.c (mouse_get_pos): Likewise.
7008 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
7009 * w32gui.h (Time): Define by including "systime.h" rather than by
7010 declaring it ourselves. (Bug#8664)
7011
d4e3e4d3
PE
7012 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7013 * image.c (clear_image_cache): Likewise.
7014
f6a24d19
PE
7015 * term.c (term_mouse_position): Don't assume time_t wraparound.
7016
08dc5ae6
PE
7017 Be more systematic about user-interface timestamps.
7018 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
7019 and sometimes 'EMACS_UINT', to represent these timestamps.
7020 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
7021 This makes the code easier to follow, and makes it easier to catch
7022 integer overflow bugs such as Bug#8664.
7023 * frame.c (Fmouse_position, Fmouse_pixel_position):
7024 Use Time, not unsigned long, for user-interface timestamps.
7025 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7026 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7027 * keyboard.h (last_event_timestamp): Likewise.
7028 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7029 * menu.h (xmenu_show): Likewise.
7030 * term.c (term_mouse_position): Likewise.
7031 * termhooks.h (struct input_event.timestamp): Likewise.
7032 (struct terminal.mouse_position_hook): Likewise.
7033 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7034 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7035 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7036 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7037 what it was before.
7038 * menu.h, termhooks.h: Include "systime.h", for Time.
7039
8e55734a
PE
7040 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7041 Don't assume that the difference between two unsigned long values
7042 can fit into an integer. At this point, we know button_down_time
7043 <= event->timestamp, so the difference must be nonnegative, so
7044 there's no need to cast the result if double-click-time is
7045 nonnegative, as it should be; check that it's nonnegative, just in
7046 case. This bug is triggered when events are more than 2**31 ms
86db42d2 7047 apart (about 25 days). (Bug#8664)
8e55734a 7048
841f1b75 7049 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 7050 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 7051
3e26f69c
PE
7052 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7053 that always fit in int. Use a sentinel instead of a counter, to
7054 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
7055 * frame.h (struct frame): Use int for menu_bar_items_used
7056 instead of EMACS_INT, since it always fits in int.
3e26f69c 7057
5cc152c0
PE
7058 * menu.c (grow_menu_items): Check for int overflow.
7059
d89eb65e
PE
7060 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7061
5235bd3e
PE
7062 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7063 Before, the code was not consistent. These values cannot exceed
7064 2**31 - 1 so there's no need to make them unsigned.
7065 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7066 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7067 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7068 as modifiers.
7069 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7070
bc827e23
PE
7071 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7072 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7073 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7074 presumably because the widths might not match.
7075
78eb494e
PE
7076 * window.c (size_window): Avoid needless test at loop start.
7077
04f2d78b
CB
70782011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7079
7080 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7081
d2fc7e3d 70822011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
7083
7084 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7085
d2fc7e3d 70862011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
7087
7088 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7089 `width' to `bar_area_x' and `bar_area_width', respectively.
7090 (x_scroll_run): Take account of fringe background extension.
7091
04f2d78b
CB
7092 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7093 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
7094 `bar_area_width', respectively.
7095 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7096 background extension.
7097
79b70037
GM
70982011-05-10 Jim Meyering <meyering@redhat.com>
7099
7100 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7101
2f142cc5
JB
71022011-05-10 Juanma Barranquero <lekktu@gmail.com>
7103
7104 * image.c (Finit_image_library): Return t for built-in image types,
7105 like pbm and xbm. (Bug#8640)
7106
57679c86
AS
71072011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7108
7109 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7110
888c9e86
EZ
71112011-05-07 Eli Zaretskii <eliz@gnu.org>
7112
b0512a1d
EZ
7113 * w32console.c (Fset_screen_color): Doc fix.
7114 (Fget_screen_color): New function.
7115 (syms_of_ntterm): Defsubr it.
7116
7285dc67
EZ
7117 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7118 unlink the temporary file if Fcall_process didn't create it in the
7119 first place.
7120 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7121 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
7122 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7123 cue to call_process_cleanup not to close that handle.
7124
4d3fcc8e
BK
71252011-05-07 Ben Key <bkey76@gmail.com>
7126
7127 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7128 one of two shell specific rules, either bootstrap-temacs-CMD or
7129 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7130 to the previous implementation of the bootstrap-temacs rule.
7131 The bootstrap-temacs-CMD rule is similar to the previous
7132 implementation of the bootstrap-temacs rule except that it
7133 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7134 variable.
7135
7136 These changes, along with some changes to nt/configure.bat,
7137 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7138 earlier fix to add support for --cflags and --ldflags options
7139 that include quotes so that it works whether make uses cmd or
7140 sh as the shell.
7141
b4289b64
MA
71422011-05-06 Michael Albinus <michael.albinus@gmx.de>
7143
7144 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7145 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7146 is a constant.
7147 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7148 a string. Handle both cases.
7149 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7150 (Fdbus_register_method): Use Qinvalid_function.
7151
af4c0e28
JB
71522011-05-06 Juanma Barranquero <lekktu@gmail.com>
7153
7154 * makefile.w32-in: Update dependencies.
7155 (LISP_H): Add inttypes.h and stdin.h.
7156 (PROCESS_H): Add unistd.h.
7157
c51453d9
EZ
71582011-05-06 Eli Zaretskii <eliz@gnu.org>
7159
7160 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7161 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7162
8ff0ac3c 71632011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7164
4c4b566b
PE
7165 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7166
aab2b9b5
PE
7167 * term.c (vfatal): Remove stray call to va_end.
7168 It's not needed and the C Standard doesn't allow it here anyway.
7169
c378da0b
PE
7170 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7171 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7172
288b08c7
PE
7173 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7174 bytes.
7175
e3601888
PE
7176 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7177
db6c0e74
PE
7178 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7179
dd5963ea
PE
7180 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7181
88c9450f
PE
7182 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7183
2f9442b8
PE
7184 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7185
c032b5f8
PE
7186 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7187 * charset.c (Fdefine_charset_internal): Don't initialize
7188 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7189 32-bit int (Bug#8600).
a108c10b
PE
7190
7191 * lread.c (read_integer): Be more consistent with string-to-number.
7192 Use string_to_number to do the actual conversion; this avoids
7193 rounding errors and fixes some other screwups. Without this fix,
7194 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7195 (digit_to_number): Move earlier, for benefit of read_integer.
7196 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7197 not a digit in any supported base. (Bug#8602)
a108c10b 7198
ad5f9eea
PE
7199 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7200
aec1708a
PE
7201 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7202 to match comment at start of function. This also removes a
7203 GCC warning about overflow in a 32+64-bit port.
7204
47be4ab5
PE
7205 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7206
371cac43
PE
7207 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7208 Reported by Stefan Monnier in
7209 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7210 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7211 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7212
d01a7826
PE
7213 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7214 (EMACS_UINTPTR): Likewise, with uintptr_t.
7215
7fd47d5c
PE
7216 * lisp.h: Prefer 64-bit EMACS_INT if available.
7217 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7218 on 32-bit hosts that have 64-bit int, so that they can access
7219 large files.
122b0c86
PE
7220 However, temporarily disable this change unless the temporary
7221 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7222
8727937b
PE
7223 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7224
8ac068ac
PE
7225 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7226 This removes an assumption that EMACS_INT and long are the same
7227 width as pointers. The assumption is true for Emacs porting targets
7228 now, but we want to make other targets possible.
7229 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7230 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7231 In the rest of the code, change types of integers that hold casted
7232 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7233 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7234 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7235 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7236 No need to cast type when ORing.
7237 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7238 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7239 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7240 assume EMACS_INT is the same width as char *.
7241 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7242 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7243 Remove no-longer-needed casts.
7244 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7245 (xg_tool_bar_help_callback, xg_make_tool_item):
7246 Use EMACS_INTPTR to hold an integer
7247 that will be cast to void *; this can avoid a GCC warning
7248 if EMACS_INT is not the same width as void *.
7249 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7250 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7251 (current_message_1, set_message_1):
7252 Use a local to convert to proper width without a cast.
7253 * xmenu.c (dialog_selection_callback): Likewise.
7254
ede49d71
PE
7255 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7256 Also, don't assume VALBITS / RAND_BITS is less than 5,
7257 and don't rely on undefined behavior when shifting a 1 left into
7258 the sign bit.
7259 * lisp.h (get_random): Change signature to match.
7260
2f30ecd0
PE
7261 * lread.c (hash_string): Use size_t, not int, for hash computation.
7262 Normally we prefer signed values; but hashing is special, because
7263 it's better to use unsigned division on hash table sizes so that
7264 the remainder is nonnegative. Also, size_t is the natural width
7265 for hashing into memory. The previous code used 'int', which doesn't
7266 retain enough info to hash well into very large tables.
7267 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7268
2a866e7b
PE
7269 * dbusbind.c: Don't possibly lose pointer info when converting.
7270 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7271 Use XPNTR rather than XHASH, so that the high-order bits of
7272 the pointer aren't lost when converting through void *.
7273
51639eac
PE
7274 * eval.c (Fautoload): Don't double-shift a pointer.
7275
92394119
PE
7276 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7277
dbdb9a7c
JB
72782011-05-06 Juanma Barranquero <lekktu@gmail.com>
7279
7280 * gnutls.c (DEF_GNUTLS_FN):
7281 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7282
db7a0b4f
AS
72832011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7284
7285 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7286 marker. (Bug#8610)
7287
cd394be1 72882011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7289
7290 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7291 New version that can reserve upto 2GB of heap space.
7292
f7ff1b0f 72932011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7294
7295 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7296
639c109b
TZ
72972011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7298
7299 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7300 `gnutls_certificate_set_x509_key_file'.
7301
d2127135
JB
73022011-05-05 Juanma Barranquero <lekktu@gmail.com>
7303
7304 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7305 Update dependencies.
7306
e968f4f3
JB
73072011-05-04 Juanma Barranquero <lekktu@gmail.com>
7308
7309 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7310 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7311 Remove unused parameter `fildes'.
7312 * process.c (read_process_output, send_process): Don't pass it.
7313
84d358f0
JB
73142011-05-04 Juanma Barranquero <lekktu@gmail.com>
7315
7316 Fix previous change: the library cache is defined in w32.c.
7317 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7318 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7319
0898ca10
JB
73202011-05-04 Juanma Barranquero <lekktu@gmail.com>
7321
7322 Implement dynamic loading of GnuTLS on Windows.
7323
7324 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7325 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7326 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7327 Declare.
7328
7329 * gnutls.c (Qgnutls_dll): Define.
7330 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7331 (gnutls_*): Declare function pointers.
7332 (init_gnutls_functions): New function to initialize function pointers.
7333 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7334 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7335 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7336 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7337 (emacs_gnutls_write, emacs_gnutls_read)
7338 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7339 (Fgnutls_available_p): New function.
7340 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7341 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7342 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7343
7344 * image.c: Include w32.h.
7345 (Vimage_type_cache): Delete.
7346 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7347 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7348 (w32_delayed_load): Move to w32.c.
7349
7350 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7351
7352 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7353 (w32_delayed_load): Move from image.c. When loading a library, record
7354 its filename in the :loaded-from property of the library id.
7355 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7356 Initialize and staticpro them.
7357 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7358
7359 * process.c: Include lisp.h before w32.h, not after.
7360 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7361 instead of gnutls_record_check_pending.
7362
7363 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7364
ff4de4aa
TZ
73652011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7366
7367 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7368 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7369 as passed in.
7370
abe95abb
JD
73712011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7372
7373 * xterm.c (x_set_frame_alpha): Do not set property on anything
7374 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7375
e16e55d4
JB
73762011-05-02 Juanma Barranquero <lekktu@gmail.com>
7377
7378 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7379
bafcf6a5
JB
73802011-05-02 Juanma Barranquero <lekktu@gmail.com>
7381
7382 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7383 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7384 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7385 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7386 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7387 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7388 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7389 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7390 (Qgnutls_bootprop_callbacks_verify): Make static.
7391
e7a6747f
AS
73922011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7393
19ed11ba
AS
7394 * callproc.c: Indentation fixup.
7395
e7a6747f 7396 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7397 (wait_for_termination, interruptible_wait_for_termination):
7398 Move after wait_for_termination_1.
e7a6747f 7399
1ef14cb4
LMI
74002011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7401
7402 * sysdep.c (interruptible_wait_for_termination): New function
7403 which is like wait_for_termination, but allows keyboard
7404 interruptions.
7405
7406 * callproc.c (Fcall_process): Add (:file "file") as an option for
7407 the STDOUT buffer.
7408 (Fcall_process_region): Ditto.
7409
330d880c
EZ
74102011-04-30 Eli Zaretskii <eliz@gnu.org>
7411
8db90b73
EZ
7412 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7413 rather than `XVECTOR (FOO)->size'.
7414
330d880c
EZ
7415 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7416 inttypes.h, as a gnulib replacement is used if it not available in
7417 system headers.
7418
15cbd324
EZ
74192011-04-21 Eli Zaretskii <eliz@gnu.org>
7420
7421 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7422 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7423 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7424
7425 * coding.c (coding_alloc_by_realloc): Error out if destination
7426 will grow beyond MOST_POSITIVE_FIXNUM.
7427 (decode_coding_emacs_mule): Abort if there isn't enough place in
7428 charbuf for the composition carryover bytes. Reserve an extra
7429 space for up to 2 characters produced in a loop.
7430 (decode_coding_iso_2022): Abort if there isn't enough place in
7431 charbuf for the composition carryover bytes.
7432
74332011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7434
ae940cca
EZ
7435 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7436 aborting when %lld or %lll format is passed.
7437 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7438 %llo or %llx format is passed. (Bug#8545)
7439
03ab8921
EZ
7440 * window.c (window_scroll_line_based): Use a marker instead of
7441 simple variables to record original value of point. (Bug#7952)
7442
afda1437
EZ
7443 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7444 produced by %s or %c overflows available buffer space. (Bug#8545)
7445
f76dee0c
PE
74462011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7447
7448 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7449 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7450
fdc5744d
JB
74512011-04-28 Juanma Barranquero <lekktu@gmail.com>
7452
7453 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7454
638f053a
JB
74552011-04-28 Juanma Barranquero <lekktu@gmail.com>
7456
7457 * keyboard.c (Qdelayed_warnings_hook): Define.
7458 (command_loop_1): Run `delayed-warnings-hook'
7459 if Vdelayed_warnings_list is non-nil.
7460 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7461 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7462
d178f871
EZ
74632011-04-28 Eli Zaretskii <eliz@gnu.org>
7464
7465 * doprnt.c (doprnt): Don't return value smaller than the buffer
7466 size if the message was truncated. (Bug#8545).
7467
b124fd93
JB
74682011-04-28 Juanma Barranquero <lekktu@gmail.com>
7469
7470 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7471 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7472
e810457d
PE
74732011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7474
7475 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7476
ea51cceb
JB
74772011-04-27 Juanma Barranquero <lekktu@gmail.com>
7478
7479 * makefile.w32-in: Update dependencies.
7480
94dcfacf
EZ
74812011-04-27 Eli Zaretskii <eliz@gnu.org>
7482
7483 Improve `doprnt' and its usage. (Bug#8545)
7484 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7485 `format_end'. Remove support for %l as a conversion specifier.
7486 Don't use xrealloc. Improve diagnostics when the %l size modifier
7487 is used. Update the commentary.
7488
7489 * eval.c (verror): Simplify calculation of size_t.
7490
7491 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7492 messages.
7493
f61f41d7
PE
74942011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7495
7496 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7497 change.
7498
96fb4434
PE
74992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7500
7501 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7502 This makes this file independent of the recent pseudovector change.
7503
671875da 75042011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7505
69e9b5a3
PE
7506 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7507
b5f869a7 7508 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7509 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7510 Remove unused local.
c8926152 7511 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7512
841a1577 7513 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7514 GCC 4.6.0 optimizes based on type-based alias analysis.
7515 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7516 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7517 != &v->size, and therefore "v->size = 1; b->size = 2; return
7518 v->size;" must therefore return 1. This assumption is incorrect
7519 for Emacs, since it type-puns struct Lisp_Vector * with many other
7520 types. To fix this problem, this patch adds a new type struct
f904488f 7521 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7522 and pseudovectors, and helps optimizing compilers not get fooled
7523 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7524 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7525 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7526 the size member.
eab3844f
PE
7527 (XSETPVECTYPE): Rewrite in terms of new macro.
7528 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7529 This is a bit clearer, and further avoids the possibility of
7530 undesirable aliasing.
7531 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7532 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7533 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7534 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7535 (ASIZE): Now uses header.size rather than size.
7536 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7537 to avoid the hassle of writing XVECTOR (foo)->header.size.
7538 (struct vectorlike_header): New type.
eab3844f
PE
7539 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7540 object, to help avoid aliasing.
7541 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7542 (SUBRP): Likewise, since Lisp_Subr is a special case.
7543 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7544 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7545 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7546 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7547 changed to be "header.size" and "header.next".
7548 * buffer.h (struct buffer): Likewise.
7549 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7550 * frame.h (struct frame): Likewise.
7551 * process.h (struct Lisp_Process): Likewise.
7552 * termhooks.h (struct terminal): Likewise.
7553 * window.c (struct save_window_data, struct saved_window): Likewise.
7554 * window.h (struct window): Likewise.
7555 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7556 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7557 * buffer.c (init_buffer_once): Likewise.
7558 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7559 special case.
7560 * process.c (Fformat_network_address): Use local var for size,
7561 for brevity.
7562
0df1eac5
PE
7563 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7564
847ab9d1 7565 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7566 * data.c (atof): Remove decl; no longer used or needed.
7567 (digit_to_number): Move to lread.c.
7568 (Fstring_to_number): Use new string_to_number function, to be
7569 consistent with how the Lisp reader treats infinities and NaNs.
7570 Do not assume that floating-point numbers represent EMACS_INT
7571 without losing information; this is not true on most 64-bit hosts.
7572 Avoid double-rounding errors, by insisting on integers when
7573 parsing non-base-10 numbers, as the documentation specifies.
7574 * lisp.h (string_to_number): New decl, replacing ...
7575 (isfloat_string): Remove.
bc0a5c13 7576 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7577 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7578 appears to have been a coding error. Similarly, do not accept
7579 strings like +-1e0 as floating point numbers. Do not report
7580 overflow for integer overflows unless the base is not 10 which
7581 means we have no simple and reliable way to continue.
7582 Break out the floating-point parsing into a new
7583 function string_to_number, so that Fstring_to_number parses
7584 floating point numbers consistently with the Lisp reader.
04f2d78b 7585 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7586 (E_CHAR, EXP_INT): Remove, replacing with ...
7587 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7588 (string_to_number): New function, replacing isfloat_string.
7589 This function checks for valid syntax and produces the resulting
7590 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7591 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7592 so that overflow for non-base-10 numbers is reported only when
7593 there's no portable and simple way to convert to floating point.
452f4150 7594
67769ffc
PE
7595 * textprop.c (set_text_properties_1): Rewrite for clarity,
7596 and to avoid GCC warning about integer overflow.
7597
c20db43f
PE
7598 * intervals.h (struct interval): Use EMACS_INT for members
7599 where EMACS_UINT might cause problems. See
7600 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7601 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7602 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7603 All uses changed.
37aa2f85
PE
7604 (offset_intervals): Tell GCC not to worry about length overflow
7605 when negating a negative length.
c20db43f 7606
2538aa2f
PE
7607 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7608 (overrun_check_free): Likewise.
7609
f2d3008d
PE
7610 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7611 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7612 word size.
7613
ec8df744
PE
7614 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7615 (gnutls_make_error): Rename local to avoid shadowing.
7616 (gnutls_emacs_global_deinit): ifdef out; not used.
7617 (Fgnutls_boot): Use const for pointer to readonly storage.
7618 Comment out unused local. Fix pointer signedness problems.
7619
640ee02d
PE
7620 * lread.c (openp): Don't stuff size_t into an 'int'.
7621 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7622 about possible signed overflow.
7623
6048fb2a
PE
7624 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7625 (GDK_KEY_g): Don't define if already defined.
7626 (xg_prepare_tooltip): Avoid pointer signedness problem.
7627 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7628
fa3c87e1
PE
7629 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7630 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7631
2172544b
PE
7632 * xfns.c (Fx_window_property): Simplify a bit,
7633 to make a bit faster and to avoid GCC 4.6.0 warning.
7634 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7635
9b821a21
PE
7636 * fns.c (internal_equal): Don't assume size_t fits in int.
7637
3c616cfa
PE
7638 * alloc.c (compact_small_strings): Tighten assertion a little.
7639
c2982e87
PE
7640 Replace pEd with more-general pI, and fix some printf arg casts.
7641 * lisp.h (pI): New macro, generalizing old pEd macro to other
7642 conversion specifiers. For example, use "...%"pI"d..." rather
7643 than "...%"pEd"...".
7644 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7645 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7646 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7647 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7648 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7649 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7650 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7651 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7652 64-bit hosts.
7653 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7654 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7655 * print.c (safe_debug_print, print_object): Likewise.
7656 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7657 to int.
6f04d126
PE
7658 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7659 avoiding the 0 flag, which is not portable.
c2982e87
PE
7660 * process.c (Fmake_network_process): Use pI to avoid cast.
7661 * region-cache.c (pp_cache): Likewise.
7662 * xdisp.c (decode_mode_spec): Likewise.
7663 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7664 behavior on 64-bit hosts with printf arg.
6f04d126 7665 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7666 (x_stop_queuing_selection_requests): Likewise.
7667 (x_get_window_property): Don't truncate byte count to an 'int'
7668 when tracing.
0b432f21 7669
5e073ec7
PE
7670 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7671 here, since it parses constructs like leading '-' and spaces,
7672 which are not wanted; and it overflows with large numbers.
7673 Instead, simply match F[0-9]+, which is what is wanted anyway.
7674
36372bf9
PE
7675 * alloc.c: Remove unportable assumptions about struct layout.
7676 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7677 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7678 (allocate_vectorlike, make_pure_vector): Use the new macros,
7679 plus offsetof, to remove unportable assumptions about struct layout.
7680 These assumptions hold on all porting targets that I know of, but
7681 they are not guaranteed, they're easy to remove, and removing them
7682 makes further changes easier.
7683
0b432f21
PE
7684 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7685 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7686 (string_overrun_cookie): Now const. Use initializers that
7687 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7688 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7689 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7690 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7691 multiple of sizeof (EMACS_INT); it need not be, if
7692 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7693 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7694
895009e1
JB
76952011-04-26 Juanma Barranquero <lekktu@gmail.com>
7696
7697 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7698
6a7a1b0b
TZ
76992011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7700
7701 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7702 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7703 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7704
841a1577 77052011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7706
7707 * lisp.h (Qdebug): List symbol.
895009e1 7708 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7709 * keyboard.c (debug-on-event): New variable.
7710 (handle_user_signal): Break into debugger when debug-on-event
7711 matches the current signal symbol.
7712
f2d3ba6f
DN
77132011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7714
7715 * alloc.c (check_sblock, check_string_bytes)
7716 (check_string_free_list): Convert to standard C.
7717
42ce4c63
TZ
77182011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7719
7720 * w32.c (emacs_gnutls_push): Fix typo.
7721
825cd63c
EZ
77222011-04-25 Eli Zaretskii <eliz@gnu.org>
7723
fb11d64d
EZ
7724 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7725 "cast to pointer from integer of different size".
7726
825cd63c
EZ
7727 Improve doprnt and its use in verror. (Bug#8545)
7728 * doprnt.c (doprnt): Document the set of format control sequences
7729 supported by the function. Use SAFE_ALLOCA instead of always
7730 using `alloca'.
7731
7732 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7733 is one byte too soon. Don't use xrealloc; instead xfree and
7734 xmalloc anew.
7735
e061a11b
TZ
77362011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7737
7738 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7739 callbacks stage.
7740
7741 * gnutls.c: Renamed global_initialized to
7742 gnutls_global_initialized. Added internals for the
7743 :verify-hostname-error, :verify-error, and :verify-flags
7744 parameters of `gnutls-boot' and documented those parameters in the
7745 docstring. Start callback support.
9173deec
JB
7746 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7747 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7748 on error. Return error code.
e061a11b
TZ
7749 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7750 (emacs_gnutls_read): Likewise.
7751 (Fgnutls_boot): Return handshake error code.
7752 (emacs_gnutls_handle_error): New function.
7753 (wsaerror_to_errno): Likewise.
7754
7755 * w32.h (emacs_gnutls_pull): Add prototype.
7756 (emacs_gnutls_push): Likewise.
7757
7758 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7759 (emacs_gnutls_push): Likewise.
7760
77612011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7762
7763 * process.c (wait_reading_process_output): Check if GnuTLS
7764 buffered some data internally if no FDs are set for TLS
7765 connections.
7766
7767 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7768 (LIBS): Link to USER_LIBS.
7769 ($(BLD)/gnutls.$(0)): New target.
7770
fa6996bc
EZ
77712011-04-24 Eli Zaretskii <eliz@gnu.org>
7772
eb35682e
EZ
7773 * xdisp.c (handle_single_display_spec): Rename the
7774 display_replaced_before_p argument into display_replaced_p, to
7775 make it consistent with the commentary. Fix typos in the
7776 commentary.
7777
e2ad650c
EZ
7778 * textprop.c (syms_of_textprop): Remove dead code.
7779 (copy_text_properties): Delete obsolete commentary about an
7780 interface that was deleted long ago. Fix typos in the description
7781 of arguments.
7782
1b2de274
EZ
7783 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7784 to changes in oldXMenu/XMenu.h from 2011-04-16.
7785 <menu_help_message, prev_menu_help_message>: Constify.
7786 (IT_menu_make_room): menu->help_text is now `const char **';
7787 adjust.
7788
7789 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7790 to changes in oldXMenu/XMenu.h from 2011-04-16.
7791 (struct XMenu): Declare `help_text' `const char **'.
7792
7793 * xfaces.c <Qunspecified>: Make extern again.
7794
7795 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7796 required by POSIX.
1b2de274 7797
762b15be
EZ
7798 * doc.c (get_doc_string): Improve the format passed to `error'.
7799
7800 * doprnt.c (doprnt): Improve commentary.
7801
7802 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7803
7804 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7805 them with etags.
7806
f1052e5d
EZ
7807 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7808 changes in globals.h immediately force recompilation.
762b15be
EZ
7809 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7810 $(CURDIR)/s/ms-w32.h.
7811 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7812
fa6996bc
EZ
7813 * character.c (Fchar_direction): Function deleted.
7814 (syms_of_character): Don't defsubr it.
7815 <char-direction-table>: Deleted.
7816
e6c3da20
EZ
78172011-04-23 Eli Zaretskii <eliz@gnu.org>
7818
7819 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7820 * doprnt.c: Include limits.h.
7821 (SIZE_MAX): New macro.
04f2d78b
CB
7822 (doprnt): Return a size_t value. 2nd arg is now size_t.
7823 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7824 Improve overflow protection. Support `l' modifier for integer
7825 conversions. Support %l conversion. Don't assume an EMACS_INT
7826 argument for integer conversions and for %c.
7827
7828 * lisp.h (doprnt): Restore prototype.
7829
7830 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7831 $(SRC)/character.h.
7832
7833 * Makefile.in (base_obj): Add back doprnt.o.
7834
7835 * deps.mk (doprnt.o): Add back prerequisites.
7836 (callint.o): Depend on character.h.
7837
7838 * eval.c (internal_lisp_condition_case): Include the handler
7839 representation in the error message.
7840 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7841 when breaking from the loop.
7842
7843 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7844
7845 * callint.c (Fcall_interactively): When displaying error message
7846 about invalid control letter, pass the character's codepoint, not
7847 a pointer to its multibyte form. Improve display of the character
7848 in octal and display also its hex code.
7849
7850 * character.c (char_string): Use %x to display the (unsigned)
7851 codepoint of an invalid character, to avoid displaying a bogus
7852 negative value.
7853
7854 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7855 `error', not SYMBOL_NAME itself.
7856
7857 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7858 character arguments to `error'.
7859
7860 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7861 to `error' in error message about FINAL_CHAR argument. Make sure
7862 FINAL_CHAR is a character, and use %c when it is passed as
7863 argument to `error'.
7864
4ffd0d6b 78652011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7866
7867 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7868
7869 * w32.c: Include <time.h>.
7870 (sys_localtime): New function.
7871
4ffd0d6b 78722011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7873
7874 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7875
4ffd0d6b 7876 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7877
4ffd0d6b 78782011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7879
4ffd0d6b
GM
7880 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7881 zombies (Bug#8467).
aac0c6e3 7882
04c56954
EZ
78832011-04-19 Eli Zaretskii <eliz@gnu.org>
7884
7885 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7886 gl_state.e_property when gl_state.object is Qt.
7887
7888 * insdel.c (make_gap_larger): Remove limitation of buffer size
7889 to <= INT_MAX.
7890
16a43933
CY
78912011-04-18 Chong Yidong <cyd@stupidchicken.com>
7892
7893 * xdisp.c (lookup_glyphless_char_display)
7894 (produce_glyphless_glyph): Handle cons cell entry in
7895 glyphless-char-display.
7896 (Vglyphless_char_display): Document it.
7897
7898 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7899 glyphless-char-display.
7900
4581706e
CY
79012011-04-17 Chong Yidong <cyd@stupidchicken.com>
7902
7903 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7904
7905 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7906
7907 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7908 definition for no-X builds.
7909
4887c6e2 79102011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7911
fd35b6f9
PE
7912 Static checks with GCC 4.6.0 and non-default toolkits.
7913
5c1ccb01
PE
7914 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7915
006c5daa
PE
7916 * process.c (keyboard_bit_set): Define only if SIGIO.
7917 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7918 (send_process): Repair possible setjmp clobbering.
7919
efc736d3
PE
7920 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7921
4e2fe2e6
PE
7922 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7923
f97334a2
PE
7924 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7925
4e75f29d
PE
7926 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7927 Define only if needed.
7928
90efadd1
PE
7929 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7930 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7931 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7932
3c647824
PE
7933 * dispextern.h (struct redisplay_interface): Rename param
7934 to avoid shadowing.
e264f262 7935 * termhooks.h (struct terminal): Likewise.
761383f4 7936 * xterm.c (xembed_send_message): Likewise.
3c647824 7937
b58c5c4a
PE
7938 * insdel.c (make_gap_smaller): Define only if
7939 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7940
cad59032
PE
7941 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7942 it.
7943
c339dc2e
PE
7944 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7945 so that we aren't warned about unused symbols.
7946
91a3e27b
PE
7947 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7948
399c71d3 7949 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7950
8ffc96f5
PE
7951 * xfns.c (x_real_positions): Mark locals as initialized.
7952
eef9bc79
PE
7953 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7954
098db9dd
PE
7955 * xterm.c: Fix problems found by static analysis with other toolkits.
7956 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7957 (x_dispatch_event): Declare static if USE_GTK, and
7958 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7959 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7960 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7961 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7962 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7963
eb18f6cc
PE
7964 * xmenu.c (menu_help_callback): Pointer type fixes.
7965 Use const pointers when pointing at readonly data. Avoid pointer
7966 signedness clashes.
7967 (FALSE): Remove unused macro.
7968 (update_frame_menubar): Remove unused decl.
7969
1fe72bf8
PE
7970 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7971
60d9e1db
PE
7972 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7973 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7974 (single_menu_item): Rename local to avoid shadowing.
7975
39261c26
PE
7976 * keyboard.c (make_lispy_event): Remove unused local var.
7977
018c5e19
PE
7978 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7979 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7980
63d2b86e
PE
7981 * bitmaps: Change bitmaps from unsigned char back to the X11
7982 compatible char. Avoid the old compiler warnings about
7983 out-of-range initializers by using, for example, '\xab' rather
7984 than 0xab.
7985
aefd87e1
PE
7986 * xgselect.c (xgselect_initialize): Check vs interface
7987 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7988
bf501fb9
PE
7989 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7990
e9829fdf
PE
7991 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7992 to read-only memory.
7993
1086c095
PE
7994 * fns.c (vector): Remove; this old hack is no longer needed.
7995
2baccd04 7996 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7997 Remove unused var.
dde42981 7998 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7999
72391843 8000 * xrdb.c (x_load_resources): Omit unused local.
3565b346 8001
436c16df 8002 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 8003 (x_window): Rename locals to avoid shadowing.
dc5ddd85 8004 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 8005
92bb796d 8006 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 8007 (x_term_init): Remove local to avoid shadowing.
92bb796d 8008
764430a3 8009 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
8010
8011 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8012 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8013
d1dfb56c
EZ
80142011-04-16 Eli Zaretskii <eliz@gnu.org>
8015
c4354cb4
EZ
8016 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8017
d1dfb56c
EZ
8018 Fix regex.c, syntax.c and friends for buffers > 2GB.
8019 * syntax.h (struct gl_state_s): Declare character position members
8020 EMACS_INT.
8021
8022 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8023
04f2d78b
CB
8024 * textprop.c (verify_interval_modification, interval_of):
8025 Declare arguments EMACS_INT.
d1dfb56c
EZ
8026
8027 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8028 EMACS_INT.
8029
8030 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8031
8032 * indent.c (Fvertical_motion): Local variable it_start is now
8033 EMACS_INT.
8034
8035 * regex.c (re_match, re_match_2, re_match_2_internal)
8036 (bcmp_translate, regcomp, regexec, print_double_string)
8037 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8038 (re_compile_pattern, re_exec): Declare arguments and local
8039 variables `size_t' and `ssize_t' and return values `regoff_t', as
8040 appropriate.
8041 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8042 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8043 <compile_stack_type>: `size' and `avail' are now `size_t'.
8044
8045 * regex.h <regoff_t>: Use ssize_t, not int.
8046 (re_search, re_search_2, re_match, re_match_2): Arguments that
8047 specify buffer/string position and length are now ssize_t and
8048 size_t. Return type is regoff_t.
8049
613052cd
BK
80502011-04-16 Ben Key <bkey76@gmail.com>
8051
8052 * nsfont.m: Fixed bugs in ns_get_family and
8053 ns_descriptor_to_entity that were caused by using free to
8054 deallocate memory blocks that were allocated by xmalloc (via
8055 xstrdup). This caused Emacs to crash when compiled with
8056 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8057 --enable-checking=xmallocoverrun). xfree is now used to
8058 deallocate these memory blocks.
8059
4170f62f 80602011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 8061
71b41406
PE
8062 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8063
9587a89d
PE
8064 emacs_write: Accept and return EMACS_INT for sizes.
8065 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8066 et seq.
8067 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8068 Accept and return EMACS_INT.
8069 (emacs_gnutls_write): Return the number of bytes written on
8070 partial writes.
8071 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
8072 (emacs_read, emacs_write): Remove check for negative size, as the
8073 Emacs source code has been audited now.
9587a89d
PE
8074 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8075 (emacs_read, emacs_write): Use it.
273a5f82
PE
8076 * process.c (send_process): Adjust to the new signatures of
8077 emacs_write and emacs_gnutls_write. Do not attempt to store
8078 a byte offset into an 'int'; it might overflow.
9587a89d 8079 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 8080
3e047f51
PE
8081 * sound.c: Don't assume sizes fit in 'int'.
8082 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 8083 Return EMACS_INT, not int.
3e047f51 8084 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
8085 Accept EMACS_INT, not int.
8086 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
8087 record read return values.
8088
cc39a9db
BK
80892011-04-15 Ben Key <bkey76@gmail.com>
8090
c9d0ec6d
JB
8091 * keyboard.c (Qundefined): Don't declare static since it is used
8092 in nsfns.m.
8093 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8094 static since they are used in nsfont.m.
cc39a9db 8095
6c60eb9f
SM
80962011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8097
8098 * process.c (Qprocessp): Don't declare static.
8099 * lisp.h (Qprocessp): Declare again.
8100
7990b61a
JB
81012011-04-15 Juanma Barranquero <lekktu@gmail.com>
8102
8103 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8104
5d4cb038
PE
81052011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8106
8bd7b830 8107 Improve C-level modularity by making more things 'static'.
cd64ea1d 8108
e3b27b31
PE
8109 Don't publish debugger-only interfaces to other modules.
8110 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8111 (verify_bytepos, count_markers): Move decls to the only modules
8112 that need them.
8113 * region-cache.h (pp_cache): Likewise.
8114 * window.h (check_all_windows): Likewise.
8115 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8116
5d4cb038
PE
8117 * sysdep.c (croak): Now static, if
8118 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8119 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
8120
8121 * alloc.c (refill_memory_reserve): Now static if
8122 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8123 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 8124
e87b6180
PE
8125 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8126 Define only if USE_LUCID.
8127
ac64929e
PE
8128 * xrdb.c (x_customization_string, x_rm_string): Now static.
8129
6f37259d
PE
8130 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8131 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8132
1683e3ab
PE
8133 * xdisp.c (draw_row_with_mouse_face): Now static.
8134 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8135
de9c2632
PE
8136 * window.h (check_all_windows): Mark externally visible.
8137
2b96acb7
PE
8138 * window.c (window_deletion_count): Now static.
8139
8140 * undo.c: Make symbols static if they're not exported.
8141 (last_undo_buffer, last_boundary_position, pending_boundary):
8142 Now static.
8143
50436f33
PE
8144 * textprop.c (interval_insert_behind_hooks): Now static.
8145 (interval_insert_in_front_hooks): Likewise.
8146
64520e5c
PE
8147 * term.c: Make symbols static if they're not exported.
8148 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8149 (max_frame_lines, tty_set_terminal_modes):
8150 (tty_reset_terminal_modes, tty_turn_off_highlight):
8151 (get_tty_terminal): Now static.
8152 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8153 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 8154 HAVE_WINDOW_SYSTEM.
64520e5c
PE
8155 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8156 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8157
1fa53021
PE
8158 * sysdep.c: Make symbols static if they're not exported.
8159 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8160 Now static.
8161 (sigprocmask_set, full_mask): Remove; unused.
8162 (wait_debugging): Mark as visible.
8163 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8164 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8165
d4b43b22
PE
8166 * syntax.c (syntax_temp): Define only if !__GNUC__.
8167
b7c513d0
PE
8168 * sound.c (current_sound_device, current_sound): Now static.
8169
989b29ad
PE
8170 * search.c (searchbufs, searchbuf_head): Now static.
8171
13a55a78
PE
8172 * scroll.c (scroll_cost): Remove; unused.
8173 * dispextern.h (scroll_cost): Remove decl.
8174
de68a1fc
PE
8175 * region-cache.h (pp_cache): Mark as externally visible.
8176
40ccffa6
PE
8177 * process.c: Make symbols static if they're not exported.
8178 (process_tick, update_tick, create_process, chan_process):
8179 (Vprocess_alist, proc_buffered_char, datagram_access):
8180 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8181 (deactivate_process): Mark defn as static, as well as decl.
8182 * lisp.h (create_process): Remove decl.
8183 * process.h (chan_process, Vprocess_alist): Remove decls.
8184
ad64fc97
PE
8185 * print.c: Make symbols static if they're not exported.
8186 (print_depth, new_backquote_output, being_printed, print_buffer):
8187 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8188 (print_interval, print_number_index, initial_stderr_stream):
8189 Now static.
8190 * lisp.h (Fprinc): Remove decl.
8191 (debug_output_compilation_hack): Mark as externally visible.
8192
adddb265
PE
8193 * sysdep.c (croak): Move decl from here to syssignal.h.
8194 * syssignal.h (croak): Put it here, so the API can be checked when
8195 'croak' is called from dissociate_if_controlling_tty.
8196
1717ede2
PE
8197 * minibuf.c: Make symbols static if they're not exported.
8198 (minibuf_save_list, choose_minibuf_frame): Now static.
8199 * lisp.h (choose_minibuf_frame): Remove decl.
8200
fa5fb2bc
PE
8201 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8202
1e3890d1
PE
8203 * lread.c: Make symbols static if they're not exported.
8204 (read_objects, initial_obarray, oblookup_last_bucket_number):
8205 Now static.
8206 (make_symbol): Remove; unused.
8207 * lisp.h (initial_obarray, make_symbol): Remove decls.
8208
8a1414fa
PE
8209 * keyboard.c: Make symbols static if they're not exported.
8210 (single_kboard, recent_keys_index, total_keys, recent_keys):
8211 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8212 (this_single_command_key_start, echoing, last_auto_save):
8213 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8214 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8215 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8216 (Vlispy_mouse_stem, double_click_count):
8217 Now static.
8218 (force_auto_save_soon): Define only if SIGDANGER.
8219 (ignore_mouse_drag_p): Now static if
8220 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8221 (print_help): Remove; unused.
8222 (stop_character, last_timer_event): Mark as externally visible.
8223 * keyboard.h (ignore_mouse_drag_p): Declare only if
8224 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8225 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8226 * lisp.h (echoing): Remove decl.
8227 (force_auto_save_soon): Declare only if SIGDANGER.
8228 * xdisp.c (redisplay_window): Simplify code, to make it more
8229 obvious that ignore_mouse_drag_p is not accessed if !defined
8230 USE_GTK && !defined HAVE_NS.
8231
93ea6e8f
PE
8232 * intervals.c: Make symbols static if they're not exported.
8233 (merge_properties_sticky, merge_interval_right, delete_interval):
8234 Now static.
8235 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8236
77382fcc
PE
8237 * insdel.c: Make symbols static if they're not exported.
8238 However, leave prepare_to_modify_buffer alone. It's never
8239 called from outside this function, but that appears to be a bug.
8240 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8241 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8242 (adjust_after_replace_noundo): Remove; unused.
8243 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8244 (signal_before_change): Remove decls.
77382fcc 8245
9306c32e
PE
8246 * indent.c (val_compute_motion, val_vmotion): Now static.
8247
cd44d2eb
PE
8248 * image.c: Make symbols static if they're not exported.
8249 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8250 if USE_GTK.
8251 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8252 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8253
ad9a7a06
PE
8254 * fringe.c (standard_bitmaps): Now static.
8255 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8256
81626931
PE
8257 * frame.c: Make symbols static if they're not exported.
8258 (x_report_frame_params, make_terminal_frame): Now static.
8259 (get_frame_param): Now static, unless HAVE_NS.
8260 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8261 (x_get_resource_string): Remove; not used.
8262 * frame.h (make_terminal_frame, x_report_frame_params):
8263 (x_get_resource_string); Remove decls.
8264 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8265 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8266
239f9db9
PE
8267 * font.c, fontset.c: Make symbols static if they're not exported.
8268 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8269 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8270 * font.c (font_close_object): Now static.
8271 * font.h (font_close_object): Remove.
8272 * fontset.c (FONTSET_OBJLIST): Remove.
8273 (free_realized_fontset) #if-0 the body, which does nothing.
8274 (face_suitable_for_char_p): #if-0, as it's never called.
8275 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8276 * xfaces.c (face_at_string_position):
8277 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8278 since 0 is always ASCII.
8279
dfcf3579
PE
8280 * fns.c (weak_hash_tables): Now static.
8281
5045092b
PE
8282 * fileio.c: Make symbols static if they're not exported.
8283 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8284 (Vwrite_region_annotation_buffers): Now static.
8285
57a96f5c
PE
8286 * eval.c: Make symbols static if they're not exported.
8287 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8288 * lisp.h (backtrace_list): Remove decl.
8289
35f08c38
PE
8290 * emacs.c: Make symbols static if they're not exported.
8291 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8292 (fatal_error_code, fatal_error_signal_hook, standard_args):
8293 Now static.
8294 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8295 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8296 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8297 * lisp.h (fatal_error_signal_hook): Remove decl.
8298 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8299
f44bd759
PE
8300 * editfns.c: Move a (normally-unused) function to its only use.
8301 * editfns.c, lisp.h (get_operating_system_release): Remove.
8302 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8303 worth the hassle of breaking this out.
8304
b532497d
PE
8305 * xterm.c: Make symbols static if they're not exported.
8306 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8307 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8308 (x_destroy_window, x_delete_display):
8309 Now static.
8310 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8311 (x_mouse_leave): Remove; unused.
8312 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8313 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8314 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8315 Remove decls.
8316 (x_mouse_leave): Declare only if WINDOWSNT.
8317 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8318 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8319 USE_X_TOOLKIT.
8320
1675728f
PE
8321 * ftxfont.c: Make symbols static if they're not exported.
8322 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8323 HAVE_FREETYPE.
8324 * font.h (ftxfont_driver): Likewise.
8325
e4cebfca
PE
8326 * xfns.c: Make symbols static if they're not exported.
8327 (x_last_font_name, x_display_info_for_name):
8328 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8329 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8330 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8331 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8332 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8333 (last_show_tip_args): Now static.
8334 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8335 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8336 (x_screen_planes): Remove; unused.
8337 * dispextern.h (x_screen_planes): Remove decl.
8338
5bf46f05
PE
8339 * dispnew.c: Make symbols static if they're not exported.
8340 * dispextern.h (redraw_garbaged_frames, scrolling):
8341 (increment_row_positions): Remove.
8342 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8343 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8344 Now static.
8345 (redraw_garbaged_frames): Remove; unused.
8346
435f4c28
PE
8347 * xfaces.c: Make symbols static if they're not exported.
8348 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8349 Remove decls.
8350 * xterm.h (defined_color): Remove decls.
8351 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8352 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8353 (menu_face_changed_default, defined_color, free_realized_face):
8354 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8355 (ascii_face_of_lisp_face): Remove; unused.
8356
8524aef3
PE
8357 * xdisp.c: Make symbols static if they're not exported.
8358 * dispextern.h (scratch_glyph_row, window_box_edges):
8359 (glyph_to_pixel_coords, set_cursor_from_row):
8360 (get_next_display_element, set_iterator_to_next):
8361 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8362 (show_mouse_face): Remove decls
8363 * frame.h (message_buf_print): Likewise.
8364 * lisp.h (pop_message, set_message, check_point_in_composition):
8365 Likewise.
8366 * xterm.h (set_vertical_scroll_bar): Likewise.
8367 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8368 (message_buf_print, scratch_glyph_row, displayed_buffer):
8369 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8370 (get_next_display_element, show_mouse_face, window_box_edges):
8371 (frame_to_window_pixel_xy, check_point_in_composition):
8372 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8373 (glyph_to_pixel_coords): Remove; unused.
8374
16390cd2
PE
8375 * dired.c (file_name_completion): Now static.
8376
8377 * dbusbind.c (xd_in_read_queued_messages): Now static.
8378
a25f4dfa
PE
8379 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8380 * data.c (circular_list_error): Remove.
8381
14a9c8df
PE
8382 * commands.h (last_point_position, last_point_position_buffer):
8383 (last_point_position_window): Remove decls.
8384 * keyboard.c: Make these variables static.
8385
04f2d78b
CB
8386 * coding.h (coding, code_convert_region, encode_coding_gap):
8387 Remove decls.
74ab6df5
PE
8388 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8389 (iso_code_class, detect_coding, code_convert_region): Now static.
8390 (encode_coding_gap): Remove; unused.
8391
38dfbee1
PE
8392 * chartab.c (chartab_chars, chartab_bits): Now static.
8393
a2cb4e63
PE
8394 * charset.h (charset_iso_8859_1): Remove decl.
8395 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8396 Now static.
8397
127198fd
PE
8398 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8399 * ccl.c (Vccl_program_table): Now static.
8400 (check_ccl_update): Remove; unused.
8401
d85b608f
PE
8402 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8403 * category.h: ... from here.
8404 * category.c (check_category_table, set_category_set): Now static.
8405
31cd66f3
PE
8406 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8407 * lisp.h: Remove these decls.
8408
c358e587
PE
8409 * buffer.c (buffer_count): Remove unused var.
8410
e78aecca
PE
8411 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8412 so that it's not optimized away.
8413 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8414 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8415 exported only to the debugger.
8416
e192d7d3 8417 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8418 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8419
92470028
PE
8420 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8421 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8422 was inaccessible from Lisp.
8423 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8424 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8425
244ed907
PE
8426 alloc.c: Import and export fewer symbols, and remove unused items.
8427 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8428 is defined.
8429 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8430 it's not optimized away by whole-program optimization.
8431 (message_enable_multibyte, free_misc): Remove.
8432 (catchlist, handlerlist, mark_backtrace):
8433 Declare only if BYTE_MARK_STACK.
8434 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8435 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8436 (message_enable_multibyte): Remove decl.
8437 (free_misc, interval_free_list, float_block, float_block_index):
8438 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8439 (cons_free_list, last_marked_index):
8440 Now static.
8441 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8442 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8443 (mark_backtrace): Define only if BYTE_MARK_STACK.
8444 * xdisp.c (message_enable_multibyte): Now static.
8445
61c2b50e 8446 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8447 This makes it easier for human readers (and static analyzers)
8448 to see whether these variables are used from other modules.
8449 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8450 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8451 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8452 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8453 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8454 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8455 * xmenu.c, xselect.c:
8456 Declare Q* vars static if they are not used in other modules.
8457 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8458 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8459 Remove decls of unexported vars.
8460 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8461
95c82688
PE
8462 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8463
16a97296
PE
8464 Make Emacs functions such as Fatom 'static' by default.
8465 This makes it easier for human readers (and static analyzers)
8466 to see whether these functions can be called from other modules.
8467 DEFUN now defines a static function. To make the function external
8468 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8469 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8470 (Finit_image_library):
16a97296
PE
8471 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8472 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8473 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8474 Remove decls, since these functions are now static.
8475 (Funintern, Fget_internal_run_time): New decls, since these functions
8476 were already external.
95c82688 8477
16a97296
PE
8478 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8479 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8480 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8481 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8482 * keyboard.c, keymap.c, lread.c:
8483 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8484 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8485 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8486 Mark functions with DEFUE instead of DEFUN,
8487 if they are used in other modules.
8488 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8489 decls for now-static functions.
8490 * buffer.h (Fdelete_overlay): Remove decl.
8491 * callproc.c (Fgetenv_internal): Mark as internal.
8492 * composite.c (Fremove_list_of_text_properties): Remove decl.
8493 (Fcomposition_get_gstring): New forward static decl.
8494 * composite.h (Fcomposite_get_gstring): Remove decl.
8495 * dired.c (Ffile_attributes): New forward static decl.
8496 * doc.c (Fdocumntation_property): New forward static decl.
8497 * eval.c (Ffetch_bytecode): New forward static decl.
8498 (Funintern): Remove extern decl; now in .h file where it belongs.
8499 * fileio.c (Fmake_symbolic_link): New forward static decl.
8500 * image.c (Finit_image_library): New forward static decl.
8501 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8502 * intervals.h (Fprevious_property_change):
8503 (Fremove_list_of_text_properties): Remove decls.
8504 * keyboard.c (Fthis_command_keys): Remove decl.
8505 (Fcommand_execute): New forward static decl.
8506 * keymap.c (Flookup_key): New forward static decl.
8507 (Fcopy_keymap): Now static.
8508 * keymap.h (Flookup_key): Remove decl.
8509 * process.c (Fget_process): New forward static decl.
8510 (Fprocess_datagram_address): Mark as internal.
8511 * syntax.c (Fsyntax_table_p): New forward static decl.
8512 (skip_chars): Remove duplicate decl.
8513 * textprop.c (Fprevious_property_change): New forward static decl.
8514 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8515 Now internal.
8516 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8517 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8518
785bbd42
PE
8519 * editfns.c (Fformat): Remove unreachable code.
8520
8b913b57
AS
85212011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8522
8523 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8524 change. (Bug#8496)
8525
a6744a35
EZ
85262011-04-13 Eli Zaretskii <eliz@gnu.org>
8527
8528 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8529 when at ZV. (Bug#8487)
8530
e7974947
AS
85312011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8532
baad03f0
AS
8533 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8534 (Bug#8437)
8535 * keyboard.c (parse_tool_bar_item): Likewise.
8536 * sound.c (sound_cleanup, alsa_close): Likewise.
8537 * termcap.c (tgetent): Likewise.
8538 * xfns.c (x_default_font_parameter): Likewise.
8539 * xsettings.c (read_and_apply_settings): Likewise.
8540
e7974947
AS
8541 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8542 (overrun_check_free): Protoize.
8543
28272684
PE
85442011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8545
8546 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8547 since callers should never pass a negative size.
8548 Change the signature to match that of plain 'read' and 'write'; see
8549 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8550 * lisp.h: Update prototypes of emacs_write and emacs_read.
8551
11997c76
EZ
85522011-04-11 Eli Zaretskii <eliz@gnu.org>
8553
8554 * xdisp.c (redisplay_window): Don't try to determine the character
8555 position of the scroll margin if the window start point w->startp
e896f03c 8556 is outside the buffer's accessible region. (Bug#8468)
11997c76 8557
8a2cbd72
EZ
85582011-04-10 Eli Zaretskii <eliz@gnu.org>
8559
8560 Fix write-region and its subroutines for buffers > 2GB.
8561 * fileio.c (a_write, e_write): Modify declaration of arguments and
8562 local variables to support buffers larger than 2GB.
8563 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8564
8565 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8566 argument, local variables, and return value.
8567
8568 * lisp.h: Update prototypes of emacs_write and emacs_read.
8569
8570 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8571
4073e537 85722011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8573
1ebfdcb6
PE
8574 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8575
b2ded58d
PE
8576 Fix more problems found by GCC 4.6.0's static checks.
8577
7d66342c
PE
8578 * xdisp.c (vmessage): Use a better test for character truncation.
8579
bbf47d44
PE
8580 * charset.c (load_charset_map): <, not <=, for optimization,
8581 and to avoid potential problems with integer overflow.
9248994d 8582 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8583 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8584 * editfns.c (Fformat): Likewise.
1e69125e 8585 * syntax.c (skip_chars): Likewise.
3befa583 8586
e3019616
PE
8587 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8588 This also lets GCC 4.6.0 generate slightly better loop code.
8589
becfa255
PE
8590 * callint.c (Fcall_interactively): <, not <=, for optimization.
8591 (Fcall_interactively): Count the number of arguments produced,
8592 not the number of arguments given. This is simpler and lets GCC
8593 4.6.0 generate slightly better code.
8594
dae0cd48
PE
8595 * ftfont.c: Distingish more carefully between FcChar8 and char.
8596 The previous code passed unsigned char * to a functions like
8597 strlen and xstrcasecmp that expect char *, which does not
8598 conform to the C standard.
8599 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8600 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8601 char * when the C standard requires it.
8602
76032d70
PE
8603 * keyboard.c (read_char): Remove unused var.
8604
eb3f1cc8
PE
8605 * eval.c: Port to Windows vsnprintf (Bug#8435).
8606 Include <limits.h>.
8607 (SIZE_MAX): Define if the headers do not.
8608 (verror): Do not give up if vsnprintf returns a negative count.
8609 Instead, grow the buffer. This ports to Windows vsnprintf, which
8610 does not conform to C99. Problem reported by Eli Zaretskii.
8611 Also, simplify the allocation scheme, by avoiding the need for
8612 calling realloc, and removing the ALLOCATED variable.
8613
70476b54
PE
8614 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8615
12020a9e
PE
8616 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8617 But keep the doprint source code for now, as we might revamp it
8618 and use it again (Bug#8435).
ea6c7ae6
PE
8619 * lisp.h (doprnt): Remove.
8620 * Makefile.in (base_obj): Remove doprnt.o.
8621 * deps.mk (doprnt.o): Remove.
8622
5fdb398c
PE
8623 error: Print 32- and 64-bit integers portably (Bug#8435).
8624 Without this change, on typical 64-bit hosts error ("...%d...", N)
8625 was used to print both 32- and 64-bit integers N, which relied on
8626 undefined behavior.
61bdb816 8627 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8628 * lisp.h (error, verror): Mark as printf-like functions.
8629 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8630 Report overflow in size calculations when allocating printf buffer.
8631 Do not truncate output string at its first null byte.
8632 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8633 Truncate the output at a character boundary, since vsnprintf does not
8634 do that.
8635 * charset.c (check_iso_charset_parameter): Convert internal
8636 character to string before calling 'error', since %c now has the
8637 printf meaning.
8638 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8639 overflow when computing char to be passed to 'error'. Do not
8640 pass Lisp_Object to 'error'; pass the integer instead.
8641 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8642 formatted with plain %d.
8643
b189fa66
PE
8644 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8645
bff87ef0
PE
8646 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8647
7e2cac20
PE
8648 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8649
ce4d90b5
PE
8650 * xterm.c (x_catch_errors): Remove duplicate declaration.
8651
266c9547
PE
8652 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8653
79c49ad2
PE
8654 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8655
368f4090
JM
86562011-04-10 Jim Meyering <meyering@redhat.com>
8657
8658 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8659 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8660 return ssize_t not "int", and use size_t as the buffer length.
8661 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8662 * gnutls.h: Update declarations.
8663 * process.c (read_process_output): Use ssize_t, to match.
8664 (send_process): Likewise.
8665
a32d4040
CY
86662011-04-09 Chong Yidong <cyd@stupidchicken.com>
8667
8668 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8669
8546720e 86702011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8671
04f2d78b
CB
8672 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8673 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8674
8546720e
GM
8675 * xterm.c (handle_one_xevent):
8676 * xmenu.c (create_and_show_popup_menu):
8677 * xselect.c (x_decline_selection_request)
8678 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8679
0a2f5c1a 86802011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8681
8682 Fix some uses of `int' instead of EMACS_INT.
8683 * search.c (string_match_1, fast_string_match)
8684 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8685 (scan_buffer, find_next_newline_no_quit)
8686 (find_before_next_newline, search_command, Freplace_match)
8687 (Fmatch_data): Make some `int' variables be EMACS_INT.
8688
8689 * xdisp.c (display_count_lines): 3rd argument and return value now
8690 EMACS_INT. All callers changed.
8691 (pint2hrstr): Last argument is now EMACS_INT.
8692
8693 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8694 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8695 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8696 (decode_coding_utf_16, decode_coding_emacs_mule)
8697 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8698 (decode_coding_ccl, decode_coding_charset)
8699 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8700 (decode_coding_iso_2022, decode_coding_emacs_mule)
8701 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8702 <char_offset, last_offset>: Declare EMACS_INT.
8703 (encode_coding_utf_8, encode_coding_utf_16)
8704 (encode_coding_emacs_mule, encode_invocation_designation)
8705 (encode_designation_at_bol, encode_coding_iso_2022)
8706 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8707 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8708 Declare EMACS_INT.
8709 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8710 (encode_invocation_designation): Last argument P_NCHARS is now
8711 EMACS_INT.
8712 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8713 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8714
8715 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8716 All users changed.
8717
8718 * ccl.c (Fccl_execute_on_string): Declare some variables
8719 EMACS_INT.
8720
8546720e 87212011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8722
8723 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8724
4e19a977
CS
87252011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8726
8727 * process.c (Fformat_network_address): Doc fix.
8728
87302331
R
87292011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8730
ee7683eb 8731 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8732
cbb59342
CY
87332011-04-08 Chong Yidong <cyd@stupidchicken.com>
8734
8735 * keyboard.c (read_char): Call Lisp function help-form-show,
8736 instead of using internal_with_output_to_temp_buffer.
8737 (Qhelp_form_show): New var.
e0d38eeb 8738 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8739
8740 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8741
8742 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8743
e67a13ab
CY
87442011-04-06 Chong Yidong <cyd@stupidchicken.com>
8745
04f2d78b
CB
8746 * process.c (Flist_processes): Remove to Lisp.
8747 (list_processes_1): Delete.
e67a13ab 8748
973f782d
EZ
87492011-04-06 Eli Zaretskii <eliz@gnu.org>
8750
7c106b1e
EZ
8751 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8752
973f782d
EZ
8753 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8754
41cf7d1a 87552011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8756
ca23cc88
PE
8757 Fix more problems found by GCC 4.6.0's static checks.
8758
f390e2d5
PE
8759 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8760
42eea0d0
PE
8761 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8762
b69769da 8763 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8764
f9541e84
PE
8765 * xdisp.c (vmessage): Mark as a printf-like function.
8766
13841b55
PE
8767 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8768
c136c10f
PE
8769 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8770
5e2d4a30
PE
8771 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8772 printf-like functions.
8773 (tiff_load): Add casts to remove these marks before passing them
8774 to system-supplied API.
8775
583f48b9
PE
8776 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8777
b25d760e
PE
8778 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8779 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8780 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8781 directly, rather than having caller test rule sign. This avoids
8782 some unnecessary tests.
8783 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8784 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8785 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8786
bc7b6697 8787 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8788 (xfont_open): Avoid unnecessary tests.
bc7b6697 8789
27ccc379
PE
8790 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8791
dcd5c89a
PE
8792 * composite.h, composite.c (composition_gstring_put_cache):
8793 Use EMACS_INT, not int, for length.
8794
b13a45c6
PE
8795 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8796 breaking out part of COMPOSITION_DECODE_RULE.
8797 (COMPOSITION_DECODE_RULE): Use it.
8798 * composite.c (get_composition_id): Remove unused local vars,
8799 by using the new macro.
8800
1e792e4d
PE
8801 * textprop.c (set_text_properties_1): Change while to do-while,
8802 since the condition is always true at first.
8803
dc6c6455 8804 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8805 (interval_deletion_adjustment): Return unsigned value.
8806 All uses changed.
dc6c6455 8807
aba7731a
PE
8808 * process.c (list_processes_1, create_pty, read_process_output):
8809 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8810 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8811 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8812 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8813 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8814
fdfc4bf3
PE
8815 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8816
fca8fe46 8817 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8818 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8819
06a0259a 8820 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8821 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8822 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8823
e7b9e80f
PE
8824 * print.c (print_error_message): Avoid int overflow.
8825
56201685
PE
8826 * font.c (font_list_entities): Redo for clarity,
8827 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8828
78834453 8829 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8830 (font_score): Avoid potential overflow in diff calculation.
78834453 8831
0bc0b309 8832 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8833 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8834
e610eaca
PE
8835 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8836
b895abce
PE
8837 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8838 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8839 can always succeed if overflow has undefined behavior.
8840
1f1d9321 8841 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8842 (wordify): Omit three unnecessary tests.
1f1d9321 8843
c59478bc
PE
8844 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8845 All callers changed. This avoids the need for an unused var.
8846
79b73827
PE
8847 * casefiddle.c (casify_region): Remove var that is set but not used.
8848
a4db5dfe
PE
8849 * dired.c (file_name_completion): Remove var that is set but not used.
8850
43aae36e
PE
8851 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8852
2a47c44d 8853 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8854 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8855
a37c69bf
PE
8856 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8857 Check for integer overflow on size calculations.
8858
328ab8e7
PE
8859 * buffer.c (Fprevious_overlay_change): Remove var that is set
8860 but not used.
8861
e5a2a5cb
PE
8862 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8863 Remove vars that are set but not used.
8d84a6eb 8864 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8865 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8866
a60e5f68
PE
8867 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8868
f661cb61 8869 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8870 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8871
f0397f5a
PE
8872 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8873 that are set but not used.
8874
8664db06 8875 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8876 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8877
6abdaa4a
PE
8878 * xselect.c (x_get_local_selection, x_handle_property_notify):
8879 Remove vars that are set but not used.
8880
0ce7538d 8881 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8882 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8883
9ae848fc
PE
8884 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8885 Remove var that is set but not used.
0b918413
PE
8886 (scroll_bar_windows_size): Now size_t, not int.
8887 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8888 Check for overflow.
9ae848fc 8889
a5a62657
PE
8890 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8891 (map_tty_color) [!defined MSDOS]: Likewise.
8892
5c5cdd39
PE
8893 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8894
66ebf983
PE
8895 * coding.c: Remove vars that are set but not used.
8896 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8897 All callers changed.
8898 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8899 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8900 (decode_coding_charset): Remove vars that are set but not used.
8901
1be4d761
PE
8902 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8903 that is set but not used.
8904
47553fa8
PE
8905 * print.c (print_object): Remove var that is set but not used.
8906
1f7196bf 8907 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8908 The gnulib version avoids calling malloc in the usual case,
8909 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8910 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8911 * filelock.c (current_lock_owner): Likewise.
8912 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8913 * sysdep.c: Include allocator.h, careadlinkat.h.
8914 (emacs_no_realloc_allocator): New static constant.
8915 (emacs_readlink): New function.
fdb61804
PE
8916 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8917 ../lib/careadlinkat.h.
d1fdcab7 8918
f84c17c7
SM
89192011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8920
8921 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8922 first non-nil return value).
8923
ef3862ad
JD
89242011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8925
8926 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8927 if not defined (Bug#8403).
8928
376a7006
JB
89292011-04-02 Juanma Barranquero <lekktu@gmail.com>
8930
8931 * xdisp.c (display_count_lines): Remove parameter `start',
8932 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8933 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8934 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8935 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8936 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8937 and thereabouts. All callers changed.
8938 (get_per_char_metric): Remove parameter `f', unused since
8939 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8940
6ca3801d
JM
89412011-04-02 Jim Meyering <meyering@redhat.com>
8942
8943 do not dereference NULL upon failed strdup
8944 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8945 (ns_get_family): Likewise.
8946
d8e2b5ba
JB
89472011-04-02 Juanma Barranquero <lekktu@gmail.com>
8948
8949 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8950
8c74fcbd
JD
89512011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8952
8953 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8954 later (Bug#8403).
8955
7200d79c
SM
89562011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8957
03408648 8958 Add lexical binding.
7200d79c 8959
03408648
SM
8960 * window.c (Ftemp_output_buffer_show): New fun.
8961 (Fsave_window_excursion):
8962 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8963
8964 * lread.c (lisp_file_lexically_bound_p): New function.
8965 (Fload): Bind Qlexical_binding.
8966 (readevalloop): Remove `evalfun' arg.
8967 Bind Qinternal_interpreter_environment.
8968 (Feval_buffer): Bind Qlexical_binding.
8969 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8970 Mark as dynamic.
8971 (syms_of_lread): Declare `lexical-binding'.
8972
8973 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8974
8975 * keyboard.c (eval_dyn): New fun.
8976 (menu_item_eval_property): Use it.
ca105506
SM
8977
8978 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8979
03408648
SM
8980 * fns.c (concat, mapcar1): Accept byte-code-functions.
8981
8982 * eval.c (Fsetq): Handle lexical vars.
8983 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8984 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8985 (FletX, Flet): Obey lexical binding.
8986 (Fcommandp): Handle closures.
8987 (Feval): New `lexical' arg.
8988 (eval_sub): New function extracted from Feval. Use it almost
8989 everywhere where Feval was used. Look up vars in lexical env.
8990 Handle closures.
8991 (Ffunctionp): Move from subr.el.
8992 (Ffuncall): Handle closures.
8993 (apply_lambda): Remove `eval_flags'.
8994 (funcall_lambda): Handle closures and new byte-code-functions.
8995 (Fspecial_variable_p): New function.
8996 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8997 but without exporting it to Lisp.
23aba0ea 8998
23aba0ea 8999 * doc.c (Fdocumentation, store_function_docstring):
03408648 9000 * data.c (Finteractive_form): Handle closures.
23aba0ea 9001
03408648
SM
9002 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9003 interactive spec.
ba83908c 9004
04f2d78b
CB
9005 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9006 New byte-codes.
03408648
SM
9007 (exec_byte_code): New function extracted from Fbyte_code to handle new
9008 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 9009
03408648 9010 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 9011
03408648 9012 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 9013
e2abce01
JB
90142011-03-31 Juanma Barranquero <lekktu@gmail.com>
9015
9016 * xdisp.c (redisplay_internal): Fix prototype.
9017
63696a73 90182011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 9019
63696a73 9020 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
9021 (try_scrolling): Use it when setting scroll_limit.
9022 Limit scrolling to 100 screen lines.
63696a73
EZ
9023 (redisplay_window): Even when falling back on "recentering",
9024 position point in the window according to scroll-conservatively,
9025 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9026
9027 (try_scrolling): When point is above the window, allow searching
9028 as far as scroll_max, or one screenful, to compute vertical
9029 distance from PT to the scroll margin position. This prevents
9030 try_scrolling from unnecessarily failing when
9031 scroll-conservatively is set to a value slightly larger than the
9032 window height. Clean up the case of PT below the margin at bottom
9033 of window: scroll_max can no longer be INT_MAX. When aggressive
9034 scrolling is in use, don't let point enter the opposite scroll
9035 margin as result of the scroll.
9036 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
9037 threshold of 100 lines for never-recentering scrolling.
9038
e4cc2dfc
JB
90392011-03-31 Juanma Barranquero <lekktu@gmail.com>
9040
9041 * dispextern.h (move_it_by_lines):
9042 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9043 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9044 (message_log_check_duplicate): Remove parameters `prev_bol' and
9045 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9046 (redisplay_internal): Remove parameter `preserve_echo_area',
9047 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9048
9049 * indent.c (Fvertical_motion):
9050 * window.c (window_scroll_pixel_based, Frecenter):
9051 Don't pass `need_y_p' to `move_it_by_lines'.
9052
1c470562
SM
90532011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9054
44f230aa
SM
9055 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9056 steal a few bits to be more compact.
9057 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9058 Remove unneeded casts.
9059
1c470562
SM
9060 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9061
888adce9
ZK
90622011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9063
9064 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9065 binding" message (bug#7967).
9066
f838ed7b
PE
90672011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9068
77861b95
PE
9069 Fix more problems found by GCC 4.6.0's static checks.
9070
de6dbc14
PE
9071 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9072 Remove unused local var.
9073
f838ed7b
PE
9074 * editfns.c (Fmessage_box): Remove unused local var.
9075
792c7b2b
PE
9076 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9077 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9078 Omit unused local vars.
c499e557 9079 * window.c (shrink_windows): Omit unused local var.
b01a1c29 9080 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
9081 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9082 Omit unused local var.
9083
ba0165e1
PE
9084 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9085 Don't assume string length fits in int.
32ad8845 9086 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 9087 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 9088
3c59b4c9
PE
9089 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9090 instead of alloca (Bug#8344).
9091
a3eed478 9092 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 9093 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 9094
eb4d412d
PE
9095 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9096
1658b401
PE
9097 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9098 concerns.
9099
9100 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9101
9102 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 9103
9a2c6e05
PE
9104 * keyboard.c (syms_of_keyboard): Use the same style as later
9105 in this function when indexing through an array. This also
9106 works around GCC bug 48267.
9107
03d0a109
PE
9108 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9109
44f730c8
PE
9110 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9111
fe75f926
PE
9112 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9113 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9114
ffa8c828
PE
9115 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9116 This avoids undefined behavior on integer overflow, and is a bit
9117 more convenient anyway since it is compared to a size_t variable.
9118
c5101a77
PE
9119 Variadic C functions now count arguments with size_t, not int.
9120 This avoids an unnecessary limitation on 64-bit machines, which
9121 caused (substring ...) to crash on large vectors (Bug#8344).
9122 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9123 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 9124 All variadic functions and their callers changed accordingly.
c5101a77
PE
9125 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9126 * data.c (arith_driver, float_arith_driver): Likewise.
9127 * editfns.c (general_insert_function): Likewise.
9128 * eval.c (struct backtrace.nargs, interactive_p)
9129 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9130 (funcall_lambda, mark_backtrace): Likewise.
9131 * fns.c (concat): Likewise.
9132 * frame.c (x_set_frame_parameters): Likewise.
9133 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9134 0 if not found, not -1. All callers changed.
9135
dd3f25f7
PE
9136 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9137 (stack_copy_size): Now size_t, not int.
9138 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9139
461c2ab9
JB
91402011-03-28 Juanma Barranquero <lekktu@gmail.com>
9141
9142 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9143 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9144 All callers changed.
9145
9146 * lisp.h (multibyte_char_to_unibyte):
9147 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9148 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9149 * character.h (CHAR_TO_BYTE8):
9150 * cmds.c (internal_self_insert):
9151 * editfns.c (general_insert_function):
9152 * keymap.c (push_key_description):
9153 * search.c (Freplace_match):
9154 * xdisp.c (message_dolog, set_message_1): All callers changed.
9155
f6d62986
SM
91562011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9157
9158 * keyboard.c (safe_run_hook_funcall): New function.
9159 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9160 don't set the hook to nil, but remove the offending function instead.
9161 (Qcommand_hook_internal): Remove, unused.
9162 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9163 Vcommand_hook_internal.
9164
9165 * eval.c (enum run_hooks_condition): Remove.
9166 (funcall_nil, funcall_not): New functions.
9167 (run_hook_with_args): Call each function through a `funcall' argument.
9168 Remove `cond' argument, now redundant.
9169 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9170 (Frun_hook_with_args_until_failure): Adjust accordingly.
9171 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9172
1db5b1ad
JB
91732011-03-28 Juanma Barranquero <lekktu@gmail.com>
9174
9175 * dispextern.h (string_buffer_position): Remove declaration.
9176
9177 * print.c (strout): Remove parameter `multibyte', unused since
9178 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9179
9180 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9181 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9182 All callers changed.
9183
9184 * w32.c (_wsa_errlist): Use braces for struct initializers.
9185
9186 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9187 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9188 All callers changed.
9189 (string_buffer_position): Likewise. Also, make static (it's never
9190 used outside xdisp.c).
9191 (cursor_row_p): Remove parameter `w', unused since
9192 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9193 (decode_mode_spec): Remove parameter `precision', introduced during
9194 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9195 All callers changed.
9196
5ffb62aa
JD
91972011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9198
9199 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9200
461c2ab9 92012011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9202
9203 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9204 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9205 (ns_update_auto_hide_menu_bar): New functions.
9206 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9207 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9208 ns_constrain_all_frames.
9209 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9210 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9211
5c380ffb
JD
92122011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9213
9214 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9215
9af30bdf
GM
92162011-03-27 Glenn Morris <rgm@gnu.org>
9217
9218 * syssignal.h: Replace RETSIGTYPE with void.
9219 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9220 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9221 Replace SIGTYPE with void everywhere.
9222 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9223 * s/template.h (SIGTYPE): Remove commented out definition.
9224
e2abce01
JB
92252011-03-26 Eli Zaretskii <eliz@gnu.org>
9226
9227 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9228 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9229
f868cd8a
JB
92302011-03-26 Juanma Barranquero <lekktu@gmail.com>
9231
59eb0929
JB
9232 * w32.c (read_unc_volume): Use parameter `henum', instead of
9233 global variable `wget_enum_handle'.
9234
9235 * keymap.c (describe_vector): Remove parameters `indices' and
9236 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9237 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9238
f868cd8a
JB
9239 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9240
9241 * keyboard.c (timer_check): Remove parameter `do_it_now',
9242 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9243 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9244 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9245
9246 * keyboard.c (read_char):
9247 * w32menu.c (w32_menu_display_help):
9248 * xmenu.c (show_help_event, menu_help_callback):
9249 Adjust calls to `show_help_echo'.
9250
9251 * gtkutil.c (xg_maybe_add_timer):
9252 * keyboard.c (readable_events):
9253 * process.c (wait_reading_process_output):
9254 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9255
9256 * insdel.c (adjust_markers_gap_motion):
9257 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9258 (gap_left, gap_right): Don't call it.
9259
2ecf6fdb
CY
92602011-03-25 Chong Yidong <cyd@stupidchicken.com>
9261
9262 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9263 incurred during fontification.
9264
6b1f9ba4
JB
92652011-03-25 Juanma Barranquero <lekktu@gmail.com>
9266
9267 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9268 (DEFVAR_PER_BUFFER): Don't pass it.
9269
9270 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9271 (scrolling_window): Don't pass it.
9272
0f4a96b5
JB
92732011-03-25 Juanma Barranquero <lekktu@gmail.com>
9274
9275 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9276
9277 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9278 and `suffix'.
9279 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9280 of variables specific to SELinux and computation of `encoded_absname'.
9281
9282 * image.c (XPutPixel): Remove unused variable `height'.
9283
9284 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9285
9286 * unexw32.c (get_section_info): Remove unused variable `section'.
9287
9288 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9289 (system_process_attributes): Remove unused variable `sess'.
9290 (sys_read): Remove unused variable `err'.
9291
9292 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9293 (w32_wnd_proc): Remove unused variable `isdead'.
9294 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9295 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9296 (x_create_tip_frame): Remove unused variable `tem'.
9297
9298 * w32inevt.c (w32_console_read_socket):
9299 Remove unused variable `no_events'.
9300
9301 * w32term.c (x_draw_composite_glyph_string_foreground):
9302 Remove unused variable `width'.
9303
1149507c
JB
93042011-03-24 Juanma Barranquero <lekktu@gmail.com>
9305
9306 * w32term.c (x_set_glyph_string_clipping):
9307 Don't pass uninitialized region to CombineRgn.
9308
9c88f339
JB
93092011-03-23 Juanma Barranquero <lekktu@gmail.com>
9310
9311 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9312 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9313 (Fx_close_connection): Remove unused variable `i'.
9314
9315 * w32font.c (w32font_draw): Return number of glyphs.
9316 (w32font_open_internal): Remove unused variable `i'.
9317 (w32font_driver): Add missing initializer.
9318
9319 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9320 (fill_in_menu): Remove unused variable `items_added'.
9321
9322 * w32term.c (last_mouse_press_frame): Remove static global variable.
9323 (w32_clip_to_row): Remove unused variable `f'.
9324 (x_delete_terminal): Remove unused variable `i'.
9325
9326 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9327 (NOTHING): Remove unused static global variable.
9328 (uniscribe_check_otf): Remove unused variable `table'.
9329 (uniscribe_font_driver): Add missing initializers.
9330
dee091a3
JD
93312011-03-23 Julien Danjou <julien@danjou.info>
9332
9333 * term.c (Fsuspend_tty, Fresume_tty):
9334 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9335 * window.c (temp_output_buffer_show):
9336 * insdel.c (signal_before_change):
9337 * frame.c (Fhandle_switch_frame):
9338 * fileio.c (Fdo_auto_save):
9339 * emacs.c (Fkill_emacs):
9340 * editfns.c (save_excursion_restore):
9341 * cmds.c (internal_self_insert):
9342 * callint.c (Fcall_interactively):
9343 * buffer.c (Fkill_all_local_variables):
9344 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9345 Use Frun_hooks.
0f4a96b5 9346 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9347 unconditionally since it does the check itself.
dee091a3 9348
2c520ab5 93492011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9350
c9c49752
PE
9351 Fix more problems found by GCC 4.5.2's static checks.
9352
8abc3f12
PE
9353 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9354 the first time through the loop, since we know p0 < p1 then.
9355 This also avoids a gcc -Wstrict-overflow warning.
9356
a2d26660
PE
9357 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9358 leading to a memory leak, possible in functions like
9359 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9360 of objects (Bug#8318).
a2d26660 9361
916c72e9
PE
9362 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9363 that could (at least in theory) be that large.
9364
19ab8a18
PE
9365 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9366 This is less likely to overflow, and avoids undefined behavior if
9367 overflow does occur. All callers changed. Use strtoul to scan
9368 for the unsigned long integer.
b7cbbd6f
PE
9369 (pint2hrstr): Simplify and tune code slightly.
9370 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9371
f0641eff
PE
9372 * scroll.c (do_scrolling): Work around GCC bug 48228.
9373 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9374
7f650bb9
PE
9375 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9376 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9377 (validate_x_resource_name): Simplify count usage.
9378 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9379
37dd57d1
PE
9380 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9381 fail (Bug#8306).
81e56e61 9382
699979fc 9383 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9384
401bf9b4
PE
9385 * process.c (Fmake_network_process): Use socklen_t, not int,
9386 where POSIX says socklen_t is required in portable programs.
9387 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9388 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9389 (Fmake_network_process, server_accept_connection):
9390 (wait_reading_process_output, read_process_output):
9391 Likewise.
9392
b93aacde
PE
9393 * process.c: Rename or move locals to avoid shadowing.
9394 (list_processes_1, Fmake_network_process):
9395 (read_process_output_error_handler, exec_sentinel_error_handler):
9396 Rename or move locals.
4dc343ee 9397 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9398 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9399 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9400 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9401 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9402
af8a867c 9403 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9404 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9405 Include tparam.h instead, since it declares them.
af8a867c
PE
9406 * cm.h (PC): Remove extern decl; tparam.h now does this.
9407 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9408 * terminfo.c: Include tparam.h, to check interfaces.
9409 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9410 (tparam): Adjust signature to match interface in tparam.h;
9411 this removes some undefined behavior. Check that outstring and len
9412 are zero, which they always are with Emacs.
9413 * tparam.h (PC, BC, UP): New extern decls.
9414
0248044d 9415 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9416 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9417
8ff096c1 9418 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9419 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9420 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9421 (ftfont_list): Remove unused local.
49eaafba
PE
9422 (get_adstyle_property, ftfont_pattern_entity):
9423 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9424 Rename locals to avoid shadowing.
8ff096c1 9425
e2be39f6
PE
9426 * xfont.c (xfont_list_family): Mark var as initialized.
9427
c9735e30
PE
9428 * xml.c (make_dom): Now static.
9429
8f5201ae
PE
9430 * composite.c (composition_compute_stop_pos): Rename local to
9431 avoid shadowing.
b246f932
PE
9432 (composition_reseat_it): Remove unused locals.
9433 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9434 (composition_update_it): Mark var as initialized.
11b61122
PE
9435 (find_automatic_composition): Mark vars as initialized,
9436 with a FIXME (Bug#8290).
8f5201ae 9437
760fbc2c
PE
9438 character.h: Rename locals to avoid shadowing.
9439 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9440 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9441 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9442 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9443 to avoid shadowing.
9444
ff08eb85
PE
9445 * textprop.c (property_change_between_p): Remove; unused.
9446
fc7bf025
PE
9447 * intervals.c (interval_start_pos): Now static.
9448
235d7abc
PE
9449 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9450
44f230aa
SM
9451 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9452 Rename locals to avoid shadowing.
3e7d6594 9453
50060332
PE
9454 * sound.c (wav_play, au_play, Fplay_sound_internal):
9455 Fix pointer signedness.
d01f234b 9456 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9457 (wav_play): Initialize a variable to 0, to prevent undefined
9458 behavior (Bug#8278).
50060332 9459
c4fc4e30
PE
9460 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9461
918436ed
PE
9462 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9463
c939f91b
PE
9464 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9465 clobbering (Bug#8298).
b9c7f648
PE
9466 * sysdep.c (sys_subshell): Likewise.
9467 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9468
6bd8c144
PE
9469 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9470 This should get cleaned up, so that child_setup has the
9471 same signature on all platforms.
9472
7710357c 9473 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9474 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9475
c59da222
CY
94762011-03-22 Chong Yidong <cyd@stupidchicken.com>
9477
9478 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9479 not to be necessary, and produces flickering.
9480
66b87493
GM
94812011-03-20 Glenn Morris <rgm@gnu.org>
9482
9483 * config.in: Remove file.
9484
45b6f6d5
JB
94852011-03-20 Juanma Barranquero <lekktu@gmail.com>
9486
9487 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9488 are now in src/globals.h.
9489 (syms_of_minibuf): Remove spurious & from previous change.
9490
cd394be1 94912011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9492
9493 * minibuf.c (completing-read-function): New variable.
9494 (completing-read-default): Rename from completing-read.
9495 (completing-read): Call completing-read-function.
9496
b14e3e21
CY
94972011-03-19 Juanma Barranquero <lekktu@gmail.com>
9498
9499 * xfaces.c (Fx_load_color_file):
9500 Read color file from absolute filename (bug#8250).
9501
f2b726e6
JB
95022011-03-19 Juanma Barranquero <lekktu@gmail.com>
9503
9504 * makefile.w32-in: Update dependencies.
9505
09f6ff02
EZ
95062011-03-17 Eli Zaretskii <eliz@gnu.org>
9507
9508 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9509
29a6015a
PE
95102011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9511
a3a6c54e
PE
9512 Fix more problems found by GCC 4.5.2's static checks.
9513
b766f867
PE
9514 * process.c (make_serial_process_unwind, send_process_trap):
9515 (sigchld_handler): Now static.
9516
be02381c
PE
9517 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9518 That way, the code declares only the vars that it needs.
9519 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9520 * s/cygwin.h (PTY_ITERATION): Likewise.
9521 * s/darwin.h (PTY_ITERATION): Likewise.
9522 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9523
57048744
PE
9524 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9525 * process.c (allocate_pty): Don't declare stb unless it's needed.
9526
7914961c 9527 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9528 (CONSTANTLIM): Remove; unused.
9529 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9530 Define only if needed.
7914961c 9531
b3967b18
PE
9532 * unexelf.c (unexec): Name an expression,
9533 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9534 Use a different way to cause a compilation error if anyone uses
9535 n rather than nn, a way that does not involve shadowing.
73366a00 9536 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9537
29a6015a
PE
9538 * deps.mk (unexalpha.o): Remove; unused.
9539
43cfc33e 9540 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9541 * unexec.h: New file.
ce701a33
PE
9542 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9543 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9544 Depend on unexec.h.
9545 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9546 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9547 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9548 Change as necessary to match prototype in unexec.h.
ce701a33 9549
01f44d5a
PE
9550 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9551 shadowing.
4f63c6bb 9552 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9553
a6670b0b
PE
9554 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9555 Rename locals to avoid shadowing.
9556
cef2010d 9557 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9558 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9559
d4d7173a
PE
9560 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9561
f08b802a
PE
9562 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9563 warning when compiling print.c.
9564
3ddb0639
PE
9565 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9566 instead of using an uninitialized var.
5ad03b97 9567 (font_sort_entities): Mark var as initialized.
3ddb0639 9568
170a2692
PE
9569 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9570
e663c700
PE
9571 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9572 pointers to constants.
89bc529a 9573 (font_parse_fcname): Remove unused vars.
7b81e2d0 9574 (font_delete_unmatched): Now static.
ea838e10 9575 (font_get_spec): Remove; unused.
13a547c6
PE
9576 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9577 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9578 Rename or move locals to avoid shadowing.
e663c700 9579
2a80c887 9580 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9581 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9582
1384fa33 9583 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9584 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9585
8b2c52e9
PE
9586 * alloc.c (mark_backtrace): Move decl from here ...
9587 * lisp.h: ... to here, so that it can be checked.
9588
475545b5 9589 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9590 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9591 (lisp_indirect_variable): Name an expression,
9592 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9593 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9594
b1349114 9595 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9596 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9597 Use const pointer when appropriate.
b1349114 9598
a2928364
PE
9599 * lisp.h (get_system_name, get_operating_system_release):
9600 Move decls here, to check interfaces.
9601 * process.c (get_operating_system_release): Move decl to lisp.h.
9602 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9603 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9604 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9605 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9606 (Fformat_time_string, Fencode_time, Finsert_char):
9607 (Ftranslate_region_internal, Fformat):
9608 Rename or remove local vars to avoid shadowing.
9710023e 9609 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9610
a415e694
PE
9611 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9612 avoid shadowing.
9613
8ef4622d
PE
9614 * lisp.h (eassert): Check that the argument compiles, even if
9615 ENABLE_CHECKING is not defined.
9616
946f9a5b
PE
9617 * data.c (Findirect_variable): Name an expression, to avoid
9618 gcc -Wbad-function-cast warning.
112396d6 9619 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9620 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9621 (Fmake_variable_buffer_local, Fmake_local_variable):
9622 Mark variables as initialized.
52746918 9623 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9624
e5aab7e7 9625 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9626 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9627 Rename locals to avoid shadowing.
dff45157
PE
9628 (mark_stack): Move local variables into the #ifdef region where
9629 they're used.
7bc26fdb
PE
9630 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9631 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9632 needed otherwise.
9633 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9634 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9635 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9636
e5aab7e7
PE
9637 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9638 avoids undefined behavior in theory.
9639
4da60324
PE
9640 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9641
88043301
PE
9642 Use functions, not macros, for up- and down-casing (Bug#8254).
9643 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9644 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9645 to use the following functions instead of these macros.
9646 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9647 EMACS_INT, since callers assume the returned value fits in int.
9648 (upcase1): Likewise, for UPCASE_TABLE.
9649 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9650 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9651 the race-condition problem in the old DOWNCASE.
88043301 9652
19ed5445
PE
9653 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9654 Rename locals to avoid shadowing.
9655 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9656 (regex_compile, re_search_2, re_match_2_internal):
9657 Remove unused local vars.
952db0d7
PE
9658 (FREE_VAR): Rewrite so as not to use empty "else",
9659 which gcc can warn about.
da053e48 9660 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9661 (RETALLOC_IF): Define only if needed.
9662 (WORDCHAR_P): Likewise. This one is never needed, but is used
9663 only in a comment talking about a compiler bug, so put inside
9664 the #if 0 of that comment.
9665 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9666 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9667 Remove; unused.
19ed5445 9668
1f3561e4 9669 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9670 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9671 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9672
ded6f8f7
PE
9673 * search.c (simple_search): Remove unused var.
9674
dbd37a95
PE
9675 * dired.c (compile_pattern): Move decl from here ...
9676 * lisp.h: ... to here, so that it can be checked.
9677 (struct re_registers): New forward decl.
9678
7e47afad
PE
9679 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9680
85f24f61
PE
9681 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9682 All uses changed.
9683 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9684 Rename locals to avoid shadowing.
5671df8f 9685 (Fvertical_motion): Mark locals as initialized.
85f24f61 9686
181aa2be 9687 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9688 (casify_region): Mark local as initialized.
181aa2be 9689
930d429c
PE
9690 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9691
7082eac6
PE
9692 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9693 New macros, so that the caller can use some names other than
9694 gcpro1, gcpro2, etc.
9695 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9696 of the new macros.
9697 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9698 argument, for consistency with GCPRO2_VAR, etc: it is now the
9699 prefix of the variable, not the variable itself. All uses
9700 changed.
38b2c076
PE
9701 * dired.c (directory_files_internal, file_name_completion):
9702 Rename locals to avoid shadowing.
9703
15206ed9
PE
9704 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9705 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9706 dired.c's scmp function, had undefined behavior.
9707 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9708 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9709 * buffer.h: ... to here, because these macros use current_buffer,
9710 and the new implementation with inline functions needs to have
9711 current_buffer in scope now, rather than later when the macros
9712 are used.
9713 (downcase, upcase1): New static inline functions.
9714 (DOWNCASE, UPCASE1): Reimplement using these functions.
9715 This avoids undefined behavior in expressions like
9716 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9717 from race conditions in accessing the global variables
9718 case_temp1 and case_temp2.
9719 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9720 * lisp.h (case_temp1, case_temp2): Remove their decls.
9721 * character.h (ASCII_CHAR_P): Move from here ...
9722 * lisp.h: ... to here, so that the inline functions mentioned
9723 above can use them.
9724
4a6bea26
PE
9725 * dired.c (directory_files_internal_unwind): Now static.
9726
f14b7e14
PE
9727 * fileio.c (file_name_as_directory, directory_file_name):
9728 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9729 Now static.
2893f146
PE
9730 (file_name_as_directory): Use const pointers when appropriate.
9731 (Fexpand_file_name): Likewise. In particular, newdir might
9732 point at constant storage, so make it a const pointer.
fd4ead52 9733 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9734 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9735 signedness issues.
f839df0c
PE
9736 (Fset_file_times, Finsert_file_contents, auto_save_error):
9737 Rename locals to avoid shadowing.
f14b7e14 9738
5716756e 9739 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9740 (Ftry_completion, Fall_completions): Rename or remove locals
9741 to avoid shadowing.
5716756e 9742
b4c3046a
PE
9743 * marker.c (bytepos_to_charpos): Remove; unused.
9744
b45db522
PE
9745 * lisp.h (verify_bytepos, count_markers): New decls,
9746 so that gcc does not warn that these functions aren't declared.
9747
85876d07
PE
9748 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9749 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9750 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9751 (copy_text): Remove unused local var.
85876d07 9752
03d78a21 9753 * filelock.c (within_one_second): Now static.
b3dd38ab 9754 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9755
5df8f01b
PE
9756 * buffer.c (fix_overlays_before): Mark locals as initialized.
9757 (fix_start_end_in_overlays): Likewise. This function should be
9758 simplified by using pointers-to-pointers, but that's a different
9759 matter.
b1d876f1 9760 (switch_to_buffer_1): Now static.
8f54f30a
PE
9761 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9762 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9763
a70072c9 9764 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9765 Fix pointer signedness issue.
edced198
PE
9766 (sys_subshell): Mark local as volatile if checking for lint,
9767 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9768 (MAXPATHLEN): Define only if needed.
a70072c9 9769
a0977c44
PE
9770 * process.c (serial_open, serial_configure): Move decls from here ...
9771 * systty.h: ... to here, so that they can be checked.
9772
a884fdcc
PE
9773 * fns.c (get_random, seed_random): Move extern decls from here ...
9774 * lisp.h: ... to here, so that they can be checked.
9775
604efe86 9776 * sysdep.c (reset_io): Now static.
b8950c94 9777 (wait_for_termination_signal): Remove; unused.
604efe86 9778
38fc62d9
PE
9779 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9780 (copy_keymap_item, append_key, push_text_char_description):
9781 Now static.
1004a21a 9782 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9783 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9784 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9785 (describe_map_tree):
9786 Rename locals to avoid shadowing.
38fc62d9 9787
2f2650da
PE
9788 * keyboard.c: Declare functions static if they are not used elsewhere.
9789 (echo_char, echo_dash, cmd_error, top_level_2):
9790 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9791 (read_char, kbd_buffer_get_event, make_lispy_position):
9792 (make_lispy_event, make_lispy_movement, apply_modifiers):
9793 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9794 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9795 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9796 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9797 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9798
a053e86c 9799 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9800 (mark_kboards): Move decl here ...
9801 * alloc.c (mark_kboards): ... from here.
a053e86c 9802
4752793e
PE
9803 * lisp.h (force_auto_save_soon): New decl.
9804
74f10ca7 9805 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9806 (DEFINE_DUMMY_FUNCTION): New macro.
9807 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9808 Use it.
c03cd23f
PE
9809 (main): Add casts to avoid warnings
9810 if GCC considers string literals to be constants.
74f10ca7 9811
022e70d4
PE
9812 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9813
59d6fe83
PE
9814 * dbusbind.c: Pointer signedness fixes.
9815 (xd_signature, xd_append_arg, xd_initialize):
9816 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9817 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9818 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9819 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9820
78320123
PE
9821 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9822 if GCC considers string literals to be constants.
49cebcca 9823 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9824
35ac2a97
SM
98252011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9826
fb103ca9
SM
9827 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9828 (print_preprocess, print_object): New macro to fix last change.
9829
35ac2a97
SM
9830 * print.c (print_preprocess): Don't forget font objects.
9831
62973b41
JB
98322011-03-16 Juanma Barranquero <lekktu@gmail.com>
9833
9834 * emacs.c (USAGE3): Doc fixes.
9835
0e48bb22
AS
98362011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9837
9838 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9839 structure.
9840
7684e57b
JB
98412011-03-14 Juanma Barranquero <lekktu@gmail.com>
9842
9843 * lisp.h (VWindow_system, Qfile_name_history):
9844 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9845 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9846 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9847
9848 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9849 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9850
9851 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9852 * w32console.c (detect_input_pending, read_input_pending)
9853 (encode_terminal_code):
9854 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9855 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9856 (w32_system_caret_y, Qfile_name_history):
9857 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9858 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9859 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9860 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9861 * w32proc.c (Qlocal, report_file_error):
9862 * w32term.c (Vwindow_system, updating_frame):
9863 * w32uniscribe.c (initialized, uniscribe_font_driver):
9864 Remove unneeded extern declarations.
9865
2aa46d6c
CY
98662011-03-14 Chong Yidong <cyd@stupidchicken.com>
9867
c96bbc66 9868 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9869
cffc6f3b
CY
98702011-03-13 Chong Yidong <cyd@stupidchicken.com>
9871
9872 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9873 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9874 These macros can no longer be used for assignment.
9875
44f230aa
SM
9876 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9877 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9878 (record_buffer_markers, fetch_buffer_markers): New functions for
9879 recording and fetching special buffer markers.
9880 (set_buffer_internal_1, set_buffer_temp): Use them.
9881
9882 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9883
9884 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9885
9886 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9887 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9888
9889 * xdisp.c (hscroll_window_tree):
9890 (reconsider_clip_changes): Use PT instead of BUF_PT.
9891
d251f04b
EZ
98922011-03-13 Eli Zaretskii <eliz@gnu.org>
9893
9894 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9895 $(EMACS_ROOT)/lib/intprops.h.
9896
f0c77cd1
PE
98972011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9898
3eca4629
PE
9899 Fix more problems found by GCC 4.5.2's static checks.
9900
7c86ee98
PE
9901 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9902 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9903 (xg_free_frame_widgets): Make it clear that a local variable is
9904 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9905 (gdk_window_get_screen): Make it clear that this macro is needed
9906 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9907 (int_gtk_range_get_value): New function, which avoids a diagnostic
9908 from gcc -Wbad-function-cast.
9909 (xg_set_toolkit_scroll_bar_thumb): Use it.
9910 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9911 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9912 (get_utf8_string, xg_get_file_with_chooser):
9913 Rename locals to avoid shadowing.
9914 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9915
41729b81
PE
9916 * xgselect.c (xg_select): Remove unused var.
9917
f0c77cd1
PE
9918 * image.c (four_corners_best): Mark locals as initialized.
9919 (gif_load): Initialize transparent_p to zero (Bug#8238).
9920 Mark another local as initialized.
ec6cf4c6 9921 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9922
ce0ad53d 9923 * image.c (clear_image_cache): Now static.
d5d5a617 9924 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9925 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9926 (x_edge_detection): Remove unnecessary cast that
9927 gcc -Wbad-function-cast diagnoses.
2037898d 9928 (gif_load): Fix pointer signedness.
6ae141d6
PE
9929 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9930 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9931
33383987 99322011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9933
d32df629
PE
9934 Improve quality of tests for time stamp overflow.
9935 For example, without this patch (encode-time 0 0 0 1 1
9936 1152921504606846976) returns the obviously-bogus value (-948597
9937 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9938 reports time overflow. See
9939 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9940 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9941 * editfns.c: Include limits.h and intprops.h.
9942 (TIME_T_MIN, TIME_T_MAX): New macros.
9943 (time_overflow): Move earlier, to before first use.
9944 (hi_time, lo_time): New functions, for an accurate test for
9945 out-of-range times.
9946 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9947 (Fget_internal_run_time): Don't assume time_t fits in int.
9948 (make_time): Use list2 instead of Fcons twice.
9949 (Fdecode_time): More accurate test for out-of-range times.
9950 (check_tm_member): New function.
9951 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9952 (lisp_time_argument): Don't rely on undefined left-shift and
9953 right-shift behavior when checking for time stamp overflow.
8be6f318 9954
fe31d94c
PE
9955 * editfns.c (time_overflow): New function, refactoring common code.
9956 (Fformat_time_string, Fdecode_time, Fencode_time):
9957 (Fcurrent_time_string): Use it.
9958
8be6f318
PE
9959 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9960 * dired.c (make_time): Move to ...
9961 * editfns.c (make_time): ... here.
9962 * systime.h: Note the move.
9963
09d9db2c 99642011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9965
126bc0dc
YM
9966 * fringe.c (update_window_fringes): Remove unused variables.
9967
c47cbdfd
YM
9968 * unexmacosx.c (copy_data_segment): Also copy __got section.
9969 (Bug#8223)
9970
7ac80be9
EZ
99712011-03-12 Eli Zaretskii <eliz@gnu.org>
9972
c96bbc66 9973 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9974 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9975 Constify `char *' arguments and their references according to
9976 prototypes in tparam.h.
9977
ecb0f94d 9978 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9979
7ac80be9
EZ
9980 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9981 Adapt all references accordingly.
9982
9983 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9984
ef1fd07e
TT
99852011-03-11 Tom Tromey <tromey@redhat.com>
9986
9987 * buffer.c (syms_of_buffer): Remove obsolete comment.
9988
7ef4b50c
EZ
99892011-03-11 Eli Zaretskii <eliz@gnu.org>
9990
9991 * termhooks.h (encode_terminal_code): Declare prototype.
9992
9993 * msdos.c (encode_terminal_code): Don't declare prototype.
9994
9995 * term.c (encode_terminal_code): Now external again, used by
9996 w32console.c and msdos.c.
9997
44f230aa
SM
9998 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9999 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 10000
4b1ec863 100012011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 10002
1714f52b 10003 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 10004
4b1ec863
PE
10005 * fringe.c (update_window_fringes): Mark locals as initialized
10006 (Bug#8227).
10007 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 10008
524c7aa6
PE
10009 * alloc.c (mark_fringe_data): Move decl from here ...
10010 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10011 to check its interface.
10012 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10013
a5c0af81 10014 * fontset.c (free_realized_fontset): Now static.
7519b8cd 10015 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 10016 (fontset_font): Mark local as initialized.
a9a06e0b 10017 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 10018
b4716021
PE
10019 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10020
811e9bac 10021 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 10022 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
10023 (x_own_selection, Fx_disown_selection_internal): Rename locals
10024 to avoid shadowing.
10025 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 10026
7e3ab302
PE
10027 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10028 so that the caller can use some name other than gcpro1.
10029 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
10030 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10031 (Fx_backspace_delete_keys_p):
10032 Use them to avoid shadowing, and rename vars to avoid shadowing.
10033 (x_decode_color, x_set_name, x_window): Now static.
6b437900 10034 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 10035 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
10036 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10037 Remove unused locals.
7e3ab302
PE
10038 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10039 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10040 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10041 macros.
f78faa98 10042
e2b13473
PE
10043 * xterm.h (x_mouse_leave): New decl.
10044
77f23912
PE
10045 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10046 Remove unused functions.
cdf4ba58
PE
10047 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10048 (x_calc_absolute_position): Now static.
7411c686 10049 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 10050 Don't declare local "event" unless it's used.
ed7bf3a5
PE
10051 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10052 unless they are used.
38d0b34a
PE
10053 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10054 (x_fatal_error_signal): Remove; not used.
a6067996
PE
10055 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10056 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10057 (x_error_catcher, x_connection_closed, x_error_handler):
10058 (x_error_quitter, xembed_send_message, x_iconify_frame):
10059 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 10060 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 10061 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 10062
44f230aa
SM
10063 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10064 Rename or move locals to avoid shadowing.
6b463e58 10065 (tty_defined_color, merge_face_heights): Now static.
5967d051 10066 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
10067 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10068 does not deduce is never used uninitialized.
73719eba
PE
10069 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10070 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 10071
426994c3 10072 * terminal.c (store_terminal_param): Now static.
5489860b 10073
032f1620 10074 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 10075 (set_frame_menubar): Remove unused local.
d4323972 10076 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
10077 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10078 since they might point to immutable storage.
281585b0
PE
10079 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10080 since it's unused otherwise.
032f1620 10081
367c19e5 10082 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 10083 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
10084 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10085 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 10086 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
10087 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10088 does not deduce are never used uninitialized.
70739cbe 10089
07b48fa9
PE
10090 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10091
8868a238 10092 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
10093 * window.c (window_loop, size_window):
10094 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 10095
7e5cf297 10096 * window.c (display_buffer): Now static.
d6550a9f
PE
10097 (size_window): Mark variables that gcc -Wuninitialized
10098 does not deduce are never used uninitialized.
a586633d
PE
10099 * window.h (check_all_windows): New decl, to forestall
10100 gcc -Wmissing-prototypes diagnostic.
5b555da1 10101 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 10102
f6095868
PE
10103 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10104 shadowing.
10105 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
10106 Include <limits.h>.
10107 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10108 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
10109 (load_charset_map): Mark variables that gcc -Wuninitialized
10110 does not deduce are never used uninitialized.
53df7c11 10111 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 10112
f38b440c
PE
10113 * coding.c (coding_set_source, coding_set_destination):
10114 Use "else { /* comment */ }" rather than "else /* comment */;"
10115 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
10116 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10117 a block, when the outer 'i' will do.
10118 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10119 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10120 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10121 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10122 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10123 Rename locals to avoid shadowing.
10124 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
10125 * coding.c (emacs_mule_char, encode_invocation_designation):
10126 Now static, since they're not used elsewhere.
413bb2db 10127 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 10128 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
10129 (decode_coding_emacs_mule): Mark variables that gcc
10130 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
10131 (detect_coding_iso_2022): Initialize a local variable that might
10132 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 10133 this initialization is needed. (Bug#8211)
5f58e762
PE
10134 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10135 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10136 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10137 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10138 Remove unused macros.
f38b440c 10139
232b38b9 10140 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 10141 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 10142 * character.c (string_count_byte8): Likewise.
232b38b9 10143
fb90da1b
PE
10144 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10145 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10146
fb93dbc2
PE
10147 * chartab.c (copy_sub_char_table): Now static, since it's not used
10148 elsewhere.
5c156ace
PE
10149 (sub_char_table_ref_and_range, char_table_ref_and_range):
10150 Rename locals to avoid shadowing.
bbcd0949 10151 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 10152
7d3b3862 10153 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 10154 (BIDI_BOB): Remove unused macro.
7d3b3862 10155
6be7d3da
PE
10156 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10157 deduce are never used uninitialized.
c2ed9c8b 10158 * term.c (encode_terminal_code): Likewise.
6be7d3da 10159
75f8807f 10160 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 10161
50938595
PE
10162 * tparam.h: New file.
10163 * term.c, tparam.h: Include it.
10164 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10165 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10166 Move these decls to tparam.h, and make them agree with what
10167 is actually in tparam.c. The previous trick of using incompatible
10168 decls in different modules does not conform to the C standard.
10169 All callers of tparam changed to use tparam's actual API.
10170 * tparam.c (tparam1, tparam, tgoto):
10171 Use const pointers where appropriate.
10172
fbceeba2
PE
10173 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10174 * cm.h (struct cm): Likewise.
10175 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10176 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10177 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10178 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10179 (turn_on_face, init_tty): Likewise.
10180 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10181
7f3f1250
PE
10182 * term.c (term_mouse_position): Rename local to avoid shadowing.
10183
e6ca6543
PE
10184 * alloc.c (mark_ttys): Move decl from here ...
10185 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10186
c40f8d15
AS
101872011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10188
10189 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10190
cfe0661d
JB
101912011-03-09 Juanma Barranquero <lekktu@gmail.com>
10192
10193 * search.c (compile_pattern_1): Remove argument regp, unused since
10194 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10195 (compile_pattern): Don't pass it.
10196
0afb4571
J
101972011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10198
10199 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10200 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10201 for ! HAVE_GTK3.
10202 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10203
10204 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10205
10206 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10207 gdk_window_get_screen, gdk_window_get_geometry,
10208 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10209 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10210 (xg_get_pixbuf_from_pixmap): New function.
10211 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10212 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10213 Call xg_get_pixbuf_from_pixmap instead of
10214 gdk_pixbuf_get_from_drawable.
10215 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10216 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10217 (xg_check_special_colors): Use GtkStyleContext and its functions
10218 for HAVE_GTK3.
10219 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10220 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10221 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10222 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10223 Call gtk_widget_get_preferred_size.
0afb4571
J
10224 (xg_frame_resized): gdk_window_get_geometry only takes 5
10225 parameters.
44f230aa
SM
10226 (xg_win_to_widget, xg_event_is_for_menubar):
10227 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10228 (xg_set_widget_bg): New function.
10229 (delete_cb): New function.
895009e1 10230 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10231 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10232 (xg_set_background_color): Call xg_set_widget_bg.
10233 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10234 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10235 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10236 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10237 if ! HAVE_GTK3.
10238 (update_frame_tool_bar): Call gtk_widget_hide.
10239 (xg_initialize): Use GDK_KEY_g.
10240
10241 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10242 if ! HAVE_GTK3
10243 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10244
10245 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10246 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10247 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10248
1c2cc4ef
JB
102492011-03-08 Juanma Barranquero <lekktu@gmail.com>
10250
10251 * w32xfns.c (select_palette): Check success of RealizePalette against
10252 GDI_ERROR, not zero.
10253
33383987 10254See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10255
10256;; Local Variables:
10257;; coding: utf-8
aac0c6e3
MR
10258;; End:
10259
2f097256 10260 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10261
10262 This file is part of GNU Emacs.
10263
10264 GNU Emacs is free software: you can redistribute it and/or modify
10265 it under the terms of the GNU General Public License as published by
10266 the Free Software Foundation, either version 3 of the License, or
10267 (at your option) any later version.
10268
10269 GNU Emacs is distributed in the hope that it will be useful,
10270 but WITHOUT ANY WARRANTY; without even the implied warranty of
10271 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10272 GNU General Public License for more details.
10273
10274 You should have received a copy of the GNU General Public License
10275 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.