Avoid some portability problems by eschewing 'extern inline' functions.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
09db192c
PE
12011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2
3 Avoid some portability problems by eschewing 'extern inline' functions.
4 The trivial performance wins aren't worth the portability hassles; see
5 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6 et seq.
7 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8 (window_box_width, window_box_left, window_box_left_offset)
9 (window_box_right, window_box_right_offset): Undo previous change,
10 by removing the "extern"s.
11 * intervals.c (adjust_intervals_for_insertion)
12 (adjust_intervals_for_deletion): Undo previous change,
13 making these static again.
14 (offset_intervals, temp_set_point_both, temp_set_point)
15 (copy_intervals_to_string): No longer inline.
16 * xdisp.c (window_text_bottom_y, window_box_width)
17 (window_box_height, window_box_left_offset)
18 (window_box_right_offset, window_box_left, window_box_right)
19 (window_box): No longer inline.
20
105216ed
CY
212011-11-08 Chong Yidong <cyd@gnu.org>
22
23 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
24 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
25 an error if not a live window.
26 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
27 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
28
ae9e237f
JB
292011-11-07 Juanma Barranquero <lekktu@gmail.com>
30
31 * lisp.h (syms_of_abbrev): Remove declaration.
32 Reported by CHENG Gao <chenggao@royau.me>.
33
c7aa8333
EZ
342011-11-07 Eli Zaretskii <eliz@gnu.org>
35
36 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
37 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
38 of temacs in GUI mode.
39
be7f5545
MR
402011-11-07 Martin Rudalics <rudalics@gmx.at>
41
42 * window.h: Declare delete_all_child_windows instead of
43 delete_all_subwindows.
44 * window.c (Fwindow_nest, Fset_window_nest)
45 (Fset_window_new_total, Fset_window_new_normal)
46 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
47 (delete_all_subwindows): Rename to delete_all_child_windows.
48 (Fdelete_other_windows_internal, Fset_window_configuration):
49 Call delete_all_child_windows instead of delete_all_subwindows.
50 * frame.c (delete_frame): Call delete_all_child_windows instead
51 of delete_all_subwindows.
52
ca78dc43
PE
532011-11-07 Paul Eggert <eggert@cs.ucla.edu>
54
55 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
56 This is also needed for porting to any host where GC_MARK_STACK is
57 not GC_MAKE_GCPROS_NOOPS.
58 (which_symbols): Use it.
59
a0241d01
KH
602011-11-07 Kenichi Handa <handa@m17n.org>
61
62 * coding.c (coding_set_destination): Check coding->src_pos only
63 when coding->src_object is a buffer (bug#9910).
64
65 * process.c (send_process): Set the member src_multibyte of coding
66 to 0 (bug#9911) when sending a unibyte text.
67
68 * callproc.c (Fcall_process): Set the member src_multibyte of
69 process_coding to 0 (bug#9912).
70
a64bfdfa 712011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
72
73 * xmenu.c (cleanup_widget_value_tree): New function.
74 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
75 calling free_menubar_widget_value_tree directly (Bug#9830).
76
cb41b32a
PE
772011-11-06 Paul Eggert <eggert@cs.ucla.edu>
78
79 Fix some portability problems with 'inline'.
80 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
81 (window_box_width, window_box_left, window_box_left_offset)
82 (window_box_right, window_box_right_offset): Declare extern.
83 Otherwise, these inline functions do not conform to C99 and
84 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
85 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
86 * intervals.c (adjust_intervals_for_insertion)
87 (adjust_intervals_for_deletion): Now extern, because otherwise the
88 extern inline functions 'offset_intervals' couldn't refer to it.
89 (static_offset_intervals): Remove.
90 (offset_intervals): Rewrite using the old contents of
91 static_offset_intervals. The old version didn't conform to C99
92 because an extern inline function contained a reference to an
93 identifier with static linkage.
94
b7041366
AS
952011-11-06 Andreas Schwab <schwab@linux-m68k.org>
96
97 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
98 GC.
99
88a37c4d
EZ
1002011-11-06 Eli Zaretskii <eliz@gnu.org>
101
102 * xdisp.c (init_iterator, reseat_to_string): Don't set the
103 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
104 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
105 return Qleft_to_right.
106
49745b39
CY
1072011-11-06 Chong Yidong <cyd@gnu.org>
108
109 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
110 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
111 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
112 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
113 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
114 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
115 (Fwindow_vscroll): Doc fix.
116 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
117 argument, since it makes no sense to pass a live window and for
118 consistency with window-child.
119
1f05cd82
CS
1202011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
121
122 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
123 support MSVC.
124
22610910
JR
1252011-11-05 Jason Rumney <jasonr@gnu.org>
126
127 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
128 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
129 fonts (Bug#6029).
130 (add_font_entity_to_list): Fix logic errors in mixed boolean and
131 bitwise arithmetic preventing use of unicode-sip and non-truetype
132 opentype fonts.
133
a06776b2
EZ
1342011-11-05 Eli Zaretskii <eliz@gnu.org>
135
3ad924ba
EZ
136 * s/ms-w32.h (fstat, stat, utime): Move redirections to
137 "emacs"-only part.
138
a06776b2
EZ
139 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
140 initialization code to keep similarity to xfns.c after changes
141 from 2011-11-05.
142
c9e7db78
JD
1432011-11-05 Jan Djärv <jan.h.d@swipnet.se>
144
a97f8f3f
JD
145 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
146 (unwind_create_frame): New function (Bug#9943).
147 (Fx_create_frame): Restructure code to be more similar to the one in
148 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
149 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
150 Move terminal->reference_count++ just before making the frame official
151 (Bug#9943).
152
153 * nsterm.m (x_free_frame_resources): New function.
154 (x_destroy_window): Move code to x_free_frame_resources.
155
c9e7db78
JD
156 * xfns.c (unwind_create_frame): Fix comment.
157 (Fx_create_frame, x_create_tip_frame): Move
158 terminal->reference_count++ just before making the frame
159 official. Move initialization of image_cache_refcount and
160 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
161
a6fc3b5c
EZ
1622011-11-05 Eli Zaretskii <eliz@gnu.org>
163
164 Support MSVC build with newer versions of Visual Studio.
165 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
166 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
167 nt/gmake.defs.
168
169 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
170 which are not supported by MSVC.
171 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
172 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
173 bitfields.
174 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
175 types in bitfields.
176 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
177
178 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
179
1802011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
181
182 Support MSVC build with newer versions of Visual Studio.
183 * w32.c: Don't include w32api.h for MSVC.
184 (init_environment) [_MSC_VER]: Call sys_access, not _access.
185
186 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
187 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
188 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
189 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
190 e_* cousins.
191 (alloca) [_MSC_VER]: Define to _alloca.
192
193 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
194
195 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
196
a58c13ed
EZ
1972011-11-04 Eli Zaretskii <eliz@gnu.org>
198
199 * xdisp.c (note_mouse_highlight): If either of
200 previous/next-single-property-change returns nil, treat that as
201 the beginning or the end of the buffer. (Bug#9955)
202
fe0b6370
JD
2032011-11-04 Jan Djärv <jan.h.d@swipnet.se>
204
a58c13ed 205 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
206 label is not null (Bug#9951).
207 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
208 may be NULL.
209
89bd5ee1
EZ
2102011-11-04 Eli Zaretskii <eliz@gnu.org>
211
212 * window.c (Fwindow_body_size): Mention in the doc string that the
213 return value is in frame's canonical units. (Bug#9949)
214
84c3edb9
EZ
2152011-11-03 Eli Zaretskii <eliz@gnu.org>
216
4e2fb5c7
EZ
217 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
218
84c3edb9 219 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 220 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 221 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 222
bc17a887
EZ
2232011-11-01 Eli Zaretskii <eliz@gnu.org>
224
225 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
226 Don't stop backward scan on the continuation glyph, even though
227 its CHARPOS is positive.
26b46e51
EZ
228 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
229 cover_string to disp_string.
bc17a887 230
4ee88440
MR
2312011-11-01 Martin Rudalics <rudalics@gmx.at>
232
233 * window.c (temp_output_buffer_show): Don't use
234 Vtemp_buffer_show_specifiers.
235 (Vtemp_buffer_show_specifiers): Remove unused variable.
236
c2ff3c02
EZ
2372011-10-30 Eli Zaretskii <eliz@gnu.org>
238
239 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
240 past the beginning of the current glyph matrix.
241
6e56383b
JD
2422011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
243
244 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
245 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
246 HAVE_GTK3 (Bug#9869).
b77a6a7f 247
3b574623
JD
248 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
249 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
250
b77a6a7f
JD
251 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
252
253 * xterm.c: Declare x_handle_net_wm_state to return int.
254 (handle_one_xevent): Check if we are iconified but don't have
255 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
256 (get_current_wm_state): Return non-zero if not hidden,
257 check for _NET_WM_STATE_HIDDEN (Bug#9893).
258 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
259 (x_handle_net_wm_state): Return what get_current_wm_state returns.
260 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
261
196e41e4
PE
2622011-10-29 Paul Eggert <eggert@cs.ucla.edu>
263
264 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
265 so that this new function doesn't get optimized away by a
266 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
267
021f2e1a
AS
2682011-10-29 Andreas Schwab <schwab@linux-m68k.org>
269
270 * frame.h (MOUSE_HL_INFO): Remove excess parens.
271
8b058d44
EZ
2722011-10-29 Eli Zaretskii <eliz@gnu.org>
273
274 Fix the `xbytecode' command.
275 * .gdbinit (xprintbytestr): New command.
276 (xwhichsymbols): Renamed from `which'; all callers changed.
277 (xbytecode): Print the byte-code string as well.
278
4452fb80
EZ
2792011-10-29 Kim Storm <storm@cua.dk>
280
8b058d44
EZ
281 * alloc.c (which_symbols): New function.
282
21b72067
AS
2832011-10-29 Andreas Schwab <schwab@linux-m68k.org>
284
285 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
286 line. (Bug#9903)
287
83ed7b5c
GM
2882011-10-29 Glenn Morris <rgm@gnu.org>
289
290 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
291 Not clear what it was for, and it causes various bugs. (Bug#9839)
292
5a7a728b
EZ
2932011-10-28 Eli Zaretskii <eliz@gnu.org>
294
295 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
296 possible random value that matches one of those tested as
297 condition to clear the mouse face.
298
d3d0842f
CY
2992011-10-28 Chong Yidong <cyd@gnu.org>
300
301 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
302
31b39d13
DN
3032011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
304
305 * window.c (make_window): Initialize phys_cursor_on_p.
306
9aba6043
SM
3072011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
308
309 * lisp.h (struct Lisp_Symbol): Update comments.
310
c20992f4
JB
3112011-10-28 Juanma Barranquero <lekktu@gmail.com>
312
313 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
314
db4f02f2
EZ
3152011-10-28 Eli Zaretskii <eliz@gnu.org>
316
317 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
318 <oslsachem@gmail.com> for helping to debug this.
319
320 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
321 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
322 (g_b_init_get_glyph_outline_w): New static variables.
323 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
324 (GetGlyphOutlineW_Proc): New typedefs.
325 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
326 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
327 New functions.
328 (w32font_open_internal, compute_metrics):
329 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
330 instead of calling the "wide" APIs directly.
331
332 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
333
334 * w32.h (syms_of_w32font): Add prototype.
335
87e68db4
JB
3362011-10-27 Juanma Barranquero <lekktu@gmail.com>
337
338 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
339 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
340 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
341 (Fmove_to_window_line): Doc fix.
342
435c1d67
CY
3432011-10-27 Chong Yidong <cyd@gnu.org>
344
345 * process.c (make_process): Set gnutls_state to NULL.
346
347 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
348 non-NULL, regardless of GNUTLS_INITSTAGE.
349 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
350 an error. Set process slots as soon as we allocate them.
351
352 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
353
9c6c6f49
CY
3542011-10-27 Chong Yidong <cyd@gnu.org>
355
9aba6043
SM
356 * gnutls.c (emacs_gnutls_deinit): New function.
357 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
358 (Fgnutls_deinit, Fgnutls_boot): Use it.
359
360 * process.c (make_process): Initialize GnuTLS credentials to NULL.
361 (deactivate_process): Call emacs_gnutls_deinit.
362
657d08d3
JB
3632011-10-27 Juanma Barranquero <lekktu@gmail.com>
364
365 * image.c (x_create_x_image_and_pixmap):
366 * w32.c (sys_rename, w32_delayed_load):
367 * w32font.c (fill_in_logfont):
368 * w32reg.c (x_get_string_resource): Silence compiler warnings.
369
5430d399
JB
3702011-10-26 Juanma Barranquero <lekktu@gmail.com>
371
372 * w32fns.c (w32_default_color_map): New function,
373 extracted from Fw32_default_color_map.
a7ef684b 374 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 375
fe0055fa
PE
3762011-10-25 Paul Eggert <eggert@cs.ucla.edu>
377
378 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
379
e6346438
SM
3802011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
381
382 * keyboard.c (test_undefined): New function (bug#9751).
383 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
384
e112cc37
ET
3852011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
386
387 * sysdep.c (init_sys_modes): Fix the check for the controlling
388 terminal (Bug#6649).
389
7b5d6677
EZ
3902011-10-20 Eli Zaretskii <eliz@gnu.org>
391
392 * dispextern.h (struct bidi_it): New member next_en_type.
393
394 * bidi.c (bidi_line_init): Initialize the next_en_type member.
395 (bidi_resolve_explicit_1): When next_en_pos is valid for the
396 current character, check also for next_en_type being WEAK_EN.
397 (bidi_resolve_weak): Don't enter the expensive loop if the current
398 position is before next_en_pos. Record the bidi type of the first
399 non-ET, non-BN character we find, in addition to its position.
400 (bidi_level_of_next_char): Invalidate next_en_type when
401 next_en_pos is over-stepped.
402
7da0b018
PE
4032011-10-20 Paul Eggert <eggert@cs.ucla.edu>
404
405 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
406 * editfns.c: Rewrite current-time-zone so that it invokes
407 the equivalent of (format-time-string "%Z") to get the time zone name.
408 This fixes a bug when the time zone name contains characters that
409 need converting from the system time locale to Emacs internal format.
410 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
411 that patch fixed format-time-string to do the conversion, but
412 I forgot to fix current-time-zone.
413 (format_time_string): New function, containing most of
414 what Fformat_time_string used to contain.
415 (Fformat_time_string): Rewrite in terms of format_time_string.
416 This doesn't change this function's behavior.
417 (current-time-zone): Rewrite to use format_time_string.
418 This fixes the bug reported by Michael Schierl in
419 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
420 Jason Rumney's 2007-06-07 change worked around this bug, but
421 didn't fix it.
422 * systime.h (tzname, timezone): Remove no-longer-used declarations.
423
8547b010
EZ
4242011-10-19 Eli Zaretskii <eliz@gnu.org>
425
426 * xdisp.c (start_display): If the character at POS is displayed
427 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
428 (try_window_reusing_current_matrix): If a line ends in a display
429 vector or the next line starts in a display vector, continue
430 redrawing the window even though the character position of
431 start_row was reached.
8547b010
EZ
432 (Bug#9771, part 2)
433
4e948d15
CY
4342011-10-18 Chong Yidong <cyd@gnu.org>
435
436 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
437 with nobreak-char-display too.
438
4787455f
EZ
4392011-10-18 Eli Zaretskii <eliz@gnu.org>
440
441 Fix part 3 of bug#9771.
442 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
443 (bidi_resolve_neutral): Don't enter the expensive loop looking for
444 non-neutral characters if the current character is a paragraph
445 separator (a.k.a. Newline). This avoids running the same
446 expensive loop twice, once when we consume the preceding newline
447 and the other time when the line actually needs to be displayed.
448 Avoid the loop when we see neutrals on the base embedding level
449 following a character whose directionality is the same as the
450 paragraph's. This avoids running the expensive loop when a line
451 ends in a long sequence of neutrals, like control characters.
452 Add assertion against STRONG_AL type. Slightly rearrange code
453 that determines the type of a neutral given the first non-neutral
454 that follows it.
455 (bidi_level_of_next_char): Set next_en_pos to zero when
456 invalidating its info.
457
2c91f553
EZ
4582011-10-17 Eli Zaretskii <eliz@gnu.org>
459
460 * xdisp.c (push_display_prop): Determine whether to record string
461 or buffer position by IT->string, not by IT->method. Allow
462 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
463 (move_it_vertically_backward): Don't look for character position
464 immediately after the newline when in a continuation line.
465 (Bug#9771, part 1)
2c91f553 466
c7b08b0d
MR
4672011-10-15 Martin Rudalics <rudalics@gmx.at>
468
469 * window.c (coordinates_in_window): Rewrite and delabelize
470 vertical border check. (Bug#5357) (Bug#9618)
471
6b02f655
SM
4722011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
473
474 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
475 errors in XSetWindowBorder (bug#9310).
476
81d40c92
DA
4772011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
478
479 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
480 avoid crash when xmalloc overrun checking is enabled.
481
d4172c3b
EZ
4822011-10-13 Eli Zaretskii <eliz@gnu.org>
483
484 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
485 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
486 cursor motion with <left> and <right> arrow keys.
487
488 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
489 some callers set that themselves.
490
b00eea75
EZ
4912011-10-12 Eli Zaretskii <eliz@gnu.org>
492
493 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
494 display string and the previous row comes from the same string and
495 is empty. (Bug#9739) (Bug#9738)
496
8fe012c4
SM
4972011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
498
499 * doc.c (get_doc_string): Encode file name (bug#9735).
500
0074aef2
EZ
5012011-10-12 Eli Zaretskii <eliz@gnu.org>
502
79beb178
EZ
503 * bidi.c (bidi_level_of_next_char):
504 * xdisp.c (get_visually_first_element): Remove old incorrect
505 comments regarding the Unicode Line Separator character.
506
0074aef2
EZ
507 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
508
6e4b3fbe
DA
5092011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
510
511 * alloc.c (Fgc_status): Do not access beyond zombies array
512 boundary if nzombies > MAX_ZOMBIES.
513 * alloc.c (dump_zombies): Add missing format specifier.
514
0324f3af
PE
5152011-10-12 Paul Eggert <eggert@cs.ucla.edu>
516
b5525cac
PE
517 * xdisp.c (set_cursor_from_row): Simplify conditionals,
518 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
519
0324f3af
PE
520 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
521 Some packages use them to denote characters with modifiers.
522
e9b5f888
AS
5232011-10-11 Andreas Schwab <schwab@linux-m68k.org>
524
525 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
526 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
527 matching a pp-number. Rename parameter var to var1.
528
127827c0
SM
5292011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
530
531 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
532
c8fd3bd0
GM
5332011-10-08 Glenn Morris <rgm@gnu.org>
534
535 * callint.c (Fcall_interactively): Give a more explicit error for the
536 'c' case with a non-character input. (Bug#8479)
537
352ec8ff
EZ
5382011-10-08 Eli Zaretskii <eliz@gnu.org>
539
03669ccb
EZ
540 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
541 lines.
7061c986
EZ
542 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
543 lines that are hscrolled on the left.
03669ccb 544
352ec8ff
EZ
545 * dispnew.c (buffer_posn_from_coords): Account for a possible
546 presence of header-line. (Bug#4426)
547
a66cfb1c
SM
5482011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
549
6b02f655
SM
550 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
551 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 552
7c5ee88e
PE
5532011-10-07 Paul Eggert <eggert@cs.ucla.edu>
554
555 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
556 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
557 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
558 this makes Emacs dump core during garbage collection on rare
559 occasions. sizeof is obviously inferior to offsetof here, so
560 stick with offsetof.
561 (GC_POINTER_ALIGNMENT): New macro.
562 (mark_memory): Omit 3rd (offset) arg; caller changed.
563 Don't assume EMACS_INT alignment is the same as pointer alignment.
564
df1bbe5b
SM
5652011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
566
567 * keyboard.c (read_key_sequence_remapped): New var.
568 (read_key_sequence): Compute remapping in the right buffer.
569 (command_loop_1): Use read_key_sequence's remapping directly.
570
51553db6
SM
5712011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
572
32c1fffd
SM
573 * dired.c (file_name_completion): Don't expand file name.
574 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
575 before checking file name handler.
576
51553db6
SM
577 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
578 they've been requested explicitly (bug#9591).
579
b6bd1599 5802011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
581
582 * keymap.c (Fsingle_key_description): Use make_specified_string
583 instead of build_string to build string from push_key_description.
584 (Bug#5193)
585
f701dc2a
PE
5862011-09-30 Paul Eggert <eggert@cs.ucla.edu>
587
4222c55d
PE
588 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
589 This fixes a Y2038 bug on 64-bit hosts.
590 * buffer.c (reset_buffer):
591 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
592 (Fclear_buffer_auto_save_failure):
593 Use 0, not -1, to represent an unset failure time, since time_t
594 might not be signed.
595
f701dc2a
PE
596 Remove dependency on glibc malloc internals.
597 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
598 Move back here from lisp.h, but with their new implementations.
599 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
600 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
601 * charset.c (charset_table_init): New static var.
602 (syms_of_charset): Use it instead of xmalloc. This removes a
603 dependency on glibc malloc internals. See Eli Zaretskii's comment in
604 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
605 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
606 Move back to alloc.c.
607 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
608 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
609
9ceebf39
JD
6102011-09-30 Jan Djärv <jan.h.d@swipnet.se>
611
612 * nsterm.m (windowDidResize): Call x_set_window_size only when
613 ns_in_resize is true. Otherwise set pixelwidth/height and
614 call change_frame_size (Bug#9628).
615
cb993c58
PE
6162011-09-30 Paul Eggert <eggert@cs.ucla.edu>
617
3930c88b
PE
618 Port --enable-checking=all to Fedora 14 x86-64.
619 * charset.c (syms_of_charset): Also account for glibc malloc's
620 internal overhead when calculating the initial malloc maximum.
621
cb993c58
PE
622 Port --enable-checking=all to Fedora 14 x86.
623 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
624 Move to lisp.h.
625 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
626 (overrun_check_realloc, overrun_check_free):
627 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
628 That way, xmalloc returns a properly-aligned pointer even if
629 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
630 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
631 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
632 into account when calculating the initial malloc maximum.
633 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
634 Move here from alloc.c, so that charset.c can use it too.
635 Properly align; the old code wasn't right for common 32-bit hosts
636 when configured with --enable-checking=all.
637 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
638 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
639
31bed486
EZ
6402011-09-29 Eli Zaretskii <eliz@gnu.org>
641
04c70788 642 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
643 use EDOM.
644
fbcaa2f3
EZ
6452011-09-28 Eli Zaretskii <eliz@gnu.org>
646
647 * xdisp.c (compute_display_string_end): If there's no display
648 string at CHARPOS, return -1.
649
650 * bidi.c (bidi_fetch_char): When compute_display_string_end
651 returns a negative value, treat the character as a normal
652 character not covered by a display string. (Bug#9624)
653
a239d4e9
JB
6542011-09-28 Juanma Barranquero <lekktu@gmail.com>
655
656 * lread.c (Fread_from_string): Fix typo in docstring.
657
88652fd5
EZ
6582011-09-27 Eli Zaretskii <eliz@gnu.org>
659
660 * xdisp.c (handle_invisible_prop): If invisible text ends on a
661 newline, reseat the iterator instead of bidi-iterating there one
662 character at a time. (Bug#9610)
32c1fffd
SM
663 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
664 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 665
ed497dd4
AS
6662011-09-27 Andreas Schwab <schwab@linux-m68k.org>
667
668 * lread.c (readevalloop): Use correct code for NBSP.
669 (read1): Likewise. (Bug#9608)
670
b2bf61aa
MA
6712011-09-25 Michael Albinus <michael.albinus@gmx.de>
672
673 * dbusbind.c (Fdbus_register_signal): When service is not
674 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
675
32bbb17c
GM
6762011-09-25 Glenn Morris <rgm@gnu.org>
677
678 * buffer.c (truncate-lines): Doc fix.
679
94e0933e
CY
6802011-09-24 Chong Yidong <cyd@stupidchicken.com>
681
682 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
683 (Fset_window_next_buffers): Doc fix.
684
cddde921
GM
6852011-09-24 Glenn Morris <rgm@gnu.org>
686
687 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
688
1260aef1
PE
6892011-09-24 Paul Eggert <eggert@cs.ucla.edu>
690
25b4bfa0
PE
691 Fix minor problems found by static checking.
692 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
693 * indent.c (Fvertical_motion): Fix == vs = typo.
694
e3cbd34b
EZ
6952011-09-24 Eli Zaretskii <eliz@gnu.org>
696
a66cfb1c
SM
697 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
698 Default value is now t. Doc fix.
6bf7006f 699
e3cbd34b 700 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 701 logic when moving up, not only when moving down. Fix the
e3cbd34b 702 confusing name and values of the it_overshoot_expected variable;
32c1fffd 703 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
704
705 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
706 CHARPOS is covered by a display string which includes newlines.
707 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
708 is covered by a display string with embedded newlines.
709
a3de0cbd
MA
7102011-09-24 Michael Albinus <michael.albinus@gmx.de>
711
712 * dbusbind.c (Fdbus_register_signal): Add match rule to
713 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
714 (Fdbus_register_method, Vdbus_registered_objects_table):
715 Fix docstring.
a3de0cbd 716
b260039d
JM
7172011-09-24 Jim Meyering <meyering@redhat.com>
718
32c1fffd 719 do not ignore write error for any output size
b260039d
JM
720 The previous change was incomplete.
721 While it makes emacs --batch detect the vast majority of stdout
722 write failures, errors were still ignored whenever the output size is
723 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
724 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
725 && echo FAIL: ignored write error
726 FAIL: ignored write error
727 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
728 && echo FAIL: ignored write error
729 FAIL: ignored write error
730 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
731
8eca8a7c
AS
7322011-09-23 Andreas Schwab <schwab@linux-m68k.org>
733
734 * emacs.c (Fkill_emacs): In noninteractive mode exit
735 non-successfully if a write error occurred on stdout. (Bug#9574)
736
3341db62
EZ
7372011-09-21 Eli Zaretskii <eliz@gnu.org>
738
739 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
740 the xassert test.
741
742 * dispextern.h (struct it): Update the comment documenting what
743 can it->OBJECT be.
744
8c203dbf
EZ
7452011-09-20 Eli Zaretskii <eliz@gnu.org>
746
747 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
748 a display string, extend search for cursor position to end of row.
749 (find_row_edges): If the row ends in a newline from a display
750 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
751 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
752 (Fcurrent_bidi_paragraph_direction): Fix search for previous
753 non-empty line. Fixes confusing cursor motion with arrow keys at
754 the beginning of a line that starts with whitespace.
8c203dbf 755
a4824228
LMI
7562011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
757
758 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
759 (bug#9493).
760
33ed493b
CY
7612011-09-18 Chong Yidong <cyd@stupidchicken.com>
762
763 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
764 boolean (Bug#9154).
765
56cd55c8
EZ
7662011-09-18 Eli Zaretskii <eliz@gnu.org>
767
768 * xdisp.c (display_line): Record maximum and minimum buffer
769 positions even if no glyphs were produced (e.g., by a zero-width
770 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
771 buffer positions that will be removed from the glyph row because
772 they don't fit.
c02dcedf
EZ
773 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
774 column is beyond frame width: don't subtract 1 "pixel" when
775 computing width of the stretch.
3e62b7e0
EZ
776 (reseat_at_next_visible_line_start): Undo the change made on
777 2011-09-17 that saved paragraph information and restored it after
778 the call to `reseat'. (Bug#9545)
56cd55c8 779
5ed99d36 7802011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
781
782 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
783 and turn window cursor on if cleared (Bug#9415).
784
5ed99d36 7852011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
786
787 * search.c (boyer_moore): Take unibyte characters from pattern
788 literally. (Bug#9458)
789
9bade7b2
EZ
7902011-09-18 Eli Zaretskii <eliz@gnu.org>
791
792 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
793
e5e9d610
PE
7942011-09-18 Paul Eggert <eggert@cs.ucla.edu>
795
87e4427a
PE
796 Fix minor problem found by static checking.
797 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
798 initialized, to pacify gcc -Wuninitialized.
799
e5e9d610
PE
800 * fileio.c: Report proper errno when syscall falls.
801 (Finsert_file_contents): Save and restore errno,
802 so that report_file_error outputs the correct diagnostic.
803 (Fwrite_region) [CLASH_DETECTION]: Likewise.
804
a1674f0b
EZ
8052011-09-18 Eli Zaretskii <eliz@gnu.org>
806
807 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
808
fbfb6dd4
EZ
8092011-09-17 Eli Zaretskii <eliz@gnu.org>
810
811 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
812 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
813
bb187662
EZ
8142011-09-17 Eli Zaretskii <eliz@gnu.org>
815
1137e8b8 816 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 817 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
818
819 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
820 (bidi_find_paragraph_start): Search back for paragraph beginning
821 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
822 (bidi_move_to_visually_next): Only trigger paragraph-related
823 computations when the last character is a newline or at EOB, not
824 just any NEUTRAL_B. (Bug#9470)
825
bb187662
EZ
826 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
827 truncated lines if point is covered by a display string. (Bug#9524)
828
2e621251
PE
8292011-09-16 Paul Eggert <eggert@cs.ucla.edu>
830
831 * xselect.c: Relax test for outgoing X longs (Bug#9498).
832 (cons_to_x_long): New function.
833 (lisp_data_to_selection_data): Use it. Correct the test for
834 short-versus-long data; it was negated. Break out of vector
835 loop, for efficiency, when a long datum is discovered.
836
91a15bc6
SM
8372011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
838
839 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
840
b41c3a35
EZ
8412011-09-16 Eli Zaretskii <eliz@gnu.org>
842
843 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
844 GCC PR/17406) by declaring this function with external scope.
845
7812ba2d
PE
8462011-09-15 Paul Eggert <eggert@cs.ucla.edu>
847
848 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
849 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
850
cf7edc2a
AS
8512011-09-15 Andreas Schwab <schwab@linux-m68k.org>
852
853 * editfns.c (Fformat): Correctly handle text properties on "%%".
854
bd01620e
EZ
8552011-09-15 Eli Zaretskii <eliz@gnu.org>
856
857 * xterm.c (x_draw_composite_glyph_string_foreground):
858 * w32term.c (x_draw_composite_glyph_string_foreground):
859 * term.c (encode_terminal_code):
860 * composite.c (composition_update_it, get_composition_id):
861 * xdisp.c (get_next_display_element)
862 (fill_composite_glyph_string): Add comments about special meaning
863 of TAB characters in a composition.
864
a02719a3
PE
8652011-09-15 Paul Eggert <eggert@cs.ucla.edu>
866
867 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
868 This occurs when processing a multibyte format.
869 Problem reported by Wolfgang Jenker.
a02719a3 870
72589a3c
JB
8712011-09-15 Johan Bockgård <bojohan@gnu.org>
872
873 * xdisp.c (try_cursor_movement): Only check for exact match if
874 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
875
1c14176c
PE
8762011-09-14 Paul Eggert <eggert@cs.ucla.edu>
877
878 Remove unused external symbols.
879 * dispextern.h (calc_pixel_width_or_height): Remove decl.
880 * xdisp.c (calc_pixel_width_or_height): Now static.
881 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
882 * indent.c (check_display_width):
883 * w32term.c: Fix comment to match code.
884 * xterm.c, xterm.h (x_catching_errors): Remove.
885
d2eea5b5
PE
8862011-09-14 Paul Eggert <eggert@cs.ucla.edu>
887
888 * xselect.c: Use signed conversions more consistently (Bug#9498).
889 (selection_data_to_lisp_data): Assume incoming selection data are
890 signed integers, not unsigned. This is to be consistent with
891 outgoing selection data, which was modified to use signed integers
892 in as part of the fix to Bug#9196 in response to Jan D.'s comment
893 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
894 expects long, not unsigned long.
895
46888499
EZ
8962011-09-14 Eli Zaretskii <eliz@gnu.org>
897
898 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
899 computation of loop end. Reported by Johan Bockgård
900 <bojohan@gnu.org>.
901
ef8ef9fb
CY
9022011-09-13 Chong Yidong <cyd@stupidchicken.com>
903
904 * frame.c (Fother_visible_frames_p): Function deleted.
905
fa819fed
EZ
9062011-09-12 Eli Zaretskii <eliz@gnu.org>
907
908 * indent.c (compute_motion): Process display vector front to back
909 rather than the other way around. (Bug#2496)
910
2ba8e008
SM
9112011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
912
913 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
914
20f53c69
CY
9152011-09-11 Chong Yidong <cyd@stupidchicken.com>
916
917 * minibuf.c (Fread_from_minibuffer): Doc fix.
918
d562d7a4
EZ
9192011-09-11 Eli Zaretskii <eliz@gnu.org>
920
921 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
922 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
923
1c4d7f3d
LMI
9242011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
925
926 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
927 value for non-existent files.
928
b885bf36
EZ
9292011-09-11 Eli Zaretskii <eliz@gnu.org>
930
931 * fileio.c (Finsert_file_contents): If the file cannot be opened,
932 set its "size" to -1. This will set the modtime_size field of
933 the corresponding buffer to -1, which is what
934 verify-visited-file-modtime expects for files that do not exist.
935 (Bug#9139)
936
6612f0bf
PE
9372011-09-11 Paul Eggert <eggert@cs.ucla.edu>
938
939 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
940 here ...
941 * lisp.h: ... from here. push_key_description is no longer
942 defined in keyboard.c, so its declaration should not be in
943 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
944 logically belongs with push_key_description.
945
dfb3f755
PE
9462011-09-10 Paul Eggert <eggert@cs.ucla.edu>
947
948 * buffer.h: Include <sys/types.h> instead of <time.h>.
949 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
950 Problem reported by Herbert J. Skuhra.
951
3134906c
LMI
9522011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
953
954 * xml.c (parse_region): Make the parsing work for
955 non-comment-starting XML files again (bug#9144).
956
8d903f4e
AS
9572011-09-10 Andreas Schwab <schwab@linux-m68k.org>
958
959 * image.c (gif_load): Fix calculation of bottom and right corner.
960 (Bug#9468)
961
80ad64f4
EZ
9622011-09-10 Eli Zaretskii <eliz@gnu.org>
963
964 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
965 redisplay in small windows.
966
208a048d
EZ
9672011-09-09 Eli Zaretskii <eliz@gnu.org>
968
969 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
970
9b1c252e
MR
9712011-09-08 Martin Rudalics <rudalics@gmx.at>
972
973 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
974 Operate on live windows only.
975
2949f33b
JB
9762011-09-08 Juanma Barranquero <lekktu@gmail.com>
977
978 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
979
e08dcafd
EZ
9802011-09-07 Eli Zaretskii <eliz@gnu.org>
981
982 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
983 only under bidi iteration.
984
115b96bd
JD
9852011-09-07 Jan Djärv <jan.h.d@swipnet.se>
986
987 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
988
c8199d0f
PE
9892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
990
991 isnan: Fix porting problem to Solaris 10 with bundled gcc.
992 Without this fix, the command to link temacs failed due to an
993 undefined symbol __builtin_isnan. This is because
994 /usr/include/iso/math_c99.h #defines isnan(x) to
995 __builtin_isnan(x), but the bundled gcc, which identifies itself
996 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
997 a __builtin_isnan.
998 * floatfns.c (isnan): #undef, and then #define to a clone of
999 what's in data.c.
1000 (Fisnan): Always define, since it's always available now.
1001 (syms_of_floatfns): Always define isnan at the Lisp level.
1002
e39b275c 10032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1004
1005 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1006
b2db44d9 10072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1008
f4af5137 1009 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1010 The previous code assumed that file offsets (off_t values) fit in
1011 EMACS_INT variables, which is not true on typical 32-bit hosts.
1012 The code messed up by falsely reporting buffer overflow in cases
1013 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1014 when "big" contains more than 2**29 bytes, even though this
1015 inserts just one byte and does not overflow the buffer.
1016 (Finsert_file_contents): Store file offsets as off_t
1017 values, not as EMACS_INT values. Check for overflow when
1018 converting between EMACS_INT and off_t. When checking for
1019 buffer overflow or for overlap, take the offsets into account.
1020 Don't use EMACS_INT for small values where int suffices.
1021 When checking for overlap, fix a typo: ZV was used where
1022 ZV_BYTE was intended.
1023 (Fwrite_region): Don't assume off_t fits into 'long'.
1024 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1025
ecfc0a49
MA
10262011-09-05 Michael Albinus <michael.albinus@gmx.de>
1027
1028 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1029
6511acf2 10302011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1031
0999621a 1032 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1033
1034 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1035 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1036 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1037 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1038 (modify_event_symbol): Do not assume that the length of
1039 name_alist_or_stem is safe to alloca and fits in int.
1040 (Fexecute_extended_command): Likewise for function name and binding.
1041 (Frecursion_depth): Wrap around reliably on integer overflow.
1042 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1043 since some callers pass EMACS_INT values.
1044 (Fsingle_key_description): Don't crash if symbol name contains more
1045 than MAX_ALLOCA bytes.
1046 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1047 (get_minibuffer): Arg is now EMACS_INT, not int.
1048 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1049 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1050 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1051
2be7d702
PE
1052 * dbusbind.c (signature_cat): New function.
1053 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1054 Do not overrun buffer; instead, report string overflow.
1055
9d1df220
PE
1056 * dispnew.c (add_window_display_history): Don't overrun buffer.
1057 Truncate instead; this is OK since it's just a log.
1058
33ef5c64
PE
1059 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1060 even if the time zone offset is outlandishly large.
1061 Don't mishandle offset == INT_MIN.
1062
66c6fdd5
PE
1063 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1064 when creating daemon; the previous buffer-overflow check was incorrect.
1065
d749b01b
PE
1066 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1067 which has the guts of the old verror function.
1068
b5cd1905
PE
1069 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1070 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1071
6e1a67fb
PE
1072 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1073 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1074 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1075 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1076 length of string rather than counting it via multiple sprintfs;
1077 that's simpler and more reliable.
c21721cc
PE
1078 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1079 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1080 sprintf, in case result does not fit in int.
1081
c57b67fc
PE
1082 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1083 (fontset_from_font): Print it.
1084
8a401434
PE
1085 * frame.c (tty_frame_count): Now printmax_t, not int.
1086 (make_terminal_frame, set_term_frame_name): Print it.
1087 (x_report_frame_params): In X, window IDs are unsigned long,
1088 not signed long, so print them as unsigned.
1089 (validate_x_resource_name): Check for implausibly long names,
1090 and don't assume name length fits in 'int'.
1091 (x_get_resource_string): Don't blindly alloca invocation name;
1092 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1093 not fit in int.
1094
6e1a67fb
PE
1095 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1096 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1097 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1098
0df02bf3
PE
1099 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1100 Use esprintf, not sprintf, in case result does not fit in int.
1101
48e30793
PE
1102 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1103 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1104 it as a large positive number.
1105 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1106 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1107
a66ff6d8
PE
1108 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1109 in case result does not fit in int.
1110
aca216ff
PE
1111 * print.c (float_to_string): Detect width overflow more reliably.
1112 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1113 buffer overrun. Don't assume list length fits in 'int'. Treat
1114 print length of 0 as 0, not as infinity; to be consistent with other
1115 uses of print length in this function. Don't overflow print length
1116 index. Don't assume hash table size fits in 'long', or that
1117 vectorlike size fits in 'unsigned long'.
1118
31c286f7
PE
1119 * process.c (make_process): Use printmax_t, not int, to format
1120 process-name gensyms.
1121
55e5faa1
PE
1122 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1123
80f2e268
PE
1124 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1125 to avoid potential buffer overrun.
1126
670741ab
PE
1127 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1128 if X resource line is longer than 512 bytes.
1129
b7163a50
PE
1130 * xfns.c (x_window): Make sprintf buffer a bit bigger
1131 to avoid potential buffer overrun.
1132
ae58ff1f
PE
1133 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1134
c43c8a6a
PE
1135 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1136
3f8236f4
PE
11372011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1138
53e9fe90 1139 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1140 Without these, Emacs silently mishandles large integers sometimes.
1141 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1142 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1143
6511acf2
PE
1144 * xdisp.c (try_window_id): Check Emacs fixnum range before
1145 converting to 'int'.
806add1d 1146
6511acf2 1147 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1148 Check that an Emacs fixnum is in range before assigning it to 'int'.
1149 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1150 values converted from Emacs fixnums.
1151 (Frecenter): Don't wrap around a line count if it is out of 'int'
1152 range; instead, treat it as an extreme value.
1153 (Fset_window_configuration, compare_window_configurations):
1154 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1155
6511acf2
PE
1156 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1157 that can exceed INT_MAX. Check that EMACS_INT value is in range
1158 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1159 (match_limit): Don't assume that a fixnum can fit in 'int'.
1160
6511acf2 1161 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1162 exceed INT_MAX.
1163
6511acf2 1164 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1165 (Fvertical_motion): Don't wrap around LINES values that don't fit
1166 in 'int'. Instead, treat them as extreme values. This is good
1167 enough for windows, which can't have more than INT_MAX lines anyway.
1168
fcb901a7
LMI
11692011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1170
0f2f6b6d
LMI
1171 * Require libxml/parser.h to avoid compilation warning.
1172
fcb901a7
LMI
1173 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1174
1175 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1176 since this reportedly can destroy thread storage.
1177
6e20a0d4
CY
11782011-08-30 Chong Yidong <cyd@stupidchicken.com>
1179
1180 * syntax.c (find_defun_start): Update all cache variables if
1181 exiting early (Bug#9401).
1182
148ae00e
EZ
11832011-08-30 Eli Zaretskii <eliz@gnu.org>
1184
f6cfbd8f
EZ
1185 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1186
148ae00e
EZ
1187 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1188 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1189 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1190
1191 * term.c (tty_append_glyph): New function.
1192 (produce_stretch_glyph): Static function and its prototype deleted.
1193
a66cfb1c
SM
1194 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1195 Add prototypes.
148ae00e 1196
c4a07a4c
PE
11972011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1198
1199 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1200 when checking :margin (Bug#9390).
1201 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1202 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1203 so that the name doesn't mislead. All uses changed.
1204
6bc8cd65
JB
12052011-08-28 Johan Bockgård <bojohan@gnu.org>
1206
1207 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1208 set_tty_hooks.
1209
dca4927e
EZ
12102011-08-27 Eli Zaretskii <eliz@gnu.org>
1211
1212 * xdisp.c (move_it_to): Don't bail out early when reaching
1213 position beyond to_charpos, if we are scanning backwards.
1214 (move_it_vertically_backward): When DY == 0, make sure we get to
1215 the first character in the line after the newline.
1216
f2cad773
PE
12172011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1218
1219 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1220 (ccl_driver): Do not generate an out-of-range pointer.
1221 (Fccl_execute_on_string): Remove unnecessary check for
1222 integer overflow, noted by Stefan Monnier in
1223 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1224 Remove a FIXME that didn't need fixing.
1225 Simplify the newly-introduced buffer reallocation code.
1226
0cae2cdb
JB
12272011-08-27 Juanma Barranquero <lekktu@gmail.com>
1228
1229 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1230
5fc295a4 12312011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1232
70c60eb2 1233 Integer and memory overflow issues (Bug#9196).
726e0ab1 1234
d31850da
PE
1235 * doc.c (get_doc_string): Rework so that
1236 get_doc_string_buffer_size is the actual buffer size, rather than
1237 being 1 less than the actual buffer size; this makes xpalloc more
1238 convenient.
1239
a69fbedb
PE
1240 * image.c (x_allocate_bitmap_record, cache_image):
1241 * xselect.c (Fx_register_dnd_atom):
1242 Simplify previous changes by using xpalloc.
1243
fe5c5d37
PE
1244 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1245 since either will do and ptrdiff_t is convenient with xpalloc.
1246
0065d054
PE
1247 * charset.c (charset_table_size)
1248 (struct charset_sort_data.priority): Now ptrdiff_t.
1249 (charset_compare): Don't overflow if priorities differ greatly.
1250 (Fsort_charsets): Don't assume list length fits in int.
1251 Check for size-calculation overflow when allocating sort data.
1252 (syms_of_charset): Allocate an initial charset table that is
1253 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1254
1255 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1256
1257 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1258 The actual value is always <= INT_MAX, and leaving it unsigned made
1259 overflow checking harder.
1260
1261 * dispextern.h (struct glyph_matrix.rows_allocated)
1262 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1263 with xpalloc. The values are still always <= INT_MAX.
1264
1265 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1266
1267 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1268 (SAFE_NALLOCA): New macro.
1269
1270 * region-cache.c (struct boundary.pos, find_cache_boundary)
1271 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1272 (set_cache_region, invalidate_region_cache)
1273 (revalidate_region_cache, know_region_cache, region_cache_forward)
1274 (region_cache_backward, pp_cache):
1275 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1276 so that ptrdiff_t * can be passed to xpalloc.
1277 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1278 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1279 (pp_cache): Don't assume cache_len fits in int.
1280 * region-cache.h: Adjust extern decls to match.
1281
1282 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1283 EMACS_INT, since either will do, for xpalloc.
1284
1285 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1286 (xnmalloc, xnrealloc, xpalloc): New functions.
1287
726e0ab1
PE
1288 * bidi.c (bidi_shelve_header_size): New constant.
1289 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1290 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1291
51f30bc5 1292 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1293 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1294 (overlay_strings):
1295 Don't update size of array until after memory allocation succeeds,
1296 because xmalloc/xrealloc may not return.
0065d054
PE
1297 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1298 now that we have proper integer overflow checking.
1299 (record_overlay_string, overlay_strings): Catch overflows when
1300 calculating size of overlay_str_buf.
726e0ab1 1301
0065d054
PE
1302 * callproc.c (Fcall_process): Check for size overflow when
1303 calculating size of args2.
1304 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1305 Normally we prefer signed values, but sticking with ptrdiff_t would
1306 require adding more-complicated checks.
726e0ab1
PE
1307
1308 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1309 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1310 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1311 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1312
1313 * character.c (Fstring): Check for size-calculation overflow.
1314
1315 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1316 unnecessary integer overflow. Check for size overflow.
1317 (encode_coding_object): Don't update size until xmalloc succeeds.
1318
1319 * composite.c (get_composition_id): Check for overflow in glyph
1320 length calculations.
1321
1322 Integer and memory overflow fixes for display code.
1323 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1324 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1325 (scrolling_window): Check for overflow in size calculations.
1326 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1327 Don't assume glyph table len fits in int.
1328 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1329 (row_table_size): Now ptrdiff_t, not int.
1330 (scrolling_window): Avoid overflow in size calculations.
1331 Don't update size until allocation succeeds.
1332 * fns.c (concat): Check for overflow in size calculations.
1333 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1334 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1335 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1336
1337 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1338 (get_doc_string): Check for size calculation overflow.
1339 Don't update size until allocation succeeds.
1340 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1341 EMACS_INT, where ptrdiff_t will do.
1342 (Fsubstitute_command_keys): Check for string overflow.
1343
1344 * editfns.c (set_time_zone_rule): Don't assume environment length
1345 fits in int.
1346 (message_length): Now ptrdiff_t, not int.
1347 (Fmessage_box): Don't update size until allocation succeeds.
1348 Don't assume message length fits in int.
1349 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1350
0065d054
PE
1351 * emacs.c (main): Do not reallocate argv, since there is a null at
1352 the end that can be overwritten, and this way there's no need to
1353 worry about size-calculation overflow.
1354 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1355
1356 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1357 alloc succeeds.
1358 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1359
1360 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1361 (x_set_scroll_bar_width, x_figure_window_size):
1362 Check for integer overflow.
1363 (x_set_alpha): Do not assume XINT fits in int.
1364
1365 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1366 This is for the members text_lines, text_cols, total_lines, total_cols,
1367 where the system imposes an 'int' limit.
1368
1369 * fringe.c (Fdefine_fringe_bitmap):
1370 Don't update size until alloc works.
1371
1372 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1373 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1374
1375 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1376 Check for size-calculation overflow.
1377 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1378 do, as we prefer signed integers.
1379 (id_to_widget.max_size, id_to_widget.used)
1380 (xg_store_widget_in_map, xg_remove_widget_from_map)
1381 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1382 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1383 Use and return ptrdiff_t, not int.
1384 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1385 * gtkutil.h: Change prototypes to match the above.
1386
1387 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1388 are duplicate now that they've been promoted to lisp.h.
1389 (x_allocate_bitmap_record, x_alloc_image_color)
1390 (make_image_cache, cache_image, xpm_load):
1391 Don't update size until alloc is done.
1392 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1393 (x_detect_edges):
3256efce 1394 Check for size calculation overflow.
726e0ab1
PE
1395 (ct_colors_allocated_max): New constant.
1396 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1397 overflow.
3256efce 1398
726e0ab1
PE
1399 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1400 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1401 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1402 Use ptrdiff_t, not int, to count maps.
1403 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1404 calculations. Don't update size until allocation succeeds.
1405 Redo calculations to avoid overflow.
726e0ab1
PE
1406 * keyboard.h: Change prototypes to match the above.
1407
1408 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1409 to count maps.
1410 (current_minor_maps): Check for size calculation overflow.
1411 * keymap.h: Change prototypes to match the above.
1412
1413 * lread.c (read1, init_obarray): Don't update size until alloc done.
1414
1415 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1416 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1417
726e0ab1
PE
1418 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1419 Now ptrdiff_t, not int.
1420 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1421 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1422
1423 * process.c (Fnetwork_interface_list): Check for overflow
1424 in size calculation.
1425
1426 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1427
1428 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1429 overflow. Don't bother calling xmalloc when xrealloc will do.
1430
1431 * search.c (Freplace_match): Check for size calculation overflow.
1432 (Fset_match_data): Don't assume list lengths fit in 'int'.
1433
1434 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1435 for command line length. Do not attempt to address one before the
1436 beginning of an array, as that's not portable.
1437
1438 * term.c (max_frame_lines): Remove; unused.
1439 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1440 not int.
1441 (encode_terminal_code, calculate_costs): Check for size
1442 calculation overflow.
1443 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1444 table lengths and related sizes. Don't update size until alloc
1445 done. Redo calculations to avoid overflow.
1446 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1447
1448 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1449 subtracting pointers.
1450 (gobble_line): Check for overflow more carefully. Don't update size
1451 until alloc done.
1452
1453 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1454 Don't update size until alloc done.
1455 Redo size calculations to avoid overflow.
1456 Check for size calculation overflow.
0065d054 1457 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1458
1459 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1460 Use ptrdiff_t, not int, for sizes.
1461 (store_mode_line_noprop_char): Don't update size until alloc done.
1462
0065d054
PE
1463 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1464 Use ptrdiff_t, not int, for sizes.
1465 (Finternal_make_lisp_face, cache_face):
1466 Check for size calculation overflow.
1467 (cache_face): Treat size calculation overflows as if they were
1468 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1469
1470 * xfns.c (x_encode_text, x_set_name_internal)
1471 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1472 sizes, since they can exceed INT_MAX in size. Check for size
1473 calculation overflow.
1474
0065d054
PE
1475 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1476 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1477 Don't update size until alloc done.
1478
0065d054 1479 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1480 as sprintf is limited to int lengths.
1d526e2f 1481
252c5ee1
PE
1482 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1483 (X_LONG_MIN): New macros.
864d7ce7
PE
1484 Use them to make the following changes clearer.
1485 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1486 This change doesn't affect the value now, but it may help remind
1487 future maintainers not to raise the value too much later.
1488 (SELECTION_QUANTUM): Remove, replacing with ...
1489 (selection_quantum): ... new function, which avoids overflow.
1490 All uses changed.
1491 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1492 assumption that selection length fits in 'int'.
1493 (x_reply_selection_request, x_handle_selection_request)
1494 (x_get_window_property, receive_incremental_selection)
1495 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1496 (lisp_data_to_selection_data, clean_local_selection_data):
1497 Use ptrdiff_t, not int, to record length of selection.
1498 (x_reply_selection_request, x_get_window_property)
1499 (receive_incremental_selection, x_property_data_to_lisp):
1500 Redo calculations to avoid overflow.
1501 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1502 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1503 something.
1504 (x_get_window_property, receive_incremental_selection)
1505 (lisp_data_to_selection_data, x_property_data_to_lisp):
1506 Check for size-calculation overflow.
1507 (x_get_window_property, receive_incremental_selection)
1508 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1509 Don't store size until memory allocation succeeds.
1510 (x_get_window_property): Plug memory leak on memory exhaustion.
1511 Don't double-block input; malloc is safe here. Don't assume 2**34
1512 - 4 fits in unsigned long. Add an xassert to check
1513 XGetWindowProperty overflow. Be more careful about overflow
1514 calculations, and distinguish size from memory overflow better.
1515 (receive_incremental_selection): When tracing, don't assume
1516 unsigned int is less than INT_MAX.
1517 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1518 harmful) conversions of unsigned short to int.
1519 (lisp_data_to_selection_data): Don't assume that integers
1520 in the range -65535 through -1 fit in an X unsigned short.
1521 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1522 result parameters unless successful. Rely on cons_to_unsigned
1523 to report problems with elements; the old code wasn't right anyway.
1524 (x_check_property_data): Check for int overflow; we cannot use
1525 a wider type due to X limits.
1526 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1527
726e0ab1 1528 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1529
0065d054
PE
1530 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1531 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1532 (x_color_cells): Don't store size until memory allocation succeeds.
1533 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1534 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1535 (x_term_init): Don't assume length fits in int (sprintf is limited
1536 to int size).
bc18e09d 1537
ebfa62c0
PE
1538 Use ptrdiff_t for composition IDs.
1539 * character.c (lisp_string_width):
1540 * composite.c (composition_table_size, n_compositions)
1541 (get_composition_id, composition_gstring_from_id):
1542 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1543 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1544 * window.c (Frecenter):
1545 Use ptrdiff_t, not int, for composition IDs.
1546 * composite.c (get_composition_id): Check for integer overflow.
1547 * composite.h: Adjust prototypes to match the above changes.
1548
d3411f89
PE
1549 Use ptrdiff_t for hash table indexes.
1550 * category.c (hash_get_category_set):
1551 * ccl.c (ccl_driver):
1552 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1553 * coding.c (coding_system_charset_list, detect_coding_system):
1554 * coding.h (struct coding_system.id):
1555 * composite.c (get_composition_id, gstring_lookup_cache):
1556 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1557 * image.c (xpm_get_color_table_h):
1558 * lisp.h (hash_lookup, hash_put):
1559 * minibuf.c (Ftest_completion):
1560 Use ptrdiff_t for hash table indexes, not int (which is too
1561 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1562 32-bit --with-wide-int hosts).
1563
e097a6fa
PE
1564 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1565 Add a FIXME comment about memory leaks.
1566 (syms_of_charset): Don't assume xmalloc returns.
1567
5637687f
PE
1568 Don't assume that stated character widths fit in int.
1569 * character.c (Fchar_width, c_string_width, lisp_string_width):
1570 * character.h (CHAR_WIDTH):
1571 * indent.c (MULTIBYTE_BYTES_WIDTH):
1572 Use sanitize_char_width to avoid undefined and/or bad behavior
1573 with outlandish widths.
a66cfb1c 1574 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1575 now that we have two such functions. All uses changed.
1576 (sanitize_char_width): New inline function.
1577
a2271ba2
PE
1578 Don't assume that tab-width fits in int.
1579 * character.h (sanitize_width): New inline function.
1580 (SANE_TAB_WIDTH): New macro.
1581 (ASCII_CHAR_WIDTH): Use it.
1582 * indent.c (sane_tab_width): Remove. All uses replaced by
1583 SANE_TAB_WIDTH (current_buffer).
1584 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1585
18c52557
PE
1586 * fileio.c: Integer overflow issues with file modes.
1587 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1588
caeeedc1
PE
1589 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1590 Remove unreachable code.
1591 (read_hex, load_charset_map_from_file): Check for integer overflow.
1592
50849c52
PE
1593 * xterm.c: don't go over XClientMessageEvent limit
1594 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1595 (x_send_scroll_bar_event): Likewise. Check that the size does not
1596 exceed limits imposed by XClientMessageEvent, as well as the usual
1597 ptrdiff_t and size_t limits.
1598
b13995db
PE
1599 * keyboard.c: Overflow, signedness and related fixes.
1600 (make_lispy_movement): Use same integer type in forward decl
1601 that is used in the definition.
1602 (read_key_sequence, keyremap_step):
1603 Change bufsize argument back to int, undoing my 2011-03-30 change.
1604 We prefer signed types, and int is wide enough here.
1605 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1606 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1607 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1608 length, not size_t. Use ptrdiff_t for index, not int.
1609 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1610 possibility of integer overflow.
1611
13464394
PE
1612 Overflow, signedness and related fixes for images.
1613
1614 * dispextern.h (struct it.stack[0].u.image.image_id)
1615 (struct_it.image_id, struct image.id, struct image_cache.size)
1616 (struct image_cache.used, struct image_cache.ref_count):
1617 * gtkutil.c (update_frame_tool_bar):
1618 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1619 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1620 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1621 * nsmenu.m (update_frame_tool_bar):
1622 * xdisp.c (calc_pixel_width_or_height):
1623 * xfns.c (image_cache_refcount):
1624 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1625 on typical 64-bit hosts.
1626
1627 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1628 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1629 Omit unnecessary casts to int.
1630 (parse_image_spec): Check that integers fall into 'int' range
1631 when the callers expect that.
1632 (image_ascent): Redo ascent calculation to avoid int overflow.
1633 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1634 (lookup_image): Remove unnecessary tests.
1635 (xbm_image_p): Locals are now of int, not EMACS_INT,
1636 since parse_image_check makes sure they fit into int.
1637 (png_load, gif_load, svg_load_image):
1638 Prefer int to unsigned where either will do.
1639 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1640 old tiff_error_handler and tiff_warning_handler.
1641 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1642 stack buffer overflows. It uses only the features of vsnprintf
1643 that are common to both POSIX and native Microsoft.
1644 (tiff_error_handler, tiff_warning_handler): Use it.
1645 (tiff_load, gif_load, imagemagick_load_image):
1646 Don't assume :index value fits in 'int'.
1647 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1648 (imagemagick_load_image): Check that crop parameters fit into
1649 the integer types that MagickCropImage accepts. Don't assume
1650 Vimagemagick_render_type has a nonnegative value. Don't assume
1651 size_t fits in 'long'.
1652 (gs_load): Use printmax_t to print the widest integers possible.
1653 Check for integer overflow when computing image height and width.
1654
c11821d4
EZ
16552011-08-26 Eli Zaretskii <eliz@gnu.org>
1656
1657 * xdisp.c (redisplay_window): Don't force window start if point
1658 will be invisible in the resulting window. (Bug#9324)
1659
0c95fcf7
EZ
16602011-08-25 Eli Zaretskii <eliz@gnu.org>
1661
1662 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1663 the display spec is of the form `(space ...)'.
1664 (handle_display_spec): Return the value returned by
1665 handle_single_display_spec, not just 1 or zero.
1666 (handle_single_display_spec): If the display spec is of the form
1667 `(space ...)', and specifies display in the text area, return 2
1668 rather than 1.
fee65a97 1669 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1670 accurately, and prefer exact match for point under bidi.
1671 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1672
1673 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1674 into disp_prop; all users changed.
1675
1676 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1677 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1678 for the text covered by the display property.
1679
e4ed06f1
CY
16802011-08-25 Chong Yidong <cyd@stupidchicken.com>
1681
1682 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1683 Change return value to nil.
1684 (Frecord_buffer): Delete unused function.
1685
f67cdd7f
EZ
16862011-08-24 Eli Zaretskii <eliz@gnu.org>
1687
5980d4c6
EZ
1688 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1689 buffers, return left-to-right.
8610fe8b
EZ
1690 (set_cursor_from_row): Consider candidate row a win if its glyph
1691 represents a newline and point is on that newline. Fixes cursor
1692 positioning on the newline at EOL of R2L text within L2R
1693 paragraph, and vice versa.
1694 (try_cursor_movement): Check continued rows, in addition to
1695 continuation rows. Fixes unwarranted scroll when point enters a
1696 continued line of R2L text within an L2R paragraph, or vice versa.
1697 (cursor_row_p): Consider the case of point being equal to
1698 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1699 from the end of a short line to the beginning of a continued line
1700 of R2L text within L2R paragraph.
1701 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1702 composed characters.
5980d4c6 1703
f67cdd7f
EZ
1704 * bidi.c (bidi_check_type): Use xassert.
1705 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1706 members.
1707
bca633fb
EZ
17082011-08-23 Eli Zaretskii <eliz@gnu.org>
1709
1710 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1711 a character.
1712
4a5885a7
CY
17132011-08-23 Chong Yidong <cyd@stupidchicken.com>
1714
1715 * nsfont.m (ns_otf_to_script): Fix typo.
1716
0902a04e
KH
17172011-08-22 Kenichi Handa <handa@m17n.org>
1718
1719 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1720 extra slot even if the purpose is char-code-property-table.
1721
1a2e6670
EZ
17222011-08-23 Eli Zaretskii <eliz@gnu.org>
1723
8ddde651
EZ
1724 * xdisp.c (redisplay_window): When computing centering_position,
1725 account for the height of the header line. (Bug#8874)
1726
425cc014
EZ
1727 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1728 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1729 candidate is selected by the mouse, and that candidate has a
1730 composed character under the mouse.
1731
1a2e6670
EZ
1732 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1733 coordinates reported by pos-visible-in-window-p for a composed
1734 character in column zero.
1735
8b76d6f8
SM
17362011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1737
1738 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1739
dac347dd
EZ
17402011-08-22 Eli Zaretskii <eliz@gnu.org>
1741
1742 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1743 consider it a hit if to_charpos is anywhere in the range of the
1744 composed buffer positions.
1745
e013fb34
CY
17462011-08-22 Chong Yidong <cyd@stupidchicken.com>
1747
1748 * image.c (gif_load): Don't assume that each subimage has the same
1749 dimensions as the base image. Handle disposal method that is
1750 "undefined" by the gif spec (Bug#9335).
1751
bd1ba3e8
CY
17522011-08-20 Chong Yidong <cyd@stupidchicken.com>
1753
1754 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1755 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1756
54a1215b
EZ
17572011-08-19 Eli Zaretskii <eliz@gnu.org>
1758
823564e5
EZ
1759 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1760 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1761 from an Org mode buffer to a Speedbar frame.
1762
54a1215b
EZ
1763 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1764 a composition, take its buffer position from IT->cmp_it.charpos.
1765 Fixes cursor positioning at the beginning of a line that begins
1766 with a composed character.
1767
9778ebcc
EZ
17682011-08-18 Eli Zaretskii <eliz@gnu.org>
1769
0be6ee06
EZ
1770 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1771 character bidirectional type, use STRONG_L instead. Fixes crashes
1772 in a buffer produced by `describe-categories'.
1773
9778ebcc
EZ
1774 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1775 members before the level stack, so they would be saved and
1776 restored when copying iterator state. Fixes incorrect reordering
1777 around TABs covered by display properties.
1778
156bffbe
AS
17792011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1780
6b02f655 1781 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1782
72ad093b
CY
17832011-08-17 Chong Yidong <cyd@stupidchicken.com>
1784
1785 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1786 (internal_condition_case_2, internal_condition_case_n):
1787 Remove unnecessary aborts (Bug#9081).
72ad093b 1788
35774242
EZ
17892011-08-17 Eli Zaretskii <eliz@gnu.org>
1790
1791 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1792 has no `load' handler, try opening the file locally. (Bug#9311)
1793
db76dd85
KB
17942011-08-16 Ken Brown <kbrown@cornell.edu>
1795
1796 * gmalloc.c: Expand comment.
1797
b215eee5
EZ
17982011-08-16 Eli Zaretskii <eliz@gnu.org>
1799
1800 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1801 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1802
a4579d33
KB
18032011-08-16 Ken Brown <kbrown@cornell.edu>
1804
1805 Fix memory allocation problems in Cygwin build (Bug#9273).
1806
1807 * unexcw.c ( __malloc_initialized): Declare external variable.
1808 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1809
8b76d6f8
SM
1810 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1811 New variables.
a4579d33
KB
1812 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1813 dumped emacs.
1814 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1815 in the static heap.
1816 [CYGWIN] (special_realloc): New function.
1817 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1818 requests to realloc storage in the static heap.
1819
3ebec551
PE
18202011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1821
1822 * bidi.c (bidi_initialize): Remove unused local.
1823
9fd8be00
EZ
18242011-08-15 Eli Zaretskii <eliz@gnu.org>
1825
6b02f655
SM
1826 * bidimirror.h:
1827 * biditype.h: Remove file.
1828 * makefile.w32-in ($(BLD)/bidi.$(O)):
1829 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1830
1831 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1832
1833 * chartab.c: Improve commentary for the uniprop_table API.
1834
32413314
EZ
1835 * bidi.c (bidi_paragraph_init): Support zero value of
1836 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1837 (bidi_initialize): Use uniprop_table instead of including
1838 biditype.h and bidimirror.h.
32413314 1839
9fd8be00
EZ
1840 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1841 coordinates of the iterator when restoring from ppos_it.
1842 (Bug#9296)
1843
5cf2b69b
KH
18442011-08-14 Kenichi Handa <handa@m17n.org>
1845
1846 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1847 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1848
daf17d00
EZ
18492011-08-14 Eli Zaretskii <eliz@gnu.org>
1850
1851 * xdisp.c (move_it_in_display_line_to): Don't invoke
1852 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1853 ppos_it. Fixes vertical cursor motion when line beginning is
1854 covered by an image. (Bug#9296)
1855
08e3161a
JD
18562011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1857
1858 * nsterm.h (ns_run_ascript): Declare.
1859 (NSAPP_DATA2_RUNASSCRIPT): Define.
1860
1861 * nsfns.m (as_script, as_result, as_status): New static variables.
1862 (ns_run_ascript): New function.
5e617bc2 1863 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1864 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1865 the event loop. Get status from as_status (Bug#7276).
1866
1867 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1868 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1869 the event loop (Bug#7276).
1870
a3720aa2
AS
18712011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1872
1873 * gnutls.c (QCgnutls_bootprop_priority)
1874 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1875 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1876 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1877 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1878 (QCgnutls_bootprop_verify_hostname_error)
1879 (QCgnutls_bootprop_callbacks_verify): Rename from
1880 Qgnutls_bootprop_..., all uses changed.
1881
1882 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1883 uses changed.
1884
0a0d27fb
PE
18852011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1886
19d5c50c
PE
1887 * xfaces.c (Qframe_set_background_mode): Now static.
1888 * dispextern.h (Qframe_set_background_mode): Remove decl.
1889
0a0d27fb
PE
1890 * process.c (Fnetwork_interface_info): Declare local only if needed.
1891
377538cb
JD
18922011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1893
1894 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1895 (Fnetwork_interface_list): Allocate in increments of bytes instead
1896 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1897 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1898 sockaddr.
1899 (struct ifflag_def): notrailers is smart on OSX.
1900 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1901 Get hardware address with getifaddrs if available.
1902
08fff70c
EZ
19032011-08-12 Eli Zaretskii <eliz@gnu.org>
1904
1905 * xdisp.c (iterate_out_of_display_property): xassert that
1906 IT->position is set to within IT->object's boundaries. Break from
1907 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1908 when IT->position is set up wrongly due to some bug.
1909 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1910 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1911 entry. Force push_it to save on the stack the current
1912 buffer/string position, to be restored by pop_it. Fix flags in
1913 the iterator structure wrt the object coming from a display
1914 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1915 properties. (Bug#9284)
1916
7be1c708 19172011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1918
7be1c708
CY
1919 * fontset.c (fontset_get_font_group): Add proper type checks.
1920 (Bug#9172)
aac0c6e3 1921
7be1c708 19222011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1923
7be1c708
CY
1924 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1925 and LC_VERSION_MIN_MACOSX.
1926 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1927 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1928
97bb72a6
EZ
19292011-08-08 Eli Zaretskii <eliz@gnu.org>
1930
1931 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1932 no-display-properties-and-no-overlays under bidi display.
1933 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1934 properties and overlays.
97bb72a6 1935
d5617611
CY
19362011-08-08 Chong Yidong <cyd@stupidchicken.com>
1937
37e11a63
CY
1938 * editfns.c (Fset_time_zone_rule): Document relationship with the
1939 setenv function.
1940
d5617611
CY
1941 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1942 the font entity extracted from the cache (Bug#8109).
1943
58872834
CY
19442011-08-07 Chong Yidong <cyd@stupidchicken.com>
1945
1946 * composite.c (autocmp_chars): Don't reset point. That is done by
1947 restore_point_unwind (Bug#5984).
1948
75bfc667
JL
19492011-08-07 Juri Linkov <juri@jurta.org>
1950
1951 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1952 to show the arg `TIME' instead of `TIMEVAL'.
1953
d1410150
EZ
19542011-08-06 Eli Zaretskii <eliz@gnu.org>
1955
1956 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1957 display property strides EOL and includes a newline, as in
1958 longlines-mode. (Bug#9254)
75b771e4
EZ
1959 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1960 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1961
1962 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1963 is non-zero, even if the data buffer is NULL. Fixes a crash in
1964 vertical-motion with longlines-mode. (Bug#9254)
1965
35928349
EZ
19662011-08-05 Eli Zaretskii <eliz@gnu.org>
1967
ec7cc85b
EZ
1968 * bidi.c <bidi_cache_total_alloc>: Now static.
1969 (bidi_initialize): Initialize bidi_cache_total_alloc.
1970
8b76d6f8 1971 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1972 cache. (Bug#9221)
1973
1974 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1975 amount allocated this far in `bidi_cache_total_alloc'.
1976 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1977 non-zero, only free the data buffer without restoring the cache
1978 contents. All callers changed.
1979
1980 * dispextern.h (bidi_unshelve_cache): Update prototype.
1981
1982 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1983 (move_it_in_display_line, move_it_to)
1984 (move_it_vertically_backward, move_it_by_lines): Replace the call
1985 to xfree to an equivalent call to bidi_unshelve_cache.
1986 (move_it_in_display_line_to): Fix logic of returning
412b6358 1987 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1988
e2e2423b
EZ
19892011-08-05 Eli Zaretskii <eliz@gnu.org>
1990
1991 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1992 came from a string character with a `cursor' property. (Bug#9229)
1993
ae9e757a
JD
19942011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1995
1996 * Makefile.in (LIB_PTHREAD): New variable.
1997 (LIBES): Add LIB_PTHREAD (Bug#9216).
1998
1999 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2000 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2001
213bd7f2
AS
20022011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2003
6b02f655 2004 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2005
99aaf75f
JD
20062011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2007
2008 * xterm.c (x_find_topmost_parent): New function.
2009 (x_set_frame_alpha): Find topmost parent window with
2010 x_find_topmost_parent and set the property there also (bug#9181).
2011 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2012
c74e9d86
PE
20132011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2014
2015 * callproc.c (Fcall_process): Avoid vfork clobbering
2016 the local vars buffer, coding_systems, current_dir.
2017
640c8776
SM
20182011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2019
2020 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2021
f26d0e4c
PE
20222011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2023
8a10d76c
PE
2024 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2025 so that it is not optimized away.
2026
f26d0e4c
PE
2027 * xdisp.c (compute_display_string_pos): Remove unused local.
2028
55439c61
EZ
20292011-08-02 Eli Zaretskii <eliz@gnu.org>
2030
2031 Fix slow cursor motion and scrolling in large buffers with
2032 selective display, like Org Mode buffers. (Bug#9218)
2033
2034 * dispextern.h (struct bidi_it): New member disp_prop_p.
2035
2036 * xdisp.c: Remove one-slot cache of display string positions.
2037 (compute_display_string_pos): Accept an additional argument
5e617bc2 2038 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2039 for a display string or property. If found, set DISP_PROP_P
2040 non-zero.
2041
2042 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2043 DISP_PROP_P, and pass it to compute_display_string_pos.
2044 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2045 non-zero. All callers of bidi_fetch_char changed.
2046
fb33fa43
SM
20472011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2048
2049 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2050
b099e063
DM
20512010-12-03 Don March <don@ohspite.net>
2052
2053 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2054 last character M-[char] is translated to ESC [char] (bug#7541).
2055
5cc7f7af
KH
20562011-08-02 Kenichi Handa <handa@m17n.org>
2057
d0fffa3f 2058 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2059
2060 * chartab.c (uniprop_table): Make it non-static.
2061
525d5e6e
EZ
20622011-08-01 Eli Zaretskii <eliz@gnu.org>
2063
2064 * xdisp.c (forward_to_next_line_start): Accept additional argument
2065 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2066 on the newline.
2067 (reseat_at_next_visible_line_start): Use the bidi iterator state
2068 returned by forward_to_next_line_start to restore the state of
2069 it->bidi_it after backing up to previous newline. (Bug#9212)
2070
31011111
AS
20712011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2072
2073 * regex.c (re_comp): Protoize.
2074 (re_exec): Fix return type.
2075 (regexec): Fix type of `ret'. (Bug#9203)
2076
476371c4
PE
20772011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2078
e5d76069
PE
2079 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2080 This is needed if max-image-size is a floating-point number.
2081
9a79b20c
AS
20822011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2083
2084 * print.c (print_object): Print empty symbol as ##.
2085
2086 * lread.c (read1): Read ## as empty symbol.
2087
d8c2fa78
AA
20882011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2089
2090 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2091 setting frame foreground color (Bug#9175).
2092 (x_set_background_color): Likewise.
2093
ffe57a7a
AA
2094 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2095 contents (Bug#9176).
2096 (EmacsTooltip -init): Remove bezels and add shadows to
2097 tooltip windows.
2098
bf3492a5
AA
2099 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2100 or scroll bar (Bug#8470).
2101
d55e9c53
AA
2102 * nsfont.m (nsfont_open): Remove assignment to voffset and
2103 unnecessary vars hshink, expand, hd, full_height, min_height.
2104 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2105
2106 * nsterm.h (nsfont_info): Remove voffset field.
2107
d8c2fa78 21082011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2109
2110 Implement strike-through and overline on NextStep (Bug#8863).
2111
2112 * nsfont.m (nsfont_open): Use underline position provided by font,
2113 instead of hard-coded value of 2.
2114 (nsfont_draw): Call ns_draw_text_decoration instead.
2115
2116 * nsterm.h: Add declaration for ns_draw_text_decoration.
2117
2118 * nsterm.m (ns_draw_text_decoration): New function for drawing
2119 underline, overline, and strike-through.
2120 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2121 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2122 accommodate underlining, etc.
4843aac3 2123
4cc60b9b
EZ
21242011-07-28 Eli Zaretskii <eliz@gnu.org>
2125
bc7ece87
EZ
2126 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2127 default.
4cc60b9b 2128
476371c4
PE
21292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2130
66606eea
PE
2131 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2132 Without this fix, if a signal arrives just after memory fills up,
2133 'malloc' might be invoked reentrantly.
2134
476371c4
PE
2135 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2136 In other words, assume that every image size is allowed, on non-X
2137 hosts. This assumption is probably wrong, but it lets Emacs compile.
2138
f3fcc40d
AS
21392011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2140
2141 * regex.c (re_iswctype): Convert return values to boolean.
2142
350c992f
EZ
21432011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2144
2145 * xdisp.c (compute_display_string_pos): Don't use cached display
2146 string position if the buffer had its restriction changed.
2147 (Bug#9184)
2148
5266b4bb
PE
21492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2150
2151 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2152
2573a837 21532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2154
41f55ccd 2155 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2156
39e378da
PE
2157 * bidi.c: Integer size and overflow fixes.
2158 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2159 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2160 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2161 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2162 (bidi_find_other_level_edge):
2163 Use ptrdiff_t instead of EMACS_INT where either will do.
2164 This works better on 32-bit hosts configured --with-wide-int.
2165 (bidi_cache_ensure_space): Check for size-calculation overflow.
2166 Use % rather than repeated addition, for better worst-case speed.
2167 Don't set bidi_cache_size until after xrealloc returns, because it
2168 might not return.
2169 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2170 (bidi_cache_ensure_space): Also check that the bidi cache size
2171 does not exceed that of the largest Lisp string or buffer. See Eli
2172 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2173
5e927815
PE
2174 * alloc.c (__malloc_size_t): Remove.
2175 All uses replaced by size_t. See Andreas Schwab's note
2176 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2177
ca4aa935
PE
2178 * image.c: Improve checking for integer overflow.
2179 (check_image_size): Assume that f is nonnull, since
2180 it is always nonnull in practice. This is one less thing to
2181 worry about when checking for integer overflow later.
2182 (x_check_image_size): New function, which checks for integer
2183 overflow issues inside X.
2184 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2185 This removes the need for a memory_full check.
2186 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2187 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2188 (xbm_read_bitmap_data): Change locals back to 'int', since
2189 their values must fit in 'int'.
2190 (xpm_load_image, png_load, tiff_load):
2191 Invoke x_create_x_image_and_pixmap earlier,
2192 to avoid much needless work if the image is too large.
2193 (tiff_load): Treat overly large images as if
2194 x_create_x_image_and_pixmap failed, not as malloc failures.
2195 (gs_load): Use x_check_image_size.
2196
5f8f9cc2
PE
2197 * gtkutil.c: Omit integer casts.
2198 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2199 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2200
5adf60bc
PE
2201 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2202
c8907a93
PE
2203 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2204 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2205 would wrongly return t on a 64-bit host.
2206
e3c25c68
PE
2207 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2208 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2209 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2210 and therefore cause GCC to emit a bogus diagnostic in some cases.
2211
3f791afe
PE
2212 * image.c: Integer signedness and overflow and related fixes.
2213 This is not an exhaustive set of fixes, but it's time to
2214 record what I've got.
2215 (lookup_pixel_color, check_image_size): Remove redundant decls.
2216 (check_image_size): Don't assume that arbitrary EMACS_INT values
2217 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2218 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2219 (tiff_load, imagemagick_load_image):
2220 Check for overflow in size calculations.
2221 (x_create_x_image_and_pixmap): Remove unnecessary test for
2222 xmalloc returning NULL; that can't happen.
2223 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2224 (xpm_color_bucket): Use better integer hashing function.
2225 (xpm_cache_color): Don't possibly over-allocate memory.
2226 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2227 (gif_memory_source):
2228 Use ptrdiff_t, not int or size_t, to record sizes.
2229 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2230 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2231 either works, as we prefer signed integers.
2232 (tiff_read_from_memory, tiff_write_from_memory):
2233 Return tsize_t, not size_t, since that's what the TIFF API wants.
2234 (tiff_read_from_memory): Don't fail simply because the read would
2235 go past EOF; instead, return a short read.
2236 (tiff_load): Omit no-longer-needed casts.
2237 (Fimagemagick_types): Don't assume size fits into 'int'.
2238
3cc5a532
PE
2239 Improve hashing quality when configured --with-wide-int.
2240 * fns.c (hash_string): New function, taken from sxhash_string.
2241 Do not discard information about ASCII character case; this
2242 discarding is no longer needed.
2243 (sxhash-string): Use it. Change sig to match it. Caller changed.
2244 * lisp.h: Declare it.
2245 * lread.c (hash_string): Remove, since we now use fns.c's version.
2246 The fns.c version returns a wider integer if --with-wide-int is
2247 specified, so this should help the quality of the hashing a bit.
2248
b312a492
PE
2249 * emacs.c: Integer overflow minor fix.
2250 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2251 Define only if GNU_LINUX.
2252 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2253
dfd153ae
PE
2254 * dispnew.c: Integer signedness and overflow fixes.
2255 Remove unnecessary forward decls, that were a maintenance hassle.
2256 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2257 All uses changed.
2258 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2259 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2260 (prepare_desired_row, line_draw_cost):
2261 Use int, not unsigned, where either works.
2262 (save_current_matrix, restore_current_matrix):
2263 Use ptrdiff_t, not size_t, where either works.
2264 (init_display): Check for overflow more accurately, and without
2265 relying on undefined behavior.
2266
a81d11a3
PE
2267 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2268 Remove, replacing with the new symbols in lisp.h. All uses changed.
2269 * fileio.c (make_temp_name):
2270 * filelock.c (lock_file_1, lock_file):
2271 * xdisp.c (message_dolog):
2272 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2273 Use pMd etc. instead.
2274 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2275 replacing the pWIDE etc. symbols removed from editfns.c.
2276
3300e6fd
PE
2277 * keyboard.h (num_input_events): Now uintmax_t.
2278 This is (very slightly) less likely to mess up due to wraparound.
2279 All uses changed.
2280
fd05c7e9
PE
2281 * buffer.c: Integer signedness fixes.
2282 (alloc_buffer_text, enlarge_buffer_text):
2283 Use ptrdiff_t rather than size_t when either will do, as we prefer
2284 signed integers.
2285
903fe15d
PE
2286 * alloc.c: Integer signedness and overflow fixes.
2287 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2288 (__malloc_size_t): Default to size_t, not to int.
2289 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2290 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2291 Prefer ptrdiff_t to size_t when either would do, as we prefer
2292 signed integers.
2293 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2294 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2295 Now const. Initialize with values that are in range even if char
2296 is signed.
2297 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2298 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2299 These functions do the right thing with sizes > 2**32.
2300 (check_depth): Now ptrdiff_t, not int.
2301 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2302 Adjust to new way of storing sizes. Check for size overflow bugs
2303 in rest of code.
2304 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2305 slightly wrong anyway, as it missed one instance of
2306 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2307 (refill_memory_reserve): Omit needless cast to size_t.
2308 (mark_object_loop_halt): Mark as externally visible.
2309
ac82cc6a
PE
2310 * xselect.c: Integer signedness and overflow fixes.
2311 (Fx_register_dnd_atom, x_handle_dnd_message):
2312 Use ptrdiff_t, not size_t, since we prefer signed.
2313 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2314 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2315 x_dnd_atoms_size and x_dnd_atoms_length.
2316
c2d1e36d
PE
2317 * doprnt.c: Prefer signed to unsigned when either works.
2318 * eval.c (verror):
2319 * doprnt.c (doprnt):
2320 * lisp.h (doprnt):
2321 * xdisp.c (vmessage):
2322 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2323 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2324 prefer signed arithmetic to avoid comparison confusion.
2325 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2326 but is a bit tricky.
2327
0e926e56
PE
2328 Assume freestanding C89 headers, string.h, stdlib.h.
2329 * data.c, doprnt.c, floatfns.c, print.c:
2330 Include float.h unconditionally.
2331 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2332 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2333 * regex.c: Likewise for stddef.h, string.h.
2334 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2335 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2336 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2337 (STDC_HEADERS): Remove obsolete defines.
2338 * sysdep.c: Include limits.h unconditionally.
2339
9cfdb3ec
PE
2340 Assume support for memcmp, memcpy, memmove, memset.
2341 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2342 * regex.c (memcmp, memcpy):
2343 Remove; we assume C89 now.
2344
2345 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2346 (__malloc_safe_bcopy): Remove; no longer needed.
2347
cf950e6b 2348 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2349 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2350 well either way, and we prefer signed to unsigned.
2351
dbf38e02
LMI
23522011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2353
2354 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2355 closes the connection while we're reading (bug#9182).
2356
d6f0886c 23572011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2358
d6f0886c
JD
2359 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2360 are specified (Bug#9168).
24e0f6b1 2361
2eb1f9e6
PE
23622011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2363
2364 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2365 Found by GCC static checking and --with-wide-int on a 32-bit host.
2366
22381272 23672011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2368
2369 * xdisp.c (compute_display_string_pos): Fix logic of caching
2370 previous display string position. Initialize cached_prev_pos to
2371 -1. Fixes slow-down at the beginning of a buffer.
2372
f25e39b4
EZ
23732011-07-24 Eli Zaretskii <eliz@gnu.org>
2374
2375 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2376 for attrs[LFACE_FONTSET_INDEX].
2377
04c4b52e
PE
23782011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 * xml.c (parse_region): Remove unused local
2381 that was recently introduced.
2382
c1734fbd
EZ
23832011-07-23 Eli Zaretskii <eliz@gnu.org>
2384
be18c5a5
EZ
2385 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2386 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2387
c1734fbd
EZ
2388 * xdisp.c (move_it_in_display_line_to): Record the best matching
2389 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2390 exit if none of the characters scanned was an exact match.
2391 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2392 when exact match is impossible due to invisible text, and the
2393 lines are truncated.
2394
a258d627
JD
23952011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2396
2397 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2398 for OSX >= 10.7.
2399
b6d5a689
EZ
24002011-07-22 Eli Zaretskii <eliz@gnu.org>
2401
0f74f785
EZ
2402 Fix a significant slow-down of cursor motion with C-n, C-p,
2403 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2404 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2405 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2406 (next_element_from_buffer): Call compute_stop_pos_backwards to
2407 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2408 base_level_stop.
2409 (reseat): Don't look for prev_stop, as that could mean a very long
2410 run.
2411 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2412 <cached_disp_overlay_modiff>: Cache for last found display string
2413 position.
551918c1 2414 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2415 about the same buffer in the same area of character positions, and
2416 the buffer wasn't changed since the time the display string
2417 position was cached.
551918c1 2418
b2d0c91a
EZ
24192011-07-22 Eli Zaretskii <eliz@gnu.org>
2420
2421 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2422 is an integer, which is important for empty lines. (Bug#9149)
2423
043604ee
CY
24242011-07-22 Chong Yidong <cyd@stupidchicken.com>
2425
2426 * frame.c (Fmodify_frame_parameters): In tty case, update the
2427 default face if necessary (Bug#4238).
2428
da4adb04
CY
24292011-07-21 Chong Yidong <cyd@stupidchicken.com>
2430
2431 * editfns.c (Fstring_to_char): No need to explain what a character
2432 is in the docstring (Bug#6576).
2433
9abd0532
LMI
24342011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2435
2436 * xml.c (parse_region): Make sure we always return a tree.
2437
36881d16
HK
24382011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2439
2440 * xml.c (parse_region): If a document contains only comments,
2441 return that, too.
2442
1e98674d
LMI
24432011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2444
2445 * xml.c (make_dom): Return comments, too.
2446
590bd467
PE
24472011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2448
2449 Port to OpenBSD.
2450 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2451 and the surrounding thread.
2452 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2453 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2454 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2455 timer goes off.
2456 * s/openbsd.h (BROKEN_SIGIO): Define.
2457 * unexelf.c (unexec) [__OpenBSD__]:
2458 Don't update the .mdebug section of the Alpha COFF symbol table.
2459
f41628b2
LMI
24602011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2461
2462 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2463 (bug#8460).
2464
b59b67c5
PE
24652011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2466
15e3a074
PE
2467 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2468 This fixes some race conditions on the permissions of any newly
2469 created file.
2470
41bed37d
PE
2471 * alloc.c (valid_pointer_p): Use pipe, not open.
2472 This fixes some permissions issues when debugging.
2473
b59b67c5
PE
2474 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2475 If fchown fails to set both uid and gid, try to set just gid,
2476 as that is sometimes allowed. Adjust the file's mode to eliminate
2477 setuid or setgid bits that are inappropriate if fchown fails.
2478
925a6be7
SM
24792011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2480
2481 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2482 to compare Lisp_Objects.
2483 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2484 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2485 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2486
52968808
AS
24872011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2488
0a6a104b
AS
2489 * lread.c (read_integer): Unread even EOF character.
2490 (read1): Likewise. Properly record start position of symbol.
2491
52968808
AS
2492 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2493 symbol character follows.
2494
9e381cdd
PE
24952011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2496
2497 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2498 This works around a problem with the previous change to Fcopy_file.
2499 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2500 and without this change, GCC might complain about discarding
2501 fchown's return value.
2502
b5641435
JB
25032011-07-16 Juanma Barranquero <lekktu@gmail.com>
2504
2505 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2506
a8031457
PE
25072011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2508
2509 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2510
dd889327
LMI
25112011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2512
750c33f7
LMI
2513 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2514 it's used from the C level.
2515
dd889327
LMI
2516 * process.c: Use the same condition for POLL_FOR_INPUT in both
2517 keyboard.c and process.c (bug#1858).
2518
87e86684
LM
25192011-07-09 Lawrence Mitchell <wence@gmx.li>
2520
2521 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2522 (Fgnutls_boot): Use it.
2523
64348f40
AS
25242011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2525
2526 * doc.c (Fsubstitute_command_keys): Revert last change.
2527
1d698799
LMI
25282011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2529
f863868c
LMI
2530 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2531 quotes the next character, and doesn't affect other longer
2532 sequences (bug#8935).
2533
1d698799
LMI
2534 * lread.c (syms_of_lread): Clarify that is isn't only
2535 `eval-buffer' and `eval-defun' that's affected by
2536 `lexical-binding' (bug#8460).
2537
aa4b6df6
EZ
25382011-07-15 Eli Zaretskii <eliz@gnu.org>
2539
2540 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2541 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2542
5d856da6
PE
25432011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2544
ad6042bb
PE
2545 Fix minor problems found by static checking.
2546 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2547 (elsz): Now a signed constant, not a size_t var. We prefer signed
2548 types to unsigned, to avoid integer comparison confusion. Without
2549 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2550 "cannot optimize loop, the loop counter may overflow", a symptom
2551 of the confusion.
f00bbb22 2552 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2553 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2554
6468f31c
LMI
25552011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2556
49080b10
LMI
2557 * search.c (Fre_search_backward): Mention `case-fold-search' in
2558 all the re_search_* functions (bug#8138).
2559
6468f31c
LMI
2560 * keyboard.c (Fopen_dribble_file): Document when the file is
2561 closed (bug#8056).
2562
c965adc5
EZ
25632011-07-14 Eli Zaretskii <eliz@gnu.org>
2564
df9733bf
EZ
2565 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2566 bidi_cache_idx.
2567
0bb23927
EZ
2568 Support bidi reordering of display and overlay strings.
2569 * xdisp.c (compute_display_string_pos)
2570 (compute_display_string_end): Accept additional argument STRING.
2571 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2572 (reseat_to_string): Initialize bidi_it->string.s and
2573 bidi_it->string.schars.
2574 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2575 NULL (avoids a crash in bidi_paragraph_init).
2576 Initialize itb.string.lstring.
0bb23927
EZ
2577 (init_iterator): Call bidi_init_it only of a valid
2578 buffer position was specified. Initialize paragraph_embedding to
2579 L2R.
2580 (reseat_to_string): Initialize the bidi iterator.
2581 (display_string): If we need to ignore text properties of
2582 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2583 original value of -1 will not work with bidi.)
2584 (compute_display_string_pos): First arg is now struct
2585 `text_pos *'; all callers changed. Support display properties on
2586 Lisp strings.
2587 (compute_display_string_end): Support display properties on Lisp
2588 strings.
2589 (init_iterator, reseat_1, reseat_to_string): Initialize the
2590 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2591 when iterating on a string not from display properties).
640c8776
SM
2592 (compute_display_string_pos, compute_display_string_end):
2593 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2594 arrow keys.
2595 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2596 base_level_stop; instead, set base_level_stop to BEGV.
2597 Fixes crashes in vertical-motion.
0bb23927
EZ
2598 (next_element_from_buffer): Improve commentary for when
2599 the iterator is before prev_stop.
2600 (init_iterator): Initialize bidi_p from the default value of
2601 bidi-display-reordering, not from buffer-local value. Use the
2602 buffer-local value only if initializing for buffer iteration.
2603 (handle_invisible_prop): Support invisible properties on strings
2604 that are being bidi-reordered.
2605 (set_iterator_to_next): Support bidi reordering of C strings and
2606 Lisp strings.
2607 (next_element_from_string): Support bidi reordering of Lisp
2608 strings.
2609 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2610 (display_string): Support display of R2L glyph rows.
2611 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2612 (init_iterator): Don't initialize it->bidi_p for strings
2613 here.
2614 (reseat_to_string): Initialize it->bidi_p for strings here.
2615 (next_element_from_string, next_element_from_c_string)
2616 (next_element_from_buffer): Add xassert's for correspondence
2617 between IT's object being iterated and it->bidi_it.string
2618 structure.
2619 (face_before_or_after_it_pos): Support bidi iteration.
2620 (next_element_from_c_string): Handle the case of the first string
2621 character that is not the first one in the visual order.
2622 (get_visually_first_element): New function, refactored from common
2623 parts of next_element_from_buffer, next_element_from_string, and
2624 next_element_from_c_string.
2625 (tool_bar_lines_needed, redisplay_tool_bar)
2626 (display_menu_bar): Force left-to-right direction. Add a FIXME
2627 comment for making that be controlled by a user option.
2628 (push_it, pop_it): Save and restore the state of the
2629 bidi iterator. Save and restore the bidi_p flag.
2630 (pop_it): Iterate out of display property for string iteration as
2631 well.
2632 (iterate_out_of_display_property): Support iteration over strings.
2633 (handle_single_display_spec): Set up it->bidi_it for iteration
2634 over a display string, and call bidi_init_it.
2635 (handle_single_display_spec, next_overlay_string)
2636 (get_overlay_strings_1, push_display_prop): Set up the bidi
2637 iterator for displaying display or overlay strings.
2638 (forward_to_next_line_start): Don't use the shortcut if
2639 bidi-iterating.
2640 (back_to_previous_visible_line_start): If handle_display_prop
2641 pushed the iterator stack, restore the internal state of the bidi
2642 iterator by calling bidi_pop_it same number of times.
2643 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2644 and we are bidi-iterating, don't decrement the iterator position;
2645 instead, set the first_elt flag in the bidi iterator, to produce
2646 the same effect.
2647 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2648 (push_display_prop): xassert that we are iterating a buffer.
2649 (push_it, pop_it): Save and restore paragraph_embedding member.
2650 (handle_single_display_spec, next_overlay_string)
2651 (get_overlay_strings_1, reseat_1, reseat_to_string)
2652 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2653 correctly. Don't assume unibyte strings are not bidi-reordered.
2654 (compute_display_string_pos)
2655 (compute_display_string_end): Fix handling the case of C string.
2656 (push_it, pop_it): Save and restore from_disp_prop_p.
2657 (handle_single_display_spec, push_display_prop): Set the
2658 from_disp_prop_p flag.
2659 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2660 (pop_it): Call iterate_out_of_display_property only if we are
2661 popping after iteration over a string that came from a display
2662 property. Fix a typo in popping stretch info. Add an assertion
2663 for verifying that the iterator position is in sync with the bidi
2664 iterator.
2665 (handle_single_display_spec, get_overlay_strings_1)
2666 (push_display_prop): Fix initialization of paragraph direction for
2667 string when that of the parent object is not yet determined.
2668 (reseat_1): Call bidi_init_it to resync the bidi
2669 iterator with IT's position. (Bug#7616)
2670 (find_row_edges): If ROW->start.pos gives position
2671 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2672 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2673 Reset the from_disp_prop_p flag.
2674 (SAVE_IT, RESTORE_IT): New macros.
2675 (pos_visible_p, face_before_or_after_it_pos)
2676 (back_to_previous_visible_line_start)
2677 (move_it_in_display_line_to, move_it_in_display_line)
2678 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2679 (try_scrolling, redisplay_window, display_line): Use them when
2680 saving a temporary copy of the iterator and restoring it back.
2681 (back_to_previous_visible_line_start, reseat_1)
2682 (init_iterator): Empty the bidi cache "stack".
2683 (move_it_in_display_line_to): If iterator ended up at
2684 EOL, but we never saw any buffer positions smaller than
2685 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2686 motion in bidi-reordered lines.
2687 (move_it_in_display_line_to): Record prev_method and prev_pos
2688 immediately before the call to set_iterator_to_next. Fixes cursor
2689 motion in bidi-reordered lines with stretch glyphs and strings
2690 displayed in margins. (Bug#8133) (Bug#8867)
2691 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2692 TO_CHARPOS.
640c8776
SM
2693 (pos_visible_p): Support positions in bidi-reordered lines.
2694 Save and restore bidi cache.
0bb23927
EZ
2695
2696 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2697 (bidi_paragraph_info): Delete unused struct.
2698 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2699 (bidi_cache_start): New variable.
2700 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2701 to zero.
2702 (bidi_cache_fetch_state, bidi_cache_search)
2703 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2704 (bidi_cache_find, bidi_peek_at_next_level)
2705 (bidi_level_of_next_char, bidi_find_other_level_edge)
2706 (bidi_move_to_visually_next): Compare cache index with
2707 bidi_cache_start rather than with zero.
2708 (bidi_fetch_char): Accept new argument STRING; all callers
2709 changed. Support iteration over a string. Support strings with
2710 display properties. Support unibyte strings. Fix the type of
2711 `len' according to what STRING_CHAR_AND_LENGTH expects.
2712 (bidi_paragraph_init, bidi_resolve_explicit_1)
2713 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2714 (bidi_level_of_next_char, bidi_move_to_visually_next):
2715 Support iteration over a string.
0bb23927
EZ
2716 (bidi_set_sor_type, bidi_resolve_explicit_1)
2717 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2718 can now be zero (for strings); special values 0 and -1 were
2719 changed to -1 and -2, respectively.
2720 (bidi_char_at_pos): New function.
2721 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2722 Call it instead of FETCH_MULTIBYTE_CHAR.
2723 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2724 initialized to valid values.
2725 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2726 values.
2727 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2728 the test for valid cached positions. Fix the logic for looking up
2729 the sentinel state in the cache. GCPRO the Lisp string we are
2730 iterating.
2731 (bidi_push_it, bidi_pop_it): New functions.
2732 (bidi_initialize): Initialize the bidi cache start stack pointer.
2733 (bidi_cache_ensure_space): New function, refactored from part of
2734 bidi_cache_iterator_state. Don't assume the required size is just
2735 one BIDI_CACHE_CHUNK away.
2736 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2737 (bidi_count_bytes, bidi_char_at_pos): New functions.
2738 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2739 always valid if bidi_cache_idx is valid.
2740 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2741 is valid if it's going to be used.
2742 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2743 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2744 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2745 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2746 (bidi_find_other_level_edge, bidi_cache_start_stack):
2747 All variables related to cache indices are now EMACS_INT.
c965adc5 2748
0bb23927
EZ
2749 * dispextern.h (struct bidi_string_data): New structure.
2750 (struct bidi_it): New member `string'. Make flag members be 1-bit
2751 fields, and put them last in the struct.
640c8776
SM
2752 (compute_display_string_pos, compute_display_string_end):
2753 Update prototypes.
0bb23927
EZ
2754 (bidi_push_it, bidi_pop_it): Add prototypes.
2755 (struct iterator_stack_entry): New members bidi_p,
2756 paragraph_embedding, and from_disp_prop_p.
2757 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2758 (bidi_shelve_cache, bidi_unshelve_cache):
2759 Declare prototypes.
0bb23927
EZ
2760
2761 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2762 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2763 and vector-like objects.
2764
2765 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2766 cache around display iteration.
2767
2768 * window.c (Fwindow_end, window_scroll_pixel_based)
2769 (displayed_window_lines, Frecenter): Save and restore the bidi
2770 cache around display iteration.
2771
3bbd2265
LMI
27722011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2773
2774 * editfns.c (Fdelete_region): Clarify the use of the named
2775 parameters (bug#6788).
2776
adc47434
MR
27772011-07-14 Martin Rudalics <rudalics@gmx.at>
2778
2779 * indent.c (Fvertical_motion): Set and restore w->pointm when
2780 saving and restoring the window's buffer (Bug#9006).
2781
837c31f8
LMI
27822011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2783
2784 * editfns.c (Fstring_to_char): Clarify just what is returned
2785 (bug#6576). Text by Eli Zaretskii.
2786
ac389d0c
JB
27872011-07-13 Juanma Barranquero <lekktu@gmail.com>
2788
2789 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2790
0be0ce47
EZ
27912011-07-13 Eli Zaretskii <eliz@gnu.org>
2792
2793 * buffer.c (mmap_find): Fix a typo.
2794
cd18e7e3
JB
27952011-07-13 Johan Bockgård <bojohan@gnu.org>
2796
2797 Fix execution of x selection hooks.
2798 * xselect.c (Qx_lost_selection_functions)
2799 (Qx_sent_selection_functions): New vars.
2800 (syms_of_xselect): DEFSYM them.
2801 (x_handle_selection_request): Pass Qx_sent_selection_functions
2802 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2803 (x_handle_selection_clear,x_clear_frame_selections):
2804 Pass Qx_lost_selection_functions rather than
2805 Vx_lost_selection_functions to Frun_hook_with_args.
2806
47ea7f44
PE
28072011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2808
ac389d0c 2809 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2810 The old code sometimes used this field without initializing it.
2811
47ea7f44
PE
2812 * alloc.c (gc_sweep): Don't read past end of array.
2813 In theory, the old code could also have corrupted Emacs internals,
2814 though it'd be very unlikely.
2815
bc985c87
AS
28162011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2817
2818 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2819 argument. (Bug#4026)
bc985c87 2820
0cf34688
LMI
28212011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2822
b3dadd76
LMI
2823 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2824 key" (bug#4257).
2825
0cf34688
LMI
2826 * window.c (Fset_window_start): Doc fix (bug#4199).
2827 (Fset_window_hscroll): Ditto.
2828
270768cd
PE
28292011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2830
077e3dda 2831 Fix minor new problems caught by GCC 4.6.1.
270768cd 2832 * term.c (init_tty): Remove unused local.
490011a6 2833 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2834 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2835 not used otherwise.
270768cd 2836
b1f58454
CY
28372011-07-12 Chong Yidong <cyd@stupidchicken.com>
2838
2839 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2840
22b9578d
LMI
28412011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2842
6e70ab07
LMI
2843 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2844 are the mini-buffer and the echo area (bug#3320).
2845
22b9578d
LMI
2846 * term.c (init_tty): Remove support for supdup, c10 and perq
2847 terminals, which are no longer supported (bug#1482).
2848
8974cc9f
JB
28492011-07-10 Johan Bockgård <bojohan@gnu.org>
2850
2851 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2852
a560d974
JD
28532011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2854
2855 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2856 for non-popups (Bug#3642).
2857
1dae0f0a
AS
28582011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2859
268c2c36 2860 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2861 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2862 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2863 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2864 * data.c (fmod): Likewise.
2865 * dispnew.c (swap_glyphs_in_rows): Likewise.
2866 * emacs.c (memory_warning_signal): Likewise.
2867 * floatfns.c (float_error): Likewise.
2868 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2869 (otf_open, font_otf_capability, generate_otf_features)
2870 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2871 Likewise.
2872 * image.c (pbm_read_file): Likewise.
2873 * indent.c (string_display_width): Likewise.
2874 * intervals.c (check_for_interval, search_for_interval)
2875 (inc_interval_count, count_intervals, root_interval)
2876 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2877 * lread.c (defalias): Likewise.
268c2c36 2878 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2879 * regex.c (set_image_of_range_1, set_image_of_range)
2880 (regex_grow_registers): Likewise.
2881 * sysdep.c (strerror): Likewise.
2882 * termcap.c (valid_filename_p, tprint, main): Likewise.
2883 * tparam.c (main): Likewise.
2884 * unexhp9k800.c (run_time_remap, save_data_space)
2885 (update_file_ptrs, read_header, write_header, calculate_checksum)
2886 (copy_file, copy_rest, display_header): Likewise.
2887 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2888 Likewise.
2889 * xdisp.c (check_it): Likewise.
2890 * xfaces.c (register_color, unregister_color, unregister_colors):
2891 Likewise.
2892 * xfns.c (print_fontset_result): Likewise.
2893 * xrdb.c (member, fatal, main): Likewise.
2894
99033785
PE
28952011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2896
2897 Fix minor problems found by static checking (Bug#9031).
2898 * chartab.c (char_table_set_range, map_sub_char_table):
2899 Remove unused locals.
2900 (uniprop_table): Now static.
2901 * composite.c (_work_char): Remove unused static var.
2902
9cb2ac56
JB
29032011-07-09 Juanma Barranquero <lekktu@gmail.com>
2904
2905 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2906
f25661f0
JD
29072011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2908
2909 * gtkutil.c (qttip_cb): Remove code without function.
2910
8278c4fe
EZ
29112011-07-09 Eli Zaretskii <eliz@gnu.org>
2912
2913 * w32.c (pthread_sigmask): New stub.
2914
1692ae2d 29152011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2916
8a6ebd58 2917 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2918 sigprocmask is portable only for single-threaded applications, and
2919 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2920 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2921 (LIBES): Use it.
2922 * callproc.c (Fcall_process):
2923 * process.c (create_process):
2924 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2925 Use pthread_sigmask, not sigprocmask.
123403e4 2926
1b854618
JD
29272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2928
2929 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2930 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2931 wrong (Bug#8591).
2932
3fe4b549
JD
29332011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2934
0ce7e563
JD
2935 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2936 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2937 (xg_hide_tooltip): Fix comment.
2938
3fe4b549
JD
2939 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2940 in registerServicesMenuSendTypes.
2941 (validRequestorForSendType): Don't check ns_return_types.
2942
2943 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2944 ns_return_type.
2945
5df75e47
JR
29462011-07-08 Jason Rumney <jasonr@gnu.org>
2947
22610910
JR
2948 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2949 SH_SHOW for hidden windows (Bug#5482).
2950
5df75e47
JR
2951 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2952 frame struct members of non-existent frames (Bug#6284).
2953
699c10bd
JD
29542011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2955
4393663b
JD
2956 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2957 variable firstTime not needed on OSX >= 10.6.
2958 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2959 >= 10.5. Use setKnobProportion, setDoubleValue.
2960
2961 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2962 (MAC_OS_X_VERSION_10_5): Define if not defined.
2963 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2964 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2965 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2966
2967 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2968 cString and lossyCString on OSX >= 10.4
2969
2970 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2971 sizeToFit on OSX >= 10.2.
2972
2973 * nsimage.m (allocInitFromFile): Don't use deprecated method
2974 bestRepresentationForDevice on OSX >= 10.6.
2975
2976 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2977 to avoid warning.
2978
2979 * emacs.c: Declare unexec_init_emacs_zone.
2980
a63e0781
JD
2981 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2982
699c10bd
JD
2983 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2984
2985 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2986 on svcsMenu (Bug#8842).
2987
2988 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2989 ns_return_types.
2990 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2991
2992 * nsterm.m (QUTF8_STRING): Declare.
2993 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2994 (validRequestorForSendType): Return type is (id).
2995 Change indexOfObjectIdenticalTo to indexOfObject.
2996 Check if we have local selection before returning self (Bug#8842).
2997 (writeSelectionToPasteboard): Put local selection into paste board
2998 if we have a local selection (Bug#8842).
2999 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3000
3001 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3002 (ns_get_local_selection): Declare.
3003
54e10184
LMI
30042011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3005
9888ff71
LMI
3006 * keymap.c (describe_map_tree): Don't insert a double newline at
3007 the end of the buffer (bug#1169) and return whether we inserted
3008 something.
3009
54e10184
LMI
3010 * callint.c (Fcall_interactively): Change "reading args" to
3011 "providing args" to try to clarify what it does (bug#1010).
3012
15fa4783
KH
30132011-07-07 Kenichi Handa <handa@m17n.org>
3014
3015 * composite.c (composition_compute_stop_pos): Ignore a static
3016 composition starting before CHARPOS (Bug#8915).
3017
3018 * xdisp.c (handle_composition_prop): Likewise.
3019
a8815b00
EZ
30202011-07-07 Eli Zaretskii <eliz@gnu.org>
3021
3022 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3023 (Bug#9015)
3024
ef7b981d 30252011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3026
3027 * character.h (unicode_category_t): New enum type.
3028
3029 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3030 (Qchar_code_property_table): New variable.
3031 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3032 (UNIPROP_COMPRESSED_FORM_P): New macros.
3033 (char_table_ascii): Uncompress the compressed values.
3034 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3035 Uncompress the compressed values.
ac389d0c 3036 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3037 (char_table_ref_and_range): Uncompress the compressed values.
3038 (sub_char_table_set): New arg is_uniprop. Callers changed.
3039 Uncompress the compressed values.
3040 (sub_char_table_set_range): Args changed. Callers changed.
3041 (char_table_set_range): Adjuted for the above change.
3042 (map_sub_char_table): Delete args default_val and parent. Add arg
3043 top. Give decoded values to a Lisp function.
640c8776 3044 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3045 values to a Lisp function. Gcpro more variables.
3046 (uniprop_table_uncompress)
3047 (uniprop_decode_value_run_length): New functions.
3048 (uniprop_decoder, uniprop_decoder_count): New variables.
3049 (uniprop_get_decoder, uniprop_encode_value_character)
3050 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3051 New functions.
3052 (uniprop_encoder, uniprop_encoder_count): New variables.
3053 (uniprop_get_encoder, uniprop_table)
3054 (Funicode_property_table_internal, Fget_unicode_property_internal)
3055 (Fput_unicode_property_internal): New functions.
3056 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3057 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3058 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3059 char-code-property-alist.
3060
640c8776 3061 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3062 Vunicode_category_table.
3063
640c8776 3064 * font.c (font_range): Adjust for the change of
c805dec0
KH
3065 Vunicode_category_table.
3066
76b397fb
DN
30672011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3068
3069 * m/iris4d.h: Remove file, move contents ...
3070 * s/irix6-5.h: ... here.
3071
22b4128e
PE
30722011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3073
3074 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3075 * alloc.c (mark_buffer):
3076 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3077 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3078 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3079 This isn't true in general, and it's particularly not true
3080 if Emacs is configured with --with-wide-int.
3081 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3082 New macros, used in the buffer.c change.
3083
869795d6
JD
30842011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3085
3086 * xsettings.c: Use both GConf and GSettings if both are available.
3087 (store_config_changed_event): Add comment.
3088 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3089 (store_tool_bar_style_changed): New functions.
5e617bc2 3090 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3091 (struct xsettings): Move font inside HAVE_XFT.
3092 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3093 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3094 Move inside HAVE_XFT.
640c8776 3095 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3096 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3097 also.
3098 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3099 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3100 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3101 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3102 (parse_settings): Move check for font inside HAVE_XFT.
3103 (read_settings, apply_xft_settings): Add comment.
3104 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3105 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3106 call store_font_name_changed.
3107 (xft_settings_event): Add comment.
3108 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3109 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3110 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3111 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3112 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3113 (xsettings_get_system_font, xsettings_get_system_normal_font):
3114 Add comment.
869795d6 3115
d8ed26bd
PE
31162011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3117
3118 Random fixes. E.g., (random) never returned negative values.
3119 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3120 subseconds part to the entropy, as that's a bit more random.
3121 Prefer signed to unsigned, since the signedness doesn't matter and
3122 in general we prefer signed. When given a limit, use a
3123 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3124 latter isn't right if USE_2_TAGS_FOR_INTS.
3125 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3126 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3127
cabf1cac
SM
31282011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3129
3130 * textprop.c (text_property_stickiness):
3131 Obey Vtext_property_default_nonsticky.
3132 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3133 * w32fns.c (syms_of_w32fns):
3134 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3135
6e9b2be9
PE
31362011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3137
3138 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3139 This is more efficient than Ffile_directory_p and avoids a minor race.
3140
90186c68
LMI
31412011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3142
7c301272
LMI
3143 * buffer.c (Foverlay_put): Say what the return value is
3144 (bug#7835).
3145
c4f2d8d4
LMI
3146 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3147 is a directory before asking whether to use the file name
3148 (bug#7564).
ad637907
LMI
3149 (barf_or_query_if_file_exists): Make the "File is a directory"
3150 error be more correct.
c4f2d8d4 3151
90186c68
LMI
3152 * fns.c (Frequire): Remove the mention of the .gz files, since
3153 that's installation-specific, but keep the mention of
3154 `get-load-suffixes'.
3155
da64016e
PE
31562011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3157
3158 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3159 Report string overflow if the output is too long.
3160
7d47b580
JB
31612011-07-04 Juanma Barranquero <lekktu@gmail.com>
3162
a555cb87
JB
3163 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3164 (syms_of_gnutls): Remove duplicate DEFSYM for
3165 Qgnutls_bootprop_verify_hostname_error, an error for
3166 Qgnutls_bootprop_verify_error (which is no longer used).
3167
7d47b580
JB
3168 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3169 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3170 Also (re)move comments that are misplaced or no longer relevant.
3171
1e49bfab
LMI
31722011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3173
3174 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3175
1485f4c0
CY
31762011-07-03 Chong Yidong <cyd@stupidchicken.com>
3177
3178 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3179 and background color parameters if they have been changed.
3180
a9ab721e
LMI
31812011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3182
3183 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3184
cf7cff57
PE
31852011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3186
2e13213d
PE
3187 * xsettings.c (SYSTEM_FONT): Define only when used.
3188 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3189
cf7cff57
PE
3190 * keymap.c (access_keymap_1): Now static.
3191
7a8e04f7
CY
31922011-07-02 Chong Yidong <cyd@stupidchicken.com>
3193
3194 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3195 leave any prefix arg for the up event (Bug#1586).
3196
61352f62
LMI
31972011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3198
69bb1ef7
LMI
3199 * lread.c (syms_of_lread): Mention single symbols defined by
3200 `defvar' or `defconst' (bug#7154).
3201
61352f62 3202 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3203 (Frequire): Mention get-load-suffixes.
61352f62 3204
28545e04
MR
32052011-07-02 Martin Rudalics <rudalics@gmx.at>
3206
3207 * window.h (window): Remove clone_number slot.
3208 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3209 Remove.
3210 (make_parent_window, make_window, saved_window)
3211 (Fset_window_configuration, save_window_save): Don't deal with
3212 clone numbers.
3213 * buffer.c (Qclone_number): Remove declaration.
3214 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3215
3349e122
SM
32162011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3217
3218 Add multiple inheritance to keymaps.
3219 * keymap.c (Fmake_composed_keymap): New function.
3220 (Fset_keymap_parent): Simplify.
3221 (fix_submap_inheritance): Remove.
3222 (access_keymap_1): New function extracted from access_keymap to handle
3223 embedded parents and handle lists of maps.
3224 (access_keymap): Use it.
3225 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3226 (Fcopy_keymap): Handle embedded parents.
3227 (Fcommand_remapping, define_as_prefix): Simplify.
3228 (Fkey_binding): Simplify.
3229 (syms_of_keymap): Move minibuffer-local-completion-map,
3230 minibuffer-local-filename-completion-map,
3231 minibuffer-local-must-match-map, and
3232 minibuffer-local-filename-must-match-map to Elisp.
3233 (syms_of_keymap): Defsubr make-composed-keymap.
3234 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3235 (parse_menu_item): Trivial simplification.
3236
3279eb87
GM
32372011-07-01 Glenn Morris <rgm@gnu.org>
3238
3239 * Makefile.in (SETTINGS_LIBS): Fix typo.
3240
4550efdf
KI
32412011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3242
3243 * coding.c (Fencode_coding_string): Record the last coding system
3244 used, as the function doc string says (bug#8738).
3245
0949d2b6
JD
32462011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3247
3248 * xsettings.c (store_monospaced_changed): Take new font as arg and
3249 check for change against current_mono_font.
3250 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3251 (emacs_settings_constructor, emacs_settings_get_property)
3252 (emacs_settings_set_property, emacs_settings_class_init)
3253 (emacs_settings_init, gsettings_obj): Remove.
3254 (something_changedCB): New function for HAVE_GSETTINGS.
3255 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3256 with value as argument.
3257 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3258 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3259 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3260 "changed".
3261
3262 * xgselect.c: Add defined (HAVE_GSETTINGS).
3263 (xgselect_initialize): Ditto.
3264
3265 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3266 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3267 xg_select.
3268
bbc6b304
PE
32692011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3270
3271 * eval.c (struct backtrace): Simplify and port the data structure.
3272 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3273 signed bit field, as this assumption is not portable and it makes
3274 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3275 "char debug_on_exit : 1" as this is not portable either; instead,
3276 use the portable "unsigned int debug_on_exit : 1". Remove unused
3277 member evalargs. Remove obsolete comments about cc bombing out.
3278
9851bfc5
JD
32792011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3280
51bb811f 3281 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3282 Let HAVE_GSETTINGS override HAVE_GCONF.
3283 (store_monospaced_changed): New function.
3284 (EMACS_SETTINGS): A new type derived from GObject to handle
3285 GSettings notifications.
3286 (emacs_settings_constructor, emacs_settings_get_property)
3287 (emacs_settings_set_property, emacs_settings_class_init):
3288 New functions.
3289 (gsettings_client, gsettings_obj): New variables.
3290 (GSETTINGS_SCHEMA): New define.
3291 (something_changedCB): Call store_monospaced_changed.
3292 (init_gsettings): New function.
3293 (xsettings_initialize): Call init_gsettings.
3294 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3295 to NULL.
3296
640c8776 3297 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3298 GCONF_CFLAGS/LIBS.
3299
5386012d
MR
33002011-06-29 Martin Rudalics <rudalics@gmx.at>
3301
3302 * window.c (resize_root_window, grow_mini_window)
3303 (shrink_mini_window): Rename Qresize_root_window to
3304 Qwindow_resize_root_window and Qresize_root_window_vertically to
3305 Qwindow_resize_root_window_vertically.
3306
f13e0b08
PE
33072011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3308
3309 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3310
94515237
JB
33112011-06-27 Juanma Barranquero <lekktu@gmail.com>
3312
3313 * makefile.w32-in: Redesign dependencies so they reflect more
3314 clearly which files are directly included by each source file,
3315 and not through other includes.
3316
e43b6e43
MR
33172011-06-27 Martin Rudalics <rudalics@gmx.at>
3318
3319 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3320 (sort_overlays, overlay_strings): When an overlay's clone number
3321 matches the window's clone number process the overlay even if
3322 the overlay's window property doesn't match the current window.
3323
d68443dc
MR
3324 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3325 (Fwindow_hchild): Rename to Fwindow_left_child.
3326 (Fwindow_next): Rename to Fwindow_next_sibling.
3327 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3328 (resize_window_check): Rename to window_resize_check.
3329 (resize_window_apply): Rename to window_resize_apply.
3330 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3331 (Fdelete_other_windows_internal, resize_frame_windows)
3332 (Fsplit_window_internal, Fdelete_window_internal)
3333 (grow_mini_window, shrink_mini_window)
3334 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3335
c7e73be5
JD
33362011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3337
3338 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3339 (emacs_fixed_set_min_size): Remove.
3340 (emacs_fixed_new): Take frame as argument.
3341
3342 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3343 (_EmacsFixedPrivate): Remove minwidth/height.
3344 Add struct frame *f.
3345 (emacs_fixed_init): Initialize priv->f.
3346 (get_parent_class, emacs_fixed_set_min_size): Remove.
3347 (emacs_fixed_new): Set priv->f to argument.
3348 (emacs_fixed_get_preferred_width)
3349 (emacs_fixed_get_preferred_height): Use min_width/height from
3350 frames size_hint to set minimum and natural (Bug#8919).
3351 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3352 and use min_width/height from frames size_hint to set
3353 min_width/height (Bug#8919).
3354
3355 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3356 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3357 Fix indentation.
c7e73be5 3358
cf99dcf8
EZ
33592011-06-26 Eli Zaretskii <eliz@gnu.org>
3360
3361 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3362 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3363 called at ZV.
3364
029529ac
CY
33652011-06-26 Chong Yidong <cyd@stupidchicken.com>
3366
3367 * process.c (wait_reading_process_output): Bypass select if
3368 waiting for a cell while ignoring keyboard input, and input is
3369 pending. Suggested by Jan Djärv (Bug#8869).
3370
7a7ef429
PE
33712011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3372
3373 Use gnulib's dup2 module instead of rolling our own.
3374 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3375
11fdef7d 33762011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3377
3378 * dispnew.c (scrolling_window): Before scrolling, turn off a
3379 mouse-highlight in the window being scrolled.
3380
cd3520a4
JB
33812011-06-24 Juanma Barranquero <lekktu@gmail.com>
3382
3383 Move DEFSYM to lisp.h and use everywhere.
3384
3385 * character.h (DEFSYM): Move declaration...
3386 * lisp.h (DEFSYM): ...here.
3387
3388 * gnutls.c:
3389 * minibuf.c:
3390 * w32menu.c:
3391 * w32proc.c:
3392 * w32select.c: Don't include character.h.
3393
3394 * alloc.c (syms_of_alloc):
3395 * buffer.c (syms_of_buffer):
3396 * bytecode.c (syms_of_bytecode):
3397 * callint.c (syms_of_callint):
3398 * casefiddle.c (syms_of_casefiddle):
3399 * casetab.c (init_casetab_once):
3400 * category.c (init_category_once, syms_of_category):
3401 * ccl.c (syms_of_ccl):
3402 * cmds.c (syms_of_cmds):
3403 * composite.c (syms_of_composite):
3404 * dbusbind.c (syms_of_dbusbind):
3405 * dired.c (syms_of_dired):
3406 * dispnew.c (syms_of_display):
3407 * doc.c (syms_of_doc):
3408 * editfns.c (syms_of_editfns):
3409 * emacs.c (syms_of_emacs):
3410 * eval.c (syms_of_eval):
3411 * fileio.c (syms_of_fileio):
3412 * fns.c (syms_of_fns):
3413 * frame.c (syms_of_frame):
3414 * fringe.c (syms_of_fringe):
3415 * insdel.c (syms_of_insdel):
3416 * keymap.c (syms_of_keymap):
3417 * lread.c (init_obarray, syms_of_lread):
3418 * macros.c (syms_of_macros):
3419 * msdos.c (syms_of_msdos):
3420 * print.c (syms_of_print):
3421 * process.c (syms_of_process):
3422 * search.c (syms_of_search):
3423 * sound.c (syms_of_sound):
3424 * syntax.c (init_syntax_once, syms_of_syntax):
3425 * terminal.c (syms_of_terminal):
3426 * textprop.c (syms_of_textprop):
3427 * undo.c (syms_of_undo):
3428 * w32.c (globals_of_w32):
3429 * window.c (syms_of_window):
3430 * xdisp.c (syms_of_xdisp):
3431 * xfaces.c (syms_of_xfaces):
3432 * xfns.c (syms_of_xfns):
3433 * xmenu.c (syms_of_xmenu):
3434 * xsettings.c (syms_of_xsettings):
3435 * xterm.c (syms_of_xterm): Use DEFSYM.
3436
4228cf16
TZ
34372011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3438
cd3520a4 3439 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3440
7fcccf1e
PE
34412011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3442
7efb4e0e
PE
3443 Integer and buffer overflow fixes (Bug#8873).
3444
ff5844ad
PE
3445 * print.c (printchar, strout): Check for string overflow.
3446 (PRINTPREPARE, printchar, strout):
3447 Don't set size unless allocation succeeds.
3448
90532f02
PE
3449 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3450 for sizes. Check for string overflow more accurately.
3451 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3452
6d84508d
PE
3453 * macros.c: Integer and buffer overflow fixes.
3454 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3455 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3456 Use ptrdiff_t, not int, for sizes.
3457 Don't increment bufsize until after realloc succeeds.
3458 Check for size-calculation overflow.
3459 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3460
437b2cb4
PE
3461 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3462
8b9ac8b4
PE
3463 * lread.c: Integer overflow fixes.
3464 (read_integer): Radix is now EMACS_INT, not int,
3465 to improve quality of diagnostics for out-of-range radices.
3466 Calculate buffer size correctly for out-of-range radices.
3467 (read1): Check for integer overflow in radices, and in
3468 read-circle numbers.
82cb60d3
PE
3469 (read_escape): Avoid int overflow.
3470 (Fload, openp, read_buffer_size, read1)
3471 (substitute_object_recurse, read_vector, read_list, map_obarray):
3472 Use ptrdiff_t, not int, for sizes.
3473 (read1): Use EMACS_INT, not int, for sizes.
20270765 3474 Check for size overflow.
8b9ac8b4 3475
7fcccf1e
PE
3476 * image.c (cache_image): Check for size arithmetic overflow.
3477
bfbbd7e7
PE
3478 * lread.c: Integer overflow issues.
3479 (saved_doc_string_size, saved_doc_string_length)
3480 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3481 Now ptrdiff_t, not int.
3482 (read1): Don't assume doc string length fits in int. Check for
3483 out-of-range doc string lengths.
3484 (read_list): Don't assume file position fits in int.
39019e54 3485 (read_escape): Check for hex character overflow.
bfbbd7e7 3486
4e323265
LL
34872011-06-22 Leo Liu <sdl.web@gmail.com>
3488
3489 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3490 Move to minibuffer.el.
3491
85fece3e
PE
34922011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3493
20b84ce9 3494 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3495 The following patches are for when GLYPH_DEBUG && !XASSERT.
3496 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3497 * dispnew.c (flush_stdout):
3498 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3499 Mark as externally visible.
3500 * dispnew.c (check_window_matrix_pointers): Now static.
3501 * dispnew.c (window_to_frame_vpos):
3502 * xfns.c (unwind_create_frame):
3503 * xterm.c (x_check_font): Remove unused local.
3504 * scroll.c (CHECK_BOUNDS):
3505 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3506 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3507 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3508 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3509 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3510 Now static.
3511 (debug_method_add): Use va_list and vsprintf rather than relying
3512 on undefined behavior with wrong number of arguments.
3513 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3514 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3515 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3516 since we're not interested in debugging glyphs with old libraries.
3517 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3518 GCC 4.6.0's static checking.
3519
0766b489
PE
35202011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3521
31fd4b32
PE
3522 Integer overflow and signedness fixes (Bug#8873).
3523 A few related buffer overrun fixes, too.
3524
b79e8648
PE
3525 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3526
0766b489
PE
3527 * dispextern.h (struct face.stipple):
3528 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3529 (x_bitmap_mask, x_allocate_bitmap_record)
3530 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3531 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3532 (x_create_bitmap_from_xpm_data):
3533 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3534 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3535 (.bitmaps_last):
3536 * xfaces.c (load_pixmap):
3537 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3538 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3539 (.bitmaps_last, struct x_output.icon_bitmap):
3540 Use ptrdiff_t, not int, for bitmap indexes.
3541 (x_allocate_bitmap_record): Check for size overflow.
3542 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3543
b081724f
PE
3544 Use ptrdiff_t, not int, for overlay counts.
3545 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3546 * editfns.c (overlays_around, get_pos_property):
3547 * textprop.c (get_char_property_and_overlay):
3548 * xdisp.c (next_overlay_change, note_mouse_highlight):
3549 * xfaces.c (face_at_buffer_position):
21514da7
PE
3550 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3551 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3552 (Fnext_overlay_change, Fprevious_overlay_change)
3553 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3554 Use ptrdiff_t, not int, for sizes.
21514da7 3555 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3556
3de73e5e
PE
3557 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3558
2606c57b
PE
3559 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3560 (x_session_initialize): Do not assume string length fits in int.
3561
aaafe47a
PE
3562 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3563 This is unlikely, but can occur if DPI is outlandish.
3564
2674ddc8 3565 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3566 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3567
28154962
PE
3568 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3569 * xrdb.c (magic_file_p, search_magic_path):
3570 Omit last arg SUFFIX; it was always 0. All callers changed.
3571 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3572
7de51af5
PE
3573 * xfont.c (xfont_match): Avoid need for strlen.
3574
25ed6cc3
PE
3575 * xfns.c: Don't assume strlen fits in int.
3576 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3577
4eab31dd
PE
3578 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3579 not unsigned long, as we prefer signed integers. All callers changed.
3580 Detect integer overflow in repeat count.
3581 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3582 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3583
171e2a58
PE
3584 * termcap.c: Don't assume sizes fit in int and never overflow.
3585 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3586 (gobble_line): Check for size-calculation overflow.
3587
ad39faca 3588 * minibuf.c (Fread_buffer):
6e5bb2dc 3589 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3590 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3591 Don't assume string length fits in int.
3592
52c61c22 3593 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3594 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3595
b5b8c9e5
PE
3596 * font.c: Don't assume string length fits in int.
3597 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3598 Use ptrdiff_t, not int.
ccd6111c
PE
3599 (font_intern_prop): Don't assume string length fits in int.
3600 Don't assume integer property fits in fixnum.
3601 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3602
882f0d81 3603 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3604 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3605 Reformulate so as not to need the command string.
3606 Invoke gzip -cd rather than gunzip, as it's more portable.
3607 (lock_info_type, lock_file_1, lock_file):
3608 Don't assume pid_t and time_t fit in unsigned long.
3609 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3610 (current_lock_owner): Prefer signed type for sizes.
3611 Use memcpy, not strncpy, where memcpy is what is really wanted.
3612 Don't assume (via atoi) that time_t and pid_t fit in int.
3613 Check for time_t and/or pid_t out of range, e.g., via a network share.
3614 Don't alloca where an auto var works fine.
3615
93f4cf88
PE
3616 * fileio.c: Fix some integer overflow issues.
3617 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3618 Don't assume string length fits in int.
3619 (directory_file_name): Don't assume string length fits in long.
3620 (make_temp_name): Don't assume pid fits in int, or that its print
3621 length is less than 20.
3622
f3e92b69
PE
3623 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3624
1bfdaf10
PE
3625 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3626
35016e9a
PE
3627 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3628
3d1e65a1
PE
3629 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3630 We prefer signed integers, even for size calculations.
3631
0b963a93
PE
3632 * emacs.c: Don't assume string length fits in 'int'.
3633 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3634 (main): Don't invoke strlen when not needed.
3635
573f4b54
PE
3636 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3637 (XD_DEBUG_MESSAGE): Don't waste a byte.
3638
989f33ba
PE
3639 * callproc.c (getenv_internal_1, getenv_internal)
3640 (Fgetenv_internal):
965d34eb
PE
3641 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3642
e4d29b33
PE
3643 * lread.c (invalid_syntax): Omit length argument.
3644 All uses changed. This doesn't fix a bug, but it simplifies the
3645 code away from its former Hollerith-constant appearance, and it's
3646 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3647 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3648
eb49b136
PE
3649 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3650 This didn't break anything, but it didn't help either.
3651 It's confusing to put a bogus integer in a place where the actual
3652 value does not matter.
9f62aeb1 3653 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3654 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3655
15375a22
PE
3656 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3657 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3658 implementation.
b61cc01c
PE
3659 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3660 We prefer signed types, and the value cannot exceed the EMACS_INT
3661 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3662 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3663 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3664 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3665
53b2623d
PE
3666 * indent.c (sane_tab_width): New function.
3667 (current_column, scan_for_column, Findent_to, position_indentation)
3668 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3669 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3670
51cab52b 3671 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3672
f2ed8a70
PE
3673 * lisp.h (lint_assume): New macro.
3674 * composite.c (composition_gstring_put_cache):
3675 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3676
abe80cc6
PE
3677 * editfns.c, insdel.c:
3678 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3679
b02c740e
PE
3680 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3681
ebc96716
PE
3682 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3683
b4e50fa0 3684 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3685 Use much-faster test for byte-length change.
311d5d7c 3686 Don't assume string byte-length fits in 'int'.
a4cf38e4 3687 Check that character arg fits in 'int'.
85461888 3688 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3689
c0c1ee9f
PE
3690 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3691
a498d7f4
PE
3692 * fns.c (concat): Catch string overflow earlier.
3693 Do not rely on integer wraparound.
3694
51cab52b
PE
3695 * dispextern.h (struct it.overlay_strings_charpos)
3696 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3697 * xdisp.c (forward_to_next_line_start)
3698 (back_to_previous_visible_line_start)
3699 (reseat_at_next_visible_line_start, next_element_from_buffer):
3700 Don't arbitrarily truncate the value of 'selective' to int.
3701
76031fad
PE
3702 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3703
5eb55db9
PE
3704 * composite.c: Don't truncate sizes to 'int'.
3705 (composition_gstring_p, composition_reseat_it)
3706 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3707 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3708 not EMACS_UINT, for indexes.
5eb55db9 3709
0703a717
PE
3710 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3711
d6202519
PE
3712 * buffer.c: Include <verify.h>.
3713 (struct sortvec.priority, struct sortstr.priority):
8961a454 3714 Now EMACS_INT, not int.
c20998a7 3715 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3716 (struct sortstr.size, record_overlay_string)
3717 (struct sortstrlist.size, struct sortlist.used):
3718 Don't truncate size to int.
3719 (record_overlay_string): Check for size-calculation overflow.
d6202519 3720 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3721
d5a19415
JM
37222011-06-22 Jim Meyering <meyering@redhat.com>
3723
029529ac 3724 Don't leak an XBM-image-sized buffer
d5a19415
JM
3725 * image.c (xbm_load): Free the image buffer after using it.
3726
a9041e6c
PE
37272011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3728
3729 Port to Sun C.
3730 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3731 that Sun C diagnosed.
3732 * fns.c (secure_hash): Fix pointer signedness issue.
3733 * intervals.c (static_offset_intervals): New function.
3734 (offset_intervals): Use it.
3735
7f3f739f
LL
37362011-06-21 Leo Liu <sdl.web@gmail.com>
3737
3738 * deps.mk (fns.o):
3739 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3740 sha512.h.
3741
3742 * fns.c (secure_hash): Rename from crypto_hash_function and change
3743 the first arg to accept symbols.
5b66d427 3744 (Fsecure_hash): New primitive.
7f3f739f
LL
3745 (syms_of_fns): New symbols.
3746
76147d94
DD
37472011-06-20 Deniz Dogan <deniz@dogan.se>
3748
3749 * process.c (Fset_process_buffer): Clarify return value in
3750 docstring.
3751
7d7d0045
CY
37522011-06-18 Chong Yidong <cyd@stupidchicken.com>
3753
3754 * dispnew.c (add_window_display_history): Use BVAR.
3755
3756 * xdisp.c (debug_method_add): Use BVAR.
3757 (check_window_end, dump_glyph_matrix, dump_glyph)
3758 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3759
3760 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3761 Likewise.
3762
3763 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3764 check till after the cache is created in init_frame_faces.
3765
ff2bc410
SM
37662011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3767
3768 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3769
28177add
PE
37702011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3771
dd3482fe
PE
3772 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3773 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3774 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3775
393d71f3 3776 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3777 * fileio.c (Finsert_file_contents):
3778 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3779 Remove the old (too-loose) buffer overflow checks.
3780 They weren't needed, since make_gap checks for buffer overflow.
3781 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3782 The old code merely checked for Emacs fixnum overflow, and relied
3783 on undefined (wraparound) behavior. The new code avoids undefined
3784 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3785
2e6813b0 3786 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3787 Tune. Don't use wider integers than needed. Don't use alloca.
3788 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3789
599a9e4f
PE
3790 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3791
99561444
PE
3792 * insdel.c, lisp.h (buffer_overflow): New function.
3793 (insert_from_buffer_1, replace_range, replace_range_2):
3794 * insdel.c (make_gap_larger):
3795 * editfns.c (Finsert_char):
3796 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3797
28177add
PE
3798 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3799
e69dafad
PE
38002011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3801
a7af7fde 3802 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3803
b1c46f02
PE
3804 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3805 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3806
e69dafad
PE
3807 * fileio.c: Don't assume EMACS_INT fits in off_t.
3808 (emacs_lseek): New static function.
3809 (Finsert_file_contents, Fwrite_region): Use it.
3810 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3811
566684ea
PE
3812 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3813
e6966cd6
PE
3814 * fns.c: Don't overflow int when computing a list length.
3815 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3816 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3817 truncation on 64-bit hosts. Check for QUIT every
3818 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3819 faster and is responsive enough.
3820 (Flength): Report an error instead of overflowing an integer.
3821 (Fsafe_length): Return a float if the value is not representable
3822 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3823 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3824 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3825
dd0b0efb
PE
3826 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3827 (header_size, word_size): New constants.
3828 (allocate_vectorlike): Don't check size overflow here.
3829 (allocate_vector): Check it here instead, since this is the only
3830 caller of allocate_vectorlike that could cause overflow.
3831 Check that the new vector's length is representable as a fixnum.
3832
86fe5cfe
PE
3833 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3834 The previous code was bogus. For example, next_almost_prime (32)
3835 returned 39, which is undesirable as it is a multiple of 3; and
3836 next_almost_prime (24) returned 25, which is a multiple of 5 so
3837 why was the code bothering to check for multiples of 7?
3838
80e88859
PE
3839 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3840
4a2f0ad6
PE
3841 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3842
f66c7cf8
PE
3843 Variadic C functions now count arguments with ptrdiff_t.
3844 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3845 Back then I didn't know that the Emacs coding style prefers signed int.
3846 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3847 were being counted with int, which may truncate counts on 64-bit
3848 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3849 * lisp.h (struct Lisp_Subr.function.aMANY)
3850 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3851 Arg counts are now ptrdiff_t, not size_t.
3852 All variadic functions and their callers changed accordingly.
3853 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3854 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3855 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3856 * callint.c (Fcall_interactively): Check arg count for overflow,
3857 to avoid potential buffer overrun. Use signed char, not 'int',
3858 for 'varies' array, so that we needn't bother to check its size
3859 calculation for overflow.
3860 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3861 * eval.c (apply_lambda):
3862 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3863 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3864 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3865
a1759b76
PE
3866 * callint.c (Fcall_interactively): Don't use index var as event count.
3867
d96be9fc
PE
3868 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3869 * mem-limits.h (SIZE): Remove; no longer used.
3870
a690a978 3871 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3872
578c21e6
PE
3873 Remove unnecessary casts.
3874 * xterm.c (x_term_init):
3875 * xfns.c (x_set_border_pixel):
3876 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3877 These aren't needed now that we assume ANSI C.
3878
96f53c6c
PE
3879 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3880 It's more likely to cause problems (due to unsigned overflow)
3881 than to cure them.
3882
83c77d31
PE
3883 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3884
ee2079f1
PE
3885 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3886
6da65536
PE
3887 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3888
7147c4a4
PE
3889 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3890
193e32d9
PE
3891 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3892
e5533da6
PE
3893 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3894
9910e595
PE
3895 GLYPH_CODE_FACE returns EMACS_INT, not int.
3896 * dispextern.h (merge_faces):
3897 * xfaces.c (merge_faces):
01103c44
PE
3898 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3899 Don't assume EMACS_INT fits in int.
9910e595 3900
2638320e
PE
3901 * character.h (CHAR_VALID_P): Remove unused parameter.
3902 * fontset.c, lisp.h, xdisp.c: All uses changed.
3903
045eb8d9
PE
3904 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3905
c1f134b5
PE
3906 * fns.c (concat): Minor tuning based on overflow analysis.
3907 This doesn't fix any bugs. Use int to hold character, instead
3908 of constantly refetching from Emacs object. Use XFASTINT, not
3909 XINT, for value known to be a character. Don't bother comparing
3910 a single byte to 0400, as it's always less.
3911
395fcb93 3912 * floatfns.c (Fexpt):
327eeec8
PE
3913 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3914
abbd3d23
PE
3915 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3916 for characters.
3917
684a03ef
PE
3918 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3919
0fed43f3
PE
3920 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3921 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3922 incorrectly succeed when S was a string, because 4294967386 was
3923 truncated before it was used.
3924
8fd02eb7
PE
3925 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3926 Otherwise, an out-of-range integer could cause undefined behavior
3927 on a 64-bit host.
3928
f8c86b69
PE
3929 * composite.c: Use int, not EMACS_INT, for characters.
3930 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3931 EMACS_INT, for values that are known to be in character range.
3932 This doesn't fix any bugs but is the usual style inside Emacs and
3933 may generate better code on 32-bit machines.
3934
34206dd2
PE
3935 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3936 This is for reasons similar to the recent CHAR_STRING fix.
3937 * charset.c (Fencode_char): Check that character arg is actually
3938 a character. Pass an int to ENCODE_CHAR.
3939 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3940 wider than 'int', as a compile-time check to prevent future regressions
3941 in this area.
3942
c5958d4c 3943 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3944
3945 Make sure a 64-bit char is never passed to CHAR_STRING.
3946 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3947 by silently ignoring the top 32 bits, allowing some values
3948 that were far too large to be valid characters.
3949 * character.h: Include <verify.h>.
3950 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3951 arguments are no wider than unsigned, as a compile-time check
3952 to prevent future regressions in this area.
3953 * data.c (Faset):
01103c44 3954 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3955 (Fsubst_char_in_region):
3956 * fns.c (concat):
3957 * xdisp.c (decode_mode_spec_coding):
3958 Adjust to CHAR_STRING's new requirement.
3959 * editfns.c (Finsert_char, Fsubst_char_in_region):
3960 * fns.c (concat): Check that character args are actually
3961 characters. Without this test, these functions did the wrong
3962 thing with wildly out-of-range values on 64-bit hosts.
3963
d37ca623
PE
3964 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3965 These casts should not be needed on 32-bit hosts, either.
3966 * keyboard.c (read_char):
3967 * lread.c (Fload): Remove casts to unsigned.
3968
ea204efb
PE
3969 * lisp.h (UNSIGNED_CMP): New macro.
3970 This fixes comparison bugs on 64-bit hosts.
3971 (ASCII_CHAR_P): Use it.
3972 * casefiddle.c (casify_object):
01103c44 3973 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3974 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3975 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3976 * dispextern.h (FACE_FROM_ID):
3977 * keyboard.c (read_char): Use UNSIGNED_CMP.
3978
41cb286c
PE
3979 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3980 not to EMACS_INT, to avoid GCC warning.
3981
4a1b9832
PE
3982 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3983
55daad71
PE
3984 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3985 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3986 isn't needed on 32-bit machines.
8f95c75c 3987
01103c44
PE
3988 * buffer.c (Fgenerate_new_buffer_name):
3989 Use EMACS_INT for count, not int.
0ceccced 3990 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3991
3992 * data.c (Qcompiled_function): Now static.
3993
c6f072e7
PE
3994 * window.c (window_body_lines): Now static.
3995
20ce5912
PE
3996 * image.c (gif_load): Rename local to avoid shadowing.
3997
9c4c5f81
PE
3998 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3999 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4000 * alloc.c (make_save_value): Integer argument is now of type
4001 ptrdiff_t, not int.
4002 (mark_object): Use ptrdiff_t, not int.
4003 * lisp.h (pD): New macro.
4004 * print.c (print_object): Use it.
4005
c0c5c8ae
PE
4006 * alloc.c: Use EMACS_INT, not int, to count objects.
4007 (total_conses, total_markers, total_symbols, total_vector_size)
4008 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4009 (total_free_floats, total_floats, total_free_intervals)
4010 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4011 Now EMACS_INT, not int. All uses changed.
4012 (Fgarbage_collect): Compute overall total using a double, so that
4013 integer overflow is less likely to be a problem. Check for overflow
4014 when converting back to an integer.
5a25e253
PE
4015 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4016 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4017 These were 'int' variables that could overflow on 64-bit hosts;
4018 they were never used, so remove them instead of repairing them.
211a0b2a 4019 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4020 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4021 Previously, this ceilinged at INT_MAX, but that doesn't work on
4022 64-bit machines.
e46bb31a 4023 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4024
c78baabf 4025 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4026 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4027 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4028 when a (possibly-narrower) signed value would do just as well.
4029 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4030
c9d624c6
PE
4031 * alloc.c: Catch some string size overflows that we were missing.
4032 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4033 for convenience in STRING_BYTES_MAX.
4034 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4035 The definition here is exact; the one in lisp.h was approximate.
4036 (allocate_string_data): Check for string overflow. This catches
4037 some instances we weren't catching before. Also, it catches
4038 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4039 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4040 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4041
c9d624c6
PE
4042 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4043 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4044 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4045
353032ce
PE
4046 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4047
2bccce07
PE
4048 * alloc.c (Fmake_string): Check for out-of-range init.
4049
0ac30604
SM
40502011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4051
4052 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4053
c195f2de
JD
40542011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4055
4056 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4057 xg_get_default_scrollbar_width.
4058
4059 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4060 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4061 (style_changed_cb): Call update_theme_scrollbar_width and call
4062 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4063 all frames (Bug#8505).
4064 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4065 Call gtk_window_set_resizable if HAVE_GTK3.
4066 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4067 and height if HAVE_GTK3 (Bug#8505).
4068 (scroll_bar_width_for_theme): New variable.
4069 (update_theme_scrollbar_width): New function.
4070 (xg_get_default_scrollbar_width): Move code to
4071 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4072 (xg_initialize): Call update_theme_scrollbar_width.
4073
4074 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4075
4076 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4077
e10ac9f1
MR
40782011-06-12 Martin Rudalics <rudalics@gmx.at>
4079
4080 * frame.c (make_frame): Call other_buffer_safely instead of
4081 other_buffer.
4082
4083 * window.c (temp_output_buffer_show): Call display_buffer with
4084 second argument Vtemp_buffer_show_specifiers and reset latter
4085 immediately after the call.
4086 (Vtemp_buffer_show_specifiers): New variable.
4087 (auto_window_vscroll_p, next_screen_context_lines)
4088 (Vscroll_preserve_screen_position): Remove leading asterisks from
4089 doc-strings.
4090
2d3c217e 40912011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4092
7b7f97e8 4093 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4094 * buffer.c (Qclone_number): Remove for now, as it's unused.
4095 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4096 (record_buffer): Remove unused local.
4097 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4098 (set_frame_buffer_list): Remove; unused.
4099 * frame.h (other_visible_frames): Remove decl.
4100 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4101 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4102 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4103 if HAVE_GPM.
4104 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4105 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4106 Define only if HAVE_GPM.
4107 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4108 (update_hints_inhibit): Remove; never set. All uses removed.
4109 * widgetprv.h (emacsFrameClassRec): Remove decl.
4110 * window.c (delete_deletable_window): Now returns void, since it
4111 wasn't returning anything.
4112 (compare_window_configurations): Remove unused locals.
4113 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4114 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4115 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4116 the same widths as pointers. This follows up on the 2011-05-06 patch.
4117 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4118 * xterm.h: Likewise.
4119 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4120
1384b89e
JB
41212011-06-12 Juanma Barranquero <lekktu@gmail.com>
4122
4123 * makefile.w32-in: Update dependencies.
4124 (LISP_H): Add lib/intprops.h.
4125
1100a63c
CY
41262011-06-11 Chong Yidong <cyd@stupidchicken.com>
4127
4128 * image.c (gif_load): Add animation frame delay to the metadata.
4129 (syms_of_image): Use DEFSYM. New symbol `delay'.
4130
6198ccd0
MR
41312011-06-11 Martin Rudalics <rudalics@gmx.at>
4132
4133 * window.c (delete_deletable_window): Re-add.
4134 (Fset_window_configuration): Rewrite to handle dead buffers and
4135 consequently deletable windows.
4136 (window_tree, Fwindow_tree): Remove. Supply functionality in
4137 window.el.
4138 (compare_window_configurations): Simplify code.
4139
b6e3633c
AS
41402011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4141
1ab0dee5
AS
4142 * image.c (imagemagick_load_image): Fix type mismatch.
4143 (Fimagemagick_types): Likewise.
4144
b6e3633c
AS
4145 * window.h (replace_buffer_in_windows): Declare.
4146
9397e56f
MR
41472011-06-11 Martin Rudalics <rudalics@gmx.at>
4148
4149 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4150 Qclone_number. Remove external declaration of Qdelete_window.
4151 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4152 code.
640c8776
SM
4153 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4154 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4155 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4156 buffer list implementation.
4157 (other_buffer_safely): New function.
4158 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4159 calls to replace_buffer_in_windows and
4160 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4161 if allowed.
4162 (record_buffer): Inhibit quitting and rewrite using quittable
4163 functions. Run Qbuffer_list_update_hook if allowed.
4164 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4165 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4166 Move switch-to-buffer to window.el.
9397e56f
MR
4167 (bury-buffer): Move to window.el.
4168 (Vbuffer_list_update_hook): New variable.
4169
4170 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4171 section.
4172
4173 * window.h (resize_frame_windows): Move up in code.
4174 (Fwindow_frame): Remove EXFUN.
4175 (replace_buffer_in_all_windows): Remove prototype.
4176 (replace_buffer_in_windows_safely): Add prototype.
4177
4178 * window.c: Declare Qdelete_window static again. Move down
4179 declaration of select_count.
4180 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4181 (Fother_window): Move to window.el.
4182 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4183 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4184 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4185 window.el.
4186 (replace_buffer_in_windows): Implement by calling
4187 Qreplace_buffer_in_windows.
4188 (replace_buffer_in_all_windows): Remove with some functionality
4189 moved into replace_buffer_in_windows_safely.
4190 (replace_buffer_in_windows_safely): New function.
4191 (select_window_norecord, select_frame_norecord): Move in front
4192 of run_window_configuration_change_hook. Remove now obsolete
4193 declarations.
640c8776
SM
4194 (Fset_window_buffer): Rewrite doc-string.
4195 Call Qrecord_window_buffer.
9397e56f
MR
4196 (keys_of_window): Move binding for other-window to window.el.
4197
b50691aa
CY
41982011-06-11 Chong Yidong <cyd@stupidchicken.com>
4199
4200 * dispextern.h (struct image): Replace data member, whose int_val
4201 and ptr_val fields were not used by anything, with a single
4202 lisp_val object.
4203
4204 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4205 (gif_clear_image, gif_load, imagemagick_load_image)
4206 (gs_clear_image, gs_load): Callers changed.
4207
3f754b86
PE
42082011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4209
cca69397
PE
4210 * buffer.h: Include <time.h>, for time_t.
4211 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4212
109e28d0
PE
4213 Fix minor problems found by static checking.
4214
60737f02
PE
4215 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4216
4b66faf3
PE
4217 Make identifiers static if they are not used in other modules.
4218 * data.c (Qcompiled_function, Qframe, Qvector):
4219 * image.c (QimageMagick, Qsvg):
4220 * minibuf.c (Qmetadata):
4221 * window.c (resize_window_check, resize_root_window): Now static.
4222 * window.h (resize_window_check, resize_root_window): Remove decls.
4223
109e28d0
PE
4224 * window.c (window_deletion_count, delete_deletable_window):
4225 Remove; unused.
46a4ce9e
PE
4226 (window_body_lines): Now static.
4227 (Fdelete_other_windows_internal): Mark vars as initialized.
4228 Make sure 'resize_failed' is initialized.
4229 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4230 (resize_window_apply): Remove unused local.
4231 * window.h (delete_deletable_window): Remove decl.
4232
109e28d0 4233 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4234 (imagemagick_load_image): Fix pointer signedness problem by changing
4235 last arg from unsigned char * to char *. All uses changed.
4236 Also, fix a local for similar reasons.
4237 Remove unused locals. Remove locals to avoid shadowing.
4238 (fn_rsvg_handle_free): Remove; unused.
4239 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4240 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4241
3f754b86
PE
4242 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4243
2547adb1
CY
42442011-06-10 Chong Yidong <cyd@stupidchicken.com>
4245
4246 * image.c (gif_load): Fix omitted cast error introduced by
4247 2011-06-06 change.
4248
2c8e37d4
MR
42492011-06-10 Martin Rudalics <rudalics@gmx.at>
4250
4251 * window.h (resize_proportionally, orig_total_lines)
4252 (orig_top_line): Remove from window structure.
4253 (set_window_height, set_window_width, change_window_heights)
4254 (Fdelete_window): Remove prototypes.
4255 (resize_frame_windows): Remove duplicate declaration.
4256
440a42e3
EZ
42572011-06-10 Eli Zaretskii <eliz@gnu.org>
4258
4259 * window.h (resize_frame_windows, resize_window_check)
4260 (delete_deletable_window, resize_root_window)
4261 (resize_frame_windows): Declare prototypes.
4262
4263 * window.c (resize_window_apply): Make definition be "static" to
4264 match the prototype.
4265
562dd5e9
MR
42662011-06-10 Martin Rudalics <rudalics@gmx.at>
4267
4268 * window.c: Remove declarations of Qwindow_size_fixed,
4269 window_min_size_1, window_min_size_2, window_min_size,
4270 size_window, window_fixed_size_p, enlarge_window, delete_window.
4271 Remove static from declaration of Qdelete_window, it's
4272 temporarily needed by Fbury_buffer.
4273 (replace_window): Don't assign orig_top_line and
4274 orig_total_lines.
4275 (Fdelete_window, delete_window): Remove. Window deletion is
4276 handled by window.el.
640c8776
SM
4277 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4278 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4279 (Fdelete_other_windows): Remove. Deleting other windows is
4280 handled by window.el.
4281 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4282 handled in window.el.
4283 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4284 Window minimum sizes are handled in window.el.
4285 (shrink_windows, size_window, set_window_height)
4286 (set_window_width, change_window_heights, window_height)
4287 (window_width, CURBEG, CURSIZE, enlarge_window)
4288 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4289 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4290 handled in window.el.
4291 (make_dummy_parent): Rename to make_parent_window and give it a
4292 second argument horflag.
4293 (make_window): Don't set resize_proportionally any more.
4294 (Fsplit_window): Remove. Windows are split in window.el.
4295 (save_restore_action, save_restore_orig_size)
4296 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4297 Resize mini windows in window.el.
4298 (grow_mini_window, shrink_mini_window): Implement by calling
4299 Qresize_root_window_vertically, resize_window_check and
4300 resize_window_apply.
640c8776
SM
4301 (saved_window, Fset_window_configuration, save_window_save):
4302 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4303 resize_proportionally.
4304 (window_min_height, window_min_width): Move to window.el.
4305 (keys_of_window): Move bindings for delete-other-windows,
4306 split-window, delete-window and enlarge-window to window.el.
4307
4308 * buffer.c: Temporarily extern Qdelete_window.
4309 (Fbury_buffer): Temporarily call Qdelete_window instead of
4310 Fdelete_window (Fbury_buffer will move to window.el soon).
4311
4312 * frame.c (set_menu_bar_lines_1): Remove code handling
4313 orig_top_line and orig_total_lines.
4314
4315 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4316 set_window_height but set heights directly.
4317 (change_frame_size_1): Use resize_frame_windows.
4318
4319 * xdisp.c (init_xdisp): Don't use set_window_height but set
4320 heights directly.
4321
640c8776
SM
4322 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4323 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4324 run_window_configuration_change_hook.
4325
4326 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4327 instead of change_window_heights and run
4328 run_window_configuration_change_hook.
4329
1a13852e
MR
43302011-06-09 Martin Rudalics <rudalics@gmx.at>
4331
4332 * window.c (replace_window): Rename second argument REPLACEMENT to
4333 NEW. New third argument SETFLAG. Rewrite.
4334 (delete_window, make_dummy_parent): Call replace_window with
4335 third argument 1.
4336 (window_list_1): Move down in code.
4337 (run_window_configuration_change_hook): Move set_buffer part
4338 before select_frame_norecord part in order to unwind correctly.
4339 Rename count1 to count.
4340 (recombine_windows, delete_deletable_window, resize_root_window)
4341 (Fdelete_other_windows_internal)
4342 (Frun_window_configuration_change_hook, make_parent_window)
4343 (resize_window_check, resize_window_apply, Fresize_window_apply)
4344 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4345 (Fdelete_window_internal, Fresize_mini_window_internal):
4346 New functions.
1a13852e
MR
4347 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4348
f3d1777e
MR
43492011-06-08 Martin Rudalics <rudalics@gmx.at>
4350
496e208e
MR
4351 * window.h (window): Add some new members to window structure -
4352 normal_lines, normal_cols, new_total, new_normal, clone_number,
4353 splits, nest, prev_buffers, next_buffers.
4354 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4355 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4356
f3d1777e
MR
4357 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4358 Remove.
496e208e
MR
4359 (make_dummy_parent): Set new members of windows structure.
4360 (make_window): Move down in code. Handle new members of window
4361 structure.
4362 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4363 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4364 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4365 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4366 (Fset_window_next_buffers, Fset_window_clone_number):
4367 New functions.
496e208e
MR
4368 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4369 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4370 Doc-string fixes.
4371 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4372 Argument WINDOW can be now internal window too.
4373 (Fwindow_use_time): Move up in code.
4374 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4375 Rewrite doc-string.
4376 (Fset_window_configuration, saved_window)
4377 (Fcurrent_window_configuration, save_window_save): Handle new
4378 members of window structure.
b9e809c2
MR
4379 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4380 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4381 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4382 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4383 Qget_mru_window, Qresize_root_window,
4384 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4385 Qauto_buffer_name; staticpro them.
f3d1777e 4386
abde8f8c
MR
43872011-06-07 Martin Rudalics <rudalics@gmx.at>
4388
4389 * window.c (Fwindow_total_size, Fwindow_left_column)
4390 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4391 (Fwindow_list_1): New functions.
4392 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4393 (Fwindow_width, Fscroll_left, Fscroll_right):
4394 Use window_body_cols instead of window_box_text_cols.
4395 (delete_window, Fset_window_configuration):
4396 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4397 (delete_all_subwindows): Take a window as argument and not a
4398 structure. Rewrite.
190b47e6
MR
4399 (window_loop): Remove handling of GET_LRU_WINDOW and
4400 GET_LARGEST_WINDOW.
4401 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4402
4403 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4404 window_box_text_cols. delete_all_subwindows now takes a
4405 Lisp_Object as argument.
abde8f8c 4406
640c8776
SM
4407 * indent.c (compute_motion, Fcompute_motion):
4408 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4409
fa8a67e6
MR
4410 * frame.c (delete_frame): Call delete_all_subwindows with root
4411 window as argument.
4412
a54e3482
DC
44132011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4414
4415 * fns.c (Fputhash): Document return value.
4416
60002bf5
CY
44172011-06-06 Chong Yidong <cyd@stupidchicken.com>
4418
4419 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4420
0c671da6 44212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4422
b862a52a 4423 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4424
be44ca6c
PE
4425 Check for overflow when converting integer to cons and back.
4426 * charset.c (Fdefine_charset_internal, Fdecode_char):
4427 Use cons_to_unsigned to catch overflow.
4428 (Fencode_char): Use INTEGER_TO_CONS.
4429 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4430 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4431 * data.c (long_to_cons, cons_to_long): Remove.
4432 (cons_to_unsigned, cons_to_signed): New functions.
4433 These signal an error for invalid or out-of-range values.
4434 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4435 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4436 * font.c (Ffont_variation_glyphs):
4437 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4438 * lisp.h: Include <intprops.h>.
4439 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4440 (cons_to_signed, cons_to_unsigned): New decls.
4441 (long_to_cons, cons_to_long): Remove decls.
4442 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4443 (Fprimitive_undo): Use CONS_TO_INTEGER.
4444 * xfns.c (Fx_window_property): Likewise.
4445 * xselect.c: Include <limits.h>.
4446 (x_own_selection, selection_data_to_lisp_data):
4447 Use INTEGER_TO_CONS.
4448 (x_handle_selection_request, x_handle_selection_clear)
4449 (x_get_foreign_selection, Fx_disown_selection_internal)
4450 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4451 (lisp_data_to_selection_data): Use cons_to_unsigned.
4452 (x_fill_property_data): Use cons_to_signed.
4453 Report values out of range.
4454
d1f3d2af
PE
4455 Check for buffer and string overflow more precisely.
4456 * buffer.h (BUF_BYTES_MAX): New macro.
4457 * lisp.h (STRING_BYTES_MAX): New macro.
4458 * alloc.c (Fmake_string):
4459 * character.c (string_escape_byte8):
4460 * coding.c (coding_alloc_by_realloc):
4461 * doprnt.c (doprnt):
4462 * editfns.c (Fformat):
4463 * eval.c (verror):
4464 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4465 since they may not be the same number.
4466 * editfns.c (Finsert_char):
4467 * fileio.c (Finsert_file_contents):
4468 Likewise for BUF_BYTES_MAX.
4469
dd52fcea
PE
4470 * image.c: Use ptrdiff_t, not int, for sizes.
4471 (slurp_file): Switch from int to ptrdiff_t.
4472 All uses changed.
4473 (slurp_file): Check that file size fits in both size_t (for
4474 malloc) and ptrdiff_t (for sanity and safety).
4475
7f9bbdbb
PE
4476 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4477 if b->modtime has its maximal value.
4478
dfe18f82
PE
4479 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4480
84acfcf0
PE
4481 Don't assume time_t can fit into int.
4482 * buffer.h (struct buffer.modtime): Now time_t, not int.
4483 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4484 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4485
ccd9a01a
PE
4486 Minor fixes for signed vs unsigned integers.
4487 * character.h (MAYBE_UNIFY_CHAR):
4488 * charset.c (maybe_unify_char):
4489 * keyboard.c (read_char, reorder_modifiers):
4490 XINT -> XFASTINT, since the integer must be nonnegative.
4491 * ftfont.c (ftfont_spec_pattern):
4492 * keymap.c (access_keymap, silly_event_symbol_error):
4493 XUINT -> XFASTINT, since the integer must be nonnegative.
4494 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4495 since it makes no difference and we prefer signed.
4496 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4497 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4498 nonnegative.
4499
d6d100dd
SM
45002011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4501
4502 * window.h (Fwindow_frame): Declare.
4503
2b6148e4
PE
45042011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4505
4506 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4507 (SPARE_MEMORY): Always define.
4508 (LARGE_REQUEST): Remove.
4509 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4510
f230ecc9
MR
45112011-06-06 Martin Rudalics <rudalics@gmx.at>
4512
727e958e
MR
4513 * lisp.h: Move EXFUNS for Fframe_root_window,
4514 Fframe_first_window and Fset_frame_selected_window to window.h.
4515
4516 * window.h: Move EXFUNS for Fframe_root_window,
4517 Fframe_first_window and Fset_frame_selected_window here from
4518 lisp.h.
4519
4520 * frame.c (Fwindow_frame, Fframe_first_window)
4521 (Fframe_root_window, Fframe_selected_window)
4522 (Fset_frame_selected_window): Move to window.c.
4523 (Factive_minibuffer_window): Move to minibuf.c.
4524 (Fother_visible_frames_p): New function.
4525
4526 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4527
f230ecc9
MR
4528 * window.c (decode_window, decode_any_window): Move up in code.
4529 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4530 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4531 (Fwindow_buffer): Move up and rewrite doc-string.
4532 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4533 (Fwindow_prev): New functions.
727e958e
MR
4534 (Fwindow_frame): Move here from frame.c. Accept any window as
4535 argument.
4536 (Fframe_root_window, Fframe_first_window)
4537 (Fframe_selected_window): Move here from frame.c. Accept frame
4538 or arbitrary window as argument. Update doc-strings.
4539 (Fminibuffer_window): Move up in code.
4540 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4541 (Fset_frame_selected_window): Move here from frame.c.
4542 Marginal rewrite.
727e958e
MR
4543 (Fselected_window, select_window, Fselect_window): Move up in
4544 code. Minor doc-string fixes.
f230ecc9 4545
4d09bcf6
PE
45462011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4547
4548 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4549 Do not assume that spare memory exists; that assumption is valid
4550 only if SYSTEM_MALLOC.
4551 (LARGE_REQUEST): New macro, so that the issue of large requests
4552 is separated from the issue of spare memory.
4553
810928a2
AS
45542011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4555
172418ad
AS
4556 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4557 format. (Bug#8806)
4558
43f862f7
AS
4559 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4560
810928a2
AS
4561 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4562 before statements.
4563
a059fe24
JD
45642011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4565
4566 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4567
4568 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4569
4570 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4571 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4572
989bf368
JB
45732011-06-05 Juanma Barranquero <lekktu@gmail.com>
4574
4575 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4576
4b80f674
CY
45772011-06-04 Chong Yidong <cyd@stupidchicken.com>
4578
4579 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4580 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4581 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4582 New error handlers.
4b80f674
CY
4583 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4584 Obey Vx_select_enable_clipboard_manager. Catch errors in
4585 x_clipboard_manager_save (Bug#8779).
4586 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4587 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4588
99a33b77 45892011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4590
4591 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4592
99a33b77 45932011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4594
4595 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4596 in the current matrix if keep_current_p is non-zero.
4597
8264569d
EZ
45982011-06-04 Eli Zaretskii <eliz@gnu.org>
4599
4600 * bidi.c (bidi_level_of_next_char): Fix last change.
4601
57f97249
EZ
46022011-06-03 Eli Zaretskii <eliz@gnu.org>
4603
fec2107c 4604 Support bidi reordering of text covered by display properties.
57f97249 4605
fec2107c
EZ
4606 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4607 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4608 (bidi_cache_search, bidi_cache_iterator_state)
4609 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4610 (bidi_level_of_next_char, bidi_move_to_visually_next):
4611 Support character positions inside a run of characters covered by a
fec2107c
EZ
4612 display string.
4613 (bidi_paragraph_init, bidi_resolve_explicit_1)
4614 (bidi_level_of_next_char): Call bidi_fetch_char and
4615 bidi_fetch_char_advance instead of FETCH_CHAR and
4616 FETCH_CHAR_ADVANCE.
4617 (bidi_init_it): Initialize new members.
4618 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4619 definitions.
4620 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4621 instead of using explicit *_CHAR codes.
d6d100dd
SM
4622 (bidi_resolve_explicit, bidi_resolve_weak):
4623 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4624 bidirectional text is supported only in multibyte buffers.
4625 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4626 it to initialize the frame_window_p member of struct bidi_it.
4627 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4628 (bidi_resolve_explicit, bidi_resolve_weak)
4629 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4630 bidi_it->nchars is non-positive.
4631 (bidi_level_of_next_char): Don't try to lookup the cache for the
4632 next/previous character if nothing is cached there yet, or if we
4633 were just reseat()'ed to a new position.
c40e2fb2 4634
0e14fe90
EZ
4635 * xdisp.c (set_cursor_from_row): Set start and stop points
4636 according to the row's direction when priming the loop that looks
4637 for the glyph on which to display cursor.
4638 (single_display_spec_intangible_p): Function deleted.
4639 (display_prop_intangible_p): Reimplement to call
4640 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4641 Accept 3 additional arguments needed by handle_display_spec.
4642 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4643 values: lists, `(when COND...)' forms, etc.
4644 (single_display_spec_string_p): Support property values that are
4645 lists with the argument STRING its top-level element.
4646 (display_prop_string_p): Fix the condition for processing a
4647 property that is a list to be consistent with handle_display_spec.
fec2107c 4648 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4649 last portion of handle_display_prop.
4650 (compute_display_string_pos): Accept additional argument
4651 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4652 value of a `display' property is a "replacing spec".
4653 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4654 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4655 the display property, but just return a value indicating whether
4656 the display property will replace the characters it covers.
4657 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4658 frame_window_p members of struct bidi_it.
d6d100dd
SM
4659 (compute_display_string_pos, compute_display_string_end):
4660 New functions.
fec2107c
EZ
4661 (push_it): Accept second argument POSITION, where pop_it should
4662 jump to continue iteration.
4663 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4664
fec2107c
EZ
4665 * keyboard.c (adjust_point_for_property): Adjust the call to
4666 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4667
4668 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4669 (bidi_init_it): Update prototypes.
4670 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4671 (compute_display_string_pos, compute_display_string_end):
4672 Declare prototypes.
fec2107c
EZ
4673 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4674 EMACS_INT.
fc6f18ce 4675
40087514 46762011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4677
57f53182
PE
4678 Malloc failure behavior now depends on size of allocation.
4679 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4680 * lisp.h: Change signatures accordingly.
4681 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4682 All callers changed. (Bug#8762)
4683
4684 * gnutls.c: Use Emacs's memory allocators.
4685 Without this change, the gnutls library would invoke malloc etc.
4686 directly, which causes problems on non-SYNC_INPUT hosts, and which
4687 runs afoul of improving memory_full behavior. (Bug#8761)
4688 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4689 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4690 xfree instead of the default malloc, realloc, free.
4691 (Fgnutls_boot): No need to check for memory allocation failure,
4692 since xmalloc does that for us.
4693
ac32cd99 4694 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4695 * category.c (hash_get_category_set):
4696 * ccl.c (ccl_driver):
4697 * charset.c (Fdefine_charset_internal):
4698 * charset.h (struct charset.hash_index):
4699 * composite.c (get_composition_id, gstring_lookup_cache)
4700 (composition_gstring_put_cache):
4701 * composite.h (struct composition.hash_index):
4702 * dispextern.h (struct image.hash):
4703 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4704 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4705 (hashfn_equal, hashfn_user_defined, make_hash_table)
4706 (maybe_resize_hash_table, hash_lookup, hash_put)
4707 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4708 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4709 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4710 * image.c (make_image, search_image_cache, lookup_image)
4711 (xpm_put_color_table_h):
4712 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4713 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4714 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4715 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4716 * alloc.c (allocate_vectorlike):
4717 Check for overflow in vector size calculations.
4718 * ccl.c (ccl_driver):
4719 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4720 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4721 need to be updated by these changes.
40087514
PE
4722 * fns.c (make_hash_table, maybe_resize_hash_table):
4723 Check for integer overflow with large hash tables.
0de4bb68
PE
4724 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4725 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4726 (SXHASH_REDUCE): New macro.
4727 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4728 Use it instead of discarding useful hash info with large hash values.
4729 (sxhash_float): New function.
4730 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4731 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4732 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4733 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4734 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4735 Adjust signatures to match updated version of code.
4736 (consing_since_gc): Now EMACS_INT, since a single hash table can
4737 use more than INT_MAX bytes.
4738
698d32e2
DN
47392011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4740
4741 Make it possible to build with GCC-4.6+ -O2 -flto.
4742
4743 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4744
fd6fa53f
SM
47452011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4746
4747 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4748 Call minibuffer-inactive-mode.
4749
864db017
JB
47502011-05-31 Juanma Barranquero <lekktu@gmail.com>
4751
4752 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4753 Update dependencies.
4754
2ad0baf4
DN
47552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4756
4757 * data.c (init_data): Remove code for UTS, this system is not
4758 supported anymore.
4759
4fcc2638
DN
47602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4761
4762 Don't force ./temacs to start in terminal mode.
4763
4764 * frame.c (make_initial_frame): Initialize faces in all cases, not
4765 only when CANNOT_DUMP is defined.
4766 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4767
c56e0fd5
DN
47682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4769
4770 * dispnew.c (add_window_display_history): Use const for the string
4771 pointer. Remove declaration, not needed.
4772
333d54da 47732011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4774
55d4c1b2 4775 Use 'inline', not 'INLINE'.
333d54da 4776 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4777 * alloc.c, fontset.c (INLINE): Remove.
4778 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4779 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4780 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4781 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4782 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4783
738db178
DN
47842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4785
4786 Make it possible to run ./temacs.
4787
4788 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4789 syms_of_callproc does the same thing. Remove test for
4790 "initialized", do it in the caller.
4791 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4792
620c53a6
SM
47932011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4794
4795 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4796 (read_minibuf): Use get_minibuffer.
4797 (syms_of_minibuf): Use DEFSYM.
4798 (Qmetadata): New var.
4799 * data.c (Qbuffer): Don't make it static.
4800 (syms_of_data): Use DEFSYM.
4801
e003a292
PE
48022011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4803
4804 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4805 (CCL_CODE_MIN): New macro.
4806
ed008a6d
PE
48072011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4808
3687c2ef
PE
4809 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4810
ed008a6d
PE
4811 * eval.c (Qdebug): Now static.
4812 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4813 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4814 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4815
d66c4c7c
CY
48162011-05-29 Chong Yidong <cyd@stupidchicken.com>
4817
4818 * image.c: Various fixes to ImageMagick code comments.
4819 (Fimagemagick_types): Doc fix.
4820
5fbc2025
PE
48212011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4822
0196f88a
PE
4823 Minor fixes prompted by GCC 4.6.0 warnings.
4824
4825 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4826
5fbc2025
PE
4827 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4828 (x_clipboard_manager_save_all): Move extern decl to ...
4829 * xterm.h: ... here, so that it can be checked for consistency.
4830
1dd3c2d9
CY
48312011-05-29 Chong Yidong <cyd@stupidchicken.com>
4832
4833 * xselect.c (x_clipboard_manager_save_frame)
4834 (x_clipboard_manager_save_all): New functions.
4835 (Fx_clipboard_manager_save): Lisp function deleted.
4836
4837 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4838 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4839
4840 * xterm.h: Update prototype.
4841
5ba6571d
WX
48422011-05-28 William Xu <william.xwl@gmail.com>
4843
4844 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4845 exiting (Bug#8239).
4846
3eaff834
JM
48472011-05-28 Jim Meyering <meyering@redhat.com>
4848
e1900994 4849 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4850 * fns.c (to_uchar): Define.
4851 (crypto_hash_function): Use it to convert some newly-signed
4852 variables to unsigned, to avoid sign-extension bugs. For example,
4853 without this change, (md5 "truc") would evaluate to
4854 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4855 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4856 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4857
0f6990a7
PE
48582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4859
4860 Integer overflow fixes.
c8a9ca5a 4861
08686060
PE
4862 * dbusbind.c: Serial number integer overflow fixes.
4863 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4864 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4865 to hold a serial number that is too large for a fixnum.
4866 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4867 Check for serial numbers out of range. Decode any serial number
59568bf0 4868 that was so large that it became a float. (Bug#8722)
08686060 4869
2d1fc3c7
PE
4870 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4871 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4872 Use XFASTINT rather than XUINT when numbers are nonnegative.
4873 (xd_append_arg, Fdbus_method_return_internal):
4874 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4875 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4876 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4877 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4878 (Bug#8722)
2d1fc3c7 4879
c8a9ca5a
PE
4880 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4881
519e1d69
PE
4882 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4883
30569699
PE
4884 ccl: add integer overflow checks
4885 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4886 (IN_INT_RANGE): New macros.
4887 (ccl_driver): Use them to check for integer overflow when
4888 decoding a CCL program. Many of the new checks are whether XINT (x)
4889 fits in int; it doesn't always, on 64-bit hosts. The new version
4890 doesn't catch all possible integer overflows, but it's an
847044ea 4891 improvement. (Bug#8719)
30569699 4892
c11285dc
PE
4893 * alloc.c (make_event_array): Use XINT, not XUINT.
4894 There's no need for unsigned here.
4895
fdccd48e
PE
4896 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4897 This follows up to the 2011-05-06 change that substituted uintptr_t
4898 for EMACS_INT. This case wasn't caught back then.
4899
37910ab2
PE
4900 Rework Fformat to avoid integer overflow issues.
4901 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4902 now (part of C89). Include <verify.h>.
4903 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4904 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4905 (Fformat): Avoid the prepass trying to compute sizes; it was only
4906 approximate and thus did not catch overflow reliably. Instead, walk
4907 through the format just once, formatting and computing sizes as we go,
4908 checking for integer overflow at every step, and allocating a larger
4909 buffer as needed. Keep track separately whether the format is
4910 multibyte. Keep only the most-recently calculated precision, rather
4911 than them all. Record whether each argument has been converted to
4912 string. Use EMACS_INT, not int, for byte and char and arg counts.
4913 Support field widths and precisions larger than INT_MAX. Avoid
4914 sprintf's undefined behavior with conversion specifications such as %#d
4915 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4916 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4917 formatting out-of-range floating point numbers with int
9173deec 4918 formats. (Bug#8668)
37910ab2 4919
2e6578fb
PE
4920 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4921
0ae6bdee
PE
4922 * data.c: Avoid integer truncation in expressions involving floats.
4923 * data.c: Include <intprops.h>.
4924 (arith_driver): When there's an integer overflow in an expression
4925 involving floating point, convert the integers to floating point
4926 so that the resulting value does not suffer from catastrophic
4927 integer truncation. For example, on a 64-bit host (* 4
4928 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4929 Do not rely on undefined behavior after integer overflow.
4930
de883a70
PE
4931 merge count_size_as_multibyte, parse_str_to_multibyte
4932 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4933 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4934 Check for integer overflow.
4935 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4936 since it's now a duplicate of the other. This is more of
4937 a character than a buffer op, so better that it's in character.c.
4938 * fns.c, print.c: Adjust to above changes.
4939
2ff916cb
PE
49402011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4941
4942 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4943
f1b54466
PE
49442011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4945
fb1ac845
PE
4946 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4947 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4948 (x_clipboard_manager_save): Now static.
4949 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4950
f1b54466
PE
4951 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4952 (crypto_hash_function): Now static.
4953 Fix pointer signedness problems. Avoid unnecessary initializations.
4954
a9f737ee
CY
49552011-05-27 Chong Yidong <cyd@stupidchicken.com>
4956
4957 * termhooks.h (Vselection_alist): Make it terminal-local.
4958
4959 * terminal.c (create_terminal): Initialize it.
4960
4961 * xselect.c: Support for clipboard managers.
4962 (Vselection_alist): Move to termhooks.h as terminal-local var.
4963 (LOCAL_SELECTION): New macro.
4964 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4965 (symbol_to_x_atom): Remove gratuitous arg.
4966 (x_handle_selection_request, lisp_data_to_selection_data)
4967 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4968 (x_own_selection, x_get_local_selection, x_convert_selection):
4969 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4970 (some_frame_on_display): Delete unused function.
4971 (Fx_own_selection_internal, Fx_get_selection_internal)
4972 (Fx_disown_selection_internal, Fx_selection_owner_p)
4973 (Fx_selection_exists_p): New optional frame arg.
4974 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4975 (x_handle_selection_clear): Don't treat other terminals with the
4976 same keyboard specially. Use the terminal-local Vselection_alist.
4977 (x_clear_frame_selections): Use Frun_hook_with_args.
4978
4979 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4980
4981 * xterm.h: Add support for those atoms.
4982
e067f0c1
CY
49832011-05-26 Chong Yidong <cyd@stupidchicken.com>
4984
4985 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4986 (converted_selections, conversion_fail_tag): New global variables.
4987 (x_selection_request_lisp_error): Free the above.
4988 (x_get_local_selection): Remove unnecessary code.
4989 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4990 of converted selections stored in converted_selections.
4991 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4992 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4993 (x_convert_selection): New function.
4994 (x_handle_selection_event): Simplify.
4995 (x_get_foreign_selection): Don't ignore incoming requests while
4996 waiting for an answer; this will fail when we implement
4997 SAVE_TARGETS, and seems unnecessary anyway.
4998 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4999 (Vx_sent_selection_functions): Doc fix.
5000
0f4aebc0
LL
50012011-05-26 Leo Liu <sdl.web@gmail.com>
5002
5003 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5004
e61124cd
YM
50052011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5006
5007 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5008
5009 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5010 for fringe update if it has periodic bitmap.
ac389d0c 5011 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5012 and fringe_bitmap_periodic_p.
5013
5014 * fringe.c (get_fringe_bitmap_data): New function.
5015 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5016 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5017 row. Mark glyph row for fringe update if periodicity changed.
5018
5019 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5020 for fringe update unless it has periodic bitmap.
5021
f16d9837
KH
50222011-05-25 Kenichi Handa <handa@m17n.org>
5023
5024 * xdisp.c (get_next_display_element): Set correct it->face_id for
5025 a static composition.
5026
e1b90ef6
LL
50272011-05-24 Leo Liu <sdl.web@gmail.com>
5028
5029 * deps.mk (fns.o):
5030 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5031
5032 * fns.c (crypto_hash_function, Fsha1): New function.
5033 (Fmd5): Use crypto_hash_function.
5034 (syms_of_fns): Add Ssha1.
5035
7400048f
PE
50362011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5037
5038 * gnutls.c: Remove unused macros.
5039 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5040 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5041 Remove macros that are defined and never used.
5042 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5043
abb71cf4
CY
50442011-05-22 Chong Yidong <cyd@stupidchicken.com>
5045
5046 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5047 (Fx_get_selection_internal): Minor cleanup.
5048 (Fx_own_selection_internal): Rename arguments for consistency with
5049 select.el.
5050
6307db39
PE
50512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5052
5053 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5054
f3d4e0a4
CY
50552011-05-22 Chong Yidong <cyd@stupidchicken.com>
5056
5057 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5058
4d8ade89
YM
50592011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5060
5061 * dispnew.c (scrolling_window): Don't exclude the case that the
5062 last enabled row in the desired matrix touches the bottom boundary.
5063
32078c8d
GM
50642011-05-21 Glenn Morris <rgm@gnu.org>
5065
5066 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5067 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5068 and add some more files.
32078c8d 5069
7285dc67
EZ
50702011-05-20 Eli Zaretskii <eliz@gnu.org>
5071
5072 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5073 report_file_error introduced by the change from 2011-05-07.
5074
89d1bd22
PE
50752011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5076
5077 * systime.h (Time): Define only if emacs is defined.
5078 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5079 where the include path doesn't have X11/X.h by default. See
5080 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5081
e23640bb 50822011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5083
5084 * composite.c (find_automatic_composition): Fix previous change.
5085
b9704ad9
GM
50862011-05-20 Glenn Morris <rgm@gnu.org>
5087
5088 * lisp.mk: New file, split from Makefile.in.
5089 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5090 (shortlisp): Remove.
5091 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5092
4a720484
GM
50932011-05-19 Glenn Morris <rgm@gnu.org>
5094
5095 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5096 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5097 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5098 (lisp): Set the order to that of loadup.el.
5099 (shortlisp): Make it a copy of $lisp.
5100 (SOME_MACHINE_LISP): Remove.
5101 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5102 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5103
a28d4396
KH
51042011-05-18 Kenichi Handa <handa@m17n.org>
5105
5106 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5107 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5108 (find_automatic_composition): Mostly rewrite for efficiency.
5109
a2b1fa8e
JB
51102011-05-18 Juanma Barranquero <lekktu@gmail.com>
5111
5112 * makefile.w32-in: Update dependencies.
5113
8e1f5610
CS
51142011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5115
5116 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5117 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5118
7025ee00 51192011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5120
cdfa6eab
PE
5121 Fix some integer overflow issues, such as string length overflow.
5122
06d6db33
PE
5123 * insdel.c (count_size_as_multibyte): Check for string overflow.
5124
2b4560a8
PE
5125 * character.c (lisp_string_width): Check for string overflow.
5126 Use EMACS_INT, not int, for string indexes and lengths; in
5127 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5128 the resulting string length overflows an EMACS_INT; instead,
5129 report a string overflow if no precision given. When checking for
5130 precision exhaustion, use a check that cannot possibly have
5131 integer overflow. (Bug#8675)
5132 * character.h (lisp_string_width): Adjust to new signature.
5133
cb93f9be
PE
5134 * alloc.c (string_overflow): New function.
5135 (Fmake_string): Use it. This doesn't change behavior, but saves
5136 a few bytes and will simplify future changes.
5137 * character.c (string_escape_byte8): Likewise.
5138 * lisp.h (string_overflow): New decl.
5139
1a1f3366
PE
5140 Fixups, following up to the user-interface timestamp change.
5141 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5142 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5143 * msdos.c (mouse_get_pos): Likewise.
5144 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5145 * w32gui.h (Time): Define by including "systime.h" rather than by
5146 declaring it ourselves. (Bug#8664)
5147
d4e3e4d3
PE
5148 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5149 * image.c (clear_image_cache): Likewise.
5150
f6a24d19
PE
5151 * term.c (term_mouse_position): Don't assume time_t wraparound.
5152
08dc5ae6
PE
5153 Be more systematic about user-interface timestamps.
5154 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5155 and sometimes 'EMACS_UINT', to represent these timestamps.
5156 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5157 This makes the code easier to follow, and makes it easier to catch
5158 integer overflow bugs such as Bug#8664.
5159 * frame.c (Fmouse_position, Fmouse_pixel_position):
5160 Use Time, not unsigned long, for user-interface timestamps.
5161 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5162 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5163 * keyboard.h (last_event_timestamp): Likewise.
5164 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5165 * menu.h (xmenu_show): Likewise.
5166 * term.c (term_mouse_position): Likewise.
5167 * termhooks.h (struct input_event.timestamp): Likewise.
5168 (struct terminal.mouse_position_hook): Likewise.
5169 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5170 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5171 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5172 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5173 what it was before.
5174 * menu.h, termhooks.h: Include "systime.h", for Time.
5175
8e55734a
PE
5176 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5177 Don't assume that the difference between two unsigned long values
5178 can fit into an integer. At this point, we know button_down_time
5179 <= event->timestamp, so the difference must be nonnegative, so
5180 there's no need to cast the result if double-click-time is
5181 nonnegative, as it should be; check that it's nonnegative, just in
5182 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5183 apart (about 25 days). (Bug#8664)
8e55734a 5184
841f1b75 5185 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5186 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5187
3e26f69c
PE
5188 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5189 that always fit in int. Use a sentinel instead of a counter, to
5190 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5191 * frame.h (struct frame): Use int for menu_bar_items_used
5192 instead of EMACS_INT, since it always fits in int.
3e26f69c 5193
5cc152c0
PE
5194 * menu.c (grow_menu_items): Check for int overflow.
5195
d89eb65e
PE
5196 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5197
5235bd3e
PE
5198 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5199 Before, the code was not consistent. These values cannot exceed
5200 2**31 - 1 so there's no need to make them unsigned.
5201 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5202 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5203 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5204 as modifiers.
5205 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5206
bc827e23
PE
5207 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5208 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5209 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5210 presumably because the widths might not match.
5211
78eb494e
PE
5212 * window.c (size_window): Avoid needless test at loop start.
5213
04f2d78b
CB
52142011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5215
5216 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5217
d2fc7e3d 52182011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5219
5220 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5221
d2fc7e3d 52222011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5223
5224 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5225 `width' to `bar_area_x' and `bar_area_width', respectively.
5226 (x_scroll_run): Take account of fringe background extension.
5227
04f2d78b
CB
5228 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5229 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5230 `bar_area_width', respectively.
5231 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5232 background extension.
5233
79b70037
GM
52342011-05-10 Jim Meyering <meyering@redhat.com>
5235
5236 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5237
2f142cc5
JB
52382011-05-10 Juanma Barranquero <lekktu@gmail.com>
5239
5240 * image.c (Finit_image_library): Return t for built-in image types,
5241 like pbm and xbm. (Bug#8640)
5242
57679c86
AS
52432011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5244
5245 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5246
888c9e86
EZ
52472011-05-07 Eli Zaretskii <eliz@gnu.org>
5248
b0512a1d
EZ
5249 * w32console.c (Fset_screen_color): Doc fix.
5250 (Fget_screen_color): New function.
5251 (syms_of_ntterm): Defsubr it.
5252
7285dc67
EZ
5253 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5254 unlink the temporary file if Fcall_process didn't create it in the
5255 first place.
5256 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5257 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5258 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5259 cue to call_process_cleanup not to close that handle.
5260
4d3fcc8e
BK
52612011-05-07 Ben Key <bkey76@gmail.com>
5262
5263 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5264 one of two shell specific rules, either bootstrap-temacs-CMD or
5265 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5266 to the previous implementation of the bootstrap-temacs rule.
5267 The bootstrap-temacs-CMD rule is similar to the previous
5268 implementation of the bootstrap-temacs rule except that it
5269 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5270 variable.
5271
5272 These changes, along with some changes to nt/configure.bat,
5273 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5274 earlier fix to add support for --cflags and --ldflags options
5275 that include quotes so that it works whether make uses cmd or
5276 sh as the shell.
5277
b4289b64
MA
52782011-05-06 Michael Albinus <michael.albinus@gmx.de>
5279
5280 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5281 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5282 is a constant.
5283 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5284 a string. Handle both cases.
5285 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5286 (Fdbus_register_method): Use Qinvalid_function.
5287
af4c0e28
JB
52882011-05-06 Juanma Barranquero <lekktu@gmail.com>
5289
5290 * makefile.w32-in: Update dependencies.
5291 (LISP_H): Add inttypes.h and stdin.h.
5292 (PROCESS_H): Add unistd.h.
5293
c51453d9
EZ
52942011-05-06 Eli Zaretskii <eliz@gnu.org>
5295
5296 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5297 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5298
8ff0ac3c 52992011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5300
4c4b566b
PE
5301 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5302
aab2b9b5
PE
5303 * term.c (vfatal): Remove stray call to va_end.
5304 It's not needed and the C Standard doesn't allow it here anyway.
5305
c378da0b
PE
5306 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5307 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5308
288b08c7
PE
5309 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5310 bytes.
5311
e3601888
PE
5312 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5313
db6c0e74
PE
5314 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5315
dd5963ea
PE
5316 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5317
88c9450f
PE
5318 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5319
2f9442b8
PE
5320 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5321
c032b5f8
PE
5322 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5323 * charset.c (Fdefine_charset_internal): Don't initialize
5324 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5325 32-bit int (Bug#8600).
a108c10b
PE
5326
5327 * lread.c (read_integer): Be more consistent with string-to-number.
5328 Use string_to_number to do the actual conversion; this avoids
5329 rounding errors and fixes some other screwups. Without this fix,
5330 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5331 (digit_to_number): Move earlier, for benefit of read_integer.
5332 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5333 not a digit in any supported base. (Bug#8602)
a108c10b 5334
ad5f9eea
PE
5335 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5336
aec1708a
PE
5337 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5338 to match comment at start of function. This also removes a
5339 GCC warning about overflow in a 32+64-bit port.
5340
47be4ab5
PE
5341 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5342
371cac43
PE
5343 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5344 Reported by Stefan Monnier in
5345 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5346 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5347 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5348
d01a7826
PE
5349 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5350 (EMACS_UINTPTR): Likewise, with uintptr_t.
5351
7fd47d5c
PE
5352 * lisp.h: Prefer 64-bit EMACS_INT if available.
5353 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5354 on 32-bit hosts that have 64-bit int, so that they can access
5355 large files.
122b0c86
PE
5356 However, temporarily disable this change unless the temporary
5357 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5358
8727937b
PE
5359 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5360
8ac068ac
PE
5361 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5362 This removes an assumption that EMACS_INT and long are the same
5363 width as pointers. The assumption is true for Emacs porting targets
5364 now, but we want to make other targets possible.
5365 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5366 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5367 In the rest of the code, change types of integers that hold casted
5368 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5369 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5370 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5371 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5372 No need to cast type when ORing.
5373 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5374 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5375 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5376 assume EMACS_INT is the same width as char *.
5377 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5378 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5379 Remove no-longer-needed casts.
5380 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5381 (xg_tool_bar_help_callback, xg_make_tool_item):
5382 Use EMACS_INTPTR to hold an integer
5383 that will be cast to void *; this can avoid a GCC warning
5384 if EMACS_INT is not the same width as void *.
5385 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5386 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5387 (current_message_1, set_message_1):
5388 Use a local to convert to proper width without a cast.
5389 * xmenu.c (dialog_selection_callback): Likewise.
5390
ede49d71
PE
5391 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5392 Also, don't assume VALBITS / RAND_BITS is less than 5,
5393 and don't rely on undefined behavior when shifting a 1 left into
5394 the sign bit.
5395 * lisp.h (get_random): Change signature to match.
5396
2f30ecd0
PE
5397 * lread.c (hash_string): Use size_t, not int, for hash computation.
5398 Normally we prefer signed values; but hashing is special, because
5399 it's better to use unsigned division on hash table sizes so that
5400 the remainder is nonnegative. Also, size_t is the natural width
5401 for hashing into memory. The previous code used 'int', which doesn't
5402 retain enough info to hash well into very large tables.
5403 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5404
2a866e7b
PE
5405 * dbusbind.c: Don't possibly lose pointer info when converting.
5406 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5407 Use XPNTR rather than XHASH, so that the high-order bits of
5408 the pointer aren't lost when converting through void *.
5409
51639eac
PE
5410 * eval.c (Fautoload): Don't double-shift a pointer.
5411
92394119
PE
5412 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5413
dbdb9a7c
JB
54142011-05-06 Juanma Barranquero <lekktu@gmail.com>
5415
5416 * gnutls.c (DEF_GNUTLS_FN):
5417 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5418
db7a0b4f
AS
54192011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5420
5421 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5422 marker. (Bug#8610)
5423
f7ff1b0f 54242011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5425
5426 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5427 New version that can reserve upto 2GB of heap space.
5428
f7ff1b0f 54292011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5430
5431 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5432
639c109b
TZ
54332011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5434
5435 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5436 `gnutls_certificate_set_x509_key_file'.
5437
d2127135
JB
54382011-05-05 Juanma Barranquero <lekktu@gmail.com>
5439
5440 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5441 Update dependencies.
5442
e968f4f3
JB
54432011-05-04 Juanma Barranquero <lekktu@gmail.com>
5444
5445 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5446 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5447 Remove unused parameter `fildes'.
5448 * process.c (read_process_output, send_process): Don't pass it.
5449
84d358f0
JB
54502011-05-04 Juanma Barranquero <lekktu@gmail.com>
5451
5452 Fix previous change: the library cache is defined in w32.c.
5453 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5454 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5455
0898ca10
JB
54562011-05-04 Juanma Barranquero <lekktu@gmail.com>
5457
5458 Implement dynamic loading of GnuTLS on Windows.
5459
5460 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5461 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5462 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5463 Declare.
5464
5465 * gnutls.c (Qgnutls_dll): Define.
5466 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5467 (gnutls_*): Declare function pointers.
5468 (init_gnutls_functions): New function to initialize function pointers.
5469 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5470 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5471 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5472 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5473 (emacs_gnutls_write, emacs_gnutls_read)
5474 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5475 (Fgnutls_available_p): New function.
5476 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5477 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5478 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5479
5480 * image.c: Include w32.h.
5481 (Vimage_type_cache): Delete.
5482 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5483 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5484 (w32_delayed_load): Move to w32.c.
5485
5486 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5487
5488 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5489 (w32_delayed_load): Move from image.c. When loading a library, record
5490 its filename in the :loaded-from property of the library id.
5491 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5492 Initialize and staticpro them.
5493 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5494
5495 * process.c: Include lisp.h before w32.h, not after.
5496 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5497 instead of gnutls_record_check_pending.
5498
5499 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5500
ff4de4aa
TZ
55012011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5502
5503 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5504 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5505 as passed in.
5506
abe95abb
JD
55072011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5508
5509 * xterm.c (x_set_frame_alpha): Do not set property on anything
5510 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5511
e16e55d4
JB
55122011-05-02 Juanma Barranquero <lekktu@gmail.com>
5513
5514 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5515
bafcf6a5
JB
55162011-05-02 Juanma Barranquero <lekktu@gmail.com>
5517
5518 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5519 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5520 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5521 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5522 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5523 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5524 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5525 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5526 (Qgnutls_bootprop_callbacks_verify): Make static.
5527
e7a6747f
AS
55282011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5529
19ed11ba
AS
5530 * callproc.c: Indentation fixup.
5531
e7a6747f 5532 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5533 (wait_for_termination, interruptible_wait_for_termination):
5534 Move after wait_for_termination_1.
e7a6747f 5535
1ef14cb4
LMI
55362011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5537
5538 * sysdep.c (interruptible_wait_for_termination): New function
5539 which is like wait_for_termination, but allows keyboard
5540 interruptions.
5541
5542 * callproc.c (Fcall_process): Add (:file "file") as an option for
5543 the STDOUT buffer.
5544 (Fcall_process_region): Ditto.
5545
330d880c
EZ
55462011-04-30 Eli Zaretskii <eliz@gnu.org>
5547
8db90b73
EZ
5548 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5549 rather than `XVECTOR (FOO)->size'.
5550
330d880c
EZ
5551 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5552 inttypes.h, as a gnulib replacement is used if it not available in
5553 system headers.
5554
15cbd324
EZ
55552011-04-21 Eli Zaretskii <eliz@gnu.org>
5556
5557 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5558 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5559 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5560
5561 * coding.c (coding_alloc_by_realloc): Error out if destination
5562 will grow beyond MOST_POSITIVE_FIXNUM.
5563 (decode_coding_emacs_mule): Abort if there isn't enough place in
5564 charbuf for the composition carryover bytes. Reserve an extra
5565 space for up to 2 characters produced in a loop.
5566 (decode_coding_iso_2022): Abort if there isn't enough place in
5567 charbuf for the composition carryover bytes.
5568
55692011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5570
ae940cca
EZ
5571 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5572 aborting when %lld or %lll format is passed.
5573 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5574 %llo or %llx format is passed. (Bug#8545)
5575
03ab8921
EZ
5576 * window.c (window_scroll_line_based): Use a marker instead of
5577 simple variables to record original value of point. (Bug#7952)
5578
afda1437
EZ
5579 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5580 produced by %s or %c overflows available buffer space. (Bug#8545)
5581
f76dee0c
PE
55822011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5583
5584 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5585 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5586
fdc5744d
JB
55872011-04-28 Juanma Barranquero <lekktu@gmail.com>
5588
5589 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5590
638f053a
JB
55912011-04-28 Juanma Barranquero <lekktu@gmail.com>
5592
5593 * keyboard.c (Qdelayed_warnings_hook): Define.
5594 (command_loop_1): Run `delayed-warnings-hook'
5595 if Vdelayed_warnings_list is non-nil.
5596 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5597 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5598
d178f871
EZ
55992011-04-28 Eli Zaretskii <eliz@gnu.org>
5600
5601 * doprnt.c (doprnt): Don't return value smaller than the buffer
5602 size if the message was truncated. (Bug#8545).
5603
b124fd93
JB
56042011-04-28 Juanma Barranquero <lekktu@gmail.com>
5605
5606 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5607 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5608
e810457d
PE
56092011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5610
5611 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5612
ea51cceb
JB
56132011-04-27 Juanma Barranquero <lekktu@gmail.com>
5614
5615 * makefile.w32-in: Update dependencies.
5616
94dcfacf
EZ
56172011-04-27 Eli Zaretskii <eliz@gnu.org>
5618
5619 Improve `doprnt' and its usage. (Bug#8545)
5620 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5621 `format_end'. Remove support for %l as a conversion specifier.
5622 Don't use xrealloc. Improve diagnostics when the %l size modifier
5623 is used. Update the commentary.
5624
5625 * eval.c (verror): Simplify calculation of size_t.
5626
5627 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5628 messages.
5629
f61f41d7
PE
56302011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5631
5632 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5633 change.
5634
96fb4434
PE
56352011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5636
5637 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5638 This makes this file independent of the recent pseudovector change.
5639
671875da 56402011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5641
69e9b5a3
PE
5642 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5643
b5f869a7 5644 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5645 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5646 Remove unused local.
c8926152 5647 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5648
841a1577 5649 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5650 GCC 4.6.0 optimizes based on type-based alias analysis.
5651 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5652 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5653 != &v->size, and therefore "v->size = 1; b->size = 2; return
5654 v->size;" must therefore return 1. This assumption is incorrect
5655 for Emacs, since it type-puns struct Lisp_Vector * with many other
5656 types. To fix this problem, this patch adds a new type struct
f904488f 5657 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5658 and pseudovectors, and helps optimizing compilers not get fooled
5659 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5660 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5661 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5662 the size member.
eab3844f
PE
5663 (XSETPVECTYPE): Rewrite in terms of new macro.
5664 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5665 This is a bit clearer, and further avoids the possibility of
5666 undesirable aliasing.
5667 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5668 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5669 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5670 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5671 (ASIZE): Now uses header.size rather than size.
5672 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5673 to avoid the hassle of writing XVECTOR (foo)->header.size.
5674 (struct vectorlike_header): New type.
eab3844f
PE
5675 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5676 object, to help avoid aliasing.
5677 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5678 (SUBRP): Likewise, since Lisp_Subr is a special case.
5679 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5680 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5681 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5682 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5683 changed to be "header.size" and "header.next".
5684 * buffer.h (struct buffer): Likewise.
5685 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5686 * frame.h (struct frame): Likewise.
5687 * process.h (struct Lisp_Process): Likewise.
5688 * termhooks.h (struct terminal): Likewise.
5689 * window.c (struct save_window_data, struct saved_window): Likewise.
5690 * window.h (struct window): Likewise.
5691 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5692 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5693 * buffer.c (init_buffer_once): Likewise.
5694 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5695 special case.
5696 * process.c (Fformat_network_address): Use local var for size,
5697 for brevity.
5698
0df1eac5
PE
5699 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5700
847ab9d1 5701 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5702 * data.c (atof): Remove decl; no longer used or needed.
5703 (digit_to_number): Move to lread.c.
5704 (Fstring_to_number): Use new string_to_number function, to be
5705 consistent with how the Lisp reader treats infinities and NaNs.
5706 Do not assume that floating-point numbers represent EMACS_INT
5707 without losing information; this is not true on most 64-bit hosts.
5708 Avoid double-rounding errors, by insisting on integers when
5709 parsing non-base-10 numbers, as the documentation specifies.
5710 * lisp.h (string_to_number): New decl, replacing ...
5711 (isfloat_string): Remove.
bc0a5c13 5712 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5713 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5714 appears to have been a coding error. Similarly, do not accept
5715 strings like +-1e0 as floating point numbers. Do not report
5716 overflow for integer overflows unless the base is not 10 which
5717 means we have no simple and reliable way to continue.
5718 Break out the floating-point parsing into a new
5719 function string_to_number, so that Fstring_to_number parses
5720 floating point numbers consistently with the Lisp reader.
04f2d78b 5721 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5722 (E_CHAR, EXP_INT): Remove, replacing with ...
5723 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5724 (string_to_number): New function, replacing isfloat_string.
5725 This function checks for valid syntax and produces the resulting
5726 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5727 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5728 so that overflow for non-base-10 numbers is reported only when
5729 there's no portable and simple way to convert to floating point.
452f4150 5730
67769ffc
PE
5731 * textprop.c (set_text_properties_1): Rewrite for clarity,
5732 and to avoid GCC warning about integer overflow.
5733
c20db43f
PE
5734 * intervals.h (struct interval): Use EMACS_INT for members
5735 where EMACS_UINT might cause problems. See
5736 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5737 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5738 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5739 All uses changed.
37aa2f85
PE
5740 (offset_intervals): Tell GCC not to worry about length overflow
5741 when negating a negative length.
c20db43f 5742
2538aa2f
PE
5743 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5744 (overrun_check_free): Likewise.
5745
f2d3008d
PE
5746 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5747 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5748 word size.
5749
ec8df744
PE
5750 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5751 (gnutls_make_error): Rename local to avoid shadowing.
5752 (gnutls_emacs_global_deinit): ifdef out; not used.
5753 (Fgnutls_boot): Use const for pointer to readonly storage.
5754 Comment out unused local. Fix pointer signedness problems.
5755
640ee02d
PE
5756 * lread.c (openp): Don't stuff size_t into an 'int'.
5757 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5758 about possible signed overflow.
5759
6048fb2a
PE
5760 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5761 (GDK_KEY_g): Don't define if already defined.
5762 (xg_prepare_tooltip): Avoid pointer signedness problem.
5763 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5764
fa3c87e1
PE
5765 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5766 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5767
2172544b
PE
5768 * xfns.c (Fx_window_property): Simplify a bit,
5769 to make a bit faster and to avoid GCC 4.6.0 warning.
5770 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5771
9b821a21
PE
5772 * fns.c (internal_equal): Don't assume size_t fits in int.
5773
3c616cfa
PE
5774 * alloc.c (compact_small_strings): Tighten assertion a little.
5775
c2982e87
PE
5776 Replace pEd with more-general pI, and fix some printf arg casts.
5777 * lisp.h (pI): New macro, generalizing old pEd macro to other
5778 conversion specifiers. For example, use "...%"pI"d..." rather
5779 than "...%"pEd"...".
5780 (pEd): Remove. All uses replaced with similar uses of pI.
5781 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5782 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5783 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5784 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5785 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5786 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5787 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5788 64-bit hosts.
5789 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5790 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5791 * print.c (safe_debug_print, print_object): Likewise.
5792 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5793 to int.
6f04d126
PE
5794 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5795 avoiding the 0 flag, which is not portable.
c2982e87
PE
5796 * process.c (Fmake_network_process): Use pI to avoid cast.
5797 * region-cache.c (pp_cache): Likewise.
5798 * xdisp.c (decode_mode_spec): Likewise.
5799 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5800 behavior on 64-bit hosts with printf arg.
6f04d126 5801 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5802 (x_stop_queuing_selection_requests): Likewise.
5803 (x_get_window_property): Don't truncate byte count to an 'int'
5804 when tracing.
0b432f21 5805
5e073ec7
PE
5806 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5807 here, since it parses constructs like leading '-' and spaces,
5808 which are not wanted; and it overflows with large numbers.
5809 Instead, simply match F[0-9]+, which is what is wanted anyway.
5810
36372bf9
PE
5811 * alloc.c: Remove unportable assumptions about struct layout.
5812 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5813 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5814 (allocate_vectorlike, make_pure_vector): Use the new macros,
5815 plus offsetof, to remove unportable assumptions about struct layout.
5816 These assumptions hold on all porting targets that I know of, but
5817 they are not guaranteed, they're easy to remove, and removing them
5818 makes further changes easier.
5819
0b432f21
PE
5820 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5821 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5822 (string_overrun_cookie): Now const. Use initializers that
5823 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5824 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5825 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5826 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5827 multiple of sizeof (EMACS_INT); it need not be, if
5828 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5829 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5830
895009e1
JB
58312011-04-26 Juanma Barranquero <lekktu@gmail.com>
5832
5833 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5834
6a7a1b0b
TZ
58352011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5836
5837 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5838 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5839 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5840
841a1577 58412011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5842
5843 * lisp.h (Qdebug): List symbol.
895009e1 5844 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5845 * keyboard.c (debug-on-event): New variable.
5846 (handle_user_signal): Break into debugger when debug-on-event
5847 matches the current signal symbol.
5848
f2d3ba6f
DN
58492011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5850
5851 * alloc.c (check_sblock, check_string_bytes)
5852 (check_string_free_list): Convert to standard C.
5853
42ce4c63
TZ
58542011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5855
5856 * w32.c (emacs_gnutls_push): Fix typo.
5857
825cd63c
EZ
58582011-04-25 Eli Zaretskii <eliz@gnu.org>
5859
fb11d64d
EZ
5860 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5861 "cast to pointer from integer of different size".
5862
825cd63c
EZ
5863 Improve doprnt and its use in verror. (Bug#8545)
5864 * doprnt.c (doprnt): Document the set of format control sequences
5865 supported by the function. Use SAFE_ALLOCA instead of always
5866 using `alloca'.
5867
5868 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5869 is one byte too soon. Don't use xrealloc; instead xfree and
5870 xmalloc anew.
5871
e061a11b
TZ
58722011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5873
5874 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5875 callbacks stage.
5876
5877 * gnutls.c: Renamed global_initialized to
5878 gnutls_global_initialized. Added internals for the
5879 :verify-hostname-error, :verify-error, and :verify-flags
5880 parameters of `gnutls-boot' and documented those parameters in the
5881 docstring. Start callback support.
9173deec
JB
5882 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5883 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5884 on error. Return error code.
e061a11b
TZ
5885 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5886 (emacs_gnutls_read): Likewise.
5887 (Fgnutls_boot): Return handshake error code.
5888 (emacs_gnutls_handle_error): New function.
5889 (wsaerror_to_errno): Likewise.
5890
5891 * w32.h (emacs_gnutls_pull): Add prototype.
5892 (emacs_gnutls_push): Likewise.
5893
5894 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5895 (emacs_gnutls_push): Likewise.
5896
58972011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5898
5899 * process.c (wait_reading_process_output): Check if GnuTLS
5900 buffered some data internally if no FDs are set for TLS
5901 connections.
5902
5903 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5904 (LIBS): Link to USER_LIBS.
5905 ($(BLD)/gnutls.$(0)): New target.
5906
fa6996bc
EZ
59072011-04-24 Eli Zaretskii <eliz@gnu.org>
5908
eb35682e
EZ
5909 * xdisp.c (handle_single_display_spec): Rename the
5910 display_replaced_before_p argument into display_replaced_p, to
5911 make it consistent with the commentary. Fix typos in the
5912 commentary.
5913
e2ad650c
EZ
5914 * textprop.c (syms_of_textprop): Remove dead code.
5915 (copy_text_properties): Delete obsolete commentary about an
5916 interface that was deleted long ago. Fix typos in the description
5917 of arguments.
5918
1b2de274
EZ
5919 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5920 to changes in oldXMenu/XMenu.h from 2011-04-16.
5921 <menu_help_message, prev_menu_help_message>: Constify.
5922 (IT_menu_make_room): menu->help_text is now `const char **';
5923 adjust.
5924
5925 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5926 to changes in oldXMenu/XMenu.h from 2011-04-16.
5927 (struct XMenu): Declare `help_text' `const char **'.
5928
5929 * xfaces.c <Qunspecified>: Make extern again.
5930
5931 * syntax.c: Include sys/types.h before including regex.h, as
5932 required by Posix.
5933
762b15be
EZ
5934 * doc.c (get_doc_string): Improve the format passed to `error'.
5935
5936 * doprnt.c (doprnt): Improve commentary.
5937
5938 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5939
5940 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5941 them with etags.
5942
f1052e5d
EZ
5943 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5944 changes in globals.h immediately force recompilation.
762b15be
EZ
5945 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5946 $(CURDIR)/s/ms-w32.h.
5947 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5948
fa6996bc
EZ
5949 * character.c (Fchar_direction): Function deleted.
5950 (syms_of_character): Don't defsubr it.
5951 <char-direction-table>: Deleted.
5952
e6c3da20
EZ
59532011-04-23 Eli Zaretskii <eliz@gnu.org>
5954
5955 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5956 * doprnt.c: Include limits.h.
5957 (SIZE_MAX): New macro.
04f2d78b
CB
5958 (doprnt): Return a size_t value. 2nd arg is now size_t.
5959 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5960 Improve overflow protection. Support `l' modifier for integer
5961 conversions. Support %l conversion. Don't assume an EMACS_INT
5962 argument for integer conversions and for %c.
5963
5964 * lisp.h (doprnt): Restore prototype.
5965
5966 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5967 $(SRC)/character.h.
5968
5969 * Makefile.in (base_obj): Add back doprnt.o.
5970
5971 * deps.mk (doprnt.o): Add back prerequisites.
5972 (callint.o): Depend on character.h.
5973
5974 * eval.c (internal_lisp_condition_case): Include the handler
5975 representation in the error message.
5976 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5977 when breaking from the loop.
5978
5979 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5980
5981 * callint.c (Fcall_interactively): When displaying error message
5982 about invalid control letter, pass the character's codepoint, not
5983 a pointer to its multibyte form. Improve display of the character
5984 in octal and display also its hex code.
5985
5986 * character.c (char_string): Use %x to display the (unsigned)
5987 codepoint of an invalid character, to avoid displaying a bogus
5988 negative value.
5989
5990 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5991 `error', not SYMBOL_NAME itself.
5992
5993 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5994 character arguments to `error'.
5995
5996 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5997 to `error' in error message about FINAL_CHAR argument. Make sure
5998 FINAL_CHAR is a character, and use %c when it is passed as
5999 argument to `error'.
6000
4ffd0d6b 60012011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6002
6003 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6004
6005 * w32.c: Include <time.h>.
6006 (sys_localtime): New function.
6007
4ffd0d6b 60082011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6009
6010 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6011
4ffd0d6b 6012 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6013
4ffd0d6b 60142011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6015
4ffd0d6b
GM
6016 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6017 zombies (Bug#8467).
aac0c6e3 6018
04c56954
EZ
60192011-04-19 Eli Zaretskii <eliz@gnu.org>
6020
6021 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6022 gl_state.e_property when gl_state.object is Qt.
6023
6024 * insdel.c (make_gap_larger): Remove limitation of buffer size
6025 to <= INT_MAX.
6026
16a43933
CY
60272011-04-18 Chong Yidong <cyd@stupidchicken.com>
6028
6029 * xdisp.c (lookup_glyphless_char_display)
6030 (produce_glyphless_glyph): Handle cons cell entry in
6031 glyphless-char-display.
6032 (Vglyphless_char_display): Document it.
6033
6034 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6035 glyphless-char-display.
6036
4581706e
CY
60372011-04-17 Chong Yidong <cyd@stupidchicken.com>
6038
6039 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6040
6041 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6042
6043 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6044 definition for no-X builds.
6045
4887c6e2 60462011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6047
fd35b6f9
PE
6048 Static checks with GCC 4.6.0 and non-default toolkits.
6049
5c1ccb01
PE
6050 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6051
006c5daa
PE
6052 * process.c (keyboard_bit_set): Define only if SIGIO.
6053 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6054 (send_process): Repair possible setjmp clobbering.
6055
efc736d3
PE
6056 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6057
4e2fe2e6
PE
6058 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6059
f97334a2
PE
6060 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6061
4e75f29d
PE
6062 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6063 Define only if needed.
6064
90efadd1
PE
6065 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6066 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6067 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6068
3c647824
PE
6069 * dispextern.h (struct redisplay_interface): Rename param
6070 to avoid shadowing.
e264f262 6071 * termhooks.h (struct terminal): Likewise.
761383f4 6072 * xterm.c (xembed_send_message): Likewise.
3c647824 6073
b58c5c4a
PE
6074 * insdel.c (make_gap_smaller): Define only if
6075 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6076
cad59032
PE
6077 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6078 it.
6079
c339dc2e
PE
6080 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6081 so that we aren't warned about unused symbols.
6082
91a3e27b
PE
6083 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6084
399c71d3 6085 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6086
8ffc96f5
PE
6087 * xfns.c (x_real_positions): Mark locals as initialized.
6088
eef9bc79
PE
6089 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6090
098db9dd
PE
6091 * xterm.c: Fix problems found by static analysis with other toolkits.
6092 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6093 (x_dispatch_event): Declare static if USE_GTK, and
6094 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6095 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6096 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6097 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6098 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6099
eb18f6cc
PE
6100 * xmenu.c (menu_help_callback): Pointer type fixes.
6101 Use const pointers when pointing at readonly data. Avoid pointer
6102 signedness clashes.
6103 (FALSE): Remove unused macro.
6104 (update_frame_menubar): Remove unused decl.
6105
1fe72bf8
PE
6106 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6107
60d9e1db
PE
6108 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6109 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6110 (single_menu_item): Rename local to avoid shadowing.
6111
39261c26
PE
6112 * keyboard.c (make_lispy_event): Remove unused local var.
6113
018c5e19
PE
6114 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6115 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6116
63d2b86e
PE
6117 * bitmaps: Change bitmaps from unsigned char back to the X11
6118 compatible char. Avoid the old compiler warnings about
6119 out-of-range initializers by using, for example, '\xab' rather
6120 than 0xab.
6121
aefd87e1
PE
6122 * xgselect.c (xgselect_initialize): Check vs interface
6123 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6124
bf501fb9
PE
6125 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6126
e9829fdf
PE
6127 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6128 to read-only memory.
6129
1086c095
PE
6130 * fns.c (vector): Remove; this old hack is no longer needed.
6131
2baccd04 6132 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6133 Remove unused var.
dde42981 6134 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6135
72391843 6136 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6137
436c16df 6138 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6139 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6140 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6141
92bb796d 6142 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6143 (x_term_init): Remove local to avoid shadowing.
92bb796d 6144
764430a3 6145 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6146
6147 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6148 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6149
d1dfb56c
EZ
61502011-04-16 Eli Zaretskii <eliz@gnu.org>
6151
c4354cb4
EZ
6152 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6153
d1dfb56c
EZ
6154 Fix regex.c, syntax.c and friends for buffers > 2GB.
6155 * syntax.h (struct gl_state_s): Declare character position members
6156 EMACS_INT.
6157
6158 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6159
04f2d78b
CB
6160 * textprop.c (verify_interval_modification, interval_of):
6161 Declare arguments EMACS_INT.
d1dfb56c
EZ
6162
6163 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6164 EMACS_INT.
6165
6166 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6167
6168 * indent.c (Fvertical_motion): Local variable it_start is now
6169 EMACS_INT.
6170
6171 * regex.c (re_match, re_match_2, re_match_2_internal)
6172 (bcmp_translate, regcomp, regexec, print_double_string)
6173 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6174 (re_compile_pattern, re_exec): Declare arguments and local
6175 variables `size_t' and `ssize_t' and return values `regoff_t', as
6176 appropriate.
6177 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6178 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6179 <compile_stack_type>: `size' and `avail' are now `size_t'.
6180
6181 * regex.h <regoff_t>: Use ssize_t, not int.
6182 (re_search, re_search_2, re_match, re_match_2): Arguments that
6183 specify buffer/string position and length are now ssize_t and
6184 size_t. Return type is regoff_t.
6185
613052cd
BK
61862011-04-16 Ben Key <bkey76@gmail.com>
6187
6188 * nsfont.m: Fixed bugs in ns_get_family and
6189 ns_descriptor_to_entity that were caused by using free to
6190 deallocate memory blocks that were allocated by xmalloc (via
6191 xstrdup). This caused Emacs to crash when compiled with
6192 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6193 --enable-checking=xmallocoverrun). xfree is now used to
6194 deallocate these memory blocks.
6195
4170f62f 61962011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6197
71b41406
PE
6198 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6199
9587a89d
PE
6200 emacs_write: Accept and return EMACS_INT for sizes.
6201 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6202 et seq.
6203 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6204 Accept and return EMACS_INT.
6205 (emacs_gnutls_write): Return the number of bytes written on
6206 partial writes.
6207 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6208 (emacs_read, emacs_write): Remove check for negative size, as the
6209 Emacs source code has been audited now.
9587a89d
PE
6210 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6211 (emacs_read, emacs_write): Use it.
273a5f82
PE
6212 * process.c (send_process): Adjust to the new signatures of
6213 emacs_write and emacs_gnutls_write. Do not attempt to store
6214 a byte offset into an 'int'; it might overflow.
9587a89d 6215 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6216
3e047f51
PE
6217 * sound.c: Don't assume sizes fit in 'int'.
6218 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6219 Return EMACS_INT, not int.
3e047f51 6220 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6221 Accept EMACS_INT, not int.
6222 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6223 record read return values.
6224
cc39a9db
BK
62252011-04-15 Ben Key <bkey76@gmail.com>
6226
c9d0ec6d
JB
6227 * keyboard.c (Qundefined): Don't declare static since it is used
6228 in nsfns.m.
6229 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6230 static since they are used in nsfont.m.
cc39a9db 6231
6c60eb9f
SM
62322011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6233
6234 * process.c (Qprocessp): Don't declare static.
6235 * lisp.h (Qprocessp): Declare again.
6236
7990b61a
JB
62372011-04-15 Juanma Barranquero <lekktu@gmail.com>
6238
6239 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6240
5d4cb038
PE
62412011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6242
8bd7b830 6243 Improve C-level modularity by making more things 'static'.
cd64ea1d 6244
e3b27b31
PE
6245 Don't publish debugger-only interfaces to other modules.
6246 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6247 (verify_bytepos, count_markers): Move decls to the only modules
6248 that need them.
6249 * region-cache.h (pp_cache): Likewise.
6250 * window.h (check_all_windows): Likewise.
6251 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6252
5d4cb038
PE
6253 * sysdep.c (croak): Now static, if
6254 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6255 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6256
6257 * alloc.c (refill_memory_reserve): Now static if
6258 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6259 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6260
e87b6180
PE
6261 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6262 Define only if USE_LUCID.
6263
ac64929e
PE
6264 * xrdb.c (x_customization_string, x_rm_string): Now static.
6265
6f37259d
PE
6266 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6267 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6268
1683e3ab
PE
6269 * xdisp.c (draw_row_with_mouse_face): Now static.
6270 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6271
de9c2632
PE
6272 * window.h (check_all_windows): Mark externally visible.
6273
2b96acb7
PE
6274 * window.c (window_deletion_count): Now static.
6275
6276 * undo.c: Make symbols static if they're not exported.
6277 (last_undo_buffer, last_boundary_position, pending_boundary):
6278 Now static.
6279
50436f33
PE
6280 * textprop.c (interval_insert_behind_hooks): Now static.
6281 (interval_insert_in_front_hooks): Likewise.
6282
64520e5c
PE
6283 * term.c: Make symbols static if they're not exported.
6284 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6285 (max_frame_lines, tty_set_terminal_modes):
6286 (tty_reset_terminal_modes, tty_turn_off_highlight):
6287 (get_tty_terminal): Now static.
6288 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6289 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6290 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6291 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6292 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6293
1fa53021
PE
6294 * sysdep.c: Make symbols static if they're not exported.
6295 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6296 Now static.
6297 (sigprocmask_set, full_mask): Remove; unused.
6298 (wait_debugging): Mark as visible.
6299 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6300 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6301
d4b43b22
PE
6302 * syntax.c (syntax_temp): Define only if !__GNUC__.
6303
b7c513d0
PE
6304 * sound.c (current_sound_device, current_sound): Now static.
6305
989b29ad
PE
6306 * search.c (searchbufs, searchbuf_head): Now static.
6307
13a55a78
PE
6308 * scroll.c (scroll_cost): Remove; unused.
6309 * dispextern.h (scroll_cost): Remove decl.
6310
de68a1fc
PE
6311 * region-cache.h (pp_cache): Mark as externally visible.
6312
40ccffa6
PE
6313 * process.c: Make symbols static if they're not exported.
6314 (process_tick, update_tick, create_process, chan_process):
6315 (Vprocess_alist, proc_buffered_char, datagram_access):
6316 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6317 (deactivate_process): Mark defn as static, as well as decl.
6318 * lisp.h (create_process): Remove decl.
6319 * process.h (chan_process, Vprocess_alist): Remove decls.
6320
ad64fc97
PE
6321 * print.c: Make symbols static if they're not exported.
6322 (print_depth, new_backquote_output, being_printed, print_buffer):
6323 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6324 (print_interval, print_number_index, initial_stderr_stream):
6325 Now static.
6326 * lisp.h (Fprinc): Remove decl.
6327 (debug_output_compilation_hack): Mark as externally visible.
6328
adddb265
PE
6329 * sysdep.c (croak): Move decl from here to syssignal.h.
6330 * syssignal.h (croak): Put it here, so the API can be checked when
6331 'croak' is called from dissociate_if_controlling_tty.
6332
1717ede2
PE
6333 * minibuf.c: Make symbols static if they're not exported.
6334 (minibuf_save_list, choose_minibuf_frame): Now static.
6335 * lisp.h (choose_minibuf_frame): Remove decl.
6336
fa5fb2bc
PE
6337 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6338
1e3890d1
PE
6339 * lread.c: Make symbols static if they're not exported.
6340 (read_objects, initial_obarray, oblookup_last_bucket_number):
6341 Now static.
6342 (make_symbol): Remove; unused.
6343 * lisp.h (initial_obarray, make_symbol): Remove decls.
6344
8a1414fa
PE
6345 * keyboard.c: Make symbols static if they're not exported.
6346 (single_kboard, recent_keys_index, total_keys, recent_keys):
6347 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6348 (this_single_command_key_start, echoing, last_auto_save):
6349 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6350 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6351 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6352 (Vlispy_mouse_stem, double_click_count):
6353 Now static.
6354 (force_auto_save_soon): Define only if SIGDANGER.
6355 (ignore_mouse_drag_p): Now static if
6356 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6357 (print_help): Remove; unused.
6358 (stop_character, last_timer_event): Mark as externally visible.
6359 * keyboard.h (ignore_mouse_drag_p): Declare only if
6360 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6361 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6362 * lisp.h (echoing): Remove decl.
6363 (force_auto_save_soon): Declare only if SIGDANGER.
6364 * xdisp.c (redisplay_window): Simplify code, to make it more
6365 obvious that ignore_mouse_drag_p is not accessed if !defined
6366 USE_GTK && !defined HAVE_NS.
6367
93ea6e8f
PE
6368 * intervals.c: Make symbols static if they're not exported.
6369 (merge_properties_sticky, merge_interval_right, delete_interval):
6370 Now static.
6371 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6372
77382fcc
PE
6373 * insdel.c: Make symbols static if they're not exported.
6374 However, leave prepare_to_modify_buffer alone. It's never
6375 called from outside this function, but that appears to be a bug.
6376 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6377 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6378 (adjust_after_replace_noundo): Remove; unused.
6379 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6380 (signal_before_change): Remove decls.
77382fcc 6381
9306c32e
PE
6382 * indent.c (val_compute_motion, val_vmotion): Now static.
6383
cd44d2eb
PE
6384 * image.c: Make symbols static if they're not exported.
6385 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6386 if USE_GTK.
6387 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6388 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6389
ad9a7a06
PE
6390 * fringe.c (standard_bitmaps): Now static.
6391 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6392
81626931
PE
6393 * frame.c: Make symbols static if they're not exported.
6394 (x_report_frame_params, make_terminal_frame): Now static.
6395 (get_frame_param): Now static, unless HAVE_NS.
6396 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6397 (x_get_resource_string): Remove; not used.
6398 * frame.h (make_terminal_frame, x_report_frame_params):
6399 (x_get_resource_string); Remove decls.
6400 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6401 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6402
239f9db9
PE
6403 * font.c, fontset.c: Make symbols static if they're not exported.
6404 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6405 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6406 * font.c (font_close_object): Now static.
6407 * font.h (font_close_object): Remove.
6408 * fontset.c (FONTSET_OBJLIST): Remove.
6409 (free_realized_fontset) #if-0 the body, which does nothing.
6410 (face_suitable_for_char_p): #if-0, as it's never called.
6411 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6412 * xfaces.c (face_at_string_position):
6413 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6414 since 0 is always ASCII.
6415
dfcf3579
PE
6416 * fns.c (weak_hash_tables): Now static.
6417
5045092b
PE
6418 * fileio.c: Make symbols static if they're not exported.
6419 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6420 (Vwrite_region_annotation_buffers): Now static.
6421
57a96f5c
PE
6422 * eval.c: Make symbols static if they're not exported.
6423 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6424 * lisp.h (backtrace_list): Remove decl.
6425
35f08c38
PE
6426 * emacs.c: Make symbols static if they're not exported.
6427 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6428 (fatal_error_code, fatal_error_signal_hook, standard_args):
6429 Now static.
6430 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6431 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6432 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6433 * lisp.h (fatal_error_signal_hook): Remove decl.
6434 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6435
f44bd759
PE
6436 * editfns.c: Move a (normally-unused) function to its only use.
6437 * editfns.c, lisp.h (get_operating_system_release): Remove.
6438 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6439 worth the hassle of breaking this out.
6440
b532497d
PE
6441 * xterm.c: Make symbols static if they're not exported.
6442 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6443 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6444 (x_destroy_window, x_delete_display):
6445 Now static.
6446 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6447 (x_mouse_leave): Remove; unused.
6448 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6449 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6450 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6451 Remove decls.
6452 (x_mouse_leave): Declare only if WINDOWSNT.
6453 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6454 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6455 USE_X_TOOLKIT.
6456
1675728f
PE
6457 * ftxfont.c: Make symbols static if they're not exported.
6458 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6459 HAVE_FREETYPE.
6460 * font.h (ftxfont_driver): Likewise.
6461
e4cebfca
PE
6462 * xfns.c: Make symbols static if they're not exported.
6463 (x_last_font_name, x_display_info_for_name):
6464 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6465 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6466 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6467 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6468 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6469 (last_show_tip_args): Now static.
6470 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6471 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6472 (x_screen_planes): Remove; unused.
6473 * dispextern.h (x_screen_planes): Remove decl.
6474
5bf46f05
PE
6475 * dispnew.c: Make symbols static if they're not exported.
6476 * dispextern.h (redraw_garbaged_frames, scrolling):
6477 (increment_row_positions): Remove.
6478 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6479 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6480 Now static.
6481 (redraw_garbaged_frames): Remove; unused.
6482
435f4c28
PE
6483 * xfaces.c: Make symbols static if they're not exported.
6484 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6485 Remove decls.
6486 * xterm.h (defined_color): Remove decls.
6487 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6488 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6489 (menu_face_changed_default, defined_color, free_realized_face):
6490 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6491 (ascii_face_of_lisp_face): Remove; unused.
6492
8524aef3
PE
6493 * xdisp.c: Make symbols static if they're not exported.
6494 * dispextern.h (scratch_glyph_row, window_box_edges):
6495 (glyph_to_pixel_coords, set_cursor_from_row):
6496 (get_next_display_element, set_iterator_to_next):
6497 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6498 (show_mouse_face): Remove decls
6499 * frame.h (message_buf_print): Likewise.
6500 * lisp.h (pop_message, set_message, check_point_in_composition):
6501 Likewise.
6502 * xterm.h (set_vertical_scroll_bar): Likewise.
6503 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6504 (message_buf_print, scratch_glyph_row, displayed_buffer):
6505 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6506 (get_next_display_element, show_mouse_face, window_box_edges):
6507 (frame_to_window_pixel_xy, check_point_in_composition):
6508 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6509 (glyph_to_pixel_coords): Remove; unused.
6510
16390cd2
PE
6511 * dired.c (file_name_completion): Now static.
6512
6513 * dbusbind.c (xd_in_read_queued_messages): Now static.
6514
a25f4dfa
PE
6515 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6516 * data.c (circular_list_error): Remove.
6517
14a9c8df
PE
6518 * commands.h (last_point_position, last_point_position_buffer):
6519 (last_point_position_window): Remove decls.
6520 * keyboard.c: Make these variables static.
6521
04f2d78b
CB
6522 * coding.h (coding, code_convert_region, encode_coding_gap):
6523 Remove decls.
74ab6df5
PE
6524 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6525 (iso_code_class, detect_coding, code_convert_region): Now static.
6526 (encode_coding_gap): Remove; unused.
6527
38dfbee1
PE
6528 * chartab.c (chartab_chars, chartab_bits): Now static.
6529
a2cb4e63
PE
6530 * charset.h (charset_iso_8859_1): Remove decl.
6531 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6532 Now static.
6533
127198fd
PE
6534 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6535 * ccl.c (Vccl_program_table): Now static.
6536 (check_ccl_update): Remove; unused.
6537
d85b608f
PE
6538 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6539 * category.h: ... from here.
6540 * category.c (check_category_table, set_category_set): Now static.
6541
31cd66f3
PE
6542 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6543 * lisp.h: Remove these decls.
6544
c358e587
PE
6545 * buffer.c (buffer_count): Remove unused var.
6546
e78aecca
PE
6547 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6548 so that it's not optimized away.
6549 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6550 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6551 exported only to the debugger.
6552
e192d7d3 6553 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6554 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6555
92470028
PE
6556 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6557 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6558 was inaccessible from Lisp.
6559 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6560 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6561
244ed907
PE
6562 alloc.c: Import and export fewer symbols, and remove unused items.
6563 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6564 is defined.
6565 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6566 it's not optimized away by whole-program optimization.
6567 (message_enable_multibyte, free_misc): Remove.
6568 (catchlist, handlerlist, mark_backtrace):
6569 Declare only if BYTE_MARK_STACK.
6570 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6571 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6572 (message_enable_multibyte): Remove decl.
6573 (free_misc, interval_free_list, float_block, float_block_index):
6574 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6575 (cons_free_list, last_marked_index):
6576 Now static.
6577 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6578 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6579 (mark_backtrace): Define only if BYTE_MARK_STACK.
6580 * xdisp.c (message_enable_multibyte): Now static.
6581
61c2b50e 6582 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6583 This makes it easier for human readers (and static analyzers)
6584 to see whether these variables are used from other modules.
6585 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6586 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6587 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6588 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6589 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6590 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6591 * xmenu.c, xselect.c:
6592 Declare Q* vars static if they are not used in other modules.
6593 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6594 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6595 Remove decls of unexported vars.
6596 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6597
95c82688
PE
6598 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6599
16a97296
PE
6600 Make Emacs functions such as Fatom 'static' by default.
6601 This makes it easier for human readers (and static analyzers)
6602 to see whether these functions can be called from other modules.
6603 DEFUN now defines a static function. To make the function external
6604 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6605 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6606 (Finit_image_library):
16a97296
PE
6607 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6608 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6609 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6610 Remove decls, since these functions are now static.
6611 (Funintern, Fget_internal_run_time): New decls, since these functions
6612 were already external.
95c82688 6613
16a97296
PE
6614 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6615 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6616 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6617 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6618 * keyboard.c, keymap.c, lread.c:
6619 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6620 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6621 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6622 Mark functions with DEFUE instead of DEFUN,
6623 if they are used in other modules.
6624 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6625 decls for now-static functions.
6626 * buffer.h (Fdelete_overlay): Remove decl.
6627 * callproc.c (Fgetenv_internal): Mark as internal.
6628 * composite.c (Fremove_list_of_text_properties): Remove decl.
6629 (Fcomposition_get_gstring): New forward static decl.
6630 * composite.h (Fcomposite_get_gstring): Remove decl.
6631 * dired.c (Ffile_attributes): New forward static decl.
6632 * doc.c (Fdocumntation_property): New forward static decl.
6633 * eval.c (Ffetch_bytecode): New forward static decl.
6634 (Funintern): Remove extern decl; now in .h file where it belongs.
6635 * fileio.c (Fmake_symbolic_link): New forward static decl.
6636 * image.c (Finit_image_library): New forward static decl.
6637 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6638 * intervals.h (Fprevious_property_change):
6639 (Fremove_list_of_text_properties): Remove decls.
6640 * keyboard.c (Fthis_command_keys): Remove decl.
6641 (Fcommand_execute): New forward static decl.
6642 * keymap.c (Flookup_key): New forward static decl.
6643 (Fcopy_keymap): Now static.
6644 * keymap.h (Flookup_key): Remove decl.
6645 * process.c (Fget_process): New forward static decl.
6646 (Fprocess_datagram_address): Mark as internal.
6647 * syntax.c (Fsyntax_table_p): New forward static decl.
6648 (skip_chars): Remove duplicate decl.
6649 * textprop.c (Fprevious_property_change): New forward static decl.
6650 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6651 Now internal.
6652 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6653 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6654
785bbd42
PE
6655 * editfns.c (Fformat): Remove unreachable code.
6656
8b913b57
AS
66572011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6658
6659 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6660 change. (Bug#8496)
6661
a6744a35
EZ
66622011-04-13 Eli Zaretskii <eliz@gnu.org>
6663
6664 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6665 when at ZV. (Bug#8487)
6666
e7974947
AS
66672011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6668
baad03f0
AS
6669 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6670 (Bug#8437)
6671 * keyboard.c (parse_tool_bar_item): Likewise.
6672 * sound.c (sound_cleanup, alsa_close): Likewise.
6673 * termcap.c (tgetent): Likewise.
6674 * xfns.c (x_default_font_parameter): Likewise.
6675 * xsettings.c (read_and_apply_settings): Likewise.
6676
e7974947
AS
6677 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6678 (overrun_check_free): Protoize.
6679
28272684
PE
66802011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6681
6682 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6683 since callers should never pass a negative size.
6684 Change the signature to match that of plain 'read' and 'write'; see
6685 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6686 * lisp.h: Update prototypes of emacs_write and emacs_read.
6687
11997c76
EZ
66882011-04-11 Eli Zaretskii <eliz@gnu.org>
6689
6690 * xdisp.c (redisplay_window): Don't try to determine the character
6691 position of the scroll margin if the window start point w->startp
e896f03c 6692 is outside the buffer's accessible region. (Bug#8468)
11997c76 6693
8a2cbd72
EZ
66942011-04-10 Eli Zaretskii <eliz@gnu.org>
6695
6696 Fix write-region and its subroutines for buffers > 2GB.
6697 * fileio.c (a_write, e_write): Modify declaration of arguments and
6698 local variables to support buffers larger than 2GB.
6699 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6700
6701 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6702 argument, local variables, and return value.
6703
6704 * lisp.h: Update prototypes of emacs_write and emacs_read.
6705
6706 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6707
4073e537 67082011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6709
1ebfdcb6
PE
6710 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6711
b2ded58d
PE
6712 Fix more problems found by GCC 4.6.0's static checks.
6713
7d66342c
PE
6714 * xdisp.c (vmessage): Use a better test for character truncation.
6715
bbf47d44
PE
6716 * charset.c (load_charset_map): <, not <=, for optimization,
6717 and to avoid potential problems with integer overflow.
9248994d 6718 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6719 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6720 * editfns.c (Fformat): Likewise.
1e69125e 6721 * syntax.c (skip_chars): Likewise.
3befa583 6722
e3019616
PE
6723 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6724 This also lets GCC 4.6.0 generate slightly better loop code.
6725
becfa255
PE
6726 * callint.c (Fcall_interactively): <, not <=, for optimization.
6727 (Fcall_interactively): Count the number of arguments produced,
6728 not the number of arguments given. This is simpler and lets GCC
6729 4.6.0 generate slightly better code.
6730
dae0cd48
PE
6731 * ftfont.c: Distingish more carefully between FcChar8 and char.
6732 The previous code passed unsigned char * to a functions like
6733 strlen and xstrcasecmp that expect char *, which does not
6734 conform to the C standard.
6735 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6736 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6737 char * when the C standard requires it.
6738
76032d70
PE
6739 * keyboard.c (read_char): Remove unused var.
6740
eb3f1cc8
PE
6741 * eval.c: Port to Windows vsnprintf (Bug#8435).
6742 Include <limits.h>.
6743 (SIZE_MAX): Define if the headers do not.
6744 (verror): Do not give up if vsnprintf returns a negative count.
6745 Instead, grow the buffer. This ports to Windows vsnprintf, which
6746 does not conform to C99. Problem reported by Eli Zaretskii.
6747 Also, simplify the allocation scheme, by avoiding the need for
6748 calling realloc, and removing the ALLOCATED variable.
6749
70476b54
PE
6750 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6751
12020a9e
PE
6752 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6753 But keep the doprint source code for now, as we might revamp it
6754 and use it again (Bug#8435).
ea6c7ae6
PE
6755 * lisp.h (doprnt): Remove.
6756 * Makefile.in (base_obj): Remove doprnt.o.
6757 * deps.mk (doprnt.o): Remove.
6758
5fdb398c
PE
6759 error: Print 32- and 64-bit integers portably (Bug#8435).
6760 Without this change, on typical 64-bit hosts error ("...%d...", N)
6761 was used to print both 32- and 64-bit integers N, which relied on
6762 undefined behavior.
6763 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6764 New macro.
6765 * lisp.h (error, verror): Mark as printf-like functions.
6766 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6767 Report overflow in size calculations when allocating printf buffer.
6768 Do not truncate output string at its first null byte.
6769 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6770 Truncate the output at a character boundary, since vsnprintf does not
6771 do that.
6772 * charset.c (check_iso_charset_parameter): Convert internal
6773 character to string before calling 'error', since %c now has the
6774 printf meaning.
6775 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6776 overflow when computing char to be passed to 'error'. Do not
6777 pass Lisp_Object to 'error'; pass the integer instead.
6778 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6779 formatted with plain %d.
6780
b189fa66
PE
6781 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6782
bff87ef0
PE
6783 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6784
7e2cac20
PE
6785 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6786
ce4d90b5
PE
6787 * xterm.c (x_catch_errors): Remove duplicate declaration.
6788
266c9547
PE
6789 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6790
79c49ad2
PE
6791 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6792
368f4090
JM
67932011-04-10 Jim Meyering <meyering@redhat.com>
6794
6795 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6796 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6797 return ssize_t not "int", and use size_t as the buffer length.
6798 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6799 * gnutls.h: Update declarations.
6800 * process.c (read_process_output): Use ssize_t, to match.
6801 (send_process): Likewise.
6802
a32d4040
CY
68032011-04-09 Chong Yidong <cyd@stupidchicken.com>
6804
6805 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6806
8546720e 68072011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6808
04f2d78b
CB
6809 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6810 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6811
8546720e
GM
6812 * xterm.c (handle_one_xevent):
6813 * xmenu.c (create_and_show_popup_menu):
6814 * xselect.c (x_decline_selection_request)
6815 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6816
0a2f5c1a 68172011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6818
6819 Fix some uses of `int' instead of EMACS_INT.
6820 * search.c (string_match_1, fast_string_match)
6821 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6822 (scan_buffer, find_next_newline_no_quit)
6823 (find_before_next_newline, search_command, Freplace_match)
6824 (Fmatch_data): Make some `int' variables be EMACS_INT.
6825
6826 * xdisp.c (display_count_lines): 3rd argument and return value now
6827 EMACS_INT. All callers changed.
6828 (pint2hrstr): Last argument is now EMACS_INT.
6829
6830 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6831 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6832 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6833 (decode_coding_utf_16, decode_coding_emacs_mule)
6834 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6835 (decode_coding_ccl, decode_coding_charset)
6836 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6837 (decode_coding_iso_2022, decode_coding_emacs_mule)
6838 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6839 <char_offset, last_offset>: Declare EMACS_INT.
6840 (encode_coding_utf_8, encode_coding_utf_16)
6841 (encode_coding_emacs_mule, encode_invocation_designation)
6842 (encode_designation_at_bol, encode_coding_iso_2022)
6843 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6844 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6845 Declare EMACS_INT.
6846 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6847 (encode_invocation_designation): Last argument P_NCHARS is now
6848 EMACS_INT.
6849 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6850 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6851
6852 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6853 All users changed.
6854
6855 * ccl.c (Fccl_execute_on_string): Declare some variables
6856 EMACS_INT.
6857
8546720e 68582011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6859
6860 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6861
4e19a977
CS
68622011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6863
6864 * process.c (Fformat_network_address): Doc fix.
6865
87302331
R
68662011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6867
6868 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6869
cbb59342
CY
68702011-04-08 Chong Yidong <cyd@stupidchicken.com>
6871
6872 * keyboard.c (read_char): Call Lisp function help-form-show,
6873 instead of using internal_with_output_to_temp_buffer.
6874 (Qhelp_form_show): New var.
e0d38eeb 6875 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6876
6877 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6878
6879 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6880
e67a13ab
CY
68812011-04-06 Chong Yidong <cyd@stupidchicken.com>
6882
04f2d78b
CB
6883 * process.c (Flist_processes): Remove to Lisp.
6884 (list_processes_1): Delete.
e67a13ab 6885
973f782d
EZ
68862011-04-06 Eli Zaretskii <eliz@gnu.org>
6887
7c106b1e
EZ
6888 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6889
973f782d
EZ
6890 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6891
41cf7d1a 68922011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6893
ca23cc88
PE
6894 Fix more problems found by GCC 4.6.0's static checks.
6895
f390e2d5
PE
6896 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6897
42eea0d0
PE
6898 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6899
b69769da 6900 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6901
f9541e84
PE
6902 * xdisp.c (vmessage): Mark as a printf-like function.
6903
13841b55
PE
6904 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6905
c136c10f
PE
6906 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6907
5e2d4a30
PE
6908 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6909 printf-like functions.
6910 (tiff_load): Add casts to remove these marks before passing them
6911 to system-supplied API.
6912
583f48b9
PE
6913 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6914
b25d760e
PE
6915 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6916 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6917 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6918 directly, rather than having caller test rule sign. This avoids
6919 some unnecessary tests.
6920 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6921 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6922 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6923
bc7b6697 6924 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6925 (xfont_open): Avoid unnecessary tests.
bc7b6697 6926
27ccc379
PE
6927 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6928
dcd5c89a
PE
6929 * composite.h, composite.c (composition_gstring_put_cache):
6930 Use EMACS_INT, not int, for length.
6931
b13a45c6
PE
6932 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6933 breaking out part of COMPOSITION_DECODE_RULE.
6934 (COMPOSITION_DECODE_RULE): Use it.
6935 * composite.c (get_composition_id): Remove unused local vars,
6936 by using the new macro.
6937
1e792e4d
PE
6938 * textprop.c (set_text_properties_1): Change while to do-while,
6939 since the condition is always true at first.
6940
dc6c6455 6941 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6942 (interval_deletion_adjustment): Return unsigned value.
6943 All uses changed.
dc6c6455 6944
aba7731a
PE
6945 * process.c (list_processes_1, create_pty, read_process_output):
6946 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6947 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6948 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6949 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6950 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6951
fdfc4bf3
PE
6952 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6953
fca8fe46 6954 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6955 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6956
06a0259a 6957 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6958 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6959 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6960
e7b9e80f
PE
6961 * print.c (print_error_message): Avoid int overflow.
6962
56201685
PE
6963 * font.c (font_list_entities): Redo for clarity,
6964 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6965
78834453 6966 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6967 (font_score): Avoid potential overflow in diff calculation.
78834453 6968
0bc0b309 6969 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6970 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6971
e610eaca
PE
6972 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6973
b895abce
PE
6974 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6975 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6976 can always succeed if overflow has undefined behavior.
6977
1f1d9321 6978 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6979 (wordify): Omit three unnecessary tests.
1f1d9321 6980
c59478bc
PE
6981 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6982 All callers changed. This avoids the need for an unused var.
6983
79b73827
PE
6984 * casefiddle.c (casify_region): Remove var that is set but not used.
6985
a4db5dfe
PE
6986 * dired.c (file_name_completion): Remove var that is set but not used.
6987
43aae36e
PE
6988 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6989
2a47c44d 6990 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6991 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6992
a37c69bf
PE
6993 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6994 Check for integer overflow on size calculations.
6995
328ab8e7
PE
6996 * buffer.c (Fprevious_overlay_change): Remove var that is set
6997 but not used.
6998
e5a2a5cb
PE
6999 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7000 Remove vars that are set but not used.
8d84a6eb 7001 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7002 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7003
a60e5f68
PE
7004 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7005
f661cb61 7006 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7007 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7008
f0397f5a
PE
7009 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7010 that are set but not used.
7011
8664db06 7012 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7013 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7014
6abdaa4a
PE
7015 * xselect.c (x_get_local_selection, x_handle_property_notify):
7016 Remove vars that are set but not used.
7017
0ce7538d 7018 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7019 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7020
9ae848fc
PE
7021 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7022 Remove var that is set but not used.
0b918413
PE
7023 (scroll_bar_windows_size): Now size_t, not int.
7024 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7025 Check for overflow.
9ae848fc 7026
a5a62657
PE
7027 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7028 (map_tty_color) [!defined MSDOS]: Likewise.
7029
5c5cdd39
PE
7030 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7031
66ebf983
PE
7032 * coding.c: Remove vars that are set but not used.
7033 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7034 All callers changed.
7035 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7036 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7037 (decode_coding_charset): Remove vars that are set but not used.
7038
1be4d761
PE
7039 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7040 that is set but not used.
7041
47553fa8
PE
7042 * print.c (print_object): Remove var that is set but not used.
7043
1f7196bf 7044 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7045 The gnulib version avoids calling malloc in the usual case,
7046 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7047 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7048 * filelock.c (current_lock_owner): Likewise.
7049 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7050 * sysdep.c: Include allocator.h, careadlinkat.h.
7051 (emacs_no_realloc_allocator): New static constant.
7052 (emacs_readlink): New function.
fdb61804
PE
7053 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7054 ../lib/careadlinkat.h.
d1fdcab7 7055
f84c17c7
SM
70562011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7057
7058 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7059 first non-nil return value).
7060
ef3862ad
JD
70612011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7062
7063 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7064 if not defined (Bug#8403).
7065
376a7006
JB
70662011-04-02 Juanma Barranquero <lekktu@gmail.com>
7067
7068 * xdisp.c (display_count_lines): Remove parameter `start',
7069 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7070 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7071 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7072 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7073 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7074 and thereabouts. All callers changed.
7075 (get_per_char_metric): Remove parameter `f', unused since
7076 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7077
6ca3801d
JM
70782011-04-02 Jim Meyering <meyering@redhat.com>
7079
7080 do not dereference NULL upon failed strdup
7081 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7082 (ns_get_family): Likewise.
7083
d8e2b5ba
JB
70842011-04-02 Juanma Barranquero <lekktu@gmail.com>
7085
7086 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7087
8c74fcbd
JD
70882011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7089
7090 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7091 later (Bug#8403).
7092
7200d79c
SM
70932011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7094
03408648 7095 Add lexical binding.
7200d79c 7096
03408648
SM
7097 * window.c (Ftemp_output_buffer_show): New fun.
7098 (Fsave_window_excursion):
7099 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7100
7101 * lread.c (lisp_file_lexically_bound_p): New function.
7102 (Fload): Bind Qlexical_binding.
7103 (readevalloop): Remove `evalfun' arg.
7104 Bind Qinternal_interpreter_environment.
7105 (Feval_buffer): Bind Qlexical_binding.
7106 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7107 Mark as dynamic.
7108 (syms_of_lread): Declare `lexical-binding'.
7109
7110 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7111
7112 * keyboard.c (eval_dyn): New fun.
7113 (menu_item_eval_property): Use it.
ca105506
SM
7114
7115 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7116
03408648
SM
7117 * fns.c (concat, mapcar1): Accept byte-code-functions.
7118
7119 * eval.c (Fsetq): Handle lexical vars.
7120 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7121 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7122 (FletX, Flet): Obey lexical binding.
7123 (Fcommandp): Handle closures.
7124 (Feval): New `lexical' arg.
7125 (eval_sub): New function extracted from Feval. Use it almost
7126 everywhere where Feval was used. Look up vars in lexical env.
7127 Handle closures.
7128 (Ffunctionp): Move from subr.el.
7129 (Ffuncall): Handle closures.
7130 (apply_lambda): Remove `eval_flags'.
7131 (funcall_lambda): Handle closures and new byte-code-functions.
7132 (Fspecial_variable_p): New function.
7133 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7134 but without exporting it to Lisp.
23aba0ea 7135
23aba0ea 7136 * doc.c (Fdocumentation, store_function_docstring):
03408648 7137 * data.c (Finteractive_form): Handle closures.
23aba0ea 7138
03408648
SM
7139 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7140 interactive spec.
ba83908c 7141
04f2d78b
CB
7142 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7143 New byte-codes.
03408648
SM
7144 (exec_byte_code): New function extracted from Fbyte_code to handle new
7145 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7146
03408648 7147 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7148
03408648 7149 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7150
e2abce01
JB
71512011-03-31 Juanma Barranquero <lekktu@gmail.com>
7152
7153 * xdisp.c (redisplay_internal): Fix prototype.
7154
63696a73 71552011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7156
63696a73 7157 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7158 (try_scrolling): Use it when setting scroll_limit.
7159 Limit scrolling to 100 screen lines.
63696a73
EZ
7160 (redisplay_window): Even when falling back on "recentering",
7161 position point in the window according to scroll-conservatively,
7162 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7163
7164 (try_scrolling): When point is above the window, allow searching
7165 as far as scroll_max, or one screenful, to compute vertical
7166 distance from PT to the scroll margin position. This prevents
7167 try_scrolling from unnecessarily failing when
7168 scroll-conservatively is set to a value slightly larger than the
7169 window height. Clean up the case of PT below the margin at bottom
7170 of window: scroll_max can no longer be INT_MAX. When aggressive
7171 scrolling is in use, don't let point enter the opposite scroll
7172 margin as result of the scroll.
7173 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7174 threshold of 100 lines for never-recentering scrolling.
7175
e4cc2dfc
JB
71762011-03-31 Juanma Barranquero <lekktu@gmail.com>
7177
7178 * dispextern.h (move_it_by_lines):
7179 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7180 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7181 (message_log_check_duplicate): Remove parameters `prev_bol' and
7182 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7183 (redisplay_internal): Remove parameter `preserve_echo_area',
7184 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7185
7186 * indent.c (Fvertical_motion):
7187 * window.c (window_scroll_pixel_based, Frecenter):
7188 Don't pass `need_y_p' to `move_it_by_lines'.
7189
1c470562
SM
71902011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7191
44f230aa
SM
7192 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7193 steal a few bits to be more compact.
7194 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7195 Remove unneeded casts.
7196
1c470562
SM
7197 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7198
888adce9
ZK
71992011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7200
7201 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7202 binding" message (bug#7967).
7203
f838ed7b
PE
72042011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7205
77861b95
PE
7206 Fix more problems found by GCC 4.6.0's static checks.
7207
de6dbc14
PE
7208 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7209 Remove unused local var.
7210
f838ed7b
PE
7211 * editfns.c (Fmessage_box): Remove unused local var.
7212
792c7b2b
PE
7213 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7214 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7215 Omit unused local vars.
c499e557 7216 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7217 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7218 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7219 Omit unused local var.
7220
ba0165e1
PE
7221 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7222 Don't assume string length fits in int.
32ad8845 7223 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7224 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7225
3c59b4c9
PE
7226 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7227 instead of alloca (Bug#8344).
7228
a3eed478 7229 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7230 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7231
eb4d412d
PE
7232 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7233
1658b401
PE
7234 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7235 concerns.
7236
7237 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7238
7239 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7240
9a2c6e05
PE
7241 * keyboard.c (syms_of_keyboard): Use the same style as later
7242 in this function when indexing through an array. This also
7243 works around GCC bug 48267.
7244
03d0a109
PE
7245 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7246
44f730c8
PE
7247 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7248
fe75f926
PE
7249 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7250 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7251
ffa8c828
PE
7252 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7253 This avoids undefined behavior on integer overflow, and is a bit
7254 more convenient anyway since it is compared to a size_t variable.
7255
c5101a77
PE
7256 Variadic C functions now count arguments with size_t, not int.
7257 This avoids an unnecessary limitation on 64-bit machines, which
7258 caused (substring ...) to crash on large vectors (Bug#8344).
7259 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7260 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7261 All variadic functions and their callers changed accordingly.
c5101a77
PE
7262 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7263 * data.c (arith_driver, float_arith_driver): Likewise.
7264 * editfns.c (general_insert_function): Likewise.
7265 * eval.c (struct backtrace.nargs, interactive_p)
7266 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7267 (funcall_lambda, mark_backtrace): Likewise.
7268 * fns.c (concat): Likewise.
7269 * frame.c (x_set_frame_parameters): Likewise.
7270 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7271 0 if not found, not -1. All callers changed.
7272
dd3f25f7
PE
7273 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7274 (stack_copy_size): Now size_t, not int.
7275 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7276
461c2ab9
JB
72772011-03-28 Juanma Barranquero <lekktu@gmail.com>
7278
7279 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7280 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7281 All callers changed.
7282
7283 * lisp.h (multibyte_char_to_unibyte):
7284 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7285 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7286 * character.h (CHAR_TO_BYTE8):
7287 * cmds.c (internal_self_insert):
7288 * editfns.c (general_insert_function):
7289 * keymap.c (push_key_description):
7290 * search.c (Freplace_match):
7291 * xdisp.c (message_dolog, set_message_1): All callers changed.
7292
f6d62986
SM
72932011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7294
7295 * keyboard.c (safe_run_hook_funcall): New function.
7296 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7297 don't set the hook to nil, but remove the offending function instead.
7298 (Qcommand_hook_internal): Remove, unused.
7299 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7300 Vcommand_hook_internal.
7301
7302 * eval.c (enum run_hooks_condition): Remove.
7303 (funcall_nil, funcall_not): New functions.
7304 (run_hook_with_args): Call each function through a `funcall' argument.
7305 Remove `cond' argument, now redundant.
7306 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7307 (Frun_hook_with_args_until_failure): Adjust accordingly.
7308 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7309
1db5b1ad
JB
73102011-03-28 Juanma Barranquero <lekktu@gmail.com>
7311
7312 * dispextern.h (string_buffer_position): Remove declaration.
7313
7314 * print.c (strout): Remove parameter `multibyte', unused since
7315 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7316
7317 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7318 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7319 All callers changed.
7320
7321 * w32.c (_wsa_errlist): Use braces for struct initializers.
7322
7323 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7324 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7325 All callers changed.
7326 (string_buffer_position): Likewise. Also, make static (it's never
7327 used outside xdisp.c).
7328 (cursor_row_p): Remove parameter `w', unused since
7329 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7330 (decode_mode_spec): Remove parameter `precision', introduced during
7331 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7332 All callers changed.
7333
5ffb62aa
JD
73342011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7335
7336 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7337
461c2ab9 73382011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7339
7340 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7341 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7342 (ns_update_auto_hide_menu_bar): New functions.
7343 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7344 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7345 ns_constrain_all_frames.
7346 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7347 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7348
5c380ffb
JD
73492011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7350
7351 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7352
9af30bdf
GM
73532011-03-27 Glenn Morris <rgm@gnu.org>
7354
7355 * syssignal.h: Replace RETSIGTYPE with void.
7356 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7357 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7358 Replace SIGTYPE with void everywhere.
7359 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7360 * s/template.h (SIGTYPE): Remove commented out definition.
7361
e2abce01
JB
73622011-03-26 Eli Zaretskii <eliz@gnu.org>
7363
7364 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7365 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7366
f868cd8a
JB
73672011-03-26 Juanma Barranquero <lekktu@gmail.com>
7368
59eb0929
JB
7369 * w32.c (read_unc_volume): Use parameter `henum', instead of
7370 global variable `wget_enum_handle'.
7371
7372 * keymap.c (describe_vector): Remove parameters `indices' and
7373 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7374 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7375
f868cd8a
JB
7376 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7377
7378 * keyboard.c (timer_check): Remove parameter `do_it_now',
7379 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7380 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7381 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7382
7383 * keyboard.c (read_char):
7384 * w32menu.c (w32_menu_display_help):
7385 * xmenu.c (show_help_event, menu_help_callback):
7386 Adjust calls to `show_help_echo'.
7387
7388 * gtkutil.c (xg_maybe_add_timer):
7389 * keyboard.c (readable_events):
7390 * process.c (wait_reading_process_output):
7391 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7392
7393 * insdel.c (adjust_markers_gap_motion):
7394 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7395 (gap_left, gap_right): Don't call it.
7396
2ecf6fdb
CY
73972011-03-25 Chong Yidong <cyd@stupidchicken.com>
7398
7399 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7400 incurred during fontification.
7401
6b1f9ba4
JB
74022011-03-25 Juanma Barranquero <lekktu@gmail.com>
7403
7404 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7405 (DEFVAR_PER_BUFFER): Don't pass it.
7406
7407 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7408 (scrolling_window): Don't pass it.
7409
0f4a96b5
JB
74102011-03-25 Juanma Barranquero <lekktu@gmail.com>
7411
7412 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7413
7414 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7415 and `suffix'.
7416 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7417 of variables specific to SELinux and computation of `encoded_absname'.
7418
7419 * image.c (XPutPixel): Remove unused variable `height'.
7420
7421 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7422
7423 * unexw32.c (get_section_info): Remove unused variable `section'.
7424
7425 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7426 (system_process_attributes): Remove unused variable `sess'.
7427 (sys_read): Remove unused variable `err'.
7428
7429 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7430 (w32_wnd_proc): Remove unused variable `isdead'.
7431 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7432 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7433 (x_create_tip_frame): Remove unused variable `tem'.
7434
7435 * w32inevt.c (w32_console_read_socket):
7436 Remove unused variable `no_events'.
7437
7438 * w32term.c (x_draw_composite_glyph_string_foreground):
7439 Remove unused variable `width'.
7440
1149507c
JB
74412011-03-24 Juanma Barranquero <lekktu@gmail.com>
7442
7443 * w32term.c (x_set_glyph_string_clipping):
7444 Don't pass uninitialized region to CombineRgn.
7445
9c88f339
JB
74462011-03-23 Juanma Barranquero <lekktu@gmail.com>
7447
7448 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7449 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7450 (Fx_close_connection): Remove unused variable `i'.
7451
7452 * w32font.c (w32font_draw): Return number of glyphs.
7453 (w32font_open_internal): Remove unused variable `i'.
7454 (w32font_driver): Add missing initializer.
7455
7456 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7457 (fill_in_menu): Remove unused variable `items_added'.
7458
7459 * w32term.c (last_mouse_press_frame): Remove static global variable.
7460 (w32_clip_to_row): Remove unused variable `f'.
7461 (x_delete_terminal): Remove unused variable `i'.
7462
7463 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7464 (NOTHING): Remove unused static global variable.
7465 (uniscribe_check_otf): Remove unused variable `table'.
7466 (uniscribe_font_driver): Add missing initializers.
7467
dee091a3
JD
74682011-03-23 Julien Danjou <julien@danjou.info>
7469
7470 * term.c (Fsuspend_tty, Fresume_tty):
7471 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7472 * window.c (temp_output_buffer_show):
7473 * insdel.c (signal_before_change):
7474 * frame.c (Fhandle_switch_frame):
7475 * fileio.c (Fdo_auto_save):
7476 * emacs.c (Fkill_emacs):
7477 * editfns.c (save_excursion_restore):
7478 * cmds.c (internal_self_insert):
7479 * callint.c (Fcall_interactively):
7480 * buffer.c (Fkill_all_local_variables):
7481 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7482 Use Frun_hooks.
0f4a96b5 7483 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7484 unconditionnaly since it does the check itself.
7485
2c520ab5 74862011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7487
c9c49752
PE
7488 Fix more problems found by GCC 4.5.2's static checks.
7489
8abc3f12
PE
7490 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7491 the first time through the loop, since we know p0 < p1 then.
7492 This also avoids a gcc -Wstrict-overflow warning.
7493
a2d26660
PE
7494 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7495 leading to a memory leak, possible in functions like
7496 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7497 of objects (Bug#8318).
a2d26660 7498
916c72e9
PE
7499 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7500 that could (at least in theory) be that large.
7501
19ab8a18
PE
7502 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7503 This is less likely to overflow, and avoids undefined behavior if
7504 overflow does occur. All callers changed. Use strtoul to scan
7505 for the unsigned long integer.
b7cbbd6f
PE
7506 (pint2hrstr): Simplify and tune code slightly.
7507 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7508
f0641eff
PE
7509 * scroll.c (do_scrolling): Work around GCC bug 48228.
7510 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7511
7f650bb9
PE
7512 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7513 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7514 (validate_x_resource_name): Simplify count usage.
7515 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7516
37dd57d1
PE
7517 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7518 fail (Bug#8306).
81e56e61 7519
699979fc 7520 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7521
401bf9b4
PE
7522 * process.c (Fmake_network_process): Use socklen_t, not int,
7523 where POSIX says socklen_t is required in portable programs.
7524 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7525 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7526 (Fmake_network_process, server_accept_connection):
7527 (wait_reading_process_output, read_process_output):
7528 Likewise.
7529
b93aacde
PE
7530 * process.c: Rename or move locals to avoid shadowing.
7531 (list_processes_1, Fmake_network_process):
7532 (read_process_output_error_handler, exec_sentinel_error_handler):
7533 Rename or move locals.
4dc343ee 7534 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7535 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7536 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7537 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7538 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7539
af8a867c 7540 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7541 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7542 Include tparam.h instead, since it declares them.
af8a867c
PE
7543 * cm.h (PC): Remove extern decl; tparam.h now does this.
7544 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7545 * terminfo.c: Include tparam.h, to check interfaces.
7546 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7547 (tparam): Adjust signature to match interface in tparam.h;
7548 this removes some undefined behavior. Check that outstring and len
7549 are zero, which they always are with Emacs.
7550 * tparam.h (PC, BC, UP): New extern decls.
7551
0248044d 7552 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7553 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7554
8ff096c1 7555 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7556 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7557 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7558 (ftfont_list): Remove unused local.
49eaafba
PE
7559 (get_adstyle_property, ftfont_pattern_entity):
7560 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7561 Rename locals to avoid shadowing.
8ff096c1 7562
e2be39f6
PE
7563 * xfont.c (xfont_list_family): Mark var as initialized.
7564
c9735e30
PE
7565 * xml.c (make_dom): Now static.
7566
8f5201ae
PE
7567 * composite.c (composition_compute_stop_pos): Rename local to
7568 avoid shadowing.
b246f932
PE
7569 (composition_reseat_it): Remove unused locals.
7570 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7571 (composition_update_it): Mark var as initialized.
11b61122
PE
7572 (find_automatic_composition): Mark vars as initialized,
7573 with a FIXME (Bug#8290).
8f5201ae 7574
760fbc2c
PE
7575 character.h: Rename locals to avoid shadowing.
7576 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7577 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7578 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7579 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7580 to avoid shadowing.
7581
ff08eb85
PE
7582 * textprop.c (property_change_between_p): Remove; unused.
7583
fc7bf025
PE
7584 * intervals.c (interval_start_pos): Now static.
7585
235d7abc
PE
7586 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7587
44f230aa
SM
7588 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7589 Rename locals to avoid shadowing.
3e7d6594 7590
50060332
PE
7591 * sound.c (wav_play, au_play, Fplay_sound_internal):
7592 Fix pointer signedness.
d01f234b 7593 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7594 (wav_play): Initialize a variable to 0, to prevent undefined
7595 behavior (Bug#8278).
50060332 7596
c4fc4e30
PE
7597 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7598
918436ed
PE
7599 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7600
c939f91b
PE
7601 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7602 clobbering (Bug#8298).
b9c7f648
PE
7603 * sysdep.c (sys_subshell): Likewise.
7604 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7605
6bd8c144
PE
7606 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7607 This should get cleaned up, so that child_setup has the
7608 same signature on all platforms.
7609
7710357c 7610 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7611 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7612
c59da222
CY
76132011-03-22 Chong Yidong <cyd@stupidchicken.com>
7614
7615 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7616 not to be necessary, and produces flickering.
7617
66b87493
GM
76182011-03-20 Glenn Morris <rgm@gnu.org>
7619
7620 * config.in: Remove file.
7621
45b6f6d5
JB
76222011-03-20 Juanma Barranquero <lekktu@gmail.com>
7623
7624 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7625 are now in src/globals.h.
7626 (syms_of_minibuf): Remove spurious & from previous change.
7627
3ec03f7e
LL
76282011-03-20 Leo <sdl.web@gmail.com>
7629
7630 * minibuf.c (completing-read-function): New variable.
7631 (completing-read-default): Rename from completing-read.
7632 (completing-read): Call completing-read-function.
7633
b14e3e21
CY
76342011-03-19 Juanma Barranquero <lekktu@gmail.com>
7635
7636 * xfaces.c (Fx_load_color_file):
7637 Read color file from absolute filename (bug#8250).
7638
f2b726e6
JB
76392011-03-19 Juanma Barranquero <lekktu@gmail.com>
7640
7641 * makefile.w32-in: Update dependencies.
7642
09f6ff02
EZ
76432011-03-17 Eli Zaretskii <eliz@gnu.org>
7644
7645 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7646
29a6015a
PE
76472011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7648
a3a6c54e
PE
7649 Fix more problems found by GCC 4.5.2's static checks.
7650
b766f867
PE
7651 * process.c (make_serial_process_unwind, send_process_trap):
7652 (sigchld_handler): Now static.
7653
be02381c
PE
7654 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7655 That way, the code declares only the vars that it needs.
7656 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7657 * s/cygwin.h (PTY_ITERATION): Likewise.
7658 * s/darwin.h (PTY_ITERATION): Likewise.
7659 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7660
57048744
PE
7661 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7662 * process.c (allocate_pty): Don't declare stb unless it's needed.
7663
7914961c 7664 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7665 (CONSTANTLIM): Remove; unused.
7666 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7667 Define only if needed.
7914961c 7668
b3967b18
PE
7669 * unexelf.c (unexec): Name an expression,
7670 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7671 Use a different way to cause a compilation error if anyone uses
7672 n rather than nn, a way that does not involve shadowing.
73366a00 7673 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7674
29a6015a
PE
7675 * deps.mk (unexalpha.o): Remove; unused.
7676
43cfc33e 7677 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7678 * unexec.h: New file.
ce701a33
PE
7679 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7680 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7681 Depend on unexec.h.
7682 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7683 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7684 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7685 Change as necessary to match prototype in unexec.h.
ce701a33 7686
01f44d5a
PE
7687 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7688 shadowing.
4f63c6bb 7689 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7690
a6670b0b
PE
7691 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7692 Rename locals to avoid shadowing.
7693
cef2010d 7694 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7695 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7696
d4d7173a
PE
7697 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7698
f08b802a
PE
7699 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7700 warning when compiling print.c.
7701
3ddb0639
PE
7702 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7703 instead of using an uninitialized var.
5ad03b97 7704 (font_sort_entities): Mark var as initialized.
3ddb0639 7705
170a2692
PE
7706 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7707
e663c700
PE
7708 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7709 pointers to constants.
89bc529a 7710 (font_parse_fcname): Remove unused vars.
7b81e2d0 7711 (font_delete_unmatched): Now static.
ea838e10 7712 (font_get_spec): Remove; unused.
13a547c6
PE
7713 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7714 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7715 Rename or move locals to avoid shadowing.
e663c700 7716
2a80c887 7717 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7718 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7719
1384fa33 7720 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7721 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7722
8b2c52e9
PE
7723 * alloc.c (mark_backtrace): Move decl from here ...
7724 * lisp.h: ... to here, so that it can be checked.
7725
475545b5 7726 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7727 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7728 (lisp_indirect_variable): Name an expression,
7729 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7730 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7731
b1349114 7732 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7733 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7734 Use const pointer when appropriate.
b1349114 7735
a2928364
PE
7736 * lisp.h (get_system_name, get_operating_system_release):
7737 Move decls here, to check interfaces.
7738 * process.c (get_operating_system_release): Move decl to lisp.h.
7739 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7740 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7741 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7742 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7743 (Fformat_time_string, Fencode_time, Finsert_char):
7744 (Ftranslate_region_internal, Fformat):
7745 Rename or remove local vars to avoid shadowing.
9710023e 7746 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7747
a415e694
PE
7748 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7749 avoid shadowing.
7750
8ef4622d
PE
7751 * lisp.h (eassert): Check that the argument compiles, even if
7752 ENABLE_CHECKING is not defined.
7753
946f9a5b
PE
7754 * data.c (Findirect_variable): Name an expression, to avoid
7755 gcc -Wbad-function-cast warning.
112396d6 7756 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7757 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7758 (Fmake_variable_buffer_local, Fmake_local_variable):
7759 Mark variables as initialized.
52746918 7760 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7761
e5aab7e7 7762 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7763 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7764 Rename locals to avoid shadowing.
dff45157
PE
7765 (mark_stack): Move local variables into the #ifdef region where
7766 they're used.
7bc26fdb
PE
7767 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7768 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7769 needed otherwise.
7770 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7771 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7772 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7773
e5aab7e7
PE
7774 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7775 avoids undefined behavior in theory.
7776
4da60324
PE
7777 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7778
88043301
PE
7779 Use functions, not macros, for up- and down-casing (Bug#8254).
7780 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7781 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7782 to use the following functions instead of these macros.
7783 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7784 EMACS_INT, since callers assume the returned value fits in int.
7785 (upcase1): Likewise, for UPCASE_TABLE.
7786 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7787 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7788 the race-condition problem in the old DOWNCASE.
88043301 7789
19ed5445
PE
7790 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7791 Rename locals to avoid shadowing.
7792 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7793 (regex_compile, re_search_2, re_match_2_internal):
7794 Remove unused local vars.
952db0d7
PE
7795 (FREE_VAR): Rewrite so as not to use empty "else",
7796 which gcc can warn about.
da053e48 7797 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7798 (RETALLOC_IF): Define only if needed.
7799 (WORDCHAR_P): Likewise. This one is never needed, but is used
7800 only in a comment talking about a compiler bug, so put inside
7801 the #if 0 of that comment.
7802 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7803 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7804 Remove; unused.
19ed5445 7805
1f3561e4 7806 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7807 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7808 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7809
ded6f8f7
PE
7810 * search.c (simple_search): Remove unused var.
7811
dbd37a95
PE
7812 * dired.c (compile_pattern): Move decl from here ...
7813 * lisp.h: ... to here, so that it can be checked.
7814 (struct re_registers): New forward decl.
7815
7e47afad
PE
7816 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7817
85f24f61
PE
7818 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7819 All uses changed.
7820 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7821 Rename locals to avoid shadowing.
5671df8f 7822 (Fvertical_motion): Mark locals as initialized.
85f24f61 7823
181aa2be 7824 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7825 (casify_region): Mark local as initialized.
181aa2be 7826
930d429c
PE
7827 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7828
7082eac6
PE
7829 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7830 New macros, so that the caller can use some names other than
7831 gcpro1, gcpro2, etc.
7832 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7833 of the new macros.
7834 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7835 argument, for consistency with GCPRO2_VAR, etc: it is now the
7836 prefix of the variable, not the variable itself. All uses
7837 changed.
38b2c076
PE
7838 * dired.c (directory_files_internal, file_name_completion):
7839 Rename locals to avoid shadowing.
7840
15206ed9
PE
7841 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7842 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7843 dired.c's scmp function, had undefined behavior.
7844 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7845 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7846 * buffer.h: ... to here, because these macros use current_buffer,
7847 and the new implementation with inline functions needs to have
7848 current_buffer in scope now, rather than later when the macros
7849 are used.
7850 (downcase, upcase1): New static inline functions.
7851 (DOWNCASE, UPCASE1): Reimplement using these functions.
7852 This avoids undefined behavior in expressions like
7853 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7854 from race conditions in accessing the global variables
7855 case_temp1 and case_temp2.
7856 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7857 * lisp.h (case_temp1, case_temp2): Remove their decls.
7858 * character.h (ASCII_CHAR_P): Move from here ...
7859 * lisp.h: ... to here, so that the inline functions mentioned
7860 above can use them.
7861
4a6bea26
PE
7862 * dired.c (directory_files_internal_unwind): Now static.
7863
f14b7e14
PE
7864 * fileio.c (file_name_as_directory, directory_file_name):
7865 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7866 Now static.
2893f146
PE
7867 (file_name_as_directory): Use const pointers when appropriate.
7868 (Fexpand_file_name): Likewise. In particular, newdir might
7869 point at constant storage, so make it a const pointer.
fd4ead52 7870 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7871 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7872 signedness issues.
f839df0c
PE
7873 (Fset_file_times, Finsert_file_contents, auto_save_error):
7874 Rename locals to avoid shadowing.
f14b7e14 7875
5716756e 7876 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7877 (Ftry_completion, Fall_completions): Rename or remove locals
7878 to avoid shadowing.
5716756e 7879
b4c3046a
PE
7880 * marker.c (bytepos_to_charpos): Remove; unused.
7881
b45db522
PE
7882 * lisp.h (verify_bytepos, count_markers): New decls,
7883 so that gcc does not warn that these functions aren't declared.
7884
85876d07
PE
7885 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7886 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7887 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7888 (copy_text): Remove unused local var.
85876d07 7889
03d78a21 7890 * filelock.c (within_one_second): Now static.
b3dd38ab 7891 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7892
5df8f01b
PE
7893 * buffer.c (fix_overlays_before): Mark locals as initialized.
7894 (fix_start_end_in_overlays): Likewise. This function should be
7895 simplified by using pointers-to-pointers, but that's a different
7896 matter.
b1d876f1 7897 (switch_to_buffer_1): Now static.
8f54f30a
PE
7898 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7899 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7900
a70072c9 7901 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7902 Fix pointer signedness issue.
edced198
PE
7903 (sys_subshell): Mark local as volatile if checking for lint,
7904 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7905 (MAXPATHLEN): Define only if needed.
a70072c9 7906
a0977c44
PE
7907 * process.c (serial_open, serial_configure): Move decls from here ...
7908 * systty.h: ... to here, so that they can be checked.
7909
a884fdcc
PE
7910 * fns.c (get_random, seed_random): Move extern decls from here ...
7911 * lisp.h: ... to here, so that they can be checked.
7912
604efe86 7913 * sysdep.c (reset_io): Now static.
b8950c94 7914 (wait_for_termination_signal): Remove; unused.
604efe86 7915
38fc62d9
PE
7916 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7917 (copy_keymap_item, append_key, push_text_char_description):
7918 Now static.
1004a21a 7919 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7920 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7921 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7922 (describe_map_tree):
7923 Rename locals to avoid shadowing.
38fc62d9 7924
2f2650da
PE
7925 * keyboard.c: Declare functions static if they are not used elsewhere.
7926 (echo_char, echo_dash, cmd_error, top_level_2):
7927 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7928 (read_char, kbd_buffer_get_event, make_lispy_position):
7929 (make_lispy_event, make_lispy_movement, apply_modifiers):
7930 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7931 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7932 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7933 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7934 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7935
a053e86c 7936 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7937 (mark_kboards): Move decl here ...
7938 * alloc.c (mark_kboards): ... from here.
a053e86c 7939
4752793e
PE
7940 * lisp.h (force_auto_save_soon): New decl.
7941
74f10ca7 7942 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7943 (DEFINE_DUMMY_FUNCTION): New macro.
7944 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7945 Use it.
c03cd23f
PE
7946 (main): Add casts to avoid warnings
7947 if GCC considers string literals to be constants.
74f10ca7 7948
022e70d4
PE
7949 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7950
59d6fe83
PE
7951 * dbusbind.c: Pointer signedness fixes.
7952 (xd_signature, xd_append_arg, xd_initialize):
7953 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7954 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7955 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7956 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7957
78320123
PE
7958 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7959 if GCC considers string literals to be constants.
49cebcca 7960 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7961
35ac2a97
SM
79622011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7963
fb103ca9
SM
7964 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7965 (print_preprocess, print_object): New macro to fix last change.
7966
35ac2a97
SM
7967 * print.c (print_preprocess): Don't forget font objects.
7968
62973b41
JB
79692011-03-16 Juanma Barranquero <lekktu@gmail.com>
7970
7971 * emacs.c (USAGE3): Doc fixes.
7972
0e48bb22
AS
79732011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7974
7975 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7976 structure.
7977
7684e57b
JB
79782011-03-14 Juanma Barranquero <lekktu@gmail.com>
7979
7980 * lisp.h (VWindow_system, Qfile_name_history):
7981 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7982 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7983 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7984
7985 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7986 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7987
7988 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7989 * w32console.c (detect_input_pending, read_input_pending)
7990 (encode_terminal_code):
7991 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7992 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7993 (w32_system_caret_y, Qfile_name_history):
7994 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7995 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7996 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7997 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7998 * w32proc.c (Qlocal, report_file_error):
7999 * w32term.c (Vwindow_system, updating_frame):
8000 * w32uniscribe.c (initialized, uniscribe_font_driver):
8001 Remove unneeded extern declarations.
8002
2aa46d6c
CY
80032011-03-14 Chong Yidong <cyd@stupidchicken.com>
8004
c96bbc66 8005 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8006
cffc6f3b
CY
80072011-03-13 Chong Yidong <cyd@stupidchicken.com>
8008
8009 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8010 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8011 These macros can no longer be used for assignment.
8012
44f230aa
SM
8013 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8014 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8015 (record_buffer_markers, fetch_buffer_markers): New functions for
8016 recording and fetching special buffer markers.
8017 (set_buffer_internal_1, set_buffer_temp): Use them.
8018
8019 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8020
8021 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8022
8023 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8024 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8025
8026 * xdisp.c (hscroll_window_tree):
8027 (reconsider_clip_changes): Use PT instead of BUF_PT.
8028
d251f04b
EZ
80292011-03-13 Eli Zaretskii <eliz@gnu.org>
8030
8031 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8032 $(EMACS_ROOT)/lib/intprops.h.
8033
f0c77cd1
PE
80342011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8035
3eca4629
PE
8036 Fix more problems found by GCC 4.5.2's static checks.
8037
7c86ee98
PE
8038 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8039 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8040 (xg_free_frame_widgets): Make it clear that a local variable is
8041 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8042 (gdk_window_get_screen): Make it clear that this macro is needed
8043 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8044 (int_gtk_range_get_value): New function, which avoids a diagnostic
8045 from gcc -Wbad-function-cast.
8046 (xg_set_toolkit_scroll_bar_thumb): Use it.
8047 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8048 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8049 (get_utf8_string, xg_get_file_with_chooser):
8050 Rename locals to avoid shadowing.
8051 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8052
41729b81
PE
8053 * xgselect.c (xg_select): Remove unused var.
8054
f0c77cd1
PE
8055 * image.c (four_corners_best): Mark locals as initialized.
8056 (gif_load): Initialize transparent_p to zero (Bug#8238).
8057 Mark another local as initialized.
ec6cf4c6 8058 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8059
ce0ad53d 8060 * image.c (clear_image_cache): Now static.
d5d5a617 8061 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8062 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8063 (x_edge_detection): Remove unnecessary cast that
8064 gcc -Wbad-function-cast diagnoses.
2037898d 8065 (gif_load): Fix pointer signedness.
6ae141d6
PE
8066 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8067 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8068
33383987 80692011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8070
d32df629
PE
8071 Improve quality of tests for time stamp overflow.
8072 For example, without this patch (encode-time 0 0 0 1 1
8073 1152921504606846976) returns the obviously-bogus value (-948597
8074 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8075 reports time overflow. See
8076 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8077 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8078 * editfns.c: Include limits.h and intprops.h.
8079 (TIME_T_MIN, TIME_T_MAX): New macros.
8080 (time_overflow): Move earlier, to before first use.
8081 (hi_time, lo_time): New functions, for an accurate test for
8082 out-of-range times.
8083 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8084 (Fget_internal_run_time): Don't assume time_t fits in int.
8085 (make_time): Use list2 instead of Fcons twice.
8086 (Fdecode_time): More accurate test for out-of-range times.
8087 (check_tm_member): New function.
8088 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8089 (lisp_time_argument): Don't rely on undefined left-shift and
8090 right-shift behavior when checking for time stamp overflow.
8be6f318 8091
fe31d94c
PE
8092 * editfns.c (time_overflow): New function, refactoring common code.
8093 (Fformat_time_string, Fdecode_time, Fencode_time):
8094 (Fcurrent_time_string): Use it.
8095
8be6f318
PE
8096 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8097 * dired.c (make_time): Move to ...
8098 * editfns.c (make_time): ... here.
8099 * systime.h: Note the move.
8100
09d9db2c 81012011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8102
126bc0dc
YM
8103 * fringe.c (update_window_fringes): Remove unused variables.
8104
c47cbdfd
YM
8105 * unexmacosx.c (copy_data_segment): Also copy __got section.
8106 (Bug#8223)
8107
7ac80be9
EZ
81082011-03-12 Eli Zaretskii <eliz@gnu.org>
8109
c96bbc66 8110 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8111 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8112 Constify `char *' arguments and their references according to
8113 prototypes in tparam.h.
8114
ecb0f94d 8115 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8116
7ac80be9
EZ
8117 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8118 Adapt all references accordingly.
8119
8120 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8121
ef1fd07e
TT
81222011-03-11 Tom Tromey <tromey@redhat.com>
8123
8124 * buffer.c (syms_of_buffer): Remove obsolete comment.
8125
7ef4b50c
EZ
81262011-03-11 Eli Zaretskii <eliz@gnu.org>
8127
8128 * termhooks.h (encode_terminal_code): Declare prototype.
8129
8130 * msdos.c (encode_terminal_code): Don't declare prototype.
8131
8132 * term.c (encode_terminal_code): Now external again, used by
8133 w32console.c and msdos.c.
8134
44f230aa
SM
8135 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8136 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8137
4b1ec863 81382011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8139
1714f52b 8140 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8141
4b1ec863
PE
8142 * fringe.c (update_window_fringes): Mark locals as initialized
8143 (Bug#8227).
8144 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8145
524c7aa6
PE
8146 * alloc.c (mark_fringe_data): Move decl from here ...
8147 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8148 to check its interface.
8149 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8150
a5c0af81 8151 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8152 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8153 (fontset_font): Mark local as initialized.
a9a06e0b 8154 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8155
b4716021
PE
8156 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8157
811e9bac 8158 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8159 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8160 (x_own_selection, Fx_disown_selection_internal): Rename locals
8161 to avoid shadowing.
8162 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8163
7e3ab302
PE
8164 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8165 so that the caller can use some name other than gcpro1.
8166 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8167 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8168 (Fx_backspace_delete_keys_p):
8169 Use them to avoid shadowing, and rename vars to avoid shadowing.
8170 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8171 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8172 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8173 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8174 Remove unused locals.
7e3ab302
PE
8175 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8176 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8177 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8178 macros.
f78faa98 8179
e2b13473
PE
8180 * xterm.h (x_mouse_leave): New decl.
8181
77f23912
PE
8182 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8183 Remove unused functions.
cdf4ba58
PE
8184 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8185 (x_calc_absolute_position): Now static.
7411c686 8186 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8187 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8188 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8189 unless they are used.
38d0b34a
PE
8190 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8191 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8192 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8193 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8194 (x_error_catcher, x_connection_closed, x_error_handler):
8195 (x_error_quitter, xembed_send_message, x_iconify_frame):
8196 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8197 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8198 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8199
44f230aa
SM
8200 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8201 Rename or move locals to avoid shadowing.
6b463e58 8202 (tty_defined_color, merge_face_heights): Now static.
5967d051 8203 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8204 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8205 does not deduce is never used uninitialized.
73719eba
PE
8206 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8207 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8208
426994c3 8209 * terminal.c (store_terminal_param): Now static.
5489860b 8210
032f1620 8211 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8212 (set_frame_menubar): Remove unused local.
d4323972 8213 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8214 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8215 since they might point to immutable storage.
281585b0
PE
8216 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8217 since it's unused otherwise.
032f1620 8218
367c19e5 8219 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8220 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8221 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8222 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8223 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8224 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8225 does not deduce are never used uninitialized.
70739cbe 8226
07b48fa9
PE
8227 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8228
8868a238 8229 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8230 * window.c (window_loop, size_window):
8231 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8232
7e5cf297 8233 * window.c (display_buffer): Now static.
d6550a9f
PE
8234 (size_window): Mark variables that gcc -Wuninitialized
8235 does not deduce are never used uninitialized.
a586633d
PE
8236 * window.h (check_all_windows): New decl, to forestall
8237 gcc -Wmissing-prototypes diagnostic.
5b555da1 8238 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8239
f6095868
PE
8240 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8241 shadowing.
8242 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8243 Include <limits.h>.
8244 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8245 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8246 (load_charset_map): Mark variables that gcc -Wuninitialized
8247 does not deduce are never used uninitialized.
53df7c11 8248 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8249
f38b440c
PE
8250 * coding.c (coding_set_source, coding_set_destination):
8251 Use "else { /* comment */ }" rather than "else /* comment */;"
8252 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8253 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8254 a block, when the outer 'i' will do.
8255 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8256 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8257 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8258 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8259 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8260 Rename locals to avoid shadowing.
8261 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8262 * coding.c (emacs_mule_char, encode_invocation_designation):
8263 Now static, since they're not used elsewhere.
413bb2db 8264 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8265 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8266 (decode_coding_emacs_mule): Mark variables that gcc
8267 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8268 (detect_coding_iso_2022): Initialize a local variable that might
8269 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8270 this initialization is needed. (Bug#8211)
5f58e762
PE
8271 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8272 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8273 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8274 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8275 Remove unused macros.
f38b440c 8276
232b38b9 8277 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8278 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8279 * character.c (string_count_byte8): Likewise.
232b38b9 8280
fb90da1b
PE
8281 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8282 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8283
fb93dbc2
PE
8284 * chartab.c (copy_sub_char_table): Now static, since it's not used
8285 elsewhere.
5c156ace
PE
8286 (sub_char_table_ref_and_range, char_table_ref_and_range):
8287 Rename locals to avoid shadowing.
bbcd0949 8288 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8289
7d3b3862 8290 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8291 (BIDI_BOB): Remove unused macro.
7d3b3862 8292
6be7d3da
PE
8293 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8294 deduce are never used uninitialized.
c2ed9c8b 8295 * term.c (encode_terminal_code): Likewise.
6be7d3da 8296
75f8807f 8297 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8298
50938595
PE
8299 * tparam.h: New file.
8300 * term.c, tparam.h: Include it.
8301 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8302 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8303 Move these decls to tparam.h, and make them agree with what
8304 is actually in tparam.c. The previous trick of using incompatible
8305 decls in different modules does not conform to the C standard.
8306 All callers of tparam changed to use tparam's actual API.
8307 * tparam.c (tparam1, tparam, tgoto):
8308 Use const pointers where appropriate.
8309
fbceeba2
PE
8310 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8311 * cm.h (struct cm): Likewise.
8312 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8313 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8314 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8315 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8316 (turn_on_face, init_tty): Likewise.
8317 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8318
7f3f1250
PE
8319 * term.c (term_mouse_position): Rename local to avoid shadowing.
8320
e6ca6543
PE
8321 * alloc.c (mark_ttys): Move decl from here ...
8322 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8323
c40f8d15
AS
83242011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8325
8326 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8327
cfe0661d
JB
83282011-03-09 Juanma Barranquero <lekktu@gmail.com>
8329
8330 * search.c (compile_pattern_1): Remove argument regp, unused since
8331 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8332 (compile_pattern): Don't pass it.
8333
0afb4571
J
83342011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8335
8336 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8337 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8338 for ! HAVE_GTK3.
8339 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8340
8341 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8342
8343 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8344 gdk_window_get_screen, gdk_window_get_geometry,
8345 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8346 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8347 (xg_get_pixbuf_from_pixmap): New function.
8348 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8349 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8350 Call xg_get_pixbuf_from_pixmap instead of
8351 gdk_pixbuf_get_from_drawable.
8352 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8353 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8354 (xg_check_special_colors): Use GtkStyleContext and its functions
8355 for HAVE_GTK3.
8356 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8357 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8358 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8359 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8360 Call gtk_widget_get_preferred_size.
0afb4571
J
8361 (xg_frame_resized): gdk_window_get_geometry only takes 5
8362 parameters.
44f230aa
SM
8363 (xg_win_to_widget, xg_event_is_for_menubar):
8364 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8365 (xg_set_widget_bg): New function.
8366 (delete_cb): New function.
895009e1 8367 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8368 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8369 (xg_set_background_color): Call xg_set_widget_bg.
8370 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8371 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8372 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8373 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8374 if ! HAVE_GTK3.
8375 (update_frame_tool_bar): Call gtk_widget_hide.
8376 (xg_initialize): Use GDK_KEY_g.
8377
8378 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8379 if ! HAVE_GTK3
8380 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8381
8382 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8383 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8384 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8385
1c2cc4ef
JB
83862011-03-08 Juanma Barranquero <lekktu@gmail.com>
8387
8388 * w32xfns.c (select_palette): Check success of RealizePalette against
8389 GDI_ERROR, not zero.
8390
33383987 8391See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8392
8393;; Local Variables:
8394;; coding: utf-8
aac0c6e3
MR
8395;; End:
8396
33383987 8397 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8398
8399 This file is part of GNU Emacs.
8400
8401 GNU Emacs is free software: you can redistribute it and/or modify
8402 it under the terms of the GNU General Public License as published by
8403 the Free Software Foundation, either version 3 of the License, or
8404 (at your option) any later version.
8405
8406 GNU Emacs is distributed in the hope that it will be useful,
8407 but WITHOUT ANY WARRANTY; without even the implied warranty of
8408 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8409 GNU General Public License for more details.
8410
8411 You should have received a copy of the GNU General Public License
8412 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.