* bidi.c: Integer signedness and overflow fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0e926e56
PE
12011-07-07 Paul Eggert <eggert@cs.ucla.edu>
2
5b8ffbdd
PE
3 * bidi.c: Integer signedness and overflow fixes.
4 (bidi_cache_idx, bidi_cache_last_idx, bidi_cache_fetch_state)
5 (bidi_cache_search, bidi_cache_find_level_change)
6 (bidi_cache_iterator_state, bidi_cache_find, bidi_find_other_level_edge)
7 (bidi_dump_cached_states):
8 Don't arbitrarily limit cache indexes to int; use ptrdiff_t instead.
9 (bidi_cache_size): Use ptrdiff_t rather than size_t, as we prefer
10 signed integers.
11 (elsz): Make it a (signed) constant.
12 (bidi_cache_iterator_state): Check for size-calculation overflow.
13
903fe15d
PE
14 * alloc.c: Integer signedness and overflow fixes.
15 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
16 (__malloc_size_t): Default to size_t, not to int.
17 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
18 (Fgarbage_collect, mark_object_loop_halt, mark_object):
19 Prefer ptrdiff_t to size_t when either would do, as we prefer
20 signed integers.
21 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
22 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
23 Now const. Initialize with values that are in range even if char
24 is signed.
25 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
26 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
27 These functions do the right thing with sizes > 2**32.
28 (check_depth): Now ptrdiff_t, not int.
29 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
30 Adjust to new way of storing sizes. Check for size overflow bugs
31 in rest of code.
32 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
33 slightly wrong anyway, as it missed one instance of
34 XMALLOC_OVERRUN_CHECK_OVERHEAD.
35 (refill_memory_reserve): Omit needless cast to size_t.
36 (mark_object_loop_halt): Mark as externally visible.
37
ac82cc6a
PE
38 * xselect.c: Integer signedness and overflow fixes.
39 (Fx_register_dnd_atom, x_handle_dnd_message):
40 Use ptrdiff_t, not size_t, since we prefer signed.
41 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
42 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
43 x_dnd_atoms_size and x_dnd_atoms_length.
44
c2d1e36d
PE
45 * doprnt.c: Prefer signed to unsigned when either works.
46 * eval.c (verror):
47 * doprnt.c (doprnt):
48 * lisp.h (doprnt):
49 * xdisp.c (vmessage):
50 Use ptrdiff_t, not size_t, when using or implementing doprnt,
51 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
52 prefer signed arithmetic to avoid comparison confusion.
53 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
54 but is a bit tricky.
55
0e926e56
PE
56 Assume freestanding C89 headers, string.h, stdlib.h.
57 * data.c, doprnt.c, floatfns.c, print.c:
58 Include float.h unconditionally.
59 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
60 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
61 * regex.c: Likewise for stddef.h, string.h.
62 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
63 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
64 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
65 (STDC_HEADERS): Remove obsolete defines.
66 * sysdep.c: Include limits.h unconditionally.
67
59361254 682011-07-06 Paul Eggert <eggert@cs.ucla.edu>
d8ed26bd 69
9cfdb3ec
PE
70 Assume support for memcmp, memcpy, memmove, memset.
71 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
72 * regex.c (memcmp, memcpy):
73 Remove; we assume C89 now.
74
75 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
76 (__malloc_safe_bcopy): Remove; no longer needed.
77
6089c567
PE
78 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
79 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
80 well either way, and we prefer signed to unsigned.
81
22b4128e
PE
822011-07-06 Paul Eggert <eggert@cs.ucla.edu>
83
84 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
85 * alloc.c (mark_buffer):
86 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
87 (clone_per_buffer_values): Don't assume that
22b4128e
PE
88 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
89 This isn't true in general, and it's particularly not true
90 if Emacs is configured with --with-wide-int.
91 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
92 New macros, used in the buffer.c change.
93
869795d6
JD
942011-07-05 Jan Djärv <jan.h.d@swipnet.se>
95
96 * xsettings.c: Use both GConf and GSettings if both are available.
97 (store_config_changed_event): Add comment.
98 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
99 (store_tool_bar_style_changed): New functions.
100 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
101 (struct xsettings): Move font inside HAVE_XFT.
102 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
103 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
104 Move inside HAVE_XFT.
105 (something_changed_gsettingsCB): Renamed from something_changedCB.
106 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
107 also.
108 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
109 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
110 (something_changed_gconfCB): Renamed from something_changedCB.
111 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
112 (parse_settings): Move check for font inside HAVE_XFT.
113 (read_settings, apply_xft_settings): Add comment.
114 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
115 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
116 call store_font_name_changed.
117 (xft_settings_event): Add comment.
118 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
119 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
120 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
121 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
122 (xsettings_initialize): Call init_gsettings last.
123 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
124 comment.
125
d8ed26bd
PE
1262011-07-05 Paul Eggert <eggert@cs.ucla.edu>
127
128 Random fixes. E.g., (random) never returned negative values.
129 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
130 subseconds part to the entropy, as that's a bit more random.
131 Prefer signed to unsigned, since the signedness doesn't matter and
132 in general we prefer signed. When given a limit, use a
133 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
134 latter isn't right if USE_2_TAGS_FOR_INTS.
135 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
136 not 0..VALMASK. Don't discard "excess" bits that random () returns.
137
cabf1cac
SM
1382011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
139
140 * textprop.c (text_property_stickiness):
141 Obey Vtext_property_default_nonsticky.
142 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
143 * w32fns.c (syms_of_w32fns):
144 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
145
6e9b2be9
PE
1462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
147
148 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
149 This is more efficient than Ffile_directory_p and avoids a minor race.
150
90186c68
LMI
1512011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
152
7c301272
LMI
153 * buffer.c (Foverlay_put): Say what the return value is
154 (bug#7835).
155
c4f2d8d4
LMI
156 * fileio.c (barf_or_query_if_file_exists): Check first if the file
157 is a directory before asking whether to use the file name
158 (bug#7564).
ad637907
LMI
159 (barf_or_query_if_file_exists): Make the "File is a directory"
160 error be more correct.
c4f2d8d4 161
90186c68
LMI
162 * fns.c (Frequire): Remove the mention of the .gz files, since
163 that's installation-specific, but keep the mention of
164 `get-load-suffixes'.
165
da64016e
PE
1662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
167
168 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
169 Report string overflow if the output is too long.
170
7d47b580
JB
1712011-07-04 Juanma Barranquero <lekktu@gmail.com>
172
a555cb87
JB
173 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
174 (syms_of_gnutls): Remove duplicate DEFSYM for
175 Qgnutls_bootprop_verify_hostname_error, an error for
176 Qgnutls_bootprop_verify_error (which is no longer used).
177
7d47b580
JB
178 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
179 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
180 Also (re)move comments that are misplaced or no longer relevant.
181
1e49bfab
LMI
1822011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
183
184 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
185
1485f4c0
CY
1862011-07-03 Chong Yidong <cyd@stupidchicken.com>
187
188 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
189 and background color parameters if they have been changed.
190
a9ab721e
LMI
1912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
192
193 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
194
cf7cff57
PE
1952011-07-03 Paul Eggert <eggert@cs.ucla.edu>
196
2e13213d
PE
197 * xsettings.c (SYSTEM_FONT): Define only when used.
198 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
199
cf7cff57
PE
200 * keymap.c (access_keymap_1): Now static.
201
7a8e04f7
CY
2022011-07-02 Chong Yidong <cyd@stupidchicken.com>
203
204 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
205 leave any prefix arg for the up event (Bug#1586).
206
61352f62
LMI
2072011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
208
69bb1ef7
LMI
209 * lread.c (syms_of_lread): Mention single symbols defined by
210 `defvar' or `defconst' (bug#7154).
211
61352f62 212 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 213 (Frequire): Mention get-load-suffixes.
61352f62 214
28545e04
MR
2152011-07-02 Martin Rudalics <rudalics@gmx.at>
216
217 * window.h (window): Remove clone_number slot.
218 * window.c (Fwindow_clone_number, Fset_window_clone_number):
219 Remove.
220 (make_parent_window, make_window, saved_window)
221 (Fset_window_configuration, save_window_save): Don't deal with
222 clone numbers.
223 * buffer.c (Qclone_number): Remove declaration.
224 (sort_overlays, overlay_strings): Don't deal with clone numbers.
225
3349e122
SM
2262011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
227
228 Add multiple inheritance to keymaps.
229 * keymap.c (Fmake_composed_keymap): New function.
230 (Fset_keymap_parent): Simplify.
231 (fix_submap_inheritance): Remove.
232 (access_keymap_1): New function extracted from access_keymap to handle
233 embedded parents and handle lists of maps.
234 (access_keymap): Use it.
235 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
236 (Fcopy_keymap): Handle embedded parents.
237 (Fcommand_remapping, define_as_prefix): Simplify.
238 (Fkey_binding): Simplify.
239 (syms_of_keymap): Move minibuffer-local-completion-map,
240 minibuffer-local-filename-completion-map,
241 minibuffer-local-must-match-map, and
242 minibuffer-local-filename-must-match-map to Elisp.
243 (syms_of_keymap): Defsubr make-composed-keymap.
244 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
245 (parse_menu_item): Trivial simplification.
246
3279eb87
GM
2472011-07-01 Glenn Morris <rgm@gnu.org>
248
249 * Makefile.in (SETTINGS_LIBS): Fix typo.
250
4550efdf
KI
2512011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
252
253 * coding.c (Fencode_coding_string): Record the last coding system
254 used, as the function doc string says (bug#8738).
255
0949d2b6
JD
2562011-07-01 Jan Djärv <jan.h.d@swipnet.se>
257
258 * xsettings.c (store_monospaced_changed): Take new font as arg and
259 check for change against current_mono_font.
260 (EMACS_TYPE_SETTINGS): Remove this and related defines.
261 (emacs_settings_constructor, emacs_settings_get_property)
262 (emacs_settings_set_property, emacs_settings_class_init)
263 (emacs_settings_init, gsettings_obj): Remove.
264 (something_changedCB): New function for HAVE_GSETTINGS.
265 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
266 with value as argument.
267 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
268 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 269 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
270 "changed".
271
272 * xgselect.c: Add defined (HAVE_GSETTINGS).
273 (xgselect_initialize): Ditto.
274
275 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
276 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
277 xg_select.
278
bbc6b304
PE
2792011-07-01 Paul Eggert <eggert@cs.ucla.edu>
280
281 * eval.c (struct backtrace): Simplify and port the data structure.
282 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
283 signed bit field, as this assumption is not portable and it makes
284 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
285 "char debug_on_exit : 1" as this is not portable either; instead,
286 use the portable "unsigned int debug_on_exit : 1". Remove unused
287 member evalargs. Remove obsolete comments about cc bombing out.
288
9851bfc5
JD
2892011-06-30 Jan Djärv <jan.h.d@swipnet.se>
290
51bb811f 291 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
292 Let HAVE_GSETTINGS override HAVE_GCONF.
293 (store_monospaced_changed): New function.
294 (EMACS_SETTINGS): A new type derived from GObject to handle
295 GSettings notifications.
296 (emacs_settings_constructor, emacs_settings_get_property)
297 (emacs_settings_set_property, emacs_settings_class_init):
298 New functions.
299 (gsettings_client, gsettings_obj): New variables.
300 (GSETTINGS_SCHEMA): New define.
301 (something_changedCB): Call store_monospaced_changed.
302 (init_gsettings): New function.
303 (xsettings_initialize): Call init_gsettings.
304 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
305 to NULL.
306
307 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
308 GCONF_CFLAGS/LIBS.
309
5386012d
MR
3102011-06-29 Martin Rudalics <rudalics@gmx.at>
311
312 * window.c (resize_root_window, grow_mini_window)
313 (shrink_mini_window): Rename Qresize_root_window to
314 Qwindow_resize_root_window and Qresize_root_window_vertically to
315 Qwindow_resize_root_window_vertically.
316
f13e0b08
PE
3172011-06-28 Paul Eggert <eggert@cs.ucla.edu>
318
319 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
320
94515237
JB
3212011-06-27 Juanma Barranquero <lekktu@gmail.com>
322
323 * makefile.w32-in: Redesign dependencies so they reflect more
324 clearly which files are directly included by each source file,
325 and not through other includes.
326
e43b6e43
MR
3272011-06-27 Martin Rudalics <rudalics@gmx.at>
328
329 * buffer.c (Qclone_number): Declare static and DEFSYM it.
330 (sort_overlays, overlay_strings): When an overlay's clone number
331 matches the window's clone number process the overlay even if
332 the overlay's window property doesn't match the current window.
333
d68443dc
MR
334 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
335 (Fwindow_hchild): Rename to Fwindow_left_child.
336 (Fwindow_next): Rename to Fwindow_next_sibling.
337 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
338 (resize_window_check): Rename to window_resize_check.
339 (resize_window_apply): Rename to window_resize_apply.
340 (Fresize_window_apply): Rename to Fwindow_resize_apply.
341 (Fdelete_other_windows_internal, resize_frame_windows)
342 (Fsplit_window_internal, Fdelete_window_internal)
343 (grow_mini_window, shrink_mini_window)
344 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 345
c7e73be5
JD
3462011-06-26 Jan Djärv <jan.h.d@swipnet.se>
347
348 * emacsgtkfixed.h: State that this is only used with Gtk+3.
349 (emacs_fixed_set_min_size): Remove.
350 (emacs_fixed_new): Take frame as argument.
351
352 * emacsgtkfixed.c: State that this is only used with Gtk+3.
353 (_EmacsFixedPrivate): Remove minwidth/height.
354 Add struct frame *f.
355 (emacs_fixed_init): Initialize priv->f.
356 (get_parent_class, emacs_fixed_set_min_size): Remove.
357 (emacs_fixed_new): Set priv->f to argument.
358 (emacs_fixed_get_preferred_width)
359 (emacs_fixed_get_preferred_height): Use min_width/height from
360 frames size_hint to set minimum and natural (Bug#8919).
361 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
362 and use min_width/height from frames size_hint to set
363 min_width/height (Bug#8919).
364
365 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
366 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
367 Fix indentation.
c7e73be5 368
cf99dcf8
EZ
3692011-06-26 Eli Zaretskii <eliz@gnu.org>
370
371 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
372 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
373 called at ZV.
374
029529ac
CY
3752011-06-26 Chong Yidong <cyd@stupidchicken.com>
376
377 * process.c (wait_reading_process_output): Bypass select if
378 waiting for a cell while ignoring keyboard input, and input is
379 pending. Suggested by Jan Djärv (Bug#8869).
380
7a7ef429
PE
3812011-06-25 Paul Eggert <eggert@cs.ucla.edu>
382
383 Use gnulib's dup2 module instead of rolling our own.
384 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
385
11fdef7d 3862011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
387
388 * dispnew.c (scrolling_window): Before scrolling, turn off a
389 mouse-highlight in the window being scrolled.
390
cd3520a4
JB
3912011-06-24 Juanma Barranquero <lekktu@gmail.com>
392
393 Move DEFSYM to lisp.h and use everywhere.
394
395 * character.h (DEFSYM): Move declaration...
396 * lisp.h (DEFSYM): ...here.
397
398 * gnutls.c:
399 * minibuf.c:
400 * w32menu.c:
401 * w32proc.c:
402 * w32select.c: Don't include character.h.
403
404 * alloc.c (syms_of_alloc):
405 * buffer.c (syms_of_buffer):
406 * bytecode.c (syms_of_bytecode):
407 * callint.c (syms_of_callint):
408 * casefiddle.c (syms_of_casefiddle):
409 * casetab.c (init_casetab_once):
410 * category.c (init_category_once, syms_of_category):
411 * ccl.c (syms_of_ccl):
412 * cmds.c (syms_of_cmds):
413 * composite.c (syms_of_composite):
414 * dbusbind.c (syms_of_dbusbind):
415 * dired.c (syms_of_dired):
416 * dispnew.c (syms_of_display):
417 * doc.c (syms_of_doc):
418 * editfns.c (syms_of_editfns):
419 * emacs.c (syms_of_emacs):
420 * eval.c (syms_of_eval):
421 * fileio.c (syms_of_fileio):
422 * fns.c (syms_of_fns):
423 * frame.c (syms_of_frame):
424 * fringe.c (syms_of_fringe):
425 * insdel.c (syms_of_insdel):
426 * keymap.c (syms_of_keymap):
427 * lread.c (init_obarray, syms_of_lread):
428 * macros.c (syms_of_macros):
429 * msdos.c (syms_of_msdos):
430 * print.c (syms_of_print):
431 * process.c (syms_of_process):
432 * search.c (syms_of_search):
433 * sound.c (syms_of_sound):
434 * syntax.c (init_syntax_once, syms_of_syntax):
435 * terminal.c (syms_of_terminal):
436 * textprop.c (syms_of_textprop):
437 * undo.c (syms_of_undo):
438 * w32.c (globals_of_w32):
439 * window.c (syms_of_window):
440 * xdisp.c (syms_of_xdisp):
441 * xfaces.c (syms_of_xfaces):
442 * xfns.c (syms_of_xfns):
443 * xmenu.c (syms_of_xmenu):
444 * xsettings.c (syms_of_xsettings):
445 * xterm.c (syms_of_xterm): Use DEFSYM.
446
4228cf16
TZ
4472011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
448
cd3520a4 449 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 450
7fcccf1e
PE
4512011-06-23 Paul Eggert <eggert@cs.ucla.edu>
452
7efb4e0e
PE
453 Integer and buffer overflow fixes (Bug#8873).
454
ff5844ad
PE
455 * print.c (printchar, strout): Check for string overflow.
456 (PRINTPREPARE, printchar, strout):
457 Don't set size unless allocation succeeds.
458
90532f02
PE
459 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
460 for sizes. Check for string overflow more accurately.
461 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
462
6d84508d
PE
463 * macros.c: Integer and buffer overflow fixes.
464 * keyboard.h (struct keyboard.kbd_macro_bufsize):
465 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
466 Use ptrdiff_t, not int, for sizes.
467 Don't increment bufsize until after realloc succeeds.
468 Check for size-calculation overflow.
469 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
470
437b2cb4
PE
471 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
472
8b9ac8b4
PE
473 * lread.c: Integer overflow fixes.
474 (read_integer): Radix is now EMACS_INT, not int,
475 to improve quality of diagnostics for out-of-range radices.
476 Calculate buffer size correctly for out-of-range radices.
477 (read1): Check for integer overflow in radices, and in
478 read-circle numbers.
82cb60d3
PE
479 (read_escape): Avoid int overflow.
480 (Fload, openp, read_buffer_size, read1)
481 (substitute_object_recurse, read_vector, read_list, map_obarray):
482 Use ptrdiff_t, not int, for sizes.
483 (read1): Use EMACS_INT, not int, for sizes.
20270765 484 Check for size overflow.
8b9ac8b4 485
7fcccf1e
PE
486 * image.c (cache_image): Check for size arithmetic overflow.
487
bfbbd7e7
PE
488 * lread.c: Integer overflow issues.
489 (saved_doc_string_size, saved_doc_string_length)
490 (prev_saved_doc_string_size, prev_saved_doc_string_length):
491 Now ptrdiff_t, not int.
492 (read1): Don't assume doc string length fits in int. Check for
493 out-of-range doc string lengths.
494 (read_list): Don't assume file position fits in int.
39019e54 495 (read_escape): Check for hex character overflow.
bfbbd7e7 496
4e323265
LL
4972011-06-22 Leo Liu <sdl.web@gmail.com>
498
499 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
500 Move to minibuffer.el.
501
85fece3e
PE
5022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
503
20b84ce9 504 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
505 The following patches are for when GLYPH_DEBUG && !XASSERT.
506 * dispextern.h (trace_redisplay_p, dump_glyph_string):
507 * dispnew.c (flush_stdout):
508 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
509 Mark as externally visible.
510 * dispnew.c (check_window_matrix_pointers): Now static.
511 * dispnew.c (window_to_frame_vpos):
512 * xfns.c (unwind_create_frame):
513 * xterm.c (x_check_font): Remove unused local.
514 * scroll.c (CHECK_BOUNDS):
515 * xfaces.c (cache_fache): Rename local to avoid shadowing.
516 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
517 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
518 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
519 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
520 Now static.
521 (debug_method_add): Use va_list and vsprintf rather than relying
522 on undefined behavior with wrong number of arguments.
523 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
524 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
525 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
526 since we're not interested in debugging glyphs with old libraries.
527 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
528 GCC 4.6.0's static checking.
529
0766b489
PE
5302011-06-22 Paul Eggert <eggert@cs.ucla.edu>
531
31fd4b32
PE
532 Integer overflow and signedness fixes (Bug#8873).
533 A few related buffer overrun fixes, too.
534
b79e8648
PE
535 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
536
0766b489
PE
537 * dispextern.h (struct face.stipple):
538 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
539 (x_bitmap_mask, x_allocate_bitmap_record)
540 (x_create_bitmap_from_data, x_create_bitmap_from_file)
541 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
542 (x_create_bitmap_from_xpm_data):
543 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
544 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
545 (.bitmaps_last):
546 * xfaces.c (load_pixmap):
547 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
548 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
549 (.bitmaps_last, struct x_output.icon_bitmap):
550 Use ptrdiff_t, not int, for bitmap indexes.
551 (x_allocate_bitmap_record): Check for size overflow.
552 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
553
b081724f
PE
554 Use ptrdiff_t, not int, for overlay counts.
555 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
556 * editfns.c (overlays_around, get_pos_property):
557 * textprop.c (get_char_property_and_overlay):
558 * xdisp.c (next_overlay_change, note_mouse_highlight):
559 * xfaces.c (face_at_buffer_position):
21514da7
PE
560 * buffer.c (OVERLAY_COUNT_MAX): New macro.
561 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
562 (Fnext_overlay_change, Fprevious_overlay_change)
563 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 564 Use ptrdiff_t, not int, for sizes.
21514da7 565 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 566
3de73e5e
PE
567 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
568
2606c57b
PE
569 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
570 (x_session_initialize): Do not assume string length fits in int.
571
aaafe47a
PE
572 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
573 This is unlikely, but can occur if DPI is outlandish.
574
2674ddc8 575 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
576 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
577
28154962
PE
578 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
579 * xrdb.c (magic_file_p, search_magic_path):
580 Omit last arg SUFFIX; it was always 0. All callers changed.
581 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
582
7de51af5
PE
583 * xfont.c (xfont_match): Avoid need for strlen.
584
25ed6cc3
PE
585 * xfns.c: Don't assume strlen fits in int.
586 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
587
4eab31dd
PE
588 * xdisp.c (message_log_check_duplicate): Return intmax_t,
589 not unsigned long, as we prefer signed integers. All callers changed.
590 Detect integer overflow in repeat count.
591 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 592 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 593
171e2a58
PE
594 * termcap.c: Don't assume sizes fit in int and never overflow.
595 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
596 (gobble_line): Check for size-calculation overflow.
597
ad39faca 598 * minibuf.c (Fread_buffer):
6e5bb2dc 599 * lread.c (intern, intern_c_string):
74ca2eb3
PE
600 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
601 Don't assume string length fits in int.
602
52c61c22 603 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
604 * gtkutil.c (style_changed_cb): Avoid need for strlen.
605
b5b8c9e5
PE
606 * font.c: Don't assume string length fits in int.
607 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
608 Use ptrdiff_t, not int.
ccd6111c
PE
609 (font_intern_prop): Don't assume string length fits in int.
610 Don't assume integer property fits in fixnum.
611 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 612
882f0d81 613 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 614 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
615 Reformulate so as not to need the command string.
616 Invoke gzip -cd rather than gunzip, as it's more portable.
617 (lock_info_type, lock_file_1, lock_file):
618 Don't assume pid_t and time_t fit in unsigned long.
619 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
620 (current_lock_owner): Prefer signed type for sizes.
621 Use memcpy, not strncpy, where memcpy is what is really wanted.
622 Don't assume (via atoi) that time_t and pid_t fit in int.
623 Check for time_t and/or pid_t out of range, e.g., via a network share.
624 Don't alloca where an auto var works fine.
625
93f4cf88
PE
626 * fileio.c: Fix some integer overflow issues.
627 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
628 Don't assume string length fits in int.
629 (directory_file_name): Don't assume string length fits in long.
630 (make_temp_name): Don't assume pid fits in int, or that its print
631 length is less than 20.
632
f3e92b69
PE
633 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
634
1bfdaf10
PE
635 * coding.c (make_subsidiaries): Don't assume string length fits in int.
636
35016e9a
PE
637 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
638
3d1e65a1
PE
639 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
640 We prefer signed integers, even for size calculations.
641
0b963a93
PE
642 * emacs.c: Don't assume string length fits in 'int'.
643 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
644 (main): Don't invoke strlen when not needed.
645
573f4b54
PE
646 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
647 (XD_DEBUG_MESSAGE): Don't waste a byte.
648
989f33ba
PE
649 * callproc.c (getenv_internal_1, getenv_internal)
650 (Fgetenv_internal):
965d34eb
PE
651 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
652
e4d29b33
PE
653 * lread.c (invalid_syntax): Omit length argument.
654 All uses changed. This doesn't fix a bug, but it simplifies the
655 code away from its former Hollerith-constant appearance, and it's
656 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 657 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 658
eb49b136
PE
659 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
660 This didn't break anything, but it didn't help either.
661 It's confusing to put a bogus integer in a place where the actual
662 value does not matter.
9f62aeb1 663 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 664 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 665
15375a22
PE
666 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
667 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
668 implementation.
b61cc01c
PE
669 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
670 We prefer signed types, and the value cannot exceed the EMACS_INT
671 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
672 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
673 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
674 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 675
53b2623d
PE
676 * indent.c (sane_tab_width): New function.
677 (current_column, scan_for_column, Findent_to, position_indentation)
678 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 679 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 680
51cab52b 681 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 682
f2ed8a70
PE
683 * lisp.h (lint_assume): New macro.
684 * composite.c (composition_gstring_put_cache):
685 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
686
abe80cc6
PE
687 * editfns.c, insdel.c:
688 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 689
b02c740e
PE
690 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
691
ebc96716
PE
692 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
693
b4e50fa0 694 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 695 Use much-faster test for byte-length change.
311d5d7c 696 Don't assume string byte-length fits in 'int'.
a4cf38e4 697 Check that character arg fits in 'int'.
85461888 698 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 699
c0c1ee9f
PE
700 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
701
a498d7f4
PE
702 * fns.c (concat): Catch string overflow earlier.
703 Do not rely on integer wraparound.
704
51cab52b
PE
705 * dispextern.h (struct it.overlay_strings_charpos)
706 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
707 * xdisp.c (forward_to_next_line_start)
708 (back_to_previous_visible_line_start)
709 (reseat_at_next_visible_line_start, next_element_from_buffer):
710 Don't arbitrarily truncate the value of 'selective' to int.
711
76031fad
PE
712 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
713
5eb55db9
PE
714 * composite.c: Don't truncate sizes to 'int'.
715 (composition_gstring_p, composition_reseat_it)
716 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
717 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
718 not EMACS_UINT, for indexes.
5eb55db9 719
0703a717
PE
720 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
721
d6202519
PE
722 * buffer.c: Include <verify.h>.
723 (struct sortvec.priority, struct sortstr.priority):
8961a454 724 Now EMACS_INT, not int.
c20998a7 725 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
726 (struct sortstr.size, record_overlay_string)
727 (struct sortstrlist.size, struct sortlist.used):
728 Don't truncate size to int.
729 (record_overlay_string): Check for size-calculation overflow.
d6202519 730 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 731
d5a19415
JM
7322011-06-22 Jim Meyering <meyering@redhat.com>
733
029529ac 734 Don't leak an XBM-image-sized buffer
d5a19415
JM
735 * image.c (xbm_load): Free the image buffer after using it.
736
a9041e6c
PE
7372011-06-21 Paul Eggert <eggert@cs.ucla.edu>
738
739 Port to Sun C.
740 * composite.c (find_automatic_composition): Omit needless 'return 0;'
741 that Sun C diagnosed.
742 * fns.c (secure_hash): Fix pointer signedness issue.
743 * intervals.c (static_offset_intervals): New function.
744 (offset_intervals): Use it.
745
7f3f739f
LL
7462011-06-21 Leo Liu <sdl.web@gmail.com>
747
748 * deps.mk (fns.o):
749 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
750 sha512.h.
751
752 * fns.c (secure_hash): Rename from crypto_hash_function and change
753 the first arg to accept symbols.
5b66d427 754 (Fsecure_hash): New primitive.
7f3f739f
LL
755 (syms_of_fns): New symbols.
756
76147d94
DD
7572011-06-20 Deniz Dogan <deniz@dogan.se>
758
759 * process.c (Fset_process_buffer): Clarify return value in
760 docstring.
761
7d7d0045
CY
7622011-06-18 Chong Yidong <cyd@stupidchicken.com>
763
764 * dispnew.c (add_window_display_history): Use BVAR.
765
766 * xdisp.c (debug_method_add): Use BVAR.
767 (check_window_end, dump_glyph_matrix, dump_glyph)
768 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
769
770 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
771 Likewise.
772
773 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
774 check till after the cache is created in init_frame_faces.
775
ff2bc410
SM
7762011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
777
778 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
779
28177add
PE
7802011-06-16 Paul Eggert <eggert@cs.ucla.edu>
781
dd3482fe
PE
782 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
783 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
784 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
785
393d71f3 786 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
787 * fileio.c (Finsert_file_contents):
788 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
789 Remove the old (too-loose) buffer overflow checks.
790 They weren't needed, since make_gap checks for buffer overflow.
791 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
792 The old code merely checked for Emacs fixnum overflow, and relied
793 on undefined (wraparound) behavior. The new code avoids undefined
794 behavior, and also checks for ptrdiff_t and/or size_t overflow.
795
2e6813b0 796 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
797 Tune. Don't use wider integers than needed. Don't use alloca.
798 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 799
599a9e4f
PE
800 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
801
99561444
PE
802 * insdel.c, lisp.h (buffer_overflow): New function.
803 (insert_from_buffer_1, replace_range, replace_range_2):
804 * insdel.c (make_gap_larger):
805 * editfns.c (Finsert_char):
806 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
807
28177add
PE
808 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
809
e69dafad
PE
8102011-06-15 Paul Eggert <eggert@cs.ucla.edu>
811
a7af7fde 812 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 813
b1c46f02
PE
814 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
815 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
816
e69dafad
PE
817 * fileio.c: Don't assume EMACS_INT fits in off_t.
818 (emacs_lseek): New static function.
819 (Finsert_file_contents, Fwrite_region): Use it.
820 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
821
566684ea
PE
822 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
823
e6966cd6
PE
824 * fns.c: Don't overflow int when computing a list length.
825 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
826 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
827 truncation on 64-bit hosts. Check for QUIT every
828 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
829 faster and is responsive enough.
830 (Flength): Report an error instead of overflowing an integer.
831 (Fsafe_length): Return a float if the value is not representable
832 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 833 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 834 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 835
dd0b0efb
PE
836 * alloc.c: Check that resized vectors' lengths fit in fixnums.
837 (header_size, word_size): New constants.
838 (allocate_vectorlike): Don't check size overflow here.
839 (allocate_vector): Check it here instead, since this is the only
840 caller of allocate_vectorlike that could cause overflow.
841 Check that the new vector's length is representable as a fixnum.
842
86fe5cfe
PE
843 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
844 The previous code was bogus. For example, next_almost_prime (32)
845 returned 39, which is undesirable as it is a multiple of 3; and
846 next_almost_prime (24) returned 25, which is a multiple of 5 so
847 why was the code bothering to check for multiples of 7?
848
80e88859
PE
849 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
850
4a2f0ad6
PE
851 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
852
f66c7cf8
PE
853 Variadic C functions now count arguments with ptrdiff_t.
854 This partly undoes my 2011-03-30 change, which replaced int with size_t.
855 Back then I didn't know that the Emacs coding style prefers signed int.
856 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
857 were being counted with int, which may truncate counts on 64-bit
858 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
859 * lisp.h (struct Lisp_Subr.function.aMANY)
860 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
861 Arg counts are now ptrdiff_t, not size_t.
862 All variadic functions and their callers changed accordingly.
863 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
864 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
865 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
866 * callint.c (Fcall_interactively): Check arg count for overflow,
867 to avoid potential buffer overrun. Use signed char, not 'int',
868 for 'varies' array, so that we needn't bother to check its size
869 calculation for overflow.
870 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
871 * eval.c (apply_lambda):
872 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
873 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
874 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
875
a1759b76
PE
876 * callint.c (Fcall_interactively): Don't use index var as event count.
877
d96be9fc
PE
878 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
879 * mem-limits.h (SIZE): Remove; no longer used.
880
a690a978 881 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 882
578c21e6
PE
883 Remove unnecessary casts.
884 * xterm.c (x_term_init):
885 * xfns.c (x_set_border_pixel):
886 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
887 These aren't needed now that we assume ANSI C.
888
96f53c6c
PE
889 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
890 It's more likely to cause problems (due to unsigned overflow)
891 than to cure them.
892
83c77d31
PE
893 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
894
ee2079f1
PE
895 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
896
6da65536
PE
897 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
898
7147c4a4
PE
899 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
900
193e32d9
PE
901 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
902
e5533da6
PE
903 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
904
9910e595
PE
905 GLYPH_CODE_FACE returns EMACS_INT, not int.
906 * dispextern.h (merge_faces):
907 * xfaces.c (merge_faces):
01103c44
PE
908 * xdisp.c (get_next_display_element, next_element_from_display_vector):
909 Don't assume EMACS_INT fits in int.
9910e595 910
2638320e
PE
911 * character.h (CHAR_VALID_P): Remove unused parameter.
912 * fontset.c, lisp.h, xdisp.c: All uses changed.
913
045eb8d9
PE
914 * editfns.c (Ftranslate_region_internal): Omit redundant test.
915
c1f134b5
PE
916 * fns.c (concat): Minor tuning based on overflow analysis.
917 This doesn't fix any bugs. Use int to hold character, instead
918 of constantly refetching from Emacs object. Use XFASTINT, not
919 XINT, for value known to be a character. Don't bother comparing
920 a single byte to 0400, as it's always less.
921
395fcb93 922 * floatfns.c (Fexpt):
327eeec8
PE
923 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
924
abbd3d23
PE
925 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
926 for characters.
927
684a03ef
PE
928 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
929
0fed43f3
PE
930 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
931 Without this fix, on a 64-bit host (aset S 0 4294967386) would
932 incorrectly succeed when S was a string, because 4294967386 was
933 truncated before it was used.
934
8fd02eb7
PE
935 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
936 Otherwise, an out-of-range integer could cause undefined behavior
937 on a 64-bit host.
938
f8c86b69
PE
939 * composite.c: Use int, not EMACS_INT, for characters.
940 (fill_gstring_body, composition_compute_stop_pos): Use int, not
941 EMACS_INT, for values that are known to be in character range.
942 This doesn't fix any bugs but is the usual style inside Emacs and
943 may generate better code on 32-bit machines.
944
34206dd2
PE
945 Make sure a 64-bit char is never passed to ENCODE_CHAR.
946 This is for reasons similar to the recent CHAR_STRING fix.
947 * charset.c (Fencode_char): Check that character arg is actually
948 a character. Pass an int to ENCODE_CHAR.
949 * charset.h (ENCODE_CHAR): Verify that the character argument is no
950 wider than 'int', as a compile-time check to prevent future regressions
951 in this area.
952
c5958d4c 953 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
954
955 Make sure a 64-bit char is never passed to CHAR_STRING.
956 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
957 by silently ignoring the top 32 bits, allowing some values
958 that were far too large to be valid characters.
959 * character.h: Include <verify.h>.
960 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
961 arguments are no wider than unsigned, as a compile-time check
962 to prevent future regressions in this area.
963 * data.c (Faset):
01103c44 964 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
965 (Fsubst_char_in_region):
966 * fns.c (concat):
967 * xdisp.c (decode_mode_spec_coding):
968 Adjust to CHAR_STRING's new requirement.
969 * editfns.c (Finsert_char, Fsubst_char_in_region):
970 * fns.c (concat): Check that character args are actually
971 characters. Without this test, these functions did the wrong
972 thing with wildly out-of-range values on 64-bit hosts.
973
d37ca623
PE
974 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
975 These casts should not be needed on 32-bit hosts, either.
976 * keyboard.c (read_char):
977 * lread.c (Fload): Remove casts to unsigned.
978
ea204efb
PE
979 * lisp.h (UNSIGNED_CMP): New macro.
980 This fixes comparison bugs on 64-bit hosts.
981 (ASCII_CHAR_P): Use it.
982 * casefiddle.c (casify_object):
01103c44 983 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
984 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
985 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
986 * dispextern.h (FACE_FROM_ID):
987 * keyboard.c (read_char): Use UNSIGNED_CMP.
988
41cb286c
PE
989 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
990 not to EMACS_INT, to avoid GCC warning.
991
4a1b9832
PE
992 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
993
55daad71
PE
994 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
995 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
996 isn't needed on 32-bit machines.
8f95c75c 997
01103c44
PE
998 * buffer.c (Fgenerate_new_buffer_name):
999 Use EMACS_INT for count, not int.
0ceccced 1000 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1001
1002 * data.c (Qcompiled_function): Now static.
1003
c6f072e7
PE
1004 * window.c (window_body_lines): Now static.
1005
20ce5912
PE
1006 * image.c (gif_load): Rename local to avoid shadowing.
1007
9c4c5f81
PE
1008 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1009 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1010 * alloc.c (make_save_value): Integer argument is now of type
1011 ptrdiff_t, not int.
1012 (mark_object): Use ptrdiff_t, not int.
1013 * lisp.h (pD): New macro.
1014 * print.c (print_object): Use it.
1015
c0c5c8ae
PE
1016 * alloc.c: Use EMACS_INT, not int, to count objects.
1017 (total_conses, total_markers, total_symbols, total_vector_size)
1018 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1019 (total_free_floats, total_floats, total_free_intervals)
1020 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1021 Now EMACS_INT, not int. All uses changed.
1022 (Fgarbage_collect): Compute overall total using a double, so that
1023 integer overflow is less likely to be a problem. Check for overflow
1024 when converting back to an integer.
5a25e253
PE
1025 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1026 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1027 These were 'int' variables that could overflow on 64-bit hosts;
1028 they were never used, so remove them instead of repairing them.
211a0b2a 1029 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1030 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1031 Previously, this ceilinged at INT_MAX, but that doesn't work on
1032 64-bit machines.
e46bb31a 1033 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1034
c78baabf 1035 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1036 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1037 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1038 when a (possibly-narrower) signed value would do just as well.
1039 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1040
c9d624c6
PE
1041 * alloc.c: Catch some string size overflows that we were missing.
1042 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1043 for convenience in STRING_BYTES_MAX.
1044 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1045 The definition here is exact; the one in lisp.h was approximate.
1046 (allocate_string_data): Check for string overflow. This catches
1047 some instances we weren't catching before. Also, it catches
1048 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1049 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1050 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1051
c9d624c6
PE
1052 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1053 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1054 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1055
353032ce
PE
1056 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1057
2bccce07
PE
1058 * alloc.c (Fmake_string): Check for out-of-range init.
1059
0ac30604
SM
10602011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1061
1062 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1063
c195f2de
JD
10642011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1065
1066 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1067 xg_get_default_scrollbar_width.
1068
1069 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1070 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1071 (style_changed_cb): Call update_theme_scrollbar_width and call
1072 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1073 all frames (Bug#8505).
1074 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1075 Call gtk_window_set_resizable if HAVE_GTK3.
1076 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1077 and height if HAVE_GTK3 (Bug#8505).
1078 (scroll_bar_width_for_theme): New variable.
1079 (update_theme_scrollbar_width): New function.
1080 (xg_get_default_scrollbar_width): Move code to
1081 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1082 (xg_initialize): Call update_theme_scrollbar_width.
1083
1084 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1085
1086 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1087
e10ac9f1
MR
10882011-06-12 Martin Rudalics <rudalics@gmx.at>
1089
1090 * frame.c (make_frame): Call other_buffer_safely instead of
1091 other_buffer.
1092
1093 * window.c (temp_output_buffer_show): Call display_buffer with
1094 second argument Vtemp_buffer_show_specifiers and reset latter
1095 immediately after the call.
1096 (Vtemp_buffer_show_specifiers): New variable.
1097 (auto_window_vscroll_p, next_screen_context_lines)
1098 (Vscroll_preserve_screen_position): Remove leading asterisks from
1099 doc-strings.
1100
2d3c217e 11012011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1102
7b7f97e8 1103 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1104 * buffer.c (Qclone_number): Remove for now, as it's unused.
1105 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1106 (record_buffer): Remove unused local.
1107 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1108 (set_frame_buffer_list): Remove; unused.
1109 * frame.h (other_visible_frames): Remove decl.
1110 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1111 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1112 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1113 if HAVE_GPM.
1114 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1115 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1116 Define only if HAVE_GPM.
1117 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1118 (update_hints_inhibit): Remove; never set. All uses removed.
1119 * widgetprv.h (emacsFrameClassRec): Remove decl.
1120 * window.c (delete_deletable_window): Now returns void, since it
1121 wasn't returning anything.
1122 (compare_window_configurations): Remove unused locals.
1123 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1124 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1125 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1126 the same widths as pointers. This follows up on the 2011-05-06 patch.
1127 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1128 * xterm.h: Likewise.
1129 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1130
1384b89e
JB
11312011-06-12 Juanma Barranquero <lekktu@gmail.com>
1132
1133 * makefile.w32-in: Update dependencies.
1134 (LISP_H): Add lib/intprops.h.
1135
1100a63c
CY
11362011-06-11 Chong Yidong <cyd@stupidchicken.com>
1137
1138 * image.c (gif_load): Add animation frame delay to the metadata.
1139 (syms_of_image): Use DEFSYM. New symbol `delay'.
1140
6198ccd0
MR
11412011-06-11 Martin Rudalics <rudalics@gmx.at>
1142
1143 * window.c (delete_deletable_window): Re-add.
1144 (Fset_window_configuration): Rewrite to handle dead buffers and
1145 consequently deletable windows.
1146 (window_tree, Fwindow_tree): Remove. Supply functionality in
1147 window.el.
1148 (compare_window_configurations): Simplify code.
1149
b6e3633c
AS
11502011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1151
1ab0dee5
AS
1152 * image.c (imagemagick_load_image): Fix type mismatch.
1153 (Fimagemagick_types): Likewise.
1154
b6e3633c
AS
1155 * window.h (replace_buffer_in_windows): Declare.
1156
9397e56f
MR
11572011-06-11 Martin Rudalics <rudalics@gmx.at>
1158
1159 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1160 Qclone_number. Remove external declaration of Qdelete_window.
1161 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1162 code.
1163 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1164 Qbuffer_list_update_hook if allowed.
1165 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1166 buffer list implementation.
1167 (other_buffer_safely): New function.
1168 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1169 calls to replace_buffer_in_windows and
1170 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1171 if allowed.
1172 (record_buffer): Inhibit quitting and rewrite using quittable
1173 functions. Run Qbuffer_list_update_hook if allowed.
1174 (Frecord_buffer, Funrecord_buffer): New functions.
1175 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1176 switch-to-buffer to window.el.
1177 (bury-buffer): Move to window.el.
1178 (Vbuffer_list_update_hook): New variable.
1179
1180 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1181 section.
1182
1183 * window.h (resize_frame_windows): Move up in code.
1184 (Fwindow_frame): Remove EXFUN.
1185 (replace_buffer_in_all_windows): Remove prototype.
1186 (replace_buffer_in_windows_safely): Add prototype.
1187
1188 * window.c: Declare Qdelete_window static again. Move down
1189 declaration of select_count.
1190 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1191 (Fother_window): Move to window.el.
1192 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1193 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1194 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1195 window.el.
1196 (replace_buffer_in_windows): Implement by calling
1197 Qreplace_buffer_in_windows.
1198 (replace_buffer_in_all_windows): Remove with some functionality
1199 moved into replace_buffer_in_windows_safely.
1200 (replace_buffer_in_windows_safely): New function.
1201 (select_window_norecord, select_frame_norecord): Move in front
1202 of run_window_configuration_change_hook. Remove now obsolete
1203 declarations.
1204 (Fset_window_buffer): Rewrite doc-string. Call
1205 Qrecord_window_buffer.
1206 (keys_of_window): Move binding for other-window to window.el.
1207
b50691aa
CY
12082011-06-11 Chong Yidong <cyd@stupidchicken.com>
1209
1210 * dispextern.h (struct image): Replace data member, whose int_val
1211 and ptr_val fields were not used by anything, with a single
1212 lisp_val object.
1213
1214 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1215 (gif_clear_image, gif_load, imagemagick_load_image)
1216 (gs_clear_image, gs_load): Callers changed.
1217
3f754b86
PE
12182011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1219
cca69397
PE
1220 * buffer.h: Include <time.h>, for time_t.
1221 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1222
109e28d0
PE
1223 Fix minor problems found by static checking.
1224
60737f02
PE
1225 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1226
4b66faf3
PE
1227 Make identifiers static if they are not used in other modules.
1228 * data.c (Qcompiled_function, Qframe, Qvector):
1229 * image.c (QimageMagick, Qsvg):
1230 * minibuf.c (Qmetadata):
1231 * window.c (resize_window_check, resize_root_window): Now static.
1232 * window.h (resize_window_check, resize_root_window): Remove decls.
1233
109e28d0
PE
1234 * window.c (window_deletion_count, delete_deletable_window):
1235 Remove; unused.
46a4ce9e
PE
1236 (window_body_lines): Now static.
1237 (Fdelete_other_windows_internal): Mark vars as initialized.
1238 Make sure 'resize_failed' is initialized.
1239 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1240 (resize_window_apply): Remove unused local.
1241 * window.h (delete_deletable_window): Remove decl.
1242
109e28d0 1243 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1244 (imagemagick_load_image): Fix pointer signedness problem by changing
1245 last arg from unsigned char * to char *. All uses changed.
1246 Also, fix a local for similar reasons.
1247 Remove unused locals. Remove locals to avoid shadowing.
1248 (fn_rsvg_handle_free): Remove; unused.
1249 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1250 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1251
3f754b86
PE
1252 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1253
2547adb1
CY
12542011-06-10 Chong Yidong <cyd@stupidchicken.com>
1255
1256 * image.c (gif_load): Fix omitted cast error introduced by
1257 2011-06-06 change.
1258
2c8e37d4
MR
12592011-06-10 Martin Rudalics <rudalics@gmx.at>
1260
1261 * window.h (resize_proportionally, orig_total_lines)
1262 (orig_top_line): Remove from window structure.
1263 (set_window_height, set_window_width, change_window_heights)
1264 (Fdelete_window): Remove prototypes.
1265 (resize_frame_windows): Remove duplicate declaration.
1266
440a42e3
EZ
12672011-06-10 Eli Zaretskii <eliz@gnu.org>
1268
1269 * window.h (resize_frame_windows, resize_window_check)
1270 (delete_deletable_window, resize_root_window)
1271 (resize_frame_windows): Declare prototypes.
1272
1273 * window.c (resize_window_apply): Make definition be "static" to
1274 match the prototype.
1275
562dd5e9
MR
12762011-06-10 Martin Rudalics <rudalics@gmx.at>
1277
1278 * window.c: Remove declarations of Qwindow_size_fixed,
1279 window_min_size_1, window_min_size_2, window_min_size,
1280 size_window, window_fixed_size_p, enlarge_window, delete_window.
1281 Remove static from declaration of Qdelete_window, it's
1282 temporarily needed by Fbury_buffer.
1283 (replace_window): Don't assign orig_top_line and
1284 orig_total_lines.
1285 (Fdelete_window, delete_window): Remove. Window deletion is
1286 handled by window.el.
1287 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1288 Fdelete_window calls with calls to Qdelete_window.
1289 (Fdelete_other_windows): Remove. Deleting other windows is
1290 handled by window.el.
1291 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1292 handled in window.el.
1293 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1294 Window minimum sizes are handled in window.el.
1295 (shrink_windows, size_window, set_window_height)
1296 (set_window_width, change_window_heights, window_height)
1297 (window_width, CURBEG, CURSIZE, enlarge_window)
1298 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1299 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1300 handled in window.el.
1301 (make_dummy_parent): Rename to make_parent_window and give it a
1302 second argument horflag.
1303 (make_window): Don't set resize_proportionally any more.
1304 (Fsplit_window): Remove. Windows are split in window.el.
1305 (save_restore_action, save_restore_orig_size)
1306 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1307 Resize mini windows in window.el.
1308 (grow_mini_window, shrink_mini_window): Implement by calling
1309 Qresize_root_window_vertically, resize_window_check and
1310 resize_window_apply.
1311 (saved_window, Fset_window_configuration, save_window_save): Do
1312 not handle orig_top_line, orig_total_lines, and
1313 resize_proportionally.
1314 (window_min_height, window_min_width): Move to window.el.
1315 (keys_of_window): Move bindings for delete-other-windows,
1316 split-window, delete-window and enlarge-window to window.el.
1317
1318 * buffer.c: Temporarily extern Qdelete_window.
1319 (Fbury_buffer): Temporarily call Qdelete_window instead of
1320 Fdelete_window (Fbury_buffer will move to window.el soon).
1321
1322 * frame.c (set_menu_bar_lines_1): Remove code handling
1323 orig_top_line and orig_total_lines.
1324
1325 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1326 set_window_height but set heights directly.
1327 (change_frame_size_1): Use resize_frame_windows.
1328
1329 * xdisp.c (init_xdisp): Don't use set_window_height but set
1330 heights directly.
1331
1332 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1333 resize_frame_windows instead of change_window_heights and run
1334 run_window_configuration_change_hook.
1335
1336 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1337 instead of change_window_heights and run
1338 run_window_configuration_change_hook.
1339
1a13852e
MR
13402011-06-09 Martin Rudalics <rudalics@gmx.at>
1341
1342 * window.c (replace_window): Rename second argument REPLACEMENT to
1343 NEW. New third argument SETFLAG. Rewrite.
1344 (delete_window, make_dummy_parent): Call replace_window with
1345 third argument 1.
1346 (window_list_1): Move down in code.
1347 (run_window_configuration_change_hook): Move set_buffer part
1348 before select_frame_norecord part in order to unwind correctly.
1349 Rename count1 to count.
1350 (recombine_windows, delete_deletable_window, resize_root_window)
1351 (Fdelete_other_windows_internal)
1352 (Frun_window_configuration_change_hook, make_parent_window)
1353 (resize_window_check, resize_window_apply, Fresize_window_apply)
1354 (resize_frame_windows, Fsplit_window_internal)
1355 (Fdelete_window_internal, Fresize_mini_window_internal): New
1356 functions.
1357 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1358
f3d1777e
MR
13592011-06-08 Martin Rudalics <rudalics@gmx.at>
1360
496e208e
MR
1361 * window.h (window): Add some new members to window structure -
1362 normal_lines, normal_cols, new_total, new_normal, clone_number,
1363 splits, nest, prev_buffers, next_buffers.
1364 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1365 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1366
f3d1777e
MR
1367 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1368 Remove.
496e208e
MR
1369 (make_dummy_parent): Set new members of windows structure.
1370 (make_window): Move down in code. Handle new members of window
1371 structure.
1372 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1373 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1374 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1375 (Fset_window_prev_buffers, Fwindow_next_buffers)
1376 (Fset_window_next_buffers, Fset_window_clone_number): New
1377 functions.
1378 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1379 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1380 Doc-string fixes.
1381 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1382 Argument WINDOW can be now internal window too.
1383 (Fwindow_use_time): Move up in code.
1384 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1385 Rewrite doc-string.
1386 (Fset_window_configuration, saved_window)
1387 (Fcurrent_window_configuration, save_window_save): Handle new
1388 members of window structure.
b9e809c2
MR
1389 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1390 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1391 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1392 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1393 Qget_mru_window, Qresize_root_window,
1394 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1395 Qauto_buffer_name; staticpro them.
f3d1777e 1396
abde8f8c
MR
13972011-06-07 Martin Rudalics <rudalics@gmx.at>
1398
1399 * window.c (Fwindow_total_size, Fwindow_left_column)
1400 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1401 (Fwindow_list_1): New functions.
1402 (window_box_text_cols): Replace with window_body_cols.
1403 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1404 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1405 (delete_window, Fset_window_configuration): Call
1406 delete_all_subwindows with window as argument.
1407 (delete_all_subwindows): Take a window as argument and not a
1408 structure. Rewrite.
190b47e6
MR
1409 (window_loop): Remove handling of GET_LRU_WINDOW and
1410 GET_LARGEST_WINDOW.
1411 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1412
1413 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1414 window_box_text_cols. delete_all_subwindows now takes a
1415 Lisp_Object as argument.
abde8f8c
MR
1416
1417 * indent.c (compute_motion, Fcompute_motion): Use
1418 window_body_cols instead of window_box_text_cols.
1419
fa8a67e6
MR
1420 * frame.c (delete_frame): Call delete_all_subwindows with root
1421 window as argument.
1422
a54e3482
DC
14232011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1424
1425 * fns.c (Fputhash): Document return value.
1426
60002bf5
CY
14272011-06-06 Chong Yidong <cyd@stupidchicken.com>
1428
1429 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1430
0c671da6 14312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1432
b862a52a 1433 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1434
be44ca6c
PE
1435 Check for overflow when converting integer to cons and back.
1436 * charset.c (Fdefine_charset_internal, Fdecode_char):
1437 Use cons_to_unsigned to catch overflow.
1438 (Fencode_char): Use INTEGER_TO_CONS.
1439 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1440 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1441 * data.c (long_to_cons, cons_to_long): Remove.
1442 (cons_to_unsigned, cons_to_signed): New functions.
1443 These signal an error for invalid or out-of-range values.
1444 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1445 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1446 * font.c (Ffont_variation_glyphs):
1447 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1448 * lisp.h: Include <intprops.h>.
1449 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1450 (cons_to_signed, cons_to_unsigned): New decls.
1451 (long_to_cons, cons_to_long): Remove decls.
1452 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1453 (Fprimitive_undo): Use CONS_TO_INTEGER.
1454 * xfns.c (Fx_window_property): Likewise.
1455 * xselect.c: Include <limits.h>.
1456 (x_own_selection, selection_data_to_lisp_data):
1457 Use INTEGER_TO_CONS.
1458 (x_handle_selection_request, x_handle_selection_clear)
1459 (x_get_foreign_selection, Fx_disown_selection_internal)
1460 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1461 (lisp_data_to_selection_data): Use cons_to_unsigned.
1462 (x_fill_property_data): Use cons_to_signed.
1463 Report values out of range.
1464
d1f3d2af
PE
1465 Check for buffer and string overflow more precisely.
1466 * buffer.h (BUF_BYTES_MAX): New macro.
1467 * lisp.h (STRING_BYTES_MAX): New macro.
1468 * alloc.c (Fmake_string):
1469 * character.c (string_escape_byte8):
1470 * coding.c (coding_alloc_by_realloc):
1471 * doprnt.c (doprnt):
1472 * editfns.c (Fformat):
1473 * eval.c (verror):
1474 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1475 since they may not be the same number.
1476 * editfns.c (Finsert_char):
1477 * fileio.c (Finsert_file_contents):
1478 Likewise for BUF_BYTES_MAX.
1479
dd52fcea
PE
1480 * image.c: Use ptrdiff_t, not int, for sizes.
1481 (slurp_file): Switch from int to ptrdiff_t.
1482 All uses changed.
1483 (slurp_file): Check that file size fits in both size_t (for
1484 malloc) and ptrdiff_t (for sanity and safety).
1485
7f9bbdbb
PE
1486 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1487 if b->modtime has its maximal value.
1488
dfe18f82
PE
1489 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1490
84acfcf0
PE
1491 Don't assume time_t can fit into int.
1492 * buffer.h (struct buffer.modtime): Now time_t, not int.
1493 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1494 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1495
ccd9a01a
PE
1496 Minor fixes for signed vs unsigned integers.
1497 * character.h (MAYBE_UNIFY_CHAR):
1498 * charset.c (maybe_unify_char):
1499 * keyboard.c (read_char, reorder_modifiers):
1500 XINT -> XFASTINT, since the integer must be nonnegative.
1501 * ftfont.c (ftfont_spec_pattern):
1502 * keymap.c (access_keymap, silly_event_symbol_error):
1503 XUINT -> XFASTINT, since the integer must be nonnegative.
1504 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1505 since it makes no difference and we prefer signed.
1506 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1507 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1508 nonnegative.
1509
d6d100dd
SM
15102011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1511
1512 * window.h (Fwindow_frame): Declare.
1513
2b6148e4
PE
15142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1517 (SPARE_MEMORY): Always define.
1518 (LARGE_REQUEST): Remove.
1519 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1520
f230ecc9
MR
15212011-06-06 Martin Rudalics <rudalics@gmx.at>
1522
727e958e
MR
1523 * lisp.h: Move EXFUNS for Fframe_root_window,
1524 Fframe_first_window and Fset_frame_selected_window to window.h.
1525
1526 * window.h: Move EXFUNS for Fframe_root_window,
1527 Fframe_first_window and Fset_frame_selected_window here from
1528 lisp.h.
1529
1530 * frame.c (Fwindow_frame, Fframe_first_window)
1531 (Fframe_root_window, Fframe_selected_window)
1532 (Fset_frame_selected_window): Move to window.c.
1533 (Factive_minibuffer_window): Move to minibuf.c.
1534 (Fother_visible_frames_p): New function.
1535
1536 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1537
f230ecc9
MR
1538 * window.c (decode_window, decode_any_window): Move up in code.
1539 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1540 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1541 (Fwindow_buffer): Move up and rewrite doc-string.
1542 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1543 (Fwindow_prev): New functions.
727e958e
MR
1544 (Fwindow_frame): Move here from frame.c. Accept any window as
1545 argument.
1546 (Fframe_root_window, Fframe_first_window)
1547 (Fframe_selected_window): Move here from frame.c. Accept frame
1548 or arbitrary window as argument. Update doc-strings.
1549 (Fminibuffer_window): Move up in code.
1550 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1551 (Fset_frame_selected_window): Move here from frame.c.
1552 Marginal rewrite.
727e958e
MR
1553 (Fselected_window, select_window, Fselect_window): Move up in
1554 code. Minor doc-string fixes.
f230ecc9 1555
4d09bcf6
PE
15562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1557
1558 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1559 Do not assume that spare memory exists; that assumption is valid
1560 only if SYSTEM_MALLOC.
1561 (LARGE_REQUEST): New macro, so that the issue of large requests
1562 is separated from the issue of spare memory.
1563
810928a2
AS
15642011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1565
172418ad
AS
1566 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1567 format. (Bug#8806)
1568
43f862f7
AS
1569 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1570
810928a2
AS
1571 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1572 before statements.
1573
a059fe24
JD
15742011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1575
1576 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1577
1578 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1579
1580 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1581 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1582
989bf368
JB
15832011-06-05 Juanma Barranquero <lekktu@gmail.com>
1584
1585 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1586
4b80f674
CY
15872011-06-04 Chong Yidong <cyd@stupidchicken.com>
1588
1589 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1590 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1591 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1592 New error handlers.
4b80f674
CY
1593 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1594 Obey Vx_select_enable_clipboard_manager. Catch errors in
1595 x_clipboard_manager_save (Bug#8779).
1596 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1597 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1598
99a33b77 15992011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1600
1601 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1602
99a33b77 16032011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1604
1605 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1606 in the current matrix if keep_current_p is non-zero.
1607
8264569d
EZ
16082011-06-04 Eli Zaretskii <eliz@gnu.org>
1609
1610 * bidi.c (bidi_level_of_next_char): Fix last change.
1611
57f97249
EZ
16122011-06-03 Eli Zaretskii <eliz@gnu.org>
1613
fec2107c 1614 Support bidi reordering of text covered by display properties.
57f97249 1615
fec2107c
EZ
1616 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1617 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1618 (bidi_cache_search, bidi_cache_iterator_state)
1619 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1620 (bidi_level_of_next_char, bidi_move_to_visually_next):
1621 Support character positions inside a run of characters covered by a
fec2107c
EZ
1622 display string.
1623 (bidi_paragraph_init, bidi_resolve_explicit_1)
1624 (bidi_level_of_next_char): Call bidi_fetch_char and
1625 bidi_fetch_char_advance instead of FETCH_CHAR and
1626 FETCH_CHAR_ADVANCE.
1627 (bidi_init_it): Initialize new members.
1628 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1629 definitions.
1630 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1631 instead of using explicit *_CHAR codes.
d6d100dd
SM
1632 (bidi_resolve_explicit, bidi_resolve_weak):
1633 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1634 bidirectional text is supported only in multibyte buffers.
1635 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1636 it to initialize the frame_window_p member of struct bidi_it.
1637 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1638 (bidi_resolve_explicit, bidi_resolve_weak)
1639 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1640 bidi_it->nchars is non-positive.
1641 (bidi_level_of_next_char): Don't try to lookup the cache for the
1642 next/previous character if nothing is cached there yet, or if we
1643 were just reseat()'ed to a new position.
c40e2fb2 1644
0e14fe90
EZ
1645 * xdisp.c (set_cursor_from_row): Set start and stop points
1646 according to the row's direction when priming the loop that looks
1647 for the glyph on which to display cursor.
1648 (single_display_spec_intangible_p): Function deleted.
1649 (display_prop_intangible_p): Reimplement to call
1650 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1651 Accept 3 additional arguments needed by handle_display_spec.
1652 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1653 values: lists, `(when COND...)' forms, etc.
1654 (single_display_spec_string_p): Support property values that are
1655 lists with the argument STRING its top-level element.
1656 (display_prop_string_p): Fix the condition for processing a
1657 property that is a list to be consistent with handle_display_spec.
fec2107c 1658 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1659 last portion of handle_display_prop.
1660 (compute_display_string_pos): Accept additional argument
1661 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1662 value of a `display' property is a "replacing spec".
1663 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1664 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1665 the display property, but just return a value indicating whether
1666 the display property will replace the characters it covers.
1667 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1668 frame_window_p members of struct bidi_it.
d6d100dd
SM
1669 (compute_display_string_pos, compute_display_string_end):
1670 New functions.
fec2107c
EZ
1671 (push_it): Accept second argument POSITION, where pop_it should
1672 jump to continue iteration.
1673 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1674
fec2107c
EZ
1675 * keyboard.c (adjust_point_for_property): Adjust the call to
1676 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1677
1678 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1679 (bidi_init_it): Update prototypes.
1680 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1681 (compute_display_string_pos, compute_display_string_end):
1682 Declare prototypes.
fec2107c
EZ
1683 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1684 EMACS_INT.
fc6f18ce 1685
40087514 16862011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1687
57f53182
PE
1688 Malloc failure behavior now depends on size of allocation.
1689 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1690 * lisp.h: Change signatures accordingly.
1691 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1692 All callers changed. (Bug#8762)
1693
1694 * gnutls.c: Use Emacs's memory allocators.
1695 Without this change, the gnutls library would invoke malloc etc.
1696 directly, which causes problems on non-SYNC_INPUT hosts, and which
1697 runs afoul of improving memory_full behavior. (Bug#8761)
1698 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1699 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1700 xfree instead of the default malloc, realloc, free.
1701 (Fgnutls_boot): No need to check for memory allocation failure,
1702 since xmalloc does that for us.
1703
ac32cd99 1704 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1705 * category.c (hash_get_category_set):
1706 * ccl.c (ccl_driver):
1707 * charset.c (Fdefine_charset_internal):
1708 * charset.h (struct charset.hash_index):
1709 * composite.c (get_composition_id, gstring_lookup_cache)
1710 (composition_gstring_put_cache):
1711 * composite.h (struct composition.hash_index):
1712 * dispextern.h (struct image.hash):
1713 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1714 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1715 (hashfn_equal, hashfn_user_defined, make_hash_table)
1716 (maybe_resize_hash_table, hash_lookup, hash_put)
1717 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1718 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1719 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1720 * image.c (make_image, search_image_cache, lookup_image)
1721 (xpm_put_color_table_h):
1722 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1723 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1724 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1725 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1726 * alloc.c (allocate_vectorlike):
1727 Check for overflow in vector size calculations.
1728 * ccl.c (ccl_driver):
1729 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1730 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1731 need to be updated by these changes.
40087514
PE
1732 * fns.c (make_hash_table, maybe_resize_hash_table):
1733 Check for integer overflow with large hash tables.
0de4bb68
PE
1734 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1735 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1736 (SXHASH_REDUCE): New macro.
1737 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1738 Use it instead of discarding useful hash info with large hash values.
1739 (sxhash_float): New function.
1740 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1741 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1742 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1743 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1744 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1745 Adjust signatures to match updated version of code.
1746 (consing_since_gc): Now EMACS_INT, since a single hash table can
1747 use more than INT_MAX bytes.
1748
698d32e2
DN
17492011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1750
1751 Make it possible to build with GCC-4.6+ -O2 -flto.
1752
1753 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1754
fd6fa53f
SM
17552011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1756
1757 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1758 Call minibuffer-inactive-mode.
1759
864db017
JB
17602011-05-31 Juanma Barranquero <lekktu@gmail.com>
1761
1762 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1763 Update dependencies.
1764
2ad0baf4
DN
17652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1766
1767 * data.c (init_data): Remove code for UTS, this system is not
1768 supported anymore.
1769
4fcc2638
DN
17702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1771
1772 Don't force ./temacs to start in terminal mode.
1773
1774 * frame.c (make_initial_frame): Initialize faces in all cases, not
1775 only when CANNOT_DUMP is defined.
1776 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1777
c56e0fd5
DN
17782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1779
1780 * dispnew.c (add_window_display_history): Use const for the string
1781 pointer. Remove declaration, not needed.
1782
333d54da 17832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1784
55d4c1b2 1785 Use 'inline', not 'INLINE'.
333d54da 1786 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1787 * alloc.c, fontset.c (INLINE): Remove.
1788 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1789 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1790 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1791 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1792 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1793
738db178
DN
17942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1795
1796 Make it possible to run ./temacs.
1797
1798 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1799 syms_of_callproc does the same thing. Remove test for
1800 "initialized", do it in the caller.
1801 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1802
620c53a6
SM
18032011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1804
1805 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1806 (read_minibuf): Use get_minibuffer.
1807 (syms_of_minibuf): Use DEFSYM.
1808 (Qmetadata): New var.
1809 * data.c (Qbuffer): Don't make it static.
1810 (syms_of_data): Use DEFSYM.
1811
e003a292
PE
18122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1813
1814 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1815 (CCL_CODE_MIN): New macro.
1816
ed008a6d
PE
18172011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1818
3687c2ef
PE
1819 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1820
ed008a6d
PE
1821 * eval.c (Qdebug): Now static.
1822 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1823 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1824 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1825
d66c4c7c
CY
18262011-05-29 Chong Yidong <cyd@stupidchicken.com>
1827
1828 * image.c: Various fixes to ImageMagick code comments.
1829 (Fimagemagick_types): Doc fix.
1830
5fbc2025
PE
18312011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1832
0196f88a
PE
1833 Minor fixes prompted by GCC 4.6.0 warnings.
1834
1835 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1836
5fbc2025
PE
1837 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1838 (x_clipboard_manager_save_all): Move extern decl to ...
1839 * xterm.h: ... here, so that it can be checked for consistency.
1840
1dd3c2d9
CY
18412011-05-29 Chong Yidong <cyd@stupidchicken.com>
1842
1843 * xselect.c (x_clipboard_manager_save_frame)
1844 (x_clipboard_manager_save_all): New functions.
1845 (Fx_clipboard_manager_save): Lisp function deleted.
1846
1847 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1848 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1849
1850 * xterm.h: Update prototype.
1851
5ba6571d
WX
18522011-05-28 William Xu <william.xwl@gmail.com>
1853
1854 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1855 exiting (Bug#8239).
1856
3eaff834
JM
18572011-05-28 Jim Meyering <meyering@redhat.com>
1858
e1900994 1859 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1860 * fns.c (to_uchar): Define.
1861 (crypto_hash_function): Use it to convert some newly-signed
1862 variables to unsigned, to avoid sign-extension bugs. For example,
1863 without this change, (md5 "truc") would evaluate to
1864 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1865 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1866 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1867
0f6990a7
PE
18682011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 Integer overflow fixes.
c8a9ca5a 1871
08686060
PE
1872 * dbusbind.c: Serial number integer overflow fixes.
1873 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1874 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1875 to hold a serial number that is too large for a fixnum.
1876 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1877 Check for serial numbers out of range. Decode any serial number
59568bf0 1878 that was so large that it became a float. (Bug#8722)
08686060 1879
2d1fc3c7
PE
1880 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1881 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1882 Use XFASTINT rather than XUINT when numbers are nonnegative.
1883 (xd_append_arg, Fdbus_method_return_internal):
1884 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1885 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1886 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1887 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1888 (Bug#8722)
2d1fc3c7 1889
c8a9ca5a
PE
1890 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1891
519e1d69
PE
1892 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1893
30569699
PE
1894 ccl: add integer overflow checks
1895 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1896 (IN_INT_RANGE): New macros.
1897 (ccl_driver): Use them to check for integer overflow when
1898 decoding a CCL program. Many of the new checks are whether XINT (x)
1899 fits in int; it doesn't always, on 64-bit hosts. The new version
1900 doesn't catch all possible integer overflows, but it's an
847044ea 1901 improvement. (Bug#8719)
30569699 1902
c11285dc
PE
1903 * alloc.c (make_event_array): Use XINT, not XUINT.
1904 There's no need for unsigned here.
1905
fdccd48e
PE
1906 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1907 This follows up to the 2011-05-06 change that substituted uintptr_t
1908 for EMACS_INT. This case wasn't caught back then.
1909
37910ab2
PE
1910 Rework Fformat to avoid integer overflow issues.
1911 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1912 now (part of C89). Include <verify.h>.
1913 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1914 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1915 (Fformat): Avoid the prepass trying to compute sizes; it was only
1916 approximate and thus did not catch overflow reliably. Instead, walk
1917 through the format just once, formatting and computing sizes as we go,
1918 checking for integer overflow at every step, and allocating a larger
1919 buffer as needed. Keep track separately whether the format is
1920 multibyte. Keep only the most-recently calculated precision, rather
1921 than them all. Record whether each argument has been converted to
1922 string. Use EMACS_INT, not int, for byte and char and arg counts.
1923 Support field widths and precisions larger than INT_MAX. Avoid
1924 sprintf's undefined behavior with conversion specifications such as %#d
1925 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1926 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1927 formatting out-of-range floating point numbers with int
9173deec 1928 formats. (Bug#8668)
37910ab2 1929
2e6578fb
PE
1930 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1931
0ae6bdee
PE
1932 * data.c: Avoid integer truncation in expressions involving floats.
1933 * data.c: Include <intprops.h>.
1934 (arith_driver): When there's an integer overflow in an expression
1935 involving floating point, convert the integers to floating point
1936 so that the resulting value does not suffer from catastrophic
1937 integer truncation. For example, on a 64-bit host (* 4
1938 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1939 Do not rely on undefined behavior after integer overflow.
1940
de883a70
PE
1941 merge count_size_as_multibyte, parse_str_to_multibyte
1942 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1943 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1944 Check for integer overflow.
1945 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1946 since it's now a duplicate of the other. This is more of
1947 a character than a buffer op, so better that it's in character.c.
1948 * fns.c, print.c: Adjust to above changes.
1949
2ff916cb
PE
19502011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1951
1952 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1953
f1b54466
PE
19542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1955
fb1ac845
PE
1956 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1957 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1958 (x_clipboard_manager_save): Now static.
1959 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1960
f1b54466
PE
1961 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1962 (crypto_hash_function): Now static.
1963 Fix pointer signedness problems. Avoid unnecessary initializations.
1964
a9f737ee
CY
19652011-05-27 Chong Yidong <cyd@stupidchicken.com>
1966
1967 * termhooks.h (Vselection_alist): Make it terminal-local.
1968
1969 * terminal.c (create_terminal): Initialize it.
1970
1971 * xselect.c: Support for clipboard managers.
1972 (Vselection_alist): Move to termhooks.h as terminal-local var.
1973 (LOCAL_SELECTION): New macro.
1974 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1975 (symbol_to_x_atom): Remove gratuitous arg.
1976 (x_handle_selection_request, lisp_data_to_selection_data)
1977 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1978 (x_own_selection, x_get_local_selection, x_convert_selection):
1979 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1980 (some_frame_on_display): Delete unused function.
1981 (Fx_own_selection_internal, Fx_get_selection_internal)
1982 (Fx_disown_selection_internal, Fx_selection_owner_p)
1983 (Fx_selection_exists_p): New optional frame arg.
1984 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1985 (x_handle_selection_clear): Don't treat other terminals with the
1986 same keyboard specially. Use the terminal-local Vselection_alist.
1987 (x_clear_frame_selections): Use Frun_hook_with_args.
1988
1989 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1990
1991 * xterm.h: Add support for those atoms.
1992
e067f0c1
CY
19932011-05-26 Chong Yidong <cyd@stupidchicken.com>
1994
1995 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1996 (converted_selections, conversion_fail_tag): New global variables.
1997 (x_selection_request_lisp_error): Free the above.
1998 (x_get_local_selection): Remove unnecessary code.
1999 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2000 of converted selections stored in converted_selections.
2001 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2002 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2003 (x_convert_selection): New function.
2004 (x_handle_selection_event): Simplify.
2005 (x_get_foreign_selection): Don't ignore incoming requests while
2006 waiting for an answer; this will fail when we implement
2007 SAVE_TARGETS, and seems unnecessary anyway.
2008 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2009 (Vx_sent_selection_functions): Doc fix.
2010
0f4aebc0
LL
20112011-05-26 Leo Liu <sdl.web@gmail.com>
2012
2013 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2014
e61124cd
YM
20152011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2016
2017 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2018
2019 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2020 for fringe update if it has periodic bitmap.
2021 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2022 and fringe_bitmap_periodic_p.
2023
2024 * fringe.c (get_fringe_bitmap_data): New function.
2025 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2026 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2027 row. Mark glyph row for fringe update if periodicity changed.
2028
2029 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2030 for fringe update unless it has periodic bitmap.
2031
f16d9837
KH
20322011-05-25 Kenichi Handa <handa@m17n.org>
2033
2034 * xdisp.c (get_next_display_element): Set correct it->face_id for
2035 a static composition.
2036
e1b90ef6
LL
20372011-05-24 Leo Liu <sdl.web@gmail.com>
2038
2039 * deps.mk (fns.o):
2040 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2041
2042 * fns.c (crypto_hash_function, Fsha1): New function.
2043 (Fmd5): Use crypto_hash_function.
2044 (syms_of_fns): Add Ssha1.
2045
7400048f
PE
20462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2047
2048 * gnutls.c: Remove unused macros.
2049 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2050 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2051 Remove macros that are defined and never used.
2052 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2053
abb71cf4
CY
20542011-05-22 Chong Yidong <cyd@stupidchicken.com>
2055
2056 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2057 (Fx_get_selection_internal): Minor cleanup.
2058 (Fx_own_selection_internal): Rename arguments for consistency with
2059 select.el.
2060
6307db39
PE
20612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2062
2063 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2064
f3d4e0a4
CY
20652011-05-22 Chong Yidong <cyd@stupidchicken.com>
2066
2067 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2068
4d8ade89
YM
20692011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2070
2071 * dispnew.c (scrolling_window): Don't exclude the case that the
2072 last enabled row in the desired matrix touches the bottom boundary.
2073
32078c8d
GM
20742011-05-21 Glenn Morris <rgm@gnu.org>
2075
2076 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2077 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2078 and add some more files.
32078c8d 2079
7285dc67
EZ
20802011-05-20 Eli Zaretskii <eliz@gnu.org>
2081
2082 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2083 report_file_error introduced by the change from 2011-05-07.
2084
89d1bd22
PE
20852011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2086
2087 * systime.h (Time): Define only if emacs is defined.
2088 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2089 where the include path doesn't have X11/X.h by default. See
2090 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2091
e23640bb 20922011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2093
2094 * composite.c (find_automatic_composition): Fix previous change.
2095
b9704ad9
GM
20962011-05-20 Glenn Morris <rgm@gnu.org>
2097
2098 * lisp.mk: New file, split from Makefile.in.
2099 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2100 (shortlisp): Remove.
2101 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2102
4a720484
GM
21032011-05-19 Glenn Morris <rgm@gnu.org>
2104
2105 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2106 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2107 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2108 (lisp): Set the order to that of loadup.el.
2109 (shortlisp): Make it a copy of $lisp.
2110 (SOME_MACHINE_LISP): Remove.
2111 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2112 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2113
a28d4396
KH
21142011-05-18 Kenichi Handa <handa@m17n.org>
2115
2116 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2117 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2118 (find_automatic_composition): Mostly rewrite for efficiency.
2119
a2b1fa8e
JB
21202011-05-18 Juanma Barranquero <lekktu@gmail.com>
2121
2122 * makefile.w32-in: Update dependencies.
2123
8e1f5610
CS
21242011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2125
2126 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2127 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2128
7025ee00 21292011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2130
cdfa6eab
PE
2131 Fix some integer overflow issues, such as string length overflow.
2132
06d6db33
PE
2133 * insdel.c (count_size_as_multibyte): Check for string overflow.
2134
2b4560a8
PE
2135 * character.c (lisp_string_width): Check for string overflow.
2136 Use EMACS_INT, not int, for string indexes and lengths; in
2137 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2138 the resulting string length overflows an EMACS_INT; instead,
2139 report a string overflow if no precision given. When checking for
2140 precision exhaustion, use a check that cannot possibly have
2141 integer overflow. (Bug#8675)
2142 * character.h (lisp_string_width): Adjust to new signature.
2143
cb93f9be
PE
2144 * alloc.c (string_overflow): New function.
2145 (Fmake_string): Use it. This doesn't change behavior, but saves
2146 a few bytes and will simplify future changes.
2147 * character.c (string_escape_byte8): Likewise.
2148 * lisp.h (string_overflow): New decl.
2149
1a1f3366
PE
2150 Fixups, following up to the user-interface timestamp change.
2151 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2152 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2153 * msdos.c (mouse_get_pos): Likewise.
2154 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2155 * w32gui.h (Time): Define by including "systime.h" rather than by
2156 declaring it ourselves. (Bug#8664)
2157
d4e3e4d3
PE
2158 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2159 * image.c (clear_image_cache): Likewise.
2160
f6a24d19
PE
2161 * term.c (term_mouse_position): Don't assume time_t wraparound.
2162
08dc5ae6
PE
2163 Be more systematic about user-interface timestamps.
2164 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2165 and sometimes 'EMACS_UINT', to represent these timestamps.
2166 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2167 This makes the code easier to follow, and makes it easier to catch
2168 integer overflow bugs such as Bug#8664.
2169 * frame.c (Fmouse_position, Fmouse_pixel_position):
2170 Use Time, not unsigned long, for user-interface timestamps.
2171 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2172 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2173 * keyboard.h (last_event_timestamp): Likewise.
2174 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2175 * menu.h (xmenu_show): Likewise.
2176 * term.c (term_mouse_position): Likewise.
2177 * termhooks.h (struct input_event.timestamp): Likewise.
2178 (struct terminal.mouse_position_hook): Likewise.
2179 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2180 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2181 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2182 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2183 what it was before.
2184 * menu.h, termhooks.h: Include "systime.h", for Time.
2185
8e55734a
PE
2186 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2187 Don't assume that the difference between two unsigned long values
2188 can fit into an integer. At this point, we know button_down_time
2189 <= event->timestamp, so the difference must be nonnegative, so
2190 there's no need to cast the result if double-click-time is
2191 nonnegative, as it should be; check that it's nonnegative, just in
2192 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2193 apart (about 25 days). (Bug#8664)
8e55734a 2194
841f1b75 2195 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2196 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2197
3e26f69c
PE
2198 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2199 that always fit in int. Use a sentinel instead of a counter, to
2200 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2201 * frame.h (struct frame): Use int for menu_bar_items_used
2202 instead of EMACS_INT, since it always fits in int.
3e26f69c 2203
5cc152c0
PE
2204 * menu.c (grow_menu_items): Check for int overflow.
2205
d89eb65e
PE
2206 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2207
5235bd3e
PE
2208 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2209 Before, the code was not consistent. These values cannot exceed
2210 2**31 - 1 so there's no need to make them unsigned.
2211 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2212 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2213 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2214 as modifiers.
2215 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2216
bc827e23
PE
2217 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2218 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2219 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2220 presumably because the widths might not match.
2221
78eb494e
PE
2222 * window.c (size_window): Avoid needless test at loop start.
2223
04f2d78b
CB
22242011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2225
2226 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2227
d2fc7e3d 22282011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2229
2230 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2231
d2fc7e3d 22322011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2233
2234 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2235 `width' to `bar_area_x' and `bar_area_width', respectively.
2236 (x_scroll_run): Take account of fringe background extension.
2237
04f2d78b
CB
2238 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2239 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2240 `bar_area_width', respectively.
2241 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2242 background extension.
2243
79b70037
GM
22442011-05-10 Jim Meyering <meyering@redhat.com>
2245
2246 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2247
2f142cc5
JB
22482011-05-10 Juanma Barranquero <lekktu@gmail.com>
2249
2250 * image.c (Finit_image_library): Return t for built-in image types,
2251 like pbm and xbm. (Bug#8640)
2252
57679c86
AS
22532011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2254
2255 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2256
888c9e86
EZ
22572011-05-07 Eli Zaretskii <eliz@gnu.org>
2258
b0512a1d
EZ
2259 * w32console.c (Fset_screen_color): Doc fix.
2260 (Fget_screen_color): New function.
2261 (syms_of_ntterm): Defsubr it.
2262
7285dc67
EZ
2263 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2264 unlink the temporary file if Fcall_process didn't create it in the
2265 first place.
2266 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2267 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2268 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2269 cue to call_process_cleanup not to close that handle.
2270
4d3fcc8e
BK
22712011-05-07 Ben Key <bkey76@gmail.com>
2272
2273 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2274 one of two shell specific rules, either bootstrap-temacs-CMD or
2275 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2276 to the previous implementation of the bootstrap-temacs rule.
2277 The bootstrap-temacs-CMD rule is similar to the previous
2278 implementation of the bootstrap-temacs rule except that it
2279 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2280 variable.
2281
2282 These changes, along with some changes to nt/configure.bat,
2283 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2284 earlier fix to add support for --cflags and --ldflags options
2285 that include quotes so that it works whether make uses cmd or
2286 sh as the shell.
2287
b4289b64
MA
22882011-05-06 Michael Albinus <michael.albinus@gmx.de>
2289
2290 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2291 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2292 is a constant.
2293 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2294 a string. Handle both cases.
2295 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2296 (Fdbus_register_method): Use Qinvalid_function.
2297
af4c0e28
JB
22982011-05-06 Juanma Barranquero <lekktu@gmail.com>
2299
2300 * makefile.w32-in: Update dependencies.
2301 (LISP_H): Add inttypes.h and stdin.h.
2302 (PROCESS_H): Add unistd.h.
2303
c51453d9
EZ
23042011-05-06 Eli Zaretskii <eliz@gnu.org>
2305
2306 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2307 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2308
8ff0ac3c 23092011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2310
4c4b566b
PE
2311 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2312
aab2b9b5
PE
2313 * term.c (vfatal): Remove stray call to va_end.
2314 It's not needed and the C Standard doesn't allow it here anyway.
2315
c378da0b
PE
2316 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2317 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2318
288b08c7
PE
2319 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2320 bytes.
2321
e3601888
PE
2322 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2323
db6c0e74
PE
2324 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2325
dd5963ea
PE
2326 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2327
88c9450f
PE
2328 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2329
2f9442b8
PE
2330 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2331
c032b5f8
PE
2332 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2333 * charset.c (Fdefine_charset_internal): Don't initialize
2334 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2335 32-bit int (Bug#8600).
a108c10b
PE
2336
2337 * lread.c (read_integer): Be more consistent with string-to-number.
2338 Use string_to_number to do the actual conversion; this avoids
2339 rounding errors and fixes some other screwups. Without this fix,
2340 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2341 (digit_to_number): Move earlier, for benefit of read_integer.
2342 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2343 not a digit in any supported base. (Bug#8602)
a108c10b 2344
ad5f9eea
PE
2345 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2346
aec1708a
PE
2347 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2348 to match comment at start of function. This also removes a
2349 GCC warning about overflow in a 32+64-bit port.
2350
47be4ab5
PE
2351 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2352
371cac43
PE
2353 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2354 Reported by Stefan Monnier in
2355 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2356 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2357 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2358
d01a7826
PE
2359 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2360 (EMACS_UINTPTR): Likewise, with uintptr_t.
2361
7fd47d5c
PE
2362 * lisp.h: Prefer 64-bit EMACS_INT if available.
2363 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2364 on 32-bit hosts that have 64-bit int, so that they can access
2365 large files.
122b0c86
PE
2366 However, temporarily disable this change unless the temporary
2367 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2368
8727937b
PE
2369 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2370
8ac068ac
PE
2371 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2372 This removes an assumption that EMACS_INT and long are the same
2373 width as pointers. The assumption is true for Emacs porting targets
2374 now, but we want to make other targets possible.
2375 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2376 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2377 In the rest of the code, change types of integers that hold casted
2378 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2379 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2380 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2381 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2382 No need to cast type when ORing.
2383 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2384 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2385 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2386 assume EMACS_INT is the same width as char *.
2387 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2388 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2389 Remove no-longer-needed casts.
2390 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2391 (xg_tool_bar_help_callback, xg_make_tool_item):
2392 Use EMACS_INTPTR to hold an integer
2393 that will be cast to void *; this can avoid a GCC warning
2394 if EMACS_INT is not the same width as void *.
2395 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2396 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2397 (current_message_1, set_message_1):
2398 Use a local to convert to proper width without a cast.
2399 * xmenu.c (dialog_selection_callback): Likewise.
2400
ede49d71
PE
2401 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2402 Also, don't assume VALBITS / RAND_BITS is less than 5,
2403 and don't rely on undefined behavior when shifting a 1 left into
2404 the sign bit.
2405 * lisp.h (get_random): Change signature to match.
2406
2f30ecd0
PE
2407 * lread.c (hash_string): Use size_t, not int, for hash computation.
2408 Normally we prefer signed values; but hashing is special, because
2409 it's better to use unsigned division on hash table sizes so that
2410 the remainder is nonnegative. Also, size_t is the natural width
2411 for hashing into memory. The previous code used 'int', which doesn't
2412 retain enough info to hash well into very large tables.
2413 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2414
2a866e7b
PE
2415 * dbusbind.c: Don't possibly lose pointer info when converting.
2416 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2417 Use XPNTR rather than XHASH, so that the high-order bits of
2418 the pointer aren't lost when converting through void *.
2419
51639eac
PE
2420 * eval.c (Fautoload): Don't double-shift a pointer.
2421
92394119
PE
2422 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2423
dbdb9a7c
JB
24242011-05-06 Juanma Barranquero <lekktu@gmail.com>
2425
2426 * gnutls.c (DEF_GNUTLS_FN):
2427 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2428
db7a0b4f
AS
24292011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2430
2431 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2432 marker. (Bug#8610)
2433
f7ff1b0f 24342011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2435
2436 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2437 New version that can reserve upto 2GB of heap space.
2438
f7ff1b0f 24392011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2440
2441 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2442
639c109b
TZ
24432011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2444
2445 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2446 `gnutls_certificate_set_x509_key_file'.
2447
d2127135
JB
24482011-05-05 Juanma Barranquero <lekktu@gmail.com>
2449
2450 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2451 Update dependencies.
2452
e968f4f3
JB
24532011-05-04 Juanma Barranquero <lekktu@gmail.com>
2454
2455 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2456 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2457 Remove unused parameter `fildes'.
2458 * process.c (read_process_output, send_process): Don't pass it.
2459
84d358f0
JB
24602011-05-04 Juanma Barranquero <lekktu@gmail.com>
2461
2462 Fix previous change: the library cache is defined in w32.c.
2463 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2464 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2465
0898ca10
JB
24662011-05-04 Juanma Barranquero <lekktu@gmail.com>
2467
2468 Implement dynamic loading of GnuTLS on Windows.
2469
2470 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2471 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2472 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2473 Declare.
2474
2475 * gnutls.c (Qgnutls_dll): Define.
2476 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2477 (gnutls_*): Declare function pointers.
2478 (init_gnutls_functions): New function to initialize function pointers.
2479 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2480 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2481 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2482 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2483 (emacs_gnutls_write, emacs_gnutls_read)
2484 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2485 (Fgnutls_available_p): New function.
2486 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2487 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2488 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2489
2490 * image.c: Include w32.h.
2491 (Vimage_type_cache): Delete.
2492 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2493 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2494 (w32_delayed_load): Move to w32.c.
2495
2496 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2497
2498 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2499 (w32_delayed_load): Move from image.c. When loading a library, record
2500 its filename in the :loaded-from property of the library id.
2501 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2502 Initialize and staticpro them.
2503 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2504
2505 * process.c: Include lisp.h before w32.h, not after.
2506 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2507 instead of gnutls_record_check_pending.
2508
2509 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2510
ff4de4aa
TZ
25112011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2512
2513 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2514 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2515 as passed in.
2516
abe95abb
JD
25172011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2518
2519 * xterm.c (x_set_frame_alpha): Do not set property on anything
2520 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2521
e16e55d4
JB
25222011-05-02 Juanma Barranquero <lekktu@gmail.com>
2523
2524 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2525
bafcf6a5
JB
25262011-05-02 Juanma Barranquero <lekktu@gmail.com>
2527
2528 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2529 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2530 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2531 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2532 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2533 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2534 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2535 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2536 (Qgnutls_bootprop_callbacks_verify): Make static.
2537
e7a6747f
AS
25382011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2539
19ed11ba
AS
2540 * callproc.c: Indentation fixup.
2541
e7a6747f 2542 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2543 (wait_for_termination, interruptible_wait_for_termination):
2544 Move after wait_for_termination_1.
e7a6747f 2545
1ef14cb4
LMI
25462011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2547
2548 * sysdep.c (interruptible_wait_for_termination): New function
2549 which is like wait_for_termination, but allows keyboard
2550 interruptions.
2551
2552 * callproc.c (Fcall_process): Add (:file "file") as an option for
2553 the STDOUT buffer.
2554 (Fcall_process_region): Ditto.
2555
330d880c
EZ
25562011-04-30 Eli Zaretskii <eliz@gnu.org>
2557
8db90b73
EZ
2558 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2559 rather than `XVECTOR (FOO)->size'.
2560
330d880c
EZ
2561 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2562 inttypes.h, as a gnulib replacement is used if it not available in
2563 system headers.
2564
15cbd324
EZ
25652011-04-21 Eli Zaretskii <eliz@gnu.org>
2566
2567 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2568 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2569 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2570
2571 * coding.c (coding_alloc_by_realloc): Error out if destination
2572 will grow beyond MOST_POSITIVE_FIXNUM.
2573 (decode_coding_emacs_mule): Abort if there isn't enough place in
2574 charbuf for the composition carryover bytes. Reserve an extra
2575 space for up to 2 characters produced in a loop.
2576 (decode_coding_iso_2022): Abort if there isn't enough place in
2577 charbuf for the composition carryover bytes.
2578
25792011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2580
ae940cca
EZ
2581 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2582 aborting when %lld or %lll format is passed.
2583 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2584 %llo or %llx format is passed. (Bug#8545)
2585
03ab8921
EZ
2586 * window.c (window_scroll_line_based): Use a marker instead of
2587 simple variables to record original value of point. (Bug#7952)
2588
afda1437
EZ
2589 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2590 produced by %s or %c overflows available buffer space. (Bug#8545)
2591
f76dee0c
PE
25922011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2593
2594 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2595 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2596
fdc5744d
JB
25972011-04-28 Juanma Barranquero <lekktu@gmail.com>
2598
2599 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2600
638f053a
JB
26012011-04-28 Juanma Barranquero <lekktu@gmail.com>
2602
2603 * keyboard.c (Qdelayed_warnings_hook): Define.
2604 (command_loop_1): Run `delayed-warnings-hook'
2605 if Vdelayed_warnings_list is non-nil.
2606 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2607 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2608
d178f871
EZ
26092011-04-28 Eli Zaretskii <eliz@gnu.org>
2610
2611 * doprnt.c (doprnt): Don't return value smaller than the buffer
2612 size if the message was truncated. (Bug#8545).
2613
b124fd93
JB
26142011-04-28 Juanma Barranquero <lekktu@gmail.com>
2615
2616 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2617 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2618
e810457d
PE
26192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2620
2621 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2622
ea51cceb
JB
26232011-04-27 Juanma Barranquero <lekktu@gmail.com>
2624
2625 * makefile.w32-in: Update dependencies.
2626
94dcfacf
EZ
26272011-04-27 Eli Zaretskii <eliz@gnu.org>
2628
2629 Improve `doprnt' and its usage. (Bug#8545)
2630 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2631 `format_end'. Remove support for %l as a conversion specifier.
2632 Don't use xrealloc. Improve diagnostics when the %l size modifier
2633 is used. Update the commentary.
2634
2635 * eval.c (verror): Simplify calculation of size_t.
2636
2637 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2638 messages.
2639
f61f41d7
PE
26402011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2641
2642 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2643 change.
2644
96fb4434
PE
26452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2646
2647 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2648 This makes this file independent of the recent pseudovector change.
2649
671875da 26502011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2651
69e9b5a3
PE
2652 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2653
b5f869a7 2654 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2655 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2656 Remove unused local.
c8926152 2657 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2658
841a1577 2659 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2660 GCC 4.6.0 optimizes based on type-based alias analysis.
2661 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2662 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2663 != &v->size, and therefore "v->size = 1; b->size = 2; return
2664 v->size;" must therefore return 1. This assumption is incorrect
2665 for Emacs, since it type-puns struct Lisp_Vector * with many other
2666 types. To fix this problem, this patch adds a new type struct
f904488f 2667 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2668 and pseudovectors, and helps optimizing compilers not get fooled
2669 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2670 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2671 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2672 the size member.
eab3844f
PE
2673 (XSETPVECTYPE): Rewrite in terms of new macro.
2674 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2675 This is a bit clearer, and further avoids the possibility of
2676 undesirable aliasing.
2677 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2678 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2679 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2680 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2681 (ASIZE): Now uses header.size rather than size.
2682 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2683 to avoid the hassle of writing XVECTOR (foo)->header.size.
2684 (struct vectorlike_header): New type.
eab3844f
PE
2685 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2686 object, to help avoid aliasing.
2687 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2688 (SUBRP): Likewise, since Lisp_Subr is a special case.
2689 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2690 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2691 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2692 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2693 changed to be "header.size" and "header.next".
2694 * buffer.h (struct buffer): Likewise.
2695 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2696 * frame.h (struct frame): Likewise.
2697 * process.h (struct Lisp_Process): Likewise.
2698 * termhooks.h (struct terminal): Likewise.
2699 * window.c (struct save_window_data, struct saved_window): Likewise.
2700 * window.h (struct window): Likewise.
2701 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2702 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2703 * buffer.c (init_buffer_once): Likewise.
2704 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2705 special case.
2706 * process.c (Fformat_network_address): Use local var for size,
2707 for brevity.
2708
0df1eac5
PE
2709 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2710
847ab9d1 2711 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2712 * data.c (atof): Remove decl; no longer used or needed.
2713 (digit_to_number): Move to lread.c.
2714 (Fstring_to_number): Use new string_to_number function, to be
2715 consistent with how the Lisp reader treats infinities and NaNs.
2716 Do not assume that floating-point numbers represent EMACS_INT
2717 without losing information; this is not true on most 64-bit hosts.
2718 Avoid double-rounding errors, by insisting on integers when
2719 parsing non-base-10 numbers, as the documentation specifies.
2720 * lisp.h (string_to_number): New decl, replacing ...
2721 (isfloat_string): Remove.
bc0a5c13 2722 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2723 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2724 appears to have been a coding error. Similarly, do not accept
2725 strings like +-1e0 as floating point numbers. Do not report
2726 overflow for integer overflows unless the base is not 10 which
2727 means we have no simple and reliable way to continue.
2728 Break out the floating-point parsing into a new
2729 function string_to_number, so that Fstring_to_number parses
2730 floating point numbers consistently with the Lisp reader.
04f2d78b 2731 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2732 (E_CHAR, EXP_INT): Remove, replacing with ...
2733 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2734 (string_to_number): New function, replacing isfloat_string.
2735 This function checks for valid syntax and produces the resulting
2736 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2737 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2738 so that overflow for non-base-10 numbers is reported only when
2739 there's no portable and simple way to convert to floating point.
452f4150 2740
67769ffc
PE
2741 * textprop.c (set_text_properties_1): Rewrite for clarity,
2742 and to avoid GCC warning about integer overflow.
2743
c20db43f
PE
2744 * intervals.h (struct interval): Use EMACS_INT for members
2745 where EMACS_UINT might cause problems. See
2746 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2747 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2748 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2749 All uses changed.
37aa2f85
PE
2750 (offset_intervals): Tell GCC not to worry about length overflow
2751 when negating a negative length.
c20db43f 2752
2538aa2f
PE
2753 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2754 (overrun_check_free): Likewise.
2755
f2d3008d
PE
2756 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2757 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2758 word size.
2759
ec8df744
PE
2760 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2761 (gnutls_make_error): Rename local to avoid shadowing.
2762 (gnutls_emacs_global_deinit): ifdef out; not used.
2763 (Fgnutls_boot): Use const for pointer to readonly storage.
2764 Comment out unused local. Fix pointer signedness problems.
2765
640ee02d
PE
2766 * lread.c (openp): Don't stuff size_t into an 'int'.
2767 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2768 about possible signed overflow.
2769
6048fb2a
PE
2770 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2771 (GDK_KEY_g): Don't define if already defined.
2772 (xg_prepare_tooltip): Avoid pointer signedness problem.
2773 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2774
fa3c87e1
PE
2775 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2776 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2777
2172544b
PE
2778 * xfns.c (Fx_window_property): Simplify a bit,
2779 to make a bit faster and to avoid GCC 4.6.0 warning.
2780 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2781
9b821a21
PE
2782 * fns.c (internal_equal): Don't assume size_t fits in int.
2783
3c616cfa
PE
2784 * alloc.c (compact_small_strings): Tighten assertion a little.
2785
c2982e87
PE
2786 Replace pEd with more-general pI, and fix some printf arg casts.
2787 * lisp.h (pI): New macro, generalizing old pEd macro to other
2788 conversion specifiers. For example, use "...%"pI"d..." rather
2789 than "...%"pEd"...".
2790 (pEd): Remove. All uses replaced with similar uses of pI.
2791 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2792 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2793 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2794 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2795 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2796 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2797 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2798 64-bit hosts.
2799 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2800 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2801 * print.c (safe_debug_print, print_object): Likewise.
2802 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2803 to int.
6f04d126
PE
2804 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2805 avoiding the 0 flag, which is not portable.
c2982e87
PE
2806 * process.c (Fmake_network_process): Use pI to avoid cast.
2807 * region-cache.c (pp_cache): Likewise.
2808 * xdisp.c (decode_mode_spec): Likewise.
2809 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2810 behavior on 64-bit hosts with printf arg.
6f04d126 2811 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2812 (x_stop_queuing_selection_requests): Likewise.
2813 (x_get_window_property): Don't truncate byte count to an 'int'
2814 when tracing.
0b432f21 2815
5e073ec7
PE
2816 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2817 here, since it parses constructs like leading '-' and spaces,
2818 which are not wanted; and it overflows with large numbers.
2819 Instead, simply match F[0-9]+, which is what is wanted anyway.
2820
36372bf9
PE
2821 * alloc.c: Remove unportable assumptions about struct layout.
2822 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2823 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2824 (allocate_vectorlike, make_pure_vector): Use the new macros,
2825 plus offsetof, to remove unportable assumptions about struct layout.
2826 These assumptions hold on all porting targets that I know of, but
2827 they are not guaranteed, they're easy to remove, and removing them
2828 makes further changes easier.
2829
0b432f21
PE
2830 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2831 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2832 (string_overrun_cookie): Now const. Use initializers that
2833 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2834 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2835 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2836 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2837 multiple of sizeof (EMACS_INT); it need not be, if
2838 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2839 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2840
895009e1
JB
28412011-04-26 Juanma Barranquero <lekktu@gmail.com>
2842
2843 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2844
6a7a1b0b
TZ
28452011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2846
2847 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2848 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2849 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2850
841a1577 28512011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2852
2853 * lisp.h (Qdebug): List symbol.
895009e1 2854 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2855 * keyboard.c (debug-on-event): New variable.
2856 (handle_user_signal): Break into debugger when debug-on-event
2857 matches the current signal symbol.
2858
f2d3ba6f
DN
28592011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2860
2861 * alloc.c (check_sblock, check_string_bytes)
2862 (check_string_free_list): Convert to standard C.
2863
42ce4c63
TZ
28642011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2865
2866 * w32.c (emacs_gnutls_push): Fix typo.
2867
825cd63c
EZ
28682011-04-25 Eli Zaretskii <eliz@gnu.org>
2869
fb11d64d
EZ
2870 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2871 "cast to pointer from integer of different size".
2872
825cd63c
EZ
2873 Improve doprnt and its use in verror. (Bug#8545)
2874 * doprnt.c (doprnt): Document the set of format control sequences
2875 supported by the function. Use SAFE_ALLOCA instead of always
2876 using `alloca'.
2877
2878 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2879 is one byte too soon. Don't use xrealloc; instead xfree and
2880 xmalloc anew.
2881
e061a11b
TZ
28822011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2883
2884 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2885 callbacks stage.
2886
2887 * gnutls.c: Renamed global_initialized to
2888 gnutls_global_initialized. Added internals for the
2889 :verify-hostname-error, :verify-error, and :verify-flags
2890 parameters of `gnutls-boot' and documented those parameters in the
2891 docstring. Start callback support.
9173deec
JB
2892 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2893 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2894 on error. Return error code.
e061a11b
TZ
2895 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2896 (emacs_gnutls_read): Likewise.
2897 (Fgnutls_boot): Return handshake error code.
2898 (emacs_gnutls_handle_error): New function.
2899 (wsaerror_to_errno): Likewise.
2900
2901 * w32.h (emacs_gnutls_pull): Add prototype.
2902 (emacs_gnutls_push): Likewise.
2903
2904 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2905 (emacs_gnutls_push): Likewise.
2906
29072011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2908
2909 * process.c (wait_reading_process_output): Check if GnuTLS
2910 buffered some data internally if no FDs are set for TLS
2911 connections.
2912
2913 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2914 (LIBS): Link to USER_LIBS.
2915 ($(BLD)/gnutls.$(0)): New target.
2916
fa6996bc
EZ
29172011-04-24 Eli Zaretskii <eliz@gnu.org>
2918
eb35682e
EZ
2919 * xdisp.c (handle_single_display_spec): Rename the
2920 display_replaced_before_p argument into display_replaced_p, to
2921 make it consistent with the commentary. Fix typos in the
2922 commentary.
2923
e2ad650c
EZ
2924 * textprop.c (syms_of_textprop): Remove dead code.
2925 (copy_text_properties): Delete obsolete commentary about an
2926 interface that was deleted long ago. Fix typos in the description
2927 of arguments.
2928
1b2de274
EZ
2929 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2930 to changes in oldXMenu/XMenu.h from 2011-04-16.
2931 <menu_help_message, prev_menu_help_message>: Constify.
2932 (IT_menu_make_room): menu->help_text is now `const char **';
2933 adjust.
2934
2935 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2936 to changes in oldXMenu/XMenu.h from 2011-04-16.
2937 (struct XMenu): Declare `help_text' `const char **'.
2938
2939 * xfaces.c <Qunspecified>: Make extern again.
2940
2941 * syntax.c: Include sys/types.h before including regex.h, as
2942 required by Posix.
2943
762b15be
EZ
2944 * doc.c (get_doc_string): Improve the format passed to `error'.
2945
2946 * doprnt.c (doprnt): Improve commentary.
2947
2948 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2949
2950 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2951 them with etags.
2952
f1052e5d
EZ
2953 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2954 changes in globals.h immediately force recompilation.
762b15be
EZ
2955 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2956 $(CURDIR)/s/ms-w32.h.
2957 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2958
fa6996bc
EZ
2959 * character.c (Fchar_direction): Function deleted.
2960 (syms_of_character): Don't defsubr it.
2961 <char-direction-table>: Deleted.
2962
e6c3da20
EZ
29632011-04-23 Eli Zaretskii <eliz@gnu.org>
2964
2965 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2966 * doprnt.c: Include limits.h.
2967 (SIZE_MAX): New macro.
04f2d78b
CB
2968 (doprnt): Return a size_t value. 2nd arg is now size_t.
2969 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2970 Improve overflow protection. Support `l' modifier for integer
2971 conversions. Support %l conversion. Don't assume an EMACS_INT
2972 argument for integer conversions and for %c.
2973
2974 * lisp.h (doprnt): Restore prototype.
2975
2976 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2977 $(SRC)/character.h.
2978
2979 * Makefile.in (base_obj): Add back doprnt.o.
2980
2981 * deps.mk (doprnt.o): Add back prerequisites.
2982 (callint.o): Depend on character.h.
2983
2984 * eval.c (internal_lisp_condition_case): Include the handler
2985 representation in the error message.
2986 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2987 when breaking from the loop.
2988
2989 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2990
2991 * callint.c (Fcall_interactively): When displaying error message
2992 about invalid control letter, pass the character's codepoint, not
2993 a pointer to its multibyte form. Improve display of the character
2994 in octal and display also its hex code.
2995
2996 * character.c (char_string): Use %x to display the (unsigned)
2997 codepoint of an invalid character, to avoid displaying a bogus
2998 negative value.
2999
3000 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3001 `error', not SYMBOL_NAME itself.
3002
3003 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3004 character arguments to `error'.
3005
3006 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3007 to `error' in error message about FINAL_CHAR argument. Make sure
3008 FINAL_CHAR is a character, and use %c when it is passed as
3009 argument to `error'.
3010
4ffd0d6b 30112011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3012
3013 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3014
3015 * w32.c: Include <time.h>.
3016 (sys_localtime): New function.
3017
4ffd0d6b 30182011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3019
3020 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3021
4ffd0d6b 3022 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3023
4ffd0d6b 30242011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3025
4ffd0d6b
GM
3026 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3027 zombies (Bug#8467).
aac0c6e3 3028
04c56954
EZ
30292011-04-19 Eli Zaretskii <eliz@gnu.org>
3030
3031 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3032 gl_state.e_property when gl_state.object is Qt.
3033
3034 * insdel.c (make_gap_larger): Remove limitation of buffer size
3035 to <= INT_MAX.
3036
16a43933
CY
30372011-04-18 Chong Yidong <cyd@stupidchicken.com>
3038
3039 * xdisp.c (lookup_glyphless_char_display)
3040 (produce_glyphless_glyph): Handle cons cell entry in
3041 glyphless-char-display.
3042 (Vglyphless_char_display): Document it.
3043
3044 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3045 glyphless-char-display.
3046
4581706e
CY
30472011-04-17 Chong Yidong <cyd@stupidchicken.com>
3048
3049 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3050
3051 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3052
3053 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3054 definition for no-X builds.
3055
4887c6e2 30562011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3057
fd35b6f9
PE
3058 Static checks with GCC 4.6.0 and non-default toolkits.
3059
5c1ccb01
PE
3060 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3061
006c5daa
PE
3062 * process.c (keyboard_bit_set): Define only if SIGIO.
3063 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3064 (send_process): Repair possible setjmp clobbering.
3065
efc736d3
PE
3066 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3067
4e2fe2e6
PE
3068 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3069
f97334a2
PE
3070 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3071
4e75f29d
PE
3072 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3073 Define only if needed.
3074
90efadd1
PE
3075 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3076 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3077 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3078
3c647824
PE
3079 * dispextern.h (struct redisplay_interface): Rename param
3080 to avoid shadowing.
e264f262 3081 * termhooks.h (struct terminal): Likewise.
761383f4 3082 * xterm.c (xembed_send_message): Likewise.
3c647824 3083
b58c5c4a
PE
3084 * insdel.c (make_gap_smaller): Define only if
3085 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3086
cad59032
PE
3087 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3088 it.
3089
c339dc2e
PE
3090 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3091 so that we aren't warned about unused symbols.
3092
91a3e27b
PE
3093 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3094
399c71d3 3095 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3096
8ffc96f5
PE
3097 * xfns.c (x_real_positions): Mark locals as initialized.
3098
eef9bc79
PE
3099 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3100
098db9dd
PE
3101 * xterm.c: Fix problems found by static analysis with other toolkits.
3102 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3103 (x_dispatch_event): Declare static if USE_GTK, and
3104 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3105 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3106 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3107 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3108 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3109
eb18f6cc
PE
3110 * xmenu.c (menu_help_callback): Pointer type fixes.
3111 Use const pointers when pointing at readonly data. Avoid pointer
3112 signedness clashes.
3113 (FALSE): Remove unused macro.
3114 (update_frame_menubar): Remove unused decl.
3115
1fe72bf8
PE
3116 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3117
60d9e1db
PE
3118 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3119 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3120 (single_menu_item): Rename local to avoid shadowing.
3121
39261c26
PE
3122 * keyboard.c (make_lispy_event): Remove unused local var.
3123
018c5e19
PE
3124 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3125 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3126
63d2b86e
PE
3127 * bitmaps: Change bitmaps from unsigned char back to the X11
3128 compatible char. Avoid the old compiler warnings about
3129 out-of-range initializers by using, for example, '\xab' rather
3130 than 0xab.
3131
aefd87e1
PE
3132 * xgselect.c (xgselect_initialize): Check vs interface
3133 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3134
bf501fb9
PE
3135 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3136
e9829fdf
PE
3137 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3138 to read-only memory.
3139
1086c095
PE
3140 * fns.c (vector): Remove; this old hack is no longer needed.
3141
2baccd04 3142 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3143 Remove unused var.
dde42981 3144 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3145
72391843 3146 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3147
436c16df 3148 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3149 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3150 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3151
92bb796d 3152 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3153 (x_term_init): Remove local to avoid shadowing.
92bb796d 3154
764430a3 3155 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3156
3157 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3158 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3159
d1dfb56c
EZ
31602011-04-16 Eli Zaretskii <eliz@gnu.org>
3161
c4354cb4
EZ
3162 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3163
d1dfb56c
EZ
3164 Fix regex.c, syntax.c and friends for buffers > 2GB.
3165 * syntax.h (struct gl_state_s): Declare character position members
3166 EMACS_INT.
3167
3168 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3169
04f2d78b
CB
3170 * textprop.c (verify_interval_modification, interval_of):
3171 Declare arguments EMACS_INT.
d1dfb56c
EZ
3172
3173 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3174 EMACS_INT.
3175
3176 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3177
3178 * indent.c (Fvertical_motion): Local variable it_start is now
3179 EMACS_INT.
3180
3181 * regex.c (re_match, re_match_2, re_match_2_internal)
3182 (bcmp_translate, regcomp, regexec, print_double_string)
3183 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3184 (re_compile_pattern, re_exec): Declare arguments and local
3185 variables `size_t' and `ssize_t' and return values `regoff_t', as
3186 appropriate.
3187 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3188 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3189 <compile_stack_type>: `size' and `avail' are now `size_t'.
3190
3191 * regex.h <regoff_t>: Use ssize_t, not int.
3192 (re_search, re_search_2, re_match, re_match_2): Arguments that
3193 specify buffer/string position and length are now ssize_t and
3194 size_t. Return type is regoff_t.
3195
613052cd
BK
31962011-04-16 Ben Key <bkey76@gmail.com>
3197
3198 * nsfont.m: Fixed bugs in ns_get_family and
3199 ns_descriptor_to_entity that were caused by using free to
3200 deallocate memory blocks that were allocated by xmalloc (via
3201 xstrdup). This caused Emacs to crash when compiled with
3202 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3203 --enable-checking=xmallocoverrun). xfree is now used to
3204 deallocate these memory blocks.
3205
4170f62f 32062011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3207
71b41406
PE
3208 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3209
9587a89d
PE
3210 emacs_write: Accept and return EMACS_INT for sizes.
3211 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3212 et seq.
3213 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3214 Accept and return EMACS_INT.
3215 (emacs_gnutls_write): Return the number of bytes written on
3216 partial writes.
3217 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3218 (emacs_read, emacs_write): Remove check for negative size, as the
3219 Emacs source code has been audited now.
9587a89d
PE
3220 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3221 (emacs_read, emacs_write): Use it.
273a5f82
PE
3222 * process.c (send_process): Adjust to the new signatures of
3223 emacs_write and emacs_gnutls_write. Do not attempt to store
3224 a byte offset into an 'int'; it might overflow.
9587a89d 3225 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3226
3e047f51
PE
3227 * sound.c: Don't assume sizes fit in 'int'.
3228 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3229 Return EMACS_INT, not int.
3e047f51 3230 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3231 Accept EMACS_INT, not int.
3232 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3233 record read return values.
3234
cc39a9db
BK
32352011-04-15 Ben Key <bkey76@gmail.com>
3236
c9d0ec6d
JB
3237 * keyboard.c (Qundefined): Don't declare static since it is used
3238 in nsfns.m.
3239 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3240 static since they are used in nsfont.m.
cc39a9db 3241
6c60eb9f
SM
32422011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3243
3244 * process.c (Qprocessp): Don't declare static.
3245 * lisp.h (Qprocessp): Declare again.
3246
7990b61a
JB
32472011-04-15 Juanma Barranquero <lekktu@gmail.com>
3248
3249 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3250
5d4cb038
PE
32512011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3252
8bd7b830 3253 Improve C-level modularity by making more things 'static'.
cd64ea1d 3254
e3b27b31
PE
3255 Don't publish debugger-only interfaces to other modules.
3256 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3257 (verify_bytepos, count_markers): Move decls to the only modules
3258 that need them.
3259 * region-cache.h (pp_cache): Likewise.
3260 * window.h (check_all_windows): Likewise.
3261 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3262
5d4cb038
PE
3263 * sysdep.c (croak): Now static, if
3264 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3265 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3266
3267 * alloc.c (refill_memory_reserve): Now static if
3268 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3269 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3270
e87b6180
PE
3271 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3272 Define only if USE_LUCID.
3273
ac64929e
PE
3274 * xrdb.c (x_customization_string, x_rm_string): Now static.
3275
6f37259d
PE
3276 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3277 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3278
1683e3ab
PE
3279 * xdisp.c (draw_row_with_mouse_face): Now static.
3280 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3281
de9c2632
PE
3282 * window.h (check_all_windows): Mark externally visible.
3283
2b96acb7
PE
3284 * window.c (window_deletion_count): Now static.
3285
3286 * undo.c: Make symbols static if they're not exported.
3287 (last_undo_buffer, last_boundary_position, pending_boundary):
3288 Now static.
3289
50436f33
PE
3290 * textprop.c (interval_insert_behind_hooks): Now static.
3291 (interval_insert_in_front_hooks): Likewise.
3292
64520e5c
PE
3293 * term.c: Make symbols static if they're not exported.
3294 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3295 (max_frame_lines, tty_set_terminal_modes):
3296 (tty_reset_terminal_modes, tty_turn_off_highlight):
3297 (get_tty_terminal): Now static.
3298 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3299 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3300 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3301 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3302 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3303
1fa53021
PE
3304 * sysdep.c: Make symbols static if they're not exported.
3305 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3306 Now static.
3307 (sigprocmask_set, full_mask): Remove; unused.
3308 (wait_debugging): Mark as visible.
3309 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3310 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3311
d4b43b22
PE
3312 * syntax.c (syntax_temp): Define only if !__GNUC__.
3313
b7c513d0
PE
3314 * sound.c (current_sound_device, current_sound): Now static.
3315
989b29ad
PE
3316 * search.c (searchbufs, searchbuf_head): Now static.
3317
13a55a78
PE
3318 * scroll.c (scroll_cost): Remove; unused.
3319 * dispextern.h (scroll_cost): Remove decl.
3320
de68a1fc
PE
3321 * region-cache.h (pp_cache): Mark as externally visible.
3322
40ccffa6
PE
3323 * process.c: Make symbols static if they're not exported.
3324 (process_tick, update_tick, create_process, chan_process):
3325 (Vprocess_alist, proc_buffered_char, datagram_access):
3326 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3327 (deactivate_process): Mark defn as static, as well as decl.
3328 * lisp.h (create_process): Remove decl.
3329 * process.h (chan_process, Vprocess_alist): Remove decls.
3330
ad64fc97
PE
3331 * print.c: Make symbols static if they're not exported.
3332 (print_depth, new_backquote_output, being_printed, print_buffer):
3333 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3334 (print_interval, print_number_index, initial_stderr_stream):
3335 Now static.
3336 * lisp.h (Fprinc): Remove decl.
3337 (debug_output_compilation_hack): Mark as externally visible.
3338
adddb265
PE
3339 * sysdep.c (croak): Move decl from here to syssignal.h.
3340 * syssignal.h (croak): Put it here, so the API can be checked when
3341 'croak' is called from dissociate_if_controlling_tty.
3342
1717ede2
PE
3343 * minibuf.c: Make symbols static if they're not exported.
3344 (minibuf_save_list, choose_minibuf_frame): Now static.
3345 * lisp.h (choose_minibuf_frame): Remove decl.
3346
fa5fb2bc
PE
3347 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3348
1e3890d1
PE
3349 * lread.c: Make symbols static if they're not exported.
3350 (read_objects, initial_obarray, oblookup_last_bucket_number):
3351 Now static.
3352 (make_symbol): Remove; unused.
3353 * lisp.h (initial_obarray, make_symbol): Remove decls.
3354
8a1414fa
PE
3355 * keyboard.c: Make symbols static if they're not exported.
3356 (single_kboard, recent_keys_index, total_keys, recent_keys):
3357 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3358 (this_single_command_key_start, echoing, last_auto_save):
3359 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3360 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3361 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3362 (Vlispy_mouse_stem, double_click_count):
3363 Now static.
3364 (force_auto_save_soon): Define only if SIGDANGER.
3365 (ignore_mouse_drag_p): Now static if
3366 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3367 (print_help): Remove; unused.
3368 (stop_character, last_timer_event): Mark as externally visible.
3369 * keyboard.h (ignore_mouse_drag_p): Declare only if
3370 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3371 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3372 * lisp.h (echoing): Remove decl.
3373 (force_auto_save_soon): Declare only if SIGDANGER.
3374 * xdisp.c (redisplay_window): Simplify code, to make it more
3375 obvious that ignore_mouse_drag_p is not accessed if !defined
3376 USE_GTK && !defined HAVE_NS.
3377
93ea6e8f
PE
3378 * intervals.c: Make symbols static if they're not exported.
3379 (merge_properties_sticky, merge_interval_right, delete_interval):
3380 Now static.
3381 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3382
77382fcc
PE
3383 * insdel.c: Make symbols static if they're not exported.
3384 However, leave prepare_to_modify_buffer alone. It's never
3385 called from outside this function, but that appears to be a bug.
3386 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3387 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3388 (adjust_after_replace_noundo): Remove; unused.
3389 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3390 (signal_before_change): Remove decls.
77382fcc 3391
9306c32e
PE
3392 * indent.c (val_compute_motion, val_vmotion): Now static.
3393
cd44d2eb
PE
3394 * image.c: Make symbols static if they're not exported.
3395 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3396 if USE_GTK.
3397 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3398 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3399
ad9a7a06
PE
3400 * fringe.c (standard_bitmaps): Now static.
3401 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3402
81626931
PE
3403 * frame.c: Make symbols static if they're not exported.
3404 (x_report_frame_params, make_terminal_frame): Now static.
3405 (get_frame_param): Now static, unless HAVE_NS.
3406 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3407 (x_get_resource_string): Remove; not used.
3408 * frame.h (make_terminal_frame, x_report_frame_params):
3409 (x_get_resource_string); Remove decls.
3410 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3411 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3412
239f9db9
PE
3413 * font.c, fontset.c: Make symbols static if they're not exported.
3414 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3415 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3416 * font.c (font_close_object): Now static.
3417 * font.h (font_close_object): Remove.
3418 * fontset.c (FONTSET_OBJLIST): Remove.
3419 (free_realized_fontset) #if-0 the body, which does nothing.
3420 (face_suitable_for_char_p): #if-0, as it's never called.
3421 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3422 * xfaces.c (face_at_string_position):
3423 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3424 since 0 is always ASCII.
3425
dfcf3579
PE
3426 * fns.c (weak_hash_tables): Now static.
3427
5045092b
PE
3428 * fileio.c: Make symbols static if they're not exported.
3429 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3430 (Vwrite_region_annotation_buffers): Now static.
3431
57a96f5c
PE
3432 * eval.c: Make symbols static if they're not exported.
3433 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3434 * lisp.h (backtrace_list): Remove decl.
3435
35f08c38
PE
3436 * emacs.c: Make symbols static if they're not exported.
3437 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3438 (fatal_error_code, fatal_error_signal_hook, standard_args):
3439 Now static.
3440 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3441 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3442 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3443 * lisp.h (fatal_error_signal_hook): Remove decl.
3444 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3445
f44bd759
PE
3446 * editfns.c: Move a (normally-unused) function to its only use.
3447 * editfns.c, lisp.h (get_operating_system_release): Remove.
3448 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3449 worth the hassle of breaking this out.
3450
b532497d
PE
3451 * xterm.c: Make symbols static if they're not exported.
3452 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3453 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3454 (x_destroy_window, x_delete_display):
3455 Now static.
3456 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3457 (x_mouse_leave): Remove; unused.
3458 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3459 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3460 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3461 Remove decls.
3462 (x_mouse_leave): Declare only if WINDOWSNT.
3463 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3464 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3465 USE_X_TOOLKIT.
3466
1675728f
PE
3467 * ftxfont.c: Make symbols static if they're not exported.
3468 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3469 HAVE_FREETYPE.
3470 * font.h (ftxfont_driver): Likewise.
3471
e4cebfca
PE
3472 * xfns.c: Make symbols static if they're not exported.
3473 (x_last_font_name, x_display_info_for_name):
3474 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3475 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3476 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3477 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3478 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3479 (last_show_tip_args): Now static.
3480 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3481 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3482 (x_screen_planes): Remove; unused.
3483 * dispextern.h (x_screen_planes): Remove decl.
3484
5bf46f05
PE
3485 * dispnew.c: Make symbols static if they're not exported.
3486 * dispextern.h (redraw_garbaged_frames, scrolling):
3487 (increment_row_positions): Remove.
3488 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3489 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3490 Now static.
3491 (redraw_garbaged_frames): Remove; unused.
3492
435f4c28
PE
3493 * xfaces.c: Make symbols static if they're not exported.
3494 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3495 Remove decls.
3496 * xterm.h (defined_color): Remove decls.
3497 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3498 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3499 (menu_face_changed_default, defined_color, free_realized_face):
3500 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3501 (ascii_face_of_lisp_face): Remove; unused.
3502
8524aef3
PE
3503 * xdisp.c: Make symbols static if they're not exported.
3504 * dispextern.h (scratch_glyph_row, window_box_edges):
3505 (glyph_to_pixel_coords, set_cursor_from_row):
3506 (get_next_display_element, set_iterator_to_next):
3507 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3508 (show_mouse_face): Remove decls
3509 * frame.h (message_buf_print): Likewise.
3510 * lisp.h (pop_message, set_message, check_point_in_composition):
3511 Likewise.
3512 * xterm.h (set_vertical_scroll_bar): Likewise.
3513 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3514 (message_buf_print, scratch_glyph_row, displayed_buffer):
3515 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3516 (get_next_display_element, show_mouse_face, window_box_edges):
3517 (frame_to_window_pixel_xy, check_point_in_composition):
3518 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3519 (glyph_to_pixel_coords): Remove; unused.
3520
16390cd2
PE
3521 * dired.c (file_name_completion): Now static.
3522
3523 * dbusbind.c (xd_in_read_queued_messages): Now static.
3524
a25f4dfa
PE
3525 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3526 * data.c (circular_list_error): Remove.
3527
14a9c8df
PE
3528 * commands.h (last_point_position, last_point_position_buffer):
3529 (last_point_position_window): Remove decls.
3530 * keyboard.c: Make these variables static.
3531
04f2d78b
CB
3532 * coding.h (coding, code_convert_region, encode_coding_gap):
3533 Remove decls.
74ab6df5
PE
3534 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3535 (iso_code_class, detect_coding, code_convert_region): Now static.
3536 (encode_coding_gap): Remove; unused.
3537
38dfbee1
PE
3538 * chartab.c (chartab_chars, chartab_bits): Now static.
3539
a2cb4e63
PE
3540 * charset.h (charset_iso_8859_1): Remove decl.
3541 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3542 Now static.
3543
127198fd
PE
3544 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3545 * ccl.c (Vccl_program_table): Now static.
3546 (check_ccl_update): Remove; unused.
3547
d85b608f
PE
3548 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3549 * category.h: ... from here.
3550 * category.c (check_category_table, set_category_set): Now static.
3551
31cd66f3
PE
3552 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3553 * lisp.h: Remove these decls.
3554
c358e587
PE
3555 * buffer.c (buffer_count): Remove unused var.
3556
e78aecca
PE
3557 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3558 so that it's not optimized away.
3559 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3560 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3561 exported only to the debugger.
3562
e192d7d3 3563 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3564 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3565
92470028
PE
3566 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3567 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3568 was inaccessible from Lisp.
3569 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3570 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3571
244ed907
PE
3572 alloc.c: Import and export fewer symbols, and remove unused items.
3573 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3574 is defined.
3575 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3576 it's not optimized away by whole-program optimization.
3577 (message_enable_multibyte, free_misc): Remove.
3578 (catchlist, handlerlist, mark_backtrace):
3579 Declare only if BYTE_MARK_STACK.
3580 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3581 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3582 (message_enable_multibyte): Remove decl.
3583 (free_misc, interval_free_list, float_block, float_block_index):
3584 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3585 (cons_free_list, last_marked_index):
3586 Now static.
3587 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3588 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3589 (mark_backtrace): Define only if BYTE_MARK_STACK.
3590 * xdisp.c (message_enable_multibyte): Now static.
3591
61c2b50e 3592 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3593 This makes it easier for human readers (and static analyzers)
3594 to see whether these variables are used from other modules.
3595 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3596 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3597 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3598 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3599 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3600 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3601 * xmenu.c, xselect.c:
3602 Declare Q* vars static if they are not used in other modules.
3603 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3604 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3605 Remove decls of unexported vars.
3606 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3607
95c82688
PE
3608 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3609
16a97296
PE
3610 Make Emacs functions such as Fatom 'static' by default.
3611 This makes it easier for human readers (and static analyzers)
3612 to see whether these functions can be called from other modules.
3613 DEFUN now defines a static function. To make the function external
3614 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3615 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3616 (Finit_image_library):
16a97296
PE
3617 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3618 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3619 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3620 Remove decls, since these functions are now static.
3621 (Funintern, Fget_internal_run_time): New decls, since these functions
3622 were already external.
95c82688 3623
16a97296
PE
3624 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3625 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3626 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3627 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3628 * keyboard.c, keymap.c, lread.c:
3629 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3630 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3631 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3632 Mark functions with DEFUE instead of DEFUN,
3633 if they are used in other modules.
3634 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3635 decls for now-static functions.
3636 * buffer.h (Fdelete_overlay): Remove decl.
3637 * callproc.c (Fgetenv_internal): Mark as internal.
3638 * composite.c (Fremove_list_of_text_properties): Remove decl.
3639 (Fcomposition_get_gstring): New forward static decl.
3640 * composite.h (Fcomposite_get_gstring): Remove decl.
3641 * dired.c (Ffile_attributes): New forward static decl.
3642 * doc.c (Fdocumntation_property): New forward static decl.
3643 * eval.c (Ffetch_bytecode): New forward static decl.
3644 (Funintern): Remove extern decl; now in .h file where it belongs.
3645 * fileio.c (Fmake_symbolic_link): New forward static decl.
3646 * image.c (Finit_image_library): New forward static decl.
3647 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3648 * intervals.h (Fprevious_property_change):
3649 (Fremove_list_of_text_properties): Remove decls.
3650 * keyboard.c (Fthis_command_keys): Remove decl.
3651 (Fcommand_execute): New forward static decl.
3652 * keymap.c (Flookup_key): New forward static decl.
3653 (Fcopy_keymap): Now static.
3654 * keymap.h (Flookup_key): Remove decl.
3655 * process.c (Fget_process): New forward static decl.
3656 (Fprocess_datagram_address): Mark as internal.
3657 * syntax.c (Fsyntax_table_p): New forward static decl.
3658 (skip_chars): Remove duplicate decl.
3659 * textprop.c (Fprevious_property_change): New forward static decl.
3660 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3661 Now internal.
3662 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3663 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3664
785bbd42
PE
3665 * editfns.c (Fformat): Remove unreachable code.
3666
8b913b57
AS
36672011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3668
3669 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3670 change. (Bug#8496)
3671
a6744a35
EZ
36722011-04-13 Eli Zaretskii <eliz@gnu.org>
3673
3674 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3675 when at ZV. (Bug#8487)
3676
e7974947
AS
36772011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3678
baad03f0
AS
3679 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3680 (Bug#8437)
3681 * keyboard.c (parse_tool_bar_item): Likewise.
3682 * sound.c (sound_cleanup, alsa_close): Likewise.
3683 * termcap.c (tgetent): Likewise.
3684 * xfns.c (x_default_font_parameter): Likewise.
3685 * xsettings.c (read_and_apply_settings): Likewise.
3686
e7974947
AS
3687 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3688 (overrun_check_free): Protoize.
3689
28272684
PE
36902011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3691
3692 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3693 since callers should never pass a negative size.
3694 Change the signature to match that of plain 'read' and 'write'; see
3695 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3696 * lisp.h: Update prototypes of emacs_write and emacs_read.
3697
11997c76
EZ
36982011-04-11 Eli Zaretskii <eliz@gnu.org>
3699
3700 * xdisp.c (redisplay_window): Don't try to determine the character
3701 position of the scroll margin if the window start point w->startp
e896f03c 3702 is outside the buffer's accessible region. (Bug#8468)
11997c76 3703
8a2cbd72
EZ
37042011-04-10 Eli Zaretskii <eliz@gnu.org>
3705
3706 Fix write-region and its subroutines for buffers > 2GB.
3707 * fileio.c (a_write, e_write): Modify declaration of arguments and
3708 local variables to support buffers larger than 2GB.
3709 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3710
3711 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3712 argument, local variables, and return value.
3713
3714 * lisp.h: Update prototypes of emacs_write and emacs_read.
3715
3716 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3717
4073e537 37182011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3719
1ebfdcb6
PE
3720 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3721
b2ded58d
PE
3722 Fix more problems found by GCC 4.6.0's static checks.
3723
7d66342c
PE
3724 * xdisp.c (vmessage): Use a better test for character truncation.
3725
bbf47d44
PE
3726 * charset.c (load_charset_map): <, not <=, for optimization,
3727 and to avoid potential problems with integer overflow.
9248994d 3728 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3729 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3730 * editfns.c (Fformat): Likewise.
1e69125e 3731 * syntax.c (skip_chars): Likewise.
3befa583 3732
e3019616
PE
3733 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3734 This also lets GCC 4.6.0 generate slightly better loop code.
3735
becfa255
PE
3736 * callint.c (Fcall_interactively): <, not <=, for optimization.
3737 (Fcall_interactively): Count the number of arguments produced,
3738 not the number of arguments given. This is simpler and lets GCC
3739 4.6.0 generate slightly better code.
3740
dae0cd48
PE
3741 * ftfont.c: Distingish more carefully between FcChar8 and char.
3742 The previous code passed unsigned char * to a functions like
3743 strlen and xstrcasecmp that expect char *, which does not
3744 conform to the C standard.
3745 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3746 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3747 char * when the C standard requires it.
3748
76032d70
PE
3749 * keyboard.c (read_char): Remove unused var.
3750
eb3f1cc8
PE
3751 * eval.c: Port to Windows vsnprintf (Bug#8435).
3752 Include <limits.h>.
3753 (SIZE_MAX): Define if the headers do not.
3754 (verror): Do not give up if vsnprintf returns a negative count.
3755 Instead, grow the buffer. This ports to Windows vsnprintf, which
3756 does not conform to C99. Problem reported by Eli Zaretskii.
3757 Also, simplify the allocation scheme, by avoiding the need for
3758 calling realloc, and removing the ALLOCATED variable.
3759
70476b54
PE
3760 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3761
12020a9e
PE
3762 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3763 But keep the doprint source code for now, as we might revamp it
3764 and use it again (Bug#8435).
ea6c7ae6
PE
3765 * lisp.h (doprnt): Remove.
3766 * Makefile.in (base_obj): Remove doprnt.o.
3767 * deps.mk (doprnt.o): Remove.
3768
5fdb398c
PE
3769 error: Print 32- and 64-bit integers portably (Bug#8435).
3770 Without this change, on typical 64-bit hosts error ("...%d...", N)
3771 was used to print both 32- and 64-bit integers N, which relied on
3772 undefined behavior.
3773 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3774 New macro.
3775 * lisp.h (error, verror): Mark as printf-like functions.
3776 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3777 Report overflow in size calculations when allocating printf buffer.
3778 Do not truncate output string at its first null byte.
3779 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3780 Truncate the output at a character boundary, since vsnprintf does not
3781 do that.
3782 * charset.c (check_iso_charset_parameter): Convert internal
3783 character to string before calling 'error', since %c now has the
3784 printf meaning.
3785 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3786 overflow when computing char to be passed to 'error'. Do not
3787 pass Lisp_Object to 'error'; pass the integer instead.
3788 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3789 formatted with plain %d.
3790
b189fa66
PE
3791 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3792
bff87ef0
PE
3793 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3794
7e2cac20
PE
3795 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3796
ce4d90b5
PE
3797 * xterm.c (x_catch_errors): Remove duplicate declaration.
3798
266c9547
PE
3799 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3800
79c49ad2
PE
3801 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3802
368f4090
JM
38032011-04-10 Jim Meyering <meyering@redhat.com>
3804
3805 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3806 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3807 return ssize_t not "int", and use size_t as the buffer length.
3808 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3809 * gnutls.h: Update declarations.
3810 * process.c (read_process_output): Use ssize_t, to match.
3811 (send_process): Likewise.
3812
a32d4040
CY
38132011-04-09 Chong Yidong <cyd@stupidchicken.com>
3814
3815 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3816
8546720e 38172011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3818
04f2d78b
CB
3819 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3820 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3821
8546720e
GM
3822 * xterm.c (handle_one_xevent):
3823 * xmenu.c (create_and_show_popup_menu):
3824 * xselect.c (x_decline_selection_request)
3825 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3826
0a2f5c1a 38272011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3828
3829 Fix some uses of `int' instead of EMACS_INT.
3830 * search.c (string_match_1, fast_string_match)
3831 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3832 (scan_buffer, find_next_newline_no_quit)
3833 (find_before_next_newline, search_command, Freplace_match)
3834 (Fmatch_data): Make some `int' variables be EMACS_INT.
3835
3836 * xdisp.c (display_count_lines): 3rd argument and return value now
3837 EMACS_INT. All callers changed.
3838 (pint2hrstr): Last argument is now EMACS_INT.
3839
3840 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3841 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3842 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3843 (decode_coding_utf_16, decode_coding_emacs_mule)
3844 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3845 (decode_coding_ccl, decode_coding_charset)
3846 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3847 (decode_coding_iso_2022, decode_coding_emacs_mule)
3848 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3849 <char_offset, last_offset>: Declare EMACS_INT.
3850 (encode_coding_utf_8, encode_coding_utf_16)
3851 (encode_coding_emacs_mule, encode_invocation_designation)
3852 (encode_designation_at_bol, encode_coding_iso_2022)
3853 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3854 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3855 Declare EMACS_INT.
3856 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3857 (encode_invocation_designation): Last argument P_NCHARS is now
3858 EMACS_INT.
3859 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3860 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3861
3862 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3863 All users changed.
3864
3865 * ccl.c (Fccl_execute_on_string): Declare some variables
3866 EMACS_INT.
3867
8546720e 38682011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3869
3870 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3871
4e19a977
CS
38722011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3873
3874 * process.c (Fformat_network_address): Doc fix.
3875
87302331
R
38762011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3877
3878 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3879
cbb59342
CY
38802011-04-08 Chong Yidong <cyd@stupidchicken.com>
3881
3882 * keyboard.c (read_char): Call Lisp function help-form-show,
3883 instead of using internal_with_output_to_temp_buffer.
3884 (Qhelp_form_show): New var.
e0d38eeb 3885 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3886
3887 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3888
3889 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3890
e67a13ab
CY
38912011-04-06 Chong Yidong <cyd@stupidchicken.com>
3892
04f2d78b
CB
3893 * process.c (Flist_processes): Remove to Lisp.
3894 (list_processes_1): Delete.
e67a13ab 3895
973f782d
EZ
38962011-04-06 Eli Zaretskii <eliz@gnu.org>
3897
7c106b1e
EZ
3898 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3899
973f782d
EZ
3900 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3901
41cf7d1a 39022011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3903
ca23cc88
PE
3904 Fix more problems found by GCC 4.6.0's static checks.
3905
f390e2d5
PE
3906 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3907
42eea0d0
PE
3908 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3909
b69769da 3910 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3911
f9541e84
PE
3912 * xdisp.c (vmessage): Mark as a printf-like function.
3913
13841b55
PE
3914 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3915
c136c10f
PE
3916 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3917
5e2d4a30
PE
3918 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3919 printf-like functions.
3920 (tiff_load): Add casts to remove these marks before passing them
3921 to system-supplied API.
3922
583f48b9
PE
3923 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3924
b25d760e
PE
3925 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3926 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3927 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3928 directly, rather than having caller test rule sign. This avoids
3929 some unnecessary tests.
3930 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3931 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3932 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3933
bc7b6697 3934 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3935 (xfont_open): Avoid unnecessary tests.
bc7b6697 3936
27ccc379
PE
3937 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3938
dcd5c89a
PE
3939 * composite.h, composite.c (composition_gstring_put_cache):
3940 Use EMACS_INT, not int, for length.
3941
b13a45c6
PE
3942 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3943 breaking out part of COMPOSITION_DECODE_RULE.
3944 (COMPOSITION_DECODE_RULE): Use it.
3945 * composite.c (get_composition_id): Remove unused local vars,
3946 by using the new macro.
3947
1e792e4d
PE
3948 * textprop.c (set_text_properties_1): Change while to do-while,
3949 since the condition is always true at first.
3950
dc6c6455 3951 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3952 (interval_deletion_adjustment): Return unsigned value.
3953 All uses changed.
dc6c6455 3954
aba7731a
PE
3955 * process.c (list_processes_1, create_pty, read_process_output):
3956 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3957 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3958 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3959 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3960 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3961
fdfc4bf3
PE
3962 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3963
fca8fe46 3964 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3965 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3966
06a0259a 3967 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3968 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3969 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3970
e7b9e80f
PE
3971 * print.c (print_error_message): Avoid int overflow.
3972
56201685
PE
3973 * font.c (font_list_entities): Redo for clarity,
3974 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3975
78834453 3976 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3977 (font_score): Avoid potential overflow in diff calculation.
78834453 3978
0bc0b309 3979 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3980 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3981
e610eaca
PE
3982 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3983
b895abce
PE
3984 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3985 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3986 can always succeed if overflow has undefined behavior.
3987
1f1d9321 3988 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3989 (wordify): Omit three unnecessary tests.
1f1d9321 3990
c59478bc
PE
3991 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3992 All callers changed. This avoids the need for an unused var.
3993
79b73827
PE
3994 * casefiddle.c (casify_region): Remove var that is set but not used.
3995
a4db5dfe
PE
3996 * dired.c (file_name_completion): Remove var that is set but not used.
3997
43aae36e
PE
3998 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3999
2a47c44d 4000 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4001 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4002
a37c69bf
PE
4003 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4004 Check for integer overflow on size calculations.
4005
328ab8e7
PE
4006 * buffer.c (Fprevious_overlay_change): Remove var that is set
4007 but not used.
4008
e5a2a5cb
PE
4009 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4010 Remove vars that are set but not used.
8d84a6eb 4011 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4012 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4013
a60e5f68
PE
4014 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4015
f661cb61 4016 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4017 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4018
f0397f5a
PE
4019 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4020 that are set but not used.
4021
8664db06 4022 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4023 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4024
6abdaa4a
PE
4025 * xselect.c (x_get_local_selection, x_handle_property_notify):
4026 Remove vars that are set but not used.
4027
0ce7538d 4028 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4029 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4030
9ae848fc
PE
4031 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4032 Remove var that is set but not used.
0b918413
PE
4033 (scroll_bar_windows_size): Now size_t, not int.
4034 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4035 Check for overflow.
9ae848fc 4036
a5a62657
PE
4037 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4038 (map_tty_color) [!defined MSDOS]: Likewise.
4039
5c5cdd39
PE
4040 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4041
66ebf983
PE
4042 * coding.c: Remove vars that are set but not used.
4043 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4044 All callers changed.
4045 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4046 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4047 (decode_coding_charset): Remove vars that are set but not used.
4048
1be4d761
PE
4049 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4050 that is set but not used.
4051
47553fa8
PE
4052 * print.c (print_object): Remove var that is set but not used.
4053
1f7196bf 4054 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4055 The gnulib version avoids calling malloc in the usual case,
4056 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4057 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4058 * filelock.c (current_lock_owner): Likewise.
4059 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4060 * sysdep.c: Include allocator.h, careadlinkat.h.
4061 (emacs_no_realloc_allocator): New static constant.
4062 (emacs_readlink): New function.
fdb61804
PE
4063 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4064 ../lib/careadlinkat.h.
d1fdcab7 4065
f84c17c7
SM
40662011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4067
4068 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4069 first non-nil return value).
4070
ef3862ad
JD
40712011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4072
4073 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4074 if not defined (Bug#8403).
4075
376a7006
JB
40762011-04-02 Juanma Barranquero <lekktu@gmail.com>
4077
4078 * xdisp.c (display_count_lines): Remove parameter `start',
4079 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4080 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4081 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4082 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4083 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4084 and thereabouts. All callers changed.
4085 (get_per_char_metric): Remove parameter `f', unused since
4086 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4087
6ca3801d
JM
40882011-04-02 Jim Meyering <meyering@redhat.com>
4089
4090 do not dereference NULL upon failed strdup
4091 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4092 (ns_get_family): Likewise.
4093
d8e2b5ba
JB
40942011-04-02 Juanma Barranquero <lekktu@gmail.com>
4095
4096 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4097
8c74fcbd
JD
40982011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4099
4100 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4101 later (Bug#8403).
4102
7200d79c
SM
41032011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4104
03408648 4105 Add lexical binding.
7200d79c 4106
03408648
SM
4107 * window.c (Ftemp_output_buffer_show): New fun.
4108 (Fsave_window_excursion):
4109 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4110
4111 * lread.c (lisp_file_lexically_bound_p): New function.
4112 (Fload): Bind Qlexical_binding.
4113 (readevalloop): Remove `evalfun' arg.
4114 Bind Qinternal_interpreter_environment.
4115 (Feval_buffer): Bind Qlexical_binding.
4116 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4117 Mark as dynamic.
4118 (syms_of_lread): Declare `lexical-binding'.
4119
4120 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4121
4122 * keyboard.c (eval_dyn): New fun.
4123 (menu_item_eval_property): Use it.
ca105506
SM
4124
4125 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4126
03408648
SM
4127 * fns.c (concat, mapcar1): Accept byte-code-functions.
4128
4129 * eval.c (Fsetq): Handle lexical vars.
4130 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4131 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4132 (FletX, Flet): Obey lexical binding.
4133 (Fcommandp): Handle closures.
4134 (Feval): New `lexical' arg.
4135 (eval_sub): New function extracted from Feval. Use it almost
4136 everywhere where Feval was used. Look up vars in lexical env.
4137 Handle closures.
4138 (Ffunctionp): Move from subr.el.
4139 (Ffuncall): Handle closures.
4140 (apply_lambda): Remove `eval_flags'.
4141 (funcall_lambda): Handle closures and new byte-code-functions.
4142 (Fspecial_variable_p): New function.
4143 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4144 but without exporting it to Lisp.
23aba0ea 4145
23aba0ea 4146 * doc.c (Fdocumentation, store_function_docstring):
03408648 4147 * data.c (Finteractive_form): Handle closures.
23aba0ea 4148
03408648
SM
4149 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4150 interactive spec.
ba83908c 4151
04f2d78b
CB
4152 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4153 New byte-codes.
03408648
SM
4154 (exec_byte_code): New function extracted from Fbyte_code to handle new
4155 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4156
03408648 4157 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4158
03408648 4159 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4160
e2abce01
JB
41612011-03-31 Juanma Barranquero <lekktu@gmail.com>
4162
4163 * xdisp.c (redisplay_internal): Fix prototype.
4164
63696a73 41652011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4166
63696a73 4167 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4168 (try_scrolling): Use it when setting scroll_limit.
4169 Limit scrolling to 100 screen lines.
63696a73
EZ
4170 (redisplay_window): Even when falling back on "recentering",
4171 position point in the window according to scroll-conservatively,
4172 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4173
4174 (try_scrolling): When point is above the window, allow searching
4175 as far as scroll_max, or one screenful, to compute vertical
4176 distance from PT to the scroll margin position. This prevents
4177 try_scrolling from unnecessarily failing when
4178 scroll-conservatively is set to a value slightly larger than the
4179 window height. Clean up the case of PT below the margin at bottom
4180 of window: scroll_max can no longer be INT_MAX. When aggressive
4181 scrolling is in use, don't let point enter the opposite scroll
4182 margin as result of the scroll.
4183 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4184 threshold of 100 lines for never-recentering scrolling.
4185
e4cc2dfc
JB
41862011-03-31 Juanma Barranquero <lekktu@gmail.com>
4187
4188 * dispextern.h (move_it_by_lines):
4189 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4190 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4191 (message_log_check_duplicate): Remove parameters `prev_bol' and
4192 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4193 (redisplay_internal): Remove parameter `preserve_echo_area',
4194 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4195
4196 * indent.c (Fvertical_motion):
4197 * window.c (window_scroll_pixel_based, Frecenter):
4198 Don't pass `need_y_p' to `move_it_by_lines'.
4199
1c470562
SM
42002011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4201
44f230aa
SM
4202 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4203 steal a few bits to be more compact.
4204 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4205 Remove unneeded casts.
4206
1c470562
SM
4207 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4208
888adce9
ZK
42092011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4210
4211 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4212 binding" message (bug#7967).
4213
f838ed7b
PE
42142011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4215
77861b95
PE
4216 Fix more problems found by GCC 4.6.0's static checks.
4217
de6dbc14
PE
4218 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4219 Remove unused local var.
4220
f838ed7b
PE
4221 * editfns.c (Fmessage_box): Remove unused local var.
4222
792c7b2b
PE
4223 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4224 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4225 Omit unused local vars.
c499e557 4226 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4227 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4228 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4229 Omit unused local var.
4230
ba0165e1
PE
4231 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4232 Don't assume string length fits in int.
32ad8845 4233 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4234 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4235
3c59b4c9
PE
4236 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4237 instead of alloca (Bug#8344).
4238
a3eed478 4239 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4240 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4241
eb4d412d
PE
4242 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4243
1658b401
PE
4244 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4245 concerns.
4246
4247 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4248
4249 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4250
9a2c6e05
PE
4251 * keyboard.c (syms_of_keyboard): Use the same style as later
4252 in this function when indexing through an array. This also
4253 works around GCC bug 48267.
4254
03d0a109
PE
4255 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4256
44f730c8
PE
4257 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4258
fe75f926
PE
4259 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4260 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4261
ffa8c828
PE
4262 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4263 This avoids undefined behavior on integer overflow, and is a bit
4264 more convenient anyway since it is compared to a size_t variable.
4265
c5101a77
PE
4266 Variadic C functions now count arguments with size_t, not int.
4267 This avoids an unnecessary limitation on 64-bit machines, which
4268 caused (substring ...) to crash on large vectors (Bug#8344).
4269 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4270 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4271 All variadic functions and their callers changed accordingly.
c5101a77
PE
4272 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4273 * data.c (arith_driver, float_arith_driver): Likewise.
4274 * editfns.c (general_insert_function): Likewise.
4275 * eval.c (struct backtrace.nargs, interactive_p)
4276 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4277 (funcall_lambda, mark_backtrace): Likewise.
4278 * fns.c (concat): Likewise.
4279 * frame.c (x_set_frame_parameters): Likewise.
4280 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4281 0 if not found, not -1. All callers changed.
4282
dd3f25f7
PE
4283 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4284 (stack_copy_size): Now size_t, not int.
4285 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4286
461c2ab9
JB
42872011-03-28 Juanma Barranquero <lekktu@gmail.com>
4288
4289 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4290 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4291 All callers changed.
4292
4293 * lisp.h (multibyte_char_to_unibyte):
4294 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4295 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4296 * character.h (CHAR_TO_BYTE8):
4297 * cmds.c (internal_self_insert):
4298 * editfns.c (general_insert_function):
4299 * keymap.c (push_key_description):
4300 * search.c (Freplace_match):
4301 * xdisp.c (message_dolog, set_message_1): All callers changed.
4302
f6d62986
SM
43032011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4304
4305 * keyboard.c (safe_run_hook_funcall): New function.
4306 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4307 don't set the hook to nil, but remove the offending function instead.
4308 (Qcommand_hook_internal): Remove, unused.
4309 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4310 Vcommand_hook_internal.
4311
4312 * eval.c (enum run_hooks_condition): Remove.
4313 (funcall_nil, funcall_not): New functions.
4314 (run_hook_with_args): Call each function through a `funcall' argument.
4315 Remove `cond' argument, now redundant.
4316 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4317 (Frun_hook_with_args_until_failure): Adjust accordingly.
4318 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4319
1db5b1ad
JB
43202011-03-28 Juanma Barranquero <lekktu@gmail.com>
4321
4322 * dispextern.h (string_buffer_position): Remove declaration.
4323
4324 * print.c (strout): Remove parameter `multibyte', unused since
4325 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4326
4327 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4328 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4329 All callers changed.
4330
4331 * w32.c (_wsa_errlist): Use braces for struct initializers.
4332
4333 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4334 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4335 All callers changed.
4336 (string_buffer_position): Likewise. Also, make static (it's never
4337 used outside xdisp.c).
4338 (cursor_row_p): Remove parameter `w', unused since
4339 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4340 (decode_mode_spec): Remove parameter `precision', introduced during
4341 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4342 All callers changed.
4343
5ffb62aa
JD
43442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4345
4346 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4347
461c2ab9 43482011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4349
4350 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4351 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4352 (ns_update_auto_hide_menu_bar): New functions.
4353 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4354 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4355 ns_constrain_all_frames.
4356 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4357 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4358
5c380ffb
JD
43592011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4360
4361 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4362
9af30bdf
GM
43632011-03-27 Glenn Morris <rgm@gnu.org>
4364
4365 * syssignal.h: Replace RETSIGTYPE with void.
4366 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4367 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4368 Replace SIGTYPE with void everywhere.
4369 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4370 * s/template.h (SIGTYPE): Remove commented out definition.
4371
e2abce01
JB
43722011-03-26 Eli Zaretskii <eliz@gnu.org>
4373
4374 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4375 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4376
f868cd8a
JB
43772011-03-26 Juanma Barranquero <lekktu@gmail.com>
4378
59eb0929
JB
4379 * w32.c (read_unc_volume): Use parameter `henum', instead of
4380 global variable `wget_enum_handle'.
4381
4382 * keymap.c (describe_vector): Remove parameters `indices' and
4383 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4384 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4385
f868cd8a
JB
4386 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4387
4388 * keyboard.c (timer_check): Remove parameter `do_it_now',
4389 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4390 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4391 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4392
4393 * keyboard.c (read_char):
4394 * w32menu.c (w32_menu_display_help):
4395 * xmenu.c (show_help_event, menu_help_callback):
4396 Adjust calls to `show_help_echo'.
4397
4398 * gtkutil.c (xg_maybe_add_timer):
4399 * keyboard.c (readable_events):
4400 * process.c (wait_reading_process_output):
4401 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4402
4403 * insdel.c (adjust_markers_gap_motion):
4404 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4405 (gap_left, gap_right): Don't call it.
4406
2ecf6fdb
CY
44072011-03-25 Chong Yidong <cyd@stupidchicken.com>
4408
4409 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4410 incurred during fontification.
4411
6b1f9ba4
JB
44122011-03-25 Juanma Barranquero <lekktu@gmail.com>
4413
4414 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4415 (DEFVAR_PER_BUFFER): Don't pass it.
4416
4417 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4418 (scrolling_window): Don't pass it.
4419
0f4a96b5
JB
44202011-03-25 Juanma Barranquero <lekktu@gmail.com>
4421
4422 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4423
4424 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4425 and `suffix'.
4426 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4427 of variables specific to SELinux and computation of `encoded_absname'.
4428
4429 * image.c (XPutPixel): Remove unused variable `height'.
4430
4431 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4432
4433 * unexw32.c (get_section_info): Remove unused variable `section'.
4434
4435 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4436 (system_process_attributes): Remove unused variable `sess'.
4437 (sys_read): Remove unused variable `err'.
4438
4439 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4440 (w32_wnd_proc): Remove unused variable `isdead'.
4441 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4442 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4443 (x_create_tip_frame): Remove unused variable `tem'.
4444
4445 * w32inevt.c (w32_console_read_socket):
4446 Remove unused variable `no_events'.
4447
4448 * w32term.c (x_draw_composite_glyph_string_foreground):
4449 Remove unused variable `width'.
4450
1149507c
JB
44512011-03-24 Juanma Barranquero <lekktu@gmail.com>
4452
4453 * w32term.c (x_set_glyph_string_clipping):
4454 Don't pass uninitialized region to CombineRgn.
4455
9c88f339
JB
44562011-03-23 Juanma Barranquero <lekktu@gmail.com>
4457
4458 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4459 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4460 (Fx_close_connection): Remove unused variable `i'.
4461
4462 * w32font.c (w32font_draw): Return number of glyphs.
4463 (w32font_open_internal): Remove unused variable `i'.
4464 (w32font_driver): Add missing initializer.
4465
4466 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4467 (fill_in_menu): Remove unused variable `items_added'.
4468
4469 * w32term.c (last_mouse_press_frame): Remove static global variable.
4470 (w32_clip_to_row): Remove unused variable `f'.
4471 (x_delete_terminal): Remove unused variable `i'.
4472
4473 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4474 (NOTHING): Remove unused static global variable.
4475 (uniscribe_check_otf): Remove unused variable `table'.
4476 (uniscribe_font_driver): Add missing initializers.
4477
dee091a3
JD
44782011-03-23 Julien Danjou <julien@danjou.info>
4479
4480 * term.c (Fsuspend_tty, Fresume_tty):
4481 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4482 * window.c (temp_output_buffer_show):
4483 * insdel.c (signal_before_change):
4484 * frame.c (Fhandle_switch_frame):
4485 * fileio.c (Fdo_auto_save):
4486 * emacs.c (Fkill_emacs):
4487 * editfns.c (save_excursion_restore):
4488 * cmds.c (internal_self_insert):
4489 * callint.c (Fcall_interactively):
4490 * buffer.c (Fkill_all_local_variables):
4491 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4492 Use Frun_hooks.
0f4a96b5 4493 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4494 unconditionnaly since it does the check itself.
4495
2c520ab5 44962011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4497
c9c49752
PE
4498 Fix more problems found by GCC 4.5.2's static checks.
4499
8abc3f12
PE
4500 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4501 the first time through the loop, since we know p0 < p1 then.
4502 This also avoids a gcc -Wstrict-overflow warning.
4503
a2d26660
PE
4504 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4505 leading to a memory leak, possible in functions like
4506 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4507 of objects (Bug#8318).
a2d26660 4508
916c72e9
PE
4509 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4510 that could (at least in theory) be that large.
4511
19ab8a18
PE
4512 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4513 This is less likely to overflow, and avoids undefined behavior if
4514 overflow does occur. All callers changed. Use strtoul to scan
4515 for the unsigned long integer.
b7cbbd6f
PE
4516 (pint2hrstr): Simplify and tune code slightly.
4517 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4518
f0641eff
PE
4519 * scroll.c (do_scrolling): Work around GCC bug 48228.
4520 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4521
7f650bb9
PE
4522 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4523 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4524 (validate_x_resource_name): Simplify count usage.
4525 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4526
37dd57d1
PE
4527 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4528 fail (Bug#8306).
81e56e61 4529
699979fc 4530 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4531
401bf9b4
PE
4532 * process.c (Fmake_network_process): Use socklen_t, not int,
4533 where POSIX says socklen_t is required in portable programs.
4534 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4535 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4536 (Fmake_network_process, server_accept_connection):
4537 (wait_reading_process_output, read_process_output):
4538 Likewise.
4539
b93aacde
PE
4540 * process.c: Rename or move locals to avoid shadowing.
4541 (list_processes_1, Fmake_network_process):
4542 (read_process_output_error_handler, exec_sentinel_error_handler):
4543 Rename or move locals.
4dc343ee 4544 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4545 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4546 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4547 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4548 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4549
af8a867c 4550 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4551 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4552 Include tparam.h instead, since it declares them.
af8a867c
PE
4553 * cm.h (PC): Remove extern decl; tparam.h now does this.
4554 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4555 * terminfo.c: Include tparam.h, to check interfaces.
4556 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4557 (tparam): Adjust signature to match interface in tparam.h;
4558 this removes some undefined behavior. Check that outstring and len
4559 are zero, which they always are with Emacs.
4560 * tparam.h (PC, BC, UP): New extern decls.
4561
0248044d 4562 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4563 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4564
8ff096c1 4565 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4566 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4567 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4568 (ftfont_list): Remove unused local.
49eaafba
PE
4569 (get_adstyle_property, ftfont_pattern_entity):
4570 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4571 Rename locals to avoid shadowing.
8ff096c1 4572
e2be39f6
PE
4573 * xfont.c (xfont_list_family): Mark var as initialized.
4574
c9735e30
PE
4575 * xml.c (make_dom): Now static.
4576
8f5201ae
PE
4577 * composite.c (composition_compute_stop_pos): Rename local to
4578 avoid shadowing.
b246f932
PE
4579 (composition_reseat_it): Remove unused locals.
4580 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4581 (composition_update_it): Mark var as initialized.
11b61122
PE
4582 (find_automatic_composition): Mark vars as initialized,
4583 with a FIXME (Bug#8290).
8f5201ae 4584
760fbc2c
PE
4585 character.h: Rename locals to avoid shadowing.
4586 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4587 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4588 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4589 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4590 to avoid shadowing.
4591
ff08eb85
PE
4592 * textprop.c (property_change_between_p): Remove; unused.
4593
fc7bf025
PE
4594 * intervals.c (interval_start_pos): Now static.
4595
235d7abc
PE
4596 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4597
44f230aa
SM
4598 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4599 Rename locals to avoid shadowing.
3e7d6594 4600
50060332
PE
4601 * sound.c (wav_play, au_play, Fplay_sound_internal):
4602 Fix pointer signedness.
d01f234b 4603 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4604 (wav_play): Initialize a variable to 0, to prevent undefined
4605 behavior (Bug#8278).
50060332 4606
c4fc4e30
PE
4607 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4608
918436ed
PE
4609 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4610
c939f91b
PE
4611 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4612 clobbering (Bug#8298).
b9c7f648
PE
4613 * sysdep.c (sys_subshell): Likewise.
4614 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4615
6bd8c144
PE
4616 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4617 This should get cleaned up, so that child_setup has the
4618 same signature on all platforms.
4619
7710357c 4620 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4621 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4622
c59da222
CY
46232011-03-22 Chong Yidong <cyd@stupidchicken.com>
4624
4625 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4626 not to be necessary, and produces flickering.
4627
66b87493
GM
46282011-03-20 Glenn Morris <rgm@gnu.org>
4629
4630 * config.in: Remove file.
4631
45b6f6d5
JB
46322011-03-20 Juanma Barranquero <lekktu@gmail.com>
4633
4634 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4635 are now in src/globals.h.
4636 (syms_of_minibuf): Remove spurious & from previous change.
4637
3ec03f7e
LL
46382011-03-20 Leo <sdl.web@gmail.com>
4639
4640 * minibuf.c (completing-read-function): New variable.
4641 (completing-read-default): Rename from completing-read.
4642 (completing-read): Call completing-read-function.
4643
b14e3e21
CY
46442011-03-19 Juanma Barranquero <lekktu@gmail.com>
4645
4646 * xfaces.c (Fx_load_color_file):
4647 Read color file from absolute filename (bug#8250).
4648
f2b726e6
JB
46492011-03-19 Juanma Barranquero <lekktu@gmail.com>
4650
4651 * makefile.w32-in: Update dependencies.
4652
09f6ff02
EZ
46532011-03-17 Eli Zaretskii <eliz@gnu.org>
4654
4655 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4656
29a6015a
PE
46572011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4658
a3a6c54e
PE
4659 Fix more problems found by GCC 4.5.2's static checks.
4660
b766f867
PE
4661 * process.c (make_serial_process_unwind, send_process_trap):
4662 (sigchld_handler): Now static.
4663
be02381c
PE
4664 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4665 That way, the code declares only the vars that it needs.
4666 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4667 * s/cygwin.h (PTY_ITERATION): Likewise.
4668 * s/darwin.h (PTY_ITERATION): Likewise.
4669 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4670
57048744
PE
4671 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4672 * process.c (allocate_pty): Don't declare stb unless it's needed.
4673
7914961c 4674 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4675 (CONSTANTLIM): Remove; unused.
4676 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4677 Define only if needed.
7914961c 4678
b3967b18
PE
4679 * unexelf.c (unexec): Name an expression,
4680 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4681 Use a different way to cause a compilation error if anyone uses
4682 n rather than nn, a way that does not involve shadowing.
73366a00 4683 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4684
29a6015a
PE
4685 * deps.mk (unexalpha.o): Remove; unused.
4686
43cfc33e 4687 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4688 * unexec.h: New file.
ce701a33
PE
4689 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4690 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4691 Depend on unexec.h.
4692 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4693 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4694 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4695 Change as necessary to match prototype in unexec.h.
ce701a33 4696
01f44d5a
PE
4697 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4698 shadowing.
4f63c6bb 4699 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4700
a6670b0b
PE
4701 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4702 Rename locals to avoid shadowing.
4703
cef2010d 4704 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4705 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4706
d4d7173a
PE
4707 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4708
f08b802a
PE
4709 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4710 warning when compiling print.c.
4711
3ddb0639
PE
4712 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4713 instead of using an uninitialized var.
5ad03b97 4714 (font_sort_entities): Mark var as initialized.
3ddb0639 4715
170a2692
PE
4716 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4717
e663c700
PE
4718 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4719 pointers to constants.
89bc529a 4720 (font_parse_fcname): Remove unused vars.
7b81e2d0 4721 (font_delete_unmatched): Now static.
ea838e10 4722 (font_get_spec): Remove; unused.
13a547c6
PE
4723 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4724 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4725 Rename or move locals to avoid shadowing.
e663c700 4726
2a80c887 4727 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4728 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4729
1384fa33 4730 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4731 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4732
8b2c52e9
PE
4733 * alloc.c (mark_backtrace): Move decl from here ...
4734 * lisp.h: ... to here, so that it can be checked.
4735
475545b5 4736 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4737 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4738 (lisp_indirect_variable): Name an expression,
4739 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4740 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4741
b1349114 4742 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4743 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4744 Use const pointer when appropriate.
b1349114 4745
a2928364
PE
4746 * lisp.h (get_system_name, get_operating_system_release):
4747 Move decls here, to check interfaces.
4748 * process.c (get_operating_system_release): Move decl to lisp.h.
4749 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4750 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4751 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4752 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4753 (Fformat_time_string, Fencode_time, Finsert_char):
4754 (Ftranslate_region_internal, Fformat):
4755 Rename or remove local vars to avoid shadowing.
9710023e 4756 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4757
a415e694
PE
4758 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4759 avoid shadowing.
4760
8ef4622d
PE
4761 * lisp.h (eassert): Check that the argument compiles, even if
4762 ENABLE_CHECKING is not defined.
4763
946f9a5b
PE
4764 * data.c (Findirect_variable): Name an expression, to avoid
4765 gcc -Wbad-function-cast warning.
112396d6 4766 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4767 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4768 (Fmake_variable_buffer_local, Fmake_local_variable):
4769 Mark variables as initialized.
52746918 4770 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4771
e5aab7e7 4772 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4773 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4774 Rename locals to avoid shadowing.
dff45157
PE
4775 (mark_stack): Move local variables into the #ifdef region where
4776 they're used.
7bc26fdb
PE
4777 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4778 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4779 needed otherwise.
4780 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4781 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4782 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4783
e5aab7e7
PE
4784 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4785 avoids undefined behavior in theory.
4786
4da60324
PE
4787 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4788
88043301
PE
4789 Use functions, not macros, for up- and down-casing (Bug#8254).
4790 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4791 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4792 to use the following functions instead of these macros.
4793 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4794 EMACS_INT, since callers assume the returned value fits in int.
4795 (upcase1): Likewise, for UPCASE_TABLE.
4796 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4797 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4798 the race-condition problem in the old DOWNCASE.
88043301 4799
19ed5445
PE
4800 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4801 Rename locals to avoid shadowing.
4802 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4803 (regex_compile, re_search_2, re_match_2_internal):
4804 Remove unused local vars.
952db0d7
PE
4805 (FREE_VAR): Rewrite so as not to use empty "else",
4806 which gcc can warn about.
da053e48 4807 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4808 (RETALLOC_IF): Define only if needed.
4809 (WORDCHAR_P): Likewise. This one is never needed, but is used
4810 only in a comment talking about a compiler bug, so put inside
4811 the #if 0 of that comment.
4812 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4813 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4814 Remove; unused.
19ed5445 4815
1f3561e4 4816 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4817 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4818 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4819
ded6f8f7
PE
4820 * search.c (simple_search): Remove unused var.
4821
dbd37a95
PE
4822 * dired.c (compile_pattern): Move decl from here ...
4823 * lisp.h: ... to here, so that it can be checked.
4824 (struct re_registers): New forward decl.
4825
7e47afad
PE
4826 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4827
85f24f61
PE
4828 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4829 All uses changed.
4830 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4831 Rename locals to avoid shadowing.
5671df8f 4832 (Fvertical_motion): Mark locals as initialized.
85f24f61 4833
181aa2be 4834 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4835 (casify_region): Mark local as initialized.
181aa2be 4836
930d429c
PE
4837 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4838
7082eac6
PE
4839 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4840 New macros, so that the caller can use some names other than
4841 gcpro1, gcpro2, etc.
4842 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4843 of the new macros.
4844 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4845 argument, for consistency with GCPRO2_VAR, etc: it is now the
4846 prefix of the variable, not the variable itself. All uses
4847 changed.
38b2c076
PE
4848 * dired.c (directory_files_internal, file_name_completion):
4849 Rename locals to avoid shadowing.
4850
15206ed9
PE
4851 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4852 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4853 dired.c's scmp function, had undefined behavior.
4854 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4855 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4856 * buffer.h: ... to here, because these macros use current_buffer,
4857 and the new implementation with inline functions needs to have
4858 current_buffer in scope now, rather than later when the macros
4859 are used.
4860 (downcase, upcase1): New static inline functions.
4861 (DOWNCASE, UPCASE1): Reimplement using these functions.
4862 This avoids undefined behavior in expressions like
4863 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4864 from race conditions in accessing the global variables
4865 case_temp1 and case_temp2.
4866 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4867 * lisp.h (case_temp1, case_temp2): Remove their decls.
4868 * character.h (ASCII_CHAR_P): Move from here ...
4869 * lisp.h: ... to here, so that the inline functions mentioned
4870 above can use them.
4871
4a6bea26
PE
4872 * dired.c (directory_files_internal_unwind): Now static.
4873
f14b7e14
PE
4874 * fileio.c (file_name_as_directory, directory_file_name):
4875 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4876 Now static.
2893f146
PE
4877 (file_name_as_directory): Use const pointers when appropriate.
4878 (Fexpand_file_name): Likewise. In particular, newdir might
4879 point at constant storage, so make it a const pointer.
fd4ead52 4880 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4881 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4882 signedness issues.
f839df0c
PE
4883 (Fset_file_times, Finsert_file_contents, auto_save_error):
4884 Rename locals to avoid shadowing.
f14b7e14 4885
5716756e 4886 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4887 (Ftry_completion, Fall_completions): Rename or remove locals
4888 to avoid shadowing.
5716756e 4889
b4c3046a
PE
4890 * marker.c (bytepos_to_charpos): Remove; unused.
4891
b45db522
PE
4892 * lisp.h (verify_bytepos, count_markers): New decls,
4893 so that gcc does not warn that these functions aren't declared.
4894
85876d07
PE
4895 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4896 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4897 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4898 (copy_text): Remove unused local var.
85876d07 4899
03d78a21 4900 * filelock.c (within_one_second): Now static.
b3dd38ab 4901 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4902
5df8f01b
PE
4903 * buffer.c (fix_overlays_before): Mark locals as initialized.
4904 (fix_start_end_in_overlays): Likewise. This function should be
4905 simplified by using pointers-to-pointers, but that's a different
4906 matter.
b1d876f1 4907 (switch_to_buffer_1): Now static.
8f54f30a
PE
4908 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4909 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4910
a70072c9 4911 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4912 Fix pointer signedness issue.
edced198
PE
4913 (sys_subshell): Mark local as volatile if checking for lint,
4914 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4915 (MAXPATHLEN): Define only if needed.
a70072c9 4916
a0977c44
PE
4917 * process.c (serial_open, serial_configure): Move decls from here ...
4918 * systty.h: ... to here, so that they can be checked.
4919
a884fdcc
PE
4920 * fns.c (get_random, seed_random): Move extern decls from here ...
4921 * lisp.h: ... to here, so that they can be checked.
4922
604efe86 4923 * sysdep.c (reset_io): Now static.
b8950c94 4924 (wait_for_termination_signal): Remove; unused.
604efe86 4925
38fc62d9
PE
4926 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4927 (copy_keymap_item, append_key, push_text_char_description):
4928 Now static.
1004a21a 4929 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4930 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4931 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4932 (describe_map_tree):
4933 Rename locals to avoid shadowing.
38fc62d9 4934
2f2650da
PE
4935 * keyboard.c: Declare functions static if they are not used elsewhere.
4936 (echo_char, echo_dash, cmd_error, top_level_2):
4937 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4938 (read_char, kbd_buffer_get_event, make_lispy_position):
4939 (make_lispy_event, make_lispy_movement, apply_modifiers):
4940 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4941 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4942 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4943 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4944 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4945
a053e86c 4946 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4947 (mark_kboards): Move decl here ...
4948 * alloc.c (mark_kboards): ... from here.
a053e86c 4949
4752793e
PE
4950 * lisp.h (force_auto_save_soon): New decl.
4951
74f10ca7 4952 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4953 (DEFINE_DUMMY_FUNCTION): New macro.
4954 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4955 Use it.
c03cd23f
PE
4956 (main): Add casts to avoid warnings
4957 if GCC considers string literals to be constants.
74f10ca7 4958
022e70d4
PE
4959 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4960
59d6fe83
PE
4961 * dbusbind.c: Pointer signedness fixes.
4962 (xd_signature, xd_append_arg, xd_initialize):
4963 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4964 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4965 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4966 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4967
78320123
PE
4968 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4969 if GCC considers string literals to be constants.
49cebcca 4970 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4971
35ac2a97
SM
49722011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4973
fb103ca9
SM
4974 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4975 (print_preprocess, print_object): New macro to fix last change.
4976
35ac2a97
SM
4977 * print.c (print_preprocess): Don't forget font objects.
4978
62973b41
JB
49792011-03-16 Juanma Barranquero <lekktu@gmail.com>
4980
4981 * emacs.c (USAGE3): Doc fixes.
4982
0e48bb22
AS
49832011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4984
4985 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4986 structure.
4987
7684e57b
JB
49882011-03-14 Juanma Barranquero <lekktu@gmail.com>
4989
4990 * lisp.h (VWindow_system, Qfile_name_history):
4991 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4992 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4993 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4994
4995 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4996 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4997
4998 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4999 * w32console.c (detect_input_pending, read_input_pending)
5000 (encode_terminal_code):
5001 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5002 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5003 (w32_system_caret_y, Qfile_name_history):
5004 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5005 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5006 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5007 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5008 * w32proc.c (Qlocal, report_file_error):
5009 * w32term.c (Vwindow_system, updating_frame):
5010 * w32uniscribe.c (initialized, uniscribe_font_driver):
5011 Remove unneeded extern declarations.
5012
2aa46d6c
CY
50132011-03-14 Chong Yidong <cyd@stupidchicken.com>
5014
c96bbc66 5015 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5016
cffc6f3b
CY
50172011-03-13 Chong Yidong <cyd@stupidchicken.com>
5018
5019 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5020 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5021 These macros can no longer be used for assignment.
5022
44f230aa
SM
5023 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5024 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5025 (record_buffer_markers, fetch_buffer_markers): New functions for
5026 recording and fetching special buffer markers.
5027 (set_buffer_internal_1, set_buffer_temp): Use them.
5028
5029 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5030
5031 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5032
5033 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5034 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5035
5036 * xdisp.c (hscroll_window_tree):
5037 (reconsider_clip_changes): Use PT instead of BUF_PT.
5038
d251f04b
EZ
50392011-03-13 Eli Zaretskii <eliz@gnu.org>
5040
5041 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5042 $(EMACS_ROOT)/lib/intprops.h.
5043
f0c77cd1
PE
50442011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5045
3eca4629
PE
5046 Fix more problems found by GCC 4.5.2's static checks.
5047
7c86ee98
PE
5048 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5049 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5050 (xg_free_frame_widgets): Make it clear that a local variable is
5051 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5052 (gdk_window_get_screen): Make it clear that this macro is needed
5053 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5054 (int_gtk_range_get_value): New function, which avoids a diagnostic
5055 from gcc -Wbad-function-cast.
5056 (xg_set_toolkit_scroll_bar_thumb): Use it.
5057 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5058 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5059 (get_utf8_string, xg_get_file_with_chooser):
5060 Rename locals to avoid shadowing.
5061 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5062
41729b81
PE
5063 * xgselect.c (xg_select): Remove unused var.
5064
f0c77cd1
PE
5065 * image.c (four_corners_best): Mark locals as initialized.
5066 (gif_load): Initialize transparent_p to zero (Bug#8238).
5067 Mark another local as initialized.
ec6cf4c6 5068 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5069
ce0ad53d 5070 * image.c (clear_image_cache): Now static.
d5d5a617 5071 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5072 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5073 (x_edge_detection): Remove unnecessary cast that
5074 gcc -Wbad-function-cast diagnoses.
2037898d 5075 (gif_load): Fix pointer signedness.
6ae141d6
PE
5076 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5077 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5078
33383987 50792011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5080
d32df629
PE
5081 Improve quality of tests for time stamp overflow.
5082 For example, without this patch (encode-time 0 0 0 1 1
5083 1152921504606846976) returns the obviously-bogus value (-948597
5084 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5085 reports time overflow. See
5086 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5087 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5088 * editfns.c: Include limits.h and intprops.h.
5089 (TIME_T_MIN, TIME_T_MAX): New macros.
5090 (time_overflow): Move earlier, to before first use.
5091 (hi_time, lo_time): New functions, for an accurate test for
5092 out-of-range times.
5093 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5094 (Fget_internal_run_time): Don't assume time_t fits in int.
5095 (make_time): Use list2 instead of Fcons twice.
5096 (Fdecode_time): More accurate test for out-of-range times.
5097 (check_tm_member): New function.
5098 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5099 (lisp_time_argument): Don't rely on undefined left-shift and
5100 right-shift behavior when checking for time stamp overflow.
8be6f318 5101
fe31d94c
PE
5102 * editfns.c (time_overflow): New function, refactoring common code.
5103 (Fformat_time_string, Fdecode_time, Fencode_time):
5104 (Fcurrent_time_string): Use it.
5105
8be6f318
PE
5106 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5107 * dired.c (make_time): Move to ...
5108 * editfns.c (make_time): ... here.
5109 * systime.h: Note the move.
5110
09d9db2c 51112011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5112
126bc0dc
YM
5113 * fringe.c (update_window_fringes): Remove unused variables.
5114
c47cbdfd
YM
5115 * unexmacosx.c (copy_data_segment): Also copy __got section.
5116 (Bug#8223)
5117
7ac80be9
EZ
51182011-03-12 Eli Zaretskii <eliz@gnu.org>
5119
c96bbc66 5120 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5121 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5122 Constify `char *' arguments and their references according to
5123 prototypes in tparam.h.
5124
ecb0f94d 5125 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5126
7ac80be9
EZ
5127 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5128 Adapt all references accordingly.
5129
5130 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5131
ef1fd07e
TT
51322011-03-11 Tom Tromey <tromey@redhat.com>
5133
5134 * buffer.c (syms_of_buffer): Remove obsolete comment.
5135
7ef4b50c
EZ
51362011-03-11 Eli Zaretskii <eliz@gnu.org>
5137
5138 * termhooks.h (encode_terminal_code): Declare prototype.
5139
5140 * msdos.c (encode_terminal_code): Don't declare prototype.
5141
5142 * term.c (encode_terminal_code): Now external again, used by
5143 w32console.c and msdos.c.
5144
44f230aa
SM
5145 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5146 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5147
4b1ec863 51482011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5149
1714f52b 5150 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5151
4b1ec863
PE
5152 * fringe.c (update_window_fringes): Mark locals as initialized
5153 (Bug#8227).
5154 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5155
524c7aa6
PE
5156 * alloc.c (mark_fringe_data): Move decl from here ...
5157 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5158 to check its interface.
5159 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5160
a5c0af81 5161 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5162 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5163 (fontset_font): Mark local as initialized.
a9a06e0b 5164 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5165
b4716021
PE
5166 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5167
811e9bac 5168 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5169 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5170 (x_own_selection, Fx_disown_selection_internal): Rename locals
5171 to avoid shadowing.
5172 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5173
7e3ab302
PE
5174 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5175 so that the caller can use some name other than gcpro1.
5176 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5177 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5178 (Fx_backspace_delete_keys_p):
5179 Use them to avoid shadowing, and rename vars to avoid shadowing.
5180 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5181 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5182 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5183 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5184 Remove unused locals.
7e3ab302
PE
5185 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5186 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5187 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5188 macros.
f78faa98 5189
e2b13473
PE
5190 * xterm.h (x_mouse_leave): New decl.
5191
77f23912
PE
5192 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5193 Remove unused functions.
cdf4ba58
PE
5194 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5195 (x_calc_absolute_position): Now static.
7411c686 5196 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5197 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5198 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5199 unless they are used.
38d0b34a
PE
5200 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5201 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5202 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5203 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5204 (x_error_catcher, x_connection_closed, x_error_handler):
5205 (x_error_quitter, xembed_send_message, x_iconify_frame):
5206 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5207 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5208 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5209
44f230aa
SM
5210 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5211 Rename or move locals to avoid shadowing.
6b463e58 5212 (tty_defined_color, merge_face_heights): Now static.
5967d051 5213 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5214 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5215 does not deduce is never used uninitialized.
73719eba
PE
5216 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5217 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5218
426994c3 5219 * terminal.c (store_terminal_param): Now static.
5489860b 5220
032f1620 5221 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5222 (set_frame_menubar): Remove unused local.
d4323972 5223 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5224 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5225 since they might point to immutable storage.
281585b0
PE
5226 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5227 since it's unused otherwise.
032f1620 5228
367c19e5 5229 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5230 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5231 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5232 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5233 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5234 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5235 does not deduce are never used uninitialized.
70739cbe 5236
07b48fa9
PE
5237 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5238
8868a238 5239 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5240 * window.c (window_loop, size_window):
5241 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5242
7e5cf297 5243 * window.c (display_buffer): Now static.
d6550a9f
PE
5244 (size_window): Mark variables that gcc -Wuninitialized
5245 does not deduce are never used uninitialized.
a586633d
PE
5246 * window.h (check_all_windows): New decl, to forestall
5247 gcc -Wmissing-prototypes diagnostic.
5b555da1 5248 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5249
f6095868
PE
5250 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5251 shadowing.
5252 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5253 Include <limits.h>.
5254 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5255 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5256 (load_charset_map): Mark variables that gcc -Wuninitialized
5257 does not deduce are never used uninitialized.
53df7c11 5258 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5259
f38b440c
PE
5260 * coding.c (coding_set_source, coding_set_destination):
5261 Use "else { /* comment */ }" rather than "else /* comment */;"
5262 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5263 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5264 a block, when the outer 'i' will do.
5265 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5266 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5267 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5268 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5269 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5270 Rename locals to avoid shadowing.
5271 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5272 * coding.c (emacs_mule_char, encode_invocation_designation):
5273 Now static, since they're not used elsewhere.
413bb2db 5274 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5275 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5276 (decode_coding_emacs_mule): Mark variables that gcc
5277 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5278 (detect_coding_iso_2022): Initialize a local variable that might
5279 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5280 this initialization is needed. (Bug#8211)
5f58e762
PE
5281 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5282 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5283 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5284 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5285 Remove unused macros.
f38b440c 5286
232b38b9 5287 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5288 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5289 * character.c (string_count_byte8): Likewise.
232b38b9 5290
fb90da1b
PE
5291 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5292 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5293
fb93dbc2
PE
5294 * chartab.c (copy_sub_char_table): Now static, since it's not used
5295 elsewhere.
5c156ace
PE
5296 (sub_char_table_ref_and_range, char_table_ref_and_range):
5297 Rename locals to avoid shadowing.
bbcd0949 5298 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5299
7d3b3862 5300 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5301 (BIDI_BOB): Remove unused macro.
7d3b3862 5302
6be7d3da
PE
5303 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5304 deduce are never used uninitialized.
c2ed9c8b 5305 * term.c (encode_terminal_code): Likewise.
6be7d3da 5306
75f8807f 5307 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5308
50938595
PE
5309 * tparam.h: New file.
5310 * term.c, tparam.h: Include it.
5311 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5312 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5313 Move these decls to tparam.h, and make them agree with what
5314 is actually in tparam.c. The previous trick of using incompatible
5315 decls in different modules does not conform to the C standard.
5316 All callers of tparam changed to use tparam's actual API.
5317 * tparam.c (tparam1, tparam, tgoto):
5318 Use const pointers where appropriate.
5319
fbceeba2
PE
5320 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5321 * cm.h (struct cm): Likewise.
5322 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5323 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5324 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5325 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5326 (turn_on_face, init_tty): Likewise.
5327 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5328
7f3f1250
PE
5329 * term.c (term_mouse_position): Rename local to avoid shadowing.
5330
e6ca6543
PE
5331 * alloc.c (mark_ttys): Move decl from here ...
5332 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5333
c40f8d15
AS
53342011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5335
5336 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5337
cfe0661d
JB
53382011-03-09 Juanma Barranquero <lekktu@gmail.com>
5339
5340 * search.c (compile_pattern_1): Remove argument regp, unused since
5341 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5342 (compile_pattern): Don't pass it.
5343
0afb4571
J
53442011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5345
5346 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5347 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5348 for ! HAVE_GTK3.
5349 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5350
5351 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5352
5353 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5354 gdk_window_get_screen, gdk_window_get_geometry,
5355 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5356 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5357 (xg_get_pixbuf_from_pixmap): New function.
5358 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5359 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5360 Call xg_get_pixbuf_from_pixmap instead of
5361 gdk_pixbuf_get_from_drawable.
5362 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5363 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5364 (xg_check_special_colors): Use GtkStyleContext and its functions
5365 for HAVE_GTK3.
5366 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5367 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5368 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5369 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5370 Call gtk_widget_get_preferred_size.
0afb4571
J
5371 (xg_frame_resized): gdk_window_get_geometry only takes 5
5372 parameters.
44f230aa
SM
5373 (xg_win_to_widget, xg_event_is_for_menubar):
5374 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5375 (xg_set_widget_bg): New function.
5376 (delete_cb): New function.
895009e1 5377 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5378 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5379 (xg_set_background_color): Call xg_set_widget_bg.
5380 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5381 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5382 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5383 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5384 if ! HAVE_GTK3.
5385 (update_frame_tool_bar): Call gtk_widget_hide.
5386 (xg_initialize): Use GDK_KEY_g.
5387
5388 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5389 if ! HAVE_GTK3
5390 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5391
5392 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5393 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5394 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5395
1c2cc4ef
JB
53962011-03-08 Juanma Barranquero <lekktu@gmail.com>
5397
5398 * w32xfns.c (select_palette): Check success of RealizePalette against
5399 GDI_ERROR, not zero.
5400
33383987 5401See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5402
5403;; Local Variables:
5404;; coding: utf-8
aac0c6e3
MR
5405;; End:
5406
33383987 5407 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5408
5409 This file is part of GNU Emacs.
5410
5411 GNU Emacs is free software: you can redistribute it and/or modify
5412 it under the terms of the GNU General Public License as published by
5413 the Free Software Foundation, either version 3 of the License, or
5414 (at your option) any later version.
5415
5416 GNU Emacs is distributed in the hope that it will be useful,
5417 but WITHOUT ANY WARRANTY; without even the implied warranty of
5418 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5419 GNU General Public License for more details.
5420
5421 You should have received a copy of the GNU General Public License
5422 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.