* floatfns.c (Fexpt): Omit unnecessary cast to unsigned.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
13bdea59
PE
12011-06-13 Paul Eggert <eggert@cs.ucla.edu>
2
395fcb93 3 * floatfns.c (Fexpt):
327eeec8
PE
4 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5
abbd3d23
PE
6 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7 for characters.
8
684a03ef
PE
9 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10
0fed43f3
PE
11 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
12 Without this fix, on a 64-bit host (aset S 0 4294967386) would
13 incorrectly succeed when S was a string, because 4294967386 was
14 truncated before it was used.
15
8fd02eb7
PE
16 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
17 Otherwise, an out-of-range integer could cause undefined behavior
18 on a 64-bit host.
19
f8c86b69
PE
20 * composite.c: Use int, not EMACS_INT, for characters.
21 (fill_gstring_body, composition_compute_stop_pos): Use int, not
22 EMACS_INT, for values that are known to be in character range.
23 This doesn't fix any bugs but is the usual style inside Emacs and
24 may generate better code on 32-bit machines.
25
34206dd2
PE
26 Make sure a 64-bit char is never passed to ENCODE_CHAR.
27 This is for reasons similar to the recent CHAR_STRING fix.
28 * charset.c (Fencode_char): Check that character arg is actually
29 a character. Pass an int to ENCODE_CHAR.
30 * charset.h (ENCODE_CHAR): Verify that the character argument is no
31 wider than 'int', as a compile-time check to prevent future regressions
32 in this area.
33
c5958d4c 34 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
35
36 Make sure a 64-bit char is never passed to CHAR_STRING.
37 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
38 by silently ignoring the top 32 bits, allowing some values
39 that were far too large to be valid characters.
40 * character.h: Include <verify.h>.
41 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
42 arguments are no wider than unsigned, as a compile-time check
43 to prevent future regressions in this area.
44 * data.c (Faset):
45 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char):
46 (Fsubst_char_in_region):
47 * fns.c (concat):
48 * xdisp.c (decode_mode_spec_coding):
49 Adjust to CHAR_STRING's new requirement.
50 * editfns.c (Finsert_char, Fsubst_char_in_region):
51 * fns.c (concat): Check that character args are actually
52 characters. Without this test, these functions did the wrong
53 thing with wildly out-of-range values on 64-bit hosts.
54
ea204efb
PE
552011-06-12 Paul Eggert <eggert@cs.ucla.edu>
56
d37ca623
PE
57 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
58 These casts should not be needed on 32-bit hosts, either.
59 * keyboard.c (read_char):
60 * lread.c (Fload): Remove casts to unsigned.
61
ea204efb
PE
62 * lisp.h (UNSIGNED_CMP): New macro.
63 This fixes comparison bugs on 64-bit hosts.
64 (ASCII_CHAR_P): Use it.
65 * casefiddle.c (casify_object):
66 * character.h (ASCII_BYTE_P, CHAR_VALID_P):
67 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
68 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
69 * dispextern.h (FACE_FROM_ID):
70 * keyboard.c (read_char): Use UNSIGNED_CMP.
71
fc83f7d3 722011-06-11 Paul Eggert <eggert@cs.ucla.edu>
666398f3 73
41cb286c
PE
74 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
75 not to EMACS_INT, to avoid GCC warning.
76
4a1b9832
PE
77 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
78
55daad71
PE
79 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
80 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
81 isn't needed on 32-bit machines.
8f95c75c 82
666398f3 83 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
0ceccced 84 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
85
86 * data.c (Qcompiled_function): Now static.
87
c6f072e7
PE
88 * window.c (window_body_lines): Now static.
89
20ce5912
PE
90 * image.c (gif_load): Rename local to avoid shadowing.
91
9c4c5f81
PE
92 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
93 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
94 * alloc.c (make_save_value): Integer argument is now of type
95 ptrdiff_t, not int.
96 (mark_object): Use ptrdiff_t, not int.
97 * lisp.h (pD): New macro.
98 * print.c (print_object): Use it.
99
c0c5c8ae
PE
100 * alloc.c: Use EMACS_INT, not int, to count objects.
101 (total_conses, total_markers, total_symbols, total_vector_size)
102 (total_free_conses, total_free_markers, total_free_symbols)
103 (total_free_floats, total_floats, total_free_intervals, total_intervals)
104 (total_strings, total_free_strings):
105 Now EMACS_INT, not int. All uses changed.
106 (Fgarbage_collect): Compute overall total using a double, so that
107 integer overflow is less likely to be a problem. Check for overflow
108 when converting back to an integer.
5a25e253
PE
109 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
110 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
111 These were 'int' variables that could overflow on 64-bit hosts;
112 they were never used, so remove them instead of repairing them.
211a0b2a 113 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
114 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
115 Previously, this ceilinged at INT_MAX, but that doesn't work on
116 64-bit machines.
e46bb31a 117 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 118
c78baabf 119 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 120 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
121 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
122 when a (possibly-narrower) signed value would do just as well.
123 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 124
c9d624c6
PE
125 * alloc.c: Catch some string size overflows that we were missing.
126 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
127 for convenience in STRING_BYTES_MAX.
128 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
129 The definition here is exact; the one in lisp.h was approximate.
130 (allocate_string_data): Check for string overflow. This catches
131 some instances we weren't catching before. Also, it catches
132 size_t overflow on (unusual) hosts where SIZE_MAX <= min
133 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
134 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 135
c9d624c6
PE
136 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
137 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
138 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
139
353032ce
PE
140 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
141
2bccce07
PE
142 * alloc.c (Fmake_string): Check for out-of-range init.
143
b50691aa
CY
1442011-06-11 Chong Yidong <cyd@stupidchicken.com>
145
146 * dispextern.h (struct image): Replace data member, whose int_val
147 and ptr_val fields were not used by anything, with a single
148 lisp_val object.
149
150 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
151 (gif_clear_image, gif_load, imagemagick_load_image)
152 (gs_clear_image, gs_load): Callers changed.
153
3f754b86
PE
1542011-06-10 Paul Eggert <eggert@cs.ucla.edu>
155
cca69397
PE
156 * buffer.h: Include <time.h>, for time_t.
157 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
158
109e28d0
PE
159 Fix minor problems found by static checking.
160
60737f02
PE
161 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
162
4b66faf3
PE
163 Make identifiers static if they are not used in other modules.
164 * data.c (Qcompiled_function, Qframe, Qvector):
165 * image.c (QimageMagick, Qsvg):
166 * minibuf.c (Qmetadata):
167 * window.c (resize_window_check, resize_root_window): Now static.
168 * window.h (resize_window_check, resize_root_window): Remove decls.
169
109e28d0
PE
170 * window.c (window_deletion_count, delete_deletable_window):
171 Remove; unused.
46a4ce9e
PE
172 (window_body_lines): Now static.
173 (Fdelete_other_windows_internal): Mark vars as initialized.
174 Make sure 'resize_failed' is initialized.
175 (run_window_configuration_change_hook): Rename local to avoid shadowing.
176 (resize_window_apply): Remove unused local.
177 * window.h (delete_deletable_window): Remove decl.
178
109e28d0 179 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
180 (imagemagick_load_image): Fix pointer signedness problem by changing
181 last arg from unsigned char * to char *. All uses changed.
182 Also, fix a local for similar reasons.
183 Remove unused locals. Remove locals to avoid shadowing.
184 (fn_rsvg_handle_free): Remove; unused.
185 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 186 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 187
3f754b86
PE
188 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
189
2547adb1
CY
1902011-06-10 Chong Yidong <cyd@stupidchicken.com>
191
192 * image.c (gif_load): Fix omitted cast error introduced by
193 2011-06-06 change.
194
2c8e37d4
MR
1952011-06-10 Martin Rudalics <rudalics@gmx.at>
196
197 * window.h (resize_proportionally, orig_total_lines)
198 (orig_top_line): Remove from window structure.
199 (set_window_height, set_window_width, change_window_heights)
200 (Fdelete_window): Remove prototypes.
201 (resize_frame_windows): Remove duplicate declaration.
202
440a42e3
EZ
2032011-06-10 Eli Zaretskii <eliz@gnu.org>
204
205 * window.h (resize_frame_windows, resize_window_check)
206 (delete_deletable_window, resize_root_window)
207 (resize_frame_windows): Declare prototypes.
208
209 * window.c (resize_window_apply): Make definition be "static" to
210 match the prototype.
211
562dd5e9
MR
2122011-06-10 Martin Rudalics <rudalics@gmx.at>
213
214 * window.c: Remove declarations of Qwindow_size_fixed,
215 window_min_size_1, window_min_size_2, window_min_size,
216 size_window, window_fixed_size_p, enlarge_window, delete_window.
217 Remove static from declaration of Qdelete_window, it's
218 temporarily needed by Fbury_buffer.
219 (replace_window): Don't assign orig_top_line and
220 orig_total_lines.
221 (Fdelete_window, delete_window): Remove. Window deletion is
222 handled by window.el.
223 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
224 Fdelete_window calls with calls to Qdelete_window.
225 (Fdelete_other_windows): Remove. Deleting other windows is
226 handled by window.el.
227 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
228 handled in window.el.
229 (window_min_size_2, window_min_size_1, window_min_size): Remove.
230 Window minimum sizes are handled in window.el.
231 (shrink_windows, size_window, set_window_height)
232 (set_window_width, change_window_heights, window_height)
233 (window_width, CURBEG, CURSIZE, enlarge_window)
234 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
235 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
236 handled in window.el.
237 (make_dummy_parent): Rename to make_parent_window and give it a
238 second argument horflag.
239 (make_window): Don't set resize_proportionally any more.
240 (Fsplit_window): Remove. Windows are split in window.el.
241 (save_restore_action, save_restore_orig_size)
242 (shrink_window_lowest_first, save_restore_orig_size): Remove.
243 Resize mini windows in window.el.
244 (grow_mini_window, shrink_mini_window): Implement by calling
245 Qresize_root_window_vertically, resize_window_check and
246 resize_window_apply.
247 (saved_window, Fset_window_configuration, save_window_save): Do
248 not handle orig_top_line, orig_total_lines, and
249 resize_proportionally.
250 (window_min_height, window_min_width): Move to window.el.
251 (keys_of_window): Move bindings for delete-other-windows,
252 split-window, delete-window and enlarge-window to window.el.
253
254 * buffer.c: Temporarily extern Qdelete_window.
255 (Fbury_buffer): Temporarily call Qdelete_window instead of
256 Fdelete_window (Fbury_buffer will move to window.el soon).
257
258 * frame.c (set_menu_bar_lines_1): Remove code handling
259 orig_top_line and orig_total_lines.
260
261 * dispnew.c (adjust_frame_glyphs_initially): Don't use
262 set_window_height but set heights directly.
263 (change_frame_size_1): Use resize_frame_windows.
264
265 * xdisp.c (init_xdisp): Don't use set_window_height but set
266 heights directly.
267
268 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
269 resize_frame_windows instead of change_window_heights and run
270 run_window_configuration_change_hook.
271
272 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
273 instead of change_window_heights and run
274 run_window_configuration_change_hook.
275
1a13852e
MR
2762011-06-09 Martin Rudalics <rudalics@gmx.at>
277
278 * window.c (replace_window): Rename second argument REPLACEMENT to
279 NEW. New third argument SETFLAG. Rewrite.
280 (delete_window, make_dummy_parent): Call replace_window with
281 third argument 1.
282 (window_list_1): Move down in code.
283 (run_window_configuration_change_hook): Move set_buffer part
284 before select_frame_norecord part in order to unwind correctly.
285 Rename count1 to count.
286 (recombine_windows, delete_deletable_window, resize_root_window)
287 (Fdelete_other_windows_internal)
288 (Frun_window_configuration_change_hook, make_parent_window)
289 (resize_window_check, resize_window_apply, Fresize_window_apply)
290 (resize_frame_windows, Fsplit_window_internal)
291 (Fdelete_window_internal, Fresize_mini_window_internal): New
292 functions.
293 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
294
f3d1777e
MR
2952011-06-08 Martin Rudalics <rudalics@gmx.at>
296
496e208e
MR
297 * window.h (window): Add some new members to window structure -
298 normal_lines, normal_cols, new_total, new_normal, clone_number,
299 splits, nest, prev_buffers, next_buffers.
300 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 301 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 302
f3d1777e
MR
303 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
304 Remove.
496e208e
MR
305 (make_dummy_parent): Set new members of windows structure.
306 (make_window): Move down in code. Handle new members of window
307 structure.
308 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
309 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
310 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
311 (Fset_window_prev_buffers, Fwindow_next_buffers)
312 (Fset_window_next_buffers, Fset_window_clone_number): New
313 functions.
314 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
315 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
316 Doc-string fixes.
317 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
318 Argument WINDOW can be now internal window too.
319 (Fwindow_use_time): Move up in code.
320 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
321 Rewrite doc-string.
322 (Fset_window_configuration, saved_window)
323 (Fcurrent_window_configuration, save_window_save): Handle new
324 members of window structure.
b9e809c2
MR
325 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
326 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
327 (syms_of_window): New Lisp objects Qrecord_window_buffer,
328 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
329 Qget_mru_window, Qresize_root_window,
330 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
331 Qauto_buffer_name; staticpro them.
f3d1777e 332
abde8f8c
MR
3332011-06-07 Martin Rudalics <rudalics@gmx.at>
334
335 * window.c (Fwindow_total_size, Fwindow_left_column)
336 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
337 (Fwindow_list_1): New functions.
338 (window_box_text_cols): Replace with window_body_cols.
339 (Fwindow_width, Fscroll_left, Fscroll_right): Use
340 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
341 (delete_window, Fset_window_configuration): Call
342 delete_all_subwindows with window as argument.
343 (delete_all_subwindows): Take a window as argument and not a
344 structure. Rewrite.
190b47e6
MR
345 (window_loop): Remove handling of GET_LRU_WINDOW and
346 GET_LARGEST_WINDOW.
347 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
348
349 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
350 window_box_text_cols. delete_all_subwindows now takes a
351 Lisp_Object as argument.
abde8f8c
MR
352
353 * indent.c (compute_motion, Fcompute_motion): Use
354 window_body_cols instead of window_box_text_cols.
355
fa8a67e6
MR
356 * frame.c (delete_frame): Call delete_all_subwindows with root
357 window as argument.
358
a54e3482
DC
3592011-06-07 Daniel Colascione <dan.colascione@gmail.com>
360
361 * fns.c (Fputhash): Document return value.
362
60002bf5
CY
3632011-06-06 Chong Yidong <cyd@stupidchicken.com>
364
365 * image.c (gif_load): Implement gif89a spec "no disposal" method.
366
0c671da6 3672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 368
b862a52a 369 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 370
be44ca6c
PE
371 Check for overflow when converting integer to cons and back.
372 * charset.c (Fdefine_charset_internal, Fdecode_char):
373 Use cons_to_unsigned to catch overflow.
374 (Fencode_char): Use INTEGER_TO_CONS.
375 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
376 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
377 * data.c (long_to_cons, cons_to_long): Remove.
378 (cons_to_unsigned, cons_to_signed): New functions.
379 These signal an error for invalid or out-of-range values.
380 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
381 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
382 * font.c (Ffont_variation_glyphs):
383 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
384 * lisp.h: Include <intprops.h>.
385 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
386 (cons_to_signed, cons_to_unsigned): New decls.
387 (long_to_cons, cons_to_long): Remove decls.
388 * undo.c (record_first_change): Use INTEGER_TO_CONS.
389 (Fprimitive_undo): Use CONS_TO_INTEGER.
390 * xfns.c (Fx_window_property): Likewise.
391 * xselect.c: Include <limits.h>.
392 (x_own_selection, selection_data_to_lisp_data):
393 Use INTEGER_TO_CONS.
394 (x_handle_selection_request, x_handle_selection_clear)
395 (x_get_foreign_selection, Fx_disown_selection_internal)
396 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
397 (lisp_data_to_selection_data): Use cons_to_unsigned.
398 (x_fill_property_data): Use cons_to_signed.
399 Report values out of range.
400
d1f3d2af
PE
401 Check for buffer and string overflow more precisely.
402 * buffer.h (BUF_BYTES_MAX): New macro.
403 * lisp.h (STRING_BYTES_MAX): New macro.
404 * alloc.c (Fmake_string):
405 * character.c (string_escape_byte8):
406 * coding.c (coding_alloc_by_realloc):
407 * doprnt.c (doprnt):
408 * editfns.c (Fformat):
409 * eval.c (verror):
410 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
411 since they may not be the same number.
412 * editfns.c (Finsert_char):
413 * fileio.c (Finsert_file_contents):
414 Likewise for BUF_BYTES_MAX.
415
dd52fcea
PE
416 * image.c: Use ptrdiff_t, not int, for sizes.
417 (slurp_file): Switch from int to ptrdiff_t.
418 All uses changed.
419 (slurp_file): Check that file size fits in both size_t (for
420 malloc) and ptrdiff_t (for sanity and safety).
421
7f9bbdbb
PE
422 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
423 if b->modtime has its maximal value.
424
dfe18f82
PE
425 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
426
84acfcf0
PE
427 Don't assume time_t can fit into int.
428 * buffer.h (struct buffer.modtime): Now time_t, not int.
429 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
430 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
431
ccd9a01a
PE
432 Minor fixes for signed vs unsigned integers.
433 * character.h (MAYBE_UNIFY_CHAR):
434 * charset.c (maybe_unify_char):
435 * keyboard.c (read_char, reorder_modifiers):
436 XINT -> XFASTINT, since the integer must be nonnegative.
437 * ftfont.c (ftfont_spec_pattern):
438 * keymap.c (access_keymap, silly_event_symbol_error):
439 XUINT -> XFASTINT, since the integer must be nonnegative.
440 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
441 since it makes no difference and we prefer signed.
442 * keyboard.c (record_char): Use XUINT when all the neighbors do.
443 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
444 nonnegative.
445
d6d100dd
SM
4462011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
447
448 * window.h (Fwindow_frame): Declare.
449
2b6148e4
PE
4502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
451
452 * alloc.c: Simplify handling of large-request failures (Bug#8800).
453 (SPARE_MEMORY): Always define.
454 (LARGE_REQUEST): Remove.
455 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
456
f230ecc9
MR
4572011-06-06 Martin Rudalics <rudalics@gmx.at>
458
727e958e
MR
459 * lisp.h: Move EXFUNS for Fframe_root_window,
460 Fframe_first_window and Fset_frame_selected_window to window.h.
461
462 * window.h: Move EXFUNS for Fframe_root_window,
463 Fframe_first_window and Fset_frame_selected_window here from
464 lisp.h.
465
466 * frame.c (Fwindow_frame, Fframe_first_window)
467 (Fframe_root_window, Fframe_selected_window)
468 (Fset_frame_selected_window): Move to window.c.
469 (Factive_minibuffer_window): Move to minibuf.c.
470 (Fother_visible_frames_p): New function.
471
472 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
473
f230ecc9
MR
474 * window.c (decode_window, decode_any_window): Move up in code.
475 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
476 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
477 (Fwindow_buffer): Move up and rewrite doc-string.
478 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
479 (Fwindow_prev): New functions.
727e958e
MR
480 (Fwindow_frame): Move here from frame.c. Accept any window as
481 argument.
482 (Fframe_root_window, Fframe_first_window)
483 (Fframe_selected_window): Move here from frame.c. Accept frame
484 or arbitrary window as argument. Update doc-strings.
485 (Fminibuffer_window): Move up in code.
486 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
487 (Fset_frame_selected_window): Move here from frame.c.
488 Marginal rewrite.
727e958e
MR
489 (Fselected_window, select_window, Fselect_window): Move up in
490 code. Minor doc-string fixes.
f230ecc9 491
4d09bcf6
PE
4922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
493
494 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
495 Do not assume that spare memory exists; that assumption is valid
496 only if SYSTEM_MALLOC.
497 (LARGE_REQUEST): New macro, so that the issue of large requests
498 is separated from the issue of spare memory.
499
810928a2
AS
5002011-06-05 Andreas Schwab <schwab@linux-m68k.org>
501
172418ad
AS
502 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
503 format. (Bug#8806)
504
43f862f7
AS
505 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
506
810928a2
AS
507 * xfns.c (x_set_scroll_bar_default_width): Move declarations
508 before statements.
509
a059fe24
JD
5102011-06-05 Jan Djärv <jan.h.d@swipnet.se>
511
512 * gtkutil.c (xg_get_default_scrollbar_width): New function.
513
514 * gtkutil.h: Declare xg_get_default_scrollbar_width.
515
516 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
517 min width by calling x_set_scroll_bar_default_width (Bug#8505).
518
989bf368
JB
5192011-06-05 Juanma Barranquero <lekktu@gmail.com>
520
521 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
522
4b80f674
CY
5232011-06-04 Chong Yidong <cyd@stupidchicken.com>
524
525 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
526 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
527 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
528 New error handlers.
4b80f674
CY
529 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
530 Obey Vx_select_enable_clipboard_manager. Catch errors in
531 x_clipboard_manager_save (Bug#8779).
532 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 533 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 534
99a33b77 5352011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
536
537 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
538
99a33b77 5392011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
540
541 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
542 in the current matrix if keep_current_p is non-zero.
543
8264569d
EZ
5442011-06-04 Eli Zaretskii <eliz@gnu.org>
545
546 * bidi.c (bidi_level_of_next_char): Fix last change.
547
57f97249
EZ
5482011-06-03 Eli Zaretskii <eliz@gnu.org>
549
fec2107c 550 Support bidi reordering of text covered by display properties.
57f97249 551
fec2107c
EZ
552 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
553 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
554 (bidi_cache_search, bidi_cache_iterator_state)
555 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
556 (bidi_level_of_next_char, bidi_move_to_visually_next):
557 Support character positions inside a run of characters covered by a
fec2107c
EZ
558 display string.
559 (bidi_paragraph_init, bidi_resolve_explicit_1)
560 (bidi_level_of_next_char): Call bidi_fetch_char and
561 bidi_fetch_char_advance instead of FETCH_CHAR and
562 FETCH_CHAR_ADVANCE.
563 (bidi_init_it): Initialize new members.
564 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
565 definitions.
566 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
567 instead of using explicit *_CHAR codes.
d6d100dd
SM
568 (bidi_resolve_explicit, bidi_resolve_weak):
569 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
570 bidirectional text is supported only in multibyte buffers.
571 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
572 it to initialize the frame_window_p member of struct bidi_it.
573 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
574 (bidi_resolve_explicit, bidi_resolve_weak)
575 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
576 bidi_it->nchars is non-positive.
577 (bidi_level_of_next_char): Don't try to lookup the cache for the
578 next/previous character if nothing is cached there yet, or if we
579 were just reseat()'ed to a new position.
c40e2fb2 580
0e14fe90
EZ
581 * xdisp.c (set_cursor_from_row): Set start and stop points
582 according to the row's direction when priming the loop that looks
583 for the glyph on which to display cursor.
584 (single_display_spec_intangible_p): Function deleted.
585 (display_prop_intangible_p): Reimplement to call
586 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
587 Accept 3 additional arguments needed by handle_display_spec.
588 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
589 values: lists, `(when COND...)' forms, etc.
590 (single_display_spec_string_p): Support property values that are
591 lists with the argument STRING its top-level element.
592 (display_prop_string_p): Fix the condition for processing a
593 property that is a list to be consistent with handle_display_spec.
fec2107c 594 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
595 last portion of handle_display_prop.
596 (compute_display_string_pos): Accept additional argument
597 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
598 value of a `display' property is a "replacing spec".
599 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
600 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
601 the display property, but just return a value indicating whether
602 the display property will replace the characters it covers.
603 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
604 frame_window_p members of struct bidi_it.
d6d100dd
SM
605 (compute_display_string_pos, compute_display_string_end):
606 New functions.
fec2107c
EZ
607 (push_it): Accept second argument POSITION, where pop_it should
608 jump to continue iteration.
609 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 610
fec2107c
EZ
611 * keyboard.c (adjust_point_for_property): Adjust the call to
612 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
613
614 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
615 (bidi_init_it): Update prototypes.
616 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
617 (compute_display_string_pos, compute_display_string_end):
618 Declare prototypes.
fec2107c
EZ
619 (struct bidi_it): New members nchars and disp_pos. ch_len is now
620 EMACS_INT.
fc6f18ce 621
40087514 6222011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 623
57f53182
PE
624 Malloc failure behavior now depends on size of allocation.
625 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
626 * lisp.h: Change signatures accordingly.
627 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
628 All callers changed. (Bug#8762)
629
630 * gnutls.c: Use Emacs's memory allocators.
631 Without this change, the gnutls library would invoke malloc etc.
632 directly, which causes problems on non-SYNC_INPUT hosts, and which
633 runs afoul of improving memory_full behavior. (Bug#8761)
634 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
635 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
636 xfree instead of the default malloc, realloc, free.
637 (Fgnutls_boot): No need to check for memory allocation failure,
638 since xmalloc does that for us.
639
ac32cd99 640 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
641 * category.c (hash_get_category_set):
642 * ccl.c (ccl_driver):
643 * charset.c (Fdefine_charset_internal):
644 * charset.h (struct charset.hash_index):
645 * composite.c (get_composition_id, gstring_lookup_cache)
646 (composition_gstring_put_cache):
647 * composite.h (struct composition.hash_index):
648 * dispextern.h (struct image.hash):
649 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
650 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
651 (hashfn_equal, hashfn_user_defined, make_hash_table)
652 (maybe_resize_hash_table, hash_lookup, hash_put)
653 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
654 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
655 (Fsxhash, Fgethash, Fputhash, Fmaphash):
656 * image.c (make_image, search_image_cache, lookup_image)
657 (xpm_put_color_table_h):
658 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 659 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
660 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
661 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
662 * alloc.c (allocate_vectorlike):
663 Check for overflow in vector size calculations.
664 * ccl.c (ccl_driver):
665 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
666 * fns.c, image.c: Remove unnecessary static decls that would otherwise
667 need to be updated by these changes.
40087514
PE
668 * fns.c (make_hash_table, maybe_resize_hash_table):
669 Check for integer overflow with large hash tables.
0de4bb68
PE
670 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
671 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
672 (SXHASH_REDUCE): New macro.
673 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
674 Use it instead of discarding useful hash info with large hash values.
675 (sxhash_float): New function.
676 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
677 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
678 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
679 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
680 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
681 Adjust signatures to match updated version of code.
682 (consing_since_gc): Now EMACS_INT, since a single hash table can
683 use more than INT_MAX bytes.
684
698d32e2
DN
6852011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
686
687 Make it possible to build with GCC-4.6+ -O2 -flto.
688
689 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
690
fd6fa53f
SM
6912011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
692
693 * minibuf.c (get_minibuffer, read_minibuf_unwind):
694 Call minibuffer-inactive-mode.
695
864db017
JB
6962011-05-31 Juanma Barranquero <lekktu@gmail.com>
697
698 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
699 Update dependencies.
700
2ad0baf4
DN
7012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
702
703 * data.c (init_data): Remove code for UTS, this system is not
704 supported anymore.
705
4fcc2638
DN
7062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
707
708 Don't force ./temacs to start in terminal mode.
709
710 * frame.c (make_initial_frame): Initialize faces in all cases, not
711 only when CANNOT_DUMP is defined.
712 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
713
c56e0fd5
DN
7142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
715
716 * dispnew.c (add_window_display_history): Use const for the string
717 pointer. Remove declaration, not needed.
718
333d54da 7192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 720
55d4c1b2 721 Use 'inline', not 'INLINE'.
333d54da 722 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
723 * alloc.c, fontset.c (INLINE): Remove.
724 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
725 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
726 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
727 * gmalloc.c (register_heapinfo): Use inline unconditionally.
728 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
729
738db178
DN
7302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
731
732 Make it possible to run ./temacs.
733
734 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
735 syms_of_callproc does the same thing. Remove test for
736 "initialized", do it in the caller.
737 * emacs.c (main): Avoid calling set_initial_environment when dumping.
738
620c53a6
SM
7392011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
740
741 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
742 (read_minibuf): Use get_minibuffer.
743 (syms_of_minibuf): Use DEFSYM.
744 (Qmetadata): New var.
745 * data.c (Qbuffer): Don't make it static.
746 (syms_of_data): Use DEFSYM.
747
e003a292
PE
7482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
749
750 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
751 (CCL_CODE_MIN): New macro.
752
ed008a6d
PE
7532011-05-30 Paul Eggert <eggert@cs.ucla.edu>
754
3687c2ef
PE
755 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
756
ed008a6d
PE
757 * eval.c (Qdebug): Now static.
758 * lisp.h (Qdebug): Remove decl. This reverts a part of the
759 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
760 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
761
d66c4c7c
CY
7622011-05-29 Chong Yidong <cyd@stupidchicken.com>
763
764 * image.c: Various fixes to ImageMagick code comments.
765 (Fimagemagick_types): Doc fix.
766
5fbc2025
PE
7672011-05-29 Paul Eggert <eggert@cs.ucla.edu>
768
0196f88a
PE
769 Minor fixes prompted by GCC 4.6.0 warnings.
770
771 * xselect.c (converted_selections, conversion_fail_tag): Now static.
772
5fbc2025
PE
773 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
774 (x_clipboard_manager_save_all): Move extern decl to ...
775 * xterm.h: ... here, so that it can be checked for consistency.
776
1dd3c2d9
CY
7772011-05-29 Chong Yidong <cyd@stupidchicken.com>
778
779 * xselect.c (x_clipboard_manager_save_frame)
780 (x_clipboard_manager_save_all): New functions.
781 (Fx_clipboard_manager_save): Lisp function deleted.
782
783 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
784 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
785
786 * xterm.h: Update prototype.
787
5ba6571d
WX
7882011-05-28 William Xu <william.xwl@gmail.com>
789
790 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
791 exiting (Bug#8239).
792
3eaff834
JM
7932011-05-28 Jim Meyering <meyering@redhat.com>
794
e1900994 795 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
796 * fns.c (to_uchar): Define.
797 (crypto_hash_function): Use it to convert some newly-signed
798 variables to unsigned, to avoid sign-extension bugs. For example,
799 without this change, (md5 "truc") would evaluate to
800 45723a2aff78ff4fff7fff1114760e62 rather than the expected
801 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 802 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 803
0f6990a7
PE
8042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
805
806 Integer overflow fixes.
c8a9ca5a 807
08686060
PE
808 * dbusbind.c: Serial number integer overflow fixes.
809 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
810 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
811 to hold a serial number that is too large for a fixnum.
812 (Fdbus_method_return_internal, Fdbus_method_error_internal):
813 Check for serial numbers out of range. Decode any serial number
59568bf0 814 that was so large that it became a float. (Bug#8722)
08686060 815
2d1fc3c7
PE
816 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
817 (Fdbus_call_method, Fdbus_call_method_asynchronously):
818 Use XFASTINT rather than XUINT when numbers are nonnegative.
819 (xd_append_arg, Fdbus_method_return_internal):
820 (Fdbus_method_error_internal): Likewise. Also, for unsigned
821 arguments, check that Lisp number is nonnegative, rather than
59568bf0 822 silently wrapping negative numbers around. (Bug#8722)
30217ff0 823 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 824 (Bug#8722)
2d1fc3c7 825
c8a9ca5a
PE
826 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
827
519e1d69
PE
828 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
829
30569699
PE
830 ccl: add integer overflow checks
831 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
832 (IN_INT_RANGE): New macros.
833 (ccl_driver): Use them to check for integer overflow when
834 decoding a CCL program. Many of the new checks are whether XINT (x)
835 fits in int; it doesn't always, on 64-bit hosts. The new version
836 doesn't catch all possible integer overflows, but it's an
847044ea 837 improvement. (Bug#8719)
30569699 838
c11285dc
PE
839 * alloc.c (make_event_array): Use XINT, not XUINT.
840 There's no need for unsigned here.
841
fdccd48e
PE
842 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
843 This follows up to the 2011-05-06 change that substituted uintptr_t
844 for EMACS_INT. This case wasn't caught back then.
845
37910ab2
PE
846 Rework Fformat to avoid integer overflow issues.
847 * editfns.c: Include <float.h> unconditionally, as it's everywhere
848 now (part of C89). Include <verify.h>.
849 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
850 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
851 (Fformat): Avoid the prepass trying to compute sizes; it was only
852 approximate and thus did not catch overflow reliably. Instead, walk
853 through the format just once, formatting and computing sizes as we go,
854 checking for integer overflow at every step, and allocating a larger
855 buffer as needed. Keep track separately whether the format is
856 multibyte. Keep only the most-recently calculated precision, rather
857 than them all. Record whether each argument has been converted to
858 string. Use EMACS_INT, not int, for byte and char and arg counts.
859 Support field widths and precisions larger than INT_MAX. Avoid
860 sprintf's undefined behavior with conversion specifications such as %#d
861 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
862 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
863 formatting out-of-range floating point numbers with int
864 formats. (Bug#8668)
865
2e6578fb
PE
866 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
867
0ae6bdee
PE
868 * data.c: Avoid integer truncation in expressions involving floats.
869 * data.c: Include <intprops.h>.
870 (arith_driver): When there's an integer overflow in an expression
871 involving floating point, convert the integers to floating point
872 so that the resulting value does not suffer from catastrophic
873 integer truncation. For example, on a 64-bit host (* 4
874 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
875 Do not rely on undefined behavior after integer overflow.
876
de883a70
PE
877 merge count_size_as_multibyte, parse_str_to_multibyte
878 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 879 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
880 Check for integer overflow.
881 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
882 since it's now a duplicate of the other. This is more of
883 a character than a buffer op, so better that it's in character.c.
884 * fns.c, print.c: Adjust to above changes.
885
2ff916cb
PE
8862011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
887
888 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
889
f1b54466
PE
8902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
891
fb1ac845
PE
892 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
893 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
894 (x_clipboard_manager_save): Now static.
895 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
896
f1b54466
PE
897 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
898 (crypto_hash_function): Now static.
899 Fix pointer signedness problems. Avoid unnecessary initializations.
900
a9f737ee
CY
9012011-05-27 Chong Yidong <cyd@stupidchicken.com>
902
903 * termhooks.h (Vselection_alist): Make it terminal-local.
904
905 * terminal.c (create_terminal): Initialize it.
906
907 * xselect.c: Support for clipboard managers.
908 (Vselection_alist): Move to termhooks.h as terminal-local var.
909 (LOCAL_SELECTION): New macro.
910 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
911 (symbol_to_x_atom): Remove gratuitous arg.
912 (x_handle_selection_request, lisp_data_to_selection_data)
913 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
914 (x_own_selection, x_get_local_selection, x_convert_selection):
915 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
916 (some_frame_on_display): Delete unused function.
917 (Fx_own_selection_internal, Fx_get_selection_internal)
918 (Fx_disown_selection_internal, Fx_selection_owner_p)
919 (Fx_selection_exists_p): New optional frame arg.
920 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
921 (x_handle_selection_clear): Don't treat other terminals with the
922 same keyboard specially. Use the terminal-local Vselection_alist.
923 (x_clear_frame_selections): Use Frun_hook_with_args.
924
925 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
926
927 * xterm.h: Add support for those atoms.
928
e067f0c1
CY
9292011-05-26 Chong Yidong <cyd@stupidchicken.com>
930
931 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
932 (converted_selections, conversion_fail_tag): New global variables.
933 (x_selection_request_lisp_error): Free the above.
934 (x_get_local_selection): Remove unnecessary code.
935 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
936 of converted selections stored in converted_selections.
937 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
938 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
939 (x_convert_selection): New function.
940 (x_handle_selection_event): Simplify.
941 (x_get_foreign_selection): Don't ignore incoming requests while
942 waiting for an answer; this will fail when we implement
943 SAVE_TARGETS, and seems unnecessary anyway.
944 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
945 (Vx_sent_selection_functions): Doc fix.
946
0f4aebc0
LL
9472011-05-26 Leo Liu <sdl.web@gmail.com>
948
949 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
950
e61124cd
YM
9512011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
952
953 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
954
955 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
956 for fringe update if it has periodic bitmap.
957 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
958 and fringe_bitmap_periodic_p.
959
960 * fringe.c (get_fringe_bitmap_data): New function.
961 (draw_fringe_bitmap_1, update_window_fringes): Use it.
962 (update_window_fringes): Record periodicity of fringe bitmap in glyph
963 row. Mark glyph row for fringe update if periodicity changed.
964
965 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
966 for fringe update unless it has periodic bitmap.
967
f16d9837
KH
9682011-05-25 Kenichi Handa <handa@m17n.org>
969
970 * xdisp.c (get_next_display_element): Set correct it->face_id for
971 a static composition.
972
e1b90ef6
LL
9732011-05-24 Leo Liu <sdl.web@gmail.com>
974
975 * deps.mk (fns.o):
976 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
977
978 * fns.c (crypto_hash_function, Fsha1): New function.
979 (Fmd5): Use crypto_hash_function.
980 (syms_of_fns): Add Ssha1.
981
7400048f
PE
9822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
983
984 * gnutls.c: Remove unused macros.
985 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
986 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
987 Remove macros that are defined and never used.
988 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
989
abb71cf4
CY
9902011-05-22 Chong Yidong <cyd@stupidchicken.com>
991
992 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
993 (Fx_get_selection_internal): Minor cleanup.
994 (Fx_own_selection_internal): Rename arguments for consistency with
995 select.el.
996
6307db39
PE
9972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
998
999 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1000
f3d4e0a4
CY
10012011-05-22 Chong Yidong <cyd@stupidchicken.com>
1002
1003 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1004
4d8ade89
YM
10052011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1006
1007 * dispnew.c (scrolling_window): Don't exclude the case that the
1008 last enabled row in the desired matrix touches the bottom boundary.
1009
32078c8d
GM
10102011-05-21 Glenn Morris <rgm@gnu.org>
1011
1012 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1013 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1014 and add some more files.
32078c8d 1015
7285dc67
EZ
10162011-05-20 Eli Zaretskii <eliz@gnu.org>
1017
1018 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1019 report_file_error introduced by the change from 2011-05-07.
1020
89d1bd22
PE
10212011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1022
1023 * systime.h (Time): Define only if emacs is defined.
1024 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1025 where the include path doesn't have X11/X.h by default. See
1026 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1027
e23640bb 10282011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1029
1030 * composite.c (find_automatic_composition): Fix previous change.
1031
b9704ad9
GM
10322011-05-20 Glenn Morris <rgm@gnu.org>
1033
1034 * lisp.mk: New file, split from Makefile.in.
1035 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1036 (shortlisp): Remove.
1037 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1038
4a720484
GM
10392011-05-19 Glenn Morris <rgm@gnu.org>
1040
1041 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1042 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1043 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1044 (lisp): Set the order to that of loadup.el.
1045 (shortlisp): Make it a copy of $lisp.
1046 (SOME_MACHINE_LISP): Remove.
1047 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1048 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1049
a28d4396
KH
10502011-05-18 Kenichi Handa <handa@m17n.org>
1051
1052 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1053 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1054 (find_automatic_composition): Mostly rewrite for efficiency.
1055
a2b1fa8e
JB
10562011-05-18 Juanma Barranquero <lekktu@gmail.com>
1057
1058 * makefile.w32-in: Update dependencies.
1059
8e1f5610
CS
10602011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1061
1062 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1063 revision 104625).
1064
7025ee00 10652011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1066
cdfa6eab
PE
1067 Fix some integer overflow issues, such as string length overflow.
1068
06d6db33
PE
1069 * insdel.c (count_size_as_multibyte): Check for string overflow.
1070
2b4560a8
PE
1071 * character.c (lisp_string_width): Check for string overflow.
1072 Use EMACS_INT, not int, for string indexes and lengths; in
1073 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1074 the resulting string length overflows an EMACS_INT; instead,
1075 report a string overflow if no precision given. When checking for
1076 precision exhaustion, use a check that cannot possibly have
1077 integer overflow. (Bug#8675)
1078 * character.h (lisp_string_width): Adjust to new signature.
1079
cb93f9be
PE
1080 * alloc.c (string_overflow): New function.
1081 (Fmake_string): Use it. This doesn't change behavior, but saves
1082 a few bytes and will simplify future changes.
1083 * character.c (string_escape_byte8): Likewise.
1084 * lisp.h (string_overflow): New decl.
1085
1a1f3366
PE
1086 Fixups, following up to the user-interface timestamp change.
1087 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1088 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1089 * msdos.c (mouse_get_pos): Likewise.
1090 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1091 * w32gui.h (Time): Define by including "systime.h" rather than by
1092 declaring it ourselves. (Bug#8664)
1093
d4e3e4d3
PE
1094 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1095 * image.c (clear_image_cache): Likewise.
1096
f6a24d19
PE
1097 * term.c (term_mouse_position): Don't assume time_t wraparound.
1098
08dc5ae6
PE
1099 Be more systematic about user-interface timestamps.
1100 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1101 and sometimes 'EMACS_UINT', to represent these timestamps.
1102 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1103 This makes the code easier to follow, and makes it easier to catch
1104 integer overflow bugs such as Bug#8664.
1105 * frame.c (Fmouse_position, Fmouse_pixel_position):
1106 Use Time, not unsigned long, for user-interface timestamps.
1107 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1108 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1109 * keyboard.h (last_event_timestamp): Likewise.
1110 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1111 * menu.h (xmenu_show): Likewise.
1112 * term.c (term_mouse_position): Likewise.
1113 * termhooks.h (struct input_event.timestamp): Likewise.
1114 (struct terminal.mouse_position_hook): Likewise.
1115 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1116 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1117 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1118 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1119 what it was before.
1120 * menu.h, termhooks.h: Include "systime.h", for Time.
1121
8e55734a
PE
1122 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1123 Don't assume that the difference between two unsigned long values
1124 can fit into an integer. At this point, we know button_down_time
1125 <= event->timestamp, so the difference must be nonnegative, so
1126 there's no need to cast the result if double-click-time is
1127 nonnegative, as it should be; check that it's nonnegative, just in
1128 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1129 apart (about 25 days). (Bug#8664)
8e55734a 1130
841f1b75 1131 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1132 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1133
3e26f69c
PE
1134 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1135 that always fit in int. Use a sentinel instead of a counter, to
1136 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1137 * frame.h (struct frame): Use int for menu_bar_items_used
1138 instead of EMACS_INT, since it always fits in int.
3e26f69c 1139
5cc152c0
PE
1140 * menu.c (grow_menu_items): Check for int overflow.
1141
d89eb65e
PE
1142 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1143
5235bd3e
PE
1144 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1145 Before, the code was not consistent. These values cannot exceed
1146 2**31 - 1 so there's no need to make them unsigned.
1147 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1148 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1149 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1150 as modifiers.
1151 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1152
bc827e23
PE
1153 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1154 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1155 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1156 presumably because the widths might not match.
1157
78eb494e
PE
1158 * window.c (size_window): Avoid needless test at loop start.
1159
04f2d78b
CB
11602011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1161
1162 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1163
d2fc7e3d 11642011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1165
1166 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1167
d2fc7e3d 11682011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1169
1170 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1171 `width' to `bar_area_x' and `bar_area_width', respectively.
1172 (x_scroll_run): Take account of fringe background extension.
1173
04f2d78b
CB
1174 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1175 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1176 `bar_area_width', respectively.
1177 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1178 background extension.
1179
79b70037
GM
11802011-05-10 Jim Meyering <meyering@redhat.com>
1181
1182 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1183
2f142cc5
JB
11842011-05-10 Juanma Barranquero <lekktu@gmail.com>
1185
1186 * image.c (Finit_image_library): Return t for built-in image types,
1187 like pbm and xbm. (Bug#8640)
1188
57679c86
AS
11892011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1190
1191 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1192
888c9e86
EZ
11932011-05-07 Eli Zaretskii <eliz@gnu.org>
1194
b0512a1d
EZ
1195 * w32console.c (Fset_screen_color): Doc fix.
1196 (Fget_screen_color): New function.
1197 (syms_of_ntterm): Defsubr it.
1198
7285dc67
EZ
1199 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1200 unlink the temporary file if Fcall_process didn't create it in the
1201 first place.
1202 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1203 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1204 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1205 cue to call_process_cleanup not to close that handle.
1206
4d3fcc8e
BK
12072011-05-07 Ben Key <bkey76@gmail.com>
1208
1209 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1210 one of two shell specific rules, either bootstrap-temacs-CMD or
1211 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1212 to the previous implementation of the bootstrap-temacs rule.
1213 The bootstrap-temacs-CMD rule is similar to the previous
1214 implementation of the bootstrap-temacs rule except that it
1215 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1216 variable.
1217
1218 These changes, along with some changes to nt/configure.bat,
1219 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1220 earlier fix to add support for --cflags and --ldflags options
1221 that include quotes so that it works whether make uses cmd or
1222 sh as the shell.
1223
b4289b64
MA
12242011-05-06 Michael Albinus <michael.albinus@gmx.de>
1225
1226 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1227 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1228 is a constant.
1229 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1230 a string. Handle both cases.
1231 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1232 (Fdbus_register_method): Use Qinvalid_function.
1233
af4c0e28
JB
12342011-05-06 Juanma Barranquero <lekktu@gmail.com>
1235
1236 * makefile.w32-in: Update dependencies.
1237 (LISP_H): Add inttypes.h and stdin.h.
1238 (PROCESS_H): Add unistd.h.
1239
c51453d9
EZ
12402011-05-06 Eli Zaretskii <eliz@gnu.org>
1241
1242 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1243 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1244
8ff0ac3c 12452011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1246
4c4b566b
PE
1247 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1248
aab2b9b5
PE
1249 * term.c (vfatal): Remove stray call to va_end.
1250 It's not needed and the C Standard doesn't allow it here anyway.
1251
c378da0b
PE
1252 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1253 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1254
288b08c7
PE
1255 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1256 bytes.
1257
e3601888
PE
1258 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1259
db6c0e74
PE
1260 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1261
dd5963ea
PE
1262 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1263
88c9450f
PE
1264 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1265
2f9442b8
PE
1266 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1267
c032b5f8
PE
1268 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1269 * charset.c (Fdefine_charset_internal): Don't initialize
1270 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1271 32-bit int (Bug#8600).
a108c10b
PE
1272
1273 * lread.c (read_integer): Be more consistent with string-to-number.
1274 Use string_to_number to do the actual conversion; this avoids
1275 rounding errors and fixes some other screwups. Without this fix,
1276 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1277 (digit_to_number): Move earlier, for benefit of read_integer.
1278 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1279 not a digit in any supported base. (Bug#8602)
a108c10b 1280
ad5f9eea
PE
1281 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1282
aec1708a
PE
1283 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1284 to match comment at start of function. This also removes a
1285 GCC warning about overflow in a 32+64-bit port.
1286
47be4ab5
PE
1287 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1288
371cac43
PE
1289 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1290 Reported by Stefan Monnier in
1291 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1292 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1293 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1294
d01a7826
PE
1295 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1296 (EMACS_UINTPTR): Likewise, with uintptr_t.
1297
7fd47d5c
PE
1298 * lisp.h: Prefer 64-bit EMACS_INT if available.
1299 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1300 on 32-bit hosts that have 64-bit int, so that they can access
1301 large files.
122b0c86
PE
1302 However, temporarily disable this change unless the temporary
1303 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1304
8727937b
PE
1305 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1306
8ac068ac
PE
1307 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1308 This removes an assumption that EMACS_INT and long are the same
1309 width as pointers. The assumption is true for Emacs porting targets
1310 now, but we want to make other targets possible.
1311 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1312 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1313 In the rest of the code, change types of integers that hold casted
1314 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1315 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1316 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1317 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1318 No need to cast type when ORing.
1319 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1320 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1321 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1322 assume EMACS_INT is the same width as char *.
1323 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1324 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1325 Remove no-longer-needed casts.
1326 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1327 (xg_tool_bar_help_callback, xg_make_tool_item):
1328 Use EMACS_INTPTR to hold an integer
1329 that will be cast to void *; this can avoid a GCC warning
1330 if EMACS_INT is not the same width as void *.
1331 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1332 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1333 (current_message_1, set_message_1):
1334 Use a local to convert to proper width without a cast.
1335 * xmenu.c (dialog_selection_callback): Likewise.
1336
ede49d71
PE
1337 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1338 Also, don't assume VALBITS / RAND_BITS is less than 5,
1339 and don't rely on undefined behavior when shifting a 1 left into
1340 the sign bit.
1341 * lisp.h (get_random): Change signature to match.
1342
2f30ecd0
PE
1343 * lread.c (hash_string): Use size_t, not int, for hash computation.
1344 Normally we prefer signed values; but hashing is special, because
1345 it's better to use unsigned division on hash table sizes so that
1346 the remainder is nonnegative. Also, size_t is the natural width
1347 for hashing into memory. The previous code used 'int', which doesn't
1348 retain enough info to hash well into very large tables.
1349 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1350
2a866e7b
PE
1351 * dbusbind.c: Don't possibly lose pointer info when converting.
1352 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1353 Use XPNTR rather than XHASH, so that the high-order bits of
1354 the pointer aren't lost when converting through void *.
1355
51639eac
PE
1356 * eval.c (Fautoload): Don't double-shift a pointer.
1357
92394119
PE
1358 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1359
dbdb9a7c
JB
13602011-05-06 Juanma Barranquero <lekktu@gmail.com>
1361
1362 * gnutls.c (DEF_GNUTLS_FN):
1363 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1364
db7a0b4f
AS
13652011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1366
1367 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1368 marker. (Bug#8610)
1369
f7ff1b0f 13702011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1371
1372 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1373 New version that can reserve upto 2GB of heap space.
1374
f7ff1b0f 13752011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1376
1377 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1378
639c109b
TZ
13792011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1380
1381 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1382 `gnutls_certificate_set_x509_key_file'.
1383
d2127135
JB
13842011-05-05 Juanma Barranquero <lekktu@gmail.com>
1385
1386 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1387 Update dependencies.
1388
e968f4f3
JB
13892011-05-04 Juanma Barranquero <lekktu@gmail.com>
1390
1391 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1392 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1393 Remove unused parameter `fildes'.
1394 * process.c (read_process_output, send_process): Don't pass it.
1395
84d358f0
JB
13962011-05-04 Juanma Barranquero <lekktu@gmail.com>
1397
1398 Fix previous change: the library cache is defined in w32.c.
1399 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1400 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1401
0898ca10
JB
14022011-05-04 Juanma Barranquero <lekktu@gmail.com>
1403
1404 Implement dynamic loading of GnuTLS on Windows.
1405
1406 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1407 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1408 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1409 Declare.
1410
1411 * gnutls.c (Qgnutls_dll): Define.
1412 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1413 (gnutls_*): Declare function pointers.
1414 (init_gnutls_functions): New function to initialize function pointers.
1415 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1416 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1417 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1418 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1419 (emacs_gnutls_write, emacs_gnutls_read)
1420 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1421 (Fgnutls_available_p): New function.
1422 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1423 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1424 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1425
1426 * image.c: Include w32.h.
1427 (Vimage_type_cache): Delete.
1428 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1429 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1430 (w32_delayed_load): Move to w32.c.
1431
1432 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1433
1434 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1435 (w32_delayed_load): Move from image.c. When loading a library, record
1436 its filename in the :loaded-from property of the library id.
1437 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1438 Initialize and staticpro them.
1439 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1440
1441 * process.c: Include lisp.h before w32.h, not after.
1442 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1443 instead of gnutls_record_check_pending.
1444
1445 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1446
ff4de4aa
TZ
14472011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1448
1449 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1450 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1451 as passed in.
1452
abe95abb
JD
14532011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1454
1455 * xterm.c (x_set_frame_alpha): Do not set property on anything
1456 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1457
e16e55d4
JB
14582011-05-02 Juanma Barranquero <lekktu@gmail.com>
1459
1460 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1461
bafcf6a5
JB
14622011-05-02 Juanma Barranquero <lekktu@gmail.com>
1463
1464 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1465 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1466 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1467 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1468 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1469 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1470 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1471 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1472 (Qgnutls_bootprop_callbacks_verify): Make static.
1473
e7a6747f
AS
14742011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1475
19ed11ba
AS
1476 * callproc.c: Indentation fixup.
1477
e7a6747f 1478 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1479 (wait_for_termination, interruptible_wait_for_termination):
1480 Move after wait_for_termination_1.
e7a6747f 1481
1ef14cb4
LMI
14822011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1483
1484 * sysdep.c (interruptible_wait_for_termination): New function
1485 which is like wait_for_termination, but allows keyboard
1486 interruptions.
1487
1488 * callproc.c (Fcall_process): Add (:file "file") as an option for
1489 the STDOUT buffer.
1490 (Fcall_process_region): Ditto.
1491
330d880c
EZ
14922011-04-30 Eli Zaretskii <eliz@gnu.org>
1493
8db90b73
EZ
1494 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1495 rather than `XVECTOR (FOO)->size'.
1496
330d880c
EZ
1497 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1498 inttypes.h, as a gnulib replacement is used if it not available in
1499 system headers.
1500
15cbd324
EZ
15012011-04-21 Eli Zaretskii <eliz@gnu.org>
1502
1503 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1504 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1505 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1506
1507 * coding.c (coding_alloc_by_realloc): Error out if destination
1508 will grow beyond MOST_POSITIVE_FIXNUM.
1509 (decode_coding_emacs_mule): Abort if there isn't enough place in
1510 charbuf for the composition carryover bytes. Reserve an extra
1511 space for up to 2 characters produced in a loop.
1512 (decode_coding_iso_2022): Abort if there isn't enough place in
1513 charbuf for the composition carryover bytes.
1514
15152011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1516
ae940cca
EZ
1517 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1518 aborting when %lld or %lll format is passed.
1519 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1520 %llo or %llx format is passed. (Bug#8545)
1521
03ab8921
EZ
1522 * window.c (window_scroll_line_based): Use a marker instead of
1523 simple variables to record original value of point. (Bug#7952)
1524
afda1437
EZ
1525 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1526 produced by %s or %c overflows available buffer space. (Bug#8545)
1527
f76dee0c
PE
15282011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1529
1530 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1531 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1532
fdc5744d
JB
15332011-04-28 Juanma Barranquero <lekktu@gmail.com>
1534
1535 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1536
638f053a
JB
15372011-04-28 Juanma Barranquero <lekktu@gmail.com>
1538
1539 * keyboard.c (Qdelayed_warnings_hook): Define.
1540 (command_loop_1): Run `delayed-warnings-hook'
1541 if Vdelayed_warnings_list is non-nil.
1542 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1543 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1544
d178f871
EZ
15452011-04-28 Eli Zaretskii <eliz@gnu.org>
1546
1547 * doprnt.c (doprnt): Don't return value smaller than the buffer
1548 size if the message was truncated. (Bug#8545).
1549
b124fd93
JB
15502011-04-28 Juanma Barranquero <lekktu@gmail.com>
1551
1552 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1553 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1554
e810457d
PE
15552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1556
1557 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1558
ea51cceb
JB
15592011-04-27 Juanma Barranquero <lekktu@gmail.com>
1560
1561 * makefile.w32-in: Update dependencies.
1562
94dcfacf
EZ
15632011-04-27 Eli Zaretskii <eliz@gnu.org>
1564
1565 Improve `doprnt' and its usage. (Bug#8545)
1566 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1567 `format_end'. Remove support for %l as a conversion specifier.
1568 Don't use xrealloc. Improve diagnostics when the %l size modifier
1569 is used. Update the commentary.
1570
1571 * eval.c (verror): Simplify calculation of size_t.
1572
1573 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1574 messages.
1575
f61f41d7
PE
15762011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1577
1578 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1579 change.
1580
96fb4434
PE
15812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1582
1583 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1584 This makes this file independent of the recent pseudovector change.
1585
671875da 15862011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1587
69e9b5a3
PE
1588 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1589
b5f869a7 1590 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1591 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1592 Remove unused local.
c8926152 1593 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1594
841a1577 1595 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1596 GCC 4.6.0 optimizes based on type-based alias analysis.
1597 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1598 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1599 != &v->size, and therefore "v->size = 1; b->size = 2; return
1600 v->size;" must therefore return 1. This assumption is incorrect
1601 for Emacs, since it type-puns struct Lisp_Vector * with many other
1602 types. To fix this problem, this patch adds a new type struct
f904488f 1603 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1604 and pseudovectors, and helps optimizing compilers not get fooled
1605 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1606 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1607 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1608 the size member.
eab3844f
PE
1609 (XSETPVECTYPE): Rewrite in terms of new macro.
1610 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1611 This is a bit clearer, and further avoids the possibility of
1612 undesirable aliasing.
1613 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1614 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1615 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1616 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1617 (ASIZE): Now uses header.size rather than size.
1618 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1619 to avoid the hassle of writing XVECTOR (foo)->header.size.
1620 (struct vectorlike_header): New type.
eab3844f
PE
1621 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1622 object, to help avoid aliasing.
1623 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1624 (SUBRP): Likewise, since Lisp_Subr is a special case.
1625 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1626 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1627 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1628 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1629 changed to be "header.size" and "header.next".
1630 * buffer.h (struct buffer): Likewise.
1631 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1632 * frame.h (struct frame): Likewise.
1633 * process.h (struct Lisp_Process): Likewise.
1634 * termhooks.h (struct terminal): Likewise.
1635 * window.c (struct save_window_data, struct saved_window): Likewise.
1636 * window.h (struct window): Likewise.
1637 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1638 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1639 * buffer.c (init_buffer_once): Likewise.
1640 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1641 special case.
1642 * process.c (Fformat_network_address): Use local var for size,
1643 for brevity.
1644
0df1eac5
PE
1645 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1646
847ab9d1 1647 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1648 * data.c (atof): Remove decl; no longer used or needed.
1649 (digit_to_number): Move to lread.c.
1650 (Fstring_to_number): Use new string_to_number function, to be
1651 consistent with how the Lisp reader treats infinities and NaNs.
1652 Do not assume that floating-point numbers represent EMACS_INT
1653 without losing information; this is not true on most 64-bit hosts.
1654 Avoid double-rounding errors, by insisting on integers when
1655 parsing non-base-10 numbers, as the documentation specifies.
1656 * lisp.h (string_to_number): New decl, replacing ...
1657 (isfloat_string): Remove.
bc0a5c13 1658 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1659 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1660 appears to have been a coding error. Similarly, do not accept
1661 strings like +-1e0 as floating point numbers. Do not report
1662 overflow for integer overflows unless the base is not 10 which
1663 means we have no simple and reliable way to continue.
1664 Break out the floating-point parsing into a new
1665 function string_to_number, so that Fstring_to_number parses
1666 floating point numbers consistently with the Lisp reader.
04f2d78b 1667 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1668 (E_CHAR, EXP_INT): Remove, replacing with ...
1669 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1670 (string_to_number): New function, replacing isfloat_string.
1671 This function checks for valid syntax and produces the resulting
1672 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1673 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1674 so that overflow for non-base-10 numbers is reported only when
1675 there's no portable and simple way to convert to floating point.
452f4150 1676
67769ffc
PE
1677 * textprop.c (set_text_properties_1): Rewrite for clarity,
1678 and to avoid GCC warning about integer overflow.
1679
c20db43f
PE
1680 * intervals.h (struct interval): Use EMACS_INT for members
1681 where EMACS_UINT might cause problems. See
1682 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1683 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1684 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1685 All uses changed.
37aa2f85
PE
1686 (offset_intervals): Tell GCC not to worry about length overflow
1687 when negating a negative length.
c20db43f 1688
2538aa2f
PE
1689 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1690 (overrun_check_free): Likewise.
1691
f2d3008d
PE
1692 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1693 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1694 word size.
1695
ec8df744
PE
1696 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1697 (gnutls_make_error): Rename local to avoid shadowing.
1698 (gnutls_emacs_global_deinit): ifdef out; not used.
1699 (Fgnutls_boot): Use const for pointer to readonly storage.
1700 Comment out unused local. Fix pointer signedness problems.
1701
640ee02d
PE
1702 * lread.c (openp): Don't stuff size_t into an 'int'.
1703 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1704 about possible signed overflow.
1705
6048fb2a
PE
1706 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1707 (GDK_KEY_g): Don't define if already defined.
1708 (xg_prepare_tooltip): Avoid pointer signedness problem.
1709 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1710
fa3c87e1
PE
1711 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1712 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1713
2172544b
PE
1714 * xfns.c (Fx_window_property): Simplify a bit,
1715 to make a bit faster and to avoid GCC 4.6.0 warning.
1716 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1717
9b821a21
PE
1718 * fns.c (internal_equal): Don't assume size_t fits in int.
1719
3c616cfa
PE
1720 * alloc.c (compact_small_strings): Tighten assertion a little.
1721
c2982e87
PE
1722 Replace pEd with more-general pI, and fix some printf arg casts.
1723 * lisp.h (pI): New macro, generalizing old pEd macro to other
1724 conversion specifiers. For example, use "...%"pI"d..." rather
1725 than "...%"pEd"...".
1726 (pEd): Remove. All uses replaced with similar uses of pI.
1727 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1728 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1729 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1730 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1731 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1732 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1733 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1734 64-bit hosts.
1735 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1736 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1737 * print.c (safe_debug_print, print_object): Likewise.
1738 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1739 to int.
6f04d126
PE
1740 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1741 avoiding the 0 flag, which is not portable.
c2982e87
PE
1742 * process.c (Fmake_network_process): Use pI to avoid cast.
1743 * region-cache.c (pp_cache): Likewise.
1744 * xdisp.c (decode_mode_spec): Likewise.
1745 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1746 behavior on 64-bit hosts with printf arg.
6f04d126 1747 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1748 (x_stop_queuing_selection_requests): Likewise.
1749 (x_get_window_property): Don't truncate byte count to an 'int'
1750 when tracing.
0b432f21 1751
5e073ec7
PE
1752 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1753 here, since it parses constructs like leading '-' and spaces,
1754 which are not wanted; and it overflows with large numbers.
1755 Instead, simply match F[0-9]+, which is what is wanted anyway.
1756
36372bf9
PE
1757 * alloc.c: Remove unportable assumptions about struct layout.
1758 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1759 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1760 (allocate_vectorlike, make_pure_vector): Use the new macros,
1761 plus offsetof, to remove unportable assumptions about struct layout.
1762 These assumptions hold on all porting targets that I know of, but
1763 they are not guaranteed, they're easy to remove, and removing them
1764 makes further changes easier.
1765
0b432f21
PE
1766 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1767 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1768 (string_overrun_cookie): Now const. Use initializers that
1769 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1770 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1771 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1772 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1773 multiple of sizeof (EMACS_INT); it need not be, if
1774 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1775 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1776
895009e1
JB
17772011-04-26 Juanma Barranquero <lekktu@gmail.com>
1778
1779 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1780
6a7a1b0b
TZ
17812011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1782
1783 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1784 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1785 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1786
841a1577 17872011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1788
1789 * lisp.h (Qdebug): List symbol.
895009e1 1790 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1791 * keyboard.c (debug-on-event): New variable.
1792 (handle_user_signal): Break into debugger when debug-on-event
1793 matches the current signal symbol.
1794
f2d3ba6f
DN
17952011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1796
1797 * alloc.c (check_sblock, check_string_bytes)
1798 (check_string_free_list): Convert to standard C.
1799
42ce4c63
TZ
18002011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1801
1802 * w32.c (emacs_gnutls_push): Fix typo.
1803
825cd63c
EZ
18042011-04-25 Eli Zaretskii <eliz@gnu.org>
1805
fb11d64d
EZ
1806 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1807 "cast to pointer from integer of different size".
1808
825cd63c
EZ
1809 Improve doprnt and its use in verror. (Bug#8545)
1810 * doprnt.c (doprnt): Document the set of format control sequences
1811 supported by the function. Use SAFE_ALLOCA instead of always
1812 using `alloca'.
1813
1814 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1815 is one byte too soon. Don't use xrealloc; instead xfree and
1816 xmalloc anew.
1817
e061a11b
TZ
18182011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1819
1820 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1821 callbacks stage.
1822
1823 * gnutls.c: Renamed global_initialized to
1824 gnutls_global_initialized. Added internals for the
1825 :verify-hostname-error, :verify-error, and :verify-flags
1826 parameters of `gnutls-boot' and documented those parameters in the
1827 docstring. Start callback support.
1828 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1829 unless a fatal error occured. Call gnutls_alert_send_appropriate
1830 on error. Return error code.
1831 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1832 (emacs_gnutls_read): Likewise.
1833 (Fgnutls_boot): Return handshake error code.
1834 (emacs_gnutls_handle_error): New function.
1835 (wsaerror_to_errno): Likewise.
1836
1837 * w32.h (emacs_gnutls_pull): Add prototype.
1838 (emacs_gnutls_push): Likewise.
1839
1840 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1841 (emacs_gnutls_push): Likewise.
1842
18432011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1844
1845 * process.c (wait_reading_process_output): Check if GnuTLS
1846 buffered some data internally if no FDs are set for TLS
1847 connections.
1848
1849 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1850 (LIBS): Link to USER_LIBS.
1851 ($(BLD)/gnutls.$(0)): New target.
1852
fa6996bc
EZ
18532011-04-24 Eli Zaretskii <eliz@gnu.org>
1854
eb35682e
EZ
1855 * xdisp.c (handle_single_display_spec): Rename the
1856 display_replaced_before_p argument into display_replaced_p, to
1857 make it consistent with the commentary. Fix typos in the
1858 commentary.
1859
e2ad650c
EZ
1860 * textprop.c (syms_of_textprop): Remove dead code.
1861 (copy_text_properties): Delete obsolete commentary about an
1862 interface that was deleted long ago. Fix typos in the description
1863 of arguments.
1864
1b2de274
EZ
1865 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1866 to changes in oldXMenu/XMenu.h from 2011-04-16.
1867 <menu_help_message, prev_menu_help_message>: Constify.
1868 (IT_menu_make_room): menu->help_text is now `const char **';
1869 adjust.
1870
1871 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1872 to changes in oldXMenu/XMenu.h from 2011-04-16.
1873 (struct XMenu): Declare `help_text' `const char **'.
1874
1875 * xfaces.c <Qunspecified>: Make extern again.
1876
1877 * syntax.c: Include sys/types.h before including regex.h, as
1878 required by Posix.
1879
762b15be
EZ
1880 * doc.c (get_doc_string): Improve the format passed to `error'.
1881
1882 * doprnt.c (doprnt): Improve commentary.
1883
1884 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1885
1886 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1887 them with etags.
1888
f1052e5d
EZ
1889 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1890 changes in globals.h immediately force recompilation.
762b15be
EZ
1891 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1892 $(CURDIR)/s/ms-w32.h.
1893 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1894
fa6996bc
EZ
1895 * character.c (Fchar_direction): Function deleted.
1896 (syms_of_character): Don't defsubr it.
1897 <char-direction-table>: Deleted.
1898
e6c3da20
EZ
18992011-04-23 Eli Zaretskii <eliz@gnu.org>
1900
1901 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1902 * doprnt.c: Include limits.h.
1903 (SIZE_MAX): New macro.
04f2d78b
CB
1904 (doprnt): Return a size_t value. 2nd arg is now size_t.
1905 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1906 Improve overflow protection. Support `l' modifier for integer
1907 conversions. Support %l conversion. Don't assume an EMACS_INT
1908 argument for integer conversions and for %c.
1909
1910 * lisp.h (doprnt): Restore prototype.
1911
1912 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1913 $(SRC)/character.h.
1914
1915 * Makefile.in (base_obj): Add back doprnt.o.
1916
1917 * deps.mk (doprnt.o): Add back prerequisites.
1918 (callint.o): Depend on character.h.
1919
1920 * eval.c (internal_lisp_condition_case): Include the handler
1921 representation in the error message.
1922 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1923 when breaking from the loop.
1924
1925 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1926
1927 * callint.c (Fcall_interactively): When displaying error message
1928 about invalid control letter, pass the character's codepoint, not
1929 a pointer to its multibyte form. Improve display of the character
1930 in octal and display also its hex code.
1931
1932 * character.c (char_string): Use %x to display the (unsigned)
1933 codepoint of an invalid character, to avoid displaying a bogus
1934 negative value.
1935
1936 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1937 `error', not SYMBOL_NAME itself.
1938
1939 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1940 character arguments to `error'.
1941
1942 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1943 to `error' in error message about FINAL_CHAR argument. Make sure
1944 FINAL_CHAR is a character, and use %c when it is passed as
1945 argument to `error'.
1946
4ffd0d6b 19472011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1948
1949 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1950
1951 * w32.c: Include <time.h>.
1952 (sys_localtime): New function.
1953
4ffd0d6b 19542011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1955
1956 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1957
4ffd0d6b 1958 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1959
4ffd0d6b 19602011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1961
4ffd0d6b
GM
1962 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1963 zombies (Bug#8467).
aac0c6e3 1964
04c56954
EZ
19652011-04-19 Eli Zaretskii <eliz@gnu.org>
1966
1967 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1968 gl_state.e_property when gl_state.object is Qt.
1969
1970 * insdel.c (make_gap_larger): Remove limitation of buffer size
1971 to <= INT_MAX.
1972
16a43933
CY
19732011-04-18 Chong Yidong <cyd@stupidchicken.com>
1974
1975 * xdisp.c (lookup_glyphless_char_display)
1976 (produce_glyphless_glyph): Handle cons cell entry in
1977 glyphless-char-display.
1978 (Vglyphless_char_display): Document it.
1979
1980 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1981 glyphless-char-display.
1982
4581706e
CY
19832011-04-17 Chong Yidong <cyd@stupidchicken.com>
1984
1985 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1986
1987 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1988
1989 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1990 definition for no-X builds.
1991
4887c6e2 19922011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1993
fd35b6f9
PE
1994 Static checks with GCC 4.6.0 and non-default toolkits.
1995
5c1ccb01
PE
1996 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1997
006c5daa
PE
1998 * process.c (keyboard_bit_set): Define only if SIGIO.
1999 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2000 (send_process): Repair possible setjmp clobbering.
2001
efc736d3
PE
2002 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2003
4e2fe2e6
PE
2004 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2005
f97334a2
PE
2006 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2007
4e75f29d
PE
2008 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2009 Define only if needed.
2010
90efadd1
PE
2011 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2012 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2013 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2014
3c647824
PE
2015 * dispextern.h (struct redisplay_interface): Rename param
2016 to avoid shadowing.
e264f262 2017 * termhooks.h (struct terminal): Likewise.
761383f4 2018 * xterm.c (xembed_send_message): Likewise.
3c647824 2019
b58c5c4a
PE
2020 * insdel.c (make_gap_smaller): Define only if
2021 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2022
cad59032
PE
2023 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2024 it.
2025
c339dc2e
PE
2026 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2027 so that we aren't warned about unused symbols.
2028
91a3e27b
PE
2029 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2030
399c71d3 2031 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2032
8ffc96f5
PE
2033 * xfns.c (x_real_positions): Mark locals as initialized.
2034
eef9bc79
PE
2035 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2036
098db9dd
PE
2037 * xterm.c: Fix problems found by static analysis with other toolkits.
2038 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2039 (x_dispatch_event): Declare static if USE_GTK, and
2040 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2041 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2042 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2043 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2044 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2045
eb18f6cc
PE
2046 * xmenu.c (menu_help_callback): Pointer type fixes.
2047 Use const pointers when pointing at readonly data. Avoid pointer
2048 signedness clashes.
2049 (FALSE): Remove unused macro.
2050 (update_frame_menubar): Remove unused decl.
2051
1fe72bf8
PE
2052 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2053
60d9e1db
PE
2054 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2055 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2056 (single_menu_item): Rename local to avoid shadowing.
2057
39261c26
PE
2058 * keyboard.c (make_lispy_event): Remove unused local var.
2059
018c5e19
PE
2060 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2061 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2062
63d2b86e
PE
2063 * bitmaps: Change bitmaps from unsigned char back to the X11
2064 compatible char. Avoid the old compiler warnings about
2065 out-of-range initializers by using, for example, '\xab' rather
2066 than 0xab.
2067
aefd87e1
PE
2068 * xgselect.c (xgselect_initialize): Check vs interface
2069 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2070
bf501fb9
PE
2071 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2072
e9829fdf
PE
2073 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2074 to read-only memory.
2075
1086c095
PE
2076 * fns.c (vector): Remove; this old hack is no longer needed.
2077
2baccd04 2078 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2079 Remove unused var.
dde42981 2080 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2081
72391843 2082 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2083
436c16df 2084 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2085 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2086 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2087
92bb796d 2088 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2089 (x_term_init): Remove local to avoid shadowing.
92bb796d 2090
764430a3 2091 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2092
2093 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2094 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2095
d1dfb56c
EZ
20962011-04-16 Eli Zaretskii <eliz@gnu.org>
2097
c4354cb4
EZ
2098 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2099
d1dfb56c
EZ
2100 Fix regex.c, syntax.c and friends for buffers > 2GB.
2101 * syntax.h (struct gl_state_s): Declare character position members
2102 EMACS_INT.
2103
2104 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2105
04f2d78b
CB
2106 * textprop.c (verify_interval_modification, interval_of):
2107 Declare arguments EMACS_INT.
d1dfb56c
EZ
2108
2109 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2110 EMACS_INT.
2111
2112 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2113
2114 * indent.c (Fvertical_motion): Local variable it_start is now
2115 EMACS_INT.
2116
2117 * regex.c (re_match, re_match_2, re_match_2_internal)
2118 (bcmp_translate, regcomp, regexec, print_double_string)
2119 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2120 (re_compile_pattern, re_exec): Declare arguments and local
2121 variables `size_t' and `ssize_t' and return values `regoff_t', as
2122 appropriate.
2123 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2124 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2125 <compile_stack_type>: `size' and `avail' are now `size_t'.
2126
2127 * regex.h <regoff_t>: Use ssize_t, not int.
2128 (re_search, re_search_2, re_match, re_match_2): Arguments that
2129 specify buffer/string position and length are now ssize_t and
2130 size_t. Return type is regoff_t.
2131
613052cd
BK
21322011-04-16 Ben Key <bkey76@gmail.com>
2133
2134 * nsfont.m: Fixed bugs in ns_get_family and
2135 ns_descriptor_to_entity that were caused by using free to
2136 deallocate memory blocks that were allocated by xmalloc (via
2137 xstrdup). This caused Emacs to crash when compiled with
2138 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2139 --enable-checking=xmallocoverrun). xfree is now used to
2140 deallocate these memory blocks.
2141
4170f62f 21422011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2143
71b41406
PE
2144 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2145
9587a89d
PE
2146 emacs_write: Accept and return EMACS_INT for sizes.
2147 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2148 et seq.
2149 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2150 Accept and return EMACS_INT.
2151 (emacs_gnutls_write): Return the number of bytes written on
2152 partial writes.
2153 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2154 (emacs_read, emacs_write): Remove check for negative size, as the
2155 Emacs source code has been audited now.
9587a89d
PE
2156 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2157 (emacs_read, emacs_write): Use it.
273a5f82
PE
2158 * process.c (send_process): Adjust to the new signatures of
2159 emacs_write and emacs_gnutls_write. Do not attempt to store
2160 a byte offset into an 'int'; it might overflow.
9587a89d 2161 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2162
3e047f51
PE
2163 * sound.c: Don't assume sizes fit in 'int'.
2164 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2165 Return EMACS_INT, not int.
3e047f51 2166 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2167 Accept EMACS_INT, not int.
2168 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2169 record read return values.
2170
cc39a9db
BK
21712011-04-15 Ben Key <bkey76@gmail.com>
2172
c9d0ec6d
JB
2173 * keyboard.c (Qundefined): Don't declare static since it is used
2174 in nsfns.m.
2175 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2176 static since they are used in nsfont.m.
cc39a9db 2177
6c60eb9f
SM
21782011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2179
2180 * process.c (Qprocessp): Don't declare static.
2181 * lisp.h (Qprocessp): Declare again.
2182
7990b61a
JB
21832011-04-15 Juanma Barranquero <lekktu@gmail.com>
2184
2185 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2186
5d4cb038
PE
21872011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2188
8bd7b830 2189 Improve C-level modularity by making more things 'static'.
cd64ea1d 2190
e3b27b31
PE
2191 Don't publish debugger-only interfaces to other modules.
2192 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2193 (verify_bytepos, count_markers): Move decls to the only modules
2194 that need them.
2195 * region-cache.h (pp_cache): Likewise.
2196 * window.h (check_all_windows): Likewise.
2197 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2198
5d4cb038
PE
2199 * sysdep.c (croak): Now static, if
2200 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2201 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2202
2203 * alloc.c (refill_memory_reserve): Now static if
2204 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2205 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2206
e87b6180
PE
2207 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2208 Define only if USE_LUCID.
2209
ac64929e
PE
2210 * xrdb.c (x_customization_string, x_rm_string): Now static.
2211
6f37259d
PE
2212 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2213 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2214
1683e3ab
PE
2215 * xdisp.c (draw_row_with_mouse_face): Now static.
2216 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2217
de9c2632
PE
2218 * window.h (check_all_windows): Mark externally visible.
2219
2b96acb7
PE
2220 * window.c (window_deletion_count): Now static.
2221
2222 * undo.c: Make symbols static if they're not exported.
2223 (last_undo_buffer, last_boundary_position, pending_boundary):
2224 Now static.
2225
50436f33
PE
2226 * textprop.c (interval_insert_behind_hooks): Now static.
2227 (interval_insert_in_front_hooks): Likewise.
2228
64520e5c
PE
2229 * term.c: Make symbols static if they're not exported.
2230 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2231 (max_frame_lines, tty_set_terminal_modes):
2232 (tty_reset_terminal_modes, tty_turn_off_highlight):
2233 (get_tty_terminal): Now static.
2234 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2235 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2236 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2237 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2238 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2239
1fa53021
PE
2240 * sysdep.c: Make symbols static if they're not exported.
2241 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2242 Now static.
2243 (sigprocmask_set, full_mask): Remove; unused.
2244 (wait_debugging): Mark as visible.
2245 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2246 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2247
d4b43b22
PE
2248 * syntax.c (syntax_temp): Define only if !__GNUC__.
2249
b7c513d0
PE
2250 * sound.c (current_sound_device, current_sound): Now static.
2251
989b29ad
PE
2252 * search.c (searchbufs, searchbuf_head): Now static.
2253
13a55a78
PE
2254 * scroll.c (scroll_cost): Remove; unused.
2255 * dispextern.h (scroll_cost): Remove decl.
2256
de68a1fc
PE
2257 * region-cache.h (pp_cache): Mark as externally visible.
2258
40ccffa6
PE
2259 * process.c: Make symbols static if they're not exported.
2260 (process_tick, update_tick, create_process, chan_process):
2261 (Vprocess_alist, proc_buffered_char, datagram_access):
2262 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2263 (deactivate_process): Mark defn as static, as well as decl.
2264 * lisp.h (create_process): Remove decl.
2265 * process.h (chan_process, Vprocess_alist): Remove decls.
2266
ad64fc97
PE
2267 * print.c: Make symbols static if they're not exported.
2268 (print_depth, new_backquote_output, being_printed, print_buffer):
2269 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2270 (print_interval, print_number_index, initial_stderr_stream):
2271 Now static.
2272 * lisp.h (Fprinc): Remove decl.
2273 (debug_output_compilation_hack): Mark as externally visible.
2274
adddb265
PE
2275 * sysdep.c (croak): Move decl from here to syssignal.h.
2276 * syssignal.h (croak): Put it here, so the API can be checked when
2277 'croak' is called from dissociate_if_controlling_tty.
2278
1717ede2
PE
2279 * minibuf.c: Make symbols static if they're not exported.
2280 (minibuf_save_list, choose_minibuf_frame): Now static.
2281 * lisp.h (choose_minibuf_frame): Remove decl.
2282
fa5fb2bc
PE
2283 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2284
1e3890d1
PE
2285 * lread.c: Make symbols static if they're not exported.
2286 (read_objects, initial_obarray, oblookup_last_bucket_number):
2287 Now static.
2288 (make_symbol): Remove; unused.
2289 * lisp.h (initial_obarray, make_symbol): Remove decls.
2290
8a1414fa
PE
2291 * keyboard.c: Make symbols static if they're not exported.
2292 (single_kboard, recent_keys_index, total_keys, recent_keys):
2293 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2294 (this_single_command_key_start, echoing, last_auto_save):
2295 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2296 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2297 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2298 (Vlispy_mouse_stem, double_click_count):
2299 Now static.
2300 (force_auto_save_soon): Define only if SIGDANGER.
2301 (ignore_mouse_drag_p): Now static if
2302 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2303 (print_help): Remove; unused.
2304 (stop_character, last_timer_event): Mark as externally visible.
2305 * keyboard.h (ignore_mouse_drag_p): Declare only if
2306 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2307 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2308 * lisp.h (echoing): Remove decl.
2309 (force_auto_save_soon): Declare only if SIGDANGER.
2310 * xdisp.c (redisplay_window): Simplify code, to make it more
2311 obvious that ignore_mouse_drag_p is not accessed if !defined
2312 USE_GTK && !defined HAVE_NS.
2313
93ea6e8f
PE
2314 * intervals.c: Make symbols static if they're not exported.
2315 (merge_properties_sticky, merge_interval_right, delete_interval):
2316 Now static.
2317 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2318
77382fcc
PE
2319 * insdel.c: Make symbols static if they're not exported.
2320 However, leave prepare_to_modify_buffer alone. It's never
2321 called from outside this function, but that appears to be a bug.
2322 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2323 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2324 (adjust_after_replace_noundo): Remove; unused.
2325 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2326 (signal_before_change): Remove decls.
77382fcc 2327
9306c32e
PE
2328 * indent.c (val_compute_motion, val_vmotion): Now static.
2329
cd44d2eb
PE
2330 * image.c: Make symbols static if they're not exported.
2331 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2332 if USE_GTK.
2333 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2334 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2335
ad9a7a06
PE
2336 * fringe.c (standard_bitmaps): Now static.
2337 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2338
81626931
PE
2339 * frame.c: Make symbols static if they're not exported.
2340 (x_report_frame_params, make_terminal_frame): Now static.
2341 (get_frame_param): Now static, unless HAVE_NS.
2342 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2343 (x_get_resource_string): Remove; not used.
2344 * frame.h (make_terminal_frame, x_report_frame_params):
2345 (x_get_resource_string); Remove decls.
2346 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2347 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2348
239f9db9
PE
2349 * font.c, fontset.c: Make symbols static if they're not exported.
2350 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2351 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2352 * font.c (font_close_object): Now static.
2353 * font.h (font_close_object): Remove.
2354 * fontset.c (FONTSET_OBJLIST): Remove.
2355 (free_realized_fontset) #if-0 the body, which does nothing.
2356 (face_suitable_for_char_p): #if-0, as it's never called.
2357 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2358 * xfaces.c (face_at_string_position):
2359 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2360 since 0 is always ASCII.
2361
dfcf3579
PE
2362 * fns.c (weak_hash_tables): Now static.
2363
5045092b
PE
2364 * fileio.c: Make symbols static if they're not exported.
2365 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2366 (Vwrite_region_annotation_buffers): Now static.
2367
57a96f5c
PE
2368 * eval.c: Make symbols static if they're not exported.
2369 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2370 * lisp.h (backtrace_list): Remove decl.
2371
35f08c38
PE
2372 * emacs.c: Make symbols static if they're not exported.
2373 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2374 (fatal_error_code, fatal_error_signal_hook, standard_args):
2375 Now static.
2376 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2377 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2378 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2379 * lisp.h (fatal_error_signal_hook): Remove decl.
2380 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2381
f44bd759
PE
2382 * editfns.c: Move a (normally-unused) function to its only use.
2383 * editfns.c, lisp.h (get_operating_system_release): Remove.
2384 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2385 worth the hassle of breaking this out.
2386
b532497d
PE
2387 * xterm.c: Make symbols static if they're not exported.
2388 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2389 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2390 (x_destroy_window, x_delete_display):
2391 Now static.
2392 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2393 (x_mouse_leave): Remove; unused.
2394 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2395 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2396 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2397 Remove decls.
2398 (x_mouse_leave): Declare only if WINDOWSNT.
2399 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2400 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2401 USE_X_TOOLKIT.
2402
1675728f
PE
2403 * ftxfont.c: Make symbols static if they're not exported.
2404 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2405 HAVE_FREETYPE.
2406 * font.h (ftxfont_driver): Likewise.
2407
e4cebfca
PE
2408 * xfns.c: Make symbols static if they're not exported.
2409 (x_last_font_name, x_display_info_for_name):
2410 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2411 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2412 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2413 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2414 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2415 (last_show_tip_args): Now static.
2416 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2417 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2418 (x_screen_planes): Remove; unused.
2419 * dispextern.h (x_screen_planes): Remove decl.
2420
5bf46f05
PE
2421 * dispnew.c: Make symbols static if they're not exported.
2422 * dispextern.h (redraw_garbaged_frames, scrolling):
2423 (increment_row_positions): Remove.
2424 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2425 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2426 Now static.
2427 (redraw_garbaged_frames): Remove; unused.
2428
435f4c28
PE
2429 * xfaces.c: Make symbols static if they're not exported.
2430 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2431 Remove decls.
2432 * xterm.h (defined_color): Remove decls.
2433 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2434 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2435 (menu_face_changed_default, defined_color, free_realized_face):
2436 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2437 (ascii_face_of_lisp_face): Remove; unused.
2438
8524aef3
PE
2439 * xdisp.c: Make symbols static if they're not exported.
2440 * dispextern.h (scratch_glyph_row, window_box_edges):
2441 (glyph_to_pixel_coords, set_cursor_from_row):
2442 (get_next_display_element, set_iterator_to_next):
2443 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2444 (show_mouse_face): Remove decls
2445 * frame.h (message_buf_print): Likewise.
2446 * lisp.h (pop_message, set_message, check_point_in_composition):
2447 Likewise.
2448 * xterm.h (set_vertical_scroll_bar): Likewise.
2449 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2450 (message_buf_print, scratch_glyph_row, displayed_buffer):
2451 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2452 (get_next_display_element, show_mouse_face, window_box_edges):
2453 (frame_to_window_pixel_xy, check_point_in_composition):
2454 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2455 (glyph_to_pixel_coords): Remove; unused.
2456
16390cd2
PE
2457 * dired.c (file_name_completion): Now static.
2458
2459 * dbusbind.c (xd_in_read_queued_messages): Now static.
2460
a25f4dfa
PE
2461 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2462 * data.c (circular_list_error): Remove.
2463
14a9c8df
PE
2464 * commands.h (last_point_position, last_point_position_buffer):
2465 (last_point_position_window): Remove decls.
2466 * keyboard.c: Make these variables static.
2467
04f2d78b
CB
2468 * coding.h (coding, code_convert_region, encode_coding_gap):
2469 Remove decls.
74ab6df5
PE
2470 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2471 (iso_code_class, detect_coding, code_convert_region): Now static.
2472 (encode_coding_gap): Remove; unused.
2473
38dfbee1
PE
2474 * chartab.c (chartab_chars, chartab_bits): Now static.
2475
a2cb4e63
PE
2476 * charset.h (charset_iso_8859_1): Remove decl.
2477 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2478 Now static.
2479
127198fd
PE
2480 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2481 * ccl.c (Vccl_program_table): Now static.
2482 (check_ccl_update): Remove; unused.
2483
d85b608f
PE
2484 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2485 * category.h: ... from here.
2486 * category.c (check_category_table, set_category_set): Now static.
2487
31cd66f3
PE
2488 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2489 * lisp.h: Remove these decls.
2490
c358e587
PE
2491 * buffer.c (buffer_count): Remove unused var.
2492
e78aecca
PE
2493 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2494 so that it's not optimized away.
2495 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2496 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2497 exported only to the debugger.
2498
e192d7d3 2499 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2500 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2501
92470028
PE
2502 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2503 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2504 was inaccessible from Lisp.
2505 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2506 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2507
244ed907
PE
2508 alloc.c: Import and export fewer symbols, and remove unused items.
2509 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2510 is defined.
2511 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2512 it's not optimized away by whole-program optimization.
2513 (message_enable_multibyte, free_misc): Remove.
2514 (catchlist, handlerlist, mark_backtrace):
2515 Declare only if BYTE_MARK_STACK.
2516 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2517 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2518 (message_enable_multibyte): Remove decl.
2519 (free_misc, interval_free_list, float_block, float_block_index):
2520 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2521 (cons_free_list, last_marked_index):
2522 Now static.
2523 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2524 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2525 (mark_backtrace): Define only if BYTE_MARK_STACK.
2526 * xdisp.c (message_enable_multibyte): Now static.
2527
61c2b50e 2528 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2529 This makes it easier for human readers (and static analyzers)
2530 to see whether these variables are used from other modules.
2531 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2532 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2533 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2534 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2535 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2536 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2537 * xmenu.c, xselect.c:
2538 Declare Q* vars static if they are not used in other modules.
2539 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2540 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2541 Remove decls of unexported vars.
2542 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2543
95c82688
PE
2544 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2545
16a97296
PE
2546 Make Emacs functions such as Fatom 'static' by default.
2547 This makes it easier for human readers (and static analyzers)
2548 to see whether these functions can be called from other modules.
2549 DEFUN now defines a static function. To make the function external
2550 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2551 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2552 (Finit_image_library):
16a97296
PE
2553 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2554 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2555 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2556 Remove decls, since these functions are now static.
2557 (Funintern, Fget_internal_run_time): New decls, since these functions
2558 were already external.
95c82688 2559
16a97296
PE
2560 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2561 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2562 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2563 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2564 * keyboard.c, keymap.c, lread.c:
2565 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2566 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2567 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2568 Mark functions with DEFUE instead of DEFUN,
2569 if they are used in other modules.
2570 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2571 decls for now-static functions.
2572 * buffer.h (Fdelete_overlay): Remove decl.
2573 * callproc.c (Fgetenv_internal): Mark as internal.
2574 * composite.c (Fremove_list_of_text_properties): Remove decl.
2575 (Fcomposition_get_gstring): New forward static decl.
2576 * composite.h (Fcomposite_get_gstring): Remove decl.
2577 * dired.c (Ffile_attributes): New forward static decl.
2578 * doc.c (Fdocumntation_property): New forward static decl.
2579 * eval.c (Ffetch_bytecode): New forward static decl.
2580 (Funintern): Remove extern decl; now in .h file where it belongs.
2581 * fileio.c (Fmake_symbolic_link): New forward static decl.
2582 * image.c (Finit_image_library): New forward static decl.
2583 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2584 * intervals.h (Fprevious_property_change):
2585 (Fremove_list_of_text_properties): Remove decls.
2586 * keyboard.c (Fthis_command_keys): Remove decl.
2587 (Fcommand_execute): New forward static decl.
2588 * keymap.c (Flookup_key): New forward static decl.
2589 (Fcopy_keymap): Now static.
2590 * keymap.h (Flookup_key): Remove decl.
2591 * process.c (Fget_process): New forward static decl.
2592 (Fprocess_datagram_address): Mark as internal.
2593 * syntax.c (Fsyntax_table_p): New forward static decl.
2594 (skip_chars): Remove duplicate decl.
2595 * textprop.c (Fprevious_property_change): New forward static decl.
2596 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2597 Now internal.
2598 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2599 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2600
785bbd42
PE
2601 * editfns.c (Fformat): Remove unreachable code.
2602
8b913b57
AS
26032011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2604
2605 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2606 change. (Bug#8496)
2607
a6744a35
EZ
26082011-04-13 Eli Zaretskii <eliz@gnu.org>
2609
2610 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2611 when at ZV. (Bug#8487)
2612
e7974947
AS
26132011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2614
baad03f0
AS
2615 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2616 (Bug#8437)
2617 * keyboard.c (parse_tool_bar_item): Likewise.
2618 * sound.c (sound_cleanup, alsa_close): Likewise.
2619 * termcap.c (tgetent): Likewise.
2620 * xfns.c (x_default_font_parameter): Likewise.
2621 * xsettings.c (read_and_apply_settings): Likewise.
2622
e7974947
AS
2623 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2624 (overrun_check_free): Protoize.
2625
28272684
PE
26262011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2627
2628 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2629 since callers should never pass a negative size.
2630 Change the signature to match that of plain 'read' and 'write'; see
2631 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2632 * lisp.h: Update prototypes of emacs_write and emacs_read.
2633
11997c76
EZ
26342011-04-11 Eli Zaretskii <eliz@gnu.org>
2635
2636 * xdisp.c (redisplay_window): Don't try to determine the character
2637 position of the scroll margin if the window start point w->startp
e896f03c 2638 is outside the buffer's accessible region. (Bug#8468)
11997c76 2639
8a2cbd72
EZ
26402011-04-10 Eli Zaretskii <eliz@gnu.org>
2641
2642 Fix write-region and its subroutines for buffers > 2GB.
2643 * fileio.c (a_write, e_write): Modify declaration of arguments and
2644 local variables to support buffers larger than 2GB.
2645 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2646
2647 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2648 argument, local variables, and return value.
2649
2650 * lisp.h: Update prototypes of emacs_write and emacs_read.
2651
2652 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2653
4073e537 26542011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2655
1ebfdcb6
PE
2656 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2657
b2ded58d
PE
2658 Fix more problems found by GCC 4.6.0's static checks.
2659
7d66342c
PE
2660 * xdisp.c (vmessage): Use a better test for character truncation.
2661
bbf47d44
PE
2662 * charset.c (load_charset_map): <, not <=, for optimization,
2663 and to avoid potential problems with integer overflow.
9248994d 2664 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2665 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2666 * editfns.c (Fformat): Likewise.
1e69125e 2667 * syntax.c (skip_chars): Likewise.
3befa583 2668
e3019616
PE
2669 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2670 This also lets GCC 4.6.0 generate slightly better loop code.
2671
becfa255
PE
2672 * callint.c (Fcall_interactively): <, not <=, for optimization.
2673 (Fcall_interactively): Count the number of arguments produced,
2674 not the number of arguments given. This is simpler and lets GCC
2675 4.6.0 generate slightly better code.
2676
dae0cd48
PE
2677 * ftfont.c: Distingish more carefully between FcChar8 and char.
2678 The previous code passed unsigned char * to a functions like
2679 strlen and xstrcasecmp that expect char *, which does not
2680 conform to the C standard.
2681 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2682 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2683 char * when the C standard requires it.
2684
76032d70
PE
2685 * keyboard.c (read_char): Remove unused var.
2686
eb3f1cc8
PE
2687 * eval.c: Port to Windows vsnprintf (Bug#8435).
2688 Include <limits.h>.
2689 (SIZE_MAX): Define if the headers do not.
2690 (verror): Do not give up if vsnprintf returns a negative count.
2691 Instead, grow the buffer. This ports to Windows vsnprintf, which
2692 does not conform to C99. Problem reported by Eli Zaretskii.
2693 Also, simplify the allocation scheme, by avoiding the need for
2694 calling realloc, and removing the ALLOCATED variable.
2695
70476b54
PE
2696 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2697
12020a9e
PE
2698 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2699 But keep the doprint source code for now, as we might revamp it
2700 and use it again (Bug#8435).
ea6c7ae6
PE
2701 * lisp.h (doprnt): Remove.
2702 * Makefile.in (base_obj): Remove doprnt.o.
2703 * deps.mk (doprnt.o): Remove.
2704
5fdb398c
PE
2705 error: Print 32- and 64-bit integers portably (Bug#8435).
2706 Without this change, on typical 64-bit hosts error ("...%d...", N)
2707 was used to print both 32- and 64-bit integers N, which relied on
2708 undefined behavior.
2709 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2710 New macro.
2711 * lisp.h (error, verror): Mark as printf-like functions.
2712 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2713 Report overflow in size calculations when allocating printf buffer.
2714 Do not truncate output string at its first null byte.
2715 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2716 Truncate the output at a character boundary, since vsnprintf does not
2717 do that.
2718 * charset.c (check_iso_charset_parameter): Convert internal
2719 character to string before calling 'error', since %c now has the
2720 printf meaning.
2721 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2722 overflow when computing char to be passed to 'error'. Do not
2723 pass Lisp_Object to 'error'; pass the integer instead.
2724 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2725 formatted with plain %d.
2726
b189fa66
PE
2727 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2728
bff87ef0
PE
2729 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2730
7e2cac20
PE
2731 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2732
ce4d90b5
PE
2733 * xterm.c (x_catch_errors): Remove duplicate declaration.
2734
266c9547
PE
2735 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2736
79c49ad2
PE
2737 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2738
368f4090
JM
27392011-04-10 Jim Meyering <meyering@redhat.com>
2740
2741 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2742 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2743 return ssize_t not "int", and use size_t as the buffer length.
2744 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2745 * gnutls.h: Update declarations.
2746 * process.c (read_process_output): Use ssize_t, to match.
2747 (send_process): Likewise.
2748
a32d4040
CY
27492011-04-09 Chong Yidong <cyd@stupidchicken.com>
2750
2751 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2752
8546720e 27532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2754
04f2d78b
CB
2755 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2756 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2757
8546720e
GM
2758 * xterm.c (handle_one_xevent):
2759 * xmenu.c (create_and_show_popup_menu):
2760 * xselect.c (x_decline_selection_request)
2761 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2762
0a2f5c1a 27632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2764
2765 Fix some uses of `int' instead of EMACS_INT.
2766 * search.c (string_match_1, fast_string_match)
2767 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2768 (scan_buffer, find_next_newline_no_quit)
2769 (find_before_next_newline, search_command, Freplace_match)
2770 (Fmatch_data): Make some `int' variables be EMACS_INT.
2771
2772 * xdisp.c (display_count_lines): 3rd argument and return value now
2773 EMACS_INT. All callers changed.
2774 (pint2hrstr): Last argument is now EMACS_INT.
2775
2776 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2777 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2778 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2779 (decode_coding_utf_16, decode_coding_emacs_mule)
2780 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2781 (decode_coding_ccl, decode_coding_charset)
2782 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2783 (decode_coding_iso_2022, decode_coding_emacs_mule)
2784 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2785 <char_offset, last_offset>: Declare EMACS_INT.
2786 (encode_coding_utf_8, encode_coding_utf_16)
2787 (encode_coding_emacs_mule, encode_invocation_designation)
2788 (encode_designation_at_bol, encode_coding_iso_2022)
2789 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2790 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2791 Declare EMACS_INT.
2792 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2793 (encode_invocation_designation): Last argument P_NCHARS is now
2794 EMACS_INT.
2795 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2796 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2797
2798 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2799 All users changed.
2800
2801 * ccl.c (Fccl_execute_on_string): Declare some variables
2802 EMACS_INT.
2803
8546720e 28042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2805
2806 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2807
4e19a977
CS
28082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2809
2810 * process.c (Fformat_network_address): Doc fix.
2811
87302331
R
28122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2813
2814 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2815
cbb59342
CY
28162011-04-08 Chong Yidong <cyd@stupidchicken.com>
2817
2818 * keyboard.c (read_char): Call Lisp function help-form-show,
2819 instead of using internal_with_output_to_temp_buffer.
2820 (Qhelp_form_show): New var.
e0d38eeb 2821 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2822
2823 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2824
2825 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2826
e67a13ab
CY
28272011-04-06 Chong Yidong <cyd@stupidchicken.com>
2828
04f2d78b
CB
2829 * process.c (Flist_processes): Remove to Lisp.
2830 (list_processes_1): Delete.
e67a13ab 2831
973f782d
EZ
28322011-04-06 Eli Zaretskii <eliz@gnu.org>
2833
7c106b1e
EZ
2834 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2835
973f782d
EZ
2836 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2837
41cf7d1a 28382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2839
ca23cc88
PE
2840 Fix more problems found by GCC 4.6.0's static checks.
2841
f390e2d5
PE
2842 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2843
42eea0d0
PE
2844 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2845
b69769da 2846 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2847
f9541e84
PE
2848 * xdisp.c (vmessage): Mark as a printf-like function.
2849
13841b55
PE
2850 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2851
c136c10f
PE
2852 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2853
5e2d4a30
PE
2854 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2855 printf-like functions.
2856 (tiff_load): Add casts to remove these marks before passing them
2857 to system-supplied API.
2858
583f48b9
PE
2859 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2860
b25d760e
PE
2861 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2862 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2863 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2864 directly, rather than having caller test rule sign. This avoids
2865 some unnecessary tests.
2866 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2867 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2868 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2869
bc7b6697 2870 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2871 (xfont_open): Avoid unnecessary tests.
bc7b6697 2872
27ccc379
PE
2873 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2874
dcd5c89a
PE
2875 * composite.h, composite.c (composition_gstring_put_cache):
2876 Use EMACS_INT, not int, for length.
2877
b13a45c6
PE
2878 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2879 breaking out part of COMPOSITION_DECODE_RULE.
2880 (COMPOSITION_DECODE_RULE): Use it.
2881 * composite.c (get_composition_id): Remove unused local vars,
2882 by using the new macro.
2883
1e792e4d
PE
2884 * textprop.c (set_text_properties_1): Change while to do-while,
2885 since the condition is always true at first.
2886
dc6c6455 2887 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2888 (interval_deletion_adjustment): Return unsigned value.
2889 All uses changed.
dc6c6455 2890
aba7731a
PE
2891 * process.c (list_processes_1, create_pty, read_process_output):
2892 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2893 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2894 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2895 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2896 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2897
fdfc4bf3
PE
2898 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2899
fca8fe46 2900 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2901 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2902
06a0259a 2903 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2904 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2905 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2906
e7b9e80f
PE
2907 * print.c (print_error_message): Avoid int overflow.
2908
56201685
PE
2909 * font.c (font_list_entities): Redo for clarity,
2910 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2911
78834453 2912 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2913 (font_score): Avoid potential overflow in diff calculation.
78834453 2914
0bc0b309 2915 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2916 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2917
e610eaca
PE
2918 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2919
b895abce
PE
2920 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2921 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2922 can always succeed if overflow has undefined behavior.
2923
1f1d9321 2924 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2925 (wordify): Omit three unnecessary tests.
1f1d9321 2926
c59478bc
PE
2927 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2928 All callers changed. This avoids the need for an unused var.
2929
79b73827
PE
2930 * casefiddle.c (casify_region): Remove var that is set but not used.
2931
a4db5dfe
PE
2932 * dired.c (file_name_completion): Remove var that is set but not used.
2933
43aae36e
PE
2934 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2935
2a47c44d 2936 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2937 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2938
a37c69bf
PE
2939 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2940 Check for integer overflow on size calculations.
2941
328ab8e7
PE
2942 * buffer.c (Fprevious_overlay_change): Remove var that is set
2943 but not used.
2944
e5a2a5cb
PE
2945 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2946 Remove vars that are set but not used.
8d84a6eb 2947 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2948 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2949
a60e5f68
PE
2950 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2951
f661cb61 2952 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2953 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2954
f0397f5a
PE
2955 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2956 that are set but not used.
2957
8664db06 2958 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2959 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2960
6abdaa4a
PE
2961 * xselect.c (x_get_local_selection, x_handle_property_notify):
2962 Remove vars that are set but not used.
2963
0ce7538d 2964 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2965 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2966
9ae848fc
PE
2967 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2968 Remove var that is set but not used.
0b918413
PE
2969 (scroll_bar_windows_size): Now size_t, not int.
2970 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2971 Check for overflow.
9ae848fc 2972
a5a62657
PE
2973 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2974 (map_tty_color) [!defined MSDOS]: Likewise.
2975
5c5cdd39
PE
2976 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2977
66ebf983
PE
2978 * coding.c: Remove vars that are set but not used.
2979 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2980 All callers changed.
2981 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2982 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2983 (decode_coding_charset): Remove vars that are set but not used.
2984
1be4d761
PE
2985 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2986 that is set but not used.
2987
47553fa8
PE
2988 * print.c (print_object): Remove var that is set but not used.
2989
1f7196bf 2990 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2991 The gnulib version avoids calling malloc in the usual case,
2992 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2993 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2994 * filelock.c (current_lock_owner): Likewise.
2995 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2996 * sysdep.c: Include allocator.h, careadlinkat.h.
2997 (emacs_no_realloc_allocator): New static constant.
2998 (emacs_readlink): New function.
fdb61804
PE
2999 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3000 ../lib/careadlinkat.h.
d1fdcab7 3001
f84c17c7
SM
30022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3003
3004 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3005 first non-nil return value).
3006
ef3862ad
JD
30072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3008
3009 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3010 if not defined (Bug#8403).
3011
376a7006
JB
30122011-04-02 Juanma Barranquero <lekktu@gmail.com>
3013
3014 * xdisp.c (display_count_lines): Remove parameter `start',
3015 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3016 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3017 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3018 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3019 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3020 and thereabouts. All callers changed.
3021 (get_per_char_metric): Remove parameter `f', unused since
3022 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3023
6ca3801d
JM
30242011-04-02 Jim Meyering <meyering@redhat.com>
3025
3026 do not dereference NULL upon failed strdup
3027 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3028 (ns_get_family): Likewise.
3029
d8e2b5ba
JB
30302011-04-02 Juanma Barranquero <lekktu@gmail.com>
3031
3032 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3033
8c74fcbd
JD
30342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3035
3036 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3037 later (Bug#8403).
3038
7200d79c
SM
30392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3040
03408648 3041 Add lexical binding.
7200d79c 3042
03408648
SM
3043 * window.c (Ftemp_output_buffer_show): New fun.
3044 (Fsave_window_excursion):
3045 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3046
3047 * lread.c (lisp_file_lexically_bound_p): New function.
3048 (Fload): Bind Qlexical_binding.
3049 (readevalloop): Remove `evalfun' arg.
3050 Bind Qinternal_interpreter_environment.
3051 (Feval_buffer): Bind Qlexical_binding.
3052 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3053 Mark as dynamic.
3054 (syms_of_lread): Declare `lexical-binding'.
3055
3056 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3057
3058 * keyboard.c (eval_dyn): New fun.
3059 (menu_item_eval_property): Use it.
ca105506
SM
3060
3061 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3062
03408648
SM
3063 * fns.c (concat, mapcar1): Accept byte-code-functions.
3064
3065 * eval.c (Fsetq): Handle lexical vars.
3066 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3067 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3068 (FletX, Flet): Obey lexical binding.
3069 (Fcommandp): Handle closures.
3070 (Feval): New `lexical' arg.
3071 (eval_sub): New function extracted from Feval. Use it almost
3072 everywhere where Feval was used. Look up vars in lexical env.
3073 Handle closures.
3074 (Ffunctionp): Move from subr.el.
3075 (Ffuncall): Handle closures.
3076 (apply_lambda): Remove `eval_flags'.
3077 (funcall_lambda): Handle closures and new byte-code-functions.
3078 (Fspecial_variable_p): New function.
3079 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3080 but without exporting it to Lisp.
23aba0ea 3081
23aba0ea 3082 * doc.c (Fdocumentation, store_function_docstring):
03408648 3083 * data.c (Finteractive_form): Handle closures.
23aba0ea 3084
03408648
SM
3085 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3086 interactive spec.
ba83908c 3087
04f2d78b
CB
3088 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3089 New byte-codes.
03408648
SM
3090 (exec_byte_code): New function extracted from Fbyte_code to handle new
3091 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3092
03408648 3093 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3094
03408648 3095 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3096
e2abce01
JB
30972011-03-31 Juanma Barranquero <lekktu@gmail.com>
3098
3099 * xdisp.c (redisplay_internal): Fix prototype.
3100
63696a73 31012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3102
63696a73 3103 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3104 (try_scrolling): Use it when setting scroll_limit.
3105 Limit scrolling to 100 screen lines.
63696a73
EZ
3106 (redisplay_window): Even when falling back on "recentering",
3107 position point in the window according to scroll-conservatively,
3108 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3109
3110 (try_scrolling): When point is above the window, allow searching
3111 as far as scroll_max, or one screenful, to compute vertical
3112 distance from PT to the scroll margin position. This prevents
3113 try_scrolling from unnecessarily failing when
3114 scroll-conservatively is set to a value slightly larger than the
3115 window height. Clean up the case of PT below the margin at bottom
3116 of window: scroll_max can no longer be INT_MAX. When aggressive
3117 scrolling is in use, don't let point enter the opposite scroll
3118 margin as result of the scroll.
3119 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3120 threshold of 100 lines for never-recentering scrolling.
3121
e4cc2dfc
JB
31222011-03-31 Juanma Barranquero <lekktu@gmail.com>
3123
3124 * dispextern.h (move_it_by_lines):
3125 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3126 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3127 (message_log_check_duplicate): Remove parameters `prev_bol' and
3128 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3129 (redisplay_internal): Remove parameter `preserve_echo_area',
3130 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3131
3132 * indent.c (Fvertical_motion):
3133 * window.c (window_scroll_pixel_based, Frecenter):
3134 Don't pass `need_y_p' to `move_it_by_lines'.
3135
1c470562
SM
31362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3137
44f230aa
SM
3138 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3139 steal a few bits to be more compact.
3140 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3141 Remove unneeded casts.
3142
1c470562
SM
3143 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3144
888adce9
ZK
31452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3146
3147 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3148 binding" message (bug#7967).
3149
f838ed7b
PE
31502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3151
77861b95
PE
3152 Fix more problems found by GCC 4.6.0's static checks.
3153
de6dbc14
PE
3154 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3155 Remove unused local var.
3156
f838ed7b
PE
3157 * editfns.c (Fmessage_box): Remove unused local var.
3158
792c7b2b
PE
3159 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3160 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3161 Omit unused local vars.
c499e557 3162 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3163 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3164 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3165 Omit unused local var.
3166
ba0165e1
PE
3167 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3168 Don't assume string length fits in int.
32ad8845 3169 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3170 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3171
3c59b4c9
PE
3172 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3173 instead of alloca (Bug#8344).
3174
a3eed478 3175 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3176 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3177
eb4d412d
PE
3178 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3179
1658b401
PE
3180 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3181 concerns.
3182
3183 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3184
3185 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3186
9a2c6e05
PE
3187 * keyboard.c (syms_of_keyboard): Use the same style as later
3188 in this function when indexing through an array. This also
3189 works around GCC bug 48267.
3190
03d0a109
PE
3191 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3192
44f730c8
PE
3193 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3194
fe75f926
PE
3195 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3196 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3197
ffa8c828
PE
3198 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3199 This avoids undefined behavior on integer overflow, and is a bit
3200 more convenient anyway since it is compared to a size_t variable.
3201
c5101a77
PE
3202 Variadic C functions now count arguments with size_t, not int.
3203 This avoids an unnecessary limitation on 64-bit machines, which
3204 caused (substring ...) to crash on large vectors (Bug#8344).
3205 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3206 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3207 All variadic functions and their callers changed accordingly.
c5101a77
PE
3208 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3209 * data.c (arith_driver, float_arith_driver): Likewise.
3210 * editfns.c (general_insert_function): Likewise.
3211 * eval.c (struct backtrace.nargs, interactive_p)
3212 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3213 (funcall_lambda, mark_backtrace): Likewise.
3214 * fns.c (concat): Likewise.
3215 * frame.c (x_set_frame_parameters): Likewise.
3216 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3217 0 if not found, not -1. All callers changed.
3218
dd3f25f7
PE
3219 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3220 (stack_copy_size): Now size_t, not int.
3221 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3222
461c2ab9
JB
32232011-03-28 Juanma Barranquero <lekktu@gmail.com>
3224
3225 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3226 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3227 All callers changed.
3228
3229 * lisp.h (multibyte_char_to_unibyte):
3230 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3231 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3232 * character.h (CHAR_TO_BYTE8):
3233 * cmds.c (internal_self_insert):
3234 * editfns.c (general_insert_function):
3235 * keymap.c (push_key_description):
3236 * search.c (Freplace_match):
3237 * xdisp.c (message_dolog, set_message_1): All callers changed.
3238
f6d62986
SM
32392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3240
3241 * keyboard.c (safe_run_hook_funcall): New function.
3242 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3243 don't set the hook to nil, but remove the offending function instead.
3244 (Qcommand_hook_internal): Remove, unused.
3245 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3246 Vcommand_hook_internal.
3247
3248 * eval.c (enum run_hooks_condition): Remove.
3249 (funcall_nil, funcall_not): New functions.
3250 (run_hook_with_args): Call each function through a `funcall' argument.
3251 Remove `cond' argument, now redundant.
3252 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3253 (Frun_hook_with_args_until_failure): Adjust accordingly.
3254 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3255
1db5b1ad
JB
32562011-03-28 Juanma Barranquero <lekktu@gmail.com>
3257
3258 * dispextern.h (string_buffer_position): Remove declaration.
3259
3260 * print.c (strout): Remove parameter `multibyte', unused since
3261 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3262
3263 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3264 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3265 All callers changed.
3266
3267 * w32.c (_wsa_errlist): Use braces for struct initializers.
3268
3269 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3270 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3271 All callers changed.
3272 (string_buffer_position): Likewise. Also, make static (it's never
3273 used outside xdisp.c).
3274 (cursor_row_p): Remove parameter `w', unused since
3275 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3276 (decode_mode_spec): Remove parameter `precision', introduced during
3277 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3278 All callers changed.
3279
5ffb62aa
JD
32802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3281
3282 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3283
461c2ab9 32842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3285
3286 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3287 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3288 (ns_update_auto_hide_menu_bar): New functions.
3289 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3290 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3291 ns_constrain_all_frames.
3292 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3293 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3294
5c380ffb
JD
32952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3296
3297 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3298
9af30bdf
GM
32992011-03-27 Glenn Morris <rgm@gnu.org>
3300
3301 * syssignal.h: Replace RETSIGTYPE with void.
3302 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3303 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3304 Replace SIGTYPE with void everywhere.
3305 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3306 * s/template.h (SIGTYPE): Remove commented out definition.
3307
e2abce01
JB
33082011-03-26 Eli Zaretskii <eliz@gnu.org>
3309
3310 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3311 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3312
f868cd8a
JB
33132011-03-26 Juanma Barranquero <lekktu@gmail.com>
3314
59eb0929
JB
3315 * w32.c (read_unc_volume): Use parameter `henum', instead of
3316 global variable `wget_enum_handle'.
3317
3318 * keymap.c (describe_vector): Remove parameters `indices' and
3319 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3320 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3321
f868cd8a
JB
3322 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3323
3324 * keyboard.c (timer_check): Remove parameter `do_it_now',
3325 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3326 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3327 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3328
3329 * keyboard.c (read_char):
3330 * w32menu.c (w32_menu_display_help):
3331 * xmenu.c (show_help_event, menu_help_callback):
3332 Adjust calls to `show_help_echo'.
3333
3334 * gtkutil.c (xg_maybe_add_timer):
3335 * keyboard.c (readable_events):
3336 * process.c (wait_reading_process_output):
3337 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3338
3339 * insdel.c (adjust_markers_gap_motion):
3340 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3341 (gap_left, gap_right): Don't call it.
3342
2ecf6fdb
CY
33432011-03-25 Chong Yidong <cyd@stupidchicken.com>
3344
3345 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3346 incurred during fontification.
3347
6b1f9ba4
JB
33482011-03-25 Juanma Barranquero <lekktu@gmail.com>
3349
3350 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3351 (DEFVAR_PER_BUFFER): Don't pass it.
3352
3353 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3354 (scrolling_window): Don't pass it.
3355
0f4a96b5
JB
33562011-03-25 Juanma Barranquero <lekktu@gmail.com>
3357
3358 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3359
3360 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3361 and `suffix'.
3362 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3363 of variables specific to SELinux and computation of `encoded_absname'.
3364
3365 * image.c (XPutPixel): Remove unused variable `height'.
3366
3367 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3368
3369 * unexw32.c (get_section_info): Remove unused variable `section'.
3370
3371 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3372 (system_process_attributes): Remove unused variable `sess'.
3373 (sys_read): Remove unused variable `err'.
3374
3375 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3376 (w32_wnd_proc): Remove unused variable `isdead'.
3377 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3378 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3379 (x_create_tip_frame): Remove unused variable `tem'.
3380
3381 * w32inevt.c (w32_console_read_socket):
3382 Remove unused variable `no_events'.
3383
3384 * w32term.c (x_draw_composite_glyph_string_foreground):
3385 Remove unused variable `width'.
3386
1149507c
JB
33872011-03-24 Juanma Barranquero <lekktu@gmail.com>
3388
3389 * w32term.c (x_set_glyph_string_clipping):
3390 Don't pass uninitialized region to CombineRgn.
3391
9c88f339
JB
33922011-03-23 Juanma Barranquero <lekktu@gmail.com>
3393
3394 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3395 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3396 (Fx_close_connection): Remove unused variable `i'.
3397
3398 * w32font.c (w32font_draw): Return number of glyphs.
3399 (w32font_open_internal): Remove unused variable `i'.
3400 (w32font_driver): Add missing initializer.
3401
3402 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3403 (fill_in_menu): Remove unused variable `items_added'.
3404
3405 * w32term.c (last_mouse_press_frame): Remove static global variable.
3406 (w32_clip_to_row): Remove unused variable `f'.
3407 (x_delete_terminal): Remove unused variable `i'.
3408
3409 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3410 (NOTHING): Remove unused static global variable.
3411 (uniscribe_check_otf): Remove unused variable `table'.
3412 (uniscribe_font_driver): Add missing initializers.
3413
dee091a3
JD
34142011-03-23 Julien Danjou <julien@danjou.info>
3415
3416 * term.c (Fsuspend_tty, Fresume_tty):
3417 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3418 * window.c (temp_output_buffer_show):
3419 * insdel.c (signal_before_change):
3420 * frame.c (Fhandle_switch_frame):
3421 * fileio.c (Fdo_auto_save):
3422 * emacs.c (Fkill_emacs):
3423 * editfns.c (save_excursion_restore):
3424 * cmds.c (internal_self_insert):
3425 * callint.c (Fcall_interactively):
3426 * buffer.c (Fkill_all_local_variables):
3427 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3428 Use Frun_hooks.
0f4a96b5 3429 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3430 unconditionnaly since it does the check itself.
3431
2c520ab5 34322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3433
c9c49752
PE
3434 Fix more problems found by GCC 4.5.2's static checks.
3435
8abc3f12
PE
3436 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3437 the first time through the loop, since we know p0 < p1 then.
3438 This also avoids a gcc -Wstrict-overflow warning.
3439
a2d26660
PE
3440 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3441 leading to a memory leak, possible in functions like
3442 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3443 of objects (Bug#8318).
a2d26660 3444
916c72e9
PE
3445 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3446 that could (at least in theory) be that large.
3447
19ab8a18
PE
3448 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3449 This is less likely to overflow, and avoids undefined behavior if
3450 overflow does occur. All callers changed. Use strtoul to scan
3451 for the unsigned long integer.
b7cbbd6f
PE
3452 (pint2hrstr): Simplify and tune code slightly.
3453 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3454
f0641eff
PE
3455 * scroll.c (do_scrolling): Work around GCC bug 48228.
3456 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3457
7f650bb9
PE
3458 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3459 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3460 (validate_x_resource_name): Simplify count usage.
3461 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3462
37dd57d1
PE
3463 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3464 fail (Bug#8306).
81e56e61 3465
699979fc 3466 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3467
401bf9b4
PE
3468 * process.c (Fmake_network_process): Use socklen_t, not int,
3469 where POSIX says socklen_t is required in portable programs.
3470 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3471 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3472 (Fmake_network_process, server_accept_connection):
3473 (wait_reading_process_output, read_process_output):
3474 Likewise.
3475
b93aacde
PE
3476 * process.c: Rename or move locals to avoid shadowing.
3477 (list_processes_1, Fmake_network_process):
3478 (read_process_output_error_handler, exec_sentinel_error_handler):
3479 Rename or move locals.
4dc343ee 3480 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3481 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3482 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3483 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3484 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3485
af8a867c 3486 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3487 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3488 Include tparam.h instead, since it declares them.
af8a867c
PE
3489 * cm.h (PC): Remove extern decl; tparam.h now does this.
3490 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3491 * terminfo.c: Include tparam.h, to check interfaces.
3492 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3493 (tparam): Adjust signature to match interface in tparam.h;
3494 this removes some undefined behavior. Check that outstring and len
3495 are zero, which they always are with Emacs.
3496 * tparam.h (PC, BC, UP): New extern decls.
3497
0248044d 3498 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3499 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3500
8ff096c1 3501 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3502 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3503 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3504 (ftfont_list): Remove unused local.
49eaafba
PE
3505 (get_adstyle_property, ftfont_pattern_entity):
3506 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3507 Rename locals to avoid shadowing.
8ff096c1 3508
e2be39f6
PE
3509 * xfont.c (xfont_list_family): Mark var as initialized.
3510
c9735e30
PE
3511 * xml.c (make_dom): Now static.
3512
8f5201ae
PE
3513 * composite.c (composition_compute_stop_pos): Rename local to
3514 avoid shadowing.
b246f932
PE
3515 (composition_reseat_it): Remove unused locals.
3516 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3517 (composition_update_it): Mark var as initialized.
11b61122
PE
3518 (find_automatic_composition): Mark vars as initialized,
3519 with a FIXME (Bug#8290).
8f5201ae 3520
760fbc2c
PE
3521 character.h: Rename locals to avoid shadowing.
3522 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3523 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3524 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3525 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3526 to avoid shadowing.
3527
ff08eb85
PE
3528 * textprop.c (property_change_between_p): Remove; unused.
3529
fc7bf025
PE
3530 * intervals.c (interval_start_pos): Now static.
3531
235d7abc
PE
3532 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3533
44f230aa
SM
3534 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3535 Rename locals to avoid shadowing.
3e7d6594 3536
50060332
PE
3537 * sound.c (wav_play, au_play, Fplay_sound_internal):
3538 Fix pointer signedness.
d01f234b 3539 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3540 (wav_play): Initialize a variable to 0, to prevent undefined
3541 behavior (Bug#8278).
50060332 3542
c4fc4e30
PE
3543 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3544
918436ed
PE
3545 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3546
c939f91b
PE
3547 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3548 clobbering (Bug#8298).
b9c7f648
PE
3549 * sysdep.c (sys_subshell): Likewise.
3550 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3551
6bd8c144
PE
3552 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3553 This should get cleaned up, so that child_setup has the
3554 same signature on all platforms.
3555
7710357c 3556 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3557 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3558
c59da222
CY
35592011-03-22 Chong Yidong <cyd@stupidchicken.com>
3560
3561 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3562 not to be necessary, and produces flickering.
3563
66b87493
GM
35642011-03-20 Glenn Morris <rgm@gnu.org>
3565
3566 * config.in: Remove file.
3567
45b6f6d5
JB
35682011-03-20 Juanma Barranquero <lekktu@gmail.com>
3569
3570 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3571 are now in src/globals.h.
3572 (syms_of_minibuf): Remove spurious & from previous change.
3573
3ec03f7e
LL
35742011-03-20 Leo <sdl.web@gmail.com>
3575
3576 * minibuf.c (completing-read-function): New variable.
3577 (completing-read-default): Rename from completing-read.
3578 (completing-read): Call completing-read-function.
3579
b14e3e21
CY
35802011-03-19 Juanma Barranquero <lekktu@gmail.com>
3581
3582 * xfaces.c (Fx_load_color_file):
3583 Read color file from absolute filename (bug#8250).
3584
f2b726e6
JB
35852011-03-19 Juanma Barranquero <lekktu@gmail.com>
3586
3587 * makefile.w32-in: Update dependencies.
3588
09f6ff02
EZ
35892011-03-17 Eli Zaretskii <eliz@gnu.org>
3590
3591 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3592
29a6015a
PE
35932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3594
a3a6c54e
PE
3595 Fix more problems found by GCC 4.5.2's static checks.
3596
b766f867
PE
3597 * process.c (make_serial_process_unwind, send_process_trap):
3598 (sigchld_handler): Now static.
3599
be02381c
PE
3600 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3601 That way, the code declares only the vars that it needs.
3602 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3603 * s/cygwin.h (PTY_ITERATION): Likewise.
3604 * s/darwin.h (PTY_ITERATION): Likewise.
3605 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3606
57048744
PE
3607 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3608 * process.c (allocate_pty): Don't declare stb unless it's needed.
3609
7914961c 3610 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3611 (CONSTANTLIM): Remove; unused.
3612 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3613 Define only if needed.
7914961c 3614
b3967b18
PE
3615 * unexelf.c (unexec): Name an expression,
3616 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3617 Use a different way to cause a compilation error if anyone uses
3618 n rather than nn, a way that does not involve shadowing.
73366a00 3619 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3620
29a6015a
PE
3621 * deps.mk (unexalpha.o): Remove; unused.
3622
43cfc33e 3623 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3624 * unexec.h: New file.
ce701a33
PE
3625 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3626 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3627 Depend on unexec.h.
3628 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3629 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3630 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3631 Change as necessary to match prototype in unexec.h.
ce701a33 3632
01f44d5a
PE
3633 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3634 shadowing.
4f63c6bb 3635 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3636
a6670b0b
PE
3637 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3638 Rename locals to avoid shadowing.
3639
cef2010d 3640 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3641 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3642
d4d7173a
PE
3643 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3644
f08b802a
PE
3645 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3646 warning when compiling print.c.
3647
3ddb0639
PE
3648 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3649 instead of using an uninitialized var.
5ad03b97 3650 (font_sort_entities): Mark var as initialized.
3ddb0639 3651
170a2692
PE
3652 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3653
e663c700
PE
3654 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3655 pointers to constants.
89bc529a 3656 (font_parse_fcname): Remove unused vars.
7b81e2d0 3657 (font_delete_unmatched): Now static.
ea838e10 3658 (font_get_spec): Remove; unused.
13a547c6
PE
3659 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3660 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3661 Rename or move locals to avoid shadowing.
e663c700 3662
2a80c887 3663 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3664 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3665
1384fa33 3666 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3667 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3668
8b2c52e9
PE
3669 * alloc.c (mark_backtrace): Move decl from here ...
3670 * lisp.h: ... to here, so that it can be checked.
3671
475545b5 3672 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3673 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3674 (lisp_indirect_variable): Name an expression,
3675 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3676 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3677
b1349114 3678 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3679 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3680 Use const pointer when appropriate.
b1349114 3681
a2928364
PE
3682 * lisp.h (get_system_name, get_operating_system_release):
3683 Move decls here, to check interfaces.
3684 * process.c (get_operating_system_release): Move decl to lisp.h.
3685 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3686 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3687 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3688 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3689 (Fformat_time_string, Fencode_time, Finsert_char):
3690 (Ftranslate_region_internal, Fformat):
3691 Rename or remove local vars to avoid shadowing.
9710023e 3692 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3693
a415e694
PE
3694 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3695 avoid shadowing.
3696
8ef4622d
PE
3697 * lisp.h (eassert): Check that the argument compiles, even if
3698 ENABLE_CHECKING is not defined.
3699
946f9a5b
PE
3700 * data.c (Findirect_variable): Name an expression, to avoid
3701 gcc -Wbad-function-cast warning.
112396d6 3702 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3703 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3704 (Fmake_variable_buffer_local, Fmake_local_variable):
3705 Mark variables as initialized.
52746918 3706 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3707
e5aab7e7 3708 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3709 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3710 Rename locals to avoid shadowing.
dff45157
PE
3711 (mark_stack): Move local variables into the #ifdef region where
3712 they're used.
7bc26fdb
PE
3713 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3714 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3715 needed otherwise.
3716 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3717 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3718 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3719
e5aab7e7
PE
3720 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3721 avoids undefined behavior in theory.
3722
4da60324
PE
3723 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3724
88043301
PE
3725 Use functions, not macros, for up- and down-casing (Bug#8254).
3726 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3727 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3728 to use the following functions instead of these macros.
3729 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3730 EMACS_INT, since callers assume the returned value fits in int.
3731 (upcase1): Likewise, for UPCASE_TABLE.
3732 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3733 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3734 the race-condition problem in the old DOWNCASE.
88043301 3735
19ed5445
PE
3736 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3737 Rename locals to avoid shadowing.
3738 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3739 (regex_compile, re_search_2, re_match_2_internal):
3740 Remove unused local vars.
952db0d7
PE
3741 (FREE_VAR): Rewrite so as not to use empty "else",
3742 which gcc can warn about.
da053e48 3743 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3744 (RETALLOC_IF): Define only if needed.
3745 (WORDCHAR_P): Likewise. This one is never needed, but is used
3746 only in a comment talking about a compiler bug, so put inside
3747 the #if 0 of that comment.
3748 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3749 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3750 Remove; unused.
19ed5445 3751
1f3561e4 3752 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3753 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3754 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3755
ded6f8f7
PE
3756 * search.c (simple_search): Remove unused var.
3757
dbd37a95
PE
3758 * dired.c (compile_pattern): Move decl from here ...
3759 * lisp.h: ... to here, so that it can be checked.
3760 (struct re_registers): New forward decl.
3761
7e47afad
PE
3762 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3763
85f24f61
PE
3764 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3765 All uses changed.
3766 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3767 Rename locals to avoid shadowing.
5671df8f 3768 (Fvertical_motion): Mark locals as initialized.
85f24f61 3769
181aa2be 3770 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3771 (casify_region): Mark local as initialized.
181aa2be 3772
930d429c
PE
3773 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3774
7082eac6
PE
3775 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3776 New macros, so that the caller can use some names other than
3777 gcpro1, gcpro2, etc.
3778 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3779 of the new macros.
3780 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3781 argument, for consistency with GCPRO2_VAR, etc: it is now the
3782 prefix of the variable, not the variable itself. All uses
3783 changed.
38b2c076
PE
3784 * dired.c (directory_files_internal, file_name_completion):
3785 Rename locals to avoid shadowing.
3786
15206ed9
PE
3787 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3788 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3789 dired.c's scmp function, had undefined behavior.
3790 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3791 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3792 * buffer.h: ... to here, because these macros use current_buffer,
3793 and the new implementation with inline functions needs to have
3794 current_buffer in scope now, rather than later when the macros
3795 are used.
3796 (downcase, upcase1): New static inline functions.
3797 (DOWNCASE, UPCASE1): Reimplement using these functions.
3798 This avoids undefined behavior in expressions like
3799 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3800 from race conditions in accessing the global variables
3801 case_temp1 and case_temp2.
3802 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3803 * lisp.h (case_temp1, case_temp2): Remove their decls.
3804 * character.h (ASCII_CHAR_P): Move from here ...
3805 * lisp.h: ... to here, so that the inline functions mentioned
3806 above can use them.
3807
4a6bea26
PE
3808 * dired.c (directory_files_internal_unwind): Now static.
3809
f14b7e14
PE
3810 * fileio.c (file_name_as_directory, directory_file_name):
3811 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3812 Now static.
2893f146
PE
3813 (file_name_as_directory): Use const pointers when appropriate.
3814 (Fexpand_file_name): Likewise. In particular, newdir might
3815 point at constant storage, so make it a const pointer.
fd4ead52 3816 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3817 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3818 signedness issues.
f839df0c
PE
3819 (Fset_file_times, Finsert_file_contents, auto_save_error):
3820 Rename locals to avoid shadowing.
f14b7e14 3821
5716756e 3822 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3823 (Ftry_completion, Fall_completions): Rename or remove locals
3824 to avoid shadowing.
5716756e 3825
b4c3046a
PE
3826 * marker.c (bytepos_to_charpos): Remove; unused.
3827
b45db522
PE
3828 * lisp.h (verify_bytepos, count_markers): New decls,
3829 so that gcc does not warn that these functions aren't declared.
3830
85876d07
PE
3831 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3832 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3833 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3834 (copy_text): Remove unused local var.
85876d07 3835
03d78a21 3836 * filelock.c (within_one_second): Now static.
b3dd38ab 3837 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3838
5df8f01b
PE
3839 * buffer.c (fix_overlays_before): Mark locals as initialized.
3840 (fix_start_end_in_overlays): Likewise. This function should be
3841 simplified by using pointers-to-pointers, but that's a different
3842 matter.
b1d876f1 3843 (switch_to_buffer_1): Now static.
8f54f30a
PE
3844 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3845 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3846
a70072c9 3847 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3848 Fix pointer signedness issue.
edced198
PE
3849 (sys_subshell): Mark local as volatile if checking for lint,
3850 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3851 (MAXPATHLEN): Define only if needed.
a70072c9 3852
a0977c44
PE
3853 * process.c (serial_open, serial_configure): Move decls from here ...
3854 * systty.h: ... to here, so that they can be checked.
3855
a884fdcc
PE
3856 * fns.c (get_random, seed_random): Move extern decls from here ...
3857 * lisp.h: ... to here, so that they can be checked.
3858
604efe86 3859 * sysdep.c (reset_io): Now static.
b8950c94 3860 (wait_for_termination_signal): Remove; unused.
604efe86 3861
38fc62d9
PE
3862 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3863 (copy_keymap_item, append_key, push_text_char_description):
3864 Now static.
1004a21a 3865 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3866 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3867 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3868 (describe_map_tree):
3869 Rename locals to avoid shadowing.
38fc62d9 3870
2f2650da
PE
3871 * keyboard.c: Declare functions static if they are not used elsewhere.
3872 (echo_char, echo_dash, cmd_error, top_level_2):
3873 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3874 (read_char, kbd_buffer_get_event, make_lispy_position):
3875 (make_lispy_event, make_lispy_movement, apply_modifiers):
3876 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3877 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3878 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3879 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3880 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3881
a053e86c 3882 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3883 (mark_kboards): Move decl here ...
3884 * alloc.c (mark_kboards): ... from here.
a053e86c 3885
4752793e
PE
3886 * lisp.h (force_auto_save_soon): New decl.
3887
74f10ca7 3888 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3889 (DEFINE_DUMMY_FUNCTION): New macro.
3890 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3891 Use it.
c03cd23f
PE
3892 (main): Add casts to avoid warnings
3893 if GCC considers string literals to be constants.
74f10ca7 3894
022e70d4
PE
3895 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3896
59d6fe83
PE
3897 * dbusbind.c: Pointer signedness fixes.
3898 (xd_signature, xd_append_arg, xd_initialize):
3899 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3900 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3901 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3902 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3903
78320123
PE
3904 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3905 if GCC considers string literals to be constants.
49cebcca 3906 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3907
35ac2a97
SM
39082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3909
fb103ca9
SM
3910 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3911 (print_preprocess, print_object): New macro to fix last change.
3912
35ac2a97
SM
3913 * print.c (print_preprocess): Don't forget font objects.
3914
62973b41
JB
39152011-03-16 Juanma Barranquero <lekktu@gmail.com>
3916
3917 * emacs.c (USAGE3): Doc fixes.
3918
0e48bb22
AS
39192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3920
3921 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3922 structure.
3923
7684e57b
JB
39242011-03-14 Juanma Barranquero <lekktu@gmail.com>
3925
3926 * lisp.h (VWindow_system, Qfile_name_history):
3927 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3928 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3929 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3930
3931 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3932 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3933
3934 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3935 * w32console.c (detect_input_pending, read_input_pending)
3936 (encode_terminal_code):
3937 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3938 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3939 (w32_system_caret_y, Qfile_name_history):
3940 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3941 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3942 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3943 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3944 * w32proc.c (Qlocal, report_file_error):
3945 * w32term.c (Vwindow_system, updating_frame):
3946 * w32uniscribe.c (initialized, uniscribe_font_driver):
3947 Remove unneeded extern declarations.
3948
2aa46d6c
CY
39492011-03-14 Chong Yidong <cyd@stupidchicken.com>
3950
c96bbc66 3951 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3952
cffc6f3b
CY
39532011-03-13 Chong Yidong <cyd@stupidchicken.com>
3954
3955 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3956 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3957 These macros can no longer be used for assignment.
3958
44f230aa
SM
3959 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3960 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3961 (record_buffer_markers, fetch_buffer_markers): New functions for
3962 recording and fetching special buffer markers.
3963 (set_buffer_internal_1, set_buffer_temp): Use them.
3964
3965 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3966
3967 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3968
3969 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3970 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3971
3972 * xdisp.c (hscroll_window_tree):
3973 (reconsider_clip_changes): Use PT instead of BUF_PT.
3974
d251f04b
EZ
39752011-03-13 Eli Zaretskii <eliz@gnu.org>
3976
3977 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3978 $(EMACS_ROOT)/lib/intprops.h.
3979
f0c77cd1
PE
39802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3981
3eca4629
PE
3982 Fix more problems found by GCC 4.5.2's static checks.
3983
7c86ee98
PE
3984 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3985 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3986 (xg_free_frame_widgets): Make it clear that a local variable is
3987 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3988 (gdk_window_get_screen): Make it clear that this macro is needed
3989 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3990 (int_gtk_range_get_value): New function, which avoids a diagnostic
3991 from gcc -Wbad-function-cast.
3992 (xg_set_toolkit_scroll_bar_thumb): Use it.
3993 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3994 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3995 (get_utf8_string, xg_get_file_with_chooser):
3996 Rename locals to avoid shadowing.
3997 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3998
41729b81
PE
3999 * xgselect.c (xg_select): Remove unused var.
4000
f0c77cd1
PE
4001 * image.c (four_corners_best): Mark locals as initialized.
4002 (gif_load): Initialize transparent_p to zero (Bug#8238).
4003 Mark another local as initialized.
ec6cf4c6 4004 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4005
ce0ad53d 4006 * image.c (clear_image_cache): Now static.
d5d5a617 4007 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4008 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4009 (x_edge_detection): Remove unnecessary cast that
4010 gcc -Wbad-function-cast diagnoses.
2037898d 4011 (gif_load): Fix pointer signedness.
6ae141d6
PE
4012 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4013 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4014
33383987 40152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4016
d32df629
PE
4017 Improve quality of tests for time stamp overflow.
4018 For example, without this patch (encode-time 0 0 0 1 1
4019 1152921504606846976) returns the obviously-bogus value (-948597
4020 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4021 reports time overflow. See
4022 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4023 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4024 * editfns.c: Include limits.h and intprops.h.
4025 (TIME_T_MIN, TIME_T_MAX): New macros.
4026 (time_overflow): Move earlier, to before first use.
4027 (hi_time, lo_time): New functions, for an accurate test for
4028 out-of-range times.
4029 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4030 (Fget_internal_run_time): Don't assume time_t fits in int.
4031 (make_time): Use list2 instead of Fcons twice.
4032 (Fdecode_time): More accurate test for out-of-range times.
4033 (check_tm_member): New function.
4034 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4035 (lisp_time_argument): Don't rely on undefined left-shift and
4036 right-shift behavior when checking for time stamp overflow.
8be6f318 4037
fe31d94c
PE
4038 * editfns.c (time_overflow): New function, refactoring common code.
4039 (Fformat_time_string, Fdecode_time, Fencode_time):
4040 (Fcurrent_time_string): Use it.
4041
8be6f318
PE
4042 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4043 * dired.c (make_time): Move to ...
4044 * editfns.c (make_time): ... here.
4045 * systime.h: Note the move.
4046
09d9db2c 40472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4048
126bc0dc
YM
4049 * fringe.c (update_window_fringes): Remove unused variables.
4050
c47cbdfd
YM
4051 * unexmacosx.c (copy_data_segment): Also copy __got section.
4052 (Bug#8223)
4053
7ac80be9
EZ
40542011-03-12 Eli Zaretskii <eliz@gnu.org>
4055
c96bbc66 4056 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4057 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4058 Constify `char *' arguments and their references according to
4059 prototypes in tparam.h.
4060
ecb0f94d 4061 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4062
7ac80be9
EZ
4063 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4064 Adapt all references accordingly.
4065
4066 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4067
ef1fd07e
TT
40682011-03-11 Tom Tromey <tromey@redhat.com>
4069
4070 * buffer.c (syms_of_buffer): Remove obsolete comment.
4071
7ef4b50c
EZ
40722011-03-11 Eli Zaretskii <eliz@gnu.org>
4073
4074 * termhooks.h (encode_terminal_code): Declare prototype.
4075
4076 * msdos.c (encode_terminal_code): Don't declare prototype.
4077
4078 * term.c (encode_terminal_code): Now external again, used by
4079 w32console.c and msdos.c.
4080
44f230aa
SM
4081 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4082 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4083
4b1ec863 40842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4085
1714f52b 4086 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4087
4b1ec863
PE
4088 * fringe.c (update_window_fringes): Mark locals as initialized
4089 (Bug#8227).
4090 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4091
524c7aa6
PE
4092 * alloc.c (mark_fringe_data): Move decl from here ...
4093 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4094 to check its interface.
4095 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4096
a5c0af81 4097 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4098 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4099 (fontset_font): Mark local as initialized.
a9a06e0b 4100 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4101
b4716021
PE
4102 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4103
811e9bac 4104 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4105 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4106 (x_own_selection, Fx_disown_selection_internal): Rename locals
4107 to avoid shadowing.
4108 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4109
7e3ab302
PE
4110 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4111 so that the caller can use some name other than gcpro1.
4112 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4113 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4114 (Fx_backspace_delete_keys_p):
4115 Use them to avoid shadowing, and rename vars to avoid shadowing.
4116 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4117 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4118 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4119 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4120 Remove unused locals.
7e3ab302
PE
4121 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4122 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4123 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4124 macros.
f78faa98 4125
e2b13473
PE
4126 * xterm.h (x_mouse_leave): New decl.
4127
77f23912
PE
4128 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4129 Remove unused functions.
cdf4ba58
PE
4130 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4131 (x_calc_absolute_position): Now static.
7411c686 4132 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4133 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4134 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4135 unless they are used.
38d0b34a
PE
4136 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4137 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4138 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4139 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4140 (x_error_catcher, x_connection_closed, x_error_handler):
4141 (x_error_quitter, xembed_send_message, x_iconify_frame):
4142 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4143 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4144 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4145
44f230aa
SM
4146 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4147 Rename or move locals to avoid shadowing.
6b463e58 4148 (tty_defined_color, merge_face_heights): Now static.
5967d051 4149 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4150 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4151 does not deduce is never used uninitialized.
73719eba
PE
4152 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4153 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4154
426994c3 4155 * terminal.c (store_terminal_param): Now static.
5489860b 4156
032f1620 4157 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4158 (set_frame_menubar): Remove unused local.
d4323972 4159 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4160 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4161 since they might point to immutable storage.
281585b0
PE
4162 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4163 since it's unused otherwise.
032f1620 4164
367c19e5 4165 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4166 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4167 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4168 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4169 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4170 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4171 does not deduce are never used uninitialized.
70739cbe 4172
07b48fa9
PE
4173 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4174
8868a238 4175 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4176 * window.c (window_loop, size_window):
4177 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4178
7e5cf297 4179 * window.c (display_buffer): Now static.
d6550a9f
PE
4180 (size_window): Mark variables that gcc -Wuninitialized
4181 does not deduce are never used uninitialized.
a586633d
PE
4182 * window.h (check_all_windows): New decl, to forestall
4183 gcc -Wmissing-prototypes diagnostic.
5b555da1 4184 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4185
f6095868
PE
4186 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4187 shadowing.
4188 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4189 Include <limits.h>.
4190 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4191 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4192 (load_charset_map): Mark variables that gcc -Wuninitialized
4193 does not deduce are never used uninitialized.
53df7c11 4194 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4195
f38b440c
PE
4196 * coding.c (coding_set_source, coding_set_destination):
4197 Use "else { /* comment */ }" rather than "else /* comment */;"
4198 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4199 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4200 a block, when the outer 'i' will do.
4201 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4202 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4203 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4204 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4205 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4206 Rename locals to avoid shadowing.
4207 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4208 * coding.c (emacs_mule_char, encode_invocation_designation):
4209 Now static, since they're not used elsewhere.
413bb2db 4210 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4211 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4212 (decode_coding_emacs_mule): Mark variables that gcc
4213 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4214 (detect_coding_iso_2022): Initialize a local variable that might
4215 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4216 this initialization is needed. (Bug#8211)
5f58e762
PE
4217 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4218 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4219 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4220 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4221 Remove unused macros.
f38b440c 4222
232b38b9 4223 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4224 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4225 * character.c (string_count_byte8): Likewise.
232b38b9 4226
fb90da1b
PE
4227 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4228 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4229
fb93dbc2
PE
4230 * chartab.c (copy_sub_char_table): Now static, since it's not used
4231 elsewhere.
5c156ace
PE
4232 (sub_char_table_ref_and_range, char_table_ref_and_range):
4233 Rename locals to avoid shadowing.
bbcd0949 4234 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4235
7d3b3862 4236 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4237 (BIDI_BOB): Remove unused macro.
7d3b3862 4238
6be7d3da
PE
4239 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4240 deduce are never used uninitialized.
c2ed9c8b 4241 * term.c (encode_terminal_code): Likewise.
6be7d3da 4242
75f8807f 4243 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4244
50938595
PE
4245 * tparam.h: New file.
4246 * term.c, tparam.h: Include it.
4247 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4248 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4249 Move these decls to tparam.h, and make them agree with what
4250 is actually in tparam.c. The previous trick of using incompatible
4251 decls in different modules does not conform to the C standard.
4252 All callers of tparam changed to use tparam's actual API.
4253 * tparam.c (tparam1, tparam, tgoto):
4254 Use const pointers where appropriate.
4255
fbceeba2
PE
4256 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4257 * cm.h (struct cm): Likewise.
4258 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4259 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4260 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4261 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4262 (turn_on_face, init_tty): Likewise.
4263 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4264
7f3f1250
PE
4265 * term.c (term_mouse_position): Rename local to avoid shadowing.
4266
e6ca6543
PE
4267 * alloc.c (mark_ttys): Move decl from here ...
4268 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4269
c40f8d15
AS
42702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4271
4272 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4273
cfe0661d
JB
42742011-03-09 Juanma Barranquero <lekktu@gmail.com>
4275
4276 * search.c (compile_pattern_1): Remove argument regp, unused since
4277 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4278 (compile_pattern): Don't pass it.
4279
0afb4571
J
42802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4281
4282 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4283 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4284 for ! HAVE_GTK3.
4285 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4286
4287 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4288
4289 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4290 gdk_window_get_screen, gdk_window_get_geometry,
4291 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4292 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4293 (xg_get_pixbuf_from_pixmap): New function.
4294 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4295 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4296 Call xg_get_pixbuf_from_pixmap instead of
4297 gdk_pixbuf_get_from_drawable.
4298 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4299 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4300 (xg_check_special_colors): Use GtkStyleContext and its functions
4301 for HAVE_GTK3.
4302 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4303 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4304 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4305 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4306 Call gtk_widget_get_preferred_size.
0afb4571
J
4307 (xg_frame_resized): gdk_window_get_geometry only takes 5
4308 parameters.
44f230aa
SM
4309 (xg_win_to_widget, xg_event_is_for_menubar):
4310 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4311 (xg_set_widget_bg): New function.
4312 (delete_cb): New function.
895009e1 4313 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4314 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4315 (xg_set_background_color): Call xg_set_widget_bg.
4316 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4317 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4318 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4319 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4320 if ! HAVE_GTK3.
4321 (update_frame_tool_bar): Call gtk_widget_hide.
4322 (xg_initialize): Use GDK_KEY_g.
4323
4324 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4325 if ! HAVE_GTK3
4326 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4327
4328 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4329 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4330 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4331
1c2cc4ef
JB
43322011-03-08 Juanma Barranquero <lekktu@gmail.com>
4333
4334 * w32xfns.c (select_palette): Check success of RealizePalette against
4335 GDI_ERROR, not zero.
4336
33383987 4337See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4338
4339;; Local Variables:
4340;; coding: utf-8
aac0c6e3
MR
4341;; End:
4342
33383987 4343 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4344
4345 This file is part of GNU Emacs.
4346
4347 GNU Emacs is free software: you can redistribute it and/or modify
4348 it under the terms of the GNU General Public License as published by
4349 the Free Software Foundation, either version 3 of the License, or
4350 (at your option) any later version.
4351
4352 GNU Emacs is distributed in the hope that it will be useful,
4353 but WITHOUT ANY WARRANTY; without even the implied warranty of
4354 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4355 GNU General Public License for more details.
4356
4357 You should have received a copy of the GNU General Public License
4358 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.