* dired.el (dired-flagging-regexp): Removed unused variable
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a9ab721e
LMI
12011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4
cf7cff57
PE
52011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6
2e13213d
PE
7 * xsettings.c (SYSTEM_FONT): Define only when used.
8 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9
cf7cff57
PE
10 * keymap.c (access_keymap_1): Now static.
11
7a8e04f7
CY
122011-07-02 Chong Yidong <cyd@stupidchicken.com>
13
14 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
15 leave any prefix arg for the up event (Bug#1586).
16
61352f62
LMI
172011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
18
69bb1ef7
LMI
19 * lread.c (syms_of_lread): Mention single symbols defined by
20 `defvar' or `defconst' (bug#7154).
21
61352f62 22 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 23 (Frequire): Mention get-load-suffixes.
61352f62 24
28545e04
MR
252011-07-02 Martin Rudalics <rudalics@gmx.at>
26
27 * window.h (window): Remove clone_number slot.
28 * window.c (Fwindow_clone_number, Fset_window_clone_number):
29 Remove.
30 (make_parent_window, make_window, saved_window)
31 (Fset_window_configuration, save_window_save): Don't deal with
32 clone numbers.
33 * buffer.c (Qclone_number): Remove declaration.
34 (sort_overlays, overlay_strings): Don't deal with clone numbers.
35
3349e122
SM
362011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
37
38 Add multiple inheritance to keymaps.
39 * keymap.c (Fmake_composed_keymap): New function.
40 (Fset_keymap_parent): Simplify.
41 (fix_submap_inheritance): Remove.
42 (access_keymap_1): New function extracted from access_keymap to handle
43 embedded parents and handle lists of maps.
44 (access_keymap): Use it.
45 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
46 (Fcopy_keymap): Handle embedded parents.
47 (Fcommand_remapping, define_as_prefix): Simplify.
48 (Fkey_binding): Simplify.
49 (syms_of_keymap): Move minibuffer-local-completion-map,
50 minibuffer-local-filename-completion-map,
51 minibuffer-local-must-match-map, and
52 minibuffer-local-filename-must-match-map to Elisp.
53 (syms_of_keymap): Defsubr make-composed-keymap.
54 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
55 (parse_menu_item): Trivial simplification.
56
3279eb87
GM
572011-07-01 Glenn Morris <rgm@gnu.org>
58
59 * Makefile.in (SETTINGS_LIBS): Fix typo.
60
4550efdf
KI
612011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
62
63 * coding.c (Fencode_coding_string): Record the last coding system
64 used, as the function doc string says (bug#8738).
65
0949d2b6
JD
662011-07-01 Jan Djärv <jan.h.d@swipnet.se>
67
68 * xsettings.c (store_monospaced_changed): Take new font as arg and
69 check for change against current_mono_font.
70 (EMACS_TYPE_SETTINGS): Remove this and related defines.
71 (emacs_settings_constructor, emacs_settings_get_property)
72 (emacs_settings_set_property, emacs_settings_class_init)
73 (emacs_settings_init, gsettings_obj): Remove.
74 (something_changedCB): New function for HAVE_GSETTINGS.
75 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
76 with value as argument.
77 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
78 g_settings_new (Bug#8967). Do not create gsettings_obj.
79 Remove calls to g_settings_bind. Connect something_changedCB to
80 "changed".
81
82 * xgselect.c: Add defined (HAVE_GSETTINGS).
83 (xgselect_initialize): Ditto.
84
85 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
86 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
87 xg_select.
88
bbc6b304
PE
892011-07-01 Paul Eggert <eggert@cs.ucla.edu>
90
91 * eval.c (struct backtrace): Simplify and port the data structure.
92 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
93 signed bit field, as this assumption is not portable and it makes
94 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
95 "char debug_on_exit : 1" as this is not portable either; instead,
96 use the portable "unsigned int debug_on_exit : 1". Remove unused
97 member evalargs. Remove obsolete comments about cc bombing out.
98
9851bfc5
JD
992011-06-30 Jan Djärv <jan.h.d@swipnet.se>
100
51bb811f 101 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
102 Let HAVE_GSETTINGS override HAVE_GCONF.
103 (store_monospaced_changed): New function.
104 (EMACS_SETTINGS): A new type derived from GObject to handle
105 GSettings notifications.
106 (emacs_settings_constructor, emacs_settings_get_property)
107 (emacs_settings_set_property, emacs_settings_class_init):
108 New functions.
109 (gsettings_client, gsettings_obj): New variables.
110 (GSETTINGS_SCHEMA): New define.
111 (something_changedCB): Call store_monospaced_changed.
112 (init_gsettings): New function.
113 (xsettings_initialize): Call init_gsettings.
114 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
115 to NULL.
116
117 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
118 GCONF_CFLAGS/LIBS.
119
5386012d
MR
1202011-06-29 Martin Rudalics <rudalics@gmx.at>
121
122 * window.c (resize_root_window, grow_mini_window)
123 (shrink_mini_window): Rename Qresize_root_window to
124 Qwindow_resize_root_window and Qresize_root_window_vertically to
125 Qwindow_resize_root_window_vertically.
126
f13e0b08
PE
1272011-06-28 Paul Eggert <eggert@cs.ucla.edu>
128
129 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
130
94515237
JB
1312011-06-27 Juanma Barranquero <lekktu@gmail.com>
132
133 * makefile.w32-in: Redesign dependencies so they reflect more
134 clearly which files are directly included by each source file,
135 and not through other includes.
136
e43b6e43
MR
1372011-06-27 Martin Rudalics <rudalics@gmx.at>
138
139 * buffer.c (Qclone_number): Declare static and DEFSYM it.
140 (sort_overlays, overlay_strings): When an overlay's clone number
141 matches the window's clone number process the overlay even if
142 the overlay's window property doesn't match the current window.
143
d68443dc
MR
144 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
145 (Fwindow_hchild): Rename to Fwindow_left_child.
146 (Fwindow_next): Rename to Fwindow_next_sibling.
147 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
148 (resize_window_check): Rename to window_resize_check.
149 (resize_window_apply): Rename to window_resize_apply.
150 (Fresize_window_apply): Rename to Fwindow_resize_apply.
151 (Fdelete_other_windows_internal, resize_frame_windows)
152 (Fsplit_window_internal, Fdelete_window_internal)
153 (grow_mini_window, shrink_mini_window)
154 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 155
c7e73be5
JD
1562011-06-26 Jan Djärv <jan.h.d@swipnet.se>
157
158 * emacsgtkfixed.h: State that this is only used with Gtk+3.
159 (emacs_fixed_set_min_size): Remove.
160 (emacs_fixed_new): Take frame as argument.
161
162 * emacsgtkfixed.c: State that this is only used with Gtk+3.
163 (_EmacsFixedPrivate): Remove minwidth/height.
164 Add struct frame *f.
165 (emacs_fixed_init): Initialize priv->f.
166 (get_parent_class, emacs_fixed_set_min_size): Remove.
167 (emacs_fixed_new): Set priv->f to argument.
168 (emacs_fixed_get_preferred_width)
169 (emacs_fixed_get_preferred_height): Use min_width/height from
170 frames size_hint to set minimum and natural (Bug#8919).
171 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
172 and use min_width/height from frames size_hint to set
173 min_width/height (Bug#8919).
174
175 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
176 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
177 indentation.
178
cf99dcf8
EZ
1792011-06-26 Eli Zaretskii <eliz@gnu.org>
180
181 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
182 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
183 called at ZV.
184
029529ac
CY
1852011-06-26 Chong Yidong <cyd@stupidchicken.com>
186
187 * process.c (wait_reading_process_output): Bypass select if
188 waiting for a cell while ignoring keyboard input, and input is
189 pending. Suggested by Jan Djärv (Bug#8869).
190
7a7ef429
PE
1912011-06-25 Paul Eggert <eggert@cs.ucla.edu>
192
193 Use gnulib's dup2 module instead of rolling our own.
194 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
195
11fdef7d 1962011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
197
198 * dispnew.c (scrolling_window): Before scrolling, turn off a
199 mouse-highlight in the window being scrolled.
200
cd3520a4
JB
2012011-06-24 Juanma Barranquero <lekktu@gmail.com>
202
203 Move DEFSYM to lisp.h and use everywhere.
204
205 * character.h (DEFSYM): Move declaration...
206 * lisp.h (DEFSYM): ...here.
207
208 * gnutls.c:
209 * minibuf.c:
210 * w32menu.c:
211 * w32proc.c:
212 * w32select.c: Don't include character.h.
213
214 * alloc.c (syms_of_alloc):
215 * buffer.c (syms_of_buffer):
216 * bytecode.c (syms_of_bytecode):
217 * callint.c (syms_of_callint):
218 * casefiddle.c (syms_of_casefiddle):
219 * casetab.c (init_casetab_once):
220 * category.c (init_category_once, syms_of_category):
221 * ccl.c (syms_of_ccl):
222 * cmds.c (syms_of_cmds):
223 * composite.c (syms_of_composite):
224 * dbusbind.c (syms_of_dbusbind):
225 * dired.c (syms_of_dired):
226 * dispnew.c (syms_of_display):
227 * doc.c (syms_of_doc):
228 * editfns.c (syms_of_editfns):
229 * emacs.c (syms_of_emacs):
230 * eval.c (syms_of_eval):
231 * fileio.c (syms_of_fileio):
232 * fns.c (syms_of_fns):
233 * frame.c (syms_of_frame):
234 * fringe.c (syms_of_fringe):
235 * insdel.c (syms_of_insdel):
236 * keymap.c (syms_of_keymap):
237 * lread.c (init_obarray, syms_of_lread):
238 * macros.c (syms_of_macros):
239 * msdos.c (syms_of_msdos):
240 * print.c (syms_of_print):
241 * process.c (syms_of_process):
242 * search.c (syms_of_search):
243 * sound.c (syms_of_sound):
244 * syntax.c (init_syntax_once, syms_of_syntax):
245 * terminal.c (syms_of_terminal):
246 * textprop.c (syms_of_textprop):
247 * undo.c (syms_of_undo):
248 * w32.c (globals_of_w32):
249 * window.c (syms_of_window):
250 * xdisp.c (syms_of_xdisp):
251 * xfaces.c (syms_of_xfaces):
252 * xfns.c (syms_of_xfns):
253 * xmenu.c (syms_of_xmenu):
254 * xsettings.c (syms_of_xsettings):
255 * xterm.c (syms_of_xterm): Use DEFSYM.
256
4228cf16
TZ
2572011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
258
cd3520a4 259 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 260
7fcccf1e
PE
2612011-06-23 Paul Eggert <eggert@cs.ucla.edu>
262
7efb4e0e
PE
263 Integer and buffer overflow fixes (Bug#8873).
264
ff5844ad
PE
265 * print.c (printchar, strout): Check for string overflow.
266 (PRINTPREPARE, printchar, strout):
267 Don't set size unless allocation succeeds.
268
90532f02
PE
269 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
270 for sizes. Check for string overflow more accurately.
271 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
272
6d84508d
PE
273 * macros.c: Integer and buffer overflow fixes.
274 * keyboard.h (struct keyboard.kbd_macro_bufsize):
275 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
276 Use ptrdiff_t, not int, for sizes.
277 Don't increment bufsize until after realloc succeeds.
278 Check for size-calculation overflow.
279 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
280
437b2cb4
PE
281 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
282
8b9ac8b4
PE
283 * lread.c: Integer overflow fixes.
284 (read_integer): Radix is now EMACS_INT, not int,
285 to improve quality of diagnostics for out-of-range radices.
286 Calculate buffer size correctly for out-of-range radices.
287 (read1): Check for integer overflow in radices, and in
288 read-circle numbers.
82cb60d3
PE
289 (read_escape): Avoid int overflow.
290 (Fload, openp, read_buffer_size, read1)
291 (substitute_object_recurse, read_vector, read_list, map_obarray):
292 Use ptrdiff_t, not int, for sizes.
293 (read1): Use EMACS_INT, not int, for sizes.
20270765 294 Check for size overflow.
8b9ac8b4 295
7fcccf1e
PE
296 * image.c (cache_image): Check for size arithmetic overflow.
297
bfbbd7e7
PE
298 * lread.c: Integer overflow issues.
299 (saved_doc_string_size, saved_doc_string_length)
300 (prev_saved_doc_string_size, prev_saved_doc_string_length):
301 Now ptrdiff_t, not int.
302 (read1): Don't assume doc string length fits in int. Check for
303 out-of-range doc string lengths.
304 (read_list): Don't assume file position fits in int.
39019e54 305 (read_escape): Check for hex character overflow.
bfbbd7e7 306
4e323265
LL
3072011-06-22 Leo Liu <sdl.web@gmail.com>
308
309 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
310 Move to minibuffer.el.
311
85fece3e
PE
3122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
313
20b84ce9 314 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
315 The following patches are for when GLYPH_DEBUG && !XASSERT.
316 * dispextern.h (trace_redisplay_p, dump_glyph_string):
317 * dispnew.c (flush_stdout):
318 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
319 Mark as externally visible.
320 * dispnew.c (check_window_matrix_pointers): Now static.
321 * dispnew.c (window_to_frame_vpos):
322 * xfns.c (unwind_create_frame):
323 * xterm.c (x_check_font): Remove unused local.
324 * scroll.c (CHECK_BOUNDS):
325 * xfaces.c (cache_fache): Rename local to avoid shadowing.
326 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
327 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
328 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
329 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
330 Now static.
331 (debug_method_add): Use va_list and vsprintf rather than relying
332 on undefined behavior with wrong number of arguments.
333 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
334 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
335 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
336 since we're not interested in debugging glyphs with old libraries.
337 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
338 GCC 4.6.0's static checking.
339
0766b489
PE
3402011-06-22 Paul Eggert <eggert@cs.ucla.edu>
341
31fd4b32
PE
342 Integer overflow and signedness fixes (Bug#8873).
343 A few related buffer overrun fixes, too.
344
b79e8648
PE
345 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
346
0766b489
PE
347 * dispextern.h (struct face.stipple):
348 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
349 (x_bitmap_mask, x_allocate_bitmap_record)
350 (x_create_bitmap_from_data, x_create_bitmap_from_file)
351 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
352 (x_create_bitmap_from_xpm_data):
353 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
354 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
355 (.bitmaps_last):
356 * xfaces.c (load_pixmap):
357 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
358 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
359 (.bitmaps_last, struct x_output.icon_bitmap):
360 Use ptrdiff_t, not int, for bitmap indexes.
361 (x_allocate_bitmap_record): Check for size overflow.
362 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
363
b081724f
PE
364 Use ptrdiff_t, not int, for overlay counts.
365 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
366 * editfns.c (overlays_around, get_pos_property):
367 * textprop.c (get_char_property_and_overlay):
368 * xdisp.c (next_overlay_change, note_mouse_highlight):
369 * xfaces.c (face_at_buffer_position):
21514da7
PE
370 * buffer.c (OVERLAY_COUNT_MAX): New macro.
371 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
372 (Fnext_overlay_change, Fprevious_overlay_change)
373 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 374 Use ptrdiff_t, not int, for sizes.
21514da7 375 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 376
3de73e5e
PE
377 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
378
2606c57b
PE
379 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
380 (x_session_initialize): Do not assume string length fits in int.
381
aaafe47a
PE
382 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
383 This is unlikely, but can occur if DPI is outlandish.
384
2674ddc8 385 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
386 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
387
28154962
PE
388 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
389 * xrdb.c (magic_file_p, search_magic_path):
390 Omit last arg SUFFIX; it was always 0. All callers changed.
391 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
392
7de51af5
PE
393 * xfont.c (xfont_match): Avoid need for strlen.
394
25ed6cc3
PE
395 * xfns.c: Don't assume strlen fits in int.
396 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
397
4eab31dd
PE
398 * xdisp.c (message_log_check_duplicate): Return intmax_t,
399 not unsigned long, as we prefer signed integers. All callers changed.
400 Detect integer overflow in repeat count.
401 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 402 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 403
171e2a58
PE
404 * termcap.c: Don't assume sizes fit in int and never overflow.
405 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
406 (gobble_line): Check for size-calculation overflow.
407
ad39faca 408 * minibuf.c (Fread_buffer):
6e5bb2dc 409 * lread.c (intern, intern_c_string):
74ca2eb3
PE
410 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
411 Don't assume string length fits in int.
412
52c61c22 413 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
414 * gtkutil.c (style_changed_cb): Avoid need for strlen.
415
b5b8c9e5
PE
416 * font.c: Don't assume string length fits in int.
417 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
418 Use ptrdiff_t, not int.
ccd6111c
PE
419 (font_intern_prop): Don't assume string length fits in int.
420 Don't assume integer property fits in fixnum.
421 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 422
882f0d81 423 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 424 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
425 Reformulate so as not to need the command string.
426 Invoke gzip -cd rather than gunzip, as it's more portable.
427 (lock_info_type, lock_file_1, lock_file):
428 Don't assume pid_t and time_t fit in unsigned long.
429 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
430 (current_lock_owner): Prefer signed type for sizes.
431 Use memcpy, not strncpy, where memcpy is what is really wanted.
432 Don't assume (via atoi) that time_t and pid_t fit in int.
433 Check for time_t and/or pid_t out of range, e.g., via a network share.
434 Don't alloca where an auto var works fine.
435
93f4cf88
PE
436 * fileio.c: Fix some integer overflow issues.
437 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
438 Don't assume string length fits in int.
439 (directory_file_name): Don't assume string length fits in long.
440 (make_temp_name): Don't assume pid fits in int, or that its print
441 length is less than 20.
442
f3e92b69
PE
443 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
444
1bfdaf10
PE
445 * coding.c (make_subsidiaries): Don't assume string length fits in int.
446
35016e9a
PE
447 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
448
3d1e65a1
PE
449 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
450 We prefer signed integers, even for size calculations.
451
0b963a93
PE
452 * emacs.c: Don't assume string length fits in 'int'.
453 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
454 (main): Don't invoke strlen when not needed.
455
573f4b54
PE
456 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
457 (XD_DEBUG_MESSAGE): Don't waste a byte.
458
989f33ba
PE
459 * callproc.c (getenv_internal_1, getenv_internal)
460 (Fgetenv_internal):
965d34eb
PE
461 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
462
e4d29b33
PE
463 * lread.c (invalid_syntax): Omit length argument.
464 All uses changed. This doesn't fix a bug, but it simplifies the
465 code away from its former Hollerith-constant appearance, and it's
466 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 467 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 468
eb49b136
PE
469 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
470 This didn't break anything, but it didn't help either.
471 It's confusing to put a bogus integer in a place where the actual
472 value does not matter.
9f62aeb1 473 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 474 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 475
15375a22
PE
476 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
477 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
478 implementation.
b61cc01c
PE
479 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
480 We prefer signed types, and the value cannot exceed the EMACS_INT
481 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
482 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
483 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
484 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 485
53b2623d
PE
486 * indent.c (sane_tab_width): New function.
487 (current_column, scan_for_column, Findent_to, position_indentation)
488 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 489 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 490
51cab52b 491 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 492
f2ed8a70
PE
493 * lisp.h (lint_assume): New macro.
494 * composite.c (composition_gstring_put_cache):
495 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
496
abe80cc6
PE
497 * editfns.c, insdel.c:
498 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 499
b02c740e
PE
500 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
501
ebc96716
PE
502 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
503
b4e50fa0 504 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 505 Use much-faster test for byte-length change.
311d5d7c 506 Don't assume string byte-length fits in 'int'.
a4cf38e4 507 Check that character arg fits in 'int'.
85461888 508 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 509
c0c1ee9f
PE
510 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
511
a498d7f4
PE
512 * fns.c (concat): Catch string overflow earlier.
513 Do not rely on integer wraparound.
514
51cab52b
PE
515 * dispextern.h (struct it.overlay_strings_charpos)
516 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
517 * xdisp.c (forward_to_next_line_start)
518 (back_to_previous_visible_line_start)
519 (reseat_at_next_visible_line_start, next_element_from_buffer):
520 Don't arbitrarily truncate the value of 'selective' to int.
521
76031fad
PE
522 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
523
5eb55db9
PE
524 * composite.c: Don't truncate sizes to 'int'.
525 (composition_gstring_p, composition_reseat_it)
526 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
527 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
528 not EMACS_UINT, for indexes.
5eb55db9 529
0703a717
PE
530 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
531
d6202519
PE
532 * buffer.c: Include <verify.h>.
533 (struct sortvec.priority, struct sortstr.priority):
8961a454 534 Now EMACS_INT, not int.
c20998a7 535 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
536 (struct sortstr.size, record_overlay_string)
537 (struct sortstrlist.size, struct sortlist.used):
538 Don't truncate size to int.
539 (record_overlay_string): Check for size-calculation overflow.
d6202519 540 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 541
d5a19415
JM
5422011-06-22 Jim Meyering <meyering@redhat.com>
543
029529ac 544 Don't leak an XBM-image-sized buffer
d5a19415
JM
545 * image.c (xbm_load): Free the image buffer after using it.
546
a9041e6c
PE
5472011-06-21 Paul Eggert <eggert@cs.ucla.edu>
548
549 Port to Sun C.
550 * composite.c (find_automatic_composition): Omit needless 'return 0;'
551 that Sun C diagnosed.
552 * fns.c (secure_hash): Fix pointer signedness issue.
553 * intervals.c (static_offset_intervals): New function.
554 (offset_intervals): Use it.
555
7f3f739f
LL
5562011-06-21 Leo Liu <sdl.web@gmail.com>
557
558 * deps.mk (fns.o):
559 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
560 sha512.h.
561
562 * fns.c (secure_hash): Rename from crypto_hash_function and change
563 the first arg to accept symbols.
5b66d427 564 (Fsecure_hash): New primitive.
7f3f739f
LL
565 (syms_of_fns): New symbols.
566
76147d94
DD
5672011-06-20 Deniz Dogan <deniz@dogan.se>
568
569 * process.c (Fset_process_buffer): Clarify return value in
570 docstring.
571
7d7d0045
CY
5722011-06-18 Chong Yidong <cyd@stupidchicken.com>
573
574 * dispnew.c (add_window_display_history): Use BVAR.
575
576 * xdisp.c (debug_method_add): Use BVAR.
577 (check_window_end, dump_glyph_matrix, dump_glyph)
578 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
579
580 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
581 Likewise.
582
583 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
584 check till after the cache is created in init_frame_faces.
585
ff2bc410
SM
5862011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
587
588 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
589
28177add
PE
5902011-06-16 Paul Eggert <eggert@cs.ucla.edu>
591
dd3482fe
PE
592 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
593 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
594 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
595
393d71f3 596 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
597 * fileio.c (Finsert_file_contents):
598 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
599 Remove the old (too-loose) buffer overflow checks.
600 They weren't needed, since make_gap checks for buffer overflow.
601 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
602 The old code merely checked for Emacs fixnum overflow, and relied
603 on undefined (wraparound) behavior. The new code avoids undefined
604 behavior, and also checks for ptrdiff_t and/or size_t overflow.
605
2e6813b0 606 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
607 Tune. Don't use wider integers than needed. Don't use alloca.
608 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 609
599a9e4f
PE
610 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
611
99561444
PE
612 * insdel.c, lisp.h (buffer_overflow): New function.
613 (insert_from_buffer_1, replace_range, replace_range_2):
614 * insdel.c (make_gap_larger):
615 * editfns.c (Finsert_char):
616 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
617
28177add
PE
618 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
619
e69dafad
PE
6202011-06-15 Paul Eggert <eggert@cs.ucla.edu>
621
a7af7fde 622 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 623
b1c46f02
PE
624 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
625 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
626
e69dafad
PE
627 * fileio.c: Don't assume EMACS_INT fits in off_t.
628 (emacs_lseek): New static function.
629 (Finsert_file_contents, Fwrite_region): Use it.
630 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
631
566684ea
PE
632 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
633
e6966cd6
PE
634 * fns.c: Don't overflow int when computing a list length.
635 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
636 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
637 truncation on 64-bit hosts. Check for QUIT every
638 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
639 faster and is responsive enough.
640 (Flength): Report an error instead of overflowing an integer.
641 (Fsafe_length): Return a float if the value is not representable
642 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 643 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 644 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 645
dd0b0efb
PE
646 * alloc.c: Check that resized vectors' lengths fit in fixnums.
647 (header_size, word_size): New constants.
648 (allocate_vectorlike): Don't check size overflow here.
649 (allocate_vector): Check it here instead, since this is the only
650 caller of allocate_vectorlike that could cause overflow.
651 Check that the new vector's length is representable as a fixnum.
652
86fe5cfe
PE
653 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
654 The previous code was bogus. For example, next_almost_prime (32)
655 returned 39, which is undesirable as it is a multiple of 3; and
656 next_almost_prime (24) returned 25, which is a multiple of 5 so
657 why was the code bothering to check for multiples of 7?
658
80e88859
PE
659 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
660
4a2f0ad6
PE
661 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
662
f66c7cf8
PE
663 Variadic C functions now count arguments with ptrdiff_t.
664 This partly undoes my 2011-03-30 change, which replaced int with size_t.
665 Back then I didn't know that the Emacs coding style prefers signed int.
666 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
667 were being counted with int, which may truncate counts on 64-bit
668 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
669 * lisp.h (struct Lisp_Subr.function.aMANY)
670 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
671 Arg counts are now ptrdiff_t, not size_t.
672 All variadic functions and their callers changed accordingly.
673 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
674 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
675 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
676 * callint.c (Fcall_interactively): Check arg count for overflow,
677 to avoid potential buffer overrun. Use signed char, not 'int',
678 for 'varies' array, so that we needn't bother to check its size
679 calculation for overflow.
680 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
681 * eval.c (apply_lambda):
682 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
683 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
684 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
685
a1759b76
PE
686 * callint.c (Fcall_interactively): Don't use index var as event count.
687
d96be9fc
PE
688 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
689 * mem-limits.h (SIZE): Remove; no longer used.
690
a690a978 691 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 692
578c21e6
PE
693 Remove unnecessary casts.
694 * xterm.c (x_term_init):
695 * xfns.c (x_set_border_pixel):
696 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
697 These aren't needed now that we assume ANSI C.
698
96f53c6c
PE
699 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
700 It's more likely to cause problems (due to unsigned overflow)
701 than to cure them.
702
83c77d31
PE
703 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
704
ee2079f1
PE
705 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
706
6da65536
PE
707 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
708
7147c4a4
PE
709 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
710
193e32d9
PE
711 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
712
e5533da6
PE
713 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
714
9910e595
PE
715 GLYPH_CODE_FACE returns EMACS_INT, not int.
716 * dispextern.h (merge_faces):
717 * xfaces.c (merge_faces):
01103c44
PE
718 * xdisp.c (get_next_display_element, next_element_from_display_vector):
719 Don't assume EMACS_INT fits in int.
9910e595 720
2638320e
PE
721 * character.h (CHAR_VALID_P): Remove unused parameter.
722 * fontset.c, lisp.h, xdisp.c: All uses changed.
723
045eb8d9
PE
724 * editfns.c (Ftranslate_region_internal): Omit redundant test.
725
c1f134b5
PE
726 * fns.c (concat): Minor tuning based on overflow analysis.
727 This doesn't fix any bugs. Use int to hold character, instead
728 of constantly refetching from Emacs object. Use XFASTINT, not
729 XINT, for value known to be a character. Don't bother comparing
730 a single byte to 0400, as it's always less.
731
395fcb93 732 * floatfns.c (Fexpt):
327eeec8
PE
733 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
734
abbd3d23
PE
735 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
736 for characters.
737
684a03ef
PE
738 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
739
0fed43f3
PE
740 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
741 Without this fix, on a 64-bit host (aset S 0 4294967386) would
742 incorrectly succeed when S was a string, because 4294967386 was
743 truncated before it was used.
744
8fd02eb7
PE
745 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
746 Otherwise, an out-of-range integer could cause undefined behavior
747 on a 64-bit host.
748
f8c86b69
PE
749 * composite.c: Use int, not EMACS_INT, for characters.
750 (fill_gstring_body, composition_compute_stop_pos): Use int, not
751 EMACS_INT, for values that are known to be in character range.
752 This doesn't fix any bugs but is the usual style inside Emacs and
753 may generate better code on 32-bit machines.
754
34206dd2
PE
755 Make sure a 64-bit char is never passed to ENCODE_CHAR.
756 This is for reasons similar to the recent CHAR_STRING fix.
757 * charset.c (Fencode_char): Check that character arg is actually
758 a character. Pass an int to ENCODE_CHAR.
759 * charset.h (ENCODE_CHAR): Verify that the character argument is no
760 wider than 'int', as a compile-time check to prevent future regressions
761 in this area.
762
c5958d4c 763 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
764
765 Make sure a 64-bit char is never passed to CHAR_STRING.
766 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
767 by silently ignoring the top 32 bits, allowing some values
768 that were far too large to be valid characters.
769 * character.h: Include <verify.h>.
770 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
771 arguments are no wider than unsigned, as a compile-time check
772 to prevent future regressions in this area.
773 * data.c (Faset):
01103c44 774 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
775 (Fsubst_char_in_region):
776 * fns.c (concat):
777 * xdisp.c (decode_mode_spec_coding):
778 Adjust to CHAR_STRING's new requirement.
779 * editfns.c (Finsert_char, Fsubst_char_in_region):
780 * fns.c (concat): Check that character args are actually
781 characters. Without this test, these functions did the wrong
782 thing with wildly out-of-range values on 64-bit hosts.
783
d37ca623
PE
784 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
785 These casts should not be needed on 32-bit hosts, either.
786 * keyboard.c (read_char):
787 * lread.c (Fload): Remove casts to unsigned.
788
ea204efb
PE
789 * lisp.h (UNSIGNED_CMP): New macro.
790 This fixes comparison bugs on 64-bit hosts.
791 (ASCII_CHAR_P): Use it.
792 * casefiddle.c (casify_object):
01103c44 793 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
794 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
795 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
796 * dispextern.h (FACE_FROM_ID):
797 * keyboard.c (read_char): Use UNSIGNED_CMP.
798
41cb286c
PE
799 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
800 not to EMACS_INT, to avoid GCC warning.
801
4a1b9832
PE
802 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
803
55daad71
PE
804 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
805 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
806 isn't needed on 32-bit machines.
8f95c75c 807
01103c44
PE
808 * buffer.c (Fgenerate_new_buffer_name):
809 Use EMACS_INT for count, not int.
0ceccced 810 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
811
812 * data.c (Qcompiled_function): Now static.
813
c6f072e7
PE
814 * window.c (window_body_lines): Now static.
815
20ce5912
PE
816 * image.c (gif_load): Rename local to avoid shadowing.
817
9c4c5f81
PE
818 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
819 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
820 * alloc.c (make_save_value): Integer argument is now of type
821 ptrdiff_t, not int.
822 (mark_object): Use ptrdiff_t, not int.
823 * lisp.h (pD): New macro.
824 * print.c (print_object): Use it.
825
c0c5c8ae
PE
826 * alloc.c: Use EMACS_INT, not int, to count objects.
827 (total_conses, total_markers, total_symbols, total_vector_size)
828 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
829 (total_free_floats, total_floats, total_free_intervals)
830 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
831 Now EMACS_INT, not int. All uses changed.
832 (Fgarbage_collect): Compute overall total using a double, so that
833 integer overflow is less likely to be a problem. Check for overflow
834 when converting back to an integer.
5a25e253
PE
835 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
836 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
837 These were 'int' variables that could overflow on 64-bit hosts;
838 they were never used, so remove them instead of repairing them.
211a0b2a 839 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
840 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
841 Previously, this ceilinged at INT_MAX, but that doesn't work on
842 64-bit machines.
e46bb31a 843 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 844
c78baabf 845 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 846 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
847 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
848 when a (possibly-narrower) signed value would do just as well.
849 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 850
c9d624c6
PE
851 * alloc.c: Catch some string size overflows that we were missing.
852 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
853 for convenience in STRING_BYTES_MAX.
854 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
855 The definition here is exact; the one in lisp.h was approximate.
856 (allocate_string_data): Check for string overflow. This catches
857 some instances we weren't catching before. Also, it catches
858 size_t overflow on (unusual) hosts where SIZE_MAX <= min
859 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
860 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 861
c9d624c6
PE
862 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
863 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
864 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
865
353032ce
PE
866 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
867
2bccce07
PE
868 * alloc.c (Fmake_string): Check for out-of-range init.
869
0ac30604
SM
8702011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
871
872 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
873
c195f2de
JD
8742011-06-14 Jan Djärv <jan.h.d@swipnet.se>
875
876 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
877 xg_get_default_scrollbar_width.
878
879 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
880 (int_gtk_range_get_value): Move to the scroll bar part of the file.
881 (style_changed_cb): Call update_theme_scrollbar_width and call
882 x_set_scroll_bar_default_width and xg_frame_set_char_size for
883 all frames (Bug#8505).
884 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
885 Call gtk_window_set_resizable if HAVE_GTK3.
886 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
887 and height if HAVE_GTK3 (Bug#8505).
888 (scroll_bar_width_for_theme): New variable.
889 (update_theme_scrollbar_width): New function.
890 (xg_get_default_scrollbar_width): Move code to
891 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
892 (xg_initialize): Call update_theme_scrollbar_width.
893
894 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
895
896 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
897
e10ac9f1
MR
8982011-06-12 Martin Rudalics <rudalics@gmx.at>
899
900 * frame.c (make_frame): Call other_buffer_safely instead of
901 other_buffer.
902
903 * window.c (temp_output_buffer_show): Call display_buffer with
904 second argument Vtemp_buffer_show_specifiers and reset latter
905 immediately after the call.
906 (Vtemp_buffer_show_specifiers): New variable.
907 (auto_window_vscroll_p, next_screen_context_lines)
908 (Vscroll_preserve_screen_position): Remove leading asterisks from
909 doc-strings.
910
2d3c217e 9112011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 912
7b7f97e8 913 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
914 * buffer.c (Qclone_number): Remove for now, as it's unused.
915 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
916 (record_buffer): Remove unused local.
917 * frame.c (other_visible_frames, frame_buffer_list): Now static.
918 (set_frame_buffer_list): Remove; unused.
919 * frame.h (other_visible_frames): Remove decl.
920 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
921 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
922 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
923 if HAVE_GPM.
924 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
925 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
926 Define only if HAVE_GPM.
927 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
928 (update_hints_inhibit): Remove; never set. All uses removed.
929 * widgetprv.h (emacsFrameClassRec): Remove decl.
930 * window.c (delete_deletable_window): Now returns void, since it
931 wasn't returning anything.
932 (compare_window_configurations): Remove unused locals.
933 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
934 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
935 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
936 the same widths as pointers. This follows up on the 2011-05-06 patch.
937 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
938 * xterm.h: Likewise.
939 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
940
1384b89e
JB
9412011-06-12 Juanma Barranquero <lekktu@gmail.com>
942
943 * makefile.w32-in: Update dependencies.
944 (LISP_H): Add lib/intprops.h.
945
1100a63c
CY
9462011-06-11 Chong Yidong <cyd@stupidchicken.com>
947
948 * image.c (gif_load): Add animation frame delay to the metadata.
949 (syms_of_image): Use DEFSYM. New symbol `delay'.
950
6198ccd0
MR
9512011-06-11 Martin Rudalics <rudalics@gmx.at>
952
953 * window.c (delete_deletable_window): Re-add.
954 (Fset_window_configuration): Rewrite to handle dead buffers and
955 consequently deletable windows.
956 (window_tree, Fwindow_tree): Remove. Supply functionality in
957 window.el.
958 (compare_window_configurations): Simplify code.
959
b6e3633c
AS
9602011-06-11 Andreas Schwab <schwab@linux-m68k.org>
961
1ab0dee5
AS
962 * image.c (imagemagick_load_image): Fix type mismatch.
963 (Fimagemagick_types): Likewise.
964
b6e3633c
AS
965 * window.h (replace_buffer_in_windows): Declare.
966
9397e56f
MR
9672011-06-11 Martin Rudalics <rudalics@gmx.at>
968
969 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
970 Qclone_number. Remove external declaration of Qdelete_window.
971 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
972 code.
973 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
974 Qbuffer_list_update_hook if allowed.
975 (Fother_buffer): Rewrite doc-string. Major rewrite for new
976 buffer list implementation.
977 (other_buffer_safely): New function.
978 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
979 calls to replace_buffer_in_windows and
980 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
981 if allowed.
982 (record_buffer): Inhibit quitting and rewrite using quittable
983 functions. Run Qbuffer_list_update_hook if allowed.
984 (Frecord_buffer, Funrecord_buffer): New functions.
985 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
986 switch-to-buffer to window.el.
987 (bury-buffer): Move to window.el.
988 (Vbuffer_list_update_hook): New variable.
989
990 * lisp.h (other_buffer_safely): Add prototype in buffer.c
991 section.
992
993 * window.h (resize_frame_windows): Move up in code.
994 (Fwindow_frame): Remove EXFUN.
995 (replace_buffer_in_all_windows): Remove prototype.
996 (replace_buffer_in_windows_safely): Add prototype.
997
998 * window.c: Declare Qdelete_window static again. Move down
999 declaration of select_count.
1000 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1001 (Fother_window): Move to window.el.
1002 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1003 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1004 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1005 window.el.
1006 (replace_buffer_in_windows): Implement by calling
1007 Qreplace_buffer_in_windows.
1008 (replace_buffer_in_all_windows): Remove with some functionality
1009 moved into replace_buffer_in_windows_safely.
1010 (replace_buffer_in_windows_safely): New function.
1011 (select_window_norecord, select_frame_norecord): Move in front
1012 of run_window_configuration_change_hook. Remove now obsolete
1013 declarations.
1014 (Fset_window_buffer): Rewrite doc-string. Call
1015 Qrecord_window_buffer.
1016 (keys_of_window): Move binding for other-window to window.el.
1017
b50691aa
CY
10182011-06-11 Chong Yidong <cyd@stupidchicken.com>
1019
1020 * dispextern.h (struct image): Replace data member, whose int_val
1021 and ptr_val fields were not used by anything, with a single
1022 lisp_val object.
1023
1024 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1025 (gif_clear_image, gif_load, imagemagick_load_image)
1026 (gs_clear_image, gs_load): Callers changed.
1027
3f754b86
PE
10282011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1029
cca69397
PE
1030 * buffer.h: Include <time.h>, for time_t.
1031 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1032
109e28d0
PE
1033 Fix minor problems found by static checking.
1034
60737f02
PE
1035 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1036
4b66faf3
PE
1037 Make identifiers static if they are not used in other modules.
1038 * data.c (Qcompiled_function, Qframe, Qvector):
1039 * image.c (QimageMagick, Qsvg):
1040 * minibuf.c (Qmetadata):
1041 * window.c (resize_window_check, resize_root_window): Now static.
1042 * window.h (resize_window_check, resize_root_window): Remove decls.
1043
109e28d0
PE
1044 * window.c (window_deletion_count, delete_deletable_window):
1045 Remove; unused.
46a4ce9e
PE
1046 (window_body_lines): Now static.
1047 (Fdelete_other_windows_internal): Mark vars as initialized.
1048 Make sure 'resize_failed' is initialized.
1049 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1050 (resize_window_apply): Remove unused local.
1051 * window.h (delete_deletable_window): Remove decl.
1052
109e28d0 1053 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1054 (imagemagick_load_image): Fix pointer signedness problem by changing
1055 last arg from unsigned char * to char *. All uses changed.
1056 Also, fix a local for similar reasons.
1057 Remove unused locals. Remove locals to avoid shadowing.
1058 (fn_rsvg_handle_free): Remove; unused.
1059 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1060 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1061
3f754b86
PE
1062 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1063
2547adb1
CY
10642011-06-10 Chong Yidong <cyd@stupidchicken.com>
1065
1066 * image.c (gif_load): Fix omitted cast error introduced by
1067 2011-06-06 change.
1068
2c8e37d4
MR
10692011-06-10 Martin Rudalics <rudalics@gmx.at>
1070
1071 * window.h (resize_proportionally, orig_total_lines)
1072 (orig_top_line): Remove from window structure.
1073 (set_window_height, set_window_width, change_window_heights)
1074 (Fdelete_window): Remove prototypes.
1075 (resize_frame_windows): Remove duplicate declaration.
1076
440a42e3
EZ
10772011-06-10 Eli Zaretskii <eliz@gnu.org>
1078
1079 * window.h (resize_frame_windows, resize_window_check)
1080 (delete_deletable_window, resize_root_window)
1081 (resize_frame_windows): Declare prototypes.
1082
1083 * window.c (resize_window_apply): Make definition be "static" to
1084 match the prototype.
1085
562dd5e9
MR
10862011-06-10 Martin Rudalics <rudalics@gmx.at>
1087
1088 * window.c: Remove declarations of Qwindow_size_fixed,
1089 window_min_size_1, window_min_size_2, window_min_size,
1090 size_window, window_fixed_size_p, enlarge_window, delete_window.
1091 Remove static from declaration of Qdelete_window, it's
1092 temporarily needed by Fbury_buffer.
1093 (replace_window): Don't assign orig_top_line and
1094 orig_total_lines.
1095 (Fdelete_window, delete_window): Remove. Window deletion is
1096 handled by window.el.
1097 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1098 Fdelete_window calls with calls to Qdelete_window.
1099 (Fdelete_other_windows): Remove. Deleting other windows is
1100 handled by window.el.
1101 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1102 handled in window.el.
1103 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1104 Window minimum sizes are handled in window.el.
1105 (shrink_windows, size_window, set_window_height)
1106 (set_window_width, change_window_heights, window_height)
1107 (window_width, CURBEG, CURSIZE, enlarge_window)
1108 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1109 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1110 handled in window.el.
1111 (make_dummy_parent): Rename to make_parent_window and give it a
1112 second argument horflag.
1113 (make_window): Don't set resize_proportionally any more.
1114 (Fsplit_window): Remove. Windows are split in window.el.
1115 (save_restore_action, save_restore_orig_size)
1116 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1117 Resize mini windows in window.el.
1118 (grow_mini_window, shrink_mini_window): Implement by calling
1119 Qresize_root_window_vertically, resize_window_check and
1120 resize_window_apply.
1121 (saved_window, Fset_window_configuration, save_window_save): Do
1122 not handle orig_top_line, orig_total_lines, and
1123 resize_proportionally.
1124 (window_min_height, window_min_width): Move to window.el.
1125 (keys_of_window): Move bindings for delete-other-windows,
1126 split-window, delete-window and enlarge-window to window.el.
1127
1128 * buffer.c: Temporarily extern Qdelete_window.
1129 (Fbury_buffer): Temporarily call Qdelete_window instead of
1130 Fdelete_window (Fbury_buffer will move to window.el soon).
1131
1132 * frame.c (set_menu_bar_lines_1): Remove code handling
1133 orig_top_line and orig_total_lines.
1134
1135 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1136 set_window_height but set heights directly.
1137 (change_frame_size_1): Use resize_frame_windows.
1138
1139 * xdisp.c (init_xdisp): Don't use set_window_height but set
1140 heights directly.
1141
1142 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1143 resize_frame_windows instead of change_window_heights and run
1144 run_window_configuration_change_hook.
1145
1146 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1147 instead of change_window_heights and run
1148 run_window_configuration_change_hook.
1149
1a13852e
MR
11502011-06-09 Martin Rudalics <rudalics@gmx.at>
1151
1152 * window.c (replace_window): Rename second argument REPLACEMENT to
1153 NEW. New third argument SETFLAG. Rewrite.
1154 (delete_window, make_dummy_parent): Call replace_window with
1155 third argument 1.
1156 (window_list_1): Move down in code.
1157 (run_window_configuration_change_hook): Move set_buffer part
1158 before select_frame_norecord part in order to unwind correctly.
1159 Rename count1 to count.
1160 (recombine_windows, delete_deletable_window, resize_root_window)
1161 (Fdelete_other_windows_internal)
1162 (Frun_window_configuration_change_hook, make_parent_window)
1163 (resize_window_check, resize_window_apply, Fresize_window_apply)
1164 (resize_frame_windows, Fsplit_window_internal)
1165 (Fdelete_window_internal, Fresize_mini_window_internal): New
1166 functions.
1167 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1168
f3d1777e
MR
11692011-06-08 Martin Rudalics <rudalics@gmx.at>
1170
496e208e
MR
1171 * window.h (window): Add some new members to window structure -
1172 normal_lines, normal_cols, new_total, new_normal, clone_number,
1173 splits, nest, prev_buffers, next_buffers.
1174 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1175 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1176
f3d1777e
MR
1177 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1178 Remove.
496e208e
MR
1179 (make_dummy_parent): Set new members of windows structure.
1180 (make_window): Move down in code. Handle new members of window
1181 structure.
1182 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1183 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1184 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1185 (Fset_window_prev_buffers, Fwindow_next_buffers)
1186 (Fset_window_next_buffers, Fset_window_clone_number): New
1187 functions.
1188 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1189 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1190 Doc-string fixes.
1191 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1192 Argument WINDOW can be now internal window too.
1193 (Fwindow_use_time): Move up in code.
1194 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1195 Rewrite doc-string.
1196 (Fset_window_configuration, saved_window)
1197 (Fcurrent_window_configuration, save_window_save): Handle new
1198 members of window structure.
b9e809c2
MR
1199 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1200 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1201 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1202 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1203 Qget_mru_window, Qresize_root_window,
1204 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1205 Qauto_buffer_name; staticpro them.
f3d1777e 1206
abde8f8c
MR
12072011-06-07 Martin Rudalics <rudalics@gmx.at>
1208
1209 * window.c (Fwindow_total_size, Fwindow_left_column)
1210 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1211 (Fwindow_list_1): New functions.
1212 (window_box_text_cols): Replace with window_body_cols.
1213 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1214 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1215 (delete_window, Fset_window_configuration): Call
1216 delete_all_subwindows with window as argument.
1217 (delete_all_subwindows): Take a window as argument and not a
1218 structure. Rewrite.
190b47e6
MR
1219 (window_loop): Remove handling of GET_LRU_WINDOW and
1220 GET_LARGEST_WINDOW.
1221 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1222
1223 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1224 window_box_text_cols. delete_all_subwindows now takes a
1225 Lisp_Object as argument.
abde8f8c
MR
1226
1227 * indent.c (compute_motion, Fcompute_motion): Use
1228 window_body_cols instead of window_box_text_cols.
1229
fa8a67e6
MR
1230 * frame.c (delete_frame): Call delete_all_subwindows with root
1231 window as argument.
1232
a54e3482
DC
12332011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1234
1235 * fns.c (Fputhash): Document return value.
1236
60002bf5
CY
12372011-06-06 Chong Yidong <cyd@stupidchicken.com>
1238
1239 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1240
0c671da6 12412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1242
b862a52a 1243 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1244
be44ca6c
PE
1245 Check for overflow when converting integer to cons and back.
1246 * charset.c (Fdefine_charset_internal, Fdecode_char):
1247 Use cons_to_unsigned to catch overflow.
1248 (Fencode_char): Use INTEGER_TO_CONS.
1249 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1250 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1251 * data.c (long_to_cons, cons_to_long): Remove.
1252 (cons_to_unsigned, cons_to_signed): New functions.
1253 These signal an error for invalid or out-of-range values.
1254 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1255 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1256 * font.c (Ffont_variation_glyphs):
1257 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1258 * lisp.h: Include <intprops.h>.
1259 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1260 (cons_to_signed, cons_to_unsigned): New decls.
1261 (long_to_cons, cons_to_long): Remove decls.
1262 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1263 (Fprimitive_undo): Use CONS_TO_INTEGER.
1264 * xfns.c (Fx_window_property): Likewise.
1265 * xselect.c: Include <limits.h>.
1266 (x_own_selection, selection_data_to_lisp_data):
1267 Use INTEGER_TO_CONS.
1268 (x_handle_selection_request, x_handle_selection_clear)
1269 (x_get_foreign_selection, Fx_disown_selection_internal)
1270 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1271 (lisp_data_to_selection_data): Use cons_to_unsigned.
1272 (x_fill_property_data): Use cons_to_signed.
1273 Report values out of range.
1274
d1f3d2af
PE
1275 Check for buffer and string overflow more precisely.
1276 * buffer.h (BUF_BYTES_MAX): New macro.
1277 * lisp.h (STRING_BYTES_MAX): New macro.
1278 * alloc.c (Fmake_string):
1279 * character.c (string_escape_byte8):
1280 * coding.c (coding_alloc_by_realloc):
1281 * doprnt.c (doprnt):
1282 * editfns.c (Fformat):
1283 * eval.c (verror):
1284 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1285 since they may not be the same number.
1286 * editfns.c (Finsert_char):
1287 * fileio.c (Finsert_file_contents):
1288 Likewise for BUF_BYTES_MAX.
1289
dd52fcea
PE
1290 * image.c: Use ptrdiff_t, not int, for sizes.
1291 (slurp_file): Switch from int to ptrdiff_t.
1292 All uses changed.
1293 (slurp_file): Check that file size fits in both size_t (for
1294 malloc) and ptrdiff_t (for sanity and safety).
1295
7f9bbdbb
PE
1296 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1297 if b->modtime has its maximal value.
1298
dfe18f82
PE
1299 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1300
84acfcf0
PE
1301 Don't assume time_t can fit into int.
1302 * buffer.h (struct buffer.modtime): Now time_t, not int.
1303 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1304 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1305
ccd9a01a
PE
1306 Minor fixes for signed vs unsigned integers.
1307 * character.h (MAYBE_UNIFY_CHAR):
1308 * charset.c (maybe_unify_char):
1309 * keyboard.c (read_char, reorder_modifiers):
1310 XINT -> XFASTINT, since the integer must be nonnegative.
1311 * ftfont.c (ftfont_spec_pattern):
1312 * keymap.c (access_keymap, silly_event_symbol_error):
1313 XUINT -> XFASTINT, since the integer must be nonnegative.
1314 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1315 since it makes no difference and we prefer signed.
1316 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1317 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1318 nonnegative.
1319
d6d100dd
SM
13202011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1321
1322 * window.h (Fwindow_frame): Declare.
1323
2b6148e4
PE
13242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1325
1326 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1327 (SPARE_MEMORY): Always define.
1328 (LARGE_REQUEST): Remove.
1329 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1330
f230ecc9
MR
13312011-06-06 Martin Rudalics <rudalics@gmx.at>
1332
727e958e
MR
1333 * lisp.h: Move EXFUNS for Fframe_root_window,
1334 Fframe_first_window and Fset_frame_selected_window to window.h.
1335
1336 * window.h: Move EXFUNS for Fframe_root_window,
1337 Fframe_first_window and Fset_frame_selected_window here from
1338 lisp.h.
1339
1340 * frame.c (Fwindow_frame, Fframe_first_window)
1341 (Fframe_root_window, Fframe_selected_window)
1342 (Fset_frame_selected_window): Move to window.c.
1343 (Factive_minibuffer_window): Move to minibuf.c.
1344 (Fother_visible_frames_p): New function.
1345
1346 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1347
f230ecc9
MR
1348 * window.c (decode_window, decode_any_window): Move up in code.
1349 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1350 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1351 (Fwindow_buffer): Move up and rewrite doc-string.
1352 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1353 (Fwindow_prev): New functions.
727e958e
MR
1354 (Fwindow_frame): Move here from frame.c. Accept any window as
1355 argument.
1356 (Fframe_root_window, Fframe_first_window)
1357 (Fframe_selected_window): Move here from frame.c. Accept frame
1358 or arbitrary window as argument. Update doc-strings.
1359 (Fminibuffer_window): Move up in code.
1360 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1361 (Fset_frame_selected_window): Move here from frame.c.
1362 Marginal rewrite.
727e958e
MR
1363 (Fselected_window, select_window, Fselect_window): Move up in
1364 code. Minor doc-string fixes.
f230ecc9 1365
4d09bcf6
PE
13662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1367
1368 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1369 Do not assume that spare memory exists; that assumption is valid
1370 only if SYSTEM_MALLOC.
1371 (LARGE_REQUEST): New macro, so that the issue of large requests
1372 is separated from the issue of spare memory.
1373
810928a2
AS
13742011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1375
172418ad
AS
1376 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1377 format. (Bug#8806)
1378
43f862f7
AS
1379 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1380
810928a2
AS
1381 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1382 before statements.
1383
a059fe24
JD
13842011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1385
1386 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1387
1388 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1389
1390 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1391 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1392
989bf368
JB
13932011-06-05 Juanma Barranquero <lekktu@gmail.com>
1394
1395 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1396
4b80f674
CY
13972011-06-04 Chong Yidong <cyd@stupidchicken.com>
1398
1399 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1400 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1401 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1402 New error handlers.
4b80f674
CY
1403 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1404 Obey Vx_select_enable_clipboard_manager. Catch errors in
1405 x_clipboard_manager_save (Bug#8779).
1406 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1407 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1408
99a33b77 14092011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1410
1411 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1412
99a33b77 14132011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1414
1415 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1416 in the current matrix if keep_current_p is non-zero.
1417
8264569d
EZ
14182011-06-04 Eli Zaretskii <eliz@gnu.org>
1419
1420 * bidi.c (bidi_level_of_next_char): Fix last change.
1421
57f97249
EZ
14222011-06-03 Eli Zaretskii <eliz@gnu.org>
1423
fec2107c 1424 Support bidi reordering of text covered by display properties.
57f97249 1425
fec2107c
EZ
1426 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1427 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1428 (bidi_cache_search, bidi_cache_iterator_state)
1429 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1430 (bidi_level_of_next_char, bidi_move_to_visually_next):
1431 Support character positions inside a run of characters covered by a
fec2107c
EZ
1432 display string.
1433 (bidi_paragraph_init, bidi_resolve_explicit_1)
1434 (bidi_level_of_next_char): Call bidi_fetch_char and
1435 bidi_fetch_char_advance instead of FETCH_CHAR and
1436 FETCH_CHAR_ADVANCE.
1437 (bidi_init_it): Initialize new members.
1438 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1439 definitions.
1440 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1441 instead of using explicit *_CHAR codes.
d6d100dd
SM
1442 (bidi_resolve_explicit, bidi_resolve_weak):
1443 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1444 bidirectional text is supported only in multibyte buffers.
1445 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1446 it to initialize the frame_window_p member of struct bidi_it.
1447 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1448 (bidi_resolve_explicit, bidi_resolve_weak)
1449 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1450 bidi_it->nchars is non-positive.
1451 (bidi_level_of_next_char): Don't try to lookup the cache for the
1452 next/previous character if nothing is cached there yet, or if we
1453 were just reseat()'ed to a new position.
c40e2fb2 1454
0e14fe90
EZ
1455 * xdisp.c (set_cursor_from_row): Set start and stop points
1456 according to the row's direction when priming the loop that looks
1457 for the glyph on which to display cursor.
1458 (single_display_spec_intangible_p): Function deleted.
1459 (display_prop_intangible_p): Reimplement to call
1460 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1461 Accept 3 additional arguments needed by handle_display_spec.
1462 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1463 values: lists, `(when COND...)' forms, etc.
1464 (single_display_spec_string_p): Support property values that are
1465 lists with the argument STRING its top-level element.
1466 (display_prop_string_p): Fix the condition for processing a
1467 property that is a list to be consistent with handle_display_spec.
fec2107c 1468 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1469 last portion of handle_display_prop.
1470 (compute_display_string_pos): Accept additional argument
1471 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1472 value of a `display' property is a "replacing spec".
1473 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1474 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1475 the display property, but just return a value indicating whether
1476 the display property will replace the characters it covers.
1477 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1478 frame_window_p members of struct bidi_it.
d6d100dd
SM
1479 (compute_display_string_pos, compute_display_string_end):
1480 New functions.
fec2107c
EZ
1481 (push_it): Accept second argument POSITION, where pop_it should
1482 jump to continue iteration.
1483 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1484
fec2107c
EZ
1485 * keyboard.c (adjust_point_for_property): Adjust the call to
1486 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1487
1488 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1489 (bidi_init_it): Update prototypes.
1490 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1491 (compute_display_string_pos, compute_display_string_end):
1492 Declare prototypes.
fec2107c
EZ
1493 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1494 EMACS_INT.
fc6f18ce 1495
40087514 14962011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1497
57f53182
PE
1498 Malloc failure behavior now depends on size of allocation.
1499 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1500 * lisp.h: Change signatures accordingly.
1501 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1502 All callers changed. (Bug#8762)
1503
1504 * gnutls.c: Use Emacs's memory allocators.
1505 Without this change, the gnutls library would invoke malloc etc.
1506 directly, which causes problems on non-SYNC_INPUT hosts, and which
1507 runs afoul of improving memory_full behavior. (Bug#8761)
1508 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1509 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1510 xfree instead of the default malloc, realloc, free.
1511 (Fgnutls_boot): No need to check for memory allocation failure,
1512 since xmalloc does that for us.
1513
ac32cd99 1514 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1515 * category.c (hash_get_category_set):
1516 * ccl.c (ccl_driver):
1517 * charset.c (Fdefine_charset_internal):
1518 * charset.h (struct charset.hash_index):
1519 * composite.c (get_composition_id, gstring_lookup_cache)
1520 (composition_gstring_put_cache):
1521 * composite.h (struct composition.hash_index):
1522 * dispextern.h (struct image.hash):
1523 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1524 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1525 (hashfn_equal, hashfn_user_defined, make_hash_table)
1526 (maybe_resize_hash_table, hash_lookup, hash_put)
1527 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1528 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1529 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1530 * image.c (make_image, search_image_cache, lookup_image)
1531 (xpm_put_color_table_h):
1532 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1533 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1534 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1535 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1536 * alloc.c (allocate_vectorlike):
1537 Check for overflow in vector size calculations.
1538 * ccl.c (ccl_driver):
1539 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1540 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1541 need to be updated by these changes.
40087514
PE
1542 * fns.c (make_hash_table, maybe_resize_hash_table):
1543 Check for integer overflow with large hash tables.
0de4bb68
PE
1544 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1545 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1546 (SXHASH_REDUCE): New macro.
1547 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1548 Use it instead of discarding useful hash info with large hash values.
1549 (sxhash_float): New function.
1550 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1551 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1552 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1553 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1554 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1555 Adjust signatures to match updated version of code.
1556 (consing_since_gc): Now EMACS_INT, since a single hash table can
1557 use more than INT_MAX bytes.
1558
698d32e2
DN
15592011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1560
1561 Make it possible to build with GCC-4.6+ -O2 -flto.
1562
1563 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1564
fd6fa53f
SM
15652011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1566
1567 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1568 Call minibuffer-inactive-mode.
1569
864db017
JB
15702011-05-31 Juanma Barranquero <lekktu@gmail.com>
1571
1572 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1573 Update dependencies.
1574
2ad0baf4
DN
15752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1576
1577 * data.c (init_data): Remove code for UTS, this system is not
1578 supported anymore.
1579
4fcc2638
DN
15802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1581
1582 Don't force ./temacs to start in terminal mode.
1583
1584 * frame.c (make_initial_frame): Initialize faces in all cases, not
1585 only when CANNOT_DUMP is defined.
1586 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1587
c56e0fd5
DN
15882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1589
1590 * dispnew.c (add_window_display_history): Use const for the string
1591 pointer. Remove declaration, not needed.
1592
333d54da 15932011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1594
55d4c1b2 1595 Use 'inline', not 'INLINE'.
333d54da 1596 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1597 * alloc.c, fontset.c (INLINE): Remove.
1598 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1599 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1600 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1601 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1602 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1603
738db178
DN
16042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1605
1606 Make it possible to run ./temacs.
1607
1608 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1609 syms_of_callproc does the same thing. Remove test for
1610 "initialized", do it in the caller.
1611 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1612
620c53a6
SM
16132011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1614
1615 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1616 (read_minibuf): Use get_minibuffer.
1617 (syms_of_minibuf): Use DEFSYM.
1618 (Qmetadata): New var.
1619 * data.c (Qbuffer): Don't make it static.
1620 (syms_of_data): Use DEFSYM.
1621
e003a292
PE
16222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1623
1624 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1625 (CCL_CODE_MIN): New macro.
1626
ed008a6d
PE
16272011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1628
3687c2ef
PE
1629 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1630
ed008a6d
PE
1631 * eval.c (Qdebug): Now static.
1632 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1633 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1634 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1635
d66c4c7c
CY
16362011-05-29 Chong Yidong <cyd@stupidchicken.com>
1637
1638 * image.c: Various fixes to ImageMagick code comments.
1639 (Fimagemagick_types): Doc fix.
1640
5fbc2025
PE
16412011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1642
0196f88a
PE
1643 Minor fixes prompted by GCC 4.6.0 warnings.
1644
1645 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1646
5fbc2025
PE
1647 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1648 (x_clipboard_manager_save_all): Move extern decl to ...
1649 * xterm.h: ... here, so that it can be checked for consistency.
1650
1dd3c2d9
CY
16512011-05-29 Chong Yidong <cyd@stupidchicken.com>
1652
1653 * xselect.c (x_clipboard_manager_save_frame)
1654 (x_clipboard_manager_save_all): New functions.
1655 (Fx_clipboard_manager_save): Lisp function deleted.
1656
1657 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1658 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1659
1660 * xterm.h: Update prototype.
1661
5ba6571d
WX
16622011-05-28 William Xu <william.xwl@gmail.com>
1663
1664 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1665 exiting (Bug#8239).
1666
3eaff834
JM
16672011-05-28 Jim Meyering <meyering@redhat.com>
1668
e1900994 1669 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1670 * fns.c (to_uchar): Define.
1671 (crypto_hash_function): Use it to convert some newly-signed
1672 variables to unsigned, to avoid sign-extension bugs. For example,
1673 without this change, (md5 "truc") would evaluate to
1674 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1675 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1676 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1677
0f6990a7
PE
16782011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1679
1680 Integer overflow fixes.
c8a9ca5a 1681
08686060
PE
1682 * dbusbind.c: Serial number integer overflow fixes.
1683 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1684 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1685 to hold a serial number that is too large for a fixnum.
1686 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1687 Check for serial numbers out of range. Decode any serial number
59568bf0 1688 that was so large that it became a float. (Bug#8722)
08686060 1689
2d1fc3c7
PE
1690 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1691 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1692 Use XFASTINT rather than XUINT when numbers are nonnegative.
1693 (xd_append_arg, Fdbus_method_return_internal):
1694 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1695 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1696 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1697 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1698 (Bug#8722)
2d1fc3c7 1699
c8a9ca5a
PE
1700 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1701
519e1d69
PE
1702 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1703
30569699
PE
1704 ccl: add integer overflow checks
1705 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1706 (IN_INT_RANGE): New macros.
1707 (ccl_driver): Use them to check for integer overflow when
1708 decoding a CCL program. Many of the new checks are whether XINT (x)
1709 fits in int; it doesn't always, on 64-bit hosts. The new version
1710 doesn't catch all possible integer overflows, but it's an
847044ea 1711 improvement. (Bug#8719)
30569699 1712
c11285dc
PE
1713 * alloc.c (make_event_array): Use XINT, not XUINT.
1714 There's no need for unsigned here.
1715
fdccd48e
PE
1716 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1717 This follows up to the 2011-05-06 change that substituted uintptr_t
1718 for EMACS_INT. This case wasn't caught back then.
1719
37910ab2
PE
1720 Rework Fformat to avoid integer overflow issues.
1721 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1722 now (part of C89). Include <verify.h>.
1723 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1724 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1725 (Fformat): Avoid the prepass trying to compute sizes; it was only
1726 approximate and thus did not catch overflow reliably. Instead, walk
1727 through the format just once, formatting and computing sizes as we go,
1728 checking for integer overflow at every step, and allocating a larger
1729 buffer as needed. Keep track separately whether the format is
1730 multibyte. Keep only the most-recently calculated precision, rather
1731 than them all. Record whether each argument has been converted to
1732 string. Use EMACS_INT, not int, for byte and char and arg counts.
1733 Support field widths and precisions larger than INT_MAX. Avoid
1734 sprintf's undefined behavior with conversion specifications such as %#d
1735 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1736 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1737 formatting out-of-range floating point numbers with int
1738 formats. (Bug#8668)
1739
2e6578fb
PE
1740 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1741
0ae6bdee
PE
1742 * data.c: Avoid integer truncation in expressions involving floats.
1743 * data.c: Include <intprops.h>.
1744 (arith_driver): When there's an integer overflow in an expression
1745 involving floating point, convert the integers to floating point
1746 so that the resulting value does not suffer from catastrophic
1747 integer truncation. For example, on a 64-bit host (* 4
1748 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1749 Do not rely on undefined behavior after integer overflow.
1750
de883a70
PE
1751 merge count_size_as_multibyte, parse_str_to_multibyte
1752 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1753 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1754 Check for integer overflow.
1755 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1756 since it's now a duplicate of the other. This is more of
1757 a character than a buffer op, so better that it's in character.c.
1758 * fns.c, print.c: Adjust to above changes.
1759
2ff916cb
PE
17602011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1761
1762 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1763
f1b54466
PE
17642011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1765
fb1ac845
PE
1766 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1767 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1768 (x_clipboard_manager_save): Now static.
1769 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1770
f1b54466
PE
1771 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1772 (crypto_hash_function): Now static.
1773 Fix pointer signedness problems. Avoid unnecessary initializations.
1774
a9f737ee
CY
17752011-05-27 Chong Yidong <cyd@stupidchicken.com>
1776
1777 * termhooks.h (Vselection_alist): Make it terminal-local.
1778
1779 * terminal.c (create_terminal): Initialize it.
1780
1781 * xselect.c: Support for clipboard managers.
1782 (Vselection_alist): Move to termhooks.h as terminal-local var.
1783 (LOCAL_SELECTION): New macro.
1784 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1785 (symbol_to_x_atom): Remove gratuitous arg.
1786 (x_handle_selection_request, lisp_data_to_selection_data)
1787 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1788 (x_own_selection, x_get_local_selection, x_convert_selection):
1789 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1790 (some_frame_on_display): Delete unused function.
1791 (Fx_own_selection_internal, Fx_get_selection_internal)
1792 (Fx_disown_selection_internal, Fx_selection_owner_p)
1793 (Fx_selection_exists_p): New optional frame arg.
1794 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1795 (x_handle_selection_clear): Don't treat other terminals with the
1796 same keyboard specially. Use the terminal-local Vselection_alist.
1797 (x_clear_frame_selections): Use Frun_hook_with_args.
1798
1799 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1800
1801 * xterm.h: Add support for those atoms.
1802
e067f0c1
CY
18032011-05-26 Chong Yidong <cyd@stupidchicken.com>
1804
1805 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1806 (converted_selections, conversion_fail_tag): New global variables.
1807 (x_selection_request_lisp_error): Free the above.
1808 (x_get_local_selection): Remove unnecessary code.
1809 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1810 of converted selections stored in converted_selections.
1811 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1812 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1813 (x_convert_selection): New function.
1814 (x_handle_selection_event): Simplify.
1815 (x_get_foreign_selection): Don't ignore incoming requests while
1816 waiting for an answer; this will fail when we implement
1817 SAVE_TARGETS, and seems unnecessary anyway.
1818 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1819 (Vx_sent_selection_functions): Doc fix.
1820
0f4aebc0
LL
18212011-05-26 Leo Liu <sdl.web@gmail.com>
1822
1823 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1824
e61124cd
YM
18252011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1826
1827 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1828
1829 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1830 for fringe update if it has periodic bitmap.
1831 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1832 and fringe_bitmap_periodic_p.
1833
1834 * fringe.c (get_fringe_bitmap_data): New function.
1835 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1836 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1837 row. Mark glyph row for fringe update if periodicity changed.
1838
1839 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1840 for fringe update unless it has periodic bitmap.
1841
f16d9837
KH
18422011-05-25 Kenichi Handa <handa@m17n.org>
1843
1844 * xdisp.c (get_next_display_element): Set correct it->face_id for
1845 a static composition.
1846
e1b90ef6
LL
18472011-05-24 Leo Liu <sdl.web@gmail.com>
1848
1849 * deps.mk (fns.o):
1850 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1851
1852 * fns.c (crypto_hash_function, Fsha1): New function.
1853 (Fmd5): Use crypto_hash_function.
1854 (syms_of_fns): Add Ssha1.
1855
7400048f
PE
18562011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1857
1858 * gnutls.c: Remove unused macros.
1859 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1860 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1861 Remove macros that are defined and never used.
1862 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1863
abb71cf4
CY
18642011-05-22 Chong Yidong <cyd@stupidchicken.com>
1865
1866 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1867 (Fx_get_selection_internal): Minor cleanup.
1868 (Fx_own_selection_internal): Rename arguments for consistency with
1869 select.el.
1870
6307db39
PE
18712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1872
1873 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1874
f3d4e0a4
CY
18752011-05-22 Chong Yidong <cyd@stupidchicken.com>
1876
1877 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1878
4d8ade89
YM
18792011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1880
1881 * dispnew.c (scrolling_window): Don't exclude the case that the
1882 last enabled row in the desired matrix touches the bottom boundary.
1883
32078c8d
GM
18842011-05-21 Glenn Morris <rgm@gnu.org>
1885
1886 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1887 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1888 and add some more files.
32078c8d 1889
7285dc67
EZ
18902011-05-20 Eli Zaretskii <eliz@gnu.org>
1891
1892 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1893 report_file_error introduced by the change from 2011-05-07.
1894
89d1bd22
PE
18952011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1896
1897 * systime.h (Time): Define only if emacs is defined.
1898 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1899 where the include path doesn't have X11/X.h by default. See
1900 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1901
e23640bb 19022011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1903
1904 * composite.c (find_automatic_composition): Fix previous change.
1905
b9704ad9
GM
19062011-05-20 Glenn Morris <rgm@gnu.org>
1907
1908 * lisp.mk: New file, split from Makefile.in.
1909 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1910 (shortlisp): Remove.
1911 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1912
4a720484
GM
19132011-05-19 Glenn Morris <rgm@gnu.org>
1914
1915 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1916 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1917 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1918 (lisp): Set the order to that of loadup.el.
1919 (shortlisp): Make it a copy of $lisp.
1920 (SOME_MACHINE_LISP): Remove.
1921 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1922 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1923
a28d4396
KH
19242011-05-18 Kenichi Handa <handa@m17n.org>
1925
1926 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1927 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1928 (find_automatic_composition): Mostly rewrite for efficiency.
1929
a2b1fa8e
JB
19302011-05-18 Juanma Barranquero <lekktu@gmail.com>
1931
1932 * makefile.w32-in: Update dependencies.
1933
8e1f5610
CS
19342011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1935
1936 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1937 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1938
7025ee00 19392011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1940
cdfa6eab
PE
1941 Fix some integer overflow issues, such as string length overflow.
1942
06d6db33
PE
1943 * insdel.c (count_size_as_multibyte): Check for string overflow.
1944
2b4560a8
PE
1945 * character.c (lisp_string_width): Check for string overflow.
1946 Use EMACS_INT, not int, for string indexes and lengths; in
1947 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1948 the resulting string length overflows an EMACS_INT; instead,
1949 report a string overflow if no precision given. When checking for
1950 precision exhaustion, use a check that cannot possibly have
1951 integer overflow. (Bug#8675)
1952 * character.h (lisp_string_width): Adjust to new signature.
1953
cb93f9be
PE
1954 * alloc.c (string_overflow): New function.
1955 (Fmake_string): Use it. This doesn't change behavior, but saves
1956 a few bytes and will simplify future changes.
1957 * character.c (string_escape_byte8): Likewise.
1958 * lisp.h (string_overflow): New decl.
1959
1a1f3366
PE
1960 Fixups, following up to the user-interface timestamp change.
1961 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1962 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1963 * msdos.c (mouse_get_pos): Likewise.
1964 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1965 * w32gui.h (Time): Define by including "systime.h" rather than by
1966 declaring it ourselves. (Bug#8664)
1967
d4e3e4d3
PE
1968 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1969 * image.c (clear_image_cache): Likewise.
1970
f6a24d19
PE
1971 * term.c (term_mouse_position): Don't assume time_t wraparound.
1972
08dc5ae6
PE
1973 Be more systematic about user-interface timestamps.
1974 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1975 and sometimes 'EMACS_UINT', to represent these timestamps.
1976 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1977 This makes the code easier to follow, and makes it easier to catch
1978 integer overflow bugs such as Bug#8664.
1979 * frame.c (Fmouse_position, Fmouse_pixel_position):
1980 Use Time, not unsigned long, for user-interface timestamps.
1981 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1982 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1983 * keyboard.h (last_event_timestamp): Likewise.
1984 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1985 * menu.h (xmenu_show): Likewise.
1986 * term.c (term_mouse_position): Likewise.
1987 * termhooks.h (struct input_event.timestamp): Likewise.
1988 (struct terminal.mouse_position_hook): Likewise.
1989 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1990 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1991 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1992 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1993 what it was before.
1994 * menu.h, termhooks.h: Include "systime.h", for Time.
1995
8e55734a
PE
1996 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1997 Don't assume that the difference between two unsigned long values
1998 can fit into an integer. At this point, we know button_down_time
1999 <= event->timestamp, so the difference must be nonnegative, so
2000 there's no need to cast the result if double-click-time is
2001 nonnegative, as it should be; check that it's nonnegative, just in
2002 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2003 apart (about 25 days). (Bug#8664)
8e55734a 2004
841f1b75 2005 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2006 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2007
3e26f69c
PE
2008 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2009 that always fit in int. Use a sentinel instead of a counter, to
2010 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2011 * frame.h (struct frame): Use int for menu_bar_items_used
2012 instead of EMACS_INT, since it always fits in int.
3e26f69c 2013
5cc152c0
PE
2014 * menu.c (grow_menu_items): Check for int overflow.
2015
d89eb65e
PE
2016 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2017
5235bd3e
PE
2018 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2019 Before, the code was not consistent. These values cannot exceed
2020 2**31 - 1 so there's no need to make them unsigned.
2021 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2022 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2023 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2024 as modifiers.
2025 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2026
bc827e23
PE
2027 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2028 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2029 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2030 presumably because the widths might not match.
2031
78eb494e
PE
2032 * window.c (size_window): Avoid needless test at loop start.
2033
04f2d78b
CB
20342011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2035
2036 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2037
d2fc7e3d 20382011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2039
2040 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2041
d2fc7e3d 20422011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2043
2044 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2045 `width' to `bar_area_x' and `bar_area_width', respectively.
2046 (x_scroll_run): Take account of fringe background extension.
2047
04f2d78b
CB
2048 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2049 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2050 `bar_area_width', respectively.
2051 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2052 background extension.
2053
79b70037
GM
20542011-05-10 Jim Meyering <meyering@redhat.com>
2055
2056 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2057
2f142cc5
JB
20582011-05-10 Juanma Barranquero <lekktu@gmail.com>
2059
2060 * image.c (Finit_image_library): Return t for built-in image types,
2061 like pbm and xbm. (Bug#8640)
2062
57679c86
AS
20632011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2064
2065 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2066
888c9e86
EZ
20672011-05-07 Eli Zaretskii <eliz@gnu.org>
2068
b0512a1d
EZ
2069 * w32console.c (Fset_screen_color): Doc fix.
2070 (Fget_screen_color): New function.
2071 (syms_of_ntterm): Defsubr it.
2072
7285dc67
EZ
2073 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2074 unlink the temporary file if Fcall_process didn't create it in the
2075 first place.
2076 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2077 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2078 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2079 cue to call_process_cleanup not to close that handle.
2080
4d3fcc8e
BK
20812011-05-07 Ben Key <bkey76@gmail.com>
2082
2083 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2084 one of two shell specific rules, either bootstrap-temacs-CMD or
2085 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2086 to the previous implementation of the bootstrap-temacs rule.
2087 The bootstrap-temacs-CMD rule is similar to the previous
2088 implementation of the bootstrap-temacs rule except that it
2089 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2090 variable.
2091
2092 These changes, along with some changes to nt/configure.bat,
2093 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2094 earlier fix to add support for --cflags and --ldflags options
2095 that include quotes so that it works whether make uses cmd or
2096 sh as the shell.
2097
b4289b64
MA
20982011-05-06 Michael Albinus <michael.albinus@gmx.de>
2099
2100 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2101 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2102 is a constant.
2103 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2104 a string. Handle both cases.
2105 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2106 (Fdbus_register_method): Use Qinvalid_function.
2107
af4c0e28
JB
21082011-05-06 Juanma Barranquero <lekktu@gmail.com>
2109
2110 * makefile.w32-in: Update dependencies.
2111 (LISP_H): Add inttypes.h and stdin.h.
2112 (PROCESS_H): Add unistd.h.
2113
c51453d9
EZ
21142011-05-06 Eli Zaretskii <eliz@gnu.org>
2115
2116 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2117 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2118
8ff0ac3c 21192011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2120
4c4b566b
PE
2121 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2122
aab2b9b5
PE
2123 * term.c (vfatal): Remove stray call to va_end.
2124 It's not needed and the C Standard doesn't allow it here anyway.
2125
c378da0b
PE
2126 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2127 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2128
288b08c7
PE
2129 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2130 bytes.
2131
e3601888
PE
2132 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2133
db6c0e74
PE
2134 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2135
dd5963ea
PE
2136 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2137
88c9450f
PE
2138 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2139
2f9442b8
PE
2140 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2141
c032b5f8
PE
2142 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2143 * charset.c (Fdefine_charset_internal): Don't initialize
2144 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2145 32-bit int (Bug#8600).
a108c10b
PE
2146
2147 * lread.c (read_integer): Be more consistent with string-to-number.
2148 Use string_to_number to do the actual conversion; this avoids
2149 rounding errors and fixes some other screwups. Without this fix,
2150 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2151 (digit_to_number): Move earlier, for benefit of read_integer.
2152 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2153 not a digit in any supported base. (Bug#8602)
a108c10b 2154
ad5f9eea
PE
2155 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2156
aec1708a
PE
2157 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2158 to match comment at start of function. This also removes a
2159 GCC warning about overflow in a 32+64-bit port.
2160
47be4ab5
PE
2161 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2162
371cac43
PE
2163 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2164 Reported by Stefan Monnier in
2165 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2166 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2167 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2168
d01a7826
PE
2169 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2170 (EMACS_UINTPTR): Likewise, with uintptr_t.
2171
7fd47d5c
PE
2172 * lisp.h: Prefer 64-bit EMACS_INT if available.
2173 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2174 on 32-bit hosts that have 64-bit int, so that they can access
2175 large files.
122b0c86
PE
2176 However, temporarily disable this change unless the temporary
2177 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2178
8727937b
PE
2179 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2180
8ac068ac
PE
2181 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2182 This removes an assumption that EMACS_INT and long are the same
2183 width as pointers. The assumption is true for Emacs porting targets
2184 now, but we want to make other targets possible.
2185 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2186 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2187 In the rest of the code, change types of integers that hold casted
2188 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2189 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2190 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2191 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2192 No need to cast type when ORing.
2193 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2194 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2195 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2196 assume EMACS_INT is the same width as char *.
2197 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2198 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2199 Remove no-longer-needed casts.
2200 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2201 (xg_tool_bar_help_callback, xg_make_tool_item):
2202 Use EMACS_INTPTR to hold an integer
2203 that will be cast to void *; this can avoid a GCC warning
2204 if EMACS_INT is not the same width as void *.
2205 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2206 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2207 (current_message_1, set_message_1):
2208 Use a local to convert to proper width without a cast.
2209 * xmenu.c (dialog_selection_callback): Likewise.
2210
ede49d71
PE
2211 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2212 Also, don't assume VALBITS / RAND_BITS is less than 5,
2213 and don't rely on undefined behavior when shifting a 1 left into
2214 the sign bit.
2215 * lisp.h (get_random): Change signature to match.
2216
2f30ecd0
PE
2217 * lread.c (hash_string): Use size_t, not int, for hash computation.
2218 Normally we prefer signed values; but hashing is special, because
2219 it's better to use unsigned division on hash table sizes so that
2220 the remainder is nonnegative. Also, size_t is the natural width
2221 for hashing into memory. The previous code used 'int', which doesn't
2222 retain enough info to hash well into very large tables.
2223 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2224
2a866e7b
PE
2225 * dbusbind.c: Don't possibly lose pointer info when converting.
2226 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2227 Use XPNTR rather than XHASH, so that the high-order bits of
2228 the pointer aren't lost when converting through void *.
2229
51639eac
PE
2230 * eval.c (Fautoload): Don't double-shift a pointer.
2231
92394119
PE
2232 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2233
dbdb9a7c
JB
22342011-05-06 Juanma Barranquero <lekktu@gmail.com>
2235
2236 * gnutls.c (DEF_GNUTLS_FN):
2237 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2238
db7a0b4f
AS
22392011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2240
2241 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2242 marker. (Bug#8610)
2243
f7ff1b0f 22442011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2245
2246 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2247 New version that can reserve upto 2GB of heap space.
2248
f7ff1b0f 22492011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2250
2251 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2252
639c109b
TZ
22532011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2254
2255 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2256 `gnutls_certificate_set_x509_key_file'.
2257
d2127135
JB
22582011-05-05 Juanma Barranquero <lekktu@gmail.com>
2259
2260 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2261 Update dependencies.
2262
e968f4f3
JB
22632011-05-04 Juanma Barranquero <lekktu@gmail.com>
2264
2265 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2266 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2267 Remove unused parameter `fildes'.
2268 * process.c (read_process_output, send_process): Don't pass it.
2269
84d358f0
JB
22702011-05-04 Juanma Barranquero <lekktu@gmail.com>
2271
2272 Fix previous change: the library cache is defined in w32.c.
2273 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2274 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2275
0898ca10
JB
22762011-05-04 Juanma Barranquero <lekktu@gmail.com>
2277
2278 Implement dynamic loading of GnuTLS on Windows.
2279
2280 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2281 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2282 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2283 Declare.
2284
2285 * gnutls.c (Qgnutls_dll): Define.
2286 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2287 (gnutls_*): Declare function pointers.
2288 (init_gnutls_functions): New function to initialize function pointers.
2289 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2290 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2291 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2292 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2293 (emacs_gnutls_write, emacs_gnutls_read)
2294 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2295 (Fgnutls_available_p): New function.
2296 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2297 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2298 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2299
2300 * image.c: Include w32.h.
2301 (Vimage_type_cache): Delete.
2302 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2303 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2304 (w32_delayed_load): Move to w32.c.
2305
2306 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2307
2308 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2309 (w32_delayed_load): Move from image.c. When loading a library, record
2310 its filename in the :loaded-from property of the library id.
2311 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2312 Initialize and staticpro them.
2313 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2314
2315 * process.c: Include lisp.h before w32.h, not after.
2316 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2317 instead of gnutls_record_check_pending.
2318
2319 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2320
ff4de4aa
TZ
23212011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2322
2323 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2324 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2325 as passed in.
2326
abe95abb
JD
23272011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2328
2329 * xterm.c (x_set_frame_alpha): Do not set property on anything
2330 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2331
e16e55d4
JB
23322011-05-02 Juanma Barranquero <lekktu@gmail.com>
2333
2334 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2335
bafcf6a5
JB
23362011-05-02 Juanma Barranquero <lekktu@gmail.com>
2337
2338 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2339 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2340 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2341 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2342 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2343 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2344 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2345 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2346 (Qgnutls_bootprop_callbacks_verify): Make static.
2347
e7a6747f
AS
23482011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2349
19ed11ba
AS
2350 * callproc.c: Indentation fixup.
2351
e7a6747f 2352 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2353 (wait_for_termination, interruptible_wait_for_termination):
2354 Move after wait_for_termination_1.
e7a6747f 2355
1ef14cb4
LMI
23562011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2357
2358 * sysdep.c (interruptible_wait_for_termination): New function
2359 which is like wait_for_termination, but allows keyboard
2360 interruptions.
2361
2362 * callproc.c (Fcall_process): Add (:file "file") as an option for
2363 the STDOUT buffer.
2364 (Fcall_process_region): Ditto.
2365
330d880c
EZ
23662011-04-30 Eli Zaretskii <eliz@gnu.org>
2367
8db90b73
EZ
2368 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2369 rather than `XVECTOR (FOO)->size'.
2370
330d880c
EZ
2371 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2372 inttypes.h, as a gnulib replacement is used if it not available in
2373 system headers.
2374
15cbd324
EZ
23752011-04-21 Eli Zaretskii <eliz@gnu.org>
2376
2377 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2378 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2379 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2380
2381 * coding.c (coding_alloc_by_realloc): Error out if destination
2382 will grow beyond MOST_POSITIVE_FIXNUM.
2383 (decode_coding_emacs_mule): Abort if there isn't enough place in
2384 charbuf for the composition carryover bytes. Reserve an extra
2385 space for up to 2 characters produced in a loop.
2386 (decode_coding_iso_2022): Abort if there isn't enough place in
2387 charbuf for the composition carryover bytes.
2388
23892011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2390
ae940cca
EZ
2391 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2392 aborting when %lld or %lll format is passed.
2393 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2394 %llo or %llx format is passed. (Bug#8545)
2395
03ab8921
EZ
2396 * window.c (window_scroll_line_based): Use a marker instead of
2397 simple variables to record original value of point. (Bug#7952)
2398
afda1437
EZ
2399 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2400 produced by %s or %c overflows available buffer space. (Bug#8545)
2401
f76dee0c
PE
24022011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2403
2404 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2405 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2406
fdc5744d
JB
24072011-04-28 Juanma Barranquero <lekktu@gmail.com>
2408
2409 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2410
638f053a
JB
24112011-04-28 Juanma Barranquero <lekktu@gmail.com>
2412
2413 * keyboard.c (Qdelayed_warnings_hook): Define.
2414 (command_loop_1): Run `delayed-warnings-hook'
2415 if Vdelayed_warnings_list is non-nil.
2416 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2417 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2418
d178f871
EZ
24192011-04-28 Eli Zaretskii <eliz@gnu.org>
2420
2421 * doprnt.c (doprnt): Don't return value smaller than the buffer
2422 size if the message was truncated. (Bug#8545).
2423
b124fd93
JB
24242011-04-28 Juanma Barranquero <lekktu@gmail.com>
2425
2426 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2427 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2428
e810457d
PE
24292011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2430
2431 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2432
ea51cceb
JB
24332011-04-27 Juanma Barranquero <lekktu@gmail.com>
2434
2435 * makefile.w32-in: Update dependencies.
2436
94dcfacf
EZ
24372011-04-27 Eli Zaretskii <eliz@gnu.org>
2438
2439 Improve `doprnt' and its usage. (Bug#8545)
2440 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2441 `format_end'. Remove support for %l as a conversion specifier.
2442 Don't use xrealloc. Improve diagnostics when the %l size modifier
2443 is used. Update the commentary.
2444
2445 * eval.c (verror): Simplify calculation of size_t.
2446
2447 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2448 messages.
2449
f61f41d7
PE
24502011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2451
2452 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2453 change.
2454
96fb4434
PE
24552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2456
2457 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2458 This makes this file independent of the recent pseudovector change.
2459
671875da 24602011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2461
69e9b5a3
PE
2462 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2463
b5f869a7 2464 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2465 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2466 Remove unused local.
c8926152 2467 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2468
841a1577 2469 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2470 GCC 4.6.0 optimizes based on type-based alias analysis.
2471 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2472 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2473 != &v->size, and therefore "v->size = 1; b->size = 2; return
2474 v->size;" must therefore return 1. This assumption is incorrect
2475 for Emacs, since it type-puns struct Lisp_Vector * with many other
2476 types. To fix this problem, this patch adds a new type struct
f904488f 2477 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2478 and pseudovectors, and helps optimizing compilers not get fooled
2479 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2480 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2481 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2482 the size member.
eab3844f
PE
2483 (XSETPVECTYPE): Rewrite in terms of new macro.
2484 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2485 This is a bit clearer, and further avoids the possibility of
2486 undesirable aliasing.
2487 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2488 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2489 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2490 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2491 (ASIZE): Now uses header.size rather than size.
2492 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2493 to avoid the hassle of writing XVECTOR (foo)->header.size.
2494 (struct vectorlike_header): New type.
eab3844f
PE
2495 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2496 object, to help avoid aliasing.
2497 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2498 (SUBRP): Likewise, since Lisp_Subr is a special case.
2499 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2500 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2501 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2502 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2503 changed to be "header.size" and "header.next".
2504 * buffer.h (struct buffer): Likewise.
2505 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2506 * frame.h (struct frame): Likewise.
2507 * process.h (struct Lisp_Process): Likewise.
2508 * termhooks.h (struct terminal): Likewise.
2509 * window.c (struct save_window_data, struct saved_window): Likewise.
2510 * window.h (struct window): Likewise.
2511 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2512 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2513 * buffer.c (init_buffer_once): Likewise.
2514 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2515 special case.
2516 * process.c (Fformat_network_address): Use local var for size,
2517 for brevity.
2518
0df1eac5
PE
2519 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2520
847ab9d1 2521 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2522 * data.c (atof): Remove decl; no longer used or needed.
2523 (digit_to_number): Move to lread.c.
2524 (Fstring_to_number): Use new string_to_number function, to be
2525 consistent with how the Lisp reader treats infinities and NaNs.
2526 Do not assume that floating-point numbers represent EMACS_INT
2527 without losing information; this is not true on most 64-bit hosts.
2528 Avoid double-rounding errors, by insisting on integers when
2529 parsing non-base-10 numbers, as the documentation specifies.
2530 * lisp.h (string_to_number): New decl, replacing ...
2531 (isfloat_string): Remove.
bc0a5c13 2532 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2533 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2534 appears to have been a coding error. Similarly, do not accept
2535 strings like +-1e0 as floating point numbers. Do not report
2536 overflow for integer overflows unless the base is not 10 which
2537 means we have no simple and reliable way to continue.
2538 Break out the floating-point parsing into a new
2539 function string_to_number, so that Fstring_to_number parses
2540 floating point numbers consistently with the Lisp reader.
04f2d78b 2541 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2542 (E_CHAR, EXP_INT): Remove, replacing with ...
2543 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2544 (string_to_number): New function, replacing isfloat_string.
2545 This function checks for valid syntax and produces the resulting
2546 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2547 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2548 so that overflow for non-base-10 numbers is reported only when
2549 there's no portable and simple way to convert to floating point.
452f4150 2550
67769ffc
PE
2551 * textprop.c (set_text_properties_1): Rewrite for clarity,
2552 and to avoid GCC warning about integer overflow.
2553
c20db43f
PE
2554 * intervals.h (struct interval): Use EMACS_INT for members
2555 where EMACS_UINT might cause problems. See
2556 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2557 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2558 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2559 All uses changed.
37aa2f85
PE
2560 (offset_intervals): Tell GCC not to worry about length overflow
2561 when negating a negative length.
c20db43f 2562
2538aa2f
PE
2563 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2564 (overrun_check_free): Likewise.
2565
f2d3008d
PE
2566 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2567 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2568 word size.
2569
ec8df744
PE
2570 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2571 (gnutls_make_error): Rename local to avoid shadowing.
2572 (gnutls_emacs_global_deinit): ifdef out; not used.
2573 (Fgnutls_boot): Use const for pointer to readonly storage.
2574 Comment out unused local. Fix pointer signedness problems.
2575
640ee02d
PE
2576 * lread.c (openp): Don't stuff size_t into an 'int'.
2577 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2578 about possible signed overflow.
2579
6048fb2a
PE
2580 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2581 (GDK_KEY_g): Don't define if already defined.
2582 (xg_prepare_tooltip): Avoid pointer signedness problem.
2583 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2584
fa3c87e1
PE
2585 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2586 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2587
2172544b
PE
2588 * xfns.c (Fx_window_property): Simplify a bit,
2589 to make a bit faster and to avoid GCC 4.6.0 warning.
2590 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2591
9b821a21
PE
2592 * fns.c (internal_equal): Don't assume size_t fits in int.
2593
3c616cfa
PE
2594 * alloc.c (compact_small_strings): Tighten assertion a little.
2595
c2982e87
PE
2596 Replace pEd with more-general pI, and fix some printf arg casts.
2597 * lisp.h (pI): New macro, generalizing old pEd macro to other
2598 conversion specifiers. For example, use "...%"pI"d..." rather
2599 than "...%"pEd"...".
2600 (pEd): Remove. All uses replaced with similar uses of pI.
2601 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2602 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2603 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2604 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2605 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2606 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2607 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2608 64-bit hosts.
2609 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2610 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2611 * print.c (safe_debug_print, print_object): Likewise.
2612 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2613 to int.
6f04d126
PE
2614 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2615 avoiding the 0 flag, which is not portable.
c2982e87
PE
2616 * process.c (Fmake_network_process): Use pI to avoid cast.
2617 * region-cache.c (pp_cache): Likewise.
2618 * xdisp.c (decode_mode_spec): Likewise.
2619 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2620 behavior on 64-bit hosts with printf arg.
6f04d126 2621 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2622 (x_stop_queuing_selection_requests): Likewise.
2623 (x_get_window_property): Don't truncate byte count to an 'int'
2624 when tracing.
0b432f21 2625
5e073ec7
PE
2626 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2627 here, since it parses constructs like leading '-' and spaces,
2628 which are not wanted; and it overflows with large numbers.
2629 Instead, simply match F[0-9]+, which is what is wanted anyway.
2630
36372bf9
PE
2631 * alloc.c: Remove unportable assumptions about struct layout.
2632 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2633 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2634 (allocate_vectorlike, make_pure_vector): Use the new macros,
2635 plus offsetof, to remove unportable assumptions about struct layout.
2636 These assumptions hold on all porting targets that I know of, but
2637 they are not guaranteed, they're easy to remove, and removing them
2638 makes further changes easier.
2639
0b432f21
PE
2640 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2641 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2642 (string_overrun_cookie): Now const. Use initializers that
2643 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2644 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2645 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2646 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2647 multiple of sizeof (EMACS_INT); it need not be, if
2648 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2649 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2650
895009e1
JB
26512011-04-26 Juanma Barranquero <lekktu@gmail.com>
2652
2653 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2654
6a7a1b0b
TZ
26552011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2656
2657 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2658 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2659 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2660
841a1577 26612011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2662
2663 * lisp.h (Qdebug): List symbol.
895009e1 2664 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2665 * keyboard.c (debug-on-event): New variable.
2666 (handle_user_signal): Break into debugger when debug-on-event
2667 matches the current signal symbol.
2668
f2d3ba6f
DN
26692011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2670
2671 * alloc.c (check_sblock, check_string_bytes)
2672 (check_string_free_list): Convert to standard C.
2673
42ce4c63
TZ
26742011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2675
2676 * w32.c (emacs_gnutls_push): Fix typo.
2677
825cd63c
EZ
26782011-04-25 Eli Zaretskii <eliz@gnu.org>
2679
fb11d64d
EZ
2680 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2681 "cast to pointer from integer of different size".
2682
825cd63c
EZ
2683 Improve doprnt and its use in verror. (Bug#8545)
2684 * doprnt.c (doprnt): Document the set of format control sequences
2685 supported by the function. Use SAFE_ALLOCA instead of always
2686 using `alloca'.
2687
2688 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2689 is one byte too soon. Don't use xrealloc; instead xfree and
2690 xmalloc anew.
2691
e061a11b
TZ
26922011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2693
2694 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2695 callbacks stage.
2696
2697 * gnutls.c: Renamed global_initialized to
2698 gnutls_global_initialized. Added internals for the
2699 :verify-hostname-error, :verify-error, and :verify-flags
2700 parameters of `gnutls-boot' and documented those parameters in the
2701 docstring. Start callback support.
2702 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2703 unless a fatal error occured. Call gnutls_alert_send_appropriate
2704 on error. Return error code.
2705 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2706 (emacs_gnutls_read): Likewise.
2707 (Fgnutls_boot): Return handshake error code.
2708 (emacs_gnutls_handle_error): New function.
2709 (wsaerror_to_errno): Likewise.
2710
2711 * w32.h (emacs_gnutls_pull): Add prototype.
2712 (emacs_gnutls_push): Likewise.
2713
2714 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2715 (emacs_gnutls_push): Likewise.
2716
27172011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2718
2719 * process.c (wait_reading_process_output): Check if GnuTLS
2720 buffered some data internally if no FDs are set for TLS
2721 connections.
2722
2723 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2724 (LIBS): Link to USER_LIBS.
2725 ($(BLD)/gnutls.$(0)): New target.
2726
fa6996bc
EZ
27272011-04-24 Eli Zaretskii <eliz@gnu.org>
2728
eb35682e
EZ
2729 * xdisp.c (handle_single_display_spec): Rename the
2730 display_replaced_before_p argument into display_replaced_p, to
2731 make it consistent with the commentary. Fix typos in the
2732 commentary.
2733
e2ad650c
EZ
2734 * textprop.c (syms_of_textprop): Remove dead code.
2735 (copy_text_properties): Delete obsolete commentary about an
2736 interface that was deleted long ago. Fix typos in the description
2737 of arguments.
2738
1b2de274
EZ
2739 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2740 to changes in oldXMenu/XMenu.h from 2011-04-16.
2741 <menu_help_message, prev_menu_help_message>: Constify.
2742 (IT_menu_make_room): menu->help_text is now `const char **';
2743 adjust.
2744
2745 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2746 to changes in oldXMenu/XMenu.h from 2011-04-16.
2747 (struct XMenu): Declare `help_text' `const char **'.
2748
2749 * xfaces.c <Qunspecified>: Make extern again.
2750
2751 * syntax.c: Include sys/types.h before including regex.h, as
2752 required by Posix.
2753
762b15be
EZ
2754 * doc.c (get_doc_string): Improve the format passed to `error'.
2755
2756 * doprnt.c (doprnt): Improve commentary.
2757
2758 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2759
2760 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2761 them with etags.
2762
f1052e5d
EZ
2763 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2764 changes in globals.h immediately force recompilation.
762b15be
EZ
2765 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2766 $(CURDIR)/s/ms-w32.h.
2767 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2768
fa6996bc
EZ
2769 * character.c (Fchar_direction): Function deleted.
2770 (syms_of_character): Don't defsubr it.
2771 <char-direction-table>: Deleted.
2772
e6c3da20
EZ
27732011-04-23 Eli Zaretskii <eliz@gnu.org>
2774
2775 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2776 * doprnt.c: Include limits.h.
2777 (SIZE_MAX): New macro.
04f2d78b
CB
2778 (doprnt): Return a size_t value. 2nd arg is now size_t.
2779 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2780 Improve overflow protection. Support `l' modifier for integer
2781 conversions. Support %l conversion. Don't assume an EMACS_INT
2782 argument for integer conversions and for %c.
2783
2784 * lisp.h (doprnt): Restore prototype.
2785
2786 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2787 $(SRC)/character.h.
2788
2789 * Makefile.in (base_obj): Add back doprnt.o.
2790
2791 * deps.mk (doprnt.o): Add back prerequisites.
2792 (callint.o): Depend on character.h.
2793
2794 * eval.c (internal_lisp_condition_case): Include the handler
2795 representation in the error message.
2796 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2797 when breaking from the loop.
2798
2799 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2800
2801 * callint.c (Fcall_interactively): When displaying error message
2802 about invalid control letter, pass the character's codepoint, not
2803 a pointer to its multibyte form. Improve display of the character
2804 in octal and display also its hex code.
2805
2806 * character.c (char_string): Use %x to display the (unsigned)
2807 codepoint of an invalid character, to avoid displaying a bogus
2808 negative value.
2809
2810 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2811 `error', not SYMBOL_NAME itself.
2812
2813 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2814 character arguments to `error'.
2815
2816 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2817 to `error' in error message about FINAL_CHAR argument. Make sure
2818 FINAL_CHAR is a character, and use %c when it is passed as
2819 argument to `error'.
2820
4ffd0d6b 28212011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2822
2823 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2824
2825 * w32.c: Include <time.h>.
2826 (sys_localtime): New function.
2827
4ffd0d6b 28282011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2829
2830 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2831
4ffd0d6b 2832 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2833
4ffd0d6b 28342011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2835
4ffd0d6b
GM
2836 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2837 zombies (Bug#8467).
aac0c6e3 2838
04c56954
EZ
28392011-04-19 Eli Zaretskii <eliz@gnu.org>
2840
2841 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2842 gl_state.e_property when gl_state.object is Qt.
2843
2844 * insdel.c (make_gap_larger): Remove limitation of buffer size
2845 to <= INT_MAX.
2846
16a43933
CY
28472011-04-18 Chong Yidong <cyd@stupidchicken.com>
2848
2849 * xdisp.c (lookup_glyphless_char_display)
2850 (produce_glyphless_glyph): Handle cons cell entry in
2851 glyphless-char-display.
2852 (Vglyphless_char_display): Document it.
2853
2854 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2855 glyphless-char-display.
2856
4581706e
CY
28572011-04-17 Chong Yidong <cyd@stupidchicken.com>
2858
2859 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2860
2861 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2862
2863 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2864 definition for no-X builds.
2865
4887c6e2 28662011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2867
fd35b6f9
PE
2868 Static checks with GCC 4.6.0 and non-default toolkits.
2869
5c1ccb01
PE
2870 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2871
006c5daa
PE
2872 * process.c (keyboard_bit_set): Define only if SIGIO.
2873 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2874 (send_process): Repair possible setjmp clobbering.
2875
efc736d3
PE
2876 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2877
4e2fe2e6
PE
2878 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2879
f97334a2
PE
2880 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2881
4e75f29d
PE
2882 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2883 Define only if needed.
2884
90efadd1
PE
2885 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2886 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2887 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2888
3c647824
PE
2889 * dispextern.h (struct redisplay_interface): Rename param
2890 to avoid shadowing.
e264f262 2891 * termhooks.h (struct terminal): Likewise.
761383f4 2892 * xterm.c (xembed_send_message): Likewise.
3c647824 2893
b58c5c4a
PE
2894 * insdel.c (make_gap_smaller): Define only if
2895 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2896
cad59032
PE
2897 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2898 it.
2899
c339dc2e
PE
2900 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2901 so that we aren't warned about unused symbols.
2902
91a3e27b
PE
2903 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2904
399c71d3 2905 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2906
8ffc96f5
PE
2907 * xfns.c (x_real_positions): Mark locals as initialized.
2908
eef9bc79
PE
2909 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2910
098db9dd
PE
2911 * xterm.c: Fix problems found by static analysis with other toolkits.
2912 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2913 (x_dispatch_event): Declare static if USE_GTK, and
2914 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2915 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2916 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2917 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2918 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2919
eb18f6cc
PE
2920 * xmenu.c (menu_help_callback): Pointer type fixes.
2921 Use const pointers when pointing at readonly data. Avoid pointer
2922 signedness clashes.
2923 (FALSE): Remove unused macro.
2924 (update_frame_menubar): Remove unused decl.
2925
1fe72bf8
PE
2926 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2927
60d9e1db
PE
2928 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2929 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2930 (single_menu_item): Rename local to avoid shadowing.
2931
39261c26
PE
2932 * keyboard.c (make_lispy_event): Remove unused local var.
2933
018c5e19
PE
2934 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2935 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2936
63d2b86e
PE
2937 * bitmaps: Change bitmaps from unsigned char back to the X11
2938 compatible char. Avoid the old compiler warnings about
2939 out-of-range initializers by using, for example, '\xab' rather
2940 than 0xab.
2941
aefd87e1
PE
2942 * xgselect.c (xgselect_initialize): Check vs interface
2943 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2944
bf501fb9
PE
2945 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2946
e9829fdf
PE
2947 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2948 to read-only memory.
2949
1086c095
PE
2950 * fns.c (vector): Remove; this old hack is no longer needed.
2951
2baccd04 2952 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2953 Remove unused var.
dde42981 2954 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2955
72391843 2956 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2957
436c16df 2958 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2959 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2960 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2961
92bb796d 2962 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2963 (x_term_init): Remove local to avoid shadowing.
92bb796d 2964
764430a3 2965 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2966
2967 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2968 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2969
d1dfb56c
EZ
29702011-04-16 Eli Zaretskii <eliz@gnu.org>
2971
c4354cb4
EZ
2972 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2973
d1dfb56c
EZ
2974 Fix regex.c, syntax.c and friends for buffers > 2GB.
2975 * syntax.h (struct gl_state_s): Declare character position members
2976 EMACS_INT.
2977
2978 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2979
04f2d78b
CB
2980 * textprop.c (verify_interval_modification, interval_of):
2981 Declare arguments EMACS_INT.
d1dfb56c
EZ
2982
2983 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2984 EMACS_INT.
2985
2986 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2987
2988 * indent.c (Fvertical_motion): Local variable it_start is now
2989 EMACS_INT.
2990
2991 * regex.c (re_match, re_match_2, re_match_2_internal)
2992 (bcmp_translate, regcomp, regexec, print_double_string)
2993 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2994 (re_compile_pattern, re_exec): Declare arguments and local
2995 variables `size_t' and `ssize_t' and return values `regoff_t', as
2996 appropriate.
2997 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2998 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2999 <compile_stack_type>: `size' and `avail' are now `size_t'.
3000
3001 * regex.h <regoff_t>: Use ssize_t, not int.
3002 (re_search, re_search_2, re_match, re_match_2): Arguments that
3003 specify buffer/string position and length are now ssize_t and
3004 size_t. Return type is regoff_t.
3005
613052cd
BK
30062011-04-16 Ben Key <bkey76@gmail.com>
3007
3008 * nsfont.m: Fixed bugs in ns_get_family and
3009 ns_descriptor_to_entity that were caused by using free to
3010 deallocate memory blocks that were allocated by xmalloc (via
3011 xstrdup). This caused Emacs to crash when compiled with
3012 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3013 --enable-checking=xmallocoverrun). xfree is now used to
3014 deallocate these memory blocks.
3015
4170f62f 30162011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3017
71b41406
PE
3018 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3019
9587a89d
PE
3020 emacs_write: Accept and return EMACS_INT for sizes.
3021 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3022 et seq.
3023 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3024 Accept and return EMACS_INT.
3025 (emacs_gnutls_write): Return the number of bytes written on
3026 partial writes.
3027 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3028 (emacs_read, emacs_write): Remove check for negative size, as the
3029 Emacs source code has been audited now.
9587a89d
PE
3030 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3031 (emacs_read, emacs_write): Use it.
273a5f82
PE
3032 * process.c (send_process): Adjust to the new signatures of
3033 emacs_write and emacs_gnutls_write. Do not attempt to store
3034 a byte offset into an 'int'; it might overflow.
9587a89d 3035 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3036
3e047f51
PE
3037 * sound.c: Don't assume sizes fit in 'int'.
3038 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3039 Return EMACS_INT, not int.
3e047f51 3040 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3041 Accept EMACS_INT, not int.
3042 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3043 record read return values.
3044
cc39a9db
BK
30452011-04-15 Ben Key <bkey76@gmail.com>
3046
c9d0ec6d
JB
3047 * keyboard.c (Qundefined): Don't declare static since it is used
3048 in nsfns.m.
3049 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3050 static since they are used in nsfont.m.
cc39a9db 3051
6c60eb9f
SM
30522011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3053
3054 * process.c (Qprocessp): Don't declare static.
3055 * lisp.h (Qprocessp): Declare again.
3056
7990b61a
JB
30572011-04-15 Juanma Barranquero <lekktu@gmail.com>
3058
3059 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3060
5d4cb038
PE
30612011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3062
8bd7b830 3063 Improve C-level modularity by making more things 'static'.
cd64ea1d 3064
e3b27b31
PE
3065 Don't publish debugger-only interfaces to other modules.
3066 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3067 (verify_bytepos, count_markers): Move decls to the only modules
3068 that need them.
3069 * region-cache.h (pp_cache): Likewise.
3070 * window.h (check_all_windows): Likewise.
3071 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3072
5d4cb038
PE
3073 * sysdep.c (croak): Now static, if
3074 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3075 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3076
3077 * alloc.c (refill_memory_reserve): Now static if
3078 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3079 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3080
e87b6180
PE
3081 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3082 Define only if USE_LUCID.
3083
ac64929e
PE
3084 * xrdb.c (x_customization_string, x_rm_string): Now static.
3085
6f37259d
PE
3086 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3087 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3088
1683e3ab
PE
3089 * xdisp.c (draw_row_with_mouse_face): Now static.
3090 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3091
de9c2632
PE
3092 * window.h (check_all_windows): Mark externally visible.
3093
2b96acb7
PE
3094 * window.c (window_deletion_count): Now static.
3095
3096 * undo.c: Make symbols static if they're not exported.
3097 (last_undo_buffer, last_boundary_position, pending_boundary):
3098 Now static.
3099
50436f33
PE
3100 * textprop.c (interval_insert_behind_hooks): Now static.
3101 (interval_insert_in_front_hooks): Likewise.
3102
64520e5c
PE
3103 * term.c: Make symbols static if they're not exported.
3104 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3105 (max_frame_lines, tty_set_terminal_modes):
3106 (tty_reset_terminal_modes, tty_turn_off_highlight):
3107 (get_tty_terminal): Now static.
3108 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3109 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3110 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3111 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3112 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3113
1fa53021
PE
3114 * sysdep.c: Make symbols static if they're not exported.
3115 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3116 Now static.
3117 (sigprocmask_set, full_mask): Remove; unused.
3118 (wait_debugging): Mark as visible.
3119 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3120 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3121
d4b43b22
PE
3122 * syntax.c (syntax_temp): Define only if !__GNUC__.
3123
b7c513d0
PE
3124 * sound.c (current_sound_device, current_sound): Now static.
3125
989b29ad
PE
3126 * search.c (searchbufs, searchbuf_head): Now static.
3127
13a55a78
PE
3128 * scroll.c (scroll_cost): Remove; unused.
3129 * dispextern.h (scroll_cost): Remove decl.
3130
de68a1fc
PE
3131 * region-cache.h (pp_cache): Mark as externally visible.
3132
40ccffa6
PE
3133 * process.c: Make symbols static if they're not exported.
3134 (process_tick, update_tick, create_process, chan_process):
3135 (Vprocess_alist, proc_buffered_char, datagram_access):
3136 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3137 (deactivate_process): Mark defn as static, as well as decl.
3138 * lisp.h (create_process): Remove decl.
3139 * process.h (chan_process, Vprocess_alist): Remove decls.
3140
ad64fc97
PE
3141 * print.c: Make symbols static if they're not exported.
3142 (print_depth, new_backquote_output, being_printed, print_buffer):
3143 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3144 (print_interval, print_number_index, initial_stderr_stream):
3145 Now static.
3146 * lisp.h (Fprinc): Remove decl.
3147 (debug_output_compilation_hack): Mark as externally visible.
3148
adddb265
PE
3149 * sysdep.c (croak): Move decl from here to syssignal.h.
3150 * syssignal.h (croak): Put it here, so the API can be checked when
3151 'croak' is called from dissociate_if_controlling_tty.
3152
1717ede2
PE
3153 * minibuf.c: Make symbols static if they're not exported.
3154 (minibuf_save_list, choose_minibuf_frame): Now static.
3155 * lisp.h (choose_minibuf_frame): Remove decl.
3156
fa5fb2bc
PE
3157 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3158
1e3890d1
PE
3159 * lread.c: Make symbols static if they're not exported.
3160 (read_objects, initial_obarray, oblookup_last_bucket_number):
3161 Now static.
3162 (make_symbol): Remove; unused.
3163 * lisp.h (initial_obarray, make_symbol): Remove decls.
3164
8a1414fa
PE
3165 * keyboard.c: Make symbols static if they're not exported.
3166 (single_kboard, recent_keys_index, total_keys, recent_keys):
3167 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3168 (this_single_command_key_start, echoing, last_auto_save):
3169 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3170 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3171 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3172 (Vlispy_mouse_stem, double_click_count):
3173 Now static.
3174 (force_auto_save_soon): Define only if SIGDANGER.
3175 (ignore_mouse_drag_p): Now static if
3176 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3177 (print_help): Remove; unused.
3178 (stop_character, last_timer_event): Mark as externally visible.
3179 * keyboard.h (ignore_mouse_drag_p): Declare only if
3180 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3181 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3182 * lisp.h (echoing): Remove decl.
3183 (force_auto_save_soon): Declare only if SIGDANGER.
3184 * xdisp.c (redisplay_window): Simplify code, to make it more
3185 obvious that ignore_mouse_drag_p is not accessed if !defined
3186 USE_GTK && !defined HAVE_NS.
3187
93ea6e8f
PE
3188 * intervals.c: Make symbols static if they're not exported.
3189 (merge_properties_sticky, merge_interval_right, delete_interval):
3190 Now static.
3191 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3192
77382fcc
PE
3193 * insdel.c: Make symbols static if they're not exported.
3194 However, leave prepare_to_modify_buffer alone. It's never
3195 called from outside this function, but that appears to be a bug.
3196 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3197 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3198 (adjust_after_replace_noundo): Remove; unused.
3199 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3200 (signal_before_change): Remove decls.
77382fcc 3201
9306c32e
PE
3202 * indent.c (val_compute_motion, val_vmotion): Now static.
3203
cd44d2eb
PE
3204 * image.c: Make symbols static if they're not exported.
3205 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3206 if USE_GTK.
3207 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3208 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3209
ad9a7a06
PE
3210 * fringe.c (standard_bitmaps): Now static.
3211 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3212
81626931
PE
3213 * frame.c: Make symbols static if they're not exported.
3214 (x_report_frame_params, make_terminal_frame): Now static.
3215 (get_frame_param): Now static, unless HAVE_NS.
3216 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3217 (x_get_resource_string): Remove; not used.
3218 * frame.h (make_terminal_frame, x_report_frame_params):
3219 (x_get_resource_string); Remove decls.
3220 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3221 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3222
239f9db9
PE
3223 * font.c, fontset.c: Make symbols static if they're not exported.
3224 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3225 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3226 * font.c (font_close_object): Now static.
3227 * font.h (font_close_object): Remove.
3228 * fontset.c (FONTSET_OBJLIST): Remove.
3229 (free_realized_fontset) #if-0 the body, which does nothing.
3230 (face_suitable_for_char_p): #if-0, as it's never called.
3231 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3232 * xfaces.c (face_at_string_position):
3233 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3234 since 0 is always ASCII.
3235
dfcf3579
PE
3236 * fns.c (weak_hash_tables): Now static.
3237
5045092b
PE
3238 * fileio.c: Make symbols static if they're not exported.
3239 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3240 (Vwrite_region_annotation_buffers): Now static.
3241
57a96f5c
PE
3242 * eval.c: Make symbols static if they're not exported.
3243 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3244 * lisp.h (backtrace_list): Remove decl.
3245
35f08c38
PE
3246 * emacs.c: Make symbols static if they're not exported.
3247 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3248 (fatal_error_code, fatal_error_signal_hook, standard_args):
3249 Now static.
3250 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3251 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3252 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3253 * lisp.h (fatal_error_signal_hook): Remove decl.
3254 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3255
f44bd759
PE
3256 * editfns.c: Move a (normally-unused) function to its only use.
3257 * editfns.c, lisp.h (get_operating_system_release): Remove.
3258 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3259 worth the hassle of breaking this out.
3260
b532497d
PE
3261 * xterm.c: Make symbols static if they're not exported.
3262 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3263 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3264 (x_destroy_window, x_delete_display):
3265 Now static.
3266 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3267 (x_mouse_leave): Remove; unused.
3268 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3269 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3270 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3271 Remove decls.
3272 (x_mouse_leave): Declare only if WINDOWSNT.
3273 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3274 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3275 USE_X_TOOLKIT.
3276
1675728f
PE
3277 * ftxfont.c: Make symbols static if they're not exported.
3278 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3279 HAVE_FREETYPE.
3280 * font.h (ftxfont_driver): Likewise.
3281
e4cebfca
PE
3282 * xfns.c: Make symbols static if they're not exported.
3283 (x_last_font_name, x_display_info_for_name):
3284 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3285 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3286 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3287 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3288 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3289 (last_show_tip_args): Now static.
3290 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3291 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3292 (x_screen_planes): Remove; unused.
3293 * dispextern.h (x_screen_planes): Remove decl.
3294
5bf46f05
PE
3295 * dispnew.c: Make symbols static if they're not exported.
3296 * dispextern.h (redraw_garbaged_frames, scrolling):
3297 (increment_row_positions): Remove.
3298 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3299 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3300 Now static.
3301 (redraw_garbaged_frames): Remove; unused.
3302
435f4c28
PE
3303 * xfaces.c: Make symbols static if they're not exported.
3304 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3305 Remove decls.
3306 * xterm.h (defined_color): Remove decls.
3307 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3308 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3309 (menu_face_changed_default, defined_color, free_realized_face):
3310 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3311 (ascii_face_of_lisp_face): Remove; unused.
3312
8524aef3
PE
3313 * xdisp.c: Make symbols static if they're not exported.
3314 * dispextern.h (scratch_glyph_row, window_box_edges):
3315 (glyph_to_pixel_coords, set_cursor_from_row):
3316 (get_next_display_element, set_iterator_to_next):
3317 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3318 (show_mouse_face): Remove decls
3319 * frame.h (message_buf_print): Likewise.
3320 * lisp.h (pop_message, set_message, check_point_in_composition):
3321 Likewise.
3322 * xterm.h (set_vertical_scroll_bar): Likewise.
3323 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3324 (message_buf_print, scratch_glyph_row, displayed_buffer):
3325 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3326 (get_next_display_element, show_mouse_face, window_box_edges):
3327 (frame_to_window_pixel_xy, check_point_in_composition):
3328 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3329 (glyph_to_pixel_coords): Remove; unused.
3330
16390cd2
PE
3331 * dired.c (file_name_completion): Now static.
3332
3333 * dbusbind.c (xd_in_read_queued_messages): Now static.
3334
a25f4dfa
PE
3335 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3336 * data.c (circular_list_error): Remove.
3337
14a9c8df
PE
3338 * commands.h (last_point_position, last_point_position_buffer):
3339 (last_point_position_window): Remove decls.
3340 * keyboard.c: Make these variables static.
3341
04f2d78b
CB
3342 * coding.h (coding, code_convert_region, encode_coding_gap):
3343 Remove decls.
74ab6df5
PE
3344 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3345 (iso_code_class, detect_coding, code_convert_region): Now static.
3346 (encode_coding_gap): Remove; unused.
3347
38dfbee1
PE
3348 * chartab.c (chartab_chars, chartab_bits): Now static.
3349
a2cb4e63
PE
3350 * charset.h (charset_iso_8859_1): Remove decl.
3351 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3352 Now static.
3353
127198fd
PE
3354 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3355 * ccl.c (Vccl_program_table): Now static.
3356 (check_ccl_update): Remove; unused.
3357
d85b608f
PE
3358 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3359 * category.h: ... from here.
3360 * category.c (check_category_table, set_category_set): Now static.
3361
31cd66f3
PE
3362 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3363 * lisp.h: Remove these decls.
3364
c358e587
PE
3365 * buffer.c (buffer_count): Remove unused var.
3366
e78aecca
PE
3367 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3368 so that it's not optimized away.
3369 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3370 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3371 exported only to the debugger.
3372
e192d7d3 3373 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3374 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3375
92470028
PE
3376 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3377 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3378 was inaccessible from Lisp.
3379 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3380 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3381
244ed907
PE
3382 alloc.c: Import and export fewer symbols, and remove unused items.
3383 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3384 is defined.
3385 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3386 it's not optimized away by whole-program optimization.
3387 (message_enable_multibyte, free_misc): Remove.
3388 (catchlist, handlerlist, mark_backtrace):
3389 Declare only if BYTE_MARK_STACK.
3390 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3391 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3392 (message_enable_multibyte): Remove decl.
3393 (free_misc, interval_free_list, float_block, float_block_index):
3394 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3395 (cons_free_list, last_marked_index):
3396 Now static.
3397 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3398 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3399 (mark_backtrace): Define only if BYTE_MARK_STACK.
3400 * xdisp.c (message_enable_multibyte): Now static.
3401
61c2b50e 3402 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3403 This makes it easier for human readers (and static analyzers)
3404 to see whether these variables are used from other modules.
3405 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3406 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3407 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3408 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3409 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3410 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3411 * xmenu.c, xselect.c:
3412 Declare Q* vars static if they are not used in other modules.
3413 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3414 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3415 Remove decls of unexported vars.
3416 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3417
95c82688
PE
3418 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3419
16a97296
PE
3420 Make Emacs functions such as Fatom 'static' by default.
3421 This makes it easier for human readers (and static analyzers)
3422 to see whether these functions can be called from other modules.
3423 DEFUN now defines a static function. To make the function external
3424 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3425 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3426 (Finit_image_library):
16a97296
PE
3427 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3428 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3429 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3430 Remove decls, since these functions are now static.
3431 (Funintern, Fget_internal_run_time): New decls, since these functions
3432 were already external.
95c82688 3433
16a97296
PE
3434 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3435 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3436 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3437 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3438 * keyboard.c, keymap.c, lread.c:
3439 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3440 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3441 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3442 Mark functions with DEFUE instead of DEFUN,
3443 if they are used in other modules.
3444 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3445 decls for now-static functions.
3446 * buffer.h (Fdelete_overlay): Remove decl.
3447 * callproc.c (Fgetenv_internal): Mark as internal.
3448 * composite.c (Fremove_list_of_text_properties): Remove decl.
3449 (Fcomposition_get_gstring): New forward static decl.
3450 * composite.h (Fcomposite_get_gstring): Remove decl.
3451 * dired.c (Ffile_attributes): New forward static decl.
3452 * doc.c (Fdocumntation_property): New forward static decl.
3453 * eval.c (Ffetch_bytecode): New forward static decl.
3454 (Funintern): Remove extern decl; now in .h file where it belongs.
3455 * fileio.c (Fmake_symbolic_link): New forward static decl.
3456 * image.c (Finit_image_library): New forward static decl.
3457 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3458 * intervals.h (Fprevious_property_change):
3459 (Fremove_list_of_text_properties): Remove decls.
3460 * keyboard.c (Fthis_command_keys): Remove decl.
3461 (Fcommand_execute): New forward static decl.
3462 * keymap.c (Flookup_key): New forward static decl.
3463 (Fcopy_keymap): Now static.
3464 * keymap.h (Flookup_key): Remove decl.
3465 * process.c (Fget_process): New forward static decl.
3466 (Fprocess_datagram_address): Mark as internal.
3467 * syntax.c (Fsyntax_table_p): New forward static decl.
3468 (skip_chars): Remove duplicate decl.
3469 * textprop.c (Fprevious_property_change): New forward static decl.
3470 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3471 Now internal.
3472 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3473 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3474
785bbd42
PE
3475 * editfns.c (Fformat): Remove unreachable code.
3476
8b913b57
AS
34772011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3478
3479 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3480 change. (Bug#8496)
3481
a6744a35
EZ
34822011-04-13 Eli Zaretskii <eliz@gnu.org>
3483
3484 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3485 when at ZV. (Bug#8487)
3486
e7974947
AS
34872011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3488
baad03f0
AS
3489 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3490 (Bug#8437)
3491 * keyboard.c (parse_tool_bar_item): Likewise.
3492 * sound.c (sound_cleanup, alsa_close): Likewise.
3493 * termcap.c (tgetent): Likewise.
3494 * xfns.c (x_default_font_parameter): Likewise.
3495 * xsettings.c (read_and_apply_settings): Likewise.
3496
e7974947
AS
3497 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3498 (overrun_check_free): Protoize.
3499
28272684
PE
35002011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3501
3502 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3503 since callers should never pass a negative size.
3504 Change the signature to match that of plain 'read' and 'write'; see
3505 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3506 * lisp.h: Update prototypes of emacs_write and emacs_read.
3507
11997c76
EZ
35082011-04-11 Eli Zaretskii <eliz@gnu.org>
3509
3510 * xdisp.c (redisplay_window): Don't try to determine the character
3511 position of the scroll margin if the window start point w->startp
e896f03c 3512 is outside the buffer's accessible region. (Bug#8468)
11997c76 3513
8a2cbd72
EZ
35142011-04-10 Eli Zaretskii <eliz@gnu.org>
3515
3516 Fix write-region and its subroutines for buffers > 2GB.
3517 * fileio.c (a_write, e_write): Modify declaration of arguments and
3518 local variables to support buffers larger than 2GB.
3519 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3520
3521 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3522 argument, local variables, and return value.
3523
3524 * lisp.h: Update prototypes of emacs_write and emacs_read.
3525
3526 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3527
4073e537 35282011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3529
1ebfdcb6
PE
3530 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3531
b2ded58d
PE
3532 Fix more problems found by GCC 4.6.0's static checks.
3533
7d66342c
PE
3534 * xdisp.c (vmessage): Use a better test for character truncation.
3535
bbf47d44
PE
3536 * charset.c (load_charset_map): <, not <=, for optimization,
3537 and to avoid potential problems with integer overflow.
9248994d 3538 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3539 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3540 * editfns.c (Fformat): Likewise.
1e69125e 3541 * syntax.c (skip_chars): Likewise.
3befa583 3542
e3019616
PE
3543 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3544 This also lets GCC 4.6.0 generate slightly better loop code.
3545
becfa255
PE
3546 * callint.c (Fcall_interactively): <, not <=, for optimization.
3547 (Fcall_interactively): Count the number of arguments produced,
3548 not the number of arguments given. This is simpler and lets GCC
3549 4.6.0 generate slightly better code.
3550
dae0cd48
PE
3551 * ftfont.c: Distingish more carefully between FcChar8 and char.
3552 The previous code passed unsigned char * to a functions like
3553 strlen and xstrcasecmp that expect char *, which does not
3554 conform to the C standard.
3555 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3556 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3557 char * when the C standard requires it.
3558
76032d70
PE
3559 * keyboard.c (read_char): Remove unused var.
3560
eb3f1cc8
PE
3561 * eval.c: Port to Windows vsnprintf (Bug#8435).
3562 Include <limits.h>.
3563 (SIZE_MAX): Define if the headers do not.
3564 (verror): Do not give up if vsnprintf returns a negative count.
3565 Instead, grow the buffer. This ports to Windows vsnprintf, which
3566 does not conform to C99. Problem reported by Eli Zaretskii.
3567 Also, simplify the allocation scheme, by avoiding the need for
3568 calling realloc, and removing the ALLOCATED variable.
3569
70476b54
PE
3570 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3571
12020a9e
PE
3572 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3573 But keep the doprint source code for now, as we might revamp it
3574 and use it again (Bug#8435).
ea6c7ae6
PE
3575 * lisp.h (doprnt): Remove.
3576 * Makefile.in (base_obj): Remove doprnt.o.
3577 * deps.mk (doprnt.o): Remove.
3578
5fdb398c
PE
3579 error: Print 32- and 64-bit integers portably (Bug#8435).
3580 Without this change, on typical 64-bit hosts error ("...%d...", N)
3581 was used to print both 32- and 64-bit integers N, which relied on
3582 undefined behavior.
3583 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3584 New macro.
3585 * lisp.h (error, verror): Mark as printf-like functions.
3586 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3587 Report overflow in size calculations when allocating printf buffer.
3588 Do not truncate output string at its first null byte.
3589 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3590 Truncate the output at a character boundary, since vsnprintf does not
3591 do that.
3592 * charset.c (check_iso_charset_parameter): Convert internal
3593 character to string before calling 'error', since %c now has the
3594 printf meaning.
3595 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3596 overflow when computing char to be passed to 'error'. Do not
3597 pass Lisp_Object to 'error'; pass the integer instead.
3598 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3599 formatted with plain %d.
3600
b189fa66
PE
3601 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3602
bff87ef0
PE
3603 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3604
7e2cac20
PE
3605 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3606
ce4d90b5
PE
3607 * xterm.c (x_catch_errors): Remove duplicate declaration.
3608
266c9547
PE
3609 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3610
79c49ad2
PE
3611 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3612
368f4090
JM
36132011-04-10 Jim Meyering <meyering@redhat.com>
3614
3615 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3616 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3617 return ssize_t not "int", and use size_t as the buffer length.
3618 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3619 * gnutls.h: Update declarations.
3620 * process.c (read_process_output): Use ssize_t, to match.
3621 (send_process): Likewise.
3622
a32d4040
CY
36232011-04-09 Chong Yidong <cyd@stupidchicken.com>
3624
3625 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3626
8546720e 36272011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3628
04f2d78b
CB
3629 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3630 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3631
8546720e
GM
3632 * xterm.c (handle_one_xevent):
3633 * xmenu.c (create_and_show_popup_menu):
3634 * xselect.c (x_decline_selection_request)
3635 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3636
0a2f5c1a 36372011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3638
3639 Fix some uses of `int' instead of EMACS_INT.
3640 * search.c (string_match_1, fast_string_match)
3641 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3642 (scan_buffer, find_next_newline_no_quit)
3643 (find_before_next_newline, search_command, Freplace_match)
3644 (Fmatch_data): Make some `int' variables be EMACS_INT.
3645
3646 * xdisp.c (display_count_lines): 3rd argument and return value now
3647 EMACS_INT. All callers changed.
3648 (pint2hrstr): Last argument is now EMACS_INT.
3649
3650 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3651 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3652 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3653 (decode_coding_utf_16, decode_coding_emacs_mule)
3654 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3655 (decode_coding_ccl, decode_coding_charset)
3656 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3657 (decode_coding_iso_2022, decode_coding_emacs_mule)
3658 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3659 <char_offset, last_offset>: Declare EMACS_INT.
3660 (encode_coding_utf_8, encode_coding_utf_16)
3661 (encode_coding_emacs_mule, encode_invocation_designation)
3662 (encode_designation_at_bol, encode_coding_iso_2022)
3663 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3664 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3665 Declare EMACS_INT.
3666 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3667 (encode_invocation_designation): Last argument P_NCHARS is now
3668 EMACS_INT.
3669 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3670 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3671
3672 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3673 All users changed.
3674
3675 * ccl.c (Fccl_execute_on_string): Declare some variables
3676 EMACS_INT.
3677
8546720e 36782011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3679
3680 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3681
4e19a977
CS
36822011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3683
3684 * process.c (Fformat_network_address): Doc fix.
3685
87302331
R
36862011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3687
3688 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3689
cbb59342
CY
36902011-04-08 Chong Yidong <cyd@stupidchicken.com>
3691
3692 * keyboard.c (read_char): Call Lisp function help-form-show,
3693 instead of using internal_with_output_to_temp_buffer.
3694 (Qhelp_form_show): New var.
e0d38eeb 3695 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3696
3697 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3698
3699 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3700
e67a13ab
CY
37012011-04-06 Chong Yidong <cyd@stupidchicken.com>
3702
04f2d78b
CB
3703 * process.c (Flist_processes): Remove to Lisp.
3704 (list_processes_1): Delete.
e67a13ab 3705
973f782d
EZ
37062011-04-06 Eli Zaretskii <eliz@gnu.org>
3707
7c106b1e
EZ
3708 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3709
973f782d
EZ
3710 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3711
41cf7d1a 37122011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3713
ca23cc88
PE
3714 Fix more problems found by GCC 4.6.0's static checks.
3715
f390e2d5
PE
3716 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3717
42eea0d0
PE
3718 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3719
b69769da 3720 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3721
f9541e84
PE
3722 * xdisp.c (vmessage): Mark as a printf-like function.
3723
13841b55
PE
3724 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3725
c136c10f
PE
3726 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3727
5e2d4a30
PE
3728 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3729 printf-like functions.
3730 (tiff_load): Add casts to remove these marks before passing them
3731 to system-supplied API.
3732
583f48b9
PE
3733 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3734
b25d760e
PE
3735 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3736 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3737 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3738 directly, rather than having caller test rule sign. This avoids
3739 some unnecessary tests.
3740 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3741 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3742 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3743
bc7b6697 3744 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3745 (xfont_open): Avoid unnecessary tests.
bc7b6697 3746
27ccc379
PE
3747 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3748
dcd5c89a
PE
3749 * composite.h, composite.c (composition_gstring_put_cache):
3750 Use EMACS_INT, not int, for length.
3751
b13a45c6
PE
3752 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3753 breaking out part of COMPOSITION_DECODE_RULE.
3754 (COMPOSITION_DECODE_RULE): Use it.
3755 * composite.c (get_composition_id): Remove unused local vars,
3756 by using the new macro.
3757
1e792e4d
PE
3758 * textprop.c (set_text_properties_1): Change while to do-while,
3759 since the condition is always true at first.
3760
dc6c6455 3761 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3762 (interval_deletion_adjustment): Return unsigned value.
3763 All uses changed.
dc6c6455 3764
aba7731a
PE
3765 * process.c (list_processes_1, create_pty, read_process_output):
3766 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3767 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3768 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3769 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3770 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3771
fdfc4bf3
PE
3772 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3773
fca8fe46 3774 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3775 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3776
06a0259a 3777 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3778 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3779 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3780
e7b9e80f
PE
3781 * print.c (print_error_message): Avoid int overflow.
3782
56201685
PE
3783 * font.c (font_list_entities): Redo for clarity,
3784 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3785
78834453 3786 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3787 (font_score): Avoid potential overflow in diff calculation.
78834453 3788
0bc0b309 3789 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3790 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3791
e610eaca
PE
3792 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3793
b895abce
PE
3794 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3795 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3796 can always succeed if overflow has undefined behavior.
3797
1f1d9321 3798 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3799 (wordify): Omit three unnecessary tests.
1f1d9321 3800
c59478bc
PE
3801 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3802 All callers changed. This avoids the need for an unused var.
3803
79b73827
PE
3804 * casefiddle.c (casify_region): Remove var that is set but not used.
3805
a4db5dfe
PE
3806 * dired.c (file_name_completion): Remove var that is set but not used.
3807
43aae36e
PE
3808 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3809
2a47c44d 3810 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3811 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3812
a37c69bf
PE
3813 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3814 Check for integer overflow on size calculations.
3815
328ab8e7
PE
3816 * buffer.c (Fprevious_overlay_change): Remove var that is set
3817 but not used.
3818
e5a2a5cb
PE
3819 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3820 Remove vars that are set but not used.
8d84a6eb 3821 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3822 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3823
a60e5f68
PE
3824 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3825
f661cb61 3826 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3827 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3828
f0397f5a
PE
3829 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3830 that are set but not used.
3831
8664db06 3832 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3833 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3834
6abdaa4a
PE
3835 * xselect.c (x_get_local_selection, x_handle_property_notify):
3836 Remove vars that are set but not used.
3837
0ce7538d 3838 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3839 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3840
9ae848fc
PE
3841 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3842 Remove var that is set but not used.
0b918413
PE
3843 (scroll_bar_windows_size): Now size_t, not int.
3844 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3845 Check for overflow.
9ae848fc 3846
a5a62657
PE
3847 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3848 (map_tty_color) [!defined MSDOS]: Likewise.
3849
5c5cdd39
PE
3850 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3851
66ebf983
PE
3852 * coding.c: Remove vars that are set but not used.
3853 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3854 All callers changed.
3855 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3856 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3857 (decode_coding_charset): Remove vars that are set but not used.
3858
1be4d761
PE
3859 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3860 that is set but not used.
3861
47553fa8
PE
3862 * print.c (print_object): Remove var that is set but not used.
3863
1f7196bf 3864 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3865 The gnulib version avoids calling malloc in the usual case,
3866 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3867 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3868 * filelock.c (current_lock_owner): Likewise.
3869 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3870 * sysdep.c: Include allocator.h, careadlinkat.h.
3871 (emacs_no_realloc_allocator): New static constant.
3872 (emacs_readlink): New function.
fdb61804
PE
3873 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3874 ../lib/careadlinkat.h.
d1fdcab7 3875
f84c17c7
SM
38762011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3877
3878 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3879 first non-nil return value).
3880
ef3862ad
JD
38812011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3882
3883 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3884 if not defined (Bug#8403).
3885
376a7006
JB
38862011-04-02 Juanma Barranquero <lekktu@gmail.com>
3887
3888 * xdisp.c (display_count_lines): Remove parameter `start',
3889 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3890 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3891 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3892 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3893 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3894 and thereabouts. All callers changed.
3895 (get_per_char_metric): Remove parameter `f', unused since
3896 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3897
6ca3801d
JM
38982011-04-02 Jim Meyering <meyering@redhat.com>
3899
3900 do not dereference NULL upon failed strdup
3901 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3902 (ns_get_family): Likewise.
3903
d8e2b5ba
JB
39042011-04-02 Juanma Barranquero <lekktu@gmail.com>
3905
3906 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3907
8c74fcbd
JD
39082011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3909
3910 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3911 later (Bug#8403).
3912
7200d79c
SM
39132011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3914
03408648 3915 Add lexical binding.
7200d79c 3916
03408648
SM
3917 * window.c (Ftemp_output_buffer_show): New fun.
3918 (Fsave_window_excursion):
3919 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3920
3921 * lread.c (lisp_file_lexically_bound_p): New function.
3922 (Fload): Bind Qlexical_binding.
3923 (readevalloop): Remove `evalfun' arg.
3924 Bind Qinternal_interpreter_environment.
3925 (Feval_buffer): Bind Qlexical_binding.
3926 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3927 Mark as dynamic.
3928 (syms_of_lread): Declare `lexical-binding'.
3929
3930 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3931
3932 * keyboard.c (eval_dyn): New fun.
3933 (menu_item_eval_property): Use it.
ca105506
SM
3934
3935 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3936
03408648
SM
3937 * fns.c (concat, mapcar1): Accept byte-code-functions.
3938
3939 * eval.c (Fsetq): Handle lexical vars.
3940 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3941 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3942 (FletX, Flet): Obey lexical binding.
3943 (Fcommandp): Handle closures.
3944 (Feval): New `lexical' arg.
3945 (eval_sub): New function extracted from Feval. Use it almost
3946 everywhere where Feval was used. Look up vars in lexical env.
3947 Handle closures.
3948 (Ffunctionp): Move from subr.el.
3949 (Ffuncall): Handle closures.
3950 (apply_lambda): Remove `eval_flags'.
3951 (funcall_lambda): Handle closures and new byte-code-functions.
3952 (Fspecial_variable_p): New function.
3953 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3954 but without exporting it to Lisp.
23aba0ea 3955
23aba0ea 3956 * doc.c (Fdocumentation, store_function_docstring):
03408648 3957 * data.c (Finteractive_form): Handle closures.
23aba0ea 3958
03408648
SM
3959 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3960 interactive spec.
ba83908c 3961
04f2d78b
CB
3962 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3963 New byte-codes.
03408648
SM
3964 (exec_byte_code): New function extracted from Fbyte_code to handle new
3965 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3966
03408648 3967 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3968
03408648 3969 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3970
e2abce01
JB
39712011-03-31 Juanma Barranquero <lekktu@gmail.com>
3972
3973 * xdisp.c (redisplay_internal): Fix prototype.
3974
63696a73 39752011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3976
63696a73 3977 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3978 (try_scrolling): Use it when setting scroll_limit.
3979 Limit scrolling to 100 screen lines.
63696a73
EZ
3980 (redisplay_window): Even when falling back on "recentering",
3981 position point in the window according to scroll-conservatively,
3982 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3983
3984 (try_scrolling): When point is above the window, allow searching
3985 as far as scroll_max, or one screenful, to compute vertical
3986 distance from PT to the scroll margin position. This prevents
3987 try_scrolling from unnecessarily failing when
3988 scroll-conservatively is set to a value slightly larger than the
3989 window height. Clean up the case of PT below the margin at bottom
3990 of window: scroll_max can no longer be INT_MAX. When aggressive
3991 scrolling is in use, don't let point enter the opposite scroll
3992 margin as result of the scroll.
3993 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3994 threshold of 100 lines for never-recentering scrolling.
3995
e4cc2dfc
JB
39962011-03-31 Juanma Barranquero <lekktu@gmail.com>
3997
3998 * dispextern.h (move_it_by_lines):
3999 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4000 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4001 (message_log_check_duplicate): Remove parameters `prev_bol' and
4002 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4003 (redisplay_internal): Remove parameter `preserve_echo_area',
4004 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4005
4006 * indent.c (Fvertical_motion):
4007 * window.c (window_scroll_pixel_based, Frecenter):
4008 Don't pass `need_y_p' to `move_it_by_lines'.
4009
1c470562
SM
40102011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4011
44f230aa
SM
4012 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4013 steal a few bits to be more compact.
4014 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4015 Remove unneeded casts.
4016
1c470562
SM
4017 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4018
888adce9
ZK
40192011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4020
4021 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4022 binding" message (bug#7967).
4023
f838ed7b
PE
40242011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4025
77861b95
PE
4026 Fix more problems found by GCC 4.6.0's static checks.
4027
de6dbc14
PE
4028 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4029 Remove unused local var.
4030
f838ed7b
PE
4031 * editfns.c (Fmessage_box): Remove unused local var.
4032
792c7b2b
PE
4033 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4034 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4035 Omit unused local vars.
c499e557 4036 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4037 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4038 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4039 Omit unused local var.
4040
ba0165e1
PE
4041 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4042 Don't assume string length fits in int.
32ad8845 4043 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4044 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4045
3c59b4c9
PE
4046 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4047 instead of alloca (Bug#8344).
4048
a3eed478 4049 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4050 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4051
eb4d412d
PE
4052 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4053
1658b401
PE
4054 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4055 concerns.
4056
4057 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4058
4059 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4060
9a2c6e05
PE
4061 * keyboard.c (syms_of_keyboard): Use the same style as later
4062 in this function when indexing through an array. This also
4063 works around GCC bug 48267.
4064
03d0a109
PE
4065 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4066
44f730c8
PE
4067 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4068
fe75f926
PE
4069 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4070 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4071
ffa8c828
PE
4072 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4073 This avoids undefined behavior on integer overflow, and is a bit
4074 more convenient anyway since it is compared to a size_t variable.
4075
c5101a77
PE
4076 Variadic C functions now count arguments with size_t, not int.
4077 This avoids an unnecessary limitation on 64-bit machines, which
4078 caused (substring ...) to crash on large vectors (Bug#8344).
4079 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4080 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4081 All variadic functions and their callers changed accordingly.
c5101a77
PE
4082 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4083 * data.c (arith_driver, float_arith_driver): Likewise.
4084 * editfns.c (general_insert_function): Likewise.
4085 * eval.c (struct backtrace.nargs, interactive_p)
4086 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4087 (funcall_lambda, mark_backtrace): Likewise.
4088 * fns.c (concat): Likewise.
4089 * frame.c (x_set_frame_parameters): Likewise.
4090 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4091 0 if not found, not -1. All callers changed.
4092
dd3f25f7
PE
4093 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4094 (stack_copy_size): Now size_t, not int.
4095 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4096
461c2ab9
JB
40972011-03-28 Juanma Barranquero <lekktu@gmail.com>
4098
4099 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4100 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4101 All callers changed.
4102
4103 * lisp.h (multibyte_char_to_unibyte):
4104 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4105 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4106 * character.h (CHAR_TO_BYTE8):
4107 * cmds.c (internal_self_insert):
4108 * editfns.c (general_insert_function):
4109 * keymap.c (push_key_description):
4110 * search.c (Freplace_match):
4111 * xdisp.c (message_dolog, set_message_1): All callers changed.
4112
f6d62986
SM
41132011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4114
4115 * keyboard.c (safe_run_hook_funcall): New function.
4116 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4117 don't set the hook to nil, but remove the offending function instead.
4118 (Qcommand_hook_internal): Remove, unused.
4119 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4120 Vcommand_hook_internal.
4121
4122 * eval.c (enum run_hooks_condition): Remove.
4123 (funcall_nil, funcall_not): New functions.
4124 (run_hook_with_args): Call each function through a `funcall' argument.
4125 Remove `cond' argument, now redundant.
4126 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4127 (Frun_hook_with_args_until_failure): Adjust accordingly.
4128 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4129
1db5b1ad
JB
41302011-03-28 Juanma Barranquero <lekktu@gmail.com>
4131
4132 * dispextern.h (string_buffer_position): Remove declaration.
4133
4134 * print.c (strout): Remove parameter `multibyte', unused since
4135 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4136
4137 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4138 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4139 All callers changed.
4140
4141 * w32.c (_wsa_errlist): Use braces for struct initializers.
4142
4143 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4144 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4145 All callers changed.
4146 (string_buffer_position): Likewise. Also, make static (it's never
4147 used outside xdisp.c).
4148 (cursor_row_p): Remove parameter `w', unused since
4149 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4150 (decode_mode_spec): Remove parameter `precision', introduced during
4151 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4152 All callers changed.
4153
5ffb62aa
JD
41542011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4155
4156 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4157
461c2ab9 41582011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4159
4160 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4161 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4162 (ns_update_auto_hide_menu_bar): New functions.
4163 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4164 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4165 ns_constrain_all_frames.
4166 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4167 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4168
5c380ffb
JD
41692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4170
4171 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4172
9af30bdf
GM
41732011-03-27 Glenn Morris <rgm@gnu.org>
4174
4175 * syssignal.h: Replace RETSIGTYPE with void.
4176 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4177 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4178 Replace SIGTYPE with void everywhere.
4179 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4180 * s/template.h (SIGTYPE): Remove commented out definition.
4181
e2abce01
JB
41822011-03-26 Eli Zaretskii <eliz@gnu.org>
4183
4184 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4185 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4186
f868cd8a
JB
41872011-03-26 Juanma Barranquero <lekktu@gmail.com>
4188
59eb0929
JB
4189 * w32.c (read_unc_volume): Use parameter `henum', instead of
4190 global variable `wget_enum_handle'.
4191
4192 * keymap.c (describe_vector): Remove parameters `indices' and
4193 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4194 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4195
f868cd8a
JB
4196 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4197
4198 * keyboard.c (timer_check): Remove parameter `do_it_now',
4199 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4200 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4201 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4202
4203 * keyboard.c (read_char):
4204 * w32menu.c (w32_menu_display_help):
4205 * xmenu.c (show_help_event, menu_help_callback):
4206 Adjust calls to `show_help_echo'.
4207
4208 * gtkutil.c (xg_maybe_add_timer):
4209 * keyboard.c (readable_events):
4210 * process.c (wait_reading_process_output):
4211 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4212
4213 * insdel.c (adjust_markers_gap_motion):
4214 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4215 (gap_left, gap_right): Don't call it.
4216
2ecf6fdb
CY
42172011-03-25 Chong Yidong <cyd@stupidchicken.com>
4218
4219 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4220 incurred during fontification.
4221
6b1f9ba4
JB
42222011-03-25 Juanma Barranquero <lekktu@gmail.com>
4223
4224 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4225 (DEFVAR_PER_BUFFER): Don't pass it.
4226
4227 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4228 (scrolling_window): Don't pass it.
4229
0f4a96b5
JB
42302011-03-25 Juanma Barranquero <lekktu@gmail.com>
4231
4232 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4233
4234 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4235 and `suffix'.
4236 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4237 of variables specific to SELinux and computation of `encoded_absname'.
4238
4239 * image.c (XPutPixel): Remove unused variable `height'.
4240
4241 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4242
4243 * unexw32.c (get_section_info): Remove unused variable `section'.
4244
4245 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4246 (system_process_attributes): Remove unused variable `sess'.
4247 (sys_read): Remove unused variable `err'.
4248
4249 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4250 (w32_wnd_proc): Remove unused variable `isdead'.
4251 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4252 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4253 (x_create_tip_frame): Remove unused variable `tem'.
4254
4255 * w32inevt.c (w32_console_read_socket):
4256 Remove unused variable `no_events'.
4257
4258 * w32term.c (x_draw_composite_glyph_string_foreground):
4259 Remove unused variable `width'.
4260
1149507c
JB
42612011-03-24 Juanma Barranquero <lekktu@gmail.com>
4262
4263 * w32term.c (x_set_glyph_string_clipping):
4264 Don't pass uninitialized region to CombineRgn.
4265
9c88f339
JB
42662011-03-23 Juanma Barranquero <lekktu@gmail.com>
4267
4268 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4269 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4270 (Fx_close_connection): Remove unused variable `i'.
4271
4272 * w32font.c (w32font_draw): Return number of glyphs.
4273 (w32font_open_internal): Remove unused variable `i'.
4274 (w32font_driver): Add missing initializer.
4275
4276 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4277 (fill_in_menu): Remove unused variable `items_added'.
4278
4279 * w32term.c (last_mouse_press_frame): Remove static global variable.
4280 (w32_clip_to_row): Remove unused variable `f'.
4281 (x_delete_terminal): Remove unused variable `i'.
4282
4283 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4284 (NOTHING): Remove unused static global variable.
4285 (uniscribe_check_otf): Remove unused variable `table'.
4286 (uniscribe_font_driver): Add missing initializers.
4287
dee091a3
JD
42882011-03-23 Julien Danjou <julien@danjou.info>
4289
4290 * term.c (Fsuspend_tty, Fresume_tty):
4291 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4292 * window.c (temp_output_buffer_show):
4293 * insdel.c (signal_before_change):
4294 * frame.c (Fhandle_switch_frame):
4295 * fileio.c (Fdo_auto_save):
4296 * emacs.c (Fkill_emacs):
4297 * editfns.c (save_excursion_restore):
4298 * cmds.c (internal_self_insert):
4299 * callint.c (Fcall_interactively):
4300 * buffer.c (Fkill_all_local_variables):
4301 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4302 Use Frun_hooks.
0f4a96b5 4303 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4304 unconditionnaly since it does the check itself.
4305
2c520ab5 43062011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4307
c9c49752
PE
4308 Fix more problems found by GCC 4.5.2's static checks.
4309
8abc3f12
PE
4310 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4311 the first time through the loop, since we know p0 < p1 then.
4312 This also avoids a gcc -Wstrict-overflow warning.
4313
a2d26660
PE
4314 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4315 leading to a memory leak, possible in functions like
4316 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4317 of objects (Bug#8318).
a2d26660 4318
916c72e9
PE
4319 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4320 that could (at least in theory) be that large.
4321
19ab8a18
PE
4322 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4323 This is less likely to overflow, and avoids undefined behavior if
4324 overflow does occur. All callers changed. Use strtoul to scan
4325 for the unsigned long integer.
b7cbbd6f
PE
4326 (pint2hrstr): Simplify and tune code slightly.
4327 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4328
f0641eff
PE
4329 * scroll.c (do_scrolling): Work around GCC bug 48228.
4330 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4331
7f650bb9
PE
4332 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4333 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4334 (validate_x_resource_name): Simplify count usage.
4335 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4336
37dd57d1
PE
4337 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4338 fail (Bug#8306).
81e56e61 4339
699979fc 4340 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4341
401bf9b4
PE
4342 * process.c (Fmake_network_process): Use socklen_t, not int,
4343 where POSIX says socklen_t is required in portable programs.
4344 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4345 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4346 (Fmake_network_process, server_accept_connection):
4347 (wait_reading_process_output, read_process_output):
4348 Likewise.
4349
b93aacde
PE
4350 * process.c: Rename or move locals to avoid shadowing.
4351 (list_processes_1, Fmake_network_process):
4352 (read_process_output_error_handler, exec_sentinel_error_handler):
4353 Rename or move locals.
4dc343ee 4354 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4355 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4356 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4357 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4358 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4359
af8a867c 4360 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4361 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4362 Include tparam.h instead, since it declares them.
af8a867c
PE
4363 * cm.h (PC): Remove extern decl; tparam.h now does this.
4364 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4365 * terminfo.c: Include tparam.h, to check interfaces.
4366 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4367 (tparam): Adjust signature to match interface in tparam.h;
4368 this removes some undefined behavior. Check that outstring and len
4369 are zero, which they always are with Emacs.
4370 * tparam.h (PC, BC, UP): New extern decls.
4371
0248044d 4372 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4373 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4374
8ff096c1 4375 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4376 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4377 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4378 (ftfont_list): Remove unused local.
49eaafba
PE
4379 (get_adstyle_property, ftfont_pattern_entity):
4380 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4381 Rename locals to avoid shadowing.
8ff096c1 4382
e2be39f6
PE
4383 * xfont.c (xfont_list_family): Mark var as initialized.
4384
c9735e30
PE
4385 * xml.c (make_dom): Now static.
4386
8f5201ae
PE
4387 * composite.c (composition_compute_stop_pos): Rename local to
4388 avoid shadowing.
b246f932
PE
4389 (composition_reseat_it): Remove unused locals.
4390 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4391 (composition_update_it): Mark var as initialized.
11b61122
PE
4392 (find_automatic_composition): Mark vars as initialized,
4393 with a FIXME (Bug#8290).
8f5201ae 4394
760fbc2c
PE
4395 character.h: Rename locals to avoid shadowing.
4396 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4397 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4398 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4399 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4400 to avoid shadowing.
4401
ff08eb85
PE
4402 * textprop.c (property_change_between_p): Remove; unused.
4403
fc7bf025
PE
4404 * intervals.c (interval_start_pos): Now static.
4405
235d7abc
PE
4406 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4407
44f230aa
SM
4408 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4409 Rename locals to avoid shadowing.
3e7d6594 4410
50060332
PE
4411 * sound.c (wav_play, au_play, Fplay_sound_internal):
4412 Fix pointer signedness.
d01f234b 4413 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4414 (wav_play): Initialize a variable to 0, to prevent undefined
4415 behavior (Bug#8278).
50060332 4416
c4fc4e30
PE
4417 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4418
918436ed
PE
4419 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4420
c939f91b
PE
4421 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4422 clobbering (Bug#8298).
b9c7f648
PE
4423 * sysdep.c (sys_subshell): Likewise.
4424 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4425
6bd8c144
PE
4426 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4427 This should get cleaned up, so that child_setup has the
4428 same signature on all platforms.
4429
7710357c 4430 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4431 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4432
c59da222
CY
44332011-03-22 Chong Yidong <cyd@stupidchicken.com>
4434
4435 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4436 not to be necessary, and produces flickering.
4437
66b87493
GM
44382011-03-20 Glenn Morris <rgm@gnu.org>
4439
4440 * config.in: Remove file.
4441
45b6f6d5
JB
44422011-03-20 Juanma Barranquero <lekktu@gmail.com>
4443
4444 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4445 are now in src/globals.h.
4446 (syms_of_minibuf): Remove spurious & from previous change.
4447
3ec03f7e
LL
44482011-03-20 Leo <sdl.web@gmail.com>
4449
4450 * minibuf.c (completing-read-function): New variable.
4451 (completing-read-default): Rename from completing-read.
4452 (completing-read): Call completing-read-function.
4453
b14e3e21
CY
44542011-03-19 Juanma Barranquero <lekktu@gmail.com>
4455
4456 * xfaces.c (Fx_load_color_file):
4457 Read color file from absolute filename (bug#8250).
4458
f2b726e6
JB
44592011-03-19 Juanma Barranquero <lekktu@gmail.com>
4460
4461 * makefile.w32-in: Update dependencies.
4462
09f6ff02
EZ
44632011-03-17 Eli Zaretskii <eliz@gnu.org>
4464
4465 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4466
29a6015a
PE
44672011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4468
a3a6c54e
PE
4469 Fix more problems found by GCC 4.5.2's static checks.
4470
b766f867
PE
4471 * process.c (make_serial_process_unwind, send_process_trap):
4472 (sigchld_handler): Now static.
4473
be02381c
PE
4474 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4475 That way, the code declares only the vars that it needs.
4476 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4477 * s/cygwin.h (PTY_ITERATION): Likewise.
4478 * s/darwin.h (PTY_ITERATION): Likewise.
4479 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4480
57048744
PE
4481 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4482 * process.c (allocate_pty): Don't declare stb unless it's needed.
4483
7914961c 4484 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4485 (CONSTANTLIM): Remove; unused.
4486 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4487 Define only if needed.
7914961c 4488
b3967b18
PE
4489 * unexelf.c (unexec): Name an expression,
4490 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4491 Use a different way to cause a compilation error if anyone uses
4492 n rather than nn, a way that does not involve shadowing.
73366a00 4493 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4494
29a6015a
PE
4495 * deps.mk (unexalpha.o): Remove; unused.
4496
43cfc33e 4497 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4498 * unexec.h: New file.
ce701a33
PE
4499 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4500 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4501 Depend on unexec.h.
4502 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4503 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4504 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4505 Change as necessary to match prototype in unexec.h.
ce701a33 4506
01f44d5a
PE
4507 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4508 shadowing.
4f63c6bb 4509 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4510
a6670b0b
PE
4511 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4512 Rename locals to avoid shadowing.
4513
cef2010d 4514 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4515 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4516
d4d7173a
PE
4517 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4518
f08b802a
PE
4519 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4520 warning when compiling print.c.
4521
3ddb0639
PE
4522 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4523 instead of using an uninitialized var.
5ad03b97 4524 (font_sort_entities): Mark var as initialized.
3ddb0639 4525
170a2692
PE
4526 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4527
e663c700
PE
4528 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4529 pointers to constants.
89bc529a 4530 (font_parse_fcname): Remove unused vars.
7b81e2d0 4531 (font_delete_unmatched): Now static.
ea838e10 4532 (font_get_spec): Remove; unused.
13a547c6
PE
4533 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4534 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4535 Rename or move locals to avoid shadowing.
e663c700 4536
2a80c887 4537 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4538 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4539
1384fa33 4540 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4541 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4542
8b2c52e9
PE
4543 * alloc.c (mark_backtrace): Move decl from here ...
4544 * lisp.h: ... to here, so that it can be checked.
4545
475545b5 4546 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4547 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4548 (lisp_indirect_variable): Name an expression,
4549 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4550 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4551
b1349114 4552 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4553 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4554 Use const pointer when appropriate.
b1349114 4555
a2928364
PE
4556 * lisp.h (get_system_name, get_operating_system_release):
4557 Move decls here, to check interfaces.
4558 * process.c (get_operating_system_release): Move decl to lisp.h.
4559 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4560 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4561 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4562 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4563 (Fformat_time_string, Fencode_time, Finsert_char):
4564 (Ftranslate_region_internal, Fformat):
4565 Rename or remove local vars to avoid shadowing.
9710023e 4566 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4567
a415e694
PE
4568 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4569 avoid shadowing.
4570
8ef4622d
PE
4571 * lisp.h (eassert): Check that the argument compiles, even if
4572 ENABLE_CHECKING is not defined.
4573
946f9a5b
PE
4574 * data.c (Findirect_variable): Name an expression, to avoid
4575 gcc -Wbad-function-cast warning.
112396d6 4576 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4577 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4578 (Fmake_variable_buffer_local, Fmake_local_variable):
4579 Mark variables as initialized.
52746918 4580 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4581
e5aab7e7 4582 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4583 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4584 Rename locals to avoid shadowing.
dff45157
PE
4585 (mark_stack): Move local variables into the #ifdef region where
4586 they're used.
7bc26fdb
PE
4587 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4588 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4589 needed otherwise.
4590 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4591 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4592 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4593
e5aab7e7
PE
4594 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4595 avoids undefined behavior in theory.
4596
4da60324
PE
4597 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4598
88043301
PE
4599 Use functions, not macros, for up- and down-casing (Bug#8254).
4600 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4601 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4602 to use the following functions instead of these macros.
4603 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4604 EMACS_INT, since callers assume the returned value fits in int.
4605 (upcase1): Likewise, for UPCASE_TABLE.
4606 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4607 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4608 the race-condition problem in the old DOWNCASE.
88043301 4609
19ed5445
PE
4610 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4611 Rename locals to avoid shadowing.
4612 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4613 (regex_compile, re_search_2, re_match_2_internal):
4614 Remove unused local vars.
952db0d7
PE
4615 (FREE_VAR): Rewrite so as not to use empty "else",
4616 which gcc can warn about.
da053e48 4617 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4618 (RETALLOC_IF): Define only if needed.
4619 (WORDCHAR_P): Likewise. This one is never needed, but is used
4620 only in a comment talking about a compiler bug, so put inside
4621 the #if 0 of that comment.
4622 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4623 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4624 Remove; unused.
19ed5445 4625
1f3561e4 4626 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4627 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4628 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4629
ded6f8f7
PE
4630 * search.c (simple_search): Remove unused var.
4631
dbd37a95
PE
4632 * dired.c (compile_pattern): Move decl from here ...
4633 * lisp.h: ... to here, so that it can be checked.
4634 (struct re_registers): New forward decl.
4635
7e47afad
PE
4636 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4637
85f24f61
PE
4638 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4639 All uses changed.
4640 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4641 Rename locals to avoid shadowing.
5671df8f 4642 (Fvertical_motion): Mark locals as initialized.
85f24f61 4643
181aa2be 4644 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4645 (casify_region): Mark local as initialized.
181aa2be 4646
930d429c
PE
4647 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4648
7082eac6
PE
4649 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4650 New macros, so that the caller can use some names other than
4651 gcpro1, gcpro2, etc.
4652 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4653 of the new macros.
4654 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4655 argument, for consistency with GCPRO2_VAR, etc: it is now the
4656 prefix of the variable, not the variable itself. All uses
4657 changed.
38b2c076
PE
4658 * dired.c (directory_files_internal, file_name_completion):
4659 Rename locals to avoid shadowing.
4660
15206ed9
PE
4661 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4662 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4663 dired.c's scmp function, had undefined behavior.
4664 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4665 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4666 * buffer.h: ... to here, because these macros use current_buffer,
4667 and the new implementation with inline functions needs to have
4668 current_buffer in scope now, rather than later when the macros
4669 are used.
4670 (downcase, upcase1): New static inline functions.
4671 (DOWNCASE, UPCASE1): Reimplement using these functions.
4672 This avoids undefined behavior in expressions like
4673 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4674 from race conditions in accessing the global variables
4675 case_temp1 and case_temp2.
4676 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4677 * lisp.h (case_temp1, case_temp2): Remove their decls.
4678 * character.h (ASCII_CHAR_P): Move from here ...
4679 * lisp.h: ... to here, so that the inline functions mentioned
4680 above can use them.
4681
4a6bea26
PE
4682 * dired.c (directory_files_internal_unwind): Now static.
4683
f14b7e14
PE
4684 * fileio.c (file_name_as_directory, directory_file_name):
4685 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4686 Now static.
2893f146
PE
4687 (file_name_as_directory): Use const pointers when appropriate.
4688 (Fexpand_file_name): Likewise. In particular, newdir might
4689 point at constant storage, so make it a const pointer.
fd4ead52 4690 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4691 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4692 signedness issues.
f839df0c
PE
4693 (Fset_file_times, Finsert_file_contents, auto_save_error):
4694 Rename locals to avoid shadowing.
f14b7e14 4695
5716756e 4696 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4697 (Ftry_completion, Fall_completions): Rename or remove locals
4698 to avoid shadowing.
5716756e 4699
b4c3046a
PE
4700 * marker.c (bytepos_to_charpos): Remove; unused.
4701
b45db522
PE
4702 * lisp.h (verify_bytepos, count_markers): New decls,
4703 so that gcc does not warn that these functions aren't declared.
4704
85876d07
PE
4705 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4706 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4707 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4708 (copy_text): Remove unused local var.
85876d07 4709
03d78a21 4710 * filelock.c (within_one_second): Now static.
b3dd38ab 4711 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4712
5df8f01b
PE
4713 * buffer.c (fix_overlays_before): Mark locals as initialized.
4714 (fix_start_end_in_overlays): Likewise. This function should be
4715 simplified by using pointers-to-pointers, but that's a different
4716 matter.
b1d876f1 4717 (switch_to_buffer_1): Now static.
8f54f30a
PE
4718 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4719 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4720
a70072c9 4721 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4722 Fix pointer signedness issue.
edced198
PE
4723 (sys_subshell): Mark local as volatile if checking for lint,
4724 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4725 (MAXPATHLEN): Define only if needed.
a70072c9 4726
a0977c44
PE
4727 * process.c (serial_open, serial_configure): Move decls from here ...
4728 * systty.h: ... to here, so that they can be checked.
4729
a884fdcc
PE
4730 * fns.c (get_random, seed_random): Move extern decls from here ...
4731 * lisp.h: ... to here, so that they can be checked.
4732
604efe86 4733 * sysdep.c (reset_io): Now static.
b8950c94 4734 (wait_for_termination_signal): Remove; unused.
604efe86 4735
38fc62d9
PE
4736 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4737 (copy_keymap_item, append_key, push_text_char_description):
4738 Now static.
1004a21a 4739 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4740 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4741 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4742 (describe_map_tree):
4743 Rename locals to avoid shadowing.
38fc62d9 4744
2f2650da
PE
4745 * keyboard.c: Declare functions static if they are not used elsewhere.
4746 (echo_char, echo_dash, cmd_error, top_level_2):
4747 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4748 (read_char, kbd_buffer_get_event, make_lispy_position):
4749 (make_lispy_event, make_lispy_movement, apply_modifiers):
4750 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4751 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4752 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4753 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4754 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4755
a053e86c 4756 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4757 (mark_kboards): Move decl here ...
4758 * alloc.c (mark_kboards): ... from here.
a053e86c 4759
4752793e
PE
4760 * lisp.h (force_auto_save_soon): New decl.
4761
74f10ca7 4762 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4763 (DEFINE_DUMMY_FUNCTION): New macro.
4764 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4765 Use it.
c03cd23f
PE
4766 (main): Add casts to avoid warnings
4767 if GCC considers string literals to be constants.
74f10ca7 4768
022e70d4
PE
4769 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4770
59d6fe83
PE
4771 * dbusbind.c: Pointer signedness fixes.
4772 (xd_signature, xd_append_arg, xd_initialize):
4773 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4774 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4775 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4776 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4777
78320123
PE
4778 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4779 if GCC considers string literals to be constants.
49cebcca 4780 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4781
35ac2a97
SM
47822011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4783
fb103ca9
SM
4784 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4785 (print_preprocess, print_object): New macro to fix last change.
4786
35ac2a97
SM
4787 * print.c (print_preprocess): Don't forget font objects.
4788
62973b41
JB
47892011-03-16 Juanma Barranquero <lekktu@gmail.com>
4790
4791 * emacs.c (USAGE3): Doc fixes.
4792
0e48bb22
AS
47932011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4794
4795 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4796 structure.
4797
7684e57b
JB
47982011-03-14 Juanma Barranquero <lekktu@gmail.com>
4799
4800 * lisp.h (VWindow_system, Qfile_name_history):
4801 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4802 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4803 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4804
4805 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4806 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4807
4808 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4809 * w32console.c (detect_input_pending, read_input_pending)
4810 (encode_terminal_code):
4811 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4812 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4813 (w32_system_caret_y, Qfile_name_history):
4814 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4815 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4816 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4817 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4818 * w32proc.c (Qlocal, report_file_error):
4819 * w32term.c (Vwindow_system, updating_frame):
4820 * w32uniscribe.c (initialized, uniscribe_font_driver):
4821 Remove unneeded extern declarations.
4822
2aa46d6c
CY
48232011-03-14 Chong Yidong <cyd@stupidchicken.com>
4824
c96bbc66 4825 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4826
cffc6f3b
CY
48272011-03-13 Chong Yidong <cyd@stupidchicken.com>
4828
4829 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4830 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4831 These macros can no longer be used for assignment.
4832
44f230aa
SM
4833 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4834 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4835 (record_buffer_markers, fetch_buffer_markers): New functions for
4836 recording and fetching special buffer markers.
4837 (set_buffer_internal_1, set_buffer_temp): Use them.
4838
4839 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4840
4841 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4842
4843 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4844 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4845
4846 * xdisp.c (hscroll_window_tree):
4847 (reconsider_clip_changes): Use PT instead of BUF_PT.
4848
d251f04b
EZ
48492011-03-13 Eli Zaretskii <eliz@gnu.org>
4850
4851 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4852 $(EMACS_ROOT)/lib/intprops.h.
4853
f0c77cd1
PE
48542011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4855
3eca4629
PE
4856 Fix more problems found by GCC 4.5.2's static checks.
4857
7c86ee98
PE
4858 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4859 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4860 (xg_free_frame_widgets): Make it clear that a local variable is
4861 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4862 (gdk_window_get_screen): Make it clear that this macro is needed
4863 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4864 (int_gtk_range_get_value): New function, which avoids a diagnostic
4865 from gcc -Wbad-function-cast.
4866 (xg_set_toolkit_scroll_bar_thumb): Use it.
4867 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4868 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4869 (get_utf8_string, xg_get_file_with_chooser):
4870 Rename locals to avoid shadowing.
4871 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4872
41729b81
PE
4873 * xgselect.c (xg_select): Remove unused var.
4874
f0c77cd1
PE
4875 * image.c (four_corners_best): Mark locals as initialized.
4876 (gif_load): Initialize transparent_p to zero (Bug#8238).
4877 Mark another local as initialized.
ec6cf4c6 4878 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4879
ce0ad53d 4880 * image.c (clear_image_cache): Now static.
d5d5a617 4881 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4882 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4883 (x_edge_detection): Remove unnecessary cast that
4884 gcc -Wbad-function-cast diagnoses.
2037898d 4885 (gif_load): Fix pointer signedness.
6ae141d6
PE
4886 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4887 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4888
33383987 48892011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4890
d32df629
PE
4891 Improve quality of tests for time stamp overflow.
4892 For example, without this patch (encode-time 0 0 0 1 1
4893 1152921504606846976) returns the obviously-bogus value (-948597
4894 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4895 reports time overflow. See
4896 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4897 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4898 * editfns.c: Include limits.h and intprops.h.
4899 (TIME_T_MIN, TIME_T_MAX): New macros.
4900 (time_overflow): Move earlier, to before first use.
4901 (hi_time, lo_time): New functions, for an accurate test for
4902 out-of-range times.
4903 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4904 (Fget_internal_run_time): Don't assume time_t fits in int.
4905 (make_time): Use list2 instead of Fcons twice.
4906 (Fdecode_time): More accurate test for out-of-range times.
4907 (check_tm_member): New function.
4908 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4909 (lisp_time_argument): Don't rely on undefined left-shift and
4910 right-shift behavior when checking for time stamp overflow.
8be6f318 4911
fe31d94c
PE
4912 * editfns.c (time_overflow): New function, refactoring common code.
4913 (Fformat_time_string, Fdecode_time, Fencode_time):
4914 (Fcurrent_time_string): Use it.
4915
8be6f318
PE
4916 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4917 * dired.c (make_time): Move to ...
4918 * editfns.c (make_time): ... here.
4919 * systime.h: Note the move.
4920
09d9db2c 49212011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4922
126bc0dc
YM
4923 * fringe.c (update_window_fringes): Remove unused variables.
4924
c47cbdfd
YM
4925 * unexmacosx.c (copy_data_segment): Also copy __got section.
4926 (Bug#8223)
4927
7ac80be9
EZ
49282011-03-12 Eli Zaretskii <eliz@gnu.org>
4929
c96bbc66 4930 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4931 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4932 Constify `char *' arguments and their references according to
4933 prototypes in tparam.h.
4934
ecb0f94d 4935 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4936
7ac80be9
EZ
4937 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4938 Adapt all references accordingly.
4939
4940 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4941
ef1fd07e
TT
49422011-03-11 Tom Tromey <tromey@redhat.com>
4943
4944 * buffer.c (syms_of_buffer): Remove obsolete comment.
4945
7ef4b50c
EZ
49462011-03-11 Eli Zaretskii <eliz@gnu.org>
4947
4948 * termhooks.h (encode_terminal_code): Declare prototype.
4949
4950 * msdos.c (encode_terminal_code): Don't declare prototype.
4951
4952 * term.c (encode_terminal_code): Now external again, used by
4953 w32console.c and msdos.c.
4954
44f230aa
SM
4955 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4956 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4957
4b1ec863 49582011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4959
1714f52b 4960 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4961
4b1ec863
PE
4962 * fringe.c (update_window_fringes): Mark locals as initialized
4963 (Bug#8227).
4964 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4965
524c7aa6
PE
4966 * alloc.c (mark_fringe_data): Move decl from here ...
4967 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4968 to check its interface.
4969 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4970
a5c0af81 4971 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4972 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4973 (fontset_font): Mark local as initialized.
a9a06e0b 4974 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4975
b4716021
PE
4976 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4977
811e9bac 4978 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4979 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4980 (x_own_selection, Fx_disown_selection_internal): Rename locals
4981 to avoid shadowing.
4982 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4983
7e3ab302
PE
4984 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4985 so that the caller can use some name other than gcpro1.
4986 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4987 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4988 (Fx_backspace_delete_keys_p):
4989 Use them to avoid shadowing, and rename vars to avoid shadowing.
4990 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4991 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4992 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4993 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4994 Remove unused locals.
7e3ab302
PE
4995 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4996 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4997 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4998 macros.
f78faa98 4999
e2b13473
PE
5000 * xterm.h (x_mouse_leave): New decl.
5001
77f23912
PE
5002 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5003 Remove unused functions.
cdf4ba58
PE
5004 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5005 (x_calc_absolute_position): Now static.
7411c686 5006 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5007 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5008 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5009 unless they are used.
38d0b34a
PE
5010 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5011 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5012 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5013 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5014 (x_error_catcher, x_connection_closed, x_error_handler):
5015 (x_error_quitter, xembed_send_message, x_iconify_frame):
5016 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5017 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5018 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5019
44f230aa
SM
5020 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5021 Rename or move locals to avoid shadowing.
6b463e58 5022 (tty_defined_color, merge_face_heights): Now static.
5967d051 5023 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5024 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5025 does not deduce is never used uninitialized.
73719eba
PE
5026 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5027 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5028
426994c3 5029 * terminal.c (store_terminal_param): Now static.
5489860b 5030
032f1620 5031 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5032 (set_frame_menubar): Remove unused local.
d4323972 5033 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5034 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5035 since they might point to immutable storage.
281585b0
PE
5036 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5037 since it's unused otherwise.
032f1620 5038
367c19e5 5039 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5040 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5041 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5042 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5043 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5044 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5045 does not deduce are never used uninitialized.
70739cbe 5046
07b48fa9
PE
5047 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5048
8868a238 5049 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5050 * window.c (window_loop, size_window):
5051 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5052
7e5cf297 5053 * window.c (display_buffer): Now static.
d6550a9f
PE
5054 (size_window): Mark variables that gcc -Wuninitialized
5055 does not deduce are never used uninitialized.
a586633d
PE
5056 * window.h (check_all_windows): New decl, to forestall
5057 gcc -Wmissing-prototypes diagnostic.
5b555da1 5058 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5059
f6095868
PE
5060 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5061 shadowing.
5062 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5063 Include <limits.h>.
5064 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5065 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5066 (load_charset_map): Mark variables that gcc -Wuninitialized
5067 does not deduce are never used uninitialized.
53df7c11 5068 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5069
f38b440c
PE
5070 * coding.c (coding_set_source, coding_set_destination):
5071 Use "else { /* comment */ }" rather than "else /* comment */;"
5072 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5073 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5074 a block, when the outer 'i' will do.
5075 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5076 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5077 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5078 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5079 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5080 Rename locals to avoid shadowing.
5081 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5082 * coding.c (emacs_mule_char, encode_invocation_designation):
5083 Now static, since they're not used elsewhere.
413bb2db 5084 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5085 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5086 (decode_coding_emacs_mule): Mark variables that gcc
5087 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5088 (detect_coding_iso_2022): Initialize a local variable that might
5089 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5090 this initialization is needed. (Bug#8211)
5f58e762
PE
5091 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5092 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5093 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5094 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5095 Remove unused macros.
f38b440c 5096
232b38b9 5097 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5098 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5099 * character.c (string_count_byte8): Likewise.
232b38b9 5100
fb90da1b
PE
5101 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5102 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5103
fb93dbc2
PE
5104 * chartab.c (copy_sub_char_table): Now static, since it's not used
5105 elsewhere.
5c156ace
PE
5106 (sub_char_table_ref_and_range, char_table_ref_and_range):
5107 Rename locals to avoid shadowing.
bbcd0949 5108 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5109
7d3b3862 5110 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5111 (BIDI_BOB): Remove unused macro.
7d3b3862 5112
6be7d3da
PE
5113 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5114 deduce are never used uninitialized.
c2ed9c8b 5115 * term.c (encode_terminal_code): Likewise.
6be7d3da 5116
75f8807f 5117 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5118
50938595
PE
5119 * tparam.h: New file.
5120 * term.c, tparam.h: Include it.
5121 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5122 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5123 Move these decls to tparam.h, and make them agree with what
5124 is actually in tparam.c. The previous trick of using incompatible
5125 decls in different modules does not conform to the C standard.
5126 All callers of tparam changed to use tparam's actual API.
5127 * tparam.c (tparam1, tparam, tgoto):
5128 Use const pointers where appropriate.
5129
fbceeba2
PE
5130 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5131 * cm.h (struct cm): Likewise.
5132 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5133 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5134 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5135 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5136 (turn_on_face, init_tty): Likewise.
5137 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5138
7f3f1250
PE
5139 * term.c (term_mouse_position): Rename local to avoid shadowing.
5140
e6ca6543
PE
5141 * alloc.c (mark_ttys): Move decl from here ...
5142 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5143
c40f8d15
AS
51442011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5145
5146 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5147
cfe0661d
JB
51482011-03-09 Juanma Barranquero <lekktu@gmail.com>
5149
5150 * search.c (compile_pattern_1): Remove argument regp, unused since
5151 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5152 (compile_pattern): Don't pass it.
5153
0afb4571
J
51542011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5155
5156 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5157 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5158 for ! HAVE_GTK3.
5159 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5160
5161 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5162
5163 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5164 gdk_window_get_screen, gdk_window_get_geometry,
5165 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5166 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5167 (xg_get_pixbuf_from_pixmap): New function.
5168 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5169 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5170 Call xg_get_pixbuf_from_pixmap instead of
5171 gdk_pixbuf_get_from_drawable.
5172 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5173 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5174 (xg_check_special_colors): Use GtkStyleContext and its functions
5175 for HAVE_GTK3.
5176 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5177 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5178 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5179 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5180 Call gtk_widget_get_preferred_size.
0afb4571
J
5181 (xg_frame_resized): gdk_window_get_geometry only takes 5
5182 parameters.
44f230aa
SM
5183 (xg_win_to_widget, xg_event_is_for_menubar):
5184 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5185 (xg_set_widget_bg): New function.
5186 (delete_cb): New function.
895009e1 5187 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5188 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5189 (xg_set_background_color): Call xg_set_widget_bg.
5190 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5191 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5192 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5193 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5194 if ! HAVE_GTK3.
5195 (update_frame_tool_bar): Call gtk_widget_hide.
5196 (xg_initialize): Use GDK_KEY_g.
5197
5198 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5199 if ! HAVE_GTK3
5200 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5201
5202 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5203 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5204 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5205
1c2cc4ef
JB
52062011-03-08 Juanma Barranquero <lekktu@gmail.com>
5207
5208 * w32xfns.c (select_palette): Check success of RealizePalette against
5209 GDI_ERROR, not zero.
5210
33383987 5211See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5212
5213;; Local Variables:
5214;; coding: utf-8
aac0c6e3
MR
5215;; End:
5216
33383987 5217 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5218
5219 This file is part of GNU Emacs.
5220
5221 GNU Emacs is free software: you can redistribute it and/or modify
5222 it under the terms of the GNU General Public License as published by
5223 the Free Software Foundation, either version 3 of the License, or
5224 (at your option) any later version.
5225
5226 GNU Emacs is distributed in the hope that it will be useful,
5227 but WITHOUT ANY WARRANTY; without even the implied warranty of
5228 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5229 GNU General Public License for more details.
5230
5231 You should have received a copy of the GNU General Public License
5232 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.