Yet more syncing of xselect docs and argument specs
[bpt/emacs.git] / src / ChangeLog
CommitLineData
bd7da63e
GM
12012-02-12 Glenn Morris <rgm@gnu.org>
2
3 * xselect.c (Fx_own_selection_internal)
4 (Fx_get_selection_internal, Fx_disown_selection_internal)
5 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6 * nsselect.m (Fx_own_selection_internal)
7 (Fx_disown_selection_internal, Fx_selection_exists_p)
8 (Fx_selection_owner_p, Fx_get_selection_internal):
9 Sync docs and argument specs with the xselect.c versions.
10
77abcbc2
LI
112012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
12
13 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
14
90b671e2
EZ
152012-02-11 Eli Zaretskii <eliz@gnu.org>
16
1c0ca0b7
EZ
17 * w32select.c (Fx_selection_exists_p): Sync doc string and
18 argument list with xselect.c. (Bug#10783)
19
20 * w16select.c (Fx_selection_exists_p): Sync doc string and
21 argument list with xselect.c. (Bug#10783)
90b671e2 22
49241268
GM
232012-02-10 Glenn Morris <rgm@gnu.org>
24
25 * fns.c (Fsecure_hash): Doc fix.
26
f998bbe7 272012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
28
29 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
30
0992bd9c
CY
312012-02-07 Chong Yidong <cyd@gnu.org>
32
33 * buffer.c (Fbuffer_local_variables)
34 (buffer_lisp_local_variables): Handle unbound vars correctly;
35 don't let Qunbound leak into Lisp.
36
af008560
GM
372012-02-07 Glenn Morris <rgm@gnu.org>
38
dd605cc4
GM
39 * image.c (Fimagemagick_types): Doc fix.
40
af008560
GM
41 * image.c (imagemagick-render-type): Change it from a lisp object
42 to an integer. Move the doc here from the lisp manual.
43 Treat all values not equal to 0 the same.
44
1449fa1d
CY
452012-02-06 Chong Yidong <cyd@gnu.org>
46
47 * doc.c (store_function_docstring): Avoid applying docstring of
48 alias to base function (Bug#2603).
49
3723ec07
AS
502012-02-04 Andreas Schwab <schwab@linux-m68k.org>
51
52 * .gdbinit (pp1, pv1): Remove redundant defines.
53 (pr): Use pp.
54
79c1cc1e
CY
552012-02-04 Chong Yidong <cyd@gnu.org>
56
57 * nsterm.m: Declare a global (Bug#10694).
58
d7f29f8e
EZ
592012-02-04 Eli Zaretskii <eliz@gnu.org>
60
61 * w32.c (get_emacs_configuration_options): Include
62 --enable-checking, if specified, in the return value.
63
3b95a6f9
MR
642012-02-04 Martin Rudalics <rudalics@gmx.at>
65
66 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
67 after rounding frame sizes. (Bug#9723)
68
d6fa96a6
EZ
692012-02-04 Eli Zaretskii <eliz@gnu.org>
70
71 * keyboard.c (adjust_point_for_property): Don't position point
72 before BEGV. (Bug#10696)
73
df0b2940
PE
742012-02-03 Paul Eggert <eggert@cs.ucla.edu>
75
76 Handle overflow when computing char display width (Bug#9496).
77 * character.c (char_width): Return EMACS_INT, not int.
78 (char_width, c_string_width): Check for overflow when
79 computing the width; this is possible now that individual
80 characters can have unbounded width. Problem introduced
81 by merge from Emacs 23 on 2012-01-19.
82
6bee44d6
MA
832012-02-02 Michael Albinus <michael.albinus@gmx.de>
84
85 * dbusbind.c (Fdbus_register_method): Mention the return value
86 :ignore in the docstring.
87
44f92739
GM
882012-02-02 Glenn Morris <rgm@gnu.org>
89
1b9f60cc
GM
90 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
91
44f92739
GM
92 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
93 Unconditionally set to t. (Bug#10673)
94 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
95 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
96 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
97
c5d3843c
KH
982012-02-02 Kenichi Handa <handa@m17n.org>
99
100 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
101 0, do not call append_composite_glyph.
102
159462d4 1032012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
104
105 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
106 NULL (Bug#6988).
107 (x_produce_glyphs): If the component of a composition is a null
108 string, set it->pixel_width to 1 to avoid zero-width glyph.
109
78cef877
EZ
1102012-02-01 Eli Zaretskii <eliz@gnu.org>
111
112 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
113 first 2 arguments are identical. This makes inserting large
114 output from a subprocess an order of magnitude faster on
115 MS-Windows, where all sbrk'ed memory is always contiguous.
116
97897668
GM
1172012-01-31 Glenn Morris <rgm@gnu.org>
118
119 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 120 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
121 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
122
31fd3586
GM
1232012-01-29 Glenn Morris <rgm@gnu.org>
124
125 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
126
0e24a8b2
CY
1272012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
128
129 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
130
cc0adcb0
CY
1312012-01-28 Chong Yidong <cyd@gnu.org>
132
133 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
134
acc28cb9
CY
1352012-01-26 Chong Yidong <cyd@gnu.org>
136
9c69cfb7
CY
137 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
138
acc28cb9
CY
139 * search.c (Fsearch_forward, Fsearch_backward): Document negative
140 repeat counts (Bug#10507).
141
48da7392
GM
1422012-01-26 Glenn Morris <rgm@gnu.org>
143
144 * lread.c (syms_of_lread): Doc fix.
145
14af5f7f
CY
1462012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
147
148 * coding.c (encode_designation_at_bol): Change return value to
149 EMACS_INT.
150
0b21c100
CY
1512012-01-25 Chong Yidong <cyd@gnu.org>
152
153 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
154
3c2907f7
CY
1552012-01-21 Chong Yidong <cyd@gnu.org>
156
157 * floatfns.c (Fcopysign): Make the second argument non-optional,
158 since nil is not allowed anyway.
159
959ad23f
AS
1602012-01-21 Andreas Schwab <schwab@linux-m68k.org>
161
162 * process.c (read_process_output): Use p instead of XPROCESS (proc).
163 (send_process): Likewise.
164
34a02f46
MR
1652012-01-19 Martin Rudalics <rudalics@gmx.at>
166
167 * window.c (save_window_save, Fcurrent_window_configuration)
168 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
169 doc-strings.
170
1259009a 1712012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
172
173 * character.c (char_width): New function.
70d4fdf6
GM
174 (Fchar_width, c_string_width, lisp_string_width):
175 Use char_width (Bug#9496).
25ed9e61 176
6a6ee00d
MR
1772012-01-16 Martin Rudalics <rudalics@gmx.at>
178
179 * window.c (Vwindow_persistent_parameters): New variable.
180 (Fset_window_configuration, save_window_save): Handle persistent
181 window parameters.
182
c85efaf7
EZ
1832012-01-14 Eli Zaretskii <eliz@gnu.org>
184
185 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
186 thrashing the stack of the thread. (Bug#9087)
187
5944709e
PE
1882012-01-12 Paul Eggert <eggert@cs.ucla.edu>
189
190 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
191
e71f5d99
EZ
1922012-01-11 Eli Zaretskii <eliz@gnu.org>
193
194 * xdisp.c (rows_from_pos_range): Handle the case where the
195 highlight ends on a newline. (Bug#10464)
196 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
197 he end column for display of highlight that ends on a newline
198 before a R2L line.
199
ce316182
GM
2002012-01-11 Glenn Morris <rgm@gnu.org>
201
202 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
203 from load-path also when installation-directory is nil. (Bug#10208)
204
5b43da69
GM
2052012-01-10 Glenn Morris <rgm@gnu.org>
206
74cc8ff9
GM
207 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
208
7d8d6e4e
GM
209 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
210 Update template values to be closer to their typical values these days.
5b43da69 211
a0db8d43
EZ
2122012-01-09 Eli Zaretskii <eliz@gnu.org>
213
214 * xdisp.c (rows_from_pos_range): Accept additional argument
215 DISP_STRING, and accept any glyph in a row whose object is that
216 string as eligible for mouse highlight. Fixes mouse highlight of
217 display strings from overlays. (Bug#10464)
218
9a0115ab 2192012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 220
b9110d6a 221 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
222 * fileio.c (auto_saving_dir_umask): New static var.
223 (Fmake_directory_internal): Use it.
224 (do_auto_save_make_dir): Set it, instead of invoking chmod after
225 creating the directory. The old code temporarily assigns
226 too-generous permissions to the directory.
227 (do_auto_save_eh): Clear it.
b9110d6a 228 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
229 that the var is always cleared.
230
6c1bd3f3
EZ
2312012-01-07 Eli Zaretskii <eliz@gnu.org>
232
233 * search.c (scan_buffer): Pass character positions to
234 know_region_cache, not byte positions. (Bug#6540)
235
069d2b50
L
2362012-01-07 LynX <_LynX@bk.ru> (tiny change)
237
238 * w32.c (sys_rename): Report EXDEV when rename of a directory
239 fails because the target is on another logical disk. (Bug#10284)
240
75bf0d33
DB
2412012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
242
243 * xterm.c (x_embed_request_focus): New function.
244
245 * xterm.h: Add prototype.
246
247 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
248
1c6e5a32
GM
2492012-01-05 Glenn Morris <rgm@gnu.org>
250
251 * emacs.c (emacs_copyright): Update short copyright year to 2012.
252
651e947e
EZ
2532012-01-01 Eli Zaretskii <eliz@gnu.org>
254
255 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
256 Load gnutls_transport_set_lowat only if GnuTLS version is below
257 2.11.1.
258 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
259 GnuTLS versions below 2.11.1.
260
3778cdd8
AL
2612011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
262
263 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
264 to the doc string advising against its use for altering the way
265 windows are scrolled.
266
0e5317f7
KH
2672011-12-28 Kenichi Handa <handa@m17n.org>
268
269 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
270 coding-system ASCII compatible only when it does not produce BOM
271 on encoding (Bug#10383).
272
93d5ca1f
JD
2732011-12-26 Jan Djärv <jan.h.d@swipnet.se>
274
275 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
276 can scroll.
277 (create_and_show_popup_menu): Always use menu_position_func for
278 Gtk3 (Bug#10361).
279
ca22b785
AS
2802011-12-24 Andreas Schwab <schwab@linux-m68k.org>
281
282 * callint.c (Fcall_interactively): Don't truncate prompt string.
283
d048e1e6
EZ
2842011-12-23 Eli Zaretskii <eliz@gnu.org>
285
286 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
287 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 288 resumed from there (after widening). (Bug#10360)
d048e1e6 289
5ccaba1f
JD
2902011-12-22 Jan Djärv <jan.h.d@swipnet.se>
291
292 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
293
204ee57f
JD
2942011-12-21 Jan Djärv <jan.h.d@swipnet.se>
295
b81d40f0
JB
296 * nsterm.m (x_free_frame_resources):
297 Release f->output_data.ns->miniimage.
204ee57f
JD
298 (ns_index_color): Fix indentation. Do not retain
299 color_table->colors[i].
300
301 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
302 before returning.
303
304 * nsfns.m (x_set_background_color): Assign return value from
305 ns_index_color to face-background instead of NSColor*.
306 (ns_implicitly_set_icon_type): Fix indentation.
307 Change assignment in for loop to comparison.
308
309 * emacs.c (ns_pool): New variable.
310 (main): Assign ns_pool.
311 (Fkill_emacs): Call ns_release_autorelease_pool.
312
313 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
314 autorelease fdesc, release fdAttrs and tdict.
315 (ns_get_covering_families): Release charset.
316 (ns_findfonts): Release NSFontDescriptor created with new.
317 (ns_uni_to_glyphs): Fix indentation.
318 (setString): Release attrStr before assigning new value.
319
c803b2b7
JD
3202011-12-18 Jan Djärv <jan.h.d@swipnet.se>
321
678f4426
JD
322 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
323 and NS_IMPL_COCOA.
324 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
325 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
326
cd394be1 3272011-12-18 David Reitter <reitter@cmu.edu>
678f4426 328
5fecd5fc
JD
329 * nsterm.m (ns_term_init): Subscribe for notifications
330 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
331 to method trackingNotification in EmacsMenu.
332
333 * nsmenu.m (trackingMenu): New variable.
3771cb17 334 (trackingNotification): New method (from Aquamacs).
5fecd5fc 335 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 336 from Aquamacs (Bug#7030).
678f4426
JD
337
3382011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 339
c803b2b7
JD
340 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
341 (symbol_to_nsstring): Fix indentation.
342 (ns_symbol_to_pb): New function.
343 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
344 (Fns_rotate_cut_buffers_internal): Removed.
345 (Fns_store_selection_internal): Renamed from
346 Fns_store_cut_buffer_internal.
347 (ns_get_foreign_selection, Fx_own_selection_internal)
348 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
349 (Fns_get_selection_internal, Fns_store_selection_internal):
350 Use ns_symbol_to_pb and check if return value is nil.
351 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
352 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
353 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
354 renamed to Sns_store_selection_internal.
355 (ns_handle_selection_request): Move code to Fx_own_selection_internal
356 and remove this function.
357 (ns_handle_selection_clear): Remove, never used.
358 (Fx_own_selection_internal): Move code from ns_handle_selection_request
359 here.
360
e1b01a3a
KB
3612011-12-17 Ken Brown <kbrown@cornell.edu>
362
363 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
364 GID is unknown (Bug#10257).
365
2adb6e85
PE
3662011-12-17 Paul Eggert <eggert@cs.ucla.edu>
367
368 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
369 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
370 which caused a build failure on GNU/Linux IA-64. This problem was
371 introduced by my 2011-10-07 patch.
372
d1d7b339
JL
3732011-12-15 Juri Linkov <juri@jurta.org>
374
375 * image.c (imagemagick_error): New function. (Bug#10112)
376 (imagemagick_load_image): Comment out `MagickSetResolution' call.
377 Use `imagemagick_error' where ImageMagick functions return
378 `MagickFalse'.
379 (Fimagemagick_types): Add `Fnreverse' to return the list in the
380 proper order.
381
100d5755
KH
3822011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
383
384 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
385 fill background (Bug#8992).
386
454592a6
MR
3872011-12-13 Martin Rudalics <rudalics@gmx.at>
388
389 * window.c (Vwindow_combination_resize)
390 (Vwindow_combination_limit): Use t instead of non-nil in
391 doc-strings.
61d4b438
MR
392 (Vrecenter_redisplay): Add first sentence of doc-string on
393 separate line.
53524d93 394 (Frecenter): Fix doc-string typo.
454592a6 395
3633e3aa
KH
3962011-12-11 Kenichi Handa <handa@m17n.org>
397
398 * coding.c (Funencodable_char_position): Pay attention to the
399 buffer text relocation (Bug#9389).
400
7b9d523a
JD
4012011-12-10 Jan Djärv <jan.h.d@swipnet.se>
402
403 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
404 gtk_init (Bug#10100).
405
b73189c6
EZ
4062011-12-10 Eli Zaretskii <eliz@gnu.org>
407
408 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
409 IT->string is nil. (Bug#10263)
410
f7dfe5d6
JD
4112011-12-10 Jan Djärv <jan.h.d@swipnet.se>
412
83faebb4
JD
413 * nsterm.h (x_free_frame_resources): Declare.
414
f7dfe5d6
JD
415 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
416 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
417
418 * nsterm.h (ns_get_defaults_value): Declare.
419
420 * nsterm.m (ns_default): Call ns_get_defaults_value.
421
7cd4e72c
EZ
4222011-12-09 Eli Zaretskii <eliz@gnu.org>
423
424 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
425 (Bug#10170)
426
b34d7317
YM
4272011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
428
429 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
430 that where the value of an _OBJC_* symbol points to is in the .bss
431 section (Bug#10240).
432
76470ad1
KH
4332011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
434
435 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 436 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 437
745fff94
KH
4382011-12-08 Kenichi Handa <handa@m17n.org>
439
440 * ftfont.c (get_adstyle_property): Fix previous change
441 (Bug#10233).
442
6e44397c
JB
4432011-12-07 Juanma Barranquero <lekktu@gmail.com>
444
445 * w32.c (init_environment): If no_site_lisp, remove site-lisp
446 dirs from the default value of EMACSLOADPATH (bug#10208).
447
7efa6272
GM
4482011-12-07 Glenn Morris <rgm@gnu.org>
449
450 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
451 installation and source directories as well. (Bug#10208)
452
f6fc4d87
CY
4532011-12-06 Chong Yidong <cyd@gnu.org>
454
455 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
456
2bf26180
GM
4572011-12-06 Glenn Morris <rgm@gnu.org>
458
459 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
460 as an error, not just -1. (Bug#10217)
461
3a6ad4f0
CY
4622011-12-05 Chong Yidong <cyd@gnu.org>
463
464 * keyboard.c (process_special_events): New function.
465 (swallow_events, Finput_pending_p): Use it (Bug#10195).
466
75a3b399
PE
4672011-12-05 Paul Eggert <eggert@cs.ucla.edu>
468
469 * coding.c (encode_designation_at_bol): Don't use uninitialized
470 local variable (Bug#9318).
471
c3c9e25e
KH
4722011-12-05 Kenichi Handa <handa@m17n.org>
473
474 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
475 return Qnil (Bug#8046, Bug#10193).
476
5eb05ea3
KH
4772011-12-05 Kenichi Handa <handa@m17n.org>
478
479 * coding.c (encode_designation_at_bol): New args charbuf_end and
480 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
481 (coding_set_source): Return how many bytes coding->source was
482 relocated.
483 (coding_set_destination): Return how many bytes
484 coding->destination was relocated.
485 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
486 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
487
4882011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
489
490 * coding.c (CODING_CHAR_CHARSET_P): New macro.
491 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
492 macro (Bug#9318).
493
4942011-12-05 Andreas Schwab <schwab@linux-m68k.org>
495
496 The following changes are to fix Bug#9318.
497
a79703f5 498 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
499 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
500 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 501 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 502
7dbda6df
JB
5032011-12-05 Juanma Barranquero <lekktu@gmail.com>
504
505 * lisp.h (process_quit_flag): Fix external declaration.
506
6d5eb5b0
SM
5072011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
508
509 Don't macro-inline non-performance-critical code.
510 * eval.c (process_quit_flag): New function.
511 * lisp.h (QUIT): Use it.
512
a0c3fad0
JD
5132011-12-04 Jan Djärv <jan.h.d@swipnet.se>
514
515 * nsfns.m (get_geometry_from_preferences): New function.
516 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
517
6c07aac2
AS
5182011-12-04 Andreas Schwab <schwab@linux-m68k.org>
519
520 * emacs.c (Qkill_emacs): Define.
521 (syms_of_emacs): Initialize it.
522 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
523 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
524 (quit_throw_to_read_char): Add parameter `from_signal'.
525 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
526 * lisp.h (QUIT): Call Fkill_emacs if requested.
527
c052ead4
JD
5282011-12-03 Jan Djärv <jan.h.d@swipnet.se>
529
530 * widget.c (update_wm_hints): Return if wmshell is null.
531 (widget_update_wm_size_hints): New function.
532
533 * widget.h (widget_update_wm_size_hints): Declare.
534
535 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
536 widget_update_wm_size_hints (Bug#10104).
537
9e49252b
EZ
5382011-12-03 Eli Zaretskii <eliz@gnu.org>
539
540 * xdisp.c (handle_invisible_prop): If the invisible text ends just
541 before a newline, prepare the bidi iterator for consuming the
542 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 543 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 544
02b16839
JL
5452011-12-02 Juri Linkov <juri@jurta.org>
546
547 * search.c (Fword_search_regexp): New Lisp function created from
548 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
549 (Fword_search_backward, Fword_search_forward)
550 (Fword_search_backward_lax, Fword_search_forward_lax):
551 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
552 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
553
0068070e
SM
5542011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
555
556 * fileio.c (Finsert_file_contents): Move after-change-function call
557 to before the "handled:" label, since all "goto handled" appear in
558 cases where the *-change-functions have already been properly called
559 (bug#10117).
560
3360a3fc
AS
5612011-12-01 Andreas Schwab <schwab@linux-m68k.org>
562
563 * keyboard.c (interrupt_signal): Don't call kill-emacs when
564 waiting for input. (Bug#10169)
565
73d6c093
EZ
5662011-11-30 Eli Zaretskii <eliz@gnu.org>
567
568 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
569 verifies glyph row's hash code--we have just reallocated the
570 glyphs, so their contents can be complete garbage. (Bug#10164)
571
febe6bea
JB
5722011-11-30 Juanma Barranquero <lekktu@gmail.com>
573
574 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
575
801a4313
EZ
5762011-11-30 Eli Zaretskii <eliz@gnu.org>
577
578 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
579 attributes are tested _before_ calling verify_row_hash, to protect
580 against GCC re-ordering of the tests. (Bug#10164)
581
2b56b87e
JD
5822011-11-29 Jan Djärv <jan.h.d@swipnet.se>
583
584 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
585
586 * xterm.c (handle_one_xevent): Only set async_visible and friends
587 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 588 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
589 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
590
dbf31225
PE
5912011-11-28 Paul Eggert <eggert@cs.ucla.edu>
592
593 Remove GCPRO-related macros that exist only to avoid shadowing locals.
594 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
595 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
596 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
597 All uses changed to use GCPRO1 etc.
598 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
599 Revert to old implementation (i.e., before 2011-03-11).
600
1305621b
YM
6012011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
602
603 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
604 of scroll runs so as to avoid assigning disabled bogus rows and
605 unnecessary graphics copy operations.
606
8c9afb46
EZ
6072011-11-27 Eli Zaretskii <eliz@gnu.org>
608
609 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
610 (snprintf) [_MSC_VER]: Redirect to _snprintf.
611 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
612 (malloc, free, realloc, calloc): Redirect to e_* only when
613 compiling Emacs.
614
615 * lisp.h (GCTYPEBITS): Move before first use.
616 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
617 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
618 this macro definition.
619
620 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
621 _MSC_VER.
622
54e9e3bf
JD
6232011-11-27 Jan Djärv <jan.h.d@swipnet.se>
624
6d5eb5b0
SM
625 * gtkutil.c (xg_create_frame_widgets):
626 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
627 present with Gtk+ 2.0.
628
83aca1cb
PE
6292011-11-26 Paul Eggert <eggert@cs.ucla.edu>
630
631 * fileio.c (Finsert_file_contents): Undo previous change; see
632 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
633
5b76caa4
PE
6342011-11-26 Paul Eggert <eggert@cs.ucla.edu>
635
636 Rename locals to avoid shadowing.
637 * fileio.c (Finsert_file_contents):
638 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
639 * process.c (wait_reading_process_output):
640 Rename inner 'proc' to 'p' to avoid shadowing.
641 Indent for consistency with usual Emacs style.
642
8c535114
EZ
6432011-11-25 Eli Zaretskii <eliz@gnu.org>
644
645 * xdisp.c (redisplay_window): If cursor row is not fully visible
646 after recentering, and scroll-conservatively is set to a large
647 number, scroll window by a few more lines to make the cursor fully
648 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
649 (start_display): Don't move to the next line if the display should
650 start at a newline that is part of a display vector or an overlay
651 string. (Bug#10119)
8c535114 652
fa4fdb5c
JL
6532011-11-24 Juri Linkov <juri@jurta.org>
654
655 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
656 after the `MagickPingImage' call. (Bug#10112)
657
90ec88df
CY
6582011-11-23 Chong Yidong <cyd@gnu.org>
659
660 * window.c (Fcoordinates_in_window_p): Accept only live windows.
661
56e2e794
MR
6622011-11-23 Martin Rudalics <rudalics@gmx.at>
663
664 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
665 making another buffer current. (Bug#10114)
666
b6e64c41
GM
6672011-11-23 Glenn Morris <rgm@gnu.org>
668
669 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
670
6b21de18
CY
6712011-11-23 Chong Yidong <cyd@gnu.org>
672
673 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
674 using it (Bug#5984).
675
b12cd789
EZ
6762011-11-22 Eli Zaretskii <eliz@gnu.org>
677
678 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
679 and header-lines, as they don't have one computed for them.
680 (Bug#10098)
681
682 * .gdbinit (prow): Make displayed values more self-explaining.
683 Add row's hash code.
684
261b6fd4
LMI
6852011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
686
687 * process.c (wait_reading_process_output): Fix asynchrounous
688 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 689 (wait_reading_process_output): Add comment and URL.
261b6fd4 690
e7cfd277
JD
6912011-11-21 Jan Djärv <jan.h.d@swipnet.se>
692
693 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
694
a9b9b7f5
CY
6952011-11-21 Chong Yidong <cyd@gnu.org>
696
697 * window.c (Fnext_window, Fprevious_window): Doc fix.
698
b0d15b4f
SM
6992011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
700
701 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
702
fe7a3057
JB
7032011-11-20 Juanma Barranquero <lekktu@gmail.com>
704
705 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
706
d2999b1a
MR
7072011-11-20 Martin Rudalics <rudalics@gmx.at>
708
709 * window.c (Fset_window_combination_limit): Rename argument
710 STATUS to LIMIT.
711 (Vwindow_combination_limit): Remove "status" from doc-string.
712
d5ff9cd0
AS
7132011-11-20 Andreas Schwab <schwab@linux-m68k.org>
714
715 * m/ibms390.h: Remove.
716 * m/ibms390x.h: Don't include "ibms390.h".
717
a5bb9bd3
SM
7182011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
719
720 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
721 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
722
cd1181db
JB
7232011-11-20 Juanma Barranquero <lekktu@gmail.com>
724
725 * casetab.c (Fset_case_table):
726 * charset.c (Fcharset_after): Fix typos.
727
615a3b8d 7282011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 729
17e845af
PE
730 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
731 Otherwise, valgrind does not work on some platforms.
732 Problem reported by Andreas Schwab in
6a0bf43d
PE
733 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
734 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
735 is set, removing the need for VIRT_ADDRESS_VARIES.
736 (PURE_P): Use a more-efficient implementation that needs just one
737 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
738 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
739 to 4 (xorl, subq, cmpq, setbe).
740 * alloc.c (pure): Always extern now, since that's the
741 VIRT_ADDR_VARIES behavior.
742 (PURE_POINTER_P): Use a single comparison, not two, for
743 consistency with the new puresize.h.
744 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
745 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
746 Remove VIRT_ADDR_VARIES no longer needed.
747
f8fe6f96
EZ
7482011-11-19 Eli Zaretskii <eliz@gnu.org>
749
750 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
751 (erase_phys_cursor, update_window_cursor, show_mouse_face)
752 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
753 behave as if the cursor position were at the window margin.
754
755 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
756 and the cursor position is out of bounds, behave as if the cursor
757 position were at the window margin. (Bug#10075)
758
df05a53c
CY
7592011-11-18 Chong Yidong <cyd@gnu.org>
760
761 * window.c (Fwindow_combination_limit): Make first argument
762 non-optional, since it is meaningless for live windows like the
763 selected window.
764
2071918e
DA
7652011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
766
767 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
768
b50a28de
SM
7692011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
770
771 * intervals.c: Fix grafting over the whole buffer (bug#10071).
772 (graft_intervals_into_buffer): Simplify.
773
015137db
EZ
7742011-11-18 Eli Zaretskii <eliz@gnu.org>
775
776 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
777 hash values of the two rows.
778 (copy_row_except_pointers): Preserve the used[] arrays and the
779 hash values of the two rows. (Bug#10035)
68c95424 780 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
781
782 * xdisp.c (row_hash): New function, body extracted from
783 compute_line_metrics.
784 (compute_line_metrics): Call row_hash, instead of computing the
785 hash code inline.
786
787 * dispnew.c (verify_row_hash): Call row_hash for computing the
788 hash code of a row, instead of duplicating code from xdisp.c.
789
790 * dispextern.h (row_hash): Add prototype.
791
a2addb04
TH
7922011-11-18 Tassilo Horn <tassilo@member.fsf.org>
793
794 * frame.c (delete_frame): Don't delete the terminal when the last
795 X frame is closed if emacs is built with GTK toolkit.
796
df85d315
JB
7972011-11-17 Juanma Barranquero <lekktu@gmail.com>
798
799 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
800
a0c2d0ae
MR
8012011-11-17 Martin Rudalics <rudalics@gmx.at>
802
803 * window.c (Vwindow_splits): Rename to
804 Vwindow_combination_resize. Suggested by Juri Linkov.
805 (Fsplit_window_internal): Use Vwindow_combination_resize instead
806 of Vwindow_splits.
807
58179cce
JB
8082011-11-16 Juanma Barranquero <lekktu@gmail.com>
809
7877f373
JB
810 * nsfns.m (Fns_font_name):
811 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 812
b6f67890
MR
8132011-11-16 Martin Rudalics <rudalics@gmx.at>
814
815 * window.h (window): Rename slot "nest" to "combination_limit".
816 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
817 (Fset_window_nest): Rename to Fset_window_combination_limit.
818 (Vwindow_nest): Rename to Vwindow_combination_limit.
819 (recombine_windows, make_parent_window, make_window)
820 (Fsplit_window_internal, saved_window)
821 (Fset_window_configuration, save_window_save): Rename all
822 occurrences of window_nest to window_combination_limit.
823
c7015153
JB
8242011-11-15 Juanma Barranquero <lekktu@gmail.com>
825
826 * image.c (imagemagick_load_image): Fix typo.
827
322ad6ec
EZ
8282011-11-14 Eli Zaretskii <eliz@gnu.org>
829
830 * xdisp.c (display_line): Move the call to
831 highlight_trailing_whitespace before the call to
832 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
833 faces of all the glyphs to compute ROW's hash value.
834 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 835
f067b8ec
JB
8362011-11-14 Juanma Barranquero <lekktu@gmail.com>
837
838 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
839 just return (bug#10044).
840
1e5b2111
EZ
8412011-11-12 Eli Zaretskii <eliz@gnu.org>
842
7ef3cbd5
EZ
843 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
844 with user-defined heap size. Bump the default size of the temacs
845 heap to 27MB, to avoid memory warning when running temacs.
846 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
847
1e5b2111
EZ
848 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
849 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
850 (verify_row_hash) [XASSERTS]: New function.
851 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
852 that the hash value of glyph rows is correct.
1e5b2111 853
89d61221
MR
8542011-11-12 Martin Rudalics <rudalics@gmx.at>
855
856 * window.h (window): Remove splits slot.
857 * window.c (Fwindow_splits, Fset_window_splits): Remove.
858 (Fdelete_other_windows_internal, make_parent_window)
859 (make_window, Fsplit_window_internal, Fdelete_window_internal)
860 (Fset_window_configuration, save_window_save): Don't deal with
861 split status of windows.
862 (saved_window): Remove splits slot.
863 (Vwindow_splits): Rewrite doc-string.
864
97f18cc8
JD
8652011-11-11 Jan Djärv <jan.h.d@swipnet.se>
866
867 * xfns.c (unwind_create_frame):
868 * nsfns.m (unwind_create_frame):
869 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
870 Vframe_list (Bug#9999).
871
22a648b4
DA
8722011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
873
0b381c7e 874 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 875
659afede
KH
8762011-11-11 Kenichi Handa <handa@m17n.org>
877
878 * callproc.c (Fcall_process): Set the member dst_multibyte of
879 process_coding.
880
9ac0394b
KH
8812011-11-11 Johan Bockgård <bojohan@gnu.org>
882
883 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
884 avoid a crash (bug#9496).
885
2fbdc249
CY
8862011-11-09 Chong Yidong <cyd@gnu.org>
887
888 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
889 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
890
ac6b1f81
PE
8912011-11-08 Paul Eggert <eggert@cs.ucla.edu>
892
893 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
894
09db192c
PE
8952011-11-08 Paul Eggert <eggert@cs.ucla.edu>
896
897 Avoid some portability problems by eschewing 'extern inline' functions.
898 The trivial performance wins aren't worth the portability hassles; see
899 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
900 et seq.
901 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
902 (window_box_width, window_box_left, window_box_left_offset)
903 (window_box_right, window_box_right_offset): Undo previous change,
904 by removing the "extern"s.
905 * intervals.c (adjust_intervals_for_insertion)
906 (adjust_intervals_for_deletion): Undo previous change,
907 making these static again.
908 (offset_intervals, temp_set_point_both, temp_set_point)
909 (copy_intervals_to_string): No longer inline.
910 * xdisp.c (window_text_bottom_y, window_box_width)
911 (window_box_height, window_box_left_offset)
912 (window_box_right_offset, window_box_left, window_box_right)
913 (window_box): No longer inline.
914
105216ed
CY
9152011-11-08 Chong Yidong <cyd@gnu.org>
916
917 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
918 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
919 Signal an error if not a live window.
105216ed
CY
920 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
921 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
922
ae9e237f
JB
9232011-11-07 Juanma Barranquero <lekktu@gmail.com>
924
925 * lisp.h (syms_of_abbrev): Remove declaration.
926 Reported by CHENG Gao <chenggao@royau.me>.
927
c7aa8333
EZ
9282011-11-07 Eli Zaretskii <eliz@gnu.org>
929
930 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
931 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
932 of temacs in GUI mode.
933
be7f5545
MR
9342011-11-07 Martin Rudalics <rudalics@gmx.at>
935
936 * window.h: Declare delete_all_child_windows instead of
937 delete_all_subwindows.
938 * window.c (Fwindow_nest, Fset_window_nest)
939 (Fset_window_new_total, Fset_window_new_normal)
940 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
941 (delete_all_subwindows): Rename to delete_all_child_windows.
942 (Fdelete_other_windows_internal, Fset_window_configuration):
943 Call delete_all_child_windows instead of delete_all_subwindows.
944 * frame.c (delete_frame): Call delete_all_child_windows instead
945 of delete_all_subwindows.
946
ca78dc43
PE
9472011-11-07 Paul Eggert <eggert@cs.ucla.edu>
948
949 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
950 This is also needed for porting to any host where GC_MARK_STACK is
951 not GC_MAKE_GCPROS_NOOPS.
952 (which_symbols): Use it.
953
a0241d01
KH
9542011-11-07 Kenichi Handa <handa@m17n.org>
955
956 * coding.c (coding_set_destination): Check coding->src_pos only
957 when coding->src_object is a buffer (bug#9910).
958
959 * process.c (send_process): Set the member src_multibyte of coding
960 to 0 (bug#9911) when sending a unibyte text.
961
962 * callproc.c (Fcall_process): Set the member src_multibyte of
963 process_coding to 0 (bug#9912).
964
a64bfdfa 9652011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
966
967 * xmenu.c (cleanup_widget_value_tree): New function.
968 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
969 calling free_menubar_widget_value_tree directly (Bug#9830).
970
cb41b32a
PE
9712011-11-06 Paul Eggert <eggert@cs.ucla.edu>
972
973 Fix some portability problems with 'inline'.
974 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
975 (window_box_width, window_box_left, window_box_left_offset)
976 (window_box_right, window_box_right_offset): Declare extern.
977 Otherwise, these inline functions do not conform to C99 and
978 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
979 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
980 * intervals.c (adjust_intervals_for_insertion)
981 (adjust_intervals_for_deletion): Now extern, because otherwise the
982 extern inline functions 'offset_intervals' couldn't refer to it.
983 (static_offset_intervals): Remove.
984 (offset_intervals): Rewrite using the old contents of
985 static_offset_intervals. The old version didn't conform to C99
986 because an extern inline function contained a reference to an
987 identifier with static linkage.
988
b7041366
AS
9892011-11-06 Andreas Schwab <schwab@linux-m68k.org>
990
991 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
992 GC.
993
88a37c4d
EZ
9942011-11-06 Eli Zaretskii <eliz@gnu.org>
995
996 * xdisp.c (init_iterator, reseat_to_string): Don't set the
997 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
998 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
999 return Qleft_to_right.
1000
49745b39
CY
10012011-11-06 Chong Yidong <cyd@gnu.org>
1002
1003 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1004 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1005 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1006 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1007 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1008 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1009 (Fwindow_vscroll): Doc fix.
1010 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1011 argument, since it makes no sense to pass a live window and for
1012 consistency with window-child.
1013
1f05cd82
CS
10142011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1015
1016 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1017 support MSVC.
1018
22610910
JR
10192011-11-05 Jason Rumney <jasonr@gnu.org>
1020
1021 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1022 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1023 fonts (Bug#6029).
1024 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1025 bitwise arithmetic preventing use of unicode-sip and non-truetype
1026 opentype fonts.
1027
a06776b2
EZ
10282011-11-05 Eli Zaretskii <eliz@gnu.org>
1029
3ad924ba
EZ
1030 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1031 "emacs"-only part.
1032
a06776b2
EZ
1033 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1034 initialization code to keep similarity to xfns.c after changes
1035 from 2011-11-05.
1036
c9e7db78
JD
10372011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1038
a97f8f3f
JD
1039 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1040 (unwind_create_frame): New function (Bug#9943).
1041 (Fx_create_frame): Restructure code to be more similar to the one in
1042 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1043 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1044 Move terminal->reference_count++ just before making the frame official
1045 (Bug#9943).
1046
1047 * nsterm.m (x_free_frame_resources): New function.
1048 (x_destroy_window): Move code to x_free_frame_resources.
1049
c9e7db78 1050 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1051 (Fx_create_frame, x_create_tip_frame):
1052 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1053 official. Move initialization of image_cache_refcount and
1054 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1055
a6fc3b5c
EZ
10562011-11-05 Eli Zaretskii <eliz@gnu.org>
1057
1058 Support MSVC build with newer versions of Visual Studio.
1059 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1060 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1061 nt/gmake.defs.
1062
1063 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1064 which are not supported by MSVC.
1065 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1066 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1067 bitfields.
1068 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1069 types in bitfields.
1070 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1071
1072 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1073
58179cce 10742011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1075
1076 Support MSVC build with newer versions of Visual Studio.
1077 * w32.c: Don't include w32api.h for MSVC.
1078 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1079
1080 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1081 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1082 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1083 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1084 e_* cousins.
1085 (alloca) [_MSC_VER]: Define to _alloca.
1086
1087 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1088
1089 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1090
a58c13ed
EZ
10912011-11-04 Eli Zaretskii <eliz@gnu.org>
1092
1093 * xdisp.c (note_mouse_highlight): If either of
1094 previous/next-single-property-change returns nil, treat that as
1095 the beginning or the end of the buffer. (Bug#9955)
1096
fe0b6370
JD
10972011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1098
a58c13ed 1099 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1100 label is not null (Bug#9951).
1101 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1102 may be NULL.
1103
89bd5ee1
EZ
11042011-11-04 Eli Zaretskii <eliz@gnu.org>
1105
1106 * window.c (Fwindow_body_size): Mention in the doc string that the
1107 return value is in frame's canonical units. (Bug#9949)
1108
84c3edb9
EZ
11092011-11-03 Eli Zaretskii <eliz@gnu.org>
1110
4e2fb5c7
EZ
1111 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1112
84c3edb9 1113 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1114 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1115 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1116
bc17a887
EZ
11172011-11-01 Eli Zaretskii <eliz@gnu.org>
1118
1119 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1120 Don't stop backward scan on the continuation glyph, even though
1121 its CHARPOS is positive.
6d5eb5b0
SM
1122 (mouse_face_from_buffer_pos, note_mouse_highlight):
1123 Rename cover_string to disp_string.
bc17a887 1124
4ee88440
MR
11252011-11-01 Martin Rudalics <rudalics@gmx.at>
1126
1127 * window.c (temp_output_buffer_show): Don't use
1128 Vtemp_buffer_show_specifiers.
1129 (Vtemp_buffer_show_specifiers): Remove unused variable.
1130
c2ff3c02
EZ
11312011-10-30 Eli Zaretskii <eliz@gnu.org>
1132
1133 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1134 past the beginning of the current glyph matrix.
1135
58179cce 11362011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1137
1138 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1139 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1140 HAVE_GTK3 (Bug#9869).
b77a6a7f 1141
3b574623
JD
1142 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1143 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1144
b77a6a7f
JD
1145 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1146
1147 * xterm.c: Declare x_handle_net_wm_state to return int.
1148 (handle_one_xevent): Check if we are iconified but don't have
1149 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1150 (get_current_wm_state): Return non-zero if not hidden,
1151 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1152 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1153 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1154 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1155
196e41e4
PE
11562011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1157
1158 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1159 so that this new function doesn't get optimized away by a
1160 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1161
021f2e1a
AS
11622011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1163
1164 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1165
8b058d44
EZ
11662011-10-29 Eli Zaretskii <eliz@gnu.org>
1167
1168 Fix the `xbytecode' command.
1169 * .gdbinit (xprintbytestr): New command.
b50a28de 1170 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1171 (xbytecode): Print the byte-code string as well.
1172
4452fb80
EZ
11732011-10-29 Kim Storm <storm@cua.dk>
1174
8b058d44
EZ
1175 * alloc.c (which_symbols): New function.
1176
21b72067
AS
11772011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1178
1179 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1180 line. (Bug#9903)
1181
83ed7b5c
GM
11822011-10-29 Glenn Morris <rgm@gnu.org>
1183
1184 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1185 Not clear what it was for, and it causes various bugs. (Bug#9839)
1186
5a7a728b
EZ
11872011-10-28 Eli Zaretskii <eliz@gnu.org>
1188
1189 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1190 possible random value that matches one of those tested as
1191 condition to clear the mouse face.
1192
d3d0842f
CY
11932011-10-28 Chong Yidong <cyd@gnu.org>
1194
1195 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1196
31b39d13
DN
11972011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1198
1199 * window.c (make_window): Initialize phys_cursor_on_p.
1200
9aba6043
SM
12012011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1202
1203 * lisp.h (struct Lisp_Symbol): Update comments.
1204
c20992f4
JB
12052011-10-28 Juanma Barranquero <lekktu@gmail.com>
1206
1207 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1208
db4f02f2
EZ
12092011-10-28 Eli Zaretskii <eliz@gnu.org>
1210
1211 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1212 <oslsachem@gmail.com> for helping to debug this.
1213
1214 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1215 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1216 (g_b_init_get_glyph_outline_w): New static variables.
1217 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1218 (GetGlyphOutlineW_Proc): New typedefs.
1219 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1220 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1221 New functions.
1222 (w32font_open_internal, compute_metrics):
1223 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1224 instead of calling the "wide" APIs directly.
1225
1226 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1227
1228 * w32.h (syms_of_w32font): Add prototype.
1229
87e68db4
JB
12302011-10-27 Juanma Barranquero <lekktu@gmail.com>
1231
1232 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1233 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1234 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1235 (Fmove_to_window_line): Doc fix.
1236
435c1d67
CY
12372011-10-27 Chong Yidong <cyd@gnu.org>
1238
1239 * process.c (make_process): Set gnutls_state to NULL.
1240
1241 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1242 non-NULL, regardless of GNUTLS_INITSTAGE.
1243 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1244 an error. Set process slots as soon as we allocate them.
1245
1246 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1247
9c6c6f49
CY
12482011-10-27 Chong Yidong <cyd@gnu.org>
1249
9aba6043
SM
1250 * gnutls.c (emacs_gnutls_deinit): New function.
1251 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1252 (Fgnutls_deinit, Fgnutls_boot): Use it.
1253
1254 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1255 (deactivate_process): Call emacs_gnutls_deinit.
1256
657d08d3
JB
12572011-10-27 Juanma Barranquero <lekktu@gmail.com>
1258
1259 * image.c (x_create_x_image_and_pixmap):
1260 * w32.c (sys_rename, w32_delayed_load):
1261 * w32font.c (fill_in_logfont):
1262 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1263
5430d399
JB
12642011-10-26 Juanma Barranquero <lekktu@gmail.com>
1265
1266 * w32fns.c (w32_default_color_map): New function,
1267 extracted from Fw32_default_color_map.
a7ef684b 1268 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1269
fe0055fa
PE
12702011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1271
1272 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1273
e6346438
SM
12742011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1275
1276 * keyboard.c (test_undefined): New function (bug#9751).
1277 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1278
e112cc37
ET
12792011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1280
1281 * sysdep.c (init_sys_modes): Fix the check for the controlling
1282 terminal (Bug#6649).
1283
7b5d6677
EZ
12842011-10-20 Eli Zaretskii <eliz@gnu.org>
1285
1286 * dispextern.h (struct bidi_it): New member next_en_type.
1287
1288 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1289 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1290 current character, check also for next_en_type being WEAK_EN.
1291 (bidi_resolve_weak): Don't enter the expensive loop if the current
1292 position is before next_en_pos. Record the bidi type of the first
1293 non-ET, non-BN character we find, in addition to its position.
1294 (bidi_level_of_next_char): Invalidate next_en_type when
1295 next_en_pos is over-stepped.
1296
7da0b018
PE
12972011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1298
1299 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1300 * editfns.c: Rewrite current-time-zone so that it invokes
1301 the equivalent of (format-time-string "%Z") to get the time zone name.
1302 This fixes a bug when the time zone name contains characters that
1303 need converting from the system time locale to Emacs internal format.
1304 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1305 that patch fixed format-time-string to do the conversion, but
1306 I forgot to fix current-time-zone.
1307 (format_time_string): New function, containing most of
1308 what Fformat_time_string used to contain.
1309 (Fformat_time_string): Rewrite in terms of format_time_string.
1310 This doesn't change this function's behavior.
1311 (current-time-zone): Rewrite to use format_time_string.
1312 This fixes the bug reported by Michael Schierl in
1313 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1314 Jason Rumney's 2007-06-07 change worked around this bug, but
1315 didn't fix it.
1316 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1317
8547b010
EZ
13182011-10-19 Eli Zaretskii <eliz@gnu.org>
1319
1320 * xdisp.c (start_display): If the character at POS is displayed
1321 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1322 (try_window_reusing_current_matrix): If a line ends in a display
1323 vector or the next line starts in a display vector, continue
1324 redrawing the window even though the character position of
1325 start_row was reached.
8547b010
EZ
1326 (Bug#9771, part 2)
1327
4e948d15
CY
13282011-10-18 Chong Yidong <cyd@gnu.org>
1329
1330 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1331 with nobreak-char-display too.
1332
4787455f
EZ
13332011-10-18 Eli Zaretskii <eliz@gnu.org>
1334
1335 Fix part 3 of bug#9771.
1336 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1337 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1338 non-neutral characters if the current character is a paragraph
1339 separator (a.k.a. Newline). This avoids running the same
1340 expensive loop twice, once when we consume the preceding newline
1341 and the other time when the line actually needs to be displayed.
1342 Avoid the loop when we see neutrals on the base embedding level
1343 following a character whose directionality is the same as the
1344 paragraph's. This avoids running the expensive loop when a line
1345 ends in a long sequence of neutrals, like control characters.
1346 Add assertion against STRONG_AL type. Slightly rearrange code
1347 that determines the type of a neutral given the first non-neutral
1348 that follows it.
1349 (bidi_level_of_next_char): Set next_en_pos to zero when
1350 invalidating its info.
1351
2c91f553
EZ
13522011-10-17 Eli Zaretskii <eliz@gnu.org>
1353
1354 * xdisp.c (push_display_prop): Determine whether to record string
1355 or buffer position by IT->string, not by IT->method. Allow
1356 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1357 (move_it_vertically_backward): Don't look for character position
1358 immediately after the newline when in a continuation line.
1359 (Bug#9771, part 1)
2c91f553 1360
c7b08b0d
MR
13612011-10-15 Martin Rudalics <rudalics@gmx.at>
1362
1363 * window.c (coordinates_in_window): Rewrite and delabelize
1364 vertical border check. (Bug#5357) (Bug#9618)
1365
6b02f655
SM
13662011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1367
1368 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1369 errors in XSetWindowBorder (bug#9310).
1370
81d40c92
DA
13712011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1372
1373 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1374 avoid crash when xmalloc overrun checking is enabled.
1375
d4172c3b
EZ
13762011-10-13 Eli Zaretskii <eliz@gnu.org>
1377
1378 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1379 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1380 cursor motion with <left> and <right> arrow keys.
1381
1382 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1383 some callers set that themselves.
1384
b00eea75
EZ
13852011-10-12 Eli Zaretskii <eliz@gnu.org>
1386
1387 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1388 display string and the previous row comes from the same string and
1389 is empty. (Bug#9739) (Bug#9738)
1390
8fe012c4
SM
13912011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1392
1393 * doc.c (get_doc_string): Encode file name (bug#9735).
1394
0074aef2
EZ
13952011-10-12 Eli Zaretskii <eliz@gnu.org>
1396
79beb178
EZ
1397 * bidi.c (bidi_level_of_next_char):
1398 * xdisp.c (get_visually_first_element): Remove old incorrect
1399 comments regarding the Unicode Line Separator character.
1400
0074aef2
EZ
1401 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1402
6e4b3fbe
DA
14032011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1404
1405 * alloc.c (Fgc_status): Do not access beyond zombies array
1406 boundary if nzombies > MAX_ZOMBIES.
1407 * alloc.c (dump_zombies): Add missing format specifier.
1408
0324f3af
PE
14092011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1410
b5525cac
PE
1411 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1412 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1413
0324f3af
PE
1414 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1415 Some packages use them to denote characters with modifiers.
1416
e9b5f888
AS
14172011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1418
1419 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1420 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1421 matching a pp-number. Rename parameter var to var1.
1422
127827c0
SM
14232011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1424
1425 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1426
c8fd3bd0
GM
14272011-10-08 Glenn Morris <rgm@gnu.org>
1428
1429 * callint.c (Fcall_interactively): Give a more explicit error for the
1430 'c' case with a non-character input. (Bug#8479)
1431
352ec8ff
EZ
14322011-10-08 Eli Zaretskii <eliz@gnu.org>
1433
03669ccb
EZ
1434 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1435 lines.
7061c986
EZ
1436 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1437 lines that are hscrolled on the left.
03669ccb 1438
352ec8ff
EZ
1439 * dispnew.c (buffer_posn_from_coords): Account for a possible
1440 presence of header-line. (Bug#4426)
1441
a66cfb1c
SM
14422011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1443
6b02f655
SM
1444 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1445 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1446
7c5ee88e
PE
14472011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1448
1449 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1450 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1451 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1452 this makes Emacs dump core during garbage collection on rare
1453 occasions. sizeof is obviously inferior to offsetof here, so
1454 stick with offsetof.
1455 (GC_POINTER_ALIGNMENT): New macro.
1456 (mark_memory): Omit 3rd (offset) arg; caller changed.
1457 Don't assume EMACS_INT alignment is the same as pointer alignment.
1458
df1bbe5b
SM
14592011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1460
1461 * keyboard.c (read_key_sequence_remapped): New var.
1462 (read_key_sequence): Compute remapping in the right buffer.
1463 (command_loop_1): Use read_key_sequence's remapping directly.
1464
51553db6
SM
14652011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1466
32c1fffd
SM
1467 * dired.c (file_name_completion): Don't expand file name.
1468 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1469 before checking file name handler.
1470
51553db6
SM
1471 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1472 they've been requested explicitly (bug#9591).
1473
b6bd1599 14742011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1475
1476 * keymap.c (Fsingle_key_description): Use make_specified_string
1477 instead of build_string to build string from push_key_description.
1478 (Bug#5193)
1479
f701dc2a
PE
14802011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1481
4222c55d
PE
1482 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1483 This fixes a Y2038 bug on 64-bit hosts.
1484 * buffer.c (reset_buffer):
1485 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1486 (Fclear_buffer_auto_save_failure):
1487 Use 0, not -1, to represent an unset failure time, since time_t
1488 might not be signed.
1489
f701dc2a
PE
1490 Remove dependency on glibc malloc internals.
1491 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1492 Move back here from lisp.h, but with their new implementations.
1493 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1494 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1495 * charset.c (charset_table_init): New static var.
1496 (syms_of_charset): Use it instead of xmalloc. This removes a
1497 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1498 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1499 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1500 Move back to alloc.c.
1501 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1502 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1503
9ceebf39
JD
15042011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1505
1506 * nsterm.m (windowDidResize): Call x_set_window_size only when
1507 ns_in_resize is true. Otherwise set pixelwidth/height and
1508 call change_frame_size (Bug#9628).
1509
cb993c58
PE
15102011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1511
3930c88b
PE
1512 Port --enable-checking=all to Fedora 14 x86-64.
1513 * charset.c (syms_of_charset): Also account for glibc malloc's
1514 internal overhead when calculating the initial malloc maximum.
1515
cb993c58
PE
1516 Port --enable-checking=all to Fedora 14 x86.
1517 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1518 Move to lisp.h.
1519 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1520 (overrun_check_realloc, overrun_check_free):
1521 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1522 That way, xmalloc returns a properly-aligned pointer even if
1523 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1524 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1525 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1526 into account when calculating the initial malloc maximum.
1527 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1528 Move here from alloc.c, so that charset.c can use it too.
1529 Properly align; the old code wasn't right for common 32-bit hosts
1530 when configured with --enable-checking=all.
1531 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1532 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1533
31bed486
EZ
15342011-09-29 Eli Zaretskii <eliz@gnu.org>
1535
04c70788 1536 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1537 use EDOM.
1538
fbcaa2f3
EZ
15392011-09-28 Eli Zaretskii <eliz@gnu.org>
1540
1541 * xdisp.c (compute_display_string_end): If there's no display
1542 string at CHARPOS, return -1.
1543
1544 * bidi.c (bidi_fetch_char): When compute_display_string_end
1545 returns a negative value, treat the character as a normal
1546 character not covered by a display string. (Bug#9624)
1547
a239d4e9
JB
15482011-09-28 Juanma Barranquero <lekktu@gmail.com>
1549
1550 * lread.c (Fread_from_string): Fix typo in docstring.
1551
88652fd5
EZ
15522011-09-27 Eli Zaretskii <eliz@gnu.org>
1553
1554 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1555 newline, reseat the iterator instead of bidi-iterating there one
1556 character at a time. (Bug#9610)
32c1fffd
SM
1557 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1558 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1559
ed497dd4
AS
15602011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1561
1562 * lread.c (readevalloop): Use correct code for NBSP.
1563 (read1): Likewise. (Bug#9608)
1564
b2bf61aa
MA
15652011-09-25 Michael Albinus <michael.albinus@gmx.de>
1566
1567 * dbusbind.c (Fdbus_register_signal): When service is not
1568 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1569
32bbb17c
GM
15702011-09-25 Glenn Morris <rgm@gnu.org>
1571
1572 * buffer.c (truncate-lines): Doc fix.
1573
94e0933e
CY
15742011-09-24 Chong Yidong <cyd@stupidchicken.com>
1575
1576 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1577 (Fset_window_next_buffers): Doc fix.
1578
cddde921
GM
15792011-09-24 Glenn Morris <rgm@gnu.org>
1580
1581 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1582
1260aef1
PE
15832011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1584
25b4bfa0
PE
1585 Fix minor problems found by static checking.
1586 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1587 * indent.c (Fvertical_motion): Fix == vs = typo.
1588
e3cbd34b
EZ
15892011-09-24 Eli Zaretskii <eliz@gnu.org>
1590
a66cfb1c
SM
1591 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1592 Default value is now t. Doc fix.
6bf7006f 1593
e3cbd34b 1594 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1595 logic when moving up, not only when moving down. Fix the
e3cbd34b 1596 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1597 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1598
1599 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1600 CHARPOS is covered by a display string which includes newlines.
1601 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1602 is covered by a display string with embedded newlines.
1603
a3de0cbd
MA
16042011-09-24 Michael Albinus <michael.albinus@gmx.de>
1605
1606 * dbusbind.c (Fdbus_register_signal): Add match rule to
1607 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1608 (Fdbus_register_method, Vdbus_registered_objects_table):
1609 Fix docstring.
a3de0cbd 1610
b260039d
JM
16112011-09-24 Jim Meyering <meyering@redhat.com>
1612
32c1fffd 1613 do not ignore write error for any output size
b260039d
JM
1614 The previous change was incomplete.
1615 While it makes emacs --batch detect the vast majority of stdout
1616 write failures, errors were still ignored whenever the output size is
1617 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1618 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1619 && echo FAIL: ignored write error
1620 FAIL: ignored write error
1621 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1622 && echo FAIL: ignored write error
1623 FAIL: ignored write error
1624 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1625
8eca8a7c
AS
16262011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1627
1628 * emacs.c (Fkill_emacs): In noninteractive mode exit
1629 non-successfully if a write error occurred on stdout. (Bug#9574)
1630
3341db62
EZ
16312011-09-21 Eli Zaretskii <eliz@gnu.org>
1632
1633 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1634 the xassert test.
1635
1636 * dispextern.h (struct it): Update the comment documenting what
1637 can it->OBJECT be.
1638
8c203dbf
EZ
16392011-09-20 Eli Zaretskii <eliz@gnu.org>
1640
1641 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1642 a display string, extend search for cursor position to end of row.
1643 (find_row_edges): If the row ends in a newline from a display
1644 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1645 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1646 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1647 non-empty line. Fixes confusing cursor motion with arrow keys at
1648 the beginning of a line that starts with whitespace.
8c203dbf 1649
a4824228
LMI
16502011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1651
1652 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1653 (bug#9493).
1654
33ed493b
CY
16552011-09-18 Chong Yidong <cyd@stupidchicken.com>
1656
1657 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1658 boolean (Bug#9154).
1659
56cd55c8
EZ
16602011-09-18 Eli Zaretskii <eliz@gnu.org>
1661
1662 * xdisp.c (display_line): Record maximum and minimum buffer
1663 positions even if no glyphs were produced (e.g., by a zero-width
1664 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1665 buffer positions that will be removed from the glyph row because
1666 they don't fit.
c02dcedf
EZ
1667 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1668 column is beyond frame width: don't subtract 1 "pixel" when
1669 computing width of the stretch.
3e62b7e0
EZ
1670 (reseat_at_next_visible_line_start): Undo the change made on
1671 2011-09-17 that saved paragraph information and restored it after
1672 the call to `reseat'. (Bug#9545)
56cd55c8 1673
5ed99d36 16742011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1675
1676 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1677 and turn window cursor on if cleared (Bug#9415).
1678
5ed99d36 16792011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1680
1681 * search.c (boyer_moore): Take unibyte characters from pattern
1682 literally. (Bug#9458)
1683
9bade7b2
EZ
16842011-09-18 Eli Zaretskii <eliz@gnu.org>
1685
1686 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1687
e5e9d610
PE
16882011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1689
87e4427a
PE
1690 Fix minor problem found by static checking.
1691 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1692 initialized, to pacify gcc -Wuninitialized.
1693
e5e9d610
PE
1694 * fileio.c: Report proper errno when syscall falls.
1695 (Finsert_file_contents): Save and restore errno,
1696 so that report_file_error outputs the correct diagnostic.
1697 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1698
a1674f0b
EZ
16992011-09-18 Eli Zaretskii <eliz@gnu.org>
1700
1701 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1702
fbfb6dd4
EZ
17032011-09-17 Eli Zaretskii <eliz@gnu.org>
1704
1705 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1706 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1707
bb187662
EZ
17082011-09-17 Eli Zaretskii <eliz@gnu.org>
1709
1137e8b8 1710 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1711 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1712
1713 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1714 (bidi_find_paragraph_start): Search back for paragraph beginning
1715 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1716 (bidi_move_to_visually_next): Only trigger paragraph-related
1717 computations when the last character is a newline or at EOB, not
1718 just any NEUTRAL_B. (Bug#9470)
1719
bb187662
EZ
1720 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1721 truncated lines if point is covered by a display string. (Bug#9524)
1722
2e621251
PE
17232011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1724
1725 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1726 (cons_to_x_long): New function.
1727 (lisp_data_to_selection_data): Use it. Correct the test for
1728 short-versus-long data; it was negated. Break out of vector
1729 loop, for efficiency, when a long datum is discovered.
1730
91a15bc6
SM
17312011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1732
1733 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1734
b41c3a35
EZ
17352011-09-16 Eli Zaretskii <eliz@gnu.org>
1736
1737 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1738 GCC PR/17406) by declaring this function with external scope.
1739
7812ba2d
PE
17402011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1741
1742 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1743 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1744
cf7edc2a
AS
17452011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1746
1747 * editfns.c (Fformat): Correctly handle text properties on "%%".
1748
bd01620e
EZ
17492011-09-15 Eli Zaretskii <eliz@gnu.org>
1750
1751 * xterm.c (x_draw_composite_glyph_string_foreground):
1752 * w32term.c (x_draw_composite_glyph_string_foreground):
1753 * term.c (encode_terminal_code):
1754 * composite.c (composition_update_it, get_composition_id):
1755 * xdisp.c (get_next_display_element)
1756 (fill_composite_glyph_string): Add comments about special meaning
1757 of TAB characters in a composition.
1758
a02719a3
PE
17592011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1760
1761 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1762 This occurs when processing a multibyte format.
1763 Problem reported by Wolfgang Jenker.
a02719a3 1764
72589a3c
JB
17652011-09-15 Johan Bockgård <bojohan@gnu.org>
1766
1767 * xdisp.c (try_cursor_movement): Only check for exact match if
1768 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1769
1c14176c
PE
17702011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1771
1772 Remove unused external symbols.
1773 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1774 * xdisp.c (calc_pixel_width_or_height): Now static.
1775 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1776 * indent.c (check_display_width):
1777 * w32term.c: Fix comment to match code.
1778 * xterm.c, xterm.h (x_catching_errors): Remove.
1779
d2eea5b5
PE
17802011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1781
1782 * xselect.c: Use signed conversions more consistently (Bug#9498).
1783 (selection_data_to_lisp_data): Assume incoming selection data are
1784 signed integers, not unsigned. This is to be consistent with
1785 outgoing selection data, which was modified to use signed integers
1786 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1787 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1788 expects long, not unsigned long.
1789
46888499
EZ
17902011-09-14 Eli Zaretskii <eliz@gnu.org>
1791
1792 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1793 computation of loop end. Reported by Johan Bockgård
1794 <bojohan@gnu.org>.
1795
ef8ef9fb
CY
17962011-09-13 Chong Yidong <cyd@stupidchicken.com>
1797
1798 * frame.c (Fother_visible_frames_p): Function deleted.
1799
fa819fed
EZ
18002011-09-12 Eli Zaretskii <eliz@gnu.org>
1801
1802 * indent.c (compute_motion): Process display vector front to back
1803 rather than the other way around. (Bug#2496)
1804
2ba8e008
SM
18052011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1806
1807 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1808
20f53c69
CY
18092011-09-11 Chong Yidong <cyd@stupidchicken.com>
1810
1811 * minibuf.c (Fread_from_minibuffer): Doc fix.
1812
d562d7a4
EZ
18132011-09-11 Eli Zaretskii <eliz@gnu.org>
1814
1815 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1816 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1817
1c4d7f3d
LMI
18182011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1819
1820 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1821 value for non-existent files.
1822
b885bf36
EZ
18232011-09-11 Eli Zaretskii <eliz@gnu.org>
1824
1825 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1826 set its "size" to -1. This will set the modtime_size field of
1827 the corresponding buffer to -1, which is what
1828 verify-visited-file-modtime expects for files that do not exist.
1829 (Bug#9139)
1830
6612f0bf
PE
18312011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1832
1833 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1834 here ...
1835 * lisp.h: ... from here. push_key_description is no longer
1836 defined in keyboard.c, so its declaration should not be in
1837 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1838 logically belongs with push_key_description.
1839
dfb3f755
PE
18402011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1841
1842 * buffer.h: Include <sys/types.h> instead of <time.h>.
1843 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1844 Problem reported by Herbert J. Skuhra.
1845
3134906c
LMI
18462011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1847
1848 * xml.c (parse_region): Make the parsing work for
1849 non-comment-starting XML files again (bug#9144).
1850
8d903f4e
AS
18512011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1852
1853 * image.c (gif_load): Fix calculation of bottom and right corner.
1854 (Bug#9468)
1855
80ad64f4
EZ
18562011-09-10 Eli Zaretskii <eliz@gnu.org>
1857
1858 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1859 redisplay in small windows.
1860
208a048d
EZ
18612011-09-09 Eli Zaretskii <eliz@gnu.org>
1862
1863 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1864
9b1c252e
MR
18652011-09-08 Martin Rudalics <rudalics@gmx.at>
1866
1867 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1868 Operate on live windows only.
1869
2949f33b
JB
18702011-09-08 Juanma Barranquero <lekktu@gmail.com>
1871
1872 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1873
e08dcafd
EZ
18742011-09-07 Eli Zaretskii <eliz@gnu.org>
1875
1876 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1877 only under bidi iteration.
1878
115b96bd
JD
18792011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1880
1881 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1882
c8199d0f
PE
18832011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1884
1885 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1886 Without this fix, the command to link temacs failed due to an
1887 undefined symbol __builtin_isnan. This is because
1888 /usr/include/iso/math_c99.h #defines isnan(x) to
1889 __builtin_isnan(x), but the bundled gcc, which identifies itself
1890 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1891 a __builtin_isnan.
1892 * floatfns.c (isnan): #undef, and then #define to a clone of
1893 what's in data.c.
1894 (Fisnan): Always define, since it's always available now.
1895 (syms_of_floatfns): Always define isnan at the Lisp level.
1896
e39b275c 18972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1898
1899 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1900
b2db44d9 19012011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1902
f4af5137 1903 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1904 The previous code assumed that file offsets (off_t values) fit in
1905 EMACS_INT variables, which is not true on typical 32-bit hosts.
1906 The code messed up by falsely reporting buffer overflow in cases
1907 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1908 when "big" contains more than 2**29 bytes, even though this
1909 inserts just one byte and does not overflow the buffer.
1910 (Finsert_file_contents): Store file offsets as off_t
1911 values, not as EMACS_INT values. Check for overflow when
1912 converting between EMACS_INT and off_t. When checking for
1913 buffer overflow or for overlap, take the offsets into account.
1914 Don't use EMACS_INT for small values where int suffices.
1915 When checking for overlap, fix a typo: ZV was used where
1916 ZV_BYTE was intended.
1917 (Fwrite_region): Don't assume off_t fits into 'long'.
1918 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1919
ecfc0a49
MA
19202011-09-05 Michael Albinus <michael.albinus@gmx.de>
1921
1922 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1923
6511acf2 19242011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1925
0999621a 1926 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1927
1928 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1929 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1930 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1931 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1932 (modify_event_symbol): Do not assume that the length of
1933 name_alist_or_stem is safe to alloca and fits in int.
1934 (Fexecute_extended_command): Likewise for function name and binding.
1935 (Frecursion_depth): Wrap around reliably on integer overflow.
1936 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1937 since some callers pass EMACS_INT values.
1938 (Fsingle_key_description): Don't crash if symbol name contains more
1939 than MAX_ALLOCA bytes.
1940 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1941 (get_minibuffer): Arg is now EMACS_INT, not int.
1942 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1943 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1944 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1945
2be7d702
PE
1946 * dbusbind.c (signature_cat): New function.
1947 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1948 Do not overrun buffer; instead, report string overflow.
1949
9d1df220
PE
1950 * dispnew.c (add_window_display_history): Don't overrun buffer.
1951 Truncate instead; this is OK since it's just a log.
1952
33ef5c64
PE
1953 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1954 even if the time zone offset is outlandishly large.
1955 Don't mishandle offset == INT_MIN.
1956
66c6fdd5
PE
1957 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1958 when creating daemon; the previous buffer-overflow check was incorrect.
1959
d749b01b
PE
1960 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1961 which has the guts of the old verror function.
1962
b5cd1905
PE
1963 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1964 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1965
6e1a67fb
PE
1966 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1967 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1968 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1969 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1970 length of string rather than counting it via multiple sprintfs;
1971 that's simpler and more reliable.
c21721cc
PE
1972 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1973 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1974 sprintf, in case result does not fit in int.
1975
c57b67fc
PE
1976 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1977 (fontset_from_font): Print it.
1978
8a401434
PE
1979 * frame.c (tty_frame_count): Now printmax_t, not int.
1980 (make_terminal_frame, set_term_frame_name): Print it.
1981 (x_report_frame_params): In X, window IDs are unsigned long,
1982 not signed long, so print them as unsigned.
1983 (validate_x_resource_name): Check for implausibly long names,
1984 and don't assume name length fits in 'int'.
1985 (x_get_resource_string): Don't blindly alloca invocation name;
1986 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1987 not fit in int.
1988
6e1a67fb
PE
1989 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1990 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1991 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1992
0df02bf3
PE
1993 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1994 Use esprintf, not sprintf, in case result does not fit in int.
1995
48e30793
PE
1996 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1997 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1998 it as a large positive number.
1999 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2000 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2001
a66ff6d8
PE
2002 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2003 in case result does not fit in int.
2004
aca216ff
PE
2005 * print.c (float_to_string): Detect width overflow more reliably.
2006 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2007 buffer overrun. Don't assume list length fits in 'int'. Treat
2008 print length of 0 as 0, not as infinity; to be consistent with other
2009 uses of print length in this function. Don't overflow print length
2010 index. Don't assume hash table size fits in 'long', or that
2011 vectorlike size fits in 'unsigned long'.
2012
31c286f7
PE
2013 * process.c (make_process): Use printmax_t, not int, to format
2014 process-name gensyms.
2015
55e5faa1
PE
2016 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2017
80f2e268
PE
2018 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2019 to avoid potential buffer overrun.
2020
670741ab
PE
2021 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2022 if X resource line is longer than 512 bytes.
2023
b7163a50
PE
2024 * xfns.c (x_window): Make sprintf buffer a bit bigger
2025 to avoid potential buffer overrun.
2026
ae58ff1f
PE
2027 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2028
c43c8a6a
PE
2029 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2030
3f8236f4
PE
20312011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2032
53e9fe90 2033 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2034 Without these, Emacs silently mishandles large integers sometimes.
2035 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2036 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2037
6511acf2
PE
2038 * xdisp.c (try_window_id): Check Emacs fixnum range before
2039 converting to 'int'.
806add1d 2040
6511acf2 2041 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2042 Check that an Emacs fixnum is in range before assigning it to 'int'.
2043 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2044 values converted from Emacs fixnums.
2045 (Frecenter): Don't wrap around a line count if it is out of 'int'
2046 range; instead, treat it as an extreme value.
2047 (Fset_window_configuration, compare_window_configurations):
2048 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2049
6511acf2
PE
2050 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2051 that can exceed INT_MAX. Check that EMACS_INT value is in range
2052 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2053 (match_limit): Don't assume that a fixnum can fit in 'int'.
2054
6511acf2 2055 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2056 exceed INT_MAX.
2057
6511acf2 2058 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2059 (Fvertical_motion): Don't wrap around LINES values that don't fit
2060 in 'int'. Instead, treat them as extreme values. This is good
2061 enough for windows, which can't have more than INT_MAX lines anyway.
2062
fcb901a7
LMI
20632011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2064
0f2f6b6d
LMI
2065 * Require libxml/parser.h to avoid compilation warning.
2066
fcb901a7
LMI
2067 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2068
2069 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2070 since this reportedly can destroy thread storage.
2071
6e20a0d4
CY
20722011-08-30 Chong Yidong <cyd@stupidchicken.com>
2073
2074 * syntax.c (find_defun_start): Update all cache variables if
2075 exiting early (Bug#9401).
2076
148ae00e
EZ
20772011-08-30 Eli Zaretskii <eliz@gnu.org>
2078
f6cfbd8f
EZ
2079 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2080
148ae00e
EZ
2081 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2082 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2083 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2084
2085 * term.c (tty_append_glyph): New function.
2086 (produce_stretch_glyph): Static function and its prototype deleted.
2087
a66cfb1c
SM
2088 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2089 Add prototypes.
148ae00e 2090
c4a07a4c
PE
20912011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2092
2093 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2094 when checking :margin (Bug#9390).
2095 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2096 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2097 so that the name doesn't mislead. All uses changed.
2098
6bc8cd65
JB
20992011-08-28 Johan Bockgård <bojohan@gnu.org>
2100
2101 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2102 set_tty_hooks.
2103
dca4927e
EZ
21042011-08-27 Eli Zaretskii <eliz@gnu.org>
2105
2106 * xdisp.c (move_it_to): Don't bail out early when reaching
2107 position beyond to_charpos, if we are scanning backwards.
2108 (move_it_vertically_backward): When DY == 0, make sure we get to
2109 the first character in the line after the newline.
2110
f2cad773
PE
21112011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2112
2113 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2114 (ccl_driver): Do not generate an out-of-range pointer.
2115 (Fccl_execute_on_string): Remove unnecessary check for
2116 integer overflow, noted by Stefan Monnier in
2117 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2118 Remove a FIXME that didn't need fixing.
2119 Simplify the newly-introduced buffer reallocation code.
2120
0cae2cdb
JB
21212011-08-27 Juanma Barranquero <lekktu@gmail.com>
2122
2123 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2124
5fc295a4 21252011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2126
70c60eb2 2127 Integer and memory overflow issues (Bug#9196).
726e0ab1 2128
d31850da
PE
2129 * doc.c (get_doc_string): Rework so that
2130 get_doc_string_buffer_size is the actual buffer size, rather than
2131 being 1 less than the actual buffer size; this makes xpalloc more
2132 convenient.
2133
a69fbedb
PE
2134 * image.c (x_allocate_bitmap_record, cache_image):
2135 * xselect.c (Fx_register_dnd_atom):
2136 Simplify previous changes by using xpalloc.
2137
fe5c5d37
PE
2138 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2139 since either will do and ptrdiff_t is convenient with xpalloc.
2140
0065d054
PE
2141 * charset.c (charset_table_size)
2142 (struct charset_sort_data.priority): Now ptrdiff_t.
2143 (charset_compare): Don't overflow if priorities differ greatly.
2144 (Fsort_charsets): Don't assume list length fits in int.
2145 Check for size-calculation overflow when allocating sort data.
2146 (syms_of_charset): Allocate an initial charset table that is
2147 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2148
2149 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2150
2151 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2152 The actual value is always <= INT_MAX, and leaving it unsigned made
2153 overflow checking harder.
2154
2155 * dispextern.h (struct glyph_matrix.rows_allocated)
2156 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2157 with xpalloc. The values are still always <= INT_MAX.
2158
2159 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2160
2161 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2162 (SAFE_NALLOCA): New macro.
2163
2164 * region-cache.c (struct boundary.pos, find_cache_boundary)
2165 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2166 (set_cache_region, invalidate_region_cache)
2167 (revalidate_region_cache, know_region_cache, region_cache_forward)
2168 (region_cache_backward, pp_cache):
2169 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2170 so that ptrdiff_t * can be passed to xpalloc.
2171 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2172 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2173 (pp_cache): Don't assume cache_len fits in int.
2174 * region-cache.h: Adjust extern decls to match.
2175
2176 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2177 EMACS_INT, since either will do, for xpalloc.
2178
2179 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2180 (xnmalloc, xnrealloc, xpalloc): New functions.
2181
726e0ab1
PE
2182 * bidi.c (bidi_shelve_header_size): New constant.
2183 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2184 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2185
51f30bc5 2186 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2187 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2188 (overlay_strings):
2189 Don't update size of array until after memory allocation succeeds,
2190 because xmalloc/xrealloc may not return.
0065d054
PE
2191 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2192 now that we have proper integer overflow checking.
2193 (record_overlay_string, overlay_strings): Catch overflows when
2194 calculating size of overlay_str_buf.
726e0ab1 2195
0065d054
PE
2196 * callproc.c (Fcall_process): Check for size overflow when
2197 calculating size of args2.
2198 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2199 Normally we prefer signed values, but sticking with ptrdiff_t would
2200 require adding more-complicated checks.
726e0ab1
PE
2201
2202 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2203 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2204 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2205 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2206
2207 * character.c (Fstring): Check for size-calculation overflow.
2208
2209 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2210 unnecessary integer overflow. Check for size overflow.
2211 (encode_coding_object): Don't update size until xmalloc succeeds.
2212
2213 * composite.c (get_composition_id): Check for overflow in glyph
2214 length calculations.
2215
2216 Integer and memory overflow fixes for display code.
2217 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2218 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2219 (scrolling_window): Check for overflow in size calculations.
2220 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2221 Don't assume glyph table len fits in int.
2222 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2223 (row_table_size): Now ptrdiff_t, not int.
2224 (scrolling_window): Avoid overflow in size calculations.
2225 Don't update size until allocation succeeds.
2226 * fns.c (concat): Check for overflow in size calculations.
2227 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2228 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2229 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2230
2231 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2232 (get_doc_string): Check for size calculation overflow.
2233 Don't update size until allocation succeeds.
2234 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2235 EMACS_INT, where ptrdiff_t will do.
2236 (Fsubstitute_command_keys): Check for string overflow.
2237
2238 * editfns.c (set_time_zone_rule): Don't assume environment length
2239 fits in int.
2240 (message_length): Now ptrdiff_t, not int.
2241 (Fmessage_box): Don't update size until allocation succeeds.
2242 Don't assume message length fits in int.
2243 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2244
0065d054
PE
2245 * emacs.c (main): Do not reallocate argv, since there is a null at
2246 the end that can be overwritten, and this way there's no need to
2247 worry about size-calculation overflow.
2248 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2249
2250 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2251 alloc succeeds.
2252 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2253
2254 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2255 (x_set_scroll_bar_width, x_figure_window_size):
2256 Check for integer overflow.
2257 (x_set_alpha): Do not assume XINT fits in int.
2258
2259 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2260 This is for the members text_lines, text_cols, total_lines, total_cols,
2261 where the system imposes an 'int' limit.
2262
2263 * fringe.c (Fdefine_fringe_bitmap):
2264 Don't update size until alloc works.
2265
2266 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2267 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2268
2269 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2270 Check for size-calculation overflow.
2271 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2272 do, as we prefer signed integers.
2273 (id_to_widget.max_size, id_to_widget.used)
2274 (xg_store_widget_in_map, xg_remove_widget_from_map)
2275 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2276 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2277 Use and return ptrdiff_t, not int.
2278 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2279 * gtkutil.h: Change prototypes to match the above.
2280
2281 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2282 are duplicate now that they've been promoted to lisp.h.
2283 (x_allocate_bitmap_record, x_alloc_image_color)
2284 (make_image_cache, cache_image, xpm_load):
2285 Don't update size until alloc is done.
2286 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2287 (x_detect_edges):
3256efce 2288 Check for size calculation overflow.
726e0ab1
PE
2289 (ct_colors_allocated_max): New constant.
2290 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2291 overflow.
3256efce 2292
726e0ab1
PE
2293 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2294 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2295 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2296 Use ptrdiff_t, not int, to count maps.
2297 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2298 calculations. Don't update size until allocation succeeds.
2299 Redo calculations to avoid overflow.
726e0ab1
PE
2300 * keyboard.h: Change prototypes to match the above.
2301
2302 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2303 to count maps.
2304 (current_minor_maps): Check for size calculation overflow.
2305 * keymap.h: Change prototypes to match the above.
2306
2307 * lread.c (read1, init_obarray): Don't update size until alloc done.
2308
2309 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2310 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2311
726e0ab1
PE
2312 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2313 Now ptrdiff_t, not int.
2314 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2315 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2316
2317 * process.c (Fnetwork_interface_list): Check for overflow
2318 in size calculation.
2319
2320 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2321
2322 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2323 overflow. Don't bother calling xmalloc when xrealloc will do.
2324
2325 * search.c (Freplace_match): Check for size calculation overflow.
2326 (Fset_match_data): Don't assume list lengths fit in 'int'.
2327
2328 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2329 for command line length. Do not attempt to address one before the
2330 beginning of an array, as that's not portable.
2331
2332 * term.c (max_frame_lines): Remove; unused.
2333 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2334 not int.
2335 (encode_terminal_code, calculate_costs): Check for size
2336 calculation overflow.
2337 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2338 table lengths and related sizes. Don't update size until alloc
2339 done. Redo calculations to avoid overflow.
2340 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2341
2342 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2343 subtracting pointers.
2344 (gobble_line): Check for overflow more carefully. Don't update size
2345 until alloc done.
2346
2347 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2348 Don't update size until alloc done.
2349 Redo size calculations to avoid overflow.
2350 Check for size calculation overflow.
0065d054 2351 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2352
2353 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2354 Use ptrdiff_t, not int, for sizes.
2355 (store_mode_line_noprop_char): Don't update size until alloc done.
2356
0065d054
PE
2357 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2358 Use ptrdiff_t, not int, for sizes.
2359 (Finternal_make_lisp_face, cache_face):
2360 Check for size calculation overflow.
2361 (cache_face): Treat size calculation overflows as if they were
2362 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2363
2364 * xfns.c (x_encode_text, x_set_name_internal)
2365 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2366 sizes, since they can exceed INT_MAX in size. Check for size
2367 calculation overflow.
2368
0065d054
PE
2369 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2370 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2371 Don't update size until alloc done.
2372
0065d054 2373 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2374 as sprintf is limited to int lengths.
1d526e2f 2375
252c5ee1
PE
2376 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2377 (X_LONG_MIN): New macros.
864d7ce7
PE
2378 Use them to make the following changes clearer.
2379 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2380 This change doesn't affect the value now, but it may help remind
2381 future maintainers not to raise the value too much later.
2382 (SELECTION_QUANTUM): Remove, replacing with ...
2383 (selection_quantum): ... new function, which avoids overflow.
2384 All uses changed.
2385 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2386 assumption that selection length fits in 'int'.
2387 (x_reply_selection_request, x_handle_selection_request)
2388 (x_get_window_property, receive_incremental_selection)
2389 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2390 (lisp_data_to_selection_data, clean_local_selection_data):
2391 Use ptrdiff_t, not int, to record length of selection.
2392 (x_reply_selection_request, x_get_window_property)
2393 (receive_incremental_selection, x_property_data_to_lisp):
2394 Redo calculations to avoid overflow.
2395 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2396 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2397 something.
2398 (x_get_window_property, receive_incremental_selection)
2399 (lisp_data_to_selection_data, x_property_data_to_lisp):
2400 Check for size-calculation overflow.
2401 (x_get_window_property, receive_incremental_selection)
2402 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2403 Don't store size until memory allocation succeeds.
2404 (x_get_window_property): Plug memory leak on memory exhaustion.
2405 Don't double-block input; malloc is safe here. Don't assume 2**34
2406 - 4 fits in unsigned long. Add an xassert to check
2407 XGetWindowProperty overflow. Be more careful about overflow
2408 calculations, and distinguish size from memory overflow better.
2409 (receive_incremental_selection): When tracing, don't assume
2410 unsigned int is less than INT_MAX.
2411 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2412 harmful) conversions of unsigned short to int.
2413 (lisp_data_to_selection_data): Don't assume that integers
2414 in the range -65535 through -1 fit in an X unsigned short.
2415 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2416 result parameters unless successful. Rely on cons_to_unsigned
2417 to report problems with elements; the old code wasn't right anyway.
2418 (x_check_property_data): Check for int overflow; we cannot use
2419 a wider type due to X limits.
2420 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2421
726e0ab1 2422 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2423
0065d054
PE
2424 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2425 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2426 (x_color_cells): Don't store size until memory allocation succeeds.
2427 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2428 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2429 (x_term_init): Don't assume length fits in int (sprintf is limited
2430 to int size).
bc18e09d 2431
ebfa62c0
PE
2432 Use ptrdiff_t for composition IDs.
2433 * character.c (lisp_string_width):
2434 * composite.c (composition_table_size, n_compositions)
2435 (get_composition_id, composition_gstring_from_id):
2436 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2437 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2438 * window.c (Frecenter):
2439 Use ptrdiff_t, not int, for composition IDs.
2440 * composite.c (get_composition_id): Check for integer overflow.
2441 * composite.h: Adjust prototypes to match the above changes.
2442
d3411f89
PE
2443 Use ptrdiff_t for hash table indexes.
2444 * category.c (hash_get_category_set):
2445 * ccl.c (ccl_driver):
2446 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2447 * coding.c (coding_system_charset_list, detect_coding_system):
2448 * coding.h (struct coding_system.id):
2449 * composite.c (get_composition_id, gstring_lookup_cache):
2450 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2451 * image.c (xpm_get_color_table_h):
2452 * lisp.h (hash_lookup, hash_put):
2453 * minibuf.c (Ftest_completion):
2454 Use ptrdiff_t for hash table indexes, not int (which is too
2455 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2456 32-bit --with-wide-int hosts).
2457
e097a6fa
PE
2458 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2459 Add a FIXME comment about memory leaks.
2460 (syms_of_charset): Don't assume xmalloc returns.
2461
5637687f
PE
2462 Don't assume that stated character widths fit in int.
2463 * character.c (Fchar_width, c_string_width, lisp_string_width):
2464 * character.h (CHAR_WIDTH):
2465 * indent.c (MULTIBYTE_BYTES_WIDTH):
2466 Use sanitize_char_width to avoid undefined and/or bad behavior
2467 with outlandish widths.
a66cfb1c 2468 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2469 now that we have two such functions. All uses changed.
2470 (sanitize_char_width): New inline function.
2471
a2271ba2
PE
2472 Don't assume that tab-width fits in int.
2473 * character.h (sanitize_width): New inline function.
2474 (SANE_TAB_WIDTH): New macro.
2475 (ASCII_CHAR_WIDTH): Use it.
2476 * indent.c (sane_tab_width): Remove. All uses replaced by
2477 SANE_TAB_WIDTH (current_buffer).
2478 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2479
18c52557
PE
2480 * fileio.c: Integer overflow issues with file modes.
2481 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2482
caeeedc1
PE
2483 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2484 Remove unreachable code.
2485 (read_hex, load_charset_map_from_file): Check for integer overflow.
2486
6df6ae42 2487 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2488 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2489 (x_send_scroll_bar_event): Likewise. Check that the size does not
2490 exceed limits imposed by XClientMessageEvent, as well as the usual
2491 ptrdiff_t and size_t limits.
2492
b13995db
PE
2493 * keyboard.c: Overflow, signedness and related fixes.
2494 (make_lispy_movement): Use same integer type in forward decl
2495 that is used in the definition.
2496 (read_key_sequence, keyremap_step):
2497 Change bufsize argument back to int, undoing my 2011-03-30 change.
2498 We prefer signed types, and int is wide enough here.
2499 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2500 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2501 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2502 length, not size_t. Use ptrdiff_t for index, not int.
2503 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2504 possibility of integer overflow.
2505
13464394
PE
2506 Overflow, signedness and related fixes for images.
2507
2508 * dispextern.h (struct it.stack[0].u.image.image_id)
2509 (struct_it.image_id, struct image.id, struct image_cache.size)
2510 (struct image_cache.used, struct image_cache.ref_count):
2511 * gtkutil.c (update_frame_tool_bar):
2512 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2513 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2514 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2515 * nsmenu.m (update_frame_tool_bar):
2516 * xdisp.c (calc_pixel_width_or_height):
2517 * xfns.c (image_cache_refcount):
2518 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2519 on typical 64-bit hosts.
2520
2521 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2522 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2523 Omit unnecessary casts to int.
2524 (parse_image_spec): Check that integers fall into 'int' range
2525 when the callers expect that.
2526 (image_ascent): Redo ascent calculation to avoid int overflow.
2527 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2528 (lookup_image): Remove unnecessary tests.
2529 (xbm_image_p): Locals are now of int, not EMACS_INT,
2530 since parse_image_check makes sure they fit into int.
2531 (png_load, gif_load, svg_load_image):
2532 Prefer int to unsigned where either will do.
2533 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2534 old tiff_error_handler and tiff_warning_handler.
2535 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2536 stack buffer overflows. It uses only the features of vsnprintf
2537 that are common to both POSIX and native Microsoft.
2538 (tiff_error_handler, tiff_warning_handler): Use it.
2539 (tiff_load, gif_load, imagemagick_load_image):
2540 Don't assume :index value fits in 'int'.
2541 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2542 (imagemagick_load_image): Check that crop parameters fit into
2543 the integer types that MagickCropImage accepts. Don't assume
2544 Vimagemagick_render_type has a nonnegative value. Don't assume
2545 size_t fits in 'long'.
2546 (gs_load): Use printmax_t to print the widest integers possible.
2547 Check for integer overflow when computing image height and width.
2548
c11821d4
EZ
25492011-08-26 Eli Zaretskii <eliz@gnu.org>
2550
2551 * xdisp.c (redisplay_window): Don't force window start if point
2552 will be invisible in the resulting window. (Bug#9324)
2553
0c95fcf7
EZ
25542011-08-25 Eli Zaretskii <eliz@gnu.org>
2555
2556 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2557 the display spec is of the form `(space ...)'.
2558 (handle_display_spec): Return the value returned by
2559 handle_single_display_spec, not just 1 or zero.
2560 (handle_single_display_spec): If the display spec is of the form
2561 `(space ...)', and specifies display in the text area, return 2
2562 rather than 1.
fee65a97 2563 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2564 accurately, and prefer exact match for point under bidi.
2565 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2566
2567 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2568 into disp_prop; all users changed.
2569
2570 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2571 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2572 for the text covered by the display property.
2573
e4ed06f1
CY
25742011-08-25 Chong Yidong <cyd@stupidchicken.com>
2575
2576 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2577 Change return value to nil.
2578 (Frecord_buffer): Delete unused function.
2579
f67cdd7f
EZ
25802011-08-24 Eli Zaretskii <eliz@gnu.org>
2581
5980d4c6
EZ
2582 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2583 buffers, return left-to-right.
8610fe8b
EZ
2584 (set_cursor_from_row): Consider candidate row a win if its glyph
2585 represents a newline and point is on that newline. Fixes cursor
2586 positioning on the newline at EOL of R2L text within L2R
2587 paragraph, and vice versa.
2588 (try_cursor_movement): Check continued rows, in addition to
2589 continuation rows. Fixes unwarranted scroll when point enters a
2590 continued line of R2L text within an L2R paragraph, or vice versa.
2591 (cursor_row_p): Consider the case of point being equal to
2592 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2593 from the end of a short line to the beginning of a continued line
2594 of R2L text within L2R paragraph.
2595 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2596 composed characters.
5980d4c6 2597
f67cdd7f
EZ
2598 * bidi.c (bidi_check_type): Use xassert.
2599 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2600 members.
2601
bca633fb
EZ
26022011-08-23 Eli Zaretskii <eliz@gnu.org>
2603
2604 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2605 a character.
2606
4a5885a7
CY
26072011-08-23 Chong Yidong <cyd@stupidchicken.com>
2608
2609 * nsfont.m (ns_otf_to_script): Fix typo.
2610
0902a04e
KH
26112011-08-22 Kenichi Handa <handa@m17n.org>
2612
2613 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2614 extra slot even if the purpose is char-code-property-table.
2615
1a2e6670
EZ
26162011-08-23 Eli Zaretskii <eliz@gnu.org>
2617
8ddde651
EZ
2618 * xdisp.c (redisplay_window): When computing centering_position,
2619 account for the height of the header line. (Bug#8874)
2620
425cc014
EZ
2621 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2622 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2623 candidate is selected by the mouse, and that candidate has a
2624 composed character under the mouse.
2625
1a2e6670
EZ
2626 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2627 coordinates reported by pos-visible-in-window-p for a composed
2628 character in column zero.
2629
8b76d6f8
SM
26302011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2631
2632 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2633
dac347dd
EZ
26342011-08-22 Eli Zaretskii <eliz@gnu.org>
2635
2636 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2637 consider it a hit if to_charpos is anywhere in the range of the
2638 composed buffer positions.
2639
e013fb34
CY
26402011-08-22 Chong Yidong <cyd@stupidchicken.com>
2641
2642 * image.c (gif_load): Don't assume that each subimage has the same
2643 dimensions as the base image. Handle disposal method that is
2644 "undefined" by the gif spec (Bug#9335).
2645
bd1ba3e8
CY
26462011-08-20 Chong Yidong <cyd@stupidchicken.com>
2647
2648 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2649 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2650
54a1215b
EZ
26512011-08-19 Eli Zaretskii <eliz@gnu.org>
2652
823564e5
EZ
2653 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2654 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2655 from an Org mode buffer to a Speedbar frame.
2656
54a1215b
EZ
2657 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2658 a composition, take its buffer position from IT->cmp_it.charpos.
2659 Fixes cursor positioning at the beginning of a line that begins
2660 with a composed character.
2661
9778ebcc
EZ
26622011-08-18 Eli Zaretskii <eliz@gnu.org>
2663
0be6ee06
EZ
2664 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2665 character bidirectional type, use STRONG_L instead. Fixes crashes
2666 in a buffer produced by `describe-categories'.
2667
9778ebcc
EZ
2668 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2669 members before the level stack, so they would be saved and
2670 restored when copying iterator state. Fixes incorrect reordering
2671 around TABs covered by display properties.
2672
156bffbe
AS
26732011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2674
6b02f655 2675 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2676
72ad093b
CY
26772011-08-17 Chong Yidong <cyd@stupidchicken.com>
2678
2679 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2680 (internal_condition_case_2, internal_condition_case_n):
2681 Remove unnecessary aborts (Bug#9081).
72ad093b 2682
35774242
EZ
26832011-08-17 Eli Zaretskii <eliz@gnu.org>
2684
2685 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2686 has no `load' handler, try opening the file locally. (Bug#9311)
2687
db76dd85
KB
26882011-08-16 Ken Brown <kbrown@cornell.edu>
2689
2690 * gmalloc.c: Expand comment.
2691
b215eee5
EZ
26922011-08-16 Eli Zaretskii <eliz@gnu.org>
2693
2694 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2695 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2696
a4579d33
KB
26972011-08-16 Ken Brown <kbrown@cornell.edu>
2698
2699 Fix memory allocation problems in Cygwin build (Bug#9273).
2700
2701 * unexcw.c ( __malloc_initialized): Declare external variable.
2702 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2703
8b76d6f8
SM
2704 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2705 New variables.
a4579d33
KB
2706 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2707 dumped emacs.
2708 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2709 in the static heap.
2710 [CYGWIN] (special_realloc): New function.
2711 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2712 requests to realloc storage in the static heap.
2713
3ebec551
PE
27142011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2715
2716 * bidi.c (bidi_initialize): Remove unused local.
2717
9fd8be00
EZ
27182011-08-15 Eli Zaretskii <eliz@gnu.org>
2719
6b02f655
SM
2720 * bidimirror.h:
2721 * biditype.h: Remove file.
2722 * makefile.w32-in ($(BLD)/bidi.$(O)):
2723 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2724
2725 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2726
2727 * chartab.c: Improve commentary for the uniprop_table API.
2728
32413314
EZ
2729 * bidi.c (bidi_paragraph_init): Support zero value of
2730 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2731 (bidi_initialize): Use uniprop_table instead of including
2732 biditype.h and bidimirror.h.
32413314 2733
9fd8be00
EZ
2734 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2735 coordinates of the iterator when restoring from ppos_it.
2736 (Bug#9296)
2737
5cf2b69b
KH
27382011-08-14 Kenichi Handa <handa@m17n.org>
2739
2740 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2741 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2742
daf17d00
EZ
27432011-08-14 Eli Zaretskii <eliz@gnu.org>
2744
2745 * xdisp.c (move_it_in_display_line_to): Don't invoke
2746 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2747 ppos_it. Fixes vertical cursor motion when line beginning is
2748 covered by an image. (Bug#9296)
2749
08e3161a
JD
27502011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2751
2752 * nsterm.h (ns_run_ascript): Declare.
2753 (NSAPP_DATA2_RUNASSCRIPT): Define.
2754
2755 * nsfns.m (as_script, as_result, as_status): New static variables.
2756 (ns_run_ascript): New function.
5e617bc2 2757 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2758 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2759 the event loop. Get status from as_status (Bug#7276).
2760
2761 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2762 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2763 the event loop (Bug#7276).
2764
a3720aa2
AS
27652011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2766
2767 * gnutls.c (QCgnutls_bootprop_priority)
2768 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2769 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2770 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2771 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2772 (QCgnutls_bootprop_verify_hostname_error)
2773 (QCgnutls_bootprop_callbacks_verify): Rename from
2774 Qgnutls_bootprop_..., all uses changed.
2775
2776 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2777 uses changed.
2778
0a0d27fb
PE
27792011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2780
19d5c50c
PE
2781 * xfaces.c (Qframe_set_background_mode): Now static.
2782 * dispextern.h (Qframe_set_background_mode): Remove decl.
2783
0a0d27fb
PE
2784 * process.c (Fnetwork_interface_info): Declare local only if needed.
2785
377538cb
JD
27862011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2787
2788 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2789 (Fnetwork_interface_list): Allocate in increments of bytes instead
2790 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2791 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2792 sockaddr.
2793 (struct ifflag_def): notrailers is smart on OSX.
2794 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2795 Get hardware address with getifaddrs if available.
2796
08fff70c
EZ
27972011-08-12 Eli Zaretskii <eliz@gnu.org>
2798
2799 * xdisp.c (iterate_out_of_display_property): xassert that
2800 IT->position is set to within IT->object's boundaries. Break from
2801 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2802 when IT->position is set up wrongly due to some bug.
2803 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2804 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2805 entry. Force push_it to save on the stack the current
2806 buffer/string position, to be restored by pop_it. Fix flags in
2807 the iterator structure wrt the object coming from a display
2808 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2809 properties. (Bug#9284)
2810
7be1c708 28112011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2812
7be1c708
CY
2813 * fontset.c (fontset_get_font_group): Add proper type checks.
2814 (Bug#9172)
aac0c6e3 2815
7be1c708 28162011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2817
7be1c708
CY
2818 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2819 and LC_VERSION_MIN_MACOSX.
2820 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2821 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2822
97bb72a6
EZ
28232011-08-08 Eli Zaretskii <eliz@gnu.org>
2824
2825 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2826 no-display-properties-and-no-overlays under bidi display.
2827 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2828 properties and overlays.
97bb72a6 2829
d5617611
CY
28302011-08-08 Chong Yidong <cyd@stupidchicken.com>
2831
37e11a63
CY
2832 * editfns.c (Fset_time_zone_rule): Document relationship with the
2833 setenv function.
2834
d5617611
CY
2835 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2836 the font entity extracted from the cache (Bug#8109).
2837
58872834
CY
28382011-08-07 Chong Yidong <cyd@stupidchicken.com>
2839
2840 * composite.c (autocmp_chars): Don't reset point. That is done by
2841 restore_point_unwind (Bug#5984).
2842
75bfc667
JL
28432011-08-07 Juri Linkov <juri@jurta.org>
2844
2845 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2846 to show the arg `TIME' instead of `TIMEVAL'.
2847
d1410150
EZ
28482011-08-06 Eli Zaretskii <eliz@gnu.org>
2849
2850 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2851 display property strides EOL and includes a newline, as in
2852 longlines-mode. (Bug#9254)
75b771e4
EZ
2853 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2854 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2855
2856 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2857 is non-zero, even if the data buffer is NULL. Fixes a crash in
2858 vertical-motion with longlines-mode. (Bug#9254)
2859
35928349
EZ
28602011-08-05 Eli Zaretskii <eliz@gnu.org>
2861
ec7cc85b
EZ
2862 * bidi.c <bidi_cache_total_alloc>: Now static.
2863 (bidi_initialize): Initialize bidi_cache_total_alloc.
2864
8b76d6f8 2865 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2866 cache. (Bug#9221)
2867
2868 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2869 amount allocated this far in `bidi_cache_total_alloc'.
2870 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2871 non-zero, only free the data buffer without restoring the cache
2872 contents. All callers changed.
2873
2874 * dispextern.h (bidi_unshelve_cache): Update prototype.
2875
2876 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2877 (move_it_in_display_line, move_it_to)
2878 (move_it_vertically_backward, move_it_by_lines): Replace the call
2879 to xfree to an equivalent call to bidi_unshelve_cache.
2880 (move_it_in_display_line_to): Fix logic of returning
412b6358 2881 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2882
e2e2423b
EZ
28832011-08-05 Eli Zaretskii <eliz@gnu.org>
2884
2885 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2886 came from a string character with a `cursor' property. (Bug#9229)
2887
ae9e757a
JD
28882011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2889
2890 * Makefile.in (LIB_PTHREAD): New variable.
2891 (LIBES): Add LIB_PTHREAD (Bug#9216).
2892
2893 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2894 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2895
213bd7f2
AS
28962011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2897
6b02f655 2898 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2899
99aaf75f
JD
29002011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2901
2902 * xterm.c (x_find_topmost_parent): New function.
2903 (x_set_frame_alpha): Find topmost parent window with
2904 x_find_topmost_parent and set the property there also (bug#9181).
2905 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2906
c74e9d86
PE
29072011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2908
2909 * callproc.c (Fcall_process): Avoid vfork clobbering
2910 the local vars buffer, coding_systems, current_dir.
2911
640c8776
SM
29122011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2913
2914 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2915
f26d0e4c
PE
29162011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2917
8a10d76c
PE
2918 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2919 so that it is not optimized away.
2920
f26d0e4c
PE
2921 * xdisp.c (compute_display_string_pos): Remove unused local.
2922
55439c61
EZ
29232011-08-02 Eli Zaretskii <eliz@gnu.org>
2924
2925 Fix slow cursor motion and scrolling in large buffers with
2926 selective display, like Org Mode buffers. (Bug#9218)
2927
2928 * dispextern.h (struct bidi_it): New member disp_prop_p.
2929
2930 * xdisp.c: Remove one-slot cache of display string positions.
2931 (compute_display_string_pos): Accept an additional argument
5e617bc2 2932 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2933 for a display string or property. If found, set DISP_PROP_P
2934 non-zero.
2935
2936 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2937 DISP_PROP_P, and pass it to compute_display_string_pos.
2938 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2939 non-zero. All callers of bidi_fetch_char changed.
2940
fb33fa43
SM
29412011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2942
2943 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2944
b099e063
DM
29452010-12-03 Don March <don@ohspite.net>
2946
2947 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2948 last character M-[char] is translated to ESC [char] (bug#7541).
2949
5cc7f7af
KH
29502011-08-02 Kenichi Handa <handa@m17n.org>
2951
d0fffa3f 2952 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2953
2954 * chartab.c (uniprop_table): Make it non-static.
2955
525d5e6e
EZ
29562011-08-01 Eli Zaretskii <eliz@gnu.org>
2957
2958 * xdisp.c (forward_to_next_line_start): Accept additional argument
2959 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2960 on the newline.
2961 (reseat_at_next_visible_line_start): Use the bidi iterator state
2962 returned by forward_to_next_line_start to restore the state of
2963 it->bidi_it after backing up to previous newline. (Bug#9212)
2964
31011111
AS
29652011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2966
2967 * regex.c (re_comp): Protoize.
2968 (re_exec): Fix return type.
2969 (regexec): Fix type of `ret'. (Bug#9203)
2970
476371c4
PE
29712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2972
e5d76069
PE
2973 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2974 This is needed if max-image-size is a floating-point number.
2975
9a79b20c
AS
29762011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2977
2978 * print.c (print_object): Print empty symbol as ##.
2979
2980 * lread.c (read1): Read ## as empty symbol.
2981
d8c2fa78
AA
29822011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2983
2984 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2985 setting frame foreground color (Bug#9175).
2986 (x_set_background_color): Likewise.
2987
ffe57a7a
AA
2988 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2989 contents (Bug#9176).
2990 (EmacsTooltip -init): Remove bezels and add shadows to
2991 tooltip windows.
2992
bf3492a5
AA
2993 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2994 or scroll bar (Bug#8470).
2995
d55e9c53
AA
2996 * nsfont.m (nsfont_open): Remove assignment to voffset and
2997 unnecessary vars hshink, expand, hd, full_height, min_height.
2998 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2999
3000 * nsterm.h (nsfont_info): Remove voffset field.
3001
d8c2fa78 30022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3003
3004 Implement strike-through and overline on NextStep (Bug#8863).
3005
3006 * nsfont.m (nsfont_open): Use underline position provided by font,
3007 instead of hard-coded value of 2.
3008 (nsfont_draw): Call ns_draw_text_decoration instead.
3009
3010 * nsterm.h: Add declaration for ns_draw_text_decoration.
3011
3012 * nsterm.m (ns_draw_text_decoration): New function for drawing
3013 underline, overline, and strike-through.
3014 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3015 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3016 accommodate underlining, etc.
4843aac3 3017
4cc60b9b
EZ
30182011-07-28 Eli Zaretskii <eliz@gnu.org>
3019
bc7ece87
EZ
3020 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3021 default.
4cc60b9b 3022
476371c4
PE
30232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3024
66606eea
PE
3025 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3026 Without this fix, if a signal arrives just after memory fills up,
3027 'malloc' might be invoked reentrantly.
3028
476371c4
PE
3029 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3030 In other words, assume that every image size is allowed, on non-X
3031 hosts. This assumption is probably wrong, but it lets Emacs compile.
3032
f3fcc40d
AS
30332011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3034
3035 * regex.c (re_iswctype): Convert return values to boolean.
3036
350c992f
EZ
30372011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3038
3039 * xdisp.c (compute_display_string_pos): Don't use cached display
3040 string position if the buffer had its restriction changed.
3041 (Bug#9184)
3042
5266b4bb
PE
30432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3044
3045 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3046
2573a837 30472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3048
41f55ccd 3049 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3050
39e378da
PE
3051 * bidi.c: Integer size and overflow fixes.
3052 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3053 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3054 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3055 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3056 (bidi_find_other_level_edge):
3057 Use ptrdiff_t instead of EMACS_INT where either will do.
3058 This works better on 32-bit hosts configured --with-wide-int.
3059 (bidi_cache_ensure_space): Check for size-calculation overflow.
3060 Use % rather than repeated addition, for better worst-case speed.
3061 Don't set bidi_cache_size until after xrealloc returns, because it
3062 might not return.
3063 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3064 (bidi_cache_ensure_space): Also check that the bidi cache size
3065 does not exceed that of the largest Lisp string or buffer. See Eli
3066 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3067
5e927815
PE
3068 * alloc.c (__malloc_size_t): Remove.
3069 All uses replaced by size_t. See Andreas Schwab's note
3070 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3071
ca4aa935
PE
3072 * image.c: Improve checking for integer overflow.
3073 (check_image_size): Assume that f is nonnull, since
3074 it is always nonnull in practice. This is one less thing to
3075 worry about when checking for integer overflow later.
3076 (x_check_image_size): New function, which checks for integer
3077 overflow issues inside X.
3078 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3079 This removes the need for a memory_full check.
3080 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3081 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3082 (xbm_read_bitmap_data): Change locals back to 'int', since
3083 their values must fit in 'int'.
3084 (xpm_load_image, png_load, tiff_load):
3085 Invoke x_create_x_image_and_pixmap earlier,
3086 to avoid much needless work if the image is too large.
3087 (tiff_load): Treat overly large images as if
3088 x_create_x_image_and_pixmap failed, not as malloc failures.
3089 (gs_load): Use x_check_image_size.
3090
5f8f9cc2
PE
3091 * gtkutil.c: Omit integer casts.
3092 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3093 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3094
5adf60bc
PE
3095 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3096
c8907a93
PE
3097 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3098 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3099 would wrongly return t on a 64-bit host.
3100
e3c25c68
PE
3101 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3102 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3103 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3104 and therefore cause GCC to emit a bogus diagnostic in some cases.
3105
3f791afe
PE
3106 * image.c: Integer signedness and overflow and related fixes.
3107 This is not an exhaustive set of fixes, but it's time to
3108 record what I've got.
3109 (lookup_pixel_color, check_image_size): Remove redundant decls.
3110 (check_image_size): Don't assume that arbitrary EMACS_INT values
3111 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3112 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3113 (tiff_load, imagemagick_load_image):
3114 Check for overflow in size calculations.
3115 (x_create_x_image_and_pixmap): Remove unnecessary test for
3116 xmalloc returning NULL; that can't happen.
3117 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3118 (xpm_color_bucket): Use better integer hashing function.
3119 (xpm_cache_color): Don't possibly over-allocate memory.
3120 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3121 (gif_memory_source):
3122 Use ptrdiff_t, not int or size_t, to record sizes.
3123 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3124 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3125 either works, as we prefer signed integers.
3126 (tiff_read_from_memory, tiff_write_from_memory):
3127 Return tsize_t, not size_t, since that's what the TIFF API wants.
3128 (tiff_read_from_memory): Don't fail simply because the read would
3129 go past EOF; instead, return a short read.
3130 (tiff_load): Omit no-longer-needed casts.
3131 (Fimagemagick_types): Don't assume size fits into 'int'.
3132
3cc5a532
PE
3133 Improve hashing quality when configured --with-wide-int.
3134 * fns.c (hash_string): New function, taken from sxhash_string.
3135 Do not discard information about ASCII character case; this
3136 discarding is no longer needed.
3137 (sxhash-string): Use it. Change sig to match it. Caller changed.
3138 * lisp.h: Declare it.
3139 * lread.c (hash_string): Remove, since we now use fns.c's version.
3140 The fns.c version returns a wider integer if --with-wide-int is
3141 specified, so this should help the quality of the hashing a bit.
3142
b312a492
PE
3143 * emacs.c: Integer overflow minor fix.
3144 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3145 Define only if GNU_LINUX.
3146 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3147
dfd153ae
PE
3148 * dispnew.c: Integer signedness and overflow fixes.
3149 Remove unnecessary forward decls, that were a maintenance hassle.
3150 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3151 All uses changed.
3152 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3153 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3154 (prepare_desired_row, line_draw_cost):
3155 Use int, not unsigned, where either works.
3156 (save_current_matrix, restore_current_matrix):
3157 Use ptrdiff_t, not size_t, where either works.
3158 (init_display): Check for overflow more accurately, and without
3159 relying on undefined behavior.
3160
a81d11a3
PE
3161 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3162 Remove, replacing with the new symbols in lisp.h. All uses changed.
3163 * fileio.c (make_temp_name):
3164 * filelock.c (lock_file_1, lock_file):
3165 * xdisp.c (message_dolog):
3166 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3167 Use pMd etc. instead.
3168 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3169 replacing the pWIDE etc. symbols removed from editfns.c.
3170
3300e6fd
PE
3171 * keyboard.h (num_input_events): Now uintmax_t.
3172 This is (very slightly) less likely to mess up due to wraparound.
3173 All uses changed.
3174
fd05c7e9
PE
3175 * buffer.c: Integer signedness fixes.
3176 (alloc_buffer_text, enlarge_buffer_text):
3177 Use ptrdiff_t rather than size_t when either will do, as we prefer
3178 signed integers.
3179
903fe15d
PE
3180 * alloc.c: Integer signedness and overflow fixes.
3181 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3182 (__malloc_size_t): Default to size_t, not to int.
3183 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3184 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3185 Prefer ptrdiff_t to size_t when either would do, as we prefer
3186 signed integers.
3187 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3188 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3189 Now const. Initialize with values that are in range even if char
3190 is signed.
3191 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3192 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3193 These functions do the right thing with sizes > 2**32.
3194 (check_depth): Now ptrdiff_t, not int.
3195 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3196 Adjust to new way of storing sizes. Check for size overflow bugs
3197 in rest of code.
3198 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3199 slightly wrong anyway, as it missed one instance of
3200 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3201 (refill_memory_reserve): Omit needless cast to size_t.
3202 (mark_object_loop_halt): Mark as externally visible.
3203
ac82cc6a
PE
3204 * xselect.c: Integer signedness and overflow fixes.
3205 (Fx_register_dnd_atom, x_handle_dnd_message):
3206 Use ptrdiff_t, not size_t, since we prefer signed.
3207 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3208 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3209 x_dnd_atoms_size and x_dnd_atoms_length.
3210
c2d1e36d
PE
3211 * doprnt.c: Prefer signed to unsigned when either works.
3212 * eval.c (verror):
3213 * doprnt.c (doprnt):
3214 * lisp.h (doprnt):
3215 * xdisp.c (vmessage):
3216 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3217 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3218 prefer signed arithmetic to avoid comparison confusion.
3219 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3220 but is a bit tricky.
3221
0e926e56
PE
3222 Assume freestanding C89 headers, string.h, stdlib.h.
3223 * data.c, doprnt.c, floatfns.c, print.c:
3224 Include float.h unconditionally.
3225 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3226 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3227 * regex.c: Likewise for stddef.h, string.h.
3228 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3229 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3230 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3231 (STDC_HEADERS): Remove obsolete defines.
3232 * sysdep.c: Include limits.h unconditionally.
3233
9cfdb3ec
PE
3234 Assume support for memcmp, memcpy, memmove, memset.
3235 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3236 * regex.c (memcmp, memcpy):
3237 Remove; we assume C89 now.
3238
3239 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3240 (__malloc_safe_bcopy): Remove; no longer needed.
3241
cf950e6b 3242 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3243 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3244 well either way, and we prefer signed to unsigned.
3245
dbf38e02
LMI
32462011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3247
3248 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3249 closes the connection while we're reading (bug#9182).
3250
d6f0886c 32512011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3252
d6f0886c
JD
3253 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3254 are specified (Bug#9168).
24e0f6b1 3255
2eb1f9e6
PE
32562011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3257
3258 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3259 Found by GCC static checking and --with-wide-int on a 32-bit host.
3260
22381272 32612011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3262
3263 * xdisp.c (compute_display_string_pos): Fix logic of caching
3264 previous display string position. Initialize cached_prev_pos to
3265 -1. Fixes slow-down at the beginning of a buffer.
3266
f25e39b4
EZ
32672011-07-24 Eli Zaretskii <eliz@gnu.org>
3268
3269 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3270 for attrs[LFACE_FONTSET_INDEX].
3271
04c4b52e
PE
32722011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3273
3274 * xml.c (parse_region): Remove unused local
3275 that was recently introduced.
3276
c1734fbd
EZ
32772011-07-23 Eli Zaretskii <eliz@gnu.org>
3278
be18c5a5
EZ
3279 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3280 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3281
c1734fbd
EZ
3282 * xdisp.c (move_it_in_display_line_to): Record the best matching
3283 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3284 exit if none of the characters scanned was an exact match.
3285 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3286 when exact match is impossible due to invisible text, and the
3287 lines are truncated.
3288
a258d627
JD
32892011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3290
3291 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3292 for OSX >= 10.7.
3293
b6d5a689
EZ
32942011-07-22 Eli Zaretskii <eliz@gnu.org>
3295
0f74f785
EZ
3296 Fix a significant slow-down of cursor motion with C-n, C-p,
3297 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3298 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3299 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3300 (next_element_from_buffer): Call compute_stop_pos_backwards to
3301 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3302 base_level_stop.
3303 (reseat): Don't look for prev_stop, as that could mean a very long
3304 run.
3305 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3306 <cached_disp_overlay_modiff>: Cache for last found display string
3307 position.
551918c1 3308 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3309 about the same buffer in the same area of character positions, and
3310 the buffer wasn't changed since the time the display string
3311 position was cached.
551918c1 3312
b2d0c91a
EZ
33132011-07-22 Eli Zaretskii <eliz@gnu.org>
3314
3315 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3316 is an integer, which is important for empty lines. (Bug#9149)
3317
043604ee
CY
33182011-07-22 Chong Yidong <cyd@stupidchicken.com>
3319
3320 * frame.c (Fmodify_frame_parameters): In tty case, update the
3321 default face if necessary (Bug#4238).
3322
da4adb04
CY
33232011-07-21 Chong Yidong <cyd@stupidchicken.com>
3324
3325 * editfns.c (Fstring_to_char): No need to explain what a character
3326 is in the docstring (Bug#6576).
3327
9abd0532
LMI
33282011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3329
3330 * xml.c (parse_region): Make sure we always return a tree.
3331
36881d16
HK
33322011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3333
3334 * xml.c (parse_region): If a document contains only comments,
3335 return that, too.
3336
1e98674d
LMI
33372011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3338
3339 * xml.c (make_dom): Return comments, too.
3340
590bd467
PE
33412011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3342
3343 Port to OpenBSD.
3344 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3345 and the surrounding thread.
3346 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3347 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3348 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3349 timer goes off.
3350 * s/openbsd.h (BROKEN_SIGIO): Define.
3351 * unexelf.c (unexec) [__OpenBSD__]:
3352 Don't update the .mdebug section of the Alpha COFF symbol table.
3353
f41628b2
LMI
33542011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3355
3356 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3357 (bug#8460).
3358
b59b67c5
PE
33592011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3360
15e3a074
PE
3361 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3362 This fixes some race conditions on the permissions of any newly
3363 created file.
3364
41bed37d
PE
3365 * alloc.c (valid_pointer_p): Use pipe, not open.
3366 This fixes some permissions issues when debugging.
3367
b59b67c5
PE
3368 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3369 If fchown fails to set both uid and gid, try to set just gid,
3370 as that is sometimes allowed. Adjust the file's mode to eliminate
3371 setuid or setgid bits that are inappropriate if fchown fails.
3372
925a6be7
SM
33732011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3374
3375 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3376 to compare Lisp_Objects.
3377 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3378 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3379 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3380
52968808
AS
33812011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3382
0a6a104b
AS
3383 * lread.c (read_integer): Unread even EOF character.
3384 (read1): Likewise. Properly record start position of symbol.
3385
52968808
AS
3386 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3387 symbol character follows.
3388
9e381cdd
PE
33892011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3390
3391 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3392 This works around a problem with the previous change to Fcopy_file.
3393 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3394 and without this change, GCC might complain about discarding
3395 fchown's return value.
3396
b5641435
JB
33972011-07-16 Juanma Barranquero <lekktu@gmail.com>
3398
3399 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3400
a8031457
PE
34012011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3402
3403 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3404
dd889327
LMI
34052011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3406
750c33f7
LMI
3407 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3408 it's used from the C level.
3409
dd889327
LMI
3410 * process.c: Use the same condition for POLL_FOR_INPUT in both
3411 keyboard.c and process.c (bug#1858).
3412
87e86684
LM
34132011-07-09 Lawrence Mitchell <wence@gmx.li>
3414
3415 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3416 (Fgnutls_boot): Use it.
3417
64348f40
AS
34182011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3419
3420 * doc.c (Fsubstitute_command_keys): Revert last change.
3421
1d698799
LMI
34222011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3423
f863868c
LMI
3424 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3425 quotes the next character, and doesn't affect other longer
3426 sequences (bug#8935).
3427
1d698799
LMI
3428 * lread.c (syms_of_lread): Clarify that is isn't only
3429 `eval-buffer' and `eval-defun' that's affected by
3430 `lexical-binding' (bug#8460).
3431
aa4b6df6
EZ
34322011-07-15 Eli Zaretskii <eliz@gnu.org>
3433
3434 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3435 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3436
5d856da6
PE
34372011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3438
ad6042bb
PE
3439 Fix minor problems found by static checking.
3440 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3441 (elsz): Now a signed constant, not a size_t var. We prefer signed
3442 types to unsigned, to avoid integer comparison confusion. Without
3443 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3444 "cannot optimize loop, the loop counter may overflow", a symptom
3445 of the confusion.
f00bbb22 3446 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3447 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3448
6468f31c
LMI
34492011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3450
49080b10
LMI
3451 * search.c (Fre_search_backward): Mention `case-fold-search' in
3452 all the re_search_* functions (bug#8138).
3453
6468f31c
LMI
3454 * keyboard.c (Fopen_dribble_file): Document when the file is
3455 closed (bug#8056).
3456
c965adc5
EZ
34572011-07-14 Eli Zaretskii <eliz@gnu.org>
3458
df9733bf
EZ
3459 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3460 bidi_cache_idx.
3461
0bb23927
EZ
3462 Support bidi reordering of display and overlay strings.
3463 * xdisp.c (compute_display_string_pos)
3464 (compute_display_string_end): Accept additional argument STRING.
3465 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3466 (reseat_to_string): Initialize bidi_it->string.s and
3467 bidi_it->string.schars.
3468 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3469 NULL (avoids a crash in bidi_paragraph_init).
3470 Initialize itb.string.lstring.
0bb23927
EZ
3471 (init_iterator): Call bidi_init_it only of a valid
3472 buffer position was specified. Initialize paragraph_embedding to
3473 L2R.
3474 (reseat_to_string): Initialize the bidi iterator.
3475 (display_string): If we need to ignore text properties of
3476 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3477 original value of -1 will not work with bidi.)
3478 (compute_display_string_pos): First arg is now struct
3479 `text_pos *'; all callers changed. Support display properties on
3480 Lisp strings.
3481 (compute_display_string_end): Support display properties on Lisp
3482 strings.
3483 (init_iterator, reseat_1, reseat_to_string): Initialize the
3484 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3485 when iterating on a string not from display properties).
640c8776
SM
3486 (compute_display_string_pos, compute_display_string_end):
3487 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3488 arrow keys.
3489 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3490 base_level_stop; instead, set base_level_stop to BEGV.
3491 Fixes crashes in vertical-motion.
0bb23927
EZ
3492 (next_element_from_buffer): Improve commentary for when
3493 the iterator is before prev_stop.
3494 (init_iterator): Initialize bidi_p from the default value of
3495 bidi-display-reordering, not from buffer-local value. Use the
3496 buffer-local value only if initializing for buffer iteration.
3497 (handle_invisible_prop): Support invisible properties on strings
3498 that are being bidi-reordered.
3499 (set_iterator_to_next): Support bidi reordering of C strings and
3500 Lisp strings.
3501 (next_element_from_string): Support bidi reordering of Lisp
3502 strings.
3503 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3504 (display_string): Support display of R2L glyph rows.
3505 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3506 (init_iterator): Don't initialize it->bidi_p for strings
3507 here.
3508 (reseat_to_string): Initialize it->bidi_p for strings here.
3509 (next_element_from_string, next_element_from_c_string)
3510 (next_element_from_buffer): Add xassert's for correspondence
3511 between IT's object being iterated and it->bidi_it.string
3512 structure.
3513 (face_before_or_after_it_pos): Support bidi iteration.
3514 (next_element_from_c_string): Handle the case of the first string
3515 character that is not the first one in the visual order.
3516 (get_visually_first_element): New function, refactored from common
3517 parts of next_element_from_buffer, next_element_from_string, and
3518 next_element_from_c_string.
3519 (tool_bar_lines_needed, redisplay_tool_bar)
3520 (display_menu_bar): Force left-to-right direction. Add a FIXME
3521 comment for making that be controlled by a user option.
3522 (push_it, pop_it): Save and restore the state of the
3523 bidi iterator. Save and restore the bidi_p flag.
3524 (pop_it): Iterate out of display property for string iteration as
3525 well.
3526 (iterate_out_of_display_property): Support iteration over strings.
3527 (handle_single_display_spec): Set up it->bidi_it for iteration
3528 over a display string, and call bidi_init_it.
3529 (handle_single_display_spec, next_overlay_string)
3530 (get_overlay_strings_1, push_display_prop): Set up the bidi
3531 iterator for displaying display or overlay strings.
3532 (forward_to_next_line_start): Don't use the shortcut if
3533 bidi-iterating.
3534 (back_to_previous_visible_line_start): If handle_display_prop
3535 pushed the iterator stack, restore the internal state of the bidi
3536 iterator by calling bidi_pop_it same number of times.
3537 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3538 and we are bidi-iterating, don't decrement the iterator position;
3539 instead, set the first_elt flag in the bidi iterator, to produce
3540 the same effect.
3541 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3542 (push_display_prop): xassert that we are iterating a buffer.
3543 (push_it, pop_it): Save and restore paragraph_embedding member.
3544 (handle_single_display_spec, next_overlay_string)
3545 (get_overlay_strings_1, reseat_1, reseat_to_string)
3546 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3547 correctly. Don't assume unibyte strings are not bidi-reordered.
3548 (compute_display_string_pos)
3549 (compute_display_string_end): Fix handling the case of C string.
3550 (push_it, pop_it): Save and restore from_disp_prop_p.
3551 (handle_single_display_spec, push_display_prop): Set the
3552 from_disp_prop_p flag.
3553 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3554 (pop_it): Call iterate_out_of_display_property only if we are
3555 popping after iteration over a string that came from a display
3556 property. Fix a typo in popping stretch info. Add an assertion
3557 for verifying that the iterator position is in sync with the bidi
3558 iterator.
3559 (handle_single_display_spec, get_overlay_strings_1)
3560 (push_display_prop): Fix initialization of paragraph direction for
3561 string when that of the parent object is not yet determined.
3562 (reseat_1): Call bidi_init_it to resync the bidi
3563 iterator with IT's position. (Bug#7616)
3564 (find_row_edges): If ROW->start.pos gives position
3565 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3566 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3567 Reset the from_disp_prop_p flag.
3568 (SAVE_IT, RESTORE_IT): New macros.
3569 (pos_visible_p, face_before_or_after_it_pos)
3570 (back_to_previous_visible_line_start)
3571 (move_it_in_display_line_to, move_it_in_display_line)
3572 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3573 (try_scrolling, redisplay_window, display_line): Use them when
3574 saving a temporary copy of the iterator and restoring it back.
3575 (back_to_previous_visible_line_start, reseat_1)
3576 (init_iterator): Empty the bidi cache "stack".
3577 (move_it_in_display_line_to): If iterator ended up at
3578 EOL, but we never saw any buffer positions smaller than
3579 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3580 motion in bidi-reordered lines.
3581 (move_it_in_display_line_to): Record prev_method and prev_pos
3582 immediately before the call to set_iterator_to_next. Fixes cursor
3583 motion in bidi-reordered lines with stretch glyphs and strings
3584 displayed in margins. (Bug#8133) (Bug#8867)
3585 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3586 TO_CHARPOS.
640c8776
SM
3587 (pos_visible_p): Support positions in bidi-reordered lines.
3588 Save and restore bidi cache.
0bb23927
EZ
3589
3590 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3591 (bidi_paragraph_info): Delete unused struct.
3592 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3593 (bidi_cache_start): New variable.
3594 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3595 to zero.
3596 (bidi_cache_fetch_state, bidi_cache_search)
3597 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3598 (bidi_cache_find, bidi_peek_at_next_level)
3599 (bidi_level_of_next_char, bidi_find_other_level_edge)
3600 (bidi_move_to_visually_next): Compare cache index with
3601 bidi_cache_start rather than with zero.
3602 (bidi_fetch_char): Accept new argument STRING; all callers
3603 changed. Support iteration over a string. Support strings with
3604 display properties. Support unibyte strings. Fix the type of
3605 `len' according to what STRING_CHAR_AND_LENGTH expects.
3606 (bidi_paragraph_init, bidi_resolve_explicit_1)
3607 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3608 (bidi_level_of_next_char, bidi_move_to_visually_next):
3609 Support iteration over a string.
0bb23927
EZ
3610 (bidi_set_sor_type, bidi_resolve_explicit_1)
3611 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3612 can now be zero (for strings); special values 0 and -1 were
3613 changed to -1 and -2, respectively.
3614 (bidi_char_at_pos): New function.
3615 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3616 Call it instead of FETCH_MULTIBYTE_CHAR.
3617 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3618 initialized to valid values.
3619 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3620 values.
3621 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3622 the test for valid cached positions. Fix the logic for looking up
3623 the sentinel state in the cache. GCPRO the Lisp string we are
3624 iterating.
3625 (bidi_push_it, bidi_pop_it): New functions.
3626 (bidi_initialize): Initialize the bidi cache start stack pointer.
3627 (bidi_cache_ensure_space): New function, refactored from part of
3628 bidi_cache_iterator_state. Don't assume the required size is just
3629 one BIDI_CACHE_CHUNK away.
3630 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3631 (bidi_count_bytes, bidi_char_at_pos): New functions.
3632 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3633 always valid if bidi_cache_idx is valid.
3634 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3635 is valid if it's going to be used.
3636 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3637 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3638 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3639 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3640 (bidi_find_other_level_edge, bidi_cache_start_stack):
3641 All variables related to cache indices are now EMACS_INT.
c965adc5 3642
0bb23927
EZ
3643 * dispextern.h (struct bidi_string_data): New structure.
3644 (struct bidi_it): New member `string'. Make flag members be 1-bit
3645 fields, and put them last in the struct.
640c8776
SM
3646 (compute_display_string_pos, compute_display_string_end):
3647 Update prototypes.
0bb23927
EZ
3648 (bidi_push_it, bidi_pop_it): Add prototypes.
3649 (struct iterator_stack_entry): New members bidi_p,
3650 paragraph_embedding, and from_disp_prop_p.
3651 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3652 (bidi_shelve_cache, bidi_unshelve_cache):
3653 Declare prototypes.
0bb23927
EZ
3654
3655 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3656 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3657 and vector-like objects.
3658
3659 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3660 cache around display iteration.
3661
3662 * window.c (Fwindow_end, window_scroll_pixel_based)
3663 (displayed_window_lines, Frecenter): Save and restore the bidi
3664 cache around display iteration.
3665
3bbd2265
LMI
36662011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3667
3668 * editfns.c (Fdelete_region): Clarify the use of the named
3669 parameters (bug#6788).
3670
adc47434
MR
36712011-07-14 Martin Rudalics <rudalics@gmx.at>
3672
3673 * indent.c (Fvertical_motion): Set and restore w->pointm when
3674 saving and restoring the window's buffer (Bug#9006).
3675
837c31f8
LMI
36762011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3677
3678 * editfns.c (Fstring_to_char): Clarify just what is returned
3679 (bug#6576). Text by Eli Zaretskii.
3680
ac389d0c
JB
36812011-07-13 Juanma Barranquero <lekktu@gmail.com>
3682
3683 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3684
0be0ce47
EZ
36852011-07-13 Eli Zaretskii <eliz@gnu.org>
3686
3687 * buffer.c (mmap_find): Fix a typo.
3688
cd18e7e3
JB
36892011-07-13 Johan Bockgård <bojohan@gnu.org>
3690
3691 Fix execution of x selection hooks.
3692 * xselect.c (Qx_lost_selection_functions)
3693 (Qx_sent_selection_functions): New vars.
3694 (syms_of_xselect): DEFSYM them.
3695 (x_handle_selection_request): Pass Qx_sent_selection_functions
3696 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3697 (x_handle_selection_clear,x_clear_frame_selections):
3698 Pass Qx_lost_selection_functions rather than
3699 Vx_lost_selection_functions to Frun_hook_with_args.
3700
47ea7f44
PE
37012011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3702
ac389d0c 3703 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3704 The old code sometimes used this field without initializing it.
3705
47ea7f44
PE
3706 * alloc.c (gc_sweep): Don't read past end of array.
3707 In theory, the old code could also have corrupted Emacs internals,
3708 though it'd be very unlikely.
3709
bc985c87
AS
37102011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3711
3712 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3713 argument. (Bug#4026)
bc985c87 3714
0cf34688
LMI
37152011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3716
b3dadd76
LMI
3717 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3718 key" (bug#4257).
3719
0cf34688
LMI
3720 * window.c (Fset_window_start): Doc fix (bug#4199).
3721 (Fset_window_hscroll): Ditto.
3722
270768cd
PE
37232011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3724
077e3dda 3725 Fix minor new problems caught by GCC 4.6.1.
270768cd 3726 * term.c (init_tty): Remove unused local.
490011a6 3727 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3728 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3729 not used otherwise.
270768cd 3730
b1f58454
CY
37312011-07-12 Chong Yidong <cyd@stupidchicken.com>
3732
3733 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3734
22b9578d
LMI
37352011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3736
6e70ab07
LMI
3737 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3738 are the mini-buffer and the echo area (bug#3320).
3739
22b9578d
LMI
3740 * term.c (init_tty): Remove support for supdup, c10 and perq
3741 terminals, which are no longer supported (bug#1482).
3742
8974cc9f
JB
37432011-07-10 Johan Bockgård <bojohan@gnu.org>
3744
3745 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3746
a560d974
JD
37472011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3748
3749 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3750 for non-popups (Bug#3642).
3751
1dae0f0a
AS
37522011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3753
268c2c36 3754 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3755 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3756 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3757 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3758 * data.c (fmod): Likewise.
3759 * dispnew.c (swap_glyphs_in_rows): Likewise.
3760 * emacs.c (memory_warning_signal): Likewise.
3761 * floatfns.c (float_error): Likewise.
3762 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3763 (otf_open, font_otf_capability, generate_otf_features)
3764 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3765 Likewise.
3766 * image.c (pbm_read_file): Likewise.
3767 * indent.c (string_display_width): Likewise.
3768 * intervals.c (check_for_interval, search_for_interval)
3769 (inc_interval_count, count_intervals, root_interval)
3770 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3771 * lread.c (defalias): Likewise.
268c2c36 3772 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3773 * regex.c (set_image_of_range_1, set_image_of_range)
3774 (regex_grow_registers): Likewise.
3775 * sysdep.c (strerror): Likewise.
3776 * termcap.c (valid_filename_p, tprint, main): Likewise.
3777 * tparam.c (main): Likewise.
3778 * unexhp9k800.c (run_time_remap, save_data_space)
3779 (update_file_ptrs, read_header, write_header, calculate_checksum)
3780 (copy_file, copy_rest, display_header): Likewise.
3781 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3782 Likewise.
3783 * xdisp.c (check_it): Likewise.
3784 * xfaces.c (register_color, unregister_color, unregister_colors):
3785 Likewise.
3786 * xfns.c (print_fontset_result): Likewise.
3787 * xrdb.c (member, fatal, main): Likewise.
3788
99033785
PE
37892011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3790
3791 Fix minor problems found by static checking (Bug#9031).
3792 * chartab.c (char_table_set_range, map_sub_char_table):
3793 Remove unused locals.
3794 (uniprop_table): Now static.
3795 * composite.c (_work_char): Remove unused static var.
3796
9cb2ac56
JB
37972011-07-09 Juanma Barranquero <lekktu@gmail.com>
3798
3799 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3800
f25661f0
JD
38012011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3802
3803 * gtkutil.c (qttip_cb): Remove code without function.
3804
8278c4fe
EZ
38052011-07-09 Eli Zaretskii <eliz@gnu.org>
3806
3807 * w32.c (pthread_sigmask): New stub.
3808
1692ae2d 38092011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3810
8a6ebd58 3811 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3812 sigprocmask is portable only for single-threaded applications, and
3813 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3814 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3815 (LIBES): Use it.
3816 * callproc.c (Fcall_process):
3817 * process.c (create_process):
3818 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3819 Use pthread_sigmask, not sigprocmask.
123403e4 3820
1b854618
JD
38212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3822
3823 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3824 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3825 wrong (Bug#8591).
3826
3fe4b549
JD
38272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3828
0ce7e563
JD
3829 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3830 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3831 (xg_hide_tooltip): Fix comment.
3832
3fe4b549
JD
3833 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3834 in registerServicesMenuSendTypes.
3835 (validRequestorForSendType): Don't check ns_return_types.
3836
3837 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3838 ns_return_type.
3839
5df75e47
JR
38402011-07-08 Jason Rumney <jasonr@gnu.org>
3841
22610910
JR
3842 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3843 SH_SHOW for hidden windows (Bug#5482).
3844
5df75e47
JR
3845 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3846 frame struct members of non-existent frames (Bug#6284).
3847
699c10bd
JD
38482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3849
4393663b
JD
3850 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3851 variable firstTime not needed on OSX >= 10.6.
3852 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3853 >= 10.5. Use setKnobProportion, setDoubleValue.
3854
3855 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3856 (MAC_OS_X_VERSION_10_5): Define if not defined.
3857 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3858 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3859 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3860
3861 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3862 cString and lossyCString on OSX >= 10.4
3863
58179cce 3864 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3865 sizeToFit on OSX >= 10.2.
3866
3867 * nsimage.m (allocInitFromFile): Don't use deprecated method
3868 bestRepresentationForDevice on OSX >= 10.6.
3869
3870 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3871 to avoid warning.
3872
3873 * emacs.c: Declare unexec_init_emacs_zone.
3874
a63e0781
JD
3875 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3876
699c10bd
JD
3877 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3878
3879 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3880 on svcsMenu (Bug#8842).
3881
3882 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3883 ns_return_types.
3884 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3885
3886 * nsterm.m (QUTF8_STRING): Declare.
3887 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3888 (validRequestorForSendType): Return type is (id).
3889 Change indexOfObjectIdenticalTo to indexOfObject.
3890 Check if we have local selection before returning self (Bug#8842).
3891 (writeSelectionToPasteboard): Put local selection into paste board
3892 if we have a local selection (Bug#8842).
3893 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3894
3895 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3896 (ns_get_local_selection): Declare.
3897
54e10184
LMI
38982011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3899
9888ff71
LMI
3900 * keymap.c (describe_map_tree): Don't insert a double newline at
3901 the end of the buffer (bug#1169) and return whether we inserted
3902 something.
3903
54e10184
LMI
3904 * callint.c (Fcall_interactively): Change "reading args" to
3905 "providing args" to try to clarify what it does (bug#1010).
3906
15fa4783
KH
39072011-07-07 Kenichi Handa <handa@m17n.org>
3908
3909 * composite.c (composition_compute_stop_pos): Ignore a static
3910 composition starting before CHARPOS (Bug#8915).
3911
3912 * xdisp.c (handle_composition_prop): Likewise.
3913
a8815b00
EZ
39142011-07-07 Eli Zaretskii <eliz@gnu.org>
3915
3916 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3917 (Bug#9015)
3918
ef7b981d 39192011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3920
3921 * character.h (unicode_category_t): New enum type.
3922
3923 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3924 (Qchar_code_property_table): New variable.
3925 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3926 (UNIPROP_COMPRESSED_FORM_P): New macros.
3927 (char_table_ascii): Uncompress the compressed values.
3928 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3929 Uncompress the compressed values.
ac389d0c 3930 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3931 (char_table_ref_and_range): Uncompress the compressed values.
3932 (sub_char_table_set): New arg is_uniprop. Callers changed.
3933 Uncompress the compressed values.
3934 (sub_char_table_set_range): Args changed. Callers changed.
3935 (char_table_set_range): Adjuted for the above change.
3936 (map_sub_char_table): Delete args default_val and parent. Add arg
3937 top. Give decoded values to a Lisp function.
640c8776 3938 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3939 values to a Lisp function. Gcpro more variables.
3940 (uniprop_table_uncompress)
3941 (uniprop_decode_value_run_length): New functions.
3942 (uniprop_decoder, uniprop_decoder_count): New variables.
3943 (uniprop_get_decoder, uniprop_encode_value_character)
3944 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3945 New functions.
3946 (uniprop_encoder, uniprop_encoder_count): New variables.
3947 (uniprop_get_encoder, uniprop_table)
3948 (Funicode_property_table_internal, Fget_unicode_property_internal)
3949 (Fput_unicode_property_internal): New functions.
3950 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3951 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3952 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3953 char-code-property-alist.
3954
640c8776 3955 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3956 Vunicode_category_table.
3957
640c8776 3958 * font.c (font_range): Adjust for the change of
c805dec0
KH
3959 Vunicode_category_table.
3960
76b397fb
DN
39612011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3962
3963 * m/iris4d.h: Remove file, move contents ...
3964 * s/irix6-5.h: ... here.
3965
22b4128e
PE
39662011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3967
3968 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3969 * alloc.c (mark_buffer):
3970 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3971 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3972 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3973 This isn't true in general, and it's particularly not true
3974 if Emacs is configured with --with-wide-int.
3975 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3976 New macros, used in the buffer.c change.
3977
869795d6
JD
39782011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3979
3980 * xsettings.c: Use both GConf and GSettings if both are available.
3981 (store_config_changed_event): Add comment.
3982 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3983 (store_tool_bar_style_changed): New functions.
5e617bc2 3984 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3985 (struct xsettings): Move font inside HAVE_XFT.
3986 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3987 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3988 Move inside HAVE_XFT.
640c8776 3989 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3990 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3991 also.
3992 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3993 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3994 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3995 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3996 (parse_settings): Move check for font inside HAVE_XFT.
3997 (read_settings, apply_xft_settings): Add comment.
3998 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3999 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4000 call store_font_name_changed.
4001 (xft_settings_event): Add comment.
4002 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4003 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4004 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4005 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4006 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4007 (xsettings_get_system_font, xsettings_get_system_normal_font):
4008 Add comment.
869795d6 4009
d8ed26bd
PE
40102011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4011
4012 Random fixes. E.g., (random) never returned negative values.
4013 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4014 subseconds part to the entropy, as that's a bit more random.
4015 Prefer signed to unsigned, since the signedness doesn't matter and
4016 in general we prefer signed. When given a limit, use a
4017 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4018 latter isn't right if USE_2_TAGS_FOR_INTS.
4019 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4020 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4021
cabf1cac
SM
40222011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4023
4024 * textprop.c (text_property_stickiness):
4025 Obey Vtext_property_default_nonsticky.
4026 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4027 * w32fns.c (syms_of_w32fns):
4028 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4029
6e9b2be9
PE
40302011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4031
4032 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4033 This is more efficient than Ffile_directory_p and avoids a minor race.
4034
90186c68
LMI
40352011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4036
7c301272
LMI
4037 * buffer.c (Foverlay_put): Say what the return value is
4038 (bug#7835).
4039
c4f2d8d4
LMI
4040 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4041 is a directory before asking whether to use the file name
4042 (bug#7564).
ad637907
LMI
4043 (barf_or_query_if_file_exists): Make the "File is a directory"
4044 error be more correct.
c4f2d8d4 4045
90186c68
LMI
4046 * fns.c (Frequire): Remove the mention of the .gz files, since
4047 that's installation-specific, but keep the mention of
4048 `get-load-suffixes'.
4049
da64016e
PE
40502011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4051
4052 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4053 Report string overflow if the output is too long.
4054
7d47b580
JB
40552011-07-04 Juanma Barranquero <lekktu@gmail.com>
4056
a555cb87
JB
4057 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4058 (syms_of_gnutls): Remove duplicate DEFSYM for
4059 Qgnutls_bootprop_verify_hostname_error, an error for
4060 Qgnutls_bootprop_verify_error (which is no longer used).
4061
7d47b580
JB
4062 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4063 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4064 Also (re)move comments that are misplaced or no longer relevant.
4065
1e49bfab
LMI
40662011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4067
4068 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4069
1485f4c0
CY
40702011-07-03 Chong Yidong <cyd@stupidchicken.com>
4071
4072 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4073 and background color parameters if they have been changed.
4074
a9ab721e
LMI
40752011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4076
4077 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4078
cf7cff57
PE
40792011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4080
2e13213d
PE
4081 * xsettings.c (SYSTEM_FONT): Define only when used.
4082 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4083
cf7cff57
PE
4084 * keymap.c (access_keymap_1): Now static.
4085
7a8e04f7
CY
40862011-07-02 Chong Yidong <cyd@stupidchicken.com>
4087
4088 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4089 leave any prefix arg for the up event (Bug#1586).
4090
61352f62
LMI
40912011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4092
69bb1ef7
LMI
4093 * lread.c (syms_of_lread): Mention single symbols defined by
4094 `defvar' or `defconst' (bug#7154).
4095
61352f62 4096 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4097 (Frequire): Mention get-load-suffixes.
61352f62 4098
28545e04
MR
40992011-07-02 Martin Rudalics <rudalics@gmx.at>
4100
4101 * window.h (window): Remove clone_number slot.
4102 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4103 Remove.
4104 (make_parent_window, make_window, saved_window)
4105 (Fset_window_configuration, save_window_save): Don't deal with
4106 clone numbers.
4107 * buffer.c (Qclone_number): Remove declaration.
4108 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4109
3349e122
SM
41102011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4111
4112 Add multiple inheritance to keymaps.
4113 * keymap.c (Fmake_composed_keymap): New function.
4114 (Fset_keymap_parent): Simplify.
4115 (fix_submap_inheritance): Remove.
4116 (access_keymap_1): New function extracted from access_keymap to handle
4117 embedded parents and handle lists of maps.
4118 (access_keymap): Use it.
4119 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4120 (Fcopy_keymap): Handle embedded parents.
4121 (Fcommand_remapping, define_as_prefix): Simplify.
4122 (Fkey_binding): Simplify.
4123 (syms_of_keymap): Move minibuffer-local-completion-map,
4124 minibuffer-local-filename-completion-map,
4125 minibuffer-local-must-match-map, and
4126 minibuffer-local-filename-must-match-map to Elisp.
4127 (syms_of_keymap): Defsubr make-composed-keymap.
4128 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4129 (parse_menu_item): Trivial simplification.
4130
3279eb87
GM
41312011-07-01 Glenn Morris <rgm@gnu.org>
4132
4133 * Makefile.in (SETTINGS_LIBS): Fix typo.
4134
4550efdf
KI
41352011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4136
4137 * coding.c (Fencode_coding_string): Record the last coding system
4138 used, as the function doc string says (bug#8738).
4139
0949d2b6
JD
41402011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4141
4142 * xsettings.c (store_monospaced_changed): Take new font as arg and
4143 check for change against current_mono_font.
4144 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4145 (emacs_settings_constructor, emacs_settings_get_property)
4146 (emacs_settings_set_property, emacs_settings_class_init)
4147 (emacs_settings_init, gsettings_obj): Remove.
4148 (something_changedCB): New function for HAVE_GSETTINGS.
4149 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4150 with value as argument.
4151 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4152 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4153 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4154 "changed".
4155
4156 * xgselect.c: Add defined (HAVE_GSETTINGS).
4157 (xgselect_initialize): Ditto.
4158
4159 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4160 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4161 xg_select.
4162
bbc6b304
PE
41632011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4164
4165 * eval.c (struct backtrace): Simplify and port the data structure.
4166 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4167 signed bit field, as this assumption is not portable and it makes
4168 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4169 "char debug_on_exit : 1" as this is not portable either; instead,
4170 use the portable "unsigned int debug_on_exit : 1". Remove unused
4171 member evalargs. Remove obsolete comments about cc bombing out.
4172
9851bfc5
JD
41732011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4174
51bb811f 4175 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4176 Let HAVE_GSETTINGS override HAVE_GCONF.
4177 (store_monospaced_changed): New function.
4178 (EMACS_SETTINGS): A new type derived from GObject to handle
4179 GSettings notifications.
4180 (emacs_settings_constructor, emacs_settings_get_property)
4181 (emacs_settings_set_property, emacs_settings_class_init):
4182 New functions.
4183 (gsettings_client, gsettings_obj): New variables.
4184 (GSETTINGS_SCHEMA): New define.
4185 (something_changedCB): Call store_monospaced_changed.
4186 (init_gsettings): New function.
4187 (xsettings_initialize): Call init_gsettings.
4188 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4189 to NULL.
4190
640c8776 4191 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4192 GCONF_CFLAGS/LIBS.
4193
5386012d
MR
41942011-06-29 Martin Rudalics <rudalics@gmx.at>
4195
4196 * window.c (resize_root_window, grow_mini_window)
4197 (shrink_mini_window): Rename Qresize_root_window to
4198 Qwindow_resize_root_window and Qresize_root_window_vertically to
4199 Qwindow_resize_root_window_vertically.
4200
f13e0b08
PE
42012011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4202
4203 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4204
94515237
JB
42052011-06-27 Juanma Barranquero <lekktu@gmail.com>
4206
4207 * makefile.w32-in: Redesign dependencies so they reflect more
4208 clearly which files are directly included by each source file,
4209 and not through other includes.
4210
e43b6e43
MR
42112011-06-27 Martin Rudalics <rudalics@gmx.at>
4212
4213 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4214 (sort_overlays, overlay_strings): When an overlay's clone number
4215 matches the window's clone number process the overlay even if
4216 the overlay's window property doesn't match the current window.
4217
d68443dc
MR
4218 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4219 (Fwindow_hchild): Rename to Fwindow_left_child.
4220 (Fwindow_next): Rename to Fwindow_next_sibling.
4221 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4222 (resize_window_check): Rename to window_resize_check.
4223 (resize_window_apply): Rename to window_resize_apply.
4224 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4225 (Fdelete_other_windows_internal, resize_frame_windows)
4226 (Fsplit_window_internal, Fdelete_window_internal)
4227 (grow_mini_window, shrink_mini_window)
4228 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4229
c7e73be5
JD
42302011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4231
4232 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4233 (emacs_fixed_set_min_size): Remove.
4234 (emacs_fixed_new): Take frame as argument.
4235
4236 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4237 (_EmacsFixedPrivate): Remove minwidth/height.
4238 Add struct frame *f.
4239 (emacs_fixed_init): Initialize priv->f.
4240 (get_parent_class, emacs_fixed_set_min_size): Remove.
4241 (emacs_fixed_new): Set priv->f to argument.
4242 (emacs_fixed_get_preferred_width)
4243 (emacs_fixed_get_preferred_height): Use min_width/height from
4244 frames size_hint to set minimum and natural (Bug#8919).
4245 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4246 and use min_width/height from frames size_hint to set
4247 min_width/height (Bug#8919).
4248
4249 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4250 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4251 Fix indentation.
c7e73be5 4252
cf99dcf8
EZ
42532011-06-26 Eli Zaretskii <eliz@gnu.org>
4254
4255 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4256 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4257 called at ZV.
4258
029529ac
CY
42592011-06-26 Chong Yidong <cyd@stupidchicken.com>
4260
4261 * process.c (wait_reading_process_output): Bypass select if
4262 waiting for a cell while ignoring keyboard input, and input is
4263 pending. Suggested by Jan Djärv (Bug#8869).
4264
7a7ef429
PE
42652011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4266
4267 Use gnulib's dup2 module instead of rolling our own.
4268 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4269
11fdef7d 42702011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4271
4272 * dispnew.c (scrolling_window): Before scrolling, turn off a
4273 mouse-highlight in the window being scrolled.
4274
cd3520a4
JB
42752011-06-24 Juanma Barranquero <lekktu@gmail.com>
4276
4277 Move DEFSYM to lisp.h and use everywhere.
4278
4279 * character.h (DEFSYM): Move declaration...
4280 * lisp.h (DEFSYM): ...here.
4281
4282 * gnutls.c:
4283 * minibuf.c:
4284 * w32menu.c:
4285 * w32proc.c:
4286 * w32select.c: Don't include character.h.
4287
4288 * alloc.c (syms_of_alloc):
4289 * buffer.c (syms_of_buffer):
4290 * bytecode.c (syms_of_bytecode):
4291 * callint.c (syms_of_callint):
4292 * casefiddle.c (syms_of_casefiddle):
4293 * casetab.c (init_casetab_once):
4294 * category.c (init_category_once, syms_of_category):
4295 * ccl.c (syms_of_ccl):
4296 * cmds.c (syms_of_cmds):
4297 * composite.c (syms_of_composite):
4298 * dbusbind.c (syms_of_dbusbind):
4299 * dired.c (syms_of_dired):
4300 * dispnew.c (syms_of_display):
4301 * doc.c (syms_of_doc):
4302 * editfns.c (syms_of_editfns):
4303 * emacs.c (syms_of_emacs):
4304 * eval.c (syms_of_eval):
4305 * fileio.c (syms_of_fileio):
4306 * fns.c (syms_of_fns):
4307 * frame.c (syms_of_frame):
4308 * fringe.c (syms_of_fringe):
4309 * insdel.c (syms_of_insdel):
4310 * keymap.c (syms_of_keymap):
4311 * lread.c (init_obarray, syms_of_lread):
4312 * macros.c (syms_of_macros):
4313 * msdos.c (syms_of_msdos):
4314 * print.c (syms_of_print):
4315 * process.c (syms_of_process):
4316 * search.c (syms_of_search):
4317 * sound.c (syms_of_sound):
4318 * syntax.c (init_syntax_once, syms_of_syntax):
4319 * terminal.c (syms_of_terminal):
4320 * textprop.c (syms_of_textprop):
4321 * undo.c (syms_of_undo):
4322 * w32.c (globals_of_w32):
4323 * window.c (syms_of_window):
4324 * xdisp.c (syms_of_xdisp):
4325 * xfaces.c (syms_of_xfaces):
4326 * xfns.c (syms_of_xfns):
4327 * xmenu.c (syms_of_xmenu):
4328 * xsettings.c (syms_of_xsettings):
4329 * xterm.c (syms_of_xterm): Use DEFSYM.
4330
4228cf16
TZ
43312011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4332
cd3520a4 4333 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4334
7fcccf1e
PE
43352011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4336
7efb4e0e
PE
4337 Integer and buffer overflow fixes (Bug#8873).
4338
ff5844ad
PE
4339 * print.c (printchar, strout): Check for string overflow.
4340 (PRINTPREPARE, printchar, strout):
4341 Don't set size unless allocation succeeds.
4342
90532f02
PE
4343 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4344 for sizes. Check for string overflow more accurately.
4345 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4346
6d84508d
PE
4347 * macros.c: Integer and buffer overflow fixes.
4348 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4349 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4350 Use ptrdiff_t, not int, for sizes.
4351 Don't increment bufsize until after realloc succeeds.
4352 Check for size-calculation overflow.
4353 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4354
437b2cb4
PE
4355 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4356
8b9ac8b4
PE
4357 * lread.c: Integer overflow fixes.
4358 (read_integer): Radix is now EMACS_INT, not int,
4359 to improve quality of diagnostics for out-of-range radices.
4360 Calculate buffer size correctly for out-of-range radices.
4361 (read1): Check for integer overflow in radices, and in
4362 read-circle numbers.
82cb60d3
PE
4363 (read_escape): Avoid int overflow.
4364 (Fload, openp, read_buffer_size, read1)
4365 (substitute_object_recurse, read_vector, read_list, map_obarray):
4366 Use ptrdiff_t, not int, for sizes.
4367 (read1): Use EMACS_INT, not int, for sizes.
20270765 4368 Check for size overflow.
8b9ac8b4 4369
7fcccf1e
PE
4370 * image.c (cache_image): Check for size arithmetic overflow.
4371
bfbbd7e7
PE
4372 * lread.c: Integer overflow issues.
4373 (saved_doc_string_size, saved_doc_string_length)
4374 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4375 Now ptrdiff_t, not int.
4376 (read1): Don't assume doc string length fits in int. Check for
4377 out-of-range doc string lengths.
4378 (read_list): Don't assume file position fits in int.
39019e54 4379 (read_escape): Check for hex character overflow.
bfbbd7e7 4380
4e323265
LL
43812011-06-22 Leo Liu <sdl.web@gmail.com>
4382
4383 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4384 Move to minibuffer.el.
4385
85fece3e
PE
43862011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4387
20b84ce9 4388 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4389 The following patches are for when GLYPH_DEBUG && !XASSERT.
4390 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4391 * dispnew.c (flush_stdout):
4392 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4393 Mark as externally visible.
4394 * dispnew.c (check_window_matrix_pointers): Now static.
4395 * dispnew.c (window_to_frame_vpos):
4396 * xfns.c (unwind_create_frame):
4397 * xterm.c (x_check_font): Remove unused local.
4398 * scroll.c (CHECK_BOUNDS):
4399 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4400 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4401 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4402 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4403 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4404 Now static.
4405 (debug_method_add): Use va_list and vsprintf rather than relying
4406 on undefined behavior with wrong number of arguments.
4407 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4408 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4409 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4410 since we're not interested in debugging glyphs with old libraries.
4411 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4412 GCC 4.6.0's static checking.
4413
0766b489
PE
44142011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4415
31fd4b32
PE
4416 Integer overflow and signedness fixes (Bug#8873).
4417 A few related buffer overrun fixes, too.
4418
b79e8648
PE
4419 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4420
0766b489
PE
4421 * dispextern.h (struct face.stipple):
4422 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4423 (x_bitmap_mask, x_allocate_bitmap_record)
4424 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4425 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4426 (x_create_bitmap_from_xpm_data):
4427 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4428 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4429 (.bitmaps_last):
4430 * xfaces.c (load_pixmap):
4431 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4432 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4433 (.bitmaps_last, struct x_output.icon_bitmap):
4434 Use ptrdiff_t, not int, for bitmap indexes.
4435 (x_allocate_bitmap_record): Check for size overflow.
4436 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4437
b081724f
PE
4438 Use ptrdiff_t, not int, for overlay counts.
4439 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4440 * editfns.c (overlays_around, get_pos_property):
4441 * textprop.c (get_char_property_and_overlay):
4442 * xdisp.c (next_overlay_change, note_mouse_highlight):
4443 * xfaces.c (face_at_buffer_position):
21514da7
PE
4444 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4445 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4446 (Fnext_overlay_change, Fprevious_overlay_change)
4447 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4448 Use ptrdiff_t, not int, for sizes.
21514da7 4449 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4450
3de73e5e
PE
4451 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4452
2606c57b
PE
4453 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4454 (x_session_initialize): Do not assume string length fits in int.
4455
aaafe47a
PE
4456 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4457 This is unlikely, but can occur if DPI is outlandish.
4458
2674ddc8 4459 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4460 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4461
28154962
PE
4462 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4463 * xrdb.c (magic_file_p, search_magic_path):
4464 Omit last arg SUFFIX; it was always 0. All callers changed.
4465 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4466
7de51af5
PE
4467 * xfont.c (xfont_match): Avoid need for strlen.
4468
25ed6cc3
PE
4469 * xfns.c: Don't assume strlen fits in int.
4470 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4471
4eab31dd
PE
4472 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4473 not unsigned long, as we prefer signed integers. All callers changed.
4474 Detect integer overflow in repeat count.
4475 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4476 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4477
171e2a58
PE
4478 * termcap.c: Don't assume sizes fit in int and never overflow.
4479 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4480 (gobble_line): Check for size-calculation overflow.
4481
ad39faca 4482 * minibuf.c (Fread_buffer):
6e5bb2dc 4483 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4484 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4485 Don't assume string length fits in int.
4486
52c61c22 4487 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4488 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4489
b5b8c9e5
PE
4490 * font.c: Don't assume string length fits in int.
4491 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4492 Use ptrdiff_t, not int.
ccd6111c
PE
4493 (font_intern_prop): Don't assume string length fits in int.
4494 Don't assume integer property fits in fixnum.
4495 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4496
882f0d81 4497 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4498 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4499 Reformulate so as not to need the command string.
4500 Invoke gzip -cd rather than gunzip, as it's more portable.
4501 (lock_info_type, lock_file_1, lock_file):
4502 Don't assume pid_t and time_t fit in unsigned long.
4503 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4504 (current_lock_owner): Prefer signed type for sizes.
4505 Use memcpy, not strncpy, where memcpy is what is really wanted.
4506 Don't assume (via atoi) that time_t and pid_t fit in int.
4507 Check for time_t and/or pid_t out of range, e.g., via a network share.
4508 Don't alloca where an auto var works fine.
4509
93f4cf88
PE
4510 * fileio.c: Fix some integer overflow issues.
4511 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4512 Don't assume string length fits in int.
4513 (directory_file_name): Don't assume string length fits in long.
4514 (make_temp_name): Don't assume pid fits in int, or that its print
4515 length is less than 20.
4516
f3e92b69
PE
4517 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4518
1bfdaf10
PE
4519 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4520
35016e9a
PE
4521 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4522
3d1e65a1
PE
4523 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4524 We prefer signed integers, even for size calculations.
4525
0b963a93
PE
4526 * emacs.c: Don't assume string length fits in 'int'.
4527 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4528 (main): Don't invoke strlen when not needed.
4529
573f4b54
PE
4530 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4531 (XD_DEBUG_MESSAGE): Don't waste a byte.
4532
989f33ba
PE
4533 * callproc.c (getenv_internal_1, getenv_internal)
4534 (Fgetenv_internal):
965d34eb
PE
4535 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4536
e4d29b33
PE
4537 * lread.c (invalid_syntax): Omit length argument.
4538 All uses changed. This doesn't fix a bug, but it simplifies the
4539 code away from its former Hollerith-constant appearance, and it's
4540 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4541 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4542
eb49b136
PE
4543 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4544 This didn't break anything, but it didn't help either.
4545 It's confusing to put a bogus integer in a place where the actual
4546 value does not matter.
9f62aeb1 4547 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4548 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4549
15375a22
PE
4550 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4551 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4552 implementation.
b61cc01c
PE
4553 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4554 We prefer signed types, and the value cannot exceed the EMACS_INT
4555 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4556 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4557 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4558 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4559
53b2623d
PE
4560 * indent.c (sane_tab_width): New function.
4561 (current_column, scan_for_column, Findent_to, position_indentation)
4562 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4563 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4564
51cab52b 4565 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4566
f2ed8a70
PE
4567 * lisp.h (lint_assume): New macro.
4568 * composite.c (composition_gstring_put_cache):
4569 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4570
abe80cc6
PE
4571 * editfns.c, insdel.c:
4572 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4573
b02c740e
PE
4574 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4575
ebc96716
PE
4576 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4577
b4e50fa0 4578 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4579 Use much-faster test for byte-length change.
311d5d7c 4580 Don't assume string byte-length fits in 'int'.
a4cf38e4 4581 Check that character arg fits in 'int'.
85461888 4582 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4583
c0c1ee9f
PE
4584 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4585
a498d7f4
PE
4586 * fns.c (concat): Catch string overflow earlier.
4587 Do not rely on integer wraparound.
4588
51cab52b
PE
4589 * dispextern.h (struct it.overlay_strings_charpos)
4590 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4591 * xdisp.c (forward_to_next_line_start)
4592 (back_to_previous_visible_line_start)
4593 (reseat_at_next_visible_line_start, next_element_from_buffer):
4594 Don't arbitrarily truncate the value of 'selective' to int.
4595
76031fad
PE
4596 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4597
5eb55db9
PE
4598 * composite.c: Don't truncate sizes to 'int'.
4599 (composition_gstring_p, composition_reseat_it)
4600 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4601 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4602 not EMACS_UINT, for indexes.
5eb55db9 4603
0703a717
PE
4604 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4605
d6202519
PE
4606 * buffer.c: Include <verify.h>.
4607 (struct sortvec.priority, struct sortstr.priority):
8961a454 4608 Now EMACS_INT, not int.
c20998a7 4609 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4610 (struct sortstr.size, record_overlay_string)
4611 (struct sortstrlist.size, struct sortlist.used):
4612 Don't truncate size to int.
4613 (record_overlay_string): Check for size-calculation overflow.
d6202519 4614 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4615
d5a19415
JM
46162011-06-22 Jim Meyering <meyering@redhat.com>
4617
029529ac 4618 Don't leak an XBM-image-sized buffer
d5a19415
JM
4619 * image.c (xbm_load): Free the image buffer after using it.
4620
a9041e6c
PE
46212011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4622
4623 Port to Sun C.
4624 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4625 that Sun C diagnosed.
4626 * fns.c (secure_hash): Fix pointer signedness issue.
4627 * intervals.c (static_offset_intervals): New function.
4628 (offset_intervals): Use it.
4629
7f3f739f
LL
46302011-06-21 Leo Liu <sdl.web@gmail.com>
4631
4632 * deps.mk (fns.o):
4633 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4634 sha512.h.
4635
4636 * fns.c (secure_hash): Rename from crypto_hash_function and change
4637 the first arg to accept symbols.
5b66d427 4638 (Fsecure_hash): New primitive.
7f3f739f
LL
4639 (syms_of_fns): New symbols.
4640
76147d94
DD
46412011-06-20 Deniz Dogan <deniz@dogan.se>
4642
4643 * process.c (Fset_process_buffer): Clarify return value in
4644 docstring.
4645
7d7d0045
CY
46462011-06-18 Chong Yidong <cyd@stupidchicken.com>
4647
4648 * dispnew.c (add_window_display_history): Use BVAR.
4649
4650 * xdisp.c (debug_method_add): Use BVAR.
4651 (check_window_end, dump_glyph_matrix, dump_glyph)
4652 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4653
4654 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4655 Likewise.
4656
4657 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4658 check till after the cache is created in init_frame_faces.
4659
ff2bc410
SM
46602011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4661
4662 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4663
28177add
PE
46642011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4665
dd3482fe
PE
4666 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4667 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4668 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4669
393d71f3 4670 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4671 * fileio.c (Finsert_file_contents):
4672 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4673 Remove the old (too-loose) buffer overflow checks.
4674 They weren't needed, since make_gap checks for buffer overflow.
4675 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4676 The old code merely checked for Emacs fixnum overflow, and relied
4677 on undefined (wraparound) behavior. The new code avoids undefined
4678 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4679
2e6813b0 4680 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4681 Tune. Don't use wider integers than needed. Don't use alloca.
4682 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4683
599a9e4f
PE
4684 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4685
99561444
PE
4686 * insdel.c, lisp.h (buffer_overflow): New function.
4687 (insert_from_buffer_1, replace_range, replace_range_2):
4688 * insdel.c (make_gap_larger):
4689 * editfns.c (Finsert_char):
4690 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4691
28177add
PE
4692 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4693
e69dafad
PE
46942011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4695
4baa020d 4696 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4697
b1c46f02
PE
4698 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4699 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4700
e69dafad
PE
4701 * fileio.c: Don't assume EMACS_INT fits in off_t.
4702 (emacs_lseek): New static function.
4703 (Finsert_file_contents, Fwrite_region): Use it.
4704 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4705
566684ea
PE
4706 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4707
e6966cd6
PE
4708 * fns.c: Don't overflow int when computing a list length.
4709 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4710 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4711 truncation on 64-bit hosts. Check for QUIT every
4712 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4713 faster and is responsive enough.
4714 (Flength): Report an error instead of overflowing an integer.
4715 (Fsafe_length): Return a float if the value is not representable
4716 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4717 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4718 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4719
dd0b0efb
PE
4720 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4721 (header_size, word_size): New constants.
4722 (allocate_vectorlike): Don't check size overflow here.
4723 (allocate_vector): Check it here instead, since this is the only
4724 caller of allocate_vectorlike that could cause overflow.
4725 Check that the new vector's length is representable as a fixnum.
4726
86fe5cfe
PE
4727 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4728 The previous code was bogus. For example, next_almost_prime (32)
4729 returned 39, which is undesirable as it is a multiple of 3; and
4730 next_almost_prime (24) returned 25, which is a multiple of 5 so
4731 why was the code bothering to check for multiples of 7?
4732
80e88859
PE
4733 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4734
4a2f0ad6
PE
4735 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4736
f66c7cf8
PE
4737 Variadic C functions now count arguments with ptrdiff_t.
4738 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4739 Back then I didn't know that the Emacs coding style prefers signed int.
4740 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4741 were being counted with int, which may truncate counts on 64-bit
4742 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4743 * lisp.h (struct Lisp_Subr.function.aMANY)
4744 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4745 Arg counts are now ptrdiff_t, not size_t.
4746 All variadic functions and their callers changed accordingly.
4747 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4748 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4749 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4750 * callint.c (Fcall_interactively): Check arg count for overflow,
4751 to avoid potential buffer overrun. Use signed char, not 'int',
4752 for 'varies' array, so that we needn't bother to check its size
4753 calculation for overflow.
4754 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4755 * eval.c (apply_lambda):
4756 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4757 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4758 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4759
a1759b76
PE
4760 * callint.c (Fcall_interactively): Don't use index var as event count.
4761
d96be9fc
PE
4762 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4763 * mem-limits.h (SIZE): Remove; no longer used.
4764
a690a978 4765 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4766
578c21e6
PE
4767 Remove unnecessary casts.
4768 * xterm.c (x_term_init):
4769 * xfns.c (x_set_border_pixel):
4770 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4771 These aren't needed now that we assume ANSI C.
4772
96f53c6c
PE
4773 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4774 It's more likely to cause problems (due to unsigned overflow)
4775 than to cure them.
4776
83c77d31
PE
4777 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4778
ee2079f1
PE
4779 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4780
6da65536
PE
4781 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4782
7147c4a4
PE
4783 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4784
193e32d9
PE
4785 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4786
e5533da6
PE
4787 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4788
9910e595
PE
4789 GLYPH_CODE_FACE returns EMACS_INT, not int.
4790 * dispextern.h (merge_faces):
4791 * xfaces.c (merge_faces):
01103c44
PE
4792 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4793 Don't assume EMACS_INT fits in int.
9910e595 4794
2638320e
PE
4795 * character.h (CHAR_VALID_P): Remove unused parameter.
4796 * fontset.c, lisp.h, xdisp.c: All uses changed.
4797
045eb8d9
PE
4798 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4799
c1f134b5
PE
4800 * fns.c (concat): Minor tuning based on overflow analysis.
4801 This doesn't fix any bugs. Use int to hold character, instead
4802 of constantly refetching from Emacs object. Use XFASTINT, not
4803 XINT, for value known to be a character. Don't bother comparing
4804 a single byte to 0400, as it's always less.
4805
395fcb93 4806 * floatfns.c (Fexpt):
327eeec8
PE
4807 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4808
abbd3d23
PE
4809 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4810 for characters.
4811
684a03ef
PE
4812 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4813
0fed43f3
PE
4814 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4815 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4816 incorrectly succeed when S was a string, because 4294967386 was
4817 truncated before it was used.
4818
8fd02eb7
PE
4819 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4820 Otherwise, an out-of-range integer could cause undefined behavior
4821 on a 64-bit host.
4822
f8c86b69
PE
4823 * composite.c: Use int, not EMACS_INT, for characters.
4824 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4825 EMACS_INT, for values that are known to be in character range.
4826 This doesn't fix any bugs but is the usual style inside Emacs and
4827 may generate better code on 32-bit machines.
4828
34206dd2
PE
4829 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4830 This is for reasons similar to the recent CHAR_STRING fix.
4831 * charset.c (Fencode_char): Check that character arg is actually
4832 a character. Pass an int to ENCODE_CHAR.
4833 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4834 wider than 'int', as a compile-time check to prevent future regressions
4835 in this area.
4836
c5958d4c 4837 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4838
4839 Make sure a 64-bit char is never passed to CHAR_STRING.
4840 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4841 by silently ignoring the top 32 bits, allowing some values
4842 that were far too large to be valid characters.
4843 * character.h: Include <verify.h>.
4844 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4845 arguments are no wider than unsigned, as a compile-time check
4846 to prevent future regressions in this area.
4847 * data.c (Faset):
01103c44 4848 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4849 (Fsubst_char_in_region):
4850 * fns.c (concat):
4851 * xdisp.c (decode_mode_spec_coding):
4852 Adjust to CHAR_STRING's new requirement.
4853 * editfns.c (Finsert_char, Fsubst_char_in_region):
4854 * fns.c (concat): Check that character args are actually
4855 characters. Without this test, these functions did the wrong
4856 thing with wildly out-of-range values on 64-bit hosts.
4857
d37ca623
PE
4858 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4859 These casts should not be needed on 32-bit hosts, either.
4860 * keyboard.c (read_char):
4861 * lread.c (Fload): Remove casts to unsigned.
4862
ea204efb
PE
4863 * lisp.h (UNSIGNED_CMP): New macro.
4864 This fixes comparison bugs on 64-bit hosts.
4865 (ASCII_CHAR_P): Use it.
4866 * casefiddle.c (casify_object):
01103c44 4867 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4868 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4869 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4870 * dispextern.h (FACE_FROM_ID):
4871 * keyboard.c (read_char): Use UNSIGNED_CMP.
4872
41cb286c
PE
4873 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4874 not to EMACS_INT, to avoid GCC warning.
4875
4a1b9832
PE
4876 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4877
55daad71
PE
4878 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4879 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4880 isn't needed on 32-bit machines.
8f95c75c 4881
01103c44
PE
4882 * buffer.c (Fgenerate_new_buffer_name):
4883 Use EMACS_INT for count, not int.
0ceccced 4884 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4885
4886 * data.c (Qcompiled_function): Now static.
4887
c6f072e7
PE
4888 * window.c (window_body_lines): Now static.
4889
20ce5912
PE
4890 * image.c (gif_load): Rename local to avoid shadowing.
4891
9c4c5f81
PE
4892 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4893 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4894 * alloc.c (make_save_value): Integer argument is now of type
4895 ptrdiff_t, not int.
4896 (mark_object): Use ptrdiff_t, not int.
4897 * lisp.h (pD): New macro.
4898 * print.c (print_object): Use it.
4899
c0c5c8ae
PE
4900 * alloc.c: Use EMACS_INT, not int, to count objects.
4901 (total_conses, total_markers, total_symbols, total_vector_size)
4902 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4903 (total_free_floats, total_floats, total_free_intervals)
4904 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4905 Now EMACS_INT, not int. All uses changed.
4906 (Fgarbage_collect): Compute overall total using a double, so that
4907 integer overflow is less likely to be a problem. Check for overflow
4908 when converting back to an integer.
5a25e253
PE
4909 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4910 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4911 These were 'int' variables that could overflow on 64-bit hosts;
4912 they were never used, so remove them instead of repairing them.
211a0b2a 4913 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4914 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4915 Previously, this ceilinged at INT_MAX, but that doesn't work on
4916 64-bit machines.
e46bb31a 4917 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4918
c78baabf 4919 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4920 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4921 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4922 when a (possibly-narrower) signed value would do just as well.
4923 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4924
c9d624c6
PE
4925 * alloc.c: Catch some string size overflows that we were missing.
4926 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4927 for convenience in STRING_BYTES_MAX.
4928 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4929 The definition here is exact; the one in lisp.h was approximate.
4930 (allocate_string_data): Check for string overflow. This catches
4931 some instances we weren't catching before. Also, it catches
4932 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4933 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4934 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4935
c9d624c6
PE
4936 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4937 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4938 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4939
353032ce
PE
4940 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4941
2bccce07
PE
4942 * alloc.c (Fmake_string): Check for out-of-range init.
4943
0ac30604
SM
49442011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4945
4946 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4947
c195f2de
JD
49482011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4949
4950 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4951 xg_get_default_scrollbar_width.
4952
4953 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4954 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4955 (style_changed_cb): Call update_theme_scrollbar_width and call
4956 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4957 all frames (Bug#8505).
4958 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4959 Call gtk_window_set_resizable if HAVE_GTK3.
4960 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4961 and height if HAVE_GTK3 (Bug#8505).
4962 (scroll_bar_width_for_theme): New variable.
4963 (update_theme_scrollbar_width): New function.
4964 (xg_get_default_scrollbar_width): Move code to
4965 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4966 (xg_initialize): Call update_theme_scrollbar_width.
4967
4968 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4969
4970 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4971
e10ac9f1
MR
49722011-06-12 Martin Rudalics <rudalics@gmx.at>
4973
4974 * frame.c (make_frame): Call other_buffer_safely instead of
4975 other_buffer.
4976
4977 * window.c (temp_output_buffer_show): Call display_buffer with
4978 second argument Vtemp_buffer_show_specifiers and reset latter
4979 immediately after the call.
4980 (Vtemp_buffer_show_specifiers): New variable.
4981 (auto_window_vscroll_p, next_screen_context_lines)
4982 (Vscroll_preserve_screen_position): Remove leading asterisks from
4983 doc-strings.
4984
2d3c217e 49852011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4986
7b7f97e8 4987 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4988 * buffer.c (Qclone_number): Remove for now, as it's unused.
4989 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4990 (record_buffer): Remove unused local.
4991 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4992 (set_frame_buffer_list): Remove; unused.
4993 * frame.h (other_visible_frames): Remove decl.
4994 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4995 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4996 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4997 if HAVE_GPM.
4998 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4999 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5000 Define only if HAVE_GPM.
5001 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5002 (update_hints_inhibit): Remove; never set. All uses removed.
5003 * widgetprv.h (emacsFrameClassRec): Remove decl.
5004 * window.c (delete_deletable_window): Now returns void, since it
5005 wasn't returning anything.
5006 (compare_window_configurations): Remove unused locals.
5007 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5008 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5009 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5010 the same widths as pointers. This follows up on the 2011-05-06 patch.
5011 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5012 * xterm.h: Likewise.
5013 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5014
1384b89e
JB
50152011-06-12 Juanma Barranquero <lekktu@gmail.com>
5016
5017 * makefile.w32-in: Update dependencies.
5018 (LISP_H): Add lib/intprops.h.
5019
1100a63c
CY
50202011-06-11 Chong Yidong <cyd@stupidchicken.com>
5021
5022 * image.c (gif_load): Add animation frame delay to the metadata.
5023 (syms_of_image): Use DEFSYM. New symbol `delay'.
5024
6198ccd0
MR
50252011-06-11 Martin Rudalics <rudalics@gmx.at>
5026
5027 * window.c (delete_deletable_window): Re-add.
5028 (Fset_window_configuration): Rewrite to handle dead buffers and
5029 consequently deletable windows.
5030 (window_tree, Fwindow_tree): Remove. Supply functionality in
5031 window.el.
5032 (compare_window_configurations): Simplify code.
5033
b6e3633c
AS
50342011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5035
1ab0dee5
AS
5036 * image.c (imagemagick_load_image): Fix type mismatch.
5037 (Fimagemagick_types): Likewise.
5038
b6e3633c
AS
5039 * window.h (replace_buffer_in_windows): Declare.
5040
9397e56f
MR
50412011-06-11 Martin Rudalics <rudalics@gmx.at>
5042
5043 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5044 Qclone_number. Remove external declaration of Qdelete_window.
5045 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5046 code.
640c8776
SM
5047 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5048 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5049 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5050 buffer list implementation.
5051 (other_buffer_safely): New function.
5052 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5053 calls to replace_buffer_in_windows and
5054 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5055 if allowed.
5056 (record_buffer): Inhibit quitting and rewrite using quittable
5057 functions. Run Qbuffer_list_update_hook if allowed.
5058 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5059 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5060 Move switch-to-buffer to window.el.
9397e56f
MR
5061 (bury-buffer): Move to window.el.
5062 (Vbuffer_list_update_hook): New variable.
5063
5064 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5065 section.
5066
5067 * window.h (resize_frame_windows): Move up in code.
5068 (Fwindow_frame): Remove EXFUN.
5069 (replace_buffer_in_all_windows): Remove prototype.
5070 (replace_buffer_in_windows_safely): Add prototype.
5071
5072 * window.c: Declare Qdelete_window static again. Move down
5073 declaration of select_count.
5074 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5075 (Fother_window): Move to window.el.
5076 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5077 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5078 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5079 window.el.
5080 (replace_buffer_in_windows): Implement by calling
5081 Qreplace_buffer_in_windows.
5082 (replace_buffer_in_all_windows): Remove with some functionality
5083 moved into replace_buffer_in_windows_safely.
5084 (replace_buffer_in_windows_safely): New function.
5085 (select_window_norecord, select_frame_norecord): Move in front
5086 of run_window_configuration_change_hook. Remove now obsolete
5087 declarations.
640c8776
SM
5088 (Fset_window_buffer): Rewrite doc-string.
5089 Call Qrecord_window_buffer.
9397e56f
MR
5090 (keys_of_window): Move binding for other-window to window.el.
5091
b50691aa
CY
50922011-06-11 Chong Yidong <cyd@stupidchicken.com>
5093
5094 * dispextern.h (struct image): Replace data member, whose int_val
5095 and ptr_val fields were not used by anything, with a single
5096 lisp_val object.
5097
5098 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5099 (gif_clear_image, gif_load, imagemagick_load_image)
5100 (gs_clear_image, gs_load): Callers changed.
5101
3f754b86
PE
51022011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5103
cca69397
PE
5104 * buffer.h: Include <time.h>, for time_t.
5105 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5106
109e28d0
PE
5107 Fix minor problems found by static checking.
5108
60737f02
PE
5109 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5110
4b66faf3
PE
5111 Make identifiers static if they are not used in other modules.
5112 * data.c (Qcompiled_function, Qframe, Qvector):
5113 * image.c (QimageMagick, Qsvg):
5114 * minibuf.c (Qmetadata):
5115 * window.c (resize_window_check, resize_root_window): Now static.
5116 * window.h (resize_window_check, resize_root_window): Remove decls.
5117
109e28d0
PE
5118 * window.c (window_deletion_count, delete_deletable_window):
5119 Remove; unused.
46a4ce9e
PE
5120 (window_body_lines): Now static.
5121 (Fdelete_other_windows_internal): Mark vars as initialized.
5122 Make sure 'resize_failed' is initialized.
5123 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5124 (resize_window_apply): Remove unused local.
5125 * window.h (delete_deletable_window): Remove decl.
5126
109e28d0 5127 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5128 (imagemagick_load_image): Fix pointer signedness problem by changing
5129 last arg from unsigned char * to char *. All uses changed.
5130 Also, fix a local for similar reasons.
5131 Remove unused locals. Remove locals to avoid shadowing.
5132 (fn_rsvg_handle_free): Remove; unused.
5133 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5134 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5135
3f754b86
PE
5136 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5137
2547adb1
CY
51382011-06-10 Chong Yidong <cyd@stupidchicken.com>
5139
5140 * image.c (gif_load): Fix omitted cast error introduced by
5141 2011-06-06 change.
5142
2c8e37d4
MR
51432011-06-10 Martin Rudalics <rudalics@gmx.at>
5144
5145 * window.h (resize_proportionally, orig_total_lines)
5146 (orig_top_line): Remove from window structure.
5147 (set_window_height, set_window_width, change_window_heights)
5148 (Fdelete_window): Remove prototypes.
5149 (resize_frame_windows): Remove duplicate declaration.
5150
440a42e3
EZ
51512011-06-10 Eli Zaretskii <eliz@gnu.org>
5152
5153 * window.h (resize_frame_windows, resize_window_check)
5154 (delete_deletable_window, resize_root_window)
5155 (resize_frame_windows): Declare prototypes.
5156
5157 * window.c (resize_window_apply): Make definition be "static" to
5158 match the prototype.
5159
562dd5e9
MR
51602011-06-10 Martin Rudalics <rudalics@gmx.at>
5161
5162 * window.c: Remove declarations of Qwindow_size_fixed,
5163 window_min_size_1, window_min_size_2, window_min_size,
5164 size_window, window_fixed_size_p, enlarge_window, delete_window.
5165 Remove static from declaration of Qdelete_window, it's
5166 temporarily needed by Fbury_buffer.
5167 (replace_window): Don't assign orig_top_line and
5168 orig_total_lines.
5169 (Fdelete_window, delete_window): Remove. Window deletion is
5170 handled by window.el.
640c8776
SM
5171 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5172 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5173 (Fdelete_other_windows): Remove. Deleting other windows is
5174 handled by window.el.
5175 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5176 handled in window.el.
5177 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5178 Window minimum sizes are handled in window.el.
5179 (shrink_windows, size_window, set_window_height)
5180 (set_window_width, change_window_heights, window_height)
5181 (window_width, CURBEG, CURSIZE, enlarge_window)
5182 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5183 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5184 handled in window.el.
5185 (make_dummy_parent): Rename to make_parent_window and give it a
5186 second argument horflag.
5187 (make_window): Don't set resize_proportionally any more.
5188 (Fsplit_window): Remove. Windows are split in window.el.
5189 (save_restore_action, save_restore_orig_size)
5190 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5191 Resize mini windows in window.el.
5192 (grow_mini_window, shrink_mini_window): Implement by calling
5193 Qresize_root_window_vertically, resize_window_check and
5194 resize_window_apply.
640c8776
SM
5195 (saved_window, Fset_window_configuration, save_window_save):
5196 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5197 resize_proportionally.
5198 (window_min_height, window_min_width): Move to window.el.
5199 (keys_of_window): Move bindings for delete-other-windows,
5200 split-window, delete-window and enlarge-window to window.el.
5201
5202 * buffer.c: Temporarily extern Qdelete_window.
5203 (Fbury_buffer): Temporarily call Qdelete_window instead of
5204 Fdelete_window (Fbury_buffer will move to window.el soon).
5205
5206 * frame.c (set_menu_bar_lines_1): Remove code handling
5207 orig_top_line and orig_total_lines.
5208
5209 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5210 set_window_height but set heights directly.
5211 (change_frame_size_1): Use resize_frame_windows.
5212
5213 * xdisp.c (init_xdisp): Don't use set_window_height but set
5214 heights directly.
5215
640c8776
SM
5216 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5217 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5218 run_window_configuration_change_hook.
5219
5220 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5221 instead of change_window_heights and run
5222 run_window_configuration_change_hook.
5223
1a13852e
MR
52242011-06-09 Martin Rudalics <rudalics@gmx.at>
5225
5226 * window.c (replace_window): Rename second argument REPLACEMENT to
5227 NEW. New third argument SETFLAG. Rewrite.
5228 (delete_window, make_dummy_parent): Call replace_window with
5229 third argument 1.
5230 (window_list_1): Move down in code.
5231 (run_window_configuration_change_hook): Move set_buffer part
5232 before select_frame_norecord part in order to unwind correctly.
5233 Rename count1 to count.
5234 (recombine_windows, delete_deletable_window, resize_root_window)
5235 (Fdelete_other_windows_internal)
5236 (Frun_window_configuration_change_hook, make_parent_window)
5237 (resize_window_check, resize_window_apply, Fresize_window_apply)
5238 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5239 (Fdelete_window_internal, Fresize_mini_window_internal):
5240 New functions.
1a13852e
MR
5241 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5242
f3d1777e
MR
52432011-06-08 Martin Rudalics <rudalics@gmx.at>
5244
496e208e
MR
5245 * window.h (window): Add some new members to window structure -
5246 normal_lines, normal_cols, new_total, new_normal, clone_number,
5247 splits, nest, prev_buffers, next_buffers.
5248 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5249 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5250
f3d1777e
MR
5251 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5252 Remove.
496e208e
MR
5253 (make_dummy_parent): Set new members of windows structure.
5254 (make_window): Move down in code. Handle new members of window
5255 structure.
5256 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5257 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5258 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5259 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5260 (Fset_window_next_buffers, Fset_window_clone_number):
5261 New functions.
496e208e
MR
5262 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5263 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5264 Doc-string fixes.
5265 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5266 Argument WINDOW can be now internal window too.
5267 (Fwindow_use_time): Move up in code.
5268 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5269 Rewrite doc-string.
5270 (Fset_window_configuration, saved_window)
5271 (Fcurrent_window_configuration, save_window_save): Handle new
5272 members of window structure.
b9e809c2
MR
5273 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5274 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5275 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5276 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5277 Qget_mru_window, Qresize_root_window,
5278 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5279 Qauto_buffer_name; staticpro them.
f3d1777e 5280
abde8f8c
MR
52812011-06-07 Martin Rudalics <rudalics@gmx.at>
5282
5283 * window.c (Fwindow_total_size, Fwindow_left_column)
5284 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5285 (Fwindow_list_1): New functions.
5286 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5287 (Fwindow_width, Fscroll_left, Fscroll_right):
5288 Use window_body_cols instead of window_box_text_cols.
5289 (delete_window, Fset_window_configuration):
5290 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5291 (delete_all_subwindows): Take a window as argument and not a
5292 structure. Rewrite.
190b47e6
MR
5293 (window_loop): Remove handling of GET_LRU_WINDOW and
5294 GET_LARGEST_WINDOW.
5295 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5296
5297 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5298 window_box_text_cols. delete_all_subwindows now takes a
5299 Lisp_Object as argument.
abde8f8c 5300
640c8776
SM
5301 * indent.c (compute_motion, Fcompute_motion):
5302 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5303
fa8a67e6
MR
5304 * frame.c (delete_frame): Call delete_all_subwindows with root
5305 window as argument.
5306
a54e3482
DC
53072011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5308
5309 * fns.c (Fputhash): Document return value.
5310
60002bf5
CY
53112011-06-06 Chong Yidong <cyd@stupidchicken.com>
5312
5313 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5314
0c671da6 53152011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5316
b862a52a 5317 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5318
be44ca6c
PE
5319 Check for overflow when converting integer to cons and back.
5320 * charset.c (Fdefine_charset_internal, Fdecode_char):
5321 Use cons_to_unsigned to catch overflow.
5322 (Fencode_char): Use INTEGER_TO_CONS.
5323 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5324 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5325 * data.c (long_to_cons, cons_to_long): Remove.
5326 (cons_to_unsigned, cons_to_signed): New functions.
5327 These signal an error for invalid or out-of-range values.
5328 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5329 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5330 * font.c (Ffont_variation_glyphs):
5331 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5332 * lisp.h: Include <intprops.h>.
5333 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5334 (cons_to_signed, cons_to_unsigned): New decls.
5335 (long_to_cons, cons_to_long): Remove decls.
5336 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5337 (Fprimitive_undo): Use CONS_TO_INTEGER.
5338 * xfns.c (Fx_window_property): Likewise.
5339 * xselect.c: Include <limits.h>.
5340 (x_own_selection, selection_data_to_lisp_data):
5341 Use INTEGER_TO_CONS.
5342 (x_handle_selection_request, x_handle_selection_clear)
5343 (x_get_foreign_selection, Fx_disown_selection_internal)
5344 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5345 (lisp_data_to_selection_data): Use cons_to_unsigned.
5346 (x_fill_property_data): Use cons_to_signed.
5347 Report values out of range.
5348
d1f3d2af
PE
5349 Check for buffer and string overflow more precisely.
5350 * buffer.h (BUF_BYTES_MAX): New macro.
5351 * lisp.h (STRING_BYTES_MAX): New macro.
5352 * alloc.c (Fmake_string):
5353 * character.c (string_escape_byte8):
5354 * coding.c (coding_alloc_by_realloc):
5355 * doprnt.c (doprnt):
5356 * editfns.c (Fformat):
5357 * eval.c (verror):
5358 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5359 since they may not be the same number.
5360 * editfns.c (Finsert_char):
5361 * fileio.c (Finsert_file_contents):
5362 Likewise for BUF_BYTES_MAX.
5363
dd52fcea
PE
5364 * image.c: Use ptrdiff_t, not int, for sizes.
5365 (slurp_file): Switch from int to ptrdiff_t.
5366 All uses changed.
5367 (slurp_file): Check that file size fits in both size_t (for
5368 malloc) and ptrdiff_t (for sanity and safety).
5369
7f9bbdbb
PE
5370 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5371 if b->modtime has its maximal value.
5372
dfe18f82
PE
5373 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5374
84acfcf0
PE
5375 Don't assume time_t can fit into int.
5376 * buffer.h (struct buffer.modtime): Now time_t, not int.
5377 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5378 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5379
ccd9a01a
PE
5380 Minor fixes for signed vs unsigned integers.
5381 * character.h (MAYBE_UNIFY_CHAR):
5382 * charset.c (maybe_unify_char):
5383 * keyboard.c (read_char, reorder_modifiers):
5384 XINT -> XFASTINT, since the integer must be nonnegative.
5385 * ftfont.c (ftfont_spec_pattern):
5386 * keymap.c (access_keymap, silly_event_symbol_error):
5387 XUINT -> XFASTINT, since the integer must be nonnegative.
5388 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5389 since it makes no difference and we prefer signed.
5390 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5391 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5392 nonnegative.
5393
d6d100dd
SM
53942011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5395
5396 * window.h (Fwindow_frame): Declare.
5397
2b6148e4
PE
53982011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5399
5400 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5401 (SPARE_MEMORY): Always define.
5402 (LARGE_REQUEST): Remove.
5403 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5404
f230ecc9
MR
54052011-06-06 Martin Rudalics <rudalics@gmx.at>
5406
727e958e
MR
5407 * lisp.h: Move EXFUNS for Fframe_root_window,
5408 Fframe_first_window and Fset_frame_selected_window to window.h.
5409
5410 * window.h: Move EXFUNS for Fframe_root_window,
5411 Fframe_first_window and Fset_frame_selected_window here from
5412 lisp.h.
5413
5414 * frame.c (Fwindow_frame, Fframe_first_window)
5415 (Fframe_root_window, Fframe_selected_window)
5416 (Fset_frame_selected_window): Move to window.c.
5417 (Factive_minibuffer_window): Move to minibuf.c.
5418 (Fother_visible_frames_p): New function.
5419
5420 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5421
f230ecc9
MR
5422 * window.c (decode_window, decode_any_window): Move up in code.
5423 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5424 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5425 (Fwindow_buffer): Move up and rewrite doc-string.
5426 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5427 (Fwindow_prev): New functions.
727e958e
MR
5428 (Fwindow_frame): Move here from frame.c. Accept any window as
5429 argument.
5430 (Fframe_root_window, Fframe_first_window)
5431 (Fframe_selected_window): Move here from frame.c. Accept frame
5432 or arbitrary window as argument. Update doc-strings.
5433 (Fminibuffer_window): Move up in code.
5434 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5435 (Fset_frame_selected_window): Move here from frame.c.
5436 Marginal rewrite.
727e958e
MR
5437 (Fselected_window, select_window, Fselect_window): Move up in
5438 code. Minor doc-string fixes.
f230ecc9 5439
4d09bcf6
PE
54402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5441
5442 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5443 Do not assume that spare memory exists; that assumption is valid
5444 only if SYSTEM_MALLOC.
5445 (LARGE_REQUEST): New macro, so that the issue of large requests
5446 is separated from the issue of spare memory.
5447
810928a2
AS
54482011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5449
172418ad
AS
5450 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5451 format. (Bug#8806)
5452
43f862f7
AS
5453 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5454
810928a2
AS
5455 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5456 before statements.
5457
a059fe24
JD
54582011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5459
5460 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5461
5462 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5463
5464 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5465 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5466
989bf368
JB
54672011-06-05 Juanma Barranquero <lekktu@gmail.com>
5468
5469 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5470
4b80f674
CY
54712011-06-04 Chong Yidong <cyd@stupidchicken.com>
5472
5473 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5474 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5475 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5476 New error handlers.
4b80f674
CY
5477 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5478 Obey Vx_select_enable_clipboard_manager. Catch errors in
5479 x_clipboard_manager_save (Bug#8779).
5480 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5481 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5482
99a33b77 54832011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5484
5485 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5486
99a33b77 54872011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5488
5489 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5490 in the current matrix if keep_current_p is non-zero.
5491
8264569d
EZ
54922011-06-04 Eli Zaretskii <eliz@gnu.org>
5493
5494 * bidi.c (bidi_level_of_next_char): Fix last change.
5495
57f97249
EZ
54962011-06-03 Eli Zaretskii <eliz@gnu.org>
5497
fec2107c 5498 Support bidi reordering of text covered by display properties.
57f97249 5499
fec2107c
EZ
5500 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5501 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5502 (bidi_cache_search, bidi_cache_iterator_state)
5503 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5504 (bidi_level_of_next_char, bidi_move_to_visually_next):
5505 Support character positions inside a run of characters covered by a
fec2107c
EZ
5506 display string.
5507 (bidi_paragraph_init, bidi_resolve_explicit_1)
5508 (bidi_level_of_next_char): Call bidi_fetch_char and
5509 bidi_fetch_char_advance instead of FETCH_CHAR and
5510 FETCH_CHAR_ADVANCE.
5511 (bidi_init_it): Initialize new members.
5512 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5513 definitions.
5514 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5515 instead of using explicit *_CHAR codes.
d6d100dd
SM
5516 (bidi_resolve_explicit, bidi_resolve_weak):
5517 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5518 bidirectional text is supported only in multibyte buffers.
5519 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5520 it to initialize the frame_window_p member of struct bidi_it.
5521 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5522 (bidi_resolve_explicit, bidi_resolve_weak)
5523 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5524 bidi_it->nchars is non-positive.
5525 (bidi_level_of_next_char): Don't try to lookup the cache for the
5526 next/previous character if nothing is cached there yet, or if we
5527 were just reseat()'ed to a new position.
c40e2fb2 5528
0e14fe90
EZ
5529 * xdisp.c (set_cursor_from_row): Set start and stop points
5530 according to the row's direction when priming the loop that looks
5531 for the glyph on which to display cursor.
5532 (single_display_spec_intangible_p): Function deleted.
5533 (display_prop_intangible_p): Reimplement to call
5534 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5535 Accept 3 additional arguments needed by handle_display_spec.
5536 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5537 values: lists, `(when COND...)' forms, etc.
5538 (single_display_spec_string_p): Support property values that are
5539 lists with the argument STRING its top-level element.
5540 (display_prop_string_p): Fix the condition for processing a
5541 property that is a list to be consistent with handle_display_spec.
fec2107c 5542 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5543 last portion of handle_display_prop.
5544 (compute_display_string_pos): Accept additional argument
5545 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5546 value of a `display' property is a "replacing spec".
5547 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5548 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5549 the display property, but just return a value indicating whether
5550 the display property will replace the characters it covers.
5551 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5552 frame_window_p members of struct bidi_it.
d6d100dd
SM
5553 (compute_display_string_pos, compute_display_string_end):
5554 New functions.
fec2107c
EZ
5555 (push_it): Accept second argument POSITION, where pop_it should
5556 jump to continue iteration.
5557 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5558
fec2107c
EZ
5559 * keyboard.c (adjust_point_for_property): Adjust the call to
5560 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5561
5562 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5563 (bidi_init_it): Update prototypes.
5564 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5565 (compute_display_string_pos, compute_display_string_end):
5566 Declare prototypes.
fec2107c
EZ
5567 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5568 EMACS_INT.
fc6f18ce 5569
40087514 55702011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5571
57f53182
PE
5572 Malloc failure behavior now depends on size of allocation.
5573 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5574 * lisp.h: Change signatures accordingly.
5575 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5576 All callers changed. (Bug#8762)
5577
5578 * gnutls.c: Use Emacs's memory allocators.
5579 Without this change, the gnutls library would invoke malloc etc.
5580 directly, which causes problems on non-SYNC_INPUT hosts, and which
5581 runs afoul of improving memory_full behavior. (Bug#8761)
5582 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5583 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5584 xfree instead of the default malloc, realloc, free.
5585 (Fgnutls_boot): No need to check for memory allocation failure,
5586 since xmalloc does that for us.
5587
ac32cd99 5588 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5589 * category.c (hash_get_category_set):
5590 * ccl.c (ccl_driver):
5591 * charset.c (Fdefine_charset_internal):
5592 * charset.h (struct charset.hash_index):
5593 * composite.c (get_composition_id, gstring_lookup_cache)
5594 (composition_gstring_put_cache):
5595 * composite.h (struct composition.hash_index):
5596 * dispextern.h (struct image.hash):
5597 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5598 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5599 (hashfn_equal, hashfn_user_defined, make_hash_table)
5600 (maybe_resize_hash_table, hash_lookup, hash_put)
5601 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5602 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5603 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5604 * image.c (make_image, search_image_cache, lookup_image)
5605 (xpm_put_color_table_h):
5606 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5607 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5608 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5609 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5610 * alloc.c (allocate_vectorlike):
5611 Check for overflow in vector size calculations.
5612 * ccl.c (ccl_driver):
5613 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5614 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5615 need to be updated by these changes.
40087514
PE
5616 * fns.c (make_hash_table, maybe_resize_hash_table):
5617 Check for integer overflow with large hash tables.
0de4bb68
PE
5618 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5619 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5620 (SXHASH_REDUCE): New macro.
5621 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5622 Use it instead of discarding useful hash info with large hash values.
5623 (sxhash_float): New function.
5624 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5625 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5626 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5627 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5628 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5629 Adjust signatures to match updated version of code.
5630 (consing_since_gc): Now EMACS_INT, since a single hash table can
5631 use more than INT_MAX bytes.
5632
698d32e2
DN
56332011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5634
5635 Make it possible to build with GCC-4.6+ -O2 -flto.
5636
5637 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5638
fd6fa53f
SM
56392011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5640
5641 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5642 Call minibuffer-inactive-mode.
5643
864db017
JB
56442011-05-31 Juanma Barranquero <lekktu@gmail.com>
5645
5646 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5647 Update dependencies.
5648
2ad0baf4
DN
56492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5650
5651 * data.c (init_data): Remove code for UTS, this system is not
5652 supported anymore.
5653
4fcc2638
DN
56542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5655
5656 Don't force ./temacs to start in terminal mode.
5657
5658 * frame.c (make_initial_frame): Initialize faces in all cases, not
5659 only when CANNOT_DUMP is defined.
5660 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5661
c56e0fd5
DN
56622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5663
5664 * dispnew.c (add_window_display_history): Use const for the string
5665 pointer. Remove declaration, not needed.
5666
333d54da 56672011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5668
55d4c1b2 5669 Use 'inline', not 'INLINE'.
333d54da 5670 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5671 * alloc.c, fontset.c (INLINE): Remove.
5672 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5673 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5674 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5675 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5676 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5677
738db178
DN
56782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5679
5680 Make it possible to run ./temacs.
5681
5682 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5683 syms_of_callproc does the same thing. Remove test for
5684 "initialized", do it in the caller.
5685 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5686
620c53a6
SM
56872011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5688
5689 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5690 (read_minibuf): Use get_minibuffer.
5691 (syms_of_minibuf): Use DEFSYM.
5692 (Qmetadata): New var.
5693 * data.c (Qbuffer): Don't make it static.
5694 (syms_of_data): Use DEFSYM.
5695
e003a292
PE
56962011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5697
5698 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5699 (CCL_CODE_MIN): New macro.
5700
ed008a6d
PE
57012011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5702
3687c2ef
PE
5703 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5704
ed008a6d
PE
5705 * eval.c (Qdebug): Now static.
5706 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5707 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5708 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5709
d66c4c7c
CY
57102011-05-29 Chong Yidong <cyd@stupidchicken.com>
5711
5712 * image.c: Various fixes to ImageMagick code comments.
5713 (Fimagemagick_types): Doc fix.
5714
5fbc2025
PE
57152011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5716
0196f88a
PE
5717 Minor fixes prompted by GCC 4.6.0 warnings.
5718
5719 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5720
5fbc2025
PE
5721 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5722 (x_clipboard_manager_save_all): Move extern decl to ...
5723 * xterm.h: ... here, so that it can be checked for consistency.
5724
1dd3c2d9
CY
57252011-05-29 Chong Yidong <cyd@stupidchicken.com>
5726
5727 * xselect.c (x_clipboard_manager_save_frame)
5728 (x_clipboard_manager_save_all): New functions.
5729 (Fx_clipboard_manager_save): Lisp function deleted.
5730
5731 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5732 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5733
5734 * xterm.h: Update prototype.
5735
5ba6571d
WX
57362011-05-28 William Xu <william.xwl@gmail.com>
5737
5738 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5739 exiting (Bug#8239).
5740
3eaff834
JM
57412011-05-28 Jim Meyering <meyering@redhat.com>
5742
e1900994 5743 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5744 * fns.c (to_uchar): Define.
5745 (crypto_hash_function): Use it to convert some newly-signed
5746 variables to unsigned, to avoid sign-extension bugs. For example,
5747 without this change, (md5 "truc") would evaluate to
5748 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5749 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5750 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5751
0f6990a7
PE
57522011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5753
5754 Integer overflow fixes.
c8a9ca5a 5755
08686060
PE
5756 * dbusbind.c: Serial number integer overflow fixes.
5757 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5758 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5759 to hold a serial number that is too large for a fixnum.
5760 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5761 Check for serial numbers out of range. Decode any serial number
59568bf0 5762 that was so large that it became a float. (Bug#8722)
08686060 5763
2d1fc3c7
PE
5764 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5765 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5766 Use XFASTINT rather than XUINT when numbers are nonnegative.
5767 (xd_append_arg, Fdbus_method_return_internal):
5768 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5769 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5770 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5771 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5772 (Bug#8722)
2d1fc3c7 5773
c8a9ca5a
PE
5774 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5775
519e1d69
PE
5776 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5777
6df6ae42 5778 ccl: Add integer overflow checks.
30569699
PE
5779 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5780 (IN_INT_RANGE): New macros.
5781 (ccl_driver): Use them to check for integer overflow when
5782 decoding a CCL program. Many of the new checks are whether XINT (x)
5783 fits in int; it doesn't always, on 64-bit hosts. The new version
5784 doesn't catch all possible integer overflows, but it's an
847044ea 5785 improvement. (Bug#8719)
30569699 5786
c11285dc
PE
5787 * alloc.c (make_event_array): Use XINT, not XUINT.
5788 There's no need for unsigned here.
5789
fdccd48e
PE
5790 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5791 This follows up to the 2011-05-06 change that substituted uintptr_t
5792 for EMACS_INT. This case wasn't caught back then.
5793
37910ab2
PE
5794 Rework Fformat to avoid integer overflow issues.
5795 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5796 now (part of C89). Include <verify.h>.
5797 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5798 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5799 (Fformat): Avoid the prepass trying to compute sizes; it was only
5800 approximate and thus did not catch overflow reliably. Instead, walk
5801 through the format just once, formatting and computing sizes as we go,
5802 checking for integer overflow at every step, and allocating a larger
5803 buffer as needed. Keep track separately whether the format is
5804 multibyte. Keep only the most-recently calculated precision, rather
5805 than them all. Record whether each argument has been converted to
5806 string. Use EMACS_INT, not int, for byte and char and arg counts.
5807 Support field widths and precisions larger than INT_MAX. Avoid
5808 sprintf's undefined behavior with conversion specifications such as %#d
5809 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5810 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5811 formatting out-of-range floating point numbers with int
9173deec 5812 formats. (Bug#8668)
37910ab2 5813
2e6578fb
PE
5814 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5815
0ae6bdee
PE
5816 * data.c: Avoid integer truncation in expressions involving floats.
5817 * data.c: Include <intprops.h>.
5818 (arith_driver): When there's an integer overflow in an expression
5819 involving floating point, convert the integers to floating point
5820 so that the resulting value does not suffer from catastrophic
5821 integer truncation. For example, on a 64-bit host (* 4
5822 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5823 Do not rely on undefined behavior after integer overflow.
5824
de883a70
PE
5825 merge count_size_as_multibyte, parse_str_to_multibyte
5826 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5827 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5828 Check for integer overflow.
5829 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5830 since it's now a duplicate of the other. This is more of
5831 a character than a buffer op, so better that it's in character.c.
5832 * fns.c, print.c: Adjust to above changes.
5833
2ff916cb
PE
58342011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5835
5836 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5837
f1b54466
PE
58382011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5839
fb1ac845
PE
5840 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5841 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5842 (x_clipboard_manager_save): Now static.
5843 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5844
f1b54466
PE
5845 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5846 (crypto_hash_function): Now static.
5847 Fix pointer signedness problems. Avoid unnecessary initializations.
5848
a9f737ee
CY
58492011-05-27 Chong Yidong <cyd@stupidchicken.com>
5850
5851 * termhooks.h (Vselection_alist): Make it terminal-local.
5852
5853 * terminal.c (create_terminal): Initialize it.
5854
5855 * xselect.c: Support for clipboard managers.
5856 (Vselection_alist): Move to termhooks.h as terminal-local var.
5857 (LOCAL_SELECTION): New macro.
5858 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5859 (symbol_to_x_atom): Remove gratuitous arg.
5860 (x_handle_selection_request, lisp_data_to_selection_data)
5861 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5862 (x_own_selection, x_get_local_selection, x_convert_selection):
5863 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5864 (some_frame_on_display): Delete unused function.
5865 (Fx_own_selection_internal, Fx_get_selection_internal)
5866 (Fx_disown_selection_internal, Fx_selection_owner_p)
5867 (Fx_selection_exists_p): New optional frame arg.
5868 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5869 (x_handle_selection_clear): Don't treat other terminals with the
5870 same keyboard specially. Use the terminal-local Vselection_alist.
5871 (x_clear_frame_selections): Use Frun_hook_with_args.
5872
5873 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5874
5875 * xterm.h: Add support for those atoms.
5876
e067f0c1
CY
58772011-05-26 Chong Yidong <cyd@stupidchicken.com>
5878
5879 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5880 (converted_selections, conversion_fail_tag): New global variables.
5881 (x_selection_request_lisp_error): Free the above.
5882 (x_get_local_selection): Remove unnecessary code.
5883 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5884 of converted selections stored in converted_selections.
5885 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5886 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5887 (x_convert_selection): New function.
5888 (x_handle_selection_event): Simplify.
5889 (x_get_foreign_selection): Don't ignore incoming requests while
5890 waiting for an answer; this will fail when we implement
5891 SAVE_TARGETS, and seems unnecessary anyway.
5892 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5893 (Vx_sent_selection_functions): Doc fix.
5894
0f4aebc0
LL
58952011-05-26 Leo Liu <sdl.web@gmail.com>
5896
5897 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5898
e61124cd
YM
58992011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5900
5901 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5902
5903 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5904 for fringe update if it has periodic bitmap.
ac389d0c 5905 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5906 and fringe_bitmap_periodic_p.
5907
5908 * fringe.c (get_fringe_bitmap_data): New function.
5909 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5910 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5911 row. Mark glyph row for fringe update if periodicity changed.
5912
5913 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5914 for fringe update unless it has periodic bitmap.
5915
f16d9837
KH
59162011-05-25 Kenichi Handa <handa@m17n.org>
5917
5918 * xdisp.c (get_next_display_element): Set correct it->face_id for
5919 a static composition.
5920
e1b90ef6
LL
59212011-05-24 Leo Liu <sdl.web@gmail.com>
5922
5923 * deps.mk (fns.o):
5924 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5925
5926 * fns.c (crypto_hash_function, Fsha1): New function.
5927 (Fmd5): Use crypto_hash_function.
5928 (syms_of_fns): Add Ssha1.
5929
7400048f
PE
59302011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5931
5932 * gnutls.c: Remove unused macros.
5933 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5934 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5935 Remove macros that are defined and never used.
5936 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5937
abb71cf4
CY
59382011-05-22 Chong Yidong <cyd@stupidchicken.com>
5939
5940 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5941 (Fx_get_selection_internal): Minor cleanup.
5942 (Fx_own_selection_internal): Rename arguments for consistency with
5943 select.el.
5944
6307db39
PE
59452011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5946
5947 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5948
f3d4e0a4
CY
59492011-05-22 Chong Yidong <cyd@stupidchicken.com>
5950
5951 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5952
4d8ade89
YM
59532011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5954
5955 * dispnew.c (scrolling_window): Don't exclude the case that the
5956 last enabled row in the desired matrix touches the bottom boundary.
5957
32078c8d
GM
59582011-05-21 Glenn Morris <rgm@gnu.org>
5959
5960 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5961 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5962 and add some more files.
32078c8d 5963
7285dc67
EZ
59642011-05-20 Eli Zaretskii <eliz@gnu.org>
5965
5966 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5967 report_file_error introduced by the change from 2011-05-07.
5968
89d1bd22
PE
59692011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5970
5971 * systime.h (Time): Define only if emacs is defined.
5972 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5973 where the include path doesn't have X11/X.h by default. See
5974 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5975
cd394be1 59762011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5977
5978 * composite.c (find_automatic_composition): Fix previous change.
5979
b9704ad9
GM
59802011-05-20 Glenn Morris <rgm@gnu.org>
5981
5982 * lisp.mk: New file, split from Makefile.in.
5983 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5984 (shortlisp): Remove.
5985 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5986
4a720484
GM
59872011-05-19 Glenn Morris <rgm@gnu.org>
5988
5989 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5990 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5991 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5992 (lisp): Set the order to that of loadup.el.
5993 (shortlisp): Make it a copy of $lisp.
5994 (SOME_MACHINE_LISP): Remove.
5995 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5996 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5997
a28d4396
KH
59982011-05-18 Kenichi Handa <handa@m17n.org>
5999
6000 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6001 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6002 (find_automatic_composition): Mostly rewrite for efficiency.
6003
a2b1fa8e
JB
60042011-05-18 Juanma Barranquero <lekktu@gmail.com>
6005
6006 * makefile.w32-in: Update dependencies.
6007
8e1f5610
CS
60082011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6009
6010 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6011 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6012
7025ee00 60132011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6014
cdfa6eab
PE
6015 Fix some integer overflow issues, such as string length overflow.
6016
06d6db33
PE
6017 * insdel.c (count_size_as_multibyte): Check for string overflow.
6018
2b4560a8
PE
6019 * character.c (lisp_string_width): Check for string overflow.
6020 Use EMACS_INT, not int, for string indexes and lengths; in
6021 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6022 the resulting string length overflows an EMACS_INT; instead,
6023 report a string overflow if no precision given. When checking for
6024 precision exhaustion, use a check that cannot possibly have
6025 integer overflow. (Bug#8675)
6026 * character.h (lisp_string_width): Adjust to new signature.
6027
cb93f9be
PE
6028 * alloc.c (string_overflow): New function.
6029 (Fmake_string): Use it. This doesn't change behavior, but saves
6030 a few bytes and will simplify future changes.
6031 * character.c (string_escape_byte8): Likewise.
6032 * lisp.h (string_overflow): New decl.
6033
1a1f3366
PE
6034 Fixups, following up to the user-interface timestamp change.
6035 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6036 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6037 * msdos.c (mouse_get_pos): Likewise.
6038 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6039 * w32gui.h (Time): Define by including "systime.h" rather than by
6040 declaring it ourselves. (Bug#8664)
6041
d4e3e4d3
PE
6042 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6043 * image.c (clear_image_cache): Likewise.
6044
f6a24d19
PE
6045 * term.c (term_mouse_position): Don't assume time_t wraparound.
6046
08dc5ae6
PE
6047 Be more systematic about user-interface timestamps.
6048 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6049 and sometimes 'EMACS_UINT', to represent these timestamps.
6050 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6051 This makes the code easier to follow, and makes it easier to catch
6052 integer overflow bugs such as Bug#8664.
6053 * frame.c (Fmouse_position, Fmouse_pixel_position):
6054 Use Time, not unsigned long, for user-interface timestamps.
6055 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6056 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6057 * keyboard.h (last_event_timestamp): Likewise.
6058 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6059 * menu.h (xmenu_show): Likewise.
6060 * term.c (term_mouse_position): Likewise.
6061 * termhooks.h (struct input_event.timestamp): Likewise.
6062 (struct terminal.mouse_position_hook): Likewise.
6063 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6064 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6065 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6066 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6067 what it was before.
6068 * menu.h, termhooks.h: Include "systime.h", for Time.
6069
8e55734a
PE
6070 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6071 Don't assume that the difference between two unsigned long values
6072 can fit into an integer. At this point, we know button_down_time
6073 <= event->timestamp, so the difference must be nonnegative, so
6074 there's no need to cast the result if double-click-time is
6075 nonnegative, as it should be; check that it's nonnegative, just in
6076 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6077 apart (about 25 days). (Bug#8664)
8e55734a 6078
841f1b75 6079 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6080 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6081
3e26f69c
PE
6082 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6083 that always fit in int. Use a sentinel instead of a counter, to
6084 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6085 * frame.h (struct frame): Use int for menu_bar_items_used
6086 instead of EMACS_INT, since it always fits in int.
3e26f69c 6087
5cc152c0
PE
6088 * menu.c (grow_menu_items): Check for int overflow.
6089
d89eb65e
PE
6090 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6091
5235bd3e
PE
6092 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6093 Before, the code was not consistent. These values cannot exceed
6094 2**31 - 1 so there's no need to make them unsigned.
6095 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6096 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6097 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6098 as modifiers.
6099 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6100
bc827e23
PE
6101 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6102 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6103 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6104 presumably because the widths might not match.
6105
78eb494e
PE
6106 * window.c (size_window): Avoid needless test at loop start.
6107
04f2d78b
CB
61082011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6109
6110 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6111
d2fc7e3d 61122011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6113
6114 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6115
d2fc7e3d 61162011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6117
6118 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6119 `width' to `bar_area_x' and `bar_area_width', respectively.
6120 (x_scroll_run): Take account of fringe background extension.
6121
04f2d78b
CB
6122 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6123 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6124 `bar_area_width', respectively.
6125 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6126 background extension.
6127
79b70037
GM
61282011-05-10 Jim Meyering <meyering@redhat.com>
6129
6130 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6131
2f142cc5
JB
61322011-05-10 Juanma Barranquero <lekktu@gmail.com>
6133
6134 * image.c (Finit_image_library): Return t for built-in image types,
6135 like pbm and xbm. (Bug#8640)
6136
57679c86
AS
61372011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6138
6139 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6140
888c9e86
EZ
61412011-05-07 Eli Zaretskii <eliz@gnu.org>
6142
b0512a1d
EZ
6143 * w32console.c (Fset_screen_color): Doc fix.
6144 (Fget_screen_color): New function.
6145 (syms_of_ntterm): Defsubr it.
6146
7285dc67
EZ
6147 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6148 unlink the temporary file if Fcall_process didn't create it in the
6149 first place.
6150 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6151 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6152 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6153 cue to call_process_cleanup not to close that handle.
6154
4d3fcc8e
BK
61552011-05-07 Ben Key <bkey76@gmail.com>
6156
6157 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6158 one of two shell specific rules, either bootstrap-temacs-CMD or
6159 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6160 to the previous implementation of the bootstrap-temacs rule.
6161 The bootstrap-temacs-CMD rule is similar to the previous
6162 implementation of the bootstrap-temacs rule except that it
6163 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6164 variable.
6165
6166 These changes, along with some changes to nt/configure.bat,
6167 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6168 earlier fix to add support for --cflags and --ldflags options
6169 that include quotes so that it works whether make uses cmd or
6170 sh as the shell.
6171
b4289b64
MA
61722011-05-06 Michael Albinus <michael.albinus@gmx.de>
6173
6174 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6175 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6176 is a constant.
6177 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6178 a string. Handle both cases.
6179 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6180 (Fdbus_register_method): Use Qinvalid_function.
6181
af4c0e28
JB
61822011-05-06 Juanma Barranquero <lekktu@gmail.com>
6183
6184 * makefile.w32-in: Update dependencies.
6185 (LISP_H): Add inttypes.h and stdin.h.
6186 (PROCESS_H): Add unistd.h.
6187
c51453d9
EZ
61882011-05-06 Eli Zaretskii <eliz@gnu.org>
6189
6190 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6191 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6192
8ff0ac3c 61932011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6194
4c4b566b
PE
6195 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6196
aab2b9b5
PE
6197 * term.c (vfatal): Remove stray call to va_end.
6198 It's not needed and the C Standard doesn't allow it here anyway.
6199
c378da0b
PE
6200 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6201 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6202
288b08c7
PE
6203 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6204 bytes.
6205
e3601888
PE
6206 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6207
db6c0e74
PE
6208 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6209
dd5963ea
PE
6210 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6211
88c9450f
PE
6212 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6213
2f9442b8
PE
6214 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6215
c032b5f8
PE
6216 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6217 * charset.c (Fdefine_charset_internal): Don't initialize
6218 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6219 32-bit int (Bug#8600).
a108c10b
PE
6220
6221 * lread.c (read_integer): Be more consistent with string-to-number.
6222 Use string_to_number to do the actual conversion; this avoids
6223 rounding errors and fixes some other screwups. Without this fix,
6224 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6225 (digit_to_number): Move earlier, for benefit of read_integer.
6226 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6227 not a digit in any supported base. (Bug#8602)
a108c10b 6228
ad5f9eea
PE
6229 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6230
aec1708a
PE
6231 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6232 to match comment at start of function. This also removes a
6233 GCC warning about overflow in a 32+64-bit port.
6234
47be4ab5
PE
6235 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6236
371cac43
PE
6237 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6238 Reported by Stefan Monnier in
6239 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6240 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6241 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6242
d01a7826
PE
6243 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6244 (EMACS_UINTPTR): Likewise, with uintptr_t.
6245
7fd47d5c
PE
6246 * lisp.h: Prefer 64-bit EMACS_INT if available.
6247 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6248 on 32-bit hosts that have 64-bit int, so that they can access
6249 large files.
122b0c86
PE
6250 However, temporarily disable this change unless the temporary
6251 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6252
8727937b
PE
6253 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6254
8ac068ac
PE
6255 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6256 This removes an assumption that EMACS_INT and long are the same
6257 width as pointers. The assumption is true for Emacs porting targets
6258 now, but we want to make other targets possible.
6259 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6260 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6261 In the rest of the code, change types of integers that hold casted
6262 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6263 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6264 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6265 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6266 No need to cast type when ORing.
6267 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6268 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6269 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6270 assume EMACS_INT is the same width as char *.
6271 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6272 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6273 Remove no-longer-needed casts.
6274 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6275 (xg_tool_bar_help_callback, xg_make_tool_item):
6276 Use EMACS_INTPTR to hold an integer
6277 that will be cast to void *; this can avoid a GCC warning
6278 if EMACS_INT is not the same width as void *.
6279 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6280 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6281 (current_message_1, set_message_1):
6282 Use a local to convert to proper width without a cast.
6283 * xmenu.c (dialog_selection_callback): Likewise.
6284
ede49d71
PE
6285 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6286 Also, don't assume VALBITS / RAND_BITS is less than 5,
6287 and don't rely on undefined behavior when shifting a 1 left into
6288 the sign bit.
6289 * lisp.h (get_random): Change signature to match.
6290
2f30ecd0
PE
6291 * lread.c (hash_string): Use size_t, not int, for hash computation.
6292 Normally we prefer signed values; but hashing is special, because
6293 it's better to use unsigned division on hash table sizes so that
6294 the remainder is nonnegative. Also, size_t is the natural width
6295 for hashing into memory. The previous code used 'int', which doesn't
6296 retain enough info to hash well into very large tables.
6297 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6298
2a866e7b
PE
6299 * dbusbind.c: Don't possibly lose pointer info when converting.
6300 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6301 Use XPNTR rather than XHASH, so that the high-order bits of
6302 the pointer aren't lost when converting through void *.
6303
51639eac
PE
6304 * eval.c (Fautoload): Don't double-shift a pointer.
6305
92394119
PE
6306 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6307
dbdb9a7c
JB
63082011-05-06 Juanma Barranquero <lekktu@gmail.com>
6309
6310 * gnutls.c (DEF_GNUTLS_FN):
6311 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6312
db7a0b4f
AS
63132011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6314
6315 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6316 marker. (Bug#8610)
6317
cd394be1 63182011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6319
6320 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6321 New version that can reserve upto 2GB of heap space.
6322
f7ff1b0f 63232011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6324
6325 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6326
639c109b
TZ
63272011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6328
6329 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6330 `gnutls_certificate_set_x509_key_file'.
6331
d2127135
JB
63322011-05-05 Juanma Barranquero <lekktu@gmail.com>
6333
6334 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6335 Update dependencies.
6336
e968f4f3
JB
63372011-05-04 Juanma Barranquero <lekktu@gmail.com>
6338
6339 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6340 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6341 Remove unused parameter `fildes'.
6342 * process.c (read_process_output, send_process): Don't pass it.
6343
84d358f0
JB
63442011-05-04 Juanma Barranquero <lekktu@gmail.com>
6345
6346 Fix previous change: the library cache is defined in w32.c.
6347 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6348 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6349
0898ca10
JB
63502011-05-04 Juanma Barranquero <lekktu@gmail.com>
6351
6352 Implement dynamic loading of GnuTLS on Windows.
6353
6354 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6355 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6356 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6357 Declare.
6358
6359 * gnutls.c (Qgnutls_dll): Define.
6360 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6361 (gnutls_*): Declare function pointers.
6362 (init_gnutls_functions): New function to initialize function pointers.
6363 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6364 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6365 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6366 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6367 (emacs_gnutls_write, emacs_gnutls_read)
6368 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6369 (Fgnutls_available_p): New function.
6370 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6371 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6372 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6373
6374 * image.c: Include w32.h.
6375 (Vimage_type_cache): Delete.
6376 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6377 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6378 (w32_delayed_load): Move to w32.c.
6379
6380 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6381
6382 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6383 (w32_delayed_load): Move from image.c. When loading a library, record
6384 its filename in the :loaded-from property of the library id.
6385 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6386 Initialize and staticpro them.
6387 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6388
6389 * process.c: Include lisp.h before w32.h, not after.
6390 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6391 instead of gnutls_record_check_pending.
6392
6393 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6394
ff4de4aa
TZ
63952011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6396
6397 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6398 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6399 as passed in.
6400
abe95abb
JD
64012011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6402
6403 * xterm.c (x_set_frame_alpha): Do not set property on anything
6404 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6405
e16e55d4
JB
64062011-05-02 Juanma Barranquero <lekktu@gmail.com>
6407
6408 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6409
bafcf6a5
JB
64102011-05-02 Juanma Barranquero <lekktu@gmail.com>
6411
6412 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6413 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6414 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6415 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6416 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6417 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6418 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6419 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6420 (Qgnutls_bootprop_callbacks_verify): Make static.
6421
e7a6747f
AS
64222011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6423
19ed11ba
AS
6424 * callproc.c: Indentation fixup.
6425
e7a6747f 6426 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6427 (wait_for_termination, interruptible_wait_for_termination):
6428 Move after wait_for_termination_1.
e7a6747f 6429
1ef14cb4
LMI
64302011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6431
6432 * sysdep.c (interruptible_wait_for_termination): New function
6433 which is like wait_for_termination, but allows keyboard
6434 interruptions.
6435
6436 * callproc.c (Fcall_process): Add (:file "file") as an option for
6437 the STDOUT buffer.
6438 (Fcall_process_region): Ditto.
6439
330d880c
EZ
64402011-04-30 Eli Zaretskii <eliz@gnu.org>
6441
8db90b73
EZ
6442 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6443 rather than `XVECTOR (FOO)->size'.
6444
330d880c
EZ
6445 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6446 inttypes.h, as a gnulib replacement is used if it not available in
6447 system headers.
6448
15cbd324
EZ
64492011-04-21 Eli Zaretskii <eliz@gnu.org>
6450
6451 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6452 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6453 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6454
6455 * coding.c (coding_alloc_by_realloc): Error out if destination
6456 will grow beyond MOST_POSITIVE_FIXNUM.
6457 (decode_coding_emacs_mule): Abort if there isn't enough place in
6458 charbuf for the composition carryover bytes. Reserve an extra
6459 space for up to 2 characters produced in a loop.
6460 (decode_coding_iso_2022): Abort if there isn't enough place in
6461 charbuf for the composition carryover bytes.
6462
64632011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6464
ae940cca
EZ
6465 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6466 aborting when %lld or %lll format is passed.
6467 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6468 %llo or %llx format is passed. (Bug#8545)
6469
03ab8921
EZ
6470 * window.c (window_scroll_line_based): Use a marker instead of
6471 simple variables to record original value of point. (Bug#7952)
6472
afda1437
EZ
6473 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6474 produced by %s or %c overflows available buffer space. (Bug#8545)
6475
f76dee0c
PE
64762011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6477
6478 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6479 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6480
fdc5744d
JB
64812011-04-28 Juanma Barranquero <lekktu@gmail.com>
6482
6483 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6484
638f053a
JB
64852011-04-28 Juanma Barranquero <lekktu@gmail.com>
6486
6487 * keyboard.c (Qdelayed_warnings_hook): Define.
6488 (command_loop_1): Run `delayed-warnings-hook'
6489 if Vdelayed_warnings_list is non-nil.
6490 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6491 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6492
d178f871
EZ
64932011-04-28 Eli Zaretskii <eliz@gnu.org>
6494
6495 * doprnt.c (doprnt): Don't return value smaller than the buffer
6496 size if the message was truncated. (Bug#8545).
6497
b124fd93
JB
64982011-04-28 Juanma Barranquero <lekktu@gmail.com>
6499
6500 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6501 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6502
e810457d
PE
65032011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6504
6505 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6506
ea51cceb
JB
65072011-04-27 Juanma Barranquero <lekktu@gmail.com>
6508
6509 * makefile.w32-in: Update dependencies.
6510
94dcfacf
EZ
65112011-04-27 Eli Zaretskii <eliz@gnu.org>
6512
6513 Improve `doprnt' and its usage. (Bug#8545)
6514 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6515 `format_end'. Remove support for %l as a conversion specifier.
6516 Don't use xrealloc. Improve diagnostics when the %l size modifier
6517 is used. Update the commentary.
6518
6519 * eval.c (verror): Simplify calculation of size_t.
6520
6521 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6522 messages.
6523
f61f41d7
PE
65242011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6525
6526 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6527 change.
6528
96fb4434
PE
65292011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6530
6531 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6532 This makes this file independent of the recent pseudovector change.
6533
671875da 65342011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6535
69e9b5a3
PE
6536 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6537
b5f869a7 6538 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6539 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6540 Remove unused local.
c8926152 6541 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6542
841a1577 6543 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6544 GCC 4.6.0 optimizes based on type-based alias analysis.
6545 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6546 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6547 != &v->size, and therefore "v->size = 1; b->size = 2; return
6548 v->size;" must therefore return 1. This assumption is incorrect
6549 for Emacs, since it type-puns struct Lisp_Vector * with many other
6550 types. To fix this problem, this patch adds a new type struct
f904488f 6551 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6552 and pseudovectors, and helps optimizing compilers not get fooled
6553 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6554 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6555 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6556 the size member.
eab3844f
PE
6557 (XSETPVECTYPE): Rewrite in terms of new macro.
6558 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6559 This is a bit clearer, and further avoids the possibility of
6560 undesirable aliasing.
6561 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6562 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6563 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6564 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6565 (ASIZE): Now uses header.size rather than size.
6566 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6567 to avoid the hassle of writing XVECTOR (foo)->header.size.
6568 (struct vectorlike_header): New type.
eab3844f
PE
6569 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6570 object, to help avoid aliasing.
6571 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6572 (SUBRP): Likewise, since Lisp_Subr is a special case.
6573 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6574 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6575 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6576 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6577 changed to be "header.size" and "header.next".
6578 * buffer.h (struct buffer): Likewise.
6579 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6580 * frame.h (struct frame): Likewise.
6581 * process.h (struct Lisp_Process): Likewise.
6582 * termhooks.h (struct terminal): Likewise.
6583 * window.c (struct save_window_data, struct saved_window): Likewise.
6584 * window.h (struct window): Likewise.
6585 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6586 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6587 * buffer.c (init_buffer_once): Likewise.
6588 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6589 special case.
6590 * process.c (Fformat_network_address): Use local var for size,
6591 for brevity.
6592
0df1eac5
PE
6593 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6594
847ab9d1 6595 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6596 * data.c (atof): Remove decl; no longer used or needed.
6597 (digit_to_number): Move to lread.c.
6598 (Fstring_to_number): Use new string_to_number function, to be
6599 consistent with how the Lisp reader treats infinities and NaNs.
6600 Do not assume that floating-point numbers represent EMACS_INT
6601 without losing information; this is not true on most 64-bit hosts.
6602 Avoid double-rounding errors, by insisting on integers when
6603 parsing non-base-10 numbers, as the documentation specifies.
6604 * lisp.h (string_to_number): New decl, replacing ...
6605 (isfloat_string): Remove.
bc0a5c13 6606 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6607 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6608 appears to have been a coding error. Similarly, do not accept
6609 strings like +-1e0 as floating point numbers. Do not report
6610 overflow for integer overflows unless the base is not 10 which
6611 means we have no simple and reliable way to continue.
6612 Break out the floating-point parsing into a new
6613 function string_to_number, so that Fstring_to_number parses
6614 floating point numbers consistently with the Lisp reader.
04f2d78b 6615 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6616 (E_CHAR, EXP_INT): Remove, replacing with ...
6617 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6618 (string_to_number): New function, replacing isfloat_string.
6619 This function checks for valid syntax and produces the resulting
6620 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6621 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6622 so that overflow for non-base-10 numbers is reported only when
6623 there's no portable and simple way to convert to floating point.
452f4150 6624
67769ffc
PE
6625 * textprop.c (set_text_properties_1): Rewrite for clarity,
6626 and to avoid GCC warning about integer overflow.
6627
c20db43f
PE
6628 * intervals.h (struct interval): Use EMACS_INT for members
6629 where EMACS_UINT might cause problems. See
6630 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6631 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6632 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6633 All uses changed.
37aa2f85
PE
6634 (offset_intervals): Tell GCC not to worry about length overflow
6635 when negating a negative length.
c20db43f 6636
2538aa2f
PE
6637 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6638 (overrun_check_free): Likewise.
6639
f2d3008d
PE
6640 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6641 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6642 word size.
6643
ec8df744
PE
6644 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6645 (gnutls_make_error): Rename local to avoid shadowing.
6646 (gnutls_emacs_global_deinit): ifdef out; not used.
6647 (Fgnutls_boot): Use const for pointer to readonly storage.
6648 Comment out unused local. Fix pointer signedness problems.
6649
640ee02d
PE
6650 * lread.c (openp): Don't stuff size_t into an 'int'.
6651 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6652 about possible signed overflow.
6653
6048fb2a
PE
6654 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6655 (GDK_KEY_g): Don't define if already defined.
6656 (xg_prepare_tooltip): Avoid pointer signedness problem.
6657 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6658
fa3c87e1
PE
6659 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6660 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6661
2172544b
PE
6662 * xfns.c (Fx_window_property): Simplify a bit,
6663 to make a bit faster and to avoid GCC 4.6.0 warning.
6664 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6665
9b821a21
PE
6666 * fns.c (internal_equal): Don't assume size_t fits in int.
6667
3c616cfa
PE
6668 * alloc.c (compact_small_strings): Tighten assertion a little.
6669
c2982e87
PE
6670 Replace pEd with more-general pI, and fix some printf arg casts.
6671 * lisp.h (pI): New macro, generalizing old pEd macro to other
6672 conversion specifiers. For example, use "...%"pI"d..." rather
6673 than "...%"pEd"...".
6674 (pEd): Remove. All uses replaced with similar uses of pI.
6675 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6676 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6677 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6678 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6679 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6680 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6681 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6682 64-bit hosts.
6683 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6684 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6685 * print.c (safe_debug_print, print_object): Likewise.
6686 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6687 to int.
6f04d126
PE
6688 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6689 avoiding the 0 flag, which is not portable.
c2982e87
PE
6690 * process.c (Fmake_network_process): Use pI to avoid cast.
6691 * region-cache.c (pp_cache): Likewise.
6692 * xdisp.c (decode_mode_spec): Likewise.
6693 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6694 behavior on 64-bit hosts with printf arg.
6f04d126 6695 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6696 (x_stop_queuing_selection_requests): Likewise.
6697 (x_get_window_property): Don't truncate byte count to an 'int'
6698 when tracing.
0b432f21 6699
5e073ec7
PE
6700 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6701 here, since it parses constructs like leading '-' and spaces,
6702 which are not wanted; and it overflows with large numbers.
6703 Instead, simply match F[0-9]+, which is what is wanted anyway.
6704
36372bf9
PE
6705 * alloc.c: Remove unportable assumptions about struct layout.
6706 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6707 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6708 (allocate_vectorlike, make_pure_vector): Use the new macros,
6709 plus offsetof, to remove unportable assumptions about struct layout.
6710 These assumptions hold on all porting targets that I know of, but
6711 they are not guaranteed, they're easy to remove, and removing them
6712 makes further changes easier.
6713
0b432f21
PE
6714 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6715 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6716 (string_overrun_cookie): Now const. Use initializers that
6717 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6718 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6719 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6720 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6721 multiple of sizeof (EMACS_INT); it need not be, if
6722 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6723 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6724
895009e1
JB
67252011-04-26 Juanma Barranquero <lekktu@gmail.com>
6726
6727 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6728
6a7a1b0b
TZ
67292011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6730
6731 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6732 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6733 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6734
841a1577 67352011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6736
6737 * lisp.h (Qdebug): List symbol.
895009e1 6738 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6739 * keyboard.c (debug-on-event): New variable.
6740 (handle_user_signal): Break into debugger when debug-on-event
6741 matches the current signal symbol.
6742
f2d3ba6f
DN
67432011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6744
6745 * alloc.c (check_sblock, check_string_bytes)
6746 (check_string_free_list): Convert to standard C.
6747
42ce4c63
TZ
67482011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6749
6750 * w32.c (emacs_gnutls_push): Fix typo.
6751
825cd63c
EZ
67522011-04-25 Eli Zaretskii <eliz@gnu.org>
6753
fb11d64d
EZ
6754 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6755 "cast to pointer from integer of different size".
6756
825cd63c
EZ
6757 Improve doprnt and its use in verror. (Bug#8545)
6758 * doprnt.c (doprnt): Document the set of format control sequences
6759 supported by the function. Use SAFE_ALLOCA instead of always
6760 using `alloca'.
6761
6762 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6763 is one byte too soon. Don't use xrealloc; instead xfree and
6764 xmalloc anew.
6765
e061a11b
TZ
67662011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6767
6768 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6769 callbacks stage.
6770
6771 * gnutls.c: Renamed global_initialized to
6772 gnutls_global_initialized. Added internals for the
6773 :verify-hostname-error, :verify-error, and :verify-flags
6774 parameters of `gnutls-boot' and documented those parameters in the
6775 docstring. Start callback support.
9173deec
JB
6776 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6777 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6778 on error. Return error code.
e061a11b
TZ
6779 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6780 (emacs_gnutls_read): Likewise.
6781 (Fgnutls_boot): Return handshake error code.
6782 (emacs_gnutls_handle_error): New function.
6783 (wsaerror_to_errno): Likewise.
6784
6785 * w32.h (emacs_gnutls_pull): Add prototype.
6786 (emacs_gnutls_push): Likewise.
6787
6788 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6789 (emacs_gnutls_push): Likewise.
6790
67912011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6792
6793 * process.c (wait_reading_process_output): Check if GnuTLS
6794 buffered some data internally if no FDs are set for TLS
6795 connections.
6796
6797 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6798 (LIBS): Link to USER_LIBS.
6799 ($(BLD)/gnutls.$(0)): New target.
6800
fa6996bc
EZ
68012011-04-24 Eli Zaretskii <eliz@gnu.org>
6802
eb35682e
EZ
6803 * xdisp.c (handle_single_display_spec): Rename the
6804 display_replaced_before_p argument into display_replaced_p, to
6805 make it consistent with the commentary. Fix typos in the
6806 commentary.
6807
e2ad650c
EZ
6808 * textprop.c (syms_of_textprop): Remove dead code.
6809 (copy_text_properties): Delete obsolete commentary about an
6810 interface that was deleted long ago. Fix typos in the description
6811 of arguments.
6812
1b2de274
EZ
6813 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6814 to changes in oldXMenu/XMenu.h from 2011-04-16.
6815 <menu_help_message, prev_menu_help_message>: Constify.
6816 (IT_menu_make_room): menu->help_text is now `const char **';
6817 adjust.
6818
6819 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6820 to changes in oldXMenu/XMenu.h from 2011-04-16.
6821 (struct XMenu): Declare `help_text' `const char **'.
6822
6823 * xfaces.c <Qunspecified>: Make extern again.
6824
6825 * syntax.c: Include sys/types.h before including regex.h, as
6826 required by Posix.
6827
762b15be
EZ
6828 * doc.c (get_doc_string): Improve the format passed to `error'.
6829
6830 * doprnt.c (doprnt): Improve commentary.
6831
6832 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6833
6834 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6835 them with etags.
6836
f1052e5d
EZ
6837 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6838 changes in globals.h immediately force recompilation.
762b15be
EZ
6839 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6840 $(CURDIR)/s/ms-w32.h.
6841 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6842
fa6996bc
EZ
6843 * character.c (Fchar_direction): Function deleted.
6844 (syms_of_character): Don't defsubr it.
6845 <char-direction-table>: Deleted.
6846
e6c3da20
EZ
68472011-04-23 Eli Zaretskii <eliz@gnu.org>
6848
6849 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6850 * doprnt.c: Include limits.h.
6851 (SIZE_MAX): New macro.
04f2d78b
CB
6852 (doprnt): Return a size_t value. 2nd arg is now size_t.
6853 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6854 Improve overflow protection. Support `l' modifier for integer
6855 conversions. Support %l conversion. Don't assume an EMACS_INT
6856 argument for integer conversions and for %c.
6857
6858 * lisp.h (doprnt): Restore prototype.
6859
6860 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6861 $(SRC)/character.h.
6862
6863 * Makefile.in (base_obj): Add back doprnt.o.
6864
6865 * deps.mk (doprnt.o): Add back prerequisites.
6866 (callint.o): Depend on character.h.
6867
6868 * eval.c (internal_lisp_condition_case): Include the handler
6869 representation in the error message.
6870 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6871 when breaking from the loop.
6872
6873 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6874
6875 * callint.c (Fcall_interactively): When displaying error message
6876 about invalid control letter, pass the character's codepoint, not
6877 a pointer to its multibyte form. Improve display of the character
6878 in octal and display also its hex code.
6879
6880 * character.c (char_string): Use %x to display the (unsigned)
6881 codepoint of an invalid character, to avoid displaying a bogus
6882 negative value.
6883
6884 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6885 `error', not SYMBOL_NAME itself.
6886
6887 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6888 character arguments to `error'.
6889
6890 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6891 to `error' in error message about FINAL_CHAR argument. Make sure
6892 FINAL_CHAR is a character, and use %c when it is passed as
6893 argument to `error'.
6894
4ffd0d6b 68952011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6896
6897 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6898
6899 * w32.c: Include <time.h>.
6900 (sys_localtime): New function.
6901
4ffd0d6b 69022011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6903
6904 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6905
4ffd0d6b 6906 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6907
4ffd0d6b 69082011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6909
4ffd0d6b
GM
6910 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6911 zombies (Bug#8467).
aac0c6e3 6912
04c56954
EZ
69132011-04-19 Eli Zaretskii <eliz@gnu.org>
6914
6915 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6916 gl_state.e_property when gl_state.object is Qt.
6917
6918 * insdel.c (make_gap_larger): Remove limitation of buffer size
6919 to <= INT_MAX.
6920
16a43933
CY
69212011-04-18 Chong Yidong <cyd@stupidchicken.com>
6922
6923 * xdisp.c (lookup_glyphless_char_display)
6924 (produce_glyphless_glyph): Handle cons cell entry in
6925 glyphless-char-display.
6926 (Vglyphless_char_display): Document it.
6927
6928 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6929 glyphless-char-display.
6930
4581706e
CY
69312011-04-17 Chong Yidong <cyd@stupidchicken.com>
6932
6933 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6934
6935 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6936
6937 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6938 definition for no-X builds.
6939
4887c6e2 69402011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6941
fd35b6f9
PE
6942 Static checks with GCC 4.6.0 and non-default toolkits.
6943
5c1ccb01
PE
6944 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6945
006c5daa
PE
6946 * process.c (keyboard_bit_set): Define only if SIGIO.
6947 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6948 (send_process): Repair possible setjmp clobbering.
6949
efc736d3
PE
6950 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6951
4e2fe2e6
PE
6952 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6953
f97334a2
PE
6954 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6955
4e75f29d
PE
6956 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6957 Define only if needed.
6958
90efadd1
PE
6959 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6960 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6961 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6962
3c647824
PE
6963 * dispextern.h (struct redisplay_interface): Rename param
6964 to avoid shadowing.
e264f262 6965 * termhooks.h (struct terminal): Likewise.
761383f4 6966 * xterm.c (xembed_send_message): Likewise.
3c647824 6967
b58c5c4a
PE
6968 * insdel.c (make_gap_smaller): Define only if
6969 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6970
cad59032
PE
6971 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6972 it.
6973
c339dc2e
PE
6974 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6975 so that we aren't warned about unused symbols.
6976
91a3e27b
PE
6977 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6978
399c71d3 6979 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6980
8ffc96f5
PE
6981 * xfns.c (x_real_positions): Mark locals as initialized.
6982
eef9bc79
PE
6983 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6984
098db9dd
PE
6985 * xterm.c: Fix problems found by static analysis with other toolkits.
6986 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6987 (x_dispatch_event): Declare static if USE_GTK, and
6988 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6989 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6990 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6991 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6992 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6993
eb18f6cc
PE
6994 * xmenu.c (menu_help_callback): Pointer type fixes.
6995 Use const pointers when pointing at readonly data. Avoid pointer
6996 signedness clashes.
6997 (FALSE): Remove unused macro.
6998 (update_frame_menubar): Remove unused decl.
6999
1fe72bf8
PE
7000 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7001
60d9e1db
PE
7002 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7003 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7004 (single_menu_item): Rename local to avoid shadowing.
7005
39261c26
PE
7006 * keyboard.c (make_lispy_event): Remove unused local var.
7007
018c5e19
PE
7008 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7009 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7010
63d2b86e
PE
7011 * bitmaps: Change bitmaps from unsigned char back to the X11
7012 compatible char. Avoid the old compiler warnings about
7013 out-of-range initializers by using, for example, '\xab' rather
7014 than 0xab.
7015
aefd87e1
PE
7016 * xgselect.c (xgselect_initialize): Check vs interface
7017 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7018
bf501fb9
PE
7019 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7020
e9829fdf
PE
7021 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7022 to read-only memory.
7023
1086c095
PE
7024 * fns.c (vector): Remove; this old hack is no longer needed.
7025
2baccd04 7026 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7027 Remove unused var.
dde42981 7028 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7029
72391843 7030 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7031
436c16df 7032 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7033 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7034 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7035
92bb796d 7036 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7037 (x_term_init): Remove local to avoid shadowing.
92bb796d 7038
764430a3 7039 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7040
7041 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7042 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7043
d1dfb56c
EZ
70442011-04-16 Eli Zaretskii <eliz@gnu.org>
7045
c4354cb4
EZ
7046 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7047
d1dfb56c
EZ
7048 Fix regex.c, syntax.c and friends for buffers > 2GB.
7049 * syntax.h (struct gl_state_s): Declare character position members
7050 EMACS_INT.
7051
7052 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7053
04f2d78b
CB
7054 * textprop.c (verify_interval_modification, interval_of):
7055 Declare arguments EMACS_INT.
d1dfb56c
EZ
7056
7057 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7058 EMACS_INT.
7059
7060 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7061
7062 * indent.c (Fvertical_motion): Local variable it_start is now
7063 EMACS_INT.
7064
7065 * regex.c (re_match, re_match_2, re_match_2_internal)
7066 (bcmp_translate, regcomp, regexec, print_double_string)
7067 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7068 (re_compile_pattern, re_exec): Declare arguments and local
7069 variables `size_t' and `ssize_t' and return values `regoff_t', as
7070 appropriate.
7071 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7072 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7073 <compile_stack_type>: `size' and `avail' are now `size_t'.
7074
7075 * regex.h <regoff_t>: Use ssize_t, not int.
7076 (re_search, re_search_2, re_match, re_match_2): Arguments that
7077 specify buffer/string position and length are now ssize_t and
7078 size_t. Return type is regoff_t.
7079
613052cd
BK
70802011-04-16 Ben Key <bkey76@gmail.com>
7081
7082 * nsfont.m: Fixed bugs in ns_get_family and
7083 ns_descriptor_to_entity that were caused by using free to
7084 deallocate memory blocks that were allocated by xmalloc (via
7085 xstrdup). This caused Emacs to crash when compiled with
7086 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7087 --enable-checking=xmallocoverrun). xfree is now used to
7088 deallocate these memory blocks.
7089
4170f62f 70902011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7091
71b41406
PE
7092 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7093
9587a89d
PE
7094 emacs_write: Accept and return EMACS_INT for sizes.
7095 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7096 et seq.
7097 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7098 Accept and return EMACS_INT.
7099 (emacs_gnutls_write): Return the number of bytes written on
7100 partial writes.
7101 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7102 (emacs_read, emacs_write): Remove check for negative size, as the
7103 Emacs source code has been audited now.
9587a89d
PE
7104 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7105 (emacs_read, emacs_write): Use it.
273a5f82
PE
7106 * process.c (send_process): Adjust to the new signatures of
7107 emacs_write and emacs_gnutls_write. Do not attempt to store
7108 a byte offset into an 'int'; it might overflow.
9587a89d 7109 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7110
3e047f51
PE
7111 * sound.c: Don't assume sizes fit in 'int'.
7112 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7113 Return EMACS_INT, not int.
3e047f51 7114 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7115 Accept EMACS_INT, not int.
7116 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7117 record read return values.
7118
cc39a9db
BK
71192011-04-15 Ben Key <bkey76@gmail.com>
7120
c9d0ec6d
JB
7121 * keyboard.c (Qundefined): Don't declare static since it is used
7122 in nsfns.m.
7123 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7124 static since they are used in nsfont.m.
cc39a9db 7125
6c60eb9f
SM
71262011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7127
7128 * process.c (Qprocessp): Don't declare static.
7129 * lisp.h (Qprocessp): Declare again.
7130
7990b61a
JB
71312011-04-15 Juanma Barranquero <lekktu@gmail.com>
7132
7133 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7134
5d4cb038
PE
71352011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7136
8bd7b830 7137 Improve C-level modularity by making more things 'static'.
cd64ea1d 7138
e3b27b31
PE
7139 Don't publish debugger-only interfaces to other modules.
7140 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7141 (verify_bytepos, count_markers): Move decls to the only modules
7142 that need them.
7143 * region-cache.h (pp_cache): Likewise.
7144 * window.h (check_all_windows): Likewise.
7145 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7146
5d4cb038
PE
7147 * sysdep.c (croak): Now static, if
7148 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7149 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7150
7151 * alloc.c (refill_memory_reserve): Now static if
7152 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7153 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7154
e87b6180
PE
7155 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7156 Define only if USE_LUCID.
7157
ac64929e
PE
7158 * xrdb.c (x_customization_string, x_rm_string): Now static.
7159
6f37259d
PE
7160 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7161 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7162
1683e3ab
PE
7163 * xdisp.c (draw_row_with_mouse_face): Now static.
7164 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7165
de9c2632
PE
7166 * window.h (check_all_windows): Mark externally visible.
7167
2b96acb7
PE
7168 * window.c (window_deletion_count): Now static.
7169
7170 * undo.c: Make symbols static if they're not exported.
7171 (last_undo_buffer, last_boundary_position, pending_boundary):
7172 Now static.
7173
50436f33
PE
7174 * textprop.c (interval_insert_behind_hooks): Now static.
7175 (interval_insert_in_front_hooks): Likewise.
7176
64520e5c
PE
7177 * term.c: Make symbols static if they're not exported.
7178 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7179 (max_frame_lines, tty_set_terminal_modes):
7180 (tty_reset_terminal_modes, tty_turn_off_highlight):
7181 (get_tty_terminal): Now static.
7182 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7183 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7184 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7185 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7186 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7187
1fa53021
PE
7188 * sysdep.c: Make symbols static if they're not exported.
7189 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7190 Now static.
7191 (sigprocmask_set, full_mask): Remove; unused.
7192 (wait_debugging): Mark as visible.
7193 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7194 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7195
d4b43b22
PE
7196 * syntax.c (syntax_temp): Define only if !__GNUC__.
7197
b7c513d0
PE
7198 * sound.c (current_sound_device, current_sound): Now static.
7199
989b29ad
PE
7200 * search.c (searchbufs, searchbuf_head): Now static.
7201
13a55a78
PE
7202 * scroll.c (scroll_cost): Remove; unused.
7203 * dispextern.h (scroll_cost): Remove decl.
7204
de68a1fc
PE
7205 * region-cache.h (pp_cache): Mark as externally visible.
7206
40ccffa6
PE
7207 * process.c: Make symbols static if they're not exported.
7208 (process_tick, update_tick, create_process, chan_process):
7209 (Vprocess_alist, proc_buffered_char, datagram_access):
7210 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7211 (deactivate_process): Mark defn as static, as well as decl.
7212 * lisp.h (create_process): Remove decl.
7213 * process.h (chan_process, Vprocess_alist): Remove decls.
7214
ad64fc97
PE
7215 * print.c: Make symbols static if they're not exported.
7216 (print_depth, new_backquote_output, being_printed, print_buffer):
7217 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7218 (print_interval, print_number_index, initial_stderr_stream):
7219 Now static.
7220 * lisp.h (Fprinc): Remove decl.
7221 (debug_output_compilation_hack): Mark as externally visible.
7222
adddb265
PE
7223 * sysdep.c (croak): Move decl from here to syssignal.h.
7224 * syssignal.h (croak): Put it here, so the API can be checked when
7225 'croak' is called from dissociate_if_controlling_tty.
7226
1717ede2
PE
7227 * minibuf.c: Make symbols static if they're not exported.
7228 (minibuf_save_list, choose_minibuf_frame): Now static.
7229 * lisp.h (choose_minibuf_frame): Remove decl.
7230
fa5fb2bc
PE
7231 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7232
1e3890d1
PE
7233 * lread.c: Make symbols static if they're not exported.
7234 (read_objects, initial_obarray, oblookup_last_bucket_number):
7235 Now static.
7236 (make_symbol): Remove; unused.
7237 * lisp.h (initial_obarray, make_symbol): Remove decls.
7238
8a1414fa
PE
7239 * keyboard.c: Make symbols static if they're not exported.
7240 (single_kboard, recent_keys_index, total_keys, recent_keys):
7241 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7242 (this_single_command_key_start, echoing, last_auto_save):
7243 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7244 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7245 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7246 (Vlispy_mouse_stem, double_click_count):
7247 Now static.
7248 (force_auto_save_soon): Define only if SIGDANGER.
7249 (ignore_mouse_drag_p): Now static if
7250 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7251 (print_help): Remove; unused.
7252 (stop_character, last_timer_event): Mark as externally visible.
7253 * keyboard.h (ignore_mouse_drag_p): Declare only if
7254 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7255 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7256 * lisp.h (echoing): Remove decl.
7257 (force_auto_save_soon): Declare only if SIGDANGER.
7258 * xdisp.c (redisplay_window): Simplify code, to make it more
7259 obvious that ignore_mouse_drag_p is not accessed if !defined
7260 USE_GTK && !defined HAVE_NS.
7261
93ea6e8f
PE
7262 * intervals.c: Make symbols static if they're not exported.
7263 (merge_properties_sticky, merge_interval_right, delete_interval):
7264 Now static.
7265 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7266
77382fcc
PE
7267 * insdel.c: Make symbols static if they're not exported.
7268 However, leave prepare_to_modify_buffer alone. It's never
7269 called from outside this function, but that appears to be a bug.
7270 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7271 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7272 (adjust_after_replace_noundo): Remove; unused.
7273 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7274 (signal_before_change): Remove decls.
77382fcc 7275
9306c32e
PE
7276 * indent.c (val_compute_motion, val_vmotion): Now static.
7277
cd44d2eb
PE
7278 * image.c: Make symbols static if they're not exported.
7279 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7280 if USE_GTK.
7281 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7282 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7283
ad9a7a06
PE
7284 * fringe.c (standard_bitmaps): Now static.
7285 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7286
81626931
PE
7287 * frame.c: Make symbols static if they're not exported.
7288 (x_report_frame_params, make_terminal_frame): Now static.
7289 (get_frame_param): Now static, unless HAVE_NS.
7290 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7291 (x_get_resource_string): Remove; not used.
7292 * frame.h (make_terminal_frame, x_report_frame_params):
7293 (x_get_resource_string); Remove decls.
7294 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7295 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7296
239f9db9
PE
7297 * font.c, fontset.c: Make symbols static if they're not exported.
7298 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7299 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7300 * font.c (font_close_object): Now static.
7301 * font.h (font_close_object): Remove.
7302 * fontset.c (FONTSET_OBJLIST): Remove.
7303 (free_realized_fontset) #if-0 the body, which does nothing.
7304 (face_suitable_for_char_p): #if-0, as it's never called.
7305 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7306 * xfaces.c (face_at_string_position):
7307 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7308 since 0 is always ASCII.
7309
dfcf3579
PE
7310 * fns.c (weak_hash_tables): Now static.
7311
5045092b
PE
7312 * fileio.c: Make symbols static if they're not exported.
7313 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7314 (Vwrite_region_annotation_buffers): Now static.
7315
57a96f5c
PE
7316 * eval.c: Make symbols static if they're not exported.
7317 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7318 * lisp.h (backtrace_list): Remove decl.
7319
35f08c38
PE
7320 * emacs.c: Make symbols static if they're not exported.
7321 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7322 (fatal_error_code, fatal_error_signal_hook, standard_args):
7323 Now static.
7324 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7325 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7326 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7327 * lisp.h (fatal_error_signal_hook): Remove decl.
7328 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7329
f44bd759
PE
7330 * editfns.c: Move a (normally-unused) function to its only use.
7331 * editfns.c, lisp.h (get_operating_system_release): Remove.
7332 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7333 worth the hassle of breaking this out.
7334
b532497d
PE
7335 * xterm.c: Make symbols static if they're not exported.
7336 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7337 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7338 (x_destroy_window, x_delete_display):
7339 Now static.
7340 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7341 (x_mouse_leave): Remove; unused.
7342 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7343 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7344 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7345 Remove decls.
7346 (x_mouse_leave): Declare only if WINDOWSNT.
7347 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7348 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7349 USE_X_TOOLKIT.
7350
1675728f
PE
7351 * ftxfont.c: Make symbols static if they're not exported.
7352 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7353 HAVE_FREETYPE.
7354 * font.h (ftxfont_driver): Likewise.
7355
e4cebfca
PE
7356 * xfns.c: Make symbols static if they're not exported.
7357 (x_last_font_name, x_display_info_for_name):
7358 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7359 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7360 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7361 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7362 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7363 (last_show_tip_args): Now static.
7364 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7365 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7366 (x_screen_planes): Remove; unused.
7367 * dispextern.h (x_screen_planes): Remove decl.
7368
5bf46f05
PE
7369 * dispnew.c: Make symbols static if they're not exported.
7370 * dispextern.h (redraw_garbaged_frames, scrolling):
7371 (increment_row_positions): Remove.
7372 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7373 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7374 Now static.
7375 (redraw_garbaged_frames): Remove; unused.
7376
435f4c28
PE
7377 * xfaces.c: Make symbols static if they're not exported.
7378 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7379 Remove decls.
7380 * xterm.h (defined_color): Remove decls.
7381 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7382 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7383 (menu_face_changed_default, defined_color, free_realized_face):
7384 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7385 (ascii_face_of_lisp_face): Remove; unused.
7386
8524aef3
PE
7387 * xdisp.c: Make symbols static if they're not exported.
7388 * dispextern.h (scratch_glyph_row, window_box_edges):
7389 (glyph_to_pixel_coords, set_cursor_from_row):
7390 (get_next_display_element, set_iterator_to_next):
7391 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7392 (show_mouse_face): Remove decls
7393 * frame.h (message_buf_print): Likewise.
7394 * lisp.h (pop_message, set_message, check_point_in_composition):
7395 Likewise.
7396 * xterm.h (set_vertical_scroll_bar): Likewise.
7397 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7398 (message_buf_print, scratch_glyph_row, displayed_buffer):
7399 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7400 (get_next_display_element, show_mouse_face, window_box_edges):
7401 (frame_to_window_pixel_xy, check_point_in_composition):
7402 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7403 (glyph_to_pixel_coords): Remove; unused.
7404
16390cd2
PE
7405 * dired.c (file_name_completion): Now static.
7406
7407 * dbusbind.c (xd_in_read_queued_messages): Now static.
7408
a25f4dfa
PE
7409 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7410 * data.c (circular_list_error): Remove.
7411
14a9c8df
PE
7412 * commands.h (last_point_position, last_point_position_buffer):
7413 (last_point_position_window): Remove decls.
7414 * keyboard.c: Make these variables static.
7415
04f2d78b
CB
7416 * coding.h (coding, code_convert_region, encode_coding_gap):
7417 Remove decls.
74ab6df5
PE
7418 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7419 (iso_code_class, detect_coding, code_convert_region): Now static.
7420 (encode_coding_gap): Remove; unused.
7421
38dfbee1
PE
7422 * chartab.c (chartab_chars, chartab_bits): Now static.
7423
a2cb4e63
PE
7424 * charset.h (charset_iso_8859_1): Remove decl.
7425 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7426 Now static.
7427
127198fd
PE
7428 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7429 * ccl.c (Vccl_program_table): Now static.
7430 (check_ccl_update): Remove; unused.
7431
d85b608f
PE
7432 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7433 * category.h: ... from here.
7434 * category.c (check_category_table, set_category_set): Now static.
7435
31cd66f3
PE
7436 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7437 * lisp.h: Remove these decls.
7438
c358e587
PE
7439 * buffer.c (buffer_count): Remove unused var.
7440
e78aecca
PE
7441 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7442 so that it's not optimized away.
7443 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7444 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7445 exported only to the debugger.
7446
e192d7d3 7447 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7448 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7449
92470028
PE
7450 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7451 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7452 was inaccessible from Lisp.
7453 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7454 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7455
244ed907
PE
7456 alloc.c: Import and export fewer symbols, and remove unused items.
7457 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7458 is defined.
7459 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7460 it's not optimized away by whole-program optimization.
7461 (message_enable_multibyte, free_misc): Remove.
7462 (catchlist, handlerlist, mark_backtrace):
7463 Declare only if BYTE_MARK_STACK.
7464 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7465 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7466 (message_enable_multibyte): Remove decl.
7467 (free_misc, interval_free_list, float_block, float_block_index):
7468 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7469 (cons_free_list, last_marked_index):
7470 Now static.
7471 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7472 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7473 (mark_backtrace): Define only if BYTE_MARK_STACK.
7474 * xdisp.c (message_enable_multibyte): Now static.
7475
61c2b50e 7476 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7477 This makes it easier for human readers (and static analyzers)
7478 to see whether these variables are used from other modules.
7479 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7480 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7481 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7482 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7483 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7484 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7485 * xmenu.c, xselect.c:
7486 Declare Q* vars static if they are not used in other modules.
7487 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7488 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7489 Remove decls of unexported vars.
7490 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7491
95c82688
PE
7492 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7493
16a97296
PE
7494 Make Emacs functions such as Fatom 'static' by default.
7495 This makes it easier for human readers (and static analyzers)
7496 to see whether these functions can be called from other modules.
7497 DEFUN now defines a static function. To make the function external
7498 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7499 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7500 (Finit_image_library):
16a97296
PE
7501 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7502 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7503 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7504 Remove decls, since these functions are now static.
7505 (Funintern, Fget_internal_run_time): New decls, since these functions
7506 were already external.
95c82688 7507
16a97296
PE
7508 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7509 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7510 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7511 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7512 * keyboard.c, keymap.c, lread.c:
7513 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7514 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7515 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7516 Mark functions with DEFUE instead of DEFUN,
7517 if they are used in other modules.
7518 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7519 decls for now-static functions.
7520 * buffer.h (Fdelete_overlay): Remove decl.
7521 * callproc.c (Fgetenv_internal): Mark as internal.
7522 * composite.c (Fremove_list_of_text_properties): Remove decl.
7523 (Fcomposition_get_gstring): New forward static decl.
7524 * composite.h (Fcomposite_get_gstring): Remove decl.
7525 * dired.c (Ffile_attributes): New forward static decl.
7526 * doc.c (Fdocumntation_property): New forward static decl.
7527 * eval.c (Ffetch_bytecode): New forward static decl.
7528 (Funintern): Remove extern decl; now in .h file where it belongs.
7529 * fileio.c (Fmake_symbolic_link): New forward static decl.
7530 * image.c (Finit_image_library): New forward static decl.
7531 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7532 * intervals.h (Fprevious_property_change):
7533 (Fremove_list_of_text_properties): Remove decls.
7534 * keyboard.c (Fthis_command_keys): Remove decl.
7535 (Fcommand_execute): New forward static decl.
7536 * keymap.c (Flookup_key): New forward static decl.
7537 (Fcopy_keymap): Now static.
7538 * keymap.h (Flookup_key): Remove decl.
7539 * process.c (Fget_process): New forward static decl.
7540 (Fprocess_datagram_address): Mark as internal.
7541 * syntax.c (Fsyntax_table_p): New forward static decl.
7542 (skip_chars): Remove duplicate decl.
7543 * textprop.c (Fprevious_property_change): New forward static decl.
7544 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7545 Now internal.
7546 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7547 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7548
785bbd42
PE
7549 * editfns.c (Fformat): Remove unreachable code.
7550
8b913b57
AS
75512011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7552
7553 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7554 change. (Bug#8496)
7555
a6744a35
EZ
75562011-04-13 Eli Zaretskii <eliz@gnu.org>
7557
7558 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7559 when at ZV. (Bug#8487)
7560
e7974947
AS
75612011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7562
baad03f0
AS
7563 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7564 (Bug#8437)
7565 * keyboard.c (parse_tool_bar_item): Likewise.
7566 * sound.c (sound_cleanup, alsa_close): Likewise.
7567 * termcap.c (tgetent): Likewise.
7568 * xfns.c (x_default_font_parameter): Likewise.
7569 * xsettings.c (read_and_apply_settings): Likewise.
7570
e7974947
AS
7571 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7572 (overrun_check_free): Protoize.
7573
28272684
PE
75742011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7575
7576 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7577 since callers should never pass a negative size.
7578 Change the signature to match that of plain 'read' and 'write'; see
7579 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7580 * lisp.h: Update prototypes of emacs_write and emacs_read.
7581
11997c76
EZ
75822011-04-11 Eli Zaretskii <eliz@gnu.org>
7583
7584 * xdisp.c (redisplay_window): Don't try to determine the character
7585 position of the scroll margin if the window start point w->startp
e896f03c 7586 is outside the buffer's accessible region. (Bug#8468)
11997c76 7587
8a2cbd72
EZ
75882011-04-10 Eli Zaretskii <eliz@gnu.org>
7589
7590 Fix write-region and its subroutines for buffers > 2GB.
7591 * fileio.c (a_write, e_write): Modify declaration of arguments and
7592 local variables to support buffers larger than 2GB.
7593 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7594
7595 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7596 argument, local variables, and return value.
7597
7598 * lisp.h: Update prototypes of emacs_write and emacs_read.
7599
7600 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7601
4073e537 76022011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7603
1ebfdcb6
PE
7604 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7605
b2ded58d
PE
7606 Fix more problems found by GCC 4.6.0's static checks.
7607
7d66342c
PE
7608 * xdisp.c (vmessage): Use a better test for character truncation.
7609
bbf47d44
PE
7610 * charset.c (load_charset_map): <, not <=, for optimization,
7611 and to avoid potential problems with integer overflow.
9248994d 7612 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7613 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7614 * editfns.c (Fformat): Likewise.
1e69125e 7615 * syntax.c (skip_chars): Likewise.
3befa583 7616
e3019616
PE
7617 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7618 This also lets GCC 4.6.0 generate slightly better loop code.
7619
becfa255
PE
7620 * callint.c (Fcall_interactively): <, not <=, for optimization.
7621 (Fcall_interactively): Count the number of arguments produced,
7622 not the number of arguments given. This is simpler and lets GCC
7623 4.6.0 generate slightly better code.
7624
dae0cd48
PE
7625 * ftfont.c: Distingish more carefully between FcChar8 and char.
7626 The previous code passed unsigned char * to a functions like
7627 strlen and xstrcasecmp that expect char *, which does not
7628 conform to the C standard.
7629 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7630 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7631 char * when the C standard requires it.
7632
76032d70
PE
7633 * keyboard.c (read_char): Remove unused var.
7634
eb3f1cc8
PE
7635 * eval.c: Port to Windows vsnprintf (Bug#8435).
7636 Include <limits.h>.
7637 (SIZE_MAX): Define if the headers do not.
7638 (verror): Do not give up if vsnprintf returns a negative count.
7639 Instead, grow the buffer. This ports to Windows vsnprintf, which
7640 does not conform to C99. Problem reported by Eli Zaretskii.
7641 Also, simplify the allocation scheme, by avoiding the need for
7642 calling realloc, and removing the ALLOCATED variable.
7643
70476b54
PE
7644 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7645
12020a9e
PE
7646 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7647 But keep the doprint source code for now, as we might revamp it
7648 and use it again (Bug#8435).
ea6c7ae6
PE
7649 * lisp.h (doprnt): Remove.
7650 * Makefile.in (base_obj): Remove doprnt.o.
7651 * deps.mk (doprnt.o): Remove.
7652
5fdb398c
PE
7653 error: Print 32- and 64-bit integers portably (Bug#8435).
7654 Without this change, on typical 64-bit hosts error ("...%d...", N)
7655 was used to print both 32- and 64-bit integers N, which relied on
7656 undefined behavior.
7657 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7658 New macro.
7659 * lisp.h (error, verror): Mark as printf-like functions.
7660 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7661 Report overflow in size calculations when allocating printf buffer.
7662 Do not truncate output string at its first null byte.
7663 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7664 Truncate the output at a character boundary, since vsnprintf does not
7665 do that.
7666 * charset.c (check_iso_charset_parameter): Convert internal
7667 character to string before calling 'error', since %c now has the
7668 printf meaning.
7669 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7670 overflow when computing char to be passed to 'error'. Do not
7671 pass Lisp_Object to 'error'; pass the integer instead.
7672 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7673 formatted with plain %d.
7674
b189fa66
PE
7675 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7676
bff87ef0
PE
7677 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7678
7e2cac20
PE
7679 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7680
ce4d90b5
PE
7681 * xterm.c (x_catch_errors): Remove duplicate declaration.
7682
266c9547
PE
7683 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7684
79c49ad2
PE
7685 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7686
368f4090
JM
76872011-04-10 Jim Meyering <meyering@redhat.com>
7688
7689 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7690 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7691 return ssize_t not "int", and use size_t as the buffer length.
7692 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7693 * gnutls.h: Update declarations.
7694 * process.c (read_process_output): Use ssize_t, to match.
7695 (send_process): Likewise.
7696
a32d4040
CY
76972011-04-09 Chong Yidong <cyd@stupidchicken.com>
7698
7699 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7700
8546720e 77012011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7702
04f2d78b
CB
7703 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7704 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7705
8546720e
GM
7706 * xterm.c (handle_one_xevent):
7707 * xmenu.c (create_and_show_popup_menu):
7708 * xselect.c (x_decline_selection_request)
7709 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7710
0a2f5c1a 77112011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7712
7713 Fix some uses of `int' instead of EMACS_INT.
7714 * search.c (string_match_1, fast_string_match)
7715 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7716 (scan_buffer, find_next_newline_no_quit)
7717 (find_before_next_newline, search_command, Freplace_match)
7718 (Fmatch_data): Make some `int' variables be EMACS_INT.
7719
7720 * xdisp.c (display_count_lines): 3rd argument and return value now
7721 EMACS_INT. All callers changed.
7722 (pint2hrstr): Last argument is now EMACS_INT.
7723
7724 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7725 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7726 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7727 (decode_coding_utf_16, decode_coding_emacs_mule)
7728 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7729 (decode_coding_ccl, decode_coding_charset)
7730 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7731 (decode_coding_iso_2022, decode_coding_emacs_mule)
7732 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7733 <char_offset, last_offset>: Declare EMACS_INT.
7734 (encode_coding_utf_8, encode_coding_utf_16)
7735 (encode_coding_emacs_mule, encode_invocation_designation)
7736 (encode_designation_at_bol, encode_coding_iso_2022)
7737 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7738 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7739 Declare EMACS_INT.
7740 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7741 (encode_invocation_designation): Last argument P_NCHARS is now
7742 EMACS_INT.
7743 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7744 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7745
7746 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7747 All users changed.
7748
7749 * ccl.c (Fccl_execute_on_string): Declare some variables
7750 EMACS_INT.
7751
8546720e 77522011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7753
7754 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7755
4e19a977
CS
77562011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7757
7758 * process.c (Fformat_network_address): Doc fix.
7759
87302331
R
77602011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7761
ee7683eb 7762 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7763
cbb59342
CY
77642011-04-08 Chong Yidong <cyd@stupidchicken.com>
7765
7766 * keyboard.c (read_char): Call Lisp function help-form-show,
7767 instead of using internal_with_output_to_temp_buffer.
7768 (Qhelp_form_show): New var.
e0d38eeb 7769 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7770
7771 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7772
7773 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7774
e67a13ab
CY
77752011-04-06 Chong Yidong <cyd@stupidchicken.com>
7776
04f2d78b
CB
7777 * process.c (Flist_processes): Remove to Lisp.
7778 (list_processes_1): Delete.
e67a13ab 7779
973f782d
EZ
77802011-04-06 Eli Zaretskii <eliz@gnu.org>
7781
7c106b1e
EZ
7782 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7783
973f782d
EZ
7784 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7785
41cf7d1a 77862011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7787
ca23cc88
PE
7788 Fix more problems found by GCC 4.6.0's static checks.
7789
f390e2d5
PE
7790 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7791
42eea0d0
PE
7792 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7793
b69769da 7794 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7795
f9541e84
PE
7796 * xdisp.c (vmessage): Mark as a printf-like function.
7797
13841b55
PE
7798 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7799
c136c10f
PE
7800 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7801
5e2d4a30
PE
7802 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7803 printf-like functions.
7804 (tiff_load): Add casts to remove these marks before passing them
7805 to system-supplied API.
7806
583f48b9
PE
7807 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7808
b25d760e
PE
7809 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7810 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7811 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7812 directly, rather than having caller test rule sign. This avoids
7813 some unnecessary tests.
7814 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7815 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7816 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7817
bc7b6697 7818 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7819 (xfont_open): Avoid unnecessary tests.
bc7b6697 7820
27ccc379
PE
7821 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7822
dcd5c89a
PE
7823 * composite.h, composite.c (composition_gstring_put_cache):
7824 Use EMACS_INT, not int, for length.
7825
b13a45c6
PE
7826 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7827 breaking out part of COMPOSITION_DECODE_RULE.
7828 (COMPOSITION_DECODE_RULE): Use it.
7829 * composite.c (get_composition_id): Remove unused local vars,
7830 by using the new macro.
7831
1e792e4d
PE
7832 * textprop.c (set_text_properties_1): Change while to do-while,
7833 since the condition is always true at first.
7834
dc6c6455 7835 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7836 (interval_deletion_adjustment): Return unsigned value.
7837 All uses changed.
dc6c6455 7838
aba7731a
PE
7839 * process.c (list_processes_1, create_pty, read_process_output):
7840 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7841 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7842 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7843 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7844 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7845
fdfc4bf3
PE
7846 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7847
fca8fe46 7848 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7849 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7850
06a0259a 7851 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7852 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7853 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7854
e7b9e80f
PE
7855 * print.c (print_error_message): Avoid int overflow.
7856
56201685
PE
7857 * font.c (font_list_entities): Redo for clarity,
7858 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7859
78834453 7860 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7861 (font_score): Avoid potential overflow in diff calculation.
78834453 7862
0bc0b309 7863 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7864 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7865
e610eaca
PE
7866 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7867
b895abce
PE
7868 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7869 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7870 can always succeed if overflow has undefined behavior.
7871
1f1d9321 7872 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7873 (wordify): Omit three unnecessary tests.
1f1d9321 7874
c59478bc
PE
7875 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7876 All callers changed. This avoids the need for an unused var.
7877
79b73827
PE
7878 * casefiddle.c (casify_region): Remove var that is set but not used.
7879
a4db5dfe
PE
7880 * dired.c (file_name_completion): Remove var that is set but not used.
7881
43aae36e
PE
7882 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7883
2a47c44d 7884 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7885 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7886
a37c69bf
PE
7887 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7888 Check for integer overflow on size calculations.
7889
328ab8e7
PE
7890 * buffer.c (Fprevious_overlay_change): Remove var that is set
7891 but not used.
7892
e5a2a5cb
PE
7893 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7894 Remove vars that are set but not used.
8d84a6eb 7895 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7896 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7897
a60e5f68
PE
7898 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7899
f661cb61 7900 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7901 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7902
f0397f5a
PE
7903 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7904 that are set but not used.
7905
8664db06 7906 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7907 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7908
6abdaa4a
PE
7909 * xselect.c (x_get_local_selection, x_handle_property_notify):
7910 Remove vars that are set but not used.
7911
0ce7538d 7912 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7913 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7914
9ae848fc
PE
7915 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7916 Remove var that is set but not used.
0b918413
PE
7917 (scroll_bar_windows_size): Now size_t, not int.
7918 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7919 Check for overflow.
9ae848fc 7920
a5a62657
PE
7921 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7922 (map_tty_color) [!defined MSDOS]: Likewise.
7923
5c5cdd39
PE
7924 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7925
66ebf983
PE
7926 * coding.c: Remove vars that are set but not used.
7927 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7928 All callers changed.
7929 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7930 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7931 (decode_coding_charset): Remove vars that are set but not used.
7932
1be4d761
PE
7933 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7934 that is set but not used.
7935
47553fa8
PE
7936 * print.c (print_object): Remove var that is set but not used.
7937
1f7196bf 7938 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7939 The gnulib version avoids calling malloc in the usual case,
7940 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7941 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7942 * filelock.c (current_lock_owner): Likewise.
7943 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7944 * sysdep.c: Include allocator.h, careadlinkat.h.
7945 (emacs_no_realloc_allocator): New static constant.
7946 (emacs_readlink): New function.
fdb61804
PE
7947 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7948 ../lib/careadlinkat.h.
d1fdcab7 7949
f84c17c7
SM
79502011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7951
7952 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7953 first non-nil return value).
7954
ef3862ad
JD
79552011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7956
7957 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7958 if not defined (Bug#8403).
7959
376a7006
JB
79602011-04-02 Juanma Barranquero <lekktu@gmail.com>
7961
7962 * xdisp.c (display_count_lines): Remove parameter `start',
7963 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7964 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7965 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7966 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7967 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7968 and thereabouts. All callers changed.
7969 (get_per_char_metric): Remove parameter `f', unused since
7970 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7971
6ca3801d
JM
79722011-04-02 Jim Meyering <meyering@redhat.com>
7973
7974 do not dereference NULL upon failed strdup
7975 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7976 (ns_get_family): Likewise.
7977
d8e2b5ba
JB
79782011-04-02 Juanma Barranquero <lekktu@gmail.com>
7979
7980 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7981
8c74fcbd
JD
79822011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7983
7984 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7985 later (Bug#8403).
7986
7200d79c
SM
79872011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7988
03408648 7989 Add lexical binding.
7200d79c 7990
03408648
SM
7991 * window.c (Ftemp_output_buffer_show): New fun.
7992 (Fsave_window_excursion):
7993 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7994
7995 * lread.c (lisp_file_lexically_bound_p): New function.
7996 (Fload): Bind Qlexical_binding.
7997 (readevalloop): Remove `evalfun' arg.
7998 Bind Qinternal_interpreter_environment.
7999 (Feval_buffer): Bind Qlexical_binding.
8000 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8001 Mark as dynamic.
8002 (syms_of_lread): Declare `lexical-binding'.
8003
8004 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8005
8006 * keyboard.c (eval_dyn): New fun.
8007 (menu_item_eval_property): Use it.
ca105506
SM
8008
8009 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8010
03408648
SM
8011 * fns.c (concat, mapcar1): Accept byte-code-functions.
8012
8013 * eval.c (Fsetq): Handle lexical vars.
8014 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8015 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8016 (FletX, Flet): Obey lexical binding.
8017 (Fcommandp): Handle closures.
8018 (Feval): New `lexical' arg.
8019 (eval_sub): New function extracted from Feval. Use it almost
8020 everywhere where Feval was used. Look up vars in lexical env.
8021 Handle closures.
8022 (Ffunctionp): Move from subr.el.
8023 (Ffuncall): Handle closures.
8024 (apply_lambda): Remove `eval_flags'.
8025 (funcall_lambda): Handle closures and new byte-code-functions.
8026 (Fspecial_variable_p): New function.
8027 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8028 but without exporting it to Lisp.
23aba0ea 8029
23aba0ea 8030 * doc.c (Fdocumentation, store_function_docstring):
03408648 8031 * data.c (Finteractive_form): Handle closures.
23aba0ea 8032
03408648
SM
8033 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8034 interactive spec.
ba83908c 8035
04f2d78b
CB
8036 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8037 New byte-codes.
03408648
SM
8038 (exec_byte_code): New function extracted from Fbyte_code to handle new
8039 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8040
03408648 8041 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8042
03408648 8043 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8044
e2abce01
JB
80452011-03-31 Juanma Barranquero <lekktu@gmail.com>
8046
8047 * xdisp.c (redisplay_internal): Fix prototype.
8048
63696a73 80492011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8050
63696a73 8051 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8052 (try_scrolling): Use it when setting scroll_limit.
8053 Limit scrolling to 100 screen lines.
63696a73
EZ
8054 (redisplay_window): Even when falling back on "recentering",
8055 position point in the window according to scroll-conservatively,
8056 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8057
8058 (try_scrolling): When point is above the window, allow searching
8059 as far as scroll_max, or one screenful, to compute vertical
8060 distance from PT to the scroll margin position. This prevents
8061 try_scrolling from unnecessarily failing when
8062 scroll-conservatively is set to a value slightly larger than the
8063 window height. Clean up the case of PT below the margin at bottom
8064 of window: scroll_max can no longer be INT_MAX. When aggressive
8065 scrolling is in use, don't let point enter the opposite scroll
8066 margin as result of the scroll.
8067 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8068 threshold of 100 lines for never-recentering scrolling.
8069
e4cc2dfc
JB
80702011-03-31 Juanma Barranquero <lekktu@gmail.com>
8071
8072 * dispextern.h (move_it_by_lines):
8073 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8074 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8075 (message_log_check_duplicate): Remove parameters `prev_bol' and
8076 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8077 (redisplay_internal): Remove parameter `preserve_echo_area',
8078 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8079
8080 * indent.c (Fvertical_motion):
8081 * window.c (window_scroll_pixel_based, Frecenter):
8082 Don't pass `need_y_p' to `move_it_by_lines'.
8083
1c470562
SM
80842011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8085
44f230aa
SM
8086 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8087 steal a few bits to be more compact.
8088 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8089 Remove unneeded casts.
8090
1c470562
SM
8091 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8092
888adce9
ZK
80932011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8094
8095 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8096 binding" message (bug#7967).
8097
f838ed7b
PE
80982011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8099
77861b95
PE
8100 Fix more problems found by GCC 4.6.0's static checks.
8101
de6dbc14
PE
8102 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8103 Remove unused local var.
8104
f838ed7b
PE
8105 * editfns.c (Fmessage_box): Remove unused local var.
8106
792c7b2b
PE
8107 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8108 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8109 Omit unused local vars.
c499e557 8110 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8111 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8112 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8113 Omit unused local var.
8114
ba0165e1
PE
8115 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8116 Don't assume string length fits in int.
32ad8845 8117 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8118 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8119
3c59b4c9
PE
8120 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8121 instead of alloca (Bug#8344).
8122
a3eed478 8123 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8124 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8125
eb4d412d
PE
8126 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8127
1658b401
PE
8128 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8129 concerns.
8130
8131 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8132
8133 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8134
9a2c6e05
PE
8135 * keyboard.c (syms_of_keyboard): Use the same style as later
8136 in this function when indexing through an array. This also
8137 works around GCC bug 48267.
8138
03d0a109
PE
8139 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8140
44f730c8
PE
8141 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8142
fe75f926
PE
8143 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8144 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8145
ffa8c828
PE
8146 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8147 This avoids undefined behavior on integer overflow, and is a bit
8148 more convenient anyway since it is compared to a size_t variable.
8149
c5101a77
PE
8150 Variadic C functions now count arguments with size_t, not int.
8151 This avoids an unnecessary limitation on 64-bit machines, which
8152 caused (substring ...) to crash on large vectors (Bug#8344).
8153 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8154 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8155 All variadic functions and their callers changed accordingly.
c5101a77
PE
8156 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8157 * data.c (arith_driver, float_arith_driver): Likewise.
8158 * editfns.c (general_insert_function): Likewise.
8159 * eval.c (struct backtrace.nargs, interactive_p)
8160 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8161 (funcall_lambda, mark_backtrace): Likewise.
8162 * fns.c (concat): Likewise.
8163 * frame.c (x_set_frame_parameters): Likewise.
8164 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8165 0 if not found, not -1. All callers changed.
8166
dd3f25f7
PE
8167 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8168 (stack_copy_size): Now size_t, not int.
8169 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8170
461c2ab9
JB
81712011-03-28 Juanma Barranquero <lekktu@gmail.com>
8172
8173 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8174 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8175 All callers changed.
8176
8177 * lisp.h (multibyte_char_to_unibyte):
8178 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8179 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8180 * character.h (CHAR_TO_BYTE8):
8181 * cmds.c (internal_self_insert):
8182 * editfns.c (general_insert_function):
8183 * keymap.c (push_key_description):
8184 * search.c (Freplace_match):
8185 * xdisp.c (message_dolog, set_message_1): All callers changed.
8186
f6d62986
SM
81872011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8188
8189 * keyboard.c (safe_run_hook_funcall): New function.
8190 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8191 don't set the hook to nil, but remove the offending function instead.
8192 (Qcommand_hook_internal): Remove, unused.
8193 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8194 Vcommand_hook_internal.
8195
8196 * eval.c (enum run_hooks_condition): Remove.
8197 (funcall_nil, funcall_not): New functions.
8198 (run_hook_with_args): Call each function through a `funcall' argument.
8199 Remove `cond' argument, now redundant.
8200 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8201 (Frun_hook_with_args_until_failure): Adjust accordingly.
8202 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8203
1db5b1ad
JB
82042011-03-28 Juanma Barranquero <lekktu@gmail.com>
8205
8206 * dispextern.h (string_buffer_position): Remove declaration.
8207
8208 * print.c (strout): Remove parameter `multibyte', unused since
8209 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8210
8211 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8212 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8213 All callers changed.
8214
8215 * w32.c (_wsa_errlist): Use braces for struct initializers.
8216
8217 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8218 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8219 All callers changed.
8220 (string_buffer_position): Likewise. Also, make static (it's never
8221 used outside xdisp.c).
8222 (cursor_row_p): Remove parameter `w', unused since
8223 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8224 (decode_mode_spec): Remove parameter `precision', introduced during
8225 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8226 All callers changed.
8227
5ffb62aa
JD
82282011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8229
8230 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8231
461c2ab9 82322011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8233
8234 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8235 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8236 (ns_update_auto_hide_menu_bar): New functions.
8237 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8238 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8239 ns_constrain_all_frames.
8240 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8241 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8242
5c380ffb
JD
82432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8244
8245 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8246
9af30bdf
GM
82472011-03-27 Glenn Morris <rgm@gnu.org>
8248
8249 * syssignal.h: Replace RETSIGTYPE with void.
8250 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8251 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8252 Replace SIGTYPE with void everywhere.
8253 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8254 * s/template.h (SIGTYPE): Remove commented out definition.
8255
e2abce01
JB
82562011-03-26 Eli Zaretskii <eliz@gnu.org>
8257
8258 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8259 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8260
f868cd8a
JB
82612011-03-26 Juanma Barranquero <lekktu@gmail.com>
8262
59eb0929
JB
8263 * w32.c (read_unc_volume): Use parameter `henum', instead of
8264 global variable `wget_enum_handle'.
8265
8266 * keymap.c (describe_vector): Remove parameters `indices' and
8267 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8268 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8269
f868cd8a
JB
8270 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8271
8272 * keyboard.c (timer_check): Remove parameter `do_it_now',
8273 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8274 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8275 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8276
8277 * keyboard.c (read_char):
8278 * w32menu.c (w32_menu_display_help):
8279 * xmenu.c (show_help_event, menu_help_callback):
8280 Adjust calls to `show_help_echo'.
8281
8282 * gtkutil.c (xg_maybe_add_timer):
8283 * keyboard.c (readable_events):
8284 * process.c (wait_reading_process_output):
8285 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8286
8287 * insdel.c (adjust_markers_gap_motion):
8288 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8289 (gap_left, gap_right): Don't call it.
8290
2ecf6fdb
CY
82912011-03-25 Chong Yidong <cyd@stupidchicken.com>
8292
8293 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8294 incurred during fontification.
8295
6b1f9ba4
JB
82962011-03-25 Juanma Barranquero <lekktu@gmail.com>
8297
8298 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8299 (DEFVAR_PER_BUFFER): Don't pass it.
8300
8301 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8302 (scrolling_window): Don't pass it.
8303
0f4a96b5
JB
83042011-03-25 Juanma Barranquero <lekktu@gmail.com>
8305
8306 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8307
8308 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8309 and `suffix'.
8310 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8311 of variables specific to SELinux and computation of `encoded_absname'.
8312
8313 * image.c (XPutPixel): Remove unused variable `height'.
8314
8315 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8316
8317 * unexw32.c (get_section_info): Remove unused variable `section'.
8318
8319 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8320 (system_process_attributes): Remove unused variable `sess'.
8321 (sys_read): Remove unused variable `err'.
8322
8323 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8324 (w32_wnd_proc): Remove unused variable `isdead'.
8325 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8326 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8327 (x_create_tip_frame): Remove unused variable `tem'.
8328
8329 * w32inevt.c (w32_console_read_socket):
8330 Remove unused variable `no_events'.
8331
8332 * w32term.c (x_draw_composite_glyph_string_foreground):
8333 Remove unused variable `width'.
8334
1149507c
JB
83352011-03-24 Juanma Barranquero <lekktu@gmail.com>
8336
8337 * w32term.c (x_set_glyph_string_clipping):
8338 Don't pass uninitialized region to CombineRgn.
8339
9c88f339
JB
83402011-03-23 Juanma Barranquero <lekktu@gmail.com>
8341
8342 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8343 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8344 (Fx_close_connection): Remove unused variable `i'.
8345
8346 * w32font.c (w32font_draw): Return number of glyphs.
8347 (w32font_open_internal): Remove unused variable `i'.
8348 (w32font_driver): Add missing initializer.
8349
8350 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8351 (fill_in_menu): Remove unused variable `items_added'.
8352
8353 * w32term.c (last_mouse_press_frame): Remove static global variable.
8354 (w32_clip_to_row): Remove unused variable `f'.
8355 (x_delete_terminal): Remove unused variable `i'.
8356
8357 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8358 (NOTHING): Remove unused static global variable.
8359 (uniscribe_check_otf): Remove unused variable `table'.
8360 (uniscribe_font_driver): Add missing initializers.
8361
dee091a3
JD
83622011-03-23 Julien Danjou <julien@danjou.info>
8363
8364 * term.c (Fsuspend_tty, Fresume_tty):
8365 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8366 * window.c (temp_output_buffer_show):
8367 * insdel.c (signal_before_change):
8368 * frame.c (Fhandle_switch_frame):
8369 * fileio.c (Fdo_auto_save):
8370 * emacs.c (Fkill_emacs):
8371 * editfns.c (save_excursion_restore):
8372 * cmds.c (internal_self_insert):
8373 * callint.c (Fcall_interactively):
8374 * buffer.c (Fkill_all_local_variables):
8375 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8376 Use Frun_hooks.
0f4a96b5 8377 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8378 unconditionally since it does the check itself.
dee091a3 8379
2c520ab5 83802011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8381
c9c49752
PE
8382 Fix more problems found by GCC 4.5.2's static checks.
8383
8abc3f12
PE
8384 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8385 the first time through the loop, since we know p0 < p1 then.
8386 This also avoids a gcc -Wstrict-overflow warning.
8387
a2d26660
PE
8388 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8389 leading to a memory leak, possible in functions like
8390 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8391 of objects (Bug#8318).
a2d26660 8392
916c72e9
PE
8393 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8394 that could (at least in theory) be that large.
8395
19ab8a18
PE
8396 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8397 This is less likely to overflow, and avoids undefined behavior if
8398 overflow does occur. All callers changed. Use strtoul to scan
8399 for the unsigned long integer.
b7cbbd6f
PE
8400 (pint2hrstr): Simplify and tune code slightly.
8401 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8402
f0641eff
PE
8403 * scroll.c (do_scrolling): Work around GCC bug 48228.
8404 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8405
7f650bb9
PE
8406 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8407 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8408 (validate_x_resource_name): Simplify count usage.
8409 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8410
37dd57d1
PE
8411 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8412 fail (Bug#8306).
81e56e61 8413
699979fc 8414 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8415
401bf9b4
PE
8416 * process.c (Fmake_network_process): Use socklen_t, not int,
8417 where POSIX says socklen_t is required in portable programs.
8418 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8419 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8420 (Fmake_network_process, server_accept_connection):
8421 (wait_reading_process_output, read_process_output):
8422 Likewise.
8423
b93aacde
PE
8424 * process.c: Rename or move locals to avoid shadowing.
8425 (list_processes_1, Fmake_network_process):
8426 (read_process_output_error_handler, exec_sentinel_error_handler):
8427 Rename or move locals.
4dc343ee 8428 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8429 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8430 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8431 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8432 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8433
af8a867c 8434 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8435 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8436 Include tparam.h instead, since it declares them.
af8a867c
PE
8437 * cm.h (PC): Remove extern decl; tparam.h now does this.
8438 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8439 * terminfo.c: Include tparam.h, to check interfaces.
8440 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8441 (tparam): Adjust signature to match interface in tparam.h;
8442 this removes some undefined behavior. Check that outstring and len
8443 are zero, which they always are with Emacs.
8444 * tparam.h (PC, BC, UP): New extern decls.
8445
0248044d 8446 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8447 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8448
8ff096c1 8449 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8450 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8451 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8452 (ftfont_list): Remove unused local.
49eaafba
PE
8453 (get_adstyle_property, ftfont_pattern_entity):
8454 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8455 Rename locals to avoid shadowing.
8ff096c1 8456
e2be39f6
PE
8457 * xfont.c (xfont_list_family): Mark var as initialized.
8458
c9735e30
PE
8459 * xml.c (make_dom): Now static.
8460
8f5201ae
PE
8461 * composite.c (composition_compute_stop_pos): Rename local to
8462 avoid shadowing.
b246f932
PE
8463 (composition_reseat_it): Remove unused locals.
8464 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8465 (composition_update_it): Mark var as initialized.
11b61122
PE
8466 (find_automatic_composition): Mark vars as initialized,
8467 with a FIXME (Bug#8290).
8f5201ae 8468
760fbc2c
PE
8469 character.h: Rename locals to avoid shadowing.
8470 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8471 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8472 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8473 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8474 to avoid shadowing.
8475
ff08eb85
PE
8476 * textprop.c (property_change_between_p): Remove; unused.
8477
fc7bf025
PE
8478 * intervals.c (interval_start_pos): Now static.
8479
235d7abc
PE
8480 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8481
44f230aa
SM
8482 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8483 Rename locals to avoid shadowing.
3e7d6594 8484
50060332
PE
8485 * sound.c (wav_play, au_play, Fplay_sound_internal):
8486 Fix pointer signedness.
d01f234b 8487 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8488 (wav_play): Initialize a variable to 0, to prevent undefined
8489 behavior (Bug#8278).
50060332 8490
c4fc4e30
PE
8491 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8492
918436ed
PE
8493 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8494
c939f91b
PE
8495 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8496 clobbering (Bug#8298).
b9c7f648
PE
8497 * sysdep.c (sys_subshell): Likewise.
8498 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8499
6bd8c144
PE
8500 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8501 This should get cleaned up, so that child_setup has the
8502 same signature on all platforms.
8503
7710357c 8504 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8505 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8506
c59da222
CY
85072011-03-22 Chong Yidong <cyd@stupidchicken.com>
8508
8509 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8510 not to be necessary, and produces flickering.
8511
66b87493
GM
85122011-03-20 Glenn Morris <rgm@gnu.org>
8513
8514 * config.in: Remove file.
8515
45b6f6d5
JB
85162011-03-20 Juanma Barranquero <lekktu@gmail.com>
8517
8518 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8519 are now in src/globals.h.
8520 (syms_of_minibuf): Remove spurious & from previous change.
8521
cd394be1 85222011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8523
8524 * minibuf.c (completing-read-function): New variable.
8525 (completing-read-default): Rename from completing-read.
8526 (completing-read): Call completing-read-function.
8527
b14e3e21
CY
85282011-03-19 Juanma Barranquero <lekktu@gmail.com>
8529
8530 * xfaces.c (Fx_load_color_file):
8531 Read color file from absolute filename (bug#8250).
8532
f2b726e6
JB
85332011-03-19 Juanma Barranquero <lekktu@gmail.com>
8534
8535 * makefile.w32-in: Update dependencies.
8536
09f6ff02
EZ
85372011-03-17 Eli Zaretskii <eliz@gnu.org>
8538
8539 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8540
29a6015a
PE
85412011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8542
a3a6c54e
PE
8543 Fix more problems found by GCC 4.5.2's static checks.
8544
b766f867
PE
8545 * process.c (make_serial_process_unwind, send_process_trap):
8546 (sigchld_handler): Now static.
8547
be02381c
PE
8548 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8549 That way, the code declares only the vars that it needs.
8550 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8551 * s/cygwin.h (PTY_ITERATION): Likewise.
8552 * s/darwin.h (PTY_ITERATION): Likewise.
8553 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8554
57048744
PE
8555 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8556 * process.c (allocate_pty): Don't declare stb unless it's needed.
8557
7914961c 8558 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8559 (CONSTANTLIM): Remove; unused.
8560 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8561 Define only if needed.
7914961c 8562
b3967b18
PE
8563 * unexelf.c (unexec): Name an expression,
8564 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8565 Use a different way to cause a compilation error if anyone uses
8566 n rather than nn, a way that does not involve shadowing.
73366a00 8567 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8568
29a6015a
PE
8569 * deps.mk (unexalpha.o): Remove; unused.
8570
43cfc33e 8571 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8572 * unexec.h: New file.
ce701a33
PE
8573 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8574 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8575 Depend on unexec.h.
8576 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8577 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8578 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8579 Change as necessary to match prototype in unexec.h.
ce701a33 8580
01f44d5a
PE
8581 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8582 shadowing.
4f63c6bb 8583 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8584
a6670b0b
PE
8585 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8586 Rename locals to avoid shadowing.
8587
cef2010d 8588 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8589 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8590
d4d7173a
PE
8591 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8592
f08b802a
PE
8593 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8594 warning when compiling print.c.
8595
3ddb0639
PE
8596 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8597 instead of using an uninitialized var.
5ad03b97 8598 (font_sort_entities): Mark var as initialized.
3ddb0639 8599
170a2692
PE
8600 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8601
e663c700
PE
8602 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8603 pointers to constants.
89bc529a 8604 (font_parse_fcname): Remove unused vars.
7b81e2d0 8605 (font_delete_unmatched): Now static.
ea838e10 8606 (font_get_spec): Remove; unused.
13a547c6
PE
8607 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8608 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8609 Rename or move locals to avoid shadowing.
e663c700 8610
2a80c887 8611 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8612 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8613
1384fa33 8614 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8615 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8616
8b2c52e9
PE
8617 * alloc.c (mark_backtrace): Move decl from here ...
8618 * lisp.h: ... to here, so that it can be checked.
8619
475545b5 8620 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8621 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8622 (lisp_indirect_variable): Name an expression,
8623 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8624 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8625
b1349114 8626 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8627 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8628 Use const pointer when appropriate.
b1349114 8629
a2928364
PE
8630 * lisp.h (get_system_name, get_operating_system_release):
8631 Move decls here, to check interfaces.
8632 * process.c (get_operating_system_release): Move decl to lisp.h.
8633 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8634 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8635 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8636 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8637 (Fformat_time_string, Fencode_time, Finsert_char):
8638 (Ftranslate_region_internal, Fformat):
8639 Rename or remove local vars to avoid shadowing.
9710023e 8640 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8641
a415e694
PE
8642 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8643 avoid shadowing.
8644
8ef4622d
PE
8645 * lisp.h (eassert): Check that the argument compiles, even if
8646 ENABLE_CHECKING is not defined.
8647
946f9a5b
PE
8648 * data.c (Findirect_variable): Name an expression, to avoid
8649 gcc -Wbad-function-cast warning.
112396d6 8650 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8651 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8652 (Fmake_variable_buffer_local, Fmake_local_variable):
8653 Mark variables as initialized.
52746918 8654 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8655
e5aab7e7 8656 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8657 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8658 Rename locals to avoid shadowing.
dff45157
PE
8659 (mark_stack): Move local variables into the #ifdef region where
8660 they're used.
7bc26fdb
PE
8661 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8662 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8663 needed otherwise.
8664 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8665 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8666 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8667
e5aab7e7
PE
8668 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8669 avoids undefined behavior in theory.
8670
4da60324
PE
8671 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8672
88043301
PE
8673 Use functions, not macros, for up- and down-casing (Bug#8254).
8674 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8675 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8676 to use the following functions instead of these macros.
8677 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8678 EMACS_INT, since callers assume the returned value fits in int.
8679 (upcase1): Likewise, for UPCASE_TABLE.
8680 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8681 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8682 the race-condition problem in the old DOWNCASE.
88043301 8683
19ed5445
PE
8684 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8685 Rename locals to avoid shadowing.
8686 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8687 (regex_compile, re_search_2, re_match_2_internal):
8688 Remove unused local vars.
952db0d7
PE
8689 (FREE_VAR): Rewrite so as not to use empty "else",
8690 which gcc can warn about.
da053e48 8691 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8692 (RETALLOC_IF): Define only if needed.
8693 (WORDCHAR_P): Likewise. This one is never needed, but is used
8694 only in a comment talking about a compiler bug, so put inside
8695 the #if 0 of that comment.
8696 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8697 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8698 Remove; unused.
19ed5445 8699
1f3561e4 8700 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8701 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8702 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8703
ded6f8f7
PE
8704 * search.c (simple_search): Remove unused var.
8705
dbd37a95
PE
8706 * dired.c (compile_pattern): Move decl from here ...
8707 * lisp.h: ... to here, so that it can be checked.
8708 (struct re_registers): New forward decl.
8709
7e47afad
PE
8710 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8711
85f24f61
PE
8712 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8713 All uses changed.
8714 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8715 Rename locals to avoid shadowing.
5671df8f 8716 (Fvertical_motion): Mark locals as initialized.
85f24f61 8717
181aa2be 8718 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8719 (casify_region): Mark local as initialized.
181aa2be 8720
930d429c
PE
8721 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8722
7082eac6
PE
8723 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8724 New macros, so that the caller can use some names other than
8725 gcpro1, gcpro2, etc.
8726 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8727 of the new macros.
8728 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8729 argument, for consistency with GCPRO2_VAR, etc: it is now the
8730 prefix of the variable, not the variable itself. All uses
8731 changed.
38b2c076
PE
8732 * dired.c (directory_files_internal, file_name_completion):
8733 Rename locals to avoid shadowing.
8734
15206ed9
PE
8735 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8736 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8737 dired.c's scmp function, had undefined behavior.
8738 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8739 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8740 * buffer.h: ... to here, because these macros use current_buffer,
8741 and the new implementation with inline functions needs to have
8742 current_buffer in scope now, rather than later when the macros
8743 are used.
8744 (downcase, upcase1): New static inline functions.
8745 (DOWNCASE, UPCASE1): Reimplement using these functions.
8746 This avoids undefined behavior in expressions like
8747 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8748 from race conditions in accessing the global variables
8749 case_temp1 and case_temp2.
8750 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8751 * lisp.h (case_temp1, case_temp2): Remove their decls.
8752 * character.h (ASCII_CHAR_P): Move from here ...
8753 * lisp.h: ... to here, so that the inline functions mentioned
8754 above can use them.
8755
4a6bea26
PE
8756 * dired.c (directory_files_internal_unwind): Now static.
8757
f14b7e14
PE
8758 * fileio.c (file_name_as_directory, directory_file_name):
8759 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8760 Now static.
2893f146
PE
8761 (file_name_as_directory): Use const pointers when appropriate.
8762 (Fexpand_file_name): Likewise. In particular, newdir might
8763 point at constant storage, so make it a const pointer.
fd4ead52 8764 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8765 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8766 signedness issues.
f839df0c
PE
8767 (Fset_file_times, Finsert_file_contents, auto_save_error):
8768 Rename locals to avoid shadowing.
f14b7e14 8769
5716756e 8770 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8771 (Ftry_completion, Fall_completions): Rename or remove locals
8772 to avoid shadowing.
5716756e 8773
b4c3046a
PE
8774 * marker.c (bytepos_to_charpos): Remove; unused.
8775
b45db522
PE
8776 * lisp.h (verify_bytepos, count_markers): New decls,
8777 so that gcc does not warn that these functions aren't declared.
8778
85876d07
PE
8779 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8780 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8781 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8782 (copy_text): Remove unused local var.
85876d07 8783
03d78a21 8784 * filelock.c (within_one_second): Now static.
b3dd38ab 8785 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8786
5df8f01b
PE
8787 * buffer.c (fix_overlays_before): Mark locals as initialized.
8788 (fix_start_end_in_overlays): Likewise. This function should be
8789 simplified by using pointers-to-pointers, but that's a different
8790 matter.
b1d876f1 8791 (switch_to_buffer_1): Now static.
8f54f30a
PE
8792 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8793 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8794
a70072c9 8795 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8796 Fix pointer signedness issue.
edced198
PE
8797 (sys_subshell): Mark local as volatile if checking for lint,
8798 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8799 (MAXPATHLEN): Define only if needed.
a70072c9 8800
a0977c44
PE
8801 * process.c (serial_open, serial_configure): Move decls from here ...
8802 * systty.h: ... to here, so that they can be checked.
8803
a884fdcc
PE
8804 * fns.c (get_random, seed_random): Move extern decls from here ...
8805 * lisp.h: ... to here, so that they can be checked.
8806
604efe86 8807 * sysdep.c (reset_io): Now static.
b8950c94 8808 (wait_for_termination_signal): Remove; unused.
604efe86 8809
38fc62d9
PE
8810 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8811 (copy_keymap_item, append_key, push_text_char_description):
8812 Now static.
1004a21a 8813 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8814 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8815 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8816 (describe_map_tree):
8817 Rename locals to avoid shadowing.
38fc62d9 8818
2f2650da
PE
8819 * keyboard.c: Declare functions static if they are not used elsewhere.
8820 (echo_char, echo_dash, cmd_error, top_level_2):
8821 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8822 (read_char, kbd_buffer_get_event, make_lispy_position):
8823 (make_lispy_event, make_lispy_movement, apply_modifiers):
8824 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8825 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8826 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8827 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8828 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8829
a053e86c 8830 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8831 (mark_kboards): Move decl here ...
8832 * alloc.c (mark_kboards): ... from here.
a053e86c 8833
4752793e
PE
8834 * lisp.h (force_auto_save_soon): New decl.
8835
74f10ca7 8836 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8837 (DEFINE_DUMMY_FUNCTION): New macro.
8838 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8839 Use it.
c03cd23f
PE
8840 (main): Add casts to avoid warnings
8841 if GCC considers string literals to be constants.
74f10ca7 8842
022e70d4
PE
8843 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8844
59d6fe83
PE
8845 * dbusbind.c: Pointer signedness fixes.
8846 (xd_signature, xd_append_arg, xd_initialize):
8847 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8848 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8849 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8850 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8851
78320123
PE
8852 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8853 if GCC considers string literals to be constants.
49cebcca 8854 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8855
35ac2a97
SM
88562011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8857
fb103ca9
SM
8858 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8859 (print_preprocess, print_object): New macro to fix last change.
8860
35ac2a97
SM
8861 * print.c (print_preprocess): Don't forget font objects.
8862
62973b41
JB
88632011-03-16 Juanma Barranquero <lekktu@gmail.com>
8864
8865 * emacs.c (USAGE3): Doc fixes.
8866
0e48bb22
AS
88672011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8868
8869 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8870 structure.
8871
7684e57b
JB
88722011-03-14 Juanma Barranquero <lekktu@gmail.com>
8873
8874 * lisp.h (VWindow_system, Qfile_name_history):
8875 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8876 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8877 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8878
8879 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8880 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8881
8882 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8883 * w32console.c (detect_input_pending, read_input_pending)
8884 (encode_terminal_code):
8885 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8886 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8887 (w32_system_caret_y, Qfile_name_history):
8888 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8889 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8890 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8891 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8892 * w32proc.c (Qlocal, report_file_error):
8893 * w32term.c (Vwindow_system, updating_frame):
8894 * w32uniscribe.c (initialized, uniscribe_font_driver):
8895 Remove unneeded extern declarations.
8896
2aa46d6c
CY
88972011-03-14 Chong Yidong <cyd@stupidchicken.com>
8898
c96bbc66 8899 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8900
cffc6f3b
CY
89012011-03-13 Chong Yidong <cyd@stupidchicken.com>
8902
8903 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8904 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8905 These macros can no longer be used for assignment.
8906
44f230aa
SM
8907 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8908 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8909 (record_buffer_markers, fetch_buffer_markers): New functions for
8910 recording and fetching special buffer markers.
8911 (set_buffer_internal_1, set_buffer_temp): Use them.
8912
8913 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8914
8915 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8916
8917 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8918 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8919
8920 * xdisp.c (hscroll_window_tree):
8921 (reconsider_clip_changes): Use PT instead of BUF_PT.
8922
d251f04b
EZ
89232011-03-13 Eli Zaretskii <eliz@gnu.org>
8924
8925 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8926 $(EMACS_ROOT)/lib/intprops.h.
8927
f0c77cd1
PE
89282011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8929
3eca4629
PE
8930 Fix more problems found by GCC 4.5.2's static checks.
8931
7c86ee98
PE
8932 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8933 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8934 (xg_free_frame_widgets): Make it clear that a local variable is
8935 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8936 (gdk_window_get_screen): Make it clear that this macro is needed
8937 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8938 (int_gtk_range_get_value): New function, which avoids a diagnostic
8939 from gcc -Wbad-function-cast.
8940 (xg_set_toolkit_scroll_bar_thumb): Use it.
8941 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8942 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8943 (get_utf8_string, xg_get_file_with_chooser):
8944 Rename locals to avoid shadowing.
8945 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8946
41729b81
PE
8947 * xgselect.c (xg_select): Remove unused var.
8948
f0c77cd1
PE
8949 * image.c (four_corners_best): Mark locals as initialized.
8950 (gif_load): Initialize transparent_p to zero (Bug#8238).
8951 Mark another local as initialized.
ec6cf4c6 8952 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8953
ce0ad53d 8954 * image.c (clear_image_cache): Now static.
d5d5a617 8955 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8956 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8957 (x_edge_detection): Remove unnecessary cast that
8958 gcc -Wbad-function-cast diagnoses.
2037898d 8959 (gif_load): Fix pointer signedness.
6ae141d6
PE
8960 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8961 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8962
33383987 89632011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8964
d32df629
PE
8965 Improve quality of tests for time stamp overflow.
8966 For example, without this patch (encode-time 0 0 0 1 1
8967 1152921504606846976) returns the obviously-bogus value (-948597
8968 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8969 reports time overflow. See
8970 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8971 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8972 * editfns.c: Include limits.h and intprops.h.
8973 (TIME_T_MIN, TIME_T_MAX): New macros.
8974 (time_overflow): Move earlier, to before first use.
8975 (hi_time, lo_time): New functions, for an accurate test for
8976 out-of-range times.
8977 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8978 (Fget_internal_run_time): Don't assume time_t fits in int.
8979 (make_time): Use list2 instead of Fcons twice.
8980 (Fdecode_time): More accurate test for out-of-range times.
8981 (check_tm_member): New function.
8982 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8983 (lisp_time_argument): Don't rely on undefined left-shift and
8984 right-shift behavior when checking for time stamp overflow.
8be6f318 8985
fe31d94c
PE
8986 * editfns.c (time_overflow): New function, refactoring common code.
8987 (Fformat_time_string, Fdecode_time, Fencode_time):
8988 (Fcurrent_time_string): Use it.
8989
8be6f318
PE
8990 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8991 * dired.c (make_time): Move to ...
8992 * editfns.c (make_time): ... here.
8993 * systime.h: Note the move.
8994
09d9db2c 89952011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8996
126bc0dc
YM
8997 * fringe.c (update_window_fringes): Remove unused variables.
8998
c47cbdfd
YM
8999 * unexmacosx.c (copy_data_segment): Also copy __got section.
9000 (Bug#8223)
9001
7ac80be9
EZ
90022011-03-12 Eli Zaretskii <eliz@gnu.org>
9003
c96bbc66 9004 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9005 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9006 Constify `char *' arguments and their references according to
9007 prototypes in tparam.h.
9008
ecb0f94d 9009 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9010
7ac80be9
EZ
9011 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9012 Adapt all references accordingly.
9013
9014 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9015
ef1fd07e
TT
90162011-03-11 Tom Tromey <tromey@redhat.com>
9017
9018 * buffer.c (syms_of_buffer): Remove obsolete comment.
9019
7ef4b50c
EZ
90202011-03-11 Eli Zaretskii <eliz@gnu.org>
9021
9022 * termhooks.h (encode_terminal_code): Declare prototype.
9023
9024 * msdos.c (encode_terminal_code): Don't declare prototype.
9025
9026 * term.c (encode_terminal_code): Now external again, used by
9027 w32console.c and msdos.c.
9028
44f230aa
SM
9029 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9030 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9031
4b1ec863 90322011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9033
1714f52b 9034 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9035
4b1ec863
PE
9036 * fringe.c (update_window_fringes): Mark locals as initialized
9037 (Bug#8227).
9038 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9039
524c7aa6
PE
9040 * alloc.c (mark_fringe_data): Move decl from here ...
9041 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9042 to check its interface.
9043 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9044
a5c0af81 9045 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9046 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9047 (fontset_font): Mark local as initialized.
a9a06e0b 9048 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9049
b4716021
PE
9050 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9051
811e9bac 9052 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9053 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9054 (x_own_selection, Fx_disown_selection_internal): Rename locals
9055 to avoid shadowing.
9056 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9057
7e3ab302
PE
9058 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9059 so that the caller can use some name other than gcpro1.
9060 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9061 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9062 (Fx_backspace_delete_keys_p):
9063 Use them to avoid shadowing, and rename vars to avoid shadowing.
9064 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9065 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9066 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9067 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9068 Remove unused locals.
7e3ab302
PE
9069 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9070 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9071 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9072 macros.
f78faa98 9073
e2b13473
PE
9074 * xterm.h (x_mouse_leave): New decl.
9075
77f23912
PE
9076 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9077 Remove unused functions.
cdf4ba58
PE
9078 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9079 (x_calc_absolute_position): Now static.
7411c686 9080 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9081 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9082 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9083 unless they are used.
38d0b34a
PE
9084 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9085 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9086 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9087 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9088 (x_error_catcher, x_connection_closed, x_error_handler):
9089 (x_error_quitter, xembed_send_message, x_iconify_frame):
9090 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9091 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9092 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9093
44f230aa
SM
9094 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9095 Rename or move locals to avoid shadowing.
6b463e58 9096 (tty_defined_color, merge_face_heights): Now static.
5967d051 9097 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9098 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9099 does not deduce is never used uninitialized.
73719eba
PE
9100 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9101 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9102
426994c3 9103 * terminal.c (store_terminal_param): Now static.
5489860b 9104
032f1620 9105 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9106 (set_frame_menubar): Remove unused local.
d4323972 9107 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9108 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9109 since they might point to immutable storage.
281585b0
PE
9110 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9111 since it's unused otherwise.
032f1620 9112
367c19e5 9113 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9114 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9115 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9116 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9117 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9118 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9119 does not deduce are never used uninitialized.
70739cbe 9120
07b48fa9
PE
9121 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9122
8868a238 9123 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9124 * window.c (window_loop, size_window):
9125 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9126
7e5cf297 9127 * window.c (display_buffer): Now static.
d6550a9f
PE
9128 (size_window): Mark variables that gcc -Wuninitialized
9129 does not deduce are never used uninitialized.
a586633d
PE
9130 * window.h (check_all_windows): New decl, to forestall
9131 gcc -Wmissing-prototypes diagnostic.
5b555da1 9132 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9133
f6095868
PE
9134 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9135 shadowing.
9136 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9137 Include <limits.h>.
9138 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9139 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9140 (load_charset_map): Mark variables that gcc -Wuninitialized
9141 does not deduce are never used uninitialized.
53df7c11 9142 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9143
f38b440c
PE
9144 * coding.c (coding_set_source, coding_set_destination):
9145 Use "else { /* comment */ }" rather than "else /* comment */;"
9146 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9147 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9148 a block, when the outer 'i' will do.
9149 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9150 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9151 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9152 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9153 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9154 Rename locals to avoid shadowing.
9155 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9156 * coding.c (emacs_mule_char, encode_invocation_designation):
9157 Now static, since they're not used elsewhere.
413bb2db 9158 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9159 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9160 (decode_coding_emacs_mule): Mark variables that gcc
9161 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9162 (detect_coding_iso_2022): Initialize a local variable that might
9163 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9164 this initialization is needed. (Bug#8211)
5f58e762
PE
9165 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9166 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9167 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9168 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9169 Remove unused macros.
f38b440c 9170
232b38b9 9171 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9172 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9173 * character.c (string_count_byte8): Likewise.
232b38b9 9174
fb90da1b
PE
9175 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9176 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9177
fb93dbc2
PE
9178 * chartab.c (copy_sub_char_table): Now static, since it's not used
9179 elsewhere.
5c156ace
PE
9180 (sub_char_table_ref_and_range, char_table_ref_and_range):
9181 Rename locals to avoid shadowing.
bbcd0949 9182 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9183
7d3b3862 9184 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9185 (BIDI_BOB): Remove unused macro.
7d3b3862 9186
6be7d3da
PE
9187 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9188 deduce are never used uninitialized.
c2ed9c8b 9189 * term.c (encode_terminal_code): Likewise.
6be7d3da 9190
75f8807f 9191 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9192
50938595
PE
9193 * tparam.h: New file.
9194 * term.c, tparam.h: Include it.
9195 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9196 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9197 Move these decls to tparam.h, and make them agree with what
9198 is actually in tparam.c. The previous trick of using incompatible
9199 decls in different modules does not conform to the C standard.
9200 All callers of tparam changed to use tparam's actual API.
9201 * tparam.c (tparam1, tparam, tgoto):
9202 Use const pointers where appropriate.
9203
fbceeba2
PE
9204 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9205 * cm.h (struct cm): Likewise.
9206 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9207 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9208 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9209 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9210 (turn_on_face, init_tty): Likewise.
9211 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9212
7f3f1250
PE
9213 * term.c (term_mouse_position): Rename local to avoid shadowing.
9214
e6ca6543
PE
9215 * alloc.c (mark_ttys): Move decl from here ...
9216 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9217
c40f8d15
AS
92182011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9219
9220 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9221
cfe0661d
JB
92222011-03-09 Juanma Barranquero <lekktu@gmail.com>
9223
9224 * search.c (compile_pattern_1): Remove argument regp, unused since
9225 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9226 (compile_pattern): Don't pass it.
9227
0afb4571
J
92282011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9229
9230 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9231 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9232 for ! HAVE_GTK3.
9233 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9234
9235 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9236
9237 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9238 gdk_window_get_screen, gdk_window_get_geometry,
9239 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9240 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9241 (xg_get_pixbuf_from_pixmap): New function.
9242 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9243 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9244 Call xg_get_pixbuf_from_pixmap instead of
9245 gdk_pixbuf_get_from_drawable.
9246 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9247 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9248 (xg_check_special_colors): Use GtkStyleContext and its functions
9249 for HAVE_GTK3.
9250 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9251 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9252 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9253 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9254 Call gtk_widget_get_preferred_size.
0afb4571
J
9255 (xg_frame_resized): gdk_window_get_geometry only takes 5
9256 parameters.
44f230aa
SM
9257 (xg_win_to_widget, xg_event_is_for_menubar):
9258 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9259 (xg_set_widget_bg): New function.
9260 (delete_cb): New function.
895009e1 9261 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9262 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9263 (xg_set_background_color): Call xg_set_widget_bg.
9264 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9265 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9266 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9267 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9268 if ! HAVE_GTK3.
9269 (update_frame_tool_bar): Call gtk_widget_hide.
9270 (xg_initialize): Use GDK_KEY_g.
9271
9272 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9273 if ! HAVE_GTK3
9274 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9275
9276 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9277 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9278 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9279
1c2cc4ef
JB
92802011-03-08 Juanma Barranquero <lekktu@gmail.com>
9281
9282 * w32xfns.c (select_palette): Check success of RealizePalette against
9283 GDI_ERROR, not zero.
9284
33383987 9285See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9286
9287;; Local Variables:
9288;; coding: utf-8
aac0c6e3
MR
9289;; End:
9290
acaf905b 9291 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9292
9293 This file is part of GNU Emacs.
9294
9295 GNU Emacs is free software: you can redistribute it and/or modify
9296 it under the terms of the GNU General Public License as published by
9297 the Free Software Foundation, either version 3 of the License, or
9298 (at your option) any later version.
9299
9300 GNU Emacs is distributed in the hope that it will be useful,
9301 but WITHOUT ANY WARRANTY; without even the implied warranty of
9302 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9303 GNU General Public License for more details.
9304
9305 You should have received a copy of the GNU General Public License
9306 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.