* src/xterm.c (x_term_init): Use memcpy instead of strncpy.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3f83ace8
JM
12012-05-02 Jim Meyering <jim@meyering.net>
2
3 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4
90207a15 52012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
6
7 * xdisp.c (pos_visible_p): If already at a newline from the
8 display string before the 'while' loop, don't walk back the glyphs
9 from it3.glyph_row. Solves assertion violation when the display
10 string begins with a newline (egg.el). (Bug#11367)
11
b593d6a9
AH
122012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
13
14 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
15 Move to simple.el.
16
4737362e
GM
172012-05-01 Glenn Morris <rgm@gnu.org>
18
99cf43f9
GM
19 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
20 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
21 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
22 All were removed before 23.1.
23
9311dcff
GM
24 * dispnew.c: Remove HAVE_LIBNCURSES test;
25 it is always true on relevant platforms.
26
4d5c6349
GM
27 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
28 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
29
4737362e
GM
30 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
31
74dd3a6b
AS
322012-04-30 Andreas Schwab <schwab@linux-m68k.org>
33
34 * .gdbinit (xpr): Remove checks for no longer existing misc types.
35 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
36 Remove.
37
13c379ee
PE
382012-04-28 Paul Eggert <eggert@cs.ucla.edu>
39
40 Do not avoid creating empty evaporating overlays (Bug#9642).
41 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
42 That is, do not delete an evaporating overlay if it becomes
43 empty after its bounds are adjusted to fit within its buffer.
44 This fix caused other problems, and I'm reverting it until we get
45 to the bottom of them.
46
a8e7d6d7 472012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
48
49 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
50
a8e7d6d7 512012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
52
53 * xdisp.c (pos_visible_p): If the window start position is beyond
54 ZV, start the display from buffer beginning. Prevents assertion
55 violation in init_iterator when the minibuffer window is scrolled
56 via the scroll bar.
57
58 * window.c (window_scroll_pixel_based): Likewise.
59
a8e7d6d7 602012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
61
62 * keymap.c (where_is_internal): Doc fix (Bug#10872).
63
a8e7d6d7 642012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
65
66 * fileio.c (Fcopy_file, Fset_file_selinux_context):
67 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
68
a8e7d6d7 692012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 70
b593d6a9
AH
71 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
72 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 73
1c6900d9
EZ
742012-04-26 Eli Zaretskii <eliz@gnu.org>
75
4c3fa1d9
EZ
76 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
77 display element, check also the underlying string or buffer
78 character. (Bug#11341)
79
1c6900d9
EZ
80 * w32menu.c: Include w32heap.h.
81 (add_menu_item): If the call to AppendMenuW (via
82 unicode_append_menu) fails, disable Unicode menus only if we are
83 running on Windows 9X/Me.
84
42bf8205
AS
852012-04-24 Andreas Schwab <schwab@linux-m68k.org>
86
87 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
88 (xgetint): Add missing shift for LSB tags.
89
b1bac16e
MR
902012-04-24 Martin Rudalics <rudalics@gmx.at>
91
92 * keyboard.c (read_char): Don't wipe echo area for select window
93 events: These might get delayed via `mouse-autoselect-window'
94 (Bug#11304).
95
d69621cc
JB
962012-04-24 Juanma Barranquero <lekktu@gmail.com>
97
98 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
99 manipulation of :loaded-from data.
100
02fd101b
JB
1012012-04-23 Juanma Barranquero <lekktu@gmail.com>
102
103 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
104 now a cons (bug#11311).
105
888bec30
PE
1062012-04-23 Paul Eggert <eggert@cs.ucla.edu>
107
89a438bd
PE
108 Do not create empty overlays with the evaporate property (Bug#9642).
109 * buffer.c (Fmove_overlay): Delete an evaporating overlay
110 if it becomes empty after its bounds are adjusted to fit within
111 its buffer. Without this fix, in a nonempty buffer (let ((o
112 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
113 yields an empty overlay that has the evaporate property, which is
114 not supposed to happen.
115
1068fe4d
PE
116 Fix minor GTK3 problems found by static checking.
117 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
118 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
119 (struct _EmacsFixedClass, emacs_fixed_get_type):
120 Move decls here from emacsgtkfixed.h, since they needn't be public.
121 (emacs_fixed_get_type): Now static.
122 (emacs_fixed_class_init): Omit unused local.
123 (emacs_fixed_child_type): Remove; unused.
124 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
125 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
126 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
127 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
128 (EMACS_FIXED_GET_CLASS): Remove; unused.
129 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
130
888bec30
PE
131 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
132 Problem reported by Juanma Barranquero for Windows -Wunused-function.
133
de85e130
PE
1342012-04-22 Paul Eggert <eggert@cs.ucla.edu>
135
d0baac98
PE
136 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
137 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
138 (__malloc_size_t, __malloc_ptrdiff_t):
139 Remove. All uses removed, replaced by the definiens if needed,
140 since we can assume C89 or better now.
141 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
142 (protect_malloc_state, align, get_contiguous_space)
143 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
144 (malloc_atfork_handler_child, malloc_enable_thread)
145 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
146 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
147 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
148 (special_realloc, _realloc_internal_nolock, _realloc_internal)
149 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
150 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
151 Define using prototypes, not old style.
152 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
153 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
154 (align): Don't assume that signed integer overflow wraps around.
155 Omit unused local var.
156 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
157 (_free_internal_nolock, memalign, mallochook, reallochook):
158 Omit no-longer-needed casts.
159 (valloc): Use getpagesize, not __getpagesize.
160 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
161 (struct hdr): The 'magic' member is now size_t, not unsigned long.
162
de85e130
PE
163 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
164
dcbf5805
MA
1652012-04-22 Michael Albinus <michael.albinus@gmx.de>
166
167 Move functions from C to Lisp. Make non-blocking method calls
168 the default. Implement further D-Bus standard interfaces.
169
170 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
171 (QCdbus_request_name_allow_replacement)
172 (QCdbus_request_name_replace_existing)
173 (QCdbus_request_name_do_not_queue)
174 (QCdbus_request_name_reply_primary_owner)
175 (QCdbus_request_name_reply_in_queue)
176 (QCdbus_request_name_reply_exists)
177 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
178 (QCdbus_registered_serial, QCdbus_registered_method)
179 (QCdbus_registered_signal): New Lisp objects.
180 (XD_DEBUG_MESSAGE): Use sizeof.
181 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
182 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
183 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
184 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
185 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
186 (xd_signature, xd_append_arg): Allow float for integer types.
187 (xd_get_connection_references): New function.
b593d6a9
AH
188 (xd_get_connection_address): Rename from xd_initialize.
189 Return cached address.
dcbf5805
MA
190 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
191 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
192 level.
193 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
194 Return number of recounts.
195 (Fdbus_get_unique_name): Make stronger parameter check.
196 (Fdbus_message_internal): New defun.
197 (Fdbus_call_method, Fdbus_call_method_asynchronously)
198 (Fdbus_method_return_internal, Fdbus_method_error_internal)
199 (Fdbus_send_signal, Fdbus_register_service)
200 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
201 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
202 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
203 (Vdbus_compiled_version, Vdbus_runtime_version)
204 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
205 (Vdbus_message_type_method_return, Vdbus_message_type_error)
206 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
207 (Vdbus_registered_buses, Vdbus_registered_objects_table):
208 Adapt docstring.
dcbf5805 209
52828e02
PE
2102012-04-22 Paul Eggert <eggert@cs.ucla.edu>
211
da05bc4c
PE
212 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
213 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
214 Do not assume ptrdiff_t is the same width as 'int'.
215
52828e02
PE
216 * alloc.c: Handle unusual debugging option combinations.
217 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
218 since the two debugging options are incompatible.
219 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
220 is defined.
221 (mem_init, mem_insert, mem_insert_fixup):
222 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
223 (NEED_MEM_INSERT): Remove; no longer needed.
224
f01769f9
LL
2252012-04-22 Leo Liu <sdl.web@gmail.com>
226
227 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
228
5790543d
PE
2292012-04-22 Paul Eggert <eggert@cs.ucla.edu>
230
231 * sysdep.c [__FreeBSD__]: Minor cleanups.
232 (list_system_processes, system_process_attributes) [__FreeBSD__]:
233 Use Emacs indenting style more consistently. Avoid some casts.
234 Use 'double' consistently rather than mixing 'float' and 'double'.
235
b91b7e4d
EW
2362012-04-21 Eduard Wiebe <usenet@pusto.de>
237
b593d6a9
AH
238 * sysdep.c (list_system_processes, system_process_attributes):
239 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 240
6114eb15
AS
2412012-04-21 Andreas Schwab <schwab@linux-m68k.org>
242
243 * lisp.mk (lisp): Update.
244
2f38dff7
PE
2452012-04-20 Paul Eggert <eggert@cs.ucla.edu>
246
247 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
248 It is never used otherwise.
249
4ae29f89
SM
2502012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
251
252 * print.c (print_preprocess): Only check print_depth if print-circle
253 is nil.
254 (print_object): Check for cycles even when print-circle is nil and
255 print-gensym is t, but only check print_depth if print-circle is nil.
256
f30d612a
CY
2572012-04-20 Chong Yidong <cyd@gnu.org>
258
259 * process.c (wait_reading_process_output): If EIO occurs on a pty,
260 set the status to "failed" and ensure that sentinel is run.
261
c07a4c0b 2622012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
263
264 * process.c (Fset_process_inherit_coding_system_flag)
265 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 266 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 267
c07a4c0b 2682012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
269
270 * xdisp.c (string_buffer_position_lim): Limit starting position to
271 BEGV.
272 (set_cursor_from_row): If called for a mode-line or header-line
273 row, return zero immediately.
274 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
275 farther than the first row after the header line, if any.
276 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
277 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
278
c07a4c0b 2792012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 280
4ae29f89
SM
281 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
282 (bug#11238).
ad3a2b41 283
c07a4c0b 2842012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 2852012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
286
287 configure: new option --enable-gcc-warnings (Bug#11207)
288 * Makefile.in (C_WARNINGS_SWITCH): Remove.
289 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
290 (ALL_CFLAGS): Use new macros rather than old.
291 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
292 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
293 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
294 -Wunused-result, -Wunused-variable. This should go away once
295 the Emacs and Gnulib regex code is merged.
296 (xmalloc, xrealloc): Now static.
297
aba027e8
PE
2982012-04-17 Paul Eggert <eggert@cs.ucla.edu>
299
300 * dired.c (Fsystem_groups): Remove unused local.
301
e5a36063
GM
3022012-04-17 Glenn Morris <rgm@gnu.org>
303
304 * dired.c (Fsystem_users): Doc fix.
305
316411f0
DA
3062012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
307
308 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
309 (syms_of_dired): Add them.
310
9426aba4
PE
3112012-04-16 Paul Eggert <eggert@cs.ucla.edu>
312
b62a57be
PE
313 Fix minor alloc.c problems found by static checking.
314 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
315 New extern decls, to avoid calling undeclared functions.
316 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
317 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
318 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
319 (NEED_MEM_INSERT): New macro.
320 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 321 Remove one incorrect comment and fix another.
b62a57be 322
3539f31f
PE
323 Fix minor ralloc.c problems found by static checking.
324 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
325 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
326 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
327 (r_alloc_sbrk): Now static.
328
a041960a
PE
329 Improve ralloc.c interface checking.
330 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
331 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
332 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
333 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
334 [REL_ALLOC]: ... to here, to check interface.
335 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
336 Remove decls. This fixes an "It stinks!".
337
9426aba4
PE
338 * alloc.c (which_symbols): Fix alignment issue / type clash.
339
d55c12ed
AS
3402012-04-15 Andreas Schwab <schwab@linux-m68k.org>
341
342 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
343 (struct Lisp_Misc_Any): Likewise.
344 (struct Lisp_Free): Likewise.
345 * alloc.c (union aligned_Lisp_Symbol): Define.
346 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
347 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
348 (union aligned_Lisp_Misc): Define.
349 (MARKER_BLOCK_SIZE, struct marker_block): Use union
350 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 351 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 352
b948ce8b
PE
3532012-04-14 Paul Eggert <eggert@cs.ucla.edu>
354
355 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
356 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
357 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
358 * s/netbsd.h, s/sol2-6.h:
359 Remove definition of GC_MARK_STACK, since the default now works.
360 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
361 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
362 no longer the default.
363 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
364
35dc09a1 3652012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 366
35dc09a1
GM
367 * lread.c (lisp_file_lexically_bound_p):
368 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 369
35dc09a1
GM
3702012-04-14 Eli Zaretskii <eliz@gnu.org>
371
372 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
373 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
374
3752012-04-14 Jan Djärv <jan.h.d@swipnet.se>
376
377 * nsterm.m (constrainFrameRect): Always constrain when there is only
378 one screen (Bug#10962).
379
bcd86815
KB
3802012-04-13 Ken Brown <kbrown@cornell.edu>
381
382 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
383
c25df26e
RT
3842012-04-13 Reuben Thomas <rrt@sc3d.org>
385
386 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
387
0fc59f1e
DC
3882012-04-11 Daniel Colascione <dancol@dancol.org>
389
390 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
391 against is gone. It's better to use vfork now so that when Cygwin
392 gains a new, working vfork, we use it automatically (bug#10398).
393
de8c03dc
SM
3942012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
395
396 * window.c (save_window_save): Obey window-point-insertion-type.
397
2f097256
GM
3982012-04-11 Glenn Morris <rgm@gnu.org>
399
400 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
401
453b951e
SM
4022012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
403
404 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
405
75f1671a 4062012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
407
408 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
409 (force_quit_count): New var.
410 (handle_interrupt): Use it.
411
2a8ce227
JB
4122012-04-10 Juanma Barranquero <lekktu@gmail.com>
413
414 * w32.c (w32_delayed_load): Record the full path of the library
415 being loaded (bug#10424).
416
935396c0
GM
4172012-04-09 Glenn Morris <rgm@gnu.org>
418
05920a43
GM
419 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
420 not just in the obarray, before snarfing them. (Bug#11036)
421
935396c0
GM
422 * Makefile.in ($(leimdir)/leim-list.el):
423 Pass EMACS rather than BUILT_EMACS.
424
a18ecafa
TZ
4252012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
426
427 * process.c (make_process):
428 * process.h: Add integer `gnutls_handshakes_tried' member to
429 process struct.
430
6bbef4e5
JC
431 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
432 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
433
434 * gnutls.c (gnutls_log_function2i): Convenience log function.
435 (emacs_gnutls_read): Use new log functions,
436 `gnutls_handshakes_tried' process member, and
437 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
438 attempts per process (connection).
439
b4d3bc10
CY
4402012-04-09 Chong Yidong <cyd@gnu.org>
441
442 * eval.c (Fuser_variable_p, user_variable_p_eh)
443 (lisp_indirect_variable): Functions deleted.
444 (Fdefvar): Caller changed.
445
446 * callint.c (Finteractive, Fcall_interactively):
447 * minibuf.c (Fread_variable): Callers changed.
448
70f4d973
EZ
4492012-04-09 Eli Zaretskii <eliz@gnu.org>
450
451 * xdisp.c (set_cursor_from_row): If the display string appears in
452 the buffer at position that is closer to point than the position
453 after the display string, display the cursor on the first glyph of
454 the display string. Fixes cursor display when a 'display' text
455 property immediately follows invisible text. (Bug#11094)
456
cb3c2e3e
PE
4572012-04-09 Paul Eggert <eggert@cs.ucla.edu>
458
459 composite.c: use 'double' consistently
460 * composite.c (get_composition_id): Use 'double' consistently
461 instead of converting 'float' to 'double' and vice versa; this is
462 easier to understand and avoids a GCC warning.
463
fd06db5d
GM
4642012-04-09 Glenn Morris <rgm@gnu.org>
465
50fe702a
GM
466 * Makefile.in: Generate leim-list with bootstrap-emacs, in
467 preparation for dumping it with emacs. (Bug#4789)
468 (leimdir): New variable.
469 ($(leimdir)/leim-list.el): New rule.
470 (emacs$(EXEEXT)): Depend on leim-list.el.
471
fd06db5d
GM
472 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
473 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
474 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
475
55c131ee
AS
4762012-04-08 Andreas Schwab <schwab@linux-m68k.org>
477
478 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
479 proper alignment.
480
9209588f
JB
4812012-04-07 Juanma Barranquero <lekktu@gmail.com>
482
483 * xml.c (init_libxml2_functions) [WINDOWSNT]:
484 Remove unused local variable.
485
e3fb2efb
PE
4862012-04-07 Paul Eggert <eggert@cs.ucla.edu>
487
488 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
489 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
490 (mark_memory): Mark Lisp_Objects only if pointers might hide in
491 objects, as mark_maybe_pointer will catch them otherwise.
492 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
493 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
494
b5385551
PE
4952012-04-07 Paul Eggert <eggert@cs.ucla.edu>
496
497 Fix typo that broke non-Windows builds.
498 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
499
9078ead6
EZ
5002012-04-07 Eli Zaretskii <eliz@gnu.org>
501
502 Support building on MS-Windows with libxml2.
503
504 * makefile.w32-in (OBJ2): Add xml.$(O).
505 (GLOBAL_SOURCES): Add xml.c.
506 ($(BLD)/xml.$(O)): New dependency list.
507
508 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
509 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
510 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
511 [!WINDOWSNT]: New macros.
512 (init_libxml2_functions, libxml2_loaded_p): New functions.
513 (parse_region): Call fn_xmlCheckVersion instead of using the macro
514 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
515 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
516 Calls xmlCleanupParser only if libxml2 was loaded (or statically
517 linked in).
6bbef4e5
JC
518 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
519 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
520 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
521
522 * emacs.c: Don't include libxml/parser.h.
523 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
524 xmlCleanupParser directly.
525
526 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
527
3811fdf3
EZ
5282012-04-07 Eli Zaretskii <eliz@gnu.org>
529
530 * indent.c (Fvertical_motion): If there is a display string at
531 point, use it.vpos to compute how many lines to backtrack after
532 move_it_to point. (Bug#11133)
533
2f8e16b2
EZ
5342012-04-06 Eli Zaretskii <eliz@gnu.org>
535
536 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
537 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
538 about subtle differences between FETCH_CHAR* and STRING_CHAR*
539 macros related to unification of CJK characters. For the details,
540 see the discussion following the message here:
541 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
542
3d439cd1
CY
5432012-04-04 Chong Yidong <cyd@gnu.org>
544
545 * keyboard.c (Vdelayed_warnings_list): Doc fix.
546
8bc53d00
EZ
5472012-04-01 Eli Zaretskii <eliz@gnu.org>
548
549 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
550 instead of alloca. (Bug#11138)
551
3b0512a3
AS
5522012-04-01 Andreas Schwab <schwab@linux-m68k.org>
553
554 * w32menu.c (is_simple_dialog): Properly check lisp types.
555 (Bug#11141)
556
8427ddd2
EZ
5572012-03-31 Eli Zaretskii <eliz@gnu.org>
558
979022ef
EZ
559 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
560 position we get to after a call to move_it_to fails the
561 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
562 only if we wind up in a string from display property. (Bug#11063)
563
a6b1c7cc
EZ
564 * window.c (Fdelete_other_windows_internal): Invalidate the row
565 and column information about mouse highlight, so that redisplay
566 restores it after reallocating the glyph matrices. (Bug#7464)
567
8427ddd2
EZ
568 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
569 string comes from a `display' text property, use the buffer
570 position of that property as if we actually saw that position in
571 the row's glyphs.
697ba24b
EZ
572 (move_it_by_lines): Remove the assertion that
573 "it->current_x == 0 && it->hpos == 0" which can be legitimately
574 violated when there's a before-string at the beginning of a line.
575 (Bug#11063)
8427ddd2 576
65a0a738
EZ
5772012-03-30 Eli Zaretskii <eliz@gnu.org>
578
579 * xdisp.c (append_space_for_newline): If the default face was
580 remapped, use the remapped face for the appended newline.
581 (extend_face_to_end_of_line): Use the remapped default face for
582 extending the face to the end of the line.
583 (display_line): Call extend_face_to_end_of_line when the default
584 face was remapped. (Bug#11068)
585
581355cc
EZ
5862012-03-29 Eli Zaretskii <eliz@gnu.org>
587
588 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
589
e8fc049f
SM
5902012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
591
592 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
593
4fb9a543
GM
5942012-03-27 Glenn Morris <rgm@gnu.org>
595
596 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
597 Doc fixes.
598
679910f1
KH
5992012-03-26 Kenichi Handa <handa@m17n.org>
600
601 * dispextern.h (struct glyph): Fix previous change. Change the
602 bit length of glyphless.ch to 25 (Bug#11082).
603
90d49b7f
CY
6042012-03-26 Chong Yidong <cyd@gnu.org>
605
606 * keyboard.c (Vselection_inhibit_update_commands): New variable.
607 (command_loop_1): Use it; inhibit selection update for
608 handle-select-window too (Bug#8996).
609
f514f6f0
FP
6102012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
611
e8fc049f 612 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 613
bf43fa51
KH
6142012-03-25 Kenichi Handa <handa@m17n.org>
615
616 * dispextern.h (struct glyph): Change the bit length of
617 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
618
8a0c01dd
EZ
6192012-03-24 Eli Zaretskii <eliz@gnu.org>
620
621 * s/ms-w32.h (tzname): Include time.h before redirecting to
622 _tzname. Fixes the MSVC build. (Bug#9960)
623
7d1c3a76
AS
6242012-03-24 Andreas Schwab <schwab@linux-m68k.org>
625
8ed79523
AS
626 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
627 characters.
628
7d1c3a76
AS
629 * xterm.c (XTread_socket): Only modify handling_signal if
630 !SYNC_INPUT. (Bug#11080)
631
e99a9b8b
EZ
6322012-03-23 Eli Zaretskii <eliz@gnu.org>
633
634 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
635 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
636 when fetching a multibyte character consumes more bytes than
637 CHAR_BYTES returns, due to unification of CJK characters in
638 string_char. (Bug#11073)
639
5063c0e1
TN
6402012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
641
642 * process.c (wait_reading_process_output): Handle pty disconnect
643 by refraining from sending oneself a SIGCHLD (bug#10933).
644
9f851fbd
CY
6452012-03-22 Chong Yidong <cyd@gnu.org>
646
647 * dispextern.h (struct it): New member string_from_prefix_prop_p.
648
5063c0e1 649 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
650 Mark string as coming from a prefix property.
651 (handle_face_prop): Use default face for prefix strings (Bug#4281).
652 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
653
fb5b8aca
CY
6542012-03-21 Chong Yidong <cyd@gnu.org>
655
656 * xfaces.c (Vface_remapping_alist): Doc fix.
657
62356a1b
EZ
6582012-03-20 Eli Zaretskii <eliz@gnu.org>
659
660 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
661 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
662 Doc fixes.
62356a1b 663
025de85b
CY
6642012-03-20 Chong Yidong <cyd@gnu.org>
665
666 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
667 to reflect default non-nil value of redisplay-dont-pause.
668
4827f94e
KH
6692012-03-19 Kenichi Handa <handa@m17n.org>
670
671 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
672 it fit in a valid range (Bug#11003).
673
e50a24a2
EZ
6742012-03-18 Eli Zaretskii <eliz@gnu.org>
675
676 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
677 that is not from display property, accept the row as a "cursor
678 row" if one of the string's character has a non-nil `cursor'
679 property. Fixes cursor positioning when there are newlines in
680 overlay strings, e.g. in icomplete.el. (Bug#11035)
681
9af5ed87
PE
6822012-03-12 Paul Eggert <eggert@cs.ucla.edu>
683
684 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
685
d1f55f16
CY
6862012-03-12 Chong Yidong <cyd@gnu.org>
687
688 * eval.c (inhibit_lisp_code): Rename from
689 inhibit_window_configuration_change_hook; move from window.c.
690
691 * xfns.c (unwind_create_frame_1, Fx_create_frame):
692 * window.c (run_window_configuration_change_hook)
693 (syms_of_window): Callers changed.
694
66c5eebd
CY
6952012-03-11 Chong Yidong <cyd@gnu.org>
696
413df973
CY
697 * keymap.c (Fkey_description): Doc fix (Bug#9700).
698
66c5eebd
CY
699 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
700
1de11f56
CY
7012012-03-10 Chong Yidong <cyd@gnu.org>
702
703 * frame.c (other_visible_frames): Don't assume the selected frame
704 is visible (Bug#10955).
705
cae07000
SM
7062012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
707
708 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
709
89c94350
JD
7102012-03-08 Jan Djärv <jan.h.d@swipnet.se>
711
712 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
713 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
714 zero (Bug#10954).
715
999dd333
GM
7162012-03-03 Glenn Morris <rgm@gnu.org>
717
01a6dcc8 718 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 719
de0100f2
EZ
7202012-03-02 Eli Zaretskii <eliz@gnu.org>
721
722 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
723 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
724 (redisplay_window, next_element_from_string): Fix typos in
725 comments.
3e441275
EZ
726 (redisplay_window): Pass to move_it_vertically the margin in
727 pixels, not in screen lines.
de0100f2 728
96a72ee9
GM
7292012-03-02 Glenn Morris <rgm@gnu.org>
730
731 * buffer.c (buffer-list-update-hook): Doc fix.
732
312508d7
EZ
7332012-02-29 Eli Zaretskii <eliz@gnu.org>
734
735 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
736 push_it before setting up the iterator for the first overlay
737 string, even if we have an empty string loaded.
738 (next_overlay_string): If there's an empty string on the iterator
739 stack, pop the stack. (Bug#10903)
740
27f3c637
PE
7412012-02-25 Paul Eggert <eggert@cs.ucla.edu>
742
743 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
744 Suggested by Stefan Monnier in
745 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
746 * alloc.c (widen_to_Lisp_Object): New static function.
747 (mark_memory): Also mark Lisp_Objects by fetching pointer words
748 and widening them to Lisp_Objects. This would work even if
749 USE_LSB_TAG is defined and wide integers are used, which might
750 happen in a future version of Emacs.
751
3c9dfce6
CY
7522012-02-25 Chong Yidong <cyd@gnu.org>
753
fa74b241
CY
754 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
755 Doc fix.
756
3c9dfce6
CY
757 * xselect.c (Fx_selection_exists_p): Doc fix.
758 (x_clipboard_manager_save_all): Print an informative message
759 before saving to clipboard manager.
760
9486df08
CY
7612012-02-24 Chong Yidong <cyd@gnu.org>
762
763 * keyboard.c (process_special_events): Handle all X selection
764 requests in kbd_buffer, not just the next one (Bug#8869).
765
f01d3321
CY
7662012-02-23 Chong Yidong <cyd@gnu.org>
767
768 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
769 call when setting menu-bar-lines and tool-bar-lines parameters.
770 (unwind_create_frame_1): New helper function.
771
772 * window.c (inhibit_window_configuration_change_hook): New var.
773 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 774 (syms_of_window): Initialize it.
f01d3321 775
86b847b6
CY
7762012-02-22 Chong Yidong <cyd@gnu.org>
777
778 * xterm.c (x_draw_image_relief): Add missing type check for
779 Vtool_bar_button_margin (Bug#10743).
780
a59225b1
CY
7812012-02-21 Chong Yidong <cyd@gnu.org>
782
783 * fileio.c (Vfile_name_handler_alist): Doc fix.
784
785 * buffer.c (Fget_file_buffer): Protect against invalid file
786 handler return value.
787
310f5bd4
PE
7882012-02-20 Paul Eggert <eggert@cs.ucla.edu>
789
cb3a28cc
PE
790 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
791 when computing $valmask.
792
310f5bd4
PE
793 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
794 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
795 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
796 It's useless in that case, and it can cause problems on hosts
797 that allocate halves of EMACS_INT values separately.
798 Reported by Dan Horák. Diagnosed by Andreas Schwab in
799 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
800 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
801 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
802 it avoids undefined behavior on hosts where shifting right by more
803 than the word width has undefined behavior.
804
2375c96a
CY
8052012-02-19 Chong Yidong <cyd@gnu.org>
806
807 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
808 (Funhandled_file_name_directory, Ffile_name_as_directory)
809 (Fdirectory_file_name, Fexpand_file_name)
810 (Fsubstitute_in_file_name): Protect against invalid file handler
811 return values (Bug#10845).
812
3eb49e71
EZ
8132012-02-18 Eli Zaretskii <eliz@gnu.org>
814
815 * .gdbinit (pitx): Fix incorrect references to fields of the
816 iterator stack.
817
7b926f3f
CY
8182012-02-17 Chong Yidong <cyd@gnu.org>
819
820 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
821
11273115
PE
8222012-02-15 Paul Eggert <eggert@cs.ucla.edu>
823
824 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
825 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
826
c3a70e2b
CY
8272012-02-15 Chong Yidong <cyd@gnu.org>
828
829 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
830 marked as special. Also, starting docstrings with * is obsolete.
831
0ca43699
AS
8322012-02-13 Andreas Schwab <schwab@linux-m68k.org>
833
834 * gnutls.c (emacs_gnutls_write): Fix last change.
835
2e8f3c56
LI
8362012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
837
838 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
839 send_process.
840
af70074f
SM
8412012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
842
843 * keymap.c (Fsingle_key_description): Handle char ranges.
844
95986d52
CY
8452012-02-12 Chong Yidong <cyd@gnu.org>
846
afd83bd1
CY
847 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
848 as that creates a dangerous corner case.
849
95986d52
CY
850 * window.c (Fdelete_window_internal): Invalidate the mouse
851 highlight (Bug#9904).
852
bd7da63e
GM
8532012-02-12 Glenn Morris <rgm@gnu.org>
854
855 * xselect.c (Fx_own_selection_internal)
856 (Fx_get_selection_internal, Fx_disown_selection_internal)
857 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
858 * nsselect.m (Fx_own_selection_internal)
859 (Fx_disown_selection_internal, Fx_selection_exists_p)
860 (Fx_selection_owner_p, Fx_get_selection_internal):
861 Sync docs and argument specs with the xselect.c versions.
862
77abcbc2
LI
8632012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
864
865 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
866
90b671e2
EZ
8672012-02-11 Eli Zaretskii <eliz@gnu.org>
868
1c0ca0b7
EZ
869 * w32select.c (Fx_selection_exists_p): Sync doc string and
870 argument list with xselect.c. (Bug#10783)
871
872 * w16select.c (Fx_selection_exists_p): Sync doc string and
873 argument list with xselect.c. (Bug#10783)
90b671e2 874
49241268
GM
8752012-02-10 Glenn Morris <rgm@gnu.org>
876
877 * fns.c (Fsecure_hash): Doc fix.
878
f998bbe7 8792012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
880
881 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
882
0992bd9c
CY
8832012-02-07 Chong Yidong <cyd@gnu.org>
884
885 * buffer.c (Fbuffer_local_variables)
886 (buffer_lisp_local_variables): Handle unbound vars correctly;
887 don't let Qunbound leak into Lisp.
888
af008560
GM
8892012-02-07 Glenn Morris <rgm@gnu.org>
890
dd605cc4
GM
891 * image.c (Fimagemagick_types): Doc fix.
892
af008560
GM
893 * image.c (imagemagick-render-type): Change it from a lisp object
894 to an integer. Move the doc here from the lisp manual.
895 Treat all values not equal to 0 the same.
896
1449fa1d
CY
8972012-02-06 Chong Yidong <cyd@gnu.org>
898
899 * doc.c (store_function_docstring): Avoid applying docstring of
900 alias to base function (Bug#2603).
901
3723ec07
AS
9022012-02-04 Andreas Schwab <schwab@linux-m68k.org>
903
904 * .gdbinit (pp1, pv1): Remove redundant defines.
905 (pr): Use pp.
906
79c1cc1e
CY
9072012-02-04 Chong Yidong <cyd@gnu.org>
908
909 * nsterm.m: Declare a global (Bug#10694).
910
d7f29f8e
EZ
9112012-02-04 Eli Zaretskii <eliz@gnu.org>
912
cae07000
SM
913 * w32.c (get_emacs_configuration_options):
914 Include --enable-checking, if specified, in the return value.
d7f29f8e 915
3b95a6f9
MR
9162012-02-04 Martin Rudalics <rudalics@gmx.at>
917
918 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
919 after rounding frame sizes. (Bug#9723)
920
d6fa96a6
EZ
9212012-02-04 Eli Zaretskii <eliz@gnu.org>
922
923 * keyboard.c (adjust_point_for_property): Don't position point
924 before BEGV. (Bug#10696)
925
df0b2940
PE
9262012-02-03 Paul Eggert <eggert@cs.ucla.edu>
927
928 Handle overflow when computing char display width (Bug#9496).
929 * character.c (char_width): Return EMACS_INT, not int.
930 (char_width, c_string_width): Check for overflow when
931 computing the width; this is possible now that individual
932 characters can have unbounded width. Problem introduced
933 by merge from Emacs 23 on 2012-01-19.
934
6bee44d6
MA
9352012-02-02 Michael Albinus <michael.albinus@gmx.de>
936
937 * dbusbind.c (Fdbus_register_method): Mention the return value
938 :ignore in the docstring.
939
44f92739
GM
9402012-02-02 Glenn Morris <rgm@gnu.org>
941
1b9f60cc
GM
942 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
943
44f92739
GM
944 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
945 Unconditionally set to t. (Bug#10673)
946 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
947 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
948 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
949
c5d3843c
KH
9502012-02-02 Kenichi Handa <handa@m17n.org>
951
952 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
953 0, do not call append_composite_glyph.
954
159462d4 9552012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
956
957 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
958 NULL (Bug#6988).
959 (x_produce_glyphs): If the component of a composition is a null
960 string, set it->pixel_width to 1 to avoid zero-width glyph.
961
78cef877
EZ
9622012-02-01 Eli Zaretskii <eliz@gnu.org>
963
964 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
965 first 2 arguments are identical. This makes inserting large
966 output from a subprocess an order of magnitude faster on
967 MS-Windows, where all sbrk'ed memory is always contiguous.
968
97897668
GM
9692012-01-31 Glenn Morris <rgm@gnu.org>
970
971 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 972 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
973 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
974
31fd3586
GM
9752012-01-29 Glenn Morris <rgm@gnu.org>
976
977 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
978
0e24a8b2
CY
9792012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
980
981 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
982
cc0adcb0
CY
9832012-01-28 Chong Yidong <cyd@gnu.org>
984
985 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
986
acc28cb9
CY
9872012-01-26 Chong Yidong <cyd@gnu.org>
988
9c69cfb7
CY
989 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
990
acc28cb9
CY
991 * search.c (Fsearch_forward, Fsearch_backward): Document negative
992 repeat counts (Bug#10507).
993
48da7392
GM
9942012-01-26 Glenn Morris <rgm@gnu.org>
995
996 * lread.c (syms_of_lread): Doc fix.
997
14af5f7f
CY
9982012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
999
1000 * coding.c (encode_designation_at_bol): Change return value to
1001 EMACS_INT.
1002
0b21c100
CY
10032012-01-25 Chong Yidong <cyd@gnu.org>
1004
1005 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1006
3c2907f7
CY
10072012-01-21 Chong Yidong <cyd@gnu.org>
1008
1009 * floatfns.c (Fcopysign): Make the second argument non-optional,
1010 since nil is not allowed anyway.
1011
959ad23f
AS
10122012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1013
1014 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1015 (send_process): Likewise.
1016
34a02f46
MR
10172012-01-19 Martin Rudalics <rudalics@gmx.at>
1018
1019 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
1020 (Vwindow_persistent_parameters): Do not use Qstate.
1021 Rewrite doc-strings.
34a02f46 1022
1259009a 10232012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
1024
1025 * character.c (char_width): New function.
70d4fdf6
GM
1026 (Fchar_width, c_string_width, lisp_string_width):
1027 Use char_width (Bug#9496).
25ed9e61 1028
6a6ee00d
MR
10292012-01-16 Martin Rudalics <rudalics@gmx.at>
1030
1031 * window.c (Vwindow_persistent_parameters): New variable.
1032 (Fset_window_configuration, save_window_save): Handle persistent
1033 window parameters.
1034
c85efaf7
EZ
10352012-01-14 Eli Zaretskii <eliz@gnu.org>
1036
1037 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1038 thrashing the stack of the thread. (Bug#9087)
1039
5944709e
PE
10402012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1041
1042 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1043
e71f5d99
EZ
10442012-01-11 Eli Zaretskii <eliz@gnu.org>
1045
1046 * xdisp.c (rows_from_pos_range): Handle the case where the
1047 highlight ends on a newline. (Bug#10464)
1048 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1049 he end column for display of highlight that ends on a newline
1050 before a R2L line.
1051
ce316182
GM
10522012-01-11 Glenn Morris <rgm@gnu.org>
1053
1054 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1055 from load-path also when installation-directory is nil. (Bug#10208)
1056
5b43da69
GM
10572012-01-10 Glenn Morris <rgm@gnu.org>
1058
74cc8ff9
GM
1059 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1060
7d8d6e4e
GM
1061 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1062 Update template values to be closer to their typical values these days.
5b43da69 1063
a0db8d43
EZ
10642012-01-09 Eli Zaretskii <eliz@gnu.org>
1065
1066 * xdisp.c (rows_from_pos_range): Accept additional argument
1067 DISP_STRING, and accept any glyph in a row whose object is that
1068 string as eligible for mouse highlight. Fixes mouse highlight of
1069 display strings from overlays. (Bug#10464)
1070
9a0115ab 10712012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1072
b9110d6a 1073 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1074 * fileio.c (auto_saving_dir_umask): New static var.
1075 (Fmake_directory_internal): Use it.
1076 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1077 creating the directory. The old code temporarily assigns
1078 too-generous permissions to the directory.
1079 (do_auto_save_eh): Clear it.
b9110d6a 1080 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1081 that the var is always cleared.
1082
6c1bd3f3
EZ
10832012-01-07 Eli Zaretskii <eliz@gnu.org>
1084
1085 * search.c (scan_buffer): Pass character positions to
1086 know_region_cache, not byte positions. (Bug#6540)
1087
069d2b50
L
10882012-01-07 LynX <_LynX@bk.ru> (tiny change)
1089
1090 * w32.c (sys_rename): Report EXDEV when rename of a directory
1091 fails because the target is on another logical disk. (Bug#10284)
1092
75bf0d33
DB
10932012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1094
1095 * xterm.c (x_embed_request_focus): New function.
1096
1097 * xterm.h: Add prototype.
1098
1099 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1100
1c6e5a32
GM
11012012-01-05 Glenn Morris <rgm@gnu.org>
1102
1103 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1104
651e947e
EZ
11052012-01-01 Eli Zaretskii <eliz@gnu.org>
1106
1107 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1108 Load gnutls_transport_set_lowat only if GnuTLS version is below
1109 2.11.1.
1110 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1111 GnuTLS versions below 2.11.1.
1112
3778cdd8
AL
11132011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1114
1115 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1116 to the doc string advising against its use for altering the way
1117 windows are scrolled.
1118
0e5317f7
KH
11192011-12-28 Kenichi Handa <handa@m17n.org>
1120
1121 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1122 coding-system ASCII compatible only when it does not produce BOM
1123 on encoding (Bug#10383).
1124
93d5ca1f
JD
11252011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1126
1127 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1128 can scroll.
1129 (create_and_show_popup_menu): Always use menu_position_func for
1130 Gtk3 (Bug#10361).
1131
ca22b785
AS
11322011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1133
1134 * callint.c (Fcall_interactively): Don't truncate prompt string.
1135
d048e1e6
EZ
11362011-12-23 Eli Zaretskii <eliz@gnu.org>
1137
1138 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1139 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1140 resumed from there (after widening). (Bug#10360)
d048e1e6 1141
5ccaba1f
JD
11422011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1143
1144 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1145
204ee57f
JD
11462011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1147
b81d40f0
JB
1148 * nsterm.m (x_free_frame_resources):
1149 Release f->output_data.ns->miniimage.
204ee57f
JD
1150 (ns_index_color): Fix indentation. Do not retain
1151 color_table->colors[i].
1152
1153 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1154 before returning.
1155
1156 * nsfns.m (x_set_background_color): Assign return value from
1157 ns_index_color to face-background instead of NSColor*.
1158 (ns_implicitly_set_icon_type): Fix indentation.
1159 Change assignment in for loop to comparison.
1160
1161 * emacs.c (ns_pool): New variable.
1162 (main): Assign ns_pool.
1163 (Fkill_emacs): Call ns_release_autorelease_pool.
1164
1165 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1166 autorelease fdesc, release fdAttrs and tdict.
1167 (ns_get_covering_families): Release charset.
1168 (ns_findfonts): Release NSFontDescriptor created with new.
1169 (ns_uni_to_glyphs): Fix indentation.
1170 (setString): Release attrStr before assigning new value.
1171
c803b2b7
JD
11722011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1173
678f4426
JD
1174 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1175 and NS_IMPL_COCOA.
1176 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1177 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1178
cd394be1 11792011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1180
5fecd5fc
JD
1181 * nsterm.m (ns_term_init): Subscribe for notifications
1182 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1183 to method trackingNotification in EmacsMenu.
1184
1185 * nsmenu.m (trackingMenu): New variable.
3771cb17 1186 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1187 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1188 from Aquamacs (Bug#7030).
678f4426
JD
1189
11902011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1191
c803b2b7
JD
1192 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1193 (symbol_to_nsstring): Fix indentation.
1194 (ns_symbol_to_pb): New function.
cae07000
SM
1195 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1196 (Fns_rotate_cut_buffers_internal): Remove.
1197 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1198 Fns_store_cut_buffer_internal.
1199 (ns_get_foreign_selection, Fx_own_selection_internal)
1200 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1201 (Fns_get_selection_internal, Fns_store_selection_internal):
1202 Use ns_symbol_to_pb and check if return value is nil.
1203 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1204 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1205 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1206 renamed to Sns_store_selection_internal.
1207 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1208 and remove this function.
1209 (ns_handle_selection_clear): Remove, never used.
1210 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1211 here.
1212
e1b01a3a
KB
12132011-12-17 Ken Brown <kbrown@cornell.edu>
1214
1215 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1216 GID is unknown (Bug#10257).
1217
2adb6e85
PE
12182011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1219
1220 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1221 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1222 which caused a build failure on GNU/Linux IA-64. This problem was
1223 introduced by my 2011-10-07 patch.
1224
d1d7b339
JL
12252011-12-15 Juri Linkov <juri@jurta.org>
1226
1227 * image.c (imagemagick_error): New function. (Bug#10112)
1228 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1229 Use `imagemagick_error' where ImageMagick functions return
1230 `MagickFalse'.
1231 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1232 proper order.
1233
100d5755
KH
12342011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1235
1236 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1237 fill background (Bug#8992).
1238
454592a6
MR
12392011-12-13 Martin Rudalics <rudalics@gmx.at>
1240
1241 * window.c (Vwindow_combination_resize)
1242 (Vwindow_combination_limit): Use t instead of non-nil in
1243 doc-strings.
61d4b438
MR
1244 (Vrecenter_redisplay): Add first sentence of doc-string on
1245 separate line.
53524d93 1246 (Frecenter): Fix doc-string typo.
454592a6 1247
3633e3aa
KH
12482011-12-11 Kenichi Handa <handa@m17n.org>
1249
1250 * coding.c (Funencodable_char_position): Pay attention to the
1251 buffer text relocation (Bug#9389).
1252
7b9d523a
JD
12532011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1254
1255 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1256 gtk_init (Bug#10100).
1257
b73189c6
EZ
12582011-12-10 Eli Zaretskii <eliz@gnu.org>
1259
1260 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1261 IT->string is nil. (Bug#10263)
1262
f7dfe5d6
JD
12632011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1264
83faebb4
JD
1265 * nsterm.h (x_free_frame_resources): Declare.
1266
f7dfe5d6
JD
1267 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1268 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1269
1270 * nsterm.h (ns_get_defaults_value): Declare.
1271
1272 * nsterm.m (ns_default): Call ns_get_defaults_value.
1273
7cd4e72c
EZ
12742011-12-09 Eli Zaretskii <eliz@gnu.org>
1275
1276 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1277 (Bug#10170)
1278
b34d7317
YM
12792011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1280
1281 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1282 that where the value of an _OBJC_* symbol points to is in the .bss
1283 section (Bug#10240).
1284
76470ad1
KH
12852011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1286
1287 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1288 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1289
745fff94
KH
12902011-12-08 Kenichi Handa <handa@m17n.org>
1291
1292 * ftfont.c (get_adstyle_property): Fix previous change
1293 (Bug#10233).
1294
6e44397c
JB
12952011-12-07 Juanma Barranquero <lekktu@gmail.com>
1296
1297 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1298 dirs from the default value of EMACSLOADPATH (bug#10208).
1299
7efa6272
GM
13002011-12-07 Glenn Morris <rgm@gnu.org>
1301
1302 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1303 installation and source directories as well. (Bug#10208)
1304
f6fc4d87
CY
13052011-12-06 Chong Yidong <cyd@gnu.org>
1306
1307 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1308
2bf26180
GM
13092011-12-06 Glenn Morris <rgm@gnu.org>
1310
1311 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1312 as an error, not just -1. (Bug#10217)
1313
3a6ad4f0
CY
13142011-12-05 Chong Yidong <cyd@gnu.org>
1315
1316 * keyboard.c (process_special_events): New function.
1317 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1318
75a3b399
PE
13192011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 * coding.c (encode_designation_at_bol): Don't use uninitialized
1322 local variable (Bug#9318).
1323
c3c9e25e
KH
13242011-12-05 Kenichi Handa <handa@m17n.org>
1325
1326 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1327 return Qnil (Bug#8046, Bug#10193).
1328
5eb05ea3
KH
13292011-12-05 Kenichi Handa <handa@m17n.org>
1330
1331 * coding.c (encode_designation_at_bol): New args charbuf_end and
1332 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1333 (coding_set_source): Return how many bytes coding->source was
1334 relocated.
1335 (coding_set_destination): Return how many bytes
1336 coding->destination was relocated.
1337 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1338 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1339
13402011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1341
1342 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1343 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1344 macro (Bug#9318).
1345
13462011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1347
1348 The following changes are to fix Bug#9318.
1349
a79703f5 1350 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1351 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1352 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1353 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1354
7dbda6df
JB
13552011-12-05 Juanma Barranquero <lekktu@gmail.com>
1356
1357 * lisp.h (process_quit_flag): Fix external declaration.
1358
6d5eb5b0
SM
13592011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1360
1361 Don't macro-inline non-performance-critical code.
1362 * eval.c (process_quit_flag): New function.
1363 * lisp.h (QUIT): Use it.
1364
a0c3fad0
JD
13652011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1366
1367 * nsfns.m (get_geometry_from_preferences): New function.
1368 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1369
6c07aac2
AS
13702011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1371
1372 * emacs.c (Qkill_emacs): Define.
1373 (syms_of_emacs): Initialize it.
1374 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1375 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1376 (quit_throw_to_read_char): Add parameter `from_signal'.
1377 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1378 * lisp.h (QUIT): Call Fkill_emacs if requested.
1379
c052ead4
JD
13802011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1381
1382 * widget.c (update_wm_hints): Return if wmshell is null.
1383 (widget_update_wm_size_hints): New function.
1384
1385 * widget.h (widget_update_wm_size_hints): Declare.
1386
1387 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1388 widget_update_wm_size_hints (Bug#10104).
1389
9e49252b
EZ
13902011-12-03 Eli Zaretskii <eliz@gnu.org>
1391
1392 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1393 before a newline, prepare the bidi iterator for consuming the
1394 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1395 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1396
02b16839
JL
13972011-12-02 Juri Linkov <juri@jurta.org>
1398
1399 * search.c (Fword_search_regexp): New Lisp function created from
1400 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1401 (Fword_search_backward, Fword_search_forward)
1402 (Fword_search_backward_lax, Fword_search_forward_lax):
1403 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1404 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1405
0068070e
SM
14062011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1407
1408 * fileio.c (Finsert_file_contents): Move after-change-function call
1409 to before the "handled:" label, since all "goto handled" appear in
1410 cases where the *-change-functions have already been properly called
1411 (bug#10117).
1412
3360a3fc
AS
14132011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1414
1415 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1416 waiting for input. (Bug#10169)
1417
73d6c093
EZ
14182011-11-30 Eli Zaretskii <eliz@gnu.org>
1419
1420 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1421 verifies glyph row's hash code--we have just reallocated the
1422 glyphs, so their contents can be complete garbage. (Bug#10164)
1423
febe6bea
JB
14242011-11-30 Juanma Barranquero <lekktu@gmail.com>
1425
1426 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1427
801a4313
EZ
14282011-11-30 Eli Zaretskii <eliz@gnu.org>
1429
1430 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1431 attributes are tested _before_ calling verify_row_hash, to protect
1432 against GCC re-ordering of the tests. (Bug#10164)
1433
2b56b87e
JD
14342011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1435
1436 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1437
1438 * xterm.c (handle_one_xevent): Only set async_visible and friends
1439 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1440 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1441 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1442
dbf31225
PE
14432011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1444
1445 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1446 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1447 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1448 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1449 All uses changed to use GCPRO1 etc.
1450 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1451 Revert to old implementation (i.e., before 2011-03-11).
1452
1305621b
YM
14532011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1454
1455 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1456 of scroll runs so as to avoid assigning disabled bogus rows and
1457 unnecessary graphics copy operations.
1458
8c9afb46
EZ
14592011-11-27 Eli Zaretskii <eliz@gnu.org>
1460
1461 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1462 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1463 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1464 (malloc, free, realloc, calloc): Redirect to e_* only when
1465 compiling Emacs.
1466
1467 * lisp.h (GCTYPEBITS): Move before first use.
1468 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1469 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1470 this macro definition.
1471
1472 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1473 _MSC_VER.
1474
54e9e3bf
JD
14752011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1476
6d5eb5b0
SM
1477 * gtkutil.c (xg_create_frame_widgets):
1478 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1479 present with Gtk+ 2.0.
1480
83aca1cb
PE
14812011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1482
1483 * fileio.c (Finsert_file_contents): Undo previous change; see
1484 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1485
5b76caa4
PE
14862011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1487
1488 Rename locals to avoid shadowing.
1489 * fileio.c (Finsert_file_contents):
1490 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1491 * process.c (wait_reading_process_output):
1492 Rename inner 'proc' to 'p' to avoid shadowing.
1493 Indent for consistency with usual Emacs style.
1494
8c535114
EZ
14952011-11-25 Eli Zaretskii <eliz@gnu.org>
1496
1497 * xdisp.c (redisplay_window): If cursor row is not fully visible
1498 after recentering, and scroll-conservatively is set to a large
1499 number, scroll window by a few more lines to make the cursor fully
1500 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1501 (start_display): Don't move to the next line if the display should
1502 start at a newline that is part of a display vector or an overlay
1503 string. (Bug#10119)
8c535114 1504
fa4fdb5c
JL
15052011-11-24 Juri Linkov <juri@jurta.org>
1506
1507 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1508 after the `MagickPingImage' call. (Bug#10112)
1509
90ec88df
CY
15102011-11-23 Chong Yidong <cyd@gnu.org>
1511
1512 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1513
56e2e794
MR
15142011-11-23 Martin Rudalics <rudalics@gmx.at>
1515
1516 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1517 making another buffer current. (Bug#10114)
1518
b6e64c41
GM
15192011-11-23 Glenn Morris <rgm@gnu.org>
1520
1521 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1522
6b21de18
CY
15232011-11-23 Chong Yidong <cyd@gnu.org>
1524
1525 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1526 using it (Bug#5984).
1527
b12cd789
EZ
15282011-11-22 Eli Zaretskii <eliz@gnu.org>
1529
1530 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1531 and header-lines, as they don't have one computed for them.
1532 (Bug#10098)
1533
1534 * .gdbinit (prow): Make displayed values more self-explaining.
1535 Add row's hash code.
1536
261b6fd4
LMI
15372011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1538
1539 * process.c (wait_reading_process_output): Fix asynchrounous
1540 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1541 (wait_reading_process_output): Add comment and URL.
261b6fd4 1542
e7cfd277
JD
15432011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1544
1545 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1546
a9b9b7f5
CY
15472011-11-21 Chong Yidong <cyd@gnu.org>
1548
1549 * window.c (Fnext_window, Fprevious_window): Doc fix.
1550
b0d15b4f
SM
15512011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1552
1553 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1554
fe7a3057
JB
15552011-11-20 Juanma Barranquero <lekktu@gmail.com>
1556
1557 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1558
d2999b1a
MR
15592011-11-20 Martin Rudalics <rudalics@gmx.at>
1560
1561 * window.c (Fset_window_combination_limit): Rename argument
1562 STATUS to LIMIT.
1563 (Vwindow_combination_limit): Remove "status" from doc-string.
1564
d5ff9cd0
AS
15652011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1566
1567 * m/ibms390.h: Remove.
1568 * m/ibms390x.h: Don't include "ibms390.h".
1569
a5bb9bd3
SM
15702011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1571
1572 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1573 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1574
cd1181db
JB
15752011-11-20 Juanma Barranquero <lekktu@gmail.com>
1576
1577 * casetab.c (Fset_case_table):
1578 * charset.c (Fcharset_after): Fix typos.
1579
615a3b8d 15802011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1581
17e845af
PE
1582 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1583 Otherwise, valgrind does not work on some platforms.
1584 Problem reported by Andreas Schwab in
6a0bf43d
PE
1585 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1586 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1587 is set, removing the need for VIRT_ADDRESS_VARIES.
1588 (PURE_P): Use a more-efficient implementation that needs just one
1589 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1590 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1591 to 4 (xorl, subq, cmpq, setbe).
1592 * alloc.c (pure): Always extern now, since that's the
1593 VIRT_ADDR_VARIES behavior.
1594 (PURE_POINTER_P): Use a single comparison, not two, for
1595 consistency with the new puresize.h.
1596 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1597 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1598 Remove VIRT_ADDR_VARIES no longer needed.
1599
f8fe6f96
EZ
16002011-11-19 Eli Zaretskii <eliz@gnu.org>
1601
1602 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1603 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1604 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1605 behave as if the cursor position were at the window margin.
1606
1607 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1608 and the cursor position is out of bounds, behave as if the cursor
1609 position were at the window margin. (Bug#10075)
1610
df05a53c
CY
16112011-11-18 Chong Yidong <cyd@gnu.org>
1612
1613 * window.c (Fwindow_combination_limit): Make first argument
1614 non-optional, since it is meaningless for live windows like the
1615 selected window.
1616
2071918e
DA
16172011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1618
1619 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1620
b50a28de
SM
16212011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1622
1623 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1624 (graft_intervals_into_buffer): Simplify.
1625
015137db
EZ
16262011-11-18 Eli Zaretskii <eliz@gnu.org>
1627
1628 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1629 hash values of the two rows.
1630 (copy_row_except_pointers): Preserve the used[] arrays and the
1631 hash values of the two rows. (Bug#10035)
68c95424 1632 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1633
1634 * xdisp.c (row_hash): New function, body extracted from
1635 compute_line_metrics.
1636 (compute_line_metrics): Call row_hash, instead of computing the
1637 hash code inline.
1638
1639 * dispnew.c (verify_row_hash): Call row_hash for computing the
1640 hash code of a row, instead of duplicating code from xdisp.c.
1641
1642 * dispextern.h (row_hash): Add prototype.
1643
a2addb04
TH
16442011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1645
1646 * frame.c (delete_frame): Don't delete the terminal when the last
1647 X frame is closed if emacs is built with GTK toolkit.
1648
df85d315
JB
16492011-11-17 Juanma Barranquero <lekktu@gmail.com>
1650
1651 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1652
a0c2d0ae
MR
16532011-11-17 Martin Rudalics <rudalics@gmx.at>
1654
1655 * window.c (Vwindow_splits): Rename to
1656 Vwindow_combination_resize. Suggested by Juri Linkov.
1657 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1658 of Vwindow_splits.
1659
58179cce
JB
16602011-11-16 Juanma Barranquero <lekktu@gmail.com>
1661
7877f373
JB
1662 * nsfns.m (Fns_font_name):
1663 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1664
b6f67890
MR
16652011-11-16 Martin Rudalics <rudalics@gmx.at>
1666
1667 * window.h (window): Rename slot "nest" to "combination_limit".
1668 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1669 (Fset_window_nest): Rename to Fset_window_combination_limit.
1670 (Vwindow_nest): Rename to Vwindow_combination_limit.
1671 (recombine_windows, make_parent_window, make_window)
1672 (Fsplit_window_internal, saved_window)
1673 (Fset_window_configuration, save_window_save): Rename all
1674 occurrences of window_nest to window_combination_limit.
1675
c7015153
JB
16762011-11-15 Juanma Barranquero <lekktu@gmail.com>
1677
1678 * image.c (imagemagick_load_image): Fix typo.
1679
322ad6ec
EZ
16802011-11-14 Eli Zaretskii <eliz@gnu.org>
1681
1682 * xdisp.c (display_line): Move the call to
1683 highlight_trailing_whitespace before the call to
1684 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1685 faces of all the glyphs to compute ROW's hash value.
1686 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1687
f067b8ec
JB
16882011-11-14 Juanma Barranquero <lekktu@gmail.com>
1689
1690 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1691 just return (bug#10044).
1692
1e5b2111
EZ
16932011-11-12 Eli Zaretskii <eliz@gnu.org>
1694
7ef3cbd5
EZ
1695 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1696 with user-defined heap size. Bump the default size of the temacs
1697 heap to 27MB, to avoid memory warning when running temacs.
1698 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1699
1e5b2111
EZ
1700 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1701 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1702 (verify_row_hash) [XASSERTS]: New function.
1703 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1704 that the hash value of glyph rows is correct.
1e5b2111 1705
89d61221
MR
17062011-11-12 Martin Rudalics <rudalics@gmx.at>
1707
1708 * window.h (window): Remove splits slot.
1709 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1710 (Fdelete_other_windows_internal, make_parent_window)
1711 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1712 (Fset_window_configuration, save_window_save): Don't deal with
1713 split status of windows.
1714 (saved_window): Remove splits slot.
1715 (Vwindow_splits): Rewrite doc-string.
1716
97f18cc8
JD
17172011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1718
1719 * xfns.c (unwind_create_frame):
1720 * nsfns.m (unwind_create_frame):
1721 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1722 Vframe_list (Bug#9999).
1723
22a648b4
DA
17242011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1725
0b381c7e 1726 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1727
659afede
KH
17282011-11-11 Kenichi Handa <handa@m17n.org>
1729
1730 * callproc.c (Fcall_process): Set the member dst_multibyte of
1731 process_coding.
1732
9ac0394b
KH
17332011-11-11 Johan Bockgård <bojohan@gnu.org>
1734
1735 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1736 avoid a crash (bug#9496).
1737
2fbdc249
CY
17382011-11-09 Chong Yidong <cyd@gnu.org>
1739
1740 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1741 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1742
ac6b1f81
PE
17432011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1744
1745 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1746
09db192c
PE
17472011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1748
1749 Avoid some portability problems by eschewing 'extern inline' functions.
1750 The trivial performance wins aren't worth the portability hassles; see
1751 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1752 et seq.
1753 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1754 (window_box_width, window_box_left, window_box_left_offset)
1755 (window_box_right, window_box_right_offset): Undo previous change,
1756 by removing the "extern"s.
1757 * intervals.c (adjust_intervals_for_insertion)
1758 (adjust_intervals_for_deletion): Undo previous change,
1759 making these static again.
1760 (offset_intervals, temp_set_point_both, temp_set_point)
1761 (copy_intervals_to_string): No longer inline.
1762 * xdisp.c (window_text_bottom_y, window_box_width)
1763 (window_box_height, window_box_left_offset)
1764 (window_box_right_offset, window_box_left, window_box_right)
1765 (window_box): No longer inline.
1766
105216ed
CY
17672011-11-08 Chong Yidong <cyd@gnu.org>
1768
1769 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1770 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1771 Signal an error if not a live window.
105216ed
CY
1772 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1773 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1774
ae9e237f
JB
17752011-11-07 Juanma Barranquero <lekktu@gmail.com>
1776
1777 * lisp.h (syms_of_abbrev): Remove declaration.
1778 Reported by CHENG Gao <chenggao@royau.me>.
1779
c7aa8333
EZ
17802011-11-07 Eli Zaretskii <eliz@gnu.org>
1781
1782 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1783 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1784 of temacs in GUI mode.
1785
be7f5545
MR
17862011-11-07 Martin Rudalics <rudalics@gmx.at>
1787
1788 * window.h: Declare delete_all_child_windows instead of
1789 delete_all_subwindows.
1790 * window.c (Fwindow_nest, Fset_window_nest)
1791 (Fset_window_new_total, Fset_window_new_normal)
1792 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1793 (delete_all_subwindows): Rename to delete_all_child_windows.
1794 (Fdelete_other_windows_internal, Fset_window_configuration):
1795 Call delete_all_child_windows instead of delete_all_subwindows.
1796 * frame.c (delete_frame): Call delete_all_child_windows instead
1797 of delete_all_subwindows.
1798
ca78dc43
PE
17992011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1800
1801 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1802 This is also needed for porting to any host where GC_MARK_STACK is
1803 not GC_MAKE_GCPROS_NOOPS.
1804 (which_symbols): Use it.
1805
a0241d01
KH
18062011-11-07 Kenichi Handa <handa@m17n.org>
1807
1808 * coding.c (coding_set_destination): Check coding->src_pos only
1809 when coding->src_object is a buffer (bug#9910).
1810
1811 * process.c (send_process): Set the member src_multibyte of coding
1812 to 0 (bug#9911) when sending a unibyte text.
1813
1814 * callproc.c (Fcall_process): Set the member src_multibyte of
1815 process_coding to 0 (bug#9912).
1816
a64bfdfa 18172011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1818
1819 * xmenu.c (cleanup_widget_value_tree): New function.
1820 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1821 calling free_menubar_widget_value_tree directly (Bug#9830).
1822
cb41b32a
PE
18232011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1824
1825 Fix some portability problems with 'inline'.
1826 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1827 (window_box_width, window_box_left, window_box_left_offset)
1828 (window_box_right, window_box_right_offset): Declare extern.
1829 Otherwise, these inline functions do not conform to C99 and
1830 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1831 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1832 * intervals.c (adjust_intervals_for_insertion)
1833 (adjust_intervals_for_deletion): Now extern, because otherwise the
1834 extern inline functions 'offset_intervals' couldn't refer to it.
1835 (static_offset_intervals): Remove.
1836 (offset_intervals): Rewrite using the old contents of
1837 static_offset_intervals. The old version didn't conform to C99
1838 because an extern inline function contained a reference to an
1839 identifier with static linkage.
1840
b7041366
AS
18412011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1842
1843 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1844 GC.
1845
88a37c4d
EZ
18462011-11-06 Eli Zaretskii <eliz@gnu.org>
1847
1848 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1849 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1850 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1851 return Qleft_to_right.
1852
49745b39
CY
18532011-11-06 Chong Yidong <cyd@gnu.org>
1854
1855 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1856 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1857 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1858 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1859 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1860 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1861 (Fwindow_vscroll): Doc fix.
1862 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1863 argument, since it makes no sense to pass a live window and for
1864 consistency with window-child.
1865
1f05cd82
CS
18662011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1867
1868 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1869 support MSVC.
1870
22610910
JR
18712011-11-05 Jason Rumney <jasonr@gnu.org>
1872
1873 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1874 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1875 fonts (Bug#6029).
1876 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1877 bitwise arithmetic preventing use of unicode-sip and non-truetype
1878 opentype fonts.
1879
a06776b2
EZ
18802011-11-05 Eli Zaretskii <eliz@gnu.org>
1881
3ad924ba
EZ
1882 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1883 "emacs"-only part.
1884
a06776b2
EZ
1885 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1886 initialization code to keep similarity to xfns.c after changes
1887 from 2011-11-05.
1888
c9e7db78
JD
18892011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1890
a97f8f3f
JD
1891 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1892 (unwind_create_frame): New function (Bug#9943).
1893 (Fx_create_frame): Restructure code to be more similar to the one in
1894 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1895 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1896 Move terminal->reference_count++ just before making the frame official
1897 (Bug#9943).
1898
1899 * nsterm.m (x_free_frame_resources): New function.
1900 (x_destroy_window): Move code to x_free_frame_resources.
1901
c9e7db78 1902 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1903 (Fx_create_frame, x_create_tip_frame):
1904 Move terminal->reference_count++ just before making the frame
75f1671a 1905 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1906 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1907
a6fc3b5c
EZ
19082011-11-05 Eli Zaretskii <eliz@gnu.org>
1909
1910 Support MSVC build with newer versions of Visual Studio.
1911 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1912 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1913 nt/gmake.defs.
1914
1915 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1916 which are not supported by MSVC.
1917 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1918 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1919 bitfields.
1920 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1921 types in bitfields.
1922 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1923
1924 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1925
58179cce 19262011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1927
1928 Support MSVC build with newer versions of Visual Studio.
1929 * w32.c: Don't include w32api.h for MSVC.
1930 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1931
1932 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1933 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1934 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1935 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1936 e_* cousins.
1937 (alloca) [_MSC_VER]: Define to _alloca.
1938
1939 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1940
1941 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1942
a58c13ed
EZ
19432011-11-04 Eli Zaretskii <eliz@gnu.org>
1944
1945 * xdisp.c (note_mouse_highlight): If either of
1946 previous/next-single-property-change returns nil, treat that as
1947 the beginning or the end of the buffer. (Bug#9955)
1948
fe0b6370
JD
19492011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1950
a58c13ed 1951 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1952 label is not null (Bug#9951).
1953 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1954 may be NULL.
1955
89bd5ee1
EZ
19562011-11-04 Eli Zaretskii <eliz@gnu.org>
1957
1958 * window.c (Fwindow_body_size): Mention in the doc string that the
1959 return value is in frame's canonical units. (Bug#9949)
1960
84c3edb9
EZ
19612011-11-03 Eli Zaretskii <eliz@gnu.org>
1962
4e2fb5c7
EZ
1963 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1964
84c3edb9 1965 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1966 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1967 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1968
bc17a887
EZ
19692011-11-01 Eli Zaretskii <eliz@gnu.org>
1970
1971 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1972 Don't stop backward scan on the continuation glyph, even though
1973 its CHARPOS is positive.
6d5eb5b0
SM
1974 (mouse_face_from_buffer_pos, note_mouse_highlight):
1975 Rename cover_string to disp_string.
bc17a887 1976
4ee88440
MR
19772011-11-01 Martin Rudalics <rudalics@gmx.at>
1978
1979 * window.c (temp_output_buffer_show): Don't use
1980 Vtemp_buffer_show_specifiers.
1981 (Vtemp_buffer_show_specifiers): Remove unused variable.
1982
c2ff3c02
EZ
19832011-10-30 Eli Zaretskii <eliz@gnu.org>
1984
1985 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1986 past the beginning of the current glyph matrix.
1987
58179cce 19882011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1989
1990 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1991 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1992 HAVE_GTK3 (Bug#9869).
b77a6a7f 1993
3b574623
JD
1994 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1995 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1996
b77a6a7f
JD
1997 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1998
1999 * xterm.c: Declare x_handle_net_wm_state to return int.
2000 (handle_one_xevent): Check if we are iconified but don't have
2001 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2002 (get_current_wm_state): Return non-zero if not hidden,
2003 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2004 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2005 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2006 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2007
196e41e4
PE
20082011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2009
2010 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2011 so that this new function doesn't get optimized away by a
2012 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2013
021f2e1a
AS
20142011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2015
2016 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2017
8b058d44
EZ
20182011-10-29 Eli Zaretskii <eliz@gnu.org>
2019
2020 Fix the `xbytecode' command.
2021 * .gdbinit (xprintbytestr): New command.
b50a28de 2022 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
2023 (xbytecode): Print the byte-code string as well.
2024
4452fb80
EZ
20252011-10-29 Kim Storm <storm@cua.dk>
2026
8b058d44
EZ
2027 * alloc.c (which_symbols): New function.
2028
21b72067
AS
20292011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2030
2031 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2032 line. (Bug#9903)
2033
83ed7b5c
GM
20342011-10-29 Glenn Morris <rgm@gnu.org>
2035
2036 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2037 Not clear what it was for, and it causes various bugs. (Bug#9839)
2038
5a7a728b
EZ
20392011-10-28 Eli Zaretskii <eliz@gnu.org>
2040
2041 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2042 possible random value that matches one of those tested as
2043 condition to clear the mouse face.
2044
d3d0842f
CY
20452011-10-28 Chong Yidong <cyd@gnu.org>
2046
2047 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2048
31b39d13
DN
20492011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2050
2051 * window.c (make_window): Initialize phys_cursor_on_p.
2052
9aba6043
SM
20532011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2054
2055 * lisp.h (struct Lisp_Symbol): Update comments.
2056
c20992f4
JB
20572011-10-28 Juanma Barranquero <lekktu@gmail.com>
2058
2059 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2060
db4f02f2
EZ
20612011-10-28 Eli Zaretskii <eliz@gnu.org>
2062
2063 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2064 <oslsachem@gmail.com> for helping to debug this.
2065
2066 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2067 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2068 (g_b_init_get_glyph_outline_w): New static variables.
2069 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2070 (GetGlyphOutlineW_Proc): New typedefs.
2071 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2072 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2073 New functions.
2074 (w32font_open_internal, compute_metrics):
2075 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2076 instead of calling the "wide" APIs directly.
2077
2078 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2079
2080 * w32.h (syms_of_w32font): Add prototype.
2081
87e68db4
JB
20822011-10-27 Juanma Barranquero <lekktu@gmail.com>
2083
2084 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2085 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2086 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2087 (Fmove_to_window_line): Doc fix.
2088
435c1d67
CY
20892011-10-27 Chong Yidong <cyd@gnu.org>
2090
2091 * process.c (make_process): Set gnutls_state to NULL.
2092
2093 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2094 non-NULL, regardless of GNUTLS_INITSTAGE.
2095 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2096 an error. Set process slots as soon as we allocate them.
2097
2098 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2099
9c6c6f49
CY
21002011-10-27 Chong Yidong <cyd@gnu.org>
2101
9aba6043
SM
2102 * gnutls.c (emacs_gnutls_deinit): New function.
2103 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2104 (Fgnutls_deinit, Fgnutls_boot): Use it.
2105
2106 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2107 (deactivate_process): Call emacs_gnutls_deinit.
2108
657d08d3
JB
21092011-10-27 Juanma Barranquero <lekktu@gmail.com>
2110
2111 * image.c (x_create_x_image_and_pixmap):
2112 * w32.c (sys_rename, w32_delayed_load):
2113 * w32font.c (fill_in_logfont):
2114 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2115
5430d399
JB
21162011-10-26 Juanma Barranquero <lekktu@gmail.com>
2117
2118 * w32fns.c (w32_default_color_map): New function,
2119 extracted from Fw32_default_color_map.
a7ef684b 2120 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2121
fe0055fa
PE
21222011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2123
2124 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2125
e6346438
SM
21262011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2127
2128 * keyboard.c (test_undefined): New function (bug#9751).
2129 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2130
e112cc37
ET
21312011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2132
2133 * sysdep.c (init_sys_modes): Fix the check for the controlling
2134 terminal (Bug#6649).
2135
7b5d6677
EZ
21362011-10-20 Eli Zaretskii <eliz@gnu.org>
2137
2138 * dispextern.h (struct bidi_it): New member next_en_type.
2139
2140 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2141 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2142 current character, check also for next_en_type being WEAK_EN.
2143 (bidi_resolve_weak): Don't enter the expensive loop if the current
2144 position is before next_en_pos. Record the bidi type of the first
2145 non-ET, non-BN character we find, in addition to its position.
2146 (bidi_level_of_next_char): Invalidate next_en_type when
2147 next_en_pos is over-stepped.
2148
7da0b018
PE
21492011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2150
2151 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2152 * editfns.c: Rewrite current-time-zone so that it invokes
2153 the equivalent of (format-time-string "%Z") to get the time zone name.
2154 This fixes a bug when the time zone name contains characters that
2155 need converting from the system time locale to Emacs internal format.
2156 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2157 that patch fixed format-time-string to do the conversion, but
2158 I forgot to fix current-time-zone.
2159 (format_time_string): New function, containing most of
2160 what Fformat_time_string used to contain.
2161 (Fformat_time_string): Rewrite in terms of format_time_string.
2162 This doesn't change this function's behavior.
2163 (current-time-zone): Rewrite to use format_time_string.
2164 This fixes the bug reported by Michael Schierl in
2165 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2166 Jason Rumney's 2007-06-07 change worked around this bug, but
2167 didn't fix it.
2168 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2169
8547b010
EZ
21702011-10-19 Eli Zaretskii <eliz@gnu.org>
2171
2172 * xdisp.c (start_display): If the character at POS is displayed
2173 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2174 (try_window_reusing_current_matrix): If a line ends in a display
2175 vector or the next line starts in a display vector, continue
2176 redrawing the window even though the character position of
2177 start_row was reached.
8547b010
EZ
2178 (Bug#9771, part 2)
2179
4e948d15
CY
21802011-10-18 Chong Yidong <cyd@gnu.org>
2181
2182 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2183 with nobreak-char-display too.
2184
4787455f
EZ
21852011-10-18 Eli Zaretskii <eliz@gnu.org>
2186
2187 Fix part 3 of bug#9771.
2188 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2189 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2190 non-neutral characters if the current character is a paragraph
2191 separator (a.k.a. Newline). This avoids running the same
2192 expensive loop twice, once when we consume the preceding newline
2193 and the other time when the line actually needs to be displayed.
2194 Avoid the loop when we see neutrals on the base embedding level
2195 following a character whose directionality is the same as the
2196 paragraph's. This avoids running the expensive loop when a line
2197 ends in a long sequence of neutrals, like control characters.
2198 Add assertion against STRONG_AL type. Slightly rearrange code
2199 that determines the type of a neutral given the first non-neutral
2200 that follows it.
2201 (bidi_level_of_next_char): Set next_en_pos to zero when
2202 invalidating its info.
2203
2c91f553
EZ
22042011-10-17 Eli Zaretskii <eliz@gnu.org>
2205
2206 * xdisp.c (push_display_prop): Determine whether to record string
2207 or buffer position by IT->string, not by IT->method. Allow
2208 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2209 (move_it_vertically_backward): Don't look for character position
2210 immediately after the newline when in a continuation line.
2211 (Bug#9771, part 1)
2c91f553 2212
c7b08b0d
MR
22132011-10-15 Martin Rudalics <rudalics@gmx.at>
2214
2215 * window.c (coordinates_in_window): Rewrite and delabelize
2216 vertical border check. (Bug#5357) (Bug#9618)
2217
6b02f655
SM
22182011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2219
2220 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2221 errors in XSetWindowBorder (bug#9310).
2222
81d40c92
DA
22232011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2224
2225 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2226 avoid crash when xmalloc overrun checking is enabled.
2227
d4172c3b
EZ
22282011-10-13 Eli Zaretskii <eliz@gnu.org>
2229
2230 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2231 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2232 cursor motion with <left> and <right> arrow keys.
2233
2234 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2235 some callers set that themselves.
2236
b00eea75
EZ
22372011-10-12 Eli Zaretskii <eliz@gnu.org>
2238
2239 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2240 display string and the previous row comes from the same string and
2241 is empty. (Bug#9739) (Bug#9738)
2242
8fe012c4
SM
22432011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2244
2245 * doc.c (get_doc_string): Encode file name (bug#9735).
2246
0074aef2
EZ
22472011-10-12 Eli Zaretskii <eliz@gnu.org>
2248
79beb178
EZ
2249 * bidi.c (bidi_level_of_next_char):
2250 * xdisp.c (get_visually_first_element): Remove old incorrect
2251 comments regarding the Unicode Line Separator character.
2252
0074aef2
EZ
2253 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2254
6e4b3fbe
DA
22552011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2256
2257 * alloc.c (Fgc_status): Do not access beyond zombies array
2258 boundary if nzombies > MAX_ZOMBIES.
2259 * alloc.c (dump_zombies): Add missing format specifier.
2260
0324f3af
PE
22612011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2262
b5525cac
PE
2263 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2264 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2265
0324f3af
PE
2266 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2267 Some packages use them to denote characters with modifiers.
2268
e9b5f888
AS
22692011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2270
2271 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2272 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2273 matching a pp-number. Rename parameter var to var1.
2274
127827c0
SM
22752011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2276
2277 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2278
c8fd3bd0
GM
22792011-10-08 Glenn Morris <rgm@gnu.org>
2280
2281 * callint.c (Fcall_interactively): Give a more explicit error for the
2282 'c' case with a non-character input. (Bug#8479)
2283
352ec8ff
EZ
22842011-10-08 Eli Zaretskii <eliz@gnu.org>
2285
03669ccb
EZ
2286 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2287 lines.
7061c986
EZ
2288 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2289 lines that are hscrolled on the left.
03669ccb 2290
352ec8ff
EZ
2291 * dispnew.c (buffer_posn_from_coords): Account for a possible
2292 presence of header-line. (Bug#4426)
2293
a66cfb1c
SM
22942011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2295
6b02f655
SM
2296 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2297 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2298
7c5ee88e
PE
22992011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2300
2301 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2302 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2303 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2304 this makes Emacs dump core during garbage collection on rare
2305 occasions. sizeof is obviously inferior to offsetof here, so
2306 stick with offsetof.
2307 (GC_POINTER_ALIGNMENT): New macro.
2308 (mark_memory): Omit 3rd (offset) arg; caller changed.
2309 Don't assume EMACS_INT alignment is the same as pointer alignment.
2310
df1bbe5b
SM
23112011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2312
2313 * keyboard.c (read_key_sequence_remapped): New var.
2314 (read_key_sequence): Compute remapping in the right buffer.
2315 (command_loop_1): Use read_key_sequence's remapping directly.
2316
51553db6
SM
23172011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2318
32c1fffd
SM
2319 * dired.c (file_name_completion): Don't expand file name.
2320 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2321 before checking file name handler.
2322
51553db6
SM
2323 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2324 they've been requested explicitly (bug#9591).
2325
b6bd1599 23262011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2327
2328 * keymap.c (Fsingle_key_description): Use make_specified_string
2329 instead of build_string to build string from push_key_description.
2330 (Bug#5193)
2331
f701dc2a
PE
23322011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2333
4222c55d
PE
2334 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2335 This fixes a Y2038 bug on 64-bit hosts.
2336 * buffer.c (reset_buffer):
2337 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2338 (Fclear_buffer_auto_save_failure):
2339 Use 0, not -1, to represent an unset failure time, since time_t
2340 might not be signed.
2341
f701dc2a
PE
2342 Remove dependency on glibc malloc internals.
2343 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2344 Move back here from lisp.h, but with their new implementations.
2345 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2346 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2347 * charset.c (charset_table_init): New static var.
2348 (syms_of_charset): Use it instead of xmalloc. This removes a
2349 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2350 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2351 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2352 Move back to alloc.c.
2353 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2354 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2355
9ceebf39
JD
23562011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2357
2358 * nsterm.m (windowDidResize): Call x_set_window_size only when
2359 ns_in_resize is true. Otherwise set pixelwidth/height and
2360 call change_frame_size (Bug#9628).
2361
cb993c58
PE
23622011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2363
3930c88b
PE
2364 Port --enable-checking=all to Fedora 14 x86-64.
2365 * charset.c (syms_of_charset): Also account for glibc malloc's
2366 internal overhead when calculating the initial malloc maximum.
2367
cb993c58
PE
2368 Port --enable-checking=all to Fedora 14 x86.
2369 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2370 Move to lisp.h.
2371 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2372 (overrun_check_realloc, overrun_check_free):
2373 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2374 That way, xmalloc returns a properly-aligned pointer even if
2375 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2376 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2377 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2378 into account when calculating the initial malloc maximum.
2379 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2380 Move here from alloc.c, so that charset.c can use it too.
2381 Properly align; the old code wasn't right for common 32-bit hosts
2382 when configured with --enable-checking=all.
2383 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2384 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2385
31bed486
EZ
23862011-09-29 Eli Zaretskii <eliz@gnu.org>
2387
04c70788 2388 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2389 use EDOM.
2390
fbcaa2f3
EZ
23912011-09-28 Eli Zaretskii <eliz@gnu.org>
2392
2393 * xdisp.c (compute_display_string_end): If there's no display
2394 string at CHARPOS, return -1.
2395
2396 * bidi.c (bidi_fetch_char): When compute_display_string_end
2397 returns a negative value, treat the character as a normal
2398 character not covered by a display string. (Bug#9624)
2399
a239d4e9
JB
24002011-09-28 Juanma Barranquero <lekktu@gmail.com>
2401
2402 * lread.c (Fread_from_string): Fix typo in docstring.
2403
88652fd5
EZ
24042011-09-27 Eli Zaretskii <eliz@gnu.org>
2405
2406 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2407 newline, reseat the iterator instead of bidi-iterating there one
2408 character at a time. (Bug#9610)
32c1fffd
SM
2409 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2410 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2411
ed497dd4
AS
24122011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2413
2414 * lread.c (readevalloop): Use correct code for NBSP.
2415 (read1): Likewise. (Bug#9608)
2416
b2bf61aa
MA
24172011-09-25 Michael Albinus <michael.albinus@gmx.de>
2418
2419 * dbusbind.c (Fdbus_register_signal): When service is not
2420 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2421
32bbb17c
GM
24222011-09-25 Glenn Morris <rgm@gnu.org>
2423
2424 * buffer.c (truncate-lines): Doc fix.
2425
94e0933e
CY
24262011-09-24 Chong Yidong <cyd@stupidchicken.com>
2427
2428 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2429 (Fset_window_next_buffers): Doc fix.
2430
cddde921
GM
24312011-09-24 Glenn Morris <rgm@gnu.org>
2432
2433 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2434
1260aef1
PE
24352011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2436
25b4bfa0
PE
2437 Fix minor problems found by static checking.
2438 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2439 * indent.c (Fvertical_motion): Fix == vs = typo.
2440
e3cbd34b
EZ
24412011-09-24 Eli Zaretskii <eliz@gnu.org>
2442
a66cfb1c
SM
2443 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2444 Default value is now t. Doc fix.
6bf7006f 2445
e3cbd34b 2446 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2447 logic when moving up, not only when moving down. Fix the
e3cbd34b 2448 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2449 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2450
2451 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2452 CHARPOS is covered by a display string which includes newlines.
2453 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2454 is covered by a display string with embedded newlines.
2455
a3de0cbd
MA
24562011-09-24 Michael Albinus <michael.albinus@gmx.de>
2457
2458 * dbusbind.c (Fdbus_register_signal): Add match rule to
2459 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2460 (Fdbus_register_method, Vdbus_registered_objects_table):
2461 Fix docstring.
a3de0cbd 2462
b260039d
JM
24632011-09-24 Jim Meyering <meyering@redhat.com>
2464
32c1fffd 2465 do not ignore write error for any output size
b260039d
JM
2466 The previous change was incomplete.
2467 While it makes emacs --batch detect the vast majority of stdout
2468 write failures, errors were still ignored whenever the output size is
2469 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2470 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2471 && echo FAIL: ignored write error
2472 FAIL: ignored write error
2473 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2474 && echo FAIL: ignored write error
2475 FAIL: ignored write error
2476 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2477
8eca8a7c
AS
24782011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2479
2480 * emacs.c (Fkill_emacs): In noninteractive mode exit
2481 non-successfully if a write error occurred on stdout. (Bug#9574)
2482
3341db62
EZ
24832011-09-21 Eli Zaretskii <eliz@gnu.org>
2484
2485 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2486 the xassert test.
2487
2488 * dispextern.h (struct it): Update the comment documenting what
2489 can it->OBJECT be.
2490
8c203dbf
EZ
24912011-09-20 Eli Zaretskii <eliz@gnu.org>
2492
2493 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2494 a display string, extend search for cursor position to end of row.
2495 (find_row_edges): If the row ends in a newline from a display
2496 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2497 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2498 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2499 non-empty line. Fixes confusing cursor motion with arrow keys at
2500 the beginning of a line that starts with whitespace.
8c203dbf 2501
a4824228
LMI
25022011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2503
2504 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2505 (bug#9493).
2506
33ed493b
CY
25072011-09-18 Chong Yidong <cyd@stupidchicken.com>
2508
2509 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2510 boolean (Bug#9154).
2511
56cd55c8
EZ
25122011-09-18 Eli Zaretskii <eliz@gnu.org>
2513
2514 * xdisp.c (display_line): Record maximum and minimum buffer
2515 positions even if no glyphs were produced (e.g., by a zero-width
2516 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2517 buffer positions that will be removed from the glyph row because
2518 they don't fit.
c02dcedf
EZ
2519 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2520 column is beyond frame width: don't subtract 1 "pixel" when
2521 computing width of the stretch.
3e62b7e0
EZ
2522 (reseat_at_next_visible_line_start): Undo the change made on
2523 2011-09-17 that saved paragraph information and restored it after
2524 the call to `reseat'. (Bug#9545)
56cd55c8 2525
5ed99d36 25262011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2527
2528 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2529 and turn window cursor on if cleared (Bug#9415).
2530
5ed99d36 25312011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2532
2533 * search.c (boyer_moore): Take unibyte characters from pattern
2534 literally. (Bug#9458)
2535
9bade7b2
EZ
25362011-09-18 Eli Zaretskii <eliz@gnu.org>
2537
2538 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2539
e5e9d610
PE
25402011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2541
87e4427a
PE
2542 Fix minor problem found by static checking.
2543 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2544 initialized, to pacify gcc -Wuninitialized.
2545
e5e9d610
PE
2546 * fileio.c: Report proper errno when syscall falls.
2547 (Finsert_file_contents): Save and restore errno,
2548 so that report_file_error outputs the correct diagnostic.
2549 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2550
a1674f0b
EZ
25512011-09-18 Eli Zaretskii <eliz@gnu.org>
2552
2553 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2554
fbfb6dd4
EZ
25552011-09-17 Eli Zaretskii <eliz@gnu.org>
2556
2557 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2558 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2559
bb187662
EZ
25602011-09-17 Eli Zaretskii <eliz@gnu.org>
2561
1137e8b8 2562 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2563 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2564
2565 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2566 (bidi_find_paragraph_start): Search back for paragraph beginning
2567 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2568 (bidi_move_to_visually_next): Only trigger paragraph-related
2569 computations when the last character is a newline or at EOB, not
2570 just any NEUTRAL_B. (Bug#9470)
2571
bb187662
EZ
2572 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2573 truncated lines if point is covered by a display string. (Bug#9524)
2574
2e621251
PE
25752011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2576
2577 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2578 (cons_to_x_long): New function.
2579 (lisp_data_to_selection_data): Use it. Correct the test for
2580 short-versus-long data; it was negated. Break out of vector
2581 loop, for efficiency, when a long datum is discovered.
2582
91a15bc6
SM
25832011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2584
2585 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2586
b41c3a35
EZ
25872011-09-16 Eli Zaretskii <eliz@gnu.org>
2588
2589 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2590 GCC PR/17406) by declaring this function with external scope.
2591
7812ba2d
PE
25922011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2593
2594 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2595 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2596
cf7edc2a
AS
25972011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2598
2599 * editfns.c (Fformat): Correctly handle text properties on "%%".
2600
bd01620e
EZ
26012011-09-15 Eli Zaretskii <eliz@gnu.org>
2602
2603 * xterm.c (x_draw_composite_glyph_string_foreground):
2604 * w32term.c (x_draw_composite_glyph_string_foreground):
2605 * term.c (encode_terminal_code):
2606 * composite.c (composition_update_it, get_composition_id):
2607 * xdisp.c (get_next_display_element)
2608 (fill_composite_glyph_string): Add comments about special meaning
2609 of TAB characters in a composition.
2610
a02719a3
PE
26112011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2612
2613 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2614 This occurs when processing a multibyte format.
2615 Problem reported by Wolfgang Jenker.
a02719a3 2616
72589a3c
JB
26172011-09-15 Johan Bockgård <bojohan@gnu.org>
2618
2619 * xdisp.c (try_cursor_movement): Only check for exact match if
2620 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2621
1c14176c
PE
26222011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2623
2624 Remove unused external symbols.
2625 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2626 * xdisp.c (calc_pixel_width_or_height): Now static.
2627 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2628 * indent.c (check_display_width):
2629 * w32term.c: Fix comment to match code.
2630 * xterm.c, xterm.h (x_catching_errors): Remove.
2631
d2eea5b5
PE
26322011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2633
2634 * xselect.c: Use signed conversions more consistently (Bug#9498).
2635 (selection_data_to_lisp_data): Assume incoming selection data are
2636 signed integers, not unsigned. This is to be consistent with
2637 outgoing selection data, which was modified to use signed integers
2638 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2639 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2640 expects long, not unsigned long.
2641
46888499
EZ
26422011-09-14 Eli Zaretskii <eliz@gnu.org>
2643
2644 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2645 computation of loop end. Reported by Johan Bockgård
2646 <bojohan@gnu.org>.
2647
ef8ef9fb
CY
26482011-09-13 Chong Yidong <cyd@stupidchicken.com>
2649
2650 * frame.c (Fother_visible_frames_p): Function deleted.
2651
fa819fed
EZ
26522011-09-12 Eli Zaretskii <eliz@gnu.org>
2653
2654 * indent.c (compute_motion): Process display vector front to back
2655 rather than the other way around. (Bug#2496)
2656
2ba8e008
SM
26572011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2658
2659 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2660
20f53c69
CY
26612011-09-11 Chong Yidong <cyd@stupidchicken.com>
2662
2663 * minibuf.c (Fread_from_minibuffer): Doc fix.
2664
d562d7a4
EZ
26652011-09-11 Eli Zaretskii <eliz@gnu.org>
2666
2667 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2668 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2669
1c4d7f3d
LMI
26702011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2671
2672 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2673 value for non-existent files.
2674
b885bf36
EZ
26752011-09-11 Eli Zaretskii <eliz@gnu.org>
2676
2677 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2678 set its "size" to -1. This will set the modtime_size field of
2679 the corresponding buffer to -1, which is what
2680 verify-visited-file-modtime expects for files that do not exist.
2681 (Bug#9139)
2682
6612f0bf
PE
26832011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2684
2685 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2686 here ...
2687 * lisp.h: ... from here. push_key_description is no longer
2688 defined in keyboard.c, so its declaration should not be in
2689 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2690 logically belongs with push_key_description.
2691
dfb3f755
PE
26922011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2693
2694 * buffer.h: Include <sys/types.h> instead of <time.h>.
2695 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2696 Problem reported by Herbert J. Skuhra.
2697
3134906c
LMI
26982011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2699
2700 * xml.c (parse_region): Make the parsing work for
2701 non-comment-starting XML files again (bug#9144).
2702
8d903f4e
AS
27032011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2704
2705 * image.c (gif_load): Fix calculation of bottom and right corner.
2706 (Bug#9468)
2707
80ad64f4
EZ
27082011-09-10 Eli Zaretskii <eliz@gnu.org>
2709
2710 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2711 redisplay in small windows.
2712
208a048d
EZ
27132011-09-09 Eli Zaretskii <eliz@gnu.org>
2714
2715 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2716
9b1c252e
MR
27172011-09-08 Martin Rudalics <rudalics@gmx.at>
2718
2719 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2720 Operate on live windows only.
2721
2949f33b
JB
27222011-09-08 Juanma Barranquero <lekktu@gmail.com>
2723
2724 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2725
e08dcafd
EZ
27262011-09-07 Eli Zaretskii <eliz@gnu.org>
2727
2728 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2729 only under bidi iteration.
2730
115b96bd
JD
27312011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2732
2733 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2734
c8199d0f
PE
27352011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2736
2737 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2738 Without this fix, the command to link temacs failed due to an
2739 undefined symbol __builtin_isnan. This is because
2740 /usr/include/iso/math_c99.h #defines isnan(x) to
2741 __builtin_isnan(x), but the bundled gcc, which identifies itself
2742 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2743 a __builtin_isnan.
2744 * floatfns.c (isnan): #undef, and then #define to a clone of
2745 what's in data.c.
2746 (Fisnan): Always define, since it's always available now.
2747 (syms_of_floatfns): Always define isnan at the Lisp level.
2748
e39b275c 27492011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2750
2751 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2752
b2db44d9 27532011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2754
f4af5137 2755 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2756 The previous code assumed that file offsets (off_t values) fit in
2757 EMACS_INT variables, which is not true on typical 32-bit hosts.
2758 The code messed up by falsely reporting buffer overflow in cases
2759 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2760 when "big" contains more than 2**29 bytes, even though this
2761 inserts just one byte and does not overflow the buffer.
2762 (Finsert_file_contents): Store file offsets as off_t
2763 values, not as EMACS_INT values. Check for overflow when
2764 converting between EMACS_INT and off_t. When checking for
2765 buffer overflow or for overlap, take the offsets into account.
2766 Don't use EMACS_INT for small values where int suffices.
2767 When checking for overlap, fix a typo: ZV was used where
2768 ZV_BYTE was intended.
2769 (Fwrite_region): Don't assume off_t fits into 'long'.
2770 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2771
ecfc0a49
MA
27722011-09-05 Michael Albinus <michael.albinus@gmx.de>
2773
2774 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2775
6511acf2 27762011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2777
0999621a 2778 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2779
2780 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2781 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2782 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2783 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2784 (modify_event_symbol): Do not assume that the length of
2785 name_alist_or_stem is safe to alloca and fits in int.
2786 (Fexecute_extended_command): Likewise for function name and binding.
2787 (Frecursion_depth): Wrap around reliably on integer overflow.
2788 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2789 since some callers pass EMACS_INT values.
2790 (Fsingle_key_description): Don't crash if symbol name contains more
2791 than MAX_ALLOCA bytes.
2792 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2793 (get_minibuffer): Arg is now EMACS_INT, not int.
2794 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2795 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2796 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2797
2be7d702
PE
2798 * dbusbind.c (signature_cat): New function.
2799 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2800 Do not overrun buffer; instead, report string overflow.
2801
9d1df220
PE
2802 * dispnew.c (add_window_display_history): Don't overrun buffer.
2803 Truncate instead; this is OK since it's just a log.
2804
33ef5c64
PE
2805 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2806 even if the time zone offset is outlandishly large.
2807 Don't mishandle offset == INT_MIN.
2808
66c6fdd5
PE
2809 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2810 when creating daemon; the previous buffer-overflow check was incorrect.
2811
d749b01b
PE
2812 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2813 which has the guts of the old verror function.
2814
b5cd1905
PE
2815 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2816 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2817
6e1a67fb
PE
2818 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2819 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2820 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2821 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2822 length of string rather than counting it via multiple sprintfs;
2823 that's simpler and more reliable.
c21721cc
PE
2824 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2825 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2826 sprintf, in case result does not fit in int.
2827
c57b67fc
PE
2828 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2829 (fontset_from_font): Print it.
2830
8a401434
PE
2831 * frame.c (tty_frame_count): Now printmax_t, not int.
2832 (make_terminal_frame, set_term_frame_name): Print it.
2833 (x_report_frame_params): In X, window IDs are unsigned long,
2834 not signed long, so print them as unsigned.
2835 (validate_x_resource_name): Check for implausibly long names,
2836 and don't assume name length fits in 'int'.
2837 (x_get_resource_string): Don't blindly alloca invocation name;
2838 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2839 not fit in int.
2840
6e1a67fb
PE
2841 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2842 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2843 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2844
0df02bf3
PE
2845 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2846 Use esprintf, not sprintf, in case result does not fit in int.
2847
48e30793
PE
2848 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2849 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2850 it as a large positive number.
2851 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2852 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2853
a66ff6d8
PE
2854 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2855 in case result does not fit in int.
2856
aca216ff
PE
2857 * print.c (float_to_string): Detect width overflow more reliably.
2858 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2859 buffer overrun. Don't assume list length fits in 'int'. Treat
2860 print length of 0 as 0, not as infinity; to be consistent with other
2861 uses of print length in this function. Don't overflow print length
2862 index. Don't assume hash table size fits in 'long', or that
2863 vectorlike size fits in 'unsigned long'.
2864
31c286f7
PE
2865 * process.c (make_process): Use printmax_t, not int, to format
2866 process-name gensyms.
2867
55e5faa1
PE
2868 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2869
80f2e268
PE
2870 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2871 to avoid potential buffer overrun.
2872
670741ab
PE
2873 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2874 if X resource line is longer than 512 bytes.
2875
b7163a50
PE
2876 * xfns.c (x_window): Make sprintf buffer a bit bigger
2877 to avoid potential buffer overrun.
2878
ae58ff1f
PE
2879 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2880
c43c8a6a
PE
2881 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2882
3f8236f4
PE
28832011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2884
53e9fe90 2885 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2886 Without these, Emacs silently mishandles large integers sometimes.
2887 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2888 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2889
6511acf2
PE
2890 * xdisp.c (try_window_id): Check Emacs fixnum range before
2891 converting to 'int'.
806add1d 2892
6511acf2 2893 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2894 Check that an Emacs fixnum is in range before assigning it to 'int'.
2895 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2896 values converted from Emacs fixnums.
2897 (Frecenter): Don't wrap around a line count if it is out of 'int'
2898 range; instead, treat it as an extreme value.
2899 (Fset_window_configuration, compare_window_configurations):
2900 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2901
6511acf2
PE
2902 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2903 that can exceed INT_MAX. Check that EMACS_INT value is in range
2904 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2905 (match_limit): Don't assume that a fixnum can fit in 'int'.
2906
6511acf2 2907 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2908 exceed INT_MAX.
2909
6511acf2 2910 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2911 (Fvertical_motion): Don't wrap around LINES values that don't fit
2912 in 'int'. Instead, treat them as extreme values. This is good
2913 enough for windows, which can't have more than INT_MAX lines anyway.
2914
fcb901a7
LMI
29152011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2916
0f2f6b6d
LMI
2917 * Require libxml/parser.h to avoid compilation warning.
2918
fcb901a7
LMI
2919 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2920
2921 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2922 since this reportedly can destroy thread storage.
2923
6e20a0d4
CY
29242011-08-30 Chong Yidong <cyd@stupidchicken.com>
2925
2926 * syntax.c (find_defun_start): Update all cache variables if
2927 exiting early (Bug#9401).
2928
148ae00e
EZ
29292011-08-30 Eli Zaretskii <eliz@gnu.org>
2930
f6cfbd8f
EZ
2931 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2932
148ae00e
EZ
2933 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2934 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2935 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2936
2937 * term.c (tty_append_glyph): New function.
2938 (produce_stretch_glyph): Static function and its prototype deleted.
2939
a66cfb1c
SM
2940 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2941 Add prototypes.
148ae00e 2942
c4a07a4c
PE
29432011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2944
2945 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2946 when checking :margin (Bug#9390).
2947 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2948 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2949 so that the name doesn't mislead. All uses changed.
2950
6bc8cd65
JB
29512011-08-28 Johan Bockgård <bojohan@gnu.org>
2952
2953 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2954 set_tty_hooks.
2955
dca4927e
EZ
29562011-08-27 Eli Zaretskii <eliz@gnu.org>
2957
2958 * xdisp.c (move_it_to): Don't bail out early when reaching
2959 position beyond to_charpos, if we are scanning backwards.
2960 (move_it_vertically_backward): When DY == 0, make sure we get to
2961 the first character in the line after the newline.
2962
f2cad773
PE
29632011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2964
2965 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2966 (ccl_driver): Do not generate an out-of-range pointer.
2967 (Fccl_execute_on_string): Remove unnecessary check for
2968 integer overflow, noted by Stefan Monnier in
2969 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2970 Remove a FIXME that didn't need fixing.
2971 Simplify the newly-introduced buffer reallocation code.
2972
0cae2cdb
JB
29732011-08-27 Juanma Barranquero <lekktu@gmail.com>
2974
2975 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2976
5fc295a4 29772011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2978
70c60eb2 2979 Integer and memory overflow issues (Bug#9196).
726e0ab1 2980
d31850da
PE
2981 * doc.c (get_doc_string): Rework so that
2982 get_doc_string_buffer_size is the actual buffer size, rather than
2983 being 1 less than the actual buffer size; this makes xpalloc more
2984 convenient.
2985
a69fbedb
PE
2986 * image.c (x_allocate_bitmap_record, cache_image):
2987 * xselect.c (Fx_register_dnd_atom):
2988 Simplify previous changes by using xpalloc.
2989
fe5c5d37
PE
2990 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2991 since either will do and ptrdiff_t is convenient with xpalloc.
2992
0065d054
PE
2993 * charset.c (charset_table_size)
2994 (struct charset_sort_data.priority): Now ptrdiff_t.
2995 (charset_compare): Don't overflow if priorities differ greatly.
2996 (Fsort_charsets): Don't assume list length fits in int.
2997 Check for size-calculation overflow when allocating sort data.
2998 (syms_of_charset): Allocate an initial charset table that is
2999 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3000
3001 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3002
3003 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3004 The actual value is always <= INT_MAX, and leaving it unsigned made
3005 overflow checking harder.
3006
3007 * dispextern.h (struct glyph_matrix.rows_allocated)
3008 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3009 with xpalloc. The values are still always <= INT_MAX.
3010
3011 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3012
3013 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3014 (SAFE_NALLOCA): New macro.
3015
3016 * region-cache.c (struct boundary.pos, find_cache_boundary)
3017 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3018 (set_cache_region, invalidate_region_cache)
3019 (revalidate_region_cache, know_region_cache, region_cache_forward)
3020 (region_cache_backward, pp_cache):
3021 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3022 so that ptrdiff_t * can be passed to xpalloc.
3023 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3024 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3025 (pp_cache): Don't assume cache_len fits in int.
3026 * region-cache.h: Adjust extern decls to match.
3027
3028 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3029 EMACS_INT, since either will do, for xpalloc.
3030
3031 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3032 (xnmalloc, xnrealloc, xpalloc): New functions.
3033
726e0ab1
PE
3034 * bidi.c (bidi_shelve_header_size): New constant.
3035 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3036 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3037
51f30bc5 3038 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
3039 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3040 (overlay_strings):
3041 Don't update size of array until after memory allocation succeeds,
3042 because xmalloc/xrealloc may not return.
0065d054
PE
3043 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3044 now that we have proper integer overflow checking.
3045 (record_overlay_string, overlay_strings): Catch overflows when
3046 calculating size of overlay_str_buf.
726e0ab1 3047
0065d054
PE
3048 * callproc.c (Fcall_process): Check for size overflow when
3049 calculating size of args2.
3050 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3051 Normally we prefer signed values, but sticking with ptrdiff_t would
3052 require adding more-complicated checks.
726e0ab1
PE
3053
3054 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3055 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3056 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3057 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3058
3059 * character.c (Fstring): Check for size-calculation overflow.
3060
3061 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3062 unnecessary integer overflow. Check for size overflow.
3063 (encode_coding_object): Don't update size until xmalloc succeeds.
3064
3065 * composite.c (get_composition_id): Check for overflow in glyph
3066 length calculations.
3067
3068 Integer and memory overflow fixes for display code.
3069 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3070 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3071 (scrolling_window): Check for overflow in size calculations.
3072 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3073 Don't assume glyph table len fits in int.
3074 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3075 (row_table_size): Now ptrdiff_t, not int.
3076 (scrolling_window): Avoid overflow in size calculations.
3077 Don't update size until allocation succeeds.
3078 * fns.c (concat): Check for overflow in size calculations.
3079 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3080 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3081 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3082
3083 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3084 (get_doc_string): Check for size calculation overflow.
3085 Don't update size until allocation succeeds.
3086 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3087 EMACS_INT, where ptrdiff_t will do.
3088 (Fsubstitute_command_keys): Check for string overflow.
3089
3090 * editfns.c (set_time_zone_rule): Don't assume environment length
3091 fits in int.
3092 (message_length): Now ptrdiff_t, not int.
3093 (Fmessage_box): Don't update size until allocation succeeds.
3094 Don't assume message length fits in int.
3095 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3096
0065d054
PE
3097 * emacs.c (main): Do not reallocate argv, since there is a null at
3098 the end that can be overwritten, and this way there's no need to
3099 worry about size-calculation overflow.
3100 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3101
3102 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3103 alloc succeeds.
3104 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3105
3106 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3107 (x_set_scroll_bar_width, x_figure_window_size):
3108 Check for integer overflow.
3109 (x_set_alpha): Do not assume XINT fits in int.
3110
3111 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3112 This is for the members text_lines, text_cols, total_lines, total_cols,
3113 where the system imposes an 'int' limit.
3114
3115 * fringe.c (Fdefine_fringe_bitmap):
3116 Don't update size until alloc works.
3117
3118 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3119 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3120
3121 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3122 Check for size-calculation overflow.
3123 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3124 do, as we prefer signed integers.
3125 (id_to_widget.max_size, id_to_widget.used)
3126 (xg_store_widget_in_map, xg_remove_widget_from_map)
3127 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3128 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3129 Use and return ptrdiff_t, not int.
3130 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3131 * gtkutil.h: Change prototypes to match the above.
3132
3133 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3134 are duplicate now that they've been promoted to lisp.h.
3135 (x_allocate_bitmap_record, x_alloc_image_color)
3136 (make_image_cache, cache_image, xpm_load):
3137 Don't update size until alloc is done.
3138 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3139 (x_detect_edges):
3256efce 3140 Check for size calculation overflow.
726e0ab1
PE
3141 (ct_colors_allocated_max): New constant.
3142 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3143 overflow.
3256efce 3144
726e0ab1
PE
3145 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3146 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3147 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3148 Use ptrdiff_t, not int, to count maps.
3149 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3150 calculations. Don't update size until allocation succeeds.
3151 Redo calculations to avoid overflow.
726e0ab1
PE
3152 * keyboard.h: Change prototypes to match the above.
3153
3154 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3155 to count maps.
3156 (current_minor_maps): Check for size calculation overflow.
3157 * keymap.h: Change prototypes to match the above.
3158
3159 * lread.c (read1, init_obarray): Don't update size until alloc done.
3160
3161 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3162 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3163
726e0ab1
PE
3164 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3165 Now ptrdiff_t, not int.
3166 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3167 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3168
3169 * process.c (Fnetwork_interface_list): Check for overflow
3170 in size calculation.
3171
3172 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3173
3174 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3175 overflow. Don't bother calling xmalloc when xrealloc will do.
3176
3177 * search.c (Freplace_match): Check for size calculation overflow.
3178 (Fset_match_data): Don't assume list lengths fit in 'int'.
3179
3180 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3181 for command line length. Do not attempt to address one before the
3182 beginning of an array, as that's not portable.
3183
3184 * term.c (max_frame_lines): Remove; unused.
3185 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3186 not int.
3187 (encode_terminal_code, calculate_costs): Check for size
3188 calculation overflow.
3189 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3190 table lengths and related sizes. Don't update size until alloc
3191 done. Redo calculations to avoid overflow.
3192 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3193
3194 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3195 subtracting pointers.
3196 (gobble_line): Check for overflow more carefully. Don't update size
3197 until alloc done.
3198
3199 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3200 Don't update size until alloc done.
3201 Redo size calculations to avoid overflow.
3202 Check for size calculation overflow.
0065d054 3203 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3204
3205 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3206 Use ptrdiff_t, not int, for sizes.
3207 (store_mode_line_noprop_char): Don't update size until alloc done.
3208
0065d054
PE
3209 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3210 Use ptrdiff_t, not int, for sizes.
3211 (Finternal_make_lisp_face, cache_face):
3212 Check for size calculation overflow.
3213 (cache_face): Treat size calculation overflows as if they were
3214 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3215
3216 * xfns.c (x_encode_text, x_set_name_internal)
3217 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3218 sizes, since they can exceed INT_MAX in size. Check for size
3219 calculation overflow.
3220
0065d054
PE
3221 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3222 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3223 Don't update size until alloc done.
3224
0065d054 3225 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3226 as sprintf is limited to int lengths.
1d526e2f 3227
252c5ee1
PE
3228 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3229 (X_LONG_MIN): New macros.
864d7ce7
PE
3230 Use them to make the following changes clearer.
3231 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3232 This change doesn't affect the value now, but it may help remind
3233 future maintainers not to raise the value too much later.
3234 (SELECTION_QUANTUM): Remove, replacing with ...
3235 (selection_quantum): ... new function, which avoids overflow.
3236 All uses changed.
3237 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3238 assumption that selection length fits in 'int'.
3239 (x_reply_selection_request, x_handle_selection_request)
3240 (x_get_window_property, receive_incremental_selection)
3241 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3242 (lisp_data_to_selection_data, clean_local_selection_data):
3243 Use ptrdiff_t, not int, to record length of selection.
3244 (x_reply_selection_request, x_get_window_property)
3245 (receive_incremental_selection, x_property_data_to_lisp):
3246 Redo calculations to avoid overflow.
3247 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3248 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3249 something.
3250 (x_get_window_property, receive_incremental_selection)
3251 (lisp_data_to_selection_data, x_property_data_to_lisp):
3252 Check for size-calculation overflow.
3253 (x_get_window_property, receive_incremental_selection)
3254 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3255 Don't store size until memory allocation succeeds.
3256 (x_get_window_property): Plug memory leak on memory exhaustion.
3257 Don't double-block input; malloc is safe here. Don't assume 2**34
3258 - 4 fits in unsigned long. Add an xassert to check
3259 XGetWindowProperty overflow. Be more careful about overflow
3260 calculations, and distinguish size from memory overflow better.
3261 (receive_incremental_selection): When tracing, don't assume
3262 unsigned int is less than INT_MAX.
3263 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3264 harmful) conversions of unsigned short to int.
3265 (lisp_data_to_selection_data): Don't assume that integers
3266 in the range -65535 through -1 fit in an X unsigned short.
3267 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3268 result parameters unless successful. Rely on cons_to_unsigned
3269 to report problems with elements; the old code wasn't right anyway.
3270 (x_check_property_data): Check for int overflow; we cannot use
3271 a wider type due to X limits.
3272 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3273
726e0ab1 3274 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3275
0065d054
PE
3276 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3277 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3278 (x_color_cells): Don't store size until memory allocation succeeds.
3279 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3280 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3281 (x_term_init): Don't assume length fits in int (sprintf is limited
3282 to int size).
bc18e09d 3283
ebfa62c0
PE
3284 Use ptrdiff_t for composition IDs.
3285 * character.c (lisp_string_width):
3286 * composite.c (composition_table_size, n_compositions)
3287 (get_composition_id, composition_gstring_from_id):
3288 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3289 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3290 * window.c (Frecenter):
3291 Use ptrdiff_t, not int, for composition IDs.
3292 * composite.c (get_composition_id): Check for integer overflow.
3293 * composite.h: Adjust prototypes to match the above changes.
3294
d3411f89
PE
3295 Use ptrdiff_t for hash table indexes.
3296 * category.c (hash_get_category_set):
3297 * ccl.c (ccl_driver):
3298 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3299 * coding.c (coding_system_charset_list, detect_coding_system):
3300 * coding.h (struct coding_system.id):
3301 * composite.c (get_composition_id, gstring_lookup_cache):
3302 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3303 * image.c (xpm_get_color_table_h):
3304 * lisp.h (hash_lookup, hash_put):
3305 * minibuf.c (Ftest_completion):
3306 Use ptrdiff_t for hash table indexes, not int (which is too
3307 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3308 32-bit --with-wide-int hosts).
3309
e097a6fa
PE
3310 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3311 Add a FIXME comment about memory leaks.
3312 (syms_of_charset): Don't assume xmalloc returns.
3313
5637687f
PE
3314 Don't assume that stated character widths fit in int.
3315 * character.c (Fchar_width, c_string_width, lisp_string_width):
3316 * character.h (CHAR_WIDTH):
3317 * indent.c (MULTIBYTE_BYTES_WIDTH):
3318 Use sanitize_char_width to avoid undefined and/or bad behavior
3319 with outlandish widths.
a66cfb1c 3320 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3321 now that we have two such functions. All uses changed.
3322 (sanitize_char_width): New inline function.
3323
a2271ba2
PE
3324 Don't assume that tab-width fits in int.
3325 * character.h (sanitize_width): New inline function.
3326 (SANE_TAB_WIDTH): New macro.
3327 (ASCII_CHAR_WIDTH): Use it.
3328 * indent.c (sane_tab_width): Remove. All uses replaced by
3329 SANE_TAB_WIDTH (current_buffer).
3330 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3331
18c52557
PE
3332 * fileio.c: Integer overflow issues with file modes.
3333 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3334
caeeedc1
PE
3335 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3336 Remove unreachable code.
3337 (read_hex, load_charset_map_from_file): Check for integer overflow.
3338
6df6ae42 3339 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3340 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3341 (x_send_scroll_bar_event): Likewise. Check that the size does not
3342 exceed limits imposed by XClientMessageEvent, as well as the usual
3343 ptrdiff_t and size_t limits.
3344
b13995db
PE
3345 * keyboard.c: Overflow, signedness and related fixes.
3346 (make_lispy_movement): Use same integer type in forward decl
3347 that is used in the definition.
3348 (read_key_sequence, keyremap_step):
3349 Change bufsize argument back to int, undoing my 2011-03-30 change.
3350 We prefer signed types, and int is wide enough here.
3351 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3352 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3353 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3354 length, not size_t. Use ptrdiff_t for index, not int.
3355 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3356 possibility of integer overflow.
3357
13464394
PE
3358 Overflow, signedness and related fixes for images.
3359
3360 * dispextern.h (struct it.stack[0].u.image.image_id)
3361 (struct_it.image_id, struct image.id, struct image_cache.size)
3362 (struct image_cache.used, struct image_cache.ref_count):
3363 * gtkutil.c (update_frame_tool_bar):
3364 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3365 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3366 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3367 * nsmenu.m (update_frame_tool_bar):
3368 * xdisp.c (calc_pixel_width_or_height):
3369 * xfns.c (image_cache_refcount):
3370 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3371 on typical 64-bit hosts.
3372
3373 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3374 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3375 Omit unnecessary casts to int.
3376 (parse_image_spec): Check that integers fall into 'int' range
3377 when the callers expect that.
3378 (image_ascent): Redo ascent calculation to avoid int overflow.
3379 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3380 (lookup_image): Remove unnecessary tests.
3381 (xbm_image_p): Locals are now of int, not EMACS_INT,
3382 since parse_image_check makes sure they fit into int.
3383 (png_load, gif_load, svg_load_image):
3384 Prefer int to unsigned where either will do.
3385 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3386 old tiff_error_handler and tiff_warning_handler.
3387 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3388 stack buffer overflows. It uses only the features of vsnprintf
3389 that are common to both POSIX and native Microsoft.
3390 (tiff_error_handler, tiff_warning_handler): Use it.
3391 (tiff_load, gif_load, imagemagick_load_image):
3392 Don't assume :index value fits in 'int'.
3393 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3394 (imagemagick_load_image): Check that crop parameters fit into
3395 the integer types that MagickCropImage accepts. Don't assume
3396 Vimagemagick_render_type has a nonnegative value. Don't assume
3397 size_t fits in 'long'.
3398 (gs_load): Use printmax_t to print the widest integers possible.
3399 Check for integer overflow when computing image height and width.
3400
c11821d4
EZ
34012011-08-26 Eli Zaretskii <eliz@gnu.org>
3402
3403 * xdisp.c (redisplay_window): Don't force window start if point
3404 will be invisible in the resulting window. (Bug#9324)
3405
0c95fcf7
EZ
34062011-08-25 Eli Zaretskii <eliz@gnu.org>
3407
3408 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3409 the display spec is of the form `(space ...)'.
3410 (handle_display_spec): Return the value returned by
3411 handle_single_display_spec, not just 1 or zero.
3412 (handle_single_display_spec): If the display spec is of the form
3413 `(space ...)', and specifies display in the text area, return 2
3414 rather than 1.
fee65a97 3415 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3416 accurately, and prefer exact match for point under bidi.
3417 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3418
3419 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3420 into disp_prop; all users changed.
3421
3422 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3423 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3424 for the text covered by the display property.
3425
e4ed06f1
CY
34262011-08-25 Chong Yidong <cyd@stupidchicken.com>
3427
3428 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3429 Change return value to nil.
3430 (Frecord_buffer): Delete unused function.
3431
f67cdd7f
EZ
34322011-08-24 Eli Zaretskii <eliz@gnu.org>
3433
5980d4c6
EZ
3434 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3435 buffers, return left-to-right.
8610fe8b
EZ
3436 (set_cursor_from_row): Consider candidate row a win if its glyph
3437 represents a newline and point is on that newline. Fixes cursor
3438 positioning on the newline at EOL of R2L text within L2R
3439 paragraph, and vice versa.
3440 (try_cursor_movement): Check continued rows, in addition to
3441 continuation rows. Fixes unwarranted scroll when point enters a
3442 continued line of R2L text within an L2R paragraph, or vice versa.
3443 (cursor_row_p): Consider the case of point being equal to
3444 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3445 from the end of a short line to the beginning of a continued line
3446 of R2L text within L2R paragraph.
3447 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3448 composed characters.
5980d4c6 3449
f67cdd7f
EZ
3450 * bidi.c (bidi_check_type): Use xassert.
3451 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3452 members.
3453
bca633fb
EZ
34542011-08-23 Eli Zaretskii <eliz@gnu.org>
3455
3456 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3457 a character.
3458
4a5885a7
CY
34592011-08-23 Chong Yidong <cyd@stupidchicken.com>
3460
3461 * nsfont.m (ns_otf_to_script): Fix typo.
3462
0902a04e
KH
34632011-08-22 Kenichi Handa <handa@m17n.org>
3464
3465 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3466 extra slot even if the purpose is char-code-property-table.
3467
1a2e6670
EZ
34682011-08-23 Eli Zaretskii <eliz@gnu.org>
3469
8ddde651
EZ
3470 * xdisp.c (redisplay_window): When computing centering_position,
3471 account for the height of the header line. (Bug#8874)
3472
425cc014
EZ
3473 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3474 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3475 candidate is selected by the mouse, and that candidate has a
3476 composed character under the mouse.
3477
1a2e6670
EZ
3478 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3479 coordinates reported by pos-visible-in-window-p for a composed
3480 character in column zero.
3481
8b76d6f8
SM
34822011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3483
3484 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3485
dac347dd
EZ
34862011-08-22 Eli Zaretskii <eliz@gnu.org>
3487
3488 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3489 consider it a hit if to_charpos is anywhere in the range of the
3490 composed buffer positions.
3491
e013fb34
CY
34922011-08-22 Chong Yidong <cyd@stupidchicken.com>
3493
3494 * image.c (gif_load): Don't assume that each subimage has the same
3495 dimensions as the base image. Handle disposal method that is
3496 "undefined" by the gif spec (Bug#9335).
3497
bd1ba3e8
CY
34982011-08-20 Chong Yidong <cyd@stupidchicken.com>
3499
3500 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3501 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3502
54a1215b
EZ
35032011-08-19 Eli Zaretskii <eliz@gnu.org>
3504
823564e5
EZ
3505 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3506 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3507 from an Org mode buffer to a Speedbar frame.
3508
54a1215b
EZ
3509 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3510 a composition, take its buffer position from IT->cmp_it.charpos.
3511 Fixes cursor positioning at the beginning of a line that begins
3512 with a composed character.
3513
9778ebcc
EZ
35142011-08-18 Eli Zaretskii <eliz@gnu.org>
3515
0be6ee06
EZ
3516 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3517 character bidirectional type, use STRONG_L instead. Fixes crashes
3518 in a buffer produced by `describe-categories'.
3519
9778ebcc
EZ
3520 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3521 members before the level stack, so they would be saved and
3522 restored when copying iterator state. Fixes incorrect reordering
3523 around TABs covered by display properties.
3524
156bffbe
AS
35252011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3526
6b02f655 3527 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3528
72ad093b
CY
35292011-08-17 Chong Yidong <cyd@stupidchicken.com>
3530
3531 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3532 (internal_condition_case_2, internal_condition_case_n):
3533 Remove unnecessary aborts (Bug#9081).
72ad093b 3534
35774242
EZ
35352011-08-17 Eli Zaretskii <eliz@gnu.org>
3536
3537 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3538 has no `load' handler, try opening the file locally. (Bug#9311)
3539
db76dd85
KB
35402011-08-16 Ken Brown <kbrown@cornell.edu>
3541
3542 * gmalloc.c: Expand comment.
3543
b215eee5
EZ
35442011-08-16 Eli Zaretskii <eliz@gnu.org>
3545
3546 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3547 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3548
a4579d33
KB
35492011-08-16 Ken Brown <kbrown@cornell.edu>
3550
3551 Fix memory allocation problems in Cygwin build (Bug#9273).
3552
3553 * unexcw.c ( __malloc_initialized): Declare external variable.
3554 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3555
8b76d6f8
SM
3556 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3557 New variables.
a4579d33
KB
3558 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3559 dumped emacs.
3560 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3561 in the static heap.
3562 [CYGWIN] (special_realloc): New function.
3563 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3564 requests to realloc storage in the static heap.
3565
3ebec551
PE
35662011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3567
3568 * bidi.c (bidi_initialize): Remove unused local.
3569
9fd8be00
EZ
35702011-08-15 Eli Zaretskii <eliz@gnu.org>
3571
6b02f655
SM
3572 * bidimirror.h:
3573 * biditype.h: Remove file.
3574 * makefile.w32-in ($(BLD)/bidi.$(O)):
3575 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3576
3577 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3578
3579 * chartab.c: Improve commentary for the uniprop_table API.
3580
32413314
EZ
3581 * bidi.c (bidi_paragraph_init): Support zero value of
3582 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3583 (bidi_initialize): Use uniprop_table instead of including
3584 biditype.h and bidimirror.h.
32413314 3585
9fd8be00
EZ
3586 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3587 coordinates of the iterator when restoring from ppos_it.
3588 (Bug#9296)
3589
5cf2b69b
KH
35902011-08-14 Kenichi Handa <handa@m17n.org>
3591
3592 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3593 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3594
daf17d00
EZ
35952011-08-14 Eli Zaretskii <eliz@gnu.org>
3596
3597 * xdisp.c (move_it_in_display_line_to): Don't invoke
3598 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3599 ppos_it. Fixes vertical cursor motion when line beginning is
3600 covered by an image. (Bug#9296)
3601
08e3161a
JD
36022011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3603
3604 * nsterm.h (ns_run_ascript): Declare.
3605 (NSAPP_DATA2_RUNASSCRIPT): Define.
3606
3607 * nsfns.m (as_script, as_result, as_status): New static variables.
3608 (ns_run_ascript): New function.
5e617bc2 3609 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3610 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3611 the event loop. Get status from as_status (Bug#7276).
3612
3613 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3614 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3615 the event loop (Bug#7276).
3616
a3720aa2
AS
36172011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3618
3619 * gnutls.c (QCgnutls_bootprop_priority)
3620 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3621 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3622 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3623 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3624 (QCgnutls_bootprop_verify_hostname_error)
3625 (QCgnutls_bootprop_callbacks_verify): Rename from
3626 Qgnutls_bootprop_..., all uses changed.
3627
3628 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3629 uses changed.
3630
0a0d27fb
PE
36312011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3632
19d5c50c
PE
3633 * xfaces.c (Qframe_set_background_mode): Now static.
3634 * dispextern.h (Qframe_set_background_mode): Remove decl.
3635
0a0d27fb
PE
3636 * process.c (Fnetwork_interface_info): Declare local only if needed.
3637
377538cb
JD
36382011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3639
3640 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3641 (Fnetwork_interface_list): Allocate in increments of bytes instead
3642 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3643 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3644 sockaddr.
3645 (struct ifflag_def): notrailers is smart on OSX.
3646 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3647 Get hardware address with getifaddrs if available.
3648
08fff70c
EZ
36492011-08-12 Eli Zaretskii <eliz@gnu.org>
3650
3651 * xdisp.c (iterate_out_of_display_property): xassert that
3652 IT->position is set to within IT->object's boundaries. Break from
3653 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3654 when IT->position is set up wrongly due to some bug.
3655 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3656 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3657 entry. Force push_it to save on the stack the current
3658 buffer/string position, to be restored by pop_it. Fix flags in
3659 the iterator structure wrt the object coming from a display
3660 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3661 properties. (Bug#9284)
3662
7be1c708 36632011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3664
7be1c708
CY
3665 * fontset.c (fontset_get_font_group): Add proper type checks.
3666 (Bug#9172)
aac0c6e3 3667
7be1c708 36682011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3669
7be1c708
CY
3670 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3671 and LC_VERSION_MIN_MACOSX.
3672 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3673 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3674
97bb72a6
EZ
36752011-08-08 Eli Zaretskii <eliz@gnu.org>
3676
3677 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3678 no-display-properties-and-no-overlays under bidi display.
3679 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3680 properties and overlays.
97bb72a6 3681
d5617611
CY
36822011-08-08 Chong Yidong <cyd@stupidchicken.com>
3683
37e11a63
CY
3684 * editfns.c (Fset_time_zone_rule): Document relationship with the
3685 setenv function.
3686
d5617611
CY
3687 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3688 the font entity extracted from the cache (Bug#8109).
3689
58872834
CY
36902011-08-07 Chong Yidong <cyd@stupidchicken.com>
3691
3692 * composite.c (autocmp_chars): Don't reset point. That is done by
3693 restore_point_unwind (Bug#5984).
3694
75bfc667
JL
36952011-08-07 Juri Linkov <juri@jurta.org>
3696
3697 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3698 to show the arg `TIME' instead of `TIMEVAL'.
3699
d1410150
EZ
37002011-08-06 Eli Zaretskii <eliz@gnu.org>
3701
3702 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3703 display property strides EOL and includes a newline, as in
3704 longlines-mode. (Bug#9254)
75b771e4
EZ
3705 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3706 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3707
3708 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3709 is non-zero, even if the data buffer is NULL. Fixes a crash in
3710 vertical-motion with longlines-mode. (Bug#9254)
3711
35928349
EZ
37122011-08-05 Eli Zaretskii <eliz@gnu.org>
3713
ec7cc85b
EZ
3714 * bidi.c <bidi_cache_total_alloc>: Now static.
3715 (bidi_initialize): Initialize bidi_cache_total_alloc.
3716
8b76d6f8 3717 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3718 cache. (Bug#9221)
3719
3720 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3721 amount allocated this far in `bidi_cache_total_alloc'.
3722 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3723 non-zero, only free the data buffer without restoring the cache
3724 contents. All callers changed.
3725
3726 * dispextern.h (bidi_unshelve_cache): Update prototype.
3727
3728 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3729 (move_it_in_display_line, move_it_to)
3730 (move_it_vertically_backward, move_it_by_lines): Replace the call
3731 to xfree to an equivalent call to bidi_unshelve_cache.
3732 (move_it_in_display_line_to): Fix logic of returning
412b6358 3733 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3734
e2e2423b
EZ
37352011-08-05 Eli Zaretskii <eliz@gnu.org>
3736
3737 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3738 came from a string character with a `cursor' property. (Bug#9229)
3739
ae9e757a
JD
37402011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3741
3742 * Makefile.in (LIB_PTHREAD): New variable.
3743 (LIBES): Add LIB_PTHREAD (Bug#9216).
3744
3745 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3746 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3747
213bd7f2
AS
37482011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3749
6b02f655 3750 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3751
99aaf75f
JD
37522011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3753
3754 * xterm.c (x_find_topmost_parent): New function.
3755 (x_set_frame_alpha): Find topmost parent window with
3756 x_find_topmost_parent and set the property there also (bug#9181).
3757 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3758
c74e9d86
PE
37592011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3760
3761 * callproc.c (Fcall_process): Avoid vfork clobbering
3762 the local vars buffer, coding_systems, current_dir.
3763
640c8776
SM
37642011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3765
3766 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3767
f26d0e4c
PE
37682011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3769
8a10d76c
PE
3770 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3771 so that it is not optimized away.
3772
f26d0e4c
PE
3773 * xdisp.c (compute_display_string_pos): Remove unused local.
3774
55439c61
EZ
37752011-08-02 Eli Zaretskii <eliz@gnu.org>
3776
3777 Fix slow cursor motion and scrolling in large buffers with
3778 selective display, like Org Mode buffers. (Bug#9218)
3779
3780 * dispextern.h (struct bidi_it): New member disp_prop_p.
3781
3782 * xdisp.c: Remove one-slot cache of display string positions.
3783 (compute_display_string_pos): Accept an additional argument
5e617bc2 3784 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3785 for a display string or property. If found, set DISP_PROP_P
3786 non-zero.
3787
3788 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3789 DISP_PROP_P, and pass it to compute_display_string_pos.
3790 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3791 non-zero. All callers of bidi_fetch_char changed.
3792
fb33fa43
SM
37932011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3794
3795 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3796
b099e063
DM
37972010-12-03 Don March <don@ohspite.net>
3798
3799 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3800 last character M-[char] is translated to ESC [char] (bug#7541).
3801
5cc7f7af
KH
38022011-08-02 Kenichi Handa <handa@m17n.org>
3803
d0fffa3f 3804 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3805
3806 * chartab.c (uniprop_table): Make it non-static.
3807
525d5e6e
EZ
38082011-08-01 Eli Zaretskii <eliz@gnu.org>
3809
3810 * xdisp.c (forward_to_next_line_start): Accept additional argument
3811 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3812 on the newline.
3813 (reseat_at_next_visible_line_start): Use the bidi iterator state
3814 returned by forward_to_next_line_start to restore the state of
3815 it->bidi_it after backing up to previous newline. (Bug#9212)
3816
31011111
AS
38172011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3818
3819 * regex.c (re_comp): Protoize.
3820 (re_exec): Fix return type.
3821 (regexec): Fix type of `ret'. (Bug#9203)
3822
476371c4
PE
38232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3824
e5d76069
PE
3825 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3826 This is needed if max-image-size is a floating-point number.
3827
9a79b20c
AS
38282011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3829
3830 * print.c (print_object): Print empty symbol as ##.
3831
3832 * lread.c (read1): Read ## as empty symbol.
3833
d8c2fa78
AA
38342011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3835
3836 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3837 setting frame foreground color (Bug#9175).
3838 (x_set_background_color): Likewise.
3839
ffe57a7a
AA
3840 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3841 contents (Bug#9176).
3842 (EmacsTooltip -init): Remove bezels and add shadows to
3843 tooltip windows.
3844
bf3492a5
AA
3845 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3846 or scroll bar (Bug#8470).
3847
d55e9c53
AA
3848 * nsfont.m (nsfont_open): Remove assignment to voffset and
3849 unnecessary vars hshink, expand, hd, full_height, min_height.
3850 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3851
3852 * nsterm.h (nsfont_info): Remove voffset field.
3853
d8c2fa78 38542011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3855
3856 Implement strike-through and overline on NextStep (Bug#8863).
3857
3858 * nsfont.m (nsfont_open): Use underline position provided by font,
3859 instead of hard-coded value of 2.
3860 (nsfont_draw): Call ns_draw_text_decoration instead.
3861
3862 * nsterm.h: Add declaration for ns_draw_text_decoration.
3863
3864 * nsterm.m (ns_draw_text_decoration): New function for drawing
3865 underline, overline, and strike-through.
3866 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3867 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3868 accommodate underlining, etc.
4843aac3 3869
4cc60b9b
EZ
38702011-07-28 Eli Zaretskii <eliz@gnu.org>
3871
bc7ece87
EZ
3872 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3873 default.
4cc60b9b 3874
476371c4
PE
38752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3876
66606eea
PE
3877 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3878 Without this fix, if a signal arrives just after memory fills up,
3879 'malloc' might be invoked reentrantly.
3880
476371c4
PE
3881 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3882 In other words, assume that every image size is allowed, on non-X
3883 hosts. This assumption is probably wrong, but it lets Emacs compile.
3884
f3fcc40d
AS
38852011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3886
3887 * regex.c (re_iswctype): Convert return values to boolean.
3888
350c992f
EZ
38892011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3890
3891 * xdisp.c (compute_display_string_pos): Don't use cached display
3892 string position if the buffer had its restriction changed.
3893 (Bug#9184)
3894
5266b4bb
PE
38952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3896
3897 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3898
2573a837 38992011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3900
41f55ccd 3901 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3902
39e378da
PE
3903 * bidi.c: Integer size and overflow fixes.
3904 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3905 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3906 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3907 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3908 (bidi_find_other_level_edge):
3909 Use ptrdiff_t instead of EMACS_INT where either will do.
3910 This works better on 32-bit hosts configured --with-wide-int.
3911 (bidi_cache_ensure_space): Check for size-calculation overflow.
3912 Use % rather than repeated addition, for better worst-case speed.
3913 Don't set bidi_cache_size until after xrealloc returns, because it
3914 might not return.
3915 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3916 (bidi_cache_ensure_space): Also check that the bidi cache size
3917 does not exceed that of the largest Lisp string or buffer. See Eli
3918 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3919
5e927815
PE
3920 * alloc.c (__malloc_size_t): Remove.
3921 All uses replaced by size_t. See Andreas Schwab's note
3922 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3923
ca4aa935
PE
3924 * image.c: Improve checking for integer overflow.
3925 (check_image_size): Assume that f is nonnull, since
3926 it is always nonnull in practice. This is one less thing to
3927 worry about when checking for integer overflow later.
3928 (x_check_image_size): New function, which checks for integer
3929 overflow issues inside X.
3930 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3931 This removes the need for a memory_full check.
3932 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3933 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3934 (xbm_read_bitmap_data): Change locals back to 'int', since
3935 their values must fit in 'int'.
3936 (xpm_load_image, png_load, tiff_load):
3937 Invoke x_create_x_image_and_pixmap earlier,
3938 to avoid much needless work if the image is too large.
3939 (tiff_load): Treat overly large images as if
3940 x_create_x_image_and_pixmap failed, not as malloc failures.
3941 (gs_load): Use x_check_image_size.
3942
5f8f9cc2
PE
3943 * gtkutil.c: Omit integer casts.
3944 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3945 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3946
5adf60bc
PE
3947 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3948
c8907a93
PE
3949 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3950 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3951 would wrongly return t on a 64-bit host.
3952
e3c25c68
PE
3953 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3954 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3955 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3956 and therefore cause GCC to emit a bogus diagnostic in some cases.
3957
3f791afe
PE
3958 * image.c: Integer signedness and overflow and related fixes.
3959 This is not an exhaustive set of fixes, but it's time to
3960 record what I've got.
3961 (lookup_pixel_color, check_image_size): Remove redundant decls.
3962 (check_image_size): Don't assume that arbitrary EMACS_INT values
3963 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3964 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3965 (tiff_load, imagemagick_load_image):
3966 Check for overflow in size calculations.
3967 (x_create_x_image_and_pixmap): Remove unnecessary test for
3968 xmalloc returning NULL; that can't happen.
3969 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3970 (xpm_color_bucket): Use better integer hashing function.
3971 (xpm_cache_color): Don't possibly over-allocate memory.
3972 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3973 (gif_memory_source):
3974 Use ptrdiff_t, not int or size_t, to record sizes.
3975 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3976 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3977 either works, as we prefer signed integers.
3978 (tiff_read_from_memory, tiff_write_from_memory):
3979 Return tsize_t, not size_t, since that's what the TIFF API wants.
3980 (tiff_read_from_memory): Don't fail simply because the read would
3981 go past EOF; instead, return a short read.
3982 (tiff_load): Omit no-longer-needed casts.
3983 (Fimagemagick_types): Don't assume size fits into 'int'.
3984
3cc5a532
PE
3985 Improve hashing quality when configured --with-wide-int.
3986 * fns.c (hash_string): New function, taken from sxhash_string.
3987 Do not discard information about ASCII character case; this
3988 discarding is no longer needed.
3989 (sxhash-string): Use it. Change sig to match it. Caller changed.
3990 * lisp.h: Declare it.
3991 * lread.c (hash_string): Remove, since we now use fns.c's version.
3992 The fns.c version returns a wider integer if --with-wide-int is
3993 specified, so this should help the quality of the hashing a bit.
3994
b312a492
PE
3995 * emacs.c: Integer overflow minor fix.
3996 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3997 Define only if GNU_LINUX.
3998 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3999
dfd153ae
PE
4000 * dispnew.c: Integer signedness and overflow fixes.
4001 Remove unnecessary forward decls, that were a maintenance hassle.
4002 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4003 All uses changed.
4004 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4005 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4006 (prepare_desired_row, line_draw_cost):
4007 Use int, not unsigned, where either works.
4008 (save_current_matrix, restore_current_matrix):
4009 Use ptrdiff_t, not size_t, where either works.
4010 (init_display): Check for overflow more accurately, and without
4011 relying on undefined behavior.
4012
a81d11a3
PE
4013 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4014 Remove, replacing with the new symbols in lisp.h. All uses changed.
4015 * fileio.c (make_temp_name):
4016 * filelock.c (lock_file_1, lock_file):
4017 * xdisp.c (message_dolog):
4018 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4019 Use pMd etc. instead.
4020 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4021 replacing the pWIDE etc. symbols removed from editfns.c.
4022
3300e6fd
PE
4023 * keyboard.h (num_input_events): Now uintmax_t.
4024 This is (very slightly) less likely to mess up due to wraparound.
4025 All uses changed.
4026
fd05c7e9
PE
4027 * buffer.c: Integer signedness fixes.
4028 (alloc_buffer_text, enlarge_buffer_text):
4029 Use ptrdiff_t rather than size_t when either will do, as we prefer
4030 signed integers.
4031
903fe15d
PE
4032 * alloc.c: Integer signedness and overflow fixes.
4033 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4034 (__malloc_size_t): Default to size_t, not to int.
4035 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4036 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4037 Prefer ptrdiff_t to size_t when either would do, as we prefer
4038 signed integers.
4039 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4040 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4041 Now const. Initialize with values that are in range even if char
4042 is signed.
4043 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4044 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4045 These functions do the right thing with sizes > 2**32.
4046 (check_depth): Now ptrdiff_t, not int.
4047 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4048 Adjust to new way of storing sizes. Check for size overflow bugs
4049 in rest of code.
4050 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4051 slightly wrong anyway, as it missed one instance of
4052 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4053 (refill_memory_reserve): Omit needless cast to size_t.
4054 (mark_object_loop_halt): Mark as externally visible.
4055
ac82cc6a
PE
4056 * xselect.c: Integer signedness and overflow fixes.
4057 (Fx_register_dnd_atom, x_handle_dnd_message):
4058 Use ptrdiff_t, not size_t, since we prefer signed.
4059 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4060 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4061 x_dnd_atoms_size and x_dnd_atoms_length.
4062
c2d1e36d
PE
4063 * doprnt.c: Prefer signed to unsigned when either works.
4064 * eval.c (verror):
4065 * doprnt.c (doprnt):
4066 * lisp.h (doprnt):
4067 * xdisp.c (vmessage):
4068 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4069 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4070 prefer signed arithmetic to avoid comparison confusion.
4071 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4072 but is a bit tricky.
4073
0e926e56
PE
4074 Assume freestanding C89 headers, string.h, stdlib.h.
4075 * data.c, doprnt.c, floatfns.c, print.c:
4076 Include float.h unconditionally.
4077 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4078 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4079 * regex.c: Likewise for stddef.h, string.h.
4080 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4081 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4082 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4083 (STDC_HEADERS): Remove obsolete defines.
4084 * sysdep.c: Include limits.h unconditionally.
4085
9cfdb3ec
PE
4086 Assume support for memcmp, memcpy, memmove, memset.
4087 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4088 * regex.c (memcmp, memcpy):
4089 Remove; we assume C89 now.
4090
4091 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4092 (__malloc_safe_bcopy): Remove; no longer needed.
4093
cf950e6b 4094 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4095 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4096 well either way, and we prefer signed to unsigned.
4097
dbf38e02
LMI
40982011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4099
4100 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4101 closes the connection while we're reading (bug#9182).
4102
d6f0886c 41032011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4104
d6f0886c
JD
4105 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4106 are specified (Bug#9168).
24e0f6b1 4107
2eb1f9e6
PE
41082011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4109
4110 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4111 Found by GCC static checking and --with-wide-int on a 32-bit host.
4112
22381272 41132011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4114
4115 * xdisp.c (compute_display_string_pos): Fix logic of caching
4116 previous display string position. Initialize cached_prev_pos to
4117 -1. Fixes slow-down at the beginning of a buffer.
4118
f25e39b4
EZ
41192011-07-24 Eli Zaretskii <eliz@gnu.org>
4120
4121 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4122 for attrs[LFACE_FONTSET_INDEX].
4123
04c4b52e
PE
41242011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4125
4126 * xml.c (parse_region): Remove unused local
4127 that was recently introduced.
4128
c1734fbd
EZ
41292011-07-23 Eli Zaretskii <eliz@gnu.org>
4130
be18c5a5
EZ
4131 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4132 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4133
c1734fbd
EZ
4134 * xdisp.c (move_it_in_display_line_to): Record the best matching
4135 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4136 exit if none of the characters scanned was an exact match.
4137 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4138 when exact match is impossible due to invisible text, and the
4139 lines are truncated.
4140
a258d627
JD
41412011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4142
4143 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4144 for OSX >= 10.7.
4145
b6d5a689
EZ
41462011-07-22 Eli Zaretskii <eliz@gnu.org>
4147
0f74f785
EZ
4148 Fix a significant slow-down of cursor motion with C-n, C-p,
4149 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4150 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4151 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4152 (next_element_from_buffer): Call compute_stop_pos_backwards to
4153 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4154 base_level_stop.
4155 (reseat): Don't look for prev_stop, as that could mean a very long
4156 run.
4157 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4158 <cached_disp_overlay_modiff>: Cache for last found display string
4159 position.
551918c1 4160 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4161 about the same buffer in the same area of character positions, and
4162 the buffer wasn't changed since the time the display string
4163 position was cached.
551918c1 4164
b2d0c91a
EZ
41652011-07-22 Eli Zaretskii <eliz@gnu.org>
4166
4167 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4168 is an integer, which is important for empty lines. (Bug#9149)
4169
043604ee
CY
41702011-07-22 Chong Yidong <cyd@stupidchicken.com>
4171
4172 * frame.c (Fmodify_frame_parameters): In tty case, update the
4173 default face if necessary (Bug#4238).
4174
da4adb04
CY
41752011-07-21 Chong Yidong <cyd@stupidchicken.com>
4176
4177 * editfns.c (Fstring_to_char): No need to explain what a character
4178 is in the docstring (Bug#6576).
4179
9abd0532
LMI
41802011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4181
4182 * xml.c (parse_region): Make sure we always return a tree.
4183
36881d16
HK
41842011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4185
4186 * xml.c (parse_region): If a document contains only comments,
4187 return that, too.
4188
1e98674d
LMI
41892011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4190
4191 * xml.c (make_dom): Return comments, too.
4192
590bd467
PE
41932011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4194
4195 Port to OpenBSD.
4196 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4197 and the surrounding thread.
4198 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4199 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4200 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4201 timer goes off.
4202 * s/openbsd.h (BROKEN_SIGIO): Define.
4203 * unexelf.c (unexec) [__OpenBSD__]:
4204 Don't update the .mdebug section of the Alpha COFF symbol table.
4205
f41628b2
LMI
42062011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4207
4208 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4209 (bug#8460).
4210
b59b67c5
PE
42112011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4212
15e3a074
PE
4213 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4214 This fixes some race conditions on the permissions of any newly
4215 created file.
4216
41bed37d
PE
4217 * alloc.c (valid_pointer_p): Use pipe, not open.
4218 This fixes some permissions issues when debugging.
4219
b59b67c5
PE
4220 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4221 If fchown fails to set both uid and gid, try to set just gid,
4222 as that is sometimes allowed. Adjust the file's mode to eliminate
4223 setuid or setgid bits that are inappropriate if fchown fails.
4224
925a6be7
SM
42252011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4226
4227 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4228 to compare Lisp_Objects.
4229 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4230 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4231 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4232
52968808
AS
42332011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4234
0a6a104b
AS
4235 * lread.c (read_integer): Unread even EOF character.
4236 (read1): Likewise. Properly record start position of symbol.
4237
52968808
AS
4238 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4239 symbol character follows.
4240
9e381cdd
PE
42412011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4242
4243 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4244 This works around a problem with the previous change to Fcopy_file.
4245 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4246 and without this change, GCC might complain about discarding
4247 fchown's return value.
4248
b5641435
JB
42492011-07-16 Juanma Barranquero <lekktu@gmail.com>
4250
4251 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4252
a8031457
PE
42532011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4254
4255 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4256
dd889327
LMI
42572011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4258
750c33f7
LMI
4259 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4260 it's used from the C level.
4261
dd889327
LMI
4262 * process.c: Use the same condition for POLL_FOR_INPUT in both
4263 keyboard.c and process.c (bug#1858).
4264
87e86684
LM
42652011-07-09 Lawrence Mitchell <wence@gmx.li>
4266
4267 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4268 (Fgnutls_boot): Use it.
4269
64348f40
AS
42702011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4271
4272 * doc.c (Fsubstitute_command_keys): Revert last change.
4273
1d698799
LMI
42742011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4275
f863868c
LMI
4276 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4277 quotes the next character, and doesn't affect other longer
4278 sequences (bug#8935).
4279
1d698799
LMI
4280 * lread.c (syms_of_lread): Clarify that is isn't only
4281 `eval-buffer' and `eval-defun' that's affected by
4282 `lexical-binding' (bug#8460).
4283
aa4b6df6
EZ
42842011-07-15 Eli Zaretskii <eliz@gnu.org>
4285
4286 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4287 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4288
5d856da6
PE
42892011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4290
ad6042bb
PE
4291 Fix minor problems found by static checking.
4292 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4293 (elsz): Now a signed constant, not a size_t var. We prefer signed
4294 types to unsigned, to avoid integer comparison confusion. Without
4295 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4296 "cannot optimize loop, the loop counter may overflow", a symptom
4297 of the confusion.
f00bbb22 4298 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4299 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4300
6468f31c
LMI
43012011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4302
49080b10
LMI
4303 * search.c (Fre_search_backward): Mention `case-fold-search' in
4304 all the re_search_* functions (bug#8138).
4305
6468f31c
LMI
4306 * keyboard.c (Fopen_dribble_file): Document when the file is
4307 closed (bug#8056).
4308
c965adc5
EZ
43092011-07-14 Eli Zaretskii <eliz@gnu.org>
4310
df9733bf
EZ
4311 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4312 bidi_cache_idx.
4313
0bb23927
EZ
4314 Support bidi reordering of display and overlay strings.
4315 * xdisp.c (compute_display_string_pos)
4316 (compute_display_string_end): Accept additional argument STRING.
4317 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4318 (reseat_to_string): Initialize bidi_it->string.s and
4319 bidi_it->string.schars.
4320 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4321 NULL (avoids a crash in bidi_paragraph_init).
4322 Initialize itb.string.lstring.
0bb23927
EZ
4323 (init_iterator): Call bidi_init_it only of a valid
4324 buffer position was specified. Initialize paragraph_embedding to
4325 L2R.
4326 (reseat_to_string): Initialize the bidi iterator.
4327 (display_string): If we need to ignore text properties of
4328 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4329 original value of -1 will not work with bidi.)
4330 (compute_display_string_pos): First arg is now struct
4331 `text_pos *'; all callers changed. Support display properties on
4332 Lisp strings.
4333 (compute_display_string_end): Support display properties on Lisp
4334 strings.
4335 (init_iterator, reseat_1, reseat_to_string): Initialize the
4336 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4337 when iterating on a string not from display properties).
640c8776
SM
4338 (compute_display_string_pos, compute_display_string_end):
4339 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4340 arrow keys.
4341 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4342 base_level_stop; instead, set base_level_stop to BEGV.
4343 Fixes crashes in vertical-motion.
0bb23927
EZ
4344 (next_element_from_buffer): Improve commentary for when
4345 the iterator is before prev_stop.
4346 (init_iterator): Initialize bidi_p from the default value of
4347 bidi-display-reordering, not from buffer-local value. Use the
4348 buffer-local value only if initializing for buffer iteration.
4349 (handle_invisible_prop): Support invisible properties on strings
4350 that are being bidi-reordered.
4351 (set_iterator_to_next): Support bidi reordering of C strings and
4352 Lisp strings.
4353 (next_element_from_string): Support bidi reordering of Lisp
4354 strings.
4355 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4356 (display_string): Support display of R2L glyph rows.
4357 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4358 (init_iterator): Don't initialize it->bidi_p for strings
4359 here.
4360 (reseat_to_string): Initialize it->bidi_p for strings here.
4361 (next_element_from_string, next_element_from_c_string)
4362 (next_element_from_buffer): Add xassert's for correspondence
4363 between IT's object being iterated and it->bidi_it.string
4364 structure.
4365 (face_before_or_after_it_pos): Support bidi iteration.
4366 (next_element_from_c_string): Handle the case of the first string
4367 character that is not the first one in the visual order.
4368 (get_visually_first_element): New function, refactored from common
4369 parts of next_element_from_buffer, next_element_from_string, and
4370 next_element_from_c_string.
4371 (tool_bar_lines_needed, redisplay_tool_bar)
4372 (display_menu_bar): Force left-to-right direction. Add a FIXME
4373 comment for making that be controlled by a user option.
4374 (push_it, pop_it): Save and restore the state of the
4375 bidi iterator. Save and restore the bidi_p flag.
4376 (pop_it): Iterate out of display property for string iteration as
4377 well.
4378 (iterate_out_of_display_property): Support iteration over strings.
4379 (handle_single_display_spec): Set up it->bidi_it for iteration
4380 over a display string, and call bidi_init_it.
4381 (handle_single_display_spec, next_overlay_string)
4382 (get_overlay_strings_1, push_display_prop): Set up the bidi
4383 iterator for displaying display or overlay strings.
4384 (forward_to_next_line_start): Don't use the shortcut if
4385 bidi-iterating.
4386 (back_to_previous_visible_line_start): If handle_display_prop
4387 pushed the iterator stack, restore the internal state of the bidi
4388 iterator by calling bidi_pop_it same number of times.
4389 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4390 and we are bidi-iterating, don't decrement the iterator position;
4391 instead, set the first_elt flag in the bidi iterator, to produce
4392 the same effect.
4393 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4394 (push_display_prop): xassert that we are iterating a buffer.
4395 (push_it, pop_it): Save and restore paragraph_embedding member.
4396 (handle_single_display_spec, next_overlay_string)
4397 (get_overlay_strings_1, reseat_1, reseat_to_string)
4398 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4399 correctly. Don't assume unibyte strings are not bidi-reordered.
4400 (compute_display_string_pos)
4401 (compute_display_string_end): Fix handling the case of C string.
4402 (push_it, pop_it): Save and restore from_disp_prop_p.
4403 (handle_single_display_spec, push_display_prop): Set the
4404 from_disp_prop_p flag.
4405 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4406 (pop_it): Call iterate_out_of_display_property only if we are
4407 popping after iteration over a string that came from a display
4408 property. Fix a typo in popping stretch info. Add an assertion
4409 for verifying that the iterator position is in sync with the bidi
4410 iterator.
4411 (handle_single_display_spec, get_overlay_strings_1)
4412 (push_display_prop): Fix initialization of paragraph direction for
4413 string when that of the parent object is not yet determined.
4414 (reseat_1): Call bidi_init_it to resync the bidi
4415 iterator with IT's position. (Bug#7616)
4416 (find_row_edges): If ROW->start.pos gives position
4417 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4418 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4419 Reset the from_disp_prop_p flag.
4420 (SAVE_IT, RESTORE_IT): New macros.
4421 (pos_visible_p, face_before_or_after_it_pos)
4422 (back_to_previous_visible_line_start)
4423 (move_it_in_display_line_to, move_it_in_display_line)
4424 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4425 (try_scrolling, redisplay_window, display_line): Use them when
4426 saving a temporary copy of the iterator and restoring it back.
4427 (back_to_previous_visible_line_start, reseat_1)
4428 (init_iterator): Empty the bidi cache "stack".
4429 (move_it_in_display_line_to): If iterator ended up at
4430 EOL, but we never saw any buffer positions smaller than
4431 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4432 motion in bidi-reordered lines.
4433 (move_it_in_display_line_to): Record prev_method and prev_pos
4434 immediately before the call to set_iterator_to_next. Fixes cursor
4435 motion in bidi-reordered lines with stretch glyphs and strings
4436 displayed in margins. (Bug#8133) (Bug#8867)
4437 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4438 TO_CHARPOS.
640c8776
SM
4439 (pos_visible_p): Support positions in bidi-reordered lines.
4440 Save and restore bidi cache.
0bb23927
EZ
4441
4442 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4443 (bidi_paragraph_info): Delete unused struct.
4444 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4445 (bidi_cache_start): New variable.
4446 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4447 to zero.
4448 (bidi_cache_fetch_state, bidi_cache_search)
4449 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4450 (bidi_cache_find, bidi_peek_at_next_level)
4451 (bidi_level_of_next_char, bidi_find_other_level_edge)
4452 (bidi_move_to_visually_next): Compare cache index with
4453 bidi_cache_start rather than with zero.
4454 (bidi_fetch_char): Accept new argument STRING; all callers
4455 changed. Support iteration over a string. Support strings with
4456 display properties. Support unibyte strings. Fix the type of
4457 `len' according to what STRING_CHAR_AND_LENGTH expects.
4458 (bidi_paragraph_init, bidi_resolve_explicit_1)
4459 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4460 (bidi_level_of_next_char, bidi_move_to_visually_next):
4461 Support iteration over a string.
0bb23927
EZ
4462 (bidi_set_sor_type, bidi_resolve_explicit_1)
4463 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4464 can now be zero (for strings); special values 0 and -1 were
4465 changed to -1 and -2, respectively.
4466 (bidi_char_at_pos): New function.
4467 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4468 Call it instead of FETCH_MULTIBYTE_CHAR.
4469 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4470 initialized to valid values.
4471 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4472 values.
4473 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4474 the test for valid cached positions. Fix the logic for looking up
4475 the sentinel state in the cache. GCPRO the Lisp string we are
4476 iterating.
4477 (bidi_push_it, bidi_pop_it): New functions.
4478 (bidi_initialize): Initialize the bidi cache start stack pointer.
4479 (bidi_cache_ensure_space): New function, refactored from part of
4480 bidi_cache_iterator_state. Don't assume the required size is just
4481 one BIDI_CACHE_CHUNK away.
4482 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4483 (bidi_count_bytes, bidi_char_at_pos): New functions.
4484 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4485 always valid if bidi_cache_idx is valid.
4486 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4487 is valid if it's going to be used.
4488 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4489 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4490 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4491 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4492 (bidi_find_other_level_edge, bidi_cache_start_stack):
4493 All variables related to cache indices are now EMACS_INT.
c965adc5 4494
0bb23927
EZ
4495 * dispextern.h (struct bidi_string_data): New structure.
4496 (struct bidi_it): New member `string'. Make flag members be 1-bit
4497 fields, and put them last in the struct.
640c8776
SM
4498 (compute_display_string_pos, compute_display_string_end):
4499 Update prototypes.
0bb23927
EZ
4500 (bidi_push_it, bidi_pop_it): Add prototypes.
4501 (struct iterator_stack_entry): New members bidi_p,
4502 paragraph_embedding, and from_disp_prop_p.
4503 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4504 (bidi_shelve_cache, bidi_unshelve_cache):
4505 Declare prototypes.
0bb23927
EZ
4506
4507 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4508 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4509 and vector-like objects.
4510
4511 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4512 cache around display iteration.
4513
4514 * window.c (Fwindow_end, window_scroll_pixel_based)
4515 (displayed_window_lines, Frecenter): Save and restore the bidi
4516 cache around display iteration.
4517
3bbd2265
LMI
45182011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4519
4520 * editfns.c (Fdelete_region): Clarify the use of the named
4521 parameters (bug#6788).
4522
adc47434
MR
45232011-07-14 Martin Rudalics <rudalics@gmx.at>
4524
4525 * indent.c (Fvertical_motion): Set and restore w->pointm when
4526 saving and restoring the window's buffer (Bug#9006).
4527
837c31f8
LMI
45282011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4529
4530 * editfns.c (Fstring_to_char): Clarify just what is returned
4531 (bug#6576). Text by Eli Zaretskii.
4532
ac389d0c
JB
45332011-07-13 Juanma Barranquero <lekktu@gmail.com>
4534
4535 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4536
0be0ce47
EZ
45372011-07-13 Eli Zaretskii <eliz@gnu.org>
4538
4539 * buffer.c (mmap_find): Fix a typo.
4540
cd18e7e3
JB
45412011-07-13 Johan Bockgård <bojohan@gnu.org>
4542
4543 Fix execution of x selection hooks.
4544 * xselect.c (Qx_lost_selection_functions)
4545 (Qx_sent_selection_functions): New vars.
4546 (syms_of_xselect): DEFSYM them.
4547 (x_handle_selection_request): Pass Qx_sent_selection_functions
4548 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4549 (x_handle_selection_clear,x_clear_frame_selections):
4550 Pass Qx_lost_selection_functions rather than
4551 Vx_lost_selection_functions to Frun_hook_with_args.
4552
47ea7f44
PE
45532011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4554
ac389d0c 4555 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4556 The old code sometimes used this field without initializing it.
4557
47ea7f44
PE
4558 * alloc.c (gc_sweep): Don't read past end of array.
4559 In theory, the old code could also have corrupted Emacs internals,
4560 though it'd be very unlikely.
4561
bc985c87
AS
45622011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4563
4564 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4565 argument. (Bug#4026)
bc985c87 4566
0cf34688
LMI
45672011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4568
b3dadd76
LMI
4569 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4570 key" (bug#4257).
4571
0cf34688
LMI
4572 * window.c (Fset_window_start): Doc fix (bug#4199).
4573 (Fset_window_hscroll): Ditto.
4574
270768cd
PE
45752011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4576
077e3dda 4577 Fix minor new problems caught by GCC 4.6.1.
270768cd 4578 * term.c (init_tty): Remove unused local.
490011a6 4579 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4580 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4581 not used otherwise.
270768cd 4582
b1f58454
CY
45832011-07-12 Chong Yidong <cyd@stupidchicken.com>
4584
4585 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4586
22b9578d
LMI
45872011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4588
6e70ab07
LMI
4589 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4590 are the mini-buffer and the echo area (bug#3320).
4591
22b9578d
LMI
4592 * term.c (init_tty): Remove support for supdup, c10 and perq
4593 terminals, which are no longer supported (bug#1482).
4594
8974cc9f
JB
45952011-07-10 Johan Bockgård <bojohan@gnu.org>
4596
4597 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4598
a560d974
JD
45992011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4600
4601 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4602 for non-popups (Bug#3642).
4603
1dae0f0a
AS
46042011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4605
268c2c36 4606 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4607 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4608 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4609 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4610 * data.c (fmod): Likewise.
4611 * dispnew.c (swap_glyphs_in_rows): Likewise.
4612 * emacs.c (memory_warning_signal): Likewise.
4613 * floatfns.c (float_error): Likewise.
4614 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4615 (otf_open, font_otf_capability, generate_otf_features)
4616 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4617 Likewise.
4618 * image.c (pbm_read_file): Likewise.
4619 * indent.c (string_display_width): Likewise.
4620 * intervals.c (check_for_interval, search_for_interval)
4621 (inc_interval_count, count_intervals, root_interval)
4622 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4623 * lread.c (defalias): Likewise.
268c2c36 4624 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4625 * regex.c (set_image_of_range_1, set_image_of_range)
4626 (regex_grow_registers): Likewise.
4627 * sysdep.c (strerror): Likewise.
4628 * termcap.c (valid_filename_p, tprint, main): Likewise.
4629 * tparam.c (main): Likewise.
4630 * unexhp9k800.c (run_time_remap, save_data_space)
4631 (update_file_ptrs, read_header, write_header, calculate_checksum)
4632 (copy_file, copy_rest, display_header): Likewise.
4633 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4634 Likewise.
4635 * xdisp.c (check_it): Likewise.
4636 * xfaces.c (register_color, unregister_color, unregister_colors):
4637 Likewise.
4638 * xfns.c (print_fontset_result): Likewise.
4639 * xrdb.c (member, fatal, main): Likewise.
4640
99033785
PE
46412011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4642
4643 Fix minor problems found by static checking (Bug#9031).
4644 * chartab.c (char_table_set_range, map_sub_char_table):
4645 Remove unused locals.
4646 (uniprop_table): Now static.
4647 * composite.c (_work_char): Remove unused static var.
4648
9cb2ac56
JB
46492011-07-09 Juanma Barranquero <lekktu@gmail.com>
4650
4651 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4652
f25661f0
JD
46532011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4654
4655 * gtkutil.c (qttip_cb): Remove code without function.
4656
8278c4fe
EZ
46572011-07-09 Eli Zaretskii <eliz@gnu.org>
4658
4659 * w32.c (pthread_sigmask): New stub.
4660
1692ae2d 46612011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4662
8a6ebd58 4663 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4664 sigprocmask is portable only for single-threaded applications, and
4665 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4666 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4667 (LIBES): Use it.
4668 * callproc.c (Fcall_process):
4669 * process.c (create_process):
4670 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4671 Use pthread_sigmask, not sigprocmask.
123403e4 4672
1b854618
JD
46732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4674
4675 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4676 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4677 wrong (Bug#8591).
4678
3fe4b549
JD
46792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4680
0ce7e563
JD
4681 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4682 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4683 (xg_hide_tooltip): Fix comment.
4684
3fe4b549
JD
4685 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4686 in registerServicesMenuSendTypes.
4687 (validRequestorForSendType): Don't check ns_return_types.
4688
4689 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4690 ns_return_type.
4691
5df75e47
JR
46922011-07-08 Jason Rumney <jasonr@gnu.org>
4693
22610910
JR
4694 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4695 SH_SHOW for hidden windows (Bug#5482).
4696
5df75e47
JR
4697 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4698 frame struct members of non-existent frames (Bug#6284).
4699
699c10bd
JD
47002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4701
4393663b
JD
4702 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4703 variable firstTime not needed on OSX >= 10.6.
4704 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4705 >= 10.5. Use setKnobProportion, setDoubleValue.
4706
4707 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4708 (MAC_OS_X_VERSION_10_5): Define if not defined.
4709 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4710 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4711 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4712
4713 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4714 cString and lossyCString on OSX >= 10.4
4715
58179cce 4716 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4717 sizeToFit on OSX >= 10.2.
4718
4719 * nsimage.m (allocInitFromFile): Don't use deprecated method
4720 bestRepresentationForDevice on OSX >= 10.6.
4721
4722 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4723 to avoid warning.
4724
4725 * emacs.c: Declare unexec_init_emacs_zone.
4726
a63e0781
JD
4727 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4728
699c10bd
JD
4729 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4730
4731 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4732 on svcsMenu (Bug#8842).
4733
4734 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4735 ns_return_types.
4736 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4737
4738 * nsterm.m (QUTF8_STRING): Declare.
4739 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4740 (validRequestorForSendType): Return type is (id).
4741 Change indexOfObjectIdenticalTo to indexOfObject.
4742 Check if we have local selection before returning self (Bug#8842).
4743 (writeSelectionToPasteboard): Put local selection into paste board
4744 if we have a local selection (Bug#8842).
4745 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4746
4747 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4748 (ns_get_local_selection): Declare.
4749
54e10184
LMI
47502011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4751
9888ff71
LMI
4752 * keymap.c (describe_map_tree): Don't insert a double newline at
4753 the end of the buffer (bug#1169) and return whether we inserted
4754 something.
4755
54e10184
LMI
4756 * callint.c (Fcall_interactively): Change "reading args" to
4757 "providing args" to try to clarify what it does (bug#1010).
4758
15fa4783
KH
47592011-07-07 Kenichi Handa <handa@m17n.org>
4760
4761 * composite.c (composition_compute_stop_pos): Ignore a static
4762 composition starting before CHARPOS (Bug#8915).
4763
4764 * xdisp.c (handle_composition_prop): Likewise.
4765
a8815b00
EZ
47662011-07-07 Eli Zaretskii <eliz@gnu.org>
4767
4768 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4769 (Bug#9015)
4770
ef7b981d 47712011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4772
4773 * character.h (unicode_category_t): New enum type.
4774
4775 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4776 (Qchar_code_property_table): New variable.
4777 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4778 (UNIPROP_COMPRESSED_FORM_P): New macros.
4779 (char_table_ascii): Uncompress the compressed values.
4780 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4781 Uncompress the compressed values.
ac389d0c 4782 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4783 (char_table_ref_and_range): Uncompress the compressed values.
4784 (sub_char_table_set): New arg is_uniprop. Callers changed.
4785 Uncompress the compressed values.
4786 (sub_char_table_set_range): Args changed. Callers changed.
4787 (char_table_set_range): Adjuted for the above change.
4788 (map_sub_char_table): Delete args default_val and parent. Add arg
4789 top. Give decoded values to a Lisp function.
640c8776 4790 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4791 values to a Lisp function. Gcpro more variables.
4792 (uniprop_table_uncompress)
4793 (uniprop_decode_value_run_length): New functions.
4794 (uniprop_decoder, uniprop_decoder_count): New variables.
4795 (uniprop_get_decoder, uniprop_encode_value_character)
4796 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4797 New functions.
4798 (uniprop_encoder, uniprop_encoder_count): New variables.
4799 (uniprop_get_encoder, uniprop_table)
4800 (Funicode_property_table_internal, Fget_unicode_property_internal)
4801 (Fput_unicode_property_internal): New functions.
4802 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4803 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4804 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4805 char-code-property-alist.
4806
640c8776 4807 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4808 Vunicode_category_table.
4809
640c8776 4810 * font.c (font_range): Adjust for the change of
c805dec0
KH
4811 Vunicode_category_table.
4812
76b397fb
DN
48132011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4814
4815 * m/iris4d.h: Remove file, move contents ...
4816 * s/irix6-5.h: ... here.
4817
22b4128e
PE
48182011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4819
4820 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4821 * alloc.c (mark_buffer):
4822 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4823 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4824 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4825 This isn't true in general, and it's particularly not true
4826 if Emacs is configured with --with-wide-int.
4827 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4828 New macros, used in the buffer.c change.
4829
869795d6
JD
48302011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4831
4832 * xsettings.c: Use both GConf and GSettings if both are available.
4833 (store_config_changed_event): Add comment.
4834 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4835 (store_tool_bar_style_changed): New functions.
5e617bc2 4836 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4837 (struct xsettings): Move font inside HAVE_XFT.
4838 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4839 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4840 Move inside HAVE_XFT.
640c8776 4841 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4842 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4843 also.
4844 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4845 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4846 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4847 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4848 (parse_settings): Move check for font inside HAVE_XFT.
4849 (read_settings, apply_xft_settings): Add comment.
4850 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4851 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4852 call store_font_name_changed.
4853 (xft_settings_event): Add comment.
4854 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4855 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4856 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4857 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4858 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4859 (xsettings_get_system_font, xsettings_get_system_normal_font):
4860 Add comment.
869795d6 4861
d8ed26bd
PE
48622011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4863
4864 Random fixes. E.g., (random) never returned negative values.
4865 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4866 subseconds part to the entropy, as that's a bit more random.
4867 Prefer signed to unsigned, since the signedness doesn't matter and
4868 in general we prefer signed. When given a limit, use a
4869 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4870 latter isn't right if USE_2_TAGS_FOR_INTS.
4871 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4872 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4873
cabf1cac
SM
48742011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4875
4876 * textprop.c (text_property_stickiness):
4877 Obey Vtext_property_default_nonsticky.
4878 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4879 * w32fns.c (syms_of_w32fns):
4880 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4881
6e9b2be9
PE
48822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4883
4884 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4885 This is more efficient than Ffile_directory_p and avoids a minor race.
4886
90186c68
LMI
48872011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4888
7c301272
LMI
4889 * buffer.c (Foverlay_put): Say what the return value is
4890 (bug#7835).
4891
c4f2d8d4
LMI
4892 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4893 is a directory before asking whether to use the file name
4894 (bug#7564).
ad637907
LMI
4895 (barf_or_query_if_file_exists): Make the "File is a directory"
4896 error be more correct.
c4f2d8d4 4897
90186c68
LMI
4898 * fns.c (Frequire): Remove the mention of the .gz files, since
4899 that's installation-specific, but keep the mention of
4900 `get-load-suffixes'.
4901
da64016e
PE
49022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4903
4904 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4905 Report string overflow if the output is too long.
4906
7d47b580
JB
49072011-07-04 Juanma Barranquero <lekktu@gmail.com>
4908
a555cb87
JB
4909 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4910 (syms_of_gnutls): Remove duplicate DEFSYM for
4911 Qgnutls_bootprop_verify_hostname_error, an error for
4912 Qgnutls_bootprop_verify_error (which is no longer used).
4913
7d47b580
JB
4914 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4915 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4916 Also (re)move comments that are misplaced or no longer relevant.
4917
1e49bfab
LMI
49182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4919
4920 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4921
1485f4c0
CY
49222011-07-03 Chong Yidong <cyd@stupidchicken.com>
4923
4924 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4925 and background color parameters if they have been changed.
4926
a9ab721e
LMI
49272011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4928
4929 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4930
cf7cff57
PE
49312011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4932
2e13213d
PE
4933 * xsettings.c (SYSTEM_FONT): Define only when used.
4934 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4935
cf7cff57
PE
4936 * keymap.c (access_keymap_1): Now static.
4937
7a8e04f7
CY
49382011-07-02 Chong Yidong <cyd@stupidchicken.com>
4939
4940 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4941 leave any prefix arg for the up event (Bug#1586).
4942
61352f62
LMI
49432011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4944
69bb1ef7
LMI
4945 * lread.c (syms_of_lread): Mention single symbols defined by
4946 `defvar' or `defconst' (bug#7154).
4947
61352f62 4948 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4949 (Frequire): Mention get-load-suffixes.
61352f62 4950
28545e04
MR
49512011-07-02 Martin Rudalics <rudalics@gmx.at>
4952
4953 * window.h (window): Remove clone_number slot.
4954 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4955 Remove.
4956 (make_parent_window, make_window, saved_window)
4957 (Fset_window_configuration, save_window_save): Don't deal with
4958 clone numbers.
4959 * buffer.c (Qclone_number): Remove declaration.
4960 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4961
3349e122
SM
49622011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4963
4964 Add multiple inheritance to keymaps.
4965 * keymap.c (Fmake_composed_keymap): New function.
4966 (Fset_keymap_parent): Simplify.
4967 (fix_submap_inheritance): Remove.
4968 (access_keymap_1): New function extracted from access_keymap to handle
4969 embedded parents and handle lists of maps.
4970 (access_keymap): Use it.
4971 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4972 (Fcopy_keymap): Handle embedded parents.
4973 (Fcommand_remapping, define_as_prefix): Simplify.
4974 (Fkey_binding): Simplify.
4975 (syms_of_keymap): Move minibuffer-local-completion-map,
4976 minibuffer-local-filename-completion-map,
4977 minibuffer-local-must-match-map, and
4978 minibuffer-local-filename-must-match-map to Elisp.
4979 (syms_of_keymap): Defsubr make-composed-keymap.
4980 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4981 (parse_menu_item): Trivial simplification.
4982
3279eb87
GM
49832011-07-01 Glenn Morris <rgm@gnu.org>
4984
4985 * Makefile.in (SETTINGS_LIBS): Fix typo.
4986
4550efdf
KI
49872011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4988
4989 * coding.c (Fencode_coding_string): Record the last coding system
4990 used, as the function doc string says (bug#8738).
4991
0949d2b6
JD
49922011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4993
4994 * xsettings.c (store_monospaced_changed): Take new font as arg and
4995 check for change against current_mono_font.
4996 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4997 (emacs_settings_constructor, emacs_settings_get_property)
4998 (emacs_settings_set_property, emacs_settings_class_init)
4999 (emacs_settings_init, gsettings_obj): Remove.
5000 (something_changedCB): New function for HAVE_GSETTINGS.
5001 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5002 with value as argument.
5003 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5004 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 5005 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
5006 "changed".
5007
5008 * xgselect.c: Add defined (HAVE_GSETTINGS).
5009 (xgselect_initialize): Ditto.
5010
5011 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5012 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5013 xg_select.
5014
bbc6b304
PE
50152011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5016
5017 * eval.c (struct backtrace): Simplify and port the data structure.
5018 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5019 signed bit field, as this assumption is not portable and it makes
5020 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5021 "char debug_on_exit : 1" as this is not portable either; instead,
5022 use the portable "unsigned int debug_on_exit : 1". Remove unused
5023 member evalargs. Remove obsolete comments about cc bombing out.
5024
9851bfc5
JD
50252011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5026
51bb811f 5027 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
5028 Let HAVE_GSETTINGS override HAVE_GCONF.
5029 (store_monospaced_changed): New function.
5030 (EMACS_SETTINGS): A new type derived from GObject to handle
5031 GSettings notifications.
5032 (emacs_settings_constructor, emacs_settings_get_property)
5033 (emacs_settings_set_property, emacs_settings_class_init):
5034 New functions.
5035 (gsettings_client, gsettings_obj): New variables.
5036 (GSETTINGS_SCHEMA): New define.
5037 (something_changedCB): Call store_monospaced_changed.
5038 (init_gsettings): New function.
5039 (xsettings_initialize): Call init_gsettings.
5040 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5041 to NULL.
5042
640c8776 5043 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
5044 GCONF_CFLAGS/LIBS.
5045
5386012d
MR
50462011-06-29 Martin Rudalics <rudalics@gmx.at>
5047
5048 * window.c (resize_root_window, grow_mini_window)
5049 (shrink_mini_window): Rename Qresize_root_window to
5050 Qwindow_resize_root_window and Qresize_root_window_vertically to
5051 Qwindow_resize_root_window_vertically.
5052
f13e0b08
PE
50532011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5054
5055 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5056
94515237
JB
50572011-06-27 Juanma Barranquero <lekktu@gmail.com>
5058
5059 * makefile.w32-in: Redesign dependencies so they reflect more
5060 clearly which files are directly included by each source file,
5061 and not through other includes.
5062
e43b6e43
MR
50632011-06-27 Martin Rudalics <rudalics@gmx.at>
5064
5065 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5066 (sort_overlays, overlay_strings): When an overlay's clone number
5067 matches the window's clone number process the overlay even if
5068 the overlay's window property doesn't match the current window.
5069
d68443dc
MR
5070 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5071 (Fwindow_hchild): Rename to Fwindow_left_child.
5072 (Fwindow_next): Rename to Fwindow_next_sibling.
5073 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5074 (resize_window_check): Rename to window_resize_check.
5075 (resize_window_apply): Rename to window_resize_apply.
5076 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5077 (Fdelete_other_windows_internal, resize_frame_windows)
5078 (Fsplit_window_internal, Fdelete_window_internal)
5079 (grow_mini_window, shrink_mini_window)
5080 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5081
c7e73be5
JD
50822011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5083
5084 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5085 (emacs_fixed_set_min_size): Remove.
5086 (emacs_fixed_new): Take frame as argument.
5087
5088 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5089 (_EmacsFixedPrivate): Remove minwidth/height.
5090 Add struct frame *f.
5091 (emacs_fixed_init): Initialize priv->f.
5092 (get_parent_class, emacs_fixed_set_min_size): Remove.
5093 (emacs_fixed_new): Set priv->f to argument.
5094 (emacs_fixed_get_preferred_width)
5095 (emacs_fixed_get_preferred_height): Use min_width/height from
5096 frames size_hint to set minimum and natural (Bug#8919).
5097 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5098 and use min_width/height from frames size_hint to set
5099 min_width/height (Bug#8919).
5100
5101 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5102 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5103 Fix indentation.
c7e73be5 5104
cf99dcf8
EZ
51052011-06-26 Eli Zaretskii <eliz@gnu.org>
5106
5107 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5108 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5109 called at ZV.
5110
029529ac
CY
51112011-06-26 Chong Yidong <cyd@stupidchicken.com>
5112
5113 * process.c (wait_reading_process_output): Bypass select if
5114 waiting for a cell while ignoring keyboard input, and input is
5115 pending. Suggested by Jan Djärv (Bug#8869).
5116
7a7ef429
PE
51172011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5118
5119 Use gnulib's dup2 module instead of rolling our own.
5120 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5121
11fdef7d 51222011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5123
5124 * dispnew.c (scrolling_window): Before scrolling, turn off a
5125 mouse-highlight in the window being scrolled.
5126
cd3520a4
JB
51272011-06-24 Juanma Barranquero <lekktu@gmail.com>
5128
5129 Move DEFSYM to lisp.h and use everywhere.
5130
5131 * character.h (DEFSYM): Move declaration...
5132 * lisp.h (DEFSYM): ...here.
5133
5134 * gnutls.c:
5135 * minibuf.c:
5136 * w32menu.c:
5137 * w32proc.c:
5138 * w32select.c: Don't include character.h.
5139
5140 * alloc.c (syms_of_alloc):
5141 * buffer.c (syms_of_buffer):
5142 * bytecode.c (syms_of_bytecode):
5143 * callint.c (syms_of_callint):
5144 * casefiddle.c (syms_of_casefiddle):
5145 * casetab.c (init_casetab_once):
5146 * category.c (init_category_once, syms_of_category):
5147 * ccl.c (syms_of_ccl):
5148 * cmds.c (syms_of_cmds):
5149 * composite.c (syms_of_composite):
5150 * dbusbind.c (syms_of_dbusbind):
5151 * dired.c (syms_of_dired):
5152 * dispnew.c (syms_of_display):
5153 * doc.c (syms_of_doc):
5154 * editfns.c (syms_of_editfns):
5155 * emacs.c (syms_of_emacs):
5156 * eval.c (syms_of_eval):
5157 * fileio.c (syms_of_fileio):
5158 * fns.c (syms_of_fns):
5159 * frame.c (syms_of_frame):
5160 * fringe.c (syms_of_fringe):
5161 * insdel.c (syms_of_insdel):
5162 * keymap.c (syms_of_keymap):
5163 * lread.c (init_obarray, syms_of_lread):
5164 * macros.c (syms_of_macros):
5165 * msdos.c (syms_of_msdos):
5166 * print.c (syms_of_print):
5167 * process.c (syms_of_process):
5168 * search.c (syms_of_search):
5169 * sound.c (syms_of_sound):
5170 * syntax.c (init_syntax_once, syms_of_syntax):
5171 * terminal.c (syms_of_terminal):
5172 * textprop.c (syms_of_textprop):
5173 * undo.c (syms_of_undo):
5174 * w32.c (globals_of_w32):
5175 * window.c (syms_of_window):
5176 * xdisp.c (syms_of_xdisp):
5177 * xfaces.c (syms_of_xfaces):
5178 * xfns.c (syms_of_xfns):
5179 * xmenu.c (syms_of_xmenu):
5180 * xsettings.c (syms_of_xsettings):
5181 * xterm.c (syms_of_xterm): Use DEFSYM.
5182
4228cf16
TZ
51832011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5184
cd3520a4 5185 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5186
7fcccf1e
PE
51872011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5188
7efb4e0e
PE
5189 Integer and buffer overflow fixes (Bug#8873).
5190
ff5844ad
PE
5191 * print.c (printchar, strout): Check for string overflow.
5192 (PRINTPREPARE, printchar, strout):
5193 Don't set size unless allocation succeeds.
5194
90532f02
PE
5195 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5196 for sizes. Check for string overflow more accurately.
5197 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5198
6d84508d
PE
5199 * macros.c: Integer and buffer overflow fixes.
5200 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5201 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5202 Use ptrdiff_t, not int, for sizes.
5203 Don't increment bufsize until after realloc succeeds.
5204 Check for size-calculation overflow.
5205 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5206
437b2cb4
PE
5207 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5208
8b9ac8b4
PE
5209 * lread.c: Integer overflow fixes.
5210 (read_integer): Radix is now EMACS_INT, not int,
5211 to improve quality of diagnostics for out-of-range radices.
5212 Calculate buffer size correctly for out-of-range radices.
5213 (read1): Check for integer overflow in radices, and in
5214 read-circle numbers.
82cb60d3
PE
5215 (read_escape): Avoid int overflow.
5216 (Fload, openp, read_buffer_size, read1)
5217 (substitute_object_recurse, read_vector, read_list, map_obarray):
5218 Use ptrdiff_t, not int, for sizes.
5219 (read1): Use EMACS_INT, not int, for sizes.
20270765 5220 Check for size overflow.
8b9ac8b4 5221
7fcccf1e
PE
5222 * image.c (cache_image): Check for size arithmetic overflow.
5223
bfbbd7e7
PE
5224 * lread.c: Integer overflow issues.
5225 (saved_doc_string_size, saved_doc_string_length)
5226 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5227 Now ptrdiff_t, not int.
5228 (read1): Don't assume doc string length fits in int. Check for
5229 out-of-range doc string lengths.
5230 (read_list): Don't assume file position fits in int.
39019e54 5231 (read_escape): Check for hex character overflow.
bfbbd7e7 5232
4e323265
LL
52332011-06-22 Leo Liu <sdl.web@gmail.com>
5234
5235 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5236 Move to minibuffer.el.
5237
85fece3e
PE
52382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5239
20b84ce9 5240 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5241 The following patches are for when GLYPH_DEBUG && !XASSERT.
5242 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5243 * dispnew.c (flush_stdout):
5244 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5245 Mark as externally visible.
5246 * dispnew.c (check_window_matrix_pointers): Now static.
5247 * dispnew.c (window_to_frame_vpos):
5248 * xfns.c (unwind_create_frame):
5249 * xterm.c (x_check_font): Remove unused local.
5250 * scroll.c (CHECK_BOUNDS):
5251 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5252 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5253 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5254 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5255 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5256 Now static.
5257 (debug_method_add): Use va_list and vsprintf rather than relying
5258 on undefined behavior with wrong number of arguments.
5259 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5260 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5261 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5262 since we're not interested in debugging glyphs with old libraries.
5263 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5264 GCC 4.6.0's static checking.
5265
0766b489
PE
52662011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5267
31fd4b32
PE
5268 Integer overflow and signedness fixes (Bug#8873).
5269 A few related buffer overrun fixes, too.
5270
b79e8648
PE
5271 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5272
0766b489
PE
5273 * dispextern.h (struct face.stipple):
5274 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5275 (x_bitmap_mask, x_allocate_bitmap_record)
5276 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5277 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5278 (x_create_bitmap_from_xpm_data):
5279 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5280 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5281 (.bitmaps_last):
5282 * xfaces.c (load_pixmap):
5283 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5284 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5285 (.bitmaps_last, struct x_output.icon_bitmap):
5286 Use ptrdiff_t, not int, for bitmap indexes.
5287 (x_allocate_bitmap_record): Check for size overflow.
5288 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5289
b081724f
PE
5290 Use ptrdiff_t, not int, for overlay counts.
5291 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5292 * editfns.c (overlays_around, get_pos_property):
5293 * textprop.c (get_char_property_and_overlay):
5294 * xdisp.c (next_overlay_change, note_mouse_highlight):
5295 * xfaces.c (face_at_buffer_position):
21514da7
PE
5296 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5297 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5298 (Fnext_overlay_change, Fprevious_overlay_change)
5299 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5300 Use ptrdiff_t, not int, for sizes.
21514da7 5301 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5302
3de73e5e
PE
5303 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5304
2606c57b
PE
5305 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5306 (x_session_initialize): Do not assume string length fits in int.
5307
aaafe47a
PE
5308 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5309 This is unlikely, but can occur if DPI is outlandish.
5310
2674ddc8 5311 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5312 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5313
28154962
PE
5314 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5315 * xrdb.c (magic_file_p, search_magic_path):
5316 Omit last arg SUFFIX; it was always 0. All callers changed.
5317 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5318
7de51af5
PE
5319 * xfont.c (xfont_match): Avoid need for strlen.
5320
25ed6cc3
PE
5321 * xfns.c: Don't assume strlen fits in int.
5322 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5323
4eab31dd
PE
5324 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5325 not unsigned long, as we prefer signed integers. All callers changed.
5326 Detect integer overflow in repeat count.
5327 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5328 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5329
171e2a58
PE
5330 * termcap.c: Don't assume sizes fit in int and never overflow.
5331 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5332 (gobble_line): Check for size-calculation overflow.
5333
ad39faca 5334 * minibuf.c (Fread_buffer):
6e5bb2dc 5335 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5336 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5337 Don't assume string length fits in int.
5338
52c61c22 5339 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5340 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5341
b5b8c9e5
PE
5342 * font.c: Don't assume string length fits in int.
5343 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5344 Use ptrdiff_t, not int.
ccd6111c
PE
5345 (font_intern_prop): Don't assume string length fits in int.
5346 Don't assume integer property fits in fixnum.
5347 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5348
882f0d81 5349 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5350 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5351 Reformulate so as not to need the command string.
5352 Invoke gzip -cd rather than gunzip, as it's more portable.
5353 (lock_info_type, lock_file_1, lock_file):
5354 Don't assume pid_t and time_t fit in unsigned long.
5355 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5356 (current_lock_owner): Prefer signed type for sizes.
5357 Use memcpy, not strncpy, where memcpy is what is really wanted.
5358 Don't assume (via atoi) that time_t and pid_t fit in int.
5359 Check for time_t and/or pid_t out of range, e.g., via a network share.
5360 Don't alloca where an auto var works fine.
5361
93f4cf88
PE
5362 * fileio.c: Fix some integer overflow issues.
5363 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5364 Don't assume string length fits in int.
5365 (directory_file_name): Don't assume string length fits in long.
5366 (make_temp_name): Don't assume pid fits in int, or that its print
5367 length is less than 20.
5368
f3e92b69
PE
5369 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5370
1bfdaf10
PE
5371 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5372
35016e9a
PE
5373 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5374
3d1e65a1
PE
5375 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5376 We prefer signed integers, even for size calculations.
5377
0b963a93
PE
5378 * emacs.c: Don't assume string length fits in 'int'.
5379 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5380 (main): Don't invoke strlen when not needed.
5381
573f4b54
PE
5382 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5383 (XD_DEBUG_MESSAGE): Don't waste a byte.
5384
989f33ba
PE
5385 * callproc.c (getenv_internal_1, getenv_internal)
5386 (Fgetenv_internal):
965d34eb
PE
5387 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5388
e4d29b33
PE
5389 * lread.c (invalid_syntax): Omit length argument.
5390 All uses changed. This doesn't fix a bug, but it simplifies the
5391 code away from its former Hollerith-constant appearance, and it's
5392 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5393 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5394
eb49b136
PE
5395 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5396 This didn't break anything, but it didn't help either.
5397 It's confusing to put a bogus integer in a place where the actual
5398 value does not matter.
9f62aeb1 5399 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5400 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5401
15375a22
PE
5402 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5403 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5404 implementation.
b61cc01c
PE
5405 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5406 We prefer signed types, and the value cannot exceed the EMACS_INT
5407 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5408 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5409 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5410 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5411
53b2623d
PE
5412 * indent.c (sane_tab_width): New function.
5413 (current_column, scan_for_column, Findent_to, position_indentation)
5414 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5415 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5416
51cab52b 5417 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5418
f2ed8a70
PE
5419 * lisp.h (lint_assume): New macro.
5420 * composite.c (composition_gstring_put_cache):
5421 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5422
abe80cc6
PE
5423 * editfns.c, insdel.c:
5424 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5425
b02c740e
PE
5426 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5427
ebc96716
PE
5428 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5429
b4e50fa0 5430 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5431 Use much-faster test for byte-length change.
311d5d7c 5432 Don't assume string byte-length fits in 'int'.
a4cf38e4 5433 Check that character arg fits in 'int'.
85461888 5434 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5435
c0c1ee9f
PE
5436 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5437
a498d7f4
PE
5438 * fns.c (concat): Catch string overflow earlier.
5439 Do not rely on integer wraparound.
5440
51cab52b
PE
5441 * dispextern.h (struct it.overlay_strings_charpos)
5442 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5443 * xdisp.c (forward_to_next_line_start)
5444 (back_to_previous_visible_line_start)
5445 (reseat_at_next_visible_line_start, next_element_from_buffer):
5446 Don't arbitrarily truncate the value of 'selective' to int.
5447
76031fad
PE
5448 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5449
5eb55db9
PE
5450 * composite.c: Don't truncate sizes to 'int'.
5451 (composition_gstring_p, composition_reseat_it)
5452 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5453 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5454 not EMACS_UINT, for indexes.
5eb55db9 5455
0703a717
PE
5456 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5457
d6202519
PE
5458 * buffer.c: Include <verify.h>.
5459 (struct sortvec.priority, struct sortstr.priority):
8961a454 5460 Now EMACS_INT, not int.
c20998a7 5461 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5462 (struct sortstr.size, record_overlay_string)
5463 (struct sortstrlist.size, struct sortlist.used):
5464 Don't truncate size to int.
5465 (record_overlay_string): Check for size-calculation overflow.
d6202519 5466 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5467
d5a19415
JM
54682011-06-22 Jim Meyering <meyering@redhat.com>
5469
029529ac 5470 Don't leak an XBM-image-sized buffer
d5a19415
JM
5471 * image.c (xbm_load): Free the image buffer after using it.
5472
a9041e6c
PE
54732011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5474
5475 Port to Sun C.
5476 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5477 that Sun C diagnosed.
5478 * fns.c (secure_hash): Fix pointer signedness issue.
5479 * intervals.c (static_offset_intervals): New function.
5480 (offset_intervals): Use it.
5481
7f3f739f
LL
54822011-06-21 Leo Liu <sdl.web@gmail.com>
5483
5484 * deps.mk (fns.o):
5485 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5486 sha512.h.
5487
5488 * fns.c (secure_hash): Rename from crypto_hash_function and change
5489 the first arg to accept symbols.
5b66d427 5490 (Fsecure_hash): New primitive.
7f3f739f
LL
5491 (syms_of_fns): New symbols.
5492
76147d94
DD
54932011-06-20 Deniz Dogan <deniz@dogan.se>
5494
5495 * process.c (Fset_process_buffer): Clarify return value in
5496 docstring.
5497
7d7d0045
CY
54982011-06-18 Chong Yidong <cyd@stupidchicken.com>
5499
5500 * dispnew.c (add_window_display_history): Use BVAR.
5501
5502 * xdisp.c (debug_method_add): Use BVAR.
5503 (check_window_end, dump_glyph_matrix, dump_glyph)
5504 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5505
5506 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5507 Likewise.
5508
5509 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5510 check till after the cache is created in init_frame_faces.
5511
ff2bc410
SM
55122011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5513
5514 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5515
28177add
PE
55162011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5517
dd3482fe
PE
5518 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5519 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5520 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5521
393d71f3 5522 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5523 * fileio.c (Finsert_file_contents):
5524 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5525 Remove the old (too-loose) buffer overflow checks.
5526 They weren't needed, since make_gap checks for buffer overflow.
5527 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5528 The old code merely checked for Emacs fixnum overflow, and relied
5529 on undefined (wraparound) behavior. The new code avoids undefined
5530 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5531
2e6813b0 5532 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5533 Tune. Don't use wider integers than needed. Don't use alloca.
5534 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5535
599a9e4f
PE
5536 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5537
99561444
PE
5538 * insdel.c, lisp.h (buffer_overflow): New function.
5539 (insert_from_buffer_1, replace_range, replace_range_2):
5540 * insdel.c (make_gap_larger):
5541 * editfns.c (Finsert_char):
5542 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5543
28177add
PE
5544 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5545
e69dafad
PE
55462011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5547
4baa020d 5548 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5549
b1c46f02
PE
5550 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5551 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5552
e69dafad
PE
5553 * fileio.c: Don't assume EMACS_INT fits in off_t.
5554 (emacs_lseek): New static function.
5555 (Finsert_file_contents, Fwrite_region): Use it.
5556 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5557
566684ea
PE
5558 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5559
e6966cd6
PE
5560 * fns.c: Don't overflow int when computing a list length.
5561 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5562 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5563 truncation on 64-bit hosts. Check for QUIT every
5564 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5565 faster and is responsive enough.
5566 (Flength): Report an error instead of overflowing an integer.
5567 (Fsafe_length): Return a float if the value is not representable
5568 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5569 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5570 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5571
dd0b0efb
PE
5572 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5573 (header_size, word_size): New constants.
5574 (allocate_vectorlike): Don't check size overflow here.
5575 (allocate_vector): Check it here instead, since this is the only
5576 caller of allocate_vectorlike that could cause overflow.
5577 Check that the new vector's length is representable as a fixnum.
5578
86fe5cfe
PE
5579 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5580 The previous code was bogus. For example, next_almost_prime (32)
5581 returned 39, which is undesirable as it is a multiple of 3; and
5582 next_almost_prime (24) returned 25, which is a multiple of 5 so
5583 why was the code bothering to check for multiples of 7?
5584
80e88859
PE
5585 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5586
4a2f0ad6
PE
5587 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5588
f66c7cf8
PE
5589 Variadic C functions now count arguments with ptrdiff_t.
5590 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5591 Back then I didn't know that the Emacs coding style prefers signed int.
5592 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5593 were being counted with int, which may truncate counts on 64-bit
5594 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5595 * lisp.h (struct Lisp_Subr.function.aMANY)
5596 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5597 Arg counts are now ptrdiff_t, not size_t.
5598 All variadic functions and their callers changed accordingly.
5599 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5600 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5601 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5602 * callint.c (Fcall_interactively): Check arg count for overflow,
5603 to avoid potential buffer overrun. Use signed char, not 'int',
5604 for 'varies' array, so that we needn't bother to check its size
5605 calculation for overflow.
5606 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5607 * eval.c (apply_lambda):
5608 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5609 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5610 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5611
a1759b76
PE
5612 * callint.c (Fcall_interactively): Don't use index var as event count.
5613
d96be9fc
PE
5614 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5615 * mem-limits.h (SIZE): Remove; no longer used.
5616
a690a978 5617 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5618
578c21e6
PE
5619 Remove unnecessary casts.
5620 * xterm.c (x_term_init):
5621 * xfns.c (x_set_border_pixel):
5622 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5623 These aren't needed now that we assume ANSI C.
5624
96f53c6c
PE
5625 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5626 It's more likely to cause problems (due to unsigned overflow)
5627 than to cure them.
5628
83c77d31
PE
5629 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5630
ee2079f1
PE
5631 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5632
6da65536
PE
5633 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5634
7147c4a4
PE
5635 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5636
193e32d9
PE
5637 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5638
e5533da6
PE
5639 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5640
9910e595
PE
5641 GLYPH_CODE_FACE returns EMACS_INT, not int.
5642 * dispextern.h (merge_faces):
5643 * xfaces.c (merge_faces):
01103c44
PE
5644 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5645 Don't assume EMACS_INT fits in int.
9910e595 5646
2638320e
PE
5647 * character.h (CHAR_VALID_P): Remove unused parameter.
5648 * fontset.c, lisp.h, xdisp.c: All uses changed.
5649
045eb8d9
PE
5650 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5651
c1f134b5
PE
5652 * fns.c (concat): Minor tuning based on overflow analysis.
5653 This doesn't fix any bugs. Use int to hold character, instead
5654 of constantly refetching from Emacs object. Use XFASTINT, not
5655 XINT, for value known to be a character. Don't bother comparing
5656 a single byte to 0400, as it's always less.
5657
395fcb93 5658 * floatfns.c (Fexpt):
327eeec8
PE
5659 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5660
abbd3d23
PE
5661 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5662 for characters.
5663
684a03ef
PE
5664 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5665
0fed43f3
PE
5666 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5667 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5668 incorrectly succeed when S was a string, because 4294967386 was
5669 truncated before it was used.
5670
8fd02eb7
PE
5671 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5672 Otherwise, an out-of-range integer could cause undefined behavior
5673 on a 64-bit host.
5674
f8c86b69
PE
5675 * composite.c: Use int, not EMACS_INT, for characters.
5676 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5677 EMACS_INT, for values that are known to be in character range.
5678 This doesn't fix any bugs but is the usual style inside Emacs and
5679 may generate better code on 32-bit machines.
5680
34206dd2
PE
5681 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5682 This is for reasons similar to the recent CHAR_STRING fix.
5683 * charset.c (Fencode_char): Check that character arg is actually
5684 a character. Pass an int to ENCODE_CHAR.
5685 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5686 wider than 'int', as a compile-time check to prevent future regressions
5687 in this area.
5688
c5958d4c 5689 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5690
5691 Make sure a 64-bit char is never passed to CHAR_STRING.
5692 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5693 by silently ignoring the top 32 bits, allowing some values
5694 that were far too large to be valid characters.
5695 * character.h: Include <verify.h>.
5696 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5697 arguments are no wider than unsigned, as a compile-time check
5698 to prevent future regressions in this area.
5699 * data.c (Faset):
01103c44 5700 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5701 (Fsubst_char_in_region):
5702 * fns.c (concat):
5703 * xdisp.c (decode_mode_spec_coding):
5704 Adjust to CHAR_STRING's new requirement.
5705 * editfns.c (Finsert_char, Fsubst_char_in_region):
5706 * fns.c (concat): Check that character args are actually
5707 characters. Without this test, these functions did the wrong
5708 thing with wildly out-of-range values on 64-bit hosts.
5709
d37ca623
PE
5710 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5711 These casts should not be needed on 32-bit hosts, either.
5712 * keyboard.c (read_char):
5713 * lread.c (Fload): Remove casts to unsigned.
5714
ea204efb
PE
5715 * lisp.h (UNSIGNED_CMP): New macro.
5716 This fixes comparison bugs on 64-bit hosts.
5717 (ASCII_CHAR_P): Use it.
5718 * casefiddle.c (casify_object):
01103c44 5719 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5720 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5721 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5722 * dispextern.h (FACE_FROM_ID):
5723 * keyboard.c (read_char): Use UNSIGNED_CMP.
5724
41cb286c
PE
5725 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5726 not to EMACS_INT, to avoid GCC warning.
5727
4a1b9832
PE
5728 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5729
55daad71
PE
5730 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5731 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5732 isn't needed on 32-bit machines.
8f95c75c 5733
01103c44
PE
5734 * buffer.c (Fgenerate_new_buffer_name):
5735 Use EMACS_INT for count, not int.
0ceccced 5736 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5737
5738 * data.c (Qcompiled_function): Now static.
5739
c6f072e7
PE
5740 * window.c (window_body_lines): Now static.
5741
20ce5912
PE
5742 * image.c (gif_load): Rename local to avoid shadowing.
5743
9c4c5f81
PE
5744 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5745 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5746 * alloc.c (make_save_value): Integer argument is now of type
5747 ptrdiff_t, not int.
5748 (mark_object): Use ptrdiff_t, not int.
5749 * lisp.h (pD): New macro.
5750 * print.c (print_object): Use it.
5751
c0c5c8ae
PE
5752 * alloc.c: Use EMACS_INT, not int, to count objects.
5753 (total_conses, total_markers, total_symbols, total_vector_size)
5754 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5755 (total_free_floats, total_floats, total_free_intervals)
5756 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5757 Now EMACS_INT, not int. All uses changed.
5758 (Fgarbage_collect): Compute overall total using a double, so that
5759 integer overflow is less likely to be a problem. Check for overflow
5760 when converting back to an integer.
5a25e253
PE
5761 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5762 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5763 These were 'int' variables that could overflow on 64-bit hosts;
5764 they were never used, so remove them instead of repairing them.
211a0b2a 5765 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5766 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5767 Previously, this ceilinged at INT_MAX, but that doesn't work on
5768 64-bit machines.
e46bb31a 5769 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5770
c78baabf 5771 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5772 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5773 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5774 when a (possibly-narrower) signed value would do just as well.
5775 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5776
c9d624c6
PE
5777 * alloc.c: Catch some string size overflows that we were missing.
5778 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5779 for convenience in STRING_BYTES_MAX.
5780 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5781 The definition here is exact; the one in lisp.h was approximate.
5782 (allocate_string_data): Check for string overflow. This catches
5783 some instances we weren't catching before. Also, it catches
5784 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5785 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5786 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5787
c9d624c6
PE
5788 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5789 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5790 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5791
353032ce
PE
5792 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5793
2bccce07
PE
5794 * alloc.c (Fmake_string): Check for out-of-range init.
5795
0ac30604
SM
57962011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5797
5798 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5799
c195f2de
JD
58002011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5801
5802 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5803 xg_get_default_scrollbar_width.
5804
5805 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5806 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5807 (style_changed_cb): Call update_theme_scrollbar_width and call
5808 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5809 all frames (Bug#8505).
5810 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5811 Call gtk_window_set_resizable if HAVE_GTK3.
5812 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5813 and height if HAVE_GTK3 (Bug#8505).
5814 (scroll_bar_width_for_theme): New variable.
5815 (update_theme_scrollbar_width): New function.
5816 (xg_get_default_scrollbar_width): Move code to
5817 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5818 (xg_initialize): Call update_theme_scrollbar_width.
5819
5820 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5821
5822 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5823
e10ac9f1
MR
58242011-06-12 Martin Rudalics <rudalics@gmx.at>
5825
5826 * frame.c (make_frame): Call other_buffer_safely instead of
5827 other_buffer.
5828
5829 * window.c (temp_output_buffer_show): Call display_buffer with
5830 second argument Vtemp_buffer_show_specifiers and reset latter
5831 immediately after the call.
5832 (Vtemp_buffer_show_specifiers): New variable.
5833 (auto_window_vscroll_p, next_screen_context_lines)
5834 (Vscroll_preserve_screen_position): Remove leading asterisks from
5835 doc-strings.
5836
2d3c217e 58372011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5838
7b7f97e8 5839 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5840 * buffer.c (Qclone_number): Remove for now, as it's unused.
5841 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5842 (record_buffer): Remove unused local.
5843 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5844 (set_frame_buffer_list): Remove; unused.
5845 * frame.h (other_visible_frames): Remove decl.
5846 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5847 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5848 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5849 if HAVE_GPM.
5850 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5851 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5852 Define only if HAVE_GPM.
5853 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5854 (update_hints_inhibit): Remove; never set. All uses removed.
5855 * widgetprv.h (emacsFrameClassRec): Remove decl.
5856 * window.c (delete_deletable_window): Now returns void, since it
5857 wasn't returning anything.
5858 (compare_window_configurations): Remove unused locals.
5859 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5860 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5861 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5862 the same widths as pointers. This follows up on the 2011-05-06 patch.
5863 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5864 * xterm.h: Likewise.
5865 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5866
1384b89e
JB
58672011-06-12 Juanma Barranquero <lekktu@gmail.com>
5868
5869 * makefile.w32-in: Update dependencies.
5870 (LISP_H): Add lib/intprops.h.
5871
1100a63c
CY
58722011-06-11 Chong Yidong <cyd@stupidchicken.com>
5873
5874 * image.c (gif_load): Add animation frame delay to the metadata.
5875 (syms_of_image): Use DEFSYM. New symbol `delay'.
5876
6198ccd0
MR
58772011-06-11 Martin Rudalics <rudalics@gmx.at>
5878
5879 * window.c (delete_deletable_window): Re-add.
5880 (Fset_window_configuration): Rewrite to handle dead buffers and
5881 consequently deletable windows.
5882 (window_tree, Fwindow_tree): Remove. Supply functionality in
5883 window.el.
5884 (compare_window_configurations): Simplify code.
5885
b6e3633c
AS
58862011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5887
1ab0dee5
AS
5888 * image.c (imagemagick_load_image): Fix type mismatch.
5889 (Fimagemagick_types): Likewise.
5890
b6e3633c
AS
5891 * window.h (replace_buffer_in_windows): Declare.
5892
9397e56f
MR
58932011-06-11 Martin Rudalics <rudalics@gmx.at>
5894
5895 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5896 Qclone_number. Remove external declaration of Qdelete_window.
5897 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5898 code.
640c8776
SM
5899 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5900 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5901 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5902 buffer list implementation.
5903 (other_buffer_safely): New function.
5904 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5905 calls to replace_buffer_in_windows and
5906 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5907 if allowed.
5908 (record_buffer): Inhibit quitting and rewrite using quittable
5909 functions. Run Qbuffer_list_update_hook if allowed.
5910 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5911 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5912 Move switch-to-buffer to window.el.
9397e56f
MR
5913 (bury-buffer): Move to window.el.
5914 (Vbuffer_list_update_hook): New variable.
5915
5916 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5917 section.
5918
5919 * window.h (resize_frame_windows): Move up in code.
5920 (Fwindow_frame): Remove EXFUN.
5921 (replace_buffer_in_all_windows): Remove prototype.
5922 (replace_buffer_in_windows_safely): Add prototype.
5923
5924 * window.c: Declare Qdelete_window static again. Move down
5925 declaration of select_count.
5926 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5927 (Fother_window): Move to window.el.
5928 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5929 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5930 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5931 window.el.
5932 (replace_buffer_in_windows): Implement by calling
5933 Qreplace_buffer_in_windows.
5934 (replace_buffer_in_all_windows): Remove with some functionality
5935 moved into replace_buffer_in_windows_safely.
5936 (replace_buffer_in_windows_safely): New function.
5937 (select_window_norecord, select_frame_norecord): Move in front
5938 of run_window_configuration_change_hook. Remove now obsolete
5939 declarations.
640c8776
SM
5940 (Fset_window_buffer): Rewrite doc-string.
5941 Call Qrecord_window_buffer.
9397e56f
MR
5942 (keys_of_window): Move binding for other-window to window.el.
5943
b50691aa
CY
59442011-06-11 Chong Yidong <cyd@stupidchicken.com>
5945
5946 * dispextern.h (struct image): Replace data member, whose int_val
5947 and ptr_val fields were not used by anything, with a single
5948 lisp_val object.
5949
5950 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5951 (gif_clear_image, gif_load, imagemagick_load_image)
5952 (gs_clear_image, gs_load): Callers changed.
5953
3f754b86
PE
59542011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5955
cca69397
PE
5956 * buffer.h: Include <time.h>, for time_t.
5957 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5958
109e28d0
PE
5959 Fix minor problems found by static checking.
5960
60737f02
PE
5961 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5962
4b66faf3
PE
5963 Make identifiers static if they are not used in other modules.
5964 * data.c (Qcompiled_function, Qframe, Qvector):
5965 * image.c (QimageMagick, Qsvg):
5966 * minibuf.c (Qmetadata):
5967 * window.c (resize_window_check, resize_root_window): Now static.
5968 * window.h (resize_window_check, resize_root_window): Remove decls.
5969
109e28d0
PE
5970 * window.c (window_deletion_count, delete_deletable_window):
5971 Remove; unused.
46a4ce9e
PE
5972 (window_body_lines): Now static.
5973 (Fdelete_other_windows_internal): Mark vars as initialized.
5974 Make sure 'resize_failed' is initialized.
5975 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5976 (resize_window_apply): Remove unused local.
5977 * window.h (delete_deletable_window): Remove decl.
5978
109e28d0 5979 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5980 (imagemagick_load_image): Fix pointer signedness problem by changing
5981 last arg from unsigned char * to char *. All uses changed.
5982 Also, fix a local for similar reasons.
5983 Remove unused locals. Remove locals to avoid shadowing.
5984 (fn_rsvg_handle_free): Remove; unused.
5985 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5986 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5987
3f754b86
PE
5988 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5989
2547adb1
CY
59902011-06-10 Chong Yidong <cyd@stupidchicken.com>
5991
5992 * image.c (gif_load): Fix omitted cast error introduced by
5993 2011-06-06 change.
5994
2c8e37d4
MR
59952011-06-10 Martin Rudalics <rudalics@gmx.at>
5996
5997 * window.h (resize_proportionally, orig_total_lines)
5998 (orig_top_line): Remove from window structure.
5999 (set_window_height, set_window_width, change_window_heights)
6000 (Fdelete_window): Remove prototypes.
6001 (resize_frame_windows): Remove duplicate declaration.
6002
440a42e3
EZ
60032011-06-10 Eli Zaretskii <eliz@gnu.org>
6004
6005 * window.h (resize_frame_windows, resize_window_check)
6006 (delete_deletable_window, resize_root_window)
6007 (resize_frame_windows): Declare prototypes.
6008
6009 * window.c (resize_window_apply): Make definition be "static" to
6010 match the prototype.
6011
562dd5e9
MR
60122011-06-10 Martin Rudalics <rudalics@gmx.at>
6013
6014 * window.c: Remove declarations of Qwindow_size_fixed,
6015 window_min_size_1, window_min_size_2, window_min_size,
6016 size_window, window_fixed_size_p, enlarge_window, delete_window.
6017 Remove static from declaration of Qdelete_window, it's
6018 temporarily needed by Fbury_buffer.
6019 (replace_window): Don't assign orig_top_line and
6020 orig_total_lines.
6021 (Fdelete_window, delete_window): Remove. Window deletion is
6022 handled by window.el.
640c8776
SM
6023 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6024 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
6025 (Fdelete_other_windows): Remove. Deleting other windows is
6026 handled by window.el.
6027 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6028 handled in window.el.
6029 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6030 Window minimum sizes are handled in window.el.
6031 (shrink_windows, size_window, set_window_height)
6032 (set_window_width, change_window_heights, window_height)
6033 (window_width, CURBEG, CURSIZE, enlarge_window)
6034 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6035 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6036 handled in window.el.
6037 (make_dummy_parent): Rename to make_parent_window and give it a
6038 second argument horflag.
6039 (make_window): Don't set resize_proportionally any more.
6040 (Fsplit_window): Remove. Windows are split in window.el.
6041 (save_restore_action, save_restore_orig_size)
6042 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6043 Resize mini windows in window.el.
6044 (grow_mini_window, shrink_mini_window): Implement by calling
6045 Qresize_root_window_vertically, resize_window_check and
6046 resize_window_apply.
640c8776
SM
6047 (saved_window, Fset_window_configuration, save_window_save):
6048 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6049 resize_proportionally.
6050 (window_min_height, window_min_width): Move to window.el.
6051 (keys_of_window): Move bindings for delete-other-windows,
6052 split-window, delete-window and enlarge-window to window.el.
6053
6054 * buffer.c: Temporarily extern Qdelete_window.
6055 (Fbury_buffer): Temporarily call Qdelete_window instead of
6056 Fdelete_window (Fbury_buffer will move to window.el soon).
6057
6058 * frame.c (set_menu_bar_lines_1): Remove code handling
6059 orig_top_line and orig_total_lines.
6060
6061 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6062 set_window_height but set heights directly.
6063 (change_frame_size_1): Use resize_frame_windows.
6064
6065 * xdisp.c (init_xdisp): Don't use set_window_height but set
6066 heights directly.
6067
640c8776
SM
6068 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6069 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6070 run_window_configuration_change_hook.
6071
6072 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6073 instead of change_window_heights and run
6074 run_window_configuration_change_hook.
6075
1a13852e
MR
60762011-06-09 Martin Rudalics <rudalics@gmx.at>
6077
6078 * window.c (replace_window): Rename second argument REPLACEMENT to
6079 NEW. New third argument SETFLAG. Rewrite.
6080 (delete_window, make_dummy_parent): Call replace_window with
6081 third argument 1.
6082 (window_list_1): Move down in code.
6083 (run_window_configuration_change_hook): Move set_buffer part
6084 before select_frame_norecord part in order to unwind correctly.
6085 Rename count1 to count.
6086 (recombine_windows, delete_deletable_window, resize_root_window)
6087 (Fdelete_other_windows_internal)
6088 (Frun_window_configuration_change_hook, make_parent_window)
6089 (resize_window_check, resize_window_apply, Fresize_window_apply)
6090 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6091 (Fdelete_window_internal, Fresize_mini_window_internal):
6092 New functions.
1a13852e
MR
6093 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6094
f3d1777e
MR
60952011-06-08 Martin Rudalics <rudalics@gmx.at>
6096
496e208e
MR
6097 * window.h (window): Add some new members to window structure -
6098 normal_lines, normal_cols, new_total, new_normal, clone_number,
6099 splits, nest, prev_buffers, next_buffers.
6100 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6101 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6102
f3d1777e
MR
6103 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6104 Remove.
496e208e
MR
6105 (make_dummy_parent): Set new members of windows structure.
6106 (make_window): Move down in code. Handle new members of window
6107 structure.
6108 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6109 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6110 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6111 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6112 (Fset_window_next_buffers, Fset_window_clone_number):
6113 New functions.
496e208e
MR
6114 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6115 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6116 Doc-string fixes.
6117 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6118 Argument WINDOW can be now internal window too.
6119 (Fwindow_use_time): Move up in code.
6120 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6121 Rewrite doc-string.
6122 (Fset_window_configuration, saved_window)
6123 (Fcurrent_window_configuration, save_window_save): Handle new
6124 members of window structure.
b9e809c2
MR
6125 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6126 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6127 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6128 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6129 Qget_mru_window, Qresize_root_window,
6130 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6131 Qauto_buffer_name; staticpro them.
f3d1777e 6132
abde8f8c
MR
61332011-06-07 Martin Rudalics <rudalics@gmx.at>
6134
6135 * window.c (Fwindow_total_size, Fwindow_left_column)
6136 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6137 (Fwindow_list_1): New functions.
6138 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6139 (Fwindow_width, Fscroll_left, Fscroll_right):
6140 Use window_body_cols instead of window_box_text_cols.
6141 (delete_window, Fset_window_configuration):
6142 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6143 (delete_all_subwindows): Take a window as argument and not a
6144 structure. Rewrite.
190b47e6
MR
6145 (window_loop): Remove handling of GET_LRU_WINDOW and
6146 GET_LARGEST_WINDOW.
6147 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6148
6149 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6150 window_box_text_cols. delete_all_subwindows now takes a
6151 Lisp_Object as argument.
abde8f8c 6152
640c8776
SM
6153 * indent.c (compute_motion, Fcompute_motion):
6154 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6155
fa8a67e6
MR
6156 * frame.c (delete_frame): Call delete_all_subwindows with root
6157 window as argument.
6158
a54e3482
DC
61592011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6160
6161 * fns.c (Fputhash): Document return value.
6162
60002bf5
CY
61632011-06-06 Chong Yidong <cyd@stupidchicken.com>
6164
6165 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6166
0c671da6 61672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6168
b862a52a 6169 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6170
be44ca6c
PE
6171 Check for overflow when converting integer to cons and back.
6172 * charset.c (Fdefine_charset_internal, Fdecode_char):
6173 Use cons_to_unsigned to catch overflow.
6174 (Fencode_char): Use INTEGER_TO_CONS.
6175 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6176 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6177 * data.c (long_to_cons, cons_to_long): Remove.
6178 (cons_to_unsigned, cons_to_signed): New functions.
6179 These signal an error for invalid or out-of-range values.
6180 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6181 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6182 * font.c (Ffont_variation_glyphs):
6183 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6184 * lisp.h: Include <intprops.h>.
6185 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6186 (cons_to_signed, cons_to_unsigned): New decls.
6187 (long_to_cons, cons_to_long): Remove decls.
6188 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6189 (Fprimitive_undo): Use CONS_TO_INTEGER.
6190 * xfns.c (Fx_window_property): Likewise.
6191 * xselect.c: Include <limits.h>.
6192 (x_own_selection, selection_data_to_lisp_data):
6193 Use INTEGER_TO_CONS.
6194 (x_handle_selection_request, x_handle_selection_clear)
6195 (x_get_foreign_selection, Fx_disown_selection_internal)
6196 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6197 (lisp_data_to_selection_data): Use cons_to_unsigned.
6198 (x_fill_property_data): Use cons_to_signed.
6199 Report values out of range.
6200
d1f3d2af
PE
6201 Check for buffer and string overflow more precisely.
6202 * buffer.h (BUF_BYTES_MAX): New macro.
6203 * lisp.h (STRING_BYTES_MAX): New macro.
6204 * alloc.c (Fmake_string):
6205 * character.c (string_escape_byte8):
6206 * coding.c (coding_alloc_by_realloc):
6207 * doprnt.c (doprnt):
6208 * editfns.c (Fformat):
6209 * eval.c (verror):
6210 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6211 since they may not be the same number.
6212 * editfns.c (Finsert_char):
6213 * fileio.c (Finsert_file_contents):
6214 Likewise for BUF_BYTES_MAX.
6215
dd52fcea
PE
6216 * image.c: Use ptrdiff_t, not int, for sizes.
6217 (slurp_file): Switch from int to ptrdiff_t.
6218 All uses changed.
6219 (slurp_file): Check that file size fits in both size_t (for
6220 malloc) and ptrdiff_t (for sanity and safety).
6221
7f9bbdbb
PE
6222 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6223 if b->modtime has its maximal value.
6224
dfe18f82
PE
6225 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6226
84acfcf0
PE
6227 Don't assume time_t can fit into int.
6228 * buffer.h (struct buffer.modtime): Now time_t, not int.
6229 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6230 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6231
ccd9a01a
PE
6232 Minor fixes for signed vs unsigned integers.
6233 * character.h (MAYBE_UNIFY_CHAR):
6234 * charset.c (maybe_unify_char):
6235 * keyboard.c (read_char, reorder_modifiers):
6236 XINT -> XFASTINT, since the integer must be nonnegative.
6237 * ftfont.c (ftfont_spec_pattern):
6238 * keymap.c (access_keymap, silly_event_symbol_error):
6239 XUINT -> XFASTINT, since the integer must be nonnegative.
6240 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6241 since it makes no difference and we prefer signed.
6242 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6243 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6244 nonnegative.
6245
d6d100dd
SM
62462011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6247
6248 * window.h (Fwindow_frame): Declare.
6249
2b6148e4
PE
62502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6251
6252 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6253 (SPARE_MEMORY): Always define.
6254 (LARGE_REQUEST): Remove.
6255 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6256
f230ecc9
MR
62572011-06-06 Martin Rudalics <rudalics@gmx.at>
6258
727e958e
MR
6259 * lisp.h: Move EXFUNS for Fframe_root_window,
6260 Fframe_first_window and Fset_frame_selected_window to window.h.
6261
6262 * window.h: Move EXFUNS for Fframe_root_window,
6263 Fframe_first_window and Fset_frame_selected_window here from
6264 lisp.h.
6265
6266 * frame.c (Fwindow_frame, Fframe_first_window)
6267 (Fframe_root_window, Fframe_selected_window)
6268 (Fset_frame_selected_window): Move to window.c.
6269 (Factive_minibuffer_window): Move to minibuf.c.
6270 (Fother_visible_frames_p): New function.
6271
6272 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6273
f230ecc9
MR
6274 * window.c (decode_window, decode_any_window): Move up in code.
6275 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6276 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6277 (Fwindow_buffer): Move up and rewrite doc-string.
6278 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6279 (Fwindow_prev): New functions.
727e958e
MR
6280 (Fwindow_frame): Move here from frame.c. Accept any window as
6281 argument.
6282 (Fframe_root_window, Fframe_first_window)
6283 (Fframe_selected_window): Move here from frame.c. Accept frame
6284 or arbitrary window as argument. Update doc-strings.
6285 (Fminibuffer_window): Move up in code.
6286 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6287 (Fset_frame_selected_window): Move here from frame.c.
6288 Marginal rewrite.
727e958e
MR
6289 (Fselected_window, select_window, Fselect_window): Move up in
6290 code. Minor doc-string fixes.
f230ecc9 6291
4d09bcf6
PE
62922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6293
6294 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6295 Do not assume that spare memory exists; that assumption is valid
6296 only if SYSTEM_MALLOC.
6297 (LARGE_REQUEST): New macro, so that the issue of large requests
6298 is separated from the issue of spare memory.
6299
810928a2
AS
63002011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6301
172418ad
AS
6302 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6303 format. (Bug#8806)
6304
43f862f7
AS
6305 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6306
810928a2
AS
6307 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6308 before statements.
6309
a059fe24
JD
63102011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6311
6312 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6313
6314 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6315
6316 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6317 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6318
989bf368
JB
63192011-06-05 Juanma Barranquero <lekktu@gmail.com>
6320
6321 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6322
4b80f674
CY
63232011-06-04 Chong Yidong <cyd@stupidchicken.com>
6324
6325 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6326 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6327 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6328 New error handlers.
4b80f674
CY
6329 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6330 Obey Vx_select_enable_clipboard_manager. Catch errors in
6331 x_clipboard_manager_save (Bug#8779).
6332 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6333 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6334
99a33b77 63352011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6336
6337 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6338
99a33b77 63392011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6340
6341 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6342 in the current matrix if keep_current_p is non-zero.
6343
8264569d
EZ
63442011-06-04 Eli Zaretskii <eliz@gnu.org>
6345
6346 * bidi.c (bidi_level_of_next_char): Fix last change.
6347
57f97249
EZ
63482011-06-03 Eli Zaretskii <eliz@gnu.org>
6349
fec2107c 6350 Support bidi reordering of text covered by display properties.
57f97249 6351
fec2107c
EZ
6352 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6353 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6354 (bidi_cache_search, bidi_cache_iterator_state)
6355 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6356 (bidi_level_of_next_char, bidi_move_to_visually_next):
6357 Support character positions inside a run of characters covered by a
fec2107c
EZ
6358 display string.
6359 (bidi_paragraph_init, bidi_resolve_explicit_1)
6360 (bidi_level_of_next_char): Call bidi_fetch_char and
6361 bidi_fetch_char_advance instead of FETCH_CHAR and
6362 FETCH_CHAR_ADVANCE.
6363 (bidi_init_it): Initialize new members.
6364 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6365 definitions.
6366 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6367 instead of using explicit *_CHAR codes.
d6d100dd
SM
6368 (bidi_resolve_explicit, bidi_resolve_weak):
6369 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6370 bidirectional text is supported only in multibyte buffers.
6371 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6372 it to initialize the frame_window_p member of struct bidi_it.
6373 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6374 (bidi_resolve_explicit, bidi_resolve_weak)
6375 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6376 bidi_it->nchars is non-positive.
6377 (bidi_level_of_next_char): Don't try to lookup the cache for the
6378 next/previous character if nothing is cached there yet, or if we
6379 were just reseat()'ed to a new position.
c40e2fb2 6380
0e14fe90
EZ
6381 * xdisp.c (set_cursor_from_row): Set start and stop points
6382 according to the row's direction when priming the loop that looks
6383 for the glyph on which to display cursor.
6384 (single_display_spec_intangible_p): Function deleted.
6385 (display_prop_intangible_p): Reimplement to call
6386 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6387 Accept 3 additional arguments needed by handle_display_spec.
6388 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6389 values: lists, `(when COND...)' forms, etc.
6390 (single_display_spec_string_p): Support property values that are
6391 lists with the argument STRING its top-level element.
6392 (display_prop_string_p): Fix the condition for processing a
6393 property that is a list to be consistent with handle_display_spec.
fec2107c 6394 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6395 last portion of handle_display_prop.
6396 (compute_display_string_pos): Accept additional argument
6397 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6398 value of a `display' property is a "replacing spec".
6399 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6400 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6401 the display property, but just return a value indicating whether
6402 the display property will replace the characters it covers.
6403 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6404 frame_window_p members of struct bidi_it.
d6d100dd
SM
6405 (compute_display_string_pos, compute_display_string_end):
6406 New functions.
fec2107c
EZ
6407 (push_it): Accept second argument POSITION, where pop_it should
6408 jump to continue iteration.
6409 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6410
fec2107c
EZ
6411 * keyboard.c (adjust_point_for_property): Adjust the call to
6412 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6413
6414 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6415 (bidi_init_it): Update prototypes.
6416 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6417 (compute_display_string_pos, compute_display_string_end):
6418 Declare prototypes.
fec2107c
EZ
6419 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6420 EMACS_INT.
fc6f18ce 6421
40087514 64222011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6423
57f53182
PE
6424 Malloc failure behavior now depends on size of allocation.
6425 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6426 * lisp.h: Change signatures accordingly.
6427 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6428 All callers changed. (Bug#8762)
6429
6430 * gnutls.c: Use Emacs's memory allocators.
6431 Without this change, the gnutls library would invoke malloc etc.
6432 directly, which causes problems on non-SYNC_INPUT hosts, and which
6433 runs afoul of improving memory_full behavior. (Bug#8761)
6434 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6435 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6436 xfree instead of the default malloc, realloc, free.
6437 (Fgnutls_boot): No need to check for memory allocation failure,
6438 since xmalloc does that for us.
6439
ac32cd99 6440 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6441 * category.c (hash_get_category_set):
6442 * ccl.c (ccl_driver):
6443 * charset.c (Fdefine_charset_internal):
6444 * charset.h (struct charset.hash_index):
6445 * composite.c (get_composition_id, gstring_lookup_cache)
6446 (composition_gstring_put_cache):
6447 * composite.h (struct composition.hash_index):
6448 * dispextern.h (struct image.hash):
6449 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6450 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6451 (hashfn_equal, hashfn_user_defined, make_hash_table)
6452 (maybe_resize_hash_table, hash_lookup, hash_put)
6453 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6454 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6455 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6456 * image.c (make_image, search_image_cache, lookup_image)
6457 (xpm_put_color_table_h):
6458 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6459 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6460 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6461 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6462 * alloc.c (allocate_vectorlike):
6463 Check for overflow in vector size calculations.
6464 * ccl.c (ccl_driver):
6465 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6466 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6467 need to be updated by these changes.
40087514
PE
6468 * fns.c (make_hash_table, maybe_resize_hash_table):
6469 Check for integer overflow with large hash tables.
0de4bb68
PE
6470 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6471 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6472 (SXHASH_REDUCE): New macro.
6473 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6474 Use it instead of discarding useful hash info with large hash values.
6475 (sxhash_float): New function.
6476 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6477 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6478 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6479 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6480 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6481 Adjust signatures to match updated version of code.
6482 (consing_since_gc): Now EMACS_INT, since a single hash table can
6483 use more than INT_MAX bytes.
6484
698d32e2
DN
64852011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6486
6487 Make it possible to build with GCC-4.6+ -O2 -flto.
6488
6489 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6490
fd6fa53f
SM
64912011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6492
6493 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6494 Call minibuffer-inactive-mode.
6495
864db017
JB
64962011-05-31 Juanma Barranquero <lekktu@gmail.com>
6497
6498 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6499 Update dependencies.
6500
2ad0baf4
DN
65012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6502
6503 * data.c (init_data): Remove code for UTS, this system is not
6504 supported anymore.
6505
4fcc2638
DN
65062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6507
6508 Don't force ./temacs to start in terminal mode.
6509
6510 * frame.c (make_initial_frame): Initialize faces in all cases, not
6511 only when CANNOT_DUMP is defined.
6512 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6513
c56e0fd5
DN
65142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6515
6516 * dispnew.c (add_window_display_history): Use const for the string
6517 pointer. Remove declaration, not needed.
6518
333d54da 65192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6520
55d4c1b2 6521 Use 'inline', not 'INLINE'.
333d54da 6522 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6523 * alloc.c, fontset.c (INLINE): Remove.
6524 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6525 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6526 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6527 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6528 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6529
738db178
DN
65302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6531
6532 Make it possible to run ./temacs.
6533
6534 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6535 syms_of_callproc does the same thing. Remove test for
6536 "initialized", do it in the caller.
6537 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6538
620c53a6
SM
65392011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6540
6541 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6542 (read_minibuf): Use get_minibuffer.
6543 (syms_of_minibuf): Use DEFSYM.
6544 (Qmetadata): New var.
6545 * data.c (Qbuffer): Don't make it static.
6546 (syms_of_data): Use DEFSYM.
6547
e003a292
PE
65482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6549
6550 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6551 (CCL_CODE_MIN): New macro.
6552
ed008a6d
PE
65532011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6554
3687c2ef
PE
6555 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6556
ed008a6d
PE
6557 * eval.c (Qdebug): Now static.
6558 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6559 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6560 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6561
d66c4c7c
CY
65622011-05-29 Chong Yidong <cyd@stupidchicken.com>
6563
6564 * image.c: Various fixes to ImageMagick code comments.
6565 (Fimagemagick_types): Doc fix.
6566
5fbc2025
PE
65672011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6568
0196f88a
PE
6569 Minor fixes prompted by GCC 4.6.0 warnings.
6570
6571 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6572
5fbc2025
PE
6573 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6574 (x_clipboard_manager_save_all): Move extern decl to ...
6575 * xterm.h: ... here, so that it can be checked for consistency.
6576
1dd3c2d9
CY
65772011-05-29 Chong Yidong <cyd@stupidchicken.com>
6578
6579 * xselect.c (x_clipboard_manager_save_frame)
6580 (x_clipboard_manager_save_all): New functions.
6581 (Fx_clipboard_manager_save): Lisp function deleted.
6582
6583 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6584 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6585
6586 * xterm.h: Update prototype.
6587
5ba6571d
WX
65882011-05-28 William Xu <william.xwl@gmail.com>
6589
6590 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6591 exiting (Bug#8239).
6592
3eaff834
JM
65932011-05-28 Jim Meyering <meyering@redhat.com>
6594
e1900994 6595 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6596 * fns.c (to_uchar): Define.
6597 (crypto_hash_function): Use it to convert some newly-signed
6598 variables to unsigned, to avoid sign-extension bugs. For example,
6599 without this change, (md5 "truc") would evaluate to
6600 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6601 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6602 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6603
0f6990a7
PE
66042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6605
6606 Integer overflow fixes.
c8a9ca5a 6607
08686060
PE
6608 * dbusbind.c: Serial number integer overflow fixes.
6609 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6610 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6611 to hold a serial number that is too large for a fixnum.
6612 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6613 Check for serial numbers out of range. Decode any serial number
59568bf0 6614 that was so large that it became a float. (Bug#8722)
08686060 6615
2d1fc3c7
PE
6616 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6617 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6618 Use XFASTINT rather than XUINT when numbers are nonnegative.
6619 (xd_append_arg, Fdbus_method_return_internal):
6620 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6621 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6622 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6623 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6624 (Bug#8722)
2d1fc3c7 6625
c8a9ca5a
PE
6626 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6627
519e1d69
PE
6628 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6629
6df6ae42 6630 ccl: Add integer overflow checks.
30569699
PE
6631 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6632 (IN_INT_RANGE): New macros.
6633 (ccl_driver): Use them to check for integer overflow when
6634 decoding a CCL program. Many of the new checks are whether XINT (x)
6635 fits in int; it doesn't always, on 64-bit hosts. The new version
6636 doesn't catch all possible integer overflows, but it's an
847044ea 6637 improvement. (Bug#8719)
30569699 6638
c11285dc
PE
6639 * alloc.c (make_event_array): Use XINT, not XUINT.
6640 There's no need for unsigned here.
6641
fdccd48e
PE
6642 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6643 This follows up to the 2011-05-06 change that substituted uintptr_t
6644 for EMACS_INT. This case wasn't caught back then.
6645
37910ab2
PE
6646 Rework Fformat to avoid integer overflow issues.
6647 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6648 now (part of C89). Include <verify.h>.
6649 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6650 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6651 (Fformat): Avoid the prepass trying to compute sizes; it was only
6652 approximate and thus did not catch overflow reliably. Instead, walk
6653 through the format just once, formatting and computing sizes as we go,
6654 checking for integer overflow at every step, and allocating a larger
6655 buffer as needed. Keep track separately whether the format is
6656 multibyte. Keep only the most-recently calculated precision, rather
6657 than them all. Record whether each argument has been converted to
6658 string. Use EMACS_INT, not int, for byte and char and arg counts.
6659 Support field widths and precisions larger than INT_MAX. Avoid
6660 sprintf's undefined behavior with conversion specifications such as %#d
6661 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6662 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6663 formatting out-of-range floating point numbers with int
9173deec 6664 formats. (Bug#8668)
37910ab2 6665
2e6578fb
PE
6666 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6667
0ae6bdee
PE
6668 * data.c: Avoid integer truncation in expressions involving floats.
6669 * data.c: Include <intprops.h>.
6670 (arith_driver): When there's an integer overflow in an expression
6671 involving floating point, convert the integers to floating point
6672 so that the resulting value does not suffer from catastrophic
6673 integer truncation. For example, on a 64-bit host (* 4
6674 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6675 Do not rely on undefined behavior after integer overflow.
6676
de883a70
PE
6677 merge count_size_as_multibyte, parse_str_to_multibyte
6678 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6679 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6680 Check for integer overflow.
6681 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6682 since it's now a duplicate of the other. This is more of
6683 a character than a buffer op, so better that it's in character.c.
6684 * fns.c, print.c: Adjust to above changes.
6685
2ff916cb
PE
66862011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6687
6688 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6689
f1b54466
PE
66902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6691
fb1ac845
PE
6692 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6693 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6694 (x_clipboard_manager_save): Now static.
6695 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6696
f1b54466
PE
6697 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6698 (crypto_hash_function): Now static.
6699 Fix pointer signedness problems. Avoid unnecessary initializations.
6700
a9f737ee
CY
67012011-05-27 Chong Yidong <cyd@stupidchicken.com>
6702
6703 * termhooks.h (Vselection_alist): Make it terminal-local.
6704
6705 * terminal.c (create_terminal): Initialize it.
6706
6707 * xselect.c: Support for clipboard managers.
6708 (Vselection_alist): Move to termhooks.h as terminal-local var.
6709 (LOCAL_SELECTION): New macro.
6710 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6711 (symbol_to_x_atom): Remove gratuitous arg.
6712 (x_handle_selection_request, lisp_data_to_selection_data)
6713 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6714 (x_own_selection, x_get_local_selection, x_convert_selection):
6715 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6716 (some_frame_on_display): Delete unused function.
6717 (Fx_own_selection_internal, Fx_get_selection_internal)
6718 (Fx_disown_selection_internal, Fx_selection_owner_p)
6719 (Fx_selection_exists_p): New optional frame arg.
6720 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6721 (x_handle_selection_clear): Don't treat other terminals with the
6722 same keyboard specially. Use the terminal-local Vselection_alist.
6723 (x_clear_frame_selections): Use Frun_hook_with_args.
6724
6725 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6726
6727 * xterm.h: Add support for those atoms.
6728
e067f0c1
CY
67292011-05-26 Chong Yidong <cyd@stupidchicken.com>
6730
6731 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6732 (converted_selections, conversion_fail_tag): New global variables.
6733 (x_selection_request_lisp_error): Free the above.
6734 (x_get_local_selection): Remove unnecessary code.
6735 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6736 of converted selections stored in converted_selections.
6737 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6738 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6739 (x_convert_selection): New function.
6740 (x_handle_selection_event): Simplify.
6741 (x_get_foreign_selection): Don't ignore incoming requests while
6742 waiting for an answer; this will fail when we implement
6743 SAVE_TARGETS, and seems unnecessary anyway.
6744 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6745 (Vx_sent_selection_functions): Doc fix.
6746
0f4aebc0
LL
67472011-05-26 Leo Liu <sdl.web@gmail.com>
6748
6749 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6750
e61124cd
YM
67512011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6752
6753 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6754
6755 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6756 for fringe update if it has periodic bitmap.
ac389d0c 6757 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6758 and fringe_bitmap_periodic_p.
6759
6760 * fringe.c (get_fringe_bitmap_data): New function.
6761 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6762 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6763 row. Mark glyph row for fringe update if periodicity changed.
6764
6765 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6766 for fringe update unless it has periodic bitmap.
6767
f16d9837
KH
67682011-05-25 Kenichi Handa <handa@m17n.org>
6769
6770 * xdisp.c (get_next_display_element): Set correct it->face_id for
6771 a static composition.
6772
e1b90ef6
LL
67732011-05-24 Leo Liu <sdl.web@gmail.com>
6774
6775 * deps.mk (fns.o):
6776 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6777
6778 * fns.c (crypto_hash_function, Fsha1): New function.
6779 (Fmd5): Use crypto_hash_function.
6780 (syms_of_fns): Add Ssha1.
6781
7400048f
PE
67822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6783
6784 * gnutls.c: Remove unused macros.
6785 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6786 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6787 Remove macros that are defined and never used.
6788 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6789
abb71cf4
CY
67902011-05-22 Chong Yidong <cyd@stupidchicken.com>
6791
6792 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6793 (Fx_get_selection_internal): Minor cleanup.
6794 (Fx_own_selection_internal): Rename arguments for consistency with
6795 select.el.
6796
6307db39
PE
67972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6798
6799 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6800
f3d4e0a4
CY
68012011-05-22 Chong Yidong <cyd@stupidchicken.com>
6802
6803 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6804
4d8ade89
YM
68052011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6806
6807 * dispnew.c (scrolling_window): Don't exclude the case that the
6808 last enabled row in the desired matrix touches the bottom boundary.
6809
32078c8d
GM
68102011-05-21 Glenn Morris <rgm@gnu.org>
6811
6812 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6813 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6814 and add some more files.
32078c8d 6815
7285dc67
EZ
68162011-05-20 Eli Zaretskii <eliz@gnu.org>
6817
6818 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6819 report_file_error introduced by the change from 2011-05-07.
6820
89d1bd22
PE
68212011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6822
6823 * systime.h (Time): Define only if emacs is defined.
6824 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6825 where the include path doesn't have X11/X.h by default. See
6826 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6827
cd394be1 68282011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6829
6830 * composite.c (find_automatic_composition): Fix previous change.
6831
b9704ad9
GM
68322011-05-20 Glenn Morris <rgm@gnu.org>
6833
6834 * lisp.mk: New file, split from Makefile.in.
6835 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6836 (shortlisp): Remove.
6837 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6838
4a720484
GM
68392011-05-19 Glenn Morris <rgm@gnu.org>
6840
6841 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6842 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6843 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6844 (lisp): Set the order to that of loadup.el.
6845 (shortlisp): Make it a copy of $lisp.
6846 (SOME_MACHINE_LISP): Remove.
6847 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6848 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6849
a28d4396
KH
68502011-05-18 Kenichi Handa <handa@m17n.org>
6851
6852 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6853 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6854 (find_automatic_composition): Mostly rewrite for efficiency.
6855
a2b1fa8e
JB
68562011-05-18 Juanma Barranquero <lekktu@gmail.com>
6857
6858 * makefile.w32-in: Update dependencies.
6859
8e1f5610
CS
68602011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6861
6862 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6863 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6864
7025ee00 68652011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6866
cdfa6eab
PE
6867 Fix some integer overflow issues, such as string length overflow.
6868
06d6db33
PE
6869 * insdel.c (count_size_as_multibyte): Check for string overflow.
6870
2b4560a8
PE
6871 * character.c (lisp_string_width): Check for string overflow.
6872 Use EMACS_INT, not int, for string indexes and lengths; in
6873 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6874 the resulting string length overflows an EMACS_INT; instead,
6875 report a string overflow if no precision given. When checking for
6876 precision exhaustion, use a check that cannot possibly have
6877 integer overflow. (Bug#8675)
6878 * character.h (lisp_string_width): Adjust to new signature.
6879
cb93f9be
PE
6880 * alloc.c (string_overflow): New function.
6881 (Fmake_string): Use it. This doesn't change behavior, but saves
6882 a few bytes and will simplify future changes.
6883 * character.c (string_escape_byte8): Likewise.
6884 * lisp.h (string_overflow): New decl.
6885
1a1f3366
PE
6886 Fixups, following up to the user-interface timestamp change.
6887 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6888 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6889 * msdos.c (mouse_get_pos): Likewise.
6890 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6891 * w32gui.h (Time): Define by including "systime.h" rather than by
6892 declaring it ourselves. (Bug#8664)
6893
d4e3e4d3
PE
6894 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6895 * image.c (clear_image_cache): Likewise.
6896
f6a24d19
PE
6897 * term.c (term_mouse_position): Don't assume time_t wraparound.
6898
08dc5ae6
PE
6899 Be more systematic about user-interface timestamps.
6900 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6901 and sometimes 'EMACS_UINT', to represent these timestamps.
6902 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6903 This makes the code easier to follow, and makes it easier to catch
6904 integer overflow bugs such as Bug#8664.
6905 * frame.c (Fmouse_position, Fmouse_pixel_position):
6906 Use Time, not unsigned long, for user-interface timestamps.
6907 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6908 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6909 * keyboard.h (last_event_timestamp): Likewise.
6910 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6911 * menu.h (xmenu_show): Likewise.
6912 * term.c (term_mouse_position): Likewise.
6913 * termhooks.h (struct input_event.timestamp): Likewise.
6914 (struct terminal.mouse_position_hook): Likewise.
6915 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6916 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6917 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6918 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6919 what it was before.
6920 * menu.h, termhooks.h: Include "systime.h", for Time.
6921
8e55734a
PE
6922 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6923 Don't assume that the difference between two unsigned long values
6924 can fit into an integer. At this point, we know button_down_time
6925 <= event->timestamp, so the difference must be nonnegative, so
6926 there's no need to cast the result if double-click-time is
6927 nonnegative, as it should be; check that it's nonnegative, just in
6928 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6929 apart (about 25 days). (Bug#8664)
8e55734a 6930
841f1b75 6931 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6932 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6933
3e26f69c
PE
6934 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6935 that always fit in int. Use a sentinel instead of a counter, to
6936 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6937 * frame.h (struct frame): Use int for menu_bar_items_used
6938 instead of EMACS_INT, since it always fits in int.
3e26f69c 6939
5cc152c0
PE
6940 * menu.c (grow_menu_items): Check for int overflow.
6941
d89eb65e
PE
6942 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6943
5235bd3e
PE
6944 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6945 Before, the code was not consistent. These values cannot exceed
6946 2**31 - 1 so there's no need to make them unsigned.
6947 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6948 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6949 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6950 as modifiers.
6951 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6952
bc827e23
PE
6953 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6954 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6955 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6956 presumably because the widths might not match.
6957
78eb494e
PE
6958 * window.c (size_window): Avoid needless test at loop start.
6959
04f2d78b
CB
69602011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6961
6962 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6963
d2fc7e3d 69642011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6965
6966 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6967
d2fc7e3d 69682011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6969
6970 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6971 `width' to `bar_area_x' and `bar_area_width', respectively.
6972 (x_scroll_run): Take account of fringe background extension.
6973
04f2d78b
CB
6974 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6975 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6976 `bar_area_width', respectively.
6977 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6978 background extension.
6979
79b70037
GM
69802011-05-10 Jim Meyering <meyering@redhat.com>
6981
6982 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6983
2f142cc5
JB
69842011-05-10 Juanma Barranquero <lekktu@gmail.com>
6985
6986 * image.c (Finit_image_library): Return t for built-in image types,
6987 like pbm and xbm. (Bug#8640)
6988
57679c86
AS
69892011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6990
6991 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6992
888c9e86
EZ
69932011-05-07 Eli Zaretskii <eliz@gnu.org>
6994
b0512a1d
EZ
6995 * w32console.c (Fset_screen_color): Doc fix.
6996 (Fget_screen_color): New function.
6997 (syms_of_ntterm): Defsubr it.
6998
7285dc67
EZ
6999 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7000 unlink the temporary file if Fcall_process didn't create it in the
7001 first place.
7002 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7003 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
7004 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7005 cue to call_process_cleanup not to close that handle.
7006
4d3fcc8e
BK
70072011-05-07 Ben Key <bkey76@gmail.com>
7008
7009 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7010 one of two shell specific rules, either bootstrap-temacs-CMD or
7011 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7012 to the previous implementation of the bootstrap-temacs rule.
7013 The bootstrap-temacs-CMD rule is similar to the previous
7014 implementation of the bootstrap-temacs rule except that it
7015 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7016 variable.
7017
7018 These changes, along with some changes to nt/configure.bat,
7019 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7020 earlier fix to add support for --cflags and --ldflags options
7021 that include quotes so that it works whether make uses cmd or
7022 sh as the shell.
7023
b4289b64
MA
70242011-05-06 Michael Albinus <michael.albinus@gmx.de>
7025
7026 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7027 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7028 is a constant.
7029 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7030 a string. Handle both cases.
7031 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7032 (Fdbus_register_method): Use Qinvalid_function.
7033
af4c0e28
JB
70342011-05-06 Juanma Barranquero <lekktu@gmail.com>
7035
7036 * makefile.w32-in: Update dependencies.
7037 (LISP_H): Add inttypes.h and stdin.h.
7038 (PROCESS_H): Add unistd.h.
7039
c51453d9
EZ
70402011-05-06 Eli Zaretskii <eliz@gnu.org>
7041
7042 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7043 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7044
8ff0ac3c 70452011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7046
4c4b566b
PE
7047 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7048
aab2b9b5
PE
7049 * term.c (vfatal): Remove stray call to va_end.
7050 It's not needed and the C Standard doesn't allow it here anyway.
7051
c378da0b
PE
7052 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7053 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7054
288b08c7
PE
7055 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7056 bytes.
7057
e3601888
PE
7058 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7059
db6c0e74
PE
7060 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7061
dd5963ea
PE
7062 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7063
88c9450f
PE
7064 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7065
2f9442b8
PE
7066 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7067
c032b5f8
PE
7068 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7069 * charset.c (Fdefine_charset_internal): Don't initialize
7070 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7071 32-bit int (Bug#8600).
a108c10b
PE
7072
7073 * lread.c (read_integer): Be more consistent with string-to-number.
7074 Use string_to_number to do the actual conversion; this avoids
7075 rounding errors and fixes some other screwups. Without this fix,
7076 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7077 (digit_to_number): Move earlier, for benefit of read_integer.
7078 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7079 not a digit in any supported base. (Bug#8602)
a108c10b 7080
ad5f9eea
PE
7081 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7082
aec1708a
PE
7083 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7084 to match comment at start of function. This also removes a
7085 GCC warning about overflow in a 32+64-bit port.
7086
47be4ab5
PE
7087 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7088
371cac43
PE
7089 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7090 Reported by Stefan Monnier in
7091 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7092 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7093 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7094
d01a7826
PE
7095 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7096 (EMACS_UINTPTR): Likewise, with uintptr_t.
7097
7fd47d5c
PE
7098 * lisp.h: Prefer 64-bit EMACS_INT if available.
7099 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7100 on 32-bit hosts that have 64-bit int, so that they can access
7101 large files.
122b0c86
PE
7102 However, temporarily disable this change unless the temporary
7103 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7104
8727937b
PE
7105 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7106
8ac068ac
PE
7107 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7108 This removes an assumption that EMACS_INT and long are the same
7109 width as pointers. The assumption is true for Emacs porting targets
7110 now, but we want to make other targets possible.
7111 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7112 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7113 In the rest of the code, change types of integers that hold casted
7114 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7115 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7116 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7117 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7118 No need to cast type when ORing.
7119 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7120 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7121 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7122 assume EMACS_INT is the same width as char *.
7123 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7124 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7125 Remove no-longer-needed casts.
7126 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7127 (xg_tool_bar_help_callback, xg_make_tool_item):
7128 Use EMACS_INTPTR to hold an integer
7129 that will be cast to void *; this can avoid a GCC warning
7130 if EMACS_INT is not the same width as void *.
7131 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7132 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7133 (current_message_1, set_message_1):
7134 Use a local to convert to proper width without a cast.
7135 * xmenu.c (dialog_selection_callback): Likewise.
7136
ede49d71
PE
7137 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7138 Also, don't assume VALBITS / RAND_BITS is less than 5,
7139 and don't rely on undefined behavior when shifting a 1 left into
7140 the sign bit.
7141 * lisp.h (get_random): Change signature to match.
7142
2f30ecd0
PE
7143 * lread.c (hash_string): Use size_t, not int, for hash computation.
7144 Normally we prefer signed values; but hashing is special, because
7145 it's better to use unsigned division on hash table sizes so that
7146 the remainder is nonnegative. Also, size_t is the natural width
7147 for hashing into memory. The previous code used 'int', which doesn't
7148 retain enough info to hash well into very large tables.
7149 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7150
2a866e7b
PE
7151 * dbusbind.c: Don't possibly lose pointer info when converting.
7152 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7153 Use XPNTR rather than XHASH, so that the high-order bits of
7154 the pointer aren't lost when converting through void *.
7155
51639eac
PE
7156 * eval.c (Fautoload): Don't double-shift a pointer.
7157
92394119
PE
7158 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7159
dbdb9a7c
JB
71602011-05-06 Juanma Barranquero <lekktu@gmail.com>
7161
7162 * gnutls.c (DEF_GNUTLS_FN):
7163 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7164
db7a0b4f
AS
71652011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7166
7167 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7168 marker. (Bug#8610)
7169
cd394be1 71702011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7171
7172 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7173 New version that can reserve upto 2GB of heap space.
7174
f7ff1b0f 71752011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7176
7177 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7178
639c109b
TZ
71792011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7180
7181 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7182 `gnutls_certificate_set_x509_key_file'.
7183
d2127135
JB
71842011-05-05 Juanma Barranquero <lekktu@gmail.com>
7185
7186 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7187 Update dependencies.
7188
e968f4f3
JB
71892011-05-04 Juanma Barranquero <lekktu@gmail.com>
7190
7191 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7192 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7193 Remove unused parameter `fildes'.
7194 * process.c (read_process_output, send_process): Don't pass it.
7195
84d358f0
JB
71962011-05-04 Juanma Barranquero <lekktu@gmail.com>
7197
7198 Fix previous change: the library cache is defined in w32.c.
7199 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7200 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7201
0898ca10
JB
72022011-05-04 Juanma Barranquero <lekktu@gmail.com>
7203
7204 Implement dynamic loading of GnuTLS on Windows.
7205
7206 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7207 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7208 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7209 Declare.
7210
7211 * gnutls.c (Qgnutls_dll): Define.
7212 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7213 (gnutls_*): Declare function pointers.
7214 (init_gnutls_functions): New function to initialize function pointers.
7215 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7216 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7217 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7218 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7219 (emacs_gnutls_write, emacs_gnutls_read)
7220 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7221 (Fgnutls_available_p): New function.
7222 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7223 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7224 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7225
7226 * image.c: Include w32.h.
7227 (Vimage_type_cache): Delete.
7228 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7229 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7230 (w32_delayed_load): Move to w32.c.
7231
7232 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7233
7234 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7235 (w32_delayed_load): Move from image.c. When loading a library, record
7236 its filename in the :loaded-from property of the library id.
7237 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7238 Initialize and staticpro them.
7239 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7240
7241 * process.c: Include lisp.h before w32.h, not after.
7242 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7243 instead of gnutls_record_check_pending.
7244
7245 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7246
ff4de4aa
TZ
72472011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7248
7249 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7250 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7251 as passed in.
7252
abe95abb
JD
72532011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7254
7255 * xterm.c (x_set_frame_alpha): Do not set property on anything
7256 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7257
e16e55d4
JB
72582011-05-02 Juanma Barranquero <lekktu@gmail.com>
7259
7260 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7261
bafcf6a5
JB
72622011-05-02 Juanma Barranquero <lekktu@gmail.com>
7263
7264 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7265 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7266 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7267 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7268 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7269 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7270 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7271 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7272 (Qgnutls_bootprop_callbacks_verify): Make static.
7273
e7a6747f
AS
72742011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7275
19ed11ba
AS
7276 * callproc.c: Indentation fixup.
7277
e7a6747f 7278 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7279 (wait_for_termination, interruptible_wait_for_termination):
7280 Move after wait_for_termination_1.
e7a6747f 7281
1ef14cb4
LMI
72822011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7283
7284 * sysdep.c (interruptible_wait_for_termination): New function
7285 which is like wait_for_termination, but allows keyboard
7286 interruptions.
7287
7288 * callproc.c (Fcall_process): Add (:file "file") as an option for
7289 the STDOUT buffer.
7290 (Fcall_process_region): Ditto.
7291
330d880c
EZ
72922011-04-30 Eli Zaretskii <eliz@gnu.org>
7293
8db90b73
EZ
7294 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7295 rather than `XVECTOR (FOO)->size'.
7296
330d880c
EZ
7297 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7298 inttypes.h, as a gnulib replacement is used if it not available in
7299 system headers.
7300
15cbd324
EZ
73012011-04-21 Eli Zaretskii <eliz@gnu.org>
7302
7303 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7304 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7305 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7306
7307 * coding.c (coding_alloc_by_realloc): Error out if destination
7308 will grow beyond MOST_POSITIVE_FIXNUM.
7309 (decode_coding_emacs_mule): Abort if there isn't enough place in
7310 charbuf for the composition carryover bytes. Reserve an extra
7311 space for up to 2 characters produced in a loop.
7312 (decode_coding_iso_2022): Abort if there isn't enough place in
7313 charbuf for the composition carryover bytes.
7314
73152011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7316
ae940cca
EZ
7317 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7318 aborting when %lld or %lll format is passed.
7319 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7320 %llo or %llx format is passed. (Bug#8545)
7321
03ab8921
EZ
7322 * window.c (window_scroll_line_based): Use a marker instead of
7323 simple variables to record original value of point. (Bug#7952)
7324
afda1437
EZ
7325 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7326 produced by %s or %c overflows available buffer space. (Bug#8545)
7327
f76dee0c
PE
73282011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7329
7330 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7331 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7332
fdc5744d
JB
73332011-04-28 Juanma Barranquero <lekktu@gmail.com>
7334
7335 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7336
638f053a
JB
73372011-04-28 Juanma Barranquero <lekktu@gmail.com>
7338
7339 * keyboard.c (Qdelayed_warnings_hook): Define.
7340 (command_loop_1): Run `delayed-warnings-hook'
7341 if Vdelayed_warnings_list is non-nil.
7342 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7343 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7344
d178f871
EZ
73452011-04-28 Eli Zaretskii <eliz@gnu.org>
7346
7347 * doprnt.c (doprnt): Don't return value smaller than the buffer
7348 size if the message was truncated. (Bug#8545).
7349
b124fd93
JB
73502011-04-28 Juanma Barranquero <lekktu@gmail.com>
7351
7352 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7353 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7354
e810457d
PE
73552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7356
7357 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7358
ea51cceb
JB
73592011-04-27 Juanma Barranquero <lekktu@gmail.com>
7360
7361 * makefile.w32-in: Update dependencies.
7362
94dcfacf
EZ
73632011-04-27 Eli Zaretskii <eliz@gnu.org>
7364
7365 Improve `doprnt' and its usage. (Bug#8545)
7366 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7367 `format_end'. Remove support for %l as a conversion specifier.
7368 Don't use xrealloc. Improve diagnostics when the %l size modifier
7369 is used. Update the commentary.
7370
7371 * eval.c (verror): Simplify calculation of size_t.
7372
7373 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7374 messages.
7375
f61f41d7
PE
73762011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7377
7378 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7379 change.
7380
96fb4434
PE
73812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7382
7383 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7384 This makes this file independent of the recent pseudovector change.
7385
671875da 73862011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7387
69e9b5a3
PE
7388 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7389
b5f869a7 7390 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7391 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7392 Remove unused local.
c8926152 7393 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7394
841a1577 7395 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7396 GCC 4.6.0 optimizes based on type-based alias analysis.
7397 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7398 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7399 != &v->size, and therefore "v->size = 1; b->size = 2; return
7400 v->size;" must therefore return 1. This assumption is incorrect
7401 for Emacs, since it type-puns struct Lisp_Vector * with many other
7402 types. To fix this problem, this patch adds a new type struct
f904488f 7403 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7404 and pseudovectors, and helps optimizing compilers not get fooled
7405 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7406 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7407 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7408 the size member.
eab3844f
PE
7409 (XSETPVECTYPE): Rewrite in terms of new macro.
7410 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7411 This is a bit clearer, and further avoids the possibility of
7412 undesirable aliasing.
7413 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7414 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7415 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7416 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7417 (ASIZE): Now uses header.size rather than size.
7418 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7419 to avoid the hassle of writing XVECTOR (foo)->header.size.
7420 (struct vectorlike_header): New type.
eab3844f
PE
7421 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7422 object, to help avoid aliasing.
7423 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7424 (SUBRP): Likewise, since Lisp_Subr is a special case.
7425 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7426 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7427 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7428 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7429 changed to be "header.size" and "header.next".
7430 * buffer.h (struct buffer): Likewise.
7431 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7432 * frame.h (struct frame): Likewise.
7433 * process.h (struct Lisp_Process): Likewise.
7434 * termhooks.h (struct terminal): Likewise.
7435 * window.c (struct save_window_data, struct saved_window): Likewise.
7436 * window.h (struct window): Likewise.
7437 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7438 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7439 * buffer.c (init_buffer_once): Likewise.
7440 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7441 special case.
7442 * process.c (Fformat_network_address): Use local var for size,
7443 for brevity.
7444
0df1eac5
PE
7445 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7446
847ab9d1 7447 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7448 * data.c (atof): Remove decl; no longer used or needed.
7449 (digit_to_number): Move to lread.c.
7450 (Fstring_to_number): Use new string_to_number function, to be
7451 consistent with how the Lisp reader treats infinities and NaNs.
7452 Do not assume that floating-point numbers represent EMACS_INT
7453 without losing information; this is not true on most 64-bit hosts.
7454 Avoid double-rounding errors, by insisting on integers when
7455 parsing non-base-10 numbers, as the documentation specifies.
7456 * lisp.h (string_to_number): New decl, replacing ...
7457 (isfloat_string): Remove.
bc0a5c13 7458 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7459 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7460 appears to have been a coding error. Similarly, do not accept
7461 strings like +-1e0 as floating point numbers. Do not report
7462 overflow for integer overflows unless the base is not 10 which
7463 means we have no simple and reliable way to continue.
7464 Break out the floating-point parsing into a new
7465 function string_to_number, so that Fstring_to_number parses
7466 floating point numbers consistently with the Lisp reader.
04f2d78b 7467 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7468 (E_CHAR, EXP_INT): Remove, replacing with ...
7469 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7470 (string_to_number): New function, replacing isfloat_string.
7471 This function checks for valid syntax and produces the resulting
7472 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7473 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7474 so that overflow for non-base-10 numbers is reported only when
7475 there's no portable and simple way to convert to floating point.
452f4150 7476
67769ffc
PE
7477 * textprop.c (set_text_properties_1): Rewrite for clarity,
7478 and to avoid GCC warning about integer overflow.
7479
c20db43f
PE
7480 * intervals.h (struct interval): Use EMACS_INT for members
7481 where EMACS_UINT might cause problems. See
7482 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7483 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7484 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7485 All uses changed.
37aa2f85
PE
7486 (offset_intervals): Tell GCC not to worry about length overflow
7487 when negating a negative length.
c20db43f 7488
2538aa2f
PE
7489 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7490 (overrun_check_free): Likewise.
7491
f2d3008d
PE
7492 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7493 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7494 word size.
7495
ec8df744
PE
7496 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7497 (gnutls_make_error): Rename local to avoid shadowing.
7498 (gnutls_emacs_global_deinit): ifdef out; not used.
7499 (Fgnutls_boot): Use const for pointer to readonly storage.
7500 Comment out unused local. Fix pointer signedness problems.
7501
640ee02d
PE
7502 * lread.c (openp): Don't stuff size_t into an 'int'.
7503 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7504 about possible signed overflow.
7505
6048fb2a
PE
7506 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7507 (GDK_KEY_g): Don't define if already defined.
7508 (xg_prepare_tooltip): Avoid pointer signedness problem.
7509 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7510
fa3c87e1
PE
7511 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7512 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7513
2172544b
PE
7514 * xfns.c (Fx_window_property): Simplify a bit,
7515 to make a bit faster and to avoid GCC 4.6.0 warning.
7516 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7517
9b821a21
PE
7518 * fns.c (internal_equal): Don't assume size_t fits in int.
7519
3c616cfa
PE
7520 * alloc.c (compact_small_strings): Tighten assertion a little.
7521
c2982e87
PE
7522 Replace pEd with more-general pI, and fix some printf arg casts.
7523 * lisp.h (pI): New macro, generalizing old pEd macro to other
7524 conversion specifiers. For example, use "...%"pI"d..." rather
7525 than "...%"pEd"...".
7526 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7527 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7528 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7529 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7530 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7531 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7532 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7533 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7534 64-bit hosts.
7535 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7536 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7537 * print.c (safe_debug_print, print_object): Likewise.
7538 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7539 to int.
6f04d126
PE
7540 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7541 avoiding the 0 flag, which is not portable.
c2982e87
PE
7542 * process.c (Fmake_network_process): Use pI to avoid cast.
7543 * region-cache.c (pp_cache): Likewise.
7544 * xdisp.c (decode_mode_spec): Likewise.
7545 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7546 behavior on 64-bit hosts with printf arg.
6f04d126 7547 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7548 (x_stop_queuing_selection_requests): Likewise.
7549 (x_get_window_property): Don't truncate byte count to an 'int'
7550 when tracing.
0b432f21 7551
5e073ec7
PE
7552 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7553 here, since it parses constructs like leading '-' and spaces,
7554 which are not wanted; and it overflows with large numbers.
7555 Instead, simply match F[0-9]+, which is what is wanted anyway.
7556
36372bf9
PE
7557 * alloc.c: Remove unportable assumptions about struct layout.
7558 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7559 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7560 (allocate_vectorlike, make_pure_vector): Use the new macros,
7561 plus offsetof, to remove unportable assumptions about struct layout.
7562 These assumptions hold on all porting targets that I know of, but
7563 they are not guaranteed, they're easy to remove, and removing them
7564 makes further changes easier.
7565
0b432f21
PE
7566 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7567 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7568 (string_overrun_cookie): Now const. Use initializers that
7569 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7570 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7571 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7572 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7573 multiple of sizeof (EMACS_INT); it need not be, if
7574 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7575 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7576
895009e1
JB
75772011-04-26 Juanma Barranquero <lekktu@gmail.com>
7578
7579 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7580
6a7a1b0b
TZ
75812011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7582
7583 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7584 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7585 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7586
841a1577 75872011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7588
7589 * lisp.h (Qdebug): List symbol.
895009e1 7590 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7591 * keyboard.c (debug-on-event): New variable.
7592 (handle_user_signal): Break into debugger when debug-on-event
7593 matches the current signal symbol.
7594
f2d3ba6f
DN
75952011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7596
7597 * alloc.c (check_sblock, check_string_bytes)
7598 (check_string_free_list): Convert to standard C.
7599
42ce4c63
TZ
76002011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7601
7602 * w32.c (emacs_gnutls_push): Fix typo.
7603
825cd63c
EZ
76042011-04-25 Eli Zaretskii <eliz@gnu.org>
7605
fb11d64d
EZ
7606 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7607 "cast to pointer from integer of different size".
7608
825cd63c
EZ
7609 Improve doprnt and its use in verror. (Bug#8545)
7610 * doprnt.c (doprnt): Document the set of format control sequences
7611 supported by the function. Use SAFE_ALLOCA instead of always
7612 using `alloca'.
7613
7614 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7615 is one byte too soon. Don't use xrealloc; instead xfree and
7616 xmalloc anew.
7617
e061a11b
TZ
76182011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7619
7620 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7621 callbacks stage.
7622
7623 * gnutls.c: Renamed global_initialized to
7624 gnutls_global_initialized. Added internals for the
7625 :verify-hostname-error, :verify-error, and :verify-flags
7626 parameters of `gnutls-boot' and documented those parameters in the
7627 docstring. Start callback support.
9173deec
JB
7628 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7629 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7630 on error. Return error code.
e061a11b
TZ
7631 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7632 (emacs_gnutls_read): Likewise.
7633 (Fgnutls_boot): Return handshake error code.
7634 (emacs_gnutls_handle_error): New function.
7635 (wsaerror_to_errno): Likewise.
7636
7637 * w32.h (emacs_gnutls_pull): Add prototype.
7638 (emacs_gnutls_push): Likewise.
7639
7640 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7641 (emacs_gnutls_push): Likewise.
7642
76432011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7644
7645 * process.c (wait_reading_process_output): Check if GnuTLS
7646 buffered some data internally if no FDs are set for TLS
7647 connections.
7648
7649 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7650 (LIBS): Link to USER_LIBS.
7651 ($(BLD)/gnutls.$(0)): New target.
7652
fa6996bc
EZ
76532011-04-24 Eli Zaretskii <eliz@gnu.org>
7654
eb35682e
EZ
7655 * xdisp.c (handle_single_display_spec): Rename the
7656 display_replaced_before_p argument into display_replaced_p, to
7657 make it consistent with the commentary. Fix typos in the
7658 commentary.
7659
e2ad650c
EZ
7660 * textprop.c (syms_of_textprop): Remove dead code.
7661 (copy_text_properties): Delete obsolete commentary about an
7662 interface that was deleted long ago. Fix typos in the description
7663 of arguments.
7664
1b2de274
EZ
7665 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7666 to changes in oldXMenu/XMenu.h from 2011-04-16.
7667 <menu_help_message, prev_menu_help_message>: Constify.
7668 (IT_menu_make_room): menu->help_text is now `const char **';
7669 adjust.
7670
7671 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7672 to changes in oldXMenu/XMenu.h from 2011-04-16.
7673 (struct XMenu): Declare `help_text' `const char **'.
7674
7675 * xfaces.c <Qunspecified>: Make extern again.
7676
7677 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7678 required by POSIX.
1b2de274 7679
762b15be
EZ
7680 * doc.c (get_doc_string): Improve the format passed to `error'.
7681
7682 * doprnt.c (doprnt): Improve commentary.
7683
7684 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7685
7686 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7687 them with etags.
7688
f1052e5d
EZ
7689 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7690 changes in globals.h immediately force recompilation.
762b15be
EZ
7691 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7692 $(CURDIR)/s/ms-w32.h.
7693 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7694
fa6996bc
EZ
7695 * character.c (Fchar_direction): Function deleted.
7696 (syms_of_character): Don't defsubr it.
7697 <char-direction-table>: Deleted.
7698
e6c3da20
EZ
76992011-04-23 Eli Zaretskii <eliz@gnu.org>
7700
7701 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7702 * doprnt.c: Include limits.h.
7703 (SIZE_MAX): New macro.
04f2d78b
CB
7704 (doprnt): Return a size_t value. 2nd arg is now size_t.
7705 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7706 Improve overflow protection. Support `l' modifier for integer
7707 conversions. Support %l conversion. Don't assume an EMACS_INT
7708 argument for integer conversions and for %c.
7709
7710 * lisp.h (doprnt): Restore prototype.
7711
7712 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7713 $(SRC)/character.h.
7714
7715 * Makefile.in (base_obj): Add back doprnt.o.
7716
7717 * deps.mk (doprnt.o): Add back prerequisites.
7718 (callint.o): Depend on character.h.
7719
7720 * eval.c (internal_lisp_condition_case): Include the handler
7721 representation in the error message.
7722 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7723 when breaking from the loop.
7724
7725 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7726
7727 * callint.c (Fcall_interactively): When displaying error message
7728 about invalid control letter, pass the character's codepoint, not
7729 a pointer to its multibyte form. Improve display of the character
7730 in octal and display also its hex code.
7731
7732 * character.c (char_string): Use %x to display the (unsigned)
7733 codepoint of an invalid character, to avoid displaying a bogus
7734 negative value.
7735
7736 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7737 `error', not SYMBOL_NAME itself.
7738
7739 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7740 character arguments to `error'.
7741
7742 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7743 to `error' in error message about FINAL_CHAR argument. Make sure
7744 FINAL_CHAR is a character, and use %c when it is passed as
7745 argument to `error'.
7746
4ffd0d6b 77472011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7748
7749 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7750
7751 * w32.c: Include <time.h>.
7752 (sys_localtime): New function.
7753
4ffd0d6b 77542011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7755
7756 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7757
4ffd0d6b 7758 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7759
4ffd0d6b 77602011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7761
4ffd0d6b
GM
7762 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7763 zombies (Bug#8467).
aac0c6e3 7764
04c56954
EZ
77652011-04-19 Eli Zaretskii <eliz@gnu.org>
7766
7767 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7768 gl_state.e_property when gl_state.object is Qt.
7769
7770 * insdel.c (make_gap_larger): Remove limitation of buffer size
7771 to <= INT_MAX.
7772
16a43933
CY
77732011-04-18 Chong Yidong <cyd@stupidchicken.com>
7774
7775 * xdisp.c (lookup_glyphless_char_display)
7776 (produce_glyphless_glyph): Handle cons cell entry in
7777 glyphless-char-display.
7778 (Vglyphless_char_display): Document it.
7779
7780 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7781 glyphless-char-display.
7782
4581706e
CY
77832011-04-17 Chong Yidong <cyd@stupidchicken.com>
7784
7785 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7786
7787 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7788
7789 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7790 definition for no-X builds.
7791
4887c6e2 77922011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7793
fd35b6f9
PE
7794 Static checks with GCC 4.6.0 and non-default toolkits.
7795
5c1ccb01
PE
7796 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7797
006c5daa
PE
7798 * process.c (keyboard_bit_set): Define only if SIGIO.
7799 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7800 (send_process): Repair possible setjmp clobbering.
7801
efc736d3
PE
7802 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7803
4e2fe2e6
PE
7804 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7805
f97334a2
PE
7806 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7807
4e75f29d
PE
7808 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7809 Define only if needed.
7810
90efadd1
PE
7811 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7812 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7813 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7814
3c647824
PE
7815 * dispextern.h (struct redisplay_interface): Rename param
7816 to avoid shadowing.
e264f262 7817 * termhooks.h (struct terminal): Likewise.
761383f4 7818 * xterm.c (xembed_send_message): Likewise.
3c647824 7819
b58c5c4a
PE
7820 * insdel.c (make_gap_smaller): Define only if
7821 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7822
cad59032
PE
7823 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7824 it.
7825
c339dc2e
PE
7826 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7827 so that we aren't warned about unused symbols.
7828
91a3e27b
PE
7829 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7830
399c71d3 7831 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7832
8ffc96f5
PE
7833 * xfns.c (x_real_positions): Mark locals as initialized.
7834
eef9bc79
PE
7835 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7836
098db9dd
PE
7837 * xterm.c: Fix problems found by static analysis with other toolkits.
7838 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7839 (x_dispatch_event): Declare static if USE_GTK, and
7840 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7841 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7842 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7843 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7844 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7845
eb18f6cc
PE
7846 * xmenu.c (menu_help_callback): Pointer type fixes.
7847 Use const pointers when pointing at readonly data. Avoid pointer
7848 signedness clashes.
7849 (FALSE): Remove unused macro.
7850 (update_frame_menubar): Remove unused decl.
7851
1fe72bf8
PE
7852 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7853
60d9e1db
PE
7854 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7855 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7856 (single_menu_item): Rename local to avoid shadowing.
7857
39261c26
PE
7858 * keyboard.c (make_lispy_event): Remove unused local var.
7859
018c5e19
PE
7860 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7861 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7862
63d2b86e
PE
7863 * bitmaps: Change bitmaps from unsigned char back to the X11
7864 compatible char. Avoid the old compiler warnings about
7865 out-of-range initializers by using, for example, '\xab' rather
7866 than 0xab.
7867
aefd87e1
PE
7868 * xgselect.c (xgselect_initialize): Check vs interface
7869 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7870
bf501fb9
PE
7871 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7872
e9829fdf
PE
7873 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7874 to read-only memory.
7875
1086c095
PE
7876 * fns.c (vector): Remove; this old hack is no longer needed.
7877
2baccd04 7878 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7879 Remove unused var.
dde42981 7880 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7881
72391843 7882 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7883
436c16df 7884 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7885 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7886 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7887
92bb796d 7888 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7889 (x_term_init): Remove local to avoid shadowing.
92bb796d 7890
764430a3 7891 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7892
7893 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7894 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7895
d1dfb56c
EZ
78962011-04-16 Eli Zaretskii <eliz@gnu.org>
7897
c4354cb4
EZ
7898 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7899
d1dfb56c
EZ
7900 Fix regex.c, syntax.c and friends for buffers > 2GB.
7901 * syntax.h (struct gl_state_s): Declare character position members
7902 EMACS_INT.
7903
7904 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7905
04f2d78b
CB
7906 * textprop.c (verify_interval_modification, interval_of):
7907 Declare arguments EMACS_INT.
d1dfb56c
EZ
7908
7909 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7910 EMACS_INT.
7911
7912 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7913
7914 * indent.c (Fvertical_motion): Local variable it_start is now
7915 EMACS_INT.
7916
7917 * regex.c (re_match, re_match_2, re_match_2_internal)
7918 (bcmp_translate, regcomp, regexec, print_double_string)
7919 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7920 (re_compile_pattern, re_exec): Declare arguments and local
7921 variables `size_t' and `ssize_t' and return values `regoff_t', as
7922 appropriate.
7923 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7924 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7925 <compile_stack_type>: `size' and `avail' are now `size_t'.
7926
7927 * regex.h <regoff_t>: Use ssize_t, not int.
7928 (re_search, re_search_2, re_match, re_match_2): Arguments that
7929 specify buffer/string position and length are now ssize_t and
7930 size_t. Return type is regoff_t.
7931
613052cd
BK
79322011-04-16 Ben Key <bkey76@gmail.com>
7933
7934 * nsfont.m: Fixed bugs in ns_get_family and
7935 ns_descriptor_to_entity that were caused by using free to
7936 deallocate memory blocks that were allocated by xmalloc (via
7937 xstrdup). This caused Emacs to crash when compiled with
7938 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7939 --enable-checking=xmallocoverrun). xfree is now used to
7940 deallocate these memory blocks.
7941
4170f62f 79422011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7943
71b41406
PE
7944 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7945
9587a89d
PE
7946 emacs_write: Accept and return EMACS_INT for sizes.
7947 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7948 et seq.
7949 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7950 Accept and return EMACS_INT.
7951 (emacs_gnutls_write): Return the number of bytes written on
7952 partial writes.
7953 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7954 (emacs_read, emacs_write): Remove check for negative size, as the
7955 Emacs source code has been audited now.
9587a89d
PE
7956 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7957 (emacs_read, emacs_write): Use it.
273a5f82
PE
7958 * process.c (send_process): Adjust to the new signatures of
7959 emacs_write and emacs_gnutls_write. Do not attempt to store
7960 a byte offset into an 'int'; it might overflow.
9587a89d 7961 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7962
3e047f51
PE
7963 * sound.c: Don't assume sizes fit in 'int'.
7964 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7965 Return EMACS_INT, not int.
3e047f51 7966 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7967 Accept EMACS_INT, not int.
7968 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7969 record read return values.
7970
cc39a9db
BK
79712011-04-15 Ben Key <bkey76@gmail.com>
7972
c9d0ec6d
JB
7973 * keyboard.c (Qundefined): Don't declare static since it is used
7974 in nsfns.m.
7975 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7976 static since they are used in nsfont.m.
cc39a9db 7977
6c60eb9f
SM
79782011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7979
7980 * process.c (Qprocessp): Don't declare static.
7981 * lisp.h (Qprocessp): Declare again.
7982
7990b61a
JB
79832011-04-15 Juanma Barranquero <lekktu@gmail.com>
7984
7985 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7986
5d4cb038
PE
79872011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7988
8bd7b830 7989 Improve C-level modularity by making more things 'static'.
cd64ea1d 7990
e3b27b31
PE
7991 Don't publish debugger-only interfaces to other modules.
7992 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7993 (verify_bytepos, count_markers): Move decls to the only modules
7994 that need them.
7995 * region-cache.h (pp_cache): Likewise.
7996 * window.h (check_all_windows): Likewise.
7997 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7998
5d4cb038
PE
7999 * sysdep.c (croak): Now static, if
8000 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8001 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
8002
8003 * alloc.c (refill_memory_reserve): Now static if
8004 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8005 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 8006
e87b6180
PE
8007 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8008 Define only if USE_LUCID.
8009
ac64929e
PE
8010 * xrdb.c (x_customization_string, x_rm_string): Now static.
8011
6f37259d
PE
8012 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8013 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8014
1683e3ab
PE
8015 * xdisp.c (draw_row_with_mouse_face): Now static.
8016 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8017
de9c2632
PE
8018 * window.h (check_all_windows): Mark externally visible.
8019
2b96acb7
PE
8020 * window.c (window_deletion_count): Now static.
8021
8022 * undo.c: Make symbols static if they're not exported.
8023 (last_undo_buffer, last_boundary_position, pending_boundary):
8024 Now static.
8025
50436f33
PE
8026 * textprop.c (interval_insert_behind_hooks): Now static.
8027 (interval_insert_in_front_hooks): Likewise.
8028
64520e5c
PE
8029 * term.c: Make symbols static if they're not exported.
8030 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8031 (max_frame_lines, tty_set_terminal_modes):
8032 (tty_reset_terminal_modes, tty_turn_off_highlight):
8033 (get_tty_terminal): Now static.
8034 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8035 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 8036 HAVE_WINDOW_SYSTEM.
64520e5c
PE
8037 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8038 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8039
1fa53021
PE
8040 * sysdep.c: Make symbols static if they're not exported.
8041 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8042 Now static.
8043 (sigprocmask_set, full_mask): Remove; unused.
8044 (wait_debugging): Mark as visible.
8045 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8046 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8047
d4b43b22
PE
8048 * syntax.c (syntax_temp): Define only if !__GNUC__.
8049
b7c513d0
PE
8050 * sound.c (current_sound_device, current_sound): Now static.
8051
989b29ad
PE
8052 * search.c (searchbufs, searchbuf_head): Now static.
8053
13a55a78
PE
8054 * scroll.c (scroll_cost): Remove; unused.
8055 * dispextern.h (scroll_cost): Remove decl.
8056
de68a1fc
PE
8057 * region-cache.h (pp_cache): Mark as externally visible.
8058
40ccffa6
PE
8059 * process.c: Make symbols static if they're not exported.
8060 (process_tick, update_tick, create_process, chan_process):
8061 (Vprocess_alist, proc_buffered_char, datagram_access):
8062 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8063 (deactivate_process): Mark defn as static, as well as decl.
8064 * lisp.h (create_process): Remove decl.
8065 * process.h (chan_process, Vprocess_alist): Remove decls.
8066
ad64fc97
PE
8067 * print.c: Make symbols static if they're not exported.
8068 (print_depth, new_backquote_output, being_printed, print_buffer):
8069 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8070 (print_interval, print_number_index, initial_stderr_stream):
8071 Now static.
8072 * lisp.h (Fprinc): Remove decl.
8073 (debug_output_compilation_hack): Mark as externally visible.
8074
adddb265
PE
8075 * sysdep.c (croak): Move decl from here to syssignal.h.
8076 * syssignal.h (croak): Put it here, so the API can be checked when
8077 'croak' is called from dissociate_if_controlling_tty.
8078
1717ede2
PE
8079 * minibuf.c: Make symbols static if they're not exported.
8080 (minibuf_save_list, choose_minibuf_frame): Now static.
8081 * lisp.h (choose_minibuf_frame): Remove decl.
8082
fa5fb2bc
PE
8083 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8084
1e3890d1
PE
8085 * lread.c: Make symbols static if they're not exported.
8086 (read_objects, initial_obarray, oblookup_last_bucket_number):
8087 Now static.
8088 (make_symbol): Remove; unused.
8089 * lisp.h (initial_obarray, make_symbol): Remove decls.
8090
8a1414fa
PE
8091 * keyboard.c: Make symbols static if they're not exported.
8092 (single_kboard, recent_keys_index, total_keys, recent_keys):
8093 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8094 (this_single_command_key_start, echoing, last_auto_save):
8095 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8096 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8097 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8098 (Vlispy_mouse_stem, double_click_count):
8099 Now static.
8100 (force_auto_save_soon): Define only if SIGDANGER.
8101 (ignore_mouse_drag_p): Now static if
8102 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8103 (print_help): Remove; unused.
8104 (stop_character, last_timer_event): Mark as externally visible.
8105 * keyboard.h (ignore_mouse_drag_p): Declare only if
8106 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8107 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8108 * lisp.h (echoing): Remove decl.
8109 (force_auto_save_soon): Declare only if SIGDANGER.
8110 * xdisp.c (redisplay_window): Simplify code, to make it more
8111 obvious that ignore_mouse_drag_p is not accessed if !defined
8112 USE_GTK && !defined HAVE_NS.
8113
93ea6e8f
PE
8114 * intervals.c: Make symbols static if they're not exported.
8115 (merge_properties_sticky, merge_interval_right, delete_interval):
8116 Now static.
8117 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8118
77382fcc
PE
8119 * insdel.c: Make symbols static if they're not exported.
8120 However, leave prepare_to_modify_buffer alone. It's never
8121 called from outside this function, but that appears to be a bug.
8122 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8123 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8124 (adjust_after_replace_noundo): Remove; unused.
8125 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8126 (signal_before_change): Remove decls.
77382fcc 8127
9306c32e
PE
8128 * indent.c (val_compute_motion, val_vmotion): Now static.
8129
cd44d2eb
PE
8130 * image.c: Make symbols static if they're not exported.
8131 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8132 if USE_GTK.
8133 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8134 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8135
ad9a7a06
PE
8136 * fringe.c (standard_bitmaps): Now static.
8137 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8138
81626931
PE
8139 * frame.c: Make symbols static if they're not exported.
8140 (x_report_frame_params, make_terminal_frame): Now static.
8141 (get_frame_param): Now static, unless HAVE_NS.
8142 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8143 (x_get_resource_string): Remove; not used.
8144 * frame.h (make_terminal_frame, x_report_frame_params):
8145 (x_get_resource_string); Remove decls.
8146 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8147 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8148
239f9db9
PE
8149 * font.c, fontset.c: Make symbols static if they're not exported.
8150 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8151 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8152 * font.c (font_close_object): Now static.
8153 * font.h (font_close_object): Remove.
8154 * fontset.c (FONTSET_OBJLIST): Remove.
8155 (free_realized_fontset) #if-0 the body, which does nothing.
8156 (face_suitable_for_char_p): #if-0, as it's never called.
8157 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8158 * xfaces.c (face_at_string_position):
8159 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8160 since 0 is always ASCII.
8161
dfcf3579
PE
8162 * fns.c (weak_hash_tables): Now static.
8163
5045092b
PE
8164 * fileio.c: Make symbols static if they're not exported.
8165 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8166 (Vwrite_region_annotation_buffers): Now static.
8167
57a96f5c
PE
8168 * eval.c: Make symbols static if they're not exported.
8169 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8170 * lisp.h (backtrace_list): Remove decl.
8171
35f08c38
PE
8172 * emacs.c: Make symbols static if they're not exported.
8173 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8174 (fatal_error_code, fatal_error_signal_hook, standard_args):
8175 Now static.
8176 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8177 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8178 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8179 * lisp.h (fatal_error_signal_hook): Remove decl.
8180 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8181
f44bd759
PE
8182 * editfns.c: Move a (normally-unused) function to its only use.
8183 * editfns.c, lisp.h (get_operating_system_release): Remove.
8184 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8185 worth the hassle of breaking this out.
8186
b532497d
PE
8187 * xterm.c: Make symbols static if they're not exported.
8188 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8189 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8190 (x_destroy_window, x_delete_display):
8191 Now static.
8192 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8193 (x_mouse_leave): Remove; unused.
8194 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8195 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8196 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8197 Remove decls.
8198 (x_mouse_leave): Declare only if WINDOWSNT.
8199 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8200 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8201 USE_X_TOOLKIT.
8202
1675728f
PE
8203 * ftxfont.c: Make symbols static if they're not exported.
8204 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8205 HAVE_FREETYPE.
8206 * font.h (ftxfont_driver): Likewise.
8207
e4cebfca
PE
8208 * xfns.c: Make symbols static if they're not exported.
8209 (x_last_font_name, x_display_info_for_name):
8210 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8211 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8212 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8213 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8214 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8215 (last_show_tip_args): Now static.
8216 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8217 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8218 (x_screen_planes): Remove; unused.
8219 * dispextern.h (x_screen_planes): Remove decl.
8220
5bf46f05
PE
8221 * dispnew.c: Make symbols static if they're not exported.
8222 * dispextern.h (redraw_garbaged_frames, scrolling):
8223 (increment_row_positions): Remove.
8224 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8225 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8226 Now static.
8227 (redraw_garbaged_frames): Remove; unused.
8228
435f4c28
PE
8229 * xfaces.c: Make symbols static if they're not exported.
8230 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8231 Remove decls.
8232 * xterm.h (defined_color): Remove decls.
8233 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8234 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8235 (menu_face_changed_default, defined_color, free_realized_face):
8236 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8237 (ascii_face_of_lisp_face): Remove; unused.
8238
8524aef3
PE
8239 * xdisp.c: Make symbols static if they're not exported.
8240 * dispextern.h (scratch_glyph_row, window_box_edges):
8241 (glyph_to_pixel_coords, set_cursor_from_row):
8242 (get_next_display_element, set_iterator_to_next):
8243 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8244 (show_mouse_face): Remove decls
8245 * frame.h (message_buf_print): Likewise.
8246 * lisp.h (pop_message, set_message, check_point_in_composition):
8247 Likewise.
8248 * xterm.h (set_vertical_scroll_bar): Likewise.
8249 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8250 (message_buf_print, scratch_glyph_row, displayed_buffer):
8251 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8252 (get_next_display_element, show_mouse_face, window_box_edges):
8253 (frame_to_window_pixel_xy, check_point_in_composition):
8254 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8255 (glyph_to_pixel_coords): Remove; unused.
8256
16390cd2
PE
8257 * dired.c (file_name_completion): Now static.
8258
8259 * dbusbind.c (xd_in_read_queued_messages): Now static.
8260
a25f4dfa
PE
8261 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8262 * data.c (circular_list_error): Remove.
8263
14a9c8df
PE
8264 * commands.h (last_point_position, last_point_position_buffer):
8265 (last_point_position_window): Remove decls.
8266 * keyboard.c: Make these variables static.
8267
04f2d78b
CB
8268 * coding.h (coding, code_convert_region, encode_coding_gap):
8269 Remove decls.
74ab6df5
PE
8270 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8271 (iso_code_class, detect_coding, code_convert_region): Now static.
8272 (encode_coding_gap): Remove; unused.
8273
38dfbee1
PE
8274 * chartab.c (chartab_chars, chartab_bits): Now static.
8275
a2cb4e63
PE
8276 * charset.h (charset_iso_8859_1): Remove decl.
8277 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8278 Now static.
8279
127198fd
PE
8280 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8281 * ccl.c (Vccl_program_table): Now static.
8282 (check_ccl_update): Remove; unused.
8283
d85b608f
PE
8284 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8285 * category.h: ... from here.
8286 * category.c (check_category_table, set_category_set): Now static.
8287
31cd66f3
PE
8288 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8289 * lisp.h: Remove these decls.
8290
c358e587
PE
8291 * buffer.c (buffer_count): Remove unused var.
8292
e78aecca
PE
8293 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8294 so that it's not optimized away.
8295 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8296 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8297 exported only to the debugger.
8298
e192d7d3 8299 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8300 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8301
92470028
PE
8302 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8303 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8304 was inaccessible from Lisp.
8305 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8306 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8307
244ed907
PE
8308 alloc.c: Import and export fewer symbols, and remove unused items.
8309 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8310 is defined.
8311 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8312 it's not optimized away by whole-program optimization.
8313 (message_enable_multibyte, free_misc): Remove.
8314 (catchlist, handlerlist, mark_backtrace):
8315 Declare only if BYTE_MARK_STACK.
8316 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8317 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8318 (message_enable_multibyte): Remove decl.
8319 (free_misc, interval_free_list, float_block, float_block_index):
8320 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8321 (cons_free_list, last_marked_index):
8322 Now static.
8323 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8324 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8325 (mark_backtrace): Define only if BYTE_MARK_STACK.
8326 * xdisp.c (message_enable_multibyte): Now static.
8327
61c2b50e 8328 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8329 This makes it easier for human readers (and static analyzers)
8330 to see whether these variables are used from other modules.
8331 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8332 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8333 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8334 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8335 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8336 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8337 * xmenu.c, xselect.c:
8338 Declare Q* vars static if they are not used in other modules.
8339 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8340 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8341 Remove decls of unexported vars.
8342 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8343
95c82688
PE
8344 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8345
16a97296
PE
8346 Make Emacs functions such as Fatom 'static' by default.
8347 This makes it easier for human readers (and static analyzers)
8348 to see whether these functions can be called from other modules.
8349 DEFUN now defines a static function. To make the function external
8350 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8351 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8352 (Finit_image_library):
16a97296
PE
8353 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8354 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8355 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8356 Remove decls, since these functions are now static.
8357 (Funintern, Fget_internal_run_time): New decls, since these functions
8358 were already external.
95c82688 8359
16a97296
PE
8360 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8361 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8362 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8363 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8364 * keyboard.c, keymap.c, lread.c:
8365 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8366 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8367 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8368 Mark functions with DEFUE instead of DEFUN,
8369 if they are used in other modules.
8370 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8371 decls for now-static functions.
8372 * buffer.h (Fdelete_overlay): Remove decl.
8373 * callproc.c (Fgetenv_internal): Mark as internal.
8374 * composite.c (Fremove_list_of_text_properties): Remove decl.
8375 (Fcomposition_get_gstring): New forward static decl.
8376 * composite.h (Fcomposite_get_gstring): Remove decl.
8377 * dired.c (Ffile_attributes): New forward static decl.
8378 * doc.c (Fdocumntation_property): New forward static decl.
8379 * eval.c (Ffetch_bytecode): New forward static decl.
8380 (Funintern): Remove extern decl; now in .h file where it belongs.
8381 * fileio.c (Fmake_symbolic_link): New forward static decl.
8382 * image.c (Finit_image_library): New forward static decl.
8383 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8384 * intervals.h (Fprevious_property_change):
8385 (Fremove_list_of_text_properties): Remove decls.
8386 * keyboard.c (Fthis_command_keys): Remove decl.
8387 (Fcommand_execute): New forward static decl.
8388 * keymap.c (Flookup_key): New forward static decl.
8389 (Fcopy_keymap): Now static.
8390 * keymap.h (Flookup_key): Remove decl.
8391 * process.c (Fget_process): New forward static decl.
8392 (Fprocess_datagram_address): Mark as internal.
8393 * syntax.c (Fsyntax_table_p): New forward static decl.
8394 (skip_chars): Remove duplicate decl.
8395 * textprop.c (Fprevious_property_change): New forward static decl.
8396 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8397 Now internal.
8398 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8399 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8400
785bbd42
PE
8401 * editfns.c (Fformat): Remove unreachable code.
8402
8b913b57
AS
84032011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8404
8405 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8406 change. (Bug#8496)
8407
a6744a35
EZ
84082011-04-13 Eli Zaretskii <eliz@gnu.org>
8409
8410 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8411 when at ZV. (Bug#8487)
8412
e7974947
AS
84132011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8414
baad03f0
AS
8415 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8416 (Bug#8437)
8417 * keyboard.c (parse_tool_bar_item): Likewise.
8418 * sound.c (sound_cleanup, alsa_close): Likewise.
8419 * termcap.c (tgetent): Likewise.
8420 * xfns.c (x_default_font_parameter): Likewise.
8421 * xsettings.c (read_and_apply_settings): Likewise.
8422
e7974947
AS
8423 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8424 (overrun_check_free): Protoize.
8425
28272684
PE
84262011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8427
8428 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8429 since callers should never pass a negative size.
8430 Change the signature to match that of plain 'read' and 'write'; see
8431 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8432 * lisp.h: Update prototypes of emacs_write and emacs_read.
8433
11997c76
EZ
84342011-04-11 Eli Zaretskii <eliz@gnu.org>
8435
8436 * xdisp.c (redisplay_window): Don't try to determine the character
8437 position of the scroll margin if the window start point w->startp
e896f03c 8438 is outside the buffer's accessible region. (Bug#8468)
11997c76 8439
8a2cbd72
EZ
84402011-04-10 Eli Zaretskii <eliz@gnu.org>
8441
8442 Fix write-region and its subroutines for buffers > 2GB.
8443 * fileio.c (a_write, e_write): Modify declaration of arguments and
8444 local variables to support buffers larger than 2GB.
8445 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8446
8447 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8448 argument, local variables, and return value.
8449
8450 * lisp.h: Update prototypes of emacs_write and emacs_read.
8451
8452 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8453
4073e537 84542011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8455
1ebfdcb6
PE
8456 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8457
b2ded58d
PE
8458 Fix more problems found by GCC 4.6.0's static checks.
8459
7d66342c
PE
8460 * xdisp.c (vmessage): Use a better test for character truncation.
8461
bbf47d44
PE
8462 * charset.c (load_charset_map): <, not <=, for optimization,
8463 and to avoid potential problems with integer overflow.
9248994d 8464 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8465 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8466 * editfns.c (Fformat): Likewise.
1e69125e 8467 * syntax.c (skip_chars): Likewise.
3befa583 8468
e3019616
PE
8469 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8470 This also lets GCC 4.6.0 generate slightly better loop code.
8471
becfa255
PE
8472 * callint.c (Fcall_interactively): <, not <=, for optimization.
8473 (Fcall_interactively): Count the number of arguments produced,
8474 not the number of arguments given. This is simpler and lets GCC
8475 4.6.0 generate slightly better code.
8476
dae0cd48
PE
8477 * ftfont.c: Distingish more carefully between FcChar8 and char.
8478 The previous code passed unsigned char * to a functions like
8479 strlen and xstrcasecmp that expect char *, which does not
8480 conform to the C standard.
8481 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8482 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8483 char * when the C standard requires it.
8484
76032d70
PE
8485 * keyboard.c (read_char): Remove unused var.
8486
eb3f1cc8
PE
8487 * eval.c: Port to Windows vsnprintf (Bug#8435).
8488 Include <limits.h>.
8489 (SIZE_MAX): Define if the headers do not.
8490 (verror): Do not give up if vsnprintf returns a negative count.
8491 Instead, grow the buffer. This ports to Windows vsnprintf, which
8492 does not conform to C99. Problem reported by Eli Zaretskii.
8493 Also, simplify the allocation scheme, by avoiding the need for
8494 calling realloc, and removing the ALLOCATED variable.
8495
70476b54
PE
8496 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8497
12020a9e
PE
8498 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8499 But keep the doprint source code for now, as we might revamp it
8500 and use it again (Bug#8435).
ea6c7ae6
PE
8501 * lisp.h (doprnt): Remove.
8502 * Makefile.in (base_obj): Remove doprnt.o.
8503 * deps.mk (doprnt.o): Remove.
8504
5fdb398c
PE
8505 error: Print 32- and 64-bit integers portably (Bug#8435).
8506 Without this change, on typical 64-bit hosts error ("...%d...", N)
8507 was used to print both 32- and 64-bit integers N, which relied on
8508 undefined behavior.
61bdb816 8509 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8510 * lisp.h (error, verror): Mark as printf-like functions.
8511 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8512 Report overflow in size calculations when allocating printf buffer.
8513 Do not truncate output string at its first null byte.
8514 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8515 Truncate the output at a character boundary, since vsnprintf does not
8516 do that.
8517 * charset.c (check_iso_charset_parameter): Convert internal
8518 character to string before calling 'error', since %c now has the
8519 printf meaning.
8520 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8521 overflow when computing char to be passed to 'error'. Do not
8522 pass Lisp_Object to 'error'; pass the integer instead.
8523 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8524 formatted with plain %d.
8525
b189fa66
PE
8526 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8527
bff87ef0
PE
8528 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8529
7e2cac20
PE
8530 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8531
ce4d90b5
PE
8532 * xterm.c (x_catch_errors): Remove duplicate declaration.
8533
266c9547
PE
8534 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8535
79c49ad2
PE
8536 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8537
368f4090
JM
85382011-04-10 Jim Meyering <meyering@redhat.com>
8539
8540 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8541 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8542 return ssize_t not "int", and use size_t as the buffer length.
8543 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8544 * gnutls.h: Update declarations.
8545 * process.c (read_process_output): Use ssize_t, to match.
8546 (send_process): Likewise.
8547
a32d4040
CY
85482011-04-09 Chong Yidong <cyd@stupidchicken.com>
8549
8550 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8551
8546720e 85522011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8553
04f2d78b
CB
8554 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8555 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8556
8546720e
GM
8557 * xterm.c (handle_one_xevent):
8558 * xmenu.c (create_and_show_popup_menu):
8559 * xselect.c (x_decline_selection_request)
8560 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8561
0a2f5c1a 85622011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8563
8564 Fix some uses of `int' instead of EMACS_INT.
8565 * search.c (string_match_1, fast_string_match)
8566 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8567 (scan_buffer, find_next_newline_no_quit)
8568 (find_before_next_newline, search_command, Freplace_match)
8569 (Fmatch_data): Make some `int' variables be EMACS_INT.
8570
8571 * xdisp.c (display_count_lines): 3rd argument and return value now
8572 EMACS_INT. All callers changed.
8573 (pint2hrstr): Last argument is now EMACS_INT.
8574
8575 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8576 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8577 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8578 (decode_coding_utf_16, decode_coding_emacs_mule)
8579 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8580 (decode_coding_ccl, decode_coding_charset)
8581 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8582 (decode_coding_iso_2022, decode_coding_emacs_mule)
8583 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8584 <char_offset, last_offset>: Declare EMACS_INT.
8585 (encode_coding_utf_8, encode_coding_utf_16)
8586 (encode_coding_emacs_mule, encode_invocation_designation)
8587 (encode_designation_at_bol, encode_coding_iso_2022)
8588 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8589 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8590 Declare EMACS_INT.
8591 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8592 (encode_invocation_designation): Last argument P_NCHARS is now
8593 EMACS_INT.
8594 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8595 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8596
8597 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8598 All users changed.
8599
8600 * ccl.c (Fccl_execute_on_string): Declare some variables
8601 EMACS_INT.
8602
8546720e 86032011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8604
8605 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8606
4e19a977
CS
86072011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8608
8609 * process.c (Fformat_network_address): Doc fix.
8610
87302331
R
86112011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8612
ee7683eb 8613 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8614
cbb59342
CY
86152011-04-08 Chong Yidong <cyd@stupidchicken.com>
8616
8617 * keyboard.c (read_char): Call Lisp function help-form-show,
8618 instead of using internal_with_output_to_temp_buffer.
8619 (Qhelp_form_show): New var.
e0d38eeb 8620 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8621
8622 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8623
8624 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8625
e67a13ab
CY
86262011-04-06 Chong Yidong <cyd@stupidchicken.com>
8627
04f2d78b
CB
8628 * process.c (Flist_processes): Remove to Lisp.
8629 (list_processes_1): Delete.
e67a13ab 8630
973f782d
EZ
86312011-04-06 Eli Zaretskii <eliz@gnu.org>
8632
7c106b1e
EZ
8633 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8634
973f782d
EZ
8635 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8636
41cf7d1a 86372011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8638
ca23cc88
PE
8639 Fix more problems found by GCC 4.6.0's static checks.
8640
f390e2d5
PE
8641 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8642
42eea0d0
PE
8643 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8644
b69769da 8645 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8646
f9541e84
PE
8647 * xdisp.c (vmessage): Mark as a printf-like function.
8648
13841b55
PE
8649 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8650
c136c10f
PE
8651 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8652
5e2d4a30
PE
8653 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8654 printf-like functions.
8655 (tiff_load): Add casts to remove these marks before passing them
8656 to system-supplied API.
8657
583f48b9
PE
8658 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8659
b25d760e
PE
8660 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8661 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8662 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8663 directly, rather than having caller test rule sign. This avoids
8664 some unnecessary tests.
8665 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8666 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8667 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8668
bc7b6697 8669 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8670 (xfont_open): Avoid unnecessary tests.
bc7b6697 8671
27ccc379
PE
8672 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8673
dcd5c89a
PE
8674 * composite.h, composite.c (composition_gstring_put_cache):
8675 Use EMACS_INT, not int, for length.
8676
b13a45c6
PE
8677 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8678 breaking out part of COMPOSITION_DECODE_RULE.
8679 (COMPOSITION_DECODE_RULE): Use it.
8680 * composite.c (get_composition_id): Remove unused local vars,
8681 by using the new macro.
8682
1e792e4d
PE
8683 * textprop.c (set_text_properties_1): Change while to do-while,
8684 since the condition is always true at first.
8685
dc6c6455 8686 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8687 (interval_deletion_adjustment): Return unsigned value.
8688 All uses changed.
dc6c6455 8689
aba7731a
PE
8690 * process.c (list_processes_1, create_pty, read_process_output):
8691 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8692 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8693 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8694 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8695 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8696
fdfc4bf3
PE
8697 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8698
fca8fe46 8699 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8700 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8701
06a0259a 8702 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8703 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8704 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8705
e7b9e80f
PE
8706 * print.c (print_error_message): Avoid int overflow.
8707
56201685
PE
8708 * font.c (font_list_entities): Redo for clarity,
8709 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8710
78834453 8711 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8712 (font_score): Avoid potential overflow in diff calculation.
78834453 8713
0bc0b309 8714 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8715 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8716
e610eaca
PE
8717 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8718
b895abce
PE
8719 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8720 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8721 can always succeed if overflow has undefined behavior.
8722
1f1d9321 8723 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8724 (wordify): Omit three unnecessary tests.
1f1d9321 8725
c59478bc
PE
8726 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8727 All callers changed. This avoids the need for an unused var.
8728
79b73827
PE
8729 * casefiddle.c (casify_region): Remove var that is set but not used.
8730
a4db5dfe
PE
8731 * dired.c (file_name_completion): Remove var that is set but not used.
8732
43aae36e
PE
8733 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8734
2a47c44d 8735 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8736 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8737
a37c69bf
PE
8738 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8739 Check for integer overflow on size calculations.
8740
328ab8e7
PE
8741 * buffer.c (Fprevious_overlay_change): Remove var that is set
8742 but not used.
8743
e5a2a5cb
PE
8744 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8745 Remove vars that are set but not used.
8d84a6eb 8746 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8747 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8748
a60e5f68
PE
8749 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8750
f661cb61 8751 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8752 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8753
f0397f5a
PE
8754 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8755 that are set but not used.
8756
8664db06 8757 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8758 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8759
6abdaa4a
PE
8760 * xselect.c (x_get_local_selection, x_handle_property_notify):
8761 Remove vars that are set but not used.
8762
0ce7538d 8763 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8764 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8765
9ae848fc
PE
8766 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8767 Remove var that is set but not used.
0b918413
PE
8768 (scroll_bar_windows_size): Now size_t, not int.
8769 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8770 Check for overflow.
9ae848fc 8771
a5a62657
PE
8772 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8773 (map_tty_color) [!defined MSDOS]: Likewise.
8774
5c5cdd39
PE
8775 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8776
66ebf983
PE
8777 * coding.c: Remove vars that are set but not used.
8778 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8779 All callers changed.
8780 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8781 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8782 (decode_coding_charset): Remove vars that are set but not used.
8783
1be4d761
PE
8784 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8785 that is set but not used.
8786
47553fa8
PE
8787 * print.c (print_object): Remove var that is set but not used.
8788
1f7196bf 8789 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8790 The gnulib version avoids calling malloc in the usual case,
8791 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8792 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8793 * filelock.c (current_lock_owner): Likewise.
8794 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8795 * sysdep.c: Include allocator.h, careadlinkat.h.
8796 (emacs_no_realloc_allocator): New static constant.
8797 (emacs_readlink): New function.
fdb61804
PE
8798 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8799 ../lib/careadlinkat.h.
d1fdcab7 8800
f84c17c7
SM
88012011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8802
8803 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8804 first non-nil return value).
8805
ef3862ad
JD
88062011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8807
8808 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8809 if not defined (Bug#8403).
8810
376a7006
JB
88112011-04-02 Juanma Barranquero <lekktu@gmail.com>
8812
8813 * xdisp.c (display_count_lines): Remove parameter `start',
8814 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8815 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8816 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8817 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8818 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8819 and thereabouts. All callers changed.
8820 (get_per_char_metric): Remove parameter `f', unused since
8821 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8822
6ca3801d
JM
88232011-04-02 Jim Meyering <meyering@redhat.com>
8824
8825 do not dereference NULL upon failed strdup
8826 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8827 (ns_get_family): Likewise.
8828
d8e2b5ba
JB
88292011-04-02 Juanma Barranquero <lekktu@gmail.com>
8830
8831 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8832
8c74fcbd
JD
88332011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8834
8835 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8836 later (Bug#8403).
8837
7200d79c
SM
88382011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8839
03408648 8840 Add lexical binding.
7200d79c 8841
03408648
SM
8842 * window.c (Ftemp_output_buffer_show): New fun.
8843 (Fsave_window_excursion):
8844 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8845
8846 * lread.c (lisp_file_lexically_bound_p): New function.
8847 (Fload): Bind Qlexical_binding.
8848 (readevalloop): Remove `evalfun' arg.
8849 Bind Qinternal_interpreter_environment.
8850 (Feval_buffer): Bind Qlexical_binding.
8851 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8852 Mark as dynamic.
8853 (syms_of_lread): Declare `lexical-binding'.
8854
8855 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8856
8857 * keyboard.c (eval_dyn): New fun.
8858 (menu_item_eval_property): Use it.
ca105506
SM
8859
8860 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8861
03408648
SM
8862 * fns.c (concat, mapcar1): Accept byte-code-functions.
8863
8864 * eval.c (Fsetq): Handle lexical vars.
8865 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8866 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8867 (FletX, Flet): Obey lexical binding.
8868 (Fcommandp): Handle closures.
8869 (Feval): New `lexical' arg.
8870 (eval_sub): New function extracted from Feval. Use it almost
8871 everywhere where Feval was used. Look up vars in lexical env.
8872 Handle closures.
8873 (Ffunctionp): Move from subr.el.
8874 (Ffuncall): Handle closures.
8875 (apply_lambda): Remove `eval_flags'.
8876 (funcall_lambda): Handle closures and new byte-code-functions.
8877 (Fspecial_variable_p): New function.
8878 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8879 but without exporting it to Lisp.
23aba0ea 8880
23aba0ea 8881 * doc.c (Fdocumentation, store_function_docstring):
03408648 8882 * data.c (Finteractive_form): Handle closures.
23aba0ea 8883
03408648
SM
8884 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8885 interactive spec.
ba83908c 8886
04f2d78b
CB
8887 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8888 New byte-codes.
03408648
SM
8889 (exec_byte_code): New function extracted from Fbyte_code to handle new
8890 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8891
03408648 8892 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8893
03408648 8894 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8895
e2abce01
JB
88962011-03-31 Juanma Barranquero <lekktu@gmail.com>
8897
8898 * xdisp.c (redisplay_internal): Fix prototype.
8899
63696a73 89002011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8901
63696a73 8902 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8903 (try_scrolling): Use it when setting scroll_limit.
8904 Limit scrolling to 100 screen lines.
63696a73
EZ
8905 (redisplay_window): Even when falling back on "recentering",
8906 position point in the window according to scroll-conservatively,
8907 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8908
8909 (try_scrolling): When point is above the window, allow searching
8910 as far as scroll_max, or one screenful, to compute vertical
8911 distance from PT to the scroll margin position. This prevents
8912 try_scrolling from unnecessarily failing when
8913 scroll-conservatively is set to a value slightly larger than the
8914 window height. Clean up the case of PT below the margin at bottom
8915 of window: scroll_max can no longer be INT_MAX. When aggressive
8916 scrolling is in use, don't let point enter the opposite scroll
8917 margin as result of the scroll.
8918 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8919 threshold of 100 lines for never-recentering scrolling.
8920
e4cc2dfc
JB
89212011-03-31 Juanma Barranquero <lekktu@gmail.com>
8922
8923 * dispextern.h (move_it_by_lines):
8924 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8925 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8926 (message_log_check_duplicate): Remove parameters `prev_bol' and
8927 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8928 (redisplay_internal): Remove parameter `preserve_echo_area',
8929 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8930
8931 * indent.c (Fvertical_motion):
8932 * window.c (window_scroll_pixel_based, Frecenter):
8933 Don't pass `need_y_p' to `move_it_by_lines'.
8934
1c470562
SM
89352011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8936
44f230aa
SM
8937 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8938 steal a few bits to be more compact.
8939 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8940 Remove unneeded casts.
8941
1c470562
SM
8942 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8943
888adce9
ZK
89442011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8945
8946 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8947 binding" message (bug#7967).
8948
f838ed7b
PE
89492011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8950
77861b95
PE
8951 Fix more problems found by GCC 4.6.0's static checks.
8952
de6dbc14
PE
8953 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8954 Remove unused local var.
8955
f838ed7b
PE
8956 * editfns.c (Fmessage_box): Remove unused local var.
8957
792c7b2b
PE
8958 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8959 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8960 Omit unused local vars.
c499e557 8961 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8962 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8963 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8964 Omit unused local var.
8965
ba0165e1
PE
8966 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8967 Don't assume string length fits in int.
32ad8845 8968 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8969 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8970
3c59b4c9
PE
8971 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8972 instead of alloca (Bug#8344).
8973
a3eed478 8974 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8975 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8976
eb4d412d
PE
8977 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8978
1658b401
PE
8979 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8980 concerns.
8981
8982 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8983
8984 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8985
9a2c6e05
PE
8986 * keyboard.c (syms_of_keyboard): Use the same style as later
8987 in this function when indexing through an array. This also
8988 works around GCC bug 48267.
8989
03d0a109
PE
8990 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8991
44f730c8
PE
8992 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8993
fe75f926
PE
8994 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8995 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8996
ffa8c828
PE
8997 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8998 This avoids undefined behavior on integer overflow, and is a bit
8999 more convenient anyway since it is compared to a size_t variable.
9000
c5101a77
PE
9001 Variadic C functions now count arguments with size_t, not int.
9002 This avoids an unnecessary limitation on 64-bit machines, which
9003 caused (substring ...) to crash on large vectors (Bug#8344).
9004 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9005 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 9006 All variadic functions and their callers changed accordingly.
c5101a77
PE
9007 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9008 * data.c (arith_driver, float_arith_driver): Likewise.
9009 * editfns.c (general_insert_function): Likewise.
9010 * eval.c (struct backtrace.nargs, interactive_p)
9011 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9012 (funcall_lambda, mark_backtrace): Likewise.
9013 * fns.c (concat): Likewise.
9014 * frame.c (x_set_frame_parameters): Likewise.
9015 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9016 0 if not found, not -1. All callers changed.
9017
dd3f25f7
PE
9018 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9019 (stack_copy_size): Now size_t, not int.
9020 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9021
461c2ab9
JB
90222011-03-28 Juanma Barranquero <lekktu@gmail.com>
9023
9024 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9025 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9026 All callers changed.
9027
9028 * lisp.h (multibyte_char_to_unibyte):
9029 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9030 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9031 * character.h (CHAR_TO_BYTE8):
9032 * cmds.c (internal_self_insert):
9033 * editfns.c (general_insert_function):
9034 * keymap.c (push_key_description):
9035 * search.c (Freplace_match):
9036 * xdisp.c (message_dolog, set_message_1): All callers changed.
9037
f6d62986
SM
90382011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9039
9040 * keyboard.c (safe_run_hook_funcall): New function.
9041 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9042 don't set the hook to nil, but remove the offending function instead.
9043 (Qcommand_hook_internal): Remove, unused.
9044 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9045 Vcommand_hook_internal.
9046
9047 * eval.c (enum run_hooks_condition): Remove.
9048 (funcall_nil, funcall_not): New functions.
9049 (run_hook_with_args): Call each function through a `funcall' argument.
9050 Remove `cond' argument, now redundant.
9051 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9052 (Frun_hook_with_args_until_failure): Adjust accordingly.
9053 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9054
1db5b1ad
JB
90552011-03-28 Juanma Barranquero <lekktu@gmail.com>
9056
9057 * dispextern.h (string_buffer_position): Remove declaration.
9058
9059 * print.c (strout): Remove parameter `multibyte', unused since
9060 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9061
9062 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9063 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9064 All callers changed.
9065
9066 * w32.c (_wsa_errlist): Use braces for struct initializers.
9067
9068 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9069 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9070 All callers changed.
9071 (string_buffer_position): Likewise. Also, make static (it's never
9072 used outside xdisp.c).
9073 (cursor_row_p): Remove parameter `w', unused since
9074 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9075 (decode_mode_spec): Remove parameter `precision', introduced during
9076 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9077 All callers changed.
9078
5ffb62aa
JD
90792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9080
9081 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9082
461c2ab9 90832011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9084
9085 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9086 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9087 (ns_update_auto_hide_menu_bar): New functions.
9088 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9089 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9090 ns_constrain_all_frames.
9091 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9092 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9093
5c380ffb
JD
90942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9095
9096 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9097
9af30bdf
GM
90982011-03-27 Glenn Morris <rgm@gnu.org>
9099
9100 * syssignal.h: Replace RETSIGTYPE with void.
9101 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9102 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9103 Replace SIGTYPE with void everywhere.
9104 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9105 * s/template.h (SIGTYPE): Remove commented out definition.
9106
e2abce01
JB
91072011-03-26 Eli Zaretskii <eliz@gnu.org>
9108
9109 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9110 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9111
f868cd8a
JB
91122011-03-26 Juanma Barranquero <lekktu@gmail.com>
9113
59eb0929
JB
9114 * w32.c (read_unc_volume): Use parameter `henum', instead of
9115 global variable `wget_enum_handle'.
9116
9117 * keymap.c (describe_vector): Remove parameters `indices' and
9118 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9119 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9120
f868cd8a
JB
9121 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9122
9123 * keyboard.c (timer_check): Remove parameter `do_it_now',
9124 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9125 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9126 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9127
9128 * keyboard.c (read_char):
9129 * w32menu.c (w32_menu_display_help):
9130 * xmenu.c (show_help_event, menu_help_callback):
9131 Adjust calls to `show_help_echo'.
9132
9133 * gtkutil.c (xg_maybe_add_timer):
9134 * keyboard.c (readable_events):
9135 * process.c (wait_reading_process_output):
9136 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9137
9138 * insdel.c (adjust_markers_gap_motion):
9139 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9140 (gap_left, gap_right): Don't call it.
9141
2ecf6fdb
CY
91422011-03-25 Chong Yidong <cyd@stupidchicken.com>
9143
9144 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9145 incurred during fontification.
9146
6b1f9ba4
JB
91472011-03-25 Juanma Barranquero <lekktu@gmail.com>
9148
9149 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9150 (DEFVAR_PER_BUFFER): Don't pass it.
9151
9152 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9153 (scrolling_window): Don't pass it.
9154
0f4a96b5
JB
91552011-03-25 Juanma Barranquero <lekktu@gmail.com>
9156
9157 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9158
9159 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9160 and `suffix'.
9161 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9162 of variables specific to SELinux and computation of `encoded_absname'.
9163
9164 * image.c (XPutPixel): Remove unused variable `height'.
9165
9166 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9167
9168 * unexw32.c (get_section_info): Remove unused variable `section'.
9169
9170 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9171 (system_process_attributes): Remove unused variable `sess'.
9172 (sys_read): Remove unused variable `err'.
9173
9174 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9175 (w32_wnd_proc): Remove unused variable `isdead'.
9176 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9177 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9178 (x_create_tip_frame): Remove unused variable `tem'.
9179
9180 * w32inevt.c (w32_console_read_socket):
9181 Remove unused variable `no_events'.
9182
9183 * w32term.c (x_draw_composite_glyph_string_foreground):
9184 Remove unused variable `width'.
9185
1149507c
JB
91862011-03-24 Juanma Barranquero <lekktu@gmail.com>
9187
9188 * w32term.c (x_set_glyph_string_clipping):
9189 Don't pass uninitialized region to CombineRgn.
9190
9c88f339
JB
91912011-03-23 Juanma Barranquero <lekktu@gmail.com>
9192
9193 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9194 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9195 (Fx_close_connection): Remove unused variable `i'.
9196
9197 * w32font.c (w32font_draw): Return number of glyphs.
9198 (w32font_open_internal): Remove unused variable `i'.
9199 (w32font_driver): Add missing initializer.
9200
9201 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9202 (fill_in_menu): Remove unused variable `items_added'.
9203
9204 * w32term.c (last_mouse_press_frame): Remove static global variable.
9205 (w32_clip_to_row): Remove unused variable `f'.
9206 (x_delete_terminal): Remove unused variable `i'.
9207
9208 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9209 (NOTHING): Remove unused static global variable.
9210 (uniscribe_check_otf): Remove unused variable `table'.
9211 (uniscribe_font_driver): Add missing initializers.
9212
dee091a3
JD
92132011-03-23 Julien Danjou <julien@danjou.info>
9214
9215 * term.c (Fsuspend_tty, Fresume_tty):
9216 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9217 * window.c (temp_output_buffer_show):
9218 * insdel.c (signal_before_change):
9219 * frame.c (Fhandle_switch_frame):
9220 * fileio.c (Fdo_auto_save):
9221 * emacs.c (Fkill_emacs):
9222 * editfns.c (save_excursion_restore):
9223 * cmds.c (internal_self_insert):
9224 * callint.c (Fcall_interactively):
9225 * buffer.c (Fkill_all_local_variables):
9226 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9227 Use Frun_hooks.
0f4a96b5 9228 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9229 unconditionally since it does the check itself.
dee091a3 9230
2c520ab5 92312011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9232
c9c49752
PE
9233 Fix more problems found by GCC 4.5.2's static checks.
9234
8abc3f12
PE
9235 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9236 the first time through the loop, since we know p0 < p1 then.
9237 This also avoids a gcc -Wstrict-overflow warning.
9238
a2d26660
PE
9239 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9240 leading to a memory leak, possible in functions like
9241 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9242 of objects (Bug#8318).
a2d26660 9243
916c72e9
PE
9244 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9245 that could (at least in theory) be that large.
9246
19ab8a18
PE
9247 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9248 This is less likely to overflow, and avoids undefined behavior if
9249 overflow does occur. All callers changed. Use strtoul to scan
9250 for the unsigned long integer.
b7cbbd6f
PE
9251 (pint2hrstr): Simplify and tune code slightly.
9252 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9253
f0641eff
PE
9254 * scroll.c (do_scrolling): Work around GCC bug 48228.
9255 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9256
7f650bb9
PE
9257 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9258 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9259 (validate_x_resource_name): Simplify count usage.
9260 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9261
37dd57d1
PE
9262 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9263 fail (Bug#8306).
81e56e61 9264
699979fc 9265 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9266
401bf9b4
PE
9267 * process.c (Fmake_network_process): Use socklen_t, not int,
9268 where POSIX says socklen_t is required in portable programs.
9269 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9270 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9271 (Fmake_network_process, server_accept_connection):
9272 (wait_reading_process_output, read_process_output):
9273 Likewise.
9274
b93aacde
PE
9275 * process.c: Rename or move locals to avoid shadowing.
9276 (list_processes_1, Fmake_network_process):
9277 (read_process_output_error_handler, exec_sentinel_error_handler):
9278 Rename or move locals.
4dc343ee 9279 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9280 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9281 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9282 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9283 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9284
af8a867c 9285 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9286 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9287 Include tparam.h instead, since it declares them.
af8a867c
PE
9288 * cm.h (PC): Remove extern decl; tparam.h now does this.
9289 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9290 * terminfo.c: Include tparam.h, to check interfaces.
9291 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9292 (tparam): Adjust signature to match interface in tparam.h;
9293 this removes some undefined behavior. Check that outstring and len
9294 are zero, which they always are with Emacs.
9295 * tparam.h (PC, BC, UP): New extern decls.
9296
0248044d 9297 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9298 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9299
8ff096c1 9300 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9301 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9302 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9303 (ftfont_list): Remove unused local.
49eaafba
PE
9304 (get_adstyle_property, ftfont_pattern_entity):
9305 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9306 Rename locals to avoid shadowing.
8ff096c1 9307
e2be39f6
PE
9308 * xfont.c (xfont_list_family): Mark var as initialized.
9309
c9735e30
PE
9310 * xml.c (make_dom): Now static.
9311
8f5201ae
PE
9312 * composite.c (composition_compute_stop_pos): Rename local to
9313 avoid shadowing.
b246f932
PE
9314 (composition_reseat_it): Remove unused locals.
9315 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9316 (composition_update_it): Mark var as initialized.
11b61122
PE
9317 (find_automatic_composition): Mark vars as initialized,
9318 with a FIXME (Bug#8290).
8f5201ae 9319
760fbc2c
PE
9320 character.h: Rename locals to avoid shadowing.
9321 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9322 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9323 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9324 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9325 to avoid shadowing.
9326
ff08eb85
PE
9327 * textprop.c (property_change_between_p): Remove; unused.
9328
fc7bf025
PE
9329 * intervals.c (interval_start_pos): Now static.
9330
235d7abc
PE
9331 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9332
44f230aa
SM
9333 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9334 Rename locals to avoid shadowing.
3e7d6594 9335
50060332
PE
9336 * sound.c (wav_play, au_play, Fplay_sound_internal):
9337 Fix pointer signedness.
d01f234b 9338 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9339 (wav_play): Initialize a variable to 0, to prevent undefined
9340 behavior (Bug#8278).
50060332 9341
c4fc4e30
PE
9342 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9343
918436ed
PE
9344 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9345
c939f91b
PE
9346 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9347 clobbering (Bug#8298).
b9c7f648
PE
9348 * sysdep.c (sys_subshell): Likewise.
9349 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9350
6bd8c144
PE
9351 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9352 This should get cleaned up, so that child_setup has the
9353 same signature on all platforms.
9354
7710357c 9355 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9356 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9357
c59da222
CY
93582011-03-22 Chong Yidong <cyd@stupidchicken.com>
9359
9360 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9361 not to be necessary, and produces flickering.
9362
66b87493
GM
93632011-03-20 Glenn Morris <rgm@gnu.org>
9364
9365 * config.in: Remove file.
9366
45b6f6d5
JB
93672011-03-20 Juanma Barranquero <lekktu@gmail.com>
9368
9369 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9370 are now in src/globals.h.
9371 (syms_of_minibuf): Remove spurious & from previous change.
9372
cd394be1 93732011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9374
9375 * minibuf.c (completing-read-function): New variable.
9376 (completing-read-default): Rename from completing-read.
9377 (completing-read): Call completing-read-function.
9378
b14e3e21
CY
93792011-03-19 Juanma Barranquero <lekktu@gmail.com>
9380
9381 * xfaces.c (Fx_load_color_file):
9382 Read color file from absolute filename (bug#8250).
9383
f2b726e6
JB
93842011-03-19 Juanma Barranquero <lekktu@gmail.com>
9385
9386 * makefile.w32-in: Update dependencies.
9387
09f6ff02
EZ
93882011-03-17 Eli Zaretskii <eliz@gnu.org>
9389
9390 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9391
29a6015a
PE
93922011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9393
a3a6c54e
PE
9394 Fix more problems found by GCC 4.5.2's static checks.
9395
b766f867
PE
9396 * process.c (make_serial_process_unwind, send_process_trap):
9397 (sigchld_handler): Now static.
9398
be02381c
PE
9399 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9400 That way, the code declares only the vars that it needs.
9401 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9402 * s/cygwin.h (PTY_ITERATION): Likewise.
9403 * s/darwin.h (PTY_ITERATION): Likewise.
9404 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9405
57048744
PE
9406 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9407 * process.c (allocate_pty): Don't declare stb unless it's needed.
9408
7914961c 9409 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9410 (CONSTANTLIM): Remove; unused.
9411 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9412 Define only if needed.
7914961c 9413
b3967b18
PE
9414 * unexelf.c (unexec): Name an expression,
9415 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9416 Use a different way to cause a compilation error if anyone uses
9417 n rather than nn, a way that does not involve shadowing.
73366a00 9418 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9419
29a6015a
PE
9420 * deps.mk (unexalpha.o): Remove; unused.
9421
43cfc33e 9422 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9423 * unexec.h: New file.
ce701a33
PE
9424 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9425 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9426 Depend on unexec.h.
9427 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9428 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9429 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9430 Change as necessary to match prototype in unexec.h.
ce701a33 9431
01f44d5a
PE
9432 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9433 shadowing.
4f63c6bb 9434 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9435
a6670b0b
PE
9436 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9437 Rename locals to avoid shadowing.
9438
cef2010d 9439 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9440 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9441
d4d7173a
PE
9442 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9443
f08b802a
PE
9444 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9445 warning when compiling print.c.
9446
3ddb0639
PE
9447 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9448 instead of using an uninitialized var.
5ad03b97 9449 (font_sort_entities): Mark var as initialized.
3ddb0639 9450
170a2692
PE
9451 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9452
e663c700
PE
9453 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9454 pointers to constants.
89bc529a 9455 (font_parse_fcname): Remove unused vars.
7b81e2d0 9456 (font_delete_unmatched): Now static.
ea838e10 9457 (font_get_spec): Remove; unused.
13a547c6
PE
9458 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9459 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9460 Rename or move locals to avoid shadowing.
e663c700 9461
2a80c887 9462 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9463 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9464
1384fa33 9465 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9466 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9467
8b2c52e9
PE
9468 * alloc.c (mark_backtrace): Move decl from here ...
9469 * lisp.h: ... to here, so that it can be checked.
9470
475545b5 9471 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9472 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9473 (lisp_indirect_variable): Name an expression,
9474 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9475 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9476
b1349114 9477 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9478 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9479 Use const pointer when appropriate.
b1349114 9480
a2928364
PE
9481 * lisp.h (get_system_name, get_operating_system_release):
9482 Move decls here, to check interfaces.
9483 * process.c (get_operating_system_release): Move decl to lisp.h.
9484 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9485 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9486 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9487 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9488 (Fformat_time_string, Fencode_time, Finsert_char):
9489 (Ftranslate_region_internal, Fformat):
9490 Rename or remove local vars to avoid shadowing.
9710023e 9491 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9492
a415e694
PE
9493 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9494 avoid shadowing.
9495
8ef4622d
PE
9496 * lisp.h (eassert): Check that the argument compiles, even if
9497 ENABLE_CHECKING is not defined.
9498
946f9a5b
PE
9499 * data.c (Findirect_variable): Name an expression, to avoid
9500 gcc -Wbad-function-cast warning.
112396d6 9501 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9502 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9503 (Fmake_variable_buffer_local, Fmake_local_variable):
9504 Mark variables as initialized.
52746918 9505 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9506
e5aab7e7 9507 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9508 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9509 Rename locals to avoid shadowing.
dff45157
PE
9510 (mark_stack): Move local variables into the #ifdef region where
9511 they're used.
7bc26fdb
PE
9512 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9513 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9514 needed otherwise.
9515 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9516 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9517 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9518
e5aab7e7
PE
9519 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9520 avoids undefined behavior in theory.
9521
4da60324
PE
9522 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9523
88043301
PE
9524 Use functions, not macros, for up- and down-casing (Bug#8254).
9525 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9526 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9527 to use the following functions instead of these macros.
9528 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9529 EMACS_INT, since callers assume the returned value fits in int.
9530 (upcase1): Likewise, for UPCASE_TABLE.
9531 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9532 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9533 the race-condition problem in the old DOWNCASE.
88043301 9534
19ed5445
PE
9535 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9536 Rename locals to avoid shadowing.
9537 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9538 (regex_compile, re_search_2, re_match_2_internal):
9539 Remove unused local vars.
952db0d7
PE
9540 (FREE_VAR): Rewrite so as not to use empty "else",
9541 which gcc can warn about.
da053e48 9542 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9543 (RETALLOC_IF): Define only if needed.
9544 (WORDCHAR_P): Likewise. This one is never needed, but is used
9545 only in a comment talking about a compiler bug, so put inside
9546 the #if 0 of that comment.
9547 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9548 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9549 Remove; unused.
19ed5445 9550
1f3561e4 9551 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9552 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9553 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9554
ded6f8f7
PE
9555 * search.c (simple_search): Remove unused var.
9556
dbd37a95
PE
9557 * dired.c (compile_pattern): Move decl from here ...
9558 * lisp.h: ... to here, so that it can be checked.
9559 (struct re_registers): New forward decl.
9560
7e47afad
PE
9561 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9562
85f24f61
PE
9563 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9564 All uses changed.
9565 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9566 Rename locals to avoid shadowing.
5671df8f 9567 (Fvertical_motion): Mark locals as initialized.
85f24f61 9568
181aa2be 9569 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9570 (casify_region): Mark local as initialized.
181aa2be 9571
930d429c
PE
9572 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9573
7082eac6
PE
9574 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9575 New macros, so that the caller can use some names other than
9576 gcpro1, gcpro2, etc.
9577 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9578 of the new macros.
9579 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9580 argument, for consistency with GCPRO2_VAR, etc: it is now the
9581 prefix of the variable, not the variable itself. All uses
9582 changed.
38b2c076
PE
9583 * dired.c (directory_files_internal, file_name_completion):
9584 Rename locals to avoid shadowing.
9585
15206ed9
PE
9586 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9587 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9588 dired.c's scmp function, had undefined behavior.
9589 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9590 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9591 * buffer.h: ... to here, because these macros use current_buffer,
9592 and the new implementation with inline functions needs to have
9593 current_buffer in scope now, rather than later when the macros
9594 are used.
9595 (downcase, upcase1): New static inline functions.
9596 (DOWNCASE, UPCASE1): Reimplement using these functions.
9597 This avoids undefined behavior in expressions like
9598 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9599 from race conditions in accessing the global variables
9600 case_temp1 and case_temp2.
9601 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9602 * lisp.h (case_temp1, case_temp2): Remove their decls.
9603 * character.h (ASCII_CHAR_P): Move from here ...
9604 * lisp.h: ... to here, so that the inline functions mentioned
9605 above can use them.
9606
4a6bea26
PE
9607 * dired.c (directory_files_internal_unwind): Now static.
9608
f14b7e14
PE
9609 * fileio.c (file_name_as_directory, directory_file_name):
9610 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9611 Now static.
2893f146
PE
9612 (file_name_as_directory): Use const pointers when appropriate.
9613 (Fexpand_file_name): Likewise. In particular, newdir might
9614 point at constant storage, so make it a const pointer.
fd4ead52 9615 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9616 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9617 signedness issues.
f839df0c
PE
9618 (Fset_file_times, Finsert_file_contents, auto_save_error):
9619 Rename locals to avoid shadowing.
f14b7e14 9620
5716756e 9621 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9622 (Ftry_completion, Fall_completions): Rename or remove locals
9623 to avoid shadowing.
5716756e 9624
b4c3046a
PE
9625 * marker.c (bytepos_to_charpos): Remove; unused.
9626
b45db522
PE
9627 * lisp.h (verify_bytepos, count_markers): New decls,
9628 so that gcc does not warn that these functions aren't declared.
9629
85876d07
PE
9630 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9631 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9632 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9633 (copy_text): Remove unused local var.
85876d07 9634
03d78a21 9635 * filelock.c (within_one_second): Now static.
b3dd38ab 9636 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9637
5df8f01b
PE
9638 * buffer.c (fix_overlays_before): Mark locals as initialized.
9639 (fix_start_end_in_overlays): Likewise. This function should be
9640 simplified by using pointers-to-pointers, but that's a different
9641 matter.
b1d876f1 9642 (switch_to_buffer_1): Now static.
8f54f30a
PE
9643 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9644 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9645
a70072c9 9646 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9647 Fix pointer signedness issue.
edced198
PE
9648 (sys_subshell): Mark local as volatile if checking for lint,
9649 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9650 (MAXPATHLEN): Define only if needed.
a70072c9 9651
a0977c44
PE
9652 * process.c (serial_open, serial_configure): Move decls from here ...
9653 * systty.h: ... to here, so that they can be checked.
9654
a884fdcc
PE
9655 * fns.c (get_random, seed_random): Move extern decls from here ...
9656 * lisp.h: ... to here, so that they can be checked.
9657
604efe86 9658 * sysdep.c (reset_io): Now static.
b8950c94 9659 (wait_for_termination_signal): Remove; unused.
604efe86 9660
38fc62d9
PE
9661 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9662 (copy_keymap_item, append_key, push_text_char_description):
9663 Now static.
1004a21a 9664 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9665 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9666 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9667 (describe_map_tree):
9668 Rename locals to avoid shadowing.
38fc62d9 9669
2f2650da
PE
9670 * keyboard.c: Declare functions static if they are not used elsewhere.
9671 (echo_char, echo_dash, cmd_error, top_level_2):
9672 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9673 (read_char, kbd_buffer_get_event, make_lispy_position):
9674 (make_lispy_event, make_lispy_movement, apply_modifiers):
9675 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9676 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9677 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9678 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9679 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9680
a053e86c 9681 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9682 (mark_kboards): Move decl here ...
9683 * alloc.c (mark_kboards): ... from here.
a053e86c 9684
4752793e
PE
9685 * lisp.h (force_auto_save_soon): New decl.
9686
74f10ca7 9687 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9688 (DEFINE_DUMMY_FUNCTION): New macro.
9689 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9690 Use it.
c03cd23f
PE
9691 (main): Add casts to avoid warnings
9692 if GCC considers string literals to be constants.
74f10ca7 9693
022e70d4
PE
9694 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9695
59d6fe83
PE
9696 * dbusbind.c: Pointer signedness fixes.
9697 (xd_signature, xd_append_arg, xd_initialize):
9698 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9699 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9700 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9701 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9702
78320123
PE
9703 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9704 if GCC considers string literals to be constants.
49cebcca 9705 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9706
35ac2a97
SM
97072011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9708
fb103ca9
SM
9709 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9710 (print_preprocess, print_object): New macro to fix last change.
9711
35ac2a97
SM
9712 * print.c (print_preprocess): Don't forget font objects.
9713
62973b41
JB
97142011-03-16 Juanma Barranquero <lekktu@gmail.com>
9715
9716 * emacs.c (USAGE3): Doc fixes.
9717
0e48bb22
AS
97182011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9719
9720 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9721 structure.
9722
7684e57b
JB
97232011-03-14 Juanma Barranquero <lekktu@gmail.com>
9724
9725 * lisp.h (VWindow_system, Qfile_name_history):
9726 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9727 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9728 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9729
9730 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9731 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9732
9733 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9734 * w32console.c (detect_input_pending, read_input_pending)
9735 (encode_terminal_code):
9736 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9737 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9738 (w32_system_caret_y, Qfile_name_history):
9739 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9740 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9741 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9742 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9743 * w32proc.c (Qlocal, report_file_error):
9744 * w32term.c (Vwindow_system, updating_frame):
9745 * w32uniscribe.c (initialized, uniscribe_font_driver):
9746 Remove unneeded extern declarations.
9747
2aa46d6c
CY
97482011-03-14 Chong Yidong <cyd@stupidchicken.com>
9749
c96bbc66 9750 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9751
cffc6f3b
CY
97522011-03-13 Chong Yidong <cyd@stupidchicken.com>
9753
9754 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9755 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9756 These macros can no longer be used for assignment.
9757
44f230aa
SM
9758 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9759 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9760 (record_buffer_markers, fetch_buffer_markers): New functions for
9761 recording and fetching special buffer markers.
9762 (set_buffer_internal_1, set_buffer_temp): Use them.
9763
9764 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9765
9766 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9767
9768 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9769 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9770
9771 * xdisp.c (hscroll_window_tree):
9772 (reconsider_clip_changes): Use PT instead of BUF_PT.
9773
d251f04b
EZ
97742011-03-13 Eli Zaretskii <eliz@gnu.org>
9775
9776 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9777 $(EMACS_ROOT)/lib/intprops.h.
9778
f0c77cd1
PE
97792011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9780
3eca4629
PE
9781 Fix more problems found by GCC 4.5.2's static checks.
9782
7c86ee98
PE
9783 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9784 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9785 (xg_free_frame_widgets): Make it clear that a local variable is
9786 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9787 (gdk_window_get_screen): Make it clear that this macro is needed
9788 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9789 (int_gtk_range_get_value): New function, which avoids a diagnostic
9790 from gcc -Wbad-function-cast.
9791 (xg_set_toolkit_scroll_bar_thumb): Use it.
9792 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9793 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9794 (get_utf8_string, xg_get_file_with_chooser):
9795 Rename locals to avoid shadowing.
9796 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9797
41729b81
PE
9798 * xgselect.c (xg_select): Remove unused var.
9799
f0c77cd1
PE
9800 * image.c (four_corners_best): Mark locals as initialized.
9801 (gif_load): Initialize transparent_p to zero (Bug#8238).
9802 Mark another local as initialized.
ec6cf4c6 9803 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9804
ce0ad53d 9805 * image.c (clear_image_cache): Now static.
d5d5a617 9806 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9807 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9808 (x_edge_detection): Remove unnecessary cast that
9809 gcc -Wbad-function-cast diagnoses.
2037898d 9810 (gif_load): Fix pointer signedness.
6ae141d6
PE
9811 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9812 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9813
33383987 98142011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9815
d32df629
PE
9816 Improve quality of tests for time stamp overflow.
9817 For example, without this patch (encode-time 0 0 0 1 1
9818 1152921504606846976) returns the obviously-bogus value (-948597
9819 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9820 reports time overflow. See
9821 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9822 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9823 * editfns.c: Include limits.h and intprops.h.
9824 (TIME_T_MIN, TIME_T_MAX): New macros.
9825 (time_overflow): Move earlier, to before first use.
9826 (hi_time, lo_time): New functions, for an accurate test for
9827 out-of-range times.
9828 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9829 (Fget_internal_run_time): Don't assume time_t fits in int.
9830 (make_time): Use list2 instead of Fcons twice.
9831 (Fdecode_time): More accurate test for out-of-range times.
9832 (check_tm_member): New function.
9833 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9834 (lisp_time_argument): Don't rely on undefined left-shift and
9835 right-shift behavior when checking for time stamp overflow.
8be6f318 9836
fe31d94c
PE
9837 * editfns.c (time_overflow): New function, refactoring common code.
9838 (Fformat_time_string, Fdecode_time, Fencode_time):
9839 (Fcurrent_time_string): Use it.
9840
8be6f318
PE
9841 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9842 * dired.c (make_time): Move to ...
9843 * editfns.c (make_time): ... here.
9844 * systime.h: Note the move.
9845
09d9db2c 98462011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9847
126bc0dc
YM
9848 * fringe.c (update_window_fringes): Remove unused variables.
9849
c47cbdfd
YM
9850 * unexmacosx.c (copy_data_segment): Also copy __got section.
9851 (Bug#8223)
9852
7ac80be9
EZ
98532011-03-12 Eli Zaretskii <eliz@gnu.org>
9854
c96bbc66 9855 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9856 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9857 Constify `char *' arguments and their references according to
9858 prototypes in tparam.h.
9859
ecb0f94d 9860 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9861
7ac80be9
EZ
9862 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9863 Adapt all references accordingly.
9864
9865 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9866
ef1fd07e
TT
98672011-03-11 Tom Tromey <tromey@redhat.com>
9868
9869 * buffer.c (syms_of_buffer): Remove obsolete comment.
9870
7ef4b50c
EZ
98712011-03-11 Eli Zaretskii <eliz@gnu.org>
9872
9873 * termhooks.h (encode_terminal_code): Declare prototype.
9874
9875 * msdos.c (encode_terminal_code): Don't declare prototype.
9876
9877 * term.c (encode_terminal_code): Now external again, used by
9878 w32console.c and msdos.c.
9879
44f230aa
SM
9880 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9881 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9882
4b1ec863 98832011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9884
1714f52b 9885 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9886
4b1ec863
PE
9887 * fringe.c (update_window_fringes): Mark locals as initialized
9888 (Bug#8227).
9889 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9890
524c7aa6
PE
9891 * alloc.c (mark_fringe_data): Move decl from here ...
9892 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9893 to check its interface.
9894 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9895
a5c0af81 9896 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9897 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9898 (fontset_font): Mark local as initialized.
a9a06e0b 9899 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9900
b4716021
PE
9901 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9902
811e9bac 9903 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9904 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9905 (x_own_selection, Fx_disown_selection_internal): Rename locals
9906 to avoid shadowing.
9907 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9908
7e3ab302
PE
9909 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9910 so that the caller can use some name other than gcpro1.
9911 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9912 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9913 (Fx_backspace_delete_keys_p):
9914 Use them to avoid shadowing, and rename vars to avoid shadowing.
9915 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9916 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9917 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9918 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9919 Remove unused locals.
7e3ab302
PE
9920 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9921 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9922 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9923 macros.
f78faa98 9924
e2b13473
PE
9925 * xterm.h (x_mouse_leave): New decl.
9926
77f23912
PE
9927 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9928 Remove unused functions.
cdf4ba58
PE
9929 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9930 (x_calc_absolute_position): Now static.
7411c686 9931 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9932 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9933 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9934 unless they are used.
38d0b34a
PE
9935 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9936 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9937 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9938 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9939 (x_error_catcher, x_connection_closed, x_error_handler):
9940 (x_error_quitter, xembed_send_message, x_iconify_frame):
9941 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9942 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9943 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9944
44f230aa
SM
9945 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9946 Rename or move locals to avoid shadowing.
6b463e58 9947 (tty_defined_color, merge_face_heights): Now static.
5967d051 9948 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9949 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9950 does not deduce is never used uninitialized.
73719eba
PE
9951 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9952 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9953
426994c3 9954 * terminal.c (store_terminal_param): Now static.
5489860b 9955
032f1620 9956 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9957 (set_frame_menubar): Remove unused local.
d4323972 9958 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9959 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9960 since they might point to immutable storage.
281585b0
PE
9961 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9962 since it's unused otherwise.
032f1620 9963
367c19e5 9964 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9965 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9966 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9967 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9968 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9969 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9970 does not deduce are never used uninitialized.
70739cbe 9971
07b48fa9
PE
9972 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9973
8868a238 9974 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9975 * window.c (window_loop, size_window):
9976 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9977
7e5cf297 9978 * window.c (display_buffer): Now static.
d6550a9f
PE
9979 (size_window): Mark variables that gcc -Wuninitialized
9980 does not deduce are never used uninitialized.
a586633d
PE
9981 * window.h (check_all_windows): New decl, to forestall
9982 gcc -Wmissing-prototypes diagnostic.
5b555da1 9983 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9984
f6095868
PE
9985 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9986 shadowing.
9987 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9988 Include <limits.h>.
9989 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9990 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9991 (load_charset_map): Mark variables that gcc -Wuninitialized
9992 does not deduce are never used uninitialized.
53df7c11 9993 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9994
f38b440c
PE
9995 * coding.c (coding_set_source, coding_set_destination):
9996 Use "else { /* comment */ }" rather than "else /* comment */;"
9997 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9998 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9999 a block, when the outer 'i' will do.
10000 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10001 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10002 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10003 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10004 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10005 Rename locals to avoid shadowing.
10006 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
10007 * coding.c (emacs_mule_char, encode_invocation_designation):
10008 Now static, since they're not used elsewhere.
413bb2db 10009 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 10010 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
10011 (decode_coding_emacs_mule): Mark variables that gcc
10012 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
10013 (detect_coding_iso_2022): Initialize a local variable that might
10014 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 10015 this initialization is needed. (Bug#8211)
5f58e762
PE
10016 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10017 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10018 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10019 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10020 Remove unused macros.
f38b440c 10021
232b38b9 10022 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 10023 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 10024 * character.c (string_count_byte8): Likewise.
232b38b9 10025
fb90da1b
PE
10026 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10027 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10028
fb93dbc2
PE
10029 * chartab.c (copy_sub_char_table): Now static, since it's not used
10030 elsewhere.
5c156ace
PE
10031 (sub_char_table_ref_and_range, char_table_ref_and_range):
10032 Rename locals to avoid shadowing.
bbcd0949 10033 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 10034
7d3b3862 10035 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 10036 (BIDI_BOB): Remove unused macro.
7d3b3862 10037
6be7d3da
PE
10038 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10039 deduce are never used uninitialized.
c2ed9c8b 10040 * term.c (encode_terminal_code): Likewise.
6be7d3da 10041
75f8807f 10042 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 10043
50938595
PE
10044 * tparam.h: New file.
10045 * term.c, tparam.h: Include it.
10046 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10047 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10048 Move these decls to tparam.h, and make them agree with what
10049 is actually in tparam.c. The previous trick of using incompatible
10050 decls in different modules does not conform to the C standard.
10051 All callers of tparam changed to use tparam's actual API.
10052 * tparam.c (tparam1, tparam, tgoto):
10053 Use const pointers where appropriate.
10054
fbceeba2
PE
10055 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10056 * cm.h (struct cm): Likewise.
10057 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10058 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10059 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10060 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10061 (turn_on_face, init_tty): Likewise.
10062 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10063
7f3f1250
PE
10064 * term.c (term_mouse_position): Rename local to avoid shadowing.
10065
e6ca6543
PE
10066 * alloc.c (mark_ttys): Move decl from here ...
10067 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10068
c40f8d15
AS
100692011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10070
10071 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10072
cfe0661d
JB
100732011-03-09 Juanma Barranquero <lekktu@gmail.com>
10074
10075 * search.c (compile_pattern_1): Remove argument regp, unused since
10076 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10077 (compile_pattern): Don't pass it.
10078
0afb4571
J
100792011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10080
10081 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10082 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10083 for ! HAVE_GTK3.
10084 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10085
10086 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10087
10088 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10089 gdk_window_get_screen, gdk_window_get_geometry,
10090 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10091 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10092 (xg_get_pixbuf_from_pixmap): New function.
10093 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10094 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10095 Call xg_get_pixbuf_from_pixmap instead of
10096 gdk_pixbuf_get_from_drawable.
10097 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10098 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10099 (xg_check_special_colors): Use GtkStyleContext and its functions
10100 for HAVE_GTK3.
10101 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10102 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10103 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10104 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10105 Call gtk_widget_get_preferred_size.
0afb4571
J
10106 (xg_frame_resized): gdk_window_get_geometry only takes 5
10107 parameters.
44f230aa
SM
10108 (xg_win_to_widget, xg_event_is_for_menubar):
10109 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10110 (xg_set_widget_bg): New function.
10111 (delete_cb): New function.
895009e1 10112 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10113 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10114 (xg_set_background_color): Call xg_set_widget_bg.
10115 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10116 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10117 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10118 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10119 if ! HAVE_GTK3.
10120 (update_frame_tool_bar): Call gtk_widget_hide.
10121 (xg_initialize): Use GDK_KEY_g.
10122
10123 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10124 if ! HAVE_GTK3
10125 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10126
10127 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10128 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10129 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10130
1c2cc4ef
JB
101312011-03-08 Juanma Barranquero <lekktu@gmail.com>
10132
10133 * w32xfns.c (select_palette): Check success of RealizePalette against
10134 GDI_ERROR, not zero.
10135
33383987 10136See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10137
10138;; Local Variables:
10139;; coding: utf-8
aac0c6e3
MR
10140;; End:
10141
2f097256 10142 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10143
10144 This file is part of GNU Emacs.
10145
10146 GNU Emacs is free software: you can redistribute it and/or modify
10147 it under the terms of the GNU General Public License as published by
10148 the Free Software Foundation, either version 3 of the License, or
10149 (at your option) any later version.
10150
10151 GNU Emacs is distributed in the hope that it will be useful,
10152 but WITHOUT ANY WARRANTY; without even the implied warranty of
10153 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10154 GNU General Public License for more details.
10155
10156 You should have received a copy of the GNU General Public License
10157 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.