Fix use of uninitialized variable.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5a7a728b
EZ
12011-10-28 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4 possible random value that matches one of those tested as
5 condition to clear the mouse face.
6
d3d0842f
CY
72011-10-28 Chong Yidong <cyd@gnu.org>
8
9 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
10
31b39d13
DN
112011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
12
13 * window.c (make_window): Initialize phys_cursor_on_p.
14
9aba6043
SM
152011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
16
17 * lisp.h (struct Lisp_Symbol): Update comments.
18
c20992f4
JB
192011-10-28 Juanma Barranquero <lekktu@gmail.com>
20
21 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
22
db4f02f2
EZ
232011-10-28 Eli Zaretskii <eliz@gnu.org>
24
25 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
26 <oslsachem@gmail.com> for helping to debug this.
27
28 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
29 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
30 (g_b_init_get_glyph_outline_w): New static variables.
31 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
32 (GetGlyphOutlineW_Proc): New typedefs.
33 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
34 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
35 New functions.
36 (w32font_open_internal, compute_metrics):
37 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
38 instead of calling the "wide" APIs directly.
39
40 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
41
42 * w32.h (syms_of_w32font): Add prototype.
43
87e68db4
JB
442011-10-27 Juanma Barranquero <lekktu@gmail.com>
45
46 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
47 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
48 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
49 (Fmove_to_window_line): Doc fix.
50
435c1d67
CY
512011-10-27 Chong Yidong <cyd@gnu.org>
52
53 * process.c (make_process): Set gnutls_state to NULL.
54
55 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
56 non-NULL, regardless of GNUTLS_INITSTAGE.
57 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
58 an error. Set process slots as soon as we allocate them.
59
60 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
61
9c6c6f49
CY
622011-10-27 Chong Yidong <cyd@gnu.org>
63
9aba6043
SM
64 * gnutls.c (emacs_gnutls_deinit): New function.
65 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
66 (Fgnutls_deinit, Fgnutls_boot): Use it.
67
68 * process.c (make_process): Initialize GnuTLS credentials to NULL.
69 (deactivate_process): Call emacs_gnutls_deinit.
70
657d08d3
JB
712011-10-27 Juanma Barranquero <lekktu@gmail.com>
72
73 * image.c (x_create_x_image_and_pixmap):
74 * w32.c (sys_rename, w32_delayed_load):
75 * w32font.c (fill_in_logfont):
76 * w32reg.c (x_get_string_resource): Silence compiler warnings.
77
5430d399
JB
782011-10-26 Juanma Barranquero <lekktu@gmail.com>
79
80 * w32fns.c (w32_default_color_map): New function,
81 extracted from Fw32_default_color_map.
a7ef684b 82 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 83
fe0055fa
PE
842011-10-25 Paul Eggert <eggert@cs.ucla.edu>
85
86 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
87
e6346438
SM
882011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
89
90 * keyboard.c (test_undefined): New function (bug#9751).
91 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
92
e112cc37
ET
932011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
94
95 * sysdep.c (init_sys_modes): Fix the check for the controlling
96 terminal (Bug#6649).
97
7b5d6677
EZ
982011-10-20 Eli Zaretskii <eliz@gnu.org>
99
100 * dispextern.h (struct bidi_it): New member next_en_type.
101
102 * bidi.c (bidi_line_init): Initialize the next_en_type member.
103 (bidi_resolve_explicit_1): When next_en_pos is valid for the
104 current character, check also for next_en_type being WEAK_EN.
105 (bidi_resolve_weak): Don't enter the expensive loop if the current
106 position is before next_en_pos. Record the bidi type of the first
107 non-ET, non-BN character we find, in addition to its position.
108 (bidi_level_of_next_char): Invalidate next_en_type when
109 next_en_pos is over-stepped.
110
7da0b018
PE
1112011-10-20 Paul Eggert <eggert@cs.ucla.edu>
112
113 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
114 * editfns.c: Rewrite current-time-zone so that it invokes
115 the equivalent of (format-time-string "%Z") to get the time zone name.
116 This fixes a bug when the time zone name contains characters that
117 need converting from the system time locale to Emacs internal format.
118 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
119 that patch fixed format-time-string to do the conversion, but
120 I forgot to fix current-time-zone.
121 (format_time_string): New function, containing most of
122 what Fformat_time_string used to contain.
123 (Fformat_time_string): Rewrite in terms of format_time_string.
124 This doesn't change this function's behavior.
125 (current-time-zone): Rewrite to use format_time_string.
126 This fixes the bug reported by Michael Schierl in
127 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
128 Jason Rumney's 2007-06-07 change worked around this bug, but
129 didn't fix it.
130 * systime.h (tzname, timezone): Remove no-longer-used declarations.
131
8547b010
EZ
1322011-10-19 Eli Zaretskii <eliz@gnu.org>
133
134 * xdisp.c (start_display): If the character at POS is displayed
135 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
136 (try_window_reusing_current_matrix): If a line ends in a display
137 vector or the next line starts in a display vector, continue
138 redrawing the window even though the character position of
139 start_row was reached.
8547b010
EZ
140 (Bug#9771, part 2)
141
4e948d15
CY
1422011-10-18 Chong Yidong <cyd@gnu.org>
143
144 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
145 with nobreak-char-display too.
146
4787455f
EZ
1472011-10-18 Eli Zaretskii <eliz@gnu.org>
148
149 Fix part 3 of bug#9771.
150 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
151 (bidi_resolve_neutral): Don't enter the expensive loop looking for
152 non-neutral characters if the current character is a paragraph
153 separator (a.k.a. Newline). This avoids running the same
154 expensive loop twice, once when we consume the preceding newline
155 and the other time when the line actually needs to be displayed.
156 Avoid the loop when we see neutrals on the base embedding level
157 following a character whose directionality is the same as the
158 paragraph's. This avoids running the expensive loop when a line
159 ends in a long sequence of neutrals, like control characters.
160 Add assertion against STRONG_AL type. Slightly rearrange code
161 that determines the type of a neutral given the first non-neutral
162 that follows it.
163 (bidi_level_of_next_char): Set next_en_pos to zero when
164 invalidating its info.
165
2c91f553
EZ
1662011-10-17 Eli Zaretskii <eliz@gnu.org>
167
168 * xdisp.c (push_display_prop): Determine whether to record string
169 or buffer position by IT->string, not by IT->method. Allow
170 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
171 (move_it_vertically_backward): Don't look for character position
172 immediately after the newline when in a continuation line.
173 (Bug#9771, part 1)
2c91f553 174
c7b08b0d
MR
1752011-10-15 Martin Rudalics <rudalics@gmx.at>
176
177 * window.c (coordinates_in_window): Rewrite and delabelize
178 vertical border check. (Bug#5357) (Bug#9618)
179
6b02f655
SM
1802011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
181
182 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
183 errors in XSetWindowBorder (bug#9310).
184
81d40c92
DA
1852011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
186
187 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
188 avoid crash when xmalloc overrun checking is enabled.
189
d4172c3b
EZ
1902011-10-13 Eli Zaretskii <eliz@gnu.org>
191
192 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
193 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
194 cursor motion with <left> and <right> arrow keys.
195
196 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
197 some callers set that themselves.
198
b00eea75
EZ
1992011-10-12 Eli Zaretskii <eliz@gnu.org>
200
201 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
202 display string and the previous row comes from the same string and
203 is empty. (Bug#9739) (Bug#9738)
204
8fe012c4
SM
2052011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
206
207 * doc.c (get_doc_string): Encode file name (bug#9735).
208
0074aef2
EZ
2092011-10-12 Eli Zaretskii <eliz@gnu.org>
210
79beb178
EZ
211 * bidi.c (bidi_level_of_next_char):
212 * xdisp.c (get_visually_first_element): Remove old incorrect
213 comments regarding the Unicode Line Separator character.
214
0074aef2
EZ
215 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
216
6e4b3fbe
DA
2172011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
218
219 * alloc.c (Fgc_status): Do not access beyond zombies array
220 boundary if nzombies > MAX_ZOMBIES.
221 * alloc.c (dump_zombies): Add missing format specifier.
222
0324f3af
PE
2232011-10-12 Paul Eggert <eggert@cs.ucla.edu>
224
b5525cac
PE
225 * xdisp.c (set_cursor_from_row): Simplify conditionals,
226 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
227
0324f3af
PE
228 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
229 Some packages use them to denote characters with modifiers.
230
e9b5f888
AS
2312011-10-11 Andreas Schwab <schwab@linux-m68k.org>
232
233 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
234 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
235 matching a pp-number. Rename parameter var to var1.
236
127827c0
SM
2372011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
238
239 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
240
c8fd3bd0
GM
2412011-10-08 Glenn Morris <rgm@gnu.org>
242
243 * callint.c (Fcall_interactively): Give a more explicit error for the
244 'c' case with a non-character input. (Bug#8479)
245
352ec8ff
EZ
2462011-10-08 Eli Zaretskii <eliz@gnu.org>
247
03669ccb
EZ
248 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
249 lines.
7061c986
EZ
250 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
251 lines that are hscrolled on the left.
03669ccb 252
352ec8ff
EZ
253 * dispnew.c (buffer_posn_from_coords): Account for a possible
254 presence of header-line. (Bug#4426)
255
a66cfb1c
SM
2562011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
257
6b02f655
SM
258 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
259 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 260
7c5ee88e
PE
2612011-10-07 Paul Eggert <eggert@cs.ucla.edu>
262
263 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
264 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
265 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
266 this makes Emacs dump core during garbage collection on rare
267 occasions. sizeof is obviously inferior to offsetof here, so
268 stick with offsetof.
269 (GC_POINTER_ALIGNMENT): New macro.
270 (mark_memory): Omit 3rd (offset) arg; caller changed.
271 Don't assume EMACS_INT alignment is the same as pointer alignment.
272
df1bbe5b
SM
2732011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
274
275 * keyboard.c (read_key_sequence_remapped): New var.
276 (read_key_sequence): Compute remapping in the right buffer.
277 (command_loop_1): Use read_key_sequence's remapping directly.
278
51553db6
SM
2792011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
280
32c1fffd
SM
281 * dired.c (file_name_completion): Don't expand file name.
282 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
283 before checking file name handler.
284
51553db6
SM
285 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
286 they've been requested explicitly (bug#9591).
287
b6bd1599 2882011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
289
290 * keymap.c (Fsingle_key_description): Use make_specified_string
291 instead of build_string to build string from push_key_description.
292 (Bug#5193)
293
f701dc2a
PE
2942011-09-30 Paul Eggert <eggert@cs.ucla.edu>
295
4222c55d
PE
296 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
297 This fixes a Y2038 bug on 64-bit hosts.
298 * buffer.c (reset_buffer):
299 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
300 (Fclear_buffer_auto_save_failure):
301 Use 0, not -1, to represent an unset failure time, since time_t
302 might not be signed.
303
f701dc2a
PE
304 Remove dependency on glibc malloc internals.
305 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
306 Move back here from lisp.h, but with their new implementations.
307 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
308 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
309 * charset.c (charset_table_init): New static var.
310 (syms_of_charset): Use it instead of xmalloc. This removes a
311 dependency on glibc malloc internals. See Eli Zaretskii's comment in
312 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
313 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
314 Move back to alloc.c.
315 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
316 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
317
9ceebf39
JD
3182011-09-30 Jan Djärv <jan.h.d@swipnet.se>
319
320 * nsterm.m (windowDidResize): Call x_set_window_size only when
321 ns_in_resize is true. Otherwise set pixelwidth/height and
322 call change_frame_size (Bug#9628).
323
cb993c58
PE
3242011-09-30 Paul Eggert <eggert@cs.ucla.edu>
325
3930c88b
PE
326 Port --enable-checking=all to Fedora 14 x86-64.
327 * charset.c (syms_of_charset): Also account for glibc malloc's
328 internal overhead when calculating the initial malloc maximum.
329
cb993c58
PE
330 Port --enable-checking=all to Fedora 14 x86.
331 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
332 Move to lisp.h.
333 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
334 (overrun_check_realloc, overrun_check_free):
335 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
336 That way, xmalloc returns a properly-aligned pointer even if
337 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
338 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
339 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
340 into account when calculating the initial malloc maximum.
341 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
342 Move here from alloc.c, so that charset.c can use it too.
343 Properly align; the old code wasn't right for common 32-bit hosts
344 when configured with --enable-checking=all.
345 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
346 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
347
31bed486
EZ
3482011-09-29 Eli Zaretskii <eliz@gnu.org>
349
04c70788 350 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
351 use EDOM.
352
fbcaa2f3
EZ
3532011-09-28 Eli Zaretskii <eliz@gnu.org>
354
355 * xdisp.c (compute_display_string_end): If there's no display
356 string at CHARPOS, return -1.
357
358 * bidi.c (bidi_fetch_char): When compute_display_string_end
359 returns a negative value, treat the character as a normal
360 character not covered by a display string. (Bug#9624)
361
a239d4e9
JB
3622011-09-28 Juanma Barranquero <lekktu@gmail.com>
363
364 * lread.c (Fread_from_string): Fix typo in docstring.
365
88652fd5
EZ
3662011-09-27 Eli Zaretskii <eliz@gnu.org>
367
368 * xdisp.c (handle_invisible_prop): If invisible text ends on a
369 newline, reseat the iterator instead of bidi-iterating there one
370 character at a time. (Bug#9610)
32c1fffd
SM
371 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
372 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 373
ed497dd4
AS
3742011-09-27 Andreas Schwab <schwab@linux-m68k.org>
375
376 * lread.c (readevalloop): Use correct code for NBSP.
377 (read1): Likewise. (Bug#9608)
378
b2bf61aa
MA
3792011-09-25 Michael Albinus <michael.albinus@gmx.de>
380
381 * dbusbind.c (Fdbus_register_signal): When service is not
382 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
383
32bbb17c
GM
3842011-09-25 Glenn Morris <rgm@gnu.org>
385
386 * buffer.c (truncate-lines): Doc fix.
387
94e0933e
CY
3882011-09-24 Chong Yidong <cyd@stupidchicken.com>
389
390 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
391 (Fset_window_next_buffers): Doc fix.
392
cddde921
GM
3932011-09-24 Glenn Morris <rgm@gnu.org>
394
395 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
396
1260aef1
PE
3972011-09-24 Paul Eggert <eggert@cs.ucla.edu>
398
25b4bfa0
PE
399 Fix minor problems found by static checking.
400 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
401 * indent.c (Fvertical_motion): Fix == vs = typo.
402
e3cbd34b
EZ
4032011-09-24 Eli Zaretskii <eliz@gnu.org>
404
a66cfb1c
SM
405 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
406 Default value is now t. Doc fix.
6bf7006f 407
e3cbd34b 408 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 409 logic when moving up, not only when moving down. Fix the
e3cbd34b 410 confusing name and values of the it_overshoot_expected variable;
32c1fffd 411 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
412
413 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
414 CHARPOS is covered by a display string which includes newlines.
415 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
416 is covered by a display string with embedded newlines.
417
a3de0cbd
MA
4182011-09-24 Michael Albinus <michael.albinus@gmx.de>
419
420 * dbusbind.c (Fdbus_register_signal): Add match rule to
421 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
422 (Fdbus_register_method, Vdbus_registered_objects_table):
423 Fix docstring.
a3de0cbd 424
b260039d
JM
4252011-09-24 Jim Meyering <meyering@redhat.com>
426
32c1fffd 427 do not ignore write error for any output size
b260039d
JM
428 The previous change was incomplete.
429 While it makes emacs --batch detect the vast majority of stdout
430 write failures, errors were still ignored whenever the output size is
431 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
432 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
433 && echo FAIL: ignored write error
434 FAIL: ignored write error
435 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
436 && echo FAIL: ignored write error
437 FAIL: ignored write error
438 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
439
8eca8a7c
AS
4402011-09-23 Andreas Schwab <schwab@linux-m68k.org>
441
442 * emacs.c (Fkill_emacs): In noninteractive mode exit
443 non-successfully if a write error occurred on stdout. (Bug#9574)
444
3341db62
EZ
4452011-09-21 Eli Zaretskii <eliz@gnu.org>
446
447 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
448 the xassert test.
449
450 * dispextern.h (struct it): Update the comment documenting what
451 can it->OBJECT be.
452
8c203dbf
EZ
4532011-09-20 Eli Zaretskii <eliz@gnu.org>
454
455 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
456 a display string, extend search for cursor position to end of row.
457 (find_row_edges): If the row ends in a newline from a display
458 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
459 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
460 (Fcurrent_bidi_paragraph_direction): Fix search for previous
461 non-empty line. Fixes confusing cursor motion with arrow keys at
462 the beginning of a line that starts with whitespace.
8c203dbf 463
a4824228
LMI
4642011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
465
466 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
467 (bug#9493).
468
33ed493b
CY
4692011-09-18 Chong Yidong <cyd@stupidchicken.com>
470
471 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
472 boolean (Bug#9154).
473
56cd55c8
EZ
4742011-09-18 Eli Zaretskii <eliz@gnu.org>
475
476 * xdisp.c (display_line): Record maximum and minimum buffer
477 positions even if no glyphs were produced (e.g., by a zero-width
478 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
479 buffer positions that will be removed from the glyph row because
480 they don't fit.
c02dcedf
EZ
481 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
482 column is beyond frame width: don't subtract 1 "pixel" when
483 computing width of the stretch.
3e62b7e0
EZ
484 (reseat_at_next_visible_line_start): Undo the change made on
485 2011-09-17 that saved paragraph information and restored it after
486 the call to `reseat'. (Bug#9545)
56cd55c8 487
5ed99d36 4882011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
489
490 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
491 and turn window cursor on if cleared (Bug#9415).
492
5ed99d36 4932011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
494
495 * search.c (boyer_moore): Take unibyte characters from pattern
496 literally. (Bug#9458)
497
9bade7b2
EZ
4982011-09-18 Eli Zaretskii <eliz@gnu.org>
499
500 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
501
e5e9d610
PE
5022011-09-18 Paul Eggert <eggert@cs.ucla.edu>
503
87e4427a
PE
504 Fix minor problem found by static checking.
505 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
506 initialized, to pacify gcc -Wuninitialized.
507
e5e9d610
PE
508 * fileio.c: Report proper errno when syscall falls.
509 (Finsert_file_contents): Save and restore errno,
510 so that report_file_error outputs the correct diagnostic.
511 (Fwrite_region) [CLASH_DETECTION]: Likewise.
512
a1674f0b
EZ
5132011-09-18 Eli Zaretskii <eliz@gnu.org>
514
515 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
516
fbfb6dd4
EZ
5172011-09-17 Eli Zaretskii <eliz@gnu.org>
518
519 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
520 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
521
bb187662
EZ
5222011-09-17 Eli Zaretskii <eliz@gnu.org>
523
1137e8b8 524 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 525 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
526
527 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
528 (bidi_find_paragraph_start): Search back for paragraph beginning
529 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
530 (bidi_move_to_visually_next): Only trigger paragraph-related
531 computations when the last character is a newline or at EOB, not
532 just any NEUTRAL_B. (Bug#9470)
533
bb187662
EZ
534 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
535 truncated lines if point is covered by a display string. (Bug#9524)
536
2e621251
PE
5372011-09-16 Paul Eggert <eggert@cs.ucla.edu>
538
539 * xselect.c: Relax test for outgoing X longs (Bug#9498).
540 (cons_to_x_long): New function.
541 (lisp_data_to_selection_data): Use it. Correct the test for
542 short-versus-long data; it was negated. Break out of vector
543 loop, for efficiency, when a long datum is discovered.
544
91a15bc6
SM
5452011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
546
547 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
548
b41c3a35
EZ
5492011-09-16 Eli Zaretskii <eliz@gnu.org>
550
551 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
552 GCC PR/17406) by declaring this function with external scope.
553
7812ba2d
PE
5542011-09-15 Paul Eggert <eggert@cs.ucla.edu>
555
556 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
557 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
558
cf7edc2a
AS
5592011-09-15 Andreas Schwab <schwab@linux-m68k.org>
560
561 * editfns.c (Fformat): Correctly handle text properties on "%%".
562
bd01620e
EZ
5632011-09-15 Eli Zaretskii <eliz@gnu.org>
564
565 * xterm.c (x_draw_composite_glyph_string_foreground):
566 * w32term.c (x_draw_composite_glyph_string_foreground):
567 * term.c (encode_terminal_code):
568 * composite.c (composition_update_it, get_composition_id):
569 * xdisp.c (get_next_display_element)
570 (fill_composite_glyph_string): Add comments about special meaning
571 of TAB characters in a composition.
572
a02719a3
PE
5732011-09-15 Paul Eggert <eggert@cs.ucla.edu>
574
575 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
576 This occurs when processing a multibyte format.
577 Problem reported by Wolfgang Jenker.
a02719a3 578
72589a3c
JB
5792011-09-15 Johan Bockgård <bojohan@gnu.org>
580
581 * xdisp.c (try_cursor_movement): Only check for exact match if
582 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
583
1c14176c
PE
5842011-09-14 Paul Eggert <eggert@cs.ucla.edu>
585
586 Remove unused external symbols.
587 * dispextern.h (calc_pixel_width_or_height): Remove decl.
588 * xdisp.c (calc_pixel_width_or_height): Now static.
589 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
590 * indent.c (check_display_width):
591 * w32term.c: Fix comment to match code.
592 * xterm.c, xterm.h (x_catching_errors): Remove.
593
d2eea5b5
PE
5942011-09-14 Paul Eggert <eggert@cs.ucla.edu>
595
596 * xselect.c: Use signed conversions more consistently (Bug#9498).
597 (selection_data_to_lisp_data): Assume incoming selection data are
598 signed integers, not unsigned. This is to be consistent with
599 outgoing selection data, which was modified to use signed integers
600 in as part of the fix to Bug#9196 in response to Jan D.'s comment
601 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
602 expects long, not unsigned long.
603
46888499
EZ
6042011-09-14 Eli Zaretskii <eliz@gnu.org>
605
606 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
607 computation of loop end. Reported by Johan Bockgård
608 <bojohan@gnu.org>.
609
ef8ef9fb
CY
6102011-09-13 Chong Yidong <cyd@stupidchicken.com>
611
612 * frame.c (Fother_visible_frames_p): Function deleted.
613
fa819fed
EZ
6142011-09-12 Eli Zaretskii <eliz@gnu.org>
615
616 * indent.c (compute_motion): Process display vector front to back
617 rather than the other way around. (Bug#2496)
618
2ba8e008
SM
6192011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
620
621 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
622
20f53c69
CY
6232011-09-11 Chong Yidong <cyd@stupidchicken.com>
624
625 * minibuf.c (Fread_from_minibuffer): Doc fix.
626
d562d7a4
EZ
6272011-09-11 Eli Zaretskii <eliz@gnu.org>
628
629 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
630 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
631
1c4d7f3d
LMI
6322011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
633
634 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
635 value for non-existent files.
636
b885bf36
EZ
6372011-09-11 Eli Zaretskii <eliz@gnu.org>
638
639 * fileio.c (Finsert_file_contents): If the file cannot be opened,
640 set its "size" to -1. This will set the modtime_size field of
641 the corresponding buffer to -1, which is what
642 verify-visited-file-modtime expects for files that do not exist.
643 (Bug#9139)
644
6612f0bf
PE
6452011-09-11 Paul Eggert <eggert@cs.ucla.edu>
646
647 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
648 here ...
649 * lisp.h: ... from here. push_key_description is no longer
650 defined in keyboard.c, so its declaration should not be in
651 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
652 logically belongs with push_key_description.
653
dfb3f755
PE
6542011-09-10 Paul Eggert <eggert@cs.ucla.edu>
655
656 * buffer.h: Include <sys/types.h> instead of <time.h>.
657 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
658 Problem reported by Herbert J. Skuhra.
659
3134906c
LMI
6602011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
661
662 * xml.c (parse_region): Make the parsing work for
663 non-comment-starting XML files again (bug#9144).
664
8d903f4e
AS
6652011-09-10 Andreas Schwab <schwab@linux-m68k.org>
666
667 * image.c (gif_load): Fix calculation of bottom and right corner.
668 (Bug#9468)
669
80ad64f4
EZ
6702011-09-10 Eli Zaretskii <eliz@gnu.org>
671
672 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
673 redisplay in small windows.
674
208a048d
EZ
6752011-09-09 Eli Zaretskii <eliz@gnu.org>
676
677 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
678
9b1c252e
MR
6792011-09-08 Martin Rudalics <rudalics@gmx.at>
680
681 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
682 Operate on live windows only.
683
2949f33b
JB
6842011-09-08 Juanma Barranquero <lekktu@gmail.com>
685
686 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
687
e08dcafd
EZ
6882011-09-07 Eli Zaretskii <eliz@gnu.org>
689
690 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
691 only under bidi iteration.
692
115b96bd
JD
6932011-09-07 Jan Djärv <jan.h.d@swipnet.se>
694
695 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
696
c8199d0f
PE
6972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
698
699 isnan: Fix porting problem to Solaris 10 with bundled gcc.
700 Without this fix, the command to link temacs failed due to an
701 undefined symbol __builtin_isnan. This is because
702 /usr/include/iso/math_c99.h #defines isnan(x) to
703 __builtin_isnan(x), but the bundled gcc, which identifies itself
704 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
705 a __builtin_isnan.
706 * floatfns.c (isnan): #undef, and then #define to a clone of
707 what's in data.c.
708 (Fisnan): Always define, since it's always available now.
709 (syms_of_floatfns): Always define isnan at the Lisp level.
710
e39b275c 7112011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
712
713 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
714
b2db44d9 7152011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 716
f4af5137 717 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
718 The previous code assumed that file offsets (off_t values) fit in
719 EMACS_INT variables, which is not true on typical 32-bit hosts.
720 The code messed up by falsely reporting buffer overflow in cases
721 such as (insert-file-contents "big" nil 1 2) into an empty buffer
722 when "big" contains more than 2**29 bytes, even though this
723 inserts just one byte and does not overflow the buffer.
724 (Finsert_file_contents): Store file offsets as off_t
725 values, not as EMACS_INT values. Check for overflow when
726 converting between EMACS_INT and off_t. When checking for
727 buffer overflow or for overlap, take the offsets into account.
728 Don't use EMACS_INT for small values where int suffices.
729 When checking for overlap, fix a typo: ZV was used where
730 ZV_BYTE was intended.
731 (Fwrite_region): Don't assume off_t fits into 'long'.
732 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
733
ecfc0a49
MA
7342011-09-05 Michael Albinus <michael.albinus@gmx.de>
735
736 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
737
6511acf2 7382011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 739
0999621a 740 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
741
742 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 743 (esprintf, exprintf, evxprintf): New functions.
62f19c19 744 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 745 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
746 (modify_event_symbol): Do not assume that the length of
747 name_alist_or_stem is safe to alloca and fits in int.
748 (Fexecute_extended_command): Likewise for function name and binding.
749 (Frecursion_depth): Wrap around reliably on integer overflow.
750 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
751 since some callers pass EMACS_INT values.
752 (Fsingle_key_description): Don't crash if symbol name contains more
753 than MAX_ALLOCA bytes.
754 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
755 (get_minibuffer): Arg is now EMACS_INT, not int.
756 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 757 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
758 * window.h (command_loop_level, minibuf_level): Reflect API changes.
759
2be7d702
PE
760 * dbusbind.c (signature_cat): New function.
761 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
762 Do not overrun buffer; instead, report string overflow.
763
9d1df220
PE
764 * dispnew.c (add_window_display_history): Don't overrun buffer.
765 Truncate instead; this is OK since it's just a log.
766
33ef5c64
PE
767 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
768 even if the time zone offset is outlandishly large.
769 Don't mishandle offset == INT_MIN.
770
66c6fdd5
PE
771 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
772 when creating daemon; the previous buffer-overflow check was incorrect.
773
d749b01b
PE
774 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
775 which has the guts of the old verror function.
776
b5cd1905
PE
777 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
778 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
779
6e1a67fb
PE
780 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
781 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 782 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 783 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
784 length of string rather than counting it via multiple sprintfs;
785 that's simpler and more reliable.
c21721cc
PE
786 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
787 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
788 sprintf, in case result does not fit in int.
789
c57b67fc
PE
790 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
791 (fontset_from_font): Print it.
792
8a401434
PE
793 * frame.c (tty_frame_count): Now printmax_t, not int.
794 (make_terminal_frame, set_term_frame_name): Print it.
795 (x_report_frame_params): In X, window IDs are unsigned long,
796 not signed long, so print them as unsigned.
797 (validate_x_resource_name): Check for implausibly long names,
798 and don't assume name length fits in 'int'.
799 (x_get_resource_string): Don't blindly alloca invocation name;
800 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
801 not fit in int.
802
6e1a67fb
PE
803 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
804 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
805 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
806
0df02bf3
PE
807 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
808 Use esprintf, not sprintf, in case result does not fit in int.
809
48e30793
PE
810 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
811 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
812 it as a large positive number.
813 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
814 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
815
a66ff6d8
PE
816 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
817 in case result does not fit in int.
818
aca216ff
PE
819 * print.c (float_to_string): Detect width overflow more reliably.
820 (print_object): Make sprintf buffer a bit bigger, to avoid potential
821 buffer overrun. Don't assume list length fits in 'int'. Treat
822 print length of 0 as 0, not as infinity; to be consistent with other
823 uses of print length in this function. Don't overflow print length
824 index. Don't assume hash table size fits in 'long', or that
825 vectorlike size fits in 'unsigned long'.
826
31c286f7
PE
827 * process.c (make_process): Use printmax_t, not int, to format
828 process-name gensyms.
829
55e5faa1
PE
830 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
831
80f2e268
PE
832 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
833 to avoid potential buffer overrun.
834
670741ab
PE
835 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
836 if X resource line is longer than 512 bytes.
837
b7163a50
PE
838 * xfns.c (x_window): Make sprintf buffer a bit bigger
839 to avoid potential buffer overrun.
840
ae58ff1f
PE
841 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
842
c43c8a6a
PE
843 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
844
3f8236f4
PE
8452011-09-04 Paul Eggert <eggert@cs.ucla.edu>
846
53e9fe90 847 Integer overflow fixes for scrolling, etc.
6511acf2
PE
848 Without these, Emacs silently mishandles large integers sometimes.
849 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
850 it were "C-u 1 M-x recenter" on a typical 64-bit host.
851
6511acf2
PE
852 * xdisp.c (try_window_id): Check Emacs fixnum range before
853 converting to 'int'.
806add1d 854
6511acf2 855 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
856 Check that an Emacs fixnum is in range before assigning it to 'int'.
857 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
858 values converted from Emacs fixnums.
859 (Frecenter): Don't wrap around a line count if it is out of 'int'
860 range; instead, treat it as an extreme value.
861 (Fset_window_configuration, compare_window_configurations):
862 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
863
6511acf2
PE
864 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
865 that can exceed INT_MAX. Check that EMACS_INT value is in range
866 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
867 (match_limit): Don't assume that a fixnum can fit in 'int'.
868
6511acf2 869 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
870 exceed INT_MAX.
871
6511acf2 872 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
873 (Fvertical_motion): Don't wrap around LINES values that don't fit
874 in 'int'. Instead, treat them as extreme values. This is good
875 enough for windows, which can't have more than INT_MAX lines anyway.
876
fcb901a7
LMI
8772011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
878
0f2f6b6d
LMI
879 * Require libxml/parser.h to avoid compilation warning.
880
fcb901a7
LMI
881 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
882
883 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
884 since this reportedly can destroy thread storage.
885
6e20a0d4
CY
8862011-08-30 Chong Yidong <cyd@stupidchicken.com>
887
888 * syntax.c (find_defun_start): Update all cache variables if
889 exiting early (Bug#9401).
890
148ae00e
EZ
8912011-08-30 Eli Zaretskii <eliz@gnu.org>
892
f6cfbd8f
EZ
893 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
894
148ae00e
EZ
895 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
896 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
897 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
898
899 * term.c (tty_append_glyph): New function.
900 (produce_stretch_glyph): Static function and its prototype deleted.
901
a66cfb1c
SM
902 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
903 Add prototypes.
148ae00e 904
c4a07a4c
PE
9052011-08-29 Paul Eggert <eggert@cs.ucla.edu>
906
907 * image.c (parse_image_spec): Check for nonnegative, not for positive,
908 when checking :margin (Bug#9390).
909 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 910 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
911 so that the name doesn't mislead. All uses changed.
912
6bc8cd65
JB
9132011-08-28 Johan Bockgård <bojohan@gnu.org>
914
915 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
916 set_tty_hooks.
917
dca4927e
EZ
9182011-08-27 Eli Zaretskii <eliz@gnu.org>
919
920 * xdisp.c (move_it_to): Don't bail out early when reaching
921 position beyond to_charpos, if we are scanning backwards.
922 (move_it_vertically_backward): When DY == 0, make sure we get to
923 the first character in the line after the newline.
924
f2cad773
PE
9252011-08-27 Paul Eggert <eggert@cs.ucla.edu>
926
927 * ccl.c: Improve and simplify overflow checking (Bug#9196).
928 (ccl_driver): Do not generate an out-of-range pointer.
929 (Fccl_execute_on_string): Remove unnecessary check for
930 integer overflow, noted by Stefan Monnier in
931 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
932 Remove a FIXME that didn't need fixing.
933 Simplify the newly-introduced buffer reallocation code.
934
0cae2cdb
JB
9352011-08-27 Juanma Barranquero <lekktu@gmail.com>
936
937 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
938
5fc295a4 9392011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 940
70c60eb2 941 Integer and memory overflow issues (Bug#9196).
726e0ab1 942
d31850da
PE
943 * doc.c (get_doc_string): Rework so that
944 get_doc_string_buffer_size is the actual buffer size, rather than
945 being 1 less than the actual buffer size; this makes xpalloc more
946 convenient.
947
a69fbedb
PE
948 * image.c (x_allocate_bitmap_record, cache_image):
949 * xselect.c (Fx_register_dnd_atom):
950 Simplify previous changes by using xpalloc.
951
fe5c5d37
PE
952 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
953 since either will do and ptrdiff_t is convenient with xpalloc.
954
0065d054
PE
955 * charset.c (charset_table_size)
956 (struct charset_sort_data.priority): Now ptrdiff_t.
957 (charset_compare): Don't overflow if priorities differ greatly.
958 (Fsort_charsets): Don't assume list length fits in int.
959 Check for size-calculation overflow when allocating sort data.
960 (syms_of_charset): Allocate an initial charset table that is
961 just under 64 KiB, to avoid problems with glibc malloc and mmap.
962
963 * cmds.c (internal_self_insert): Check for size-calculation overflow.
964
965 * composite.h (struct composition.glyph_len): Now int, not unsigned.
966 The actual value is always <= INT_MAX, and leaving it unsigned made
967 overflow checking harder.
968
969 * dispextern.h (struct glyph_matrix.rows_allocated)
970 (struct face_cache.size): Now ptrdiff_t, for convenience in use
971 with xpalloc. The values are still always <= INT_MAX.
972
973 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
974
975 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
976 (SAFE_NALLOCA): New macro.
977
978 * region-cache.c (struct boundary.pos, find_cache_boundary)
979 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
980 (set_cache_region, invalidate_region_cache)
981 (revalidate_region_cache, know_region_cache, region_cache_forward)
982 (region_cache_backward, pp_cache):
983 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
984 so that ptrdiff_t * can be passed to xpalloc.
985 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
986 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
987 (pp_cache): Don't assume cache_len fits in int.
988 * region-cache.h: Adjust extern decls to match.
989
990 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
991 EMACS_INT, since either will do, for xpalloc.
992
993 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
994 (xnmalloc, xnrealloc, xpalloc): New functions.
995
726e0ab1
PE
996 * bidi.c (bidi_shelve_header_size): New constant.
997 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
998 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
999
51f30bc5 1000 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1001 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1002 (overlay_strings):
1003 Don't update size of array until after memory allocation succeeds,
1004 because xmalloc/xrealloc may not return.
0065d054
PE
1005 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1006 now that we have proper integer overflow checking.
1007 (record_overlay_string, overlay_strings): Catch overflows when
1008 calculating size of overlay_str_buf.
726e0ab1 1009
0065d054
PE
1010 * callproc.c (Fcall_process): Check for size overflow when
1011 calculating size of args2.
1012 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1013 Normally we prefer signed values, but sticking with ptrdiff_t would
1014 require adding more-complicated checks.
726e0ab1
PE
1015
1016 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1017 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1018 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1019 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1020
1021 * character.c (Fstring): Check for size-calculation overflow.
1022
1023 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1024 unnecessary integer overflow. Check for size overflow.
1025 (encode_coding_object): Don't update size until xmalloc succeeds.
1026
1027 * composite.c (get_composition_id): Check for overflow in glyph
1028 length calculations.
1029
1030 Integer and memory overflow fixes for display code.
1031 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1032 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1033 (scrolling_window): Check for overflow in size calculations.
1034 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1035 Don't assume glyph table len fits in int.
1036 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1037 (row_table_size): Now ptrdiff_t, not int.
1038 (scrolling_window): Avoid overflow in size calculations.
1039 Don't update size until allocation succeeds.
1040 * fns.c (concat): Check for overflow in size calculations.
1041 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1042 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1043 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1044
1045 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1046 (get_doc_string): Check for size calculation overflow.
1047 Don't update size until allocation succeeds.
1048 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1049 EMACS_INT, where ptrdiff_t will do.
1050 (Fsubstitute_command_keys): Check for string overflow.
1051
1052 * editfns.c (set_time_zone_rule): Don't assume environment length
1053 fits in int.
1054 (message_length): Now ptrdiff_t, not int.
1055 (Fmessage_box): Don't update size until allocation succeeds.
1056 Don't assume message length fits in int.
1057 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1058
0065d054
PE
1059 * emacs.c (main): Do not reallocate argv, since there is a null at
1060 the end that can be overwritten, and this way there's no need to
1061 worry about size-calculation overflow.
1062 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1063
1064 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1065 alloc succeeds.
1066 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1067
1068 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1069 (x_set_scroll_bar_width, x_figure_window_size):
1070 Check for integer overflow.
1071 (x_set_alpha): Do not assume XINT fits in int.
1072
1073 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1074 This is for the members text_lines, text_cols, total_lines, total_cols,
1075 where the system imposes an 'int' limit.
1076
1077 * fringe.c (Fdefine_fringe_bitmap):
1078 Don't update size until alloc works.
1079
1080 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1081 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1082
1083 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1084 Check for size-calculation overflow.
1085 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1086 do, as we prefer signed integers.
1087 (id_to_widget.max_size, id_to_widget.used)
1088 (xg_store_widget_in_map, xg_remove_widget_from_map)
1089 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1090 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1091 Use and return ptrdiff_t, not int.
1092 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1093 * gtkutil.h: Change prototypes to match the above.
1094
1095 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1096 are duplicate now that they've been promoted to lisp.h.
1097 (x_allocate_bitmap_record, x_alloc_image_color)
1098 (make_image_cache, cache_image, xpm_load):
1099 Don't update size until alloc is done.
1100 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1101 (x_detect_edges):
3256efce 1102 Check for size calculation overflow.
726e0ab1
PE
1103 (ct_colors_allocated_max): New constant.
1104 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1105 overflow.
3256efce 1106
726e0ab1
PE
1107 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1108 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1109 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1110 Use ptrdiff_t, not int, to count maps.
1111 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1112 calculations. Don't update size until allocation succeeds.
1113 Redo calculations to avoid overflow.
726e0ab1
PE
1114 * keyboard.h: Change prototypes to match the above.
1115
1116 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1117 to count maps.
1118 (current_minor_maps): Check for size calculation overflow.
1119 * keymap.h: Change prototypes to match the above.
1120
1121 * lread.c (read1, init_obarray): Don't update size until alloc done.
1122
1123 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1124 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1125
726e0ab1
PE
1126 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1127 Now ptrdiff_t, not int.
1128 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1129 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1130
1131 * process.c (Fnetwork_interface_list): Check for overflow
1132 in size calculation.
1133
1134 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1135
1136 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1137 overflow. Don't bother calling xmalloc when xrealloc will do.
1138
1139 * search.c (Freplace_match): Check for size calculation overflow.
1140 (Fset_match_data): Don't assume list lengths fit in 'int'.
1141
1142 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1143 for command line length. Do not attempt to address one before the
1144 beginning of an array, as that's not portable.
1145
1146 * term.c (max_frame_lines): Remove; unused.
1147 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1148 not int.
1149 (encode_terminal_code, calculate_costs): Check for size
1150 calculation overflow.
1151 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1152 table lengths and related sizes. Don't update size until alloc
1153 done. Redo calculations to avoid overflow.
1154 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1155
1156 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1157 subtracting pointers.
1158 (gobble_line): Check for overflow more carefully. Don't update size
1159 until alloc done.
1160
1161 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1162 Don't update size until alloc done.
1163 Redo size calculations to avoid overflow.
1164 Check for size calculation overflow.
0065d054 1165 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1166
1167 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1168 Use ptrdiff_t, not int, for sizes.
1169 (store_mode_line_noprop_char): Don't update size until alloc done.
1170
0065d054
PE
1171 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1172 Use ptrdiff_t, not int, for sizes.
1173 (Finternal_make_lisp_face, cache_face):
1174 Check for size calculation overflow.
1175 (cache_face): Treat size calculation overflows as if they were
1176 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1177
1178 * xfns.c (x_encode_text, x_set_name_internal)
1179 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1180 sizes, since they can exceed INT_MAX in size. Check for size
1181 calculation overflow.
1182
0065d054
PE
1183 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1184 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1185 Don't update size until alloc done.
1186
0065d054 1187 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1188 as sprintf is limited to int lengths.
1d526e2f 1189
252c5ee1
PE
1190 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1191 (X_LONG_MIN): New macros.
864d7ce7
PE
1192 Use them to make the following changes clearer.
1193 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1194 This change doesn't affect the value now, but it may help remind
1195 future maintainers not to raise the value too much later.
1196 (SELECTION_QUANTUM): Remove, replacing with ...
1197 (selection_quantum): ... new function, which avoids overflow.
1198 All uses changed.
1199 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1200 assumption that selection length fits in 'int'.
1201 (x_reply_selection_request, x_handle_selection_request)
1202 (x_get_window_property, receive_incremental_selection)
1203 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1204 (lisp_data_to_selection_data, clean_local_selection_data):
1205 Use ptrdiff_t, not int, to record length of selection.
1206 (x_reply_selection_request, x_get_window_property)
1207 (receive_incremental_selection, x_property_data_to_lisp):
1208 Redo calculations to avoid overflow.
1209 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1210 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1211 something.
1212 (x_get_window_property, receive_incremental_selection)
1213 (lisp_data_to_selection_data, x_property_data_to_lisp):
1214 Check for size-calculation overflow.
1215 (x_get_window_property, receive_incremental_selection)
1216 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1217 Don't store size until memory allocation succeeds.
1218 (x_get_window_property): Plug memory leak on memory exhaustion.
1219 Don't double-block input; malloc is safe here. Don't assume 2**34
1220 - 4 fits in unsigned long. Add an xassert to check
1221 XGetWindowProperty overflow. Be more careful about overflow
1222 calculations, and distinguish size from memory overflow better.
1223 (receive_incremental_selection): When tracing, don't assume
1224 unsigned int is less than INT_MAX.
1225 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1226 harmful) conversions of unsigned short to int.
1227 (lisp_data_to_selection_data): Don't assume that integers
1228 in the range -65535 through -1 fit in an X unsigned short.
1229 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1230 result parameters unless successful. Rely on cons_to_unsigned
1231 to report problems with elements; the old code wasn't right anyway.
1232 (x_check_property_data): Check for int overflow; we cannot use
1233 a wider type due to X limits.
1234 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1235
726e0ab1 1236 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1237
0065d054
PE
1238 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1239 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1240 (x_color_cells): Don't store size until memory allocation succeeds.
1241 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1242 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1243 (x_term_init): Don't assume length fits in int (sprintf is limited
1244 to int size).
bc18e09d 1245
ebfa62c0
PE
1246 Use ptrdiff_t for composition IDs.
1247 * character.c (lisp_string_width):
1248 * composite.c (composition_table_size, n_compositions)
1249 (get_composition_id, composition_gstring_from_id):
1250 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1251 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1252 * window.c (Frecenter):
1253 Use ptrdiff_t, not int, for composition IDs.
1254 * composite.c (get_composition_id): Check for integer overflow.
1255 * composite.h: Adjust prototypes to match the above changes.
1256
d3411f89
PE
1257 Use ptrdiff_t for hash table indexes.
1258 * category.c (hash_get_category_set):
1259 * ccl.c (ccl_driver):
1260 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1261 * coding.c (coding_system_charset_list, detect_coding_system):
1262 * coding.h (struct coding_system.id):
1263 * composite.c (get_composition_id, gstring_lookup_cache):
1264 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1265 * image.c (xpm_get_color_table_h):
1266 * lisp.h (hash_lookup, hash_put):
1267 * minibuf.c (Ftest_completion):
1268 Use ptrdiff_t for hash table indexes, not int (which is too
1269 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1270 32-bit --with-wide-int hosts).
1271
e097a6fa
PE
1272 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1273 Add a FIXME comment about memory leaks.
1274 (syms_of_charset): Don't assume xmalloc returns.
1275
5637687f
PE
1276 Don't assume that stated character widths fit in int.
1277 * character.c (Fchar_width, c_string_width, lisp_string_width):
1278 * character.h (CHAR_WIDTH):
1279 * indent.c (MULTIBYTE_BYTES_WIDTH):
1280 Use sanitize_char_width to avoid undefined and/or bad behavior
1281 with outlandish widths.
a66cfb1c 1282 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1283 now that we have two such functions. All uses changed.
1284 (sanitize_char_width): New inline function.
1285
a2271ba2
PE
1286 Don't assume that tab-width fits in int.
1287 * character.h (sanitize_width): New inline function.
1288 (SANE_TAB_WIDTH): New macro.
1289 (ASCII_CHAR_WIDTH): Use it.
1290 * indent.c (sane_tab_width): Remove. All uses replaced by
1291 SANE_TAB_WIDTH (current_buffer).
1292 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1293
18c52557
PE
1294 * fileio.c: Integer overflow issues with file modes.
1295 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1296
caeeedc1
PE
1297 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1298 Remove unreachable code.
1299 (read_hex, load_charset_map_from_file): Check for integer overflow.
1300
50849c52
PE
1301 * xterm.c: don't go over XClientMessageEvent limit
1302 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1303 (x_send_scroll_bar_event): Likewise. Check that the size does not
1304 exceed limits imposed by XClientMessageEvent, as well as the usual
1305 ptrdiff_t and size_t limits.
1306
b13995db
PE
1307 * keyboard.c: Overflow, signedness and related fixes.
1308 (make_lispy_movement): Use same integer type in forward decl
1309 that is used in the definition.
1310 (read_key_sequence, keyremap_step):
1311 Change bufsize argument back to int, undoing my 2011-03-30 change.
1312 We prefer signed types, and int is wide enough here.
1313 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1314 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1315 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1316 length, not size_t. Use ptrdiff_t for index, not int.
1317 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1318 possibility of integer overflow.
1319
13464394
PE
1320 Overflow, signedness and related fixes for images.
1321
1322 * dispextern.h (struct it.stack[0].u.image.image_id)
1323 (struct_it.image_id, struct image.id, struct image_cache.size)
1324 (struct image_cache.used, struct image_cache.ref_count):
1325 * gtkutil.c (update_frame_tool_bar):
1326 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1327 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1328 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1329 * nsmenu.m (update_frame_tool_bar):
1330 * xdisp.c (calc_pixel_width_or_height):
1331 * xfns.c (image_cache_refcount):
1332 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1333 on typical 64-bit hosts.
1334
1335 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1336 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1337 Omit unnecessary casts to int.
1338 (parse_image_spec): Check that integers fall into 'int' range
1339 when the callers expect that.
1340 (image_ascent): Redo ascent calculation to avoid int overflow.
1341 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1342 (lookup_image): Remove unnecessary tests.
1343 (xbm_image_p): Locals are now of int, not EMACS_INT,
1344 since parse_image_check makes sure they fit into int.
1345 (png_load, gif_load, svg_load_image):
1346 Prefer int to unsigned where either will do.
1347 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1348 old tiff_error_handler and tiff_warning_handler.
1349 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1350 stack buffer overflows. It uses only the features of vsnprintf
1351 that are common to both POSIX and native Microsoft.
1352 (tiff_error_handler, tiff_warning_handler): Use it.
1353 (tiff_load, gif_load, imagemagick_load_image):
1354 Don't assume :index value fits in 'int'.
1355 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1356 (imagemagick_load_image): Check that crop parameters fit into
1357 the integer types that MagickCropImage accepts. Don't assume
1358 Vimagemagick_render_type has a nonnegative value. Don't assume
1359 size_t fits in 'long'.
1360 (gs_load): Use printmax_t to print the widest integers possible.
1361 Check for integer overflow when computing image height and width.
1362
c11821d4
EZ
13632011-08-26 Eli Zaretskii <eliz@gnu.org>
1364
1365 * xdisp.c (redisplay_window): Don't force window start if point
1366 will be invisible in the resulting window. (Bug#9324)
1367
0c95fcf7
EZ
13682011-08-25 Eli Zaretskii <eliz@gnu.org>
1369
1370 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1371 the display spec is of the form `(space ...)'.
1372 (handle_display_spec): Return the value returned by
1373 handle_single_display_spec, not just 1 or zero.
1374 (handle_single_display_spec): If the display spec is of the form
1375 `(space ...)', and specifies display in the text area, return 2
1376 rather than 1.
fee65a97 1377 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1378 accurately, and prefer exact match for point under bidi.
1379 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1380
1381 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1382 into disp_prop; all users changed.
1383
1384 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1385 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1386 for the text covered by the display property.
1387
e4ed06f1
CY
13882011-08-25 Chong Yidong <cyd@stupidchicken.com>
1389
1390 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1391 Change return value to nil.
1392 (Frecord_buffer): Delete unused function.
1393
f67cdd7f
EZ
13942011-08-24 Eli Zaretskii <eliz@gnu.org>
1395
5980d4c6
EZ
1396 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1397 buffers, return left-to-right.
8610fe8b
EZ
1398 (set_cursor_from_row): Consider candidate row a win if its glyph
1399 represents a newline and point is on that newline. Fixes cursor
1400 positioning on the newline at EOL of R2L text within L2R
1401 paragraph, and vice versa.
1402 (try_cursor_movement): Check continued rows, in addition to
1403 continuation rows. Fixes unwarranted scroll when point enters a
1404 continued line of R2L text within an L2R paragraph, or vice versa.
1405 (cursor_row_p): Consider the case of point being equal to
1406 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1407 from the end of a short line to the beginning of a continued line
1408 of R2L text within L2R paragraph.
1409 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1410 composed characters.
5980d4c6 1411
f67cdd7f
EZ
1412 * bidi.c (bidi_check_type): Use xassert.
1413 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1414 members.
1415
bca633fb
EZ
14162011-08-23 Eli Zaretskii <eliz@gnu.org>
1417
1418 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1419 a character.
1420
4a5885a7
CY
14212011-08-23 Chong Yidong <cyd@stupidchicken.com>
1422
1423 * nsfont.m (ns_otf_to_script): Fix typo.
1424
0902a04e
KH
14252011-08-22 Kenichi Handa <handa@m17n.org>
1426
1427 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1428 extra slot even if the purpose is char-code-property-table.
1429
1a2e6670
EZ
14302011-08-23 Eli Zaretskii <eliz@gnu.org>
1431
8ddde651
EZ
1432 * xdisp.c (redisplay_window): When computing centering_position,
1433 account for the height of the header line. (Bug#8874)
1434
425cc014
EZ
1435 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1436 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1437 candidate is selected by the mouse, and that candidate has a
1438 composed character under the mouse.
1439
1a2e6670
EZ
1440 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1441 coordinates reported by pos-visible-in-window-p for a composed
1442 character in column zero.
1443
8b76d6f8
SM
14442011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1445
1446 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1447
dac347dd
EZ
14482011-08-22 Eli Zaretskii <eliz@gnu.org>
1449
1450 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1451 consider it a hit if to_charpos is anywhere in the range of the
1452 composed buffer positions.
1453
e013fb34
CY
14542011-08-22 Chong Yidong <cyd@stupidchicken.com>
1455
1456 * image.c (gif_load): Don't assume that each subimage has the same
1457 dimensions as the base image. Handle disposal method that is
1458 "undefined" by the gif spec (Bug#9335).
1459
bd1ba3e8
CY
14602011-08-20 Chong Yidong <cyd@stupidchicken.com>
1461
1462 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1463 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1464
54a1215b
EZ
14652011-08-19 Eli Zaretskii <eliz@gnu.org>
1466
823564e5
EZ
1467 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1468 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1469 from an Org mode buffer to a Speedbar frame.
1470
54a1215b
EZ
1471 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1472 a composition, take its buffer position from IT->cmp_it.charpos.
1473 Fixes cursor positioning at the beginning of a line that begins
1474 with a composed character.
1475
9778ebcc
EZ
14762011-08-18 Eli Zaretskii <eliz@gnu.org>
1477
0be6ee06
EZ
1478 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1479 character bidirectional type, use STRONG_L instead. Fixes crashes
1480 in a buffer produced by `describe-categories'.
1481
9778ebcc
EZ
1482 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1483 members before the level stack, so they would be saved and
1484 restored when copying iterator state. Fixes incorrect reordering
1485 around TABs covered by display properties.
1486
156bffbe
AS
14872011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1488
6b02f655 1489 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1490
72ad093b
CY
14912011-08-17 Chong Yidong <cyd@stupidchicken.com>
1492
1493 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1494 (internal_condition_case_2, internal_condition_case_n):
1495 Remove unnecessary aborts (Bug#9081).
72ad093b 1496
35774242
EZ
14972011-08-17 Eli Zaretskii <eliz@gnu.org>
1498
1499 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1500 has no `load' handler, try opening the file locally. (Bug#9311)
1501
db76dd85
KB
15022011-08-16 Ken Brown <kbrown@cornell.edu>
1503
1504 * gmalloc.c: Expand comment.
1505
b215eee5
EZ
15062011-08-16 Eli Zaretskii <eliz@gnu.org>
1507
1508 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1509 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1510
a4579d33
KB
15112011-08-16 Ken Brown <kbrown@cornell.edu>
1512
1513 Fix memory allocation problems in Cygwin build (Bug#9273).
1514
1515 * unexcw.c ( __malloc_initialized): Declare external variable.
1516 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1517
8b76d6f8
SM
1518 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1519 New variables.
a4579d33
KB
1520 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1521 dumped emacs.
1522 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1523 in the static heap.
1524 [CYGWIN] (special_realloc): New function.
1525 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1526 requests to realloc storage in the static heap.
1527
3ebec551
PE
15282011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1529
1530 * bidi.c (bidi_initialize): Remove unused local.
1531
9fd8be00
EZ
15322011-08-15 Eli Zaretskii <eliz@gnu.org>
1533
6b02f655
SM
1534 * bidimirror.h:
1535 * biditype.h: Remove file.
1536 * makefile.w32-in ($(BLD)/bidi.$(O)):
1537 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1538
1539 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1540
1541 * chartab.c: Improve commentary for the uniprop_table API.
1542
32413314
EZ
1543 * bidi.c (bidi_paragraph_init): Support zero value of
1544 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1545 (bidi_initialize): Use uniprop_table instead of including
1546 biditype.h and bidimirror.h.
32413314 1547
9fd8be00
EZ
1548 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1549 coordinates of the iterator when restoring from ppos_it.
1550 (Bug#9296)
1551
5cf2b69b
KH
15522011-08-14 Kenichi Handa <handa@m17n.org>
1553
1554 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1555 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1556
daf17d00
EZ
15572011-08-14 Eli Zaretskii <eliz@gnu.org>
1558
1559 * xdisp.c (move_it_in_display_line_to): Don't invoke
1560 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1561 ppos_it. Fixes vertical cursor motion when line beginning is
1562 covered by an image. (Bug#9296)
1563
08e3161a
JD
15642011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1565
1566 * nsterm.h (ns_run_ascript): Declare.
1567 (NSAPP_DATA2_RUNASSCRIPT): Define.
1568
1569 * nsfns.m (as_script, as_result, as_status): New static variables.
1570 (ns_run_ascript): New function.
5e617bc2 1571 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1572 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1573 the event loop. Get status from as_status (Bug#7276).
1574
1575 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1576 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1577 the event loop (Bug#7276).
1578
a3720aa2
AS
15792011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1580
1581 * gnutls.c (QCgnutls_bootprop_priority)
1582 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1583 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1584 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1585 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1586 (QCgnutls_bootprop_verify_hostname_error)
1587 (QCgnutls_bootprop_callbacks_verify): Rename from
1588 Qgnutls_bootprop_..., all uses changed.
1589
1590 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1591 uses changed.
1592
0a0d27fb
PE
15932011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1594
19d5c50c
PE
1595 * xfaces.c (Qframe_set_background_mode): Now static.
1596 * dispextern.h (Qframe_set_background_mode): Remove decl.
1597
0a0d27fb
PE
1598 * process.c (Fnetwork_interface_info): Declare local only if needed.
1599
377538cb
JD
16002011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1601
1602 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1603 (Fnetwork_interface_list): Allocate in increments of bytes instead
1604 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1605 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1606 sockaddr.
1607 (struct ifflag_def): notrailers is smart on OSX.
1608 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1609 Get hardware address with getifaddrs if available.
1610
08fff70c
EZ
16112011-08-12 Eli Zaretskii <eliz@gnu.org>
1612
1613 * xdisp.c (iterate_out_of_display_property): xassert that
1614 IT->position is set to within IT->object's boundaries. Break from
1615 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1616 when IT->position is set up wrongly due to some bug.
1617 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1618 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1619 entry. Force push_it to save on the stack the current
1620 buffer/string position, to be restored by pop_it. Fix flags in
1621 the iterator structure wrt the object coming from a display
1622 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1623 properties. (Bug#9284)
1624
7be1c708 16252011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1626
7be1c708
CY
1627 * fontset.c (fontset_get_font_group): Add proper type checks.
1628 (Bug#9172)
aac0c6e3 1629
7be1c708 16302011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1631
7be1c708
CY
1632 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1633 and LC_VERSION_MIN_MACOSX.
1634 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1635 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1636
97bb72a6
EZ
16372011-08-08 Eli Zaretskii <eliz@gnu.org>
1638
1639 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1640 no-display-properties-and-no-overlays under bidi display.
1641 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1642 properties and overlays.
97bb72a6 1643
d5617611
CY
16442011-08-08 Chong Yidong <cyd@stupidchicken.com>
1645
37e11a63
CY
1646 * editfns.c (Fset_time_zone_rule): Document relationship with the
1647 setenv function.
1648
d5617611
CY
1649 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1650 the font entity extracted from the cache (Bug#8109).
1651
58872834
CY
16522011-08-07 Chong Yidong <cyd@stupidchicken.com>
1653
1654 * composite.c (autocmp_chars): Don't reset point. That is done by
1655 restore_point_unwind (Bug#5984).
1656
75bfc667
JL
16572011-08-07 Juri Linkov <juri@jurta.org>
1658
1659 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1660 to show the arg `TIME' instead of `TIMEVAL'.
1661
d1410150
EZ
16622011-08-06 Eli Zaretskii <eliz@gnu.org>
1663
1664 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1665 display property strides EOL and includes a newline, as in
1666 longlines-mode. (Bug#9254)
75b771e4
EZ
1667 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1668 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1669
1670 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1671 is non-zero, even if the data buffer is NULL. Fixes a crash in
1672 vertical-motion with longlines-mode. (Bug#9254)
1673
35928349
EZ
16742011-08-05 Eli Zaretskii <eliz@gnu.org>
1675
ec7cc85b
EZ
1676 * bidi.c <bidi_cache_total_alloc>: Now static.
1677 (bidi_initialize): Initialize bidi_cache_total_alloc.
1678
8b76d6f8 1679 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1680 cache. (Bug#9221)
1681
1682 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1683 amount allocated this far in `bidi_cache_total_alloc'.
1684 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1685 non-zero, only free the data buffer without restoring the cache
1686 contents. All callers changed.
1687
1688 * dispextern.h (bidi_unshelve_cache): Update prototype.
1689
1690 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1691 (move_it_in_display_line, move_it_to)
1692 (move_it_vertically_backward, move_it_by_lines): Replace the call
1693 to xfree to an equivalent call to bidi_unshelve_cache.
1694 (move_it_in_display_line_to): Fix logic of returning
412b6358 1695 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1696
e2e2423b
EZ
16972011-08-05 Eli Zaretskii <eliz@gnu.org>
1698
1699 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1700 came from a string character with a `cursor' property. (Bug#9229)
1701
ae9e757a
JD
17022011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1703
1704 * Makefile.in (LIB_PTHREAD): New variable.
1705 (LIBES): Add LIB_PTHREAD (Bug#9216).
1706
1707 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1708 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1709
213bd7f2
AS
17102011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1711
6b02f655 1712 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1713
99aaf75f
JD
17142011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1715
1716 * xterm.c (x_find_topmost_parent): New function.
1717 (x_set_frame_alpha): Find topmost parent window with
1718 x_find_topmost_parent and set the property there also (bug#9181).
1719 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1720
c74e9d86
PE
17212011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1722
1723 * callproc.c (Fcall_process): Avoid vfork clobbering
1724 the local vars buffer, coding_systems, current_dir.
1725
640c8776
SM
17262011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1727
1728 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1729
f26d0e4c
PE
17302011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1731
8a10d76c
PE
1732 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1733 so that it is not optimized away.
1734
f26d0e4c
PE
1735 * xdisp.c (compute_display_string_pos): Remove unused local.
1736
55439c61
EZ
17372011-08-02 Eli Zaretskii <eliz@gnu.org>
1738
1739 Fix slow cursor motion and scrolling in large buffers with
1740 selective display, like Org Mode buffers. (Bug#9218)
1741
1742 * dispextern.h (struct bidi_it): New member disp_prop_p.
1743
1744 * xdisp.c: Remove one-slot cache of display string positions.
1745 (compute_display_string_pos): Accept an additional argument
5e617bc2 1746 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1747 for a display string or property. If found, set DISP_PROP_P
1748 non-zero.
1749
1750 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1751 DISP_PROP_P, and pass it to compute_display_string_pos.
1752 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1753 non-zero. All callers of bidi_fetch_char changed.
1754
fb33fa43
SM
17552011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1756
1757 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1758
b099e063
DM
17592010-12-03 Don March <don@ohspite.net>
1760
1761 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1762 last character M-[char] is translated to ESC [char] (bug#7541).
1763
5cc7f7af
KH
17642011-08-02 Kenichi Handa <handa@m17n.org>
1765
d0fffa3f 1766 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1767
1768 * chartab.c (uniprop_table): Make it non-static.
1769
525d5e6e
EZ
17702011-08-01 Eli Zaretskii <eliz@gnu.org>
1771
1772 * xdisp.c (forward_to_next_line_start): Accept additional argument
1773 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1774 on the newline.
1775 (reseat_at_next_visible_line_start): Use the bidi iterator state
1776 returned by forward_to_next_line_start to restore the state of
1777 it->bidi_it after backing up to previous newline. (Bug#9212)
1778
31011111
AS
17792011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1780
1781 * regex.c (re_comp): Protoize.
1782 (re_exec): Fix return type.
1783 (regexec): Fix type of `ret'. (Bug#9203)
1784
476371c4
PE
17852011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1786
e5d76069
PE
1787 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1788 This is needed if max-image-size is a floating-point number.
1789
9a79b20c
AS
17902011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1791
1792 * print.c (print_object): Print empty symbol as ##.
1793
1794 * lread.c (read1): Read ## as empty symbol.
1795
d8c2fa78
AA
17962011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1797
1798 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1799 setting frame foreground color (Bug#9175).
1800 (x_set_background_color): Likewise.
1801
ffe57a7a
AA
1802 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1803 contents (Bug#9176).
1804 (EmacsTooltip -init): Remove bezels and add shadows to
1805 tooltip windows.
1806
bf3492a5
AA
1807 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1808 or scroll bar (Bug#8470).
1809
d55e9c53
AA
1810 * nsfont.m (nsfont_open): Remove assignment to voffset and
1811 unnecessary vars hshink, expand, hd, full_height, min_height.
1812 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1813
1814 * nsterm.h (nsfont_info): Remove voffset field.
1815
d8c2fa78 18162011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1817
1818 Implement strike-through and overline on NextStep (Bug#8863).
1819
1820 * nsfont.m (nsfont_open): Use underline position provided by font,
1821 instead of hard-coded value of 2.
1822 (nsfont_draw): Call ns_draw_text_decoration instead.
1823
1824 * nsterm.h: Add declaration for ns_draw_text_decoration.
1825
1826 * nsterm.m (ns_draw_text_decoration): New function for drawing
1827 underline, overline, and strike-through.
1828 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1829 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1830 accommodate underlining, etc.
4843aac3 1831
4cc60b9b
EZ
18322011-07-28 Eli Zaretskii <eliz@gnu.org>
1833
bc7ece87
EZ
1834 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1835 default.
4cc60b9b 1836
476371c4
PE
18372011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1838
66606eea
PE
1839 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1840 Without this fix, if a signal arrives just after memory fills up,
1841 'malloc' might be invoked reentrantly.
1842
476371c4
PE
1843 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1844 In other words, assume that every image size is allowed, on non-X
1845 hosts. This assumption is probably wrong, but it lets Emacs compile.
1846
f3fcc40d
AS
18472011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1848
1849 * regex.c (re_iswctype): Convert return values to boolean.
1850
350c992f
EZ
18512011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1852
1853 * xdisp.c (compute_display_string_pos): Don't use cached display
1854 string position if the buffer had its restriction changed.
1855 (Bug#9184)
1856
5266b4bb
PE
18572011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1858
1859 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1860
2573a837 18612011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1862
41f55ccd 1863 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1864
39e378da
PE
1865 * bidi.c: Integer size and overflow fixes.
1866 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1867 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1868 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1869 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1870 (bidi_find_other_level_edge):
1871 Use ptrdiff_t instead of EMACS_INT where either will do.
1872 This works better on 32-bit hosts configured --with-wide-int.
1873 (bidi_cache_ensure_space): Check for size-calculation overflow.
1874 Use % rather than repeated addition, for better worst-case speed.
1875 Don't set bidi_cache_size until after xrealloc returns, because it
1876 might not return.
1877 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1878 (bidi_cache_ensure_space): Also check that the bidi cache size
1879 does not exceed that of the largest Lisp string or buffer. See Eli
1880 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1881
5e927815
PE
1882 * alloc.c (__malloc_size_t): Remove.
1883 All uses replaced by size_t. See Andreas Schwab's note
1884 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1885
ca4aa935
PE
1886 * image.c: Improve checking for integer overflow.
1887 (check_image_size): Assume that f is nonnull, since
1888 it is always nonnull in practice. This is one less thing to
1889 worry about when checking for integer overflow later.
1890 (x_check_image_size): New function, which checks for integer
1891 overflow issues inside X.
1892 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1893 This removes the need for a memory_full check.
1894 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1895 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1896 (xbm_read_bitmap_data): Change locals back to 'int', since
1897 their values must fit in 'int'.
1898 (xpm_load_image, png_load, tiff_load):
1899 Invoke x_create_x_image_and_pixmap earlier,
1900 to avoid much needless work if the image is too large.
1901 (tiff_load): Treat overly large images as if
1902 x_create_x_image_and_pixmap failed, not as malloc failures.
1903 (gs_load): Use x_check_image_size.
1904
5f8f9cc2
PE
1905 * gtkutil.c: Omit integer casts.
1906 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1907 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1908
5adf60bc
PE
1909 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1910
c8907a93
PE
1911 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1912 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1913 would wrongly return t on a 64-bit host.
1914
e3c25c68
PE
1915 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1916 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1917 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1918 and therefore cause GCC to emit a bogus diagnostic in some cases.
1919
3f791afe
PE
1920 * image.c: Integer signedness and overflow and related fixes.
1921 This is not an exhaustive set of fixes, but it's time to
1922 record what I've got.
1923 (lookup_pixel_color, check_image_size): Remove redundant decls.
1924 (check_image_size): Don't assume that arbitrary EMACS_INT values
1925 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1926 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1927 (tiff_load, imagemagick_load_image):
1928 Check for overflow in size calculations.
1929 (x_create_x_image_and_pixmap): Remove unnecessary test for
1930 xmalloc returning NULL; that can't happen.
1931 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1932 (xpm_color_bucket): Use better integer hashing function.
1933 (xpm_cache_color): Don't possibly over-allocate memory.
1934 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1935 (gif_memory_source):
1936 Use ptrdiff_t, not int or size_t, to record sizes.
1937 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1938 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1939 either works, as we prefer signed integers.
1940 (tiff_read_from_memory, tiff_write_from_memory):
1941 Return tsize_t, not size_t, since that's what the TIFF API wants.
1942 (tiff_read_from_memory): Don't fail simply because the read would
1943 go past EOF; instead, return a short read.
1944 (tiff_load): Omit no-longer-needed casts.
1945 (Fimagemagick_types): Don't assume size fits into 'int'.
1946
3cc5a532
PE
1947 Improve hashing quality when configured --with-wide-int.
1948 * fns.c (hash_string): New function, taken from sxhash_string.
1949 Do not discard information about ASCII character case; this
1950 discarding is no longer needed.
1951 (sxhash-string): Use it. Change sig to match it. Caller changed.
1952 * lisp.h: Declare it.
1953 * lread.c (hash_string): Remove, since we now use fns.c's version.
1954 The fns.c version returns a wider integer if --with-wide-int is
1955 specified, so this should help the quality of the hashing a bit.
1956
b312a492
PE
1957 * emacs.c: Integer overflow minor fix.
1958 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1959 Define only if GNU_LINUX.
1960 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1961
dfd153ae
PE
1962 * dispnew.c: Integer signedness and overflow fixes.
1963 Remove unnecessary forward decls, that were a maintenance hassle.
1964 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1965 All uses changed.
1966 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1967 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1968 (prepare_desired_row, line_draw_cost):
1969 Use int, not unsigned, where either works.
1970 (save_current_matrix, restore_current_matrix):
1971 Use ptrdiff_t, not size_t, where either works.
1972 (init_display): Check for overflow more accurately, and without
1973 relying on undefined behavior.
1974
a81d11a3
PE
1975 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1976 Remove, replacing with the new symbols in lisp.h. All uses changed.
1977 * fileio.c (make_temp_name):
1978 * filelock.c (lock_file_1, lock_file):
1979 * xdisp.c (message_dolog):
1980 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1981 Use pMd etc. instead.
1982 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1983 replacing the pWIDE etc. symbols removed from editfns.c.
1984
3300e6fd
PE
1985 * keyboard.h (num_input_events): Now uintmax_t.
1986 This is (very slightly) less likely to mess up due to wraparound.
1987 All uses changed.
1988
fd05c7e9
PE
1989 * buffer.c: Integer signedness fixes.
1990 (alloc_buffer_text, enlarge_buffer_text):
1991 Use ptrdiff_t rather than size_t when either will do, as we prefer
1992 signed integers.
1993
903fe15d
PE
1994 * alloc.c: Integer signedness and overflow fixes.
1995 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1996 (__malloc_size_t): Default to size_t, not to int.
1997 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1998 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1999 Prefer ptrdiff_t to size_t when either would do, as we prefer
2000 signed integers.
2001 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2002 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2003 Now const. Initialize with values that are in range even if char
2004 is signed.
2005 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2006 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2007 These functions do the right thing with sizes > 2**32.
2008 (check_depth): Now ptrdiff_t, not int.
2009 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2010 Adjust to new way of storing sizes. Check for size overflow bugs
2011 in rest of code.
2012 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2013 slightly wrong anyway, as it missed one instance of
2014 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2015 (refill_memory_reserve): Omit needless cast to size_t.
2016 (mark_object_loop_halt): Mark as externally visible.
2017
ac82cc6a
PE
2018 * xselect.c: Integer signedness and overflow fixes.
2019 (Fx_register_dnd_atom, x_handle_dnd_message):
2020 Use ptrdiff_t, not size_t, since we prefer signed.
2021 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2022 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2023 x_dnd_atoms_size and x_dnd_atoms_length.
2024
c2d1e36d
PE
2025 * doprnt.c: Prefer signed to unsigned when either works.
2026 * eval.c (verror):
2027 * doprnt.c (doprnt):
2028 * lisp.h (doprnt):
2029 * xdisp.c (vmessage):
2030 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2031 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2032 prefer signed arithmetic to avoid comparison confusion.
2033 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2034 but is a bit tricky.
2035
0e926e56
PE
2036 Assume freestanding C89 headers, string.h, stdlib.h.
2037 * data.c, doprnt.c, floatfns.c, print.c:
2038 Include float.h unconditionally.
2039 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2040 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2041 * regex.c: Likewise for stddef.h, string.h.
2042 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2043 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2044 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2045 (STDC_HEADERS): Remove obsolete defines.
2046 * sysdep.c: Include limits.h unconditionally.
2047
9cfdb3ec
PE
2048 Assume support for memcmp, memcpy, memmove, memset.
2049 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2050 * regex.c (memcmp, memcpy):
2051 Remove; we assume C89 now.
2052
2053 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2054 (__malloc_safe_bcopy): Remove; no longer needed.
2055
cf950e6b 2056 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2057 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2058 well either way, and we prefer signed to unsigned.
2059
dbf38e02
LMI
20602011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2061
2062 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2063 closes the connection while we're reading (bug#9182).
2064
d6f0886c 20652011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2066
d6f0886c
JD
2067 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2068 are specified (Bug#9168).
24e0f6b1 2069
2eb1f9e6
PE
20702011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2071
2072 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2073 Found by GCC static checking and --with-wide-int on a 32-bit host.
2074
22381272 20752011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2076
2077 * xdisp.c (compute_display_string_pos): Fix logic of caching
2078 previous display string position. Initialize cached_prev_pos to
2079 -1. Fixes slow-down at the beginning of a buffer.
2080
f25e39b4
EZ
20812011-07-24 Eli Zaretskii <eliz@gnu.org>
2082
2083 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2084 for attrs[LFACE_FONTSET_INDEX].
2085
04c4b52e
PE
20862011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2087
2088 * xml.c (parse_region): Remove unused local
2089 that was recently introduced.
2090
c1734fbd
EZ
20912011-07-23 Eli Zaretskii <eliz@gnu.org>
2092
be18c5a5
EZ
2093 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2094 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2095
c1734fbd
EZ
2096 * xdisp.c (move_it_in_display_line_to): Record the best matching
2097 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2098 exit if none of the characters scanned was an exact match.
2099 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2100 when exact match is impossible due to invisible text, and the
2101 lines are truncated.
2102
a258d627
JD
21032011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2104
2105 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2106 for OSX >= 10.7.
2107
b6d5a689
EZ
21082011-07-22 Eli Zaretskii <eliz@gnu.org>
2109
0f74f785
EZ
2110 Fix a significant slow-down of cursor motion with C-n, C-p,
2111 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2112 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2113 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2114 (next_element_from_buffer): Call compute_stop_pos_backwards to
2115 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2116 base_level_stop.
2117 (reseat): Don't look for prev_stop, as that could mean a very long
2118 run.
2119 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2120 <cached_disp_overlay_modiff>: Cache for last found display string
2121 position.
551918c1 2122 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2123 about the same buffer in the same area of character positions, and
2124 the buffer wasn't changed since the time the display string
2125 position was cached.
551918c1 2126
b2d0c91a
EZ
21272011-07-22 Eli Zaretskii <eliz@gnu.org>
2128
2129 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2130 is an integer, which is important for empty lines. (Bug#9149)
2131
043604ee
CY
21322011-07-22 Chong Yidong <cyd@stupidchicken.com>
2133
2134 * frame.c (Fmodify_frame_parameters): In tty case, update the
2135 default face if necessary (Bug#4238).
2136
da4adb04
CY
21372011-07-21 Chong Yidong <cyd@stupidchicken.com>
2138
2139 * editfns.c (Fstring_to_char): No need to explain what a character
2140 is in the docstring (Bug#6576).
2141
9abd0532
LMI
21422011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2143
2144 * xml.c (parse_region): Make sure we always return a tree.
2145
36881d16
HK
21462011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2147
2148 * xml.c (parse_region): If a document contains only comments,
2149 return that, too.
2150
1e98674d
LMI
21512011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2152
2153 * xml.c (make_dom): Return comments, too.
2154
590bd467
PE
21552011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2156
2157 Port to OpenBSD.
2158 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2159 and the surrounding thread.
2160 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2161 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2162 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2163 timer goes off.
2164 * s/openbsd.h (BROKEN_SIGIO): Define.
2165 * unexelf.c (unexec) [__OpenBSD__]:
2166 Don't update the .mdebug section of the Alpha COFF symbol table.
2167
f41628b2
LMI
21682011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2169
2170 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2171 (bug#8460).
2172
b59b67c5
PE
21732011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2174
15e3a074
PE
2175 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2176 This fixes some race conditions on the permissions of any newly
2177 created file.
2178
41bed37d
PE
2179 * alloc.c (valid_pointer_p): Use pipe, not open.
2180 This fixes some permissions issues when debugging.
2181
b59b67c5
PE
2182 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2183 If fchown fails to set both uid and gid, try to set just gid,
2184 as that is sometimes allowed. Adjust the file's mode to eliminate
2185 setuid or setgid bits that are inappropriate if fchown fails.
2186
925a6be7
SM
21872011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2188
2189 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2190 to compare Lisp_Objects.
2191 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2192 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2193 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2194
52968808
AS
21952011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2196
0a6a104b
AS
2197 * lread.c (read_integer): Unread even EOF character.
2198 (read1): Likewise. Properly record start position of symbol.
2199
52968808
AS
2200 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2201 symbol character follows.
2202
9e381cdd
PE
22032011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2204
2205 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2206 This works around a problem with the previous change to Fcopy_file.
2207 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2208 and without this change, GCC might complain about discarding
2209 fchown's return value.
2210
b5641435
JB
22112011-07-16 Juanma Barranquero <lekktu@gmail.com>
2212
2213 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2214
a8031457
PE
22152011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2216
2217 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2218
dd889327
LMI
22192011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2220
750c33f7
LMI
2221 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2222 it's used from the C level.
2223
dd889327
LMI
2224 * process.c: Use the same condition for POLL_FOR_INPUT in both
2225 keyboard.c and process.c (bug#1858).
2226
87e86684
LM
22272011-07-09 Lawrence Mitchell <wence@gmx.li>
2228
2229 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2230 (Fgnutls_boot): Use it.
2231
64348f40
AS
22322011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2233
2234 * doc.c (Fsubstitute_command_keys): Revert last change.
2235
1d698799
LMI
22362011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2237
f863868c
LMI
2238 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2239 quotes the next character, and doesn't affect other longer
2240 sequences (bug#8935).
2241
1d698799
LMI
2242 * lread.c (syms_of_lread): Clarify that is isn't only
2243 `eval-buffer' and `eval-defun' that's affected by
2244 `lexical-binding' (bug#8460).
2245
aa4b6df6
EZ
22462011-07-15 Eli Zaretskii <eliz@gnu.org>
2247
2248 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2249 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2250
5d856da6
PE
22512011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2252
ad6042bb
PE
2253 Fix minor problems found by static checking.
2254 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2255 (elsz): Now a signed constant, not a size_t var. We prefer signed
2256 types to unsigned, to avoid integer comparison confusion. Without
2257 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2258 "cannot optimize loop, the loop counter may overflow", a symptom
2259 of the confusion.
f00bbb22 2260 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2261 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2262
6468f31c
LMI
22632011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2264
49080b10
LMI
2265 * search.c (Fre_search_backward): Mention `case-fold-search' in
2266 all the re_search_* functions (bug#8138).
2267
6468f31c
LMI
2268 * keyboard.c (Fopen_dribble_file): Document when the file is
2269 closed (bug#8056).
2270
c965adc5
EZ
22712011-07-14 Eli Zaretskii <eliz@gnu.org>
2272
df9733bf
EZ
2273 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2274 bidi_cache_idx.
2275
0bb23927
EZ
2276 Support bidi reordering of display and overlay strings.
2277 * xdisp.c (compute_display_string_pos)
2278 (compute_display_string_end): Accept additional argument STRING.
2279 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2280 (reseat_to_string): Initialize bidi_it->string.s and
2281 bidi_it->string.schars.
2282 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2283 NULL (avoids a crash in bidi_paragraph_init).
2284 Initialize itb.string.lstring.
0bb23927
EZ
2285 (init_iterator): Call bidi_init_it only of a valid
2286 buffer position was specified. Initialize paragraph_embedding to
2287 L2R.
2288 (reseat_to_string): Initialize the bidi iterator.
2289 (display_string): If we need to ignore text properties of
2290 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2291 original value of -1 will not work with bidi.)
2292 (compute_display_string_pos): First arg is now struct
2293 `text_pos *'; all callers changed. Support display properties on
2294 Lisp strings.
2295 (compute_display_string_end): Support display properties on Lisp
2296 strings.
2297 (init_iterator, reseat_1, reseat_to_string): Initialize the
2298 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2299 when iterating on a string not from display properties).
640c8776
SM
2300 (compute_display_string_pos, compute_display_string_end):
2301 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2302 arrow keys.
2303 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2304 base_level_stop; instead, set base_level_stop to BEGV.
2305 Fixes crashes in vertical-motion.
0bb23927
EZ
2306 (next_element_from_buffer): Improve commentary for when
2307 the iterator is before prev_stop.
2308 (init_iterator): Initialize bidi_p from the default value of
2309 bidi-display-reordering, not from buffer-local value. Use the
2310 buffer-local value only if initializing for buffer iteration.
2311 (handle_invisible_prop): Support invisible properties on strings
2312 that are being bidi-reordered.
2313 (set_iterator_to_next): Support bidi reordering of C strings and
2314 Lisp strings.
2315 (next_element_from_string): Support bidi reordering of Lisp
2316 strings.
2317 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2318 (display_string): Support display of R2L glyph rows.
2319 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2320 (init_iterator): Don't initialize it->bidi_p for strings
2321 here.
2322 (reseat_to_string): Initialize it->bidi_p for strings here.
2323 (next_element_from_string, next_element_from_c_string)
2324 (next_element_from_buffer): Add xassert's for correspondence
2325 between IT's object being iterated and it->bidi_it.string
2326 structure.
2327 (face_before_or_after_it_pos): Support bidi iteration.
2328 (next_element_from_c_string): Handle the case of the first string
2329 character that is not the first one in the visual order.
2330 (get_visually_first_element): New function, refactored from common
2331 parts of next_element_from_buffer, next_element_from_string, and
2332 next_element_from_c_string.
2333 (tool_bar_lines_needed, redisplay_tool_bar)
2334 (display_menu_bar): Force left-to-right direction. Add a FIXME
2335 comment for making that be controlled by a user option.
2336 (push_it, pop_it): Save and restore the state of the
2337 bidi iterator. Save and restore the bidi_p flag.
2338 (pop_it): Iterate out of display property for string iteration as
2339 well.
2340 (iterate_out_of_display_property): Support iteration over strings.
2341 (handle_single_display_spec): Set up it->bidi_it for iteration
2342 over a display string, and call bidi_init_it.
2343 (handle_single_display_spec, next_overlay_string)
2344 (get_overlay_strings_1, push_display_prop): Set up the bidi
2345 iterator for displaying display or overlay strings.
2346 (forward_to_next_line_start): Don't use the shortcut if
2347 bidi-iterating.
2348 (back_to_previous_visible_line_start): If handle_display_prop
2349 pushed the iterator stack, restore the internal state of the bidi
2350 iterator by calling bidi_pop_it same number of times.
2351 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2352 and we are bidi-iterating, don't decrement the iterator position;
2353 instead, set the first_elt flag in the bidi iterator, to produce
2354 the same effect.
2355 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2356 (push_display_prop): xassert that we are iterating a buffer.
2357 (push_it, pop_it): Save and restore paragraph_embedding member.
2358 (handle_single_display_spec, next_overlay_string)
2359 (get_overlay_strings_1, reseat_1, reseat_to_string)
2360 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2361 correctly. Don't assume unibyte strings are not bidi-reordered.
2362 (compute_display_string_pos)
2363 (compute_display_string_end): Fix handling the case of C string.
2364 (push_it, pop_it): Save and restore from_disp_prop_p.
2365 (handle_single_display_spec, push_display_prop): Set the
2366 from_disp_prop_p flag.
2367 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2368 (pop_it): Call iterate_out_of_display_property only if we are
2369 popping after iteration over a string that came from a display
2370 property. Fix a typo in popping stretch info. Add an assertion
2371 for verifying that the iterator position is in sync with the bidi
2372 iterator.
2373 (handle_single_display_spec, get_overlay_strings_1)
2374 (push_display_prop): Fix initialization of paragraph direction for
2375 string when that of the parent object is not yet determined.
2376 (reseat_1): Call bidi_init_it to resync the bidi
2377 iterator with IT's position. (Bug#7616)
2378 (find_row_edges): If ROW->start.pos gives position
2379 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2380 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2381 Reset the from_disp_prop_p flag.
2382 (SAVE_IT, RESTORE_IT): New macros.
2383 (pos_visible_p, face_before_or_after_it_pos)
2384 (back_to_previous_visible_line_start)
2385 (move_it_in_display_line_to, move_it_in_display_line)
2386 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2387 (try_scrolling, redisplay_window, display_line): Use them when
2388 saving a temporary copy of the iterator and restoring it back.
2389 (back_to_previous_visible_line_start, reseat_1)
2390 (init_iterator): Empty the bidi cache "stack".
2391 (move_it_in_display_line_to): If iterator ended up at
2392 EOL, but we never saw any buffer positions smaller than
2393 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2394 motion in bidi-reordered lines.
2395 (move_it_in_display_line_to): Record prev_method and prev_pos
2396 immediately before the call to set_iterator_to_next. Fixes cursor
2397 motion in bidi-reordered lines with stretch glyphs and strings
2398 displayed in margins. (Bug#8133) (Bug#8867)
2399 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2400 TO_CHARPOS.
640c8776
SM
2401 (pos_visible_p): Support positions in bidi-reordered lines.
2402 Save and restore bidi cache.
0bb23927
EZ
2403
2404 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2405 (bidi_paragraph_info): Delete unused struct.
2406 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2407 (bidi_cache_start): New variable.
2408 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2409 to zero.
2410 (bidi_cache_fetch_state, bidi_cache_search)
2411 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2412 (bidi_cache_find, bidi_peek_at_next_level)
2413 (bidi_level_of_next_char, bidi_find_other_level_edge)
2414 (bidi_move_to_visually_next): Compare cache index with
2415 bidi_cache_start rather than with zero.
2416 (bidi_fetch_char): Accept new argument STRING; all callers
2417 changed. Support iteration over a string. Support strings with
2418 display properties. Support unibyte strings. Fix the type of
2419 `len' according to what STRING_CHAR_AND_LENGTH expects.
2420 (bidi_paragraph_init, bidi_resolve_explicit_1)
2421 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2422 (bidi_level_of_next_char, bidi_move_to_visually_next):
2423 Support iteration over a string.
0bb23927
EZ
2424 (bidi_set_sor_type, bidi_resolve_explicit_1)
2425 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2426 can now be zero (for strings); special values 0 and -1 were
2427 changed to -1 and -2, respectively.
2428 (bidi_char_at_pos): New function.
2429 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2430 Call it instead of FETCH_MULTIBYTE_CHAR.
2431 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2432 initialized to valid values.
2433 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2434 values.
2435 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2436 the test for valid cached positions. Fix the logic for looking up
2437 the sentinel state in the cache. GCPRO the Lisp string we are
2438 iterating.
2439 (bidi_push_it, bidi_pop_it): New functions.
2440 (bidi_initialize): Initialize the bidi cache start stack pointer.
2441 (bidi_cache_ensure_space): New function, refactored from part of
2442 bidi_cache_iterator_state. Don't assume the required size is just
2443 one BIDI_CACHE_CHUNK away.
2444 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2445 (bidi_count_bytes, bidi_char_at_pos): New functions.
2446 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2447 always valid if bidi_cache_idx is valid.
2448 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2449 is valid if it's going to be used.
2450 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2451 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2452 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2453 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2454 (bidi_find_other_level_edge, bidi_cache_start_stack):
2455 All variables related to cache indices are now EMACS_INT.
c965adc5 2456
0bb23927
EZ
2457 * dispextern.h (struct bidi_string_data): New structure.
2458 (struct bidi_it): New member `string'. Make flag members be 1-bit
2459 fields, and put them last in the struct.
640c8776
SM
2460 (compute_display_string_pos, compute_display_string_end):
2461 Update prototypes.
0bb23927
EZ
2462 (bidi_push_it, bidi_pop_it): Add prototypes.
2463 (struct iterator_stack_entry): New members bidi_p,
2464 paragraph_embedding, and from_disp_prop_p.
2465 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2466 (bidi_shelve_cache, bidi_unshelve_cache):
2467 Declare prototypes.
0bb23927
EZ
2468
2469 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2470 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2471 and vector-like objects.
2472
2473 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2474 cache around display iteration.
2475
2476 * window.c (Fwindow_end, window_scroll_pixel_based)
2477 (displayed_window_lines, Frecenter): Save and restore the bidi
2478 cache around display iteration.
2479
3bbd2265
LMI
24802011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2481
2482 * editfns.c (Fdelete_region): Clarify the use of the named
2483 parameters (bug#6788).
2484
adc47434
MR
24852011-07-14 Martin Rudalics <rudalics@gmx.at>
2486
2487 * indent.c (Fvertical_motion): Set and restore w->pointm when
2488 saving and restoring the window's buffer (Bug#9006).
2489
837c31f8
LMI
24902011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2491
2492 * editfns.c (Fstring_to_char): Clarify just what is returned
2493 (bug#6576). Text by Eli Zaretskii.
2494
ac389d0c
JB
24952011-07-13 Juanma Barranquero <lekktu@gmail.com>
2496
2497 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2498
0be0ce47
EZ
24992011-07-13 Eli Zaretskii <eliz@gnu.org>
2500
2501 * buffer.c (mmap_find): Fix a typo.
2502
cd18e7e3
JB
25032011-07-13 Johan Bockgård <bojohan@gnu.org>
2504
2505 Fix execution of x selection hooks.
2506 * xselect.c (Qx_lost_selection_functions)
2507 (Qx_sent_selection_functions): New vars.
2508 (syms_of_xselect): DEFSYM them.
2509 (x_handle_selection_request): Pass Qx_sent_selection_functions
2510 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2511 (x_handle_selection_clear,x_clear_frame_selections):
2512 Pass Qx_lost_selection_functions rather than
2513 Vx_lost_selection_functions to Frun_hook_with_args.
2514
47ea7f44
PE
25152011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2516
ac389d0c 2517 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2518 The old code sometimes used this field without initializing it.
2519
47ea7f44
PE
2520 * alloc.c (gc_sweep): Don't read past end of array.
2521 In theory, the old code could also have corrupted Emacs internals,
2522 though it'd be very unlikely.
2523
bc985c87
AS
25242011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2525
2526 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2527 argument. (Bug#4026)
bc985c87 2528
0cf34688
LMI
25292011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2530
b3dadd76
LMI
2531 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2532 key" (bug#4257).
2533
0cf34688
LMI
2534 * window.c (Fset_window_start): Doc fix (bug#4199).
2535 (Fset_window_hscroll): Ditto.
2536
270768cd
PE
25372011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2538
077e3dda 2539 Fix minor new problems caught by GCC 4.6.1.
270768cd 2540 * term.c (init_tty): Remove unused local.
490011a6 2541 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2542 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2543 not used otherwise.
270768cd 2544
b1f58454
CY
25452011-07-12 Chong Yidong <cyd@stupidchicken.com>
2546
2547 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2548
22b9578d
LMI
25492011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2550
6e70ab07
LMI
2551 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2552 are the mini-buffer and the echo area (bug#3320).
2553
22b9578d
LMI
2554 * term.c (init_tty): Remove support for supdup, c10 and perq
2555 terminals, which are no longer supported (bug#1482).
2556
8974cc9f
JB
25572011-07-10 Johan Bockgård <bojohan@gnu.org>
2558
2559 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2560
a560d974
JD
25612011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2562
2563 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2564 for non-popups (Bug#3642).
2565
1dae0f0a
AS
25662011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2567
268c2c36 2568 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2569 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2570 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2571 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2572 * data.c (fmod): Likewise.
2573 * dispnew.c (swap_glyphs_in_rows): Likewise.
2574 * emacs.c (memory_warning_signal): Likewise.
2575 * floatfns.c (float_error): Likewise.
2576 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2577 (otf_open, font_otf_capability, generate_otf_features)
2578 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2579 Likewise.
2580 * image.c (pbm_read_file): Likewise.
2581 * indent.c (string_display_width): Likewise.
2582 * intervals.c (check_for_interval, search_for_interval)
2583 (inc_interval_count, count_intervals, root_interval)
2584 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2585 * lread.c (defalias): Likewise.
268c2c36 2586 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2587 * regex.c (set_image_of_range_1, set_image_of_range)
2588 (regex_grow_registers): Likewise.
2589 * sysdep.c (strerror): Likewise.
2590 * termcap.c (valid_filename_p, tprint, main): Likewise.
2591 * tparam.c (main): Likewise.
2592 * unexhp9k800.c (run_time_remap, save_data_space)
2593 (update_file_ptrs, read_header, write_header, calculate_checksum)
2594 (copy_file, copy_rest, display_header): Likewise.
2595 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2596 Likewise.
2597 * xdisp.c (check_it): Likewise.
2598 * xfaces.c (register_color, unregister_color, unregister_colors):
2599 Likewise.
2600 * xfns.c (print_fontset_result): Likewise.
2601 * xrdb.c (member, fatal, main): Likewise.
2602
99033785
PE
26032011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2604
2605 Fix minor problems found by static checking (Bug#9031).
2606 * chartab.c (char_table_set_range, map_sub_char_table):
2607 Remove unused locals.
2608 (uniprop_table): Now static.
2609 * composite.c (_work_char): Remove unused static var.
2610
9cb2ac56
JB
26112011-07-09 Juanma Barranquero <lekktu@gmail.com>
2612
2613 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2614
f25661f0
JD
26152011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2616
2617 * gtkutil.c (qttip_cb): Remove code without function.
2618
8278c4fe
EZ
26192011-07-09 Eli Zaretskii <eliz@gnu.org>
2620
2621 * w32.c (pthread_sigmask): New stub.
2622
1692ae2d 26232011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2624
8a6ebd58 2625 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2626 sigprocmask is portable only for single-threaded applications, and
2627 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2628 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2629 (LIBES): Use it.
2630 * callproc.c (Fcall_process):
2631 * process.c (create_process):
2632 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2633 Use pthread_sigmask, not sigprocmask.
123403e4 2634
1b854618
JD
26352011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2636
2637 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2638 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2639 wrong (Bug#8591).
2640
3fe4b549
JD
26412011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2642
0ce7e563
JD
2643 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2644 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2645 (xg_hide_tooltip): Fix comment.
2646
3fe4b549
JD
2647 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2648 in registerServicesMenuSendTypes.
2649 (validRequestorForSendType): Don't check ns_return_types.
2650
2651 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2652 ns_return_type.
2653
5df75e47
JR
26542011-07-08 Jason Rumney <jasonr@gnu.org>
2655
2656 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2657 frame struct members of non-existent frames (Bug#6284).
2658
699c10bd
JD
26592011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2660
4393663b
JD
2661 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2662 variable firstTime not needed on OSX >= 10.6.
2663 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2664 >= 10.5. Use setKnobProportion, setDoubleValue.
2665
2666 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2667 (MAC_OS_X_VERSION_10_5): Define if not defined.
2668 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2669 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2670 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2671
2672 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2673 cString and lossyCString on OSX >= 10.4
2674
2675 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2676 sizeToFit on OSX >= 10.2.
2677
2678 * nsimage.m (allocInitFromFile): Don't use deprecated method
2679 bestRepresentationForDevice on OSX >= 10.6.
2680
2681 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2682 to avoid warning.
2683
2684 * emacs.c: Declare unexec_init_emacs_zone.
2685
a63e0781
JD
2686 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2687
699c10bd
JD
2688 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2689
2690 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2691 on svcsMenu (Bug#8842).
2692
2693 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2694 ns_return_types.
2695 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2696
2697 * nsterm.m (QUTF8_STRING): Declare.
2698 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2699 (validRequestorForSendType): Return type is (id).
2700 Change indexOfObjectIdenticalTo to indexOfObject.
2701 Check if we have local selection before returning self (Bug#8842).
2702 (writeSelectionToPasteboard): Put local selection into paste board
2703 if we have a local selection (Bug#8842).
2704 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2705
2706 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2707 (ns_get_local_selection): Declare.
2708
54e10184
LMI
27092011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2710
9888ff71
LMI
2711 * keymap.c (describe_map_tree): Don't insert a double newline at
2712 the end of the buffer (bug#1169) and return whether we inserted
2713 something.
2714
54e10184
LMI
2715 * callint.c (Fcall_interactively): Change "reading args" to
2716 "providing args" to try to clarify what it does (bug#1010).
2717
15fa4783
KH
27182011-07-07 Kenichi Handa <handa@m17n.org>
2719
2720 * composite.c (composition_compute_stop_pos): Ignore a static
2721 composition starting before CHARPOS (Bug#8915).
2722
2723 * xdisp.c (handle_composition_prop): Likewise.
2724
a8815b00
EZ
27252011-07-07 Eli Zaretskii <eliz@gnu.org>
2726
2727 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2728 (Bug#9015)
2729
ef7b981d 27302011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2731
2732 * character.h (unicode_category_t): New enum type.
2733
2734 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2735 (Qchar_code_property_table): New variable.
2736 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2737 (UNIPROP_COMPRESSED_FORM_P): New macros.
2738 (char_table_ascii): Uncompress the compressed values.
2739 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2740 Uncompress the compressed values.
ac389d0c 2741 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2742 (char_table_ref_and_range): Uncompress the compressed values.
2743 (sub_char_table_set): New arg is_uniprop. Callers changed.
2744 Uncompress the compressed values.
2745 (sub_char_table_set_range): Args changed. Callers changed.
2746 (char_table_set_range): Adjuted for the above change.
2747 (map_sub_char_table): Delete args default_val and parent. Add arg
2748 top. Give decoded values to a Lisp function.
640c8776 2749 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2750 values to a Lisp function. Gcpro more variables.
2751 (uniprop_table_uncompress)
2752 (uniprop_decode_value_run_length): New functions.
2753 (uniprop_decoder, uniprop_decoder_count): New variables.
2754 (uniprop_get_decoder, uniprop_encode_value_character)
2755 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2756 New functions.
2757 (uniprop_encoder, uniprop_encoder_count): New variables.
2758 (uniprop_get_encoder, uniprop_table)
2759 (Funicode_property_table_internal, Fget_unicode_property_internal)
2760 (Fput_unicode_property_internal): New functions.
2761 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2762 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2763 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2764 char-code-property-alist.
2765
640c8776 2766 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2767 Vunicode_category_table.
2768
640c8776 2769 * font.c (font_range): Adjust for the change of
c805dec0
KH
2770 Vunicode_category_table.
2771
76b397fb
DN
27722011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2773
2774 * m/iris4d.h: Remove file, move contents ...
2775 * s/irix6-5.h: ... here.
2776
22b4128e
PE
27772011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2778
2779 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2780 * alloc.c (mark_buffer):
2781 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2782 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2783 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2784 This isn't true in general, and it's particularly not true
2785 if Emacs is configured with --with-wide-int.
2786 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2787 New macros, used in the buffer.c change.
2788
869795d6
JD
27892011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2790
2791 * xsettings.c: Use both GConf and GSettings if both are available.
2792 (store_config_changed_event): Add comment.
2793 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2794 (store_tool_bar_style_changed): New functions.
5e617bc2 2795 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2796 (struct xsettings): Move font inside HAVE_XFT.
2797 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2798 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2799 Move inside HAVE_XFT.
640c8776 2800 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2801 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2802 also.
2803 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2804 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2805 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2806 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2807 (parse_settings): Move check for font inside HAVE_XFT.
2808 (read_settings, apply_xft_settings): Add comment.
2809 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2810 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2811 call store_font_name_changed.
2812 (xft_settings_event): Add comment.
2813 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2814 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2815 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2816 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2817 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2818 (xsettings_get_system_font, xsettings_get_system_normal_font):
2819 Add comment.
869795d6 2820
d8ed26bd
PE
28212011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2822
2823 Random fixes. E.g., (random) never returned negative values.
2824 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2825 subseconds part to the entropy, as that's a bit more random.
2826 Prefer signed to unsigned, since the signedness doesn't matter and
2827 in general we prefer signed. When given a limit, use a
2828 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2829 latter isn't right if USE_2_TAGS_FOR_INTS.
2830 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2831 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2832
cabf1cac
SM
28332011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2834
2835 * textprop.c (text_property_stickiness):
2836 Obey Vtext_property_default_nonsticky.
2837 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2838 * w32fns.c (syms_of_w32fns):
2839 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2840
6e9b2be9
PE
28412011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2842
2843 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2844 This is more efficient than Ffile_directory_p and avoids a minor race.
2845
90186c68
LMI
28462011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2847
7c301272
LMI
2848 * buffer.c (Foverlay_put): Say what the return value is
2849 (bug#7835).
2850
c4f2d8d4
LMI
2851 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2852 is a directory before asking whether to use the file name
2853 (bug#7564).
ad637907
LMI
2854 (barf_or_query_if_file_exists): Make the "File is a directory"
2855 error be more correct.
c4f2d8d4 2856
90186c68
LMI
2857 * fns.c (Frequire): Remove the mention of the .gz files, since
2858 that's installation-specific, but keep the mention of
2859 `get-load-suffixes'.
2860
da64016e
PE
28612011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2862
2863 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2864 Report string overflow if the output is too long.
2865
7d47b580
JB
28662011-07-04 Juanma Barranquero <lekktu@gmail.com>
2867
a555cb87
JB
2868 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2869 (syms_of_gnutls): Remove duplicate DEFSYM for
2870 Qgnutls_bootprop_verify_hostname_error, an error for
2871 Qgnutls_bootprop_verify_error (which is no longer used).
2872
7d47b580
JB
2873 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2874 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2875 Also (re)move comments that are misplaced or no longer relevant.
2876
1e49bfab
LMI
28772011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2878
2879 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2880
1485f4c0
CY
28812011-07-03 Chong Yidong <cyd@stupidchicken.com>
2882
2883 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2884 and background color parameters if they have been changed.
2885
a9ab721e
LMI
28862011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2887
2888 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2889
cf7cff57
PE
28902011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2891
2e13213d
PE
2892 * xsettings.c (SYSTEM_FONT): Define only when used.
2893 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2894
cf7cff57
PE
2895 * keymap.c (access_keymap_1): Now static.
2896
7a8e04f7
CY
28972011-07-02 Chong Yidong <cyd@stupidchicken.com>
2898
2899 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2900 leave any prefix arg for the up event (Bug#1586).
2901
61352f62
LMI
29022011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2903
69bb1ef7
LMI
2904 * lread.c (syms_of_lread): Mention single symbols defined by
2905 `defvar' or `defconst' (bug#7154).
2906
61352f62 2907 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2908 (Frequire): Mention get-load-suffixes.
61352f62 2909
28545e04
MR
29102011-07-02 Martin Rudalics <rudalics@gmx.at>
2911
2912 * window.h (window): Remove clone_number slot.
2913 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2914 Remove.
2915 (make_parent_window, make_window, saved_window)
2916 (Fset_window_configuration, save_window_save): Don't deal with
2917 clone numbers.
2918 * buffer.c (Qclone_number): Remove declaration.
2919 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2920
3349e122
SM
29212011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2922
2923 Add multiple inheritance to keymaps.
2924 * keymap.c (Fmake_composed_keymap): New function.
2925 (Fset_keymap_parent): Simplify.
2926 (fix_submap_inheritance): Remove.
2927 (access_keymap_1): New function extracted from access_keymap to handle
2928 embedded parents and handle lists of maps.
2929 (access_keymap): Use it.
2930 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2931 (Fcopy_keymap): Handle embedded parents.
2932 (Fcommand_remapping, define_as_prefix): Simplify.
2933 (Fkey_binding): Simplify.
2934 (syms_of_keymap): Move minibuffer-local-completion-map,
2935 minibuffer-local-filename-completion-map,
2936 minibuffer-local-must-match-map, and
2937 minibuffer-local-filename-must-match-map to Elisp.
2938 (syms_of_keymap): Defsubr make-composed-keymap.
2939 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2940 (parse_menu_item): Trivial simplification.
2941
3279eb87
GM
29422011-07-01 Glenn Morris <rgm@gnu.org>
2943
2944 * Makefile.in (SETTINGS_LIBS): Fix typo.
2945
4550efdf
KI
29462011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2947
2948 * coding.c (Fencode_coding_string): Record the last coding system
2949 used, as the function doc string says (bug#8738).
2950
0949d2b6
JD
29512011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2952
2953 * xsettings.c (store_monospaced_changed): Take new font as arg and
2954 check for change against current_mono_font.
2955 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2956 (emacs_settings_constructor, emacs_settings_get_property)
2957 (emacs_settings_set_property, emacs_settings_class_init)
2958 (emacs_settings_init, gsettings_obj): Remove.
2959 (something_changedCB): New function for HAVE_GSETTINGS.
2960 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2961 with value as argument.
2962 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2963 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2964 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2965 "changed".
2966
2967 * xgselect.c: Add defined (HAVE_GSETTINGS).
2968 (xgselect_initialize): Ditto.
2969
2970 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2971 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2972 xg_select.
2973
bbc6b304
PE
29742011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2975
2976 * eval.c (struct backtrace): Simplify and port the data structure.
2977 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2978 signed bit field, as this assumption is not portable and it makes
2979 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2980 "char debug_on_exit : 1" as this is not portable either; instead,
2981 use the portable "unsigned int debug_on_exit : 1". Remove unused
2982 member evalargs. Remove obsolete comments about cc bombing out.
2983
9851bfc5
JD
29842011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2985
51bb811f 2986 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2987 Let HAVE_GSETTINGS override HAVE_GCONF.
2988 (store_monospaced_changed): New function.
2989 (EMACS_SETTINGS): A new type derived from GObject to handle
2990 GSettings notifications.
2991 (emacs_settings_constructor, emacs_settings_get_property)
2992 (emacs_settings_set_property, emacs_settings_class_init):
2993 New functions.
2994 (gsettings_client, gsettings_obj): New variables.
2995 (GSETTINGS_SCHEMA): New define.
2996 (something_changedCB): Call store_monospaced_changed.
2997 (init_gsettings): New function.
2998 (xsettings_initialize): Call init_gsettings.
2999 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3000 to NULL.
3001
640c8776 3002 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3003 GCONF_CFLAGS/LIBS.
3004
5386012d
MR
30052011-06-29 Martin Rudalics <rudalics@gmx.at>
3006
3007 * window.c (resize_root_window, grow_mini_window)
3008 (shrink_mini_window): Rename Qresize_root_window to
3009 Qwindow_resize_root_window and Qresize_root_window_vertically to
3010 Qwindow_resize_root_window_vertically.
3011
f13e0b08
PE
30122011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3013
3014 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3015
94515237
JB
30162011-06-27 Juanma Barranquero <lekktu@gmail.com>
3017
3018 * makefile.w32-in: Redesign dependencies so they reflect more
3019 clearly which files are directly included by each source file,
3020 and not through other includes.
3021
e43b6e43
MR
30222011-06-27 Martin Rudalics <rudalics@gmx.at>
3023
3024 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3025 (sort_overlays, overlay_strings): When an overlay's clone number
3026 matches the window's clone number process the overlay even if
3027 the overlay's window property doesn't match the current window.
3028
d68443dc
MR
3029 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3030 (Fwindow_hchild): Rename to Fwindow_left_child.
3031 (Fwindow_next): Rename to Fwindow_next_sibling.
3032 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3033 (resize_window_check): Rename to window_resize_check.
3034 (resize_window_apply): Rename to window_resize_apply.
3035 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3036 (Fdelete_other_windows_internal, resize_frame_windows)
3037 (Fsplit_window_internal, Fdelete_window_internal)
3038 (grow_mini_window, shrink_mini_window)
3039 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3040
c7e73be5
JD
30412011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3042
3043 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3044 (emacs_fixed_set_min_size): Remove.
3045 (emacs_fixed_new): Take frame as argument.
3046
3047 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3048 (_EmacsFixedPrivate): Remove minwidth/height.
3049 Add struct frame *f.
3050 (emacs_fixed_init): Initialize priv->f.
3051 (get_parent_class, emacs_fixed_set_min_size): Remove.
3052 (emacs_fixed_new): Set priv->f to argument.
3053 (emacs_fixed_get_preferred_width)
3054 (emacs_fixed_get_preferred_height): Use min_width/height from
3055 frames size_hint to set minimum and natural (Bug#8919).
3056 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3057 and use min_width/height from frames size_hint to set
3058 min_width/height (Bug#8919).
3059
3060 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3061 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3062 Fix indentation.
c7e73be5 3063
cf99dcf8
EZ
30642011-06-26 Eli Zaretskii <eliz@gnu.org>
3065
3066 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3067 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3068 called at ZV.
3069
029529ac
CY
30702011-06-26 Chong Yidong <cyd@stupidchicken.com>
3071
3072 * process.c (wait_reading_process_output): Bypass select if
3073 waiting for a cell while ignoring keyboard input, and input is
3074 pending. Suggested by Jan Djärv (Bug#8869).
3075
7a7ef429
PE
30762011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3077
3078 Use gnulib's dup2 module instead of rolling our own.
3079 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3080
11fdef7d 30812011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3082
3083 * dispnew.c (scrolling_window): Before scrolling, turn off a
3084 mouse-highlight in the window being scrolled.
3085
cd3520a4
JB
30862011-06-24 Juanma Barranquero <lekktu@gmail.com>
3087
3088 Move DEFSYM to lisp.h and use everywhere.
3089
3090 * character.h (DEFSYM): Move declaration...
3091 * lisp.h (DEFSYM): ...here.
3092
3093 * gnutls.c:
3094 * minibuf.c:
3095 * w32menu.c:
3096 * w32proc.c:
3097 * w32select.c: Don't include character.h.
3098
3099 * alloc.c (syms_of_alloc):
3100 * buffer.c (syms_of_buffer):
3101 * bytecode.c (syms_of_bytecode):
3102 * callint.c (syms_of_callint):
3103 * casefiddle.c (syms_of_casefiddle):
3104 * casetab.c (init_casetab_once):
3105 * category.c (init_category_once, syms_of_category):
3106 * ccl.c (syms_of_ccl):
3107 * cmds.c (syms_of_cmds):
3108 * composite.c (syms_of_composite):
3109 * dbusbind.c (syms_of_dbusbind):
3110 * dired.c (syms_of_dired):
3111 * dispnew.c (syms_of_display):
3112 * doc.c (syms_of_doc):
3113 * editfns.c (syms_of_editfns):
3114 * emacs.c (syms_of_emacs):
3115 * eval.c (syms_of_eval):
3116 * fileio.c (syms_of_fileio):
3117 * fns.c (syms_of_fns):
3118 * frame.c (syms_of_frame):
3119 * fringe.c (syms_of_fringe):
3120 * insdel.c (syms_of_insdel):
3121 * keymap.c (syms_of_keymap):
3122 * lread.c (init_obarray, syms_of_lread):
3123 * macros.c (syms_of_macros):
3124 * msdos.c (syms_of_msdos):
3125 * print.c (syms_of_print):
3126 * process.c (syms_of_process):
3127 * search.c (syms_of_search):
3128 * sound.c (syms_of_sound):
3129 * syntax.c (init_syntax_once, syms_of_syntax):
3130 * terminal.c (syms_of_terminal):
3131 * textprop.c (syms_of_textprop):
3132 * undo.c (syms_of_undo):
3133 * w32.c (globals_of_w32):
3134 * window.c (syms_of_window):
3135 * xdisp.c (syms_of_xdisp):
3136 * xfaces.c (syms_of_xfaces):
3137 * xfns.c (syms_of_xfns):
3138 * xmenu.c (syms_of_xmenu):
3139 * xsettings.c (syms_of_xsettings):
3140 * xterm.c (syms_of_xterm): Use DEFSYM.
3141
4228cf16
TZ
31422011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3143
cd3520a4 3144 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3145
7fcccf1e
PE
31462011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3147
7efb4e0e
PE
3148 Integer and buffer overflow fixes (Bug#8873).
3149
ff5844ad
PE
3150 * print.c (printchar, strout): Check for string overflow.
3151 (PRINTPREPARE, printchar, strout):
3152 Don't set size unless allocation succeeds.
3153
90532f02
PE
3154 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3155 for sizes. Check for string overflow more accurately.
3156 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3157
6d84508d
PE
3158 * macros.c: Integer and buffer overflow fixes.
3159 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3160 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3161 Use ptrdiff_t, not int, for sizes.
3162 Don't increment bufsize until after realloc succeeds.
3163 Check for size-calculation overflow.
3164 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3165
437b2cb4
PE
3166 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3167
8b9ac8b4
PE
3168 * lread.c: Integer overflow fixes.
3169 (read_integer): Radix is now EMACS_INT, not int,
3170 to improve quality of diagnostics for out-of-range radices.
3171 Calculate buffer size correctly for out-of-range radices.
3172 (read1): Check for integer overflow in radices, and in
3173 read-circle numbers.
82cb60d3
PE
3174 (read_escape): Avoid int overflow.
3175 (Fload, openp, read_buffer_size, read1)
3176 (substitute_object_recurse, read_vector, read_list, map_obarray):
3177 Use ptrdiff_t, not int, for sizes.
3178 (read1): Use EMACS_INT, not int, for sizes.
20270765 3179 Check for size overflow.
8b9ac8b4 3180
7fcccf1e
PE
3181 * image.c (cache_image): Check for size arithmetic overflow.
3182
bfbbd7e7
PE
3183 * lread.c: Integer overflow issues.
3184 (saved_doc_string_size, saved_doc_string_length)
3185 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3186 Now ptrdiff_t, not int.
3187 (read1): Don't assume doc string length fits in int. Check for
3188 out-of-range doc string lengths.
3189 (read_list): Don't assume file position fits in int.
39019e54 3190 (read_escape): Check for hex character overflow.
bfbbd7e7 3191
4e323265
LL
31922011-06-22 Leo Liu <sdl.web@gmail.com>
3193
3194 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3195 Move to minibuffer.el.
3196
85fece3e
PE
31972011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3198
20b84ce9 3199 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3200 The following patches are for when GLYPH_DEBUG && !XASSERT.
3201 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3202 * dispnew.c (flush_stdout):
3203 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3204 Mark as externally visible.
3205 * dispnew.c (check_window_matrix_pointers): Now static.
3206 * dispnew.c (window_to_frame_vpos):
3207 * xfns.c (unwind_create_frame):
3208 * xterm.c (x_check_font): Remove unused local.
3209 * scroll.c (CHECK_BOUNDS):
3210 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3211 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3212 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3213 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3214 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3215 Now static.
3216 (debug_method_add): Use va_list and vsprintf rather than relying
3217 on undefined behavior with wrong number of arguments.
3218 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3219 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3220 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3221 since we're not interested in debugging glyphs with old libraries.
3222 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3223 GCC 4.6.0's static checking.
3224
0766b489
PE
32252011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3226
31fd4b32
PE
3227 Integer overflow and signedness fixes (Bug#8873).
3228 A few related buffer overrun fixes, too.
3229
b79e8648
PE
3230 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3231
0766b489
PE
3232 * dispextern.h (struct face.stipple):
3233 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3234 (x_bitmap_mask, x_allocate_bitmap_record)
3235 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3236 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3237 (x_create_bitmap_from_xpm_data):
3238 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3239 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3240 (.bitmaps_last):
3241 * xfaces.c (load_pixmap):
3242 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3243 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3244 (.bitmaps_last, struct x_output.icon_bitmap):
3245 Use ptrdiff_t, not int, for bitmap indexes.
3246 (x_allocate_bitmap_record): Check for size overflow.
3247 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3248
b081724f
PE
3249 Use ptrdiff_t, not int, for overlay counts.
3250 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3251 * editfns.c (overlays_around, get_pos_property):
3252 * textprop.c (get_char_property_and_overlay):
3253 * xdisp.c (next_overlay_change, note_mouse_highlight):
3254 * xfaces.c (face_at_buffer_position):
21514da7
PE
3255 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3256 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3257 (Fnext_overlay_change, Fprevious_overlay_change)
3258 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3259 Use ptrdiff_t, not int, for sizes.
21514da7 3260 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3261
3de73e5e
PE
3262 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3263
2606c57b
PE
3264 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3265 (x_session_initialize): Do not assume string length fits in int.
3266
aaafe47a
PE
3267 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3268 This is unlikely, but can occur if DPI is outlandish.
3269
2674ddc8 3270 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3271 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3272
28154962
PE
3273 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3274 * xrdb.c (magic_file_p, search_magic_path):
3275 Omit last arg SUFFIX; it was always 0. All callers changed.
3276 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3277
7de51af5
PE
3278 * xfont.c (xfont_match): Avoid need for strlen.
3279
25ed6cc3
PE
3280 * xfns.c: Don't assume strlen fits in int.
3281 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3282
4eab31dd
PE
3283 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3284 not unsigned long, as we prefer signed integers. All callers changed.
3285 Detect integer overflow in repeat count.
3286 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3287 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3288
171e2a58
PE
3289 * termcap.c: Don't assume sizes fit in int and never overflow.
3290 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3291 (gobble_line): Check for size-calculation overflow.
3292
ad39faca 3293 * minibuf.c (Fread_buffer):
6e5bb2dc 3294 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3295 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3296 Don't assume string length fits in int.
3297
52c61c22 3298 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3299 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3300
b5b8c9e5
PE
3301 * font.c: Don't assume string length fits in int.
3302 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3303 Use ptrdiff_t, not int.
ccd6111c
PE
3304 (font_intern_prop): Don't assume string length fits in int.
3305 Don't assume integer property fits in fixnum.
3306 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3307
882f0d81 3308 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3309 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3310 Reformulate so as not to need the command string.
3311 Invoke gzip -cd rather than gunzip, as it's more portable.
3312 (lock_info_type, lock_file_1, lock_file):
3313 Don't assume pid_t and time_t fit in unsigned long.
3314 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3315 (current_lock_owner): Prefer signed type for sizes.
3316 Use memcpy, not strncpy, where memcpy is what is really wanted.
3317 Don't assume (via atoi) that time_t and pid_t fit in int.
3318 Check for time_t and/or pid_t out of range, e.g., via a network share.
3319 Don't alloca where an auto var works fine.
3320
93f4cf88
PE
3321 * fileio.c: Fix some integer overflow issues.
3322 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3323 Don't assume string length fits in int.
3324 (directory_file_name): Don't assume string length fits in long.
3325 (make_temp_name): Don't assume pid fits in int, or that its print
3326 length is less than 20.
3327
f3e92b69
PE
3328 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3329
1bfdaf10
PE
3330 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3331
35016e9a
PE
3332 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3333
3d1e65a1
PE
3334 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3335 We prefer signed integers, even for size calculations.
3336
0b963a93
PE
3337 * emacs.c: Don't assume string length fits in 'int'.
3338 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3339 (main): Don't invoke strlen when not needed.
3340
573f4b54
PE
3341 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3342 (XD_DEBUG_MESSAGE): Don't waste a byte.
3343
989f33ba
PE
3344 * callproc.c (getenv_internal_1, getenv_internal)
3345 (Fgetenv_internal):
965d34eb
PE
3346 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3347
e4d29b33
PE
3348 * lread.c (invalid_syntax): Omit length argument.
3349 All uses changed. This doesn't fix a bug, but it simplifies the
3350 code away from its former Hollerith-constant appearance, and it's
3351 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3352 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3353
eb49b136
PE
3354 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3355 This didn't break anything, but it didn't help either.
3356 It's confusing to put a bogus integer in a place where the actual
3357 value does not matter.
9f62aeb1 3358 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3359 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3360
15375a22
PE
3361 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3362 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3363 implementation.
b61cc01c
PE
3364 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3365 We prefer signed types, and the value cannot exceed the EMACS_INT
3366 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3367 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3368 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3369 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3370
53b2623d
PE
3371 * indent.c (sane_tab_width): New function.
3372 (current_column, scan_for_column, Findent_to, position_indentation)
3373 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3374 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3375
51cab52b 3376 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3377
f2ed8a70
PE
3378 * lisp.h (lint_assume): New macro.
3379 * composite.c (composition_gstring_put_cache):
3380 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3381
abe80cc6
PE
3382 * editfns.c, insdel.c:
3383 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3384
b02c740e
PE
3385 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3386
ebc96716
PE
3387 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3388
b4e50fa0 3389 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3390 Use much-faster test for byte-length change.
311d5d7c 3391 Don't assume string byte-length fits in 'int'.
a4cf38e4 3392 Check that character arg fits in 'int'.
85461888 3393 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3394
c0c1ee9f
PE
3395 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3396
a498d7f4
PE
3397 * fns.c (concat): Catch string overflow earlier.
3398 Do not rely on integer wraparound.
3399
51cab52b
PE
3400 * dispextern.h (struct it.overlay_strings_charpos)
3401 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3402 * xdisp.c (forward_to_next_line_start)
3403 (back_to_previous_visible_line_start)
3404 (reseat_at_next_visible_line_start, next_element_from_buffer):
3405 Don't arbitrarily truncate the value of 'selective' to int.
3406
76031fad
PE
3407 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3408
5eb55db9
PE
3409 * composite.c: Don't truncate sizes to 'int'.
3410 (composition_gstring_p, composition_reseat_it)
3411 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3412 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3413 not EMACS_UINT, for indexes.
5eb55db9 3414
0703a717
PE
3415 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3416
d6202519
PE
3417 * buffer.c: Include <verify.h>.
3418 (struct sortvec.priority, struct sortstr.priority):
8961a454 3419 Now EMACS_INT, not int.
c20998a7 3420 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3421 (struct sortstr.size, record_overlay_string)
3422 (struct sortstrlist.size, struct sortlist.used):
3423 Don't truncate size to int.
3424 (record_overlay_string): Check for size-calculation overflow.
d6202519 3425 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3426
d5a19415
JM
34272011-06-22 Jim Meyering <meyering@redhat.com>
3428
029529ac 3429 Don't leak an XBM-image-sized buffer
d5a19415
JM
3430 * image.c (xbm_load): Free the image buffer after using it.
3431
a9041e6c
PE
34322011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3433
3434 Port to Sun C.
3435 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3436 that Sun C diagnosed.
3437 * fns.c (secure_hash): Fix pointer signedness issue.
3438 * intervals.c (static_offset_intervals): New function.
3439 (offset_intervals): Use it.
3440
7f3f739f
LL
34412011-06-21 Leo Liu <sdl.web@gmail.com>
3442
3443 * deps.mk (fns.o):
3444 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3445 sha512.h.
3446
3447 * fns.c (secure_hash): Rename from crypto_hash_function and change
3448 the first arg to accept symbols.
5b66d427 3449 (Fsecure_hash): New primitive.
7f3f739f
LL
3450 (syms_of_fns): New symbols.
3451
76147d94
DD
34522011-06-20 Deniz Dogan <deniz@dogan.se>
3453
3454 * process.c (Fset_process_buffer): Clarify return value in
3455 docstring.
3456
7d7d0045
CY
34572011-06-18 Chong Yidong <cyd@stupidchicken.com>
3458
3459 * dispnew.c (add_window_display_history): Use BVAR.
3460
3461 * xdisp.c (debug_method_add): Use BVAR.
3462 (check_window_end, dump_glyph_matrix, dump_glyph)
3463 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3464
3465 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3466 Likewise.
3467
3468 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3469 check till after the cache is created in init_frame_faces.
3470
ff2bc410
SM
34712011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3472
3473 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3474
28177add
PE
34752011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3476
dd3482fe
PE
3477 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3478 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3479 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3480
393d71f3 3481 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3482 * fileio.c (Finsert_file_contents):
3483 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3484 Remove the old (too-loose) buffer overflow checks.
3485 They weren't needed, since make_gap checks for buffer overflow.
3486 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3487 The old code merely checked for Emacs fixnum overflow, and relied
3488 on undefined (wraparound) behavior. The new code avoids undefined
3489 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3490
2e6813b0 3491 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3492 Tune. Don't use wider integers than needed. Don't use alloca.
3493 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3494
599a9e4f
PE
3495 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3496
99561444
PE
3497 * insdel.c, lisp.h (buffer_overflow): New function.
3498 (insert_from_buffer_1, replace_range, replace_range_2):
3499 * insdel.c (make_gap_larger):
3500 * editfns.c (Finsert_char):
3501 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3502
28177add
PE
3503 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3504
e69dafad
PE
35052011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3506
a7af7fde 3507 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3508
b1c46f02
PE
3509 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3510 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3511
e69dafad
PE
3512 * fileio.c: Don't assume EMACS_INT fits in off_t.
3513 (emacs_lseek): New static function.
3514 (Finsert_file_contents, Fwrite_region): Use it.
3515 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3516
566684ea
PE
3517 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3518
e6966cd6
PE
3519 * fns.c: Don't overflow int when computing a list length.
3520 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3521 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3522 truncation on 64-bit hosts. Check for QUIT every
3523 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3524 faster and is responsive enough.
3525 (Flength): Report an error instead of overflowing an integer.
3526 (Fsafe_length): Return a float if the value is not representable
3527 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3528 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3529 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3530
dd0b0efb
PE
3531 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3532 (header_size, word_size): New constants.
3533 (allocate_vectorlike): Don't check size overflow here.
3534 (allocate_vector): Check it here instead, since this is the only
3535 caller of allocate_vectorlike that could cause overflow.
3536 Check that the new vector's length is representable as a fixnum.
3537
86fe5cfe
PE
3538 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3539 The previous code was bogus. For example, next_almost_prime (32)
3540 returned 39, which is undesirable as it is a multiple of 3; and
3541 next_almost_prime (24) returned 25, which is a multiple of 5 so
3542 why was the code bothering to check for multiples of 7?
3543
80e88859
PE
3544 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3545
4a2f0ad6
PE
3546 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3547
f66c7cf8
PE
3548 Variadic C functions now count arguments with ptrdiff_t.
3549 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3550 Back then I didn't know that the Emacs coding style prefers signed int.
3551 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3552 were being counted with int, which may truncate counts on 64-bit
3553 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3554 * lisp.h (struct Lisp_Subr.function.aMANY)
3555 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3556 Arg counts are now ptrdiff_t, not size_t.
3557 All variadic functions and their callers changed accordingly.
3558 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3559 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3560 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3561 * callint.c (Fcall_interactively): Check arg count for overflow,
3562 to avoid potential buffer overrun. Use signed char, not 'int',
3563 for 'varies' array, so that we needn't bother to check its size
3564 calculation for overflow.
3565 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3566 * eval.c (apply_lambda):
3567 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3568 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3569 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3570
a1759b76
PE
3571 * callint.c (Fcall_interactively): Don't use index var as event count.
3572
d96be9fc
PE
3573 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3574 * mem-limits.h (SIZE): Remove; no longer used.
3575
a690a978 3576 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3577
578c21e6
PE
3578 Remove unnecessary casts.
3579 * xterm.c (x_term_init):
3580 * xfns.c (x_set_border_pixel):
3581 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3582 These aren't needed now that we assume ANSI C.
3583
96f53c6c
PE
3584 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3585 It's more likely to cause problems (due to unsigned overflow)
3586 than to cure them.
3587
83c77d31
PE
3588 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3589
ee2079f1
PE
3590 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3591
6da65536
PE
3592 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3593
7147c4a4
PE
3594 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3595
193e32d9
PE
3596 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3597
e5533da6
PE
3598 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3599
9910e595
PE
3600 GLYPH_CODE_FACE returns EMACS_INT, not int.
3601 * dispextern.h (merge_faces):
3602 * xfaces.c (merge_faces):
01103c44
PE
3603 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3604 Don't assume EMACS_INT fits in int.
9910e595 3605
2638320e
PE
3606 * character.h (CHAR_VALID_P): Remove unused parameter.
3607 * fontset.c, lisp.h, xdisp.c: All uses changed.
3608
045eb8d9
PE
3609 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3610
c1f134b5
PE
3611 * fns.c (concat): Minor tuning based on overflow analysis.
3612 This doesn't fix any bugs. Use int to hold character, instead
3613 of constantly refetching from Emacs object. Use XFASTINT, not
3614 XINT, for value known to be a character. Don't bother comparing
3615 a single byte to 0400, as it's always less.
3616
395fcb93 3617 * floatfns.c (Fexpt):
327eeec8
PE
3618 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3619
abbd3d23
PE
3620 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3621 for characters.
3622
684a03ef
PE
3623 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3624
0fed43f3
PE
3625 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3626 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3627 incorrectly succeed when S was a string, because 4294967386 was
3628 truncated before it was used.
3629
8fd02eb7
PE
3630 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3631 Otherwise, an out-of-range integer could cause undefined behavior
3632 on a 64-bit host.
3633
f8c86b69
PE
3634 * composite.c: Use int, not EMACS_INT, for characters.
3635 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3636 EMACS_INT, for values that are known to be in character range.
3637 This doesn't fix any bugs but is the usual style inside Emacs and
3638 may generate better code on 32-bit machines.
3639
34206dd2
PE
3640 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3641 This is for reasons similar to the recent CHAR_STRING fix.
3642 * charset.c (Fencode_char): Check that character arg is actually
3643 a character. Pass an int to ENCODE_CHAR.
3644 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3645 wider than 'int', as a compile-time check to prevent future regressions
3646 in this area.
3647
c5958d4c 3648 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3649
3650 Make sure a 64-bit char is never passed to CHAR_STRING.
3651 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3652 by silently ignoring the top 32 bits, allowing some values
3653 that were far too large to be valid characters.
3654 * character.h: Include <verify.h>.
3655 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3656 arguments are no wider than unsigned, as a compile-time check
3657 to prevent future regressions in this area.
3658 * data.c (Faset):
01103c44 3659 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3660 (Fsubst_char_in_region):
3661 * fns.c (concat):
3662 * xdisp.c (decode_mode_spec_coding):
3663 Adjust to CHAR_STRING's new requirement.
3664 * editfns.c (Finsert_char, Fsubst_char_in_region):
3665 * fns.c (concat): Check that character args are actually
3666 characters. Without this test, these functions did the wrong
3667 thing with wildly out-of-range values on 64-bit hosts.
3668
d37ca623
PE
3669 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3670 These casts should not be needed on 32-bit hosts, either.
3671 * keyboard.c (read_char):
3672 * lread.c (Fload): Remove casts to unsigned.
3673
ea204efb
PE
3674 * lisp.h (UNSIGNED_CMP): New macro.
3675 This fixes comparison bugs on 64-bit hosts.
3676 (ASCII_CHAR_P): Use it.
3677 * casefiddle.c (casify_object):
01103c44 3678 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3679 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3680 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3681 * dispextern.h (FACE_FROM_ID):
3682 * keyboard.c (read_char): Use UNSIGNED_CMP.
3683
41cb286c
PE
3684 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3685 not to EMACS_INT, to avoid GCC warning.
3686
4a1b9832
PE
3687 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3688
55daad71
PE
3689 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3690 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3691 isn't needed on 32-bit machines.
8f95c75c 3692
01103c44
PE
3693 * buffer.c (Fgenerate_new_buffer_name):
3694 Use EMACS_INT for count, not int.
0ceccced 3695 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3696
3697 * data.c (Qcompiled_function): Now static.
3698
c6f072e7
PE
3699 * window.c (window_body_lines): Now static.
3700
20ce5912
PE
3701 * image.c (gif_load): Rename local to avoid shadowing.
3702
9c4c5f81
PE
3703 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3704 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3705 * alloc.c (make_save_value): Integer argument is now of type
3706 ptrdiff_t, not int.
3707 (mark_object): Use ptrdiff_t, not int.
3708 * lisp.h (pD): New macro.
3709 * print.c (print_object): Use it.
3710
c0c5c8ae
PE
3711 * alloc.c: Use EMACS_INT, not int, to count objects.
3712 (total_conses, total_markers, total_symbols, total_vector_size)
3713 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3714 (total_free_floats, total_floats, total_free_intervals)
3715 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3716 Now EMACS_INT, not int. All uses changed.
3717 (Fgarbage_collect): Compute overall total using a double, so that
3718 integer overflow is less likely to be a problem. Check for overflow
3719 when converting back to an integer.
5a25e253
PE
3720 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3721 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3722 These were 'int' variables that could overflow on 64-bit hosts;
3723 they were never used, so remove them instead of repairing them.
211a0b2a 3724 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3725 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3726 Previously, this ceilinged at INT_MAX, but that doesn't work on
3727 64-bit machines.
e46bb31a 3728 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3729
c78baabf 3730 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3731 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3732 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3733 when a (possibly-narrower) signed value would do just as well.
3734 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3735
c9d624c6
PE
3736 * alloc.c: Catch some string size overflows that we were missing.
3737 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3738 for convenience in STRING_BYTES_MAX.
3739 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3740 The definition here is exact; the one in lisp.h was approximate.
3741 (allocate_string_data): Check for string overflow. This catches
3742 some instances we weren't catching before. Also, it catches
3743 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3744 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3745 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3746
c9d624c6
PE
3747 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3748 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3749 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3750
353032ce
PE
3751 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3752
2bccce07
PE
3753 * alloc.c (Fmake_string): Check for out-of-range init.
3754
0ac30604
SM
37552011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3756
3757 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3758
c195f2de
JD
37592011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3760
3761 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3762 xg_get_default_scrollbar_width.
3763
3764 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3765 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3766 (style_changed_cb): Call update_theme_scrollbar_width and call
3767 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3768 all frames (Bug#8505).
3769 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3770 Call gtk_window_set_resizable if HAVE_GTK3.
3771 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3772 and height if HAVE_GTK3 (Bug#8505).
3773 (scroll_bar_width_for_theme): New variable.
3774 (update_theme_scrollbar_width): New function.
3775 (xg_get_default_scrollbar_width): Move code to
3776 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3777 (xg_initialize): Call update_theme_scrollbar_width.
3778
3779 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3780
3781 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3782
e10ac9f1
MR
37832011-06-12 Martin Rudalics <rudalics@gmx.at>
3784
3785 * frame.c (make_frame): Call other_buffer_safely instead of
3786 other_buffer.
3787
3788 * window.c (temp_output_buffer_show): Call display_buffer with
3789 second argument Vtemp_buffer_show_specifiers and reset latter
3790 immediately after the call.
3791 (Vtemp_buffer_show_specifiers): New variable.
3792 (auto_window_vscroll_p, next_screen_context_lines)
3793 (Vscroll_preserve_screen_position): Remove leading asterisks from
3794 doc-strings.
3795
2d3c217e 37962011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3797
7b7f97e8 3798 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3799 * buffer.c (Qclone_number): Remove for now, as it's unused.
3800 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3801 (record_buffer): Remove unused local.
3802 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3803 (set_frame_buffer_list): Remove; unused.
3804 * frame.h (other_visible_frames): Remove decl.
3805 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3806 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3807 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3808 if HAVE_GPM.
3809 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3810 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3811 Define only if HAVE_GPM.
3812 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3813 (update_hints_inhibit): Remove; never set. All uses removed.
3814 * widgetprv.h (emacsFrameClassRec): Remove decl.
3815 * window.c (delete_deletable_window): Now returns void, since it
3816 wasn't returning anything.
3817 (compare_window_configurations): Remove unused locals.
3818 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3819 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3820 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3821 the same widths as pointers. This follows up on the 2011-05-06 patch.
3822 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3823 * xterm.h: Likewise.
3824 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3825
1384b89e
JB
38262011-06-12 Juanma Barranquero <lekktu@gmail.com>
3827
3828 * makefile.w32-in: Update dependencies.
3829 (LISP_H): Add lib/intprops.h.
3830
1100a63c
CY
38312011-06-11 Chong Yidong <cyd@stupidchicken.com>
3832
3833 * image.c (gif_load): Add animation frame delay to the metadata.
3834 (syms_of_image): Use DEFSYM. New symbol `delay'.
3835
6198ccd0
MR
38362011-06-11 Martin Rudalics <rudalics@gmx.at>
3837
3838 * window.c (delete_deletable_window): Re-add.
3839 (Fset_window_configuration): Rewrite to handle dead buffers and
3840 consequently deletable windows.
3841 (window_tree, Fwindow_tree): Remove. Supply functionality in
3842 window.el.
3843 (compare_window_configurations): Simplify code.
3844
b6e3633c
AS
38452011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3846
1ab0dee5
AS
3847 * image.c (imagemagick_load_image): Fix type mismatch.
3848 (Fimagemagick_types): Likewise.
3849
b6e3633c
AS
3850 * window.h (replace_buffer_in_windows): Declare.
3851
9397e56f
MR
38522011-06-11 Martin Rudalics <rudalics@gmx.at>
3853
3854 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3855 Qclone_number. Remove external declaration of Qdelete_window.
3856 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3857 code.
640c8776
SM
3858 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3859 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3860 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3861 buffer list implementation.
3862 (other_buffer_safely): New function.
3863 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3864 calls to replace_buffer_in_windows and
3865 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3866 if allowed.
3867 (record_buffer): Inhibit quitting and rewrite using quittable
3868 functions. Run Qbuffer_list_update_hook if allowed.
3869 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3870 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3871 Move switch-to-buffer to window.el.
9397e56f
MR
3872 (bury-buffer): Move to window.el.
3873 (Vbuffer_list_update_hook): New variable.
3874
3875 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3876 section.
3877
3878 * window.h (resize_frame_windows): Move up in code.
3879 (Fwindow_frame): Remove EXFUN.
3880 (replace_buffer_in_all_windows): Remove prototype.
3881 (replace_buffer_in_windows_safely): Add prototype.
3882
3883 * window.c: Declare Qdelete_window static again. Move down
3884 declaration of select_count.
3885 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3886 (Fother_window): Move to window.el.
3887 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3888 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3889 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3890 window.el.
3891 (replace_buffer_in_windows): Implement by calling
3892 Qreplace_buffer_in_windows.
3893 (replace_buffer_in_all_windows): Remove with some functionality
3894 moved into replace_buffer_in_windows_safely.
3895 (replace_buffer_in_windows_safely): New function.
3896 (select_window_norecord, select_frame_norecord): Move in front
3897 of run_window_configuration_change_hook. Remove now obsolete
3898 declarations.
640c8776
SM
3899 (Fset_window_buffer): Rewrite doc-string.
3900 Call Qrecord_window_buffer.
9397e56f
MR
3901 (keys_of_window): Move binding for other-window to window.el.
3902
b50691aa
CY
39032011-06-11 Chong Yidong <cyd@stupidchicken.com>
3904
3905 * dispextern.h (struct image): Replace data member, whose int_val
3906 and ptr_val fields were not used by anything, with a single
3907 lisp_val object.
3908
3909 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3910 (gif_clear_image, gif_load, imagemagick_load_image)
3911 (gs_clear_image, gs_load): Callers changed.
3912
3f754b86
PE
39132011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3914
cca69397
PE
3915 * buffer.h: Include <time.h>, for time_t.
3916 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3917
109e28d0
PE
3918 Fix minor problems found by static checking.
3919
60737f02
PE
3920 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3921
4b66faf3
PE
3922 Make identifiers static if they are not used in other modules.
3923 * data.c (Qcompiled_function, Qframe, Qvector):
3924 * image.c (QimageMagick, Qsvg):
3925 * minibuf.c (Qmetadata):
3926 * window.c (resize_window_check, resize_root_window): Now static.
3927 * window.h (resize_window_check, resize_root_window): Remove decls.
3928
109e28d0
PE
3929 * window.c (window_deletion_count, delete_deletable_window):
3930 Remove; unused.
46a4ce9e
PE
3931 (window_body_lines): Now static.
3932 (Fdelete_other_windows_internal): Mark vars as initialized.
3933 Make sure 'resize_failed' is initialized.
3934 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3935 (resize_window_apply): Remove unused local.
3936 * window.h (delete_deletable_window): Remove decl.
3937
109e28d0 3938 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3939 (imagemagick_load_image): Fix pointer signedness problem by changing
3940 last arg from unsigned char * to char *. All uses changed.
3941 Also, fix a local for similar reasons.
3942 Remove unused locals. Remove locals to avoid shadowing.
3943 (fn_rsvg_handle_free): Remove; unused.
3944 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3945 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3946
3f754b86
PE
3947 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3948
2547adb1
CY
39492011-06-10 Chong Yidong <cyd@stupidchicken.com>
3950
3951 * image.c (gif_load): Fix omitted cast error introduced by
3952 2011-06-06 change.
3953
2c8e37d4
MR
39542011-06-10 Martin Rudalics <rudalics@gmx.at>
3955
3956 * window.h (resize_proportionally, orig_total_lines)
3957 (orig_top_line): Remove from window structure.
3958 (set_window_height, set_window_width, change_window_heights)
3959 (Fdelete_window): Remove prototypes.
3960 (resize_frame_windows): Remove duplicate declaration.
3961
440a42e3
EZ
39622011-06-10 Eli Zaretskii <eliz@gnu.org>
3963
3964 * window.h (resize_frame_windows, resize_window_check)
3965 (delete_deletable_window, resize_root_window)
3966 (resize_frame_windows): Declare prototypes.
3967
3968 * window.c (resize_window_apply): Make definition be "static" to
3969 match the prototype.
3970
562dd5e9
MR
39712011-06-10 Martin Rudalics <rudalics@gmx.at>
3972
3973 * window.c: Remove declarations of Qwindow_size_fixed,
3974 window_min_size_1, window_min_size_2, window_min_size,
3975 size_window, window_fixed_size_p, enlarge_window, delete_window.
3976 Remove static from declaration of Qdelete_window, it's
3977 temporarily needed by Fbury_buffer.
3978 (replace_window): Don't assign orig_top_line and
3979 orig_total_lines.
3980 (Fdelete_window, delete_window): Remove. Window deletion is
3981 handled by window.el.
640c8776
SM
3982 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3983 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3984 (Fdelete_other_windows): Remove. Deleting other windows is
3985 handled by window.el.
3986 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3987 handled in window.el.
3988 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3989 Window minimum sizes are handled in window.el.
3990 (shrink_windows, size_window, set_window_height)
3991 (set_window_width, change_window_heights, window_height)
3992 (window_width, CURBEG, CURSIZE, enlarge_window)
3993 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3994 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3995 handled in window.el.
3996 (make_dummy_parent): Rename to make_parent_window and give it a
3997 second argument horflag.
3998 (make_window): Don't set resize_proportionally any more.
3999 (Fsplit_window): Remove. Windows are split in window.el.
4000 (save_restore_action, save_restore_orig_size)
4001 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4002 Resize mini windows in window.el.
4003 (grow_mini_window, shrink_mini_window): Implement by calling
4004 Qresize_root_window_vertically, resize_window_check and
4005 resize_window_apply.
640c8776
SM
4006 (saved_window, Fset_window_configuration, save_window_save):
4007 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4008 resize_proportionally.
4009 (window_min_height, window_min_width): Move to window.el.
4010 (keys_of_window): Move bindings for delete-other-windows,
4011 split-window, delete-window and enlarge-window to window.el.
4012
4013 * buffer.c: Temporarily extern Qdelete_window.
4014 (Fbury_buffer): Temporarily call Qdelete_window instead of
4015 Fdelete_window (Fbury_buffer will move to window.el soon).
4016
4017 * frame.c (set_menu_bar_lines_1): Remove code handling
4018 orig_top_line and orig_total_lines.
4019
4020 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4021 set_window_height but set heights directly.
4022 (change_frame_size_1): Use resize_frame_windows.
4023
4024 * xdisp.c (init_xdisp): Don't use set_window_height but set
4025 heights directly.
4026
640c8776
SM
4027 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4028 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4029 run_window_configuration_change_hook.
4030
4031 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4032 instead of change_window_heights and run
4033 run_window_configuration_change_hook.
4034
1a13852e
MR
40352011-06-09 Martin Rudalics <rudalics@gmx.at>
4036
4037 * window.c (replace_window): Rename second argument REPLACEMENT to
4038 NEW. New third argument SETFLAG. Rewrite.
4039 (delete_window, make_dummy_parent): Call replace_window with
4040 third argument 1.
4041 (window_list_1): Move down in code.
4042 (run_window_configuration_change_hook): Move set_buffer part
4043 before select_frame_norecord part in order to unwind correctly.
4044 Rename count1 to count.
4045 (recombine_windows, delete_deletable_window, resize_root_window)
4046 (Fdelete_other_windows_internal)
4047 (Frun_window_configuration_change_hook, make_parent_window)
4048 (resize_window_check, resize_window_apply, Fresize_window_apply)
4049 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4050 (Fdelete_window_internal, Fresize_mini_window_internal):
4051 New functions.
1a13852e
MR
4052 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4053
f3d1777e
MR
40542011-06-08 Martin Rudalics <rudalics@gmx.at>
4055
496e208e
MR
4056 * window.h (window): Add some new members to window structure -
4057 normal_lines, normal_cols, new_total, new_normal, clone_number,
4058 splits, nest, prev_buffers, next_buffers.
4059 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4060 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4061
f3d1777e
MR
4062 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4063 Remove.
496e208e
MR
4064 (make_dummy_parent): Set new members of windows structure.
4065 (make_window): Move down in code. Handle new members of window
4066 structure.
4067 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4068 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4069 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4070 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4071 (Fset_window_next_buffers, Fset_window_clone_number):
4072 New functions.
496e208e
MR
4073 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4074 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4075 Doc-string fixes.
4076 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4077 Argument WINDOW can be now internal window too.
4078 (Fwindow_use_time): Move up in code.
4079 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4080 Rewrite doc-string.
4081 (Fset_window_configuration, saved_window)
4082 (Fcurrent_window_configuration, save_window_save): Handle new
4083 members of window structure.
b9e809c2
MR
4084 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4085 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4086 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4087 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4088 Qget_mru_window, Qresize_root_window,
4089 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4090 Qauto_buffer_name; staticpro them.
f3d1777e 4091
abde8f8c
MR
40922011-06-07 Martin Rudalics <rudalics@gmx.at>
4093
4094 * window.c (Fwindow_total_size, Fwindow_left_column)
4095 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4096 (Fwindow_list_1): New functions.
4097 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4098 (Fwindow_width, Fscroll_left, Fscroll_right):
4099 Use window_body_cols instead of window_box_text_cols.
4100 (delete_window, Fset_window_configuration):
4101 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4102 (delete_all_subwindows): Take a window as argument and not a
4103 structure. Rewrite.
190b47e6
MR
4104 (window_loop): Remove handling of GET_LRU_WINDOW and
4105 GET_LARGEST_WINDOW.
4106 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4107
4108 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4109 window_box_text_cols. delete_all_subwindows now takes a
4110 Lisp_Object as argument.
abde8f8c 4111
640c8776
SM
4112 * indent.c (compute_motion, Fcompute_motion):
4113 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4114
fa8a67e6
MR
4115 * frame.c (delete_frame): Call delete_all_subwindows with root
4116 window as argument.
4117
a54e3482
DC
41182011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4119
4120 * fns.c (Fputhash): Document return value.
4121
60002bf5
CY
41222011-06-06 Chong Yidong <cyd@stupidchicken.com>
4123
4124 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4125
0c671da6 41262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4127
b862a52a 4128 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4129
be44ca6c
PE
4130 Check for overflow when converting integer to cons and back.
4131 * charset.c (Fdefine_charset_internal, Fdecode_char):
4132 Use cons_to_unsigned to catch overflow.
4133 (Fencode_char): Use INTEGER_TO_CONS.
4134 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4135 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4136 * data.c (long_to_cons, cons_to_long): Remove.
4137 (cons_to_unsigned, cons_to_signed): New functions.
4138 These signal an error for invalid or out-of-range values.
4139 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4140 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4141 * font.c (Ffont_variation_glyphs):
4142 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4143 * lisp.h: Include <intprops.h>.
4144 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4145 (cons_to_signed, cons_to_unsigned): New decls.
4146 (long_to_cons, cons_to_long): Remove decls.
4147 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4148 (Fprimitive_undo): Use CONS_TO_INTEGER.
4149 * xfns.c (Fx_window_property): Likewise.
4150 * xselect.c: Include <limits.h>.
4151 (x_own_selection, selection_data_to_lisp_data):
4152 Use INTEGER_TO_CONS.
4153 (x_handle_selection_request, x_handle_selection_clear)
4154 (x_get_foreign_selection, Fx_disown_selection_internal)
4155 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4156 (lisp_data_to_selection_data): Use cons_to_unsigned.
4157 (x_fill_property_data): Use cons_to_signed.
4158 Report values out of range.
4159
d1f3d2af
PE
4160 Check for buffer and string overflow more precisely.
4161 * buffer.h (BUF_BYTES_MAX): New macro.
4162 * lisp.h (STRING_BYTES_MAX): New macro.
4163 * alloc.c (Fmake_string):
4164 * character.c (string_escape_byte8):
4165 * coding.c (coding_alloc_by_realloc):
4166 * doprnt.c (doprnt):
4167 * editfns.c (Fformat):
4168 * eval.c (verror):
4169 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4170 since they may not be the same number.
4171 * editfns.c (Finsert_char):
4172 * fileio.c (Finsert_file_contents):
4173 Likewise for BUF_BYTES_MAX.
4174
dd52fcea
PE
4175 * image.c: Use ptrdiff_t, not int, for sizes.
4176 (slurp_file): Switch from int to ptrdiff_t.
4177 All uses changed.
4178 (slurp_file): Check that file size fits in both size_t (for
4179 malloc) and ptrdiff_t (for sanity and safety).
4180
7f9bbdbb
PE
4181 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4182 if b->modtime has its maximal value.
4183
dfe18f82
PE
4184 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4185
84acfcf0
PE
4186 Don't assume time_t can fit into int.
4187 * buffer.h (struct buffer.modtime): Now time_t, not int.
4188 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4189 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4190
ccd9a01a
PE
4191 Minor fixes for signed vs unsigned integers.
4192 * character.h (MAYBE_UNIFY_CHAR):
4193 * charset.c (maybe_unify_char):
4194 * keyboard.c (read_char, reorder_modifiers):
4195 XINT -> XFASTINT, since the integer must be nonnegative.
4196 * ftfont.c (ftfont_spec_pattern):
4197 * keymap.c (access_keymap, silly_event_symbol_error):
4198 XUINT -> XFASTINT, since the integer must be nonnegative.
4199 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4200 since it makes no difference and we prefer signed.
4201 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4202 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4203 nonnegative.
4204
d6d100dd
SM
42052011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4206
4207 * window.h (Fwindow_frame): Declare.
4208
2b6148e4
PE
42092011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4210
4211 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4212 (SPARE_MEMORY): Always define.
4213 (LARGE_REQUEST): Remove.
4214 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4215
f230ecc9
MR
42162011-06-06 Martin Rudalics <rudalics@gmx.at>
4217
727e958e
MR
4218 * lisp.h: Move EXFUNS for Fframe_root_window,
4219 Fframe_first_window and Fset_frame_selected_window to window.h.
4220
4221 * window.h: Move EXFUNS for Fframe_root_window,
4222 Fframe_first_window and Fset_frame_selected_window here from
4223 lisp.h.
4224
4225 * frame.c (Fwindow_frame, Fframe_first_window)
4226 (Fframe_root_window, Fframe_selected_window)
4227 (Fset_frame_selected_window): Move to window.c.
4228 (Factive_minibuffer_window): Move to minibuf.c.
4229 (Fother_visible_frames_p): New function.
4230
4231 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4232
f230ecc9
MR
4233 * window.c (decode_window, decode_any_window): Move up in code.
4234 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4235 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4236 (Fwindow_buffer): Move up and rewrite doc-string.
4237 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4238 (Fwindow_prev): New functions.
727e958e
MR
4239 (Fwindow_frame): Move here from frame.c. Accept any window as
4240 argument.
4241 (Fframe_root_window, Fframe_first_window)
4242 (Fframe_selected_window): Move here from frame.c. Accept frame
4243 or arbitrary window as argument. Update doc-strings.
4244 (Fminibuffer_window): Move up in code.
4245 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4246 (Fset_frame_selected_window): Move here from frame.c.
4247 Marginal rewrite.
727e958e
MR
4248 (Fselected_window, select_window, Fselect_window): Move up in
4249 code. Minor doc-string fixes.
f230ecc9 4250
4d09bcf6
PE
42512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4252
4253 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4254 Do not assume that spare memory exists; that assumption is valid
4255 only if SYSTEM_MALLOC.
4256 (LARGE_REQUEST): New macro, so that the issue of large requests
4257 is separated from the issue of spare memory.
4258
810928a2
AS
42592011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4260
172418ad
AS
4261 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4262 format. (Bug#8806)
4263
43f862f7
AS
4264 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4265
810928a2
AS
4266 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4267 before statements.
4268
a059fe24
JD
42692011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4270
4271 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4272
4273 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4274
4275 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4276 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4277
989bf368
JB
42782011-06-05 Juanma Barranquero <lekktu@gmail.com>
4279
4280 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4281
4b80f674
CY
42822011-06-04 Chong Yidong <cyd@stupidchicken.com>
4283
4284 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4285 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4286 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4287 New error handlers.
4b80f674
CY
4288 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4289 Obey Vx_select_enable_clipboard_manager. Catch errors in
4290 x_clipboard_manager_save (Bug#8779).
4291 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4292 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4293
99a33b77 42942011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4295
4296 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4297
99a33b77 42982011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4299
4300 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4301 in the current matrix if keep_current_p is non-zero.
4302
8264569d
EZ
43032011-06-04 Eli Zaretskii <eliz@gnu.org>
4304
4305 * bidi.c (bidi_level_of_next_char): Fix last change.
4306
57f97249
EZ
43072011-06-03 Eli Zaretskii <eliz@gnu.org>
4308
fec2107c 4309 Support bidi reordering of text covered by display properties.
57f97249 4310
fec2107c
EZ
4311 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4312 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4313 (bidi_cache_search, bidi_cache_iterator_state)
4314 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4315 (bidi_level_of_next_char, bidi_move_to_visually_next):
4316 Support character positions inside a run of characters covered by a
fec2107c
EZ
4317 display string.
4318 (bidi_paragraph_init, bidi_resolve_explicit_1)
4319 (bidi_level_of_next_char): Call bidi_fetch_char and
4320 bidi_fetch_char_advance instead of FETCH_CHAR and
4321 FETCH_CHAR_ADVANCE.
4322 (bidi_init_it): Initialize new members.
4323 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4324 definitions.
4325 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4326 instead of using explicit *_CHAR codes.
d6d100dd
SM
4327 (bidi_resolve_explicit, bidi_resolve_weak):
4328 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4329 bidirectional text is supported only in multibyte buffers.
4330 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4331 it to initialize the frame_window_p member of struct bidi_it.
4332 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4333 (bidi_resolve_explicit, bidi_resolve_weak)
4334 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4335 bidi_it->nchars is non-positive.
4336 (bidi_level_of_next_char): Don't try to lookup the cache for the
4337 next/previous character if nothing is cached there yet, or if we
4338 were just reseat()'ed to a new position.
c40e2fb2 4339
0e14fe90
EZ
4340 * xdisp.c (set_cursor_from_row): Set start and stop points
4341 according to the row's direction when priming the loop that looks
4342 for the glyph on which to display cursor.
4343 (single_display_spec_intangible_p): Function deleted.
4344 (display_prop_intangible_p): Reimplement to call
4345 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4346 Accept 3 additional arguments needed by handle_display_spec.
4347 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4348 values: lists, `(when COND...)' forms, etc.
4349 (single_display_spec_string_p): Support property values that are
4350 lists with the argument STRING its top-level element.
4351 (display_prop_string_p): Fix the condition for processing a
4352 property that is a list to be consistent with handle_display_spec.
fec2107c 4353 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4354 last portion of handle_display_prop.
4355 (compute_display_string_pos): Accept additional argument
4356 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4357 value of a `display' property is a "replacing spec".
4358 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4359 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4360 the display property, but just return a value indicating whether
4361 the display property will replace the characters it covers.
4362 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4363 frame_window_p members of struct bidi_it.
d6d100dd
SM
4364 (compute_display_string_pos, compute_display_string_end):
4365 New functions.
fec2107c
EZ
4366 (push_it): Accept second argument POSITION, where pop_it should
4367 jump to continue iteration.
4368 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4369
fec2107c
EZ
4370 * keyboard.c (adjust_point_for_property): Adjust the call to
4371 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4372
4373 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4374 (bidi_init_it): Update prototypes.
4375 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4376 (compute_display_string_pos, compute_display_string_end):
4377 Declare prototypes.
fec2107c
EZ
4378 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4379 EMACS_INT.
fc6f18ce 4380
40087514 43812011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4382
57f53182
PE
4383 Malloc failure behavior now depends on size of allocation.
4384 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4385 * lisp.h: Change signatures accordingly.
4386 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4387 All callers changed. (Bug#8762)
4388
4389 * gnutls.c: Use Emacs's memory allocators.
4390 Without this change, the gnutls library would invoke malloc etc.
4391 directly, which causes problems on non-SYNC_INPUT hosts, and which
4392 runs afoul of improving memory_full behavior. (Bug#8761)
4393 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4394 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4395 xfree instead of the default malloc, realloc, free.
4396 (Fgnutls_boot): No need to check for memory allocation failure,
4397 since xmalloc does that for us.
4398
ac32cd99 4399 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4400 * category.c (hash_get_category_set):
4401 * ccl.c (ccl_driver):
4402 * charset.c (Fdefine_charset_internal):
4403 * charset.h (struct charset.hash_index):
4404 * composite.c (get_composition_id, gstring_lookup_cache)
4405 (composition_gstring_put_cache):
4406 * composite.h (struct composition.hash_index):
4407 * dispextern.h (struct image.hash):
4408 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4409 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4410 (hashfn_equal, hashfn_user_defined, make_hash_table)
4411 (maybe_resize_hash_table, hash_lookup, hash_put)
4412 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4413 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4414 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4415 * image.c (make_image, search_image_cache, lookup_image)
4416 (xpm_put_color_table_h):
4417 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4418 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4419 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4420 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4421 * alloc.c (allocate_vectorlike):
4422 Check for overflow in vector size calculations.
4423 * ccl.c (ccl_driver):
4424 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4425 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4426 need to be updated by these changes.
40087514
PE
4427 * fns.c (make_hash_table, maybe_resize_hash_table):
4428 Check for integer overflow with large hash tables.
0de4bb68
PE
4429 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4430 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4431 (SXHASH_REDUCE): New macro.
4432 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4433 Use it instead of discarding useful hash info with large hash values.
4434 (sxhash_float): New function.
4435 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4436 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4437 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4438 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4439 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4440 Adjust signatures to match updated version of code.
4441 (consing_since_gc): Now EMACS_INT, since a single hash table can
4442 use more than INT_MAX bytes.
4443
698d32e2
DN
44442011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4445
4446 Make it possible to build with GCC-4.6+ -O2 -flto.
4447
4448 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4449
fd6fa53f
SM
44502011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4451
4452 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4453 Call minibuffer-inactive-mode.
4454
864db017
JB
44552011-05-31 Juanma Barranquero <lekktu@gmail.com>
4456
4457 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4458 Update dependencies.
4459
2ad0baf4
DN
44602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4461
4462 * data.c (init_data): Remove code for UTS, this system is not
4463 supported anymore.
4464
4fcc2638
DN
44652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4466
4467 Don't force ./temacs to start in terminal mode.
4468
4469 * frame.c (make_initial_frame): Initialize faces in all cases, not
4470 only when CANNOT_DUMP is defined.
4471 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4472
c56e0fd5
DN
44732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4474
4475 * dispnew.c (add_window_display_history): Use const for the string
4476 pointer. Remove declaration, not needed.
4477
333d54da 44782011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4479
55d4c1b2 4480 Use 'inline', not 'INLINE'.
333d54da 4481 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4482 * alloc.c, fontset.c (INLINE): Remove.
4483 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4484 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4485 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4486 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4487 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4488
738db178
DN
44892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4490
4491 Make it possible to run ./temacs.
4492
4493 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4494 syms_of_callproc does the same thing. Remove test for
4495 "initialized", do it in the caller.
4496 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4497
620c53a6
SM
44982011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4499
4500 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4501 (read_minibuf): Use get_minibuffer.
4502 (syms_of_minibuf): Use DEFSYM.
4503 (Qmetadata): New var.
4504 * data.c (Qbuffer): Don't make it static.
4505 (syms_of_data): Use DEFSYM.
4506
e003a292
PE
45072011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4508
4509 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4510 (CCL_CODE_MIN): New macro.
4511
ed008a6d
PE
45122011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4513
3687c2ef
PE
4514 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4515
ed008a6d
PE
4516 * eval.c (Qdebug): Now static.
4517 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4518 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4519 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4520
d66c4c7c
CY
45212011-05-29 Chong Yidong <cyd@stupidchicken.com>
4522
4523 * image.c: Various fixes to ImageMagick code comments.
4524 (Fimagemagick_types): Doc fix.
4525
5fbc2025
PE
45262011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4527
0196f88a
PE
4528 Minor fixes prompted by GCC 4.6.0 warnings.
4529
4530 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4531
5fbc2025
PE
4532 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4533 (x_clipboard_manager_save_all): Move extern decl to ...
4534 * xterm.h: ... here, so that it can be checked for consistency.
4535
1dd3c2d9
CY
45362011-05-29 Chong Yidong <cyd@stupidchicken.com>
4537
4538 * xselect.c (x_clipboard_manager_save_frame)
4539 (x_clipboard_manager_save_all): New functions.
4540 (Fx_clipboard_manager_save): Lisp function deleted.
4541
4542 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4543 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4544
4545 * xterm.h: Update prototype.
4546
5ba6571d
WX
45472011-05-28 William Xu <william.xwl@gmail.com>
4548
4549 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4550 exiting (Bug#8239).
4551
3eaff834
JM
45522011-05-28 Jim Meyering <meyering@redhat.com>
4553
e1900994 4554 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4555 * fns.c (to_uchar): Define.
4556 (crypto_hash_function): Use it to convert some newly-signed
4557 variables to unsigned, to avoid sign-extension bugs. For example,
4558 without this change, (md5 "truc") would evaluate to
4559 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4560 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4561 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4562
0f6990a7
PE
45632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4564
4565 Integer overflow fixes.
c8a9ca5a 4566
08686060
PE
4567 * dbusbind.c: Serial number integer overflow fixes.
4568 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4569 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4570 to hold a serial number that is too large for a fixnum.
4571 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4572 Check for serial numbers out of range. Decode any serial number
59568bf0 4573 that was so large that it became a float. (Bug#8722)
08686060 4574
2d1fc3c7
PE
4575 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4576 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4577 Use XFASTINT rather than XUINT when numbers are nonnegative.
4578 (xd_append_arg, Fdbus_method_return_internal):
4579 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4580 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4581 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4582 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4583 (Bug#8722)
2d1fc3c7 4584
c8a9ca5a
PE
4585 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4586
519e1d69
PE
4587 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4588
30569699
PE
4589 ccl: add integer overflow checks
4590 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4591 (IN_INT_RANGE): New macros.
4592 (ccl_driver): Use them to check for integer overflow when
4593 decoding a CCL program. Many of the new checks are whether XINT (x)
4594 fits in int; it doesn't always, on 64-bit hosts. The new version
4595 doesn't catch all possible integer overflows, but it's an
847044ea 4596 improvement. (Bug#8719)
30569699 4597
c11285dc
PE
4598 * alloc.c (make_event_array): Use XINT, not XUINT.
4599 There's no need for unsigned here.
4600
fdccd48e
PE
4601 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4602 This follows up to the 2011-05-06 change that substituted uintptr_t
4603 for EMACS_INT. This case wasn't caught back then.
4604
37910ab2
PE
4605 Rework Fformat to avoid integer overflow issues.
4606 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4607 now (part of C89). Include <verify.h>.
4608 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4609 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4610 (Fformat): Avoid the prepass trying to compute sizes; it was only
4611 approximate and thus did not catch overflow reliably. Instead, walk
4612 through the format just once, formatting and computing sizes as we go,
4613 checking for integer overflow at every step, and allocating a larger
4614 buffer as needed. Keep track separately whether the format is
4615 multibyte. Keep only the most-recently calculated precision, rather
4616 than them all. Record whether each argument has been converted to
4617 string. Use EMACS_INT, not int, for byte and char and arg counts.
4618 Support field widths and precisions larger than INT_MAX. Avoid
4619 sprintf's undefined behavior with conversion specifications such as %#d
4620 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4621 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4622 formatting out-of-range floating point numbers with int
9173deec 4623 formats. (Bug#8668)
37910ab2 4624
2e6578fb
PE
4625 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4626
0ae6bdee
PE
4627 * data.c: Avoid integer truncation in expressions involving floats.
4628 * data.c: Include <intprops.h>.
4629 (arith_driver): When there's an integer overflow in an expression
4630 involving floating point, convert the integers to floating point
4631 so that the resulting value does not suffer from catastrophic
4632 integer truncation. For example, on a 64-bit host (* 4
4633 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4634 Do not rely on undefined behavior after integer overflow.
4635
de883a70
PE
4636 merge count_size_as_multibyte, parse_str_to_multibyte
4637 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4638 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4639 Check for integer overflow.
4640 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4641 since it's now a duplicate of the other. This is more of
4642 a character than a buffer op, so better that it's in character.c.
4643 * fns.c, print.c: Adjust to above changes.
4644
2ff916cb
PE
46452011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4646
4647 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4648
f1b54466
PE
46492011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4650
fb1ac845
PE
4651 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4652 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4653 (x_clipboard_manager_save): Now static.
4654 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4655
f1b54466
PE
4656 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4657 (crypto_hash_function): Now static.
4658 Fix pointer signedness problems. Avoid unnecessary initializations.
4659
a9f737ee
CY
46602011-05-27 Chong Yidong <cyd@stupidchicken.com>
4661
4662 * termhooks.h (Vselection_alist): Make it terminal-local.
4663
4664 * terminal.c (create_terminal): Initialize it.
4665
4666 * xselect.c: Support for clipboard managers.
4667 (Vselection_alist): Move to termhooks.h as terminal-local var.
4668 (LOCAL_SELECTION): New macro.
4669 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4670 (symbol_to_x_atom): Remove gratuitous arg.
4671 (x_handle_selection_request, lisp_data_to_selection_data)
4672 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4673 (x_own_selection, x_get_local_selection, x_convert_selection):
4674 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4675 (some_frame_on_display): Delete unused function.
4676 (Fx_own_selection_internal, Fx_get_selection_internal)
4677 (Fx_disown_selection_internal, Fx_selection_owner_p)
4678 (Fx_selection_exists_p): New optional frame arg.
4679 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4680 (x_handle_selection_clear): Don't treat other terminals with the
4681 same keyboard specially. Use the terminal-local Vselection_alist.
4682 (x_clear_frame_selections): Use Frun_hook_with_args.
4683
4684 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4685
4686 * xterm.h: Add support for those atoms.
4687
e067f0c1
CY
46882011-05-26 Chong Yidong <cyd@stupidchicken.com>
4689
4690 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4691 (converted_selections, conversion_fail_tag): New global variables.
4692 (x_selection_request_lisp_error): Free the above.
4693 (x_get_local_selection): Remove unnecessary code.
4694 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4695 of converted selections stored in converted_selections.
4696 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4697 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4698 (x_convert_selection): New function.
4699 (x_handle_selection_event): Simplify.
4700 (x_get_foreign_selection): Don't ignore incoming requests while
4701 waiting for an answer; this will fail when we implement
4702 SAVE_TARGETS, and seems unnecessary anyway.
4703 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4704 (Vx_sent_selection_functions): Doc fix.
4705
0f4aebc0
LL
47062011-05-26 Leo Liu <sdl.web@gmail.com>
4707
4708 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4709
e61124cd
YM
47102011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4711
4712 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4713
4714 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4715 for fringe update if it has periodic bitmap.
ac389d0c 4716 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4717 and fringe_bitmap_periodic_p.
4718
4719 * fringe.c (get_fringe_bitmap_data): New function.
4720 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4721 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4722 row. Mark glyph row for fringe update if periodicity changed.
4723
4724 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4725 for fringe update unless it has periodic bitmap.
4726
f16d9837
KH
47272011-05-25 Kenichi Handa <handa@m17n.org>
4728
4729 * xdisp.c (get_next_display_element): Set correct it->face_id for
4730 a static composition.
4731
e1b90ef6
LL
47322011-05-24 Leo Liu <sdl.web@gmail.com>
4733
4734 * deps.mk (fns.o):
4735 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4736
4737 * fns.c (crypto_hash_function, Fsha1): New function.
4738 (Fmd5): Use crypto_hash_function.
4739 (syms_of_fns): Add Ssha1.
4740
7400048f
PE
47412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4742
4743 * gnutls.c: Remove unused macros.
4744 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4745 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4746 Remove macros that are defined and never used.
4747 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4748
abb71cf4
CY
47492011-05-22 Chong Yidong <cyd@stupidchicken.com>
4750
4751 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4752 (Fx_get_selection_internal): Minor cleanup.
4753 (Fx_own_selection_internal): Rename arguments for consistency with
4754 select.el.
4755
6307db39
PE
47562011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4757
4758 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4759
f3d4e0a4
CY
47602011-05-22 Chong Yidong <cyd@stupidchicken.com>
4761
4762 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4763
4d8ade89
YM
47642011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4765
4766 * dispnew.c (scrolling_window): Don't exclude the case that the
4767 last enabled row in the desired matrix touches the bottom boundary.
4768
32078c8d
GM
47692011-05-21 Glenn Morris <rgm@gnu.org>
4770
4771 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4772 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4773 and add some more files.
32078c8d 4774
7285dc67
EZ
47752011-05-20 Eli Zaretskii <eliz@gnu.org>
4776
4777 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4778 report_file_error introduced by the change from 2011-05-07.
4779
89d1bd22
PE
47802011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4781
4782 * systime.h (Time): Define only if emacs is defined.
4783 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4784 where the include path doesn't have X11/X.h by default. See
4785 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4786
e23640bb 47872011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4788
4789 * composite.c (find_automatic_composition): Fix previous change.
4790
b9704ad9
GM
47912011-05-20 Glenn Morris <rgm@gnu.org>
4792
4793 * lisp.mk: New file, split from Makefile.in.
4794 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4795 (shortlisp): Remove.
4796 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4797
4a720484
GM
47982011-05-19 Glenn Morris <rgm@gnu.org>
4799
4800 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4801 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4802 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4803 (lisp): Set the order to that of loadup.el.
4804 (shortlisp): Make it a copy of $lisp.
4805 (SOME_MACHINE_LISP): Remove.
4806 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4807 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4808
a28d4396
KH
48092011-05-18 Kenichi Handa <handa@m17n.org>
4810
4811 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4812 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4813 (find_automatic_composition): Mostly rewrite for efficiency.
4814
a2b1fa8e
JB
48152011-05-18 Juanma Barranquero <lekktu@gmail.com>
4816
4817 * makefile.w32-in: Update dependencies.
4818
8e1f5610
CS
48192011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4820
4821 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4822 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4823
7025ee00 48242011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4825
cdfa6eab
PE
4826 Fix some integer overflow issues, such as string length overflow.
4827
06d6db33
PE
4828 * insdel.c (count_size_as_multibyte): Check for string overflow.
4829
2b4560a8
PE
4830 * character.c (lisp_string_width): Check for string overflow.
4831 Use EMACS_INT, not int, for string indexes and lengths; in
4832 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4833 the resulting string length overflows an EMACS_INT; instead,
4834 report a string overflow if no precision given. When checking for
4835 precision exhaustion, use a check that cannot possibly have
4836 integer overflow. (Bug#8675)
4837 * character.h (lisp_string_width): Adjust to new signature.
4838
cb93f9be
PE
4839 * alloc.c (string_overflow): New function.
4840 (Fmake_string): Use it. This doesn't change behavior, but saves
4841 a few bytes and will simplify future changes.
4842 * character.c (string_escape_byte8): Likewise.
4843 * lisp.h (string_overflow): New decl.
4844
1a1f3366
PE
4845 Fixups, following up to the user-interface timestamp change.
4846 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4847 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4848 * msdos.c (mouse_get_pos): Likewise.
4849 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4850 * w32gui.h (Time): Define by including "systime.h" rather than by
4851 declaring it ourselves. (Bug#8664)
4852
d4e3e4d3
PE
4853 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4854 * image.c (clear_image_cache): Likewise.
4855
f6a24d19
PE
4856 * term.c (term_mouse_position): Don't assume time_t wraparound.
4857
08dc5ae6
PE
4858 Be more systematic about user-interface timestamps.
4859 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4860 and sometimes 'EMACS_UINT', to represent these timestamps.
4861 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4862 This makes the code easier to follow, and makes it easier to catch
4863 integer overflow bugs such as Bug#8664.
4864 * frame.c (Fmouse_position, Fmouse_pixel_position):
4865 Use Time, not unsigned long, for user-interface timestamps.
4866 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4867 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4868 * keyboard.h (last_event_timestamp): Likewise.
4869 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4870 * menu.h (xmenu_show): Likewise.
4871 * term.c (term_mouse_position): Likewise.
4872 * termhooks.h (struct input_event.timestamp): Likewise.
4873 (struct terminal.mouse_position_hook): Likewise.
4874 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4875 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4876 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4877 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4878 what it was before.
4879 * menu.h, termhooks.h: Include "systime.h", for Time.
4880
8e55734a
PE
4881 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4882 Don't assume that the difference between two unsigned long values
4883 can fit into an integer. At this point, we know button_down_time
4884 <= event->timestamp, so the difference must be nonnegative, so
4885 there's no need to cast the result if double-click-time is
4886 nonnegative, as it should be; check that it's nonnegative, just in
4887 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4888 apart (about 25 days). (Bug#8664)
8e55734a 4889
841f1b75 4890 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4891 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4892
3e26f69c
PE
4893 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4894 that always fit in int. Use a sentinel instead of a counter, to
4895 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4896 * frame.h (struct frame): Use int for menu_bar_items_used
4897 instead of EMACS_INT, since it always fits in int.
3e26f69c 4898
5cc152c0
PE
4899 * menu.c (grow_menu_items): Check for int overflow.
4900
d89eb65e
PE
4901 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4902
5235bd3e
PE
4903 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4904 Before, the code was not consistent. These values cannot exceed
4905 2**31 - 1 so there's no need to make them unsigned.
4906 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4907 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4908 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4909 as modifiers.
4910 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4911
bc827e23
PE
4912 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4913 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4914 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4915 presumably because the widths might not match.
4916
78eb494e
PE
4917 * window.c (size_window): Avoid needless test at loop start.
4918
04f2d78b
CB
49192011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4920
4921 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4922
d2fc7e3d 49232011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4924
4925 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4926
d2fc7e3d 49272011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4928
4929 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4930 `width' to `bar_area_x' and `bar_area_width', respectively.
4931 (x_scroll_run): Take account of fringe background extension.
4932
04f2d78b
CB
4933 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4934 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4935 `bar_area_width', respectively.
4936 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4937 background extension.
4938
79b70037
GM
49392011-05-10 Jim Meyering <meyering@redhat.com>
4940
4941 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4942
2f142cc5
JB
49432011-05-10 Juanma Barranquero <lekktu@gmail.com>
4944
4945 * image.c (Finit_image_library): Return t for built-in image types,
4946 like pbm and xbm. (Bug#8640)
4947
57679c86
AS
49482011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4949
4950 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4951
888c9e86
EZ
49522011-05-07 Eli Zaretskii <eliz@gnu.org>
4953
b0512a1d
EZ
4954 * w32console.c (Fset_screen_color): Doc fix.
4955 (Fget_screen_color): New function.
4956 (syms_of_ntterm): Defsubr it.
4957
7285dc67
EZ
4958 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4959 unlink the temporary file if Fcall_process didn't create it in the
4960 first place.
4961 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4962 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4963 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4964 cue to call_process_cleanup not to close that handle.
4965
4d3fcc8e
BK
49662011-05-07 Ben Key <bkey76@gmail.com>
4967
4968 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4969 one of two shell specific rules, either bootstrap-temacs-CMD or
4970 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4971 to the previous implementation of the bootstrap-temacs rule.
4972 The bootstrap-temacs-CMD rule is similar to the previous
4973 implementation of the bootstrap-temacs rule except that it
4974 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4975 variable.
4976
4977 These changes, along with some changes to nt/configure.bat,
4978 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4979 earlier fix to add support for --cflags and --ldflags options
4980 that include quotes so that it works whether make uses cmd or
4981 sh as the shell.
4982
b4289b64
MA
49832011-05-06 Michael Albinus <michael.albinus@gmx.de>
4984
4985 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4986 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4987 is a constant.
4988 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4989 a string. Handle both cases.
4990 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4991 (Fdbus_register_method): Use Qinvalid_function.
4992
af4c0e28
JB
49932011-05-06 Juanma Barranquero <lekktu@gmail.com>
4994
4995 * makefile.w32-in: Update dependencies.
4996 (LISP_H): Add inttypes.h and stdin.h.
4997 (PROCESS_H): Add unistd.h.
4998
c51453d9
EZ
49992011-05-06 Eli Zaretskii <eliz@gnu.org>
5000
5001 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5002 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5003
8ff0ac3c 50042011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5005
4c4b566b
PE
5006 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5007
aab2b9b5
PE
5008 * term.c (vfatal): Remove stray call to va_end.
5009 It's not needed and the C Standard doesn't allow it here anyway.
5010
c378da0b
PE
5011 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5012 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5013
288b08c7
PE
5014 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5015 bytes.
5016
e3601888
PE
5017 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5018
db6c0e74
PE
5019 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5020
dd5963ea
PE
5021 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5022
88c9450f
PE
5023 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5024
2f9442b8
PE
5025 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5026
c032b5f8
PE
5027 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5028 * charset.c (Fdefine_charset_internal): Don't initialize
5029 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5030 32-bit int (Bug#8600).
a108c10b
PE
5031
5032 * lread.c (read_integer): Be more consistent with string-to-number.
5033 Use string_to_number to do the actual conversion; this avoids
5034 rounding errors and fixes some other screwups. Without this fix,
5035 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5036 (digit_to_number): Move earlier, for benefit of read_integer.
5037 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5038 not a digit in any supported base. (Bug#8602)
a108c10b 5039
ad5f9eea
PE
5040 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5041
aec1708a
PE
5042 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5043 to match comment at start of function. This also removes a
5044 GCC warning about overflow in a 32+64-bit port.
5045
47be4ab5
PE
5046 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5047
371cac43
PE
5048 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5049 Reported by Stefan Monnier in
5050 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5051 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5052 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5053
d01a7826
PE
5054 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5055 (EMACS_UINTPTR): Likewise, with uintptr_t.
5056
7fd47d5c
PE
5057 * lisp.h: Prefer 64-bit EMACS_INT if available.
5058 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5059 on 32-bit hosts that have 64-bit int, so that they can access
5060 large files.
122b0c86
PE
5061 However, temporarily disable this change unless the temporary
5062 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5063
8727937b
PE
5064 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5065
8ac068ac
PE
5066 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5067 This removes an assumption that EMACS_INT and long are the same
5068 width as pointers. The assumption is true for Emacs porting targets
5069 now, but we want to make other targets possible.
5070 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5071 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5072 In the rest of the code, change types of integers that hold casted
5073 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5074 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5075 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5076 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5077 No need to cast type when ORing.
5078 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5079 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5080 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5081 assume EMACS_INT is the same width as char *.
5082 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5083 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5084 Remove no-longer-needed casts.
5085 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5086 (xg_tool_bar_help_callback, xg_make_tool_item):
5087 Use EMACS_INTPTR to hold an integer
5088 that will be cast to void *; this can avoid a GCC warning
5089 if EMACS_INT is not the same width as void *.
5090 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5091 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5092 (current_message_1, set_message_1):
5093 Use a local to convert to proper width without a cast.
5094 * xmenu.c (dialog_selection_callback): Likewise.
5095
ede49d71
PE
5096 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5097 Also, don't assume VALBITS / RAND_BITS is less than 5,
5098 and don't rely on undefined behavior when shifting a 1 left into
5099 the sign bit.
5100 * lisp.h (get_random): Change signature to match.
5101
2f30ecd0
PE
5102 * lread.c (hash_string): Use size_t, not int, for hash computation.
5103 Normally we prefer signed values; but hashing is special, because
5104 it's better to use unsigned division on hash table sizes so that
5105 the remainder is nonnegative. Also, size_t is the natural width
5106 for hashing into memory. The previous code used 'int', which doesn't
5107 retain enough info to hash well into very large tables.
5108 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5109
2a866e7b
PE
5110 * dbusbind.c: Don't possibly lose pointer info when converting.
5111 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5112 Use XPNTR rather than XHASH, so that the high-order bits of
5113 the pointer aren't lost when converting through void *.
5114
51639eac
PE
5115 * eval.c (Fautoload): Don't double-shift a pointer.
5116
92394119
PE
5117 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5118
dbdb9a7c
JB
51192011-05-06 Juanma Barranquero <lekktu@gmail.com>
5120
5121 * gnutls.c (DEF_GNUTLS_FN):
5122 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5123
db7a0b4f
AS
51242011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5125
5126 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5127 marker. (Bug#8610)
5128
f7ff1b0f 51292011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5130
5131 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5132 New version that can reserve upto 2GB of heap space.
5133
f7ff1b0f 51342011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5135
5136 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5137
639c109b
TZ
51382011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5139
5140 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5141 `gnutls_certificate_set_x509_key_file'.
5142
d2127135
JB
51432011-05-05 Juanma Barranquero <lekktu@gmail.com>
5144
5145 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5146 Update dependencies.
5147
e968f4f3
JB
51482011-05-04 Juanma Barranquero <lekktu@gmail.com>
5149
5150 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5151 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5152 Remove unused parameter `fildes'.
5153 * process.c (read_process_output, send_process): Don't pass it.
5154
84d358f0
JB
51552011-05-04 Juanma Barranquero <lekktu@gmail.com>
5156
5157 Fix previous change: the library cache is defined in w32.c.
5158 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5159 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5160
0898ca10
JB
51612011-05-04 Juanma Barranquero <lekktu@gmail.com>
5162
5163 Implement dynamic loading of GnuTLS on Windows.
5164
5165 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5166 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5167 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5168 Declare.
5169
5170 * gnutls.c (Qgnutls_dll): Define.
5171 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5172 (gnutls_*): Declare function pointers.
5173 (init_gnutls_functions): New function to initialize function pointers.
5174 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5175 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5176 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5177 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5178 (emacs_gnutls_write, emacs_gnutls_read)
5179 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5180 (Fgnutls_available_p): New function.
5181 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5182 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5183 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5184
5185 * image.c: Include w32.h.
5186 (Vimage_type_cache): Delete.
5187 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5188 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5189 (w32_delayed_load): Move to w32.c.
5190
5191 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5192
5193 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5194 (w32_delayed_load): Move from image.c. When loading a library, record
5195 its filename in the :loaded-from property of the library id.
5196 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5197 Initialize and staticpro them.
5198 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5199
5200 * process.c: Include lisp.h before w32.h, not after.
5201 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5202 instead of gnutls_record_check_pending.
5203
5204 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5205
ff4de4aa
TZ
52062011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5207
5208 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5209 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5210 as passed in.
5211
abe95abb
JD
52122011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5213
5214 * xterm.c (x_set_frame_alpha): Do not set property on anything
5215 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5216
e16e55d4
JB
52172011-05-02 Juanma Barranquero <lekktu@gmail.com>
5218
5219 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5220
bafcf6a5
JB
52212011-05-02 Juanma Barranquero <lekktu@gmail.com>
5222
5223 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5224 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5225 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5226 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5227 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5228 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5229 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5230 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5231 (Qgnutls_bootprop_callbacks_verify): Make static.
5232
e7a6747f
AS
52332011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5234
19ed11ba
AS
5235 * callproc.c: Indentation fixup.
5236
e7a6747f 5237 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5238 (wait_for_termination, interruptible_wait_for_termination):
5239 Move after wait_for_termination_1.
e7a6747f 5240
1ef14cb4
LMI
52412011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5242
5243 * sysdep.c (interruptible_wait_for_termination): New function
5244 which is like wait_for_termination, but allows keyboard
5245 interruptions.
5246
5247 * callproc.c (Fcall_process): Add (:file "file") as an option for
5248 the STDOUT buffer.
5249 (Fcall_process_region): Ditto.
5250
330d880c
EZ
52512011-04-30 Eli Zaretskii <eliz@gnu.org>
5252
8db90b73
EZ
5253 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5254 rather than `XVECTOR (FOO)->size'.
5255
330d880c
EZ
5256 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5257 inttypes.h, as a gnulib replacement is used if it not available in
5258 system headers.
5259
15cbd324
EZ
52602011-04-21 Eli Zaretskii <eliz@gnu.org>
5261
5262 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5263 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5264 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5265
5266 * coding.c (coding_alloc_by_realloc): Error out if destination
5267 will grow beyond MOST_POSITIVE_FIXNUM.
5268 (decode_coding_emacs_mule): Abort if there isn't enough place in
5269 charbuf for the composition carryover bytes. Reserve an extra
5270 space for up to 2 characters produced in a loop.
5271 (decode_coding_iso_2022): Abort if there isn't enough place in
5272 charbuf for the composition carryover bytes.
5273
52742011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5275
ae940cca
EZ
5276 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5277 aborting when %lld or %lll format is passed.
5278 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5279 %llo or %llx format is passed. (Bug#8545)
5280
03ab8921
EZ
5281 * window.c (window_scroll_line_based): Use a marker instead of
5282 simple variables to record original value of point. (Bug#7952)
5283
afda1437
EZ
5284 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5285 produced by %s or %c overflows available buffer space. (Bug#8545)
5286
f76dee0c
PE
52872011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5288
5289 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5290 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5291
fdc5744d
JB
52922011-04-28 Juanma Barranquero <lekktu@gmail.com>
5293
5294 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5295
638f053a
JB
52962011-04-28 Juanma Barranquero <lekktu@gmail.com>
5297
5298 * keyboard.c (Qdelayed_warnings_hook): Define.
5299 (command_loop_1): Run `delayed-warnings-hook'
5300 if Vdelayed_warnings_list is non-nil.
5301 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5302 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5303
d178f871
EZ
53042011-04-28 Eli Zaretskii <eliz@gnu.org>
5305
5306 * doprnt.c (doprnt): Don't return value smaller than the buffer
5307 size if the message was truncated. (Bug#8545).
5308
b124fd93
JB
53092011-04-28 Juanma Barranquero <lekktu@gmail.com>
5310
5311 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5312 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5313
e810457d
PE
53142011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5315
5316 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5317
ea51cceb
JB
53182011-04-27 Juanma Barranquero <lekktu@gmail.com>
5319
5320 * makefile.w32-in: Update dependencies.
5321
94dcfacf
EZ
53222011-04-27 Eli Zaretskii <eliz@gnu.org>
5323
5324 Improve `doprnt' and its usage. (Bug#8545)
5325 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5326 `format_end'. Remove support for %l as a conversion specifier.
5327 Don't use xrealloc. Improve diagnostics when the %l size modifier
5328 is used. Update the commentary.
5329
5330 * eval.c (verror): Simplify calculation of size_t.
5331
5332 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5333 messages.
5334
f61f41d7
PE
53352011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5336
5337 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5338 change.
5339
96fb4434
PE
53402011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5341
5342 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5343 This makes this file independent of the recent pseudovector change.
5344
671875da 53452011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5346
69e9b5a3
PE
5347 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5348
b5f869a7 5349 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5350 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5351 Remove unused local.
c8926152 5352 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5353
841a1577 5354 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5355 GCC 4.6.0 optimizes based on type-based alias analysis.
5356 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5357 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5358 != &v->size, and therefore "v->size = 1; b->size = 2; return
5359 v->size;" must therefore return 1. This assumption is incorrect
5360 for Emacs, since it type-puns struct Lisp_Vector * with many other
5361 types. To fix this problem, this patch adds a new type struct
f904488f 5362 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5363 and pseudovectors, and helps optimizing compilers not get fooled
5364 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5365 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5366 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5367 the size member.
eab3844f
PE
5368 (XSETPVECTYPE): Rewrite in terms of new macro.
5369 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5370 This is a bit clearer, and further avoids the possibility of
5371 undesirable aliasing.
5372 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5373 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5374 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5375 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5376 (ASIZE): Now uses header.size rather than size.
5377 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5378 to avoid the hassle of writing XVECTOR (foo)->header.size.
5379 (struct vectorlike_header): New type.
eab3844f
PE
5380 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5381 object, to help avoid aliasing.
5382 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5383 (SUBRP): Likewise, since Lisp_Subr is a special case.
5384 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5385 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5386 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5387 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5388 changed to be "header.size" and "header.next".
5389 * buffer.h (struct buffer): Likewise.
5390 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5391 * frame.h (struct frame): Likewise.
5392 * process.h (struct Lisp_Process): Likewise.
5393 * termhooks.h (struct terminal): Likewise.
5394 * window.c (struct save_window_data, struct saved_window): Likewise.
5395 * window.h (struct window): Likewise.
5396 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5397 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5398 * buffer.c (init_buffer_once): Likewise.
5399 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5400 special case.
5401 * process.c (Fformat_network_address): Use local var for size,
5402 for brevity.
5403
0df1eac5
PE
5404 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5405
847ab9d1 5406 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5407 * data.c (atof): Remove decl; no longer used or needed.
5408 (digit_to_number): Move to lread.c.
5409 (Fstring_to_number): Use new string_to_number function, to be
5410 consistent with how the Lisp reader treats infinities and NaNs.
5411 Do not assume that floating-point numbers represent EMACS_INT
5412 without losing information; this is not true on most 64-bit hosts.
5413 Avoid double-rounding errors, by insisting on integers when
5414 parsing non-base-10 numbers, as the documentation specifies.
5415 * lisp.h (string_to_number): New decl, replacing ...
5416 (isfloat_string): Remove.
bc0a5c13 5417 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5418 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5419 appears to have been a coding error. Similarly, do not accept
5420 strings like +-1e0 as floating point numbers. Do not report
5421 overflow for integer overflows unless the base is not 10 which
5422 means we have no simple and reliable way to continue.
5423 Break out the floating-point parsing into a new
5424 function string_to_number, so that Fstring_to_number parses
5425 floating point numbers consistently with the Lisp reader.
04f2d78b 5426 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5427 (E_CHAR, EXP_INT): Remove, replacing with ...
5428 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5429 (string_to_number): New function, replacing isfloat_string.
5430 This function checks for valid syntax and produces the resulting
5431 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5432 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5433 so that overflow for non-base-10 numbers is reported only when
5434 there's no portable and simple way to convert to floating point.
452f4150 5435
67769ffc
PE
5436 * textprop.c (set_text_properties_1): Rewrite for clarity,
5437 and to avoid GCC warning about integer overflow.
5438
c20db43f
PE
5439 * intervals.h (struct interval): Use EMACS_INT for members
5440 where EMACS_UINT might cause problems. See
5441 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5442 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5443 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5444 All uses changed.
37aa2f85
PE
5445 (offset_intervals): Tell GCC not to worry about length overflow
5446 when negating a negative length.
c20db43f 5447
2538aa2f
PE
5448 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5449 (overrun_check_free): Likewise.
5450
f2d3008d
PE
5451 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5452 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5453 word size.
5454
ec8df744
PE
5455 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5456 (gnutls_make_error): Rename local to avoid shadowing.
5457 (gnutls_emacs_global_deinit): ifdef out; not used.
5458 (Fgnutls_boot): Use const for pointer to readonly storage.
5459 Comment out unused local. Fix pointer signedness problems.
5460
640ee02d
PE
5461 * lread.c (openp): Don't stuff size_t into an 'int'.
5462 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5463 about possible signed overflow.
5464
6048fb2a
PE
5465 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5466 (GDK_KEY_g): Don't define if already defined.
5467 (xg_prepare_tooltip): Avoid pointer signedness problem.
5468 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5469
fa3c87e1
PE
5470 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5471 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5472
2172544b
PE
5473 * xfns.c (Fx_window_property): Simplify a bit,
5474 to make a bit faster and to avoid GCC 4.6.0 warning.
5475 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5476
9b821a21
PE
5477 * fns.c (internal_equal): Don't assume size_t fits in int.
5478
3c616cfa
PE
5479 * alloc.c (compact_small_strings): Tighten assertion a little.
5480
c2982e87
PE
5481 Replace pEd with more-general pI, and fix some printf arg casts.
5482 * lisp.h (pI): New macro, generalizing old pEd macro to other
5483 conversion specifiers. For example, use "...%"pI"d..." rather
5484 than "...%"pEd"...".
5485 (pEd): Remove. All uses replaced with similar uses of pI.
5486 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5487 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5488 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5489 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5490 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5491 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5492 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5493 64-bit hosts.
5494 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5495 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5496 * print.c (safe_debug_print, print_object): Likewise.
5497 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5498 to int.
6f04d126
PE
5499 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5500 avoiding the 0 flag, which is not portable.
c2982e87
PE
5501 * process.c (Fmake_network_process): Use pI to avoid cast.
5502 * region-cache.c (pp_cache): Likewise.
5503 * xdisp.c (decode_mode_spec): Likewise.
5504 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5505 behavior on 64-bit hosts with printf arg.
6f04d126 5506 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5507 (x_stop_queuing_selection_requests): Likewise.
5508 (x_get_window_property): Don't truncate byte count to an 'int'
5509 when tracing.
0b432f21 5510
5e073ec7
PE
5511 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5512 here, since it parses constructs like leading '-' and spaces,
5513 which are not wanted; and it overflows with large numbers.
5514 Instead, simply match F[0-9]+, which is what is wanted anyway.
5515
36372bf9
PE
5516 * alloc.c: Remove unportable assumptions about struct layout.
5517 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5518 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5519 (allocate_vectorlike, make_pure_vector): Use the new macros,
5520 plus offsetof, to remove unportable assumptions about struct layout.
5521 These assumptions hold on all porting targets that I know of, but
5522 they are not guaranteed, they're easy to remove, and removing them
5523 makes further changes easier.
5524
0b432f21
PE
5525 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5526 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5527 (string_overrun_cookie): Now const. Use initializers that
5528 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5529 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5530 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5531 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5532 multiple of sizeof (EMACS_INT); it need not be, if
5533 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5534 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5535
895009e1
JB
55362011-04-26 Juanma Barranquero <lekktu@gmail.com>
5537
5538 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5539
6a7a1b0b
TZ
55402011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5541
5542 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5543 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5544 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5545
841a1577 55462011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5547
5548 * lisp.h (Qdebug): List symbol.
895009e1 5549 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5550 * keyboard.c (debug-on-event): New variable.
5551 (handle_user_signal): Break into debugger when debug-on-event
5552 matches the current signal symbol.
5553
f2d3ba6f
DN
55542011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5555
5556 * alloc.c (check_sblock, check_string_bytes)
5557 (check_string_free_list): Convert to standard C.
5558
42ce4c63
TZ
55592011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5560
5561 * w32.c (emacs_gnutls_push): Fix typo.
5562
825cd63c
EZ
55632011-04-25 Eli Zaretskii <eliz@gnu.org>
5564
fb11d64d
EZ
5565 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5566 "cast to pointer from integer of different size".
5567
825cd63c
EZ
5568 Improve doprnt and its use in verror. (Bug#8545)
5569 * doprnt.c (doprnt): Document the set of format control sequences
5570 supported by the function. Use SAFE_ALLOCA instead of always
5571 using `alloca'.
5572
5573 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5574 is one byte too soon. Don't use xrealloc; instead xfree and
5575 xmalloc anew.
5576
e061a11b
TZ
55772011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5578
5579 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5580 callbacks stage.
5581
5582 * gnutls.c: Renamed global_initialized to
5583 gnutls_global_initialized. Added internals for the
5584 :verify-hostname-error, :verify-error, and :verify-flags
5585 parameters of `gnutls-boot' and documented those parameters in the
5586 docstring. Start callback support.
9173deec
JB
5587 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5588 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5589 on error. Return error code.
e061a11b
TZ
5590 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5591 (emacs_gnutls_read): Likewise.
5592 (Fgnutls_boot): Return handshake error code.
5593 (emacs_gnutls_handle_error): New function.
5594 (wsaerror_to_errno): Likewise.
5595
5596 * w32.h (emacs_gnutls_pull): Add prototype.
5597 (emacs_gnutls_push): Likewise.
5598
5599 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5600 (emacs_gnutls_push): Likewise.
5601
56022011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5603
5604 * process.c (wait_reading_process_output): Check if GnuTLS
5605 buffered some data internally if no FDs are set for TLS
5606 connections.
5607
5608 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5609 (LIBS): Link to USER_LIBS.
5610 ($(BLD)/gnutls.$(0)): New target.
5611
fa6996bc
EZ
56122011-04-24 Eli Zaretskii <eliz@gnu.org>
5613
eb35682e
EZ
5614 * xdisp.c (handle_single_display_spec): Rename the
5615 display_replaced_before_p argument into display_replaced_p, to
5616 make it consistent with the commentary. Fix typos in the
5617 commentary.
5618
e2ad650c
EZ
5619 * textprop.c (syms_of_textprop): Remove dead code.
5620 (copy_text_properties): Delete obsolete commentary about an
5621 interface that was deleted long ago. Fix typos in the description
5622 of arguments.
5623
1b2de274
EZ
5624 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5625 to changes in oldXMenu/XMenu.h from 2011-04-16.
5626 <menu_help_message, prev_menu_help_message>: Constify.
5627 (IT_menu_make_room): menu->help_text is now `const char **';
5628 adjust.
5629
5630 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5631 to changes in oldXMenu/XMenu.h from 2011-04-16.
5632 (struct XMenu): Declare `help_text' `const char **'.
5633
5634 * xfaces.c <Qunspecified>: Make extern again.
5635
5636 * syntax.c: Include sys/types.h before including regex.h, as
5637 required by Posix.
5638
762b15be
EZ
5639 * doc.c (get_doc_string): Improve the format passed to `error'.
5640
5641 * doprnt.c (doprnt): Improve commentary.
5642
5643 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5644
5645 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5646 them with etags.
5647
f1052e5d
EZ
5648 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5649 changes in globals.h immediately force recompilation.
762b15be
EZ
5650 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5651 $(CURDIR)/s/ms-w32.h.
5652 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5653
fa6996bc
EZ
5654 * character.c (Fchar_direction): Function deleted.
5655 (syms_of_character): Don't defsubr it.
5656 <char-direction-table>: Deleted.
5657
e6c3da20
EZ
56582011-04-23 Eli Zaretskii <eliz@gnu.org>
5659
5660 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5661 * doprnt.c: Include limits.h.
5662 (SIZE_MAX): New macro.
04f2d78b
CB
5663 (doprnt): Return a size_t value. 2nd arg is now size_t.
5664 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5665 Improve overflow protection. Support `l' modifier for integer
5666 conversions. Support %l conversion. Don't assume an EMACS_INT
5667 argument for integer conversions and for %c.
5668
5669 * lisp.h (doprnt): Restore prototype.
5670
5671 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5672 $(SRC)/character.h.
5673
5674 * Makefile.in (base_obj): Add back doprnt.o.
5675
5676 * deps.mk (doprnt.o): Add back prerequisites.
5677 (callint.o): Depend on character.h.
5678
5679 * eval.c (internal_lisp_condition_case): Include the handler
5680 representation in the error message.
5681 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5682 when breaking from the loop.
5683
5684 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5685
5686 * callint.c (Fcall_interactively): When displaying error message
5687 about invalid control letter, pass the character's codepoint, not
5688 a pointer to its multibyte form. Improve display of the character
5689 in octal and display also its hex code.
5690
5691 * character.c (char_string): Use %x to display the (unsigned)
5692 codepoint of an invalid character, to avoid displaying a bogus
5693 negative value.
5694
5695 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5696 `error', not SYMBOL_NAME itself.
5697
5698 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5699 character arguments to `error'.
5700
5701 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5702 to `error' in error message about FINAL_CHAR argument. Make sure
5703 FINAL_CHAR is a character, and use %c when it is passed as
5704 argument to `error'.
5705
4ffd0d6b 57062011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5707
5708 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5709
5710 * w32.c: Include <time.h>.
5711 (sys_localtime): New function.
5712
4ffd0d6b 57132011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5714
5715 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5716
4ffd0d6b 5717 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5718
4ffd0d6b 57192011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5720
4ffd0d6b
GM
5721 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5722 zombies (Bug#8467).
aac0c6e3 5723
04c56954
EZ
57242011-04-19 Eli Zaretskii <eliz@gnu.org>
5725
5726 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5727 gl_state.e_property when gl_state.object is Qt.
5728
5729 * insdel.c (make_gap_larger): Remove limitation of buffer size
5730 to <= INT_MAX.
5731
16a43933
CY
57322011-04-18 Chong Yidong <cyd@stupidchicken.com>
5733
5734 * xdisp.c (lookup_glyphless_char_display)
5735 (produce_glyphless_glyph): Handle cons cell entry in
5736 glyphless-char-display.
5737 (Vglyphless_char_display): Document it.
5738
5739 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5740 glyphless-char-display.
5741
4581706e
CY
57422011-04-17 Chong Yidong <cyd@stupidchicken.com>
5743
5744 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5745
5746 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5747
5748 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5749 definition for no-X builds.
5750
4887c6e2 57512011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5752
fd35b6f9
PE
5753 Static checks with GCC 4.6.0 and non-default toolkits.
5754
5c1ccb01
PE
5755 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5756
006c5daa
PE
5757 * process.c (keyboard_bit_set): Define only if SIGIO.
5758 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5759 (send_process): Repair possible setjmp clobbering.
5760
efc736d3
PE
5761 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5762
4e2fe2e6
PE
5763 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5764
f97334a2
PE
5765 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5766
4e75f29d
PE
5767 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5768 Define only if needed.
5769
90efadd1
PE
5770 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5771 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5772 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5773
3c647824
PE
5774 * dispextern.h (struct redisplay_interface): Rename param
5775 to avoid shadowing.
e264f262 5776 * termhooks.h (struct terminal): Likewise.
761383f4 5777 * xterm.c (xembed_send_message): Likewise.
3c647824 5778
b58c5c4a
PE
5779 * insdel.c (make_gap_smaller): Define only if
5780 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5781
cad59032
PE
5782 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5783 it.
5784
c339dc2e
PE
5785 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5786 so that we aren't warned about unused symbols.
5787
91a3e27b
PE
5788 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5789
399c71d3 5790 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5791
8ffc96f5
PE
5792 * xfns.c (x_real_positions): Mark locals as initialized.
5793
eef9bc79
PE
5794 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5795
098db9dd
PE
5796 * xterm.c: Fix problems found by static analysis with other toolkits.
5797 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5798 (x_dispatch_event): Declare static if USE_GTK, and
5799 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5800 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5801 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5802 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5803 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5804
eb18f6cc
PE
5805 * xmenu.c (menu_help_callback): Pointer type fixes.
5806 Use const pointers when pointing at readonly data. Avoid pointer
5807 signedness clashes.
5808 (FALSE): Remove unused macro.
5809 (update_frame_menubar): Remove unused decl.
5810
1fe72bf8
PE
5811 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5812
60d9e1db
PE
5813 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5814 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5815 (single_menu_item): Rename local to avoid shadowing.
5816
39261c26
PE
5817 * keyboard.c (make_lispy_event): Remove unused local var.
5818
018c5e19
PE
5819 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5820 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5821
63d2b86e
PE
5822 * bitmaps: Change bitmaps from unsigned char back to the X11
5823 compatible char. Avoid the old compiler warnings about
5824 out-of-range initializers by using, for example, '\xab' rather
5825 than 0xab.
5826
aefd87e1
PE
5827 * xgselect.c (xgselect_initialize): Check vs interface
5828 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5829
bf501fb9
PE
5830 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5831
e9829fdf
PE
5832 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5833 to read-only memory.
5834
1086c095
PE
5835 * fns.c (vector): Remove; this old hack is no longer needed.
5836
2baccd04 5837 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5838 Remove unused var.
dde42981 5839 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5840
72391843 5841 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5842
436c16df 5843 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5844 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5845 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5846
92bb796d 5847 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5848 (x_term_init): Remove local to avoid shadowing.
92bb796d 5849
764430a3 5850 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5851
5852 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5853 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5854
d1dfb56c
EZ
58552011-04-16 Eli Zaretskii <eliz@gnu.org>
5856
c4354cb4
EZ
5857 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5858
d1dfb56c
EZ
5859 Fix regex.c, syntax.c and friends for buffers > 2GB.
5860 * syntax.h (struct gl_state_s): Declare character position members
5861 EMACS_INT.
5862
5863 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5864
04f2d78b
CB
5865 * textprop.c (verify_interval_modification, interval_of):
5866 Declare arguments EMACS_INT.
d1dfb56c
EZ
5867
5868 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5869 EMACS_INT.
5870
5871 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5872
5873 * indent.c (Fvertical_motion): Local variable it_start is now
5874 EMACS_INT.
5875
5876 * regex.c (re_match, re_match_2, re_match_2_internal)
5877 (bcmp_translate, regcomp, regexec, print_double_string)
5878 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5879 (re_compile_pattern, re_exec): Declare arguments and local
5880 variables `size_t' and `ssize_t' and return values `regoff_t', as
5881 appropriate.
5882 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5883 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5884 <compile_stack_type>: `size' and `avail' are now `size_t'.
5885
5886 * regex.h <regoff_t>: Use ssize_t, not int.
5887 (re_search, re_search_2, re_match, re_match_2): Arguments that
5888 specify buffer/string position and length are now ssize_t and
5889 size_t. Return type is regoff_t.
5890
613052cd
BK
58912011-04-16 Ben Key <bkey76@gmail.com>
5892
5893 * nsfont.m: Fixed bugs in ns_get_family and
5894 ns_descriptor_to_entity that were caused by using free to
5895 deallocate memory blocks that were allocated by xmalloc (via
5896 xstrdup). This caused Emacs to crash when compiled with
5897 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5898 --enable-checking=xmallocoverrun). xfree is now used to
5899 deallocate these memory blocks.
5900
4170f62f 59012011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5902
71b41406
PE
5903 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5904
9587a89d
PE
5905 emacs_write: Accept and return EMACS_INT for sizes.
5906 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5907 et seq.
5908 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5909 Accept and return EMACS_INT.
5910 (emacs_gnutls_write): Return the number of bytes written on
5911 partial writes.
5912 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5913 (emacs_read, emacs_write): Remove check for negative size, as the
5914 Emacs source code has been audited now.
9587a89d
PE
5915 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5916 (emacs_read, emacs_write): Use it.
273a5f82
PE
5917 * process.c (send_process): Adjust to the new signatures of
5918 emacs_write and emacs_gnutls_write. Do not attempt to store
5919 a byte offset into an 'int'; it might overflow.
9587a89d 5920 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5921
3e047f51
PE
5922 * sound.c: Don't assume sizes fit in 'int'.
5923 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5924 Return EMACS_INT, not int.
3e047f51 5925 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5926 Accept EMACS_INT, not int.
5927 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5928 record read return values.
5929
cc39a9db
BK
59302011-04-15 Ben Key <bkey76@gmail.com>
5931
c9d0ec6d
JB
5932 * keyboard.c (Qundefined): Don't declare static since it is used
5933 in nsfns.m.
5934 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5935 static since they are used in nsfont.m.
cc39a9db 5936
6c60eb9f
SM
59372011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5938
5939 * process.c (Qprocessp): Don't declare static.
5940 * lisp.h (Qprocessp): Declare again.
5941
7990b61a
JB
59422011-04-15 Juanma Barranquero <lekktu@gmail.com>
5943
5944 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5945
5d4cb038
PE
59462011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5947
8bd7b830 5948 Improve C-level modularity by making more things 'static'.
cd64ea1d 5949
e3b27b31
PE
5950 Don't publish debugger-only interfaces to other modules.
5951 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5952 (verify_bytepos, count_markers): Move decls to the only modules
5953 that need them.
5954 * region-cache.h (pp_cache): Likewise.
5955 * window.h (check_all_windows): Likewise.
5956 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5957
5d4cb038
PE
5958 * sysdep.c (croak): Now static, if
5959 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5960 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5961
5962 * alloc.c (refill_memory_reserve): Now static if
5963 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5964 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5965
e87b6180
PE
5966 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5967 Define only if USE_LUCID.
5968
ac64929e
PE
5969 * xrdb.c (x_customization_string, x_rm_string): Now static.
5970
6f37259d
PE
5971 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5972 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5973
1683e3ab
PE
5974 * xdisp.c (draw_row_with_mouse_face): Now static.
5975 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5976
de9c2632
PE
5977 * window.h (check_all_windows): Mark externally visible.
5978
2b96acb7
PE
5979 * window.c (window_deletion_count): Now static.
5980
5981 * undo.c: Make symbols static if they're not exported.
5982 (last_undo_buffer, last_boundary_position, pending_boundary):
5983 Now static.
5984
50436f33
PE
5985 * textprop.c (interval_insert_behind_hooks): Now static.
5986 (interval_insert_in_front_hooks): Likewise.
5987
64520e5c
PE
5988 * term.c: Make symbols static if they're not exported.
5989 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5990 (max_frame_lines, tty_set_terminal_modes):
5991 (tty_reset_terminal_modes, tty_turn_off_highlight):
5992 (get_tty_terminal): Now static.
5993 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5994 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5995 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5996 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5997 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5998
1fa53021
PE
5999 * sysdep.c: Make symbols static if they're not exported.
6000 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6001 Now static.
6002 (sigprocmask_set, full_mask): Remove; unused.
6003 (wait_debugging): Mark as visible.
6004 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6005 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6006
d4b43b22
PE
6007 * syntax.c (syntax_temp): Define only if !__GNUC__.
6008
b7c513d0
PE
6009 * sound.c (current_sound_device, current_sound): Now static.
6010
989b29ad
PE
6011 * search.c (searchbufs, searchbuf_head): Now static.
6012
13a55a78
PE
6013 * scroll.c (scroll_cost): Remove; unused.
6014 * dispextern.h (scroll_cost): Remove decl.
6015
de68a1fc
PE
6016 * region-cache.h (pp_cache): Mark as externally visible.
6017
40ccffa6
PE
6018 * process.c: Make symbols static if they're not exported.
6019 (process_tick, update_tick, create_process, chan_process):
6020 (Vprocess_alist, proc_buffered_char, datagram_access):
6021 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6022 (deactivate_process): Mark defn as static, as well as decl.
6023 * lisp.h (create_process): Remove decl.
6024 * process.h (chan_process, Vprocess_alist): Remove decls.
6025
ad64fc97
PE
6026 * print.c: Make symbols static if they're not exported.
6027 (print_depth, new_backquote_output, being_printed, print_buffer):
6028 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6029 (print_interval, print_number_index, initial_stderr_stream):
6030 Now static.
6031 * lisp.h (Fprinc): Remove decl.
6032 (debug_output_compilation_hack): Mark as externally visible.
6033
adddb265
PE
6034 * sysdep.c (croak): Move decl from here to syssignal.h.
6035 * syssignal.h (croak): Put it here, so the API can be checked when
6036 'croak' is called from dissociate_if_controlling_tty.
6037
1717ede2
PE
6038 * minibuf.c: Make symbols static if they're not exported.
6039 (minibuf_save_list, choose_minibuf_frame): Now static.
6040 * lisp.h (choose_minibuf_frame): Remove decl.
6041
fa5fb2bc
PE
6042 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6043
1e3890d1
PE
6044 * lread.c: Make symbols static if they're not exported.
6045 (read_objects, initial_obarray, oblookup_last_bucket_number):
6046 Now static.
6047 (make_symbol): Remove; unused.
6048 * lisp.h (initial_obarray, make_symbol): Remove decls.
6049
8a1414fa
PE
6050 * keyboard.c: Make symbols static if they're not exported.
6051 (single_kboard, recent_keys_index, total_keys, recent_keys):
6052 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6053 (this_single_command_key_start, echoing, last_auto_save):
6054 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6055 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6056 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6057 (Vlispy_mouse_stem, double_click_count):
6058 Now static.
6059 (force_auto_save_soon): Define only if SIGDANGER.
6060 (ignore_mouse_drag_p): Now static if
6061 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6062 (print_help): Remove; unused.
6063 (stop_character, last_timer_event): Mark as externally visible.
6064 * keyboard.h (ignore_mouse_drag_p): Declare only if
6065 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6066 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6067 * lisp.h (echoing): Remove decl.
6068 (force_auto_save_soon): Declare only if SIGDANGER.
6069 * xdisp.c (redisplay_window): Simplify code, to make it more
6070 obvious that ignore_mouse_drag_p is not accessed if !defined
6071 USE_GTK && !defined HAVE_NS.
6072
93ea6e8f
PE
6073 * intervals.c: Make symbols static if they're not exported.
6074 (merge_properties_sticky, merge_interval_right, delete_interval):
6075 Now static.
6076 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6077
77382fcc
PE
6078 * insdel.c: Make symbols static if they're not exported.
6079 However, leave prepare_to_modify_buffer alone. It's never
6080 called from outside this function, but that appears to be a bug.
6081 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6082 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6083 (adjust_after_replace_noundo): Remove; unused.
6084 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6085 (signal_before_change): Remove decls.
77382fcc 6086
9306c32e
PE
6087 * indent.c (val_compute_motion, val_vmotion): Now static.
6088
cd44d2eb
PE
6089 * image.c: Make symbols static if they're not exported.
6090 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6091 if USE_GTK.
6092 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6093 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6094
ad9a7a06
PE
6095 * fringe.c (standard_bitmaps): Now static.
6096 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6097
81626931
PE
6098 * frame.c: Make symbols static if they're not exported.
6099 (x_report_frame_params, make_terminal_frame): Now static.
6100 (get_frame_param): Now static, unless HAVE_NS.
6101 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6102 (x_get_resource_string): Remove; not used.
6103 * frame.h (make_terminal_frame, x_report_frame_params):
6104 (x_get_resource_string); Remove decls.
6105 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6106 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6107
239f9db9
PE
6108 * font.c, fontset.c: Make symbols static if they're not exported.
6109 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6110 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6111 * font.c (font_close_object): Now static.
6112 * font.h (font_close_object): Remove.
6113 * fontset.c (FONTSET_OBJLIST): Remove.
6114 (free_realized_fontset) #if-0 the body, which does nothing.
6115 (face_suitable_for_char_p): #if-0, as it's never called.
6116 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6117 * xfaces.c (face_at_string_position):
6118 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6119 since 0 is always ASCII.
6120
dfcf3579
PE
6121 * fns.c (weak_hash_tables): Now static.
6122
5045092b
PE
6123 * fileio.c: Make symbols static if they're not exported.
6124 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6125 (Vwrite_region_annotation_buffers): Now static.
6126
57a96f5c
PE
6127 * eval.c: Make symbols static if they're not exported.
6128 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6129 * lisp.h (backtrace_list): Remove decl.
6130
35f08c38
PE
6131 * emacs.c: Make symbols static if they're not exported.
6132 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6133 (fatal_error_code, fatal_error_signal_hook, standard_args):
6134 Now static.
6135 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6136 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6137 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6138 * lisp.h (fatal_error_signal_hook): Remove decl.
6139 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6140
f44bd759
PE
6141 * editfns.c: Move a (normally-unused) function to its only use.
6142 * editfns.c, lisp.h (get_operating_system_release): Remove.
6143 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6144 worth the hassle of breaking this out.
6145
b532497d
PE
6146 * xterm.c: Make symbols static if they're not exported.
6147 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6148 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6149 (x_destroy_window, x_delete_display):
6150 Now static.
6151 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6152 (x_mouse_leave): Remove; unused.
6153 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6154 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6155 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6156 Remove decls.
6157 (x_mouse_leave): Declare only if WINDOWSNT.
6158 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6159 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6160 USE_X_TOOLKIT.
6161
1675728f
PE
6162 * ftxfont.c: Make symbols static if they're not exported.
6163 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6164 HAVE_FREETYPE.
6165 * font.h (ftxfont_driver): Likewise.
6166
e4cebfca
PE
6167 * xfns.c: Make symbols static if they're not exported.
6168 (x_last_font_name, x_display_info_for_name):
6169 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6170 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6171 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6172 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6173 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6174 (last_show_tip_args): Now static.
6175 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6176 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6177 (x_screen_planes): Remove; unused.
6178 * dispextern.h (x_screen_planes): Remove decl.
6179
5bf46f05
PE
6180 * dispnew.c: Make symbols static if they're not exported.
6181 * dispextern.h (redraw_garbaged_frames, scrolling):
6182 (increment_row_positions): Remove.
6183 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6184 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6185 Now static.
6186 (redraw_garbaged_frames): Remove; unused.
6187
435f4c28
PE
6188 * xfaces.c: Make symbols static if they're not exported.
6189 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6190 Remove decls.
6191 * xterm.h (defined_color): Remove decls.
6192 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6193 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6194 (menu_face_changed_default, defined_color, free_realized_face):
6195 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6196 (ascii_face_of_lisp_face): Remove; unused.
6197
8524aef3
PE
6198 * xdisp.c: Make symbols static if they're not exported.
6199 * dispextern.h (scratch_glyph_row, window_box_edges):
6200 (glyph_to_pixel_coords, set_cursor_from_row):
6201 (get_next_display_element, set_iterator_to_next):
6202 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6203 (show_mouse_face): Remove decls
6204 * frame.h (message_buf_print): Likewise.
6205 * lisp.h (pop_message, set_message, check_point_in_composition):
6206 Likewise.
6207 * xterm.h (set_vertical_scroll_bar): Likewise.
6208 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6209 (message_buf_print, scratch_glyph_row, displayed_buffer):
6210 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6211 (get_next_display_element, show_mouse_face, window_box_edges):
6212 (frame_to_window_pixel_xy, check_point_in_composition):
6213 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6214 (glyph_to_pixel_coords): Remove; unused.
6215
16390cd2
PE
6216 * dired.c (file_name_completion): Now static.
6217
6218 * dbusbind.c (xd_in_read_queued_messages): Now static.
6219
a25f4dfa
PE
6220 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6221 * data.c (circular_list_error): Remove.
6222
14a9c8df
PE
6223 * commands.h (last_point_position, last_point_position_buffer):
6224 (last_point_position_window): Remove decls.
6225 * keyboard.c: Make these variables static.
6226
04f2d78b
CB
6227 * coding.h (coding, code_convert_region, encode_coding_gap):
6228 Remove decls.
74ab6df5
PE
6229 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6230 (iso_code_class, detect_coding, code_convert_region): Now static.
6231 (encode_coding_gap): Remove; unused.
6232
38dfbee1
PE
6233 * chartab.c (chartab_chars, chartab_bits): Now static.
6234
a2cb4e63
PE
6235 * charset.h (charset_iso_8859_1): Remove decl.
6236 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6237 Now static.
6238
127198fd
PE
6239 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6240 * ccl.c (Vccl_program_table): Now static.
6241 (check_ccl_update): Remove; unused.
6242
d85b608f
PE
6243 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6244 * category.h: ... from here.
6245 * category.c (check_category_table, set_category_set): Now static.
6246
31cd66f3
PE
6247 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6248 * lisp.h: Remove these decls.
6249
c358e587
PE
6250 * buffer.c (buffer_count): Remove unused var.
6251
e78aecca
PE
6252 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6253 so that it's not optimized away.
6254 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6255 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6256 exported only to the debugger.
6257
e192d7d3 6258 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6259 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6260
92470028
PE
6261 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6262 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6263 was inaccessible from Lisp.
6264 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6265 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6266
244ed907
PE
6267 alloc.c: Import and export fewer symbols, and remove unused items.
6268 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6269 is defined.
6270 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6271 it's not optimized away by whole-program optimization.
6272 (message_enable_multibyte, free_misc): Remove.
6273 (catchlist, handlerlist, mark_backtrace):
6274 Declare only if BYTE_MARK_STACK.
6275 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6276 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6277 (message_enable_multibyte): Remove decl.
6278 (free_misc, interval_free_list, float_block, float_block_index):
6279 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6280 (cons_free_list, last_marked_index):
6281 Now static.
6282 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6283 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6284 (mark_backtrace): Define only if BYTE_MARK_STACK.
6285 * xdisp.c (message_enable_multibyte): Now static.
6286
61c2b50e 6287 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6288 This makes it easier for human readers (and static analyzers)
6289 to see whether these variables are used from other modules.
6290 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6291 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6292 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6293 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6294 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6295 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6296 * xmenu.c, xselect.c:
6297 Declare Q* vars static if they are not used in other modules.
6298 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6299 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6300 Remove decls of unexported vars.
6301 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6302
95c82688
PE
6303 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6304
16a97296
PE
6305 Make Emacs functions such as Fatom 'static' by default.
6306 This makes it easier for human readers (and static analyzers)
6307 to see whether these functions can be called from other modules.
6308 DEFUN now defines a static function. To make the function external
6309 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6310 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6311 (Finit_image_library):
16a97296
PE
6312 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6313 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6314 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6315 Remove decls, since these functions are now static.
6316 (Funintern, Fget_internal_run_time): New decls, since these functions
6317 were already external.
95c82688 6318
16a97296
PE
6319 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6320 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6321 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6322 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6323 * keyboard.c, keymap.c, lread.c:
6324 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6325 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6326 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6327 Mark functions with DEFUE instead of DEFUN,
6328 if they are used in other modules.
6329 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6330 decls for now-static functions.
6331 * buffer.h (Fdelete_overlay): Remove decl.
6332 * callproc.c (Fgetenv_internal): Mark as internal.
6333 * composite.c (Fremove_list_of_text_properties): Remove decl.
6334 (Fcomposition_get_gstring): New forward static decl.
6335 * composite.h (Fcomposite_get_gstring): Remove decl.
6336 * dired.c (Ffile_attributes): New forward static decl.
6337 * doc.c (Fdocumntation_property): New forward static decl.
6338 * eval.c (Ffetch_bytecode): New forward static decl.
6339 (Funintern): Remove extern decl; now in .h file where it belongs.
6340 * fileio.c (Fmake_symbolic_link): New forward static decl.
6341 * image.c (Finit_image_library): New forward static decl.
6342 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6343 * intervals.h (Fprevious_property_change):
6344 (Fremove_list_of_text_properties): Remove decls.
6345 * keyboard.c (Fthis_command_keys): Remove decl.
6346 (Fcommand_execute): New forward static decl.
6347 * keymap.c (Flookup_key): New forward static decl.
6348 (Fcopy_keymap): Now static.
6349 * keymap.h (Flookup_key): Remove decl.
6350 * process.c (Fget_process): New forward static decl.
6351 (Fprocess_datagram_address): Mark as internal.
6352 * syntax.c (Fsyntax_table_p): New forward static decl.
6353 (skip_chars): Remove duplicate decl.
6354 * textprop.c (Fprevious_property_change): New forward static decl.
6355 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6356 Now internal.
6357 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6358 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6359
785bbd42
PE
6360 * editfns.c (Fformat): Remove unreachable code.
6361
8b913b57
AS
63622011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6363
6364 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6365 change. (Bug#8496)
6366
a6744a35
EZ
63672011-04-13 Eli Zaretskii <eliz@gnu.org>
6368
6369 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6370 when at ZV. (Bug#8487)
6371
e7974947
AS
63722011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6373
baad03f0
AS
6374 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6375 (Bug#8437)
6376 * keyboard.c (parse_tool_bar_item): Likewise.
6377 * sound.c (sound_cleanup, alsa_close): Likewise.
6378 * termcap.c (tgetent): Likewise.
6379 * xfns.c (x_default_font_parameter): Likewise.
6380 * xsettings.c (read_and_apply_settings): Likewise.
6381
e7974947
AS
6382 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6383 (overrun_check_free): Protoize.
6384
28272684
PE
63852011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6386
6387 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6388 since callers should never pass a negative size.
6389 Change the signature to match that of plain 'read' and 'write'; see
6390 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6391 * lisp.h: Update prototypes of emacs_write and emacs_read.
6392
11997c76
EZ
63932011-04-11 Eli Zaretskii <eliz@gnu.org>
6394
6395 * xdisp.c (redisplay_window): Don't try to determine the character
6396 position of the scroll margin if the window start point w->startp
e896f03c 6397 is outside the buffer's accessible region. (Bug#8468)
11997c76 6398
8a2cbd72
EZ
63992011-04-10 Eli Zaretskii <eliz@gnu.org>
6400
6401 Fix write-region and its subroutines for buffers > 2GB.
6402 * fileio.c (a_write, e_write): Modify declaration of arguments and
6403 local variables to support buffers larger than 2GB.
6404 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6405
6406 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6407 argument, local variables, and return value.
6408
6409 * lisp.h: Update prototypes of emacs_write and emacs_read.
6410
6411 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6412
4073e537 64132011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6414
1ebfdcb6
PE
6415 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6416
b2ded58d
PE
6417 Fix more problems found by GCC 4.6.0's static checks.
6418
7d66342c
PE
6419 * xdisp.c (vmessage): Use a better test for character truncation.
6420
bbf47d44
PE
6421 * charset.c (load_charset_map): <, not <=, for optimization,
6422 and to avoid potential problems with integer overflow.
9248994d 6423 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6424 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6425 * editfns.c (Fformat): Likewise.
1e69125e 6426 * syntax.c (skip_chars): Likewise.
3befa583 6427
e3019616
PE
6428 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6429 This also lets GCC 4.6.0 generate slightly better loop code.
6430
becfa255
PE
6431 * callint.c (Fcall_interactively): <, not <=, for optimization.
6432 (Fcall_interactively): Count the number of arguments produced,
6433 not the number of arguments given. This is simpler and lets GCC
6434 4.6.0 generate slightly better code.
6435
dae0cd48
PE
6436 * ftfont.c: Distingish more carefully between FcChar8 and char.
6437 The previous code passed unsigned char * to a functions like
6438 strlen and xstrcasecmp that expect char *, which does not
6439 conform to the C standard.
6440 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6441 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6442 char * when the C standard requires it.
6443
76032d70
PE
6444 * keyboard.c (read_char): Remove unused var.
6445
eb3f1cc8
PE
6446 * eval.c: Port to Windows vsnprintf (Bug#8435).
6447 Include <limits.h>.
6448 (SIZE_MAX): Define if the headers do not.
6449 (verror): Do not give up if vsnprintf returns a negative count.
6450 Instead, grow the buffer. This ports to Windows vsnprintf, which
6451 does not conform to C99. Problem reported by Eli Zaretskii.
6452 Also, simplify the allocation scheme, by avoiding the need for
6453 calling realloc, and removing the ALLOCATED variable.
6454
70476b54
PE
6455 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6456
12020a9e
PE
6457 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6458 But keep the doprint source code for now, as we might revamp it
6459 and use it again (Bug#8435).
ea6c7ae6
PE
6460 * lisp.h (doprnt): Remove.
6461 * Makefile.in (base_obj): Remove doprnt.o.
6462 * deps.mk (doprnt.o): Remove.
6463
5fdb398c
PE
6464 error: Print 32- and 64-bit integers portably (Bug#8435).
6465 Without this change, on typical 64-bit hosts error ("...%d...", N)
6466 was used to print both 32- and 64-bit integers N, which relied on
6467 undefined behavior.
6468 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6469 New macro.
6470 * lisp.h (error, verror): Mark as printf-like functions.
6471 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6472 Report overflow in size calculations when allocating printf buffer.
6473 Do not truncate output string at its first null byte.
6474 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6475 Truncate the output at a character boundary, since vsnprintf does not
6476 do that.
6477 * charset.c (check_iso_charset_parameter): Convert internal
6478 character to string before calling 'error', since %c now has the
6479 printf meaning.
6480 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6481 overflow when computing char to be passed to 'error'. Do not
6482 pass Lisp_Object to 'error'; pass the integer instead.
6483 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6484 formatted with plain %d.
6485
b189fa66
PE
6486 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6487
bff87ef0
PE
6488 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6489
7e2cac20
PE
6490 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6491
ce4d90b5
PE
6492 * xterm.c (x_catch_errors): Remove duplicate declaration.
6493
266c9547
PE
6494 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6495
79c49ad2
PE
6496 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6497
368f4090
JM
64982011-04-10 Jim Meyering <meyering@redhat.com>
6499
6500 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6501 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6502 return ssize_t not "int", and use size_t as the buffer length.
6503 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6504 * gnutls.h: Update declarations.
6505 * process.c (read_process_output): Use ssize_t, to match.
6506 (send_process): Likewise.
6507
a32d4040
CY
65082011-04-09 Chong Yidong <cyd@stupidchicken.com>
6509
6510 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6511
8546720e 65122011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6513
04f2d78b
CB
6514 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6515 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6516
8546720e
GM
6517 * xterm.c (handle_one_xevent):
6518 * xmenu.c (create_and_show_popup_menu):
6519 * xselect.c (x_decline_selection_request)
6520 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6521
0a2f5c1a 65222011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6523
6524 Fix some uses of `int' instead of EMACS_INT.
6525 * search.c (string_match_1, fast_string_match)
6526 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6527 (scan_buffer, find_next_newline_no_quit)
6528 (find_before_next_newline, search_command, Freplace_match)
6529 (Fmatch_data): Make some `int' variables be EMACS_INT.
6530
6531 * xdisp.c (display_count_lines): 3rd argument and return value now
6532 EMACS_INT. All callers changed.
6533 (pint2hrstr): Last argument is now EMACS_INT.
6534
6535 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6536 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6537 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6538 (decode_coding_utf_16, decode_coding_emacs_mule)
6539 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6540 (decode_coding_ccl, decode_coding_charset)
6541 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6542 (decode_coding_iso_2022, decode_coding_emacs_mule)
6543 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6544 <char_offset, last_offset>: Declare EMACS_INT.
6545 (encode_coding_utf_8, encode_coding_utf_16)
6546 (encode_coding_emacs_mule, encode_invocation_designation)
6547 (encode_designation_at_bol, encode_coding_iso_2022)
6548 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6549 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6550 Declare EMACS_INT.
6551 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6552 (encode_invocation_designation): Last argument P_NCHARS is now
6553 EMACS_INT.
6554 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6555 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6556
6557 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6558 All users changed.
6559
6560 * ccl.c (Fccl_execute_on_string): Declare some variables
6561 EMACS_INT.
6562
8546720e 65632011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6564
6565 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6566
4e19a977
CS
65672011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6568
6569 * process.c (Fformat_network_address): Doc fix.
6570
87302331
R
65712011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6572
6573 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6574
cbb59342
CY
65752011-04-08 Chong Yidong <cyd@stupidchicken.com>
6576
6577 * keyboard.c (read_char): Call Lisp function help-form-show,
6578 instead of using internal_with_output_to_temp_buffer.
6579 (Qhelp_form_show): New var.
e0d38eeb 6580 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6581
6582 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6583
6584 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6585
e67a13ab
CY
65862011-04-06 Chong Yidong <cyd@stupidchicken.com>
6587
04f2d78b
CB
6588 * process.c (Flist_processes): Remove to Lisp.
6589 (list_processes_1): Delete.
e67a13ab 6590
973f782d
EZ
65912011-04-06 Eli Zaretskii <eliz@gnu.org>
6592
7c106b1e
EZ
6593 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6594
973f782d
EZ
6595 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6596
41cf7d1a 65972011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6598
ca23cc88
PE
6599 Fix more problems found by GCC 4.6.0's static checks.
6600
f390e2d5
PE
6601 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6602
42eea0d0
PE
6603 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6604
b69769da 6605 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6606
f9541e84
PE
6607 * xdisp.c (vmessage): Mark as a printf-like function.
6608
13841b55
PE
6609 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6610
c136c10f
PE
6611 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6612
5e2d4a30
PE
6613 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6614 printf-like functions.
6615 (tiff_load): Add casts to remove these marks before passing them
6616 to system-supplied API.
6617
583f48b9
PE
6618 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6619
b25d760e
PE
6620 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6621 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6622 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6623 directly, rather than having caller test rule sign. This avoids
6624 some unnecessary tests.
6625 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6626 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6627 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6628
bc7b6697 6629 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6630 (xfont_open): Avoid unnecessary tests.
bc7b6697 6631
27ccc379
PE
6632 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6633
dcd5c89a
PE
6634 * composite.h, composite.c (composition_gstring_put_cache):
6635 Use EMACS_INT, not int, for length.
6636
b13a45c6
PE
6637 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6638 breaking out part of COMPOSITION_DECODE_RULE.
6639 (COMPOSITION_DECODE_RULE): Use it.
6640 * composite.c (get_composition_id): Remove unused local vars,
6641 by using the new macro.
6642
1e792e4d
PE
6643 * textprop.c (set_text_properties_1): Change while to do-while,
6644 since the condition is always true at first.
6645
dc6c6455 6646 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6647 (interval_deletion_adjustment): Return unsigned value.
6648 All uses changed.
dc6c6455 6649
aba7731a
PE
6650 * process.c (list_processes_1, create_pty, read_process_output):
6651 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6652 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6653 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6654 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6655 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6656
fdfc4bf3
PE
6657 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6658
fca8fe46 6659 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6660 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6661
06a0259a 6662 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6663 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6664 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6665
e7b9e80f
PE
6666 * print.c (print_error_message): Avoid int overflow.
6667
56201685
PE
6668 * font.c (font_list_entities): Redo for clarity,
6669 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6670
78834453 6671 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6672 (font_score): Avoid potential overflow in diff calculation.
78834453 6673
0bc0b309 6674 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6675 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6676
e610eaca
PE
6677 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6678
b895abce
PE
6679 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6680 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6681 can always succeed if overflow has undefined behavior.
6682
1f1d9321 6683 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6684 (wordify): Omit three unnecessary tests.
1f1d9321 6685
c59478bc
PE
6686 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6687 All callers changed. This avoids the need for an unused var.
6688
79b73827
PE
6689 * casefiddle.c (casify_region): Remove var that is set but not used.
6690
a4db5dfe
PE
6691 * dired.c (file_name_completion): Remove var that is set but not used.
6692
43aae36e
PE
6693 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6694
2a47c44d 6695 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6696 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6697
a37c69bf
PE
6698 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6699 Check for integer overflow on size calculations.
6700
328ab8e7
PE
6701 * buffer.c (Fprevious_overlay_change): Remove var that is set
6702 but not used.
6703
e5a2a5cb
PE
6704 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6705 Remove vars that are set but not used.
8d84a6eb 6706 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6707 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6708
a60e5f68
PE
6709 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6710
f661cb61 6711 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6712 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6713
f0397f5a
PE
6714 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6715 that are set but not used.
6716
8664db06 6717 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6718 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6719
6abdaa4a
PE
6720 * xselect.c (x_get_local_selection, x_handle_property_notify):
6721 Remove vars that are set but not used.
6722
0ce7538d 6723 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6724 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6725
9ae848fc
PE
6726 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6727 Remove var that is set but not used.
0b918413
PE
6728 (scroll_bar_windows_size): Now size_t, not int.
6729 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6730 Check for overflow.
9ae848fc 6731
a5a62657
PE
6732 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6733 (map_tty_color) [!defined MSDOS]: Likewise.
6734
5c5cdd39
PE
6735 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6736
66ebf983
PE
6737 * coding.c: Remove vars that are set but not used.
6738 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6739 All callers changed.
6740 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6741 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6742 (decode_coding_charset): Remove vars that are set but not used.
6743
1be4d761
PE
6744 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6745 that is set but not used.
6746
47553fa8
PE
6747 * print.c (print_object): Remove var that is set but not used.
6748
1f7196bf 6749 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6750 The gnulib version avoids calling malloc in the usual case,
6751 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6752 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6753 * filelock.c (current_lock_owner): Likewise.
6754 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6755 * sysdep.c: Include allocator.h, careadlinkat.h.
6756 (emacs_no_realloc_allocator): New static constant.
6757 (emacs_readlink): New function.
fdb61804
PE
6758 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6759 ../lib/careadlinkat.h.
d1fdcab7 6760
f84c17c7
SM
67612011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6762
6763 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6764 first non-nil return value).
6765
ef3862ad
JD
67662011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6767
6768 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6769 if not defined (Bug#8403).
6770
376a7006
JB
67712011-04-02 Juanma Barranquero <lekktu@gmail.com>
6772
6773 * xdisp.c (display_count_lines): Remove parameter `start',
6774 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6775 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6776 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6777 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6778 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6779 and thereabouts. All callers changed.
6780 (get_per_char_metric): Remove parameter `f', unused since
6781 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6782
6ca3801d
JM
67832011-04-02 Jim Meyering <meyering@redhat.com>
6784
6785 do not dereference NULL upon failed strdup
6786 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6787 (ns_get_family): Likewise.
6788
d8e2b5ba
JB
67892011-04-02 Juanma Barranquero <lekktu@gmail.com>
6790
6791 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6792
8c74fcbd
JD
67932011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6794
6795 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6796 later (Bug#8403).
6797
7200d79c
SM
67982011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6799
03408648 6800 Add lexical binding.
7200d79c 6801
03408648
SM
6802 * window.c (Ftemp_output_buffer_show): New fun.
6803 (Fsave_window_excursion):
6804 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6805
6806 * lread.c (lisp_file_lexically_bound_p): New function.
6807 (Fload): Bind Qlexical_binding.
6808 (readevalloop): Remove `evalfun' arg.
6809 Bind Qinternal_interpreter_environment.
6810 (Feval_buffer): Bind Qlexical_binding.
6811 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6812 Mark as dynamic.
6813 (syms_of_lread): Declare `lexical-binding'.
6814
6815 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6816
6817 * keyboard.c (eval_dyn): New fun.
6818 (menu_item_eval_property): Use it.
ca105506
SM
6819
6820 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6821
03408648
SM
6822 * fns.c (concat, mapcar1): Accept byte-code-functions.
6823
6824 * eval.c (Fsetq): Handle lexical vars.
6825 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6826 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6827 (FletX, Flet): Obey lexical binding.
6828 (Fcommandp): Handle closures.
6829 (Feval): New `lexical' arg.
6830 (eval_sub): New function extracted from Feval. Use it almost
6831 everywhere where Feval was used. Look up vars in lexical env.
6832 Handle closures.
6833 (Ffunctionp): Move from subr.el.
6834 (Ffuncall): Handle closures.
6835 (apply_lambda): Remove `eval_flags'.
6836 (funcall_lambda): Handle closures and new byte-code-functions.
6837 (Fspecial_variable_p): New function.
6838 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6839 but without exporting it to Lisp.
23aba0ea 6840
23aba0ea 6841 * doc.c (Fdocumentation, store_function_docstring):
03408648 6842 * data.c (Finteractive_form): Handle closures.
23aba0ea 6843
03408648
SM
6844 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6845 interactive spec.
ba83908c 6846
04f2d78b
CB
6847 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6848 New byte-codes.
03408648
SM
6849 (exec_byte_code): New function extracted from Fbyte_code to handle new
6850 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6851
03408648 6852 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6853
03408648 6854 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6855
e2abce01
JB
68562011-03-31 Juanma Barranquero <lekktu@gmail.com>
6857
6858 * xdisp.c (redisplay_internal): Fix prototype.
6859
63696a73 68602011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6861
63696a73 6862 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6863 (try_scrolling): Use it when setting scroll_limit.
6864 Limit scrolling to 100 screen lines.
63696a73
EZ
6865 (redisplay_window): Even when falling back on "recentering",
6866 position point in the window according to scroll-conservatively,
6867 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6868
6869 (try_scrolling): When point is above the window, allow searching
6870 as far as scroll_max, or one screenful, to compute vertical
6871 distance from PT to the scroll margin position. This prevents
6872 try_scrolling from unnecessarily failing when
6873 scroll-conservatively is set to a value slightly larger than the
6874 window height. Clean up the case of PT below the margin at bottom
6875 of window: scroll_max can no longer be INT_MAX. When aggressive
6876 scrolling is in use, don't let point enter the opposite scroll
6877 margin as result of the scroll.
6878 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6879 threshold of 100 lines for never-recentering scrolling.
6880
e4cc2dfc
JB
68812011-03-31 Juanma Barranquero <lekktu@gmail.com>
6882
6883 * dispextern.h (move_it_by_lines):
6884 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6885 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6886 (message_log_check_duplicate): Remove parameters `prev_bol' and
6887 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6888 (redisplay_internal): Remove parameter `preserve_echo_area',
6889 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6890
6891 * indent.c (Fvertical_motion):
6892 * window.c (window_scroll_pixel_based, Frecenter):
6893 Don't pass `need_y_p' to `move_it_by_lines'.
6894
1c470562
SM
68952011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6896
44f230aa
SM
6897 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6898 steal a few bits to be more compact.
6899 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6900 Remove unneeded casts.
6901
1c470562
SM
6902 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6903
888adce9
ZK
69042011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6905
6906 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6907 binding" message (bug#7967).
6908
f838ed7b
PE
69092011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6910
77861b95
PE
6911 Fix more problems found by GCC 4.6.0's static checks.
6912
de6dbc14
PE
6913 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6914 Remove unused local var.
6915
f838ed7b
PE
6916 * editfns.c (Fmessage_box): Remove unused local var.
6917
792c7b2b
PE
6918 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6919 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6920 Omit unused local vars.
c499e557 6921 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6922 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6923 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6924 Omit unused local var.
6925
ba0165e1
PE
6926 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6927 Don't assume string length fits in int.
32ad8845 6928 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6929 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6930
3c59b4c9
PE
6931 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6932 instead of alloca (Bug#8344).
6933
a3eed478 6934 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6935 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6936
eb4d412d
PE
6937 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6938
1658b401
PE
6939 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6940 concerns.
6941
6942 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6943
6944 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6945
9a2c6e05
PE
6946 * keyboard.c (syms_of_keyboard): Use the same style as later
6947 in this function when indexing through an array. This also
6948 works around GCC bug 48267.
6949
03d0a109
PE
6950 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6951
44f730c8
PE
6952 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6953
fe75f926
PE
6954 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6955 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6956
ffa8c828
PE
6957 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6958 This avoids undefined behavior on integer overflow, and is a bit
6959 more convenient anyway since it is compared to a size_t variable.
6960
c5101a77
PE
6961 Variadic C functions now count arguments with size_t, not int.
6962 This avoids an unnecessary limitation on 64-bit machines, which
6963 caused (substring ...) to crash on large vectors (Bug#8344).
6964 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6965 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6966 All variadic functions and their callers changed accordingly.
c5101a77
PE
6967 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6968 * data.c (arith_driver, float_arith_driver): Likewise.
6969 * editfns.c (general_insert_function): Likewise.
6970 * eval.c (struct backtrace.nargs, interactive_p)
6971 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6972 (funcall_lambda, mark_backtrace): Likewise.
6973 * fns.c (concat): Likewise.
6974 * frame.c (x_set_frame_parameters): Likewise.
6975 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6976 0 if not found, not -1. All callers changed.
6977
dd3f25f7
PE
6978 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6979 (stack_copy_size): Now size_t, not int.
6980 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6981
461c2ab9
JB
69822011-03-28 Juanma Barranquero <lekktu@gmail.com>
6983
6984 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6985 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6986 All callers changed.
6987
6988 * lisp.h (multibyte_char_to_unibyte):
6989 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6990 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6991 * character.h (CHAR_TO_BYTE8):
6992 * cmds.c (internal_self_insert):
6993 * editfns.c (general_insert_function):
6994 * keymap.c (push_key_description):
6995 * search.c (Freplace_match):
6996 * xdisp.c (message_dolog, set_message_1): All callers changed.
6997
f6d62986
SM
69982011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6999
7000 * keyboard.c (safe_run_hook_funcall): New function.
7001 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7002 don't set the hook to nil, but remove the offending function instead.
7003 (Qcommand_hook_internal): Remove, unused.
7004 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7005 Vcommand_hook_internal.
7006
7007 * eval.c (enum run_hooks_condition): Remove.
7008 (funcall_nil, funcall_not): New functions.
7009 (run_hook_with_args): Call each function through a `funcall' argument.
7010 Remove `cond' argument, now redundant.
7011 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7012 (Frun_hook_with_args_until_failure): Adjust accordingly.
7013 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7014
1db5b1ad
JB
70152011-03-28 Juanma Barranquero <lekktu@gmail.com>
7016
7017 * dispextern.h (string_buffer_position): Remove declaration.
7018
7019 * print.c (strout): Remove parameter `multibyte', unused since
7020 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7021
7022 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7023 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7024 All callers changed.
7025
7026 * w32.c (_wsa_errlist): Use braces for struct initializers.
7027
7028 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7029 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7030 All callers changed.
7031 (string_buffer_position): Likewise. Also, make static (it's never
7032 used outside xdisp.c).
7033 (cursor_row_p): Remove parameter `w', unused since
7034 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7035 (decode_mode_spec): Remove parameter `precision', introduced during
7036 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7037 All callers changed.
7038
5ffb62aa
JD
70392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7040
7041 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7042
461c2ab9 70432011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7044
7045 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7046 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7047 (ns_update_auto_hide_menu_bar): New functions.
7048 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7049 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7050 ns_constrain_all_frames.
7051 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7052 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7053
5c380ffb
JD
70542011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7055
7056 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7057
9af30bdf
GM
70582011-03-27 Glenn Morris <rgm@gnu.org>
7059
7060 * syssignal.h: Replace RETSIGTYPE with void.
7061 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7062 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7063 Replace SIGTYPE with void everywhere.
7064 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7065 * s/template.h (SIGTYPE): Remove commented out definition.
7066
e2abce01
JB
70672011-03-26 Eli Zaretskii <eliz@gnu.org>
7068
7069 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7070 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7071
f868cd8a
JB
70722011-03-26 Juanma Barranquero <lekktu@gmail.com>
7073
59eb0929
JB
7074 * w32.c (read_unc_volume): Use parameter `henum', instead of
7075 global variable `wget_enum_handle'.
7076
7077 * keymap.c (describe_vector): Remove parameters `indices' and
7078 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7079 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7080
f868cd8a
JB
7081 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7082
7083 * keyboard.c (timer_check): Remove parameter `do_it_now',
7084 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7085 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7086 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7087
7088 * keyboard.c (read_char):
7089 * w32menu.c (w32_menu_display_help):
7090 * xmenu.c (show_help_event, menu_help_callback):
7091 Adjust calls to `show_help_echo'.
7092
7093 * gtkutil.c (xg_maybe_add_timer):
7094 * keyboard.c (readable_events):
7095 * process.c (wait_reading_process_output):
7096 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7097
7098 * insdel.c (adjust_markers_gap_motion):
7099 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7100 (gap_left, gap_right): Don't call it.
7101
2ecf6fdb
CY
71022011-03-25 Chong Yidong <cyd@stupidchicken.com>
7103
7104 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7105 incurred during fontification.
7106
6b1f9ba4
JB
71072011-03-25 Juanma Barranquero <lekktu@gmail.com>
7108
7109 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7110 (DEFVAR_PER_BUFFER): Don't pass it.
7111
7112 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7113 (scrolling_window): Don't pass it.
7114
0f4a96b5
JB
71152011-03-25 Juanma Barranquero <lekktu@gmail.com>
7116
7117 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7118
7119 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7120 and `suffix'.
7121 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7122 of variables specific to SELinux and computation of `encoded_absname'.
7123
7124 * image.c (XPutPixel): Remove unused variable `height'.
7125
7126 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7127
7128 * unexw32.c (get_section_info): Remove unused variable `section'.
7129
7130 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7131 (system_process_attributes): Remove unused variable `sess'.
7132 (sys_read): Remove unused variable `err'.
7133
7134 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7135 (w32_wnd_proc): Remove unused variable `isdead'.
7136 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7137 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7138 (x_create_tip_frame): Remove unused variable `tem'.
7139
7140 * w32inevt.c (w32_console_read_socket):
7141 Remove unused variable `no_events'.
7142
7143 * w32term.c (x_draw_composite_glyph_string_foreground):
7144 Remove unused variable `width'.
7145
1149507c
JB
71462011-03-24 Juanma Barranquero <lekktu@gmail.com>
7147
7148 * w32term.c (x_set_glyph_string_clipping):
7149 Don't pass uninitialized region to CombineRgn.
7150
9c88f339
JB
71512011-03-23 Juanma Barranquero <lekktu@gmail.com>
7152
7153 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7154 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7155 (Fx_close_connection): Remove unused variable `i'.
7156
7157 * w32font.c (w32font_draw): Return number of glyphs.
7158 (w32font_open_internal): Remove unused variable `i'.
7159 (w32font_driver): Add missing initializer.
7160
7161 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7162 (fill_in_menu): Remove unused variable `items_added'.
7163
7164 * w32term.c (last_mouse_press_frame): Remove static global variable.
7165 (w32_clip_to_row): Remove unused variable `f'.
7166 (x_delete_terminal): Remove unused variable `i'.
7167
7168 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7169 (NOTHING): Remove unused static global variable.
7170 (uniscribe_check_otf): Remove unused variable `table'.
7171 (uniscribe_font_driver): Add missing initializers.
7172
dee091a3
JD
71732011-03-23 Julien Danjou <julien@danjou.info>
7174
7175 * term.c (Fsuspend_tty, Fresume_tty):
7176 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7177 * window.c (temp_output_buffer_show):
7178 * insdel.c (signal_before_change):
7179 * frame.c (Fhandle_switch_frame):
7180 * fileio.c (Fdo_auto_save):
7181 * emacs.c (Fkill_emacs):
7182 * editfns.c (save_excursion_restore):
7183 * cmds.c (internal_self_insert):
7184 * callint.c (Fcall_interactively):
7185 * buffer.c (Fkill_all_local_variables):
7186 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7187 Use Frun_hooks.
0f4a96b5 7188 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7189 unconditionnaly since it does the check itself.
7190
2c520ab5 71912011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7192
c9c49752
PE
7193 Fix more problems found by GCC 4.5.2's static checks.
7194
8abc3f12
PE
7195 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7196 the first time through the loop, since we know p0 < p1 then.
7197 This also avoids a gcc -Wstrict-overflow warning.
7198
a2d26660
PE
7199 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7200 leading to a memory leak, possible in functions like
7201 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7202 of objects (Bug#8318).
a2d26660 7203
916c72e9
PE
7204 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7205 that could (at least in theory) be that large.
7206
19ab8a18
PE
7207 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7208 This is less likely to overflow, and avoids undefined behavior if
7209 overflow does occur. All callers changed. Use strtoul to scan
7210 for the unsigned long integer.
b7cbbd6f
PE
7211 (pint2hrstr): Simplify and tune code slightly.
7212 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7213
f0641eff
PE
7214 * scroll.c (do_scrolling): Work around GCC bug 48228.
7215 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7216
7f650bb9
PE
7217 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7218 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7219 (validate_x_resource_name): Simplify count usage.
7220 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7221
37dd57d1
PE
7222 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7223 fail (Bug#8306).
81e56e61 7224
699979fc 7225 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7226
401bf9b4
PE
7227 * process.c (Fmake_network_process): Use socklen_t, not int,
7228 where POSIX says socklen_t is required in portable programs.
7229 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7230 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7231 (Fmake_network_process, server_accept_connection):
7232 (wait_reading_process_output, read_process_output):
7233 Likewise.
7234
b93aacde
PE
7235 * process.c: Rename or move locals to avoid shadowing.
7236 (list_processes_1, Fmake_network_process):
7237 (read_process_output_error_handler, exec_sentinel_error_handler):
7238 Rename or move locals.
4dc343ee 7239 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7240 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7241 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7242 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7243 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7244
af8a867c 7245 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7246 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7247 Include tparam.h instead, since it declares them.
af8a867c
PE
7248 * cm.h (PC): Remove extern decl; tparam.h now does this.
7249 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7250 * terminfo.c: Include tparam.h, to check interfaces.
7251 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7252 (tparam): Adjust signature to match interface in tparam.h;
7253 this removes some undefined behavior. Check that outstring and len
7254 are zero, which they always are with Emacs.
7255 * tparam.h (PC, BC, UP): New extern decls.
7256
0248044d 7257 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7258 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7259
8ff096c1 7260 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7261 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7262 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7263 (ftfont_list): Remove unused local.
49eaafba
PE
7264 (get_adstyle_property, ftfont_pattern_entity):
7265 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7266 Rename locals to avoid shadowing.
8ff096c1 7267
e2be39f6
PE
7268 * xfont.c (xfont_list_family): Mark var as initialized.
7269
c9735e30
PE
7270 * xml.c (make_dom): Now static.
7271
8f5201ae
PE
7272 * composite.c (composition_compute_stop_pos): Rename local to
7273 avoid shadowing.
b246f932
PE
7274 (composition_reseat_it): Remove unused locals.
7275 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7276 (composition_update_it): Mark var as initialized.
11b61122
PE
7277 (find_automatic_composition): Mark vars as initialized,
7278 with a FIXME (Bug#8290).
8f5201ae 7279
760fbc2c
PE
7280 character.h: Rename locals to avoid shadowing.
7281 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7282 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7283 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7284 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7285 to avoid shadowing.
7286
ff08eb85
PE
7287 * textprop.c (property_change_between_p): Remove; unused.
7288
fc7bf025
PE
7289 * intervals.c (interval_start_pos): Now static.
7290
235d7abc
PE
7291 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7292
44f230aa
SM
7293 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7294 Rename locals to avoid shadowing.
3e7d6594 7295
50060332
PE
7296 * sound.c (wav_play, au_play, Fplay_sound_internal):
7297 Fix pointer signedness.
d01f234b 7298 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7299 (wav_play): Initialize a variable to 0, to prevent undefined
7300 behavior (Bug#8278).
50060332 7301
c4fc4e30
PE
7302 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7303
918436ed
PE
7304 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7305
c939f91b
PE
7306 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7307 clobbering (Bug#8298).
b9c7f648
PE
7308 * sysdep.c (sys_subshell): Likewise.
7309 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7310
6bd8c144
PE
7311 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7312 This should get cleaned up, so that child_setup has the
7313 same signature on all platforms.
7314
7710357c 7315 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7316 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7317
c59da222
CY
73182011-03-22 Chong Yidong <cyd@stupidchicken.com>
7319
7320 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7321 not to be necessary, and produces flickering.
7322
66b87493
GM
73232011-03-20 Glenn Morris <rgm@gnu.org>
7324
7325 * config.in: Remove file.
7326
45b6f6d5
JB
73272011-03-20 Juanma Barranquero <lekktu@gmail.com>
7328
7329 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7330 are now in src/globals.h.
7331 (syms_of_minibuf): Remove spurious & from previous change.
7332
3ec03f7e
LL
73332011-03-20 Leo <sdl.web@gmail.com>
7334
7335 * minibuf.c (completing-read-function): New variable.
7336 (completing-read-default): Rename from completing-read.
7337 (completing-read): Call completing-read-function.
7338
b14e3e21
CY
73392011-03-19 Juanma Barranquero <lekktu@gmail.com>
7340
7341 * xfaces.c (Fx_load_color_file):
7342 Read color file from absolute filename (bug#8250).
7343
f2b726e6
JB
73442011-03-19 Juanma Barranquero <lekktu@gmail.com>
7345
7346 * makefile.w32-in: Update dependencies.
7347
09f6ff02
EZ
73482011-03-17 Eli Zaretskii <eliz@gnu.org>
7349
7350 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7351
29a6015a
PE
73522011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7353
a3a6c54e
PE
7354 Fix more problems found by GCC 4.5.2's static checks.
7355
b766f867
PE
7356 * process.c (make_serial_process_unwind, send_process_trap):
7357 (sigchld_handler): Now static.
7358
be02381c
PE
7359 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7360 That way, the code declares only the vars that it needs.
7361 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7362 * s/cygwin.h (PTY_ITERATION): Likewise.
7363 * s/darwin.h (PTY_ITERATION): Likewise.
7364 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7365
57048744
PE
7366 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7367 * process.c (allocate_pty): Don't declare stb unless it's needed.
7368
7914961c 7369 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7370 (CONSTANTLIM): Remove; unused.
7371 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7372 Define only if needed.
7914961c 7373
b3967b18
PE
7374 * unexelf.c (unexec): Name an expression,
7375 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7376 Use a different way to cause a compilation error if anyone uses
7377 n rather than nn, a way that does not involve shadowing.
73366a00 7378 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7379
29a6015a
PE
7380 * deps.mk (unexalpha.o): Remove; unused.
7381
43cfc33e 7382 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7383 * unexec.h: New file.
ce701a33
PE
7384 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7385 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7386 Depend on unexec.h.
7387 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7388 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7389 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7390 Change as necessary to match prototype in unexec.h.
ce701a33 7391
01f44d5a
PE
7392 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7393 shadowing.
4f63c6bb 7394 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7395
a6670b0b
PE
7396 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7397 Rename locals to avoid shadowing.
7398
cef2010d 7399 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7400 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7401
d4d7173a
PE
7402 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7403
f08b802a
PE
7404 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7405 warning when compiling print.c.
7406
3ddb0639
PE
7407 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7408 instead of using an uninitialized var.
5ad03b97 7409 (font_sort_entities): Mark var as initialized.
3ddb0639 7410
170a2692
PE
7411 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7412
e663c700
PE
7413 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7414 pointers to constants.
89bc529a 7415 (font_parse_fcname): Remove unused vars.
7b81e2d0 7416 (font_delete_unmatched): Now static.
ea838e10 7417 (font_get_spec): Remove; unused.
13a547c6
PE
7418 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7419 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7420 Rename or move locals to avoid shadowing.
e663c700 7421
2a80c887 7422 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7423 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7424
1384fa33 7425 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7426 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7427
8b2c52e9
PE
7428 * alloc.c (mark_backtrace): Move decl from here ...
7429 * lisp.h: ... to here, so that it can be checked.
7430
475545b5 7431 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7432 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7433 (lisp_indirect_variable): Name an expression,
7434 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7435 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7436
b1349114 7437 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7438 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7439 Use const pointer when appropriate.
b1349114 7440
a2928364
PE
7441 * lisp.h (get_system_name, get_operating_system_release):
7442 Move decls here, to check interfaces.
7443 * process.c (get_operating_system_release): Move decl to lisp.h.
7444 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7445 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7446 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7447 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7448 (Fformat_time_string, Fencode_time, Finsert_char):
7449 (Ftranslate_region_internal, Fformat):
7450 Rename or remove local vars to avoid shadowing.
9710023e 7451 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7452
a415e694
PE
7453 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7454 avoid shadowing.
7455
8ef4622d
PE
7456 * lisp.h (eassert): Check that the argument compiles, even if
7457 ENABLE_CHECKING is not defined.
7458
946f9a5b
PE
7459 * data.c (Findirect_variable): Name an expression, to avoid
7460 gcc -Wbad-function-cast warning.
112396d6 7461 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7462 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7463 (Fmake_variable_buffer_local, Fmake_local_variable):
7464 Mark variables as initialized.
52746918 7465 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7466
e5aab7e7 7467 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7468 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7469 Rename locals to avoid shadowing.
dff45157
PE
7470 (mark_stack): Move local variables into the #ifdef region where
7471 they're used.
7bc26fdb
PE
7472 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7473 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7474 needed otherwise.
7475 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7476 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7477 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7478
e5aab7e7
PE
7479 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7480 avoids undefined behavior in theory.
7481
4da60324
PE
7482 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7483
88043301
PE
7484 Use functions, not macros, for up- and down-casing (Bug#8254).
7485 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7486 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7487 to use the following functions instead of these macros.
7488 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7489 EMACS_INT, since callers assume the returned value fits in int.
7490 (upcase1): Likewise, for UPCASE_TABLE.
7491 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7492 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7493 the race-condition problem in the old DOWNCASE.
88043301 7494
19ed5445
PE
7495 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7496 Rename locals to avoid shadowing.
7497 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7498 (regex_compile, re_search_2, re_match_2_internal):
7499 Remove unused local vars.
952db0d7
PE
7500 (FREE_VAR): Rewrite so as not to use empty "else",
7501 which gcc can warn about.
da053e48 7502 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7503 (RETALLOC_IF): Define only if needed.
7504 (WORDCHAR_P): Likewise. This one is never needed, but is used
7505 only in a comment talking about a compiler bug, so put inside
7506 the #if 0 of that comment.
7507 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7508 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7509 Remove; unused.
19ed5445 7510
1f3561e4 7511 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7512 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7513 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7514
ded6f8f7
PE
7515 * search.c (simple_search): Remove unused var.
7516
dbd37a95
PE
7517 * dired.c (compile_pattern): Move decl from here ...
7518 * lisp.h: ... to here, so that it can be checked.
7519 (struct re_registers): New forward decl.
7520
7e47afad
PE
7521 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7522
85f24f61
PE
7523 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7524 All uses changed.
7525 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7526 Rename locals to avoid shadowing.
5671df8f 7527 (Fvertical_motion): Mark locals as initialized.
85f24f61 7528
181aa2be 7529 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7530 (casify_region): Mark local as initialized.
181aa2be 7531
930d429c
PE
7532 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7533
7082eac6
PE
7534 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7535 New macros, so that the caller can use some names other than
7536 gcpro1, gcpro2, etc.
7537 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7538 of the new macros.
7539 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7540 argument, for consistency with GCPRO2_VAR, etc: it is now the
7541 prefix of the variable, not the variable itself. All uses
7542 changed.
38b2c076
PE
7543 * dired.c (directory_files_internal, file_name_completion):
7544 Rename locals to avoid shadowing.
7545
15206ed9
PE
7546 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7547 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7548 dired.c's scmp function, had undefined behavior.
7549 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7550 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7551 * buffer.h: ... to here, because these macros use current_buffer,
7552 and the new implementation with inline functions needs to have
7553 current_buffer in scope now, rather than later when the macros
7554 are used.
7555 (downcase, upcase1): New static inline functions.
7556 (DOWNCASE, UPCASE1): Reimplement using these functions.
7557 This avoids undefined behavior in expressions like
7558 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7559 from race conditions in accessing the global variables
7560 case_temp1 and case_temp2.
7561 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7562 * lisp.h (case_temp1, case_temp2): Remove their decls.
7563 * character.h (ASCII_CHAR_P): Move from here ...
7564 * lisp.h: ... to here, so that the inline functions mentioned
7565 above can use them.
7566
4a6bea26
PE
7567 * dired.c (directory_files_internal_unwind): Now static.
7568
f14b7e14
PE
7569 * fileio.c (file_name_as_directory, directory_file_name):
7570 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7571 Now static.
2893f146
PE
7572 (file_name_as_directory): Use const pointers when appropriate.
7573 (Fexpand_file_name): Likewise. In particular, newdir might
7574 point at constant storage, so make it a const pointer.
fd4ead52 7575 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7576 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7577 signedness issues.
f839df0c
PE
7578 (Fset_file_times, Finsert_file_contents, auto_save_error):
7579 Rename locals to avoid shadowing.
f14b7e14 7580
5716756e 7581 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7582 (Ftry_completion, Fall_completions): Rename or remove locals
7583 to avoid shadowing.
5716756e 7584
b4c3046a
PE
7585 * marker.c (bytepos_to_charpos): Remove; unused.
7586
b45db522
PE
7587 * lisp.h (verify_bytepos, count_markers): New decls,
7588 so that gcc does not warn that these functions aren't declared.
7589
85876d07
PE
7590 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7591 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7592 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7593 (copy_text): Remove unused local var.
85876d07 7594
03d78a21 7595 * filelock.c (within_one_second): Now static.
b3dd38ab 7596 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7597
5df8f01b
PE
7598 * buffer.c (fix_overlays_before): Mark locals as initialized.
7599 (fix_start_end_in_overlays): Likewise. This function should be
7600 simplified by using pointers-to-pointers, but that's a different
7601 matter.
b1d876f1 7602 (switch_to_buffer_1): Now static.
8f54f30a
PE
7603 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7604 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7605
a70072c9 7606 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7607 Fix pointer signedness issue.
edced198
PE
7608 (sys_subshell): Mark local as volatile if checking for lint,
7609 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7610 (MAXPATHLEN): Define only if needed.
a70072c9 7611
a0977c44
PE
7612 * process.c (serial_open, serial_configure): Move decls from here ...
7613 * systty.h: ... to here, so that they can be checked.
7614
a884fdcc
PE
7615 * fns.c (get_random, seed_random): Move extern decls from here ...
7616 * lisp.h: ... to here, so that they can be checked.
7617
604efe86 7618 * sysdep.c (reset_io): Now static.
b8950c94 7619 (wait_for_termination_signal): Remove; unused.
604efe86 7620
38fc62d9
PE
7621 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7622 (copy_keymap_item, append_key, push_text_char_description):
7623 Now static.
1004a21a 7624 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7625 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7626 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7627 (describe_map_tree):
7628 Rename locals to avoid shadowing.
38fc62d9 7629
2f2650da
PE
7630 * keyboard.c: Declare functions static if they are not used elsewhere.
7631 (echo_char, echo_dash, cmd_error, top_level_2):
7632 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7633 (read_char, kbd_buffer_get_event, make_lispy_position):
7634 (make_lispy_event, make_lispy_movement, apply_modifiers):
7635 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7636 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7637 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7638 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7639 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7640
a053e86c 7641 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7642 (mark_kboards): Move decl here ...
7643 * alloc.c (mark_kboards): ... from here.
a053e86c 7644
4752793e
PE
7645 * lisp.h (force_auto_save_soon): New decl.
7646
74f10ca7 7647 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7648 (DEFINE_DUMMY_FUNCTION): New macro.
7649 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7650 Use it.
c03cd23f
PE
7651 (main): Add casts to avoid warnings
7652 if GCC considers string literals to be constants.
74f10ca7 7653
022e70d4
PE
7654 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7655
59d6fe83
PE
7656 * dbusbind.c: Pointer signedness fixes.
7657 (xd_signature, xd_append_arg, xd_initialize):
7658 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7659 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7660 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7661 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7662
78320123
PE
7663 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7664 if GCC considers string literals to be constants.
49cebcca 7665 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7666
35ac2a97
SM
76672011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7668
fb103ca9
SM
7669 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7670 (print_preprocess, print_object): New macro to fix last change.
7671
35ac2a97
SM
7672 * print.c (print_preprocess): Don't forget font objects.
7673
62973b41
JB
76742011-03-16 Juanma Barranquero <lekktu@gmail.com>
7675
7676 * emacs.c (USAGE3): Doc fixes.
7677
0e48bb22
AS
76782011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7679
7680 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7681 structure.
7682
7684e57b
JB
76832011-03-14 Juanma Barranquero <lekktu@gmail.com>
7684
7685 * lisp.h (VWindow_system, Qfile_name_history):
7686 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7687 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7688 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7689
7690 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7691 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7692
7693 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7694 * w32console.c (detect_input_pending, read_input_pending)
7695 (encode_terminal_code):
7696 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7697 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7698 (w32_system_caret_y, Qfile_name_history):
7699 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7700 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7701 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7702 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7703 * w32proc.c (Qlocal, report_file_error):
7704 * w32term.c (Vwindow_system, updating_frame):
7705 * w32uniscribe.c (initialized, uniscribe_font_driver):
7706 Remove unneeded extern declarations.
7707
2aa46d6c
CY
77082011-03-14 Chong Yidong <cyd@stupidchicken.com>
7709
c96bbc66 7710 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7711
cffc6f3b
CY
77122011-03-13 Chong Yidong <cyd@stupidchicken.com>
7713
7714 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7715 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7716 These macros can no longer be used for assignment.
7717
44f230aa
SM
7718 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7719 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7720 (record_buffer_markers, fetch_buffer_markers): New functions for
7721 recording and fetching special buffer markers.
7722 (set_buffer_internal_1, set_buffer_temp): Use them.
7723
7724 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7725
7726 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7727
7728 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7729 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7730
7731 * xdisp.c (hscroll_window_tree):
7732 (reconsider_clip_changes): Use PT instead of BUF_PT.
7733
d251f04b
EZ
77342011-03-13 Eli Zaretskii <eliz@gnu.org>
7735
7736 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7737 $(EMACS_ROOT)/lib/intprops.h.
7738
f0c77cd1
PE
77392011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7740
3eca4629
PE
7741 Fix more problems found by GCC 4.5.2's static checks.
7742
7c86ee98
PE
7743 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7744 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7745 (xg_free_frame_widgets): Make it clear that a local variable is
7746 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7747 (gdk_window_get_screen): Make it clear that this macro is needed
7748 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7749 (int_gtk_range_get_value): New function, which avoids a diagnostic
7750 from gcc -Wbad-function-cast.
7751 (xg_set_toolkit_scroll_bar_thumb): Use it.
7752 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7753 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7754 (get_utf8_string, xg_get_file_with_chooser):
7755 Rename locals to avoid shadowing.
7756 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7757
41729b81
PE
7758 * xgselect.c (xg_select): Remove unused var.
7759
f0c77cd1
PE
7760 * image.c (four_corners_best): Mark locals as initialized.
7761 (gif_load): Initialize transparent_p to zero (Bug#8238).
7762 Mark another local as initialized.
ec6cf4c6 7763 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7764
ce0ad53d 7765 * image.c (clear_image_cache): Now static.
d5d5a617 7766 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7767 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7768 (x_edge_detection): Remove unnecessary cast that
7769 gcc -Wbad-function-cast diagnoses.
2037898d 7770 (gif_load): Fix pointer signedness.
6ae141d6
PE
7771 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7772 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7773
33383987 77742011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7775
d32df629
PE
7776 Improve quality of tests for time stamp overflow.
7777 For example, without this patch (encode-time 0 0 0 1 1
7778 1152921504606846976) returns the obviously-bogus value (-948597
7779 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7780 reports time overflow. See
7781 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7782 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7783 * editfns.c: Include limits.h and intprops.h.
7784 (TIME_T_MIN, TIME_T_MAX): New macros.
7785 (time_overflow): Move earlier, to before first use.
7786 (hi_time, lo_time): New functions, for an accurate test for
7787 out-of-range times.
7788 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7789 (Fget_internal_run_time): Don't assume time_t fits in int.
7790 (make_time): Use list2 instead of Fcons twice.
7791 (Fdecode_time): More accurate test for out-of-range times.
7792 (check_tm_member): New function.
7793 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7794 (lisp_time_argument): Don't rely on undefined left-shift and
7795 right-shift behavior when checking for time stamp overflow.
8be6f318 7796
fe31d94c
PE
7797 * editfns.c (time_overflow): New function, refactoring common code.
7798 (Fformat_time_string, Fdecode_time, Fencode_time):
7799 (Fcurrent_time_string): Use it.
7800
8be6f318
PE
7801 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7802 * dired.c (make_time): Move to ...
7803 * editfns.c (make_time): ... here.
7804 * systime.h: Note the move.
7805
09d9db2c 78062011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7807
126bc0dc
YM
7808 * fringe.c (update_window_fringes): Remove unused variables.
7809
c47cbdfd
YM
7810 * unexmacosx.c (copy_data_segment): Also copy __got section.
7811 (Bug#8223)
7812
7ac80be9
EZ
78132011-03-12 Eli Zaretskii <eliz@gnu.org>
7814
c96bbc66 7815 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7816 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7817 Constify `char *' arguments and their references according to
7818 prototypes in tparam.h.
7819
ecb0f94d 7820 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7821
7ac80be9
EZ
7822 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7823 Adapt all references accordingly.
7824
7825 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7826
ef1fd07e
TT
78272011-03-11 Tom Tromey <tromey@redhat.com>
7828
7829 * buffer.c (syms_of_buffer): Remove obsolete comment.
7830
7ef4b50c
EZ
78312011-03-11 Eli Zaretskii <eliz@gnu.org>
7832
7833 * termhooks.h (encode_terminal_code): Declare prototype.
7834
7835 * msdos.c (encode_terminal_code): Don't declare prototype.
7836
7837 * term.c (encode_terminal_code): Now external again, used by
7838 w32console.c and msdos.c.
7839
44f230aa
SM
7840 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7841 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7842
4b1ec863 78432011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7844
1714f52b 7845 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7846
4b1ec863
PE
7847 * fringe.c (update_window_fringes): Mark locals as initialized
7848 (Bug#8227).
7849 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7850
524c7aa6
PE
7851 * alloc.c (mark_fringe_data): Move decl from here ...
7852 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7853 to check its interface.
7854 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7855
a5c0af81 7856 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7857 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7858 (fontset_font): Mark local as initialized.
a9a06e0b 7859 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7860
b4716021
PE
7861 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7862
811e9bac 7863 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7864 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7865 (x_own_selection, Fx_disown_selection_internal): Rename locals
7866 to avoid shadowing.
7867 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7868
7e3ab302
PE
7869 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7870 so that the caller can use some name other than gcpro1.
7871 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7872 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7873 (Fx_backspace_delete_keys_p):
7874 Use them to avoid shadowing, and rename vars to avoid shadowing.
7875 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7876 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7877 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7878 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7879 Remove unused locals.
7e3ab302
PE
7880 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7881 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7882 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7883 macros.
f78faa98 7884
e2b13473
PE
7885 * xterm.h (x_mouse_leave): New decl.
7886
77f23912
PE
7887 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7888 Remove unused functions.
cdf4ba58
PE
7889 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7890 (x_calc_absolute_position): Now static.
7411c686 7891 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7892 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7893 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7894 unless they are used.
38d0b34a
PE
7895 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7896 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7897 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7898 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7899 (x_error_catcher, x_connection_closed, x_error_handler):
7900 (x_error_quitter, xembed_send_message, x_iconify_frame):
7901 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7902 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7903 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7904
44f230aa
SM
7905 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7906 Rename or move locals to avoid shadowing.
6b463e58 7907 (tty_defined_color, merge_face_heights): Now static.
5967d051 7908 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7909 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7910 does not deduce is never used uninitialized.
73719eba
PE
7911 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7912 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7913
426994c3 7914 * terminal.c (store_terminal_param): Now static.
5489860b 7915
032f1620 7916 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7917 (set_frame_menubar): Remove unused local.
d4323972 7918 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7919 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7920 since they might point to immutable storage.
281585b0
PE
7921 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7922 since it's unused otherwise.
032f1620 7923
367c19e5 7924 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7925 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7926 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7927 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7928 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7929 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7930 does not deduce are never used uninitialized.
70739cbe 7931
07b48fa9
PE
7932 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7933
8868a238 7934 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7935 * window.c (window_loop, size_window):
7936 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7937
7e5cf297 7938 * window.c (display_buffer): Now static.
d6550a9f
PE
7939 (size_window): Mark variables that gcc -Wuninitialized
7940 does not deduce are never used uninitialized.
a586633d
PE
7941 * window.h (check_all_windows): New decl, to forestall
7942 gcc -Wmissing-prototypes diagnostic.
5b555da1 7943 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7944
f6095868
PE
7945 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7946 shadowing.
7947 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7948 Include <limits.h>.
7949 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7950 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7951 (load_charset_map): Mark variables that gcc -Wuninitialized
7952 does not deduce are never used uninitialized.
53df7c11 7953 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7954
f38b440c
PE
7955 * coding.c (coding_set_source, coding_set_destination):
7956 Use "else { /* comment */ }" rather than "else /* comment */;"
7957 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7958 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7959 a block, when the outer 'i' will do.
7960 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7961 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7962 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7963 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7964 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7965 Rename locals to avoid shadowing.
7966 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7967 * coding.c (emacs_mule_char, encode_invocation_designation):
7968 Now static, since they're not used elsewhere.
413bb2db 7969 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7970 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7971 (decode_coding_emacs_mule): Mark variables that gcc
7972 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7973 (detect_coding_iso_2022): Initialize a local variable that might
7974 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7975 this initialization is needed. (Bug#8211)
5f58e762
PE
7976 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7977 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7978 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7979 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7980 Remove unused macros.
f38b440c 7981
232b38b9 7982 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7983 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7984 * character.c (string_count_byte8): Likewise.
232b38b9 7985
fb90da1b
PE
7986 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7987 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7988
fb93dbc2
PE
7989 * chartab.c (copy_sub_char_table): Now static, since it's not used
7990 elsewhere.
5c156ace
PE
7991 (sub_char_table_ref_and_range, char_table_ref_and_range):
7992 Rename locals to avoid shadowing.
bbcd0949 7993 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7994
7d3b3862 7995 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7996 (BIDI_BOB): Remove unused macro.
7d3b3862 7997
6be7d3da
PE
7998 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7999 deduce are never used uninitialized.
c2ed9c8b 8000 * term.c (encode_terminal_code): Likewise.
6be7d3da 8001
75f8807f 8002 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8003
50938595
PE
8004 * tparam.h: New file.
8005 * term.c, tparam.h: Include it.
8006 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8007 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8008 Move these decls to tparam.h, and make them agree with what
8009 is actually in tparam.c. The previous trick of using incompatible
8010 decls in different modules does not conform to the C standard.
8011 All callers of tparam changed to use tparam's actual API.
8012 * tparam.c (tparam1, tparam, tgoto):
8013 Use const pointers where appropriate.
8014
fbceeba2
PE
8015 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8016 * cm.h (struct cm): Likewise.
8017 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8018 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8019 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8020 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8021 (turn_on_face, init_tty): Likewise.
8022 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8023
7f3f1250
PE
8024 * term.c (term_mouse_position): Rename local to avoid shadowing.
8025
e6ca6543
PE
8026 * alloc.c (mark_ttys): Move decl from here ...
8027 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8028
c40f8d15
AS
80292011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8030
8031 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8032
cfe0661d
JB
80332011-03-09 Juanma Barranquero <lekktu@gmail.com>
8034
8035 * search.c (compile_pattern_1): Remove argument regp, unused since
8036 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8037 (compile_pattern): Don't pass it.
8038
0afb4571
J
80392011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8040
8041 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8042 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8043 for ! HAVE_GTK3.
8044 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8045
8046 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8047
8048 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8049 gdk_window_get_screen, gdk_window_get_geometry,
8050 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8051 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8052 (xg_get_pixbuf_from_pixmap): New function.
8053 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8054 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8055 Call xg_get_pixbuf_from_pixmap instead of
8056 gdk_pixbuf_get_from_drawable.
8057 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8058 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8059 (xg_check_special_colors): Use GtkStyleContext and its functions
8060 for HAVE_GTK3.
8061 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8062 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8063 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8064 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8065 Call gtk_widget_get_preferred_size.
0afb4571
J
8066 (xg_frame_resized): gdk_window_get_geometry only takes 5
8067 parameters.
44f230aa
SM
8068 (xg_win_to_widget, xg_event_is_for_menubar):
8069 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8070 (xg_set_widget_bg): New function.
8071 (delete_cb): New function.
895009e1 8072 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8073 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8074 (xg_set_background_color): Call xg_set_widget_bg.
8075 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8076 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8077 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8078 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8079 if ! HAVE_GTK3.
8080 (update_frame_tool_bar): Call gtk_widget_hide.
8081 (xg_initialize): Use GDK_KEY_g.
8082
8083 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8084 if ! HAVE_GTK3
8085 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8086
8087 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8088 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8089 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8090
1c2cc4ef
JB
80912011-03-08 Juanma Barranquero <lekktu@gmail.com>
8092
8093 * w32xfns.c (select_palette): Check success of RealizePalette against
8094 GDI_ERROR, not zero.
8095
33383987 8096See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8097
8098;; Local Variables:
8099;; coding: utf-8
aac0c6e3
MR
8100;; End:
8101
33383987 8102 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8103
8104 This file is part of GNU Emacs.
8105
8106 GNU Emacs is free software: you can redistribute it and/or modify
8107 it under the terms of the GNU General Public License as published by
8108 the Free Software Foundation, either version 3 of the License, or
8109 (at your option) any later version.
8110
8111 GNU Emacs is distributed in the hope that it will be useful,
8112 but WITHOUT ANY WARRANTY; without even the implied warranty of
8113 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8114 GNU General Public License for more details.
8115
8116 You should have received a copy of the GNU General Public License
8117 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.