gnus-art.el (gnus-article-stop-animations): Use gnus-timer--function that is an alias...
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d59a1afb
DA
12012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Function to mark objects and remove killed buffers at once.
4 * alloc.c (discard_killed_buffers): Rename to ...
5 (mark_discard_killed buffers) ... new name. Add marking
6 of remaining objects. Fix comment. Adjust users.
7 (mark_object): Do not touch frame buffer lists here.
8 * frame.c (delete_frame): Reset frame buffer lists here.
9
5f0cb45a
PE
102012-09-13 Paul Eggert <eggert@cs.ucla.edu>
11
8ea47e3a
PE
12 Better workaround for GNOME bug when --enable-gcc-warnings.
13 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
14 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
15 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
16
4a4bbad2
PE
17 Simplify SIGIO usage (Bug#12408).
18 The code that dealt with SIGIO was crufty and confusing, e.g., it
19 played tricks like "#undef SIGIO" but these tricks were not used
20 consistently. Simplify mostly by not #undeffing standard symbols,
21 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
22 or not as we please) rather than "defined SIGIO" (standard symbol
23 that we probably shouldn't #undef).
24 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
25 Modules that need it can include it.
26 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
27 * dispextern.h (ignore_sigio): New decl.
28 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
29 unconditionally, since it's now a no-op if !USABLE_SIGIO.
30 * emacs.c (shut_down_emacs):
31 * keyboard.c (kbd_buffer_store_event_hold):
32 Use ignore_sigio rather than invoking 'signal' directly.
33 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
34 for FIONREAD.
35 (FIONREAD, SIGIO): Do not #undef.
36 (tty_read_avail_input): Use #error rather than a syntax error.
37 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
38 for I_PIPE, used by SETUP_SLAVE_PTY.
39 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
40 * sysdep.c (croak): Remove; no longer needed. This bit of
41 temporary code, with Fred N. Fish's comment that it's temporary,
42 has been in Emacs since at least 1992!
43 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
44 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
45 * syssignal.h (croak): Remove decl.
46 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
47 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
48 now that we're termios-only.
49 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
50 * term.c (dissociate_if_controlling_tty): Use #error rather than
51 a run-time error.
52
5f0cb45a
PE
53 Work around GCC and GNOME bugs when --enable-gcc-warnings.
54 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
55 to work around GNOME bug 683906.
56 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
57 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
58 This works around GCC bug 54561.
59
40bce90b
PE
602012-09-12 Paul Eggert <eggert@cs.ucla.edu>
61
62 More fixes for 'volatile' and setjmp/longjmp.
63 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
64 * image.c (struct png_load_context) [HAVE_PNG]: New type.
65 (png_load_body) [HAVE_PNG]:
66 (jpeg_load_body) [HAVE_JPEG]:
67 New function, with most of the old parent function's body.
68 (png_load) [HAVE_PNG]:
69 (jpeg_load) [HAVE_JPEG]:
70 Invoke the new function, to avoid longjmp munging our locals.
71 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
72 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
73 longjmp is passed 2, as the C standard doesn't guarantee this.
74 Instead, store the failure code into mgr->failure_code.
75
bfeae2cf
SM
762012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
77
78 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
79 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
80 (syms_of_keyboard): Remove support for unread-command-char.
81
8099e36b
EZ
822012-09-12 Eli Zaretskii <eliz@gnu.org>
83
84 * w32proc.c (sys_kill): If PID is our process ID and the signal is
85 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
86 violation. (Bug#12426)
87
92547ff9
PE
882012-09-12 Paul Eggert <eggert@cs.ucla.edu>
89
90 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
91
45b82ad0
SM
922012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
93
94 * eval.c: Add `inhibit-debugger'.
95 (Qinhibit_debugger): New symbol.
96 (call_debugger): Bind it instead of Qdebug_on_error.
97 (maybe_call_debugger): Test Vinhibit_debugger.
98 (syms_of_eval): Define inhibit-debugger.
99 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
100 (syms_of_xdisp): Remove inhibit-debug-on-message.
101
5779a1dc
PE
1022012-09-11 Paul Eggert <eggert@cs.ucla.edu>
103
50f2e553
PE
104 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
105 If a nonvolatile local variable is written before a _longjmp to
106 the frame containing the variable, and is read after the _longjmp,
107 the value read is indeterminate. Some local variables of type
108 'struct handler' and 'struct catchtag' are used in this way, so
109 mark each of their slots as volatile if the slot can be set before
110 _longjmp and read afterwards.
111 * lisp.h (struct handler): var and chosen_clause are now volatile.
112 (struct catchtag): val, next, and pdlcount are now volatile.
113
ae1d87e2
PE
114 * bidi.c (bidi_push_it, bidi_pop_it):
115 * fns.c (copy_hash_table):
116 * image.c (define_image_type):
117 * keyboard.c (kbd_buffer_store_event_hold):
118 * process.c (Fprocess_send_eof):
119 * xfaces.c (x_create_gc) [HAVE_NS]:
120 * xgselect.c (xg_select):
121 Prefer assignment to memcpy when either will do.
122
5779a1dc
PE
123 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
124 Use pointer-to-a-pointer to simplify and avoid a NILP check each
125 time an item is removed. No need to mark this function 'inline';
126 the compiler knows better than we do.
127
c4c9756b
JD
1282012-09-11 Jan Djärv <jan.h.d@swipnet.se>
129
130 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
131 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
132 to change_frame_size (Bug#12388).
133 (windowDidResize:): Pass YES to updateFrameSize.
134
135 * nsterm.h: Add delay parameter to updateFrameSize.
136
d73e321c
DA
1372012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
138
139 Discard killed buffers from deleted window and frame objects.
140 This reduces an amount of references to killed buffers and
141 helps GC to reclaim them faster.
142 * alloc.c (discard_killed_buffers): New function.
143 (mark_object): Use it for deleted windows and frames.
144 (mark_object): If symbol's value is set up for a killed buffer
145 or deleted frame, restore it's global binding.
146 * data.c (swap_in_global_binding): Add GC notice.
147 (swap_in_symval_forwarding): Use convenient set_blv_where.
148 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
149 * window.h: ... to here.
150
e578f381
DA
1512012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
152
153 Convenient macro to check whether the buffer is live.
154 * buffer.h (BUFFER_LIVE_P): New macro.
155 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
156 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
157
3057e615
YM
1582012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
159
160 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
161 composition cases (Bug#12364).
162
163 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
164 overhang of succeeding glyphs overlapping box cursor.
165
166 * w32term.c (x_draw_glyph_string): Likewise.
167
6fda35f2
PE
1682012-09-11 Paul Eggert <eggert@cs.ucla.edu>
169
c990426a
PE
170 Simplify, document, and port floating-point (Bug#12381).
171 The porting part of this patch fixes bugs on non-IEEE platforms
172 with frexp, ldexp, logb.
173 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
174 Now static.
175 * floatfns.c: Simplify discussion of functions that Emacs doesn't
176 support, by removing commented-out code and briefly listing the
177 C89 functions excluded. The commented-out stuff was confusing
178 maintenance, e.g., we thought we needed cbrt but it was commented out.
179 (logb): Remove decl; no longer needed.
180 (isfinite): New macro, if not already supplied.
181 (isnan): Don't replace any existing macro.
182 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
183 are present on all C89 platforms.
184 (Ffrexp): Do not special-case zero, as frexp does the right thing
185 for that case.
186 (Flogb): Do not use logb, as it doesn't have the desired meaning
187 on hosts that use non-base-2 floating point. Instead, stick with
188 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
189 frexp, to avoid getting an unspecified result.
190
6fda35f2
PE
191 * xdisp.c (Qinhibit_debug_on_message): Now static.
192
16130a58
JD
1932012-09-10 Jan Djärv <jan.h.d@swipnet.se>
194
195 * nsterm.m (ns_update_begin): Set clip path to whole view by using
196 NSBezierPath (Bug#12131).
197
d105a573
CY
1982012-09-10 Chong Yidong <cyd@gnu.org>
199
200 * fns.c (Fdelq, Fdelete): Doc fix.
201
ff55dfe8
PE
2022012-09-10 Paul Eggert <eggert@cs.ucla.edu>
203
204 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
205 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
206
e7032e7c
SM
2072012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
208
209 * lisp.h (make_lisp_ptr): New macro to replace XSET.
210 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
211 Use it.
212
e9957956
EZ
2132012-09-09 Eli Zaretskii <eliz@gnu.org>
214
aba05ce9
EZ
215 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
216 left fringe if the window has a left margin. This avoids leaving
217 traces of the cursor because its leftmost pixel is not drawn over.
218
e9957956
EZ
219 * dispnew.c (update_window_line): When the left margin area of a
220 screen line is updated, set the redraw_fringe_bitmaps_p flag of
221 that screen line. (Bug#12277)
222
f6196b87
PE
2232012-09-09 Paul Eggert <eggert@cs.ucla.edu>
224
225 Assume C89 or later for math functions (Bug#12381).
226 This simplifies the code, and makes it a bit smaller and faster,
227 and (most important) makes it easier to clean up signal handling
228 since we can stop worring about floating-point exceptions in
229 library code. That was a problem before C89, but the problem
230 went away many years ago on all practical Emacs targets.
231 * data.c, image.c, lread.c, print.c:
232 Don't include <math.h>; no longer needed.
233 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
234 might be autoconfigured, as that never happens.
235 * data.c (fmod):
236 * doprnt.c (DBL_MAX_10_EXP):
237 * print.c (DBL_DIG):
238 Remove. C89 or later always defines these.
239 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
240 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
241 (arith_error, domain_error, domain_error2):
242 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
243 no longer needed -- we simply return what C returns. All uses removed.
244 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
245 the wrapped code.
246 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
247 Remove. All uses expanded, as these macros are no longer used
248 more than once and are now more trouble than they're worth.
249 (Ftan): Use tan, not sin / cos.
250 (Flogb): Assume C89 frexp.
251 (fmod_float): Assume C89 fmod.
252 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
253 (init_floatfns): Remove. All uses removed.
254
9d7f1863
JD
2552012-09-08 Jan Djärv <jan.h.d@swipnet.se>
256
257 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
258 compositeToPoint for OSX < 10.6 (Bug#12390).
259
eabf0404
PE
2602012-09-08 Paul Eggert <eggert@cs.ucla.edu>
261
262 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
263 This produces more-accurate results.
264
0b3b1d23
JD
2652012-09-08 Jan Djärv <jan.h.d@swipnet.se>
266
267 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
268 changes (Bug#12088).
269
6dcef6ec
CY
2702012-09-08 Chong Yidong <cyd@gnu.org>
271
272 * syntax.c (Fstring_to_syntax): Doc fix.
273
aa7d57c5
JD
2742012-09-08 Jan Djärv <jan.h.d@swipnet.se>
275
276 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
277 in the internal border.
278 (x_set_window_size): Remove static variables and their usage.
279 (ns_redraw_scroll_bars): Fix NSTRACE arg.
280 (ns_after_update_window_line, ns_draw_fringe_bitmap): Remove
281 fringe/internal border adjustment (Bug#11052).
282 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
283 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
284 (ns_fix_rect_ibw): Remove.
285 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
286 (ns_dumpglyphs_box_or_relief): Ditto.
287 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
288 adjustment.
289 (ns_dumpglyphs_image): Ditto.
290 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
291 border adjustment.
292 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
293 their usage. Add fringe_extended_p and its use as in other terms.
294 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
295 scroll bar was removed.
296 (updateFrameSize): New function.
297 (windowDidResize): Move code to updateFrameSize and call it.
298
299 * nsterm.h (EmacsView): Add updateFrameSize.
300
1a5432bc
CY
3012012-09-07 Chong Yidong <cyd@gnu.org>
302
b4f5313e
CY
303 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
304
1a5432bc
CY
305 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
306
1a4f1e9b
PE
3072012-09-07 Paul Eggert <eggert@cs.ucla.edu>
308
309 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
310 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
311 Problem introduced when merging patches. Noted by Eli Zaretskii in
312 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
313 * floatfns.c: Comment fix.
314 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
315 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
316 and anyway the declaration is harmless even if SIGDANGER is not defined.
317 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
318 defined BROKEN_FIONREAD). systty.h formerly did this, but other
319 source files not surprisingly expected syssignal.h to define, or
320 not define, SIGIO, and it's cleaner to do it that way, for consistency.
321 Include <sys/ioctl.h>, for FIONREAD.
322 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
323 This eliminates a problem whereby other files mysteriously had
324 to include "syssignal.h" before including "systty.h" if they
325 wanted to use "#ifdef SIGIO".
326
bc8000ff
EZ
3272012-09-07 Eli Zaretskii <eliz@gnu.org>
328
3e6d6928
EZ
329 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
330
331 * w32.c (sigemptyset): Empty the set.
332 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
333
bc8000ff
EZ
334 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
335
b4fa72f2
DA
3362012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
337
338 * alloc.c (mark_buffer): Revert unsafe marking optimization.
339 (mark_object): Likewise for frame objects.
340
30730c93
PE
3412012-09-07 Paul Eggert <eggert@cs.ucla.edu>
342
343 * syssignal.h (handle_on_main_thread): Always declare,
344 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
345 This ports to platforms without HAVE_PTHREAD.
346
2fe28299
PE
3472012-09-06 Paul Eggert <eggert@cs.ucla.edu>
348
349 Signal-handler cleanup (Bug#12327).
350 Emacs's signal handlers were written in the old 4.2BSD style with
351 sigblock and sigmask and so forth, and this led to some
352 inefficiencies and confusion. Rewrite these to use
353 pthread_sigmask etc. without copying signal sets around. Also,
354 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
355 'signal', and instead use functions that do not attempt to take
356 over the system name space. This patch causes Emacs's text
357 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
358 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
359 Do not include <signal.h> or "syssignal.h", as these
360 modules do not use signals.
361 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
362 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
363 Do not include <signal.h>, as "syssignal.h" does that for us now.
364 * atimer.c (sigmask_atimers): New function.
365 (block_atimers, unblock_atimers): New functions,
366 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
367 All uses replaced.
368 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
369 no longer needed here.
370 * emacs.c (main): Inspect existing signal handler with sigaction,
371 so that there's no need to block and unblock SIGHUP.
372 * sysdep.c (struct save_signal): New member 'action', replacing
373 old member 'handler'.
374 (save_signal_handlers, restore_signal_handlers):
375 Use sigaction instead of 'signal' to save and restore.
376 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
377 New function. All users of 'signal' modified to use set_sighandler
378 if they're writeonly, and to use sys_signal if they're read+write.
379 (emacs_sigaction_init, forwarded_signal): New functions.
380 (sys_signal): Remove. All uses replaced by calls to sigaction
381 and emacs_sigaction_init, or by direct calls to 'signal'.
382 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
383 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
384 all uses replaced by pthread_sigmask etc. calls.
385 * syssignal.h: Include <signal.h>.
386 (emacs_sigaction_init, forwarded_signal): New decls.
387 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
388 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
389 (sigmask, sys_sigmask): Remove; no longer needed.
390 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
391 (sigblock, sigunblock, sigfree):
392 (sigsetmask) [!defined sigsetmask]:
393 Remove. All uses replaced by pthread_sigmask.
394 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
395 no longer need to be replaced, and its typical old uses
396 are now done via emacs_sigaction_init and sigaction.
397 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
398 (sys_sigdel): Remove; unused.
399 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
400
0216c128
EZ
4012012-09-06 Eli Zaretskii <eliz@gnu.org>
402
403 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
404 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
405
c752cfa9
DA
4062012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
407
408 Explicitly mark buffer_defaults and buffer_local_symbols.
409 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
410 mark_local_symbols here.
411 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
412 since special buffers aren't marked here any more.
413 (allocate_buffer): Chain new buffer with all_buffers here...
414 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
415 not here.
416 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
417 (syms_of_buffer): Remove staticpro of the above.
418 (init_buffer_once): Set names for buffer_defaults and
419 buffer_local_symbols.
420
a864ef14
PE
4212012-09-06 Paul Eggert <eggert@cs.ucla.edu>
422
423 Use bool for booleans in font-related modules.
424 * font.c (font_intern_prop, font_style_to_value)
425 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
426 (generate_otf_features, font_check_otf_features, font_check_otf)
427 (font_match_p, font_list_entities, font_at):
428 * fontset.c (fontset_id_valid_p, reorder_font_vector
429 (fontset_find_font, Fset_fontset_font)
430 (face_suitable_for_char_p) [0]:
431 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
432 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
433 (m17n_flt_initialized, ftfont_shape_by_flt):
434 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
435 * nsfont.m (nsfont_draw):
436 * w32font.c (w32font_draw):
437 * w32term.c (x_draw_glyphless_glyph_string_foreground):
438 Use bool for booleans.
439 * font.h: Adjust to above API changes.
440 (struct font, struct font_driver, struct font_driver_list):
441 Use bool for booleans.
442 (struct font): Remove useless member encoding_type.
443 All users removed.
444 * fontset.c, xftfont.c: Omit unnecessary static decls.
445
0699fc18
DA
4462012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
447
448 * alloc.c (mark_object): Revert window marking code
449 since it's unsafe for the Fset_window_configuration.
450
20ef56db
PE
4512012-09-05 Paul Eggert <eggert@cs.ucla.edu>
452
2fe28299 453 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
454 Be more systematic about preserving errno whenever a signal
455 handler returns, even if it's not in the main thread. Do this by
456 renaming signal handlers to distinguish between signal delivery
457 and signal handling. All uses changed.
458 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
459 * data.c (deliver_arith_signal): Rename from arith_error.
460 * dispnew.c (deliver_window_change_signal): Rename from
461 window_change_signal.
462 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
463 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
464 * keyboard.c (deliver_input_available_signal): Rename from
465 input_available_signal.
466 (deliver_user_signal): Rename from handle_user_signal.
467 (deliver_interrupt_signal): Rename from interrupt_signal.
468 * process.c (deliver_pipe_signal): Rename from send_process_trap.
469 (deliver_child_signal): Rename from sigchld_handler.
470 * atimer.c (handle_alarm_signal):
471 * data.c (handle_arith_signal):
472 * dispnew.c (handle_window_change_signal):
473 * emacs.c (handle_fatal_signal, handle_danger_signal):
474 * keyboard.c (handle_input_available_signal):
475 * keyboard.c (handle_user_signal, handle_interrupt_signal):
476 * process.c (handle_pipe_signal, handle_child_signal):
477 New functions, with the actual signal-handling code taken from the
478 original respective signal handlers, sans the sporadic attempts to
479 preserve errno, since that's now done by handle_on_main_thread.
480 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
481 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
482 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
483 Move to sysdep.c.
484 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
485 Move initialization of main_thread to sysdep.c's init_signals.
486 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
487 our usage, and simplifies the mainline code.
488 (record_child_status_change): New static function, as a helper
489 for handle_child_signal, and with most of the old child handler's
490 contents.
491 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
492 (handle_child_signal): Use the above.
493 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
494 Moved here from emacs.c.
495 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
496 code moved here from emacs.c's main function.
497 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
498 replacing the old SIGNAL_THREAD_CHECK. All uses changed. This
499 lets callers save and restore errno properly.
500
e3ccf108
DA
5012012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
502
503 Remove redundant or unused things here and there.
504 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
505 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
506 * editfns.c (Fcompare_buffer_substrings): Likewise.
507 * frame.h (struct terminal, struct font_driver_list):
508 Remove redundant declarations.
509 * window.h (Qleft, Qright): Likewise.
510
697e1e39
DA
5112012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
512
513 Do not mark objects from deleted buffers, windows and frames.
514 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
515 (mark_object): Likewise for windows and frames.
516
c1ca42ca
DA
5172012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
518
519 * alloc.c (valid_lisp_object_p): Treat killed buffers,
520 buffer_defaults and buffer_local_symbols as valid objects.
521 Return special value to denote them.
522
014d93be
PE
5232012-09-05 Paul Eggert <eggert@cs.ucla.edu>
524
f75d7a91
PE
525 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
526 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
527 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
528 (file_name_absolute_p, Fsubstitute_in_file_name):
529 (check_executable, check_writable, Ffile_accessible_directory_p)
530 (Fset_file_selinux_context, Fdefault_file_modes)
531 (Finsert_file_contents, choose_write_coding_system)
532 (Fwrite_region, build_annotations, a_write, e_write)
533 (Fdo_auto_save):
534 * filelock.c (boot_time_initialized, get_boot_time)
535 (get_boot_time_1, lock_file_1, within_one_second):
536 * floatfns.c (in_float):
537 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
538 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
539 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
540 * lisp.h (struct Lisp_Hash_Table.cmpfn):
541 * window.c (compare_window_configurations):
542 Use bool for booleans.
543 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
544 (Fdefault_file_modes): Now mode_t, not int, for modes.
545 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
546 (internal_delete_file): Now returns void, not a (boolean) int,
547 since nobody was looking at the return value.
548 * lisp.h, window.h: Adjust to above API changes.
549
014d93be
PE
550 * xdisp.c (set_message): Simplify and reindent last change.
551
776f29e1
JB
5522012-09-05 Juanma Barranquero <lekktu@gmail.com>
553
554 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
555
7f7e0167
LI
5562012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
557
558 * eval.c (call_debugger): Make the function non-static so that we
559 can call it from set_message.
560
561 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
562 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
563
cf29dd84
PE
5642012-09-04 Paul Eggert <eggert@cs.ucla.edu>
565
566 Give more-useful info on a fatal error (Bug#12328).
567 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
568 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
569 of doing the work ourselves.
570 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
571 do most of the work.
572 (fatal_error_backtrace): New function, taken from the guts
573 of the old fatal_error_signal, but with a new option to output
574 a backtrace.
575 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
576 info about the signal than just its number.
577 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
578 * sysdep.c: Include <execinfo.h>
579 (emacs_backtrace): New function, taken partly from the previous
580 code of the 'die' function.
581 (emacs_abort): Call fatal_error_backtrace rather than abort.
582
972debf2
SM
5832012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
584
585 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
586 eager (load-time) macro-expansion.
587 * lisp.mk (lisp): Add macroexp.
588
1088b922
PE
5892012-09-04 Paul Eggert <eggert@cs.ucla.edu>
590
591 Simplify redefinition of 'abort' (Bug#12316).
592 Do not try to redefine the 'abort' function. Instead, redo
593 the code so that it calls 'emacs_abort' rather than 'abort'.
594 This removes the need for the NO_ABORT configure-time macro
595 and makes it easier to change the abort code to do a backtrace.
596 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
597 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
598 Remove; sysdep.c's emacs_abort now takes its place.
599 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
600 'abort' changed to use 'emacs_abort'.
601 * msdos.c (dos_abort) [defined abort]: Remove; not used.
602 (abort) [!defined abort]: Rename to ...
603 (emacs_abort): ... new name.
604 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
605 the place of the old 'abort' in emacs.c.
606 * w32.c, w32fns.c (abort): Do not #undef.
607 * w32.c (emacs_abort): Rename from w32_abort.
608
30934d33
EZ
6092012-09-04 Eli Zaretskii <eliz@gnu.org>
610
611 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
612 offsets[j].dv, since the y axis of the screen coordinates points
613 down, while the y axis of the font definition coordinates points
614 up. This fixes display of Arabic diacritics such as KASRA and
615 KASRATAN. (Bug#11860)
616
af26b72c
PE
6172012-09-04 Paul Eggert <eggert@cs.ucla.edu>
618
619 Be more systematic about _setjmp vs setjmp.
620 * alloc.c (test_setjmp, mark_stack):
621 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
622 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
623 (png_load, my_error_exit, jpeg_load):
624 * process.c (send_process_trap, send_process):
625 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
626 The underscored versions are up to 30x faster on some hosts.
627 Formerly, the code used setjmp+longjmp sometimes and
628 _setjmp+_longjmp at other times, with no particular reason to
629 prefer setjmp+longjmp.
630
26d4541d
PE
6312012-09-03 Paul Eggert <eggert@cs.ucla.edu>
632
d42f4f0f 633 Fix minor problem found by static checking.
26d4541d 634 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 635
c5e28e39
MR
6362012-09-03 Martin Rudalics <rudalics@gmx.at>
637
638 * buffer.c (Fdelete_all_overlays): New function.
639
3eab3ca9
CY
6402012-09-03 Chong Yidong <cyd@gnu.org>
641
642 * gtkutil.c: Add extern decl for Qxft.
643
c04889f8
PE
6442012-09-02 Paul Eggert <eggert@cs.ucla.edu>
645
1882aa38
PE
646 * emacs.c, eval.c: Use bool for boolean.
647 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
648 (malloc_using_checking) [DOUG_LEA_MALLOC]:
649 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
650 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
651 (main, decode_env_path, Fdaemon_initialized):
652 * eval.c (call_debugger, Finteractive_p, interactive_p):
653 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
654 (maybe_call_debugger, Fbacktrace):
655 * process.c (read_process_output, exec_sentinel):
656 Use bool for booleans.
657 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
658 All callers changed.
659 * eval.c (interactive_p): Omit always-true boolean argument
660 EXCLUDE_SUBRS_P. All callers changed.
661 * dispextern.h, lisp.h: Reflect above API changes.
662 * firstfile.c (dummy): Use the address of 'main', whose signature
663 won't change, instead of the address of 'initialize', whose
664 signature just changed from int to bool.
665 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
666 * msdos.c (fatal_error_in_progress): ... from here.
667 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
668 of incrementing it.
669 (redisplay_internal, unwind_redisplay): Simply clear
670 REDISPLAYING_P when unwinding, instead of saving its previous,
671 always-false value and then restoring it.
672
a411ac43
PE
673 Clean up some extern decls.
674 Mostly, this hoists extern decls out of .c files and into .h files.
675 That way, we're more likely to catch errors if the interfaces change.
676 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
677 declare xg_mark_data.
678 * dispextern.h (x_frame_parm_handlers):
679 * font.h (Qxft):
680 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
681 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
682 (Qultra_bold, Qoblique, Qitalic):
683 Move extern decl here from .c file.
684 * alloc.c (xg_mark_data) [USE_GTK]:
685 * doc.c (Qclosure):
686 * eval.c (Qlexical_binding):
687 * fns.c (time) [!HAVE_UNISTD_H]:
688 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
689 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
690 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
691 * lread.c (Qinternal_interpreter_environment):
692 * minibuf.c (Qbuffer):
693 * process.c (QCfamily, QCfilter):
694 * widget.c (free_frame_faces):
695 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
696 * xfont.c (x_clear_errors):
697 * xterm.c (x_frame_parm_handlers):
698 Remove now-redundant extern decls.
699 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
700 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
701 Now static.
702 * xfaces.c: Remove unnecessary static decls.
703 * xterm.c (updating_frame): Remove decl of nonexistent object.
704
c04889f8
PE
705 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
706 when building globals.h, as the objects that are not built on
707 this host are not needed to compile C files on this host.
708
8b339673
JD
7092012-09-02 Jan Djärv <jan.h.d@swipnet.se>
710
711 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
712
713 * frame.h: Add missing prototype for x_wm_set_size_hint.
714
a08d4ba7
PE
7152012-09-02 Paul Eggert <eggert@cs.ucla.edu>
716
717 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
718 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
719 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
720 (Fsubstitute_command_keys):
721 * editfns.c (region_limit, find_field, Fconstrain_to_field)
722 (save_excursion_save, save_excursion_restore)
723 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
724 (format_time_string, general_insert_function)
725 (make_buffer_string, make_buffer_string_both)
726 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
727 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
728 (copy_text, insert_1, insert_1_both, insert_from_string)
729 (insert_from_string_before_markers, insert_from_string_1)
730 (insert_from_buffer, insert_from_buffer_1, replace_range)
731 (replace_range_2, del_range_1, del_range_byte, del_range_both)
732 (del_range_2, modify_region):
733 * intervals.c (intervals_equal, balance_possible_root_interval)
734 (adjust_intervals_for_insertion, merge_properties_sticky)
735 (graft_intervals_into_buffer, lookup_char_property)
736 (adjust_for_invis_intang, set_point_both)
737 (get_property_and_range, compare_string_intervals)
738 (set_intervals_multibyte_1, set_intervals_multibyte):
739 * keyboard.c (decode_timer):
740 Use bool for boolean.
741 * intervals.h, lisp.h, systime.h: Reflect above API changes.
742 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
743
48c948de
CY
7442012-09-02 Chong Yidong <cyd@gnu.org>
745
746 * keymap.c (push_key_description): Print M-TAB as C-M-i
747 (Bug#11758).
748
6c49a40b
JB
7492012-09-02 Juanma Barranquero <lekktu@gmail.com>
750
751 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
752 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
753 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
754 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
755 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
756 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
757 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
758
4dfbd238
EZ
7592012-09-01 Eli Zaretskii <eliz@gnu.org>
760
7e510e28
EZ
761 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
762 more than one grapheme cluster passed to the shaper: compute the
763 offset adjustment values separately for each cluster. (Bug#11860)
764
4dfbd238
EZ
765 * image.c: Restore mistakenly removed inclusion of w32.h. Without
766 it, GCC doesn't see prototypes of w32_delayed_load, and complains
767 about implicit conversions from integer to pointer.
768
86571ae0
DC
7692012-09-01 Daniel Colascione <dancol@dancol.org>
770
771 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
772 system used too early.
773
0e23ef9d
PE
7742012-09-01 Paul Eggert <eggert@cs.ucla.edu>
775
776 Better seed support for (random).
777 * emacs.c (main): Call init_random.
778 * fns.c (Frandom): Set the seed from a string argument, if given.
779 Remove long-obsolete Gentzel cruft.
780 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
781 (init_random): New function.
782
17a2cbbd
DC
7832012-09-01 Daniel Colascione <dancol@dancol.org>
784
785 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
786 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
787 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
788 x_wm_set_size_hint, x_query_colors, x_real_positions,
789 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
790 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
791 all of which have been moved to common code.
792
793 * xfaces.c: Include TERM_HEADER instead of listing all possible
794 window-system headers.
795
796 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
797 to match header.
798
799 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
800 directly accessing frame internals.
801
f18cbb28 802 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
803 globals_of_w32font.
804
805 * process.c: Include TERM_HEADER instead of listing all possible
806 window-system headers.
807
808 * nsterm.h: Remove declarations now in frame.h. Define
809 FRAME_X_SCREEN, FRAME_X_VISUAL.
810
811 * menu.c: Include TERM_HEADER instead of listing all possible
812 window-system headers.
813
814 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
815 window system.
816
817 * keyboard.c: Include TERM_HEADER instead of listing all possible
818 window-system headers.
819
820 * image.c: Include TERM_HEADER instead of listing all possible
821 window-system headers. Declare Vlibrary_cache when compiling for
822 Windows.
823
824 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
825 window system declarations.
826
827 * frame.h: Move common functions here: set_frame_menubar,
828 x_set_window_size, x_sync, x_get_focus_frame,
829 x_set_mouse_position, x_set_mouse_pixel_position,
830 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
831 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
832 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
833 x_activate_menubar, x_real_positions, x_bitmap_icon,
834 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
835 and x_query_colors.
836
837 * frame.c: Include TERM_HEADER instead of listing all possible
838 window-system headers.
839
840 * font.c: Include TERM_HEADER instead of listing all possible
841 window-system headers.
842
843 * emacs.c: Include TERM_HEADER.
844
f18cbb28
EZ
845 * dispnew.c: Include TERM_HEADER instead of listing all possible
846 window-system headers.
17a2cbbd 847
f18cbb28 848 * ccl.h: Include character.h.
17a2cbbd
DC
849
850 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
851 the current window system; include in list of objects to link into
852 Emacs.
853
c650a5de
DA
8542012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
855
856 Remove mark_ttys function and fix tty_display_info initialization.
857 * lisp.h (mark_ttys): Remove prototype.
858 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
859 to mark_ttys because all possible values of 'top_frame' slot are
860 the frames which are reachable from Vframe_list.
861 * term.c (mark_ttys): Remove.
862 (init_tty): Safely initialize 'top_frame' slot with Qnil.
863
4e0f6479
DA
8642012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
865
866 Change struct frame bitfields from unsigned char to unsigned.
867 * frame.h (struct frame): Change type of 'display_preempted',
868 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
869 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
870 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
871 bitfields from unsigned char to unsigned.
872
8b96a52c
DA
8732012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
874
875 Remove unused member of struct x_output and struct w32_output.
876 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
877 * w32term.h (struct w32_output): Likewise.
878
b4444c8a
JD
8792012-08-30 Jan Djärv <jan.h.d@swipnet.se>
880
881 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
882 does not become zero (Bug#12234).
883
b98521db
PE
8842012-08-30 Paul Eggert <eggert@cs.ucla.edu>
885
886 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
887 for GCC 4.7.1 x86-64.
888
31d02438
GM
8892012-08-30 Glenn Morris <rgm@gnu.org>
890
891 * lread.c (init_lread): For out-of-tree builds, only add the
892 source directory's site-lisp dir to the load-path if it exists,
893 consistent with in-tree builds. (Bug#12302)
894
7f8941d8
JD
8952012-08-28 Jan Djärv <jan.h.d@swipnet.se>
896
897 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
898 button_values to NULL. Call setStykeMask so dialogs get a close button.
899 (windowShouldClose:): Set window_closed.
900 (dealloc): New member, free button_values.
901 (process_dialog:): Make member function. Remove window argument,
902 replace window with self. Count buttons and allocate and store values
903 in button_values.
904 (addButton:value:row:): value is int with the name tag. Call setTag
905 with tag. Remove return self, declare return value as void.
906 (addString:row:): Remove return self, declare return value as void.
907 (addSplit): Remove return self, declare return value as void.
908 (clicked:): Remove return self, declare return value as void.
909 Set dialog_return to button_values[seltag]. Code formatting change.
910 (initFromContents:isQuestion:): Adjust call to process_dialog.
911 Code formatting change.
912 (timeout_handler:): Set timer_fired to YES.
913 (runDialogAt:): Set timer_fired to NO.
914 Handle click on close button as quit.
915
916 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
917 Add window_closed and button_values. Add void as return value for
918 add(Button|String|Split). addButton takes int instead of Lisp_Object.
919 Add process_dialog as new member.
920
eada0861 9212012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 922
eada0861
GM
923 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
924 is not one of the heaps we manage. (Bug#12242)
925
9262012-08-28 Glenn Morris <rgm@gnu.org>
927
928 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
929
457294dd
MR
9302012-08-28 Martin Rudalics <rudalics@gmx.at>
931
932 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
933 auto-buffer-name window parameter. Install revision of reverted
934 fix.
457294dd 935
4f2daf31
DA
9362012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
937
938 Do not allow to set major mode for a dead buffer.
939 * buffer.c (Fset_buffer_major_mode): Signal an error
940 if the buffer is dead.
941 (Fother_buffer, other_buffer_safely): Remove redundant
942 nested declaration.
943
66322887
DA
9442012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
945
946 Always use set_buffer_if_live to restore original buffer at unwind.
947 * buffer.h (record_unwind_current_buffer): New function.
948 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
949 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
950 * undo.c, window.c: Adjust users.
951 * buffer.c (set_buffer_if_live): Fix comment.
952
a3d794a1
DA
9532012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
954
955 Fix usage of set_buffer_internal.
956 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
957 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
958 * coding.c (decode_coding): Omit redundant test.
959 * fileio.c (decide_coding_unwind): Likewise.
960 * fns.c (secure_hash): Likewise.
961 * insdel.c (modify_region): Likewise.
962 * keyboard.c (command_loop_1): Likewise.
963 * print.c (PRINTFINISH): Likewise.
964 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
965
59ea14cd
PE
9662012-08-27 Paul Eggert <eggert@cs.ucla.edu>
967
968 * dispnew.c: Use bool for boolean.
969 (frame_garbaged, display_completed, delayed_size_change)
970 (fonts_changed_p, add_window_display_history)
971 (add_frame_display_history, verify_row_hash)
972 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
973 (row_equal_p, realloc_glyph_pool)
974 (allocate_matrices_for_frame_redisplay)
975 (showing_window_margins_p)
976 (adjust_frame_glyphs_for_frame_redisplay)
977 (build_frame_matrix_from_leaf_window, make_current)
978 (mirrored_line_dance, mirror_line_dance, update_frame)
979 (update_window_tree, update_single_window)
980 (check_current_matrix_flags, update_window, update_text_area)
981 (update_window_line, set_window_update_flags, scrolling_window)
982 (update_frame_1, scrolling, buffer_posn_from_coords)
983 (do_pending_window_change, change_frame_size)
984 (change_frame_size_1, sit_for):
985 Use bool for boolean.
986 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
987 and remove last int (actually boolean) argument, which was always 0.
988 All callers changed.
989 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
990 * dispextern.h (struct composition_it): Use bool for boolean.
991 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
992 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
993 * dired.c (file_name_completion):
994 Use bool for boolean. (This was missed in an earlier change.)
995
95072a94
MR
9962012-08-27 Martin Rudalics <rudalics@gmx.at>
997
998 * window.c (Fset_window_configuration): Revert first part of
999 last change.
1000
0f19feff
JD
10012012-08-27 Jan Djärv <jan.h.d@swipnet.se>
1002
1003 * nsterm.h (NSPanel): New class variable dialog_return.
1004
1005 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
1006 dialog_return.
1007 (windowShouldClose:): Use stop instead of stopModalWithCode.
1008 (clicked:): Ditto, and also set dialog_return (Bug#12258).
1009 (timeout_handler:): Use stop instead of abortModal. Send a dummy
1010 event.
1011 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
1012 modal loop returns.
1013
f10fe38f
PE
10142012-08-27 Paul Eggert <eggert@cs.ucla.edu>
1015
de1339b0
PE
1016 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
1017 * composite.c (find_composition, composition_gstring_p)
1018 (composition_reseat_it, find_automatic_composition):
1019 * data.c (let_shadows_buffer_binding_p)
1020 (let_shadows_global_binding_p, set_internal, make_blv)
1021 (Fmake_variable_buffer_local, Fmake_local_variable)
1022 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
1023 (cons_to_signed, arith_driver):
1024 * dbusbind.c (xd_in_read_queued_messages):
1025 * dired.c (directory_files_internal, file_name_completion):
1026 Use bool for booleans.
1027 * dired.c (file_name_completion):
1028 * process.h (fd_callback):
1029 Omit int (actually boolean) argument. It wasn't being used.
1030 All uses changed.
1031 * composite.h, lisp.h: Reflect above API changes.
1032
f10fe38f
PE
1033 * cmds.c, coding.c: Use bool for booleans.
1034 * cmds.c (move_point, Fself_insert_command):
1035 * coding.h (struct composition status, struct coding_system):
1036 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
1037 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
1038 (emacs_mule_char, decode_coding_emacs_mule)
1039 (encode_coding_emacs_mule, detect_coding_iso_2022)
1040 (decode_coding_iso_2022, encode_invocation_designation)
1041 (encode_designation_at_bol, encode_coding_iso_2022)
1042 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
1043 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
1044 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
1045 (encode_coding_raw_text, detect_coding_charset)
1046 (decode_coding_charset, encode_coding_charset, detect_eol)
1047 (detect_coding, get_translation_table, produce_chars)
1048 (consume_chars, reused_workbuf_in_use)
1049 (make_conversion_work_buffer, code_conversion_save)
1050 (decode_coding_object, encode_coding_object)
1051 (detect_coding_system, char_encodable_p)
1052 (Funencodable_char_position, code_convert_region)
1053 (code_convert_string, code_convert_string_norecord)
1054 (Fset_coding_system_priority):
1055 * fileio.c (Finsert_file_contents):
1056 Use bool for booleans.
1057 * coding.h, lisp.h: Reflect above API changes.
1058 * coding.c: Remove unnecessary static function decls.
1059 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
1060 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
1061 not a boolean 'int', since callers never look at the return value.
1062 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
1063 * coding.h (decoding_buffer_size, encoding_buffer_size)
1064 (emacs_mule_string_char): Remove unused extern decls.
1065 (struct iso_2022_spec, struct coding_system):
1066 Use 'unsigned int : 1' for boolean fields, since there's more than one.
1067 (struct emacs_mule_spec): Remove unused field 'full_support'.
1068 All initializations removed.
1069 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
1070
5474c384
DA
10712012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1072
f10fe38f 1073 Fix spare memory change (Bug#12286).
5474c384
DA
1074 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
1075 (valid_lisp_object_p): Likewise.
1076
c4b6914d
MR
10772012-08-27 Martin Rudalics <rudalics@gmx.at>
1078
1079 * window.c (Fset_window_configuration): Record any window's old
1080 buffer if it's replaced (see Bug#8789). If the new current
1081 buffer doesn't appear in the selected window, go to its old
1082 point (Bug#12208).
1083
35aaa1ea
DA
10842012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1085
1086 Special MEM_TYPE_SPARE to denote reserved memory.
1087 * alloc.c (enum mem_type): New memory type.
1088 (refill_memory_reserve): Use new type for spare memory.
1089 This prevents live_cons_p and live_string_p from incorrect
1090 detection of uninitialized objects from spare memory as live.
1091
6af64513
PE
10922012-08-26 Paul Eggert <eggert@cs.ucla.edu>
1093
8b2e00a3
PE
1094 Spelling fixes.
1095 * Makefile.in (.PHONY): versioclean -> versionclean.
1096
b52d6985
PE
1097 Remove unused external symbols.
1098 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
1099 * window.c (Qwindow_valid_p, decode_valid_window):
1100 Now static, not extern.
1101 * data.c (Qinterval): Remove; unused.
1102 (syms_of_data): Do not define 'interval'.
1103 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
1104 * window.h (decode_valid_window):
1105 Remove decls.
1106
d5172d4f
PE
1107 * character.c, charset.c, chartab.c: Use bool for booleans.
1108 * character.c (lisp_string_width, string_count_byte8)
1109 (string_escape_byte8):
1110 * charset.c (charset_map_loaded, load_charset_map, read_hex):
1111 (load_charset_map_from_file, map_charset_chars)
1112 (Fdefine_charset_internal, define_charset_internal)
1113 (Fdeclare_equiv_charset, find_charsets_in_text)
1114 (Ffind_charset_region, char_charset, Fiso_charset):
1115 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
1116 (sub_char_table_set, sub_char_table_set_range)
1117 (char_table_set_range, optimize_sub_char_table)
1118 (map_sub_char_table):
1119 Use bool for boolean.
1120 * character.c (str_to_unibyte): Omit last boolean argument; it was
1121 always 0. All callers changed.
1122 * character.h, charset.h: Adjust to match previous changes.
1123 * character.h (char_printable_p): Remove decl of nonexistent function.
1124 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
1125 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
1126 are all boolean, so make them single-bit bitfields.
1127
6af64513
PE
1128 * lisp.h (ASET): Remove attempt to detect side effects.
1129 It was meant to be temporary and it often doesn't work,
1130 because when IDX has side effects the behavior of IDX==IDX
1131 is undefined. See Stefan Monnier in
1132 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
1133
e1f29348
BR
11342012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1135
1136 * lisp.h (functionp): New function (extracted from Ffunctionp).
1137 (FUNCTIONP): Use it.
1138 * eval.c (Ffunctionp): Use it.
1139
17c05d74
PE
11402012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1141
0f46bc75
PE
1142 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
1143 as that's faster and simpler than static storage. Don't bother
1144 with the g_main_context_query overhead if g_main_context_pending
1145 says no events are pending.
1146 (gfds, gfds_size): Remove these static vars.
1147 (xgselect_initialize): Remove; no longer needed.
1148 All uses and decls removed.
1149
ee4c0f69
PE
1150 * emacs.c (fatal_error_signal_hook): Remove.
1151 All uses removed. This leftover from old code was always 0.
1152
17c05d74
PE
1153 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
1154 * casefiddle.c (casify_object, casify_region):
1155 * casetab.c (set_case_table):
1156 * category.c, category.h (word_boundary_p):
1157 * category.h (CHAR_HAS_CATEGORY):
1158 Use bool for booleans, instead of int.
1159
391ceac5
EZ
11602012-08-25 Eli Zaretskii <eliz@gnu.org>
1161
1162 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
1163
2f221583
PE
11642012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1165
f4a681b0
PE
1166 On assertion failure, print backtrace if available.
1167 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
1168 (die) [ENABLE_CHECKING]: Print a backtrace if available.
1169 * Makefile.in (LIB_EXECINFO): New macro.
1170 (LIBES): Use it.
1171
2f221583
PE
1172 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
1173 * bytecode.c (exec_byte_code):
1174 * callint.c (check_mark, Fcall_interactively):
1175 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
1176 (getenv_internal, sync_process_alive, call_process_exited):
1177 * lisp.h (USE_SAFE_ALLOCA):
1178 Use bool for booleans, instead of int.
1179 * lisp.h, process.h: Adjust prototypes to match above changes.
1180 * callint.c (Fcall_interactively): Don't assume the mark's
1181 offset fits in 'int'.
1182
37ef52bb
PE
11832012-08-24 Paul Eggert <eggert@cs.ucla.edu>
1184
1185 * buffer.c, buffer.h: Use bool for boolean.
1186 * buffer.c (reset_buffer_local_variables)
1187 (buffer_lisp_local_variables, Fset_buffer_modified_p)
1188 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
1189 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
1190 (overlay_touches_p, overlay_strings, Foverlay_put)
1191 (report_overlay_modification, call_overlay_mod_hooks):
1192 (mmap_enlarge, mmap_set_vars):
1193 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
1194 Use bool for booleans, instead of int.
1195 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
1196 since the 1-or-0 return value is always ignored anyway.
1197 (mmap_initialized_p):
1198 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
1199 * buffer.h, lisp.h: Adjust prototypes to match above changes.
1200
2cc21167
PE
12012012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1202
1203 * bidi.c: Use bool for boolean.
1204 This is a bit more readable, and makes the text segment of bidi.o
1205 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
1206 Presumably it's faster too.
1207 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
1208 Now bool.
1209 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1210 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
1211 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
1212 (bidi_explicit_dir_char, bidi_level_of_next_char)
1213 (bidi_find_other_level_edge, bidi_move_to_visually_next):
1214 Use bool for booleans, instead of int.
1215 * dispextern.h (bidi_init_it, bidi_paragraph_init)
1216 (bidi_unshelve_cache): Adjust decls to match code.
1217
7db4ddf4
MR
12182012-08-23 Martin Rudalics <rudalics@gmx.at>
1219
1220 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
1221 argument.
1222
b1bb8011
PE
12232012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1224
1225 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
1226 * atimer.h: Include <stdbool.h>.
1227
ff687885
DN
12282012-08-22 Dan Nicolaescu <dann@gnu.org>
1229
1230 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
1231 compile time tests instead of run time tests on systems that do
1232 not use them.
1233 (FRAME_MAC_P): Remove leftover from deleted code.
1234 * frame.c (syms_of_frame): Remove leftover from deleted code.
1235
4ce7a138
JD
12362012-08-22 Jan Djärv <jan.h.d@swipnet.se>
1237
1238 * nsterm.m (insertText:): Don't clear modifiers if code is space.
1239
d733ec6d
PE
12402012-08-22 Paul Eggert <eggert@cs.ucla.edu>
1241
1242 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
1243 Otherwise, the compiler complains about (A?B:C) where B is void
1244 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
1245 (fontset_add): Return void, for FONTSET_ADD.
1246
d0d2d26f
PE
12472012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1248
fce31d69
PE
1249 * alloc.c: Use bool for booleans.
1250 (gc_in_progress, abort_on_gc)
1251 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
1252 (dont_register_blocks) [GC_MALLOC_CHECK]:
1253 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
1254 (check_string_bytes, make_specified_string, memory_full)
1255 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
1256 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
1257 (mark_stack, valid_pointer_p, make_pure_string)
1258 (Fgarbage_collect, survives_gc_p, gc_sweep):
1259 Use bool for booleans, instead of int.
1260 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
1261 Remove unused local.
1262 * alloc.c (PURE_POINTER_P):
1263 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
1264 * editfns.c (Fformat):
1265 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
1266 (Fdo_auto_save):
1267 * fns.c (sweep_weak_table):
1268 * lisp.h (suppress_checking, push_message, survives_gc_p)
1269 (make_pure_string, gc_in_progress, abort_on_gc):
1270 * lread.c (readchar, read1):
1271 * print.c (Fprin1_to_string):
1272 * xdisp.c (push_message):
1273 Use bool for booleans affected directly or indirectly by
1274 alloc.c's changes.
1275
d0d2d26f
PE
1276 Make recently-introduced setters macros.
1277 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
1278 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
1279 (set_fontset_default, set_fontset_fallback): Rename from their
1280 upper-case counterparts, and make them functions rather than macros.
1281 This is more consistent with the other recently-introduced setters.
1282 These don't need to be inline, since they're local.
1283
d18e2bb6
JD
12842012-08-21 Jan Djärv <jan.h.d@swipnet.se>
1285
1286 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
1287 the loop (Bug#12247).
1288
1b9d9d16
PE
12892012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1290
1291 * lisp.h (vcopy): Use memcpy rather than our own loop.
1292 This fixes a performance regression introduced by the recent
1293 addition of vcopy. This means 'vcopy' will need to be modified
1294 for a copying collector, but that's OK. Also, tighten the
1295 checking in the assertion.
1296
b2f09701
EZ
12972012-08-21 Eli Zaretskii <eliz@gnu.org>
1298
1299 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
1300 components for RTL text (Bug#11860). Adjust X-OFFSET of each
1301 non-base glyph for the width of the base character, according to
e1f29348
BR
1302 what x_draw_composite_glyph_string_foreground expects.
1303 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
1304 expectations, to produce correct width of the composed character.
1305 Reverse the sign of the DU offset produced by ScriptPlace.
1306
9b994fed
PE
13072012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1308
1309 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
1310
086ca913
DA
13112012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1312
1313 Avoid direct writes to contents member of struct Lisp_Vector.
1314 * lisp.h (vcopy): New function to copy data into vector.
1315 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
1316 * fns.c (Ffillarray): Use ASET.
1317 * keyboard.c (timer_check_2): Use AREF and ASET.
1318 (append_tool_bar_item, Frecent_keys): Use vcopy.
1319 * lread.c (read_vector): Use ASET.
1320 * msdos.c (Frecent_doskeys): Use vcopy.
1321 * xface.c (Finternal_copy_lisp_face): Use vcopy.
1322 (Finternal_merge_in_global_face): Use ASET and vcopy.
1323 * xfont.c (xfont_list_pattern): Likewise.
1324
5481664a
MR
13252012-08-21 Martin Rudalics <rudalics@gmx.at>
1326
1327 * window.c (Fwindow_point): For the selected window always return
1328 the position of its buffer's point.
1329 (Fset_window_point): For the selected window always go in its
1330 buffer to the specified position.
1331
6d470bdd
DA
13322012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
1333
1334 Setter macros for fontsets.
1335 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
1336 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
1337 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
1338 Adjust users.
1339
24564fe1
GM
13402012-08-20 Glenn Morris <rgm@gnu.org>
1341
1342 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1343 Don't assume that `ln -f' works.
1344
0a05a035
EZ
13452012-08-20 Eli Zaretskii <eliz@gnu.org>
1346
1347 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
1348 and later about non-assignments with no effect. See discussion at
1349 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
1350 details.
1351
e46f2325
DA
13522012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1353
1354 Inline setter functions for Lisp_Objects slots of struct specbinding.
1355 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
1356 Adjust users.
1357
734fbd86
MR
13582012-08-20 Martin Rudalics <rudalics@gmx.at>
1359
1360 * window.c (select_window): Always make selected window's buffer
1361 current.
1362
f1a95992
DA
13632012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1364
1365 Use AREF and ASET for docstrings of category tables.
1366 * category.h (CATEGORY_DOCSTRING): Use AREF.
1367 (SET_CATEGORY_DOCSTRING): Use ASET.
1368 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
1369
e83064be
DA
13702012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1371
1372 Inline setter functions for hash table members.
1373 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
1374 (set_hash_hash, set_hash_index): Rename with _slot suffix.
1375 (set_hash_key_and_value, set_hash_index, set_hash_next)
1376 (set_hash_hash): New functions.
1377 * charset.c, fns.c: Adjust users.
1378
4ce60d2e
DA
13792012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
1380
1381 Inline getter and setter functions for per-buffer values.
1382 * buffer.h (per_buffer_default, set_per_buffer_default)
1383 (per_buffer_value, set_per_buffer_value): New functions.
1384 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
1385 * buffer.c, data.c: Adjust users.
1386
c06c9690
JB
13872012-08-20 Juanma Barranquero <lekktu@gmail.com>
1388
1389 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
1390
32bd4250
PE
13912012-08-19 Paul Eggert <eggert@cs.ucla.edu>
1392
bad03192 1393 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
1394 as gnulib does this if the system doesn't.
1395 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
1396 Remove declaration. MS-Windows declares it on stdlib.h which is
1397 included by conf_post.h.
b69a6d22
PE
1398 * emacs.c (environ) [DOUG_LEA_MALLOC]:
1399 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
1400 * vm-limit.c: Include <unistd.h>, for 'environ'.
1401
22d7feb2
PE
1402 * unexaix.c, unexcoff.c: Include "mem-limits.h".
1403 (start_of_data): Remove decl; mem-limits.h provides it.
1404
32bd4250
PE
1405 * xdisp.c (handle_invisible_prop): Make it a bit faster
1406 and avoid a gcc -Wmaybe-uninitialized diagnostic.
1407
450809af
CY
14082012-08-19 Chong Yidong <cyd@gnu.org>
1409
1410 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
1411 ends (Bug#3874).
1412
9e677988
AS
14132012-08-19 Andreas Schwab <schwab@linux-m68k.org>
1414
6b1319ce
AS
1415 * .gdbinit: Use call instead of set when calling a function in the
1416 inferior.
1417
9e677988
AS
1418 * data.c (set_internal): Don't use set_blv_found.
1419 (Fkill_local_variable): Likewise.
1420
d7191076
AA
14212012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
1422
1423 * nsfont.m (ns_ascii_average_width): Ensure the string
1424 ascii_printable is initialized with a null-terminated character
1425 array. Otherwise, it can contain undesired extra characters.
1426
e757f1c6
PE
14272012-08-18 Paul Eggert <eggert@cs.ucla.edu>
1428
1429 port new setting code to Sun C 5.8 2005/10/13
1430 * chartab.c, lisp.h (char_table_set, char_table_set_range):
1431 Return void, not Lisp_Object. Otherwise, the compiler
1432 complains about (A?B:C) where B is void and C is Lisp_Object
1433 when compiling CHAR_TABLE_SET, due to the recent change to
1434 the API of sub_char_table_set_contents.
1435
a999ce26
CY
14362012-08-18 Chong Yidong <cyd@gnu.org>
1437
1438 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
1439 for the string case (Bug#3874).
1440
3f22b86f
PE
14412012-08-18 Paul Eggert <eggert@cs.ucla.edu>
1442
39eb03f1
PE
1443 * buffer.h (BSET): Remove (Bug#12215).
1444 Replace all uses with calls to new setter functions.
1445 (bset_bidi_paragraph_direction, bset_case_canon_table)
1446 (bset_case_eqv_table, bset_directory, bset_display_count)
1447 (bset_display_time, bset_downcase_table)
1448 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
1449 (bset_last_selected_window, bset_local_var_alist)
1450 (bset_mark_active, bset_point_before_scroll, bset_read_only)
1451 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
1452 (bset_width_table):
1453 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
1454 (bset_auto_fill_function, bset_auto_save_file_format)
1455 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
1456 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
1457 (bset_cache_long_line_scans, bset_case_fold_search)
1458 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
1459 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
1460 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
1461 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
1462 (bset_header_line_format, bset_indicate_buffer_boundaries)
1463 (bset_indicate_empty_lines, bset_invisibility_spec)
1464 (bset_left_fringe_width, bset_major_mode, bset_mark)
1465 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
1466 (bset_name, bset_overwrite_mode, bset_pt_marker)
1467 (bset_right_fringe_width, bset_save_length)
1468 (bset_scroll_bar_width, bset_scroll_down_aggressively)
1469 (bset_scroll_up_aggressively, bset_selective_display)
1470 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
1471 (bset_word_wrap, bset_zv_marker):
1472 * category.c (bset_category_table):
1473 * syntax.c (bset_syntax_table):
1474 New setter functions.
1475
6a09a33b
PE
1476 * process.h (PSET): Remove (Bug#12215).
1477 Replace all uses with calls to new setter functions.
1478 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1479 (PROCESS_INLINE): New macro.
1480 (pset_childp): New setter function.
1481 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
1482 * process.c (PROCESS_INLINE):
1483 Define to EXTERN_INLINE, so that the corresponding functions
1484 are compiled into code.
1485 (pset_buffer, pset_command, pset_decode_coding_system)
1486 (pset_decoding_buf, pset_encode_coding_system)
1487 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
1488 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
1489 (pset_type, pset_write_queue): New setter functions.
1490
e8c17b81
PE
1491 * window.h (WSET): Remove (Bug#12215).
1492 Replace all uses with calls to new setter functions.
1493 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1494 (WINDOW_INLINE): New macro.
1495 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
1496 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
1497 (wset_total_lines, wset_vertical_scroll_bar)
1498 (wset_window_end_pos, wset_window_end_valid)
1499 (wset_window_end_vpos): New setter functions.
1500 * window.c (WINDOW_INLINE):
1501 Define to EXTERN_INLINE, so that the corresponding functions
1502 are compiled into code.
1503 (wset_combination_limit, wset_dedicated, wset_display_table)
1504 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
1505 (wset_new_normal, wset_new_total, wset_next_buffers)
1506 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
1507 (wset_prev_buffers, wset_right_fringe_width)
1508 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
1509 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
1510 (wset_window_parameters):
1511 * xdisp.c (wset_base_line_number, wset_base_line_pos)
1512 (wset_column_number_displayed, wset_region_showing):
1513 New setter functions.
1514
3f22b86f
PE
1515 * termhooks.h (TSET): Remove (Bug#12215).
1516 Replace all uses with calls to new setter functions.
1517 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1518 (TERMHOOKS_INLINE): New macro.
1519 (tset_charset_list, tset_selection_alist): New setter functions.
1520 * terminal.c (TERMHOOKS_INLINE):
1521 Define to EXTERN_INLINE, so that the corresponding functions
1522 are compiled into code.
1523 (tset_param_alist): New setter function.
1524
742af32f
PE
15252012-08-17 Paul Eggert <eggert@cs.ucla.edu>
1526
15dbb4d6
PE
1527 * keyboard.h (KSET): Remove (Bug#12215).
1528 Replace all uses with calls to new setter functions.
1529 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1530 (KEYBOARD_INLINE): New macro.
1531 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
1532 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
1533 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
1534 New setter functions.
1535 * keyboard.c (KEYBOARD_INLINE):
1536 Define to EXTERN_INLINE, so that the corresponding functions
1537 are compiled into code.
1538 (kset_echo_string, kset_kbd_queue)
1539 (kset_keyboard_translate_table, kset_last_prefix_arg)
1540 (kset_last_repeatable_command, kset_local_function_key_map)
1541 (kset_overriding_terminal_local_map, kset_real_last_command)
1542 (kset_system_key_syms): New setter functions.
1543
f00af5b1
PE
1544 * frame.h (FSET): Remove (Bug#12215).
1545 Replace all uses with calls to new setter functions.
1546 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1547 (FRAME_INLINE): New macro.
1548 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
1549 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
1550 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
1551 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
1552 (fset_param_alist, fset_root_window, fset_scroll_bars)
1553 (fset_selected_window, fset_title, fset_tool_bar_items)
1554 (fset_tool_bar_position, fset_tool_bar_window): New functions.
1555 * frame.c (FRAME_INLINE):
1556 Define to EXTERN_INLINE, so that the corresponding functions
1557 are compiled into code.
1558 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
1559
0c94c8d6
PE
1560 A few more naming-convention fixes for getters and setters.
1561 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
1562 and rename from buffer_overlays_set_before.
1563 (set_buffer_overlays_after): Move here from buffer.h, and rename
1564 from buffer_overlays_set_after.
1565 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
1566 All uses changed.
1567 (set_buffer_intervals): Rename from buffer_set_intervals.
1568 * intervals.c (set_interval_object): Move here from intervals.h,
1569 and rename from interval_set_object.
1570 (set_interval_left): Move here from intervals.h, and rename from
1571 interval_set_left.
1572 (set_interval_right): Move here from intervals.h, and rename from
1573 interval_set_right.
1574 (copy_interval_parent): Move here from intervals.h, and rename from
1575 interval_copy_parent.
1576 * intervals.h (set_interval_parent): Rename from interval_set_parent.
1577 (set_interval_plist): Rename from interval_set_plist.
1578 Return void, not Lisp_Object, since no caller uses the result.
1579 * lisp.h (string_intervals): Rename from string_get_intervals.
1580 (set_string_intervals): Rename from string_set_intervals.
1581
34dabdb7
PE
1582 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
1583 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 1584 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
1585 All uses changed. See the end of
1586 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
1587
742af32f
PE
1588 * lisp.h (CSET): Remove (Bug#12215).
1589 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
1590 (set_char_table_purpose): New functions,
1591 replacing CSET. All uses changed. For example, replace
1592 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 1593 "set_char_table_parent (char_table, parent);".
742af32f
PE
1594 The old version was confusing because it used the same name
1595 'parent' for two different things.
1596
a04e2c62
DA
15972012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
1598
1599 Functions to get and set Lisp_Object fields of buffer-local variables.
1600 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
1601 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
1602 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
1603 * data.c, eval.c, frame.c: Adjust users.
1604
383dcbf9
CY
16052012-08-17 Chong Yidong <cyd@gnu.org>
1606
1607 * xfaces.c (merge_face_vectors): If the target font specfies a
1608 font spec, make the font's attributes take precedence over
1609 directly-specified attributes.
1610 (merge_face_ref): Recognize :font.
1611
44386687
DA
16122012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
1613
1614 Do not use memcpy for copying intervals.
1615 * intervals.c (reproduce_interval): New function.
1616 (reproduce_tree, reproduce_tree_obj): Use it.
1617 (reproduce_tree_obj): Remove prototype.
1618
927c7216
PE
16192012-08-17 Paul Eggert <eggert@cs.ucla.edu>
1620
1621 * lisp.h (duration_to_sec_usec): Remove unused decl.
1622
93044f7b
AA
16232012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
1624
1625 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
1626 to an allocated instance of NSString, not to the class itself.
1627
9851e4a5
JB
16282012-08-17 Juanma Barranquero <lekktu@gmail.com>
1629
1630 * makefile.w32-in (C_CTYPE_H): New macro.
1631 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
1632 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
1633 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
1634
620f13b0
PE
16352012-08-16 Paul Eggert <eggert@cs.ucla.edu>
1636
1637 Use ASCII tests for character types.
1638 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
1639 * xfns.c, xterm.c:
1640 Don't include <ctype.h>; was not needed.
1641 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
1642 * sysdep.c, xfaces.c:
1643 Include <c-ctype.h> instead of <ctype.h>.
1644 * nsterm.m: Include <c-ctype.h>.
1645 * charset.c (read_hex):
1646 * doc.c (Fsnarf_documentation):
1647 * fileio.c (IS_DRIVE) [WINDOWSNT]:
1648 (DRIVE_LETTER) [DOS_NT]:
1649 (Ffile_name_directory, Fexpand_file_name)
1650 (Fsubstitute_in_file_name):
1651 * font.c (font_parse_xlfd, font_parse_fcname):
1652 * frame.c (x_set_font_backend):
1653 * gtkutil.c (xg_get_font):
1654 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
1655 * nsimage.m (hexchar):
1656 * nsterm.m (ns_xlfd_to_fontname):
1657 * sysdep.c (system_process_attributes):
1658 * xfaces.c (hash_string_case_insensitive):
1659 Use C-locale tests instead of locale-specific tests for character
1660 types, since we want the ASCII interpretation here, not the
1661 interpretation suitable for whatever happens to be the current locale.
1662
52162052
MR
16632012-08-16 Martin Rudalics <rudalics@gmx.at>
1664
1665 Consistently check windows for validity/liveness
1666 (Bug#11984, Bug#12025, Bug#12026).
1667 * lisp.h (CHECK_VALID_WINDOW): New macro.
1668 * window.c (decode_window): Rename to decode_live_window.
1669 (decode_valid_window, Fwindow_valid_p): New functions.
1670 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
1671 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
1672 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
1673 (Fwindow_prev_sibling, Fwindow_combination_limit)
1674 (Fset_window_combination_limit, Fwindow_use_time)
1675 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
1676 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
1677 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
1678 (Fwindow_hscroll, Fset_window_hscroll)
1679 (Fwindow_redisplay_end_trigger)
1680 (Fset_window_redisplay_end_trigger, Fwindow_edges)
1681 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
1682 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1683 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
1684 (Fwindow_end, Fset_window_point, Fset_window_start)
1685 (Fpos_visible_in_window_p, Fwindow_line_height)
1686 (Fwindow_dedicated_p, Fset_window_dedicated_p)
1687 (Fwindow_prev_buffers, Fset_window_prev_buffers)
1688 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
1689 (Fset_window_parameter, Fwindow_display_table)
1690 (Fset_window_display_table, Fdelete_other_windows_internal)
1691 (Fset_window_buffer, Fset_window_new_total)
1692 (Fset_window_new_normal, Fdelete_window_internal)
1693 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
1694 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
1695 (Fwindow_scroll_bars): Check whether argument window is a valid or
1696 live window. Update doc-strings.
1697 (syms_of_window): New symbol Qwindow_valid_p.
1698 * keyboard.c (Fposn_at_x_y): Check whether argument
1699 frame_or_window denotes a valid window.
1700
2751c80f
DA
17012012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
1702
1703 Fix previous char table change.
1704 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
1705 * chartab.c (optimize_sub_char_table): Likewise.
1706
032a42c8
CY
17072012-08-16 Chong Yidong <cyd@gnu.org>
1708
a2d19368
CY
1709 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
1710
032a42c8
CY
1711 * xfont.c (xfont_open):
1712 * xftfont.c (xftfont_open): Set the font's max_width field.
1713
1714 * nsfont.m (nsfont_open): Similar to the Xft backend, set
1715 min_width to space_width and average_width to the average over
1716 printable ASCII characters.
1717 (ns_char_width): Code cleanup.
1718 (ns_ascii_average_width): New utility function.
1719
1720 * font.h (struct font): Update comments.
1721
a098c930
DA
17222012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
1723
032a42c8 1724 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
1725 * lisp.h (CSET): New macro.
1726 (char_table_set_extras, char_table_set_contents)
1727 (sub_char_table_set_contents): New function.
1728 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
1729 * syntax.c: Adjust users.
1730
8be3a09c
SM
17312012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
1732
1733 * eval.c (eval_sub): Bind lexical-binding.
1734 * lread.c (Qlexical_binding): Make non-static.
1735
ac4845a6
JD
17362012-08-15 Jan Djärv <jan.h.d@swipnet.se>
1737
ddee6515
JD
1738 * nsmenu.m (popupSession): Remove.
1739 (pop_down_menu): Remove endModalSession.
1740 (timeout_handler:): New method.
1741 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
1742 Call runModalForWindow. Check timer_fired when it returns.
1743 If not set, cancel timer and break out of loop.
1744 Otherwise loop again, with a new timeout.
1745
1746 * nsterm.m: Include fcntl.h if present.
1747 (fd_entry, t_readfds, inNsSelect): Remove.
1748 (select_writefds, select_valid, select_timeout, selfds)
1749 (select_mutex, apploopnr): Add.
1750 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
1751 Otherwise call kbd_buffer_store_event.
1752 (ns_send_appdefined): Remove release of fd_entry.
1753 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
1754 Increment and decrement apploopnr.
1755 (ns_select): If no file descriptors, just do a NSTimer.
1756 Otherwise copy read/write masks and start select thread (fd_handler).
1757 Start main loop and wait for application defined event.
1758 Inform select thread to stop selecting after main loop is exited.
1759 (ns_term_init): Create selfds pipe and set non-blocking.
1760 Initialize select_mutex. Start the select thread (fd_handler).
1761 (fd_handler:): Loop forever, wait for info from the main thread
1762 to either start or stop selecting. When select returns, send
1763 and appdefined event.
1764 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
1765 If not call kbd_buffer_store_event.
1766
1767 * nsterm.h (EmacsApp): fd_handler takes id argument.
1768 (EmacsDialogPanel): Add timer_fired and timeout_handler.
1769
ac4845a6
JD
1770 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
1771
eb424fe3
EZ
17722012-08-15 Eli Zaretskii <eliz@gnu.org>
1773
1774 * region-cache.c (move_cache_gap): Update gap_len using the actual
1775 growth of the boundaries array. Do not change cache_len.
1776 (Bug#12196)
1777
4e6a86c6
DA
17782012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1779
1780 Generalize and cleanup font subsystem checks.
1781 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
1782 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
1783 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 1784
5bf192ca
DA
17852012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
1786
1787 * gtkutil.c (xg_get_font): Use pango_units_to_double.
1788
f2045622
CY
17892012-08-15 Chong Yidong <cyd@gnu.org>
1790
8be3a09c
SM
1791 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
1792 When using the new font chooser, use gtk_font_chooser_get_font_desc to
1793 extract the font descriptor instead of just the font name.
1794 In that case, return a font spec instead of a string.
f2045622
CY
1795 (x_last_font_name): Move to this file from xfns.c.
1796
1797 * xfns.c (Fx_select_font): The return value can also be a font
1798 spec. Move x_last_font_name management to gtkutil.c.
1799
1800 * xfaces.c: Make font weight and style symbols non-static.
1801
7f6feb56
SM
18022012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
1803
1804 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
1805 (bug#12117).
1806
fecbd8ff
SM
18072012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
1808
1809 * alloc.c (Fgarbage_collect): Use plural form consistently.
1810
9b8d5165
EZ
18112012-08-14 Eli Zaretskii <eliz@gnu.org>
1812
1813 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
1814 iteration through the command loop. Fixes a problem whereby mouse
1815 movements are ignored until the first mouse click.
1816
f5d9e83a
PE
18172012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1818
1819 Use bool, not int, for Lisp booleans.
1820 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
1821 makes Emacs a bit smaller and presumably a bit faster.
1822 * lisp.h: Include <stdbool.h>.
1823 (struct Lisp_Boolfwd, defvar_bool):
1824 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
1825 * regex.c [!emacs]: Include <stdbool.h>.
1826 (false, true): Remove; <stdbool.h> does this for us now.
1827
55802e4a
CY
18282012-08-14 Chong Yidong <cyd@gnu.org>
1829
4abcdac8
CY
1830 * character.c (Fcharacterp): Doc fix (Bug#12076).
1831
1832 * data.c (Findirect_variable): Doc fix (Bug#11040).
1833
55802e4a
CY
1834 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
1835
1836 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 1837 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 1838
8e99d072
BR
18392012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1840
1841 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
1842 (bug#12022).
1843
08908aca
MR
18442012-08-14 Martin Rudalics <rudalics@gmx.at>
1845
1846 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
1847 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
1848 * minibuf.c (choose_minibuf_frame, read_minibuf):
1849 * w32fns.c (x_create_tip_frame):
1850 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
1851 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
1852
56120d6f
PE
18532012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1854
1855 * intervals.c (offset_intervals): Remove obsolete comment.
1856
67b77c0b
AS
18572012-08-14 Andreas Schwab <schwab@linux-m68k.org>
1858
1859 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
1860
f48b82fd
GR
18612012-08-14 Gergely Risko <gergely@risko.hu>
1862
1863 * coding.c (decode_coding): Record buffer modification before
1864 disabling undo_list (Bug#11773).
1865
fd318b54
DA
18662012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1867
1868 Revert and cleanup some recent overlay changes.
1869 * buffer.h (enum overlay_type): Remove.
1870 (buffer_get_overlays, buffer_set_overlays): Likewise.
1871 (buffer_set_overlays_before, buffer_set_overlays_after):
1872 New function. Adjust users.
1873 (unchain_both): Add eassert.
1874
41a62dd9
DA
18752012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1876
1877 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
1878
5884c324
PE
18792012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1880
1881 * gtkutil.c (xg_mark_data): Don't assume C99.
1882
ca06f160
JD
18832012-08-13 Jan Djärv <jan.h.d@swipnet.se>
1884
1885 * gtkutil.c (xg_frame_tb_info): New struct.
1886 (TB_INFO_KEY): New define.
1887 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
1888 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
1889 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
1890 if not present.
1891 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
1892 is up to date. Otherwise store new data.
1893 (free_frame_tool_bar): Free xg_frame_tb_info if present.
1894
7864a3f7
DA
18952012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1896
1897 Use KSET for write access to Lisp_Object members of struct kboard.
1898 * keyboard.h (KSET): New macro.
1899 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
1900 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
1901 * xterm.c: Adjust users.
1902
4c31be61
DA
19032012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1904
1905 Use BSET for write access to Lisp_Object members of struct buffer.
1906 * buffer.h (BSET): New macro.
1907 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
1908 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
1909 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
1910 * window.c, xdisp.c, xfns.c: Adjust users.
1911
14ae4239
BT
19122012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
1913
1914 * lread.c (syms_of_lread): Initialize Vlexical_binding.
1915
32bcadb4
JD
19162012-08-11 Jan Djärv <jan.h.d@swipnet.se>
1917
3d29b2ce
JD
1918 * nsterm.m (not_in_argv): New function.
1919 (application:openFile, application:openTempFile:):
1920 (application:openFileWithoutUI:, application:openFiles:): Open file
1921 if not_in_argv returns non-zero (bug#12171).
1922
32bcadb4 1923 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
1924 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
1925 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
1926 (xg_get_font_name): Use those functions/macros here.
1927 Reported by Frans Oilinki <moilinki@gmail.com>.
1928
9ff9402d 19292012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
1930
1931 * unexmacosx.c (copy_data_segment): Copy initialized data in
1932 statically linked libraries from input file rather than memory.
1933
db74a5fc
YM
1934 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
1935 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
1936 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
1937
25e65510
GM
19382012-08-10 Glenn Morris <rgm@gnu.org>
1939
1940 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
1941 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
1942
7961135c
DA
19432012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1944
1945 Fix last change to allow compilation with low optimization levels.
1946 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
1947 Reported by Jan Djärv <jan.h.d@swipnet.se>.
1948
42b3a444
DA
19492012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1950
1951 Use common inline syntax in intervals.h.
1952 * intervals.h (INTERVALS_INLINE): New macro.
1953 Change all users from LISP_INLINE.
1954
9fb0c957
DA
19552012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1956
1957 Define Qnone once for all platforms.
1958 * frame.c (Qnone): Define here.
1959 (syms_of_frame): DEFSYM it.
1960 * lisp.h (Qnone): New declaration.
1961 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
1962 * xfns.c: Remove duplication. Adjust users.
1963
65e8ee52
DA
19642012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1965
1966 Remove unused macros from intervals.h.
1967 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
1968 * intervals.c: Adjust comment.
1969
9b855fd6
EZ
19702012-08-10 Eli Zaretskii <eliz@gnu.org>
1971
1972 * w32fns.c <w32_unicode_gui>: New static variable.
1973 (globals_of_w32fns): Initialize it according to os_subtype.
1974 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
1975 testing os_subtype.
1976
39cb9e56 19772012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
1978 Eli Zaretskii <eliz@gnu.org>
1979
1980 Fix bug #10299 with Unicode characters sent by customized
1981 keyboards created by MSKLC.
1982 * w32fns.c (INIT_WINDOW_CLASS): New macro.
1983 (w32_init_class): Use it to initialize the Emacs class with either
1984 ANSI or Unicode API calls.
1985 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
1986 later.
1987 (w32_wnd_proc): If the character code sent by WM_CHAR or
1988 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
1989 original message. Call DefWindowProcW on NT and later.
1990
9374581a
GM
19912012-08-10 Glenn Morris <rgm@gnu.org>
1992
4b94e8cf
GM
1993 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
1994
9374581a
GM
1995 * lisp.h (DIRECTORY_SEP): Let configure set it.
1996
a2752828
DA
19972012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1998
1999 Use TSET for write access to Lisp_Object slots of struct terminal.
2000 * termhooks.h (TSET): New macro.
2001 * coding.c, terminal.c, xselect.c: Adjust users.
2002
cc92c454
SM
20032012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
2004
2005 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
2006 the failing expression, include them in the error message.
2007 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
2008 * lisp.h (internal_condition_case_n): Update declaration.
2009
4cb3e6b3
DA
20102012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2011
2012 Inline functions to examine and change buffer overlays.
2013 * buffer.c (unchain_both): New function.
2014 * buffer.h (buffer_get_overlays, buffer_set_overlays):
2015 (buffer_has_overlays): New function.
2016 (enum overlay_type): New enum.
2017 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
2018 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
2019
8707c1e5
DA
20202012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2021
2022 Inline functions to examine and change buffer intervals.
2023 * alloc.c (mark_interval_tree): Remove.
2024 (MARK_INTERVAL_TREE): Simplify.
2025 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
2026 * intervals.c (buffer_balance_intervals): New function.
2027 (graft_intervals_into_buffer): Adjust indentation.
2028 (set_intervals_multibyte): Simplify.
2029 * buffer.h (BUF_INTERVALS): Remove.
2030 (buffer_get_intervals, buffer_set_intervals): New function.
2031 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
2032 * intervals.c, textprop.c: Adjust users.
2033
ad8c997f
DA
20342012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2035
2036 Inline functions to examine and change string intervals.
2037 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
2038 (string_get_intervals, string_set_intervals): New function.
2039 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2040 * lread.c, print.c, textprop.c: Adjust users.
2041
32ac3a6b
GM
20422012-08-08 Glenn Morris <rgm@gnu.org>
2043
2044 * lisp.mk (lisp): Remove language/persian.elc.
2045
77c7bcb1
DA
20462012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2047
2048 Cleanup intervals.
2049 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
2050 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
2051 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
2052 Adjust comment. Move under #if 0.
77c7bcb1
DA
2053 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2054 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
2055
9c08a8d4
DA
20562012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2057
2058 Check total length of intervals with eassert.
2059 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
2060 * intervals.c: Change all users to eassert.
2061
26d16b35
EZ
20622012-08-07 Eli Zaretskii <eliz@gnu.org>
2063
14ae4239
BT
2064 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
2065 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
2066 INTERNAL_FIELD in Lisp_Cons.
2067
c644523b
DA
20682012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2069
2070 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
2071 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
2072 name since all xname users are fixed long time ago. Do not
2073 use INTERNAL_FIELD.
2074 (set_symbol_name, set_symbol_function, set_symbol_plist):
2075 (set_symbol_next, set_overlay_plist): New function.
2076 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
2077 (struct Lisp_Overlay): Likewise.
2078 (CVAR, MVAR, SVAR): Remove.
2079 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
2080 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
2081 * xterm.c: Adjust users.
2082 * .gdbinit: Change to use name field of struct Lisp_Symbol
2083 where appropriate.
2084
6a3d20cc
DA
20852012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2086
2087 Basic functions to set Lisp_Object and pointer slots of intervals.
2088 * intervals.h (interval_set_parent, interval_set_object):
2089 (interval_set_left, interval_set_right, interval_set_plist):
2090 (interval_copy_parent): New function.
2091 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
2092 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
2093 Adjust indentation.
6a3d20cc
DA
2094 (INTERVAL_SIZE): Remove. Adjust users.
2095 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
2096
4d2b044c
DA
20972012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2098
2099 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
2100 * process.h (PGET): Remove.
2101 (struct Lisp_Process): Do not use INTERNAL_FIELD.
2102 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2103
d3d50620
DA
21042012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2105
2106 Drop WGET and revert read access to Lisp_Objects slots of struct window.
2107 * window.h (WGET): Remove.
2108 (struct window): Do not use INTERNAL_FIELD.
2109 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2110 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2111 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2112 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2113 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2114 Adjust users.
2115
d10a51dc
CY
21162012-08-07 Chong Yidong <cyd@gnu.org>
2117
2118 * window.c (Fwindow_edges, Fwindow_pixel_edges)
2119 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
2120 (Fdelete_window_internal): Signal an error if the window is not on
2121 a live frame (Bug#12025).
2122
e69b0960
DA
21232012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2124
2125 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
2126 * frame.h (FGET): Remove.
2127 (struct frame): Do not use INTERNAL_FIELD.
2128 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2129 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2130 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2131 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2132
25a20a3a
JB
21332012-08-06 Juanma Barranquero <lekktu@gmail.com>
2134
2135 * w32.c: Silence compiler warnings.
2136 (map_w32_filename): Remove unused variable `is_fat'.
2137 (chase_symlinks): Add parentheses around expression.
2138
1c6f11f4
GM
21392012-08-06 Glenn Morris <rgm@gnu.org>
2140
1db4583a
GM
2141 * sysdep.c: Respect BROKEN_GETWD.
2142
1c6f11f4
GM
2143 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
2144 Let configure handle it.
2145 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
2146
2b90362b
DA
21472012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2148
2149 Use GCALIGNMENT where appropriate.
2150 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
2151 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
2152 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
2153
5f50daf2
EZ
21542012-08-06 Eli Zaretskii <eliz@gnu.org>
2155
14ae4239
BT
2156 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
2157 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 2158
cbcc7007
SM
21592012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
2160
2161 * buffer.h (struct buffer): Revert `indirections' to a simple int;
2162 that should be sufficient for everyone.
2163
4d365fa4
JD
21642012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2165
2166 * keyboard.c (timer_check_2): Add break so timer_check returns next
2167 timeout.
2168
dd86bd82
DA
21692012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2170
2171 Fix Windows build errors introduced after converting to WGET and WSET.
2172 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
2173 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2174
054e1668
JD
21752012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2176
2177 * nsterm.m (ns_frame_rehighlight): Use FSET.
2178
2179 * nsmenu.m (ns_update_menubar): Use FSET.
2180
21238f11
DA
21812012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2182
2183 Separate read and write access to Lisp_Object slots of Lisp_Process.
2184 * process.h (PGET, PSET): New macros similar to AREF and ASET.
2185 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2186
077288cf
DA
21872012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2188
2189 Separate read and write access to Lisp_Object slots of struct window.
2190 * window.h (WGET, WSET): New macros similar to AREF and ASET.
2191 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2192 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2193 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2194 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2195 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2196 Adjust users.
2197
71688bd7
DA
21982012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2199
2200 Fix Windows build errors introduced after converting to FGET and FSET.
2201 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
2202 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
2203 (w32_judge_scroll_bars): Change to use FSET.
2204 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2205
f99bac93
DA
22062012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2207
2208 Fix replacement typo.
2209 * window.c (replace_window): Set root_window instead of
2210 selected_window. This fixes a total window subsystem
2211 malfunction reported by Bastien Guerry <bzg@gnu.org>.
2212
8c2a0f2d
GM
22132012-08-06 Glenn Morris <rgm@gnu.org>
2214
2215 * lisp.mk (lisp): Add language/persian.elc.
2216
edd74c35
DA
22172012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2218
2219 Separate read and write access to Lisp_Object slots of struct frame.
2220 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
2221 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2222 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2223 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2224 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2225
8671676c
AS
22262012-08-05 Andreas Schwab <schwab@linux-m68k.org>
2227
2228 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
2229
663e2b3f
DA
22302012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2231
2232 Generalize common compile-time constants.
2233 * lisp.h (header_size, bool_header_size, word_size): Now here.
2234 (struct Lisp_Vector): Add comment.
2235 (struct Lisp_Bool_Vector): Move up to define handy constants.
2236 (VECSIZE, PSEUDOVECSIZE): Simplify.
2237 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
2238 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
2239 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
2240 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
2241 * xfont.c, xmenu.c: Use word_size where appropriate.
2242
d32e47af
LM
22432012-08-05 Lawrence Mitchell <wence@gmx.li>
2244
2245 * search.c (Freplace_match): Treat \? in the replacement text
2246 literally (Bug#8161).
2247
e5d9c0d1
CY
22482012-08-05 Chong Yidong <cyd@gnu.org>
2249
2250 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
2251 * frame.c (Vdelete_frame_functions):
2252 * emacs.c (Vkill_emacs_hook): Doc fix.
2253
8da0576b
EZ
22542012-08-04 Eli Zaretskii <eliz@gnu.org>
2255
2256 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
2257 --with-x-toolkit=no builds.
2258 Reported by Carsten Mattner <carstenmattner@gmail.com>.
2259
02676e5d
CY
22602012-08-04 Chong Yidong <cyd@gnu.org>
2261
2262 * syntax.c (Fmodify_syntax_entry): Doc fix.
2263
97147da9
EZ
22642012-08-04 Eli Zaretskii <eliz@gnu.org>
2265
76151e2c
EZ
2266 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
2267 * w32.c (init_environment): Change the default values of many
2268 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
2269 them into environment when they were not already defined.
2270 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 2271 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
2272 (check_windows_init_file): Now external, not static.
2273 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
2274 called when Vload_path is already set up.
2275
2276 * w32.h (check_windows_init_file): Add prototype.
2277
2278 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
2279 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
2280 compatibility with Posix platforms.
2281 (main): Move the call to check_windows_init_file to here from
2282 w32.c.
2283 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
2284 any, in the DEFALT argument into the root of the Emacs build or
2285 installation tree, as appropriate.
2286
2287 * callproc.c (init_callproc_1): Call decode_env_path instead of
2288 doing its equivalent by hand.
2289 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
2290 the code that sets Vexec_path run on MS-Windows.
2291
2292 * lread.c (init_lread): Add comments to #ifdef's.
2293
97147da9
EZ
2294 * msdos.c (dos_set_window_size, IT_update_begin)
2295 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
2296 instead of direct references.
2297
185ee146
PE
22982012-08-04 Paul Eggert <eggert@cs.ucla.edu>
2299
2300 Export DEFAULT_REHASH_* to GDB.
2301 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
2302 Now constants, not macros.
2303
8834c57a
PE
23042012-08-03 Paul Eggert <eggert@cs.ucla.edu>
2305
98c6f1e3
PE
2306 Remove unnecessary casts involving pointers.
2307 These casts are no longer needed now that we assume C89 or later,
2308 since they involve casting to or from void *.
2309 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
2310 (make_pure_float, make_pure_vector):
2311 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
2312 * macros.c (Fstart_kbd_macro):
2313 * menu.c (find_and_return_menu_selection):
2314 * minibuf.c (read_minibuf_noninteractive):
2315 * sysdep.c (closedir):
2316 * xdisp.c (x_produce_glyphs):
2317 * xfaces.c (compare_fonts_by_sort_order):
2318 * xfns.c (x_real_positions, select_visual):
2319 * xselect.c (x_stop_queuing_selection_requests)
2320 (x_get_window_property, x_get_window_property_as_lisp_data):
2321 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
2322 Remove unnecessary pointer casts.
2323 * alloc.c (record_xmalloc): New function.
2324 * lisp.h (record_xmalloc): New decl.
2325 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
2326 more like a function. This is because the pointer cast is not
2327 needed. All uses changed.
2328 * print.c (print_string, print_error_message): Avoid length recalc.
2329
8834c57a
PE
2330 Improve fix for macroexp crash with debugging (Bug#12118).
2331 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
2332 ARRAY_MARK_FLAG when checking subscripts, because ASET is
2333 not supposed to be invoked from the garbage collector.
2334 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
2335 (gc_aset): New function, which is like ASET but can be
2336 used in the garbage collector.
2337 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
2338 (set_hash_index): Use it instead of ASET.
2339
6dad7178
EZ
23402012-08-03 Eli Zaretskii <eliz@gnu.org>
2341
2342 Support symlinks on latest versions of MS-Windows.
2343 * w32.c: Include winioctl.h and aclapi.h.
2344 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
2345 (revert_to_self): Forward declarations of static functions.
2346 <static BOOL g_b_init_get_security_info>:
2347 <g_b_init_create_symbolic_link>: New static flags.
2348 (globals_of_w32): Initialize them to zero.
2349 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
2350 (map_w32_filename): Improve commentary. Simplify switch.
2351 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
2352 headers (most versions of MinGW w32api don't).
2353 (get_security_info, create_symbolic_link)
2354 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
2355 New functions.
2356 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
2357 in the argument file name.
2358 (sys_access): Call unc_volume_file_attributes only if
2359 GetFileAttributes fails with network-related error codes.
2360 (sys_rename): Diagnose renaming of a symlink when the user doesn't
2361 have the required privileges.
14ae4239 2362 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
2363 get_file_security_desc.
2364 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
2365 with addition of handling of symlinks and support for 'lstat'.
2366 If possible, get file's attributes and security information by
6dad7178
EZ
2367 handle, not by name. Produce S_IFLNK bit for symlinks, when
2368 called from 'lstat'.
2369 (stat, lstat): New functions, call 'stat_worker'.
2370 (symlink, readlink, careadlinkat): Rewritten to create and resolve
2371 symlinks when the underlying filesystem supports them.
2372
f162bcc3
PE
23732012-08-02 Paul Eggert <eggert@cs.ucla.edu>
2374
79ea6c20
PE
2375 Fix macroexp crash on Windows with debugging (Bug#12118).
2376 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
2377 checking subscripts; problem introduced with the recent
2378 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
2379 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
2380 since it's used in non-static inline functions now.
2381
c0ce93fd
PE
2382 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
2383 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 2384
f162bcc3
PE
2385 Use C99-style 'extern inline' if available.
2386 * buffer.h (BUFFER_INLINE):
2387 * category.h (CATEGORY_INLINE):
2388 * character.h (CHARACTER_INLINE):
2389 * charset.h (CHARSET_INLINE):
2390 * composite.h (COMPOSITE_INLINE):
2391 * dispextern.h (DISPEXTERN_INLINE):
2392 * lisp.h (LISP_INLINE):
2393 * systime.h (SYSTIME_INLINE):
2394 New macro, replacing 'static inline' in this header.
2395 * buffer.h, category.h, character.h, charset.h, composite.h:
2396 * dispextern.h, lisp.h, systime.h:
2397 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2398 * alloc.c (LISP_INLINE):
2399 * buffer.c (BUFFER_INLINE):
2400 * category.c (CATEGORY_INLINE):
2401 * character.c (CHARACTER_INLINE):
2402 * charset.c (CHARSET_INLINE):
2403 * composite.c (COMPOSITE_INLINE):
2404 * dispnew.c (DISPEXTERN_INLINE):
2405 * sysdep.c (SYSTIME_INLINE):
2406 Define to EXTERN_INLINE, so that the corresponding functions
2407 are compiled into code.
2408 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
2409 (INLINE_HEADER_END): New macros.
2410 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
2411 since it's used in non-static inline functions now.
a8333d03 2412 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 2413
837b365b
GM
24142012-08-02 Glenn Morris <rgm@gnu.org>
2415
d66b744d
GM
2416 * s/: Remove empty directory.
2417
837b365b
GM
2418 * s/ms-w32.h: Move to ../nt/inc.
2419 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
2420 Update for new ms-w32.h location.
2421
13294f95
PE
24222012-08-02 Paul Eggert <eggert@cs.ucla.edu>
2423
2424 Port to Solaris 8.
2425 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
2426
90df0db3
GM
24272012-08-02 Glenn Morris <rgm@gnu.org>
2428
2429 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
2430 hard-coding the path separator.
2431
4939150c
PE
24322012-08-01 Paul Eggert <eggert@cs.ucla.edu>
2433
2434 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
2435 This how ASET and AREF are supposed to work, and makes
2436 it easier to think about future improvements. See
2437 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
2438 * charset.h (set_charset_attr): New function.
2439 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
2440 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
2441 (aref_addr): New function. All uses of &AREF(...) changed.
2442 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
2443 (set_hash_index): New functions. All lvalue-style uses of
2444 HASH_KEY etc. changed.
2445 * keyboard.c (set_prop): New function. All lvalue-style uses
2446 of PROP changed.
2447
947b2afd
AA
24482012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
2449
2450 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
2451 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
2452 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
2453 * nsfns.m (ns_set_name_as_filename): Likewise.
2454 * nsmenu.m (ns_update_menubar): Likewise.
2455 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
2456
4f5d0325
EZ
24572012-08-01 Eli Zaretskii <eliz@gnu.org>
2458
2008beae
EZ
2459 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
2460 Adapt to latest changes in field names of the corresponding Lisp
288479f6 2461 objects.
2008beae 2462
4f5d0325
EZ
2463 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
2464
fe3cc771
GM
24652012-08-01 Glenn Morris <rgm@gnu.org>
2466
2467 * s/msdos.h: Remove file.
2468 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
2469 * Makefile.in (S_FILE): Remove.
2470 (config_h): Remove S_FILE.
2471
c90acc54
JB
24722012-08-01 Juanma Barranquero <lekktu@gmail.com>
2473
2474 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
2475 Remove; moved to nt/config.nt.
2476
d8a05828
DA
24772012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2478
2479 Use INTERNAL_FIELD for conses and overlays.
2480 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
2481 Remove obsolete comment.
2482 (MVAR): New macro.
2483 (struct Lisp_Overlay): Use INTERNAL_FIELD.
2484 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
2485
8271d590
DA
24862012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2487
2488 Use INTERNAL_FIELD for symbols.
2489 * lisp.h (SVAR): New macro. Adjust users.
2490 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
2491 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
2492
3193acd2
DA
24932012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2494
2495 Use INTERNAL_FIELD for processes.
2496 * process.h (PVAR): New macro. Adjust style.
2497 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
2498 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
2499
3a45383a
DA
25002012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2501
2502 Use INTERNAL_FIELD for windows.
2503 * window.h (WVAR): New macro.
2504 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
2505 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2506 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2507 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
2508 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
2509 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
2510
c1dbc63c
PE
25112012-08-01 Paul Eggert <eggert@cs.ucla.edu>
2512
2513 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
2514
5c0c0e8a
GM
25152012-08-01 Glenn Morris <rgm@gnu.org>
2516
2517 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
2518 Move to configure.ac.
2519
552a99b4
JB
25202012-08-01 Juanma Barranquero <lekktu@gmail.com>
2521
2522 * makefile.w32-in (CONFIG_H): Update dependencies.
2523 (CONF_POST_H): New macro.
2524
2525 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
2526
8d8e2dfe
GM
25272012-07-31 Glenn Morris <rgm@gnu.org>
2528
bc96620a
GM
2529 * Makefile.in (S_FILE): No longer set by configure.
2530
476b1b2d
GM
2531 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
2532 is available.
2533 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
2534
b2c7a106
GM
2535 * process.h (NULL_DEVICE):
2536 * emacs.c (SEPCHAR):
2537 * editfns.c (USER_FULL_NAME): Let configure set them.
2538
d53d062a
GM
2539 * s/README, s/template.h: Remove files.
2540
4515017f
GM
2541 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
2542
8d8e2dfe
GM
2543 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
2544 Move to configure.ac.
2545
5b20b3cc
EZ
25462012-07-31 Eli Zaretskii <eliz@gnu.org>
2547
1e0afd9a
EZ
2548 * .gdbinit (xframe): Adapt to introduction of FVAR and the
2549 resulting renaming of 'struct frame' members.
2550
5b20b3cc
EZ
2551 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
2552
2553 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
2554 after introduction of FVAR.
2555
f1310128
JD
25562012-07-31 Jan Djärv <jan.h.d@swipnet.se>
2557
79e721e0
JD
2558 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
2559
2560 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
2561 instead of compositeToPoint.
2562 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
2563
8d7c7eed 2564 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 2565
e34f7f79
DA
25662012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2567
2568 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
2569 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 2570 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
2571 (BVAR): Change to use INTERNAL_FIELD.
2572 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
2573 (KVAR): Change to use INTERNAL_FIELD.
2574 * frame.h (FVAR): New macro.
2575 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
2576 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
2577 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
2578 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
2579 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
2580
c09bfb2f
DA
25812012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2582
2583 Miscellaneous fixes for non-default X toolkits.
2584 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
2585 * xterm.c (x_frame_of_widget): Remove redundant prototype.
2586 Move under #ifdef USE_LUCID.
2587 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
2588 definition and usage to avoid warnings.
2589
14c114ae
JD
25902012-07-31 Jan Djärv <jan.h.d@swipnet.se>
2591
2592 * nsterm.m (openFiles): Fix previous checkin.
2593
3bd21e82
PE
25942012-07-31 Paul Eggert <eggert@cs.ucla.edu>
2595
2596 * indent.c (compute_motion): Remove unused local.
2597
c1529ded
GM
25982012-07-31 Glenn Morris <rgm@gnu.org>
2599
400d5621
GM
2600 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
2601
268e2432
GM
2602 * conf_post.h [USG5_4]:
2603 Move remaining contents of s/usg5-4-common.h here.
2604 * s/usg5-4-common.h: Remove file.
2605
7552f3ee
GM
2606 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
2607 * s/irix6-5.h: Remove file.
2608
6a381852
GM
2609 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
2610 * s/darwin.h: Remove file.
2611
c1529ded
GM
2612 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
2613 * s/hpux10-20.h: Remove file, which is now empty.
2614
b429a4ee
GM
26152012-07-30 Glenn Morris <rgm@gnu.org>
2616
2617 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
2618 * Makefile.in (config_h): Add conf_post.h.
2619 * makefile.w32-in (CONFIG_H): Add conf_post.h.
2620
adff3182
JD
26212012-07-30 Jan Djärv <jan.h.d@swipnet.se>
2622
2623 * nsterm.m (ns_do_open_file): New variable.
b9031d69 2624 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
2625 (openFile, openTempFile, openFileWithoutUI, openFiles):
2626 Open files only if ns_do_open_file.
adff3182 2627
c32af1e4
PE
26282012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2629
7393bcbb
PE
2630 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
2631 This no-op macro hasn't been needed for many years.
2632 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
2633
c32af1e4
PE
2634 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
2635 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
2636 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
2637 gdb_make_enums_visible.
2638 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
2639 (DIRECTORY_SEP): Now a constant, not a macro.
2640
302fc036
EZ
26412012-07-30 Eli Zaretskii <eliz@gnu.org>
2642
2643 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
2644 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
2645
2646 * w32term.c <w32_keyboard_codepage>: Renamed from
2647 keyboard_codepage and now external. All users changed.
2648
2649 * w32term.h: Add declaration of w32_keyboard_codepage.
2650
2651 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
2652 the codepage to translate keys to Unicode. If this argument is
2653 -1, use the value returned by GetConsoleCP. All callers changed.
2654
88fb40b4
PE
26552012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2656
0aee6912
PE
2657 Update .PHONY listings in makefiles.
2658 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
2659 bootstrap-clean, distclean, maintainer-clean, versioclean,
2660 extraclean, frc.
2661
88fb40b4
PE
2662 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
2663 This is a bit clearer. Fix some commentary typos.
2664
0a763bd1
GM
26652012-07-30 Glenn Morris <rgm@gnu.org>
2666
32bac6d6
GM
2667 * s/netbsd.h: Let configure include signal.h if needed.
2668 Remove file, which is now empty.
2669
b65e7c46
GM
2670 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
2671 Let configure set them.
2672 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
2673 No more need to undefine.
0a763bd1 2674
169304bd
AS
26752012-07-30 Andreas Schwab <schwab@linux-m68k.org>
2676
2677 * keymap.c (Fkey_description): Don't remove 0x80 bit from
2678 non-single-byte char when adding meta modifier. (Bug#12090)
2679
6cd7a139
DA
26802012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2681
2682 Convert safe_call to use variable number of arguments.
2683 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
2684 (safe_call2): Fix comment.
2685 * lisp.h (safe_call): Adjust prototype.
2686 * coding.c (encode_coding_object): Change to use safe_call2.
2687 * xfaces.c (merge_face_heights): Change to use safe_call1.
2688
d34d6ffc
GM
26892012-07-30 Glenn Morris <rgm@gnu.org>
2690
7b8a48e4 2691 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 2692 does that unconditionally. Remove file, which is now empty.
7b8a48e4 2693
d34d6ffc
GM
2694 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
2695 Remove empty files.
2696
03a660a6
PE
26972012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2698
2699 Export to GDB most of lisp.h's remaining object-like macros.
2700 * lisp.h (min, max): Move earlier, because they're used earlier now.
2701 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
2702 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
2703 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
2704 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
2705 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
2706 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
2707 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
2708 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
2709 Now constants, for GDB. They need not be macros.
2710 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
2711 Now constants, for GDB, as well as macros, for static initializers.
2712 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
2713 Move to after the definition of struct Lisp_Char_Table,
2714 since the former now needs that type defined.
2715 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
2716 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
2717 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
2718 New enums, for gdb_make_enums_visible.
2719 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 2720 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
2721 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
2722 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
2723 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
2724 enum maxargs, enum MAX_ALLOCA.
2725 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
2726 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
2727 no longer needed, now that they are done in lisp.h.
2728
e499d0ee
DA
27292012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
2730
2731 Cleanup string bytes checking.
2732 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
2733 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
2734 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
2735 (check_sblock, compact_small_strings): Simplify.
2736
d5040d2d
PE
27372012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2738
2739 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
2740 These macros are confusing and no longer need to be defined, as
2741 the enum values now suffice. All uses replaced with definiens.
2742 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
2743
7f259ae6
JB
27442012-07-29 Juanma Barranquero <lekktu@gmail.com>
2745
2746 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
2747 ($(BLD)/w32console.$(O)): Update dependencies.
2748
7e63e0c3
DA
27492012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2750
2751 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
2752 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
2753 time. Adjust users.
2754 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
2755
ffd817eb
JD
27562012-07-29 Jan Djärv <jan.h.d@swipnet.se>
2757
2758 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
2759 setting sitelisp (Bug#12010).
2760
417a7a0e
EZ
27612012-07-29 Eli Zaretskii <eliz@gnu.org>
2762
14ae4239 2763 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
2764
2765 * w32heap.c (cache_system_info):
2766 * w32.c (sys_rename):
2767 * w32proc.c (find_child_console, sys_kill): All users changed.
2768
387d4d92
PE
27692012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2770
2771 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
2772
55a6cca6
EZ
27732012-07-29 Eli Zaretskii <eliz@gnu.org>
2774
2775 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
2776
dbcf001c
DA
27772012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2778
2779 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
2780 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
2781 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 2782
e2688e4a
DA
27832012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2784
2785 Generalize marker debugging code under MARKER_DEBUG and use eassert.
2786 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
2787 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
2788 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
2789 (replace_range, replace_range_2, del_range_2): Change to eassert.
2790 * marker.c (byte_char_debug_check): Adjust style.
2791
b46a6a83
PE
27922012-07-29 Paul Eggert <eggert@cs.ucla.edu>
2793
2794 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
2795 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
2796 long-ago-commented-out code that talks about "WIN32".
2797 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
2798 All uses changed.
2799
e32a5799
PE
28002012-07-28 Paul Eggert <eggert@cs.ucla.edu>
2801
2802 Use Gnulib stdalign module (Bug#9772, Bug#9960).
2803 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
2804 Simplify by using alignof.
2805 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
2806 * lisp.h: Include <stdalign.h>.
2807 (GCALIGNMENT): New macro and constant.
2808 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
2809 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
2810 (stdalign): New macro, if not already defined.
2811
df81cd29
EZ
28122012-07-28 Eli Zaretskii <eliz@gnu.org>
2813
01bd1b0d
EZ
2814 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
2815 * w32inevt.c: Include w32inevt.h.
2816 (w32_read_console_input): New inline function, calls either
2817 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
2818 w32_console_unicode_input.
2819 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
2820 (w32_kbd_patch_key, key_event): Use the codepage returned by
2821 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
2822 (key_event): use uChar.UnicodeChar only if
2823 w32_console_unicode_input is non-zero.
2824
2825 * w32console.c: Include w32heap.h.
2826 <w32_console_unicode_input>: New global variable.
2827 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
2828 family of Windows, zero otherwise.
2829
2830 * w32inevt.h: Declare w32_console_unicode_input.
2831
df81cd29
EZ
2832 * xdisp.c (init_iterator): Don't reference tip_frame in a build
2833 --without-x. (Bug#11742)
2834
c20fdd9e
PE
28352012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 Adjust GDB to reflect pvec_type changes (Bug#12036).
2838 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
2839 2012-07-04 changes to pseudovector representation.
2840 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 2841
32770973 28422012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
2843
2844 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
2845 bus address.
2846 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
2847
3438fe21
EZ
28482012-07-27 Eli Zaretskii <eliz@gnu.org>
2849
bcfbc9de
EZ
2850 * alloc.c (listn): Fix the order the arguments are consed onto the
2851 list.
2852
3438fe21
EZ
2853 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
2854 enumeration constants, as PURE and HEAP are too general, and clash
2855 with other headers and sources, such as gmalloc.c and the
2856 MS-Windows system headers. All users changed.
2857
eeaea515
DA
28582012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2859
2860 Revert last save_excursion_save and save_excursion_restore changes.
2861 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
2862 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
2863
073c88c2
DA
28642012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2865
2866 Fix recently-introduced typos in Windows port.
2867 Reported by Martin Rudalics <rudalics@gmx.at>.
2868 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 2869 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 2870
4706125e
PE
28712012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 Improve GDB symbol export (Bug#12036).
2874 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
2875 arms of an 'if', not using conditional expressions; otherwise GDB
2876 complains about the types in the unevaluated arm when the argument
2877 is an integer literal.
2878 (xgetint): Simplify expression.
2879 * alloc.c (gdb_make_enums_visible): New constant. This ports to
2880 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
2881 Zaretskii in <http://bugs.gnu.org/12036#13>.
2882 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
2883 needed now that we have gdb_make_enums_visible.
2884 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
2885 (enum enum_USE_LSB_TAG):
2886 New enum types, packaging up enums that need to be exported to GDB.
2887
694b6c97
DA
28882012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2889
2890 Utility function to make a list from specified amount of objects.
2891 * lisp.h (enum constype): New datatype.
2892 (listn): New prototype.
2893 * alloc.c (listn): New function.
2894 (Fmemory_use_count, syms_of_alloc): Use it.
2895 * buffer.c (syms_of_buffer): Likewise.
2896 * callint.c (syms_of_callint): Likewise.
2897 * charset.c (define_charset_internal): Likewise.
2898 * coding.c (syms_of_coding): Likewise.
2899 * keymap.c (syms_of_keymap): Likewise.
2900 * search.c (syms_of_search): Likewise.
2901 * syntax.c (syms_of_syntax): Likewise.
2902 * w32.c (init_environment): Likewise.
2903 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
2904 * xdisp.c (syms_of_xdisp): Likewise.
2905 * xfns.c (syms_of_xfns): Likewise.
2906
6195f384
DA
29072012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2908
2909 Fast save_excursion_save and save_excursion_restore.
2910 * lisp.h (struct Lisp_Excursion): New data type.
2911 (PVEC_EXCURSION): New pseudovector type.
2912 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
2913 to deal with it. Adjust comments.
2914 (init_marker, attach_marker): New prototype.
2915 (unchain_marker): Adjust prototype.
2916 * marker.c (attach_marker): Change to global.
2917 (init_marker): New function.
2918 * alloc.c (Fmake_marker, build_marker): Use it.
2919 (build_marker): More easserts.
2920 (mark_object): Handle struct Lisp_Excursion.
2921 * editfns.c (save_excursion_save, save_excursion_restore):
2922 Reimplement to use struct Lisp_Excursion. Add comments.
2923
5eceb8fb
PE
29242012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2925
2926 Fix export of symbols to GDB (Bug#12036).
2927 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
2928 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
2929 emacs.c, as this is a more-suitable home. Had this been done earlier
2930 the fix for 12036 would have avoided some of the problems noted in
2931 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
2932 would have been more obvious.
562157c8
PE
2933 * emacs.c: Do not include <verify.h>; no longer needed.
2934 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
2935 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
2936 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2937 Remove; now done in lisp.h.
2938 * lisp.h (PUBLISH_TO_GDB): New macro.
2939 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
2940 (DATA_SEG_BITS): Use it.
2941 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
2942 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
2943 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
2944 not be usable in #if. This simplifies things.
2945
d6749401
JB
29462012-07-26 Juanma Barranquero <lekktu@gmail.com>
2947
2948 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
2949
1781b9e9
PE
29502012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2951
d89518db 2952 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
2953 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
2954 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
2955 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
2956 Adjust to changes in lisp.h and emacs.c, by using
2957 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
2958 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
2959 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
2960 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
2961 instead of gdb_valbits.
2962 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
2963 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
2964 instead of gdb_array_mark_flag.
2965 (xboolvector): Get size from $->size, not $->header.size.
2966 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
2967 (xreload, hook-run, hookpost-run): Remove.
2968 * emacs.c: Include <verify.h>.
2969 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
2970 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
2971 Remove.
2972 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
2973 (gdb_USE_LSB_TAG): New enum constants.
2974 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2975 Also define these as enum constants, so they're visible to GDB.
2976 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
2977 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
2978 as constants, so they're visible to GDB.
2979 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
2980 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
2981 Now enum constants, not macros, so they're visible to GDB.
2982 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
2983 more convenient now. All uses changed.
2984 (VALMASK) [USE_LSB_TAG]: Also define in this case.
2985 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
2986
3628596a
DA
29872012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
2988
2989 Explicitly free restriction data that are not needed anymore.
2990 * editfns.c (save_restriction_restore): Free restriction data.
2991
7abaf5cc
SM
29922012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2993
2994 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
2995 add argument, tune behavior, and adjust all callers.
2996
71f88e00
PE
29972012-07-25 Paul Eggert <eggert@cs.ucla.edu>
2998
2999 Use typedef for EMACS_INT, EMACS_UINT.
3000 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
3001 than macros. This simplifies debugging in the usual case, since
3002 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
3003 and it allows expressions involving EMACS_INT casts.
3004 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
3005
57ec3034
JD
30062012-07-25 Jan Djärv <jan.h.d@swipnet.se>
3007
3008 * nsterm.m (ns_read_socket): Return early if there is a modal
3009 window (Bug#12043).
3010
8137e7b3
MR
30112012-07-25 Martin Rudalics <rudalics@gmx.at>
3012
3013 * frame.c (Fredirect_frame_focus): In doc-string don't mention
3014 that FOCUS-FRAME can be omitted.
3015
04e9897c
DA
30162012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
3017
3018 Adjust buffer text indirection counters at the end of Fkill_buffer.
3019 * buffer.c (Fkill_buffer): Adjust indirection counters when the
3020 buffer is definitely dead. This should really fix an issue reported
3021 by Christoph Scholtes again. (Bug#12007).
3022 (init_buffer_once): Initialize indirection counters of
3023 buffer_defaults and buffer_local_symbols (for sanity and safety).
3024
8a0484e1
EZ
30252012-07-24 Eli Zaretskii <eliz@gnu.org>
3026
3027 * xdisp.c (init_iterator): Don't compute dimensions of truncation
3028 and continuation glyphs on tooltip frames, leave them at zero.
3029 Avoids continued lines in tooltips. (Bug#11832)
3030
fa691a83
DA
30312012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
3032
3033 Simplify copy_overlay.
04e9897c 3034 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
3035 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
3036
436bc8e0
EZ
30372012-07-23 Eli Zaretskii <eliz@gnu.org>
3038
3039 * print.c (print_object): Don't crash when a frame's name is nil
3040 or invalid. (Bug#12025)
3041
3042 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
3043 it signals an error when a tooltip frame is being created.
3044
d7a7fda3
DA
30452012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
3046
3047 Cleanup miscellaneous objects allocation and initialization.
3048 * alloc.c (allocate_misc): Change to static. Add argument to
3049 specify the subtype. Adjust comment and users.
3050 (build_overlay): New function.
3051 * buffer.c (copy_overlays, Fmake_overlay): Use it.
3052 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
3053 (allocate_misc): Remove prototype.
3054 (build_overlay): Add prototype.
3055
30562012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
3057
3058 Swap buffer text indirection counters in Fbuffer_swap_text.
3059 * buffer.c (Fbuffer_swap_text): Swap indirections too.
3060 This avoids crash reported by Christoph Scholtes at
3061 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
3062
9d7fa573
JD
30632012-07-22 Jan Djärv <jan.h.d@swipnet.se>
3064
3065 * nsmenu.m (Popdown_data): New struct.
3066 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
3067 free Popdown_data.
3068 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
3069 (initWithContentRect): Make imgView and contentView non-static
3070 and autorelease them. Also autorelease img and matrix (Bug#12005).
3071 (dealloc): Remove (Bug#12005).
3072
0dd6d66d
DA
30732012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3074
3075 Adjust consing_since_gc when objects are explicitly freed.
3076 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
3077 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
3078 (free_cons, free_misc): Subtract object size from consing_since_gc.
3079
d36d71df
DA
30802012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3081
3082 Simplify and cleanup markers positioning code.
3083 * marker.c (attach_marker): More useful eassert.
3084 (live_buffer, set_marker_internal): New function.
3085 (Fset_marker, set_marker_restricted): Use set_marker_internal.
3086 (set_marker_both, set_marker_restricted_both): Use live_buffer.
3087
fb9ea40f
PE
30882012-07-22 Paul Eggert <eggert@cs.ucla.edu>
3089
3090 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
3091 as it's limited by the amount of memory, not by INT_MAX.
3092
2d5c5f7d
EZ
30932012-07-21 Eli Zaretskii <eliz@gnu.org>
3094
07fb592e
EZ
3095 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
3096 in special-event-map. See the discussion at
3097 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
3098 for the reasons.
3099
37a9eac8 3100 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
3101 info.dwItemData. Fixes crashes on 64-bit Windows.
3102 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 3103
c4328746
JD
31042012-07-21 Jan Djärv <jan.h.d@swipnet.se>
3105
3106 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 3107 (conversationIdentifier): Return value is NSInteger.
784051c4 3108 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 3109
6e5d1c12
CY
31102012-07-21 Chong Yidong <cyd@gnu.org>
3111
3112 * window.c (decode_any_window): Signal an error if the window is
3113 on a dead frame (Bug#11984).
3114
9928463d
DA
31152012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3116
3117 Add indirection counting to speed up Fkill_buffer.
3118 * buffer.h (struct buffer): New member.
3119 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
3120 (Fmake_indirect_buffer): Set indirection counter to -1, increment
3121 base buffer indirection counter.
3122 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
3123 (Fkill_buffer): Adjust indirection counters as needed, don't walk
3124 through buffer list if indirection counter is 0.
3125
f8643a6b
DA
31262012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3127
3128 Extend the value returned by Fgarbage_collect with heap statistics.
3129 * alloc.c (Qheap): New symbol.
3130 (syms_of_alloc): DEFSYM it.
3131 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
3132 (Fmemory_free): Remove.
3133 (syms_of_alloc): Don't defsubr it.
3134 * buffer.c (Fcompact_buffer): Remove.
3135 (syms_of_buffer): Don't defsubr it.
3136
dac616ff
DA
31372012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3138
3139 Make maybe_gc inline.
3140 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
3141 * lisp.h (consing_since_gc, gc_relative_threshold)
3142 (memory_full_cons_threshold): Revert declaration.
3143 (maybe_gc): Remove prototype, define as inline.
3144 * alloc.c: Remove old commented-out code.
3145 (consing_since_gc, gc_relative_threshold)
3146 (memory_full_cons_threshold): Revert to global.
3147 (maybe_gc): Remove.
3148
d7ea76b4
DA
31492012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3150
3151 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
3152 * lisp.h (build_unibyte_string): New function.
3153 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
3154 * sysdep.c, w32fns.c, xfns.c: Use it.
3155 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
3156 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
3157 Adjust users accordingly.
3158 * font.h (font_open_by_name): Adjust prototype.
3159
765e61e3
DA
31602012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3161
3162 Cleanup calls to Fgarbage_collect.
3163 * lisp.h (maybe_gc): New prototype.
3164 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3165 Remove declarations.
3166 * alloc.c (maybe_gc): New function.
3167 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3168 Make them static.
3169 * bytecode.c (MAYBE_GC): Use maybe_gc.
3170 * eval.c (eval_sub, Ffuncall): Likewise.
3171 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
3172 to avoid dependency from auto-save feature.
3173
52b852c7
PE
31742012-07-19 Paul Eggert <eggert@cs.ucla.edu>
3175
3176 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
3177 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
3178 'for_each_per_buffer_object_at'.
3179 All uses changed. It's better to use upper-case for macros that
3180 cannot be implemented as functions, to give the reader a clue
3181 that they're special.
3182
5db81e33
SM
31832012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
3184
3185 * alloc.c (Fgarbage_collect): Tweak docstring.
3186
5b835e1d
DA
31872012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3188
3189 Tweak the value returned from Fgarbage_collect again.
3190 * alloc.c (Fgarbage_collect): New return value, as confirmed in
3191 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
3192 Adjust documentation.
3193 (total_vector_bytes): Rename to total_vector_slots, adjust
3194 accounting.
3195 (total_free_vector_bytes): Rename to total_free_vector_slots,
3196 adjust accounting.
3197 (Qstring_bytes, Qvector_slots): New symbols.
3198 (syms_of_alloc): DEFSYM them.
3199
9cd47b72
DA
32002012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3201
3202 Buffer compaction primitive which may be used from Lisp.
3203 * buffer.c (compact_buffer, Fcompact_buffer): New function.
3204 (syms_of_buffer): Register Fcompact_buffer.
3205 * alloc.c (Fgarbage_collect): Use compact_buffer.
3206 * buffer.h (compact_buffer): New prototype.
3207 (struct buffer_text): New member.
3208
d17337e5
DA
32092012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3210
3211 New macro to iterate over all buffers, miscellaneous cleanups.
3212 * lisp.h (all_buffers): Remove declaration.
3213 * buffer.h (all_buffers): Add declaration, with comment.
3214 (for_each_buffer): New macro.
3215 * alloc.c (Fgarbage_collect, mark_object): Use it.
3216 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
3217 (init_buffer): Likewise.
3218 * data.c (Fset_default): Likewise.
3219 * coding.c (code_conversion_restore): Remove redundant check
3220 for dead buffer.
3221 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
3222
60cfd278
AS
32232012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3224
3225 Fix bug that created negative-length intervals.
3226 * intervals.c (merge_interval_right, merge_interval_left):
3227 Do not zero out this interval if it is absorbed by its children,
3228 as this interval's total length doesn't change in that case. See
3229 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
3230
d06714cb
PE
32312012-07-18 Paul Eggert <eggert@cs.ucla.edu>
3232
83713154
PE
3233 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
3234 when invoking (make-bool-vector N t) and N is a positive
3235 multiple of 8 -- the last 8 bits were mistakenly cleared.
3236
d06714cb
PE
3237 Remove some struct layout assumptions in bool vectors.
3238 * alloc.c (bool_header_size): New constant.
3239 (header_size, word_size): Move earlier, as they're now used earlier.
3240 Use 'word_size' in a few more places, where it's appropriate.
3241 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
3242 padding before the data member of a bool vector.
3243 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
3244 than doing the check by hand with an abort ().
3245
464d5a5e
SM
32462012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3247
5fbc0409
SM
3248 * eval.c (Fdefvar): Don't check constants since we only set the var if
3249 it's not yet defined anyway (bug#11904).
3250
464d5a5e
SM
3251 * lisp.h (last_undo_boundary): Declare new var.
3252 * keyboard.c (command_loop_1): Set it.
3253 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
3254 were auto-added by the command loop (bug#11774).
3255
8dc2e44a
AS
32562012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3257
3258 * w32font.c (Qsymbol): Remove local definition.
3259 (syms_of_w32font): Don't DEFSYM it.
3260
169925ec
DA
32612012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
3262
3263 Fix sweep_vectors to handle large bool vectors correctly.
3264 * alloc.c (sweep_vectors): Account total_vector_bytes for
3265 bool vectors larger than VBLOCK_BYTES_MAX.
3266
5fbfb018
CY
32672012-07-18 Chong Yidong <cyd@gnu.org>
3268
3269 * frame.c (x_set_frame_parameters): Revert bogus change introduced
3270 in 2012-05-25 commit by Paul Eggert (Bug#11738).
3271
3ab6e069
DA
32722012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
3273
3274 Return more descriptive data from Fgarbage_collect.
3275 Suggested by Stefan Monnier in
3276 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
3277 * alloc.c (bounded_number): New function.
3278 (total_buffers, total_vectors): New variable.
3279 (total_string_size): Rename to total_string_bytes, adjust users.
3280 (total_vector_size): Rename to total_vector_bytes, adjust users.
3281 (sweep_vectors): Account total_vectors and total_vector_bytes.
3282 (Fgarbage_collect): New return value. Adjust documentation.
3283 (gc_sweep): Account total_buffers.
3284 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
3285 (VECTOR_SIZE): Remove.
3286 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
3287 (Qinterval, Qmisc): New symbols.
3288 (syms_of_data): Initialize them.
3289 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
3290 (Qcons, Qbuffer): New declarations.
3291
6d02fe5b
PE
32922012-07-17 Paul Eggert <eggert@cs.ucla.edu>
3293
3294 * alloc.c (Fmemory_free): Account for memory-free's own storage.
3295 Round up, not down. Improve doc.
3296
b7ffe040
DA
32972012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3298
3299 Restore old code in allocate_string_data to avoid Faset breakage.
3300 Reported by Julien Danjou <julien@danjou.info> in
3301 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
3302 * alloc.c (allocate_string_data): Restore old code with minor
3303 adjustments, fix comment to explain this subtle issue.
3304
4dc7c8d5
SM
33052012-07-17 Eli Zaretskii <eliz@gnu.org>
3306
3307 Remove FILE_SYSTEM_CASE.
3308 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
3309
3310 * fileio.c (FILE_SYSTEM_CASE): Don't define.
3311 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
3312 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
3313 call-process-region passes it through expand-file-name.
3314
3315 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
3316
33172012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3318
3319 Fix crash when creating indirect buffer (Bug#11917)
3320 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
3321 Don't handle unbound variables specially if non-zero.
3322 (Fbuffer_local_variables): Pass zero.
3323 (clone_per_buffer_values): Pass non-zero.
3324
33252012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3326
3327 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
3328 to make the loop interruptible.
3329
33302012-07-17 Andreas Schwab <schwab@linux-m68k.org>
3331
3332 * gnutls.c (emacs_gnutls_handshake): Only retry if
3333 GNUTLS_E_INTERRUPTED.
3334
cce7fefc
DA
33352012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3336
3337 Cleanup and convert miscellaneous checks to eassert.
3338 * alloc.c (mark_interval): Fix comment, partially rephrase
3339 old comment from intervals.h (see below).
3340 * intervals.c (find_interval, adjust_intervals_for_insertion)
3341 (delete_interval, adjust_intervals_for_deletion)
3342 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
3343 Convert to eassert.
3344 (adjust_intervals_for_insertion, make_new_interval):
3345 Remove obsolete and unused code.
3346 * intervals.h (struct interval): Remove obsolete comment.
3347 * textprotp.c (erase_properties): Remove unused code.
3348 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
3349 (Fremove_list_of_text_properties): Convert to eassert.
3350
9ea10cc3
CY
33512012-07-17 Chong Yidong <cyd@gnu.org>
3352
3353 * editfns.c (Finsert_char): Doc fix.
3354
3900d5de
DA
33552012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3356
3357 Fix previous change to make Fmemory_free always accurate.
3358 * alloc.c (make_interval): Update total_free_intervals.
3359 (make_float): Likewise for total_free_floats.
3360 (free_cons, Fcons): Likewise for total_free_conses.
3361 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
3362 Likewise for total_free_vector_bytes.
3363 (Fmake_symbol): Likewise for total_free_symbols.
3364 (bytes_free): Remove.
3365
7098646f
DA
33662012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3367
3368 Simple free memory accounting feature.
3369 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
3370 (sweep_vectors): Accumulate size of free vectors.
3371 (Fgarbage_collect): Setup bytes_free.
3372 (Fmemory_free): New function.
3373 (syms_of_alloc): Register it.
3374
22657b40
DA
33752012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
3376
3377 Cleanup overlays checking.
3378 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
3379 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
3380 eassert and OVERLAYP.
3381 (sort_overlays): Change to use OVERLAYP.
3382
ddfc8813
RK
33832012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
3384
3385 * editfns.c (Finsert_char): Make it interactive, and make the
3386 second arg optional. Copy interactive spec and docstring from
3387 ucs-insert.
3388
7c26cf3c
PE
33892012-07-17 Paul Eggert <eggert@cs.ucla.edu>
3390
3391 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
3392 Unlike the other wrapped functions, fabs has an unspecified
3393 effect on errno.
3394
5d127af9
JD
33952012-07-16 Jan Djärv <jan.h.d@swipnet.se>
3396
3397 * nsterm.m (keyDown): Interpret flags without left/right bits
3398 as the left key (Bug#11670).
3399
6a0dd1d7
DA
34002012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
3401
3402 Remove empty and useless init functions.
3403 * lisp.h (init_character_once, init_fns, init_image)
3404 (init_filelock, init_sound): Remove prototype.
3405 * character.c (init_character_once): Remove.
3406 * filelock.c (init_filelock): Likewise.
3407 * fns.c (init_fns): Likewise.
3408 * image.c (init_image): Likewise.
3409 * sound.c (init_sound): Likewise.
3410 * emacs.c (main): Adjust accordingly.
3411
7a6136fd
DA
34122012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
3413
3414 * gtkutil.h: Tiny cleanups.
3415 (use_old_gtk_file_dialog): Remove useless declaration.
3416 (xg_uses_old_file_dialog): Add suggested const attribute.
3417
ce811ad9
EZ
34182012-07-15 Eli Zaretskii <eliz@gnu.org>
3419
3420 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
3421 (bidi_paragraph_init): Use it to limit search forward for a strong
3422 directional character in abnormally large paragraphs full of
3423 neutral or weak characters. (Bug#11943)
3424
c9adfeaa
SF
34252012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
3426
3427 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
3428 the toolbar (Bug#9451).
3429 (xg_make_tool_item): Give the widget event box a transparent
3430 background.
3431
fff62aa9
DA
34322012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
3433
3434 Cleanup basic allocation variables and functions.
3435 * alloc.c (ignore_warnings, init_intervals, init_float)
3436 (init_cons, init_symbol, init_marker): Remove.
3437 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
3438 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
3439 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
3440 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
3441 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
3442 (staticidx, init_alloc_once, init_strings, free_ablock):
3443 Remove redundant initialization.
3444 * fns.c (init_weak_hash_tables): Remove.
3445 * lisp.h (init_weak_hash_tables): Remove prototype.
3446
9730daca
DA
34472012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
3448
3449 Use zero_vector where appropriate.
3450 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
3451 accordingly.
3452 * lisp.h (zero_vector): New declaration.
3453 * font.c (null_vector): Remove.
3454 (syms_of_font): Remove initialization and staticpro.
3455 (font_list_entities, font_find_for_lface): Change to use zero_vector.
3456 * keymap.c (Faccessible_keymaps): Likewise.
3457
2e2d2a13
LL
34582012-07-15 Leo Liu <sdl.web@gmail.com>
3459
3460 * fringe.c: Fix typo in comments.
3461
cd276f6e
LL
34622012-07-14 Leo Liu <sdl.web@gmail.com>
3463
3464 * fringe.c: Add a new bitmap exclamation-mark.
3465
5a1131d9
EZ
34662012-07-14 Eli Zaretskii <eliz@gnu.org>
3467
3468 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
3469
3470 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
3471 (HAVE_MENUS): Don't define, defined by editing config.in with
3472 msdos/sed2v2.inp.
3473 (GMALLOC_INHIBIT_VALLOC): Don't define.
3474 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
3475
22e983b7
JB
34762012-07-14 Juanma Barranquero <lekktu@gmail.com>
3477
3478 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
3479
5b3f250f
GM
34802012-07-14 Glenn Morris <rgm@gnu.org>
3481
3482 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
3483 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
3484 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
3485
33d63ff4
GM
34862012-07-13 Glenn Morris <rgm@gnu.org>
3487
5b633342
GM
3488 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
3489
33d63ff4
GM
3490 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
3491 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
3492
b55b9f85
JD
34932012-07-13 Jan Djärv <jan.h.d@swipnet.se>
3494
0dc8cf50
JD
3495 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
3496 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
3497 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
3498 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
3499 where appropriate.
3500 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
3501 as boolean expression.
3502 (x_set_window_size): Remove unused variable toolbar.
3503 (ns_get_color_default, ns_mod_to_lisp): Remove.
3504 (ns_mouse_position): Remove unused variables xchar and ychar.
3505 (ns_compute_glyph_string_overhangs): Remove unused variable face.
3506 (ns_set_vertical_scroll_bar): Remove unused variable count.
3507 (ns_delete_terminal): Remove unused variable i.
3508 (ns_term_init): Remove unused variables r, g and b.
3509 (mouseDown): Remove unused variable window.
3510 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
3511 (initFrameFromEmacs): Remove unused variable vbextra.
3512 (mouseEntered): Remove unused variables p and dpyinfo.
3513 (mouseExited): Remove unused variables p and r.
3514 (ns_define_frame_cursor, ns_clear_frame_area)
3515 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
3516 (menuDown): Assign [sender tag] to variable and cast the variable.
3517
3518 * nsterm.h (menuDown): Add id as type to argument sender.
3519 (ns_display_info_for_name): Add Lisp_Object argument.
3520 (ns_term_init): Add Lisp_Object argument.
3521 (ns_map_event_to_object): Add void argument.
3522 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
3523 prototype with arguments and only declare if __OBJC__.
3524 (nxatoms_of_nsselect): Add void argument.
3525 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
3526 (ns_alloc_autorelease_pool): Add void argument.
3527 (ns_release_autorelease_pool): Add void* argument.
3528 (ns_get_defaults_value): Add const char* argument.
3529
3530 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
3531 (initFromContents): Use SSDATA where appropriate.
3532 (ns_update_menubar): Add braces to ambigous if-else.
3533 (initWithTitle): Put () around assignment in if statement.
3534 (ns_menu_show): Remove unused variables window and keymap.
3535 (update_frame_tool_bar): Remove unused variable selected_p.
3536 (initWithContentRect): Remove unused variable this_cmd_name.
3537
3538 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
3539 appropriate.
3540 (setXBMColor): Remove unused variable len.
3541 (setPixmapData): Put () around assignment in loop statement.
3542
3543 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
3544 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
3545 where appropriate.
3546 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
3547 around assignment in loop statement.
3548 (nsfont_open): Remove unused variable i.
3549 (nsfont_open): Remove unused variable len.
3550 (nsfont_draw): Remove unused variable cs.
3551
3552 * nsfns.m (x_set_icon_name, ns_set_name_internal)
3553 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
3554 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
3555 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
3556 (Fns_font_name, Fns_perform_service)
3557 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
3558 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
3559 (ns_set_name): Remove unused variable view.
3560 (x_set_menu_bar_lines): Remove unused variable olines.
3561 (x_set_tool_bar_lines): Remove unused variable root_window.
3562 (Fns_list_colors): Put () around assignment in while statement.
3563 (Fns_perform_service): Remove unused variable len.
3564 (Fns_display_usable_bounds): Remove unused variable top.
3565 (syms_of_nsfns): Remove unused variable i.
3566
b55b9f85
JD
3567 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
3568 memcpy (Bug#11907).
3569
ed9265fc 35702012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
3571
3572 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
3573 and free it with DestroyExceptionInfo (Bug#11558).
3574
ef099b57
JB
35752012-07-13 Juanma Barranquero <lekktu@gmail.com>
3576
3577 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
3578 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
3579 Set here, not in nt/config.nt.
3580
ea814a5d
EZ
35812012-07-13 Eli Zaretskii <eliz@gnu.org>
3582
3583 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
3584 cursor overflow into the last glyph on display line when the right
3585 fringe is off. (Bug#11832)
3586
1a952767
PE
35872012-07-13 Paul Eggert <eggert@cs.ucla.edu>
3588
3589 * xdisp.c (produce_special_glyphs): Now static.
3590 * dispextern.h (produce_special_glyphs): Remove decl.
3591
983188fd
GM
35922012-07-13 Glenn Morris <rgm@gnu.org>
3593
8d7c7eed 3594 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
3595 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
3596
983188fd
GM
3597 * s/usg5-4-common.h (USG, USG5):
3598 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
3599 * s/sol2-6.h (SOLARIS2):
3600 * s/irix6-5.h (IRIX6_5):
3601 * s/hpux10-20.h (USG, USG5, HPUX):
3602 * s/gnu-linux.h (USG, GNU_LINUX):
3603 * s/freebsd.h (BSD_SYSTEM):
3604 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
3605 * s/cygwin.h (CYGWIN):
3606 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
3607 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
3608
d1e68667 36092012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
3610
3611 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 3612
6de0e799
GM
36132012-07-13 Glenn Morris <rgm@gnu.org>
3614
739ae010
GM
3615 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
3616
dbee5793
GM
3617 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
3618
6de0e799
GM
3619 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
3620 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
3621
b82da769
GM
36222012-07-12 Glenn Morris <rgm@gnu.org>
3623
4fae5a7a 3624 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
3625
3626 * process.c (init_process_emacs): Rename from init_process.
3627 The old name is also the name of a Mach system call.
3628 * lisp.h, emacs.c: Update for this name change.
3629 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
3630 longer needed.
3631
5a979817
EZ
36322012-07-12 Eli Zaretskii <eliz@gnu.org>
3633
3634 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
3635 memmove call that removes glyphs covered by the left truncation
3636 glyph. Improve commentary.
3637 (display_line): Fix display of continuation glyphs on GUI frames
3638 when the right fringe is turned off and variable-size fonts are
3639 used in the window. Move the code that appends a stretch glyph to
3640 produce_special_glyphs, so that it could be used for truncation
3641 and continuation glyphs alike.
3642 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
3643 glyph of a suitably computed width, to align the special glyphs at
3644 the window margin. Code moved from display_line. (Bug#11832)
3645
3e91a053
GM
36462012-07-12 Glenn Morris <rgm@gnu.org>
3647
ba9e4b84
GM
3648 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
3649
3650 * s/gnu-linux.h, s/hpux10-20.h:
3651 Do not unconditionally define HAVE_XRMSETDATABASE.
3652
3e91a053
GM
3653 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
3654
b300b1f4
PE
36552012-07-12 Paul Eggert <eggert@cs.ucla.edu>
3656
3657 Fix typos that broke OS X build.
3658 Reported by Randal L. Schwartz in
3659 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
3660 * nsterm.m (ns_timeout): Add missing local decl.
3661 (ns_get_color): snprintf -> sprintf, to fix typo.
3662
6e777848
GM
36632012-07-12 Glenn Morris <rgm@gnu.org>
3664
3f922c37
GM
3665 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
3666 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
3667 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
3668 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
3669
0ab7b23a
GM
3670 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
3671 Move PTY_OPEN to configure.
3672
6e777848
GM
3673 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3674 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
3675 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
3676
4a7edc24
DA
36772012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
3678
3679 Use empty_unibyte_string where applicable.
3680 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
3681 * lread.c (read1): Likewise.
3682 * xsettings.c (syms_of_xsettings): Likewise.
3683
308aab79
GM
36842012-07-12 Glenn Morris <rgm@gnu.org>
3685
42bd1719
GM
3686 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
3687 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
3688 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
3689 * s/hpux10-20.h (RUN_TIME_REMAP):
3690 * s/bsd-common.h (TABDLY): Move to configure.
3691
3692 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
3693
3694 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
3695
ea0bbd17 3696 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 3697 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
3698
3699 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 3700
308aab79
GM
3701 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
3702 * s/template.h: Move NARROWPROTO to configure.
3703
ee1cf5cf
GM
37042012-07-11 Glenn Morris <rgm@gnu.org>
3705
30fe9bf4
GM
3706 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
3707 unused since 2011-01-17 change to systty.h.
3708
ee1cf5cf
GM
3709 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
3710 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
3711 Move HAVE_PTYS and HAVE_SOCKETS to configure.
3712
63e47e07
PE
37132012-07-11 Paul Eggert <eggert@cs.ucla.edu>
3714
3715 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
3716
c43fb4c3
GM
37172012-07-11 Glenn Morris <rgm@gnu.org>
3718
3719 * s/darwin.h, s/gnu-linux.h, s/template.h:
3720 Move INTERRUPT_INPUT to configure.
3721
e8df9267
DA
37222012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3723
3724 Minor adjustments to interning code.
3725 * lisp.h (intern, intern_c_string): Redefine as static inline
3726 wrappers for intern_1 and intern_c_string_1, respectively.
3727 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
3728 * lread.c (intern_1, intern_c_string_1, oblookup):
3729 Simplify Vobarray checking.
e8df9267
DA
3730 * font.c (font_intern_prop): Likewise. Adjust comment.
3731 * w32font.c (intern_font_name): Likewise.
3732
34348bd4
AS
37332012-07-11 Andreas Schwab <schwab@linux-m68k.org>
3734
d96a1e0c
AS
3735 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
3736
34348bd4
AS
3737 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
3738 of Fcar/Fcdr if possible.
3739 * font.c (check_otf_features): Likewise.
3740 * fontset.c (Fnew_fontset): Likewise.
3741 * gnutls.c (Fgnutls_boot): Likewise.
3742 * minibuf.c (read_minibuf): Likewise.
3743 * msdos.c (IT_set_frame_parameters): Likewise.
3744 * xmenu.c (Fx_popup_dialog): Likewise.
3745 * w32menu.c (Fx_popup_dialog): Likewise.
3746
c8add24e
GM
37472012-07-11 Glenn Morris <rgm@gnu.org>
3748
4b575b3c
GM
3749 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
3750 since nothing has defined it on these platforms.
3751
09f4e3b0
GM
3752 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
3753 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
3754
172bedef
GM
3755 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3756 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
3757 Move CLASH_DETECTION to configure.
3758
249685df
GM
3759 * s/gnu.h: Remove file, which is now empty.
3760
c8add24e
GM
3761 * s/gnu.h, s/gnu-linux.h:
3762 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
3763
b41253a3
JW
37642012-07-11 John Wiegley <johnw@newartisans.com>
3765
3766 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
3767 function attribute, so we only use it if it exists in the
3768 compiler.
3769
d923b542
DA
37702012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3771
3772 Avoid call to strlen in fast_c_string_match_ignore_case.
3773 * search.c (fast_c_string_match_ignore_case): Change to use
3774 length argument. Adjust users accordingly.
3775 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
3776
5ebbef1d
PE
37772012-07-11 Paul Eggert <eggert@cs.ucla.edu>
3778
bb352260
PE
3779 Assume mkdir, rmdir.
3780 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
3781 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
3782
57054ddd
PE
3783 Assume rename.
3784 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
3785
b747d3f7
PE
3786 Assume perror.
3787 * s/hpux10-20.h (HAVE_PERROR): Remove.
3788 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
3789 Remove dummy definition, as this problem was obsolete long ago.
3790
5ebbef1d
PE
3791 Assume strerror.
3792 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
3793
984e7f30
DA
37942012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
3795
3796 Avoid calls to strlen in font processing functions.
3797 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
3798 (font_open_by_name): Change to use length argument.
3799 Adjust users accordingly.
d923b542
DA
3800 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
3801 Adjust prototypes.
3802 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
3803 Change to return ptrdiff_t.
984e7f30
DA
3804 (xfont_list_pattern, xfont_match): Use length returned by
3805 xfont_decode_coding_xlfd.
3806 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
3807
20e94fdd
GM
38082012-07-11 Glenn Morris <rgm@gnu.org>
3809
9d596af3
GM
3810 * s/darwin.h, s/freebsd.h, s/netbsd.h:
3811 Move DONT_REOPEN_PTY to configure.
3812
20e94fdd
GM
3813 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
3814 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
3815
e99a530f
PE
38162012-07-10 Paul Eggert <eggert@cs.ucla.edu>
3817
22ffb973
PE
3818 Remove "#define unix" that is no longer needed (Bug#11905).
3819 * s/aix4-2.h (unix): Remove; no longer needed.
3820
e9a9ae03
PE
3821 EMACS_TIME simplification (Bug#11875).
3822 This replaces macros (which typically do not work in GDB)
3823 with functions, typedefs and enums, making the code easier to debug.
3824 The functional style also makes code easier to read and maintain.
3825 * systime.h: Include <sys/time.h> on all hosts, not just if
3826 WINDOWSNT, since 'struct timeval' is needed in general.
3827 (EMACS_TIME): Now a typedef, not a macro.
3828 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
3829 not macros.
3830 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
3831 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
3832 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
3833 (EMACS_TIME_LE): Now functions, not macros.
3834 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
3835 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
3836 which are not functions. All uses rewritten to use:
3837 (make_emacs_time): New function.
3838 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
3839 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
3840 not functions. All uses rewritten to use the following, respectively:
3841 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
3842 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 3843 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
3844 * fileio.c (Fcopy_file):
3845 * xterm.c (XTflash): Get the current time closer to when it's used.
3846 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
3847
ffacb126
PE
3848 * bytecode.c (targets): Suppress -Woverride-init warnings.
3849
e99a530f
PE
3850 Simplify by avoiding confusing use of strncpy etc.
3851 * doc.c (Fsnarf_documentation):
3852 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
3853 * frame.c (Fmake_terminal_frame):
3854 * gtkutil.c (get_utf8_string):
3855 * lread.c (openp):
3856 * nsmenu.m (ns_update_menubar):
3857 * regex.c (regerror):
3858 Prefer memcpy to strncpy and strncat when either will do.
3859 * fileio.c (Fsubstitute_in_file_name):
3860 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
3861 (menu_separator_name_p):
3862 * nsmenu.m (ns_update_menubar):
3863 Prefer memcmp to strncmp when either will do.
3864 * nsterm.m: Include <ftoastr.h>.
3865 (ns_get_color):
3866 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
3867 Prefer snprintf to strncpy.
3868 * nsterm.m (ns_term_init):
3869 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
3870 * nsterm.m (ns_term_init):
3871 Avoid the need for strncpy, by using build_string or
3872 make_unibyte_string directly. Use dtoastr, not snprintf.
3873 * process.c (Fmake_network_process): Diagnose service names that
3874 are too long, rather than silently truncating them or creating
3875 non-null-terminated names.
3876 (Fnetwork_interface_info): Likewise, for interface names.
3877 * sysdep.c (system_process_attributes) [GNU_LINUX]:
3878 Prefer sprintf to strncat.
3879 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
3880 Prefer vsnprintf to vsprintf + strncpy.
3881
c59592b3
GM
38822012-07-10 Glenn Morris <rgm@gnu.org>
3883
3884 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
3885 Clarify fallback case.
3886
7d7bbefd
DA
38872012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3888
3889 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
3890 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
3891 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 3892 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
3893 where argument type is known to be a Lisp_Cons.
3894
3a4c8000
TT
38952012-07-10 Tom Tromey <tromey@redhat.com>
3896
3897 * bytecode.c (BYTE_CODE_THREADED): New macro.
3898 (BYTE_CODES): New macro. Replaces all old byte-code defines.
3899 (enum byte_code_op): New type.
3900 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
3901 (exec_byte_code): Use them. Use token threading when applicable.
3902
2a0213a6
DA
39032012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3904
3905 Optimize pure C strings initialization.
3906 * lisp.h (make_pure_string): Fix prototype.
3907 (build_pure_c_string): New function, defined as static inline. This
3908 provides a better opportunity to optimize away calls to strlen when
3909 the function is called with compile-time constant argument.
3910 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
3911 argument, adjust users accordingly. Use build_pure_c_string where
3912 appropriate.
3913 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
3914 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
3915 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
3916
cb1caeaf
DA
39172012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3918
3919 Avoid calls to strlen in miscellaneous functions.
3920 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
3921 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
3922 * lread.c (openp): Likewise.
3923
c293e30c
DA
39242012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3925
3926 Avoid calls to strlen in path processing functions.
3927 * fileio.c (file_name_as_directory): Add comment. Change to add
3928 srclen argument and return the length of result. Adjust users
3929 accordingly.
3930 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
3931 swap 1st and 2nd arguments to obey the common convention.
3932 Adjust users accordingly.
c293e30c
DA
3933 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
3934
9e059e3f
GM
39352012-07-10 Glenn Morris <rgm@gnu.org>
3936
d02eb359
GM
3937 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
3938 Move PENDING_OUTPUT_COUNT definition to configure.
3939
882cf227
GM
3940 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
3941 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
3942 * s/gnu.h (DATA_START): Move definitions to configure.
3943
af6e839f
GM
3944 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
3945 We include usg5-4-common.h, which defines them both.
3946
40289a12
GM
3947 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
3948 O_RDONLY already includes it).
3949
9e059e3f
GM
3950 Stop ns builds setting the EMACSLOADPATH environment variable.
3951 * nsterm.m (ns_load_path): Rename from ns_init_paths.
3952 Now it does not set EMACSLOADPATH, just returns the load-path string.
3953 * nsterm.h: Update accordingly.
3954 * lread.c [HAVE_NS]: Include nsterm.h.
3955 (init_lread) [HAVE_NS]: Use ns_load_path.
3956 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
3957
7c4e8ec0
GM
39582012-07-09 Glenn Morris <rgm@gnu.org>
3959
d4f600ff
GM
3960 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
3961 since the included bsd-common.h does so.
3962
cbb31951
GM
3963 Stop ns builds setting the EMACSPATH environment variable.
3964 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
3965 (ns_init_paths): Do not set EMACSPATH.
3966 * nsterm.h (ns_exec_path): Add it.
3967 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
3968 Use ns_exec_path.
3969
7c4e8ec0
GM
3970 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
3971
26bccfae
PE
39722012-07-09 Paul Eggert <eggert@cs.ucla.edu>
3973
a0bee46f
PE
3974 * process.c (wait_reading_process_output): 'waitchannels' was unset
3975 when read_kbd || !NILP (wait_for_cell); fix this.
3976
5994c183
PE
3977 Add GCC-style 'const' attribute to functions that can use it.
3978 * character.h (char_resolve_modifier_mask):
3979 * keyboard.h (make_ctrl_char):
3980 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
3981 (init_character_once, next_almost_prime, init_fns, init_image)
3982 (flush_pending_output, init_sound):
3983 * mem-limits.h (start_of_data):
3984 * menu.h (finish_menu_items):
3985 Add ATTRIBUTE_CONST.
3986 * emacs.c (DEFINE_DUMMY_FUNCTION):
3987 Declare the dummy function with ATTRIBUTE_CONST.
3988 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
3989 Add decls with ATTRIBUTE_CONST.
3990
26bccfae
PE
3991 Minor improvements to make_formatted_string.
3992 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
3993 where int is good enough, as vsprintf returns an int.
3994 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
3995
a8290ec3
DA
39962012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3997
3998 Use make_formatted_string to avoid double length calculation.
3999 * lisp.h (make_formatted_string): New prototype.
4000 * alloc.c (make_formatted_string): New function.
4001 * buffer.c (Fgenerate_new_buffer_name): Use it.
4002 * dbus.c (syms_of_dbusbind): Likewise.
4003 * editfns.c (Fcurrent_time_zone): Likewise.
4004 * filelock.c (get_boot_time): Likewise.
4005 * frame.c (make_terminal_frame, set_term_frame_name)
4006 (x_report_frame_params): Likewise.
4007 * image.c (gs_load): Likewise.
4008 * minibuf.c (get_minibuffer): Likewise.
4009 * msdos.c (dos_set_window_size): Likewise.
4010 * process.c (make_process): Likewise.
4011 * xdisp.c (ensure_echo_area_buffers): Likewise.
4012 * xsettings.c (apply_xft_settings): Likewise.
4013
d01ba2f1
GM
40142012-07-09 Glenn Morris <rgm@gnu.org>
4015
4016 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
4017 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
4018 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
4019 * nsterm.h (ns_etc_directory): Add it.
4020 * callproc.c [HAVE_NS]: Include nsterm.h.
4021 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
4022
f1f924b6
DA
40232012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4024
4025 Move marker debugging code under MARKER_DEBUG.
4026 * marker.c (MARKER_DEBUG): Move marker debugging code under
4027 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
4028 for bootstrap with --enable-checking (~3x slowdown reported
4029 by Juanma Barranquero <lekktu@gmail.com>).
4030 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
4031
ab531b66
PE
40322012-07-08 Paul Eggert <eggert@cs.ucla.edu>
4033
4034 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
4035 See <http://bugs.gnu.org/11825#29>.
4036
c4b3bc8a
EZ
40372012-07-08 Eli Zaretskii <eliz@gnu.org>
4038
4039 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
4040 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
4041 (display_line): Add commentary about displaying truncation glyphs
4042 on GUI frames.
4043 (produce_special_glyphs): Move here from term.c.
4044
4045 * term.c (produce_special_glyphs): Move to xdisp.c.
4046
4047 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
4048 section.
c4b3bc8a 4049
b676b881
AS
40502012-07-07 Andreas Schwab <schwab@linux-m68k.org>
4051
f17c5273
AS
4052 * xdisp.c (display_line): Avoid warning about implicit declaration
4053 of FRAME_FONT.
4054
298819b9
AS
4055 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
4056
b676b881
AS
4057 * lisp.h: Remove empty conditional.
4058
6045c4fd
PE
40592012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4060
b3350bf9
PE
4061 * lread.c (load_path_check): Now static.
4062
6045c4fd
PE
4063 Fix some minor --with-ns problems found by static checking.
4064 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
4065 (x_set_font) [!HAVE_X_WINDOWS]:
4066 * image.c (xpm_load_image) [HAVE_NS]:
4067 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
4068 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
4069 Remove unused local.
4070 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
4071 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
4072 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
4073 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
4074 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
4075 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
4076 Fix pointer signedness problem.
4077 * xfaces.c (FRAME_X_FONT_TABLE):
4078 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
4079
929e7845
GM
40802012-07-07 Glenn Morris <rgm@gnu.org>
4081
4082 * lread.c (load_path_check): New function, split from init_lread.
4083 (init_lread): Reorganize. Motivation:
4084 If EMACSLOADPATH is set, check/warn about that rather than the
4085 defaults, which we are not going to use. Hence we can remove
4086 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
4087 Don't warn if site-lisp directories are missing.
4088 If not installed, start from a blank load-path, since
4089 PATH_LOADSEARCH refers to the eventual installation directories.
4090
58dd0aa4
EZ
40912012-07-07 Eli Zaretskii <eliz@gnu.org>
4092
4093 Support truncation and continuation glyphs on GUI frames, when
4094 fringes are disabled. (Bug#11832)
4095 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
4096 continuation glyphs even if on GUI frames.
4097 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
4098 or both, are absent.
4099 (start_display, move_it_in_display_line_to): Handle the case of a
4100 GUI frame without a fringe to display continuation or truncation
4101 glyphs.
4102 (insert_left_trunc_glyphs): Support GUI frames: make sure
4103 truncation glyphs overwrite enough glyphs from the current line to
4104 have sufficient space in pixels.
4105 (display_line): Support truncation and continuation glyphs on GUI
4106 frames. If some spare pixels are left on the line after inserting
4107 the truncation glyphs, fill that space with a stretch glyph of a
4108 suitably computed width.
4109
4110 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
4111 produce_glyphs, to support GUI sessions.
4112
31571fd7
PE
41132012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4114
5a16b9bc
PE
4115 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
4116
f3047c75
PE
4117 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
4118
31571fd7
PE
4119 Do not require float-time's arg to fit in time_t (Bug#11825).
4120 This works better on hosts where time_t is unsigned, and where
4121 float-time is applied to the (negative) difference between two times.
4122 * editfns.c (decode_time_components): Last arg is now double *,
4123 not int *, and means to store all the result as a double, without
4124 worrying about whether the seconds part fits in time_t.
4125 All callers changed.
4126 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
4127 All callers changed.
4128 (Ffloat_time): Do not fail merely because the specified time falls
4129 outside of time_t range.
4130
4516fbef
GM
41312012-07-07 Glenn Morris <rgm@gnu.org>
4132
4133 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
4134 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
4135 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
4136
07adc2c6
JB
41372012-07-07 Juanma Barranquero <lekktu@gmail.com>
4138
4139 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
4140 Update dependencies.
4141
4142 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
4143
fd573f31
PE
41442012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4145
fee5959d
PE
4146 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
4147 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
4148 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
4149 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
4150 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
4151 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
4152
fd573f31
PE
4153 * xfont.c (compare_font_names): Redo to omit the need for casts.
4154
ddadbc0e
AS
41552012-07-06 Andreas Schwab <schwab@linux-m68k.org>
4156
fca8d6b6
AS
4157 * xfns.c (Fx_change_window_property): Doc fix.
4158 * w32fns.c (Fx_change_window_property): Doc fix.
4159
ddadbc0e
AS
4160 * w32fns.c (Fx_window_property): Accept the same arguments as the
4161 X Windows version. Doc fix.
4162 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
4163
ed9265fc 41642012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
4165 Eli Zaretskii <eliz@gnu.org>
4166
4167 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
4168 Windows-specific code from nt/config.nt moved here.
4169 Obsolete settings removed.
4170
216ee680
PE
41712012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4172
4173 * process.c: Avoid unnecessary calls to gettime.
4174 (wait_reading_process_output): Don't get the time of day
4175 when gobbling data immediately and not waiting, as there's no need
4176 for it in that case. This removes a FIXME.
4177
bdd091e4
JD
41782012-07-06 Jan Djärv <jan.h.d@swipnet.se>
4179
4180 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
4181 is defined (Bug#11768).
4182
9d44f8ce
DA
41832012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4184
4185 Fix marker debugging code.
4186 * marker.c (byte_char_debug_check): Do not perform the check
4187 if buffer is not multibyte.
090bd7cb
JB
4188 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4189 Call byte_char_debug_check with correct arguments.
9d44f8ce 4190
90fc4786
DA
41912012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4192
4193 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
4194 * marker.c (byte_char_debug_check, count_markers):
4195 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
4196 (byte_debug_flag): Remove.
4197 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4198 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
4199
7b7ae965
DA
42002012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4201
4e57b342
DA
4202 Avoid code repetition in marker-related functions.
4203 * marker.c (attach_marker): New function.
4204 (Fset_marker, set_marker_restricted, set_marker_both)
4205 (set_marker_restricted_both): Use it.
4206 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
4207 Consistently rename charno to charpos.
4208 (marker_position): Add eassert.
4209 (marker_byte_position): Convert to eassert.
4210
42112012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4212
4213 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 4214 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 4215 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 4216
657924ff
DA
42172012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4218
4219 Introduce fast path for the widely used marker operation.
4220 * alloc.c (build_marker): New function.
4221 * lisp.h (build_marker): New prototype.
4222 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
4223 * composite.c (autocmp_chars): Likewise.
4224 * editfns.c (buildmark): Remove.
4225 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
4226 (save_restriction_save): Use build_marker.
4227 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
4228 * window.c (save_window_save): Likewise.
4229
041a49a6
DA
42302012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4231
4232 Do not use Fdelete_overlay in delete_all_overlays
4233 to avoid redundant calls to unchain_overlay.
4234 * buffer.c (drop_overlay): New function.
4235 (delete_all_overlays, Fdelete_overlay): Use it.
4236 * minibuf.c (get_minibuffer): Fix comment.
4237
7dca65a4
PE
42382012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4239
4240 Port to OpenBSD 5.1 amd64.
4241 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
4242 This is needed for OpenBSD, and should be harmless on all BSD systems.
4243 Also, include <sys/sysctl.h>, as it should be available on all
4244 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
4245 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
4246 use p_pid member, not kp_proc.pid.
4247
8eb876e2
GM
42482012-07-06 Glenn Morris <rgm@gnu.org>
4249
4250 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
4251
38182d90
PE
42522012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4253
4254 More xmalloc and related cleanup.
4255 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
4256 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
4257 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
4258 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
4259 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
4260 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
4261 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
4262 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
4263 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
4264 * xterm.c:
4265 Omit needless casts involving void * pointers and allocation.
4266 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
4267 as the former is more robust if P's type is changed.
4268 Prefer xzalloc to xmalloc + memset 0.
4269 Simplify malloc-or-realloc to realloc.
4270 Don't worry about xmalloc returning a null pointer.
4271 Prefer xstrdup to xmalloc + strcpy.
4272 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
4273 growing it.
4274 * keyboard.c (apply_modifiers_uncached): Prefer local array to
4275 alloca of a constant.
4276
6dd5a677
EZ
42772012-07-05 Eli Zaretskii <eliz@gnu.org>
4278
4279 * xdisp.c (display_line): Fix horizontal pixel coordinates when
4280 hscroll is larger than the line width. Fixes long and futile
4281 looping inside extend_face_to_end_of_line (on a TTY) producing
4282 glyphs that are not needed and thrown away.
4283
6b312f0f
DA
42842012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
4285
4286 * marker.c (set_marker_restricted_both): Simplify by using
4287 clip_to_bounds.
4288
f520ef9b
PE
42892012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4290
4291 * editfns.c (region_limit): Simplify by using clip_to_bounds.
4292
383b7c95
JD
42932012-07-05 Jan Djärv <jan.h.d@swipnet.se>
4294
4295 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
4296 not defined (Bug#11768).
4297 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
4298 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
4299 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
4300 followed by gtk_box_set_homogeneous (Bug#11768).
4301 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
4302 (update_theme_scrollbar_width, xg_create_scroll_bar):
4303 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
4304 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
4305 (is_box_type): New function (Bug#11768).
4306 (xg_tool_item_stale_p): Call is_box_type.
5293d758 4307 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
4308 with default display (Bug#11768).
4309
d6e7bf45
EZ
43102012-07-05 Eli Zaretskii <eliz@gnu.org>
4311
4312 * xdisp.c (window_hscroll_limited): New function.
4313 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
4314 coordinates when window's hscroll is set to insanely large
4315 values. (Bug#11857)
4316
431391ec
JB
43172012-07-05 Juanma Barranquero <lekktu@gmail.com>
4318
4319 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
4320 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
4321
23f86fce
DA
43222012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
4323
4324 Cleanup xmalloc.
4325 * lisp.h (xzalloc): New prototype. Omit needless casts.
4326 * alloc.c (xzalloc): New function. Omit needless casts.
4327 * charset.c: Omit needless casts. Convert all calls to
4328 xmalloc with following memset to xzalloc.
4329 * dispnew.c: Likewise.
4330 * fringe.c: Likewise.
4331 * image.c: Likewise.
4332 * sound.c: Likewise.
4333 * term.c: Likewise.
4334 * w32fns.c: Likewise.
4335 * w32font.c: Likewise.
4336 * w32term.c: Likewise.
4337 * xfaces.c: Likewise.
4338 * xfns.c: Likewise.
4339 * xterm.c: Likewise.
4340 * atimer.c: Omit needless casts.
4341 * buffer.c: Likewise.
4342 * callproc.c: Likewise.
4343 * ccl.c: Likewise.
4344 * coding.c: Likewise.
4345 * composite.c: Likewise.
4346 * doc.c: Likewise.
4347 * doprnt.c: Likewise.
4348 * editfns.c: Likewise.
4349 * emacs.c: Likewise.
4350 * eval.c: Likewise.
4351 * filelock.c: Likewise.
4352 * fns.c: Likewise.
4353 * gtkutil.c: Likewise.
4354 * keyboard.c: Likewise.
4355 * lisp.h: Likewise.
4356 * lread.c: Likewise.
4357 * minibuf.c: Likewise.
4358 * msdos.c: Likewise.
4359 * print.c: Likewise.
4360 * process.c: Likewise.
4361 * region-cache.c: Likewise.
4362 * search.c: Likewise.
4363 * sysdep.c: Likewise.
4364 * termcap.c: Likewise.
4365 * terminal.c: Likewise.
4366 * tparam.c: Likewise.
4367 * w16select.c: Likewise.
4368 * w32.c: Likewise.
4369 * w32reg.c: Likewise.
4370 * w32select.c: Likewise.
4371 * w32uniscribe.c: Likewise.
4372 * widget.c: Likewise.
4373 * xdisp.c: Likewise.
4374 * xmenu.c: Likewise.
4375 * xrdb.c: Likewise.
4376 * xselect.c: Likewise.
4377
0497dc44
PE
43782012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4379
4380 * fileio.c (time_error_value): Check the right error number.
4381 Problem reported by Troels Nielsen in
4382 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
4383
356e7178
PE
43842012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4385
4e71fd89
PE
4386 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
4387 This should be fixed in a better way; see Eli Zaretskii in
4388 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
4389 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
4390
f0941253
PE
4391 * fileio.c (time_error_value): Rename from special_mtime.
4392 The old name's problems were noted by Eli Zaretskii in
4393 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
4394
065c9eb4
PE
4395 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
4396 This variable's comment says Emacs needs at least one GDB-visible
4397 symbol of type enum pvec_type, to work around GDB problems.
4398 The symbol's value doesn't matter.
4399
356e7178
PE
4400 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
4401 that causes compilation to fail on pre-C99 compilers.
4402
ed9265fc 44032012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
4404
4405 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
4406 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
4407
3884d954
DA
44082012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4409
d209e2fb 4410 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
4411 headers for buffer_defaults and buffer_local_symbols.
4412 Reported by Juanma Barranquero <lekktu@gmail.com>.
4413
ee28be33
SM
44142012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4415
4416 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
4417 * lisp.h (enum pvec_type): Use fewer bits.
4418 (PSEUDOVECTOR_SIZE_BITS): New constant.
4419 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
4420 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
4421 change in pvec_type.
4422 (PSEUDOVECTOR_TYPEP): New macro.
4423 (TYPED_PSEUDOVECTORP): Use it.
4424 * fns.c (internal_equal): Adapt code to extract pvectype.
4425 * emacs.c (gdb_pvec_type): Update type.
4426 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
4427 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
4428 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
4429 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
4430 (sweep_vectors): Use it. Use local var `total_bytes' instead of
4431 abusing vector->header.next.nbytes.
4432 (live_vector_p): Use PVEC_TYPE.
4433 (mark_object): Adapt code to extract pvectype. Use switch.
4434
c7f2cd7f
PE
44352012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4436
4437 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
4438 Tighten new eassert a bit.
4439
8ce70ed2
DA
44402012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4441
4442 Fix compilation with --enable-gcc-warnings and -O1
4443 optimization level.
4444 * doprnt.c (doprnt): Change type of tem to int, initialize
4445 to avoid compiler warning. Add eassert.
4446 * search.c (simple_search): Initialize match_byte to avoid
4447 compiler warning. Add eassert.
4448
dea7f1e5
PE
44492012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4450
24a212eb
PE
4451 Avoid weird behavior with large horizontal scrolls.
4452 Without this change, for example, large hscroll values would
4453 mess up Emacs's display on Fedora 15 x86, presumably due to
4454 overflows in int calculations in the display code.
4455 Also, if buffers had long lines, Emacs would freeze.
4456 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
4457 (set_window_hscroll): New function, containing the old guts of
4458 Fset_window_hscroll. Return the clipped value.
4459 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
4460 This avoids the need to check against PTRDIFF_MAX.
4461
dea7f1e5
PE
4462 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
4463
76046526
DA
44642012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
4465
4466 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
4467
39adff0d
PE
44682012-07-04 Paul Eggert <eggert@cs.ucla.edu>
4469
63807d47
PE
4470 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
4471 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
4472 since GCC 4.4.6 issues a bogus warning for them.
4473
39adff0d
PE
4474 Fix bugs in file timestamp newness comparisons.
4475 * fileio.c (Ffile_newer_than_file_p):
4476 * lread.c (Fload): Use full timestamp resolution of files,
4477 not just the 1-second resolution, so that files that are only
4478 slightly newer still count as newer.
4479 * fileio.c (Ffile_newer_than_file_p): Don't assume file
4480 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
4481
dbeed9a6
PE
44822012-07-03 Paul Eggert <eggert@cs.ucla.edu>
4483
4484 * fileio.c: Improve handling of file time marker. (Bug#11852)
4485 (special_mtime): New function.
4486 (Finsert_file_contents, Fverify_visited_file_modtime):
4487 Use it to set special mtime values consistently.
4488
636334d6
AS
44892012-07-03 Andreas Schwab <schwab@linux-m68k.org>
4490
4491 * fileio.c (Finsert_file_contents): Properly handle st_mtime
4492 marker for non-existing file. (Bug#11852)
4493
e2017fe2
GM
44942012-07-03 Glenn Morris <rgm@gnu.org>
4495
4496 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
4497 and did not make it into globals.h).
4498
404dbd37
TT
44992012-07-03 Tom Tromey <tromey@redhat.com>
4500
4501 * window.c (Fset_window_margins, Fset_window_fringes)
4502 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
4503 * textprop.c (Fprevious_property_change): No longer static.
4504 * syntax.c (Fsyntax_table_p): No longer static.
4505 * process.c (Fget_process, Fprocess_datagram_address): No longer
4506 static.
4507 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
4508 * keyboard.c (Fcommand_execute): No longer static.
4509 Remove EXFUN.
4510 * insdel.c (Fcombine_after_change_execute): No longer static.
4511 * image.c (Finit_image_library): No longer static.
4512 * fileio.c (Fmake_symbolic_link): No longer static.
4513 * eval.c (Ffetch_bytecode): No longer static.
4514 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
4515 * doc.c (Fdocumentation_property, Fsnarf_documentation):
4516 No longer static.
404dbd37
TT
4517 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
4518 static.
4519 * dired.c (Ffile_attributes): No longer static.
4520 * composite.c (Fcomposition_get_gstring): No longer static.
4521 * callproc.c (Fgetenv_internal): No longer static.
4522
4523 * ccl.h: Remove EXFUNs.
4524 * buffer.h: Remove EXFUNs.
4525 * dispextern.h: Remove EXFUNs.
4526 * intervals.h: Remove EXFUNs.
4527 * fontset.h: Remove EXFUN.
4528 * font.h: Remove EXFUNs.
4529 * dosfns.c (system_process_attributes): Remove EXFUN.
4530 * keymap.h: Remove EXFUNs.
4531 * lisp.h: Remove EXFUNs.
4532 * w32term.h: Remove EXFUNs.
4533 * window.h: Remove EXFUNs.
4534 * xsettings.h: Remove EXFUN.
4535 * xterm.h: Remove EXFUN.
4536
8e4fd1e1
GM
45372012-07-03 Glenn Morris <rgm@gnu.org>
4538
4539 * lisp.h (Frandom): Make it visible to C.
4540 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
4541 buffer for invisible buffers. (Bug#1229)
4542
ca95b3eb
DA
45432012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4544
4545 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
4546 values which aren't power of 2.
14ae4239
BT
4547 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
4548 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
4549 accordingly.
4550
7555c33f
SM
45512012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
4552
4553 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
4554
4555 * alloc.c (mark_object): Revert part of last patch to use `switch'.
4556
d12e8f5a
DA
45572012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4558
4559 * alloc.c (allocate_vector_block): Remove redundant
4560 calls to mallopt if DOUG_LEA_MALLOC is defined.
4561 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
4562 avoid calls to mallopt if zero_vector is returned.
4563
296094c3
DA
45642012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4565
4566 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
4567 is enabled, avoid dereferencing NULL current_sblock if
4568 running undumped.
4569
36429c89
DA
45702012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
4571
4572 Cleanup basic buffer management.
4573 * buffer.h (struct buffer): Change layout to use generic vector
4574 marking code. Fix some comments. Change type of 'clip_changed'
4575 to bitfield. Remove unused #ifndef old.
4576 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
4577 (GET_OVERLAYS_AT): Fix indentation.
4578 (for_each_per_buffer_object_at): New macro.
4579 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
4580 (Fbuffer_local_variables): Use it.
4581 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
4582 * alloc.c (allocate_buffer): Adjust to match new layout of
4583 struct buffer. Fix comment.
4584 (mark_overlay): New function.
4585 (mark_buffer): Use it. Use mark_vectorlike to mark normal
4586 Lisp area of struct buffer.
4587 (mark_object): Use it. Adjust marking of misc objects
4588 and related comments.
4589
3b3e4cac
PE
45902012-07-02 Paul Eggert <eggert@cs.ucla.edu>
4591
4592 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
4593 wrapper that is not needed because the wrapped code is a no-op (zero
4594 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
4595 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
4596
cf5c0175
DA
45972012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
4598
4599 * alloc.c (mark_buffer): Simplify. Remove prototype.
4600 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 4601 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
4602 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
4603 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 4604
ca26824c
GM
46052012-06-30 Glenn Morris <rgm@gnu.org>
4606
2e4c5312
GM
4607 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
4608
ca26824c
GM
4609 * epaths.in (PATH_SITELOADSEARCH): New.
4610 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
4611 This is rather than relying on --enable-locallisppath elements
4612 having "site-lisp" in their names. (Bug#10208#25, 11658)
4613
0d23c240
EZ
46142012-06-30 Eli Zaretskii <eliz@gnu.org>
4615
c9240d7a
EZ
4616 * w32proc.c (sys_select): Accept and ignore one more argument.
4617
4618 * w32.c (emacs_gnutls_pull): Call select with one more argument.
4619
0d23c240 4620 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 4621 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
4622
4623 * sysdep.c: Don't include dos.h and dosfns.h.
4624
4625 * process.c (sys_select):
4626 * msdos.c (sys_select): Accept one more argument and ignore it.
4627
4628 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
4629 adapt data types and code to that.
4630
4631 * dosfns.c:
4632 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
4633 which clashes with the gnulib function of the same name.
4634
af5a5a98
AS
46352012-06-30 Andreas Schwab <schwab@linux-m68k.org>
4636
c5e4379c
AS
4637 * font.c (font_style_to_value, font_style_symbolic)
4638 (font_prop_validate_style): Add type checks for values in
4639 font_style_table.
4640
af5a5a98
AS
4641 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
4642 argument.
4643 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
4644 uses.
4645
8d38f461
EZ
46462012-06-29 Eli Zaretskii <eliz@gnu.org>
4647
2e5a6631
EZ
4648 * xdisp.c (try_window_id): Undo last change.
4649
8d38f461
EZ
4650 * w32.c (getwd): Adjust commentary about startup_dir.
4651 (init_environment): Always call sys_access, even in non-MSVC
4652 builds. Don't chdir to the directory of the Emacs executable.
4653 This undoes code from 1997 which was justified by the need to
4654 "avoid conflicts when removing and renaming directories". But its
4655 downside was that every relative file name was being interpreted
4656 relative to the directory of the Emacs executable, which can never
4657 be TRT. In particular, it broke sys_access when called with
4658 relative file names.
4659 (sys_access): Map GetLastError to errno.
4660
2af3565e
DA
46612012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4662
4663 * window.h (struct window): Change type of 'fringes_outside_margins'
4664 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 4665 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
4666 Adjust comment.
4667 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
4668 to ptrdiff_t.
4669
c8d3a25c 46702012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 4671
c8d3a25c
GM
4672 * gnutls.c (emacs_gnutls_handshake):
4673 Add QUIT to make the loop interruptible.
57570cd3 4674
c8d3a25c 46752012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 4676
c8d3a25c
GM
4677 * charset.c (init_charset): Make lack of etc/charsets fatal.
4678
3e984ee8
DA
46792012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4680
4681 * editfns.c (region_limit): Fix type mismatch.
4682
ef884f23
DA
46832012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
4684
4685 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
4686 undefined. Convert from xassert to eassert.
4687 * nsmenu.m: Convert from xassert to eassert.
4688 * nsterm.m: Likewise.
4689
7d7e0027
SM
46902012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
4691
4692 * editfns.c (region_limit): Clip to narrowing (bug#11770).
4693
aa754e6a
PE
46942012-06-28 Paul Eggert <eggert@cs.ucla.edu>
4695
4696 Avoid integer overflow on scroll-left and scroll-right.
4697 * window.c (HSCROLL_MAX): New macro.
4698 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
4699 overflow when requested scroll falls outside ptrdiff_t range.
4700
80b00b08
DA
47012012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4702
4703 * window.h (struct window): Change type of 'hscroll',
4704 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
4705 'last_modified' and 'last_overlay_modified' to EMACS_INT.
4706 Adjust users accordingly.
4707 * xdisp.c (try_cursor_movement): Replace type check with eassert.
4708 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
4709 from EMACS_INT to ptrdiff_t.
4710 (make_window): Omit redundant initialization.
4711
62b2bcf6
JB
47122012-06-28 Juanma Barranquero <lekktu@gmail.com>
4713
4714 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
4715
45942c7d
DA
47162012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4717
4718 * window.h (struct window): Change type of 'use_time' and
4719 'sequence_number' from Lisp_Object to int.
4720 * frame.c (make_frame): Adjust users accordingly.
4721 * print.c (print_object): Likewise.
4722 * window.c (select_window, Fwindow_use_time, make_parent_window)
4723 (make_window): Likewise.
4724
e509cfa6
DA
47252012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4726
4727 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
4728 enabled with --enable-checking=[all,glyphs] configure option.
4729 Fix GLYPH_DEBUG usage assuming that it may be undefined,
4730 adjust comments accordingly.
4731 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
4732 undefined, adjust comments accordingly.
4733 * image.c: Likewise.
4734 * scroll.c: Likewise.
4735 * w32fns.c: Likewise.
4736 * w32term.c: Likewise.
4737 * xdisp.c: Likewise.
4738 * xfaces.c: Likewise.
4739 * xfns.c: Likewise.
4740 * xterm.c: Likewise.
4741
a54e2c05
DA
47422012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
4743
4744 Generalize run-time debugging checks.
4745 * dispextern.h (XASSERTS): Remove.
4746 * fontset.c (xassert): Remove.
4747 Convert from xassert to eassert.
4748 * alloc.c: Convert from xassert to eassert.
4749 * bidi.c: Likewise.
4750 * dispnew.c: Likewise.
4751 * fns.c: Likewise.
4752 * fringe.c: Likewise.
4753 * ftfont.c: Likewise.
4754 * gtkutil.c: Likewise.
4755 * image.c: Likewise.
4756 * keyboard.c: Likewise.
4757 * menu.c: Likewise.
4758 * process.c: Likewise.
4759 * scroll.c: Likewise.
4760 * sound.c: Likewise.
4761 * term.c: Likewise.
4762 * w32console.c: Likewise.
4763 * w32fns.c: Likewise.
4764 * w32term.c: Likewise.
4765 * window.c: Likewise.
4766 * xdisp.c: Likewise.
4767 * xfaces.c: Likewise.
4768 * xfns.c: Likewise.
4769 * xselect.c: Likewise.
4770 * xterm.c: Likewise.
4771
1ec4b7b2
SM
47722012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
4773
4774 * fns.c (maybe_resize_hash_table): Output message when growing the
4775 purify-hashtable.
4776
2014308a
DA
47772012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4778
4779 * alloc.c (allocate_string_data): Remove dead code.
4780 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
4781 avoid GCC warning about unused macro.
4782
246155eb
DA
47832012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4784
4785 * alloc.c (allocate_string): Omit intervals initialization.
4786 * alloc.c (make_uninit_multibyte_string): Initialize intervals
4787 as in make_pure_string and make_pure_c_string.
4788
43184b7b
DA
47892012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4790
d209e2fb 4791 * alloc.c (allocate_string): Fix last change.
43184b7b 4792
3fe6dd74
DA
47932012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
4794
d209e2fb 4795 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
4796 to memset, add explicit initialization where appropriate.
4797
1ba6038a
GM
47982012-06-27 Glenn Morris <rgm@gnu.org>
4799
4800 * lisp.mk (lisp): Remove paths.elc.
4801
c89926a5
CY
48022012-06-27 Chong Yidong <cyd@gnu.org>
4803
4804 * doc.c (Fsubstitute_command_keys): Fix punctuation.
4805
ed6b3510
JW
48062012-06-26 John Wiegley <johnw@newartisans.com>
4807
1ec4b7b2 4808 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
4809 on Mac OS X Lion: __mod_init_func and __mod_term_func.
4810
ed6b3510
JW
4811 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
4812 when building with Clang.
4813
8edd4a2b
SM
48142012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
4815
4816 * eval.c (Fapply): Allow calling it with a single argument.
4817
f6f62d1b
EZ
48182012-06-26 Eli Zaretskii <eliz@gnu.org>
4819
4820 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
4821 _stricmp and _strnicmp.
4822 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
4823
62efea5e
DA
48242012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4825
4826 * alloc.c (allocate_window): Zero out non-Lisp part of newly
4827 allocated window.
4828 (allocate_process): Likewise for new process.
8edd4a2b 4829 (allocate_terminal): Change to use offsetof.
62efea5e
DA
4830 (allocate_frame): Likewise.
4831 * frame.c (make_frame): Omit redundant initialization.
4832 * window.c (make_parent_window): Use memset.
4833 (make_window): Omit redundant initialization.
4834 * process.c (make_process): Omit redundant initialization.
4835 * terminal.c (create_terminal): Likewise.
4836
42997f4d
DA
48372012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4838
4839 * term.c (delete_tty): Remove redundant call to memset.
4840
1130ecfc
DA
48412012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
4842
4843 * alloc.c: Remove build_string.
4844 * lisp.h: Define build_string as static inline. This provides
4845 a better opportunity to optimize away calls to strlen when the
4846 function is called with compile-time constant argument.
4847 * image.c (imagemagick_error): Convert to build_string.
4848 * w32proc.c (sys_spawnve): Likewise.
4849 * xterm.c (x_term_init): Likewise.
4850
cf38a720
PE
48512012-06-26 Paul Eggert <eggert@cs.ucla.edu>
4852
99027bdd
PE
4853 Use sprintf return value instead of invoking strlen on result.
4854 In the old days this wasn't portable, since some sprintf
4855 implementations returned char *. But they died out years ago and
4856 Emacs already assumes sprintf returns int.
4857 Similarly for float_to_string.
4858 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
4859 * ccl.c (ccl_driver):
4860 * character.c (string_escape_byte8):
4861 * data.c (Fnumber_to_string):
4862 * doprnt.c (doprnt):
4863 * print.c (print_object):
4864 * xdisp.c (message_dolog):
4865 * xfns.c (syms_of_xfns):
4866 Use sprintf or float_to_string result to avoid need to call strlen.
4867 * data.c (Fnumber_to_string):
4868 Use make_unibyte_string, since the string must be ASCII.
4869 * lisp.h, print.c (float_to_string): Now returns int length.
4870 * term.c (produce_glyphless_glyph):
4871 Use sprintf result rather than recomputing it.
4872
cf38a720
PE
4873 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
4874 * Makefile.in (ALL_CFLAGS):
4875 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
4876 * gmalloc.c, regex.c: Include <config.h> unconditionally.
4877
3511c784
DA
48782012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4879
0a08eb21 4880 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
4881 strcasecmp if available.
4882 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
4883
fb7da12e
AS
48842012-06-25 Andreas Schwab <schwab@linux-m68k.org>
4885
4886 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
4887 Avoid comma operator.
4888 * menu.c (push_submenu_start, push_submenu_end)
4889 (push_left_right_boundary, push_menu_pane): Likewise.
4890 * msdos.c (dos_rawgetc): Likewise.
4891
afa2ffd8
DA
48922012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4893
4894 * xfns.c (xic_create_fontsetname): Remove redundant calls
4895 to memset.
4896
b3b4476b
PE
48972012-06-25 Paul Eggert <eggert@cs.ucla.edu>
4898
4495ff38
PE
4899 * gtkutil.c (get_utf8_string): Remove redundant assignment.
4900 sprintf already null-terminates its output.
4901
b3b4476b
PE
4902 * xfns.c (x_window): Remove redundant cast.
4903
b00876c9
DA
49042012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4905
4906 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
4907 `const char *' to `char *' to avoid compiler warning.
4908
d188e26b
PE
49092012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4910
885d1d74
PE
4911 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
4912 instead of truncating it to 63 (admittedly a generous limit).
4913
d188e26b
PE
4914 * process.c: Fix spelling and caps in comments.
4915
e2f560b1
DN
49162012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
4917
e86db54b 4918 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
4919 * sysdep.c (setpgrp): Remove definition, not used in this file.
4920
7583a3a1
JB
49212012-06-24 Juanma Barranquero <lekktu@gmail.com>
4922
4923 * makefile.w32-in: Update dependencies.
4924
696056c2
EZ
49252012-06-24 Eli Zaretskii <eliz@gnu.org>
4926
4927 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
4928 (SYSTIME_H): Add nt/inc/sys/time.h.
4929
4930 * systime.h [WINDOWSNT]: Include sys/time.h.
4931
4932 * s/ms-w32.h (struct timespec): Definition moved from
4933 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
4934
845ca893
PE
49352012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4936
4937 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
4938 * buffer.h (buffer_slot_type_mismatch):
4939 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4940 * eval.c (unwind_to_catch):
4941 * image.c (my_png_error, my_error_exit):
4942 * keyboard.c (quit_throw_to_read_char, user_error)
4943 (Fexit_recursive_edit, Fabort_recursive_edit):
4944 * lisp.h (die, args_out_of_range, args_out_of_range_3)
4945 (wrong_type_argument, buffer_overflow, __executable_start)
4946 (memory_full, buffer_memory_full, string_overflow, Fthrow)
4947 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
4948 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
4949 (fatal):
4950 (child_setup) [!DOS_NT]:
4951 * lread.c (end_of_file_error, invalid_syntax):
4952 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4953 * puresize.h (pure_write_error):
4954 * search.c (matcher_overflow):
4955 * sound.c (sound_perror, alsa_sound_perror):
4956 * sysdep.c, syssignal.h (croak):
4957 * term.c (maybe_fatal, vfatal):
4958 * textprop.c (text_read_only):
4959 * undo.c (user_error):
4960 * unexmacosx.c (unexec_error):
4961 * xterm.c (x_ins_del_lines, x_delete_glyphs):
4962 Use _Noreturn rather than NO_RETURN.
4963 No need for separate decl merely because of _Noreturn.
4964 * sound.c (sound_warning, parse_sound):
4965 Remove unnecessary forward decls.
4966
f1dd8073
PE
49672012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4968
4969 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
4970 * lisp.h (WAIT_READING_MAX): New macro.
4971 * dispnew.c (Fsleep_for, sit_for):
4972 * keyboard.c (kbd_buffer_get_event):
4973 * process.c (Faccept_process_output):
4974 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
4975 This improves on the previous patch, which introduced a bug
4976 when time_t is unsigned and as wide as intmax_t.
4977 See <http://bugs.gnu.org/9000#51>.
4978
b82c1755
EZ
49792012-06-23 Eli Zaretskii <eliz@gnu.org>
4980
4981 * dispnew.c (sit_for, Fsleep_for):
4982 * keyboard.c (kbd_buffer_get_event):
4983 * process.c (Faccept_process_output): Avoid compiler warnings when
4984 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
4985
ca300656
JB
49862012-06-23 Juanma Barranquero <lekktu@gmail.com>
4987
049ec95b
JB
4988 * makefile.w32-in: Update dependencies.
4989
ca300656
JB
4990 * w32.c (ltime): Add return type and declare static.
4991 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
4992
db7b8d06
PE
49932012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4994
4995 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
4996 Privately reported by Herbert J. Skuhra.
4997 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
4998 All uses changed.
4999 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
5000 not make_lisp_timeval, when the argument is of type EMACS_TIME.
5001
0bd8297f
EZ
50022012-06-23 Eli Zaretskii <eliz@gnu.org>
5003
96512555
EZ
5004 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
5005 last argument of make_unibyte_string.
5006
0bd8297f
EZ
5007 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
5008 language ID in the event parameters.
5009
5010 * w32term.c (w32_read_socket): Put the new keyboard codepage into
5011 event.code, not the obscure "character set ID".
5012
63def6b6
CY
50132012-06-23 Chong Yidong <cyd@gnu.org>
5014
5015 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
5016
e8a02204
EZ
50172012-06-23 Eli Zaretskii <eliz@gnu.org>
5018
388cdec0
EZ
5019 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
5020 * w32.c (fdutimens): New function.
5021
5022 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
5023
5024 * s/ms-w32.h (pselect): Redirect to sys_select.
5025
5026 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
5027
e8a02204
EZ
5028 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
5029 in the logic of incrementing and decrementing the value of
5030 use_relocatable_buffers.
5031
d054f3fb
PE
50322012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5033
5034 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
5035 Privately reported by Herbert J. Skuhra.
5036 [__FreeBSD__]: Remove "*/" typo after "#include".
5037 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
5038 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
5039 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
5040 Don't assume EMACS_TIME and struct timeval are the same type.
5041
d35af63c
PE
50422012-06-22 Paul Eggert <eggert@cs.ucla.edu>
5043
5044 Support higher-resolution time stamps (Bug#9000).
5045 The time stamps are only nanosecond-resolution at the C level,
5046 since that's the best that any real-world system supports now.
5047 But they are picosecond-resolution at the Lisp level, as that's
5048 easy, and leaves room for future OS improvements.
5049
5050 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
5051 (LIBES): Use it.
5052
5053 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
5054 Don't get current time unless it's needed.
5055
5056 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
5057 now provides it if it's absent.
5058 (start_atimer): Port to higher-res time stamps.
5059 Check for time stamp overflow. Don't get current time more
5060 often than is needed.
5061
5062 * buffer.h (struct buffer): Buffer modtime now has high resolution.
5063 Include systime.h, not time.h.
5064 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
5065
5066 * dired.c: Include stat-time.h.
5067 (Ffile-attributes): File times now have higher resolution.
5068
5069 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
5070 (struct image): Timestamp now has higher resolution.
5071
5072 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
5073 has at least microseconds now. All uses removed.
5074 (update_frame, update_single_window, update_window, update_frame_1)
5075 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 5076 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
5077
5078 * editfns.c (time_overflow): Now extern.
5079 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
5080 (float-time, Fformat_time_string, Fcurrent_time_string)
5081 (Fcurrent_time_zone): Accept and generate higher-resolution
5082 time stamps.
5083 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
5084 (decode_time_components, lisp_seconds_argument): New functions.
5085 (make_time): Now static.
5086 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
5087 Report an error if the time is invalid, rather than having the caller
5088 do that.
5089
5090 * fileio.c: Include <stat-time.h>
5091 (Fcopy_file): Copy higher-resolution time stamps.
5092 Prefer to set the time stamp via a file descriptor if that works.
5093 (Fset_file_times, Finsert_file_contents, Fwrite_region)
5094 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
5095 (Fvisited_file_modtime, Fset_visited_file_modtime):
5096 Support higher-resolution time stamps.
5097
5098 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
5099
5100 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
5101
5102 * image.c (prepare_image_for_display, clear_image_cache)
5103 (lookup_image): Port to higer-resolution time stamps.
5104
5105 * keyboard.c (start_polling, bind_polling_period):
5106 Check for time stamp overflow.
5107 (read_char, kbd_buffer_get_event, timer_start_idle)
5108 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
5109 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
5110 Port to higher-resolution time stamps. Do not assume time_t is signed.
5111 (decode_timer): New function. Timers are now vectors of length 9,
5112 not 8, to accommodate the picosecond component.
5113 (timer_check_2): Use it.
5114
5115 * nsterm.m (select_timeout, timeval_subtract): Remove.
5116 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
5117 as they're a bit more accurate and handle overflow better.
5118 (ns_select): Change prototype to be compatible with pselect.
5119 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
5120 * nsterm.h (ns_select): Adjust prototype.
5121
5122 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
5123 us-resolution time stamps.
5124 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
5125
5126 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
5127
5128 * lisp.h (time_overflow): New decl.
5129 (wait_reading_process_output): First arg is now intmax_t, not int,
5130 to accommodate larger waits.
5131
5132 * process.h (struct Lisp_Process.read_output_delay):
5133 Now counts nanoseconds, not microseconds.
5134 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
5135 EMACS_HAS_USECS.
5136 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
5137 (wait_reading_process_output):
5138 Port to ns-resolution time stamps.
5139 (Faccept_process_output, wait_reading_process_output):
5140 Check for time stamp overflow. Do not assume time_t is signed.
5141 (select_wrapper): Remove; we now use pselect.
5142 (Fprocess_attributes): Now generates ns-resolution time stamps.
5143
5144 * sysdep.c: Include utimens.h. Don't include utime.h
5145 or worry about struct utimbuf; gnulib does that for us now.
5146 (gettimeofday): Remove; gnulib provides a substitute.
5147 (make_timeval): New function.
5148 (set_file_times): Now sets ns-resolution time stamps.
5149 New arg FD; all uses changed.
5150 (time_from_jiffies, ltime_from_jiffies, get_up_time)
5151 (system_process_attributes):
5152 Now returns ns-resolution time stamp. All uses changed.
5153 Check for time stamp overflow.
5154
5155 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
5156 provides a substitute now.
5157
5158 * systime.h: Include timespec.h rather than sys/time.h and time.h,
5159 since it guarantees struct timespec.
5160 (EMACS_TIME): Now struct timespec, so that we can support
5161 ns-resolution time stamps.
5162 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
5163 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
5164 (EMACS_USECS): Remove.
5165 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
5166 so multiply the arg by 1000 before storing it.
5167 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
5168 New macros.
5169 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
5170 Port to ns-resolution time stamps.
5171 (EMACS_TIME_NEG_P): Remove; replaced by....
5172 (EMACS_TIME_SIGN): New macro.
5173 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
5174 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
5175 (set_file_times, make_time, lisp_time_argument): Adjust signature.
5176 (make_timeval, make_lisp_time, decode_time_components): New decls.
5177 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
5178 that it mishandled time_t overflow. You can't compare by subtracting!
5179 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
5180 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
5181
5182 * term.c: Include <sys/time.h>.
5183 (timeval_to_Time): New function, for proper overflow wraparound.
5184 (term_mouse_position, term_mouse_click): Use it.
5185
5186 * undo.c (record_first_change): Support higher-resolution time stamps
5187 in the undo buffer.
5188 (Fprimitive_undo): Use them when restoring time stamps.
5189
5190 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
5191 (w32_get_internal_run_time):
5192 Port to higher-resolution Emacs time stamps.
5193 (ltime): Now accepts single 64-bit integer, as that's more convenient
5194 for callers.
5195
5196 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
5197
5198 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
5199 for compatibility with pselect. Support ns-resolution time stamps.
5200
5201 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
5202
5203 * xselect.c (wait_for_property_change, x_get_foreign_selection):
5204 Check for time stamp overflow, and support ns-resolution time stamps.
5205
5206 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
5207 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
5208 (timeval_subtract): Remove; no longer needed.
5209 (XTflash, XTring_bell, x_wait_for_event):
5210 Port to ns-resolution time stamps. Don't assume time_t is signed.
5211
b6a92dfe
CY
52122012-06-22 Chong Yidong <cyd@gnu.org>
5213
5214 * xdisp.c (x_consider_frame_title): Revert last change.
5215
d251c37c
EZ
52162012-06-22 Eli Zaretskii <eliz@gnu.org>
5217
5218 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
5219 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
5220 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
5221 staticidx goes up to 1597 out of 1600 = 0x640.)
5222
f10deafb
PE
52232012-06-20 Paul Eggert <eggert@cs.ucla.edu>
5224
5225 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
5226 Otherwise, the umask might be mistakenly 0 while handling input signals.
5227
ec6de1e2
SM
52282012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
5229
5230 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
5231
28be1ada
DA
52322012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
5233
5234 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
5235 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
5236 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
5237 access to `contents' member of Lisp_Vector objects with AREF and ASET
5238 where appropriate.
5239
c6bf3022
CY
52402012-06-19 Chong Yidong <cyd@gnu.org>
5241
5242 * frame.c (delete_frame): When selecting a frame on a different
5243 text terminal, do not alter the terminal's top-frame.
5244
5245 * xdisp.c (format_mode_line_unwind_data): Record the target
5246 frame's selected window and its terminal's top-frame.
5247 (unwind_format_mode_line): Restore them.
5248 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
5249 Callers changed.
5250 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
5251 since tty frames can be explicitly named.
5252 (prepare_menu_bars): Likewise.
5253
5254 * term.c (Ftty_top_frame): New function.
5255
defd4196
PE
52562012-06-18 Paul Eggert <eggert@cs.ucla.edu>
5257
5258 Port byte-code-meter to modern targets.
5259 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
5260 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 5261 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
5262 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
5263 (METER_1, METER_2): Simplify.
5264
1053a871
SM
52652012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
5266
5267 * data.c (Fdefalias): Return `symbol' (bug#11686).
5268
b7e8d081
MR
52692012-06-18 Martin Rudalics <rudalics@gmx.at>
5270
5271 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
5272 gets killed during executing of this function (Bug#11665).
5273 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
5274 (Vkill_buffer_query_functions): In doc-string say that functions
5275 run by this hook should not change the current buffer.
5276
7ea2b339
PE
52772012-06-18 Paul Eggert <eggert@cs.ucla.edu>
5278
5279 Fix recently-introduced process.c problems found by static checking.
5280 * process.c (write_queue_push, write_queue_pop, send_process):
5281 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
5282 (write_queue_pop): Fix pointer signedness problem.
5283 (send_process): Remove unused local.
5284
96a313a1
CY
52852012-06-17 Chong Yidong <cyd@gnu.org>
5286
5287 * xdisp.c (redisplay_internal): No need to redisplay terminal
5288 frames that are not on top.
5289
20ca2e94
TN
52902012-06-17 Troels Nielsen <bn.troels@gmail.com>
5291
5292 * process.c (make_process): Initialize write_queue.
5293 (write_queue_push, write_queue_pop): New functions.
5294 (send_process): Use them to maintain correct ordering of process
5295 writes (Bug#10815).
5296
9a900ca9
PE
52972012-06-17 Paul Eggert <eggert@cs.ucla.edu>
5298
310fbfa8
PE
5299 * lisp.h (eassert): Assume C89 or later.
5300 This removes the need for CHECK.
5301 (CHECK): Remove. Its comments about always evaluating its
5302 argument were confusing, as 'eassert' typically does not evaluate
5303 its argument.
5304
27bb1ca4
PE
5305 * coding.c (produce_chars): Use ptrdiff_t, not int.
5306
9a900ca9
PE
5307 * xterm.c (x_draw_underwave): Check for integer overflow.
5308 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
5309
41b7f8bc 53102012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
5311
5312 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
5313 referenced (Bug#11583).
5314
9b0e3eba
AA
53152012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
5316
5317 Implement wave-style variant of underlining.
5318 * dispextern.h (face_underline_type): New enum.
5319 (face): Add field for underline type.
5320 * nsterm.m (ns_draw_underwave): New function.
5321 (ns_draw_text_decoration): Use it.
5322 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
5323 New functions.
5324 (x_draw_glyph_string): Use them.
5325 * xfaces.c (Qline, Qwave): New Lisp objects.
5326 (check_lface_attrs, merge_face_ref)
1053a871
SM
5327 (Finternal_set_lisp_face_attribute, realize_x_face):
5328 Handle wave-style underline face attributes.
9b0e3eba
AA
5329 * xterm.c (x_draw_underwave): New function.
5330 (x_draw_glyph_string): Use it.
5331
0fb52f11
JB
53322012-06-16 Juanma Barranquero <lekktu@gmail.com>
5333
5334 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
5335 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
5336 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
5337 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
5338 ($(BLD)/w32select.$(O)): Update dependencies.
5339
e5560ff7
AS
53402012-06-16 Andreas Schwab <schwab@linux-m68k.org>
5341
5342 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
5343 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
5344 * character.c (_fetch_multibyte_char_p): Remove.
5345 * alloc.c: Include "character.h" before "buffer.h".
5346 * bidi.c: Likewise.
5347 * buffer.c: Likewise.
5348 * bytecode.c: Likewise.
5349 * callint.c: Likewise.
5350 * callproc.c: Likewise.
5351 * casefiddle.c: Likewise.
5352 * casetab.c: Likewise.
5353 * category.c: Likewise.
5354 * cmds.c: Likewise.
5355 * coding.c: Likewise.
5356 * composite.c: Likewise.
5357 * dired.c: Likewise.
5358 * dispnew.c: Likewise.
5359 * doc.c: Likewise.
5360 * dosfns.c: Likewise.
5361 * editfns.c: Likewise.
5362 * emacs.c: Likewise.
5363 * fileio.c: Likewise.
5364 * filelock.c: Likewise.
5365 * font.c: Likewise.
5366 * fontset.c: Likewise.
5367 * fringe.c: Likewise.
5368 * indent.c: Likewise.
5369 * insdel.c: Likewise.
5370 * intervals.c: Likewise.
5371 * keyboard.c: Likewise.
5372 * keymap.c: Likewise.
5373 * lread.c: Likewise.
5374 * macros.c: Likewise.
5375 * marker.c: Likewise.
5376 * minibuf.c: Likewise.
5377 * nsfns.m: Likewise.
5378 * nsmenu.m: Likewise.
5379 * print.c: Likewise.
5380 * process.c: Likewise.
5381 * regex.c: Likewise.
5382 * region-cache.c: Likewise.
5383 * search.c: Likewise.
5384 * syntax.c: Likewise.
5385 * term.c: Likewise.
5386 * textprop.c: Likewise.
5387 * undo.c: Likewise.
5388 * unexsol.c: Likewise.
5389 * w16select.c: Likewise.
5390 * w32fns.c: Likewise.
5391 * w32menu.c: Likewise.
5392 * window.c: Likewise.
5393 * xdisp.c: Likewise.
5394 * xfns.c: Likewise.
5395 * xmenu.c: Likewise.
5396 * xml.c: Likewise.
5397 * xselect.c: Likewise.
5398
2f07e6af
EZ
53992012-06-16 Eli Zaretskii <eliz@gnu.org>
5400
1053a871
SM
5401 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
5402 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 5403 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
5404 row.
5405 (handle_face_prop): Use chunk-relative overlay string index when
5406 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
5407 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
5408 the rightmost. (Bug#11720)
2f07e6af 5409
29b83cec
AS
54102012-06-16 Andreas Schwab <schwab@linux-m68k.org>
5411
5412 * category.h (CHAR_HAS_CATEGORY): Define as inline.
5413 (CATEGORY_MEMBER): Enforce 1/0 value.
5414 * category.c (_temp_category_set): Remove.
5415
4c5501e9
EZ
54162012-06-16 Eli Zaretskii <eliz@gnu.org>
5417
5418 * window.c (Fdelete_other_windows_internal)
5419 (Fdelete_window_internal): Don't access frame's mouse highlight
5420 info of the initial frame. (Bug#11677)
5421
2b570124
PE
54222012-06-14 Paul Eggert <eggert@cs.ucla.edu>
5423
e93864f9
PE
5424 * .gdbinit (xgetint): Fix recently-introduced paren typo.
5425 Assume USE_2_TAGS_FOR_INTS.
5426 (xreload): Adjust $tagmask width to match recent lisp.h change.
5427
2b570124
PE
5428 Simplify lisp.h in minor ways that should not affect code.
5429 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
5430 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
5431 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
5432 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
5433 (INTTYPEBITS): New macro, for clarity.
5434 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
5435 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
5436 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
5437 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
5438 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
5439
81755f69
JB
54402012-06-13 Juanma Barranquero <lekktu@gmail.com>
5441
5442 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
5443
16192a57
GM
54442012-06-13 Glenn Morris <rgm@gnu.org>
5445
5446 * s/bsd-common.h (BSD4_3):
5447 * s/usg5-4-common.h (USG5_4): No longer define; unused.
5448
646b5f55
AS
54492012-06-13 Andreas Schwab <schwab@linux-m68k.org>
5450
5451 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
5452 instead of union.
5453 (XLI, XIL): Define.
1053a871
SM
5454 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
5455 Use them.
5456 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 5457 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 5458 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
5459 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
5460 * frame.c (delete_frame): Remove outdated comment.
5461 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
5462 USE_LISP_UNION_TYPE.
5463 (Fw32_unregister_hot_key): Likewise.
5464 (Fw32_toggle_lock_key): Likewise.
5465 * w32menu.c (add_menu_item): Likewise.
5466 (w32_menu_display_help): Use XIL instead of checking
5467 USE_LISP_UNION_TYPE.
5468 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
5469 (init_heap): Likewise.
5470 * w32term.c (w32_read_socket): Update comment.
5471
1d3823c9
GM
54722012-06-13 Glenn Morris <rgm@gnu.org>
5473
c62ff706
GM
5474 * s/usg5-4-common.h, src/s/unixware.h:
5475 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
5476
1d3823c9
GM
5477 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
5478
bfe3e0a2
PE
54792012-06-13 Paul Eggert <eggert@cs.ucla.edu>
5480
5481 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
5482 * alloc.c (make_number) [!defined make_number]:
5483 Remove, as lisp.h always defines this now.
5484 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
5485 (roundup_size): Verify that it is a power of 2.
5486 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
5487 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
5488 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
5489 -DUSE_LSB_TAG=0, to override the automatically-selected default.
5490 USE_LSB_TAG now is always defined to be either 0 or 1.
5491 All uses changed.
5492 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
5493 code works fine either way, and efficiency is not a concern here,
5494 as the union type is for debugging, not for production.
5495 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
5496 Use an inline function on all platforms when using the union type,
5497 since this is simpler and 'static inline' can be used portably
5498 within Emacs now.
5499 (LISP_INITIALLY_ZERO): New macro.
5500 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
5501 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
5502
45fa9c0f
GM
55032012-06-12 Glenn Morris <rgm@gnu.org>
5504
b4492cba
GM
5505 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
5506
5507 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 5508
45fa9c0f
GM
5509 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
5510 Move BROKEN_SIGIO to configure.
5511
5512 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
5513 Move NO_TERMIO to configure.
5514
0e25d334
CY
55152012-06-12 Chong Yidong <cyd@gnu.org>
5516
5517 * image.c (imagemagick_load_image): Use MagickFlattenImage if
5518 MagickMergeImageLayers is undefined. Use pixel pusher loop if
5519 MagickExportImagePixels is undefined.
5520
43682bb6
PE
55212012-06-12 Paul Eggert <eggert@cs.ucla.edu>
5522
5523 * image.c (imagemagick_load_image): Remove unused label.
5524
a9be7d2b
GM
55252012-06-11 Glenn Morris <rgm@gnu.org>
5526
5527 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
5528 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
5529 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
5530 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
5531
3017f87f
SM
55322012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
5533
5534 * alloc.c (make_byte_code): New function.
5535 (Fmake_byte_code): Use it. Don't purify here.
5536 * lread.c (read1): Use it as well to avoid extra allocation.
5537
1b9b4cf4
CY
55382012-06-11 Chong Yidong <cyd@gnu.org>
5539
5540 * image.c (imagemagick_load_image): Implement transparency.
5541
95988fcf
AS
55422012-06-10 Andreas Schwab <schwab@linux-m68k.org>
5543
5544 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
5545 account for preceding backslashes. (Bug#11663)
5546
cd4eb164
CY
55472012-06-09 Chong Yidong <cyd@gnu.org>
5548
5549 * term.c: Support italics in capable terminals (Bug#9652).
5550 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
5551 (turn_on_face): Output using TS_enter_italic_mode if available.
5552 Don't handle unused blinking and alt-charset cases.
5553 (turn_off_face): Handle italic case; discard unused tty_blinking_p
5554 and tty_alt_charset_p cases.
5555 (tty_capable_p, init_tty): Support italics.
5556
5557 * termchar.h (struct tty_display_info): Add field for italics.
5558 Remove unused blink field.
5559
5560 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
5561 Handle slant.
5562
5563 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
5564 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
5565 tty_alt_charset_p. Add tty_italic_p.
5566
ff88beb8
MA
55672012-06-09 Michael Albinus <michael.albinus@gmx.de>
5568
5569 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
5570 dbus_type_is_basic if available.
5571 (xd_extract_signed, xd_extract_unsigned): Rename from
5572 extract_signed and extract_unsigned, respectively. Adapt callers.
5573
44286096
CY
55742012-06-09 Chong Yidong <cyd@gnu.org>
5575
1682701f
CY
5576 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
5577
44286096
CY
5578 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
5579 case (Bug#9752).
5580
d86feb17
PE
55812012-06-08 Paul Eggert <eggert@cs.ucla.edu>
5582
5583 * xdisp.c (vmessage): Treat frame message as multibyte.
5584 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
5585 would generate the diagnostic "Making \302\247 buffer-local while
5586 let-bound!".
5587
d5c20fe8
EZ
55882012-06-08 Eli Zaretskii <eliz@gnu.org>
5589
5590 * dispnew.c (showing_window_margins_p): Undo last change, which
5591 was done due to an inadvertent commit.
5592 (adjust_frame_glyphs_for_frame_redisplay): Do call
5593 showing_window_margins_p.
5594
513749ee
SM
55952012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
5596
5597 * eval.c (Fmake_var_non_special): New primitive.
5598 (syms_of_eval): Defsubr it.
5599 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
5600
d4a8f5c1
JB
56012012-06-08 Juanma Barranquero <lekktu@gmail.com>
5602
5603 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
5604 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
5605
8bbbc977
EZ
56062012-06-08 Eli Zaretskii <eliz@gnu.org>
5607
5608 * alloc.c (allocate_vectorlike): Fix last change.
5609
f3372c87
DA
56102012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
5611
5612 Block-based vector allocation of small vectors.
5613 * lisp.h (struct vectorlike_header): New field `nbytes',
5614 adjust comment accordingly.
5615 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
5616 to denote vector blocks. Adjust users (live_vector_p,
5617 mark_maybe_pointer, valid_lisp_object_p) accordingly.
5618 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
5619 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
5620 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
5621 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
5622 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
5623 (roundup_size): New constant.
5624 (struct vector_block): New data type.
5625 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 5626 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
5627 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
5628 (sweep_vectors): New functions.
5629 (allocate_vectorlike): Return `zero_vector' as the only vector of
5630 0 items. Allocate new vector from block if vector size is less than
5631 or equal to VBLOCK_BYTES_MAX.
5632 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
5633 (init_alloc_once): Add call to init_vectors.
5634
4f18a4ed
SM
56352012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
5636
5637 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
5638
86f158bc
PE
56392012-06-07 Paul Eggert <eggert@cs.ucla.edu>
5640
5641 * doprnt.c (doprnt): Truncate multibyte char correctly.
5642 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
5643 would mishandle a string argument "Xc" if X was a multibyte
5644 character of length 2: it would truncate after X's first byte
5645 rather than including all of X.
5646
c5cfcbe0
CY
56472012-06-06 Chong Yidong <cyd@gnu.org>
5648
5649 * buffer.c (word_wrap): Doc fix.
5650
c05cf390
PE
56512012-06-04 Paul Eggert <eggert@cs.ucla.edu>
5652
5653 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
5654
0c3461de
GM
56552012-06-03 Glenn Morris <rgm@gnu.org>
5656
5657 * xdisp.c (tool-bar-style): Doc fix.
5658
c71232db
UM
56592012-06-03 Ulrich Müller <ulm@gentoo.org>
5660
5661 * Makefile.in (PAXCTL): Define.
5662 (temacs$(EXEEXT)): Disable memory randomization for the temacs
5663 binary via PaX flags if the paxctl utility is available.
5664 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
5665 Restore PaX flags to their default. (Bug#11398)
5666
383f7350
CY
56672012-06-03 Chong Yidong <cyd@gnu.org>
5668
5669 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
5670 buffer (Bug#11226).
5671
5f2c76c6
CY
56722012-06-03 Chong Yidong <cyd@gnu.org>
5673
5674 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
5675 (note_mode_line_or_margin_highlight): If there is no help echo,
5676 use mode-line-default-help-echo. Handle the case where the mouse
5677 position is past the end of the mode line string.
5678
5679 * buffer.c (buffer_local_value_1): New function, split from
5680 Fbuffer_local_value; can return Qunbound.
5681 (Fbuffer_local_value): Use it.
5682 (Vmode_line_format): Docstring tweaks.
5683
773d47f6
PE
56842012-06-02 Paul Eggert <eggert@cs.ucla.edu>
5685
5686 * sysdep.c (system_process_attributes): Improve comment.
5687
f2d6a3df
SM
56882012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
5689
5690 * keyboard.c: Export real-this-command to Elisp.
5691 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
5692 and DEFVAR it. Update all users.
5693
63810350
PE
56942012-06-02 Paul Eggert <eggert@cs.ucla.edu>
5695
7bd5c1f4
PE
5696 * minibuf.c (Fassoc_string): Remove duplicate declaration.
5697
63810350
PE
5698 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
5699 Convert pctcpu and pctmem to Lisp float properly.
5700 Let the compiler fold better, as 100.0/0x8000 is exact.
5701
a2821611
AS
57022012-06-02 Andreas Schwab <schwab@linux-m68k.org>
5703
5704 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
5705 cons_block.
5706
5fceba1d
PE
57072012-06-01 Paul Eggert <eggert@cs.ucla.edu>
5708
5709 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
5710
c98ff5dd
DA
57112012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
5712
5713 For a 'struct window', replace some Lisp_Object fields to
5714 bitfields where appropriate, remove unused fields.
5715 * window.h (struct window): Remove unused 'last_mark_x' and
5716 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
5717 change it's type from Lisp_Object to bitfield.
5718 Change type of 'force_start', 'optional_new_start',
5719 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
5720 fields from Lisp_Object to bitfield. Adjust users accordingly.
5721
ca34e0be
PE
57222012-05-31 Paul Eggert <eggert@cs.ucla.edu>
5723
5724 Pacify gcc -Wdouble-precision when using Xaw.
5725 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
5726 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
5727 Use 'float' consistently, rather than 'float' in most places
5728 and 'double' in a couple of places.
5729
efc00ab1 57302012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
5731
5732 * xdisp.c (handle_stop): Detect whether we have overlay strings
5733 loaded by testing it->current.overlay_string_index to be
5734 non-negative, instead of checking whether n_overlay_strings is
5735 positive. (Bug#11587)
5736
efc00ab1 57372012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
5738
5739 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
5740
5741 * doc.c (Fsubstitute_command_keys): Doc fix.
5742
efc00ab1 57432012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
5744
5745 * search.c (search_buffer): Remove calls to
5746 r_alloc_inhibit_buffer_relocation, as it is now called by
5747 maybe_unify_char, which was the cause of relocation of buffer text
5748 in bug#11519.
5749
efc00ab1 57502012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
5751
5752 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
5753 for the duration of call to load_charset, to avoid problems with
5754 callers of maybe_unify_char that access buffer text through C
5755 pointers.
5756
5757 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
5758 decrement the inhibition flag, instead of just setting or
5759 resetting it.
5760
ba93a187
PE
57612012-05-31 Paul Eggert <eggert@cs.ucla.edu>
5762
5763 Remove obsolete '#define static' cruft.
5764 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
5765 This #undef was "temporary" in 2000; it is no longer needed
5766 now that '#define static' has gone away.
5767 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
5768 (gray_bitmap_bits): Remove; no longer needed.
5769 All uses replaced with definiens.
5770 * xterm.c: Include "bitmaps/gray.xbm".
5771
9e4bf381
PE
57722012-05-30 Paul Eggert <eggert@cs.ucla.edu>
5773
5774 Clean up __executable_start, monstartup when --enable-profiling.
5775 The following changes affect the code only when profiling.
5776 * dispnew.c (__executable_start): Rename from safe_bcopy.
5777 Define only on platforms that need it.
5778 * emacs.c: Include <sys/gmon.h> when profiling.
5779 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
5780 (__executable_start): Remove decl, since lisp.h does it now.
5781 (safe_bcopy): Remove decl; no longer has that name.
5782 (main): Coalesce #if into single bit of code, for simplicity.
5783 Cast pointers to uintptr_t, since standard libraries want integers
5784 and not pointers.
5785 * lisp.h (__executable_start): New decl.
5786
32d72c2f
GM
57872012-05-31 Glenn Morris <rgm@gnu.org>
5788
5789 * image.c (Fimagemagick_types): Doc fix.
5790
baac5bc7
JM
57912012-05-30 Jim Meyering <meyering@redhat.com>
5792
5793 * callproc.c (Fcall_process_region): Include directory component
5794 in mkstemp error message (Bug#11586).
5795
72cb32cf
PE
57962012-05-30 Paul Eggert <eggert@cs.ucla.edu>
5797
5798 * alloc.c, lisp.h (make_pure_vector): Now static.
5799
61b108cc
SM
58002012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
5801
5802 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
5803 Move to byte-run.el.
5804 (Fautoload): Do the hash-doc more carefully.
5805 * data.c (Fdefalias): Purify definition, except for keymaps.
5806 (Qdefun): Move from eval.c.
5807 * lisp.h (Qdefun): Remove.
5808 * lread.c (read1): Tiny simplification.
5809
471fe23d
TN
58102012-05-29 Troels Nielsen <bn.troels@gmail.com>
5811
934f3f58 5812 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
5813 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
5814 Bug#9642, but explicitly check that the buffer the overlay would
5815 be moved to is live and rearrange lines to make sure that errors
5816 will not put the overlay in an inconsistent state.
5817 (Fdelete_overlay): Cosmetics.
5818
85d0efd1
EZ
58192012-05-28 Eli Zaretskii <eliz@gnu.org>
5820
5821 * w32term.c (my_bring_window_to_top): New function.
5822 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
5823 could be different from the original one.
5824 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
5825 (Bug#11513)
5826
5827 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
5828 by calling BringWindowToTop.
5829
5830 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
5831 (WM_EMACS_END): Increase by one.
5832
da92a98c
PE
58332012-05-28 Paul Eggert <eggert@cs.ucla.edu>
5834
5835 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
5836 This avoids undefined behavior that might cause the eassert
5837 to not catch an out-of-range value.
5838
74d1f848
JB
58392012-05-28 Juanma Barranquero <lekktu@gmail.com>
5840
5841 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
5842 Update dependencies.
5843
9e1a06fc
EZ
58442012-05-27 Eli Zaretskii <eliz@gnu.org>
5845
5846 * bidi.c (bidi_mirror_char): Fix last change.
5847
f3dd7312
AS
58482012-05-27 Andreas Schwab <schwab@linux-m68k.org>
5849
5850 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
5851 when referring to sectname field in printf format.
5852
81899c91
PE
58532012-05-27 Paul Eggert <eggert@cs.ucla.edu>
5854
57b81a9f
PE
5855 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
5856 Only r_alloc_inhibit_buffer_relocation needed to be added;
5857 the others were already declared.
5858
81899c91
PE
5859 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
5860 before checking whether it's out of range. Put the check inside
5861 eassert. See
5862 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
5863
33017faf 58642012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
5865
5866 * callproc.c (Fcall_process): Restore a line that was accidentally
5867 commented out in the 2011-02-13 change (bug#11547).
5868
33017faf 58692012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
5870
5871 * lisp.h [REL_ALLOC]: Add prototypes for external functions
5872 defined on ralloc.c.
5873
5874 * buffer.c [REL_ALLOC]: Remove prototypes of
5875 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
5876 they are now on lisp.h.
5877
5878 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
5879
5880 * search.c (search_buffer): Use it to inhibit relocation of buffer
5881 text while re_search_2 is doing its job, because re_search_2 is
5882 passed C pointers to buffer text. (Bug#11519)
5883
23415acf
EZ
5884 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
5885 Update value to 24.
5886
44e27368
EZ
5887 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
5888 state after an additional call to move_it_in_display_line_to, keep
5889 the values of it->max_ascent and it->max_descent found for the
5890 entire line.
5891 (pos_visible_p): Revert the comparison against bottom_y to what it
5892 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
5893 (Bug#11464)
5894
c1892f11
PE
58952012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5896
5897 Fix coding-related core dumps with gcc -ftrapv.
5898 The code was computing A - B, where A and B are pointers, and B is
5899 random garbage. This can lead to core dumps on platforms that
5900 have special pointer registers, and it also leads to core dumps on
5901 x86-64 when compiled with gcc -ftrapv. The fix is to compute
5902 A - B only when B is initialized properly.
5903 * coding.c (coding_set_source, coding_set_destination): Return void.
5904 (coding_change_source, coding_change_destinations): New functions,
5905 with the old behaviors of coding_set_source and coding_set_destination.
5906 All callers that need an offset changed to use these new functions.
5907
eb7afdad
GM
59082012-05-26 Glenn Morris <rgm@gnu.org>
5909
5910 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
5911
f12fdf02
EZ
59122012-05-26 Eli Zaretskii <eliz@gnu.org>
5913
53a63be6 5914 Extend mouse support on W32 text-mode console.
61b108cc
SM
5915 * xdisp.c (draw_row_with_mouse_face):
5916 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 5917
eb3f6f01 5918 * w32console.c: Include window.h.
61b108cc
SM
5919 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
5920 New functions.
eb3f6f01
EZ
5921 (initialize_w32_display): Initialize mouse-highlight data.
5922
53a63be6
EZ
5923 * w32inevt.c: Include termchar.h and window.h.
5924 (do_mouse_event): Support mouse-autoselect-window. When the mouse
5925 moves, call note_mouse_highlight. If help_echo changed, call
5926 gen_help_event to produce help-echo message in the echo area.
5927 Call clear_mouse_face if mouse_face_hidden is set in the mouse
5928 highlight info.
5929
4cfd81f6
PE
59302012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5931
5932 * lread.c (read1): Simplify slightly to avoid an overflow warning
5933 with GCC 4.7.0 on x86-64.
5934
4446092a
EZ
59352012-05-26 Eli Zaretskii <eliz@gnu.org>
5936
5937 * bidi.c (bidi_mirror_char): Revert last change: an int is
5938 definitely wide enough here.
5939
42b2a986 59402012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 5941
42b2a986 5942 Fix integer width and related bugs (Bug#9874).
eb106a49 5943 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5944 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
5945 (string_bytes, check_sblock, allocate_string_data):
5946 (compact_small_strings, Fmake_bool_vector, make_string)
5947 (make_unibyte_string, make_multibyte_string)
5948 (make_string_from_bytes, make_specified_string)
5949 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
5950 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
5951 (mark_vectorlike):
5952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5953 (allocate_pseudovector):
5954 Use int, not EMACS_INT, where int is wide enough.
5955 (inhibit_garbage_collection, Fgarbage_collect):
5956 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5957 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
5958 int might not be wide enough.
5959 (bidi_cache_search, bidi_cache_find, bidi_init_it)
5960 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
5961 (bidi_at_paragraph_end, bidi_find_paragraph_start)
5962 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5963 (bidi_level_of_next_char, bidi_move_to_visually_next):
5964 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5965 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
5966 (Fkill_buffer, Fset_buffer_major_mode)
5967 (advance_to_char_boundary, Fbuffer_swap_text)
5968 (Fset_buffer_multibyte, overlays_at, overlays_in)
5969 (overlay_touches_p, struct sortvec, record_overlay_string)
5970 (overlay_strings, recenter_overlay_lists)
5971 (adjust_overlays_for_insert, adjust_overlays_for_delete)
5972 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
5973 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
5974 (Foverlay_recenter, last_overlay_modification_hooks_used)
5975 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
5976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
5977 (validate_region): Omit unnecessary test for b <= e,
5978 since that's guaranteed by the previous test.
d311d28c
PE
5979 (adjust_overlays_for_delete): Avoid pos + length overflow.
5980 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
5981 (report_overlay_modification):
5982 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5983 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
5984 Omit pointer cast, which isn't needed anyway, and doesn't work
5985 after the EMACS_INT -> ptrdiff_t change.
02481186 5986 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
5987 * buffer.h: Adjust decls to match defn changes elsewhere.
5988 (struct buffer_text, struct buffer):
5989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5990 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
5991 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
5992 not int, to avoid needless 32-bit limit on 64-bit hosts.
5993 (exec_byte_code): Use tighter memory-full test, one that checks
5994 for alloca overflow. Don't compute the address of the object just
5995 before an array, as that's not portable. Use EMACS_INT, not
5996 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
5997 * callint.c (Fcall_interactively):
5998 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5999 * callproc.c (call_process_kill, Fcall_process):
6000 Don't assume pid_t fits into an Emacs fixnum.
6001 (call_process_cleanup, Fcall_process, child_setup):
6002 Don't assume pid_t fits into int.
6003 (call_process_cleanup, Fcall_process, delete_temp_file)
6004 (Fcall_process_region):
6005 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6006 (Fcall_process): Simplify handling of volatile integers.
6007 Use int, not EMACS_INT, where int will do.
6008 * casefiddle.c (casify_object, casify_region, operate_on_word)
6009 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
6010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6011 (casify_object): Avoid integer overflow when overallocating buffer.
6012 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 6013 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
6014 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
6015 * category.h (CATEGORYP): Don't assume arg is nonnegative.
6016 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
6017 integers are now checked earlier. All uses replaced with XINT.
6018 (ccl_driver):
6019 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6020 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
6021 (ccl_driver, Fregister_code_conversion_map):
6022 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
6023 (resolve_symbol_ccl_program): Check that vector header is in range.
6024 Always copy the vector, so that we can check its contents reliably
6025 now rather than having to recheck each instruction as it's being
6026 executed. Check that vector words fit in 'int'.
6027 (ccl_get_compiled_code, Fregister_ccl_program)
6028 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
6029 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
6030 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
6031 contents are in range.
6032 (Fccl_execute_on_string): Check that status is in range.
6033 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
6034 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
6035 Accept and return EMACS_INT, not int, because callers can pass values
6036 out of 'int' range.
6037 (c_string_width, strwidth, lisp_string_width, chars_in_text)
6038 (multibyte_chars_in_text, parse_str_as_multibyte)
6039 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
6040 (str_as_unibyte, str_to_unibyte, string_count_byte8)
6041 (string_escape_byte8, Fget_byte):
6042 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 6043 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
6044 avoid mishandling large integers.
6045 * character.h: Adjust decls to match defn changes elsewhere.
6046 * charset.c (load_charset_map_from_file, find_charsets_in_text)
6047 (Ffind_charset_region):
6048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6049 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
6050 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 6051 Don't assume fixnum fits in int.
d311d28c
PE
6052 (load_charset_map_from_vector, Fmap_charset_chars):
6053 Remove now-unnecessary CHECK_NATNUMs.
6054 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
6055 Don't rely on undefined behavior with signed left shift overflow.
6056 Don't assume unsigned int fits into fixnum, or that fixnum fits
6057 into unsigned int. Don't require max_code to be a valid fixnum;
6058 that's not true for gb10830 4-byte on a 32-bit host. Allow
6059 invalid_code to be a cons, for the same reason. Require code_offset
6060 to be a character. Avoid int overflow if max_char is close
6061 to INT_MAX.
6062 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
6063 this is intended anyway and avoids some undefined behavior.
6064 (load_charset_map): Pass unsigned, not int, as 2nd arg of
6065 INDEX_TO_CODE_POINT, as that's what it expects.
6066 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
6067 * charset.h (DECODE_CHAR): Return int, not unsigned;
6068 this is what was intended anyway, and it avoids undefined behavior.
6069 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
6070 integer-overflow issues.
6071 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
6072 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
6073 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
6074 * chartab.c (Fmake_char_table, Fset_char_table_range)
6075 (uniprop_get_decoder, uniprop_get_encoder):
6076 Don't assume fixnum fits in int.
6077 * cmds.c (move_point): New function, that does the gist of
6078 Fforward_char and Fbackward_char, but does so while checking
6079 for integer overflow more accurately.
c96e5d6a 6080 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
6081 (Fforward_line, Fend_of_line, internal_self_insert)
6082 (internal_self_insert):
6083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6084 Fix a FIXME, by checking for integer overflow when calculating
6085 target_clm and actual_clm.
6086 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 6087 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
6088 (ASSURE_DESTINATION, coding_alloc_by_realloc)
6089 (coding_alloc_by_making_gap, alloc_destination)
6090 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
6091 (encode_coding_utf_16, detect_coding_emacs_mule)
6092 (decode_coding_emacs_mule, encode_coding_emacs_mule)
6093 (detect_coding_iso_2022, decode_coding_iso_2022)
6094 (encode_invocation_designation, encode_designation_at_bol)
6095 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6096 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
6097 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
6098 (encode_coding_ccl, encode_coding_raw_text)
6099 (detect_coding_charset, decode_coding_charset)
6100 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
6101 (produce_composition, produce_charset, produce_annotation)
6102 (decode_coding, handle_composition_annotation)
6103 (handle_charset_annotation, consume_chars, decode_coding_gap)
6104 (decode_coding_object, encode_coding_object, detect_coding_system)
6105 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
6106 (code_convert_region, code_convert_string)
8f50130c
PE
6107 (Fdefine_coding_system_internal)
6108 (coding_set_source, coding_set_destination):
d311d28c
PE
6109 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6110 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
6111 (Fdefine_coding_system_internal):
6112 Don't assume fixnums fit in int.
6113 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 6114 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
6115 (Funencodable_char_position, Fcheck_coding_systems_region)
6116 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 6117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 6118 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 6119 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 6120 Don't access memory outside of the args array.
d311d28c 6121 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
6122 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
6123 result of ENCODE_CHAR.
d311d28c
PE
6124 * coding.h: Adjust decls to match defn changes elsewhere.
6125 (struct coding_system):
6126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6127 * composite.c (get_composition_id, find_composition)
6128 (run_composition_function, update_compositions)
6129 (compose_text, composition_gstring_put_cache)
6130 (composition_gstring_p, composition_gstring_width)
6131 (fill_gstring_header, fill_gstring_body, autocmp_chars)
6132 (composition_compute_stop_pos, composition_reseat_it)
6133 (composition_update_it, struct position_record)
6134 (find_automatic_composition, composition_adjust_point)
6135 (Fcomposition_get_gstring, Ffind_composition_internal):
6136 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6137 (update_compositions):
6138 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6139 * composite.h: Adjust decls to match defn changes elsewhere.
6140 (struct composition):
6141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6142 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
6143 Do not attempt to compute the address of the object just before a
6144 buffer; this is not portable.
6145 (Faref, Faset):
6146 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6147 (Faset): Use int, not EMACS_INT, where int is wide enough.
6148 (Fstring_to_number): Don't assume fixnums fit in int.
6149 (Frem): Don't assume arg is nonnegative.
6150 * dbusbind.c (xd_append_arg): Check for integers out of range.
6151 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 6152 (extract_signed, extract_unsigned): New functions.
243e0530
PE
6153 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
6154 (xd_get_connection_references): Return ptrdiff_t, not int.
6155 All uses changed.
6156 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
6157 (xd_read_message_1):
6158 Use int, not unsigned, where the dbus API uses int.
6159 (Fdbus_message_internal): Don't overflow mtype.
6160 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
6161 * dired.c (directory_files_internal, file_name_completion, scmp)
6162 (file_name_completion_stat):
6163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6164 (file_name_completion): Don't overflow matchcount.
6165 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
6166 * dispextern.h: Adjust decls to match defn changes elsewhere.
6167 (struct text_pos, struct glyph, struct bidi_saved_info)
6168 (struct bidi_string_data, struct bidi_it, struct composition_it)
6169 (struct it):
6170 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6171 (struct display_pos, struct composition_it, struct it):
6172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6173 * dispnew.c (increment_matrix_positions)
6174 (increment_row_positions, mode_line_string)
6175 (marginal_area_string):
6176 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 6177 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
6178 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6179 (duration_to_sec_usec): New function, to check for overflow better.
6180 (Fsleep_for, sit_for): Use it.
6181 * doc.c (get_doc_string, store_function_docstring):
6182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6183 (get_doc_string, Fsnarf_documentation):
6184 Use int, not EMACS_INT, where int is wide enough.
6185 (get_doc_string):
6186 Use SAFE_ALLOCA, not alloca.
6187 Check for overflow when converting EMACS_INT to off_t.
6188 * doprnt.c (doprnt):
6189 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6190 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
6191 Don't assume uid_t fits into fixnum.
6192 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
6193 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
6194 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
6195 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
6196 (general_insert_function)
6197 (Finsert_char, make_buffer_string, make_buffer_string_both)
6198 (update_buffer_properties, Fbuffer_substring)
6199 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
6200 (Fsubst_char_in_region, check_translation)
6201 (Ftranslate_region_internal, save_restriction_restore, Fformat)
6202 (transpose_markers, Ftranspose_regions):
6203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6204 (clip_to_bounds): Move to lisp.h as an inline function).
6205 (Fconstrain_to_field): Don't assume integers are nonnegative.
6206 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
6207 (Fsubst_char_in_region, Fsave_restriction):
6208 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6209 (Femacs_pid): Don't assume pid_t fits into fixnum.
6210 (lo_time): Use int, not EMACS_INT, when int suffices.
6211 (lisp_time_argument): Check for usec out of range.
6212 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
6213 (Fuser_login_name, Fuser_full_name): Signal an error
6214 if a uid argument is out of range, rather than relying on
6215 undefined behavior.
c8d5c857
PE
6216 (Fformat_time_string): Remove now-unnecessary check.
6217 lisp_time_argument checks for out-of-range usec now.
243e0530 6218 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
6219 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
6220 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
6221 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
6222 (init_cmdargs, Fdump_emacs):
6223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6224 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
6225 the bottom (typically) 32 bits of the fixnum.
6226 * eval.c (specpdl_size, call_debugger):
6227 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6228 (when_entered_debugger, Fbacktrace_debug):
6229 Don't assume fixnum can fit in int.
6230 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
6231 the object just before a buffer; this is not portable.
6232 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
6233 (grow_specpdl, unbind_to):
6234 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6235 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
6236 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 6237 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
6238 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
6239 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
6240 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6241 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
6242 (a_write, e_write):
6243 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6244 (Fcopy_file, non_regular_nbytes, read_non_regular)
6245 (Finsert_file_contents):
6246 Use int, not EMACS_INT, where int is wide enough.
6247 (READ_BUF_SIZE): Verify that it fits in int.
6248 (Finsert_file_contents): Check that counts are in proper range,
6249 rather than assuming fixnums fit into ptrdiff_t etc.
6250 Don't assume fixnums fit into int.
125b3835 6251 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
6252 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
6253 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
6254 (string_char_to_byte, string_byte_to_char)
6255 (string_make_multibyte, string_to_multibyte)
6256 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
6257 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
6258 (substring_both, Fdelete, internal_equal, Ffillarray)
6259 (Fclear_string, mapcar1)
6260 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
6261 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
6262 (larger_vector, make_hash_table, maybe_resize_hash_table)
6263 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
6264 (Fmaphash, secure_hash):
6265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6266 (concat): Check for string index and length overflow.
6267 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
6268 (Frequire):
6269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6270 (larger_vector): New API (vec, incr_min, size_max) replaces old
6271 one (vec, new_size, init). This catches size overflow.
6272 INIT was removed because it was always Qnil.
6273 All callers changed.
6274 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
6275 the upper bound on a hash table index size.
6276 (make_hash_table, maybe_resize_hash_table): Use it.
6277 (secure_hash): Computer start_byte and end_byte only after
6278 they're known to be in ptrdiff_t range.
6279 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
6280 (Ffont_get_glyphs, Ffont_at):
6281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6282 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
6283 (Flist_fonts, Fopen_font):
6284 Don't assume fixnum can fit in int.
6285 (check_gstring): Don't assume index can fit in int.
6286 (font_match_p): Check that fixnum is a character, not a nonnegative
6287 fixnum, since the later code needs to stuff it into an int.
6288 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
6289 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
6290 conversion overflow issues.
6291 (Fopen_font): Check for integer out of range.
6292 (Ffont_get_glyphs): Don't assume index can fit in int.
6293 * font.h: Adjust decls to match defn changes elsewhere.
6294 * fontset.c (reorder_font_vector): Redo score calculation to avoid
6295 integer overflow.
6296 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
6297 printmax_t, where ptrdiff_t is wide enough.
6298 (Finternal_char_font):
6299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6300 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
6301 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
6302 (Fset_frame_position, x_set_frame_parameters)
6303 (x_set_line_spacing, x_set_border_width)
6304 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
6305 Check that fixnums are in proper range for system types.
6306 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
6307 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6308 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
6309 Use SAFE_ALLOCA_LISP, not alloca.
6310 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
6311 intptr_t is wide enough.
6312 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
6313 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
6314 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
6315 Check for fixnum out of range.
6316 * ftfont.c (ftfont_list): Don't assume index fits in int.
6317 Check that fixnums are in proper range for system types.
6318 (ftfont_shape_by_flt):
6319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
6320 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6321 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6322 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
6323 Check that fixnums are in proper range for system types.
6324 * gnutls.h: Adjust decls to match defn changes elsewhere.
6325 * gtkutil.c (xg_dialog_run):
6326 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6327 (update_frame_tool_bar):
6328 Check that fixnums are in proper range for system types.
6329 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 6330 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
6331 * indent.c (last_known_column, last_known_column_point):
6332 (current_column_bol_cache):
6333 (skip_invisible, current_column, check_display_width):
6334 (check_display_width, scan_for_column, current_column_1)
6335 (Findent_to, Fcurrent_indentation, position_indentation)
6336 (indented_beyond_p, Fmove_to_column, compute_motion):
6337 (Fcompute_motion, Fvertical_motion):
6338 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6339 (last_known_column_modified): Use EMACS_INT, not int.
6340 (check_display_width):
6341 (Fcompute_motion):
6342 Check that fixnums and floats are in proper range for system types.
6343 (compute_motion): Don't assume index or fixnum fits in int.
6344 (compute_motion, Fcompute_motion):
6345 Use int, not EMACS_INT, when it is wide enough.
6346 (vmotion): Omit local var start_hpos that is always 0; that way
6347 we don't need to worry about overflow in expressions involving it.
6348 * indent.h: Adjust decls to match defn changes elsewhere.
6349 (struct position):
6350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6351 Use int, not EMACS_INT, where int is wide enough.
6352 Remove unused members ovstring_chars_done and tab_offset;
6353 all uses removed.
6354 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
6355 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
6356 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
6357 (make_gap, copy_text, insert, insert_and_inherit)
6358 (insert_before_markers, insert_before_markers_and_inherit)
6359 (insert_1, count_combining_before, count_combining_after)
6360 (insert_1_both, insert_from_string)
6361 (insert_from_string_before_markers, insert_from_string_1)
6362 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
6363 (adjust_after_replace, adjust_after_insert, replace_range)
6364 (replace_range_2, del_range, del_range_1, del_range_byte)
6365 (del_range_both, del_range_2, modify_region)
6366 (prepare_to_modify_buffer, signal_before_change)
6367 (signal_after_change, Fcombine_after_change_execute):
6368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6369 * intervals.c (traverse_intervals, rotate_right, rotate_left)
6370 (balance_an_interval, split_interval_right, split_interval_left)
6371 (find_interval, next_interval, update_interval)
6372 (adjust_intervals_for_insertion, delete_node, delete_interval)
6373 (interval_deletion_adjustment, adjust_intervals_for_deletion)
6374 (static_offset_intervals, offset_intervals)
6375 (merge_interval_right, merge_interval_left, make_new_interval)
6376 (graft_intervals_into_buffer, temp_set_point_both)
6377 (temp_set_point, set_point, adjust_for_invis_intang)
6378 (set_point_both, move_if_not_intangible, get_property_and_range)
6379 (get_local_map, copy_intervals, copy_intervals_to_string)
6380 (compare_string_intervals, set_intervals_multibyte_1):
6381 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6382 * intervals.h: Adjust decls to match defn changes elsewhere.
6383 (struct interval):
6384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6385 * keyboard.c (this_command_key_count, this_single_command_key_start)
6386 (before_command_key_count, before_command_echo_length, echo_now)
6387 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
6388 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
6389 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
6390 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
6391 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6392 (last_non_minibuf_size, last_point_position, echo_truncate)
6393 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
6394 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
6395 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
6396 (stuff_buffered_input):
6397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6398 (last_auto_save, command_loop_1, read_char):
6399 Use EMACS_INT, not int, to avoid integer overflow.
6400 (record_char): Avoid overflow in total_keys computation.
6401 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
6402 * keyboard.h: Adjust decls to match defn changes elsewhere.
6403 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
6404 (Fkey_description, Fdescribe_vector, Flookup_key):
6405 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6406 (click_position): New function, to check that positions are in range.
6407 (Fcurrent_active_maps):
6408 (describe_command):
6409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6410 (Faccessible_keymaps, Fkey_description):
6411 (preferred_sequence_p):
6412 Don't assume fixnum can fit into int.
6413 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
6414 Check for integer overflow in size calculations.
6415 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
6416 avoid mishandling large integers.
6417 * lisp.h: Adjust decls to match defn changes elsewhere.
6418 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
6419 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
6420 (struct Lisp_Marker):
6421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6422 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
6423 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
6424 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
6425 All callers changed.
6426 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
6427 Assume the arg has valid form, since it always does.
6428 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
6429 unsigned integer system type.
6430 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
6431 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
6432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6433 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
6434 (duration_to_sec_usec): New decl.
6435 * lread.c (read_from_string_index, read_from_string_index_byte)
6436 (read_from_string_limit, readchar, unreadchar, openp)
6437 (read_internal_start, read1, oblookup):
6438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6439 (Fload, readevalloop, Feval_buffer, Feval_region):
6440 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6441 (openp): Check for out-of-range argument to 'access'.
6442 (read1): Use int, not EMACS_INT, where int is wide enough.
6443 Don't assume fixnum fits into int.
6efdadfd 6444 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
6445 (read_filtered_event): Use duration_to_sec_usec
6446 to do proper overflow checking on durations.
d311d28c
PE
6447 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
6448 in size calculation.
6449 (Fexecute_kbd_macro):
6450 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6451 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
6452 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
6453 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
6454 (set_marker_both, set_marker_restricted_both, marker_position)
6455 (marker_byte_position, Fbuffer_has_markers_at):
6456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6457 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 6458 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
6459 It now merely ensures that the menu is large enough, without
6460 necessarily growing it, as this avoids some integer overflow issues.
6461 All callers changed.
6462 (keymap_panes, parse_single_submenu, Fx_popup_menu):
6463 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6464 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
6465 Use SAFE_ALLOCA_LISP, not alloca.
6466 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
6467 to EMACS_INT. Check that fixnums are in proper range for system types.
6468 * minibuf.c (minibuf_prompt_width, string_to_object)
6469 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
6470 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
6471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6472 (get_minibuffer, read_minibuf_unwind):
6473 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6474 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
6475 this simplifies overflow checking. All callers changed.
6476 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
6477 (Ftest_completion):
6478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6479 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
6480 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
6481 Check that fixnums are in proper range for system types.
6482 (Fx_create_frame, Fx_show_tip):
6483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6484 * nsfont.m (ns_findfonts, nsfont_list_family):
6485 Don't assume fixnum fits in long.
6486 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
6487 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6488 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
6489 wide enough.
17fdb222 6490 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
6491 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6492 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
6493 (PRINTDECLARE, PRINTPREPARE):
6494 (strout, print_string):
6495 (print, print_preprocess, print_check_string_charset_prop)
6496 (print_object):
6497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6498 (PRINTDECLARE):
6499 (temp_output_buffer_setup, Fprin1_to_string, print_object):
6500 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6501 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 6502 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 6503 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
6504 (print_error_message): Use SAFE_ALLOCA, not alloca.
6505 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
6506 (print_depth, new_backquote_output, print_number_index):
6507 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
6508 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
6509 (Fset_process_window_size, Fformat_network_address)
6510 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 6511 (sigchld_handler):
d311d28c 6512 Check that fixnums are in proper range for system types.
d44287d4 6513 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
6514 Check for process-ids out of pid_t range rather than relying on
6515 undefined behavior.
e4d81efc 6516 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
6517 (Fformat_network_address, read_process_output, send_process)
6518 (Fprocess_send_region, status_notify):
6519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6520 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
6521 (wait_reading_process_output, read_process_output, exec_sentinel):
6522 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6523 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
6524 (Faccept_process_output): Use duration_to_sec_usec to do proper
6525 overflow checking on durations.
dde14581
PE
6526 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
6527 Don't assume pid_t fits in int.
02481186
PE
6528 * process.h (struct Lisp_Process): Members tick and update_tick
6529 are now of type EMACS_INT, not int.
b62b53e8
PE
6530 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
6531 configured --with-wide-int.
d311d28c
PE
6532 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
6533 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
6534 * search.c (looking_at_1, string_match_1):
6535 (fast_string_match, fast_c_string_match_ignore_case)
6536 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
6537 (scan_newline, find_before_next_newline, search_command)
6538 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
6539 (set_search_regs, wordify):
6540 (Freplace_match):
6541 (Fmatch_data):
6542 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6543 (string_match_1, search_buffer, set_search_regs):
6544 (Fmatch_data):
6545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6546 (wordify): Check for overflow in size calculation.
6547 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
6548 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
6549 Check that fixnums are in proper range for system types.
6550 * sound.c (struct sound_device)
6551 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
6552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6553 (Fplay_sound_internal):
6554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 6555 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
6556 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
6557 (Fparse_partial_sexp):
6558 Don't assume fixnums can fit in int.
6559 (struct lisp_parse_state, find_start_pos, find_start_value)
6560 (find_start_value_byte, find_start_begv)
6561 (update_syntax_table, char_quoted, dec_bytepos)
6562 (find_defun_start, prev_char_comend_first, back_comment):
6563 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
6564 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
6565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6566 (Finternal_describe_syntax_value): Check that match_lisp is a
6567 character, not an integer, since the code stuffs it into int.
6568 (scan_words, scan_sexps_forward):
6569 Check that fixnums are in proper range for system types.
6570 (Fforward_word):
6571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6572 (scan_sexps_forward):
6573 Use CHARACTERP, not INTEGERP, since the value must fit into int.
6574 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
6575 * syntax.h: Adjust decls to match defn changes elsewhere.
6576 (struct gl_state_s):
6577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
6578 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
6579 MOST_POSITIVE_FIXNUM.
d311d28c
PE
6580 * sysdep.c (wait_for_termination_1, wait_for_termination)
6581 (interruptible_wait_for_termination, mkdir):
6582 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
6583 (emacs_read, emacs_write):
6584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
6585 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
6586 and double all fit in int.
d311d28c
PE
6587 * term.c (set_tty_color_mode):
6588 Check that fixnums are in proper range for system types.
6589 * termhooks.h (struct input_event):
6590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6591 * textprop.c (validate_interval_range, interval_of)
6592 (Fadd_text_properties, set_text_properties_1)
6593 (Fremove_text_properties, Fremove_list_of_text_properties)
6594 (Ftext_property_any, Ftext_property_not_all)
6595 (copy_text_properties, text_property_list, extend_property_ranges)
6596 (verify_interval_modification):
6597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6598 (Fnext_single_char_property_change)
6599 (Fprevious_single_char_property_change):
6600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
6601 (copy_text_properties):
6602 Check for integer overflow in index calculation.
d311d28c
PE
6603 * undo.c (last_boundary_position, record_point, record_insert)
6604 (record_delete, record_marker_adjustment, record_change)
6605 (record_property_change):
6606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6607 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
6608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6609 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
6610 (Fx_hide_tip, Fx_file_dialog):
6611 * w32menu.c (set_frame_menubar):
6612 Use ptrdiff_t, not int, for consistency with rest of code.
6613 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
6614 (select_window, Fdelete_other_windows_internal)
6615 (window_scroll_pixel_based, window_scroll_line_based)
6616 (Frecenter, Fset_window_configuration):
6617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6618 (Fset_window_hscroll, run_window_configuration_change_hook)
6619 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 6620 (Fscroll_other_window, Frecenter):
d311d28c
PE
6621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6622 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
6623 Don't assume fixnum fits in int.
6624 (Fset_window_scroll_bars):
6625 Check that fixnums are in proper range for system types.
6626 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
6627 (string_pos, c_string_pos, number_of_chars, init_iterator)
6628 (in_ellipses_for_invisible_text_p, init_from_display_pos)
6629 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
6630 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
6631 (face_before_or_after_it_pos, handle_invisible_prop)
6632 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
6633 (display_prop_intangible_p, string_buffer_position_lim)
6634 (string_buffer_position, handle_composition_prop, load_overlay_strings)
6635 (get_overlay_strings_1, get_overlay_strings)
6636 (iterate_out_of_display_property, forward_to_next_line_start)
6637 (back_to_previous_visible_line_start, reseat, reseat_to_string)
6638 (get_next_display_element, set_iterator_to_next)
6639 (get_visually_first_element, compute_stop_pos_backwards)
6640 (handle_stop_backwards, next_element_from_buffer)
6641 (move_it_in_display_line_to, move_it_in_display_line)
6642 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6643 (add_to_log, message_dolog, message_log_check_duplicate)
6644 (message2, message2_nolog, message3, message3_nolog
6645 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
6646 (current_message_1, truncate_echo_area, truncate_message_1)
6647 (set_message, set_message_1, store_mode_line_noprop)
6648 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
6649 (text_outside_line_unchanged_p, check_point_in_composition)
6650 (reconsider_clip_changes)
6651 (redisplay_internal, set_cursor_from_row, try_scrolling)
6652 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
6653 (redisplay_window, find_last_unchanged_at_beg_row)
6654 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
6655 (trailing_whitespace_p, find_row_edges, display_line)
6656 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
6657 (display_mode_element, store_mode_line_string)
6658 (pint2str, pint2hrstr, decode_mode_spec)
6659 (display_count_lines, display_string, draw_glyphs)
6660 (x_produce_glyphs, x_insert_glyphs)
6661 (rows_from_pos_range, mouse_face_from_buffer_pos)
6662 (fast_find_string_pos, mouse_face_from_string_pos)
6663 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6665 (safe_call, init_from_display_pos, handle_fontified_prop)
6666 (handle_single_display_spec, load_overlay_strings)
6667 (with_echo_area_buffer, setup_echo_area_for_printing)
6668 (display_echo_area, echo_area_display)
6669 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
6670 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
6671 (redisplay_window, dump_glyph_row, display_mode_line)
6672 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 6673 (handle_display_spec, display_prop_string_p):
d311d28c
PE
6674 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6675 (handle_single_display_spec, build_desired_tool_bar_string)
6676 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
6677 (get_specified_cursor_type):
6678 Check that fixnums are in proper range for system types.
6679 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
6680 (Flookup_image_map):
6681 Don't assume fixnums fit in int.
6682 (compare_overlay_entries):
6683 Avoid mishandling comparisons due to subtraction overflow.
6684 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
6685 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
6686 (handle_tool_bar_click):
6687 Use int, not unsigned, since we prefer signed and the signedness
6688 doesn't matter here.
6689 (get_next_display_element, next_element_from_display_vector):
6690 Use int, not EMACS_INT, when int is wide enough.
6691 (start_hourglass): Use duration_to_sec_usec to do proper
6692 overflow checking on durations.
6693 * xfaces.c (Fbitmap_spec_p):
6694 Check that fixnums are in proper range for system types.
6695 (compare_fonts_by_sort_order):
6696 Avoid mishandling comparisons due to subtraction overflow.
6697 (Fx_family_fonts, realize_basic_faces):
6698 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6699 (Fx_family_fonts):
6700 Don't assume fixnum fits in int.
6701 Use SAFE_ALLOCA_LISP, not alloca.
6702 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
6703 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
6704 (face_at_buffer_position, face_for_overlay_string)
6705 (face_at_string_position):
6706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6707 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
6708 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
6709 (Fx_show_tip):
6710 Check that fixnums are in proper range for system types.
6711 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
6712 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
6713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6714 (Fx_change_window_property): Don't assume fixnums fit in int.
6715 * xfont.c (xfont_chars_supported):
6716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6717 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
6718 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
6719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6720 * xml.c (parse_region):
6721 * xrdb.c (magic_file_p):
6722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6723 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
6724 (x_get_local_selection, x_reply_selection_request)
6725 (x_handle_selection_request, wait_for_property_change):
6726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6727 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
6728 short is wide enough.
6729 (x_send_client_event): Don't assume fixnum fits in int.
6730 * xterm.c (x_x_to_emacs_modifiers):
6731 Don't assume EMACS_INT overflows nicely into int.
6732 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
6733 may come from Lisp.
6734 (handle_one_xevent): NATNUMP can eval its arg twice.
6735 (x_connection_closed):
6736 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6737 * xterm.h: Adjust decls to match defn changes elsewhere.
6738 (struct scroll_bar): Use struct vectorlike_header
6739 rather than rolling our own approximation.
6740 (SCROLL_BAR_VEC_SIZE): Remove; not used.
6741
c6574eb5
GM
67422012-05-25 Glenn Morris <rgm@gnu.org>
6743
6744 * lisp.mk (lisp): Update for more files being compiled now.
6745
e8d32c7e
SM
67462012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
6747
48def666
SM
6748 * lread.c: Remove `read_pure' which makes no difference.
6749 (read_pure): Remove var.
6750 (unreadpure): Remove function.
6751 (readevalloop): Don't call read_list with -1 flag.
6752 (read1, read_vector): Don't test read_pure any more.
6753 (read_list): Simplify.
6754
e8d32c7e
SM
6755 * fileio.c, character.h: Minor style tweaks.
6756
4b2addb7
DA
67572012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
6758
6759 * window.h (clip_changed): Remove useless declaration.
6760
584461b2
JB
67612012-05-22 Juanma Barranquero <lekktu@gmail.com>
6762
6763 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
6764 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
6765
34374650
PE
67662012-05-22 Paul Eggert <eggert@cs.ucla.edu>
6767
6768 Remove src/m/*.
6769 This directory predates autoconf and is no longer needed nowadays.
6770 Move its few remaining bits of functionality to where they're needed.
6771 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
6772 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
6773 * m/template.h: Remove.
6774 * Makefile.in (M_FILE): Remove. All uses removed.
6775 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
6776 * lisp.h (USE_LSB_TAG):
6777 * mem-limits.h (EXCEEDS_LISP_PTR):
6778 Use VAL_MAX, not VALBITS, in #if.
6779 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
6780 (EMACS_UINT): Define unconditionally now.
6781 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
6782 (BITS_PER_EMACS_INT): New constants, replacing
6783 what used to be in config.h, but not useful in #if.
6784 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
6785 define them any more.
6786 (VAL_MAX): New macro.
6787 (VALMASK): Use it.
6788 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
6789 BITS_PER_EMACS_INT, in #if.
6790 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
6791 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
6792 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
6793 * s/ms-w32.h (DATA_START):
6794 Move here from removed file m/intel386.h.
6795 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
6796 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
6797
261cb4bb
PE
67982012-05-21 Paul Eggert <eggert@cs.ucla.edu>
6799
6800 Assume C89 or later.
6801 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
6802 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
6803 (xrealloc):
6804 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
6805 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
6806 * textprop.c, tparam.c (NULL): Remove.
6807 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
6808 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
6809 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
6810 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
6811 * xterm.c (input_signal_count): Assume volatile works.
6812
ff23cd9f
KB
68132012-05-21 Ken Brown <kbrown@cornell.edu>
6814
6815 * xgselect.c (xg_select): Fix first argument in call to 'select'
6816 (bug#11508).
6817
1b170bc6
KB
68182012-05-20 Ken Brown <kbrown@cornell.edu>
6819
6820 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 6821 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 6822
b2f4d39f
KB
68232012-05-19 Ken Brown <kbrown@cornell.edu>
6824
6825 * xfns.c (x_in_use): Remove `static' qualifier.
6826 * xterm.h (x_in_use): Declare.
6827 * xgselect.c: Include xterm.h.
6828 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
6829 and `display_arg' (bug#9754).
6830
003fdae2
PE
68312012-05-19 Paul Eggert <eggert@cs.ucla.edu>
6832
9232a6d9
PE
6833 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
6834
003fdae2
PE
6835 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
6836 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
6837
784b56e2
EZ
68382012-05-18 Eli Zaretskii <eliz@gnu.org>
6839
6840 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
6841
6842 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 6843 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
6844
6845 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
6846 reference to image_cache->refcount.
6847 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
6848
a0a79cde
JL
68492012-05-17 Juri Linkov <juri@jurta.org>
6850
6851 * search.c (Fword_search_regexp, Fword_search_backward)
6852 (Fword_search_forward, Fword_search_backward_lax)
6853 (Fword_search_forward_lax): Move functions to isearch.el
6854 (bug#10145, bug#11381).
6855
b0572523
PE
68562012-05-16 Paul Eggert <eggert@cs.ucla.edu>
6857
6858 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
6859
9660f5fc
SM
68602012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
6861
6862 * lread.c (init_obarray): Declare Qt and Qnil as special.
6863
4374de83
GM
68642012-05-14 Glenn Morris <rgm@gnu.org>
6865
6866 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 6867 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 6868
dc44c39a
PE
68692012-05-14 Paul Eggert <eggert@cs.ucla.edu>
6870
078c97cb
PE
6871 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
6872
dc44c39a
PE
6873 * unexaix.c: Port to more-recent AIX compilers.
6874 (report_error, report_error_1, make_hdr, copy_sym)
6875 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
6876 Make arguments const char *, not char *, to avoid violations of C
6877 standard and to fix some AIX warnings reported by Gilles Pion.
6878
e18afed7 68792012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
6880
6881 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
6882 already have overlays loaded.
6883 (handle_single_display_spec): Before returning without displaying
6884 fringe bitmap, synchronize the bidi iterator with the main display
6885 iterator, by calling iterate_out_of_display_property.
6886 (iterate_out_of_display_property): Detect buffer iteration by
6887 testing that it->string is a Lisp string.
6888 (get_next_display_element): When the current object is exhausted,
6889 and there's something on it->stack, call set_iterator_to_next to
6890 proceed with what's on the stack, instead of returning zero.
6891 (set_iterator_to_next): If called at the end of a Lisp string,
6892 proceed to consider_string_end without incrementing string
6893 position. Don't increment display vector index past the end of
6894 the display vector. (Bug#11417)
c8fb9dc6
EZ
6895 (pos_visible_p): Don't report a position visible when move_it_to
6896 stopped at the last line of window, which happens to be scanned
6897 backwards by the bidi iteration. (Bug#11464)
ac268e67 6898
e18afed7 68992012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
6900
6901 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
6902 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
6903 are on a TTY, and thus unable to display on the fringes.
6904 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
6905 so we need to signal to the caller that this is a "replacing"
6906 display spec. This fixes display when the spec is invalid or we
6907 are on a TTY.
6908
e18afed7 69092012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
6910
6911 * unexaix.c (make_hdr): Fix typo in prototype.
6912 This bug broke the build on AIX. Problem reported by Gilles Pion.
6913
9d0a235a
MA
69142012-05-14 Michael Albinus <michael.albinus@gmx.de>
6915
6916 * keyboard.c (kbd_buffer_get_event): Read special events also in
6917 batch mode. (Bug#11415)
6918
9e6b06ed
GM
69192012-05-12 Glenn Morris <rgm@gnu.org>
6920
6921 * ns.mk: Update for ns_appbindir no longer having trailing "/".
6922
c1a1d7a3
EZ
69232012-05-12 Eli Zaretskii <eliz@gnu.org>
6924
6925 * lisp.mk (lisp): Add newcomment.elc.
6926
3fe7cdc8
GM
69272012-05-12 Glenn Morris <rgm@gnu.org>
6928
6929 * Makefile.in (MKDIR_P): New, set by configure.
6930 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
6931
53f7d2c0
PE
69322012-05-11 Paul Eggert <eggert@cs.ucla.edu>
6933
6934 Remove unused function hourglass_started.
6935 * dispextern.h (hourglass_started):
6936 * w32fns.c (hourglass_started):
6937 * xdisp.c (hourglass_started): Remove.
6938
75aafb17
JB
69392012-05-10 Juanma Barranquero <lekktu@gmail.com>
6940
6941 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
6942 Update dependencies.
6943
12959e8e
PE
69442012-05-10 Paul Eggert <eggert@cs.ucla.edu>
6945
97107e2e
PE
6946 * xgselect.c (xg_select): Put maxfds+1 into a var.
6947 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
6948
12959e8e
PE
6949 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
6950
836d29b3
DA
69512012-05-10 Dave Abrahams <dave@boostpro.com>
6952
6953 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
6954 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
6955
5cb67954
MA
69562012-05-09 Michael Albinus <michael.albinus@gmx.de>
6957
6958 * dbusbind.c (xd_registered_buses): New internal Lisp object.
6959 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
6960 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
6961 Initialize xd_registered_buses.
6962
3478ec45
PE
69632012-05-09 Paul Eggert <eggert@cs.ucla.edu>
6964
b263a6b0
PE
6965 Untag more efficiently if USE_LSB_TAG.
6966 This is based on a proposal by YAMAMOTO Mitsuharu in
6967 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
6968 For an admittedly artificial (nth 8000 longlist) benchmark on
6969 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
6970 Emacs's overall text size by 1%.
6971 * lisp.h (XUNTAG): New macro.
6972 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
6973 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
6974 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
6975 * eval.c (Fautoload):
6976 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
6977 * frame.h (XFRAME): Use XUNTAG.
6978
3478ec45
PE
6979 Port recent dbusbind.c changes to 32-bit --with-wide-int.
6980 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
6981 Remove unportable assumptions about print widths of types like
6982 dbus_uint32_t.
6983 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
6984 intptr_t when converting between pointer and integer, to avoid GCC
6985 warnings about wrong width.
6986
666b903b 69872012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
6988
6989 * w32proc.c (new_child): Force Windows to reserve only 64KB of
6990 stack for each reader_thread, instead of defaulting to 8MB
6991 determined by the linker. This avoids failures in creating
6992 subprocesses on Windows 7, see the discussion in this thread:
6993 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
6994
b120cc17
JC
69952012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
6996
6997 Fix up display of the *Minibuf-0* buffer in the mini window.
6998 * keyboard.c (read_char): Don't clear the echo area if there's no
6999 message to clear.
7000 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 7001 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 7002
9a4b36f8
MA
70032012-05-07 Michael Albinus <michael.albinus@gmx.de>
7004
7005 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
7006 batch mode.
7007
e5f9458f
CY
70082012-05-06 Chong Yidong <cyd@gnu.org>
7009
7010 * lisp.mk (lisp): Update.
7011
eceeb5fc 70122012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
7013
7014 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
7015
71873e2b
SM
70162012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
7017
7018 * data.c (PUT_ERROR): New macro.
7019 (syms_of_data): Use it. Add new error type `user-error'.
7020 * undo.c (user_error): New function.
7021 (Fprimitive_undo): Use it.
7022 * print.c (print_error_message): Adjust print style for `user-error'.
7023 * keyboard.c (user_error): New function.
7024 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
7025
ab0fa4e4
PE
70262012-05-03 Paul Eggert <eggert@cs.ucla.edu>
7027
7028 Do not limit current-time-string to years 1000..9999.
7029 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
7030 (Fcurrent_time_string): Support any year that is supported by the
7031 underlying localtime representation. Don't use asctime, as it
7032 has undefined behavior for years outside the range -999..9999.
7033
7ed806a7
PE
70342012-05-02 Paul Eggert <eggert@cs.ucla.edu>
7035
7036 Fix race conditions involving setenv, gmtime, localtime, asctime.
7037 Without this fix, interrupts could mess up code that uses these
7038 nonreentrant functions, since setting TZ invalidates existing
7039 tm_zone or tzname values, and since most of these functions return
7040 pointers to static storage.
7041 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
7042 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
7043 Grow the critical sections to include not just invoking
7044 localtime/gmtime, but also accessing these functions' results
7045 including their tm_zone values if any, and any related TZ setting.
7046 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
7047 so that the struct tm is saved in the critical section.
7048 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
7049 motivated by the fact that memory allocation needs to be outside
7050 the critical section.
7051
0c16dfed
DA
70522012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
7053
7054 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
7055 with RESET_INTERVAL.
7056
7057 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7058 Remove duplicated buffer name initialization.
7059
3f83ace8
JM
70602012-05-02 Jim Meyering <jim@meyering.net>
7061
7062 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
7063
c7b8541e
JM
7064 * xfns.c (x_window): Use xstrdup (Bug#11375).
7065
90207a15 70662012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
7067
7068 * xdisp.c (pos_visible_p): If already at a newline from the
7069 display string before the 'while' loop, don't walk back the glyphs
7070 from it3.glyph_row. Solves assertion violation when the display
7071 string begins with a newline (egg.el). (Bug#11367)
7072
b593d6a9
AH
70732012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
7074
7075 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
7076 Move to simple.el.
7077
4737362e
GM
70782012-05-01 Glenn Morris <rgm@gnu.org>
7079
99cf43f9
GM
7080 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
7081 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
7082 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
7083 All were removed before 23.1.
7084
9311dcff
GM
7085 * dispnew.c: Remove HAVE_LIBNCURSES test;
7086 it is always true on relevant platforms.
7087
4d5c6349
GM
7088 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
7089 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
7090
4737362e
GM
7091 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
7092
74dd3a6b
AS
70932012-04-30 Andreas Schwab <schwab@linux-m68k.org>
7094
7095 * .gdbinit (xpr): Remove checks for no longer existing misc types.
7096 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
7097 Remove.
7098
13c379ee
PE
70992012-04-28 Paul Eggert <eggert@cs.ucla.edu>
7100
7101 Do not avoid creating empty evaporating overlays (Bug#9642).
7102 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
7103 That is, do not delete an evaporating overlay if it becomes
7104 empty after its bounds are adjusted to fit within its buffer.
7105 This fix caused other problems, and I'm reverting it until we get
7106 to the bottom of them.
7107
a8e7d6d7 71082012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
7109
7110 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
7111
a8e7d6d7 71122012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
7113
7114 * xdisp.c (pos_visible_p): If the window start position is beyond
7115 ZV, start the display from buffer beginning. Prevents assertion
7116 violation in init_iterator when the minibuffer window is scrolled
7117 via the scroll bar.
7118
7119 * window.c (window_scroll_pixel_based): Likewise.
7120
a8e7d6d7 71212012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
7122
7123 * keymap.c (where_is_internal): Doc fix (Bug#10872).
7124
a8e7d6d7 71252012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
7126
7127 * fileio.c (Fcopy_file, Fset_file_selinux_context):
7128 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
7129
a8e7d6d7 71302012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 7131
b593d6a9
AH
7132 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
7133 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 7134
1c6900d9
EZ
71352012-04-26 Eli Zaretskii <eliz@gnu.org>
7136
4c3fa1d9
EZ
7137 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
7138 display element, check also the underlying string or buffer
7139 character. (Bug#11341)
7140
1c6900d9
EZ
7141 * w32menu.c: Include w32heap.h.
7142 (add_menu_item): If the call to AppendMenuW (via
7143 unicode_append_menu) fails, disable Unicode menus only if we are
7144 running on Windows 9X/Me.
7145
42bf8205
AS
71462012-04-24 Andreas Schwab <schwab@linux-m68k.org>
7147
7148 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
7149 (xgetint): Add missing shift for LSB tags.
7150
b1bac16e
MR
71512012-04-24 Martin Rudalics <rudalics@gmx.at>
7152
7153 * keyboard.c (read_char): Don't wipe echo area for select window
7154 events: These might get delayed via `mouse-autoselect-window'
7155 (Bug#11304).
7156
d69621cc
JB
71572012-04-24 Juanma Barranquero <lekktu@gmail.com>
7158
7159 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
7160 manipulation of :loaded-from data.
7161
02fd101b
JB
71622012-04-23 Juanma Barranquero <lekktu@gmail.com>
7163
7164 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
7165 now a cons (bug#11311).
7166
888bec30
PE
71672012-04-23 Paul Eggert <eggert@cs.ucla.edu>
7168
89a438bd
PE
7169 Do not create empty overlays with the evaporate property (Bug#9642).
7170 * buffer.c (Fmove_overlay): Delete an evaporating overlay
7171 if it becomes empty after its bounds are adjusted to fit within
7172 its buffer. Without this fix, in a nonempty buffer (let ((o
7173 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
7174 yields an empty overlay that has the evaporate property, which is
7175 not supposed to happen.
7176
1068fe4d
PE
7177 Fix minor GTK3 problems found by static checking.
7178 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7179 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7180 (struct _EmacsFixedClass, emacs_fixed_get_type):
7181 Move decls here from emacsgtkfixed.h, since they needn't be public.
7182 (emacs_fixed_get_type): Now static.
7183 (emacs_fixed_class_init): Omit unused local.
7184 (emacs_fixed_child_type): Remove; unused.
7185 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7186 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7187 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
7188 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
7189 (EMACS_FIXED_GET_CLASS): Remove; unused.
7190 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
7191
888bec30
PE
7192 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
7193 Problem reported by Juanma Barranquero for Windows -Wunused-function.
7194
de85e130
PE
71952012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7196
d0baac98 7197 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 7198 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
7199 (__malloc_size_t, __malloc_ptrdiff_t):
7200 Remove. All uses removed, replaced by the definiens if needed,
7201 since we can assume C89 or better now.
7202 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
7203 (protect_malloc_state, align, get_contiguous_space)
7204 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
7205 (malloc_atfork_handler_child, malloc_enable_thread)
7206 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
7207 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
7208 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
7209 (special_realloc, _realloc_internal_nolock, _realloc_internal)
7210 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
7211 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
7212 Define using prototypes, not old style.
7213 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
7214 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
7215 (align): Don't assume that signed integer overflow wraps around.
7216 Omit unused local var.
7217 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
7218 (_free_internal_nolock, memalign, mallochook, reallochook):
7219 Omit no-longer-needed casts.
7220 (valloc): Use getpagesize, not __getpagesize.
7221 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
7222 (struct hdr): The 'magic' member is now size_t, not unsigned long.
7223
de85e130
PE
7224 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
7225
dcbf5805
MA
72262012-04-22 Michael Albinus <michael.albinus@gmx.de>
7227
7228 Move functions from C to Lisp. Make non-blocking method calls
7229 the default. Implement further D-Bus standard interfaces.
7230
7231 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
7232 (QCdbus_request_name_allow_replacement)
7233 (QCdbus_request_name_replace_existing)
7234 (QCdbus_request_name_do_not_queue)
7235 (QCdbus_request_name_reply_primary_owner)
7236 (QCdbus_request_name_reply_in_queue)
7237 (QCdbus_request_name_reply_exists)
7238 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
7239 (QCdbus_registered_serial, QCdbus_registered_method)
7240 (QCdbus_registered_signal): New Lisp objects.
7241 (XD_DEBUG_MESSAGE): Use sizeof.
7242 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
7243 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
7244 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
7245 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
7246 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
7247 (xd_signature, xd_append_arg): Allow float for integer types.
7248 (xd_get_connection_references): New function.
b593d6a9
AH
7249 (xd_get_connection_address): Rename from xd_initialize.
7250 Return cached address.
dcbf5805
MA
7251 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
7252 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
7253 level.
7254 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 7255 Return number of refcounts.
dcbf5805
MA
7256 (Fdbus_get_unique_name): Make stronger parameter check.
7257 (Fdbus_message_internal): New defun.
7258 (Fdbus_call_method, Fdbus_call_method_asynchronously)
7259 (Fdbus_method_return_internal, Fdbus_method_error_internal)
7260 (Fdbus_send_signal, Fdbus_register_service)
7261 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
7262 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
7263 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
7264 (Vdbus_compiled_version, Vdbus_runtime_version)
7265 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
7266 (Vdbus_message_type_method_return, Vdbus_message_type_error)
7267 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
7268 (Vdbus_registered_buses, Vdbus_registered_objects_table):
7269 Adapt docstring.
dcbf5805 7270
52828e02
PE
72712012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7272
da05bc4c
PE
7273 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
7274 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
7275 Do not assume ptrdiff_t is the same width as 'int'.
7276
52828e02
PE
7277 * alloc.c: Handle unusual debugging option combinations.
7278 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
7279 since the two debugging options are incompatible.
7280 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
7281 is defined.
7282 (mem_init, mem_insert, mem_insert_fixup):
7283 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
7284 (NEED_MEM_INSERT): Remove; no longer needed.
7285
f01769f9
LL
72862012-04-22 Leo Liu <sdl.web@gmail.com>
7287
7288 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
7289
5790543d
PE
72902012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7291
7292 * sysdep.c [__FreeBSD__]: Minor cleanups.
7293 (list_system_processes, system_process_attributes) [__FreeBSD__]:
7294 Use Emacs indenting style more consistently. Avoid some casts.
7295 Use 'double' consistently rather than mixing 'float' and 'double'.
7296
b91b7e4d
EW
72972012-04-21 Eduard Wiebe <usenet@pusto.de>
7298
b593d6a9
AH
7299 * sysdep.c (list_system_processes, system_process_attributes):
7300 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 7301
6114eb15
AS
73022012-04-21 Andreas Schwab <schwab@linux-m68k.org>
7303
7304 * lisp.mk (lisp): Update.
7305
2f38dff7
PE
73062012-04-20 Paul Eggert <eggert@cs.ucla.edu>
7307
7308 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
7309 It is never used otherwise.
7310
4ae29f89
SM
73112012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
7312
7313 * print.c (print_preprocess): Only check print_depth if print-circle
7314 is nil.
7315 (print_object): Check for cycles even when print-circle is nil and
7316 print-gensym is t, but only check print_depth if print-circle is nil.
7317
f30d612a
CY
73182012-04-20 Chong Yidong <cyd@gnu.org>
7319
7320 * process.c (wait_reading_process_output): If EIO occurs on a pty,
7321 set the status to "failed" and ensure that sentinel is run.
7322
c07a4c0b 73232012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
7324
7325 * process.c (Fset_process_inherit_coding_system_flag)
7326 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 7327 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 7328
c07a4c0b 73292012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
7330
7331 * xdisp.c (string_buffer_position_lim): Limit starting position to
7332 BEGV.
7333 (set_cursor_from_row): If called for a mode-line or header-line
7334 row, return zero immediately.
7335 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
7336 farther than the first row after the header line, if any.
7337 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
7338 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
7339
c07a4c0b 73402012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 7341
4ae29f89
SM
7342 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
7343 (bug#11238).
ad3a2b41 7344
c07a4c0b 73452012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 73462012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
7347
7348 configure: new option --enable-gcc-warnings (Bug#11207)
7349 * Makefile.in (C_WARNINGS_SWITCH): Remove.
7350 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
7351 (ALL_CFLAGS): Use new macros rather than old.
7352 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
7353 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
7354 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
7355 -Wunused-result, -Wunused-variable. This should go away once
7356 the Emacs and Gnulib regex code is merged.
7357 (xmalloc, xrealloc): Now static.
7358
aba027e8
PE
73592012-04-17 Paul Eggert <eggert@cs.ucla.edu>
7360
7361 * dired.c (Fsystem_groups): Remove unused local.
7362
e5a36063
GM
73632012-04-17 Glenn Morris <rgm@gnu.org>
7364
7365 * dired.c (Fsystem_users): Doc fix.
7366
316411f0
DA
73672012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
7368
7369 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
7370 (syms_of_dired): Add them.
7371
9426aba4
PE
73722012-04-16 Paul Eggert <eggert@cs.ucla.edu>
7373
b62a57be
PE
7374 Fix minor alloc.c problems found by static checking.
7375 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
7376 New extern decls, to avoid calling undeclared functions.
7377 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
7378 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
7379 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
7380 (NEED_MEM_INSERT): New macro.
7381 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 7382 Remove one incorrect comment and fix another.
b62a57be 7383
3539f31f
PE
7384 Fix minor ralloc.c problems found by static checking.
7385 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
7386 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
7387 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
7388 (r_alloc_sbrk): Now static.
7389
a041960a
PE
7390 Improve ralloc.c interface checking.
7391 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
7392 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
7393 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
7394 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
7395 [REL_ALLOC]: ... to here, to check interface.
7396 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
7397 Remove decls. This fixes an "It stinks!".
7398
9426aba4
PE
7399 * alloc.c (which_symbols): Fix alignment issue / type clash.
7400
d55c12ed
AS
74012012-04-15 Andreas Schwab <schwab@linux-m68k.org>
7402
7403 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
7404 (struct Lisp_Misc_Any): Likewise.
7405 (struct Lisp_Free): Likewise.
7406 * alloc.c (union aligned_Lisp_Symbol): Define.
7407 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
7408 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
7409 (union aligned_Lisp_Misc): Define.
7410 (MARKER_BLOCK_SIZE, struct marker_block): Use union
7411 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 7412 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 7413
b948ce8b
PE
74142012-04-14 Paul Eggert <eggert@cs.ucla.edu>
7415
7416 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
7417 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
7418 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
7419 * s/netbsd.h, s/sol2-6.h:
7420 Remove definition of GC_MARK_STACK, since the default now works.
7421 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
7422 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
7423 no longer the default.
7424 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
7425
35dc09a1 74262012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 7427
35dc09a1
GM
7428 * lread.c (lisp_file_lexically_bound_p):
7429 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 7430
35dc09a1
GM
74312012-04-14 Eli Zaretskii <eliz@gnu.org>
7432
7433 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
7434 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
7435
74362012-04-14 Jan Djärv <jan.h.d@swipnet.se>
7437
7438 * nsterm.m (constrainFrameRect): Always constrain when there is only
7439 one screen (Bug#10962).
7440
bcd86815
KB
74412012-04-13 Ken Brown <kbrown@cornell.edu>
7442
7443 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
7444
c25df26e
RT
74452012-04-13 Reuben Thomas <rrt@sc3d.org>
7446
7447 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
7448
0fc59f1e
DC
74492012-04-11 Daniel Colascione <dancol@dancol.org>
7450
7451 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
7452 against is gone. It's better to use vfork now so that when Cygwin
7453 gains a new, working vfork, we use it automatically (bug#10398).
7454
de8c03dc
SM
74552012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
7456
7457 * window.c (save_window_save): Obey window-point-insertion-type.
7458
2f097256
GM
74592012-04-11 Glenn Morris <rgm@gnu.org>
7460
7461 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
7462
453b951e
SM
74632012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
7464
7465 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
7466
75f1671a 74672012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
7468
7469 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
7470 (force_quit_count): New var.
7471 (handle_interrupt): Use it.
7472
2a8ce227
JB
74732012-04-10 Juanma Barranquero <lekktu@gmail.com>
7474
7475 * w32.c (w32_delayed_load): Record the full path of the library
7476 being loaded (bug#10424).
7477
935396c0
GM
74782012-04-09 Glenn Morris <rgm@gnu.org>
7479
05920a43
GM
7480 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
7481 not just in the obarray, before snarfing them. (Bug#11036)
7482
935396c0
GM
7483 * Makefile.in ($(leimdir)/leim-list.el):
7484 Pass EMACS rather than BUILT_EMACS.
7485
a18ecafa
TZ
74862012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
7487
7488 * process.c (make_process):
7489 * process.h: Add integer `gnutls_handshakes_tried' member to
7490 process struct.
7491
6bbef4e5
JC
7492 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
7493 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
7494
7495 * gnutls.c (gnutls_log_function2i): Convenience log function.
7496 (emacs_gnutls_read): Use new log functions,
7497 `gnutls_handshakes_tried' process member, and
7498 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
7499 attempts per process (connection).
7500
b4d3bc10
CY
75012012-04-09 Chong Yidong <cyd@gnu.org>
7502
7503 * eval.c (Fuser_variable_p, user_variable_p_eh)
7504 (lisp_indirect_variable): Functions deleted.
7505 (Fdefvar): Caller changed.
7506
7507 * callint.c (Finteractive, Fcall_interactively):
7508 * minibuf.c (Fread_variable): Callers changed.
7509
70f4d973
EZ
75102012-04-09 Eli Zaretskii <eliz@gnu.org>
7511
7512 * xdisp.c (set_cursor_from_row): If the display string appears in
7513 the buffer at position that is closer to point than the position
7514 after the display string, display the cursor on the first glyph of
7515 the display string. Fixes cursor display when a 'display' text
7516 property immediately follows invisible text. (Bug#11094)
7517
cb3c2e3e
PE
75182012-04-09 Paul Eggert <eggert@cs.ucla.edu>
7519
7520 composite.c: use 'double' consistently
7521 * composite.c (get_composition_id): Use 'double' consistently
7522 instead of converting 'float' to 'double' and vice versa; this is
7523 easier to understand and avoids a GCC warning.
7524
fd06db5d
GM
75252012-04-09 Glenn Morris <rgm@gnu.org>
7526
50fe702a
GM
7527 * Makefile.in: Generate leim-list with bootstrap-emacs, in
7528 preparation for dumping it with emacs. (Bug#4789)
7529 (leimdir): New variable.
7530 ($(leimdir)/leim-list.el): New rule.
7531 (emacs$(EXEEXT)): Depend on leim-list.el.
7532
fd06db5d
GM
7533 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
7534 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
7535 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
7536
55c131ee
AS
75372012-04-08 Andreas Schwab <schwab@linux-m68k.org>
7538
7539 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
7540 proper alignment.
7541
9209588f
JB
75422012-04-07 Juanma Barranquero <lekktu@gmail.com>
7543
7544 * xml.c (init_libxml2_functions) [WINDOWSNT]:
7545 Remove unused local variable.
7546
e3fb2efb
PE
75472012-04-07 Paul Eggert <eggert@cs.ucla.edu>
7548
7549 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
7550 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
7551 (mark_memory): Mark Lisp_Objects only if pointers might hide in
7552 objects, as mark_maybe_pointer will catch them otherwise.
7553 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
7554 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
7555
b5385551
PE
75562012-04-07 Paul Eggert <eggert@cs.ucla.edu>
7557
7558 Fix typo that broke non-Windows builds.
7559 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
7560
9078ead6
EZ
75612012-04-07 Eli Zaretskii <eliz@gnu.org>
7562
7563 Support building on MS-Windows with libxml2.
7564
7565 * makefile.w32-in (OBJ2): Add xml.$(O).
7566 (GLOBAL_SOURCES): Add xml.c.
7567 ($(BLD)/xml.$(O)): New dependency list.
7568
7569 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
7570 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
7571 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
7572 [!WINDOWSNT]: New macros.
7573 (init_libxml2_functions, libxml2_loaded_p): New functions.
7574 (parse_region): Call fn_xmlCheckVersion instead of using the macro
7575 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
7576 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
7577 Calls xmlCleanupParser only if libxml2 was loaded (or statically
7578 linked in).
6bbef4e5
JC
7579 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
7580 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
7581 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
7582
7583 * emacs.c: Don't include libxml/parser.h.
7584 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
7585 xmlCleanupParser directly.
7586
7587 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
7588
3811fdf3
EZ
75892012-04-07 Eli Zaretskii <eliz@gnu.org>
7590
7591 * indent.c (Fvertical_motion): If there is a display string at
7592 point, use it.vpos to compute how many lines to backtrack after
7593 move_it_to point. (Bug#11133)
7594
2f8e16b2
EZ
75952012-04-06 Eli Zaretskii <eliz@gnu.org>
7596
7597 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
7598 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
7599 about subtle differences between FETCH_CHAR* and STRING_CHAR*
7600 macros related to unification of CJK characters. For the details,
7601 see the discussion following the message here:
7602 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
7603
3d439cd1
CY
76042012-04-04 Chong Yidong <cyd@gnu.org>
7605
7606 * keyboard.c (Vdelayed_warnings_list): Doc fix.
7607
8bc53d00
EZ
76082012-04-01 Eli Zaretskii <eliz@gnu.org>
7609
7610 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
7611 instead of alloca. (Bug#11138)
7612
3b0512a3
AS
76132012-04-01 Andreas Schwab <schwab@linux-m68k.org>
7614
7615 * w32menu.c (is_simple_dialog): Properly check lisp types.
7616 (Bug#11141)
7617
8427ddd2
EZ
76182012-03-31 Eli Zaretskii <eliz@gnu.org>
7619
979022ef
EZ
7620 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
7621 position we get to after a call to move_it_to fails the
7622 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
7623 only if we wind up in a string from display property. (Bug#11063)
7624
a6b1c7cc
EZ
7625 * window.c (Fdelete_other_windows_internal): Invalidate the row
7626 and column information about mouse highlight, so that redisplay
7627 restores it after reallocating the glyph matrices. (Bug#7464)
7628
8427ddd2
EZ
7629 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
7630 string comes from a `display' text property, use the buffer
7631 position of that property as if we actually saw that position in
7632 the row's glyphs.
697ba24b
EZ
7633 (move_it_by_lines): Remove the assertion that
7634 "it->current_x == 0 && it->hpos == 0" which can be legitimately
7635 violated when there's a before-string at the beginning of a line.
7636 (Bug#11063)
8427ddd2 7637
65a0a738
EZ
76382012-03-30 Eli Zaretskii <eliz@gnu.org>
7639
7640 * xdisp.c (append_space_for_newline): If the default face was
7641 remapped, use the remapped face for the appended newline.
7642 (extend_face_to_end_of_line): Use the remapped default face for
7643 extending the face to the end of the line.
7644 (display_line): Call extend_face_to_end_of_line when the default
7645 face was remapped. (Bug#11068)
7646
581355cc
EZ
76472012-03-29 Eli Zaretskii <eliz@gnu.org>
7648
7649 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
7650
e8fc049f
SM
76512012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7652
7653 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
7654
4fb9a543
GM
76552012-03-27 Glenn Morris <rgm@gnu.org>
7656
7657 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
7658 Doc fixes.
7659
679910f1
KH
76602012-03-26 Kenichi Handa <handa@m17n.org>
7661
7662 * dispextern.h (struct glyph): Fix previous change. Change the
7663 bit length of glyphless.ch to 25 (Bug#11082).
7664
90d49b7f
CY
76652012-03-26 Chong Yidong <cyd@gnu.org>
7666
7667 * keyboard.c (Vselection_inhibit_update_commands): New variable.
7668 (command_loop_1): Use it; inhibit selection update for
7669 handle-select-window too (Bug#8996).
7670
f514f6f0
FP
76712012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
7672
e8fc049f 7673 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 7674
bf43fa51
KH
76752012-03-25 Kenichi Handa <handa@m17n.org>
7676
7677 * dispextern.h (struct glyph): Change the bit length of
7678 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
7679
8a0c01dd
EZ
76802012-03-24 Eli Zaretskii <eliz@gnu.org>
7681
7682 * s/ms-w32.h (tzname): Include time.h before redirecting to
7683 _tzname. Fixes the MSVC build. (Bug#9960)
7684
7d1c3a76
AS
76852012-03-24 Andreas Schwab <schwab@linux-m68k.org>
7686
8ed79523
AS
7687 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
7688 characters.
7689
7d1c3a76
AS
7690 * xterm.c (XTread_socket): Only modify handling_signal if
7691 !SYNC_INPUT. (Bug#11080)
7692
e99a9b8b
EZ
76932012-03-23 Eli Zaretskii <eliz@gnu.org>
7694
7695 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
7696 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
7697 when fetching a multibyte character consumes more bytes than
7698 CHAR_BYTES returns, due to unification of CJK characters in
7699 string_char. (Bug#11073)
7700
5063c0e1
TN
77012012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
7702
7703 * process.c (wait_reading_process_output): Handle pty disconnect
7704 by refraining from sending oneself a SIGCHLD (bug#10933).
7705
9f851fbd
CY
77062012-03-22 Chong Yidong <cyd@gnu.org>
7707
7708 * dispextern.h (struct it): New member string_from_prefix_prop_p.
7709
5063c0e1 7710 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
7711 Mark string as coming from a prefix property.
7712 (handle_face_prop): Use default face for prefix strings (Bug#4281).
7713 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
7714
fb5b8aca
CY
77152012-03-21 Chong Yidong <cyd@gnu.org>
7716
7717 * xfaces.c (Vface_remapping_alist): Doc fix.
7718
62356a1b
EZ
77192012-03-20 Eli Zaretskii <eliz@gnu.org>
7720
7721 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
7722 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
7723 Doc fixes.
62356a1b 7724
025de85b
CY
77252012-03-20 Chong Yidong <cyd@gnu.org>
7726
7727 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
7728 to reflect default non-nil value of redisplay-dont-pause.
7729
4827f94e
KH
77302012-03-19 Kenichi Handa <handa@m17n.org>
7731
7732 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
7733 it fit in a valid range (Bug#11003).
7734
e50a24a2
EZ
77352012-03-18 Eli Zaretskii <eliz@gnu.org>
7736
7737 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
7738 that is not from display property, accept the row as a "cursor
7739 row" if one of the string's character has a non-nil `cursor'
7740 property. Fixes cursor positioning when there are newlines in
7741 overlay strings, e.g. in icomplete.el. (Bug#11035)
7742
9af5ed87
PE
77432012-03-12 Paul Eggert <eggert@cs.ucla.edu>
7744
7745 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
7746
d1f55f16
CY
77472012-03-12 Chong Yidong <cyd@gnu.org>
7748
7749 * eval.c (inhibit_lisp_code): Rename from
7750 inhibit_window_configuration_change_hook; move from window.c.
7751
7752 * xfns.c (unwind_create_frame_1, Fx_create_frame):
7753 * window.c (run_window_configuration_change_hook)
7754 (syms_of_window): Callers changed.
7755
66c5eebd
CY
77562012-03-11 Chong Yidong <cyd@gnu.org>
7757
413df973
CY
7758 * keymap.c (Fkey_description): Doc fix (Bug#9700).
7759
66c5eebd
CY
7760 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
7761
1de11f56
CY
77622012-03-10 Chong Yidong <cyd@gnu.org>
7763
7764 * frame.c (other_visible_frames): Don't assume the selected frame
7765 is visible (Bug#10955).
7766
cae07000
SM
77672012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
7768
7769 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
7770
89c94350
JD
77712012-03-08 Jan Djärv <jan.h.d@swipnet.se>
7772
7773 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
7774 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
7775 zero (Bug#10954).
7776
999dd333
GM
77772012-03-03 Glenn Morris <rgm@gnu.org>
7778
01a6dcc8 7779 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 7780
de0100f2
EZ
77812012-03-02 Eli Zaretskii <eliz@gnu.org>
7782
7783 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
7784 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
7785 (redisplay_window, next_element_from_string): Fix typos in
7786 comments.
3e441275
EZ
7787 (redisplay_window): Pass to move_it_vertically the margin in
7788 pixels, not in screen lines.
de0100f2 7789
96a72ee9
GM
77902012-03-02 Glenn Morris <rgm@gnu.org>
7791
7792 * buffer.c (buffer-list-update-hook): Doc fix.
7793
312508d7
EZ
77942012-02-29 Eli Zaretskii <eliz@gnu.org>
7795
7796 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
7797 push_it before setting up the iterator for the first overlay
7798 string, even if we have an empty string loaded.
7799 (next_overlay_string): If there's an empty string on the iterator
7800 stack, pop the stack. (Bug#10903)
7801
27f3c637
PE
78022012-02-25 Paul Eggert <eggert@cs.ucla.edu>
7803
7804 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
7805 Suggested by Stefan Monnier in
7806 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
7807 * alloc.c (widen_to_Lisp_Object): New static function.
7808 (mark_memory): Also mark Lisp_Objects by fetching pointer words
7809 and widening them to Lisp_Objects. This would work even if
7810 USE_LSB_TAG is defined and wide integers are used, which might
7811 happen in a future version of Emacs.
7812
3c9dfce6
CY
78132012-02-25 Chong Yidong <cyd@gnu.org>
7814
fa74b241
CY
7815 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
7816 Doc fix.
7817
3c9dfce6
CY
7818 * xselect.c (Fx_selection_exists_p): Doc fix.
7819 (x_clipboard_manager_save_all): Print an informative message
7820 before saving to clipboard manager.
7821
9486df08
CY
78222012-02-24 Chong Yidong <cyd@gnu.org>
7823
7824 * keyboard.c (process_special_events): Handle all X selection
7825 requests in kbd_buffer, not just the next one (Bug#8869).
7826
f01d3321
CY
78272012-02-23 Chong Yidong <cyd@gnu.org>
7828
7829 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
7830 call when setting menu-bar-lines and tool-bar-lines parameters.
7831 (unwind_create_frame_1): New helper function.
7832
7833 * window.c (inhibit_window_configuration_change_hook): New var.
7834 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 7835 (syms_of_window): Initialize it.
f01d3321 7836
86b847b6
CY
78372012-02-22 Chong Yidong <cyd@gnu.org>
7838
7839 * xterm.c (x_draw_image_relief): Add missing type check for
7840 Vtool_bar_button_margin (Bug#10743).
7841
a59225b1
CY
78422012-02-21 Chong Yidong <cyd@gnu.org>
7843
7844 * fileio.c (Vfile_name_handler_alist): Doc fix.
7845
7846 * buffer.c (Fget_file_buffer): Protect against invalid file
7847 handler return value.
7848
310f5bd4
PE
78492012-02-20 Paul Eggert <eggert@cs.ucla.edu>
7850
cb3a28cc
PE
7851 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
7852 when computing $valmask.
7853
310f5bd4
PE
7854 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
7855 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
7856 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
7857 It's useless in that case, and it can cause problems on hosts
7858 that allocate halves of EMACS_INT values separately.
7859 Reported by Dan Horák. Diagnosed by Andreas Schwab in
7860 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
7861 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
7862 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
7863 it avoids undefined behavior on hosts where shifting right by more
7864 than the word width has undefined behavior.
7865
2375c96a
CY
78662012-02-19 Chong Yidong <cyd@gnu.org>
7867
7868 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
7869 (Funhandled_file_name_directory, Ffile_name_as_directory)
7870 (Fdirectory_file_name, Fexpand_file_name)
7871 (Fsubstitute_in_file_name): Protect against invalid file handler
7872 return values (Bug#10845).
7873
3eb49e71
EZ
78742012-02-18 Eli Zaretskii <eliz@gnu.org>
7875
7876 * .gdbinit (pitx): Fix incorrect references to fields of the
7877 iterator stack.
7878
7b926f3f
CY
78792012-02-17 Chong Yidong <cyd@gnu.org>
7880
7881 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
7882
11273115
PE
78832012-02-15 Paul Eggert <eggert@cs.ucla.edu>
7884
7885 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
7886 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
7887
c3a70e2b
CY
78882012-02-15 Chong Yidong <cyd@gnu.org>
7889
7890 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
7891 marked as special. Also, starting docstrings with * is obsolete.
7892
0ca43699
AS
78932012-02-13 Andreas Schwab <schwab@linux-m68k.org>
7894
7895 * gnutls.c (emacs_gnutls_write): Fix last change.
7896
2e8f3c56
LI
78972012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
7898
7899 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
7900 send_process.
7901
af70074f
SM
79022012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
7903
7904 * keymap.c (Fsingle_key_description): Handle char ranges.
7905
95986d52
CY
79062012-02-12 Chong Yidong <cyd@gnu.org>
7907
afd83bd1
CY
7908 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
7909 as that creates a dangerous corner case.
7910
95986d52
CY
7911 * window.c (Fdelete_window_internal): Invalidate the mouse
7912 highlight (Bug#9904).
7913
bd7da63e
GM
79142012-02-12 Glenn Morris <rgm@gnu.org>
7915
7916 * xselect.c (Fx_own_selection_internal)
7917 (Fx_get_selection_internal, Fx_disown_selection_internal)
7918 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
7919 * nsselect.m (Fx_own_selection_internal)
7920 (Fx_disown_selection_internal, Fx_selection_exists_p)
7921 (Fx_selection_owner_p, Fx_get_selection_internal):
7922 Sync docs and argument specs with the xselect.c versions.
7923
77abcbc2
LI
79242012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
7925
7926 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
7927
90b671e2
EZ
79282012-02-11 Eli Zaretskii <eliz@gnu.org>
7929
1c0ca0b7
EZ
7930 * w32select.c (Fx_selection_exists_p): Sync doc string and
7931 argument list with xselect.c. (Bug#10783)
7932
7933 * w16select.c (Fx_selection_exists_p): Sync doc string and
7934 argument list with xselect.c. (Bug#10783)
90b671e2 7935
49241268
GM
79362012-02-10 Glenn Morris <rgm@gnu.org>
7937
7938 * fns.c (Fsecure_hash): Doc fix.
7939
f998bbe7 79402012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
7941
7942 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
7943
0992bd9c
CY
79442012-02-07 Chong Yidong <cyd@gnu.org>
7945
7946 * buffer.c (Fbuffer_local_variables)
7947 (buffer_lisp_local_variables): Handle unbound vars correctly;
7948 don't let Qunbound leak into Lisp.
7949
af008560
GM
79502012-02-07 Glenn Morris <rgm@gnu.org>
7951
dd605cc4
GM
7952 * image.c (Fimagemagick_types): Doc fix.
7953
af008560
GM
7954 * image.c (imagemagick-render-type): Change it from a lisp object
7955 to an integer. Move the doc here from the lisp manual.
7956 Treat all values not equal to 0 the same.
7957
1449fa1d
CY
79582012-02-06 Chong Yidong <cyd@gnu.org>
7959
7960 * doc.c (store_function_docstring): Avoid applying docstring of
7961 alias to base function (Bug#2603).
7962
3723ec07
AS
79632012-02-04 Andreas Schwab <schwab@linux-m68k.org>
7964
7965 * .gdbinit (pp1, pv1): Remove redundant defines.
7966 (pr): Use pp.
7967
79c1cc1e
CY
79682012-02-04 Chong Yidong <cyd@gnu.org>
7969
7970 * nsterm.m: Declare a global (Bug#10694).
7971
d7f29f8e
EZ
79722012-02-04 Eli Zaretskii <eliz@gnu.org>
7973
cae07000
SM
7974 * w32.c (get_emacs_configuration_options):
7975 Include --enable-checking, if specified, in the return value.
d7f29f8e 7976
3b95a6f9
MR
79772012-02-04 Martin Rudalics <rudalics@gmx.at>
7978
7979 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
7980 after rounding frame sizes. (Bug#9723)
7981
d6fa96a6
EZ
79822012-02-04 Eli Zaretskii <eliz@gnu.org>
7983
7984 * keyboard.c (adjust_point_for_property): Don't position point
7985 before BEGV. (Bug#10696)
7986
df0b2940
PE
79872012-02-03 Paul Eggert <eggert@cs.ucla.edu>
7988
7989 Handle overflow when computing char display width (Bug#9496).
7990 * character.c (char_width): Return EMACS_INT, not int.
7991 (char_width, c_string_width): Check for overflow when
7992 computing the width; this is possible now that individual
7993 characters can have unbounded width. Problem introduced
7994 by merge from Emacs 23 on 2012-01-19.
7995
6bee44d6
MA
79962012-02-02 Michael Albinus <michael.albinus@gmx.de>
7997
7998 * dbusbind.c (Fdbus_register_method): Mention the return value
7999 :ignore in the docstring.
8000
44f92739
GM
80012012-02-02 Glenn Morris <rgm@gnu.org>
8002
1b9f60cc
GM
8003 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
8004
44f92739
GM
8005 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8006 Unconditionally set to t. (Bug#10673)
8007 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8008 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
8009 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
8010
c5d3843c
KH
80112012-02-02 Kenichi Handa <handa@m17n.org>
8012
8013 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
8014 0, do not call append_composite_glyph.
8015
159462d4 80162012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
8017
8018 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
8019 NULL (Bug#6988).
8020 (x_produce_glyphs): If the component of a composition is a null
8021 string, set it->pixel_width to 1 to avoid zero-width glyph.
8022
78cef877
EZ
80232012-02-01 Eli Zaretskii <eliz@gnu.org>
8024
8025 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
8026 first 2 arguments are identical. This makes inserting large
8027 output from a subprocess an order of magnitude faster on
8028 MS-Windows, where all sbrk'ed memory is always contiguous.
8029
97897668
GM
80302012-01-31 Glenn Morris <rgm@gnu.org>
8031
8032 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 8033 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
8034 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
8035
31fd3586
GM
80362012-01-29 Glenn Morris <rgm@gnu.org>
8037
8038 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
8039
0e24a8b2
CY
80402012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
8041
8042 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
8043
cc0adcb0
CY
80442012-01-28 Chong Yidong <cyd@gnu.org>
8045
8046 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
8047
acc28cb9
CY
80482012-01-26 Chong Yidong <cyd@gnu.org>
8049
9c69cfb7
CY
8050 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
8051
acc28cb9
CY
8052 * search.c (Fsearch_forward, Fsearch_backward): Document negative
8053 repeat counts (Bug#10507).
8054
48da7392
GM
80552012-01-26 Glenn Morris <rgm@gnu.org>
8056
8057 * lread.c (syms_of_lread): Doc fix.
8058
14af5f7f
CY
80592012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
8060
8061 * coding.c (encode_designation_at_bol): Change return value to
8062 EMACS_INT.
8063
0b21c100
CY
80642012-01-25 Chong Yidong <cyd@gnu.org>
8065
8066 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
8067
3c2907f7
CY
80682012-01-21 Chong Yidong <cyd@gnu.org>
8069
8070 * floatfns.c (Fcopysign): Make the second argument non-optional,
8071 since nil is not allowed anyway.
8072
959ad23f
AS
80732012-01-21 Andreas Schwab <schwab@linux-m68k.org>
8074
8075 * process.c (read_process_output): Use p instead of XPROCESS (proc).
8076 (send_process): Likewise.
8077
34a02f46
MR
80782012-01-19 Martin Rudalics <rudalics@gmx.at>
8079
8080 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
8081 (Vwindow_persistent_parameters): Do not use Qstate.
8082 Rewrite doc-strings.
34a02f46 8083
1259009a 80842012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
8085
8086 * character.c (char_width): New function.
70d4fdf6
GM
8087 (Fchar_width, c_string_width, lisp_string_width):
8088 Use char_width (Bug#9496).
25ed9e61 8089
6a6ee00d
MR
80902012-01-16 Martin Rudalics <rudalics@gmx.at>
8091
8092 * window.c (Vwindow_persistent_parameters): New variable.
8093 (Fset_window_configuration, save_window_save): Handle persistent
8094 window parameters.
8095
c85efaf7
EZ
80962012-01-14 Eli Zaretskii <eliz@gnu.org>
8097
8098 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
8099 thrashing the stack of the thread. (Bug#9087)
8100
5944709e
PE
81012012-01-12 Paul Eggert <eggert@cs.ucla.edu>
8102
8103 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
8104
e71f5d99
EZ
81052012-01-11 Eli Zaretskii <eliz@gnu.org>
8106
8107 * xdisp.c (rows_from_pos_range): Handle the case where the
8108 highlight ends on a newline. (Bug#10464)
8109 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
8110 he end column for display of highlight that ends on a newline
8111 before a R2L line.
8112
ce316182
GM
81132012-01-11 Glenn Morris <rgm@gnu.org>
8114
8115 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
8116 from load-path also when installation-directory is nil. (Bug#10208)
8117
5b43da69
GM
81182012-01-10 Glenn Morris <rgm@gnu.org>
8119
74cc8ff9
GM
8120 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
8121
7d8d6e4e
GM
8122 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
8123 Update template values to be closer to their typical values these days.
5b43da69 8124
a0db8d43
EZ
81252012-01-09 Eli Zaretskii <eliz@gnu.org>
8126
8127 * xdisp.c (rows_from_pos_range): Accept additional argument
8128 DISP_STRING, and accept any glyph in a row whose object is that
8129 string as eligible for mouse highlight. Fixes mouse highlight of
8130 display strings from overlays. (Bug#10464)
8131
9a0115ab 81322012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 8133
b9110d6a 8134 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
8135 * fileio.c (auto_saving_dir_umask): New static var.
8136 (Fmake_directory_internal): Use it.
8137 (do_auto_save_make_dir): Set it, instead of invoking chmod after
8138 creating the directory. The old code temporarily assigns
8139 too-generous permissions to the directory.
8140 (do_auto_save_eh): Clear it.
b9110d6a 8141 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
8142 that the var is always cleared.
8143
6c1bd3f3
EZ
81442012-01-07 Eli Zaretskii <eliz@gnu.org>
8145
8146 * search.c (scan_buffer): Pass character positions to
8147 know_region_cache, not byte positions. (Bug#6540)
8148
069d2b50
L
81492012-01-07 LynX <_LynX@bk.ru> (tiny change)
8150
8151 * w32.c (sys_rename): Report EXDEV when rename of a directory
8152 fails because the target is on another logical disk. (Bug#10284)
8153
75bf0d33
DB
81542012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
8155
8156 * xterm.c (x_embed_request_focus): New function.
8157
8158 * xterm.h: Add prototype.
8159
8160 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
8161
1c6e5a32
GM
81622012-01-05 Glenn Morris <rgm@gnu.org>
8163
8164 * emacs.c (emacs_copyright): Update short copyright year to 2012.
8165
651e947e
EZ
81662012-01-01 Eli Zaretskii <eliz@gnu.org>
8167
8168 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
8169 Load gnutls_transport_set_lowat only if GnuTLS version is below
8170 2.11.1.
8171 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
8172 GnuTLS versions below 2.11.1.
8173
3778cdd8
AL
81742011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
8175
8176 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
8177 to the doc string advising against its use for altering the way
8178 windows are scrolled.
8179
0e5317f7
KH
81802011-12-28 Kenichi Handa <handa@m17n.org>
8181
8182 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
8183 coding-system ASCII compatible only when it does not produce BOM
8184 on encoding (Bug#10383).
8185
93d5ca1f
JD
81862011-12-26 Jan Djärv <jan.h.d@swipnet.se>
8187
8188 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
8189 can scroll.
8190 (create_and_show_popup_menu): Always use menu_position_func for
8191 Gtk3 (Bug#10361).
8192
ca22b785
AS
81932011-12-24 Andreas Schwab <schwab@linux-m68k.org>
8194
8195 * callint.c (Fcall_interactively): Don't truncate prompt string.
8196
d048e1e6
EZ
81972011-12-23 Eli Zaretskii <eliz@gnu.org>
8198
8199 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
8200 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 8201 resumed from there (after widening). (Bug#10360)
d048e1e6 8202
5ccaba1f
JD
82032011-12-22 Jan Djärv <jan.h.d@swipnet.se>
8204
8205 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
8206
204ee57f
JD
82072011-12-21 Jan Djärv <jan.h.d@swipnet.se>
8208
b81d40f0
JB
8209 * nsterm.m (x_free_frame_resources):
8210 Release f->output_data.ns->miniimage.
204ee57f
JD
8211 (ns_index_color): Fix indentation. Do not retain
8212 color_table->colors[i].
8213
8214 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
8215 before returning.
8216
8217 * nsfns.m (x_set_background_color): Assign return value from
8218 ns_index_color to face-background instead of NSColor*.
8219 (ns_implicitly_set_icon_type): Fix indentation.
8220 Change assignment in for loop to comparison.
8221
8222 * emacs.c (ns_pool): New variable.
8223 (main): Assign ns_pool.
8224 (Fkill_emacs): Call ns_release_autorelease_pool.
8225
8226 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
8227 autorelease fdesc, release fdAttrs and tdict.
8228 (ns_get_covering_families): Release charset.
8229 (ns_findfonts): Release NSFontDescriptor created with new.
8230 (ns_uni_to_glyphs): Fix indentation.
8231 (setString): Release attrStr before assigning new value.
8232
c803b2b7
JD
82332011-12-18 Jan Djärv <jan.h.d@swipnet.se>
8234
678f4426
JD
8235 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
8236 and NS_IMPL_COCOA.
8237 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
8238 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
8239
cd394be1 82402011-12-18 David Reitter <reitter@cmu.edu>
678f4426 8241
5fecd5fc
JD
8242 * nsterm.m (ns_term_init): Subscribe for notifications
8243 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
8244 to method trackingNotification in EmacsMenu.
8245
8246 * nsmenu.m (trackingMenu): New variable.
3771cb17 8247 (trackingNotification): New method (from Aquamacs).
5fecd5fc 8248 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 8249 from Aquamacs (Bug#7030).
678f4426
JD
8250
82512011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 8252
c803b2b7
JD
8253 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
8254 (symbol_to_nsstring): Fix indentation.
8255 (ns_symbol_to_pb): New function.
cae07000
SM
8256 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
8257 (Fns_rotate_cut_buffers_internal): Remove.
8258 (Fns_store_selection_internal): Rename from
c803b2b7
JD
8259 Fns_store_cut_buffer_internal.
8260 (ns_get_foreign_selection, Fx_own_selection_internal)
8261 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
8262 (Fns_get_selection_internal, Fns_store_selection_internal):
8263 Use ns_symbol_to_pb and check if return value is nil.
8264 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
8265 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
8266 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
8267 renamed to Sns_store_selection_internal.
8268 (ns_handle_selection_request): Move code to Fx_own_selection_internal
8269 and remove this function.
8270 (ns_handle_selection_clear): Remove, never used.
8271 (Fx_own_selection_internal): Move code from ns_handle_selection_request
8272 here.
8273
e1b01a3a
KB
82742011-12-17 Ken Brown <kbrown@cornell.edu>
8275
8276 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
8277 GID is unknown (Bug#10257).
8278
2adb6e85
PE
82792011-12-17 Paul Eggert <eggert@cs.ucla.edu>
8280
8281 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
8282 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
8283 which caused a build failure on GNU/Linux IA-64. This problem was
8284 introduced by my 2011-10-07 patch.
8285
d1d7b339
JL
82862011-12-15 Juri Linkov <juri@jurta.org>
8287
8288 * image.c (imagemagick_error): New function. (Bug#10112)
8289 (imagemagick_load_image): Comment out `MagickSetResolution' call.
8290 Use `imagemagick_error' where ImageMagick functions return
8291 `MagickFalse'.
8292 (Fimagemagick_types): Add `Fnreverse' to return the list in the
8293 proper order.
8294
100d5755
KH
82952011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8296
8297 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
8298 fill background (Bug#8992).
8299
454592a6
MR
83002011-12-13 Martin Rudalics <rudalics@gmx.at>
8301
8302 * window.c (Vwindow_combination_resize)
8303 (Vwindow_combination_limit): Use t instead of non-nil in
8304 doc-strings.
61d4b438
MR
8305 (Vrecenter_redisplay): Add first sentence of doc-string on
8306 separate line.
53524d93 8307 (Frecenter): Fix doc-string typo.
454592a6 8308
3633e3aa
KH
83092011-12-11 Kenichi Handa <handa@m17n.org>
8310
8311 * coding.c (Funencodable_char_position): Pay attention to the
8312 buffer text relocation (Bug#9389).
8313
7b9d523a 83142011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 8315
7b9d523a
JD
8316 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
8317 gtk_init (Bug#10100).
8318
b73189c6
EZ
83192011-12-10 Eli Zaretskii <eliz@gnu.org>
8320
8321 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
8322 IT->string is nil. (Bug#10263)
8323
f7dfe5d6
JD
83242011-12-10 Jan Djärv <jan.h.d@swipnet.se>
8325
83faebb4
JD
8326 * nsterm.h (x_free_frame_resources): Declare.
8327
f7dfe5d6
JD
8328 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
8329 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
8330
8331 * nsterm.h (ns_get_defaults_value): Declare.
8332
8333 * nsterm.m (ns_default): Call ns_get_defaults_value.
8334
7cd4e72c
EZ
83352011-12-09 Eli Zaretskii <eliz@gnu.org>
8336
8337 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
8338 (Bug#10170)
8339
b34d7317
YM
83402011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8341
8342 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
8343 that where the value of an _OBJC_* symbol points to is in the .bss
8344 section (Bug#10240).
8345
76470ad1
KH
83462011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
8347
8348 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 8349 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 8350
745fff94
KH
83512011-12-08 Kenichi Handa <handa@m17n.org>
8352
8353 * ftfont.c (get_adstyle_property): Fix previous change
8354 (Bug#10233).
8355
6e44397c
JB
83562011-12-07 Juanma Barranquero <lekktu@gmail.com>
8357
8358 * w32.c (init_environment): If no_site_lisp, remove site-lisp
8359 dirs from the default value of EMACSLOADPATH (bug#10208).
8360
7efa6272
GM
83612011-12-07 Glenn Morris <rgm@gnu.org>
8362
8363 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
8364 installation and source directories as well. (Bug#10208)
8365
f6fc4d87
CY
83662011-12-06 Chong Yidong <cyd@gnu.org>
8367
8368 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
8369
2bf26180
GM
83702011-12-06 Glenn Morris <rgm@gnu.org>
8371
8372 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
8373 as an error, not just -1. (Bug#10217)
8374
3a6ad4f0
CY
83752011-12-05 Chong Yidong <cyd@gnu.org>
8376
8377 * keyboard.c (process_special_events): New function.
8378 (swallow_events, Finput_pending_p): Use it (Bug#10195).
8379
75a3b399
PE
83802011-12-05 Paul Eggert <eggert@cs.ucla.edu>
8381
8382 * coding.c (encode_designation_at_bol): Don't use uninitialized
8383 local variable (Bug#9318).
8384
c3c9e25e
KH
83852011-12-05 Kenichi Handa <handa@m17n.org>
8386
8387 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
8388 return Qnil (Bug#8046, Bug#10193).
8389
5eb05ea3
KH
83902011-12-05 Kenichi Handa <handa@m17n.org>
8391
8392 * coding.c (encode_designation_at_bol): New args charbuf_end and
8393 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
8394 (coding_set_source): Return how many bytes coding->source was
8395 relocated.
8396 (coding_set_destination): Return how many bytes
8397 coding->destination was relocated.
8398 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 8399 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
8400
84012011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
8402
8403 * coding.c (CODING_CHAR_CHARSET_P): New macro.
8404 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
8405 macro (Bug#9318).
8406
84072011-12-05 Andreas Schwab <schwab@linux-m68k.org>
8408
8409 The following changes are to fix Bug#9318.
8410
a79703f5 8411 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
8412 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
8413 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 8414 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 8415
7dbda6df
JB
84162011-12-05 Juanma Barranquero <lekktu@gmail.com>
8417
8418 * lisp.h (process_quit_flag): Fix external declaration.
8419
6d5eb5b0
SM
84202011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
8421
8422 Don't macro-inline non-performance-critical code.
8423 * eval.c (process_quit_flag): New function.
8424 * lisp.h (QUIT): Use it.
8425
a0c3fad0
JD
84262011-12-04 Jan Djärv <jan.h.d@swipnet.se>
8427
8428 * nsfns.m (get_geometry_from_preferences): New function.
8429 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
8430
6c07aac2
AS
84312011-12-04 Andreas Schwab <schwab@linux-m68k.org>
8432
8433 * emacs.c (Qkill_emacs): Define.
8434 (syms_of_emacs): Initialize it.
8435 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
8436 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
8437 (quit_throw_to_read_char): Add parameter `from_signal'.
8438 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
8439 * lisp.h (QUIT): Call Fkill_emacs if requested.
8440
c052ead4
JD
84412011-12-03 Jan Djärv <jan.h.d@swipnet.se>
8442
8443 * widget.c (update_wm_hints): Return if wmshell is null.
8444 (widget_update_wm_size_hints): New function.
8445
8446 * widget.h (widget_update_wm_size_hints): Declare.
8447
8448 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
8449 widget_update_wm_size_hints (Bug#10104).
8450
9e49252b
EZ
84512011-12-03 Eli Zaretskii <eliz@gnu.org>
8452
8453 * xdisp.c (handle_invisible_prop): If the invisible text ends just
8454 before a newline, prepare the bidi iterator for consuming the
8455 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 8456 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 8457
02b16839
JL
84582011-12-02 Juri Linkov <juri@jurta.org>
8459
8460 * search.c (Fword_search_regexp): New Lisp function created from
8461 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
8462 (Fword_search_backward, Fword_search_forward)
8463 (Fword_search_backward_lax, Fword_search_forward_lax):
8464 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
8465 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
8466
0068070e
SM
84672011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
8468
8469 * fileio.c (Finsert_file_contents): Move after-change-function call
8470 to before the "handled:" label, since all "goto handled" appear in
8471 cases where the *-change-functions have already been properly called
8472 (bug#10117).
8473
3360a3fc
AS
84742011-12-01 Andreas Schwab <schwab@linux-m68k.org>
8475
8476 * keyboard.c (interrupt_signal): Don't call kill-emacs when
8477 waiting for input. (Bug#10169)
8478
73d6c093
EZ
84792011-11-30 Eli Zaretskii <eliz@gnu.org>
8480
8481 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
8482 verifies glyph row's hash code--we have just reallocated the
8483 glyphs, so their contents can be complete garbage. (Bug#10164)
8484
febe6bea
JB
84852011-11-30 Juanma Barranquero <lekktu@gmail.com>
8486
8487 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
8488
801a4313
EZ
84892011-11-30 Eli Zaretskii <eliz@gnu.org>
8490
8491 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
8492 attributes are tested _before_ calling verify_row_hash, to protect
8493 against GCC re-ordering of the tests. (Bug#10164)
8494
2b56b87e
JD
84952011-11-29 Jan Djärv <jan.h.d@swipnet.se>
8496
8497 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
8498
8499 * xterm.c (handle_one_xevent): Only set async_visible and friends
8500 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 8501 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
8502 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
8503
dbf31225
PE
85042011-11-28 Paul Eggert <eggert@cs.ucla.edu>
8505
8506 Remove GCPRO-related macros that exist only to avoid shadowing locals.
8507 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
8508 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
8509 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
8510 All uses changed to use GCPRO1 etc.
8511 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
8512 Revert to old implementation (i.e., before 2011-03-11).
8513
1305621b
YM
85142011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8515
8516 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
8517 of scroll runs so as to avoid assigning disabled bogus rows and
8518 unnecessary graphics copy operations.
8519
8c9afb46
EZ
85202011-11-27 Eli Zaretskii <eliz@gnu.org>
8521
8522 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
8523 (snprintf) [_MSC_VER]: Redirect to _snprintf.
8524 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
8525 (malloc, free, realloc, calloc): Redirect to e_* only when
8526 compiling Emacs.
8527
8528 * lisp.h (GCTYPEBITS): Move before first use.
8529 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
8530 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
8531 this macro definition.
8532
8533 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
8534 _MSC_VER.
8535
54e9e3bf
JD
85362011-11-27 Jan Djärv <jan.h.d@swipnet.se>
8537
6d5eb5b0
SM
8538 * gtkutil.c (xg_create_frame_widgets):
8539 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
8540 present with Gtk+ 2.0.
8541
83aca1cb
PE
85422011-11-26 Paul Eggert <eggert@cs.ucla.edu>
8543
8544 * fileio.c (Finsert_file_contents): Undo previous change; see
8545 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
8546
5b76caa4
PE
85472011-11-26 Paul Eggert <eggert@cs.ucla.edu>
8548
8549 Rename locals to avoid shadowing.
8550 * fileio.c (Finsert_file_contents):
8551 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
8552 * process.c (wait_reading_process_output):
8553 Rename inner 'proc' to 'p' to avoid shadowing.
8554 Indent for consistency with usual Emacs style.
8555
8c535114
EZ
85562011-11-25 Eli Zaretskii <eliz@gnu.org>
8557
8558 * xdisp.c (redisplay_window): If cursor row is not fully visible
8559 after recentering, and scroll-conservatively is set to a large
8560 number, scroll window by a few more lines to make the cursor fully
8561 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
8562 (start_display): Don't move to the next line if the display should
8563 start at a newline that is part of a display vector or an overlay
8564 string. (Bug#10119)
8c535114 8565
fa4fdb5c
JL
85662011-11-24 Juri Linkov <juri@jurta.org>
8567
8568 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
8569 after the `MagickPingImage' call. (Bug#10112)
8570
90ec88df
CY
85712011-11-23 Chong Yidong <cyd@gnu.org>
8572
8573 * window.c (Fcoordinates_in_window_p): Accept only live windows.
8574
56e2e794
MR
85752011-11-23 Martin Rudalics <rudalics@gmx.at>
8576
8577 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
8578 making another buffer current. (Bug#10114)
8579
b6e64c41
GM
85802011-11-23 Glenn Morris <rgm@gnu.org>
8581
8582 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
8583
6b21de18
CY
85842011-11-23 Chong Yidong <cyd@gnu.org>
8585
8586 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
8587 using it (Bug#5984).
8588
b12cd789
EZ
85892011-11-22 Eli Zaretskii <eliz@gnu.org>
8590
8591 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
8592 and header-lines, as they don't have one computed for them.
8593 (Bug#10098)
8594
8595 * .gdbinit (prow): Make displayed values more self-explaining.
8596 Add row's hash code.
8597
261b6fd4
LMI
85982011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
8599
8600 * process.c (wait_reading_process_output): Fix asynchrounous
8601 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 8602 (wait_reading_process_output): Add comment and URL.
261b6fd4 8603
e7cfd277
JD
86042011-11-21 Jan Djärv <jan.h.d@swipnet.se>
8605
8606 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
8607
a9b9b7f5
CY
86082011-11-21 Chong Yidong <cyd@gnu.org>
8609
8610 * window.c (Fnext_window, Fprevious_window): Doc fix.
8611
b0d15b4f
SM
86122011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
8613
8614 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
8615
fe7a3057
JB
86162011-11-20 Juanma Barranquero <lekktu@gmail.com>
8617
8618 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
8619
d2999b1a
MR
86202011-11-20 Martin Rudalics <rudalics@gmx.at>
8621
8622 * window.c (Fset_window_combination_limit): Rename argument
8623 STATUS to LIMIT.
8624 (Vwindow_combination_limit): Remove "status" from doc-string.
8625
d5ff9cd0
AS
86262011-11-20 Andreas Schwab <schwab@linux-m68k.org>
8627
8628 * m/ibms390.h: Remove.
8629 * m/ibms390x.h: Don't include "ibms390.h".
8630
a5bb9bd3
SM
86312011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
8632
8633 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
8634 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
8635
cd1181db
JB
86362011-11-20 Juanma Barranquero <lekktu@gmail.com>
8637
8638 * casetab.c (Fset_case_table):
8639 * charset.c (Fcharset_after): Fix typos.
8640
615a3b8d 86412011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 8642
17e845af
PE
8643 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
8644 Otherwise, valgrind does not work on some platforms.
8645 Problem reported by Andreas Schwab in
6a0bf43d
PE
8646 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
8647 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
8648 is set, removing the need for VIRT_ADDRESS_VARIES.
8649 (PURE_P): Use a more-efficient implementation that needs just one
8650 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
8651 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
8652 to 4 (xorl, subq, cmpq, setbe).
8653 * alloc.c (pure): Always extern now, since that's the
8654 VIRT_ADDR_VARIES behavior.
8655 (PURE_POINTER_P): Use a single comparison, not two, for
8656 consistency with the new puresize.h.
8657 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
8658 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
8659 Remove VIRT_ADDR_VARIES no longer needed.
8660
f8fe6f96
EZ
86612011-11-19 Eli Zaretskii <eliz@gnu.org>
8662
8663 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
8664 (erase_phys_cursor, update_window_cursor, show_mouse_face)
8665 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
8666 behave as if the cursor position were at the window margin.
8667
8668 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
8669 and the cursor position is out of bounds, behave as if the cursor
8670 position were at the window margin. (Bug#10075)
8671
df05a53c
CY
86722011-11-18 Chong Yidong <cyd@gnu.org>
8673
8674 * window.c (Fwindow_combination_limit): Make first argument
8675 non-optional, since it is meaningless for live windows like the
8676 selected window.
61ccba97 8677
2071918e
DA
86782011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
8679
8680 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
8681
b50a28de
SM
86822011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
8683
8684 * intervals.c: Fix grafting over the whole buffer (bug#10071).
8685 (graft_intervals_into_buffer): Simplify.
8686
015137db
EZ
86872011-11-18 Eli Zaretskii <eliz@gnu.org>
8688
8689 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
8690 hash values of the two rows.
8691 (copy_row_except_pointers): Preserve the used[] arrays and the
8692 hash values of the two rows. (Bug#10035)
68c95424 8693 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
8694
8695 * xdisp.c (row_hash): New function, body extracted from
8696 compute_line_metrics.
8697 (compute_line_metrics): Call row_hash, instead of computing the
8698 hash code inline.
8699
8700 * dispnew.c (verify_row_hash): Call row_hash for computing the
8701 hash code of a row, instead of duplicating code from xdisp.c.
8702
8703 * dispextern.h (row_hash): Add prototype.
8704
a2addb04
TH
87052011-11-18 Tassilo Horn <tassilo@member.fsf.org>
8706
8707 * frame.c (delete_frame): Don't delete the terminal when the last
8708 X frame is closed if emacs is built with GTK toolkit.
8709
df85d315
JB
87102011-11-17 Juanma Barranquero <lekktu@gmail.com>
8711
8712 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
8713
a0c2d0ae
MR
87142011-11-17 Martin Rudalics <rudalics@gmx.at>
8715
8716 * window.c (Vwindow_splits): Rename to
8717 Vwindow_combination_resize. Suggested by Juri Linkov.
8718 (Fsplit_window_internal): Use Vwindow_combination_resize instead
8719 of Vwindow_splits.
8720
58179cce
JB
87212011-11-16 Juanma Barranquero <lekktu@gmail.com>
8722
7877f373
JB
8723 * nsfns.m (Fns_font_name):
8724 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 8725
b6f67890
MR
87262011-11-16 Martin Rudalics <rudalics@gmx.at>
8727
8728 * window.h (window): Rename slot "nest" to "combination_limit".
8729 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
8730 (Fset_window_nest): Rename to Fset_window_combination_limit.
8731 (Vwindow_nest): Rename to Vwindow_combination_limit.
8732 (recombine_windows, make_parent_window, make_window)
8733 (Fsplit_window_internal, saved_window)
8734 (Fset_window_configuration, save_window_save): Rename all
8735 occurrences of window_nest to window_combination_limit.
8736
c7015153
JB
87372011-11-15 Juanma Barranquero <lekktu@gmail.com>
8738
8739 * image.c (imagemagick_load_image): Fix typo.
8740
322ad6ec
EZ
87412011-11-14 Eli Zaretskii <eliz@gnu.org>
8742
8743 * xdisp.c (display_line): Move the call to
8744 highlight_trailing_whitespace before the call to
8745 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
8746 faces of all the glyphs to compute ROW's hash value.
8747 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 8748
f067b8ec
JB
87492011-11-14 Juanma Barranquero <lekktu@gmail.com>
8750
8751 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
8752 just return (bug#10044).
8753
1e5b2111
EZ
87542011-11-12 Eli Zaretskii <eliz@gnu.org>
8755
7ef3cbd5
EZ
8756 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
8757 with user-defined heap size. Bump the default size of the temacs
8758 heap to 27MB, to avoid memory warning when running temacs.
8759 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
8760
1e5b2111
EZ
8761 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
8762 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
8763 (verify_row_hash) [XASSERTS]: New function.
8764 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
8765 that the hash value of glyph rows is correct.
1e5b2111 8766
89d61221
MR
87672011-11-12 Martin Rudalics <rudalics@gmx.at>
8768
8769 * window.h (window): Remove splits slot.
8770 * window.c (Fwindow_splits, Fset_window_splits): Remove.
8771 (Fdelete_other_windows_internal, make_parent_window)
8772 (make_window, Fsplit_window_internal, Fdelete_window_internal)
8773 (Fset_window_configuration, save_window_save): Don't deal with
8774 split status of windows.
8775 (saved_window): Remove splits slot.
8776 (Vwindow_splits): Rewrite doc-string.
8777
97f18cc8
JD
87782011-11-11 Jan Djärv <jan.h.d@swipnet.se>
8779
8780 * xfns.c (unwind_create_frame):
8781 * nsfns.m (unwind_create_frame):
8782 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
8783 Vframe_list (Bug#9999).
8784
22a648b4
DA
87852011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
8786
0b381c7e 8787 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 8788
659afede
KH
87892011-11-11 Kenichi Handa <handa@m17n.org>
8790
8791 * callproc.c (Fcall_process): Set the member dst_multibyte of
8792 process_coding.
8793
9ac0394b
KH
87942011-11-11 Johan Bockgård <bojohan@gnu.org>
8795
8796 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
8797 avoid a crash (bug#9496).
8798
2fbdc249
CY
87992011-11-09 Chong Yidong <cyd@gnu.org>
8800
8801 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
8802 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
8803
ac6b1f81
PE
88042011-11-08 Paul Eggert <eggert@cs.ucla.edu>
8805
8806 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
8807
09db192c
PE
88082011-11-08 Paul Eggert <eggert@cs.ucla.edu>
8809
8810 Avoid some portability problems by eschewing 'extern inline' functions.
8811 The trivial performance wins aren't worth the portability hassles; see
8812 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
8813 et seq.
8814 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8815 (window_box_width, window_box_left, window_box_left_offset)
8816 (window_box_right, window_box_right_offset): Undo previous change,
8817 by removing the "extern"s.
8818 * intervals.c (adjust_intervals_for_insertion)
8819 (adjust_intervals_for_deletion): Undo previous change,
8820 making these static again.
8821 (offset_intervals, temp_set_point_both, temp_set_point)
8822 (copy_intervals_to_string): No longer inline.
8823 * xdisp.c (window_text_bottom_y, window_box_width)
8824 (window_box_height, window_box_left_offset)
8825 (window_box_right_offset, window_box_left, window_box_right)
8826 (window_box): No longer inline.
8827
105216ed
CY
88282011-11-08 Chong Yidong <cyd@gnu.org>
8829
8830 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
8831 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
8832 Signal an error if not a live window.
105216ed
CY
8833 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
8834 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
8835
ae9e237f
JB
88362011-11-07 Juanma Barranquero <lekktu@gmail.com>
8837
8838 * lisp.h (syms_of_abbrev): Remove declaration.
8839 Reported by CHENG Gao <chenggao@royau.me>.
8840
c7aa8333
EZ
88412011-11-07 Eli Zaretskii <eliz@gnu.org>
8842
8843 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
8844 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
8845 of temacs in GUI mode.
8846
be7f5545
MR
88472011-11-07 Martin Rudalics <rudalics@gmx.at>
8848
8849 * window.h: Declare delete_all_child_windows instead of
8850 delete_all_subwindows.
8851 * window.c (Fwindow_nest, Fset_window_nest)
8852 (Fset_window_new_total, Fset_window_new_normal)
8853 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
8854 (delete_all_subwindows): Rename to delete_all_child_windows.
8855 (Fdelete_other_windows_internal, Fset_window_configuration):
8856 Call delete_all_child_windows instead of delete_all_subwindows.
8857 * frame.c (delete_frame): Call delete_all_child_windows instead
8858 of delete_all_subwindows.
8859
ca78dc43
PE
88602011-11-07 Paul Eggert <eggert@cs.ucla.edu>
8861
8862 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
8863 This is also needed for porting to any host where GC_MARK_STACK is
8864 not GC_MAKE_GCPROS_NOOPS.
8865 (which_symbols): Use it.
8866
a0241d01
KH
88672011-11-07 Kenichi Handa <handa@m17n.org>
8868
8869 * coding.c (coding_set_destination): Check coding->src_pos only
8870 when coding->src_object is a buffer (bug#9910).
8871
8872 * process.c (send_process): Set the member src_multibyte of coding
8873 to 0 (bug#9911) when sending a unibyte text.
8874
8875 * callproc.c (Fcall_process): Set the member src_multibyte of
8876 process_coding to 0 (bug#9912).
8877
a64bfdfa 88782011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
8879
8880 * xmenu.c (cleanup_widget_value_tree): New function.
8881 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
8882 calling free_menubar_widget_value_tree directly (Bug#9830).
8883
cb41b32a
PE
88842011-11-06 Paul Eggert <eggert@cs.ucla.edu>
8885
8886 Fix some portability problems with 'inline'.
8887 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8888 (window_box_width, window_box_left, window_box_left_offset)
8889 (window_box_right, window_box_right_offset): Declare extern.
8890 Otherwise, these inline functions do not conform to C99 and
8891 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
8892 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
8893 * intervals.c (adjust_intervals_for_insertion)
8894 (adjust_intervals_for_deletion): Now extern, because otherwise the
8895 extern inline functions 'offset_intervals' couldn't refer to it.
8896 (static_offset_intervals): Remove.
8897 (offset_intervals): Rewrite using the old contents of
8898 static_offset_intervals. The old version didn't conform to C99
8899 because an extern inline function contained a reference to an
8900 identifier with static linkage.
8901
b7041366
AS
89022011-11-06 Andreas Schwab <schwab@linux-m68k.org>
8903
8904 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
8905 GC.
8906
88a37c4d
EZ
89072011-11-06 Eli Zaretskii <eliz@gnu.org>
8908
8909 * xdisp.c (init_iterator, reseat_to_string): Don't set the
8910 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
8911 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
8912 return Qleft_to_right.
8913
49745b39
CY
89142011-11-06 Chong Yidong <cyd@gnu.org>
8915
8916 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
8917 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
8918 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
8919 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
8920 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
8921 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
8922 (Fwindow_vscroll): Doc fix.
8923 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
8924 argument, since it makes no sense to pass a live window and for
8925 consistency with window-child.
8926
1f05cd82
CS
89272011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
8928
8929 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
8930 support MSVC.
8931
22610910
JR
89322011-11-05 Jason Rumney <jasonr@gnu.org>
8933
8934 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
8935 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
8936 fonts (Bug#6029).
8937 (add_font_entity_to_list): Fix logic errors in mixed boolean and
8938 bitwise arithmetic preventing use of unicode-sip and non-truetype
8939 opentype fonts.
8940
a06776b2
EZ
89412011-11-05 Eli Zaretskii <eliz@gnu.org>
8942
3ad924ba
EZ
8943 * s/ms-w32.h (fstat, stat, utime): Move redirections to
8944 "emacs"-only part.
8945
a06776b2
EZ
8946 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
8947 initialization code to keep similarity to xfns.c after changes
8948 from 2011-11-05.
8949
c9e7db78
JD
89502011-11-05 Jan Djärv <jan.h.d@swipnet.se>
8951
a97f8f3f
JD
8952 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
8953 (unwind_create_frame): New function (Bug#9943).
8954 (Fx_create_frame): Restructure code to be more similar to the one in
8955 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
8956 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
8957 Move terminal->reference_count++ just before making the frame official
8958 (Bug#9943).
8959
8960 * nsterm.m (x_free_frame_resources): New function.
8961 (x_destroy_window): Move code to x_free_frame_resources.
8962
c9e7db78 8963 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
8964 (Fx_create_frame, x_create_tip_frame):
8965 Move terminal->reference_count++ just before making the frame
75f1671a 8966 official. Move initialization of image_cache_refcount and
c9e7db78
JD
8967 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
8968
a6fc3b5c
EZ
89692011-11-05 Eli Zaretskii <eliz@gnu.org>
8970
8971 Support MSVC build with newer versions of Visual Studio.
8972 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
8973 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
8974 nt/gmake.defs.
8975
8976 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
8977 which are not supported by MSVC.
8978 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
8979 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
8980 bitfields.
8981 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
8982 types in bitfields.
8983 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
8984
8985 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
8986
58179cce 89872011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
8988
8989 Support MSVC build with newer versions of Visual Studio.
8990 * w32.c: Don't include w32api.h for MSVC.
8991 (init_environment) [_MSC_VER]: Call sys_access, not _access.
8992
8993 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
8994 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
8995 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
8996 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
8997 e_* cousins.
8998 (alloca) [_MSC_VER]: Define to _alloca.
8999
9000 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
9001
9002 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
9003
a58c13ed
EZ
90042011-11-04 Eli Zaretskii <eliz@gnu.org>
9005
9006 * xdisp.c (note_mouse_highlight): If either of
9007 previous/next-single-property-change returns nil, treat that as
9008 the beginning or the end of the buffer. (Bug#9955)
9009
fe0b6370
JD
90102011-11-04 Jan Djärv <jan.h.d@swipnet.se>
9011
a58c13ed 9012 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
9013 label is not null (Bug#9951).
9014 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
9015 may be NULL.
9016
89bd5ee1
EZ
90172011-11-04 Eli Zaretskii <eliz@gnu.org>
9018
9019 * window.c (Fwindow_body_size): Mention in the doc string that the
9020 return value is in frame's canonical units. (Bug#9949)
9021
84c3edb9
EZ
90222011-11-03 Eli Zaretskii <eliz@gnu.org>
9023
4e2fb5c7
EZ
9024 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
9025
84c3edb9 9026 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 9027 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 9028 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 9029
bc17a887
EZ
90302011-11-01 Eli Zaretskii <eliz@gnu.org>
9031
9032 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
9033 Don't stop backward scan on the continuation glyph, even though
9034 its CHARPOS is positive.
6d5eb5b0
SM
9035 (mouse_face_from_buffer_pos, note_mouse_highlight):
9036 Rename cover_string to disp_string.
bc17a887 9037
4ee88440
MR
90382011-11-01 Martin Rudalics <rudalics@gmx.at>
9039
9040 * window.c (temp_output_buffer_show): Don't use
9041 Vtemp_buffer_show_specifiers.
9042 (Vtemp_buffer_show_specifiers): Remove unused variable.
9043
c2ff3c02
EZ
90442011-10-30 Eli Zaretskii <eliz@gnu.org>
9045
9046 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
9047 past the beginning of the current glyph matrix.
9048
58179cce 90492011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
9050
9051 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
9052 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
9053 HAVE_GTK3 (Bug#9869).
b77a6a7f 9054
3b574623
JD
9055 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
9056 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
9057
b77a6a7f
JD
9058 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
9059
9060 * xterm.c: Declare x_handle_net_wm_state to return int.
9061 (handle_one_xevent): Check if we are iconified but don't have
9062 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
9063 (get_current_wm_state): Return non-zero if not hidden,
9064 check for _NET_WM_STATE_HIDDEN (Bug#9893).
9065 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
9066 (x_handle_net_wm_state): Return what get_current_wm_state returns.
9067 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
9068
196e41e4
PE
90692011-10-29 Paul Eggert <eggert@cs.ucla.edu>
9070
9071 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
9072 so that this new function doesn't get optimized away by a
9073 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
9074
021f2e1a
AS
90752011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9076
9077 * frame.h (MOUSE_HL_INFO): Remove excess parens.
9078
8b058d44
EZ
90792011-10-29 Eli Zaretskii <eliz@gnu.org>
9080
9081 Fix the `xbytecode' command.
9082 * .gdbinit (xprintbytestr): New command.
b50a28de 9083 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
9084 (xbytecode): Print the byte-code string as well.
9085
4452fb80
EZ
90862011-10-29 Kim Storm <storm@cua.dk>
9087
8b058d44
EZ
9088 * alloc.c (which_symbols): New function.
9089
21b72067
AS
90902011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9091
9092 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
9093 line. (Bug#9903)
9094
83ed7b5c
GM
90952011-10-29 Glenn Morris <rgm@gnu.org>
9096
9097 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
9098 Not clear what it was for, and it causes various bugs. (Bug#9839)
9099
5a7a728b
EZ
91002011-10-28 Eli Zaretskii <eliz@gnu.org>
9101
9102 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
9103 possible random value that matches one of those tested as
9104 condition to clear the mouse face.
9105
d3d0842f
CY
91062011-10-28 Chong Yidong <cyd@gnu.org>
9107
9108 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
9109
31b39d13
DN
91102011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
9111
9112 * window.c (make_window): Initialize phys_cursor_on_p.
9113
9aba6043
SM
91142011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
9115
9116 * lisp.h (struct Lisp_Symbol): Update comments.
9117
c20992f4
JB
91182011-10-28 Juanma Barranquero <lekktu@gmail.com>
9119
9120 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
9121
db4f02f2
EZ
91222011-10-28 Eli Zaretskii <eliz@gnu.org>
9123
9124 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
9125 <oslsachem@gmail.com> for helping to debug this.
9126
9127 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
9128 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
9129 (g_b_init_get_glyph_outline_w): New static variables.
9130 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
9131 (GetGlyphOutlineW_Proc): New typedefs.
9132 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
9133 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
9134 New functions.
9135 (w32font_open_internal, compute_metrics):
9136 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
9137 instead of calling the "wide" APIs directly.
9138
9139 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
9140
9141 * w32.h (syms_of_w32font): Add prototype.
9142
87e68db4
JB
91432011-10-27 Juanma Barranquero <lekktu@gmail.com>
9144
9145 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
9146 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
9147 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
9148 (Fmove_to_window_line): Doc fix.
9149
435c1d67
CY
91502011-10-27 Chong Yidong <cyd@gnu.org>
9151
9152 * process.c (make_process): Set gnutls_state to NULL.
9153
9154 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
9155 non-NULL, regardless of GNUTLS_INITSTAGE.
9156 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
9157 an error. Set process slots as soon as we allocate them.
9158
9159 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
9160
9c6c6f49
CY
91612011-10-27 Chong Yidong <cyd@gnu.org>
9162
9aba6043
SM
9163 * gnutls.c (emacs_gnutls_deinit): New function.
9164 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
9165 (Fgnutls_deinit, Fgnutls_boot): Use it.
9166
9167 * process.c (make_process): Initialize GnuTLS credentials to NULL.
9168 (deactivate_process): Call emacs_gnutls_deinit.
9169
657d08d3
JB
91702011-10-27 Juanma Barranquero <lekktu@gmail.com>
9171
9172 * image.c (x_create_x_image_and_pixmap):
9173 * w32.c (sys_rename, w32_delayed_load):
9174 * w32font.c (fill_in_logfont):
9175 * w32reg.c (x_get_string_resource): Silence compiler warnings.
9176
5430d399
JB
91772011-10-26 Juanma Barranquero <lekktu@gmail.com>
9178
9179 * w32fns.c (w32_default_color_map): New function,
9180 extracted from Fw32_default_color_map.
a7ef684b 9181 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 9182
fe0055fa
PE
91832011-10-25 Paul Eggert <eggert@cs.ucla.edu>
9184
9185 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
9186
e6346438
SM
91872011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
9188
9189 * keyboard.c (test_undefined): New function (bug#9751).
9190 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
9191
e112cc37
ET
91922011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
9193
9194 * sysdep.c (init_sys_modes): Fix the check for the controlling
9195 terminal (Bug#6649).
9196
7b5d6677
EZ
91972011-10-20 Eli Zaretskii <eliz@gnu.org>
9198
9199 * dispextern.h (struct bidi_it): New member next_en_type.
9200
9201 * bidi.c (bidi_line_init): Initialize the next_en_type member.
9202 (bidi_resolve_explicit_1): When next_en_pos is valid for the
9203 current character, check also for next_en_type being WEAK_EN.
9204 (bidi_resolve_weak): Don't enter the expensive loop if the current
9205 position is before next_en_pos. Record the bidi type of the first
9206 non-ET, non-BN character we find, in addition to its position.
9207 (bidi_level_of_next_char): Invalidate next_en_type when
9208 next_en_pos is over-stepped.
9209
7da0b018
PE
92102011-10-20 Paul Eggert <eggert@cs.ucla.edu>
9211
9212 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
9213 * editfns.c: Rewrite current-time-zone so that it invokes
9214 the equivalent of (format-time-string "%Z") to get the time zone name.
9215 This fixes a bug when the time zone name contains characters that
9216 need converting from the system time locale to Emacs internal format.
9217 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
9218 that patch fixed format-time-string to do the conversion, but
9219 I forgot to fix current-time-zone.
9220 (format_time_string): New function, containing most of
9221 what Fformat_time_string used to contain.
9222 (Fformat_time_string): Rewrite in terms of format_time_string.
9223 This doesn't change this function's behavior.
9224 (current-time-zone): Rewrite to use format_time_string.
9225 This fixes the bug reported by Michael Schierl in
9226 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
9227 Jason Rumney's 2007-06-07 change worked around this bug, but
9228 didn't fix it.
9229 * systime.h (tzname, timezone): Remove no-longer-used declarations.
9230
8547b010
EZ
92312011-10-19 Eli Zaretskii <eliz@gnu.org>
9232
9233 * xdisp.c (start_display): If the character at POS is displayed
9234 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
9235 (try_window_reusing_current_matrix): If a line ends in a display
9236 vector or the next line starts in a display vector, continue
9237 redrawing the window even though the character position of
9238 start_row was reached.
8547b010
EZ
9239 (Bug#9771, part 2)
9240
4e948d15
CY
92412011-10-18 Chong Yidong <cyd@gnu.org>
9242
9243 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
9244 with nobreak-char-display too.
9245
4787455f
EZ
92462011-10-18 Eli Zaretskii <eliz@gnu.org>
9247
9248 Fix part 3 of bug#9771.
9249 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
9250 (bidi_resolve_neutral): Don't enter the expensive loop looking for
9251 non-neutral characters if the current character is a paragraph
9252 separator (a.k.a. Newline). This avoids running the same
9253 expensive loop twice, once when we consume the preceding newline
9254 and the other time when the line actually needs to be displayed.
9255 Avoid the loop when we see neutrals on the base embedding level
9256 following a character whose directionality is the same as the
9257 paragraph's. This avoids running the expensive loop when a line
9258 ends in a long sequence of neutrals, like control characters.
9259 Add assertion against STRONG_AL type. Slightly rearrange code
9260 that determines the type of a neutral given the first non-neutral
9261 that follows it.
9262 (bidi_level_of_next_char): Set next_en_pos to zero when
9263 invalidating its info.
9264
2c91f553
EZ
92652011-10-17 Eli Zaretskii <eliz@gnu.org>
9266
9267 * xdisp.c (push_display_prop): Determine whether to record string
9268 or buffer position by IT->string, not by IT->method. Allow
9269 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
9270 (move_it_vertically_backward): Don't look for character position
9271 immediately after the newline when in a continuation line.
9272 (Bug#9771, part 1)
2c91f553 9273
c7b08b0d
MR
92742011-10-15 Martin Rudalics <rudalics@gmx.at>
9275
9276 * window.c (coordinates_in_window): Rewrite and delabelize
9277 vertical border check. (Bug#5357) (Bug#9618)
9278
6b02f655
SM
92792011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
9280
9281 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
9282 errors in XSetWindowBorder (bug#9310).
9283
81d40c92
DA
92842011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
9285
9286 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
9287 avoid crash when xmalloc overrun checking is enabled.
9288
d4172c3b
EZ
92892011-10-13 Eli Zaretskii <eliz@gnu.org>
9290
9291 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
9292 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
9293 cursor motion with <left> and <right> arrow keys.
9294
9295 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
9296 some callers set that themselves.
9297
b00eea75
EZ
92982011-10-12 Eli Zaretskii <eliz@gnu.org>
9299
9300 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
9301 display string and the previous row comes from the same string and
9302 is empty. (Bug#9739) (Bug#9738)
9303
8fe012c4
SM
93042011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
9305
9306 * doc.c (get_doc_string): Encode file name (bug#9735).
9307
0074aef2
EZ
93082011-10-12 Eli Zaretskii <eliz@gnu.org>
9309
79beb178
EZ
9310 * bidi.c (bidi_level_of_next_char):
9311 * xdisp.c (get_visually_first_element): Remove old incorrect
9312 comments regarding the Unicode Line Separator character.
9313
0074aef2
EZ
9314 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
9315
6e4b3fbe
DA
93162011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
9317
9318 * alloc.c (Fgc_status): Do not access beyond zombies array
9319 boundary if nzombies > MAX_ZOMBIES.
9320 * alloc.c (dump_zombies): Add missing format specifier.
9321
0324f3af
PE
93222011-10-12 Paul Eggert <eggert@cs.ucla.edu>
9323
b5525cac
PE
9324 * xdisp.c (set_cursor_from_row): Simplify conditionals,
9325 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
9326
0324f3af
PE
9327 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
9328 Some packages use them to denote characters with modifiers.
9329
e9b5f888
AS
93302011-10-11 Andreas Schwab <schwab@linux-m68k.org>
9331
9332 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
9333 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
9334 matching a pp-number. Rename parameter var to var1.
9335
127827c0
SM
93362011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
9337
9338 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
9339
c8fd3bd0
GM
93402011-10-08 Glenn Morris <rgm@gnu.org>
9341
9342 * callint.c (Fcall_interactively): Give a more explicit error for the
9343 'c' case with a non-character input. (Bug#8479)
9344
352ec8ff
EZ
93452011-10-08 Eli Zaretskii <eliz@gnu.org>
9346
03669ccb
EZ
9347 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
9348 lines.
7061c986
EZ
9349 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
9350 lines that are hscrolled on the left.
03669ccb 9351
352ec8ff
EZ
9352 * dispnew.c (buffer_posn_from_coords): Account for a possible
9353 presence of header-line. (Bug#4426)
9354
a66cfb1c
SM
93552011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
9356
6b02f655
SM
9357 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
9358 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 9359
7c5ee88e
PE
93602011-10-07 Paul Eggert <eggert@cs.ucla.edu>
9361
9362 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
9363 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
9364 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
9365 this makes Emacs dump core during garbage collection on rare
9366 occasions. sizeof is obviously inferior to offsetof here, so
9367 stick with offsetof.
9368 (GC_POINTER_ALIGNMENT): New macro.
9369 (mark_memory): Omit 3rd (offset) arg; caller changed.
9370 Don't assume EMACS_INT alignment is the same as pointer alignment.
9371
df1bbe5b
SM
93722011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
9373
9374 * keyboard.c (read_key_sequence_remapped): New var.
9375 (read_key_sequence): Compute remapping in the right buffer.
9376 (command_loop_1): Use read_key_sequence's remapping directly.
9377
51553db6
SM
93782011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
9379
32c1fffd
SM
9380 * dired.c (file_name_completion): Don't expand file name.
9381 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
9382 before checking file name handler.
9383
51553db6
SM
9384 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
9385 they've been requested explicitly (bug#9591).
9386
b6bd1599 93872011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
9388
9389 * keymap.c (Fsingle_key_description): Use make_specified_string
9390 instead of build_string to build string from push_key_description.
9391 (Bug#5193)
9392
f701dc2a
PE
93932011-09-30 Paul Eggert <eggert@cs.ucla.edu>
9394
4222c55d
PE
9395 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
9396 This fixes a Y2038 bug on 64-bit hosts.
9397 * buffer.c (reset_buffer):
9398 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
9399 (Fclear_buffer_auto_save_failure):
9400 Use 0, not -1, to represent an unset failure time, since time_t
9401 might not be signed.
9402
f701dc2a
PE
9403 Remove dependency on glibc malloc internals.
9404 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9405 Move back here from lisp.h, but with their new implementations.
9406 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9407 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
9408 * charset.c (charset_table_init): New static var.
9409 (syms_of_charset): Use it instead of xmalloc. This removes a
9410 dependency on glibc malloc internals. See Eli Zaretskii's comment in
9411 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
9412 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9413 Move back to alloc.c.
9414 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9415 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
9416
9ceebf39
JD
94172011-09-30 Jan Djärv <jan.h.d@swipnet.se>
9418
9419 * nsterm.m (windowDidResize): Call x_set_window_size only when
9420 ns_in_resize is true. Otherwise set pixelwidth/height and
9421 call change_frame_size (Bug#9628).
9422
cb993c58
PE
94232011-09-30 Paul Eggert <eggert@cs.ucla.edu>
9424
3930c88b
PE
9425 Port --enable-checking=all to Fedora 14 x86-64.
9426 * charset.c (syms_of_charset): Also account for glibc malloc's
9427 internal overhead when calculating the initial malloc maximum.
9428
cb993c58
PE
9429 Port --enable-checking=all to Fedora 14 x86.
9430 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9431 Move to lisp.h.
9432 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
9433 (overrun_check_realloc, overrun_check_free):
9434 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
9435 That way, xmalloc returns a properly-aligned pointer even if
9436 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
9437 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
9438 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
9439 into account when calculating the initial malloc maximum.
9440 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
9441 Move here from alloc.c, so that charset.c can use it too.
9442 Properly align; the old code wasn't right for common 32-bit hosts
9443 when configured with --enable-checking=all.
9444 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
9445 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
9446
31bed486
EZ
94472011-09-29 Eli Zaretskii <eliz@gnu.org>
9448
04c70788 9449 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
9450 use EDOM.
9451
fbcaa2f3
EZ
94522011-09-28 Eli Zaretskii <eliz@gnu.org>
9453
9454 * xdisp.c (compute_display_string_end): If there's no display
9455 string at CHARPOS, return -1.
9456
9457 * bidi.c (bidi_fetch_char): When compute_display_string_end
9458 returns a negative value, treat the character as a normal
9459 character not covered by a display string. (Bug#9624)
9460
a239d4e9
JB
94612011-09-28 Juanma Barranquero <lekktu@gmail.com>
9462
9463 * lread.c (Fread_from_string): Fix typo in docstring.
9464
88652fd5
EZ
94652011-09-27 Eli Zaretskii <eliz@gnu.org>
9466
9467 * xdisp.c (handle_invisible_prop): If invisible text ends on a
9468 newline, reseat the iterator instead of bidi-iterating there one
9469 character at a time. (Bug#9610)
32c1fffd
SM
9470 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
9471 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 9472
ed497dd4
AS
94732011-09-27 Andreas Schwab <schwab@linux-m68k.org>
9474
9475 * lread.c (readevalloop): Use correct code for NBSP.
9476 (read1): Likewise. (Bug#9608)
9477
b2bf61aa
MA
94782011-09-25 Michael Albinus <michael.albinus@gmx.de>
9479
9480 * dbusbind.c (Fdbus_register_signal): When service is not
9481 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
9482
32bbb17c
GM
94832011-09-25 Glenn Morris <rgm@gnu.org>
9484
9485 * buffer.c (truncate-lines): Doc fix.
9486
94e0933e
CY
94872011-09-24 Chong Yidong <cyd@stupidchicken.com>
9488
9489 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
9490 (Fset_window_next_buffers): Doc fix.
9491
cddde921
GM
94922011-09-24 Glenn Morris <rgm@gnu.org>
9493
9494 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
9495
1260aef1
PE
94962011-09-24 Paul Eggert <eggert@cs.ucla.edu>
9497
25b4bfa0
PE
9498 Fix minor problems found by static checking.
9499 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
9500 * indent.c (Fvertical_motion): Fix == vs = typo.
9501
e3cbd34b
EZ
95022011-09-24 Eli Zaretskii <eliz@gnu.org>
9503
a66cfb1c
SM
9504 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
9505 Default value is now t. Doc fix.
6bf7006f 9506
e3cbd34b 9507 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 9508 logic when moving up, not only when moving down. Fix the
e3cbd34b 9509 confusing name and values of the it_overshoot_expected variable;
32c1fffd 9510 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
9511
9512 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
9513 CHARPOS is covered by a display string which includes newlines.
9514 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
9515 is covered by a display string with embedded newlines.
9516
a3de0cbd
MA
95172011-09-24 Michael Albinus <michael.albinus@gmx.de>
9518
9519 * dbusbind.c (Fdbus_register_signal): Add match rule to
9520 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
9521 (Fdbus_register_method, Vdbus_registered_objects_table):
9522 Fix docstring.
a3de0cbd 9523
b260039d
JM
95242011-09-24 Jim Meyering <meyering@redhat.com>
9525
32c1fffd 9526 do not ignore write error for any output size
b260039d
JM
9527 The previous change was incomplete.
9528 While it makes emacs --batch detect the vast majority of stdout
9529 write failures, errors were still ignored whenever the output size is
9530 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
9531 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
9532 && echo FAIL: ignored write error
9533 FAIL: ignored write error
9534 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
9535 && echo FAIL: ignored write error
9536 FAIL: ignored write error
9537 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
9538
8eca8a7c
AS
95392011-09-23 Andreas Schwab <schwab@linux-m68k.org>
9540
9541 * emacs.c (Fkill_emacs): In noninteractive mode exit
9542 non-successfully if a write error occurred on stdout. (Bug#9574)
9543
3341db62
EZ
95442011-09-21 Eli Zaretskii <eliz@gnu.org>
9545
9546 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
9547 the xassert test.
9548
9549 * dispextern.h (struct it): Update the comment documenting what
9550 can it->OBJECT be.
9551
8c203dbf
EZ
95522011-09-20 Eli Zaretskii <eliz@gnu.org>
9553
9554 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
9555 a display string, extend search for cursor position to end of row.
9556 (find_row_edges): If the row ends in a newline from a display
9557 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
9558 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
9559 (Fcurrent_bidi_paragraph_direction): Fix search for previous
9560 non-empty line. Fixes confusing cursor motion with arrow keys at
9561 the beginning of a line that starts with whitespace.
8c203dbf 9562
a4824228
LMI
95632011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9564
9565 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
9566 (bug#9493).
9567
33ed493b
CY
95682011-09-18 Chong Yidong <cyd@stupidchicken.com>
9569
9570 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
9571 boolean (Bug#9154).
9572
56cd55c8
EZ
95732011-09-18 Eli Zaretskii <eliz@gnu.org>
9574
9575 * xdisp.c (display_line): Record maximum and minimum buffer
9576 positions even if no glyphs were produced (e.g., by a zero-width
9577 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
9578 buffer positions that will be removed from the glyph row because
9579 they don't fit.
c02dcedf
EZ
9580 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
9581 column is beyond frame width: don't subtract 1 "pixel" when
9582 computing width of the stretch.
3e62b7e0
EZ
9583 (reseat_at_next_visible_line_start): Undo the change made on
9584 2011-09-17 that saved paragraph information and restored it after
9585 the call to `reseat'. (Bug#9545)
56cd55c8 9586
5ed99d36 95872011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
9588
9589 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
9590 and turn window cursor on if cleared (Bug#9415).
9591
5ed99d36 95922011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
9593
9594 * search.c (boyer_moore): Take unibyte characters from pattern
9595 literally. (Bug#9458)
9596
9bade7b2
EZ
95972011-09-18 Eli Zaretskii <eliz@gnu.org>
9598
9599 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
9600
e5e9d610
PE
96012011-09-18 Paul Eggert <eggert@cs.ucla.edu>
9602
87e4427a
PE
9603 Fix minor problem found by static checking.
9604 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
9605 initialized, to pacify gcc -Wuninitialized.
9606
e5e9d610
PE
9607 * fileio.c: Report proper errno when syscall falls.
9608 (Finsert_file_contents): Save and restore errno,
9609 so that report_file_error outputs the correct diagnostic.
9610 (Fwrite_region) [CLASH_DETECTION]: Likewise.
9611
a1674f0b
EZ
96122011-09-18 Eli Zaretskii <eliz@gnu.org>
9613
9614 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
9615
fbfb6dd4
EZ
96162011-09-17 Eli Zaretskii <eliz@gnu.org>
9617
9618 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
9619 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
9620
bb187662
EZ
96212011-09-17 Eli Zaretskii <eliz@gnu.org>
9622
1137e8b8 9623 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 9624 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
9625
9626 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
9627 (bidi_find_paragraph_start): Search back for paragraph beginning
9628 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
9629 (bidi_move_to_visually_next): Only trigger paragraph-related
9630 computations when the last character is a newline or at EOB, not
9631 just any NEUTRAL_B. (Bug#9470)
9632
bb187662
EZ
9633 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
9634 truncated lines if point is covered by a display string. (Bug#9524)
9635
2e621251
PE
96362011-09-16 Paul Eggert <eggert@cs.ucla.edu>
9637
9638 * xselect.c: Relax test for outgoing X longs (Bug#9498).
9639 (cons_to_x_long): New function.
9640 (lisp_data_to_selection_data): Use it. Correct the test for
9641 short-versus-long data; it was negated. Break out of vector
9642 loop, for efficiency, when a long datum is discovered.
9643
91a15bc6
SM
96442011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
9645
9646 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
9647
b41c3a35
EZ
96482011-09-16 Eli Zaretskii <eliz@gnu.org>
9649
9650 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
9651 GCC PR/17406) by declaring this function with external scope.
9652
7812ba2d
PE
96532011-09-15 Paul Eggert <eggert@cs.ucla.edu>
9654
9655 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
9656 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
9657
cf7edc2a
AS
96582011-09-15 Andreas Schwab <schwab@linux-m68k.org>
9659
9660 * editfns.c (Fformat): Correctly handle text properties on "%%".
9661
bd01620e
EZ
96622011-09-15 Eli Zaretskii <eliz@gnu.org>
9663
9664 * xterm.c (x_draw_composite_glyph_string_foreground):
9665 * w32term.c (x_draw_composite_glyph_string_foreground):
9666 * term.c (encode_terminal_code):
9667 * composite.c (composition_update_it, get_composition_id):
9668 * xdisp.c (get_next_display_element)
9669 (fill_composite_glyph_string): Add comments about special meaning
9670 of TAB characters in a composition.
9671
a02719a3
PE
96722011-09-15 Paul Eggert <eggert@cs.ucla.edu>
9673
9674 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
9675 This occurs when processing a multibyte format.
9676 Problem reported by Wolfgang Jenker.
a02719a3 9677
72589a3c
JB
96782011-09-15 Johan Bockgård <bojohan@gnu.org>
9679
9680 * xdisp.c (try_cursor_movement): Only check for exact match if
9681 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
9682
1c14176c
PE
96832011-09-14 Paul Eggert <eggert@cs.ucla.edu>
9684
9685 Remove unused external symbols.
9686 * dispextern.h (calc_pixel_width_or_height): Remove decl.
9687 * xdisp.c (calc_pixel_width_or_height): Now static.
9688 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
9689 * indent.c (check_display_width):
9690 * w32term.c: Fix comment to match code.
9691 * xterm.c, xterm.h (x_catching_errors): Remove.
9692
d2eea5b5
PE
96932011-09-14 Paul Eggert <eggert@cs.ucla.edu>
9694
9695 * xselect.c: Use signed conversions more consistently (Bug#9498).
9696 (selection_data_to_lisp_data): Assume incoming selection data are
9697 signed integers, not unsigned. This is to be consistent with
9698 outgoing selection data, which was modified to use signed integers
9699 in as part of the fix to Bug#9196 in response to Jan D.'s comment
9700 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
9701 expects long, not unsigned long.
9702
46888499
EZ
97032011-09-14 Eli Zaretskii <eliz@gnu.org>
9704
9705 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
9706 computation of loop end. Reported by Johan Bockgård
9707 <bojohan@gnu.org>.
9708
ef8ef9fb
CY
97092011-09-13 Chong Yidong <cyd@stupidchicken.com>
9710
9711 * frame.c (Fother_visible_frames_p): Function deleted.
9712
fa819fed
EZ
97132011-09-12 Eli Zaretskii <eliz@gnu.org>
9714
9715 * indent.c (compute_motion): Process display vector front to back
9716 rather than the other way around. (Bug#2496)
9717
2ba8e008
SM
97182011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
9719
9720 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
9721
20f53c69
CY
97222011-09-11 Chong Yidong <cyd@stupidchicken.com>
9723
9724 * minibuf.c (Fread_from_minibuffer): Doc fix.
9725
d562d7a4
EZ
97262011-09-11 Eli Zaretskii <eliz@gnu.org>
9727
9728 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
9729 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
9730
1c4d7f3d
LMI
97312011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9732
9733 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
9734 value for non-existent files.
9735
b885bf36
EZ
97362011-09-11 Eli Zaretskii <eliz@gnu.org>
9737
9738 * fileio.c (Finsert_file_contents): If the file cannot be opened,
9739 set its "size" to -1. This will set the modtime_size field of
9740 the corresponding buffer to -1, which is what
9741 verify-visited-file-modtime expects for files that do not exist.
9742 (Bug#9139)
9743
6612f0bf
PE
97442011-09-11 Paul Eggert <eggert@cs.ucla.edu>
9745
9746 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
9747 here ...
9748 * lisp.h: ... from here. push_key_description is no longer
9749 defined in keyboard.c, so its declaration should not be in
9750 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
9751 logically belongs with push_key_description.
9752
dfb3f755
PE
97532011-09-10 Paul Eggert <eggert@cs.ucla.edu>
9754
9755 * buffer.h: Include <sys/types.h> instead of <time.h>.
9756 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
9757 Problem reported by Herbert J. Skuhra.
9758
3134906c
LMI
97592011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
9760
9761 * xml.c (parse_region): Make the parsing work for
9762 non-comment-starting XML files again (bug#9144).
9763
8d903f4e
AS
97642011-09-10 Andreas Schwab <schwab@linux-m68k.org>
9765
9766 * image.c (gif_load): Fix calculation of bottom and right corner.
9767 (Bug#9468)
9768
80ad64f4
EZ
97692011-09-10 Eli Zaretskii <eliz@gnu.org>
9770
9771 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
9772 redisplay in small windows.
9773
208a048d
EZ
97742011-09-09 Eli Zaretskii <eliz@gnu.org>
9775
9776 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
9777
9b1c252e
MR
97782011-09-08 Martin Rudalics <rudalics@gmx.at>
9779
9780 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
9781 Operate on live windows only.
9782
2949f33b
JB
97832011-09-08 Juanma Barranquero <lekktu@gmail.com>
9784
9785 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
9786
e08dcafd
EZ
97872011-09-07 Eli Zaretskii <eliz@gnu.org>
9788
9789 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
9790 only under bidi iteration.
9791
115b96bd
JD
97922011-09-07 Jan Djärv <jan.h.d@swipnet.se>
9793
9794 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
9795
c8199d0f
PE
97962011-09-06 Paul Eggert <eggert@cs.ucla.edu>
9797
9798 isnan: Fix porting problem to Solaris 10 with bundled gcc.
9799 Without this fix, the command to link temacs failed due to an
9800 undefined symbol __builtin_isnan. This is because
9801 /usr/include/iso/math_c99.h #defines isnan(x) to
9802 __builtin_isnan(x), but the bundled gcc, which identifies itself
9803 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
9804 a __builtin_isnan.
9805 * floatfns.c (isnan): #undef, and then #define to a clone of
9806 what's in data.c.
9807 (Fisnan): Always define, since it's always available now.
9808 (syms_of_floatfns): Always define isnan at the Lisp level.
9809
e39b275c 98102011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
9811
9812 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
9813
b2db44d9 98142011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 9815
f4af5137 9816 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
9817 The previous code assumed that file offsets (off_t values) fit in
9818 EMACS_INT variables, which is not true on typical 32-bit hosts.
9819 The code messed up by falsely reporting buffer overflow in cases
9820 such as (insert-file-contents "big" nil 1 2) into an empty buffer
9821 when "big" contains more than 2**29 bytes, even though this
9822 inserts just one byte and does not overflow the buffer.
9823 (Finsert_file_contents): Store file offsets as off_t
9824 values, not as EMACS_INT values. Check for overflow when
9825 converting between EMACS_INT and off_t. When checking for
9826 buffer overflow or for overlap, take the offsets into account.
9827 Don't use EMACS_INT for small values where int suffices.
9828 When checking for overlap, fix a typo: ZV was used where
9829 ZV_BYTE was intended.
9830 (Fwrite_region): Don't assume off_t fits into 'long'.
9831 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
9832
ecfc0a49
MA
98332011-09-05 Michael Albinus <michael.albinus@gmx.de>
9834
9835 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
9836
6511acf2 98372011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 9838
0999621a 9839 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
9840
9841 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 9842 (esprintf, exprintf, evxprintf): New functions.
62f19c19 9843 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 9844 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
9845 (modify_event_symbol): Do not assume that the length of
9846 name_alist_or_stem is safe to alloca and fits in int.
9847 (Fexecute_extended_command): Likewise for function name and binding.
9848 (Frecursion_depth): Wrap around reliably on integer overflow.
9849 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
9850 since some callers pass EMACS_INT values.
9851 (Fsingle_key_description): Don't crash if symbol name contains more
9852 than MAX_ALLOCA bytes.
9853 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
9854 (get_minibuffer): Arg is now EMACS_INT, not int.
9855 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 9856 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
9857 * window.h (command_loop_level, minibuf_level): Reflect API changes.
9858
2be7d702
PE
9859 * dbusbind.c (signature_cat): New function.
9860 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
9861 Do not overrun buffer; instead, report string overflow.
9862
9d1df220
PE
9863 * dispnew.c (add_window_display_history): Don't overrun buffer.
9864 Truncate instead; this is OK since it's just a log.
9865
33ef5c64
PE
9866 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
9867 even if the time zone offset is outlandishly large.
9868 Don't mishandle offset == INT_MIN.
9869
66c6fdd5
PE
9870 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
9871 when creating daemon; the previous buffer-overflow check was incorrect.
9872
d749b01b
PE
9873 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
9874 which has the guts of the old verror function.
9875
b5cd1905
PE
9876 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
9877 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
9878
6e1a67fb
PE
9879 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
9880 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 9881 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 9882 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
9883 length of string rather than counting it via multiple sprintfs;
9884 that's simpler and more reliable.
c21721cc
PE
9885 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
9886 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
9887 sprintf, in case result does not fit in int.
9888
c57b67fc
PE
9889 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
9890 (fontset_from_font): Print it.
9891
8a401434
PE
9892 * frame.c (tty_frame_count): Now printmax_t, not int.
9893 (make_terminal_frame, set_term_frame_name): Print it.
9894 (x_report_frame_params): In X, window IDs are unsigned long,
9895 not signed long, so print them as unsigned.
9896 (validate_x_resource_name): Check for implausibly long names,
9897 and don't assume name length fits in 'int'.
9898 (x_get_resource_string): Don't blindly alloca invocation name;
9899 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
9900 not fit in int.
9901
6e1a67fb
PE
9902 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
9903 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
9904 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
9905
0df02bf3
PE
9906 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
9907 Use esprintf, not sprintf, in case result does not fit in int.
9908
48e30793
PE
9909 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9910 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
9911 it as a large positive number.
9912 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
9913 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9914
a66ff6d8
PE
9915 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
9916 in case result does not fit in int.
9917
aca216ff
PE
9918 * print.c (float_to_string): Detect width overflow more reliably.
9919 (print_object): Make sprintf buffer a bit bigger, to avoid potential
9920 buffer overrun. Don't assume list length fits in 'int'. Treat
9921 print length of 0 as 0, not as infinity; to be consistent with other
9922 uses of print length in this function. Don't overflow print length
9923 index. Don't assume hash table size fits in 'long', or that
9924 vectorlike size fits in 'unsigned long'.
9925
31c286f7
PE
9926 * process.c (make_process): Use printmax_t, not int, to format
9927 process-name gensyms.
9928
55e5faa1
PE
9929 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
9930
80f2e268
PE
9931 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
9932 to avoid potential buffer overrun.
9933
670741ab
PE
9934 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
9935 if X resource line is longer than 512 bytes.
9936
b7163a50
PE
9937 * xfns.c (x_window): Make sprintf buffer a bit bigger
9938 to avoid potential buffer overrun.
9939
ae58ff1f
PE
9940 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
9941
c43c8a6a
PE
9942 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
9943
3f8236f4
PE
99442011-09-04 Paul Eggert <eggert@cs.ucla.edu>
9945
53e9fe90 9946 Integer overflow fixes for scrolling, etc.
6511acf2
PE
9947 Without these, Emacs silently mishandles large integers sometimes.
9948 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
9949 it were "C-u 1 M-x recenter" on a typical 64-bit host.
9950
6511acf2
PE
9951 * xdisp.c (try_window_id): Check Emacs fixnum range before
9952 converting to 'int'.
806add1d 9953
6511acf2 9954 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
9955 Check that an Emacs fixnum is in range before assigning it to 'int'.
9956 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
9957 values converted from Emacs fixnums.
9958 (Frecenter): Don't wrap around a line count if it is out of 'int'
9959 range; instead, treat it as an extreme value.
9960 (Fset_window_configuration, compare_window_configurations):
9961 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
9962
6511acf2
PE
9963 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
9964 that can exceed INT_MAX. Check that EMACS_INT value is in range
9965 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
9966 (match_limit): Don't assume that a fixnum can fit in 'int'.
9967
6511acf2 9968 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
9969 exceed INT_MAX.
9970
6511acf2 9971 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
9972 (Fvertical_motion): Don't wrap around LINES values that don't fit
9973 in 'int'. Instead, treat them as extreme values. This is good
9974 enough for windows, which can't have more than INT_MAX lines anyway.
9975
fcb901a7
LMI
99762011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9977
0f2f6b6d
LMI
9978 * Require libxml/parser.h to avoid compilation warning.
9979
fcb901a7
LMI
9980 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
9981
9982 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
9983 since this reportedly can destroy thread storage.
9984
6e20a0d4
CY
99852011-08-30 Chong Yidong <cyd@stupidchicken.com>
9986
9987 * syntax.c (find_defun_start): Update all cache variables if
9988 exiting early (Bug#9401).
9989
148ae00e
EZ
99902011-08-30 Eli Zaretskii <eliz@gnu.org>
9991
f6cfbd8f
EZ
9992 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
9993
148ae00e
EZ
9994 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
9995 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
9996 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
9997
9998 * term.c (tty_append_glyph): New function.
9999 (produce_stretch_glyph): Static function and its prototype deleted.
10000
a66cfb1c
SM
10001 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
10002 Add prototypes.
148ae00e 10003
c4a07a4c
PE
100042011-08-29 Paul Eggert <eggert@cs.ucla.edu>
10005
10006 * image.c (parse_image_spec): Check for nonnegative, not for positive,
10007 when checking :margin (Bug#9390).
10008 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 10009 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
10010 so that the name doesn't mislead. All uses changed.
10011
6bc8cd65
JB
100122011-08-28 Johan Bockgård <bojohan@gnu.org>
10013
10014 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
10015 set_tty_hooks.
10016
dca4927e
EZ
100172011-08-27 Eli Zaretskii <eliz@gnu.org>
10018
10019 * xdisp.c (move_it_to): Don't bail out early when reaching
10020 position beyond to_charpos, if we are scanning backwards.
10021 (move_it_vertically_backward): When DY == 0, make sure we get to
10022 the first character in the line after the newline.
10023
f2cad773
PE
100242011-08-27 Paul Eggert <eggert@cs.ucla.edu>
10025
10026 * ccl.c: Improve and simplify overflow checking (Bug#9196).
10027 (ccl_driver): Do not generate an out-of-range pointer.
10028 (Fccl_execute_on_string): Remove unnecessary check for
10029 integer overflow, noted by Stefan Monnier in
10030 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
10031 Remove a FIXME that didn't need fixing.
10032 Simplify the newly-introduced buffer reallocation code.
10033
0cae2cdb
JB
100342011-08-27 Juanma Barranquero <lekktu@gmail.com>
10035
10036 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
10037
5fc295a4 100382011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 10039
70c60eb2 10040 Integer and memory overflow issues (Bug#9196).
726e0ab1 10041
d31850da
PE
10042 * doc.c (get_doc_string): Rework so that
10043 get_doc_string_buffer_size is the actual buffer size, rather than
10044 being 1 less than the actual buffer size; this makes xpalloc more
10045 convenient.
10046
a69fbedb
PE
10047 * image.c (x_allocate_bitmap_record, cache_image):
10048 * xselect.c (Fx_register_dnd_atom):
10049 Simplify previous changes by using xpalloc.
10050
fe5c5d37
PE
10051 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
10052 since either will do and ptrdiff_t is convenient with xpalloc.
10053
0065d054
PE
10054 * charset.c (charset_table_size)
10055 (struct charset_sort_data.priority): Now ptrdiff_t.
10056 (charset_compare): Don't overflow if priorities differ greatly.
10057 (Fsort_charsets): Don't assume list length fits in int.
10058 Check for size-calculation overflow when allocating sort data.
10059 (syms_of_charset): Allocate an initial charset table that is
10060 just under 64 KiB, to avoid problems with glibc malloc and mmap.
10061
10062 * cmds.c (internal_self_insert): Check for size-calculation overflow.
10063
10064 * composite.h (struct composition.glyph_len): Now int, not unsigned.
10065 The actual value is always <= INT_MAX, and leaving it unsigned made
10066 overflow checking harder.
10067
10068 * dispextern.h (struct glyph_matrix.rows_allocated)
10069 (struct face_cache.size): Now ptrdiff_t, for convenience in use
10070 with xpalloc. The values are still always <= INT_MAX.
10071
10072 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
10073
10074 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
10075 (SAFE_NALLOCA): New macro.
10076
10077 * region-cache.c (struct boundary.pos, find_cache_boundary)
10078 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
10079 (set_cache_region, invalidate_region_cache)
10080 (revalidate_region_cache, know_region_cache, region_cache_forward)
10081 (region_cache_backward, pp_cache):
10082 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
10083 so that ptrdiff_t * can be passed to xpalloc.
10084 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
10085 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
10086 (pp_cache): Don't assume cache_len fits in int.
10087 * region-cache.h: Adjust extern decls to match.
10088
10089 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
10090 EMACS_INT, since either will do, for xpalloc.
10091
10092 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
10093 (xnmalloc, xnrealloc, xpalloc): New functions.
10094
726e0ab1
PE
10095 * bidi.c (bidi_shelve_header_size): New constant.
10096 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
10097 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
10098
51f30bc5 10099 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
10100 * buffer.c (overlays_at, overlays_in, record_overlay_string)
10101 (overlay_strings):
10102 Don't update size of array until after memory allocation succeeds,
10103 because xmalloc/xrealloc may not return.
0065d054
PE
10104 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
10105 now that we have proper integer overflow checking.
10106 (record_overlay_string, overlay_strings): Catch overflows when
10107 calculating size of overlay_str_buf.
726e0ab1 10108
0065d054
PE
10109 * callproc.c (Fcall_process): Check for size overflow when
10110 calculating size of args2.
10111 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
10112 Normally we prefer signed values, but sticking with ptrdiff_t would
10113 require adding more-complicated checks.
726e0ab1
PE
10114
10115 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
10116 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
10117 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 10118 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
10119
10120 * character.c (Fstring): Check for size-calculation overflow.
10121
10122 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
10123 unnecessary integer overflow. Check for size overflow.
10124 (encode_coding_object): Don't update size until xmalloc succeeds.
10125
10126 * composite.c (get_composition_id): Check for overflow in glyph
10127 length calculations.
10128
10129 Integer and memory overflow fixes for display code.
10130 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
10131 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
10132 (scrolling_window): Check for overflow in size calculations.
10133 (line_draw_cost, realloc_glyph_pool, add_row_entry):
10134 Don't assume glyph table len fits in int.
10135 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
10136 (row_table_size): Now ptrdiff_t, not int.
10137 (scrolling_window): Avoid overflow in size calculations.
10138 Don't update size until allocation succeeds.
10139 * fns.c (concat): Check for overflow in size calculations.
10140 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
10141 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
10142 (NEXT_ALMOST_PRIME_LIMIT): New constant.
10143
10144 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
10145 (get_doc_string): Check for size calculation overflow.
10146 Don't update size until allocation succeeds.
10147 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
10148 EMACS_INT, where ptrdiff_t will do.
10149 (Fsubstitute_command_keys): Check for string overflow.
10150
10151 * editfns.c (set_time_zone_rule): Don't assume environment length
10152 fits in int.
10153 (message_length): Now ptrdiff_t, not int.
10154 (Fmessage_box): Don't update size until allocation succeeds.
10155 Don't assume message length fits in int.
10156 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
10157
0065d054
PE
10158 * emacs.c (main): Do not reallocate argv, since there is a null at
10159 the end that can be overwritten, and this way there's no need to
10160 worry about size-calculation overflow.
10161 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
10162
10163 * eval.c (init_eval_once, grow_specpdl): Don't update size until
10164 alloc succeeds.
10165 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
10166
10167 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
10168 (x_set_scroll_bar_width, x_figure_window_size):
10169 Check for integer overflow.
10170 (x_set_alpha): Do not assume XINT fits in int.
10171
10172 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
10173 This is for the members text_lines, text_cols, total_lines, total_cols,
10174 where the system imposes an 'int' limit.
10175
10176 * fringe.c (Fdefine_fringe_bitmap):
10177 Don't update size until alloc works.
10178
10179 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
10180 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
10181
10182 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
10183 Check for size-calculation overflow.
10184 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
10185 do, as we prefer signed integers.
10186 (id_to_widget.max_size, id_to_widget.used)
10187 (xg_store_widget_in_map, xg_remove_widget_from_map)
10188 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
10189 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
10190 Use and return ptrdiff_t, not int.
10191 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
10192 * gtkutil.h: Change prototypes to match the above.
10193
10194 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
10195 are duplicate now that they've been promoted to lisp.h.
10196 (x_allocate_bitmap_record, x_alloc_image_color)
10197 (make_image_cache, cache_image, xpm_load):
10198 Don't update size until alloc is done.
10199 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
10200 (x_detect_edges):
3256efce 10201 Check for size calculation overflow.
726e0ab1
PE
10202 (ct_colors_allocated_max): New constant.
10203 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
10204 overflow.
3256efce 10205
726e0ab1
PE
10206 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
10207 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
10208 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
10209 Use ptrdiff_t, not int, to count maps.
10210 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
10211 calculations. Don't update size until allocation succeeds.
10212 Redo calculations to avoid overflow.
726e0ab1
PE
10213 * keyboard.h: Change prototypes to match the above.
10214
10215 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
10216 to count maps.
10217 (current_minor_maps): Check for size calculation overflow.
10218 * keymap.h: Change prototypes to match the above.
10219
10220 * lread.c (read1, init_obarray): Don't update size until alloc done.
10221
10222 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
10223 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
10224
726e0ab1
PE
10225 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
10226 Now ptrdiff_t, not int.
10227 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
10228 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
10229
10230 * process.c (Fnetwork_interface_list): Check for overflow
10231 in size calculation.
10232
10233 * region-cache.c (move_cache_gap): Check for size calculation overflow.
10234
10235 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
10236 overflow. Don't bother calling xmalloc when xrealloc will do.
10237
10238 * search.c (Freplace_match): Check for size calculation overflow.
10239 (Fset_match_data): Don't assume list lengths fit in 'int'.
10240
10241 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
10242 for command line length. Do not attempt to address one before the
10243 beginning of an array, as that's not portable.
10244
10245 * term.c (max_frame_lines): Remove; unused.
10246 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
10247 not int.
10248 (encode_terminal_code, calculate_costs): Check for size
10249 calculation overflow.
10250 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
10251 table lengths and related sizes. Don't update size until alloc
10252 done. Redo calculations to avoid overflow.
10253 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
10254
10255 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
10256 subtracting pointers.
10257 (gobble_line): Check for overflow more carefully. Don't update size
10258 until alloc done.
10259
10260 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
10261 Don't update size until alloc done.
10262 Redo size calculations to avoid overflow.
10263 Check for size calculation overflow.
0065d054 10264 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
10265
10266 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
10267 Use ptrdiff_t, not int, for sizes.
10268 (store_mode_line_noprop_char): Don't update size until alloc done.
10269
0065d054
PE
10270 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
10271 Use ptrdiff_t, not int, for sizes.
10272 (Finternal_make_lisp_face, cache_face):
10273 Check for size calculation overflow.
10274 (cache_face): Treat size calculation overflows as if they were
10275 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
10276
10277 * xfns.c (x_encode_text, x_set_name_internal)
10278 (Fx_change_window_property): Use ptrdiff_t, not int, to count
10279 sizes, since they can exceed INT_MAX in size. Check for size
10280 calculation overflow.
10281
0065d054
PE
10282 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
10283 (xg_select): Check for size calculation overflow.
726e0ab1
PE
10284 Don't update size until alloc done.
10285
0065d054 10286 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 10287 as sprintf is limited to int lengths.
1d526e2f 10288
252c5ee1
PE
10289 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
10290 (X_LONG_MIN): New macros.
864d7ce7
PE
10291 Use them to make the following changes clearer.
10292 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
10293 This change doesn't affect the value now, but it may help remind
10294 future maintainers not to raise the value too much later.
10295 (SELECTION_QUANTUM): Remove, replacing with ...
10296 (selection_quantum): ... new function, which avoids overflow.
10297 All uses changed.
10298 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
10299 assumption that selection length fits in 'int'.
10300 (x_reply_selection_request, x_handle_selection_request)
10301 (x_get_window_property, receive_incremental_selection)
10302 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
10303 (lisp_data_to_selection_data, clean_local_selection_data):
10304 Use ptrdiff_t, not int, to record length of selection.
10305 (x_reply_selection_request, x_get_window_property)
10306 (receive_incremental_selection, x_property_data_to_lisp):
10307 Redo calculations to avoid overflow.
10308 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 10309 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
10310 something.
10311 (x_get_window_property, receive_incremental_selection)
10312 (lisp_data_to_selection_data, x_property_data_to_lisp):
10313 Check for size-calculation overflow.
10314 (x_get_window_property, receive_incremental_selection)
10315 (lisp_data_to_selection_data, Fx_register_dnd_atom):
10316 Don't store size until memory allocation succeeds.
10317 (x_get_window_property): Plug memory leak on memory exhaustion.
10318 Don't double-block input; malloc is safe here. Don't assume 2**34
10319 - 4 fits in unsigned long. Add an xassert to check
10320 XGetWindowProperty overflow. Be more careful about overflow
10321 calculations, and distinguish size from memory overflow better.
10322 (receive_incremental_selection): When tracing, don't assume
10323 unsigned int is less than INT_MAX.
10324 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
10325 harmful) conversions of unsigned short to int.
10326 (lisp_data_to_selection_data): Don't assume that integers
10327 in the range -65535 through -1 fit in an X unsigned short.
10328 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
10329 result parameters unless successful. Rely on cons_to_unsigned
10330 to report problems with elements; the old code wasn't right anyway.
10331 (x_check_property_data): Check for int overflow; we cannot use
10332 a wider type due to X limits.
10333 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
10334
726e0ab1 10335 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 10336
0065d054
PE
10337 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
10338 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
10339 (x_color_cells): Don't store size until memory allocation succeeds.
10340 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 10341 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
10342 (x_term_init): Don't assume length fits in int (sprintf is limited
10343 to int size).
bc18e09d 10344
ebfa62c0
PE
10345 Use ptrdiff_t for composition IDs.
10346 * character.c (lisp_string_width):
10347 * composite.c (composition_table_size, n_compositions)
10348 (get_composition_id, composition_gstring_from_id):
10349 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
10350 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
10351 * window.c (Frecenter):
10352 Use ptrdiff_t, not int, for composition IDs.
10353 * composite.c (get_composition_id): Check for integer overflow.
10354 * composite.h: Adjust prototypes to match the above changes.
10355
d3411f89
PE
10356 Use ptrdiff_t for hash table indexes.
10357 * category.c (hash_get_category_set):
10358 * ccl.c (ccl_driver):
10359 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
10360 * coding.c (coding_system_charset_list, detect_coding_system):
10361 * coding.h (struct coding_system.id):
10362 * composite.c (get_composition_id, gstring_lookup_cache):
10363 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
10364 * image.c (xpm_get_color_table_h):
10365 * lisp.h (hash_lookup, hash_put):
10366 * minibuf.c (Ftest_completion):
10367 Use ptrdiff_t for hash table indexes, not int (which is too
10368 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
10369 32-bit --with-wide-int hosts).
10370
e097a6fa
PE
10371 * charset.c (Fdefine_charset_internal): Check for integer overflow.
10372 Add a FIXME comment about memory leaks.
10373 (syms_of_charset): Don't assume xmalloc returns.
10374
5637687f
PE
10375 Don't assume that stated character widths fit in int.
10376 * character.c (Fchar_width, c_string_width, lisp_string_width):
10377 * character.h (CHAR_WIDTH):
10378 * indent.c (MULTIBYTE_BYTES_WIDTH):
10379 Use sanitize_char_width to avoid undefined and/or bad behavior
10380 with outlandish widths.
a66cfb1c 10381 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
10382 now that we have two such functions. All uses changed.
10383 (sanitize_char_width): New inline function.
10384
a2271ba2
PE
10385 Don't assume that tab-width fits in int.
10386 * character.h (sanitize_width): New inline function.
10387 (SANE_TAB_WIDTH): New macro.
10388 (ASCII_CHAR_WIDTH): Use it.
10389 * indent.c (sane_tab_width): Remove. All uses replaced by
10390 SANE_TAB_WIDTH (current_buffer).
10391 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
10392
18c52557
PE
10393 * fileio.c: Integer overflow issues with file modes.
10394 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
10395
caeeedc1
PE
10396 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
10397 Remove unreachable code.
10398 (read_hex, load_charset_map_from_file): Check for integer overflow.
10399
6df6ae42 10400 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
10401 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
10402 (x_send_scroll_bar_event): Likewise. Check that the size does not
10403 exceed limits imposed by XClientMessageEvent, as well as the usual
10404 ptrdiff_t and size_t limits.
10405
b13995db
PE
10406 * keyboard.c: Overflow, signedness and related fixes.
10407 (make_lispy_movement): Use same integer type in forward decl
10408 that is used in the definition.
10409 (read_key_sequence, keyremap_step):
10410 Change bufsize argument back to int, undoing my 2011-03-30 change.
10411 We prefer signed types, and int is wide enough here.
10412 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
10413 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
10414 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
10415 length, not size_t. Use ptrdiff_t for index, not int.
10416 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
10417 possibility of integer overflow.
10418
13464394
PE
10419 Overflow, signedness and related fixes for images.
10420
10421 * dispextern.h (struct it.stack[0].u.image.image_id)
10422 (struct_it.image_id, struct image.id, struct image_cache.size)
10423 (struct image_cache.used, struct image_cache.ref_count):
10424 * gtkutil.c (update_frame_tool_bar):
10425 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
10426 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
10427 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
10428 * nsmenu.m (update_frame_tool_bar):
10429 * xdisp.c (calc_pixel_width_or_height):
10430 * xfns.c (image_cache_refcount):
10431 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
10432 on typical 64-bit hosts.
10433
10434 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
10435 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
10436 Omit unnecessary casts to int.
10437 (parse_image_spec): Check that integers fall into 'int' range
10438 when the callers expect that.
10439 (image_ascent): Redo ascent calculation to avoid int overflow.
10440 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
10441 (lookup_image): Remove unnecessary tests.
10442 (xbm_image_p): Locals are now of int, not EMACS_INT,
10443 since parse_image_check makes sure they fit into int.
10444 (png_load, gif_load, svg_load_image):
10445 Prefer int to unsigned where either will do.
10446 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
10447 old tiff_error_handler and tiff_warning_handler.
10448 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
10449 stack buffer overflows. It uses only the features of vsnprintf
10450 that are common to both POSIX and native Microsoft.
10451 (tiff_error_handler, tiff_warning_handler): Use it.
10452 (tiff_load, gif_load, imagemagick_load_image):
10453 Don't assume :index value fits in 'int'.
10454 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
10455 (imagemagick_load_image): Check that crop parameters fit into
10456 the integer types that MagickCropImage accepts. Don't assume
10457 Vimagemagick_render_type has a nonnegative value. Don't assume
10458 size_t fits in 'long'.
10459 (gs_load): Use printmax_t to print the widest integers possible.
10460 Check for integer overflow when computing image height and width.
10461
c11821d4
EZ
104622011-08-26 Eli Zaretskii <eliz@gnu.org>
10463
10464 * xdisp.c (redisplay_window): Don't force window start if point
10465 will be invisible in the resulting window. (Bug#9324)
10466
0c95fcf7
EZ
104672011-08-25 Eli Zaretskii <eliz@gnu.org>
10468
10469 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
10470 the display spec is of the form `(space ...)'.
10471 (handle_display_spec): Return the value returned by
10472 handle_single_display_spec, not just 1 or zero.
10473 (handle_single_display_spec): If the display spec is of the form
10474 `(space ...)', and specifies display in the text area, return 2
10475 rather than 1.
fee65a97 10476 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
10477 accurately, and prefer exact match for point under bidi.
10478 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
10479
10480 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
10481 into disp_prop; all users changed.
10482
10483 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
10484 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
10485 for the text covered by the display property.
10486
e4ed06f1
CY
104872011-08-25 Chong Yidong <cyd@stupidchicken.com>
10488
10489 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
10490 Change return value to nil.
10491 (Frecord_buffer): Delete unused function.
10492
f67cdd7f
EZ
104932011-08-24 Eli Zaretskii <eliz@gnu.org>
10494
5980d4c6
EZ
10495 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
10496 buffers, return left-to-right.
8610fe8b
EZ
10497 (set_cursor_from_row): Consider candidate row a win if its glyph
10498 represents a newline and point is on that newline. Fixes cursor
10499 positioning on the newline at EOL of R2L text within L2R
10500 paragraph, and vice versa.
10501 (try_cursor_movement): Check continued rows, in addition to
10502 continuation rows. Fixes unwarranted scroll when point enters a
10503 continued line of R2L text within an L2R paragraph, or vice versa.
10504 (cursor_row_p): Consider the case of point being equal to
10505 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
10506 from the end of a short line to the beginning of a continued line
10507 of R2L text within L2R paragraph.
10508 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
10509 composed characters.
5980d4c6 10510
f67cdd7f
EZ
10511 * bidi.c (bidi_check_type): Use xassert.
10512 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
10513 members.
10514
bca633fb
EZ
105152011-08-23 Eli Zaretskii <eliz@gnu.org>
10516
10517 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
10518 a character.
10519
4a5885a7
CY
105202011-08-23 Chong Yidong <cyd@stupidchicken.com>
10521
10522 * nsfont.m (ns_otf_to_script): Fix typo.
10523
0902a04e
KH
105242011-08-22 Kenichi Handa <handa@m17n.org>
10525
10526 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
10527 extra slot even if the purpose is char-code-property-table.
10528
1a2e6670
EZ
105292011-08-23 Eli Zaretskii <eliz@gnu.org>
10530
8ddde651
EZ
10531 * xdisp.c (redisplay_window): When computing centering_position,
10532 account for the height of the header line. (Bug#8874)
10533
425cc014
EZ
10534 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
10535 instead of CHAR_TO_BYTE. Fixes a crash when a completion
10536 candidate is selected by the mouse, and that candidate has a
10537 composed character under the mouse.
10538
1a2e6670
EZ
10539 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
10540 coordinates reported by pos-visible-in-window-p for a composed
10541 character in column zero.
10542
8b76d6f8
SM
105432011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
10544
10545 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
10546
dac347dd
EZ
105472011-08-22 Eli Zaretskii <eliz@gnu.org>
10548
10549 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
10550 consider it a hit if to_charpos is anywhere in the range of the
10551 composed buffer positions.
10552
e013fb34
CY
105532011-08-22 Chong Yidong <cyd@stupidchicken.com>
10554
10555 * image.c (gif_load): Don't assume that each subimage has the same
10556 dimensions as the base image. Handle disposal method that is
10557 "undefined" by the gif spec (Bug#9335).
10558
bd1ba3e8
CY
105592011-08-20 Chong Yidong <cyd@stupidchicken.com>
10560
10561 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 10562 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 10563
54a1215b
EZ
105642011-08-19 Eli Zaretskii <eliz@gnu.org>
10565
823564e5
EZ
10566 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
10567 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
10568 from an Org mode buffer to a Speedbar frame.
10569
54a1215b
EZ
10570 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
10571 a composition, take its buffer position from IT->cmp_it.charpos.
10572 Fixes cursor positioning at the beginning of a line that begins
10573 with a composed character.
10574
9778ebcc
EZ
105752011-08-18 Eli Zaretskii <eliz@gnu.org>
10576
0be6ee06
EZ
10577 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
10578 character bidirectional type, use STRONG_L instead. Fixes crashes
10579 in a buffer produced by `describe-categories'.
10580
9778ebcc
EZ
10581 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
10582 members before the level stack, so they would be saved and
10583 restored when copying iterator state. Fixes incorrect reordering
10584 around TABs covered by display properties.
10585
156bffbe
AS
105862011-08-18 Andreas Schwab <schwab@linux-m68k.org>
10587
6b02f655 10588 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 10589
72ad093b
CY
105902011-08-17 Chong Yidong <cyd@stupidchicken.com>
10591
10592 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
10593 (internal_condition_case_2, internal_condition_case_n):
10594 Remove unnecessary aborts (Bug#9081).
72ad093b 10595
35774242
EZ
105962011-08-17 Eli Zaretskii <eliz@gnu.org>
10597
10598 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
10599 has no `load' handler, try opening the file locally. (Bug#9311)
10600
db76dd85
KB
106012011-08-16 Ken Brown <kbrown@cornell.edu>
10602
10603 * gmalloc.c: Expand comment.
10604
b215eee5
EZ
106052011-08-16 Eli Zaretskii <eliz@gnu.org>
10606
10607 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
10608 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
10609
a4579d33
KB
106102011-08-16 Ken Brown <kbrown@cornell.edu>
10611
10612 Fix memory allocation problems in Cygwin build (Bug#9273).
10613
10614 * unexcw.c ( __malloc_initialized): Declare external variable.
10615 (fixup_executable): Force the dumped emacs to reinitialize malloc.
10616
8b76d6f8
SM
10617 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
10618 New variables.
a4579d33
KB
10619 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
10620 dumped emacs.
10621 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
10622 in the static heap.
10623 [CYGWIN] (special_realloc): New function.
10624 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
10625 requests to realloc storage in the static heap.
10626
3ebec551
PE
106272011-08-15 Paul Eggert <eggert@cs.ucla.edu>
10628
10629 * bidi.c (bidi_initialize): Remove unused local.
10630
9fd8be00
EZ
106312011-08-15 Eli Zaretskii <eliz@gnu.org>
10632
6b02f655
SM
10633 * bidimirror.h:
10634 * biditype.h: Remove file.
10635 * makefile.w32-in ($(BLD)/bidi.$(O)):
10636 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
10637
10638 * dispextern.h: Fix a typo in the comment to bidi_type_t.
10639
10640 * chartab.c: Improve commentary for the uniprop_table API.
10641
32413314
EZ
10642 * bidi.c (bidi_paragraph_init): Support zero value of
10643 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
10644 (bidi_initialize): Use uniprop_table instead of including
10645 biditype.h and bidimirror.h.
32413314 10646
9fd8be00
EZ
10647 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
10648 coordinates of the iterator when restoring from ppos_it.
10649 (Bug#9296)
10650
5cf2b69b
KH
106512011-08-14 Kenichi Handa <handa@m17n.org>
10652
10653 * process.c (create_process): Call setup_process_coding_systems
72ad093b 10654 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 10655
daf17d00
EZ
106562011-08-14 Eli Zaretskii <eliz@gnu.org>
10657
10658 * xdisp.c (move_it_in_display_line_to): Don't invoke
10659 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
10660 ppos_it. Fixes vertical cursor motion when line beginning is
10661 covered by an image. (Bug#9296)
10662
08e3161a
JD
106632011-08-14 Jan Djärv <jan.h.d@swipnet.se>
10664
10665 * nsterm.h (ns_run_ascript): Declare.
10666 (NSAPP_DATA2_RUNASSCRIPT): Define.
10667
10668 * nsfns.m (as_script, as_result, as_status): New static variables.
10669 (ns_run_ascript): New function.
5e617bc2 10670 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
10671 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
10672 the event loop. Get status from as_status (Bug#7276).
10673
10674 * nsterm.m (sendEvent): If event is NSApplicationDefined and
10675 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
10676 the event loop (Bug#7276).
10677
a3720aa2
AS
106782011-08-14 Andreas Schwab <schwab@linux-m68k.org>
10679
10680 * gnutls.c (QCgnutls_bootprop_priority)
10681 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
10682 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
10683 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
10684 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
10685 (QCgnutls_bootprop_verify_hostname_error)
10686 (QCgnutls_bootprop_callbacks_verify): Rename from
10687 Qgnutls_bootprop_..., all uses changed.
10688
10689 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
10690 uses changed.
10691
0a0d27fb
PE
106922011-08-14 Paul Eggert <eggert@cs.ucla.edu>
10693
19d5c50c
PE
10694 * xfaces.c (Qframe_set_background_mode): Now static.
10695 * dispextern.h (Qframe_set_background_mode): Remove decl.
10696
0a0d27fb
PE
10697 * process.c (Fnetwork_interface_info): Declare local only if needed.
10698
377538cb
JD
106992011-08-13 Jan Djärv <jan.h.d@swipnet.se>
10700
10701 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
10702 (Fnetwork_interface_list): Allocate in increments of bytes instead
10703 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
10704 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
10705 sockaddr.
10706 (struct ifflag_def): notrailers is smart on OSX.
10707 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
10708 Get hardware address with getifaddrs if available.
10709
08fff70c
EZ
107102011-08-12 Eli Zaretskii <eliz@gnu.org>
10711
10712 * xdisp.c (iterate_out_of_display_property): xassert that
10713 IT->position is set to within IT->object's boundaries. Break from
10714 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
10715 when IT->position is set up wrongly due to some bug.
10716 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
10717 (push_display_prop): Allow GET_FROM_STRING as IT->method on
10718 entry. Force push_it to save on the stack the current
10719 buffer/string position, to be restored by pop_it. Fix flags in
10720 the iterator structure wrt the object coming from a display
10721 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
10722 properties. (Bug#9284)
10723
7be1c708 107242011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 10725
7be1c708
CY
10726 * fontset.c (fontset_get_font_group): Add proper type checks.
10727 (Bug#9172)
aac0c6e3 10728
7be1c708 107292011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 10730
7be1c708
CY
10731 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
10732 and LC_VERSION_MIN_MACOSX.
10733 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
10734 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 10735
97bb72a6
EZ
107362011-08-08 Eli Zaretskii <eliz@gnu.org>
10737
10738 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
10739 no-display-properties-and-no-overlays under bidi display.
10740 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 10741 properties and overlays.
97bb72a6 10742
d5617611
CY
107432011-08-08 Chong Yidong <cyd@stupidchicken.com>
10744
37e11a63
CY
10745 * editfns.c (Fset_time_zone_rule): Document relationship with the
10746 setenv function.
10747
d5617611
CY
10748 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
10749 the font entity extracted from the cache (Bug#8109).
10750
58872834
CY
107512011-08-07 Chong Yidong <cyd@stupidchicken.com>
10752
10753 * composite.c (autocmp_chars): Don't reset point. That is done by
10754 restore_point_unwind (Bug#5984).
10755
75bfc667
JL
107562011-08-07 Juri Linkov <juri@jurta.org>
10757
10758 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
10759 to show the arg `TIME' instead of `TIMEVAL'.
10760
d1410150
EZ
107612011-08-06 Eli Zaretskii <eliz@gnu.org>
10762
10763 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
10764 display property strides EOL and includes a newline, as in
10765 longlines-mode. (Bug#9254)
75b771e4
EZ
10766 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
10767 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
10768
10769 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
10770 is non-zero, even if the data buffer is NULL. Fixes a crash in
10771 vertical-motion with longlines-mode. (Bug#9254)
10772
35928349
EZ
107732011-08-05 Eli Zaretskii <eliz@gnu.org>
10774
ec7cc85b
EZ
10775 * bidi.c <bidi_cache_total_alloc>: Now static.
10776 (bidi_initialize): Initialize bidi_cache_total_alloc.
10777
8b76d6f8 10778 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
10779 cache. (Bug#9221)
10780
10781 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
10782 amount allocated this far in `bidi_cache_total_alloc'.
10783 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
10784 non-zero, only free the data buffer without restoring the cache
10785 contents. All callers changed.
10786
10787 * dispextern.h (bidi_unshelve_cache): Update prototype.
10788
10789 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
10790 (move_it_in_display_line, move_it_to)
10791 (move_it_vertically_backward, move_it_by_lines): Replace the call
10792 to xfree to an equivalent call to bidi_unshelve_cache.
10793 (move_it_in_display_line_to): Fix logic of returning
412b6358 10794 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 10795
e2e2423b
EZ
107962011-08-05 Eli Zaretskii <eliz@gnu.org>
10797
10798 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
10799 came from a string character with a `cursor' property. (Bug#9229)
10800
ae9e757a
JD
108012011-08-04 Jan Djärv <jan.h.d@swipnet.se>
10802
10803 * Makefile.in (LIB_PTHREAD): New variable.
10804 (LIBES): Add LIB_PTHREAD (Bug#9216).
10805
10806 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
10807 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
10808
213bd7f2
AS
108092011-08-04 Andreas Schwab <schwab@linux-m68k.org>
10810
6b02f655 10811 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 10812
99aaf75f
JD
108132011-08-04 Jan Djärv <jan.h.d@swipnet.se>
10814
10815 * xterm.c (x_find_topmost_parent): New function.
10816 (x_set_frame_alpha): Find topmost parent window with
10817 x_find_topmost_parent and set the property there also (bug#9181).
10818 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
10819
c74e9d86
PE
108202011-08-04 Paul Eggert <eggert@cs.ucla.edu>
10821
10822 * callproc.c (Fcall_process): Avoid vfork clobbering
10823 the local vars buffer, coding_systems, current_dir.
10824
640c8776
SM
108252011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
10826
10827 * keymap.c (Fmake_composed_keymap): Move to subr.el.
10828
f26d0e4c
PE
108292011-08-03 Paul Eggert <eggert@cs.ucla.edu>
10830
8a10d76c
PE
10831 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
10832 so that it is not optimized away.
10833
f26d0e4c
PE
10834 * xdisp.c (compute_display_string_pos): Remove unused local.
10835
55439c61
EZ
108362011-08-02 Eli Zaretskii <eliz@gnu.org>
10837
10838 Fix slow cursor motion and scrolling in large buffers with
10839 selective display, like Org Mode buffers. (Bug#9218)
10840
10841 * dispextern.h (struct bidi_it): New member disp_prop_p.
10842
10843 * xdisp.c: Remove one-slot cache of display string positions.
10844 (compute_display_string_pos): Accept an additional argument
5e617bc2 10845 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
10846 for a display string or property. If found, set DISP_PROP_P
10847 non-zero.
10848
10849 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
10850 DISP_PROP_P, and pass it to compute_display_string_pos.
10851 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
10852 non-zero. All callers of bidi_fetch_char changed.
10853
fb33fa43
SM
108542011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
10855
10856 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
10857
b099e063
DM
108582010-12-03 Don March <don@ohspite.net>
10859
10860 * keymap.c (Fdefine_key): Fix non-prefix key error message when
10861 last character M-[char] is translated to ESC [char] (bug#7541).
10862
5cc7f7af
KH
108632011-08-02 Kenichi Handa <handa@m17n.org>
10864
d0fffa3f 10865 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
10866
10867 * chartab.c (uniprop_table): Make it non-static.
10868
525d5e6e
EZ
108692011-08-01 Eli Zaretskii <eliz@gnu.org>
10870
10871 * xdisp.c (forward_to_next_line_start): Accept additional argument
10872 BIDI_IT_PREV, and store into it the state of the bidi iterator had
10873 on the newline.
10874 (reseat_at_next_visible_line_start): Use the bidi iterator state
10875 returned by forward_to_next_line_start to restore the state of
10876 it->bidi_it after backing up to previous newline. (Bug#9212)
10877
31011111
AS
108782011-07-30 Andreas Schwab <schwab@linux-m68k.org>
10879
10880 * regex.c (re_comp): Protoize.
10881 (re_exec): Fix return type.
10882 (regexec): Fix type of `ret'. (Bug#9203)
10883
476371c4
PE
108842011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10885
e5d76069
PE
10886 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
10887 This is needed if max-image-size is a floating-point number.
10888
9a79b20c
AS
108892011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10890
10891 * print.c (print_object): Print empty symbol as ##.
10892
10893 * lread.c (read1): Read ## as empty symbol.
10894
d8c2fa78
AA
108952011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
10896
10897 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
10898 setting frame foreground color (Bug#9175).
10899 (x_set_background_color): Likewise.
10900
ffe57a7a
AA
10901 * nsmenu.m (-setText): Size tooltip dimensions precisely to
10902 contents (Bug#9176).
10903 (EmacsTooltip -init): Remove bezels and add shadows to
10904 tooltip windows.
10905
bf3492a5
AA
10906 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
10907 or scroll bar (Bug#8470).
10908
d55e9c53
AA
10909 * nsfont.m (nsfont_open): Remove assignment to voffset and
10910 unnecessary vars hshink, expand, hd, full_height, min_height.
10911 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
10912
10913 * nsterm.h (nsfont_info): Remove voffset field.
10914
d8c2fa78 109152011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
10916
10917 Implement strike-through and overline on NextStep (Bug#8863).
10918
10919 * nsfont.m (nsfont_open): Use underline position provided by font,
10920 instead of hard-coded value of 2.
10921 (nsfont_draw): Call ns_draw_text_decoration instead.
10922
10923 * nsterm.h: Add declaration for ns_draw_text_decoration.
10924
10925 * nsterm.m (ns_draw_text_decoration): New function for drawing
10926 underline, overline, and strike-through.
10927 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
10928 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 10929 accommodate underlining, etc.
4843aac3 10930
4cc60b9b
EZ
109312011-07-28 Eli Zaretskii <eliz@gnu.org>
10932
bc7ece87
EZ
10933 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
10934 default.
4cc60b9b 10935
476371c4
PE
109362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10937
66606eea
PE
10938 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
10939 Without this fix, if a signal arrives just after memory fills up,
10940 'malloc' might be invoked reentrantly.
10941
476371c4
PE
10942 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
10943 In other words, assume that every image size is allowed, on non-X
10944 hosts. This assumption is probably wrong, but it lets Emacs compile.
10945
f3fcc40d
AS
109462011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10947
10948 * regex.c (re_iswctype): Convert return values to boolean.
10949
350c992f
EZ
109502011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
10951
10952 * xdisp.c (compute_display_string_pos): Don't use cached display
10953 string position if the buffer had its restriction changed.
10954 (Bug#9184)
10955
5266b4bb
PE
109562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10957
10958 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10959
2573a837 109602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 10961
41f55ccd 10962 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 10963
39e378da
PE
10964 * bidi.c: Integer size and overflow fixes.
10965 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
10966 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
10967 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10968 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
10969 (bidi_find_other_level_edge):
10970 Use ptrdiff_t instead of EMACS_INT where either will do.
10971 This works better on 32-bit hosts configured --with-wide-int.
10972 (bidi_cache_ensure_space): Check for size-calculation overflow.
10973 Use % rather than repeated addition, for better worst-case speed.
10974 Don't set bidi_cache_size until after xrealloc returns, because it
10975 might not return.
10976 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
10977 (bidi_cache_ensure_space): Also check that the bidi cache size
10978 does not exceed that of the largest Lisp string or buffer. See Eli
10979 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 10980
5e927815
PE
10981 * alloc.c (__malloc_size_t): Remove.
10982 All uses replaced by size_t. See Andreas Schwab's note
10983 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
10984
ca4aa935
PE
10985 * image.c: Improve checking for integer overflow.
10986 (check_image_size): Assume that f is nonnull, since
10987 it is always nonnull in practice. This is one less thing to
10988 worry about when checking for integer overflow later.
10989 (x_check_image_size): New function, which checks for integer
10990 overflow issues inside X.
10991 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
10992 This removes the need for a memory_full check.
10993 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
10994 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
10995 (xbm_read_bitmap_data): Change locals back to 'int', since
10996 their values must fit in 'int'.
10997 (xpm_load_image, png_load, tiff_load):
10998 Invoke x_create_x_image_and_pixmap earlier,
10999 to avoid much needless work if the image is too large.
11000 (tiff_load): Treat overly large images as if
11001 x_create_x_image_and_pixmap failed, not as malloc failures.
11002 (gs_load): Use x_check_image_size.
11003
5f8f9cc2
PE
11004 * gtkutil.c: Omit integer casts.
11005 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
11006 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
11007
5adf60bc
PE
11008 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
11009
c8907a93
PE
11010 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
11011 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
11012 would wrongly return t on a 64-bit host.
11013
e3c25c68
PE
11014 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
11015 The plain *_OVERFLOW macros run afoul of GCC bug 49705
11016 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
11017 and therefore cause GCC to emit a bogus diagnostic in some cases.
11018
3f791afe
PE
11019 * image.c: Integer signedness and overflow and related fixes.
11020 This is not an exhaustive set of fixes, but it's time to
11021 record what I've got.
11022 (lookup_pixel_color, check_image_size): Remove redundant decls.
11023 (check_image_size): Don't assume that arbitrary EMACS_INT values
11024 fit in 'int', or that arbitrary 'double' values fit in 'int'.
11025 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
11026 (tiff_load, imagemagick_load_image):
11027 Check for overflow in size calculations.
11028 (x_create_x_image_and_pixmap): Remove unnecessary test for
11029 xmalloc returning NULL; that can't happen.
11030 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
11031 (xpm_color_bucket): Use better integer hashing function.
11032 (xpm_cache_color): Don't possibly over-allocate memory.
11033 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
11034 (gif_memory_source):
11035 Use ptrdiff_t, not int or size_t, to record sizes.
11036 (png_load): Don't assume values greater than 2**31 fit in 'int'.
11037 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
11038 either works, as we prefer signed integers.
11039 (tiff_read_from_memory, tiff_write_from_memory):
11040 Return tsize_t, not size_t, since that's what the TIFF API wants.
11041 (tiff_read_from_memory): Don't fail simply because the read would
11042 go past EOF; instead, return a short read.
11043 (tiff_load): Omit no-longer-needed casts.
11044 (Fimagemagick_types): Don't assume size fits into 'int'.
11045
3cc5a532
PE
11046 Improve hashing quality when configured --with-wide-int.
11047 * fns.c (hash_string): New function, taken from sxhash_string.
11048 Do not discard information about ASCII character case; this
11049 discarding is no longer needed.
11050 (sxhash-string): Use it. Change sig to match it. Caller changed.
11051 * lisp.h: Declare it.
11052 * lread.c (hash_string): Remove, since we now use fns.c's version.
11053 The fns.c version returns a wider integer if --with-wide-int is
11054 specified, so this should help the quality of the hashing a bit.
11055
b312a492
PE
11056 * emacs.c: Integer overflow minor fix.
11057 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
11058 Define only if GNU_LINUX.
11059 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
11060
dfd153ae
PE
11061 * dispnew.c: Integer signedness and overflow fixes.
11062 Remove unnecessary forward decls, that were a maintenance hassle.
11063 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
11064 All uses changed.
11065 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
11066 (scrolling_window): Use ptrdiff_t, not int, for byte count.
11067 (prepare_desired_row, line_draw_cost):
11068 Use int, not unsigned, where either works.
11069 (save_current_matrix, restore_current_matrix):
11070 Use ptrdiff_t, not size_t, where either works.
11071 (init_display): Check for overflow more accurately, and without
11072 relying on undefined behavior.
11073
a81d11a3
PE
11074 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
11075 Remove, replacing with the new symbols in lisp.h. All uses changed.
11076 * fileio.c (make_temp_name):
11077 * filelock.c (lock_file_1, lock_file):
11078 * xdisp.c (message_dolog):
11079 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
11080 Use pMd etc. instead.
11081 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
11082 replacing the pWIDE etc. symbols removed from editfns.c.
11083
3300e6fd
PE
11084 * keyboard.h (num_input_events): Now uintmax_t.
11085 This is (very slightly) less likely to mess up due to wraparound.
11086 All uses changed.
11087
fd05c7e9
PE
11088 * buffer.c: Integer signedness fixes.
11089 (alloc_buffer_text, enlarge_buffer_text):
11090 Use ptrdiff_t rather than size_t when either will do, as we prefer
11091 signed integers.
11092
903fe15d
PE
11093 * alloc.c: Integer signedness and overflow fixes.
11094 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
11095 (__malloc_size_t): Default to size_t, not to int.
11096 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
11097 (Fgarbage_collect, mark_object_loop_halt, mark_object):
11098 Prefer ptrdiff_t to size_t when either would do, as we prefer
11099 signed integers.
11100 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
11101 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
11102 Now const. Initialize with values that are in range even if char
11103 is signed.
11104 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
11105 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
11106 These functions do the right thing with sizes > 2**32.
11107 (check_depth): Now ptrdiff_t, not int.
11108 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
11109 Adjust to new way of storing sizes. Check for size overflow bugs
11110 in rest of code.
11111 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
11112 slightly wrong anyway, as it missed one instance of
11113 XMALLOC_OVERRUN_CHECK_OVERHEAD.
11114 (refill_memory_reserve): Omit needless cast to size_t.
11115 (mark_object_loop_halt): Mark as externally visible.
11116
ac82cc6a
PE
11117 * xselect.c: Integer signedness and overflow fixes.
11118 (Fx_register_dnd_atom, x_handle_dnd_message):
11119 Use ptrdiff_t, not size_t, since we prefer signed.
11120 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
11121 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
11122 x_dnd_atoms_size and x_dnd_atoms_length.
11123
c2d1e36d
PE
11124 * doprnt.c: Prefer signed to unsigned when either works.
11125 * eval.c (verror):
11126 * doprnt.c (doprnt):
11127 * lisp.h (doprnt):
11128 * xdisp.c (vmessage):
11129 Use ptrdiff_t, not size_t, when using or implementing doprnt,
11130 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
11131 prefer signed arithmetic to avoid comparison confusion.
11132 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
11133 but is a bit tricky.
11134
0e926e56
PE
11135 Assume freestanding C89 headers, string.h, stdlib.h.
11136 * data.c, doprnt.c, floatfns.c, print.c:
11137 Include float.h unconditionally.
11138 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
11139 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
11140 * regex.c: Likewise for stddef.h, string.h.
11141 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
11142 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
11143 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
11144 (STDC_HEADERS): Remove obsolete defines.
11145 * sysdep.c: Include limits.h unconditionally.
11146
9cfdb3ec
PE
11147 Assume support for memcmp, memcpy, memmove, memset.
11148 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
11149 * regex.c (memcmp, memcpy):
11150 Remove; we assume C89 now.
11151
11152 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
11153 (__malloc_safe_bcopy): Remove; no longer needed.
11154
cf950e6b 11155 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
11156 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
11157 well either way, and we prefer signed to unsigned.
11158
dbf38e02
LMI
111592011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
11160
11161 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
11162 closes the connection while we're reading (bug#9182).
11163
d6f0886c 111642011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 11165
d6f0886c
JD
11166 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
11167 are specified (Bug#9168).
24e0f6b1 11168
2eb1f9e6
PE
111692011-07-25 Paul Eggert <eggert@cs.ucla.edu>
11170
11171 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
11172 Found by GCC static checking and --with-wide-int on a 32-bit host.
11173
22381272 111742011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
11175
11176 * xdisp.c (compute_display_string_pos): Fix logic of caching
11177 previous display string position. Initialize cached_prev_pos to
11178 -1. Fixes slow-down at the beginning of a buffer.
11179
f25e39b4
EZ
111802011-07-24 Eli Zaretskii <eliz@gnu.org>
11181
11182 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
11183 for attrs[LFACE_FONTSET_INDEX].
11184
04c4b52e
PE
111852011-07-23 Paul Eggert <eggert@cs.ucla.edu>
11186
11187 * xml.c (parse_region): Remove unused local
11188 that was recently introduced.
11189
c1734fbd
EZ
111902011-07-23 Eli Zaretskii <eliz@gnu.org>
11191
be18c5a5
EZ
11192 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
11193 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
11194
c1734fbd
EZ
11195 * xdisp.c (move_it_in_display_line_to): Record the best matching
11196 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
11197 exit if none of the characters scanned was an exact match.
11198 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
11199 when exact match is impossible due to invisible text, and the
11200 lines are truncated.
11201
a258d627
JD
112022011-07-23 Jan Djärv <jan.h.d@swipnet.se>
11203
11204 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
11205 for OSX >= 10.7.
11206
b6d5a689
EZ
112072011-07-22 Eli Zaretskii <eliz@gnu.org>
11208
0f74f785
EZ
11209 Fix a significant slow-down of cursor motion with C-n, C-p,
11210 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
11211 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 11212 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
11213 (next_element_from_buffer): Call compute_stop_pos_backwards to
11214 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
11215 base_level_stop.
11216 (reseat): Don't look for prev_stop, as that could mean a very long
11217 run.
11218 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
11219 <cached_disp_overlay_modiff>: Cache for last found display string
11220 position.
551918c1 11221 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
11222 about the same buffer in the same area of character positions, and
11223 the buffer wasn't changed since the time the display string
11224 position was cached.
551918c1 11225
b2d0c91a
EZ
112262011-07-22 Eli Zaretskii <eliz@gnu.org>
11227
11228 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
11229 is an integer, which is important for empty lines. (Bug#9149)
11230
043604ee
CY
112312011-07-22 Chong Yidong <cyd@stupidchicken.com>
11232
11233 * frame.c (Fmodify_frame_parameters): In tty case, update the
11234 default face if necessary (Bug#4238).
11235
da4adb04
CY
112362011-07-21 Chong Yidong <cyd@stupidchicken.com>
11237
11238 * editfns.c (Fstring_to_char): No need to explain what a character
11239 is in the docstring (Bug#6576).
11240
9abd0532
LMI
112412011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11242
11243 * xml.c (parse_region): Make sure we always return a tree.
11244
36881d16
HK
112452011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
11246
11247 * xml.c (parse_region): If a document contains only comments,
11248 return that, too.
11249
1e98674d
LMI
112502011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11251
11252 * xml.c (make_dom): Return comments, too.
11253
590bd467
PE
112542011-07-19 Paul Eggert <eggert@cs.ucla.edu>
11255
11256 Port to OpenBSD.
11257 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
11258 and the surrounding thread.
11259 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
11260 rather than fgets, and retry after EINTR. Otherwise, 'emacs
11261 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
11262 timer goes off.
11263 * s/openbsd.h (BROKEN_SIGIO): Define.
11264 * unexelf.c (unexec) [__OpenBSD__]:
11265 Don't update the .mdebug section of the Alpha COFF symbol table.
11266
f41628b2
LMI
112672011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
11268
11269 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
11270 (bug#8460).
11271
b59b67c5
PE
112722011-07-18 Paul Eggert <eggert@cs.ucla.edu>
11273
15e3a074
PE
11274 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
11275 This fixes some race conditions on the permissions of any newly
11276 created file.
11277
41bed37d
PE
11278 * alloc.c (valid_pointer_p): Use pipe, not open.
11279 This fixes some permissions issues when debugging.
11280
b59b67c5
PE
11281 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
11282 If fchown fails to set both uid and gid, try to set just gid,
11283 as that is sometimes allowed. Adjust the file's mode to eliminate
11284 setuid or setgid bits that are inappropriate if fchown fails.
11285
925a6be7
SM
112862011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
11287
11288 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
11289 to compare Lisp_Objects.
11290 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
11291 global_gnutls_log_level, don't mistake it for a Lisp_Object.
11292 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
11293
52968808
AS
112942011-07-17 Andreas Schwab <schwab@linux-m68k.org>
11295
0a6a104b
AS
11296 * lread.c (read_integer): Unread even EOF character.
11297 (read1): Likewise. Properly record start position of symbol.
11298
52968808
AS
11299 * lread.c (read1): Read `#:' as empty uninterned symbol if no
11300 symbol character follows.
11301
9e381cdd
PE
113022011-07-17 Paul Eggert <eggert@cs.ucla.edu>
11303
11304 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
11305 This works around a problem with the previous change to Fcopy_file.
11306 Recent glibc declares fchown with __attribute__((warn_unused_result)),
11307 and without this change, GCC might complain about discarding
11308 fchown's return value.
11309
b5641435
JB
113102011-07-16 Juanma Barranquero <lekktu@gmail.com>
11311
11312 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
11313
a8031457
PE
113142011-07-16 Paul Eggert <eggert@cs.ucla.edu>
11315
11316 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
11317
dd889327
LMI
113182011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
11319
750c33f7
LMI
11320 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
11321 it's used from the C level.
11322
dd889327
LMI
11323 * process.c: Use the same condition for POLL_FOR_INPUT in both
11324 keyboard.c and process.c (bug#1858).
11325
87e86684
LM
113262011-07-09 Lawrence Mitchell <wence@gmx.li>
11327
11328 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
11329 (Fgnutls_boot): Use it.
11330
64348f40
AS
113312011-07-15 Andreas Schwab <schwab@linux-m68k.org>
11332
11333 * doc.c (Fsubstitute_command_keys): Revert last change.
11334
1d698799
LMI
113352011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
11336
f863868c
LMI
11337 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
11338 quotes the next character, and doesn't affect other longer
11339 sequences (bug#8935).
11340
1d698799
LMI
11341 * lread.c (syms_of_lread): Clarify that is isn't only
11342 `eval-buffer' and `eval-defun' that's affected by
11343 `lexical-binding' (bug#8460).
11344
aa4b6df6
EZ
113452011-07-15 Eli Zaretskii <eliz@gnu.org>
11346
11347 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 11348 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 11349
5d856da6
PE
113502011-07-14 Paul Eggert <eggert@cs.ucla.edu>
11351
ad6042bb
PE
11352 Fix minor problems found by static checking.
11353 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
11354 (elsz): Now a signed constant, not a size_t var. We prefer signed
11355 types to unsigned, to avoid integer comparison confusion. Without
11356 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
11357 "cannot optimize loop, the loop counter may overflow", a symptom
11358 of the confusion.
f00bbb22 11359 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
11360 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
11361
6468f31c
LMI
113622011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
11363
49080b10
LMI
11364 * search.c (Fre_search_backward): Mention `case-fold-search' in
11365 all the re_search_* functions (bug#8138).
11366
6468f31c
LMI
11367 * keyboard.c (Fopen_dribble_file): Document when the file is
11368 closed (bug#8056).
11369
c965adc5
EZ
113702011-07-14 Eli Zaretskii <eliz@gnu.org>
11371
df9733bf
EZ
11372 * bidi.c (bidi_dump_cached_states): Fix format of displaying
11373 bidi_cache_idx.
11374
0bb23927
EZ
11375 Support bidi reordering of display and overlay strings.
11376 * xdisp.c (compute_display_string_pos)
11377 (compute_display_string_end): Accept additional argument STRING.
11378 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
11379 (reseat_to_string): Initialize bidi_it->string.s and
11380 bidi_it->string.schars.
11381 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
11382 NULL (avoids a crash in bidi_paragraph_init).
11383 Initialize itb.string.lstring.
0bb23927
EZ
11384 (init_iterator): Call bidi_init_it only of a valid
11385 buffer position was specified. Initialize paragraph_embedding to
11386 L2R.
11387 (reseat_to_string): Initialize the bidi iterator.
11388 (display_string): If we need to ignore text properties of
11389 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
11390 original value of -1 will not work with bidi.)
11391 (compute_display_string_pos): First arg is now struct
11392 `text_pos *'; all callers changed. Support display properties on
11393 Lisp strings.
11394 (compute_display_string_end): Support display properties on Lisp
11395 strings.
11396 (init_iterator, reseat_1, reseat_to_string): Initialize the
11397 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
11398 when iterating on a string not from display properties).
640c8776
SM
11399 (compute_display_string_pos, compute_display_string_end):
11400 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
11401 arrow keys.
11402 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
11403 base_level_stop; instead, set base_level_stop to BEGV.
11404 Fixes crashes in vertical-motion.
0bb23927
EZ
11405 (next_element_from_buffer): Improve commentary for when
11406 the iterator is before prev_stop.
11407 (init_iterator): Initialize bidi_p from the default value of
11408 bidi-display-reordering, not from buffer-local value. Use the
11409 buffer-local value only if initializing for buffer iteration.
11410 (handle_invisible_prop): Support invisible properties on strings
11411 that are being bidi-reordered.
11412 (set_iterator_to_next): Support bidi reordering of C strings and
11413 Lisp strings.
11414 (next_element_from_string): Support bidi reordering of Lisp
11415 strings.
11416 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
11417 (display_string): Support display of R2L glyph rows.
11418 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
11419 (init_iterator): Don't initialize it->bidi_p for strings
11420 here.
11421 (reseat_to_string): Initialize it->bidi_p for strings here.
11422 (next_element_from_string, next_element_from_c_string)
11423 (next_element_from_buffer): Add xassert's for correspondence
11424 between IT's object being iterated and it->bidi_it.string
11425 structure.
11426 (face_before_or_after_it_pos): Support bidi iteration.
11427 (next_element_from_c_string): Handle the case of the first string
11428 character that is not the first one in the visual order.
11429 (get_visually_first_element): New function, refactored from common
11430 parts of next_element_from_buffer, next_element_from_string, and
11431 next_element_from_c_string.
11432 (tool_bar_lines_needed, redisplay_tool_bar)
11433 (display_menu_bar): Force left-to-right direction. Add a FIXME
11434 comment for making that be controlled by a user option.
11435 (push_it, pop_it): Save and restore the state of the
11436 bidi iterator. Save and restore the bidi_p flag.
11437 (pop_it): Iterate out of display property for string iteration as
11438 well.
11439 (iterate_out_of_display_property): Support iteration over strings.
11440 (handle_single_display_spec): Set up it->bidi_it for iteration
11441 over a display string, and call bidi_init_it.
11442 (handle_single_display_spec, next_overlay_string)
11443 (get_overlay_strings_1, push_display_prop): Set up the bidi
11444 iterator for displaying display or overlay strings.
11445 (forward_to_next_line_start): Don't use the shortcut if
11446 bidi-iterating.
11447 (back_to_previous_visible_line_start): If handle_display_prop
11448 pushed the iterator stack, restore the internal state of the bidi
11449 iterator by calling bidi_pop_it same number of times.
11450 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
11451 and we are bidi-iterating, don't decrement the iterator position;
11452 instead, set the first_elt flag in the bidi iterator, to produce
11453 the same effect.
11454 (reseat_1): Remove redundant setting of string_from_display_prop_p.
11455 (push_display_prop): xassert that we are iterating a buffer.
11456 (push_it, pop_it): Save and restore paragraph_embedding member.
11457 (handle_single_display_spec, next_overlay_string)
11458 (get_overlay_strings_1, reseat_1, reseat_to_string)
11459 (push_display_prop): Set up the `unibyte' member of bidi_it.string
11460 correctly. Don't assume unibyte strings are not bidi-reordered.
11461 (compute_display_string_pos)
11462 (compute_display_string_end): Fix handling the case of C string.
11463 (push_it, pop_it): Save and restore from_disp_prop_p.
11464 (handle_single_display_spec, push_display_prop): Set the
11465 from_disp_prop_p flag.
11466 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
11467 (pop_it): Call iterate_out_of_display_property only if we are
11468 popping after iteration over a string that came from a display
11469 property. Fix a typo in popping stretch info. Add an assertion
11470 for verifying that the iterator position is in sync with the bidi
11471 iterator.
11472 (handle_single_display_spec, get_overlay_strings_1)
11473 (push_display_prop): Fix initialization of paragraph direction for
11474 string when that of the parent object is not yet determined.
11475 (reseat_1): Call bidi_init_it to resync the bidi
11476 iterator with IT's position. (Bug#7616)
11477 (find_row_edges): If ROW->start.pos gives position
11478 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
11479 (handle_stop, back_to_previous_visible_line_start, reseat_1):
11480 Reset the from_disp_prop_p flag.
11481 (SAVE_IT, RESTORE_IT): New macros.
11482 (pos_visible_p, face_before_or_after_it_pos)
11483 (back_to_previous_visible_line_start)
11484 (move_it_in_display_line_to, move_it_in_display_line)
11485 (move_it_to, move_it_vertically_backward, move_it_by_lines)
11486 (try_scrolling, redisplay_window, display_line): Use them when
11487 saving a temporary copy of the iterator and restoring it back.
11488 (back_to_previous_visible_line_start, reseat_1)
11489 (init_iterator): Empty the bidi cache "stack".
11490 (move_it_in_display_line_to): If iterator ended up at
11491 EOL, but we never saw any buffer positions smaller than
11492 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
11493 motion in bidi-reordered lines.
11494 (move_it_in_display_line_to): Record prev_method and prev_pos
11495 immediately before the call to set_iterator_to_next. Fixes cursor
11496 motion in bidi-reordered lines with stretch glyphs and strings
11497 displayed in margins. (Bug#8133) (Bug#8867)
11498 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
11499 TO_CHARPOS.
640c8776
SM
11500 (pos_visible_p): Support positions in bidi-reordered lines.
11501 Save and restore bidi cache.
0bb23927
EZ
11502
11503 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
11504 (bidi_paragraph_info): Delete unused struct.
11505 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
11506 (bidi_cache_start): New variable.
11507 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
11508 to zero.
11509 (bidi_cache_fetch_state, bidi_cache_search)
11510 (bidi_cache_find_level_change, bidi_cache_iterator_state)
11511 (bidi_cache_find, bidi_peek_at_next_level)
11512 (bidi_level_of_next_char, bidi_find_other_level_edge)
11513 (bidi_move_to_visually_next): Compare cache index with
11514 bidi_cache_start rather than with zero.
11515 (bidi_fetch_char): Accept new argument STRING; all callers
11516 changed. Support iteration over a string. Support strings with
11517 display properties. Support unibyte strings. Fix the type of
11518 `len' according to what STRING_CHAR_AND_LENGTH expects.
11519 (bidi_paragraph_init, bidi_resolve_explicit_1)
11520 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
11521 (bidi_level_of_next_char, bidi_move_to_visually_next):
11522 Support iteration over a string.
0bb23927
EZ
11523 (bidi_set_sor_type, bidi_resolve_explicit_1)
11524 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
11525 can now be zero (for strings); special values 0 and -1 were
11526 changed to -1 and -2, respectively.
11527 (bidi_char_at_pos): New function.
11528 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
11529 Call it instead of FETCH_MULTIBYTE_CHAR.
11530 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
11531 initialized to valid values.
11532 (bidi_init_it): Don't initialize charpos and bytepos with invalid
11533 values.
11534 (bidi_level_of_next_char): Allow the sentinel "position" to pass
11535 the test for valid cached positions. Fix the logic for looking up
11536 the sentinel state in the cache. GCPRO the Lisp string we are
11537 iterating.
11538 (bidi_push_it, bidi_pop_it): New functions.
11539 (bidi_initialize): Initialize the bidi cache start stack pointer.
11540 (bidi_cache_ensure_space): New function, refactored from part of
11541 bidi_cache_iterator_state. Don't assume the required size is just
11542 one BIDI_CACHE_CHUNK away.
11543 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
11544 (bidi_count_bytes, bidi_char_at_pos): New functions.
11545 (bidi_cache_search): Don't assume bidi_cache_last_idx is
11546 always valid if bidi_cache_idx is valid.
11547 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
11548 is valid if it's going to be used.
11549 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
11550 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
11551 (bidi_cache_find_level_change, bidi_cache_ensure_space)
11552 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
11553 (bidi_find_other_level_edge, bidi_cache_start_stack):
11554 All variables related to cache indices are now EMACS_INT.
c965adc5 11555
0bb23927
EZ
11556 * dispextern.h (struct bidi_string_data): New structure.
11557 (struct bidi_it): New member `string'. Make flag members be 1-bit
11558 fields, and put them last in the struct.
640c8776
SM
11559 (compute_display_string_pos, compute_display_string_end):
11560 Update prototypes.
0bb23927
EZ
11561 (bidi_push_it, bidi_pop_it): Add prototypes.
11562 (struct iterator_stack_entry): New members bidi_p,
11563 paragraph_embedding, and from_disp_prop_p.
11564 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
11565 (bidi_shelve_cache, bidi_unshelve_cache):
11566 Declare prototypes.
0bb23927
EZ
11567
11568 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
11569 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
11570 and vector-like objects.
11571
11572 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
11573 cache around display iteration.
11574
11575 * window.c (Fwindow_end, window_scroll_pixel_based)
11576 (displayed_window_lines, Frecenter): Save and restore the bidi
11577 cache around display iteration.
11578
3bbd2265
LMI
115792011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
11580
11581 * editfns.c (Fdelete_region): Clarify the use of the named
11582 parameters (bug#6788).
11583
adc47434
MR
115842011-07-14 Martin Rudalics <rudalics@gmx.at>
11585
11586 * indent.c (Fvertical_motion): Set and restore w->pointm when
11587 saving and restoring the window's buffer (Bug#9006).
11588
837c31f8
LMI
115892011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
11590
11591 * editfns.c (Fstring_to_char): Clarify just what is returned
11592 (bug#6576). Text by Eli Zaretskii.
11593
ac389d0c
JB
115942011-07-13 Juanma Barranquero <lekktu@gmail.com>
11595
11596 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
11597
0be0ce47
EZ
115982011-07-13 Eli Zaretskii <eliz@gnu.org>
11599
11600 * buffer.c (mmap_find): Fix a typo.
11601
cd18e7e3
JB
116022011-07-13 Johan Bockgård <bojohan@gnu.org>
11603
11604 Fix execution of x selection hooks.
11605 * xselect.c (Qx_lost_selection_functions)
11606 (Qx_sent_selection_functions): New vars.
11607 (syms_of_xselect): DEFSYM them.
11608 (x_handle_selection_request): Pass Qx_sent_selection_functions
11609 rather than Vx_sent_selection_functions to Frun_hook_with_args.
11610 (x_handle_selection_clear,x_clear_frame_selections):
11611 Pass Qx_lost_selection_functions rather than
11612 Vx_lost_selection_functions to Frun_hook_with_args.
11613
47ea7f44
PE
116142011-07-13 Paul Eggert <eggert@cs.ucla.edu>
11615
ac389d0c 11616 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
11617 The old code sometimes used this field without initializing it.
11618
47ea7f44
PE
11619 * alloc.c (gc_sweep): Don't read past end of array.
11620 In theory, the old code could also have corrupted Emacs internals,
11621 though it'd be very unlikely.
11622
bc985c87
AS
116232011-07-12 Andreas Schwab <schwab@linux-m68k.org>
11624
11625 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 11626 argument. (Bug#4026)
bc985c87 11627
0cf34688
LMI
116282011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
11629
b3dadd76
LMI
11630 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
11631 key" (bug#4257).
11632
0cf34688
LMI
11633 * window.c (Fset_window_start): Doc fix (bug#4199).
11634 (Fset_window_hscroll): Ditto.
11635
270768cd
PE
116362011-07-12 Paul Eggert <eggert@cs.ucla.edu>
11637
077e3dda 11638 Fix minor new problems caught by GCC 4.6.1.
270768cd 11639 * term.c (init_tty): Remove unused local.
490011a6 11640 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 11641 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 11642 not used otherwise.
270768cd 11643
b1f58454
CY
116442011-07-12 Chong Yidong <cyd@stupidchicken.com>
11645
11646 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
11647
22b9578d
LMI
116482011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
11649
6e70ab07
LMI
11650 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
11651 are the mini-buffer and the echo area (bug#3320).
11652
22b9578d
LMI
11653 * term.c (init_tty): Remove support for supdup, c10 and perq
11654 terminals, which are no longer supported (bug#1482).
11655
8974cc9f
JB
116562011-07-10 Johan Bockgård <bojohan@gnu.org>
11657
11658 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
11659
a560d974
JD
116602011-07-10 Jan Djärv <jan.h.d@swipnet.se>
11661
11662 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
11663 for non-popups (Bug#3642).
11664
1dae0f0a
AS
116652011-07-10 Andreas Schwab <schwab@linux-m68k.org>
11666
268c2c36 11667 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 11668 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
11669 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
11670 * cm.c (losecursor): Likewise.
1dae0f0a
AS
11671 * data.c (fmod): Likewise.
11672 * dispnew.c (swap_glyphs_in_rows): Likewise.
11673 * emacs.c (memory_warning_signal): Likewise.
11674 * floatfns.c (float_error): Likewise.
11675 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
11676 (otf_open, font_otf_capability, generate_otf_features)
11677 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
11678 Likewise.
11679 * image.c (pbm_read_file): Likewise.
11680 * indent.c (string_display_width): Likewise.
11681 * intervals.c (check_for_interval, search_for_interval)
11682 (inc_interval_count, count_intervals, root_interval)
11683 (adjust_intervals_for_insertion, make_new_interval): Likewise.
11684 * lread.c (defalias): Likewise.
268c2c36 11685 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
11686 * regex.c (set_image_of_range_1, set_image_of_range)
11687 (regex_grow_registers): Likewise.
11688 * sysdep.c (strerror): Likewise.
11689 * termcap.c (valid_filename_p, tprint, main): Likewise.
11690 * tparam.c (main): Likewise.
11691 * unexhp9k800.c (run_time_remap, save_data_space)
11692 (update_file_ptrs, read_header, write_header, calculate_checksum)
11693 (copy_file, copy_rest, display_header): Likewise.
11694 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
11695 Likewise.
11696 * xdisp.c (check_it): Likewise.
11697 * xfaces.c (register_color, unregister_color, unregister_colors):
11698 Likewise.
11699 * xfns.c (print_fontset_result): Likewise.
11700 * xrdb.c (member, fatal, main): Likewise.
11701
99033785
PE
117022011-07-10 Paul Eggert <eggert@cs.ucla.edu>
11703
11704 Fix minor problems found by static checking (Bug#9031).
11705 * chartab.c (char_table_set_range, map_sub_char_table):
11706 Remove unused locals.
11707 (uniprop_table): Now static.
11708 * composite.c (_work_char): Remove unused static var.
11709
9cb2ac56
JB
117102011-07-09 Juanma Barranquero <lekktu@gmail.com>
11711
11712 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
11713
f25661f0
JD
117142011-07-09 Jan Djärv <jan.h.d@swipnet.se>
11715
11716 * gtkutil.c (qttip_cb): Remove code without function.
11717
8278c4fe
EZ
117182011-07-09 Eli Zaretskii <eliz@gnu.org>
11719
11720 * w32.c (pthread_sigmask): New stub.
11721
1692ae2d 117222011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 11723
8a6ebd58 11724 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
11725 sigprocmask is portable only for single-threaded applications, and
11726 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
11727 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
11728 (LIBES): Use it.
11729 * callproc.c (Fcall_process):
11730 * process.c (create_process):
11731 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
11732 Use pthread_sigmask, not sigprocmask.
123403e4 11733
1b854618
JD
117342011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11735
11736 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
11737 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
11738 wrong (Bug#8591).
11739
3fe4b549
JD
117402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11741
0ce7e563
JD
11742 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
11743 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
11744 (xg_hide_tooltip): Fix comment.
11745
3fe4b549
JD
11746 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
11747 in registerServicesMenuSendTypes.
11748 (validRequestorForSendType): Don't check ns_return_types.
11749
11750 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
11751 ns_return_type.
11752
5df75e47
JR
117532011-07-08 Jason Rumney <jasonr@gnu.org>
11754
22610910
JR
11755 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
11756 SH_SHOW for hidden windows (Bug#5482).
11757
5df75e47
JR
11758 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
11759 frame struct members of non-existent frames (Bug#6284).
11760
699c10bd
JD
117612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
11762
4393663b
JD
11763 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
11764 variable firstTime not needed on OSX >= 10.6.
11765 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
11766 >= 10.5. Use setKnobProportion, setDoubleValue.
11767
11768 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
11769 (MAC_OS_X_VERSION_10_5): Define if not defined.
11770 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
11771 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
11772 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
11773
11774 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 11775 cString and lossyCString on OSX >= 10.4.
4393663b 11776
58179cce 11777 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
11778 sizeToFit on OSX >= 10.2.
11779
11780 * nsimage.m (allocInitFromFile): Don't use deprecated method
11781 bestRepresentationForDevice on OSX >= 10.6.
11782
11783 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
11784 to avoid warning.
11785
11786 * emacs.c: Declare unexec_init_emacs_zone.
11787
a63e0781
JD
11788 * nsgui.h: Fix compiler warning about gnulib redefining verify.
11789
699c10bd
JD
11790 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
11791
11792 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
11793 on svcsMenu (Bug#8842).
11794
11795 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
11796 ns_return_types.
11797 (Fns_list_services): Just return Qnil on 10.6, code not working there.
11798
11799 * nsterm.m (QUTF8_STRING): Declare.
11800 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
11801 (validRequestorForSendType): Return type is (id).
11802 Change indexOfObjectIdenticalTo to indexOfObject.
11803 Check if we have local selection before returning self (Bug#8842).
11804 (writeSelectionToPasteboard): Put local selection into paste board
11805 if we have a local selection (Bug#8842).
11806 (syms_of_nsterm): DEFSYM QUTF8_STRING.
11807
11808 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
11809 (ns_get_local_selection): Declare.
11810
54e10184
LMI
118112011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
11812
9888ff71
LMI
11813 * keymap.c (describe_map_tree): Don't insert a double newline at
11814 the end of the buffer (bug#1169) and return whether we inserted
11815 something.
11816
54e10184
LMI
11817 * callint.c (Fcall_interactively): Change "reading args" to
11818 "providing args" to try to clarify what it does (bug#1010).
11819
15fa4783
KH
118202011-07-07 Kenichi Handa <handa@m17n.org>
11821
11822 * composite.c (composition_compute_stop_pos): Ignore a static
11823 composition starting before CHARPOS (Bug#8915).
11824
11825 * xdisp.c (handle_composition_prop): Likewise.
11826
a8815b00
EZ
118272011-07-07 Eli Zaretskii <eliz@gnu.org>
11828
11829 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
11830 (Bug#9015)
11831
ef7b981d 118322011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
11833
11834 * character.h (unicode_category_t): New enum type.
11835
11836 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
11837 (Qchar_code_property_table): New variable.
11838 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
11839 (UNIPROP_COMPRESSED_FORM_P): New macros.
11840 (char_table_ascii): Uncompress the compressed values.
11841 (sub_char_table_ref): New arg is_uniprop. Callers changed.
11842 Uncompress the compressed values.
ac389d0c 11843 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
11844 (char_table_ref_and_range): Uncompress the compressed values.
11845 (sub_char_table_set): New arg is_uniprop. Callers changed.
11846 Uncompress the compressed values.
11847 (sub_char_table_set_range): Args changed. Callers changed.
11848 (char_table_set_range): Adjuted for the above change.
11849 (map_sub_char_table): Delete args default_val and parent. Add arg
11850 top. Give decoded values to a Lisp function.
640c8776 11851 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
11852 values to a Lisp function. Gcpro more variables.
11853 (uniprop_table_uncompress)
11854 (uniprop_decode_value_run_length): New functions.
11855 (uniprop_decoder, uniprop_decoder_count): New variables.
11856 (uniprop_get_decoder, uniprop_encode_value_character)
11857 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
11858 New functions.
11859 (uniprop_encoder, uniprop_encoder_count): New variables.
11860 (uniprop_get_encoder, uniprop_table)
11861 (Funicode_property_table_internal, Fget_unicode_property_internal)
11862 (Fput_unicode_property_internal): New functions.
11863 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
11864 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 11865 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
11866 char-code-property-alist.
11867
640c8776 11868 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
11869 Vunicode_category_table.
11870
640c8776 11871 * font.c (font_range): Adjust for the change of
c805dec0
KH
11872 Vunicode_category_table.
11873
76b397fb
DN
118742011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
11875
11876 * m/iris4d.h: Remove file, move contents ...
11877 * s/irix6-5.h: ... here.
11878
22b4128e
PE
118792011-07-06 Paul Eggert <eggert@cs.ucla.edu>
11880
11881 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
11882 * alloc.c (mark_buffer):
11883 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
11884 (clone_per_buffer_values): Don't assume that
22b4128e
PE
11885 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
11886 This isn't true in general, and it's particularly not true
11887 if Emacs is configured with --with-wide-int.
11888 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
11889 New macros, used in the buffer.c change.
11890
869795d6
JD
118912011-07-05 Jan Djärv <jan.h.d@swipnet.se>
11892
11893 * xsettings.c: Use both GConf and GSettings if both are available.
11894 (store_config_changed_event): Add comment.
11895 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
11896 (store_tool_bar_style_changed): New functions.
5e617bc2 11897 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
11898 (struct xsettings): Move font inside HAVE_XFT.
11899 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 11900 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 11901 Move inside HAVE_XFT.
640c8776 11902 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
11903 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
11904 also.
11905 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 11906 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 11907 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
11908 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
11909 (parse_settings): Move check for font inside HAVE_XFT.
11910 (read_settings, apply_xft_settings): Add comment.
11911 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
11912 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
11913 call store_font_name_changed.
11914 (xft_settings_event): Add comment.
11915 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
11916 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
11917 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
11918 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
11919 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
11920 (xsettings_get_system_font, xsettings_get_system_normal_font):
11921 Add comment.
869795d6 11922
d8ed26bd
PE
119232011-07-05 Paul Eggert <eggert@cs.ucla.edu>
11924
11925 Random fixes. E.g., (random) never returned negative values.
11926 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
11927 subseconds part to the entropy, as that's a bit more random.
11928 Prefer signed to unsigned, since the signedness doesn't matter and
11929 in general we prefer signed. When given a limit, use a
11930 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
11931 latter isn't right if USE_2_TAGS_FOR_INTS.
11932 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
11933 not 0..VALMASK. Don't discard "excess" bits that random () returns.
11934
cabf1cac
SM
119352011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
11936
11937 * textprop.c (text_property_stickiness):
11938 Obey Vtext_property_default_nonsticky.
11939 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
11940 * w32fns.c (syms_of_w32fns):
11941 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
11942
6e9b2be9
PE
119432011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11944
11945 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
11946 This is more efficient than Ffile_directory_p and avoids a minor race.
11947
90186c68
LMI
119482011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
11949
7c301272
LMI
11950 * buffer.c (Foverlay_put): Say what the return value is
11951 (bug#7835).
11952
c4f2d8d4
LMI
11953 * fileio.c (barf_or_query_if_file_exists): Check first if the file
11954 is a directory before asking whether to use the file name
11955 (bug#7564).
ad637907
LMI
11956 (barf_or_query_if_file_exists): Make the "File is a directory"
11957 error be more correct.
c4f2d8d4 11958
90186c68
LMI
11959 * fns.c (Frequire): Remove the mention of the .gz files, since
11960 that's installation-specific, but keep the mention of
11961 `get-load-suffixes'.
11962
da64016e
PE
119632011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11964
11965 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
11966 Report string overflow if the output is too long.
11967
7d47b580
JB
119682011-07-04 Juanma Barranquero <lekktu@gmail.com>
11969
a555cb87
JB
11970 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
11971 (syms_of_gnutls): Remove duplicate DEFSYM for
11972 Qgnutls_bootprop_verify_hostname_error, an error for
11973 Qgnutls_bootprop_verify_error (which is no longer used).
11974
7d47b580
JB
11975 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
11976 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
11977 Also (re)move comments that are misplaced or no longer relevant.
11978
1e49bfab
LMI
119792011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11980
11981 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
11982
1485f4c0
CY
119832011-07-03 Chong Yidong <cyd@stupidchicken.com>
11984
11985 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
11986 and background color parameters if they have been changed.
11987
a9ab721e
LMI
119882011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11989
11990 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
11991
cf7cff57
PE
119922011-07-03 Paul Eggert <eggert@cs.ucla.edu>
11993
2e13213d
PE
11994 * xsettings.c (SYSTEM_FONT): Define only when used.
11995 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
11996
cf7cff57
PE
11997 * keymap.c (access_keymap_1): Now static.
11998
7a8e04f7
CY
119992011-07-02 Chong Yidong <cyd@stupidchicken.com>
12000
12001 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
12002 leave any prefix arg for the up event (Bug#1586).
12003
61352f62
LMI
120042011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
12005
69bb1ef7
LMI
12006 * lread.c (syms_of_lread): Mention single symbols defined by
12007 `defvar' or `defconst' (bug#7154).
12008
61352f62 12009 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 12010 (Frequire): Mention get-load-suffixes.
61352f62 12011
28545e04
MR
120122011-07-02 Martin Rudalics <rudalics@gmx.at>
12013
12014 * window.h (window): Remove clone_number slot.
12015 * window.c (Fwindow_clone_number, Fset_window_clone_number):
12016 Remove.
12017 (make_parent_window, make_window, saved_window)
12018 (Fset_window_configuration, save_window_save): Don't deal with
12019 clone numbers.
12020 * buffer.c (Qclone_number): Remove declaration.
12021 (sort_overlays, overlay_strings): Don't deal with clone numbers.
12022
3349e122
SM
120232011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
12024
12025 Add multiple inheritance to keymaps.
12026 * keymap.c (Fmake_composed_keymap): New function.
12027 (Fset_keymap_parent): Simplify.
12028 (fix_submap_inheritance): Remove.
12029 (access_keymap_1): New function extracted from access_keymap to handle
12030 embedded parents and handle lists of maps.
12031 (access_keymap): Use it.
12032 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
12033 (Fcopy_keymap): Handle embedded parents.
12034 (Fcommand_remapping, define_as_prefix): Simplify.
12035 (Fkey_binding): Simplify.
12036 (syms_of_keymap): Move minibuffer-local-completion-map,
12037 minibuffer-local-filename-completion-map,
12038 minibuffer-local-must-match-map, and
12039 minibuffer-local-filename-must-match-map to Elisp.
12040 (syms_of_keymap): Defsubr make-composed-keymap.
12041 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
12042 (parse_menu_item): Trivial simplification.
12043
3279eb87
GM
120442011-07-01 Glenn Morris <rgm@gnu.org>
12045
12046 * Makefile.in (SETTINGS_LIBS): Fix typo.
12047
39cb9e56 120482011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
12049
12050 * coding.c (Fencode_coding_string): Record the last coding system
12051 used, as the function doc string says (bug#8738).
12052
0949d2b6
JD
120532011-07-01 Jan Djärv <jan.h.d@swipnet.se>
12054
12055 * xsettings.c (store_monospaced_changed): Take new font as arg and
12056 check for change against current_mono_font.
12057 (EMACS_TYPE_SETTINGS): Remove this and related defines.
12058 (emacs_settings_constructor, emacs_settings_get_property)
12059 (emacs_settings_set_property, emacs_settings_class_init)
12060 (emacs_settings_init, gsettings_obj): Remove.
12061 (something_changedCB): New function for HAVE_GSETTINGS.
12062 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
12063 with value as argument.
12064 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
12065 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 12066 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
12067 "changed".
12068
12069 * xgselect.c: Add defined (HAVE_GSETTINGS).
12070 (xgselect_initialize): Ditto.
12071
12072 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
12073 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
12074 xg_select.
12075
bbc6b304
PE
120762011-07-01 Paul Eggert <eggert@cs.ucla.edu>
12077
12078 * eval.c (struct backtrace): Simplify and port the data structure.
12079 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
12080 signed bit field, as this assumption is not portable and it makes
12081 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
12082 "char debug_on_exit : 1" as this is not portable either; instead,
12083 use the portable "unsigned int debug_on_exit : 1". Remove unused
12084 member evalargs. Remove obsolete comments about cc bombing out.
12085
9851bfc5
JD
120862011-06-30 Jan Djärv <jan.h.d@swipnet.se>
12087
51bb811f 12088 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
12089 Let HAVE_GSETTINGS override HAVE_GCONF.
12090 (store_monospaced_changed): New function.
12091 (EMACS_SETTINGS): A new type derived from GObject to handle
12092 GSettings notifications.
12093 (emacs_settings_constructor, emacs_settings_get_property)
12094 (emacs_settings_set_property, emacs_settings_class_init):
12095 New functions.
12096 (gsettings_client, gsettings_obj): New variables.
12097 (GSETTINGS_SCHEMA): New define.
12098 (something_changedCB): Call store_monospaced_changed.
12099 (init_gsettings): New function.
12100 (xsettings_initialize): Call init_gsettings.
12101 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
12102 to NULL.
12103
640c8776 12104 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
12105 GCONF_CFLAGS/LIBS.
12106
5386012d
MR
121072011-06-29 Martin Rudalics <rudalics@gmx.at>
12108
12109 * window.c (resize_root_window, grow_mini_window)
12110 (shrink_mini_window): Rename Qresize_root_window to
12111 Qwindow_resize_root_window and Qresize_root_window_vertically to
12112 Qwindow_resize_root_window_vertically.
12113
f13e0b08
PE
121142011-06-28 Paul Eggert <eggert@cs.ucla.edu>
12115
12116 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
12117
94515237
JB
121182011-06-27 Juanma Barranquero <lekktu@gmail.com>
12119
12120 * makefile.w32-in: Redesign dependencies so they reflect more
12121 clearly which files are directly included by each source file,
12122 and not through other includes.
12123
e43b6e43
MR
121242011-06-27 Martin Rudalics <rudalics@gmx.at>
12125
12126 * buffer.c (Qclone_number): Declare static and DEFSYM it.
12127 (sort_overlays, overlay_strings): When an overlay's clone number
12128 matches the window's clone number process the overlay even if
12129 the overlay's window property doesn't match the current window.
12130
d68443dc
MR
12131 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
12132 (Fwindow_hchild): Rename to Fwindow_left_child.
12133 (Fwindow_next): Rename to Fwindow_next_sibling.
12134 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
12135 (resize_window_check): Rename to window_resize_check.
12136 (resize_window_apply): Rename to window_resize_apply.
12137 (Fresize_window_apply): Rename to Fwindow_resize_apply.
12138 (Fdelete_other_windows_internal, resize_frame_windows)
12139 (Fsplit_window_internal, Fdelete_window_internal)
12140 (grow_mini_window, shrink_mini_window)
12141 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 12142
c7e73be5
JD
121432011-06-26 Jan Djärv <jan.h.d@swipnet.se>
12144
12145 * emacsgtkfixed.h: State that this is only used with Gtk+3.
12146 (emacs_fixed_set_min_size): Remove.
12147 (emacs_fixed_new): Take frame as argument.
12148
12149 * emacsgtkfixed.c: State that this is only used with Gtk+3.
12150 (_EmacsFixedPrivate): Remove minwidth/height.
12151 Add struct frame *f.
12152 (emacs_fixed_init): Initialize priv->f.
12153 (get_parent_class, emacs_fixed_set_min_size): Remove.
12154 (emacs_fixed_new): Set priv->f to argument.
12155 (emacs_fixed_get_preferred_width)
12156 (emacs_fixed_get_preferred_height): Use min_width/height from
12157 frames size_hint to set minimum and natural (Bug#8919).
12158 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
12159 and use min_width/height from frames size_hint to set
12160 min_width/height (Bug#8919).
12161
12162 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
12163 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
12164 Fix indentation.
c7e73be5 12165
cf99dcf8
EZ
121662011-06-26 Eli Zaretskii <eliz@gnu.org>
12167
12168 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
12169 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
12170 called at ZV.
12171
029529ac
CY
121722011-06-26 Chong Yidong <cyd@stupidchicken.com>
12173
12174 * process.c (wait_reading_process_output): Bypass select if
12175 waiting for a cell while ignoring keyboard input, and input is
12176 pending. Suggested by Jan Djärv (Bug#8869).
12177
7a7ef429
PE
121782011-06-25 Paul Eggert <eggert@cs.ucla.edu>
12179
12180 Use gnulib's dup2 module instead of rolling our own.
12181 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
12182
11fdef7d 121832011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
12184
12185 * dispnew.c (scrolling_window): Before scrolling, turn off a
12186 mouse-highlight in the window being scrolled.
12187
cd3520a4
JB
121882011-06-24 Juanma Barranquero <lekktu@gmail.com>
12189
12190 Move DEFSYM to lisp.h and use everywhere.
12191
12192 * character.h (DEFSYM): Move declaration...
12193 * lisp.h (DEFSYM): ...here.
12194
12195 * gnutls.c:
12196 * minibuf.c:
12197 * w32menu.c:
12198 * w32proc.c:
12199 * w32select.c: Don't include character.h.
12200
12201 * alloc.c (syms_of_alloc):
12202 * buffer.c (syms_of_buffer):
12203 * bytecode.c (syms_of_bytecode):
12204 * callint.c (syms_of_callint):
12205 * casefiddle.c (syms_of_casefiddle):
12206 * casetab.c (init_casetab_once):
12207 * category.c (init_category_once, syms_of_category):
12208 * ccl.c (syms_of_ccl):
12209 * cmds.c (syms_of_cmds):
12210 * composite.c (syms_of_composite):
12211 * dbusbind.c (syms_of_dbusbind):
12212 * dired.c (syms_of_dired):
12213 * dispnew.c (syms_of_display):
12214 * doc.c (syms_of_doc):
12215 * editfns.c (syms_of_editfns):
12216 * emacs.c (syms_of_emacs):
12217 * eval.c (syms_of_eval):
12218 * fileio.c (syms_of_fileio):
12219 * fns.c (syms_of_fns):
12220 * frame.c (syms_of_frame):
12221 * fringe.c (syms_of_fringe):
12222 * insdel.c (syms_of_insdel):
12223 * keymap.c (syms_of_keymap):
12224 * lread.c (init_obarray, syms_of_lread):
12225 * macros.c (syms_of_macros):
12226 * msdos.c (syms_of_msdos):
12227 * print.c (syms_of_print):
12228 * process.c (syms_of_process):
12229 * search.c (syms_of_search):
12230 * sound.c (syms_of_sound):
12231 * syntax.c (init_syntax_once, syms_of_syntax):
12232 * terminal.c (syms_of_terminal):
12233 * textprop.c (syms_of_textprop):
12234 * undo.c (syms_of_undo):
12235 * w32.c (globals_of_w32):
12236 * window.c (syms_of_window):
12237 * xdisp.c (syms_of_xdisp):
12238 * xfaces.c (syms_of_xfaces):
12239 * xfns.c (syms_of_xfns):
12240 * xmenu.c (syms_of_xmenu):
12241 * xsettings.c (syms_of_xsettings):
12242 * xterm.c (syms_of_xterm): Use DEFSYM.
12243
4228cf16
TZ
122442011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
12245
cd3520a4 12246 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 12247
7fcccf1e
PE
122482011-06-23 Paul Eggert <eggert@cs.ucla.edu>
12249
7efb4e0e
PE
12250 Integer and buffer overflow fixes (Bug#8873).
12251
ff5844ad
PE
12252 * print.c (printchar, strout): Check for string overflow.
12253 (PRINTPREPARE, printchar, strout):
12254 Don't set size unless allocation succeeds.
12255
90532f02
PE
12256 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
12257 for sizes. Check for string overflow more accurately.
12258 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
12259
6d84508d
PE
12260 * macros.c: Integer and buffer overflow fixes.
12261 * keyboard.h (struct keyboard.kbd_macro_bufsize):
12262 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
12263 Use ptrdiff_t, not int, for sizes.
12264 Don't increment bufsize until after realloc succeeds.
12265 Check for size-calculation overflow.
12266 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
12267
437b2cb4
PE
12268 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
12269
8b9ac8b4
PE
12270 * lread.c: Integer overflow fixes.
12271 (read_integer): Radix is now EMACS_INT, not int,
12272 to improve quality of diagnostics for out-of-range radices.
12273 Calculate buffer size correctly for out-of-range radices.
12274 (read1): Check for integer overflow in radices, and in
12275 read-circle numbers.
82cb60d3
PE
12276 (read_escape): Avoid int overflow.
12277 (Fload, openp, read_buffer_size, read1)
12278 (substitute_object_recurse, read_vector, read_list, map_obarray):
12279 Use ptrdiff_t, not int, for sizes.
12280 (read1): Use EMACS_INT, not int, for sizes.
20270765 12281 Check for size overflow.
8b9ac8b4 12282
7fcccf1e
PE
12283 * image.c (cache_image): Check for size arithmetic overflow.
12284
bfbbd7e7
PE
12285 * lread.c: Integer overflow issues.
12286 (saved_doc_string_size, saved_doc_string_length)
12287 (prev_saved_doc_string_size, prev_saved_doc_string_length):
12288 Now ptrdiff_t, not int.
12289 (read1): Don't assume doc string length fits in int. Check for
12290 out-of-range doc string lengths.
12291 (read_list): Don't assume file position fits in int.
39019e54 12292 (read_escape): Check for hex character overflow.
bfbbd7e7 12293
4e323265
LL
122942011-06-22 Leo Liu <sdl.web@gmail.com>
12295
12296 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
12297 Move to minibuffer.el.
12298
85fece3e
PE
122992011-06-22 Paul Eggert <eggert@cs.ucla.edu>
12300
20b84ce9 12301 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
12302 The following patches are for when GLYPH_DEBUG && !XASSERT.
12303 * dispextern.h (trace_redisplay_p, dump_glyph_string):
12304 * dispnew.c (flush_stdout):
12305 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
12306 Mark as externally visible.
12307 * dispnew.c (check_window_matrix_pointers): Now static.
12308 * dispnew.c (window_to_frame_vpos):
12309 * xfns.c (unwind_create_frame):
12310 * xterm.c (x_check_font): Remove unused local.
12311 * scroll.c (CHECK_BOUNDS):
12312 * xfaces.c (cache_fache): Rename local to avoid shadowing.
12313 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
12314 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
12315 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
12316 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
12317 Now static.
12318 (debug_method_add): Use va_list and vsprintf rather than relying
12319 on undefined behavior with wrong number of arguments.
12320 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
12321 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
12322 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
12323 since we're not interested in debugging glyphs with old libraries.
12324 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
12325 GCC 4.6.0's static checking.
12326
0766b489
PE
123272011-06-22 Paul Eggert <eggert@cs.ucla.edu>
12328
31fd4b32
PE
12329 Integer overflow and signedness fixes (Bug#8873).
12330 A few related buffer overrun fixes, too.
12331
b79e8648
PE
12332 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
12333
0766b489
PE
12334 * dispextern.h (struct face.stipple):
12335 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
12336 (x_bitmap_mask, x_allocate_bitmap_record)
12337 (x_create_bitmap_from_data, x_create_bitmap_from_file)
12338 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
12339 (x_create_bitmap_from_xpm_data):
12340 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
12341 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
12342 (.bitmaps_last):
12343 * xfaces.c (load_pixmap):
12344 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
12345 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
12346 (.bitmaps_last, struct x_output.icon_bitmap):
12347 Use ptrdiff_t, not int, for bitmap indexes.
12348 (x_allocate_bitmap_record): Check for size overflow.
12349 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
12350
b081724f
PE
12351 Use ptrdiff_t, not int, for overlay counts.
12352 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
12353 * editfns.c (overlays_around, get_pos_property):
12354 * textprop.c (get_char_property_and_overlay):
12355 * xdisp.c (next_overlay_change, note_mouse_highlight):
12356 * xfaces.c (face_at_buffer_position):
21514da7
PE
12357 * buffer.c (OVERLAY_COUNT_MAX): New macro.
12358 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
12359 (Fnext_overlay_change, Fprevious_overlay_change)
12360 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 12361 Use ptrdiff_t, not int, for sizes.
21514da7 12362 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 12363
3de73e5e
PE
12364 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
12365
2606c57b
PE
12366 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
12367 (x_session_initialize): Do not assume string length fits in int.
12368
aaafe47a
PE
12369 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
12370 This is unlikely, but can occur if DPI is outlandish.
12371
2674ddc8 12372 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
12373 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
12374
28154962
PE
12375 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
12376 * xrdb.c (magic_file_p, search_magic_path):
12377 Omit last arg SUFFIX; it was always 0. All callers changed.
12378 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
12379
7de51af5
PE
12380 * xfont.c (xfont_match): Avoid need for strlen.
12381
25ed6cc3
PE
12382 * xfns.c: Don't assume strlen fits in int.
12383 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
12384
4eab31dd
PE
12385 * xdisp.c (message_log_check_duplicate): Return intmax_t,
12386 not unsigned long, as we prefer signed integers. All callers changed.
12387 Detect integer overflow in repeat count.
12388 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 12389 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 12390
171e2a58
PE
12391 * termcap.c: Don't assume sizes fit in int and never overflow.
12392 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
12393 (gobble_line): Check for size-calculation overflow.
12394
ad39faca 12395 * minibuf.c (Fread_buffer):
6e5bb2dc 12396 * lread.c (intern, intern_c_string):
74ca2eb3
PE
12397 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
12398 Don't assume string length fits in int.
12399
52c61c22 12400 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
12401 * gtkutil.c (style_changed_cb): Avoid need for strlen.
12402
b5b8c9e5
PE
12403 * font.c: Don't assume string length fits in int.
12404 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
12405 Use ptrdiff_t, not int.
ccd6111c
PE
12406 (font_intern_prop): Don't assume string length fits in int.
12407 Don't assume integer property fits in fixnum.
12408 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 12409
882f0d81 12410 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 12411 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
12412 Reformulate so as not to need the command string.
12413 Invoke gzip -cd rather than gunzip, as it's more portable.
12414 (lock_info_type, lock_file_1, lock_file):
12415 Don't assume pid_t and time_t fit in unsigned long.
12416 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
12417 (current_lock_owner): Prefer signed type for sizes.
12418 Use memcpy, not strncpy, where memcpy is what is really wanted.
12419 Don't assume (via atoi) that time_t and pid_t fit in int.
12420 Check for time_t and/or pid_t out of range, e.g., via a network share.
12421 Don't alloca where an auto var works fine.
12422
93f4cf88
PE
12423 * fileio.c: Fix some integer overflow issues.
12424 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
12425 Don't assume string length fits in int.
12426 (directory_file_name): Don't assume string length fits in long.
12427 (make_temp_name): Don't assume pid fits in int, or that its print
12428 length is less than 20.
12429
f3e92b69
PE
12430 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
12431
1bfdaf10
PE
12432 * coding.c (make_subsidiaries): Don't assume string length fits in int.
12433
35016e9a
PE
12434 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
12435
3d1e65a1
PE
12436 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
12437 We prefer signed integers, even for size calculations.
12438
0b963a93
PE
12439 * emacs.c: Don't assume string length fits in 'int'.
12440 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
12441 (main): Don't invoke strlen when not needed.
12442
573f4b54
PE
12443 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
12444 (XD_DEBUG_MESSAGE): Don't waste a byte.
12445
989f33ba
PE
12446 * callproc.c (getenv_internal_1, getenv_internal)
12447 (Fgetenv_internal):
965d34eb
PE
12448 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
12449
e4d29b33
PE
12450 * lread.c (invalid_syntax): Omit length argument.
12451 All uses changed. This doesn't fix a bug, but it simplifies the
12452 code away from its former Hollerith-constant appearance, and it's
12453 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 12454 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 12455
eb49b136
PE
12456 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
12457 This didn't break anything, but it didn't help either.
12458 It's confusing to put a bogus integer in a place where the actual
12459 value does not matter.
9f62aeb1 12460 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 12461 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 12462
15375a22
PE
12463 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
12464 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
12465 implementation.
b61cc01c
PE
12466 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
12467 We prefer signed types, and the value cannot exceed the EMACS_INT
12468 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
12469 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
12470 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
12471 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 12472
53b2623d
PE
12473 * indent.c (sane_tab_width): New function.
12474 (current_column, scan_for_column, Findent_to, position_indentation)
12475 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 12476 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 12477
51cab52b 12478 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 12479
f2ed8a70
PE
12480 * lisp.h (lint_assume): New macro.
12481 * composite.c (composition_gstring_put_cache):
12482 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
12483
abe80cc6
PE
12484 * editfns.c, insdel.c:
12485 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 12486
b02c740e
PE
12487 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
12488
ebc96716
PE
12489 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
12490
b4e50fa0 12491 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 12492 Use much-faster test for byte-length change.
311d5d7c 12493 Don't assume string byte-length fits in 'int'.
a4cf38e4 12494 Check that character arg fits in 'int'.
85461888 12495 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 12496
c0c1ee9f
PE
12497 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
12498
a498d7f4
PE
12499 * fns.c (concat): Catch string overflow earlier.
12500 Do not rely on integer wraparound.
12501
51cab52b
PE
12502 * dispextern.h (struct it.overlay_strings_charpos)
12503 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
12504 * xdisp.c (forward_to_next_line_start)
12505 (back_to_previous_visible_line_start)
12506 (reseat_at_next_visible_line_start, next_element_from_buffer):
12507 Don't arbitrarily truncate the value of 'selective' to int.
12508
76031fad
PE
12509 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
12510
5eb55db9
PE
12511 * composite.c: Don't truncate sizes to 'int'.
12512 (composition_gstring_p, composition_reseat_it)
12513 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
12514 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
12515 not EMACS_UINT, for indexes.
5eb55db9 12516
0703a717
PE
12517 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
12518
d6202519
PE
12519 * buffer.c: Include <verify.h>.
12520 (struct sortvec.priority, struct sortstr.priority):
8961a454 12521 Now EMACS_INT, not int.
c20998a7 12522 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
12523 (struct sortstr.size, record_overlay_string)
12524 (struct sortstrlist.size, struct sortlist.used):
12525 Don't truncate size to int.
12526 (record_overlay_string): Check for size-calculation overflow.
d6202519 12527 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 12528
d5a19415
JM
125292011-06-22 Jim Meyering <meyering@redhat.com>
12530
029529ac 12531 Don't leak an XBM-image-sized buffer
d5a19415
JM
12532 * image.c (xbm_load): Free the image buffer after using it.
12533
a9041e6c
PE
125342011-06-21 Paul Eggert <eggert@cs.ucla.edu>
12535
12536 Port to Sun C.
12537 * composite.c (find_automatic_composition): Omit needless 'return 0;'
12538 that Sun C diagnosed.
12539 * fns.c (secure_hash): Fix pointer signedness issue.
12540 * intervals.c (static_offset_intervals): New function.
12541 (offset_intervals): Use it.
12542
7f3f739f
LL
125432011-06-21 Leo Liu <sdl.web@gmail.com>
12544
12545 * deps.mk (fns.o):
12546 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
12547 sha512.h.
12548
12549 * fns.c (secure_hash): Rename from crypto_hash_function and change
12550 the first arg to accept symbols.
5b66d427 12551 (Fsecure_hash): New primitive.
7f3f739f
LL
12552 (syms_of_fns): New symbols.
12553
76147d94
DD
125542011-06-20 Deniz Dogan <deniz@dogan.se>
12555
12556 * process.c (Fset_process_buffer): Clarify return value in
12557 docstring.
12558
7d7d0045
CY
125592011-06-18 Chong Yidong <cyd@stupidchicken.com>
12560
12561 * dispnew.c (add_window_display_history): Use BVAR.
12562
12563 * xdisp.c (debug_method_add): Use BVAR.
12564 (check_window_end, dump_glyph_matrix, dump_glyph)
12565 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
12566
12567 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
12568 Likewise.
12569
12570 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
12571 check till after the cache is created in init_frame_faces.
12572
ff2bc410
SM
125732011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
12574
12575 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
12576
28177add
PE
125772011-06-16 Paul Eggert <eggert@cs.ucla.edu>
12578
dd3482fe
PE
12579 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
12580 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
12581 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
12582
393d71f3 12583 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
12584 * fileio.c (Finsert_file_contents):
12585 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
12586 Remove the old (too-loose) buffer overflow checks.
12587 They weren't needed, since make_gap checks for buffer overflow.
12588 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
12589 The old code merely checked for Emacs fixnum overflow, and relied
12590 on undefined (wraparound) behavior. The new code avoids undefined
12591 behavior, and also checks for ptrdiff_t and/or size_t overflow.
12592
2e6813b0 12593 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
12594 Tune. Don't use wider integers than needed. Don't use alloca.
12595 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 12596
599a9e4f
PE
12597 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
12598
99561444
PE
12599 * insdel.c, lisp.h (buffer_overflow): New function.
12600 (insert_from_buffer_1, replace_range, replace_range_2):
12601 * insdel.c (make_gap_larger):
12602 * editfns.c (Finsert_char):
12603 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
12604
28177add
PE
12605 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
12606
e69dafad
PE
126072011-06-15 Paul Eggert <eggert@cs.ucla.edu>
12608
4baa020d 12609 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 12610
b1c46f02
PE
12611 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
12612 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
12613
e69dafad
PE
12614 * fileio.c: Don't assume EMACS_INT fits in off_t.
12615 (emacs_lseek): New static function.
12616 (Finsert_file_contents, Fwrite_region): Use it.
12617 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
12618
566684ea
PE
12619 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
12620
e6966cd6
PE
12621 * fns.c: Don't overflow int when computing a list length.
12622 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
12623 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
12624 truncation on 64-bit hosts. Check for QUIT every
12625 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
12626 faster and is responsive enough.
12627 (Flength): Report an error instead of overflowing an integer.
12628 (Fsafe_length): Return a float if the value is not representable
12629 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 12630 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 12631 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 12632
dd0b0efb
PE
12633 * alloc.c: Check that resized vectors' lengths fit in fixnums.
12634 (header_size, word_size): New constants.
12635 (allocate_vectorlike): Don't check size overflow here.
12636 (allocate_vector): Check it here instead, since this is the only
12637 caller of allocate_vectorlike that could cause overflow.
12638 Check that the new vector's length is representable as a fixnum.
12639
86fe5cfe
PE
12640 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
12641 The previous code was bogus. For example, next_almost_prime (32)
12642 returned 39, which is undesirable as it is a multiple of 3; and
12643 next_almost_prime (24) returned 25, which is a multiple of 5 so
12644 why was the code bothering to check for multiples of 7?
12645
80e88859
PE
12646 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
12647
4a2f0ad6
PE
12648 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
12649
f66c7cf8
PE
12650 Variadic C functions now count arguments with ptrdiff_t.
12651 This partly undoes my 2011-03-30 change, which replaced int with size_t.
12652 Back then I didn't know that the Emacs coding style prefers signed int.
12653 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
12654 were being counted with int, which may truncate counts on 64-bit
12655 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
12656 * lisp.h (struct Lisp_Subr.function.aMANY)
12657 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
12658 Arg counts are now ptrdiff_t, not size_t.
12659 All variadic functions and their callers changed accordingly.
12660 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
12661 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
12662 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
12663 * callint.c (Fcall_interactively): Check arg count for overflow,
12664 to avoid potential buffer overrun. Use signed char, not 'int',
12665 for 'varies' array, so that we needn't bother to check its size
12666 calculation for overflow.
12667 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
12668 * eval.c (apply_lambda):
12669 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
12670 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
12671 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
12672
a1759b76
PE
12673 * callint.c (Fcall_interactively): Don't use index var as event count.
12674
d96be9fc
PE
12675 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
12676 * mem-limits.h (SIZE): Remove; no longer used.
12677
a690a978 12678 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 12679
578c21e6
PE
12680 Remove unnecessary casts.
12681 * xterm.c (x_term_init):
12682 * xfns.c (x_set_border_pixel):
12683 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
12684 These aren't needed now that we assume ANSI C.
12685
96f53c6c
PE
12686 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
12687 It's more likely to cause problems (due to unsigned overflow)
12688 than to cure them.
12689
83c77d31
PE
12690 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
12691
ee2079f1
PE
12692 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
12693
6da65536
PE
12694 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
12695
7147c4a4
PE
12696 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
12697
193e32d9
PE
12698 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
12699
e5533da6
PE
12700 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
12701
9910e595
PE
12702 GLYPH_CODE_FACE returns EMACS_INT, not int.
12703 * dispextern.h (merge_faces):
12704 * xfaces.c (merge_faces):
01103c44
PE
12705 * xdisp.c (get_next_display_element, next_element_from_display_vector):
12706 Don't assume EMACS_INT fits in int.
9910e595 12707
2638320e
PE
12708 * character.h (CHAR_VALID_P): Remove unused parameter.
12709 * fontset.c, lisp.h, xdisp.c: All uses changed.
12710
045eb8d9
PE
12711 * editfns.c (Ftranslate_region_internal): Omit redundant test.
12712
c1f134b5
PE
12713 * fns.c (concat): Minor tuning based on overflow analysis.
12714 This doesn't fix any bugs. Use int to hold character, instead
12715 of constantly refetching from Emacs object. Use XFASTINT, not
12716 XINT, for value known to be a character. Don't bother comparing
12717 a single byte to 0400, as it's always less.
12718
395fcb93 12719 * floatfns.c (Fexpt):
327eeec8
PE
12720 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
12721
abbd3d23
PE
12722 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
12723 for characters.
12724
684a03ef
PE
12725 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
12726
0fed43f3
PE
12727 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
12728 Without this fix, on a 64-bit host (aset S 0 4294967386) would
12729 incorrectly succeed when S was a string, because 4294967386 was
12730 truncated before it was used.
12731
8fd02eb7
PE
12732 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
12733 Otherwise, an out-of-range integer could cause undefined behavior
12734 on a 64-bit host.
12735
f8c86b69
PE
12736 * composite.c: Use int, not EMACS_INT, for characters.
12737 (fill_gstring_body, composition_compute_stop_pos): Use int, not
12738 EMACS_INT, for values that are known to be in character range.
12739 This doesn't fix any bugs but is the usual style inside Emacs and
12740 may generate better code on 32-bit machines.
12741
34206dd2
PE
12742 Make sure a 64-bit char is never passed to ENCODE_CHAR.
12743 This is for reasons similar to the recent CHAR_STRING fix.
12744 * charset.c (Fencode_char): Check that character arg is actually
12745 a character. Pass an int to ENCODE_CHAR.
12746 * charset.h (ENCODE_CHAR): Verify that the character argument is no
12747 wider than 'int', as a compile-time check to prevent future regressions
12748 in this area.
12749
c5958d4c 12750 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
12751
12752 Make sure a 64-bit char is never passed to CHAR_STRING.
12753 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
12754 by silently ignoring the top 32 bits, allowing some values
12755 that were far too large to be valid characters.
12756 * character.h: Include <verify.h>.
12757 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
12758 arguments are no wider than unsigned, as a compile-time check
12759 to prevent future regressions in this area.
12760 * data.c (Faset):
01103c44 12761 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
12762 (Fsubst_char_in_region):
12763 * fns.c (concat):
12764 * xdisp.c (decode_mode_spec_coding):
12765 Adjust to CHAR_STRING's new requirement.
12766 * editfns.c (Finsert_char, Fsubst_char_in_region):
12767 * fns.c (concat): Check that character args are actually
12768 characters. Without this test, these functions did the wrong
12769 thing with wildly out-of-range values on 64-bit hosts.
12770
d37ca623
PE
12771 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
12772 These casts should not be needed on 32-bit hosts, either.
12773 * keyboard.c (read_char):
12774 * lread.c (Fload): Remove casts to unsigned.
12775
ea204efb
PE
12776 * lisp.h (UNSIGNED_CMP): New macro.
12777 This fixes comparison bugs on 64-bit hosts.
12778 (ASCII_CHAR_P): Use it.
12779 * casefiddle.c (casify_object):
01103c44 12780 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
12781 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
12782 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
12783 * dispextern.h (FACE_FROM_ID):
12784 * keyboard.c (read_char): Use UNSIGNED_CMP.
12785
41cb286c
PE
12786 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
12787 not to EMACS_INT, to avoid GCC warning.
12788
4a1b9832
PE
12789 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
12790
55daad71
PE
12791 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
12792 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
12793 isn't needed on 32-bit machines.
8f95c75c 12794
01103c44
PE
12795 * buffer.c (Fgenerate_new_buffer_name):
12796 Use EMACS_INT for count, not int.
0ceccced 12797 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
12798
12799 * data.c (Qcompiled_function): Now static.
12800
c6f072e7
PE
12801 * window.c (window_body_lines): Now static.
12802
20ce5912
PE
12803 * image.c (gif_load): Rename local to avoid shadowing.
12804
9c4c5f81
PE
12805 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
12806 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
12807 * alloc.c (make_save_value): Integer argument is now of type
12808 ptrdiff_t, not int.
12809 (mark_object): Use ptrdiff_t, not int.
12810 * lisp.h (pD): New macro.
12811 * print.c (print_object): Use it.
12812
c0c5c8ae
PE
12813 * alloc.c: Use EMACS_INT, not int, to count objects.
12814 (total_conses, total_markers, total_symbols, total_vector_size)
12815 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
12816 (total_free_floats, total_floats, total_free_intervals)
12817 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
12818 Now EMACS_INT, not int. All uses changed.
12819 (Fgarbage_collect): Compute overall total using a double, so that
12820 integer overflow is less likely to be a problem. Check for overflow
12821 when converting back to an integer.
5a25e253
PE
12822 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
12823 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
12824 These were 'int' variables that could overflow on 64-bit hosts;
12825 they were never used, so remove them instead of repairing them.
211a0b2a 12826 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
12827 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
12828 Previously, this ceilinged at INT_MAX, but that doesn't work on
12829 64-bit machines.
e46bb31a 12830 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 12831
c78baabf 12832 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 12833 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
12834 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
12835 when a (possibly-narrower) signed value would do just as well.
12836 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 12837
c9d624c6
PE
12838 * alloc.c: Catch some string size overflows that we were missing.
12839 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
12840 for convenience in STRING_BYTES_MAX.
12841 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
12842 The definition here is exact; the one in lisp.h was approximate.
12843 (allocate_string_data): Check for string overflow. This catches
12844 some instances we weren't catching before. Also, it catches
12845 size_t overflow on (unusual) hosts where SIZE_MAX <= min
12846 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
12847 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 12848
c9d624c6
PE
12849 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
12850 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 12851 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 12852
353032ce
PE
12853 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
12854
2bccce07
PE
12855 * alloc.c (Fmake_string): Check for out-of-range init.
12856
0ac30604
SM
128572011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
12858
12859 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
12860
c195f2de
JD
128612011-06-14 Jan Djärv <jan.h.d@swipnet.se>
12862
12863 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
12864 xg_get_default_scrollbar_width.
12865
12866 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
12867 (int_gtk_range_get_value): Move to the scroll bar part of the file.
12868 (style_changed_cb): Call update_theme_scrollbar_width and call
12869 x_set_scroll_bar_default_width and xg_frame_set_char_size for
12870 all frames (Bug#8505).
12871 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
12872 Call gtk_window_set_resizable if HAVE_GTK3.
12873 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
12874 and height if HAVE_GTK3 (Bug#8505).
12875 (scroll_bar_width_for_theme): New variable.
12876 (update_theme_scrollbar_width): New function.
12877 (xg_get_default_scrollbar_width): Move code to
12878 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
12879 (xg_initialize): Call update_theme_scrollbar_width.
12880
12881 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
12882
12883 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
12884
e10ac9f1
MR
128852011-06-12 Martin Rudalics <rudalics@gmx.at>
12886
12887 * frame.c (make_frame): Call other_buffer_safely instead of
12888 other_buffer.
12889
12890 * window.c (temp_output_buffer_show): Call display_buffer with
12891 second argument Vtemp_buffer_show_specifiers and reset latter
12892 immediately after the call.
12893 (Vtemp_buffer_show_specifiers): New variable.
12894 (auto_window_vscroll_p, next_screen_context_lines)
12895 (Vscroll_preserve_screen_position): Remove leading asterisks from
12896 doc-strings.
12897
2d3c217e 128982011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 12899
7b7f97e8 12900 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
12901 * buffer.c (Qclone_number): Remove for now, as it's unused.
12902 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
12903 (record_buffer): Remove unused local.
12904 * frame.c (other_visible_frames, frame_buffer_list): Now static.
12905 (set_frame_buffer_list): Remove; unused.
12906 * frame.h (other_visible_frames): Remove decl.
12907 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
12908 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
12909 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
12910 if HAVE_GPM.
12911 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
12912 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
12913 Define only if HAVE_GPM.
12914 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
12915 (update_hints_inhibit): Remove; never set. All uses removed.
12916 * widgetprv.h (emacsFrameClassRec): Remove decl.
12917 * window.c (delete_deletable_window): Now returns void, since it
12918 wasn't returning anything.
12919 (compare_window_configurations): Remove unused locals.
12920 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
12921 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
12922 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
12923 the same widths as pointers. This follows up on the 2011-05-06 patch.
12924 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
12925 * xterm.h: Likewise.
12926 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
12927
1384b89e
JB
129282011-06-12 Juanma Barranquero <lekktu@gmail.com>
12929
12930 * makefile.w32-in: Update dependencies.
12931 (LISP_H): Add lib/intprops.h.
12932
1100a63c
CY
129332011-06-11 Chong Yidong <cyd@stupidchicken.com>
12934
12935 * image.c (gif_load): Add animation frame delay to the metadata.
12936 (syms_of_image): Use DEFSYM. New symbol `delay'.
12937
6198ccd0
MR
129382011-06-11 Martin Rudalics <rudalics@gmx.at>
12939
12940 * window.c (delete_deletable_window): Re-add.
12941 (Fset_window_configuration): Rewrite to handle dead buffers and
12942 consequently deletable windows.
12943 (window_tree, Fwindow_tree): Remove. Supply functionality in
12944 window.el.
12945 (compare_window_configurations): Simplify code.
12946
b6e3633c
AS
129472011-06-11 Andreas Schwab <schwab@linux-m68k.org>
12948
1ab0dee5
AS
12949 * image.c (imagemagick_load_image): Fix type mismatch.
12950 (Fimagemagick_types): Likewise.
12951
b6e3633c
AS
12952 * window.h (replace_buffer_in_windows): Declare.
12953
9397e56f
MR
129542011-06-11 Martin Rudalics <rudalics@gmx.at>
12955
12956 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
12957 Qclone_number. Remove external declaration of Qdelete_window.
12958 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
12959 code.
640c8776
SM
12960 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
12961 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
12962 (Fother_buffer): Rewrite doc-string. Major rewrite for new
12963 buffer list implementation.
12964 (other_buffer_safely): New function.
12965 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
12966 calls to replace_buffer_in_windows and
12967 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
12968 if allowed.
12969 (record_buffer): Inhibit quitting and rewrite using quittable
12970 functions. Run Qbuffer_list_update_hook if allowed.
12971 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
12972 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
12973 Move switch-to-buffer to window.el.
9397e56f
MR
12974 (bury-buffer): Move to window.el.
12975 (Vbuffer_list_update_hook): New variable.
12976
12977 * lisp.h (other_buffer_safely): Add prototype in buffer.c
12978 section.
12979
12980 * window.h (resize_frame_windows): Move up in code.
12981 (Fwindow_frame): Remove EXFUN.
12982 (replace_buffer_in_all_windows): Remove prototype.
12983 (replace_buffer_in_windows_safely): Add prototype.
12984
12985 * window.c: Declare Qdelete_window static again. Move down
12986 declaration of select_count.
12987 (Fnext_window, Fprevious_window): Rewrite doc-strings.
12988 (Fother_window): Move to window.el.
12989 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
12990 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
12991 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
12992 window.el.
12993 (replace_buffer_in_windows): Implement by calling
12994 Qreplace_buffer_in_windows.
12995 (replace_buffer_in_all_windows): Remove with some functionality
12996 moved into replace_buffer_in_windows_safely.
12997 (replace_buffer_in_windows_safely): New function.
12998 (select_window_norecord, select_frame_norecord): Move in front
12999 of run_window_configuration_change_hook. Remove now obsolete
13000 declarations.
640c8776
SM
13001 (Fset_window_buffer): Rewrite doc-string.
13002 Call Qrecord_window_buffer.
9397e56f
MR
13003 (keys_of_window): Move binding for other-window to window.el.
13004
b50691aa
CY
130052011-06-11 Chong Yidong <cyd@stupidchicken.com>
13006
13007 * dispextern.h (struct image): Replace data member, whose int_val
13008 and ptr_val fields were not used by anything, with a single
13009 lisp_val object.
13010
13011 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
13012 (gif_clear_image, gif_load, imagemagick_load_image)
13013 (gs_clear_image, gs_load): Callers changed.
13014
3f754b86
PE
130152011-06-10 Paul Eggert <eggert@cs.ucla.edu>
13016
cca69397
PE
13017 * buffer.h: Include <time.h>, for time_t.
13018 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
13019
109e28d0
PE
13020 Fix minor problems found by static checking.
13021
60737f02
PE
13022 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
13023
4b66faf3
PE
13024 Make identifiers static if they are not used in other modules.
13025 * data.c (Qcompiled_function, Qframe, Qvector):
13026 * image.c (QimageMagick, Qsvg):
13027 * minibuf.c (Qmetadata):
13028 * window.c (resize_window_check, resize_root_window): Now static.
13029 * window.h (resize_window_check, resize_root_window): Remove decls.
13030
109e28d0
PE
13031 * window.c (window_deletion_count, delete_deletable_window):
13032 Remove; unused.
46a4ce9e
PE
13033 (window_body_lines): Now static.
13034 (Fdelete_other_windows_internal): Mark vars as initialized.
13035 Make sure 'resize_failed' is initialized.
13036 (run_window_configuration_change_hook): Rename local to avoid shadowing.
13037 (resize_window_apply): Remove unused local.
13038 * window.h (delete_deletable_window): Remove decl.
13039
109e28d0 13040 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
13041 (imagemagick_load_image): Fix pointer signedness problem by changing
13042 last arg from unsigned char * to char *. All uses changed.
13043 Also, fix a local for similar reasons.
13044 Remove unused locals. Remove locals to avoid shadowing.
13045 (fn_rsvg_handle_free): Remove; unused.
13046 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 13047 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 13048
3f754b86
PE
13049 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
13050
2547adb1
CY
130512011-06-10 Chong Yidong <cyd@stupidchicken.com>
13052
13053 * image.c (gif_load): Fix omitted cast error introduced by
13054 2011-06-06 change.
13055
2c8e37d4
MR
130562011-06-10 Martin Rudalics <rudalics@gmx.at>
13057
13058 * window.h (resize_proportionally, orig_total_lines)
13059 (orig_top_line): Remove from window structure.
13060 (set_window_height, set_window_width, change_window_heights)
13061 (Fdelete_window): Remove prototypes.
13062 (resize_frame_windows): Remove duplicate declaration.
13063
440a42e3
EZ
130642011-06-10 Eli Zaretskii <eliz@gnu.org>
13065
13066 * window.h (resize_frame_windows, resize_window_check)
13067 (delete_deletable_window, resize_root_window)
13068 (resize_frame_windows): Declare prototypes.
13069
13070 * window.c (resize_window_apply): Make definition be "static" to
13071 match the prototype.
13072
562dd5e9
MR
130732011-06-10 Martin Rudalics <rudalics@gmx.at>
13074
13075 * window.c: Remove declarations of Qwindow_size_fixed,
13076 window_min_size_1, window_min_size_2, window_min_size,
13077 size_window, window_fixed_size_p, enlarge_window, delete_window.
13078 Remove static from declaration of Qdelete_window, it's
13079 temporarily needed by Fbury_buffer.
13080 (replace_window): Don't assign orig_top_line and
13081 orig_total_lines.
13082 (Fdelete_window, delete_window): Remove. Window deletion is
13083 handled by window.el.
640c8776
SM
13084 (window_loop): Remove DELETE_OTHER_WINDOWS case.
13085 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
13086 (Fdelete_other_windows): Remove. Deleting other windows is
13087 handled by window.el.
13088 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
13089 handled in window.el.
13090 (window_min_size_2, window_min_size_1, window_min_size): Remove.
13091 Window minimum sizes are handled in window.el.
13092 (shrink_windows, size_window, set_window_height)
13093 (set_window_width, change_window_heights, window_height)
13094 (window_width, CURBEG, CURSIZE, enlarge_window)
13095 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
13096 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
13097 handled in window.el.
13098 (make_dummy_parent): Rename to make_parent_window and give it a
13099 second argument horflag.
13100 (make_window): Don't set resize_proportionally any more.
13101 (Fsplit_window): Remove. Windows are split in window.el.
13102 (save_restore_action, save_restore_orig_size)
13103 (shrink_window_lowest_first, save_restore_orig_size): Remove.
13104 Resize mini windows in window.el.
13105 (grow_mini_window, shrink_mini_window): Implement by calling
13106 Qresize_root_window_vertically, resize_window_check and
13107 resize_window_apply.
640c8776
SM
13108 (saved_window, Fset_window_configuration, save_window_save):
13109 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
13110 resize_proportionally.
13111 (window_min_height, window_min_width): Move to window.el.
13112 (keys_of_window): Move bindings for delete-other-windows,
13113 split-window, delete-window and enlarge-window to window.el.
13114
13115 * buffer.c: Temporarily extern Qdelete_window.
13116 (Fbury_buffer): Temporarily call Qdelete_window instead of
13117 Fdelete_window (Fbury_buffer will move to window.el soon).
13118
13119 * frame.c (set_menu_bar_lines_1): Remove code handling
13120 orig_top_line and orig_total_lines.
13121
13122 * dispnew.c (adjust_frame_glyphs_initially): Don't use
13123 set_window_height but set heights directly.
13124 (change_frame_size_1): Use resize_frame_windows.
13125
13126 * xdisp.c (init_xdisp): Don't use set_window_height but set
13127 heights directly.
13128
640c8776
SM
13129 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
13130 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
13131 run_window_configuration_change_hook.
13132
13133 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
13134 instead of change_window_heights and run
13135 run_window_configuration_change_hook.
13136
1a13852e
MR
131372011-06-09 Martin Rudalics <rudalics@gmx.at>
13138
13139 * window.c (replace_window): Rename second argument REPLACEMENT to
13140 NEW. New third argument SETFLAG. Rewrite.
13141 (delete_window, make_dummy_parent): Call replace_window with
13142 third argument 1.
13143 (window_list_1): Move down in code.
13144 (run_window_configuration_change_hook): Move set_buffer part
13145 before select_frame_norecord part in order to unwind correctly.
13146 Rename count1 to count.
13147 (recombine_windows, delete_deletable_window, resize_root_window)
13148 (Fdelete_other_windows_internal)
13149 (Frun_window_configuration_change_hook, make_parent_window)
13150 (resize_window_check, resize_window_apply, Fresize_window_apply)
13151 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
13152 (Fdelete_window_internal, Fresize_mini_window_internal):
13153 New functions.
1a13852e
MR
13154 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
13155
f3d1777e
MR
131562011-06-08 Martin Rudalics <rudalics@gmx.at>
13157
496e208e
MR
13158 * window.h (window): Add some new members to window structure -
13159 normal_lines, normal_cols, new_total, new_normal, clone_number,
13160 splits, nest, prev_buffers, next_buffers.
13161 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 13162 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 13163
f3d1777e
MR
13164 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
13165 Remove.
496e208e
MR
13166 (make_dummy_parent): Set new members of windows structure.
13167 (make_window): Move down in code. Handle new members of window
13168 structure.
13169 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
13170 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
13171 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
13172 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
13173 (Fset_window_next_buffers, Fset_window_clone_number):
13174 New functions.
496e208e
MR
13175 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
13176 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
13177 Doc-string fixes.
13178 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
13179 Argument WINDOW can be now internal window too.
13180 (Fwindow_use_time): Move up in code.
13181 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
13182 Rewrite doc-string.
13183 (Fset_window_configuration, saved_window)
13184 (Fcurrent_window_configuration, save_window_save): Handle new
13185 members of window structure.
b9e809c2
MR
13186 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
13187 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
13188 (syms_of_window): New Lisp objects Qrecord_window_buffer,
13189 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
13190 Qget_mru_window, Qresize_root_window,
13191 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
13192 Qauto_buffer_name; staticpro them.
f3d1777e 13193
abde8f8c
MR
131942011-06-07 Martin Rudalics <rudalics@gmx.at>
13195
13196 * window.c (Fwindow_total_size, Fwindow_left_column)
13197 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
13198 (Fwindow_list_1): New functions.
13199 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
13200 (Fwindow_width, Fscroll_left, Fscroll_right):
13201 Use window_body_cols instead of window_box_text_cols.
13202 (delete_window, Fset_window_configuration):
13203 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
13204 (delete_all_subwindows): Take a window as argument and not a
13205 structure. Rewrite.
190b47e6
MR
13206 (window_loop): Remove handling of GET_LRU_WINDOW and
13207 GET_LARGEST_WINDOW.
13208 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
13209
13210 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
13211 window_box_text_cols. delete_all_subwindows now takes a
13212 Lisp_Object as argument.
abde8f8c 13213
640c8776
SM
13214 * indent.c (compute_motion, Fcompute_motion):
13215 Use window_body_cols instead of window_box_text_cols.
abde8f8c 13216
fa8a67e6
MR
13217 * frame.c (delete_frame): Call delete_all_subwindows with root
13218 window as argument.
13219
a54e3482
DC
132202011-06-07 Daniel Colascione <dan.colascione@gmail.com>
13221
13222 * fns.c (Fputhash): Document return value.
13223
60002bf5
CY
132242011-06-06 Chong Yidong <cyd@stupidchicken.com>
13225
13226 * image.c (gif_load): Implement gif89a spec "no disposal" method.
13227
0c671da6 132282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 13229
b862a52a 13230 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 13231
be44ca6c
PE
13232 Check for overflow when converting integer to cons and back.
13233 * charset.c (Fdefine_charset_internal, Fdecode_char):
13234 Use cons_to_unsigned to catch overflow.
13235 (Fencode_char): Use INTEGER_TO_CONS.
13236 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
13237 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
13238 * data.c (long_to_cons, cons_to_long): Remove.
13239 (cons_to_unsigned, cons_to_signed): New functions.
13240 These signal an error for invalid or out-of-range values.
13241 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
13242 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
13243 * font.c (Ffont_variation_glyphs):
13244 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
13245 * lisp.h: Include <intprops.h>.
13246 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
13247 (cons_to_signed, cons_to_unsigned): New decls.
13248 (long_to_cons, cons_to_long): Remove decls.
13249 * undo.c (record_first_change): Use INTEGER_TO_CONS.
13250 (Fprimitive_undo): Use CONS_TO_INTEGER.
13251 * xfns.c (Fx_window_property): Likewise.
13252 * xselect.c: Include <limits.h>.
13253 (x_own_selection, selection_data_to_lisp_data):
13254 Use INTEGER_TO_CONS.
13255 (x_handle_selection_request, x_handle_selection_clear)
13256 (x_get_foreign_selection, Fx_disown_selection_internal)
13257 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
13258 (lisp_data_to_selection_data): Use cons_to_unsigned.
13259 (x_fill_property_data): Use cons_to_signed.
13260 Report values out of range.
13261
d1f3d2af
PE
13262 Check for buffer and string overflow more precisely.
13263 * buffer.h (BUF_BYTES_MAX): New macro.
13264 * lisp.h (STRING_BYTES_MAX): New macro.
13265 * alloc.c (Fmake_string):
13266 * character.c (string_escape_byte8):
13267 * coding.c (coding_alloc_by_realloc):
13268 * doprnt.c (doprnt):
13269 * editfns.c (Fformat):
13270 * eval.c (verror):
13271 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
13272 since they may not be the same number.
13273 * editfns.c (Finsert_char):
13274 * fileio.c (Finsert_file_contents):
13275 Likewise for BUF_BYTES_MAX.
13276
dd52fcea
PE
13277 * image.c: Use ptrdiff_t, not int, for sizes.
13278 (slurp_file): Switch from int to ptrdiff_t.
13279 All uses changed.
13280 (slurp_file): Check that file size fits in both size_t (for
13281 malloc) and ptrdiff_t (for sanity and safety).
13282
7f9bbdbb
PE
13283 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
13284 if b->modtime has its maximal value.
13285
dfe18f82
PE
13286 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
13287
84acfcf0
PE
13288 Don't assume time_t can fit into int.
13289 * buffer.h (struct buffer.modtime): Now time_t, not int.
13290 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
13291 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
13292
ccd9a01a
PE
13293 Minor fixes for signed vs unsigned integers.
13294 * character.h (MAYBE_UNIFY_CHAR):
13295 * charset.c (maybe_unify_char):
13296 * keyboard.c (read_char, reorder_modifiers):
13297 XINT -> XFASTINT, since the integer must be nonnegative.
13298 * ftfont.c (ftfont_spec_pattern):
13299 * keymap.c (access_keymap, silly_event_symbol_error):
13300 XUINT -> XFASTINT, since the integer must be nonnegative.
13301 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
13302 since it makes no difference and we prefer signed.
13303 * keyboard.c (record_char): Use XUINT when all the neighbors do.
13304 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
13305 nonnegative.
13306
d6d100dd
SM
133072011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
13308
13309 * window.h (Fwindow_frame): Declare.
13310
2b6148e4
PE
133112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
13312
13313 * alloc.c: Simplify handling of large-request failures (Bug#8800).
13314 (SPARE_MEMORY): Always define.
13315 (LARGE_REQUEST): Remove.
13316 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
13317
f230ecc9
MR
133182011-06-06 Martin Rudalics <rudalics@gmx.at>
13319
727e958e
MR
13320 * lisp.h: Move EXFUNS for Fframe_root_window,
13321 Fframe_first_window and Fset_frame_selected_window to window.h.
13322
13323 * window.h: Move EXFUNS for Fframe_root_window,
13324 Fframe_first_window and Fset_frame_selected_window here from
13325 lisp.h.
13326
13327 * frame.c (Fwindow_frame, Fframe_first_window)
13328 (Fframe_root_window, Fframe_selected_window)
13329 (Fset_frame_selected_window): Move to window.c.
13330 (Factive_minibuffer_window): Move to minibuf.c.
13331 (Fother_visible_frames_p): New function.
13332
13333 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
13334
f230ecc9
MR
13335 * window.c (decode_window, decode_any_window): Move up in code.
13336 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
13337 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
13338 (Fwindow_buffer): Move up and rewrite doc-string.
13339 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
13340 (Fwindow_prev): New functions.
727e958e
MR
13341 (Fwindow_frame): Move here from frame.c. Accept any window as
13342 argument.
13343 (Fframe_root_window, Fframe_first_window)
13344 (Fframe_selected_window): Move here from frame.c. Accept frame
13345 or arbitrary window as argument. Update doc-strings.
13346 (Fminibuffer_window): Move up in code.
13347 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
13348 (Fset_frame_selected_window): Move here from frame.c.
13349 Marginal rewrite.
727e958e
MR
13350 (Fselected_window, select_window, Fselect_window): Move up in
13351 code. Minor doc-string fixes.
f230ecc9 13352
4d09bcf6
PE
133532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
13354
13355 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
13356 Do not assume that spare memory exists; that assumption is valid
13357 only if SYSTEM_MALLOC.
13358 (LARGE_REQUEST): New macro, so that the issue of large requests
13359 is separated from the issue of spare memory.
13360
810928a2
AS
133612011-06-05 Andreas Schwab <schwab@linux-m68k.org>
13362
172418ad
AS
13363 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
13364 format. (Bug#8806)
13365
43f862f7
AS
13366 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
13367
810928a2
AS
13368 * xfns.c (x_set_scroll_bar_default_width): Move declarations
13369 before statements.
13370
a059fe24
JD
133712011-06-05 Jan Djärv <jan.h.d@swipnet.se>
13372
13373 * gtkutil.c (xg_get_default_scrollbar_width): New function.
13374
13375 * gtkutil.h: Declare xg_get_default_scrollbar_width.
13376
13377 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
13378 min width by calling x_set_scroll_bar_default_width (Bug#8505).
13379
989bf368
JB
133802011-06-05 Juanma Barranquero <lekktu@gmail.com>
13381
13382 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
13383
4b80f674
CY
133842011-06-04 Chong Yidong <cyd@stupidchicken.com>
13385
13386 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
13387 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
13388 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
13389 New error handlers.
4b80f674
CY
13390 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
13391 Obey Vx_select_enable_clipboard_manager. Catch errors in
13392 x_clipboard_manager_save (Bug#8779).
13393 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 13394 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 13395
99a33b77 133962011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
13397
13398 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
13399
99a33b77 134002011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
13401
13402 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
13403 in the current matrix if keep_current_p is non-zero.
13404
8264569d
EZ
134052011-06-04 Eli Zaretskii <eliz@gnu.org>
13406
13407 * bidi.c (bidi_level_of_next_char): Fix last change.
13408
57f97249
EZ
134092011-06-03 Eli Zaretskii <eliz@gnu.org>
13410
fec2107c 13411 Support bidi reordering of text covered by display properties.
57f97249 13412
fec2107c
EZ
13413 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
13414 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
13415 (bidi_cache_search, bidi_cache_iterator_state)
13416 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
13417 (bidi_level_of_next_char, bidi_move_to_visually_next):
13418 Support character positions inside a run of characters covered by a
fec2107c
EZ
13419 display string.
13420 (bidi_paragraph_init, bidi_resolve_explicit_1)
13421 (bidi_level_of_next_char): Call bidi_fetch_char and
13422 bidi_fetch_char_advance instead of FETCH_CHAR and
13423 FETCH_CHAR_ADVANCE.
13424 (bidi_init_it): Initialize new members.
13425 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
13426 definitions.
13427 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
13428 instead of using explicit *_CHAR codes.
d6d100dd
SM
13429 (bidi_resolve_explicit, bidi_resolve_weak):
13430 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
13431 bidirectional text is supported only in multibyte buffers.
13432 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
13433 it to initialize the frame_window_p member of struct bidi_it.
13434 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
13435 (bidi_resolve_explicit, bidi_resolve_weak)
13436 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
13437 bidi_it->nchars is non-positive.
13438 (bidi_level_of_next_char): Don't try to lookup the cache for the
13439 next/previous character if nothing is cached there yet, or if we
13440 were just reseat()'ed to a new position.
c40e2fb2 13441
0e14fe90
EZ
13442 * xdisp.c (set_cursor_from_row): Set start and stop points
13443 according to the row's direction when priming the loop that looks
13444 for the glyph on which to display cursor.
13445 (single_display_spec_intangible_p): Function deleted.
13446 (display_prop_intangible_p): Reimplement to call
13447 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
13448 Accept 3 additional arguments needed by handle_display_spec.
13449 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
13450 values: lists, `(when COND...)' forms, etc.
13451 (single_display_spec_string_p): Support property values that are
13452 lists with the argument STRING its top-level element.
13453 (display_prop_string_p): Fix the condition for processing a
13454 property that is a list to be consistent with handle_display_spec.
fec2107c 13455 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
13456 last portion of handle_display_prop.
13457 (compute_display_string_pos): Accept additional argument
13458 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
13459 value of a `display' property is a "replacing spec".
13460 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
13461 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
13462 the display property, but just return a value indicating whether
13463 the display property will replace the characters it covers.
13464 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
13465 frame_window_p members of struct bidi_it.
d6d100dd
SM
13466 (compute_display_string_pos, compute_display_string_end):
13467 New functions.
fec2107c
EZ
13468 (push_it): Accept second argument POSITION, where pop_it should
13469 jump to continue iteration.
13470 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 13471
fec2107c
EZ
13472 * keyboard.c (adjust_point_for_property): Adjust the call to
13473 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
13474
13475 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
13476 (bidi_init_it): Update prototypes.
13477 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
13478 (compute_display_string_pos, compute_display_string_end):
13479 Declare prototypes.
fec2107c
EZ
13480 (struct bidi_it): New members nchars and disp_pos. ch_len is now
13481 EMACS_INT.
fc6f18ce 13482
40087514 134832011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 13484
57f53182
PE
13485 Malloc failure behavior now depends on size of allocation.
13486 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
13487 * lisp.h: Change signatures accordingly.
13488 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
13489 All callers changed. (Bug#8762)
13490
13491 * gnutls.c: Use Emacs's memory allocators.
13492 Without this change, the gnutls library would invoke malloc etc.
13493 directly, which causes problems on non-SYNC_INPUT hosts, and which
13494 runs afoul of improving memory_full behavior. (Bug#8761)
13495 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
13496 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
13497 xfree instead of the default malloc, realloc, free.
13498 (Fgnutls_boot): No need to check for memory allocation failure,
13499 since xmalloc does that for us.
13500
ac32cd99 13501 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
13502 * category.c (hash_get_category_set):
13503 * ccl.c (ccl_driver):
13504 * charset.c (Fdefine_charset_internal):
13505 * charset.h (struct charset.hash_index):
13506 * composite.c (get_composition_id, gstring_lookup_cache)
13507 (composition_gstring_put_cache):
13508 * composite.h (struct composition.hash_index):
13509 * dispextern.h (struct image.hash):
13510 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
13511 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
13512 (hashfn_equal, hashfn_user_defined, make_hash_table)
13513 (maybe_resize_hash_table, hash_lookup, hash_put)
13514 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
13515 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
13516 (Fsxhash, Fgethash, Fputhash, Fmaphash):
13517 * image.c (make_image, search_image_cache, lookup_image)
13518 (xpm_put_color_table_h):
13519 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 13520 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 13521 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 13522 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
13523 * alloc.c (allocate_vectorlike):
13524 Check for overflow in vector size calculations.
13525 * ccl.c (ccl_driver):
13526 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
13527 * fns.c, image.c: Remove unnecessary static decls that would otherwise
13528 need to be updated by these changes.
40087514
PE
13529 * fns.c (make_hash_table, maybe_resize_hash_table):
13530 Check for integer overflow with large hash tables.
0de4bb68
PE
13531 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
13532 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
13533 (SXHASH_REDUCE): New macro.
13534 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
13535 Use it instead of discarding useful hash info with large hash values.
13536 (sxhash_float): New function.
13537 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
13538 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
13539 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
13540 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
13541 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
13542 Adjust signatures to match updated version of code.
13543 (consing_since_gc): Now EMACS_INT, since a single hash table can
13544 use more than INT_MAX bytes.
13545
698d32e2
DN
135462011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
13547
13548 Make it possible to build with GCC-4.6+ -O2 -flto.
13549
13550 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
13551
fd6fa53f
SM
135522011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
13553
13554 * minibuf.c (get_minibuffer, read_minibuf_unwind):
13555 Call minibuffer-inactive-mode.
13556
864db017
JB
135572011-05-31 Juanma Barranquero <lekktu@gmail.com>
13558
13559 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
13560 Update dependencies.
13561
2ad0baf4
DN
135622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13563
13564 * data.c (init_data): Remove code for UTS, this system is not
13565 supported anymore.
13566
4fcc2638
DN
135672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13568
13569 Don't force ./temacs to start in terminal mode.
13570
13571 * frame.c (make_initial_frame): Initialize faces in all cases, not
13572 only when CANNOT_DUMP is defined.
13573 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
13574
c56e0fd5
DN
135752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13576
13577 * dispnew.c (add_window_display_history): Use const for the string
13578 pointer. Remove declaration, not needed.
13579
333d54da 135802011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 13581
55d4c1b2 13582 Use 'inline', not 'INLINE'.
333d54da 13583 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
13584 * alloc.c, fontset.c (INLINE): Remove.
13585 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
13586 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
13587 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
13588 * gmalloc.c (register_heapinfo): Use inline unconditionally.
13589 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
13590
738db178
DN
135912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
13592
13593 Make it possible to run ./temacs.
13594
13595 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
13596 syms_of_callproc does the same thing. Remove test for
13597 "initialized", do it in the caller.
13598 * emacs.c (main): Avoid calling set_initial_environment when dumping.
13599
620c53a6
SM
136002011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
13601
13602 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
13603 (read_minibuf): Use get_minibuffer.
13604 (syms_of_minibuf): Use DEFSYM.
13605 (Qmetadata): New var.
13606 * data.c (Qbuffer): Don't make it static.
13607 (syms_of_data): Use DEFSYM.
13608
e003a292
PE
136092011-05-31 Paul Eggert <eggert@cs.ucla.edu>
13610
13611 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
13612 (CCL_CODE_MIN): New macro.
13613
ed008a6d
PE
136142011-05-30 Paul Eggert <eggert@cs.ucla.edu>
13615
3687c2ef
PE
13616 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
13617
ed008a6d
PE
13618 * eval.c (Qdebug): Now static.
13619 * lisp.h (Qdebug): Remove decl. This reverts a part of the
13620 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
13621 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
13622
d66c4c7c
CY
136232011-05-29 Chong Yidong <cyd@stupidchicken.com>
13624
13625 * image.c: Various fixes to ImageMagick code comments.
13626 (Fimagemagick_types): Doc fix.
13627
5fbc2025
PE
136282011-05-29 Paul Eggert <eggert@cs.ucla.edu>
13629
0196f88a
PE
13630 Minor fixes prompted by GCC 4.6.0 warnings.
13631
13632 * xselect.c (converted_selections, conversion_fail_tag): Now static.
13633
5fbc2025
PE
13634 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
13635 (x_clipboard_manager_save_all): Move extern decl to ...
13636 * xterm.h: ... here, so that it can be checked for consistency.
13637
1dd3c2d9
CY
136382011-05-29 Chong Yidong <cyd@stupidchicken.com>
13639
13640 * xselect.c (x_clipboard_manager_save_frame)
13641 (x_clipboard_manager_save_all): New functions.
13642 (Fx_clipboard_manager_save): Lisp function deleted.
13643
13644 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
13645 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
13646
13647 * xterm.h: Update prototype.
13648
5ba6571d
WX
136492011-05-28 William Xu <william.xwl@gmail.com>
13650
13651 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
13652 exiting (Bug#8239).
13653
3eaff834
JM
136542011-05-28 Jim Meyering <meyering@redhat.com>
13655
e1900994 13656 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
13657 * fns.c (to_uchar): Define.
13658 (crypto_hash_function): Use it to convert some newly-signed
13659 variables to unsigned, to avoid sign-extension bugs. For example,
13660 without this change, (md5 "truc") would evaluate to
13661 45723a2aff78ff4fff7fff1114760e62 rather than the expected
13662 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 13663 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 13664
0f6990a7
PE
136652011-05-27 Paul Eggert <eggert@cs.ucla.edu>
13666
13667 Integer overflow fixes.
c8a9ca5a 13668
08686060
PE
13669 * dbusbind.c: Serial number integer overflow fixes.
13670 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
13671 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
13672 to hold a serial number that is too large for a fixnum.
13673 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13674 Check for serial numbers out of range. Decode any serial number
59568bf0 13675 that was so large that it became a float. (Bug#8722)
08686060 13676
2d1fc3c7
PE
13677 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
13678 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13679 Use XFASTINT rather than XUINT when numbers are nonnegative.
13680 (xd_append_arg, Fdbus_method_return_internal):
13681 (Fdbus_method_error_internal): Likewise. Also, for unsigned
13682 arguments, check that Lisp number is nonnegative, rather than
59568bf0 13683 silently wrapping negative numbers around. (Bug#8722)
30217ff0 13684 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 13685 (Bug#8722)
2d1fc3c7 13686
c8a9ca5a
PE
13687 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
13688
519e1d69
PE
13689 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
13690
6df6ae42 13691 ccl: Add integer overflow checks.
30569699
PE
13692 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
13693 (IN_INT_RANGE): New macros.
13694 (ccl_driver): Use them to check for integer overflow when
13695 decoding a CCL program. Many of the new checks are whether XINT (x)
13696 fits in int; it doesn't always, on 64-bit hosts. The new version
13697 doesn't catch all possible integer overflows, but it's an
847044ea 13698 improvement. (Bug#8719)
30569699 13699
c11285dc
PE
13700 * alloc.c (make_event_array): Use XINT, not XUINT.
13701 There's no need for unsigned here.
13702
fdccd48e
PE
13703 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
13704 This follows up to the 2011-05-06 change that substituted uintptr_t
13705 for EMACS_INT. This case wasn't caught back then.
13706
37910ab2
PE
13707 Rework Fformat to avoid integer overflow issues.
13708 * editfns.c: Include <float.h> unconditionally, as it's everywhere
13709 now (part of C89). Include <verify.h>.
13710 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
13711 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
13712 (Fformat): Avoid the prepass trying to compute sizes; it was only
13713 approximate and thus did not catch overflow reliably. Instead, walk
13714 through the format just once, formatting and computing sizes as we go,
13715 checking for integer overflow at every step, and allocating a larger
13716 buffer as needed. Keep track separately whether the format is
13717 multibyte. Keep only the most-recently calculated precision, rather
13718 than them all. Record whether each argument has been converted to
13719 string. Use EMACS_INT, not int, for byte and char and arg counts.
13720 Support field widths and precisions larger than INT_MAX. Avoid
13721 sprintf's undefined behavior with conversion specifications such as %#d
13722 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
13723 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
13724 formatting out-of-range floating point numbers with int
9173deec 13725 formats. (Bug#8668)
37910ab2 13726
2e6578fb
PE
13727 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
13728
0ae6bdee
PE
13729 * data.c: Avoid integer truncation in expressions involving floats.
13730 * data.c: Include <intprops.h>.
13731 (arith_driver): When there's an integer overflow in an expression
13732 involving floating point, convert the integers to floating point
13733 so that the resulting value does not suffer from catastrophic
13734 integer truncation. For example, on a 64-bit host (* 4
13735 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
13736 Do not rely on undefined behavior after integer overflow.
13737
de883a70
PE
13738 merge count_size_as_multibyte, parse_str_to_multibyte
13739 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 13740 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
13741 Check for integer overflow.
13742 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
13743 since it's now a duplicate of the other. This is more of
13744 a character than a buffer op, so better that it's in character.c.
13745 * fns.c, print.c: Adjust to above changes.
13746
2ff916cb
PE
137472011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
13748
13749 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
13750
f1b54466
PE
137512011-05-27 Paul Eggert <eggert@cs.ucla.edu>
13752
fb1ac845
PE
13753 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
13754 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
13755 (x_clipboard_manager_save): Now static.
13756 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
13757
f1b54466
PE
13758 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
13759 (crypto_hash_function): Now static.
13760 Fix pointer signedness problems. Avoid unnecessary initializations.
13761
a9f737ee
CY
137622011-05-27 Chong Yidong <cyd@stupidchicken.com>
13763
13764 * termhooks.h (Vselection_alist): Make it terminal-local.
13765
13766 * terminal.c (create_terminal): Initialize it.
13767
13768 * xselect.c: Support for clipboard managers.
13769 (Vselection_alist): Move to termhooks.h as terminal-local var.
13770 (LOCAL_SELECTION): New macro.
13771 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
13772 (symbol_to_x_atom): Remove gratuitous arg.
13773 (x_handle_selection_request, lisp_data_to_selection_data)
13774 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
13775 (x_own_selection, x_get_local_selection, x_convert_selection):
13776 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
13777 (some_frame_on_display): Delete unused function.
13778 (Fx_own_selection_internal, Fx_get_selection_internal)
13779 (Fx_disown_selection_internal, Fx_selection_owner_p)
13780 (Fx_selection_exists_p): New optional frame arg.
13781 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
13782 (x_handle_selection_clear): Don't treat other terminals with the
13783 same keyboard specially. Use the terminal-local Vselection_alist.
13784 (x_clear_frame_selections): Use Frun_hook_with_args.
13785
13786 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
13787
13788 * xterm.h: Add support for those atoms.
13789
e067f0c1
CY
137902011-05-26 Chong Yidong <cyd@stupidchicken.com>
13791
13792 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
13793 (converted_selections, conversion_fail_tag): New global variables.
13794 (x_selection_request_lisp_error): Free the above.
13795 (x_get_local_selection): Remove unnecessary code.
13796 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
13797 of converted selections stored in converted_selections.
13798 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
13799 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
13800 (x_convert_selection): New function.
13801 (x_handle_selection_event): Simplify.
13802 (x_get_foreign_selection): Don't ignore incoming requests while
13803 waiting for an answer; this will fail when we implement
13804 SAVE_TARGETS, and seems unnecessary anyway.
13805 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
13806 (Vx_sent_selection_functions): Doc fix.
13807
0f4aebc0
LL
138082011-05-26 Leo Liu <sdl.web@gmail.com>
13809
13810 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
13811
e61124cd
YM
138122011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13813
13814 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
13815
13816 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
13817 for fringe update if it has periodic bitmap.
ac389d0c 13818 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
13819 and fringe_bitmap_periodic_p.
13820
13821 * fringe.c (get_fringe_bitmap_data): New function.
13822 (draw_fringe_bitmap_1, update_window_fringes): Use it.
13823 (update_window_fringes): Record periodicity of fringe bitmap in glyph
13824 row. Mark glyph row for fringe update if periodicity changed.
13825
13826 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
13827 for fringe update unless it has periodic bitmap.
13828
f16d9837
KH
138292011-05-25 Kenichi Handa <handa@m17n.org>
13830
13831 * xdisp.c (get_next_display_element): Set correct it->face_id for
13832 a static composition.
13833
e1b90ef6
LL
138342011-05-24 Leo Liu <sdl.web@gmail.com>
13835
13836 * deps.mk (fns.o):
13837 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
13838
13839 * fns.c (crypto_hash_function, Fsha1): New function.
13840 (Fmd5): Use crypto_hash_function.
13841 (syms_of_fns): Add Ssha1.
13842
7400048f
PE
138432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
13844
13845 * gnutls.c: Remove unused macros.
13846 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
13847 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
13848 Remove macros that are defined and never used.
13849 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
13850
abb71cf4
CY
138512011-05-22 Chong Yidong <cyd@stupidchicken.com>
13852
13853 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
13854 (Fx_get_selection_internal): Minor cleanup.
13855 (Fx_own_selection_internal): Rename arguments for consistency with
13856 select.el.
13857
6307db39
PE
138582011-05-22 Paul Eggert <eggert@cs.ucla.edu>
13859
13860 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
13861
f3d4e0a4
CY
138622011-05-22 Chong Yidong <cyd@stupidchicken.com>
13863
13864 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
13865
4d8ade89
YM
138662011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13867
13868 * dispnew.c (scrolling_window): Don't exclude the case that the
13869 last enabled row in the desired matrix touches the bottom boundary.
13870
32078c8d
GM
138712011-05-21 Glenn Morris <rgm@gnu.org>
13872
13873 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
13874 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
13875 and add some more files.
32078c8d 13876
7285dc67
EZ
138772011-05-20 Eli Zaretskii <eliz@gnu.org>
13878
13879 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
13880 report_file_error introduced by the change from 2011-05-07.
13881
89d1bd22
PE
138822011-05-20 Paul Eggert <eggert@cs.ucla.edu>
13883
13884 * systime.h (Time): Define only if emacs is defined.
13885 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
13886 where the include path doesn't have X11/X.h by default. See
13887 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
13888
cd394be1 138892011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
13890
13891 * composite.c (find_automatic_composition): Fix previous change.
13892
b9704ad9
GM
138932011-05-20 Glenn Morris <rgm@gnu.org>
13894
13895 * lisp.mk: New file, split from Makefile.in.
13896 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
13897 (shortlisp): Remove.
13898 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
13899
4a720484
GM
139002011-05-19 Glenn Morris <rgm@gnu.org>
13901
13902 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
13903 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
13904 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
13905 (lisp): Set the order to that of loadup.el.
13906 (shortlisp): Make it a copy of $lisp.
13907 (SOME_MACHINE_LISP): Remove.
13908 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
13909 Use just $shortlisp, not $SOME_MACHINE_LISP too.
13910
a28d4396
KH
139112011-05-18 Kenichi Handa <handa@m17n.org>
13912
13913 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
13914 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
13915 (find_automatic_composition): Mostly rewrite for efficiency.
13916
a2b1fa8e
JB
139172011-05-18 Juanma Barranquero <lekktu@gmail.com>
13918
13919 * makefile.w32-in: Update dependencies.
13920
8e1f5610
CS
139212011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
13922
13923 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 13924 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 13925
7025ee00 139262011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 13927
cdfa6eab
PE
13928 Fix some integer overflow issues, such as string length overflow.
13929
06d6db33
PE
13930 * insdel.c (count_size_as_multibyte): Check for string overflow.
13931
2b4560a8
PE
13932 * character.c (lisp_string_width): Check for string overflow.
13933 Use EMACS_INT, not int, for string indexes and lengths; in
13934 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
13935 the resulting string length overflows an EMACS_INT; instead,
13936 report a string overflow if no precision given. When checking for
13937 precision exhaustion, use a check that cannot possibly have
13938 integer overflow. (Bug#8675)
13939 * character.h (lisp_string_width): Adjust to new signature.
13940
cb93f9be
PE
13941 * alloc.c (string_overflow): New function.
13942 (Fmake_string): Use it. This doesn't change behavior, but saves
13943 a few bytes and will simplify future changes.
13944 * character.c (string_escape_byte8): Likewise.
13945 * lisp.h (string_overflow): New decl.
13946
1a1f3366
PE
13947 Fixups, following up to the user-interface timestamp change.
13948 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
13949 for UI timestamps, instead of unsigned long.
9fbd6841
PE
13950 * msdos.c (mouse_get_pos): Likewise.
13951 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
13952 * w32gui.h (Time): Define by including "systime.h" rather than by
13953 declaring it ourselves. (Bug#8664)
13954
d4e3e4d3
PE
13955 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
13956 * image.c (clear_image_cache): Likewise.
13957
f6a24d19
PE
13958 * term.c (term_mouse_position): Don't assume time_t wraparound.
13959
08dc5ae6
PE
13960 Be more systematic about user-interface timestamps.
13961 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
13962 and sometimes 'EMACS_UINT', to represent these timestamps.
13963 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
13964 This makes the code easier to follow, and makes it easier to catch
13965 integer overflow bugs such as Bug#8664.
13966 * frame.c (Fmouse_position, Fmouse_pixel_position):
13967 Use Time, not unsigned long, for user-interface timestamps.
13968 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
13969 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
13970 * keyboard.h (last_event_timestamp): Likewise.
13971 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
13972 * menu.h (xmenu_show): Likewise.
13973 * term.c (term_mouse_position): Likewise.
13974 * termhooks.h (struct input_event.timestamp): Likewise.
13975 (struct terminal.mouse_position_hook): Likewise.
13976 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
13977 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
13978 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
13979 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
13980 what it was before.
13981 * menu.h, termhooks.h: Include "systime.h", for Time.
13982
8e55734a
PE
13983 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
13984 Don't assume that the difference between two unsigned long values
13985 can fit into an integer. At this point, we know button_down_time
13986 <= event->timestamp, so the difference must be nonnegative, so
13987 there's no need to cast the result if double-click-time is
13988 nonnegative, as it should be; check that it's nonnegative, just in
13989 case. This bug is triggered when events are more than 2**31 ms
86db42d2 13990 apart (about 25 days). (Bug#8664)
8e55734a 13991
841f1b75 13992 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 13993 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 13994
3e26f69c
PE
13995 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
13996 that always fit in int. Use a sentinel instead of a counter, to
13997 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
13998 * frame.h (struct frame): Use int for menu_bar_items_used
13999 instead of EMACS_INT, since it always fits in int.
3e26f69c 14000
5cc152c0
PE
14001 * menu.c (grow_menu_items): Check for int overflow.
14002
d89eb65e
PE
14003 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
14004
5235bd3e
PE
14005 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
14006 Before, the code was not consistent. These values cannot exceed
14007 2**31 - 1 so there's no need to make them unsigned.
14008 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
14009 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
14010 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
14011 as modifiers.
14012 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
14013
bc827e23
PE
14014 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
14015 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
14016 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
14017 presumably because the widths might not match.
14018
78eb494e
PE
14019 * window.c (size_window): Avoid needless test at loop start.
14020
04f2d78b
CB
140212011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
14022
14023 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
14024
d2fc7e3d 140252011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
14026
14027 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
14028
d2fc7e3d 140292011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
14030
14031 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
14032 `width' to `bar_area_x' and `bar_area_width', respectively.
14033 (x_scroll_run): Take account of fringe background extension.
14034
04f2d78b
CB
14035 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
14036 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
14037 `bar_area_width', respectively.
14038 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
14039 background extension.
14040
79b70037
GM
140412011-05-10 Jim Meyering <meyering@redhat.com>
14042
14043 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
14044
2f142cc5
JB
140452011-05-10 Juanma Barranquero <lekktu@gmail.com>
14046
14047 * image.c (Finit_image_library): Return t for built-in image types,
14048 like pbm and xbm. (Bug#8640)
14049
57679c86
AS
140502011-05-09 Andreas Schwab <schwab@linux-m68k.org>
14051
14052 * w32menu.c (set_frame_menubar): Fix submenu allocation.
14053
888c9e86
EZ
140542011-05-07 Eli Zaretskii <eliz@gnu.org>
14055
b0512a1d
EZ
14056 * w32console.c (Fset_screen_color): Doc fix.
14057 (Fget_screen_color): New function.
14058 (syms_of_ntterm): Defsubr it.
14059
7285dc67
EZ
14060 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
14061 unlink the temporary file if Fcall_process didn't create it in the
14062 first place.
14063 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
14064 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
14065 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
14066 cue to call_process_cleanup not to close that handle.
14067
4d3fcc8e
BK
140682011-05-07 Ben Key <bkey76@gmail.com>
14069
14070 * makefile.w32-in: The bootstrap-temacs rule now makes use of
14071 one of two shell specific rules, either bootstrap-temacs-CMD or
14072 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
14073 to the previous implementation of the bootstrap-temacs rule.
14074 The bootstrap-temacs-CMD rule is similar to the previous
14075 implementation of the bootstrap-temacs rule except that it
14076 makes use of the ESC_CFLAGS variable instead of the CFLAGS
14077 variable.
14078
14079 These changes, along with some changes to nt/configure.bat,
14080 nt/gmake.defs, and nt/nmake.defs, are required to extend my
14081 earlier fix to add support for --cflags and --ldflags options
14082 that include quotes so that it works whether make uses cmd or
14083 sh as the shell.
14084
b4289b64
MA
140852011-05-06 Michael Albinus <michael.albinus@gmx.de>
14086
14087 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
14088 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
14089 is a constant.
14090 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
14091 a string. Handle both cases.
14092 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
14093 (Fdbus_register_method): Use Qinvalid_function.
14094
af4c0e28
JB
140952011-05-06 Juanma Barranquero <lekktu@gmail.com>
14096
14097 * makefile.w32-in: Update dependencies.
14098 (LISP_H): Add inttypes.h and stdin.h.
14099 (PROCESS_H): Add unistd.h.
14100
c51453d9
EZ
141012011-05-06 Eli Zaretskii <eliz@gnu.org>
14102
14103 * lread.c: Include limits.h (fixes the MS-Windows build broken by
14104 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
14105
8ff0ac3c 141062011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 14107
4c4b566b
PE
14108 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
14109
aab2b9b5
PE
14110 * term.c (vfatal): Remove stray call to va_end.
14111 It's not needed and the C Standard doesn't allow it here anyway.
14112
c378da0b
PE
14113 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
14114 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
14115
288b08c7
PE
14116 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
14117 bytes.
14118
e3601888
PE
14119 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
14120
db6c0e74
PE
14121 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
14122
dd5963ea
PE
14123 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
14124
88c9450f
PE
14125 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
14126
2f9442b8
PE
14127 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
14128
c032b5f8
PE
14129 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
14130 * charset.c (Fdefine_charset_internal): Don't initialize
14131 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 14132 32-bit int (Bug#8600).
a108c10b
PE
14133
14134 * lread.c (read_integer): Be more consistent with string-to-number.
14135 Use string_to_number to do the actual conversion; this avoids
14136 rounding errors and fixes some other screwups. Without this fix,
14137 for example, #x1fffffffffffffff was misread as -2305843009213693952.
14138 (digit_to_number): Move earlier, for benefit of read_integer.
14139 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 14140 not a digit in any supported base. (Bug#8602)
a108c10b 14141
ad5f9eea
PE
14142 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
14143
aec1708a
PE
14144 * dispnew.c (scrolling_window): Return 1 if we scrolled,
14145 to match comment at start of function. This also removes a
14146 GCC warning about overflow in a 32+64-bit port.
14147
47be4ab5
PE
14148 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
14149
371cac43
PE
14150 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
14151 Reported by Stefan Monnier in
14152 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
14153 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14154 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 14155
d01a7826
PE
14156 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
14157 (EMACS_UINTPTR): Likewise, with uintptr_t.
14158
7fd47d5c
PE
14159 * lisp.h: Prefer 64-bit EMACS_INT if available.
14160 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
14161 on 32-bit hosts that have 64-bit int, so that they can access
14162 large files.
122b0c86
PE
14163 However, temporarily disable this change unless the temporary
14164 symbol WIDE_EMACS_INT is defined.
7fd47d5c 14165
8727937b
PE
14166 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
14167
8ac068ac
PE
14168 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
14169 This removes an assumption that EMACS_INT and long are the same
14170 width as pointers. The assumption is true for Emacs porting targets
14171 now, but we want to make other targets possible.
14172 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
14173 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
14174 In the rest of the code, change types of integers that hold casted
14175 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
14176 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
14177 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
14178 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
14179 No need to cast type when ORing.
14180 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
14181 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
14182 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
14183 assume EMACS_INT is the same width as char *.
14184 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
14185 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
14186 Remove no-longer-needed casts.
14187 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
14188 (xg_tool_bar_help_callback, xg_make_tool_item):
14189 Use EMACS_INTPTR to hold an integer
14190 that will be cast to void *; this can avoid a GCC warning
14191 if EMACS_INT is not the same width as void *.
14192 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
14193 * xdisp.c (display_echo_area_1, resize_mini_window_1):
14194 (current_message_1, set_message_1):
14195 Use a local to convert to proper width without a cast.
14196 * xmenu.c (dialog_selection_callback): Likewise.
14197
ede49d71
PE
14198 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
14199 Also, don't assume VALBITS / RAND_BITS is less than 5,
14200 and don't rely on undefined behavior when shifting a 1 left into
14201 the sign bit.
14202 * lisp.h (get_random): Change signature to match.
14203
2f30ecd0
PE
14204 * lread.c (hash_string): Use size_t, not int, for hash computation.
14205 Normally we prefer signed values; but hashing is special, because
14206 it's better to use unsigned division on hash table sizes so that
14207 the remainder is nonnegative. Also, size_t is the natural width
14208 for hashing into memory. The previous code used 'int', which doesn't
14209 retain enough info to hash well into very large tables.
14210 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
14211
2a866e7b
PE
14212 * dbusbind.c: Don't possibly lose pointer info when converting.
14213 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14214 Use XPNTR rather than XHASH, so that the high-order bits of
14215 the pointer aren't lost when converting through void *.
14216
51639eac
PE
14217 * eval.c (Fautoload): Don't double-shift a pointer.
14218
92394119
PE
14219 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
14220
dbdb9a7c
JB
142212011-05-06 Juanma Barranquero <lekktu@gmail.com>
14222
14223 * gnutls.c (DEF_GNUTLS_FN):
14224 * image.c (DEF_IMGLIB_FN): Make function pointers static.
14225
db7a0b4f
AS
142262011-05-05 Andreas Schwab <schwab@linux-m68k.org>
14227
14228 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
14229 marker. (Bug#8610)
14230
cd394be1 142312011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
14232
14233 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
14234 New version that can reserve upto 2GB of heap space.
14235
f7ff1b0f 142362011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
14237
14238 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
14239
639c109b
TZ
142402011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
14241
14242 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
14243 `gnutls_certificate_set_x509_key_file'.
14244
d2127135
JB
142452011-05-05 Juanma Barranquero <lekktu@gmail.com>
14246
14247 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
14248 Update dependencies.
14249
e968f4f3
JB
142502011-05-04 Juanma Barranquero <lekktu@gmail.com>
14251
14252 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
14253 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
14254 Remove unused parameter `fildes'.
14255 * process.c (read_process_output, send_process): Don't pass it.
14256
84d358f0
JB
142572011-05-04 Juanma Barranquero <lekktu@gmail.com>
14258
14259 Fix previous change: the library cache is defined in w32.c.
14260 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
14261 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
14262
0898ca10
JB
142632011-05-04 Juanma Barranquero <lekktu@gmail.com>
14264
14265 Implement dynamic loading of GnuTLS on Windows.
14266
14267 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
14268 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
14269 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
14270 Declare.
14271
14272 * gnutls.c (Qgnutls_dll): Define.
14273 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
14274 (gnutls_*): Declare function pointers.
14275 (init_gnutls_functions): New function to initialize function pointers.
14276 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
14277 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
14278 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
14279 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
14280 (emacs_gnutls_write, emacs_gnutls_read)
14281 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
14282 (Fgnutls_available_p): New function.
14283 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
14284 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
14285 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
14286
14287 * image.c: Include w32.h.
14288 (Vimage_type_cache): Delete.
14289 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
14290 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
14291 (w32_delayed_load): Move to w32.c.
14292
14293 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
14294
14295 * w32.c (QCloaded_from, Vlibrary_cache): Define.
14296 (w32_delayed_load): Move from image.c. When loading a library, record
14297 its filename in the :loaded-from property of the library id.
14298 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
14299 Initialize and staticpro them.
14300 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
14301
14302 * process.c: Include lisp.h before w32.h, not after.
14303 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
14304 instead of gnutls_record_check_pending.
14305
14306 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
14307
ff4de4aa
TZ
143082011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
14309
14310 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
14311 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
14312 as passed in.
14313
abe95abb
JD
143142011-05-03 Jan Djärv <jan.h.d@swipnet.se>
14315
14316 * xterm.c (x_set_frame_alpha): Do not set property on anything
14317 else than FRAME_X_OUTER_WINDOW (Bug#8608).
14318
e16e55d4
JB
143192011-05-02 Juanma Barranquero <lekktu@gmail.com>
14320
14321 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
14322
bafcf6a5
JB
143232011-05-02 Juanma Barranquero <lekktu@gmail.com>
14324
14325 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
14326 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
14327 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
14328 (gnutls_global_initialized, Qgnutls_bootprop_priority)
14329 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
14330 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
14331 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
14332 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
14333 (Qgnutls_bootprop_callbacks_verify): Make static.
14334
e7a6747f
AS
143352011-05-01 Andreas Schwab <schwab@linux-m68k.org>
14336
19ed11ba
AS
14337 * callproc.c: Indentation fixup.
14338
e7a6747f 14339 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
14340 (wait_for_termination, interruptible_wait_for_termination):
14341 Move after wait_for_termination_1.
e7a6747f 14342
1ef14cb4
LMI
143432011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
14344
14345 * sysdep.c (interruptible_wait_for_termination): New function
14346 which is like wait_for_termination, but allows keyboard
14347 interruptions.
14348
14349 * callproc.c (Fcall_process): Add (:file "file") as an option for
14350 the STDOUT buffer.
14351 (Fcall_process_region): Ditto.
14352
330d880c
EZ
143532011-04-30 Eli Zaretskii <eliz@gnu.org>
14354
8db90b73
EZ
14355 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
14356 rather than `XVECTOR (FOO)->size'.
14357
330d880c
EZ
14358 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
14359 inttypes.h, as a gnulib replacement is used if it not available in
14360 system headers.
14361
15cbd324
EZ
143622011-04-21 Eli Zaretskii <eliz@gnu.org>
14363
14364 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
14365 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
14366 of MOST_POSITIVE_FIXNUM. (Bug#8528)
14367
14368 * coding.c (coding_alloc_by_realloc): Error out if destination
14369 will grow beyond MOST_POSITIVE_FIXNUM.
14370 (decode_coding_emacs_mule): Abort if there isn't enough place in
14371 charbuf for the composition carryover bytes. Reserve an extra
14372 space for up to 2 characters produced in a loop.
14373 (decode_coding_iso_2022): Abort if there isn't enough place in
14374 charbuf for the composition carryover bytes.
14375
143762011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 14377
ae940cca
EZ
14378 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
14379 aborting when %lld or %lll format is passed.
14380 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
14381 %llo or %llx format is passed. (Bug#8545)
14382
03ab8921
EZ
14383 * window.c (window_scroll_line_based): Use a marker instead of
14384 simple variables to record original value of point. (Bug#7952)
14385
afda1437
EZ
14386 * doprnt.c (doprnt): Fix the case where a multibyte sequence
14387 produced by %s or %c overflows available buffer space. (Bug#8545)
14388
f76dee0c
PE
143892011-04-28 Paul Eggert <eggert@cs.ucla.edu>
14390
14391 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 14392 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 14393
fdc5744d
JB
143942011-04-28 Juanma Barranquero <lekktu@gmail.com>
14395
14396 * w32.c (init_environment): Warn about defaulting HOME to C:\.
14397
638f053a
JB
143982011-04-28 Juanma Barranquero <lekktu@gmail.com>
14399
14400 * keyboard.c (Qdelayed_warnings_hook): Define.
14401 (command_loop_1): Run `delayed-warnings-hook'
14402 if Vdelayed_warnings_list is non-nil.
14403 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
14404 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
14405
d178f871
EZ
144062011-04-28 Eli Zaretskii <eliz@gnu.org>
14407
14408 * doprnt.c (doprnt): Don't return value smaller than the buffer
14409 size if the message was truncated. (Bug#8545).
14410
b124fd93
JB
144112011-04-28 Juanma Barranquero <lekktu@gmail.com>
14412
14413 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
14414 (Fx_window_property): #if-0 the whole functions, not just the bodies.
14415
e810457d
PE
144162011-04-27 Paul Eggert <eggert@cs.ucla.edu>
14417
14418 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
14419
ea51cceb
JB
144202011-04-27 Juanma Barranquero <lekktu@gmail.com>
14421
14422 * makefile.w32-in: Update dependencies.
14423
94dcfacf
EZ
144242011-04-27 Eli Zaretskii <eliz@gnu.org>
14425
14426 Improve `doprnt' and its usage. (Bug#8545)
14427 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
14428 `format_end'. Remove support for %l as a conversion specifier.
14429 Don't use xrealloc. Improve diagnostics when the %l size modifier
14430 is used. Update the commentary.
14431
14432 * eval.c (verror): Simplify calculation of size_t.
14433
14434 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
14435 messages.
14436
f61f41d7
PE
144372011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
14438
14439 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
14440 change.
14441
96fb4434
PE
144422011-04-27 Paul Eggert <eggert@cs.ucla.edu>
14443
14444 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
14445 This makes this file independent of the recent pseudovector change.
14446
671875da 144472011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 14448
69e9b5a3
PE
14449 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
14450
b5f869a7 14451 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 14452 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 14453 Remove unused local.
c8926152 14454 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 14455
841a1577 14456 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
14457 GCC 4.6.0 optimizes based on type-based alias analysis.
14458 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
14459 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
14460 != &v->size, and therefore "v->size = 1; b->size = 2; return
14461 v->size;" must therefore return 1. This assumption is incorrect
14462 for Emacs, since it type-puns struct Lisp_Vector * with many other
14463 types. To fix this problem, this patch adds a new type struct
f904488f 14464 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
14465 and pseudovectors, and helps optimizing compilers not get fooled
14466 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
14467 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
14468 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
14469 the size member.
eab3844f
PE
14470 (XSETPVECTYPE): Rewrite in terms of new macro.
14471 (XSETPVECTYPESIZE): New macro, specifying both type and size.
14472 This is a bit clearer, and further avoids the possibility of
14473 undesirable aliasing.
14474 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 14475 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
14476 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
14477 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
14478 (ASIZE): Now uses header.size rather than size.
14479 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
14480 to avoid the hassle of writing XVECTOR (foo)->header.size.
14481 (struct vectorlike_header): New type.
eab3844f
PE
14482 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
14483 object, to help avoid aliasing.
14484 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
14485 (SUBRP): Likewise, since Lisp_Subr is a special case.
14486 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
14487 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
14488 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 14489 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
14490 changed to be "header.size" and "header.next".
14491 * buffer.h (struct buffer): Likewise.
14492 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
14493 * frame.h (struct frame): Likewise.
14494 * process.h (struct Lisp_Process): Likewise.
14495 * termhooks.h (struct terminal): Likewise.
14496 * window.c (struct save_window_data, struct saved_window): Likewise.
14497 * window.h (struct window): Likewise.
14498 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
14499 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
14500 * buffer.c (init_buffer_once): Likewise.
14501 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
14502 special case.
14503 * process.c (Fformat_network_address): Use local var for size,
14504 for brevity.
14505
0df1eac5
PE
14506 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
14507
847ab9d1 14508 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
14509 * data.c (atof): Remove decl; no longer used or needed.
14510 (digit_to_number): Move to lread.c.
14511 (Fstring_to_number): Use new string_to_number function, to be
14512 consistent with how the Lisp reader treats infinities and NaNs.
14513 Do not assume that floating-point numbers represent EMACS_INT
14514 without losing information; this is not true on most 64-bit hosts.
14515 Avoid double-rounding errors, by insisting on integers when
14516 parsing non-base-10 numbers, as the documentation specifies.
14517 * lisp.h (string_to_number): New decl, replacing ...
14518 (isfloat_string): Remove.
bc0a5c13 14519 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 14520 (read1): Do not accept +. and -. as integers; this
452f4150
PE
14521 appears to have been a coding error. Similarly, do not accept
14522 strings like +-1e0 as floating point numbers. Do not report
14523 overflow for integer overflows unless the base is not 10 which
14524 means we have no simple and reliable way to continue.
14525 Break out the floating-point parsing into a new
14526 function string_to_number, so that Fstring_to_number parses
14527 floating point numbers consistently with the Lisp reader.
04f2d78b 14528 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
14529 (E_CHAR, EXP_INT): Remove, replacing with ...
14530 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
14531 (string_to_number): New function, replacing isfloat_string.
14532 This function checks for valid syntax and produces the resulting
14533 Lisp float number too. Rework it so that string-to-number
bc0a5c13 14534 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
14535 so that overflow for non-base-10 numbers is reported only when
14536 there's no portable and simple way to convert to floating point.
452f4150 14537
67769ffc
PE
14538 * textprop.c (set_text_properties_1): Rewrite for clarity,
14539 and to avoid GCC warning about integer overflow.
14540
c20db43f
PE
14541 * intervals.h (struct interval): Use EMACS_INT for members
14542 where EMACS_UINT might cause problems. See
14543 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
14544 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
14545 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
14546 All uses changed.
37aa2f85
PE
14547 (offset_intervals): Tell GCC not to worry about length overflow
14548 when negating a negative length.
c20db43f 14549
2538aa2f
PE
14550 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
14551 (overrun_check_free): Likewise.
14552
f2d3008d
PE
14553 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
14554 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
14555 word size.
14556
ec8df744
PE
14557 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
14558 (gnutls_make_error): Rename local to avoid shadowing.
14559 (gnutls_emacs_global_deinit): ifdef out; not used.
14560 (Fgnutls_boot): Use const for pointer to readonly storage.
14561 Comment out unused local. Fix pointer signedness problems.
14562
640ee02d
PE
14563 * lread.c (openp): Don't stuff size_t into an 'int'.
14564 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
14565 about possible signed overflow.
14566
6048fb2a
PE
14567 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
14568 (GDK_KEY_g): Don't define if already defined.
14569 (xg_prepare_tooltip): Avoid pointer signedness problem.
14570 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
14571
fa3c87e1
PE
14572 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
14573 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
14574
2172544b
PE
14575 * xfns.c (Fx_window_property): Simplify a bit,
14576 to make a bit faster and to avoid GCC 4.6.0 warning.
14577 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
14578
9b821a21
PE
14579 * fns.c (internal_equal): Don't assume size_t fits in int.
14580
3c616cfa
PE
14581 * alloc.c (compact_small_strings): Tighten assertion a little.
14582
c2982e87
PE
14583 Replace pEd with more-general pI, and fix some printf arg casts.
14584 * lisp.h (pI): New macro, generalizing old pEd macro to other
14585 conversion specifiers. For example, use "...%"pI"d..." rather
14586 than "...%"pEd"...".
14587 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 14588 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
14589 * alloc.c (check_pure_size): Don't overflow by converting size to int.
14590 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
14591 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
14592 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
14593 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
14594 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
14595 64-bit hosts.
14596 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
14597 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
14598 * print.c (safe_debug_print, print_object): Likewise.
14599 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
14600 to int.
6f04d126
PE
14601 Use pI instead of if-then-else-abort. Use %p to avoid casts,
14602 avoiding the 0 flag, which is not portable.
c2982e87
PE
14603 * process.c (Fmake_network_process): Use pI to avoid cast.
14604 * region-cache.c (pp_cache): Likewise.
14605 * xdisp.c (decode_mode_spec): Likewise.
14606 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
14607 behavior on 64-bit hosts with printf arg.
6f04d126 14608 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
14609 (x_stop_queuing_selection_requests): Likewise.
14610 (x_get_window_property): Don't truncate byte count to an 'int'
14611 when tracing.
0b432f21 14612
5e073ec7
PE
14613 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
14614 here, since it parses constructs like leading '-' and spaces,
14615 which are not wanted; and it overflows with large numbers.
14616 Instead, simply match F[0-9]+, which is what is wanted anyway.
14617
36372bf9
PE
14618 * alloc.c: Remove unportable assumptions about struct layout.
14619 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
14620 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
14621 (allocate_vectorlike, make_pure_vector): Use the new macros,
14622 plus offsetof, to remove unportable assumptions about struct layout.
14623 These assumptions hold on all porting targets that I know of, but
14624 they are not guaranteed, they're easy to remove, and removing them
14625 makes further changes easier.
14626
0b432f21
PE
14627 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
14628 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
14629 (string_overrun_cookie): Now const. Use initializers that
14630 don't formally overflow signed char, to avoid warnings.
000098c1
PE
14631 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
14632 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
14633 (allocate_buffer): Don't assume sizeof (struct buffer) is a
14634 multiple of sizeof (EMACS_INT); it need not be, if
14635 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 14636 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 14637
895009e1
JB
146382011-04-26 Juanma Barranquero <lekktu@gmail.com>
14639
14640 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
14641
6a7a1b0b
TZ
146422011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
14643
14644 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 14645 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
14646 Reported by Paul Eggert <eggert@cs.ucla.edu>.
14647
841a1577 146482011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
14649
14650 * lisp.h (Qdebug): List symbol.
895009e1 14651 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
14652 * keyboard.c (debug-on-event): New variable.
14653 (handle_user_signal): Break into debugger when debug-on-event
14654 matches the current signal symbol.
14655
f2d3ba6f
DN
146562011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
14657
14658 * alloc.c (check_sblock, check_string_bytes)
14659 (check_string_free_list): Convert to standard C.
14660
42ce4c63
TZ
146612011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
14662
14663 * w32.c (emacs_gnutls_push): Fix typo.
14664
825cd63c
EZ
146652011-04-25 Eli Zaretskii <eliz@gnu.org>
14666
fb11d64d
EZ
14667 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
14668 "cast to pointer from integer of different size".
14669
825cd63c
EZ
14670 Improve doprnt and its use in verror. (Bug#8545)
14671 * doprnt.c (doprnt): Document the set of format control sequences
14672 supported by the function. Use SAFE_ALLOCA instead of always
14673 using `alloca'.
14674
14675 * eval.c (verror): Don't limit the buffer size at size_max-1, that
14676 is one byte too soon. Don't use xrealloc; instead xfree and
14677 xmalloc anew.
14678
e061a11b
TZ
146792011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
14680
14681 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
14682 callbacks stage.
14683
14684 * gnutls.c: Renamed global_initialized to
14685 gnutls_global_initialized. Added internals for the
14686 :verify-hostname-error, :verify-error, and :verify-flags
14687 parameters of `gnutls-boot' and documented those parameters in the
14688 docstring. Start callback support.
9173deec
JB
14689 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
14690 unless a fatal error occurred. Call gnutls_alert_send_appropriate
14691 on error. Return error code.
e061a11b
TZ
14692 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
14693 (emacs_gnutls_read): Likewise.
14694 (Fgnutls_boot): Return handshake error code.
14695 (emacs_gnutls_handle_error): New function.
14696 (wsaerror_to_errno): Likewise.
14697
14698 * w32.h (emacs_gnutls_pull): Add prototype.
14699 (emacs_gnutls_push): Likewise.
14700
14701 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
14702 (emacs_gnutls_push): Likewise.
14703
147042011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
14705
14706 * process.c (wait_reading_process_output): Check if GnuTLS
14707 buffered some data internally if no FDs are set for TLS
14708 connections.
14709
14710 * makefile.w32-in (OBJ2): Add gnutls.$(O).
14711 (LIBS): Link to USER_LIBS.
14712 ($(BLD)/gnutls.$(0)): New target.
14713
fa6996bc
EZ
147142011-04-24 Eli Zaretskii <eliz@gnu.org>
14715
eb35682e
EZ
14716 * xdisp.c (handle_single_display_spec): Rename the
14717 display_replaced_before_p argument into display_replaced_p, to
14718 make it consistent with the commentary. Fix typos in the
14719 commentary.
14720
e2ad650c
EZ
14721 * textprop.c (syms_of_textprop): Remove dead code.
14722 (copy_text_properties): Delete obsolete commentary about an
14723 interface that was deleted long ago. Fix typos in the description
14724 of arguments.
14725
1b2de274
EZ
14726 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
14727 to changes in oldXMenu/XMenu.h from 2011-04-16.
14728 <menu_help_message, prev_menu_help_message>: Constify.
14729 (IT_menu_make_room): menu->help_text is now `const char **';
14730 adjust.
14731
14732 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
14733 to changes in oldXMenu/XMenu.h from 2011-04-16.
14734 (struct XMenu): Declare `help_text' `const char **'.
14735
14736 * xfaces.c <Qunspecified>: Make extern again.
14737
14738 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 14739 required by POSIX.
1b2de274 14740
762b15be
EZ
14741 * doc.c (get_doc_string): Improve the format passed to `error'.
14742
14743 * doprnt.c (doprnt): Improve commentary.
14744
14745 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
14746
14747 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
14748 them with etags.
14749
f1052e5d
EZ
14750 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
14751 changes in globals.h immediately force recompilation.
762b15be
EZ
14752 (TAGS): Depend on $(CURDIR)/m/intel386.h and
14753 $(CURDIR)/s/ms-w32.h.
14754 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 14755
fa6996bc
EZ
14756 * character.c (Fchar_direction): Function deleted.
14757 (syms_of_character): Don't defsubr it.
14758 <char-direction-table>: Deleted.
14759
e6c3da20
EZ
147602011-04-23 Eli Zaretskii <eliz@gnu.org>
14761
14762 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
14763 * doprnt.c: Include limits.h.
14764 (SIZE_MAX): New macro.
04f2d78b
CB
14765 (doprnt): Return a size_t value. 2nd arg is now size_t.
14766 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
14767 Improve overflow protection. Support `l' modifier for integer
14768 conversions. Support %l conversion. Don't assume an EMACS_INT
14769 argument for integer conversions and for %c.
14770
14771 * lisp.h (doprnt): Restore prototype.
14772
14773 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
14774 $(SRC)/character.h.
14775
14776 * Makefile.in (base_obj): Add back doprnt.o.
14777
14778 * deps.mk (doprnt.o): Add back prerequisites.
14779 (callint.o): Depend on character.h.
14780
14781 * eval.c (internal_lisp_condition_case): Include the handler
14782 representation in the error message.
14783 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
14784 when breaking from the loop.
14785
14786 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
14787
14788 * callint.c (Fcall_interactively): When displaying error message
14789 about invalid control letter, pass the character's codepoint, not
14790 a pointer to its multibyte form. Improve display of the character
14791 in octal and display also its hex code.
14792
14793 * character.c (char_string): Use %x to display the (unsigned)
14794 codepoint of an invalid character, to avoid displaying a bogus
14795 negative value.
14796
14797 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
14798 `error', not SYMBOL_NAME itself.
14799
14800 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
14801 character arguments to `error'.
14802
14803 * charset.c (check_iso_charset_parameter): Fix incorrect argument
14804 to `error' in error message about FINAL_CHAR argument. Make sure
14805 FINAL_CHAR is a character, and use %c when it is passed as
14806 argument to `error'.
14807
4ffd0d6b 148082011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
14809
14810 * s/ms-w32.h (localtime): Redirect to sys_localtime.
14811
14812 * w32.c: Include <time.h>.
14813 (sys_localtime): New function.
14814
4ffd0d6b 148152011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
14816
14817 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
14818
4ffd0d6b 14819 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 14820
4ffd0d6b 148212011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 14822
4ffd0d6b
GM
14823 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
14824 zombies (Bug#8467).
aac0c6e3 14825
04c56954
EZ
148262011-04-19 Eli Zaretskii <eliz@gnu.org>
14827
14828 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
14829 gl_state.e_property when gl_state.object is Qt.
14830
14831 * insdel.c (make_gap_larger): Remove limitation of buffer size
14832 to <= INT_MAX.
14833
16a43933
CY
148342011-04-18 Chong Yidong <cyd@stupidchicken.com>
14835
14836 * xdisp.c (lookup_glyphless_char_display)
14837 (produce_glyphless_glyph): Handle cons cell entry in
14838 glyphless-char-display.
14839 (Vglyphless_char_display): Document it.
14840
14841 * term.c (produce_glyphless_glyph): Handle cons cell entry in
14842 glyphless-char-display.
14843
4581706e
CY
148442011-04-17 Chong Yidong <cyd@stupidchicken.com>
14845
14846 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
14847
14848 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
14849
14850 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
14851 definition for no-X builds.
14852
4887c6e2 148532011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 14854
fd35b6f9
PE
14855 Static checks with GCC 4.6.0 and non-default toolkits.
14856
5c1ccb01
PE
14857 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
14858
006c5daa
PE
14859 * process.c (keyboard_bit_set): Define only if SIGIO.
14860 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
14861 (send_process): Repair possible setjmp clobbering.
14862
efc736d3
PE
14863 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
14864
4e2fe2e6
PE
14865 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
14866
f97334a2
PE
14867 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
14868
4e75f29d
PE
14869 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
14870 Define only if needed.
14871
90efadd1
PE
14872 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
14873 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 14874 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 14875
3c647824
PE
14876 * dispextern.h (struct redisplay_interface): Rename param
14877 to avoid shadowing.
e264f262 14878 * termhooks.h (struct terminal): Likewise.
761383f4 14879 * xterm.c (xembed_send_message): Likewise.
3c647824 14880
b58c5c4a
PE
14881 * insdel.c (make_gap_smaller): Define only if
14882 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
14883
cad59032
PE
14884 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
14885 it.
14886
c339dc2e
PE
14887 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
14888 so that we aren't warned about unused symbols.
14889
91a3e27b
PE
14890 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
14891
399c71d3 14892 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 14893
8ffc96f5
PE
14894 * xfns.c (x_real_positions): Mark locals as initialized.
14895
eef9bc79
PE
14896 * xmenu.c (xmenu_show): Don't use uninitialized vars.
14897
098db9dd
PE
14898 * xterm.c: Fix problems found by static analysis with other toolkits.
14899 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
14900 (x_dispatch_event): Declare static if USE_GTK, and
14901 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 14902 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 14903 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
14904 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
14905 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 14906
eb18f6cc
PE
14907 * xmenu.c (menu_help_callback): Pointer type fixes.
14908 Use const pointers when pointing at readonly data. Avoid pointer
14909 signedness clashes.
14910 (FALSE): Remove unused macro.
14911 (update_frame_menubar): Remove unused decl.
14912
1fe72bf8
PE
14913 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
14914
60d9e1db
PE
14915 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
14916 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
14917 (single_menu_item): Rename local to avoid shadowing.
14918
39261c26
PE
14919 * keyboard.c (make_lispy_event): Remove unused local var.
14920
018c5e19
PE
14921 * frame.c, frame.h (x_get_resource_string): Bring this back, but
14922 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
14923
63d2b86e
PE
14924 * bitmaps: Change bitmaps from unsigned char back to the X11
14925 compatible char. Avoid the old compiler warnings about
14926 out-of-range initializers by using, for example, '\xab' rather
14927 than 0xab.
14928
aefd87e1
PE
14929 * xgselect.c (xgselect_initialize): Check vs interface
14930 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
14931
bf501fb9
PE
14932 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
14933
e9829fdf
PE
14934 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
14935 to read-only memory.
14936
1086c095
PE
14937 * fns.c (vector): Remove; this old hack is no longer needed.
14938
2baccd04 14939 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 14940 Remove unused var.
dde42981 14941 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 14942
72391843 14943 * xrdb.c (x_load_resources): Omit unused local.
3565b346 14944
436c16df 14945 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 14946 (x_window): Rename locals to avoid shadowing.
dc5ddd85 14947 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 14948
92bb796d 14949 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 14950 (x_term_init): Remove local to avoid shadowing.
92bb796d 14951
764430a3 14952 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
14953
14954 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
14955 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
14956
d1dfb56c
EZ
149572011-04-16 Eli Zaretskii <eliz@gnu.org>
14958
c4354cb4
EZ
14959 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
14960
d1dfb56c
EZ
14961 Fix regex.c, syntax.c and friends for buffers > 2GB.
14962 * syntax.h (struct gl_state_s): Declare character position members
14963 EMACS_INT.
14964
14965 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
14966
04f2d78b
CB
14967 * textprop.c (verify_interval_modification, interval_of):
14968 Declare arguments EMACS_INT.
d1dfb56c
EZ
14969
14970 * intervals.c (adjust_intervals_for_insertion): Declare arguments
14971 EMACS_INT.
14972
14973 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
14974
14975 * indent.c (Fvertical_motion): Local variable it_start is now
14976 EMACS_INT.
14977
14978 * regex.c (re_match, re_match_2, re_match_2_internal)
14979 (bcmp_translate, regcomp, regexec, print_double_string)
14980 (group_in_compile_stack, re_search, re_search_2, regex_compile)
14981 (re_compile_pattern, re_exec): Declare arguments and local
14982 variables `size_t' and `ssize_t' and return values `regoff_t', as
14983 appropriate.
14984 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
14985 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
14986 <compile_stack_type>: `size' and `avail' are now `size_t'.
14987
14988 * regex.h <regoff_t>: Use ssize_t, not int.
14989 (re_search, re_search_2, re_match, re_match_2): Arguments that
14990 specify buffer/string position and length are now ssize_t and
14991 size_t. Return type is regoff_t.
14992
613052cd
BK
149932011-04-16 Ben Key <bkey76@gmail.com>
14994
14995 * nsfont.m: Fixed bugs in ns_get_family and
14996 ns_descriptor_to_entity that were caused by using free to
14997 deallocate memory blocks that were allocated by xmalloc (via
14998 xstrdup). This caused Emacs to crash when compiled with
14999 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
15000 --enable-checking=xmallocoverrun). xfree is now used to
15001 deallocate these memory blocks.
15002
4170f62f 150032011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 15004
71b41406
PE
15005 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
15006
9587a89d
PE
15007 emacs_write: Accept and return EMACS_INT for sizes.
15008 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
15009 et seq.
15010 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
15011 Accept and return EMACS_INT.
15012 (emacs_gnutls_write): Return the number of bytes written on
15013 partial writes.
15014 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
15015 (emacs_read, emacs_write): Remove check for negative size, as the
15016 Emacs source code has been audited now.
9587a89d
PE
15017 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
15018 (emacs_read, emacs_write): Use it.
273a5f82
PE
15019 * process.c (send_process): Adjust to the new signatures of
15020 emacs_write and emacs_gnutls_write. Do not attempt to store
15021 a byte offset into an 'int'; it might overflow.
9587a89d 15022 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 15023
3e047f51
PE
15024 * sound.c: Don't assume sizes fit in 'int'.
15025 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 15026 Return EMACS_INT, not int.
3e047f51 15027 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
15028 Accept EMACS_INT, not int.
15029 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
15030 record read return values.
15031
cc39a9db
BK
150322011-04-15 Ben Key <bkey76@gmail.com>
15033
c9d0ec6d
JB
15034 * keyboard.c (Qundefined): Don't declare static since it is used
15035 in nsfns.m.
15036 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
15037 static since they are used in nsfont.m.
cc39a9db 15038
6c60eb9f
SM
150392011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
15040
15041 * process.c (Qprocessp): Don't declare static.
15042 * lisp.h (Qprocessp): Declare again.
15043
7990b61a
JB
150442011-04-15 Juanma Barranquero <lekktu@gmail.com>
15045
15046 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
15047
5d4cb038
PE
150482011-04-14 Paul Eggert <eggert@cs.ucla.edu>
15049
8bd7b830 15050 Improve C-level modularity by making more things 'static'.
cd64ea1d 15051
e3b27b31
PE
15052 Don't publish debugger-only interfaces to other modules.
15053 * lisp.h (safe_debug_print, debug_output_compilation_hack):
15054 (verify_bytepos, count_markers): Move decls to the only modules
15055 that need them.
15056 * region-cache.h (pp_cache): Likewise.
15057 * window.h (check_all_windows): Likewise.
15058 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
15059
5d4cb038
PE
15060 * sysdep.c (croak): Now static, if
15061 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
15062 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
15063
15064 * alloc.c (refill_memory_reserve): Now static if
15065 !defined REL_ALLOC || defined SYSTEM_MALLOC.
15066 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 15067
e87b6180
PE
15068 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
15069 Define only if USE_LUCID.
15070
ac64929e
PE
15071 * xrdb.c (x_customization_string, x_rm_string): Now static.
15072
6f37259d
PE
15073 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
15074 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
15075
1683e3ab
PE
15076 * xdisp.c (draw_row_with_mouse_face): Now static.
15077 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
15078
de9c2632
PE
15079 * window.h (check_all_windows): Mark externally visible.
15080
2b96acb7
PE
15081 * window.c (window_deletion_count): Now static.
15082
15083 * undo.c: Make symbols static if they're not exported.
15084 (last_undo_buffer, last_boundary_position, pending_boundary):
15085 Now static.
15086
50436f33
PE
15087 * textprop.c (interval_insert_behind_hooks): Now static.
15088 (interval_insert_in_front_hooks): Likewise.
15089
64520e5c
PE
15090 * term.c: Make symbols static if they're not exported.
15091 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
15092 (max_frame_lines, tty_set_terminal_modes):
15093 (tty_reset_terminal_modes, tty_turn_off_highlight):
15094 (get_tty_terminal): Now static.
15095 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
15096 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 15097 HAVE_WINDOW_SYSTEM.
64520e5c
PE
15098 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
15099 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
15100
1fa53021
PE
15101 * sysdep.c: Make symbols static if they're not exported.
15102 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
15103 Now static.
15104 (sigprocmask_set, full_mask): Remove; unused.
15105 (wait_debugging): Mark as visible.
15106 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
15107 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
15108
d4b43b22
PE
15109 * syntax.c (syntax_temp): Define only if !__GNUC__.
15110
b7c513d0
PE
15111 * sound.c (current_sound_device, current_sound): Now static.
15112
989b29ad
PE
15113 * search.c (searchbufs, searchbuf_head): Now static.
15114
13a55a78
PE
15115 * scroll.c (scroll_cost): Remove; unused.
15116 * dispextern.h (scroll_cost): Remove decl.
15117
de68a1fc
PE
15118 * region-cache.h (pp_cache): Mark as externally visible.
15119
40ccffa6
PE
15120 * process.c: Make symbols static if they're not exported.
15121 (process_tick, update_tick, create_process, chan_process):
15122 (Vprocess_alist, proc_buffered_char, datagram_access):
15123 (fd_callback_data, send_process_frame, process_sent_to): Now static.
15124 (deactivate_process): Mark defn as static, as well as decl.
15125 * lisp.h (create_process): Remove decl.
15126 * process.h (chan_process, Vprocess_alist): Remove decls.
15127
ad64fc97
PE
15128 * print.c: Make symbols static if they're not exported.
15129 (print_depth, new_backquote_output, being_printed, print_buffer):
15130 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
15131 (print_interval, print_number_index, initial_stderr_stream):
15132 Now static.
15133 * lisp.h (Fprinc): Remove decl.
15134 (debug_output_compilation_hack): Mark as externally visible.
15135
adddb265
PE
15136 * sysdep.c (croak): Move decl from here to syssignal.h.
15137 * syssignal.h (croak): Put it here, so the API can be checked when
15138 'croak' is called from dissociate_if_controlling_tty.
15139
1717ede2
PE
15140 * minibuf.c: Make symbols static if they're not exported.
15141 (minibuf_save_list, choose_minibuf_frame): Now static.
15142 * lisp.h (choose_minibuf_frame): Remove decl.
15143
fa5fb2bc
PE
15144 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
15145
1e3890d1
PE
15146 * lread.c: Make symbols static if they're not exported.
15147 (read_objects, initial_obarray, oblookup_last_bucket_number):
15148 Now static.
15149 (make_symbol): Remove; unused.
15150 * lisp.h (initial_obarray, make_symbol): Remove decls.
15151
8a1414fa
PE
15152 * keyboard.c: Make symbols static if they're not exported.
15153 (single_kboard, recent_keys_index, total_keys, recent_keys):
15154 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
15155 (this_single_command_key_start, echoing, last_auto_save):
15156 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
15157 (command_loop, echo_now, keyboard_init_hook, help_char_p):
15158 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
15159 (Vlispy_mouse_stem, double_click_count):
15160 Now static.
15161 (force_auto_save_soon): Define only if SIGDANGER.
15162 (ignore_mouse_drag_p): Now static if
15163 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
15164 (print_help): Remove; unused.
15165 (stop_character, last_timer_event): Mark as externally visible.
15166 * keyboard.h (ignore_mouse_drag_p): Declare only if
15167 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
15168 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
15169 * lisp.h (echoing): Remove decl.
15170 (force_auto_save_soon): Declare only if SIGDANGER.
15171 * xdisp.c (redisplay_window): Simplify code, to make it more
15172 obvious that ignore_mouse_drag_p is not accessed if !defined
15173 USE_GTK && !defined HAVE_NS.
15174
93ea6e8f
PE
15175 * intervals.c: Make symbols static if they're not exported.
15176 (merge_properties_sticky, merge_interval_right, delete_interval):
15177 Now static.
15178 * intervals.h (merge_interval_right, delete_interval): Remove decls.
15179
77382fcc
PE
15180 * insdel.c: Make symbols static if they're not exported.
15181 However, leave prepare_to_modify_buffer alone. It's never
15182 called from outside this function, but that appears to be a bug.
15183 (combine_after_change_list, combine_after_change_buffer):
4889fc82 15184 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
15185 (adjust_after_replace_noundo): Remove; unused.
15186 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 15187 (signal_before_change): Remove decls.
77382fcc 15188
9306c32e
PE
15189 * indent.c (val_compute_motion, val_vmotion): Now static.
15190
cd44d2eb
PE
15191 * image.c: Make symbols static if they're not exported.
15192 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
15193 if USE_GTK.
15194 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
15195 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
15196
ad9a7a06
PE
15197 * fringe.c (standard_bitmaps): Now static.
15198 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
15199
81626931
PE
15200 * frame.c: Make symbols static if they're not exported.
15201 (x_report_frame_params, make_terminal_frame): Now static.
15202 (get_frame_param): Now static, unless HAVE_NS.
15203 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
15204 (x_get_resource_string): Remove; not used.
15205 * frame.h (make_terminal_frame, x_report_frame_params):
15206 (x_get_resource_string); Remove decls.
15207 (x_fullscreen_adjust): Declare only if WINDOWSNT.
15208 * lisp.h (get_frame_param): Declare only if HAVE_NS.
15209
239f9db9
PE
15210 * font.c, fontset.c: Make symbols static if they're not exported.
15211 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
15212 (FACE_SUITABLE_FOR_CHAR_P): Use it.
15213 * font.c (font_close_object): Now static.
15214 * font.h (font_close_object): Remove.
15215 * fontset.c (FONTSET_OBJLIST): Remove.
15216 (free_realized_fontset) #if-0 the body, which does nothing.
15217 (face_suitable_for_char_p): #if-0, as it's never called.
15218 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
15219 * xfaces.c (face_at_string_position):
15220 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
15221 since 0 is always ASCII.
15222
dfcf3579
PE
15223 * fns.c (weak_hash_tables): Now static.
15224
5045092b
PE
15225 * fileio.c: Make symbols static if they're not exported.
15226 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
15227 (Vwrite_region_annotation_buffers): Now static.
15228
57a96f5c
PE
15229 * eval.c: Make symbols static if they're not exported.
15230 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
15231 * lisp.h (backtrace_list): Remove decl.
15232
35f08c38
PE
15233 * emacs.c: Make symbols static if they're not exported.
15234 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
15235 (fatal_error_code, fatal_error_signal_hook, standard_args):
15236 Now static.
15237 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
15238 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
15239 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
15240 * lisp.h (fatal_error_signal_hook): Remove decl.
15241 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
15242
f44bd759
PE
15243 * editfns.c: Move a (normally-unused) function to its only use.
15244 * editfns.c, lisp.h (get_operating_system_release): Remove.
15245 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
15246 worth the hassle of breaking this out.
15247
b532497d
PE
15248 * xterm.c: Make symbols static if they're not exported.
15249 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
15250 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
15251 (x_destroy_window, x_delete_display):
15252 Now static.
15253 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
15254 (x_mouse_leave): Remove; unused.
15255 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
15256 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
15257 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
15258 Remove decls.
15259 (x_mouse_leave): Declare only if WINDOWSNT.
15260 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
15261 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
15262 USE_X_TOOLKIT.
15263
1675728f
PE
15264 * ftxfont.c: Make symbols static if they're not exported.
15265 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
15266 HAVE_FREETYPE.
15267 * font.h (ftxfont_driver): Likewise.
15268
e4cebfca
PE
15269 * xfns.c: Make symbols static if they're not exported.
15270 (x_last_font_name, x_display_info_for_name):
15271 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
15272 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
15273 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
15274 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
15275 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
15276 (last_show_tip_args): Now static.
15277 (xic_defaut_fontset, xic_create_fontsetname): Define only if
15278 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
15279 (x_screen_planes): Remove; unused.
15280 * dispextern.h (x_screen_planes): Remove decl.
15281
5bf46f05
PE
15282 * dispnew.c: Make symbols static if they're not exported.
15283 * dispextern.h (redraw_garbaged_frames, scrolling):
15284 (increment_row_positions): Remove.
15285 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
15286 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
15287 Now static.
15288 (redraw_garbaged_frames): Remove; unused.
15289
435f4c28
PE
15290 * xfaces.c: Make symbols static if they're not exported.
15291 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
15292 Remove decls.
15293 * xterm.h (defined_color): Remove decls.
15294 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
15295 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
15296 (menu_face_changed_default, defined_color, free_realized_face):
15297 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
15298 (ascii_face_of_lisp_face): Remove; unused.
15299
8524aef3
PE
15300 * xdisp.c: Make symbols static if they're not exported.
15301 * dispextern.h (scratch_glyph_row, window_box_edges):
15302 (glyph_to_pixel_coords, set_cursor_from_row):
15303 (get_next_display_element, set_iterator_to_next):
15304 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
15305 (show_mouse_face): Remove decls
15306 * frame.h (message_buf_print): Likewise.
15307 * lisp.h (pop_message, set_message, check_point_in_composition):
15308 Likewise.
15309 * xterm.h (set_vertical_scroll_bar): Likewise.
15310 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
15311 (message_buf_print, scratch_glyph_row, displayed_buffer):
15312 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
15313 (get_next_display_element, show_mouse_face, window_box_edges):
15314 (frame_to_window_pixel_xy, check_point_in_composition):
15315 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
15316 (glyph_to_pixel_coords): Remove; unused.
15317
16390cd2
PE
15318 * dired.c (file_name_completion): Now static.
15319
15320 * dbusbind.c (xd_in_read_queued_messages): Now static.
15321
a25f4dfa
PE
15322 * lisp.h (circular_list_error, FOREACH): Remove; unused.
15323 * data.c (circular_list_error): Remove.
15324
14a9c8df
PE
15325 * commands.h (last_point_position, last_point_position_buffer):
15326 (last_point_position_window): Remove decls.
15327 * keyboard.c: Make these variables static.
15328
04f2d78b
CB
15329 * coding.h (coding, code_convert_region, encode_coding_gap):
15330 Remove decls.
74ab6df5
PE
15331 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
15332 (iso_code_class, detect_coding, code_convert_region): Now static.
15333 (encode_coding_gap): Remove; unused.
15334
38dfbee1
PE
15335 * chartab.c (chartab_chars, chartab_bits): Now static.
15336
a2cb4e63
PE
15337 * charset.h (charset_iso_8859_1): Remove decl.
15338 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
15339 Now static.
15340
127198fd
PE
15341 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
15342 * ccl.c (Vccl_program_table): Now static.
15343 (check_ccl_update): Remove; unused.
15344
d85b608f
PE
15345 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
15346 * category.h: ... from here.
15347 * category.c (check_category_table, set_category_set): Now static.
15348
31cd66f3
PE
15349 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
15350 * lisp.h: Remove these decls.
15351
c358e587
PE
15352 * buffer.c (buffer_count): Remove unused var.
15353
e78aecca
PE
15354 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
15355 so that it's not optimized away.
15356 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
15357 * dispextern.h (bidi_dump_cached_states): Remove, since it's
15358 exported only to the debugger.
15359
e192d7d3 15360 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 15361 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 15362
92470028
PE
15363 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
15364 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
15365 was inaccessible from Lisp.
15366 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
15367 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
15368
244ed907
PE
15369 alloc.c: Import and export fewer symbols, and remove unused items.
15370 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
15371 is defined.
15372 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
15373 it's not optimized away by whole-program optimization.
15374 (message_enable_multibyte, free_misc): Remove.
15375 (catchlist, handlerlist, mark_backtrace):
15376 Declare only if BYTE_MARK_STACK.
15377 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
15378 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
15379 (message_enable_multibyte): Remove decl.
15380 (free_misc, interval_free_list, float_block, float_block_index):
15381 (n_float_blocks, float_free_list, cons_block, cons_block_index):
15382 (cons_free_list, last_marked_index):
15383 Now static.
15384 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
15385 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
15386 (mark_backtrace): Define only if BYTE_MARK_STACK.
15387 * xdisp.c (message_enable_multibyte): Now static.
15388
61c2b50e 15389 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
15390 This makes it easier for human readers (and static analyzers)
15391 to see whether these variables are used from other modules.
15392 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
15393 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
15394 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
15395 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
15396 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
15397 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
15398 * xmenu.c, xselect.c:
15399 Declare Q* vars static if they are not used in other modules.
15400 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
15401 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
15402 Remove decls of unexported vars.
15403 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
15404
95c82688
PE
15405 * lisp.h (DEFINE_FUNC): Make sname 'static'.
15406
16a97296
PE
15407 Make Emacs functions such as Fatom 'static' by default.
15408 This makes it easier for human readers (and static analyzers)
15409 to see whether these functions can be called from other modules.
15410 DEFUN now defines a static function. To make the function external
15411 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
15412 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
15413 (Finit_image_library):
16a97296
PE
15414 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
15415 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
15416 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
15417 Remove decls, since these functions are now static.
15418 (Funintern, Fget_internal_run_time): New decls, since these functions
15419 were already external.
95c82688 15420
16a97296
PE
15421 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
15422 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
15423 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
15424 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
15425 * keyboard.c, keymap.c, lread.c:
15426 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
15427 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
15428 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
15429 Mark functions with DEFUE instead of DEFUN,
15430 if they are used in other modules.
15431 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
15432 decls for now-static functions.
15433 * buffer.h (Fdelete_overlay): Remove decl.
15434 * callproc.c (Fgetenv_internal): Mark as internal.
15435 * composite.c (Fremove_list_of_text_properties): Remove decl.
15436 (Fcomposition_get_gstring): New forward static decl.
15437 * composite.h (Fcomposite_get_gstring): Remove decl.
15438 * dired.c (Ffile_attributes): New forward static decl.
15439 * doc.c (Fdocumntation_property): New forward static decl.
15440 * eval.c (Ffetch_bytecode): New forward static decl.
15441 (Funintern): Remove extern decl; now in .h file where it belongs.
15442 * fileio.c (Fmake_symbolic_link): New forward static decl.
15443 * image.c (Finit_image_library): New forward static decl.
15444 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
15445 * intervals.h (Fprevious_property_change):
15446 (Fremove_list_of_text_properties): Remove decls.
15447 * keyboard.c (Fthis_command_keys): Remove decl.
15448 (Fcommand_execute): New forward static decl.
15449 * keymap.c (Flookup_key): New forward static decl.
15450 (Fcopy_keymap): Now static.
15451 * keymap.h (Flookup_key): Remove decl.
15452 * process.c (Fget_process): New forward static decl.
15453 (Fprocess_datagram_address): Mark as internal.
15454 * syntax.c (Fsyntax_table_p): New forward static decl.
15455 (skip_chars): Remove duplicate decl.
15456 * textprop.c (Fprevious_property_change): New forward static decl.
15457 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
15458 Now internal.
15459 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
15460 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
15461
785bbd42
PE
15462 * editfns.c (Fformat): Remove unreachable code.
15463
8b913b57
AS
154642011-04-14 Andreas Schwab <schwab@linux-m68k.org>
15465
15466 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
15467 change. (Bug#8496)
15468
a6744a35
EZ
154692011-04-13 Eli Zaretskii <eliz@gnu.org>
15470
15471 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
15472 when at ZV. (Bug#8487)
15473
e7974947
AS
154742011-04-12 Andreas Schwab <schwab@linux-m68k.org>
15475
baad03f0
AS
15476 * charset.c (Fclear_charset_maps): Use xfree instead of free.
15477 (Bug#8437)
15478 * keyboard.c (parse_tool_bar_item): Likewise.
15479 * sound.c (sound_cleanup, alsa_close): Likewise.
15480 * termcap.c (tgetent): Likewise.
15481 * xfns.c (x_default_font_parameter): Likewise.
15482 * xsettings.c (read_and_apply_settings): Likewise.
15483
e7974947
AS
15484 * alloc.c (overrun_check_malloc, overrun_check_realloc)
15485 (overrun_check_free): Protoize.
15486
28272684
PE
154872011-04-12 Paul Eggert <eggert@cs.ucla.edu>
15488
15489 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
15490 since callers should never pass a negative size.
15491 Change the signature to match that of plain 'read' and 'write'; see
15492 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
15493 * lisp.h: Update prototypes of emacs_write and emacs_read.
15494
11997c76
EZ
154952011-04-11 Eli Zaretskii <eliz@gnu.org>
15496
15497 * xdisp.c (redisplay_window): Don't try to determine the character
15498 position of the scroll margin if the window start point w->startp
e896f03c 15499 is outside the buffer's accessible region. (Bug#8468)
11997c76 15500
8a2cbd72
EZ
155012011-04-10 Eli Zaretskii <eliz@gnu.org>
15502
15503 Fix write-region and its subroutines for buffers > 2GB.
15504 * fileio.c (a_write, e_write): Modify declaration of arguments and
15505 local variables to support buffers larger than 2GB.
15506 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
15507
15508 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
15509 argument, local variables, and return value.
15510
15511 * lisp.h: Update prototypes of emacs_write and emacs_read.
15512
15513 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
15514
4073e537 155152011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 15516
1ebfdcb6
PE
15517 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
15518
b2ded58d
PE
15519 Fix more problems found by GCC 4.6.0's static checks.
15520
7d66342c
PE
15521 * xdisp.c (vmessage): Use a better test for character truncation.
15522
bbf47d44
PE
15523 * charset.c (load_charset_map): <, not <=, for optimization,
15524 and to avoid potential problems with integer overflow.
9248994d 15525 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 15526 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 15527 * editfns.c (Fformat): Likewise.
1e69125e 15528 * syntax.c (skip_chars): Likewise.
3befa583 15529
e3019616
PE
15530 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
15531 This also lets GCC 4.6.0 generate slightly better loop code.
15532
becfa255
PE
15533 * callint.c (Fcall_interactively): <, not <=, for optimization.
15534 (Fcall_interactively): Count the number of arguments produced,
15535 not the number of arguments given. This is simpler and lets GCC
15536 4.6.0 generate slightly better code.
15537
dae0cd48
PE
15538 * ftfont.c: Distingish more carefully between FcChar8 and char.
15539 The previous code passed unsigned char * to a functions like
15540 strlen and xstrcasecmp that expect char *, which does not
15541 conform to the C standard.
15542 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
15543 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
15544 char * when the C standard requires it.
15545
76032d70
PE
15546 * keyboard.c (read_char): Remove unused var.
15547
eb3f1cc8
PE
15548 * eval.c: Port to Windows vsnprintf (Bug#8435).
15549 Include <limits.h>.
15550 (SIZE_MAX): Define if the headers do not.
15551 (verror): Do not give up if vsnprintf returns a negative count.
15552 Instead, grow the buffer. This ports to Windows vsnprintf, which
15553 does not conform to C99. Problem reported by Eli Zaretskii.
15554 Also, simplify the allocation scheme, by avoiding the need for
15555 calling realloc, and removing the ALLOCATED variable.
15556
70476b54
PE
15557 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
15558
12020a9e
PE
15559 Remove invocations of doprnt, as Emacs now uses vsnprintf.
15560 But keep the doprint source code for now, as we might revamp it
15561 and use it again (Bug#8435).
ea6c7ae6
PE
15562 * lisp.h (doprnt): Remove.
15563 * Makefile.in (base_obj): Remove doprnt.o.
15564 * deps.mk (doprnt.o): Remove.
15565
5fdb398c
PE
15566 error: Print 32- and 64-bit integers portably (Bug#8435).
15567 Without this change, on typical 64-bit hosts error ("...%d...", N)
15568 was used to print both 32- and 64-bit integers N, which relied on
15569 undefined behavior.
61bdb816 15570 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
15571 * lisp.h (error, verror): Mark as printf-like functions.
15572 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
15573 Report overflow in size calculations when allocating printf buffer.
15574 Do not truncate output string at its first null byte.
15575 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
15576 Truncate the output at a character boundary, since vsnprintf does not
15577 do that.
15578 * charset.c (check_iso_charset_parameter): Convert internal
15579 character to string before calling 'error', since %c now has the
15580 printf meaning.
15581 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
15582 overflow when computing char to be passed to 'error'. Do not
15583 pass Lisp_Object to 'error'; pass the integer instead.
15584 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
15585 formatted with plain %d.
15586
b189fa66
PE
15587 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
15588
bff87ef0
PE
15589 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
15590
7e2cac20
PE
15591 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
15592
ce4d90b5
PE
15593 * xterm.c (x_catch_errors): Remove duplicate declaration.
15594
266c9547
PE
15595 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
15596
79c49ad2
PE
15597 * xdisp.c, lisp.h (message_nolog): Remove; unused.
15598
368f4090
JM
155992011-04-10 Jim Meyering <meyering@redhat.com>
15600
15601 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
15602 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
15603 return ssize_t not "int", and use size_t as the buffer length.
15604 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
15605 * gnutls.h: Update declarations.
15606 * process.c (read_process_output): Use ssize_t, to match.
15607 (send_process): Likewise.
15608
a32d4040
CY
156092011-04-09 Chong Yidong <cyd@stupidchicken.com>
15610
15611 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
15612
8546720e 156132011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 15614
04f2d78b
CB
15615 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
15616 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 15617
8546720e
GM
15618 * xterm.c (handle_one_xevent):
15619 * xmenu.c (create_and_show_popup_menu):
15620 * xselect.c (x_decline_selection_request)
15621 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 15622
0a2f5c1a 156232011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
15624
15625 Fix some uses of `int' instead of EMACS_INT.
15626 * search.c (string_match_1, fast_string_match)
15627 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
15628 (scan_buffer, find_next_newline_no_quit)
15629 (find_before_next_newline, search_command, Freplace_match)
15630 (Fmatch_data): Make some `int' variables be EMACS_INT.
15631
15632 * xdisp.c (display_count_lines): 3rd argument and return value now
15633 EMACS_INT. All callers changed.
15634 (pint2hrstr): Last argument is now EMACS_INT.
15635
15636 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
15637 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
15638 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
15639 (decode_coding_utf_16, decode_coding_emacs_mule)
15640 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
15641 (decode_coding_ccl, decode_coding_charset)
15642 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
15643 (decode_coding_iso_2022, decode_coding_emacs_mule)
15644 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
15645 <char_offset, last_offset>: Declare EMACS_INT.
15646 (encode_coding_utf_8, encode_coding_utf_16)
15647 (encode_coding_emacs_mule, encode_invocation_designation)
15648 (encode_designation_at_bol, encode_coding_iso_2022)
15649 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
15650 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
15651 Declare EMACS_INT.
15652 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
15653 (encode_invocation_designation): Last argument P_NCHARS is now
15654 EMACS_INT.
15655 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
15656 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
15657
15658 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
15659 All users changed.
15660
15661 * ccl.c (Fccl_execute_on_string): Declare some variables
15662 EMACS_INT.
15663
8546720e 156642011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
15665
15666 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
15667
4e19a977
CS
156682011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
15669
15670 * process.c (Fformat_network_address): Doc fix.
15671
87302331
R
156722011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
15673
ee7683eb 15674 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 15675
cbb59342
CY
156762011-04-08 Chong Yidong <cyd@stupidchicken.com>
15677
15678 * keyboard.c (read_char): Call Lisp function help-form-show,
15679 instead of using internal_with_output_to_temp_buffer.
15680 (Qhelp_form_show): New var.
e0d38eeb 15681 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
15682
15683 * print.c (internal_with_output_to_temp_buffer): Function deleted.
15684
15685 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
15686
e67a13ab
CY
156872011-04-06 Chong Yidong <cyd@stupidchicken.com>
15688
04f2d78b
CB
15689 * process.c (Flist_processes): Remove to Lisp.
15690 (list_processes_1): Delete.
e67a13ab 15691
973f782d
EZ
156922011-04-06 Eli Zaretskii <eliz@gnu.org>
15693
7c106b1e
EZ
15694 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
15695
973f782d
EZ
15696 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
15697
41cf7d1a 156982011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 15699
ca23cc88
PE
15700 Fix more problems found by GCC 4.6.0's static checks.
15701
f390e2d5
PE
15702 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
15703
42eea0d0
PE
15704 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
15705
b69769da 15706 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 15707
f9541e84
PE
15708 * xdisp.c (vmessage): Mark as a printf-like function.
15709
13841b55
PE
15710 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
15711
c136c10f
PE
15712 * sound.c (sound_warning): Don't crash if arg contains a printf format.
15713
5e2d4a30
PE
15714 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
15715 printf-like functions.
15716 (tiff_load): Add casts to remove these marks before passing them
15717 to system-supplied API.
15718
583f48b9
PE
15719 * eval.c (Fsignal): Remove excess argument to 'fatal'.
15720
b25d760e
PE
15721 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
15722 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
15723 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
15724 directly, rather than having caller test rule sign. This avoids
15725 some unnecessary tests.
15726 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
15727 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
15728 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 15729
bc7b6697 15730 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 15731 (xfont_open): Avoid unnecessary tests.
bc7b6697 15732
27ccc379
PE
15733 * composite.c (composition_gstring_put_cache): Use unsigned integer.
15734
dcd5c89a
PE
15735 * composite.h, composite.c (composition_gstring_put_cache):
15736 Use EMACS_INT, not int, for length.
15737
b13a45c6
PE
15738 * composite.h (COMPOSITION_DECODE_REFS): New macro,
15739 breaking out part of COMPOSITION_DECODE_RULE.
15740 (COMPOSITION_DECODE_RULE): Use it.
15741 * composite.c (get_composition_id): Remove unused local vars,
15742 by using the new macro.
15743
1e792e4d
PE
15744 * textprop.c (set_text_properties_1): Change while to do-while,
15745 since the condition is always true at first.
15746
dc6c6455 15747 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
15748 (interval_deletion_adjustment): Return unsigned value.
15749 All uses changed.
dc6c6455 15750
aba7731a
PE
15751 * process.c (list_processes_1, create_pty, read_process_output):
15752 (exec_sentinel): Remove vars that were set but not used.
afd4052b 15753 (create_pty): Remove unnecessary "volatile"s.
bc57d757 15754 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 15755 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 15756 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 15757
fdfc4bf3
PE
15758 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
15759
fca8fe46 15760 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 15761 (update_syntax_table): Use unsigned instead of int.
fca8fe46 15762
06a0259a 15763 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 15764 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 15765 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 15766
e7b9e80f
PE
15767 * print.c (print_error_message): Avoid int overflow.
15768
56201685
PE
15769 * font.c (font_list_entities): Redo for clarity,
15770 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
15771
78834453 15772 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 15773 (font_score): Avoid potential overflow in diff calculation.
78834453 15774
0bc0b309 15775 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 15776 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 15777
e610eaca
PE
15778 * eval.c (funcall_lambda): Rename local to avoid shadowing.
15779
b895abce
PE
15780 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
15781 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
15782 can always succeed if overflow has undefined behavior.
15783
1f1d9321 15784 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 15785 (wordify): Omit three unnecessary tests.
1f1d9321 15786
c59478bc
PE
15787 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
15788 All callers changed. This avoids the need for an unused var.
15789
79b73827
PE
15790 * casefiddle.c (casify_region): Remove var that is set but not used.
15791
a4db5dfe
PE
15792 * dired.c (file_name_completion): Remove var that is set but not used.
15793
43aae36e
PE
15794 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
15795
2a47c44d 15796 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 15797 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 15798
a37c69bf
PE
15799 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
15800 Check for integer overflow on size calculations.
15801
328ab8e7
PE
15802 * buffer.c (Fprevious_overlay_change): Remove var that is set
15803 but not used.
15804
e5a2a5cb
PE
15805 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
15806 Remove vars that are set but not used.
8d84a6eb 15807 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 15808 (timer_check_2): Mark vars as initialized.
e5a2a5cb 15809
a60e5f68
PE
15810 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
15811
f661cb61 15812 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 15813 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 15814
f0397f5a
PE
15815 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
15816 that are set but not used.
15817
8664db06 15818 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 15819 if XCreateBitmapFromData fails (Bug#8410).
8664db06 15820
6abdaa4a
PE
15821 * xselect.c (x_get_local_selection, x_handle_property_notify):
15822 Remove vars that are set but not used.
15823
0ce7538d 15824 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 15825 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 15826
9ae848fc
PE
15827 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
15828 Remove var that is set but not used.
0b918413
PE
15829 (scroll_bar_windows_size): Now size_t, not int.
15830 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
15831 Check for overflow.
9ae848fc 15832
a5a62657
PE
15833 * xfaces.c (realize_named_face): Remove vars that are set but not used.
15834 (map_tty_color) [!defined MSDOS]: Likewise.
15835
5c5cdd39
PE
15836 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
15837
66ebf983
PE
15838 * coding.c: Remove vars that are set but not used.
15839 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
15840 All callers changed.
15841 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
15842 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
15843 (decode_coding_charset): Remove vars that are set but not used.
15844
1be4d761
PE
15845 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
15846 that is set but not used.
15847
47553fa8
PE
15848 * print.c (print_object): Remove var that is set but not used.
15849
1f7196bf 15850 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
15851 The gnulib version avoids calling malloc in the usual case,
15852 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
15853 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
15854 * filelock.c (current_lock_owner): Likewise.
15855 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
15856 * sysdep.c: Include allocator.h, careadlinkat.h.
15857 (emacs_no_realloc_allocator): New static constant.
15858 (emacs_readlink): New function.
fdb61804
PE
15859 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
15860 ../lib/careadlinkat.h.
d1fdcab7 15861
f84c17c7
SM
158622011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
15863
15864 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
15865 first non-nil return value).
15866
ef3862ad
JD
158672011-04-03 Jan Djärv <jan.h.d@swipnet.se>
15868
15869 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
15870 if not defined (Bug#8403).
15871
376a7006
JB
158722011-04-02 Juanma Barranquero <lekktu@gmail.com>
15873
15874 * xdisp.c (display_count_lines): Remove parameter `start',
15875 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15876 (get_char_face_and_encoding): Remove parameter `multibyte_p',
15877 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15878 (fill_stretch_glyph_string): Remove parameters `row' and `area',
15879 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
15880 and thereabouts. All callers changed.
15881 (get_per_char_metric): Remove parameter `f', unused since
15882 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15883
6ca3801d
JM
158842011-04-02 Jim Meyering <meyering@redhat.com>
15885
15886 do not dereference NULL upon failed strdup
15887 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
15888 (ns_get_family): Likewise.
15889
d8e2b5ba
JB
158902011-04-02 Juanma Barranquero <lekktu@gmail.com>
15891
15892 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
15893
8c74fcbd
JD
158942011-04-02 Jan Djärv <jan.h.d@swipnet.se>
15895
15896 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
15897 later (Bug#8403).
15898
7200d79c
SM
158992011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
15900
03408648 15901 Add lexical binding.
7200d79c 15902
03408648
SM
15903 * window.c (Ftemp_output_buffer_show): New fun.
15904 (Fsave_window_excursion):
15905 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
15906
15907 * lread.c (lisp_file_lexically_bound_p): New function.
15908 (Fload): Bind Qlexical_binding.
15909 (readevalloop): Remove `evalfun' arg.
15910 Bind Qinternal_interpreter_environment.
15911 (Feval_buffer): Bind Qlexical_binding.
15912 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
15913 Mark as dynamic.
15914 (syms_of_lread): Declare `lexical-binding'.
15915
15916 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
15917
15918 * keyboard.c (eval_dyn): New fun.
15919 (menu_item_eval_property): Use it.
ca105506
SM
15920
15921 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 15922
03408648
SM
15923 * fns.c (concat, mapcar1): Accept byte-code-functions.
15924
15925 * eval.c (Fsetq): Handle lexical vars.
15926 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
15927 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
15928 (FletX, Flet): Obey lexical binding.
15929 (Fcommandp): Handle closures.
15930 (Feval): New `lexical' arg.
15931 (eval_sub): New function extracted from Feval. Use it almost
15932 everywhere where Feval was used. Look up vars in lexical env.
15933 Handle closures.
15934 (Ffunctionp): Move from subr.el.
15935 (Ffuncall): Handle closures.
15936 (apply_lambda): Remove `eval_flags'.
15937 (funcall_lambda): Handle closures and new byte-code-functions.
15938 (Fspecial_variable_p): New function.
15939 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
15940 but without exporting it to Lisp.
23aba0ea 15941
23aba0ea 15942 * doc.c (Fdocumentation, store_function_docstring):
03408648 15943 * data.c (Finteractive_form): Handle closures.
23aba0ea 15944
03408648
SM
15945 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
15946 interactive spec.
ba83908c 15947
04f2d78b
CB
15948 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
15949 New byte-codes.
03408648
SM
15950 (exec_byte_code): New function extracted from Fbyte_code to handle new
15951 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 15952
03408648 15953 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 15954
03408648 15955 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 15956
e2abce01
JB
159572011-03-31 Juanma Barranquero <lekktu@gmail.com>
15958
15959 * xdisp.c (redisplay_internal): Fix prototype.
15960
63696a73 159612011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 15962
63696a73 15963 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
15964 (try_scrolling): Use it when setting scroll_limit.
15965 Limit scrolling to 100 screen lines.
63696a73
EZ
15966 (redisplay_window): Even when falling back on "recentering",
15967 position point in the window according to scroll-conservatively,
15968 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
15969
15970 (try_scrolling): When point is above the window, allow searching
15971 as far as scroll_max, or one screenful, to compute vertical
15972 distance from PT to the scroll margin position. This prevents
15973 try_scrolling from unnecessarily failing when
15974 scroll-conservatively is set to a value slightly larger than the
15975 window height. Clean up the case of PT below the margin at bottom
15976 of window: scroll_max can no longer be INT_MAX. When aggressive
15977 scrolling is in use, don't let point enter the opposite scroll
15978 margin as result of the scroll.
15979 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
15980 threshold of 100 lines for never-recentering scrolling.
15981
e4cc2dfc
JB
159822011-03-31 Juanma Barranquero <lekktu@gmail.com>
15983
15984 * dispextern.h (move_it_by_lines):
15985 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
15986 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
15987 (message_log_check_duplicate): Remove parameters `prev_bol' and
15988 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15989 (redisplay_internal): Remove parameter `preserve_echo_area',
15990 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
15991
15992 * indent.c (Fvertical_motion):
15993 * window.c (window_scroll_pixel_based, Frecenter):
15994 Don't pass `need_y_p' to `move_it_by_lines'.
15995
1c470562
SM
159962011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
15997
44f230aa
SM
15998 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
15999 steal a few bits to be more compact.
16000 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
16001 Remove unneeded casts.
16002
1c470562
SM
16003 * bytecode.c (Fbyte_code): CAR and CDR can GC.
16004
888adce9
ZK
160052011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
16006
16007 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
16008 binding" message (bug#7967).
16009
f838ed7b
PE
160102011-03-30 Paul Eggert <eggert@cs.ucla.edu>
16011
77861b95
PE
16012 Fix more problems found by GCC 4.6.0's static checks.
16013
de6dbc14
PE
16014 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
16015 Remove unused local var.
16016
f838ed7b
PE
16017 * editfns.c (Fmessage_box): Remove unused local var.
16018
792c7b2b
PE
16019 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
16020 (note_mode_line_or_margin_highlight, note_mouse_highlight):
16021 Omit unused local vars.
c499e557 16022 * window.c (shrink_windows): Omit unused local var.
b01a1c29 16023 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
16024 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
16025 Omit unused local var.
16026
ba0165e1
PE
16027 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
16028 Don't assume string length fits in int.
32ad8845 16029 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 16030 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 16031
3c59b4c9
PE
16032 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
16033 instead of alloca (Bug#8344).
16034
a3eed478 16035 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 16036 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 16037
eb4d412d
PE
16038 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
16039
1658b401
PE
16040 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
16041 concerns.
16042
16043 * term.c (produce_glyphless_glyph): Remove unnecessary test.
16044
16045 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 16046
9a2c6e05
PE
16047 * keyboard.c (syms_of_keyboard): Use the same style as later
16048 in this function when indexing through an array. This also
16049 works around GCC bug 48267.
16050
03d0a109
PE
16051 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
16052
44f730c8
PE
16053 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
16054
fe75f926
PE
16055 * chartab.c (sub_char_table_ref_and_range): Redo for slight
16056 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
16057
ffa8c828
PE
16058 * keyboard.c, keyboard.h (num_input_events): Now size_t.
16059 This avoids undefined behavior on integer overflow, and is a bit
16060 more convenient anyway since it is compared to a size_t variable.
16061
c5101a77
PE
16062 Variadic C functions now count arguments with size_t, not int.
16063 This avoids an unnecessary limitation on 64-bit machines, which
16064 caused (substring ...) to crash on large vectors (Bug#8344).
16065 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
16066 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 16067 All variadic functions and their callers changed accordingly.
c5101a77
PE
16068 (struct gcpro.nvars): Now size_t, not int. All uses changed.
16069 * data.c (arith_driver, float_arith_driver): Likewise.
16070 * editfns.c (general_insert_function): Likewise.
16071 * eval.c (struct backtrace.nargs, interactive_p)
16072 (internal_condition_case_n, run_hook_with_args, apply_lambda)
16073 (funcall_lambda, mark_backtrace): Likewise.
16074 * fns.c (concat): Likewise.
16075 * frame.c (x_set_frame_parameters): Likewise.
16076 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
16077 0 if not found, not -1. All callers changed.
16078
dd3f25f7
PE
16079 * alloc.c (garbage_collect): Don't assume stack size fits in int.
16080 (stack_copy_size): Now size_t, not int.
16081 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
16082
461c2ab9
JB
160832011-03-28 Juanma Barranquero <lekktu@gmail.com>
16084
16085 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
16086 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16087 All callers changed.
16088
16089 * lisp.h (multibyte_char_to_unibyte):
16090 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
16091 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16092 * character.h (CHAR_TO_BYTE8):
16093 * cmds.c (internal_self_insert):
16094 * editfns.c (general_insert_function):
16095 * keymap.c (push_key_description):
16096 * search.c (Freplace_match):
16097 * xdisp.c (message_dolog, set_message_1): All callers changed.
16098
f6d62986
SM
160992011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
16100
16101 * keyboard.c (safe_run_hook_funcall): New function.
16102 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
16103 don't set the hook to nil, but remove the offending function instead.
16104 (Qcommand_hook_internal): Remove, unused.
16105 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
16106 Vcommand_hook_internal.
16107
16108 * eval.c (enum run_hooks_condition): Remove.
16109 (funcall_nil, funcall_not): New functions.
16110 (run_hook_with_args): Call each function through a `funcall' argument.
16111 Remove `cond' argument, now redundant.
16112 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
16113 (Frun_hook_with_args_until_failure): Adjust accordingly.
16114 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
16115
1db5b1ad
JB
161162011-03-28 Juanma Barranquero <lekktu@gmail.com>
16117
16118 * dispextern.h (string_buffer_position): Remove declaration.
16119
16120 * print.c (strout): Remove parameter `multibyte', unused since
16121 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
16122
16123 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
16124 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
16125 All callers changed.
16126
16127 * w32.c (_wsa_errlist): Use braces for struct initializers.
16128
16129 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
16130 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
16131 All callers changed.
16132 (string_buffer_position): Likewise. Also, make static (it's never
16133 used outside xdisp.c).
16134 (cursor_row_p): Remove parameter `w', unused since
16135 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
16136 (decode_mode_spec): Remove parameter `precision', introduced during
16137 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
16138 All callers changed.
16139
5ffb62aa
JD
161402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16141
16142 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
16143
461c2ab9 161442011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
16145
16146 * nsterm.m (ns_menu_bar_is_hidden): New variable.
16147 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
16148 (ns_update_auto_hide_menu_bar): New functions.
16149 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
16150 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
16151 ns_constrain_all_frames.
16152 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
16153 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
16154
5c380ffb
JD
161552011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16156
16157 * nsmenu.m (runDialogAt): Remove argument to timer_check.
16158
9af30bdf
GM
161592011-03-27 Glenn Morris <rgm@gnu.org>
16160
16161 * syssignal.h: Replace RETSIGTYPE with void.
16162 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
16163 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
16164 Replace SIGTYPE with void everywhere.
16165 * s/usg5-4-common.h (SIGTYPE): Remove definition.
16166 * s/template.h (SIGTYPE): Remove commented out definition.
16167
e2abce01
JB
161682011-03-26 Eli Zaretskii <eliz@gnu.org>
16169
16170 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
16171 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
16172
f868cd8a
JB
161732011-03-26 Juanma Barranquero <lekktu@gmail.com>
16174
59eb0929
JB
16175 * w32.c (read_unc_volume): Use parameter `henum', instead of
16176 global variable `wget_enum_handle'.
16177
16178 * keymap.c (describe_vector): Remove parameters `indices' and
16179 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
16180 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
16181
f868cd8a
JB
16182 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
16183
16184 * keyboard.c (timer_check): Remove parameter `do_it_now',
16185 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
16186 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
16187 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
16188
16189 * keyboard.c (read_char):
16190 * w32menu.c (w32_menu_display_help):
16191 * xmenu.c (show_help_event, menu_help_callback):
16192 Adjust calls to `show_help_echo'.
16193
16194 * gtkutil.c (xg_maybe_add_timer):
16195 * keyboard.c (readable_events):
16196 * process.c (wait_reading_process_output):
16197 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
16198
16199 * insdel.c (adjust_markers_gap_motion):
16200 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
16201 (gap_left, gap_right): Don't call it.
16202
2ecf6fdb
CY
162032011-03-25 Chong Yidong <cyd@stupidchicken.com>
16204
16205 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
16206 incurred during fontification.
16207
6b1f9ba4
JB
162082011-03-25 Juanma Barranquero <lekktu@gmail.com>
16209
16210 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
16211 (DEFVAR_PER_BUFFER): Don't pass it.
16212
16213 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
16214 (scrolling_window): Don't pass it.
16215
0f4a96b5
JB
162162011-03-25 Juanma Barranquero <lekktu@gmail.com>
16217
16218 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
16219
16220 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
16221 and `suffix'.
16222 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
16223 of variables specific to SELinux and computation of `encoded_absname'.
16224
16225 * image.c (XPutPixel): Remove unused variable `height'.
16226
16227 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
16228
16229 * unexw32.c (get_section_info): Remove unused variable `section'.
16230
16231 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
16232 (system_process_attributes): Remove unused variable `sess'.
16233 (sys_read): Remove unused variable `err'.
16234
16235 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
16236 (w32_wnd_proc): Remove unused variable `isdead'.
16237 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
16238 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
16239 (x_create_tip_frame): Remove unused variable `tem'.
16240
16241 * w32inevt.c (w32_console_read_socket):
16242 Remove unused variable `no_events'.
16243
16244 * w32term.c (x_draw_composite_glyph_string_foreground):
16245 Remove unused variable `width'.
16246
1149507c
JB
162472011-03-24 Juanma Barranquero <lekktu@gmail.com>
16248
16249 * w32term.c (x_set_glyph_string_clipping):
16250 Don't pass uninitialized region to CombineRgn.
16251
9c88f339
JB
162522011-03-23 Juanma Barranquero <lekktu@gmail.com>
16253
16254 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
16255 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
16256 (Fx_close_connection): Remove unused variable `i'.
16257
16258 * w32font.c (w32font_draw): Return number of glyphs.
16259 (w32font_open_internal): Remove unused variable `i'.
16260 (w32font_driver): Add missing initializer.
16261
16262 * w32menu.c (utf8to16): Remove unused variable `utf16'.
16263 (fill_in_menu): Remove unused variable `items_added'.
16264
16265 * w32term.c (last_mouse_press_frame): Remove static global variable.
16266 (w32_clip_to_row): Remove unused variable `f'.
16267 (x_delete_terminal): Remove unused variable `i'.
16268
16269 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
16270 (NOTHING): Remove unused static global variable.
16271 (uniscribe_check_otf): Remove unused variable `table'.
16272 (uniscribe_font_driver): Add missing initializers.
16273
dee091a3
JD
162742011-03-23 Julien Danjou <julien@danjou.info>
16275
16276 * term.c (Fsuspend_tty, Fresume_tty):
16277 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
16278 * window.c (temp_output_buffer_show):
16279 * insdel.c (signal_before_change):
16280 * frame.c (Fhandle_switch_frame):
16281 * fileio.c (Fdo_auto_save):
16282 * emacs.c (Fkill_emacs):
16283 * editfns.c (save_excursion_restore):
16284 * cmds.c (internal_self_insert):
16285 * callint.c (Fcall_interactively):
16286 * buffer.c (Fkill_all_local_variables):
16287 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
16288 Use Frun_hooks.
0f4a96b5 16289 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 16290 unconditionally since it does the check itself.
dee091a3 16291
2c520ab5 162922011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 16293
c9c49752
PE
16294 Fix more problems found by GCC 4.5.2's static checks.
16295
8abc3f12
PE
16296 * coding.c (encode_coding_raw_text): Avoid unnecessary test
16297 the first time through the loop, since we know p0 < p1 then.
16298 This also avoids a gcc -Wstrict-overflow warning.
16299
a2d26660
PE
16300 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
16301 leading to a memory leak, possible in functions like
16302 load_charset_map_from_file that can allocate an unbounded number
b12ef411 16303 of objects (Bug#8318).
a2d26660 16304
916c72e9
PE
16305 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
16306 that could (at least in theory) be that large.
16307
19ab8a18
PE
16308 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
16309 This is less likely to overflow, and avoids undefined behavior if
16310 overflow does occur. All callers changed. Use strtoul to scan
16311 for the unsigned long integer.
b7cbbd6f
PE
16312 (pint2hrstr): Simplify and tune code slightly.
16313 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 16314
f0641eff
PE
16315 * scroll.c (do_scrolling): Work around GCC bug 48228.
16316 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
16317
7f650bb9
PE
16318 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
16319 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
16320 (validate_x_resource_name): Simplify count usage.
16321 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 16322
37dd57d1
PE
16323 * fileio.c (Fcopy_file): Report error if fchown or fchmod
16324 fail (Bug#8306).
81e56e61 16325
699979fc 16326 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 16327
401bf9b4
PE
16328 * process.c (Fmake_network_process): Use socklen_t, not int,
16329 where POSIX says socklen_t is required in portable programs.
16330 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 16331 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
16332 (Fmake_network_process, server_accept_connection):
16333 (wait_reading_process_output, read_process_output):
16334 Likewise.
16335
b93aacde
PE
16336 * process.c: Rename or move locals to avoid shadowing.
16337 (list_processes_1, Fmake_network_process):
16338 (read_process_output_error_handler, exec_sentinel_error_handler):
16339 Rename or move locals.
4dc343ee 16340 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 16341 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 16342 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 16343 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 16344 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 16345
af8a867c 16346 Make tparam.h and terminfo.c consistent.
44f230aa
SM
16347 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
16348 Include tparam.h instead, since it declares them.
af8a867c
PE
16349 * cm.h (PC): Remove extern decl; tparam.h now does this.
16350 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
16351 * terminfo.c: Include tparam.h, to check interfaces.
16352 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
16353 (tparam): Adjust signature to match interface in tparam.h;
16354 this removes some undefined behavior. Check that outstring and len
16355 are zero, which they always are with Emacs.
16356 * tparam.h (PC, BC, UP): New extern decls.
16357
0248044d 16358 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 16359 (xftfont_open): Rename locals to avoid shadowing.
0248044d 16360
8ff096c1 16361 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
16362 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
16363 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 16364 (ftfont_list): Remove unused local.
49eaafba
PE
16365 (get_adstyle_property, ftfont_pattern_entity):
16366 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
16367 Rename locals to avoid shadowing.
8ff096c1 16368
e2be39f6
PE
16369 * xfont.c (xfont_list_family): Mark var as initialized.
16370
c9735e30
PE
16371 * xml.c (make_dom): Now static.
16372
8f5201ae
PE
16373 * composite.c (composition_compute_stop_pos): Rename local to
16374 avoid shadowing.
b246f932
PE
16375 (composition_reseat_it): Remove unused locals.
16376 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 16377 (composition_update_it): Mark var as initialized.
11b61122
PE
16378 (find_automatic_composition): Mark vars as initialized,
16379 with a FIXME (Bug#8290).
8f5201ae 16380
760fbc2c
PE
16381 character.h: Rename locals to avoid shadowing.
16382 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
16383 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
16384 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
16385 (BUF_DEC_POS): Be more systematic about renaming local temporaries
16386 to avoid shadowing.
16387
ff08eb85
PE
16388 * textprop.c (property_change_between_p): Remove; unused.
16389
fc7bf025
PE
16390 * intervals.c (interval_start_pos): Now static.
16391
235d7abc
PE
16392 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
16393
44f230aa
SM
16394 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
16395 Rename locals to avoid shadowing.
3e7d6594 16396
50060332
PE
16397 * sound.c (wav_play, au_play, Fplay_sound_internal):
16398 Fix pointer signedness.
d01f234b 16399 (alsa_choose_format): Remove unused local var.
c83b8872
PE
16400 (wav_play): Initialize a variable to 0, to prevent undefined
16401 behavior (Bug#8278).
50060332 16402
c4fc4e30
PE
16403 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
16404
918436ed
PE
16405 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
16406
c939f91b
PE
16407 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
16408 clobbering (Bug#8298).
b9c7f648
PE
16409 * sysdep.c (sys_subshell): Likewise.
16410 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 16411
6bd8c144
PE
16412 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
16413 This should get cleaned up, so that child_setup has the
16414 same signature on all platforms.
16415
7710357c 16416 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 16417 (relocate_fd): Rename locals to avoid shadowing.
7710357c 16418
c59da222
CY
164192011-03-22 Chong Yidong <cyd@stupidchicken.com>
16420
16421 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
16422 not to be necessary, and produces flickering.
16423
66b87493
GM
164242011-03-20 Glenn Morris <rgm@gnu.org>
16425
16426 * config.in: Remove file.
16427
45b6f6d5
JB
164282011-03-20 Juanma Barranquero <lekktu@gmail.com>
16429
16430 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
16431 are now in src/globals.h.
16432 (syms_of_minibuf): Remove spurious & from previous change.
16433
cd394be1 164342011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
16435
16436 * minibuf.c (completing-read-function): New variable.
16437 (completing-read-default): Rename from completing-read.
16438 (completing-read): Call completing-read-function.
16439
b14e3e21
CY
164402011-03-19 Juanma Barranquero <lekktu@gmail.com>
16441
16442 * xfaces.c (Fx_load_color_file):
16443 Read color file from absolute filename (bug#8250).
16444
f2b726e6
JB
164452011-03-19 Juanma Barranquero <lekktu@gmail.com>
16446
16447 * makefile.w32-in: Update dependencies.
16448
09f6ff02
EZ
164492011-03-17 Eli Zaretskii <eliz@gnu.org>
16450
16451 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
16452
29a6015a
PE
164532011-03-17 Paul Eggert <eggert@cs.ucla.edu>
16454
a3a6c54e
PE
16455 Fix more problems found by GCC 4.5.2's static checks.
16456
b766f867
PE
16457 * process.c (make_serial_process_unwind, send_process_trap):
16458 (sigchld_handler): Now static.
16459
be02381c
PE
16460 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
16461 That way, the code declares only the vars that it needs.
16462 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
16463 * s/cygwin.h (PTY_ITERATION): Likewise.
16464 * s/darwin.h (PTY_ITERATION): Likewise.
16465 * s/gnu-linux.h (PTY_ITERATION): Likewise.
16466
57048744
PE
16467 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
16468 * process.c (allocate_pty): Don't declare stb unless it's needed.
16469
7914961c 16470 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
16471 (CONSTANTLIM): Remove; unused.
16472 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
16473 Define only if needed.
7914961c 16474
b3967b18
PE
16475 * unexelf.c (unexec): Name an expression,
16476 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
16477 Use a different way to cause a compilation error if anyone uses
16478 n rather than nn, a way that does not involve shadowing.
73366a00 16479 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 16480
29a6015a
PE
16481 * deps.mk (unexalpha.o): Remove; unused.
16482
43cfc33e 16483 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 16484 * unexec.h: New file.
ce701a33
PE
16485 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
16486 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
16487 Depend on unexec.h.
16488 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
16489 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
16490 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 16491 Change as necessary to match prototype in unexec.h.
ce701a33 16492
01f44d5a
PE
16493 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
16494 shadowing.
4f63c6bb 16495 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 16496
a6670b0b
PE
16497 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
16498 Rename locals to avoid shadowing.
16499
cef2010d 16500 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 16501 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 16502
d4d7173a
PE
16503 * print.c (Fredirect_debugging_output): Fix pointer signedess.
16504
f08b802a
PE
16505 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
16506 warning when compiling print.c.
16507
3ddb0639
PE
16508 * font.c (font_unparse_fcname): Abort in an "impossible" situation
16509 instead of using an uninitialized var.
5ad03b97 16510 (font_sort_entities): Mark var as initialized.
3ddb0639 16511
170a2692
PE
16512 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
16513
e663c700
PE
16514 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
16515 pointers to constants.
89bc529a 16516 (font_parse_fcname): Remove unused vars.
7b81e2d0 16517 (font_delete_unmatched): Now static.
ea838e10 16518 (font_get_spec): Remove; unused.
13a547c6
PE
16519 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
16520 (font_update_drivers, Ffont_get_glyphs, font_add_log):
16521 Rename or move locals to avoid shadowing.
e663c700 16522
2a80c887 16523 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 16524 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 16525
1384fa33 16526 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 16527 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 16528
8b2c52e9
PE
16529 * alloc.c (mark_backtrace): Move decl from here ...
16530 * lisp.h: ... to here, so that it can be checked.
16531
475545b5 16532 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 16533 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
16534 (lisp_indirect_variable): Name an expression,
16535 to avoid gcc -Wbad-function-cast warning.
1faed8ae 16536 (Fdefvar): Rename locals to avoid shadowing.
475545b5 16537
b1349114 16538 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 16539 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 16540 Use const pointer when appropriate.
b1349114 16541
a2928364
PE
16542 * lisp.h (get_system_name, get_operating_system_release):
16543 Move decls here, to check interfaces.
16544 * process.c (get_operating_system_release): Move decl to lisp.h.
16545 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
16546 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
16547 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
16548 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
16549 (Fformat_time_string, Fencode_time, Finsert_char):
16550 (Ftranslate_region_internal, Fformat):
16551 Rename or remove local vars to avoid shadowing.
9710023e 16552 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 16553
a415e694
PE
16554 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
16555 avoid shadowing.
16556
8ef4622d
PE
16557 * lisp.h (eassert): Check that the argument compiles, even if
16558 ENABLE_CHECKING is not defined.
16559
946f9a5b
PE
16560 * data.c (Findirect_variable): Name an expression, to avoid
16561 gcc -Wbad-function-cast warning.
112396d6 16562 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 16563 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
16564 (Fmake_variable_buffer_local, Fmake_local_variable):
16565 Mark variables as initialized.
52746918 16566 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 16567
e5aab7e7 16568 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
16569 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
16570 Rename locals to avoid shadowing.
dff45157
PE
16571 (mark_stack): Move local variables into the #ifdef region where
16572 they're used.
7bc26fdb
PE
16573 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
16574 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
16575 needed otherwise.
16576 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
16577 (GC_STRING_CHARS): Remove; not used.
d40d4be1 16578 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 16579
e5aab7e7
PE
16580 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
16581 avoids undefined behavior in theory.
16582
4da60324
PE
16583 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
16584
88043301
PE
16585 Use functions, not macros, for up- and down-casing (Bug#8254).
16586 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
16587 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
16588 to use the following functions instead of these macros.
16589 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
16590 EMACS_INT, since callers assume the returned value fits in int.
16591 (upcase1): Likewise, for UPCASE_TABLE.
16592 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 16593 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 16594 the race-condition problem in the old DOWNCASE.
88043301 16595
19ed5445
PE
16596 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
16597 Rename locals to avoid shadowing.
16598 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
16599 (regex_compile, re_search_2, re_match_2_internal):
16600 Remove unused local vars.
952db0d7
PE
16601 (FREE_VAR): Rewrite so as not to use empty "else",
16602 which gcc can warn about.
da053e48 16603 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
16604 (RETALLOC_IF): Define only if needed.
16605 (WORDCHAR_P): Likewise. This one is never needed, but is used
16606 only in a comment talking about a compiler bug, so put inside
16607 the #if 0 of that comment.
16608 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
16609 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
16610 Remove; unused.
19ed5445 16611
1f3561e4 16612 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
16613 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
16614 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 16615
ded6f8f7
PE
16616 * search.c (simple_search): Remove unused var.
16617
dbd37a95
PE
16618 * dired.c (compile_pattern): Move decl from here ...
16619 * lisp.h: ... to here, so that it can be checked.
16620 (struct re_registers): New forward decl.
16621
7e47afad
PE
16622 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
16623
85f24f61
PE
16624 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
16625 All uses changed.
16626 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
16627 Rename locals to avoid shadowing.
5671df8f 16628 (Fvertical_motion): Mark locals as initialized.
85f24f61 16629
181aa2be 16630 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 16631 (casify_region): Mark local as initialized.
181aa2be 16632
930d429c
PE
16633 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
16634
7082eac6
PE
16635 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
16636 New macros, so that the caller can use some names other than
16637 gcpro1, gcpro2, etc.
16638 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
16639 of the new macros.
16640 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
16641 argument, for consistency with GCPRO2_VAR, etc: it is now the
16642 prefix of the variable, not the variable itself. All uses
16643 changed.
38b2c076
PE
16644 * dired.c (directory_files_internal, file_name_completion):
16645 Rename locals to avoid shadowing.
16646
15206ed9
PE
16647 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
16648 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
16649 dired.c's scmp function, had undefined behavior.
16650 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
16651 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
16652 * buffer.h: ... to here, because these macros use current_buffer,
16653 and the new implementation with inline functions needs to have
16654 current_buffer in scope now, rather than later when the macros
16655 are used.
16656 (downcase, upcase1): New static inline functions.
16657 (DOWNCASE, UPCASE1): Reimplement using these functions.
16658 This avoids undefined behavior in expressions like
16659 DOWNCASE (x) == DOWNCASE (y), which previously suffered
16660 from race conditions in accessing the global variables
16661 case_temp1 and case_temp2.
16662 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
16663 * lisp.h (case_temp1, case_temp2): Remove their decls.
16664 * character.h (ASCII_CHAR_P): Move from here ...
16665 * lisp.h: ... to here, so that the inline functions mentioned
16666 above can use them.
16667
4a6bea26
PE
16668 * dired.c (directory_files_internal_unwind): Now static.
16669
f14b7e14
PE
16670 * fileio.c (file_name_as_directory, directory_file_name):
16671 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
16672 Now static.
2893f146
PE
16673 (file_name_as_directory): Use const pointers when appropriate.
16674 (Fexpand_file_name): Likewise. In particular, newdir might
16675 point at constant storage, so make it a const pointer.
fd4ead52 16676 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
16677 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
16678 signedness issues.
f839df0c
PE
16679 (Fset_file_times, Finsert_file_contents, auto_save_error):
16680 Rename locals to avoid shadowing.
f14b7e14 16681
5716756e 16682 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
16683 (Ftry_completion, Fall_completions): Rename or remove locals
16684 to avoid shadowing.
5716756e 16685
b4c3046a
PE
16686 * marker.c (bytepos_to_charpos): Remove; unused.
16687
b45db522
PE
16688 * lisp.h (verify_bytepos, count_markers): New decls,
16689 so that gcc does not warn that these functions aren't declared.
16690
85876d07
PE
16691 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
16692 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 16693 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 16694 (copy_text): Remove unused local var.
85876d07 16695
03d78a21 16696 * filelock.c (within_one_second): Now static.
b3dd38ab 16697 (lock_file_1): Rename local to avoid shadowing.
03d78a21 16698
5df8f01b
PE
16699 * buffer.c (fix_overlays_before): Mark locals as initialized.
16700 (fix_start_end_in_overlays): Likewise. This function should be
16701 simplified by using pointers-to-pointers, but that's a different
16702 matter.
b1d876f1 16703 (switch_to_buffer_1): Now static.
8f54f30a
PE
16704 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
16705 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 16706
a70072c9 16707 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 16708 Fix pointer signedness issue.
edced198
PE
16709 (sys_subshell): Mark local as volatile if checking for lint,
16710 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 16711 (MAXPATHLEN): Define only if needed.
a70072c9 16712
a0977c44
PE
16713 * process.c (serial_open, serial_configure): Move decls from here ...
16714 * systty.h: ... to here, so that they can be checked.
16715
a884fdcc
PE
16716 * fns.c (get_random, seed_random): Move extern decls from here ...
16717 * lisp.h: ... to here, so that they can be checked.
16718
604efe86 16719 * sysdep.c (reset_io): Now static.
b8950c94 16720 (wait_for_termination_signal): Remove; unused.
604efe86 16721
38fc62d9
PE
16722 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
16723 (copy_keymap_item, append_key, push_text_char_description):
16724 Now static.
1004a21a 16725 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 16726 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
16727 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
16728 (describe_map_tree):
16729 Rename locals to avoid shadowing.
38fc62d9 16730
2f2650da
PE
16731 * keyboard.c: Declare functions static if they are not used elsewhere.
16732 (echo_char, echo_dash, cmd_error, top_level_2):
16733 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
16734 (read_char, kbd_buffer_get_event, make_lispy_position):
16735 (make_lispy_event, make_lispy_movement, apply_modifiers):
16736 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
16737 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
16738 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 16739 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 16740 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 16741
a053e86c 16742 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
16743 (mark_kboards): Move decl here ...
16744 * alloc.c (mark_kboards): ... from here.
a053e86c 16745
4752793e
PE
16746 * lisp.h (force_auto_save_soon): New decl.
16747
74f10ca7 16748 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
16749 (DEFINE_DUMMY_FUNCTION): New macro.
16750 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
16751 Use it.
c03cd23f
PE
16752 (main): Add casts to avoid warnings
16753 if GCC considers string literals to be constants.
74f10ca7 16754
022e70d4
PE
16755 * lisp.h (fatal_error_signal): Add decl, since it's exported.
16756
59d6fe83
PE
16757 * dbusbind.c: Pointer signedness fixes.
16758 (xd_signature, xd_append_arg, xd_initialize):
16759 (Fdbus_call_method, Fdbus_call_method_asynchronously):
16760 (Fdbus_method_return_internal, Fdbus_method_error_internal):
16761 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
16762 (Fdbus_register_signal): Use SSDATA when the context wants char *.
16763
78320123
PE
16764 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
16765 if GCC considers string literals to be constants.
49cebcca 16766 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 16767
35ac2a97
SM
167682011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
16769
fb103ca9
SM
16770 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
16771 (print_preprocess, print_object): New macro to fix last change.
16772
35ac2a97
SM
16773 * print.c (print_preprocess): Don't forget font objects.
16774
62973b41
JB
167752011-03-16 Juanma Barranquero <lekktu@gmail.com>
16776
16777 * emacs.c (USAGE3): Doc fixes.
16778
0e48bb22
AS
167792011-03-15 Andreas Schwab <schwab@linux-m68k.org>
16780
16781 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
16782 structure.
16783
7684e57b
JB
167842011-03-14 Juanma Barranquero <lekktu@gmail.com>
16785
16786 * lisp.h (VWindow_system, Qfile_name_history):
16787 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
16788 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
16789 (w32_system_caret_x, w32_system_caret_y): Declare extern.
16790
16791 * w32select.c: Don't #include "keyboard.h".
c96bbc66 16792 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
16793
16794 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
16795 * w32console.c (detect_input_pending, read_input_pending)
16796 (encode_terminal_code):
16797 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
16798 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
16799 (w32_system_caret_y, Qfile_name_history):
16800 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
16801 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
16802 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
16803 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
16804 * w32proc.c (Qlocal, report_file_error):
16805 * w32term.c (Vwindow_system, updating_frame):
16806 * w32uniscribe.c (initialized, uniscribe_font_driver):
16807 Remove unneeded extern declarations.
16808
2aa46d6c
CY
168092011-03-14 Chong Yidong <cyd@stupidchicken.com>
16810
c96bbc66 16811 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 16812
cffc6f3b
CY
168132011-03-13 Chong Yidong <cyd@stupidchicken.com>
16814
16815 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
16816 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
16817 These macros can no longer be used for assignment.
16818
44f230aa
SM
16819 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
16820 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
16821 (record_buffer_markers, fetch_buffer_markers): New functions for
16822 recording and fetching special buffer markers.
16823 (set_buffer_internal_1, set_buffer_temp): Use them.
16824
16825 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
16826
16827 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
16828
16829 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
16830 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
16831
16832 * xdisp.c (hscroll_window_tree):
16833 (reconsider_clip_changes): Use PT instead of BUF_PT.
16834
d251f04b
EZ
168352011-03-13 Eli Zaretskii <eliz@gnu.org>
16836
16837 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
16838 $(EMACS_ROOT)/lib/intprops.h.
16839
f0c77cd1
PE
168402011-03-13 Paul Eggert <eggert@cs.ucla.edu>
16841
3eca4629
PE
16842 Fix more problems found by GCC 4.5.2's static checks.
16843
7c86ee98
PE
16844 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
16845 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
16846 (xg_free_frame_widgets): Make it clear that a local variable is
16847 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
16848 (gdk_window_get_screen): Make it clear that this macro is needed
16849 only if USE_GTK_TOOLTIP.
1e5524e7
PE
16850 (int_gtk_range_get_value): New function, which avoids a diagnostic
16851 from gcc -Wbad-function-cast.
16852 (xg_set_toolkit_scroll_bar_thumb): Use it.
16853 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
16854 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
16855 (get_utf8_string, xg_get_file_with_chooser):
16856 Rename locals to avoid shadowing.
16857 (create_dialog): Move locals to avoid shadowing.
7c86ee98 16858
41729b81
PE
16859 * xgselect.c (xg_select): Remove unused var.
16860
f0c77cd1
PE
16861 * image.c (four_corners_best): Mark locals as initialized.
16862 (gif_load): Initialize transparent_p to zero (Bug#8238).
16863 Mark another local as initialized.
ec6cf4c6 16864 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 16865
ce0ad53d 16866 * image.c (clear_image_cache): Now static.
d5d5a617 16867 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 16868 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
16869 (x_edge_detection): Remove unnecessary cast that
16870 gcc -Wbad-function-cast diagnoses.
2037898d 16871 (gif_load): Fix pointer signedness.
6ae141d6
PE
16872 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
16873 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 16874
33383987 168752011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 16876
d32df629
PE
16877 Improve quality of tests for time stamp overflow.
16878 For example, without this patch (encode-time 0 0 0 1 1
16879 1152921504606846976) returns the obviously-bogus value (-948597
16880 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
16881 reports time overflow. See
16882 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
16883 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
16884 * editfns.c: Include limits.h and intprops.h.
16885 (TIME_T_MIN, TIME_T_MAX): New macros.
16886 (time_overflow): Move earlier, to before first use.
16887 (hi_time, lo_time): New functions, for an accurate test for
16888 out-of-range times.
16889 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
16890 (Fget_internal_run_time): Don't assume time_t fits in int.
16891 (make_time): Use list2 instead of Fcons twice.
16892 (Fdecode_time): More accurate test for out-of-range times.
16893 (check_tm_member): New function.
16894 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
16895 (lisp_time_argument): Don't rely on undefined left-shift and
16896 right-shift behavior when checking for time stamp overflow.
8be6f318 16897
fe31d94c
PE
16898 * editfns.c (time_overflow): New function, refactoring common code.
16899 (Fformat_time_string, Fdecode_time, Fencode_time):
16900 (Fcurrent_time_string): Use it.
16901
8be6f318
PE
16902 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
16903 * dired.c (make_time): Move to ...
16904 * editfns.c (make_time): ... here.
16905 * systime.h: Note the move.
16906
09d9db2c 169072011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 16908
126bc0dc
YM
16909 * fringe.c (update_window_fringes): Remove unused variables.
16910
c47cbdfd
YM
16911 * unexmacosx.c (copy_data_segment): Also copy __got section.
16912 (Bug#8223)
16913
7ac80be9
EZ
169142011-03-12 Eli Zaretskii <eliz@gnu.org>
16915
c96bbc66 16916 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
16917 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
16918 Constify `char *' arguments and their references according to
16919 prototypes in tparam.h.
16920
ecb0f94d 16921 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 16922
7ac80be9
EZ
16923 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
16924 Adapt all references accordingly.
16925
16926 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
16927
ef1fd07e
TT
169282011-03-11 Tom Tromey <tromey@redhat.com>
16929
16930 * buffer.c (syms_of_buffer): Remove obsolete comment.
16931
7ef4b50c
EZ
169322011-03-11 Eli Zaretskii <eliz@gnu.org>
16933
16934 * termhooks.h (encode_terminal_code): Declare prototype.
16935
16936 * msdos.c (encode_terminal_code): Don't declare prototype.
16937
16938 * term.c (encode_terminal_code): Now external again, used by
16939 w32console.c and msdos.c.
16940
44f230aa
SM
16941 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
16942 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 16943
4b1ec863 169442011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 16945
1714f52b 16946 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 16947
4b1ec863
PE
16948 * fringe.c (update_window_fringes): Mark locals as initialized
16949 (Bug#8227).
16950 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 16951
524c7aa6
PE
16952 * alloc.c (mark_fringe_data): Move decl from here ...
16953 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
16954 to check its interface.
16955 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
16956
a5c0af81 16957 * fontset.c (free_realized_fontset): Now static.
7519b8cd 16958 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 16959 (fontset_font): Mark local as initialized.
a9a06e0b 16960 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 16961
b4716021
PE
16962 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
16963
811e9bac 16964 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 16965 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
16966 (x_own_selection, Fx_disown_selection_internal): Rename locals
16967 to avoid shadowing.
16968 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 16969
7e3ab302
PE
16970 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
16971 so that the caller can use some name other than gcpro1.
16972 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
16973 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16974 (Fx_backspace_delete_keys_p):
16975 Use them to avoid shadowing, and rename vars to avoid shadowing.
16976 (x_decode_color, x_set_name, x_window): Now static.
6b437900 16977 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 16978 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
16979 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
16980 Remove unused locals.
7e3ab302
PE
16981 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16982 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
16983 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
16984 macros.
f78faa98 16985
e2b13473
PE
16986 * xterm.h (x_mouse_leave): New decl.
16987
77f23912
PE
16988 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
16989 Remove unused functions.
cdf4ba58
PE
16990 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
16991 (x_calc_absolute_position): Now static.
7411c686 16992 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 16993 Don't declare local "event" unless it's used.
ed7bf3a5
PE
16994 (x_iconify_frame, x_free_frame_resources): Don't declare locals
16995 unless they are used.
38d0b34a
PE
16996 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
16997 (x_fatal_error_signal): Remove; not used.
a6067996
PE
16998 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
16999 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
17000 (x_error_catcher, x_connection_closed, x_error_handler):
17001 (x_error_quitter, xembed_send_message, x_iconify_frame):
17002 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 17003 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 17004 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 17005
44f230aa
SM
17006 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
17007 Rename or move locals to avoid shadowing.
6b463e58 17008 (tty_defined_color, merge_face_heights): Now static.
5967d051 17009 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
17010 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
17011 does not deduce is never used uninitialized.
73719eba
PE
17012 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
17013 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 17014
426994c3 17015 * terminal.c (store_terminal_param): Now static.
5489860b 17016
032f1620 17017 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 17018 (set_frame_menubar): Remove unused local.
d4323972 17019 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
17020 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
17021 since they might point to immutable storage.
281585b0
PE
17022 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
17023 since it's unused otherwise.
032f1620 17024
367c19e5 17025 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 17026 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
17027 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
17028 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 17029 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
17030 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
17031 does not deduce are never used uninitialized.
70739cbe 17032
07b48fa9
PE
17033 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
17034
8868a238 17035 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
17036 * window.c (window_loop, size_window):
17037 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 17038
7e5cf297 17039 * window.c (display_buffer): Now static.
d6550a9f
PE
17040 (size_window): Mark variables that gcc -Wuninitialized
17041 does not deduce are never used uninitialized.
a586633d
PE
17042 * window.h (check_all_windows): New decl, to forestall
17043 gcc -Wmissing-prototypes diagnostic.
5b555da1 17044 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 17045
f6095868
PE
17046 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
17047 shadowing.
17048 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
17049 Include <limits.h>.
17050 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
17051 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
17052 (load_charset_map): Mark variables that gcc -Wuninitialized
17053 does not deduce are never used uninitialized.
53df7c11 17054 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 17055
f38b440c
PE
17056 * coding.c (coding_set_source, coding_set_destination):
17057 Use "else { /* comment */ }" rather than "else /* comment */;"
17058 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
17059 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
17060 a block, when the outer 'i' will do.
17061 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
17062 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
17063 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
17064 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
17065 (Fdecode_sjis_char, Fdefine_coding_system_internal):
17066 Rename locals to avoid shadowing.
17067 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
17068 * coding.c (emacs_mule_char, encode_invocation_designation):
17069 Now static, since they're not used elsewhere.
413bb2db 17070 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 17071 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
17072 (decode_coding_emacs_mule): Mark variables that gcc
17073 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
17074 (detect_coding_iso_2022): Initialize a local variable that might
17075 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 17076 this initialization is needed. (Bug#8211)
5f58e762
PE
17077 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
17078 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
17079 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
17080 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
17081 Remove unused macros.
f38b440c 17082
232b38b9 17083 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 17084 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 17085 * character.c (string_count_byte8): Likewise.
232b38b9 17086
fb90da1b
PE
17087 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
17088 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
17089
fb93dbc2
PE
17090 * chartab.c (copy_sub_char_table): Now static, since it's not used
17091 elsewhere.
5c156ace
PE
17092 (sub_char_table_ref_and_range, char_table_ref_and_range):
17093 Rename locals to avoid shadowing.
bbcd0949 17094 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 17095
7d3b3862 17096 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 17097 (BIDI_BOB): Remove unused macro.
7d3b3862 17098
6be7d3da
PE
17099 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
17100 deduce are never used uninitialized.
c2ed9c8b 17101 * term.c (encode_terminal_code): Likewise.
6be7d3da 17102
75f8807f 17103 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 17104
50938595
PE
17105 * tparam.h: New file.
17106 * term.c, tparam.h: Include it.
17107 * deps.mk (term.o, tparam.o): Depend on tparam.h.
17108 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
17109 Move these decls to tparam.h, and make them agree with what
17110 is actually in tparam.c. The previous trick of using incompatible
17111 decls in different modules does not conform to the C standard.
17112 All callers of tparam changed to use tparam's actual API.
17113 * tparam.c (tparam1, tparam, tgoto):
17114 Use const pointers where appropriate.
17115
fbceeba2
PE
17116 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
17117 * cm.h (struct cm): Likewise.
17118 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
17119 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
17120 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
17121 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
17122 (turn_on_face, init_tty): Likewise.
17123 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 17124
7f3f1250
PE
17125 * term.c (term_mouse_position): Rename local to avoid shadowing.
17126
e6ca6543
PE
17127 * alloc.c (mark_ttys): Move decl from here ...
17128 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
17129
c40f8d15
AS
171302011-03-11 Andreas Schwab <schwab@linux-m68k.org>
17131
17132 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
17133
cfe0661d
JB
171342011-03-09 Juanma Barranquero <lekktu@gmail.com>
17135
17136 * search.c (compile_pattern_1): Remove argument regp, unused since
17137 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
17138 (compile_pattern): Don't pass it.
17139
0afb4571
J
171402011-03-08 Jan Djärv <jan.h.d@swipnet.se>
17141
17142 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
17143 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
17144 for ! HAVE_GTK3.
17145 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
17146
17147 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
17148
17149 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
17150 gdk_window_get_screen, gdk_window_get_geometry,
17151 gdk_x11_window_lookup_for_display and GDK_KEY_g.
17152 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
17153 (xg_get_pixbuf_from_pixmap): New function.
17154 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
17155 to Pixmap, take frame as parameter, remove GdkColormap parameter.
17156 Call xg_get_pixbuf_from_pixmap instead of
17157 gdk_pixbuf_get_from_drawable.
17158 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
17159 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
17160 (xg_check_special_colors): Use GtkStyleContext and its functions
17161 for HAVE_GTK3.
17162 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
17163 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
17164 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
17165 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
17166 Call gtk_widget_get_preferred_size.
0afb4571
J
17167 (xg_frame_resized): gdk_window_get_geometry only takes 5
17168 parameters.
44f230aa
SM
17169 (xg_win_to_widget, xg_event_is_for_menubar):
17170 Call gdk_x11_window_lookup_for_display.
0afb4571
J
17171 (xg_set_widget_bg): New function.
17172 (delete_cb): New function.
895009e1 17173 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 17174 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
17175 (xg_set_background_color): Call xg_set_widget_bg.
17176 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
17177 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
17178 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
17179 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
17180 if ! HAVE_GTK3.
17181 (update_frame_tool_bar): Call gtk_widget_hide.
17182 (xg_initialize): Use GDK_KEY_g.
17183
17184 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
17185 if ! HAVE_GTK3
17186 (x_session_initialize): Call gdk_x11_set_sm_client_id.
17187
17188 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
17189 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
17190 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
17191
1c2cc4ef
JB
171922011-03-08 Juanma Barranquero <lekktu@gmail.com>
17193
17194 * w32xfns.c (select_palette): Check success of RealizePalette against
17195 GDI_ERROR, not zero.
17196
33383987 17197See ChangeLog.11 for earlier changes.
aac0c6e3
MR
17198
17199;; Local Variables:
17200;; coding: utf-8
aac0c6e3
MR
17201;; End:
17202
2f097256 17203 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
17204
17205 This file is part of GNU Emacs.
17206
17207 GNU Emacs is free software: you can redistribute it and/or modify
17208 it under the terms of the GNU General Public License as published by
17209 the Free Software Foundation, either version 3 of the License, or
17210 (at your option) any later version.
17211
17212 GNU Emacs is distributed in the hope that it will be useful,
17213 but WITHOUT ANY WARRANTY; without even the implied warranty of
17214 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17215 GNU General Public License for more details.
17216
17217 You should have received a copy of the GNU General Public License
17218 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.