Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2adb6e85
PE
12011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2
3 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5 which caused a build failure on GNU/Linux IA-64. This problem was
6 introduced by my 2011-10-07 patch.
7
d1d7b339
JL
82011-12-15 Juri Linkov <juri@jurta.org>
9
10 * image.c (imagemagick_error): New function. (Bug#10112)
11 (imagemagick_load_image): Comment out `MagickSetResolution' call.
12 Use `imagemagick_error' where ImageMagick functions return
13 `MagickFalse'.
14 (Fimagemagick_types): Add `Fnreverse' to return the list in the
15 proper order.
16
100d5755
KH
172011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
18
19 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
20 fill background (Bug#8992).
21
454592a6
MR
222011-12-13 Martin Rudalics <rudalics@gmx.at>
23
24 * window.c (Vwindow_combination_resize)
25 (Vwindow_combination_limit): Use t instead of non-nil in
26 doc-strings.
61d4b438
MR
27 (Vrecenter_redisplay): Add first sentence of doc-string on
28 separate line.
53524d93 29 (Frecenter): Fix doc-string typo.
454592a6 30
3633e3aa
KH
312011-12-11 Kenichi Handa <handa@m17n.org>
32
33 * coding.c (Funencodable_char_position): Pay attention to the
34 buffer text relocation (Bug#9389).
35
7b9d523a
JD
362011-12-10 Jan Djärv <jan.h.d@swipnet.se>
37
38 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
39 gtk_init (Bug#10100).
40
b73189c6
EZ
412011-12-10 Eli Zaretskii <eliz@gnu.org>
42
43 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
44 IT->string is nil. (Bug#10263)
45
f7dfe5d6
JD
462011-12-10 Jan Djärv <jan.h.d@swipnet.se>
47
83faebb4
JD
48 * nsterm.h (x_free_frame_resources): Declare.
49
f7dfe5d6
JD
50 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
51 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
52
53 * nsterm.h (ns_get_defaults_value): Declare.
54
55 * nsterm.m (ns_default): Call ns_get_defaults_value.
56
7cd4e72c
EZ
572011-12-09 Eli Zaretskii <eliz@gnu.org>
58
59 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
60 (Bug#10170)
61
b34d7317
YM
622011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
63
64 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
65 that where the value of an _OBJC_* symbol points to is in the .bss
66 section (Bug#10240).
67
76470ad1
KH
682011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
69
70 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 71 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 72
745fff94
KH
732011-12-08 Kenichi Handa <handa@m17n.org>
74
75 * ftfont.c (get_adstyle_property): Fix previous change
76 (Bug#10233).
77
6e44397c
JB
782011-12-07 Juanma Barranquero <lekktu@gmail.com>
79
80 * w32.c (init_environment): If no_site_lisp, remove site-lisp
81 dirs from the default value of EMACSLOADPATH (bug#10208).
82
7efa6272
GM
832011-12-07 Glenn Morris <rgm@gnu.org>
84
85 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
86 installation and source directories as well. (Bug#10208)
87
f6fc4d87
CY
882011-12-06 Chong Yidong <cyd@gnu.org>
89
90 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
91
2bf26180
GM
922011-12-06 Glenn Morris <rgm@gnu.org>
93
94 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
95 as an error, not just -1. (Bug#10217)
96
3a6ad4f0
CY
972011-12-05 Chong Yidong <cyd@gnu.org>
98
99 * keyboard.c (process_special_events): New function.
100 (swallow_events, Finput_pending_p): Use it (Bug#10195).
101
75a3b399
PE
1022011-12-05 Paul Eggert <eggert@cs.ucla.edu>
103
104 * coding.c (encode_designation_at_bol): Don't use uninitialized
105 local variable (Bug#9318).
106
c3c9e25e
KH
1072011-12-05 Kenichi Handa <handa@m17n.org>
108
109 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
110 return Qnil (Bug#8046, Bug#10193).
111
5eb05ea3
KH
1122011-12-05 Kenichi Handa <handa@m17n.org>
113
114 * coding.c (encode_designation_at_bol): New args charbuf_end and
115 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
116 (coding_set_source): Return how many bytes coding->source was
117 relocated.
118 (coding_set_destination): Return how many bytes
119 coding->destination was relocated.
120 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
121 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
122
1232011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
124
125 * coding.c (CODING_CHAR_CHARSET_P): New macro.
126 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
127 macro (Bug#9318).
128
1292011-12-05 Andreas Schwab <schwab@linux-m68k.org>
130
131 The following changes are to fix Bug#9318.
132
a79703f5 133 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
134 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
135 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 136 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 137
7dbda6df
JB
1382011-12-05 Juanma Barranquero <lekktu@gmail.com>
139
140 * lisp.h (process_quit_flag): Fix external declaration.
141
6d5eb5b0
SM
1422011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
143
144 Don't macro-inline non-performance-critical code.
145 * eval.c (process_quit_flag): New function.
146 * lisp.h (QUIT): Use it.
147
a0c3fad0
JD
1482011-12-04 Jan Djärv <jan.h.d@swipnet.se>
149
150 * nsfns.m (get_geometry_from_preferences): New function.
151 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
152
6c07aac2
AS
1532011-12-04 Andreas Schwab <schwab@linux-m68k.org>
154
155 * emacs.c (Qkill_emacs): Define.
156 (syms_of_emacs): Initialize it.
157 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
158 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
159 (quit_throw_to_read_char): Add parameter `from_signal'.
160 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
161 * lisp.h (QUIT): Call Fkill_emacs if requested.
162
c052ead4
JD
1632011-12-03 Jan Djärv <jan.h.d@swipnet.se>
164
165 * widget.c (update_wm_hints): Return if wmshell is null.
166 (widget_update_wm_size_hints): New function.
167
168 * widget.h (widget_update_wm_size_hints): Declare.
169
170 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
171 widget_update_wm_size_hints (Bug#10104).
172
9e49252b
EZ
1732011-12-03 Eli Zaretskii <eliz@gnu.org>
174
175 * xdisp.c (handle_invisible_prop): If the invisible text ends just
176 before a newline, prepare the bidi iterator for consuming the
177 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 178 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 179
02b16839
JL
1802011-12-02 Juri Linkov <juri@jurta.org>
181
182 * search.c (Fword_search_regexp): New Lisp function created from
183 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
184 (Fword_search_backward, Fword_search_forward)
185 (Fword_search_backward_lax, Fword_search_forward_lax):
186 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
187 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
188
0068070e
SM
1892011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
190
191 * fileio.c (Finsert_file_contents): Move after-change-function call
192 to before the "handled:" label, since all "goto handled" appear in
193 cases where the *-change-functions have already been properly called
194 (bug#10117).
195
3360a3fc
AS
1962011-12-01 Andreas Schwab <schwab@linux-m68k.org>
197
198 * keyboard.c (interrupt_signal): Don't call kill-emacs when
199 waiting for input. (Bug#10169)
200
73d6c093
EZ
2012011-11-30 Eli Zaretskii <eliz@gnu.org>
202
203 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
204 verifies glyph row's hash code--we have just reallocated the
205 glyphs, so their contents can be complete garbage. (Bug#10164)
206
febe6bea
JB
2072011-11-30 Juanma Barranquero <lekktu@gmail.com>
208
209 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
210
801a4313
EZ
2112011-11-30 Eli Zaretskii <eliz@gnu.org>
212
213 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
214 attributes are tested _before_ calling verify_row_hash, to protect
215 against GCC re-ordering of the tests. (Bug#10164)
216
2b56b87e
JD
2172011-11-29 Jan Djärv <jan.h.d@swipnet.se>
218
219 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
220
221 * xterm.c (handle_one_xevent): Only set async_visible and friends
222 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 223 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
224 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
225
dbf31225
PE
2262011-11-28 Paul Eggert <eggert@cs.ucla.edu>
227
228 Remove GCPRO-related macros that exist only to avoid shadowing locals.
229 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
230 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
231 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
232 All uses changed to use GCPRO1 etc.
233 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
234 Revert to old implementation (i.e., before 2011-03-11).
235
1305621b
YM
2362011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
237
238 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
239 of scroll runs so as to avoid assigning disabled bogus rows and
240 unnecessary graphics copy operations.
241
8c9afb46
EZ
2422011-11-27 Eli Zaretskii <eliz@gnu.org>
243
244 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
245 (snprintf) [_MSC_VER]: Redirect to _snprintf.
246 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
247 (malloc, free, realloc, calloc): Redirect to e_* only when
248 compiling Emacs.
249
250 * lisp.h (GCTYPEBITS): Move before first use.
251 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
252 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
253 this macro definition.
254
255 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
256 _MSC_VER.
257
54e9e3bf
JD
2582011-11-27 Jan Djärv <jan.h.d@swipnet.se>
259
6d5eb5b0
SM
260 * gtkutil.c (xg_create_frame_widgets):
261 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
262 present with Gtk+ 2.0.
263
83aca1cb
PE
2642011-11-26 Paul Eggert <eggert@cs.ucla.edu>
265
266 * fileio.c (Finsert_file_contents): Undo previous change; see
267 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
268
5b76caa4
PE
2692011-11-26 Paul Eggert <eggert@cs.ucla.edu>
270
271 Rename locals to avoid shadowing.
272 * fileio.c (Finsert_file_contents):
273 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
274 * process.c (wait_reading_process_output):
275 Rename inner 'proc' to 'p' to avoid shadowing.
276 Indent for consistency with usual Emacs style.
277
8c535114
EZ
2782011-11-25 Eli Zaretskii <eliz@gnu.org>
279
280 * xdisp.c (redisplay_window): If cursor row is not fully visible
281 after recentering, and scroll-conservatively is set to a large
282 number, scroll window by a few more lines to make the cursor fully
283 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
284 (start_display): Don't move to the next line if the display should
285 start at a newline that is part of a display vector or an overlay
286 string. (Bug#10119)
8c535114 287
fa4fdb5c
JL
2882011-11-24 Juri Linkov <juri@jurta.org>
289
290 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
291 after the `MagickPingImage' call. (Bug#10112)
292
90ec88df
CY
2932011-11-23 Chong Yidong <cyd@gnu.org>
294
295 * window.c (Fcoordinates_in_window_p): Accept only live windows.
296
56e2e794
MR
2972011-11-23 Martin Rudalics <rudalics@gmx.at>
298
299 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
300 making another buffer current. (Bug#10114)
301
b6e64c41
GM
3022011-11-23 Glenn Morris <rgm@gnu.org>
303
304 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
305
6b21de18
CY
3062011-11-23 Chong Yidong <cyd@gnu.org>
307
308 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
309 using it (Bug#5984).
310
b12cd789
EZ
3112011-11-22 Eli Zaretskii <eliz@gnu.org>
312
313 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
314 and header-lines, as they don't have one computed for them.
315 (Bug#10098)
316
317 * .gdbinit (prow): Make displayed values more self-explaining.
318 Add row's hash code.
319
261b6fd4
LMI
3202011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
321
322 * process.c (wait_reading_process_output): Fix asynchrounous
323 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 324 (wait_reading_process_output): Add comment and URL.
261b6fd4 325
e7cfd277
JD
3262011-11-21 Jan Djärv <jan.h.d@swipnet.se>
327
328 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
329
a9b9b7f5
CY
3302011-11-21 Chong Yidong <cyd@gnu.org>
331
332 * window.c (Fnext_window, Fprevious_window): Doc fix.
333
b0d15b4f
SM
3342011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
335
336 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
337
fe7a3057
JB
3382011-11-20 Juanma Barranquero <lekktu@gmail.com>
339
340 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
341
d2999b1a
MR
3422011-11-20 Martin Rudalics <rudalics@gmx.at>
343
344 * window.c (Fset_window_combination_limit): Rename argument
345 STATUS to LIMIT.
346 (Vwindow_combination_limit): Remove "status" from doc-string.
347
d5ff9cd0
AS
3482011-11-20 Andreas Schwab <schwab@linux-m68k.org>
349
350 * m/ibms390.h: Remove.
351 * m/ibms390x.h: Don't include "ibms390.h".
352
a5bb9bd3
SM
3532011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
354
355 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
356 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
357
cd1181db
JB
3582011-11-20 Juanma Barranquero <lekktu@gmail.com>
359
360 * casetab.c (Fset_case_table):
361 * charset.c (Fcharset_after): Fix typos.
362
615a3b8d 3632011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 364
17e845af
PE
365 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
366 Otherwise, valgrind does not work on some platforms.
367 Problem reported by Andreas Schwab in
6a0bf43d
PE
368 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
369 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
370 is set, removing the need for VIRT_ADDRESS_VARIES.
371 (PURE_P): Use a more-efficient implementation that needs just one
372 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
373 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
374 to 4 (xorl, subq, cmpq, setbe).
375 * alloc.c (pure): Always extern now, since that's the
376 VIRT_ADDR_VARIES behavior.
377 (PURE_POINTER_P): Use a single comparison, not two, for
378 consistency with the new puresize.h.
379 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
380 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
381 Remove VIRT_ADDR_VARIES no longer needed.
382
f8fe6f96
EZ
3832011-11-19 Eli Zaretskii <eliz@gnu.org>
384
385 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
386 (erase_phys_cursor, update_window_cursor, show_mouse_face)
387 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
388 behave as if the cursor position were at the window margin.
389
390 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
391 and the cursor position is out of bounds, behave as if the cursor
392 position were at the window margin. (Bug#10075)
393
df05a53c
CY
3942011-11-18 Chong Yidong <cyd@gnu.org>
395
396 * window.c (Fwindow_combination_limit): Make first argument
397 non-optional, since it is meaningless for live windows like the
398 selected window.
399
2071918e
DA
4002011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
401
402 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
403
b50a28de
SM
4042011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
405
406 * intervals.c: Fix grafting over the whole buffer (bug#10071).
407 (graft_intervals_into_buffer): Simplify.
408
015137db
EZ
4092011-11-18 Eli Zaretskii <eliz@gnu.org>
410
411 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
412 hash values of the two rows.
413 (copy_row_except_pointers): Preserve the used[] arrays and the
414 hash values of the two rows. (Bug#10035)
68c95424 415 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
416
417 * xdisp.c (row_hash): New function, body extracted from
418 compute_line_metrics.
419 (compute_line_metrics): Call row_hash, instead of computing the
420 hash code inline.
421
422 * dispnew.c (verify_row_hash): Call row_hash for computing the
423 hash code of a row, instead of duplicating code from xdisp.c.
424
425 * dispextern.h (row_hash): Add prototype.
426
a2addb04
TH
4272011-11-18 Tassilo Horn <tassilo@member.fsf.org>
428
429 * frame.c (delete_frame): Don't delete the terminal when the last
430 X frame is closed if emacs is built with GTK toolkit.
431
df85d315
JB
4322011-11-17 Juanma Barranquero <lekktu@gmail.com>
433
434 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
435
a0c2d0ae
MR
4362011-11-17 Martin Rudalics <rudalics@gmx.at>
437
438 * window.c (Vwindow_splits): Rename to
439 Vwindow_combination_resize. Suggested by Juri Linkov.
440 (Fsplit_window_internal): Use Vwindow_combination_resize instead
441 of Vwindow_splits.
442
58179cce
JB
4432011-11-16 Juanma Barranquero <lekktu@gmail.com>
444
7877f373
JB
445 * nsfns.m (Fns_font_name):
446 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 447
b6f67890
MR
4482011-11-16 Martin Rudalics <rudalics@gmx.at>
449
450 * window.h (window): Rename slot "nest" to "combination_limit".
451 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
452 (Fset_window_nest): Rename to Fset_window_combination_limit.
453 (Vwindow_nest): Rename to Vwindow_combination_limit.
454 (recombine_windows, make_parent_window, make_window)
455 (Fsplit_window_internal, saved_window)
456 (Fset_window_configuration, save_window_save): Rename all
457 occurrences of window_nest to window_combination_limit.
458
c7015153
JB
4592011-11-15 Juanma Barranquero <lekktu@gmail.com>
460
461 * image.c (imagemagick_load_image): Fix typo.
462
322ad6ec
EZ
4632011-11-14 Eli Zaretskii <eliz@gnu.org>
464
465 * xdisp.c (display_line): Move the call to
466 highlight_trailing_whitespace before the call to
467 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
468 faces of all the glyphs to compute ROW's hash value.
469 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 470
f067b8ec
JB
4712011-11-14 Juanma Barranquero <lekktu@gmail.com>
472
473 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
474 just return (bug#10044).
475
1e5b2111
EZ
4762011-11-12 Eli Zaretskii <eliz@gnu.org>
477
7ef3cbd5
EZ
478 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
479 with user-defined heap size. Bump the default size of the temacs
480 heap to 27MB, to avoid memory warning when running temacs.
481 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
482
1e5b2111
EZ
483 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
484 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
485 (verify_row_hash) [XASSERTS]: New function.
486 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
487 that the hash value of glyph rows is correct.
1e5b2111 488
89d61221
MR
4892011-11-12 Martin Rudalics <rudalics@gmx.at>
490
491 * window.h (window): Remove splits slot.
492 * window.c (Fwindow_splits, Fset_window_splits): Remove.
493 (Fdelete_other_windows_internal, make_parent_window)
494 (make_window, Fsplit_window_internal, Fdelete_window_internal)
495 (Fset_window_configuration, save_window_save): Don't deal with
496 split status of windows.
497 (saved_window): Remove splits slot.
498 (Vwindow_splits): Rewrite doc-string.
499
97f18cc8
JD
5002011-11-11 Jan Djärv <jan.h.d@swipnet.se>
501
502 * xfns.c (unwind_create_frame):
503 * nsfns.m (unwind_create_frame):
504 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
505 Vframe_list (Bug#9999).
506
22a648b4
DA
5072011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
508
0b381c7e 509 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 510
659afede
KH
5112011-11-11 Kenichi Handa <handa@m17n.org>
512
513 * callproc.c (Fcall_process): Set the member dst_multibyte of
514 process_coding.
515
9ac0394b
KH
5162011-11-11 Johan Bockgård <bojohan@gnu.org>
517
518 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
519 avoid a crash (bug#9496).
520
2fbdc249
CY
5212011-11-09 Chong Yidong <cyd@gnu.org>
522
523 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
524 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
525
ac6b1f81
PE
5262011-11-08 Paul Eggert <eggert@cs.ucla.edu>
527
528 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
529
09db192c
PE
5302011-11-08 Paul Eggert <eggert@cs.ucla.edu>
531
532 Avoid some portability problems by eschewing 'extern inline' functions.
533 The trivial performance wins aren't worth the portability hassles; see
534 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
535 et seq.
536 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
537 (window_box_width, window_box_left, window_box_left_offset)
538 (window_box_right, window_box_right_offset): Undo previous change,
539 by removing the "extern"s.
540 * intervals.c (adjust_intervals_for_insertion)
541 (adjust_intervals_for_deletion): Undo previous change,
542 making these static again.
543 (offset_intervals, temp_set_point_both, temp_set_point)
544 (copy_intervals_to_string): No longer inline.
545 * xdisp.c (window_text_bottom_y, window_box_width)
546 (window_box_height, window_box_left_offset)
547 (window_box_right_offset, window_box_left, window_box_right)
548 (window_box): No longer inline.
549
105216ed
CY
5502011-11-08 Chong Yidong <cyd@gnu.org>
551
552 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
553 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
554 Signal an error if not a live window.
105216ed
CY
555 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
556 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
557
ae9e237f
JB
5582011-11-07 Juanma Barranquero <lekktu@gmail.com>
559
560 * lisp.h (syms_of_abbrev): Remove declaration.
561 Reported by CHENG Gao <chenggao@royau.me>.
562
c7aa8333
EZ
5632011-11-07 Eli Zaretskii <eliz@gnu.org>
564
565 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
566 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
567 of temacs in GUI mode.
568
be7f5545
MR
5692011-11-07 Martin Rudalics <rudalics@gmx.at>
570
571 * window.h: Declare delete_all_child_windows instead of
572 delete_all_subwindows.
573 * window.c (Fwindow_nest, Fset_window_nest)
574 (Fset_window_new_total, Fset_window_new_normal)
575 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
576 (delete_all_subwindows): Rename to delete_all_child_windows.
577 (Fdelete_other_windows_internal, Fset_window_configuration):
578 Call delete_all_child_windows instead of delete_all_subwindows.
579 * frame.c (delete_frame): Call delete_all_child_windows instead
580 of delete_all_subwindows.
581
ca78dc43
PE
5822011-11-07 Paul Eggert <eggert@cs.ucla.edu>
583
584 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
585 This is also needed for porting to any host where GC_MARK_STACK is
586 not GC_MAKE_GCPROS_NOOPS.
587 (which_symbols): Use it.
588
a0241d01
KH
5892011-11-07 Kenichi Handa <handa@m17n.org>
590
591 * coding.c (coding_set_destination): Check coding->src_pos only
592 when coding->src_object is a buffer (bug#9910).
593
594 * process.c (send_process): Set the member src_multibyte of coding
595 to 0 (bug#9911) when sending a unibyte text.
596
597 * callproc.c (Fcall_process): Set the member src_multibyte of
598 process_coding to 0 (bug#9912).
599
a64bfdfa 6002011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
601
602 * xmenu.c (cleanup_widget_value_tree): New function.
603 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
604 calling free_menubar_widget_value_tree directly (Bug#9830).
605
cb41b32a
PE
6062011-11-06 Paul Eggert <eggert@cs.ucla.edu>
607
608 Fix some portability problems with 'inline'.
609 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
610 (window_box_width, window_box_left, window_box_left_offset)
611 (window_box_right, window_box_right_offset): Declare extern.
612 Otherwise, these inline functions do not conform to C99 and
613 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
614 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
615 * intervals.c (adjust_intervals_for_insertion)
616 (adjust_intervals_for_deletion): Now extern, because otherwise the
617 extern inline functions 'offset_intervals' couldn't refer to it.
618 (static_offset_intervals): Remove.
619 (offset_intervals): Rewrite using the old contents of
620 static_offset_intervals. The old version didn't conform to C99
621 because an extern inline function contained a reference to an
622 identifier with static linkage.
623
b7041366
AS
6242011-11-06 Andreas Schwab <schwab@linux-m68k.org>
625
626 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
627 GC.
628
88a37c4d
EZ
6292011-11-06 Eli Zaretskii <eliz@gnu.org>
630
631 * xdisp.c (init_iterator, reseat_to_string): Don't set the
632 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
633 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
634 return Qleft_to_right.
635
49745b39
CY
6362011-11-06 Chong Yidong <cyd@gnu.org>
637
638 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
639 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
640 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
641 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
642 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
643 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
644 (Fwindow_vscroll): Doc fix.
645 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
646 argument, since it makes no sense to pass a live window and for
647 consistency with window-child.
648
1f05cd82
CS
6492011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
650
651 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
652 support MSVC.
653
22610910
JR
6542011-11-05 Jason Rumney <jasonr@gnu.org>
655
656 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
657 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
658 fonts (Bug#6029).
659 (add_font_entity_to_list): Fix logic errors in mixed boolean and
660 bitwise arithmetic preventing use of unicode-sip and non-truetype
661 opentype fonts.
662
a06776b2
EZ
6632011-11-05 Eli Zaretskii <eliz@gnu.org>
664
3ad924ba
EZ
665 * s/ms-w32.h (fstat, stat, utime): Move redirections to
666 "emacs"-only part.
667
a06776b2
EZ
668 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
669 initialization code to keep similarity to xfns.c after changes
670 from 2011-11-05.
671
c9e7db78
JD
6722011-11-05 Jan Djärv <jan.h.d@swipnet.se>
673
a97f8f3f
JD
674 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
675 (unwind_create_frame): New function (Bug#9943).
676 (Fx_create_frame): Restructure code to be more similar to the one in
677 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
678 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
679 Move terminal->reference_count++ just before making the frame official
680 (Bug#9943).
681
682 * nsterm.m (x_free_frame_resources): New function.
683 (x_destroy_window): Move code to x_free_frame_resources.
684
c9e7db78 685 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
686 (Fx_create_frame, x_create_tip_frame):
687 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
688 official. Move initialization of image_cache_refcount and
689 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
690
a6fc3b5c
EZ
6912011-11-05 Eli Zaretskii <eliz@gnu.org>
692
693 Support MSVC build with newer versions of Visual Studio.
694 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
695 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
696 nt/gmake.defs.
697
698 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
699 which are not supported by MSVC.
700 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
701 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
702 bitfields.
703 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
704 types in bitfields.
705 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
706
707 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
708
58179cce 7092011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
710
711 Support MSVC build with newer versions of Visual Studio.
712 * w32.c: Don't include w32api.h for MSVC.
713 (init_environment) [_MSC_VER]: Call sys_access, not _access.
714
715 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
716 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
717 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
718 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
719 e_* cousins.
720 (alloca) [_MSC_VER]: Define to _alloca.
721
722 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
723
724 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
725
a58c13ed
EZ
7262011-11-04 Eli Zaretskii <eliz@gnu.org>
727
728 * xdisp.c (note_mouse_highlight): If either of
729 previous/next-single-property-change returns nil, treat that as
730 the beginning or the end of the buffer. (Bug#9955)
731
fe0b6370
JD
7322011-11-04 Jan Djärv <jan.h.d@swipnet.se>
733
a58c13ed 734 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
735 label is not null (Bug#9951).
736 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
737 may be NULL.
738
89bd5ee1
EZ
7392011-11-04 Eli Zaretskii <eliz@gnu.org>
740
741 * window.c (Fwindow_body_size): Mention in the doc string that the
742 return value is in frame's canonical units. (Bug#9949)
743
84c3edb9
EZ
7442011-11-03 Eli Zaretskii <eliz@gnu.org>
745
4e2fb5c7
EZ
746 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
747
84c3edb9 748 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 749 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 750 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 751
bc17a887
EZ
7522011-11-01 Eli Zaretskii <eliz@gnu.org>
753
754 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
755 Don't stop backward scan on the continuation glyph, even though
756 its CHARPOS is positive.
6d5eb5b0
SM
757 (mouse_face_from_buffer_pos, note_mouse_highlight):
758 Rename cover_string to disp_string.
bc17a887 759
4ee88440
MR
7602011-11-01 Martin Rudalics <rudalics@gmx.at>
761
762 * window.c (temp_output_buffer_show): Don't use
763 Vtemp_buffer_show_specifiers.
764 (Vtemp_buffer_show_specifiers): Remove unused variable.
765
c2ff3c02
EZ
7662011-10-30 Eli Zaretskii <eliz@gnu.org>
767
768 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
769 past the beginning of the current glyph matrix.
770
58179cce 7712011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
772
773 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
774 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
775 HAVE_GTK3 (Bug#9869).
b77a6a7f 776
3b574623
JD
777 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
778 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
779
b77a6a7f
JD
780 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
781
782 * xterm.c: Declare x_handle_net_wm_state to return int.
783 (handle_one_xevent): Check if we are iconified but don't have
784 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
785 (get_current_wm_state): Return non-zero if not hidden,
786 check for _NET_WM_STATE_HIDDEN (Bug#9893).
787 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
788 (x_handle_net_wm_state): Return what get_current_wm_state returns.
789 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
790
196e41e4
PE
7912011-10-29 Paul Eggert <eggert@cs.ucla.edu>
792
793 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
794 so that this new function doesn't get optimized away by a
795 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
796
021f2e1a
AS
7972011-10-29 Andreas Schwab <schwab@linux-m68k.org>
798
799 * frame.h (MOUSE_HL_INFO): Remove excess parens.
800
8b058d44
EZ
8012011-10-29 Eli Zaretskii <eliz@gnu.org>
802
803 Fix the `xbytecode' command.
804 * .gdbinit (xprintbytestr): New command.
b50a28de 805 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
806 (xbytecode): Print the byte-code string as well.
807
4452fb80
EZ
8082011-10-29 Kim Storm <storm@cua.dk>
809
8b058d44
EZ
810 * alloc.c (which_symbols): New function.
811
21b72067
AS
8122011-10-29 Andreas Schwab <schwab@linux-m68k.org>
813
814 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
815 line. (Bug#9903)
816
83ed7b5c
GM
8172011-10-29 Glenn Morris <rgm@gnu.org>
818
819 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
820 Not clear what it was for, and it causes various bugs. (Bug#9839)
821
5a7a728b
EZ
8222011-10-28 Eli Zaretskii <eliz@gnu.org>
823
824 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
825 possible random value that matches one of those tested as
826 condition to clear the mouse face.
827
d3d0842f
CY
8282011-10-28 Chong Yidong <cyd@gnu.org>
829
830 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
831
31b39d13
DN
8322011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
833
834 * window.c (make_window): Initialize phys_cursor_on_p.
835
9aba6043
SM
8362011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
837
838 * lisp.h (struct Lisp_Symbol): Update comments.
839
c20992f4
JB
8402011-10-28 Juanma Barranquero <lekktu@gmail.com>
841
842 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
843
db4f02f2
EZ
8442011-10-28 Eli Zaretskii <eliz@gnu.org>
845
846 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
847 <oslsachem@gmail.com> for helping to debug this.
848
849 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
850 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
851 (g_b_init_get_glyph_outline_w): New static variables.
852 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
853 (GetGlyphOutlineW_Proc): New typedefs.
854 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
855 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
856 New functions.
857 (w32font_open_internal, compute_metrics):
858 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
859 instead of calling the "wide" APIs directly.
860
861 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
862
863 * w32.h (syms_of_w32font): Add prototype.
864
87e68db4
JB
8652011-10-27 Juanma Barranquero <lekktu@gmail.com>
866
867 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
868 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
869 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
870 (Fmove_to_window_line): Doc fix.
871
435c1d67
CY
8722011-10-27 Chong Yidong <cyd@gnu.org>
873
874 * process.c (make_process): Set gnutls_state to NULL.
875
876 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
877 non-NULL, regardless of GNUTLS_INITSTAGE.
878 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
879 an error. Set process slots as soon as we allocate them.
880
881 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
882
9c6c6f49
CY
8832011-10-27 Chong Yidong <cyd@gnu.org>
884
9aba6043
SM
885 * gnutls.c (emacs_gnutls_deinit): New function.
886 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
887 (Fgnutls_deinit, Fgnutls_boot): Use it.
888
889 * process.c (make_process): Initialize GnuTLS credentials to NULL.
890 (deactivate_process): Call emacs_gnutls_deinit.
891
657d08d3
JB
8922011-10-27 Juanma Barranquero <lekktu@gmail.com>
893
894 * image.c (x_create_x_image_and_pixmap):
895 * w32.c (sys_rename, w32_delayed_load):
896 * w32font.c (fill_in_logfont):
897 * w32reg.c (x_get_string_resource): Silence compiler warnings.
898
5430d399
JB
8992011-10-26 Juanma Barranquero <lekktu@gmail.com>
900
901 * w32fns.c (w32_default_color_map): New function,
902 extracted from Fw32_default_color_map.
a7ef684b 903 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 904
fe0055fa
PE
9052011-10-25 Paul Eggert <eggert@cs.ucla.edu>
906
907 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
908
e6346438
SM
9092011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
910
911 * keyboard.c (test_undefined): New function (bug#9751).
912 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
913
e112cc37
ET
9142011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
915
916 * sysdep.c (init_sys_modes): Fix the check for the controlling
917 terminal (Bug#6649).
918
7b5d6677
EZ
9192011-10-20 Eli Zaretskii <eliz@gnu.org>
920
921 * dispextern.h (struct bidi_it): New member next_en_type.
922
923 * bidi.c (bidi_line_init): Initialize the next_en_type member.
924 (bidi_resolve_explicit_1): When next_en_pos is valid for the
925 current character, check also for next_en_type being WEAK_EN.
926 (bidi_resolve_weak): Don't enter the expensive loop if the current
927 position is before next_en_pos. Record the bidi type of the first
928 non-ET, non-BN character we find, in addition to its position.
929 (bidi_level_of_next_char): Invalidate next_en_type when
930 next_en_pos is over-stepped.
931
7da0b018
PE
9322011-10-20 Paul Eggert <eggert@cs.ucla.edu>
933
934 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
935 * editfns.c: Rewrite current-time-zone so that it invokes
936 the equivalent of (format-time-string "%Z") to get the time zone name.
937 This fixes a bug when the time zone name contains characters that
938 need converting from the system time locale to Emacs internal format.
939 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
940 that patch fixed format-time-string to do the conversion, but
941 I forgot to fix current-time-zone.
942 (format_time_string): New function, containing most of
943 what Fformat_time_string used to contain.
944 (Fformat_time_string): Rewrite in terms of format_time_string.
945 This doesn't change this function's behavior.
946 (current-time-zone): Rewrite to use format_time_string.
947 This fixes the bug reported by Michael Schierl in
948 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
949 Jason Rumney's 2007-06-07 change worked around this bug, but
950 didn't fix it.
951 * systime.h (tzname, timezone): Remove no-longer-used declarations.
952
8547b010
EZ
9532011-10-19 Eli Zaretskii <eliz@gnu.org>
954
955 * xdisp.c (start_display): If the character at POS is displayed
956 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
957 (try_window_reusing_current_matrix): If a line ends in a display
958 vector or the next line starts in a display vector, continue
959 redrawing the window even though the character position of
960 start_row was reached.
8547b010
EZ
961 (Bug#9771, part 2)
962
4e948d15
CY
9632011-10-18 Chong Yidong <cyd@gnu.org>
964
965 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
966 with nobreak-char-display too.
967
4787455f
EZ
9682011-10-18 Eli Zaretskii <eliz@gnu.org>
969
970 Fix part 3 of bug#9771.
971 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
972 (bidi_resolve_neutral): Don't enter the expensive loop looking for
973 non-neutral characters if the current character is a paragraph
974 separator (a.k.a. Newline). This avoids running the same
975 expensive loop twice, once when we consume the preceding newline
976 and the other time when the line actually needs to be displayed.
977 Avoid the loop when we see neutrals on the base embedding level
978 following a character whose directionality is the same as the
979 paragraph's. This avoids running the expensive loop when a line
980 ends in a long sequence of neutrals, like control characters.
981 Add assertion against STRONG_AL type. Slightly rearrange code
982 that determines the type of a neutral given the first non-neutral
983 that follows it.
984 (bidi_level_of_next_char): Set next_en_pos to zero when
985 invalidating its info.
986
2c91f553
EZ
9872011-10-17 Eli Zaretskii <eliz@gnu.org>
988
989 * xdisp.c (push_display_prop): Determine whether to record string
990 or buffer position by IT->string, not by IT->method. Allow
991 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
992 (move_it_vertically_backward): Don't look for character position
993 immediately after the newline when in a continuation line.
994 (Bug#9771, part 1)
2c91f553 995
c7b08b0d
MR
9962011-10-15 Martin Rudalics <rudalics@gmx.at>
997
998 * window.c (coordinates_in_window): Rewrite and delabelize
999 vertical border check. (Bug#5357) (Bug#9618)
1000
6b02f655
SM
10012011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1002
1003 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1004 errors in XSetWindowBorder (bug#9310).
1005
81d40c92
DA
10062011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1007
1008 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1009 avoid crash when xmalloc overrun checking is enabled.
1010
d4172c3b
EZ
10112011-10-13 Eli Zaretskii <eliz@gnu.org>
1012
1013 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1014 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1015 cursor motion with <left> and <right> arrow keys.
1016
1017 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1018 some callers set that themselves.
1019
b00eea75
EZ
10202011-10-12 Eli Zaretskii <eliz@gnu.org>
1021
1022 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1023 display string and the previous row comes from the same string and
1024 is empty. (Bug#9739) (Bug#9738)
1025
8fe012c4
SM
10262011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1027
1028 * doc.c (get_doc_string): Encode file name (bug#9735).
1029
0074aef2
EZ
10302011-10-12 Eli Zaretskii <eliz@gnu.org>
1031
79beb178
EZ
1032 * bidi.c (bidi_level_of_next_char):
1033 * xdisp.c (get_visually_first_element): Remove old incorrect
1034 comments regarding the Unicode Line Separator character.
1035
0074aef2
EZ
1036 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1037
6e4b3fbe
DA
10382011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1039
1040 * alloc.c (Fgc_status): Do not access beyond zombies array
1041 boundary if nzombies > MAX_ZOMBIES.
1042 * alloc.c (dump_zombies): Add missing format specifier.
1043
0324f3af
PE
10442011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1045
b5525cac
PE
1046 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1047 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1048
0324f3af
PE
1049 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1050 Some packages use them to denote characters with modifiers.
1051
e9b5f888
AS
10522011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1053
1054 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1055 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1056 matching a pp-number. Rename parameter var to var1.
1057
127827c0
SM
10582011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1059
1060 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1061
c8fd3bd0
GM
10622011-10-08 Glenn Morris <rgm@gnu.org>
1063
1064 * callint.c (Fcall_interactively): Give a more explicit error for the
1065 'c' case with a non-character input. (Bug#8479)
1066
352ec8ff
EZ
10672011-10-08 Eli Zaretskii <eliz@gnu.org>
1068
03669ccb
EZ
1069 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1070 lines.
7061c986
EZ
1071 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1072 lines that are hscrolled on the left.
03669ccb 1073
352ec8ff
EZ
1074 * dispnew.c (buffer_posn_from_coords): Account for a possible
1075 presence of header-line. (Bug#4426)
1076
a66cfb1c
SM
10772011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1078
6b02f655
SM
1079 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1080 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1081
7c5ee88e
PE
10822011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1083
1084 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1085 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1086 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1087 this makes Emacs dump core during garbage collection on rare
1088 occasions. sizeof is obviously inferior to offsetof here, so
1089 stick with offsetof.
1090 (GC_POINTER_ALIGNMENT): New macro.
1091 (mark_memory): Omit 3rd (offset) arg; caller changed.
1092 Don't assume EMACS_INT alignment is the same as pointer alignment.
1093
df1bbe5b
SM
10942011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1095
1096 * keyboard.c (read_key_sequence_remapped): New var.
1097 (read_key_sequence): Compute remapping in the right buffer.
1098 (command_loop_1): Use read_key_sequence's remapping directly.
1099
51553db6
SM
11002011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1101
32c1fffd
SM
1102 * dired.c (file_name_completion): Don't expand file name.
1103 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1104 before checking file name handler.
1105
51553db6
SM
1106 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1107 they've been requested explicitly (bug#9591).
1108
b6bd1599 11092011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1110
1111 * keymap.c (Fsingle_key_description): Use make_specified_string
1112 instead of build_string to build string from push_key_description.
1113 (Bug#5193)
1114
f701dc2a
PE
11152011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1116
4222c55d
PE
1117 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1118 This fixes a Y2038 bug on 64-bit hosts.
1119 * buffer.c (reset_buffer):
1120 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1121 (Fclear_buffer_auto_save_failure):
1122 Use 0, not -1, to represent an unset failure time, since time_t
1123 might not be signed.
1124
f701dc2a
PE
1125 Remove dependency on glibc malloc internals.
1126 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1127 Move back here from lisp.h, but with their new implementations.
1128 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1129 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1130 * charset.c (charset_table_init): New static var.
1131 (syms_of_charset): Use it instead of xmalloc. This removes a
1132 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1133 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1134 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1135 Move back to alloc.c.
1136 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1137 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1138
9ceebf39
JD
11392011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1140
1141 * nsterm.m (windowDidResize): Call x_set_window_size only when
1142 ns_in_resize is true. Otherwise set pixelwidth/height and
1143 call change_frame_size (Bug#9628).
1144
cb993c58
PE
11452011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1146
3930c88b
PE
1147 Port --enable-checking=all to Fedora 14 x86-64.
1148 * charset.c (syms_of_charset): Also account for glibc malloc's
1149 internal overhead when calculating the initial malloc maximum.
1150
cb993c58
PE
1151 Port --enable-checking=all to Fedora 14 x86.
1152 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1153 Move to lisp.h.
1154 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1155 (overrun_check_realloc, overrun_check_free):
1156 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1157 That way, xmalloc returns a properly-aligned pointer even if
1158 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1159 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1160 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1161 into account when calculating the initial malloc maximum.
1162 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1163 Move here from alloc.c, so that charset.c can use it too.
1164 Properly align; the old code wasn't right for common 32-bit hosts
1165 when configured with --enable-checking=all.
1166 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1167 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1168
31bed486
EZ
11692011-09-29 Eli Zaretskii <eliz@gnu.org>
1170
04c70788 1171 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1172 use EDOM.
1173
fbcaa2f3
EZ
11742011-09-28 Eli Zaretskii <eliz@gnu.org>
1175
1176 * xdisp.c (compute_display_string_end): If there's no display
1177 string at CHARPOS, return -1.
1178
1179 * bidi.c (bidi_fetch_char): When compute_display_string_end
1180 returns a negative value, treat the character as a normal
1181 character not covered by a display string. (Bug#9624)
1182
a239d4e9
JB
11832011-09-28 Juanma Barranquero <lekktu@gmail.com>
1184
1185 * lread.c (Fread_from_string): Fix typo in docstring.
1186
88652fd5
EZ
11872011-09-27 Eli Zaretskii <eliz@gnu.org>
1188
1189 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1190 newline, reseat the iterator instead of bidi-iterating there one
1191 character at a time. (Bug#9610)
32c1fffd
SM
1192 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1193 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1194
ed497dd4
AS
11952011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1196
1197 * lread.c (readevalloop): Use correct code for NBSP.
1198 (read1): Likewise. (Bug#9608)
1199
b2bf61aa
MA
12002011-09-25 Michael Albinus <michael.albinus@gmx.de>
1201
1202 * dbusbind.c (Fdbus_register_signal): When service is not
1203 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1204
32bbb17c
GM
12052011-09-25 Glenn Morris <rgm@gnu.org>
1206
1207 * buffer.c (truncate-lines): Doc fix.
1208
94e0933e
CY
12092011-09-24 Chong Yidong <cyd@stupidchicken.com>
1210
1211 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1212 (Fset_window_next_buffers): Doc fix.
1213
cddde921
GM
12142011-09-24 Glenn Morris <rgm@gnu.org>
1215
1216 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1217
1260aef1
PE
12182011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1219
25b4bfa0
PE
1220 Fix minor problems found by static checking.
1221 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1222 * indent.c (Fvertical_motion): Fix == vs = typo.
1223
e3cbd34b
EZ
12242011-09-24 Eli Zaretskii <eliz@gnu.org>
1225
a66cfb1c
SM
1226 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1227 Default value is now t. Doc fix.
6bf7006f 1228
e3cbd34b 1229 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1230 logic when moving up, not only when moving down. Fix the
e3cbd34b 1231 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1232 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1233
1234 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1235 CHARPOS is covered by a display string which includes newlines.
1236 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1237 is covered by a display string with embedded newlines.
1238
a3de0cbd
MA
12392011-09-24 Michael Albinus <michael.albinus@gmx.de>
1240
1241 * dbusbind.c (Fdbus_register_signal): Add match rule to
1242 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1243 (Fdbus_register_method, Vdbus_registered_objects_table):
1244 Fix docstring.
a3de0cbd 1245
b260039d
JM
12462011-09-24 Jim Meyering <meyering@redhat.com>
1247
32c1fffd 1248 do not ignore write error for any output size
b260039d
JM
1249 The previous change was incomplete.
1250 While it makes emacs --batch detect the vast majority of stdout
1251 write failures, errors were still ignored whenever the output size is
1252 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1253 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1254 && echo FAIL: ignored write error
1255 FAIL: ignored write error
1256 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1257 && echo FAIL: ignored write error
1258 FAIL: ignored write error
1259 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1260
8eca8a7c
AS
12612011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1262
1263 * emacs.c (Fkill_emacs): In noninteractive mode exit
1264 non-successfully if a write error occurred on stdout. (Bug#9574)
1265
3341db62
EZ
12662011-09-21 Eli Zaretskii <eliz@gnu.org>
1267
1268 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1269 the xassert test.
1270
1271 * dispextern.h (struct it): Update the comment documenting what
1272 can it->OBJECT be.
1273
8c203dbf
EZ
12742011-09-20 Eli Zaretskii <eliz@gnu.org>
1275
1276 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1277 a display string, extend search for cursor position to end of row.
1278 (find_row_edges): If the row ends in a newline from a display
1279 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1280 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1281 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1282 non-empty line. Fixes confusing cursor motion with arrow keys at
1283 the beginning of a line that starts with whitespace.
8c203dbf 1284
a4824228
LMI
12852011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1286
1287 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1288 (bug#9493).
1289
33ed493b
CY
12902011-09-18 Chong Yidong <cyd@stupidchicken.com>
1291
1292 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1293 boolean (Bug#9154).
1294
56cd55c8
EZ
12952011-09-18 Eli Zaretskii <eliz@gnu.org>
1296
1297 * xdisp.c (display_line): Record maximum and minimum buffer
1298 positions even if no glyphs were produced (e.g., by a zero-width
1299 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1300 buffer positions that will be removed from the glyph row because
1301 they don't fit.
c02dcedf
EZ
1302 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1303 column is beyond frame width: don't subtract 1 "pixel" when
1304 computing width of the stretch.
3e62b7e0
EZ
1305 (reseat_at_next_visible_line_start): Undo the change made on
1306 2011-09-17 that saved paragraph information and restored it after
1307 the call to `reseat'. (Bug#9545)
56cd55c8 1308
5ed99d36 13092011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1310
1311 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1312 and turn window cursor on if cleared (Bug#9415).
1313
5ed99d36 13142011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1315
1316 * search.c (boyer_moore): Take unibyte characters from pattern
1317 literally. (Bug#9458)
1318
9bade7b2
EZ
13192011-09-18 Eli Zaretskii <eliz@gnu.org>
1320
1321 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1322
e5e9d610
PE
13232011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1324
87e4427a
PE
1325 Fix minor problem found by static checking.
1326 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1327 initialized, to pacify gcc -Wuninitialized.
1328
e5e9d610
PE
1329 * fileio.c: Report proper errno when syscall falls.
1330 (Finsert_file_contents): Save and restore errno,
1331 so that report_file_error outputs the correct diagnostic.
1332 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1333
a1674f0b
EZ
13342011-09-18 Eli Zaretskii <eliz@gnu.org>
1335
1336 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1337
fbfb6dd4
EZ
13382011-09-17 Eli Zaretskii <eliz@gnu.org>
1339
1340 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1341 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1342
bb187662
EZ
13432011-09-17 Eli Zaretskii <eliz@gnu.org>
1344
1137e8b8 1345 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1346 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1347
1348 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1349 (bidi_find_paragraph_start): Search back for paragraph beginning
1350 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1351 (bidi_move_to_visually_next): Only trigger paragraph-related
1352 computations when the last character is a newline or at EOB, not
1353 just any NEUTRAL_B. (Bug#9470)
1354
bb187662
EZ
1355 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1356 truncated lines if point is covered by a display string. (Bug#9524)
1357
2e621251
PE
13582011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1359
1360 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1361 (cons_to_x_long): New function.
1362 (lisp_data_to_selection_data): Use it. Correct the test for
1363 short-versus-long data; it was negated. Break out of vector
1364 loop, for efficiency, when a long datum is discovered.
1365
91a15bc6
SM
13662011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1367
1368 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1369
b41c3a35
EZ
13702011-09-16 Eli Zaretskii <eliz@gnu.org>
1371
1372 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1373 GCC PR/17406) by declaring this function with external scope.
1374
7812ba2d
PE
13752011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1376
1377 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1378 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1379
cf7edc2a
AS
13802011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1381
1382 * editfns.c (Fformat): Correctly handle text properties on "%%".
1383
bd01620e
EZ
13842011-09-15 Eli Zaretskii <eliz@gnu.org>
1385
1386 * xterm.c (x_draw_composite_glyph_string_foreground):
1387 * w32term.c (x_draw_composite_glyph_string_foreground):
1388 * term.c (encode_terminal_code):
1389 * composite.c (composition_update_it, get_composition_id):
1390 * xdisp.c (get_next_display_element)
1391 (fill_composite_glyph_string): Add comments about special meaning
1392 of TAB characters in a composition.
1393
a02719a3
PE
13942011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1395
1396 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1397 This occurs when processing a multibyte format.
1398 Problem reported by Wolfgang Jenker.
a02719a3 1399
72589a3c
JB
14002011-09-15 Johan Bockgård <bojohan@gnu.org>
1401
1402 * xdisp.c (try_cursor_movement): Only check for exact match if
1403 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1404
1c14176c
PE
14052011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1406
1407 Remove unused external symbols.
1408 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1409 * xdisp.c (calc_pixel_width_or_height): Now static.
1410 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1411 * indent.c (check_display_width):
1412 * w32term.c: Fix comment to match code.
1413 * xterm.c, xterm.h (x_catching_errors): Remove.
1414
d2eea5b5
PE
14152011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1416
1417 * xselect.c: Use signed conversions more consistently (Bug#9498).
1418 (selection_data_to_lisp_data): Assume incoming selection data are
1419 signed integers, not unsigned. This is to be consistent with
1420 outgoing selection data, which was modified to use signed integers
1421 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1422 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1423 expects long, not unsigned long.
1424
46888499
EZ
14252011-09-14 Eli Zaretskii <eliz@gnu.org>
1426
1427 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1428 computation of loop end. Reported by Johan Bockgård
1429 <bojohan@gnu.org>.
1430
ef8ef9fb
CY
14312011-09-13 Chong Yidong <cyd@stupidchicken.com>
1432
1433 * frame.c (Fother_visible_frames_p): Function deleted.
1434
fa819fed
EZ
14352011-09-12 Eli Zaretskii <eliz@gnu.org>
1436
1437 * indent.c (compute_motion): Process display vector front to back
1438 rather than the other way around. (Bug#2496)
1439
2ba8e008
SM
14402011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1441
1442 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1443
20f53c69
CY
14442011-09-11 Chong Yidong <cyd@stupidchicken.com>
1445
1446 * minibuf.c (Fread_from_minibuffer): Doc fix.
1447
d562d7a4
EZ
14482011-09-11 Eli Zaretskii <eliz@gnu.org>
1449
1450 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1451 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1452
1c4d7f3d
LMI
14532011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1454
1455 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1456 value for non-existent files.
1457
b885bf36
EZ
14582011-09-11 Eli Zaretskii <eliz@gnu.org>
1459
1460 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1461 set its "size" to -1. This will set the modtime_size field of
1462 the corresponding buffer to -1, which is what
1463 verify-visited-file-modtime expects for files that do not exist.
1464 (Bug#9139)
1465
6612f0bf
PE
14662011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1467
1468 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1469 here ...
1470 * lisp.h: ... from here. push_key_description is no longer
1471 defined in keyboard.c, so its declaration should not be in
1472 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1473 logically belongs with push_key_description.
1474
dfb3f755
PE
14752011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1476
1477 * buffer.h: Include <sys/types.h> instead of <time.h>.
1478 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1479 Problem reported by Herbert J. Skuhra.
1480
3134906c
LMI
14812011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1482
1483 * xml.c (parse_region): Make the parsing work for
1484 non-comment-starting XML files again (bug#9144).
1485
8d903f4e
AS
14862011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1487
1488 * image.c (gif_load): Fix calculation of bottom and right corner.
1489 (Bug#9468)
1490
80ad64f4
EZ
14912011-09-10 Eli Zaretskii <eliz@gnu.org>
1492
1493 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1494 redisplay in small windows.
1495
208a048d
EZ
14962011-09-09 Eli Zaretskii <eliz@gnu.org>
1497
1498 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1499
9b1c252e
MR
15002011-09-08 Martin Rudalics <rudalics@gmx.at>
1501
1502 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1503 Operate on live windows only.
1504
2949f33b
JB
15052011-09-08 Juanma Barranquero <lekktu@gmail.com>
1506
1507 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1508
e08dcafd
EZ
15092011-09-07 Eli Zaretskii <eliz@gnu.org>
1510
1511 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1512 only under bidi iteration.
1513
115b96bd
JD
15142011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1515
1516 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1517
c8199d0f
PE
15182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1521 Without this fix, the command to link temacs failed due to an
1522 undefined symbol __builtin_isnan. This is because
1523 /usr/include/iso/math_c99.h #defines isnan(x) to
1524 __builtin_isnan(x), but the bundled gcc, which identifies itself
1525 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1526 a __builtin_isnan.
1527 * floatfns.c (isnan): #undef, and then #define to a clone of
1528 what's in data.c.
1529 (Fisnan): Always define, since it's always available now.
1530 (syms_of_floatfns): Always define isnan at the Lisp level.
1531
e39b275c 15322011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1533
1534 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1535
b2db44d9 15362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1537
f4af5137 1538 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1539 The previous code assumed that file offsets (off_t values) fit in
1540 EMACS_INT variables, which is not true on typical 32-bit hosts.
1541 The code messed up by falsely reporting buffer overflow in cases
1542 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1543 when "big" contains more than 2**29 bytes, even though this
1544 inserts just one byte and does not overflow the buffer.
1545 (Finsert_file_contents): Store file offsets as off_t
1546 values, not as EMACS_INT values. Check for overflow when
1547 converting between EMACS_INT and off_t. When checking for
1548 buffer overflow or for overlap, take the offsets into account.
1549 Don't use EMACS_INT for small values where int suffices.
1550 When checking for overlap, fix a typo: ZV was used where
1551 ZV_BYTE was intended.
1552 (Fwrite_region): Don't assume off_t fits into 'long'.
1553 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1554
ecfc0a49
MA
15552011-09-05 Michael Albinus <michael.albinus@gmx.de>
1556
1557 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1558
6511acf2 15592011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1560
0999621a 1561 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1562
1563 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1564 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1565 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1566 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1567 (modify_event_symbol): Do not assume that the length of
1568 name_alist_or_stem is safe to alloca and fits in int.
1569 (Fexecute_extended_command): Likewise for function name and binding.
1570 (Frecursion_depth): Wrap around reliably on integer overflow.
1571 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1572 since some callers pass EMACS_INT values.
1573 (Fsingle_key_description): Don't crash if symbol name contains more
1574 than MAX_ALLOCA bytes.
1575 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1576 (get_minibuffer): Arg is now EMACS_INT, not int.
1577 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1578 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1579 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1580
2be7d702
PE
1581 * dbusbind.c (signature_cat): New function.
1582 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1583 Do not overrun buffer; instead, report string overflow.
1584
9d1df220
PE
1585 * dispnew.c (add_window_display_history): Don't overrun buffer.
1586 Truncate instead; this is OK since it's just a log.
1587
33ef5c64
PE
1588 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1589 even if the time zone offset is outlandishly large.
1590 Don't mishandle offset == INT_MIN.
1591
66c6fdd5
PE
1592 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1593 when creating daemon; the previous buffer-overflow check was incorrect.
1594
d749b01b
PE
1595 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1596 which has the guts of the old verror function.
1597
b5cd1905
PE
1598 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1599 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1600
6e1a67fb
PE
1601 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1602 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1603 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1604 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1605 length of string rather than counting it via multiple sprintfs;
1606 that's simpler and more reliable.
c21721cc
PE
1607 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1608 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1609 sprintf, in case result does not fit in int.
1610
c57b67fc
PE
1611 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1612 (fontset_from_font): Print it.
1613
8a401434
PE
1614 * frame.c (tty_frame_count): Now printmax_t, not int.
1615 (make_terminal_frame, set_term_frame_name): Print it.
1616 (x_report_frame_params): In X, window IDs are unsigned long,
1617 not signed long, so print them as unsigned.
1618 (validate_x_resource_name): Check for implausibly long names,
1619 and don't assume name length fits in 'int'.
1620 (x_get_resource_string): Don't blindly alloca invocation name;
1621 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1622 not fit in int.
1623
6e1a67fb
PE
1624 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1625 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1626 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1627
0df02bf3
PE
1628 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1629 Use esprintf, not sprintf, in case result does not fit in int.
1630
48e30793
PE
1631 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1632 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1633 it as a large positive number.
1634 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1635 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1636
a66ff6d8
PE
1637 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1638 in case result does not fit in int.
1639
aca216ff
PE
1640 * print.c (float_to_string): Detect width overflow more reliably.
1641 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1642 buffer overrun. Don't assume list length fits in 'int'. Treat
1643 print length of 0 as 0, not as infinity; to be consistent with other
1644 uses of print length in this function. Don't overflow print length
1645 index. Don't assume hash table size fits in 'long', or that
1646 vectorlike size fits in 'unsigned long'.
1647
31c286f7
PE
1648 * process.c (make_process): Use printmax_t, not int, to format
1649 process-name gensyms.
1650
55e5faa1
PE
1651 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1652
80f2e268
PE
1653 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1654 to avoid potential buffer overrun.
1655
670741ab
PE
1656 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1657 if X resource line is longer than 512 bytes.
1658
b7163a50
PE
1659 * xfns.c (x_window): Make sprintf buffer a bit bigger
1660 to avoid potential buffer overrun.
1661
ae58ff1f
PE
1662 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1663
c43c8a6a
PE
1664 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1665
3f8236f4
PE
16662011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1667
53e9fe90 1668 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1669 Without these, Emacs silently mishandles large integers sometimes.
1670 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1671 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1672
6511acf2
PE
1673 * xdisp.c (try_window_id): Check Emacs fixnum range before
1674 converting to 'int'.
806add1d 1675
6511acf2 1676 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1677 Check that an Emacs fixnum is in range before assigning it to 'int'.
1678 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1679 values converted from Emacs fixnums.
1680 (Frecenter): Don't wrap around a line count if it is out of 'int'
1681 range; instead, treat it as an extreme value.
1682 (Fset_window_configuration, compare_window_configurations):
1683 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1684
6511acf2
PE
1685 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1686 that can exceed INT_MAX. Check that EMACS_INT value is in range
1687 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1688 (match_limit): Don't assume that a fixnum can fit in 'int'.
1689
6511acf2 1690 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1691 exceed INT_MAX.
1692
6511acf2 1693 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1694 (Fvertical_motion): Don't wrap around LINES values that don't fit
1695 in 'int'. Instead, treat them as extreme values. This is good
1696 enough for windows, which can't have more than INT_MAX lines anyway.
1697
fcb901a7
LMI
16982011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1699
0f2f6b6d
LMI
1700 * Require libxml/parser.h to avoid compilation warning.
1701
fcb901a7
LMI
1702 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1703
1704 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1705 since this reportedly can destroy thread storage.
1706
6e20a0d4
CY
17072011-08-30 Chong Yidong <cyd@stupidchicken.com>
1708
1709 * syntax.c (find_defun_start): Update all cache variables if
1710 exiting early (Bug#9401).
1711
148ae00e
EZ
17122011-08-30 Eli Zaretskii <eliz@gnu.org>
1713
f6cfbd8f
EZ
1714 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1715
148ae00e
EZ
1716 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1717 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1718 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1719
1720 * term.c (tty_append_glyph): New function.
1721 (produce_stretch_glyph): Static function and its prototype deleted.
1722
a66cfb1c
SM
1723 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1724 Add prototypes.
148ae00e 1725
c4a07a4c
PE
17262011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1727
1728 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1729 when checking :margin (Bug#9390).
1730 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1731 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1732 so that the name doesn't mislead. All uses changed.
1733
6bc8cd65
JB
17342011-08-28 Johan Bockgård <bojohan@gnu.org>
1735
1736 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1737 set_tty_hooks.
1738
dca4927e
EZ
17392011-08-27 Eli Zaretskii <eliz@gnu.org>
1740
1741 * xdisp.c (move_it_to): Don't bail out early when reaching
1742 position beyond to_charpos, if we are scanning backwards.
1743 (move_it_vertically_backward): When DY == 0, make sure we get to
1744 the first character in the line after the newline.
1745
f2cad773
PE
17462011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1747
1748 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1749 (ccl_driver): Do not generate an out-of-range pointer.
1750 (Fccl_execute_on_string): Remove unnecessary check for
1751 integer overflow, noted by Stefan Monnier in
1752 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1753 Remove a FIXME that didn't need fixing.
1754 Simplify the newly-introduced buffer reallocation code.
1755
0cae2cdb
JB
17562011-08-27 Juanma Barranquero <lekktu@gmail.com>
1757
1758 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1759
5fc295a4 17602011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1761
70c60eb2 1762 Integer and memory overflow issues (Bug#9196).
726e0ab1 1763
d31850da
PE
1764 * doc.c (get_doc_string): Rework so that
1765 get_doc_string_buffer_size is the actual buffer size, rather than
1766 being 1 less than the actual buffer size; this makes xpalloc more
1767 convenient.
1768
a69fbedb
PE
1769 * image.c (x_allocate_bitmap_record, cache_image):
1770 * xselect.c (Fx_register_dnd_atom):
1771 Simplify previous changes by using xpalloc.
1772
fe5c5d37
PE
1773 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1774 since either will do and ptrdiff_t is convenient with xpalloc.
1775
0065d054
PE
1776 * charset.c (charset_table_size)
1777 (struct charset_sort_data.priority): Now ptrdiff_t.
1778 (charset_compare): Don't overflow if priorities differ greatly.
1779 (Fsort_charsets): Don't assume list length fits in int.
1780 Check for size-calculation overflow when allocating sort data.
1781 (syms_of_charset): Allocate an initial charset table that is
1782 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1783
1784 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1785
1786 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1787 The actual value is always <= INT_MAX, and leaving it unsigned made
1788 overflow checking harder.
1789
1790 * dispextern.h (struct glyph_matrix.rows_allocated)
1791 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1792 with xpalloc. The values are still always <= INT_MAX.
1793
1794 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1795
1796 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1797 (SAFE_NALLOCA): New macro.
1798
1799 * region-cache.c (struct boundary.pos, find_cache_boundary)
1800 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1801 (set_cache_region, invalidate_region_cache)
1802 (revalidate_region_cache, know_region_cache, region_cache_forward)
1803 (region_cache_backward, pp_cache):
1804 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1805 so that ptrdiff_t * can be passed to xpalloc.
1806 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1807 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1808 (pp_cache): Don't assume cache_len fits in int.
1809 * region-cache.h: Adjust extern decls to match.
1810
1811 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1812 EMACS_INT, since either will do, for xpalloc.
1813
1814 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1815 (xnmalloc, xnrealloc, xpalloc): New functions.
1816
726e0ab1
PE
1817 * bidi.c (bidi_shelve_header_size): New constant.
1818 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1819 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1820
51f30bc5 1821 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1822 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1823 (overlay_strings):
1824 Don't update size of array until after memory allocation succeeds,
1825 because xmalloc/xrealloc may not return.
0065d054
PE
1826 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1827 now that we have proper integer overflow checking.
1828 (record_overlay_string, overlay_strings): Catch overflows when
1829 calculating size of overlay_str_buf.
726e0ab1 1830
0065d054
PE
1831 * callproc.c (Fcall_process): Check for size overflow when
1832 calculating size of args2.
1833 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1834 Normally we prefer signed values, but sticking with ptrdiff_t would
1835 require adding more-complicated checks.
726e0ab1
PE
1836
1837 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1838 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1839 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1840 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1841
1842 * character.c (Fstring): Check for size-calculation overflow.
1843
1844 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1845 unnecessary integer overflow. Check for size overflow.
1846 (encode_coding_object): Don't update size until xmalloc succeeds.
1847
1848 * composite.c (get_composition_id): Check for overflow in glyph
1849 length calculations.
1850
1851 Integer and memory overflow fixes for display code.
1852 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1853 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1854 (scrolling_window): Check for overflow in size calculations.
1855 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1856 Don't assume glyph table len fits in int.
1857 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1858 (row_table_size): Now ptrdiff_t, not int.
1859 (scrolling_window): Avoid overflow in size calculations.
1860 Don't update size until allocation succeeds.
1861 * fns.c (concat): Check for overflow in size calculations.
1862 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1863 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1864 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1865
1866 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1867 (get_doc_string): Check for size calculation overflow.
1868 Don't update size until allocation succeeds.
1869 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1870 EMACS_INT, where ptrdiff_t will do.
1871 (Fsubstitute_command_keys): Check for string overflow.
1872
1873 * editfns.c (set_time_zone_rule): Don't assume environment length
1874 fits in int.
1875 (message_length): Now ptrdiff_t, not int.
1876 (Fmessage_box): Don't update size until allocation succeeds.
1877 Don't assume message length fits in int.
1878 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1879
0065d054
PE
1880 * emacs.c (main): Do not reallocate argv, since there is a null at
1881 the end that can be overwritten, and this way there's no need to
1882 worry about size-calculation overflow.
1883 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1884
1885 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1886 alloc succeeds.
1887 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1888
1889 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1890 (x_set_scroll_bar_width, x_figure_window_size):
1891 Check for integer overflow.
1892 (x_set_alpha): Do not assume XINT fits in int.
1893
1894 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1895 This is for the members text_lines, text_cols, total_lines, total_cols,
1896 where the system imposes an 'int' limit.
1897
1898 * fringe.c (Fdefine_fringe_bitmap):
1899 Don't update size until alloc works.
1900
1901 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1902 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1903
1904 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1905 Check for size-calculation overflow.
1906 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1907 do, as we prefer signed integers.
1908 (id_to_widget.max_size, id_to_widget.used)
1909 (xg_store_widget_in_map, xg_remove_widget_from_map)
1910 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1911 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1912 Use and return ptrdiff_t, not int.
1913 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1914 * gtkutil.h: Change prototypes to match the above.
1915
1916 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1917 are duplicate now that they've been promoted to lisp.h.
1918 (x_allocate_bitmap_record, x_alloc_image_color)
1919 (make_image_cache, cache_image, xpm_load):
1920 Don't update size until alloc is done.
1921 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1922 (x_detect_edges):
3256efce 1923 Check for size calculation overflow.
726e0ab1
PE
1924 (ct_colors_allocated_max): New constant.
1925 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1926 overflow.
3256efce 1927
726e0ab1
PE
1928 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1929 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1930 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1931 Use ptrdiff_t, not int, to count maps.
1932 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1933 calculations. Don't update size until allocation succeeds.
1934 Redo calculations to avoid overflow.
726e0ab1
PE
1935 * keyboard.h: Change prototypes to match the above.
1936
1937 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1938 to count maps.
1939 (current_minor_maps): Check for size calculation overflow.
1940 * keymap.h: Change prototypes to match the above.
1941
1942 * lread.c (read1, init_obarray): Don't update size until alloc done.
1943
1944 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1945 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1946
726e0ab1
PE
1947 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1948 Now ptrdiff_t, not int.
1949 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1950 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1951
1952 * process.c (Fnetwork_interface_list): Check for overflow
1953 in size calculation.
1954
1955 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1956
1957 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1958 overflow. Don't bother calling xmalloc when xrealloc will do.
1959
1960 * search.c (Freplace_match): Check for size calculation overflow.
1961 (Fset_match_data): Don't assume list lengths fit in 'int'.
1962
1963 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1964 for command line length. Do not attempt to address one before the
1965 beginning of an array, as that's not portable.
1966
1967 * term.c (max_frame_lines): Remove; unused.
1968 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1969 not int.
1970 (encode_terminal_code, calculate_costs): Check for size
1971 calculation overflow.
1972 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1973 table lengths and related sizes. Don't update size until alloc
1974 done. Redo calculations to avoid overflow.
1975 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1976
1977 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1978 subtracting pointers.
1979 (gobble_line): Check for overflow more carefully. Don't update size
1980 until alloc done.
1981
1982 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1983 Don't update size until alloc done.
1984 Redo size calculations to avoid overflow.
1985 Check for size calculation overflow.
0065d054 1986 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1987
1988 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1989 Use ptrdiff_t, not int, for sizes.
1990 (store_mode_line_noprop_char): Don't update size until alloc done.
1991
0065d054
PE
1992 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1993 Use ptrdiff_t, not int, for sizes.
1994 (Finternal_make_lisp_face, cache_face):
1995 Check for size calculation overflow.
1996 (cache_face): Treat size calculation overflows as if they were
1997 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1998
1999 * xfns.c (x_encode_text, x_set_name_internal)
2000 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2001 sizes, since they can exceed INT_MAX in size. Check for size
2002 calculation overflow.
2003
0065d054
PE
2004 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2005 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2006 Don't update size until alloc done.
2007
0065d054 2008 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2009 as sprintf is limited to int lengths.
1d526e2f 2010
252c5ee1
PE
2011 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2012 (X_LONG_MIN): New macros.
864d7ce7
PE
2013 Use them to make the following changes clearer.
2014 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2015 This change doesn't affect the value now, but it may help remind
2016 future maintainers not to raise the value too much later.
2017 (SELECTION_QUANTUM): Remove, replacing with ...
2018 (selection_quantum): ... new function, which avoids overflow.
2019 All uses changed.
2020 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2021 assumption that selection length fits in 'int'.
2022 (x_reply_selection_request, x_handle_selection_request)
2023 (x_get_window_property, receive_incremental_selection)
2024 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2025 (lisp_data_to_selection_data, clean_local_selection_data):
2026 Use ptrdiff_t, not int, to record length of selection.
2027 (x_reply_selection_request, x_get_window_property)
2028 (receive_incremental_selection, x_property_data_to_lisp):
2029 Redo calculations to avoid overflow.
2030 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2031 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2032 something.
2033 (x_get_window_property, receive_incremental_selection)
2034 (lisp_data_to_selection_data, x_property_data_to_lisp):
2035 Check for size-calculation overflow.
2036 (x_get_window_property, receive_incremental_selection)
2037 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2038 Don't store size until memory allocation succeeds.
2039 (x_get_window_property): Plug memory leak on memory exhaustion.
2040 Don't double-block input; malloc is safe here. Don't assume 2**34
2041 - 4 fits in unsigned long. Add an xassert to check
2042 XGetWindowProperty overflow. Be more careful about overflow
2043 calculations, and distinguish size from memory overflow better.
2044 (receive_incremental_selection): When tracing, don't assume
2045 unsigned int is less than INT_MAX.
2046 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2047 harmful) conversions of unsigned short to int.
2048 (lisp_data_to_selection_data): Don't assume that integers
2049 in the range -65535 through -1 fit in an X unsigned short.
2050 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2051 result parameters unless successful. Rely on cons_to_unsigned
2052 to report problems with elements; the old code wasn't right anyway.
2053 (x_check_property_data): Check for int overflow; we cannot use
2054 a wider type due to X limits.
2055 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2056
726e0ab1 2057 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2058
0065d054
PE
2059 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2060 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2061 (x_color_cells): Don't store size until memory allocation succeeds.
2062 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2063 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2064 (x_term_init): Don't assume length fits in int (sprintf is limited
2065 to int size).
bc18e09d 2066
ebfa62c0
PE
2067 Use ptrdiff_t for composition IDs.
2068 * character.c (lisp_string_width):
2069 * composite.c (composition_table_size, n_compositions)
2070 (get_composition_id, composition_gstring_from_id):
2071 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2072 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2073 * window.c (Frecenter):
2074 Use ptrdiff_t, not int, for composition IDs.
2075 * composite.c (get_composition_id): Check for integer overflow.
2076 * composite.h: Adjust prototypes to match the above changes.
2077
d3411f89
PE
2078 Use ptrdiff_t for hash table indexes.
2079 * category.c (hash_get_category_set):
2080 * ccl.c (ccl_driver):
2081 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2082 * coding.c (coding_system_charset_list, detect_coding_system):
2083 * coding.h (struct coding_system.id):
2084 * composite.c (get_composition_id, gstring_lookup_cache):
2085 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2086 * image.c (xpm_get_color_table_h):
2087 * lisp.h (hash_lookup, hash_put):
2088 * minibuf.c (Ftest_completion):
2089 Use ptrdiff_t for hash table indexes, not int (which is too
2090 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2091 32-bit --with-wide-int hosts).
2092
e097a6fa
PE
2093 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2094 Add a FIXME comment about memory leaks.
2095 (syms_of_charset): Don't assume xmalloc returns.
2096
5637687f
PE
2097 Don't assume that stated character widths fit in int.
2098 * character.c (Fchar_width, c_string_width, lisp_string_width):
2099 * character.h (CHAR_WIDTH):
2100 * indent.c (MULTIBYTE_BYTES_WIDTH):
2101 Use sanitize_char_width to avoid undefined and/or bad behavior
2102 with outlandish widths.
a66cfb1c 2103 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2104 now that we have two such functions. All uses changed.
2105 (sanitize_char_width): New inline function.
2106
a2271ba2
PE
2107 Don't assume that tab-width fits in int.
2108 * character.h (sanitize_width): New inline function.
2109 (SANE_TAB_WIDTH): New macro.
2110 (ASCII_CHAR_WIDTH): Use it.
2111 * indent.c (sane_tab_width): Remove. All uses replaced by
2112 SANE_TAB_WIDTH (current_buffer).
2113 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2114
18c52557
PE
2115 * fileio.c: Integer overflow issues with file modes.
2116 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2117
caeeedc1
PE
2118 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2119 Remove unreachable code.
2120 (read_hex, load_charset_map_from_file): Check for integer overflow.
2121
50849c52
PE
2122 * xterm.c: don't go over XClientMessageEvent limit
2123 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2124 (x_send_scroll_bar_event): Likewise. Check that the size does not
2125 exceed limits imposed by XClientMessageEvent, as well as the usual
2126 ptrdiff_t and size_t limits.
2127
b13995db
PE
2128 * keyboard.c: Overflow, signedness and related fixes.
2129 (make_lispy_movement): Use same integer type in forward decl
2130 that is used in the definition.
2131 (read_key_sequence, keyremap_step):
2132 Change bufsize argument back to int, undoing my 2011-03-30 change.
2133 We prefer signed types, and int is wide enough here.
2134 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2135 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2136 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2137 length, not size_t. Use ptrdiff_t for index, not int.
2138 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2139 possibility of integer overflow.
2140
13464394
PE
2141 Overflow, signedness and related fixes for images.
2142
2143 * dispextern.h (struct it.stack[0].u.image.image_id)
2144 (struct_it.image_id, struct image.id, struct image_cache.size)
2145 (struct image_cache.used, struct image_cache.ref_count):
2146 * gtkutil.c (update_frame_tool_bar):
2147 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2148 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2149 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2150 * nsmenu.m (update_frame_tool_bar):
2151 * xdisp.c (calc_pixel_width_or_height):
2152 * xfns.c (image_cache_refcount):
2153 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2154 on typical 64-bit hosts.
2155
2156 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2157 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2158 Omit unnecessary casts to int.
2159 (parse_image_spec): Check that integers fall into 'int' range
2160 when the callers expect that.
2161 (image_ascent): Redo ascent calculation to avoid int overflow.
2162 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2163 (lookup_image): Remove unnecessary tests.
2164 (xbm_image_p): Locals are now of int, not EMACS_INT,
2165 since parse_image_check makes sure they fit into int.
2166 (png_load, gif_load, svg_load_image):
2167 Prefer int to unsigned where either will do.
2168 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2169 old tiff_error_handler and tiff_warning_handler.
2170 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2171 stack buffer overflows. It uses only the features of vsnprintf
2172 that are common to both POSIX and native Microsoft.
2173 (tiff_error_handler, tiff_warning_handler): Use it.
2174 (tiff_load, gif_load, imagemagick_load_image):
2175 Don't assume :index value fits in 'int'.
2176 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2177 (imagemagick_load_image): Check that crop parameters fit into
2178 the integer types that MagickCropImage accepts. Don't assume
2179 Vimagemagick_render_type has a nonnegative value. Don't assume
2180 size_t fits in 'long'.
2181 (gs_load): Use printmax_t to print the widest integers possible.
2182 Check for integer overflow when computing image height and width.
2183
c11821d4
EZ
21842011-08-26 Eli Zaretskii <eliz@gnu.org>
2185
2186 * xdisp.c (redisplay_window): Don't force window start if point
2187 will be invisible in the resulting window. (Bug#9324)
2188
0c95fcf7
EZ
21892011-08-25 Eli Zaretskii <eliz@gnu.org>
2190
2191 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2192 the display spec is of the form `(space ...)'.
2193 (handle_display_spec): Return the value returned by
2194 handle_single_display_spec, not just 1 or zero.
2195 (handle_single_display_spec): If the display spec is of the form
2196 `(space ...)', and specifies display in the text area, return 2
2197 rather than 1.
fee65a97 2198 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2199 accurately, and prefer exact match for point under bidi.
2200 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2201
2202 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2203 into disp_prop; all users changed.
2204
2205 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2206 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2207 for the text covered by the display property.
2208
e4ed06f1
CY
22092011-08-25 Chong Yidong <cyd@stupidchicken.com>
2210
2211 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2212 Change return value to nil.
2213 (Frecord_buffer): Delete unused function.
2214
f67cdd7f
EZ
22152011-08-24 Eli Zaretskii <eliz@gnu.org>
2216
5980d4c6
EZ
2217 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2218 buffers, return left-to-right.
8610fe8b
EZ
2219 (set_cursor_from_row): Consider candidate row a win if its glyph
2220 represents a newline and point is on that newline. Fixes cursor
2221 positioning on the newline at EOL of R2L text within L2R
2222 paragraph, and vice versa.
2223 (try_cursor_movement): Check continued rows, in addition to
2224 continuation rows. Fixes unwarranted scroll when point enters a
2225 continued line of R2L text within an L2R paragraph, or vice versa.
2226 (cursor_row_p): Consider the case of point being equal to
2227 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2228 from the end of a short line to the beginning of a continued line
2229 of R2L text within L2R paragraph.
2230 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2231 composed characters.
5980d4c6 2232
f67cdd7f
EZ
2233 * bidi.c (bidi_check_type): Use xassert.
2234 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2235 members.
2236
bca633fb
EZ
22372011-08-23 Eli Zaretskii <eliz@gnu.org>
2238
2239 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2240 a character.
2241
4a5885a7
CY
22422011-08-23 Chong Yidong <cyd@stupidchicken.com>
2243
2244 * nsfont.m (ns_otf_to_script): Fix typo.
2245
0902a04e
KH
22462011-08-22 Kenichi Handa <handa@m17n.org>
2247
2248 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2249 extra slot even if the purpose is char-code-property-table.
2250
1a2e6670
EZ
22512011-08-23 Eli Zaretskii <eliz@gnu.org>
2252
8ddde651
EZ
2253 * xdisp.c (redisplay_window): When computing centering_position,
2254 account for the height of the header line. (Bug#8874)
2255
425cc014
EZ
2256 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2257 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2258 candidate is selected by the mouse, and that candidate has a
2259 composed character under the mouse.
2260
1a2e6670
EZ
2261 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2262 coordinates reported by pos-visible-in-window-p for a composed
2263 character in column zero.
2264
8b76d6f8
SM
22652011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2266
2267 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2268
dac347dd
EZ
22692011-08-22 Eli Zaretskii <eliz@gnu.org>
2270
2271 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2272 consider it a hit if to_charpos is anywhere in the range of the
2273 composed buffer positions.
2274
e013fb34
CY
22752011-08-22 Chong Yidong <cyd@stupidchicken.com>
2276
2277 * image.c (gif_load): Don't assume that each subimage has the same
2278 dimensions as the base image. Handle disposal method that is
2279 "undefined" by the gif spec (Bug#9335).
2280
bd1ba3e8
CY
22812011-08-20 Chong Yidong <cyd@stupidchicken.com>
2282
2283 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2284 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2285
54a1215b
EZ
22862011-08-19 Eli Zaretskii <eliz@gnu.org>
2287
823564e5
EZ
2288 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2289 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2290 from an Org mode buffer to a Speedbar frame.
2291
54a1215b
EZ
2292 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2293 a composition, take its buffer position from IT->cmp_it.charpos.
2294 Fixes cursor positioning at the beginning of a line that begins
2295 with a composed character.
2296
9778ebcc
EZ
22972011-08-18 Eli Zaretskii <eliz@gnu.org>
2298
0be6ee06
EZ
2299 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2300 character bidirectional type, use STRONG_L instead. Fixes crashes
2301 in a buffer produced by `describe-categories'.
2302
9778ebcc
EZ
2303 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2304 members before the level stack, so they would be saved and
2305 restored when copying iterator state. Fixes incorrect reordering
2306 around TABs covered by display properties.
2307
156bffbe
AS
23082011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2309
6b02f655 2310 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2311
72ad093b
CY
23122011-08-17 Chong Yidong <cyd@stupidchicken.com>
2313
2314 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2315 (internal_condition_case_2, internal_condition_case_n):
2316 Remove unnecessary aborts (Bug#9081).
72ad093b 2317
35774242
EZ
23182011-08-17 Eli Zaretskii <eliz@gnu.org>
2319
2320 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2321 has no `load' handler, try opening the file locally. (Bug#9311)
2322
db76dd85
KB
23232011-08-16 Ken Brown <kbrown@cornell.edu>
2324
2325 * gmalloc.c: Expand comment.
2326
b215eee5
EZ
23272011-08-16 Eli Zaretskii <eliz@gnu.org>
2328
2329 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2330 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2331
a4579d33
KB
23322011-08-16 Ken Brown <kbrown@cornell.edu>
2333
2334 Fix memory allocation problems in Cygwin build (Bug#9273).
2335
2336 * unexcw.c ( __malloc_initialized): Declare external variable.
2337 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2338
8b76d6f8
SM
2339 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2340 New variables.
a4579d33
KB
2341 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2342 dumped emacs.
2343 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2344 in the static heap.
2345 [CYGWIN] (special_realloc): New function.
2346 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2347 requests to realloc storage in the static heap.
2348
3ebec551
PE
23492011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2350
2351 * bidi.c (bidi_initialize): Remove unused local.
2352
9fd8be00
EZ
23532011-08-15 Eli Zaretskii <eliz@gnu.org>
2354
6b02f655
SM
2355 * bidimirror.h:
2356 * biditype.h: Remove file.
2357 * makefile.w32-in ($(BLD)/bidi.$(O)):
2358 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2359
2360 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2361
2362 * chartab.c: Improve commentary for the uniprop_table API.
2363
32413314
EZ
2364 * bidi.c (bidi_paragraph_init): Support zero value of
2365 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2366 (bidi_initialize): Use uniprop_table instead of including
2367 biditype.h and bidimirror.h.
32413314 2368
9fd8be00
EZ
2369 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2370 coordinates of the iterator when restoring from ppos_it.
2371 (Bug#9296)
2372
5cf2b69b
KH
23732011-08-14 Kenichi Handa <handa@m17n.org>
2374
2375 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2376 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2377
daf17d00
EZ
23782011-08-14 Eli Zaretskii <eliz@gnu.org>
2379
2380 * xdisp.c (move_it_in_display_line_to): Don't invoke
2381 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2382 ppos_it. Fixes vertical cursor motion when line beginning is
2383 covered by an image. (Bug#9296)
2384
08e3161a
JD
23852011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2386
2387 * nsterm.h (ns_run_ascript): Declare.
2388 (NSAPP_DATA2_RUNASSCRIPT): Define.
2389
2390 * nsfns.m (as_script, as_result, as_status): New static variables.
2391 (ns_run_ascript): New function.
5e617bc2 2392 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2393 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2394 the event loop. Get status from as_status (Bug#7276).
2395
2396 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2397 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2398 the event loop (Bug#7276).
2399
a3720aa2
AS
24002011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2401
2402 * gnutls.c (QCgnutls_bootprop_priority)
2403 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2404 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2405 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2406 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2407 (QCgnutls_bootprop_verify_hostname_error)
2408 (QCgnutls_bootprop_callbacks_verify): Rename from
2409 Qgnutls_bootprop_..., all uses changed.
2410
2411 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2412 uses changed.
2413
0a0d27fb
PE
24142011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2415
19d5c50c
PE
2416 * xfaces.c (Qframe_set_background_mode): Now static.
2417 * dispextern.h (Qframe_set_background_mode): Remove decl.
2418
0a0d27fb
PE
2419 * process.c (Fnetwork_interface_info): Declare local only if needed.
2420
377538cb
JD
24212011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2422
2423 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2424 (Fnetwork_interface_list): Allocate in increments of bytes instead
2425 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2426 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2427 sockaddr.
2428 (struct ifflag_def): notrailers is smart on OSX.
2429 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2430 Get hardware address with getifaddrs if available.
2431
08fff70c
EZ
24322011-08-12 Eli Zaretskii <eliz@gnu.org>
2433
2434 * xdisp.c (iterate_out_of_display_property): xassert that
2435 IT->position is set to within IT->object's boundaries. Break from
2436 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2437 when IT->position is set up wrongly due to some bug.
2438 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2439 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2440 entry. Force push_it to save on the stack the current
2441 buffer/string position, to be restored by pop_it. Fix flags in
2442 the iterator structure wrt the object coming from a display
2443 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2444 properties. (Bug#9284)
2445
7be1c708 24462011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2447
7be1c708
CY
2448 * fontset.c (fontset_get_font_group): Add proper type checks.
2449 (Bug#9172)
aac0c6e3 2450
7be1c708 24512011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2452
7be1c708
CY
2453 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2454 and LC_VERSION_MIN_MACOSX.
2455 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2456 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2457
97bb72a6
EZ
24582011-08-08 Eli Zaretskii <eliz@gnu.org>
2459
2460 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2461 no-display-properties-and-no-overlays under bidi display.
2462 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2463 properties and overlays.
97bb72a6 2464
d5617611
CY
24652011-08-08 Chong Yidong <cyd@stupidchicken.com>
2466
37e11a63
CY
2467 * editfns.c (Fset_time_zone_rule): Document relationship with the
2468 setenv function.
2469
d5617611
CY
2470 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2471 the font entity extracted from the cache (Bug#8109).
2472
58872834
CY
24732011-08-07 Chong Yidong <cyd@stupidchicken.com>
2474
2475 * composite.c (autocmp_chars): Don't reset point. That is done by
2476 restore_point_unwind (Bug#5984).
2477
75bfc667
JL
24782011-08-07 Juri Linkov <juri@jurta.org>
2479
2480 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2481 to show the arg `TIME' instead of `TIMEVAL'.
2482
d1410150
EZ
24832011-08-06 Eli Zaretskii <eliz@gnu.org>
2484
2485 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2486 display property strides EOL and includes a newline, as in
2487 longlines-mode. (Bug#9254)
75b771e4
EZ
2488 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2489 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2490
2491 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2492 is non-zero, even if the data buffer is NULL. Fixes a crash in
2493 vertical-motion with longlines-mode. (Bug#9254)
2494
35928349
EZ
24952011-08-05 Eli Zaretskii <eliz@gnu.org>
2496
ec7cc85b
EZ
2497 * bidi.c <bidi_cache_total_alloc>: Now static.
2498 (bidi_initialize): Initialize bidi_cache_total_alloc.
2499
8b76d6f8 2500 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2501 cache. (Bug#9221)
2502
2503 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2504 amount allocated this far in `bidi_cache_total_alloc'.
2505 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2506 non-zero, only free the data buffer without restoring the cache
2507 contents. All callers changed.
2508
2509 * dispextern.h (bidi_unshelve_cache): Update prototype.
2510
2511 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2512 (move_it_in_display_line, move_it_to)
2513 (move_it_vertically_backward, move_it_by_lines): Replace the call
2514 to xfree to an equivalent call to bidi_unshelve_cache.
2515 (move_it_in_display_line_to): Fix logic of returning
412b6358 2516 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2517
e2e2423b
EZ
25182011-08-05 Eli Zaretskii <eliz@gnu.org>
2519
2520 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2521 came from a string character with a `cursor' property. (Bug#9229)
2522
ae9e757a
JD
25232011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2524
2525 * Makefile.in (LIB_PTHREAD): New variable.
2526 (LIBES): Add LIB_PTHREAD (Bug#9216).
2527
2528 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2529 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2530
213bd7f2
AS
25312011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2532
6b02f655 2533 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2534
99aaf75f
JD
25352011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2536
2537 * xterm.c (x_find_topmost_parent): New function.
2538 (x_set_frame_alpha): Find topmost parent window with
2539 x_find_topmost_parent and set the property there also (bug#9181).
2540 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2541
c74e9d86
PE
25422011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2543
2544 * callproc.c (Fcall_process): Avoid vfork clobbering
2545 the local vars buffer, coding_systems, current_dir.
2546
640c8776
SM
25472011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2548
2549 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2550
f26d0e4c
PE
25512011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2552
8a10d76c
PE
2553 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2554 so that it is not optimized away.
2555
f26d0e4c
PE
2556 * xdisp.c (compute_display_string_pos): Remove unused local.
2557
55439c61
EZ
25582011-08-02 Eli Zaretskii <eliz@gnu.org>
2559
2560 Fix slow cursor motion and scrolling in large buffers with
2561 selective display, like Org Mode buffers. (Bug#9218)
2562
2563 * dispextern.h (struct bidi_it): New member disp_prop_p.
2564
2565 * xdisp.c: Remove one-slot cache of display string positions.
2566 (compute_display_string_pos): Accept an additional argument
5e617bc2 2567 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2568 for a display string or property. If found, set DISP_PROP_P
2569 non-zero.
2570
2571 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2572 DISP_PROP_P, and pass it to compute_display_string_pos.
2573 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2574 non-zero. All callers of bidi_fetch_char changed.
2575
fb33fa43
SM
25762011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2577
2578 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2579
b099e063
DM
25802010-12-03 Don March <don@ohspite.net>
2581
2582 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2583 last character M-[char] is translated to ESC [char] (bug#7541).
2584
5cc7f7af
KH
25852011-08-02 Kenichi Handa <handa@m17n.org>
2586
d0fffa3f 2587 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2588
2589 * chartab.c (uniprop_table): Make it non-static.
2590
525d5e6e
EZ
25912011-08-01 Eli Zaretskii <eliz@gnu.org>
2592
2593 * xdisp.c (forward_to_next_line_start): Accept additional argument
2594 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2595 on the newline.
2596 (reseat_at_next_visible_line_start): Use the bidi iterator state
2597 returned by forward_to_next_line_start to restore the state of
2598 it->bidi_it after backing up to previous newline. (Bug#9212)
2599
31011111
AS
26002011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2601
2602 * regex.c (re_comp): Protoize.
2603 (re_exec): Fix return type.
2604 (regexec): Fix type of `ret'. (Bug#9203)
2605
476371c4
PE
26062011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2607
e5d76069
PE
2608 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2609 This is needed if max-image-size is a floating-point number.
2610
9a79b20c
AS
26112011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2612
2613 * print.c (print_object): Print empty symbol as ##.
2614
2615 * lread.c (read1): Read ## as empty symbol.
2616
d8c2fa78
AA
26172011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2618
2619 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2620 setting frame foreground color (Bug#9175).
2621 (x_set_background_color): Likewise.
2622
ffe57a7a
AA
2623 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2624 contents (Bug#9176).
2625 (EmacsTooltip -init): Remove bezels and add shadows to
2626 tooltip windows.
2627
bf3492a5
AA
2628 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2629 or scroll bar (Bug#8470).
2630
d55e9c53
AA
2631 * nsfont.m (nsfont_open): Remove assignment to voffset and
2632 unnecessary vars hshink, expand, hd, full_height, min_height.
2633 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2634
2635 * nsterm.h (nsfont_info): Remove voffset field.
2636
d8c2fa78 26372011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2638
2639 Implement strike-through and overline on NextStep (Bug#8863).
2640
2641 * nsfont.m (nsfont_open): Use underline position provided by font,
2642 instead of hard-coded value of 2.
2643 (nsfont_draw): Call ns_draw_text_decoration instead.
2644
2645 * nsterm.h: Add declaration for ns_draw_text_decoration.
2646
2647 * nsterm.m (ns_draw_text_decoration): New function for drawing
2648 underline, overline, and strike-through.
2649 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2650 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2651 accommodate underlining, etc.
4843aac3 2652
4cc60b9b
EZ
26532011-07-28 Eli Zaretskii <eliz@gnu.org>
2654
bc7ece87
EZ
2655 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2656 default.
4cc60b9b 2657
476371c4
PE
26582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2659
66606eea
PE
2660 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2661 Without this fix, if a signal arrives just after memory fills up,
2662 'malloc' might be invoked reentrantly.
2663
476371c4
PE
2664 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2665 In other words, assume that every image size is allowed, on non-X
2666 hosts. This assumption is probably wrong, but it lets Emacs compile.
2667
f3fcc40d
AS
26682011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2669
2670 * regex.c (re_iswctype): Convert return values to boolean.
2671
350c992f
EZ
26722011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2673
2674 * xdisp.c (compute_display_string_pos): Don't use cached display
2675 string position if the buffer had its restriction changed.
2676 (Bug#9184)
2677
5266b4bb
PE
26782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2679
2680 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2681
2573a837 26822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2683
41f55ccd 2684 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2685
39e378da
PE
2686 * bidi.c: Integer size and overflow fixes.
2687 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2688 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2689 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2690 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2691 (bidi_find_other_level_edge):
2692 Use ptrdiff_t instead of EMACS_INT where either will do.
2693 This works better on 32-bit hosts configured --with-wide-int.
2694 (bidi_cache_ensure_space): Check for size-calculation overflow.
2695 Use % rather than repeated addition, for better worst-case speed.
2696 Don't set bidi_cache_size until after xrealloc returns, because it
2697 might not return.
2698 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2699 (bidi_cache_ensure_space): Also check that the bidi cache size
2700 does not exceed that of the largest Lisp string or buffer. See Eli
2701 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2702
5e927815
PE
2703 * alloc.c (__malloc_size_t): Remove.
2704 All uses replaced by size_t. See Andreas Schwab's note
2705 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2706
ca4aa935
PE
2707 * image.c: Improve checking for integer overflow.
2708 (check_image_size): Assume that f is nonnull, since
2709 it is always nonnull in practice. This is one less thing to
2710 worry about when checking for integer overflow later.
2711 (x_check_image_size): New function, which checks for integer
2712 overflow issues inside X.
2713 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2714 This removes the need for a memory_full check.
2715 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2716 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2717 (xbm_read_bitmap_data): Change locals back to 'int', since
2718 their values must fit in 'int'.
2719 (xpm_load_image, png_load, tiff_load):
2720 Invoke x_create_x_image_and_pixmap earlier,
2721 to avoid much needless work if the image is too large.
2722 (tiff_load): Treat overly large images as if
2723 x_create_x_image_and_pixmap failed, not as malloc failures.
2724 (gs_load): Use x_check_image_size.
2725
5f8f9cc2
PE
2726 * gtkutil.c: Omit integer casts.
2727 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2728 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2729
5adf60bc
PE
2730 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2731
c8907a93
PE
2732 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2733 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2734 would wrongly return t on a 64-bit host.
2735
e3c25c68
PE
2736 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2737 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2738 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2739 and therefore cause GCC to emit a bogus diagnostic in some cases.
2740
3f791afe
PE
2741 * image.c: Integer signedness and overflow and related fixes.
2742 This is not an exhaustive set of fixes, but it's time to
2743 record what I've got.
2744 (lookup_pixel_color, check_image_size): Remove redundant decls.
2745 (check_image_size): Don't assume that arbitrary EMACS_INT values
2746 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2747 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2748 (tiff_load, imagemagick_load_image):
2749 Check for overflow in size calculations.
2750 (x_create_x_image_and_pixmap): Remove unnecessary test for
2751 xmalloc returning NULL; that can't happen.
2752 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2753 (xpm_color_bucket): Use better integer hashing function.
2754 (xpm_cache_color): Don't possibly over-allocate memory.
2755 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2756 (gif_memory_source):
2757 Use ptrdiff_t, not int or size_t, to record sizes.
2758 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2759 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2760 either works, as we prefer signed integers.
2761 (tiff_read_from_memory, tiff_write_from_memory):
2762 Return tsize_t, not size_t, since that's what the TIFF API wants.
2763 (tiff_read_from_memory): Don't fail simply because the read would
2764 go past EOF; instead, return a short read.
2765 (tiff_load): Omit no-longer-needed casts.
2766 (Fimagemagick_types): Don't assume size fits into 'int'.
2767
3cc5a532
PE
2768 Improve hashing quality when configured --with-wide-int.
2769 * fns.c (hash_string): New function, taken from sxhash_string.
2770 Do not discard information about ASCII character case; this
2771 discarding is no longer needed.
2772 (sxhash-string): Use it. Change sig to match it. Caller changed.
2773 * lisp.h: Declare it.
2774 * lread.c (hash_string): Remove, since we now use fns.c's version.
2775 The fns.c version returns a wider integer if --with-wide-int is
2776 specified, so this should help the quality of the hashing a bit.
2777
b312a492
PE
2778 * emacs.c: Integer overflow minor fix.
2779 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2780 Define only if GNU_LINUX.
2781 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2782
dfd153ae
PE
2783 * dispnew.c: Integer signedness and overflow fixes.
2784 Remove unnecessary forward decls, that were a maintenance hassle.
2785 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2786 All uses changed.
2787 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2788 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2789 (prepare_desired_row, line_draw_cost):
2790 Use int, not unsigned, where either works.
2791 (save_current_matrix, restore_current_matrix):
2792 Use ptrdiff_t, not size_t, where either works.
2793 (init_display): Check for overflow more accurately, and without
2794 relying on undefined behavior.
2795
a81d11a3
PE
2796 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2797 Remove, replacing with the new symbols in lisp.h. All uses changed.
2798 * fileio.c (make_temp_name):
2799 * filelock.c (lock_file_1, lock_file):
2800 * xdisp.c (message_dolog):
2801 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2802 Use pMd etc. instead.
2803 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2804 replacing the pWIDE etc. symbols removed from editfns.c.
2805
3300e6fd
PE
2806 * keyboard.h (num_input_events): Now uintmax_t.
2807 This is (very slightly) less likely to mess up due to wraparound.
2808 All uses changed.
2809
fd05c7e9
PE
2810 * buffer.c: Integer signedness fixes.
2811 (alloc_buffer_text, enlarge_buffer_text):
2812 Use ptrdiff_t rather than size_t when either will do, as we prefer
2813 signed integers.
2814
903fe15d
PE
2815 * alloc.c: Integer signedness and overflow fixes.
2816 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2817 (__malloc_size_t): Default to size_t, not to int.
2818 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2819 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2820 Prefer ptrdiff_t to size_t when either would do, as we prefer
2821 signed integers.
2822 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2823 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2824 Now const. Initialize with values that are in range even if char
2825 is signed.
2826 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2827 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2828 These functions do the right thing with sizes > 2**32.
2829 (check_depth): Now ptrdiff_t, not int.
2830 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2831 Adjust to new way of storing sizes. Check for size overflow bugs
2832 in rest of code.
2833 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2834 slightly wrong anyway, as it missed one instance of
2835 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2836 (refill_memory_reserve): Omit needless cast to size_t.
2837 (mark_object_loop_halt): Mark as externally visible.
2838
ac82cc6a
PE
2839 * xselect.c: Integer signedness and overflow fixes.
2840 (Fx_register_dnd_atom, x_handle_dnd_message):
2841 Use ptrdiff_t, not size_t, since we prefer signed.
2842 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2843 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2844 x_dnd_atoms_size and x_dnd_atoms_length.
2845
c2d1e36d
PE
2846 * doprnt.c: Prefer signed to unsigned when either works.
2847 * eval.c (verror):
2848 * doprnt.c (doprnt):
2849 * lisp.h (doprnt):
2850 * xdisp.c (vmessage):
2851 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2852 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2853 prefer signed arithmetic to avoid comparison confusion.
2854 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2855 but is a bit tricky.
2856
0e926e56
PE
2857 Assume freestanding C89 headers, string.h, stdlib.h.
2858 * data.c, doprnt.c, floatfns.c, print.c:
2859 Include float.h unconditionally.
2860 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2861 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2862 * regex.c: Likewise for stddef.h, string.h.
2863 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2864 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2865 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2866 (STDC_HEADERS): Remove obsolete defines.
2867 * sysdep.c: Include limits.h unconditionally.
2868
9cfdb3ec
PE
2869 Assume support for memcmp, memcpy, memmove, memset.
2870 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2871 * regex.c (memcmp, memcpy):
2872 Remove; we assume C89 now.
2873
2874 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2875 (__malloc_safe_bcopy): Remove; no longer needed.
2876
cf950e6b 2877 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2878 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2879 well either way, and we prefer signed to unsigned.
2880
dbf38e02
LMI
28812011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2882
2883 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2884 closes the connection while we're reading (bug#9182).
2885
d6f0886c 28862011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2887
d6f0886c
JD
2888 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2889 are specified (Bug#9168).
24e0f6b1 2890
2eb1f9e6
PE
28912011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2892
2893 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2894 Found by GCC static checking and --with-wide-int on a 32-bit host.
2895
22381272 28962011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2897
2898 * xdisp.c (compute_display_string_pos): Fix logic of caching
2899 previous display string position. Initialize cached_prev_pos to
2900 -1. Fixes slow-down at the beginning of a buffer.
2901
f25e39b4
EZ
29022011-07-24 Eli Zaretskii <eliz@gnu.org>
2903
2904 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2905 for attrs[LFACE_FONTSET_INDEX].
2906
04c4b52e
PE
29072011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2908
2909 * xml.c (parse_region): Remove unused local
2910 that was recently introduced.
2911
c1734fbd
EZ
29122011-07-23 Eli Zaretskii <eliz@gnu.org>
2913
be18c5a5
EZ
2914 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2915 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2916
c1734fbd
EZ
2917 * xdisp.c (move_it_in_display_line_to): Record the best matching
2918 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2919 exit if none of the characters scanned was an exact match.
2920 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2921 when exact match is impossible due to invisible text, and the
2922 lines are truncated.
2923
a258d627
JD
29242011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2925
2926 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2927 for OSX >= 10.7.
2928
b6d5a689
EZ
29292011-07-22 Eli Zaretskii <eliz@gnu.org>
2930
0f74f785
EZ
2931 Fix a significant slow-down of cursor motion with C-n, C-p,
2932 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2933 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2934 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2935 (next_element_from_buffer): Call compute_stop_pos_backwards to
2936 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2937 base_level_stop.
2938 (reseat): Don't look for prev_stop, as that could mean a very long
2939 run.
2940 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2941 <cached_disp_overlay_modiff>: Cache for last found display string
2942 position.
551918c1 2943 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2944 about the same buffer in the same area of character positions, and
2945 the buffer wasn't changed since the time the display string
2946 position was cached.
551918c1 2947
b2d0c91a
EZ
29482011-07-22 Eli Zaretskii <eliz@gnu.org>
2949
2950 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2951 is an integer, which is important for empty lines. (Bug#9149)
2952
043604ee
CY
29532011-07-22 Chong Yidong <cyd@stupidchicken.com>
2954
2955 * frame.c (Fmodify_frame_parameters): In tty case, update the
2956 default face if necessary (Bug#4238).
2957
da4adb04
CY
29582011-07-21 Chong Yidong <cyd@stupidchicken.com>
2959
2960 * editfns.c (Fstring_to_char): No need to explain what a character
2961 is in the docstring (Bug#6576).
2962
9abd0532
LMI
29632011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2964
2965 * xml.c (parse_region): Make sure we always return a tree.
2966
36881d16
HK
29672011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2968
2969 * xml.c (parse_region): If a document contains only comments,
2970 return that, too.
2971
1e98674d
LMI
29722011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2973
2974 * xml.c (make_dom): Return comments, too.
2975
590bd467
PE
29762011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2977
2978 Port to OpenBSD.
2979 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2980 and the surrounding thread.
2981 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2982 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2983 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2984 timer goes off.
2985 * s/openbsd.h (BROKEN_SIGIO): Define.
2986 * unexelf.c (unexec) [__OpenBSD__]:
2987 Don't update the .mdebug section of the Alpha COFF symbol table.
2988
f41628b2
LMI
29892011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2990
2991 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2992 (bug#8460).
2993
b59b67c5
PE
29942011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2995
15e3a074
PE
2996 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2997 This fixes some race conditions on the permissions of any newly
2998 created file.
2999
41bed37d
PE
3000 * alloc.c (valid_pointer_p): Use pipe, not open.
3001 This fixes some permissions issues when debugging.
3002
b59b67c5
PE
3003 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3004 If fchown fails to set both uid and gid, try to set just gid,
3005 as that is sometimes allowed. Adjust the file's mode to eliminate
3006 setuid or setgid bits that are inappropriate if fchown fails.
3007
925a6be7
SM
30082011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3009
3010 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3011 to compare Lisp_Objects.
3012 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3013 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3014 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3015
52968808
AS
30162011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3017
0a6a104b
AS
3018 * lread.c (read_integer): Unread even EOF character.
3019 (read1): Likewise. Properly record start position of symbol.
3020
52968808
AS
3021 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3022 symbol character follows.
3023
9e381cdd
PE
30242011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3025
3026 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3027 This works around a problem with the previous change to Fcopy_file.
3028 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3029 and without this change, GCC might complain about discarding
3030 fchown's return value.
3031
b5641435
JB
30322011-07-16 Juanma Barranquero <lekktu@gmail.com>
3033
3034 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3035
a8031457
PE
30362011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3037
3038 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3039
dd889327
LMI
30402011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3041
750c33f7
LMI
3042 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3043 it's used from the C level.
3044
dd889327
LMI
3045 * process.c: Use the same condition for POLL_FOR_INPUT in both
3046 keyboard.c and process.c (bug#1858).
3047
87e86684
LM
30482011-07-09 Lawrence Mitchell <wence@gmx.li>
3049
3050 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3051 (Fgnutls_boot): Use it.
3052
64348f40
AS
30532011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3054
3055 * doc.c (Fsubstitute_command_keys): Revert last change.
3056
1d698799
LMI
30572011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3058
f863868c
LMI
3059 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3060 quotes the next character, and doesn't affect other longer
3061 sequences (bug#8935).
3062
1d698799
LMI
3063 * lread.c (syms_of_lread): Clarify that is isn't only
3064 `eval-buffer' and `eval-defun' that's affected by
3065 `lexical-binding' (bug#8460).
3066
aa4b6df6
EZ
30672011-07-15 Eli Zaretskii <eliz@gnu.org>
3068
3069 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3070 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3071
5d856da6
PE
30722011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3073
ad6042bb
PE
3074 Fix minor problems found by static checking.
3075 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3076 (elsz): Now a signed constant, not a size_t var. We prefer signed
3077 types to unsigned, to avoid integer comparison confusion. Without
3078 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3079 "cannot optimize loop, the loop counter may overflow", a symptom
3080 of the confusion.
f00bbb22 3081 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3082 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3083
6468f31c
LMI
30842011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3085
49080b10
LMI
3086 * search.c (Fre_search_backward): Mention `case-fold-search' in
3087 all the re_search_* functions (bug#8138).
3088
6468f31c
LMI
3089 * keyboard.c (Fopen_dribble_file): Document when the file is
3090 closed (bug#8056).
3091
c965adc5
EZ
30922011-07-14 Eli Zaretskii <eliz@gnu.org>
3093
df9733bf
EZ
3094 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3095 bidi_cache_idx.
3096
0bb23927
EZ
3097 Support bidi reordering of display and overlay strings.
3098 * xdisp.c (compute_display_string_pos)
3099 (compute_display_string_end): Accept additional argument STRING.
3100 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3101 (reseat_to_string): Initialize bidi_it->string.s and
3102 bidi_it->string.schars.
3103 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3104 NULL (avoids a crash in bidi_paragraph_init).
3105 Initialize itb.string.lstring.
0bb23927
EZ
3106 (init_iterator): Call bidi_init_it only of a valid
3107 buffer position was specified. Initialize paragraph_embedding to
3108 L2R.
3109 (reseat_to_string): Initialize the bidi iterator.
3110 (display_string): If we need to ignore text properties of
3111 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3112 original value of -1 will not work with bidi.)
3113 (compute_display_string_pos): First arg is now struct
3114 `text_pos *'; all callers changed. Support display properties on
3115 Lisp strings.
3116 (compute_display_string_end): Support display properties on Lisp
3117 strings.
3118 (init_iterator, reseat_1, reseat_to_string): Initialize the
3119 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3120 when iterating on a string not from display properties).
640c8776
SM
3121 (compute_display_string_pos, compute_display_string_end):
3122 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3123 arrow keys.
3124 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3125 base_level_stop; instead, set base_level_stop to BEGV.
3126 Fixes crashes in vertical-motion.
0bb23927
EZ
3127 (next_element_from_buffer): Improve commentary for when
3128 the iterator is before prev_stop.
3129 (init_iterator): Initialize bidi_p from the default value of
3130 bidi-display-reordering, not from buffer-local value. Use the
3131 buffer-local value only if initializing for buffer iteration.
3132 (handle_invisible_prop): Support invisible properties on strings
3133 that are being bidi-reordered.
3134 (set_iterator_to_next): Support bidi reordering of C strings and
3135 Lisp strings.
3136 (next_element_from_string): Support bidi reordering of Lisp
3137 strings.
3138 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3139 (display_string): Support display of R2L glyph rows.
3140 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3141 (init_iterator): Don't initialize it->bidi_p for strings
3142 here.
3143 (reseat_to_string): Initialize it->bidi_p for strings here.
3144 (next_element_from_string, next_element_from_c_string)
3145 (next_element_from_buffer): Add xassert's for correspondence
3146 between IT's object being iterated and it->bidi_it.string
3147 structure.
3148 (face_before_or_after_it_pos): Support bidi iteration.
3149 (next_element_from_c_string): Handle the case of the first string
3150 character that is not the first one in the visual order.
3151 (get_visually_first_element): New function, refactored from common
3152 parts of next_element_from_buffer, next_element_from_string, and
3153 next_element_from_c_string.
3154 (tool_bar_lines_needed, redisplay_tool_bar)
3155 (display_menu_bar): Force left-to-right direction. Add a FIXME
3156 comment for making that be controlled by a user option.
3157 (push_it, pop_it): Save and restore the state of the
3158 bidi iterator. Save and restore the bidi_p flag.
3159 (pop_it): Iterate out of display property for string iteration as
3160 well.
3161 (iterate_out_of_display_property): Support iteration over strings.
3162 (handle_single_display_spec): Set up it->bidi_it for iteration
3163 over a display string, and call bidi_init_it.
3164 (handle_single_display_spec, next_overlay_string)
3165 (get_overlay_strings_1, push_display_prop): Set up the bidi
3166 iterator for displaying display or overlay strings.
3167 (forward_to_next_line_start): Don't use the shortcut if
3168 bidi-iterating.
3169 (back_to_previous_visible_line_start): If handle_display_prop
3170 pushed the iterator stack, restore the internal state of the bidi
3171 iterator by calling bidi_pop_it same number of times.
3172 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3173 and we are bidi-iterating, don't decrement the iterator position;
3174 instead, set the first_elt flag in the bidi iterator, to produce
3175 the same effect.
3176 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3177 (push_display_prop): xassert that we are iterating a buffer.
3178 (push_it, pop_it): Save and restore paragraph_embedding member.
3179 (handle_single_display_spec, next_overlay_string)
3180 (get_overlay_strings_1, reseat_1, reseat_to_string)
3181 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3182 correctly. Don't assume unibyte strings are not bidi-reordered.
3183 (compute_display_string_pos)
3184 (compute_display_string_end): Fix handling the case of C string.
3185 (push_it, pop_it): Save and restore from_disp_prop_p.
3186 (handle_single_display_spec, push_display_prop): Set the
3187 from_disp_prop_p flag.
3188 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3189 (pop_it): Call iterate_out_of_display_property only if we are
3190 popping after iteration over a string that came from a display
3191 property. Fix a typo in popping stretch info. Add an assertion
3192 for verifying that the iterator position is in sync with the bidi
3193 iterator.
3194 (handle_single_display_spec, get_overlay_strings_1)
3195 (push_display_prop): Fix initialization of paragraph direction for
3196 string when that of the parent object is not yet determined.
3197 (reseat_1): Call bidi_init_it to resync the bidi
3198 iterator with IT's position. (Bug#7616)
3199 (find_row_edges): If ROW->start.pos gives position
3200 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3201 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3202 Reset the from_disp_prop_p flag.
3203 (SAVE_IT, RESTORE_IT): New macros.
3204 (pos_visible_p, face_before_or_after_it_pos)
3205 (back_to_previous_visible_line_start)
3206 (move_it_in_display_line_to, move_it_in_display_line)
3207 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3208 (try_scrolling, redisplay_window, display_line): Use them when
3209 saving a temporary copy of the iterator and restoring it back.
3210 (back_to_previous_visible_line_start, reseat_1)
3211 (init_iterator): Empty the bidi cache "stack".
3212 (move_it_in_display_line_to): If iterator ended up at
3213 EOL, but we never saw any buffer positions smaller than
3214 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3215 motion in bidi-reordered lines.
3216 (move_it_in_display_line_to): Record prev_method and prev_pos
3217 immediately before the call to set_iterator_to_next. Fixes cursor
3218 motion in bidi-reordered lines with stretch glyphs and strings
3219 displayed in margins. (Bug#8133) (Bug#8867)
3220 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3221 TO_CHARPOS.
640c8776
SM
3222 (pos_visible_p): Support positions in bidi-reordered lines.
3223 Save and restore bidi cache.
0bb23927
EZ
3224
3225 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3226 (bidi_paragraph_info): Delete unused struct.
3227 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3228 (bidi_cache_start): New variable.
3229 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3230 to zero.
3231 (bidi_cache_fetch_state, bidi_cache_search)
3232 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3233 (bidi_cache_find, bidi_peek_at_next_level)
3234 (bidi_level_of_next_char, bidi_find_other_level_edge)
3235 (bidi_move_to_visually_next): Compare cache index with
3236 bidi_cache_start rather than with zero.
3237 (bidi_fetch_char): Accept new argument STRING; all callers
3238 changed. Support iteration over a string. Support strings with
3239 display properties. Support unibyte strings. Fix the type of
3240 `len' according to what STRING_CHAR_AND_LENGTH expects.
3241 (bidi_paragraph_init, bidi_resolve_explicit_1)
3242 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3243 (bidi_level_of_next_char, bidi_move_to_visually_next):
3244 Support iteration over a string.
0bb23927
EZ
3245 (bidi_set_sor_type, bidi_resolve_explicit_1)
3246 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3247 can now be zero (for strings); special values 0 and -1 were
3248 changed to -1 and -2, respectively.
3249 (bidi_char_at_pos): New function.
3250 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3251 Call it instead of FETCH_MULTIBYTE_CHAR.
3252 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3253 initialized to valid values.
3254 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3255 values.
3256 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3257 the test for valid cached positions. Fix the logic for looking up
3258 the sentinel state in the cache. GCPRO the Lisp string we are
3259 iterating.
3260 (bidi_push_it, bidi_pop_it): New functions.
3261 (bidi_initialize): Initialize the bidi cache start stack pointer.
3262 (bidi_cache_ensure_space): New function, refactored from part of
3263 bidi_cache_iterator_state. Don't assume the required size is just
3264 one BIDI_CACHE_CHUNK away.
3265 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3266 (bidi_count_bytes, bidi_char_at_pos): New functions.
3267 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3268 always valid if bidi_cache_idx is valid.
3269 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3270 is valid if it's going to be used.
3271 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3272 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3273 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3274 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3275 (bidi_find_other_level_edge, bidi_cache_start_stack):
3276 All variables related to cache indices are now EMACS_INT.
c965adc5 3277
0bb23927
EZ
3278 * dispextern.h (struct bidi_string_data): New structure.
3279 (struct bidi_it): New member `string'. Make flag members be 1-bit
3280 fields, and put them last in the struct.
640c8776
SM
3281 (compute_display_string_pos, compute_display_string_end):
3282 Update prototypes.
0bb23927
EZ
3283 (bidi_push_it, bidi_pop_it): Add prototypes.
3284 (struct iterator_stack_entry): New members bidi_p,
3285 paragraph_embedding, and from_disp_prop_p.
3286 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3287 (bidi_shelve_cache, bidi_unshelve_cache):
3288 Declare prototypes.
0bb23927
EZ
3289
3290 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3291 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3292 and vector-like objects.
3293
3294 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3295 cache around display iteration.
3296
3297 * window.c (Fwindow_end, window_scroll_pixel_based)
3298 (displayed_window_lines, Frecenter): Save and restore the bidi
3299 cache around display iteration.
3300
3bbd2265
LMI
33012011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3302
3303 * editfns.c (Fdelete_region): Clarify the use of the named
3304 parameters (bug#6788).
3305
adc47434
MR
33062011-07-14 Martin Rudalics <rudalics@gmx.at>
3307
3308 * indent.c (Fvertical_motion): Set and restore w->pointm when
3309 saving and restoring the window's buffer (Bug#9006).
3310
837c31f8
LMI
33112011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3312
3313 * editfns.c (Fstring_to_char): Clarify just what is returned
3314 (bug#6576). Text by Eli Zaretskii.
3315
ac389d0c
JB
33162011-07-13 Juanma Barranquero <lekktu@gmail.com>
3317
3318 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3319
0be0ce47
EZ
33202011-07-13 Eli Zaretskii <eliz@gnu.org>
3321
3322 * buffer.c (mmap_find): Fix a typo.
3323
cd18e7e3
JB
33242011-07-13 Johan Bockgård <bojohan@gnu.org>
3325
3326 Fix execution of x selection hooks.
3327 * xselect.c (Qx_lost_selection_functions)
3328 (Qx_sent_selection_functions): New vars.
3329 (syms_of_xselect): DEFSYM them.
3330 (x_handle_selection_request): Pass Qx_sent_selection_functions
3331 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3332 (x_handle_selection_clear,x_clear_frame_selections):
3333 Pass Qx_lost_selection_functions rather than
3334 Vx_lost_selection_functions to Frun_hook_with_args.
3335
47ea7f44
PE
33362011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3337
ac389d0c 3338 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3339 The old code sometimes used this field without initializing it.
3340
47ea7f44
PE
3341 * alloc.c (gc_sweep): Don't read past end of array.
3342 In theory, the old code could also have corrupted Emacs internals,
3343 though it'd be very unlikely.
3344
bc985c87
AS
33452011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3346
3347 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3348 argument. (Bug#4026)
bc985c87 3349
0cf34688
LMI
33502011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3351
b3dadd76
LMI
3352 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3353 key" (bug#4257).
3354
0cf34688
LMI
3355 * window.c (Fset_window_start): Doc fix (bug#4199).
3356 (Fset_window_hscroll): Ditto.
3357
270768cd
PE
33582011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3359
077e3dda 3360 Fix minor new problems caught by GCC 4.6.1.
270768cd 3361 * term.c (init_tty): Remove unused local.
490011a6 3362 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3363 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3364 not used otherwise.
270768cd 3365
b1f58454
CY
33662011-07-12 Chong Yidong <cyd@stupidchicken.com>
3367
3368 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3369
22b9578d
LMI
33702011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3371
6e70ab07
LMI
3372 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3373 are the mini-buffer and the echo area (bug#3320).
3374
22b9578d
LMI
3375 * term.c (init_tty): Remove support for supdup, c10 and perq
3376 terminals, which are no longer supported (bug#1482).
3377
8974cc9f
JB
33782011-07-10 Johan Bockgård <bojohan@gnu.org>
3379
3380 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3381
a560d974
JD
33822011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3383
3384 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3385 for non-popups (Bug#3642).
3386
1dae0f0a
AS
33872011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3388
268c2c36 3389 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3390 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3391 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3392 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3393 * data.c (fmod): Likewise.
3394 * dispnew.c (swap_glyphs_in_rows): Likewise.
3395 * emacs.c (memory_warning_signal): Likewise.
3396 * floatfns.c (float_error): Likewise.
3397 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3398 (otf_open, font_otf_capability, generate_otf_features)
3399 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3400 Likewise.
3401 * image.c (pbm_read_file): Likewise.
3402 * indent.c (string_display_width): Likewise.
3403 * intervals.c (check_for_interval, search_for_interval)
3404 (inc_interval_count, count_intervals, root_interval)
3405 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3406 * lread.c (defalias): Likewise.
268c2c36 3407 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3408 * regex.c (set_image_of_range_1, set_image_of_range)
3409 (regex_grow_registers): Likewise.
3410 * sysdep.c (strerror): Likewise.
3411 * termcap.c (valid_filename_p, tprint, main): Likewise.
3412 * tparam.c (main): Likewise.
3413 * unexhp9k800.c (run_time_remap, save_data_space)
3414 (update_file_ptrs, read_header, write_header, calculate_checksum)
3415 (copy_file, copy_rest, display_header): Likewise.
3416 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3417 Likewise.
3418 * xdisp.c (check_it): Likewise.
3419 * xfaces.c (register_color, unregister_color, unregister_colors):
3420 Likewise.
3421 * xfns.c (print_fontset_result): Likewise.
3422 * xrdb.c (member, fatal, main): Likewise.
3423
99033785
PE
34242011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3425
3426 Fix minor problems found by static checking (Bug#9031).
3427 * chartab.c (char_table_set_range, map_sub_char_table):
3428 Remove unused locals.
3429 (uniprop_table): Now static.
3430 * composite.c (_work_char): Remove unused static var.
3431
9cb2ac56
JB
34322011-07-09 Juanma Barranquero <lekktu@gmail.com>
3433
3434 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3435
f25661f0
JD
34362011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3437
3438 * gtkutil.c (qttip_cb): Remove code without function.
3439
8278c4fe
EZ
34402011-07-09 Eli Zaretskii <eliz@gnu.org>
3441
3442 * w32.c (pthread_sigmask): New stub.
3443
1692ae2d 34442011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3445
8a6ebd58 3446 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3447 sigprocmask is portable only for single-threaded applications, and
3448 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3449 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3450 (LIBES): Use it.
3451 * callproc.c (Fcall_process):
3452 * process.c (create_process):
3453 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3454 Use pthread_sigmask, not sigprocmask.
123403e4 3455
1b854618
JD
34562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3457
3458 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3459 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3460 wrong (Bug#8591).
3461
3fe4b549
JD
34622011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3463
0ce7e563
JD
3464 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3465 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3466 (xg_hide_tooltip): Fix comment.
3467
3fe4b549
JD
3468 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3469 in registerServicesMenuSendTypes.
3470 (validRequestorForSendType): Don't check ns_return_types.
3471
3472 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3473 ns_return_type.
3474
5df75e47
JR
34752011-07-08 Jason Rumney <jasonr@gnu.org>
3476
22610910
JR
3477 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3478 SH_SHOW for hidden windows (Bug#5482).
3479
5df75e47
JR
3480 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3481 frame struct members of non-existent frames (Bug#6284).
3482
699c10bd
JD
34832011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3484
4393663b
JD
3485 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3486 variable firstTime not needed on OSX >= 10.6.
3487 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3488 >= 10.5. Use setKnobProportion, setDoubleValue.
3489
3490 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3491 (MAC_OS_X_VERSION_10_5): Define if not defined.
3492 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3493 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3494 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3495
3496 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3497 cString and lossyCString on OSX >= 10.4
3498
58179cce 3499 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3500 sizeToFit on OSX >= 10.2.
3501
3502 * nsimage.m (allocInitFromFile): Don't use deprecated method
3503 bestRepresentationForDevice on OSX >= 10.6.
3504
3505 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3506 to avoid warning.
3507
3508 * emacs.c: Declare unexec_init_emacs_zone.
3509
a63e0781
JD
3510 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3511
699c10bd
JD
3512 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3513
3514 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3515 on svcsMenu (Bug#8842).
3516
3517 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3518 ns_return_types.
3519 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3520
3521 * nsterm.m (QUTF8_STRING): Declare.
3522 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3523 (validRequestorForSendType): Return type is (id).
3524 Change indexOfObjectIdenticalTo to indexOfObject.
3525 Check if we have local selection before returning self (Bug#8842).
3526 (writeSelectionToPasteboard): Put local selection into paste board
3527 if we have a local selection (Bug#8842).
3528 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3529
3530 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3531 (ns_get_local_selection): Declare.
3532
54e10184
LMI
35332011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3534
9888ff71
LMI
3535 * keymap.c (describe_map_tree): Don't insert a double newline at
3536 the end of the buffer (bug#1169) and return whether we inserted
3537 something.
3538
54e10184
LMI
3539 * callint.c (Fcall_interactively): Change "reading args" to
3540 "providing args" to try to clarify what it does (bug#1010).
3541
15fa4783
KH
35422011-07-07 Kenichi Handa <handa@m17n.org>
3543
3544 * composite.c (composition_compute_stop_pos): Ignore a static
3545 composition starting before CHARPOS (Bug#8915).
3546
3547 * xdisp.c (handle_composition_prop): Likewise.
3548
a8815b00
EZ
35492011-07-07 Eli Zaretskii <eliz@gnu.org>
3550
3551 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3552 (Bug#9015)
3553
ef7b981d 35542011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3555
3556 * character.h (unicode_category_t): New enum type.
3557
3558 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3559 (Qchar_code_property_table): New variable.
3560 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3561 (UNIPROP_COMPRESSED_FORM_P): New macros.
3562 (char_table_ascii): Uncompress the compressed values.
3563 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3564 Uncompress the compressed values.
ac389d0c 3565 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3566 (char_table_ref_and_range): Uncompress the compressed values.
3567 (sub_char_table_set): New arg is_uniprop. Callers changed.
3568 Uncompress the compressed values.
3569 (sub_char_table_set_range): Args changed. Callers changed.
3570 (char_table_set_range): Adjuted for the above change.
3571 (map_sub_char_table): Delete args default_val and parent. Add arg
3572 top. Give decoded values to a Lisp function.
640c8776 3573 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3574 values to a Lisp function. Gcpro more variables.
3575 (uniprop_table_uncompress)
3576 (uniprop_decode_value_run_length): New functions.
3577 (uniprop_decoder, uniprop_decoder_count): New variables.
3578 (uniprop_get_decoder, uniprop_encode_value_character)
3579 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3580 New functions.
3581 (uniprop_encoder, uniprop_encoder_count): New variables.
3582 (uniprop_get_encoder, uniprop_table)
3583 (Funicode_property_table_internal, Fget_unicode_property_internal)
3584 (Fput_unicode_property_internal): New functions.
3585 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3586 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3587 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3588 char-code-property-alist.
3589
640c8776 3590 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3591 Vunicode_category_table.
3592
640c8776 3593 * font.c (font_range): Adjust for the change of
c805dec0
KH
3594 Vunicode_category_table.
3595
76b397fb
DN
35962011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3597
3598 * m/iris4d.h: Remove file, move contents ...
3599 * s/irix6-5.h: ... here.
3600
22b4128e
PE
36012011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3602
3603 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3604 * alloc.c (mark_buffer):
3605 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3606 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3607 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3608 This isn't true in general, and it's particularly not true
3609 if Emacs is configured with --with-wide-int.
3610 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3611 New macros, used in the buffer.c change.
3612
869795d6
JD
36132011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3614
3615 * xsettings.c: Use both GConf and GSettings if both are available.
3616 (store_config_changed_event): Add comment.
3617 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3618 (store_tool_bar_style_changed): New functions.
5e617bc2 3619 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3620 (struct xsettings): Move font inside HAVE_XFT.
3621 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3622 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3623 Move inside HAVE_XFT.
640c8776 3624 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3625 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3626 also.
3627 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3628 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3629 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3630 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3631 (parse_settings): Move check for font inside HAVE_XFT.
3632 (read_settings, apply_xft_settings): Add comment.
3633 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3634 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3635 call store_font_name_changed.
3636 (xft_settings_event): Add comment.
3637 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3638 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3639 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3640 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3641 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3642 (xsettings_get_system_font, xsettings_get_system_normal_font):
3643 Add comment.
869795d6 3644
d8ed26bd
PE
36452011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3646
3647 Random fixes. E.g., (random) never returned negative values.
3648 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3649 subseconds part to the entropy, as that's a bit more random.
3650 Prefer signed to unsigned, since the signedness doesn't matter and
3651 in general we prefer signed. When given a limit, use a
3652 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3653 latter isn't right if USE_2_TAGS_FOR_INTS.
3654 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3655 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3656
cabf1cac
SM
36572011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3658
3659 * textprop.c (text_property_stickiness):
3660 Obey Vtext_property_default_nonsticky.
3661 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3662 * w32fns.c (syms_of_w32fns):
3663 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3664
6e9b2be9
PE
36652011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3666
3667 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3668 This is more efficient than Ffile_directory_p and avoids a minor race.
3669
90186c68
LMI
36702011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3671
7c301272
LMI
3672 * buffer.c (Foverlay_put): Say what the return value is
3673 (bug#7835).
3674
c4f2d8d4
LMI
3675 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3676 is a directory before asking whether to use the file name
3677 (bug#7564).
ad637907
LMI
3678 (barf_or_query_if_file_exists): Make the "File is a directory"
3679 error be more correct.
c4f2d8d4 3680
90186c68
LMI
3681 * fns.c (Frequire): Remove the mention of the .gz files, since
3682 that's installation-specific, but keep the mention of
3683 `get-load-suffixes'.
3684
da64016e
PE
36852011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3686
3687 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3688 Report string overflow if the output is too long.
3689
7d47b580
JB
36902011-07-04 Juanma Barranquero <lekktu@gmail.com>
3691
a555cb87
JB
3692 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3693 (syms_of_gnutls): Remove duplicate DEFSYM for
3694 Qgnutls_bootprop_verify_hostname_error, an error for
3695 Qgnutls_bootprop_verify_error (which is no longer used).
3696
7d47b580
JB
3697 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3698 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3699 Also (re)move comments that are misplaced or no longer relevant.
3700
1e49bfab
LMI
37012011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3702
3703 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3704
1485f4c0
CY
37052011-07-03 Chong Yidong <cyd@stupidchicken.com>
3706
3707 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3708 and background color parameters if they have been changed.
3709
a9ab721e
LMI
37102011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3711
3712 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3713
cf7cff57
PE
37142011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3715
2e13213d
PE
3716 * xsettings.c (SYSTEM_FONT): Define only when used.
3717 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3718
cf7cff57
PE
3719 * keymap.c (access_keymap_1): Now static.
3720
7a8e04f7
CY
37212011-07-02 Chong Yidong <cyd@stupidchicken.com>
3722
3723 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3724 leave any prefix arg for the up event (Bug#1586).
3725
61352f62
LMI
37262011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3727
69bb1ef7
LMI
3728 * lread.c (syms_of_lread): Mention single symbols defined by
3729 `defvar' or `defconst' (bug#7154).
3730
61352f62 3731 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3732 (Frequire): Mention get-load-suffixes.
61352f62 3733
28545e04
MR
37342011-07-02 Martin Rudalics <rudalics@gmx.at>
3735
3736 * window.h (window): Remove clone_number slot.
3737 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3738 Remove.
3739 (make_parent_window, make_window, saved_window)
3740 (Fset_window_configuration, save_window_save): Don't deal with
3741 clone numbers.
3742 * buffer.c (Qclone_number): Remove declaration.
3743 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3744
3349e122
SM
37452011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3746
3747 Add multiple inheritance to keymaps.
3748 * keymap.c (Fmake_composed_keymap): New function.
3749 (Fset_keymap_parent): Simplify.
3750 (fix_submap_inheritance): Remove.
3751 (access_keymap_1): New function extracted from access_keymap to handle
3752 embedded parents and handle lists of maps.
3753 (access_keymap): Use it.
3754 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3755 (Fcopy_keymap): Handle embedded parents.
3756 (Fcommand_remapping, define_as_prefix): Simplify.
3757 (Fkey_binding): Simplify.
3758 (syms_of_keymap): Move minibuffer-local-completion-map,
3759 minibuffer-local-filename-completion-map,
3760 minibuffer-local-must-match-map, and
3761 minibuffer-local-filename-must-match-map to Elisp.
3762 (syms_of_keymap): Defsubr make-composed-keymap.
3763 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3764 (parse_menu_item): Trivial simplification.
3765
3279eb87
GM
37662011-07-01 Glenn Morris <rgm@gnu.org>
3767
3768 * Makefile.in (SETTINGS_LIBS): Fix typo.
3769
4550efdf
KI
37702011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3771
3772 * coding.c (Fencode_coding_string): Record the last coding system
3773 used, as the function doc string says (bug#8738).
3774
0949d2b6
JD
37752011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3776
3777 * xsettings.c (store_monospaced_changed): Take new font as arg and
3778 check for change against current_mono_font.
3779 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3780 (emacs_settings_constructor, emacs_settings_get_property)
3781 (emacs_settings_set_property, emacs_settings_class_init)
3782 (emacs_settings_init, gsettings_obj): Remove.
3783 (something_changedCB): New function for HAVE_GSETTINGS.
3784 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3785 with value as argument.
3786 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3787 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3788 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3789 "changed".
3790
3791 * xgselect.c: Add defined (HAVE_GSETTINGS).
3792 (xgselect_initialize): Ditto.
3793
3794 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3795 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3796 xg_select.
3797
bbc6b304
PE
37982011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3799
3800 * eval.c (struct backtrace): Simplify and port the data structure.
3801 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3802 signed bit field, as this assumption is not portable and it makes
3803 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3804 "char debug_on_exit : 1" as this is not portable either; instead,
3805 use the portable "unsigned int debug_on_exit : 1". Remove unused
3806 member evalargs. Remove obsolete comments about cc bombing out.
3807
9851bfc5
JD
38082011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3809
51bb811f 3810 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3811 Let HAVE_GSETTINGS override HAVE_GCONF.
3812 (store_monospaced_changed): New function.
3813 (EMACS_SETTINGS): A new type derived from GObject to handle
3814 GSettings notifications.
3815 (emacs_settings_constructor, emacs_settings_get_property)
3816 (emacs_settings_set_property, emacs_settings_class_init):
3817 New functions.
3818 (gsettings_client, gsettings_obj): New variables.
3819 (GSETTINGS_SCHEMA): New define.
3820 (something_changedCB): Call store_monospaced_changed.
3821 (init_gsettings): New function.
3822 (xsettings_initialize): Call init_gsettings.
3823 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3824 to NULL.
3825
640c8776 3826 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3827 GCONF_CFLAGS/LIBS.
3828
5386012d
MR
38292011-06-29 Martin Rudalics <rudalics@gmx.at>
3830
3831 * window.c (resize_root_window, grow_mini_window)
3832 (shrink_mini_window): Rename Qresize_root_window to
3833 Qwindow_resize_root_window and Qresize_root_window_vertically to
3834 Qwindow_resize_root_window_vertically.
3835
f13e0b08
PE
38362011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3837
3838 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3839
94515237
JB
38402011-06-27 Juanma Barranquero <lekktu@gmail.com>
3841
3842 * makefile.w32-in: Redesign dependencies so they reflect more
3843 clearly which files are directly included by each source file,
3844 and not through other includes.
3845
e43b6e43
MR
38462011-06-27 Martin Rudalics <rudalics@gmx.at>
3847
3848 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3849 (sort_overlays, overlay_strings): When an overlay's clone number
3850 matches the window's clone number process the overlay even if
3851 the overlay's window property doesn't match the current window.
3852
d68443dc
MR
3853 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3854 (Fwindow_hchild): Rename to Fwindow_left_child.
3855 (Fwindow_next): Rename to Fwindow_next_sibling.
3856 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3857 (resize_window_check): Rename to window_resize_check.
3858 (resize_window_apply): Rename to window_resize_apply.
3859 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3860 (Fdelete_other_windows_internal, resize_frame_windows)
3861 (Fsplit_window_internal, Fdelete_window_internal)
3862 (grow_mini_window, shrink_mini_window)
3863 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3864
c7e73be5
JD
38652011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3866
3867 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3868 (emacs_fixed_set_min_size): Remove.
3869 (emacs_fixed_new): Take frame as argument.
3870
3871 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3872 (_EmacsFixedPrivate): Remove minwidth/height.
3873 Add struct frame *f.
3874 (emacs_fixed_init): Initialize priv->f.
3875 (get_parent_class, emacs_fixed_set_min_size): Remove.
3876 (emacs_fixed_new): Set priv->f to argument.
3877 (emacs_fixed_get_preferred_width)
3878 (emacs_fixed_get_preferred_height): Use min_width/height from
3879 frames size_hint to set minimum and natural (Bug#8919).
3880 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3881 and use min_width/height from frames size_hint to set
3882 min_width/height (Bug#8919).
3883
3884 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3885 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3886 Fix indentation.
c7e73be5 3887
cf99dcf8
EZ
38882011-06-26 Eli Zaretskii <eliz@gnu.org>
3889
3890 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3891 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3892 called at ZV.
3893
029529ac
CY
38942011-06-26 Chong Yidong <cyd@stupidchicken.com>
3895
3896 * process.c (wait_reading_process_output): Bypass select if
3897 waiting for a cell while ignoring keyboard input, and input is
3898 pending. Suggested by Jan Djärv (Bug#8869).
3899
7a7ef429
PE
39002011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3901
3902 Use gnulib's dup2 module instead of rolling our own.
3903 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3904
11fdef7d 39052011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3906
3907 * dispnew.c (scrolling_window): Before scrolling, turn off a
3908 mouse-highlight in the window being scrolled.
3909
cd3520a4
JB
39102011-06-24 Juanma Barranquero <lekktu@gmail.com>
3911
3912 Move DEFSYM to lisp.h and use everywhere.
3913
3914 * character.h (DEFSYM): Move declaration...
3915 * lisp.h (DEFSYM): ...here.
3916
3917 * gnutls.c:
3918 * minibuf.c:
3919 * w32menu.c:
3920 * w32proc.c:
3921 * w32select.c: Don't include character.h.
3922
3923 * alloc.c (syms_of_alloc):
3924 * buffer.c (syms_of_buffer):
3925 * bytecode.c (syms_of_bytecode):
3926 * callint.c (syms_of_callint):
3927 * casefiddle.c (syms_of_casefiddle):
3928 * casetab.c (init_casetab_once):
3929 * category.c (init_category_once, syms_of_category):
3930 * ccl.c (syms_of_ccl):
3931 * cmds.c (syms_of_cmds):
3932 * composite.c (syms_of_composite):
3933 * dbusbind.c (syms_of_dbusbind):
3934 * dired.c (syms_of_dired):
3935 * dispnew.c (syms_of_display):
3936 * doc.c (syms_of_doc):
3937 * editfns.c (syms_of_editfns):
3938 * emacs.c (syms_of_emacs):
3939 * eval.c (syms_of_eval):
3940 * fileio.c (syms_of_fileio):
3941 * fns.c (syms_of_fns):
3942 * frame.c (syms_of_frame):
3943 * fringe.c (syms_of_fringe):
3944 * insdel.c (syms_of_insdel):
3945 * keymap.c (syms_of_keymap):
3946 * lread.c (init_obarray, syms_of_lread):
3947 * macros.c (syms_of_macros):
3948 * msdos.c (syms_of_msdos):
3949 * print.c (syms_of_print):
3950 * process.c (syms_of_process):
3951 * search.c (syms_of_search):
3952 * sound.c (syms_of_sound):
3953 * syntax.c (init_syntax_once, syms_of_syntax):
3954 * terminal.c (syms_of_terminal):
3955 * textprop.c (syms_of_textprop):
3956 * undo.c (syms_of_undo):
3957 * w32.c (globals_of_w32):
3958 * window.c (syms_of_window):
3959 * xdisp.c (syms_of_xdisp):
3960 * xfaces.c (syms_of_xfaces):
3961 * xfns.c (syms_of_xfns):
3962 * xmenu.c (syms_of_xmenu):
3963 * xsettings.c (syms_of_xsettings):
3964 * xterm.c (syms_of_xterm): Use DEFSYM.
3965
4228cf16
TZ
39662011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3967
cd3520a4 3968 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3969
7fcccf1e
PE
39702011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3971
7efb4e0e
PE
3972 Integer and buffer overflow fixes (Bug#8873).
3973
ff5844ad
PE
3974 * print.c (printchar, strout): Check for string overflow.
3975 (PRINTPREPARE, printchar, strout):
3976 Don't set size unless allocation succeeds.
3977
90532f02
PE
3978 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3979 for sizes. Check for string overflow more accurately.
3980 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3981
6d84508d
PE
3982 * macros.c: Integer and buffer overflow fixes.
3983 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3984 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3985 Use ptrdiff_t, not int, for sizes.
3986 Don't increment bufsize until after realloc succeeds.
3987 Check for size-calculation overflow.
3988 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3989
437b2cb4
PE
3990 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3991
8b9ac8b4
PE
3992 * lread.c: Integer overflow fixes.
3993 (read_integer): Radix is now EMACS_INT, not int,
3994 to improve quality of diagnostics for out-of-range radices.
3995 Calculate buffer size correctly for out-of-range radices.
3996 (read1): Check for integer overflow in radices, and in
3997 read-circle numbers.
82cb60d3
PE
3998 (read_escape): Avoid int overflow.
3999 (Fload, openp, read_buffer_size, read1)
4000 (substitute_object_recurse, read_vector, read_list, map_obarray):
4001 Use ptrdiff_t, not int, for sizes.
4002 (read1): Use EMACS_INT, not int, for sizes.
20270765 4003 Check for size overflow.
8b9ac8b4 4004
7fcccf1e
PE
4005 * image.c (cache_image): Check for size arithmetic overflow.
4006
bfbbd7e7
PE
4007 * lread.c: Integer overflow issues.
4008 (saved_doc_string_size, saved_doc_string_length)
4009 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4010 Now ptrdiff_t, not int.
4011 (read1): Don't assume doc string length fits in int. Check for
4012 out-of-range doc string lengths.
4013 (read_list): Don't assume file position fits in int.
39019e54 4014 (read_escape): Check for hex character overflow.
bfbbd7e7 4015
4e323265
LL
40162011-06-22 Leo Liu <sdl.web@gmail.com>
4017
4018 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4019 Move to minibuffer.el.
4020
85fece3e
PE
40212011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4022
20b84ce9 4023 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4024 The following patches are for when GLYPH_DEBUG && !XASSERT.
4025 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4026 * dispnew.c (flush_stdout):
4027 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4028 Mark as externally visible.
4029 * dispnew.c (check_window_matrix_pointers): Now static.
4030 * dispnew.c (window_to_frame_vpos):
4031 * xfns.c (unwind_create_frame):
4032 * xterm.c (x_check_font): Remove unused local.
4033 * scroll.c (CHECK_BOUNDS):
4034 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4035 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4036 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4037 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4038 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4039 Now static.
4040 (debug_method_add): Use va_list and vsprintf rather than relying
4041 on undefined behavior with wrong number of arguments.
4042 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4043 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4044 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4045 since we're not interested in debugging glyphs with old libraries.
4046 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4047 GCC 4.6.0's static checking.
4048
0766b489
PE
40492011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4050
31fd4b32
PE
4051 Integer overflow and signedness fixes (Bug#8873).
4052 A few related buffer overrun fixes, too.
4053
b79e8648
PE
4054 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4055
0766b489
PE
4056 * dispextern.h (struct face.stipple):
4057 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4058 (x_bitmap_mask, x_allocate_bitmap_record)
4059 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4060 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4061 (x_create_bitmap_from_xpm_data):
4062 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4063 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4064 (.bitmaps_last):
4065 * xfaces.c (load_pixmap):
4066 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4067 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4068 (.bitmaps_last, struct x_output.icon_bitmap):
4069 Use ptrdiff_t, not int, for bitmap indexes.
4070 (x_allocate_bitmap_record): Check for size overflow.
4071 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4072
b081724f
PE
4073 Use ptrdiff_t, not int, for overlay counts.
4074 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4075 * editfns.c (overlays_around, get_pos_property):
4076 * textprop.c (get_char_property_and_overlay):
4077 * xdisp.c (next_overlay_change, note_mouse_highlight):
4078 * xfaces.c (face_at_buffer_position):
21514da7
PE
4079 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4080 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4081 (Fnext_overlay_change, Fprevious_overlay_change)
4082 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4083 Use ptrdiff_t, not int, for sizes.
21514da7 4084 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4085
3de73e5e
PE
4086 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4087
2606c57b
PE
4088 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4089 (x_session_initialize): Do not assume string length fits in int.
4090
aaafe47a
PE
4091 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4092 This is unlikely, but can occur if DPI is outlandish.
4093
2674ddc8 4094 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4095 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4096
28154962
PE
4097 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4098 * xrdb.c (magic_file_p, search_magic_path):
4099 Omit last arg SUFFIX; it was always 0. All callers changed.
4100 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4101
7de51af5
PE
4102 * xfont.c (xfont_match): Avoid need for strlen.
4103
25ed6cc3
PE
4104 * xfns.c: Don't assume strlen fits in int.
4105 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4106
4eab31dd
PE
4107 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4108 not unsigned long, as we prefer signed integers. All callers changed.
4109 Detect integer overflow in repeat count.
4110 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4111 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4112
171e2a58
PE
4113 * termcap.c: Don't assume sizes fit in int and never overflow.
4114 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4115 (gobble_line): Check for size-calculation overflow.
4116
ad39faca 4117 * minibuf.c (Fread_buffer):
6e5bb2dc 4118 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4119 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4120 Don't assume string length fits in int.
4121
52c61c22 4122 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4123 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4124
b5b8c9e5
PE
4125 * font.c: Don't assume string length fits in int.
4126 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4127 Use ptrdiff_t, not int.
ccd6111c
PE
4128 (font_intern_prop): Don't assume string length fits in int.
4129 Don't assume integer property fits in fixnum.
4130 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4131
882f0d81 4132 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4133 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4134 Reformulate so as not to need the command string.
4135 Invoke gzip -cd rather than gunzip, as it's more portable.
4136 (lock_info_type, lock_file_1, lock_file):
4137 Don't assume pid_t and time_t fit in unsigned long.
4138 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4139 (current_lock_owner): Prefer signed type for sizes.
4140 Use memcpy, not strncpy, where memcpy is what is really wanted.
4141 Don't assume (via atoi) that time_t and pid_t fit in int.
4142 Check for time_t and/or pid_t out of range, e.g., via a network share.
4143 Don't alloca where an auto var works fine.
4144
93f4cf88
PE
4145 * fileio.c: Fix some integer overflow issues.
4146 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4147 Don't assume string length fits in int.
4148 (directory_file_name): Don't assume string length fits in long.
4149 (make_temp_name): Don't assume pid fits in int, or that its print
4150 length is less than 20.
4151
f3e92b69
PE
4152 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4153
1bfdaf10
PE
4154 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4155
35016e9a
PE
4156 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4157
3d1e65a1
PE
4158 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4159 We prefer signed integers, even for size calculations.
4160
0b963a93
PE
4161 * emacs.c: Don't assume string length fits in 'int'.
4162 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4163 (main): Don't invoke strlen when not needed.
4164
573f4b54
PE
4165 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4166 (XD_DEBUG_MESSAGE): Don't waste a byte.
4167
989f33ba
PE
4168 * callproc.c (getenv_internal_1, getenv_internal)
4169 (Fgetenv_internal):
965d34eb
PE
4170 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4171
e4d29b33
PE
4172 * lread.c (invalid_syntax): Omit length argument.
4173 All uses changed. This doesn't fix a bug, but it simplifies the
4174 code away from its former Hollerith-constant appearance, and it's
4175 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4176 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4177
eb49b136
PE
4178 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4179 This didn't break anything, but it didn't help either.
4180 It's confusing to put a bogus integer in a place where the actual
4181 value does not matter.
9f62aeb1 4182 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4183 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4184
15375a22
PE
4185 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4186 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4187 implementation.
b61cc01c
PE
4188 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4189 We prefer signed types, and the value cannot exceed the EMACS_INT
4190 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4191 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4192 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4193 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4194
53b2623d
PE
4195 * indent.c (sane_tab_width): New function.
4196 (current_column, scan_for_column, Findent_to, position_indentation)
4197 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4198 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4199
51cab52b 4200 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4201
f2ed8a70
PE
4202 * lisp.h (lint_assume): New macro.
4203 * composite.c (composition_gstring_put_cache):
4204 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4205
abe80cc6
PE
4206 * editfns.c, insdel.c:
4207 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4208
b02c740e
PE
4209 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4210
ebc96716
PE
4211 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4212
b4e50fa0 4213 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4214 Use much-faster test for byte-length change.
311d5d7c 4215 Don't assume string byte-length fits in 'int'.
a4cf38e4 4216 Check that character arg fits in 'int'.
85461888 4217 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4218
c0c1ee9f
PE
4219 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4220
a498d7f4
PE
4221 * fns.c (concat): Catch string overflow earlier.
4222 Do not rely on integer wraparound.
4223
51cab52b
PE
4224 * dispextern.h (struct it.overlay_strings_charpos)
4225 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4226 * xdisp.c (forward_to_next_line_start)
4227 (back_to_previous_visible_line_start)
4228 (reseat_at_next_visible_line_start, next_element_from_buffer):
4229 Don't arbitrarily truncate the value of 'selective' to int.
4230
76031fad
PE
4231 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4232
5eb55db9
PE
4233 * composite.c: Don't truncate sizes to 'int'.
4234 (composition_gstring_p, composition_reseat_it)
4235 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4236 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4237 not EMACS_UINT, for indexes.
5eb55db9 4238
0703a717
PE
4239 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4240
d6202519
PE
4241 * buffer.c: Include <verify.h>.
4242 (struct sortvec.priority, struct sortstr.priority):
8961a454 4243 Now EMACS_INT, not int.
c20998a7 4244 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4245 (struct sortstr.size, record_overlay_string)
4246 (struct sortstrlist.size, struct sortlist.used):
4247 Don't truncate size to int.
4248 (record_overlay_string): Check for size-calculation overflow.
d6202519 4249 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4250
d5a19415
JM
42512011-06-22 Jim Meyering <meyering@redhat.com>
4252
029529ac 4253 Don't leak an XBM-image-sized buffer
d5a19415
JM
4254 * image.c (xbm_load): Free the image buffer after using it.
4255
a9041e6c
PE
42562011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4257
4258 Port to Sun C.
4259 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4260 that Sun C diagnosed.
4261 * fns.c (secure_hash): Fix pointer signedness issue.
4262 * intervals.c (static_offset_intervals): New function.
4263 (offset_intervals): Use it.
4264
7f3f739f
LL
42652011-06-21 Leo Liu <sdl.web@gmail.com>
4266
4267 * deps.mk (fns.o):
4268 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4269 sha512.h.
4270
4271 * fns.c (secure_hash): Rename from crypto_hash_function and change
4272 the first arg to accept symbols.
5b66d427 4273 (Fsecure_hash): New primitive.
7f3f739f
LL
4274 (syms_of_fns): New symbols.
4275
76147d94
DD
42762011-06-20 Deniz Dogan <deniz@dogan.se>
4277
4278 * process.c (Fset_process_buffer): Clarify return value in
4279 docstring.
4280
7d7d0045
CY
42812011-06-18 Chong Yidong <cyd@stupidchicken.com>
4282
4283 * dispnew.c (add_window_display_history): Use BVAR.
4284
4285 * xdisp.c (debug_method_add): Use BVAR.
4286 (check_window_end, dump_glyph_matrix, dump_glyph)
4287 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4288
4289 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4290 Likewise.
4291
4292 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4293 check till after the cache is created in init_frame_faces.
4294
ff2bc410
SM
42952011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4296
4297 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4298
28177add
PE
42992011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4300
dd3482fe
PE
4301 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4302 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4303 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4304
393d71f3 4305 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4306 * fileio.c (Finsert_file_contents):
4307 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4308 Remove the old (too-loose) buffer overflow checks.
4309 They weren't needed, since make_gap checks for buffer overflow.
4310 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4311 The old code merely checked for Emacs fixnum overflow, and relied
4312 on undefined (wraparound) behavior. The new code avoids undefined
4313 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4314
2e6813b0 4315 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4316 Tune. Don't use wider integers than needed. Don't use alloca.
4317 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4318
599a9e4f
PE
4319 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4320
99561444
PE
4321 * insdel.c, lisp.h (buffer_overflow): New function.
4322 (insert_from_buffer_1, replace_range, replace_range_2):
4323 * insdel.c (make_gap_larger):
4324 * editfns.c (Finsert_char):
4325 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4326
28177add
PE
4327 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4328
e69dafad
PE
43292011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4330
a7af7fde 4331 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4332
b1c46f02
PE
4333 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4334 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4335
e69dafad
PE
4336 * fileio.c: Don't assume EMACS_INT fits in off_t.
4337 (emacs_lseek): New static function.
4338 (Finsert_file_contents, Fwrite_region): Use it.
4339 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4340
566684ea
PE
4341 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4342
e6966cd6
PE
4343 * fns.c: Don't overflow int when computing a list length.
4344 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4345 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4346 truncation on 64-bit hosts. Check for QUIT every
4347 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4348 faster and is responsive enough.
4349 (Flength): Report an error instead of overflowing an integer.
4350 (Fsafe_length): Return a float if the value is not representable
4351 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4352 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4353 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4354
dd0b0efb
PE
4355 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4356 (header_size, word_size): New constants.
4357 (allocate_vectorlike): Don't check size overflow here.
4358 (allocate_vector): Check it here instead, since this is the only
4359 caller of allocate_vectorlike that could cause overflow.
4360 Check that the new vector's length is representable as a fixnum.
4361
86fe5cfe
PE
4362 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4363 The previous code was bogus. For example, next_almost_prime (32)
4364 returned 39, which is undesirable as it is a multiple of 3; and
4365 next_almost_prime (24) returned 25, which is a multiple of 5 so
4366 why was the code bothering to check for multiples of 7?
4367
80e88859
PE
4368 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4369
4a2f0ad6
PE
4370 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4371
f66c7cf8
PE
4372 Variadic C functions now count arguments with ptrdiff_t.
4373 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4374 Back then I didn't know that the Emacs coding style prefers signed int.
4375 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4376 were being counted with int, which may truncate counts on 64-bit
4377 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4378 * lisp.h (struct Lisp_Subr.function.aMANY)
4379 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4380 Arg counts are now ptrdiff_t, not size_t.
4381 All variadic functions and their callers changed accordingly.
4382 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4383 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4384 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4385 * callint.c (Fcall_interactively): Check arg count for overflow,
4386 to avoid potential buffer overrun. Use signed char, not 'int',
4387 for 'varies' array, so that we needn't bother to check its size
4388 calculation for overflow.
4389 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4390 * eval.c (apply_lambda):
4391 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4392 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4393 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4394
a1759b76
PE
4395 * callint.c (Fcall_interactively): Don't use index var as event count.
4396
d96be9fc
PE
4397 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4398 * mem-limits.h (SIZE): Remove; no longer used.
4399
a690a978 4400 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4401
578c21e6
PE
4402 Remove unnecessary casts.
4403 * xterm.c (x_term_init):
4404 * xfns.c (x_set_border_pixel):
4405 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4406 These aren't needed now that we assume ANSI C.
4407
96f53c6c
PE
4408 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4409 It's more likely to cause problems (due to unsigned overflow)
4410 than to cure them.
4411
83c77d31
PE
4412 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4413
ee2079f1
PE
4414 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4415
6da65536
PE
4416 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4417
7147c4a4
PE
4418 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4419
193e32d9
PE
4420 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4421
e5533da6
PE
4422 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4423
9910e595
PE
4424 GLYPH_CODE_FACE returns EMACS_INT, not int.
4425 * dispextern.h (merge_faces):
4426 * xfaces.c (merge_faces):
01103c44
PE
4427 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4428 Don't assume EMACS_INT fits in int.
9910e595 4429
2638320e
PE
4430 * character.h (CHAR_VALID_P): Remove unused parameter.
4431 * fontset.c, lisp.h, xdisp.c: All uses changed.
4432
045eb8d9
PE
4433 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4434
c1f134b5
PE
4435 * fns.c (concat): Minor tuning based on overflow analysis.
4436 This doesn't fix any bugs. Use int to hold character, instead
4437 of constantly refetching from Emacs object. Use XFASTINT, not
4438 XINT, for value known to be a character. Don't bother comparing
4439 a single byte to 0400, as it's always less.
4440
395fcb93 4441 * floatfns.c (Fexpt):
327eeec8
PE
4442 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4443
abbd3d23
PE
4444 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4445 for characters.
4446
684a03ef
PE
4447 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4448
0fed43f3
PE
4449 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4450 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4451 incorrectly succeed when S was a string, because 4294967386 was
4452 truncated before it was used.
4453
8fd02eb7
PE
4454 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4455 Otherwise, an out-of-range integer could cause undefined behavior
4456 on a 64-bit host.
4457
f8c86b69
PE
4458 * composite.c: Use int, not EMACS_INT, for characters.
4459 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4460 EMACS_INT, for values that are known to be in character range.
4461 This doesn't fix any bugs but is the usual style inside Emacs and
4462 may generate better code on 32-bit machines.
4463
34206dd2
PE
4464 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4465 This is for reasons similar to the recent CHAR_STRING fix.
4466 * charset.c (Fencode_char): Check that character arg is actually
4467 a character. Pass an int to ENCODE_CHAR.
4468 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4469 wider than 'int', as a compile-time check to prevent future regressions
4470 in this area.
4471
c5958d4c 4472 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4473
4474 Make sure a 64-bit char is never passed to CHAR_STRING.
4475 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4476 by silently ignoring the top 32 bits, allowing some values
4477 that were far too large to be valid characters.
4478 * character.h: Include <verify.h>.
4479 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4480 arguments are no wider than unsigned, as a compile-time check
4481 to prevent future regressions in this area.
4482 * data.c (Faset):
01103c44 4483 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4484 (Fsubst_char_in_region):
4485 * fns.c (concat):
4486 * xdisp.c (decode_mode_spec_coding):
4487 Adjust to CHAR_STRING's new requirement.
4488 * editfns.c (Finsert_char, Fsubst_char_in_region):
4489 * fns.c (concat): Check that character args are actually
4490 characters. Without this test, these functions did the wrong
4491 thing with wildly out-of-range values on 64-bit hosts.
4492
d37ca623
PE
4493 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4494 These casts should not be needed on 32-bit hosts, either.
4495 * keyboard.c (read_char):
4496 * lread.c (Fload): Remove casts to unsigned.
4497
ea204efb
PE
4498 * lisp.h (UNSIGNED_CMP): New macro.
4499 This fixes comparison bugs on 64-bit hosts.
4500 (ASCII_CHAR_P): Use it.
4501 * casefiddle.c (casify_object):
01103c44 4502 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4503 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4504 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4505 * dispextern.h (FACE_FROM_ID):
4506 * keyboard.c (read_char): Use UNSIGNED_CMP.
4507
41cb286c
PE
4508 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4509 not to EMACS_INT, to avoid GCC warning.
4510
4a1b9832
PE
4511 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4512
55daad71
PE
4513 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4514 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4515 isn't needed on 32-bit machines.
8f95c75c 4516
01103c44
PE
4517 * buffer.c (Fgenerate_new_buffer_name):
4518 Use EMACS_INT for count, not int.
0ceccced 4519 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4520
4521 * data.c (Qcompiled_function): Now static.
4522
c6f072e7
PE
4523 * window.c (window_body_lines): Now static.
4524
20ce5912
PE
4525 * image.c (gif_load): Rename local to avoid shadowing.
4526
9c4c5f81
PE
4527 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4528 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4529 * alloc.c (make_save_value): Integer argument is now of type
4530 ptrdiff_t, not int.
4531 (mark_object): Use ptrdiff_t, not int.
4532 * lisp.h (pD): New macro.
4533 * print.c (print_object): Use it.
4534
c0c5c8ae
PE
4535 * alloc.c: Use EMACS_INT, not int, to count objects.
4536 (total_conses, total_markers, total_symbols, total_vector_size)
4537 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4538 (total_free_floats, total_floats, total_free_intervals)
4539 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4540 Now EMACS_INT, not int. All uses changed.
4541 (Fgarbage_collect): Compute overall total using a double, so that
4542 integer overflow is less likely to be a problem. Check for overflow
4543 when converting back to an integer.
5a25e253
PE
4544 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4545 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4546 These were 'int' variables that could overflow on 64-bit hosts;
4547 they were never used, so remove them instead of repairing them.
211a0b2a 4548 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4549 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4550 Previously, this ceilinged at INT_MAX, but that doesn't work on
4551 64-bit machines.
e46bb31a 4552 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4553
c78baabf 4554 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4555 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4556 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4557 when a (possibly-narrower) signed value would do just as well.
4558 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4559
c9d624c6
PE
4560 * alloc.c: Catch some string size overflows that we were missing.
4561 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4562 for convenience in STRING_BYTES_MAX.
4563 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4564 The definition here is exact; the one in lisp.h was approximate.
4565 (allocate_string_data): Check for string overflow. This catches
4566 some instances we weren't catching before. Also, it catches
4567 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4568 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4569 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4570
c9d624c6
PE
4571 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4572 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4573 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4574
353032ce
PE
4575 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4576
2bccce07
PE
4577 * alloc.c (Fmake_string): Check for out-of-range init.
4578
0ac30604
SM
45792011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4580
4581 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4582
c195f2de
JD
45832011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4584
4585 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4586 xg_get_default_scrollbar_width.
4587
4588 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4589 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4590 (style_changed_cb): Call update_theme_scrollbar_width and call
4591 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4592 all frames (Bug#8505).
4593 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4594 Call gtk_window_set_resizable if HAVE_GTK3.
4595 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4596 and height if HAVE_GTK3 (Bug#8505).
4597 (scroll_bar_width_for_theme): New variable.
4598 (update_theme_scrollbar_width): New function.
4599 (xg_get_default_scrollbar_width): Move code to
4600 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4601 (xg_initialize): Call update_theme_scrollbar_width.
4602
4603 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4604
4605 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4606
e10ac9f1
MR
46072011-06-12 Martin Rudalics <rudalics@gmx.at>
4608
4609 * frame.c (make_frame): Call other_buffer_safely instead of
4610 other_buffer.
4611
4612 * window.c (temp_output_buffer_show): Call display_buffer with
4613 second argument Vtemp_buffer_show_specifiers and reset latter
4614 immediately after the call.
4615 (Vtemp_buffer_show_specifiers): New variable.
4616 (auto_window_vscroll_p, next_screen_context_lines)
4617 (Vscroll_preserve_screen_position): Remove leading asterisks from
4618 doc-strings.
4619
2d3c217e 46202011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4621
7b7f97e8 4622 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4623 * buffer.c (Qclone_number): Remove for now, as it's unused.
4624 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4625 (record_buffer): Remove unused local.
4626 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4627 (set_frame_buffer_list): Remove; unused.
4628 * frame.h (other_visible_frames): Remove decl.
4629 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4630 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4631 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4632 if HAVE_GPM.
4633 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4634 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4635 Define only if HAVE_GPM.
4636 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4637 (update_hints_inhibit): Remove; never set. All uses removed.
4638 * widgetprv.h (emacsFrameClassRec): Remove decl.
4639 * window.c (delete_deletable_window): Now returns void, since it
4640 wasn't returning anything.
4641 (compare_window_configurations): Remove unused locals.
4642 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4643 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4644 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4645 the same widths as pointers. This follows up on the 2011-05-06 patch.
4646 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4647 * xterm.h: Likewise.
4648 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4649
1384b89e
JB
46502011-06-12 Juanma Barranquero <lekktu@gmail.com>
4651
4652 * makefile.w32-in: Update dependencies.
4653 (LISP_H): Add lib/intprops.h.
4654
1100a63c
CY
46552011-06-11 Chong Yidong <cyd@stupidchicken.com>
4656
4657 * image.c (gif_load): Add animation frame delay to the metadata.
4658 (syms_of_image): Use DEFSYM. New symbol `delay'.
4659
6198ccd0
MR
46602011-06-11 Martin Rudalics <rudalics@gmx.at>
4661
4662 * window.c (delete_deletable_window): Re-add.
4663 (Fset_window_configuration): Rewrite to handle dead buffers and
4664 consequently deletable windows.
4665 (window_tree, Fwindow_tree): Remove. Supply functionality in
4666 window.el.
4667 (compare_window_configurations): Simplify code.
4668
b6e3633c
AS
46692011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4670
1ab0dee5
AS
4671 * image.c (imagemagick_load_image): Fix type mismatch.
4672 (Fimagemagick_types): Likewise.
4673
b6e3633c
AS
4674 * window.h (replace_buffer_in_windows): Declare.
4675
9397e56f
MR
46762011-06-11 Martin Rudalics <rudalics@gmx.at>
4677
4678 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4679 Qclone_number. Remove external declaration of Qdelete_window.
4680 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4681 code.
640c8776
SM
4682 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4683 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4684 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4685 buffer list implementation.
4686 (other_buffer_safely): New function.
4687 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4688 calls to replace_buffer_in_windows and
4689 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4690 if allowed.
4691 (record_buffer): Inhibit quitting and rewrite using quittable
4692 functions. Run Qbuffer_list_update_hook if allowed.
4693 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4694 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4695 Move switch-to-buffer to window.el.
9397e56f
MR
4696 (bury-buffer): Move to window.el.
4697 (Vbuffer_list_update_hook): New variable.
4698
4699 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4700 section.
4701
4702 * window.h (resize_frame_windows): Move up in code.
4703 (Fwindow_frame): Remove EXFUN.
4704 (replace_buffer_in_all_windows): Remove prototype.
4705 (replace_buffer_in_windows_safely): Add prototype.
4706
4707 * window.c: Declare Qdelete_window static again. Move down
4708 declaration of select_count.
4709 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4710 (Fother_window): Move to window.el.
4711 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4712 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4713 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4714 window.el.
4715 (replace_buffer_in_windows): Implement by calling
4716 Qreplace_buffer_in_windows.
4717 (replace_buffer_in_all_windows): Remove with some functionality
4718 moved into replace_buffer_in_windows_safely.
4719 (replace_buffer_in_windows_safely): New function.
4720 (select_window_norecord, select_frame_norecord): Move in front
4721 of run_window_configuration_change_hook. Remove now obsolete
4722 declarations.
640c8776
SM
4723 (Fset_window_buffer): Rewrite doc-string.
4724 Call Qrecord_window_buffer.
9397e56f
MR
4725 (keys_of_window): Move binding for other-window to window.el.
4726
b50691aa
CY
47272011-06-11 Chong Yidong <cyd@stupidchicken.com>
4728
4729 * dispextern.h (struct image): Replace data member, whose int_val
4730 and ptr_val fields were not used by anything, with a single
4731 lisp_val object.
4732
4733 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4734 (gif_clear_image, gif_load, imagemagick_load_image)
4735 (gs_clear_image, gs_load): Callers changed.
4736
3f754b86
PE
47372011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4738
cca69397
PE
4739 * buffer.h: Include <time.h>, for time_t.
4740 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4741
109e28d0
PE
4742 Fix minor problems found by static checking.
4743
60737f02
PE
4744 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4745
4b66faf3
PE
4746 Make identifiers static if they are not used in other modules.
4747 * data.c (Qcompiled_function, Qframe, Qvector):
4748 * image.c (QimageMagick, Qsvg):
4749 * minibuf.c (Qmetadata):
4750 * window.c (resize_window_check, resize_root_window): Now static.
4751 * window.h (resize_window_check, resize_root_window): Remove decls.
4752
109e28d0
PE
4753 * window.c (window_deletion_count, delete_deletable_window):
4754 Remove; unused.
46a4ce9e
PE
4755 (window_body_lines): Now static.
4756 (Fdelete_other_windows_internal): Mark vars as initialized.
4757 Make sure 'resize_failed' is initialized.
4758 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4759 (resize_window_apply): Remove unused local.
4760 * window.h (delete_deletable_window): Remove decl.
4761
109e28d0 4762 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4763 (imagemagick_load_image): Fix pointer signedness problem by changing
4764 last arg from unsigned char * to char *. All uses changed.
4765 Also, fix a local for similar reasons.
4766 Remove unused locals. Remove locals to avoid shadowing.
4767 (fn_rsvg_handle_free): Remove; unused.
4768 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4769 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4770
3f754b86
PE
4771 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4772
2547adb1
CY
47732011-06-10 Chong Yidong <cyd@stupidchicken.com>
4774
4775 * image.c (gif_load): Fix omitted cast error introduced by
4776 2011-06-06 change.
4777
2c8e37d4
MR
47782011-06-10 Martin Rudalics <rudalics@gmx.at>
4779
4780 * window.h (resize_proportionally, orig_total_lines)
4781 (orig_top_line): Remove from window structure.
4782 (set_window_height, set_window_width, change_window_heights)
4783 (Fdelete_window): Remove prototypes.
4784 (resize_frame_windows): Remove duplicate declaration.
4785
440a42e3
EZ
47862011-06-10 Eli Zaretskii <eliz@gnu.org>
4787
4788 * window.h (resize_frame_windows, resize_window_check)
4789 (delete_deletable_window, resize_root_window)
4790 (resize_frame_windows): Declare prototypes.
4791
4792 * window.c (resize_window_apply): Make definition be "static" to
4793 match the prototype.
4794
562dd5e9
MR
47952011-06-10 Martin Rudalics <rudalics@gmx.at>
4796
4797 * window.c: Remove declarations of Qwindow_size_fixed,
4798 window_min_size_1, window_min_size_2, window_min_size,
4799 size_window, window_fixed_size_p, enlarge_window, delete_window.
4800 Remove static from declaration of Qdelete_window, it's
4801 temporarily needed by Fbury_buffer.
4802 (replace_window): Don't assign orig_top_line and
4803 orig_total_lines.
4804 (Fdelete_window, delete_window): Remove. Window deletion is
4805 handled by window.el.
640c8776
SM
4806 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4807 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4808 (Fdelete_other_windows): Remove. Deleting other windows is
4809 handled by window.el.
4810 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4811 handled in window.el.
4812 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4813 Window minimum sizes are handled in window.el.
4814 (shrink_windows, size_window, set_window_height)
4815 (set_window_width, change_window_heights, window_height)
4816 (window_width, CURBEG, CURSIZE, enlarge_window)
4817 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4818 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4819 handled in window.el.
4820 (make_dummy_parent): Rename to make_parent_window and give it a
4821 second argument horflag.
4822 (make_window): Don't set resize_proportionally any more.
4823 (Fsplit_window): Remove. Windows are split in window.el.
4824 (save_restore_action, save_restore_orig_size)
4825 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4826 Resize mini windows in window.el.
4827 (grow_mini_window, shrink_mini_window): Implement by calling
4828 Qresize_root_window_vertically, resize_window_check and
4829 resize_window_apply.
640c8776
SM
4830 (saved_window, Fset_window_configuration, save_window_save):
4831 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4832 resize_proportionally.
4833 (window_min_height, window_min_width): Move to window.el.
4834 (keys_of_window): Move bindings for delete-other-windows,
4835 split-window, delete-window and enlarge-window to window.el.
4836
4837 * buffer.c: Temporarily extern Qdelete_window.
4838 (Fbury_buffer): Temporarily call Qdelete_window instead of
4839 Fdelete_window (Fbury_buffer will move to window.el soon).
4840
4841 * frame.c (set_menu_bar_lines_1): Remove code handling
4842 orig_top_line and orig_total_lines.
4843
4844 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4845 set_window_height but set heights directly.
4846 (change_frame_size_1): Use resize_frame_windows.
4847
4848 * xdisp.c (init_xdisp): Don't use set_window_height but set
4849 heights directly.
4850
640c8776
SM
4851 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4852 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4853 run_window_configuration_change_hook.
4854
4855 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4856 instead of change_window_heights and run
4857 run_window_configuration_change_hook.
4858
1a13852e
MR
48592011-06-09 Martin Rudalics <rudalics@gmx.at>
4860
4861 * window.c (replace_window): Rename second argument REPLACEMENT to
4862 NEW. New third argument SETFLAG. Rewrite.
4863 (delete_window, make_dummy_parent): Call replace_window with
4864 third argument 1.
4865 (window_list_1): Move down in code.
4866 (run_window_configuration_change_hook): Move set_buffer part
4867 before select_frame_norecord part in order to unwind correctly.
4868 Rename count1 to count.
4869 (recombine_windows, delete_deletable_window, resize_root_window)
4870 (Fdelete_other_windows_internal)
4871 (Frun_window_configuration_change_hook, make_parent_window)
4872 (resize_window_check, resize_window_apply, Fresize_window_apply)
4873 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4874 (Fdelete_window_internal, Fresize_mini_window_internal):
4875 New functions.
1a13852e
MR
4876 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4877
f3d1777e
MR
48782011-06-08 Martin Rudalics <rudalics@gmx.at>
4879
496e208e
MR
4880 * window.h (window): Add some new members to window structure -
4881 normal_lines, normal_cols, new_total, new_normal, clone_number,
4882 splits, nest, prev_buffers, next_buffers.
4883 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4884 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4885
f3d1777e
MR
4886 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4887 Remove.
496e208e
MR
4888 (make_dummy_parent): Set new members of windows structure.
4889 (make_window): Move down in code. Handle new members of window
4890 structure.
4891 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4892 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4893 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4894 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4895 (Fset_window_next_buffers, Fset_window_clone_number):
4896 New functions.
496e208e
MR
4897 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4898 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4899 Doc-string fixes.
4900 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4901 Argument WINDOW can be now internal window too.
4902 (Fwindow_use_time): Move up in code.
4903 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4904 Rewrite doc-string.
4905 (Fset_window_configuration, saved_window)
4906 (Fcurrent_window_configuration, save_window_save): Handle new
4907 members of window structure.
b9e809c2
MR
4908 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4909 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4910 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4911 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4912 Qget_mru_window, Qresize_root_window,
4913 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4914 Qauto_buffer_name; staticpro them.
f3d1777e 4915
abde8f8c
MR
49162011-06-07 Martin Rudalics <rudalics@gmx.at>
4917
4918 * window.c (Fwindow_total_size, Fwindow_left_column)
4919 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4920 (Fwindow_list_1): New functions.
4921 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4922 (Fwindow_width, Fscroll_left, Fscroll_right):
4923 Use window_body_cols instead of window_box_text_cols.
4924 (delete_window, Fset_window_configuration):
4925 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4926 (delete_all_subwindows): Take a window as argument and not a
4927 structure. Rewrite.
190b47e6
MR
4928 (window_loop): Remove handling of GET_LRU_WINDOW and
4929 GET_LARGEST_WINDOW.
4930 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4931
4932 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4933 window_box_text_cols. delete_all_subwindows now takes a
4934 Lisp_Object as argument.
abde8f8c 4935
640c8776
SM
4936 * indent.c (compute_motion, Fcompute_motion):
4937 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4938
fa8a67e6
MR
4939 * frame.c (delete_frame): Call delete_all_subwindows with root
4940 window as argument.
4941
a54e3482
DC
49422011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4943
4944 * fns.c (Fputhash): Document return value.
4945
60002bf5
CY
49462011-06-06 Chong Yidong <cyd@stupidchicken.com>
4947
4948 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4949
0c671da6 49502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4951
b862a52a 4952 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4953
be44ca6c
PE
4954 Check for overflow when converting integer to cons and back.
4955 * charset.c (Fdefine_charset_internal, Fdecode_char):
4956 Use cons_to_unsigned to catch overflow.
4957 (Fencode_char): Use INTEGER_TO_CONS.
4958 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4959 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4960 * data.c (long_to_cons, cons_to_long): Remove.
4961 (cons_to_unsigned, cons_to_signed): New functions.
4962 These signal an error for invalid or out-of-range values.
4963 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4964 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4965 * font.c (Ffont_variation_glyphs):
4966 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4967 * lisp.h: Include <intprops.h>.
4968 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4969 (cons_to_signed, cons_to_unsigned): New decls.
4970 (long_to_cons, cons_to_long): Remove decls.
4971 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4972 (Fprimitive_undo): Use CONS_TO_INTEGER.
4973 * xfns.c (Fx_window_property): Likewise.
4974 * xselect.c: Include <limits.h>.
4975 (x_own_selection, selection_data_to_lisp_data):
4976 Use INTEGER_TO_CONS.
4977 (x_handle_selection_request, x_handle_selection_clear)
4978 (x_get_foreign_selection, Fx_disown_selection_internal)
4979 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4980 (lisp_data_to_selection_data): Use cons_to_unsigned.
4981 (x_fill_property_data): Use cons_to_signed.
4982 Report values out of range.
4983
d1f3d2af
PE
4984 Check for buffer and string overflow more precisely.
4985 * buffer.h (BUF_BYTES_MAX): New macro.
4986 * lisp.h (STRING_BYTES_MAX): New macro.
4987 * alloc.c (Fmake_string):
4988 * character.c (string_escape_byte8):
4989 * coding.c (coding_alloc_by_realloc):
4990 * doprnt.c (doprnt):
4991 * editfns.c (Fformat):
4992 * eval.c (verror):
4993 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4994 since they may not be the same number.
4995 * editfns.c (Finsert_char):
4996 * fileio.c (Finsert_file_contents):
4997 Likewise for BUF_BYTES_MAX.
4998
dd52fcea
PE
4999 * image.c: Use ptrdiff_t, not int, for sizes.
5000 (slurp_file): Switch from int to ptrdiff_t.
5001 All uses changed.
5002 (slurp_file): Check that file size fits in both size_t (for
5003 malloc) and ptrdiff_t (for sanity and safety).
5004
7f9bbdbb
PE
5005 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5006 if b->modtime has its maximal value.
5007
dfe18f82
PE
5008 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5009
84acfcf0
PE
5010 Don't assume time_t can fit into int.
5011 * buffer.h (struct buffer.modtime): Now time_t, not int.
5012 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5013 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5014
ccd9a01a
PE
5015 Minor fixes for signed vs unsigned integers.
5016 * character.h (MAYBE_UNIFY_CHAR):
5017 * charset.c (maybe_unify_char):
5018 * keyboard.c (read_char, reorder_modifiers):
5019 XINT -> XFASTINT, since the integer must be nonnegative.
5020 * ftfont.c (ftfont_spec_pattern):
5021 * keymap.c (access_keymap, silly_event_symbol_error):
5022 XUINT -> XFASTINT, since the integer must be nonnegative.
5023 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5024 since it makes no difference and we prefer signed.
5025 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5026 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5027 nonnegative.
5028
d6d100dd
SM
50292011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5030
5031 * window.h (Fwindow_frame): Declare.
5032
2b6148e4
PE
50332011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5034
5035 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5036 (SPARE_MEMORY): Always define.
5037 (LARGE_REQUEST): Remove.
5038 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5039
f230ecc9
MR
50402011-06-06 Martin Rudalics <rudalics@gmx.at>
5041
727e958e
MR
5042 * lisp.h: Move EXFUNS for Fframe_root_window,
5043 Fframe_first_window and Fset_frame_selected_window to window.h.
5044
5045 * window.h: Move EXFUNS for Fframe_root_window,
5046 Fframe_first_window and Fset_frame_selected_window here from
5047 lisp.h.
5048
5049 * frame.c (Fwindow_frame, Fframe_first_window)
5050 (Fframe_root_window, Fframe_selected_window)
5051 (Fset_frame_selected_window): Move to window.c.
5052 (Factive_minibuffer_window): Move to minibuf.c.
5053 (Fother_visible_frames_p): New function.
5054
5055 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5056
f230ecc9
MR
5057 * window.c (decode_window, decode_any_window): Move up in code.
5058 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5059 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5060 (Fwindow_buffer): Move up and rewrite doc-string.
5061 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5062 (Fwindow_prev): New functions.
727e958e
MR
5063 (Fwindow_frame): Move here from frame.c. Accept any window as
5064 argument.
5065 (Fframe_root_window, Fframe_first_window)
5066 (Fframe_selected_window): Move here from frame.c. Accept frame
5067 or arbitrary window as argument. Update doc-strings.
5068 (Fminibuffer_window): Move up in code.
5069 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5070 (Fset_frame_selected_window): Move here from frame.c.
5071 Marginal rewrite.
727e958e
MR
5072 (Fselected_window, select_window, Fselect_window): Move up in
5073 code. Minor doc-string fixes.
f230ecc9 5074
4d09bcf6
PE
50752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5076
5077 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5078 Do not assume that spare memory exists; that assumption is valid
5079 only if SYSTEM_MALLOC.
5080 (LARGE_REQUEST): New macro, so that the issue of large requests
5081 is separated from the issue of spare memory.
5082
810928a2
AS
50832011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5084
172418ad
AS
5085 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5086 format. (Bug#8806)
5087
43f862f7
AS
5088 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5089
810928a2
AS
5090 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5091 before statements.
5092
a059fe24
JD
50932011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5094
5095 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5096
5097 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5098
5099 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5100 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5101
989bf368
JB
51022011-06-05 Juanma Barranquero <lekktu@gmail.com>
5103
5104 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5105
4b80f674
CY
51062011-06-04 Chong Yidong <cyd@stupidchicken.com>
5107
5108 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5109 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5110 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5111 New error handlers.
4b80f674
CY
5112 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5113 Obey Vx_select_enable_clipboard_manager. Catch errors in
5114 x_clipboard_manager_save (Bug#8779).
5115 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5116 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5117
99a33b77 51182011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5119
5120 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5121
99a33b77 51222011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5123
5124 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5125 in the current matrix if keep_current_p is non-zero.
5126
8264569d
EZ
51272011-06-04 Eli Zaretskii <eliz@gnu.org>
5128
5129 * bidi.c (bidi_level_of_next_char): Fix last change.
5130
57f97249
EZ
51312011-06-03 Eli Zaretskii <eliz@gnu.org>
5132
fec2107c 5133 Support bidi reordering of text covered by display properties.
57f97249 5134
fec2107c
EZ
5135 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5136 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5137 (bidi_cache_search, bidi_cache_iterator_state)
5138 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5139 (bidi_level_of_next_char, bidi_move_to_visually_next):
5140 Support character positions inside a run of characters covered by a
fec2107c
EZ
5141 display string.
5142 (bidi_paragraph_init, bidi_resolve_explicit_1)
5143 (bidi_level_of_next_char): Call bidi_fetch_char and
5144 bidi_fetch_char_advance instead of FETCH_CHAR and
5145 FETCH_CHAR_ADVANCE.
5146 (bidi_init_it): Initialize new members.
5147 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5148 definitions.
5149 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5150 instead of using explicit *_CHAR codes.
d6d100dd
SM
5151 (bidi_resolve_explicit, bidi_resolve_weak):
5152 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5153 bidirectional text is supported only in multibyte buffers.
5154 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5155 it to initialize the frame_window_p member of struct bidi_it.
5156 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5157 (bidi_resolve_explicit, bidi_resolve_weak)
5158 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5159 bidi_it->nchars is non-positive.
5160 (bidi_level_of_next_char): Don't try to lookup the cache for the
5161 next/previous character if nothing is cached there yet, or if we
5162 were just reseat()'ed to a new position.
c40e2fb2 5163
0e14fe90
EZ
5164 * xdisp.c (set_cursor_from_row): Set start and stop points
5165 according to the row's direction when priming the loop that looks
5166 for the glyph on which to display cursor.
5167 (single_display_spec_intangible_p): Function deleted.
5168 (display_prop_intangible_p): Reimplement to call
5169 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5170 Accept 3 additional arguments needed by handle_display_spec.
5171 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5172 values: lists, `(when COND...)' forms, etc.
5173 (single_display_spec_string_p): Support property values that are
5174 lists with the argument STRING its top-level element.
5175 (display_prop_string_p): Fix the condition for processing a
5176 property that is a list to be consistent with handle_display_spec.
fec2107c 5177 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5178 last portion of handle_display_prop.
5179 (compute_display_string_pos): Accept additional argument
5180 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5181 value of a `display' property is a "replacing spec".
5182 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5183 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5184 the display property, but just return a value indicating whether
5185 the display property will replace the characters it covers.
5186 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5187 frame_window_p members of struct bidi_it.
d6d100dd
SM
5188 (compute_display_string_pos, compute_display_string_end):
5189 New functions.
fec2107c
EZ
5190 (push_it): Accept second argument POSITION, where pop_it should
5191 jump to continue iteration.
5192 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5193
fec2107c
EZ
5194 * keyboard.c (adjust_point_for_property): Adjust the call to
5195 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5196
5197 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5198 (bidi_init_it): Update prototypes.
5199 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5200 (compute_display_string_pos, compute_display_string_end):
5201 Declare prototypes.
fec2107c
EZ
5202 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5203 EMACS_INT.
fc6f18ce 5204
40087514 52052011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5206
57f53182
PE
5207 Malloc failure behavior now depends on size of allocation.
5208 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5209 * lisp.h: Change signatures accordingly.
5210 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5211 All callers changed. (Bug#8762)
5212
5213 * gnutls.c: Use Emacs's memory allocators.
5214 Without this change, the gnutls library would invoke malloc etc.
5215 directly, which causes problems on non-SYNC_INPUT hosts, and which
5216 runs afoul of improving memory_full behavior. (Bug#8761)
5217 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5218 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5219 xfree instead of the default malloc, realloc, free.
5220 (Fgnutls_boot): No need to check for memory allocation failure,
5221 since xmalloc does that for us.
5222
ac32cd99 5223 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5224 * category.c (hash_get_category_set):
5225 * ccl.c (ccl_driver):
5226 * charset.c (Fdefine_charset_internal):
5227 * charset.h (struct charset.hash_index):
5228 * composite.c (get_composition_id, gstring_lookup_cache)
5229 (composition_gstring_put_cache):
5230 * composite.h (struct composition.hash_index):
5231 * dispextern.h (struct image.hash):
5232 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5233 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5234 (hashfn_equal, hashfn_user_defined, make_hash_table)
5235 (maybe_resize_hash_table, hash_lookup, hash_put)
5236 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5237 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5238 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5239 * image.c (make_image, search_image_cache, lookup_image)
5240 (xpm_put_color_table_h):
5241 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5242 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5243 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5244 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5245 * alloc.c (allocate_vectorlike):
5246 Check for overflow in vector size calculations.
5247 * ccl.c (ccl_driver):
5248 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5249 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5250 need to be updated by these changes.
40087514
PE
5251 * fns.c (make_hash_table, maybe_resize_hash_table):
5252 Check for integer overflow with large hash tables.
0de4bb68
PE
5253 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5254 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5255 (SXHASH_REDUCE): New macro.
5256 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5257 Use it instead of discarding useful hash info with large hash values.
5258 (sxhash_float): New function.
5259 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5260 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5261 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5262 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5263 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5264 Adjust signatures to match updated version of code.
5265 (consing_since_gc): Now EMACS_INT, since a single hash table can
5266 use more than INT_MAX bytes.
5267
698d32e2
DN
52682011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5269
5270 Make it possible to build with GCC-4.6+ -O2 -flto.
5271
5272 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5273
fd6fa53f
SM
52742011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5275
5276 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5277 Call minibuffer-inactive-mode.
5278
864db017
JB
52792011-05-31 Juanma Barranquero <lekktu@gmail.com>
5280
5281 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5282 Update dependencies.
5283
2ad0baf4
DN
52842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5285
5286 * data.c (init_data): Remove code for UTS, this system is not
5287 supported anymore.
5288
4fcc2638
DN
52892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5290
5291 Don't force ./temacs to start in terminal mode.
5292
5293 * frame.c (make_initial_frame): Initialize faces in all cases, not
5294 only when CANNOT_DUMP is defined.
5295 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5296
c56e0fd5
DN
52972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5298
5299 * dispnew.c (add_window_display_history): Use const for the string
5300 pointer. Remove declaration, not needed.
5301
333d54da 53022011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5303
55d4c1b2 5304 Use 'inline', not 'INLINE'.
333d54da 5305 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5306 * alloc.c, fontset.c (INLINE): Remove.
5307 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5308 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5309 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5310 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5311 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5312
738db178
DN
53132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5314
5315 Make it possible to run ./temacs.
5316
5317 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5318 syms_of_callproc does the same thing. Remove test for
5319 "initialized", do it in the caller.
5320 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5321
620c53a6
SM
53222011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5323
5324 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5325 (read_minibuf): Use get_minibuffer.
5326 (syms_of_minibuf): Use DEFSYM.
5327 (Qmetadata): New var.
5328 * data.c (Qbuffer): Don't make it static.
5329 (syms_of_data): Use DEFSYM.
5330
e003a292
PE
53312011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5332
5333 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5334 (CCL_CODE_MIN): New macro.
5335
ed008a6d
PE
53362011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5337
3687c2ef
PE
5338 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5339
ed008a6d
PE
5340 * eval.c (Qdebug): Now static.
5341 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5342 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5343 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5344
d66c4c7c
CY
53452011-05-29 Chong Yidong <cyd@stupidchicken.com>
5346
5347 * image.c: Various fixes to ImageMagick code comments.
5348 (Fimagemagick_types): Doc fix.
5349
5fbc2025
PE
53502011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5351
0196f88a
PE
5352 Minor fixes prompted by GCC 4.6.0 warnings.
5353
5354 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5355
5fbc2025
PE
5356 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5357 (x_clipboard_manager_save_all): Move extern decl to ...
5358 * xterm.h: ... here, so that it can be checked for consistency.
5359
1dd3c2d9
CY
53602011-05-29 Chong Yidong <cyd@stupidchicken.com>
5361
5362 * xselect.c (x_clipboard_manager_save_frame)
5363 (x_clipboard_manager_save_all): New functions.
5364 (Fx_clipboard_manager_save): Lisp function deleted.
5365
5366 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5367 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5368
5369 * xterm.h: Update prototype.
5370
5ba6571d
WX
53712011-05-28 William Xu <william.xwl@gmail.com>
5372
5373 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5374 exiting (Bug#8239).
5375
3eaff834
JM
53762011-05-28 Jim Meyering <meyering@redhat.com>
5377
e1900994 5378 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5379 * fns.c (to_uchar): Define.
5380 (crypto_hash_function): Use it to convert some newly-signed
5381 variables to unsigned, to avoid sign-extension bugs. For example,
5382 without this change, (md5 "truc") would evaluate to
5383 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5384 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5385 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5386
0f6990a7
PE
53872011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5388
5389 Integer overflow fixes.
c8a9ca5a 5390
08686060
PE
5391 * dbusbind.c: Serial number integer overflow fixes.
5392 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5393 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5394 to hold a serial number that is too large for a fixnum.
5395 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5396 Check for serial numbers out of range. Decode any serial number
59568bf0 5397 that was so large that it became a float. (Bug#8722)
08686060 5398
2d1fc3c7
PE
5399 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5400 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5401 Use XFASTINT rather than XUINT when numbers are nonnegative.
5402 (xd_append_arg, Fdbus_method_return_internal):
5403 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5404 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5405 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5406 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5407 (Bug#8722)
2d1fc3c7 5408
c8a9ca5a
PE
5409 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5410
519e1d69
PE
5411 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5412
30569699
PE
5413 ccl: add integer overflow checks
5414 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5415 (IN_INT_RANGE): New macros.
5416 (ccl_driver): Use them to check for integer overflow when
5417 decoding a CCL program. Many of the new checks are whether XINT (x)
5418 fits in int; it doesn't always, on 64-bit hosts. The new version
5419 doesn't catch all possible integer overflows, but it's an
847044ea 5420 improvement. (Bug#8719)
30569699 5421
c11285dc
PE
5422 * alloc.c (make_event_array): Use XINT, not XUINT.
5423 There's no need for unsigned here.
5424
fdccd48e
PE
5425 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5426 This follows up to the 2011-05-06 change that substituted uintptr_t
5427 for EMACS_INT. This case wasn't caught back then.
5428
37910ab2
PE
5429 Rework Fformat to avoid integer overflow issues.
5430 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5431 now (part of C89). Include <verify.h>.
5432 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5433 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5434 (Fformat): Avoid the prepass trying to compute sizes; it was only
5435 approximate and thus did not catch overflow reliably. Instead, walk
5436 through the format just once, formatting and computing sizes as we go,
5437 checking for integer overflow at every step, and allocating a larger
5438 buffer as needed. Keep track separately whether the format is
5439 multibyte. Keep only the most-recently calculated precision, rather
5440 than them all. Record whether each argument has been converted to
5441 string. Use EMACS_INT, not int, for byte and char and arg counts.
5442 Support field widths and precisions larger than INT_MAX. Avoid
5443 sprintf's undefined behavior with conversion specifications such as %#d
5444 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5445 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5446 formatting out-of-range floating point numbers with int
9173deec 5447 formats. (Bug#8668)
37910ab2 5448
2e6578fb
PE
5449 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5450
0ae6bdee
PE
5451 * data.c: Avoid integer truncation in expressions involving floats.
5452 * data.c: Include <intprops.h>.
5453 (arith_driver): When there's an integer overflow in an expression
5454 involving floating point, convert the integers to floating point
5455 so that the resulting value does not suffer from catastrophic
5456 integer truncation. For example, on a 64-bit host (* 4
5457 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5458 Do not rely on undefined behavior after integer overflow.
5459
de883a70
PE
5460 merge count_size_as_multibyte, parse_str_to_multibyte
5461 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5462 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5463 Check for integer overflow.
5464 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5465 since it's now a duplicate of the other. This is more of
5466 a character than a buffer op, so better that it's in character.c.
5467 * fns.c, print.c: Adjust to above changes.
5468
2ff916cb
PE
54692011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5470
5471 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5472
f1b54466
PE
54732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5474
fb1ac845
PE
5475 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5476 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5477 (x_clipboard_manager_save): Now static.
5478 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5479
f1b54466
PE
5480 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5481 (crypto_hash_function): Now static.
5482 Fix pointer signedness problems. Avoid unnecessary initializations.
5483
a9f737ee
CY
54842011-05-27 Chong Yidong <cyd@stupidchicken.com>
5485
5486 * termhooks.h (Vselection_alist): Make it terminal-local.
5487
5488 * terminal.c (create_terminal): Initialize it.
5489
5490 * xselect.c: Support for clipboard managers.
5491 (Vselection_alist): Move to termhooks.h as terminal-local var.
5492 (LOCAL_SELECTION): New macro.
5493 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5494 (symbol_to_x_atom): Remove gratuitous arg.
5495 (x_handle_selection_request, lisp_data_to_selection_data)
5496 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5497 (x_own_selection, x_get_local_selection, x_convert_selection):
5498 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5499 (some_frame_on_display): Delete unused function.
5500 (Fx_own_selection_internal, Fx_get_selection_internal)
5501 (Fx_disown_selection_internal, Fx_selection_owner_p)
5502 (Fx_selection_exists_p): New optional frame arg.
5503 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5504 (x_handle_selection_clear): Don't treat other terminals with the
5505 same keyboard specially. Use the terminal-local Vselection_alist.
5506 (x_clear_frame_selections): Use Frun_hook_with_args.
5507
5508 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5509
5510 * xterm.h: Add support for those atoms.
5511
e067f0c1
CY
55122011-05-26 Chong Yidong <cyd@stupidchicken.com>
5513
5514 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5515 (converted_selections, conversion_fail_tag): New global variables.
5516 (x_selection_request_lisp_error): Free the above.
5517 (x_get_local_selection): Remove unnecessary code.
5518 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5519 of converted selections stored in converted_selections.
5520 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5521 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5522 (x_convert_selection): New function.
5523 (x_handle_selection_event): Simplify.
5524 (x_get_foreign_selection): Don't ignore incoming requests while
5525 waiting for an answer; this will fail when we implement
5526 SAVE_TARGETS, and seems unnecessary anyway.
5527 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5528 (Vx_sent_selection_functions): Doc fix.
5529
0f4aebc0
LL
55302011-05-26 Leo Liu <sdl.web@gmail.com>
5531
5532 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5533
e61124cd
YM
55342011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5535
5536 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5537
5538 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5539 for fringe update if it has periodic bitmap.
ac389d0c 5540 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5541 and fringe_bitmap_periodic_p.
5542
5543 * fringe.c (get_fringe_bitmap_data): New function.
5544 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5545 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5546 row. Mark glyph row for fringe update if periodicity changed.
5547
5548 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5549 for fringe update unless it has periodic bitmap.
5550
f16d9837
KH
55512011-05-25 Kenichi Handa <handa@m17n.org>
5552
5553 * xdisp.c (get_next_display_element): Set correct it->face_id for
5554 a static composition.
5555
e1b90ef6
LL
55562011-05-24 Leo Liu <sdl.web@gmail.com>
5557
5558 * deps.mk (fns.o):
5559 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5560
5561 * fns.c (crypto_hash_function, Fsha1): New function.
5562 (Fmd5): Use crypto_hash_function.
5563 (syms_of_fns): Add Ssha1.
5564
7400048f
PE
55652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5566
5567 * gnutls.c: Remove unused macros.
5568 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5569 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5570 Remove macros that are defined and never used.
5571 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5572
abb71cf4
CY
55732011-05-22 Chong Yidong <cyd@stupidchicken.com>
5574
5575 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5576 (Fx_get_selection_internal): Minor cleanup.
5577 (Fx_own_selection_internal): Rename arguments for consistency with
5578 select.el.
5579
6307db39
PE
55802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5581
5582 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5583
f3d4e0a4
CY
55842011-05-22 Chong Yidong <cyd@stupidchicken.com>
5585
5586 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5587
4d8ade89
YM
55882011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5589
5590 * dispnew.c (scrolling_window): Don't exclude the case that the
5591 last enabled row in the desired matrix touches the bottom boundary.
5592
32078c8d
GM
55932011-05-21 Glenn Morris <rgm@gnu.org>
5594
5595 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5596 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5597 and add some more files.
32078c8d 5598
7285dc67
EZ
55992011-05-20 Eli Zaretskii <eliz@gnu.org>
5600
5601 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5602 report_file_error introduced by the change from 2011-05-07.
5603
89d1bd22
PE
56042011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5605
5606 * systime.h (Time): Define only if emacs is defined.
5607 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5608 where the include path doesn't have X11/X.h by default. See
5609 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5610
e23640bb 56112011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5612
5613 * composite.c (find_automatic_composition): Fix previous change.
5614
b9704ad9
GM
56152011-05-20 Glenn Morris <rgm@gnu.org>
5616
5617 * lisp.mk: New file, split from Makefile.in.
5618 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5619 (shortlisp): Remove.
5620 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5621
4a720484
GM
56222011-05-19 Glenn Morris <rgm@gnu.org>
5623
5624 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5625 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5626 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5627 (lisp): Set the order to that of loadup.el.
5628 (shortlisp): Make it a copy of $lisp.
5629 (SOME_MACHINE_LISP): Remove.
5630 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5631 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5632
a28d4396
KH
56332011-05-18 Kenichi Handa <handa@m17n.org>
5634
5635 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5636 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5637 (find_automatic_composition): Mostly rewrite for efficiency.
5638
a2b1fa8e
JB
56392011-05-18 Juanma Barranquero <lekktu@gmail.com>
5640
5641 * makefile.w32-in: Update dependencies.
5642
8e1f5610
CS
56432011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5644
5645 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5646 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5647
7025ee00 56482011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5649
cdfa6eab
PE
5650 Fix some integer overflow issues, such as string length overflow.
5651
06d6db33
PE
5652 * insdel.c (count_size_as_multibyte): Check for string overflow.
5653
2b4560a8
PE
5654 * character.c (lisp_string_width): Check for string overflow.
5655 Use EMACS_INT, not int, for string indexes and lengths; in
5656 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5657 the resulting string length overflows an EMACS_INT; instead,
5658 report a string overflow if no precision given. When checking for
5659 precision exhaustion, use a check that cannot possibly have
5660 integer overflow. (Bug#8675)
5661 * character.h (lisp_string_width): Adjust to new signature.
5662
cb93f9be
PE
5663 * alloc.c (string_overflow): New function.
5664 (Fmake_string): Use it. This doesn't change behavior, but saves
5665 a few bytes and will simplify future changes.
5666 * character.c (string_escape_byte8): Likewise.
5667 * lisp.h (string_overflow): New decl.
5668
1a1f3366
PE
5669 Fixups, following up to the user-interface timestamp change.
5670 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5671 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5672 * msdos.c (mouse_get_pos): Likewise.
5673 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5674 * w32gui.h (Time): Define by including "systime.h" rather than by
5675 declaring it ourselves. (Bug#8664)
5676
d4e3e4d3
PE
5677 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5678 * image.c (clear_image_cache): Likewise.
5679
f6a24d19
PE
5680 * term.c (term_mouse_position): Don't assume time_t wraparound.
5681
08dc5ae6
PE
5682 Be more systematic about user-interface timestamps.
5683 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5684 and sometimes 'EMACS_UINT', to represent these timestamps.
5685 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5686 This makes the code easier to follow, and makes it easier to catch
5687 integer overflow bugs such as Bug#8664.
5688 * frame.c (Fmouse_position, Fmouse_pixel_position):
5689 Use Time, not unsigned long, for user-interface timestamps.
5690 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5691 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5692 * keyboard.h (last_event_timestamp): Likewise.
5693 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5694 * menu.h (xmenu_show): Likewise.
5695 * term.c (term_mouse_position): Likewise.
5696 * termhooks.h (struct input_event.timestamp): Likewise.
5697 (struct terminal.mouse_position_hook): Likewise.
5698 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5699 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5700 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5701 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5702 what it was before.
5703 * menu.h, termhooks.h: Include "systime.h", for Time.
5704
8e55734a
PE
5705 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5706 Don't assume that the difference between two unsigned long values
5707 can fit into an integer. At this point, we know button_down_time
5708 <= event->timestamp, so the difference must be nonnegative, so
5709 there's no need to cast the result if double-click-time is
5710 nonnegative, as it should be; check that it's nonnegative, just in
5711 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5712 apart (about 25 days). (Bug#8664)
8e55734a 5713
841f1b75 5714 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5715 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5716
3e26f69c
PE
5717 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5718 that always fit in int. Use a sentinel instead of a counter, to
5719 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5720 * frame.h (struct frame): Use int for menu_bar_items_used
5721 instead of EMACS_INT, since it always fits in int.
3e26f69c 5722
5cc152c0
PE
5723 * menu.c (grow_menu_items): Check for int overflow.
5724
d89eb65e
PE
5725 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5726
5235bd3e
PE
5727 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5728 Before, the code was not consistent. These values cannot exceed
5729 2**31 - 1 so there's no need to make them unsigned.
5730 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5731 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5732 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5733 as modifiers.
5734 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5735
bc827e23
PE
5736 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5737 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5738 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5739 presumably because the widths might not match.
5740
78eb494e
PE
5741 * window.c (size_window): Avoid needless test at loop start.
5742
04f2d78b
CB
57432011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5744
5745 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5746
d2fc7e3d 57472011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5748
5749 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5750
d2fc7e3d 57512011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5752
5753 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5754 `width' to `bar_area_x' and `bar_area_width', respectively.
5755 (x_scroll_run): Take account of fringe background extension.
5756
04f2d78b
CB
5757 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5758 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5759 `bar_area_width', respectively.
5760 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5761 background extension.
5762
79b70037
GM
57632011-05-10 Jim Meyering <meyering@redhat.com>
5764
5765 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5766
2f142cc5
JB
57672011-05-10 Juanma Barranquero <lekktu@gmail.com>
5768
5769 * image.c (Finit_image_library): Return t for built-in image types,
5770 like pbm and xbm. (Bug#8640)
5771
57679c86
AS
57722011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5773
5774 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5775
888c9e86
EZ
57762011-05-07 Eli Zaretskii <eliz@gnu.org>
5777
b0512a1d
EZ
5778 * w32console.c (Fset_screen_color): Doc fix.
5779 (Fget_screen_color): New function.
5780 (syms_of_ntterm): Defsubr it.
5781
7285dc67
EZ
5782 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5783 unlink the temporary file if Fcall_process didn't create it in the
5784 first place.
5785 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5786 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5787 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5788 cue to call_process_cleanup not to close that handle.
5789
4d3fcc8e
BK
57902011-05-07 Ben Key <bkey76@gmail.com>
5791
5792 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5793 one of two shell specific rules, either bootstrap-temacs-CMD or
5794 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5795 to the previous implementation of the bootstrap-temacs rule.
5796 The bootstrap-temacs-CMD rule is similar to the previous
5797 implementation of the bootstrap-temacs rule except that it
5798 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5799 variable.
5800
5801 These changes, along with some changes to nt/configure.bat,
5802 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5803 earlier fix to add support for --cflags and --ldflags options
5804 that include quotes so that it works whether make uses cmd or
5805 sh as the shell.
5806
b4289b64
MA
58072011-05-06 Michael Albinus <michael.albinus@gmx.de>
5808
5809 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5810 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5811 is a constant.
5812 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5813 a string. Handle both cases.
5814 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5815 (Fdbus_register_method): Use Qinvalid_function.
5816
af4c0e28
JB
58172011-05-06 Juanma Barranquero <lekktu@gmail.com>
5818
5819 * makefile.w32-in: Update dependencies.
5820 (LISP_H): Add inttypes.h and stdin.h.
5821 (PROCESS_H): Add unistd.h.
5822
c51453d9
EZ
58232011-05-06 Eli Zaretskii <eliz@gnu.org>
5824
5825 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5826 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5827
8ff0ac3c 58282011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5829
4c4b566b
PE
5830 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5831
aab2b9b5
PE
5832 * term.c (vfatal): Remove stray call to va_end.
5833 It's not needed and the C Standard doesn't allow it here anyway.
5834
c378da0b
PE
5835 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5836 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5837
288b08c7
PE
5838 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5839 bytes.
5840
e3601888
PE
5841 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5842
db6c0e74
PE
5843 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5844
dd5963ea
PE
5845 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5846
88c9450f
PE
5847 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5848
2f9442b8
PE
5849 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5850
c032b5f8
PE
5851 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5852 * charset.c (Fdefine_charset_internal): Don't initialize
5853 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5854 32-bit int (Bug#8600).
a108c10b
PE
5855
5856 * lread.c (read_integer): Be more consistent with string-to-number.
5857 Use string_to_number to do the actual conversion; this avoids
5858 rounding errors and fixes some other screwups. Without this fix,
5859 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5860 (digit_to_number): Move earlier, for benefit of read_integer.
5861 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5862 not a digit in any supported base. (Bug#8602)
a108c10b 5863
ad5f9eea
PE
5864 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5865
aec1708a
PE
5866 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5867 to match comment at start of function. This also removes a
5868 GCC warning about overflow in a 32+64-bit port.
5869
47be4ab5
PE
5870 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5871
371cac43
PE
5872 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5873 Reported by Stefan Monnier in
5874 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5875 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5876 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5877
d01a7826
PE
5878 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5879 (EMACS_UINTPTR): Likewise, with uintptr_t.
5880
7fd47d5c
PE
5881 * lisp.h: Prefer 64-bit EMACS_INT if available.
5882 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5883 on 32-bit hosts that have 64-bit int, so that they can access
5884 large files.
122b0c86
PE
5885 However, temporarily disable this change unless the temporary
5886 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5887
8727937b
PE
5888 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5889
8ac068ac
PE
5890 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5891 This removes an assumption that EMACS_INT and long are the same
5892 width as pointers. The assumption is true for Emacs porting targets
5893 now, but we want to make other targets possible.
5894 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5895 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5896 In the rest of the code, change types of integers that hold casted
5897 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5898 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5899 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5900 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5901 No need to cast type when ORing.
5902 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5903 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5904 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5905 assume EMACS_INT is the same width as char *.
5906 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5907 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5908 Remove no-longer-needed casts.
5909 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5910 (xg_tool_bar_help_callback, xg_make_tool_item):
5911 Use EMACS_INTPTR to hold an integer
5912 that will be cast to void *; this can avoid a GCC warning
5913 if EMACS_INT is not the same width as void *.
5914 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5915 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5916 (current_message_1, set_message_1):
5917 Use a local to convert to proper width without a cast.
5918 * xmenu.c (dialog_selection_callback): Likewise.
5919
ede49d71
PE
5920 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5921 Also, don't assume VALBITS / RAND_BITS is less than 5,
5922 and don't rely on undefined behavior when shifting a 1 left into
5923 the sign bit.
5924 * lisp.h (get_random): Change signature to match.
5925
2f30ecd0
PE
5926 * lread.c (hash_string): Use size_t, not int, for hash computation.
5927 Normally we prefer signed values; but hashing is special, because
5928 it's better to use unsigned division on hash table sizes so that
5929 the remainder is nonnegative. Also, size_t is the natural width
5930 for hashing into memory. The previous code used 'int', which doesn't
5931 retain enough info to hash well into very large tables.
5932 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5933
2a866e7b
PE
5934 * dbusbind.c: Don't possibly lose pointer info when converting.
5935 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5936 Use XPNTR rather than XHASH, so that the high-order bits of
5937 the pointer aren't lost when converting through void *.
5938
51639eac
PE
5939 * eval.c (Fautoload): Don't double-shift a pointer.
5940
92394119
PE
5941 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5942
dbdb9a7c
JB
59432011-05-06 Juanma Barranquero <lekktu@gmail.com>
5944
5945 * gnutls.c (DEF_GNUTLS_FN):
5946 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5947
db7a0b4f
AS
59482011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5949
5950 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5951 marker. (Bug#8610)
5952
f7ff1b0f 59532011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5954
5955 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5956 New version that can reserve upto 2GB of heap space.
5957
f7ff1b0f 59582011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5959
5960 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5961
639c109b
TZ
59622011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5963
5964 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5965 `gnutls_certificate_set_x509_key_file'.
5966
d2127135
JB
59672011-05-05 Juanma Barranquero <lekktu@gmail.com>
5968
5969 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5970 Update dependencies.
5971
e968f4f3
JB
59722011-05-04 Juanma Barranquero <lekktu@gmail.com>
5973
5974 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5975 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5976 Remove unused parameter `fildes'.
5977 * process.c (read_process_output, send_process): Don't pass it.
5978
84d358f0
JB
59792011-05-04 Juanma Barranquero <lekktu@gmail.com>
5980
5981 Fix previous change: the library cache is defined in w32.c.
5982 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5983 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5984
0898ca10
JB
59852011-05-04 Juanma Barranquero <lekktu@gmail.com>
5986
5987 Implement dynamic loading of GnuTLS on Windows.
5988
5989 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5990 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5991 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5992 Declare.
5993
5994 * gnutls.c (Qgnutls_dll): Define.
5995 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5996 (gnutls_*): Declare function pointers.
5997 (init_gnutls_functions): New function to initialize function pointers.
5998 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5999 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6000 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6001 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6002 (emacs_gnutls_write, emacs_gnutls_read)
6003 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6004 (Fgnutls_available_p): New function.
6005 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6006 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6007 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6008
6009 * image.c: Include w32.h.
6010 (Vimage_type_cache): Delete.
6011 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6012 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6013 (w32_delayed_load): Move to w32.c.
6014
6015 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6016
6017 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6018 (w32_delayed_load): Move from image.c. When loading a library, record
6019 its filename in the :loaded-from property of the library id.
6020 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6021 Initialize and staticpro them.
6022 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6023
6024 * process.c: Include lisp.h before w32.h, not after.
6025 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6026 instead of gnutls_record_check_pending.
6027
6028 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6029
ff4de4aa
TZ
60302011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6031
6032 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6033 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6034 as passed in.
6035
abe95abb
JD
60362011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6037
6038 * xterm.c (x_set_frame_alpha): Do not set property on anything
6039 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6040
e16e55d4
JB
60412011-05-02 Juanma Barranquero <lekktu@gmail.com>
6042
6043 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6044
bafcf6a5
JB
60452011-05-02 Juanma Barranquero <lekktu@gmail.com>
6046
6047 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6048 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6049 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6050 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6051 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6052 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6053 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6054 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6055 (Qgnutls_bootprop_callbacks_verify): Make static.
6056
e7a6747f
AS
60572011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6058
19ed11ba
AS
6059 * callproc.c: Indentation fixup.
6060
e7a6747f 6061 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6062 (wait_for_termination, interruptible_wait_for_termination):
6063 Move after wait_for_termination_1.
e7a6747f 6064
1ef14cb4
LMI
60652011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6066
6067 * sysdep.c (interruptible_wait_for_termination): New function
6068 which is like wait_for_termination, but allows keyboard
6069 interruptions.
6070
6071 * callproc.c (Fcall_process): Add (:file "file") as an option for
6072 the STDOUT buffer.
6073 (Fcall_process_region): Ditto.
6074
330d880c
EZ
60752011-04-30 Eli Zaretskii <eliz@gnu.org>
6076
8db90b73
EZ
6077 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6078 rather than `XVECTOR (FOO)->size'.
6079
330d880c
EZ
6080 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6081 inttypes.h, as a gnulib replacement is used if it not available in
6082 system headers.
6083
15cbd324
EZ
60842011-04-21 Eli Zaretskii <eliz@gnu.org>
6085
6086 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6087 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6088 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6089
6090 * coding.c (coding_alloc_by_realloc): Error out if destination
6091 will grow beyond MOST_POSITIVE_FIXNUM.
6092 (decode_coding_emacs_mule): Abort if there isn't enough place in
6093 charbuf for the composition carryover bytes. Reserve an extra
6094 space for up to 2 characters produced in a loop.
6095 (decode_coding_iso_2022): Abort if there isn't enough place in
6096 charbuf for the composition carryover bytes.
6097
60982011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6099
ae940cca
EZ
6100 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6101 aborting when %lld or %lll format is passed.
6102 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6103 %llo or %llx format is passed. (Bug#8545)
6104
03ab8921
EZ
6105 * window.c (window_scroll_line_based): Use a marker instead of
6106 simple variables to record original value of point. (Bug#7952)
6107
afda1437
EZ
6108 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6109 produced by %s or %c overflows available buffer space. (Bug#8545)
6110
f76dee0c
PE
61112011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6112
6113 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6114 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6115
fdc5744d
JB
61162011-04-28 Juanma Barranquero <lekktu@gmail.com>
6117
6118 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6119
638f053a
JB
61202011-04-28 Juanma Barranquero <lekktu@gmail.com>
6121
6122 * keyboard.c (Qdelayed_warnings_hook): Define.
6123 (command_loop_1): Run `delayed-warnings-hook'
6124 if Vdelayed_warnings_list is non-nil.
6125 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6126 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6127
d178f871
EZ
61282011-04-28 Eli Zaretskii <eliz@gnu.org>
6129
6130 * doprnt.c (doprnt): Don't return value smaller than the buffer
6131 size if the message was truncated. (Bug#8545).
6132
b124fd93
JB
61332011-04-28 Juanma Barranquero <lekktu@gmail.com>
6134
6135 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6136 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6137
e810457d
PE
61382011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6139
6140 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6141
ea51cceb
JB
61422011-04-27 Juanma Barranquero <lekktu@gmail.com>
6143
6144 * makefile.w32-in: Update dependencies.
6145
94dcfacf
EZ
61462011-04-27 Eli Zaretskii <eliz@gnu.org>
6147
6148 Improve `doprnt' and its usage. (Bug#8545)
6149 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6150 `format_end'. Remove support for %l as a conversion specifier.
6151 Don't use xrealloc. Improve diagnostics when the %l size modifier
6152 is used. Update the commentary.
6153
6154 * eval.c (verror): Simplify calculation of size_t.
6155
6156 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6157 messages.
6158
f61f41d7
PE
61592011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6160
6161 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6162 change.
6163
96fb4434
PE
61642011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6165
6166 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6167 This makes this file independent of the recent pseudovector change.
6168
671875da 61692011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6170
69e9b5a3
PE
6171 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6172
b5f869a7 6173 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6174 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6175 Remove unused local.
c8926152 6176 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6177
841a1577 6178 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6179 GCC 4.6.0 optimizes based on type-based alias analysis.
6180 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6181 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6182 != &v->size, and therefore "v->size = 1; b->size = 2; return
6183 v->size;" must therefore return 1. This assumption is incorrect
6184 for Emacs, since it type-puns struct Lisp_Vector * with many other
6185 types. To fix this problem, this patch adds a new type struct
f904488f 6186 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6187 and pseudovectors, and helps optimizing compilers not get fooled
6188 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6189 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6190 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6191 the size member.
eab3844f
PE
6192 (XSETPVECTYPE): Rewrite in terms of new macro.
6193 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6194 This is a bit clearer, and further avoids the possibility of
6195 undesirable aliasing.
6196 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6197 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6198 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6199 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6200 (ASIZE): Now uses header.size rather than size.
6201 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6202 to avoid the hassle of writing XVECTOR (foo)->header.size.
6203 (struct vectorlike_header): New type.
eab3844f
PE
6204 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6205 object, to help avoid aliasing.
6206 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6207 (SUBRP): Likewise, since Lisp_Subr is a special case.
6208 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6209 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6210 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6211 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6212 changed to be "header.size" and "header.next".
6213 * buffer.h (struct buffer): Likewise.
6214 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6215 * frame.h (struct frame): Likewise.
6216 * process.h (struct Lisp_Process): Likewise.
6217 * termhooks.h (struct terminal): Likewise.
6218 * window.c (struct save_window_data, struct saved_window): Likewise.
6219 * window.h (struct window): Likewise.
6220 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6221 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6222 * buffer.c (init_buffer_once): Likewise.
6223 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6224 special case.
6225 * process.c (Fformat_network_address): Use local var for size,
6226 for brevity.
6227
0df1eac5
PE
6228 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6229
847ab9d1 6230 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6231 * data.c (atof): Remove decl; no longer used or needed.
6232 (digit_to_number): Move to lread.c.
6233 (Fstring_to_number): Use new string_to_number function, to be
6234 consistent with how the Lisp reader treats infinities and NaNs.
6235 Do not assume that floating-point numbers represent EMACS_INT
6236 without losing information; this is not true on most 64-bit hosts.
6237 Avoid double-rounding errors, by insisting on integers when
6238 parsing non-base-10 numbers, as the documentation specifies.
6239 * lisp.h (string_to_number): New decl, replacing ...
6240 (isfloat_string): Remove.
bc0a5c13 6241 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6242 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6243 appears to have been a coding error. Similarly, do not accept
6244 strings like +-1e0 as floating point numbers. Do not report
6245 overflow for integer overflows unless the base is not 10 which
6246 means we have no simple and reliable way to continue.
6247 Break out the floating-point parsing into a new
6248 function string_to_number, so that Fstring_to_number parses
6249 floating point numbers consistently with the Lisp reader.
04f2d78b 6250 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6251 (E_CHAR, EXP_INT): Remove, replacing with ...
6252 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6253 (string_to_number): New function, replacing isfloat_string.
6254 This function checks for valid syntax and produces the resulting
6255 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6256 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6257 so that overflow for non-base-10 numbers is reported only when
6258 there's no portable and simple way to convert to floating point.
452f4150 6259
67769ffc
PE
6260 * textprop.c (set_text_properties_1): Rewrite for clarity,
6261 and to avoid GCC warning about integer overflow.
6262
c20db43f
PE
6263 * intervals.h (struct interval): Use EMACS_INT for members
6264 where EMACS_UINT might cause problems. See
6265 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6266 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6267 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6268 All uses changed.
37aa2f85
PE
6269 (offset_intervals): Tell GCC not to worry about length overflow
6270 when negating a negative length.
c20db43f 6271
2538aa2f
PE
6272 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6273 (overrun_check_free): Likewise.
6274
f2d3008d
PE
6275 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6276 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6277 word size.
6278
ec8df744
PE
6279 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6280 (gnutls_make_error): Rename local to avoid shadowing.
6281 (gnutls_emacs_global_deinit): ifdef out; not used.
6282 (Fgnutls_boot): Use const for pointer to readonly storage.
6283 Comment out unused local. Fix pointer signedness problems.
6284
640ee02d
PE
6285 * lread.c (openp): Don't stuff size_t into an 'int'.
6286 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6287 about possible signed overflow.
6288
6048fb2a
PE
6289 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6290 (GDK_KEY_g): Don't define if already defined.
6291 (xg_prepare_tooltip): Avoid pointer signedness problem.
6292 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6293
fa3c87e1
PE
6294 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6295 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6296
2172544b
PE
6297 * xfns.c (Fx_window_property): Simplify a bit,
6298 to make a bit faster and to avoid GCC 4.6.0 warning.
6299 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6300
9b821a21
PE
6301 * fns.c (internal_equal): Don't assume size_t fits in int.
6302
3c616cfa
PE
6303 * alloc.c (compact_small_strings): Tighten assertion a little.
6304
c2982e87
PE
6305 Replace pEd with more-general pI, and fix some printf arg casts.
6306 * lisp.h (pI): New macro, generalizing old pEd macro to other
6307 conversion specifiers. For example, use "...%"pI"d..." rather
6308 than "...%"pEd"...".
6309 (pEd): Remove. All uses replaced with similar uses of pI.
6310 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6311 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6312 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6313 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6314 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6315 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6316 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6317 64-bit hosts.
6318 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6319 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6320 * print.c (safe_debug_print, print_object): Likewise.
6321 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6322 to int.
6f04d126
PE
6323 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6324 avoiding the 0 flag, which is not portable.
c2982e87
PE
6325 * process.c (Fmake_network_process): Use pI to avoid cast.
6326 * region-cache.c (pp_cache): Likewise.
6327 * xdisp.c (decode_mode_spec): Likewise.
6328 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6329 behavior on 64-bit hosts with printf arg.
6f04d126 6330 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6331 (x_stop_queuing_selection_requests): Likewise.
6332 (x_get_window_property): Don't truncate byte count to an 'int'
6333 when tracing.
0b432f21 6334
5e073ec7
PE
6335 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6336 here, since it parses constructs like leading '-' and spaces,
6337 which are not wanted; and it overflows with large numbers.
6338 Instead, simply match F[0-9]+, which is what is wanted anyway.
6339
36372bf9
PE
6340 * alloc.c: Remove unportable assumptions about struct layout.
6341 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6342 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6343 (allocate_vectorlike, make_pure_vector): Use the new macros,
6344 plus offsetof, to remove unportable assumptions about struct layout.
6345 These assumptions hold on all porting targets that I know of, but
6346 they are not guaranteed, they're easy to remove, and removing them
6347 makes further changes easier.
6348
0b432f21
PE
6349 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6350 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6351 (string_overrun_cookie): Now const. Use initializers that
6352 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6353 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6354 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6355 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6356 multiple of sizeof (EMACS_INT); it need not be, if
6357 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6358 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6359
895009e1
JB
63602011-04-26 Juanma Barranquero <lekktu@gmail.com>
6361
6362 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6363
6a7a1b0b
TZ
63642011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6365
6366 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6367 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6368 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6369
841a1577 63702011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6371
6372 * lisp.h (Qdebug): List symbol.
895009e1 6373 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6374 * keyboard.c (debug-on-event): New variable.
6375 (handle_user_signal): Break into debugger when debug-on-event
6376 matches the current signal symbol.
6377
f2d3ba6f
DN
63782011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6379
6380 * alloc.c (check_sblock, check_string_bytes)
6381 (check_string_free_list): Convert to standard C.
6382
42ce4c63
TZ
63832011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6384
6385 * w32.c (emacs_gnutls_push): Fix typo.
6386
825cd63c
EZ
63872011-04-25 Eli Zaretskii <eliz@gnu.org>
6388
fb11d64d
EZ
6389 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6390 "cast to pointer from integer of different size".
6391
825cd63c
EZ
6392 Improve doprnt and its use in verror. (Bug#8545)
6393 * doprnt.c (doprnt): Document the set of format control sequences
6394 supported by the function. Use SAFE_ALLOCA instead of always
6395 using `alloca'.
6396
6397 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6398 is one byte too soon. Don't use xrealloc; instead xfree and
6399 xmalloc anew.
6400
e061a11b
TZ
64012011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6402
6403 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6404 callbacks stage.
6405
6406 * gnutls.c: Renamed global_initialized to
6407 gnutls_global_initialized. Added internals for the
6408 :verify-hostname-error, :verify-error, and :verify-flags
6409 parameters of `gnutls-boot' and documented those parameters in the
6410 docstring. Start callback support.
9173deec
JB
6411 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6412 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6413 on error. Return error code.
e061a11b
TZ
6414 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6415 (emacs_gnutls_read): Likewise.
6416 (Fgnutls_boot): Return handshake error code.
6417 (emacs_gnutls_handle_error): New function.
6418 (wsaerror_to_errno): Likewise.
6419
6420 * w32.h (emacs_gnutls_pull): Add prototype.
6421 (emacs_gnutls_push): Likewise.
6422
6423 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6424 (emacs_gnutls_push): Likewise.
6425
64262011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6427
6428 * process.c (wait_reading_process_output): Check if GnuTLS
6429 buffered some data internally if no FDs are set for TLS
6430 connections.
6431
6432 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6433 (LIBS): Link to USER_LIBS.
6434 ($(BLD)/gnutls.$(0)): New target.
6435
fa6996bc
EZ
64362011-04-24 Eli Zaretskii <eliz@gnu.org>
6437
eb35682e
EZ
6438 * xdisp.c (handle_single_display_spec): Rename the
6439 display_replaced_before_p argument into display_replaced_p, to
6440 make it consistent with the commentary. Fix typos in the
6441 commentary.
6442
e2ad650c
EZ
6443 * textprop.c (syms_of_textprop): Remove dead code.
6444 (copy_text_properties): Delete obsolete commentary about an
6445 interface that was deleted long ago. Fix typos in the description
6446 of arguments.
6447
1b2de274
EZ
6448 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6449 to changes in oldXMenu/XMenu.h from 2011-04-16.
6450 <menu_help_message, prev_menu_help_message>: Constify.
6451 (IT_menu_make_room): menu->help_text is now `const char **';
6452 adjust.
6453
6454 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6455 to changes in oldXMenu/XMenu.h from 2011-04-16.
6456 (struct XMenu): Declare `help_text' `const char **'.
6457
6458 * xfaces.c <Qunspecified>: Make extern again.
6459
6460 * syntax.c: Include sys/types.h before including regex.h, as
6461 required by Posix.
6462
762b15be
EZ
6463 * doc.c (get_doc_string): Improve the format passed to `error'.
6464
6465 * doprnt.c (doprnt): Improve commentary.
6466
6467 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6468
6469 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6470 them with etags.
6471
f1052e5d
EZ
6472 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6473 changes in globals.h immediately force recompilation.
762b15be
EZ
6474 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6475 $(CURDIR)/s/ms-w32.h.
6476 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6477
fa6996bc
EZ
6478 * character.c (Fchar_direction): Function deleted.
6479 (syms_of_character): Don't defsubr it.
6480 <char-direction-table>: Deleted.
6481
e6c3da20
EZ
64822011-04-23 Eli Zaretskii <eliz@gnu.org>
6483
6484 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6485 * doprnt.c: Include limits.h.
6486 (SIZE_MAX): New macro.
04f2d78b
CB
6487 (doprnt): Return a size_t value. 2nd arg is now size_t.
6488 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6489 Improve overflow protection. Support `l' modifier for integer
6490 conversions. Support %l conversion. Don't assume an EMACS_INT
6491 argument for integer conversions and for %c.
6492
6493 * lisp.h (doprnt): Restore prototype.
6494
6495 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6496 $(SRC)/character.h.
6497
6498 * Makefile.in (base_obj): Add back doprnt.o.
6499
6500 * deps.mk (doprnt.o): Add back prerequisites.
6501 (callint.o): Depend on character.h.
6502
6503 * eval.c (internal_lisp_condition_case): Include the handler
6504 representation in the error message.
6505 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6506 when breaking from the loop.
6507
6508 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6509
6510 * callint.c (Fcall_interactively): When displaying error message
6511 about invalid control letter, pass the character's codepoint, not
6512 a pointer to its multibyte form. Improve display of the character
6513 in octal and display also its hex code.
6514
6515 * character.c (char_string): Use %x to display the (unsigned)
6516 codepoint of an invalid character, to avoid displaying a bogus
6517 negative value.
6518
6519 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6520 `error', not SYMBOL_NAME itself.
6521
6522 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6523 character arguments to `error'.
6524
6525 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6526 to `error' in error message about FINAL_CHAR argument. Make sure
6527 FINAL_CHAR is a character, and use %c when it is passed as
6528 argument to `error'.
6529
4ffd0d6b 65302011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6531
6532 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6533
6534 * w32.c: Include <time.h>.
6535 (sys_localtime): New function.
6536
4ffd0d6b 65372011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6538
6539 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6540
4ffd0d6b 6541 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6542
4ffd0d6b 65432011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6544
4ffd0d6b
GM
6545 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6546 zombies (Bug#8467).
aac0c6e3 6547
04c56954
EZ
65482011-04-19 Eli Zaretskii <eliz@gnu.org>
6549
6550 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6551 gl_state.e_property when gl_state.object is Qt.
6552
6553 * insdel.c (make_gap_larger): Remove limitation of buffer size
6554 to <= INT_MAX.
6555
16a43933
CY
65562011-04-18 Chong Yidong <cyd@stupidchicken.com>
6557
6558 * xdisp.c (lookup_glyphless_char_display)
6559 (produce_glyphless_glyph): Handle cons cell entry in
6560 glyphless-char-display.
6561 (Vglyphless_char_display): Document it.
6562
6563 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6564 glyphless-char-display.
6565
4581706e
CY
65662011-04-17 Chong Yidong <cyd@stupidchicken.com>
6567
6568 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6569
6570 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6571
6572 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6573 definition for no-X builds.
6574
4887c6e2 65752011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6576
fd35b6f9
PE
6577 Static checks with GCC 4.6.0 and non-default toolkits.
6578
5c1ccb01
PE
6579 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6580
006c5daa
PE
6581 * process.c (keyboard_bit_set): Define only if SIGIO.
6582 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6583 (send_process): Repair possible setjmp clobbering.
6584
efc736d3
PE
6585 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6586
4e2fe2e6
PE
6587 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6588
f97334a2
PE
6589 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6590
4e75f29d
PE
6591 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6592 Define only if needed.
6593
90efadd1
PE
6594 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6595 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6596 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6597
3c647824
PE
6598 * dispextern.h (struct redisplay_interface): Rename param
6599 to avoid shadowing.
e264f262 6600 * termhooks.h (struct terminal): Likewise.
761383f4 6601 * xterm.c (xembed_send_message): Likewise.
3c647824 6602
b58c5c4a
PE
6603 * insdel.c (make_gap_smaller): Define only if
6604 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6605
cad59032
PE
6606 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6607 it.
6608
c339dc2e
PE
6609 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6610 so that we aren't warned about unused symbols.
6611
91a3e27b
PE
6612 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6613
399c71d3 6614 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6615
8ffc96f5
PE
6616 * xfns.c (x_real_positions): Mark locals as initialized.
6617
eef9bc79
PE
6618 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6619
098db9dd
PE
6620 * xterm.c: Fix problems found by static analysis with other toolkits.
6621 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6622 (x_dispatch_event): Declare static if USE_GTK, and
6623 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6624 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6625 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6626 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6627 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6628
eb18f6cc
PE
6629 * xmenu.c (menu_help_callback): Pointer type fixes.
6630 Use const pointers when pointing at readonly data. Avoid pointer
6631 signedness clashes.
6632 (FALSE): Remove unused macro.
6633 (update_frame_menubar): Remove unused decl.
6634
1fe72bf8
PE
6635 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6636
60d9e1db
PE
6637 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6638 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6639 (single_menu_item): Rename local to avoid shadowing.
6640
39261c26
PE
6641 * keyboard.c (make_lispy_event): Remove unused local var.
6642
018c5e19
PE
6643 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6644 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6645
63d2b86e
PE
6646 * bitmaps: Change bitmaps from unsigned char back to the X11
6647 compatible char. Avoid the old compiler warnings about
6648 out-of-range initializers by using, for example, '\xab' rather
6649 than 0xab.
6650
aefd87e1
PE
6651 * xgselect.c (xgselect_initialize): Check vs interface
6652 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6653
bf501fb9
PE
6654 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6655
e9829fdf
PE
6656 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6657 to read-only memory.
6658
1086c095
PE
6659 * fns.c (vector): Remove; this old hack is no longer needed.
6660
2baccd04 6661 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6662 Remove unused var.
dde42981 6663 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6664
72391843 6665 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6666
436c16df 6667 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6668 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6669 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6670
92bb796d 6671 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6672 (x_term_init): Remove local to avoid shadowing.
92bb796d 6673
764430a3 6674 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6675
6676 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6677 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6678
d1dfb56c
EZ
66792011-04-16 Eli Zaretskii <eliz@gnu.org>
6680
c4354cb4
EZ
6681 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6682
d1dfb56c
EZ
6683 Fix regex.c, syntax.c and friends for buffers > 2GB.
6684 * syntax.h (struct gl_state_s): Declare character position members
6685 EMACS_INT.
6686
6687 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6688
04f2d78b
CB
6689 * textprop.c (verify_interval_modification, interval_of):
6690 Declare arguments EMACS_INT.
d1dfb56c
EZ
6691
6692 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6693 EMACS_INT.
6694
6695 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6696
6697 * indent.c (Fvertical_motion): Local variable it_start is now
6698 EMACS_INT.
6699
6700 * regex.c (re_match, re_match_2, re_match_2_internal)
6701 (bcmp_translate, regcomp, regexec, print_double_string)
6702 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6703 (re_compile_pattern, re_exec): Declare arguments and local
6704 variables `size_t' and `ssize_t' and return values `regoff_t', as
6705 appropriate.
6706 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6707 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6708 <compile_stack_type>: `size' and `avail' are now `size_t'.
6709
6710 * regex.h <regoff_t>: Use ssize_t, not int.
6711 (re_search, re_search_2, re_match, re_match_2): Arguments that
6712 specify buffer/string position and length are now ssize_t and
6713 size_t. Return type is regoff_t.
6714
613052cd
BK
67152011-04-16 Ben Key <bkey76@gmail.com>
6716
6717 * nsfont.m: Fixed bugs in ns_get_family and
6718 ns_descriptor_to_entity that were caused by using free to
6719 deallocate memory blocks that were allocated by xmalloc (via
6720 xstrdup). This caused Emacs to crash when compiled with
6721 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6722 --enable-checking=xmallocoverrun). xfree is now used to
6723 deallocate these memory blocks.
6724
4170f62f 67252011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6726
71b41406
PE
6727 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6728
9587a89d
PE
6729 emacs_write: Accept and return EMACS_INT for sizes.
6730 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6731 et seq.
6732 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6733 Accept and return EMACS_INT.
6734 (emacs_gnutls_write): Return the number of bytes written on
6735 partial writes.
6736 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6737 (emacs_read, emacs_write): Remove check for negative size, as the
6738 Emacs source code has been audited now.
9587a89d
PE
6739 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6740 (emacs_read, emacs_write): Use it.
273a5f82
PE
6741 * process.c (send_process): Adjust to the new signatures of
6742 emacs_write and emacs_gnutls_write. Do not attempt to store
6743 a byte offset into an 'int'; it might overflow.
9587a89d 6744 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6745
3e047f51
PE
6746 * sound.c: Don't assume sizes fit in 'int'.
6747 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6748 Return EMACS_INT, not int.
3e047f51 6749 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6750 Accept EMACS_INT, not int.
6751 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6752 record read return values.
6753
cc39a9db
BK
67542011-04-15 Ben Key <bkey76@gmail.com>
6755
c9d0ec6d
JB
6756 * keyboard.c (Qundefined): Don't declare static since it is used
6757 in nsfns.m.
6758 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6759 static since they are used in nsfont.m.
cc39a9db 6760
6c60eb9f
SM
67612011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6762
6763 * process.c (Qprocessp): Don't declare static.
6764 * lisp.h (Qprocessp): Declare again.
6765
7990b61a
JB
67662011-04-15 Juanma Barranquero <lekktu@gmail.com>
6767
6768 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6769
5d4cb038
PE
67702011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6771
8bd7b830 6772 Improve C-level modularity by making more things 'static'.
cd64ea1d 6773
e3b27b31
PE
6774 Don't publish debugger-only interfaces to other modules.
6775 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6776 (verify_bytepos, count_markers): Move decls to the only modules
6777 that need them.
6778 * region-cache.h (pp_cache): Likewise.
6779 * window.h (check_all_windows): Likewise.
6780 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6781
5d4cb038
PE
6782 * sysdep.c (croak): Now static, if
6783 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6784 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6785
6786 * alloc.c (refill_memory_reserve): Now static if
6787 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6788 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6789
e87b6180
PE
6790 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6791 Define only if USE_LUCID.
6792
ac64929e
PE
6793 * xrdb.c (x_customization_string, x_rm_string): Now static.
6794
6f37259d
PE
6795 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6796 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6797
1683e3ab
PE
6798 * xdisp.c (draw_row_with_mouse_face): Now static.
6799 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6800
de9c2632
PE
6801 * window.h (check_all_windows): Mark externally visible.
6802
2b96acb7
PE
6803 * window.c (window_deletion_count): Now static.
6804
6805 * undo.c: Make symbols static if they're not exported.
6806 (last_undo_buffer, last_boundary_position, pending_boundary):
6807 Now static.
6808
50436f33
PE
6809 * textprop.c (interval_insert_behind_hooks): Now static.
6810 (interval_insert_in_front_hooks): Likewise.
6811
64520e5c
PE
6812 * term.c: Make symbols static if they're not exported.
6813 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6814 (max_frame_lines, tty_set_terminal_modes):
6815 (tty_reset_terminal_modes, tty_turn_off_highlight):
6816 (get_tty_terminal): Now static.
6817 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6818 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6819 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6820 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6821 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6822
1fa53021
PE
6823 * sysdep.c: Make symbols static if they're not exported.
6824 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6825 Now static.
6826 (sigprocmask_set, full_mask): Remove; unused.
6827 (wait_debugging): Mark as visible.
6828 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6829 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6830
d4b43b22
PE
6831 * syntax.c (syntax_temp): Define only if !__GNUC__.
6832
b7c513d0
PE
6833 * sound.c (current_sound_device, current_sound): Now static.
6834
989b29ad
PE
6835 * search.c (searchbufs, searchbuf_head): Now static.
6836
13a55a78
PE
6837 * scroll.c (scroll_cost): Remove; unused.
6838 * dispextern.h (scroll_cost): Remove decl.
6839
de68a1fc
PE
6840 * region-cache.h (pp_cache): Mark as externally visible.
6841
40ccffa6
PE
6842 * process.c: Make symbols static if they're not exported.
6843 (process_tick, update_tick, create_process, chan_process):
6844 (Vprocess_alist, proc_buffered_char, datagram_access):
6845 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6846 (deactivate_process): Mark defn as static, as well as decl.
6847 * lisp.h (create_process): Remove decl.
6848 * process.h (chan_process, Vprocess_alist): Remove decls.
6849
ad64fc97
PE
6850 * print.c: Make symbols static if they're not exported.
6851 (print_depth, new_backquote_output, being_printed, print_buffer):
6852 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6853 (print_interval, print_number_index, initial_stderr_stream):
6854 Now static.
6855 * lisp.h (Fprinc): Remove decl.
6856 (debug_output_compilation_hack): Mark as externally visible.
6857
adddb265
PE
6858 * sysdep.c (croak): Move decl from here to syssignal.h.
6859 * syssignal.h (croak): Put it here, so the API can be checked when
6860 'croak' is called from dissociate_if_controlling_tty.
6861
1717ede2
PE
6862 * minibuf.c: Make symbols static if they're not exported.
6863 (minibuf_save_list, choose_minibuf_frame): Now static.
6864 * lisp.h (choose_minibuf_frame): Remove decl.
6865
fa5fb2bc
PE
6866 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6867
1e3890d1
PE
6868 * lread.c: Make symbols static if they're not exported.
6869 (read_objects, initial_obarray, oblookup_last_bucket_number):
6870 Now static.
6871 (make_symbol): Remove; unused.
6872 * lisp.h (initial_obarray, make_symbol): Remove decls.
6873
8a1414fa
PE
6874 * keyboard.c: Make symbols static if they're not exported.
6875 (single_kboard, recent_keys_index, total_keys, recent_keys):
6876 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6877 (this_single_command_key_start, echoing, last_auto_save):
6878 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6879 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6880 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6881 (Vlispy_mouse_stem, double_click_count):
6882 Now static.
6883 (force_auto_save_soon): Define only if SIGDANGER.
6884 (ignore_mouse_drag_p): Now static if
6885 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6886 (print_help): Remove; unused.
6887 (stop_character, last_timer_event): Mark as externally visible.
6888 * keyboard.h (ignore_mouse_drag_p): Declare only if
6889 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6890 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6891 * lisp.h (echoing): Remove decl.
6892 (force_auto_save_soon): Declare only if SIGDANGER.
6893 * xdisp.c (redisplay_window): Simplify code, to make it more
6894 obvious that ignore_mouse_drag_p is not accessed if !defined
6895 USE_GTK && !defined HAVE_NS.
6896
93ea6e8f
PE
6897 * intervals.c: Make symbols static if they're not exported.
6898 (merge_properties_sticky, merge_interval_right, delete_interval):
6899 Now static.
6900 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6901
77382fcc
PE
6902 * insdel.c: Make symbols static if they're not exported.
6903 However, leave prepare_to_modify_buffer alone. It's never
6904 called from outside this function, but that appears to be a bug.
6905 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6906 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6907 (adjust_after_replace_noundo): Remove; unused.
6908 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6909 (signal_before_change): Remove decls.
77382fcc 6910
9306c32e
PE
6911 * indent.c (val_compute_motion, val_vmotion): Now static.
6912
cd44d2eb
PE
6913 * image.c: Make symbols static if they're not exported.
6914 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6915 if USE_GTK.
6916 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6917 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6918
ad9a7a06
PE
6919 * fringe.c (standard_bitmaps): Now static.
6920 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6921
81626931
PE
6922 * frame.c: Make symbols static if they're not exported.
6923 (x_report_frame_params, make_terminal_frame): Now static.
6924 (get_frame_param): Now static, unless HAVE_NS.
6925 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6926 (x_get_resource_string): Remove; not used.
6927 * frame.h (make_terminal_frame, x_report_frame_params):
6928 (x_get_resource_string); Remove decls.
6929 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6930 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6931
239f9db9
PE
6932 * font.c, fontset.c: Make symbols static if they're not exported.
6933 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6934 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6935 * font.c (font_close_object): Now static.
6936 * font.h (font_close_object): Remove.
6937 * fontset.c (FONTSET_OBJLIST): Remove.
6938 (free_realized_fontset) #if-0 the body, which does nothing.
6939 (face_suitable_for_char_p): #if-0, as it's never called.
6940 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6941 * xfaces.c (face_at_string_position):
6942 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6943 since 0 is always ASCII.
6944
dfcf3579
PE
6945 * fns.c (weak_hash_tables): Now static.
6946
5045092b
PE
6947 * fileio.c: Make symbols static if they're not exported.
6948 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6949 (Vwrite_region_annotation_buffers): Now static.
6950
57a96f5c
PE
6951 * eval.c: Make symbols static if they're not exported.
6952 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6953 * lisp.h (backtrace_list): Remove decl.
6954
35f08c38
PE
6955 * emacs.c: Make symbols static if they're not exported.
6956 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6957 (fatal_error_code, fatal_error_signal_hook, standard_args):
6958 Now static.
6959 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6960 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6961 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6962 * lisp.h (fatal_error_signal_hook): Remove decl.
6963 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6964
f44bd759
PE
6965 * editfns.c: Move a (normally-unused) function to its only use.
6966 * editfns.c, lisp.h (get_operating_system_release): Remove.
6967 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6968 worth the hassle of breaking this out.
6969
b532497d
PE
6970 * xterm.c: Make symbols static if they're not exported.
6971 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6972 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6973 (x_destroy_window, x_delete_display):
6974 Now static.
6975 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6976 (x_mouse_leave): Remove; unused.
6977 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6978 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6979 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6980 Remove decls.
6981 (x_mouse_leave): Declare only if WINDOWSNT.
6982 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6983 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6984 USE_X_TOOLKIT.
6985
1675728f
PE
6986 * ftxfont.c: Make symbols static if they're not exported.
6987 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6988 HAVE_FREETYPE.
6989 * font.h (ftxfont_driver): Likewise.
6990
e4cebfca
PE
6991 * xfns.c: Make symbols static if they're not exported.
6992 (x_last_font_name, x_display_info_for_name):
6993 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6994 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6995 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6996 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6997 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6998 (last_show_tip_args): Now static.
6999 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7000 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7001 (x_screen_planes): Remove; unused.
7002 * dispextern.h (x_screen_planes): Remove decl.
7003
5bf46f05
PE
7004 * dispnew.c: Make symbols static if they're not exported.
7005 * dispextern.h (redraw_garbaged_frames, scrolling):
7006 (increment_row_positions): Remove.
7007 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7008 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7009 Now static.
7010 (redraw_garbaged_frames): Remove; unused.
7011
435f4c28
PE
7012 * xfaces.c: Make symbols static if they're not exported.
7013 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7014 Remove decls.
7015 * xterm.h (defined_color): Remove decls.
7016 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7017 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7018 (menu_face_changed_default, defined_color, free_realized_face):
7019 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7020 (ascii_face_of_lisp_face): Remove; unused.
7021
8524aef3
PE
7022 * xdisp.c: Make symbols static if they're not exported.
7023 * dispextern.h (scratch_glyph_row, window_box_edges):
7024 (glyph_to_pixel_coords, set_cursor_from_row):
7025 (get_next_display_element, set_iterator_to_next):
7026 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7027 (show_mouse_face): Remove decls
7028 * frame.h (message_buf_print): Likewise.
7029 * lisp.h (pop_message, set_message, check_point_in_composition):
7030 Likewise.
7031 * xterm.h (set_vertical_scroll_bar): Likewise.
7032 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7033 (message_buf_print, scratch_glyph_row, displayed_buffer):
7034 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7035 (get_next_display_element, show_mouse_face, window_box_edges):
7036 (frame_to_window_pixel_xy, check_point_in_composition):
7037 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7038 (glyph_to_pixel_coords): Remove; unused.
7039
16390cd2
PE
7040 * dired.c (file_name_completion): Now static.
7041
7042 * dbusbind.c (xd_in_read_queued_messages): Now static.
7043
a25f4dfa
PE
7044 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7045 * data.c (circular_list_error): Remove.
7046
14a9c8df
PE
7047 * commands.h (last_point_position, last_point_position_buffer):
7048 (last_point_position_window): Remove decls.
7049 * keyboard.c: Make these variables static.
7050
04f2d78b
CB
7051 * coding.h (coding, code_convert_region, encode_coding_gap):
7052 Remove decls.
74ab6df5
PE
7053 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7054 (iso_code_class, detect_coding, code_convert_region): Now static.
7055 (encode_coding_gap): Remove; unused.
7056
38dfbee1
PE
7057 * chartab.c (chartab_chars, chartab_bits): Now static.
7058
a2cb4e63
PE
7059 * charset.h (charset_iso_8859_1): Remove decl.
7060 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7061 Now static.
7062
127198fd
PE
7063 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7064 * ccl.c (Vccl_program_table): Now static.
7065 (check_ccl_update): Remove; unused.
7066
d85b608f
PE
7067 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7068 * category.h: ... from here.
7069 * category.c (check_category_table, set_category_set): Now static.
7070
31cd66f3
PE
7071 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7072 * lisp.h: Remove these decls.
7073
c358e587
PE
7074 * buffer.c (buffer_count): Remove unused var.
7075
e78aecca
PE
7076 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7077 so that it's not optimized away.
7078 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7079 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7080 exported only to the debugger.
7081
e192d7d3 7082 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7083 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7084
92470028
PE
7085 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7086 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7087 was inaccessible from Lisp.
7088 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7089 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7090
244ed907
PE
7091 alloc.c: Import and export fewer symbols, and remove unused items.
7092 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7093 is defined.
7094 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7095 it's not optimized away by whole-program optimization.
7096 (message_enable_multibyte, free_misc): Remove.
7097 (catchlist, handlerlist, mark_backtrace):
7098 Declare only if BYTE_MARK_STACK.
7099 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7100 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7101 (message_enable_multibyte): Remove decl.
7102 (free_misc, interval_free_list, float_block, float_block_index):
7103 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7104 (cons_free_list, last_marked_index):
7105 Now static.
7106 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7107 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7108 (mark_backtrace): Define only if BYTE_MARK_STACK.
7109 * xdisp.c (message_enable_multibyte): Now static.
7110
61c2b50e 7111 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7112 This makes it easier for human readers (and static analyzers)
7113 to see whether these variables are used from other modules.
7114 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7115 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7116 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7117 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7118 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7119 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7120 * xmenu.c, xselect.c:
7121 Declare Q* vars static if they are not used in other modules.
7122 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7123 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7124 Remove decls of unexported vars.
7125 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7126
95c82688
PE
7127 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7128
16a97296
PE
7129 Make Emacs functions such as Fatom 'static' by default.
7130 This makes it easier for human readers (and static analyzers)
7131 to see whether these functions can be called from other modules.
7132 DEFUN now defines a static function. To make the function external
7133 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7134 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7135 (Finit_image_library):
16a97296
PE
7136 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7137 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7138 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7139 Remove decls, since these functions are now static.
7140 (Funintern, Fget_internal_run_time): New decls, since these functions
7141 were already external.
95c82688 7142
16a97296
PE
7143 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7144 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7145 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7146 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7147 * keyboard.c, keymap.c, lread.c:
7148 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7149 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7150 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7151 Mark functions with DEFUE instead of DEFUN,
7152 if they are used in other modules.
7153 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7154 decls for now-static functions.
7155 * buffer.h (Fdelete_overlay): Remove decl.
7156 * callproc.c (Fgetenv_internal): Mark as internal.
7157 * composite.c (Fremove_list_of_text_properties): Remove decl.
7158 (Fcomposition_get_gstring): New forward static decl.
7159 * composite.h (Fcomposite_get_gstring): Remove decl.
7160 * dired.c (Ffile_attributes): New forward static decl.
7161 * doc.c (Fdocumntation_property): New forward static decl.
7162 * eval.c (Ffetch_bytecode): New forward static decl.
7163 (Funintern): Remove extern decl; now in .h file where it belongs.
7164 * fileio.c (Fmake_symbolic_link): New forward static decl.
7165 * image.c (Finit_image_library): New forward static decl.
7166 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7167 * intervals.h (Fprevious_property_change):
7168 (Fremove_list_of_text_properties): Remove decls.
7169 * keyboard.c (Fthis_command_keys): Remove decl.
7170 (Fcommand_execute): New forward static decl.
7171 * keymap.c (Flookup_key): New forward static decl.
7172 (Fcopy_keymap): Now static.
7173 * keymap.h (Flookup_key): Remove decl.
7174 * process.c (Fget_process): New forward static decl.
7175 (Fprocess_datagram_address): Mark as internal.
7176 * syntax.c (Fsyntax_table_p): New forward static decl.
7177 (skip_chars): Remove duplicate decl.
7178 * textprop.c (Fprevious_property_change): New forward static decl.
7179 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7180 Now internal.
7181 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7182 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7183
785bbd42
PE
7184 * editfns.c (Fformat): Remove unreachable code.
7185
8b913b57
AS
71862011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7187
7188 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7189 change. (Bug#8496)
7190
a6744a35
EZ
71912011-04-13 Eli Zaretskii <eliz@gnu.org>
7192
7193 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7194 when at ZV. (Bug#8487)
7195
e7974947
AS
71962011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7197
baad03f0
AS
7198 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7199 (Bug#8437)
7200 * keyboard.c (parse_tool_bar_item): Likewise.
7201 * sound.c (sound_cleanup, alsa_close): Likewise.
7202 * termcap.c (tgetent): Likewise.
7203 * xfns.c (x_default_font_parameter): Likewise.
7204 * xsettings.c (read_and_apply_settings): Likewise.
7205
e7974947
AS
7206 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7207 (overrun_check_free): Protoize.
7208
28272684
PE
72092011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7210
7211 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7212 since callers should never pass a negative size.
7213 Change the signature to match that of plain 'read' and 'write'; see
7214 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7215 * lisp.h: Update prototypes of emacs_write and emacs_read.
7216
11997c76
EZ
72172011-04-11 Eli Zaretskii <eliz@gnu.org>
7218
7219 * xdisp.c (redisplay_window): Don't try to determine the character
7220 position of the scroll margin if the window start point w->startp
e896f03c 7221 is outside the buffer's accessible region. (Bug#8468)
11997c76 7222
8a2cbd72
EZ
72232011-04-10 Eli Zaretskii <eliz@gnu.org>
7224
7225 Fix write-region and its subroutines for buffers > 2GB.
7226 * fileio.c (a_write, e_write): Modify declaration of arguments and
7227 local variables to support buffers larger than 2GB.
7228 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7229
7230 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7231 argument, local variables, and return value.
7232
7233 * lisp.h: Update prototypes of emacs_write and emacs_read.
7234
7235 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7236
4073e537 72372011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7238
1ebfdcb6
PE
7239 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7240
b2ded58d
PE
7241 Fix more problems found by GCC 4.6.0's static checks.
7242
7d66342c
PE
7243 * xdisp.c (vmessage): Use a better test for character truncation.
7244
bbf47d44
PE
7245 * charset.c (load_charset_map): <, not <=, for optimization,
7246 and to avoid potential problems with integer overflow.
9248994d 7247 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7248 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7249 * editfns.c (Fformat): Likewise.
1e69125e 7250 * syntax.c (skip_chars): Likewise.
3befa583 7251
e3019616
PE
7252 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7253 This also lets GCC 4.6.0 generate slightly better loop code.
7254
becfa255
PE
7255 * callint.c (Fcall_interactively): <, not <=, for optimization.
7256 (Fcall_interactively): Count the number of arguments produced,
7257 not the number of arguments given. This is simpler and lets GCC
7258 4.6.0 generate slightly better code.
7259
dae0cd48
PE
7260 * ftfont.c: Distingish more carefully between FcChar8 and char.
7261 The previous code passed unsigned char * to a functions like
7262 strlen and xstrcasecmp that expect char *, which does not
7263 conform to the C standard.
7264 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7265 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7266 char * when the C standard requires it.
7267
76032d70
PE
7268 * keyboard.c (read_char): Remove unused var.
7269
eb3f1cc8
PE
7270 * eval.c: Port to Windows vsnprintf (Bug#8435).
7271 Include <limits.h>.
7272 (SIZE_MAX): Define if the headers do not.
7273 (verror): Do not give up if vsnprintf returns a negative count.
7274 Instead, grow the buffer. This ports to Windows vsnprintf, which
7275 does not conform to C99. Problem reported by Eli Zaretskii.
7276 Also, simplify the allocation scheme, by avoiding the need for
7277 calling realloc, and removing the ALLOCATED variable.
7278
70476b54
PE
7279 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7280
12020a9e
PE
7281 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7282 But keep the doprint source code for now, as we might revamp it
7283 and use it again (Bug#8435).
ea6c7ae6
PE
7284 * lisp.h (doprnt): Remove.
7285 * Makefile.in (base_obj): Remove doprnt.o.
7286 * deps.mk (doprnt.o): Remove.
7287
5fdb398c
PE
7288 error: Print 32- and 64-bit integers portably (Bug#8435).
7289 Without this change, on typical 64-bit hosts error ("...%d...", N)
7290 was used to print both 32- and 64-bit integers N, which relied on
7291 undefined behavior.
7292 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7293 New macro.
7294 * lisp.h (error, verror): Mark as printf-like functions.
7295 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7296 Report overflow in size calculations when allocating printf buffer.
7297 Do not truncate output string at its first null byte.
7298 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7299 Truncate the output at a character boundary, since vsnprintf does not
7300 do that.
7301 * charset.c (check_iso_charset_parameter): Convert internal
7302 character to string before calling 'error', since %c now has the
7303 printf meaning.
7304 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7305 overflow when computing char to be passed to 'error'. Do not
7306 pass Lisp_Object to 'error'; pass the integer instead.
7307 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7308 formatted with plain %d.
7309
b189fa66
PE
7310 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7311
bff87ef0
PE
7312 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7313
7e2cac20
PE
7314 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7315
ce4d90b5
PE
7316 * xterm.c (x_catch_errors): Remove duplicate declaration.
7317
266c9547
PE
7318 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7319
79c49ad2
PE
7320 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7321
368f4090
JM
73222011-04-10 Jim Meyering <meyering@redhat.com>
7323
7324 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7325 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7326 return ssize_t not "int", and use size_t as the buffer length.
7327 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7328 * gnutls.h: Update declarations.
7329 * process.c (read_process_output): Use ssize_t, to match.
7330 (send_process): Likewise.
7331
a32d4040
CY
73322011-04-09 Chong Yidong <cyd@stupidchicken.com>
7333
7334 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7335
8546720e 73362011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7337
04f2d78b
CB
7338 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7339 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7340
8546720e
GM
7341 * xterm.c (handle_one_xevent):
7342 * xmenu.c (create_and_show_popup_menu):
7343 * xselect.c (x_decline_selection_request)
7344 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7345
0a2f5c1a 73462011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7347
7348 Fix some uses of `int' instead of EMACS_INT.
7349 * search.c (string_match_1, fast_string_match)
7350 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7351 (scan_buffer, find_next_newline_no_quit)
7352 (find_before_next_newline, search_command, Freplace_match)
7353 (Fmatch_data): Make some `int' variables be EMACS_INT.
7354
7355 * xdisp.c (display_count_lines): 3rd argument and return value now
7356 EMACS_INT. All callers changed.
7357 (pint2hrstr): Last argument is now EMACS_INT.
7358
7359 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7360 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7361 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7362 (decode_coding_utf_16, decode_coding_emacs_mule)
7363 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7364 (decode_coding_ccl, decode_coding_charset)
7365 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7366 (decode_coding_iso_2022, decode_coding_emacs_mule)
7367 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7368 <char_offset, last_offset>: Declare EMACS_INT.
7369 (encode_coding_utf_8, encode_coding_utf_16)
7370 (encode_coding_emacs_mule, encode_invocation_designation)
7371 (encode_designation_at_bol, encode_coding_iso_2022)
7372 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7373 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7374 Declare EMACS_INT.
7375 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7376 (encode_invocation_designation): Last argument P_NCHARS is now
7377 EMACS_INT.
7378 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7379 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7380
7381 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7382 All users changed.
7383
7384 * ccl.c (Fccl_execute_on_string): Declare some variables
7385 EMACS_INT.
7386
8546720e 73872011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7388
7389 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7390
4e19a977
CS
73912011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7392
7393 * process.c (Fformat_network_address): Doc fix.
7394
87302331
R
73952011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7396
ee7683eb 7397 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7398
cbb59342
CY
73992011-04-08 Chong Yidong <cyd@stupidchicken.com>
7400
7401 * keyboard.c (read_char): Call Lisp function help-form-show,
7402 instead of using internal_with_output_to_temp_buffer.
7403 (Qhelp_form_show): New var.
e0d38eeb 7404 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7405
7406 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7407
7408 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7409
e67a13ab
CY
74102011-04-06 Chong Yidong <cyd@stupidchicken.com>
7411
04f2d78b
CB
7412 * process.c (Flist_processes): Remove to Lisp.
7413 (list_processes_1): Delete.
e67a13ab 7414
973f782d
EZ
74152011-04-06 Eli Zaretskii <eliz@gnu.org>
7416
7c106b1e
EZ
7417 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7418
973f782d
EZ
7419 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7420
41cf7d1a 74212011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7422
ca23cc88
PE
7423 Fix more problems found by GCC 4.6.0's static checks.
7424
f390e2d5
PE
7425 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7426
42eea0d0
PE
7427 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7428
b69769da 7429 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7430
f9541e84
PE
7431 * xdisp.c (vmessage): Mark as a printf-like function.
7432
13841b55
PE
7433 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7434
c136c10f
PE
7435 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7436
5e2d4a30
PE
7437 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7438 printf-like functions.
7439 (tiff_load): Add casts to remove these marks before passing them
7440 to system-supplied API.
7441
583f48b9
PE
7442 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7443
b25d760e
PE
7444 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7445 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7446 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7447 directly, rather than having caller test rule sign. This avoids
7448 some unnecessary tests.
7449 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7450 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7451 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7452
bc7b6697 7453 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7454 (xfont_open): Avoid unnecessary tests.
bc7b6697 7455
27ccc379
PE
7456 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7457
dcd5c89a
PE
7458 * composite.h, composite.c (composition_gstring_put_cache):
7459 Use EMACS_INT, not int, for length.
7460
b13a45c6
PE
7461 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7462 breaking out part of COMPOSITION_DECODE_RULE.
7463 (COMPOSITION_DECODE_RULE): Use it.
7464 * composite.c (get_composition_id): Remove unused local vars,
7465 by using the new macro.
7466
1e792e4d
PE
7467 * textprop.c (set_text_properties_1): Change while to do-while,
7468 since the condition is always true at first.
7469
dc6c6455 7470 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7471 (interval_deletion_adjustment): Return unsigned value.
7472 All uses changed.
dc6c6455 7473
aba7731a
PE
7474 * process.c (list_processes_1, create_pty, read_process_output):
7475 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7476 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7477 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7478 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7479 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7480
fdfc4bf3
PE
7481 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7482
fca8fe46 7483 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7484 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7485
06a0259a 7486 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7487 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7488 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7489
e7b9e80f
PE
7490 * print.c (print_error_message): Avoid int overflow.
7491
56201685
PE
7492 * font.c (font_list_entities): Redo for clarity,
7493 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7494
78834453 7495 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7496 (font_score): Avoid potential overflow in diff calculation.
78834453 7497
0bc0b309 7498 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7499 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7500
e610eaca
PE
7501 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7502
b895abce
PE
7503 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7504 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7505 can always succeed if overflow has undefined behavior.
7506
1f1d9321 7507 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7508 (wordify): Omit three unnecessary tests.
1f1d9321 7509
c59478bc
PE
7510 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7511 All callers changed. This avoids the need for an unused var.
7512
79b73827
PE
7513 * casefiddle.c (casify_region): Remove var that is set but not used.
7514
a4db5dfe
PE
7515 * dired.c (file_name_completion): Remove var that is set but not used.
7516
43aae36e
PE
7517 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7518
2a47c44d 7519 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7520 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7521
a37c69bf
PE
7522 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7523 Check for integer overflow on size calculations.
7524
328ab8e7
PE
7525 * buffer.c (Fprevious_overlay_change): Remove var that is set
7526 but not used.
7527
e5a2a5cb
PE
7528 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7529 Remove vars that are set but not used.
8d84a6eb 7530 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7531 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7532
a60e5f68
PE
7533 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7534
f661cb61 7535 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7536 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7537
f0397f5a
PE
7538 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7539 that are set but not used.
7540
8664db06 7541 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7542 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7543
6abdaa4a
PE
7544 * xselect.c (x_get_local_selection, x_handle_property_notify):
7545 Remove vars that are set but not used.
7546
0ce7538d 7547 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7548 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7549
9ae848fc
PE
7550 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7551 Remove var that is set but not used.
0b918413
PE
7552 (scroll_bar_windows_size): Now size_t, not int.
7553 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7554 Check for overflow.
9ae848fc 7555
a5a62657
PE
7556 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7557 (map_tty_color) [!defined MSDOS]: Likewise.
7558
5c5cdd39
PE
7559 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7560
66ebf983
PE
7561 * coding.c: Remove vars that are set but not used.
7562 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7563 All callers changed.
7564 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7565 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7566 (decode_coding_charset): Remove vars that are set but not used.
7567
1be4d761
PE
7568 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7569 that is set but not used.
7570
47553fa8
PE
7571 * print.c (print_object): Remove var that is set but not used.
7572
1f7196bf 7573 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7574 The gnulib version avoids calling malloc in the usual case,
7575 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7576 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7577 * filelock.c (current_lock_owner): Likewise.
7578 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7579 * sysdep.c: Include allocator.h, careadlinkat.h.
7580 (emacs_no_realloc_allocator): New static constant.
7581 (emacs_readlink): New function.
fdb61804
PE
7582 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7583 ../lib/careadlinkat.h.
d1fdcab7 7584
f84c17c7
SM
75852011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7586
7587 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7588 first non-nil return value).
7589
ef3862ad
JD
75902011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7591
7592 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7593 if not defined (Bug#8403).
7594
376a7006
JB
75952011-04-02 Juanma Barranquero <lekktu@gmail.com>
7596
7597 * xdisp.c (display_count_lines): Remove parameter `start',
7598 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7599 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7600 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7601 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7602 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7603 and thereabouts. All callers changed.
7604 (get_per_char_metric): Remove parameter `f', unused since
7605 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7606
6ca3801d
JM
76072011-04-02 Jim Meyering <meyering@redhat.com>
7608
7609 do not dereference NULL upon failed strdup
7610 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7611 (ns_get_family): Likewise.
7612
d8e2b5ba
JB
76132011-04-02 Juanma Barranquero <lekktu@gmail.com>
7614
7615 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7616
8c74fcbd
JD
76172011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7618
7619 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7620 later (Bug#8403).
7621
7200d79c
SM
76222011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7623
03408648 7624 Add lexical binding.
7200d79c 7625
03408648
SM
7626 * window.c (Ftemp_output_buffer_show): New fun.
7627 (Fsave_window_excursion):
7628 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7629
7630 * lread.c (lisp_file_lexically_bound_p): New function.
7631 (Fload): Bind Qlexical_binding.
7632 (readevalloop): Remove `evalfun' arg.
7633 Bind Qinternal_interpreter_environment.
7634 (Feval_buffer): Bind Qlexical_binding.
7635 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7636 Mark as dynamic.
7637 (syms_of_lread): Declare `lexical-binding'.
7638
7639 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7640
7641 * keyboard.c (eval_dyn): New fun.
7642 (menu_item_eval_property): Use it.
ca105506
SM
7643
7644 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7645
03408648
SM
7646 * fns.c (concat, mapcar1): Accept byte-code-functions.
7647
7648 * eval.c (Fsetq): Handle lexical vars.
7649 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7650 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7651 (FletX, Flet): Obey lexical binding.
7652 (Fcommandp): Handle closures.
7653 (Feval): New `lexical' arg.
7654 (eval_sub): New function extracted from Feval. Use it almost
7655 everywhere where Feval was used. Look up vars in lexical env.
7656 Handle closures.
7657 (Ffunctionp): Move from subr.el.
7658 (Ffuncall): Handle closures.
7659 (apply_lambda): Remove `eval_flags'.
7660 (funcall_lambda): Handle closures and new byte-code-functions.
7661 (Fspecial_variable_p): New function.
7662 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7663 but without exporting it to Lisp.
23aba0ea 7664
23aba0ea 7665 * doc.c (Fdocumentation, store_function_docstring):
03408648 7666 * data.c (Finteractive_form): Handle closures.
23aba0ea 7667
03408648
SM
7668 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7669 interactive spec.
ba83908c 7670
04f2d78b
CB
7671 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7672 New byte-codes.
03408648
SM
7673 (exec_byte_code): New function extracted from Fbyte_code to handle new
7674 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7675
03408648 7676 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7677
03408648 7678 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7679
e2abce01
JB
76802011-03-31 Juanma Barranquero <lekktu@gmail.com>
7681
7682 * xdisp.c (redisplay_internal): Fix prototype.
7683
63696a73 76842011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7685
63696a73 7686 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7687 (try_scrolling): Use it when setting scroll_limit.
7688 Limit scrolling to 100 screen lines.
63696a73
EZ
7689 (redisplay_window): Even when falling back on "recentering",
7690 position point in the window according to scroll-conservatively,
7691 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7692
7693 (try_scrolling): When point is above the window, allow searching
7694 as far as scroll_max, or one screenful, to compute vertical
7695 distance from PT to the scroll margin position. This prevents
7696 try_scrolling from unnecessarily failing when
7697 scroll-conservatively is set to a value slightly larger than the
7698 window height. Clean up the case of PT below the margin at bottom
7699 of window: scroll_max can no longer be INT_MAX. When aggressive
7700 scrolling is in use, don't let point enter the opposite scroll
7701 margin as result of the scroll.
7702 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7703 threshold of 100 lines for never-recentering scrolling.
7704
e4cc2dfc
JB
77052011-03-31 Juanma Barranquero <lekktu@gmail.com>
7706
7707 * dispextern.h (move_it_by_lines):
7708 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7709 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7710 (message_log_check_duplicate): Remove parameters `prev_bol' and
7711 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7712 (redisplay_internal): Remove parameter `preserve_echo_area',
7713 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7714
7715 * indent.c (Fvertical_motion):
7716 * window.c (window_scroll_pixel_based, Frecenter):
7717 Don't pass `need_y_p' to `move_it_by_lines'.
7718
1c470562
SM
77192011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7720
44f230aa
SM
7721 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7722 steal a few bits to be more compact.
7723 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7724 Remove unneeded casts.
7725
1c470562
SM
7726 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7727
888adce9
ZK
77282011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7729
7730 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7731 binding" message (bug#7967).
7732
f838ed7b
PE
77332011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7734
77861b95
PE
7735 Fix more problems found by GCC 4.6.0's static checks.
7736
de6dbc14
PE
7737 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7738 Remove unused local var.
7739
f838ed7b
PE
7740 * editfns.c (Fmessage_box): Remove unused local var.
7741
792c7b2b
PE
7742 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7743 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7744 Omit unused local vars.
c499e557 7745 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7746 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7747 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7748 Omit unused local var.
7749
ba0165e1
PE
7750 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7751 Don't assume string length fits in int.
32ad8845 7752 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7753 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7754
3c59b4c9
PE
7755 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7756 instead of alloca (Bug#8344).
7757
a3eed478 7758 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7759 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7760
eb4d412d
PE
7761 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7762
1658b401
PE
7763 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7764 concerns.
7765
7766 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7767
7768 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7769
9a2c6e05
PE
7770 * keyboard.c (syms_of_keyboard): Use the same style as later
7771 in this function when indexing through an array. This also
7772 works around GCC bug 48267.
7773
03d0a109
PE
7774 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7775
44f730c8
PE
7776 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7777
fe75f926
PE
7778 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7779 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7780
ffa8c828
PE
7781 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7782 This avoids undefined behavior on integer overflow, and is a bit
7783 more convenient anyway since it is compared to a size_t variable.
7784
c5101a77
PE
7785 Variadic C functions now count arguments with size_t, not int.
7786 This avoids an unnecessary limitation on 64-bit machines, which
7787 caused (substring ...) to crash on large vectors (Bug#8344).
7788 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7789 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7790 All variadic functions and their callers changed accordingly.
c5101a77
PE
7791 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7792 * data.c (arith_driver, float_arith_driver): Likewise.
7793 * editfns.c (general_insert_function): Likewise.
7794 * eval.c (struct backtrace.nargs, interactive_p)
7795 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7796 (funcall_lambda, mark_backtrace): Likewise.
7797 * fns.c (concat): Likewise.
7798 * frame.c (x_set_frame_parameters): Likewise.
7799 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7800 0 if not found, not -1. All callers changed.
7801
dd3f25f7
PE
7802 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7803 (stack_copy_size): Now size_t, not int.
7804 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7805
461c2ab9
JB
78062011-03-28 Juanma Barranquero <lekktu@gmail.com>
7807
7808 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7809 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7810 All callers changed.
7811
7812 * lisp.h (multibyte_char_to_unibyte):
7813 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7814 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7815 * character.h (CHAR_TO_BYTE8):
7816 * cmds.c (internal_self_insert):
7817 * editfns.c (general_insert_function):
7818 * keymap.c (push_key_description):
7819 * search.c (Freplace_match):
7820 * xdisp.c (message_dolog, set_message_1): All callers changed.
7821
f6d62986
SM
78222011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7823
7824 * keyboard.c (safe_run_hook_funcall): New function.
7825 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7826 don't set the hook to nil, but remove the offending function instead.
7827 (Qcommand_hook_internal): Remove, unused.
7828 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7829 Vcommand_hook_internal.
7830
7831 * eval.c (enum run_hooks_condition): Remove.
7832 (funcall_nil, funcall_not): New functions.
7833 (run_hook_with_args): Call each function through a `funcall' argument.
7834 Remove `cond' argument, now redundant.
7835 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7836 (Frun_hook_with_args_until_failure): Adjust accordingly.
7837 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7838
1db5b1ad
JB
78392011-03-28 Juanma Barranquero <lekktu@gmail.com>
7840
7841 * dispextern.h (string_buffer_position): Remove declaration.
7842
7843 * print.c (strout): Remove parameter `multibyte', unused since
7844 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7845
7846 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7847 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7848 All callers changed.
7849
7850 * w32.c (_wsa_errlist): Use braces for struct initializers.
7851
7852 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7853 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7854 All callers changed.
7855 (string_buffer_position): Likewise. Also, make static (it's never
7856 used outside xdisp.c).
7857 (cursor_row_p): Remove parameter `w', unused since
7858 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7859 (decode_mode_spec): Remove parameter `precision', introduced during
7860 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7861 All callers changed.
7862
5ffb62aa
JD
78632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7864
7865 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7866
461c2ab9 78672011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7868
7869 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7870 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7871 (ns_update_auto_hide_menu_bar): New functions.
7872 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7873 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7874 ns_constrain_all_frames.
7875 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7876 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7877
5c380ffb
JD
78782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7879
7880 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7881
9af30bdf
GM
78822011-03-27 Glenn Morris <rgm@gnu.org>
7883
7884 * syssignal.h: Replace RETSIGTYPE with void.
7885 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7886 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7887 Replace SIGTYPE with void everywhere.
7888 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7889 * s/template.h (SIGTYPE): Remove commented out definition.
7890
e2abce01
JB
78912011-03-26 Eli Zaretskii <eliz@gnu.org>
7892
7893 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7894 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7895
f868cd8a
JB
78962011-03-26 Juanma Barranquero <lekktu@gmail.com>
7897
59eb0929
JB
7898 * w32.c (read_unc_volume): Use parameter `henum', instead of
7899 global variable `wget_enum_handle'.
7900
7901 * keymap.c (describe_vector): Remove parameters `indices' and
7902 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7903 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7904
f868cd8a
JB
7905 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7906
7907 * keyboard.c (timer_check): Remove parameter `do_it_now',
7908 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7909 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7910 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7911
7912 * keyboard.c (read_char):
7913 * w32menu.c (w32_menu_display_help):
7914 * xmenu.c (show_help_event, menu_help_callback):
7915 Adjust calls to `show_help_echo'.
7916
7917 * gtkutil.c (xg_maybe_add_timer):
7918 * keyboard.c (readable_events):
7919 * process.c (wait_reading_process_output):
7920 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7921
7922 * insdel.c (adjust_markers_gap_motion):
7923 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7924 (gap_left, gap_right): Don't call it.
7925
2ecf6fdb
CY
79262011-03-25 Chong Yidong <cyd@stupidchicken.com>
7927
7928 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7929 incurred during fontification.
7930
6b1f9ba4
JB
79312011-03-25 Juanma Barranquero <lekktu@gmail.com>
7932
7933 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7934 (DEFVAR_PER_BUFFER): Don't pass it.
7935
7936 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7937 (scrolling_window): Don't pass it.
7938
0f4a96b5
JB
79392011-03-25 Juanma Barranquero <lekktu@gmail.com>
7940
7941 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7942
7943 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7944 and `suffix'.
7945 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7946 of variables specific to SELinux and computation of `encoded_absname'.
7947
7948 * image.c (XPutPixel): Remove unused variable `height'.
7949
7950 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7951
7952 * unexw32.c (get_section_info): Remove unused variable `section'.
7953
7954 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7955 (system_process_attributes): Remove unused variable `sess'.
7956 (sys_read): Remove unused variable `err'.
7957
7958 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7959 (w32_wnd_proc): Remove unused variable `isdead'.
7960 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7961 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7962 (x_create_tip_frame): Remove unused variable `tem'.
7963
7964 * w32inevt.c (w32_console_read_socket):
7965 Remove unused variable `no_events'.
7966
7967 * w32term.c (x_draw_composite_glyph_string_foreground):
7968 Remove unused variable `width'.
7969
1149507c
JB
79702011-03-24 Juanma Barranquero <lekktu@gmail.com>
7971
7972 * w32term.c (x_set_glyph_string_clipping):
7973 Don't pass uninitialized region to CombineRgn.
7974
9c88f339
JB
79752011-03-23 Juanma Barranquero <lekktu@gmail.com>
7976
7977 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7978 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7979 (Fx_close_connection): Remove unused variable `i'.
7980
7981 * w32font.c (w32font_draw): Return number of glyphs.
7982 (w32font_open_internal): Remove unused variable `i'.
7983 (w32font_driver): Add missing initializer.
7984
7985 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7986 (fill_in_menu): Remove unused variable `items_added'.
7987
7988 * w32term.c (last_mouse_press_frame): Remove static global variable.
7989 (w32_clip_to_row): Remove unused variable `f'.
7990 (x_delete_terminal): Remove unused variable `i'.
7991
7992 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7993 (NOTHING): Remove unused static global variable.
7994 (uniscribe_check_otf): Remove unused variable `table'.
7995 (uniscribe_font_driver): Add missing initializers.
7996
dee091a3
JD
79972011-03-23 Julien Danjou <julien@danjou.info>
7998
7999 * term.c (Fsuspend_tty, Fresume_tty):
8000 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8001 * window.c (temp_output_buffer_show):
8002 * insdel.c (signal_before_change):
8003 * frame.c (Fhandle_switch_frame):
8004 * fileio.c (Fdo_auto_save):
8005 * emacs.c (Fkill_emacs):
8006 * editfns.c (save_excursion_restore):
8007 * cmds.c (internal_self_insert):
8008 * callint.c (Fcall_interactively):
8009 * buffer.c (Fkill_all_local_variables):
8010 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8011 Use Frun_hooks.
0f4a96b5 8012 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8013 unconditionally since it does the check itself.
dee091a3 8014
2c520ab5 80152011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8016
c9c49752
PE
8017 Fix more problems found by GCC 4.5.2's static checks.
8018
8abc3f12
PE
8019 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8020 the first time through the loop, since we know p0 < p1 then.
8021 This also avoids a gcc -Wstrict-overflow warning.
8022
a2d26660
PE
8023 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8024 leading to a memory leak, possible in functions like
8025 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8026 of objects (Bug#8318).
a2d26660 8027
916c72e9
PE
8028 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8029 that could (at least in theory) be that large.
8030
19ab8a18
PE
8031 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8032 This is less likely to overflow, and avoids undefined behavior if
8033 overflow does occur. All callers changed. Use strtoul to scan
8034 for the unsigned long integer.
b7cbbd6f
PE
8035 (pint2hrstr): Simplify and tune code slightly.
8036 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8037
f0641eff
PE
8038 * scroll.c (do_scrolling): Work around GCC bug 48228.
8039 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8040
7f650bb9
PE
8041 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8042 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8043 (validate_x_resource_name): Simplify count usage.
8044 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8045
37dd57d1
PE
8046 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8047 fail (Bug#8306).
81e56e61 8048
699979fc 8049 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8050
401bf9b4
PE
8051 * process.c (Fmake_network_process): Use socklen_t, not int,
8052 where POSIX says socklen_t is required in portable programs.
8053 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8054 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8055 (Fmake_network_process, server_accept_connection):
8056 (wait_reading_process_output, read_process_output):
8057 Likewise.
8058
b93aacde
PE
8059 * process.c: Rename or move locals to avoid shadowing.
8060 (list_processes_1, Fmake_network_process):
8061 (read_process_output_error_handler, exec_sentinel_error_handler):
8062 Rename or move locals.
4dc343ee 8063 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8064 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8065 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8066 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8067 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8068
af8a867c 8069 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8070 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8071 Include tparam.h instead, since it declares them.
af8a867c
PE
8072 * cm.h (PC): Remove extern decl; tparam.h now does this.
8073 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8074 * terminfo.c: Include tparam.h, to check interfaces.
8075 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8076 (tparam): Adjust signature to match interface in tparam.h;
8077 this removes some undefined behavior. Check that outstring and len
8078 are zero, which they always are with Emacs.
8079 * tparam.h (PC, BC, UP): New extern decls.
8080
0248044d 8081 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8082 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8083
8ff096c1 8084 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8085 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8086 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8087 (ftfont_list): Remove unused local.
49eaafba
PE
8088 (get_adstyle_property, ftfont_pattern_entity):
8089 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8090 Rename locals to avoid shadowing.
8ff096c1 8091
e2be39f6
PE
8092 * xfont.c (xfont_list_family): Mark var as initialized.
8093
c9735e30
PE
8094 * xml.c (make_dom): Now static.
8095
8f5201ae
PE
8096 * composite.c (composition_compute_stop_pos): Rename local to
8097 avoid shadowing.
b246f932
PE
8098 (composition_reseat_it): Remove unused locals.
8099 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8100 (composition_update_it): Mark var as initialized.
11b61122
PE
8101 (find_automatic_composition): Mark vars as initialized,
8102 with a FIXME (Bug#8290).
8f5201ae 8103
760fbc2c
PE
8104 character.h: Rename locals to avoid shadowing.
8105 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8106 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8107 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8108 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8109 to avoid shadowing.
8110
ff08eb85
PE
8111 * textprop.c (property_change_between_p): Remove; unused.
8112
fc7bf025
PE
8113 * intervals.c (interval_start_pos): Now static.
8114
235d7abc
PE
8115 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8116
44f230aa
SM
8117 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8118 Rename locals to avoid shadowing.
3e7d6594 8119
50060332
PE
8120 * sound.c (wav_play, au_play, Fplay_sound_internal):
8121 Fix pointer signedness.
d01f234b 8122 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8123 (wav_play): Initialize a variable to 0, to prevent undefined
8124 behavior (Bug#8278).
50060332 8125
c4fc4e30
PE
8126 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8127
918436ed
PE
8128 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8129
c939f91b
PE
8130 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8131 clobbering (Bug#8298).
b9c7f648
PE
8132 * sysdep.c (sys_subshell): Likewise.
8133 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8134
6bd8c144
PE
8135 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8136 This should get cleaned up, so that child_setup has the
8137 same signature on all platforms.
8138
7710357c 8139 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8140 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8141
c59da222
CY
81422011-03-22 Chong Yidong <cyd@stupidchicken.com>
8143
8144 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8145 not to be necessary, and produces flickering.
8146
66b87493
GM
81472011-03-20 Glenn Morris <rgm@gnu.org>
8148
8149 * config.in: Remove file.
8150
45b6f6d5
JB
81512011-03-20 Juanma Barranquero <lekktu@gmail.com>
8152
8153 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8154 are now in src/globals.h.
8155 (syms_of_minibuf): Remove spurious & from previous change.
8156
3ec03f7e
LL
81572011-03-20 Leo <sdl.web@gmail.com>
8158
8159 * minibuf.c (completing-read-function): New variable.
8160 (completing-read-default): Rename from completing-read.
8161 (completing-read): Call completing-read-function.
8162
b14e3e21
CY
81632011-03-19 Juanma Barranquero <lekktu@gmail.com>
8164
8165 * xfaces.c (Fx_load_color_file):
8166 Read color file from absolute filename (bug#8250).
8167
f2b726e6
JB
81682011-03-19 Juanma Barranquero <lekktu@gmail.com>
8169
8170 * makefile.w32-in: Update dependencies.
8171
09f6ff02
EZ
81722011-03-17 Eli Zaretskii <eliz@gnu.org>
8173
8174 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8175
29a6015a
PE
81762011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8177
a3a6c54e
PE
8178 Fix more problems found by GCC 4.5.2's static checks.
8179
b766f867
PE
8180 * process.c (make_serial_process_unwind, send_process_trap):
8181 (sigchld_handler): Now static.
8182
be02381c
PE
8183 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8184 That way, the code declares only the vars that it needs.
8185 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8186 * s/cygwin.h (PTY_ITERATION): Likewise.
8187 * s/darwin.h (PTY_ITERATION): Likewise.
8188 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8189
57048744
PE
8190 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8191 * process.c (allocate_pty): Don't declare stb unless it's needed.
8192
7914961c 8193 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8194 (CONSTANTLIM): Remove; unused.
8195 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8196 Define only if needed.
7914961c 8197
b3967b18
PE
8198 * unexelf.c (unexec): Name an expression,
8199 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8200 Use a different way to cause a compilation error if anyone uses
8201 n rather than nn, a way that does not involve shadowing.
73366a00 8202 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8203
29a6015a
PE
8204 * deps.mk (unexalpha.o): Remove; unused.
8205
43cfc33e 8206 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8207 * unexec.h: New file.
ce701a33
PE
8208 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8209 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8210 Depend on unexec.h.
8211 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8212 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8213 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8214 Change as necessary to match prototype in unexec.h.
ce701a33 8215
01f44d5a
PE
8216 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8217 shadowing.
4f63c6bb 8218 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8219
a6670b0b
PE
8220 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8221 Rename locals to avoid shadowing.
8222
cef2010d 8223 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8224 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8225
d4d7173a
PE
8226 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8227
f08b802a
PE
8228 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8229 warning when compiling print.c.
8230
3ddb0639
PE
8231 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8232 instead of using an uninitialized var.
5ad03b97 8233 (font_sort_entities): Mark var as initialized.
3ddb0639 8234
170a2692
PE
8235 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8236
e663c700
PE
8237 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8238 pointers to constants.
89bc529a 8239 (font_parse_fcname): Remove unused vars.
7b81e2d0 8240 (font_delete_unmatched): Now static.
ea838e10 8241 (font_get_spec): Remove; unused.
13a547c6
PE
8242 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8243 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8244 Rename or move locals to avoid shadowing.
e663c700 8245
2a80c887 8246 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8247 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8248
1384fa33 8249 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8250 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8251
8b2c52e9
PE
8252 * alloc.c (mark_backtrace): Move decl from here ...
8253 * lisp.h: ... to here, so that it can be checked.
8254
475545b5 8255 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8256 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8257 (lisp_indirect_variable): Name an expression,
8258 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8259 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8260
b1349114 8261 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8262 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8263 Use const pointer when appropriate.
b1349114 8264
a2928364
PE
8265 * lisp.h (get_system_name, get_operating_system_release):
8266 Move decls here, to check interfaces.
8267 * process.c (get_operating_system_release): Move decl to lisp.h.
8268 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8269 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8270 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8271 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8272 (Fformat_time_string, Fencode_time, Finsert_char):
8273 (Ftranslate_region_internal, Fformat):
8274 Rename or remove local vars to avoid shadowing.
9710023e 8275 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8276
a415e694
PE
8277 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8278 avoid shadowing.
8279
8ef4622d
PE
8280 * lisp.h (eassert): Check that the argument compiles, even if
8281 ENABLE_CHECKING is not defined.
8282
946f9a5b
PE
8283 * data.c (Findirect_variable): Name an expression, to avoid
8284 gcc -Wbad-function-cast warning.
112396d6 8285 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8286 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8287 (Fmake_variable_buffer_local, Fmake_local_variable):
8288 Mark variables as initialized.
52746918 8289 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8290
e5aab7e7 8291 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8292 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8293 Rename locals to avoid shadowing.
dff45157
PE
8294 (mark_stack): Move local variables into the #ifdef region where
8295 they're used.
7bc26fdb
PE
8296 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8297 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8298 needed otherwise.
8299 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8300 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8301 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8302
e5aab7e7
PE
8303 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8304 avoids undefined behavior in theory.
8305
4da60324
PE
8306 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8307
88043301
PE
8308 Use functions, not macros, for up- and down-casing (Bug#8254).
8309 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8310 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8311 to use the following functions instead of these macros.
8312 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8313 EMACS_INT, since callers assume the returned value fits in int.
8314 (upcase1): Likewise, for UPCASE_TABLE.
8315 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8316 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8317 the race-condition problem in the old DOWNCASE.
88043301 8318
19ed5445
PE
8319 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8320 Rename locals to avoid shadowing.
8321 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8322 (regex_compile, re_search_2, re_match_2_internal):
8323 Remove unused local vars.
952db0d7
PE
8324 (FREE_VAR): Rewrite so as not to use empty "else",
8325 which gcc can warn about.
da053e48 8326 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8327 (RETALLOC_IF): Define only if needed.
8328 (WORDCHAR_P): Likewise. This one is never needed, but is used
8329 only in a comment talking about a compiler bug, so put inside
8330 the #if 0 of that comment.
8331 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8332 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8333 Remove; unused.
19ed5445 8334
1f3561e4 8335 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8336 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8337 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8338
ded6f8f7
PE
8339 * search.c (simple_search): Remove unused var.
8340
dbd37a95
PE
8341 * dired.c (compile_pattern): Move decl from here ...
8342 * lisp.h: ... to here, so that it can be checked.
8343 (struct re_registers): New forward decl.
8344
7e47afad
PE
8345 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8346
85f24f61
PE
8347 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8348 All uses changed.
8349 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8350 Rename locals to avoid shadowing.
5671df8f 8351 (Fvertical_motion): Mark locals as initialized.
85f24f61 8352
181aa2be 8353 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8354 (casify_region): Mark local as initialized.
181aa2be 8355
930d429c
PE
8356 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8357
7082eac6
PE
8358 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8359 New macros, so that the caller can use some names other than
8360 gcpro1, gcpro2, etc.
8361 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8362 of the new macros.
8363 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8364 argument, for consistency with GCPRO2_VAR, etc: it is now the
8365 prefix of the variable, not the variable itself. All uses
8366 changed.
38b2c076
PE
8367 * dired.c (directory_files_internal, file_name_completion):
8368 Rename locals to avoid shadowing.
8369
15206ed9
PE
8370 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8371 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8372 dired.c's scmp function, had undefined behavior.
8373 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8374 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8375 * buffer.h: ... to here, because these macros use current_buffer,
8376 and the new implementation with inline functions needs to have
8377 current_buffer in scope now, rather than later when the macros
8378 are used.
8379 (downcase, upcase1): New static inline functions.
8380 (DOWNCASE, UPCASE1): Reimplement using these functions.
8381 This avoids undefined behavior in expressions like
8382 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8383 from race conditions in accessing the global variables
8384 case_temp1 and case_temp2.
8385 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8386 * lisp.h (case_temp1, case_temp2): Remove their decls.
8387 * character.h (ASCII_CHAR_P): Move from here ...
8388 * lisp.h: ... to here, so that the inline functions mentioned
8389 above can use them.
8390
4a6bea26
PE
8391 * dired.c (directory_files_internal_unwind): Now static.
8392
f14b7e14
PE
8393 * fileio.c (file_name_as_directory, directory_file_name):
8394 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8395 Now static.
2893f146
PE
8396 (file_name_as_directory): Use const pointers when appropriate.
8397 (Fexpand_file_name): Likewise. In particular, newdir might
8398 point at constant storage, so make it a const pointer.
fd4ead52 8399 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8400 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8401 signedness issues.
f839df0c
PE
8402 (Fset_file_times, Finsert_file_contents, auto_save_error):
8403 Rename locals to avoid shadowing.
f14b7e14 8404
5716756e 8405 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8406 (Ftry_completion, Fall_completions): Rename or remove locals
8407 to avoid shadowing.
5716756e 8408
b4c3046a
PE
8409 * marker.c (bytepos_to_charpos): Remove; unused.
8410
b45db522
PE
8411 * lisp.h (verify_bytepos, count_markers): New decls,
8412 so that gcc does not warn that these functions aren't declared.
8413
85876d07
PE
8414 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8415 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8416 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8417 (copy_text): Remove unused local var.
85876d07 8418
03d78a21 8419 * filelock.c (within_one_second): Now static.
b3dd38ab 8420 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8421
5df8f01b
PE
8422 * buffer.c (fix_overlays_before): Mark locals as initialized.
8423 (fix_start_end_in_overlays): Likewise. This function should be
8424 simplified by using pointers-to-pointers, but that's a different
8425 matter.
b1d876f1 8426 (switch_to_buffer_1): Now static.
8f54f30a
PE
8427 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8428 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8429
a70072c9 8430 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8431 Fix pointer signedness issue.
edced198
PE
8432 (sys_subshell): Mark local as volatile if checking for lint,
8433 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8434 (MAXPATHLEN): Define only if needed.
a70072c9 8435
a0977c44
PE
8436 * process.c (serial_open, serial_configure): Move decls from here ...
8437 * systty.h: ... to here, so that they can be checked.
8438
a884fdcc
PE
8439 * fns.c (get_random, seed_random): Move extern decls from here ...
8440 * lisp.h: ... to here, so that they can be checked.
8441
604efe86 8442 * sysdep.c (reset_io): Now static.
b8950c94 8443 (wait_for_termination_signal): Remove; unused.
604efe86 8444
38fc62d9
PE
8445 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8446 (copy_keymap_item, append_key, push_text_char_description):
8447 Now static.
1004a21a 8448 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8449 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8450 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8451 (describe_map_tree):
8452 Rename locals to avoid shadowing.
38fc62d9 8453
2f2650da
PE
8454 * keyboard.c: Declare functions static if they are not used elsewhere.
8455 (echo_char, echo_dash, cmd_error, top_level_2):
8456 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8457 (read_char, kbd_buffer_get_event, make_lispy_position):
8458 (make_lispy_event, make_lispy_movement, apply_modifiers):
8459 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8460 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8461 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8462 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8463 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8464
a053e86c 8465 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8466 (mark_kboards): Move decl here ...
8467 * alloc.c (mark_kboards): ... from here.
a053e86c 8468
4752793e
PE
8469 * lisp.h (force_auto_save_soon): New decl.
8470
74f10ca7 8471 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8472 (DEFINE_DUMMY_FUNCTION): New macro.
8473 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8474 Use it.
c03cd23f
PE
8475 (main): Add casts to avoid warnings
8476 if GCC considers string literals to be constants.
74f10ca7 8477
022e70d4
PE
8478 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8479
59d6fe83
PE
8480 * dbusbind.c: Pointer signedness fixes.
8481 (xd_signature, xd_append_arg, xd_initialize):
8482 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8483 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8484 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8485 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8486
78320123
PE
8487 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8488 if GCC considers string literals to be constants.
49cebcca 8489 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8490
35ac2a97
SM
84912011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8492
fb103ca9
SM
8493 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8494 (print_preprocess, print_object): New macro to fix last change.
8495
35ac2a97
SM
8496 * print.c (print_preprocess): Don't forget font objects.
8497
62973b41
JB
84982011-03-16 Juanma Barranquero <lekktu@gmail.com>
8499
8500 * emacs.c (USAGE3): Doc fixes.
8501
0e48bb22
AS
85022011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8503
8504 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8505 structure.
8506
7684e57b
JB
85072011-03-14 Juanma Barranquero <lekktu@gmail.com>
8508
8509 * lisp.h (VWindow_system, Qfile_name_history):
8510 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8511 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8512 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8513
8514 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8515 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8516
8517 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8518 * w32console.c (detect_input_pending, read_input_pending)
8519 (encode_terminal_code):
8520 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8521 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8522 (w32_system_caret_y, Qfile_name_history):
8523 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8524 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8525 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8526 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8527 * w32proc.c (Qlocal, report_file_error):
8528 * w32term.c (Vwindow_system, updating_frame):
8529 * w32uniscribe.c (initialized, uniscribe_font_driver):
8530 Remove unneeded extern declarations.
8531
2aa46d6c
CY
85322011-03-14 Chong Yidong <cyd@stupidchicken.com>
8533
c96bbc66 8534 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8535
cffc6f3b
CY
85362011-03-13 Chong Yidong <cyd@stupidchicken.com>
8537
8538 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8539 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8540 These macros can no longer be used for assignment.
8541
44f230aa
SM
8542 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8543 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8544 (record_buffer_markers, fetch_buffer_markers): New functions for
8545 recording and fetching special buffer markers.
8546 (set_buffer_internal_1, set_buffer_temp): Use them.
8547
8548 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8549
8550 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8551
8552 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8553 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8554
8555 * xdisp.c (hscroll_window_tree):
8556 (reconsider_clip_changes): Use PT instead of BUF_PT.
8557
d251f04b
EZ
85582011-03-13 Eli Zaretskii <eliz@gnu.org>
8559
8560 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8561 $(EMACS_ROOT)/lib/intprops.h.
8562
f0c77cd1
PE
85632011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8564
3eca4629
PE
8565 Fix more problems found by GCC 4.5.2's static checks.
8566
7c86ee98
PE
8567 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8568 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8569 (xg_free_frame_widgets): Make it clear that a local variable is
8570 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8571 (gdk_window_get_screen): Make it clear that this macro is needed
8572 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8573 (int_gtk_range_get_value): New function, which avoids a diagnostic
8574 from gcc -Wbad-function-cast.
8575 (xg_set_toolkit_scroll_bar_thumb): Use it.
8576 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8577 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8578 (get_utf8_string, xg_get_file_with_chooser):
8579 Rename locals to avoid shadowing.
8580 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8581
41729b81
PE
8582 * xgselect.c (xg_select): Remove unused var.
8583
f0c77cd1
PE
8584 * image.c (four_corners_best): Mark locals as initialized.
8585 (gif_load): Initialize transparent_p to zero (Bug#8238).
8586 Mark another local as initialized.
ec6cf4c6 8587 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8588
ce0ad53d 8589 * image.c (clear_image_cache): Now static.
d5d5a617 8590 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8591 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8592 (x_edge_detection): Remove unnecessary cast that
8593 gcc -Wbad-function-cast diagnoses.
2037898d 8594 (gif_load): Fix pointer signedness.
6ae141d6
PE
8595 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8596 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8597
33383987 85982011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8599
d32df629
PE
8600 Improve quality of tests for time stamp overflow.
8601 For example, without this patch (encode-time 0 0 0 1 1
8602 1152921504606846976) returns the obviously-bogus value (-948597
8603 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8604 reports time overflow. See
8605 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8606 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8607 * editfns.c: Include limits.h and intprops.h.
8608 (TIME_T_MIN, TIME_T_MAX): New macros.
8609 (time_overflow): Move earlier, to before first use.
8610 (hi_time, lo_time): New functions, for an accurate test for
8611 out-of-range times.
8612 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8613 (Fget_internal_run_time): Don't assume time_t fits in int.
8614 (make_time): Use list2 instead of Fcons twice.
8615 (Fdecode_time): More accurate test for out-of-range times.
8616 (check_tm_member): New function.
8617 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8618 (lisp_time_argument): Don't rely on undefined left-shift and
8619 right-shift behavior when checking for time stamp overflow.
8be6f318 8620
fe31d94c
PE
8621 * editfns.c (time_overflow): New function, refactoring common code.
8622 (Fformat_time_string, Fdecode_time, Fencode_time):
8623 (Fcurrent_time_string): Use it.
8624
8be6f318
PE
8625 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8626 * dired.c (make_time): Move to ...
8627 * editfns.c (make_time): ... here.
8628 * systime.h: Note the move.
8629
09d9db2c 86302011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8631
126bc0dc
YM
8632 * fringe.c (update_window_fringes): Remove unused variables.
8633
c47cbdfd
YM
8634 * unexmacosx.c (copy_data_segment): Also copy __got section.
8635 (Bug#8223)
8636
7ac80be9
EZ
86372011-03-12 Eli Zaretskii <eliz@gnu.org>
8638
c96bbc66 8639 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8640 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8641 Constify `char *' arguments and their references according to
8642 prototypes in tparam.h.
8643
ecb0f94d 8644 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8645
7ac80be9
EZ
8646 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8647 Adapt all references accordingly.
8648
8649 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8650
ef1fd07e
TT
86512011-03-11 Tom Tromey <tromey@redhat.com>
8652
8653 * buffer.c (syms_of_buffer): Remove obsolete comment.
8654
7ef4b50c
EZ
86552011-03-11 Eli Zaretskii <eliz@gnu.org>
8656
8657 * termhooks.h (encode_terminal_code): Declare prototype.
8658
8659 * msdos.c (encode_terminal_code): Don't declare prototype.
8660
8661 * term.c (encode_terminal_code): Now external again, used by
8662 w32console.c and msdos.c.
8663
44f230aa
SM
8664 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8665 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8666
4b1ec863 86672011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8668
1714f52b 8669 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8670
4b1ec863
PE
8671 * fringe.c (update_window_fringes): Mark locals as initialized
8672 (Bug#8227).
8673 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8674
524c7aa6
PE
8675 * alloc.c (mark_fringe_data): Move decl from here ...
8676 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8677 to check its interface.
8678 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8679
a5c0af81 8680 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8681 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8682 (fontset_font): Mark local as initialized.
a9a06e0b 8683 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8684
b4716021
PE
8685 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8686
811e9bac 8687 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8688 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8689 (x_own_selection, Fx_disown_selection_internal): Rename locals
8690 to avoid shadowing.
8691 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8692
7e3ab302
PE
8693 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8694 so that the caller can use some name other than gcpro1.
8695 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8696 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8697 (Fx_backspace_delete_keys_p):
8698 Use them to avoid shadowing, and rename vars to avoid shadowing.
8699 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8700 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8701 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8702 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8703 Remove unused locals.
7e3ab302
PE
8704 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8705 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8706 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8707 macros.
f78faa98 8708
e2b13473
PE
8709 * xterm.h (x_mouse_leave): New decl.
8710
77f23912
PE
8711 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8712 Remove unused functions.
cdf4ba58
PE
8713 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8714 (x_calc_absolute_position): Now static.
7411c686 8715 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8716 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8717 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8718 unless they are used.
38d0b34a
PE
8719 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8720 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8721 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8722 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8723 (x_error_catcher, x_connection_closed, x_error_handler):
8724 (x_error_quitter, xembed_send_message, x_iconify_frame):
8725 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8726 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8727 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8728
44f230aa
SM
8729 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8730 Rename or move locals to avoid shadowing.
6b463e58 8731 (tty_defined_color, merge_face_heights): Now static.
5967d051 8732 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8733 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8734 does not deduce is never used uninitialized.
73719eba
PE
8735 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8736 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8737
426994c3 8738 * terminal.c (store_terminal_param): Now static.
5489860b 8739
032f1620 8740 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8741 (set_frame_menubar): Remove unused local.
d4323972 8742 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8743 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8744 since they might point to immutable storage.
281585b0
PE
8745 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8746 since it's unused otherwise.
032f1620 8747
367c19e5 8748 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8749 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8750 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8751 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8752 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8753 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8754 does not deduce are never used uninitialized.
70739cbe 8755
07b48fa9
PE
8756 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8757
8868a238 8758 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8759 * window.c (window_loop, size_window):
8760 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8761
7e5cf297 8762 * window.c (display_buffer): Now static.
d6550a9f
PE
8763 (size_window): Mark variables that gcc -Wuninitialized
8764 does not deduce are never used uninitialized.
a586633d
PE
8765 * window.h (check_all_windows): New decl, to forestall
8766 gcc -Wmissing-prototypes diagnostic.
5b555da1 8767 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8768
f6095868
PE
8769 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8770 shadowing.
8771 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8772 Include <limits.h>.
8773 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8774 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8775 (load_charset_map): Mark variables that gcc -Wuninitialized
8776 does not deduce are never used uninitialized.
53df7c11 8777 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8778
f38b440c
PE
8779 * coding.c (coding_set_source, coding_set_destination):
8780 Use "else { /* comment */ }" rather than "else /* comment */;"
8781 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8782 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8783 a block, when the outer 'i' will do.
8784 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8785 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8786 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8787 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8788 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8789 Rename locals to avoid shadowing.
8790 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8791 * coding.c (emacs_mule_char, encode_invocation_designation):
8792 Now static, since they're not used elsewhere.
413bb2db 8793 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8794 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8795 (decode_coding_emacs_mule): Mark variables that gcc
8796 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8797 (detect_coding_iso_2022): Initialize a local variable that might
8798 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8799 this initialization is needed. (Bug#8211)
5f58e762
PE
8800 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8801 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8802 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8803 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8804 Remove unused macros.
f38b440c 8805
232b38b9 8806 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8807 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8808 * character.c (string_count_byte8): Likewise.
232b38b9 8809
fb90da1b
PE
8810 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8811 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8812
fb93dbc2
PE
8813 * chartab.c (copy_sub_char_table): Now static, since it's not used
8814 elsewhere.
5c156ace
PE
8815 (sub_char_table_ref_and_range, char_table_ref_and_range):
8816 Rename locals to avoid shadowing.
bbcd0949 8817 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8818
7d3b3862 8819 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8820 (BIDI_BOB): Remove unused macro.
7d3b3862 8821
6be7d3da
PE
8822 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8823 deduce are never used uninitialized.
c2ed9c8b 8824 * term.c (encode_terminal_code): Likewise.
6be7d3da 8825
75f8807f 8826 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8827
50938595
PE
8828 * tparam.h: New file.
8829 * term.c, tparam.h: Include it.
8830 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8831 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8832 Move these decls to tparam.h, and make them agree with what
8833 is actually in tparam.c. The previous trick of using incompatible
8834 decls in different modules does not conform to the C standard.
8835 All callers of tparam changed to use tparam's actual API.
8836 * tparam.c (tparam1, tparam, tgoto):
8837 Use const pointers where appropriate.
8838
fbceeba2
PE
8839 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8840 * cm.h (struct cm): Likewise.
8841 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8842 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8843 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8844 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8845 (turn_on_face, init_tty): Likewise.
8846 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8847
7f3f1250
PE
8848 * term.c (term_mouse_position): Rename local to avoid shadowing.
8849
e6ca6543
PE
8850 * alloc.c (mark_ttys): Move decl from here ...
8851 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8852
c40f8d15
AS
88532011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8854
8855 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8856
cfe0661d
JB
88572011-03-09 Juanma Barranquero <lekktu@gmail.com>
8858
8859 * search.c (compile_pattern_1): Remove argument regp, unused since
8860 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8861 (compile_pattern): Don't pass it.
8862
0afb4571
J
88632011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8864
8865 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8866 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8867 for ! HAVE_GTK3.
8868 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8869
8870 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8871
8872 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8873 gdk_window_get_screen, gdk_window_get_geometry,
8874 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8875 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8876 (xg_get_pixbuf_from_pixmap): New function.
8877 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8878 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8879 Call xg_get_pixbuf_from_pixmap instead of
8880 gdk_pixbuf_get_from_drawable.
8881 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8882 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8883 (xg_check_special_colors): Use GtkStyleContext and its functions
8884 for HAVE_GTK3.
8885 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8886 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8887 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8888 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8889 Call gtk_widget_get_preferred_size.
0afb4571
J
8890 (xg_frame_resized): gdk_window_get_geometry only takes 5
8891 parameters.
44f230aa
SM
8892 (xg_win_to_widget, xg_event_is_for_menubar):
8893 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8894 (xg_set_widget_bg): New function.
8895 (delete_cb): New function.
895009e1 8896 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8897 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8898 (xg_set_background_color): Call xg_set_widget_bg.
8899 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8900 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8901 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8902 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8903 if ! HAVE_GTK3.
8904 (update_frame_tool_bar): Call gtk_widget_hide.
8905 (xg_initialize): Use GDK_KEY_g.
8906
8907 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8908 if ! HAVE_GTK3
8909 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8910
8911 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8912 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8913 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8914
1c2cc4ef
JB
89152011-03-08 Juanma Barranquero <lekktu@gmail.com>
8916
8917 * w32xfns.c (select_palette): Check success of RealizePalette against
8918 GDI_ERROR, not zero.
8919
33383987 8920See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8921
8922;; Local Variables:
8923;; coding: utf-8
aac0c6e3
MR
8924;; End:
8925
33383987 8926 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8927
8928 This file is part of GNU Emacs.
8929
8930 GNU Emacs is free software: you can redistribute it and/or modify
8931 it under the terms of the GNU General Public License as published by
8932 the Free Software Foundation, either version 3 of the License, or
8933 (at your option) any later version.
8934
8935 GNU Emacs is distributed in the hope that it will be useful,
8936 but WITHOUT ANY WARRANTY; without even the implied warranty of
8937 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8938 GNU General Public License for more details.
8939
8940 You should have received a copy of the GNU General Public License
8941 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.