* indent.c (sane_tab_width): New function.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e39e811e
PE
12011-06-18 Paul Eggert <eggert@cs.ucla.edu>
2
53b2623d
PE
3 * indent.c (sane_tab_width): New function.
4 (current_column, scan_for_column, Findent_to, position_indentation)
5 (compute_motion): Use it. This is just for clarity.
6
45aebb64
PE
7 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
8
f2ed8a70
PE
9 * lisp.h (lint_assume): New macro.
10 * composite.c (composition_gstring_put_cache):
11 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
12
a9e860e1
PE
13 * editfns.c: Omit unnecessary forward decls, to simplify future changes.
14
b02c740e
PE
15 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
16
ebc96716
PE
17 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
18
b4e50fa0 19 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 20 Use much-faster test for byte-length change.
311d5d7c 21 Don't assume string byte-length fits in 'int'.
a4cf38e4 22 Check that character arg fits in 'int'.
85461888 23 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 24
c0c1ee9f
PE
25 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
26
a498d7f4
PE
27 * fns.c (concat): Catch string overflow earlier.
28 Do not rely on integer wraparound.
29
e39e811e
PE
30 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
31
fadf4e30
PE
322011-06-17 Paul Eggert <eggert@cs.ucla.edu>
33
87830974
PE
34 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
35 * xdisp.c (forward_to_next_line_start)
36 (back_to_previous_visible_line_start)
37 (reseat_at_next_visible_line_start, next_element_from_buffer):
38 Don't arbitrarily truncate the value of 'selective' to int.
39
76031fad
PE
40 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
41
5eb55db9
PE
42 * composite.c: Don't truncate sizes to 'int'.
43 (composition_gstring_p, composition_reseat_it)
44 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
45 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
46 not EMACS_UINT, for indexes.
5eb55db9 47
0703a717
PE
48 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
49
d6202519
PE
50 * buffer.c: Include <verify.h>.
51 (struct sortvec.priority, struct sortstr.priority):
8961a454 52 Now EMACS_INT, not int.
c20998a7 53 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
54 (struct sortstr.size, record_overlay_string)
55 (struct sortstrlist.size, struct sortlist.used):
56 Don't truncate size to int.
57 (record_overlay_string): Check for size-calculation overflow.
d6202519 58 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 59
28177add
PE
602011-06-16 Paul Eggert <eggert@cs.ucla.edu>
61
dd3482fe
PE
62 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
63 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
64 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
65
393d71f3 66 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
67 * fileio.c (Finsert_file_contents):
68 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
69 Remove the old (too-loose) buffer overflow checks.
70 They weren't needed, since make_gap checks for buffer overflow.
71 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
72 The old code merely checked for Emacs fixnum overflow, and relied
73 on undefined (wraparound) behavior. The new code avoids undefined
74 behavior, and also checks for ptrdiff_t and/or size_t overflow.
75
2e6813b0 76 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
77 Tune. Don't use wider integers than needed. Don't use alloca.
78 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 79
599a9e4f
PE
80 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
81
99561444
PE
82 * insdel.c, lisp.h (buffer_overflow): New function.
83 (insert_from_buffer_1, replace_range, replace_range_2):
84 * insdel.c (make_gap_larger):
85 * editfns.c (Finsert_char):
86 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
87
28177add
PE
88 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
89
e69dafad
PE
902011-06-15 Paul Eggert <eggert@cs.ucla.edu>
91
a7af7fde 92 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 93
b1c46f02
PE
94 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
95 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
96
e69dafad
PE
97 * fileio.c: Don't assume EMACS_INT fits in off_t.
98 (emacs_lseek): New static function.
99 (Finsert_file_contents, Fwrite_region): Use it.
100 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
101
566684ea
PE
102 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
103
e6966cd6
PE
104 * fns.c: Don't overflow int when computing a list length.
105 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
106 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
107 truncation on 64-bit hosts. Check for QUIT every
108 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
109 faster and is responsive enough.
110 (Flength): Report an error instead of overflowing an integer.
111 (Fsafe_length): Return a float if the value is not representable
112 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 113 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 114 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 115
dd0b0efb
PE
116 * alloc.c: Check that resized vectors' lengths fit in fixnums.
117 (header_size, word_size): New constants.
118 (allocate_vectorlike): Don't check size overflow here.
119 (allocate_vector): Check it here instead, since this is the only
120 caller of allocate_vectorlike that could cause overflow.
121 Check that the new vector's length is representable as a fixnum.
122
86fe5cfe
PE
123 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
124 The previous code was bogus. For example, next_almost_prime (32)
125 returned 39, which is undesirable as it is a multiple of 3; and
126 next_almost_prime (24) returned 25, which is a multiple of 5 so
127 why was the code bothering to check for multiples of 7?
128
80e88859
PE
129 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
130
4a2f0ad6
PE
131 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
132
f66c7cf8
PE
133 Variadic C functions now count arguments with ptrdiff_t.
134 This partly undoes my 2011-03-30 change, which replaced int with size_t.
135 Back then I didn't know that the Emacs coding style prefers signed int.
136 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
137 were being counted with int, which may truncate counts on 64-bit
138 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
139 * lisp.h (struct Lisp_Subr.function.aMANY)
140 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
141 Arg counts are now ptrdiff_t, not size_t.
142 All variadic functions and their callers changed accordingly.
143 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
144 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
145 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
146 * callint.c (Fcall_interactively): Check arg count for overflow,
147 to avoid potential buffer overrun. Use signed char, not 'int',
148 for 'varies' array, so that we needn't bother to check its size
149 calculation for overflow.
150 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
151 * eval.c (apply_lambda):
152 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
153 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
154 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
155
a1759b76
PE
156 * callint.c (Fcall_interactively): Don't use index var as event count.
157
d96be9fc
PE
158 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
159 * mem-limits.h (SIZE): Remove; no longer used.
160
a690a978 161 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 162
578c21e6
PE
163 Remove unnecessary casts.
164 * xterm.c (x_term_init):
165 * xfns.c (x_set_border_pixel):
166 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
167 These aren't needed now that we assume ANSI C.
168
96f53c6c
PE
169 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
170 It's more likely to cause problems (due to unsigned overflow)
171 than to cure them.
172
83c77d31
PE
173 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
174
ee2079f1
PE
175 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
176
6da65536
PE
177 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
178
7147c4a4
PE
179 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
180
193e32d9
PE
181 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
182
e5533da6
PE
183 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
184
9910e595
PE
185 GLYPH_CODE_FACE returns EMACS_INT, not int.
186 * dispextern.h (merge_faces):
187 * xfaces.c (merge_faces):
01103c44
PE
188 * xdisp.c (get_next_display_element, next_element_from_display_vector):
189 Don't assume EMACS_INT fits in int.
9910e595 190
2638320e
PE
191 * character.h (CHAR_VALID_P): Remove unused parameter.
192 * fontset.c, lisp.h, xdisp.c: All uses changed.
193
045eb8d9
PE
194 * editfns.c (Ftranslate_region_internal): Omit redundant test.
195
c1f134b5
PE
196 * fns.c (concat): Minor tuning based on overflow analysis.
197 This doesn't fix any bugs. Use int to hold character, instead
198 of constantly refetching from Emacs object. Use XFASTINT, not
199 XINT, for value known to be a character. Don't bother comparing
200 a single byte to 0400, as it's always less.
201
395fcb93 202 * floatfns.c (Fexpt):
327eeec8
PE
203 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
204
abbd3d23
PE
205 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
206 for characters.
207
684a03ef
PE
208 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
209
0fed43f3
PE
210 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
211 Without this fix, on a 64-bit host (aset S 0 4294967386) would
212 incorrectly succeed when S was a string, because 4294967386 was
213 truncated before it was used.
214
8fd02eb7
PE
215 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
216 Otherwise, an out-of-range integer could cause undefined behavior
217 on a 64-bit host.
218
f8c86b69
PE
219 * composite.c: Use int, not EMACS_INT, for characters.
220 (fill_gstring_body, composition_compute_stop_pos): Use int, not
221 EMACS_INT, for values that are known to be in character range.
222 This doesn't fix any bugs but is the usual style inside Emacs and
223 may generate better code on 32-bit machines.
224
34206dd2
PE
225 Make sure a 64-bit char is never passed to ENCODE_CHAR.
226 This is for reasons similar to the recent CHAR_STRING fix.
227 * charset.c (Fencode_char): Check that character arg is actually
228 a character. Pass an int to ENCODE_CHAR.
229 * charset.h (ENCODE_CHAR): Verify that the character argument is no
230 wider than 'int', as a compile-time check to prevent future regressions
231 in this area.
232
c5958d4c 233 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
234
235 Make sure a 64-bit char is never passed to CHAR_STRING.
236 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
237 by silently ignoring the top 32 bits, allowing some values
238 that were far too large to be valid characters.
239 * character.h: Include <verify.h>.
240 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
241 arguments are no wider than unsigned, as a compile-time check
242 to prevent future regressions in this area.
243 * data.c (Faset):
01103c44 244 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
245 (Fsubst_char_in_region):
246 * fns.c (concat):
247 * xdisp.c (decode_mode_spec_coding):
248 Adjust to CHAR_STRING's new requirement.
249 * editfns.c (Finsert_char, Fsubst_char_in_region):
250 * fns.c (concat): Check that character args are actually
251 characters. Without this test, these functions did the wrong
252 thing with wildly out-of-range values on 64-bit hosts.
253
d37ca623
PE
254 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
255 These casts should not be needed on 32-bit hosts, either.
256 * keyboard.c (read_char):
257 * lread.c (Fload): Remove casts to unsigned.
258
ea204efb
PE
259 * lisp.h (UNSIGNED_CMP): New macro.
260 This fixes comparison bugs on 64-bit hosts.
261 (ASCII_CHAR_P): Use it.
262 * casefiddle.c (casify_object):
01103c44 263 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
264 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
265 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
266 * dispextern.h (FACE_FROM_ID):
267 * keyboard.c (read_char): Use UNSIGNED_CMP.
268
41cb286c
PE
269 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
270 not to EMACS_INT, to avoid GCC warning.
271
4a1b9832
PE
272 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
273
55daad71
PE
274 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
275 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
276 isn't needed on 32-bit machines.
8f95c75c 277
01103c44
PE
278 * buffer.c (Fgenerate_new_buffer_name):
279 Use EMACS_INT for count, not int.
0ceccced 280 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
281
282 * data.c (Qcompiled_function): Now static.
283
c6f072e7
PE
284 * window.c (window_body_lines): Now static.
285
20ce5912
PE
286 * image.c (gif_load): Rename local to avoid shadowing.
287
9c4c5f81
PE
288 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
289 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
290 * alloc.c (make_save_value): Integer argument is now of type
291 ptrdiff_t, not int.
292 (mark_object): Use ptrdiff_t, not int.
293 * lisp.h (pD): New macro.
294 * print.c (print_object): Use it.
295
c0c5c8ae
PE
296 * alloc.c: Use EMACS_INT, not int, to count objects.
297 (total_conses, total_markers, total_symbols, total_vector_size)
298 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
299 (total_free_floats, total_floats, total_free_intervals)
300 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
301 Now EMACS_INT, not int. All uses changed.
302 (Fgarbage_collect): Compute overall total using a double, so that
303 integer overflow is less likely to be a problem. Check for overflow
304 when converting back to an integer.
5a25e253
PE
305 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
306 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
307 These were 'int' variables that could overflow on 64-bit hosts;
308 they were never used, so remove them instead of repairing them.
211a0b2a 309 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
310 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
311 Previously, this ceilinged at INT_MAX, but that doesn't work on
312 64-bit machines.
e46bb31a 313 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 314
c78baabf 315 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 316 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
317 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
318 when a (possibly-narrower) signed value would do just as well.
319 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 320
c9d624c6
PE
321 * alloc.c: Catch some string size overflows that we were missing.
322 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
323 for convenience in STRING_BYTES_MAX.
324 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
325 The definition here is exact; the one in lisp.h was approximate.
326 (allocate_string_data): Check for string overflow. This catches
327 some instances we weren't catching before. Also, it catches
328 size_t overflow on (unusual) hosts where SIZE_MAX <= min
329 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
330 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 331
c9d624c6
PE
332 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
333 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
334 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
335
353032ce
PE
336 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
337
2bccce07
PE
338 * alloc.c (Fmake_string): Check for out-of-range init.
339
0ac30604
SM
3402011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
341
342 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
343
c195f2de
JD
3442011-06-14 Jan Djärv <jan.h.d@swipnet.se>
345
346 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
347 xg_get_default_scrollbar_width.
348
349 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
350 (int_gtk_range_get_value): Move to the scroll bar part of the file.
351 (style_changed_cb): Call update_theme_scrollbar_width and call
352 x_set_scroll_bar_default_width and xg_frame_set_char_size for
353 all frames (Bug#8505).
354 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
355 Call gtk_window_set_resizable if HAVE_GTK3.
356 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
357 and height if HAVE_GTK3 (Bug#8505).
358 (scroll_bar_width_for_theme): New variable.
359 (update_theme_scrollbar_width): New function.
360 (xg_get_default_scrollbar_width): Move code to
361 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
362 (xg_initialize): Call update_theme_scrollbar_width.
363
364 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
365
366 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
367
e10ac9f1
MR
3682011-06-12 Martin Rudalics <rudalics@gmx.at>
369
370 * frame.c (make_frame): Call other_buffer_safely instead of
371 other_buffer.
372
373 * window.c (temp_output_buffer_show): Call display_buffer with
374 second argument Vtemp_buffer_show_specifiers and reset latter
375 immediately after the call.
376 (Vtemp_buffer_show_specifiers): New variable.
377 (auto_window_vscroll_p, next_screen_context_lines)
378 (Vscroll_preserve_screen_position): Remove leading asterisks from
379 doc-strings.
380
2d3c217e 3812011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 382
7b7f97e8 383 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
384 * buffer.c (Qclone_number): Remove for now, as it's unused.
385 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
386 (record_buffer): Remove unused local.
387 * frame.c (other_visible_frames, frame_buffer_list): Now static.
388 (set_frame_buffer_list): Remove; unused.
389 * frame.h (other_visible_frames): Remove decl.
390 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
391 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
392 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
393 if HAVE_GPM.
394 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
395 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
396 Define only if HAVE_GPM.
397 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
398 (update_hints_inhibit): Remove; never set. All uses removed.
399 * widgetprv.h (emacsFrameClassRec): Remove decl.
400 * window.c (delete_deletable_window): Now returns void, since it
401 wasn't returning anything.
402 (compare_window_configurations): Remove unused locals.
403 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
404 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
405 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
406 the same widths as pointers. This follows up on the 2011-05-06 patch.
407 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
408 * xterm.h: Likewise.
409 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
410
1384b89e
JB
4112011-06-12 Juanma Barranquero <lekktu@gmail.com>
412
413 * makefile.w32-in: Update dependencies.
414 (LISP_H): Add lib/intprops.h.
415
1100a63c
CY
4162011-06-11 Chong Yidong <cyd@stupidchicken.com>
417
418 * image.c (gif_load): Add animation frame delay to the metadata.
419 (syms_of_image): Use DEFSYM. New symbol `delay'.
420
6198ccd0
MR
4212011-06-11 Martin Rudalics <rudalics@gmx.at>
422
423 * window.c (delete_deletable_window): Re-add.
424 (Fset_window_configuration): Rewrite to handle dead buffers and
425 consequently deletable windows.
426 (window_tree, Fwindow_tree): Remove. Supply functionality in
427 window.el.
428 (compare_window_configurations): Simplify code.
429
b6e3633c
AS
4302011-06-11 Andreas Schwab <schwab@linux-m68k.org>
431
1ab0dee5
AS
432 * image.c (imagemagick_load_image): Fix type mismatch.
433 (Fimagemagick_types): Likewise.
434
b6e3633c
AS
435 * window.h (replace_buffer_in_windows): Declare.
436
9397e56f
MR
4372011-06-11 Martin Rudalics <rudalics@gmx.at>
438
439 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
440 Qclone_number. Remove external declaration of Qdelete_window.
441 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
442 code.
443 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
444 Qbuffer_list_update_hook if allowed.
445 (Fother_buffer): Rewrite doc-string. Major rewrite for new
446 buffer list implementation.
447 (other_buffer_safely): New function.
448 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
449 calls to replace_buffer_in_windows and
450 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
451 if allowed.
452 (record_buffer): Inhibit quitting and rewrite using quittable
453 functions. Run Qbuffer_list_update_hook if allowed.
454 (Frecord_buffer, Funrecord_buffer): New functions.
455 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
456 switch-to-buffer to window.el.
457 (bury-buffer): Move to window.el.
458 (Vbuffer_list_update_hook): New variable.
459
460 * lisp.h (other_buffer_safely): Add prototype in buffer.c
461 section.
462
463 * window.h (resize_frame_windows): Move up in code.
464 (Fwindow_frame): Remove EXFUN.
465 (replace_buffer_in_all_windows): Remove prototype.
466 (replace_buffer_in_windows_safely): Add prototype.
467
468 * window.c: Declare Qdelete_window static again. Move down
469 declaration of select_count.
470 (Fnext_window, Fprevious_window): Rewrite doc-strings.
471 (Fother_window): Move to window.el.
472 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
473 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
474 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
475 window.el.
476 (replace_buffer_in_windows): Implement by calling
477 Qreplace_buffer_in_windows.
478 (replace_buffer_in_all_windows): Remove with some functionality
479 moved into replace_buffer_in_windows_safely.
480 (replace_buffer_in_windows_safely): New function.
481 (select_window_norecord, select_frame_norecord): Move in front
482 of run_window_configuration_change_hook. Remove now obsolete
483 declarations.
484 (Fset_window_buffer): Rewrite doc-string. Call
485 Qrecord_window_buffer.
486 (keys_of_window): Move binding for other-window to window.el.
487
b50691aa
CY
4882011-06-11 Chong Yidong <cyd@stupidchicken.com>
489
490 * dispextern.h (struct image): Replace data member, whose int_val
491 and ptr_val fields were not used by anything, with a single
492 lisp_val object.
493
494 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
495 (gif_clear_image, gif_load, imagemagick_load_image)
496 (gs_clear_image, gs_load): Callers changed.
497
3f754b86
PE
4982011-06-10 Paul Eggert <eggert@cs.ucla.edu>
499
cca69397
PE
500 * buffer.h: Include <time.h>, for time_t.
501 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
502
109e28d0
PE
503 Fix minor problems found by static checking.
504
60737f02
PE
505 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
506
4b66faf3
PE
507 Make identifiers static if they are not used in other modules.
508 * data.c (Qcompiled_function, Qframe, Qvector):
509 * image.c (QimageMagick, Qsvg):
510 * minibuf.c (Qmetadata):
511 * window.c (resize_window_check, resize_root_window): Now static.
512 * window.h (resize_window_check, resize_root_window): Remove decls.
513
109e28d0
PE
514 * window.c (window_deletion_count, delete_deletable_window):
515 Remove; unused.
46a4ce9e
PE
516 (window_body_lines): Now static.
517 (Fdelete_other_windows_internal): Mark vars as initialized.
518 Make sure 'resize_failed' is initialized.
519 (run_window_configuration_change_hook): Rename local to avoid shadowing.
520 (resize_window_apply): Remove unused local.
521 * window.h (delete_deletable_window): Remove decl.
522
109e28d0 523 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
524 (imagemagick_load_image): Fix pointer signedness problem by changing
525 last arg from unsigned char * to char *. All uses changed.
526 Also, fix a local for similar reasons.
527 Remove unused locals. Remove locals to avoid shadowing.
528 (fn_rsvg_handle_free): Remove; unused.
529 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 530 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 531
3f754b86
PE
532 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
533
2547adb1
CY
5342011-06-10 Chong Yidong <cyd@stupidchicken.com>
535
536 * image.c (gif_load): Fix omitted cast error introduced by
537 2011-06-06 change.
538
2c8e37d4
MR
5392011-06-10 Martin Rudalics <rudalics@gmx.at>
540
541 * window.h (resize_proportionally, orig_total_lines)
542 (orig_top_line): Remove from window structure.
543 (set_window_height, set_window_width, change_window_heights)
544 (Fdelete_window): Remove prototypes.
545 (resize_frame_windows): Remove duplicate declaration.
546
440a42e3
EZ
5472011-06-10 Eli Zaretskii <eliz@gnu.org>
548
549 * window.h (resize_frame_windows, resize_window_check)
550 (delete_deletable_window, resize_root_window)
551 (resize_frame_windows): Declare prototypes.
552
553 * window.c (resize_window_apply): Make definition be "static" to
554 match the prototype.
555
562dd5e9
MR
5562011-06-10 Martin Rudalics <rudalics@gmx.at>
557
558 * window.c: Remove declarations of Qwindow_size_fixed,
559 window_min_size_1, window_min_size_2, window_min_size,
560 size_window, window_fixed_size_p, enlarge_window, delete_window.
561 Remove static from declaration of Qdelete_window, it's
562 temporarily needed by Fbury_buffer.
563 (replace_window): Don't assign orig_top_line and
564 orig_total_lines.
565 (Fdelete_window, delete_window): Remove. Window deletion is
566 handled by window.el.
567 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
568 Fdelete_window calls with calls to Qdelete_window.
569 (Fdelete_other_windows): Remove. Deleting other windows is
570 handled by window.el.
571 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
572 handled in window.el.
573 (window_min_size_2, window_min_size_1, window_min_size): Remove.
574 Window minimum sizes are handled in window.el.
575 (shrink_windows, size_window, set_window_height)
576 (set_window_width, change_window_heights, window_height)
577 (window_width, CURBEG, CURSIZE, enlarge_window)
578 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
579 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
580 handled in window.el.
581 (make_dummy_parent): Rename to make_parent_window and give it a
582 second argument horflag.
583 (make_window): Don't set resize_proportionally any more.
584 (Fsplit_window): Remove. Windows are split in window.el.
585 (save_restore_action, save_restore_orig_size)
586 (shrink_window_lowest_first, save_restore_orig_size): Remove.
587 Resize mini windows in window.el.
588 (grow_mini_window, shrink_mini_window): Implement by calling
589 Qresize_root_window_vertically, resize_window_check and
590 resize_window_apply.
591 (saved_window, Fset_window_configuration, save_window_save): Do
592 not handle orig_top_line, orig_total_lines, and
593 resize_proportionally.
594 (window_min_height, window_min_width): Move to window.el.
595 (keys_of_window): Move bindings for delete-other-windows,
596 split-window, delete-window and enlarge-window to window.el.
597
598 * buffer.c: Temporarily extern Qdelete_window.
599 (Fbury_buffer): Temporarily call Qdelete_window instead of
600 Fdelete_window (Fbury_buffer will move to window.el soon).
601
602 * frame.c (set_menu_bar_lines_1): Remove code handling
603 orig_top_line and orig_total_lines.
604
605 * dispnew.c (adjust_frame_glyphs_initially): Don't use
606 set_window_height but set heights directly.
607 (change_frame_size_1): Use resize_frame_windows.
608
609 * xdisp.c (init_xdisp): Don't use set_window_height but set
610 heights directly.
611
612 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
613 resize_frame_windows instead of change_window_heights and run
614 run_window_configuration_change_hook.
615
616 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
617 instead of change_window_heights and run
618 run_window_configuration_change_hook.
619
1a13852e
MR
6202011-06-09 Martin Rudalics <rudalics@gmx.at>
621
622 * window.c (replace_window): Rename second argument REPLACEMENT to
623 NEW. New third argument SETFLAG. Rewrite.
624 (delete_window, make_dummy_parent): Call replace_window with
625 third argument 1.
626 (window_list_1): Move down in code.
627 (run_window_configuration_change_hook): Move set_buffer part
628 before select_frame_norecord part in order to unwind correctly.
629 Rename count1 to count.
630 (recombine_windows, delete_deletable_window, resize_root_window)
631 (Fdelete_other_windows_internal)
632 (Frun_window_configuration_change_hook, make_parent_window)
633 (resize_window_check, resize_window_apply, Fresize_window_apply)
634 (resize_frame_windows, Fsplit_window_internal)
635 (Fdelete_window_internal, Fresize_mini_window_internal): New
636 functions.
637 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
638
f3d1777e
MR
6392011-06-08 Martin Rudalics <rudalics@gmx.at>
640
496e208e
MR
641 * window.h (window): Add some new members to window structure -
642 normal_lines, normal_cols, new_total, new_normal, clone_number,
643 splits, nest, prev_buffers, next_buffers.
644 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 645 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 646
f3d1777e
MR
647 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
648 Remove.
496e208e
MR
649 (make_dummy_parent): Set new members of windows structure.
650 (make_window): Move down in code. Handle new members of window
651 structure.
652 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
653 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
654 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
655 (Fset_window_prev_buffers, Fwindow_next_buffers)
656 (Fset_window_next_buffers, Fset_window_clone_number): New
657 functions.
658 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
659 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
660 Doc-string fixes.
661 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
662 Argument WINDOW can be now internal window too.
663 (Fwindow_use_time): Move up in code.
664 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
665 Rewrite doc-string.
666 (Fset_window_configuration, saved_window)
667 (Fcurrent_window_configuration, save_window_save): Handle new
668 members of window structure.
b9e809c2
MR
669 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
670 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
671 (syms_of_window): New Lisp objects Qrecord_window_buffer,
672 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
673 Qget_mru_window, Qresize_root_window,
674 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
675 Qauto_buffer_name; staticpro them.
f3d1777e 676
abde8f8c
MR
6772011-06-07 Martin Rudalics <rudalics@gmx.at>
678
679 * window.c (Fwindow_total_size, Fwindow_left_column)
680 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
681 (Fwindow_list_1): New functions.
682 (window_box_text_cols): Replace with window_body_cols.
683 (Fwindow_width, Fscroll_left, Fscroll_right): Use
684 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
685 (delete_window, Fset_window_configuration): Call
686 delete_all_subwindows with window as argument.
687 (delete_all_subwindows): Take a window as argument and not a
688 structure. Rewrite.
190b47e6
MR
689 (window_loop): Remove handling of GET_LRU_WINDOW and
690 GET_LARGEST_WINDOW.
691 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
692
693 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
694 window_box_text_cols. delete_all_subwindows now takes a
695 Lisp_Object as argument.
abde8f8c
MR
696
697 * indent.c (compute_motion, Fcompute_motion): Use
698 window_body_cols instead of window_box_text_cols.
699
fa8a67e6
MR
700 * frame.c (delete_frame): Call delete_all_subwindows with root
701 window as argument.
702
a54e3482
DC
7032011-06-07 Daniel Colascione <dan.colascione@gmail.com>
704
705 * fns.c (Fputhash): Document return value.
706
60002bf5
CY
7072011-06-06 Chong Yidong <cyd@stupidchicken.com>
708
709 * image.c (gif_load): Implement gif89a spec "no disposal" method.
710
0c671da6 7112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 712
b862a52a 713 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 714
be44ca6c
PE
715 Check for overflow when converting integer to cons and back.
716 * charset.c (Fdefine_charset_internal, Fdecode_char):
717 Use cons_to_unsigned to catch overflow.
718 (Fencode_char): Use INTEGER_TO_CONS.
719 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
720 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
721 * data.c (long_to_cons, cons_to_long): Remove.
722 (cons_to_unsigned, cons_to_signed): New functions.
723 These signal an error for invalid or out-of-range values.
724 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
725 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
726 * font.c (Ffont_variation_glyphs):
727 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
728 * lisp.h: Include <intprops.h>.
729 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
730 (cons_to_signed, cons_to_unsigned): New decls.
731 (long_to_cons, cons_to_long): Remove decls.
732 * undo.c (record_first_change): Use INTEGER_TO_CONS.
733 (Fprimitive_undo): Use CONS_TO_INTEGER.
734 * xfns.c (Fx_window_property): Likewise.
735 * xselect.c: Include <limits.h>.
736 (x_own_selection, selection_data_to_lisp_data):
737 Use INTEGER_TO_CONS.
738 (x_handle_selection_request, x_handle_selection_clear)
739 (x_get_foreign_selection, Fx_disown_selection_internal)
740 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
741 (lisp_data_to_selection_data): Use cons_to_unsigned.
742 (x_fill_property_data): Use cons_to_signed.
743 Report values out of range.
744
d1f3d2af
PE
745 Check for buffer and string overflow more precisely.
746 * buffer.h (BUF_BYTES_MAX): New macro.
747 * lisp.h (STRING_BYTES_MAX): New macro.
748 * alloc.c (Fmake_string):
749 * character.c (string_escape_byte8):
750 * coding.c (coding_alloc_by_realloc):
751 * doprnt.c (doprnt):
752 * editfns.c (Fformat):
753 * eval.c (verror):
754 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
755 since they may not be the same number.
756 * editfns.c (Finsert_char):
757 * fileio.c (Finsert_file_contents):
758 Likewise for BUF_BYTES_MAX.
759
dd52fcea
PE
760 * image.c: Use ptrdiff_t, not int, for sizes.
761 (slurp_file): Switch from int to ptrdiff_t.
762 All uses changed.
763 (slurp_file): Check that file size fits in both size_t (for
764 malloc) and ptrdiff_t (for sanity and safety).
765
7f9bbdbb
PE
766 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
767 if b->modtime has its maximal value.
768
dfe18f82
PE
769 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
770
84acfcf0
PE
771 Don't assume time_t can fit into int.
772 * buffer.h (struct buffer.modtime): Now time_t, not int.
773 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
774 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
775
ccd9a01a
PE
776 Minor fixes for signed vs unsigned integers.
777 * character.h (MAYBE_UNIFY_CHAR):
778 * charset.c (maybe_unify_char):
779 * keyboard.c (read_char, reorder_modifiers):
780 XINT -> XFASTINT, since the integer must be nonnegative.
781 * ftfont.c (ftfont_spec_pattern):
782 * keymap.c (access_keymap, silly_event_symbol_error):
783 XUINT -> XFASTINT, since the integer must be nonnegative.
784 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
785 since it makes no difference and we prefer signed.
786 * keyboard.c (record_char): Use XUINT when all the neighbors do.
787 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
788 nonnegative.
789
d6d100dd
SM
7902011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
791
792 * window.h (Fwindow_frame): Declare.
793
2b6148e4
PE
7942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
795
796 * alloc.c: Simplify handling of large-request failures (Bug#8800).
797 (SPARE_MEMORY): Always define.
798 (LARGE_REQUEST): Remove.
799 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
800
f230ecc9
MR
8012011-06-06 Martin Rudalics <rudalics@gmx.at>
802
727e958e
MR
803 * lisp.h: Move EXFUNS for Fframe_root_window,
804 Fframe_first_window and Fset_frame_selected_window to window.h.
805
806 * window.h: Move EXFUNS for Fframe_root_window,
807 Fframe_first_window and Fset_frame_selected_window here from
808 lisp.h.
809
810 * frame.c (Fwindow_frame, Fframe_first_window)
811 (Fframe_root_window, Fframe_selected_window)
812 (Fset_frame_selected_window): Move to window.c.
813 (Factive_minibuffer_window): Move to minibuf.c.
814 (Fother_visible_frames_p): New function.
815
816 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
817
f230ecc9
MR
818 * window.c (decode_window, decode_any_window): Move up in code.
819 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
820 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
821 (Fwindow_buffer): Move up and rewrite doc-string.
822 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
823 (Fwindow_prev): New functions.
727e958e
MR
824 (Fwindow_frame): Move here from frame.c. Accept any window as
825 argument.
826 (Fframe_root_window, Fframe_first_window)
827 (Fframe_selected_window): Move here from frame.c. Accept frame
828 or arbitrary window as argument. Update doc-strings.
829 (Fminibuffer_window): Move up in code.
830 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
831 (Fset_frame_selected_window): Move here from frame.c.
832 Marginal rewrite.
727e958e
MR
833 (Fselected_window, select_window, Fselect_window): Move up in
834 code. Minor doc-string fixes.
f230ecc9 835
4d09bcf6
PE
8362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
837
838 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
839 Do not assume that spare memory exists; that assumption is valid
840 only if SYSTEM_MALLOC.
841 (LARGE_REQUEST): New macro, so that the issue of large requests
842 is separated from the issue of spare memory.
843
810928a2
AS
8442011-06-05 Andreas Schwab <schwab@linux-m68k.org>
845
172418ad
AS
846 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
847 format. (Bug#8806)
848
43f862f7
AS
849 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
850
810928a2
AS
851 * xfns.c (x_set_scroll_bar_default_width): Move declarations
852 before statements.
853
a059fe24
JD
8542011-06-05 Jan Djärv <jan.h.d@swipnet.se>
855
856 * gtkutil.c (xg_get_default_scrollbar_width): New function.
857
858 * gtkutil.h: Declare xg_get_default_scrollbar_width.
859
860 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
861 min width by calling x_set_scroll_bar_default_width (Bug#8505).
862
989bf368
JB
8632011-06-05 Juanma Barranquero <lekktu@gmail.com>
864
865 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
866
4b80f674
CY
8672011-06-04 Chong Yidong <cyd@stupidchicken.com>
868
869 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
870 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
871 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
872 New error handlers.
4b80f674
CY
873 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
874 Obey Vx_select_enable_clipboard_manager. Catch errors in
875 x_clipboard_manager_save (Bug#8779).
876 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 877 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 878
99a33b77 8792011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
880
881 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
882
99a33b77 8832011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
884
885 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
886 in the current matrix if keep_current_p is non-zero.
887
8264569d
EZ
8882011-06-04 Eli Zaretskii <eliz@gnu.org>
889
890 * bidi.c (bidi_level_of_next_char): Fix last change.
891
57f97249
EZ
8922011-06-03 Eli Zaretskii <eliz@gnu.org>
893
fec2107c 894 Support bidi reordering of text covered by display properties.
57f97249 895
fec2107c
EZ
896 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
897 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
898 (bidi_cache_search, bidi_cache_iterator_state)
899 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
900 (bidi_level_of_next_char, bidi_move_to_visually_next):
901 Support character positions inside a run of characters covered by a
fec2107c
EZ
902 display string.
903 (bidi_paragraph_init, bidi_resolve_explicit_1)
904 (bidi_level_of_next_char): Call bidi_fetch_char and
905 bidi_fetch_char_advance instead of FETCH_CHAR and
906 FETCH_CHAR_ADVANCE.
907 (bidi_init_it): Initialize new members.
908 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
909 definitions.
910 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
911 instead of using explicit *_CHAR codes.
d6d100dd
SM
912 (bidi_resolve_explicit, bidi_resolve_weak):
913 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
914 bidirectional text is supported only in multibyte buffers.
915 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
916 it to initialize the frame_window_p member of struct bidi_it.
917 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
918 (bidi_resolve_explicit, bidi_resolve_weak)
919 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
920 bidi_it->nchars is non-positive.
921 (bidi_level_of_next_char): Don't try to lookup the cache for the
922 next/previous character if nothing is cached there yet, or if we
923 were just reseat()'ed to a new position.
c40e2fb2 924
0e14fe90
EZ
925 * xdisp.c (set_cursor_from_row): Set start and stop points
926 according to the row's direction when priming the loop that looks
927 for the glyph on which to display cursor.
928 (single_display_spec_intangible_p): Function deleted.
929 (display_prop_intangible_p): Reimplement to call
930 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
931 Accept 3 additional arguments needed by handle_display_spec.
932 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
933 values: lists, `(when COND...)' forms, etc.
934 (single_display_spec_string_p): Support property values that are
935 lists with the argument STRING its top-level element.
936 (display_prop_string_p): Fix the condition for processing a
937 property that is a list to be consistent with handle_display_spec.
fec2107c 938 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
939 last portion of handle_display_prop.
940 (compute_display_string_pos): Accept additional argument
941 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
942 value of a `display' property is a "replacing spec".
943 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
944 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
945 the display property, but just return a value indicating whether
946 the display property will replace the characters it covers.
947 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
948 frame_window_p members of struct bidi_it.
d6d100dd
SM
949 (compute_display_string_pos, compute_display_string_end):
950 New functions.
fec2107c
EZ
951 (push_it): Accept second argument POSITION, where pop_it should
952 jump to continue iteration.
953 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 954
fec2107c
EZ
955 * keyboard.c (adjust_point_for_property): Adjust the call to
956 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
957
958 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
959 (bidi_init_it): Update prototypes.
960 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
961 (compute_display_string_pos, compute_display_string_end):
962 Declare prototypes.
fec2107c
EZ
963 (struct bidi_it): New members nchars and disp_pos. ch_len is now
964 EMACS_INT.
fc6f18ce 965
40087514 9662011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 967
57f53182
PE
968 Malloc failure behavior now depends on size of allocation.
969 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
970 * lisp.h: Change signatures accordingly.
971 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
972 All callers changed. (Bug#8762)
973
974 * gnutls.c: Use Emacs's memory allocators.
975 Without this change, the gnutls library would invoke malloc etc.
976 directly, which causes problems on non-SYNC_INPUT hosts, and which
977 runs afoul of improving memory_full behavior. (Bug#8761)
978 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
979 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
980 xfree instead of the default malloc, realloc, free.
981 (Fgnutls_boot): No need to check for memory allocation failure,
982 since xmalloc does that for us.
983
ac32cd99 984 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
985 * category.c (hash_get_category_set):
986 * ccl.c (ccl_driver):
987 * charset.c (Fdefine_charset_internal):
988 * charset.h (struct charset.hash_index):
989 * composite.c (get_composition_id, gstring_lookup_cache)
990 (composition_gstring_put_cache):
991 * composite.h (struct composition.hash_index):
992 * dispextern.h (struct image.hash):
993 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
994 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
995 (hashfn_equal, hashfn_user_defined, make_hash_table)
996 (maybe_resize_hash_table, hash_lookup, hash_put)
997 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
998 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
999 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1000 * image.c (make_image, search_image_cache, lookup_image)
1001 (xpm_put_color_table_h):
1002 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1003 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1004 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1005 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1006 * alloc.c (allocate_vectorlike):
1007 Check for overflow in vector size calculations.
1008 * ccl.c (ccl_driver):
1009 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1010 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1011 need to be updated by these changes.
40087514
PE
1012 * fns.c (make_hash_table, maybe_resize_hash_table):
1013 Check for integer overflow with large hash tables.
0de4bb68
PE
1014 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1015 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1016 (SXHASH_REDUCE): New macro.
1017 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1018 Use it instead of discarding useful hash info with large hash values.
1019 (sxhash_float): New function.
1020 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1021 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1022 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1023 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1024 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1025 Adjust signatures to match updated version of code.
1026 (consing_since_gc): Now EMACS_INT, since a single hash table can
1027 use more than INT_MAX bytes.
1028
698d32e2
DN
10292011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1030
1031 Make it possible to build with GCC-4.6+ -O2 -flto.
1032
1033 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1034
fd6fa53f
SM
10352011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1036
1037 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1038 Call minibuffer-inactive-mode.
1039
864db017
JB
10402011-05-31 Juanma Barranquero <lekktu@gmail.com>
1041
1042 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1043 Update dependencies.
1044
2ad0baf4
DN
10452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1046
1047 * data.c (init_data): Remove code for UTS, this system is not
1048 supported anymore.
1049
4fcc2638
DN
10502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1051
1052 Don't force ./temacs to start in terminal mode.
1053
1054 * frame.c (make_initial_frame): Initialize faces in all cases, not
1055 only when CANNOT_DUMP is defined.
1056 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1057
c56e0fd5
DN
10582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1059
1060 * dispnew.c (add_window_display_history): Use const for the string
1061 pointer. Remove declaration, not needed.
1062
333d54da 10632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1064
55d4c1b2 1065 Use 'inline', not 'INLINE'.
333d54da 1066 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1067 * alloc.c, fontset.c (INLINE): Remove.
1068 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1069 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1070 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1071 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1072 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1073
738db178
DN
10742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1075
1076 Make it possible to run ./temacs.
1077
1078 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1079 syms_of_callproc does the same thing. Remove test for
1080 "initialized", do it in the caller.
1081 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1082
620c53a6
SM
10832011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1084
1085 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1086 (read_minibuf): Use get_minibuffer.
1087 (syms_of_minibuf): Use DEFSYM.
1088 (Qmetadata): New var.
1089 * data.c (Qbuffer): Don't make it static.
1090 (syms_of_data): Use DEFSYM.
1091
e003a292
PE
10922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1093
1094 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1095 (CCL_CODE_MIN): New macro.
1096
ed008a6d
PE
10972011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1098
3687c2ef
PE
1099 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1100
ed008a6d
PE
1101 * eval.c (Qdebug): Now static.
1102 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1103 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1104 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1105
d66c4c7c
CY
11062011-05-29 Chong Yidong <cyd@stupidchicken.com>
1107
1108 * image.c: Various fixes to ImageMagick code comments.
1109 (Fimagemagick_types): Doc fix.
1110
5fbc2025
PE
11112011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1112
0196f88a
PE
1113 Minor fixes prompted by GCC 4.6.0 warnings.
1114
1115 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1116
5fbc2025
PE
1117 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1118 (x_clipboard_manager_save_all): Move extern decl to ...
1119 * xterm.h: ... here, so that it can be checked for consistency.
1120
1dd3c2d9
CY
11212011-05-29 Chong Yidong <cyd@stupidchicken.com>
1122
1123 * xselect.c (x_clipboard_manager_save_frame)
1124 (x_clipboard_manager_save_all): New functions.
1125 (Fx_clipboard_manager_save): Lisp function deleted.
1126
1127 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1128 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1129
1130 * xterm.h: Update prototype.
1131
5ba6571d
WX
11322011-05-28 William Xu <william.xwl@gmail.com>
1133
1134 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1135 exiting (Bug#8239).
1136
3eaff834
JM
11372011-05-28 Jim Meyering <meyering@redhat.com>
1138
e1900994 1139 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1140 * fns.c (to_uchar): Define.
1141 (crypto_hash_function): Use it to convert some newly-signed
1142 variables to unsigned, to avoid sign-extension bugs. For example,
1143 without this change, (md5 "truc") would evaluate to
1144 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1145 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1146 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1147
0f6990a7
PE
11482011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1149
1150 Integer overflow fixes.
c8a9ca5a 1151
08686060
PE
1152 * dbusbind.c: Serial number integer overflow fixes.
1153 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1154 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1155 to hold a serial number that is too large for a fixnum.
1156 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1157 Check for serial numbers out of range. Decode any serial number
59568bf0 1158 that was so large that it became a float. (Bug#8722)
08686060 1159
2d1fc3c7
PE
1160 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1161 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1162 Use XFASTINT rather than XUINT when numbers are nonnegative.
1163 (xd_append_arg, Fdbus_method_return_internal):
1164 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1165 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1166 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1167 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1168 (Bug#8722)
2d1fc3c7 1169
c8a9ca5a
PE
1170 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1171
519e1d69
PE
1172 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1173
30569699
PE
1174 ccl: add integer overflow checks
1175 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1176 (IN_INT_RANGE): New macros.
1177 (ccl_driver): Use them to check for integer overflow when
1178 decoding a CCL program. Many of the new checks are whether XINT (x)
1179 fits in int; it doesn't always, on 64-bit hosts. The new version
1180 doesn't catch all possible integer overflows, but it's an
847044ea 1181 improvement. (Bug#8719)
30569699 1182
c11285dc
PE
1183 * alloc.c (make_event_array): Use XINT, not XUINT.
1184 There's no need for unsigned here.
1185
fdccd48e
PE
1186 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1187 This follows up to the 2011-05-06 change that substituted uintptr_t
1188 for EMACS_INT. This case wasn't caught back then.
1189
37910ab2
PE
1190 Rework Fformat to avoid integer overflow issues.
1191 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1192 now (part of C89). Include <verify.h>.
1193 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1194 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1195 (Fformat): Avoid the prepass trying to compute sizes; it was only
1196 approximate and thus did not catch overflow reliably. Instead, walk
1197 through the format just once, formatting and computing sizes as we go,
1198 checking for integer overflow at every step, and allocating a larger
1199 buffer as needed. Keep track separately whether the format is
1200 multibyte. Keep only the most-recently calculated precision, rather
1201 than them all. Record whether each argument has been converted to
1202 string. Use EMACS_INT, not int, for byte and char and arg counts.
1203 Support field widths and precisions larger than INT_MAX. Avoid
1204 sprintf's undefined behavior with conversion specifications such as %#d
1205 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1206 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1207 formatting out-of-range floating point numbers with int
1208 formats. (Bug#8668)
1209
2e6578fb
PE
1210 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1211
0ae6bdee
PE
1212 * data.c: Avoid integer truncation in expressions involving floats.
1213 * data.c: Include <intprops.h>.
1214 (arith_driver): When there's an integer overflow in an expression
1215 involving floating point, convert the integers to floating point
1216 so that the resulting value does not suffer from catastrophic
1217 integer truncation. For example, on a 64-bit host (* 4
1218 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1219 Do not rely on undefined behavior after integer overflow.
1220
de883a70
PE
1221 merge count_size_as_multibyte, parse_str_to_multibyte
1222 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1223 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1224 Check for integer overflow.
1225 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1226 since it's now a duplicate of the other. This is more of
1227 a character than a buffer op, so better that it's in character.c.
1228 * fns.c, print.c: Adjust to above changes.
1229
2ff916cb
PE
12302011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1231
1232 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1233
f1b54466
PE
12342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1235
fb1ac845
PE
1236 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1237 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1238 (x_clipboard_manager_save): Now static.
1239 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1240
f1b54466
PE
1241 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1242 (crypto_hash_function): Now static.
1243 Fix pointer signedness problems. Avoid unnecessary initializations.
1244
a9f737ee
CY
12452011-05-27 Chong Yidong <cyd@stupidchicken.com>
1246
1247 * termhooks.h (Vselection_alist): Make it terminal-local.
1248
1249 * terminal.c (create_terminal): Initialize it.
1250
1251 * xselect.c: Support for clipboard managers.
1252 (Vselection_alist): Move to termhooks.h as terminal-local var.
1253 (LOCAL_SELECTION): New macro.
1254 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1255 (symbol_to_x_atom): Remove gratuitous arg.
1256 (x_handle_selection_request, lisp_data_to_selection_data)
1257 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1258 (x_own_selection, x_get_local_selection, x_convert_selection):
1259 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1260 (some_frame_on_display): Delete unused function.
1261 (Fx_own_selection_internal, Fx_get_selection_internal)
1262 (Fx_disown_selection_internal, Fx_selection_owner_p)
1263 (Fx_selection_exists_p): New optional frame arg.
1264 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1265 (x_handle_selection_clear): Don't treat other terminals with the
1266 same keyboard specially. Use the terminal-local Vselection_alist.
1267 (x_clear_frame_selections): Use Frun_hook_with_args.
1268
1269 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1270
1271 * xterm.h: Add support for those atoms.
1272
e067f0c1
CY
12732011-05-26 Chong Yidong <cyd@stupidchicken.com>
1274
1275 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1276 (converted_selections, conversion_fail_tag): New global variables.
1277 (x_selection_request_lisp_error): Free the above.
1278 (x_get_local_selection): Remove unnecessary code.
1279 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1280 of converted selections stored in converted_selections.
1281 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1282 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1283 (x_convert_selection): New function.
1284 (x_handle_selection_event): Simplify.
1285 (x_get_foreign_selection): Don't ignore incoming requests while
1286 waiting for an answer; this will fail when we implement
1287 SAVE_TARGETS, and seems unnecessary anyway.
1288 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1289 (Vx_sent_selection_functions): Doc fix.
1290
0f4aebc0
LL
12912011-05-26 Leo Liu <sdl.web@gmail.com>
1292
1293 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1294
e61124cd
YM
12952011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1296
1297 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1298
1299 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1300 for fringe update if it has periodic bitmap.
1301 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1302 and fringe_bitmap_periodic_p.
1303
1304 * fringe.c (get_fringe_bitmap_data): New function.
1305 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1306 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1307 row. Mark glyph row for fringe update if periodicity changed.
1308
1309 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1310 for fringe update unless it has periodic bitmap.
1311
f16d9837
KH
13122011-05-25 Kenichi Handa <handa@m17n.org>
1313
1314 * xdisp.c (get_next_display_element): Set correct it->face_id for
1315 a static composition.
1316
e1b90ef6
LL
13172011-05-24 Leo Liu <sdl.web@gmail.com>
1318
1319 * deps.mk (fns.o):
1320 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1321
1322 * fns.c (crypto_hash_function, Fsha1): New function.
1323 (Fmd5): Use crypto_hash_function.
1324 (syms_of_fns): Add Ssha1.
1325
7400048f
PE
13262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1327
1328 * gnutls.c: Remove unused macros.
1329 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1330 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1331 Remove macros that are defined and never used.
1332 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1333
abb71cf4
CY
13342011-05-22 Chong Yidong <cyd@stupidchicken.com>
1335
1336 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1337 (Fx_get_selection_internal): Minor cleanup.
1338 (Fx_own_selection_internal): Rename arguments for consistency with
1339 select.el.
1340
6307db39
PE
13412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1342
1343 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1344
f3d4e0a4
CY
13452011-05-22 Chong Yidong <cyd@stupidchicken.com>
1346
1347 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1348
4d8ade89
YM
13492011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1350
1351 * dispnew.c (scrolling_window): Don't exclude the case that the
1352 last enabled row in the desired matrix touches the bottom boundary.
1353
32078c8d
GM
13542011-05-21 Glenn Morris <rgm@gnu.org>
1355
1356 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1357 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1358 and add some more files.
32078c8d 1359
7285dc67
EZ
13602011-05-20 Eli Zaretskii <eliz@gnu.org>
1361
1362 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1363 report_file_error introduced by the change from 2011-05-07.
1364
89d1bd22
PE
13652011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1366
1367 * systime.h (Time): Define only if emacs is defined.
1368 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1369 where the include path doesn't have X11/X.h by default. See
1370 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1371
e23640bb 13722011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1373
1374 * composite.c (find_automatic_composition): Fix previous change.
1375
b9704ad9
GM
13762011-05-20 Glenn Morris <rgm@gnu.org>
1377
1378 * lisp.mk: New file, split from Makefile.in.
1379 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1380 (shortlisp): Remove.
1381 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1382
4a720484
GM
13832011-05-19 Glenn Morris <rgm@gnu.org>
1384
1385 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1386 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1387 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1388 (lisp): Set the order to that of loadup.el.
1389 (shortlisp): Make it a copy of $lisp.
1390 (SOME_MACHINE_LISP): Remove.
1391 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1392 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1393
a28d4396
KH
13942011-05-18 Kenichi Handa <handa@m17n.org>
1395
1396 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1397 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1398 (find_automatic_composition): Mostly rewrite for efficiency.
1399
a2b1fa8e
JB
14002011-05-18 Juanma Barranquero <lekktu@gmail.com>
1401
1402 * makefile.w32-in: Update dependencies.
1403
8e1f5610
CS
14042011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1405
1406 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1407 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1408
7025ee00 14092011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1410
cdfa6eab
PE
1411 Fix some integer overflow issues, such as string length overflow.
1412
06d6db33
PE
1413 * insdel.c (count_size_as_multibyte): Check for string overflow.
1414
2b4560a8
PE
1415 * character.c (lisp_string_width): Check for string overflow.
1416 Use EMACS_INT, not int, for string indexes and lengths; in
1417 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1418 the resulting string length overflows an EMACS_INT; instead,
1419 report a string overflow if no precision given. When checking for
1420 precision exhaustion, use a check that cannot possibly have
1421 integer overflow. (Bug#8675)
1422 * character.h (lisp_string_width): Adjust to new signature.
1423
cb93f9be
PE
1424 * alloc.c (string_overflow): New function.
1425 (Fmake_string): Use it. This doesn't change behavior, but saves
1426 a few bytes and will simplify future changes.
1427 * character.c (string_escape_byte8): Likewise.
1428 * lisp.h (string_overflow): New decl.
1429
1a1f3366
PE
1430 Fixups, following up to the user-interface timestamp change.
1431 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1432 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1433 * msdos.c (mouse_get_pos): Likewise.
1434 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1435 * w32gui.h (Time): Define by including "systime.h" rather than by
1436 declaring it ourselves. (Bug#8664)
1437
d4e3e4d3
PE
1438 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1439 * image.c (clear_image_cache): Likewise.
1440
f6a24d19
PE
1441 * term.c (term_mouse_position): Don't assume time_t wraparound.
1442
08dc5ae6
PE
1443 Be more systematic about user-interface timestamps.
1444 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1445 and sometimes 'EMACS_UINT', to represent these timestamps.
1446 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1447 This makes the code easier to follow, and makes it easier to catch
1448 integer overflow bugs such as Bug#8664.
1449 * frame.c (Fmouse_position, Fmouse_pixel_position):
1450 Use Time, not unsigned long, for user-interface timestamps.
1451 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1452 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1453 * keyboard.h (last_event_timestamp): Likewise.
1454 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1455 * menu.h (xmenu_show): Likewise.
1456 * term.c (term_mouse_position): Likewise.
1457 * termhooks.h (struct input_event.timestamp): Likewise.
1458 (struct terminal.mouse_position_hook): Likewise.
1459 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1460 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1461 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1462 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1463 what it was before.
1464 * menu.h, termhooks.h: Include "systime.h", for Time.
1465
8e55734a
PE
1466 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1467 Don't assume that the difference between two unsigned long values
1468 can fit into an integer. At this point, we know button_down_time
1469 <= event->timestamp, so the difference must be nonnegative, so
1470 there's no need to cast the result if double-click-time is
1471 nonnegative, as it should be; check that it's nonnegative, just in
1472 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1473 apart (about 25 days). (Bug#8664)
8e55734a 1474
841f1b75 1475 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1476 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1477
3e26f69c
PE
1478 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1479 that always fit in int. Use a sentinel instead of a counter, to
1480 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1481 * frame.h (struct frame): Use int for menu_bar_items_used
1482 instead of EMACS_INT, since it always fits in int.
3e26f69c 1483
5cc152c0
PE
1484 * menu.c (grow_menu_items): Check for int overflow.
1485
d89eb65e
PE
1486 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1487
5235bd3e
PE
1488 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1489 Before, the code was not consistent. These values cannot exceed
1490 2**31 - 1 so there's no need to make them unsigned.
1491 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1492 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1493 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1494 as modifiers.
1495 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1496
bc827e23
PE
1497 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1498 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1499 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1500 presumably because the widths might not match.
1501
78eb494e
PE
1502 * window.c (size_window): Avoid needless test at loop start.
1503
04f2d78b
CB
15042011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1505
1506 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1507
d2fc7e3d 15082011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1509
1510 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1511
d2fc7e3d 15122011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1513
1514 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1515 `width' to `bar_area_x' and `bar_area_width', respectively.
1516 (x_scroll_run): Take account of fringe background extension.
1517
04f2d78b
CB
1518 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1519 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1520 `bar_area_width', respectively.
1521 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1522 background extension.
1523
79b70037
GM
15242011-05-10 Jim Meyering <meyering@redhat.com>
1525
1526 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1527
2f142cc5
JB
15282011-05-10 Juanma Barranquero <lekktu@gmail.com>
1529
1530 * image.c (Finit_image_library): Return t for built-in image types,
1531 like pbm and xbm. (Bug#8640)
1532
57679c86
AS
15332011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1534
1535 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1536
888c9e86
EZ
15372011-05-07 Eli Zaretskii <eliz@gnu.org>
1538
b0512a1d
EZ
1539 * w32console.c (Fset_screen_color): Doc fix.
1540 (Fget_screen_color): New function.
1541 (syms_of_ntterm): Defsubr it.
1542
7285dc67
EZ
1543 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1544 unlink the temporary file if Fcall_process didn't create it in the
1545 first place.
1546 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1547 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1548 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1549 cue to call_process_cleanup not to close that handle.
1550
4d3fcc8e
BK
15512011-05-07 Ben Key <bkey76@gmail.com>
1552
1553 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1554 one of two shell specific rules, either bootstrap-temacs-CMD or
1555 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1556 to the previous implementation of the bootstrap-temacs rule.
1557 The bootstrap-temacs-CMD rule is similar to the previous
1558 implementation of the bootstrap-temacs rule except that it
1559 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1560 variable.
1561
1562 These changes, along with some changes to nt/configure.bat,
1563 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1564 earlier fix to add support for --cflags and --ldflags options
1565 that include quotes so that it works whether make uses cmd or
1566 sh as the shell.
1567
b4289b64
MA
15682011-05-06 Michael Albinus <michael.albinus@gmx.de>
1569
1570 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1571 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1572 is a constant.
1573 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1574 a string. Handle both cases.
1575 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1576 (Fdbus_register_method): Use Qinvalid_function.
1577
af4c0e28
JB
15782011-05-06 Juanma Barranquero <lekktu@gmail.com>
1579
1580 * makefile.w32-in: Update dependencies.
1581 (LISP_H): Add inttypes.h and stdin.h.
1582 (PROCESS_H): Add unistd.h.
1583
c51453d9
EZ
15842011-05-06 Eli Zaretskii <eliz@gnu.org>
1585
1586 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1587 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1588
8ff0ac3c 15892011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1590
4c4b566b
PE
1591 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1592
aab2b9b5
PE
1593 * term.c (vfatal): Remove stray call to va_end.
1594 It's not needed and the C Standard doesn't allow it here anyway.
1595
c378da0b
PE
1596 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1597 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1598
288b08c7
PE
1599 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1600 bytes.
1601
e3601888
PE
1602 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1603
db6c0e74
PE
1604 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1605
dd5963ea
PE
1606 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1607
88c9450f
PE
1608 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1609
2f9442b8
PE
1610 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1611
c032b5f8
PE
1612 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1613 * charset.c (Fdefine_charset_internal): Don't initialize
1614 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1615 32-bit int (Bug#8600).
a108c10b
PE
1616
1617 * lread.c (read_integer): Be more consistent with string-to-number.
1618 Use string_to_number to do the actual conversion; this avoids
1619 rounding errors and fixes some other screwups. Without this fix,
1620 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1621 (digit_to_number): Move earlier, for benefit of read_integer.
1622 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1623 not a digit in any supported base. (Bug#8602)
a108c10b 1624
ad5f9eea
PE
1625 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1626
aec1708a
PE
1627 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1628 to match comment at start of function. This also removes a
1629 GCC warning about overflow in a 32+64-bit port.
1630
47be4ab5
PE
1631 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1632
371cac43
PE
1633 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1634 Reported by Stefan Monnier in
1635 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1636 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1637 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1638
d01a7826
PE
1639 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1640 (EMACS_UINTPTR): Likewise, with uintptr_t.
1641
7fd47d5c
PE
1642 * lisp.h: Prefer 64-bit EMACS_INT if available.
1643 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1644 on 32-bit hosts that have 64-bit int, so that they can access
1645 large files.
122b0c86
PE
1646 However, temporarily disable this change unless the temporary
1647 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1648
8727937b
PE
1649 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1650
8ac068ac
PE
1651 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1652 This removes an assumption that EMACS_INT and long are the same
1653 width as pointers. The assumption is true for Emacs porting targets
1654 now, but we want to make other targets possible.
1655 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1656 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1657 In the rest of the code, change types of integers that hold casted
1658 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1659 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1660 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1661 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1662 No need to cast type when ORing.
1663 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1664 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1665 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1666 assume EMACS_INT is the same width as char *.
1667 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1668 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1669 Remove no-longer-needed casts.
1670 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1671 (xg_tool_bar_help_callback, xg_make_tool_item):
1672 Use EMACS_INTPTR to hold an integer
1673 that will be cast to void *; this can avoid a GCC warning
1674 if EMACS_INT is not the same width as void *.
1675 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1676 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1677 (current_message_1, set_message_1):
1678 Use a local to convert to proper width without a cast.
1679 * xmenu.c (dialog_selection_callback): Likewise.
1680
ede49d71
PE
1681 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1682 Also, don't assume VALBITS / RAND_BITS is less than 5,
1683 and don't rely on undefined behavior when shifting a 1 left into
1684 the sign bit.
1685 * lisp.h (get_random): Change signature to match.
1686
2f30ecd0
PE
1687 * lread.c (hash_string): Use size_t, not int, for hash computation.
1688 Normally we prefer signed values; but hashing is special, because
1689 it's better to use unsigned division on hash table sizes so that
1690 the remainder is nonnegative. Also, size_t is the natural width
1691 for hashing into memory. The previous code used 'int', which doesn't
1692 retain enough info to hash well into very large tables.
1693 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1694
2a866e7b
PE
1695 * dbusbind.c: Don't possibly lose pointer info when converting.
1696 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1697 Use XPNTR rather than XHASH, so that the high-order bits of
1698 the pointer aren't lost when converting through void *.
1699
51639eac
PE
1700 * eval.c (Fautoload): Don't double-shift a pointer.
1701
92394119
PE
1702 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1703
dbdb9a7c
JB
17042011-05-06 Juanma Barranquero <lekktu@gmail.com>
1705
1706 * gnutls.c (DEF_GNUTLS_FN):
1707 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1708
db7a0b4f
AS
17092011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1710
1711 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1712 marker. (Bug#8610)
1713
f7ff1b0f 17142011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1715
1716 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1717 New version that can reserve upto 2GB of heap space.
1718
f7ff1b0f 17192011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1720
1721 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1722
639c109b
TZ
17232011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1724
1725 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1726 `gnutls_certificate_set_x509_key_file'.
1727
d2127135
JB
17282011-05-05 Juanma Barranquero <lekktu@gmail.com>
1729
1730 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1731 Update dependencies.
1732
e968f4f3
JB
17332011-05-04 Juanma Barranquero <lekktu@gmail.com>
1734
1735 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1736 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1737 Remove unused parameter `fildes'.
1738 * process.c (read_process_output, send_process): Don't pass it.
1739
84d358f0
JB
17402011-05-04 Juanma Barranquero <lekktu@gmail.com>
1741
1742 Fix previous change: the library cache is defined in w32.c.
1743 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1744 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1745
0898ca10
JB
17462011-05-04 Juanma Barranquero <lekktu@gmail.com>
1747
1748 Implement dynamic loading of GnuTLS on Windows.
1749
1750 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1751 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1752 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1753 Declare.
1754
1755 * gnutls.c (Qgnutls_dll): Define.
1756 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1757 (gnutls_*): Declare function pointers.
1758 (init_gnutls_functions): New function to initialize function pointers.
1759 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1760 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1761 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1762 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1763 (emacs_gnutls_write, emacs_gnutls_read)
1764 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1765 (Fgnutls_available_p): New function.
1766 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1767 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1768 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1769
1770 * image.c: Include w32.h.
1771 (Vimage_type_cache): Delete.
1772 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1773 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1774 (w32_delayed_load): Move to w32.c.
1775
1776 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1777
1778 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1779 (w32_delayed_load): Move from image.c. When loading a library, record
1780 its filename in the :loaded-from property of the library id.
1781 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1782 Initialize and staticpro them.
1783 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1784
1785 * process.c: Include lisp.h before w32.h, not after.
1786 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1787 instead of gnutls_record_check_pending.
1788
1789 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1790
ff4de4aa
TZ
17912011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1792
1793 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1794 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1795 as passed in.
1796
abe95abb
JD
17972011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1798
1799 * xterm.c (x_set_frame_alpha): Do not set property on anything
1800 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1801
e16e55d4
JB
18022011-05-02 Juanma Barranquero <lekktu@gmail.com>
1803
1804 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1805
bafcf6a5
JB
18062011-05-02 Juanma Barranquero <lekktu@gmail.com>
1807
1808 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1809 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1810 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1811 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1812 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1813 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1814 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1815 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1816 (Qgnutls_bootprop_callbacks_verify): Make static.
1817
e7a6747f
AS
18182011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1819
19ed11ba
AS
1820 * callproc.c: Indentation fixup.
1821
e7a6747f 1822 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1823 (wait_for_termination, interruptible_wait_for_termination):
1824 Move after wait_for_termination_1.
e7a6747f 1825
1ef14cb4
LMI
18262011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1827
1828 * sysdep.c (interruptible_wait_for_termination): New function
1829 which is like wait_for_termination, but allows keyboard
1830 interruptions.
1831
1832 * callproc.c (Fcall_process): Add (:file "file") as an option for
1833 the STDOUT buffer.
1834 (Fcall_process_region): Ditto.
1835
330d880c
EZ
18362011-04-30 Eli Zaretskii <eliz@gnu.org>
1837
8db90b73
EZ
1838 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1839 rather than `XVECTOR (FOO)->size'.
1840
330d880c
EZ
1841 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1842 inttypes.h, as a gnulib replacement is used if it not available in
1843 system headers.
1844
15cbd324
EZ
18452011-04-21 Eli Zaretskii <eliz@gnu.org>
1846
1847 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1848 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1849 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1850
1851 * coding.c (coding_alloc_by_realloc): Error out if destination
1852 will grow beyond MOST_POSITIVE_FIXNUM.
1853 (decode_coding_emacs_mule): Abort if there isn't enough place in
1854 charbuf for the composition carryover bytes. Reserve an extra
1855 space for up to 2 characters produced in a loop.
1856 (decode_coding_iso_2022): Abort if there isn't enough place in
1857 charbuf for the composition carryover bytes.
1858
18592011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1860
ae940cca
EZ
1861 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1862 aborting when %lld or %lll format is passed.
1863 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1864 %llo or %llx format is passed. (Bug#8545)
1865
03ab8921
EZ
1866 * window.c (window_scroll_line_based): Use a marker instead of
1867 simple variables to record original value of point. (Bug#7952)
1868
afda1437
EZ
1869 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1870 produced by %s or %c overflows available buffer space. (Bug#8545)
1871
f76dee0c
PE
18722011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1873
1874 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1875 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1876
fdc5744d
JB
18772011-04-28 Juanma Barranquero <lekktu@gmail.com>
1878
1879 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1880
638f053a
JB
18812011-04-28 Juanma Barranquero <lekktu@gmail.com>
1882
1883 * keyboard.c (Qdelayed_warnings_hook): Define.
1884 (command_loop_1): Run `delayed-warnings-hook'
1885 if Vdelayed_warnings_list is non-nil.
1886 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1887 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1888
d178f871
EZ
18892011-04-28 Eli Zaretskii <eliz@gnu.org>
1890
1891 * doprnt.c (doprnt): Don't return value smaller than the buffer
1892 size if the message was truncated. (Bug#8545).
1893
b124fd93
JB
18942011-04-28 Juanma Barranquero <lekktu@gmail.com>
1895
1896 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1897 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1898
e810457d
PE
18992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1900
1901 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1902
ea51cceb
JB
19032011-04-27 Juanma Barranquero <lekktu@gmail.com>
1904
1905 * makefile.w32-in: Update dependencies.
1906
94dcfacf
EZ
19072011-04-27 Eli Zaretskii <eliz@gnu.org>
1908
1909 Improve `doprnt' and its usage. (Bug#8545)
1910 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1911 `format_end'. Remove support for %l as a conversion specifier.
1912 Don't use xrealloc. Improve diagnostics when the %l size modifier
1913 is used. Update the commentary.
1914
1915 * eval.c (verror): Simplify calculation of size_t.
1916
1917 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1918 messages.
1919
f61f41d7
PE
19202011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1921
1922 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1923 change.
1924
96fb4434
PE
19252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1926
1927 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1928 This makes this file independent of the recent pseudovector change.
1929
671875da 19302011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1931
69e9b5a3
PE
1932 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1933
b5f869a7 1934 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1935 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1936 Remove unused local.
c8926152 1937 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1938
841a1577 1939 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1940 GCC 4.6.0 optimizes based on type-based alias analysis.
1941 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1942 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1943 != &v->size, and therefore "v->size = 1; b->size = 2; return
1944 v->size;" must therefore return 1. This assumption is incorrect
1945 for Emacs, since it type-puns struct Lisp_Vector * with many other
1946 types. To fix this problem, this patch adds a new type struct
f904488f 1947 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1948 and pseudovectors, and helps optimizing compilers not get fooled
1949 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1950 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1951 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1952 the size member.
eab3844f
PE
1953 (XSETPVECTYPE): Rewrite in terms of new macro.
1954 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1955 This is a bit clearer, and further avoids the possibility of
1956 undesirable aliasing.
1957 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1958 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1959 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1960 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1961 (ASIZE): Now uses header.size rather than size.
1962 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1963 to avoid the hassle of writing XVECTOR (foo)->header.size.
1964 (struct vectorlike_header): New type.
eab3844f
PE
1965 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1966 object, to help avoid aliasing.
1967 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1968 (SUBRP): Likewise, since Lisp_Subr is a special case.
1969 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1970 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1971 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1972 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1973 changed to be "header.size" and "header.next".
1974 * buffer.h (struct buffer): Likewise.
1975 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1976 * frame.h (struct frame): Likewise.
1977 * process.h (struct Lisp_Process): Likewise.
1978 * termhooks.h (struct terminal): Likewise.
1979 * window.c (struct save_window_data, struct saved_window): Likewise.
1980 * window.h (struct window): Likewise.
1981 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1982 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1983 * buffer.c (init_buffer_once): Likewise.
1984 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1985 special case.
1986 * process.c (Fformat_network_address): Use local var for size,
1987 for brevity.
1988
0df1eac5
PE
1989 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1990
847ab9d1 1991 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1992 * data.c (atof): Remove decl; no longer used or needed.
1993 (digit_to_number): Move to lread.c.
1994 (Fstring_to_number): Use new string_to_number function, to be
1995 consistent with how the Lisp reader treats infinities and NaNs.
1996 Do not assume that floating-point numbers represent EMACS_INT
1997 without losing information; this is not true on most 64-bit hosts.
1998 Avoid double-rounding errors, by insisting on integers when
1999 parsing non-base-10 numbers, as the documentation specifies.
2000 * lisp.h (string_to_number): New decl, replacing ...
2001 (isfloat_string): Remove.
bc0a5c13 2002 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2003 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2004 appears to have been a coding error. Similarly, do not accept
2005 strings like +-1e0 as floating point numbers. Do not report
2006 overflow for integer overflows unless the base is not 10 which
2007 means we have no simple and reliable way to continue.
2008 Break out the floating-point parsing into a new
2009 function string_to_number, so that Fstring_to_number parses
2010 floating point numbers consistently with the Lisp reader.
04f2d78b 2011 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2012 (E_CHAR, EXP_INT): Remove, replacing with ...
2013 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2014 (string_to_number): New function, replacing isfloat_string.
2015 This function checks for valid syntax and produces the resulting
2016 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2017 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2018 so that overflow for non-base-10 numbers is reported only when
2019 there's no portable and simple way to convert to floating point.
452f4150 2020
67769ffc
PE
2021 * textprop.c (set_text_properties_1): Rewrite for clarity,
2022 and to avoid GCC warning about integer overflow.
2023
c20db43f
PE
2024 * intervals.h (struct interval): Use EMACS_INT for members
2025 where EMACS_UINT might cause problems. See
2026 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2027 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2028 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2029 All uses changed.
37aa2f85
PE
2030 (offset_intervals): Tell GCC not to worry about length overflow
2031 when negating a negative length.
c20db43f 2032
2538aa2f
PE
2033 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2034 (overrun_check_free): Likewise.
2035
f2d3008d
PE
2036 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2037 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2038 word size.
2039
ec8df744
PE
2040 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2041 (gnutls_make_error): Rename local to avoid shadowing.
2042 (gnutls_emacs_global_deinit): ifdef out; not used.
2043 (Fgnutls_boot): Use const for pointer to readonly storage.
2044 Comment out unused local. Fix pointer signedness problems.
2045
640ee02d
PE
2046 * lread.c (openp): Don't stuff size_t into an 'int'.
2047 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2048 about possible signed overflow.
2049
6048fb2a
PE
2050 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2051 (GDK_KEY_g): Don't define if already defined.
2052 (xg_prepare_tooltip): Avoid pointer signedness problem.
2053 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2054
fa3c87e1
PE
2055 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2056 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2057
2172544b
PE
2058 * xfns.c (Fx_window_property): Simplify a bit,
2059 to make a bit faster and to avoid GCC 4.6.0 warning.
2060 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2061
9b821a21
PE
2062 * fns.c (internal_equal): Don't assume size_t fits in int.
2063
3c616cfa
PE
2064 * alloc.c (compact_small_strings): Tighten assertion a little.
2065
c2982e87
PE
2066 Replace pEd with more-general pI, and fix some printf arg casts.
2067 * lisp.h (pI): New macro, generalizing old pEd macro to other
2068 conversion specifiers. For example, use "...%"pI"d..." rather
2069 than "...%"pEd"...".
2070 (pEd): Remove. All uses replaced with similar uses of pI.
2071 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2072 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2073 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2074 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2075 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2076 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2077 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2078 64-bit hosts.
2079 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2080 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2081 * print.c (safe_debug_print, print_object): Likewise.
2082 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2083 to int.
6f04d126
PE
2084 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2085 avoiding the 0 flag, which is not portable.
c2982e87
PE
2086 * process.c (Fmake_network_process): Use pI to avoid cast.
2087 * region-cache.c (pp_cache): Likewise.
2088 * xdisp.c (decode_mode_spec): Likewise.
2089 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2090 behavior on 64-bit hosts with printf arg.
6f04d126 2091 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2092 (x_stop_queuing_selection_requests): Likewise.
2093 (x_get_window_property): Don't truncate byte count to an 'int'
2094 when tracing.
0b432f21 2095
5e073ec7
PE
2096 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2097 here, since it parses constructs like leading '-' and spaces,
2098 which are not wanted; and it overflows with large numbers.
2099 Instead, simply match F[0-9]+, which is what is wanted anyway.
2100
36372bf9
PE
2101 * alloc.c: Remove unportable assumptions about struct layout.
2102 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2103 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2104 (allocate_vectorlike, make_pure_vector): Use the new macros,
2105 plus offsetof, to remove unportable assumptions about struct layout.
2106 These assumptions hold on all porting targets that I know of, but
2107 they are not guaranteed, they're easy to remove, and removing them
2108 makes further changes easier.
2109
0b432f21
PE
2110 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2111 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2112 (string_overrun_cookie): Now const. Use initializers that
2113 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2114 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2115 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2116 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2117 multiple of sizeof (EMACS_INT); it need not be, if
2118 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2119 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2120
895009e1
JB
21212011-04-26 Juanma Barranquero <lekktu@gmail.com>
2122
2123 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2124
6a7a1b0b
TZ
21252011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2126
2127 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2128 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2129 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2130
841a1577 21312011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2132
2133 * lisp.h (Qdebug): List symbol.
895009e1 2134 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2135 * keyboard.c (debug-on-event): New variable.
2136 (handle_user_signal): Break into debugger when debug-on-event
2137 matches the current signal symbol.
2138
f2d3ba6f
DN
21392011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2140
2141 * alloc.c (check_sblock, check_string_bytes)
2142 (check_string_free_list): Convert to standard C.
2143
42ce4c63
TZ
21442011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2145
2146 * w32.c (emacs_gnutls_push): Fix typo.
2147
825cd63c
EZ
21482011-04-25 Eli Zaretskii <eliz@gnu.org>
2149
fb11d64d
EZ
2150 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2151 "cast to pointer from integer of different size".
2152
825cd63c
EZ
2153 Improve doprnt and its use in verror. (Bug#8545)
2154 * doprnt.c (doprnt): Document the set of format control sequences
2155 supported by the function. Use SAFE_ALLOCA instead of always
2156 using `alloca'.
2157
2158 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2159 is one byte too soon. Don't use xrealloc; instead xfree and
2160 xmalloc anew.
2161
e061a11b
TZ
21622011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2163
2164 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2165 callbacks stage.
2166
2167 * gnutls.c: Renamed global_initialized to
2168 gnutls_global_initialized. Added internals for the
2169 :verify-hostname-error, :verify-error, and :verify-flags
2170 parameters of `gnutls-boot' and documented those parameters in the
2171 docstring. Start callback support.
2172 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2173 unless a fatal error occured. Call gnutls_alert_send_appropriate
2174 on error. Return error code.
2175 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2176 (emacs_gnutls_read): Likewise.
2177 (Fgnutls_boot): Return handshake error code.
2178 (emacs_gnutls_handle_error): New function.
2179 (wsaerror_to_errno): Likewise.
2180
2181 * w32.h (emacs_gnutls_pull): Add prototype.
2182 (emacs_gnutls_push): Likewise.
2183
2184 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2185 (emacs_gnutls_push): Likewise.
2186
21872011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2188
2189 * process.c (wait_reading_process_output): Check if GnuTLS
2190 buffered some data internally if no FDs are set for TLS
2191 connections.
2192
2193 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2194 (LIBS): Link to USER_LIBS.
2195 ($(BLD)/gnutls.$(0)): New target.
2196
fa6996bc
EZ
21972011-04-24 Eli Zaretskii <eliz@gnu.org>
2198
eb35682e
EZ
2199 * xdisp.c (handle_single_display_spec): Rename the
2200 display_replaced_before_p argument into display_replaced_p, to
2201 make it consistent with the commentary. Fix typos in the
2202 commentary.
2203
e2ad650c
EZ
2204 * textprop.c (syms_of_textprop): Remove dead code.
2205 (copy_text_properties): Delete obsolete commentary about an
2206 interface that was deleted long ago. Fix typos in the description
2207 of arguments.
2208
1b2de274
EZ
2209 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2210 to changes in oldXMenu/XMenu.h from 2011-04-16.
2211 <menu_help_message, prev_menu_help_message>: Constify.
2212 (IT_menu_make_room): menu->help_text is now `const char **';
2213 adjust.
2214
2215 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2216 to changes in oldXMenu/XMenu.h from 2011-04-16.
2217 (struct XMenu): Declare `help_text' `const char **'.
2218
2219 * xfaces.c <Qunspecified>: Make extern again.
2220
2221 * syntax.c: Include sys/types.h before including regex.h, as
2222 required by Posix.
2223
762b15be
EZ
2224 * doc.c (get_doc_string): Improve the format passed to `error'.
2225
2226 * doprnt.c (doprnt): Improve commentary.
2227
2228 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2229
2230 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2231 them with etags.
2232
f1052e5d
EZ
2233 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2234 changes in globals.h immediately force recompilation.
762b15be
EZ
2235 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2236 $(CURDIR)/s/ms-w32.h.
2237 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2238
fa6996bc
EZ
2239 * character.c (Fchar_direction): Function deleted.
2240 (syms_of_character): Don't defsubr it.
2241 <char-direction-table>: Deleted.
2242
e6c3da20
EZ
22432011-04-23 Eli Zaretskii <eliz@gnu.org>
2244
2245 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2246 * doprnt.c: Include limits.h.
2247 (SIZE_MAX): New macro.
04f2d78b
CB
2248 (doprnt): Return a size_t value. 2nd arg is now size_t.
2249 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2250 Improve overflow protection. Support `l' modifier for integer
2251 conversions. Support %l conversion. Don't assume an EMACS_INT
2252 argument for integer conversions and for %c.
2253
2254 * lisp.h (doprnt): Restore prototype.
2255
2256 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2257 $(SRC)/character.h.
2258
2259 * Makefile.in (base_obj): Add back doprnt.o.
2260
2261 * deps.mk (doprnt.o): Add back prerequisites.
2262 (callint.o): Depend on character.h.
2263
2264 * eval.c (internal_lisp_condition_case): Include the handler
2265 representation in the error message.
2266 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2267 when breaking from the loop.
2268
2269 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2270
2271 * callint.c (Fcall_interactively): When displaying error message
2272 about invalid control letter, pass the character's codepoint, not
2273 a pointer to its multibyte form. Improve display of the character
2274 in octal and display also its hex code.
2275
2276 * character.c (char_string): Use %x to display the (unsigned)
2277 codepoint of an invalid character, to avoid displaying a bogus
2278 negative value.
2279
2280 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2281 `error', not SYMBOL_NAME itself.
2282
2283 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2284 character arguments to `error'.
2285
2286 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2287 to `error' in error message about FINAL_CHAR argument. Make sure
2288 FINAL_CHAR is a character, and use %c when it is passed as
2289 argument to `error'.
2290
4ffd0d6b 22912011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2292
2293 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2294
2295 * w32.c: Include <time.h>.
2296 (sys_localtime): New function.
2297
4ffd0d6b 22982011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2299
2300 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2301
4ffd0d6b 2302 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2303
4ffd0d6b 23042011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2305
4ffd0d6b
GM
2306 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2307 zombies (Bug#8467).
aac0c6e3 2308
04c56954
EZ
23092011-04-19 Eli Zaretskii <eliz@gnu.org>
2310
2311 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2312 gl_state.e_property when gl_state.object is Qt.
2313
2314 * insdel.c (make_gap_larger): Remove limitation of buffer size
2315 to <= INT_MAX.
2316
16a43933
CY
23172011-04-18 Chong Yidong <cyd@stupidchicken.com>
2318
2319 * xdisp.c (lookup_glyphless_char_display)
2320 (produce_glyphless_glyph): Handle cons cell entry in
2321 glyphless-char-display.
2322 (Vglyphless_char_display): Document it.
2323
2324 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2325 glyphless-char-display.
2326
4581706e
CY
23272011-04-17 Chong Yidong <cyd@stupidchicken.com>
2328
2329 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2330
2331 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2332
2333 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2334 definition for no-X builds.
2335
4887c6e2 23362011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2337
fd35b6f9
PE
2338 Static checks with GCC 4.6.0 and non-default toolkits.
2339
5c1ccb01
PE
2340 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2341
006c5daa
PE
2342 * process.c (keyboard_bit_set): Define only if SIGIO.
2343 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2344 (send_process): Repair possible setjmp clobbering.
2345
efc736d3
PE
2346 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2347
4e2fe2e6
PE
2348 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2349
f97334a2
PE
2350 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2351
4e75f29d
PE
2352 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2353 Define only if needed.
2354
90efadd1
PE
2355 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2356 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2357 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2358
3c647824
PE
2359 * dispextern.h (struct redisplay_interface): Rename param
2360 to avoid shadowing.
e264f262 2361 * termhooks.h (struct terminal): Likewise.
761383f4 2362 * xterm.c (xembed_send_message): Likewise.
3c647824 2363
b58c5c4a
PE
2364 * insdel.c (make_gap_smaller): Define only if
2365 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2366
cad59032
PE
2367 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2368 it.
2369
c339dc2e
PE
2370 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2371 so that we aren't warned about unused symbols.
2372
91a3e27b
PE
2373 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2374
399c71d3 2375 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2376
8ffc96f5
PE
2377 * xfns.c (x_real_positions): Mark locals as initialized.
2378
eef9bc79
PE
2379 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2380
098db9dd
PE
2381 * xterm.c: Fix problems found by static analysis with other toolkits.
2382 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2383 (x_dispatch_event): Declare static if USE_GTK, and
2384 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2385 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2386 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2387 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2388 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2389
eb18f6cc
PE
2390 * xmenu.c (menu_help_callback): Pointer type fixes.
2391 Use const pointers when pointing at readonly data. Avoid pointer
2392 signedness clashes.
2393 (FALSE): Remove unused macro.
2394 (update_frame_menubar): Remove unused decl.
2395
1fe72bf8
PE
2396 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2397
60d9e1db
PE
2398 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2399 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2400 (single_menu_item): Rename local to avoid shadowing.
2401
39261c26
PE
2402 * keyboard.c (make_lispy_event): Remove unused local var.
2403
018c5e19
PE
2404 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2405 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2406
63d2b86e
PE
2407 * bitmaps: Change bitmaps from unsigned char back to the X11
2408 compatible char. Avoid the old compiler warnings about
2409 out-of-range initializers by using, for example, '\xab' rather
2410 than 0xab.
2411
aefd87e1
PE
2412 * xgselect.c (xgselect_initialize): Check vs interface
2413 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2414
bf501fb9
PE
2415 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2416
e9829fdf
PE
2417 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2418 to read-only memory.
2419
1086c095
PE
2420 * fns.c (vector): Remove; this old hack is no longer needed.
2421
2baccd04 2422 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2423 Remove unused var.
dde42981 2424 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2425
72391843 2426 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2427
436c16df 2428 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2429 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2430 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2431
92bb796d 2432 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2433 (x_term_init): Remove local to avoid shadowing.
92bb796d 2434
764430a3 2435 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2436
2437 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2438 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2439
d1dfb56c
EZ
24402011-04-16 Eli Zaretskii <eliz@gnu.org>
2441
c4354cb4
EZ
2442 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2443
d1dfb56c
EZ
2444 Fix regex.c, syntax.c and friends for buffers > 2GB.
2445 * syntax.h (struct gl_state_s): Declare character position members
2446 EMACS_INT.
2447
2448 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2449
04f2d78b
CB
2450 * textprop.c (verify_interval_modification, interval_of):
2451 Declare arguments EMACS_INT.
d1dfb56c
EZ
2452
2453 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2454 EMACS_INT.
2455
2456 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2457
2458 * indent.c (Fvertical_motion): Local variable it_start is now
2459 EMACS_INT.
2460
2461 * regex.c (re_match, re_match_2, re_match_2_internal)
2462 (bcmp_translate, regcomp, regexec, print_double_string)
2463 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2464 (re_compile_pattern, re_exec): Declare arguments and local
2465 variables `size_t' and `ssize_t' and return values `regoff_t', as
2466 appropriate.
2467 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2468 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2469 <compile_stack_type>: `size' and `avail' are now `size_t'.
2470
2471 * regex.h <regoff_t>: Use ssize_t, not int.
2472 (re_search, re_search_2, re_match, re_match_2): Arguments that
2473 specify buffer/string position and length are now ssize_t and
2474 size_t. Return type is regoff_t.
2475
613052cd
BK
24762011-04-16 Ben Key <bkey76@gmail.com>
2477
2478 * nsfont.m: Fixed bugs in ns_get_family and
2479 ns_descriptor_to_entity that were caused by using free to
2480 deallocate memory blocks that were allocated by xmalloc (via
2481 xstrdup). This caused Emacs to crash when compiled with
2482 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2483 --enable-checking=xmallocoverrun). xfree is now used to
2484 deallocate these memory blocks.
2485
4170f62f 24862011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2487
71b41406
PE
2488 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2489
9587a89d
PE
2490 emacs_write: Accept and return EMACS_INT for sizes.
2491 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2492 et seq.
2493 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2494 Accept and return EMACS_INT.
2495 (emacs_gnutls_write): Return the number of bytes written on
2496 partial writes.
2497 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2498 (emacs_read, emacs_write): Remove check for negative size, as the
2499 Emacs source code has been audited now.
9587a89d
PE
2500 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2501 (emacs_read, emacs_write): Use it.
273a5f82
PE
2502 * process.c (send_process): Adjust to the new signatures of
2503 emacs_write and emacs_gnutls_write. Do not attempt to store
2504 a byte offset into an 'int'; it might overflow.
9587a89d 2505 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2506
3e047f51
PE
2507 * sound.c: Don't assume sizes fit in 'int'.
2508 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2509 Return EMACS_INT, not int.
3e047f51 2510 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2511 Accept EMACS_INT, not int.
2512 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2513 record read return values.
2514
cc39a9db
BK
25152011-04-15 Ben Key <bkey76@gmail.com>
2516
c9d0ec6d
JB
2517 * keyboard.c (Qundefined): Don't declare static since it is used
2518 in nsfns.m.
2519 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2520 static since they are used in nsfont.m.
cc39a9db 2521
6c60eb9f
SM
25222011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2523
2524 * process.c (Qprocessp): Don't declare static.
2525 * lisp.h (Qprocessp): Declare again.
2526
7990b61a
JB
25272011-04-15 Juanma Barranquero <lekktu@gmail.com>
2528
2529 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2530
5d4cb038
PE
25312011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2532
8bd7b830 2533 Improve C-level modularity by making more things 'static'.
cd64ea1d 2534
e3b27b31
PE
2535 Don't publish debugger-only interfaces to other modules.
2536 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2537 (verify_bytepos, count_markers): Move decls to the only modules
2538 that need them.
2539 * region-cache.h (pp_cache): Likewise.
2540 * window.h (check_all_windows): Likewise.
2541 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2542
5d4cb038
PE
2543 * sysdep.c (croak): Now static, if
2544 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2545 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2546
2547 * alloc.c (refill_memory_reserve): Now static if
2548 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2549 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2550
e87b6180
PE
2551 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2552 Define only if USE_LUCID.
2553
ac64929e
PE
2554 * xrdb.c (x_customization_string, x_rm_string): Now static.
2555
6f37259d
PE
2556 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2557 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2558
1683e3ab
PE
2559 * xdisp.c (draw_row_with_mouse_face): Now static.
2560 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2561
de9c2632
PE
2562 * window.h (check_all_windows): Mark externally visible.
2563
2b96acb7
PE
2564 * window.c (window_deletion_count): Now static.
2565
2566 * undo.c: Make symbols static if they're not exported.
2567 (last_undo_buffer, last_boundary_position, pending_boundary):
2568 Now static.
2569
50436f33
PE
2570 * textprop.c (interval_insert_behind_hooks): Now static.
2571 (interval_insert_in_front_hooks): Likewise.
2572
64520e5c
PE
2573 * term.c: Make symbols static if they're not exported.
2574 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2575 (max_frame_lines, tty_set_terminal_modes):
2576 (tty_reset_terminal_modes, tty_turn_off_highlight):
2577 (get_tty_terminal): Now static.
2578 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2579 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2580 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2581 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2582 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2583
1fa53021
PE
2584 * sysdep.c: Make symbols static if they're not exported.
2585 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2586 Now static.
2587 (sigprocmask_set, full_mask): Remove; unused.
2588 (wait_debugging): Mark as visible.
2589 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2590 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2591
d4b43b22
PE
2592 * syntax.c (syntax_temp): Define only if !__GNUC__.
2593
b7c513d0
PE
2594 * sound.c (current_sound_device, current_sound): Now static.
2595
989b29ad
PE
2596 * search.c (searchbufs, searchbuf_head): Now static.
2597
13a55a78
PE
2598 * scroll.c (scroll_cost): Remove; unused.
2599 * dispextern.h (scroll_cost): Remove decl.
2600
de68a1fc
PE
2601 * region-cache.h (pp_cache): Mark as externally visible.
2602
40ccffa6
PE
2603 * process.c: Make symbols static if they're not exported.
2604 (process_tick, update_tick, create_process, chan_process):
2605 (Vprocess_alist, proc_buffered_char, datagram_access):
2606 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2607 (deactivate_process): Mark defn as static, as well as decl.
2608 * lisp.h (create_process): Remove decl.
2609 * process.h (chan_process, Vprocess_alist): Remove decls.
2610
ad64fc97
PE
2611 * print.c: Make symbols static if they're not exported.
2612 (print_depth, new_backquote_output, being_printed, print_buffer):
2613 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2614 (print_interval, print_number_index, initial_stderr_stream):
2615 Now static.
2616 * lisp.h (Fprinc): Remove decl.
2617 (debug_output_compilation_hack): Mark as externally visible.
2618
adddb265
PE
2619 * sysdep.c (croak): Move decl from here to syssignal.h.
2620 * syssignal.h (croak): Put it here, so the API can be checked when
2621 'croak' is called from dissociate_if_controlling_tty.
2622
1717ede2
PE
2623 * minibuf.c: Make symbols static if they're not exported.
2624 (minibuf_save_list, choose_minibuf_frame): Now static.
2625 * lisp.h (choose_minibuf_frame): Remove decl.
2626
fa5fb2bc
PE
2627 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2628
1e3890d1
PE
2629 * lread.c: Make symbols static if they're not exported.
2630 (read_objects, initial_obarray, oblookup_last_bucket_number):
2631 Now static.
2632 (make_symbol): Remove; unused.
2633 * lisp.h (initial_obarray, make_symbol): Remove decls.
2634
8a1414fa
PE
2635 * keyboard.c: Make symbols static if they're not exported.
2636 (single_kboard, recent_keys_index, total_keys, recent_keys):
2637 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2638 (this_single_command_key_start, echoing, last_auto_save):
2639 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2640 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2641 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2642 (Vlispy_mouse_stem, double_click_count):
2643 Now static.
2644 (force_auto_save_soon): Define only if SIGDANGER.
2645 (ignore_mouse_drag_p): Now static if
2646 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2647 (print_help): Remove; unused.
2648 (stop_character, last_timer_event): Mark as externally visible.
2649 * keyboard.h (ignore_mouse_drag_p): Declare only if
2650 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2651 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2652 * lisp.h (echoing): Remove decl.
2653 (force_auto_save_soon): Declare only if SIGDANGER.
2654 * xdisp.c (redisplay_window): Simplify code, to make it more
2655 obvious that ignore_mouse_drag_p is not accessed if !defined
2656 USE_GTK && !defined HAVE_NS.
2657
93ea6e8f
PE
2658 * intervals.c: Make symbols static if they're not exported.
2659 (merge_properties_sticky, merge_interval_right, delete_interval):
2660 Now static.
2661 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2662
77382fcc
PE
2663 * insdel.c: Make symbols static if they're not exported.
2664 However, leave prepare_to_modify_buffer alone. It's never
2665 called from outside this function, but that appears to be a bug.
2666 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2667 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2668 (adjust_after_replace_noundo): Remove; unused.
2669 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2670 (signal_before_change): Remove decls.
77382fcc 2671
9306c32e
PE
2672 * indent.c (val_compute_motion, val_vmotion): Now static.
2673
cd44d2eb
PE
2674 * image.c: Make symbols static if they're not exported.
2675 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2676 if USE_GTK.
2677 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2678 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2679
ad9a7a06
PE
2680 * fringe.c (standard_bitmaps): Now static.
2681 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2682
81626931
PE
2683 * frame.c: Make symbols static if they're not exported.
2684 (x_report_frame_params, make_terminal_frame): Now static.
2685 (get_frame_param): Now static, unless HAVE_NS.
2686 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2687 (x_get_resource_string): Remove; not used.
2688 * frame.h (make_terminal_frame, x_report_frame_params):
2689 (x_get_resource_string); Remove decls.
2690 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2691 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2692
239f9db9
PE
2693 * font.c, fontset.c: Make symbols static if they're not exported.
2694 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2695 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2696 * font.c (font_close_object): Now static.
2697 * font.h (font_close_object): Remove.
2698 * fontset.c (FONTSET_OBJLIST): Remove.
2699 (free_realized_fontset) #if-0 the body, which does nothing.
2700 (face_suitable_for_char_p): #if-0, as it's never called.
2701 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2702 * xfaces.c (face_at_string_position):
2703 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2704 since 0 is always ASCII.
2705
dfcf3579
PE
2706 * fns.c (weak_hash_tables): Now static.
2707
5045092b
PE
2708 * fileio.c: Make symbols static if they're not exported.
2709 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2710 (Vwrite_region_annotation_buffers): Now static.
2711
57a96f5c
PE
2712 * eval.c: Make symbols static if they're not exported.
2713 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2714 * lisp.h (backtrace_list): Remove decl.
2715
35f08c38
PE
2716 * emacs.c: Make symbols static if they're not exported.
2717 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2718 (fatal_error_code, fatal_error_signal_hook, standard_args):
2719 Now static.
2720 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2721 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2722 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2723 * lisp.h (fatal_error_signal_hook): Remove decl.
2724 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2725
f44bd759
PE
2726 * editfns.c: Move a (normally-unused) function to its only use.
2727 * editfns.c, lisp.h (get_operating_system_release): Remove.
2728 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2729 worth the hassle of breaking this out.
2730
b532497d
PE
2731 * xterm.c: Make symbols static if they're not exported.
2732 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2733 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2734 (x_destroy_window, x_delete_display):
2735 Now static.
2736 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2737 (x_mouse_leave): Remove; unused.
2738 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2739 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2740 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2741 Remove decls.
2742 (x_mouse_leave): Declare only if WINDOWSNT.
2743 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2744 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2745 USE_X_TOOLKIT.
2746
1675728f
PE
2747 * ftxfont.c: Make symbols static if they're not exported.
2748 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2749 HAVE_FREETYPE.
2750 * font.h (ftxfont_driver): Likewise.
2751
e4cebfca
PE
2752 * xfns.c: Make symbols static if they're not exported.
2753 (x_last_font_name, x_display_info_for_name):
2754 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2755 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2756 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2757 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2758 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2759 (last_show_tip_args): Now static.
2760 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2761 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2762 (x_screen_planes): Remove; unused.
2763 * dispextern.h (x_screen_planes): Remove decl.
2764
5bf46f05
PE
2765 * dispnew.c: Make symbols static if they're not exported.
2766 * dispextern.h (redraw_garbaged_frames, scrolling):
2767 (increment_row_positions): Remove.
2768 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2769 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2770 Now static.
2771 (redraw_garbaged_frames): Remove; unused.
2772
435f4c28
PE
2773 * xfaces.c: Make symbols static if they're not exported.
2774 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2775 Remove decls.
2776 * xterm.h (defined_color): Remove decls.
2777 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2778 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2779 (menu_face_changed_default, defined_color, free_realized_face):
2780 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2781 (ascii_face_of_lisp_face): Remove; unused.
2782
8524aef3
PE
2783 * xdisp.c: Make symbols static if they're not exported.
2784 * dispextern.h (scratch_glyph_row, window_box_edges):
2785 (glyph_to_pixel_coords, set_cursor_from_row):
2786 (get_next_display_element, set_iterator_to_next):
2787 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2788 (show_mouse_face): Remove decls
2789 * frame.h (message_buf_print): Likewise.
2790 * lisp.h (pop_message, set_message, check_point_in_composition):
2791 Likewise.
2792 * xterm.h (set_vertical_scroll_bar): Likewise.
2793 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2794 (message_buf_print, scratch_glyph_row, displayed_buffer):
2795 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2796 (get_next_display_element, show_mouse_face, window_box_edges):
2797 (frame_to_window_pixel_xy, check_point_in_composition):
2798 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2799 (glyph_to_pixel_coords): Remove; unused.
2800
16390cd2
PE
2801 * dired.c (file_name_completion): Now static.
2802
2803 * dbusbind.c (xd_in_read_queued_messages): Now static.
2804
a25f4dfa
PE
2805 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2806 * data.c (circular_list_error): Remove.
2807
14a9c8df
PE
2808 * commands.h (last_point_position, last_point_position_buffer):
2809 (last_point_position_window): Remove decls.
2810 * keyboard.c: Make these variables static.
2811
04f2d78b
CB
2812 * coding.h (coding, code_convert_region, encode_coding_gap):
2813 Remove decls.
74ab6df5
PE
2814 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2815 (iso_code_class, detect_coding, code_convert_region): Now static.
2816 (encode_coding_gap): Remove; unused.
2817
38dfbee1
PE
2818 * chartab.c (chartab_chars, chartab_bits): Now static.
2819
a2cb4e63
PE
2820 * charset.h (charset_iso_8859_1): Remove decl.
2821 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2822 Now static.
2823
127198fd
PE
2824 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2825 * ccl.c (Vccl_program_table): Now static.
2826 (check_ccl_update): Remove; unused.
2827
d85b608f
PE
2828 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2829 * category.h: ... from here.
2830 * category.c (check_category_table, set_category_set): Now static.
2831
31cd66f3
PE
2832 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2833 * lisp.h: Remove these decls.
2834
c358e587
PE
2835 * buffer.c (buffer_count): Remove unused var.
2836
e78aecca
PE
2837 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2838 so that it's not optimized away.
2839 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2840 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2841 exported only to the debugger.
2842
e192d7d3 2843 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2844 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2845
92470028
PE
2846 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2847 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2848 was inaccessible from Lisp.
2849 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2850 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2851
244ed907
PE
2852 alloc.c: Import and export fewer symbols, and remove unused items.
2853 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2854 is defined.
2855 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2856 it's not optimized away by whole-program optimization.
2857 (message_enable_multibyte, free_misc): Remove.
2858 (catchlist, handlerlist, mark_backtrace):
2859 Declare only if BYTE_MARK_STACK.
2860 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2861 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2862 (message_enable_multibyte): Remove decl.
2863 (free_misc, interval_free_list, float_block, float_block_index):
2864 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2865 (cons_free_list, last_marked_index):
2866 Now static.
2867 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2868 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2869 (mark_backtrace): Define only if BYTE_MARK_STACK.
2870 * xdisp.c (message_enable_multibyte): Now static.
2871
61c2b50e 2872 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2873 This makes it easier for human readers (and static analyzers)
2874 to see whether these variables are used from other modules.
2875 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2876 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2877 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2878 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2879 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2880 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2881 * xmenu.c, xselect.c:
2882 Declare Q* vars static if they are not used in other modules.
2883 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2884 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2885 Remove decls of unexported vars.
2886 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2887
95c82688
PE
2888 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2889
16a97296
PE
2890 Make Emacs functions such as Fatom 'static' by default.
2891 This makes it easier for human readers (and static analyzers)
2892 to see whether these functions can be called from other modules.
2893 DEFUN now defines a static function. To make the function external
2894 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2895 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2896 (Finit_image_library):
16a97296
PE
2897 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2898 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2899 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2900 Remove decls, since these functions are now static.
2901 (Funintern, Fget_internal_run_time): New decls, since these functions
2902 were already external.
95c82688 2903
16a97296
PE
2904 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2905 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2906 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2907 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2908 * keyboard.c, keymap.c, lread.c:
2909 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2910 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2911 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2912 Mark functions with DEFUE instead of DEFUN,
2913 if they are used in other modules.
2914 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2915 decls for now-static functions.
2916 * buffer.h (Fdelete_overlay): Remove decl.
2917 * callproc.c (Fgetenv_internal): Mark as internal.
2918 * composite.c (Fremove_list_of_text_properties): Remove decl.
2919 (Fcomposition_get_gstring): New forward static decl.
2920 * composite.h (Fcomposite_get_gstring): Remove decl.
2921 * dired.c (Ffile_attributes): New forward static decl.
2922 * doc.c (Fdocumntation_property): New forward static decl.
2923 * eval.c (Ffetch_bytecode): New forward static decl.
2924 (Funintern): Remove extern decl; now in .h file where it belongs.
2925 * fileio.c (Fmake_symbolic_link): New forward static decl.
2926 * image.c (Finit_image_library): New forward static decl.
2927 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2928 * intervals.h (Fprevious_property_change):
2929 (Fremove_list_of_text_properties): Remove decls.
2930 * keyboard.c (Fthis_command_keys): Remove decl.
2931 (Fcommand_execute): New forward static decl.
2932 * keymap.c (Flookup_key): New forward static decl.
2933 (Fcopy_keymap): Now static.
2934 * keymap.h (Flookup_key): Remove decl.
2935 * process.c (Fget_process): New forward static decl.
2936 (Fprocess_datagram_address): Mark as internal.
2937 * syntax.c (Fsyntax_table_p): New forward static decl.
2938 (skip_chars): Remove duplicate decl.
2939 * textprop.c (Fprevious_property_change): New forward static decl.
2940 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2941 Now internal.
2942 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2943 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2944
785bbd42
PE
2945 * editfns.c (Fformat): Remove unreachable code.
2946
8b913b57
AS
29472011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2948
2949 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2950 change. (Bug#8496)
2951
a6744a35
EZ
29522011-04-13 Eli Zaretskii <eliz@gnu.org>
2953
2954 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2955 when at ZV. (Bug#8487)
2956
e7974947
AS
29572011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2958
baad03f0
AS
2959 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2960 (Bug#8437)
2961 * keyboard.c (parse_tool_bar_item): Likewise.
2962 * sound.c (sound_cleanup, alsa_close): Likewise.
2963 * termcap.c (tgetent): Likewise.
2964 * xfns.c (x_default_font_parameter): Likewise.
2965 * xsettings.c (read_and_apply_settings): Likewise.
2966
e7974947
AS
2967 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2968 (overrun_check_free): Protoize.
2969
28272684
PE
29702011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2971
2972 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2973 since callers should never pass a negative size.
2974 Change the signature to match that of plain 'read' and 'write'; see
2975 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2976 * lisp.h: Update prototypes of emacs_write and emacs_read.
2977
11997c76
EZ
29782011-04-11 Eli Zaretskii <eliz@gnu.org>
2979
2980 * xdisp.c (redisplay_window): Don't try to determine the character
2981 position of the scroll margin if the window start point w->startp
e896f03c 2982 is outside the buffer's accessible region. (Bug#8468)
11997c76 2983
8a2cbd72
EZ
29842011-04-10 Eli Zaretskii <eliz@gnu.org>
2985
2986 Fix write-region and its subroutines for buffers > 2GB.
2987 * fileio.c (a_write, e_write): Modify declaration of arguments and
2988 local variables to support buffers larger than 2GB.
2989 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2990
2991 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2992 argument, local variables, and return value.
2993
2994 * lisp.h: Update prototypes of emacs_write and emacs_read.
2995
2996 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2997
4073e537 29982011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2999
1ebfdcb6
PE
3000 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3001
b2ded58d
PE
3002 Fix more problems found by GCC 4.6.0's static checks.
3003
7d66342c
PE
3004 * xdisp.c (vmessage): Use a better test for character truncation.
3005
bbf47d44
PE
3006 * charset.c (load_charset_map): <, not <=, for optimization,
3007 and to avoid potential problems with integer overflow.
9248994d 3008 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3009 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3010 * editfns.c (Fformat): Likewise.
1e69125e 3011 * syntax.c (skip_chars): Likewise.
3befa583 3012
e3019616
PE
3013 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3014 This also lets GCC 4.6.0 generate slightly better loop code.
3015
becfa255
PE
3016 * callint.c (Fcall_interactively): <, not <=, for optimization.
3017 (Fcall_interactively): Count the number of arguments produced,
3018 not the number of arguments given. This is simpler and lets GCC
3019 4.6.0 generate slightly better code.
3020
dae0cd48
PE
3021 * ftfont.c: Distingish more carefully between FcChar8 and char.
3022 The previous code passed unsigned char * to a functions like
3023 strlen and xstrcasecmp that expect char *, which does not
3024 conform to the C standard.
3025 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3026 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3027 char * when the C standard requires it.
3028
76032d70
PE
3029 * keyboard.c (read_char): Remove unused var.
3030
eb3f1cc8
PE
3031 * eval.c: Port to Windows vsnprintf (Bug#8435).
3032 Include <limits.h>.
3033 (SIZE_MAX): Define if the headers do not.
3034 (verror): Do not give up if vsnprintf returns a negative count.
3035 Instead, grow the buffer. This ports to Windows vsnprintf, which
3036 does not conform to C99. Problem reported by Eli Zaretskii.
3037 Also, simplify the allocation scheme, by avoiding the need for
3038 calling realloc, and removing the ALLOCATED variable.
3039
70476b54
PE
3040 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3041
12020a9e
PE
3042 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3043 But keep the doprint source code for now, as we might revamp it
3044 and use it again (Bug#8435).
ea6c7ae6
PE
3045 * lisp.h (doprnt): Remove.
3046 * Makefile.in (base_obj): Remove doprnt.o.
3047 * deps.mk (doprnt.o): Remove.
3048
5fdb398c
PE
3049 error: Print 32- and 64-bit integers portably (Bug#8435).
3050 Without this change, on typical 64-bit hosts error ("...%d...", N)
3051 was used to print both 32- and 64-bit integers N, which relied on
3052 undefined behavior.
3053 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3054 New macro.
3055 * lisp.h (error, verror): Mark as printf-like functions.
3056 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3057 Report overflow in size calculations when allocating printf buffer.
3058 Do not truncate output string at its first null byte.
3059 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3060 Truncate the output at a character boundary, since vsnprintf does not
3061 do that.
3062 * charset.c (check_iso_charset_parameter): Convert internal
3063 character to string before calling 'error', since %c now has the
3064 printf meaning.
3065 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3066 overflow when computing char to be passed to 'error'. Do not
3067 pass Lisp_Object to 'error'; pass the integer instead.
3068 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3069 formatted with plain %d.
3070
b189fa66
PE
3071 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3072
bff87ef0
PE
3073 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3074
7e2cac20
PE
3075 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3076
ce4d90b5
PE
3077 * xterm.c (x_catch_errors): Remove duplicate declaration.
3078
266c9547
PE
3079 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3080
79c49ad2
PE
3081 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3082
368f4090
JM
30832011-04-10 Jim Meyering <meyering@redhat.com>
3084
3085 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3086 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3087 return ssize_t not "int", and use size_t as the buffer length.
3088 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3089 * gnutls.h: Update declarations.
3090 * process.c (read_process_output): Use ssize_t, to match.
3091 (send_process): Likewise.
3092
a32d4040
CY
30932011-04-09 Chong Yidong <cyd@stupidchicken.com>
3094
3095 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3096
8546720e 30972011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3098
04f2d78b
CB
3099 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3100 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3101
8546720e
GM
3102 * xterm.c (handle_one_xevent):
3103 * xmenu.c (create_and_show_popup_menu):
3104 * xselect.c (x_decline_selection_request)
3105 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3106
0a2f5c1a 31072011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3108
3109 Fix some uses of `int' instead of EMACS_INT.
3110 * search.c (string_match_1, fast_string_match)
3111 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3112 (scan_buffer, find_next_newline_no_quit)
3113 (find_before_next_newline, search_command, Freplace_match)
3114 (Fmatch_data): Make some `int' variables be EMACS_INT.
3115
3116 * xdisp.c (display_count_lines): 3rd argument and return value now
3117 EMACS_INT. All callers changed.
3118 (pint2hrstr): Last argument is now EMACS_INT.
3119
3120 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3121 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3122 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3123 (decode_coding_utf_16, decode_coding_emacs_mule)
3124 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3125 (decode_coding_ccl, decode_coding_charset)
3126 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3127 (decode_coding_iso_2022, decode_coding_emacs_mule)
3128 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3129 <char_offset, last_offset>: Declare EMACS_INT.
3130 (encode_coding_utf_8, encode_coding_utf_16)
3131 (encode_coding_emacs_mule, encode_invocation_designation)
3132 (encode_designation_at_bol, encode_coding_iso_2022)
3133 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3134 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3135 Declare EMACS_INT.
3136 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3137 (encode_invocation_designation): Last argument P_NCHARS is now
3138 EMACS_INT.
3139 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3140 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3141
3142 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3143 All users changed.
3144
3145 * ccl.c (Fccl_execute_on_string): Declare some variables
3146 EMACS_INT.
3147
8546720e 31482011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3149
3150 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3151
4e19a977
CS
31522011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3153
3154 * process.c (Fformat_network_address): Doc fix.
3155
87302331
R
31562011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3157
3158 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3159
cbb59342
CY
31602011-04-08 Chong Yidong <cyd@stupidchicken.com>
3161
3162 * keyboard.c (read_char): Call Lisp function help-form-show,
3163 instead of using internal_with_output_to_temp_buffer.
3164 (Qhelp_form_show): New var.
e0d38eeb 3165 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3166
3167 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3168
3169 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3170
e67a13ab
CY
31712011-04-06 Chong Yidong <cyd@stupidchicken.com>
3172
04f2d78b
CB
3173 * process.c (Flist_processes): Remove to Lisp.
3174 (list_processes_1): Delete.
e67a13ab 3175
973f782d
EZ
31762011-04-06 Eli Zaretskii <eliz@gnu.org>
3177
7c106b1e
EZ
3178 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3179
973f782d
EZ
3180 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3181
41cf7d1a 31822011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3183
ca23cc88
PE
3184 Fix more problems found by GCC 4.6.0's static checks.
3185
f390e2d5
PE
3186 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3187
42eea0d0
PE
3188 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3189
b69769da 3190 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3191
f9541e84
PE
3192 * xdisp.c (vmessage): Mark as a printf-like function.
3193
13841b55
PE
3194 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3195
c136c10f
PE
3196 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3197
5e2d4a30
PE
3198 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3199 printf-like functions.
3200 (tiff_load): Add casts to remove these marks before passing them
3201 to system-supplied API.
3202
583f48b9
PE
3203 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3204
b25d760e
PE
3205 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3206 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3207 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3208 directly, rather than having caller test rule sign. This avoids
3209 some unnecessary tests.
3210 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3211 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3212 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3213
bc7b6697 3214 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3215 (xfont_open): Avoid unnecessary tests.
bc7b6697 3216
27ccc379
PE
3217 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3218
dcd5c89a
PE
3219 * composite.h, composite.c (composition_gstring_put_cache):
3220 Use EMACS_INT, not int, for length.
3221
b13a45c6
PE
3222 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3223 breaking out part of COMPOSITION_DECODE_RULE.
3224 (COMPOSITION_DECODE_RULE): Use it.
3225 * composite.c (get_composition_id): Remove unused local vars,
3226 by using the new macro.
3227
1e792e4d
PE
3228 * textprop.c (set_text_properties_1): Change while to do-while,
3229 since the condition is always true at first.
3230
dc6c6455 3231 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3232 (interval_deletion_adjustment): Return unsigned value.
3233 All uses changed.
dc6c6455 3234
aba7731a
PE
3235 * process.c (list_processes_1, create_pty, read_process_output):
3236 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3237 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3238 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3239 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3240 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3241
fdfc4bf3
PE
3242 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3243
fca8fe46 3244 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3245 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3246
06a0259a 3247 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3248 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3249 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3250
e7b9e80f
PE
3251 * print.c (print_error_message): Avoid int overflow.
3252
56201685
PE
3253 * font.c (font_list_entities): Redo for clarity,
3254 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3255
78834453 3256 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3257 (font_score): Avoid potential overflow in diff calculation.
78834453 3258
0bc0b309 3259 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3260 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3261
e610eaca
PE
3262 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3263
b895abce
PE
3264 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3265 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3266 can always succeed if overflow has undefined behavior.
3267
1f1d9321 3268 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3269 (wordify): Omit three unnecessary tests.
1f1d9321 3270
c59478bc
PE
3271 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3272 All callers changed. This avoids the need for an unused var.
3273
79b73827
PE
3274 * casefiddle.c (casify_region): Remove var that is set but not used.
3275
a4db5dfe
PE
3276 * dired.c (file_name_completion): Remove var that is set but not used.
3277
43aae36e
PE
3278 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3279
2a47c44d 3280 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3281 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3282
a37c69bf
PE
3283 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3284 Check for integer overflow on size calculations.
3285
328ab8e7
PE
3286 * buffer.c (Fprevious_overlay_change): Remove var that is set
3287 but not used.
3288
e5a2a5cb
PE
3289 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3290 Remove vars that are set but not used.
8d84a6eb 3291 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3292 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3293
a60e5f68
PE
3294 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3295
f661cb61 3296 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3297 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3298
f0397f5a
PE
3299 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3300 that are set but not used.
3301
8664db06 3302 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3303 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3304
6abdaa4a
PE
3305 * xselect.c (x_get_local_selection, x_handle_property_notify):
3306 Remove vars that are set but not used.
3307
0ce7538d 3308 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3309 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3310
9ae848fc
PE
3311 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3312 Remove var that is set but not used.
0b918413
PE
3313 (scroll_bar_windows_size): Now size_t, not int.
3314 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3315 Check for overflow.
9ae848fc 3316
a5a62657
PE
3317 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3318 (map_tty_color) [!defined MSDOS]: Likewise.
3319
5c5cdd39
PE
3320 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3321
66ebf983
PE
3322 * coding.c: Remove vars that are set but not used.
3323 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3324 All callers changed.
3325 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3326 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3327 (decode_coding_charset): Remove vars that are set but not used.
3328
1be4d761
PE
3329 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3330 that is set but not used.
3331
47553fa8
PE
3332 * print.c (print_object): Remove var that is set but not used.
3333
1f7196bf 3334 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3335 The gnulib version avoids calling malloc in the usual case,
3336 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3337 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3338 * filelock.c (current_lock_owner): Likewise.
3339 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3340 * sysdep.c: Include allocator.h, careadlinkat.h.
3341 (emacs_no_realloc_allocator): New static constant.
3342 (emacs_readlink): New function.
fdb61804
PE
3343 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3344 ../lib/careadlinkat.h.
d1fdcab7 3345
f84c17c7
SM
33462011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3347
3348 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3349 first non-nil return value).
3350
ef3862ad
JD
33512011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3352
3353 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3354 if not defined (Bug#8403).
3355
376a7006
JB
33562011-04-02 Juanma Barranquero <lekktu@gmail.com>
3357
3358 * xdisp.c (display_count_lines): Remove parameter `start',
3359 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3360 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3361 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3362 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3363 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3364 and thereabouts. All callers changed.
3365 (get_per_char_metric): Remove parameter `f', unused since
3366 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3367
6ca3801d
JM
33682011-04-02 Jim Meyering <meyering@redhat.com>
3369
3370 do not dereference NULL upon failed strdup
3371 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3372 (ns_get_family): Likewise.
3373
d8e2b5ba
JB
33742011-04-02 Juanma Barranquero <lekktu@gmail.com>
3375
3376 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3377
8c74fcbd
JD
33782011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3379
3380 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3381 later (Bug#8403).
3382
7200d79c
SM
33832011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3384
03408648 3385 Add lexical binding.
7200d79c 3386
03408648
SM
3387 * window.c (Ftemp_output_buffer_show): New fun.
3388 (Fsave_window_excursion):
3389 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3390
3391 * lread.c (lisp_file_lexically_bound_p): New function.
3392 (Fload): Bind Qlexical_binding.
3393 (readevalloop): Remove `evalfun' arg.
3394 Bind Qinternal_interpreter_environment.
3395 (Feval_buffer): Bind Qlexical_binding.
3396 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3397 Mark as dynamic.
3398 (syms_of_lread): Declare `lexical-binding'.
3399
3400 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3401
3402 * keyboard.c (eval_dyn): New fun.
3403 (menu_item_eval_property): Use it.
ca105506
SM
3404
3405 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3406
03408648
SM
3407 * fns.c (concat, mapcar1): Accept byte-code-functions.
3408
3409 * eval.c (Fsetq): Handle lexical vars.
3410 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3411 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3412 (FletX, Flet): Obey lexical binding.
3413 (Fcommandp): Handle closures.
3414 (Feval): New `lexical' arg.
3415 (eval_sub): New function extracted from Feval. Use it almost
3416 everywhere where Feval was used. Look up vars in lexical env.
3417 Handle closures.
3418 (Ffunctionp): Move from subr.el.
3419 (Ffuncall): Handle closures.
3420 (apply_lambda): Remove `eval_flags'.
3421 (funcall_lambda): Handle closures and new byte-code-functions.
3422 (Fspecial_variable_p): New function.
3423 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3424 but without exporting it to Lisp.
23aba0ea 3425
23aba0ea 3426 * doc.c (Fdocumentation, store_function_docstring):
03408648 3427 * data.c (Finteractive_form): Handle closures.
23aba0ea 3428
03408648
SM
3429 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3430 interactive spec.
ba83908c 3431
04f2d78b
CB
3432 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3433 New byte-codes.
03408648
SM
3434 (exec_byte_code): New function extracted from Fbyte_code to handle new
3435 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3436
03408648 3437 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3438
03408648 3439 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3440
e2abce01
JB
34412011-03-31 Juanma Barranquero <lekktu@gmail.com>
3442
3443 * xdisp.c (redisplay_internal): Fix prototype.
3444
63696a73 34452011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3446
63696a73 3447 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3448 (try_scrolling): Use it when setting scroll_limit.
3449 Limit scrolling to 100 screen lines.
63696a73
EZ
3450 (redisplay_window): Even when falling back on "recentering",
3451 position point in the window according to scroll-conservatively,
3452 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3453
3454 (try_scrolling): When point is above the window, allow searching
3455 as far as scroll_max, or one screenful, to compute vertical
3456 distance from PT to the scroll margin position. This prevents
3457 try_scrolling from unnecessarily failing when
3458 scroll-conservatively is set to a value slightly larger than the
3459 window height. Clean up the case of PT below the margin at bottom
3460 of window: scroll_max can no longer be INT_MAX. When aggressive
3461 scrolling is in use, don't let point enter the opposite scroll
3462 margin as result of the scroll.
3463 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3464 threshold of 100 lines for never-recentering scrolling.
3465
e4cc2dfc
JB
34662011-03-31 Juanma Barranquero <lekktu@gmail.com>
3467
3468 * dispextern.h (move_it_by_lines):
3469 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3470 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3471 (message_log_check_duplicate): Remove parameters `prev_bol' and
3472 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3473 (redisplay_internal): Remove parameter `preserve_echo_area',
3474 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3475
3476 * indent.c (Fvertical_motion):
3477 * window.c (window_scroll_pixel_based, Frecenter):
3478 Don't pass `need_y_p' to `move_it_by_lines'.
3479
1c470562
SM
34802011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3481
44f230aa
SM
3482 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3483 steal a few bits to be more compact.
3484 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3485 Remove unneeded casts.
3486
1c470562
SM
3487 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3488
888adce9
ZK
34892011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3490
3491 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3492 binding" message (bug#7967).
3493
f838ed7b
PE
34942011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3495
77861b95
PE
3496 Fix more problems found by GCC 4.6.0's static checks.
3497
de6dbc14
PE
3498 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3499 Remove unused local var.
3500
f838ed7b
PE
3501 * editfns.c (Fmessage_box): Remove unused local var.
3502
792c7b2b
PE
3503 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3504 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3505 Omit unused local vars.
c499e557 3506 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3507 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3508 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3509 Omit unused local var.
3510
ba0165e1
PE
3511 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3512 Don't assume string length fits in int.
32ad8845 3513 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3514 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3515
3c59b4c9
PE
3516 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3517 instead of alloca (Bug#8344).
3518
a3eed478 3519 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3520 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3521
eb4d412d
PE
3522 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3523
1658b401
PE
3524 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3525 concerns.
3526
3527 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3528
3529 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3530
9a2c6e05
PE
3531 * keyboard.c (syms_of_keyboard): Use the same style as later
3532 in this function when indexing through an array. This also
3533 works around GCC bug 48267.
3534
03d0a109
PE
3535 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3536
44f730c8
PE
3537 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3538
fe75f926
PE
3539 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3540 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3541
ffa8c828
PE
3542 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3543 This avoids undefined behavior on integer overflow, and is a bit
3544 more convenient anyway since it is compared to a size_t variable.
3545
c5101a77
PE
3546 Variadic C functions now count arguments with size_t, not int.
3547 This avoids an unnecessary limitation on 64-bit machines, which
3548 caused (substring ...) to crash on large vectors (Bug#8344).
3549 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3550 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3551 All variadic functions and their callers changed accordingly.
c5101a77
PE
3552 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3553 * data.c (arith_driver, float_arith_driver): Likewise.
3554 * editfns.c (general_insert_function): Likewise.
3555 * eval.c (struct backtrace.nargs, interactive_p)
3556 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3557 (funcall_lambda, mark_backtrace): Likewise.
3558 * fns.c (concat): Likewise.
3559 * frame.c (x_set_frame_parameters): Likewise.
3560 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3561 0 if not found, not -1. All callers changed.
3562
dd3f25f7
PE
3563 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3564 (stack_copy_size): Now size_t, not int.
3565 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3566
461c2ab9
JB
35672011-03-28 Juanma Barranquero <lekktu@gmail.com>
3568
3569 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3570 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3571 All callers changed.
3572
3573 * lisp.h (multibyte_char_to_unibyte):
3574 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3575 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3576 * character.h (CHAR_TO_BYTE8):
3577 * cmds.c (internal_self_insert):
3578 * editfns.c (general_insert_function):
3579 * keymap.c (push_key_description):
3580 * search.c (Freplace_match):
3581 * xdisp.c (message_dolog, set_message_1): All callers changed.
3582
f6d62986
SM
35832011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3584
3585 * keyboard.c (safe_run_hook_funcall): New function.
3586 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3587 don't set the hook to nil, but remove the offending function instead.
3588 (Qcommand_hook_internal): Remove, unused.
3589 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3590 Vcommand_hook_internal.
3591
3592 * eval.c (enum run_hooks_condition): Remove.
3593 (funcall_nil, funcall_not): New functions.
3594 (run_hook_with_args): Call each function through a `funcall' argument.
3595 Remove `cond' argument, now redundant.
3596 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3597 (Frun_hook_with_args_until_failure): Adjust accordingly.
3598 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3599
1db5b1ad
JB
36002011-03-28 Juanma Barranquero <lekktu@gmail.com>
3601
3602 * dispextern.h (string_buffer_position): Remove declaration.
3603
3604 * print.c (strout): Remove parameter `multibyte', unused since
3605 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3606
3607 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3608 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3609 All callers changed.
3610
3611 * w32.c (_wsa_errlist): Use braces for struct initializers.
3612
3613 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3614 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3615 All callers changed.
3616 (string_buffer_position): Likewise. Also, make static (it's never
3617 used outside xdisp.c).
3618 (cursor_row_p): Remove parameter `w', unused since
3619 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3620 (decode_mode_spec): Remove parameter `precision', introduced during
3621 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3622 All callers changed.
3623
5ffb62aa
JD
36242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3625
3626 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3627
461c2ab9 36282011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3629
3630 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3631 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3632 (ns_update_auto_hide_menu_bar): New functions.
3633 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3634 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3635 ns_constrain_all_frames.
3636 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3637 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3638
5c380ffb
JD
36392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3640
3641 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3642
9af30bdf
GM
36432011-03-27 Glenn Morris <rgm@gnu.org>
3644
3645 * syssignal.h: Replace RETSIGTYPE with void.
3646 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3647 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3648 Replace SIGTYPE with void everywhere.
3649 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3650 * s/template.h (SIGTYPE): Remove commented out definition.
3651
e2abce01
JB
36522011-03-26 Eli Zaretskii <eliz@gnu.org>
3653
3654 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3655 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3656
f868cd8a
JB
36572011-03-26 Juanma Barranquero <lekktu@gmail.com>
3658
59eb0929
JB
3659 * w32.c (read_unc_volume): Use parameter `henum', instead of
3660 global variable `wget_enum_handle'.
3661
3662 * keymap.c (describe_vector): Remove parameters `indices' and
3663 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3664 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3665
f868cd8a
JB
3666 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3667
3668 * keyboard.c (timer_check): Remove parameter `do_it_now',
3669 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3670 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3671 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3672
3673 * keyboard.c (read_char):
3674 * w32menu.c (w32_menu_display_help):
3675 * xmenu.c (show_help_event, menu_help_callback):
3676 Adjust calls to `show_help_echo'.
3677
3678 * gtkutil.c (xg_maybe_add_timer):
3679 * keyboard.c (readable_events):
3680 * process.c (wait_reading_process_output):
3681 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3682
3683 * insdel.c (adjust_markers_gap_motion):
3684 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3685 (gap_left, gap_right): Don't call it.
3686
2ecf6fdb
CY
36872011-03-25 Chong Yidong <cyd@stupidchicken.com>
3688
3689 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3690 incurred during fontification.
3691
6b1f9ba4
JB
36922011-03-25 Juanma Barranquero <lekktu@gmail.com>
3693
3694 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3695 (DEFVAR_PER_BUFFER): Don't pass it.
3696
3697 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3698 (scrolling_window): Don't pass it.
3699
0f4a96b5
JB
37002011-03-25 Juanma Barranquero <lekktu@gmail.com>
3701
3702 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3703
3704 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3705 and `suffix'.
3706 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3707 of variables specific to SELinux and computation of `encoded_absname'.
3708
3709 * image.c (XPutPixel): Remove unused variable `height'.
3710
3711 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3712
3713 * unexw32.c (get_section_info): Remove unused variable `section'.
3714
3715 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3716 (system_process_attributes): Remove unused variable `sess'.
3717 (sys_read): Remove unused variable `err'.
3718
3719 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3720 (w32_wnd_proc): Remove unused variable `isdead'.
3721 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3722 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3723 (x_create_tip_frame): Remove unused variable `tem'.
3724
3725 * w32inevt.c (w32_console_read_socket):
3726 Remove unused variable `no_events'.
3727
3728 * w32term.c (x_draw_composite_glyph_string_foreground):
3729 Remove unused variable `width'.
3730
1149507c
JB
37312011-03-24 Juanma Barranquero <lekktu@gmail.com>
3732
3733 * w32term.c (x_set_glyph_string_clipping):
3734 Don't pass uninitialized region to CombineRgn.
3735
9c88f339
JB
37362011-03-23 Juanma Barranquero <lekktu@gmail.com>
3737
3738 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3739 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3740 (Fx_close_connection): Remove unused variable `i'.
3741
3742 * w32font.c (w32font_draw): Return number of glyphs.
3743 (w32font_open_internal): Remove unused variable `i'.
3744 (w32font_driver): Add missing initializer.
3745
3746 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3747 (fill_in_menu): Remove unused variable `items_added'.
3748
3749 * w32term.c (last_mouse_press_frame): Remove static global variable.
3750 (w32_clip_to_row): Remove unused variable `f'.
3751 (x_delete_terminal): Remove unused variable `i'.
3752
3753 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3754 (NOTHING): Remove unused static global variable.
3755 (uniscribe_check_otf): Remove unused variable `table'.
3756 (uniscribe_font_driver): Add missing initializers.
3757
dee091a3
JD
37582011-03-23 Julien Danjou <julien@danjou.info>
3759
3760 * term.c (Fsuspend_tty, Fresume_tty):
3761 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3762 * window.c (temp_output_buffer_show):
3763 * insdel.c (signal_before_change):
3764 * frame.c (Fhandle_switch_frame):
3765 * fileio.c (Fdo_auto_save):
3766 * emacs.c (Fkill_emacs):
3767 * editfns.c (save_excursion_restore):
3768 * cmds.c (internal_self_insert):
3769 * callint.c (Fcall_interactively):
3770 * buffer.c (Fkill_all_local_variables):
3771 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3772 Use Frun_hooks.
0f4a96b5 3773 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3774 unconditionnaly since it does the check itself.
3775
2c520ab5 37762011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3777
c9c49752
PE
3778 Fix more problems found by GCC 4.5.2's static checks.
3779
8abc3f12
PE
3780 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3781 the first time through the loop, since we know p0 < p1 then.
3782 This also avoids a gcc -Wstrict-overflow warning.
3783
a2d26660
PE
3784 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3785 leading to a memory leak, possible in functions like
3786 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3787 of objects (Bug#8318).
a2d26660 3788
916c72e9
PE
3789 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3790 that could (at least in theory) be that large.
3791
19ab8a18
PE
3792 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3793 This is less likely to overflow, and avoids undefined behavior if
3794 overflow does occur. All callers changed. Use strtoul to scan
3795 for the unsigned long integer.
b7cbbd6f
PE
3796 (pint2hrstr): Simplify and tune code slightly.
3797 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3798
f0641eff
PE
3799 * scroll.c (do_scrolling): Work around GCC bug 48228.
3800 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3801
7f650bb9
PE
3802 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3803 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3804 (validate_x_resource_name): Simplify count usage.
3805 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3806
37dd57d1
PE
3807 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3808 fail (Bug#8306).
81e56e61 3809
699979fc 3810 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3811
401bf9b4
PE
3812 * process.c (Fmake_network_process): Use socklen_t, not int,
3813 where POSIX says socklen_t is required in portable programs.
3814 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3815 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3816 (Fmake_network_process, server_accept_connection):
3817 (wait_reading_process_output, read_process_output):
3818 Likewise.
3819
b93aacde
PE
3820 * process.c: Rename or move locals to avoid shadowing.
3821 (list_processes_1, Fmake_network_process):
3822 (read_process_output_error_handler, exec_sentinel_error_handler):
3823 Rename or move locals.
4dc343ee 3824 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3825 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3826 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3827 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3828 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3829
af8a867c 3830 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3831 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3832 Include tparam.h instead, since it declares them.
af8a867c
PE
3833 * cm.h (PC): Remove extern decl; tparam.h now does this.
3834 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3835 * terminfo.c: Include tparam.h, to check interfaces.
3836 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3837 (tparam): Adjust signature to match interface in tparam.h;
3838 this removes some undefined behavior. Check that outstring and len
3839 are zero, which they always are with Emacs.
3840 * tparam.h (PC, BC, UP): New extern decls.
3841
0248044d 3842 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3843 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3844
8ff096c1 3845 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3846 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3847 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3848 (ftfont_list): Remove unused local.
49eaafba
PE
3849 (get_adstyle_property, ftfont_pattern_entity):
3850 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3851 Rename locals to avoid shadowing.
8ff096c1 3852
e2be39f6
PE
3853 * xfont.c (xfont_list_family): Mark var as initialized.
3854
c9735e30
PE
3855 * xml.c (make_dom): Now static.
3856
8f5201ae
PE
3857 * composite.c (composition_compute_stop_pos): Rename local to
3858 avoid shadowing.
b246f932
PE
3859 (composition_reseat_it): Remove unused locals.
3860 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3861 (composition_update_it): Mark var as initialized.
11b61122
PE
3862 (find_automatic_composition): Mark vars as initialized,
3863 with a FIXME (Bug#8290).
8f5201ae 3864
760fbc2c
PE
3865 character.h: Rename locals to avoid shadowing.
3866 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3867 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3868 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3869 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3870 to avoid shadowing.
3871
ff08eb85
PE
3872 * textprop.c (property_change_between_p): Remove; unused.
3873
fc7bf025
PE
3874 * intervals.c (interval_start_pos): Now static.
3875
235d7abc
PE
3876 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3877
44f230aa
SM
3878 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3879 Rename locals to avoid shadowing.
3e7d6594 3880
50060332
PE
3881 * sound.c (wav_play, au_play, Fplay_sound_internal):
3882 Fix pointer signedness.
d01f234b 3883 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3884 (wav_play): Initialize a variable to 0, to prevent undefined
3885 behavior (Bug#8278).
50060332 3886
c4fc4e30
PE
3887 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3888
918436ed
PE
3889 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3890
c939f91b
PE
3891 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3892 clobbering (Bug#8298).
b9c7f648
PE
3893 * sysdep.c (sys_subshell): Likewise.
3894 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3895
6bd8c144
PE
3896 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3897 This should get cleaned up, so that child_setup has the
3898 same signature on all platforms.
3899
7710357c 3900 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3901 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3902
c59da222
CY
39032011-03-22 Chong Yidong <cyd@stupidchicken.com>
3904
3905 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3906 not to be necessary, and produces flickering.
3907
66b87493
GM
39082011-03-20 Glenn Morris <rgm@gnu.org>
3909
3910 * config.in: Remove file.
3911
45b6f6d5
JB
39122011-03-20 Juanma Barranquero <lekktu@gmail.com>
3913
3914 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3915 are now in src/globals.h.
3916 (syms_of_minibuf): Remove spurious & from previous change.
3917
3ec03f7e
LL
39182011-03-20 Leo <sdl.web@gmail.com>
3919
3920 * minibuf.c (completing-read-function): New variable.
3921 (completing-read-default): Rename from completing-read.
3922 (completing-read): Call completing-read-function.
3923
b14e3e21
CY
39242011-03-19 Juanma Barranquero <lekktu@gmail.com>
3925
3926 * xfaces.c (Fx_load_color_file):
3927 Read color file from absolute filename (bug#8250).
3928
f2b726e6
JB
39292011-03-19 Juanma Barranquero <lekktu@gmail.com>
3930
3931 * makefile.w32-in: Update dependencies.
3932
09f6ff02
EZ
39332011-03-17 Eli Zaretskii <eliz@gnu.org>
3934
3935 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3936
29a6015a
PE
39372011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3938
a3a6c54e
PE
3939 Fix more problems found by GCC 4.5.2's static checks.
3940
b766f867
PE
3941 * process.c (make_serial_process_unwind, send_process_trap):
3942 (sigchld_handler): Now static.
3943
be02381c
PE
3944 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3945 That way, the code declares only the vars that it needs.
3946 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3947 * s/cygwin.h (PTY_ITERATION): Likewise.
3948 * s/darwin.h (PTY_ITERATION): Likewise.
3949 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3950
57048744
PE
3951 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3952 * process.c (allocate_pty): Don't declare stb unless it's needed.
3953
7914961c 3954 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3955 (CONSTANTLIM): Remove; unused.
3956 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3957 Define only if needed.
7914961c 3958
b3967b18
PE
3959 * unexelf.c (unexec): Name an expression,
3960 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3961 Use a different way to cause a compilation error if anyone uses
3962 n rather than nn, a way that does not involve shadowing.
73366a00 3963 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3964
29a6015a
PE
3965 * deps.mk (unexalpha.o): Remove; unused.
3966
43cfc33e 3967 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3968 * unexec.h: New file.
ce701a33
PE
3969 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3970 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3971 Depend on unexec.h.
3972 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3973 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3974 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3975 Change as necessary to match prototype in unexec.h.
ce701a33 3976
01f44d5a
PE
3977 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3978 shadowing.
4f63c6bb 3979 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3980
a6670b0b
PE
3981 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3982 Rename locals to avoid shadowing.
3983
cef2010d 3984 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3985 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3986
d4d7173a
PE
3987 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3988
f08b802a
PE
3989 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3990 warning when compiling print.c.
3991
3ddb0639
PE
3992 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3993 instead of using an uninitialized var.
5ad03b97 3994 (font_sort_entities): Mark var as initialized.
3ddb0639 3995
170a2692
PE
3996 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3997
e663c700
PE
3998 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3999 pointers to constants.
89bc529a 4000 (font_parse_fcname): Remove unused vars.
7b81e2d0 4001 (font_delete_unmatched): Now static.
ea838e10 4002 (font_get_spec): Remove; unused.
13a547c6
PE
4003 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4004 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4005 Rename or move locals to avoid shadowing.
e663c700 4006
2a80c887 4007 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4008 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4009
1384fa33 4010 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4011 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4012
8b2c52e9
PE
4013 * alloc.c (mark_backtrace): Move decl from here ...
4014 * lisp.h: ... to here, so that it can be checked.
4015
475545b5 4016 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4017 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4018 (lisp_indirect_variable): Name an expression,
4019 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4020 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4021
b1349114 4022 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4023 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4024 Use const pointer when appropriate.
b1349114 4025
a2928364
PE
4026 * lisp.h (get_system_name, get_operating_system_release):
4027 Move decls here, to check interfaces.
4028 * process.c (get_operating_system_release): Move decl to lisp.h.
4029 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4030 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4031 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4032 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4033 (Fformat_time_string, Fencode_time, Finsert_char):
4034 (Ftranslate_region_internal, Fformat):
4035 Rename or remove local vars to avoid shadowing.
9710023e 4036 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4037
a415e694
PE
4038 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4039 avoid shadowing.
4040
8ef4622d
PE
4041 * lisp.h (eassert): Check that the argument compiles, even if
4042 ENABLE_CHECKING is not defined.
4043
946f9a5b
PE
4044 * data.c (Findirect_variable): Name an expression, to avoid
4045 gcc -Wbad-function-cast warning.
112396d6 4046 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4047 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4048 (Fmake_variable_buffer_local, Fmake_local_variable):
4049 Mark variables as initialized.
52746918 4050 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4051
e5aab7e7 4052 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4053 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4054 Rename locals to avoid shadowing.
dff45157
PE
4055 (mark_stack): Move local variables into the #ifdef region where
4056 they're used.
7bc26fdb
PE
4057 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4058 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4059 needed otherwise.
4060 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4061 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4062 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4063
e5aab7e7
PE
4064 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4065 avoids undefined behavior in theory.
4066
4da60324
PE
4067 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4068
88043301
PE
4069 Use functions, not macros, for up- and down-casing (Bug#8254).
4070 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4071 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4072 to use the following functions instead of these macros.
4073 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4074 EMACS_INT, since callers assume the returned value fits in int.
4075 (upcase1): Likewise, for UPCASE_TABLE.
4076 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4077 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4078 the race-condition problem in the old DOWNCASE.
88043301 4079
19ed5445
PE
4080 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4081 Rename locals to avoid shadowing.
4082 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4083 (regex_compile, re_search_2, re_match_2_internal):
4084 Remove unused local vars.
952db0d7
PE
4085 (FREE_VAR): Rewrite so as not to use empty "else",
4086 which gcc can warn about.
da053e48 4087 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4088 (RETALLOC_IF): Define only if needed.
4089 (WORDCHAR_P): Likewise. This one is never needed, but is used
4090 only in a comment talking about a compiler bug, so put inside
4091 the #if 0 of that comment.
4092 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4093 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4094 Remove; unused.
19ed5445 4095
1f3561e4 4096 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4097 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4098 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4099
ded6f8f7
PE
4100 * search.c (simple_search): Remove unused var.
4101
dbd37a95
PE
4102 * dired.c (compile_pattern): Move decl from here ...
4103 * lisp.h: ... to here, so that it can be checked.
4104 (struct re_registers): New forward decl.
4105
7e47afad
PE
4106 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4107
85f24f61
PE
4108 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4109 All uses changed.
4110 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4111 Rename locals to avoid shadowing.
5671df8f 4112 (Fvertical_motion): Mark locals as initialized.
85f24f61 4113
181aa2be 4114 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4115 (casify_region): Mark local as initialized.
181aa2be 4116
930d429c
PE
4117 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4118
7082eac6
PE
4119 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4120 New macros, so that the caller can use some names other than
4121 gcpro1, gcpro2, etc.
4122 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4123 of the new macros.
4124 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4125 argument, for consistency with GCPRO2_VAR, etc: it is now the
4126 prefix of the variable, not the variable itself. All uses
4127 changed.
38b2c076
PE
4128 * dired.c (directory_files_internal, file_name_completion):
4129 Rename locals to avoid shadowing.
4130
15206ed9
PE
4131 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4132 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4133 dired.c's scmp function, had undefined behavior.
4134 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4135 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4136 * buffer.h: ... to here, because these macros use current_buffer,
4137 and the new implementation with inline functions needs to have
4138 current_buffer in scope now, rather than later when the macros
4139 are used.
4140 (downcase, upcase1): New static inline functions.
4141 (DOWNCASE, UPCASE1): Reimplement using these functions.
4142 This avoids undefined behavior in expressions like
4143 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4144 from race conditions in accessing the global variables
4145 case_temp1 and case_temp2.
4146 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4147 * lisp.h (case_temp1, case_temp2): Remove their decls.
4148 * character.h (ASCII_CHAR_P): Move from here ...
4149 * lisp.h: ... to here, so that the inline functions mentioned
4150 above can use them.
4151
4a6bea26
PE
4152 * dired.c (directory_files_internal_unwind): Now static.
4153
f14b7e14
PE
4154 * fileio.c (file_name_as_directory, directory_file_name):
4155 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4156 Now static.
2893f146
PE
4157 (file_name_as_directory): Use const pointers when appropriate.
4158 (Fexpand_file_name): Likewise. In particular, newdir might
4159 point at constant storage, so make it a const pointer.
fd4ead52 4160 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4161 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4162 signedness issues.
f839df0c
PE
4163 (Fset_file_times, Finsert_file_contents, auto_save_error):
4164 Rename locals to avoid shadowing.
f14b7e14 4165
5716756e 4166 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4167 (Ftry_completion, Fall_completions): Rename or remove locals
4168 to avoid shadowing.
5716756e 4169
b4c3046a
PE
4170 * marker.c (bytepos_to_charpos): Remove; unused.
4171
b45db522
PE
4172 * lisp.h (verify_bytepos, count_markers): New decls,
4173 so that gcc does not warn that these functions aren't declared.
4174
85876d07
PE
4175 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4176 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4177 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4178 (copy_text): Remove unused local var.
85876d07 4179
03d78a21 4180 * filelock.c (within_one_second): Now static.
b3dd38ab 4181 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4182
5df8f01b
PE
4183 * buffer.c (fix_overlays_before): Mark locals as initialized.
4184 (fix_start_end_in_overlays): Likewise. This function should be
4185 simplified by using pointers-to-pointers, but that's a different
4186 matter.
b1d876f1 4187 (switch_to_buffer_1): Now static.
8f54f30a
PE
4188 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4189 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4190
a70072c9 4191 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4192 Fix pointer signedness issue.
edced198
PE
4193 (sys_subshell): Mark local as volatile if checking for lint,
4194 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4195 (MAXPATHLEN): Define only if needed.
a70072c9 4196
a0977c44
PE
4197 * process.c (serial_open, serial_configure): Move decls from here ...
4198 * systty.h: ... to here, so that they can be checked.
4199
a884fdcc
PE
4200 * fns.c (get_random, seed_random): Move extern decls from here ...
4201 * lisp.h: ... to here, so that they can be checked.
4202
604efe86 4203 * sysdep.c (reset_io): Now static.
b8950c94 4204 (wait_for_termination_signal): Remove; unused.
604efe86 4205
38fc62d9
PE
4206 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4207 (copy_keymap_item, append_key, push_text_char_description):
4208 Now static.
1004a21a 4209 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4210 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4211 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4212 (describe_map_tree):
4213 Rename locals to avoid shadowing.
38fc62d9 4214
2f2650da
PE
4215 * keyboard.c: Declare functions static if they are not used elsewhere.
4216 (echo_char, echo_dash, cmd_error, top_level_2):
4217 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4218 (read_char, kbd_buffer_get_event, make_lispy_position):
4219 (make_lispy_event, make_lispy_movement, apply_modifiers):
4220 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4221 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4222 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4223 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4224 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4225
a053e86c 4226 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4227 (mark_kboards): Move decl here ...
4228 * alloc.c (mark_kboards): ... from here.
a053e86c 4229
4752793e
PE
4230 * lisp.h (force_auto_save_soon): New decl.
4231
74f10ca7 4232 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4233 (DEFINE_DUMMY_FUNCTION): New macro.
4234 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4235 Use it.
c03cd23f
PE
4236 (main): Add casts to avoid warnings
4237 if GCC considers string literals to be constants.
74f10ca7 4238
022e70d4
PE
4239 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4240
59d6fe83
PE
4241 * dbusbind.c: Pointer signedness fixes.
4242 (xd_signature, xd_append_arg, xd_initialize):
4243 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4244 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4245 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4246 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4247
78320123
PE
4248 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4249 if GCC considers string literals to be constants.
49cebcca 4250 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4251
35ac2a97
SM
42522011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4253
fb103ca9
SM
4254 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4255 (print_preprocess, print_object): New macro to fix last change.
4256
35ac2a97
SM
4257 * print.c (print_preprocess): Don't forget font objects.
4258
62973b41
JB
42592011-03-16 Juanma Barranquero <lekktu@gmail.com>
4260
4261 * emacs.c (USAGE3): Doc fixes.
4262
0e48bb22
AS
42632011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4264
4265 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4266 structure.
4267
7684e57b
JB
42682011-03-14 Juanma Barranquero <lekktu@gmail.com>
4269
4270 * lisp.h (VWindow_system, Qfile_name_history):
4271 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4272 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4273 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4274
4275 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4276 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4277
4278 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4279 * w32console.c (detect_input_pending, read_input_pending)
4280 (encode_terminal_code):
4281 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4282 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4283 (w32_system_caret_y, Qfile_name_history):
4284 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4285 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4286 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4287 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4288 * w32proc.c (Qlocal, report_file_error):
4289 * w32term.c (Vwindow_system, updating_frame):
4290 * w32uniscribe.c (initialized, uniscribe_font_driver):
4291 Remove unneeded extern declarations.
4292
2aa46d6c
CY
42932011-03-14 Chong Yidong <cyd@stupidchicken.com>
4294
c96bbc66 4295 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4296
cffc6f3b
CY
42972011-03-13 Chong Yidong <cyd@stupidchicken.com>
4298
4299 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4300 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4301 These macros can no longer be used for assignment.
4302
44f230aa
SM
4303 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4304 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4305 (record_buffer_markers, fetch_buffer_markers): New functions for
4306 recording and fetching special buffer markers.
4307 (set_buffer_internal_1, set_buffer_temp): Use them.
4308
4309 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4310
4311 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4312
4313 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4314 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4315
4316 * xdisp.c (hscroll_window_tree):
4317 (reconsider_clip_changes): Use PT instead of BUF_PT.
4318
d251f04b
EZ
43192011-03-13 Eli Zaretskii <eliz@gnu.org>
4320
4321 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4322 $(EMACS_ROOT)/lib/intprops.h.
4323
f0c77cd1
PE
43242011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4325
3eca4629
PE
4326 Fix more problems found by GCC 4.5.2's static checks.
4327
7c86ee98
PE
4328 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4329 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4330 (xg_free_frame_widgets): Make it clear that a local variable is
4331 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4332 (gdk_window_get_screen): Make it clear that this macro is needed
4333 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4334 (int_gtk_range_get_value): New function, which avoids a diagnostic
4335 from gcc -Wbad-function-cast.
4336 (xg_set_toolkit_scroll_bar_thumb): Use it.
4337 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4338 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4339 (get_utf8_string, xg_get_file_with_chooser):
4340 Rename locals to avoid shadowing.
4341 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4342
41729b81
PE
4343 * xgselect.c (xg_select): Remove unused var.
4344
f0c77cd1
PE
4345 * image.c (four_corners_best): Mark locals as initialized.
4346 (gif_load): Initialize transparent_p to zero (Bug#8238).
4347 Mark another local as initialized.
ec6cf4c6 4348 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4349
ce0ad53d 4350 * image.c (clear_image_cache): Now static.
d5d5a617 4351 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4352 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4353 (x_edge_detection): Remove unnecessary cast that
4354 gcc -Wbad-function-cast diagnoses.
2037898d 4355 (gif_load): Fix pointer signedness.
6ae141d6
PE
4356 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4357 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4358
33383987 43592011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4360
d32df629
PE
4361 Improve quality of tests for time stamp overflow.
4362 For example, without this patch (encode-time 0 0 0 1 1
4363 1152921504606846976) returns the obviously-bogus value (-948597
4364 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4365 reports time overflow. See
4366 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4367 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4368 * editfns.c: Include limits.h and intprops.h.
4369 (TIME_T_MIN, TIME_T_MAX): New macros.
4370 (time_overflow): Move earlier, to before first use.
4371 (hi_time, lo_time): New functions, for an accurate test for
4372 out-of-range times.
4373 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4374 (Fget_internal_run_time): Don't assume time_t fits in int.
4375 (make_time): Use list2 instead of Fcons twice.
4376 (Fdecode_time): More accurate test for out-of-range times.
4377 (check_tm_member): New function.
4378 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4379 (lisp_time_argument): Don't rely on undefined left-shift and
4380 right-shift behavior when checking for time stamp overflow.
8be6f318 4381
fe31d94c
PE
4382 * editfns.c (time_overflow): New function, refactoring common code.
4383 (Fformat_time_string, Fdecode_time, Fencode_time):
4384 (Fcurrent_time_string): Use it.
4385
8be6f318
PE
4386 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4387 * dired.c (make_time): Move to ...
4388 * editfns.c (make_time): ... here.
4389 * systime.h: Note the move.
4390
09d9db2c 43912011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4392
126bc0dc
YM
4393 * fringe.c (update_window_fringes): Remove unused variables.
4394
c47cbdfd
YM
4395 * unexmacosx.c (copy_data_segment): Also copy __got section.
4396 (Bug#8223)
4397
7ac80be9
EZ
43982011-03-12 Eli Zaretskii <eliz@gnu.org>
4399
c96bbc66 4400 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4401 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4402 Constify `char *' arguments and their references according to
4403 prototypes in tparam.h.
4404
ecb0f94d 4405 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4406
7ac80be9
EZ
4407 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4408 Adapt all references accordingly.
4409
4410 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4411
ef1fd07e
TT
44122011-03-11 Tom Tromey <tromey@redhat.com>
4413
4414 * buffer.c (syms_of_buffer): Remove obsolete comment.
4415
7ef4b50c
EZ
44162011-03-11 Eli Zaretskii <eliz@gnu.org>
4417
4418 * termhooks.h (encode_terminal_code): Declare prototype.
4419
4420 * msdos.c (encode_terminal_code): Don't declare prototype.
4421
4422 * term.c (encode_terminal_code): Now external again, used by
4423 w32console.c and msdos.c.
4424
44f230aa
SM
4425 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4426 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4427
4b1ec863 44282011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4429
1714f52b 4430 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4431
4b1ec863
PE
4432 * fringe.c (update_window_fringes): Mark locals as initialized
4433 (Bug#8227).
4434 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4435
524c7aa6
PE
4436 * alloc.c (mark_fringe_data): Move decl from here ...
4437 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4438 to check its interface.
4439 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4440
a5c0af81 4441 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4442 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4443 (fontset_font): Mark local as initialized.
a9a06e0b 4444 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4445
b4716021
PE
4446 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4447
811e9bac 4448 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4449 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4450 (x_own_selection, Fx_disown_selection_internal): Rename locals
4451 to avoid shadowing.
4452 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4453
7e3ab302
PE
4454 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4455 so that the caller can use some name other than gcpro1.
4456 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4457 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4458 (Fx_backspace_delete_keys_p):
4459 Use them to avoid shadowing, and rename vars to avoid shadowing.
4460 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4461 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4462 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4463 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4464 Remove unused locals.
7e3ab302
PE
4465 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4466 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4467 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4468 macros.
f78faa98 4469
e2b13473
PE
4470 * xterm.h (x_mouse_leave): New decl.
4471
77f23912
PE
4472 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4473 Remove unused functions.
cdf4ba58
PE
4474 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4475 (x_calc_absolute_position): Now static.
7411c686 4476 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4477 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4478 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4479 unless they are used.
38d0b34a
PE
4480 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4481 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4482 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4483 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4484 (x_error_catcher, x_connection_closed, x_error_handler):
4485 (x_error_quitter, xembed_send_message, x_iconify_frame):
4486 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4487 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4488 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4489
44f230aa
SM
4490 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4491 Rename or move locals to avoid shadowing.
6b463e58 4492 (tty_defined_color, merge_face_heights): Now static.
5967d051 4493 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4494 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4495 does not deduce is never used uninitialized.
73719eba
PE
4496 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4497 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4498
426994c3 4499 * terminal.c (store_terminal_param): Now static.
5489860b 4500
032f1620 4501 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4502 (set_frame_menubar): Remove unused local.
d4323972 4503 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4504 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4505 since they might point to immutable storage.
281585b0
PE
4506 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4507 since it's unused otherwise.
032f1620 4508
367c19e5 4509 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4510 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4511 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4512 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4513 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4514 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4515 does not deduce are never used uninitialized.
70739cbe 4516
07b48fa9
PE
4517 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4518
8868a238 4519 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4520 * window.c (window_loop, size_window):
4521 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4522
7e5cf297 4523 * window.c (display_buffer): Now static.
d6550a9f
PE
4524 (size_window): Mark variables that gcc -Wuninitialized
4525 does not deduce are never used uninitialized.
a586633d
PE
4526 * window.h (check_all_windows): New decl, to forestall
4527 gcc -Wmissing-prototypes diagnostic.
5b555da1 4528 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4529
f6095868
PE
4530 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4531 shadowing.
4532 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4533 Include <limits.h>.
4534 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4535 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4536 (load_charset_map): Mark variables that gcc -Wuninitialized
4537 does not deduce are never used uninitialized.
53df7c11 4538 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4539
f38b440c
PE
4540 * coding.c (coding_set_source, coding_set_destination):
4541 Use "else { /* comment */ }" rather than "else /* comment */;"
4542 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4543 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4544 a block, when the outer 'i' will do.
4545 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4546 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4547 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4548 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4549 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4550 Rename locals to avoid shadowing.
4551 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4552 * coding.c (emacs_mule_char, encode_invocation_designation):
4553 Now static, since they're not used elsewhere.
413bb2db 4554 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4555 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4556 (decode_coding_emacs_mule): Mark variables that gcc
4557 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4558 (detect_coding_iso_2022): Initialize a local variable that might
4559 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4560 this initialization is needed. (Bug#8211)
5f58e762
PE
4561 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4562 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4563 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4564 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4565 Remove unused macros.
f38b440c 4566
232b38b9 4567 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4568 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4569 * character.c (string_count_byte8): Likewise.
232b38b9 4570
fb90da1b
PE
4571 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4572 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4573
fb93dbc2
PE
4574 * chartab.c (copy_sub_char_table): Now static, since it's not used
4575 elsewhere.
5c156ace
PE
4576 (sub_char_table_ref_and_range, char_table_ref_and_range):
4577 Rename locals to avoid shadowing.
bbcd0949 4578 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4579
7d3b3862 4580 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4581 (BIDI_BOB): Remove unused macro.
7d3b3862 4582
6be7d3da
PE
4583 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4584 deduce are never used uninitialized.
c2ed9c8b 4585 * term.c (encode_terminal_code): Likewise.
6be7d3da 4586
75f8807f 4587 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4588
50938595
PE
4589 * tparam.h: New file.
4590 * term.c, tparam.h: Include it.
4591 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4592 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4593 Move these decls to tparam.h, and make them agree with what
4594 is actually in tparam.c. The previous trick of using incompatible
4595 decls in different modules does not conform to the C standard.
4596 All callers of tparam changed to use tparam's actual API.
4597 * tparam.c (tparam1, tparam, tgoto):
4598 Use const pointers where appropriate.
4599
fbceeba2
PE
4600 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4601 * cm.h (struct cm): Likewise.
4602 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4603 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4604 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4605 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4606 (turn_on_face, init_tty): Likewise.
4607 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4608
7f3f1250
PE
4609 * term.c (term_mouse_position): Rename local to avoid shadowing.
4610
e6ca6543
PE
4611 * alloc.c (mark_ttys): Move decl from here ...
4612 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4613
c40f8d15
AS
46142011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4615
4616 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4617
cfe0661d
JB
46182011-03-09 Juanma Barranquero <lekktu@gmail.com>
4619
4620 * search.c (compile_pattern_1): Remove argument regp, unused since
4621 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4622 (compile_pattern): Don't pass it.
4623
0afb4571
J
46242011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4625
4626 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4627 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4628 for ! HAVE_GTK3.
4629 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4630
4631 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4632
4633 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4634 gdk_window_get_screen, gdk_window_get_geometry,
4635 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4636 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4637 (xg_get_pixbuf_from_pixmap): New function.
4638 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4639 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4640 Call xg_get_pixbuf_from_pixmap instead of
4641 gdk_pixbuf_get_from_drawable.
4642 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4643 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4644 (xg_check_special_colors): Use GtkStyleContext and its functions
4645 for HAVE_GTK3.
4646 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4647 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4648 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4649 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4650 Call gtk_widget_get_preferred_size.
0afb4571
J
4651 (xg_frame_resized): gdk_window_get_geometry only takes 5
4652 parameters.
44f230aa
SM
4653 (xg_win_to_widget, xg_event_is_for_menubar):
4654 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4655 (xg_set_widget_bg): New function.
4656 (delete_cb): New function.
895009e1 4657 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4658 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4659 (xg_set_background_color): Call xg_set_widget_bg.
4660 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4661 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4662 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4663 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4664 if ! HAVE_GTK3.
4665 (update_frame_tool_bar): Call gtk_widget_hide.
4666 (xg_initialize): Use GDK_KEY_g.
4667
4668 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4669 if ! HAVE_GTK3
4670 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4671
4672 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4673 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4674 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4675
1c2cc4ef
JB
46762011-03-08 Juanma Barranquero <lekktu@gmail.com>
4677
4678 * w32xfns.c (select_palette): Check success of RealizePalette against
4679 GDI_ERROR, not zero.
4680
33383987 4681See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4682
4683;; Local Variables:
4684;; coding: utf-8
aac0c6e3
MR
4685;; End:
4686
33383987 4687 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4688
4689 This file is part of GNU Emacs.
4690
4691 GNU Emacs is free software: you can redistribute it and/or modify
4692 it under the terms of the GNU General Public License as published by
4693 the Free Software Foundation, either version 3 of the License, or
4694 (at your option) any later version.
4695
4696 GNU Emacs is distributed in the hope that it will be useful,
4697 but WITHOUT ANY WARRANTY; without even the implied warranty of
4698 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4699 GNU General Public License for more details.
4700
4701 You should have received a copy of the GNU General Public License
4702 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.