* profiler.c (Fprofiler_cpu_start): Remove unnecessary flag SA_SIGINFO.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3670daf7
TM
12012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
2
3 * profiler.c (Fprofiler_cpu_start): Remove unnecessary flag SA_SIGINFO.
4
6a586b7f
JB
52012-09-26 Juanma Barranquero <lekktu@gmail.com>
6
7 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
8
41c8bfcf
PE
92012-09-26 Paul Eggert <eggert@cs.ucla.edu>
10
11 * character.h (MAYBE_UNIFY_CHAR): Remove.
12 * charset.c, charset.h (maybe_unify_char): Now static.
13 * charset.c (decode_char): Use maybe_unify_char, not MAYBE_UNIFY_CHAR.
14 Since this stuff is now private to charset.c, there's no need for
15 a public macro and no need to inline by hand.
16
3a880af4
SM
172012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
18 Stefan Monnier <monnier@iro.umontreal.ca>
19 Juanma Barranquero <lekktu@gmail.com>
611b7507 20
3a880af4
SM
21 * profiler.c: New file.
22 * Makefile.in (base_obj): Add profiler.o.
611b7507
JB
23 * makefile.w32-in (OBJ2, GLOBAL_SOURCES): Add profiler.c.
24 ($(BLD)/profiler.$(O)): New target.
3a880af4
SM
25 * emacs.c (main): Call syms_of_profiler.
26 * alloc.c (Qautomatic_gc): New constant.
27 (MALLOC_PROBE): New macro.
28 (xmalloc, xzalloc, xrealloc, lisp_malloc, lisp_align_malloc): Use it.
29 (total_bytes_of_live_objects): New function.
30 (Fgarbage_collect): Use it. Record itself in backtrace_list.
31 Call malloc_probe for the memory profiler.
32 (syms_of_alloc): Define Qautomatic_gc.
33 * eval.c (eval_sub, Ffuncall): Reorder assignments to avoid
34 race condition.
35 (struct backtrace): Move definition...
36 * lisp.h (struct backtrace): ..here.
37 (Qautomatic_gc, profiler_memory_running): Declare vars.
38 (malloc_probe, syms_of_profiler): Declare functions.
39 * xdisp.c (Qautomatic_redisplay): New constant.
40 (redisplay_internal): Record itself in backtrace_list.
41 (syms_of_xdisp): Define Qautomatic_redisplay.
611b7507 42
b67238c2
JB
432012-09-25 Juanma Barranquero <lekktu@gmail.com>
44
45 * makefile.w32-in ($(BLD)/callproc.$(O)): Update dependencies.
46
e26fd2e4
PE
472012-09-25 Paul Eggert <eggert@cs.ucla.edu>
48
49 Prefer POSIX timers if available.
50 They avoid a race if the timer is too close to the current time.
51 * atimer.c (alarm_timer, alarm_timer_ok) [SIGEV_SIGNAL]: New static vars.
52 (set_alarm) [SIGEV_SIGNAL]: Use POSIX timers if available.
9180598c 53 (init_atimer) [SIGEV_SIGNAL]: Initialize them.
e26fd2e4 54
eedec3ee
EZ
552012-09-25 Eli Zaretskii <eliz@gnu.org>
56
57 * coding.c (CHAR_STRING_ADVANCE_NO_UNIFY): Make it an alias of
58 CHAR_STRING_ADVANCE.
59 (STRING_CHAR_ADVANCE_NO_UNIFY): Make it an alias of
60 STRING_CHAR_ADVANCE.
61
aa15c6bb
JB
622012-09-25 Juanma Barranquero <lekktu@gmail.com>
63
64 Move Vlibrary_cache to emacs.c and reset before dumping.
65
66 * lisp.h (reset_image_types): Declare.
67 [WINDOWSNT] (Vlibrary_cache): Declare.
68
69 * image.c (reset_image_types): New function.
70
71 * emacs.c [WINDOWSNT] (Vlibrary_cache): Move from w32.c.
72 (syms_of_emacs) [WINDOWSNT] <Vlibrary_cache>: Initialize and staticpro.
73 (Fdump_emacs): Reset Vlibrary_cache and image_types.
74
75 * w32.c (Vlibrary_cache): Do not define; moved to emacs.c
76 (globals_of_w32) <Vlibrary_cache>: Do not initialize.
77
78 * w32.h (Vlibrary_cache): Do not declare.
79
54d629be
EZ
802012-09-25 Eli Zaretskii <eliz@gnu.org>
81
16b22fef
EZ
82 * w32proc.c (sys_signal): Handle all signals defined by the
83 MS-Windows runtime, not just SIGCHLD. Actually install the signal
84 handlers for signals supported by Windows. Don't override
85 term_ntproc as the handler for SIGABRT.
86 (sigaction): Rewrite to call sys_signal instead of duplicating its
87 code.
88 (sys_kill): Improve commentary.
89
90 * w32.c (term_ntproc): Accept (and ignore) one argument, for
91 consistency with a signature of a signal handler. All callers
92 changed.
93 (init_ntproc): Accept an argument DUMPING. If dumping, don't
94 install term_ntproc as a signal handler for SIGABRT, as that
95 should be done by the dumped Emacs.
96
97 * w32.h (init_ntproc, term_ntproc): Adjust prototypes.
98
99 * w32select.c (term_w32select): Protect against repeated
100 invocation by setting clipboard_owner to NULL after calling
101 DestroyWindow.
102
103 * emacs.c (shut_down_emacs, main): Adapt the calls to init_ntproc
104 and term_ntproc to their modified signatures.
105
54d629be
EZ
106 * character.c (char_string, string_char): Remove calls to
107 MAYBE_UNIFY_CHAR. See the discussion starting at
108 http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00433.html
109 for the details.
110
59f7af81
CY
1112012-09-25 Chong Yidong <cyd@gnu.org>
112
113 * xdisp.c (mode_line_inverse_video): Delete obsolete variable.
114
22e8cf4a
SM
1152012-09-24 Stefan Monnier <monnier@iro.umontreal.ca>
116
117 * bytecode.c (exec_byte_code): Signal an error instead of aborting,
118 when encountering an unknown bytecode.
119
578098f3
PE
1202012-09-24 Paul Eggert <eggert@cs.ucla.edu>
121
122 image.c, indent.c: Use bool for booleans.
123 * dispextern.h (struct image_type): Members valid_p, load, init
124 now return bool, not int. All uses changed.
125 * image.c: Omit unnecessary static decls.
126 (x_create_bitmap_mask, x_build_heuristic_mask):
127 Return void, not int, since callers don't care about the return value.
128 (x_create_bitmap_mask, define_image_type, valid_image_p)
129 (struct image_keyword, parse_image_spec, image_spec_value)
130 (check_image_size, image_background)
131 (image_background_transparent, x_clear_image_1)
132 (postprocess_image, lookup_image, x_check_image_size)
133 (x_create_x_image_and_pixmap, xbm_image_p)
134 (Create_Pixmap_From_Bitmap_Data, xbm_read_bitmap_data)
135 (xbm_load_image, xbm_file_p, xbm_load, xpm_lookup_color)
136 (init_xpm_functions, xpm_valid_color_symbols_p, xpm_image_p)
137 (xpm_load, xpm_load_image, lookup_rgb_color, lookup_pixel_color)
138 (x_to_xcolors, x_build_heuristic_mask, pbm_image_p, pbm_load)
139 (png_image_p, init_png_functions, png_load_body, png_load)
140 (jpeg_image_p, init_jpeg_functions, jpeg_load_body, jpeg_load)
141 (tiff_image_p, init_tiff_functions, tiff_load, gif_image_p)
142 (init_gif_functions, gif_load, imagemagick_image_p)
143 (imagemagick_load_image, imagemagick_load, svg_image_p)
144 (init_svg_functions, svg_load, svg_load_image, gs_image_p)
145 (gs_load):
146 * nsimage.m (ns_load_image):
147 * nsterm.m (ns_defined_color):
148 * xfaces.c (tty_lookup_color, tty_defined_color, defined_color):
149 * xfns.c (x_defined_color):
150 * xterm.c (x_alloc_lighter_color_for_widget)
151 (x_alloc_nearest_color_1, x_alloc_nearest_color)
152 (x_alloc_lighter_color):
153 * indent.c (disptab_matches_widthtab, current_column)
154 (scan_for_column, string_display_width, indented_beyond_p)
155 (compute_motion, vmotion, Fvertical_motion):
156 Use bool for booleans.
157
a5f2b6ec
CY
1582012-09-24 Chong Yidong <cyd@gnu.org>
159
160 * chartab.c (Fset_char_table_default): Obsolete function removed.
161
18e27ea8
PE
1622012-09-23 Paul Eggert <eggert@cs.ucla.edu>
163
afea8a8a
PE
164 Move pid_t related decls out of lisp.h.
165 * lisp.h, syswait.h (record_child_status_change, wait_for_termination)
166 (interruptible_wait_for_termination):
167 Move these decls from lisp.h to syswait.h, since they use pid_t.
168 Needed on FreeBSD; see Herbert J. Skuhra in
169 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00571.html>.
170 * callproc.c: Include syswait.h.
171
18e27ea8
PE
172 gnutls.c, gtkutil.c: Use bool for boolean.
173 * gnutls.c (gnutls_global_initialized, init_gnutls_functions)
174 (emacs_gnutls_handle_error):
175 * gtkutil.c (xg_check_special_colors, xg_prepare_tooltip)
176 (xg_hide_tooltip, xg_create_frame_widgets)
177 (create_dialog, xg_uses_old_file_dialog)
178 (xg_get_file_with_chooser, xg_get_file_with_selection)
179 (xg_get_file_name, xg_have_tear_offs, create_menus, xg_create_widget)
180 (xg_item_label_same_p, xg_update_menubar)
181 (xg_modify_menubar_widgets, xg_event_is_for_menubar)
182 (xg_ignore_gtk_scrollbar, xg_set_toolkit_scroll_bar_thumb)
183 (xg_event_is_for_scrollbar, xg_pack_tool_bar, xg_make_tool_item)
184 (is_box_type, xg_tool_item_stale_p, xg_update_tool_bar_sizes)
185 (update_frame_tool_bar, free_frame_tool_bar):
186 * gtkutil.c, w32term.c, xterm.c (x_wm_set_size_hint):
187 * nsmenu.m (ns_update_menubar):
188 * nsmenu.m, w32menu.c, xmenu.c (set_frame_menubar):
189 * xfns.c (Fx_show_tip) [USE_GTK]:
190 Use bool for boolean.
191 * gtkutil.c (xg_update_frame_menubar):
192 * xmenu.c (update_frame_menubar):
193 Return void, not int, since caller ignores return value.
194 * gtkutil.c (xg_change_toolbar_position):
195 Return void, not 1.
196
af0e9f75
JB
1972012-09-23 Juanma Barranquero <lekktu@gmail.com>
198
199 * makefile.w32-in (BLOCKINPUT_H): Remove.
200 (SYSSIGNAL_H): New macro.
201 ($(BLD)/alloc.$(O), $(BLD)/atimer.$(O), $(BLD)/buffer.$(O))
202 ($(BLD)/callproc.$(O), $(BLD)/data.$(O), $(BLD)/dired.$(O))
203 ($(BLD)/dispnew.$(O), $(BLD)/editfns.$(O), $(BLD)/emacs.$(O))
204 ($(BLD)/eval.$(O), $(BLD)/fileio.$(O), $(BLD)/floatfns.$(O))
205 ($(BLD)/fns.$(O), $(BLD)/fontset.$(O), $(BLD)/frame.$(O))
206 ($(BLD)/fringe.$(O), $(BLD)/image.$(O), $(BLD)/insdel.$(O))
207 ($(BLD)/keyboard.$(O), $(BLD)/keymap.$(O), $(BLD)/lread.$(O))
208 ($(BLD)/menu.$(O), $(BLD)/w32inevt.$(O), $(BLD)/w32proc.$(O))
209 ($(BLD)/print.$(O), $(BLD)/process.$(O), $(BLD)/ralloc.$(O))
210 ($(BLD)/search.$(O), $(BLD)/sound.$(O), $(BLD)/sysdep.$(O))
211 ($(BLD)/term.$(O), $(BLD)/window.$(O), $(BLD)/xdisp.$(O))
212 ($(BLD)/xfaces.$(O), $(BLD)/w32fns.$(O), $(BLD)/w32menu.$(O))
213 ($(BLD)/w32term.$(O), $(BLD)/w32select.$(O), $(BLD)/w32reg.$(O))
214 ($(BLD)/w32xfns.$(O)): Update dependencies.
215
5101529e
EZ
2162012-09-23 Eli Zaretskii <eliz@gnu.org>
217
218 * .gdbinit: Set breakpoint on terminate_due_to_signal, not on
219 fatal_error_backtrace.
220
221 * w32proc.c (sys_kill): Undo last change: don't do anything when
222 invoked to deliver SIGABRT to our own process. This is now
223 handled by emacs_raise.
224
2c3ee0ad
JB
2252012-09-23 Juanma Barranquero <lekktu@gmail.com>
226
227 * w32term.c (w32_read_socket): Remove leftover reference to
228 interrupt_input_pending.
229
62a1d661
PE
2302012-09-23 Paul Eggert <eggert@cs.ucla.edu>
231
232 Do not use SA_NODEFER.
233 Problem reported by Dani Moncayo in
234 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00557.html>.
235 * alloc.c (die):
236 * sysdep.c (emacs_abort): Do not reset signal handler.
237 * emacs.c (terminate_due_to_signal): Reset signal handler here.
238 * sysdep.c (init_signals): Do not use SA_NODEFER. It wasn't
239 wanted even on POSIXish hosts, and it doesn't work on Windows.
240
a0942b9a
JD
2412012-09-23 Jan Djärv <jan.h.d@swipnet.se>
242
243 * xterm.c (x_term_init): Call fixup_locale before and after calling
244 gtk_init (Bug#12392).
245
d07ff9db
CY
2462012-09-23 Chong Yidong <cyd@gnu.org>
247
248 * w32.c (w32_delayed_load): Remove LIBRARIES argument; always use
249 Vdynamic_library_alist.
250
251 * gnutls.c (init_gnutls_functions): Caller changed; remove arg.
252 (Fgnutls_available_p): Caller changed.
253
254 * xml.c (init_libxml2_functions, Flibxml_parse_html_region)
255 (Flibxml_parse_xml_region): Likewise.
256
257 * dispextern.h (struct image_type): Remove arg from init function.
258
259 * image.c (Finit_image_library, lookup_image_type)
260 (define_image_type): Remove now-unneeded second arg.
261 (init_xpm_functions, init_png_functions, init_jpeg_functions)
262 (init_tiff_functions, init_gif_functions, init_svg_functions):
263 Arglist and w32_delayed_load calling convention changed.
264 (gs_type): Remove init_gs_functions; there is no such function.
641cfd14 265 (valid_image_p, make_image): Fix caller to lookup_image_type.
d07ff9db 266
4d7e6e51
PE
2672012-09-23 Paul Eggert <eggert@cs.ucla.edu>
268
269 Simplify and avoid signal-handling races (Bug#12471).
270 * alloc.c (die):
271 * sysdep.c (emacs_abort) [HAVE_NTGUI]:
272 Avoid recursive loop if there's a fatal error in the function itself.
273 * atimer.c (pending_atimers):
274 * blockinput.h: Don't include "atimer.h"; no longer needed.
275 (interrupt_input_pending): Remove. All uses removed.
276 pending_signals now counts both atimers and ordinary interrupts.
277 This is less racy than having three separate pending-signal flags.
278 (block_input, unblock_input, totally_unblock_input, unblock_input_to)
279 (input_blocked_p):
280 Rename from their upper-case counterparts BLOCK_INPUT,
281 UNBLOCK_INPUT, TOTALLY_UNBLOCK_INPUT, UNBLOCK_INPUT_TO,
282 INPUT_BLOCKED_P, and turn into functions. All uses changed.
283 This makes it easier to access volatile variables more accurately.
284 (BLOCK_INPUT_RESIGNAL): Remove. All uses replaced by unblock_input ().
285 (input_blocked_p): Prefer this to 'interrupt_input_blocked', as
286 that's more reliable if the code is buggy and sets
287 interrupt_input_blocked to a negative value. All uses changed.
288 * atimer.c (deliver_alarm_signal):
289 Remove. No need to deliver this to the parent; any thread can
290 handle this signal now. All uses replaced by underlying handler.
291 * atimer.c (turn_on_atimers):
292 * dispnew.c (handle_window_change_signal):
293 * emacs.c (handle_danger_signal):
294 * keyboard.c (kbd_buffer_get_event):
295 Don't reestablish signal handler; not needed with sigaction.
296 * blockinput.h (UNBLOCK_INPUT_TO, TOTALLY_UNBLOCK_INPUT)
297 (UNBLOCK_INPUT_TO):
298 Rework to avoid unnecessary accesses to volatile variables.
299 (UNBLOCK_INPUT_TO): Now a function.
300 (totally_unblock_input, unblock_input): New decls.
301 * data.c (handle_arith_signal, deliver_arith_signal): Move to sysdep.c
302 (init_data): Remove. Necessary stuff now done in init_signal.
303 * emacs.c, xdisp.c: Include "atimer.h", since we invoke atimer functions.
304 * emacs.c (handle_fatal_signal, deliver_fatal_signal): Move to sysdep.c.
305 (fatal_error_code): Remove; no longer needed.
306 (terminate_due_to_signal): Rename from fatal_error_backtrace, since
307 it doesn't always backtrace. All uses changed. No need to reset
308 signal to default, since sigaction and/or die does that for us now.
309 Use emacs_raise (FOO), not kill (getpid (), FOO).
310 (main): Check more-accurately whether we're dumping.
311 Move fatal-error setup to sysdep.c
312 * floatfns.c: Do not include "syssignal.h"; no longer needed.
313 * gtkutil.c (xg_get_file_name, xg_get_font):
314 Remove no-longer-needed signal-mask manipulation.
315 * keyboard.c, process.c (POLL_FOR_INPUT):
316 Don't depend on USE_ASYNC_EVENTS, a symbol that is never defined.
317 * keyboard.c (read_avail_input): Remove.
318 All uses replaced by gobble_input.
319 (Ftop_level): Use TOTALLY_UNBLOCK_INPUT rather than open code.
320 (kbd_buffer_store_event_hold, gobble_input):
321 (record_asynch_buffer_change) [USABLE_SIGIO]:
322 (store_user_signal_events):
323 No need to mess with signal mask.
324 (gobble_input): If blocking input and there are terminals, simply
325 set pending_signals to 1 and return. All hooks changed to not
326 worry about whether input is blocked.
327 (process_pending_signals): Clear pending_signals before processing
328 them, in case a signal comes in while we're processing.
329 By convention callers now test pending_signals before calling us.
330 (UNBLOCK_INPUT_TO, unblock_input, totally_unblock_input):
331 New functions, to support changes to blockinput.h.
332 (handle_input_available_signal): Now extern.
333 (reinvoke_input_signal): Remove. All uses replaced by
334 handle_async_input.
335 (quit_count): Now volatile, since a signal handler uses it.
3a880af4
SM
336 (handle_interrupt): Now takes bool IN_SIGNAL_HANDLER as arg.
337 All callers changed. Block SIGINT only if not already blocked.
4d7e6e51
PE
338 Clear sigmask reliably, even if Fsignal returns, which it can.
339 Omit unnecessary accesses to volatile var.
340 (quit_throw_to_read_char): No need to restore sigmask.
341 * keyboard.c (gobble_input, handle_user_signal):
342 * process.c (wait_reading_process_output):
343 Call signal-handling code rather than killing ourselves.
344 * lisp.h: Include <float.h>, for...
345 (IEEE_FLOATING_POINT): New macro, moved here to avoid duplication.
346 (pending_signals): Now volatile.
347 (syms_of_data): Now const if IEEE floating point.
348 (handle_input_available_signal) [USABLE_SIGIO]:
349 (terminate_due_to_signal, record_child_status_change): New decls.
350 * process.c (create_process): Avoid disaster if memory is exhausted
351 while we're processing a vfork, by tightening the critical section
352 around the vfork.
353 (send_process_frame, process_sent_to, handle_pipe_signal)
354 (deliver_pipe_signal): Remove. No longer needed, as Emacs now
355 ignores SIGPIPE.
356 (send_process): No need for setjmp/longjmp any more, since the
357 SIGPIPE stuff is now gone. Instead, report an error if errno
358 is EPIPE.
359 (record_child_status_change): Now extern. PID and W are now args.
360 Return void, not bool. All callers changed.
361 * sysdep.c (wait_debugging) [(BSD_SYSTEM || HPUX) && !defined (__GNU__)]:
362 Remove. All uses removed. This bug should be fixed now in a
363 different way.
364 (wait_for_termination_1): Use waitpid rather than sigsuspend,
365 and record the child status change directly. This avoids the
366 need to futz with the signal mask.
367 (process_fatal_action): Move here from emacs.c.
368 (emacs_sigaction_flags): New function, containing
369 much of what used to be in emacs_sigaction_init.
370 (emacs_sigaction_init): Use it. Block nonfatal system signals that are
371 caught by emacs, to make races less likely.
372 (deliver_process_signal): Rename from handle_on_main_thread.
373 All uses changed.
374 (BACKTRACE_LIMIT_MAX): Now at top level.
375 (thread_backtrace_buffer, threadback_backtrace_pointers):
376 New static vars.
377 (deliver_thread_signal, deliver_fatal_thread_signal):
378 New functions, for more-accurate delivery of thread-specific signals.
379 (handle_fatal_signal, deliver_fatal_signal): Move here from emacs.c.
380 (deliver_arith_signal): Handle in this thread, not
381 in the main thread, since it's triggered by this thread.
382 (maybe_fatal_sig): New function.
383 (init_signals): New arg DUMPING so that we can be more accurate
384 about whether we're dumping. Caller changed.
385 Treat thread-specific signals differently from process-general signals.
386 Block all signals while handling fatal error; that's safer.
387 xsignal from SIGFPE only on non-IEEE hosts, treating it as fatal
388 on IEEE hosts.
389 When batch, ignore SIGHUP, SIGINT, SIGTERM if they were already ignored.
390 Ignore SIGPIPE unless batch.
391 (emacs_backtrace): Output backtrace for the appropriate thread,
392 which is not necessarily the main thread.
393 * syssignal.h: Include <stdbool.h>.
394 (emacs_raise): New macro.
395 * xterm.c (x_connection_signal): Remove; no longer needed
396 now that we use sigaction.
397 (x_connection_closed): No need to mess with sigmask now.
398 (x_initialize): No need to reset SIGPIPE handler here, since
399 init_signals does this for us now.
400
8f4635e9
JD
4012012-09-23 Jan Djärv <jan.h.d@swipnet.se>
402
403 * nsterm.m (ns_dumpglyphs_image): dr is a new rect to draw image into,
fb39b937 404 background rect may be larger (Bug#12245).
8f4635e9 405
3296976d
CY
4062012-09-23 Chong Yidong <cyd@gnu.org>
407
408 * keyboard.c (timer_check): Avoid quitting during Fcopy_sequence.
409
d41e491e
PE
4102012-09-22 Paul Eggert <eggert@cs.ucla.edu>
411
412 * .gdbinit: Just stop at fatal_error_backtrace.
413 See Stefan Monnier's request in
414 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00549.html>.
415 Remove no-longer-used query of system type.
416
c88b867f
CY
4172012-09-22 Chong Yidong <cyd@gnu.org>
418
419 * search.c (Freplace_match): Doc fix (Bug#12325).
420
421 * minibuf.c (Finternal_complete_buffer): Doc fix (Bug#12391).
422
423 * editfns.c (Fline_beginning_position): Doc fix (Bug#12416).
424 (Fline_end_position): Doc fix.
425
426 * cmds.c (Fforward_char, Fbackward_char): Doc fix (Bug#12414).
427
bb4d86b4
CY
4282012-09-22 Chong Yidong <cyd@gnu.org>
429
430 * dispextern.h (struct image_type): Add new slot, storing a type
431 initialization function.
432
433 * image.c (define_image_type): Call the image initializer function
434 if it is defined. Arguments and return value changed.
435 (valid_image_p, make_image): Callers changed.
436 (xbm_type, xpm_type, pbm_type, png_type, jpeg_type, tiff_type)
3a880af4
SM
437 (gif_type, imagemagick_type, svg_type, gs_type):
438 Add initialization functions.
bb4d86b4
CY
439 (Finit_image_library): Call lookup_image_type.
440 (CHECK_LIB_AVAILABLE): Macro deleted.
441 (lookup_image_type): Call define_image_type here, rather than via
442 Finit_image_library, and without using CHECK_LIB_AVAILABLE.
443 (syms_of_image): Move define_image_type calls for xbm_type and
444 pbm_type to lookup_image_type.
445
df9685f3
EZ
4462012-09-22 Eli Zaretskii <eliz@gnu.org>
447
448 * keyboard.c (timer_check_2): Move calculation of 'timers' and
449 'idle_timers' from here ...
450 (timer_check): ... to here. Use Fcopy_sequence to copy the timer
451 lists, to avoid infloops when the timer does something stupid,
452 like reinvoke itself with the same or smaller time-out.
453 (Bug#12447)
454
8e17c9ba
MR
4552012-09-22 Martin Rudalics <rudalics@gmx.at>
456
457 * window.c (Fsplit_window_internal): Handle only Qt value of
458 Vwindow_combination_limit separately.
459 (Qtemp_buffer_resize): New symbol.
3a880af4
SM
460 (Vwindow_combination_limit): New default value.
461 Rewrite doc-string.
8e17c9ba 462
589bd69b
EZ
4632012-09-22 Eli Zaretskii <eliz@gnu.org>
464
465 * xdisp.c (next_overlay_string): Initialize it->end_charpos for
466 the new overlay string. (Bug#10159)
467
01108e3f
PE
4682012-09-22 Paul Eggert <eggert@cs.ucla.edu>
469
470 * emacs.c (shut_down_emacs): Don't assume stderr is buffered,
471 or that fprintf is async-signal-safe. POSIX doesn't require
472 either assumption.
473
82f8cd94
CY
4742012-09-22 Chong Yidong <cyd@gnu.org>
475
476 * buffer.c (Fset_buffer_modified_p): Handle indirect buffers
477 (Bug#8207).
478
3cccbd87
KH
4792012-09-22 Kenichi Handa <handa@gnu.org>
480
481 * composite.c (composition_reseat_it): Handle the case that a
482 grapheme cluster is not covered by a single font (Bug#12352).
483
09c01941
CY
4842012-09-21 Chong Yidong <cyd@gnu.org>
485
486 * image.c (define_image_type): Avoid adding duplicate types to
487 image_types (Bug#12463). Suggested by Jörg Walter.
488
acfa068f 4892012-09-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
e25c1a30
YM
490
491 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
492 (print_load_command_name): Add case LC_DATA_IN_CODE.
493 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
494
acfa068f 4952012-09-21 Glenn Morris <rgm@gnu.org>
1e9bbf47
GM
496
497 * eval.c (Frun_hook_with_args_until_success)
498 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
499
acfa068f 5002012-09-21 Andreas Schwab <schwab@linux-m68k.org>
c6ba4138
AS
501
502 * fileio.c (Ffile_selinux_context): Only call freecon when
503 lgetfilecon succeeded.
504 (Fset_file_selinux_context): Likewise. (Bug#12444)
505
acfa068f 5062012-09-21 Eli Zaretskii <eliz@gnu.org>
aa36e4d2
EZ
507
508 * xdisp.c (try_window_reusing_current_matrix): Under bidi
509 reordering, locate the cursor by calling set_cursor_from_row; if
510 that fails, clear the desired glyph matrix before returning a
511 failure indication to the caller. Fixes leaving garbled display
512 when fast scrolling with a down-key. (Bug#12403)
f2016bea
EZ
513 (compute_stop_pos_backwards): Fix a typo that caused crashes while
514 scrolling through multibyte text.
aa36e4d2 515
e99f70c8
SM
5162012-09-20 Stefan Monnier <monnier@iro.umontreal.ca>
517
518 * alloc.c (mark_object) <PVEC_WINDOW>: Mark prev/next_buffers *after*
519 calling mark_vectorlike since that's the one that marks the window.
520 (mark_discard_killed_buffers): Mark the final cdr.
521 * window.h (struct window): Move prev/next_buffers to the
522 non-standard fields.
523 * window.c (make_window): Initialize prev/next_buffers manually.
524
f75beb47
PE
5252012-09-20 Paul Eggert <eggert@cs.ucla.edu>
526
527 Omit unused arg EXPECTED from socket hooks.
528 * keyboard.c (gobble_input, read_avail_input, tty_read_avail_input):
529 * nsterm.m (ns_term_init):
530 * termhooks.h (struct terminal.read_socket_hook):
531 * w32inevt.c (w32_console_read_socket):
532 * w32term.c (w32_read_socket):
533 * xterm.c (XTread_socket):
534 Omit unused arg EXPECTED. All callers changed.
535 (store_user_signal_events): Return void, not int, since callers no
536 longer care about the return value. All uses changed.
537
b019b76a
JB
5382012-09-20 Juanma Barranquero <lekktu@gmail.com>
539
540 * w32gui.h (XParseGeometry): Do not declare.
541
05642592
PE
5422012-09-19 Paul Eggert <eggert@cs.ucla.edu>
543
e4bce92a
PE
544 * w32inevt.c (w32_console_read_socket): Return -1 on failure, not 0.
545 Ignore 'expected'. See Eli Zaretskii in
546 <http://bugs.gnu.org/12471#8> (last line).
547
05642592
PE
548 * frame.c (read_integer): Remove. All uses replaced by strtol/strtoul.
549 (XParseGeometry): Now static. Substitute extremal values for
550 values that are out of range.
551
e543ae91
JD
5522012-09-19 Jan Djärv <jan.h.d@swipnet.se>
553
554 * w32xfns.c (read_integer, XParseGeometry): Move to frame.c.
555
556 * nsfns.m (XParseGeometry): Remove.
557 (Fx_create_frame): Call x_set_offset to correctly interpret
558 top_pos in geometry.
559
3a880af4 560 * frame.c (read_integer, XParseGeometry): Move from w32xfns.c.
e543ae91
JD
561 (Fx_parse_geometry): If there is a space in string, call
562 Qns_parse_geometry, otherwise do as on other terms (Bug#12368).
563
45ba16c7
EZ
5642012-09-17 Eli Zaretskii <eliz@gnu.org>
565
c8b9f1bc
EZ
566 * search.c (scan_buffer): Use character positions in calls to
567 region_cache_forward and region_cache_backward, not byte
568 positions. (Bug#12196)
569
b4c932a2
EZ
570 * w32term.c (w32_read_socket): Set pending_signals to 1, like
571 xterm.c does. Reported by Daniel Colascione <dancol@dancol.org>.
572
45ba16c7
EZ
573 * ralloc.c (r_alloc_init) [!SYSTEM_MALLOC]: Initialize
574 __malloc_extra_blocks to 32 instead of 64, like alloc.c did in
575 emacs_blocked_malloc, now deleted.
576
eeceac93
PE
5772012-09-17 Paul Eggert <eggert@cs.ucla.edu>
578
579 Remove no-longer-needed Solaris 2.4 vfork bug workaround.
580 The workaround was for improving performance on Solaris 2.4, but
581 is getting in the way now. Emacs will still work if someone is
582 still running Solaris 2.4 in a museum somewhere; Sun dropped
583 support for Solaris 2.4 in 2003.
584 * callproc.c (Fcall_process) [HAVE_WORKING_VFORK]:
585 * process.c (create_process) [HAVE_WORKING_VFORK]:
586 Omit now-unnecessary workaround for the Solaris 2.4 vfork bug,
587 since Emacs no longer uses vfork on that platform.
588
78f83752
GM
5892012-09-17 Glenn Morris <rgm@gnu.org>
590
591 * emacs.c: Use COPYRIGHT.
592
634b8cac
PE
5932012-09-16 Paul Eggert <eggert@cs.ucla.edu>
594
0caaedb1
PE
595 Remove configure's --without-sync-input option (Bug#12450).
596 When auditing signal-handling in preparation for cleaning it up,
597 I found that SYNC_INPUT has race conditions and would be a real
598 pain to fix. Since it's an undocumented and deprecated
599 configure-time option, now seems like a good time to remove it.
600 Also see <http://bugs.gnu.org/11080#16>.
601 * alloc.c (_bytes_used, __malloc_extra_blocks, _malloc_internal)
602 (_free_internal) [!DOUG_LEA_MALLOC]: Remove decls.
603 (alloc_mutex) [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
604 (malloc_hysteresis):
605 (check_depth) [XMALLOC_OVERRUN_CHECK]:
606 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT):
607 (__malloc_hook, __realloc_hook, __free_hook, BYTES_USED)
608 (dont_register_blocks, bytes_used_when_reconsidered)
609 (bytes_used_when_full, emacs_blocked_free, emacs_blocked_malloc)
610 (emacs_blocked_realloc, reset_malloc_hooks, uninterrupt_malloc):
611 [!SYSTEM_MALLOC && !SYNC_INPUT]:
612 Remove. All uses removed.
613 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT): Use a different
614 implementation, one that depends on whether the new macro
615 XMALLOC_BLOCK_INPUT_CHECK is defined, not on whether SYNC_INPUT
616 is defined.
617 * atimer.c (run_timers, handle_alarm_signal):
618 * keyboard.c (pending_signal, poll_for_input_1, poll_for_input)
619 (handle_async_input, process_pending_signals)
620 (handle_input_available_signal, init_keyboard):
621 * nsterm.m (ns_read_socket):
622 * process.c (wait_reading_process_output):
623 * regex.c (immediate_quit, IMMEDIATE_QUIT_CHECK):
624 * sysdep.c (emacs_sigaction_init) [SA_RESTART]:
625 (emacs_write):
626 * xterm.c (XTread_socket):
627 Assume SYNC_INPUT.
628 * conf_post.h (SA_RESTART) [IRIX6_5]: Do not #undef.
629 * eval.c (handling_signal): Remove. All uses removed.
630 * lisp.h (ELSE_PENDING_SIGNALS): Remove.
631 All uses replaced with the SYNC_INPUT version.
632 (reset_malloc_hooks, uninterrupt_malloc, handling_signal):
633 Remove decls.
634 * sysdep.c, syssignal.h (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
635 Now static.
636
634b8cac
PE
637 * font.c (Ffont_shape_gstring): Remove unused local.
638
83da1b55
GM
6392012-09-16 Glenn Morris <rgm@gnu.org>
640
518650a5
GM
641 * Makefile.in (clean): No longer run nextstep's clean.
642
83da1b55
GM
643 * Makefile.in (ns_appdir, ns_appbindir, ns_appsrc): Remove variables.
644 (ns_frag): Remove.
645 (ns-app): Move here from ns.mk, and simplify.
646 (clean): Simplify nextstep entry.
647 * ns.mk: Remove file.
648
85a43e2e
KH
6492012-09-17 Kenichi Handa <handa@gnu.org>
650
651 * font.c (Ffont_shape_gstring): Fix previous change; GLYPHs may
652 not covert the last few charactes.
653
ba13e616 6542012-09-16 Kenichi Handa <handa@gnu.org>
ea964864
KH
655
656 * font.c (Ffont_shape_gstring): Don't adjust grapheme cluster
657 here, but just check the validity of glyphs in the glyph-string.
658
a8c729af
MR
6592012-09-16 Martin Rudalics <rudalics@gmx.at>
660
3a880af4
SM
661 * window.c (Fwindow_parameter, Fset_window_parameter):
662 Accept any window as argument (Bug#12452).
a8c729af 663
c077c059
JD
6642012-09-16 Jan Djärv <jan.h.d@swipnet.se>
665
666 * nsfns.m (Fx_open_connection): Move initialization of ns_*_types
667 to ns_term_init to avoid memory leak.
668
669 * nsterm.m (ns_update_begin): Initialize bp after lcokFocus, use
670 explicit retain/release.
671 (ns_term_init): Only allow one display. Initialize outerpool and
672 ns_*_types.
673
39a57ad0
PE
6742012-09-15 Paul Eggert <eggert@cs.ucla.edu>
675
676 Port _setjmp fix to POSIXish hosts as well as Microsoft.
677 * image.c (_setjmp) [!HAVE__SETJMP]: Restore definition, as
678 it's needed on POSIXish hosts that lack _setjmp. Attempt to solve
679 the Microsoft problem in a different way, by altering ../nt/config.nt.
680
7105c8cb
EZ
6812012-09-15 Eli Zaretskii <eliz@gnu.org>
682
683 * w32xfns.c:
684 * w32uniscribe.c:
685 * w32term.c:
686 * w32select.c:
687 * w32reg.c:
688 * w32proc.c:
689 * w32menu.c:
690 * w32inevt.c:
691 * w32heap.c:
692 * w32font.c:
693 * w32fns.c:
694 * w32console.c:
695 * w32.c:
696 * w16select.c: Remove inclusion of setjmp.h, as it is now included
697 by lisp.h. This completes removal of setjmp.h inclusion
698 erroneously announced in the previous commit. (Bug#12446)
699
700 * lisp.h [!HAVE__SETJMP, !HAVE_SIGSETJMP]: Make the commentary
701 more accurate.
702
703 * image.c (_setjmp) [!HAVE__SETJMP]: Define only if 'setjmp' is
704 not defined as a macro. The latter happens on MS-Windows.
705 (Bug#12446)
706
0328b6de
PE
7072012-09-15 Paul Eggert <eggert@cs.ucla.edu>
708
709 Port better to POSIX hosts lacking _setjmp (Bug#12446).
710 * lisp.h: Include <setjmp.h> here, since we use its symbols here.
7105c8cb 711 Some instances of '#include <setjmp.h>' removed, if the
0328b6de
PE
712 only reason for the instance was because "lisp.h" was included.
713 (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
714 Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
715 and _longjmp with the new symbols. Emacs already uses _setjmp if
716 available, so this change affects only POSIXish hosts that have
717 sigsetjmp but not _setjmp, such as some versions of Solaris and
718 Unixware. (Also, POSIX-2008 marks _setjmp as obsolescent.)
719 * image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
720 (png_load_body) [HAVE_PNG]:
721 (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
722 (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
723 Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
724 since PNG requires jmp_buf. This is the only exception to the
725 general rule that we now use sys_setjmp and sys_longjmp.
726 This exception is OK since this code does not change the signal
727 mask or longjmp out of a signal handler.
728
2af03429
PE
7292012-09-14 Paul Eggert <eggert@cs.ucla.edu>
730
731 * alloc.c [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
732 Include "syssignal.h", for 'main_thread'.
733
2f294edf
DA
7342012-09-14 Dmitry Antipov <dmantipov@yandex.ru>
735
736 Avoid out-of-range marker position (Bug#12426).
3a880af4
SM
737 * insdel.c (replace_range, replace_range_2):
738 Adjust markers before overlays, as suggested by comments.
2f294edf
DA
739 (insert_1_both, insert_from_buffer_1, adjust_after_replace):
740 Remove redundant check before calling offset_intervals.
741
6b533e9c
MR
7422012-09-14 Martin Rudalics <rudalics@gmx.at>
743
744 * xdisp.c (Fformat_mode_line): Unconditionally save/restore
745 current buffer (Bug#12387).
746
2a7931e3
JB
7472012-09-14 Juanma Barranquero <lekktu@gmail.com>
748
749 * makefile.w32-in ($(BLD)/alloc.$(O)): Update dependencies.
750
c18e885b
PE
7512012-09-13 Paul Eggert <eggert@cs.ucla.edu>
752
753 Use a more backwards-compatible timer format (Bug#12430).
754 * keyboard.c (decode_timer): Get PSECS from the 8th (origin-0)
755 vector element, not from the 4th, since PSECS is now at the end.
756 (Fcurrent_idle_time): Doc fix.
757
d59a1afb
DA
7582012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
759
760 Function to mark objects and remove killed buffers at once.
761 * alloc.c (discard_killed_buffers): Rename to ...
762 (mark_discard_killed buffers) ... new name. Add marking
763 of remaining objects. Fix comment. Adjust users.
764 (mark_object): Do not touch frame buffer lists here.
765 * frame.c (delete_frame): Reset frame buffer lists here.
766
5f0cb45a
PE
7672012-09-13 Paul Eggert <eggert@cs.ucla.edu>
768
8ea47e3a
PE
769 Better workaround for GNOME bug when --enable-gcc-warnings.
770 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
771 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
772 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
773
4a4bbad2
PE
774 Simplify SIGIO usage (Bug#12408).
775 The code that dealt with SIGIO was crufty and confusing, e.g., it
776 played tricks like "#undef SIGIO" but these tricks were not used
777 consistently. Simplify mostly by not #undeffing standard symbols,
778 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
779 or not as we please) rather than "defined SIGIO" (standard symbol
780 that we probably shouldn't #undef).
781 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
782 Modules that need it can include it.
783 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
784 * dispextern.h (ignore_sigio): New decl.
785 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
786 unconditionally, since it's now a no-op if !USABLE_SIGIO.
787 * emacs.c (shut_down_emacs):
788 * keyboard.c (kbd_buffer_store_event_hold):
789 Use ignore_sigio rather than invoking 'signal' directly.
790 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
791 for FIONREAD.
792 (FIONREAD, SIGIO): Do not #undef.
793 (tty_read_avail_input): Use #error rather than a syntax error.
794 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
795 for I_PIPE, used by SETUP_SLAVE_PTY.
796 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
797 * sysdep.c (croak): Remove; no longer needed. This bit of
798 temporary code, with Fred N. Fish's comment that it's temporary,
799 has been in Emacs since at least 1992!
800 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
801 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
802 * syssignal.h (croak): Remove decl.
803 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
804 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
805 now that we're termios-only.
806 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
807 * term.c (dissociate_if_controlling_tty): Use #error rather than
808 a run-time error.
809
5f0cb45a
PE
810 Work around GCC and GNOME bugs when --enable-gcc-warnings.
811 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
812 to work around GNOME bug 683906.
813 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
814 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
815 This works around GCC bug 54561.
816
40bce90b
PE
8172012-09-12 Paul Eggert <eggert@cs.ucla.edu>
818
819 More fixes for 'volatile' and setjmp/longjmp.
820 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
821 * image.c (struct png_load_context) [HAVE_PNG]: New type.
822 (png_load_body) [HAVE_PNG]:
823 (jpeg_load_body) [HAVE_JPEG]:
824 New function, with most of the old parent function's body.
825 (png_load) [HAVE_PNG]:
826 (jpeg_load) [HAVE_JPEG]:
827 Invoke the new function, to avoid longjmp munging our locals.
828 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
829 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
830 longjmp is passed 2, as the C standard doesn't guarantee this.
831 Instead, store the failure code into mgr->failure_code.
832
bfeae2cf
SM
8332012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
834
835 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
836 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
837 (syms_of_keyboard): Remove support for unread-command-char.
838
8099e36b
EZ
8392012-09-12 Eli Zaretskii <eliz@gnu.org>
840
841 * w32proc.c (sys_kill): If PID is our process ID and the signal is
842 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
843 violation. (Bug#12426)
844
92547ff9
PE
8452012-09-12 Paul Eggert <eggert@cs.ucla.edu>
846
847 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
848
45b82ad0
SM
8492012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
850
851 * eval.c: Add `inhibit-debugger'.
852 (Qinhibit_debugger): New symbol.
853 (call_debugger): Bind it instead of Qdebug_on_error.
854 (maybe_call_debugger): Test Vinhibit_debugger.
855 (syms_of_eval): Define inhibit-debugger.
856 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
857 (syms_of_xdisp): Remove inhibit-debug-on-message.
858
5779a1dc
PE
8592012-09-11 Paul Eggert <eggert@cs.ucla.edu>
860
50f2e553
PE
861 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
862 If a nonvolatile local variable is written before a _longjmp to
863 the frame containing the variable, and is read after the _longjmp,
864 the value read is indeterminate. Some local variables of type
865 'struct handler' and 'struct catchtag' are used in this way, so
866 mark each of their slots as volatile if the slot can be set before
867 _longjmp and read afterwards.
868 * lisp.h (struct handler): var and chosen_clause are now volatile.
869 (struct catchtag): val, next, and pdlcount are now volatile.
870
ae1d87e2
PE
871 * bidi.c (bidi_push_it, bidi_pop_it):
872 * fns.c (copy_hash_table):
873 * image.c (define_image_type):
874 * keyboard.c (kbd_buffer_store_event_hold):
875 * process.c (Fprocess_send_eof):
876 * xfaces.c (x_create_gc) [HAVE_NS]:
877 * xgselect.c (xg_select):
878 Prefer assignment to memcpy when either will do.
879
5779a1dc
PE
880 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
881 Use pointer-to-a-pointer to simplify and avoid a NILP check each
882 time an item is removed. No need to mark this function 'inline';
883 the compiler knows better than we do.
884
c4c9756b
JD
8852012-09-11 Jan Djärv <jan.h.d@swipnet.se>
886
887 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
888 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
889 to change_frame_size (Bug#12388).
890 (windowDidResize:): Pass YES to updateFrameSize.
891
892 * nsterm.h: Add delay parameter to updateFrameSize.
893
d73e321c
DA
8942012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
895
896 Discard killed buffers from deleted window and frame objects.
897 This reduces an amount of references to killed buffers and
898 helps GC to reclaim them faster.
899 * alloc.c (discard_killed_buffers): New function.
900 (mark_object): Use it for deleted windows and frames.
901 (mark_object): If symbol's value is set up for a killed buffer
902 or deleted frame, restore it's global binding.
903 * data.c (swap_in_global_binding): Add GC notice.
904 (swap_in_symval_forwarding): Use convenient set_blv_where.
905 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
906 * window.h: ... to here.
907
e578f381
DA
9082012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
909
910 Convenient macro to check whether the buffer is live.
911 * buffer.h (BUFFER_LIVE_P): New macro.
912 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
913 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
914
3057e615
YM
9152012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
916
917 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
918 composition cases (Bug#12364).
919
920 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
921 overhang of succeeding glyphs overlapping box cursor.
922
923 * w32term.c (x_draw_glyph_string): Likewise.
924
6fda35f2
PE
9252012-09-11 Paul Eggert <eggert@cs.ucla.edu>
926
c990426a
PE
927 Simplify, document, and port floating-point (Bug#12381).
928 The porting part of this patch fixes bugs on non-IEEE platforms
929 with frexp, ldexp, logb.
930 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
931 Now static.
932 * floatfns.c: Simplify discussion of functions that Emacs doesn't
933 support, by removing commented-out code and briefly listing the
934 C89 functions excluded. The commented-out stuff was confusing
935 maintenance, e.g., we thought we needed cbrt but it was commented out.
936 (logb): Remove decl; no longer needed.
937 (isfinite): New macro, if not already supplied.
938 (isnan): Don't replace any existing macro.
939 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
940 are present on all C89 platforms.
941 (Ffrexp): Do not special-case zero, as frexp does the right thing
942 for that case.
943 (Flogb): Do not use logb, as it doesn't have the desired meaning
944 on hosts that use non-base-2 floating point. Instead, stick with
945 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
946 frexp, to avoid getting an unspecified result.
947
6fda35f2
PE
948 * xdisp.c (Qinhibit_debug_on_message): Now static.
949
16130a58
JD
9502012-09-10 Jan Djärv <jan.h.d@swipnet.se>
951
952 * nsterm.m (ns_update_begin): Set clip path to whole view by using
953 NSBezierPath (Bug#12131).
954
d105a573
CY
9552012-09-10 Chong Yidong <cyd@gnu.org>
956
957 * fns.c (Fdelq, Fdelete): Doc fix.
958
ff55dfe8
PE
9592012-09-10 Paul Eggert <eggert@cs.ucla.edu>
960
961 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
962 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
963
e7032e7c
SM
9642012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
965
966 * lisp.h (make_lisp_ptr): New macro to replace XSET.
967 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
968 Use it.
969
e9957956
EZ
9702012-09-09 Eli Zaretskii <eliz@gnu.org>
971
aba05ce9
EZ
972 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
973 left fringe if the window has a left margin. This avoids leaving
974 traces of the cursor because its leftmost pixel is not drawn over.
975
e9957956
EZ
976 * dispnew.c (update_window_line): When the left margin area of a
977 screen line is updated, set the redraw_fringe_bitmaps_p flag of
978 that screen line. (Bug#12277)
979
f6196b87
PE
9802012-09-09 Paul Eggert <eggert@cs.ucla.edu>
981
982 Assume C89 or later for math functions (Bug#12381).
983 This simplifies the code, and makes it a bit smaller and faster,
984 and (most important) makes it easier to clean up signal handling
985 since we can stop worring about floating-point exceptions in
986 library code. That was a problem before C89, but the problem
987 went away many years ago on all practical Emacs targets.
988 * data.c, image.c, lread.c, print.c:
989 Don't include <math.h>; no longer needed.
990 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
991 might be autoconfigured, as that never happens.
992 * data.c (fmod):
993 * doprnt.c (DBL_MAX_10_EXP):
994 * print.c (DBL_DIG):
995 Remove. C89 or later always defines these.
996 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
997 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
998 (arith_error, domain_error, domain_error2):
999 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
1000 no longer needed -- we simply return what C returns. All uses removed.
1001 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
1002 the wrapped code.
1003 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
1004 Remove. All uses expanded, as these macros are no longer used
1005 more than once and are now more trouble than they're worth.
1006 (Ftan): Use tan, not sin / cos.
1007 (Flogb): Assume C89 frexp.
1008 (fmod_float): Assume C89 fmod.
1009 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
1010 (init_floatfns): Remove. All uses removed.
1011
9d7f1863
JD
10122012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1013
1014 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
1015 compositeToPoint for OSX < 10.6 (Bug#12390).
1016
eabf0404
PE
10172012-09-08 Paul Eggert <eggert@cs.ucla.edu>
1018
1019 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
1020 This produces more-accurate results.
1021
0b3b1d23
JD
10222012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1023
1024 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
1025 changes (Bug#12088).
1026
6dcef6ec
CY
10272012-09-08 Chong Yidong <cyd@gnu.org>
1028
1029 * syntax.c (Fstring_to_syntax): Doc fix.
1030
aa7d57c5
JD
10312012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1032
1033 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
1034 in the internal border.
1035 (x_set_window_size): Remove static variables and their usage.
1036 (ns_redraw_scroll_bars): Fix NSTRACE arg.
3a880af4
SM
1037 (ns_after_update_window_line, ns_draw_fringe_bitmap):
1038 Remove fringe/internal border adjustment (Bug#11052).
aa7d57c5
JD
1039 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
1040 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
1041 (ns_fix_rect_ibw): Remove.
1042 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
1043 (ns_dumpglyphs_box_or_relief): Ditto.
1044 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
1045 adjustment.
1046 (ns_dumpglyphs_image): Ditto.
fc0c31f8 1047 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
aa7d57c5
JD
1048 border adjustment.
1049 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
1050 their usage. Add fringe_extended_p and its use as in other terms.
1051 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
1052 scroll bar was removed.
1053 (updateFrameSize): New function.
1054 (windowDidResize): Move code to updateFrameSize and call it.
1055
1056 * nsterm.h (EmacsView): Add updateFrameSize.
1057
1a5432bc
CY
10582012-09-07 Chong Yidong <cyd@gnu.org>
1059
b4f5313e
CY
1060 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
1061
1a5432bc
CY
1062 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
1063
1a4f1e9b
PE
10642012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1065
1066 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
1067 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
1068 Problem introduced when merging patches. Noted by Eli Zaretskii in
1069 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
1070 * floatfns.c: Comment fix.
1071 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
1072 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
1073 and anyway the declaration is harmless even if SIGDANGER is not defined.
1074 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
1075 defined BROKEN_FIONREAD). systty.h formerly did this, but other
1076 source files not surprisingly expected syssignal.h to define, or
1077 not define, SIGIO, and it's cleaner to do it that way, for consistency.
1078 Include <sys/ioctl.h>, for FIONREAD.
1079 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
1080 This eliminates a problem whereby other files mysteriously had
1081 to include "syssignal.h" before including "systty.h" if they
1082 wanted to use "#ifdef SIGIO".
1083
bc8000ff
EZ
10842012-09-07 Eli Zaretskii <eliz@gnu.org>
1085
3e6d6928
EZ
1086 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
1087
1088 * w32.c (sigemptyset): Empty the set.
1089 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
1090
bc8000ff
EZ
1091 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
1092
b4fa72f2
DA
10932012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
1094
1095 * alloc.c (mark_buffer): Revert unsafe marking optimization.
1096 (mark_object): Likewise for frame objects.
1097
30730c93
PE
10982012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1099
1100 * syssignal.h (handle_on_main_thread): Always declare,
1101 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
1102 This ports to platforms without HAVE_PTHREAD.
1103
2fe28299
PE
11042012-09-06 Paul Eggert <eggert@cs.ucla.edu>
1105
1106 Signal-handler cleanup (Bug#12327).
1107 Emacs's signal handlers were written in the old 4.2BSD style with
1108 sigblock and sigmask and so forth, and this led to some
1109 inefficiencies and confusion. Rewrite these to use
1110 pthread_sigmask etc. without copying signal sets around. Also,
1111 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
1112 'signal', and instead use functions that do not attempt to take
1113 over the system name space. This patch causes Emacs's text
1114 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
1115 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
1116 Do not include <signal.h> or "syssignal.h", as these
1117 modules do not use signals.
1118 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
1119 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
1120 Do not include <signal.h>, as "syssignal.h" does that for us now.
1121 * atimer.c (sigmask_atimers): New function.
1122 (block_atimers, unblock_atimers): New functions,
1123 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
1124 All uses replaced.
1125 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
1126 no longer needed here.
1127 * emacs.c (main): Inspect existing signal handler with sigaction,
fc0c31f8 1128 so that there's no need to block and unblock SIGHUP.
2fe28299
PE
1129 * sysdep.c (struct save_signal): New member 'action', replacing
1130 old member 'handler'.
1131 (save_signal_handlers, restore_signal_handlers):
1132 Use sigaction instead of 'signal' to save and restore.
1133 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
1134 New function. All users of 'signal' modified to use set_sighandler
1135 if they're writeonly, and to use sys_signal if they're read+write.
1136 (emacs_sigaction_init, forwarded_signal): New functions.
1137 (sys_signal): Remove. All uses replaced by calls to sigaction
1138 and emacs_sigaction_init, or by direct calls to 'signal'.
1139 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
1140 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
1141 all uses replaced by pthread_sigmask etc. calls.
1142 * syssignal.h: Include <signal.h>.
1143 (emacs_sigaction_init, forwarded_signal): New decls.
1144 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
1145 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
1146 (sigmask, sys_sigmask): Remove; no longer needed.
1147 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
1148 (sigblock, sigunblock, sigfree):
1149 (sigsetmask) [!defined sigsetmask]:
1150 Remove. All uses replaced by pthread_sigmask.
1151 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
1152 no longer need to be replaced, and its typical old uses
1153 are now done via emacs_sigaction_init and sigaction.
1154 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
1155 (sys_sigdel): Remove; unused.
1156 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
1157
0216c128
EZ
11582012-09-06 Eli Zaretskii <eliz@gnu.org>
1159
1160 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
1161 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
1162
c752cfa9
DA
11632012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1164
1165 Explicitly mark buffer_defaults and buffer_local_symbols.
1166 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
1167 mark_local_symbols here.
1168 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
1169 since special buffers aren't marked here any more.
1170 (allocate_buffer): Chain new buffer with all_buffers here...
1171 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
1172 not here.
1173 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
1174 (syms_of_buffer): Remove staticpro of the above.
1175 (init_buffer_once): Set names for buffer_defaults and
1176 buffer_local_symbols.
1177
a864ef14
PE
11782012-09-06 Paul Eggert <eggert@cs.ucla.edu>
1179
1180 Use bool for booleans in font-related modules.
1181 * font.c (font_intern_prop, font_style_to_value)
1182 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
1183 (generate_otf_features, font_check_otf_features, font_check_otf)
1184 (font_match_p, font_list_entities, font_at):
1185 * fontset.c (fontset_id_valid_p, reorder_font_vector
1186 (fontset_find_font, Fset_fontset_font)
1187 (face_suitable_for_char_p) [0]:
1188 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
1189 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
1190 (m17n_flt_initialized, ftfont_shape_by_flt):
1191 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
1192 * nsfont.m (nsfont_draw):
1193 * w32font.c (w32font_draw):
1194 * w32term.c (x_draw_glyphless_glyph_string_foreground):
1195 Use bool for booleans.
1196 * font.h: Adjust to above API changes.
1197 (struct font, struct font_driver, struct font_driver_list):
1198 Use bool for booleans.
1199 (struct font): Remove useless member encoding_type.
1200 All users removed.
1201 * fontset.c, xftfont.c: Omit unnecessary static decls.
1202
0699fc18
DA
12032012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1204
1205 * alloc.c (mark_object): Revert window marking code
1206 since it's unsafe for the Fset_window_configuration.
1207
20ef56db
PE
12082012-09-05 Paul Eggert <eggert@cs.ucla.edu>
1209
2fe28299 1210 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
1211 Be more systematic about preserving errno whenever a signal
1212 handler returns, even if it's not in the main thread. Do this by
1213 renaming signal handlers to distinguish between signal delivery
1214 and signal handling. All uses changed.
1215 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
1216 * data.c (deliver_arith_signal): Rename from arith_error.
1217 * dispnew.c (deliver_window_change_signal): Rename from
1218 window_change_signal.
1219 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
1220 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
1221 * keyboard.c (deliver_input_available_signal): Rename from
1222 input_available_signal.
1223 (deliver_user_signal): Rename from handle_user_signal.
1224 (deliver_interrupt_signal): Rename from interrupt_signal.
1225 * process.c (deliver_pipe_signal): Rename from send_process_trap.
1226 (deliver_child_signal): Rename from sigchld_handler.
1227 * atimer.c (handle_alarm_signal):
1228 * data.c (handle_arith_signal):
1229 * dispnew.c (handle_window_change_signal):
1230 * emacs.c (handle_fatal_signal, handle_danger_signal):
1231 * keyboard.c (handle_input_available_signal):
1232 * keyboard.c (handle_user_signal, handle_interrupt_signal):
1233 * process.c (handle_pipe_signal, handle_child_signal):
1234 New functions, with the actual signal-handling code taken from the
1235 original respective signal handlers, sans the sporadic attempts to
1236 preserve errno, since that's now done by handle_on_main_thread.
1237 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
1238 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
1239 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1240 Move to sysdep.c.
1241 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1242 Move initialization of main_thread to sysdep.c's init_signals.
1243 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
1244 our usage, and simplifies the mainline code.
1245 (record_child_status_change): New static function, as a helper
1246 for handle_child_signal, and with most of the old child handler's
1247 contents.
1248 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
1249 (handle_child_signal): Use the above.
1250 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1251 Moved here from emacs.c.
1252 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
1253 code moved here from emacs.c's main function.
1254 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
3a880af4
SM
1255 replacing the old SIGNAL_THREAD_CHECK. All uses changed.
1256 This lets callers save and restore errno properly.
20ef56db 1257
e3ccf108
DA
12582012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1259
1260 Remove redundant or unused things here and there.
1261 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
1262 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
1263 * editfns.c (Fcompare_buffer_substrings): Likewise.
1264 * frame.h (struct terminal, struct font_driver_list):
1265 Remove redundant declarations.
1266 * window.h (Qleft, Qright): Likewise.
1267
697e1e39
DA
12682012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1269
1270 Do not mark objects from deleted buffers, windows and frames.
1271 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
1272 (mark_object): Likewise for windows and frames.
1273
c1ca42ca
DA
12742012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1275
1276 * alloc.c (valid_lisp_object_p): Treat killed buffers,
1277 buffer_defaults and buffer_local_symbols as valid objects.
1278 Return special value to denote them.
1279
014d93be
PE
12802012-09-05 Paul Eggert <eggert@cs.ucla.edu>
1281
f75d7a91
PE
1282 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
1283 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
1284 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
1285 (file_name_absolute_p, Fsubstitute_in_file_name):
1286 (check_executable, check_writable, Ffile_accessible_directory_p)
1287 (Fset_file_selinux_context, Fdefault_file_modes)
1288 (Finsert_file_contents, choose_write_coding_system)
1289 (Fwrite_region, build_annotations, a_write, e_write)
1290 (Fdo_auto_save):
1291 * filelock.c (boot_time_initialized, get_boot_time)
1292 (get_boot_time_1, lock_file_1, within_one_second):
1293 * floatfns.c (in_float):
1294 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
1295 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
1296 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
1297 * lisp.h (struct Lisp_Hash_Table.cmpfn):
1298 * window.c (compare_window_configurations):
1299 Use bool for booleans.
1300 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
1301 (Fdefault_file_modes): Now mode_t, not int, for modes.
1302 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
1303 (internal_delete_file): Now returns void, not a (boolean) int,
1304 since nobody was looking at the return value.
1305 * lisp.h, window.h: Adjust to above API changes.
1306
014d93be
PE
1307 * xdisp.c (set_message): Simplify and reindent last change.
1308
776f29e1
JB
13092012-09-05 Juanma Barranquero <lekktu@gmail.com>
1310
1311 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
1312
7f7e0167
LI
13132012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
1314
1315 * eval.c (call_debugger): Make the function non-static so that we
1316 can call it from set_message.
1317
1318 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
1319 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
1320
cf29dd84
PE
13212012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1322
1323 Give more-useful info on a fatal error (Bug#12328).
1324 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
1325 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
1326 of doing the work ourselves.
1327 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
1328 do most of the work.
1329 (fatal_error_backtrace): New function, taken from the guts
1330 of the old fatal_error_signal, but with a new option to output
1331 a backtrace.
1332 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
1333 info about the signal than just its number.
1334 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
1335 * sysdep.c: Include <execinfo.h>
1336 (emacs_backtrace): New function, taken partly from the previous
1337 code of the 'die' function.
1338 (emacs_abort): Call fatal_error_backtrace rather than abort.
1339
972debf2
SM
13402012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1341
1342 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
1343 eager (load-time) macro-expansion.
1344 * lisp.mk (lisp): Add macroexp.
1345
1088b922
PE
13462012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1347
1348 Simplify redefinition of 'abort' (Bug#12316).
1349 Do not try to redefine the 'abort' function. Instead, redo
1350 the code so that it calls 'emacs_abort' rather than 'abort'.
1351 This removes the need for the NO_ABORT configure-time macro
1352 and makes it easier to change the abort code to do a backtrace.
1353 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
1354 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
1355 Remove; sysdep.c's emacs_abort now takes its place.
1356 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
1357 'abort' changed to use 'emacs_abort'.
1358 * msdos.c (dos_abort) [defined abort]: Remove; not used.
1359 (abort) [!defined abort]: Rename to ...
1360 (emacs_abort): ... new name.
1361 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
1362 the place of the old 'abort' in emacs.c.
1363 * w32.c, w32fns.c (abort): Do not #undef.
1364 * w32.c (emacs_abort): Rename from w32_abort.
1365
30934d33
EZ
13662012-09-04 Eli Zaretskii <eliz@gnu.org>
1367
1368 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
1369 offsets[j].dv, since the y axis of the screen coordinates points
1370 down, while the y axis of the font definition coordinates points
1371 up. This fixes display of Arabic diacritics such as KASRA and
1372 KASRATAN. (Bug#11860)
1373
af26b72c
PE
13742012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1375
1376 Be more systematic about _setjmp vs setjmp.
1377 * alloc.c (test_setjmp, mark_stack):
1378 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
1379 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
1380 (png_load, my_error_exit, jpeg_load):
1381 * process.c (send_process_trap, send_process):
1382 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
1383 The underscored versions are up to 30x faster on some hosts.
1384 Formerly, the code used setjmp+longjmp sometimes and
1385 _setjmp+_longjmp at other times, with no particular reason to
1386 prefer setjmp+longjmp.
1387
26d4541d
PE
13882012-09-03 Paul Eggert <eggert@cs.ucla.edu>
1389
d42f4f0f 1390 Fix minor problem found by static checking.
26d4541d 1391 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 1392
c5e28e39
MR
13932012-09-03 Martin Rudalics <rudalics@gmx.at>
1394
1395 * buffer.c (Fdelete_all_overlays): New function.
1396
3eab3ca9
CY
13972012-09-03 Chong Yidong <cyd@gnu.org>
1398
1399 * gtkutil.c: Add extern decl for Qxft.
1400
c04889f8
PE
14012012-09-02 Paul Eggert <eggert@cs.ucla.edu>
1402
1882aa38
PE
1403 * emacs.c, eval.c: Use bool for boolean.
1404 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
1405 (malloc_using_checking) [DOUG_LEA_MALLOC]:
1406 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
1407 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
1408 (main, decode_env_path, Fdaemon_initialized):
1409 * eval.c (call_debugger, Finteractive_p, interactive_p):
1410 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
1411 (maybe_call_debugger, Fbacktrace):
1412 * process.c (read_process_output, exec_sentinel):
1413 Use bool for booleans.
1414 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
1415 All callers changed.
1416 * eval.c (interactive_p): Omit always-true boolean argument
1417 EXCLUDE_SUBRS_P. All callers changed.
1418 * dispextern.h, lisp.h: Reflect above API changes.
1419 * firstfile.c (dummy): Use the address of 'main', whose signature
1420 won't change, instead of the address of 'initialize', whose
1421 signature just changed from int to bool.
1422 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
1423 * msdos.c (fatal_error_in_progress): ... from here.
1424 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
1425 of incrementing it.
1426 (redisplay_internal, unwind_redisplay): Simply clear
1427 REDISPLAYING_P when unwinding, instead of saving its previous,
1428 always-false value and then restoring it.
1429
a411ac43
PE
1430 Clean up some extern decls.
1431 Mostly, this hoists extern decls out of .c files and into .h files.
1432 That way, we're more likely to catch errors if the interfaces change.
1433 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
1434 declare xg_mark_data.
1435 * dispextern.h (x_frame_parm_handlers):
1436 * font.h (Qxft):
1437 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
1438 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
1439 (Qultra_bold, Qoblique, Qitalic):
1440 Move extern decl here from .c file.
1441 * alloc.c (xg_mark_data) [USE_GTK]:
1442 * doc.c (Qclosure):
1443 * eval.c (Qlexical_binding):
1444 * fns.c (time) [!HAVE_UNISTD_H]:
1445 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
1446 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
1447 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
1448 * lread.c (Qinternal_interpreter_environment):
1449 * minibuf.c (Qbuffer):
1450 * process.c (QCfamily, QCfilter):
1451 * widget.c (free_frame_faces):
1452 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
1453 * xfont.c (x_clear_errors):
1454 * xterm.c (x_frame_parm_handlers):
1455 Remove now-redundant extern decls.
1456 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
1457 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
1458 Now static.
1459 * xfaces.c: Remove unnecessary static decls.
1460 * xterm.c (updating_frame): Remove decl of nonexistent object.
1461
c04889f8
PE
1462 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
1463 when building globals.h, as the objects that are not built on
1464 this host are not needed to compile C files on this host.
1465
8b339673
JD
14662012-09-02 Jan Djärv <jan.h.d@swipnet.se>
1467
1468 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
1469
1470 * frame.h: Add missing prototype for x_wm_set_size_hint.
1471
a08d4ba7
PE
14722012-09-02 Paul Eggert <eggert@cs.ucla.edu>
1473
1474 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
1475 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
1476 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
1477 (Fsubstitute_command_keys):
1478 * editfns.c (region_limit, find_field, Fconstrain_to_field)
1479 (save_excursion_save, save_excursion_restore)
1480 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
1481 (format_time_string, general_insert_function)
1482 (make_buffer_string, make_buffer_string_both)
1483 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
1484 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
1485 (copy_text, insert_1, insert_1_both, insert_from_string)
1486 (insert_from_string_before_markers, insert_from_string_1)
1487 (insert_from_buffer, insert_from_buffer_1, replace_range)
1488 (replace_range_2, del_range_1, del_range_byte, del_range_both)
1489 (del_range_2, modify_region):
1490 * intervals.c (intervals_equal, balance_possible_root_interval)
1491 (adjust_intervals_for_insertion, merge_properties_sticky)
1492 (graft_intervals_into_buffer, lookup_char_property)
1493 (adjust_for_invis_intang, set_point_both)
1494 (get_property_and_range, compare_string_intervals)
1495 (set_intervals_multibyte_1, set_intervals_multibyte):
1496 * keyboard.c (decode_timer):
1497 Use bool for boolean.
1498 * intervals.h, lisp.h, systime.h: Reflect above API changes.
1499 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
1500
48c948de
CY
15012012-09-02 Chong Yidong <cyd@gnu.org>
1502
1503 * keymap.c (push_key_description): Print M-TAB as C-M-i
1504 (Bug#11758).
1505
6c49a40b
JB
15062012-09-02 Juanma Barranquero <lekktu@gmail.com>
1507
1508 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
1509 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
1510 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
1511 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
1512 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
1513 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
1514 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
1515
4dfbd238
EZ
15162012-09-01 Eli Zaretskii <eliz@gnu.org>
1517
7e510e28
EZ
1518 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
1519 more than one grapheme cluster passed to the shaper: compute the
1520 offset adjustment values separately for each cluster. (Bug#11860)
1521
4dfbd238
EZ
1522 * image.c: Restore mistakenly removed inclusion of w32.h. Without
1523 it, GCC doesn't see prototypes of w32_delayed_load, and complains
1524 about implicit conversions from integer to pointer.
1525
86571ae0
DC
15262012-09-01 Daniel Colascione <dancol@dancol.org>
1527
1528 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
1529 system used too early.
1530
0e23ef9d
PE
15312012-09-01 Paul Eggert <eggert@cs.ucla.edu>
1532
1533 Better seed support for (random).
1534 * emacs.c (main): Call init_random.
1535 * fns.c (Frandom): Set the seed from a string argument, if given.
1536 Remove long-obsolete Gentzel cruft.
1537 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
1538 (init_random): New function.
1539
17a2cbbd
DC
15402012-09-01 Daniel Colascione <dancol@dancol.org>
1541
1542 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
1543 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
1544 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
1545 x_wm_set_size_hint, x_query_colors, x_real_positions,
1546 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
1547 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
1548 all of which have been moved to common code.
1549
1550 * xfaces.c: Include TERM_HEADER instead of listing all possible
1551 window-system headers.
1552
1553 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
1554 to match header.
1555
1556 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
1557 directly accessing frame internals.
1558
f18cbb28 1559 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
1560 globals_of_w32font.
1561
1562 * process.c: Include TERM_HEADER instead of listing all possible
1563 window-system headers.
1564
3a880af4
SM
1565 * nsterm.h: Remove declarations now in frame.h.
1566 Define FRAME_X_SCREEN, FRAME_X_VISUAL.
17a2cbbd
DC
1567
1568 * menu.c: Include TERM_HEADER instead of listing all possible
1569 window-system headers.
1570
1571 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
1572 window system.
1573
1574 * keyboard.c: Include TERM_HEADER instead of listing all possible
1575 window-system headers.
1576
1577 * image.c: Include TERM_HEADER instead of listing all possible
1578 window-system headers. Declare Vlibrary_cache when compiling for
1579 Windows.
1580
1581 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
1582 window system declarations.
1583
1584 * frame.h: Move common functions here: set_frame_menubar,
1585 x_set_window_size, x_sync, x_get_focus_frame,
1586 x_set_mouse_position, x_set_mouse_pixel_position,
1587 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
1588 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
1589 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
1590 x_activate_menubar, x_real_positions, x_bitmap_icon,
1591 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
1592 and x_query_colors.
1593
1594 * frame.c: Include TERM_HEADER instead of listing all possible
1595 window-system headers.
1596
1597 * font.c: Include TERM_HEADER instead of listing all possible
1598 window-system headers.
1599
1600 * emacs.c: Include TERM_HEADER.
1601
f18cbb28
EZ
1602 * dispnew.c: Include TERM_HEADER instead of listing all possible
1603 window-system headers.
17a2cbbd 1604
f18cbb28 1605 * ccl.h: Include character.h.
17a2cbbd
DC
1606
1607 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
1608 the current window system; include in list of objects to link into
1609 Emacs.
1610
c650a5de
DA
16112012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
1612
1613 Remove mark_ttys function and fix tty_display_info initialization.
1614 * lisp.h (mark_ttys): Remove prototype.
1615 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
1616 to mark_ttys because all possible values of 'top_frame' slot are
1617 the frames which are reachable from Vframe_list.
1618 * term.c (mark_ttys): Remove.
1619 (init_tty): Safely initialize 'top_frame' slot with Qnil.
1620
4e0f6479
DA
16212012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
1622
1623 Change struct frame bitfields from unsigned char to unsigned.
1624 * frame.h (struct frame): Change type of 'display_preempted',
1625 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
1626 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
1627 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
1628 bitfields from unsigned char to unsigned.
1629
8b96a52c
DA
16302012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
1631
1632 Remove unused member of struct x_output and struct w32_output.
1633 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
1634 * w32term.h (struct w32_output): Likewise.
1635
b4444c8a
JD
16362012-08-30 Jan Djärv <jan.h.d@swipnet.se>
1637
1638 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
1639 does not become zero (Bug#12234).
1640
b98521db
PE
16412012-08-30 Paul Eggert <eggert@cs.ucla.edu>
1642
1643 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
1644 for GCC 4.7.1 x86-64.
1645
31d02438
GM
16462012-08-30 Glenn Morris <rgm@gnu.org>
1647
1648 * lread.c (init_lread): For out-of-tree builds, only add the
1649 source directory's site-lisp dir to the load-path if it exists,
1650 consistent with in-tree builds. (Bug#12302)
1651
7f8941d8
JD
16522012-08-28 Jan Djärv <jan.h.d@swipnet.se>
1653
1654 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
fc0c31f8 1655 button_values to NULL. Call setStykeMask so dialogs get a close button.
7f8941d8
JD
1656 (windowShouldClose:): Set window_closed.
1657 (dealloc): New member, free button_values.
fc0c31f8
JB
1658 (process_dialog:): Make member function. Remove window argument,
1659 replace window with self. Count buttons and allocate and store values
7f8941d8
JD
1660 in button_values.
1661 (addButton:value:row:): value is int with the name tag. Call setTag
fc0c31f8 1662 with tag. Remove return self, declare return value as void.
7f8941d8
JD
1663 (addString:row:): Remove return self, declare return value as void.
1664 (addSplit): Remove return self, declare return value as void.
1665 (clicked:): Remove return self, declare return value as void.
fc0c31f8 1666 Set dialog_return to button_values[seltag]. Code formatting change.
7f8941d8
JD
1667 (initFromContents:isQuestion:): Adjust call to process_dialog.
1668 Code formatting change.
1669 (timeout_handler:): Set timer_fired to YES.
1670 (runDialogAt:): Set timer_fired to NO.
1671 Handle click on close button as quit.
1672
1673 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
1674 Add window_closed and button_values. Add void as return value for
1675 add(Button|String|Split). addButton takes int instead of Lisp_Object.
1676 Add process_dialog as new member.
1677
eada0861 16782012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 1679
eada0861
GM
1680 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
1681 is not one of the heaps we manage. (Bug#12242)
1682
16832012-08-28 Glenn Morris <rgm@gnu.org>
1684
1685 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
1686
457294dd
MR
16872012-08-28 Martin Rudalics <rudalics@gmx.at>
1688
1689 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
1690 auto-buffer-name window parameter. Install revision of reverted
1691 fix.
457294dd 1692
4f2daf31
DA
16932012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1694
1695 Do not allow to set major mode for a dead buffer.
1696 * buffer.c (Fset_buffer_major_mode): Signal an error
1697 if the buffer is dead.
1698 (Fother_buffer, other_buffer_safely): Remove redundant
1699 nested declaration.
1700
66322887
DA
17012012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1702
1703 Always use set_buffer_if_live to restore original buffer at unwind.
1704 * buffer.h (record_unwind_current_buffer): New function.
1705 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
1706 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
1707 * undo.c, window.c: Adjust users.
1708 * buffer.c (set_buffer_if_live): Fix comment.
1709
a3d794a1
DA
17102012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1711
1712 Fix usage of set_buffer_internal.
1713 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
1714 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
1715 * coding.c (decode_coding): Omit redundant test.
1716 * fileio.c (decide_coding_unwind): Likewise.
1717 * fns.c (secure_hash): Likewise.
1718 * insdel.c (modify_region): Likewise.
1719 * keyboard.c (command_loop_1): Likewise.
1720 * print.c (PRINTFINISH): Likewise.
1721 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
1722
59ea14cd
PE
17232012-08-27 Paul Eggert <eggert@cs.ucla.edu>
1724
1725 * dispnew.c: Use bool for boolean.
1726 (frame_garbaged, display_completed, delayed_size_change)
1727 (fonts_changed_p, add_window_display_history)
1728 (add_frame_display_history, verify_row_hash)
1729 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
1730 (row_equal_p, realloc_glyph_pool)
1731 (allocate_matrices_for_frame_redisplay)
1732 (showing_window_margins_p)
1733 (adjust_frame_glyphs_for_frame_redisplay)
1734 (build_frame_matrix_from_leaf_window, make_current)
1735 (mirrored_line_dance, mirror_line_dance, update_frame)
1736 (update_window_tree, update_single_window)
1737 (check_current_matrix_flags, update_window, update_text_area)
1738 (update_window_line, set_window_update_flags, scrolling_window)
1739 (update_frame_1, scrolling, buffer_posn_from_coords)
1740 (do_pending_window_change, change_frame_size)
1741 (change_frame_size_1, sit_for):
1742 Use bool for boolean.
1743 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
1744 and remove last int (actually boolean) argument, which was always 0.
1745 All callers changed.
1746 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
1747 * dispextern.h (struct composition_it): Use bool for boolean.
1748 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
1749 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
1750 * dired.c (file_name_completion):
1751 Use bool for boolean. (This was missed in an earlier change.)
1752
95072a94
MR
17532012-08-27 Martin Rudalics <rudalics@gmx.at>
1754
1755 * window.c (Fset_window_configuration): Revert first part of
1756 last change.
1757
0f19feff
JD
17582012-08-27 Jan Djärv <jan.h.d@swipnet.se>
1759
1760 * nsterm.h (NSPanel): New class variable dialog_return.
1761
3a880af4
SM
1762 * nsmenu.m (initWithContentRect:styleMask:backing:defer:):
1763 Initialize dialog_return.
0f19feff
JD
1764 (windowShouldClose:): Use stop instead of stopModalWithCode.
1765 (clicked:): Ditto, and also set dialog_return (Bug#12258).
1766 (timeout_handler:): Use stop instead of abortModal. Send a dummy
1767 event.
1768 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
1769 modal loop returns.
1770
f10fe38f
PE
17712012-08-27 Paul Eggert <eggert@cs.ucla.edu>
1772
de1339b0
PE
1773 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
1774 * composite.c (find_composition, composition_gstring_p)
1775 (composition_reseat_it, find_automatic_composition):
1776 * data.c (let_shadows_buffer_binding_p)
1777 (let_shadows_global_binding_p, set_internal, make_blv)
1778 (Fmake_variable_buffer_local, Fmake_local_variable)
1779 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
1780 (cons_to_signed, arith_driver):
1781 * dbusbind.c (xd_in_read_queued_messages):
1782 * dired.c (directory_files_internal, file_name_completion):
1783 Use bool for booleans.
1784 * dired.c (file_name_completion):
1785 * process.h (fd_callback):
1786 Omit int (actually boolean) argument. It wasn't being used.
1787 All uses changed.
1788 * composite.h, lisp.h: Reflect above API changes.
1789
f10fe38f
PE
1790 * cmds.c, coding.c: Use bool for booleans.
1791 * cmds.c (move_point, Fself_insert_command):
1792 * coding.h (struct composition status, struct coding_system):
1793 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
1794 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
1795 (emacs_mule_char, decode_coding_emacs_mule)
1796 (encode_coding_emacs_mule, detect_coding_iso_2022)
1797 (decode_coding_iso_2022, encode_invocation_designation)
1798 (encode_designation_at_bol, encode_coding_iso_2022)
1799 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
1800 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
1801 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
1802 (encode_coding_raw_text, detect_coding_charset)
1803 (decode_coding_charset, encode_coding_charset, detect_eol)
1804 (detect_coding, get_translation_table, produce_chars)
1805 (consume_chars, reused_workbuf_in_use)
1806 (make_conversion_work_buffer, code_conversion_save)
1807 (decode_coding_object, encode_coding_object)
1808 (detect_coding_system, char_encodable_p)
1809 (Funencodable_char_position, code_convert_region)
1810 (code_convert_string, code_convert_string_norecord)
1811 (Fset_coding_system_priority):
1812 * fileio.c (Finsert_file_contents):
1813 Use bool for booleans.
1814 * coding.h, lisp.h: Reflect above API changes.
1815 * coding.c: Remove unnecessary static function decls.
1816 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
1817 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
1818 not a boolean 'int', since callers never look at the return value.
1819 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
1820 * coding.h (decoding_buffer_size, encoding_buffer_size)
1821 (emacs_mule_string_char): Remove unused extern decls.
1822 (struct iso_2022_spec, struct coding_system):
1823 Use 'unsigned int : 1' for boolean fields, since there's more than one.
1824 (struct emacs_mule_spec): Remove unused field 'full_support'.
1825 All initializations removed.
1826 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
1827
5474c384
DA
18282012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1829
f10fe38f 1830 Fix spare memory change (Bug#12286).
5474c384
DA
1831 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
1832 (valid_lisp_object_p): Likewise.
1833
c4b6914d
MR
18342012-08-27 Martin Rudalics <rudalics@gmx.at>
1835
1836 * window.c (Fset_window_configuration): Record any window's old
1837 buffer if it's replaced (see Bug#8789). If the new current
1838 buffer doesn't appear in the selected window, go to its old
1839 point (Bug#12208).
1840
35aaa1ea
DA
18412012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1842
1843 Special MEM_TYPE_SPARE to denote reserved memory.
1844 * alloc.c (enum mem_type): New memory type.
1845 (refill_memory_reserve): Use new type for spare memory.
1846 This prevents live_cons_p and live_string_p from incorrect
1847 detection of uninitialized objects from spare memory as live.
1848
6af64513
PE
18492012-08-26 Paul Eggert <eggert@cs.ucla.edu>
1850
8b2e00a3
PE
1851 Spelling fixes.
1852 * Makefile.in (.PHONY): versioclean -> versionclean.
1853
b52d6985
PE
1854 Remove unused external symbols.
1855 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
1856 * window.c (Qwindow_valid_p, decode_valid_window):
1857 Now static, not extern.
1858 * data.c (Qinterval): Remove; unused.
1859 (syms_of_data): Do not define 'interval'.
1860 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
1861 * window.h (decode_valid_window):
1862 Remove decls.
1863
d5172d4f
PE
1864 * character.c, charset.c, chartab.c: Use bool for booleans.
1865 * character.c (lisp_string_width, string_count_byte8)
1866 (string_escape_byte8):
1867 * charset.c (charset_map_loaded, load_charset_map, read_hex):
1868 (load_charset_map_from_file, map_charset_chars)
1869 (Fdefine_charset_internal, define_charset_internal)
1870 (Fdeclare_equiv_charset, find_charsets_in_text)
1871 (Ffind_charset_region, char_charset, Fiso_charset):
1872 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
1873 (sub_char_table_set, sub_char_table_set_range)
1874 (char_table_set_range, optimize_sub_char_table)
1875 (map_sub_char_table):
1876 Use bool for boolean.
1877 * character.c (str_to_unibyte): Omit last boolean argument; it was
1878 always 0. All callers changed.
1879 * character.h, charset.h: Adjust to match previous changes.
1880 * character.h (char_printable_p): Remove decl of nonexistent function.
1881 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
1882 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
1883 are all boolean, so make them single-bit bitfields.
1884
6af64513
PE
1885 * lisp.h (ASET): Remove attempt to detect side effects.
1886 It was meant to be temporary and it often doesn't work,
1887 because when IDX has side effects the behavior of IDX==IDX
1888 is undefined. See Stefan Monnier in
1889 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
1890
e1f29348
BR
18912012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1892
1893 * lisp.h (functionp): New function (extracted from Ffunctionp).
1894 (FUNCTIONP): Use it.
1895 * eval.c (Ffunctionp): Use it.
1896
17c05d74
PE
18972012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1898
0f46bc75
PE
1899 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
1900 as that's faster and simpler than static storage. Don't bother
1901 with the g_main_context_query overhead if g_main_context_pending
1902 says no events are pending.
1903 (gfds, gfds_size): Remove these static vars.
1904 (xgselect_initialize): Remove; no longer needed.
1905 All uses and decls removed.
1906
ee4c0f69
PE
1907 * emacs.c (fatal_error_signal_hook): Remove.
1908 All uses removed. This leftover from old code was always 0.
1909
17c05d74
PE
1910 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
1911 * casefiddle.c (casify_object, casify_region):
1912 * casetab.c (set_case_table):
1913 * category.c, category.h (word_boundary_p):
1914 * category.h (CHAR_HAS_CATEGORY):
1915 Use bool for booleans, instead of int.
1916
391ceac5
EZ
19172012-08-25 Eli Zaretskii <eliz@gnu.org>
1918
1919 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
1920
2f221583
PE
19212012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1922
f4a681b0
PE
1923 On assertion failure, print backtrace if available.
1924 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
1925 (die) [ENABLE_CHECKING]: Print a backtrace if available.
1926 * Makefile.in (LIB_EXECINFO): New macro.
1927 (LIBES): Use it.
1928
2f221583
PE
1929 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
1930 * bytecode.c (exec_byte_code):
1931 * callint.c (check_mark, Fcall_interactively):
1932 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
1933 (getenv_internal, sync_process_alive, call_process_exited):
1934 * lisp.h (USE_SAFE_ALLOCA):
1935 Use bool for booleans, instead of int.
1936 * lisp.h, process.h: Adjust prototypes to match above changes.
1937 * callint.c (Fcall_interactively): Don't assume the mark's
1938 offset fits in 'int'.
1939
37ef52bb
PE
19402012-08-24 Paul Eggert <eggert@cs.ucla.edu>
1941
1942 * buffer.c, buffer.h: Use bool for boolean.
1943 * buffer.c (reset_buffer_local_variables)
1944 (buffer_lisp_local_variables, Fset_buffer_modified_p)
1945 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
1946 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
1947 (overlay_touches_p, overlay_strings, Foverlay_put)
1948 (report_overlay_modification, call_overlay_mod_hooks):
1949 (mmap_enlarge, mmap_set_vars):
1950 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
1951 Use bool for booleans, instead of int.
1952 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
1953 since the 1-or-0 return value is always ignored anyway.
1954 (mmap_initialized_p):
1955 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
1956 * buffer.h, lisp.h: Adjust prototypes to match above changes.
1957
2cc21167
PE
19582012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1959
1960 * bidi.c: Use bool for boolean.
1961 This is a bit more readable, and makes the text segment of bidi.o
1962 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
1963 Presumably it's faster too.
1964 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
1965 Now bool.
1966 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1967 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
1968 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
1969 (bidi_explicit_dir_char, bidi_level_of_next_char)
1970 (bidi_find_other_level_edge, bidi_move_to_visually_next):
1971 Use bool for booleans, instead of int.
1972 * dispextern.h (bidi_init_it, bidi_paragraph_init)
1973 (bidi_unshelve_cache): Adjust decls to match code.
1974
7db4ddf4
MR
19752012-08-23 Martin Rudalics <rudalics@gmx.at>
1976
1977 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
1978 argument.
1979
b1bb8011
PE
19802012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1981
1982 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
1983 * atimer.h: Include <stdbool.h>.
1984
ff687885
DN
19852012-08-22 Dan Nicolaescu <dann@gnu.org>
1986
1987 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
1988 compile time tests instead of run time tests on systems that do
1989 not use them.
1990 (FRAME_MAC_P): Remove leftover from deleted code.
1991 * frame.c (syms_of_frame): Remove leftover from deleted code.
1992
4ce7a138
JD
19932012-08-22 Jan Djärv <jan.h.d@swipnet.se>
1994
1995 * nsterm.m (insertText:): Don't clear modifiers if code is space.
1996
d733ec6d
PE
19972012-08-22 Paul Eggert <eggert@cs.ucla.edu>
1998
1999 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
2000 Otherwise, the compiler complains about (A?B:C) where B is void
fc0c31f8 2001 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
d733ec6d
PE
2002 (fontset_add): Return void, for FONTSET_ADD.
2003
d0d2d26f
PE
20042012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2005
fce31d69
PE
2006 * alloc.c: Use bool for booleans.
2007 (gc_in_progress, abort_on_gc)
2008 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2009 (dont_register_blocks) [GC_MALLOC_CHECK]:
2010 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
2011 (check_string_bytes, make_specified_string, memory_full)
2012 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
2013 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
2014 (mark_stack, valid_pointer_p, make_pure_string)
2015 (Fgarbage_collect, survives_gc_p, gc_sweep):
2016 Use bool for booleans, instead of int.
2017 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2018 Remove unused local.
2019 * alloc.c (PURE_POINTER_P):
2020 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
2021 * editfns.c (Fformat):
2022 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
2023 (Fdo_auto_save):
2024 * fns.c (sweep_weak_table):
2025 * lisp.h (suppress_checking, push_message, survives_gc_p)
2026 (make_pure_string, gc_in_progress, abort_on_gc):
2027 * lread.c (readchar, read1):
2028 * print.c (Fprin1_to_string):
2029 * xdisp.c (push_message):
2030 Use bool for booleans affected directly or indirectly by
2031 alloc.c's changes.
2032
d0d2d26f
PE
2033 Make recently-introduced setters macros.
2034 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
2035 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
2036 (set_fontset_default, set_fontset_fallback): Rename from their
2037 upper-case counterparts, and make them functions rather than macros.
2038 This is more consistent with the other recently-introduced setters.
2039 These don't need to be inline, since they're local.
2040
d18e2bb6
JD
20412012-08-21 Jan Djärv <jan.h.d@swipnet.se>
2042
2043 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
2044 the loop (Bug#12247).
2045
1b9d9d16
PE
20462012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2047
2048 * lisp.h (vcopy): Use memcpy rather than our own loop.
2049 This fixes a performance regression introduced by the recent
2050 addition of vcopy. This means 'vcopy' will need to be modified
2051 for a copying collector, but that's OK. Also, tighten the
2052 checking in the assertion.
2053
b2f09701
EZ
20542012-08-21 Eli Zaretskii <eliz@gnu.org>
2055
2056 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
2057 components for RTL text (Bug#11860). Adjust X-OFFSET of each
2058 non-base glyph for the width of the base character, according to
e1f29348
BR
2059 what x_draw_composite_glyph_string_foreground expects.
2060 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
2061 expectations, to produce correct width of the composed character.
2062 Reverse the sign of the DU offset produced by ScriptPlace.
2063
9b994fed
PE
20642012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2065
2066 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
2067
086ca913
DA
20682012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2069
2070 Avoid direct writes to contents member of struct Lisp_Vector.
2071 * lisp.h (vcopy): New function to copy data into vector.
2072 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
2073 * fns.c (Ffillarray): Use ASET.
2074 * keyboard.c (timer_check_2): Use AREF and ASET.
2075 (append_tool_bar_item, Frecent_keys): Use vcopy.
2076 * lread.c (read_vector): Use ASET.
2077 * msdos.c (Frecent_doskeys): Use vcopy.
2078 * xface.c (Finternal_copy_lisp_face): Use vcopy.
2079 (Finternal_merge_in_global_face): Use ASET and vcopy.
2080 * xfont.c (xfont_list_pattern): Likewise.
2081
5481664a
MR
20822012-08-21 Martin Rudalics <rudalics@gmx.at>
2083
2084 * window.c (Fwindow_point): For the selected window always return
2085 the position of its buffer's point.
2086 (Fset_window_point): For the selected window always go in its
2087 buffer to the specified position.
2088
6d470bdd
DA
20892012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2090
2091 Setter macros for fontsets.
2092 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
2093 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
2094 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
2095 Adjust users.
2096
24564fe1
GM
20972012-08-20 Glenn Morris <rgm@gnu.org>
2098
2099 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2100 Don't assume that `ln -f' works.
2101
0a05a035
EZ
21022012-08-20 Eli Zaretskii <eliz@gnu.org>
2103
2104 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
2105 and later about non-assignments with no effect. See discussion at
2106 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
2107 details.
2108
e46f2325
DA
21092012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2110
2111 Inline setter functions for Lisp_Objects slots of struct specbinding.
2112 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
2113 Adjust users.
2114
734fbd86
MR
21152012-08-20 Martin Rudalics <rudalics@gmx.at>
2116
2117 * window.c (select_window): Always make selected window's buffer
2118 current.
2119
f1a95992
DA
21202012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2121
2122 Use AREF and ASET for docstrings of category tables.
2123 * category.h (CATEGORY_DOCSTRING): Use AREF.
2124 (SET_CATEGORY_DOCSTRING): Use ASET.
2125 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
2126
e83064be
DA
21272012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2128
2129 Inline setter functions for hash table members.
2130 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
2131 (set_hash_hash, set_hash_index): Rename with _slot suffix.
2132 (set_hash_key_and_value, set_hash_index, set_hash_next)
2133 (set_hash_hash): New functions.
2134 * charset.c, fns.c: Adjust users.
2135
4ce60d2e
DA
21362012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2137
2138 Inline getter and setter functions for per-buffer values.
2139 * buffer.h (per_buffer_default, set_per_buffer_default)
2140 (per_buffer_value, set_per_buffer_value): New functions.
2141 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
2142 * buffer.c, data.c: Adjust users.
2143
c06c9690
JB
21442012-08-20 Juanma Barranquero <lekktu@gmail.com>
2145
2146 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
2147
32bd4250
PE
21482012-08-19 Paul Eggert <eggert@cs.ucla.edu>
2149
bad03192 2150 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
2151 as gnulib does this if the system doesn't.
2152 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
2153 Remove declaration. MS-Windows declares it on stdlib.h which is
2154 included by conf_post.h.
b69a6d22
PE
2155 * emacs.c (environ) [DOUG_LEA_MALLOC]:
2156 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
2157 * vm-limit.c: Include <unistd.h>, for 'environ'.
2158
22d7feb2
PE
2159 * unexaix.c, unexcoff.c: Include "mem-limits.h".
2160 (start_of_data): Remove decl; mem-limits.h provides it.
2161
32bd4250
PE
2162 * xdisp.c (handle_invisible_prop): Make it a bit faster
2163 and avoid a gcc -Wmaybe-uninitialized diagnostic.
2164
450809af
CY
21652012-08-19 Chong Yidong <cyd@gnu.org>
2166
2167 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
2168 ends (Bug#3874).
2169
9e677988
AS
21702012-08-19 Andreas Schwab <schwab@linux-m68k.org>
2171
6b1319ce
AS
2172 * .gdbinit: Use call instead of set when calling a function in the
2173 inferior.
2174
9e677988
AS
2175 * data.c (set_internal): Don't use set_blv_found.
2176 (Fkill_local_variable): Likewise.
2177
d7191076
AA
21782012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
2179
2180 * nsfont.m (ns_ascii_average_width): Ensure the string
2181 ascii_printable is initialized with a null-terminated character
2182 array. Otherwise, it can contain undesired extra characters.
2183
e757f1c6
PE
21842012-08-18 Paul Eggert <eggert@cs.ucla.edu>
2185
2186 port new setting code to Sun C 5.8 2005/10/13
2187 * chartab.c, lisp.h (char_table_set, char_table_set_range):
2188 Return void, not Lisp_Object. Otherwise, the compiler
2189 complains about (A?B:C) where B is void and C is Lisp_Object
2190 when compiling CHAR_TABLE_SET, due to the recent change to
2191 the API of sub_char_table_set_contents.
2192
a999ce26
CY
21932012-08-18 Chong Yidong <cyd@gnu.org>
2194
2195 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
2196 for the string case (Bug#3874).
2197
3f22b86f
PE
21982012-08-18 Paul Eggert <eggert@cs.ucla.edu>
2199
39eb03f1
PE
2200 * buffer.h (BSET): Remove (Bug#12215).
2201 Replace all uses with calls to new setter functions.
2202 (bset_bidi_paragraph_direction, bset_case_canon_table)
2203 (bset_case_eqv_table, bset_directory, bset_display_count)
2204 (bset_display_time, bset_downcase_table)
2205 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
2206 (bset_last_selected_window, bset_local_var_alist)
2207 (bset_mark_active, bset_point_before_scroll, bset_read_only)
2208 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
2209 (bset_width_table):
2210 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
2211 (bset_auto_fill_function, bset_auto_save_file_format)
2212 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
2213 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
2214 (bset_cache_long_line_scans, bset_case_fold_search)
2215 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
2216 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
2217 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
2218 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
2219 (bset_header_line_format, bset_indicate_buffer_boundaries)
2220 (bset_indicate_empty_lines, bset_invisibility_spec)
2221 (bset_left_fringe_width, bset_major_mode, bset_mark)
2222 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
2223 (bset_name, bset_overwrite_mode, bset_pt_marker)
2224 (bset_right_fringe_width, bset_save_length)
2225 (bset_scroll_bar_width, bset_scroll_down_aggressively)
2226 (bset_scroll_up_aggressively, bset_selective_display)
2227 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
2228 (bset_word_wrap, bset_zv_marker):
2229 * category.c (bset_category_table):
2230 * syntax.c (bset_syntax_table):
2231 New setter functions.
2232
6a09a33b
PE
2233 * process.h (PSET): Remove (Bug#12215).
2234 Replace all uses with calls to new setter functions.
2235 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2236 (PROCESS_INLINE): New macro.
2237 (pset_childp): New setter function.
2238 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
2239 * process.c (PROCESS_INLINE):
2240 Define to EXTERN_INLINE, so that the corresponding functions
2241 are compiled into code.
2242 (pset_buffer, pset_command, pset_decode_coding_system)
2243 (pset_decoding_buf, pset_encode_coding_system)
2244 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
2245 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
2246 (pset_type, pset_write_queue): New setter functions.
2247
e8c17b81
PE
2248 * window.h (WSET): Remove (Bug#12215).
2249 Replace all uses with calls to new setter functions.
2250 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2251 (WINDOW_INLINE): New macro.
2252 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
2253 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
2254 (wset_total_lines, wset_vertical_scroll_bar)
2255 (wset_window_end_pos, wset_window_end_valid)
2256 (wset_window_end_vpos): New setter functions.
2257 * window.c (WINDOW_INLINE):
2258 Define to EXTERN_INLINE, so that the corresponding functions
2259 are compiled into code.
2260 (wset_combination_limit, wset_dedicated, wset_display_table)
2261 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
2262 (wset_new_normal, wset_new_total, wset_next_buffers)
2263 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
2264 (wset_prev_buffers, wset_right_fringe_width)
2265 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
2266 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
2267 (wset_window_parameters):
2268 * xdisp.c (wset_base_line_number, wset_base_line_pos)
2269 (wset_column_number_displayed, wset_region_showing):
2270 New setter functions.
2271
3f22b86f
PE
2272 * termhooks.h (TSET): Remove (Bug#12215).
2273 Replace all uses with calls to new setter functions.
2274 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2275 (TERMHOOKS_INLINE): New macro.
2276 (tset_charset_list, tset_selection_alist): New setter functions.
2277 * terminal.c (TERMHOOKS_INLINE):
2278 Define to EXTERN_INLINE, so that the corresponding functions
2279 are compiled into code.
2280 (tset_param_alist): New setter function.
2281
742af32f
PE
22822012-08-17 Paul Eggert <eggert@cs.ucla.edu>
2283
15dbb4d6
PE
2284 * keyboard.h (KSET): Remove (Bug#12215).
2285 Replace all uses with calls to new setter functions.
2286 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2287 (KEYBOARD_INLINE): New macro.
2288 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
2289 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
2290 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
2291 New setter functions.
2292 * keyboard.c (KEYBOARD_INLINE):
2293 Define to EXTERN_INLINE, so that the corresponding functions
2294 are compiled into code.
2295 (kset_echo_string, kset_kbd_queue)
2296 (kset_keyboard_translate_table, kset_last_prefix_arg)
2297 (kset_last_repeatable_command, kset_local_function_key_map)
2298 (kset_overriding_terminal_local_map, kset_real_last_command)
2299 (kset_system_key_syms): New setter functions.
2300
f00af5b1
PE
2301 * frame.h (FSET): Remove (Bug#12215).
2302 Replace all uses with calls to new setter functions.
2303 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2304 (FRAME_INLINE): New macro.
2305 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
2306 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
2307 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
2308 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
2309 (fset_param_alist, fset_root_window, fset_scroll_bars)
2310 (fset_selected_window, fset_title, fset_tool_bar_items)
2311 (fset_tool_bar_position, fset_tool_bar_window): New functions.
2312 * frame.c (FRAME_INLINE):
2313 Define to EXTERN_INLINE, so that the corresponding functions
2314 are compiled into code.
2315 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
2316
0c94c8d6
PE
2317 A few more naming-convention fixes for getters and setters.
2318 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
2319 and rename from buffer_overlays_set_before.
2320 (set_buffer_overlays_after): Move here from buffer.h, and rename
2321 from buffer_overlays_set_after.
2322 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
2323 All uses changed.
2324 (set_buffer_intervals): Rename from buffer_set_intervals.
2325 * intervals.c (set_interval_object): Move here from intervals.h,
2326 and rename from interval_set_object.
2327 (set_interval_left): Move here from intervals.h, and rename from
2328 interval_set_left.
2329 (set_interval_right): Move here from intervals.h, and rename from
2330 interval_set_right.
2331 (copy_interval_parent): Move here from intervals.h, and rename from
2332 interval_copy_parent.
2333 * intervals.h (set_interval_parent): Rename from interval_set_parent.
2334 (set_interval_plist): Rename from interval_set_plist.
2335 Return void, not Lisp_Object, since no caller uses the result.
2336 * lisp.h (string_intervals): Rename from string_get_intervals.
2337 (set_string_intervals): Rename from string_set_intervals.
2338
34dabdb7
PE
2339 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
2340 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 2341 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
2342 All uses changed. See the end of
2343 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
2344
742af32f
PE
2345 * lisp.h (CSET): Remove (Bug#12215).
2346 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
2347 (set_char_table_purpose): New functions,
2348 replacing CSET. All uses changed. For example, replace
2349 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 2350 "set_char_table_parent (char_table, parent);".
742af32f
PE
2351 The old version was confusing because it used the same name
2352 'parent' for two different things.
2353
a04e2c62
DA
23542012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2355
2356 Functions to get and set Lisp_Object fields of buffer-local variables.
2357 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
2358 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
2359 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
2360 * data.c, eval.c, frame.c: Adjust users.
2361
383dcbf9
CY
23622012-08-17 Chong Yidong <cyd@gnu.org>
2363
2364 * xfaces.c (merge_face_vectors): If the target font specfies a
2365 font spec, make the font's attributes take precedence over
2366 directly-specified attributes.
2367 (merge_face_ref): Recognize :font.
2368
44386687
DA
23692012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2370
2371 Do not use memcpy for copying intervals.
2372 * intervals.c (reproduce_interval): New function.
2373 (reproduce_tree, reproduce_tree_obj): Use it.
2374 (reproduce_tree_obj): Remove prototype.
2375
927c7216
PE
23762012-08-17 Paul Eggert <eggert@cs.ucla.edu>
2377
2378 * lisp.h (duration_to_sec_usec): Remove unused decl.
2379
93044f7b
AA
23802012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
2381
2382 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
2383 to an allocated instance of NSString, not to the class itself.
2384
9851e4a5
JB
23852012-08-17 Juanma Barranquero <lekktu@gmail.com>
2386
2387 * makefile.w32-in (C_CTYPE_H): New macro.
2388 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
2389 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
2390 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
2391
620f13b0
PE
23922012-08-16 Paul Eggert <eggert@cs.ucla.edu>
2393
2394 Use ASCII tests for character types.
2395 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
2396 * xfns.c, xterm.c:
2397 Don't include <ctype.h>; was not needed.
2398 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
2399 * sysdep.c, xfaces.c:
2400 Include <c-ctype.h> instead of <ctype.h>.
2401 * nsterm.m: Include <c-ctype.h>.
2402 * charset.c (read_hex):
2403 * doc.c (Fsnarf_documentation):
2404 * fileio.c (IS_DRIVE) [WINDOWSNT]:
2405 (DRIVE_LETTER) [DOS_NT]:
2406 (Ffile_name_directory, Fexpand_file_name)
2407 (Fsubstitute_in_file_name):
2408 * font.c (font_parse_xlfd, font_parse_fcname):
2409 * frame.c (x_set_font_backend):
2410 * gtkutil.c (xg_get_font):
2411 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
2412 * nsimage.m (hexchar):
2413 * nsterm.m (ns_xlfd_to_fontname):
2414 * sysdep.c (system_process_attributes):
2415 * xfaces.c (hash_string_case_insensitive):
2416 Use C-locale tests instead of locale-specific tests for character
2417 types, since we want the ASCII interpretation here, not the
2418 interpretation suitable for whatever happens to be the current locale.
2419
52162052
MR
24202012-08-16 Martin Rudalics <rudalics@gmx.at>
2421
2422 Consistently check windows for validity/liveness
2423 (Bug#11984, Bug#12025, Bug#12026).
2424 * lisp.h (CHECK_VALID_WINDOW): New macro.
2425 * window.c (decode_window): Rename to decode_live_window.
2426 (decode_valid_window, Fwindow_valid_p): New functions.
2427 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
2428 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
2429 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
2430 (Fwindow_prev_sibling, Fwindow_combination_limit)
2431 (Fset_window_combination_limit, Fwindow_use_time)
2432 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
2433 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
2434 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
2435 (Fwindow_hscroll, Fset_window_hscroll)
2436 (Fwindow_redisplay_end_trigger)
2437 (Fset_window_redisplay_end_trigger, Fwindow_edges)
2438 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
2439 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2440 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
2441 (Fwindow_end, Fset_window_point, Fset_window_start)
2442 (Fpos_visible_in_window_p, Fwindow_line_height)
2443 (Fwindow_dedicated_p, Fset_window_dedicated_p)
2444 (Fwindow_prev_buffers, Fset_window_prev_buffers)
2445 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
2446 (Fset_window_parameter, Fwindow_display_table)
2447 (Fset_window_display_table, Fdelete_other_windows_internal)
2448 (Fset_window_buffer, Fset_window_new_total)
2449 (Fset_window_new_normal, Fdelete_window_internal)
2450 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
2451 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
2452 (Fwindow_scroll_bars): Check whether argument window is a valid or
2453 live window. Update doc-strings.
2454 (syms_of_window): New symbol Qwindow_valid_p.
2455 * keyboard.c (Fposn_at_x_y): Check whether argument
2456 frame_or_window denotes a valid window.
2457
2751c80f
DA
24582012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
2459
2460 Fix previous char table change.
2461 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
2462 * chartab.c (optimize_sub_char_table): Likewise.
2463
032a42c8
CY
24642012-08-16 Chong Yidong <cyd@gnu.org>
2465
a2d19368
CY
2466 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
2467
032a42c8
CY
2468 * xfont.c (xfont_open):
2469 * xftfont.c (xftfont_open): Set the font's max_width field.
2470
2471 * nsfont.m (nsfont_open): Similar to the Xft backend, set
2472 min_width to space_width and average_width to the average over
2473 printable ASCII characters.
2474 (ns_char_width): Code cleanup.
2475 (ns_ascii_average_width): New utility function.
2476
2477 * font.h (struct font): Update comments.
2478
a098c930
DA
24792012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
2480
032a42c8 2481 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
2482 * lisp.h (CSET): New macro.
2483 (char_table_set_extras, char_table_set_contents)
2484 (sub_char_table_set_contents): New function.
2485 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
2486 * syntax.c: Adjust users.
2487
8be3a09c
SM
24882012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
2489
2490 * eval.c (eval_sub): Bind lexical-binding.
2491 * lread.c (Qlexical_binding): Make non-static.
2492
ac4845a6
JD
24932012-08-15 Jan Djärv <jan.h.d@swipnet.se>
2494
ddee6515
JD
2495 * nsmenu.m (popupSession): Remove.
2496 (pop_down_menu): Remove endModalSession.
2497 (timeout_handler:): New method.
2498 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
2499 Call runModalForWindow. Check timer_fired when it returns.
2500 If not set, cancel timer and break out of loop.
2501 Otherwise loop again, with a new timeout.
2502
2503 * nsterm.m: Include fcntl.h if present.
2504 (fd_entry, t_readfds, inNsSelect): Remove.
2505 (select_writefds, select_valid, select_timeout, selfds)
2506 (select_mutex, apploopnr): Add.
2507 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
2508 Otherwise call kbd_buffer_store_event.
2509 (ns_send_appdefined): Remove release of fd_entry.
2510 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
2511 Increment and decrement apploopnr.
2512 (ns_select): If no file descriptors, just do a NSTimer.
2513 Otherwise copy read/write masks and start select thread (fd_handler).
2514 Start main loop and wait for application defined event.
2515 Inform select thread to stop selecting after main loop is exited.
2516 (ns_term_init): Create selfds pipe and set non-blocking.
fc0c31f8 2517 Initialize select_mutex. Start the select thread (fd_handler).
ddee6515
JD
2518 (fd_handler:): Loop forever, wait for info from the main thread
2519 to either start or stop selecting. When select returns, send
2520 and appdefined event.
2521 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
2522 If not call kbd_buffer_store_event.
2523
2524 * nsterm.h (EmacsApp): fd_handler takes id argument.
2525 (EmacsDialogPanel): Add timer_fired and timeout_handler.
2526
ac4845a6
JD
2527 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
2528
eb424fe3
EZ
25292012-08-15 Eli Zaretskii <eliz@gnu.org>
2530
2531 * region-cache.c (move_cache_gap): Update gap_len using the actual
2532 growth of the boundaries array. Do not change cache_len.
2533 (Bug#12196)
2534
4e6a86c6
DA
25352012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2536
2537 Generalize and cleanup font subsystem checks.
2538 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
2539 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
2540 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 2541
5bf192ca
DA
25422012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2543
2544 * gtkutil.c (xg_get_font): Use pango_units_to_double.
2545
f2045622
CY
25462012-08-15 Chong Yidong <cyd@gnu.org>
2547
8be3a09c
SM
2548 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
2549 When using the new font chooser, use gtk_font_chooser_get_font_desc to
2550 extract the font descriptor instead of just the font name.
2551 In that case, return a font spec instead of a string.
f2045622
CY
2552 (x_last_font_name): Move to this file from xfns.c.
2553
2554 * xfns.c (Fx_select_font): The return value can also be a font
2555 spec. Move x_last_font_name management to gtkutil.c.
2556
2557 * xfaces.c: Make font weight and style symbols non-static.
2558
7f6feb56
SM
25592012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
2560
2561 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
2562 (bug#12117).
2563
fecbd8ff
SM
25642012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
2565
2566 * alloc.c (Fgarbage_collect): Use plural form consistently.
2567
9b8d5165
EZ
25682012-08-14 Eli Zaretskii <eliz@gnu.org>
2569
2570 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
2571 iteration through the command loop. Fixes a problem whereby mouse
2572 movements are ignored until the first mouse click.
2573
f5d9e83a
PE
25742012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2575
2576 Use bool, not int, for Lisp booleans.
2577 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
2578 makes Emacs a bit smaller and presumably a bit faster.
2579 * lisp.h: Include <stdbool.h>.
2580 (struct Lisp_Boolfwd, defvar_bool):
2581 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
2582 * regex.c [!emacs]: Include <stdbool.h>.
2583 (false, true): Remove; <stdbool.h> does this for us now.
2584
55802e4a
CY
25852012-08-14 Chong Yidong <cyd@gnu.org>
2586
4abcdac8
CY
2587 * character.c (Fcharacterp): Doc fix (Bug#12076).
2588
2589 * data.c (Findirect_variable): Doc fix (Bug#11040).
2590
55802e4a
CY
2591 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
2592
2593 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 2594 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 2595
8e99d072
BR
25962012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2597
2598 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
2599 (bug#12022).
2600
08908aca
MR
26012012-08-14 Martin Rudalics <rudalics@gmx.at>
2602
2603 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
2604 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
2605 * minibuf.c (choose_minibuf_frame, read_minibuf):
2606 * w32fns.c (x_create_tip_frame):
2607 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
2608 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
2609
56120d6f
PE
26102012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2611
2612 * intervals.c (offset_intervals): Remove obsolete comment.
2613
67b77c0b
AS
26142012-08-14 Andreas Schwab <schwab@linux-m68k.org>
2615
2616 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
2617
f48b82fd
GR
26182012-08-14 Gergely Risko <gergely@risko.hu>
2619
2620 * coding.c (decode_coding): Record buffer modification before
2621 disabling undo_list (Bug#11773).
2622
fd318b54
DA
26232012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2624
2625 Revert and cleanup some recent overlay changes.
2626 * buffer.h (enum overlay_type): Remove.
2627 (buffer_get_overlays, buffer_set_overlays): Likewise.
2628 (buffer_set_overlays_before, buffer_set_overlays_after):
2629 New function. Adjust users.
2630 (unchain_both): Add eassert.
2631
41a62dd9
DA
26322012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2633
2634 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
2635
5884c324
PE
26362012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2637
2638 * gtkutil.c (xg_mark_data): Don't assume C99.
2639
ca06f160
JD
26402012-08-13 Jan Djärv <jan.h.d@swipnet.se>
2641
2642 * gtkutil.c (xg_frame_tb_info): New struct.
2643 (TB_INFO_KEY): New define.
2644 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
2645 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
2646 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
2647 if not present.
2648 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
fc0c31f8 2649 is up to date. Otherwise store new data.
ca06f160
JD
2650 (free_frame_tool_bar): Free xg_frame_tb_info if present.
2651
7864a3f7
DA
26522012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2653
2654 Use KSET for write access to Lisp_Object members of struct kboard.
2655 * keyboard.h (KSET): New macro.
2656 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
2657 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
2658 * xterm.c: Adjust users.
2659
4c31be61
DA
26602012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2661
2662 Use BSET for write access to Lisp_Object members of struct buffer.
2663 * buffer.h (BSET): New macro.
2664 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
2665 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
2666 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
2667 * window.c, xdisp.c, xfns.c: Adjust users.
2668
14ae4239
BT
26692012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
2670
2671 * lread.c (syms_of_lread): Initialize Vlexical_binding.
2672
32bcadb4
JD
26732012-08-11 Jan Djärv <jan.h.d@swipnet.se>
2674
3d29b2ce 2675 * nsterm.m (not_in_argv): New function.
fc0c31f8 2676 (application:openFile, application:openTempFile:):
3d29b2ce
JD
2677 (application:openFileWithoutUI:, application:openFiles:): Open file
2678 if not_in_argv returns non-zero (bug#12171).
2679
32bcadb4 2680 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
2681 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
2682 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
2683 (xg_get_font_name): Use those functions/macros here.
2684 Reported by Frans Oilinki <moilinki@gmail.com>.
2685
9ff9402d 26862012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
2687
2688 * unexmacosx.c (copy_data_segment): Copy initialized data in
2689 statically linked libraries from input file rather than memory.
2690
db74a5fc
YM
2691 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
2692 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
2693 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
2694
25e65510
GM
26952012-08-10 Glenn Morris <rgm@gnu.org>
2696
2697 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
2698 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
2699
7961135c
DA
27002012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2701
2702 Fix last change to allow compilation with low optimization levels.
2703 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
2704 Reported by Jan Djärv <jan.h.d@swipnet.se>.
2705
42b3a444
DA
27062012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2707
2708 Use common inline syntax in intervals.h.
2709 * intervals.h (INTERVALS_INLINE): New macro.
2710 Change all users from LISP_INLINE.
2711
9fb0c957
DA
27122012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2713
2714 Define Qnone once for all platforms.
2715 * frame.c (Qnone): Define here.
2716 (syms_of_frame): DEFSYM it.
2717 * lisp.h (Qnone): New declaration.
2718 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
2719 * xfns.c: Remove duplication. Adjust users.
2720
65e8ee52
DA
27212012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2722
2723 Remove unused macros from intervals.h.
2724 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
2725 * intervals.c: Adjust comment.
2726
9b855fd6
EZ
27272012-08-10 Eli Zaretskii <eliz@gnu.org>
2728
2729 * w32fns.c <w32_unicode_gui>: New static variable.
2730 (globals_of_w32fns): Initialize it according to os_subtype.
2731 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
2732 testing os_subtype.
2733
39cb9e56 27342012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
2735 Eli Zaretskii <eliz@gnu.org>
2736
2737 Fix bug #10299 with Unicode characters sent by customized
2738 keyboards created by MSKLC.
2739 * w32fns.c (INIT_WINDOW_CLASS): New macro.
2740 (w32_init_class): Use it to initialize the Emacs class with either
2741 ANSI or Unicode API calls.
2742 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
2743 later.
2744 (w32_wnd_proc): If the character code sent by WM_CHAR or
2745 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
2746 original message. Call DefWindowProcW on NT and later.
2747
9374581a
GM
27482012-08-10 Glenn Morris <rgm@gnu.org>
2749
4b94e8cf
GM
2750 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
2751
9374581a
GM
2752 * lisp.h (DIRECTORY_SEP): Let configure set it.
2753
a2752828
DA
27542012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2755
2756 Use TSET for write access to Lisp_Object slots of struct terminal.
2757 * termhooks.h (TSET): New macro.
2758 * coding.c, terminal.c, xselect.c: Adjust users.
2759
cc92c454
SM
27602012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
2761
2762 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
2763 the failing expression, include them in the error message.
2764 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
2765 * lisp.h (internal_condition_case_n): Update declaration.
2766
4cb3e6b3
DA
27672012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2768
2769 Inline functions to examine and change buffer overlays.
2770 * buffer.c (unchain_both): New function.
2771 * buffer.h (buffer_get_overlays, buffer_set_overlays):
2772 (buffer_has_overlays): New function.
2773 (enum overlay_type): New enum.
2774 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
2775 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
2776
8707c1e5
DA
27772012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2778
2779 Inline functions to examine and change buffer intervals.
2780 * alloc.c (mark_interval_tree): Remove.
2781 (MARK_INTERVAL_TREE): Simplify.
2782 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
2783 * intervals.c (buffer_balance_intervals): New function.
2784 (graft_intervals_into_buffer): Adjust indentation.
2785 (set_intervals_multibyte): Simplify.
2786 * buffer.h (BUF_INTERVALS): Remove.
2787 (buffer_get_intervals, buffer_set_intervals): New function.
2788 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
2789 * intervals.c, textprop.c: Adjust users.
2790
ad8c997f
DA
27912012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2792
2793 Inline functions to examine and change string intervals.
2794 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
2795 (string_get_intervals, string_set_intervals): New function.
2796 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2797 * lread.c, print.c, textprop.c: Adjust users.
2798
32ac3a6b
GM
27992012-08-08 Glenn Morris <rgm@gnu.org>
2800
2801 * lisp.mk (lisp): Remove language/persian.elc.
2802
77c7bcb1
DA
28032012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2804
2805 Cleanup intervals.
2806 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
2807 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
2808 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
2809 Adjust comment. Move under #if 0.
77c7bcb1
DA
2810 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2811 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
2812
9c08a8d4
DA
28132012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2814
2815 Check total length of intervals with eassert.
2816 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
2817 * intervals.c: Change all users to eassert.
2818
26d16b35
EZ
28192012-08-07 Eli Zaretskii <eliz@gnu.org>
2820
14ae4239
BT
2821 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
2822 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
2823 INTERNAL_FIELD in Lisp_Cons.
2824
c644523b
DA
28252012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2826
2827 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
2828 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
2829 name since all xname users are fixed long time ago. Do not
2830 use INTERNAL_FIELD.
2831 (set_symbol_name, set_symbol_function, set_symbol_plist):
2832 (set_symbol_next, set_overlay_plist): New function.
2833 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
2834 (struct Lisp_Overlay): Likewise.
2835 (CVAR, MVAR, SVAR): Remove.
2836 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
2837 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
2838 * xterm.c: Adjust users.
2839 * .gdbinit: Change to use name field of struct Lisp_Symbol
2840 where appropriate.
2841
6a3d20cc
DA
28422012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2843
2844 Basic functions to set Lisp_Object and pointer slots of intervals.
2845 * intervals.h (interval_set_parent, interval_set_object):
2846 (interval_set_left, interval_set_right, interval_set_plist):
2847 (interval_copy_parent): New function.
2848 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
2849 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
2850 Adjust indentation.
6a3d20cc
DA
2851 (INTERVAL_SIZE): Remove. Adjust users.
2852 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
2853
4d2b044c
DA
28542012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2855
2856 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
2857 * process.h (PGET): Remove.
2858 (struct Lisp_Process): Do not use INTERNAL_FIELD.
2859 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2860
d3d50620
DA
28612012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2862
2863 Drop WGET and revert read access to Lisp_Objects slots of struct window.
2864 * window.h (WGET): Remove.
2865 (struct window): Do not use INTERNAL_FIELD.
2866 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2867 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2868 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2869 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2870 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2871 Adjust users.
2872
d10a51dc
CY
28732012-08-07 Chong Yidong <cyd@gnu.org>
2874
2875 * window.c (Fwindow_edges, Fwindow_pixel_edges)
2876 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
2877 (Fdelete_window_internal): Signal an error if the window is not on
2878 a live frame (Bug#12025).
2879
e69b0960
DA
28802012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2881
2882 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
2883 * frame.h (FGET): Remove.
2884 (struct frame): Do not use INTERNAL_FIELD.
2885 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2886 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2887 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2888 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2889
25a20a3a
JB
28902012-08-06 Juanma Barranquero <lekktu@gmail.com>
2891
2892 * w32.c: Silence compiler warnings.
2893 (map_w32_filename): Remove unused variable `is_fat'.
2894 (chase_symlinks): Add parentheses around expression.
2895
1c6f11f4
GM
28962012-08-06 Glenn Morris <rgm@gnu.org>
2897
1db4583a
GM
2898 * sysdep.c: Respect BROKEN_GETWD.
2899
1c6f11f4
GM
2900 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
2901 Let configure handle it.
2902 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
2903
2b90362b
DA
29042012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2905
2906 Use GCALIGNMENT where appropriate.
2907 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
2908 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
2909 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
2910
5f50daf2
EZ
29112012-08-06 Eli Zaretskii <eliz@gnu.org>
2912
14ae4239
BT
2913 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
2914 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 2915
cbcc7007
SM
29162012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
2917
2918 * buffer.h (struct buffer): Revert `indirections' to a simple int;
2919 that should be sufficient for everyone.
2920
4d365fa4
JD
29212012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2922
2923 * keyboard.c (timer_check_2): Add break so timer_check returns next
2924 timeout.
2925
dd86bd82
DA
29262012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2927
2928 Fix Windows build errors introduced after converting to WGET and WSET.
2929 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
2930 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2931
054e1668
JD
29322012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2933
2934 * nsterm.m (ns_frame_rehighlight): Use FSET.
2935
2936 * nsmenu.m (ns_update_menubar): Use FSET.
2937
21238f11
DA
29382012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2939
2940 Separate read and write access to Lisp_Object slots of Lisp_Process.
2941 * process.h (PGET, PSET): New macros similar to AREF and ASET.
2942 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2943
077288cf
DA
29442012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2945
2946 Separate read and write access to Lisp_Object slots of struct window.
2947 * window.h (WGET, WSET): New macros similar to AREF and ASET.
2948 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2949 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2950 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2951 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2952 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2953 Adjust users.
2954
71688bd7
DA
29552012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2956
2957 Fix Windows build errors introduced after converting to FGET and FSET.
2958 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
2959 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
2960 (w32_judge_scroll_bars): Change to use FSET.
2961 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2962
f99bac93
DA
29632012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2964
2965 Fix replacement typo.
2966 * window.c (replace_window): Set root_window instead of
2967 selected_window. This fixes a total window subsystem
2968 malfunction reported by Bastien Guerry <bzg@gnu.org>.
2969
8c2a0f2d
GM
29702012-08-06 Glenn Morris <rgm@gnu.org>
2971
2972 * lisp.mk (lisp): Add language/persian.elc.
2973
edd74c35
DA
29742012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2975
2976 Separate read and write access to Lisp_Object slots of struct frame.
2977 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
2978 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2979 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2980 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2981 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2982
8671676c
AS
29832012-08-05 Andreas Schwab <schwab@linux-m68k.org>
2984
2985 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
2986
663e2b3f
DA
29872012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2988
2989 Generalize common compile-time constants.
2990 * lisp.h (header_size, bool_header_size, word_size): Now here.
2991 (struct Lisp_Vector): Add comment.
2992 (struct Lisp_Bool_Vector): Move up to define handy constants.
2993 (VECSIZE, PSEUDOVECSIZE): Simplify.
2994 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
2995 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
2996 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
2997 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
2998 * xfont.c, xmenu.c: Use word_size where appropriate.
2999
d32e47af
LM
30002012-08-05 Lawrence Mitchell <wence@gmx.li>
3001
3002 * search.c (Freplace_match): Treat \? in the replacement text
3003 literally (Bug#8161).
3004
e5d9c0d1
CY
30052012-08-05 Chong Yidong <cyd@gnu.org>
3006
3007 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
3008 * frame.c (Vdelete_frame_functions):
3009 * emacs.c (Vkill_emacs_hook): Doc fix.
3010
8da0576b
EZ
30112012-08-04 Eli Zaretskii <eliz@gnu.org>
3012
3013 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
3014 --with-x-toolkit=no builds.
3015 Reported by Carsten Mattner <carstenmattner@gmail.com>.
3016
02676e5d
CY
30172012-08-04 Chong Yidong <cyd@gnu.org>
3018
3019 * syntax.c (Fmodify_syntax_entry): Doc fix.
3020
97147da9
EZ
30212012-08-04 Eli Zaretskii <eliz@gnu.org>
3022
76151e2c
EZ
3023 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
3024 * w32.c (init_environment): Change the default values of many
3025 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
3026 them into environment when they were not already defined.
3027 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 3028 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
3029 (check_windows_init_file): Now external, not static.
3030 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
3031 called when Vload_path is already set up.
3032
3033 * w32.h (check_windows_init_file): Add prototype.
3034
3035 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
3036 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
3037 compatibility with Posix platforms.
3038 (main): Move the call to check_windows_init_file to here from
3039 w32.c.
3040 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
3041 any, in the DEFALT argument into the root of the Emacs build or
3042 installation tree, as appropriate.
3043
3044 * callproc.c (init_callproc_1): Call decode_env_path instead of
3045 doing its equivalent by hand.
3046 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
3047 the code that sets Vexec_path run on MS-Windows.
3048
3049 * lread.c (init_lread): Add comments to #ifdef's.
3050
97147da9
EZ
3051 * msdos.c (dos_set_window_size, IT_update_begin)
3052 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
3053 instead of direct references.
3054
185ee146
PE
30552012-08-04 Paul Eggert <eggert@cs.ucla.edu>
3056
3057 Export DEFAULT_REHASH_* to GDB.
3058 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
3059 Now constants, not macros.
3060
8834c57a
PE
30612012-08-03 Paul Eggert <eggert@cs.ucla.edu>
3062
98c6f1e3
PE
3063 Remove unnecessary casts involving pointers.
3064 These casts are no longer needed now that we assume C89 or later,
3065 since they involve casting to or from void *.
3066 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
3067 (make_pure_float, make_pure_vector):
3068 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
3069 * macros.c (Fstart_kbd_macro):
3070 * menu.c (find_and_return_menu_selection):
3071 * minibuf.c (read_minibuf_noninteractive):
3072 * sysdep.c (closedir):
3073 * xdisp.c (x_produce_glyphs):
3074 * xfaces.c (compare_fonts_by_sort_order):
3075 * xfns.c (x_real_positions, select_visual):
3076 * xselect.c (x_stop_queuing_selection_requests)
3077 (x_get_window_property, x_get_window_property_as_lisp_data):
3078 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
3079 Remove unnecessary pointer casts.
3080 * alloc.c (record_xmalloc): New function.
3081 * lisp.h (record_xmalloc): New decl.
3082 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
3083 more like a function. This is because the pointer cast is not
3084 needed. All uses changed.
3085 * print.c (print_string, print_error_message): Avoid length recalc.
3086
8834c57a
PE
3087 Improve fix for macroexp crash with debugging (Bug#12118).
3088 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
3089 ARRAY_MARK_FLAG when checking subscripts, because ASET is
3090 not supposed to be invoked from the garbage collector.
3091 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
3092 (gc_aset): New function, which is like ASET but can be
3093 used in the garbage collector.
3094 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
3095 (set_hash_index): Use it instead of ASET.
3096
6dad7178
EZ
30972012-08-03 Eli Zaretskii <eliz@gnu.org>
3098
3099 Support symlinks on latest versions of MS-Windows.
3100 * w32.c: Include winioctl.h and aclapi.h.
3101 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
3102 (revert_to_self): Forward declarations of static functions.
3103 <static BOOL g_b_init_get_security_info>:
3104 <g_b_init_create_symbolic_link>: New static flags.
3105 (globals_of_w32): Initialize them to zero.
3106 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
3107 (map_w32_filename): Improve commentary. Simplify switch.
3108 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
3109 headers (most versions of MinGW w32api don't).
3110 (get_security_info, create_symbolic_link)
3111 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
3112 New functions.
3113 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
3114 in the argument file name.
3115 (sys_access): Call unc_volume_file_attributes only if
3116 GetFileAttributes fails with network-related error codes.
3117 (sys_rename): Diagnose renaming of a symlink when the user doesn't
3118 have the required privileges.
14ae4239 3119 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
3120 get_file_security_desc.
3121 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
3122 with addition of handling of symlinks and support for 'lstat'.
3123 If possible, get file's attributes and security information by
6dad7178
EZ
3124 handle, not by name. Produce S_IFLNK bit for symlinks, when
3125 called from 'lstat'.
3126 (stat, lstat): New functions, call 'stat_worker'.
3127 (symlink, readlink, careadlinkat): Rewritten to create and resolve
3128 symlinks when the underlying filesystem supports them.
3129
f162bcc3
PE
31302012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3131
79ea6c20
PE
3132 Fix macroexp crash on Windows with debugging (Bug#12118).
3133 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
3134 checking subscripts; problem introduced with the recent
3135 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
3136 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
3137 since it's used in non-static inline functions now.
3138
c0ce93fd
PE
3139 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
3140 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 3141
f162bcc3
PE
3142 Use C99-style 'extern inline' if available.
3143 * buffer.h (BUFFER_INLINE):
3144 * category.h (CATEGORY_INLINE):
3145 * character.h (CHARACTER_INLINE):
3146 * charset.h (CHARSET_INLINE):
3147 * composite.h (COMPOSITE_INLINE):
3148 * dispextern.h (DISPEXTERN_INLINE):
3149 * lisp.h (LISP_INLINE):
3150 * systime.h (SYSTIME_INLINE):
3151 New macro, replacing 'static inline' in this header.
3152 * buffer.h, category.h, character.h, charset.h, composite.h:
3153 * dispextern.h, lisp.h, systime.h:
3154 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3155 * alloc.c (LISP_INLINE):
3156 * buffer.c (BUFFER_INLINE):
3157 * category.c (CATEGORY_INLINE):
3158 * character.c (CHARACTER_INLINE):
3159 * charset.c (CHARSET_INLINE):
3160 * composite.c (COMPOSITE_INLINE):
3161 * dispnew.c (DISPEXTERN_INLINE):
3162 * sysdep.c (SYSTIME_INLINE):
3163 Define to EXTERN_INLINE, so that the corresponding functions
3164 are compiled into code.
3165 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
3166 (INLINE_HEADER_END): New macros.
3167 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
3168 since it's used in non-static inline functions now.
a8333d03 3169 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 3170
837b365b
GM
31712012-08-02 Glenn Morris <rgm@gnu.org>
3172
d66b744d
GM
3173 * s/: Remove empty directory.
3174
837b365b
GM
3175 * s/ms-w32.h: Move to ../nt/inc.
3176 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
3177 Update for new ms-w32.h location.
3178
13294f95
PE
31792012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3180
3181 Port to Solaris 8.
3182 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
3183
90df0db3
GM
31842012-08-02 Glenn Morris <rgm@gnu.org>
3185
3186 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
3187 hard-coding the path separator.
3188
4939150c
PE
31892012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3190
3191 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
3192 This how ASET and AREF are supposed to work, and makes
3193 it easier to think about future improvements. See
3194 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
3195 * charset.h (set_charset_attr): New function.
3196 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
3197 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
3198 (aref_addr): New function. All uses of &AREF(...) changed.
3199 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
3200 (set_hash_index): New functions. All lvalue-style uses of
3201 HASH_KEY etc. changed.
3202 * keyboard.c (set_prop): New function. All lvalue-style uses
3203 of PROP changed.
3204
947b2afd
AA
32052012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
3206
3207 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
3208 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
3209 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
3210 * nsfns.m (ns_set_name_as_filename): Likewise.
3211 * nsmenu.m (ns_update_menubar): Likewise.
3212 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
3213
4f5d0325
EZ
32142012-08-01 Eli Zaretskii <eliz@gnu.org>
3215
2008beae
EZ
3216 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
3217 Adapt to latest changes in field names of the corresponding Lisp
288479f6 3218 objects.
2008beae 3219
4f5d0325
EZ
3220 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
3221
fe3cc771
GM
32222012-08-01 Glenn Morris <rgm@gnu.org>
3223
3224 * s/msdos.h: Remove file.
3225 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
3226 * Makefile.in (S_FILE): Remove.
3227 (config_h): Remove S_FILE.
3228
c90acc54
JB
32292012-08-01 Juanma Barranquero <lekktu@gmail.com>
3230
3231 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
3232 Remove; moved to nt/config.nt.
3233
d8a05828
DA
32342012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3235
3236 Use INTERNAL_FIELD for conses and overlays.
3237 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
3238 Remove obsolete comment.
3239 (MVAR): New macro.
3240 (struct Lisp_Overlay): Use INTERNAL_FIELD.
3241 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
3242
8271d590
DA
32432012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3244
3245 Use INTERNAL_FIELD for symbols.
3246 * lisp.h (SVAR): New macro. Adjust users.
3247 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
3248 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
3249
3193acd2
DA
32502012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3251
3252 Use INTERNAL_FIELD for processes.
3253 * process.h (PVAR): New macro. Adjust style.
3254 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
3255 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
3256
3a45383a
DA
32572012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3258
3259 Use INTERNAL_FIELD for windows.
3260 * window.h (WVAR): New macro.
3261 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
3262 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3263 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3264 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
3265 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
3266 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3267
c1dbc63c
PE
32682012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3269
3270 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
3271
5c0c0e8a
GM
32722012-08-01 Glenn Morris <rgm@gnu.org>
3273
3274 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
3275 Move to configure.ac.
3276
552a99b4
JB
32772012-08-01 Juanma Barranquero <lekktu@gmail.com>
3278
3279 * makefile.w32-in (CONFIG_H): Update dependencies.
3280 (CONF_POST_H): New macro.
3281
3282 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
3283
8d8e2dfe
GM
32842012-07-31 Glenn Morris <rgm@gnu.org>
3285
bc96620a
GM
3286 * Makefile.in (S_FILE): No longer set by configure.
3287
476b1b2d
GM
3288 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
3289 is available.
3290 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
3291
b2c7a106
GM
3292 * process.h (NULL_DEVICE):
3293 * emacs.c (SEPCHAR):
3294 * editfns.c (USER_FULL_NAME): Let configure set them.
3295
d53d062a
GM
3296 * s/README, s/template.h: Remove files.
3297
4515017f
GM
3298 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
3299
8d8e2dfe
GM
3300 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
3301 Move to configure.ac.
3302
5b20b3cc
EZ
33032012-07-31 Eli Zaretskii <eliz@gnu.org>
3304
1e0afd9a
EZ
3305 * .gdbinit (xframe): Adapt to introduction of FVAR and the
3306 resulting renaming of 'struct frame' members.
3307
5b20b3cc
EZ
3308 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
3309
3310 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
3311 after introduction of FVAR.
3312
f1310128
JD
33132012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3314
79e721e0
JD
3315 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
3316
3317 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
3318 instead of compositeToPoint.
3319 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
3320
8d7c7eed 3321 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 3322
e34f7f79
DA
33232012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3324
3325 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
3326 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 3327 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
3328 (BVAR): Change to use INTERNAL_FIELD.
3329 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
3330 (KVAR): Change to use INTERNAL_FIELD.
3331 * frame.h (FVAR): New macro.
3332 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
3333 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
3334 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
3335 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
3336 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3337
c09bfb2f
DA
33382012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3339
3340 Miscellaneous fixes for non-default X toolkits.
3341 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
3342 * xterm.c (x_frame_of_widget): Remove redundant prototype.
3343 Move under #ifdef USE_LUCID.
3344 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
3345 definition and usage to avoid warnings.
3346
14c114ae
JD
33472012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3348
3349 * nsterm.m (openFiles): Fix previous checkin.
3350
3bd21e82
PE
33512012-07-31 Paul Eggert <eggert@cs.ucla.edu>
3352
3353 * indent.c (compute_motion): Remove unused local.
3354
c1529ded
GM
33552012-07-31 Glenn Morris <rgm@gnu.org>
3356
400d5621
GM
3357 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
3358
268e2432
GM
3359 * conf_post.h [USG5_4]:
3360 Move remaining contents of s/usg5-4-common.h here.
3361 * s/usg5-4-common.h: Remove file.
3362
7552f3ee
GM
3363 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
3364 * s/irix6-5.h: Remove file.
3365
6a381852
GM
3366 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
3367 * s/darwin.h: Remove file.
3368
c1529ded
GM
3369 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
3370 * s/hpux10-20.h: Remove file, which is now empty.
3371
b429a4ee
GM
33722012-07-30 Glenn Morris <rgm@gnu.org>
3373
3374 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
3375 * Makefile.in (config_h): Add conf_post.h.
3376 * makefile.w32-in (CONFIG_H): Add conf_post.h.
3377
adff3182
JD
33782012-07-30 Jan Djärv <jan.h.d@swipnet.se>
3379
3380 * nsterm.m (ns_do_open_file): New variable.
b9031d69 3381 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
3382 (openFile, openTempFile, openFileWithoutUI, openFiles):
3383 Open files only if ns_do_open_file.
adff3182 3384
c32af1e4
PE
33852012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3386
7393bcbb
PE
3387 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
3388 This no-op macro hasn't been needed for many years.
3389 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
3390
c32af1e4
PE
3391 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
3392 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
3393 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
3394 gdb_make_enums_visible.
3395 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
3396 (DIRECTORY_SEP): Now a constant, not a macro.
3397
302fc036
EZ
33982012-07-30 Eli Zaretskii <eliz@gnu.org>
3399
3400 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
3401 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
3402
3403 * w32term.c <w32_keyboard_codepage>: Renamed from
3404 keyboard_codepage and now external. All users changed.
3405
3406 * w32term.h: Add declaration of w32_keyboard_codepage.
3407
3408 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
3409 the codepage to translate keys to Unicode. If this argument is
3410 -1, use the value returned by GetConsoleCP. All callers changed.
3411
88fb40b4
PE
34122012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3413
0aee6912
PE
3414 Update .PHONY listings in makefiles.
3415 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
3416 bootstrap-clean, distclean, maintainer-clean, versioclean,
3417 extraclean, frc.
3418
88fb40b4
PE
3419 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
3420 This is a bit clearer. Fix some commentary typos.
3421
0a763bd1
GM
34222012-07-30 Glenn Morris <rgm@gnu.org>
3423
32bac6d6
GM
3424 * s/netbsd.h: Let configure include signal.h if needed.
3425 Remove file, which is now empty.
3426
b65e7c46
GM
3427 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
3428 Let configure set them.
3429 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
3430 No more need to undefine.
0a763bd1 3431
169304bd
AS
34322012-07-30 Andreas Schwab <schwab@linux-m68k.org>
3433
3434 * keymap.c (Fkey_description): Don't remove 0x80 bit from
3435 non-single-byte char when adding meta modifier. (Bug#12090)
3436
6cd7a139
DA
34372012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3438
3439 Convert safe_call to use variable number of arguments.
3440 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
3441 (safe_call2): Fix comment.
3442 * lisp.h (safe_call): Adjust prototype.
3443 * coding.c (encode_coding_object): Change to use safe_call2.
3444 * xfaces.c (merge_face_heights): Change to use safe_call1.
3445
d34d6ffc
GM
34462012-07-30 Glenn Morris <rgm@gnu.org>
3447
7b8a48e4 3448 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 3449 does that unconditionally. Remove file, which is now empty.
7b8a48e4 3450
d34d6ffc
GM
3451 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
3452 Remove empty files.
3453
03a660a6
PE
34542012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3455
3456 Export to GDB most of lisp.h's remaining object-like macros.
3457 * lisp.h (min, max): Move earlier, because they're used earlier now.
3458 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
3459 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
3460 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
3461 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
3462 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
3463 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
3464 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
3465 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
3466 Now constants, for GDB. They need not be macros.
3467 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
3468 Now constants, for GDB, as well as macros, for static initializers.
3469 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
3470 Move to after the definition of struct Lisp_Char_Table,
3471 since the former now needs that type defined.
3472 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
3473 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
3474 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
3475 New enums, for gdb_make_enums_visible.
3476 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 3477 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
3478 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
3479 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
3480 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
3481 enum maxargs, enum MAX_ALLOCA.
3482 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
3483 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
3484 no longer needed, now that they are done in lisp.h.
3485
e499d0ee
DA
34862012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3487
3488 Cleanup string bytes checking.
3489 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
3490 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
3491 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
3492 (check_sblock, compact_small_strings): Simplify.
3493
d5040d2d
PE
34942012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3495
3496 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
3497 These macros are confusing and no longer need to be defined, as
3498 the enum values now suffice. All uses replaced with definiens.
3499 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
3500
7f259ae6
JB
35012012-07-29 Juanma Barranquero <lekktu@gmail.com>
3502
3503 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
3504 ($(BLD)/w32console.$(O)): Update dependencies.
3505
7e63e0c3
DA
35062012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3507
3508 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
3509 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
3510 time. Adjust users.
3511 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
3512
ffd817eb
JD
35132012-07-29 Jan Djärv <jan.h.d@swipnet.se>
3514
3515 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
3516 setting sitelisp (Bug#12010).
3517
417a7a0e
EZ
35182012-07-29 Eli Zaretskii <eliz@gnu.org>
3519
14ae4239 3520 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
3521
3522 * w32heap.c (cache_system_info):
3523 * w32.c (sys_rename):
3524 * w32proc.c (find_child_console, sys_kill): All users changed.
3525
387d4d92
PE
35262012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3527
3528 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
3529
55a6cca6
EZ
35302012-07-29 Eli Zaretskii <eliz@gnu.org>
3531
3532 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
3533
dbcf001c
DA
35342012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3535
3536 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
3537 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
3538 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 3539
e2688e4a
DA
35402012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3541
3542 Generalize marker debugging code under MARKER_DEBUG and use eassert.
3543 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
3544 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
3545 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
3546 (replace_range, replace_range_2, del_range_2): Change to eassert.
3547 * marker.c (byte_char_debug_check): Adjust style.
3548
b46a6a83
PE
35492012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3550
3551 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
3552 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
3553 long-ago-commented-out code that talks about "WIN32".
3554 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
3555 All uses changed.
3556
e32a5799
PE
35572012-07-28 Paul Eggert <eggert@cs.ucla.edu>
3558
3559 Use Gnulib stdalign module (Bug#9772, Bug#9960).
3560 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
3561 Simplify by using alignof.
3562 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
3563 * lisp.h: Include <stdalign.h>.
3564 (GCALIGNMENT): New macro and constant.
3565 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
3566 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
3567 (stdalign): New macro, if not already defined.
3568
df81cd29
EZ
35692012-07-28 Eli Zaretskii <eliz@gnu.org>
3570
01bd1b0d
EZ
3571 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
3572 * w32inevt.c: Include w32inevt.h.
3573 (w32_read_console_input): New inline function, calls either
3574 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
3575 w32_console_unicode_input.
3576 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
3577 (w32_kbd_patch_key, key_event): Use the codepage returned by
3578 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
3579 (key_event): use uChar.UnicodeChar only if
3580 w32_console_unicode_input is non-zero.
3581
3582 * w32console.c: Include w32heap.h.
3583 <w32_console_unicode_input>: New global variable.
3584 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
3585 family of Windows, zero otherwise.
3586
3587 * w32inevt.h: Declare w32_console_unicode_input.
3588
df81cd29
EZ
3589 * xdisp.c (init_iterator): Don't reference tip_frame in a build
3590 --without-x. (Bug#11742)
3591
c20fdd9e
PE
35922012-07-27 Paul Eggert <eggert@cs.ucla.edu>
3593
3594 Adjust GDB to reflect pvec_type changes (Bug#12036).
3595 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
3596 2012-07-04 changes to pseudovector representation.
3597 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 3598
32770973 35992012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
3600
3601 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
3602 bus address.
3603 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
3604
3438fe21
EZ
36052012-07-27 Eli Zaretskii <eliz@gnu.org>
3606
bcfbc9de
EZ
3607 * alloc.c (listn): Fix the order the arguments are consed onto the
3608 list.
3609
3438fe21
EZ
3610 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
3611 enumeration constants, as PURE and HEAP are too general, and clash
3612 with other headers and sources, such as gmalloc.c and the
3613 MS-Windows system headers. All users changed.
3614
eeaea515
DA
36152012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3616
3617 Revert last save_excursion_save and save_excursion_restore changes.
3618 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
3619 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
3620
073c88c2
DA
36212012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3622
3623 Fix recently-introduced typos in Windows port.
3624 Reported by Martin Rudalics <rudalics@gmx.at>.
3625 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 3626 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 3627
4706125e
PE
36282012-07-27 Paul Eggert <eggert@cs.ucla.edu>
3629
3630 Improve GDB symbol export (Bug#12036).
3631 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
3632 arms of an 'if', not using conditional expressions; otherwise GDB
3633 complains about the types in the unevaluated arm when the argument
3634 is an integer literal.
3635 (xgetint): Simplify expression.
3636 * alloc.c (gdb_make_enums_visible): New constant. This ports to
3637 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
3638 Zaretskii in <http://bugs.gnu.org/12036#13>.
3639 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
3640 needed now that we have gdb_make_enums_visible.
3641 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
3642 (enum enum_USE_LSB_TAG):
3643 New enum types, packaging up enums that need to be exported to GDB.
3644
694b6c97
DA
36452012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3646
3647 Utility function to make a list from specified amount of objects.
3648 * lisp.h (enum constype): New datatype.
3649 (listn): New prototype.
3650 * alloc.c (listn): New function.
3651 (Fmemory_use_count, syms_of_alloc): Use it.
3652 * buffer.c (syms_of_buffer): Likewise.
3653 * callint.c (syms_of_callint): Likewise.
3654 * charset.c (define_charset_internal): Likewise.
3655 * coding.c (syms_of_coding): Likewise.
3656 * keymap.c (syms_of_keymap): Likewise.
3657 * search.c (syms_of_search): Likewise.
3658 * syntax.c (syms_of_syntax): Likewise.
3659 * w32.c (init_environment): Likewise.
3660 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
3661 * xdisp.c (syms_of_xdisp): Likewise.
3662 * xfns.c (syms_of_xfns): Likewise.
3663
6195f384
DA
36642012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3665
3666 Fast save_excursion_save and save_excursion_restore.
3667 * lisp.h (struct Lisp_Excursion): New data type.
3668 (PVEC_EXCURSION): New pseudovector type.
3669 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
3670 to deal with it. Adjust comments.
3671 (init_marker, attach_marker): New prototype.
3672 (unchain_marker): Adjust prototype.
3673 * marker.c (attach_marker): Change to global.
3674 (init_marker): New function.
3675 * alloc.c (Fmake_marker, build_marker): Use it.
3676 (build_marker): More easserts.
3677 (mark_object): Handle struct Lisp_Excursion.
3678 * editfns.c (save_excursion_save, save_excursion_restore):
3679 Reimplement to use struct Lisp_Excursion. Add comments.
3680
5eceb8fb
PE
36812012-07-26 Paul Eggert <eggert@cs.ucla.edu>
3682
3683 Fix export of symbols to GDB (Bug#12036).
3684 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
3685 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
3686 emacs.c, as this is a more-suitable home. Had this been done earlier
3687 the fix for 12036 would have avoided some of the problems noted in
3688 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
3689 would have been more obvious.
562157c8
PE
3690 * emacs.c: Do not include <verify.h>; no longer needed.
3691 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
3692 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
3693 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
3694 Remove; now done in lisp.h.
3695 * lisp.h (PUBLISH_TO_GDB): New macro.
3696 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
3697 (DATA_SEG_BITS): Use it.
3698 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
3699 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
3700 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
3701 not be usable in #if. This simplifies things.
3702
d6749401
JB
37032012-07-26 Juanma Barranquero <lekktu@gmail.com>
3704
3705 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
3706
1781b9e9
PE
37072012-07-26 Paul Eggert <eggert@cs.ucla.edu>
3708
d89518db 3709 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
3710 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
3711 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
3712 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
3713 Adjust to changes in lisp.h and emacs.c, by using
3714 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
3715 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
3716 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
3717 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
3718 instead of gdb_valbits.
3719 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
3720 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
3721 instead of gdb_array_mark_flag.
3722 (xboolvector): Get size from $->size, not $->header.size.
3723 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
3724 (xreload, hook-run, hookpost-run): Remove.
3725 * emacs.c: Include <verify.h>.
3726 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
3727 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
3728 Remove.
3729 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
3730 (gdb_USE_LSB_TAG): New enum constants.
3731 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
3732 Also define these as enum constants, so they're visible to GDB.
3733 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
3734 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
3735 as constants, so they're visible to GDB.
3736 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
3737 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
3738 Now enum constants, not macros, so they're visible to GDB.
3739 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
3740 more convenient now. All uses changed.
3741 (VALMASK) [USE_LSB_TAG]: Also define in this case.
3742 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
3743
3628596a
DA
37442012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
3745
3746 Explicitly free restriction data that are not needed anymore.
3747 * editfns.c (save_restriction_restore): Free restriction data.
3748
7abaf5cc
SM
37492012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
3750
3751 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
3752 add argument, tune behavior, and adjust all callers.
3753
71f88e00
PE
37542012-07-25 Paul Eggert <eggert@cs.ucla.edu>
3755
3756 Use typedef for EMACS_INT, EMACS_UINT.
3757 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
3758 than macros. This simplifies debugging in the usual case, since
3759 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
3760 and it allows expressions involving EMACS_INT casts.
3761 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
3762
57ec3034
JD
37632012-07-25 Jan Djärv <jan.h.d@swipnet.se>
3764
3765 * nsterm.m (ns_read_socket): Return early if there is a modal
3766 window (Bug#12043).
3767
8137e7b3
MR
37682012-07-25 Martin Rudalics <rudalics@gmx.at>
3769
3770 * frame.c (Fredirect_frame_focus): In doc-string don't mention
3771 that FOCUS-FRAME can be omitted.
3772
04e9897c
DA
37732012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
3774
3775 Adjust buffer text indirection counters at the end of Fkill_buffer.
3776 * buffer.c (Fkill_buffer): Adjust indirection counters when the
3777 buffer is definitely dead. This should really fix an issue reported
3778 by Christoph Scholtes again. (Bug#12007).
3779 (init_buffer_once): Initialize indirection counters of
3780 buffer_defaults and buffer_local_symbols (for sanity and safety).
3781
8a0484e1
EZ
37822012-07-24 Eli Zaretskii <eliz@gnu.org>
3783
3784 * xdisp.c (init_iterator): Don't compute dimensions of truncation
3785 and continuation glyphs on tooltip frames, leave them at zero.
3786 Avoids continued lines in tooltips. (Bug#11832)
3787
fa691a83
DA
37882012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
3789
3790 Simplify copy_overlay.
04e9897c 3791 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
3792 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
3793
436bc8e0
EZ
37942012-07-23 Eli Zaretskii <eliz@gnu.org>
3795
3796 * print.c (print_object): Don't crash when a frame's name is nil
3797 or invalid. (Bug#12025)
3798
3799 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
3800 it signals an error when a tooltip frame is being created.
3801
d7a7fda3
DA
38022012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
3803
3804 Cleanup miscellaneous objects allocation and initialization.
3805 * alloc.c (allocate_misc): Change to static. Add argument to
3806 specify the subtype. Adjust comment and users.
3807 (build_overlay): New function.
3808 * buffer.c (copy_overlays, Fmake_overlay): Use it.
3809 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
3810 (allocate_misc): Remove prototype.
3811 (build_overlay): Add prototype.
3812
38132012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
3814
3815 Swap buffer text indirection counters in Fbuffer_swap_text.
3816 * buffer.c (Fbuffer_swap_text): Swap indirections too.
3817 This avoids crash reported by Christoph Scholtes at
3818 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
3819
9d7fa573
JD
38202012-07-22 Jan Djärv <jan.h.d@swipnet.se>
3821
3822 * nsmenu.m (Popdown_data): New struct.
3823 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
3824 free Popdown_data.
3825 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
3826 (initWithContentRect): Make imgView and contentView non-static
3827 and autorelease them. Also autorelease img and matrix (Bug#12005).
3828 (dealloc): Remove (Bug#12005).
3829
0dd6d66d
DA
38302012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3831
3832 Adjust consing_since_gc when objects are explicitly freed.
3833 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
3834 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
3835 (free_cons, free_misc): Subtract object size from consing_since_gc.
3836
d36d71df
DA
38372012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3838
3839 Simplify and cleanup markers positioning code.
3840 * marker.c (attach_marker): More useful eassert.
3841 (live_buffer, set_marker_internal): New function.
3842 (Fset_marker, set_marker_restricted): Use set_marker_internal.
3843 (set_marker_both, set_marker_restricted_both): Use live_buffer.
3844
fb9ea40f
PE
38452012-07-22 Paul Eggert <eggert@cs.ucla.edu>
3846
3847 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
3848 as it's limited by the amount of memory, not by INT_MAX.
3849
2d5c5f7d
EZ
38502012-07-21 Eli Zaretskii <eliz@gnu.org>
3851
07fb592e
EZ
3852 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
3853 in special-event-map. See the discussion at
3854 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
3855 for the reasons.
3856
37a9eac8 3857 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
3858 info.dwItemData. Fixes crashes on 64-bit Windows.
3859 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 3860
c4328746
JD
38612012-07-21 Jan Djärv <jan.h.d@swipnet.se>
3862
fc0c31f8 3863 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 3864 (conversationIdentifier): Return value is NSInteger.
784051c4 3865 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 3866
6e5d1c12
CY
38672012-07-21 Chong Yidong <cyd@gnu.org>
3868
3869 * window.c (decode_any_window): Signal an error if the window is
3870 on a dead frame (Bug#11984).
3871
9928463d
DA
38722012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3873
3874 Add indirection counting to speed up Fkill_buffer.
3875 * buffer.h (struct buffer): New member.
3876 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
3877 (Fmake_indirect_buffer): Set indirection counter to -1, increment
3878 base buffer indirection counter.
3879 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
3880 (Fkill_buffer): Adjust indirection counters as needed, don't walk
3881 through buffer list if indirection counter is 0.
3882
f8643a6b
DA
38832012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3884
3885 Extend the value returned by Fgarbage_collect with heap statistics.
3886 * alloc.c (Qheap): New symbol.
3887 (syms_of_alloc): DEFSYM it.
3888 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
3889 (Fmemory_free): Remove.
3890 (syms_of_alloc): Don't defsubr it.
3891 * buffer.c (Fcompact_buffer): Remove.
3892 (syms_of_buffer): Don't defsubr it.
3893
dac616ff
DA
38942012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3895
3896 Make maybe_gc inline.
3897 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
3898 * lisp.h (consing_since_gc, gc_relative_threshold)
3899 (memory_full_cons_threshold): Revert declaration.
3900 (maybe_gc): Remove prototype, define as inline.
3901 * alloc.c: Remove old commented-out code.
3902 (consing_since_gc, gc_relative_threshold)
3903 (memory_full_cons_threshold): Revert to global.
3904 (maybe_gc): Remove.
3905
d7ea76b4
DA
39062012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3907
3908 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
3909 * lisp.h (build_unibyte_string): New function.
3910 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
3911 * sysdep.c, w32fns.c, xfns.c: Use it.
3912 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
3913 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
3914 Adjust users accordingly.
3915 * font.h (font_open_by_name): Adjust prototype.
3916
765e61e3
DA
39172012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3918
3919 Cleanup calls to Fgarbage_collect.
3920 * lisp.h (maybe_gc): New prototype.
3921 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3922 Remove declarations.
3923 * alloc.c (maybe_gc): New function.
3924 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3925 Make them static.
3926 * bytecode.c (MAYBE_GC): Use maybe_gc.
3927 * eval.c (eval_sub, Ffuncall): Likewise.
3928 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
3929 to avoid dependency from auto-save feature.
3930
52b852c7
PE
39312012-07-19 Paul Eggert <eggert@cs.ucla.edu>
3932
3933 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
3934 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
3935 'for_each_per_buffer_object_at'.
3936 All uses changed. It's better to use upper-case for macros that
3937 cannot be implemented as functions, to give the reader a clue
3938 that they're special.
3939
5db81e33
SM
39402012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
3941
3942 * alloc.c (Fgarbage_collect): Tweak docstring.
3943
5b835e1d
DA
39442012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3945
3946 Tweak the value returned from Fgarbage_collect again.
3947 * alloc.c (Fgarbage_collect): New return value, as confirmed in
3948 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
3949 Adjust documentation.
3950 (total_vector_bytes): Rename to total_vector_slots, adjust
3951 accounting.
3952 (total_free_vector_bytes): Rename to total_free_vector_slots,
3953 adjust accounting.
3954 (Qstring_bytes, Qvector_slots): New symbols.
3955 (syms_of_alloc): DEFSYM them.
3956
9cd47b72
DA
39572012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3958
3959 Buffer compaction primitive which may be used from Lisp.
3960 * buffer.c (compact_buffer, Fcompact_buffer): New function.
3961 (syms_of_buffer): Register Fcompact_buffer.
3962 * alloc.c (Fgarbage_collect): Use compact_buffer.
3963 * buffer.h (compact_buffer): New prototype.
3964 (struct buffer_text): New member.
3965
d17337e5
DA
39662012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3967
3968 New macro to iterate over all buffers, miscellaneous cleanups.
3969 * lisp.h (all_buffers): Remove declaration.
3970 * buffer.h (all_buffers): Add declaration, with comment.
3971 (for_each_buffer): New macro.
3972 * alloc.c (Fgarbage_collect, mark_object): Use it.
3973 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
3974 (init_buffer): Likewise.
3975 * data.c (Fset_default): Likewise.
3976 * coding.c (code_conversion_restore): Remove redundant check
3977 for dead buffer.
3978 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
3979
60cfd278
AS
39802012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3981
3982 Fix bug that created negative-length intervals.
3983 * intervals.c (merge_interval_right, merge_interval_left):
3984 Do not zero out this interval if it is absorbed by its children,
3985 as this interval's total length doesn't change in that case. See
3986 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
3987
d06714cb
PE
39882012-07-18 Paul Eggert <eggert@cs.ucla.edu>
3989
83713154
PE
3990 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
3991 when invoking (make-bool-vector N t) and N is a positive
3992 multiple of 8 -- the last 8 bits were mistakenly cleared.
3993
d06714cb
PE
3994 Remove some struct layout assumptions in bool vectors.
3995 * alloc.c (bool_header_size): New constant.
3996 (header_size, word_size): Move earlier, as they're now used earlier.
3997 Use 'word_size' in a few more places, where it's appropriate.
3998 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
3999 padding before the data member of a bool vector.
4000 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
4001 than doing the check by hand with an abort ().
4002
464d5a5e
SM
40032012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4004
5fbc0409
SM
4005 * eval.c (Fdefvar): Don't check constants since we only set the var if
4006 it's not yet defined anyway (bug#11904).
4007
464d5a5e
SM
4008 * lisp.h (last_undo_boundary): Declare new var.
4009 * keyboard.c (command_loop_1): Set it.
4010 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
4011 were auto-added by the command loop (bug#11774).
4012
8dc2e44a
AS
40132012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4014
4015 * w32font.c (Qsymbol): Remove local definition.
4016 (syms_of_w32font): Don't DEFSYM it.
4017
169925ec
DA
40182012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4019
4020 Fix sweep_vectors to handle large bool vectors correctly.
4021 * alloc.c (sweep_vectors): Account total_vector_bytes for
4022 bool vectors larger than VBLOCK_BYTES_MAX.
4023
5fbfb018
CY
40242012-07-18 Chong Yidong <cyd@gnu.org>
4025
4026 * frame.c (x_set_frame_parameters): Revert bogus change introduced
4027 in 2012-05-25 commit by Paul Eggert (Bug#11738).
4028
3ab6e069
DA
40292012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4030
4031 Return more descriptive data from Fgarbage_collect.
4032 Suggested by Stefan Monnier in
4033 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
4034 * alloc.c (bounded_number): New function.
4035 (total_buffers, total_vectors): New variable.
4036 (total_string_size): Rename to total_string_bytes, adjust users.
4037 (total_vector_size): Rename to total_vector_bytes, adjust users.
4038 (sweep_vectors): Account total_vectors and total_vector_bytes.
4039 (Fgarbage_collect): New return value. Adjust documentation.
4040 (gc_sweep): Account total_buffers.
4041 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
4042 (VECTOR_SIZE): Remove.
4043 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
4044 (Qinterval, Qmisc): New symbols.
4045 (syms_of_data): Initialize them.
4046 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
4047 (Qcons, Qbuffer): New declarations.
4048
6d02fe5b
PE
40492012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4050
4051 * alloc.c (Fmemory_free): Account for memory-free's own storage.
4052 Round up, not down. Improve doc.
4053
b7ffe040
DA
40542012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4055
4056 Restore old code in allocate_string_data to avoid Faset breakage.
4057 Reported by Julien Danjou <julien@danjou.info> in
4058 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
4059 * alloc.c (allocate_string_data): Restore old code with minor
4060 adjustments, fix comment to explain this subtle issue.
4061
4dc7c8d5
SM
40622012-07-17 Eli Zaretskii <eliz@gnu.org>
4063
4064 Remove FILE_SYSTEM_CASE.
4065 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
4066
4067 * fileio.c (FILE_SYSTEM_CASE): Don't define.
4068 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
4069 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
4070 call-process-region passes it through expand-file-name.
4071
4072 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
4073
40742012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4075
4076 Fix crash when creating indirect buffer (Bug#11917)
4077 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
4078 Don't handle unbound variables specially if non-zero.
4079 (Fbuffer_local_variables): Pass zero.
4080 (clone_per_buffer_values): Pass non-zero.
4081
40822012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4083
4084 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
4085 to make the loop interruptible.
4086
40872012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4088
4089 * gnutls.c (emacs_gnutls_handshake): Only retry if
4090 GNUTLS_E_INTERRUPTED.
4091
cce7fefc
DA
40922012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4093
4094 Cleanup and convert miscellaneous checks to eassert.
4095 * alloc.c (mark_interval): Fix comment, partially rephrase
4096 old comment from intervals.h (see below).
4097 * intervals.c (find_interval, adjust_intervals_for_insertion)
4098 (delete_interval, adjust_intervals_for_deletion)
4099 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
4100 Convert to eassert.
4101 (adjust_intervals_for_insertion, make_new_interval):
4102 Remove obsolete and unused code.
4103 * intervals.h (struct interval): Remove obsolete comment.
4104 * textprotp.c (erase_properties): Remove unused code.
4105 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
4106 (Fremove_list_of_text_properties): Convert to eassert.
4107
9ea10cc3
CY
41082012-07-17 Chong Yidong <cyd@gnu.org>
4109
4110 * editfns.c (Finsert_char): Doc fix.
4111
3900d5de
DA
41122012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4113
4114 Fix previous change to make Fmemory_free always accurate.
4115 * alloc.c (make_interval): Update total_free_intervals.
4116 (make_float): Likewise for total_free_floats.
4117 (free_cons, Fcons): Likewise for total_free_conses.
4118 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
4119 Likewise for total_free_vector_bytes.
4120 (Fmake_symbol): Likewise for total_free_symbols.
4121 (bytes_free): Remove.
4122
7098646f
DA
41232012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4124
4125 Simple free memory accounting feature.
4126 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
4127 (sweep_vectors): Accumulate size of free vectors.
4128 (Fgarbage_collect): Setup bytes_free.
4129 (Fmemory_free): New function.
4130 (syms_of_alloc): Register it.
4131
22657b40
DA
41322012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4133
4134 Cleanup overlays checking.
4135 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
4136 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
4137 eassert and OVERLAYP.
4138 (sort_overlays): Change to use OVERLAYP.
4139
ddfc8813
RK
41402012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
4141
4142 * editfns.c (Finsert_char): Make it interactive, and make the
4143 second arg optional. Copy interactive spec and docstring from
4144 ucs-insert.
4145
7c26cf3c
PE
41462012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4147
4148 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
4149 Unlike the other wrapped functions, fabs has an unspecified
4150 effect on errno.
4151
5d127af9
JD
41522012-07-16 Jan Djärv <jan.h.d@swipnet.se>
4153
4154 * nsterm.m (keyDown): Interpret flags without left/right bits
4155 as the left key (Bug#11670).
4156
6a0dd1d7
DA
41572012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
4158
4159 Remove empty and useless init functions.
4160 * lisp.h (init_character_once, init_fns, init_image)
4161 (init_filelock, init_sound): Remove prototype.
4162 * character.c (init_character_once): Remove.
4163 * filelock.c (init_filelock): Likewise.
4164 * fns.c (init_fns): Likewise.
4165 * image.c (init_image): Likewise.
4166 * sound.c (init_sound): Likewise.
4167 * emacs.c (main): Adjust accordingly.
4168
7a6136fd
DA
41692012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
4170
4171 * gtkutil.h: Tiny cleanups.
4172 (use_old_gtk_file_dialog): Remove useless declaration.
4173 (xg_uses_old_file_dialog): Add suggested const attribute.
4174
ce811ad9
EZ
41752012-07-15 Eli Zaretskii <eliz@gnu.org>
4176
4177 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
4178 (bidi_paragraph_init): Use it to limit search forward for a strong
4179 directional character in abnormally large paragraphs full of
4180 neutral or weak characters. (Bug#11943)
4181
c9adfeaa
SF
41822012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
4183
4184 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
4185 the toolbar (Bug#9451).
4186 (xg_make_tool_item): Give the widget event box a transparent
4187 background.
4188
fff62aa9
DA
41892012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
4190
4191 Cleanup basic allocation variables and functions.
4192 * alloc.c (ignore_warnings, init_intervals, init_float)
4193 (init_cons, init_symbol, init_marker): Remove.
4194 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
4195 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
4196 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
4197 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
4198 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
4199 (staticidx, init_alloc_once, init_strings, free_ablock):
4200 Remove redundant initialization.
4201 * fns.c (init_weak_hash_tables): Remove.
4202 * lisp.h (init_weak_hash_tables): Remove prototype.
4203
9730daca
DA
42042012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
4205
4206 Use zero_vector where appropriate.
4207 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
4208 accordingly.
4209 * lisp.h (zero_vector): New declaration.
4210 * font.c (null_vector): Remove.
4211 (syms_of_font): Remove initialization and staticpro.
4212 (font_list_entities, font_find_for_lface): Change to use zero_vector.
4213 * keymap.c (Faccessible_keymaps): Likewise.
4214
2e2d2a13
LL
42152012-07-15 Leo Liu <sdl.web@gmail.com>
4216
4217 * fringe.c: Fix typo in comments.
4218
cd276f6e
LL
42192012-07-14 Leo Liu <sdl.web@gmail.com>
4220
4221 * fringe.c: Add a new bitmap exclamation-mark.
4222
5a1131d9
EZ
42232012-07-14 Eli Zaretskii <eliz@gnu.org>
4224
4225 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
4226
4227 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
4228 (HAVE_MENUS): Don't define, defined by editing config.in with
4229 msdos/sed2v2.inp.
4230 (GMALLOC_INHIBIT_VALLOC): Don't define.
4231 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
4232
22e983b7
JB
42332012-07-14 Juanma Barranquero <lekktu@gmail.com>
4234
4235 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
4236
5b3f250f
GM
42372012-07-14 Glenn Morris <rgm@gnu.org>
4238
4239 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
4240 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
4241 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
4242
33d63ff4
GM
42432012-07-13 Glenn Morris <rgm@gnu.org>
4244
5b633342
GM
4245 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
4246
33d63ff4
GM
4247 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
4248 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
4249
b55b9f85
JD
42502012-07-13 Jan Djärv <jan.h.d@swipnet.se>
4251
0dc8cf50
JD
4252 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
4253 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
4254 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
4255 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
4256 where appropriate.
4257 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
4258 as boolean expression.
4259 (x_set_window_size): Remove unused variable toolbar.
4260 (ns_get_color_default, ns_mod_to_lisp): Remove.
4261 (ns_mouse_position): Remove unused variables xchar and ychar.
4262 (ns_compute_glyph_string_overhangs): Remove unused variable face.
4263 (ns_set_vertical_scroll_bar): Remove unused variable count.
4264 (ns_delete_terminal): Remove unused variable i.
4265 (ns_term_init): Remove unused variables r, g and b.
4266 (mouseDown): Remove unused variable window.
4267 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
4268 (initFrameFromEmacs): Remove unused variable vbextra.
4269 (mouseEntered): Remove unused variables p and dpyinfo.
4270 (mouseExited): Remove unused variables p and r.
4271 (ns_define_frame_cursor, ns_clear_frame_area)
4272 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
4273 (menuDown): Assign [sender tag] to variable and cast the variable.
4274
4275 * nsterm.h (menuDown): Add id as type to argument sender.
4276 (ns_display_info_for_name): Add Lisp_Object argument.
4277 (ns_term_init): Add Lisp_Object argument.
4278 (ns_map_event_to_object): Add void argument.
4279 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
4280 prototype with arguments and only declare if __OBJC__.
4281 (nxatoms_of_nsselect): Add void argument.
4282 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
4283 (ns_alloc_autorelease_pool): Add void argument.
4284 (ns_release_autorelease_pool): Add void* argument.
4285 (ns_get_defaults_value): Add const char* argument.
4286
4287 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
4288 (initFromContents): Use SSDATA where appropriate.
4289 (ns_update_menubar): Add braces to ambigous if-else.
4290 (initWithTitle): Put () around assignment in if statement.
4291 (ns_menu_show): Remove unused variables window and keymap.
4292 (update_frame_tool_bar): Remove unused variable selected_p.
4293 (initWithContentRect): Remove unused variable this_cmd_name.
4294
4295 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
4296 appropriate.
4297 (setXBMColor): Remove unused variable len.
4298 (setPixmapData): Put () around assignment in loop statement.
4299
4300 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
4301 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
4302 where appropriate.
4303 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
4304 around assignment in loop statement.
4305 (nsfont_open): Remove unused variable i.
4306 (nsfont_open): Remove unused variable len.
4307 (nsfont_draw): Remove unused variable cs.
4308
4309 * nsfns.m (x_set_icon_name, ns_set_name_internal)
4310 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
4311 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
4312 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
4313 (Fns_font_name, Fns_perform_service)
4314 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
4315 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
4316 (ns_set_name): Remove unused variable view.
4317 (x_set_menu_bar_lines): Remove unused variable olines.
4318 (x_set_tool_bar_lines): Remove unused variable root_window.
4319 (Fns_list_colors): Put () around assignment in while statement.
4320 (Fns_perform_service): Remove unused variable len.
4321 (Fns_display_usable_bounds): Remove unused variable top.
4322 (syms_of_nsfns): Remove unused variable i.
4323
b55b9f85
JD
4324 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
4325 memcpy (Bug#11907).
4326
ed9265fc 43272012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
4328
4329 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
4330 and free it with DestroyExceptionInfo (Bug#11558).
4331
ef099b57
JB
43322012-07-13 Juanma Barranquero <lekktu@gmail.com>
4333
4334 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
4335 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
4336 Set here, not in nt/config.nt.
4337
ea814a5d
EZ
43382012-07-13 Eli Zaretskii <eliz@gnu.org>
4339
4340 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
4341 cursor overflow into the last glyph on display line when the right
4342 fringe is off. (Bug#11832)
4343
1a952767
PE
43442012-07-13 Paul Eggert <eggert@cs.ucla.edu>
4345
4346 * xdisp.c (produce_special_glyphs): Now static.
4347 * dispextern.h (produce_special_glyphs): Remove decl.
4348
983188fd
GM
43492012-07-13 Glenn Morris <rgm@gnu.org>
4350
8d7c7eed 4351 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
4352 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
4353
983188fd
GM
4354 * s/usg5-4-common.h (USG, USG5):
4355 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
4356 * s/sol2-6.h (SOLARIS2):
4357 * s/irix6-5.h (IRIX6_5):
4358 * s/hpux10-20.h (USG, USG5, HPUX):
4359 * s/gnu-linux.h (USG, GNU_LINUX):
4360 * s/freebsd.h (BSD_SYSTEM):
4361 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
4362 * s/cygwin.h (CYGWIN):
4363 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
4364 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
4365
d1e68667 43662012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
4367
4368 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 4369
6de0e799
GM
43702012-07-13 Glenn Morris <rgm@gnu.org>
4371
739ae010
GM
4372 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
4373
dbee5793
GM
4374 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
4375
6de0e799
GM
4376 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
4377 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
4378
b82da769
GM
43792012-07-12 Glenn Morris <rgm@gnu.org>
4380
4fae5a7a 4381 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
4382
4383 * process.c (init_process_emacs): Rename from init_process.
4384 The old name is also the name of a Mach system call.
4385 * lisp.h, emacs.c: Update for this name change.
4386 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
4387 longer needed.
4388
5a979817
EZ
43892012-07-12 Eli Zaretskii <eliz@gnu.org>
4390
4391 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
4392 memmove call that removes glyphs covered by the left truncation
4393 glyph. Improve commentary.
4394 (display_line): Fix display of continuation glyphs on GUI frames
4395 when the right fringe is turned off and variable-size fonts are
4396 used in the window. Move the code that appends a stretch glyph to
4397 produce_special_glyphs, so that it could be used for truncation
4398 and continuation glyphs alike.
4399 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
4400 glyph of a suitably computed width, to align the special glyphs at
4401 the window margin. Code moved from display_line. (Bug#11832)
4402
3e91a053
GM
44032012-07-12 Glenn Morris <rgm@gnu.org>
4404
ba9e4b84
GM
4405 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
4406
4407 * s/gnu-linux.h, s/hpux10-20.h:
4408 Do not unconditionally define HAVE_XRMSETDATABASE.
4409
3e91a053
GM
4410 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
4411
b300b1f4
PE
44122012-07-12 Paul Eggert <eggert@cs.ucla.edu>
4413
4414 Fix typos that broke OS X build.
4415 Reported by Randal L. Schwartz in
4416 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
4417 * nsterm.m (ns_timeout): Add missing local decl.
4418 (ns_get_color): snprintf -> sprintf, to fix typo.
4419
6e777848
GM
44202012-07-12 Glenn Morris <rgm@gnu.org>
4421
3f922c37
GM
4422 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
4423 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
4424 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
4425 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
4426
0ab7b23a
GM
4427 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
4428 Move PTY_OPEN to configure.
4429
6e777848
GM
4430 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4431 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
4432 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
4433
4a7edc24
DA
44342012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
4435
4436 Use empty_unibyte_string where applicable.
4437 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
4438 * lread.c (read1): Likewise.
4439 * xsettings.c (syms_of_xsettings): Likewise.
4440
308aab79
GM
44412012-07-12 Glenn Morris <rgm@gnu.org>
4442
42bd1719
GM
4443 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
4444 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
4445 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
4446 * s/hpux10-20.h (RUN_TIME_REMAP):
4447 * s/bsd-common.h (TABDLY): Move to configure.
4448
4449 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
4450
4451 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
4452
ea0bbd17 4453 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 4454 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
4455
4456 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 4457
308aab79
GM
4458 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
4459 * s/template.h: Move NARROWPROTO to configure.
4460
ee1cf5cf
GM
44612012-07-11 Glenn Morris <rgm@gnu.org>
4462
30fe9bf4
GM
4463 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
4464 unused since 2011-01-17 change to systty.h.
4465
ee1cf5cf
GM
4466 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
4467 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
4468 Move HAVE_PTYS and HAVE_SOCKETS to configure.
4469
63e47e07
PE
44702012-07-11 Paul Eggert <eggert@cs.ucla.edu>
4471
4472 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
4473
c43fb4c3
GM
44742012-07-11 Glenn Morris <rgm@gnu.org>
4475
4476 * s/darwin.h, s/gnu-linux.h, s/template.h:
4477 Move INTERRUPT_INPUT to configure.
4478
e8df9267
DA
44792012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4480
4481 Minor adjustments to interning code.
4482 * lisp.h (intern, intern_c_string): Redefine as static inline
4483 wrappers for intern_1 and intern_c_string_1, respectively.
4484 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
4485 * lread.c (intern_1, intern_c_string_1, oblookup):
4486 Simplify Vobarray checking.
e8df9267
DA
4487 * font.c (font_intern_prop): Likewise. Adjust comment.
4488 * w32font.c (intern_font_name): Likewise.
4489
34348bd4
AS
44902012-07-11 Andreas Schwab <schwab@linux-m68k.org>
4491
d96a1e0c
AS
4492 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
4493
34348bd4
AS
4494 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
4495 of Fcar/Fcdr if possible.
4496 * font.c (check_otf_features): Likewise.
4497 * fontset.c (Fnew_fontset): Likewise.
4498 * gnutls.c (Fgnutls_boot): Likewise.
4499 * minibuf.c (read_minibuf): Likewise.
4500 * msdos.c (IT_set_frame_parameters): Likewise.
4501 * xmenu.c (Fx_popup_dialog): Likewise.
4502 * w32menu.c (Fx_popup_dialog): Likewise.
4503
c8add24e
GM
45042012-07-11 Glenn Morris <rgm@gnu.org>
4505
4b575b3c
GM
4506 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
4507 since nothing has defined it on these platforms.
4508
09f4e3b0
GM
4509 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
4510 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
4511
172bedef
GM
4512 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4513 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
4514 Move CLASH_DETECTION to configure.
4515
249685df
GM
4516 * s/gnu.h: Remove file, which is now empty.
4517
c8add24e
GM
4518 * s/gnu.h, s/gnu-linux.h:
4519 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
4520
b41253a3
JW
45212012-07-11 John Wiegley <johnw@newartisans.com>
4522
4523 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
4524 function attribute, so we only use it if it exists in the
4525 compiler.
4526
d923b542
DA
45272012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4528
4529 Avoid call to strlen in fast_c_string_match_ignore_case.
4530 * search.c (fast_c_string_match_ignore_case): Change to use
4531 length argument. Adjust users accordingly.
4532 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
4533
5ebbef1d
PE
45342012-07-11 Paul Eggert <eggert@cs.ucla.edu>
4535
bb352260
PE
4536 Assume mkdir, rmdir.
4537 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
4538 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
4539
57054ddd
PE
4540 Assume rename.
4541 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
4542
b747d3f7
PE
4543 Assume perror.
4544 * s/hpux10-20.h (HAVE_PERROR): Remove.
4545 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
4546 Remove dummy definition, as this problem was obsolete long ago.
4547
5ebbef1d
PE
4548 Assume strerror.
4549 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
4550
984e7f30
DA
45512012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4552
4553 Avoid calls to strlen in font processing functions.
4554 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
4555 (font_open_by_name): Change to use length argument.
4556 Adjust users accordingly.
d923b542
DA
4557 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
4558 Adjust prototypes.
4559 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
4560 Change to return ptrdiff_t.
984e7f30
DA
4561 (xfont_list_pattern, xfont_match): Use length returned by
4562 xfont_decode_coding_xlfd.
4563 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
4564
20e94fdd
GM
45652012-07-11 Glenn Morris <rgm@gnu.org>
4566
9d596af3
GM
4567 * s/darwin.h, s/freebsd.h, s/netbsd.h:
4568 Move DONT_REOPEN_PTY to configure.
4569
20e94fdd
GM
4570 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
4571 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
4572
e99a530f
PE
45732012-07-10 Paul Eggert <eggert@cs.ucla.edu>
4574
22ffb973
PE
4575 Remove "#define unix" that is no longer needed (Bug#11905).
4576 * s/aix4-2.h (unix): Remove; no longer needed.
4577
e9a9ae03
PE
4578 EMACS_TIME simplification (Bug#11875).
4579 This replaces macros (which typically do not work in GDB)
4580 with functions, typedefs and enums, making the code easier to debug.
4581 The functional style also makes code easier to read and maintain.
4582 * systime.h: Include <sys/time.h> on all hosts, not just if
4583 WINDOWSNT, since 'struct timeval' is needed in general.
4584 (EMACS_TIME): Now a typedef, not a macro.
4585 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
4586 not macros.
4587 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
4588 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
4589 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
4590 (EMACS_TIME_LE): Now functions, not macros.
4591 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
4592 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
4593 which are not functions. All uses rewritten to use:
4594 (make_emacs_time): New function.
4595 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
4596 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
4597 not functions. All uses rewritten to use the following, respectively:
4598 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
4599 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 4600 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
4601 * fileio.c (Fcopy_file):
4602 * xterm.c (XTflash): Get the current time closer to when it's used.
4603 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
4604
ffacb126
PE
4605 * bytecode.c (targets): Suppress -Woverride-init warnings.
4606
e99a530f
PE
4607 Simplify by avoiding confusing use of strncpy etc.
4608 * doc.c (Fsnarf_documentation):
4609 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
4610 * frame.c (Fmake_terminal_frame):
4611 * gtkutil.c (get_utf8_string):
4612 * lread.c (openp):
4613 * nsmenu.m (ns_update_menubar):
4614 * regex.c (regerror):
4615 Prefer memcpy to strncpy and strncat when either will do.
4616 * fileio.c (Fsubstitute_in_file_name):
4617 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
4618 (menu_separator_name_p):
4619 * nsmenu.m (ns_update_menubar):
4620 Prefer memcmp to strncmp when either will do.
4621 * nsterm.m: Include <ftoastr.h>.
4622 (ns_get_color):
4623 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
4624 Prefer snprintf to strncpy.
4625 * nsterm.m (ns_term_init):
4626 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
4627 * nsterm.m (ns_term_init):
4628 Avoid the need for strncpy, by using build_string or
4629 make_unibyte_string directly. Use dtoastr, not snprintf.
4630 * process.c (Fmake_network_process): Diagnose service names that
4631 are too long, rather than silently truncating them or creating
4632 non-null-terminated names.
4633 (Fnetwork_interface_info): Likewise, for interface names.
4634 * sysdep.c (system_process_attributes) [GNU_LINUX]:
4635 Prefer sprintf to strncat.
4636 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
4637 Prefer vsnprintf to vsprintf + strncpy.
4638
c59592b3
GM
46392012-07-10 Glenn Morris <rgm@gnu.org>
4640
4641 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
4642 Clarify fallback case.
4643
7d7bbefd
DA
46442012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4645
4646 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
4647 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
4648 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 4649 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
4650 where argument type is known to be a Lisp_Cons.
4651
3a4c8000
TT
46522012-07-10 Tom Tromey <tromey@redhat.com>
4653
4654 * bytecode.c (BYTE_CODE_THREADED): New macro.
4655 (BYTE_CODES): New macro. Replaces all old byte-code defines.
4656 (enum byte_code_op): New type.
4657 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
4658 (exec_byte_code): Use them. Use token threading when applicable.
4659
2a0213a6
DA
46602012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4661
4662 Optimize pure C strings initialization.
4663 * lisp.h (make_pure_string): Fix prototype.
4664 (build_pure_c_string): New function, defined as static inline. This
4665 provides a better opportunity to optimize away calls to strlen when
4666 the function is called with compile-time constant argument.
4667 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
4668 argument, adjust users accordingly. Use build_pure_c_string where
4669 appropriate.
4670 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
4671 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
4672 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
4673
cb1caeaf
DA
46742012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4675
4676 Avoid calls to strlen in miscellaneous functions.
4677 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
4678 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
4679 * lread.c (openp): Likewise.
4680
c293e30c
DA
46812012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4682
4683 Avoid calls to strlen in path processing functions.
4684 * fileio.c (file_name_as_directory): Add comment. Change to add
4685 srclen argument and return the length of result. Adjust users
4686 accordingly.
4687 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
4688 swap 1st and 2nd arguments to obey the common convention.
4689 Adjust users accordingly.
c293e30c
DA
4690 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
4691
9e059e3f
GM
46922012-07-10 Glenn Morris <rgm@gnu.org>
4693
d02eb359
GM
4694 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
4695 Move PENDING_OUTPUT_COUNT definition to configure.
4696
882cf227
GM
4697 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
4698 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
4699 * s/gnu.h (DATA_START): Move definitions to configure.
4700
af6e839f
GM
4701 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
4702 We include usg5-4-common.h, which defines them both.
4703
40289a12
GM
4704 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
4705 O_RDONLY already includes it).
4706
9e059e3f
GM
4707 Stop ns builds setting the EMACSLOADPATH environment variable.
4708 * nsterm.m (ns_load_path): Rename from ns_init_paths.
4709 Now it does not set EMACSLOADPATH, just returns the load-path string.
4710 * nsterm.h: Update accordingly.
4711 * lread.c [HAVE_NS]: Include nsterm.h.
4712 (init_lread) [HAVE_NS]: Use ns_load_path.
4713 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
4714
7c4e8ec0
GM
47152012-07-09 Glenn Morris <rgm@gnu.org>
4716
d4f600ff
GM
4717 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
4718 since the included bsd-common.h does so.
4719
cbb31951
GM
4720 Stop ns builds setting the EMACSPATH environment variable.
4721 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
4722 (ns_init_paths): Do not set EMACSPATH.
4723 * nsterm.h (ns_exec_path): Add it.
4724 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
4725 Use ns_exec_path.
4726
7c4e8ec0
GM
4727 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
4728
26bccfae
PE
47292012-07-09 Paul Eggert <eggert@cs.ucla.edu>
4730
a0bee46f
PE
4731 * process.c (wait_reading_process_output): 'waitchannels' was unset
4732 when read_kbd || !NILP (wait_for_cell); fix this.
4733
5994c183
PE
4734 Add GCC-style 'const' attribute to functions that can use it.
4735 * character.h (char_resolve_modifier_mask):
4736 * keyboard.h (make_ctrl_char):
4737 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
4738 (init_character_once, next_almost_prime, init_fns, init_image)
4739 (flush_pending_output, init_sound):
4740 * mem-limits.h (start_of_data):
4741 * menu.h (finish_menu_items):
4742 Add ATTRIBUTE_CONST.
4743 * emacs.c (DEFINE_DUMMY_FUNCTION):
4744 Declare the dummy function with ATTRIBUTE_CONST.
4745 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
4746 Add decls with ATTRIBUTE_CONST.
4747
26bccfae
PE
4748 Minor improvements to make_formatted_string.
4749 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
4750 where int is good enough, as vsprintf returns an int.
4751 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
4752
a8290ec3
DA
47532012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4754
4755 Use make_formatted_string to avoid double length calculation.
4756 * lisp.h (make_formatted_string): New prototype.
4757 * alloc.c (make_formatted_string): New function.
4758 * buffer.c (Fgenerate_new_buffer_name): Use it.
4759 * dbus.c (syms_of_dbusbind): Likewise.
4760 * editfns.c (Fcurrent_time_zone): Likewise.
4761 * filelock.c (get_boot_time): Likewise.
4762 * frame.c (make_terminal_frame, set_term_frame_name)
4763 (x_report_frame_params): Likewise.
4764 * image.c (gs_load): Likewise.
4765 * minibuf.c (get_minibuffer): Likewise.
4766 * msdos.c (dos_set_window_size): Likewise.
4767 * process.c (make_process): Likewise.
4768 * xdisp.c (ensure_echo_area_buffers): Likewise.
4769 * xsettings.c (apply_xft_settings): Likewise.
4770
d01ba2f1
GM
47712012-07-09 Glenn Morris <rgm@gnu.org>
4772
4773 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
4774 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
4775 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
4776 * nsterm.h (ns_etc_directory): Add it.
4777 * callproc.c [HAVE_NS]: Include nsterm.h.
4778 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
4779
f1f924b6
DA
47802012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4781
4782 Move marker debugging code under MARKER_DEBUG.
4783 * marker.c (MARKER_DEBUG): Move marker debugging code under
4784 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
4785 for bootstrap with --enable-checking (~3x slowdown reported
4786 by Juanma Barranquero <lekktu@gmail.com>).
4787 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
4788
ab531b66
PE
47892012-07-08 Paul Eggert <eggert@cs.ucla.edu>
4790
4791 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
4792 See <http://bugs.gnu.org/11825#29>.
4793
c4b3bc8a
EZ
47942012-07-08 Eli Zaretskii <eliz@gnu.org>
4795
4796 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
4797 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
4798 (display_line): Add commentary about displaying truncation glyphs
4799 on GUI frames.
4800 (produce_special_glyphs): Move here from term.c.
4801
4802 * term.c (produce_special_glyphs): Move to xdisp.c.
4803
4804 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
4805 section.
c4b3bc8a 4806
b676b881
AS
48072012-07-07 Andreas Schwab <schwab@linux-m68k.org>
4808
f17c5273
AS
4809 * xdisp.c (display_line): Avoid warning about implicit declaration
4810 of FRAME_FONT.
4811
298819b9
AS
4812 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
4813
b676b881
AS
4814 * lisp.h: Remove empty conditional.
4815
6045c4fd
PE
48162012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4817
b3350bf9
PE
4818 * lread.c (load_path_check): Now static.
4819
6045c4fd
PE
4820 Fix some minor --with-ns problems found by static checking.
4821 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
4822 (x_set_font) [!HAVE_X_WINDOWS]:
4823 * image.c (xpm_load_image) [HAVE_NS]:
4824 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
4825 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
4826 Remove unused local.
4827 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
4828 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
4829 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
4830 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
4831 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
4832 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
4833 Fix pointer signedness problem.
4834 * xfaces.c (FRAME_X_FONT_TABLE):
4835 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
4836
929e7845
GM
48372012-07-07 Glenn Morris <rgm@gnu.org>
4838
4839 * lread.c (load_path_check): New function, split from init_lread.
4840 (init_lread): Reorganize. Motivation:
4841 If EMACSLOADPATH is set, check/warn about that rather than the
4842 defaults, which we are not going to use. Hence we can remove
4843 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
4844 Don't warn if site-lisp directories are missing.
4845 If not installed, start from a blank load-path, since
4846 PATH_LOADSEARCH refers to the eventual installation directories.
4847
58dd0aa4
EZ
48482012-07-07 Eli Zaretskii <eliz@gnu.org>
4849
4850 Support truncation and continuation glyphs on GUI frames, when
4851 fringes are disabled. (Bug#11832)
4852 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
4853 continuation glyphs even if on GUI frames.
4854 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
4855 or both, are absent.
4856 (start_display, move_it_in_display_line_to): Handle the case of a
4857 GUI frame without a fringe to display continuation or truncation
4858 glyphs.
4859 (insert_left_trunc_glyphs): Support GUI frames: make sure
4860 truncation glyphs overwrite enough glyphs from the current line to
4861 have sufficient space in pixels.
4862 (display_line): Support truncation and continuation glyphs on GUI
4863 frames. If some spare pixels are left on the line after inserting
4864 the truncation glyphs, fill that space with a stretch glyph of a
4865 suitably computed width.
4866
4867 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
4868 produce_glyphs, to support GUI sessions.
4869
31571fd7
PE
48702012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4871
5a16b9bc
PE
4872 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
4873
f3047c75
PE
4874 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
4875
31571fd7
PE
4876 Do not require float-time's arg to fit in time_t (Bug#11825).
4877 This works better on hosts where time_t is unsigned, and where
4878 float-time is applied to the (negative) difference between two times.
4879 * editfns.c (decode_time_components): Last arg is now double *,
4880 not int *, and means to store all the result as a double, without
4881 worrying about whether the seconds part fits in time_t.
4882 All callers changed.
4883 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
4884 All callers changed.
4885 (Ffloat_time): Do not fail merely because the specified time falls
4886 outside of time_t range.
4887
4516fbef
GM
48882012-07-07 Glenn Morris <rgm@gnu.org>
4889
4890 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
4891 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
4892 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
4893
07adc2c6
JB
48942012-07-07 Juanma Barranquero <lekktu@gmail.com>
4895
4896 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
4897 Update dependencies.
4898
4899 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
4900
fd573f31
PE
49012012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4902
fee5959d
PE
4903 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
4904 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
4905 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
4906 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
4907 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
4908 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
4909
fd573f31
PE
4910 * xfont.c (compare_font_names): Redo to omit the need for casts.
4911
ddadbc0e
AS
49122012-07-06 Andreas Schwab <schwab@linux-m68k.org>
4913
fca8d6b6
AS
4914 * xfns.c (Fx_change_window_property): Doc fix.
4915 * w32fns.c (Fx_change_window_property): Doc fix.
4916
ddadbc0e
AS
4917 * w32fns.c (Fx_window_property): Accept the same arguments as the
4918 X Windows version. Doc fix.
4919 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
4920
ed9265fc 49212012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
4922 Eli Zaretskii <eliz@gnu.org>
4923
4924 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
4925 Windows-specific code from nt/config.nt moved here.
4926 Obsolete settings removed.
4927
216ee680
PE
49282012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4929
4930 * process.c: Avoid unnecessary calls to gettime.
4931 (wait_reading_process_output): Don't get the time of day
4932 when gobbling data immediately and not waiting, as there's no need
4933 for it in that case. This removes a FIXME.
4934
bdd091e4
JD
49352012-07-06 Jan Djärv <jan.h.d@swipnet.se>
4936
4937 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
4938 is defined (Bug#11768).
4939
9d44f8ce
DA
49402012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4941
4942 Fix marker debugging code.
4943 * marker.c (byte_char_debug_check): Do not perform the check
4944 if buffer is not multibyte.
090bd7cb
JB
4945 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4946 Call byte_char_debug_check with correct arguments.
9d44f8ce 4947
90fc4786
DA
49482012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4949
4950 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
4951 * marker.c (byte_char_debug_check, count_markers):
4952 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
4953 (byte_debug_flag): Remove.
4954 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4955 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
4956
7b7ae965
DA
49572012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4958
4e57b342
DA
4959 Avoid code repetition in marker-related functions.
4960 * marker.c (attach_marker): New function.
4961 (Fset_marker, set_marker_restricted, set_marker_both)
4962 (set_marker_restricted_both): Use it.
4963 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
4964 Consistently rename charno to charpos.
4965 (marker_position): Add eassert.
4966 (marker_byte_position): Convert to eassert.
4967
49682012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4969
4970 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 4971 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 4972 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 4973
657924ff
DA
49742012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4975
4976 Introduce fast path for the widely used marker operation.
4977 * alloc.c (build_marker): New function.
4978 * lisp.h (build_marker): New prototype.
4979 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
4980 * composite.c (autocmp_chars): Likewise.
4981 * editfns.c (buildmark): Remove.
4982 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
4983 (save_restriction_save): Use build_marker.
4984 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
4985 * window.c (save_window_save): Likewise.
4986
041a49a6
DA
49872012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4988
4989 Do not use Fdelete_overlay in delete_all_overlays
4990 to avoid redundant calls to unchain_overlay.
4991 * buffer.c (drop_overlay): New function.
4992 (delete_all_overlays, Fdelete_overlay): Use it.
4993 * minibuf.c (get_minibuffer): Fix comment.
4994
7dca65a4
PE
49952012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4996
4997 Port to OpenBSD 5.1 amd64.
4998 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
4999 This is needed for OpenBSD, and should be harmless on all BSD systems.
5000 Also, include <sys/sysctl.h>, as it should be available on all
5001 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
5002 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
5003 use p_pid member, not kp_proc.pid.
5004
8eb876e2
GM
50052012-07-06 Glenn Morris <rgm@gnu.org>
5006
5007 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
5008
38182d90
PE
50092012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5010
5011 More xmalloc and related cleanup.
5012 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
5013 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
5014 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
5015 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
5016 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
5017 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
5018 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
5019 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
5020 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
5021 * xterm.c:
5022 Omit needless casts involving void * pointers and allocation.
5023 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
5024 as the former is more robust if P's type is changed.
5025 Prefer xzalloc to xmalloc + memset 0.
5026 Simplify malloc-or-realloc to realloc.
5027 Don't worry about xmalloc returning a null pointer.
5028 Prefer xstrdup to xmalloc + strcpy.
5029 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
5030 growing it.
5031 * keyboard.c (apply_modifiers_uncached): Prefer local array to
5032 alloca of a constant.
5033
6dd5a677
EZ
50342012-07-05 Eli Zaretskii <eliz@gnu.org>
5035
5036 * xdisp.c (display_line): Fix horizontal pixel coordinates when
5037 hscroll is larger than the line width. Fixes long and futile
5038 looping inside extend_face_to_end_of_line (on a TTY) producing
5039 glyphs that are not needed and thrown away.
5040
6b312f0f
DA
50412012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5042
5043 * marker.c (set_marker_restricted_both): Simplify by using
5044 clip_to_bounds.
5045
f520ef9b
PE
50462012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5047
5048 * editfns.c (region_limit): Simplify by using clip_to_bounds.
5049
383b7c95
JD
50502012-07-05 Jan Djärv <jan.h.d@swipnet.se>
5051
5052 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
5053 not defined (Bug#11768).
5054 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
5055 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
5056 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
5057 followed by gtk_box_set_homogeneous (Bug#11768).
5058 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
5059 (update_theme_scrollbar_width, xg_create_scroll_bar):
5060 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
5061 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
5062 (is_box_type): New function (Bug#11768).
5063 (xg_tool_item_stale_p): Call is_box_type.
5293d758 5064 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
5065 with default display (Bug#11768).
5066
d6e7bf45
EZ
50672012-07-05 Eli Zaretskii <eliz@gnu.org>
5068
5069 * xdisp.c (window_hscroll_limited): New function.
5070 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
5071 coordinates when window's hscroll is set to insanely large
5072 values. (Bug#11857)
5073
431391ec
JB
50742012-07-05 Juanma Barranquero <lekktu@gmail.com>
5075
5076 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
5077 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
5078
23f86fce
DA
50792012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5080
5081 Cleanup xmalloc.
5082 * lisp.h (xzalloc): New prototype. Omit needless casts.
5083 * alloc.c (xzalloc): New function. Omit needless casts.
5084 * charset.c: Omit needless casts. Convert all calls to
5085 xmalloc with following memset to xzalloc.
5086 * dispnew.c: Likewise.
5087 * fringe.c: Likewise.
5088 * image.c: Likewise.
5089 * sound.c: Likewise.
5090 * term.c: Likewise.
5091 * w32fns.c: Likewise.
5092 * w32font.c: Likewise.
5093 * w32term.c: Likewise.
5094 * xfaces.c: Likewise.
5095 * xfns.c: Likewise.
5096 * xterm.c: Likewise.
5097 * atimer.c: Omit needless casts.
5098 * buffer.c: Likewise.
5099 * callproc.c: Likewise.
5100 * ccl.c: Likewise.
5101 * coding.c: Likewise.
5102 * composite.c: Likewise.
5103 * doc.c: Likewise.
5104 * doprnt.c: Likewise.
5105 * editfns.c: Likewise.
5106 * emacs.c: Likewise.
5107 * eval.c: Likewise.
5108 * filelock.c: Likewise.
5109 * fns.c: Likewise.
5110 * gtkutil.c: Likewise.
5111 * keyboard.c: Likewise.
5112 * lisp.h: Likewise.
5113 * lread.c: Likewise.
5114 * minibuf.c: Likewise.
5115 * msdos.c: Likewise.
5116 * print.c: Likewise.
5117 * process.c: Likewise.
5118 * region-cache.c: Likewise.
5119 * search.c: Likewise.
5120 * sysdep.c: Likewise.
5121 * termcap.c: Likewise.
5122 * terminal.c: Likewise.
5123 * tparam.c: Likewise.
5124 * w16select.c: Likewise.
5125 * w32.c: Likewise.
5126 * w32reg.c: Likewise.
5127 * w32select.c: Likewise.
5128 * w32uniscribe.c: Likewise.
5129 * widget.c: Likewise.
5130 * xdisp.c: Likewise.
5131 * xmenu.c: Likewise.
5132 * xrdb.c: Likewise.
5133 * xselect.c: Likewise.
5134
0497dc44
PE
51352012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5136
5137 * fileio.c (time_error_value): Check the right error number.
5138 Problem reported by Troels Nielsen in
5139 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
5140
356e7178
PE
51412012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5142
4e71fd89
PE
5143 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
5144 This should be fixed in a better way; see Eli Zaretskii in
5145 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
5146 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
5147
f0941253
PE
5148 * fileio.c (time_error_value): Rename from special_mtime.
5149 The old name's problems were noted by Eli Zaretskii in
5150 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
5151
065c9eb4
PE
5152 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
5153 This variable's comment says Emacs needs at least one GDB-visible
5154 symbol of type enum pvec_type, to work around GDB problems.
5155 The symbol's value doesn't matter.
5156
356e7178
PE
5157 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
5158 that causes compilation to fail on pre-C99 compilers.
5159
ed9265fc 51602012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
5161
5162 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
5163 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
5164
3884d954
DA
51652012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5166
d209e2fb 5167 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
5168 headers for buffer_defaults and buffer_local_symbols.
5169 Reported by Juanma Barranquero <lekktu@gmail.com>.
5170
ee28be33
SM
51712012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5172
5173 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
5174 * lisp.h (enum pvec_type): Use fewer bits.
5175 (PSEUDOVECTOR_SIZE_BITS): New constant.
5176 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
5177 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
5178 change in pvec_type.
5179 (PSEUDOVECTOR_TYPEP): New macro.
5180 (TYPED_PSEUDOVECTORP): Use it.
5181 * fns.c (internal_equal): Adapt code to extract pvectype.
5182 * emacs.c (gdb_pvec_type): Update type.
5183 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
5184 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
5185 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
5186 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
5187 (sweep_vectors): Use it. Use local var `total_bytes' instead of
5188 abusing vector->header.next.nbytes.
5189 (live_vector_p): Use PVEC_TYPE.
5190 (mark_object): Adapt code to extract pvectype. Use switch.
5191
c7f2cd7f
PE
51922012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5193
5194 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
5195 Tighten new eassert a bit.
5196
8ce70ed2
DA
51972012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5198
5199 Fix compilation with --enable-gcc-warnings and -O1
5200 optimization level.
5201 * doprnt.c (doprnt): Change type of tem to int, initialize
5202 to avoid compiler warning. Add eassert.
5203 * search.c (simple_search): Initialize match_byte to avoid
5204 compiler warning. Add eassert.
5205
dea7f1e5
PE
52062012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5207
24a212eb
PE
5208 Avoid weird behavior with large horizontal scrolls.
5209 Without this change, for example, large hscroll values would
5210 mess up Emacs's display on Fedora 15 x86, presumably due to
5211 overflows in int calculations in the display code.
5212 Also, if buffers had long lines, Emacs would freeze.
5213 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
5214 (set_window_hscroll): New function, containing the old guts of
5215 Fset_window_hscroll. Return the clipped value.
5216 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
5217 This avoids the need to check against PTRDIFF_MAX.
5218
dea7f1e5
PE
5219 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
5220
76046526
DA
52212012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5222
5223 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
5224
39adff0d
PE
52252012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5226
63807d47
PE
5227 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
5228 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
5229 since GCC 4.4.6 issues a bogus warning for them.
5230
39adff0d
PE
5231 Fix bugs in file timestamp newness comparisons.
5232 * fileio.c (Ffile_newer_than_file_p):
5233 * lread.c (Fload): Use full timestamp resolution of files,
5234 not just the 1-second resolution, so that files that are only
5235 slightly newer still count as newer.
5236 * fileio.c (Ffile_newer_than_file_p): Don't assume file
5237 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
5238
dbeed9a6
PE
52392012-07-03 Paul Eggert <eggert@cs.ucla.edu>
5240
5241 * fileio.c: Improve handling of file time marker. (Bug#11852)
5242 (special_mtime): New function.
5243 (Finsert_file_contents, Fverify_visited_file_modtime):
5244 Use it to set special mtime values consistently.
5245
636334d6
AS
52462012-07-03 Andreas Schwab <schwab@linux-m68k.org>
5247
5248 * fileio.c (Finsert_file_contents): Properly handle st_mtime
5249 marker for non-existing file. (Bug#11852)
5250
e2017fe2
GM
52512012-07-03 Glenn Morris <rgm@gnu.org>
5252
5253 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
5254 and did not make it into globals.h).
5255
404dbd37
TT
52562012-07-03 Tom Tromey <tromey@redhat.com>
5257
5258 * window.c (Fset_window_margins, Fset_window_fringes)
5259 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
5260 * textprop.c (Fprevious_property_change): No longer static.
5261 * syntax.c (Fsyntax_table_p): No longer static.
5262 * process.c (Fget_process, Fprocess_datagram_address): No longer
5263 static.
5264 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
5265 * keyboard.c (Fcommand_execute): No longer static.
5266 Remove EXFUN.
5267 * insdel.c (Fcombine_after_change_execute): No longer static.
5268 * image.c (Finit_image_library): No longer static.
5269 * fileio.c (Fmake_symbolic_link): No longer static.
5270 * eval.c (Ffetch_bytecode): No longer static.
5271 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
5272 * doc.c (Fdocumentation_property, Fsnarf_documentation):
5273 No longer static.
404dbd37
TT
5274 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
5275 static.
5276 * dired.c (Ffile_attributes): No longer static.
5277 * composite.c (Fcomposition_get_gstring): No longer static.
5278 * callproc.c (Fgetenv_internal): No longer static.
5279
5280 * ccl.h: Remove EXFUNs.
5281 * buffer.h: Remove EXFUNs.
5282 * dispextern.h: Remove EXFUNs.
5283 * intervals.h: Remove EXFUNs.
5284 * fontset.h: Remove EXFUN.
5285 * font.h: Remove EXFUNs.
5286 * dosfns.c (system_process_attributes): Remove EXFUN.
5287 * keymap.h: Remove EXFUNs.
5288 * lisp.h: Remove EXFUNs.
5289 * w32term.h: Remove EXFUNs.
5290 * window.h: Remove EXFUNs.
5291 * xsettings.h: Remove EXFUN.
5292 * xterm.h: Remove EXFUN.
5293
8e4fd1e1
GM
52942012-07-03 Glenn Morris <rgm@gnu.org>
5295
5296 * lisp.h (Frandom): Make it visible to C.
5297 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
5298 buffer for invisible buffers. (Bug#1229)
5299
ca95b3eb
DA
53002012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5301
5302 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
5303 values which aren't power of 2.
14ae4239
BT
5304 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
5305 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
5306 accordingly.
5307
7555c33f
SM
53082012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
5309
5310 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
5311
5312 * alloc.c (mark_object): Revert part of last patch to use `switch'.
5313
d12e8f5a
DA
53142012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5315
5316 * alloc.c (allocate_vector_block): Remove redundant
5317 calls to mallopt if DOUG_LEA_MALLOC is defined.
5318 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
5319 avoid calls to mallopt if zero_vector is returned.
5320
296094c3
DA
53212012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5322
5323 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
5324 is enabled, avoid dereferencing NULL current_sblock if
5325 running undumped.
5326
36429c89
DA
53272012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5328
5329 Cleanup basic buffer management.
5330 * buffer.h (struct buffer): Change layout to use generic vector
5331 marking code. Fix some comments. Change type of 'clip_changed'
5332 to bitfield. Remove unused #ifndef old.
5333 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
5334 (GET_OVERLAYS_AT): Fix indentation.
5335 (for_each_per_buffer_object_at): New macro.
5336 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
5337 (Fbuffer_local_variables): Use it.
5338 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
5339 * alloc.c (allocate_buffer): Adjust to match new layout of
5340 struct buffer. Fix comment.
5341 (mark_overlay): New function.
5342 (mark_buffer): Use it. Use mark_vectorlike to mark normal
5343 Lisp area of struct buffer.
5344 (mark_object): Use it. Adjust marking of misc objects
5345 and related comments.
5346
3b3e4cac
PE
53472012-07-02 Paul Eggert <eggert@cs.ucla.edu>
5348
5349 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
5350 wrapper that is not needed because the wrapped code is a no-op (zero
5351 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
5352 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
5353
cf5c0175
DA
53542012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
5355
5356 * alloc.c (mark_buffer): Simplify. Remove prototype.
5357 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 5358 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
5359 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
5360 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 5361
ca26824c
GM
53622012-06-30 Glenn Morris <rgm@gnu.org>
5363
2e4c5312
GM
5364 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
5365
ca26824c
GM
5366 * epaths.in (PATH_SITELOADSEARCH): New.
5367 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
5368 This is rather than relying on --enable-locallisppath elements
5369 having "site-lisp" in their names. (Bug#10208#25, 11658)
5370
0d23c240
EZ
53712012-06-30 Eli Zaretskii <eliz@gnu.org>
5372
c9240d7a
EZ
5373 * w32proc.c (sys_select): Accept and ignore one more argument.
5374
5375 * w32.c (emacs_gnutls_pull): Call select with one more argument.
5376
0d23c240 5377 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 5378 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
5379
5380 * sysdep.c: Don't include dos.h and dosfns.h.
5381
5382 * process.c (sys_select):
5383 * msdos.c (sys_select): Accept one more argument and ignore it.
5384
5385 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
5386 adapt data types and code to that.
5387
5388 * dosfns.c:
5389 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
5390 which clashes with the gnulib function of the same name.
5391
af5a5a98
AS
53922012-06-30 Andreas Schwab <schwab@linux-m68k.org>
5393
c5e4379c
AS
5394 * font.c (font_style_to_value, font_style_symbolic)
5395 (font_prop_validate_style): Add type checks for values in
5396 font_style_table.
5397
af5a5a98
AS
5398 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
5399 argument.
5400 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
5401 uses.
5402
8d38f461
EZ
54032012-06-29 Eli Zaretskii <eliz@gnu.org>
5404
2e5a6631
EZ
5405 * xdisp.c (try_window_id): Undo last change.
5406
8d38f461
EZ
5407 * w32.c (getwd): Adjust commentary about startup_dir.
5408 (init_environment): Always call sys_access, even in non-MSVC
5409 builds. Don't chdir to the directory of the Emacs executable.
5410 This undoes code from 1997 which was justified by the need to
5411 "avoid conflicts when removing and renaming directories". But its
5412 downside was that every relative file name was being interpreted
5413 relative to the directory of the Emacs executable, which can never
5414 be TRT. In particular, it broke sys_access when called with
5415 relative file names.
5416 (sys_access): Map GetLastError to errno.
5417
2af3565e
DA
54182012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5419
5420 * window.h (struct window): Change type of 'fringes_outside_margins'
5421 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 5422 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
5423 Adjust comment.
5424 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
5425 to ptrdiff_t.
5426
c8d3a25c 54272012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 5428
c8d3a25c
GM
5429 * gnutls.c (emacs_gnutls_handshake):
5430 Add QUIT to make the loop interruptible.
57570cd3 5431
c8d3a25c 54322012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 5433
c8d3a25c
GM
5434 * charset.c (init_charset): Make lack of etc/charsets fatal.
5435
3e984ee8
DA
54362012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5437
5438 * editfns.c (region_limit): Fix type mismatch.
5439
ef884f23
DA
54402012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5441
5442 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
5443 undefined. Convert from xassert to eassert.
5444 * nsmenu.m: Convert from xassert to eassert.
5445 * nsterm.m: Likewise.
5446
7d7e0027
SM
54472012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
5448
5449 * editfns.c (region_limit): Clip to narrowing (bug#11770).
5450
aa754e6a
PE
54512012-06-28 Paul Eggert <eggert@cs.ucla.edu>
5452
5453 Avoid integer overflow on scroll-left and scroll-right.
5454 * window.c (HSCROLL_MAX): New macro.
5455 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
5456 overflow when requested scroll falls outside ptrdiff_t range.
5457
80b00b08
DA
54582012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5459
5460 * window.h (struct window): Change type of 'hscroll',
5461 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
5462 'last_modified' and 'last_overlay_modified' to EMACS_INT.
5463 Adjust users accordingly.
5464 * xdisp.c (try_cursor_movement): Replace type check with eassert.
5465 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
5466 from EMACS_INT to ptrdiff_t.
5467 (make_window): Omit redundant initialization.
5468
62b2bcf6
JB
54692012-06-28 Juanma Barranquero <lekktu@gmail.com>
5470
5471 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
5472
45942c7d
DA
54732012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5474
5475 * window.h (struct window): Change type of 'use_time' and
5476 'sequence_number' from Lisp_Object to int.
5477 * frame.c (make_frame): Adjust users accordingly.
5478 * print.c (print_object): Likewise.
5479 * window.c (select_window, Fwindow_use_time, make_parent_window)
5480 (make_window): Likewise.
5481
e509cfa6
DA
54822012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5483
5484 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
5485 enabled with --enable-checking=[all,glyphs] configure option.
5486 Fix GLYPH_DEBUG usage assuming that it may be undefined,
5487 adjust comments accordingly.
5488 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
5489 undefined, adjust comments accordingly.
5490 * image.c: Likewise.
5491 * scroll.c: Likewise.
5492 * w32fns.c: Likewise.
5493 * w32term.c: Likewise.
5494 * xdisp.c: Likewise.
5495 * xfaces.c: Likewise.
5496 * xfns.c: Likewise.
5497 * xterm.c: Likewise.
5498
a54e2c05
DA
54992012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5500
5501 Generalize run-time debugging checks.
5502 * dispextern.h (XASSERTS): Remove.
5503 * fontset.c (xassert): Remove.
5504 Convert from xassert to eassert.
5505 * alloc.c: Convert from xassert to eassert.
5506 * bidi.c: Likewise.
5507 * dispnew.c: Likewise.
5508 * fns.c: Likewise.
5509 * fringe.c: Likewise.
5510 * ftfont.c: Likewise.
5511 * gtkutil.c: Likewise.
5512 * image.c: Likewise.
5513 * keyboard.c: Likewise.
5514 * menu.c: Likewise.
5515 * process.c: Likewise.
5516 * scroll.c: Likewise.
5517 * sound.c: Likewise.
5518 * term.c: Likewise.
5519 * w32console.c: Likewise.
5520 * w32fns.c: Likewise.
5521 * w32term.c: Likewise.
5522 * window.c: Likewise.
5523 * xdisp.c: Likewise.
5524 * xfaces.c: Likewise.
5525 * xfns.c: Likewise.
5526 * xselect.c: Likewise.
5527 * xterm.c: Likewise.
5528
1ec4b7b2
SM
55292012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
5530
5531 * fns.c (maybe_resize_hash_table): Output message when growing the
5532 purify-hashtable.
5533
2014308a
DA
55342012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5535
5536 * alloc.c (allocate_string_data): Remove dead code.
5537 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
5538 avoid GCC warning about unused macro.
5539
246155eb
DA
55402012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5541
5542 * alloc.c (allocate_string): Omit intervals initialization.
5543 * alloc.c (make_uninit_multibyte_string): Initialize intervals
5544 as in make_pure_string and make_pure_c_string.
5545
43184b7b
DA
55462012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5547
d209e2fb 5548 * alloc.c (allocate_string): Fix last change.
43184b7b 5549
3fe6dd74
DA
55502012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5551
d209e2fb 5552 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
5553 to memset, add explicit initialization where appropriate.
5554
1ba6038a
GM
55552012-06-27 Glenn Morris <rgm@gnu.org>
5556
5557 * lisp.mk (lisp): Remove paths.elc.
5558
c89926a5
CY
55592012-06-27 Chong Yidong <cyd@gnu.org>
5560
5561 * doc.c (Fsubstitute_command_keys): Fix punctuation.
5562
ed6b3510
JW
55632012-06-26 John Wiegley <johnw@newartisans.com>
5564
1ec4b7b2 5565 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
5566 on Mac OS X Lion: __mod_init_func and __mod_term_func.
5567
ed6b3510
JW
5568 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
5569 when building with Clang.
5570
8edd4a2b
SM
55712012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
5572
5573 * eval.c (Fapply): Allow calling it with a single argument.
5574
f6f62d1b
EZ
55752012-06-26 Eli Zaretskii <eliz@gnu.org>
5576
5577 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
5578 _stricmp and _strnicmp.
5579 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
5580
62efea5e
DA
55812012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5582
5583 * alloc.c (allocate_window): Zero out non-Lisp part of newly
5584 allocated window.
5585 (allocate_process): Likewise for new process.
8edd4a2b 5586 (allocate_terminal): Change to use offsetof.
62efea5e
DA
5587 (allocate_frame): Likewise.
5588 * frame.c (make_frame): Omit redundant initialization.
5589 * window.c (make_parent_window): Use memset.
5590 (make_window): Omit redundant initialization.
5591 * process.c (make_process): Omit redundant initialization.
5592 * terminal.c (create_terminal): Likewise.
5593
42997f4d
DA
55942012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5595
5596 * term.c (delete_tty): Remove redundant call to memset.
5597
1130ecfc
DA
55982012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5599
5600 * alloc.c: Remove build_string.
5601 * lisp.h: Define build_string as static inline. This provides
5602 a better opportunity to optimize away calls to strlen when the
5603 function is called with compile-time constant argument.
5604 * image.c (imagemagick_error): Convert to build_string.
5605 * w32proc.c (sys_spawnve): Likewise.
5606 * xterm.c (x_term_init): Likewise.
5607
cf38a720
PE
56082012-06-26 Paul Eggert <eggert@cs.ucla.edu>
5609
99027bdd
PE
5610 Use sprintf return value instead of invoking strlen on result.
5611 In the old days this wasn't portable, since some sprintf
5612 implementations returned char *. But they died out years ago and
5613 Emacs already assumes sprintf returns int.
5614 Similarly for float_to_string.
5615 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
5616 * ccl.c (ccl_driver):
5617 * character.c (string_escape_byte8):
5618 * data.c (Fnumber_to_string):
5619 * doprnt.c (doprnt):
5620 * print.c (print_object):
5621 * xdisp.c (message_dolog):
5622 * xfns.c (syms_of_xfns):
5623 Use sprintf or float_to_string result to avoid need to call strlen.
5624 * data.c (Fnumber_to_string):
5625 Use make_unibyte_string, since the string must be ASCII.
5626 * lisp.h, print.c (float_to_string): Now returns int length.
5627 * term.c (produce_glyphless_glyph):
5628 Use sprintf result rather than recomputing it.
5629
cf38a720
PE
5630 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
5631 * Makefile.in (ALL_CFLAGS):
5632 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
5633 * gmalloc.c, regex.c: Include <config.h> unconditionally.
5634
3511c784
DA
56352012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
5636
0a08eb21 5637 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
5638 strcasecmp if available.
5639 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
5640
fb7da12e
AS
56412012-06-25 Andreas Schwab <schwab@linux-m68k.org>
5642
5643 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
5644 Avoid comma operator.
5645 * menu.c (push_submenu_start, push_submenu_end)
5646 (push_left_right_boundary, push_menu_pane): Likewise.
5647 * msdos.c (dos_rawgetc): Likewise.
5648
afa2ffd8
DA
56492012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
5650
5651 * xfns.c (xic_create_fontsetname): Remove redundant calls
5652 to memset.
5653
b3b4476b
PE
56542012-06-25 Paul Eggert <eggert@cs.ucla.edu>
5655
4495ff38
PE
5656 * gtkutil.c (get_utf8_string): Remove redundant assignment.
5657 sprintf already null-terminates its output.
5658
b3b4476b
PE
5659 * xfns.c (x_window): Remove redundant cast.
5660
b00876c9
DA
56612012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
5662
5663 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
5664 `const char *' to `char *' to avoid compiler warning.
5665
d188e26b
PE
56662012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5667
885d1d74
PE
5668 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
5669 instead of truncating it to 63 (admittedly a generous limit).
5670
d188e26b
PE
5671 * process.c: Fix spelling and caps in comments.
5672
e2f560b1
DN
56732012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
5674
e86db54b 5675 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
5676 * sysdep.c (setpgrp): Remove definition, not used in this file.
5677
7583a3a1
JB
56782012-06-24 Juanma Barranquero <lekktu@gmail.com>
5679
5680 * makefile.w32-in: Update dependencies.
5681
696056c2
EZ
56822012-06-24 Eli Zaretskii <eliz@gnu.org>
5683
5684 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
5685 (SYSTIME_H): Add nt/inc/sys/time.h.
5686
5687 * systime.h [WINDOWSNT]: Include sys/time.h.
5688
5689 * s/ms-w32.h (struct timespec): Definition moved from
5690 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
5691
845ca893
PE
56922012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5693
5694 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
5695 * buffer.h (buffer_slot_type_mismatch):
5696 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
5697 * eval.c (unwind_to_catch):
5698 * image.c (my_png_error, my_error_exit):
5699 * keyboard.c (quit_throw_to_read_char, user_error)
5700 (Fexit_recursive_edit, Fabort_recursive_edit):
5701 * lisp.h (die, args_out_of_range, args_out_of_range_3)
5702 (wrong_type_argument, buffer_overflow, __executable_start)
5703 (memory_full, buffer_memory_full, string_overflow, Fthrow)
5704 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
5705 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
5706 (fatal):
5707 (child_setup) [!DOS_NT]:
5708 * lread.c (end_of_file_error, invalid_syntax):
5709 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
5710 * puresize.h (pure_write_error):
5711 * search.c (matcher_overflow):
5712 * sound.c (sound_perror, alsa_sound_perror):
5713 * sysdep.c, syssignal.h (croak):
5714 * term.c (maybe_fatal, vfatal):
5715 * textprop.c (text_read_only):
5716 * undo.c (user_error):
5717 * unexmacosx.c (unexec_error):
5718 * xterm.c (x_ins_del_lines, x_delete_glyphs):
5719 Use _Noreturn rather than NO_RETURN.
5720 No need for separate decl merely because of _Noreturn.
5721 * sound.c (sound_warning, parse_sound):
5722 Remove unnecessary forward decls.
5723
f1dd8073
PE
57242012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5725
5726 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
5727 * lisp.h (WAIT_READING_MAX): New macro.
5728 * dispnew.c (Fsleep_for, sit_for):
5729 * keyboard.c (kbd_buffer_get_event):
5730 * process.c (Faccept_process_output):
5731 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
5732 This improves on the previous patch, which introduced a bug
5733 when time_t is unsigned and as wide as intmax_t.
5734 See <http://bugs.gnu.org/9000#51>.
5735
b82c1755
EZ
57362012-06-23 Eli Zaretskii <eliz@gnu.org>
5737
5738 * dispnew.c (sit_for, Fsleep_for):
5739 * keyboard.c (kbd_buffer_get_event):
5740 * process.c (Faccept_process_output): Avoid compiler warnings when
5741 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
5742
ca300656
JB
57432012-06-23 Juanma Barranquero <lekktu@gmail.com>
5744
049ec95b
JB
5745 * makefile.w32-in: Update dependencies.
5746
ca300656
JB
5747 * w32.c (ltime): Add return type and declare static.
5748 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
5749
db7b8d06
PE
57502012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5751
5752 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
5753 Privately reported by Herbert J. Skuhra.
5754 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
5755 All uses changed.
5756 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
5757 not make_lisp_timeval, when the argument is of type EMACS_TIME.
5758
0bd8297f
EZ
57592012-06-23 Eli Zaretskii <eliz@gnu.org>
5760
96512555
EZ
5761 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
5762 last argument of make_unibyte_string.
5763
0bd8297f
EZ
5764 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
5765 language ID in the event parameters.
5766
5767 * w32term.c (w32_read_socket): Put the new keyboard codepage into
5768 event.code, not the obscure "character set ID".
5769
63def6b6
CY
57702012-06-23 Chong Yidong <cyd@gnu.org>
5771
5772 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
5773
e8a02204
EZ
57742012-06-23 Eli Zaretskii <eliz@gnu.org>
5775
388cdec0
EZ
5776 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
5777 * w32.c (fdutimens): New function.
5778
5779 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
5780
5781 * s/ms-w32.h (pselect): Redirect to sys_select.
5782
5783 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
5784
e8a02204
EZ
5785 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
5786 in the logic of incrementing and decrementing the value of
5787 use_relocatable_buffers.
5788
d054f3fb
PE
57892012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5790
5791 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
5792 Privately reported by Herbert J. Skuhra.
5793 [__FreeBSD__]: Remove "*/" typo after "#include".
5794 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
5795 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
5796 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
5797 Don't assume EMACS_TIME and struct timeval are the same type.
5798
d35af63c
PE
57992012-06-22 Paul Eggert <eggert@cs.ucla.edu>
5800
5801 Support higher-resolution time stamps (Bug#9000).
5802 The time stamps are only nanosecond-resolution at the C level,
5803 since that's the best that any real-world system supports now.
5804 But they are picosecond-resolution at the Lisp level, as that's
5805 easy, and leaves room for future OS improvements.
5806
5807 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
5808 (LIBES): Use it.
5809
5810 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
5811 Don't get current time unless it's needed.
5812
5813 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
5814 now provides it if it's absent.
5815 (start_atimer): Port to higher-res time stamps.
5816 Check for time stamp overflow. Don't get current time more
5817 often than is needed.
5818
5819 * buffer.h (struct buffer): Buffer modtime now has high resolution.
5820 Include systime.h, not time.h.
5821 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
5822
5823 * dired.c: Include stat-time.h.
5824 (Ffile-attributes): File times now have higher resolution.
5825
5826 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
5827 (struct image): Timestamp now has higher resolution.
5828
5829 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
5830 has at least microseconds now. All uses removed.
5831 (update_frame, update_single_window, update_window, update_frame_1)
5832 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 5833 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
5834
5835 * editfns.c (time_overflow): Now extern.
5836 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
5837 (float-time, Fformat_time_string, Fcurrent_time_string)
5838 (Fcurrent_time_zone): Accept and generate higher-resolution
5839 time stamps.
5840 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
5841 (decode_time_components, lisp_seconds_argument): New functions.
5842 (make_time): Now static.
5843 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
5844 Report an error if the time is invalid, rather than having the caller
5845 do that.
5846
5847 * fileio.c: Include <stat-time.h>
5848 (Fcopy_file): Copy higher-resolution time stamps.
5849 Prefer to set the time stamp via a file descriptor if that works.
5850 (Fset_file_times, Finsert_file_contents, Fwrite_region)
5851 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
5852 (Fvisited_file_modtime, Fset_visited_file_modtime):
5853 Support higher-resolution time stamps.
5854
5855 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
5856
5857 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
5858
5859 * image.c (prepare_image_for_display, clear_image_cache)
5860 (lookup_image): Port to higer-resolution time stamps.
5861
5862 * keyboard.c (start_polling, bind_polling_period):
5863 Check for time stamp overflow.
5864 (read_char, kbd_buffer_get_event, timer_start_idle)
5865 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
5866 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
5867 Port to higher-resolution time stamps. Do not assume time_t is signed.
5868 (decode_timer): New function. Timers are now vectors of length 9,
5869 not 8, to accommodate the picosecond component.
5870 (timer_check_2): Use it.
5871
5872 * nsterm.m (select_timeout, timeval_subtract): Remove.
5873 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
5874 as they're a bit more accurate and handle overflow better.
5875 (ns_select): Change prototype to be compatible with pselect.
5876 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
5877 * nsterm.h (ns_select): Adjust prototype.
5878
5879 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
5880 us-resolution time stamps.
5881 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
5882
5883 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
5884
5885 * lisp.h (time_overflow): New decl.
5886 (wait_reading_process_output): First arg is now intmax_t, not int,
5887 to accommodate larger waits.
5888
5889 * process.h (struct Lisp_Process.read_output_delay):
5890 Now counts nanoseconds, not microseconds.
5891 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
5892 EMACS_HAS_USECS.
5893 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
5894 (wait_reading_process_output):
5895 Port to ns-resolution time stamps.
5896 (Faccept_process_output, wait_reading_process_output):
5897 Check for time stamp overflow. Do not assume time_t is signed.
5898 (select_wrapper): Remove; we now use pselect.
5899 (Fprocess_attributes): Now generates ns-resolution time stamps.
5900
5901 * sysdep.c: Include utimens.h. Don't include utime.h
5902 or worry about struct utimbuf; gnulib does that for us now.
5903 (gettimeofday): Remove; gnulib provides a substitute.
5904 (make_timeval): New function.
5905 (set_file_times): Now sets ns-resolution time stamps.
5906 New arg FD; all uses changed.
5907 (time_from_jiffies, ltime_from_jiffies, get_up_time)
5908 (system_process_attributes):
5909 Now returns ns-resolution time stamp. All uses changed.
5910 Check for time stamp overflow.
5911
5912 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
5913 provides a substitute now.
5914
5915 * systime.h: Include timespec.h rather than sys/time.h and time.h,
5916 since it guarantees struct timespec.
5917 (EMACS_TIME): Now struct timespec, so that we can support
5918 ns-resolution time stamps.
5919 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
5920 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
5921 (EMACS_USECS): Remove.
5922 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
5923 so multiply the arg by 1000 before storing it.
5924 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
5925 New macros.
5926 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
5927 Port to ns-resolution time stamps.
5928 (EMACS_TIME_NEG_P): Remove; replaced by....
5929 (EMACS_TIME_SIGN): New macro.
5930 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
5931 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
5932 (set_file_times, make_time, lisp_time_argument): Adjust signature.
5933 (make_timeval, make_lisp_time, decode_time_components): New decls.
5934 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
5935 that it mishandled time_t overflow. You can't compare by subtracting!
5936 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
5937 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
5938
5939 * term.c: Include <sys/time.h>.
5940 (timeval_to_Time): New function, for proper overflow wraparound.
5941 (term_mouse_position, term_mouse_click): Use it.
5942
5943 * undo.c (record_first_change): Support higher-resolution time stamps
5944 in the undo buffer.
5945 (Fprimitive_undo): Use them when restoring time stamps.
5946
5947 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
5948 (w32_get_internal_run_time):
5949 Port to higher-resolution Emacs time stamps.
5950 (ltime): Now accepts single 64-bit integer, as that's more convenient
5951 for callers.
5952
5953 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
5954
5955 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
5956 for compatibility with pselect. Support ns-resolution time stamps.
5957
5958 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
5959
5960 * xselect.c (wait_for_property_change, x_get_foreign_selection):
5961 Check for time stamp overflow, and support ns-resolution time stamps.
5962
5963 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
5964 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
5965 (timeval_subtract): Remove; no longer needed.
5966 (XTflash, XTring_bell, x_wait_for_event):
5967 Port to ns-resolution time stamps. Don't assume time_t is signed.
5968
b6a92dfe
CY
59692012-06-22 Chong Yidong <cyd@gnu.org>
5970
5971 * xdisp.c (x_consider_frame_title): Revert last change.
5972
d251c37c
EZ
59732012-06-22 Eli Zaretskii <eliz@gnu.org>
5974
5975 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
5976 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
5977 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
5978 staticidx goes up to 1597 out of 1600 = 0x640.)
5979
f10deafb
PE
59802012-06-20 Paul Eggert <eggert@cs.ucla.edu>
5981
5982 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
5983 Otherwise, the umask might be mistakenly 0 while handling input signals.
5984
ec6de1e2
SM
59852012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
5986
5987 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
5988
28be1ada
DA
59892012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
5990
5991 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
5992 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
5993 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
5994 access to `contents' member of Lisp_Vector objects with AREF and ASET
5995 where appropriate.
5996
c6bf3022
CY
59972012-06-19 Chong Yidong <cyd@gnu.org>
5998
5999 * frame.c (delete_frame): When selecting a frame on a different
6000 text terminal, do not alter the terminal's top-frame.
6001
6002 * xdisp.c (format_mode_line_unwind_data): Record the target
6003 frame's selected window and its terminal's top-frame.
6004 (unwind_format_mode_line): Restore them.
6005 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
6006 Callers changed.
6007 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
6008 since tty frames can be explicitly named.
6009 (prepare_menu_bars): Likewise.
6010
6011 * term.c (Ftty_top_frame): New function.
6012
defd4196
PE
60132012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6014
6015 Port byte-code-meter to modern targets.
6016 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
6017 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 6018 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
6019 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
6020 (METER_1, METER_2): Simplify.
6021
1053a871
SM
60222012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
6023
6024 * data.c (Fdefalias): Return `symbol' (bug#11686).
6025
b7e8d081
MR
60262012-06-18 Martin Rudalics <rudalics@gmx.at>
6027
6028 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
6029 gets killed during executing of this function (Bug#11665).
6030 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
6031 (Vkill_buffer_query_functions): In doc-string say that functions
6032 run by this hook should not change the current buffer.
6033
7ea2b339
PE
60342012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6035
6036 Fix recently-introduced process.c problems found by static checking.
6037 * process.c (write_queue_push, write_queue_pop, send_process):
6038 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
6039 (write_queue_pop): Fix pointer signedness problem.
6040 (send_process): Remove unused local.
6041
96a313a1
CY
60422012-06-17 Chong Yidong <cyd@gnu.org>
6043
6044 * xdisp.c (redisplay_internal): No need to redisplay terminal
6045 frames that are not on top.
6046
20ca2e94
TN
60472012-06-17 Troels Nielsen <bn.troels@gmail.com>
6048
6049 * process.c (make_process): Initialize write_queue.
6050 (write_queue_push, write_queue_pop): New functions.
6051 (send_process): Use them to maintain correct ordering of process
6052 writes (Bug#10815).
6053
9a900ca9
PE
60542012-06-17 Paul Eggert <eggert@cs.ucla.edu>
6055
310fbfa8
PE
6056 * lisp.h (eassert): Assume C89 or later.
6057 This removes the need for CHECK.
6058 (CHECK): Remove. Its comments about always evaluating its
6059 argument were confusing, as 'eassert' typically does not evaluate
6060 its argument.
6061
27bb1ca4
PE
6062 * coding.c (produce_chars): Use ptrdiff_t, not int.
6063
9a900ca9
PE
6064 * xterm.c (x_draw_underwave): Check for integer overflow.
6065 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
6066
41b7f8bc 60672012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
6068
6069 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
6070 referenced (Bug#11583).
6071
9b0e3eba
AA
60722012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
6073
6074 Implement wave-style variant of underlining.
6075 * dispextern.h (face_underline_type): New enum.
6076 (face): Add field for underline type.
6077 * nsterm.m (ns_draw_underwave): New function.
6078 (ns_draw_text_decoration): Use it.
6079 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
6080 New functions.
6081 (x_draw_glyph_string): Use them.
6082 * xfaces.c (Qline, Qwave): New Lisp objects.
6083 (check_lface_attrs, merge_face_ref)
1053a871
SM
6084 (Finternal_set_lisp_face_attribute, realize_x_face):
6085 Handle wave-style underline face attributes.
9b0e3eba
AA
6086 * xterm.c (x_draw_underwave): New function.
6087 (x_draw_glyph_string): Use it.
6088
0fb52f11
JB
60892012-06-16 Juanma Barranquero <lekktu@gmail.com>
6090
6091 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
6092 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
6093 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
6094 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
6095 ($(BLD)/w32select.$(O)): Update dependencies.
6096
e5560ff7
AS
60972012-06-16 Andreas Schwab <schwab@linux-m68k.org>
6098
6099 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
6100 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
6101 * character.c (_fetch_multibyte_char_p): Remove.
6102 * alloc.c: Include "character.h" before "buffer.h".
6103 * bidi.c: Likewise.
6104 * buffer.c: Likewise.
6105 * bytecode.c: Likewise.
6106 * callint.c: Likewise.
6107 * callproc.c: Likewise.
6108 * casefiddle.c: Likewise.
6109 * casetab.c: Likewise.
6110 * category.c: Likewise.
6111 * cmds.c: Likewise.
6112 * coding.c: Likewise.
6113 * composite.c: Likewise.
6114 * dired.c: Likewise.
6115 * dispnew.c: Likewise.
6116 * doc.c: Likewise.
6117 * dosfns.c: Likewise.
6118 * editfns.c: Likewise.
6119 * emacs.c: Likewise.
6120 * fileio.c: Likewise.
6121 * filelock.c: Likewise.
6122 * font.c: Likewise.
6123 * fontset.c: Likewise.
6124 * fringe.c: Likewise.
6125 * indent.c: Likewise.
6126 * insdel.c: Likewise.
6127 * intervals.c: Likewise.
6128 * keyboard.c: Likewise.
6129 * keymap.c: Likewise.
6130 * lread.c: Likewise.
6131 * macros.c: Likewise.
6132 * marker.c: Likewise.
6133 * minibuf.c: Likewise.
6134 * nsfns.m: Likewise.
6135 * nsmenu.m: Likewise.
6136 * print.c: Likewise.
6137 * process.c: Likewise.
6138 * regex.c: Likewise.
6139 * region-cache.c: Likewise.
6140 * search.c: Likewise.
6141 * syntax.c: Likewise.
6142 * term.c: Likewise.
6143 * textprop.c: Likewise.
6144 * undo.c: Likewise.
6145 * unexsol.c: Likewise.
6146 * w16select.c: Likewise.
6147 * w32fns.c: Likewise.
6148 * w32menu.c: Likewise.
6149 * window.c: Likewise.
6150 * xdisp.c: Likewise.
6151 * xfns.c: Likewise.
6152 * xmenu.c: Likewise.
6153 * xml.c: Likewise.
6154 * xselect.c: Likewise.
6155
2f07e6af
EZ
61562012-06-16 Eli Zaretskii <eliz@gnu.org>
6157
1053a871
SM
6158 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
6159 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 6160 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
6161 row.
6162 (handle_face_prop): Use chunk-relative overlay string index when
6163 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
6164 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
6165 the rightmost. (Bug#11720)
2f07e6af 6166
29b83cec
AS
61672012-06-16 Andreas Schwab <schwab@linux-m68k.org>
6168
6169 * category.h (CHAR_HAS_CATEGORY): Define as inline.
6170 (CATEGORY_MEMBER): Enforce 1/0 value.
6171 * category.c (_temp_category_set): Remove.
6172
4c5501e9
EZ
61732012-06-16 Eli Zaretskii <eliz@gnu.org>
6174
6175 * window.c (Fdelete_other_windows_internal)
6176 (Fdelete_window_internal): Don't access frame's mouse highlight
6177 info of the initial frame. (Bug#11677)
6178
2b570124
PE
61792012-06-14 Paul Eggert <eggert@cs.ucla.edu>
6180
e93864f9
PE
6181 * .gdbinit (xgetint): Fix recently-introduced paren typo.
6182 Assume USE_2_TAGS_FOR_INTS.
6183 (xreload): Adjust $tagmask width to match recent lisp.h change.
6184
2b570124
PE
6185 Simplify lisp.h in minor ways that should not affect code.
6186 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
6187 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
6188 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
6189 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
6190 (INTTYPEBITS): New macro, for clarity.
6191 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
6192 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
6193 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
6194 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
6195 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
6196
81755f69
JB
61972012-06-13 Juanma Barranquero <lekktu@gmail.com>
6198
6199 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
6200
16192a57
GM
62012012-06-13 Glenn Morris <rgm@gnu.org>
6202
6203 * s/bsd-common.h (BSD4_3):
6204 * s/usg5-4-common.h (USG5_4): No longer define; unused.
6205
646b5f55
AS
62062012-06-13 Andreas Schwab <schwab@linux-m68k.org>
6207
6208 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
6209 instead of union.
6210 (XLI, XIL): Define.
1053a871
SM
6211 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
6212 Use them.
6213 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 6214 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 6215 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
6216 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
6217 * frame.c (delete_frame): Remove outdated comment.
6218 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
6219 USE_LISP_UNION_TYPE.
6220 (Fw32_unregister_hot_key): Likewise.
6221 (Fw32_toggle_lock_key): Likewise.
6222 * w32menu.c (add_menu_item): Likewise.
6223 (w32_menu_display_help): Use XIL instead of checking
6224 USE_LISP_UNION_TYPE.
6225 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
6226 (init_heap): Likewise.
6227 * w32term.c (w32_read_socket): Update comment.
6228
1d3823c9
GM
62292012-06-13 Glenn Morris <rgm@gnu.org>
6230
c62ff706
GM
6231 * s/usg5-4-common.h, src/s/unixware.h:
6232 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
6233
1d3823c9
GM
6234 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
6235
bfe3e0a2
PE
62362012-06-13 Paul Eggert <eggert@cs.ucla.edu>
6237
6238 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
6239 * alloc.c (make_number) [!defined make_number]:
6240 Remove, as lisp.h always defines this now.
6241 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
6242 (roundup_size): Verify that it is a power of 2.
6243 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
6244 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
6245 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
6246 -DUSE_LSB_TAG=0, to override the automatically-selected default.
6247 USE_LSB_TAG now is always defined to be either 0 or 1.
6248 All uses changed.
6249 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
6250 code works fine either way, and efficiency is not a concern here,
6251 as the union type is for debugging, not for production.
6252 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
6253 Use an inline function on all platforms when using the union type,
6254 since this is simpler and 'static inline' can be used portably
6255 within Emacs now.
6256 (LISP_INITIALLY_ZERO): New macro.
6257 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
6258 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
6259
45fa9c0f
GM
62602012-06-12 Glenn Morris <rgm@gnu.org>
6261
b4492cba
GM
6262 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
6263
6264 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 6265
45fa9c0f
GM
6266 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
6267 Move BROKEN_SIGIO to configure.
6268
6269 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
6270 Move NO_TERMIO to configure.
6271
0e25d334
CY
62722012-06-12 Chong Yidong <cyd@gnu.org>
6273
6274 * image.c (imagemagick_load_image): Use MagickFlattenImage if
6275 MagickMergeImageLayers is undefined. Use pixel pusher loop if
6276 MagickExportImagePixels is undefined.
6277
43682bb6
PE
62782012-06-12 Paul Eggert <eggert@cs.ucla.edu>
6279
6280 * image.c (imagemagick_load_image): Remove unused label.
6281
a9be7d2b
GM
62822012-06-11 Glenn Morris <rgm@gnu.org>
6283
6284 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
6285 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
6286 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
6287 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
6288
3017f87f
SM
62892012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
6290
6291 * alloc.c (make_byte_code): New function.
6292 (Fmake_byte_code): Use it. Don't purify here.
6293 * lread.c (read1): Use it as well to avoid extra allocation.
6294
1b9b4cf4
CY
62952012-06-11 Chong Yidong <cyd@gnu.org>
6296
6297 * image.c (imagemagick_load_image): Implement transparency.
6298
95988fcf
AS
62992012-06-10 Andreas Schwab <schwab@linux-m68k.org>
6300
6301 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
6302 account for preceding backslashes. (Bug#11663)
6303
cd4eb164
CY
63042012-06-09 Chong Yidong <cyd@gnu.org>
6305
6306 * term.c: Support italics in capable terminals (Bug#9652).
6307 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
6308 (turn_on_face): Output using TS_enter_italic_mode if available.
6309 Don't handle unused blinking and alt-charset cases.
6310 (turn_off_face): Handle italic case; discard unused tty_blinking_p
6311 and tty_alt_charset_p cases.
6312 (tty_capable_p, init_tty): Support italics.
6313
6314 * termchar.h (struct tty_display_info): Add field for italics.
6315 Remove unused blink field.
6316
6317 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
6318 Handle slant.
6319
6320 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
6321 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
6322 tty_alt_charset_p. Add tty_italic_p.
6323
ff88beb8
MA
63242012-06-09 Michael Albinus <michael.albinus@gmx.de>
6325
6326 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
6327 dbus_type_is_basic if available.
6328 (xd_extract_signed, xd_extract_unsigned): Rename from
6329 extract_signed and extract_unsigned, respectively. Adapt callers.
6330
44286096
CY
63312012-06-09 Chong Yidong <cyd@gnu.org>
6332
1682701f
CY
6333 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
6334
44286096
CY
6335 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
6336 case (Bug#9752).
6337
d86feb17
PE
63382012-06-08 Paul Eggert <eggert@cs.ucla.edu>
6339
6340 * xdisp.c (vmessage): Treat frame message as multibyte.
6341 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
6342 would generate the diagnostic "Making \302\247 buffer-local while
6343 let-bound!".
6344
d5c20fe8
EZ
63452012-06-08 Eli Zaretskii <eliz@gnu.org>
6346
6347 * dispnew.c (showing_window_margins_p): Undo last change, which
6348 was done due to an inadvertent commit.
6349 (adjust_frame_glyphs_for_frame_redisplay): Do call
6350 showing_window_margins_p.
6351
513749ee
SM
63522012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
6353
6354 * eval.c (Fmake_var_non_special): New primitive.
6355 (syms_of_eval): Defsubr it.
6356 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
6357
d4a8f5c1
JB
63582012-06-08 Juanma Barranquero <lekktu@gmail.com>
6359
6360 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
6361 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
6362
8bbbc977
EZ
63632012-06-08 Eli Zaretskii <eliz@gnu.org>
6364
6365 * alloc.c (allocate_vectorlike): Fix last change.
6366
f3372c87
DA
63672012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
6368
6369 Block-based vector allocation of small vectors.
6370 * lisp.h (struct vectorlike_header): New field `nbytes',
6371 adjust comment accordingly.
6372 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
fc0c31f8 6373 to denote vector blocks. Adjust users (live_vector_p,
f3372c87
DA
6374 mark_maybe_pointer, valid_lisp_object_p) accordingly.
6375 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
6376 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
6377 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
6378 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
6379 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
6380 (roundup_size): New constant.
6381 (struct vector_block): New data type.
6382 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 6383 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
6384 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
6385 (sweep_vectors): New functions.
6386 (allocate_vectorlike): Return `zero_vector' as the only vector of
fc0c31f8 6387 0 items. Allocate new vector from block if vector size is less than
f3372c87
DA
6388 or equal to VBLOCK_BYTES_MAX.
6389 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
6390 (init_alloc_once): Add call to init_vectors.
6391
4f18a4ed
SM
63922012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
6393
6394 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
6395
86f158bc
PE
63962012-06-07 Paul Eggert <eggert@cs.ucla.edu>
6397
6398 * doprnt.c (doprnt): Truncate multibyte char correctly.
6399 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
6400 would mishandle a string argument "Xc" if X was a multibyte
6401 character of length 2: it would truncate after X's first byte
6402 rather than including all of X.
6403
c5cfcbe0
CY
64042012-06-06 Chong Yidong <cyd@gnu.org>
6405
6406 * buffer.c (word_wrap): Doc fix.
6407
c05cf390
PE
64082012-06-04 Paul Eggert <eggert@cs.ucla.edu>
6409
6410 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
6411
0c3461de
GM
64122012-06-03 Glenn Morris <rgm@gnu.org>
6413
6414 * xdisp.c (tool-bar-style): Doc fix.
6415
c71232db
UM
64162012-06-03 Ulrich Müller <ulm@gentoo.org>
6417
6418 * Makefile.in (PAXCTL): Define.
6419 (temacs$(EXEEXT)): Disable memory randomization for the temacs
6420 binary via PaX flags if the paxctl utility is available.
6421 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
6422 Restore PaX flags to their default. (Bug#11398)
6423
383f7350
CY
64242012-06-03 Chong Yidong <cyd@gnu.org>
6425
6426 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
6427 buffer (Bug#11226).
6428
5f2c76c6
CY
64292012-06-03 Chong Yidong <cyd@gnu.org>
6430
6431 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
6432 (note_mode_line_or_margin_highlight): If there is no help echo,
6433 use mode-line-default-help-echo. Handle the case where the mouse
6434 position is past the end of the mode line string.
6435
6436 * buffer.c (buffer_local_value_1): New function, split from
6437 Fbuffer_local_value; can return Qunbound.
6438 (Fbuffer_local_value): Use it.
6439 (Vmode_line_format): Docstring tweaks.
6440
773d47f6
PE
64412012-06-02 Paul Eggert <eggert@cs.ucla.edu>
6442
6443 * sysdep.c (system_process_attributes): Improve comment.
6444
f2d6a3df
SM
64452012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
6446
6447 * keyboard.c: Export real-this-command to Elisp.
6448 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
6449 and DEFVAR it. Update all users.
6450
63810350
PE
64512012-06-02 Paul Eggert <eggert@cs.ucla.edu>
6452
7bd5c1f4
PE
6453 * minibuf.c (Fassoc_string): Remove duplicate declaration.
6454
63810350
PE
6455 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
6456 Convert pctcpu and pctmem to Lisp float properly.
6457 Let the compiler fold better, as 100.0/0x8000 is exact.
6458
a2821611
AS
64592012-06-02 Andreas Schwab <schwab@linux-m68k.org>
6460
6461 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
6462 cons_block.
6463
5fceba1d
PE
64642012-06-01 Paul Eggert <eggert@cs.ucla.edu>
6465
6466 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
6467
c98ff5dd
DA
64682012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
6469
6470 For a 'struct window', replace some Lisp_Object fields to
6471 bitfields where appropriate, remove unused fields.
6472 * window.h (struct window): Remove unused 'last_mark_x' and
6473 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
6474 change it's type from Lisp_Object to bitfield.
6475 Change type of 'force_start', 'optional_new_start',
6476 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fc0c31f8 6477 fields from Lisp_Object to bitfield. Adjust users accordingly.
c98ff5dd 6478
ca34e0be
PE
64792012-05-31 Paul Eggert <eggert@cs.ucla.edu>
6480
6481 Pacify gcc -Wdouble-precision when using Xaw.
6482 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
6483 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
6484 Use 'float' consistently, rather than 'float' in most places
6485 and 'double' in a couple of places.
6486
efc00ab1 64872012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
6488
6489 * xdisp.c (handle_stop): Detect whether we have overlay strings
6490 loaded by testing it->current.overlay_string_index to be
6491 non-negative, instead of checking whether n_overlay_strings is
6492 positive. (Bug#11587)
6493
efc00ab1 64942012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
6495
6496 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
6497
6498 * doc.c (Fsubstitute_command_keys): Doc fix.
6499
efc00ab1 65002012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
6501
6502 * search.c (search_buffer): Remove calls to
6503 r_alloc_inhibit_buffer_relocation, as it is now called by
6504 maybe_unify_char, which was the cause of relocation of buffer text
6505 in bug#11519.
6506
efc00ab1 65072012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
6508
6509 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
6510 for the duration of call to load_charset, to avoid problems with
6511 callers of maybe_unify_char that access buffer text through C
6512 pointers.
6513
6514 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
6515 decrement the inhibition flag, instead of just setting or
6516 resetting it.
6517
ba93a187
PE
65182012-05-31 Paul Eggert <eggert@cs.ucla.edu>
6519
6520 Remove obsolete '#define static' cruft.
6521 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
6522 This #undef was "temporary" in 2000; it is no longer needed
6523 now that '#define static' has gone away.
6524 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
6525 (gray_bitmap_bits): Remove; no longer needed.
6526 All uses replaced with definiens.
6527 * xterm.c: Include "bitmaps/gray.xbm".
6528
9e4bf381
PE
65292012-05-30 Paul Eggert <eggert@cs.ucla.edu>
6530
6531 Clean up __executable_start, monstartup when --enable-profiling.
6532 The following changes affect the code only when profiling.
6533 * dispnew.c (__executable_start): Rename from safe_bcopy.
6534 Define only on platforms that need it.
6535 * emacs.c: Include <sys/gmon.h> when profiling.
6536 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
6537 (__executable_start): Remove decl, since lisp.h does it now.
6538 (safe_bcopy): Remove decl; no longer has that name.
6539 (main): Coalesce #if into single bit of code, for simplicity.
6540 Cast pointers to uintptr_t, since standard libraries want integers
6541 and not pointers.
6542 * lisp.h (__executable_start): New decl.
6543
32d72c2f
GM
65442012-05-31 Glenn Morris <rgm@gnu.org>
6545
6546 * image.c (Fimagemagick_types): Doc fix.
6547
baac5bc7
JM
65482012-05-30 Jim Meyering <meyering@redhat.com>
6549
6550 * callproc.c (Fcall_process_region): Include directory component
6551 in mkstemp error message (Bug#11586).
6552
72cb32cf
PE
65532012-05-30 Paul Eggert <eggert@cs.ucla.edu>
6554
6555 * alloc.c, lisp.h (make_pure_vector): Now static.
6556
61b108cc
SM
65572012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
6558
6559 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
6560 Move to byte-run.el.
6561 (Fautoload): Do the hash-doc more carefully.
6562 * data.c (Fdefalias): Purify definition, except for keymaps.
6563 (Qdefun): Move from eval.c.
6564 * lisp.h (Qdefun): Remove.
6565 * lread.c (read1): Tiny simplification.
6566
471fe23d
TN
65672012-05-29 Troels Nielsen <bn.troels@gmail.com>
6568
934f3f58 6569 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
6570 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
6571 Bug#9642, but explicitly check that the buffer the overlay would
6572 be moved to is live and rearrange lines to make sure that errors
6573 will not put the overlay in an inconsistent state.
6574 (Fdelete_overlay): Cosmetics.
6575
85d0efd1
EZ
65762012-05-28 Eli Zaretskii <eliz@gnu.org>
6577
6578 * w32term.c (my_bring_window_to_top): New function.
6579 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
6580 could be different from the original one.
6581 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
6582 (Bug#11513)
6583
6584 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
6585 by calling BringWindowToTop.
6586
6587 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
6588 (WM_EMACS_END): Increase by one.
6589
da92a98c
PE
65902012-05-28 Paul Eggert <eggert@cs.ucla.edu>
6591
6592 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
6593 This avoids undefined behavior that might cause the eassert
6594 to not catch an out-of-range value.
6595
74d1f848
JB
65962012-05-28 Juanma Barranquero <lekktu@gmail.com>
6597
6598 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
6599 Update dependencies.
6600
9e1a06fc
EZ
66012012-05-27 Eli Zaretskii <eliz@gnu.org>
6602
6603 * bidi.c (bidi_mirror_char): Fix last change.
6604
f3dd7312
AS
66052012-05-27 Andreas Schwab <schwab@linux-m68k.org>
6606
6607 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
6608 when referring to sectname field in printf format.
6609
81899c91
PE
66102012-05-27 Paul Eggert <eggert@cs.ucla.edu>
6611
57b81a9f
PE
6612 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
6613 Only r_alloc_inhibit_buffer_relocation needed to be added;
6614 the others were already declared.
6615
81899c91
PE
6616 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
6617 before checking whether it's out of range. Put the check inside
6618 eassert. See
6619 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
6620
33017faf 66212012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
6622
6623 * callproc.c (Fcall_process): Restore a line that was accidentally
6624 commented out in the 2011-02-13 change (bug#11547).
6625
33017faf 66262012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
6627
6628 * lisp.h [REL_ALLOC]: Add prototypes for external functions
6629 defined on ralloc.c.
6630
6631 * buffer.c [REL_ALLOC]: Remove prototypes of
6632 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
6633 they are now on lisp.h.
6634
6635 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
6636
6637 * search.c (search_buffer): Use it to inhibit relocation of buffer
6638 text while re_search_2 is doing its job, because re_search_2 is
6639 passed C pointers to buffer text. (Bug#11519)
6640
23415acf
EZ
6641 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
6642 Update value to 24.
6643
44e27368
EZ
6644 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
6645 state after an additional call to move_it_in_display_line_to, keep
6646 the values of it->max_ascent and it->max_descent found for the
6647 entire line.
6648 (pos_visible_p): Revert the comparison against bottom_y to what it
6649 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
6650 (Bug#11464)
6651
c1892f11
PE
66522012-05-26 Paul Eggert <eggert@cs.ucla.edu>
6653
6654 Fix coding-related core dumps with gcc -ftrapv.
6655 The code was computing A - B, where A and B are pointers, and B is
6656 random garbage. This can lead to core dumps on platforms that
6657 have special pointer registers, and it also leads to core dumps on
6658 x86-64 when compiled with gcc -ftrapv. The fix is to compute
6659 A - B only when B is initialized properly.
6660 * coding.c (coding_set_source, coding_set_destination): Return void.
6661 (coding_change_source, coding_change_destinations): New functions,
6662 with the old behaviors of coding_set_source and coding_set_destination.
6663 All callers that need an offset changed to use these new functions.
6664
eb7afdad
GM
66652012-05-26 Glenn Morris <rgm@gnu.org>
6666
6667 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
6668
f12fdf02
EZ
66692012-05-26 Eli Zaretskii <eliz@gnu.org>
6670
53a63be6 6671 Extend mouse support on W32 text-mode console.
61b108cc
SM
6672 * xdisp.c (draw_row_with_mouse_face):
6673 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 6674
eb3f6f01 6675 * w32console.c: Include window.h.
61b108cc
SM
6676 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
6677 New functions.
eb3f6f01
EZ
6678 (initialize_w32_display): Initialize mouse-highlight data.
6679
53a63be6
EZ
6680 * w32inevt.c: Include termchar.h and window.h.
6681 (do_mouse_event): Support mouse-autoselect-window. When the mouse
6682 moves, call note_mouse_highlight. If help_echo changed, call
6683 gen_help_event to produce help-echo message in the echo area.
6684 Call clear_mouse_face if mouse_face_hidden is set in the mouse
6685 highlight info.
6686
4cfd81f6
PE
66872012-05-26 Paul Eggert <eggert@cs.ucla.edu>
6688
6689 * lread.c (read1): Simplify slightly to avoid an overflow warning
6690 with GCC 4.7.0 on x86-64.
6691
4446092a
EZ
66922012-05-26 Eli Zaretskii <eliz@gnu.org>
6693
6694 * bidi.c (bidi_mirror_char): Revert last change: an int is
6695 definitely wide enough here.
6696
42b2a986 66972012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 6698
42b2a986 6699 Fix integer width and related bugs (Bug#9874).
eb106a49 6700 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
6701 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6702 (string_bytes, check_sblock, allocate_string_data):
6703 (compact_small_strings, Fmake_bool_vector, make_string)
6704 (make_unibyte_string, make_multibyte_string)
6705 (make_string_from_bytes, make_specified_string)
6706 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
6707 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
6708 (mark_vectorlike):
6709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6710 (allocate_pseudovector):
6711 Use int, not EMACS_INT, where int is wide enough.
6712 (inhibit_garbage_collection, Fgarbage_collect):
6713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6714 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
6715 int might not be wide enough.
6716 (bidi_cache_search, bidi_cache_find, bidi_init_it)
6717 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
6718 (bidi_at_paragraph_end, bidi_find_paragraph_start)
6719 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6720 (bidi_level_of_next_char, bidi_move_to_visually_next):
6721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6722 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
6723 (Fkill_buffer, Fset_buffer_major_mode)
6724 (advance_to_char_boundary, Fbuffer_swap_text)
6725 (Fset_buffer_multibyte, overlays_at, overlays_in)
6726 (overlay_touches_p, struct sortvec, record_overlay_string)
6727 (overlay_strings, recenter_overlay_lists)
6728 (adjust_overlays_for_insert, adjust_overlays_for_delete)
6729 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
6730 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
6731 (Foverlay_recenter, last_overlay_modification_hooks_used)
6732 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
6733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
6734 (validate_region): Omit unnecessary test for b <= e,
6735 since that's guaranteed by the previous test.
d311d28c
PE
6736 (adjust_overlays_for_delete): Avoid pos + length overflow.
6737 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
6738 (report_overlay_modification):
6739 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6740 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
6741 Omit pointer cast, which isn't needed anyway, and doesn't work
6742 after the EMACS_INT -> ptrdiff_t change.
02481186 6743 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
6744 * buffer.h: Adjust decls to match defn changes elsewhere.
6745 (struct buffer_text, struct buffer):
6746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6747 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
6748 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
6749 not int, to avoid needless 32-bit limit on 64-bit hosts.
6750 (exec_byte_code): Use tighter memory-full test, one that checks
6751 for alloca overflow. Don't compute the address of the object just
6752 before an array, as that's not portable. Use EMACS_INT, not
6753 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
6754 * callint.c (Fcall_interactively):
6755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6756 * callproc.c (call_process_kill, Fcall_process):
6757 Don't assume pid_t fits into an Emacs fixnum.
6758 (call_process_cleanup, Fcall_process, child_setup):
6759 Don't assume pid_t fits into int.
6760 (call_process_cleanup, Fcall_process, delete_temp_file)
6761 (Fcall_process_region):
6762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6763 (Fcall_process): Simplify handling of volatile integers.
6764 Use int, not EMACS_INT, where int will do.
6765 * casefiddle.c (casify_object, casify_region, operate_on_word)
6766 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
6767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6768 (casify_object): Avoid integer overflow when overallocating buffer.
6769 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 6770 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
6771 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
6772 * category.h (CATEGORYP): Don't assume arg is nonnegative.
6773 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
6774 integers are now checked earlier. All uses replaced with XINT.
6775 (ccl_driver):
6776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6777 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
6778 (ccl_driver, Fregister_code_conversion_map):
6779 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
6780 (resolve_symbol_ccl_program): Check that vector header is in range.
6781 Always copy the vector, so that we can check its contents reliably
6782 now rather than having to recheck each instruction as it's being
6783 executed. Check that vector words fit in 'int'.
6784 (ccl_get_compiled_code, Fregister_ccl_program)
6785 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
6786 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
6787 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
6788 contents are in range.
6789 (Fccl_execute_on_string): Check that status is in range.
6790 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
6791 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
6792 Accept and return EMACS_INT, not int, because callers can pass values
6793 out of 'int' range.
6794 (c_string_width, strwidth, lisp_string_width, chars_in_text)
6795 (multibyte_chars_in_text, parse_str_as_multibyte)
6796 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
6797 (str_as_unibyte, str_to_unibyte, string_count_byte8)
6798 (string_escape_byte8, Fget_byte):
6799 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 6800 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
6801 avoid mishandling large integers.
6802 * character.h: Adjust decls to match defn changes elsewhere.
6803 * charset.c (load_charset_map_from_file, find_charsets_in_text)
6804 (Ffind_charset_region):
6805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6806 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
6807 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 6808 Don't assume fixnum fits in int.
d311d28c
PE
6809 (load_charset_map_from_vector, Fmap_charset_chars):
6810 Remove now-unnecessary CHECK_NATNUMs.
6811 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
6812 Don't rely on undefined behavior with signed left shift overflow.
6813 Don't assume unsigned int fits into fixnum, or that fixnum fits
6814 into unsigned int. Don't require max_code to be a valid fixnum;
6815 that's not true for gb10830 4-byte on a 32-bit host. Allow
6816 invalid_code to be a cons, for the same reason. Require code_offset
6817 to be a character. Avoid int overflow if max_char is close
6818 to INT_MAX.
6819 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
6820 this is intended anyway and avoids some undefined behavior.
6821 (load_charset_map): Pass unsigned, not int, as 2nd arg of
6822 INDEX_TO_CODE_POINT, as that's what it expects.
6823 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
6824 * charset.h (DECODE_CHAR): Return int, not unsigned;
6825 this is what was intended anyway, and it avoids undefined behavior.
6826 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
6827 integer-overflow issues.
6828 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
6829 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
6830 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
6831 * chartab.c (Fmake_char_table, Fset_char_table_range)
6832 (uniprop_get_decoder, uniprop_get_encoder):
6833 Don't assume fixnum fits in int.
6834 * cmds.c (move_point): New function, that does the gist of
6835 Fforward_char and Fbackward_char, but does so while checking
6836 for integer overflow more accurately.
c96e5d6a 6837 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
6838 (Fforward_line, Fend_of_line, internal_self_insert)
6839 (internal_self_insert):
6840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6841 Fix a FIXME, by checking for integer overflow when calculating
6842 target_clm and actual_clm.
6843 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 6844 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
6845 (ASSURE_DESTINATION, coding_alloc_by_realloc)
6846 (coding_alloc_by_making_gap, alloc_destination)
6847 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
6848 (encode_coding_utf_16, detect_coding_emacs_mule)
6849 (decode_coding_emacs_mule, encode_coding_emacs_mule)
6850 (detect_coding_iso_2022, decode_coding_iso_2022)
6851 (encode_invocation_designation, encode_designation_at_bol)
6852 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6853 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
6854 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
6855 (encode_coding_ccl, encode_coding_raw_text)
6856 (detect_coding_charset, decode_coding_charset)
6857 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
6858 (produce_composition, produce_charset, produce_annotation)
6859 (decode_coding, handle_composition_annotation)
6860 (handle_charset_annotation, consume_chars, decode_coding_gap)
6861 (decode_coding_object, encode_coding_object, detect_coding_system)
6862 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
6863 (code_convert_region, code_convert_string)
8f50130c
PE
6864 (Fdefine_coding_system_internal)
6865 (coding_set_source, coding_set_destination):
d311d28c
PE
6866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6867 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
6868 (Fdefine_coding_system_internal):
6869 Don't assume fixnums fit in int.
6870 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 6871 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
6872 (Funencodable_char_position, Fcheck_coding_systems_region)
6873 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 6874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 6875 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 6876 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 6877 Don't access memory outside of the args array.
d311d28c 6878 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
6879 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
6880 result of ENCODE_CHAR.
d311d28c
PE
6881 * coding.h: Adjust decls to match defn changes elsewhere.
6882 (struct coding_system):
6883 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6884 * composite.c (get_composition_id, find_composition)
6885 (run_composition_function, update_compositions)
6886 (compose_text, composition_gstring_put_cache)
6887 (composition_gstring_p, composition_gstring_width)
6888 (fill_gstring_header, fill_gstring_body, autocmp_chars)
6889 (composition_compute_stop_pos, composition_reseat_it)
6890 (composition_update_it, struct position_record)
6891 (find_automatic_composition, composition_adjust_point)
6892 (Fcomposition_get_gstring, Ffind_composition_internal):
6893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6894 (update_compositions):
6895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6896 * composite.h: Adjust decls to match defn changes elsewhere.
6897 (struct composition):
6898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6899 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
6900 Do not attempt to compute the address of the object just before a
6901 buffer; this is not portable.
6902 (Faref, Faset):
6903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6904 (Faset): Use int, not EMACS_INT, where int is wide enough.
6905 (Fstring_to_number): Don't assume fixnums fit in int.
6906 (Frem): Don't assume arg is nonnegative.
6907 * dbusbind.c (xd_append_arg): Check for integers out of range.
6908 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 6909 (extract_signed, extract_unsigned): New functions.
243e0530
PE
6910 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
6911 (xd_get_connection_references): Return ptrdiff_t, not int.
6912 All uses changed.
6913 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
6914 (xd_read_message_1):
6915 Use int, not unsigned, where the dbus API uses int.
6916 (Fdbus_message_internal): Don't overflow mtype.
6917 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
6918 * dired.c (directory_files_internal, file_name_completion, scmp)
6919 (file_name_completion_stat):
6920 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6921 (file_name_completion): Don't overflow matchcount.
6922 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
6923 * dispextern.h: Adjust decls to match defn changes elsewhere.
6924 (struct text_pos, struct glyph, struct bidi_saved_info)
6925 (struct bidi_string_data, struct bidi_it, struct composition_it)
6926 (struct it):
6927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6928 (struct display_pos, struct composition_it, struct it):
6929 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6930 * dispnew.c (increment_matrix_positions)
6931 (increment_row_positions, mode_line_string)
6932 (marginal_area_string):
6933 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 6934 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
6935 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6936 (duration_to_sec_usec): New function, to check for overflow better.
6937 (Fsleep_for, sit_for): Use it.
6938 * doc.c (get_doc_string, store_function_docstring):
6939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6940 (get_doc_string, Fsnarf_documentation):
6941 Use int, not EMACS_INT, where int is wide enough.
6942 (get_doc_string):
6943 Use SAFE_ALLOCA, not alloca.
6944 Check for overflow when converting EMACS_INT to off_t.
6945 * doprnt.c (doprnt):
6946 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6947 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
6948 Don't assume uid_t fits into fixnum.
6949 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
6950 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
6951 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
6952 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
6953 (general_insert_function)
6954 (Finsert_char, make_buffer_string, make_buffer_string_both)
6955 (update_buffer_properties, Fbuffer_substring)
6956 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
6957 (Fsubst_char_in_region, check_translation)
6958 (Ftranslate_region_internal, save_restriction_restore, Fformat)
6959 (transpose_markers, Ftranspose_regions):
6960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6961 (clip_to_bounds): Move to lisp.h as an inline function).
6962 (Fconstrain_to_field): Don't assume integers are nonnegative.
6963 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
6964 (Fsubst_char_in_region, Fsave_restriction):
6965 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6966 (Femacs_pid): Don't assume pid_t fits into fixnum.
6967 (lo_time): Use int, not EMACS_INT, when int suffices.
6968 (lisp_time_argument): Check for usec out of range.
6969 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
6970 (Fuser_login_name, Fuser_full_name): Signal an error
6971 if a uid argument is out of range, rather than relying on
6972 undefined behavior.
c8d5c857
PE
6973 (Fformat_time_string): Remove now-unnecessary check.
6974 lisp_time_argument checks for out-of-range usec now.
243e0530 6975 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
6976 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
6977 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
6978 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
6979 (init_cmdargs, Fdump_emacs):
6980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6981 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
6982 the bottom (typically) 32 bits of the fixnum.
6983 * eval.c (specpdl_size, call_debugger):
6984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6985 (when_entered_debugger, Fbacktrace_debug):
6986 Don't assume fixnum can fit in int.
6987 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
6988 the object just before a buffer; this is not portable.
6989 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
6990 (grow_specpdl, unbind_to):
6991 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6992 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
6993 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 6994 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
6995 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
6996 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
6997 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6998 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
6999 (a_write, e_write):
7000 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7001 (Fcopy_file, non_regular_nbytes, read_non_regular)
7002 (Finsert_file_contents):
7003 Use int, not EMACS_INT, where int is wide enough.
7004 (READ_BUF_SIZE): Verify that it fits in int.
7005 (Finsert_file_contents): Check that counts are in proper range,
7006 rather than assuming fixnums fit into ptrdiff_t etc.
7007 Don't assume fixnums fit into int.
125b3835 7008 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
7009 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
7010 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
7011 (string_char_to_byte, string_byte_to_char)
7012 (string_make_multibyte, string_to_multibyte)
7013 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
7014 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
7015 (substring_both, Fdelete, internal_equal, Ffillarray)
7016 (Fclear_string, mapcar1)
7017 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
7018 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
7019 (larger_vector, make_hash_table, maybe_resize_hash_table)
7020 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
7021 (Fmaphash, secure_hash):
7022 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7023 (concat): Check for string index and length overflow.
7024 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
7025 (Frequire):
7026 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7027 (larger_vector): New API (vec, incr_min, size_max) replaces old
7028 one (vec, new_size, init). This catches size overflow.
7029 INIT was removed because it was always Qnil.
7030 All callers changed.
7031 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
7032 the upper bound on a hash table index size.
7033 (make_hash_table, maybe_resize_hash_table): Use it.
7034 (secure_hash): Computer start_byte and end_byte only after
7035 they're known to be in ptrdiff_t range.
7036 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
7037 (Ffont_get_glyphs, Ffont_at):
7038 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7039 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
7040 (Flist_fonts, Fopen_font):
7041 Don't assume fixnum can fit in int.
7042 (check_gstring): Don't assume index can fit in int.
7043 (font_match_p): Check that fixnum is a character, not a nonnegative
7044 fixnum, since the later code needs to stuff it into an int.
7045 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
7046 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
7047 conversion overflow issues.
7048 (Fopen_font): Check for integer out of range.
7049 (Ffont_get_glyphs): Don't assume index can fit in int.
7050 * font.h: Adjust decls to match defn changes elsewhere.
7051 * fontset.c (reorder_font_vector): Redo score calculation to avoid
7052 integer overflow.
7053 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
7054 printmax_t, where ptrdiff_t is wide enough.
7055 (Finternal_char_font):
7056 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7057 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
7058 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
7059 (Fset_frame_position, x_set_frame_parameters)
7060 (x_set_line_spacing, x_set_border_width)
7061 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
7062 Check that fixnums are in proper range for system types.
7063 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
7064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7065 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
7066 Use SAFE_ALLOCA_LISP, not alloca.
7067 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
7068 intptr_t is wide enough.
7069 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
7070 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
7071 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
7072 Check for fixnum out of range.
7073 * ftfont.c (ftfont_list): Don't assume index fits in int.
7074 Check that fixnums are in proper range for system types.
7075 (ftfont_shape_by_flt):
7076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
7077 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7079 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
7080 Check that fixnums are in proper range for system types.
7081 * gnutls.h: Adjust decls to match defn changes elsewhere.
7082 * gtkutil.c (xg_dialog_run):
7083 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7084 (update_frame_tool_bar):
7085 Check that fixnums are in proper range for system types.
7086 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 7087 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
7088 * indent.c (last_known_column, last_known_column_point):
7089 (current_column_bol_cache):
7090 (skip_invisible, current_column, check_display_width):
7091 (check_display_width, scan_for_column, current_column_1)
7092 (Findent_to, Fcurrent_indentation, position_indentation)
7093 (indented_beyond_p, Fmove_to_column, compute_motion):
7094 (Fcompute_motion, Fvertical_motion):
7095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7096 (last_known_column_modified): Use EMACS_INT, not int.
7097 (check_display_width):
7098 (Fcompute_motion):
7099 Check that fixnums and floats are in proper range for system types.
7100 (compute_motion): Don't assume index or fixnum fits in int.
7101 (compute_motion, Fcompute_motion):
7102 Use int, not EMACS_INT, when it is wide enough.
7103 (vmotion): Omit local var start_hpos that is always 0; that way
7104 we don't need to worry about overflow in expressions involving it.
7105 * indent.h: Adjust decls to match defn changes elsewhere.
7106 (struct position):
7107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7108 Use int, not EMACS_INT, where int is wide enough.
7109 Remove unused members ovstring_chars_done and tab_offset;
7110 all uses removed.
7111 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
7112 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
7113 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
7114 (make_gap, copy_text, insert, insert_and_inherit)
7115 (insert_before_markers, insert_before_markers_and_inherit)
7116 (insert_1, count_combining_before, count_combining_after)
7117 (insert_1_both, insert_from_string)
7118 (insert_from_string_before_markers, insert_from_string_1)
7119 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
7120 (adjust_after_replace, adjust_after_insert, replace_range)
7121 (replace_range_2, del_range, del_range_1, del_range_byte)
7122 (del_range_both, del_range_2, modify_region)
7123 (prepare_to_modify_buffer, signal_before_change)
7124 (signal_after_change, Fcombine_after_change_execute):
7125 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7126 * intervals.c (traverse_intervals, rotate_right, rotate_left)
7127 (balance_an_interval, split_interval_right, split_interval_left)
7128 (find_interval, next_interval, update_interval)
7129 (adjust_intervals_for_insertion, delete_node, delete_interval)
7130 (interval_deletion_adjustment, adjust_intervals_for_deletion)
7131 (static_offset_intervals, offset_intervals)
7132 (merge_interval_right, merge_interval_left, make_new_interval)
7133 (graft_intervals_into_buffer, temp_set_point_both)
7134 (temp_set_point, set_point, adjust_for_invis_intang)
7135 (set_point_both, move_if_not_intangible, get_property_and_range)
7136 (get_local_map, copy_intervals, copy_intervals_to_string)
7137 (compare_string_intervals, set_intervals_multibyte_1):
7138 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7139 * intervals.h: Adjust decls to match defn changes elsewhere.
7140 (struct interval):
7141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7142 * keyboard.c (this_command_key_count, this_single_command_key_start)
7143 (before_command_key_count, before_command_echo_length, echo_now)
7144 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
7145 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
7146 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
7147 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
7148 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7149 (last_non_minibuf_size, last_point_position, echo_truncate)
7150 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
7151 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
7152 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
7153 (stuff_buffered_input):
7154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7155 (last_auto_save, command_loop_1, read_char):
7156 Use EMACS_INT, not int, to avoid integer overflow.
7157 (record_char): Avoid overflow in total_keys computation.
7158 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
7159 * keyboard.h: Adjust decls to match defn changes elsewhere.
7160 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
7161 (Fkey_description, Fdescribe_vector, Flookup_key):
7162 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7163 (click_position): New function, to check that positions are in range.
7164 (Fcurrent_active_maps):
7165 (describe_command):
7166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7167 (Faccessible_keymaps, Fkey_description):
7168 (preferred_sequence_p):
7169 Don't assume fixnum can fit into int.
7170 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
7171 Check for integer overflow in size calculations.
7172 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
7173 avoid mishandling large integers.
7174 * lisp.h: Adjust decls to match defn changes elsewhere.
7175 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
7176 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
7177 (struct Lisp_Marker):
7178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7179 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
7180 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
7181 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
7182 All callers changed.
7183 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
7184 Assume the arg has valid form, since it always does.
7185 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
7186 unsigned integer system type.
7187 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
7188 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
7189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7190 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
7191 (duration_to_sec_usec): New decl.
7192 * lread.c (read_from_string_index, read_from_string_index_byte)
7193 (read_from_string_limit, readchar, unreadchar, openp)
7194 (read_internal_start, read1, oblookup):
7195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7196 (Fload, readevalloop, Feval_buffer, Feval_region):
7197 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7198 (openp): Check for out-of-range argument to 'access'.
7199 (read1): Use int, not EMACS_INT, where int is wide enough.
7200 Don't assume fixnum fits into int.
6efdadfd 7201 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
7202 (read_filtered_event): Use duration_to_sec_usec
7203 to do proper overflow checking on durations.
d311d28c
PE
7204 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
7205 in size calculation.
7206 (Fexecute_kbd_macro):
7207 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7208 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
7209 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
7210 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
7211 (set_marker_both, set_marker_restricted_both, marker_position)
7212 (marker_byte_position, Fbuffer_has_markers_at):
7213 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7214 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 7215 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
7216 It now merely ensures that the menu is large enough, without
7217 necessarily growing it, as this avoids some integer overflow issues.
7218 All callers changed.
7219 (keymap_panes, parse_single_submenu, Fx_popup_menu):
7220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7221 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
7222 Use SAFE_ALLOCA_LISP, not alloca.
7223 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
7224 to EMACS_INT. Check that fixnums are in proper range for system types.
7225 * minibuf.c (minibuf_prompt_width, string_to_object)
7226 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
7227 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
7228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7229 (get_minibuffer, read_minibuf_unwind):
7230 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7231 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
7232 this simplifies overflow checking. All callers changed.
7233 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
7234 (Ftest_completion):
7235 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7236 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
7237 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
7238 Check that fixnums are in proper range for system types.
7239 (Fx_create_frame, Fx_show_tip):
7240 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7241 * nsfont.m (ns_findfonts, nsfont_list_family):
7242 Don't assume fixnum fits in long.
7243 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
7244 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7245 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
7246 wide enough.
17fdb222 7247 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
7248 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7249 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
7250 (PRINTDECLARE, PRINTPREPARE):
7251 (strout, print_string):
7252 (print, print_preprocess, print_check_string_charset_prop)
7253 (print_object):
7254 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7255 (PRINTDECLARE):
7256 (temp_output_buffer_setup, Fprin1_to_string, print_object):
7257 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7258 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 7259 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 7260 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
7261 (print_error_message): Use SAFE_ALLOCA, not alloca.
7262 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
7263 (print_depth, new_backquote_output, print_number_index):
7264 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
7265 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
7266 (Fset_process_window_size, Fformat_network_address)
7267 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 7268 (sigchld_handler):
d311d28c 7269 Check that fixnums are in proper range for system types.
d44287d4 7270 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
7271 Check for process-ids out of pid_t range rather than relying on
7272 undefined behavior.
e4d81efc 7273 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
7274 (Fformat_network_address, read_process_output, send_process)
7275 (Fprocess_send_region, status_notify):
7276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7277 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
7278 (wait_reading_process_output, read_process_output, exec_sentinel):
7279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7280 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
7281 (Faccept_process_output): Use duration_to_sec_usec to do proper
7282 overflow checking on durations.
dde14581
PE
7283 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
7284 Don't assume pid_t fits in int.
02481186
PE
7285 * process.h (struct Lisp_Process): Members tick and update_tick
7286 are now of type EMACS_INT, not int.
b62b53e8
PE
7287 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
7288 configured --with-wide-int.
d311d28c
PE
7289 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
7290 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
7291 * search.c (looking_at_1, string_match_1):
7292 (fast_string_match, fast_c_string_match_ignore_case)
7293 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
7294 (scan_newline, find_before_next_newline, search_command)
7295 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
7296 (set_search_regs, wordify):
7297 (Freplace_match):
7298 (Fmatch_data):
7299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7300 (string_match_1, search_buffer, set_search_regs):
7301 (Fmatch_data):
7302 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7303 (wordify): Check for overflow in size calculation.
7304 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
7305 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
7306 Check that fixnums are in proper range for system types.
7307 * sound.c (struct sound_device)
7308 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
7309 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7310 (Fplay_sound_internal):
7311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 7312 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
7313 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
7314 (Fparse_partial_sexp):
7315 Don't assume fixnums can fit in int.
7316 (struct lisp_parse_state, find_start_pos, find_start_value)
7317 (find_start_value_byte, find_start_begv)
7318 (update_syntax_table, char_quoted, dec_bytepos)
7319 (find_defun_start, prev_char_comend_first, back_comment):
7320 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
7321 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
7322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7323 (Finternal_describe_syntax_value): Check that match_lisp is a
7324 character, not an integer, since the code stuffs it into int.
7325 (scan_words, scan_sexps_forward):
7326 Check that fixnums are in proper range for system types.
7327 (Fforward_word):
7328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7329 (scan_sexps_forward):
7330 Use CHARACTERP, not INTEGERP, since the value must fit into int.
7331 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
7332 * syntax.h: Adjust decls to match defn changes elsewhere.
7333 (struct gl_state_s):
7334 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
7335 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
7336 MOST_POSITIVE_FIXNUM.
d311d28c
PE
7337 * sysdep.c (wait_for_termination_1, wait_for_termination)
7338 (interruptible_wait_for_termination, mkdir):
7339 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
7340 (emacs_read, emacs_write):
7341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
7342 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
7343 and double all fit in int.
d311d28c
PE
7344 * term.c (set_tty_color_mode):
7345 Check that fixnums are in proper range for system types.
7346 * termhooks.h (struct input_event):
7347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7348 * textprop.c (validate_interval_range, interval_of)
7349 (Fadd_text_properties, set_text_properties_1)
7350 (Fremove_text_properties, Fremove_list_of_text_properties)
7351 (Ftext_property_any, Ftext_property_not_all)
7352 (copy_text_properties, text_property_list, extend_property_ranges)
7353 (verify_interval_modification):
7354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7355 (Fnext_single_char_property_change)
7356 (Fprevious_single_char_property_change):
7357 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
7358 (copy_text_properties):
7359 Check for integer overflow in index calculation.
d311d28c
PE
7360 * undo.c (last_boundary_position, record_point, record_insert)
7361 (record_delete, record_marker_adjustment, record_change)
7362 (record_property_change):
7363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7364 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
7365 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7366 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
7367 (Fx_hide_tip, Fx_file_dialog):
7368 * w32menu.c (set_frame_menubar):
7369 Use ptrdiff_t, not int, for consistency with rest of code.
7370 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
7371 (select_window, Fdelete_other_windows_internal)
7372 (window_scroll_pixel_based, window_scroll_line_based)
7373 (Frecenter, Fset_window_configuration):
7374 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7375 (Fset_window_hscroll, run_window_configuration_change_hook)
7376 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 7377 (Fscroll_other_window, Frecenter):
d311d28c
PE
7378 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7379 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
7380 Don't assume fixnum fits in int.
7381 (Fset_window_scroll_bars):
7382 Check that fixnums are in proper range for system types.
7383 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
7384 (string_pos, c_string_pos, number_of_chars, init_iterator)
7385 (in_ellipses_for_invisible_text_p, init_from_display_pos)
7386 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
7387 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
7388 (face_before_or_after_it_pos, handle_invisible_prop)
7389 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
7390 (display_prop_intangible_p, string_buffer_position_lim)
7391 (string_buffer_position, handle_composition_prop, load_overlay_strings)
7392 (get_overlay_strings_1, get_overlay_strings)
7393 (iterate_out_of_display_property, forward_to_next_line_start)
7394 (back_to_previous_visible_line_start, reseat, reseat_to_string)
7395 (get_next_display_element, set_iterator_to_next)
7396 (get_visually_first_element, compute_stop_pos_backwards)
7397 (handle_stop_backwards, next_element_from_buffer)
7398 (move_it_in_display_line_to, move_it_in_display_line)
7399 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7400 (add_to_log, message_dolog, message_log_check_duplicate)
7401 (message2, message2_nolog, message3, message3_nolog
7402 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
7403 (current_message_1, truncate_echo_area, truncate_message_1)
7404 (set_message, set_message_1, store_mode_line_noprop)
7405 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
7406 (text_outside_line_unchanged_p, check_point_in_composition)
7407 (reconsider_clip_changes)
7408 (redisplay_internal, set_cursor_from_row, try_scrolling)
7409 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
7410 (redisplay_window, find_last_unchanged_at_beg_row)
7411 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
7412 (trailing_whitespace_p, find_row_edges, display_line)
7413 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
7414 (display_mode_element, store_mode_line_string)
7415 (pint2str, pint2hrstr, decode_mode_spec)
7416 (display_count_lines, display_string, draw_glyphs)
7417 (x_produce_glyphs, x_insert_glyphs)
7418 (rows_from_pos_range, mouse_face_from_buffer_pos)
7419 (fast_find_string_pos, mouse_face_from_string_pos)
7420 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7422 (safe_call, init_from_display_pos, handle_fontified_prop)
7423 (handle_single_display_spec, load_overlay_strings)
7424 (with_echo_area_buffer, setup_echo_area_for_printing)
7425 (display_echo_area, echo_area_display)
7426 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
7427 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
7428 (redisplay_window, dump_glyph_row, display_mode_line)
7429 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 7430 (handle_display_spec, display_prop_string_p):
d311d28c
PE
7431 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7432 (handle_single_display_spec, build_desired_tool_bar_string)
7433 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
7434 (get_specified_cursor_type):
7435 Check that fixnums are in proper range for system types.
7436 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
7437 (Flookup_image_map):
7438 Don't assume fixnums fit in int.
7439 (compare_overlay_entries):
7440 Avoid mishandling comparisons due to subtraction overflow.
7441 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
7442 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
7443 (handle_tool_bar_click):
7444 Use int, not unsigned, since we prefer signed and the signedness
7445 doesn't matter here.
7446 (get_next_display_element, next_element_from_display_vector):
7447 Use int, not EMACS_INT, when int is wide enough.
7448 (start_hourglass): Use duration_to_sec_usec to do proper
7449 overflow checking on durations.
7450 * xfaces.c (Fbitmap_spec_p):
7451 Check that fixnums are in proper range for system types.
7452 (compare_fonts_by_sort_order):
7453 Avoid mishandling comparisons due to subtraction overflow.
7454 (Fx_family_fonts, realize_basic_faces):
7455 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7456 (Fx_family_fonts):
7457 Don't assume fixnum fits in int.
7458 Use SAFE_ALLOCA_LISP, not alloca.
7459 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
7460 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
7461 (face_at_buffer_position, face_for_overlay_string)
7462 (face_at_string_position):
7463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7464 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
7465 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
7466 (Fx_show_tip):
7467 Check that fixnums are in proper range for system types.
7468 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
7469 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
7470 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7471 (Fx_change_window_property): Don't assume fixnums fit in int.
7472 * xfont.c (xfont_chars_supported):
7473 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7474 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
7475 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
7476 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7477 * xml.c (parse_region):
7478 * xrdb.c (magic_file_p):
7479 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7480 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
7481 (x_get_local_selection, x_reply_selection_request)
7482 (x_handle_selection_request, wait_for_property_change):
7483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7484 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
7485 short is wide enough.
7486 (x_send_client_event): Don't assume fixnum fits in int.
7487 * xterm.c (x_x_to_emacs_modifiers):
7488 Don't assume EMACS_INT overflows nicely into int.
7489 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
7490 may come from Lisp.
7491 (handle_one_xevent): NATNUMP can eval its arg twice.
7492 (x_connection_closed):
7493 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7494 * xterm.h: Adjust decls to match defn changes elsewhere.
7495 (struct scroll_bar): Use struct vectorlike_header
7496 rather than rolling our own approximation.
7497 (SCROLL_BAR_VEC_SIZE): Remove; not used.
7498
c6574eb5
GM
74992012-05-25 Glenn Morris <rgm@gnu.org>
7500
7501 * lisp.mk (lisp): Update for more files being compiled now.
7502
e8d32c7e
SM
75032012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
7504
48def666
SM
7505 * lread.c: Remove `read_pure' which makes no difference.
7506 (read_pure): Remove var.
7507 (unreadpure): Remove function.
7508 (readevalloop): Don't call read_list with -1 flag.
7509 (read1, read_vector): Don't test read_pure any more.
7510 (read_list): Simplify.
7511
e8d32c7e
SM
7512 * fileio.c, character.h: Minor style tweaks.
7513
4b2addb7
DA
75142012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
7515
7516 * window.h (clip_changed): Remove useless declaration.
7517
584461b2
JB
75182012-05-22 Juanma Barranquero <lekktu@gmail.com>
7519
7520 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
7521 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
7522
34374650
PE
75232012-05-22 Paul Eggert <eggert@cs.ucla.edu>
7524
7525 Remove src/m/*.
7526 This directory predates autoconf and is no longer needed nowadays.
7527 Move its few remaining bits of functionality to where they're needed.
7528 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
7529 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
7530 * m/template.h: Remove.
7531 * Makefile.in (M_FILE): Remove. All uses removed.
7532 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
7533 * lisp.h (USE_LSB_TAG):
7534 * mem-limits.h (EXCEEDS_LISP_PTR):
7535 Use VAL_MAX, not VALBITS, in #if.
7536 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
7537 (EMACS_UINT): Define unconditionally now.
7538 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
7539 (BITS_PER_EMACS_INT): New constants, replacing
7540 what used to be in config.h, but not useful in #if.
7541 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
7542 define them any more.
7543 (VAL_MAX): New macro.
7544 (VALMASK): Use it.
7545 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
7546 BITS_PER_EMACS_INT, in #if.
7547 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
7548 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
7549 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
7550 * s/ms-w32.h (DATA_START):
7551 Move here from removed file m/intel386.h.
7552 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
7553 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
7554
261cb4bb
PE
75552012-05-21 Paul Eggert <eggert@cs.ucla.edu>
7556
7557 Assume C89 or later.
7558 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
7559 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
7560 (xrealloc):
7561 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
7562 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
7563 * textprop.c, tparam.c (NULL): Remove.
7564 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
7565 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
7566 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
7567 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
7568 * xterm.c (input_signal_count): Assume volatile works.
7569
ff23cd9f
KB
75702012-05-21 Ken Brown <kbrown@cornell.edu>
7571
7572 * xgselect.c (xg_select): Fix first argument in call to 'select'
7573 (bug#11508).
7574
1b170bc6
KB
75752012-05-20 Ken Brown <kbrown@cornell.edu>
7576
7577 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 7578 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 7579
b2f4d39f
KB
75802012-05-19 Ken Brown <kbrown@cornell.edu>
7581
7582 * xfns.c (x_in_use): Remove `static' qualifier.
7583 * xterm.h (x_in_use): Declare.
7584 * xgselect.c: Include xterm.h.
7585 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
7586 and `display_arg' (bug#9754).
7587
003fdae2
PE
75882012-05-19 Paul Eggert <eggert@cs.ucla.edu>
7589
9232a6d9
PE
7590 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
7591
003fdae2
PE
7592 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
7593 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
7594
784b56e2
EZ
75952012-05-18 Eli Zaretskii <eliz@gnu.org>
7596
7597 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
7598
7599 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 7600 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
7601
7602 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
7603 reference to image_cache->refcount.
7604 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
7605
a0a79cde
JL
76062012-05-17 Juri Linkov <juri@jurta.org>
7607
7608 * search.c (Fword_search_regexp, Fword_search_backward)
7609 (Fword_search_forward, Fword_search_backward_lax)
7610 (Fword_search_forward_lax): Move functions to isearch.el
7611 (bug#10145, bug#11381).
7612
b0572523
PE
76132012-05-16 Paul Eggert <eggert@cs.ucla.edu>
7614
7615 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
7616
9660f5fc
SM
76172012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
7618
7619 * lread.c (init_obarray): Declare Qt and Qnil as special.
7620
4374de83
GM
76212012-05-14 Glenn Morris <rgm@gnu.org>
7622
7623 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 7624 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 7625
dc44c39a
PE
76262012-05-14 Paul Eggert <eggert@cs.ucla.edu>
7627
078c97cb
PE
7628 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
7629
dc44c39a
PE
7630 * unexaix.c: Port to more-recent AIX compilers.
7631 (report_error, report_error_1, make_hdr, copy_sym)
7632 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
7633 Make arguments const char *, not char *, to avoid violations of C
7634 standard and to fix some AIX warnings reported by Gilles Pion.
7635
e18afed7 76362012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
7637
7638 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
7639 already have overlays loaded.
7640 (handle_single_display_spec): Before returning without displaying
7641 fringe bitmap, synchronize the bidi iterator with the main display
7642 iterator, by calling iterate_out_of_display_property.
7643 (iterate_out_of_display_property): Detect buffer iteration by
7644 testing that it->string is a Lisp string.
7645 (get_next_display_element): When the current object is exhausted,
7646 and there's something on it->stack, call set_iterator_to_next to
7647 proceed with what's on the stack, instead of returning zero.
7648 (set_iterator_to_next): If called at the end of a Lisp string,
7649 proceed to consider_string_end without incrementing string
7650 position. Don't increment display vector index past the end of
7651 the display vector. (Bug#11417)
c8fb9dc6
EZ
7652 (pos_visible_p): Don't report a position visible when move_it_to
7653 stopped at the last line of window, which happens to be scanned
7654 backwards by the bidi iteration. (Bug#11464)
ac268e67 7655
e18afed7 76562012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
7657
7658 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
7659 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
7660 are on a TTY, and thus unable to display on the fringes.
7661 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
7662 so we need to signal to the caller that this is a "replacing"
7663 display spec. This fixes display when the spec is invalid or we
7664 are on a TTY.
7665
e18afed7 76662012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
7667
7668 * unexaix.c (make_hdr): Fix typo in prototype.
7669 This bug broke the build on AIX. Problem reported by Gilles Pion.
7670
9d0a235a
MA
76712012-05-14 Michael Albinus <michael.albinus@gmx.de>
7672
7673 * keyboard.c (kbd_buffer_get_event): Read special events also in
7674 batch mode. (Bug#11415)
7675
9e6b06ed
GM
76762012-05-12 Glenn Morris <rgm@gnu.org>
7677
7678 * ns.mk: Update for ns_appbindir no longer having trailing "/".
7679
c1a1d7a3
EZ
76802012-05-12 Eli Zaretskii <eliz@gnu.org>
7681
7682 * lisp.mk (lisp): Add newcomment.elc.
7683
3fe7cdc8
GM
76842012-05-12 Glenn Morris <rgm@gnu.org>
7685
7686 * Makefile.in (MKDIR_P): New, set by configure.
7687 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
7688
53f7d2c0
PE
76892012-05-11 Paul Eggert <eggert@cs.ucla.edu>
7690
7691 Remove unused function hourglass_started.
7692 * dispextern.h (hourglass_started):
7693 * w32fns.c (hourglass_started):
7694 * xdisp.c (hourglass_started): Remove.
7695
75aafb17
JB
76962012-05-10 Juanma Barranquero <lekktu@gmail.com>
7697
7698 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
7699 Update dependencies.
7700
12959e8e
PE
77012012-05-10 Paul Eggert <eggert@cs.ucla.edu>
7702
97107e2e
PE
7703 * xgselect.c (xg_select): Put maxfds+1 into a var.
7704 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
7705
12959e8e
PE
7706 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
7707
836d29b3
DA
77082012-05-10 Dave Abrahams <dave@boostpro.com>
7709
7710 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
7711 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
7712
5cb67954
MA
77132012-05-09 Michael Albinus <michael.albinus@gmx.de>
7714
7715 * dbusbind.c (xd_registered_buses): New internal Lisp object.
7716 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
7717 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
7718 Initialize xd_registered_buses.
7719
3478ec45
PE
77202012-05-09 Paul Eggert <eggert@cs.ucla.edu>
7721
b263a6b0
PE
7722 Untag more efficiently if USE_LSB_TAG.
7723 This is based on a proposal by YAMAMOTO Mitsuharu in
7724 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
7725 For an admittedly artificial (nth 8000 longlist) benchmark on
7726 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
7727 Emacs's overall text size by 1%.
7728 * lisp.h (XUNTAG): New macro.
7729 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
7730 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
7731 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
7732 * eval.c (Fautoload):
7733 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
7734 * frame.h (XFRAME): Use XUNTAG.
7735
3478ec45
PE
7736 Port recent dbusbind.c changes to 32-bit --with-wide-int.
7737 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
7738 Remove unportable assumptions about print widths of types like
7739 dbus_uint32_t.
7740 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
7741 intptr_t when converting between pointer and integer, to avoid GCC
7742 warnings about wrong width.
7743
666b903b 77442012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
7745
7746 * w32proc.c (new_child): Force Windows to reserve only 64KB of
7747 stack for each reader_thread, instead of defaulting to 8MB
7748 determined by the linker. This avoids failures in creating
7749 subprocesses on Windows 7, see the discussion in this thread:
7750 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
7751
b120cc17
JC
77522012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
7753
7754 Fix up display of the *Minibuf-0* buffer in the mini window.
7755 * keyboard.c (read_char): Don't clear the echo area if there's no
7756 message to clear.
7757 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 7758 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 7759
9a4b36f8
MA
77602012-05-07 Michael Albinus <michael.albinus@gmx.de>
7761
7762 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
7763 batch mode.
7764
e5f9458f
CY
77652012-05-06 Chong Yidong <cyd@gnu.org>
7766
7767 * lisp.mk (lisp): Update.
7768
eceeb5fc 77692012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
7770
7771 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
7772
71873e2b
SM
77732012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
7774
7775 * data.c (PUT_ERROR): New macro.
7776 (syms_of_data): Use it. Add new error type `user-error'.
7777 * undo.c (user_error): New function.
7778 (Fprimitive_undo): Use it.
7779 * print.c (print_error_message): Adjust print style for `user-error'.
7780 * keyboard.c (user_error): New function.
7781 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
7782
ab0fa4e4
PE
77832012-05-03 Paul Eggert <eggert@cs.ucla.edu>
7784
7785 Do not limit current-time-string to years 1000..9999.
7786 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
7787 (Fcurrent_time_string): Support any year that is supported by the
7788 underlying localtime representation. Don't use asctime, as it
7789 has undefined behavior for years outside the range -999..9999.
7790
7ed806a7
PE
77912012-05-02 Paul Eggert <eggert@cs.ucla.edu>
7792
7793 Fix race conditions involving setenv, gmtime, localtime, asctime.
7794 Without this fix, interrupts could mess up code that uses these
7795 nonreentrant functions, since setting TZ invalidates existing
7796 tm_zone or tzname values, and since most of these functions return
7797 pointers to static storage.
7798 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
7799 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
7800 Grow the critical sections to include not just invoking
7801 localtime/gmtime, but also accessing these functions' results
7802 including their tm_zone values if any, and any related TZ setting.
7803 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
7804 so that the struct tm is saved in the critical section.
7805 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
7806 motivated by the fact that memory allocation needs to be outside
7807 the critical section.
7808
0c16dfed
DA
78092012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
7810
7811 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
7812 with RESET_INTERVAL.
7813
7814 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7815 Remove duplicated buffer name initialization.
7816
3f83ace8
JM
78172012-05-02 Jim Meyering <jim@meyering.net>
7818
7819 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
7820
c7b8541e
JM
7821 * xfns.c (x_window): Use xstrdup (Bug#11375).
7822
90207a15 78232012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
7824
7825 * xdisp.c (pos_visible_p): If already at a newline from the
7826 display string before the 'while' loop, don't walk back the glyphs
7827 from it3.glyph_row. Solves assertion violation when the display
7828 string begins with a newline (egg.el). (Bug#11367)
7829
b593d6a9
AH
78302012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
7831
7832 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
7833 Move to simple.el.
7834
4737362e
GM
78352012-05-01 Glenn Morris <rgm@gnu.org>
7836
99cf43f9
GM
7837 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
7838 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
7839 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
7840 All were removed before 23.1.
7841
9311dcff
GM
7842 * dispnew.c: Remove HAVE_LIBNCURSES test;
7843 it is always true on relevant platforms.
7844
4d5c6349
GM
7845 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
7846 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
7847
4737362e
GM
7848 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
7849
74dd3a6b
AS
78502012-04-30 Andreas Schwab <schwab@linux-m68k.org>
7851
7852 * .gdbinit (xpr): Remove checks for no longer existing misc types.
7853 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
7854 Remove.
7855
13c379ee
PE
78562012-04-28 Paul Eggert <eggert@cs.ucla.edu>
7857
7858 Do not avoid creating empty evaporating overlays (Bug#9642).
7859 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
7860 That is, do not delete an evaporating overlay if it becomes
7861 empty after its bounds are adjusted to fit within its buffer.
7862 This fix caused other problems, and I'm reverting it until we get
7863 to the bottom of them.
7864
a8e7d6d7 78652012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
7866
7867 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
7868
a8e7d6d7 78692012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
7870
7871 * xdisp.c (pos_visible_p): If the window start position is beyond
7872 ZV, start the display from buffer beginning. Prevents assertion
7873 violation in init_iterator when the minibuffer window is scrolled
7874 via the scroll bar.
7875
7876 * window.c (window_scroll_pixel_based): Likewise.
7877
a8e7d6d7 78782012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
7879
7880 * keymap.c (where_is_internal): Doc fix (Bug#10872).
7881
a8e7d6d7 78822012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
7883
7884 * fileio.c (Fcopy_file, Fset_file_selinux_context):
7885 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
7886
a8e7d6d7 78872012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 7888
b593d6a9
AH
7889 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
7890 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 7891
1c6900d9
EZ
78922012-04-26 Eli Zaretskii <eliz@gnu.org>
7893
4c3fa1d9
EZ
7894 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
7895 display element, check also the underlying string or buffer
7896 character. (Bug#11341)
7897
1c6900d9
EZ
7898 * w32menu.c: Include w32heap.h.
7899 (add_menu_item): If the call to AppendMenuW (via
7900 unicode_append_menu) fails, disable Unicode menus only if we are
7901 running on Windows 9X/Me.
7902
42bf8205
AS
79032012-04-24 Andreas Schwab <schwab@linux-m68k.org>
7904
7905 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
7906 (xgetint): Add missing shift for LSB tags.
7907
b1bac16e
MR
79082012-04-24 Martin Rudalics <rudalics@gmx.at>
7909
7910 * keyboard.c (read_char): Don't wipe echo area for select window
7911 events: These might get delayed via `mouse-autoselect-window'
7912 (Bug#11304).
7913
d69621cc
JB
79142012-04-24 Juanma Barranquero <lekktu@gmail.com>
7915
7916 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
7917 manipulation of :loaded-from data.
7918
02fd101b
JB
79192012-04-23 Juanma Barranquero <lekktu@gmail.com>
7920
7921 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
7922 now a cons (bug#11311).
7923
888bec30
PE
79242012-04-23 Paul Eggert <eggert@cs.ucla.edu>
7925
89a438bd
PE
7926 Do not create empty overlays with the evaporate property (Bug#9642).
7927 * buffer.c (Fmove_overlay): Delete an evaporating overlay
7928 if it becomes empty after its bounds are adjusted to fit within
7929 its buffer. Without this fix, in a nonempty buffer (let ((o
7930 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
7931 yields an empty overlay that has the evaporate property, which is
7932 not supposed to happen.
7933
1068fe4d
PE
7934 Fix minor GTK3 problems found by static checking.
7935 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7936 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7937 (struct _EmacsFixedClass, emacs_fixed_get_type):
7938 Move decls here from emacsgtkfixed.h, since they needn't be public.
7939 (emacs_fixed_get_type): Now static.
7940 (emacs_fixed_class_init): Omit unused local.
7941 (emacs_fixed_child_type): Remove; unused.
7942 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7943 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7944 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
7945 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
7946 (EMACS_FIXED_GET_CLASS): Remove; unused.
7947 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
7948
888bec30
PE
7949 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
7950 Problem reported by Juanma Barranquero for Windows -Wunused-function.
7951
de85e130
PE
79522012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7953
d0baac98 7954 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 7955 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
7956 (__malloc_size_t, __malloc_ptrdiff_t):
7957 Remove. All uses removed, replaced by the definiens if needed,
7958 since we can assume C89 or better now.
7959 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
7960 (protect_malloc_state, align, get_contiguous_space)
7961 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
7962 (malloc_atfork_handler_child, malloc_enable_thread)
7963 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
7964 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
7965 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
7966 (special_realloc, _realloc_internal_nolock, _realloc_internal)
7967 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
7968 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
7969 Define using prototypes, not old style.
7970 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
7971 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
7972 (align): Don't assume that signed integer overflow wraps around.
7973 Omit unused local var.
7974 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
7975 (_free_internal_nolock, memalign, mallochook, reallochook):
7976 Omit no-longer-needed casts.
7977 (valloc): Use getpagesize, not __getpagesize.
7978 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
7979 (struct hdr): The 'magic' member is now size_t, not unsigned long.
7980
de85e130
PE
7981 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
7982
dcbf5805
MA
79832012-04-22 Michael Albinus <michael.albinus@gmx.de>
7984
7985 Move functions from C to Lisp. Make non-blocking method calls
7986 the default. Implement further D-Bus standard interfaces.
7987
7988 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
7989 (QCdbus_request_name_allow_replacement)
7990 (QCdbus_request_name_replace_existing)
7991 (QCdbus_request_name_do_not_queue)
7992 (QCdbus_request_name_reply_primary_owner)
7993 (QCdbus_request_name_reply_in_queue)
7994 (QCdbus_request_name_reply_exists)
7995 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
7996 (QCdbus_registered_serial, QCdbus_registered_method)
7997 (QCdbus_registered_signal): New Lisp objects.
7998 (XD_DEBUG_MESSAGE): Use sizeof.
7999 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
8000 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
8001 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
8002 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
8003 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
8004 (xd_signature, xd_append_arg): Allow float for integer types.
8005 (xd_get_connection_references): New function.
b593d6a9
AH
8006 (xd_get_connection_address): Rename from xd_initialize.
8007 Return cached address.
dcbf5805
MA
8008 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
8009 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
8010 level.
8011 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 8012 Return number of refcounts.
dcbf5805
MA
8013 (Fdbus_get_unique_name): Make stronger parameter check.
8014 (Fdbus_message_internal): New defun.
8015 (Fdbus_call_method, Fdbus_call_method_asynchronously)
8016 (Fdbus_method_return_internal, Fdbus_method_error_internal)
8017 (Fdbus_send_signal, Fdbus_register_service)
8018 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
8019 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
8020 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
8021 (Vdbus_compiled_version, Vdbus_runtime_version)
8022 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
8023 (Vdbus_message_type_method_return, Vdbus_message_type_error)
8024 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
8025 (Vdbus_registered_buses, Vdbus_registered_objects_table):
8026 Adapt docstring.
dcbf5805 8027
52828e02
PE
80282012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8029
da05bc4c
PE
8030 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
8031 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
8032 Do not assume ptrdiff_t is the same width as 'int'.
8033
52828e02
PE
8034 * alloc.c: Handle unusual debugging option combinations.
8035 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
8036 since the two debugging options are incompatible.
8037 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
8038 is defined.
8039 (mem_init, mem_insert, mem_insert_fixup):
8040 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
8041 (NEED_MEM_INSERT): Remove; no longer needed.
8042
f01769f9
LL
80432012-04-22 Leo Liu <sdl.web@gmail.com>
8044
8045 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
8046
5790543d
PE
80472012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8048
8049 * sysdep.c [__FreeBSD__]: Minor cleanups.
8050 (list_system_processes, system_process_attributes) [__FreeBSD__]:
8051 Use Emacs indenting style more consistently. Avoid some casts.
8052 Use 'double' consistently rather than mixing 'float' and 'double'.
8053
b91b7e4d
EW
80542012-04-21 Eduard Wiebe <usenet@pusto.de>
8055
b593d6a9
AH
8056 * sysdep.c (list_system_processes, system_process_attributes):
8057 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 8058
6114eb15
AS
80592012-04-21 Andreas Schwab <schwab@linux-m68k.org>
8060
8061 * lisp.mk (lisp): Update.
8062
2f38dff7
PE
80632012-04-20 Paul Eggert <eggert@cs.ucla.edu>
8064
8065 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
8066 It is never used otherwise.
8067
4ae29f89
SM
80682012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
8069
8070 * print.c (print_preprocess): Only check print_depth if print-circle
8071 is nil.
8072 (print_object): Check for cycles even when print-circle is nil and
8073 print-gensym is t, but only check print_depth if print-circle is nil.
8074
f30d612a
CY
80752012-04-20 Chong Yidong <cyd@gnu.org>
8076
8077 * process.c (wait_reading_process_output): If EIO occurs on a pty,
8078 set the status to "failed" and ensure that sentinel is run.
8079
c07a4c0b 80802012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
8081
8082 * process.c (Fset_process_inherit_coding_system_flag)
8083 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 8084 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 8085
c07a4c0b 80862012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
8087
8088 * xdisp.c (string_buffer_position_lim): Limit starting position to
8089 BEGV.
8090 (set_cursor_from_row): If called for a mode-line or header-line
8091 row, return zero immediately.
8092 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
8093 farther than the first row after the header line, if any.
8094 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
8095 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
8096
c07a4c0b 80972012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 8098
4ae29f89
SM
8099 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
8100 (bug#11238).
ad3a2b41 8101
c07a4c0b 81022012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 81032012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
8104
8105 configure: new option --enable-gcc-warnings (Bug#11207)
8106 * Makefile.in (C_WARNINGS_SWITCH): Remove.
8107 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
8108 (ALL_CFLAGS): Use new macros rather than old.
8109 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
8110 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
8111 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
8112 -Wunused-result, -Wunused-variable. This should go away once
8113 the Emacs and Gnulib regex code is merged.
8114 (xmalloc, xrealloc): Now static.
8115
aba027e8
PE
81162012-04-17 Paul Eggert <eggert@cs.ucla.edu>
8117
8118 * dired.c (Fsystem_groups): Remove unused local.
8119
e5a36063
GM
81202012-04-17 Glenn Morris <rgm@gnu.org>
8121
8122 * dired.c (Fsystem_users): Doc fix.
8123
316411f0
DA
81242012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
8125
8126 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
8127 (syms_of_dired): Add them.
8128
9426aba4
PE
81292012-04-16 Paul Eggert <eggert@cs.ucla.edu>
8130
b62a57be
PE
8131 Fix minor alloc.c problems found by static checking.
8132 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
8133 New extern decls, to avoid calling undeclared functions.
8134 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
8135 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
8136 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
8137 (NEED_MEM_INSERT): New macro.
8138 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 8139 Remove one incorrect comment and fix another.
b62a57be 8140
3539f31f
PE
8141 Fix minor ralloc.c problems found by static checking.
8142 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8143 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
8144 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
8145 (r_alloc_sbrk): Now static.
8146
a041960a
PE
8147 Improve ralloc.c interface checking.
8148 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8149 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
8150 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
8151 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
8152 [REL_ALLOC]: ... to here, to check interface.
8153 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
8154 Remove decls. This fixes an "It stinks!".
8155
9426aba4
PE
8156 * alloc.c (which_symbols): Fix alignment issue / type clash.
8157
d55c12ed
AS
81582012-04-15 Andreas Schwab <schwab@linux-m68k.org>
8159
8160 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
8161 (struct Lisp_Misc_Any): Likewise.
8162 (struct Lisp_Free): Likewise.
8163 * alloc.c (union aligned_Lisp_Symbol): Define.
8164 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
8165 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
8166 (union aligned_Lisp_Misc): Define.
8167 (MARKER_BLOCK_SIZE, struct marker_block): Use union
8168 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 8169 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 8170
b948ce8b
PE
81712012-04-14 Paul Eggert <eggert@cs.ucla.edu>
8172
8173 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
8174 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
8175 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
8176 * s/netbsd.h, s/sol2-6.h:
8177 Remove definition of GC_MARK_STACK, since the default now works.
8178 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
8179 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
8180 no longer the default.
8181 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
8182
35dc09a1 81832012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 8184
35dc09a1
GM
8185 * lread.c (lisp_file_lexically_bound_p):
8186 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 8187
35dc09a1
GM
81882012-04-14 Eli Zaretskii <eliz@gnu.org>
8189
8190 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
8191 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
8192
81932012-04-14 Jan Djärv <jan.h.d@swipnet.se>
8194
8195 * nsterm.m (constrainFrameRect): Always constrain when there is only
8196 one screen (Bug#10962).
8197
bcd86815
KB
81982012-04-13 Ken Brown <kbrown@cornell.edu>
8199
8200 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
8201
c25df26e
RT
82022012-04-13 Reuben Thomas <rrt@sc3d.org>
8203
8204 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
8205
0fc59f1e
DC
82062012-04-11 Daniel Colascione <dancol@dancol.org>
8207
8208 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
8209 against is gone. It's better to use vfork now so that when Cygwin
8210 gains a new, working vfork, we use it automatically (bug#10398).
8211
de8c03dc
SM
82122012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
8213
8214 * window.c (save_window_save): Obey window-point-insertion-type.
8215
2f097256
GM
82162012-04-11 Glenn Morris <rgm@gnu.org>
8217
8218 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
8219
453b951e
SM
82202012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
8221
8222 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
8223
75f1671a 82242012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
8225
8226 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
8227 (force_quit_count): New var.
8228 (handle_interrupt): Use it.
8229
2a8ce227
JB
82302012-04-10 Juanma Barranquero <lekktu@gmail.com>
8231
8232 * w32.c (w32_delayed_load): Record the full path of the library
8233 being loaded (bug#10424).
8234
935396c0
GM
82352012-04-09 Glenn Morris <rgm@gnu.org>
8236
05920a43
GM
8237 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
8238 not just in the obarray, before snarfing them. (Bug#11036)
8239
935396c0
GM
8240 * Makefile.in ($(leimdir)/leim-list.el):
8241 Pass EMACS rather than BUILT_EMACS.
8242
a18ecafa
TZ
82432012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
8244
8245 * process.c (make_process):
8246 * process.h: Add integer `gnutls_handshakes_tried' member to
8247 process struct.
8248
6bbef4e5
JC
8249 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
8250 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
8251
8252 * gnutls.c (gnutls_log_function2i): Convenience log function.
8253 (emacs_gnutls_read): Use new log functions,
8254 `gnutls_handshakes_tried' process member, and
8255 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
8256 attempts per process (connection).
8257
b4d3bc10
CY
82582012-04-09 Chong Yidong <cyd@gnu.org>
8259
8260 * eval.c (Fuser_variable_p, user_variable_p_eh)
8261 (lisp_indirect_variable): Functions deleted.
8262 (Fdefvar): Caller changed.
8263
8264 * callint.c (Finteractive, Fcall_interactively):
8265 * minibuf.c (Fread_variable): Callers changed.
8266
70f4d973
EZ
82672012-04-09 Eli Zaretskii <eliz@gnu.org>
8268
8269 * xdisp.c (set_cursor_from_row): If the display string appears in
8270 the buffer at position that is closer to point than the position
8271 after the display string, display the cursor on the first glyph of
8272 the display string. Fixes cursor display when a 'display' text
8273 property immediately follows invisible text. (Bug#11094)
8274
cb3c2e3e
PE
82752012-04-09 Paul Eggert <eggert@cs.ucla.edu>
8276
8277 composite.c: use 'double' consistently
8278 * composite.c (get_composition_id): Use 'double' consistently
8279 instead of converting 'float' to 'double' and vice versa; this is
8280 easier to understand and avoids a GCC warning.
8281
fd06db5d
GM
82822012-04-09 Glenn Morris <rgm@gnu.org>
8283
50fe702a
GM
8284 * Makefile.in: Generate leim-list with bootstrap-emacs, in
8285 preparation for dumping it with emacs. (Bug#4789)
8286 (leimdir): New variable.
8287 ($(leimdir)/leim-list.el): New rule.
8288 (emacs$(EXEEXT)): Depend on leim-list.el.
8289
fd06db5d
GM
8290 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
8291 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
8292 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
8293
55c131ee
AS
82942012-04-08 Andreas Schwab <schwab@linux-m68k.org>
8295
8296 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
8297 proper alignment.
8298
9209588f
JB
82992012-04-07 Juanma Barranquero <lekktu@gmail.com>
8300
8301 * xml.c (init_libxml2_functions) [WINDOWSNT]:
8302 Remove unused local variable.
8303
e3fb2efb
PE
83042012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8305
8306 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
8307 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
8308 (mark_memory): Mark Lisp_Objects only if pointers might hide in
8309 objects, as mark_maybe_pointer will catch them otherwise.
8310 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
8311 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
8312
b5385551
PE
83132012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8314
8315 Fix typo that broke non-Windows builds.
8316 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
8317
9078ead6
EZ
83182012-04-07 Eli Zaretskii <eliz@gnu.org>
8319
8320 Support building on MS-Windows with libxml2.
8321
8322 * makefile.w32-in (OBJ2): Add xml.$(O).
8323 (GLOBAL_SOURCES): Add xml.c.
8324 ($(BLD)/xml.$(O)): New dependency list.
8325
8326 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
8327 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
8328 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
8329 [!WINDOWSNT]: New macros.
8330 (init_libxml2_functions, libxml2_loaded_p): New functions.
8331 (parse_region): Call fn_xmlCheckVersion instead of using the macro
8332 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
8333 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
8334 Calls xmlCleanupParser only if libxml2 was loaded (or statically
8335 linked in).
6bbef4e5
JC
8336 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
8337 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
8338 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
8339
8340 * emacs.c: Don't include libxml/parser.h.
8341 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
8342 xmlCleanupParser directly.
8343
8344 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
8345
3811fdf3
EZ
83462012-04-07 Eli Zaretskii <eliz@gnu.org>
8347
8348 * indent.c (Fvertical_motion): If there is a display string at
8349 point, use it.vpos to compute how many lines to backtrack after
8350 move_it_to point. (Bug#11133)
8351
2f8e16b2
EZ
83522012-04-06 Eli Zaretskii <eliz@gnu.org>
8353
8354 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
8355 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
8356 about subtle differences between FETCH_CHAR* and STRING_CHAR*
8357 macros related to unification of CJK characters. For the details,
8358 see the discussion following the message here:
8359 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
8360
3d439cd1
CY
83612012-04-04 Chong Yidong <cyd@gnu.org>
8362
8363 * keyboard.c (Vdelayed_warnings_list): Doc fix.
8364
8bc53d00
EZ
83652012-04-01 Eli Zaretskii <eliz@gnu.org>
8366
8367 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
8368 instead of alloca. (Bug#11138)
8369
3b0512a3
AS
83702012-04-01 Andreas Schwab <schwab@linux-m68k.org>
8371
8372 * w32menu.c (is_simple_dialog): Properly check lisp types.
8373 (Bug#11141)
8374
8427ddd2
EZ
83752012-03-31 Eli Zaretskii <eliz@gnu.org>
8376
979022ef
EZ
8377 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
8378 position we get to after a call to move_it_to fails the
8379 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
8380 only if we wind up in a string from display property. (Bug#11063)
8381
a6b1c7cc
EZ
8382 * window.c (Fdelete_other_windows_internal): Invalidate the row
8383 and column information about mouse highlight, so that redisplay
8384 restores it after reallocating the glyph matrices. (Bug#7464)
8385
8427ddd2
EZ
8386 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
8387 string comes from a `display' text property, use the buffer
8388 position of that property as if we actually saw that position in
8389 the row's glyphs.
697ba24b
EZ
8390 (move_it_by_lines): Remove the assertion that
8391 "it->current_x == 0 && it->hpos == 0" which can be legitimately
8392 violated when there's a before-string at the beginning of a line.
8393 (Bug#11063)
8427ddd2 8394
65a0a738
EZ
83952012-03-30 Eli Zaretskii <eliz@gnu.org>
8396
8397 * xdisp.c (append_space_for_newline): If the default face was
8398 remapped, use the remapped face for the appended newline.
8399 (extend_face_to_end_of_line): Use the remapped default face for
8400 extending the face to the end of the line.
8401 (display_line): Call extend_face_to_end_of_line when the default
8402 face was remapped. (Bug#11068)
8403
581355cc
EZ
84042012-03-29 Eli Zaretskii <eliz@gnu.org>
8405
8406 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
8407
e8fc049f
SM
84082012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8409
8410 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
8411
4fb9a543
GM
84122012-03-27 Glenn Morris <rgm@gnu.org>
8413
8414 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
8415 Doc fixes.
8416
679910f1
KH
84172012-03-26 Kenichi Handa <handa@m17n.org>
8418
8419 * dispextern.h (struct glyph): Fix previous change. Change the
8420 bit length of glyphless.ch to 25 (Bug#11082).
8421
90d49b7f
CY
84222012-03-26 Chong Yidong <cyd@gnu.org>
8423
8424 * keyboard.c (Vselection_inhibit_update_commands): New variable.
8425 (command_loop_1): Use it; inhibit selection update for
8426 handle-select-window too (Bug#8996).
8427
f514f6f0
FP
84282012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
8429
e8fc049f 8430 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 8431
bf43fa51
KH
84322012-03-25 Kenichi Handa <handa@m17n.org>
8433
8434 * dispextern.h (struct glyph): Change the bit length of
8435 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
8436
8a0c01dd
EZ
84372012-03-24 Eli Zaretskii <eliz@gnu.org>
8438
8439 * s/ms-w32.h (tzname): Include time.h before redirecting to
8440 _tzname. Fixes the MSVC build. (Bug#9960)
8441
7d1c3a76
AS
84422012-03-24 Andreas Schwab <schwab@linux-m68k.org>
8443
8ed79523
AS
8444 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
8445 characters.
8446
7d1c3a76
AS
8447 * xterm.c (XTread_socket): Only modify handling_signal if
8448 !SYNC_INPUT. (Bug#11080)
8449
e99a9b8b
EZ
84502012-03-23 Eli Zaretskii <eliz@gnu.org>
8451
8452 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
8453 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
8454 when fetching a multibyte character consumes more bytes than
8455 CHAR_BYTES returns, due to unification of CJK characters in
8456 string_char. (Bug#11073)
8457
5063c0e1
TN
84582012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
8459
8460 * process.c (wait_reading_process_output): Handle pty disconnect
8461 by refraining from sending oneself a SIGCHLD (bug#10933).
8462
9f851fbd
CY
84632012-03-22 Chong Yidong <cyd@gnu.org>
8464
8465 * dispextern.h (struct it): New member string_from_prefix_prop_p.
8466
5063c0e1 8467 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
8468 Mark string as coming from a prefix property.
8469 (handle_face_prop): Use default face for prefix strings (Bug#4281).
8470 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
8471
fb5b8aca
CY
84722012-03-21 Chong Yidong <cyd@gnu.org>
8473
8474 * xfaces.c (Vface_remapping_alist): Doc fix.
8475
62356a1b
EZ
84762012-03-20 Eli Zaretskii <eliz@gnu.org>
8477
8478 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
8479 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
8480 Doc fixes.
62356a1b 8481
025de85b
CY
84822012-03-20 Chong Yidong <cyd@gnu.org>
8483
8484 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
8485 to reflect default non-nil value of redisplay-dont-pause.
8486
4827f94e
KH
84872012-03-19 Kenichi Handa <handa@m17n.org>
8488
8489 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
8490 it fit in a valid range (Bug#11003).
8491
e50a24a2
EZ
84922012-03-18 Eli Zaretskii <eliz@gnu.org>
8493
8494 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
8495 that is not from display property, accept the row as a "cursor
8496 row" if one of the string's character has a non-nil `cursor'
8497 property. Fixes cursor positioning when there are newlines in
8498 overlay strings, e.g. in icomplete.el. (Bug#11035)
8499
9af5ed87
PE
85002012-03-12 Paul Eggert <eggert@cs.ucla.edu>
8501
8502 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
8503
d1f55f16
CY
85042012-03-12 Chong Yidong <cyd@gnu.org>
8505
8506 * eval.c (inhibit_lisp_code): Rename from
8507 inhibit_window_configuration_change_hook; move from window.c.
8508
8509 * xfns.c (unwind_create_frame_1, Fx_create_frame):
8510 * window.c (run_window_configuration_change_hook)
8511 (syms_of_window): Callers changed.
8512
66c5eebd
CY
85132012-03-11 Chong Yidong <cyd@gnu.org>
8514
413df973
CY
8515 * keymap.c (Fkey_description): Doc fix (Bug#9700).
8516
66c5eebd
CY
8517 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
8518
1de11f56
CY
85192012-03-10 Chong Yidong <cyd@gnu.org>
8520
8521 * frame.c (other_visible_frames): Don't assume the selected frame
8522 is visible (Bug#10955).
8523
cae07000
SM
85242012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
8525
8526 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
8527
89c94350
JD
85282012-03-08 Jan Djärv <jan.h.d@swipnet.se>
8529
8530 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
8531 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
8532 zero (Bug#10954).
8533
999dd333
GM
85342012-03-03 Glenn Morris <rgm@gnu.org>
8535
01a6dcc8 8536 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 8537
de0100f2
EZ
85382012-03-02 Eli Zaretskii <eliz@gnu.org>
8539
8540 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
8541 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
8542 (redisplay_window, next_element_from_string): Fix typos in
8543 comments.
3e441275
EZ
8544 (redisplay_window): Pass to move_it_vertically the margin in
8545 pixels, not in screen lines.
de0100f2 8546
96a72ee9
GM
85472012-03-02 Glenn Morris <rgm@gnu.org>
8548
8549 * buffer.c (buffer-list-update-hook): Doc fix.
8550
312508d7
EZ
85512012-02-29 Eli Zaretskii <eliz@gnu.org>
8552
8553 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
8554 push_it before setting up the iterator for the first overlay
8555 string, even if we have an empty string loaded.
8556 (next_overlay_string): If there's an empty string on the iterator
8557 stack, pop the stack. (Bug#10903)
8558
27f3c637
PE
85592012-02-25 Paul Eggert <eggert@cs.ucla.edu>
8560
8561 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
8562 Suggested by Stefan Monnier in
8563 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
8564 * alloc.c (widen_to_Lisp_Object): New static function.
8565 (mark_memory): Also mark Lisp_Objects by fetching pointer words
8566 and widening them to Lisp_Objects. This would work even if
8567 USE_LSB_TAG is defined and wide integers are used, which might
8568 happen in a future version of Emacs.
8569
3c9dfce6
CY
85702012-02-25 Chong Yidong <cyd@gnu.org>
8571
fa74b241
CY
8572 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
8573 Doc fix.
8574
3c9dfce6
CY
8575 * xselect.c (Fx_selection_exists_p): Doc fix.
8576 (x_clipboard_manager_save_all): Print an informative message
8577 before saving to clipboard manager.
8578
9486df08
CY
85792012-02-24 Chong Yidong <cyd@gnu.org>
8580
8581 * keyboard.c (process_special_events): Handle all X selection
8582 requests in kbd_buffer, not just the next one (Bug#8869).
8583
f01d3321
CY
85842012-02-23 Chong Yidong <cyd@gnu.org>
8585
8586 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
8587 call when setting menu-bar-lines and tool-bar-lines parameters.
8588 (unwind_create_frame_1): New helper function.
8589
8590 * window.c (inhibit_window_configuration_change_hook): New var.
8591 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 8592 (syms_of_window): Initialize it.
f01d3321 8593
86b847b6
CY
85942012-02-22 Chong Yidong <cyd@gnu.org>
8595
8596 * xterm.c (x_draw_image_relief): Add missing type check for
8597 Vtool_bar_button_margin (Bug#10743).
8598
a59225b1
CY
85992012-02-21 Chong Yidong <cyd@gnu.org>
8600
8601 * fileio.c (Vfile_name_handler_alist): Doc fix.
8602
8603 * buffer.c (Fget_file_buffer): Protect against invalid file
8604 handler return value.
8605
310f5bd4
PE
86062012-02-20 Paul Eggert <eggert@cs.ucla.edu>
8607
cb3a28cc
PE
8608 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
8609 when computing $valmask.
8610
310f5bd4
PE
8611 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
8612 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
8613 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
8614 It's useless in that case, and it can cause problems on hosts
8615 that allocate halves of EMACS_INT values separately.
8616 Reported by Dan Horák. Diagnosed by Andreas Schwab in
8617 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
8618 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
8619 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
8620 it avoids undefined behavior on hosts where shifting right by more
8621 than the word width has undefined behavior.
8622
2375c96a
CY
86232012-02-19 Chong Yidong <cyd@gnu.org>
8624
8625 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
8626 (Funhandled_file_name_directory, Ffile_name_as_directory)
8627 (Fdirectory_file_name, Fexpand_file_name)
8628 (Fsubstitute_in_file_name): Protect against invalid file handler
8629 return values (Bug#10845).
8630
3eb49e71
EZ
86312012-02-18 Eli Zaretskii <eliz@gnu.org>
8632
8633 * .gdbinit (pitx): Fix incorrect references to fields of the
8634 iterator stack.
8635
7b926f3f
CY
86362012-02-17 Chong Yidong <cyd@gnu.org>
8637
8638 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
8639
11273115
PE
86402012-02-15 Paul Eggert <eggert@cs.ucla.edu>
8641
8642 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
8643 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
8644
c3a70e2b
CY
86452012-02-15 Chong Yidong <cyd@gnu.org>
8646
8647 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
8648 marked as special. Also, starting docstrings with * is obsolete.
8649
0ca43699
AS
86502012-02-13 Andreas Schwab <schwab@linux-m68k.org>
8651
8652 * gnutls.c (emacs_gnutls_write): Fix last change.
8653
2e8f3c56
LI
86542012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
8655
8656 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
8657 send_process.
8658
af70074f
SM
86592012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
8660
8661 * keymap.c (Fsingle_key_description): Handle char ranges.
8662
95986d52
CY
86632012-02-12 Chong Yidong <cyd@gnu.org>
8664
afd83bd1
CY
8665 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
8666 as that creates a dangerous corner case.
8667
95986d52
CY
8668 * window.c (Fdelete_window_internal): Invalidate the mouse
8669 highlight (Bug#9904).
8670
bd7da63e
GM
86712012-02-12 Glenn Morris <rgm@gnu.org>
8672
8673 * xselect.c (Fx_own_selection_internal)
8674 (Fx_get_selection_internal, Fx_disown_selection_internal)
8675 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
8676 * nsselect.m (Fx_own_selection_internal)
8677 (Fx_disown_selection_internal, Fx_selection_exists_p)
8678 (Fx_selection_owner_p, Fx_get_selection_internal):
8679 Sync docs and argument specs with the xselect.c versions.
8680
77abcbc2
LI
86812012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
8682
8683 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
8684
90b671e2
EZ
86852012-02-11 Eli Zaretskii <eliz@gnu.org>
8686
1c0ca0b7
EZ
8687 * w32select.c (Fx_selection_exists_p): Sync doc string and
8688 argument list with xselect.c. (Bug#10783)
8689
8690 * w16select.c (Fx_selection_exists_p): Sync doc string and
8691 argument list with xselect.c. (Bug#10783)
90b671e2 8692
49241268
GM
86932012-02-10 Glenn Morris <rgm@gnu.org>
8694
8695 * fns.c (Fsecure_hash): Doc fix.
8696
f998bbe7 86972012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
8698
8699 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
8700
0992bd9c
CY
87012012-02-07 Chong Yidong <cyd@gnu.org>
8702
8703 * buffer.c (Fbuffer_local_variables)
8704 (buffer_lisp_local_variables): Handle unbound vars correctly;
8705 don't let Qunbound leak into Lisp.
8706
af008560
GM
87072012-02-07 Glenn Morris <rgm@gnu.org>
8708
dd605cc4
GM
8709 * image.c (Fimagemagick_types): Doc fix.
8710
af008560
GM
8711 * image.c (imagemagick-render-type): Change it from a lisp object
8712 to an integer. Move the doc here from the lisp manual.
8713 Treat all values not equal to 0 the same.
8714
1449fa1d
CY
87152012-02-06 Chong Yidong <cyd@gnu.org>
8716
8717 * doc.c (store_function_docstring): Avoid applying docstring of
8718 alias to base function (Bug#2603).
8719
3723ec07
AS
87202012-02-04 Andreas Schwab <schwab@linux-m68k.org>
8721
8722 * .gdbinit (pp1, pv1): Remove redundant defines.
8723 (pr): Use pp.
8724
79c1cc1e
CY
87252012-02-04 Chong Yidong <cyd@gnu.org>
8726
8727 * nsterm.m: Declare a global (Bug#10694).
8728
d7f29f8e
EZ
87292012-02-04 Eli Zaretskii <eliz@gnu.org>
8730
cae07000
SM
8731 * w32.c (get_emacs_configuration_options):
8732 Include --enable-checking, if specified, in the return value.
d7f29f8e 8733
3b95a6f9
MR
87342012-02-04 Martin Rudalics <rudalics@gmx.at>
8735
8736 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
8737 after rounding frame sizes. (Bug#9723)
8738
d6fa96a6
EZ
87392012-02-04 Eli Zaretskii <eliz@gnu.org>
8740
8741 * keyboard.c (adjust_point_for_property): Don't position point
8742 before BEGV. (Bug#10696)
8743
df0b2940
PE
87442012-02-03 Paul Eggert <eggert@cs.ucla.edu>
8745
8746 Handle overflow when computing char display width (Bug#9496).
8747 * character.c (char_width): Return EMACS_INT, not int.
8748 (char_width, c_string_width): Check for overflow when
8749 computing the width; this is possible now that individual
8750 characters can have unbounded width. Problem introduced
8751 by merge from Emacs 23 on 2012-01-19.
8752
6bee44d6
MA
87532012-02-02 Michael Albinus <michael.albinus@gmx.de>
8754
8755 * dbusbind.c (Fdbus_register_method): Mention the return value
8756 :ignore in the docstring.
8757
44f92739
GM
87582012-02-02 Glenn Morris <rgm@gnu.org>
8759
1b9f60cc
GM
8760 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
8761
44f92739
GM
8762 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8763 Unconditionally set to t. (Bug#10673)
8764 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8765 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
8766 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
8767
c5d3843c
KH
87682012-02-02 Kenichi Handa <handa@m17n.org>
8769
8770 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
8771 0, do not call append_composite_glyph.
8772
159462d4 87732012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
8774
8775 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
8776 NULL (Bug#6988).
8777 (x_produce_glyphs): If the component of a composition is a null
8778 string, set it->pixel_width to 1 to avoid zero-width glyph.
8779
78cef877
EZ
87802012-02-01 Eli Zaretskii <eliz@gnu.org>
8781
8782 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
8783 first 2 arguments are identical. This makes inserting large
8784 output from a subprocess an order of magnitude faster on
8785 MS-Windows, where all sbrk'ed memory is always contiguous.
8786
97897668
GM
87872012-01-31 Glenn Morris <rgm@gnu.org>
8788
8789 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 8790 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
8791 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
8792
31fd3586
GM
87932012-01-29 Glenn Morris <rgm@gnu.org>
8794
8795 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
8796
0e24a8b2
CY
87972012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
8798
8799 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
8800
cc0adcb0
CY
88012012-01-28 Chong Yidong <cyd@gnu.org>
8802
8803 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
8804
acc28cb9
CY
88052012-01-26 Chong Yidong <cyd@gnu.org>
8806
9c69cfb7
CY
8807 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
8808
acc28cb9
CY
8809 * search.c (Fsearch_forward, Fsearch_backward): Document negative
8810 repeat counts (Bug#10507).
8811
48da7392
GM
88122012-01-26 Glenn Morris <rgm@gnu.org>
8813
8814 * lread.c (syms_of_lread): Doc fix.
8815
14af5f7f
CY
88162012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
8817
8818 * coding.c (encode_designation_at_bol): Change return value to
8819 EMACS_INT.
8820
0b21c100
CY
88212012-01-25 Chong Yidong <cyd@gnu.org>
8822
8823 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
8824
3c2907f7
CY
88252012-01-21 Chong Yidong <cyd@gnu.org>
8826
8827 * floatfns.c (Fcopysign): Make the second argument non-optional,
8828 since nil is not allowed anyway.
8829
959ad23f
AS
88302012-01-21 Andreas Schwab <schwab@linux-m68k.org>
8831
8832 * process.c (read_process_output): Use p instead of XPROCESS (proc).
8833 (send_process): Likewise.
8834
34a02f46
MR
88352012-01-19 Martin Rudalics <rudalics@gmx.at>
8836
8837 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
8838 (Vwindow_persistent_parameters): Do not use Qstate.
8839 Rewrite doc-strings.
34a02f46 8840
1259009a 88412012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
8842
8843 * character.c (char_width): New function.
70d4fdf6
GM
8844 (Fchar_width, c_string_width, lisp_string_width):
8845 Use char_width (Bug#9496).
25ed9e61 8846
6a6ee00d
MR
88472012-01-16 Martin Rudalics <rudalics@gmx.at>
8848
8849 * window.c (Vwindow_persistent_parameters): New variable.
8850 (Fset_window_configuration, save_window_save): Handle persistent
8851 window parameters.
8852
c85efaf7
EZ
88532012-01-14 Eli Zaretskii <eliz@gnu.org>
8854
8855 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
8856 thrashing the stack of the thread. (Bug#9087)
8857
5944709e
PE
88582012-01-12 Paul Eggert <eggert@cs.ucla.edu>
8859
8860 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
8861
e71f5d99
EZ
88622012-01-11 Eli Zaretskii <eliz@gnu.org>
8863
8864 * xdisp.c (rows_from_pos_range): Handle the case where the
8865 highlight ends on a newline. (Bug#10464)
8866 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
8867 he end column for display of highlight that ends on a newline
8868 before a R2L line.
8869
ce316182
GM
88702012-01-11 Glenn Morris <rgm@gnu.org>
8871
8872 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
8873 from load-path also when installation-directory is nil. (Bug#10208)
8874
5b43da69
GM
88752012-01-10 Glenn Morris <rgm@gnu.org>
8876
74cc8ff9
GM
8877 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
8878
7d8d6e4e
GM
8879 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
8880 Update template values to be closer to their typical values these days.
5b43da69 8881
a0db8d43
EZ
88822012-01-09 Eli Zaretskii <eliz@gnu.org>
8883
8884 * xdisp.c (rows_from_pos_range): Accept additional argument
8885 DISP_STRING, and accept any glyph in a row whose object is that
8886 string as eligible for mouse highlight. Fixes mouse highlight of
8887 display strings from overlays. (Bug#10464)
8888
9a0115ab 88892012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 8890
b9110d6a 8891 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
8892 * fileio.c (auto_saving_dir_umask): New static var.
8893 (Fmake_directory_internal): Use it.
8894 (do_auto_save_make_dir): Set it, instead of invoking chmod after
8895 creating the directory. The old code temporarily assigns
8896 too-generous permissions to the directory.
8897 (do_auto_save_eh): Clear it.
b9110d6a 8898 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
8899 that the var is always cleared.
8900
6c1bd3f3
EZ
89012012-01-07 Eli Zaretskii <eliz@gnu.org>
8902
8903 * search.c (scan_buffer): Pass character positions to
8904 know_region_cache, not byte positions. (Bug#6540)
8905
069d2b50
L
89062012-01-07 LynX <_LynX@bk.ru> (tiny change)
8907
8908 * w32.c (sys_rename): Report EXDEV when rename of a directory
8909 fails because the target is on another logical disk. (Bug#10284)
8910
75bf0d33
DB
89112012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
8912
8913 * xterm.c (x_embed_request_focus): New function.
8914
8915 * xterm.h: Add prototype.
8916
8917 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
8918
1c6e5a32
GM
89192012-01-05 Glenn Morris <rgm@gnu.org>
8920
8921 * emacs.c (emacs_copyright): Update short copyright year to 2012.
8922
651e947e
EZ
89232012-01-01 Eli Zaretskii <eliz@gnu.org>
8924
8925 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
8926 Load gnutls_transport_set_lowat only if GnuTLS version is below
8927 2.11.1.
8928 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
8929 GnuTLS versions below 2.11.1.
8930
3778cdd8
AL
89312011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
8932
8933 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
8934 to the doc string advising against its use for altering the way
8935 windows are scrolled.
8936
0e5317f7
KH
89372011-12-28 Kenichi Handa <handa@m17n.org>
8938
8939 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
8940 coding-system ASCII compatible only when it does not produce BOM
8941 on encoding (Bug#10383).
8942
93d5ca1f
JD
89432011-12-26 Jan Djärv <jan.h.d@swipnet.se>
8944
8945 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
8946 can scroll.
8947 (create_and_show_popup_menu): Always use menu_position_func for
8948 Gtk3 (Bug#10361).
8949
ca22b785
AS
89502011-12-24 Andreas Schwab <schwab@linux-m68k.org>
8951
8952 * callint.c (Fcall_interactively): Don't truncate prompt string.
8953
d048e1e6
EZ
89542011-12-23 Eli Zaretskii <eliz@gnu.org>
8955
8956 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
8957 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 8958 resumed from there (after widening). (Bug#10360)
d048e1e6 8959
5ccaba1f
JD
89602011-12-22 Jan Djärv <jan.h.d@swipnet.se>
8961
8962 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
8963
204ee57f
JD
89642011-12-21 Jan Djärv <jan.h.d@swipnet.se>
8965
b81d40f0
JB
8966 * nsterm.m (x_free_frame_resources):
8967 Release f->output_data.ns->miniimage.
204ee57f
JD
8968 (ns_index_color): Fix indentation. Do not retain
8969 color_table->colors[i].
8970
8971 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
8972 before returning.
8973
8974 * nsfns.m (x_set_background_color): Assign return value from
8975 ns_index_color to face-background instead of NSColor*.
8976 (ns_implicitly_set_icon_type): Fix indentation.
8977 Change assignment in for loop to comparison.
8978
8979 * emacs.c (ns_pool): New variable.
8980 (main): Assign ns_pool.
8981 (Fkill_emacs): Call ns_release_autorelease_pool.
8982
8983 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
8984 autorelease fdesc, release fdAttrs and tdict.
8985 (ns_get_covering_families): Release charset.
8986 (ns_findfonts): Release NSFontDescriptor created with new.
8987 (ns_uni_to_glyphs): Fix indentation.
8988 (setString): Release attrStr before assigning new value.
8989
c803b2b7
JD
89902011-12-18 Jan Djärv <jan.h.d@swipnet.se>
8991
678f4426
JD
8992 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
8993 and NS_IMPL_COCOA.
8994 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
8995 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
8996
cd394be1 89972011-12-18 David Reitter <reitter@cmu.edu>
678f4426 8998
5fecd5fc
JD
8999 * nsterm.m (ns_term_init): Subscribe for notifications
9000 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
9001 to method trackingNotification in EmacsMenu.
9002
9003 * nsmenu.m (trackingMenu): New variable.
3771cb17 9004 (trackingNotification): New method (from Aquamacs).
5fecd5fc 9005 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 9006 from Aquamacs (Bug#7030).
678f4426
JD
9007
90082011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 9009
c803b2b7
JD
9010 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
9011 (symbol_to_nsstring): Fix indentation.
9012 (ns_symbol_to_pb): New function.
cae07000
SM
9013 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
9014 (Fns_rotate_cut_buffers_internal): Remove.
9015 (Fns_store_selection_internal): Rename from
c803b2b7
JD
9016 Fns_store_cut_buffer_internal.
9017 (ns_get_foreign_selection, Fx_own_selection_internal)
9018 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
9019 (Fns_get_selection_internal, Fns_store_selection_internal):
9020 Use ns_symbol_to_pb and check if return value is nil.
9021 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
9022 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
9023 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
9024 renamed to Sns_store_selection_internal.
9025 (ns_handle_selection_request): Move code to Fx_own_selection_internal
9026 and remove this function.
9027 (ns_handle_selection_clear): Remove, never used.
9028 (Fx_own_selection_internal): Move code from ns_handle_selection_request
9029 here.
9030
e1b01a3a
KB
90312011-12-17 Ken Brown <kbrown@cornell.edu>
9032
9033 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
9034 GID is unknown (Bug#10257).
9035
2adb6e85
PE
90362011-12-17 Paul Eggert <eggert@cs.ucla.edu>
9037
9038 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
9039 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
9040 which caused a build failure on GNU/Linux IA-64. This problem was
9041 introduced by my 2011-10-07 patch.
9042
d1d7b339
JL
90432011-12-15 Juri Linkov <juri@jurta.org>
9044
9045 * image.c (imagemagick_error): New function. (Bug#10112)
9046 (imagemagick_load_image): Comment out `MagickSetResolution' call.
9047 Use `imagemagick_error' where ImageMagick functions return
9048 `MagickFalse'.
9049 (Fimagemagick_types): Add `Fnreverse' to return the list in the
9050 proper order.
9051
100d5755
KH
90522011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9053
9054 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
9055 fill background (Bug#8992).
9056
454592a6
MR
90572011-12-13 Martin Rudalics <rudalics@gmx.at>
9058
9059 * window.c (Vwindow_combination_resize)
9060 (Vwindow_combination_limit): Use t instead of non-nil in
9061 doc-strings.
61d4b438
MR
9062 (Vrecenter_redisplay): Add first sentence of doc-string on
9063 separate line.
53524d93 9064 (Frecenter): Fix doc-string typo.
454592a6 9065
3633e3aa
KH
90662011-12-11 Kenichi Handa <handa@m17n.org>
9067
9068 * coding.c (Funencodable_char_position): Pay attention to the
9069 buffer text relocation (Bug#9389).
9070
7b9d523a 90712011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 9072
7b9d523a
JD
9073 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
9074 gtk_init (Bug#10100).
9075
b73189c6
EZ
90762011-12-10 Eli Zaretskii <eliz@gnu.org>
9077
9078 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
9079 IT->string is nil. (Bug#10263)
9080
f7dfe5d6
JD
90812011-12-10 Jan Djärv <jan.h.d@swipnet.se>
9082
83faebb4
JD
9083 * nsterm.h (x_free_frame_resources): Declare.
9084
f7dfe5d6
JD
9085 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
9086 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
9087
9088 * nsterm.h (ns_get_defaults_value): Declare.
9089
9090 * nsterm.m (ns_default): Call ns_get_defaults_value.
9091
7cd4e72c
EZ
90922011-12-09 Eli Zaretskii <eliz@gnu.org>
9093
9094 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
9095 (Bug#10170)
9096
b34d7317
YM
90972011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9098
9099 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
9100 that where the value of an _OBJC_* symbol points to is in the .bss
9101 section (Bug#10240).
9102
76470ad1
KH
91032011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
9104
9105 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 9106 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 9107
745fff94
KH
91082011-12-08 Kenichi Handa <handa@m17n.org>
9109
9110 * ftfont.c (get_adstyle_property): Fix previous change
9111 (Bug#10233).
9112
6e44397c
JB
91132011-12-07 Juanma Barranquero <lekktu@gmail.com>
9114
9115 * w32.c (init_environment): If no_site_lisp, remove site-lisp
9116 dirs from the default value of EMACSLOADPATH (bug#10208).
9117
7efa6272
GM
91182011-12-07 Glenn Morris <rgm@gnu.org>
9119
9120 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
9121 installation and source directories as well. (Bug#10208)
9122
f6fc4d87
CY
91232011-12-06 Chong Yidong <cyd@gnu.org>
9124
9125 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
9126
2bf26180
GM
91272011-12-06 Glenn Morris <rgm@gnu.org>
9128
9129 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
9130 as an error, not just -1. (Bug#10217)
9131
3a6ad4f0
CY
91322011-12-05 Chong Yidong <cyd@gnu.org>
9133
9134 * keyboard.c (process_special_events): New function.
9135 (swallow_events, Finput_pending_p): Use it (Bug#10195).
9136
75a3b399
PE
91372011-12-05 Paul Eggert <eggert@cs.ucla.edu>
9138
9139 * coding.c (encode_designation_at_bol): Don't use uninitialized
9140 local variable (Bug#9318).
9141
c3c9e25e
KH
91422011-12-05 Kenichi Handa <handa@m17n.org>
9143
9144 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
9145 return Qnil (Bug#8046, Bug#10193).
9146
5eb05ea3
KH
91472011-12-05 Kenichi Handa <handa@m17n.org>
9148
9149 * coding.c (encode_designation_at_bol): New args charbuf_end and
9150 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
9151 (coding_set_source): Return how many bytes coding->source was
9152 relocated.
9153 (coding_set_destination): Return how many bytes
9154 coding->destination was relocated.
9155 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 9156 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
9157
91582011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
9159
9160 * coding.c (CODING_CHAR_CHARSET_P): New macro.
9161 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
9162 macro (Bug#9318).
9163
91642011-12-05 Andreas Schwab <schwab@linux-m68k.org>
9165
9166 The following changes are to fix Bug#9318.
9167
a79703f5 9168 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
9169 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
9170 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 9171 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 9172
7dbda6df
JB
91732011-12-05 Juanma Barranquero <lekktu@gmail.com>
9174
9175 * lisp.h (process_quit_flag): Fix external declaration.
9176
6d5eb5b0
SM
91772011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
9178
9179 Don't macro-inline non-performance-critical code.
9180 * eval.c (process_quit_flag): New function.
9181 * lisp.h (QUIT): Use it.
9182
a0c3fad0
JD
91832011-12-04 Jan Djärv <jan.h.d@swipnet.se>
9184
9185 * nsfns.m (get_geometry_from_preferences): New function.
9186 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
9187
6c07aac2
AS
91882011-12-04 Andreas Schwab <schwab@linux-m68k.org>
9189
9190 * emacs.c (Qkill_emacs): Define.
9191 (syms_of_emacs): Initialize it.
9192 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
9193 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
9194 (quit_throw_to_read_char): Add parameter `from_signal'.
9195 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
9196 * lisp.h (QUIT): Call Fkill_emacs if requested.
9197
c052ead4
JD
91982011-12-03 Jan Djärv <jan.h.d@swipnet.se>
9199
9200 * widget.c (update_wm_hints): Return if wmshell is null.
9201 (widget_update_wm_size_hints): New function.
9202
9203 * widget.h (widget_update_wm_size_hints): Declare.
9204
9205 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
9206 widget_update_wm_size_hints (Bug#10104).
9207
9e49252b
EZ
92082011-12-03 Eli Zaretskii <eliz@gnu.org>
9209
9210 * xdisp.c (handle_invisible_prop): If the invisible text ends just
9211 before a newline, prepare the bidi iterator for consuming the
9212 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 9213 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 9214
02b16839
JL
92152011-12-02 Juri Linkov <juri@jurta.org>
9216
9217 * search.c (Fword_search_regexp): New Lisp function created from
9218 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
9219 (Fword_search_backward, Fword_search_forward)
9220 (Fword_search_backward_lax, Fword_search_forward_lax):
9221 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
9222 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
9223
0068070e
SM
92242011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
9225
9226 * fileio.c (Finsert_file_contents): Move after-change-function call
9227 to before the "handled:" label, since all "goto handled" appear in
9228 cases where the *-change-functions have already been properly called
9229 (bug#10117).
9230
3360a3fc
AS
92312011-12-01 Andreas Schwab <schwab@linux-m68k.org>
9232
9233 * keyboard.c (interrupt_signal): Don't call kill-emacs when
9234 waiting for input. (Bug#10169)
9235
73d6c093
EZ
92362011-11-30 Eli Zaretskii <eliz@gnu.org>
9237
9238 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
9239 verifies glyph row's hash code--we have just reallocated the
9240 glyphs, so their contents can be complete garbage. (Bug#10164)
9241
febe6bea
JB
92422011-11-30 Juanma Barranquero <lekktu@gmail.com>
9243
9244 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
9245
801a4313
EZ
92462011-11-30 Eli Zaretskii <eliz@gnu.org>
9247
9248 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
9249 attributes are tested _before_ calling verify_row_hash, to protect
9250 against GCC re-ordering of the tests. (Bug#10164)
9251
2b56b87e
JD
92522011-11-29 Jan Djärv <jan.h.d@swipnet.se>
9253
9254 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
9255
9256 * xterm.c (handle_one_xevent): Only set async_visible and friends
9257 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 9258 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
9259 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
9260
dbf31225
PE
92612011-11-28 Paul Eggert <eggert@cs.ucla.edu>
9262
9263 Remove GCPRO-related macros that exist only to avoid shadowing locals.
9264 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
9265 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
9266 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9267 All uses changed to use GCPRO1 etc.
9268 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
9269 Revert to old implementation (i.e., before 2011-03-11).
9270
1305621b
YM
92712011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9272
9273 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
9274 of scroll runs so as to avoid assigning disabled bogus rows and
9275 unnecessary graphics copy operations.
9276
8c9afb46
EZ
92772011-11-27 Eli Zaretskii <eliz@gnu.org>
9278
9279 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
9280 (snprintf) [_MSC_VER]: Redirect to _snprintf.
9281 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
9282 (malloc, free, realloc, calloc): Redirect to e_* only when
9283 compiling Emacs.
9284
9285 * lisp.h (GCTYPEBITS): Move before first use.
9286 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
9287 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
9288 this macro definition.
9289
9290 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
9291 _MSC_VER.
9292
54e9e3bf
JD
92932011-11-27 Jan Djärv <jan.h.d@swipnet.se>
9294
6d5eb5b0
SM
9295 * gtkutil.c (xg_create_frame_widgets):
9296 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
9297 present with Gtk+ 2.0.
9298
83aca1cb
PE
92992011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9300
9301 * fileio.c (Finsert_file_contents): Undo previous change; see
9302 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9303
5b76caa4
PE
93042011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9305
9306 Rename locals to avoid shadowing.
9307 * fileio.c (Finsert_file_contents):
9308 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
9309 * process.c (wait_reading_process_output):
9310 Rename inner 'proc' to 'p' to avoid shadowing.
9311 Indent for consistency with usual Emacs style.
9312
8c535114
EZ
93132011-11-25 Eli Zaretskii <eliz@gnu.org>
9314
9315 * xdisp.c (redisplay_window): If cursor row is not fully visible
9316 after recentering, and scroll-conservatively is set to a large
9317 number, scroll window by a few more lines to make the cursor fully
9318 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
9319 (start_display): Don't move to the next line if the display should
9320 start at a newline that is part of a display vector or an overlay
9321 string. (Bug#10119)
8c535114 9322
fa4fdb5c
JL
93232011-11-24 Juri Linkov <juri@jurta.org>
9324
9325 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
9326 after the `MagickPingImage' call. (Bug#10112)
9327
90ec88df
CY
93282011-11-23 Chong Yidong <cyd@gnu.org>
9329
9330 * window.c (Fcoordinates_in_window_p): Accept only live windows.
9331
56e2e794
MR
93322011-11-23 Martin Rudalics <rudalics@gmx.at>
9333
9334 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
9335 making another buffer current. (Bug#10114)
9336
b6e64c41
GM
93372011-11-23 Glenn Morris <rgm@gnu.org>
9338
9339 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
9340
6b21de18
CY
93412011-11-23 Chong Yidong <cyd@gnu.org>
9342
9343 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
9344 using it (Bug#5984).
9345
b12cd789
EZ
93462011-11-22 Eli Zaretskii <eliz@gnu.org>
9347
9348 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
9349 and header-lines, as they don't have one computed for them.
9350 (Bug#10098)
9351
9352 * .gdbinit (prow): Make displayed values more self-explaining.
9353 Add row's hash code.
9354
261b6fd4
LMI
93552011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
9356
9357 * process.c (wait_reading_process_output): Fix asynchrounous
9358 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 9359 (wait_reading_process_output): Add comment and URL.
261b6fd4 9360
e7cfd277
JD
93612011-11-21 Jan Djärv <jan.h.d@swipnet.se>
9362
9363 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
9364
a9b9b7f5
CY
93652011-11-21 Chong Yidong <cyd@gnu.org>
9366
9367 * window.c (Fnext_window, Fprevious_window): Doc fix.
9368
b0d15b4f
SM
93692011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
9370
9371 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
9372
fe7a3057
JB
93732011-11-20 Juanma Barranquero <lekktu@gmail.com>
9374
9375 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
9376
d2999b1a
MR
93772011-11-20 Martin Rudalics <rudalics@gmx.at>
9378
9379 * window.c (Fset_window_combination_limit): Rename argument
9380 STATUS to LIMIT.
9381 (Vwindow_combination_limit): Remove "status" from doc-string.
9382
d5ff9cd0
AS
93832011-11-20 Andreas Schwab <schwab@linux-m68k.org>
9384
9385 * m/ibms390.h: Remove.
9386 * m/ibms390x.h: Don't include "ibms390.h".
9387
a5bb9bd3
SM
93882011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
9389
9390 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
9391 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
9392
cd1181db
JB
93932011-11-20 Juanma Barranquero <lekktu@gmail.com>
9394
9395 * casetab.c (Fset_case_table):
9396 * charset.c (Fcharset_after): Fix typos.
9397
615a3b8d 93982011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 9399
17e845af
PE
9400 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
9401 Otherwise, valgrind does not work on some platforms.
9402 Problem reported by Andreas Schwab in
6a0bf43d
PE
9403 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
9404 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
9405 is set, removing the need for VIRT_ADDRESS_VARIES.
9406 (PURE_P): Use a more-efficient implementation that needs just one
9407 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
9408 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
9409 to 4 (xorl, subq, cmpq, setbe).
9410 * alloc.c (pure): Always extern now, since that's the
9411 VIRT_ADDR_VARIES behavior.
9412 (PURE_POINTER_P): Use a single comparison, not two, for
9413 consistency with the new puresize.h.
9414 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
9415 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
9416 Remove VIRT_ADDR_VARIES no longer needed.
9417
f8fe6f96
EZ
94182011-11-19 Eli Zaretskii <eliz@gnu.org>
9419
9420 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
9421 (erase_phys_cursor, update_window_cursor, show_mouse_face)
9422 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
9423 behave as if the cursor position were at the window margin.
9424
9425 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
9426 and the cursor position is out of bounds, behave as if the cursor
9427 position were at the window margin. (Bug#10075)
9428
df05a53c
CY
94292011-11-18 Chong Yidong <cyd@gnu.org>
9430
9431 * window.c (Fwindow_combination_limit): Make first argument
9432 non-optional, since it is meaningless for live windows like the
9433 selected window.
61ccba97 9434
2071918e
DA
94352011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
9436
9437 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
9438
b50a28de
SM
94392011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
9440
9441 * intervals.c: Fix grafting over the whole buffer (bug#10071).
9442 (graft_intervals_into_buffer): Simplify.
9443
015137db
EZ
94442011-11-18 Eli Zaretskii <eliz@gnu.org>
9445
9446 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
9447 hash values of the two rows.
9448 (copy_row_except_pointers): Preserve the used[] arrays and the
9449 hash values of the two rows. (Bug#10035)
68c95424 9450 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
9451
9452 * xdisp.c (row_hash): New function, body extracted from
9453 compute_line_metrics.
9454 (compute_line_metrics): Call row_hash, instead of computing the
9455 hash code inline.
9456
9457 * dispnew.c (verify_row_hash): Call row_hash for computing the
9458 hash code of a row, instead of duplicating code from xdisp.c.
9459
9460 * dispextern.h (row_hash): Add prototype.
9461
a2addb04
TH
94622011-11-18 Tassilo Horn <tassilo@member.fsf.org>
9463
9464 * frame.c (delete_frame): Don't delete the terminal when the last
9465 X frame is closed if emacs is built with GTK toolkit.
9466
df85d315
JB
94672011-11-17 Juanma Barranquero <lekktu@gmail.com>
9468
9469 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
9470
a0c2d0ae
MR
94712011-11-17 Martin Rudalics <rudalics@gmx.at>
9472
9473 * window.c (Vwindow_splits): Rename to
9474 Vwindow_combination_resize. Suggested by Juri Linkov.
9475 (Fsplit_window_internal): Use Vwindow_combination_resize instead
9476 of Vwindow_splits.
9477
58179cce
JB
94782011-11-16 Juanma Barranquero <lekktu@gmail.com>
9479
7877f373
JB
9480 * nsfns.m (Fns_font_name):
9481 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 9482
b6f67890
MR
94832011-11-16 Martin Rudalics <rudalics@gmx.at>
9484
9485 * window.h (window): Rename slot "nest" to "combination_limit".
9486 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
9487 (Fset_window_nest): Rename to Fset_window_combination_limit.
9488 (Vwindow_nest): Rename to Vwindow_combination_limit.
9489 (recombine_windows, make_parent_window, make_window)
9490 (Fsplit_window_internal, saved_window)
9491 (Fset_window_configuration, save_window_save): Rename all
9492 occurrences of window_nest to window_combination_limit.
9493
c7015153
JB
94942011-11-15 Juanma Barranquero <lekktu@gmail.com>
9495
9496 * image.c (imagemagick_load_image): Fix typo.
9497
322ad6ec
EZ
94982011-11-14 Eli Zaretskii <eliz@gnu.org>
9499
9500 * xdisp.c (display_line): Move the call to
9501 highlight_trailing_whitespace before the call to
9502 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
9503 faces of all the glyphs to compute ROW's hash value.
9504 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 9505
f067b8ec
JB
95062011-11-14 Juanma Barranquero <lekktu@gmail.com>
9507
9508 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
9509 just return (bug#10044).
9510
1e5b2111
EZ
95112011-11-12 Eli Zaretskii <eliz@gnu.org>
9512
7ef3cbd5
EZ
9513 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
9514 with user-defined heap size. Bump the default size of the temacs
9515 heap to 27MB, to avoid memory warning when running temacs.
9516 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
9517
1e5b2111
EZ
9518 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
9519 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
9520 (verify_row_hash) [XASSERTS]: New function.
9521 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
9522 that the hash value of glyph rows is correct.
1e5b2111 9523
89d61221
MR
95242011-11-12 Martin Rudalics <rudalics@gmx.at>
9525
9526 * window.h (window): Remove splits slot.
9527 * window.c (Fwindow_splits, Fset_window_splits): Remove.
9528 (Fdelete_other_windows_internal, make_parent_window)
9529 (make_window, Fsplit_window_internal, Fdelete_window_internal)
9530 (Fset_window_configuration, save_window_save): Don't deal with
9531 split status of windows.
9532 (saved_window): Remove splits slot.
9533 (Vwindow_splits): Rewrite doc-string.
9534
97f18cc8
JD
95352011-11-11 Jan Djärv <jan.h.d@swipnet.se>
9536
9537 * xfns.c (unwind_create_frame):
9538 * nsfns.m (unwind_create_frame):
9539 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
9540 Vframe_list (Bug#9999).
9541
22a648b4
DA
95422011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
9543
0b381c7e 9544 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 9545
659afede
KH
95462011-11-11 Kenichi Handa <handa@m17n.org>
9547
9548 * callproc.c (Fcall_process): Set the member dst_multibyte of
9549 process_coding.
9550
9ac0394b
KH
95512011-11-11 Johan Bockgård <bojohan@gnu.org>
9552
9553 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
9554 avoid a crash (bug#9496).
9555
2fbdc249
CY
95562011-11-09 Chong Yidong <cyd@gnu.org>
9557
9558 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
9559 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
9560
ac6b1f81
PE
95612011-11-08 Paul Eggert <eggert@cs.ucla.edu>
9562
9563 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
9564
09db192c
PE
95652011-11-08 Paul Eggert <eggert@cs.ucla.edu>
9566
9567 Avoid some portability problems by eschewing 'extern inline' functions.
9568 The trivial performance wins aren't worth the portability hassles; see
9569 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
9570 et seq.
9571 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
9572 (window_box_width, window_box_left, window_box_left_offset)
9573 (window_box_right, window_box_right_offset): Undo previous change,
9574 by removing the "extern"s.
9575 * intervals.c (adjust_intervals_for_insertion)
9576 (adjust_intervals_for_deletion): Undo previous change,
9577 making these static again.
9578 (offset_intervals, temp_set_point_both, temp_set_point)
9579 (copy_intervals_to_string): No longer inline.
9580 * xdisp.c (window_text_bottom_y, window_box_width)
9581 (window_box_height, window_box_left_offset)
9582 (window_box_right_offset, window_box_left, window_box_right)
9583 (window_box): No longer inline.
9584
105216ed
CY
95852011-11-08 Chong Yidong <cyd@gnu.org>
9586
9587 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
9588 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
9589 Signal an error if not a live window.
105216ed
CY
9590 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
9591 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
9592
ae9e237f
JB
95932011-11-07 Juanma Barranquero <lekktu@gmail.com>
9594
9595 * lisp.h (syms_of_abbrev): Remove declaration.
9596 Reported by CHENG Gao <chenggao@royau.me>.
9597
c7aa8333
EZ
95982011-11-07 Eli Zaretskii <eliz@gnu.org>
9599
9600 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
9601 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
9602 of temacs in GUI mode.
9603
be7f5545
MR
96042011-11-07 Martin Rudalics <rudalics@gmx.at>
9605
9606 * window.h: Declare delete_all_child_windows instead of
9607 delete_all_subwindows.
9608 * window.c (Fwindow_nest, Fset_window_nest)
9609 (Fset_window_new_total, Fset_window_new_normal)
9610 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
9611 (delete_all_subwindows): Rename to delete_all_child_windows.
9612 (Fdelete_other_windows_internal, Fset_window_configuration):
9613 Call delete_all_child_windows instead of delete_all_subwindows.
9614 * frame.c (delete_frame): Call delete_all_child_windows instead
9615 of delete_all_subwindows.
9616
ca78dc43
PE
96172011-11-07 Paul Eggert <eggert@cs.ucla.edu>
9618
9619 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
9620 This is also needed for porting to any host where GC_MARK_STACK is
9621 not GC_MAKE_GCPROS_NOOPS.
9622 (which_symbols): Use it.
9623
a0241d01
KH
96242011-11-07 Kenichi Handa <handa@m17n.org>
9625
9626 * coding.c (coding_set_destination): Check coding->src_pos only
9627 when coding->src_object is a buffer (bug#9910).
9628
9629 * process.c (send_process): Set the member src_multibyte of coding
9630 to 0 (bug#9911) when sending a unibyte text.
9631
9632 * callproc.c (Fcall_process): Set the member src_multibyte of
9633 process_coding to 0 (bug#9912).
9634
a64bfdfa 96352011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
9636
9637 * xmenu.c (cleanup_widget_value_tree): New function.
9638 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
9639 calling free_menubar_widget_value_tree directly (Bug#9830).
9640
cb41b32a
PE
96412011-11-06 Paul Eggert <eggert@cs.ucla.edu>
9642
9643 Fix some portability problems with 'inline'.
9644 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
9645 (window_box_width, window_box_left, window_box_left_offset)
9646 (window_box_right, window_box_right_offset): Declare extern.
9647 Otherwise, these inline functions do not conform to C99 and
9648 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
9649 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
9650 * intervals.c (adjust_intervals_for_insertion)
9651 (adjust_intervals_for_deletion): Now extern, because otherwise the
9652 extern inline functions 'offset_intervals' couldn't refer to it.
9653 (static_offset_intervals): Remove.
9654 (offset_intervals): Rewrite using the old contents of
9655 static_offset_intervals. The old version didn't conform to C99
9656 because an extern inline function contained a reference to an
9657 identifier with static linkage.
9658
b7041366
AS
96592011-11-06 Andreas Schwab <schwab@linux-m68k.org>
9660
9661 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
9662 GC.
9663
88a37c4d
EZ
96642011-11-06 Eli Zaretskii <eliz@gnu.org>
9665
9666 * xdisp.c (init_iterator, reseat_to_string): Don't set the
9667 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
9668 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
9669 return Qleft_to_right.
9670
49745b39
CY
96712011-11-06 Chong Yidong <cyd@gnu.org>
9672
9673 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
9674 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
9675 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
9676 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
9677 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
9678 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
9679 (Fwindow_vscroll): Doc fix.
9680 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
9681 argument, since it makes no sense to pass a live window and for
9682 consistency with window-child.
9683
1f05cd82
CS
96842011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
9685
9686 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
9687 support MSVC.
9688
22610910
JR
96892011-11-05 Jason Rumney <jasonr@gnu.org>
9690
9691 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
9692 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
9693 fonts (Bug#6029).
9694 (add_font_entity_to_list): Fix logic errors in mixed boolean and
9695 bitwise arithmetic preventing use of unicode-sip and non-truetype
9696 opentype fonts.
9697
a06776b2
EZ
96982011-11-05 Eli Zaretskii <eliz@gnu.org>
9699
3ad924ba
EZ
9700 * s/ms-w32.h (fstat, stat, utime): Move redirections to
9701 "emacs"-only part.
9702
a06776b2
EZ
9703 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
9704 initialization code to keep similarity to xfns.c after changes
9705 from 2011-11-05.
9706
c9e7db78
JD
97072011-11-05 Jan Djärv <jan.h.d@swipnet.se>
9708
a97f8f3f
JD
9709 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
9710 (unwind_create_frame): New function (Bug#9943).
9711 (Fx_create_frame): Restructure code to be more similar to the one in
9712 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
9713 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
9714 Move terminal->reference_count++ just before making the frame official
9715 (Bug#9943).
9716
9717 * nsterm.m (x_free_frame_resources): New function.
9718 (x_destroy_window): Move code to x_free_frame_resources.
9719
c9e7db78 9720 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
9721 (Fx_create_frame, x_create_tip_frame):
9722 Move terminal->reference_count++ just before making the frame
75f1671a 9723 official. Move initialization of image_cache_refcount and
c9e7db78
JD
9724 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
9725
a6fc3b5c
EZ
97262011-11-05 Eli Zaretskii <eliz@gnu.org>
9727
9728 Support MSVC build with newer versions of Visual Studio.
9729 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
9730 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
9731 nt/gmake.defs.
9732
9733 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
9734 which are not supported by MSVC.
9735 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
9736 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
9737 bitfields.
9738 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
9739 types in bitfields.
9740 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
9741
9742 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
9743
58179cce 97442011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
9745
9746 Support MSVC build with newer versions of Visual Studio.
9747 * w32.c: Don't include w32api.h for MSVC.
9748 (init_environment) [_MSC_VER]: Call sys_access, not _access.
9749
9750 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
9751 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
9752 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
9753 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
9754 e_* cousins.
9755 (alloca) [_MSC_VER]: Define to _alloca.
9756
9757 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
9758
9759 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
9760
a58c13ed
EZ
97612011-11-04 Eli Zaretskii <eliz@gnu.org>
9762
9763 * xdisp.c (note_mouse_highlight): If either of
9764 previous/next-single-property-change returns nil, treat that as
9765 the beginning or the end of the buffer. (Bug#9955)
9766
fe0b6370
JD
97672011-11-04 Jan Djärv <jan.h.d@swipnet.se>
9768
a58c13ed 9769 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
9770 label is not null (Bug#9951).
9771 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
9772 may be NULL.
9773
89bd5ee1
EZ
97742011-11-04 Eli Zaretskii <eliz@gnu.org>
9775
9776 * window.c (Fwindow_body_size): Mention in the doc string that the
9777 return value is in frame's canonical units. (Bug#9949)
9778
84c3edb9
EZ
97792011-11-03 Eli Zaretskii <eliz@gnu.org>
9780
4e2fb5c7
EZ
9781 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
9782
84c3edb9 9783 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 9784 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 9785 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 9786
bc17a887
EZ
97872011-11-01 Eli Zaretskii <eliz@gnu.org>
9788
9789 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
9790 Don't stop backward scan on the continuation glyph, even though
9791 its CHARPOS is positive.
6d5eb5b0
SM
9792 (mouse_face_from_buffer_pos, note_mouse_highlight):
9793 Rename cover_string to disp_string.
bc17a887 9794
4ee88440
MR
97952011-11-01 Martin Rudalics <rudalics@gmx.at>
9796
9797 * window.c (temp_output_buffer_show): Don't use
9798 Vtemp_buffer_show_specifiers.
9799 (Vtemp_buffer_show_specifiers): Remove unused variable.
9800
c2ff3c02
EZ
98012011-10-30 Eli Zaretskii <eliz@gnu.org>
9802
9803 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
9804 past the beginning of the current glyph matrix.
9805
58179cce 98062011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
9807
9808 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
9809 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
9810 HAVE_GTK3 (Bug#9869).
b77a6a7f 9811
3b574623
JD
9812 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
9813 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
9814
b77a6a7f
JD
9815 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
9816
9817 * xterm.c: Declare x_handle_net_wm_state to return int.
9818 (handle_one_xevent): Check if we are iconified but don't have
9819 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
9820 (get_current_wm_state): Return non-zero if not hidden,
9821 check for _NET_WM_STATE_HIDDEN (Bug#9893).
9822 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
9823 (x_handle_net_wm_state): Return what get_current_wm_state returns.
9824 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
9825
196e41e4
PE
98262011-10-29 Paul Eggert <eggert@cs.ucla.edu>
9827
9828 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
9829 so that this new function doesn't get optimized away by a
9830 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
9831
021f2e1a
AS
98322011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9833
9834 * frame.h (MOUSE_HL_INFO): Remove excess parens.
9835
8b058d44
EZ
98362011-10-29 Eli Zaretskii <eliz@gnu.org>
9837
9838 Fix the `xbytecode' command.
9839 * .gdbinit (xprintbytestr): New command.
b50a28de 9840 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
9841 (xbytecode): Print the byte-code string as well.
9842
4452fb80
EZ
98432011-10-29 Kim Storm <storm@cua.dk>
9844
8b058d44
EZ
9845 * alloc.c (which_symbols): New function.
9846
21b72067
AS
98472011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9848
9849 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
9850 line. (Bug#9903)
9851
83ed7b5c
GM
98522011-10-29 Glenn Morris <rgm@gnu.org>
9853
9854 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
9855 Not clear what it was for, and it causes various bugs. (Bug#9839)
9856
5a7a728b
EZ
98572011-10-28 Eli Zaretskii <eliz@gnu.org>
9858
9859 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
9860 possible random value that matches one of those tested as
9861 condition to clear the mouse face.
9862
d3d0842f
CY
98632011-10-28 Chong Yidong <cyd@gnu.org>
9864
9865 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
9866
31b39d13
DN
98672011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
9868
9869 * window.c (make_window): Initialize phys_cursor_on_p.
9870
9aba6043
SM
98712011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
9872
9873 * lisp.h (struct Lisp_Symbol): Update comments.
9874
c20992f4
JB
98752011-10-28 Juanma Barranquero <lekktu@gmail.com>
9876
9877 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
9878
db4f02f2
EZ
98792011-10-28 Eli Zaretskii <eliz@gnu.org>
9880
9881 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
9882 <oslsachem@gmail.com> for helping to debug this.
9883
9884 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
9885 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
9886 (g_b_init_get_glyph_outline_w): New static variables.
9887 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
9888 (GetGlyphOutlineW_Proc): New typedefs.
9889 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
9890 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
9891 New functions.
9892 (w32font_open_internal, compute_metrics):
9893 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
9894 instead of calling the "wide" APIs directly.
9895
9896 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
9897
9898 * w32.h (syms_of_w32font): Add prototype.
9899
87e68db4
JB
99002011-10-27 Juanma Barranquero <lekktu@gmail.com>
9901
9902 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
9903 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
9904 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
9905 (Fmove_to_window_line): Doc fix.
9906
435c1d67
CY
99072011-10-27 Chong Yidong <cyd@gnu.org>
9908
9909 * process.c (make_process): Set gnutls_state to NULL.
9910
9911 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
9912 non-NULL, regardless of GNUTLS_INITSTAGE.
9913 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
9914 an error. Set process slots as soon as we allocate them.
9915
9916 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
9917
9c6c6f49
CY
99182011-10-27 Chong Yidong <cyd@gnu.org>
9919
9aba6043
SM
9920 * gnutls.c (emacs_gnutls_deinit): New function.
9921 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
9922 (Fgnutls_deinit, Fgnutls_boot): Use it.
9923
9924 * process.c (make_process): Initialize GnuTLS credentials to NULL.
9925 (deactivate_process): Call emacs_gnutls_deinit.
9926
657d08d3
JB
99272011-10-27 Juanma Barranquero <lekktu@gmail.com>
9928
9929 * image.c (x_create_x_image_and_pixmap):
9930 * w32.c (sys_rename, w32_delayed_load):
9931 * w32font.c (fill_in_logfont):
9932 * w32reg.c (x_get_string_resource): Silence compiler warnings.
9933
5430d399
JB
99342011-10-26 Juanma Barranquero <lekktu@gmail.com>
9935
9936 * w32fns.c (w32_default_color_map): New function,
9937 extracted from Fw32_default_color_map.
a7ef684b 9938 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 9939
fe0055fa
PE
99402011-10-25 Paul Eggert <eggert@cs.ucla.edu>
9941
9942 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
9943
e6346438
SM
99442011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
9945
9946 * keyboard.c (test_undefined): New function (bug#9751).
9947 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
9948
e112cc37
ET
99492011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
9950
9951 * sysdep.c (init_sys_modes): Fix the check for the controlling
9952 terminal (Bug#6649).
9953
7b5d6677
EZ
99542011-10-20 Eli Zaretskii <eliz@gnu.org>
9955
9956 * dispextern.h (struct bidi_it): New member next_en_type.
9957
9958 * bidi.c (bidi_line_init): Initialize the next_en_type member.
9959 (bidi_resolve_explicit_1): When next_en_pos is valid for the
9960 current character, check also for next_en_type being WEAK_EN.
9961 (bidi_resolve_weak): Don't enter the expensive loop if the current
9962 position is before next_en_pos. Record the bidi type of the first
9963 non-ET, non-BN character we find, in addition to its position.
9964 (bidi_level_of_next_char): Invalidate next_en_type when
9965 next_en_pos is over-stepped.
9966
7da0b018
PE
99672011-10-20 Paul Eggert <eggert@cs.ucla.edu>
9968
9969 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
9970 * editfns.c: Rewrite current-time-zone so that it invokes
9971 the equivalent of (format-time-string "%Z") to get the time zone name.
9972 This fixes a bug when the time zone name contains characters that
9973 need converting from the system time locale to Emacs internal format.
9974 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
9975 that patch fixed format-time-string to do the conversion, but
9976 I forgot to fix current-time-zone.
9977 (format_time_string): New function, containing most of
9978 what Fformat_time_string used to contain.
9979 (Fformat_time_string): Rewrite in terms of format_time_string.
9980 This doesn't change this function's behavior.
9981 (current-time-zone): Rewrite to use format_time_string.
9982 This fixes the bug reported by Michael Schierl in
9983 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
9984 Jason Rumney's 2007-06-07 change worked around this bug, but
9985 didn't fix it.
9986 * systime.h (tzname, timezone): Remove no-longer-used declarations.
9987
8547b010
EZ
99882011-10-19 Eli Zaretskii <eliz@gnu.org>
9989
9990 * xdisp.c (start_display): If the character at POS is displayed
9991 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
9992 (try_window_reusing_current_matrix): If a line ends in a display
9993 vector or the next line starts in a display vector, continue
9994 redrawing the window even though the character position of
9995 start_row was reached.
8547b010
EZ
9996 (Bug#9771, part 2)
9997
4e948d15
CY
99982011-10-18 Chong Yidong <cyd@gnu.org>
9999
10000 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
10001 with nobreak-char-display too.
10002
4787455f
EZ
100032011-10-18 Eli Zaretskii <eliz@gnu.org>
10004
10005 Fix part 3 of bug#9771.
10006 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
10007 (bidi_resolve_neutral): Don't enter the expensive loop looking for
10008 non-neutral characters if the current character is a paragraph
10009 separator (a.k.a. Newline). This avoids running the same
10010 expensive loop twice, once when we consume the preceding newline
10011 and the other time when the line actually needs to be displayed.
10012 Avoid the loop when we see neutrals on the base embedding level
10013 following a character whose directionality is the same as the
10014 paragraph's. This avoids running the expensive loop when a line
10015 ends in a long sequence of neutrals, like control characters.
10016 Add assertion against STRONG_AL type. Slightly rearrange code
10017 that determines the type of a neutral given the first non-neutral
10018 that follows it.
10019 (bidi_level_of_next_char): Set next_en_pos to zero when
10020 invalidating its info.
10021
2c91f553
EZ
100222011-10-17 Eli Zaretskii <eliz@gnu.org>
10023
10024 * xdisp.c (push_display_prop): Determine whether to record string
10025 or buffer position by IT->string, not by IT->method. Allow
10026 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
10027 (move_it_vertically_backward): Don't look for character position
10028 immediately after the newline when in a continuation line.
10029 (Bug#9771, part 1)
2c91f553 10030
c7b08b0d
MR
100312011-10-15 Martin Rudalics <rudalics@gmx.at>
10032
10033 * window.c (coordinates_in_window): Rewrite and delabelize
10034 vertical border check. (Bug#5357) (Bug#9618)
10035
6b02f655
SM
100362011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
10037
10038 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
10039 errors in XSetWindowBorder (bug#9310).
10040
81d40c92
DA
100412011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
10042
10043 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
10044 avoid crash when xmalloc overrun checking is enabled.
10045
d4172c3b
EZ
100462011-10-13 Eli Zaretskii <eliz@gnu.org>
10047
10048 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
10049 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
10050 cursor motion with <left> and <right> arrow keys.
10051
10052 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
10053 some callers set that themselves.
10054
b00eea75
EZ
100552011-10-12 Eli Zaretskii <eliz@gnu.org>
10056
10057 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
10058 display string and the previous row comes from the same string and
10059 is empty. (Bug#9739) (Bug#9738)
10060
8fe012c4
SM
100612011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
10062
10063 * doc.c (get_doc_string): Encode file name (bug#9735).
10064
0074aef2
EZ
100652011-10-12 Eli Zaretskii <eliz@gnu.org>
10066
79beb178
EZ
10067 * bidi.c (bidi_level_of_next_char):
10068 * xdisp.c (get_visually_first_element): Remove old incorrect
10069 comments regarding the Unicode Line Separator character.
10070
0074aef2
EZ
10071 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
10072
6e4b3fbe
DA
100732011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
10074
10075 * alloc.c (Fgc_status): Do not access beyond zombies array
10076 boundary if nzombies > MAX_ZOMBIES.
10077 * alloc.c (dump_zombies): Add missing format specifier.
10078
0324f3af
PE
100792011-10-12 Paul Eggert <eggert@cs.ucla.edu>
10080
b5525cac
PE
10081 * xdisp.c (set_cursor_from_row): Simplify conditionals,
10082 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
10083
0324f3af
PE
10084 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
10085 Some packages use them to denote characters with modifiers.
10086
e9b5f888
AS
100872011-10-11 Andreas Schwab <schwab@linux-m68k.org>
10088
10089 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
10090 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
10091 matching a pp-number. Rename parameter var to var1.
10092
127827c0
SM
100932011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
10094
10095 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
10096
c8fd3bd0
GM
100972011-10-08 Glenn Morris <rgm@gnu.org>
10098
10099 * callint.c (Fcall_interactively): Give a more explicit error for the
10100 'c' case with a non-character input. (Bug#8479)
10101
352ec8ff
EZ
101022011-10-08 Eli Zaretskii <eliz@gnu.org>
10103
03669ccb
EZ
10104 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
10105 lines.
7061c986
EZ
10106 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
10107 lines that are hscrolled on the left.
03669ccb 10108
352ec8ff
EZ
10109 * dispnew.c (buffer_posn_from_coords): Account for a possible
10110 presence of header-line. (Bug#4426)
10111
a66cfb1c
SM
101122011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
10113
6b02f655
SM
10114 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
10115 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 10116
7c5ee88e
PE
101172011-10-07 Paul Eggert <eggert@cs.ucla.edu>
10118
10119 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
10120 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
10121 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
10122 this makes Emacs dump core during garbage collection on rare
10123 occasions. sizeof is obviously inferior to offsetof here, so
10124 stick with offsetof.
10125 (GC_POINTER_ALIGNMENT): New macro.
10126 (mark_memory): Omit 3rd (offset) arg; caller changed.
10127 Don't assume EMACS_INT alignment is the same as pointer alignment.
10128
df1bbe5b
SM
101292011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
10130
10131 * keyboard.c (read_key_sequence_remapped): New var.
10132 (read_key_sequence): Compute remapping in the right buffer.
10133 (command_loop_1): Use read_key_sequence's remapping directly.
10134
51553db6
SM
101352011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
10136
32c1fffd
SM
10137 * dired.c (file_name_completion): Don't expand file name.
10138 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
10139 before checking file name handler.
10140
51553db6
SM
10141 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
10142 they've been requested explicitly (bug#9591).
10143
b6bd1599 101442011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
10145
10146 * keymap.c (Fsingle_key_description): Use make_specified_string
10147 instead of build_string to build string from push_key_description.
10148 (Bug#5193)
10149
f701dc2a
PE
101502011-09-30 Paul Eggert <eggert@cs.ucla.edu>
10151
4222c55d
PE
10152 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
10153 This fixes a Y2038 bug on 64-bit hosts.
10154 * buffer.c (reset_buffer):
10155 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
10156 (Fclear_buffer_auto_save_failure):
10157 Use 0, not -1, to represent an unset failure time, since time_t
10158 might not be signed.
10159
f701dc2a
PE
10160 Remove dependency on glibc malloc internals.
10161 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10162 Move back here from lisp.h, but with their new implementations.
10163 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10164 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
10165 * charset.c (charset_table_init): New static var.
10166 (syms_of_charset): Use it instead of xmalloc. This removes a
10167 dependency on glibc malloc internals. See Eli Zaretskii's comment in
10168 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
10169 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10170 Move back to alloc.c.
10171 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10172 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
10173
9ceebf39
JD
101742011-09-30 Jan Djärv <jan.h.d@swipnet.se>
10175
10176 * nsterm.m (windowDidResize): Call x_set_window_size only when
10177 ns_in_resize is true. Otherwise set pixelwidth/height and
10178 call change_frame_size (Bug#9628).
10179
cb993c58
PE
101802011-09-30 Paul Eggert <eggert@cs.ucla.edu>
10181
3930c88b
PE
10182 Port --enable-checking=all to Fedora 14 x86-64.
10183 * charset.c (syms_of_charset): Also account for glibc malloc's
10184 internal overhead when calculating the initial malloc maximum.
10185
cb993c58
PE
10186 Port --enable-checking=all to Fedora 14 x86.
10187 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10188 Move to lisp.h.
10189 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
10190 (overrun_check_realloc, overrun_check_free):
10191 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
10192 That way, xmalloc returns a properly-aligned pointer even if
10193 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
10194 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
10195 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
10196 into account when calculating the initial malloc maximum.
10197 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10198 Move here from alloc.c, so that charset.c can use it too.
10199 Properly align; the old code wasn't right for common 32-bit hosts
10200 when configured with --enable-checking=all.
10201 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10202 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
10203
31bed486
EZ
102042011-09-29 Eli Zaretskii <eliz@gnu.org>
10205
04c70788 10206 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
10207 use EDOM.
10208
fbcaa2f3
EZ
102092011-09-28 Eli Zaretskii <eliz@gnu.org>
10210
10211 * xdisp.c (compute_display_string_end): If there's no display
10212 string at CHARPOS, return -1.
10213
10214 * bidi.c (bidi_fetch_char): When compute_display_string_end
10215 returns a negative value, treat the character as a normal
10216 character not covered by a display string. (Bug#9624)
10217
a239d4e9
JB
102182011-09-28 Juanma Barranquero <lekktu@gmail.com>
10219
10220 * lread.c (Fread_from_string): Fix typo in docstring.
10221
88652fd5
EZ
102222011-09-27 Eli Zaretskii <eliz@gnu.org>
10223
10224 * xdisp.c (handle_invisible_prop): If invisible text ends on a
10225 newline, reseat the iterator instead of bidi-iterating there one
10226 character at a time. (Bug#9610)
32c1fffd
SM
10227 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
10228 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 10229
ed497dd4
AS
102302011-09-27 Andreas Schwab <schwab@linux-m68k.org>
10231
10232 * lread.c (readevalloop): Use correct code for NBSP.
10233 (read1): Likewise. (Bug#9608)
10234
b2bf61aa
MA
102352011-09-25 Michael Albinus <michael.albinus@gmx.de>
10236
10237 * dbusbind.c (Fdbus_register_signal): When service is not
10238 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
10239
32bbb17c
GM
102402011-09-25 Glenn Morris <rgm@gnu.org>
10241
10242 * buffer.c (truncate-lines): Doc fix.
10243
94e0933e
CY
102442011-09-24 Chong Yidong <cyd@stupidchicken.com>
10245
10246 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
10247 (Fset_window_next_buffers): Doc fix.
10248
cddde921
GM
102492011-09-24 Glenn Morris <rgm@gnu.org>
10250
10251 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
10252
1260aef1
PE
102532011-09-24 Paul Eggert <eggert@cs.ucla.edu>
10254
25b4bfa0
PE
10255 Fix minor problems found by static checking.
10256 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
10257 * indent.c (Fvertical_motion): Fix == vs = typo.
10258
e3cbd34b
EZ
102592011-09-24 Eli Zaretskii <eliz@gnu.org>
10260
a66cfb1c
SM
10261 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
10262 Default value is now t. Doc fix.
6bf7006f 10263
e3cbd34b 10264 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 10265 logic when moving up, not only when moving down. Fix the
e3cbd34b 10266 confusing name and values of the it_overshoot_expected variable;
32c1fffd 10267 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
10268
10269 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
10270 CHARPOS is covered by a display string which includes newlines.
10271 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
10272 is covered by a display string with embedded newlines.
10273
a3de0cbd
MA
102742011-09-24 Michael Albinus <michael.albinus@gmx.de>
10275
10276 * dbusbind.c (Fdbus_register_signal): Add match rule to
10277 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
10278 (Fdbus_register_method, Vdbus_registered_objects_table):
10279 Fix docstring.
a3de0cbd 10280
b260039d
JM
102812011-09-24 Jim Meyering <meyering@redhat.com>
10282
32c1fffd 10283 do not ignore write error for any output size
b260039d
JM
10284 The previous change was incomplete.
10285 While it makes emacs --batch detect the vast majority of stdout
10286 write failures, errors were still ignored whenever the output size is
10287 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
10288 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
10289 && echo FAIL: ignored write error
10290 FAIL: ignored write error
10291 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
10292 && echo FAIL: ignored write error
10293 FAIL: ignored write error
10294 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
10295
8eca8a7c
AS
102962011-09-23 Andreas Schwab <schwab@linux-m68k.org>
10297
10298 * emacs.c (Fkill_emacs): In noninteractive mode exit
10299 non-successfully if a write error occurred on stdout. (Bug#9574)
10300
3341db62
EZ
103012011-09-21 Eli Zaretskii <eliz@gnu.org>
10302
10303 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
10304 the xassert test.
10305
10306 * dispextern.h (struct it): Update the comment documenting what
10307 can it->OBJECT be.
10308
8c203dbf
EZ
103092011-09-20 Eli Zaretskii <eliz@gnu.org>
10310
10311 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
10312 a display string, extend search for cursor position to end of row.
10313 (find_row_edges): If the row ends in a newline from a display
10314 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
10315 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
10316 (Fcurrent_bidi_paragraph_direction): Fix search for previous
10317 non-empty line. Fixes confusing cursor motion with arrow keys at
10318 the beginning of a line that starts with whitespace.
8c203dbf 10319
a4824228
LMI
103202011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10321
10322 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
10323 (bug#9493).
10324
33ed493b
CY
103252011-09-18 Chong Yidong <cyd@stupidchicken.com>
10326
10327 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
10328 boolean (Bug#9154).
10329
56cd55c8
EZ
103302011-09-18 Eli Zaretskii <eliz@gnu.org>
10331
10332 * xdisp.c (display_line): Record maximum and minimum buffer
10333 positions even if no glyphs were produced (e.g., by a zero-width
10334 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
10335 buffer positions that will be removed from the glyph row because
10336 they don't fit.
c02dcedf
EZ
10337 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
10338 column is beyond frame width: don't subtract 1 "pixel" when
10339 computing width of the stretch.
3e62b7e0
EZ
10340 (reseat_at_next_visible_line_start): Undo the change made on
10341 2011-09-17 that saved paragraph information and restored it after
10342 the call to `reseat'. (Bug#9545)
56cd55c8 10343
5ed99d36 103442011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
10345
10346 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
10347 and turn window cursor on if cleared (Bug#9415).
10348
5ed99d36 103492011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
10350
10351 * search.c (boyer_moore): Take unibyte characters from pattern
10352 literally. (Bug#9458)
10353
9bade7b2
EZ
103542011-09-18 Eli Zaretskii <eliz@gnu.org>
10355
10356 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
10357
e5e9d610
PE
103582011-09-18 Paul Eggert <eggert@cs.ucla.edu>
10359
87e4427a
PE
10360 Fix minor problem found by static checking.
10361 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
10362 initialized, to pacify gcc -Wuninitialized.
10363
e5e9d610
PE
10364 * fileio.c: Report proper errno when syscall falls.
10365 (Finsert_file_contents): Save and restore errno,
10366 so that report_file_error outputs the correct diagnostic.
10367 (Fwrite_region) [CLASH_DETECTION]: Likewise.
10368
a1674f0b
EZ
103692011-09-18 Eli Zaretskii <eliz@gnu.org>
10370
10371 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
10372
fbfb6dd4
EZ
103732011-09-17 Eli Zaretskii <eliz@gnu.org>
10374
10375 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
10376 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
10377
bb187662
EZ
103782011-09-17 Eli Zaretskii <eliz@gnu.org>
10379
1137e8b8 10380 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 10381 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
10382
10383 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
10384 (bidi_find_paragraph_start): Search back for paragraph beginning
10385 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
10386 (bidi_move_to_visually_next): Only trigger paragraph-related
10387 computations when the last character is a newline or at EOB, not
10388 just any NEUTRAL_B. (Bug#9470)
10389
bb187662
EZ
10390 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
10391 truncated lines if point is covered by a display string. (Bug#9524)
10392
2e621251
PE
103932011-09-16 Paul Eggert <eggert@cs.ucla.edu>
10394
10395 * xselect.c: Relax test for outgoing X longs (Bug#9498).
10396 (cons_to_x_long): New function.
10397 (lisp_data_to_selection_data): Use it. Correct the test for
10398 short-versus-long data; it was negated. Break out of vector
10399 loop, for efficiency, when a long datum is discovered.
10400
91a15bc6
SM
104012011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
10402
10403 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
10404
b41c3a35
EZ
104052011-09-16 Eli Zaretskii <eliz@gnu.org>
10406
10407 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
10408 GCC PR/17406) by declaring this function with external scope.
10409
7812ba2d
PE
104102011-09-15 Paul Eggert <eggert@cs.ucla.edu>
10411
10412 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
10413 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
10414
cf7edc2a
AS
104152011-09-15 Andreas Schwab <schwab@linux-m68k.org>
10416
10417 * editfns.c (Fformat): Correctly handle text properties on "%%".
10418
bd01620e
EZ
104192011-09-15 Eli Zaretskii <eliz@gnu.org>
10420
10421 * xterm.c (x_draw_composite_glyph_string_foreground):
10422 * w32term.c (x_draw_composite_glyph_string_foreground):
10423 * term.c (encode_terminal_code):
10424 * composite.c (composition_update_it, get_composition_id):
10425 * xdisp.c (get_next_display_element)
10426 (fill_composite_glyph_string): Add comments about special meaning
10427 of TAB characters in a composition.
10428
a02719a3
PE
104292011-09-15 Paul Eggert <eggert@cs.ucla.edu>
10430
10431 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
10432 This occurs when processing a multibyte format.
10433 Problem reported by Wolfgang Jenker.
a02719a3 10434
72589a3c
JB
104352011-09-15 Johan Bockgård <bojohan@gnu.org>
10436
10437 * xdisp.c (try_cursor_movement): Only check for exact match if
10438 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
10439
1c14176c
PE
104402011-09-14 Paul Eggert <eggert@cs.ucla.edu>
10441
10442 Remove unused external symbols.
10443 * dispextern.h (calc_pixel_width_or_height): Remove decl.
10444 * xdisp.c (calc_pixel_width_or_height): Now static.
10445 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
10446 * indent.c (check_display_width):
10447 * w32term.c: Fix comment to match code.
10448 * xterm.c, xterm.h (x_catching_errors): Remove.
10449
d2eea5b5
PE
104502011-09-14 Paul Eggert <eggert@cs.ucla.edu>
10451
10452 * xselect.c: Use signed conversions more consistently (Bug#9498).
10453 (selection_data_to_lisp_data): Assume incoming selection data are
10454 signed integers, not unsigned. This is to be consistent with
10455 outgoing selection data, which was modified to use signed integers
10456 in as part of the fix to Bug#9196 in response to Jan D.'s comment
10457 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
10458 expects long, not unsigned long.
10459
46888499
EZ
104602011-09-14 Eli Zaretskii <eliz@gnu.org>
10461
10462 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
10463 computation of loop end. Reported by Johan Bockgård
10464 <bojohan@gnu.org>.
10465
ef8ef9fb
CY
104662011-09-13 Chong Yidong <cyd@stupidchicken.com>
10467
10468 * frame.c (Fother_visible_frames_p): Function deleted.
10469
fa819fed
EZ
104702011-09-12 Eli Zaretskii <eliz@gnu.org>
10471
10472 * indent.c (compute_motion): Process display vector front to back
10473 rather than the other way around. (Bug#2496)
10474
2ba8e008
SM
104752011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
10476
10477 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
10478
20f53c69
CY
104792011-09-11 Chong Yidong <cyd@stupidchicken.com>
10480
10481 * minibuf.c (Fread_from_minibuffer): Doc fix.
10482
d562d7a4
EZ
104832011-09-11 Eli Zaretskii <eliz@gnu.org>
10484
10485 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
10486 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
10487
1c4d7f3d
LMI
104882011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
10489
10490 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
10491 value for non-existent files.
10492
b885bf36
EZ
104932011-09-11 Eli Zaretskii <eliz@gnu.org>
10494
10495 * fileio.c (Finsert_file_contents): If the file cannot be opened,
10496 set its "size" to -1. This will set the modtime_size field of
10497 the corresponding buffer to -1, which is what
10498 verify-visited-file-modtime expects for files that do not exist.
10499 (Bug#9139)
10500
6612f0bf
PE
105012011-09-11 Paul Eggert <eggert@cs.ucla.edu>
10502
10503 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
10504 here ...
10505 * lisp.h: ... from here. push_key_description is no longer
10506 defined in keyboard.c, so its declaration should not be in
10507 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
10508 logically belongs with push_key_description.
10509
dfb3f755
PE
105102011-09-10 Paul Eggert <eggert@cs.ucla.edu>
10511
10512 * buffer.h: Include <sys/types.h> instead of <time.h>.
10513 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
10514 Problem reported by Herbert J. Skuhra.
10515
3134906c
LMI
105162011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
10517
10518 * xml.c (parse_region): Make the parsing work for
10519 non-comment-starting XML files again (bug#9144).
10520
8d903f4e
AS
105212011-09-10 Andreas Schwab <schwab@linux-m68k.org>
10522
10523 * image.c (gif_load): Fix calculation of bottom and right corner.
10524 (Bug#9468)
10525
80ad64f4
EZ
105262011-09-10 Eli Zaretskii <eliz@gnu.org>
10527
10528 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
10529 redisplay in small windows.
10530
208a048d
EZ
105312011-09-09 Eli Zaretskii <eliz@gnu.org>
10532
10533 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
10534
9b1c252e
MR
105352011-09-08 Martin Rudalics <rudalics@gmx.at>
10536
10537 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
10538 Operate on live windows only.
10539
2949f33b
JB
105402011-09-08 Juanma Barranquero <lekktu@gmail.com>
10541
10542 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
10543
e08dcafd
EZ
105442011-09-07 Eli Zaretskii <eliz@gnu.org>
10545
10546 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
10547 only under bidi iteration.
10548
115b96bd
JD
105492011-09-07 Jan Djärv <jan.h.d@swipnet.se>
10550
10551 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
10552
c8199d0f
PE
105532011-09-06 Paul Eggert <eggert@cs.ucla.edu>
10554
10555 isnan: Fix porting problem to Solaris 10 with bundled gcc.
10556 Without this fix, the command to link temacs failed due to an
10557 undefined symbol __builtin_isnan. This is because
10558 /usr/include/iso/math_c99.h #defines isnan(x) to
10559 __builtin_isnan(x), but the bundled gcc, which identifies itself
10560 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
10561 a __builtin_isnan.
10562 * floatfns.c (isnan): #undef, and then #define to a clone of
10563 what's in data.c.
10564 (Fisnan): Always define, since it's always available now.
10565 (syms_of_floatfns): Always define isnan at the Lisp level.
10566
e39b275c 105672011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
10568
10569 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
10570
b2db44d9 105712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 10572
f4af5137 10573 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
10574 The previous code assumed that file offsets (off_t values) fit in
10575 EMACS_INT variables, which is not true on typical 32-bit hosts.
10576 The code messed up by falsely reporting buffer overflow in cases
10577 such as (insert-file-contents "big" nil 1 2) into an empty buffer
10578 when "big" contains more than 2**29 bytes, even though this
10579 inserts just one byte and does not overflow the buffer.
10580 (Finsert_file_contents): Store file offsets as off_t
10581 values, not as EMACS_INT values. Check for overflow when
10582 converting between EMACS_INT and off_t. When checking for
10583 buffer overflow or for overlap, take the offsets into account.
10584 Don't use EMACS_INT for small values where int suffices.
10585 When checking for overlap, fix a typo: ZV was used where
10586 ZV_BYTE was intended.
10587 (Fwrite_region): Don't assume off_t fits into 'long'.
10588 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
10589
ecfc0a49
MA
105902011-09-05 Michael Albinus <michael.albinus@gmx.de>
10591
10592 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
10593
6511acf2 105942011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 10595
0999621a 10596 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
10597
10598 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 10599 (esprintf, exprintf, evxprintf): New functions.
62f19c19 10600 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 10601 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
10602 (modify_event_symbol): Do not assume that the length of
10603 name_alist_or_stem is safe to alloca and fits in int.
10604 (Fexecute_extended_command): Likewise for function name and binding.
10605 (Frecursion_depth): Wrap around reliably on integer overflow.
10606 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
10607 since some callers pass EMACS_INT values.
10608 (Fsingle_key_description): Don't crash if symbol name contains more
10609 than MAX_ALLOCA bytes.
10610 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
10611 (get_minibuffer): Arg is now EMACS_INT, not int.
10612 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 10613 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
10614 * window.h (command_loop_level, minibuf_level): Reflect API changes.
10615
2be7d702
PE
10616 * dbusbind.c (signature_cat): New function.
10617 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
10618 Do not overrun buffer; instead, report string overflow.
10619
9d1df220
PE
10620 * dispnew.c (add_window_display_history): Don't overrun buffer.
10621 Truncate instead; this is OK since it's just a log.
10622
33ef5c64
PE
10623 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
10624 even if the time zone offset is outlandishly large.
10625 Don't mishandle offset == INT_MIN.
10626
66c6fdd5
PE
10627 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
10628 when creating daemon; the previous buffer-overflow check was incorrect.
10629
d749b01b
PE
10630 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
10631 which has the guts of the old verror function.
10632
b5cd1905
PE
10633 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
10634 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
10635
6e1a67fb
PE
10636 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
10637 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 10638 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 10639 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
10640 length of string rather than counting it via multiple sprintfs;
10641 that's simpler and more reliable.
c21721cc
PE
10642 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
10643 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
10644 sprintf, in case result does not fit in int.
10645
c57b67fc
PE
10646 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
10647 (fontset_from_font): Print it.
10648
8a401434
PE
10649 * frame.c (tty_frame_count): Now printmax_t, not int.
10650 (make_terminal_frame, set_term_frame_name): Print it.
10651 (x_report_frame_params): In X, window IDs are unsigned long,
10652 not signed long, so print them as unsigned.
10653 (validate_x_resource_name): Check for implausibly long names,
10654 and don't assume name length fits in 'int'.
10655 (x_get_resource_string): Don't blindly alloca invocation name;
10656 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
10657 not fit in int.
10658
6e1a67fb
PE
10659 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
10660 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
10661 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
10662
0df02bf3
PE
10663 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
10664 Use esprintf, not sprintf, in case result does not fit in int.
10665
48e30793
PE
10666 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
10667 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
10668 it as a large positive number.
10669 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
10670 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
10671
a66ff6d8
PE
10672 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
10673 in case result does not fit in int.
10674
aca216ff
PE
10675 * print.c (float_to_string): Detect width overflow more reliably.
10676 (print_object): Make sprintf buffer a bit bigger, to avoid potential
10677 buffer overrun. Don't assume list length fits in 'int'. Treat
10678 print length of 0 as 0, not as infinity; to be consistent with other
10679 uses of print length in this function. Don't overflow print length
10680 index. Don't assume hash table size fits in 'long', or that
10681 vectorlike size fits in 'unsigned long'.
10682
31c286f7
PE
10683 * process.c (make_process): Use printmax_t, not int, to format
10684 process-name gensyms.
10685
55e5faa1
PE
10686 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
10687
80f2e268
PE
10688 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
10689 to avoid potential buffer overrun.
10690
670741ab
PE
10691 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
10692 if X resource line is longer than 512 bytes.
10693
b7163a50
PE
10694 * xfns.c (x_window): Make sprintf buffer a bit bigger
10695 to avoid potential buffer overrun.
10696
ae58ff1f
PE
10697 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
10698
c43c8a6a
PE
10699 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
10700
3f8236f4
PE
107012011-09-04 Paul Eggert <eggert@cs.ucla.edu>
10702
53e9fe90 10703 Integer overflow fixes for scrolling, etc.
6511acf2
PE
10704 Without these, Emacs silently mishandles large integers sometimes.
10705 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
10706 it were "C-u 1 M-x recenter" on a typical 64-bit host.
10707
6511acf2
PE
10708 * xdisp.c (try_window_id): Check Emacs fixnum range before
10709 converting to 'int'.
806add1d 10710
6511acf2 10711 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
10712 Check that an Emacs fixnum is in range before assigning it to 'int'.
10713 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
10714 values converted from Emacs fixnums.
10715 (Frecenter): Don't wrap around a line count if it is out of 'int'
10716 range; instead, treat it as an extreme value.
10717 (Fset_window_configuration, compare_window_configurations):
10718 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
10719
6511acf2
PE
10720 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
10721 that can exceed INT_MAX. Check that EMACS_INT value is in range
10722 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
10723 (match_limit): Don't assume that a fixnum can fit in 'int'.
10724
6511acf2 10725 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
10726 exceed INT_MAX.
10727
6511acf2 10728 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
10729 (Fvertical_motion): Don't wrap around LINES values that don't fit
10730 in 'int'. Instead, treat them as extreme values. This is good
10731 enough for windows, which can't have more than INT_MAX lines anyway.
10732
fcb901a7
LMI
107332011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10734
0f2f6b6d
LMI
10735 * Require libxml/parser.h to avoid compilation warning.
10736
fcb901a7
LMI
10737 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
10738
10739 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
10740 since this reportedly can destroy thread storage.
10741
6e20a0d4
CY
107422011-08-30 Chong Yidong <cyd@stupidchicken.com>
10743
10744 * syntax.c (find_defun_start): Update all cache variables if
10745 exiting early (Bug#9401).
10746
148ae00e
EZ
107472011-08-30 Eli Zaretskii <eliz@gnu.org>
10748
f6cfbd8f
EZ
10749 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
10750
148ae00e
EZ
10751 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
10752 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
10753 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
10754
10755 * term.c (tty_append_glyph): New function.
10756 (produce_stretch_glyph): Static function and its prototype deleted.
10757
a66cfb1c
SM
10758 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
10759 Add prototypes.
148ae00e 10760
c4a07a4c
PE
107612011-08-29 Paul Eggert <eggert@cs.ucla.edu>
10762
10763 * image.c (parse_image_spec): Check for nonnegative, not for positive,
10764 when checking :margin (Bug#9390).
10765 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 10766 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
10767 so that the name doesn't mislead. All uses changed.
10768
6bc8cd65
JB
107692011-08-28 Johan Bockgård <bojohan@gnu.org>
10770
10771 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
10772 set_tty_hooks.
10773
dca4927e
EZ
107742011-08-27 Eli Zaretskii <eliz@gnu.org>
10775
10776 * xdisp.c (move_it_to): Don't bail out early when reaching
10777 position beyond to_charpos, if we are scanning backwards.
10778 (move_it_vertically_backward): When DY == 0, make sure we get to
10779 the first character in the line after the newline.
10780
f2cad773
PE
107812011-08-27 Paul Eggert <eggert@cs.ucla.edu>
10782
10783 * ccl.c: Improve and simplify overflow checking (Bug#9196).
10784 (ccl_driver): Do not generate an out-of-range pointer.
10785 (Fccl_execute_on_string): Remove unnecessary check for
10786 integer overflow, noted by Stefan Monnier in
10787 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
10788 Remove a FIXME that didn't need fixing.
10789 Simplify the newly-introduced buffer reallocation code.
10790
0cae2cdb
JB
107912011-08-27 Juanma Barranquero <lekktu@gmail.com>
10792
10793 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
10794
5fc295a4 107952011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 10796
70c60eb2 10797 Integer and memory overflow issues (Bug#9196).
726e0ab1 10798
d31850da
PE
10799 * doc.c (get_doc_string): Rework so that
10800 get_doc_string_buffer_size is the actual buffer size, rather than
10801 being 1 less than the actual buffer size; this makes xpalloc more
10802 convenient.
10803
a69fbedb
PE
10804 * image.c (x_allocate_bitmap_record, cache_image):
10805 * xselect.c (Fx_register_dnd_atom):
10806 Simplify previous changes by using xpalloc.
10807
fe5c5d37
PE
10808 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
10809 since either will do and ptrdiff_t is convenient with xpalloc.
10810
0065d054
PE
10811 * charset.c (charset_table_size)
10812 (struct charset_sort_data.priority): Now ptrdiff_t.
10813 (charset_compare): Don't overflow if priorities differ greatly.
10814 (Fsort_charsets): Don't assume list length fits in int.
10815 Check for size-calculation overflow when allocating sort data.
10816 (syms_of_charset): Allocate an initial charset table that is
10817 just under 64 KiB, to avoid problems with glibc malloc and mmap.
10818
10819 * cmds.c (internal_self_insert): Check for size-calculation overflow.
10820
10821 * composite.h (struct composition.glyph_len): Now int, not unsigned.
10822 The actual value is always <= INT_MAX, and leaving it unsigned made
10823 overflow checking harder.
10824
10825 * dispextern.h (struct glyph_matrix.rows_allocated)
10826 (struct face_cache.size): Now ptrdiff_t, for convenience in use
10827 with xpalloc. The values are still always <= INT_MAX.
10828
10829 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
10830
10831 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
10832 (SAFE_NALLOCA): New macro.
10833
10834 * region-cache.c (struct boundary.pos, find_cache_boundary)
10835 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
10836 (set_cache_region, invalidate_region_cache)
10837 (revalidate_region_cache, know_region_cache, region_cache_forward)
10838 (region_cache_backward, pp_cache):
10839 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
10840 so that ptrdiff_t * can be passed to xpalloc.
10841 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
10842 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
10843 (pp_cache): Don't assume cache_len fits in int.
10844 * region-cache.h: Adjust extern decls to match.
10845
10846 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
10847 EMACS_INT, since either will do, for xpalloc.
10848
10849 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
10850 (xnmalloc, xnrealloc, xpalloc): New functions.
10851
726e0ab1
PE
10852 * bidi.c (bidi_shelve_header_size): New constant.
10853 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
10854 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
10855
51f30bc5 10856 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
10857 * buffer.c (overlays_at, overlays_in, record_overlay_string)
10858 (overlay_strings):
10859 Don't update size of array until after memory allocation succeeds,
10860 because xmalloc/xrealloc may not return.
0065d054
PE
10861 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
10862 now that we have proper integer overflow checking.
10863 (record_overlay_string, overlay_strings): Catch overflows when
10864 calculating size of overlay_str_buf.
726e0ab1 10865
0065d054
PE
10866 * callproc.c (Fcall_process): Check for size overflow when
10867 calculating size of args2.
10868 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
10869 Normally we prefer signed values, but sticking with ptrdiff_t would
10870 require adding more-complicated checks.
726e0ab1
PE
10871
10872 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
10873 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
10874 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 10875 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
10876
10877 * character.c (Fstring): Check for size-calculation overflow.
10878
10879 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
10880 unnecessary integer overflow. Check for size overflow.
10881 (encode_coding_object): Don't update size until xmalloc succeeds.
10882
10883 * composite.c (get_composition_id): Check for overflow in glyph
10884 length calculations.
10885
10886 Integer and memory overflow fixes for display code.
10887 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
10888 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
10889 (scrolling_window): Check for overflow in size calculations.
10890 (line_draw_cost, realloc_glyph_pool, add_row_entry):
10891 Don't assume glyph table len fits in int.
10892 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
10893 (row_table_size): Now ptrdiff_t, not int.
10894 (scrolling_window): Avoid overflow in size calculations.
10895 Don't update size until allocation succeeds.
10896 * fns.c (concat): Check for overflow in size calculations.
10897 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
10898 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
10899 (NEXT_ALMOST_PRIME_LIMIT): New constant.
10900
10901 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
10902 (get_doc_string): Check for size calculation overflow.
10903 Don't update size until allocation succeeds.
10904 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
10905 EMACS_INT, where ptrdiff_t will do.
10906 (Fsubstitute_command_keys): Check for string overflow.
10907
10908 * editfns.c (set_time_zone_rule): Don't assume environment length
10909 fits in int.
10910 (message_length): Now ptrdiff_t, not int.
10911 (Fmessage_box): Don't update size until allocation succeeds.
10912 Don't assume message length fits in int.
10913 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
10914
0065d054
PE
10915 * emacs.c (main): Do not reallocate argv, since there is a null at
10916 the end that can be overwritten, and this way there's no need to
10917 worry about size-calculation overflow.
10918 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
10919
10920 * eval.c (init_eval_once, grow_specpdl): Don't update size until
10921 alloc succeeds.
10922 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
10923
10924 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
10925 (x_set_scroll_bar_width, x_figure_window_size):
10926 Check for integer overflow.
10927 (x_set_alpha): Do not assume XINT fits in int.
10928
10929 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
10930 This is for the members text_lines, text_cols, total_lines, total_cols,
10931 where the system imposes an 'int' limit.
10932
10933 * fringe.c (Fdefine_fringe_bitmap):
10934 Don't update size until alloc works.
10935
10936 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
10937 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
10938
10939 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
10940 Check for size-calculation overflow.
10941 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
10942 do, as we prefer signed integers.
10943 (id_to_widget.max_size, id_to_widget.used)
10944 (xg_store_widget_in_map, xg_remove_widget_from_map)
10945 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
10946 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
10947 Use and return ptrdiff_t, not int.
10948 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
10949 * gtkutil.h: Change prototypes to match the above.
10950
10951 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
10952 are duplicate now that they've been promoted to lisp.h.
10953 (x_allocate_bitmap_record, x_alloc_image_color)
10954 (make_image_cache, cache_image, xpm_load):
10955 Don't update size until alloc is done.
10956 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
10957 (x_detect_edges):
3256efce 10958 Check for size calculation overflow.
726e0ab1
PE
10959 (ct_colors_allocated_max): New constant.
10960 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
10961 overflow.
3256efce 10962
726e0ab1
PE
10963 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
10964 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
10965 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
10966 Use ptrdiff_t, not int, to count maps.
10967 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
10968 calculations. Don't update size until allocation succeeds.
10969 Redo calculations to avoid overflow.
726e0ab1
PE
10970 * keyboard.h: Change prototypes to match the above.
10971
10972 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
10973 to count maps.
10974 (current_minor_maps): Check for size calculation overflow.
10975 * keymap.h: Change prototypes to match the above.
10976
10977 * lread.c (read1, init_obarray): Don't update size until alloc done.
10978
10979 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
10980 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
10981
726e0ab1
PE
10982 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
10983 Now ptrdiff_t, not int.
10984 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
10985 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
10986
10987 * process.c (Fnetwork_interface_list): Check for overflow
10988 in size calculation.
10989
10990 * region-cache.c (move_cache_gap): Check for size calculation overflow.
10991
10992 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
10993 overflow. Don't bother calling xmalloc when xrealloc will do.
10994
10995 * search.c (Freplace_match): Check for size calculation overflow.
10996 (Fset_match_data): Don't assume list lengths fit in 'int'.
10997
10998 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
10999 for command line length. Do not attempt to address one before the
11000 beginning of an array, as that's not portable.
11001
11002 * term.c (max_frame_lines): Remove; unused.
11003 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
11004 not int.
11005 (encode_terminal_code, calculate_costs): Check for size
11006 calculation overflow.
11007 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
11008 table lengths and related sizes. Don't update size until alloc
11009 done. Redo calculations to avoid overflow.
11010 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
11011
11012 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
11013 subtracting pointers.
11014 (gobble_line): Check for overflow more carefully. Don't update size
11015 until alloc done.
11016
11017 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
11018 Don't update size until alloc done.
11019 Redo size calculations to avoid overflow.
11020 Check for size calculation overflow.
0065d054 11021 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
11022
11023 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
11024 Use ptrdiff_t, not int, for sizes.
11025 (store_mode_line_noprop_char): Don't update size until alloc done.
11026
0065d054
PE
11027 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
11028 Use ptrdiff_t, not int, for sizes.
11029 (Finternal_make_lisp_face, cache_face):
11030 Check for size calculation overflow.
11031 (cache_face): Treat size calculation overflows as if they were
11032 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
11033
11034 * xfns.c (x_encode_text, x_set_name_internal)
11035 (Fx_change_window_property): Use ptrdiff_t, not int, to count
11036 sizes, since they can exceed INT_MAX in size. Check for size
11037 calculation overflow.
11038
0065d054
PE
11039 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
11040 (xg_select): Check for size calculation overflow.
726e0ab1
PE
11041 Don't update size until alloc done.
11042
0065d054 11043 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 11044 as sprintf is limited to int lengths.
1d526e2f 11045
252c5ee1
PE
11046 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
11047 (X_LONG_MIN): New macros.
864d7ce7
PE
11048 Use them to make the following changes clearer.
11049 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
11050 This change doesn't affect the value now, but it may help remind
11051 future maintainers not to raise the value too much later.
11052 (SELECTION_QUANTUM): Remove, replacing with ...
11053 (selection_quantum): ... new function, which avoids overflow.
11054 All uses changed.
11055 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
11056 assumption that selection length fits in 'int'.
11057 (x_reply_selection_request, x_handle_selection_request)
11058 (x_get_window_property, receive_incremental_selection)
11059 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
11060 (lisp_data_to_selection_data, clean_local_selection_data):
11061 Use ptrdiff_t, not int, to record length of selection.
11062 (x_reply_selection_request, x_get_window_property)
11063 (receive_incremental_selection, x_property_data_to_lisp):
11064 Redo calculations to avoid overflow.
11065 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 11066 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
11067 something.
11068 (x_get_window_property, receive_incremental_selection)
11069 (lisp_data_to_selection_data, x_property_data_to_lisp):
11070 Check for size-calculation overflow.
11071 (x_get_window_property, receive_incremental_selection)
11072 (lisp_data_to_selection_data, Fx_register_dnd_atom):
11073 Don't store size until memory allocation succeeds.
11074 (x_get_window_property): Plug memory leak on memory exhaustion.
11075 Don't double-block input; malloc is safe here. Don't assume 2**34
11076 - 4 fits in unsigned long. Add an xassert to check
11077 XGetWindowProperty overflow. Be more careful about overflow
11078 calculations, and distinguish size from memory overflow better.
11079 (receive_incremental_selection): When tracing, don't assume
11080 unsigned int is less than INT_MAX.
11081 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
11082 harmful) conversions of unsigned short to int.
11083 (lisp_data_to_selection_data): Don't assume that integers
11084 in the range -65535 through -1 fit in an X unsigned short.
11085 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
11086 result parameters unless successful. Rely on cons_to_unsigned
11087 to report problems with elements; the old code wasn't right anyway.
11088 (x_check_property_data): Check for int overflow; we cannot use
11089 a wider type due to X limits.
11090 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
11091
726e0ab1 11092 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 11093
0065d054
PE
11094 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
11095 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
11096 (x_color_cells): Don't store size until memory allocation succeeds.
11097 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 11098 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
11099 (x_term_init): Don't assume length fits in int (sprintf is limited
11100 to int size).
bc18e09d 11101
ebfa62c0
PE
11102 Use ptrdiff_t for composition IDs.
11103 * character.c (lisp_string_width):
11104 * composite.c (composition_table_size, n_compositions)
11105 (get_composition_id, composition_gstring_from_id):
11106 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
11107 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
11108 * window.c (Frecenter):
11109 Use ptrdiff_t, not int, for composition IDs.
11110 * composite.c (get_composition_id): Check for integer overflow.
11111 * composite.h: Adjust prototypes to match the above changes.
11112
d3411f89
PE
11113 Use ptrdiff_t for hash table indexes.
11114 * category.c (hash_get_category_set):
11115 * ccl.c (ccl_driver):
11116 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
11117 * coding.c (coding_system_charset_list, detect_coding_system):
11118 * coding.h (struct coding_system.id):
11119 * composite.c (get_composition_id, gstring_lookup_cache):
11120 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
11121 * image.c (xpm_get_color_table_h):
11122 * lisp.h (hash_lookup, hash_put):
11123 * minibuf.c (Ftest_completion):
11124 Use ptrdiff_t for hash table indexes, not int (which is too
11125 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
11126 32-bit --with-wide-int hosts).
11127
e097a6fa
PE
11128 * charset.c (Fdefine_charset_internal): Check for integer overflow.
11129 Add a FIXME comment about memory leaks.
11130 (syms_of_charset): Don't assume xmalloc returns.
11131
5637687f
PE
11132 Don't assume that stated character widths fit in int.
11133 * character.c (Fchar_width, c_string_width, lisp_string_width):
11134 * character.h (CHAR_WIDTH):
11135 * indent.c (MULTIBYTE_BYTES_WIDTH):
11136 Use sanitize_char_width to avoid undefined and/or bad behavior
11137 with outlandish widths.
a66cfb1c 11138 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
11139 now that we have two such functions. All uses changed.
11140 (sanitize_char_width): New inline function.
11141
a2271ba2
PE
11142 Don't assume that tab-width fits in int.
11143 * character.h (sanitize_width): New inline function.
11144 (SANE_TAB_WIDTH): New macro.
11145 (ASCII_CHAR_WIDTH): Use it.
11146 * indent.c (sane_tab_width): Remove. All uses replaced by
11147 SANE_TAB_WIDTH (current_buffer).
11148 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
11149
18c52557
PE
11150 * fileio.c: Integer overflow issues with file modes.
11151 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
11152
caeeedc1
PE
11153 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
11154 Remove unreachable code.
11155 (read_hex, load_charset_map_from_file): Check for integer overflow.
11156
6df6ae42 11157 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
11158 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
11159 (x_send_scroll_bar_event): Likewise. Check that the size does not
11160 exceed limits imposed by XClientMessageEvent, as well as the usual
11161 ptrdiff_t and size_t limits.
11162
b13995db
PE
11163 * keyboard.c: Overflow, signedness and related fixes.
11164 (make_lispy_movement): Use same integer type in forward decl
11165 that is used in the definition.
11166 (read_key_sequence, keyremap_step):
11167 Change bufsize argument back to int, undoing my 2011-03-30 change.
11168 We prefer signed types, and int is wide enough here.
11169 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
11170 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
11171 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
11172 length, not size_t. Use ptrdiff_t for index, not int.
11173 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
11174 possibility of integer overflow.
11175
13464394
PE
11176 Overflow, signedness and related fixes for images.
11177
11178 * dispextern.h (struct it.stack[0].u.image.image_id)
11179 (struct_it.image_id, struct image.id, struct image_cache.size)
11180 (struct image_cache.used, struct image_cache.ref_count):
11181 * gtkutil.c (update_frame_tool_bar):
11182 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
11183 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
11184 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
11185 * nsmenu.m (update_frame_tool_bar):
11186 * xdisp.c (calc_pixel_width_or_height):
11187 * xfns.c (image_cache_refcount):
11188 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
11189 on typical 64-bit hosts.
11190
11191 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
11192 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
11193 Omit unnecessary casts to int.
11194 (parse_image_spec): Check that integers fall into 'int' range
11195 when the callers expect that.
11196 (image_ascent): Redo ascent calculation to avoid int overflow.
11197 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
11198 (lookup_image): Remove unnecessary tests.
11199 (xbm_image_p): Locals are now of int, not EMACS_INT,
11200 since parse_image_check makes sure they fit into int.
11201 (png_load, gif_load, svg_load_image):
11202 Prefer int to unsigned where either will do.
11203 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
11204 old tiff_error_handler and tiff_warning_handler.
11205 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
11206 stack buffer overflows. It uses only the features of vsnprintf
11207 that are common to both POSIX and native Microsoft.
11208 (tiff_error_handler, tiff_warning_handler): Use it.
11209 (tiff_load, gif_load, imagemagick_load_image):
11210 Don't assume :index value fits in 'int'.
11211 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
11212 (imagemagick_load_image): Check that crop parameters fit into
11213 the integer types that MagickCropImage accepts. Don't assume
11214 Vimagemagick_render_type has a nonnegative value. Don't assume
11215 size_t fits in 'long'.
11216 (gs_load): Use printmax_t to print the widest integers possible.
11217 Check for integer overflow when computing image height and width.
11218
c11821d4
EZ
112192011-08-26 Eli Zaretskii <eliz@gnu.org>
11220
11221 * xdisp.c (redisplay_window): Don't force window start if point
11222 will be invisible in the resulting window. (Bug#9324)
11223
0c95fcf7
EZ
112242011-08-25 Eli Zaretskii <eliz@gnu.org>
11225
11226 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
11227 the display spec is of the form `(space ...)'.
11228 (handle_display_spec): Return the value returned by
11229 handle_single_display_spec, not just 1 or zero.
11230 (handle_single_display_spec): If the display spec is of the form
11231 `(space ...)', and specifies display in the text area, return 2
11232 rather than 1.
fee65a97 11233 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
11234 accurately, and prefer exact match for point under bidi.
11235 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
11236
11237 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
11238 into disp_prop; all users changed.
11239
11240 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
11241 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
11242 for the text covered by the display property.
11243
e4ed06f1
CY
112442011-08-25 Chong Yidong <cyd@stupidchicken.com>
11245
11246 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
11247 Change return value to nil.
11248 (Frecord_buffer): Delete unused function.
11249
f67cdd7f
EZ
112502011-08-24 Eli Zaretskii <eliz@gnu.org>
11251
5980d4c6
EZ
11252 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
11253 buffers, return left-to-right.
8610fe8b
EZ
11254 (set_cursor_from_row): Consider candidate row a win if its glyph
11255 represents a newline and point is on that newline. Fixes cursor
11256 positioning on the newline at EOL of R2L text within L2R
11257 paragraph, and vice versa.
11258 (try_cursor_movement): Check continued rows, in addition to
11259 continuation rows. Fixes unwarranted scroll when point enters a
11260 continued line of R2L text within an L2R paragraph, or vice versa.
11261 (cursor_row_p): Consider the case of point being equal to
11262 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
11263 from the end of a short line to the beginning of a continued line
11264 of R2L text within L2R paragraph.
11265 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
11266 composed characters.
5980d4c6 11267
f67cdd7f
EZ
11268 * bidi.c (bidi_check_type): Use xassert.
11269 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
11270 members.
11271
bca633fb
EZ
112722011-08-23 Eli Zaretskii <eliz@gnu.org>
11273
11274 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
11275 a character.
11276
4a5885a7
CY
112772011-08-23 Chong Yidong <cyd@stupidchicken.com>
11278
11279 * nsfont.m (ns_otf_to_script): Fix typo.
11280
0902a04e
KH
112812011-08-22 Kenichi Handa <handa@m17n.org>
11282
11283 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
11284 extra slot even if the purpose is char-code-property-table.
11285
1a2e6670
EZ
112862011-08-23 Eli Zaretskii <eliz@gnu.org>
11287
8ddde651
EZ
11288 * xdisp.c (redisplay_window): When computing centering_position,
11289 account for the height of the header line. (Bug#8874)
11290
425cc014
EZ
11291 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
11292 instead of CHAR_TO_BYTE. Fixes a crash when a completion
11293 candidate is selected by the mouse, and that candidate has a
11294 composed character under the mouse.
11295
1a2e6670
EZ
11296 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
11297 coordinates reported by pos-visible-in-window-p for a composed
11298 character in column zero.
11299
8b76d6f8
SM
113002011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
11301
11302 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
11303
dac347dd
EZ
113042011-08-22 Eli Zaretskii <eliz@gnu.org>
11305
11306 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
11307 consider it a hit if to_charpos is anywhere in the range of the
11308 composed buffer positions.
11309
e013fb34
CY
113102011-08-22 Chong Yidong <cyd@stupidchicken.com>
11311
11312 * image.c (gif_load): Don't assume that each subimage has the same
11313 dimensions as the base image. Handle disposal method that is
11314 "undefined" by the gif spec (Bug#9335).
11315
bd1ba3e8
CY
113162011-08-20 Chong Yidong <cyd@stupidchicken.com>
11317
11318 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 11319 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 11320
54a1215b
EZ
113212011-08-19 Eli Zaretskii <eliz@gnu.org>
11322
823564e5
EZ
11323 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
11324 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
11325 from an Org mode buffer to a Speedbar frame.
11326
54a1215b
EZ
11327 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
11328 a composition, take its buffer position from IT->cmp_it.charpos.
11329 Fixes cursor positioning at the beginning of a line that begins
11330 with a composed character.
11331
9778ebcc
EZ
113322011-08-18 Eli Zaretskii <eliz@gnu.org>
11333
0be6ee06
EZ
11334 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
11335 character bidirectional type, use STRONG_L instead. Fixes crashes
11336 in a buffer produced by `describe-categories'.
11337
9778ebcc
EZ
11338 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
11339 members before the level stack, so they would be saved and
11340 restored when copying iterator state. Fixes incorrect reordering
11341 around TABs covered by display properties.
11342
156bffbe
AS
113432011-08-18 Andreas Schwab <schwab@linux-m68k.org>
11344
6b02f655 11345 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 11346
72ad093b
CY
113472011-08-17 Chong Yidong <cyd@stupidchicken.com>
11348
11349 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
11350 (internal_condition_case_2, internal_condition_case_n):
11351 Remove unnecessary aborts (Bug#9081).
72ad093b 11352
35774242
EZ
113532011-08-17 Eli Zaretskii <eliz@gnu.org>
11354
11355 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
11356 has no `load' handler, try opening the file locally. (Bug#9311)
11357
db76dd85
KB
113582011-08-16 Ken Brown <kbrown@cornell.edu>
11359
11360 * gmalloc.c: Expand comment.
11361
b215eee5
EZ
113622011-08-16 Eli Zaretskii <eliz@gnu.org>
11363
11364 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
11365 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
11366
a4579d33
KB
113672011-08-16 Ken Brown <kbrown@cornell.edu>
11368
11369 Fix memory allocation problems in Cygwin build (Bug#9273).
11370
11371 * unexcw.c ( __malloc_initialized): Declare external variable.
11372 (fixup_executable): Force the dumped emacs to reinitialize malloc.
11373
8b76d6f8
SM
11374 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
11375 New variables.
a4579d33
KB
11376 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
11377 dumped emacs.
11378 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
11379 in the static heap.
11380 [CYGWIN] (special_realloc): New function.
11381 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
11382 requests to realloc storage in the static heap.
11383
3ebec551
PE
113842011-08-15 Paul Eggert <eggert@cs.ucla.edu>
11385
11386 * bidi.c (bidi_initialize): Remove unused local.
11387
9fd8be00
EZ
113882011-08-15 Eli Zaretskii <eliz@gnu.org>
11389
6b02f655
SM
11390 * bidimirror.h:
11391 * biditype.h: Remove file.
11392 * makefile.w32-in ($(BLD)/bidi.$(O)):
11393 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
11394
11395 * dispextern.h: Fix a typo in the comment to bidi_type_t.
11396
11397 * chartab.c: Improve commentary for the uniprop_table API.
11398
32413314
EZ
11399 * bidi.c (bidi_paragraph_init): Support zero value of
11400 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
11401 (bidi_initialize): Use uniprop_table instead of including
11402 biditype.h and bidimirror.h.
32413314 11403
9fd8be00
EZ
11404 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
11405 coordinates of the iterator when restoring from ppos_it.
11406 (Bug#9296)
11407
5cf2b69b
KH
114082011-08-14 Kenichi Handa <handa@m17n.org>
11409
11410 * process.c (create_process): Call setup_process_coding_systems
72ad093b 11411 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 11412
daf17d00
EZ
114132011-08-14 Eli Zaretskii <eliz@gnu.org>
11414
11415 * xdisp.c (move_it_in_display_line_to): Don't invoke
11416 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
11417 ppos_it. Fixes vertical cursor motion when line beginning is
11418 covered by an image. (Bug#9296)
11419
08e3161a
JD
114202011-08-14 Jan Djärv <jan.h.d@swipnet.se>
11421
11422 * nsterm.h (ns_run_ascript): Declare.
11423 (NSAPP_DATA2_RUNASSCRIPT): Define.
11424
11425 * nsfns.m (as_script, as_result, as_status): New static variables.
11426 (ns_run_ascript): New function.
5e617bc2 11427 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
11428 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
11429 the event loop. Get status from as_status (Bug#7276).
11430
11431 * nsterm.m (sendEvent): If event is NSApplicationDefined and
11432 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
11433 the event loop (Bug#7276).
11434
a3720aa2
AS
114352011-08-14 Andreas Schwab <schwab@linux-m68k.org>
11436
11437 * gnutls.c (QCgnutls_bootprop_priority)
11438 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
11439 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
11440 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
11441 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
11442 (QCgnutls_bootprop_verify_hostname_error)
11443 (QCgnutls_bootprop_callbacks_verify): Rename from
11444 Qgnutls_bootprop_..., all uses changed.
11445
11446 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
11447 uses changed.
11448
0a0d27fb
PE
114492011-08-14 Paul Eggert <eggert@cs.ucla.edu>
11450
19d5c50c
PE
11451 * xfaces.c (Qframe_set_background_mode): Now static.
11452 * dispextern.h (Qframe_set_background_mode): Remove decl.
11453
0a0d27fb
PE
11454 * process.c (Fnetwork_interface_info): Declare local only if needed.
11455
377538cb
JD
114562011-08-13 Jan Djärv <jan.h.d@swipnet.se>
11457
11458 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
11459 (Fnetwork_interface_list): Allocate in increments of bytes instead
11460 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
11461 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
11462 sockaddr.
11463 (struct ifflag_def): notrailers is smart on OSX.
11464 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
11465 Get hardware address with getifaddrs if available.
11466
08fff70c
EZ
114672011-08-12 Eli Zaretskii <eliz@gnu.org>
11468
11469 * xdisp.c (iterate_out_of_display_property): xassert that
11470 IT->position is set to within IT->object's boundaries. Break from
11471 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
11472 when IT->position is set up wrongly due to some bug.
11473 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
11474 (push_display_prop): Allow GET_FROM_STRING as IT->method on
11475 entry. Force push_it to save on the stack the current
11476 buffer/string position, to be restored by pop_it. Fix flags in
11477 the iterator structure wrt the object coming from a display
11478 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
11479 properties. (Bug#9284)
11480
7be1c708 114812011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 11482
7be1c708
CY
11483 * fontset.c (fontset_get_font_group): Add proper type checks.
11484 (Bug#9172)
aac0c6e3 11485
7be1c708 114862011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 11487
7be1c708
CY
11488 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
11489 and LC_VERSION_MIN_MACOSX.
11490 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
11491 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 11492
97bb72a6
EZ
114932011-08-08 Eli Zaretskii <eliz@gnu.org>
11494
11495 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
11496 no-display-properties-and-no-overlays under bidi display.
11497 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 11498 properties and overlays.
97bb72a6 11499
d5617611
CY
115002011-08-08 Chong Yidong <cyd@stupidchicken.com>
11501
37e11a63
CY
11502 * editfns.c (Fset_time_zone_rule): Document relationship with the
11503 setenv function.
11504
d5617611
CY
11505 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
11506 the font entity extracted from the cache (Bug#8109).
11507
58872834
CY
115082011-08-07 Chong Yidong <cyd@stupidchicken.com>
11509
11510 * composite.c (autocmp_chars): Don't reset point. That is done by
11511 restore_point_unwind (Bug#5984).
11512
75bfc667
JL
115132011-08-07 Juri Linkov <juri@jurta.org>
11514
11515 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
11516 to show the arg `TIME' instead of `TIMEVAL'.
11517
d1410150
EZ
115182011-08-06 Eli Zaretskii <eliz@gnu.org>
11519
11520 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
11521 display property strides EOL and includes a newline, as in
11522 longlines-mode. (Bug#9254)
75b771e4
EZ
11523 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
11524 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
11525
11526 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
11527 is non-zero, even if the data buffer is NULL. Fixes a crash in
11528 vertical-motion with longlines-mode. (Bug#9254)
11529
35928349
EZ
115302011-08-05 Eli Zaretskii <eliz@gnu.org>
11531
ec7cc85b
EZ
11532 * bidi.c <bidi_cache_total_alloc>: Now static.
11533 (bidi_initialize): Initialize bidi_cache_total_alloc.
11534
8b76d6f8 11535 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
11536 cache. (Bug#9221)
11537
11538 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
11539 amount allocated this far in `bidi_cache_total_alloc'.
11540 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
11541 non-zero, only free the data buffer without restoring the cache
11542 contents. All callers changed.
11543
11544 * dispextern.h (bidi_unshelve_cache): Update prototype.
11545
11546 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
11547 (move_it_in_display_line, move_it_to)
11548 (move_it_vertically_backward, move_it_by_lines): Replace the call
11549 to xfree to an equivalent call to bidi_unshelve_cache.
11550 (move_it_in_display_line_to): Fix logic of returning
412b6358 11551 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 11552
e2e2423b
EZ
115532011-08-05 Eli Zaretskii <eliz@gnu.org>
11554
11555 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
11556 came from a string character with a `cursor' property. (Bug#9229)
11557
ae9e757a
JD
115582011-08-04 Jan Djärv <jan.h.d@swipnet.se>
11559
11560 * Makefile.in (LIB_PTHREAD): New variable.
11561 (LIBES): Add LIB_PTHREAD (Bug#9216).
11562
11563 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
11564 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
11565
213bd7f2
AS
115662011-08-04 Andreas Schwab <schwab@linux-m68k.org>
11567
6b02f655 11568 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 11569
99aaf75f
JD
115702011-08-04 Jan Djärv <jan.h.d@swipnet.se>
11571
11572 * xterm.c (x_find_topmost_parent): New function.
11573 (x_set_frame_alpha): Find topmost parent window with
11574 x_find_topmost_parent and set the property there also (bug#9181).
11575 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
11576
c74e9d86
PE
115772011-08-04 Paul Eggert <eggert@cs.ucla.edu>
11578
11579 * callproc.c (Fcall_process): Avoid vfork clobbering
11580 the local vars buffer, coding_systems, current_dir.
11581
640c8776
SM
115822011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
11583
11584 * keymap.c (Fmake_composed_keymap): Move to subr.el.
11585
f26d0e4c
PE
115862011-08-03 Paul Eggert <eggert@cs.ucla.edu>
11587
8a10d76c
PE
11588 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
11589 so that it is not optimized away.
11590
f26d0e4c
PE
11591 * xdisp.c (compute_display_string_pos): Remove unused local.
11592
55439c61
EZ
115932011-08-02 Eli Zaretskii <eliz@gnu.org>
11594
11595 Fix slow cursor motion and scrolling in large buffers with
11596 selective display, like Org Mode buffers. (Bug#9218)
11597
11598 * dispextern.h (struct bidi_it): New member disp_prop_p.
11599
11600 * xdisp.c: Remove one-slot cache of display string positions.
11601 (compute_display_string_pos): Accept an additional argument
5e617bc2 11602 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
11603 for a display string or property. If found, set DISP_PROP_P
11604 non-zero.
11605
11606 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
11607 DISP_PROP_P, and pass it to compute_display_string_pos.
11608 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
11609 non-zero. All callers of bidi_fetch_char changed.
11610
fb33fa43
SM
116112011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
11612
11613 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
11614
b099e063
DM
116152010-12-03 Don March <don@ohspite.net>
11616
11617 * keymap.c (Fdefine_key): Fix non-prefix key error message when
11618 last character M-[char] is translated to ESC [char] (bug#7541).
11619
5cc7f7af
KH
116202011-08-02 Kenichi Handa <handa@m17n.org>
11621
d0fffa3f 11622 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
11623
11624 * chartab.c (uniprop_table): Make it non-static.
11625
525d5e6e
EZ
116262011-08-01 Eli Zaretskii <eliz@gnu.org>
11627
11628 * xdisp.c (forward_to_next_line_start): Accept additional argument
11629 BIDI_IT_PREV, and store into it the state of the bidi iterator had
11630 on the newline.
11631 (reseat_at_next_visible_line_start): Use the bidi iterator state
11632 returned by forward_to_next_line_start to restore the state of
11633 it->bidi_it after backing up to previous newline. (Bug#9212)
11634
31011111
AS
116352011-07-30 Andreas Schwab <schwab@linux-m68k.org>
11636
11637 * regex.c (re_comp): Protoize.
11638 (re_exec): Fix return type.
11639 (regexec): Fix type of `ret'. (Bug#9203)
11640
476371c4
PE
116412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11642
e5d76069
PE
11643 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
11644 This is needed if max-image-size is a floating-point number.
11645
9a79b20c
AS
116462011-07-28 Andreas Schwab <schwab@linux-m68k.org>
11647
11648 * print.c (print_object): Print empty symbol as ##.
11649
11650 * lread.c (read1): Read ## as empty symbol.
11651
d8c2fa78
AA
116522011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
11653
11654 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
11655 setting frame foreground color (Bug#9175).
11656 (x_set_background_color): Likewise.
11657
ffe57a7a
AA
11658 * nsmenu.m (-setText): Size tooltip dimensions precisely to
11659 contents (Bug#9176).
11660 (EmacsTooltip -init): Remove bezels and add shadows to
11661 tooltip windows.
11662
bf3492a5
AA
11663 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
11664 or scroll bar (Bug#8470).
11665
d55e9c53
AA
11666 * nsfont.m (nsfont_open): Remove assignment to voffset and
11667 unnecessary vars hshink, expand, hd, full_height, min_height.
11668 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
11669
11670 * nsterm.h (nsfont_info): Remove voffset field.
11671
d8c2fa78 116722011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
11673
11674 Implement strike-through and overline on NextStep (Bug#8863).
11675
11676 * nsfont.m (nsfont_open): Use underline position provided by font,
11677 instead of hard-coded value of 2.
11678 (nsfont_draw): Call ns_draw_text_decoration instead.
11679
11680 * nsterm.h: Add declaration for ns_draw_text_decoration.
11681
11682 * nsterm.m (ns_draw_text_decoration): New function for drawing
11683 underline, overline, and strike-through.
11684 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
11685 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 11686 accommodate underlining, etc.
4843aac3 11687
4cc60b9b
EZ
116882011-07-28 Eli Zaretskii <eliz@gnu.org>
11689
bc7ece87
EZ
11690 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
11691 default.
4cc60b9b 11692
476371c4
PE
116932011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11694
66606eea
PE
11695 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
11696 Without this fix, if a signal arrives just after memory fills up,
11697 'malloc' might be invoked reentrantly.
11698
476371c4
PE
11699 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
11700 In other words, assume that every image size is allowed, on non-X
11701 hosts. This assumption is probably wrong, but it lets Emacs compile.
11702
f3fcc40d
AS
117032011-07-28 Andreas Schwab <schwab@linux-m68k.org>
11704
11705 * regex.c (re_iswctype): Convert return values to boolean.
11706
350c992f
EZ
117072011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
11708
11709 * xdisp.c (compute_display_string_pos): Don't use cached display
11710 string position if the buffer had its restriction changed.
11711 (Bug#9184)
11712
5266b4bb
PE
117132011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11714
11715 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11716
2573a837 117172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 11718
41f55ccd 11719 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 11720
39e378da
PE
11721 * bidi.c: Integer size and overflow fixes.
11722 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
11723 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
11724 (bidi_cache_find_level_change, bidi_cache_ensure_space)
11725 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
11726 (bidi_find_other_level_edge):
11727 Use ptrdiff_t instead of EMACS_INT where either will do.
11728 This works better on 32-bit hosts configured --with-wide-int.
11729 (bidi_cache_ensure_space): Check for size-calculation overflow.
11730 Use % rather than repeated addition, for better worst-case speed.
11731 Don't set bidi_cache_size until after xrealloc returns, because it
11732 might not return.
11733 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
11734 (bidi_cache_ensure_space): Also check that the bidi cache size
11735 does not exceed that of the largest Lisp string or buffer. See Eli
11736 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 11737
5e927815
PE
11738 * alloc.c (__malloc_size_t): Remove.
11739 All uses replaced by size_t. See Andreas Schwab's note
11740 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
11741
ca4aa935
PE
11742 * image.c: Improve checking for integer overflow.
11743 (check_image_size): Assume that f is nonnull, since
11744 it is always nonnull in practice. This is one less thing to
11745 worry about when checking for integer overflow later.
11746 (x_check_image_size): New function, which checks for integer
11747 overflow issues inside X.
11748 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
11749 This removes the need for a memory_full check.
11750 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
11751 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
11752 (xbm_read_bitmap_data): Change locals back to 'int', since
11753 their values must fit in 'int'.
11754 (xpm_load_image, png_load, tiff_load):
11755 Invoke x_create_x_image_and_pixmap earlier,
11756 to avoid much needless work if the image is too large.
11757 (tiff_load): Treat overly large images as if
11758 x_create_x_image_and_pixmap failed, not as malloc failures.
11759 (gs_load): Use x_check_image_size.
11760
5f8f9cc2
PE
11761 * gtkutil.c: Omit integer casts.
11762 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
11763 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
11764
5adf60bc
PE
11765 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
11766
c8907a93
PE
11767 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
11768 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
11769 would wrongly return t on a 64-bit host.
11770
e3c25c68
PE
11771 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
11772 The plain *_OVERFLOW macros run afoul of GCC bug 49705
11773 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
11774 and therefore cause GCC to emit a bogus diagnostic in some cases.
11775
3f791afe
PE
11776 * image.c: Integer signedness and overflow and related fixes.
11777 This is not an exhaustive set of fixes, but it's time to
11778 record what I've got.
11779 (lookup_pixel_color, check_image_size): Remove redundant decls.
11780 (check_image_size): Don't assume that arbitrary EMACS_INT values
11781 fit in 'int', or that arbitrary 'double' values fit in 'int'.
11782 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
11783 (tiff_load, imagemagick_load_image):
11784 Check for overflow in size calculations.
11785 (x_create_x_image_and_pixmap): Remove unnecessary test for
11786 xmalloc returning NULL; that can't happen.
11787 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
11788 (xpm_color_bucket): Use better integer hashing function.
11789 (xpm_cache_color): Don't possibly over-allocate memory.
11790 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
11791 (gif_memory_source):
11792 Use ptrdiff_t, not int or size_t, to record sizes.
11793 (png_load): Don't assume values greater than 2**31 fit in 'int'.
11794 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
11795 either works, as we prefer signed integers.
11796 (tiff_read_from_memory, tiff_write_from_memory):
11797 Return tsize_t, not size_t, since that's what the TIFF API wants.
11798 (tiff_read_from_memory): Don't fail simply because the read would
11799 go past EOF; instead, return a short read.
11800 (tiff_load): Omit no-longer-needed casts.
11801 (Fimagemagick_types): Don't assume size fits into 'int'.
11802
3cc5a532
PE
11803 Improve hashing quality when configured --with-wide-int.
11804 * fns.c (hash_string): New function, taken from sxhash_string.
11805 Do not discard information about ASCII character case; this
11806 discarding is no longer needed.
11807 (sxhash-string): Use it. Change sig to match it. Caller changed.
11808 * lisp.h: Declare it.
11809 * lread.c (hash_string): Remove, since we now use fns.c's version.
11810 The fns.c version returns a wider integer if --with-wide-int is
11811 specified, so this should help the quality of the hashing a bit.
11812
b312a492
PE
11813 * emacs.c: Integer overflow minor fix.
11814 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
11815 Define only if GNU_LINUX.
11816 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
11817
dfd153ae
PE
11818 * dispnew.c: Integer signedness and overflow fixes.
11819 Remove unnecessary forward decls, that were a maintenance hassle.
11820 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
11821 All uses changed.
11822 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
11823 (scrolling_window): Use ptrdiff_t, not int, for byte count.
11824 (prepare_desired_row, line_draw_cost):
11825 Use int, not unsigned, where either works.
11826 (save_current_matrix, restore_current_matrix):
11827 Use ptrdiff_t, not size_t, where either works.
11828 (init_display): Check for overflow more accurately, and without
11829 relying on undefined behavior.
11830
a81d11a3
PE
11831 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
11832 Remove, replacing with the new symbols in lisp.h. All uses changed.
11833 * fileio.c (make_temp_name):
11834 * filelock.c (lock_file_1, lock_file):
11835 * xdisp.c (message_dolog):
11836 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
11837 Use pMd etc. instead.
11838 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
11839 replacing the pWIDE etc. symbols removed from editfns.c.
11840
3300e6fd
PE
11841 * keyboard.h (num_input_events): Now uintmax_t.
11842 This is (very slightly) less likely to mess up due to wraparound.
11843 All uses changed.
11844
fd05c7e9
PE
11845 * buffer.c: Integer signedness fixes.
11846 (alloc_buffer_text, enlarge_buffer_text):
11847 Use ptrdiff_t rather than size_t when either will do, as we prefer
11848 signed integers.
11849
903fe15d
PE
11850 * alloc.c: Integer signedness and overflow fixes.
11851 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
11852 (__malloc_size_t): Default to size_t, not to int.
11853 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
11854 (Fgarbage_collect, mark_object_loop_halt, mark_object):
11855 Prefer ptrdiff_t to size_t when either would do, as we prefer
11856 signed integers.
11857 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
11858 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
11859 Now const. Initialize with values that are in range even if char
11860 is signed.
11861 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
11862 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
11863 These functions do the right thing with sizes > 2**32.
11864 (check_depth): Now ptrdiff_t, not int.
11865 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
11866 Adjust to new way of storing sizes. Check for size overflow bugs
11867 in rest of code.
11868 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
11869 slightly wrong anyway, as it missed one instance of
11870 XMALLOC_OVERRUN_CHECK_OVERHEAD.
11871 (refill_memory_reserve): Omit needless cast to size_t.
11872 (mark_object_loop_halt): Mark as externally visible.
11873
ac82cc6a
PE
11874 * xselect.c: Integer signedness and overflow fixes.
11875 (Fx_register_dnd_atom, x_handle_dnd_message):
11876 Use ptrdiff_t, not size_t, since we prefer signed.
11877 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
11878 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
11879 x_dnd_atoms_size and x_dnd_atoms_length.
11880
c2d1e36d
PE
11881 * doprnt.c: Prefer signed to unsigned when either works.
11882 * eval.c (verror):
11883 * doprnt.c (doprnt):
11884 * lisp.h (doprnt):
11885 * xdisp.c (vmessage):
11886 Use ptrdiff_t, not size_t, when using or implementing doprnt,
11887 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
11888 prefer signed arithmetic to avoid comparison confusion.
11889 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
11890 but is a bit tricky.
11891
0e926e56
PE
11892 Assume freestanding C89 headers, string.h, stdlib.h.
11893 * data.c, doprnt.c, floatfns.c, print.c:
11894 Include float.h unconditionally.
11895 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
11896 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
11897 * regex.c: Likewise for stddef.h, string.h.
11898 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
11899 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
11900 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
11901 (STDC_HEADERS): Remove obsolete defines.
11902 * sysdep.c: Include limits.h unconditionally.
11903
9cfdb3ec
PE
11904 Assume support for memcmp, memcpy, memmove, memset.
11905 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
11906 * regex.c (memcmp, memcpy):
11907 Remove; we assume C89 now.
11908
11909 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
11910 (__malloc_safe_bcopy): Remove; no longer needed.
11911
cf950e6b 11912 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
11913 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
11914 well either way, and we prefer signed to unsigned.
11915
dbf38e02
LMI
119162011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
11917
11918 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
11919 closes the connection while we're reading (bug#9182).
11920
d6f0886c 119212011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 11922
d6f0886c
JD
11923 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
11924 are specified (Bug#9168).
24e0f6b1 11925
2eb1f9e6
PE
119262011-07-25 Paul Eggert <eggert@cs.ucla.edu>
11927
11928 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
11929 Found by GCC static checking and --with-wide-int on a 32-bit host.
11930
22381272 119312011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
11932
11933 * xdisp.c (compute_display_string_pos): Fix logic of caching
11934 previous display string position. Initialize cached_prev_pos to
11935 -1. Fixes slow-down at the beginning of a buffer.
11936
f25e39b4
EZ
119372011-07-24 Eli Zaretskii <eliz@gnu.org>
11938
11939 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
11940 for attrs[LFACE_FONTSET_INDEX].
11941
04c4b52e
PE
119422011-07-23 Paul Eggert <eggert@cs.ucla.edu>
11943
11944 * xml.c (parse_region): Remove unused local
11945 that was recently introduced.
11946
c1734fbd
EZ
119472011-07-23 Eli Zaretskii <eliz@gnu.org>
11948
be18c5a5
EZ
11949 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
11950 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
11951
c1734fbd
EZ
11952 * xdisp.c (move_it_in_display_line_to): Record the best matching
11953 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
11954 exit if none of the characters scanned was an exact match.
11955 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
11956 when exact match is impossible due to invisible text, and the
11957 lines are truncated.
11958
a258d627
JD
119592011-07-23 Jan Djärv <jan.h.d@swipnet.se>
11960
11961 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
11962 for OSX >= 10.7.
11963
b6d5a689
EZ
119642011-07-22 Eli Zaretskii <eliz@gnu.org>
11965
0f74f785
EZ
11966 Fix a significant slow-down of cursor motion with C-n, C-p,
11967 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
11968 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 11969 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
11970 (next_element_from_buffer): Call compute_stop_pos_backwards to
11971 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
11972 base_level_stop.
11973 (reseat): Don't look for prev_stop, as that could mean a very long
11974 run.
11975 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
11976 <cached_disp_overlay_modiff>: Cache for last found display string
11977 position.
551918c1 11978 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
11979 about the same buffer in the same area of character positions, and
11980 the buffer wasn't changed since the time the display string
11981 position was cached.
551918c1 11982
b2d0c91a
EZ
119832011-07-22 Eli Zaretskii <eliz@gnu.org>
11984
11985 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
11986 is an integer, which is important for empty lines. (Bug#9149)
11987
043604ee
CY
119882011-07-22 Chong Yidong <cyd@stupidchicken.com>
11989
11990 * frame.c (Fmodify_frame_parameters): In tty case, update the
11991 default face if necessary (Bug#4238).
11992
da4adb04
CY
119932011-07-21 Chong Yidong <cyd@stupidchicken.com>
11994
11995 * editfns.c (Fstring_to_char): No need to explain what a character
11996 is in the docstring (Bug#6576).
11997
9abd0532
LMI
119982011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11999
12000 * xml.c (parse_region): Make sure we always return a tree.
12001
36881d16
HK
120022011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
12003
12004 * xml.c (parse_region): If a document contains only comments,
12005 return that, too.
12006
1e98674d
LMI
120072011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12008
12009 * xml.c (make_dom): Return comments, too.
12010
590bd467
PE
120112011-07-19 Paul Eggert <eggert@cs.ucla.edu>
12012
12013 Port to OpenBSD.
12014 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
12015 and the surrounding thread.
12016 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
12017 rather than fgets, and retry after EINTR. Otherwise, 'emacs
12018 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
12019 timer goes off.
12020 * s/openbsd.h (BROKEN_SIGIO): Define.
12021 * unexelf.c (unexec) [__OpenBSD__]:
12022 Don't update the .mdebug section of the Alpha COFF symbol table.
12023
f41628b2
LMI
120242011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
12025
12026 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
12027 (bug#8460).
12028
b59b67c5
PE
120292011-07-18 Paul Eggert <eggert@cs.ucla.edu>
12030
15e3a074
PE
12031 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
12032 This fixes some race conditions on the permissions of any newly
12033 created file.
12034
41bed37d
PE
12035 * alloc.c (valid_pointer_p): Use pipe, not open.
12036 This fixes some permissions issues when debugging.
12037
b59b67c5
PE
12038 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
12039 If fchown fails to set both uid and gid, try to set just gid,
12040 as that is sometimes allowed. Adjust the file's mode to eliminate
12041 setuid or setgid bits that are inappropriate if fchown fails.
12042
925a6be7
SM
120432011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
12044
12045 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
12046 to compare Lisp_Objects.
12047 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
12048 global_gnutls_log_level, don't mistake it for a Lisp_Object.
12049 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
12050
52968808
AS
120512011-07-17 Andreas Schwab <schwab@linux-m68k.org>
12052
0a6a104b
AS
12053 * lread.c (read_integer): Unread even EOF character.
12054 (read1): Likewise. Properly record start position of symbol.
12055
52968808
AS
12056 * lread.c (read1): Read `#:' as empty uninterned symbol if no
12057 symbol character follows.
12058
9e381cdd
PE
120592011-07-17 Paul Eggert <eggert@cs.ucla.edu>
12060
12061 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
12062 This works around a problem with the previous change to Fcopy_file.
12063 Recent glibc declares fchown with __attribute__((warn_unused_result)),
12064 and without this change, GCC might complain about discarding
12065 fchown's return value.
12066
b5641435
JB
120672011-07-16 Juanma Barranquero <lekktu@gmail.com>
12068
12069 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
12070
a8031457
PE
120712011-07-16 Paul Eggert <eggert@cs.ucla.edu>
12072
12073 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
12074
dd889327
LMI
120752011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
12076
750c33f7
LMI
12077 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
12078 it's used from the C level.
12079
dd889327
LMI
12080 * process.c: Use the same condition for POLL_FOR_INPUT in both
12081 keyboard.c and process.c (bug#1858).
12082
87e86684
LM
120832011-07-09 Lawrence Mitchell <wence@gmx.li>
12084
12085 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
12086 (Fgnutls_boot): Use it.
12087
64348f40
AS
120882011-07-15 Andreas Schwab <schwab@linux-m68k.org>
12089
12090 * doc.c (Fsubstitute_command_keys): Revert last change.
12091
1d698799
LMI
120922011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
12093
f863868c
LMI
12094 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
12095 quotes the next character, and doesn't affect other longer
12096 sequences (bug#8935).
12097
1d698799
LMI
12098 * lread.c (syms_of_lread): Clarify that is isn't only
12099 `eval-buffer' and `eval-defun' that's affected by
12100 `lexical-binding' (bug#8460).
12101
aa4b6df6
EZ
121022011-07-15 Eli Zaretskii <eliz@gnu.org>
12103
12104 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 12105 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 12106
5d856da6
PE
121072011-07-14 Paul Eggert <eggert@cs.ucla.edu>
12108
ad6042bb
PE
12109 Fix minor problems found by static checking.
12110 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
12111 (elsz): Now a signed constant, not a size_t var. We prefer signed
12112 types to unsigned, to avoid integer comparison confusion. Without
12113 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
12114 "cannot optimize loop, the loop counter may overflow", a symptom
12115 of the confusion.
f00bbb22 12116 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
12117 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
12118
6468f31c
LMI
121192011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12120
49080b10
LMI
12121 * search.c (Fre_search_backward): Mention `case-fold-search' in
12122 all the re_search_* functions (bug#8138).
12123
6468f31c
LMI
12124 * keyboard.c (Fopen_dribble_file): Document when the file is
12125 closed (bug#8056).
12126
c965adc5
EZ
121272011-07-14 Eli Zaretskii <eliz@gnu.org>
12128
df9733bf
EZ
12129 * bidi.c (bidi_dump_cached_states): Fix format of displaying
12130 bidi_cache_idx.
12131
0bb23927
EZ
12132 Support bidi reordering of display and overlay strings.
12133 * xdisp.c (compute_display_string_pos)
12134 (compute_display_string_end): Accept additional argument STRING.
12135 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
12136 (reseat_to_string): Initialize bidi_it->string.s and
12137 bidi_it->string.schars.
12138 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
12139 NULL (avoids a crash in bidi_paragraph_init).
12140 Initialize itb.string.lstring.
0bb23927
EZ
12141 (init_iterator): Call bidi_init_it only of a valid
12142 buffer position was specified. Initialize paragraph_embedding to
12143 L2R.
12144 (reseat_to_string): Initialize the bidi iterator.
12145 (display_string): If we need to ignore text properties of
12146 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
12147 original value of -1 will not work with bidi.)
12148 (compute_display_string_pos): First arg is now struct
12149 `text_pos *'; all callers changed. Support display properties on
12150 Lisp strings.
12151 (compute_display_string_end): Support display properties on Lisp
12152 strings.
12153 (init_iterator, reseat_1, reseat_to_string): Initialize the
12154 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
12155 when iterating on a string not from display properties).
640c8776
SM
12156 (compute_display_string_pos, compute_display_string_end):
12157 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
12158 arrow keys.
12159 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
12160 base_level_stop; instead, set base_level_stop to BEGV.
12161 Fixes crashes in vertical-motion.
0bb23927
EZ
12162 (next_element_from_buffer): Improve commentary for when
12163 the iterator is before prev_stop.
12164 (init_iterator): Initialize bidi_p from the default value of
12165 bidi-display-reordering, not from buffer-local value. Use the
12166 buffer-local value only if initializing for buffer iteration.
12167 (handle_invisible_prop): Support invisible properties on strings
12168 that are being bidi-reordered.
12169 (set_iterator_to_next): Support bidi reordering of C strings and
12170 Lisp strings.
12171 (next_element_from_string): Support bidi reordering of Lisp
12172 strings.
12173 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
12174 (display_string): Support display of R2L glyph rows.
12175 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
12176 (init_iterator): Don't initialize it->bidi_p for strings
12177 here.
12178 (reseat_to_string): Initialize it->bidi_p for strings here.
12179 (next_element_from_string, next_element_from_c_string)
12180 (next_element_from_buffer): Add xassert's for correspondence
12181 between IT's object being iterated and it->bidi_it.string
12182 structure.
12183 (face_before_or_after_it_pos): Support bidi iteration.
12184 (next_element_from_c_string): Handle the case of the first string
12185 character that is not the first one in the visual order.
12186 (get_visually_first_element): New function, refactored from common
12187 parts of next_element_from_buffer, next_element_from_string, and
12188 next_element_from_c_string.
12189 (tool_bar_lines_needed, redisplay_tool_bar)
12190 (display_menu_bar): Force left-to-right direction. Add a FIXME
12191 comment for making that be controlled by a user option.
12192 (push_it, pop_it): Save and restore the state of the
12193 bidi iterator. Save and restore the bidi_p flag.
12194 (pop_it): Iterate out of display property for string iteration as
12195 well.
12196 (iterate_out_of_display_property): Support iteration over strings.
12197 (handle_single_display_spec): Set up it->bidi_it for iteration
12198 over a display string, and call bidi_init_it.
12199 (handle_single_display_spec, next_overlay_string)
12200 (get_overlay_strings_1, push_display_prop): Set up the bidi
12201 iterator for displaying display or overlay strings.
12202 (forward_to_next_line_start): Don't use the shortcut if
12203 bidi-iterating.
12204 (back_to_previous_visible_line_start): If handle_display_prop
12205 pushed the iterator stack, restore the internal state of the bidi
12206 iterator by calling bidi_pop_it same number of times.
12207 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
12208 and we are bidi-iterating, don't decrement the iterator position;
12209 instead, set the first_elt flag in the bidi iterator, to produce
12210 the same effect.
12211 (reseat_1): Remove redundant setting of string_from_display_prop_p.
12212 (push_display_prop): xassert that we are iterating a buffer.
12213 (push_it, pop_it): Save and restore paragraph_embedding member.
12214 (handle_single_display_spec, next_overlay_string)
12215 (get_overlay_strings_1, reseat_1, reseat_to_string)
12216 (push_display_prop): Set up the `unibyte' member of bidi_it.string
12217 correctly. Don't assume unibyte strings are not bidi-reordered.
12218 (compute_display_string_pos)
12219 (compute_display_string_end): Fix handling the case of C string.
12220 (push_it, pop_it): Save and restore from_disp_prop_p.
12221 (handle_single_display_spec, push_display_prop): Set the
12222 from_disp_prop_p flag.
12223 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
12224 (pop_it): Call iterate_out_of_display_property only if we are
12225 popping after iteration over a string that came from a display
12226 property. Fix a typo in popping stretch info. Add an assertion
12227 for verifying that the iterator position is in sync with the bidi
12228 iterator.
12229 (handle_single_display_spec, get_overlay_strings_1)
12230 (push_display_prop): Fix initialization of paragraph direction for
12231 string when that of the parent object is not yet determined.
12232 (reseat_1): Call bidi_init_it to resync the bidi
12233 iterator with IT's position. (Bug#7616)
12234 (find_row_edges): If ROW->start.pos gives position
12235 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
12236 (handle_stop, back_to_previous_visible_line_start, reseat_1):
12237 Reset the from_disp_prop_p flag.
12238 (SAVE_IT, RESTORE_IT): New macros.
12239 (pos_visible_p, face_before_or_after_it_pos)
12240 (back_to_previous_visible_line_start)
12241 (move_it_in_display_line_to, move_it_in_display_line)
12242 (move_it_to, move_it_vertically_backward, move_it_by_lines)
12243 (try_scrolling, redisplay_window, display_line): Use them when
12244 saving a temporary copy of the iterator and restoring it back.
12245 (back_to_previous_visible_line_start, reseat_1)
12246 (init_iterator): Empty the bidi cache "stack".
12247 (move_it_in_display_line_to): If iterator ended up at
12248 EOL, but we never saw any buffer positions smaller than
12249 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
12250 motion in bidi-reordered lines.
12251 (move_it_in_display_line_to): Record prev_method and prev_pos
12252 immediately before the call to set_iterator_to_next. Fixes cursor
12253 motion in bidi-reordered lines with stretch glyphs and strings
12254 displayed in margins. (Bug#8133) (Bug#8867)
12255 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
12256 TO_CHARPOS.
640c8776
SM
12257 (pos_visible_p): Support positions in bidi-reordered lines.
12258 Save and restore bidi cache.
0bb23927
EZ
12259
12260 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
12261 (bidi_paragraph_info): Delete unused struct.
12262 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
12263 (bidi_cache_start): New variable.
12264 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
12265 to zero.
12266 (bidi_cache_fetch_state, bidi_cache_search)
12267 (bidi_cache_find_level_change, bidi_cache_iterator_state)
12268 (bidi_cache_find, bidi_peek_at_next_level)
12269 (bidi_level_of_next_char, bidi_find_other_level_edge)
12270 (bidi_move_to_visually_next): Compare cache index with
12271 bidi_cache_start rather than with zero.
12272 (bidi_fetch_char): Accept new argument STRING; all callers
12273 changed. Support iteration over a string. Support strings with
12274 display properties. Support unibyte strings. Fix the type of
12275 `len' according to what STRING_CHAR_AND_LENGTH expects.
12276 (bidi_paragraph_init, bidi_resolve_explicit_1)
12277 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
12278 (bidi_level_of_next_char, bidi_move_to_visually_next):
12279 Support iteration over a string.
0bb23927
EZ
12280 (bidi_set_sor_type, bidi_resolve_explicit_1)
12281 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
12282 can now be zero (for strings); special values 0 and -1 were
12283 changed to -1 and -2, respectively.
12284 (bidi_char_at_pos): New function.
12285 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
12286 Call it instead of FETCH_MULTIBYTE_CHAR.
12287 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
12288 initialized to valid values.
12289 (bidi_init_it): Don't initialize charpos and bytepos with invalid
12290 values.
12291 (bidi_level_of_next_char): Allow the sentinel "position" to pass
12292 the test for valid cached positions. Fix the logic for looking up
12293 the sentinel state in the cache. GCPRO the Lisp string we are
12294 iterating.
12295 (bidi_push_it, bidi_pop_it): New functions.
12296 (bidi_initialize): Initialize the bidi cache start stack pointer.
12297 (bidi_cache_ensure_space): New function, refactored from part of
12298 bidi_cache_iterator_state. Don't assume the required size is just
12299 one BIDI_CACHE_CHUNK away.
12300 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
12301 (bidi_count_bytes, bidi_char_at_pos): New functions.
12302 (bidi_cache_search): Don't assume bidi_cache_last_idx is
12303 always valid if bidi_cache_idx is valid.
12304 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
12305 is valid if it's going to be used.
12306 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
12307 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
12308 (bidi_cache_find_level_change, bidi_cache_ensure_space)
12309 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
12310 (bidi_find_other_level_edge, bidi_cache_start_stack):
12311 All variables related to cache indices are now EMACS_INT.
c965adc5 12312
0bb23927
EZ
12313 * dispextern.h (struct bidi_string_data): New structure.
12314 (struct bidi_it): New member `string'. Make flag members be 1-bit
12315 fields, and put them last in the struct.
640c8776
SM
12316 (compute_display_string_pos, compute_display_string_end):
12317 Update prototypes.
0bb23927
EZ
12318 (bidi_push_it, bidi_pop_it): Add prototypes.
12319 (struct iterator_stack_entry): New members bidi_p,
12320 paragraph_embedding, and from_disp_prop_p.
12321 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
12322 (bidi_shelve_cache, bidi_unshelve_cache):
12323 Declare prototypes.
0bb23927
EZ
12324
12325 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
12326 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
12327 and vector-like objects.
12328
12329 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
12330 cache around display iteration.
12331
12332 * window.c (Fwindow_end, window_scroll_pixel_based)
12333 (displayed_window_lines, Frecenter): Save and restore the bidi
12334 cache around display iteration.
12335
3bbd2265
LMI
123362011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12337
12338 * editfns.c (Fdelete_region): Clarify the use of the named
12339 parameters (bug#6788).
12340
adc47434
MR
123412011-07-14 Martin Rudalics <rudalics@gmx.at>
12342
12343 * indent.c (Fvertical_motion): Set and restore w->pointm when
12344 saving and restoring the window's buffer (Bug#9006).
12345
837c31f8
LMI
123462011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
12347
12348 * editfns.c (Fstring_to_char): Clarify just what is returned
12349 (bug#6576). Text by Eli Zaretskii.
12350
ac389d0c
JB
123512011-07-13 Juanma Barranquero <lekktu@gmail.com>
12352
12353 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
12354
0be0ce47
EZ
123552011-07-13 Eli Zaretskii <eliz@gnu.org>
12356
12357 * buffer.c (mmap_find): Fix a typo.
12358
cd18e7e3
JB
123592011-07-13 Johan Bockgård <bojohan@gnu.org>
12360
12361 Fix execution of x selection hooks.
12362 * xselect.c (Qx_lost_selection_functions)
12363 (Qx_sent_selection_functions): New vars.
12364 (syms_of_xselect): DEFSYM them.
12365 (x_handle_selection_request): Pass Qx_sent_selection_functions
12366 rather than Vx_sent_selection_functions to Frun_hook_with_args.
12367 (x_handle_selection_clear,x_clear_frame_selections):
12368 Pass Qx_lost_selection_functions rather than
12369 Vx_lost_selection_functions to Frun_hook_with_args.
12370
47ea7f44
PE
123712011-07-13 Paul Eggert <eggert@cs.ucla.edu>
12372
ac389d0c 12373 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
12374 The old code sometimes used this field without initializing it.
12375
47ea7f44
PE
12376 * alloc.c (gc_sweep): Don't read past end of array.
12377 In theory, the old code could also have corrupted Emacs internals,
12378 though it'd be very unlikely.
12379
bc985c87
AS
123802011-07-12 Andreas Schwab <schwab@linux-m68k.org>
12381
12382 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 12383 argument. (Bug#4026)
bc985c87 12384
0cf34688
LMI
123852011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
12386
b3dadd76
LMI
12387 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
12388 key" (bug#4257).
12389
0cf34688
LMI
12390 * window.c (Fset_window_start): Doc fix (bug#4199).
12391 (Fset_window_hscroll): Ditto.
12392
270768cd
PE
123932011-07-12 Paul Eggert <eggert@cs.ucla.edu>
12394
077e3dda 12395 Fix minor new problems caught by GCC 4.6.1.
270768cd 12396 * term.c (init_tty): Remove unused local.
490011a6 12397 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 12398 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 12399 not used otherwise.
270768cd 12400
b1f58454
CY
124012011-07-12 Chong Yidong <cyd@stupidchicken.com>
12402
12403 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
12404
22b9578d
LMI
124052011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
12406
6e70ab07
LMI
12407 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
12408 are the mini-buffer and the echo area (bug#3320).
12409
22b9578d
LMI
12410 * term.c (init_tty): Remove support for supdup, c10 and perq
12411 terminals, which are no longer supported (bug#1482).
12412
8974cc9f
JB
124132011-07-10 Johan Bockgård <bojohan@gnu.org>
12414
12415 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
12416
a560d974
JD
124172011-07-10 Jan Djärv <jan.h.d@swipnet.se>
12418
12419 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
12420 for non-popups (Bug#3642).
12421
1dae0f0a
AS
124222011-07-10 Andreas Schwab <schwab@linux-m68k.org>
12423
268c2c36 12424 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 12425 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
12426 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
12427 * cm.c (losecursor): Likewise.
1dae0f0a
AS
12428 * data.c (fmod): Likewise.
12429 * dispnew.c (swap_glyphs_in_rows): Likewise.
12430 * emacs.c (memory_warning_signal): Likewise.
12431 * floatfns.c (float_error): Likewise.
12432 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
12433 (otf_open, font_otf_capability, generate_otf_features)
12434 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
12435 Likewise.
12436 * image.c (pbm_read_file): Likewise.
12437 * indent.c (string_display_width): Likewise.
12438 * intervals.c (check_for_interval, search_for_interval)
12439 (inc_interval_count, count_intervals, root_interval)
12440 (adjust_intervals_for_insertion, make_new_interval): Likewise.
12441 * lread.c (defalias): Likewise.
268c2c36 12442 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
12443 * regex.c (set_image_of_range_1, set_image_of_range)
12444 (regex_grow_registers): Likewise.
12445 * sysdep.c (strerror): Likewise.
12446 * termcap.c (valid_filename_p, tprint, main): Likewise.
12447 * tparam.c (main): Likewise.
12448 * unexhp9k800.c (run_time_remap, save_data_space)
12449 (update_file_ptrs, read_header, write_header, calculate_checksum)
12450 (copy_file, copy_rest, display_header): Likewise.
12451 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
12452 Likewise.
12453 * xdisp.c (check_it): Likewise.
12454 * xfaces.c (register_color, unregister_color, unregister_colors):
12455 Likewise.
12456 * xfns.c (print_fontset_result): Likewise.
12457 * xrdb.c (member, fatal, main): Likewise.
12458
99033785
PE
124592011-07-10 Paul Eggert <eggert@cs.ucla.edu>
12460
12461 Fix minor problems found by static checking (Bug#9031).
12462 * chartab.c (char_table_set_range, map_sub_char_table):
12463 Remove unused locals.
12464 (uniprop_table): Now static.
12465 * composite.c (_work_char): Remove unused static var.
12466
9cb2ac56
JB
124672011-07-09 Juanma Barranquero <lekktu@gmail.com>
12468
12469 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
12470
f25661f0
JD
124712011-07-09 Jan Djärv <jan.h.d@swipnet.se>
12472
12473 * gtkutil.c (qttip_cb): Remove code without function.
12474
8278c4fe
EZ
124752011-07-09 Eli Zaretskii <eliz@gnu.org>
12476
12477 * w32.c (pthread_sigmask): New stub.
12478
1692ae2d 124792011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 12480
8a6ebd58 12481 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
12482 sigprocmask is portable only for single-threaded applications, and
12483 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
12484 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
12485 (LIBES): Use it.
12486 * callproc.c (Fcall_process):
12487 * process.c (create_process):
12488 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
12489 Use pthread_sigmask, not sigprocmask.
123403e4 12490
1b854618
JD
124912011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12492
12493 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
12494 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
12495 wrong (Bug#8591).
12496
3fe4b549
JD
124972011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12498
0ce7e563
JD
12499 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
12500 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
12501 (xg_hide_tooltip): Fix comment.
12502
3fe4b549
JD
12503 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
12504 in registerServicesMenuSendTypes.
12505 (validRequestorForSendType): Don't check ns_return_types.
12506
12507 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
12508 ns_return_type.
12509
5df75e47
JR
125102011-07-08 Jason Rumney <jasonr@gnu.org>
12511
22610910
JR
12512 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
12513 SH_SHOW for hidden windows (Bug#5482).
12514
5df75e47
JR
12515 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
12516 frame struct members of non-existent frames (Bug#6284).
12517
699c10bd
JD
125182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12519
4393663b
JD
12520 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
12521 variable firstTime not needed on OSX >= 10.6.
12522 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
12523 >= 10.5. Use setKnobProportion, setDoubleValue.
12524
12525 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
12526 (MAC_OS_X_VERSION_10_5): Define if not defined.
12527 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
12528 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
12529 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
12530
12531 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 12532 cString and lossyCString on OSX >= 10.4.
4393663b 12533
58179cce 12534 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
12535 sizeToFit on OSX >= 10.2.
12536
12537 * nsimage.m (allocInitFromFile): Don't use deprecated method
12538 bestRepresentationForDevice on OSX >= 10.6.
12539
12540 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
12541 to avoid warning.
12542
12543 * emacs.c: Declare unexec_init_emacs_zone.
12544
a63e0781
JD
12545 * nsgui.h: Fix compiler warning about gnulib redefining verify.
12546
699c10bd
JD
12547 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
12548
12549 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
12550 on svcsMenu (Bug#8842).
12551
12552 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
12553 ns_return_types.
12554 (Fns_list_services): Just return Qnil on 10.6, code not working there.
12555
12556 * nsterm.m (QUTF8_STRING): Declare.
12557 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
12558 (validRequestorForSendType): Return type is (id).
12559 Change indexOfObjectIdenticalTo to indexOfObject.
12560 Check if we have local selection before returning self (Bug#8842).
12561 (writeSelectionToPasteboard): Put local selection into paste board
12562 if we have a local selection (Bug#8842).
12563 (syms_of_nsterm): DEFSYM QUTF8_STRING.
12564
12565 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
12566 (ns_get_local_selection): Declare.
12567
54e10184
LMI
125682011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
12569
9888ff71
LMI
12570 * keymap.c (describe_map_tree): Don't insert a double newline at
12571 the end of the buffer (bug#1169) and return whether we inserted
12572 something.
12573
54e10184
LMI
12574 * callint.c (Fcall_interactively): Change "reading args" to
12575 "providing args" to try to clarify what it does (bug#1010).
12576
15fa4783
KH
125772011-07-07 Kenichi Handa <handa@m17n.org>
12578
12579 * composite.c (composition_compute_stop_pos): Ignore a static
12580 composition starting before CHARPOS (Bug#8915).
12581
12582 * xdisp.c (handle_composition_prop): Likewise.
12583
a8815b00
EZ
125842011-07-07 Eli Zaretskii <eliz@gnu.org>
12585
12586 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
12587 (Bug#9015)
12588
ef7b981d 125892011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
12590
12591 * character.h (unicode_category_t): New enum type.
12592
12593 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
12594 (Qchar_code_property_table): New variable.
12595 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
12596 (UNIPROP_COMPRESSED_FORM_P): New macros.
12597 (char_table_ascii): Uncompress the compressed values.
12598 (sub_char_table_ref): New arg is_uniprop. Callers changed.
12599 Uncompress the compressed values.
ac389d0c 12600 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
12601 (char_table_ref_and_range): Uncompress the compressed values.
12602 (sub_char_table_set): New arg is_uniprop. Callers changed.
12603 Uncompress the compressed values.
12604 (sub_char_table_set_range): Args changed. Callers changed.
12605 (char_table_set_range): Adjuted for the above change.
12606 (map_sub_char_table): Delete args default_val and parent. Add arg
12607 top. Give decoded values to a Lisp function.
640c8776 12608 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
12609 values to a Lisp function. Gcpro more variables.
12610 (uniprop_table_uncompress)
12611 (uniprop_decode_value_run_length): New functions.
12612 (uniprop_decoder, uniprop_decoder_count): New variables.
12613 (uniprop_get_decoder, uniprop_encode_value_character)
12614 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
12615 New functions.
12616 (uniprop_encoder, uniprop_encoder_count): New variables.
12617 (uniprop_get_encoder, uniprop_table)
12618 (Funicode_property_table_internal, Fget_unicode_property_internal)
12619 (Fput_unicode_property_internal): New functions.
12620 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
12621 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 12622 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
12623 char-code-property-alist.
12624
640c8776 12625 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
12626 Vunicode_category_table.
12627
640c8776 12628 * font.c (font_range): Adjust for the change of
c805dec0
KH
12629 Vunicode_category_table.
12630
76b397fb
DN
126312011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
12632
12633 * m/iris4d.h: Remove file, move contents ...
12634 * s/irix6-5.h: ... here.
12635
22b4128e
PE
126362011-07-06 Paul Eggert <eggert@cs.ucla.edu>
12637
12638 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
12639 * alloc.c (mark_buffer):
12640 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
12641 (clone_per_buffer_values): Don't assume that
22b4128e
PE
12642 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
12643 This isn't true in general, and it's particularly not true
12644 if Emacs is configured with --with-wide-int.
12645 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
12646 New macros, used in the buffer.c change.
12647
869795d6
JD
126482011-07-05 Jan Djärv <jan.h.d@swipnet.se>
12649
12650 * xsettings.c: Use both GConf and GSettings if both are available.
12651 (store_config_changed_event): Add comment.
12652 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
12653 (store_tool_bar_style_changed): New functions.
5e617bc2 12654 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
12655 (struct xsettings): Move font inside HAVE_XFT.
12656 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 12657 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 12658 Move inside HAVE_XFT.
640c8776 12659 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
12660 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
12661 also.
12662 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 12663 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 12664 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
12665 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
12666 (parse_settings): Move check for font inside HAVE_XFT.
12667 (read_settings, apply_xft_settings): Add comment.
12668 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
12669 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
12670 call store_font_name_changed.
12671 (xft_settings_event): Add comment.
12672 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
12673 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
12674 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
12675 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
12676 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
12677 (xsettings_get_system_font, xsettings_get_system_normal_font):
12678 Add comment.
869795d6 12679
d8ed26bd
PE
126802011-07-05 Paul Eggert <eggert@cs.ucla.edu>
12681
12682 Random fixes. E.g., (random) never returned negative values.
12683 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
12684 subseconds part to the entropy, as that's a bit more random.
12685 Prefer signed to unsigned, since the signedness doesn't matter and
12686 in general we prefer signed. When given a limit, use a
12687 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
12688 latter isn't right if USE_2_TAGS_FOR_INTS.
12689 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
12690 not 0..VALMASK. Don't discard "excess" bits that random () returns.
12691
cabf1cac
SM
126922011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
12693
12694 * textprop.c (text_property_stickiness):
12695 Obey Vtext_property_default_nonsticky.
12696 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
12697 * w32fns.c (syms_of_w32fns):
12698 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
12699
6e9b2be9
PE
127002011-07-04 Paul Eggert <eggert@cs.ucla.edu>
12701
12702 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
12703 This is more efficient than Ffile_directory_p and avoids a minor race.
12704
90186c68
LMI
127052011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
12706
7c301272
LMI
12707 * buffer.c (Foverlay_put): Say what the return value is
12708 (bug#7835).
12709
c4f2d8d4
LMI
12710 * fileio.c (barf_or_query_if_file_exists): Check first if the file
12711 is a directory before asking whether to use the file name
12712 (bug#7564).
ad637907
LMI
12713 (barf_or_query_if_file_exists): Make the "File is a directory"
12714 error be more correct.
c4f2d8d4 12715
90186c68
LMI
12716 * fns.c (Frequire): Remove the mention of the .gz files, since
12717 that's installation-specific, but keep the mention of
12718 `get-load-suffixes'.
12719
da64016e
PE
127202011-07-04 Paul Eggert <eggert@cs.ucla.edu>
12721
12722 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
12723 Report string overflow if the output is too long.
12724
7d47b580
JB
127252011-07-04 Juanma Barranquero <lekktu@gmail.com>
12726
a555cb87
JB
12727 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
12728 (syms_of_gnutls): Remove duplicate DEFSYM for
12729 Qgnutls_bootprop_verify_hostname_error, an error for
12730 Qgnutls_bootprop_verify_error (which is no longer used).
12731
7d47b580
JB
12732 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
12733 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
12734 Also (re)move comments that are misplaced or no longer relevant.
12735
1e49bfab
LMI
127362011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
12737
12738 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
12739
1485f4c0
CY
127402011-07-03 Chong Yidong <cyd@stupidchicken.com>
12741
12742 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
12743 and background color parameters if they have been changed.
12744
a9ab721e
LMI
127452011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
12746
12747 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
12748
cf7cff57
PE
127492011-07-03 Paul Eggert <eggert@cs.ucla.edu>
12750
2e13213d
PE
12751 * xsettings.c (SYSTEM_FONT): Define only when used.
12752 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
12753
cf7cff57
PE
12754 * keymap.c (access_keymap_1): Now static.
12755
7a8e04f7
CY
127562011-07-02 Chong Yidong <cyd@stupidchicken.com>
12757
12758 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
12759 leave any prefix arg for the up event (Bug#1586).
12760
61352f62
LMI
127612011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
12762
69bb1ef7
LMI
12763 * lread.c (syms_of_lread): Mention single symbols defined by
12764 `defvar' or `defconst' (bug#7154).
12765
61352f62 12766 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 12767 (Frequire): Mention get-load-suffixes.
61352f62 12768
28545e04
MR
127692011-07-02 Martin Rudalics <rudalics@gmx.at>
12770
12771 * window.h (window): Remove clone_number slot.
12772 * window.c (Fwindow_clone_number, Fset_window_clone_number):
12773 Remove.
12774 (make_parent_window, make_window, saved_window)
12775 (Fset_window_configuration, save_window_save): Don't deal with
12776 clone numbers.
12777 * buffer.c (Qclone_number): Remove declaration.
12778 (sort_overlays, overlay_strings): Don't deal with clone numbers.
12779
3349e122
SM
127802011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
12781
12782 Add multiple inheritance to keymaps.
12783 * keymap.c (Fmake_composed_keymap): New function.
12784 (Fset_keymap_parent): Simplify.
12785 (fix_submap_inheritance): Remove.
12786 (access_keymap_1): New function extracted from access_keymap to handle
12787 embedded parents and handle lists of maps.
12788 (access_keymap): Use it.
12789 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
12790 (Fcopy_keymap): Handle embedded parents.
12791 (Fcommand_remapping, define_as_prefix): Simplify.
12792 (Fkey_binding): Simplify.
12793 (syms_of_keymap): Move minibuffer-local-completion-map,
12794 minibuffer-local-filename-completion-map,
12795 minibuffer-local-must-match-map, and
12796 minibuffer-local-filename-must-match-map to Elisp.
12797 (syms_of_keymap): Defsubr make-composed-keymap.
12798 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
12799 (parse_menu_item): Trivial simplification.
12800
3279eb87
GM
128012011-07-01 Glenn Morris <rgm@gnu.org>
12802
12803 * Makefile.in (SETTINGS_LIBS): Fix typo.
12804
39cb9e56 128052011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
12806
12807 * coding.c (Fencode_coding_string): Record the last coding system
12808 used, as the function doc string says (bug#8738).
12809
0949d2b6
JD
128102011-07-01 Jan Djärv <jan.h.d@swipnet.se>
12811
12812 * xsettings.c (store_monospaced_changed): Take new font as arg and
12813 check for change against current_mono_font.
12814 (EMACS_TYPE_SETTINGS): Remove this and related defines.
12815 (emacs_settings_constructor, emacs_settings_get_property)
12816 (emacs_settings_set_property, emacs_settings_class_init)
12817 (emacs_settings_init, gsettings_obj): Remove.
12818 (something_changedCB): New function for HAVE_GSETTINGS.
12819 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
12820 with value as argument.
12821 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
12822 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 12823 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
12824 "changed".
12825
12826 * xgselect.c: Add defined (HAVE_GSETTINGS).
12827 (xgselect_initialize): Ditto.
12828
12829 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
12830 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
12831 xg_select.
12832
bbc6b304
PE
128332011-07-01 Paul Eggert <eggert@cs.ucla.edu>
12834
12835 * eval.c (struct backtrace): Simplify and port the data structure.
12836 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
12837 signed bit field, as this assumption is not portable and it makes
12838 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
12839 "char debug_on_exit : 1" as this is not portable either; instead,
12840 use the portable "unsigned int debug_on_exit : 1". Remove unused
12841 member evalargs. Remove obsolete comments about cc bombing out.
12842
9851bfc5
JD
128432011-06-30 Jan Djärv <jan.h.d@swipnet.se>
12844
51bb811f 12845 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
12846 Let HAVE_GSETTINGS override HAVE_GCONF.
12847 (store_monospaced_changed): New function.
12848 (EMACS_SETTINGS): A new type derived from GObject to handle
12849 GSettings notifications.
12850 (emacs_settings_constructor, emacs_settings_get_property)
12851 (emacs_settings_set_property, emacs_settings_class_init):
12852 New functions.
12853 (gsettings_client, gsettings_obj): New variables.
12854 (GSETTINGS_SCHEMA): New define.
12855 (something_changedCB): Call store_monospaced_changed.
12856 (init_gsettings): New function.
12857 (xsettings_initialize): Call init_gsettings.
12858 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
12859 to NULL.
12860
640c8776 12861 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
12862 GCONF_CFLAGS/LIBS.
12863
5386012d
MR
128642011-06-29 Martin Rudalics <rudalics@gmx.at>
12865
12866 * window.c (resize_root_window, grow_mini_window)
12867 (shrink_mini_window): Rename Qresize_root_window to
12868 Qwindow_resize_root_window and Qresize_root_window_vertically to
12869 Qwindow_resize_root_window_vertically.
12870
f13e0b08
PE
128712011-06-28 Paul Eggert <eggert@cs.ucla.edu>
12872
12873 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
12874
94515237
JB
128752011-06-27 Juanma Barranquero <lekktu@gmail.com>
12876
12877 * makefile.w32-in: Redesign dependencies so they reflect more
12878 clearly which files are directly included by each source file,
12879 and not through other includes.
12880
e43b6e43
MR
128812011-06-27 Martin Rudalics <rudalics@gmx.at>
12882
12883 * buffer.c (Qclone_number): Declare static and DEFSYM it.
12884 (sort_overlays, overlay_strings): When an overlay's clone number
12885 matches the window's clone number process the overlay even if
12886 the overlay's window property doesn't match the current window.
12887
d68443dc
MR
12888 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
12889 (Fwindow_hchild): Rename to Fwindow_left_child.
12890 (Fwindow_next): Rename to Fwindow_next_sibling.
12891 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
12892 (resize_window_check): Rename to window_resize_check.
12893 (resize_window_apply): Rename to window_resize_apply.
12894 (Fresize_window_apply): Rename to Fwindow_resize_apply.
12895 (Fdelete_other_windows_internal, resize_frame_windows)
12896 (Fsplit_window_internal, Fdelete_window_internal)
12897 (grow_mini_window, shrink_mini_window)
12898 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 12899
c7e73be5
JD
129002011-06-26 Jan Djärv <jan.h.d@swipnet.se>
12901
12902 * emacsgtkfixed.h: State that this is only used with Gtk+3.
12903 (emacs_fixed_set_min_size): Remove.
12904 (emacs_fixed_new): Take frame as argument.
12905
12906 * emacsgtkfixed.c: State that this is only used with Gtk+3.
12907 (_EmacsFixedPrivate): Remove minwidth/height.
12908 Add struct frame *f.
12909 (emacs_fixed_init): Initialize priv->f.
12910 (get_parent_class, emacs_fixed_set_min_size): Remove.
12911 (emacs_fixed_new): Set priv->f to argument.
12912 (emacs_fixed_get_preferred_width)
12913 (emacs_fixed_get_preferred_height): Use min_width/height from
12914 frames size_hint to set minimum and natural (Bug#8919).
12915 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
12916 and use min_width/height from frames size_hint to set
12917 min_width/height (Bug#8919).
12918
12919 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
12920 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
12921 Fix indentation.
c7e73be5 12922
cf99dcf8
EZ
129232011-06-26 Eli Zaretskii <eliz@gnu.org>
12924
12925 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
12926 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
12927 called at ZV.
12928
029529ac
CY
129292011-06-26 Chong Yidong <cyd@stupidchicken.com>
12930
12931 * process.c (wait_reading_process_output): Bypass select if
12932 waiting for a cell while ignoring keyboard input, and input is
12933 pending. Suggested by Jan Djärv (Bug#8869).
12934
7a7ef429
PE
129352011-06-25 Paul Eggert <eggert@cs.ucla.edu>
12936
12937 Use gnulib's dup2 module instead of rolling our own.
12938 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
12939
11fdef7d 129402011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
12941
12942 * dispnew.c (scrolling_window): Before scrolling, turn off a
12943 mouse-highlight in the window being scrolled.
12944
cd3520a4
JB
129452011-06-24 Juanma Barranquero <lekktu@gmail.com>
12946
12947 Move DEFSYM to lisp.h and use everywhere.
12948
12949 * character.h (DEFSYM): Move declaration...
12950 * lisp.h (DEFSYM): ...here.
12951
12952 * gnutls.c:
12953 * minibuf.c:
12954 * w32menu.c:
12955 * w32proc.c:
12956 * w32select.c: Don't include character.h.
12957
12958 * alloc.c (syms_of_alloc):
12959 * buffer.c (syms_of_buffer):
12960 * bytecode.c (syms_of_bytecode):
12961 * callint.c (syms_of_callint):
12962 * casefiddle.c (syms_of_casefiddle):
12963 * casetab.c (init_casetab_once):
12964 * category.c (init_category_once, syms_of_category):
12965 * ccl.c (syms_of_ccl):
12966 * cmds.c (syms_of_cmds):
12967 * composite.c (syms_of_composite):
12968 * dbusbind.c (syms_of_dbusbind):
12969 * dired.c (syms_of_dired):
12970 * dispnew.c (syms_of_display):
12971 * doc.c (syms_of_doc):
12972 * editfns.c (syms_of_editfns):
12973 * emacs.c (syms_of_emacs):
12974 * eval.c (syms_of_eval):
12975 * fileio.c (syms_of_fileio):
12976 * fns.c (syms_of_fns):
12977 * frame.c (syms_of_frame):
12978 * fringe.c (syms_of_fringe):
12979 * insdel.c (syms_of_insdel):
12980 * keymap.c (syms_of_keymap):
12981 * lread.c (init_obarray, syms_of_lread):
12982 * macros.c (syms_of_macros):
12983 * msdos.c (syms_of_msdos):
12984 * print.c (syms_of_print):
12985 * process.c (syms_of_process):
12986 * search.c (syms_of_search):
12987 * sound.c (syms_of_sound):
12988 * syntax.c (init_syntax_once, syms_of_syntax):
12989 * terminal.c (syms_of_terminal):
12990 * textprop.c (syms_of_textprop):
12991 * undo.c (syms_of_undo):
12992 * w32.c (globals_of_w32):
12993 * window.c (syms_of_window):
12994 * xdisp.c (syms_of_xdisp):
12995 * xfaces.c (syms_of_xfaces):
12996 * xfns.c (syms_of_xfns):
12997 * xmenu.c (syms_of_xmenu):
12998 * xsettings.c (syms_of_xsettings):
12999 * xterm.c (syms_of_xterm): Use DEFSYM.
13000
4228cf16
TZ
130012011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
13002
cd3520a4 13003 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 13004
7fcccf1e
PE
130052011-06-23 Paul Eggert <eggert@cs.ucla.edu>
13006
7efb4e0e
PE
13007 Integer and buffer overflow fixes (Bug#8873).
13008
ff5844ad
PE
13009 * print.c (printchar, strout): Check for string overflow.
13010 (PRINTPREPARE, printchar, strout):
13011 Don't set size unless allocation succeeds.
13012
90532f02
PE
13013 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
13014 for sizes. Check for string overflow more accurately.
13015 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
13016
6d84508d
PE
13017 * macros.c: Integer and buffer overflow fixes.
13018 * keyboard.h (struct keyboard.kbd_macro_bufsize):
13019 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
13020 Use ptrdiff_t, not int, for sizes.
13021 Don't increment bufsize until after realloc succeeds.
13022 Check for size-calculation overflow.
13023 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
13024
437b2cb4
PE
13025 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
13026
8b9ac8b4
PE
13027 * lread.c: Integer overflow fixes.
13028 (read_integer): Radix is now EMACS_INT, not int,
13029 to improve quality of diagnostics for out-of-range radices.
13030 Calculate buffer size correctly for out-of-range radices.
13031 (read1): Check for integer overflow in radices, and in
13032 read-circle numbers.
82cb60d3
PE
13033 (read_escape): Avoid int overflow.
13034 (Fload, openp, read_buffer_size, read1)
13035 (substitute_object_recurse, read_vector, read_list, map_obarray):
13036 Use ptrdiff_t, not int, for sizes.
13037 (read1): Use EMACS_INT, not int, for sizes.
20270765 13038 Check for size overflow.
8b9ac8b4 13039
7fcccf1e
PE
13040 * image.c (cache_image): Check for size arithmetic overflow.
13041
bfbbd7e7
PE
13042 * lread.c: Integer overflow issues.
13043 (saved_doc_string_size, saved_doc_string_length)
13044 (prev_saved_doc_string_size, prev_saved_doc_string_length):
13045 Now ptrdiff_t, not int.
13046 (read1): Don't assume doc string length fits in int. Check for
13047 out-of-range doc string lengths.
13048 (read_list): Don't assume file position fits in int.
39019e54 13049 (read_escape): Check for hex character overflow.
bfbbd7e7 13050
4e323265
LL
130512011-06-22 Leo Liu <sdl.web@gmail.com>
13052
13053 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
13054 Move to minibuffer.el.
13055
85fece3e
PE
130562011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13057
20b84ce9 13058 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
13059 The following patches are for when GLYPH_DEBUG && !XASSERT.
13060 * dispextern.h (trace_redisplay_p, dump_glyph_string):
13061 * dispnew.c (flush_stdout):
13062 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
13063 Mark as externally visible.
13064 * dispnew.c (check_window_matrix_pointers): Now static.
13065 * dispnew.c (window_to_frame_vpos):
13066 * xfns.c (unwind_create_frame):
13067 * xterm.c (x_check_font): Remove unused local.
13068 * scroll.c (CHECK_BOUNDS):
13069 * xfaces.c (cache_fache): Rename local to avoid shadowing.
13070 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
13071 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
13072 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
13073 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
13074 Now static.
13075 (debug_method_add): Use va_list and vsprintf rather than relying
13076 on undefined behavior with wrong number of arguments.
13077 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
13078 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
13079 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
13080 since we're not interested in debugging glyphs with old libraries.
13081 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
13082 GCC 4.6.0's static checking.
13083
0766b489
PE
130842011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13085
31fd4b32
PE
13086 Integer overflow and signedness fixes (Bug#8873).
13087 A few related buffer overrun fixes, too.
13088
b79e8648
PE
13089 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
13090
0766b489
PE
13091 * dispextern.h (struct face.stipple):
13092 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
13093 (x_bitmap_mask, x_allocate_bitmap_record)
13094 (x_create_bitmap_from_data, x_create_bitmap_from_file)
13095 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
13096 (x_create_bitmap_from_xpm_data):
13097 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
13098 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
13099 (.bitmaps_last):
13100 * xfaces.c (load_pixmap):
13101 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
13102 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
13103 (.bitmaps_last, struct x_output.icon_bitmap):
13104 Use ptrdiff_t, not int, for bitmap indexes.
13105 (x_allocate_bitmap_record): Check for size overflow.
13106 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
13107
b081724f
PE
13108 Use ptrdiff_t, not int, for overlay counts.
13109 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
13110 * editfns.c (overlays_around, get_pos_property):
13111 * textprop.c (get_char_property_and_overlay):
13112 * xdisp.c (next_overlay_change, note_mouse_highlight):
13113 * xfaces.c (face_at_buffer_position):
21514da7
PE
13114 * buffer.c (OVERLAY_COUNT_MAX): New macro.
13115 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
13116 (Fnext_overlay_change, Fprevious_overlay_change)
13117 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 13118 Use ptrdiff_t, not int, for sizes.
21514da7 13119 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 13120
3de73e5e
PE
13121 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
13122
2606c57b
PE
13123 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
13124 (x_session_initialize): Do not assume string length fits in int.
13125
aaafe47a
PE
13126 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
13127 This is unlikely, but can occur if DPI is outlandish.
13128
2674ddc8 13129 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
13130 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
13131
28154962
PE
13132 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
13133 * xrdb.c (magic_file_p, search_magic_path):
13134 Omit last arg SUFFIX; it was always 0. All callers changed.
13135 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
13136
7de51af5
PE
13137 * xfont.c (xfont_match): Avoid need for strlen.
13138
25ed6cc3
PE
13139 * xfns.c: Don't assume strlen fits in int.
13140 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
13141
4eab31dd
PE
13142 * xdisp.c (message_log_check_duplicate): Return intmax_t,
13143 not unsigned long, as we prefer signed integers. All callers changed.
13144 Detect integer overflow in repeat count.
13145 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 13146 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 13147
171e2a58
PE
13148 * termcap.c: Don't assume sizes fit in int and never overflow.
13149 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
13150 (gobble_line): Check for size-calculation overflow.
13151
ad39faca 13152 * minibuf.c (Fread_buffer):
6e5bb2dc 13153 * lread.c (intern, intern_c_string):
74ca2eb3
PE
13154 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
13155 Don't assume string length fits in int.
13156
52c61c22 13157 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
13158 * gtkutil.c (style_changed_cb): Avoid need for strlen.
13159
b5b8c9e5
PE
13160 * font.c: Don't assume string length fits in int.
13161 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
13162 Use ptrdiff_t, not int.
ccd6111c
PE
13163 (font_intern_prop): Don't assume string length fits in int.
13164 Don't assume integer property fits in fixnum.
13165 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 13166
882f0d81 13167 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 13168 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
13169 Reformulate so as not to need the command string.
13170 Invoke gzip -cd rather than gunzip, as it's more portable.
13171 (lock_info_type, lock_file_1, lock_file):
13172 Don't assume pid_t and time_t fit in unsigned long.
13173 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
13174 (current_lock_owner): Prefer signed type for sizes.
13175 Use memcpy, not strncpy, where memcpy is what is really wanted.
13176 Don't assume (via atoi) that time_t and pid_t fit in int.
13177 Check for time_t and/or pid_t out of range, e.g., via a network share.
13178 Don't alloca where an auto var works fine.
13179
93f4cf88
PE
13180 * fileio.c: Fix some integer overflow issues.
13181 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
13182 Don't assume string length fits in int.
13183 (directory_file_name): Don't assume string length fits in long.
13184 (make_temp_name): Don't assume pid fits in int, or that its print
13185 length is less than 20.
13186
f3e92b69
PE
13187 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
13188
1bfdaf10
PE
13189 * coding.c (make_subsidiaries): Don't assume string length fits in int.
13190
35016e9a
PE
13191 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
13192
3d1e65a1
PE
13193 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
13194 We prefer signed integers, even for size calculations.
13195
0b963a93
PE
13196 * emacs.c: Don't assume string length fits in 'int'.
13197 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
13198 (main): Don't invoke strlen when not needed.
13199
573f4b54
PE
13200 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
13201 (XD_DEBUG_MESSAGE): Don't waste a byte.
13202
989f33ba
PE
13203 * callproc.c (getenv_internal_1, getenv_internal)
13204 (Fgetenv_internal):
965d34eb
PE
13205 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
13206
e4d29b33
PE
13207 * lread.c (invalid_syntax): Omit length argument.
13208 All uses changed. This doesn't fix a bug, but it simplifies the
13209 code away from its former Hollerith-constant appearance, and it's
13210 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 13211 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 13212
eb49b136
PE
13213 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
13214 This didn't break anything, but it didn't help either.
13215 It's confusing to put a bogus integer in a place where the actual
13216 value does not matter.
9f62aeb1 13217 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 13218 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 13219
15375a22
PE
13220 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
13221 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
13222 implementation.
b61cc01c
PE
13223 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
13224 We prefer signed types, and the value cannot exceed the EMACS_INT
13225 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
13226 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
13227 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
13228 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 13229
53b2623d
PE
13230 * indent.c (sane_tab_width): New function.
13231 (current_column, scan_for_column, Findent_to, position_indentation)
13232 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 13233 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 13234
51cab52b 13235 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 13236
f2ed8a70
PE
13237 * lisp.h (lint_assume): New macro.
13238 * composite.c (composition_gstring_put_cache):
13239 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
13240
abe80cc6
PE
13241 * editfns.c, insdel.c:
13242 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 13243
b02c740e
PE
13244 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
13245
ebc96716
PE
13246 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
13247
b4e50fa0 13248 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 13249 Use much-faster test for byte-length change.
311d5d7c 13250 Don't assume string byte-length fits in 'int'.
a4cf38e4 13251 Check that character arg fits in 'int'.
85461888 13252 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 13253
c0c1ee9f
PE
13254 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
13255
a498d7f4
PE
13256 * fns.c (concat): Catch string overflow earlier.
13257 Do not rely on integer wraparound.
13258
51cab52b
PE
13259 * dispextern.h (struct it.overlay_strings_charpos)
13260 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
13261 * xdisp.c (forward_to_next_line_start)
13262 (back_to_previous_visible_line_start)
13263 (reseat_at_next_visible_line_start, next_element_from_buffer):
13264 Don't arbitrarily truncate the value of 'selective' to int.
13265
76031fad
PE
13266 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
13267
5eb55db9
PE
13268 * composite.c: Don't truncate sizes to 'int'.
13269 (composition_gstring_p, composition_reseat_it)
13270 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
13271 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
13272 not EMACS_UINT, for indexes.
5eb55db9 13273
0703a717
PE
13274 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
13275
d6202519
PE
13276 * buffer.c: Include <verify.h>.
13277 (struct sortvec.priority, struct sortstr.priority):
8961a454 13278 Now EMACS_INT, not int.
c20998a7 13279 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
13280 (struct sortstr.size, record_overlay_string)
13281 (struct sortstrlist.size, struct sortlist.used):
13282 Don't truncate size to int.
13283 (record_overlay_string): Check for size-calculation overflow.
d6202519 13284 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 13285
d5a19415
JM
132862011-06-22 Jim Meyering <meyering@redhat.com>
13287
029529ac 13288 Don't leak an XBM-image-sized buffer
d5a19415
JM
13289 * image.c (xbm_load): Free the image buffer after using it.
13290
a9041e6c
PE
132912011-06-21 Paul Eggert <eggert@cs.ucla.edu>
13292
13293 Port to Sun C.
13294 * composite.c (find_automatic_composition): Omit needless 'return 0;'
13295 that Sun C diagnosed.
13296 * fns.c (secure_hash): Fix pointer signedness issue.
13297 * intervals.c (static_offset_intervals): New function.
13298 (offset_intervals): Use it.
13299
7f3f739f
LL
133002011-06-21 Leo Liu <sdl.web@gmail.com>
13301
13302 * deps.mk (fns.o):
13303 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
13304 sha512.h.
13305
13306 * fns.c (secure_hash): Rename from crypto_hash_function and change
13307 the first arg to accept symbols.
5b66d427 13308 (Fsecure_hash): New primitive.
7f3f739f
LL
13309 (syms_of_fns): New symbols.
13310
76147d94
DD
133112011-06-20 Deniz Dogan <deniz@dogan.se>
13312
13313 * process.c (Fset_process_buffer): Clarify return value in
13314 docstring.
13315
7d7d0045
CY
133162011-06-18 Chong Yidong <cyd@stupidchicken.com>
13317
13318 * dispnew.c (add_window_display_history): Use BVAR.
13319
13320 * xdisp.c (debug_method_add): Use BVAR.
13321 (check_window_end, dump_glyph_matrix, dump_glyph)
13322 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
13323
13324 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
13325 Likewise.
13326
13327 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
13328 check till after the cache is created in init_frame_faces.
13329
ff2bc410
SM
133302011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
13331
13332 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
13333
28177add
PE
133342011-06-16 Paul Eggert <eggert@cs.ucla.edu>
13335
dd3482fe
PE
13336 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
13337 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
13338 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
13339
393d71f3 13340 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
13341 * fileio.c (Finsert_file_contents):
13342 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
13343 Remove the old (too-loose) buffer overflow checks.
13344 They weren't needed, since make_gap checks for buffer overflow.
13345 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
13346 The old code merely checked for Emacs fixnum overflow, and relied
13347 on undefined (wraparound) behavior. The new code avoids undefined
13348 behavior, and also checks for ptrdiff_t and/or size_t overflow.
13349
2e6813b0 13350 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
13351 Tune. Don't use wider integers than needed. Don't use alloca.
13352 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 13353
599a9e4f
PE
13354 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
13355
99561444
PE
13356 * insdel.c, lisp.h (buffer_overflow): New function.
13357 (insert_from_buffer_1, replace_range, replace_range_2):
13358 * insdel.c (make_gap_larger):
13359 * editfns.c (Finsert_char):
13360 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
13361
28177add
PE
13362 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
13363
e69dafad
PE
133642011-06-15 Paul Eggert <eggert@cs.ucla.edu>
13365
4baa020d 13366 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 13367
b1c46f02
PE
13368 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
13369 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
13370
e69dafad
PE
13371 * fileio.c: Don't assume EMACS_INT fits in off_t.
13372 (emacs_lseek): New static function.
13373 (Finsert_file_contents, Fwrite_region): Use it.
13374 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
13375
566684ea
PE
13376 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
13377
e6966cd6
PE
13378 * fns.c: Don't overflow int when computing a list length.
13379 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
13380 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
13381 truncation on 64-bit hosts. Check for QUIT every
13382 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
13383 faster and is responsive enough.
13384 (Flength): Report an error instead of overflowing an integer.
13385 (Fsafe_length): Return a float if the value is not representable
13386 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 13387 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 13388 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 13389
dd0b0efb
PE
13390 * alloc.c: Check that resized vectors' lengths fit in fixnums.
13391 (header_size, word_size): New constants.
13392 (allocate_vectorlike): Don't check size overflow here.
13393 (allocate_vector): Check it here instead, since this is the only
13394 caller of allocate_vectorlike that could cause overflow.
13395 Check that the new vector's length is representable as a fixnum.
13396
86fe5cfe
PE
13397 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
13398 The previous code was bogus. For example, next_almost_prime (32)
13399 returned 39, which is undesirable as it is a multiple of 3; and
13400 next_almost_prime (24) returned 25, which is a multiple of 5 so
13401 why was the code bothering to check for multiples of 7?
13402
80e88859
PE
13403 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
13404
4a2f0ad6
PE
13405 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
13406
f66c7cf8
PE
13407 Variadic C functions now count arguments with ptrdiff_t.
13408 This partly undoes my 2011-03-30 change, which replaced int with size_t.
13409 Back then I didn't know that the Emacs coding style prefers signed int.
13410 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
13411 were being counted with int, which may truncate counts on 64-bit
13412 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
13413 * lisp.h (struct Lisp_Subr.function.aMANY)
13414 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
13415 Arg counts are now ptrdiff_t, not size_t.
13416 All variadic functions and their callers changed accordingly.
13417 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
13418 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
13419 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
13420 * callint.c (Fcall_interactively): Check arg count for overflow,
13421 to avoid potential buffer overrun. Use signed char, not 'int',
13422 for 'varies' array, so that we needn't bother to check its size
13423 calculation for overflow.
13424 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
13425 * eval.c (apply_lambda):
13426 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
13427 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
13428 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
13429
a1759b76
PE
13430 * callint.c (Fcall_interactively): Don't use index var as event count.
13431
d96be9fc
PE
13432 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
13433 * mem-limits.h (SIZE): Remove; no longer used.
13434
a690a978 13435 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 13436
578c21e6
PE
13437 Remove unnecessary casts.
13438 * xterm.c (x_term_init):
13439 * xfns.c (x_set_border_pixel):
13440 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
13441 These aren't needed now that we assume ANSI C.
13442
96f53c6c
PE
13443 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
13444 It's more likely to cause problems (due to unsigned overflow)
13445 than to cure them.
13446
83c77d31
PE
13447 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
13448
ee2079f1
PE
13449 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
13450
6da65536
PE
13451 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
13452
7147c4a4
PE
13453 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
13454
193e32d9
PE
13455 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
13456
e5533da6
PE
13457 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
13458
9910e595
PE
13459 GLYPH_CODE_FACE returns EMACS_INT, not int.
13460 * dispextern.h (merge_faces):
13461 * xfaces.c (merge_faces):
01103c44
PE
13462 * xdisp.c (get_next_display_element, next_element_from_display_vector):
13463 Don't assume EMACS_INT fits in int.
9910e595 13464
2638320e
PE
13465 * character.h (CHAR_VALID_P): Remove unused parameter.
13466 * fontset.c, lisp.h, xdisp.c: All uses changed.
13467
045eb8d9
PE
13468 * editfns.c (Ftranslate_region_internal): Omit redundant test.
13469
c1f134b5
PE
13470 * fns.c (concat): Minor tuning based on overflow analysis.
13471 This doesn't fix any bugs. Use int to hold character, instead
13472 of constantly refetching from Emacs object. Use XFASTINT, not
13473 XINT, for value known to be a character. Don't bother comparing
13474 a single byte to 0400, as it's always less.
13475
395fcb93 13476 * floatfns.c (Fexpt):
327eeec8
PE
13477 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
13478
abbd3d23
PE
13479 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
13480 for characters.
13481
684a03ef
PE
13482 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
13483
0fed43f3
PE
13484 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
13485 Without this fix, on a 64-bit host (aset S 0 4294967386) would
13486 incorrectly succeed when S was a string, because 4294967386 was
13487 truncated before it was used.
13488
8fd02eb7
PE
13489 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
13490 Otherwise, an out-of-range integer could cause undefined behavior
13491 on a 64-bit host.
13492
f8c86b69
PE
13493 * composite.c: Use int, not EMACS_INT, for characters.
13494 (fill_gstring_body, composition_compute_stop_pos): Use int, not
13495 EMACS_INT, for values that are known to be in character range.
13496 This doesn't fix any bugs but is the usual style inside Emacs and
13497 may generate better code on 32-bit machines.
13498
34206dd2
PE
13499 Make sure a 64-bit char is never passed to ENCODE_CHAR.
13500 This is for reasons similar to the recent CHAR_STRING fix.
13501 * charset.c (Fencode_char): Check that character arg is actually
13502 a character. Pass an int to ENCODE_CHAR.
13503 * charset.h (ENCODE_CHAR): Verify that the character argument is no
13504 wider than 'int', as a compile-time check to prevent future regressions
13505 in this area.
13506
c5958d4c 13507 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
13508
13509 Make sure a 64-bit char is never passed to CHAR_STRING.
13510 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
13511 by silently ignoring the top 32 bits, allowing some values
13512 that were far too large to be valid characters.
13513 * character.h: Include <verify.h>.
13514 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
13515 arguments are no wider than unsigned, as a compile-time check
13516 to prevent future regressions in this area.
13517 * data.c (Faset):
01103c44 13518 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
13519 (Fsubst_char_in_region):
13520 * fns.c (concat):
13521 * xdisp.c (decode_mode_spec_coding):
13522 Adjust to CHAR_STRING's new requirement.
13523 * editfns.c (Finsert_char, Fsubst_char_in_region):
13524 * fns.c (concat): Check that character args are actually
13525 characters. Without this test, these functions did the wrong
13526 thing with wildly out-of-range values on 64-bit hosts.
13527
d37ca623
PE
13528 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
13529 These casts should not be needed on 32-bit hosts, either.
13530 * keyboard.c (read_char):
13531 * lread.c (Fload): Remove casts to unsigned.
13532
ea204efb
PE
13533 * lisp.h (UNSIGNED_CMP): New macro.
13534 This fixes comparison bugs on 64-bit hosts.
13535 (ASCII_CHAR_P): Use it.
13536 * casefiddle.c (casify_object):
01103c44 13537 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
13538 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
13539 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
13540 * dispextern.h (FACE_FROM_ID):
13541 * keyboard.c (read_char): Use UNSIGNED_CMP.
13542
41cb286c
PE
13543 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
13544 not to EMACS_INT, to avoid GCC warning.
13545
4a1b9832
PE
13546 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
13547
55daad71
PE
13548 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
13549 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
13550 isn't needed on 32-bit machines.
8f95c75c 13551
01103c44
PE
13552 * buffer.c (Fgenerate_new_buffer_name):
13553 Use EMACS_INT for count, not int.
0ceccced 13554 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
13555
13556 * data.c (Qcompiled_function): Now static.
13557
c6f072e7
PE
13558 * window.c (window_body_lines): Now static.
13559
20ce5912
PE
13560 * image.c (gif_load): Rename local to avoid shadowing.
13561
9c4c5f81
PE
13562 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
13563 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
13564 * alloc.c (make_save_value): Integer argument is now of type
13565 ptrdiff_t, not int.
13566 (mark_object): Use ptrdiff_t, not int.
13567 * lisp.h (pD): New macro.
13568 * print.c (print_object): Use it.
13569
c0c5c8ae
PE
13570 * alloc.c: Use EMACS_INT, not int, to count objects.
13571 (total_conses, total_markers, total_symbols, total_vector_size)
13572 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
13573 (total_free_floats, total_floats, total_free_intervals)
13574 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
13575 Now EMACS_INT, not int. All uses changed.
13576 (Fgarbage_collect): Compute overall total using a double, so that
13577 integer overflow is less likely to be a problem. Check for overflow
13578 when converting back to an integer.
5a25e253
PE
13579 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
13580 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
13581 These were 'int' variables that could overflow on 64-bit hosts;
13582 they were never used, so remove them instead of repairing them.
211a0b2a 13583 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
13584 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
13585 Previously, this ceilinged at INT_MAX, but that doesn't work on
13586 64-bit machines.
e46bb31a 13587 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 13588
c78baabf 13589 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 13590 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
13591 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
13592 when a (possibly-narrower) signed value would do just as well.
13593 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 13594
c9d624c6
PE
13595 * alloc.c: Catch some string size overflows that we were missing.
13596 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
13597 for convenience in STRING_BYTES_MAX.
13598 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
13599 The definition here is exact; the one in lisp.h was approximate.
13600 (allocate_string_data): Check for string overflow. This catches
13601 some instances we weren't catching before. Also, it catches
13602 size_t overflow on (unusual) hosts where SIZE_MAX <= min
13603 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
13604 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 13605
c9d624c6
PE
13606 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
13607 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 13608 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 13609
353032ce
PE
13610 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
13611
2bccce07
PE
13612 * alloc.c (Fmake_string): Check for out-of-range init.
13613
0ac30604
SM
136142011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
13615
13616 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
13617
c195f2de
JD
136182011-06-14 Jan Djärv <jan.h.d@swipnet.se>
13619
13620 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
13621 xg_get_default_scrollbar_width.
13622
13623 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
13624 (int_gtk_range_get_value): Move to the scroll bar part of the file.
13625 (style_changed_cb): Call update_theme_scrollbar_width and call
13626 x_set_scroll_bar_default_width and xg_frame_set_char_size for
13627 all frames (Bug#8505).
13628 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
13629 Call gtk_window_set_resizable if HAVE_GTK3.
13630 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
13631 and height if HAVE_GTK3 (Bug#8505).
13632 (scroll_bar_width_for_theme): New variable.
13633 (update_theme_scrollbar_width): New function.
13634 (xg_get_default_scrollbar_width): Move code to
13635 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
13636 (xg_initialize): Call update_theme_scrollbar_width.
13637
13638 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
13639
13640 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
13641
e10ac9f1
MR
136422011-06-12 Martin Rudalics <rudalics@gmx.at>
13643
13644 * frame.c (make_frame): Call other_buffer_safely instead of
13645 other_buffer.
13646
13647 * window.c (temp_output_buffer_show): Call display_buffer with
13648 second argument Vtemp_buffer_show_specifiers and reset latter
13649 immediately after the call.
13650 (Vtemp_buffer_show_specifiers): New variable.
13651 (auto_window_vscroll_p, next_screen_context_lines)
13652 (Vscroll_preserve_screen_position): Remove leading asterisks from
13653 doc-strings.
13654
2d3c217e 136552011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 13656
7b7f97e8 13657 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
13658 * buffer.c (Qclone_number): Remove for now, as it's unused.
13659 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
13660 (record_buffer): Remove unused local.
13661 * frame.c (other_visible_frames, frame_buffer_list): Now static.
13662 (set_frame_buffer_list): Remove; unused.
13663 * frame.h (other_visible_frames): Remove decl.
13664 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
13665 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
13666 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
13667 if HAVE_GPM.
13668 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
13669 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
13670 Define only if HAVE_GPM.
13671 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
13672 (update_hints_inhibit): Remove; never set. All uses removed.
13673 * widgetprv.h (emacsFrameClassRec): Remove decl.
13674 * window.c (delete_deletable_window): Now returns void, since it
13675 wasn't returning anything.
13676 (compare_window_configurations): Remove unused locals.
13677 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
13678 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
13679 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
13680 the same widths as pointers. This follows up on the 2011-05-06 patch.
13681 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
13682 * xterm.h: Likewise.
13683 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
13684
1384b89e
JB
136852011-06-12 Juanma Barranquero <lekktu@gmail.com>
13686
13687 * makefile.w32-in: Update dependencies.
13688 (LISP_H): Add lib/intprops.h.
13689
1100a63c
CY
136902011-06-11 Chong Yidong <cyd@stupidchicken.com>
13691
13692 * image.c (gif_load): Add animation frame delay to the metadata.
13693 (syms_of_image): Use DEFSYM. New symbol `delay'.
13694
6198ccd0
MR
136952011-06-11 Martin Rudalics <rudalics@gmx.at>
13696
13697 * window.c (delete_deletable_window): Re-add.
13698 (Fset_window_configuration): Rewrite to handle dead buffers and
13699 consequently deletable windows.
13700 (window_tree, Fwindow_tree): Remove. Supply functionality in
13701 window.el.
13702 (compare_window_configurations): Simplify code.
13703
b6e3633c
AS
137042011-06-11 Andreas Schwab <schwab@linux-m68k.org>
13705
1ab0dee5
AS
13706 * image.c (imagemagick_load_image): Fix type mismatch.
13707 (Fimagemagick_types): Likewise.
13708
b6e3633c
AS
13709 * window.h (replace_buffer_in_windows): Declare.
13710
9397e56f
MR
137112011-06-11 Martin Rudalics <rudalics@gmx.at>
13712
13713 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
13714 Qclone_number. Remove external declaration of Qdelete_window.
13715 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
13716 code.
640c8776
SM
13717 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
13718 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
13719 (Fother_buffer): Rewrite doc-string. Major rewrite for new
13720 buffer list implementation.
13721 (other_buffer_safely): New function.
13722 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
13723 calls to replace_buffer_in_windows and
13724 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
13725 if allowed.
13726 (record_buffer): Inhibit quitting and rewrite using quittable
13727 functions. Run Qbuffer_list_update_hook if allowed.
13728 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
13729 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
13730 Move switch-to-buffer to window.el.
9397e56f
MR
13731 (bury-buffer): Move to window.el.
13732 (Vbuffer_list_update_hook): New variable.
13733
13734 * lisp.h (other_buffer_safely): Add prototype in buffer.c
13735 section.
13736
13737 * window.h (resize_frame_windows): Move up in code.
13738 (Fwindow_frame): Remove EXFUN.
13739 (replace_buffer_in_all_windows): Remove prototype.
13740 (replace_buffer_in_windows_safely): Add prototype.
13741
13742 * window.c: Declare Qdelete_window static again. Move down
13743 declaration of select_count.
13744 (Fnext_window, Fprevious_window): Rewrite doc-strings.
13745 (Fother_window): Move to window.el.
13746 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
13747 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
13748 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
13749 window.el.
13750 (replace_buffer_in_windows): Implement by calling
13751 Qreplace_buffer_in_windows.
13752 (replace_buffer_in_all_windows): Remove with some functionality
13753 moved into replace_buffer_in_windows_safely.
13754 (replace_buffer_in_windows_safely): New function.
13755 (select_window_norecord, select_frame_norecord): Move in front
13756 of run_window_configuration_change_hook. Remove now obsolete
13757 declarations.
640c8776
SM
13758 (Fset_window_buffer): Rewrite doc-string.
13759 Call Qrecord_window_buffer.
9397e56f
MR
13760 (keys_of_window): Move binding for other-window to window.el.
13761
b50691aa
CY
137622011-06-11 Chong Yidong <cyd@stupidchicken.com>
13763
13764 * dispextern.h (struct image): Replace data member, whose int_val
13765 and ptr_val fields were not used by anything, with a single
13766 lisp_val object.
13767
13768 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
13769 (gif_clear_image, gif_load, imagemagick_load_image)
13770 (gs_clear_image, gs_load): Callers changed.
13771
3f754b86
PE
137722011-06-10 Paul Eggert <eggert@cs.ucla.edu>
13773
cca69397
PE
13774 * buffer.h: Include <time.h>, for time_t.
13775 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
13776
109e28d0
PE
13777 Fix minor problems found by static checking.
13778
60737f02
PE
13779 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
13780
4b66faf3
PE
13781 Make identifiers static if they are not used in other modules.
13782 * data.c (Qcompiled_function, Qframe, Qvector):
13783 * image.c (QimageMagick, Qsvg):
13784 * minibuf.c (Qmetadata):
13785 * window.c (resize_window_check, resize_root_window): Now static.
13786 * window.h (resize_window_check, resize_root_window): Remove decls.
13787
109e28d0
PE
13788 * window.c (window_deletion_count, delete_deletable_window):
13789 Remove; unused.
46a4ce9e
PE
13790 (window_body_lines): Now static.
13791 (Fdelete_other_windows_internal): Mark vars as initialized.
13792 Make sure 'resize_failed' is initialized.
13793 (run_window_configuration_change_hook): Rename local to avoid shadowing.
13794 (resize_window_apply): Remove unused local.
13795 * window.h (delete_deletable_window): Remove decl.
13796
109e28d0 13797 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
13798 (imagemagick_load_image): Fix pointer signedness problem by changing
13799 last arg from unsigned char * to char *. All uses changed.
13800 Also, fix a local for similar reasons.
13801 Remove unused locals. Remove locals to avoid shadowing.
13802 (fn_rsvg_handle_free): Remove; unused.
13803 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 13804 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 13805
3f754b86
PE
13806 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
13807
2547adb1
CY
138082011-06-10 Chong Yidong <cyd@stupidchicken.com>
13809
13810 * image.c (gif_load): Fix omitted cast error introduced by
13811 2011-06-06 change.
13812
2c8e37d4
MR
138132011-06-10 Martin Rudalics <rudalics@gmx.at>
13814
13815 * window.h (resize_proportionally, orig_total_lines)
13816 (orig_top_line): Remove from window structure.
13817 (set_window_height, set_window_width, change_window_heights)
13818 (Fdelete_window): Remove prototypes.
13819 (resize_frame_windows): Remove duplicate declaration.
13820
440a42e3
EZ
138212011-06-10 Eli Zaretskii <eliz@gnu.org>
13822
13823 * window.h (resize_frame_windows, resize_window_check)
13824 (delete_deletable_window, resize_root_window)
13825 (resize_frame_windows): Declare prototypes.
13826
13827 * window.c (resize_window_apply): Make definition be "static" to
13828 match the prototype.
13829
562dd5e9
MR
138302011-06-10 Martin Rudalics <rudalics@gmx.at>
13831
13832 * window.c: Remove declarations of Qwindow_size_fixed,
13833 window_min_size_1, window_min_size_2, window_min_size,
13834 size_window, window_fixed_size_p, enlarge_window, delete_window.
13835 Remove static from declaration of Qdelete_window, it's
13836 temporarily needed by Fbury_buffer.
13837 (replace_window): Don't assign orig_top_line and
13838 orig_total_lines.
13839 (Fdelete_window, delete_window): Remove. Window deletion is
13840 handled by window.el.
640c8776
SM
13841 (window_loop): Remove DELETE_OTHER_WINDOWS case.
13842 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
13843 (Fdelete_other_windows): Remove. Deleting other windows is
13844 handled by window.el.
13845 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
13846 handled in window.el.
13847 (window_min_size_2, window_min_size_1, window_min_size): Remove.
13848 Window minimum sizes are handled in window.el.
13849 (shrink_windows, size_window, set_window_height)
13850 (set_window_width, change_window_heights, window_height)
13851 (window_width, CURBEG, CURSIZE, enlarge_window)
13852 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
13853 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
13854 handled in window.el.
13855 (make_dummy_parent): Rename to make_parent_window and give it a
13856 second argument horflag.
13857 (make_window): Don't set resize_proportionally any more.
13858 (Fsplit_window): Remove. Windows are split in window.el.
13859 (save_restore_action, save_restore_orig_size)
13860 (shrink_window_lowest_first, save_restore_orig_size): Remove.
13861 Resize mini windows in window.el.
13862 (grow_mini_window, shrink_mini_window): Implement by calling
13863 Qresize_root_window_vertically, resize_window_check and
13864 resize_window_apply.
640c8776
SM
13865 (saved_window, Fset_window_configuration, save_window_save):
13866 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
13867 resize_proportionally.
13868 (window_min_height, window_min_width): Move to window.el.
13869 (keys_of_window): Move bindings for delete-other-windows,
13870 split-window, delete-window and enlarge-window to window.el.
13871
13872 * buffer.c: Temporarily extern Qdelete_window.
13873 (Fbury_buffer): Temporarily call Qdelete_window instead of
13874 Fdelete_window (Fbury_buffer will move to window.el soon).
13875
13876 * frame.c (set_menu_bar_lines_1): Remove code handling
13877 orig_top_line and orig_total_lines.
13878
13879 * dispnew.c (adjust_frame_glyphs_initially): Don't use
13880 set_window_height but set heights directly.
13881 (change_frame_size_1): Use resize_frame_windows.
13882
13883 * xdisp.c (init_xdisp): Don't use set_window_height but set
13884 heights directly.
13885
640c8776
SM
13886 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
13887 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
13888 run_window_configuration_change_hook.
13889
13890 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
13891 instead of change_window_heights and run
13892 run_window_configuration_change_hook.
13893
1a13852e
MR
138942011-06-09 Martin Rudalics <rudalics@gmx.at>
13895
13896 * window.c (replace_window): Rename second argument REPLACEMENT to
13897 NEW. New third argument SETFLAG. Rewrite.
13898 (delete_window, make_dummy_parent): Call replace_window with
13899 third argument 1.
13900 (window_list_1): Move down in code.
13901 (run_window_configuration_change_hook): Move set_buffer part
13902 before select_frame_norecord part in order to unwind correctly.
13903 Rename count1 to count.
13904 (recombine_windows, delete_deletable_window, resize_root_window)
13905 (Fdelete_other_windows_internal)
13906 (Frun_window_configuration_change_hook, make_parent_window)
13907 (resize_window_check, resize_window_apply, Fresize_window_apply)
13908 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
13909 (Fdelete_window_internal, Fresize_mini_window_internal):
13910 New functions.
1a13852e
MR
13911 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
13912
f3d1777e
MR
139132011-06-08 Martin Rudalics <rudalics@gmx.at>
13914
496e208e
MR
13915 * window.h (window): Add some new members to window structure -
13916 normal_lines, normal_cols, new_total, new_normal, clone_number,
13917 splits, nest, prev_buffers, next_buffers.
13918 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 13919 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 13920
f3d1777e
MR
13921 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
13922 Remove.
496e208e
MR
13923 (make_dummy_parent): Set new members of windows structure.
13924 (make_window): Move down in code. Handle new members of window
13925 structure.
13926 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
13927 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
13928 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
13929 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
13930 (Fset_window_next_buffers, Fset_window_clone_number):
13931 New functions.
496e208e
MR
13932 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
13933 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
13934 Doc-string fixes.
13935 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
13936 Argument WINDOW can be now internal window too.
13937 (Fwindow_use_time): Move up in code.
13938 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
13939 Rewrite doc-string.
13940 (Fset_window_configuration, saved_window)
13941 (Fcurrent_window_configuration, save_window_save): Handle new
13942 members of window structure.
b9e809c2
MR
13943 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
13944 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
13945 (syms_of_window): New Lisp objects Qrecord_window_buffer,
13946 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
13947 Qget_mru_window, Qresize_root_window,
13948 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
13949 Qauto_buffer_name; staticpro them.
f3d1777e 13950
abde8f8c
MR
139512011-06-07 Martin Rudalics <rudalics@gmx.at>
13952
13953 * window.c (Fwindow_total_size, Fwindow_left_column)
13954 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
13955 (Fwindow_list_1): New functions.
13956 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
13957 (Fwindow_width, Fscroll_left, Fscroll_right):
13958 Use window_body_cols instead of window_box_text_cols.
13959 (delete_window, Fset_window_configuration):
13960 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
13961 (delete_all_subwindows): Take a window as argument and not a
13962 structure. Rewrite.
190b47e6
MR
13963 (window_loop): Remove handling of GET_LRU_WINDOW and
13964 GET_LARGEST_WINDOW.
13965 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
13966
13967 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
13968 window_box_text_cols. delete_all_subwindows now takes a
13969 Lisp_Object as argument.
abde8f8c 13970
640c8776
SM
13971 * indent.c (compute_motion, Fcompute_motion):
13972 Use window_body_cols instead of window_box_text_cols.
abde8f8c 13973
fa8a67e6
MR
13974 * frame.c (delete_frame): Call delete_all_subwindows with root
13975 window as argument.
13976
a54e3482
DC
139772011-06-07 Daniel Colascione <dan.colascione@gmail.com>
13978
13979 * fns.c (Fputhash): Document return value.
13980
60002bf5
CY
139812011-06-06 Chong Yidong <cyd@stupidchicken.com>
13982
13983 * image.c (gif_load): Implement gif89a spec "no disposal" method.
13984
0c671da6 139852011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 13986
b862a52a 13987 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 13988
be44ca6c
PE
13989 Check for overflow when converting integer to cons and back.
13990 * charset.c (Fdefine_charset_internal, Fdecode_char):
13991 Use cons_to_unsigned to catch overflow.
13992 (Fencode_char): Use INTEGER_TO_CONS.
13993 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
13994 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
13995 * data.c (long_to_cons, cons_to_long): Remove.
13996 (cons_to_unsigned, cons_to_signed): New functions.
13997 These signal an error for invalid or out-of-range values.
13998 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
13999 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
14000 * font.c (Ffont_variation_glyphs):
14001 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
14002 * lisp.h: Include <intprops.h>.
14003 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
14004 (cons_to_signed, cons_to_unsigned): New decls.
14005 (long_to_cons, cons_to_long): Remove decls.
14006 * undo.c (record_first_change): Use INTEGER_TO_CONS.
14007 (Fprimitive_undo): Use CONS_TO_INTEGER.
14008 * xfns.c (Fx_window_property): Likewise.
14009 * xselect.c: Include <limits.h>.
14010 (x_own_selection, selection_data_to_lisp_data):
14011 Use INTEGER_TO_CONS.
14012 (x_handle_selection_request, x_handle_selection_clear)
14013 (x_get_foreign_selection, Fx_disown_selection_internal)
14014 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
14015 (lisp_data_to_selection_data): Use cons_to_unsigned.
14016 (x_fill_property_data): Use cons_to_signed.
14017 Report values out of range.
14018
d1f3d2af
PE
14019 Check for buffer and string overflow more precisely.
14020 * buffer.h (BUF_BYTES_MAX): New macro.
14021 * lisp.h (STRING_BYTES_MAX): New macro.
14022 * alloc.c (Fmake_string):
14023 * character.c (string_escape_byte8):
14024 * coding.c (coding_alloc_by_realloc):
14025 * doprnt.c (doprnt):
14026 * editfns.c (Fformat):
14027 * eval.c (verror):
14028 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
14029 since they may not be the same number.
14030 * editfns.c (Finsert_char):
14031 * fileio.c (Finsert_file_contents):
14032 Likewise for BUF_BYTES_MAX.
14033
dd52fcea
PE
14034 * image.c: Use ptrdiff_t, not int, for sizes.
14035 (slurp_file): Switch from int to ptrdiff_t.
14036 All uses changed.
14037 (slurp_file): Check that file size fits in both size_t (for
14038 malloc) and ptrdiff_t (for sanity and safety).
14039
7f9bbdbb
PE
14040 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
14041 if b->modtime has its maximal value.
14042
dfe18f82
PE
14043 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
14044
84acfcf0
PE
14045 Don't assume time_t can fit into int.
14046 * buffer.h (struct buffer.modtime): Now time_t, not int.
14047 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
14048 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
14049
ccd9a01a
PE
14050 Minor fixes for signed vs unsigned integers.
14051 * character.h (MAYBE_UNIFY_CHAR):
14052 * charset.c (maybe_unify_char):
14053 * keyboard.c (read_char, reorder_modifiers):
14054 XINT -> XFASTINT, since the integer must be nonnegative.
14055 * ftfont.c (ftfont_spec_pattern):
14056 * keymap.c (access_keymap, silly_event_symbol_error):
14057 XUINT -> XFASTINT, since the integer must be nonnegative.
14058 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
14059 since it makes no difference and we prefer signed.
14060 * keyboard.c (record_char): Use XUINT when all the neighbors do.
14061 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
14062 nonnegative.
14063
d6d100dd
SM
140642011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
14065
14066 * window.h (Fwindow_frame): Declare.
14067
2b6148e4
PE
140682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14069
14070 * alloc.c: Simplify handling of large-request failures (Bug#8800).
14071 (SPARE_MEMORY): Always define.
14072 (LARGE_REQUEST): Remove.
14073 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
14074
f230ecc9
MR
140752011-06-06 Martin Rudalics <rudalics@gmx.at>
14076
727e958e
MR
14077 * lisp.h: Move EXFUNS for Fframe_root_window,
14078 Fframe_first_window and Fset_frame_selected_window to window.h.
14079
14080 * window.h: Move EXFUNS for Fframe_root_window,
14081 Fframe_first_window and Fset_frame_selected_window here from
14082 lisp.h.
14083
14084 * frame.c (Fwindow_frame, Fframe_first_window)
14085 (Fframe_root_window, Fframe_selected_window)
14086 (Fset_frame_selected_window): Move to window.c.
14087 (Factive_minibuffer_window): Move to minibuf.c.
14088 (Fother_visible_frames_p): New function.
14089
14090 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
14091
f230ecc9
MR
14092 * window.c (decode_window, decode_any_window): Move up in code.
14093 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
14094 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
14095 (Fwindow_buffer): Move up and rewrite doc-string.
14096 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
14097 (Fwindow_prev): New functions.
727e958e
MR
14098 (Fwindow_frame): Move here from frame.c. Accept any window as
14099 argument.
14100 (Fframe_root_window, Fframe_first_window)
14101 (Fframe_selected_window): Move here from frame.c. Accept frame
14102 or arbitrary window as argument. Update doc-strings.
14103 (Fminibuffer_window): Move up in code.
14104 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
14105 (Fset_frame_selected_window): Move here from frame.c.
14106 Marginal rewrite.
727e958e
MR
14107 (Fselected_window, select_window, Fselect_window): Move up in
14108 code. Minor doc-string fixes.
f230ecc9 14109
4d09bcf6
PE
141102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14111
14112 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
14113 Do not assume that spare memory exists; that assumption is valid
14114 only if SYSTEM_MALLOC.
14115 (LARGE_REQUEST): New macro, so that the issue of large requests
14116 is separated from the issue of spare memory.
14117
810928a2
AS
141182011-06-05 Andreas Schwab <schwab@linux-m68k.org>
14119
172418ad
AS
14120 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
14121 format. (Bug#8806)
14122
43f862f7
AS
14123 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
14124
810928a2
AS
14125 * xfns.c (x_set_scroll_bar_default_width): Move declarations
14126 before statements.
14127
a059fe24
JD
141282011-06-05 Jan Djärv <jan.h.d@swipnet.se>
14129
14130 * gtkutil.c (xg_get_default_scrollbar_width): New function.
14131
14132 * gtkutil.h: Declare xg_get_default_scrollbar_width.
14133
14134 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
14135 min width by calling x_set_scroll_bar_default_width (Bug#8505).
14136
989bf368
JB
141372011-06-05 Juanma Barranquero <lekktu@gmail.com>
14138
14139 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
14140
4b80f674
CY
141412011-06-04 Chong Yidong <cyd@stupidchicken.com>
14142
14143 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
14144 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
14145 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
14146 New error handlers.
4b80f674
CY
14147 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
14148 Obey Vx_select_enable_clipboard_manager. Catch errors in
14149 x_clipboard_manager_save (Bug#8779).
14150 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 14151 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 14152
99a33b77 141532011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
14154
14155 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
14156
99a33b77 141572011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
14158
14159 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
14160 in the current matrix if keep_current_p is non-zero.
14161
8264569d
EZ
141622011-06-04 Eli Zaretskii <eliz@gnu.org>
14163
14164 * bidi.c (bidi_level_of_next_char): Fix last change.
14165
57f97249
EZ
141662011-06-03 Eli Zaretskii <eliz@gnu.org>
14167
fec2107c 14168 Support bidi reordering of text covered by display properties.
57f97249 14169
fec2107c
EZ
14170 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
14171 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
14172 (bidi_cache_search, bidi_cache_iterator_state)
14173 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
14174 (bidi_level_of_next_char, bidi_move_to_visually_next):
14175 Support character positions inside a run of characters covered by a
fec2107c
EZ
14176 display string.
14177 (bidi_paragraph_init, bidi_resolve_explicit_1)
14178 (bidi_level_of_next_char): Call bidi_fetch_char and
14179 bidi_fetch_char_advance instead of FETCH_CHAR and
14180 FETCH_CHAR_ADVANCE.
14181 (bidi_init_it): Initialize new members.
14182 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
14183 definitions.
14184 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
14185 instead of using explicit *_CHAR codes.
d6d100dd
SM
14186 (bidi_resolve_explicit, bidi_resolve_weak):
14187 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
14188 bidirectional text is supported only in multibyte buffers.
14189 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
14190 it to initialize the frame_window_p member of struct bidi_it.
14191 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
14192 (bidi_resolve_explicit, bidi_resolve_weak)
14193 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
14194 bidi_it->nchars is non-positive.
14195 (bidi_level_of_next_char): Don't try to lookup the cache for the
14196 next/previous character if nothing is cached there yet, or if we
14197 were just reseat()'ed to a new position.
c40e2fb2 14198
0e14fe90
EZ
14199 * xdisp.c (set_cursor_from_row): Set start and stop points
14200 according to the row's direction when priming the loop that looks
14201 for the glyph on which to display cursor.
14202 (single_display_spec_intangible_p): Function deleted.
14203 (display_prop_intangible_p): Reimplement to call
14204 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
14205 Accept 3 additional arguments needed by handle_display_spec.
14206 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
14207 values: lists, `(when COND...)' forms, etc.
14208 (single_display_spec_string_p): Support property values that are
14209 lists with the argument STRING its top-level element.
14210 (display_prop_string_p): Fix the condition for processing a
14211 property that is a list to be consistent with handle_display_spec.
fec2107c 14212 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
14213 last portion of handle_display_prop.
14214 (compute_display_string_pos): Accept additional argument
14215 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
14216 value of a `display' property is a "replacing spec".
14217 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
14218 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
14219 the display property, but just return a value indicating whether
14220 the display property will replace the characters it covers.
14221 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
14222 frame_window_p members of struct bidi_it.
d6d100dd
SM
14223 (compute_display_string_pos, compute_display_string_end):
14224 New functions.
fec2107c
EZ
14225 (push_it): Accept second argument POSITION, where pop_it should
14226 jump to continue iteration.
14227 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 14228
fec2107c
EZ
14229 * keyboard.c (adjust_point_for_property): Adjust the call to
14230 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
14231
14232 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
14233 (bidi_init_it): Update prototypes.
14234 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
14235 (compute_display_string_pos, compute_display_string_end):
14236 Declare prototypes.
fec2107c
EZ
14237 (struct bidi_it): New members nchars and disp_pos. ch_len is now
14238 EMACS_INT.
fc6f18ce 14239
40087514 142402011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 14241
57f53182
PE
14242 Malloc failure behavior now depends on size of allocation.
14243 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
14244 * lisp.h: Change signatures accordingly.
14245 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
14246 All callers changed. (Bug#8762)
14247
14248 * gnutls.c: Use Emacs's memory allocators.
14249 Without this change, the gnutls library would invoke malloc etc.
14250 directly, which causes problems on non-SYNC_INPUT hosts, and which
14251 runs afoul of improving memory_full behavior. (Bug#8761)
14252 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
14253 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
14254 xfree instead of the default malloc, realloc, free.
14255 (Fgnutls_boot): No need to check for memory allocation failure,
14256 since xmalloc does that for us.
14257
ac32cd99 14258 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
14259 * category.c (hash_get_category_set):
14260 * ccl.c (ccl_driver):
14261 * charset.c (Fdefine_charset_internal):
14262 * charset.h (struct charset.hash_index):
14263 * composite.c (get_composition_id, gstring_lookup_cache)
14264 (composition_gstring_put_cache):
14265 * composite.h (struct composition.hash_index):
14266 * dispextern.h (struct image.hash):
14267 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
14268 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
14269 (hashfn_equal, hashfn_user_defined, make_hash_table)
14270 (maybe_resize_hash_table, hash_lookup, hash_put)
14271 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
14272 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
14273 (Fsxhash, Fgethash, Fputhash, Fmaphash):
14274 * image.c (make_image, search_image_cache, lookup_image)
14275 (xpm_put_color_table_h):
14276 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 14277 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 14278 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 14279 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
14280 * alloc.c (allocate_vectorlike):
14281 Check for overflow in vector size calculations.
14282 * ccl.c (ccl_driver):
14283 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
14284 * fns.c, image.c: Remove unnecessary static decls that would otherwise
14285 need to be updated by these changes.
40087514
PE
14286 * fns.c (make_hash_table, maybe_resize_hash_table):
14287 Check for integer overflow with large hash tables.
0de4bb68
PE
14288 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
14289 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
14290 (SXHASH_REDUCE): New macro.
14291 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
14292 Use it instead of discarding useful hash info with large hash values.
14293 (sxhash_float): New function.
14294 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
14295 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
14296 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
14297 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
14298 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
14299 Adjust signatures to match updated version of code.
14300 (consing_since_gc): Now EMACS_INT, since a single hash table can
14301 use more than INT_MAX bytes.
14302
698d32e2
DN
143032011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
14304
14305 Make it possible to build with GCC-4.6+ -O2 -flto.
14306
14307 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
14308
fd6fa53f
SM
143092011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
14310
14311 * minibuf.c (get_minibuffer, read_minibuf_unwind):
14312 Call minibuffer-inactive-mode.
14313
864db017
JB
143142011-05-31 Juanma Barranquero <lekktu@gmail.com>
14315
14316 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
14317 Update dependencies.
14318
2ad0baf4
DN
143192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14320
14321 * data.c (init_data): Remove code for UTS, this system is not
14322 supported anymore.
14323
4fcc2638
DN
143242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14325
14326 Don't force ./temacs to start in terminal mode.
14327
14328 * frame.c (make_initial_frame): Initialize faces in all cases, not
14329 only when CANNOT_DUMP is defined.
14330 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
14331
c56e0fd5
DN
143322011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14333
14334 * dispnew.c (add_window_display_history): Use const for the string
14335 pointer. Remove declaration, not needed.
14336
333d54da 143372011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 14338
55d4c1b2 14339 Use 'inline', not 'INLINE'.
333d54da 14340 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
14341 * alloc.c, fontset.c (INLINE): Remove.
14342 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
14343 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
14344 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
14345 * gmalloc.c (register_heapinfo): Use inline unconditionally.
14346 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
14347
738db178
DN
143482011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14349
14350 Make it possible to run ./temacs.
14351
14352 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
14353 syms_of_callproc does the same thing. Remove test for
14354 "initialized", do it in the caller.
14355 * emacs.c (main): Avoid calling set_initial_environment when dumping.
14356
620c53a6
SM
143572011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
14358
14359 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
14360 (read_minibuf): Use get_minibuffer.
14361 (syms_of_minibuf): Use DEFSYM.
14362 (Qmetadata): New var.
14363 * data.c (Qbuffer): Don't make it static.
14364 (syms_of_data): Use DEFSYM.
14365
e003a292
PE
143662011-05-31 Paul Eggert <eggert@cs.ucla.edu>
14367
14368 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
14369 (CCL_CODE_MIN): New macro.
14370
ed008a6d
PE
143712011-05-30 Paul Eggert <eggert@cs.ucla.edu>
14372
3687c2ef
PE
14373 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
14374
ed008a6d
PE
14375 * eval.c (Qdebug): Now static.
14376 * lisp.h (Qdebug): Remove decl. This reverts a part of the
14377 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
14378 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
14379
d66c4c7c
CY
143802011-05-29 Chong Yidong <cyd@stupidchicken.com>
14381
14382 * image.c: Various fixes to ImageMagick code comments.
14383 (Fimagemagick_types): Doc fix.
14384
5fbc2025
PE
143852011-05-29 Paul Eggert <eggert@cs.ucla.edu>
14386
0196f88a
PE
14387 Minor fixes prompted by GCC 4.6.0 warnings.
14388
14389 * xselect.c (converted_selections, conversion_fail_tag): Now static.
14390
5fbc2025
PE
14391 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
14392 (x_clipboard_manager_save_all): Move extern decl to ...
14393 * xterm.h: ... here, so that it can be checked for consistency.
14394
1dd3c2d9
CY
143952011-05-29 Chong Yidong <cyd@stupidchicken.com>
14396
14397 * xselect.c (x_clipboard_manager_save_frame)
14398 (x_clipboard_manager_save_all): New functions.
14399 (Fx_clipboard_manager_save): Lisp function deleted.
14400
14401 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
14402 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
14403
14404 * xterm.h: Update prototype.
14405
5ba6571d
WX
144062011-05-28 William Xu <william.xwl@gmail.com>
14407
14408 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
14409 exiting (Bug#8239).
14410
3eaff834
JM
144112011-05-28 Jim Meyering <meyering@redhat.com>
14412
e1900994 14413 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
14414 * fns.c (to_uchar): Define.
14415 (crypto_hash_function): Use it to convert some newly-signed
14416 variables to unsigned, to avoid sign-extension bugs. For example,
14417 without this change, (md5 "truc") would evaluate to
14418 45723a2aff78ff4fff7fff1114760e62 rather than the expected
14419 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 14420 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 14421
0f6990a7
PE
144222011-05-27 Paul Eggert <eggert@cs.ucla.edu>
14423
14424 Integer overflow fixes.
c8a9ca5a 14425
08686060
PE
14426 * dbusbind.c: Serial number integer overflow fixes.
14427 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
14428 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
14429 to hold a serial number that is too large for a fixnum.
14430 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14431 Check for serial numbers out of range. Decode any serial number
59568bf0 14432 that was so large that it became a float. (Bug#8722)
08686060 14433
2d1fc3c7
PE
14434 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
14435 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14436 Use XFASTINT rather than XUINT when numbers are nonnegative.
14437 (xd_append_arg, Fdbus_method_return_internal):
14438 (Fdbus_method_error_internal): Likewise. Also, for unsigned
14439 arguments, check that Lisp number is nonnegative, rather than
59568bf0 14440 silently wrapping negative numbers around. (Bug#8722)
30217ff0 14441 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 14442 (Bug#8722)
2d1fc3c7 14443
c8a9ca5a
PE
14444 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
14445
519e1d69
PE
14446 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
14447
6df6ae42 14448 ccl: Add integer overflow checks.
30569699
PE
14449 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
14450 (IN_INT_RANGE): New macros.
14451 (ccl_driver): Use them to check for integer overflow when
14452 decoding a CCL program. Many of the new checks are whether XINT (x)
14453 fits in int; it doesn't always, on 64-bit hosts. The new version
14454 doesn't catch all possible integer overflows, but it's an
847044ea 14455 improvement. (Bug#8719)
30569699 14456
c11285dc
PE
14457 * alloc.c (make_event_array): Use XINT, not XUINT.
14458 There's no need for unsigned here.
14459
fdccd48e
PE
14460 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
14461 This follows up to the 2011-05-06 change that substituted uintptr_t
14462 for EMACS_INT. This case wasn't caught back then.
14463
37910ab2
PE
14464 Rework Fformat to avoid integer overflow issues.
14465 * editfns.c: Include <float.h> unconditionally, as it's everywhere
14466 now (part of C89). Include <verify.h>.
14467 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
14468 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
14469 (Fformat): Avoid the prepass trying to compute sizes; it was only
14470 approximate and thus did not catch overflow reliably. Instead, walk
14471 through the format just once, formatting and computing sizes as we go,
14472 checking for integer overflow at every step, and allocating a larger
14473 buffer as needed. Keep track separately whether the format is
14474 multibyte. Keep only the most-recently calculated precision, rather
14475 than them all. Record whether each argument has been converted to
14476 string. Use EMACS_INT, not int, for byte and char and arg counts.
14477 Support field widths and precisions larger than INT_MAX. Avoid
14478 sprintf's undefined behavior with conversion specifications such as %#d
14479 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
14480 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
14481 formatting out-of-range floating point numbers with int
9173deec 14482 formats. (Bug#8668)
37910ab2 14483
2e6578fb
PE
14484 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
14485
0ae6bdee
PE
14486 * data.c: Avoid integer truncation in expressions involving floats.
14487 * data.c: Include <intprops.h>.
14488 (arith_driver): When there's an integer overflow in an expression
14489 involving floating point, convert the integers to floating point
14490 so that the resulting value does not suffer from catastrophic
14491 integer truncation. For example, on a 64-bit host (* 4
14492 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
14493 Do not rely on undefined behavior after integer overflow.
14494
de883a70
PE
14495 merge count_size_as_multibyte, parse_str_to_multibyte
14496 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 14497 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
14498 Check for integer overflow.
14499 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
14500 since it's now a duplicate of the other. This is more of
14501 a character than a buffer op, so better that it's in character.c.
14502 * fns.c, print.c: Adjust to above changes.
14503
2ff916cb
PE
145042011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
14505
14506 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
14507
f1b54466
PE
145082011-05-27 Paul Eggert <eggert@cs.ucla.edu>
14509
fb1ac845
PE
14510 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
14511 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
14512 (x_clipboard_manager_save): Now static.
14513 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
14514
f1b54466
PE
14515 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
14516 (crypto_hash_function): Now static.
14517 Fix pointer signedness problems. Avoid unnecessary initializations.
14518
a9f737ee
CY
145192011-05-27 Chong Yidong <cyd@stupidchicken.com>
14520
14521 * termhooks.h (Vselection_alist): Make it terminal-local.
14522
14523 * terminal.c (create_terminal): Initialize it.
14524
14525 * xselect.c: Support for clipboard managers.
14526 (Vselection_alist): Move to termhooks.h as terminal-local var.
14527 (LOCAL_SELECTION): New macro.
14528 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
14529 (symbol_to_x_atom): Remove gratuitous arg.
14530 (x_handle_selection_request, lisp_data_to_selection_data)
14531 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
14532 (x_own_selection, x_get_local_selection, x_convert_selection):
14533 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
14534 (some_frame_on_display): Delete unused function.
14535 (Fx_own_selection_internal, Fx_get_selection_internal)
14536 (Fx_disown_selection_internal, Fx_selection_owner_p)
14537 (Fx_selection_exists_p): New optional frame arg.
14538 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
14539 (x_handle_selection_clear): Don't treat other terminals with the
14540 same keyboard specially. Use the terminal-local Vselection_alist.
14541 (x_clear_frame_selections): Use Frun_hook_with_args.
14542
14543 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
14544
14545 * xterm.h: Add support for those atoms.
14546
e067f0c1
CY
145472011-05-26 Chong Yidong <cyd@stupidchicken.com>
14548
14549 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
14550 (converted_selections, conversion_fail_tag): New global variables.
14551 (x_selection_request_lisp_error): Free the above.
14552 (x_get_local_selection): Remove unnecessary code.
14553 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
14554 of converted selections stored in converted_selections.
14555 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
14556 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
14557 (x_convert_selection): New function.
14558 (x_handle_selection_event): Simplify.
14559 (x_get_foreign_selection): Don't ignore incoming requests while
14560 waiting for an answer; this will fail when we implement
14561 SAVE_TARGETS, and seems unnecessary anyway.
14562 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
14563 (Vx_sent_selection_functions): Doc fix.
14564
0f4aebc0
LL
145652011-05-26 Leo Liu <sdl.web@gmail.com>
14566
14567 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
14568
e61124cd
YM
145692011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14570
14571 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
14572
14573 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
14574 for fringe update if it has periodic bitmap.
ac389d0c 14575 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
14576 and fringe_bitmap_periodic_p.
14577
14578 * fringe.c (get_fringe_bitmap_data): New function.
14579 (draw_fringe_bitmap_1, update_window_fringes): Use it.
14580 (update_window_fringes): Record periodicity of fringe bitmap in glyph
14581 row. Mark glyph row for fringe update if periodicity changed.
14582
14583 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
14584 for fringe update unless it has periodic bitmap.
14585
f16d9837
KH
145862011-05-25 Kenichi Handa <handa@m17n.org>
14587
14588 * xdisp.c (get_next_display_element): Set correct it->face_id for
14589 a static composition.
14590
e1b90ef6
LL
145912011-05-24 Leo Liu <sdl.web@gmail.com>
14592
14593 * deps.mk (fns.o):
14594 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
14595
14596 * fns.c (crypto_hash_function, Fsha1): New function.
14597 (Fmd5): Use crypto_hash_function.
14598 (syms_of_fns): Add Ssha1.
14599
7400048f
PE
146002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
14601
14602 * gnutls.c: Remove unused macros.
14603 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
14604 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
14605 Remove macros that are defined and never used.
14606 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
14607
abb71cf4
CY
146082011-05-22 Chong Yidong <cyd@stupidchicken.com>
14609
14610 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
14611 (Fx_get_selection_internal): Minor cleanup.
14612 (Fx_own_selection_internal): Rename arguments for consistency with
14613 select.el.
14614
6307db39
PE
146152011-05-22 Paul Eggert <eggert@cs.ucla.edu>
14616
14617 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
14618
f3d4e0a4
CY
146192011-05-22 Chong Yidong <cyd@stupidchicken.com>
14620
14621 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
14622
4d8ade89
YM
146232011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14624
14625 * dispnew.c (scrolling_window): Don't exclude the case that the
14626 last enabled row in the desired matrix touches the bottom boundary.
14627
32078c8d
GM
146282011-05-21 Glenn Morris <rgm@gnu.org>
14629
14630 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
14631 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
14632 and add some more files.
32078c8d 14633
7285dc67
EZ
146342011-05-20 Eli Zaretskii <eliz@gnu.org>
14635
14636 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
14637 report_file_error introduced by the change from 2011-05-07.
14638
89d1bd22
PE
146392011-05-20 Paul Eggert <eggert@cs.ucla.edu>
14640
14641 * systime.h (Time): Define only if emacs is defined.
14642 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
14643 where the include path doesn't have X11/X.h by default. See
14644 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
14645
cd394be1 146462011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
14647
14648 * composite.c (find_automatic_composition): Fix previous change.
14649
b9704ad9
GM
146502011-05-20 Glenn Morris <rgm@gnu.org>
14651
14652 * lisp.mk: New file, split from Makefile.in.
14653 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
14654 (shortlisp): Remove.
14655 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
14656
4a720484
GM
146572011-05-19 Glenn Morris <rgm@gnu.org>
14658
14659 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
14660 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
14661 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
14662 (lisp): Set the order to that of loadup.el.
14663 (shortlisp): Make it a copy of $lisp.
14664 (SOME_MACHINE_LISP): Remove.
14665 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
14666 Use just $shortlisp, not $SOME_MACHINE_LISP too.
14667
a28d4396
KH
146682011-05-18 Kenichi Handa <handa@m17n.org>
14669
14670 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
14671 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
14672 (find_automatic_composition): Mostly rewrite for efficiency.
14673
a2b1fa8e
JB
146742011-05-18 Juanma Barranquero <lekktu@gmail.com>
14675
14676 * makefile.w32-in: Update dependencies.
14677
8e1f5610
CS
146782011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
14679
14680 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 14681 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 14682
7025ee00 146832011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 14684
cdfa6eab
PE
14685 Fix some integer overflow issues, such as string length overflow.
14686
06d6db33
PE
14687 * insdel.c (count_size_as_multibyte): Check for string overflow.
14688
2b4560a8
PE
14689 * character.c (lisp_string_width): Check for string overflow.
14690 Use EMACS_INT, not int, for string indexes and lengths; in
14691 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
14692 the resulting string length overflows an EMACS_INT; instead,
14693 report a string overflow if no precision given. When checking for
14694 precision exhaustion, use a check that cannot possibly have
14695 integer overflow. (Bug#8675)
14696 * character.h (lisp_string_width): Adjust to new signature.
14697
cb93f9be
PE
14698 * alloc.c (string_overflow): New function.
14699 (Fmake_string): Use it. This doesn't change behavior, but saves
14700 a few bytes and will simplify future changes.
14701 * character.c (string_escape_byte8): Likewise.
14702 * lisp.h (string_overflow): New decl.
14703
1a1f3366
PE
14704 Fixups, following up to the user-interface timestamp change.
14705 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
14706 for UI timestamps, instead of unsigned long.
9fbd6841
PE
14707 * msdos.c (mouse_get_pos): Likewise.
14708 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
14709 * w32gui.h (Time): Define by including "systime.h" rather than by
14710 declaring it ourselves. (Bug#8664)
14711
d4e3e4d3
PE
14712 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
14713 * image.c (clear_image_cache): Likewise.
14714
f6a24d19
PE
14715 * term.c (term_mouse_position): Don't assume time_t wraparound.
14716
08dc5ae6
PE
14717 Be more systematic about user-interface timestamps.
14718 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
14719 and sometimes 'EMACS_UINT', to represent these timestamps.
14720 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
14721 This makes the code easier to follow, and makes it easier to catch
14722 integer overflow bugs such as Bug#8664.
14723 * frame.c (Fmouse_position, Fmouse_pixel_position):
14724 Use Time, not unsigned long, for user-interface timestamps.
14725 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
14726 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
14727 * keyboard.h (last_event_timestamp): Likewise.
14728 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
14729 * menu.h (xmenu_show): Likewise.
14730 * term.c (term_mouse_position): Likewise.
14731 * termhooks.h (struct input_event.timestamp): Likewise.
14732 (struct terminal.mouse_position_hook): Likewise.
14733 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
14734 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
14735 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
14736 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
14737 what it was before.
14738 * menu.h, termhooks.h: Include "systime.h", for Time.
14739
8e55734a
PE
14740 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
14741 Don't assume that the difference between two unsigned long values
14742 can fit into an integer. At this point, we know button_down_time
14743 <= event->timestamp, so the difference must be nonnegative, so
14744 there's no need to cast the result if double-click-time is
14745 nonnegative, as it should be; check that it's nonnegative, just in
14746 case. This bug is triggered when events are more than 2**31 ms
86db42d2 14747 apart (about 25 days). (Bug#8664)
8e55734a 14748
841f1b75 14749 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 14750 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 14751
3e26f69c
PE
14752 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
14753 that always fit in int. Use a sentinel instead of a counter, to
14754 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
14755 * frame.h (struct frame): Use int for menu_bar_items_used
14756 instead of EMACS_INT, since it always fits in int.
3e26f69c 14757
5cc152c0
PE
14758 * menu.c (grow_menu_items): Check for int overflow.
14759
d89eb65e
PE
14760 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
14761
5235bd3e
PE
14762 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
14763 Before, the code was not consistent. These values cannot exceed
14764 2**31 - 1 so there's no need to make them unsigned.
14765 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
14766 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
14767 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
14768 as modifiers.
14769 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
14770
bc827e23
PE
14771 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
14772 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
14773 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
14774 presumably because the widths might not match.
14775
78eb494e
PE
14776 * window.c (size_window): Avoid needless test at loop start.
14777
04f2d78b
CB
147782011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
14779
14780 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
14781
d2fc7e3d 147822011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
14783
14784 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
14785
d2fc7e3d 147862011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
14787
14788 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
14789 `width' to `bar_area_x' and `bar_area_width', respectively.
14790 (x_scroll_run): Take account of fringe background extension.
14791
04f2d78b
CB
14792 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
14793 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
14794 `bar_area_width', respectively.
14795 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
14796 background extension.
14797
79b70037
GM
147982011-05-10 Jim Meyering <meyering@redhat.com>
14799
14800 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
14801
2f142cc5
JB
148022011-05-10 Juanma Barranquero <lekktu@gmail.com>
14803
14804 * image.c (Finit_image_library): Return t for built-in image types,
14805 like pbm and xbm. (Bug#8640)
14806
57679c86
AS
148072011-05-09 Andreas Schwab <schwab@linux-m68k.org>
14808
14809 * w32menu.c (set_frame_menubar): Fix submenu allocation.
14810
888c9e86
EZ
148112011-05-07 Eli Zaretskii <eliz@gnu.org>
14812
b0512a1d
EZ
14813 * w32console.c (Fset_screen_color): Doc fix.
14814 (Fget_screen_color): New function.
14815 (syms_of_ntterm): Defsubr it.
14816
7285dc67
EZ
14817 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
14818 unlink the temporary file if Fcall_process didn't create it in the
14819 first place.
14820 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
14821 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
14822 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
14823 cue to call_process_cleanup not to close that handle.
14824
4d3fcc8e
BK
148252011-05-07 Ben Key <bkey76@gmail.com>
14826
14827 * makefile.w32-in: The bootstrap-temacs rule now makes use of
14828 one of two shell specific rules, either bootstrap-temacs-CMD or
14829 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
14830 to the previous implementation of the bootstrap-temacs rule.
14831 The bootstrap-temacs-CMD rule is similar to the previous
14832 implementation of the bootstrap-temacs rule except that it
14833 makes use of the ESC_CFLAGS variable instead of the CFLAGS
14834 variable.
14835
14836 These changes, along with some changes to nt/configure.bat,
14837 nt/gmake.defs, and nt/nmake.defs, are required to extend my
14838 earlier fix to add support for --cflags and --ldflags options
14839 that include quotes so that it works whether make uses cmd or
14840 sh as the shell.
14841
b4289b64
MA
148422011-05-06 Michael Albinus <michael.albinus@gmx.de>
14843
14844 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
14845 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
14846 is a constant.
14847 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
14848 a string. Handle both cases.
14849 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
14850 (Fdbus_register_method): Use Qinvalid_function.
14851
af4c0e28
JB
148522011-05-06 Juanma Barranquero <lekktu@gmail.com>
14853
14854 * makefile.w32-in: Update dependencies.
14855 (LISP_H): Add inttypes.h and stdin.h.
14856 (PROCESS_H): Add unistd.h.
14857
c51453d9
EZ
148582011-05-06 Eli Zaretskii <eliz@gnu.org>
14859
14860 * lread.c: Include limits.h (fixes the MS-Windows build broken by
14861 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
14862
8ff0ac3c 148632011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 14864
4c4b566b
PE
14865 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
14866
aab2b9b5
PE
14867 * term.c (vfatal): Remove stray call to va_end.
14868 It's not needed and the C Standard doesn't allow it here anyway.
14869
c378da0b
PE
14870 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
14871 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
14872
288b08c7
PE
14873 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
14874 bytes.
14875
e3601888
PE
14876 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
14877
db6c0e74
PE
14878 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
14879
dd5963ea
PE
14880 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
14881
88c9450f
PE
14882 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
14883
2f9442b8
PE
14884 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
14885
c032b5f8
PE
14886 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
14887 * charset.c (Fdefine_charset_internal): Don't initialize
14888 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 14889 32-bit int (Bug#8600).
a108c10b
PE
14890
14891 * lread.c (read_integer): Be more consistent with string-to-number.
14892 Use string_to_number to do the actual conversion; this avoids
14893 rounding errors and fixes some other screwups. Without this fix,
14894 for example, #x1fffffffffffffff was misread as -2305843009213693952.
14895 (digit_to_number): Move earlier, for benefit of read_integer.
14896 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 14897 not a digit in any supported base. (Bug#8602)
a108c10b 14898
ad5f9eea
PE
14899 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
14900
aec1708a
PE
14901 * dispnew.c (scrolling_window): Return 1 if we scrolled,
14902 to match comment at start of function. This also removes a
14903 GCC warning about overflow in a 32+64-bit port.
14904
47be4ab5
PE
14905 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
14906
371cac43
PE
14907 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
14908 Reported by Stefan Monnier in
14909 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
14910 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14911 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 14912
d01a7826
PE
14913 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
14914 (EMACS_UINTPTR): Likewise, with uintptr_t.
14915
7fd47d5c
PE
14916 * lisp.h: Prefer 64-bit EMACS_INT if available.
14917 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
14918 on 32-bit hosts that have 64-bit int, so that they can access
14919 large files.
122b0c86
PE
14920 However, temporarily disable this change unless the temporary
14921 symbol WIDE_EMACS_INT is defined.
7fd47d5c 14922
8727937b
PE
14923 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
14924
8ac068ac
PE
14925 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
14926 This removes an assumption that EMACS_INT and long are the same
14927 width as pointers. The assumption is true for Emacs porting targets
14928 now, but we want to make other targets possible.
14929 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
14930 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
14931 In the rest of the code, change types of integers that hold casted
14932 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
14933 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
14934 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
14935 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
14936 No need to cast type when ORing.
14937 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
14938 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
14939 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
14940 assume EMACS_INT is the same width as char *.
14941 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
14942 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
14943 Remove no-longer-needed casts.
14944 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
14945 (xg_tool_bar_help_callback, xg_make_tool_item):
14946 Use EMACS_INTPTR to hold an integer
14947 that will be cast to void *; this can avoid a GCC warning
14948 if EMACS_INT is not the same width as void *.
14949 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
14950 * xdisp.c (display_echo_area_1, resize_mini_window_1):
14951 (current_message_1, set_message_1):
14952 Use a local to convert to proper width without a cast.
14953 * xmenu.c (dialog_selection_callback): Likewise.
14954
ede49d71
PE
14955 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
14956 Also, don't assume VALBITS / RAND_BITS is less than 5,
14957 and don't rely on undefined behavior when shifting a 1 left into
14958 the sign bit.
14959 * lisp.h (get_random): Change signature to match.
14960
2f30ecd0
PE
14961 * lread.c (hash_string): Use size_t, not int, for hash computation.
14962 Normally we prefer signed values; but hashing is special, because
14963 it's better to use unsigned division on hash table sizes so that
14964 the remainder is nonnegative. Also, size_t is the natural width
14965 for hashing into memory. The previous code used 'int', which doesn't
14966 retain enough info to hash well into very large tables.
14967 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
14968
2a866e7b
PE
14969 * dbusbind.c: Don't possibly lose pointer info when converting.
14970 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14971 Use XPNTR rather than XHASH, so that the high-order bits of
14972 the pointer aren't lost when converting through void *.
14973
51639eac
PE
14974 * eval.c (Fautoload): Don't double-shift a pointer.
14975
92394119
PE
14976 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
14977
dbdb9a7c
JB
149782011-05-06 Juanma Barranquero <lekktu@gmail.com>
14979
14980 * gnutls.c (DEF_GNUTLS_FN):
14981 * image.c (DEF_IMGLIB_FN): Make function pointers static.
14982
db7a0b4f
AS
149832011-05-05 Andreas Schwab <schwab@linux-m68k.org>
14984
14985 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
14986 marker. (Bug#8610)
14987
cd394be1 149882011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
14989
14990 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
14991 New version that can reserve upto 2GB of heap space.
14992
f7ff1b0f 149932011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
14994
14995 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
14996
639c109b
TZ
149972011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
14998
14999 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
15000 `gnutls_certificate_set_x509_key_file'.
15001
d2127135
JB
150022011-05-05 Juanma Barranquero <lekktu@gmail.com>
15003
15004 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
15005 Update dependencies.
15006
e968f4f3
JB
150072011-05-04 Juanma Barranquero <lekktu@gmail.com>
15008
15009 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
15010 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
15011 Remove unused parameter `fildes'.
15012 * process.c (read_process_output, send_process): Don't pass it.
15013
84d358f0
JB
150142011-05-04 Juanma Barranquero <lekktu@gmail.com>
15015
15016 Fix previous change: the library cache is defined in w32.c.
15017 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
15018 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
15019
0898ca10
JB
150202011-05-04 Juanma Barranquero <lekktu@gmail.com>
15021
15022 Implement dynamic loading of GnuTLS on Windows.
15023
15024 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
15025 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
15026 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15027 Declare.
15028
15029 * gnutls.c (Qgnutls_dll): Define.
15030 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
15031 (gnutls_*): Declare function pointers.
15032 (init_gnutls_functions): New function to initialize function pointers.
15033 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
15034 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
15035 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15036 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
15037 (emacs_gnutls_write, emacs_gnutls_read)
15038 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
15039 (Fgnutls_available_p): New function.
15040 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
15041 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
15042 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
15043
15044 * image.c: Include w32.h.
15045 (Vimage_type_cache): Delete.
15046 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
15047 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
15048 (w32_delayed_load): Move to w32.c.
15049
15050 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
15051
15052 * w32.c (QCloaded_from, Vlibrary_cache): Define.
15053 (w32_delayed_load): Move from image.c. When loading a library, record
15054 its filename in the :loaded-from property of the library id.
15055 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
15056 Initialize and staticpro them.
15057 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
15058
15059 * process.c: Include lisp.h before w32.h, not after.
15060 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
15061 instead of gnutls_record_check_pending.
15062
15063 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
15064
ff4de4aa
TZ
150652011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
15066
15067 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
15068 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
15069 as passed in.
15070
abe95abb
JD
150712011-05-03 Jan Djärv <jan.h.d@swipnet.se>
15072
15073 * xterm.c (x_set_frame_alpha): Do not set property on anything
15074 else than FRAME_X_OUTER_WINDOW (Bug#8608).
15075
e16e55d4
JB
150762011-05-02 Juanma Barranquero <lekktu@gmail.com>
15077
15078 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
15079
bafcf6a5
JB
150802011-05-02 Juanma Barranquero <lekktu@gmail.com>
15081
15082 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
15083 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
15084 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
15085 (gnutls_global_initialized, Qgnutls_bootprop_priority)
15086 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
15087 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
15088 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
15089 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
15090 (Qgnutls_bootprop_callbacks_verify): Make static.
15091
e7a6747f
AS
150922011-05-01 Andreas Schwab <schwab@linux-m68k.org>
15093
19ed11ba
AS
15094 * callproc.c: Indentation fixup.
15095
e7a6747f 15096 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
15097 (wait_for_termination, interruptible_wait_for_termination):
15098 Move after wait_for_termination_1.
e7a6747f 15099
1ef14cb4
LMI
151002011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
15101
15102 * sysdep.c (interruptible_wait_for_termination): New function
15103 which is like wait_for_termination, but allows keyboard
15104 interruptions.
15105
15106 * callproc.c (Fcall_process): Add (:file "file") as an option for
15107 the STDOUT buffer.
15108 (Fcall_process_region): Ditto.
15109
330d880c
EZ
151102011-04-30 Eli Zaretskii <eliz@gnu.org>
15111
8db90b73
EZ
15112 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
15113 rather than `XVECTOR (FOO)->size'.
15114
330d880c
EZ
15115 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
15116 inttypes.h, as a gnulib replacement is used if it not available in
15117 system headers.
15118
15cbd324
EZ
151192011-04-21 Eli Zaretskii <eliz@gnu.org>
15120
15121 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
15122 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
15123 of MOST_POSITIVE_FIXNUM. (Bug#8528)
15124
15125 * coding.c (coding_alloc_by_realloc): Error out if destination
15126 will grow beyond MOST_POSITIVE_FIXNUM.
15127 (decode_coding_emacs_mule): Abort if there isn't enough place in
15128 charbuf for the composition carryover bytes. Reserve an extra
15129 space for up to 2 characters produced in a loop.
15130 (decode_coding_iso_2022): Abort if there isn't enough place in
15131 charbuf for the composition carryover bytes.
15132
151332011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 15134
ae940cca
EZ
15135 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
15136 aborting when %lld or %lll format is passed.
15137 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
15138 %llo or %llx format is passed. (Bug#8545)
15139
03ab8921
EZ
15140 * window.c (window_scroll_line_based): Use a marker instead of
15141 simple variables to record original value of point. (Bug#7952)
15142
afda1437
EZ
15143 * doprnt.c (doprnt): Fix the case where a multibyte sequence
15144 produced by %s or %c overflows available buffer space. (Bug#8545)
15145
f76dee0c
PE
151462011-04-28 Paul Eggert <eggert@cs.ucla.edu>
15147
15148 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 15149 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 15150
fdc5744d
JB
151512011-04-28 Juanma Barranquero <lekktu@gmail.com>
15152
15153 * w32.c (init_environment): Warn about defaulting HOME to C:\.
15154
638f053a
JB
151552011-04-28 Juanma Barranquero <lekktu@gmail.com>
15156
15157 * keyboard.c (Qdelayed_warnings_hook): Define.
15158 (command_loop_1): Run `delayed-warnings-hook'
15159 if Vdelayed_warnings_list is non-nil.
15160 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
15161 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
15162
d178f871
EZ
151632011-04-28 Eli Zaretskii <eliz@gnu.org>
15164
15165 * doprnt.c (doprnt): Don't return value smaller than the buffer
15166 size if the message was truncated. (Bug#8545).
15167
b124fd93
JB
151682011-04-28 Juanma Barranquero <lekktu@gmail.com>
15169
15170 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
15171 (Fx_window_property): #if-0 the whole functions, not just the bodies.
15172
e810457d
PE
151732011-04-27 Paul Eggert <eggert@cs.ucla.edu>
15174
15175 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
15176
ea51cceb
JB
151772011-04-27 Juanma Barranquero <lekktu@gmail.com>
15178
15179 * makefile.w32-in: Update dependencies.
15180
94dcfacf
EZ
151812011-04-27 Eli Zaretskii <eliz@gnu.org>
15182
15183 Improve `doprnt' and its usage. (Bug#8545)
15184 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
15185 `format_end'. Remove support for %l as a conversion specifier.
15186 Don't use xrealloc. Improve diagnostics when the %l size modifier
15187 is used. Update the commentary.
15188
15189 * eval.c (verror): Simplify calculation of size_t.
15190
15191 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
15192 messages.
15193
f61f41d7
PE
151942011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
15195
15196 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
15197 change.
15198
96fb4434
PE
151992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
15200
15201 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
15202 This makes this file independent of the recent pseudovector change.
15203
671875da 152042011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 15205
69e9b5a3
PE
15206 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
15207
b5f869a7 15208 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 15209 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 15210 Remove unused local.
c8926152 15211 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 15212
841a1577 15213 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
15214 GCC 4.6.0 optimizes based on type-based alias analysis.
15215 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
15216 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
15217 != &v->size, and therefore "v->size = 1; b->size = 2; return
15218 v->size;" must therefore return 1. This assumption is incorrect
15219 for Emacs, since it type-puns struct Lisp_Vector * with many other
15220 types. To fix this problem, this patch adds a new type struct
f904488f 15221 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
15222 and pseudovectors, and helps optimizing compilers not get fooled
15223 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
15224 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
15225 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
15226 the size member.
eab3844f
PE
15227 (XSETPVECTYPE): Rewrite in terms of new macro.
15228 (XSETPVECTYPESIZE): New macro, specifying both type and size.
15229 This is a bit clearer, and further avoids the possibility of
15230 undesirable aliasing.
15231 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 15232 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
15233 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
15234 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
15235 (ASIZE): Now uses header.size rather than size.
15236 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
15237 to avoid the hassle of writing XVECTOR (foo)->header.size.
15238 (struct vectorlike_header): New type.
eab3844f
PE
15239 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
15240 object, to help avoid aliasing.
15241 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
15242 (SUBRP): Likewise, since Lisp_Subr is a special case.
15243 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
15244 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
15245 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 15246 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
15247 changed to be "header.size" and "header.next".
15248 * buffer.h (struct buffer): Likewise.
15249 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
15250 * frame.h (struct frame): Likewise.
15251 * process.h (struct Lisp_Process): Likewise.
15252 * termhooks.h (struct terminal): Likewise.
15253 * window.c (struct save_window_data, struct saved_window): Likewise.
15254 * window.h (struct window): Likewise.
15255 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
15256 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
15257 * buffer.c (init_buffer_once): Likewise.
15258 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
15259 special case.
15260 * process.c (Fformat_network_address): Use local var for size,
15261 for brevity.
15262
0df1eac5
PE
15263 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
15264
847ab9d1 15265 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
15266 * data.c (atof): Remove decl; no longer used or needed.
15267 (digit_to_number): Move to lread.c.
15268 (Fstring_to_number): Use new string_to_number function, to be
15269 consistent with how the Lisp reader treats infinities and NaNs.
15270 Do not assume that floating-point numbers represent EMACS_INT
15271 without losing information; this is not true on most 64-bit hosts.
15272 Avoid double-rounding errors, by insisting on integers when
15273 parsing non-base-10 numbers, as the documentation specifies.
15274 * lisp.h (string_to_number): New decl, replacing ...
15275 (isfloat_string): Remove.
bc0a5c13 15276 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 15277 (read1): Do not accept +. and -. as integers; this
452f4150
PE
15278 appears to have been a coding error. Similarly, do not accept
15279 strings like +-1e0 as floating point numbers. Do not report
15280 overflow for integer overflows unless the base is not 10 which
15281 means we have no simple and reliable way to continue.
15282 Break out the floating-point parsing into a new
15283 function string_to_number, so that Fstring_to_number parses
15284 floating point numbers consistently with the Lisp reader.
04f2d78b 15285 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
15286 (E_CHAR, EXP_INT): Remove, replacing with ...
15287 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
15288 (string_to_number): New function, replacing isfloat_string.
15289 This function checks for valid syntax and produces the resulting
15290 Lisp float number too. Rework it so that string-to-number
bc0a5c13 15291 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
15292 so that overflow for non-base-10 numbers is reported only when
15293 there's no portable and simple way to convert to floating point.
452f4150 15294
67769ffc
PE
15295 * textprop.c (set_text_properties_1): Rewrite for clarity,
15296 and to avoid GCC warning about integer overflow.
15297
c20db43f
PE
15298 * intervals.h (struct interval): Use EMACS_INT for members
15299 where EMACS_UINT might cause problems. See
15300 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
15301 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
15302 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
15303 All uses changed.
37aa2f85
PE
15304 (offset_intervals): Tell GCC not to worry about length overflow
15305 when negating a negative length.
c20db43f 15306
2538aa2f
PE
15307 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
15308 (overrun_check_free): Likewise.
15309
f2d3008d
PE
15310 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
15311 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
15312 word size.
15313
ec8df744
PE
15314 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15315 (gnutls_make_error): Rename local to avoid shadowing.
15316 (gnutls_emacs_global_deinit): ifdef out; not used.
15317 (Fgnutls_boot): Use const for pointer to readonly storage.
15318 Comment out unused local. Fix pointer signedness problems.
15319
640ee02d
PE
15320 * lread.c (openp): Don't stuff size_t into an 'int'.
15321 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
15322 about possible signed overflow.
15323
6048fb2a
PE
15324 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15325 (GDK_KEY_g): Don't define if already defined.
15326 (xg_prepare_tooltip): Avoid pointer signedness problem.
15327 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
15328
fa3c87e1
PE
15329 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
15330 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
15331
2172544b
PE
15332 * xfns.c (Fx_window_property): Simplify a bit,
15333 to make a bit faster and to avoid GCC 4.6.0 warning.
15334 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
15335
9b821a21
PE
15336 * fns.c (internal_equal): Don't assume size_t fits in int.
15337
3c616cfa
PE
15338 * alloc.c (compact_small_strings): Tighten assertion a little.
15339
c2982e87
PE
15340 Replace pEd with more-general pI, and fix some printf arg casts.
15341 * lisp.h (pI): New macro, generalizing old pEd macro to other
15342 conversion specifiers. For example, use "...%"pI"d..." rather
15343 than "...%"pEd"...".
15344 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 15345 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
15346 * alloc.c (check_pure_size): Don't overflow by converting size to int.
15347 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
15348 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
15349 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
15350 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
15351 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
15352 64-bit hosts.
15353 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
15354 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
15355 * print.c (safe_debug_print, print_object): Likewise.
15356 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
15357 to int.
6f04d126
PE
15358 Use pI instead of if-then-else-abort. Use %p to avoid casts,
15359 avoiding the 0 flag, which is not portable.
c2982e87
PE
15360 * process.c (Fmake_network_process): Use pI to avoid cast.
15361 * region-cache.c (pp_cache): Likewise.
15362 * xdisp.c (decode_mode_spec): Likewise.
15363 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
15364 behavior on 64-bit hosts with printf arg.
6f04d126 15365 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
15366 (x_stop_queuing_selection_requests): Likewise.
15367 (x_get_window_property): Don't truncate byte count to an 'int'
15368 when tracing.
0b432f21 15369
5e073ec7
PE
15370 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
15371 here, since it parses constructs like leading '-' and spaces,
15372 which are not wanted; and it overflows with large numbers.
15373 Instead, simply match F[0-9]+, which is what is wanted anyway.
15374
36372bf9
PE
15375 * alloc.c: Remove unportable assumptions about struct layout.
15376 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
15377 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
15378 (allocate_vectorlike, make_pure_vector): Use the new macros,
15379 plus offsetof, to remove unportable assumptions about struct layout.
15380 These assumptions hold on all porting targets that I know of, but
15381 they are not guaranteed, they're easy to remove, and removing them
15382 makes further changes easier.
15383
0b432f21
PE
15384 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
15385 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
15386 (string_overrun_cookie): Now const. Use initializers that
15387 don't formally overflow signed char, to avoid warnings.
000098c1
PE
15388 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
15389 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
15390 (allocate_buffer): Don't assume sizeof (struct buffer) is a
15391 multiple of sizeof (EMACS_INT); it need not be, if
15392 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 15393 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 15394
895009e1
JB
153952011-04-26 Juanma Barranquero <lekktu@gmail.com>
15396
15397 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
15398
6a7a1b0b
TZ
153992011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
15400
15401 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 15402 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
15403 Reported by Paul Eggert <eggert@cs.ucla.edu>.
15404
841a1577 154052011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
15406
15407 * lisp.h (Qdebug): List symbol.
895009e1 15408 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
15409 * keyboard.c (debug-on-event): New variable.
15410 (handle_user_signal): Break into debugger when debug-on-event
15411 matches the current signal symbol.
15412
f2d3ba6f
DN
154132011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
15414
15415 * alloc.c (check_sblock, check_string_bytes)
15416 (check_string_free_list): Convert to standard C.
15417
42ce4c63
TZ
154182011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
15419
15420 * w32.c (emacs_gnutls_push): Fix typo.
15421
825cd63c
EZ
154222011-04-25 Eli Zaretskii <eliz@gnu.org>
15423
fb11d64d
EZ
15424 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
15425 "cast to pointer from integer of different size".
15426
825cd63c
EZ
15427 Improve doprnt and its use in verror. (Bug#8545)
15428 * doprnt.c (doprnt): Document the set of format control sequences
15429 supported by the function. Use SAFE_ALLOCA instead of always
15430 using `alloca'.
15431
15432 * eval.c (verror): Don't limit the buffer size at size_max-1, that
15433 is one byte too soon. Don't use xrealloc; instead xfree and
15434 xmalloc anew.
15435
e061a11b
TZ
154362011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
15437
15438 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
15439 callbacks stage.
15440
15441 * gnutls.c: Renamed global_initialized to
15442 gnutls_global_initialized. Added internals for the
15443 :verify-hostname-error, :verify-error, and :verify-flags
15444 parameters of `gnutls-boot' and documented those parameters in the
15445 docstring. Start callback support.
9173deec
JB
15446 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
15447 unless a fatal error occurred. Call gnutls_alert_send_appropriate
15448 on error. Return error code.
e061a11b
TZ
15449 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
15450 (emacs_gnutls_read): Likewise.
15451 (Fgnutls_boot): Return handshake error code.
15452 (emacs_gnutls_handle_error): New function.
15453 (wsaerror_to_errno): Likewise.
15454
15455 * w32.h (emacs_gnutls_pull): Add prototype.
15456 (emacs_gnutls_push): Likewise.
15457
15458 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
15459 (emacs_gnutls_push): Likewise.
15460
154612011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
15462
15463 * process.c (wait_reading_process_output): Check if GnuTLS
15464 buffered some data internally if no FDs are set for TLS
15465 connections.
15466
15467 * makefile.w32-in (OBJ2): Add gnutls.$(O).
15468 (LIBS): Link to USER_LIBS.
15469 ($(BLD)/gnutls.$(0)): New target.
15470
fa6996bc
EZ
154712011-04-24 Eli Zaretskii <eliz@gnu.org>
15472
eb35682e
EZ
15473 * xdisp.c (handle_single_display_spec): Rename the
15474 display_replaced_before_p argument into display_replaced_p, to
15475 make it consistent with the commentary. Fix typos in the
15476 commentary.
15477
e2ad650c
EZ
15478 * textprop.c (syms_of_textprop): Remove dead code.
15479 (copy_text_properties): Delete obsolete commentary about an
15480 interface that was deleted long ago. Fix typos in the description
15481 of arguments.
15482
1b2de274
EZ
15483 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
15484 to changes in oldXMenu/XMenu.h from 2011-04-16.
15485 <menu_help_message, prev_menu_help_message>: Constify.
15486 (IT_menu_make_room): menu->help_text is now `const char **';
15487 adjust.
15488
15489 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
15490 to changes in oldXMenu/XMenu.h from 2011-04-16.
15491 (struct XMenu): Declare `help_text' `const char **'.
15492
15493 * xfaces.c <Qunspecified>: Make extern again.
15494
15495 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 15496 required by POSIX.
1b2de274 15497
762b15be
EZ
15498 * doc.c (get_doc_string): Improve the format passed to `error'.
15499
15500 * doprnt.c (doprnt): Improve commentary.
15501
15502 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
15503
15504 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
15505 them with etags.
15506
f1052e5d
EZ
15507 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
15508 changes in globals.h immediately force recompilation.
762b15be
EZ
15509 (TAGS): Depend on $(CURDIR)/m/intel386.h and
15510 $(CURDIR)/s/ms-w32.h.
15511 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 15512
fa6996bc
EZ
15513 * character.c (Fchar_direction): Function deleted.
15514 (syms_of_character): Don't defsubr it.
15515 <char-direction-table>: Deleted.
15516
e6c3da20
EZ
155172011-04-23 Eli Zaretskii <eliz@gnu.org>
15518
15519 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
15520 * doprnt.c: Include limits.h.
15521 (SIZE_MAX): New macro.
04f2d78b
CB
15522 (doprnt): Return a size_t value. 2nd arg is now size_t.
15523 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
15524 Improve overflow protection. Support `l' modifier for integer
15525 conversions. Support %l conversion. Don't assume an EMACS_INT
15526 argument for integer conversions and for %c.
15527
15528 * lisp.h (doprnt): Restore prototype.
15529
15530 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
15531 $(SRC)/character.h.
15532
15533 * Makefile.in (base_obj): Add back doprnt.o.
15534
15535 * deps.mk (doprnt.o): Add back prerequisites.
15536 (callint.o): Depend on character.h.
15537
15538 * eval.c (internal_lisp_condition_case): Include the handler
15539 representation in the error message.
15540 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
15541 when breaking from the loop.
15542
15543 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
15544
15545 * callint.c (Fcall_interactively): When displaying error message
15546 about invalid control letter, pass the character's codepoint, not
15547 a pointer to its multibyte form. Improve display of the character
15548 in octal and display also its hex code.
15549
15550 * character.c (char_string): Use %x to display the (unsigned)
15551 codepoint of an invalid character, to avoid displaying a bogus
15552 negative value.
15553
15554 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
15555 `error', not SYMBOL_NAME itself.
15556
15557 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
15558 character arguments to `error'.
15559
15560 * charset.c (check_iso_charset_parameter): Fix incorrect argument
15561 to `error' in error message about FINAL_CHAR argument. Make sure
15562 FINAL_CHAR is a character, and use %c when it is passed as
15563 argument to `error'.
15564
4ffd0d6b 155652011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
15566
15567 * s/ms-w32.h (localtime): Redirect to sys_localtime.
15568
15569 * w32.c: Include <time.h>.
15570 (sys_localtime): New function.
15571
4ffd0d6b 155722011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
15573
15574 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
15575
4ffd0d6b 15576 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 15577
4ffd0d6b 155782011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 15579
4ffd0d6b
GM
15580 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
15581 zombies (Bug#8467).
aac0c6e3 15582
04c56954
EZ
155832011-04-19 Eli Zaretskii <eliz@gnu.org>
15584
15585 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
15586 gl_state.e_property when gl_state.object is Qt.
15587
15588 * insdel.c (make_gap_larger): Remove limitation of buffer size
15589 to <= INT_MAX.
15590
16a43933
CY
155912011-04-18 Chong Yidong <cyd@stupidchicken.com>
15592
15593 * xdisp.c (lookup_glyphless_char_display)
15594 (produce_glyphless_glyph): Handle cons cell entry in
15595 glyphless-char-display.
15596 (Vglyphless_char_display): Document it.
15597
15598 * term.c (produce_glyphless_glyph): Handle cons cell entry in
15599 glyphless-char-display.
15600
4581706e
CY
156012011-04-17 Chong Yidong <cyd@stupidchicken.com>
15602
15603 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
15604
15605 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
15606
15607 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
15608 definition for no-X builds.
15609
4887c6e2 156102011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 15611
fd35b6f9
PE
15612 Static checks with GCC 4.6.0 and non-default toolkits.
15613
5c1ccb01
PE
15614 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
15615
006c5daa
PE
15616 * process.c (keyboard_bit_set): Define only if SIGIO.
15617 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
15618 (send_process): Repair possible setjmp clobbering.
15619
efc736d3
PE
15620 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
15621
4e2fe2e6
PE
15622 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
15623
f97334a2
PE
15624 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
15625
4e75f29d
PE
15626 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
15627 Define only if needed.
15628
90efadd1
PE
15629 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
15630 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 15631 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 15632
3c647824
PE
15633 * dispextern.h (struct redisplay_interface): Rename param
15634 to avoid shadowing.
e264f262 15635 * termhooks.h (struct terminal): Likewise.
761383f4 15636 * xterm.c (xembed_send_message): Likewise.
3c647824 15637
b58c5c4a
PE
15638 * insdel.c (make_gap_smaller): Define only if
15639 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
15640
cad59032
PE
15641 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
15642 it.
15643
c339dc2e
PE
15644 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
15645 so that we aren't warned about unused symbols.
15646
91a3e27b
PE
15647 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
15648
399c71d3 15649 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 15650
8ffc96f5
PE
15651 * xfns.c (x_real_positions): Mark locals as initialized.
15652
eef9bc79
PE
15653 * xmenu.c (xmenu_show): Don't use uninitialized vars.
15654
098db9dd
PE
15655 * xterm.c: Fix problems found by static analysis with other toolkits.
15656 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
15657 (x_dispatch_event): Declare static if USE_GTK, and
15658 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 15659 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 15660 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
15661 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
15662 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 15663
eb18f6cc
PE
15664 * xmenu.c (menu_help_callback): Pointer type fixes.
15665 Use const pointers when pointing at readonly data. Avoid pointer
15666 signedness clashes.
15667 (FALSE): Remove unused macro.
15668 (update_frame_menubar): Remove unused decl.
15669
1fe72bf8
PE
15670 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
15671
60d9e1db
PE
15672 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
15673 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
15674 (single_menu_item): Rename local to avoid shadowing.
15675
39261c26
PE
15676 * keyboard.c (make_lispy_event): Remove unused local var.
15677
018c5e19
PE
15678 * frame.c, frame.h (x_get_resource_string): Bring this back, but
15679 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
15680
63d2b86e
PE
15681 * bitmaps: Change bitmaps from unsigned char back to the X11
15682 compatible char. Avoid the old compiler warnings about
15683 out-of-range initializers by using, for example, '\xab' rather
15684 than 0xab.
15685
aefd87e1
PE
15686 * xgselect.c (xgselect_initialize): Check vs interface
15687 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
15688
bf501fb9
PE
15689 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
15690
e9829fdf
PE
15691 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
15692 to read-only memory.
15693
1086c095
PE
15694 * fns.c (vector): Remove; this old hack is no longer needed.
15695
2baccd04 15696 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 15697 Remove unused var.
dde42981 15698 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 15699
72391843 15700 * xrdb.c (x_load_resources): Omit unused local.
3565b346 15701
436c16df 15702 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 15703 (x_window): Rename locals to avoid shadowing.
dc5ddd85 15704 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 15705
92bb796d 15706 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 15707 (x_term_init): Remove local to avoid shadowing.
92bb796d 15708
764430a3 15709 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
15710
15711 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
15712 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
15713
d1dfb56c
EZ
157142011-04-16 Eli Zaretskii <eliz@gnu.org>
15715
c4354cb4
EZ
15716 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
15717
d1dfb56c
EZ
15718 Fix regex.c, syntax.c and friends for buffers > 2GB.
15719 * syntax.h (struct gl_state_s): Declare character position members
15720 EMACS_INT.
15721
15722 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
15723
04f2d78b
CB
15724 * textprop.c (verify_interval_modification, interval_of):
15725 Declare arguments EMACS_INT.
d1dfb56c
EZ
15726
15727 * intervals.c (adjust_intervals_for_insertion): Declare arguments
15728 EMACS_INT.
15729
15730 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
15731
15732 * indent.c (Fvertical_motion): Local variable it_start is now
15733 EMACS_INT.
15734
15735 * regex.c (re_match, re_match_2, re_match_2_internal)
15736 (bcmp_translate, regcomp, regexec, print_double_string)
15737 (group_in_compile_stack, re_search, re_search_2, regex_compile)
15738 (re_compile_pattern, re_exec): Declare arguments and local
15739 variables `size_t' and `ssize_t' and return values `regoff_t', as
15740 appropriate.
15741 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
15742 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
15743 <compile_stack_type>: `size' and `avail' are now `size_t'.
15744
15745 * regex.h <regoff_t>: Use ssize_t, not int.
15746 (re_search, re_search_2, re_match, re_match_2): Arguments that
15747 specify buffer/string position and length are now ssize_t and
15748 size_t. Return type is regoff_t.
15749
613052cd
BK
157502011-04-16 Ben Key <bkey76@gmail.com>
15751
15752 * nsfont.m: Fixed bugs in ns_get_family and
15753 ns_descriptor_to_entity that were caused by using free to
15754 deallocate memory blocks that were allocated by xmalloc (via
15755 xstrdup). This caused Emacs to crash when compiled with
15756 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
15757 --enable-checking=xmallocoverrun). xfree is now used to
15758 deallocate these memory blocks.
15759
4170f62f 157602011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 15761
71b41406
PE
15762 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
15763
9587a89d
PE
15764 emacs_write: Accept and return EMACS_INT for sizes.
15765 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
15766 et seq.
15767 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
15768 Accept and return EMACS_INT.
15769 (emacs_gnutls_write): Return the number of bytes written on
15770 partial writes.
15771 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
15772 (emacs_read, emacs_write): Remove check for negative size, as the
15773 Emacs source code has been audited now.
9587a89d
PE
15774 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
15775 (emacs_read, emacs_write): Use it.
273a5f82
PE
15776 * process.c (send_process): Adjust to the new signatures of
15777 emacs_write and emacs_gnutls_write. Do not attempt to store
15778 a byte offset into an 'int'; it might overflow.
9587a89d 15779 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 15780
3e047f51
PE
15781 * sound.c: Don't assume sizes fit in 'int'.
15782 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 15783 Return EMACS_INT, not int.
3e047f51 15784 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
15785 Accept EMACS_INT, not int.
15786 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
15787 record read return values.
15788
cc39a9db
BK
157892011-04-15 Ben Key <bkey76@gmail.com>
15790
c9d0ec6d
JB
15791 * keyboard.c (Qundefined): Don't declare static since it is used
15792 in nsfns.m.
15793 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
15794 static since they are used in nsfont.m.
cc39a9db 15795
6c60eb9f
SM
157962011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
15797
15798 * process.c (Qprocessp): Don't declare static.
15799 * lisp.h (Qprocessp): Declare again.
15800
7990b61a
JB
158012011-04-15 Juanma Barranquero <lekktu@gmail.com>
15802
15803 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
15804
5d4cb038
PE
158052011-04-14 Paul Eggert <eggert@cs.ucla.edu>
15806
8bd7b830 15807 Improve C-level modularity by making more things 'static'.
cd64ea1d 15808
e3b27b31
PE
15809 Don't publish debugger-only interfaces to other modules.
15810 * lisp.h (safe_debug_print, debug_output_compilation_hack):
15811 (verify_bytepos, count_markers): Move decls to the only modules
15812 that need them.
15813 * region-cache.h (pp_cache): Likewise.
15814 * window.h (check_all_windows): Likewise.
15815 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
15816
5d4cb038
PE
15817 * sysdep.c (croak): Now static, if
15818 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
15819 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
15820
15821 * alloc.c (refill_memory_reserve): Now static if
15822 !defined REL_ALLOC || defined SYSTEM_MALLOC.
15823 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 15824
e87b6180
PE
15825 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
15826 Define only if USE_LUCID.
15827
ac64929e
PE
15828 * xrdb.c (x_customization_string, x_rm_string): Now static.
15829
6f37259d
PE
15830 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
15831 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
15832
1683e3ab
PE
15833 * xdisp.c (draw_row_with_mouse_face): Now static.
15834 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
15835
de9c2632
PE
15836 * window.h (check_all_windows): Mark externally visible.
15837
2b96acb7
PE
15838 * window.c (window_deletion_count): Now static.
15839
15840 * undo.c: Make symbols static if they're not exported.
15841 (last_undo_buffer, last_boundary_position, pending_boundary):
15842 Now static.
15843
50436f33
PE
15844 * textprop.c (interval_insert_behind_hooks): Now static.
15845 (interval_insert_in_front_hooks): Likewise.
15846
64520e5c
PE
15847 * term.c: Make symbols static if they're not exported.
15848 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
15849 (max_frame_lines, tty_set_terminal_modes):
15850 (tty_reset_terminal_modes, tty_turn_off_highlight):
15851 (get_tty_terminal): Now static.
15852 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
15853 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 15854 HAVE_WINDOW_SYSTEM.
64520e5c
PE
15855 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
15856 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
15857
1fa53021
PE
15858 * sysdep.c: Make symbols static if they're not exported.
15859 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
15860 Now static.
15861 (sigprocmask_set, full_mask): Remove; unused.
15862 (wait_debugging): Mark as visible.
15863 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
15864 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
15865
d4b43b22
PE
15866 * syntax.c (syntax_temp): Define only if !__GNUC__.
15867
b7c513d0
PE
15868 * sound.c (current_sound_device, current_sound): Now static.
15869
989b29ad
PE
15870 * search.c (searchbufs, searchbuf_head): Now static.
15871
13a55a78
PE
15872 * scroll.c (scroll_cost): Remove; unused.
15873 * dispextern.h (scroll_cost): Remove decl.
15874
de68a1fc
PE
15875 * region-cache.h (pp_cache): Mark as externally visible.
15876
40ccffa6
PE
15877 * process.c: Make symbols static if they're not exported.
15878 (process_tick, update_tick, create_process, chan_process):
15879 (Vprocess_alist, proc_buffered_char, datagram_access):
15880 (fd_callback_data, send_process_frame, process_sent_to): Now static.
15881 (deactivate_process): Mark defn as static, as well as decl.
15882 * lisp.h (create_process): Remove decl.
15883 * process.h (chan_process, Vprocess_alist): Remove decls.
15884
ad64fc97
PE
15885 * print.c: Make symbols static if they're not exported.
15886 (print_depth, new_backquote_output, being_printed, print_buffer):
15887 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
15888 (print_interval, print_number_index, initial_stderr_stream):
15889 Now static.
15890 * lisp.h (Fprinc): Remove decl.
15891 (debug_output_compilation_hack): Mark as externally visible.
15892
adddb265
PE
15893 * sysdep.c (croak): Move decl from here to syssignal.h.
15894 * syssignal.h (croak): Put it here, so the API can be checked when
15895 'croak' is called from dissociate_if_controlling_tty.
15896
1717ede2
PE
15897 * minibuf.c: Make symbols static if they're not exported.
15898 (minibuf_save_list, choose_minibuf_frame): Now static.
15899 * lisp.h (choose_minibuf_frame): Remove decl.
15900
fa5fb2bc
PE
15901 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
15902
1e3890d1
PE
15903 * lread.c: Make symbols static if they're not exported.
15904 (read_objects, initial_obarray, oblookup_last_bucket_number):
15905 Now static.
15906 (make_symbol): Remove; unused.
15907 * lisp.h (initial_obarray, make_symbol): Remove decls.
15908
8a1414fa
PE
15909 * keyboard.c: Make symbols static if they're not exported.
15910 (single_kboard, recent_keys_index, total_keys, recent_keys):
15911 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
15912 (this_single_command_key_start, echoing, last_auto_save):
15913 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
15914 (command_loop, echo_now, keyboard_init_hook, help_char_p):
15915 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
15916 (Vlispy_mouse_stem, double_click_count):
15917 Now static.
15918 (force_auto_save_soon): Define only if SIGDANGER.
15919 (ignore_mouse_drag_p): Now static if
15920 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
15921 (print_help): Remove; unused.
15922 (stop_character, last_timer_event): Mark as externally visible.
15923 * keyboard.h (ignore_mouse_drag_p): Declare only if
15924 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
15925 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
15926 * lisp.h (echoing): Remove decl.
15927 (force_auto_save_soon): Declare only if SIGDANGER.
15928 * xdisp.c (redisplay_window): Simplify code, to make it more
15929 obvious that ignore_mouse_drag_p is not accessed if !defined
15930 USE_GTK && !defined HAVE_NS.
15931
93ea6e8f
PE
15932 * intervals.c: Make symbols static if they're not exported.
15933 (merge_properties_sticky, merge_interval_right, delete_interval):
15934 Now static.
15935 * intervals.h (merge_interval_right, delete_interval): Remove decls.
15936
77382fcc
PE
15937 * insdel.c: Make symbols static if they're not exported.
15938 However, leave prepare_to_modify_buffer alone. It's never
15939 called from outside this function, but that appears to be a bug.
15940 (combine_after_change_list, combine_after_change_buffer):
4889fc82 15941 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
15942 (adjust_after_replace_noundo): Remove; unused.
15943 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 15944 (signal_before_change): Remove decls.
77382fcc 15945
9306c32e
PE
15946 * indent.c (val_compute_motion, val_vmotion): Now static.
15947
cd44d2eb
PE
15948 * image.c: Make symbols static if they're not exported.
15949 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
15950 if USE_GTK.
15951 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
15952 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
15953
ad9a7a06
PE
15954 * fringe.c (standard_bitmaps): Now static.
15955 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
15956
81626931
PE
15957 * frame.c: Make symbols static if they're not exported.
15958 (x_report_frame_params, make_terminal_frame): Now static.
15959 (get_frame_param): Now static, unless HAVE_NS.
15960 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
15961 (x_get_resource_string): Remove; not used.
15962 * frame.h (make_terminal_frame, x_report_frame_params):
15963 (x_get_resource_string); Remove decls.
15964 (x_fullscreen_adjust): Declare only if WINDOWSNT.
15965 * lisp.h (get_frame_param): Declare only if HAVE_NS.
15966
239f9db9
PE
15967 * font.c, fontset.c: Make symbols static if they're not exported.
15968 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
15969 (FACE_SUITABLE_FOR_CHAR_P): Use it.
15970 * font.c (font_close_object): Now static.
15971 * font.h (font_close_object): Remove.
15972 * fontset.c (FONTSET_OBJLIST): Remove.
15973 (free_realized_fontset) #if-0 the body, which does nothing.
15974 (face_suitable_for_char_p): #if-0, as it's never called.
15975 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
15976 * xfaces.c (face_at_string_position):
15977 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
15978 since 0 is always ASCII.
15979
dfcf3579
PE
15980 * fns.c (weak_hash_tables): Now static.
15981
5045092b
PE
15982 * fileio.c: Make symbols static if they're not exported.
15983 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
15984 (Vwrite_region_annotation_buffers): Now static.
15985
57a96f5c
PE
15986 * eval.c: Make symbols static if they're not exported.
15987 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
15988 * lisp.h (backtrace_list): Remove decl.
15989
35f08c38
PE
15990 * emacs.c: Make symbols static if they're not exported.
15991 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
15992 (fatal_error_code, fatal_error_signal_hook, standard_args):
15993 Now static.
15994 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
15995 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
15996 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
15997 * lisp.h (fatal_error_signal_hook): Remove decl.
15998 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
15999
f44bd759
PE
16000 * editfns.c: Move a (normally-unused) function to its only use.
16001 * editfns.c, lisp.h (get_operating_system_release): Remove.
16002 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
16003 worth the hassle of breaking this out.
16004
b532497d
PE
16005 * xterm.c: Make symbols static if they're not exported.
16006 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
16007 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
16008 (x_destroy_window, x_delete_display):
16009 Now static.
16010 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
16011 (x_mouse_leave): Remove; unused.
16012 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
16013 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
16014 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
16015 Remove decls.
16016 (x_mouse_leave): Declare only if WINDOWSNT.
16017 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
16018 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
16019 USE_X_TOOLKIT.
16020
1675728f
PE
16021 * ftxfont.c: Make symbols static if they're not exported.
16022 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
16023 HAVE_FREETYPE.
16024 * font.h (ftxfont_driver): Likewise.
16025
e4cebfca
PE
16026 * xfns.c: Make symbols static if they're not exported.
16027 (x_last_font_name, x_display_info_for_name):
16028 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
16029 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
16030 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
16031 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
16032 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
16033 (last_show_tip_args): Now static.
16034 (xic_defaut_fontset, xic_create_fontsetname): Define only if
16035 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
16036 (x_screen_planes): Remove; unused.
16037 * dispextern.h (x_screen_planes): Remove decl.
16038
5bf46f05
PE
16039 * dispnew.c: Make symbols static if they're not exported.
16040 * dispextern.h (redraw_garbaged_frames, scrolling):
16041 (increment_row_positions): Remove.
16042 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
16043 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
16044 Now static.
16045 (redraw_garbaged_frames): Remove; unused.
16046
435f4c28
PE
16047 * xfaces.c: Make symbols static if they're not exported.
16048 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
16049 Remove decls.
16050 * xterm.h (defined_color): Remove decls.
16051 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
16052 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
16053 (menu_face_changed_default, defined_color, free_realized_face):
16054 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
16055 (ascii_face_of_lisp_face): Remove; unused.
16056
8524aef3
PE
16057 * xdisp.c: Make symbols static if they're not exported.
16058 * dispextern.h (scratch_glyph_row, window_box_edges):
16059 (glyph_to_pixel_coords, set_cursor_from_row):
16060 (get_next_display_element, set_iterator_to_next):
16061 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
16062 (show_mouse_face): Remove decls
16063 * frame.h (message_buf_print): Likewise.
16064 * lisp.h (pop_message, set_message, check_point_in_composition):
16065 Likewise.
16066 * xterm.h (set_vertical_scroll_bar): Likewise.
16067 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
16068 (message_buf_print, scratch_glyph_row, displayed_buffer):
16069 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
16070 (get_next_display_element, show_mouse_face, window_box_edges):
16071 (frame_to_window_pixel_xy, check_point_in_composition):
16072 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
16073 (glyph_to_pixel_coords): Remove; unused.
16074
16390cd2
PE
16075 * dired.c (file_name_completion): Now static.
16076
16077 * dbusbind.c (xd_in_read_queued_messages): Now static.
16078
a25f4dfa
PE
16079 * lisp.h (circular_list_error, FOREACH): Remove; unused.
16080 * data.c (circular_list_error): Remove.
16081
14a9c8df
PE
16082 * commands.h (last_point_position, last_point_position_buffer):
16083 (last_point_position_window): Remove decls.
16084 * keyboard.c: Make these variables static.
16085
04f2d78b
CB
16086 * coding.h (coding, code_convert_region, encode_coding_gap):
16087 Remove decls.
74ab6df5
PE
16088 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
16089 (iso_code_class, detect_coding, code_convert_region): Now static.
16090 (encode_coding_gap): Remove; unused.
16091
38dfbee1
PE
16092 * chartab.c (chartab_chars, chartab_bits): Now static.
16093
a2cb4e63
PE
16094 * charset.h (charset_iso_8859_1): Remove decl.
16095 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
16096 Now static.
16097
127198fd
PE
16098 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
16099 * ccl.c (Vccl_program_table): Now static.
16100 (check_ccl_update): Remove; unused.
16101
d85b608f
PE
16102 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
16103 * category.h: ... from here.
16104 * category.c (check_category_table, set_category_set): Now static.
16105
31cd66f3
PE
16106 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
16107 * lisp.h: Remove these decls.
16108
c358e587
PE
16109 * buffer.c (buffer_count): Remove unused var.
16110
e78aecca
PE
16111 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
16112 so that it's not optimized away.
16113 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
16114 * dispextern.h (bidi_dump_cached_states): Remove, since it's
16115 exported only to the debugger.
16116
e192d7d3 16117 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 16118 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 16119
92470028
PE
16120 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
16121 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
16122 was inaccessible from Lisp.
16123 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
16124 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
16125
244ed907
PE
16126 alloc.c: Import and export fewer symbols, and remove unused items.
16127 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
16128 is defined.
16129 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
16130 it's not optimized away by whole-program optimization.
16131 (message_enable_multibyte, free_misc): Remove.
16132 (catchlist, handlerlist, mark_backtrace):
16133 Declare only if BYTE_MARK_STACK.
16134 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
16135 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
16136 (message_enable_multibyte): Remove decl.
16137 (free_misc, interval_free_list, float_block, float_block_index):
16138 (n_float_blocks, float_free_list, cons_block, cons_block_index):
16139 (cons_free_list, last_marked_index):
16140 Now static.
16141 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
16142 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
16143 (mark_backtrace): Define only if BYTE_MARK_STACK.
16144 * xdisp.c (message_enable_multibyte): Now static.
16145
61c2b50e 16146 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
16147 This makes it easier for human readers (and static analyzers)
16148 to see whether these variables are used from other modules.
16149 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
16150 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
16151 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
16152 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
16153 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
16154 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
16155 * xmenu.c, xselect.c:
16156 Declare Q* vars static if they are not used in other modules.
16157 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
16158 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
16159 Remove decls of unexported vars.
16160 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
16161
95c82688
PE
16162 * lisp.h (DEFINE_FUNC): Make sname 'static'.
16163
16a97296
PE
16164 Make Emacs functions such as Fatom 'static' by default.
16165 This makes it easier for human readers (and static analyzers)
16166 to see whether these functions can be called from other modules.
16167 DEFUN now defines a static function. To make the function external
16168 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
16169 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
16170 (Finit_image_library):
16a97296
PE
16171 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
16172 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
16173 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
16174 Remove decls, since these functions are now static.
16175 (Funintern, Fget_internal_run_time): New decls, since these functions
16176 were already external.
95c82688 16177
16a97296
PE
16178 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
16179 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
16180 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
16181 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
16182 * keyboard.c, keymap.c, lread.c:
16183 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
16184 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
16185 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
16186 Mark functions with DEFUE instead of DEFUN,
16187 if they are used in other modules.
16188 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
16189 decls for now-static functions.
16190 * buffer.h (Fdelete_overlay): Remove decl.
16191 * callproc.c (Fgetenv_internal): Mark as internal.
16192 * composite.c (Fremove_list_of_text_properties): Remove decl.
16193 (Fcomposition_get_gstring): New forward static decl.
16194 * composite.h (Fcomposite_get_gstring): Remove decl.
16195 * dired.c (Ffile_attributes): New forward static decl.
16196 * doc.c (Fdocumntation_property): New forward static decl.
16197 * eval.c (Ffetch_bytecode): New forward static decl.
16198 (Funintern): Remove extern decl; now in .h file where it belongs.
16199 * fileio.c (Fmake_symbolic_link): New forward static decl.
16200 * image.c (Finit_image_library): New forward static decl.
16201 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
16202 * intervals.h (Fprevious_property_change):
16203 (Fremove_list_of_text_properties): Remove decls.
16204 * keyboard.c (Fthis_command_keys): Remove decl.
16205 (Fcommand_execute): New forward static decl.
16206 * keymap.c (Flookup_key): New forward static decl.
16207 (Fcopy_keymap): Now static.
16208 * keymap.h (Flookup_key): Remove decl.
16209 * process.c (Fget_process): New forward static decl.
16210 (Fprocess_datagram_address): Mark as internal.
16211 * syntax.c (Fsyntax_table_p): New forward static decl.
16212 (skip_chars): Remove duplicate decl.
16213 * textprop.c (Fprevious_property_change): New forward static decl.
16214 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
16215 Now internal.
16216 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
16217 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
16218
785bbd42
PE
16219 * editfns.c (Fformat): Remove unreachable code.
16220
8b913b57
AS
162212011-04-14 Andreas Schwab <schwab@linux-m68k.org>
16222
16223 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
16224 change. (Bug#8496)
16225
a6744a35
EZ
162262011-04-13 Eli Zaretskii <eliz@gnu.org>
16227
16228 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
16229 when at ZV. (Bug#8487)
16230
e7974947
AS
162312011-04-12 Andreas Schwab <schwab@linux-m68k.org>
16232
baad03f0
AS
16233 * charset.c (Fclear_charset_maps): Use xfree instead of free.
16234 (Bug#8437)
16235 * keyboard.c (parse_tool_bar_item): Likewise.
16236 * sound.c (sound_cleanup, alsa_close): Likewise.
16237 * termcap.c (tgetent): Likewise.
16238 * xfns.c (x_default_font_parameter): Likewise.
16239 * xsettings.c (read_and_apply_settings): Likewise.
16240
e7974947
AS
16241 * alloc.c (overrun_check_malloc, overrun_check_realloc)
16242 (overrun_check_free): Protoize.
16243
28272684
PE
162442011-04-12 Paul Eggert <eggert@cs.ucla.edu>
16245
16246 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
16247 since callers should never pass a negative size.
16248 Change the signature to match that of plain 'read' and 'write'; see
16249 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
16250 * lisp.h: Update prototypes of emacs_write and emacs_read.
16251
11997c76
EZ
162522011-04-11 Eli Zaretskii <eliz@gnu.org>
16253
16254 * xdisp.c (redisplay_window): Don't try to determine the character
16255 position of the scroll margin if the window start point w->startp
e896f03c 16256 is outside the buffer's accessible region. (Bug#8468)
11997c76 16257
8a2cbd72
EZ
162582011-04-10 Eli Zaretskii <eliz@gnu.org>
16259
16260 Fix write-region and its subroutines for buffers > 2GB.
16261 * fileio.c (a_write, e_write): Modify declaration of arguments and
16262 local variables to support buffers larger than 2GB.
16263 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
16264
16265 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
16266 argument, local variables, and return value.
16267
16268 * lisp.h: Update prototypes of emacs_write and emacs_read.
16269
16270 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
16271
4073e537 162722011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 16273
1ebfdcb6
PE
16274 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
16275
b2ded58d
PE
16276 Fix more problems found by GCC 4.6.0's static checks.
16277
7d66342c
PE
16278 * xdisp.c (vmessage): Use a better test for character truncation.
16279
bbf47d44
PE
16280 * charset.c (load_charset_map): <, not <=, for optimization,
16281 and to avoid potential problems with integer overflow.
9248994d 16282 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 16283 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 16284 * editfns.c (Fformat): Likewise.
1e69125e 16285 * syntax.c (skip_chars): Likewise.
3befa583 16286
e3019616
PE
16287 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
16288 This also lets GCC 4.6.0 generate slightly better loop code.
16289
becfa255
PE
16290 * callint.c (Fcall_interactively): <, not <=, for optimization.
16291 (Fcall_interactively): Count the number of arguments produced,
16292 not the number of arguments given. This is simpler and lets GCC
16293 4.6.0 generate slightly better code.
16294
dae0cd48
PE
16295 * ftfont.c: Distingish more carefully between FcChar8 and char.
16296 The previous code passed unsigned char * to a functions like
16297 strlen and xstrcasecmp that expect char *, which does not
16298 conform to the C standard.
16299 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
16300 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
16301 char * when the C standard requires it.
16302
76032d70
PE
16303 * keyboard.c (read_char): Remove unused var.
16304
eb3f1cc8
PE
16305 * eval.c: Port to Windows vsnprintf (Bug#8435).
16306 Include <limits.h>.
16307 (SIZE_MAX): Define if the headers do not.
16308 (verror): Do not give up if vsnprintf returns a negative count.
16309 Instead, grow the buffer. This ports to Windows vsnprintf, which
16310 does not conform to C99. Problem reported by Eli Zaretskii.
16311 Also, simplify the allocation scheme, by avoiding the need for
16312 calling realloc, and removing the ALLOCATED variable.
16313
70476b54
PE
16314 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
16315
12020a9e
PE
16316 Remove invocations of doprnt, as Emacs now uses vsnprintf.
16317 But keep the doprint source code for now, as we might revamp it
16318 and use it again (Bug#8435).
ea6c7ae6
PE
16319 * lisp.h (doprnt): Remove.
16320 * Makefile.in (base_obj): Remove doprnt.o.
16321 * deps.mk (doprnt.o): Remove.
16322
5fdb398c
PE
16323 error: Print 32- and 64-bit integers portably (Bug#8435).
16324 Without this change, on typical 64-bit hosts error ("...%d...", N)
16325 was used to print both 32- and 64-bit integers N, which relied on
16326 undefined behavior.
61bdb816 16327 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
16328 * lisp.h (error, verror): Mark as printf-like functions.
16329 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
16330 Report overflow in size calculations when allocating printf buffer.
16331 Do not truncate output string at its first null byte.
16332 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
16333 Truncate the output at a character boundary, since vsnprintf does not
16334 do that.
16335 * charset.c (check_iso_charset_parameter): Convert internal
16336 character to string before calling 'error', since %c now has the
16337 printf meaning.
16338 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
16339 overflow when computing char to be passed to 'error'. Do not
16340 pass Lisp_Object to 'error'; pass the integer instead.
16341 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
16342 formatted with plain %d.
16343
b189fa66
PE
16344 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
16345
bff87ef0
PE
16346 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
16347
7e2cac20
PE
16348 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
16349
ce4d90b5
PE
16350 * xterm.c (x_catch_errors): Remove duplicate declaration.
16351
266c9547
PE
16352 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
16353
79c49ad2
PE
16354 * xdisp.c, lisp.h (message_nolog): Remove; unused.
16355
368f4090
JM
163562011-04-10 Jim Meyering <meyering@redhat.com>
16357
16358 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
16359 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
16360 return ssize_t not "int", and use size_t as the buffer length.
16361 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
16362 * gnutls.h: Update declarations.
16363 * process.c (read_process_output): Use ssize_t, to match.
16364 (send_process): Likewise.
16365
a32d4040
CY
163662011-04-09 Chong Yidong <cyd@stupidchicken.com>
16367
16368 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
16369
8546720e 163702011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 16371
04f2d78b
CB
16372 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
16373 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 16374
8546720e
GM
16375 * xterm.c (handle_one_xevent):
16376 * xmenu.c (create_and_show_popup_menu):
16377 * xselect.c (x_decline_selection_request)
16378 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 16379
0a2f5c1a 163802011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
16381
16382 Fix some uses of `int' instead of EMACS_INT.
16383 * search.c (string_match_1, fast_string_match)
16384 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
16385 (scan_buffer, find_next_newline_no_quit)
16386 (find_before_next_newline, search_command, Freplace_match)
16387 (Fmatch_data): Make some `int' variables be EMACS_INT.
16388
16389 * xdisp.c (display_count_lines): 3rd argument and return value now
16390 EMACS_INT. All callers changed.
16391 (pint2hrstr): Last argument is now EMACS_INT.
16392
16393 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
16394 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
16395 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
16396 (decode_coding_utf_16, decode_coding_emacs_mule)
16397 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
16398 (decode_coding_ccl, decode_coding_charset)
16399 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
16400 (decode_coding_iso_2022, decode_coding_emacs_mule)
16401 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
16402 <char_offset, last_offset>: Declare EMACS_INT.
16403 (encode_coding_utf_8, encode_coding_utf_16)
16404 (encode_coding_emacs_mule, encode_invocation_designation)
16405 (encode_designation_at_bol, encode_coding_iso_2022)
16406 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
16407 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
16408 Declare EMACS_INT.
16409 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
16410 (encode_invocation_designation): Last argument P_NCHARS is now
16411 EMACS_INT.
16412 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
16413 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
16414
16415 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
16416 All users changed.
16417
16418 * ccl.c (Fccl_execute_on_string): Declare some variables
16419 EMACS_INT.
16420
8546720e 164212011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
16422
16423 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
16424
4e19a977
CS
164252011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
16426
16427 * process.c (Fformat_network_address): Doc fix.
16428
87302331
R
164292011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
16430
ee7683eb 16431 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 16432
cbb59342
CY
164332011-04-08 Chong Yidong <cyd@stupidchicken.com>
16434
16435 * keyboard.c (read_char): Call Lisp function help-form-show,
16436 instead of using internal_with_output_to_temp_buffer.
16437 (Qhelp_form_show): New var.
e0d38eeb 16438 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
16439
16440 * print.c (internal_with_output_to_temp_buffer): Function deleted.
16441
16442 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
16443
e67a13ab
CY
164442011-04-06 Chong Yidong <cyd@stupidchicken.com>
16445
04f2d78b
CB
16446 * process.c (Flist_processes): Remove to Lisp.
16447 (list_processes_1): Delete.
e67a13ab 16448
973f782d
EZ
164492011-04-06 Eli Zaretskii <eliz@gnu.org>
16450
7c106b1e
EZ
16451 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
16452
973f782d
EZ
16453 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
16454
41cf7d1a 164552011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 16456
ca23cc88
PE
16457 Fix more problems found by GCC 4.6.0's static checks.
16458
f390e2d5
PE
16459 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
16460
42eea0d0
PE
16461 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
16462
b69769da 16463 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 16464
f9541e84
PE
16465 * xdisp.c (vmessage): Mark as a printf-like function.
16466
13841b55
PE
16467 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
16468
c136c10f
PE
16469 * sound.c (sound_warning): Don't crash if arg contains a printf format.
16470
5e2d4a30
PE
16471 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
16472 printf-like functions.
16473 (tiff_load): Add casts to remove these marks before passing them
16474 to system-supplied API.
16475
583f48b9
PE
16476 * eval.c (Fsignal): Remove excess argument to 'fatal'.
16477
b25d760e
PE
16478 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
16479 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
16480 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
16481 directly, rather than having caller test rule sign. This avoids
16482 some unnecessary tests.
16483 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
16484 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
16485 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 16486
bc7b6697 16487 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 16488 (xfont_open): Avoid unnecessary tests.
bc7b6697 16489
27ccc379
PE
16490 * composite.c (composition_gstring_put_cache): Use unsigned integer.
16491
dcd5c89a
PE
16492 * composite.h, composite.c (composition_gstring_put_cache):
16493 Use EMACS_INT, not int, for length.
16494
b13a45c6
PE
16495 * composite.h (COMPOSITION_DECODE_REFS): New macro,
16496 breaking out part of COMPOSITION_DECODE_RULE.
16497 (COMPOSITION_DECODE_RULE): Use it.
16498 * composite.c (get_composition_id): Remove unused local vars,
16499 by using the new macro.
16500
1e792e4d
PE
16501 * textprop.c (set_text_properties_1): Change while to do-while,
16502 since the condition is always true at first.
16503
dc6c6455 16504 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
16505 (interval_deletion_adjustment): Return unsigned value.
16506 All uses changed.
dc6c6455 16507
aba7731a
PE
16508 * process.c (list_processes_1, create_pty, read_process_output):
16509 (exec_sentinel): Remove vars that were set but not used.
afd4052b 16510 (create_pty): Remove unnecessary "volatile"s.
bc57d757 16511 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 16512 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 16513 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 16514
fdfc4bf3
PE
16515 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
16516
fca8fe46 16517 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 16518 (update_syntax_table): Use unsigned instead of int.
fca8fe46 16519
06a0259a 16520 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 16521 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 16522 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 16523
e7b9e80f
PE
16524 * print.c (print_error_message): Avoid int overflow.
16525
56201685
PE
16526 * font.c (font_list_entities): Redo for clarity,
16527 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
16528
78834453 16529 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 16530 (font_score): Avoid potential overflow in diff calculation.
78834453 16531
0bc0b309 16532 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 16533 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 16534
e610eaca
PE
16535 * eval.c (funcall_lambda): Rename local to avoid shadowing.
16536
b895abce
PE
16537 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
16538 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
16539 can always succeed if overflow has undefined behavior.
16540
1f1d9321 16541 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 16542 (wordify): Omit three unnecessary tests.
1f1d9321 16543
c59478bc
PE
16544 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
16545 All callers changed. This avoids the need for an unused var.
16546
79b73827
PE
16547 * casefiddle.c (casify_region): Remove var that is set but not used.
16548
a4db5dfe
PE
16549 * dired.c (file_name_completion): Remove var that is set but not used.
16550
43aae36e
PE
16551 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
16552
2a47c44d 16553 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 16554 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 16555
a37c69bf
PE
16556 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
16557 Check for integer overflow on size calculations.
16558
328ab8e7
PE
16559 * buffer.c (Fprevious_overlay_change): Remove var that is set
16560 but not used.
16561
e5a2a5cb
PE
16562 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
16563 Remove vars that are set but not used.
8d84a6eb 16564 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 16565 (timer_check_2): Mark vars as initialized.
e5a2a5cb 16566
a60e5f68
PE
16567 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
16568
f661cb61 16569 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 16570 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 16571
f0397f5a
PE
16572 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
16573 that are set but not used.
16574
8664db06 16575 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 16576 if XCreateBitmapFromData fails (Bug#8410).
8664db06 16577
6abdaa4a
PE
16578 * xselect.c (x_get_local_selection, x_handle_property_notify):
16579 Remove vars that are set but not used.
16580
0ce7538d 16581 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 16582 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 16583
9ae848fc
PE
16584 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
16585 Remove var that is set but not used.
0b918413
PE
16586 (scroll_bar_windows_size): Now size_t, not int.
16587 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
16588 Check for overflow.
9ae848fc 16589
a5a62657
PE
16590 * xfaces.c (realize_named_face): Remove vars that are set but not used.
16591 (map_tty_color) [!defined MSDOS]: Likewise.
16592
5c5cdd39
PE
16593 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
16594
66ebf983
PE
16595 * coding.c: Remove vars that are set but not used.
16596 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
16597 All callers changed.
16598 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
16599 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
16600 (decode_coding_charset): Remove vars that are set but not used.
16601
1be4d761
PE
16602 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
16603 that is set but not used.
16604
47553fa8
PE
16605 * print.c (print_object): Remove var that is set but not used.
16606
1f7196bf 16607 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
16608 The gnulib version avoids calling malloc in the usual case,
16609 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
16610 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
16611 * filelock.c (current_lock_owner): Likewise.
16612 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
16613 * sysdep.c: Include allocator.h, careadlinkat.h.
16614 (emacs_no_realloc_allocator): New static constant.
16615 (emacs_readlink): New function.
fdb61804
PE
16616 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
16617 ../lib/careadlinkat.h.
d1fdcab7 16618
f84c17c7
SM
166192011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
16620
16621 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
16622 first non-nil return value).
16623
ef3862ad
JD
166242011-04-03 Jan Djärv <jan.h.d@swipnet.se>
16625
16626 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
16627 if not defined (Bug#8403).
16628
376a7006
JB
166292011-04-02 Juanma Barranquero <lekktu@gmail.com>
16630
16631 * xdisp.c (display_count_lines): Remove parameter `start',
16632 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
16633 (get_char_face_and_encoding): Remove parameter `multibyte_p',
16634 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
16635 (fill_stretch_glyph_string): Remove parameters `row' and `area',
16636 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
16637 and thereabouts. All callers changed.
16638 (get_per_char_metric): Remove parameter `f', unused since
16639 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
16640
6ca3801d
JM
166412011-04-02 Jim Meyering <meyering@redhat.com>
16642
16643 do not dereference NULL upon failed strdup
16644 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
16645 (ns_get_family): Likewise.
16646
d8e2b5ba
JB
166472011-04-02 Juanma Barranquero <lekktu@gmail.com>
16648
16649 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
16650
8c74fcbd
JD
166512011-04-02 Jan Djärv <jan.h.d@swipnet.se>
16652
16653 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
16654 later (Bug#8403).
16655
7200d79c
SM
166562011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
16657
03408648 16658 Add lexical binding.
7200d79c 16659
03408648
SM
16660 * window.c (Ftemp_output_buffer_show): New fun.
16661 (Fsave_window_excursion):
16662 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
16663
16664 * lread.c (lisp_file_lexically_bound_p): New function.
16665 (Fload): Bind Qlexical_binding.
16666 (readevalloop): Remove `evalfun' arg.
16667 Bind Qinternal_interpreter_environment.
16668 (Feval_buffer): Bind Qlexical_binding.
16669 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
16670 Mark as dynamic.
16671 (syms_of_lread): Declare `lexical-binding'.
16672
16673 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
16674
16675 * keyboard.c (eval_dyn): New fun.
16676 (menu_item_eval_property): Use it.
ca105506
SM
16677
16678 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 16679
03408648
SM
16680 * fns.c (concat, mapcar1): Accept byte-code-functions.
16681
16682 * eval.c (Fsetq): Handle lexical vars.
16683 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
16684 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
16685 (FletX, Flet): Obey lexical binding.
16686 (Fcommandp): Handle closures.
16687 (Feval): New `lexical' arg.
16688 (eval_sub): New function extracted from Feval. Use it almost
16689 everywhere where Feval was used. Look up vars in lexical env.
16690 Handle closures.
16691 (Ffunctionp): Move from subr.el.
16692 (Ffuncall): Handle closures.
16693 (apply_lambda): Remove `eval_flags'.
16694 (funcall_lambda): Handle closures and new byte-code-functions.
16695 (Fspecial_variable_p): New function.
16696 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
16697 but without exporting it to Lisp.
23aba0ea 16698
23aba0ea 16699 * doc.c (Fdocumentation, store_function_docstring):
03408648 16700 * data.c (Finteractive_form): Handle closures.
23aba0ea 16701
03408648
SM
16702 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
16703 interactive spec.
ba83908c 16704
04f2d78b
CB
16705 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
16706 New byte-codes.
03408648
SM
16707 (exec_byte_code): New function extracted from Fbyte_code to handle new
16708 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 16709
03408648 16710 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 16711
03408648 16712 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 16713
e2abce01
JB
167142011-03-31 Juanma Barranquero <lekktu@gmail.com>
16715
16716 * xdisp.c (redisplay_internal): Fix prototype.
16717
63696a73 167182011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 16719
63696a73 16720 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
16721 (try_scrolling): Use it when setting scroll_limit.
16722 Limit scrolling to 100 screen lines.
63696a73
EZ
16723 (redisplay_window): Even when falling back on "recentering",
16724 position point in the window according to scroll-conservatively,
16725 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
16726
16727 (try_scrolling): When point is above the window, allow searching
16728 as far as scroll_max, or one screenful, to compute vertical
16729 distance from PT to the scroll margin position. This prevents
16730 try_scrolling from unnecessarily failing when
16731 scroll-conservatively is set to a value slightly larger than the
16732 window height. Clean up the case of PT below the margin at bottom
16733 of window: scroll_max can no longer be INT_MAX. When aggressive
16734 scrolling is in use, don't let point enter the opposite scroll
16735 margin as result of the scroll.
16736 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
16737 threshold of 100 lines for never-recentering scrolling.
16738
e4cc2dfc
JB
167392011-03-31 Juanma Barranquero <lekktu@gmail.com>
16740
16741 * dispextern.h (move_it_by_lines):
16742 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
16743 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
16744 (message_log_check_duplicate): Remove parameters `prev_bol' and
16745 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
16746 (redisplay_internal): Remove parameter `preserve_echo_area',
16747 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
16748
16749 * indent.c (Fvertical_motion):
16750 * window.c (window_scroll_pixel_based, Frecenter):
16751 Don't pass `need_y_p' to `move_it_by_lines'.
16752
1c470562
SM
167532011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
16754
44f230aa
SM
16755 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
16756 steal a few bits to be more compact.
16757 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
16758 Remove unneeded casts.
16759
1c470562
SM
16760 * bytecode.c (Fbyte_code): CAR and CDR can GC.
16761
888adce9
ZK
167622011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
16763
16764 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
16765 binding" message (bug#7967).
16766
f838ed7b
PE
167672011-03-30 Paul Eggert <eggert@cs.ucla.edu>
16768
77861b95
PE
16769 Fix more problems found by GCC 4.6.0's static checks.
16770
de6dbc14
PE
16771 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
16772 Remove unused local var.
16773
f838ed7b
PE
16774 * editfns.c (Fmessage_box): Remove unused local var.
16775
792c7b2b
PE
16776 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
16777 (note_mode_line_or_margin_highlight, note_mouse_highlight):
16778 Omit unused local vars.
c499e557 16779 * window.c (shrink_windows): Omit unused local var.
b01a1c29 16780 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
16781 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
16782 Omit unused local var.
16783
ba0165e1
PE
16784 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
16785 Don't assume string length fits in int.
32ad8845 16786 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 16787 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 16788
3c59b4c9
PE
16789 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
16790 instead of alloca (Bug#8344).
16791
a3eed478 16792 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 16793 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 16794
eb4d412d
PE
16795 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
16796
1658b401
PE
16797 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
16798 concerns.
16799
16800 * term.c (produce_glyphless_glyph): Remove unnecessary test.
16801
16802 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 16803
9a2c6e05
PE
16804 * keyboard.c (syms_of_keyboard): Use the same style as later
16805 in this function when indexing through an array. This also
16806 works around GCC bug 48267.
16807
03d0a109
PE
16808 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
16809
44f730c8
PE
16810 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
16811
fe75f926
PE
16812 * chartab.c (sub_char_table_ref_and_range): Redo for slight
16813 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
16814
ffa8c828
PE
16815 * keyboard.c, keyboard.h (num_input_events): Now size_t.
16816 This avoids undefined behavior on integer overflow, and is a bit
16817 more convenient anyway since it is compared to a size_t variable.
16818
c5101a77
PE
16819 Variadic C functions now count arguments with size_t, not int.
16820 This avoids an unnecessary limitation on 64-bit machines, which
16821 caused (substring ...) to crash on large vectors (Bug#8344).
16822 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
16823 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 16824 All variadic functions and their callers changed accordingly.
c5101a77
PE
16825 (struct gcpro.nvars): Now size_t, not int. All uses changed.
16826 * data.c (arith_driver, float_arith_driver): Likewise.
16827 * editfns.c (general_insert_function): Likewise.
16828 * eval.c (struct backtrace.nargs, interactive_p)
16829 (internal_condition_case_n, run_hook_with_args, apply_lambda)
16830 (funcall_lambda, mark_backtrace): Likewise.
16831 * fns.c (concat): Likewise.
16832 * frame.c (x_set_frame_parameters): Likewise.
16833 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
16834 0 if not found, not -1. All callers changed.
16835
dd3f25f7
PE
16836 * alloc.c (garbage_collect): Don't assume stack size fits in int.
16837 (stack_copy_size): Now size_t, not int.
16838 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
16839
461c2ab9
JB
168402011-03-28 Juanma Barranquero <lekktu@gmail.com>
16841
16842 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
16843 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16844 All callers changed.
16845
16846 * lisp.h (multibyte_char_to_unibyte):
16847 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
16848 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16849 * character.h (CHAR_TO_BYTE8):
16850 * cmds.c (internal_self_insert):
16851 * editfns.c (general_insert_function):
16852 * keymap.c (push_key_description):
16853 * search.c (Freplace_match):
16854 * xdisp.c (message_dolog, set_message_1): All callers changed.
16855
f6d62986
SM
168562011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
16857
16858 * keyboard.c (safe_run_hook_funcall): New function.
16859 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
16860 don't set the hook to nil, but remove the offending function instead.
16861 (Qcommand_hook_internal): Remove, unused.
16862 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
16863 Vcommand_hook_internal.
16864
16865 * eval.c (enum run_hooks_condition): Remove.
16866 (funcall_nil, funcall_not): New functions.
16867 (run_hook_with_args): Call each function through a `funcall' argument.
16868 Remove `cond' argument, now redundant.
16869 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
16870 (Frun_hook_with_args_until_failure): Adjust accordingly.
16871 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
16872
1db5b1ad
JB
168732011-03-28 Juanma Barranquero <lekktu@gmail.com>
16874
16875 * dispextern.h (string_buffer_position): Remove declaration.
16876
16877 * print.c (strout): Remove parameter `multibyte', unused since
16878 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
16879
16880 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
16881 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
16882 All callers changed.
16883
16884 * w32.c (_wsa_errlist): Use braces for struct initializers.
16885
16886 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
16887 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
16888 All callers changed.
16889 (string_buffer_position): Likewise. Also, make static (it's never
16890 used outside xdisp.c).
16891 (cursor_row_p): Remove parameter `w', unused since
16892 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
16893 (decode_mode_spec): Remove parameter `precision', introduced during
16894 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
16895 All callers changed.
16896
5ffb62aa
JD
168972011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16898
16899 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
16900
461c2ab9 169012011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
16902
16903 * nsterm.m (ns_menu_bar_is_hidden): New variable.
16904 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
16905 (ns_update_auto_hide_menu_bar): New functions.
16906 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
16907 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
16908 ns_constrain_all_frames.
16909 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
16910 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
16911
5c380ffb
JD
169122011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16913
16914 * nsmenu.m (runDialogAt): Remove argument to timer_check.
16915
9af30bdf
GM
169162011-03-27 Glenn Morris <rgm@gnu.org>
16917
16918 * syssignal.h: Replace RETSIGTYPE with void.
16919 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
16920 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
16921 Replace SIGTYPE with void everywhere.
16922 * s/usg5-4-common.h (SIGTYPE): Remove definition.
16923 * s/template.h (SIGTYPE): Remove commented out definition.
16924
e2abce01
JB
169252011-03-26 Eli Zaretskii <eliz@gnu.org>
16926
16927 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
16928 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
16929
f868cd8a
JB
169302011-03-26 Juanma Barranquero <lekktu@gmail.com>
16931
59eb0929
JB
16932 * w32.c (read_unc_volume): Use parameter `henum', instead of
16933 global variable `wget_enum_handle'.
16934
16935 * keymap.c (describe_vector): Remove parameters `indices' and
16936 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
16937 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
16938
f868cd8a
JB
16939 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
16940
16941 * keyboard.c (timer_check): Remove parameter `do_it_now',
16942 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
16943 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
16944 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
16945
16946 * keyboard.c (read_char):
16947 * w32menu.c (w32_menu_display_help):
16948 * xmenu.c (show_help_event, menu_help_callback):
16949 Adjust calls to `show_help_echo'.
16950
16951 * gtkutil.c (xg_maybe_add_timer):
16952 * keyboard.c (readable_events):
16953 * process.c (wait_reading_process_output):
16954 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
16955
16956 * insdel.c (adjust_markers_gap_motion):
16957 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
16958 (gap_left, gap_right): Don't call it.
16959
2ecf6fdb
CY
169602011-03-25 Chong Yidong <cyd@stupidchicken.com>
16961
16962 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
16963 incurred during fontification.
16964
6b1f9ba4
JB
169652011-03-25 Juanma Barranquero <lekktu@gmail.com>
16966
16967 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
16968 (DEFVAR_PER_BUFFER): Don't pass it.
16969
16970 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
16971 (scrolling_window): Don't pass it.
16972
0f4a96b5
JB
169732011-03-25 Juanma Barranquero <lekktu@gmail.com>
16974
16975 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
16976
16977 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
16978 and `suffix'.
16979 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
16980 of variables specific to SELinux and computation of `encoded_absname'.
16981
16982 * image.c (XPutPixel): Remove unused variable `height'.
16983
16984 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
16985
16986 * unexw32.c (get_section_info): Remove unused variable `section'.
16987
16988 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
16989 (system_process_attributes): Remove unused variable `sess'.
16990 (sys_read): Remove unused variable `err'.
16991
16992 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
16993 (w32_wnd_proc): Remove unused variable `isdead'.
16994 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
16995 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
16996 (x_create_tip_frame): Remove unused variable `tem'.
16997
16998 * w32inevt.c (w32_console_read_socket):
16999 Remove unused variable `no_events'.
17000
17001 * w32term.c (x_draw_composite_glyph_string_foreground):
17002 Remove unused variable `width'.
17003
1149507c
JB
170042011-03-24 Juanma Barranquero <lekktu@gmail.com>
17005
17006 * w32term.c (x_set_glyph_string_clipping):
17007 Don't pass uninitialized region to CombineRgn.
17008
9c88f339
JB
170092011-03-23 Juanma Barranquero <lekktu@gmail.com>
17010
17011 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
17012 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
17013 (Fx_close_connection): Remove unused variable `i'.
17014
17015 * w32font.c (w32font_draw): Return number of glyphs.
17016 (w32font_open_internal): Remove unused variable `i'.
17017 (w32font_driver): Add missing initializer.
17018
17019 * w32menu.c (utf8to16): Remove unused variable `utf16'.
17020 (fill_in_menu): Remove unused variable `items_added'.
17021
17022 * w32term.c (last_mouse_press_frame): Remove static global variable.
17023 (w32_clip_to_row): Remove unused variable `f'.
17024 (x_delete_terminal): Remove unused variable `i'.
17025
17026 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
17027 (NOTHING): Remove unused static global variable.
17028 (uniscribe_check_otf): Remove unused variable `table'.
17029 (uniscribe_font_driver): Add missing initializers.
17030
dee091a3
JD
170312011-03-23 Julien Danjou <julien@danjou.info>
17032
17033 * term.c (Fsuspend_tty, Fresume_tty):
17034 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
17035 * window.c (temp_output_buffer_show):
17036 * insdel.c (signal_before_change):
17037 * frame.c (Fhandle_switch_frame):
17038 * fileio.c (Fdo_auto_save):
17039 * emacs.c (Fkill_emacs):
17040 * editfns.c (save_excursion_restore):
17041 * cmds.c (internal_self_insert):
17042 * callint.c (Fcall_interactively):
17043 * buffer.c (Fkill_all_local_variables):
17044 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
17045 Use Frun_hooks.
0f4a96b5 17046 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 17047 unconditionally since it does the check itself.
dee091a3 17048
2c520ab5 170492011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 17050
c9c49752
PE
17051 Fix more problems found by GCC 4.5.2's static checks.
17052
8abc3f12
PE
17053 * coding.c (encode_coding_raw_text): Avoid unnecessary test
17054 the first time through the loop, since we know p0 < p1 then.
17055 This also avoids a gcc -Wstrict-overflow warning.
17056
a2d26660
PE
17057 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
17058 leading to a memory leak, possible in functions like
17059 load_charset_map_from_file that can allocate an unbounded number
b12ef411 17060 of objects (Bug#8318).
a2d26660 17061
916c72e9
PE
17062 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
17063 that could (at least in theory) be that large.
17064
19ab8a18
PE
17065 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
17066 This is less likely to overflow, and avoids undefined behavior if
17067 overflow does occur. All callers changed. Use strtoul to scan
17068 for the unsigned long integer.
b7cbbd6f
PE
17069 (pint2hrstr): Simplify and tune code slightly.
17070 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 17071
f0641eff
PE
17072 * scroll.c (do_scrolling): Work around GCC bug 48228.
17073 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
17074
7f650bb9
PE
17075 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
17076 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
17077 (validate_x_resource_name): Simplify count usage.
17078 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 17079
37dd57d1
PE
17080 * fileio.c (Fcopy_file): Report error if fchown or fchmod
17081 fail (Bug#8306).
81e56e61 17082
699979fc 17083 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 17084
401bf9b4
PE
17085 * process.c (Fmake_network_process): Use socklen_t, not int,
17086 where POSIX says socklen_t is required in portable programs.
17087 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 17088 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
17089 (Fmake_network_process, server_accept_connection):
17090 (wait_reading_process_output, read_process_output):
17091 Likewise.
17092
b93aacde
PE
17093 * process.c: Rename or move locals to avoid shadowing.
17094 (list_processes_1, Fmake_network_process):
17095 (read_process_output_error_handler, exec_sentinel_error_handler):
17096 Rename or move locals.
4dc343ee 17097 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 17098 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 17099 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 17100 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 17101 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 17102
af8a867c 17103 Make tparam.h and terminfo.c consistent.
44f230aa
SM
17104 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
17105 Include tparam.h instead, since it declares them.
af8a867c
PE
17106 * cm.h (PC): Remove extern decl; tparam.h now does this.
17107 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
17108 * terminfo.c: Include tparam.h, to check interfaces.
17109 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
17110 (tparam): Adjust signature to match interface in tparam.h;
17111 this removes some undefined behavior. Check that outstring and len
17112 are zero, which they always are with Emacs.
17113 * tparam.h (PC, BC, UP): New extern decls.
17114
0248044d 17115 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 17116 (xftfont_open): Rename locals to avoid shadowing.
0248044d 17117
8ff096c1 17118 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
17119 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
17120 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 17121 (ftfont_list): Remove unused local.
49eaafba
PE
17122 (get_adstyle_property, ftfont_pattern_entity):
17123 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
17124 Rename locals to avoid shadowing.
8ff096c1 17125
e2be39f6
PE
17126 * xfont.c (xfont_list_family): Mark var as initialized.
17127
c9735e30
PE
17128 * xml.c (make_dom): Now static.
17129
8f5201ae
PE
17130 * composite.c (composition_compute_stop_pos): Rename local to
17131 avoid shadowing.
b246f932
PE
17132 (composition_reseat_it): Remove unused locals.
17133 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 17134 (composition_update_it): Mark var as initialized.
11b61122
PE
17135 (find_automatic_composition): Mark vars as initialized,
17136 with a FIXME (Bug#8290).
8f5201ae 17137
760fbc2c
PE
17138 character.h: Rename locals to avoid shadowing.
17139 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
17140 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
17141 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
17142 (BUF_DEC_POS): Be more systematic about renaming local temporaries
17143 to avoid shadowing.
17144
ff08eb85
PE
17145 * textprop.c (property_change_between_p): Remove; unused.
17146
fc7bf025
PE
17147 * intervals.c (interval_start_pos): Now static.
17148
235d7abc
PE
17149 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
17150
44f230aa
SM
17151 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
17152 Rename locals to avoid shadowing.
3e7d6594 17153
50060332
PE
17154 * sound.c (wav_play, au_play, Fplay_sound_internal):
17155 Fix pointer signedness.
d01f234b 17156 (alsa_choose_format): Remove unused local var.
c83b8872
PE
17157 (wav_play): Initialize a variable to 0, to prevent undefined
17158 behavior (Bug#8278).
50060332 17159
c4fc4e30
PE
17160 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
17161
918436ed
PE
17162 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
17163
c939f91b
PE
17164 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
17165 clobbering (Bug#8298).
b9c7f648
PE
17166 * sysdep.c (sys_subshell): Likewise.
17167 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 17168
6bd8c144
PE
17169 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
17170 This should get cleaned up, so that child_setup has the
17171 same signature on all platforms.
17172
7710357c 17173 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 17174 (relocate_fd): Rename locals to avoid shadowing.
7710357c 17175
c59da222
CY
171762011-03-22 Chong Yidong <cyd@stupidchicken.com>
17177
17178 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
17179 not to be necessary, and produces flickering.
17180
66b87493
GM
171812011-03-20 Glenn Morris <rgm@gnu.org>
17182
17183 * config.in: Remove file.
17184
45b6f6d5
JB
171852011-03-20 Juanma Barranquero <lekktu@gmail.com>
17186
17187 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
17188 are now in src/globals.h.
17189 (syms_of_minibuf): Remove spurious & from previous change.
17190
cd394be1 171912011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
17192
17193 * minibuf.c (completing-read-function): New variable.
17194 (completing-read-default): Rename from completing-read.
17195 (completing-read): Call completing-read-function.
17196
b14e3e21
CY
171972011-03-19 Juanma Barranquero <lekktu@gmail.com>
17198
17199 * xfaces.c (Fx_load_color_file):
17200 Read color file from absolute filename (bug#8250).
17201
f2b726e6
JB
172022011-03-19 Juanma Barranquero <lekktu@gmail.com>
17203
17204 * makefile.w32-in: Update dependencies.
17205
09f6ff02
EZ
172062011-03-17 Eli Zaretskii <eliz@gnu.org>
17207
17208 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
17209
29a6015a
PE
172102011-03-17 Paul Eggert <eggert@cs.ucla.edu>
17211
a3a6c54e
PE
17212 Fix more problems found by GCC 4.5.2's static checks.
17213
b766f867
PE
17214 * process.c (make_serial_process_unwind, send_process_trap):
17215 (sigchld_handler): Now static.
17216
be02381c
PE
17217 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
17218 That way, the code declares only the vars that it needs.
17219 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
17220 * s/cygwin.h (PTY_ITERATION): Likewise.
17221 * s/darwin.h (PTY_ITERATION): Likewise.
17222 * s/gnu-linux.h (PTY_ITERATION): Likewise.
17223
57048744
PE
17224 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
17225 * process.c (allocate_pty): Don't declare stb unless it's needed.
17226
7914961c 17227 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
17228 (CONSTANTLIM): Remove; unused.
17229 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
17230 Define only if needed.
7914961c 17231
b3967b18
PE
17232 * unexelf.c (unexec): Name an expression,
17233 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
17234 Use a different way to cause a compilation error if anyone uses
17235 n rather than nn, a way that does not involve shadowing.
73366a00 17236 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 17237
29a6015a
PE
17238 * deps.mk (unexalpha.o): Remove; unused.
17239
43cfc33e 17240 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 17241 * unexec.h: New file.
ce701a33
PE
17242 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
17243 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
17244 Depend on unexec.h.
17245 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
17246 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
17247 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 17248 Change as necessary to match prototype in unexec.h.
ce701a33 17249
01f44d5a
PE
17250 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
17251 shadowing.
4f63c6bb 17252 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 17253
a6670b0b
PE
17254 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
17255 Rename locals to avoid shadowing.
17256
cef2010d 17257 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 17258 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 17259
d4d7173a
PE
17260 * print.c (Fredirect_debugging_output): Fix pointer signedess.
17261
f08b802a
PE
17262 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
17263 warning when compiling print.c.
17264
3ddb0639
PE
17265 * font.c (font_unparse_fcname): Abort in an "impossible" situation
17266 instead of using an uninitialized var.
5ad03b97 17267 (font_sort_entities): Mark var as initialized.
3ddb0639 17268
170a2692
PE
17269 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
17270
e663c700
PE
17271 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
17272 pointers to constants.
89bc529a 17273 (font_parse_fcname): Remove unused vars.
7b81e2d0 17274 (font_delete_unmatched): Now static.
ea838e10 17275 (font_get_spec): Remove; unused.
13a547c6
PE
17276 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
17277 (font_update_drivers, Ffont_get_glyphs, font_add_log):
17278 Rename or move locals to avoid shadowing.
e663c700 17279
2a80c887 17280 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 17281 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 17282
1384fa33 17283 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 17284 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 17285
8b2c52e9
PE
17286 * alloc.c (mark_backtrace): Move decl from here ...
17287 * lisp.h: ... to here, so that it can be checked.
17288
475545b5 17289 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 17290 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
17291 (lisp_indirect_variable): Name an expression,
17292 to avoid gcc -Wbad-function-cast warning.
1faed8ae 17293 (Fdefvar): Rename locals to avoid shadowing.
475545b5 17294
b1349114 17295 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 17296 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 17297 Use const pointer when appropriate.
b1349114 17298
a2928364
PE
17299 * lisp.h (get_system_name, get_operating_system_release):
17300 Move decls here, to check interfaces.
17301 * process.c (get_operating_system_release): Move decl to lisp.h.
17302 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
17303 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
17304 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
17305 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
17306 (Fformat_time_string, Fencode_time, Finsert_char):
17307 (Ftranslate_region_internal, Fformat):
17308 Rename or remove local vars to avoid shadowing.
9710023e 17309 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 17310
a415e694
PE
17311 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
17312 avoid shadowing.
17313
8ef4622d
PE
17314 * lisp.h (eassert): Check that the argument compiles, even if
17315 ENABLE_CHECKING is not defined.
17316
946f9a5b
PE
17317 * data.c (Findirect_variable): Name an expression, to avoid
17318 gcc -Wbad-function-cast warning.
112396d6 17319 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 17320 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
17321 (Fmake_variable_buffer_local, Fmake_local_variable):
17322 Mark variables as initialized.
52746918 17323 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 17324
e5aab7e7 17325 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
17326 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
17327 Rename locals to avoid shadowing.
dff45157
PE
17328 (mark_stack): Move local variables into the #ifdef region where
17329 they're used.
7bc26fdb
PE
17330 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
17331 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
17332 needed otherwise.
17333 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
17334 (GC_STRING_CHARS): Remove; not used.
d40d4be1 17335 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 17336
e5aab7e7
PE
17337 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
17338 avoids undefined behavior in theory.
17339
4da60324
PE
17340 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
17341
88043301
PE
17342 Use functions, not macros, for up- and down-casing (Bug#8254).
17343 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
17344 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
17345 to use the following functions instead of these macros.
17346 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
17347 EMACS_INT, since callers assume the returned value fits in int.
17348 (upcase1): Likewise, for UPCASE_TABLE.
17349 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 17350 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 17351 the race-condition problem in the old DOWNCASE.
88043301 17352
19ed5445
PE
17353 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
17354 Rename locals to avoid shadowing.
17355 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
17356 (regex_compile, re_search_2, re_match_2_internal):
17357 Remove unused local vars.
952db0d7
PE
17358 (FREE_VAR): Rewrite so as not to use empty "else",
17359 which gcc can warn about.
da053e48 17360 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
17361 (RETALLOC_IF): Define only if needed.
17362 (WORDCHAR_P): Likewise. This one is never needed, but is used
17363 only in a comment talking about a compiler bug, so put inside
17364 the #if 0 of that comment.
17365 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
17366 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
17367 Remove; unused.
19ed5445 17368
1f3561e4 17369 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
17370 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
17371 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 17372
ded6f8f7
PE
17373 * search.c (simple_search): Remove unused var.
17374
dbd37a95
PE
17375 * dired.c (compile_pattern): Move decl from here ...
17376 * lisp.h: ... to here, so that it can be checked.
17377 (struct re_registers): New forward decl.
17378
7e47afad
PE
17379 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
17380
85f24f61
PE
17381 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
17382 All uses changed.
17383 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
17384 Rename locals to avoid shadowing.
5671df8f 17385 (Fvertical_motion): Mark locals as initialized.
85f24f61 17386
181aa2be 17387 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 17388 (casify_region): Mark local as initialized.
181aa2be 17389
930d429c
PE
17390 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
17391
7082eac6
PE
17392 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
17393 New macros, so that the caller can use some names other than
17394 gcpro1, gcpro2, etc.
17395 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
17396 of the new macros.
17397 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
17398 argument, for consistency with GCPRO2_VAR, etc: it is now the
17399 prefix of the variable, not the variable itself. All uses
17400 changed.
38b2c076
PE
17401 * dired.c (directory_files_internal, file_name_completion):
17402 Rename locals to avoid shadowing.
17403
15206ed9
PE
17404 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
17405 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
17406 dired.c's scmp function, had undefined behavior.
17407 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
17408 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
17409 * buffer.h: ... to here, because these macros use current_buffer,
17410 and the new implementation with inline functions needs to have
17411 current_buffer in scope now, rather than later when the macros
17412 are used.
17413 (downcase, upcase1): New static inline functions.
17414 (DOWNCASE, UPCASE1): Reimplement using these functions.
17415 This avoids undefined behavior in expressions like
17416 DOWNCASE (x) == DOWNCASE (y), which previously suffered
17417 from race conditions in accessing the global variables
17418 case_temp1 and case_temp2.
17419 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
17420 * lisp.h (case_temp1, case_temp2): Remove their decls.
17421 * character.h (ASCII_CHAR_P): Move from here ...
17422 * lisp.h: ... to here, so that the inline functions mentioned
17423 above can use them.
17424
4a6bea26
PE
17425 * dired.c (directory_files_internal_unwind): Now static.
17426
f14b7e14
PE
17427 * fileio.c (file_name_as_directory, directory_file_name):
17428 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
17429 Now static.
2893f146
PE
17430 (file_name_as_directory): Use const pointers when appropriate.
17431 (Fexpand_file_name): Likewise. In particular, newdir might
17432 point at constant storage, so make it a const pointer.
fd4ead52 17433 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
17434 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
17435 signedness issues.
f839df0c
PE
17436 (Fset_file_times, Finsert_file_contents, auto_save_error):
17437 Rename locals to avoid shadowing.
f14b7e14 17438
5716756e 17439 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
17440 (Ftry_completion, Fall_completions): Rename or remove locals
17441 to avoid shadowing.
5716756e 17442
b4c3046a
PE
17443 * marker.c (bytepos_to_charpos): Remove; unused.
17444
b45db522
PE
17445 * lisp.h (verify_bytepos, count_markers): New decls,
17446 so that gcc does not warn that these functions aren't declared.
17447
85876d07
PE
17448 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
17449 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 17450 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 17451 (copy_text): Remove unused local var.
85876d07 17452
03d78a21 17453 * filelock.c (within_one_second): Now static.
b3dd38ab 17454 (lock_file_1): Rename local to avoid shadowing.
03d78a21 17455
5df8f01b
PE
17456 * buffer.c (fix_overlays_before): Mark locals as initialized.
17457 (fix_start_end_in_overlays): Likewise. This function should be
17458 simplified by using pointers-to-pointers, but that's a different
17459 matter.
b1d876f1 17460 (switch_to_buffer_1): Now static.
8f54f30a
PE
17461 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
17462 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 17463
a70072c9 17464 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 17465 Fix pointer signedness issue.
edced198
PE
17466 (sys_subshell): Mark local as volatile if checking for lint,
17467 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 17468 (MAXPATHLEN): Define only if needed.
a70072c9 17469
a0977c44
PE
17470 * process.c (serial_open, serial_configure): Move decls from here ...
17471 * systty.h: ... to here, so that they can be checked.
17472
a884fdcc
PE
17473 * fns.c (get_random, seed_random): Move extern decls from here ...
17474 * lisp.h: ... to here, so that they can be checked.
17475
604efe86 17476 * sysdep.c (reset_io): Now static.
b8950c94 17477 (wait_for_termination_signal): Remove; unused.
604efe86 17478
38fc62d9
PE
17479 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
17480 (copy_keymap_item, append_key, push_text_char_description):
17481 Now static.
1004a21a 17482 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 17483 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
17484 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
17485 (describe_map_tree):
17486 Rename locals to avoid shadowing.
38fc62d9 17487
2f2650da
PE
17488 * keyboard.c: Declare functions static if they are not used elsewhere.
17489 (echo_char, echo_dash, cmd_error, top_level_2):
17490 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
17491 (read_char, kbd_buffer_get_event, make_lispy_position):
17492 (make_lispy_event, make_lispy_movement, apply_modifiers):
17493 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
17494 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
17495 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 17496 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 17497 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 17498
a053e86c 17499 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
17500 (mark_kboards): Move decl here ...
17501 * alloc.c (mark_kboards): ... from here.
a053e86c 17502
4752793e
PE
17503 * lisp.h (force_auto_save_soon): New decl.
17504
74f10ca7 17505 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
17506 (DEFINE_DUMMY_FUNCTION): New macro.
17507 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
17508 Use it.
c03cd23f
PE
17509 (main): Add casts to avoid warnings
17510 if GCC considers string literals to be constants.
74f10ca7 17511
022e70d4
PE
17512 * lisp.h (fatal_error_signal): Add decl, since it's exported.
17513
59d6fe83
PE
17514 * dbusbind.c: Pointer signedness fixes.
17515 (xd_signature, xd_append_arg, xd_initialize):
17516 (Fdbus_call_method, Fdbus_call_method_asynchronously):
17517 (Fdbus_method_return_internal, Fdbus_method_error_internal):
17518 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
17519 (Fdbus_register_signal): Use SSDATA when the context wants char *.
17520
78320123
PE
17521 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
17522 if GCC considers string literals to be constants.
49cebcca 17523 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 17524
35ac2a97
SM
175252011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
17526
fb103ca9
SM
17527 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
17528 (print_preprocess, print_object): New macro to fix last change.
17529
35ac2a97
SM
17530 * print.c (print_preprocess): Don't forget font objects.
17531
62973b41
JB
175322011-03-16 Juanma Barranquero <lekktu@gmail.com>
17533
17534 * emacs.c (USAGE3): Doc fixes.
17535
0e48bb22
AS
175362011-03-15 Andreas Schwab <schwab@linux-m68k.org>
17537
17538 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
17539 structure.
17540
7684e57b
JB
175412011-03-14 Juanma Barranquero <lekktu@gmail.com>
17542
17543 * lisp.h (VWindow_system, Qfile_name_history):
17544 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
17545 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
17546 (w32_system_caret_x, w32_system_caret_y): Declare extern.
17547
17548 * w32select.c: Don't #include "keyboard.h".
c96bbc66 17549 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
17550
17551 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
17552 * w32console.c (detect_input_pending, read_input_pending)
17553 (encode_terminal_code):
17554 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
17555 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
17556 (w32_system_caret_y, Qfile_name_history):
17557 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
17558 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
17559 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
17560 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
17561 * w32proc.c (Qlocal, report_file_error):
17562 * w32term.c (Vwindow_system, updating_frame):
17563 * w32uniscribe.c (initialized, uniscribe_font_driver):
17564 Remove unneeded extern declarations.
17565
2aa46d6c
CY
175662011-03-14 Chong Yidong <cyd@stupidchicken.com>
17567
c96bbc66 17568 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 17569
cffc6f3b
CY
175702011-03-13 Chong Yidong <cyd@stupidchicken.com>
17571
17572 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
17573 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
17574 These macros can no longer be used for assignment.
17575
44f230aa
SM
17576 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
17577 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
17578 (record_buffer_markers, fetch_buffer_markers): New functions for
17579 recording and fetching special buffer markers.
17580 (set_buffer_internal_1, set_buffer_temp): Use them.
17581
17582 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
17583
17584 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
17585
17586 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
17587 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
17588
17589 * xdisp.c (hscroll_window_tree):
17590 (reconsider_clip_changes): Use PT instead of BUF_PT.
17591
d251f04b
EZ
175922011-03-13 Eli Zaretskii <eliz@gnu.org>
17593
17594 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
17595 $(EMACS_ROOT)/lib/intprops.h.
17596
f0c77cd1
PE
175972011-03-13 Paul Eggert <eggert@cs.ucla.edu>
17598
3eca4629
PE
17599 Fix more problems found by GCC 4.5.2's static checks.
17600
7c86ee98
PE
17601 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
17602 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
17603 (xg_free_frame_widgets): Make it clear that a local variable is
17604 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
17605 (gdk_window_get_screen): Make it clear that this macro is needed
17606 only if USE_GTK_TOOLTIP.
1e5524e7
PE
17607 (int_gtk_range_get_value): New function, which avoids a diagnostic
17608 from gcc -Wbad-function-cast.
17609 (xg_set_toolkit_scroll_bar_thumb): Use it.
17610 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
17611 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
17612 (get_utf8_string, xg_get_file_with_chooser):
17613 Rename locals to avoid shadowing.
17614 (create_dialog): Move locals to avoid shadowing.
7c86ee98 17615
41729b81
PE
17616 * xgselect.c (xg_select): Remove unused var.
17617
f0c77cd1
PE
17618 * image.c (four_corners_best): Mark locals as initialized.
17619 (gif_load): Initialize transparent_p to zero (Bug#8238).
17620 Mark another local as initialized.
ec6cf4c6 17621 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 17622
ce0ad53d 17623 * image.c (clear_image_cache): Now static.
d5d5a617 17624 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 17625 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
17626 (x_edge_detection): Remove unnecessary cast that
17627 gcc -Wbad-function-cast diagnoses.
2037898d 17628 (gif_load): Fix pointer signedness.
6ae141d6
PE
17629 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
17630 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 17631
33383987 176322011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 17633
d32df629
PE
17634 Improve quality of tests for time stamp overflow.
17635 For example, without this patch (encode-time 0 0 0 1 1
17636 1152921504606846976) returns the obviously-bogus value (-948597
17637 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
17638 reports time overflow. See
17639 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
17640 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
17641 * editfns.c: Include limits.h and intprops.h.
17642 (TIME_T_MIN, TIME_T_MAX): New macros.
17643 (time_overflow): Move earlier, to before first use.
17644 (hi_time, lo_time): New functions, for an accurate test for
17645 out-of-range times.
17646 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
17647 (Fget_internal_run_time): Don't assume time_t fits in int.
17648 (make_time): Use list2 instead of Fcons twice.
17649 (Fdecode_time): More accurate test for out-of-range times.
17650 (check_tm_member): New function.
17651 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
17652 (lisp_time_argument): Don't rely on undefined left-shift and
17653 right-shift behavior when checking for time stamp overflow.
8be6f318 17654
fe31d94c
PE
17655 * editfns.c (time_overflow): New function, refactoring common code.
17656 (Fformat_time_string, Fdecode_time, Fencode_time):
17657 (Fcurrent_time_string): Use it.
17658
8be6f318
PE
17659 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
17660 * dired.c (make_time): Move to ...
17661 * editfns.c (make_time): ... here.
17662 * systime.h: Note the move.
17663
09d9db2c 176642011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 17665
126bc0dc
YM
17666 * fringe.c (update_window_fringes): Remove unused variables.
17667
c47cbdfd
YM
17668 * unexmacosx.c (copy_data_segment): Also copy __got section.
17669 (Bug#8223)
17670
7ac80be9
EZ
176712011-03-12 Eli Zaretskii <eliz@gnu.org>
17672
c96bbc66 17673 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
17674 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
17675 Constify `char *' arguments and their references according to
17676 prototypes in tparam.h.
17677
ecb0f94d 17678 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 17679
7ac80be9
EZ
17680 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
17681 Adapt all references accordingly.
17682
17683 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
17684
ef1fd07e
TT
176852011-03-11 Tom Tromey <tromey@redhat.com>
17686
17687 * buffer.c (syms_of_buffer): Remove obsolete comment.
17688
7ef4b50c
EZ
176892011-03-11 Eli Zaretskii <eliz@gnu.org>
17690
17691 * termhooks.h (encode_terminal_code): Declare prototype.
17692
17693 * msdos.c (encode_terminal_code): Don't declare prototype.
17694
17695 * term.c (encode_terminal_code): Now external again, used by
17696 w32console.c and msdos.c.
17697
44f230aa
SM
17698 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
17699 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 17700
4b1ec863 177012011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 17702
1714f52b 17703 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 17704
4b1ec863
PE
17705 * fringe.c (update_window_fringes): Mark locals as initialized
17706 (Bug#8227).
17707 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 17708
524c7aa6
PE
17709 * alloc.c (mark_fringe_data): Move decl from here ...
17710 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
17711 to check its interface.
17712 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
17713
a5c0af81 17714 * fontset.c (free_realized_fontset): Now static.
7519b8cd 17715 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 17716 (fontset_font): Mark local as initialized.
a9a06e0b 17717 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 17718
b4716021
PE
17719 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
17720
811e9bac 17721 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 17722 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
17723 (x_own_selection, Fx_disown_selection_internal): Rename locals
17724 to avoid shadowing.
17725 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 17726
7e3ab302
PE
17727 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
17728 so that the caller can use some name other than gcpro1.
17729 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
17730 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
17731 (Fx_backspace_delete_keys_p):
17732 Use them to avoid shadowing, and rename vars to avoid shadowing.
17733 (x_decode_color, x_set_name, x_window): Now static.
6b437900 17734 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 17735 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
17736 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
17737 Remove unused locals.
7e3ab302
PE
17738 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
17739 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
17740 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
17741 macros.
f78faa98 17742
e2b13473
PE
17743 * xterm.h (x_mouse_leave): New decl.
17744
77f23912
PE
17745 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
17746 Remove unused functions.
cdf4ba58
PE
17747 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
17748 (x_calc_absolute_position): Now static.
7411c686 17749 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 17750 Don't declare local "event" unless it's used.
ed7bf3a5
PE
17751 (x_iconify_frame, x_free_frame_resources): Don't declare locals
17752 unless they are used.
38d0b34a
PE
17753 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
17754 (x_fatal_error_signal): Remove; not used.
a6067996
PE
17755 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
17756 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
17757 (x_error_catcher, x_connection_closed, x_error_handler):
17758 (x_error_quitter, xembed_send_message, x_iconify_frame):
17759 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 17760 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 17761 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 17762
44f230aa
SM
17763 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
17764 Rename or move locals to avoid shadowing.
6b463e58 17765 (tty_defined_color, merge_face_heights): Now static.
5967d051 17766 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
17767 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
17768 does not deduce is never used uninitialized.
73719eba
PE
17769 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
17770 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 17771
426994c3 17772 * terminal.c (store_terminal_param): Now static.
5489860b 17773
032f1620 17774 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 17775 (set_frame_menubar): Remove unused local.
d4323972 17776 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
17777 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
17778 since they might point to immutable storage.
281585b0
PE
17779 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
17780 since it's unused otherwise.
032f1620 17781
367c19e5 17782 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 17783 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
17784 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
17785 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 17786 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
17787 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
17788 does not deduce are never used uninitialized.
70739cbe 17789
07b48fa9
PE
17790 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
17791
8868a238 17792 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
17793 * window.c (window_loop, size_window):
17794 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 17795
7e5cf297 17796 * window.c (display_buffer): Now static.
d6550a9f
PE
17797 (size_window): Mark variables that gcc -Wuninitialized
17798 does not deduce are never used uninitialized.
a586633d
PE
17799 * window.h (check_all_windows): New decl, to forestall
17800 gcc -Wmissing-prototypes diagnostic.
5b555da1 17801 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 17802
f6095868
PE
17803 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
17804 shadowing.
17805 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
17806 Include <limits.h>.
17807 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
17808 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
17809 (load_charset_map): Mark variables that gcc -Wuninitialized
17810 does not deduce are never used uninitialized.
53df7c11 17811 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 17812
f38b440c
PE
17813 * coding.c (coding_set_source, coding_set_destination):
17814 Use "else { /* comment */ }" rather than "else /* comment */;"
17815 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
17816 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
17817 a block, when the outer 'i' will do.
17818 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
17819 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
17820 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
17821 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
17822 (Fdecode_sjis_char, Fdefine_coding_system_internal):
17823 Rename locals to avoid shadowing.
17824 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
17825 * coding.c (emacs_mule_char, encode_invocation_designation):
17826 Now static, since they're not used elsewhere.
413bb2db 17827 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 17828 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
17829 (decode_coding_emacs_mule): Mark variables that gcc
17830 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
17831 (detect_coding_iso_2022): Initialize a local variable that might
17832 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 17833 this initialization is needed. (Bug#8211)
5f58e762
PE
17834 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
17835 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
17836 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
17837 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
17838 Remove unused macros.
f38b440c 17839
232b38b9 17840 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 17841 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 17842 * character.c (string_count_byte8): Likewise.
232b38b9 17843
fb90da1b
PE
17844 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
17845 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
17846
fb93dbc2
PE
17847 * chartab.c (copy_sub_char_table): Now static, since it's not used
17848 elsewhere.
5c156ace
PE
17849 (sub_char_table_ref_and_range, char_table_ref_and_range):
17850 Rename locals to avoid shadowing.
bbcd0949 17851 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 17852
7d3b3862 17853 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 17854 (BIDI_BOB): Remove unused macro.
7d3b3862 17855
6be7d3da
PE
17856 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
17857 deduce are never used uninitialized.
c2ed9c8b 17858 * term.c (encode_terminal_code): Likewise.
6be7d3da 17859
75f8807f 17860 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 17861
50938595
PE
17862 * tparam.h: New file.
17863 * term.c, tparam.h: Include it.
17864 * deps.mk (term.o, tparam.o): Depend on tparam.h.
17865 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
17866 Move these decls to tparam.h, and make them agree with what
17867 is actually in tparam.c. The previous trick of using incompatible
17868 decls in different modules does not conform to the C standard.
17869 All callers of tparam changed to use tparam's actual API.
17870 * tparam.c (tparam1, tparam, tgoto):
17871 Use const pointers where appropriate.
17872
fbceeba2
PE
17873 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
17874 * cm.h (struct cm): Likewise.
17875 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
17876 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
17877 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
17878 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
17879 (turn_on_face, init_tty): Likewise.
17880 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 17881
7f3f1250
PE
17882 * term.c (term_mouse_position): Rename local to avoid shadowing.
17883
e6ca6543
PE
17884 * alloc.c (mark_ttys): Move decl from here ...
17885 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
17886
c40f8d15
AS
178872011-03-11 Andreas Schwab <schwab@linux-m68k.org>
17888
17889 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
17890
cfe0661d
JB
178912011-03-09 Juanma Barranquero <lekktu@gmail.com>
17892
17893 * search.c (compile_pattern_1): Remove argument regp, unused since
17894 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
17895 (compile_pattern): Don't pass it.
17896
0afb4571
J
178972011-03-08 Jan Djärv <jan.h.d@swipnet.se>
17898
17899 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
17900 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
17901 for ! HAVE_GTK3.
17902 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
17903
17904 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
17905
17906 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
17907 gdk_window_get_screen, gdk_window_get_geometry,
17908 gdk_x11_window_lookup_for_display and GDK_KEY_g.
17909 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
17910 (xg_get_pixbuf_from_pixmap): New function.
17911 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
17912 to Pixmap, take frame as parameter, remove GdkColormap parameter.
17913 Call xg_get_pixbuf_from_pixmap instead of
17914 gdk_pixbuf_get_from_drawable.
17915 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
17916 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
17917 (xg_check_special_colors): Use GtkStyleContext and its functions
17918 for HAVE_GTK3.
17919 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
17920 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
17921 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
17922 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
17923 Call gtk_widget_get_preferred_size.
0afb4571
J
17924 (xg_frame_resized): gdk_window_get_geometry only takes 5
17925 parameters.
44f230aa
SM
17926 (xg_win_to_widget, xg_event_is_for_menubar):
17927 Call gdk_x11_window_lookup_for_display.
0afb4571
J
17928 (xg_set_widget_bg): New function.
17929 (delete_cb): New function.
895009e1 17930 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 17931 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
17932 (xg_set_background_color): Call xg_set_widget_bg.
17933 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
17934 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
17935 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
17936 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
17937 if ! HAVE_GTK3.
17938 (update_frame_tool_bar): Call gtk_widget_hide.
17939 (xg_initialize): Use GDK_KEY_g.
17940
17941 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
17942 if ! HAVE_GTK3
17943 (x_session_initialize): Call gdk_x11_set_sm_client_id.
17944
17945 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
17946 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
17947 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
17948
1c2cc4ef
JB
179492011-03-08 Juanma Barranquero <lekktu@gmail.com>
17950
17951 * w32xfns.c (select_palette): Check success of RealizePalette against
17952 GDI_ERROR, not zero.
17953
33383987 17954See ChangeLog.11 for earlier changes.
aac0c6e3
MR
17955
17956;; Local Variables:
17957;; coding: utf-8
aac0c6e3
MR
17958;; End:
17959
2f097256 17960 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
17961
17962 This file is part of GNU Emacs.
17963
17964 GNU Emacs is free software: you can redistribute it and/or modify
17965 it under the terms of the GNU General Public License as published by
17966 the Free Software Foundation, either version 3 of the License, or
17967 (at your option) any later version.
17968
17969 GNU Emacs is distributed in the hope that it will be useful,
17970 but WITHOUT ANY WARRANTY; without even the implied warranty of
17971 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17972 GNU General Public License for more details.
17973
17974 You should have received a copy of the GNU General Public License
17975 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.