* xfns.c (Fx_change_window_property): Doc fix.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ddadbc0e
AS
12012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2
fca8d6b6
AS
3 * xfns.c (Fx_change_window_property): Doc fix.
4 * w32fns.c (Fx_change_window_property): Doc fix.
5
ddadbc0e
AS
6 * w32fns.c (Fx_window_property): Accept the same arguments as the
7 X Windows version. Doc fix.
8 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
9
f247498e
JB
102012-07-06 Juanma Barranquero <lekktu@gmail.com>
11 Eli Zaretskii <eliz@gnu.org>
12
13 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
14 Windows-specific code from nt/config.nt moved here.
15 Obsolete settings removed.
16
216ee680
PE
172012-07-06 Paul Eggert <eggert@cs.ucla.edu>
18
19 * process.c: Avoid unnecessary calls to gettime.
20 (wait_reading_process_output): Don't get the time of day
21 when gobbling data immediately and not waiting, as there's no need
22 for it in that case. This removes a FIXME.
23
bdd091e4
JD
242012-07-06 Jan Djärv <jan.h.d@swipnet.se>
25
26 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
27 is defined (Bug#11768).
28
9d44f8ce
DA
292012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
30
31 Fix marker debugging code.
32 * marker.c (byte_char_debug_check): Do not perform the check
33 if buffer is not multibyte.
34 (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Call
35 byte_char_debug_check with correct arguments.
36
90fc4786
DA
372012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
38
39 Compile marker debugging code only if ENABLE_CHECKING is defined.
40 * marker.c (byte_char_debug_check, count_markers): Use
41 only if ENABLE_CHECKING is defined.
42 (byte_debug_flag): Remove.
43 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
44 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
45
7b7ae965
DA
462012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
47
4e57b342
DA
48 Avoid code repetition in marker-related functions.
49 * marker.c (attach_marker): New function.
50 (Fset_marker, set_marker_restricted, set_marker_both)
51 (set_marker_restricted_both): Use it.
52 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
53 Consistently rename charno to charpos.
54 (marker_position): Add eassert.
55 (marker_byte_position): Convert to eassert.
56
572012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
58
59 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 60 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 61 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 62
657924ff
DA
632012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
64
65 Introduce fast path for the widely used marker operation.
66 * alloc.c (build_marker): New function.
67 * lisp.h (build_marker): New prototype.
68 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
69 * composite.c (autocmp_chars): Likewise.
70 * editfns.c (buildmark): Remove.
71 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
72 (save_restriction_save): Use build_marker.
73 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
74 * window.c (save_window_save): Likewise.
75
041a49a6
DA
762012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
77
78 Do not use Fdelete_overlay in delete_all_overlays
79 to avoid redundant calls to unchain_overlay.
80 * buffer.c (drop_overlay): New function.
81 (delete_all_overlays, Fdelete_overlay): Use it.
82 * minibuf.c (get_minibuffer): Fix comment.
83
7dca65a4
PE
842012-07-06 Paul Eggert <eggert@cs.ucla.edu>
85
86 Port to OpenBSD 5.1 amd64.
87 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
88 This is needed for OpenBSD, and should be harmless on all BSD systems.
89 Also, include <sys/sysctl.h>, as it should be available on all
90 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
91 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
92 use p_pid member, not kp_proc.pid.
93
8eb876e2
GM
942012-07-06 Glenn Morris <rgm@gnu.org>
95
96 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
97
38182d90
PE
982012-07-05 Paul Eggert <eggert@cs.ucla.edu>
99
100 More xmalloc and related cleanup.
101 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
102 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
103 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
104 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
105 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
106 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
107 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
108 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
109 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
110 * xterm.c:
111 Omit needless casts involving void * pointers and allocation.
112 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
113 as the former is more robust if P's type is changed.
114 Prefer xzalloc to xmalloc + memset 0.
115 Simplify malloc-or-realloc to realloc.
116 Don't worry about xmalloc returning a null pointer.
117 Prefer xstrdup to xmalloc + strcpy.
118 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
119 growing it.
120 * keyboard.c (apply_modifiers_uncached): Prefer local array to
121 alloca of a constant.
122
6dd5a677
EZ
1232012-07-05 Eli Zaretskii <eliz@gnu.org>
124
125 * xdisp.c (display_line): Fix horizontal pixel coordinates when
126 hscroll is larger than the line width. Fixes long and futile
127 looping inside extend_face_to_end_of_line (on a TTY) producing
128 glyphs that are not needed and thrown away.
129
6b312f0f
DA
1302012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
131
132 * marker.c (set_marker_restricted_both): Simplify by using
133 clip_to_bounds.
134
f520ef9b
PE
1352012-07-05 Paul Eggert <eggert@cs.ucla.edu>
136
137 * editfns.c (region_limit): Simplify by using clip_to_bounds.
138
383b7c95
JD
1392012-07-05 Jan Djärv <jan.h.d@swipnet.se>
140
141 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
142 not defined (Bug#11768).
143 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
144 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
145 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
146 followed by gtk_box_set_homogeneous (Bug#11768).
147 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
148 (update_theme_scrollbar_width, xg_create_scroll_bar): Use
149 gtk_scrollbar_new (Bug#11768).
150 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
151 (is_box_type): New function (Bug#11768).
152 (xg_tool_item_stale_p): Call is_box_type.
5293d758 153 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
154 with default display (Bug#11768).
155
d6e7bf45
EZ
1562012-07-05 Eli Zaretskii <eliz@gnu.org>
157
158 * xdisp.c (window_hscroll_limited): New function.
159 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
160 coordinates when window's hscroll is set to insanely large
161 values. (Bug#11857)
162
431391ec
JB
1632012-07-05 Juanma Barranquero <lekktu@gmail.com>
164
165 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
166 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
167
23f86fce
DA
1682012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
169
170 Cleanup xmalloc.
171 * lisp.h (xzalloc): New prototype. Omit needless casts.
172 * alloc.c (xzalloc): New function. Omit needless casts.
173 * charset.c: Omit needless casts. Convert all calls to
174 xmalloc with following memset to xzalloc.
175 * dispnew.c: Likewise.
176 * fringe.c: Likewise.
177 * image.c: Likewise.
178 * sound.c: Likewise.
179 * term.c: Likewise.
180 * w32fns.c: Likewise.
181 * w32font.c: Likewise.
182 * w32term.c: Likewise.
183 * xfaces.c: Likewise.
184 * xfns.c: Likewise.
185 * xterm.c: Likewise.
186 * atimer.c: Omit needless casts.
187 * buffer.c: Likewise.
188 * callproc.c: Likewise.
189 * ccl.c: Likewise.
190 * coding.c: Likewise.
191 * composite.c: Likewise.
192 * doc.c: Likewise.
193 * doprnt.c: Likewise.
194 * editfns.c: Likewise.
195 * emacs.c: Likewise.
196 * eval.c: Likewise.
197 * filelock.c: Likewise.
198 * fns.c: Likewise.
199 * gtkutil.c: Likewise.
200 * keyboard.c: Likewise.
201 * lisp.h: Likewise.
202 * lread.c: Likewise.
203 * minibuf.c: Likewise.
204 * msdos.c: Likewise.
205 * print.c: Likewise.
206 * process.c: Likewise.
207 * region-cache.c: Likewise.
208 * search.c: Likewise.
209 * sysdep.c: Likewise.
210 * termcap.c: Likewise.
211 * terminal.c: Likewise.
212 * tparam.c: Likewise.
213 * w16select.c: Likewise.
214 * w32.c: Likewise.
215 * w32reg.c: Likewise.
216 * w32select.c: Likewise.
217 * w32uniscribe.c: Likewise.
218 * widget.c: Likewise.
219 * xdisp.c: Likewise.
220 * xmenu.c: Likewise.
221 * xrdb.c: Likewise.
222 * xselect.c: Likewise.
223
0497dc44
PE
2242012-07-05 Paul Eggert <eggert@cs.ucla.edu>
225
226 * fileio.c (time_error_value): Check the right error number.
227 Problem reported by Troels Nielsen in
228 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
229
356e7178
PE
2302012-07-04 Paul Eggert <eggert@cs.ucla.edu>
231
4e71fd89
PE
232 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
233 This should be fixed in a better way; see Eli Zaretskii in
234 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
235 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
236
f0941253
PE
237 * fileio.c (time_error_value): Rename from special_mtime.
238 The old name's problems were noted by Eli Zaretskii in
239 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
240
065c9eb4
PE
241 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
242 This variable's comment says Emacs needs at least one GDB-visible
243 symbol of type enum pvec_type, to work around GDB problems.
244 The symbol's value doesn't matter.
245
356e7178
PE
246 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
247 that causes compilation to fail on pre-C99 compilers.
248
95f61aa2
JB
2492012-07-04 Juanma Barranquero <lekktu@gmail.com>
250
251 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
252 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
253
3884d954
DA
2542012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
255
d209e2fb 256 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
257 headers for buffer_defaults and buffer_local_symbols.
258 Reported by Juanma Barranquero <lekktu@gmail.com>.
259
ee28be33
SM
2602012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
261
262 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
263 * lisp.h (enum pvec_type): Use fewer bits.
264 (PSEUDOVECTOR_SIZE_BITS): New constant.
265 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
266 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
267 change in pvec_type.
268 (PSEUDOVECTOR_TYPEP): New macro.
269 (TYPED_PSEUDOVECTORP): Use it.
270 * fns.c (internal_equal): Adapt code to extract pvectype.
271 * emacs.c (gdb_pvec_type): Update type.
272 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
273 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
274 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
275 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
276 (sweep_vectors): Use it. Use local var `total_bytes' instead of
277 abusing vector->header.next.nbytes.
278 (live_vector_p): Use PVEC_TYPE.
279 (mark_object): Adapt code to extract pvectype. Use switch.
280
c7f2cd7f
PE
2812012-07-04 Paul Eggert <eggert@cs.ucla.edu>
282
283 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
284 Tighten new eassert a bit.
285
8ce70ed2
DA
2862012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
287
288 Fix compilation with --enable-gcc-warnings and -O1
289 optimization level.
290 * doprnt.c (doprnt): Change type of tem to int, initialize
291 to avoid compiler warning. Add eassert.
292 * search.c (simple_search): Initialize match_byte to avoid
293 compiler warning. Add eassert.
294
dea7f1e5
PE
2952012-07-04 Paul Eggert <eggert@cs.ucla.edu>
296
24a212eb
PE
297 Avoid weird behavior with large horizontal scrolls.
298 Without this change, for example, large hscroll values would
299 mess up Emacs's display on Fedora 15 x86, presumably due to
300 overflows in int calculations in the display code.
301 Also, if buffers had long lines, Emacs would freeze.
302 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
303 (set_window_hscroll): New function, containing the old guts of
304 Fset_window_hscroll. Return the clipped value.
305 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
306 This avoids the need to check against PTRDIFF_MAX.
307
dea7f1e5
PE
308 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
309
76046526
DA
3102012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
311
312 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
313
39adff0d
PE
3142012-07-04 Paul Eggert <eggert@cs.ucla.edu>
315
63807d47
PE
316 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
317 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
318 since GCC 4.4.6 issues a bogus warning for them.
319
39adff0d
PE
320 Fix bugs in file timestamp newness comparisons.
321 * fileio.c (Ffile_newer_than_file_p):
322 * lread.c (Fload): Use full timestamp resolution of files,
323 not just the 1-second resolution, so that files that are only
324 slightly newer still count as newer.
325 * fileio.c (Ffile_newer_than_file_p): Don't assume file
326 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
327
dbeed9a6
PE
3282012-07-03 Paul Eggert <eggert@cs.ucla.edu>
329
330 * fileio.c: Improve handling of file time marker. (Bug#11852)
331 (special_mtime): New function.
332 (Finsert_file_contents, Fverify_visited_file_modtime):
333 Use it to set special mtime values consistently.
334
636334d6
AS
3352012-07-03 Andreas Schwab <schwab@linux-m68k.org>
336
337 * fileio.c (Finsert_file_contents): Properly handle st_mtime
338 marker for non-existing file. (Bug#11852)
339
e2017fe2
GM
3402012-07-03 Glenn Morris <rgm@gnu.org>
341
342 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
343 and did not make it into globals.h).
344
404dbd37
TT
3452012-07-03 Tom Tromey <tromey@redhat.com>
346
347 * window.c (Fset_window_margins, Fset_window_fringes)
348 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
349 * textprop.c (Fprevious_property_change): No longer static.
350 * syntax.c (Fsyntax_table_p): No longer static.
351 * process.c (Fget_process, Fprocess_datagram_address): No longer
352 static.
353 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
354 * keyboard.c (Fcommand_execute): No longer static.
355 Remove EXFUN.
356 * insdel.c (Fcombine_after_change_execute): No longer static.
357 * image.c (Finit_image_library): No longer static.
358 * fileio.c (Fmake_symbolic_link): No longer static.
359 * eval.c (Ffetch_bytecode): No longer static.
360 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
361 * doc.c (Fdocumentation_property, Fsnarf_documentation):
362 No longer static.
404dbd37
TT
363 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
364 static.
365 * dired.c (Ffile_attributes): No longer static.
366 * composite.c (Fcomposition_get_gstring): No longer static.
367 * callproc.c (Fgetenv_internal): No longer static.
368
369 * ccl.h: Remove EXFUNs.
370 * buffer.h: Remove EXFUNs.
371 * dispextern.h: Remove EXFUNs.
372 * intervals.h: Remove EXFUNs.
373 * fontset.h: Remove EXFUN.
374 * font.h: Remove EXFUNs.
375 * dosfns.c (system_process_attributes): Remove EXFUN.
376 * keymap.h: Remove EXFUNs.
377 * lisp.h: Remove EXFUNs.
378 * w32term.h: Remove EXFUNs.
379 * window.h: Remove EXFUNs.
380 * xsettings.h: Remove EXFUN.
381 * xterm.h: Remove EXFUN.
382
8e4fd1e1
GM
3832012-07-03 Glenn Morris <rgm@gnu.org>
384
385 * lisp.h (Frandom): Make it visible to C.
386 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
387 buffer for invisible buffers. (Bug#1229)
388
ca95b3eb
DA
3892012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
390
391 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
392 values which aren't power of 2.
393 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
394 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
395 accordingly.
396
7555c33f
SM
3972012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
398
399 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
400
401 * alloc.c (mark_object): Revert part of last patch to use `switch'.
402
d12e8f5a
DA
4032012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
404
405 * alloc.c (allocate_vector_block): Remove redundant
406 calls to mallopt if DOUG_LEA_MALLOC is defined.
407 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
408 avoid calls to mallopt if zero_vector is returned.
409
296094c3
DA
4102012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
411
412 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
413 is enabled, avoid dereferencing NULL current_sblock if
414 running undumped.
415
36429c89
DA
4162012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
417
418 Cleanup basic buffer management.
419 * buffer.h (struct buffer): Change layout to use generic vector
420 marking code. Fix some comments. Change type of 'clip_changed'
421 to bitfield. Remove unused #ifndef old.
422 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
423 (GET_OVERLAYS_AT): Fix indentation.
424 (for_each_per_buffer_object_at): New macro.
425 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
426 (Fbuffer_local_variables): Use it.
427 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
428 * alloc.c (allocate_buffer): Adjust to match new layout of
429 struct buffer. Fix comment.
430 (mark_overlay): New function.
431 (mark_buffer): Use it. Use mark_vectorlike to mark normal
432 Lisp area of struct buffer.
433 (mark_object): Use it. Adjust marking of misc objects
434 and related comments.
435
3b3e4cac
PE
4362012-07-02 Paul Eggert <eggert@cs.ucla.edu>
437
438 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
439 wrapper that is not needed because the wrapped code is a no-op (zero
440 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
441 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
442
cf5c0175
DA
4432012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
444
445 * alloc.c (mark_buffer): Simplify. Remove prototype.
446 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 447 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
448 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
449 redundant calls to mark_vectorlike for bool vectors.
450
ca26824c
GM
4512012-06-30 Glenn Morris <rgm@gnu.org>
452
2e4c5312
GM
453 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
454
ca26824c
GM
455 * epaths.in (PATH_SITELOADSEARCH): New.
456 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
457 This is rather than relying on --enable-locallisppath elements
458 having "site-lisp" in their names. (Bug#10208#25, 11658)
459
0d23c240
EZ
4602012-06-30 Eli Zaretskii <eliz@gnu.org>
461
c9240d7a
EZ
462 * w32proc.c (sys_select): Accept and ignore one more argument.
463
464 * w32.c (emacs_gnutls_pull): Call select with one more argument.
465
0d23c240 466 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 467 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
468
469 * sysdep.c: Don't include dos.h and dosfns.h.
470
471 * process.c (sys_select):
472 * msdos.c (sys_select): Accept one more argument and ignore it.
473
474 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
475 adapt data types and code to that.
476
477 * dosfns.c:
478 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
479 which clashes with the gnulib function of the same name.
480
af5a5a98
AS
4812012-06-30 Andreas Schwab <schwab@linux-m68k.org>
482
c5e4379c
AS
483 * font.c (font_style_to_value, font_style_symbolic)
484 (font_prop_validate_style): Add type checks for values in
485 font_style_table.
486
af5a5a98
AS
487 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
488 argument.
489 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
490 uses.
491
8d38f461
EZ
4922012-06-29 Eli Zaretskii <eliz@gnu.org>
493
2e5a6631
EZ
494 * xdisp.c (try_window_id): Undo last change.
495
8d38f461
EZ
496 * w32.c (getwd): Adjust commentary about startup_dir.
497 (init_environment): Always call sys_access, even in non-MSVC
498 builds. Don't chdir to the directory of the Emacs executable.
499 This undoes code from 1997 which was justified by the need to
500 "avoid conflicts when removing and renaming directories". But its
501 downside was that every relative file name was being interpreted
502 relative to the directory of the Emacs executable, which can never
503 be TRT. In particular, it broke sys_access when called with
504 relative file names.
505 (sys_access): Map GetLastError to errno.
506
2af3565e
DA
5072012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
508
509 * window.h (struct window): Change type of 'fringes_outside_margins'
510 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 511 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
512 Adjust comment.
513 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
514 to ptrdiff_t.
515
c8d3a25c 5162012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 517
c8d3a25c
GM
518 * gnutls.c (emacs_gnutls_handshake):
519 Add QUIT to make the loop interruptible.
57570cd3 520
c8d3a25c 5212012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 522
c8d3a25c
GM
523 * charset.c (init_charset): Make lack of etc/charsets fatal.
524
3e984ee8
DA
5252012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
526
527 * editfns.c (region_limit): Fix type mismatch.
528
ef884f23
DA
5292012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
530
531 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
532 undefined. Convert from xassert to eassert.
533 * nsmenu.m: Convert from xassert to eassert.
534 * nsterm.m: Likewise.
535
7d7e0027
SM
5362012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
537
538 * editfns.c (region_limit): Clip to narrowing (bug#11770).
539
aa754e6a
PE
5402012-06-28 Paul Eggert <eggert@cs.ucla.edu>
541
542 Avoid integer overflow on scroll-left and scroll-right.
543 * window.c (HSCROLL_MAX): New macro.
544 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
545 overflow when requested scroll falls outside ptrdiff_t range.
546
80b00b08
DA
5472012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
548
549 * window.h (struct window): Change type of 'hscroll',
550 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
551 'last_modified' and 'last_overlay_modified' to EMACS_INT.
552 Adjust users accordingly.
553 * xdisp.c (try_cursor_movement): Replace type check with eassert.
554 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
555 from EMACS_INT to ptrdiff_t.
556 (make_window): Omit redundant initialization.
557
62b2bcf6
JB
5582012-06-28 Juanma Barranquero <lekktu@gmail.com>
559
560 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
561
45942c7d
DA
5622012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
563
564 * window.h (struct window): Change type of 'use_time' and
565 'sequence_number' from Lisp_Object to int.
566 * frame.c (make_frame): Adjust users accordingly.
567 * print.c (print_object): Likewise.
568 * window.c (select_window, Fwindow_use_time, make_parent_window)
569 (make_window): Likewise.
570
e509cfa6
DA
5712012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
572
573 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
574 enabled with --enable-checking=[all,glyphs] configure option.
575 Fix GLYPH_DEBUG usage assuming that it may be undefined,
576 adjust comments accordingly.
577 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
578 undefined, adjust comments accordingly.
579 * image.c: Likewise.
580 * scroll.c: Likewise.
581 * w32fns.c: Likewise.
582 * w32term.c: Likewise.
583 * xdisp.c: Likewise.
584 * xfaces.c: Likewise.
585 * xfns.c: Likewise.
586 * xterm.c: Likewise.
587
a54e2c05
DA
5882012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
589
590 Generalize run-time debugging checks.
591 * dispextern.h (XASSERTS): Remove.
592 * fontset.c (xassert): Remove.
593 Convert from xassert to eassert.
594 * alloc.c: Convert from xassert to eassert.
595 * bidi.c: Likewise.
596 * dispnew.c: Likewise.
597 * fns.c: Likewise.
598 * fringe.c: Likewise.
599 * ftfont.c: Likewise.
600 * gtkutil.c: Likewise.
601 * image.c: Likewise.
602 * keyboard.c: Likewise.
603 * menu.c: Likewise.
604 * process.c: Likewise.
605 * scroll.c: Likewise.
606 * sound.c: Likewise.
607 * term.c: Likewise.
608 * w32console.c: Likewise.
609 * w32fns.c: Likewise.
610 * w32term.c: Likewise.
611 * window.c: Likewise.
612 * xdisp.c: Likewise.
613 * xfaces.c: Likewise.
614 * xfns.c: Likewise.
615 * xselect.c: Likewise.
616 * xterm.c: Likewise.
617
1ec4b7b2
SM
6182012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
619
620 * fns.c (maybe_resize_hash_table): Output message when growing the
621 purify-hashtable.
622
2014308a
DA
6232012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
624
625 * alloc.c (allocate_string_data): Remove dead code.
626 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
627 avoid GCC warning about unused macro.
628
246155eb
DA
6292012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
630
631 * alloc.c (allocate_string): Omit intervals initialization.
632 * alloc.c (make_uninit_multibyte_string): Initialize intervals
633 as in make_pure_string and make_pure_c_string.
634
43184b7b
DA
6352012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
636
d209e2fb 637 * alloc.c (allocate_string): Fix last change.
43184b7b 638
3fe6dd74
DA
6392012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
640
d209e2fb 641 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
642 to memset, add explicit initialization where appropriate.
643
1ba6038a
GM
6442012-06-27 Glenn Morris <rgm@gnu.org>
645
646 * lisp.mk (lisp): Remove paths.elc.
647
c89926a5
CY
6482012-06-27 Chong Yidong <cyd@gnu.org>
649
650 * doc.c (Fsubstitute_command_keys): Fix punctuation.
651
ed6b3510
JW
6522012-06-26 John Wiegley <johnw@newartisans.com>
653
1ec4b7b2 654 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
655 on Mac OS X Lion: __mod_init_func and __mod_term_func.
656
ed6b3510
JW
657 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
658 when building with Clang.
659
8edd4a2b
SM
6602012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
661
662 * eval.c (Fapply): Allow calling it with a single argument.
663
f6f62d1b
EZ
6642012-06-26 Eli Zaretskii <eliz@gnu.org>
665
666 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
667 _stricmp and _strnicmp.
668 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
669
62efea5e
DA
6702012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
671
672 * alloc.c (allocate_window): Zero out non-Lisp part of newly
673 allocated window.
674 (allocate_process): Likewise for new process.
8edd4a2b 675 (allocate_terminal): Change to use offsetof.
62efea5e
DA
676 (allocate_frame): Likewise.
677 * frame.c (make_frame): Omit redundant initialization.
678 * window.c (make_parent_window): Use memset.
679 (make_window): Omit redundant initialization.
680 * process.c (make_process): Omit redundant initialization.
681 * terminal.c (create_terminal): Likewise.
682
42997f4d
DA
6832012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
684
685 * term.c (delete_tty): Remove redundant call to memset.
686
1130ecfc
DA
6872012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
688
689 * alloc.c: Remove build_string.
690 * lisp.h: Define build_string as static inline. This provides
691 a better opportunity to optimize away calls to strlen when the
692 function is called with compile-time constant argument.
693 * image.c (imagemagick_error): Convert to build_string.
694 * w32proc.c (sys_spawnve): Likewise.
695 * xterm.c (x_term_init): Likewise.
696
cf38a720
PE
6972012-06-26 Paul Eggert <eggert@cs.ucla.edu>
698
99027bdd
PE
699 Use sprintf return value instead of invoking strlen on result.
700 In the old days this wasn't portable, since some sprintf
701 implementations returned char *. But they died out years ago and
702 Emacs already assumes sprintf returns int.
703 Similarly for float_to_string.
704 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
705 * ccl.c (ccl_driver):
706 * character.c (string_escape_byte8):
707 * data.c (Fnumber_to_string):
708 * doprnt.c (doprnt):
709 * print.c (print_object):
710 * xdisp.c (message_dolog):
711 * xfns.c (syms_of_xfns):
712 Use sprintf or float_to_string result to avoid need to call strlen.
713 * data.c (Fnumber_to_string):
714 Use make_unibyte_string, since the string must be ASCII.
715 * lisp.h, print.c (float_to_string): Now returns int length.
716 * term.c (produce_glyphless_glyph):
717 Use sprintf result rather than recomputing it.
718
cf38a720
PE
719 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
720 * Makefile.in (ALL_CFLAGS):
721 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
722 * gmalloc.c, regex.c: Include <config.h> unconditionally.
723
3511c784
DA
7242012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
725
0a08eb21 726 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
727 strcasecmp if available.
728 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
729
fb7da12e
AS
7302012-06-25 Andreas Schwab <schwab@linux-m68k.org>
731
732 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
733 Avoid comma operator.
734 * menu.c (push_submenu_start, push_submenu_end)
735 (push_left_right_boundary, push_menu_pane): Likewise.
736 * msdos.c (dos_rawgetc): Likewise.
737
afa2ffd8
DA
7382012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
739
740 * xfns.c (xic_create_fontsetname): Remove redundant calls
741 to memset.
742
b3b4476b
PE
7432012-06-25 Paul Eggert <eggert@cs.ucla.edu>
744
4495ff38
PE
745 * gtkutil.c (get_utf8_string): Remove redundant assignment.
746 sprintf already null-terminates its output.
747
b3b4476b
PE
748 * xfns.c (x_window): Remove redundant cast.
749
b00876c9
DA
7502012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
751
752 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
753 `const char *' to `char *' to avoid compiler warning.
754
d188e26b
PE
7552012-06-24 Paul Eggert <eggert@cs.ucla.edu>
756
885d1d74
PE
757 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
758 instead of truncating it to 63 (admittedly a generous limit).
759
d188e26b
PE
760 * process.c: Fix spelling and caps in comments.
761
e2f560b1
DN
7622012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
763
e86db54b 764 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
765 * sysdep.c (setpgrp): Remove definition, not used in this file.
766
7583a3a1
JB
7672012-06-24 Juanma Barranquero <lekktu@gmail.com>
768
769 * makefile.w32-in: Update dependencies.
770
696056c2
EZ
7712012-06-24 Eli Zaretskii <eliz@gnu.org>
772
773 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
774 (SYSTIME_H): Add nt/inc/sys/time.h.
775
776 * systime.h [WINDOWSNT]: Include sys/time.h.
777
778 * s/ms-w32.h (struct timespec): Definition moved from
779 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
780
845ca893
PE
7812012-06-24 Paul Eggert <eggert@cs.ucla.edu>
782
783 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
784 * buffer.h (buffer_slot_type_mismatch):
785 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
786 * eval.c (unwind_to_catch):
787 * image.c (my_png_error, my_error_exit):
788 * keyboard.c (quit_throw_to_read_char, user_error)
789 (Fexit_recursive_edit, Fabort_recursive_edit):
790 * lisp.h (die, args_out_of_range, args_out_of_range_3)
791 (wrong_type_argument, buffer_overflow, __executable_start)
792 (memory_full, buffer_memory_full, string_overflow, Fthrow)
793 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
794 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
795 (fatal):
796 (child_setup) [!DOS_NT]:
797 * lread.c (end_of_file_error, invalid_syntax):
798 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
799 * puresize.h (pure_write_error):
800 * search.c (matcher_overflow):
801 * sound.c (sound_perror, alsa_sound_perror):
802 * sysdep.c, syssignal.h (croak):
803 * term.c (maybe_fatal, vfatal):
804 * textprop.c (text_read_only):
805 * undo.c (user_error):
806 * unexmacosx.c (unexec_error):
807 * xterm.c (x_ins_del_lines, x_delete_glyphs):
808 Use _Noreturn rather than NO_RETURN.
809 No need for separate decl merely because of _Noreturn.
810 * sound.c (sound_warning, parse_sound):
811 Remove unnecessary forward decls.
812
f1dd8073
PE
8132012-06-24 Paul Eggert <eggert@cs.ucla.edu>
814
815 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
816 * lisp.h (WAIT_READING_MAX): New macro.
817 * dispnew.c (Fsleep_for, sit_for):
818 * keyboard.c (kbd_buffer_get_event):
819 * process.c (Faccept_process_output):
820 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
821 This improves on the previous patch, which introduced a bug
822 when time_t is unsigned and as wide as intmax_t.
823 See <http://bugs.gnu.org/9000#51>.
824
b82c1755
EZ
8252012-06-23 Eli Zaretskii <eliz@gnu.org>
826
827 * dispnew.c (sit_for, Fsleep_for):
828 * keyboard.c (kbd_buffer_get_event):
829 * process.c (Faccept_process_output): Avoid compiler warnings when
830 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
831
ca300656
JB
8322012-06-23 Juanma Barranquero <lekktu@gmail.com>
833
049ec95b
JB
834 * makefile.w32-in: Update dependencies.
835
ca300656
JB
836 * w32.c (ltime): Add return type and declare static.
837 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
838
db7b8d06
PE
8392012-06-23 Paul Eggert <eggert@cs.ucla.edu>
840
841 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
842 Privately reported by Herbert J. Skuhra.
843 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
844 All uses changed.
845 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
846 not make_lisp_timeval, when the argument is of type EMACS_TIME.
847
0bd8297f
EZ
8482012-06-23 Eli Zaretskii <eliz@gnu.org>
849
96512555
EZ
850 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
851 last argument of make_unibyte_string.
852
0bd8297f
EZ
853 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
854 language ID in the event parameters.
855
856 * w32term.c (w32_read_socket): Put the new keyboard codepage into
857 event.code, not the obscure "character set ID".
858
63def6b6
CY
8592012-06-23 Chong Yidong <cyd@gnu.org>
860
861 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
862
e8a02204
EZ
8632012-06-23 Eli Zaretskii <eliz@gnu.org>
864
388cdec0
EZ
865 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
866 * w32.c (fdutimens): New function.
867
868 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
869
870 * s/ms-w32.h (pselect): Redirect to sys_select.
871
872 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
873
e8a02204
EZ
874 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
875 in the logic of incrementing and decrementing the value of
876 use_relocatable_buffers.
877
d054f3fb
PE
8782012-06-23 Paul Eggert <eggert@cs.ucla.edu>
879
880 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
881 Privately reported by Herbert J. Skuhra.
882 [__FreeBSD__]: Remove "*/" typo after "#include".
883 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
884 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
885 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
886 Don't assume EMACS_TIME and struct timeval are the same type.
887
d35af63c
PE
8882012-06-22 Paul Eggert <eggert@cs.ucla.edu>
889
890 Support higher-resolution time stamps (Bug#9000).
891 The time stamps are only nanosecond-resolution at the C level,
892 since that's the best that any real-world system supports now.
893 But they are picosecond-resolution at the Lisp level, as that's
894 easy, and leaves room for future OS improvements.
895
896 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
897 (LIBES): Use it.
898
899 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
900 Don't get current time unless it's needed.
901
902 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
903 now provides it if it's absent.
904 (start_atimer): Port to higher-res time stamps.
905 Check for time stamp overflow. Don't get current time more
906 often than is needed.
907
908 * buffer.h (struct buffer): Buffer modtime now has high resolution.
909 Include systime.h, not time.h.
910 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
911
912 * dired.c: Include stat-time.h.
913 (Ffile-attributes): File times now have higher resolution.
914
915 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
916 (struct image): Timestamp now has higher resolution.
917
918 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
919 has at least microseconds now. All uses removed.
920 (update_frame, update_single_window, update_window, update_frame_1)
921 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
922
923 * editfns.c (time_overflow): Now extern.
924 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
925 (float-time, Fformat_time_string, Fcurrent_time_string)
926 (Fcurrent_time_zone): Accept and generate higher-resolution
927 time stamps.
928 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
929 (decode_time_components, lisp_seconds_argument): New functions.
930 (make_time): Now static.
931 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
932 Report an error if the time is invalid, rather than having the caller
933 do that.
934
935 * fileio.c: Include <stat-time.h>
936 (Fcopy_file): Copy higher-resolution time stamps.
937 Prefer to set the time stamp via a file descriptor if that works.
938 (Fset_file_times, Finsert_file_contents, Fwrite_region)
939 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
940 (Fvisited_file_modtime, Fset_visited_file_modtime):
941 Support higher-resolution time stamps.
942
943 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
944
945 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
946
947 * image.c (prepare_image_for_display, clear_image_cache)
948 (lookup_image): Port to higer-resolution time stamps.
949
950 * keyboard.c (start_polling, bind_polling_period):
951 Check for time stamp overflow.
952 (read_char, kbd_buffer_get_event, timer_start_idle)
953 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
954 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
955 Port to higher-resolution time stamps. Do not assume time_t is signed.
956 (decode_timer): New function. Timers are now vectors of length 9,
957 not 8, to accommodate the picosecond component.
958 (timer_check_2): Use it.
959
960 * nsterm.m (select_timeout, timeval_subtract): Remove.
961 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
962 as they're a bit more accurate and handle overflow better.
963 (ns_select): Change prototype to be compatible with pselect.
964 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
965 * nsterm.h (ns_select): Adjust prototype.
966
967 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
968 us-resolution time stamps.
969 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
970
971 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
972
973 * lisp.h (time_overflow): New decl.
974 (wait_reading_process_output): First arg is now intmax_t, not int,
975 to accommodate larger waits.
976
977 * process.h (struct Lisp_Process.read_output_delay):
978 Now counts nanoseconds, not microseconds.
979 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
980 EMACS_HAS_USECS.
981 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
982 (wait_reading_process_output):
983 Port to ns-resolution time stamps.
984 (Faccept_process_output, wait_reading_process_output):
985 Check for time stamp overflow. Do not assume time_t is signed.
986 (select_wrapper): Remove; we now use pselect.
987 (Fprocess_attributes): Now generates ns-resolution time stamps.
988
989 * sysdep.c: Include utimens.h. Don't include utime.h
990 or worry about struct utimbuf; gnulib does that for us now.
991 (gettimeofday): Remove; gnulib provides a substitute.
992 (make_timeval): New function.
993 (set_file_times): Now sets ns-resolution time stamps.
994 New arg FD; all uses changed.
995 (time_from_jiffies, ltime_from_jiffies, get_up_time)
996 (system_process_attributes):
997 Now returns ns-resolution time stamp. All uses changed.
998 Check for time stamp overflow.
999
1000 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1001 provides a substitute now.
1002
1003 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1004 since it guarantees struct timespec.
1005 (EMACS_TIME): Now struct timespec, so that we can support
1006 ns-resolution time stamps.
1007 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1008 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1009 (EMACS_USECS): Remove.
1010 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1011 so multiply the arg by 1000 before storing it.
1012 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1013 New macros.
1014 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1015 Port to ns-resolution time stamps.
1016 (EMACS_TIME_NEG_P): Remove; replaced by....
1017 (EMACS_TIME_SIGN): New macro.
1018 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1019 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1020 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1021 (make_timeval, make_lisp_time, decode_time_components): New decls.
1022 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1023 that it mishandled time_t overflow. You can't compare by subtracting!
1024 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1025 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1026
1027 * term.c: Include <sys/time.h>.
1028 (timeval_to_Time): New function, for proper overflow wraparound.
1029 (term_mouse_position, term_mouse_click): Use it.
1030
1031 * undo.c (record_first_change): Support higher-resolution time stamps
1032 in the undo buffer.
1033 (Fprimitive_undo): Use them when restoring time stamps.
1034
1035 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1036 (w32_get_internal_run_time):
1037 Port to higher-resolution Emacs time stamps.
1038 (ltime): Now accepts single 64-bit integer, as that's more convenient
1039 for callers.
1040
1041 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1042
1043 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1044 for compatibility with pselect. Support ns-resolution time stamps.
1045
1046 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1047
1048 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1049 Check for time stamp overflow, and support ns-resolution time stamps.
1050
1051 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1052 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1053 (timeval_subtract): Remove; no longer needed.
1054 (XTflash, XTring_bell, x_wait_for_event):
1055 Port to ns-resolution time stamps. Don't assume time_t is signed.
1056
b6a92dfe
CY
10572012-06-22 Chong Yidong <cyd@gnu.org>
1058
1059 * xdisp.c (x_consider_frame_title): Revert last change.
1060
d251c37c
EZ
10612012-06-22 Eli Zaretskii <eliz@gnu.org>
1062
1063 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1064 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1065 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1066 staticidx goes up to 1597 out of 1600 = 0x640.)
1067
f10deafb
PE
10682012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1069
1070 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1071 Otherwise, the umask might be mistakenly 0 while handling input signals.
1072
ec6de1e2
SM
10732012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1074
1075 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1076
28be1ada
DA
10772012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1078
1079 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1080 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1081 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1082 access to `contents' member of Lisp_Vector objects with AREF and ASET
1083 where appropriate.
1084
c6bf3022
CY
10852012-06-19 Chong Yidong <cyd@gnu.org>
1086
1087 * frame.c (delete_frame): When selecting a frame on a different
1088 text terminal, do not alter the terminal's top-frame.
1089
1090 * xdisp.c (format_mode_line_unwind_data): Record the target
1091 frame's selected window and its terminal's top-frame.
1092 (unwind_format_mode_line): Restore them.
1093 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1094 Callers changed.
1095 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1096 since tty frames can be explicitly named.
1097 (prepare_menu_bars): Likewise.
1098
1099 * term.c (Ftty_top_frame): New function.
1100
defd4196
PE
11012012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1102
1103 Port byte-code-meter to modern targets.
1104 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1105 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1106 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1107 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1108 (METER_1, METER_2): Simplify.
1109
1053a871
SM
11102012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1111
1112 * data.c (Fdefalias): Return `symbol' (bug#11686).
1113
b7e8d081
MR
11142012-06-18 Martin Rudalics <rudalics@gmx.at>
1115
1116 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1117 gets killed during executing of this function (Bug#11665).
1118 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1119 (Vkill_buffer_query_functions): In doc-string say that functions
1120 run by this hook should not change the current buffer.
1121
7ea2b339
PE
11222012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1123
1124 Fix recently-introduced process.c problems found by static checking.
1125 * process.c (write_queue_push, write_queue_pop, send_process):
1126 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1127 (write_queue_pop): Fix pointer signedness problem.
1128 (send_process): Remove unused local.
1129
96a313a1
CY
11302012-06-17 Chong Yidong <cyd@gnu.org>
1131
1132 * xdisp.c (redisplay_internal): No need to redisplay terminal
1133 frames that are not on top.
1134
20ca2e94
TN
11352012-06-17 Troels Nielsen <bn.troels@gmail.com>
1136
1137 * process.c (make_process): Initialize write_queue.
1138 (write_queue_push, write_queue_pop): New functions.
1139 (send_process): Use them to maintain correct ordering of process
1140 writes (Bug#10815).
1141
9a900ca9
PE
11422012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1143
310fbfa8
PE
1144 * lisp.h (eassert): Assume C89 or later.
1145 This removes the need for CHECK.
1146 (CHECK): Remove. Its comments about always evaluating its
1147 argument were confusing, as 'eassert' typically does not evaluate
1148 its argument.
1149
27bb1ca4
PE
1150 * coding.c (produce_chars): Use ptrdiff_t, not int.
1151
9a900ca9
PE
1152 * xterm.c (x_draw_underwave): Check for integer overflow.
1153 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1154
41b7f8bc 11552012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1156
1157 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1158 referenced (Bug#11583).
1159
9b0e3eba
AA
11602012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1161
1162 Implement wave-style variant of underlining.
1163 * dispextern.h (face_underline_type): New enum.
1164 (face): Add field for underline type.
1165 * nsterm.m (ns_draw_underwave): New function.
1166 (ns_draw_text_decoration): Use it.
1167 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1168 New functions.
1169 (x_draw_glyph_string): Use them.
1170 * xfaces.c (Qline, Qwave): New Lisp objects.
1171 (check_lface_attrs, merge_face_ref)
1053a871
SM
1172 (Finternal_set_lisp_face_attribute, realize_x_face):
1173 Handle wave-style underline face attributes.
9b0e3eba
AA
1174 * xterm.c (x_draw_underwave): New function.
1175 (x_draw_glyph_string): Use it.
1176
0fb52f11
JB
11772012-06-16 Juanma Barranquero <lekktu@gmail.com>
1178
1179 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1180 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1181 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1182 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1183 ($(BLD)/w32select.$(O)): Update dependencies.
1184
e5560ff7
AS
11852012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1186
1187 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1188 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1189 * character.c (_fetch_multibyte_char_p): Remove.
1190 * alloc.c: Include "character.h" before "buffer.h".
1191 * bidi.c: Likewise.
1192 * buffer.c: Likewise.
1193 * bytecode.c: Likewise.
1194 * callint.c: Likewise.
1195 * callproc.c: Likewise.
1196 * casefiddle.c: Likewise.
1197 * casetab.c: Likewise.
1198 * category.c: Likewise.
1199 * cmds.c: Likewise.
1200 * coding.c: Likewise.
1201 * composite.c: Likewise.
1202 * dired.c: Likewise.
1203 * dispnew.c: Likewise.
1204 * doc.c: Likewise.
1205 * dosfns.c: Likewise.
1206 * editfns.c: Likewise.
1207 * emacs.c: Likewise.
1208 * fileio.c: Likewise.
1209 * filelock.c: Likewise.
1210 * font.c: Likewise.
1211 * fontset.c: Likewise.
1212 * fringe.c: Likewise.
1213 * indent.c: Likewise.
1214 * insdel.c: Likewise.
1215 * intervals.c: Likewise.
1216 * keyboard.c: Likewise.
1217 * keymap.c: Likewise.
1218 * lread.c: Likewise.
1219 * macros.c: Likewise.
1220 * marker.c: Likewise.
1221 * minibuf.c: Likewise.
1222 * nsfns.m: Likewise.
1223 * nsmenu.m: Likewise.
1224 * print.c: Likewise.
1225 * process.c: Likewise.
1226 * regex.c: Likewise.
1227 * region-cache.c: Likewise.
1228 * search.c: Likewise.
1229 * syntax.c: Likewise.
1230 * term.c: Likewise.
1231 * textprop.c: Likewise.
1232 * undo.c: Likewise.
1233 * unexsol.c: Likewise.
1234 * w16select.c: Likewise.
1235 * w32fns.c: Likewise.
1236 * w32menu.c: Likewise.
1237 * window.c: Likewise.
1238 * xdisp.c: Likewise.
1239 * xfns.c: Likewise.
1240 * xmenu.c: Likewise.
1241 * xml.c: Likewise.
1242 * xselect.c: Likewise.
1243
2f07e6af
EZ
12442012-06-16 Eli Zaretskii <eliz@gnu.org>
1245
1053a871
SM
1246 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1247 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1248 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1249 row.
1250 (handle_face_prop): Use chunk-relative overlay string index when
1251 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1252 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1253 the rightmost. (Bug#11720)
2f07e6af 1254
29b83cec
AS
12552012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1256
1257 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1258 (CATEGORY_MEMBER): Enforce 1/0 value.
1259 * category.c (_temp_category_set): Remove.
1260
4c5501e9
EZ
12612012-06-16 Eli Zaretskii <eliz@gnu.org>
1262
1263 * window.c (Fdelete_other_windows_internal)
1264 (Fdelete_window_internal): Don't access frame's mouse highlight
1265 info of the initial frame. (Bug#11677)
1266
2b570124
PE
12672012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1268
e93864f9
PE
1269 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1270 Assume USE_2_TAGS_FOR_INTS.
1271 (xreload): Adjust $tagmask width to match recent lisp.h change.
1272
2b570124
PE
1273 Simplify lisp.h in minor ways that should not affect code.
1274 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1275 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1276 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1277 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1278 (INTTYPEBITS): New macro, for clarity.
1279 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1280 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1281 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1282 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1283 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1284
81755f69
JB
12852012-06-13 Juanma Barranquero <lekktu@gmail.com>
1286
1287 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1288
16192a57
GM
12892012-06-13 Glenn Morris <rgm@gnu.org>
1290
1291 * s/bsd-common.h (BSD4_3):
1292 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1293
646b5f55
AS
12942012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1295
1296 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1297 instead of union.
1298 (XLI, XIL): Define.
1053a871
SM
1299 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1300 Use them.
1301 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1302 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1303 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1304 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1305 * frame.c (delete_frame): Remove outdated comment.
1306 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1307 USE_LISP_UNION_TYPE.
1308 (Fw32_unregister_hot_key): Likewise.
1309 (Fw32_toggle_lock_key): Likewise.
1310 * w32menu.c (add_menu_item): Likewise.
1311 (w32_menu_display_help): Use XIL instead of checking
1312 USE_LISP_UNION_TYPE.
1313 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1314 (init_heap): Likewise.
1315 * w32term.c (w32_read_socket): Update comment.
1316
1d3823c9
GM
13172012-06-13 Glenn Morris <rgm@gnu.org>
1318
c62ff706
GM
1319 * s/usg5-4-common.h, src/s/unixware.h:
1320 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1321
1d3823c9
GM
1322 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1323
bfe3e0a2
PE
13242012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1325
1326 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1327 * alloc.c (make_number) [!defined make_number]:
1328 Remove, as lisp.h always defines this now.
1329 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1330 (roundup_size): Verify that it is a power of 2.
1331 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1332 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1333 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1334 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1335 USE_LSB_TAG now is always defined to be either 0 or 1.
1336 All uses changed.
1337 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1338 code works fine either way, and efficiency is not a concern here,
1339 as the union type is for debugging, not for production.
1340 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1341 Use an inline function on all platforms when using the union type,
1342 since this is simpler and 'static inline' can be used portably
1343 within Emacs now.
1344 (LISP_INITIALLY_ZERO): New macro.
1345 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1346 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1347
45fa9c0f
GM
13482012-06-12 Glenn Morris <rgm@gnu.org>
1349
b4492cba
GM
1350 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1351
1352 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1353
45fa9c0f
GM
1354 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1355 Move BROKEN_SIGIO to configure.
1356
1357 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1358 Move NO_TERMIO to configure.
1359
0e25d334
CY
13602012-06-12 Chong Yidong <cyd@gnu.org>
1361
1362 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1363 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1364 MagickExportImagePixels is undefined.
1365
43682bb6
PE
13662012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1367
1368 * image.c (imagemagick_load_image): Remove unused label.
1369
a9be7d2b
GM
13702012-06-11 Glenn Morris <rgm@gnu.org>
1371
1372 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1373 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1374 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1375 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1376
3017f87f
SM
13772012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1378
1379 * alloc.c (make_byte_code): New function.
1380 (Fmake_byte_code): Use it. Don't purify here.
1381 * lread.c (read1): Use it as well to avoid extra allocation.
1382
1b9b4cf4
CY
13832012-06-11 Chong Yidong <cyd@gnu.org>
1384
1385 * image.c (imagemagick_load_image): Implement transparency.
1386
95988fcf
AS
13872012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1388
1389 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1390 account for preceding backslashes. (Bug#11663)
1391
cd4eb164
CY
13922012-06-09 Chong Yidong <cyd@gnu.org>
1393
1394 * term.c: Support italics in capable terminals (Bug#9652).
1395 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1396 (turn_on_face): Output using TS_enter_italic_mode if available.
1397 Don't handle unused blinking and alt-charset cases.
1398 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1399 and tty_alt_charset_p cases.
1400 (tty_capable_p, init_tty): Support italics.
1401
1402 * termchar.h (struct tty_display_info): Add field for italics.
1403 Remove unused blink field.
1404
1405 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1406 Handle slant.
1407
1408 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1409 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1410 tty_alt_charset_p. Add tty_italic_p.
1411
ff88beb8
MA
14122012-06-09 Michael Albinus <michael.albinus@gmx.de>
1413
1414 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1415 dbus_type_is_basic if available.
1416 (xd_extract_signed, xd_extract_unsigned): Rename from
1417 extract_signed and extract_unsigned, respectively. Adapt callers.
1418
44286096
CY
14192012-06-09 Chong Yidong <cyd@gnu.org>
1420
1682701f
CY
1421 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1422
44286096
CY
1423 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1424 case (Bug#9752).
1425
d86feb17
PE
14262012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1427
1428 * xdisp.c (vmessage): Treat frame message as multibyte.
1429 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1430 would generate the diagnostic "Making \302\247 buffer-local while
1431 let-bound!".
1432
d5c20fe8
EZ
14332012-06-08 Eli Zaretskii <eliz@gnu.org>
1434
1435 * dispnew.c (showing_window_margins_p): Undo last change, which
1436 was done due to an inadvertent commit.
1437 (adjust_frame_glyphs_for_frame_redisplay): Do call
1438 showing_window_margins_p.
1439
513749ee
SM
14402012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1441
1442 * eval.c (Fmake_var_non_special): New primitive.
1443 (syms_of_eval): Defsubr it.
1444 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1445
d4a8f5c1
JB
14462012-06-08 Juanma Barranquero <lekktu@gmail.com>
1447
1448 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1449 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1450
8bbbc977
EZ
14512012-06-08 Eli Zaretskii <eliz@gnu.org>
1452
1453 * alloc.c (allocate_vectorlike): Fix last change.
1454
f3372c87
DA
14552012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1456
1457 Block-based vector allocation of small vectors.
1458 * lisp.h (struct vectorlike_header): New field `nbytes',
1459 adjust comment accordingly.
1460 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1461 to denote vector blocks. Adjust users (live_vector_p,
1462 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1463 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1464 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1465 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1466 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1467 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1468 (roundup_size): New constant.
1469 (struct vector_block): New data type.
1470 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1471 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1472 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1473 (sweep_vectors): New functions.
1474 (allocate_vectorlike): Return `zero_vector' as the only vector of
1475 0 items. Allocate new vector from block if vector size is less than
1476 or equal to VBLOCK_BYTES_MAX.
1477 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1478 (init_alloc_once): Add call to init_vectors.
1479
4f18a4ed
SM
14802012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1481
1482 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1483
86f158bc
PE
14842012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1485
1486 * doprnt.c (doprnt): Truncate multibyte char correctly.
1487 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1488 would mishandle a string argument "Xc" if X was a multibyte
1489 character of length 2: it would truncate after X's first byte
1490 rather than including all of X.
1491
c5cfcbe0
CY
14922012-06-06 Chong Yidong <cyd@gnu.org>
1493
1494 * buffer.c (word_wrap): Doc fix.
1495
c05cf390
PE
14962012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1497
1498 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1499
0c3461de
GM
15002012-06-03 Glenn Morris <rgm@gnu.org>
1501
1502 * xdisp.c (tool-bar-style): Doc fix.
1503
c71232db
UM
15042012-06-03 Ulrich Müller <ulm@gentoo.org>
1505
1506 * Makefile.in (PAXCTL): Define.
1507 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1508 binary via PaX flags if the paxctl utility is available.
1509 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1510 Restore PaX flags to their default. (Bug#11398)
1511
383f7350
CY
15122012-06-03 Chong Yidong <cyd@gnu.org>
1513
1514 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1515 buffer (Bug#11226).
1516
5f2c76c6
CY
15172012-06-03 Chong Yidong <cyd@gnu.org>
1518
1519 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1520 (note_mode_line_or_margin_highlight): If there is no help echo,
1521 use mode-line-default-help-echo. Handle the case where the mouse
1522 position is past the end of the mode line string.
1523
1524 * buffer.c (buffer_local_value_1): New function, split from
1525 Fbuffer_local_value; can return Qunbound.
1526 (Fbuffer_local_value): Use it.
1527 (Vmode_line_format): Docstring tweaks.
1528
773d47f6
PE
15292012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1530
1531 * sysdep.c (system_process_attributes): Improve comment.
1532
f2d6a3df
SM
15332012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1534
1535 * keyboard.c: Export real-this-command to Elisp.
1536 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1537 and DEFVAR it. Update all users.
1538
63810350
PE
15392012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1540
7bd5c1f4
PE
1541 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1542
63810350
PE
1543 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1544 Convert pctcpu and pctmem to Lisp float properly.
1545 Let the compiler fold better, as 100.0/0x8000 is exact.
1546
a2821611
AS
15472012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1548
1549 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1550 cons_block.
1551
5fceba1d
PE
15522012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1553
1554 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1555
c98ff5dd
DA
15562012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1557
1558 For a 'struct window', replace some Lisp_Object fields to
1559 bitfields where appropriate, remove unused fields.
1560 * window.h (struct window): Remove unused 'last_mark_x' and
1561 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1562 change it's type from Lisp_Object to bitfield.
1563 Change type of 'force_start', 'optional_new_start',
1564 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1565 fields from Lisp_Object to bitfield. Adjust users accordingly.
1566
ca34e0be
PE
15672012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1568
1569 Pacify gcc -Wdouble-precision when using Xaw.
1570 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1571 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1572 Use 'float' consistently, rather than 'float' in most places
1573 and 'double' in a couple of places.
1574
efc00ab1 15752012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1576
1577 * xdisp.c (handle_stop): Detect whether we have overlay strings
1578 loaded by testing it->current.overlay_string_index to be
1579 non-negative, instead of checking whether n_overlay_strings is
1580 positive. (Bug#11587)
1581
efc00ab1 15822012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1583
1584 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1585
1586 * doc.c (Fsubstitute_command_keys): Doc fix.
1587
efc00ab1 15882012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1589
1590 * search.c (search_buffer): Remove calls to
1591 r_alloc_inhibit_buffer_relocation, as it is now called by
1592 maybe_unify_char, which was the cause of relocation of buffer text
1593 in bug#11519.
1594
efc00ab1 15952012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1596
1597 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1598 for the duration of call to load_charset, to avoid problems with
1599 callers of maybe_unify_char that access buffer text through C
1600 pointers.
1601
1602 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1603 decrement the inhibition flag, instead of just setting or
1604 resetting it.
1605
ba93a187
PE
16062012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1607
1608 Remove obsolete '#define static' cruft.
1609 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1610 This #undef was "temporary" in 2000; it is no longer needed
1611 now that '#define static' has gone away.
1612 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1613 (gray_bitmap_bits): Remove; no longer needed.
1614 All uses replaced with definiens.
1615 * xterm.c: Include "bitmaps/gray.xbm".
1616
9e4bf381
PE
16172012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1618
1619 Clean up __executable_start, monstartup when --enable-profiling.
1620 The following changes affect the code only when profiling.
1621 * dispnew.c (__executable_start): Rename from safe_bcopy.
1622 Define only on platforms that need it.
1623 * emacs.c: Include <sys/gmon.h> when profiling.
1624 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1625 (__executable_start): Remove decl, since lisp.h does it now.
1626 (safe_bcopy): Remove decl; no longer has that name.
1627 (main): Coalesce #if into single bit of code, for simplicity.
1628 Cast pointers to uintptr_t, since standard libraries want integers
1629 and not pointers.
1630 * lisp.h (__executable_start): New decl.
1631
32d72c2f
GM
16322012-05-31 Glenn Morris <rgm@gnu.org>
1633
1634 * image.c (Fimagemagick_types): Doc fix.
1635
baac5bc7
JM
16362012-05-30 Jim Meyering <meyering@redhat.com>
1637
1638 * callproc.c (Fcall_process_region): Include directory component
1639 in mkstemp error message (Bug#11586).
1640
72cb32cf
PE
16412012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1642
1643 * alloc.c, lisp.h (make_pure_vector): Now static.
1644
61b108cc
SM
16452012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1646
1647 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1648 Move to byte-run.el.
1649 (Fautoload): Do the hash-doc more carefully.
1650 * data.c (Fdefalias): Purify definition, except for keymaps.
1651 (Qdefun): Move from eval.c.
1652 * lisp.h (Qdefun): Remove.
1653 * lread.c (read1): Tiny simplification.
1654
471fe23d
TN
16552012-05-29 Troels Nielsen <bn.troels@gmail.com>
1656
934f3f58 1657 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1658 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1659 Bug#9642, but explicitly check that the buffer the overlay would
1660 be moved to is live and rearrange lines to make sure that errors
1661 will not put the overlay in an inconsistent state.
1662 (Fdelete_overlay): Cosmetics.
1663
85d0efd1
EZ
16642012-05-28 Eli Zaretskii <eliz@gnu.org>
1665
1666 * w32term.c (my_bring_window_to_top): New function.
1667 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1668 could be different from the original one.
1669 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1670 (Bug#11513)
1671
1672 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1673 by calling BringWindowToTop.
1674
1675 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1676 (WM_EMACS_END): Increase by one.
1677
da92a98c
PE
16782012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1679
1680 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1681 This avoids undefined behavior that might cause the eassert
1682 to not catch an out-of-range value.
1683
74d1f848
JB
16842012-05-28 Juanma Barranquero <lekktu@gmail.com>
1685
1686 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1687 Update dependencies.
1688
9e1a06fc
EZ
16892012-05-27 Eli Zaretskii <eliz@gnu.org>
1690
1691 * bidi.c (bidi_mirror_char): Fix last change.
1692
f3dd7312
AS
16932012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1694
1695 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1696 when referring to sectname field in printf format.
1697
81899c91
PE
16982012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1699
57b81a9f
PE
1700 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1701 Only r_alloc_inhibit_buffer_relocation needed to be added;
1702 the others were already declared.
1703
81899c91
PE
1704 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1705 before checking whether it's out of range. Put the check inside
1706 eassert. See
1707 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1708
33017faf 17092012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1710
1711 * callproc.c (Fcall_process): Restore a line that was accidentally
1712 commented out in the 2011-02-13 change (bug#11547).
1713
33017faf 17142012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1715
1716 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1717 defined on ralloc.c.
1718
1719 * buffer.c [REL_ALLOC]: Remove prototypes of
1720 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1721 they are now on lisp.h.
1722
1723 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1724
1725 * search.c (search_buffer): Use it to inhibit relocation of buffer
1726 text while re_search_2 is doing its job, because re_search_2 is
1727 passed C pointers to buffer text. (Bug#11519)
1728
23415acf
EZ
1729 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1730 Update value to 24.
1731
44e27368
EZ
1732 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1733 state after an additional call to move_it_in_display_line_to, keep
1734 the values of it->max_ascent and it->max_descent found for the
1735 entire line.
1736 (pos_visible_p): Revert the comparison against bottom_y to what it
1737 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1738 (Bug#11464)
1739
c1892f11
PE
17402012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1741
1742 Fix coding-related core dumps with gcc -ftrapv.
1743 The code was computing A - B, where A and B are pointers, and B is
1744 random garbage. This can lead to core dumps on platforms that
1745 have special pointer registers, and it also leads to core dumps on
1746 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1747 A - B only when B is initialized properly.
1748 * coding.c (coding_set_source, coding_set_destination): Return void.
1749 (coding_change_source, coding_change_destinations): New functions,
1750 with the old behaviors of coding_set_source and coding_set_destination.
1751 All callers that need an offset changed to use these new functions.
1752
eb7afdad
GM
17532012-05-26 Glenn Morris <rgm@gnu.org>
1754
1755 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1756
f12fdf02
EZ
17572012-05-26 Eli Zaretskii <eliz@gnu.org>
1758
53a63be6 1759 Extend mouse support on W32 text-mode console.
61b108cc
SM
1760 * xdisp.c (draw_row_with_mouse_face):
1761 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1762
eb3f6f01 1763 * w32console.c: Include window.h.
61b108cc
SM
1764 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1765 New functions.
eb3f6f01
EZ
1766 (initialize_w32_display): Initialize mouse-highlight data.
1767
53a63be6
EZ
1768 * w32inevt.c: Include termchar.h and window.h.
1769 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1770 moves, call note_mouse_highlight. If help_echo changed, call
1771 gen_help_event to produce help-echo message in the echo area.
1772 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1773 highlight info.
1774
4cfd81f6
PE
17752012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1776
1777 * lread.c (read1): Simplify slightly to avoid an overflow warning
1778 with GCC 4.7.0 on x86-64.
1779
4446092a
EZ
17802012-05-26 Eli Zaretskii <eliz@gnu.org>
1781
1782 * bidi.c (bidi_mirror_char): Revert last change: an int is
1783 definitely wide enough here.
1784
42b2a986 17852012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1786
42b2a986 1787 Fix integer width and related bugs (Bug#9874).
eb106a49 1788 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1789 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1790 (string_bytes, check_sblock, allocate_string_data):
1791 (compact_small_strings, Fmake_bool_vector, make_string)
1792 (make_unibyte_string, make_multibyte_string)
1793 (make_string_from_bytes, make_specified_string)
1794 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1795 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1796 (mark_vectorlike):
1797 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1798 (allocate_pseudovector):
1799 Use int, not EMACS_INT, where int is wide enough.
1800 (inhibit_garbage_collection, Fgarbage_collect):
1801 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1802 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1803 int might not be wide enough.
1804 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1805 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1806 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1807 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1808 (bidi_level_of_next_char, bidi_move_to_visually_next):
1809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1810 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1811 (Fkill_buffer, Fset_buffer_major_mode)
1812 (advance_to_char_boundary, Fbuffer_swap_text)
1813 (Fset_buffer_multibyte, overlays_at, overlays_in)
1814 (overlay_touches_p, struct sortvec, record_overlay_string)
1815 (overlay_strings, recenter_overlay_lists)
1816 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1817 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1818 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1819 (Foverlay_recenter, last_overlay_modification_hooks_used)
1820 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1822 (validate_region): Omit unnecessary test for b <= e,
1823 since that's guaranteed by the previous test.
d311d28c
PE
1824 (adjust_overlays_for_delete): Avoid pos + length overflow.
1825 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1826 (report_overlay_modification):
1827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1828 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1829 Omit pointer cast, which isn't needed anyway, and doesn't work
1830 after the EMACS_INT -> ptrdiff_t change.
02481186 1831 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1832 * buffer.h: Adjust decls to match defn changes elsewhere.
1833 (struct buffer_text, struct buffer):
1834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1835 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1836 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1837 not int, to avoid needless 32-bit limit on 64-bit hosts.
1838 (exec_byte_code): Use tighter memory-full test, one that checks
1839 for alloca overflow. Don't compute the address of the object just
1840 before an array, as that's not portable. Use EMACS_INT, not
1841 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1842 * callint.c (Fcall_interactively):
1843 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1844 * callproc.c (call_process_kill, Fcall_process):
1845 Don't assume pid_t fits into an Emacs fixnum.
1846 (call_process_cleanup, Fcall_process, child_setup):
1847 Don't assume pid_t fits into int.
1848 (call_process_cleanup, Fcall_process, delete_temp_file)
1849 (Fcall_process_region):
1850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1851 (Fcall_process): Simplify handling of volatile integers.
1852 Use int, not EMACS_INT, where int will do.
1853 * casefiddle.c (casify_object, casify_region, operate_on_word)
1854 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1855 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1856 (casify_object): Avoid integer overflow when overallocating buffer.
1857 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1858 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1859 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1860 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1861 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1862 integers are now checked earlier. All uses replaced with XINT.
1863 (ccl_driver):
1864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1865 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1866 (ccl_driver, Fregister_code_conversion_map):
1867 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1868 (resolve_symbol_ccl_program): Check that vector header is in range.
1869 Always copy the vector, so that we can check its contents reliably
1870 now rather than having to recheck each instruction as it's being
1871 executed. Check that vector words fit in 'int'.
1872 (ccl_get_compiled_code, Fregister_ccl_program)
1873 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1874 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1875 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1876 contents are in range.
1877 (Fccl_execute_on_string): Check that status is in range.
1878 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1879 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1880 Accept and return EMACS_INT, not int, because callers can pass values
1881 out of 'int' range.
1882 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1883 (multibyte_chars_in_text, parse_str_as_multibyte)
1884 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1885 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1886 (string_escape_byte8, Fget_byte):
1887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1888 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1889 avoid mishandling large integers.
1890 * character.h: Adjust decls to match defn changes elsewhere.
1891 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1892 (Ffind_charset_region):
1893 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1894 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1895 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1896 Don't assume fixnum fits in int.
d311d28c
PE
1897 (load_charset_map_from_vector, Fmap_charset_chars):
1898 Remove now-unnecessary CHECK_NATNUMs.
1899 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1900 Don't rely on undefined behavior with signed left shift overflow.
1901 Don't assume unsigned int fits into fixnum, or that fixnum fits
1902 into unsigned int. Don't require max_code to be a valid fixnum;
1903 that's not true for gb10830 4-byte on a 32-bit host. Allow
1904 invalid_code to be a cons, for the same reason. Require code_offset
1905 to be a character. Avoid int overflow if max_char is close
1906 to INT_MAX.
1907 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1908 this is intended anyway and avoids some undefined behavior.
1909 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1910 INDEX_TO_CODE_POINT, as that's what it expects.
1911 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1912 * charset.h (DECODE_CHAR): Return int, not unsigned;
1913 this is what was intended anyway, and it avoids undefined behavior.
1914 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1915 integer-overflow issues.
1916 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1917 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1918 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1919 * chartab.c (Fmake_char_table, Fset_char_table_range)
1920 (uniprop_get_decoder, uniprop_get_encoder):
1921 Don't assume fixnum fits in int.
1922 * cmds.c (move_point): New function, that does the gist of
1923 Fforward_char and Fbackward_char, but does so while checking
1924 for integer overflow more accurately.
c96e5d6a 1925 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1926 (Fforward_line, Fend_of_line, internal_self_insert)
1927 (internal_self_insert):
1928 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1929 Fix a FIXME, by checking for integer overflow when calculating
1930 target_clm and actual_clm.
1931 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1932 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1933 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1934 (coding_alloc_by_making_gap, alloc_destination)
1935 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1936 (encode_coding_utf_16, detect_coding_emacs_mule)
1937 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1938 (detect_coding_iso_2022, decode_coding_iso_2022)
1939 (encode_invocation_designation, encode_designation_at_bol)
1940 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1941 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1942 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1943 (encode_coding_ccl, encode_coding_raw_text)
1944 (detect_coding_charset, decode_coding_charset)
1945 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1946 (produce_composition, produce_charset, produce_annotation)
1947 (decode_coding, handle_composition_annotation)
1948 (handle_charset_annotation, consume_chars, decode_coding_gap)
1949 (decode_coding_object, encode_coding_object, detect_coding_system)
1950 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1951 (code_convert_region, code_convert_string)
8f50130c
PE
1952 (Fdefine_coding_system_internal)
1953 (coding_set_source, coding_set_destination):
d311d28c
PE
1954 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1955 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1956 (Fdefine_coding_system_internal):
1957 Don't assume fixnums fit in int.
1958 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1959 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1960 (Funencodable_char_position, Fcheck_coding_systems_region)
1961 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1962 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1963 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1964 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1965 Don't access memory outside of the args array.
d311d28c 1966 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1967 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1968 result of ENCODE_CHAR.
d311d28c
PE
1969 * coding.h: Adjust decls to match defn changes elsewhere.
1970 (struct coding_system):
1971 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1972 * composite.c (get_composition_id, find_composition)
1973 (run_composition_function, update_compositions)
1974 (compose_text, composition_gstring_put_cache)
1975 (composition_gstring_p, composition_gstring_width)
1976 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1977 (composition_compute_stop_pos, composition_reseat_it)
1978 (composition_update_it, struct position_record)
1979 (find_automatic_composition, composition_adjust_point)
1980 (Fcomposition_get_gstring, Ffind_composition_internal):
1981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1982 (update_compositions):
1983 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1984 * composite.h: Adjust decls to match defn changes elsewhere.
1985 (struct composition):
1986 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1987 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1988 Do not attempt to compute the address of the object just before a
1989 buffer; this is not portable.
1990 (Faref, Faset):
1991 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1992 (Faset): Use int, not EMACS_INT, where int is wide enough.
1993 (Fstring_to_number): Don't assume fixnums fit in int.
1994 (Frem): Don't assume arg is nonnegative.
1995 * dbusbind.c (xd_append_arg): Check for integers out of range.
1996 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1997 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1998 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1999 (xd_get_connection_references): Return ptrdiff_t, not int.
2000 All uses changed.
2001 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2002 (xd_read_message_1):
2003 Use int, not unsigned, where the dbus API uses int.
2004 (Fdbus_message_internal): Don't overflow mtype.
2005 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2006 * dired.c (directory_files_internal, file_name_completion, scmp)
2007 (file_name_completion_stat):
2008 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2009 (file_name_completion): Don't overflow matchcount.
2010 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2011 * dispextern.h: Adjust decls to match defn changes elsewhere.
2012 (struct text_pos, struct glyph, struct bidi_saved_info)
2013 (struct bidi_string_data, struct bidi_it, struct composition_it)
2014 (struct it):
2015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2016 (struct display_pos, struct composition_it, struct it):
2017 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2018 * dispnew.c (increment_matrix_positions)
2019 (increment_row_positions, mode_line_string)
2020 (marginal_area_string):
2021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2022 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2024 (duration_to_sec_usec): New function, to check for overflow better.
2025 (Fsleep_for, sit_for): Use it.
2026 * doc.c (get_doc_string, store_function_docstring):
2027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2028 (get_doc_string, Fsnarf_documentation):
2029 Use int, not EMACS_INT, where int is wide enough.
2030 (get_doc_string):
2031 Use SAFE_ALLOCA, not alloca.
2032 Check for overflow when converting EMACS_INT to off_t.
2033 * doprnt.c (doprnt):
2034 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2035 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2036 Don't assume uid_t fits into fixnum.
2037 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2038 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2039 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2040 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2041 (general_insert_function)
2042 (Finsert_char, make_buffer_string, make_buffer_string_both)
2043 (update_buffer_properties, Fbuffer_substring)
2044 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2045 (Fsubst_char_in_region, check_translation)
2046 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2047 (transpose_markers, Ftranspose_regions):
2048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2049 (clip_to_bounds): Move to lisp.h as an inline function).
2050 (Fconstrain_to_field): Don't assume integers are nonnegative.
2051 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2052 (Fsubst_char_in_region, Fsave_restriction):
2053 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2054 (Femacs_pid): Don't assume pid_t fits into fixnum.
2055 (lo_time): Use int, not EMACS_INT, when int suffices.
2056 (lisp_time_argument): Check for usec out of range.
2057 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2058 (Fuser_login_name, Fuser_full_name): Signal an error
2059 if a uid argument is out of range, rather than relying on
2060 undefined behavior.
c8d5c857
PE
2061 (Fformat_time_string): Remove now-unnecessary check.
2062 lisp_time_argument checks for out-of-range usec now.
243e0530 2063 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2064 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2065 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2066 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2067 (init_cmdargs, Fdump_emacs):
2068 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2069 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2070 the bottom (typically) 32 bits of the fixnum.
2071 * eval.c (specpdl_size, call_debugger):
2072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2073 (when_entered_debugger, Fbacktrace_debug):
2074 Don't assume fixnum can fit in int.
2075 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2076 the object just before a buffer; this is not portable.
2077 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2078 (grow_specpdl, unbind_to):
2079 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2080 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2081 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2082 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2083 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2084 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2085 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2086 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2087 (a_write, e_write):
2088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2089 (Fcopy_file, non_regular_nbytes, read_non_regular)
2090 (Finsert_file_contents):
2091 Use int, not EMACS_INT, where int is wide enough.
2092 (READ_BUF_SIZE): Verify that it fits in int.
2093 (Finsert_file_contents): Check that counts are in proper range,
2094 rather than assuming fixnums fit into ptrdiff_t etc.
2095 Don't assume fixnums fit into int.
125b3835 2096 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2097 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2098 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2099 (string_char_to_byte, string_byte_to_char)
2100 (string_make_multibyte, string_to_multibyte)
2101 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2102 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2103 (substring_both, Fdelete, internal_equal, Ffillarray)
2104 (Fclear_string, mapcar1)
2105 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2106 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2107 (larger_vector, make_hash_table, maybe_resize_hash_table)
2108 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2109 (Fmaphash, secure_hash):
2110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2111 (concat): Check for string index and length overflow.
2112 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2113 (Frequire):
2114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2115 (larger_vector): New API (vec, incr_min, size_max) replaces old
2116 one (vec, new_size, init). This catches size overflow.
2117 INIT was removed because it was always Qnil.
2118 All callers changed.
2119 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2120 the upper bound on a hash table index size.
2121 (make_hash_table, maybe_resize_hash_table): Use it.
2122 (secure_hash): Computer start_byte and end_byte only after
2123 they're known to be in ptrdiff_t range.
2124 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2125 (Ffont_get_glyphs, Ffont_at):
2126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2127 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2128 (Flist_fonts, Fopen_font):
2129 Don't assume fixnum can fit in int.
2130 (check_gstring): Don't assume index can fit in int.
2131 (font_match_p): Check that fixnum is a character, not a nonnegative
2132 fixnum, since the later code needs to stuff it into an int.
2133 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2134 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2135 conversion overflow issues.
2136 (Fopen_font): Check for integer out of range.
2137 (Ffont_get_glyphs): Don't assume index can fit in int.
2138 * font.h: Adjust decls to match defn changes elsewhere.
2139 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2140 integer overflow.
2141 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2142 printmax_t, where ptrdiff_t is wide enough.
2143 (Finternal_char_font):
2144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2145 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2146 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2147 (Fset_frame_position, x_set_frame_parameters)
2148 (x_set_line_spacing, x_set_border_width)
2149 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2150 Check that fixnums are in proper range for system types.
2151 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2153 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2154 Use SAFE_ALLOCA_LISP, not alloca.
2155 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2156 intptr_t is wide enough.
2157 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2158 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2159 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2160 Check for fixnum out of range.
2161 * ftfont.c (ftfont_list): Don't assume index fits in int.
2162 Check that fixnums are in proper range for system types.
2163 (ftfont_shape_by_flt):
2164 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2165 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2167 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2168 Check that fixnums are in proper range for system types.
2169 * gnutls.h: Adjust decls to match defn changes elsewhere.
2170 * gtkutil.c (xg_dialog_run):
2171 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2172 (update_frame_tool_bar):
2173 Check that fixnums are in proper range for system types.
2174 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2175 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2176 * indent.c (last_known_column, last_known_column_point):
2177 (current_column_bol_cache):
2178 (skip_invisible, current_column, check_display_width):
2179 (check_display_width, scan_for_column, current_column_1)
2180 (Findent_to, Fcurrent_indentation, position_indentation)
2181 (indented_beyond_p, Fmove_to_column, compute_motion):
2182 (Fcompute_motion, Fvertical_motion):
2183 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2184 (last_known_column_modified): Use EMACS_INT, not int.
2185 (check_display_width):
2186 (Fcompute_motion):
2187 Check that fixnums and floats are in proper range for system types.
2188 (compute_motion): Don't assume index or fixnum fits in int.
2189 (compute_motion, Fcompute_motion):
2190 Use int, not EMACS_INT, when it is wide enough.
2191 (vmotion): Omit local var start_hpos that is always 0; that way
2192 we don't need to worry about overflow in expressions involving it.
2193 * indent.h: Adjust decls to match defn changes elsewhere.
2194 (struct position):
2195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2196 Use int, not EMACS_INT, where int is wide enough.
2197 Remove unused members ovstring_chars_done and tab_offset;
2198 all uses removed.
2199 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2200 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2201 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2202 (make_gap, copy_text, insert, insert_and_inherit)
2203 (insert_before_markers, insert_before_markers_and_inherit)
2204 (insert_1, count_combining_before, count_combining_after)
2205 (insert_1_both, insert_from_string)
2206 (insert_from_string_before_markers, insert_from_string_1)
2207 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2208 (adjust_after_replace, adjust_after_insert, replace_range)
2209 (replace_range_2, del_range, del_range_1, del_range_byte)
2210 (del_range_both, del_range_2, modify_region)
2211 (prepare_to_modify_buffer, signal_before_change)
2212 (signal_after_change, Fcombine_after_change_execute):
2213 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2214 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2215 (balance_an_interval, split_interval_right, split_interval_left)
2216 (find_interval, next_interval, update_interval)
2217 (adjust_intervals_for_insertion, delete_node, delete_interval)
2218 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2219 (static_offset_intervals, offset_intervals)
2220 (merge_interval_right, merge_interval_left, make_new_interval)
2221 (graft_intervals_into_buffer, temp_set_point_both)
2222 (temp_set_point, set_point, adjust_for_invis_intang)
2223 (set_point_both, move_if_not_intangible, get_property_and_range)
2224 (get_local_map, copy_intervals, copy_intervals_to_string)
2225 (compare_string_intervals, set_intervals_multibyte_1):
2226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2227 * intervals.h: Adjust decls to match defn changes elsewhere.
2228 (struct interval):
2229 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2230 * keyboard.c (this_command_key_count, this_single_command_key_start)
2231 (before_command_key_count, before_command_echo_length, echo_now)
2232 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2233 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2234 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2235 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2236 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2237 (last_non_minibuf_size, last_point_position, echo_truncate)
2238 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2239 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2240 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2241 (stuff_buffered_input):
2242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2243 (last_auto_save, command_loop_1, read_char):
2244 Use EMACS_INT, not int, to avoid integer overflow.
2245 (record_char): Avoid overflow in total_keys computation.
2246 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2247 * keyboard.h: Adjust decls to match defn changes elsewhere.
2248 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2249 (Fkey_description, Fdescribe_vector, Flookup_key):
2250 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2251 (click_position): New function, to check that positions are in range.
2252 (Fcurrent_active_maps):
2253 (describe_command):
2254 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2255 (Faccessible_keymaps, Fkey_description):
2256 (preferred_sequence_p):
2257 Don't assume fixnum can fit into int.
2258 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2259 Check for integer overflow in size calculations.
2260 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2261 avoid mishandling large integers.
2262 * lisp.h: Adjust decls to match defn changes elsewhere.
2263 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2264 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2265 (struct Lisp_Marker):
2266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2267 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2268 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2269 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2270 All callers changed.
2271 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2272 Assume the arg has valid form, since it always does.
2273 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2274 unsigned integer system type.
2275 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2276 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2278 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2279 (duration_to_sec_usec): New decl.
2280 * lread.c (read_from_string_index, read_from_string_index_byte)
2281 (read_from_string_limit, readchar, unreadchar, openp)
2282 (read_internal_start, read1, oblookup):
2283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2284 (Fload, readevalloop, Feval_buffer, Feval_region):
2285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2286 (openp): Check for out-of-range argument to 'access'.
2287 (read1): Use int, not EMACS_INT, where int is wide enough.
2288 Don't assume fixnum fits into int.
6efdadfd 2289 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2290 (read_filtered_event): Use duration_to_sec_usec
2291 to do proper overflow checking on durations.
d311d28c
PE
2292 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2293 in size calculation.
2294 (Fexecute_kbd_macro):
2295 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2296 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2297 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2298 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2299 (set_marker_both, set_marker_restricted_both, marker_position)
2300 (marker_byte_position, Fbuffer_has_markers_at):
2301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2302 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2303 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2304 It now merely ensures that the menu is large enough, without
2305 necessarily growing it, as this avoids some integer overflow issues.
2306 All callers changed.
2307 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2308 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2309 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2310 Use SAFE_ALLOCA_LISP, not alloca.
2311 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2312 to EMACS_INT. Check that fixnums are in proper range for system types.
2313 * minibuf.c (minibuf_prompt_width, string_to_object)
2314 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2315 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2316 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2317 (get_minibuffer, read_minibuf_unwind):
2318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2319 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2320 this simplifies overflow checking. All callers changed.
2321 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2322 (Ftest_completion):
2323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2324 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2325 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2326 Check that fixnums are in proper range for system types.
2327 (Fx_create_frame, Fx_show_tip):
2328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2329 * nsfont.m (ns_findfonts, nsfont_list_family):
2330 Don't assume fixnum fits in long.
2331 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2332 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2333 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2334 wide enough.
17fdb222 2335 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2336 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2337 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2338 (PRINTDECLARE, PRINTPREPARE):
2339 (strout, print_string):
2340 (print, print_preprocess, print_check_string_charset_prop)
2341 (print_object):
2342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2343 (PRINTDECLARE):
2344 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2346 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2347 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2348 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2349 (print_error_message): Use SAFE_ALLOCA, not alloca.
2350 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2351 (print_depth, new_backquote_output, print_number_index):
2352 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2353 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2354 (Fset_process_window_size, Fformat_network_address)
2355 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2356 (sigchld_handler):
d311d28c 2357 Check that fixnums are in proper range for system types.
d44287d4 2358 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2359 Check for process-ids out of pid_t range rather than relying on
2360 undefined behavior.
e4d81efc 2361 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2362 (Fformat_network_address, read_process_output, send_process)
2363 (Fprocess_send_region, status_notify):
2364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2365 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2366 (wait_reading_process_output, read_process_output, exec_sentinel):
2367 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2368 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2369 (Faccept_process_output): Use duration_to_sec_usec to do proper
2370 overflow checking on durations.
dde14581
PE
2371 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2372 Don't assume pid_t fits in int.
02481186
PE
2373 * process.h (struct Lisp_Process): Members tick and update_tick
2374 are now of type EMACS_INT, not int.
b62b53e8
PE
2375 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2376 configured --with-wide-int.
d311d28c
PE
2377 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2378 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2379 * search.c (looking_at_1, string_match_1):
2380 (fast_string_match, fast_c_string_match_ignore_case)
2381 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2382 (scan_newline, find_before_next_newline, search_command)
2383 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2384 (set_search_regs, wordify):
2385 (Freplace_match):
2386 (Fmatch_data):
2387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2388 (string_match_1, search_buffer, set_search_regs):
2389 (Fmatch_data):
2390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2391 (wordify): Check for overflow in size calculation.
2392 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2393 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2394 Check that fixnums are in proper range for system types.
2395 * sound.c (struct sound_device)
2396 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2398 (Fplay_sound_internal):
2399 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2400 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2401 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2402 (Fparse_partial_sexp):
2403 Don't assume fixnums can fit in int.
2404 (struct lisp_parse_state, find_start_pos, find_start_value)
2405 (find_start_value_byte, find_start_begv)
2406 (update_syntax_table, char_quoted, dec_bytepos)
2407 (find_defun_start, prev_char_comend_first, back_comment):
2408 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2409 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2411 (Finternal_describe_syntax_value): Check that match_lisp is a
2412 character, not an integer, since the code stuffs it into int.
2413 (scan_words, scan_sexps_forward):
2414 Check that fixnums are in proper range for system types.
2415 (Fforward_word):
2416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2417 (scan_sexps_forward):
2418 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2419 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2420 * syntax.h: Adjust decls to match defn changes elsewhere.
2421 (struct gl_state_s):
2422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2423 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2424 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2425 * sysdep.c (wait_for_termination_1, wait_for_termination)
2426 (interruptible_wait_for_termination, mkdir):
2427 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2428 (emacs_read, emacs_write):
2429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2430 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2431 and double all fit in int.
d311d28c
PE
2432 * term.c (set_tty_color_mode):
2433 Check that fixnums are in proper range for system types.
2434 * termhooks.h (struct input_event):
2435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2436 * textprop.c (validate_interval_range, interval_of)
2437 (Fadd_text_properties, set_text_properties_1)
2438 (Fremove_text_properties, Fremove_list_of_text_properties)
2439 (Ftext_property_any, Ftext_property_not_all)
2440 (copy_text_properties, text_property_list, extend_property_ranges)
2441 (verify_interval_modification):
2442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2443 (Fnext_single_char_property_change)
2444 (Fprevious_single_char_property_change):
2445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2446 (copy_text_properties):
2447 Check for integer overflow in index calculation.
d311d28c
PE
2448 * undo.c (last_boundary_position, record_point, record_insert)
2449 (record_delete, record_marker_adjustment, record_change)
2450 (record_property_change):
2451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2452 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2453 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2454 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2455 (Fx_hide_tip, Fx_file_dialog):
2456 * w32menu.c (set_frame_menubar):
2457 Use ptrdiff_t, not int, for consistency with rest of code.
2458 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2459 (select_window, Fdelete_other_windows_internal)
2460 (window_scroll_pixel_based, window_scroll_line_based)
2461 (Frecenter, Fset_window_configuration):
2462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2463 (Fset_window_hscroll, run_window_configuration_change_hook)
2464 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2465 (Fscroll_other_window, Frecenter):
d311d28c
PE
2466 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2467 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2468 Don't assume fixnum fits in int.
2469 (Fset_window_scroll_bars):
2470 Check that fixnums are in proper range for system types.
2471 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2472 (string_pos, c_string_pos, number_of_chars, init_iterator)
2473 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2474 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2475 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2476 (face_before_or_after_it_pos, handle_invisible_prop)
2477 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2478 (display_prop_intangible_p, string_buffer_position_lim)
2479 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2480 (get_overlay_strings_1, get_overlay_strings)
2481 (iterate_out_of_display_property, forward_to_next_line_start)
2482 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2483 (get_next_display_element, set_iterator_to_next)
2484 (get_visually_first_element, compute_stop_pos_backwards)
2485 (handle_stop_backwards, next_element_from_buffer)
2486 (move_it_in_display_line_to, move_it_in_display_line)
2487 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2488 (add_to_log, message_dolog, message_log_check_duplicate)
2489 (message2, message2_nolog, message3, message3_nolog
2490 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2491 (current_message_1, truncate_echo_area, truncate_message_1)
2492 (set_message, set_message_1, store_mode_line_noprop)
2493 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2494 (text_outside_line_unchanged_p, check_point_in_composition)
2495 (reconsider_clip_changes)
2496 (redisplay_internal, set_cursor_from_row, try_scrolling)
2497 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2498 (redisplay_window, find_last_unchanged_at_beg_row)
2499 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2500 (trailing_whitespace_p, find_row_edges, display_line)
2501 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2502 (display_mode_element, store_mode_line_string)
2503 (pint2str, pint2hrstr, decode_mode_spec)
2504 (display_count_lines, display_string, draw_glyphs)
2505 (x_produce_glyphs, x_insert_glyphs)
2506 (rows_from_pos_range, mouse_face_from_buffer_pos)
2507 (fast_find_string_pos, mouse_face_from_string_pos)
2508 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2510 (safe_call, init_from_display_pos, handle_fontified_prop)
2511 (handle_single_display_spec, load_overlay_strings)
2512 (with_echo_area_buffer, setup_echo_area_for_printing)
2513 (display_echo_area, echo_area_display)
2514 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2515 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2516 (redisplay_window, dump_glyph_row, display_mode_line)
2517 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2518 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2520 (handle_single_display_spec, build_desired_tool_bar_string)
2521 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2522 (get_specified_cursor_type):
2523 Check that fixnums are in proper range for system types.
2524 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2525 (Flookup_image_map):
2526 Don't assume fixnums fit in int.
2527 (compare_overlay_entries):
2528 Avoid mishandling comparisons due to subtraction overflow.
2529 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2530 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2531 (handle_tool_bar_click):
2532 Use int, not unsigned, since we prefer signed and the signedness
2533 doesn't matter here.
2534 (get_next_display_element, next_element_from_display_vector):
2535 Use int, not EMACS_INT, when int is wide enough.
2536 (start_hourglass): Use duration_to_sec_usec to do proper
2537 overflow checking on durations.
2538 * xfaces.c (Fbitmap_spec_p):
2539 Check that fixnums are in proper range for system types.
2540 (compare_fonts_by_sort_order):
2541 Avoid mishandling comparisons due to subtraction overflow.
2542 (Fx_family_fonts, realize_basic_faces):
2543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2544 (Fx_family_fonts):
2545 Don't assume fixnum fits in int.
2546 Use SAFE_ALLOCA_LISP, not alloca.
2547 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2548 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2549 (face_at_buffer_position, face_for_overlay_string)
2550 (face_at_string_position):
2551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2552 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2553 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2554 (Fx_show_tip):
2555 Check that fixnums are in proper range for system types.
2556 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2557 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2559 (Fx_change_window_property): Don't assume fixnums fit in int.
2560 * xfont.c (xfont_chars_supported):
2561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2562 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2563 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2564 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2565 * xml.c (parse_region):
2566 * xrdb.c (magic_file_p):
2567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2568 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2569 (x_get_local_selection, x_reply_selection_request)
2570 (x_handle_selection_request, wait_for_property_change):
2571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2572 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2573 short is wide enough.
2574 (x_send_client_event): Don't assume fixnum fits in int.
2575 * xterm.c (x_x_to_emacs_modifiers):
2576 Don't assume EMACS_INT overflows nicely into int.
2577 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2578 may come from Lisp.
2579 (handle_one_xevent): NATNUMP can eval its arg twice.
2580 (x_connection_closed):
2581 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2582 * xterm.h: Adjust decls to match defn changes elsewhere.
2583 (struct scroll_bar): Use struct vectorlike_header
2584 rather than rolling our own approximation.
2585 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2586
c6574eb5
GM
25872012-05-25 Glenn Morris <rgm@gnu.org>
2588
2589 * lisp.mk (lisp): Update for more files being compiled now.
2590
e8d32c7e
SM
25912012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2592
48def666
SM
2593 * lread.c: Remove `read_pure' which makes no difference.
2594 (read_pure): Remove var.
2595 (unreadpure): Remove function.
2596 (readevalloop): Don't call read_list with -1 flag.
2597 (read1, read_vector): Don't test read_pure any more.
2598 (read_list): Simplify.
2599
e8d32c7e
SM
2600 * fileio.c, character.h: Minor style tweaks.
2601
4b2addb7
DA
26022012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2603
2604 * window.h (clip_changed): Remove useless declaration.
2605
584461b2
JB
26062012-05-22 Juanma Barranquero <lekktu@gmail.com>
2607
2608 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2609 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2610
34374650
PE
26112012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2612
2613 Remove src/m/*.
2614 This directory predates autoconf and is no longer needed nowadays.
2615 Move its few remaining bits of functionality to where they're needed.
2616 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2617 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2618 * m/template.h: Remove.
2619 * Makefile.in (M_FILE): Remove. All uses removed.
2620 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2621 * lisp.h (USE_LSB_TAG):
2622 * mem-limits.h (EXCEEDS_LISP_PTR):
2623 Use VAL_MAX, not VALBITS, in #if.
2624 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2625 (EMACS_UINT): Define unconditionally now.
2626 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2627 (BITS_PER_EMACS_INT): New constants, replacing
2628 what used to be in config.h, but not useful in #if.
2629 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2630 define them any more.
2631 (VAL_MAX): New macro.
2632 (VALMASK): Use it.
2633 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2634 BITS_PER_EMACS_INT, in #if.
2635 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2636 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2637 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2638 * s/ms-w32.h (DATA_START):
2639 Move here from removed file m/intel386.h.
2640 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2641 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2642
261cb4bb
PE
26432012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2644
2645 Assume C89 or later.
2646 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2647 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2648 (xrealloc):
2649 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2650 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2651 * textprop.c, tparam.c (NULL): Remove.
2652 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2653 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2654 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2655 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2656 * xterm.c (input_signal_count): Assume volatile works.
2657
ff23cd9f
KB
26582012-05-21 Ken Brown <kbrown@cornell.edu>
2659
2660 * xgselect.c (xg_select): Fix first argument in call to 'select'
2661 (bug#11508).
2662
1b170bc6
KB
26632012-05-20 Ken Brown <kbrown@cornell.edu>
2664
2665 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2666 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2667
b2f4d39f
KB
26682012-05-19 Ken Brown <kbrown@cornell.edu>
2669
2670 * xfns.c (x_in_use): Remove `static' qualifier.
2671 * xterm.h (x_in_use): Declare.
2672 * xgselect.c: Include xterm.h.
2673 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2674 and `display_arg' (bug#9754).
2675
003fdae2
PE
26762012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2677
9232a6d9
PE
2678 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2679
003fdae2
PE
2680 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2681 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2682
784b56e2
EZ
26832012-05-18 Eli Zaretskii <eliz@gnu.org>
2684
2685 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2686
2687 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2688 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2689
2690 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2691 reference to image_cache->refcount.
2692 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2693
a0a79cde
JL
26942012-05-17 Juri Linkov <juri@jurta.org>
2695
2696 * search.c (Fword_search_regexp, Fword_search_backward)
2697 (Fword_search_forward, Fword_search_backward_lax)
2698 (Fword_search_forward_lax): Move functions to isearch.el
2699 (bug#10145, bug#11381).
2700
b0572523
PE
27012012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2702
2703 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2704
9660f5fc
SM
27052012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2706
2707 * lread.c (init_obarray): Declare Qt and Qnil as special.
2708
4374de83
GM
27092012-05-14 Glenn Morris <rgm@gnu.org>
2710
2711 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2712 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2713
dc44c39a
PE
27142012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2715
078c97cb
PE
2716 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2717
dc44c39a
PE
2718 * unexaix.c: Port to more-recent AIX compilers.
2719 (report_error, report_error_1, make_hdr, copy_sym)
2720 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2721 Make arguments const char *, not char *, to avoid violations of C
2722 standard and to fix some AIX warnings reported by Gilles Pion.
2723
e18afed7 27242012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2725
2726 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2727 already have overlays loaded.
2728 (handle_single_display_spec): Before returning without displaying
2729 fringe bitmap, synchronize the bidi iterator with the main display
2730 iterator, by calling iterate_out_of_display_property.
2731 (iterate_out_of_display_property): Detect buffer iteration by
2732 testing that it->string is a Lisp string.
2733 (get_next_display_element): When the current object is exhausted,
2734 and there's something on it->stack, call set_iterator_to_next to
2735 proceed with what's on the stack, instead of returning zero.
2736 (set_iterator_to_next): If called at the end of a Lisp string,
2737 proceed to consider_string_end without incrementing string
2738 position. Don't increment display vector index past the end of
2739 the display vector. (Bug#11417)
c8fb9dc6
EZ
2740 (pos_visible_p): Don't report a position visible when move_it_to
2741 stopped at the last line of window, which happens to be scanned
2742 backwards by the bidi iteration. (Bug#11464)
ac268e67 2743
e18afed7 27442012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2745
2746 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2747 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2748 are on a TTY, and thus unable to display on the fringes.
2749 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2750 so we need to signal to the caller that this is a "replacing"
2751 display spec. This fixes display when the spec is invalid or we
2752 are on a TTY.
2753
e18afed7 27542012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2755
2756 * unexaix.c (make_hdr): Fix typo in prototype.
2757 This bug broke the build on AIX. Problem reported by Gilles Pion.
2758
9d0a235a
MA
27592012-05-14 Michael Albinus <michael.albinus@gmx.de>
2760
2761 * keyboard.c (kbd_buffer_get_event): Read special events also in
2762 batch mode. (Bug#11415)
2763
9e6b06ed
GM
27642012-05-12 Glenn Morris <rgm@gnu.org>
2765
2766 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2767
c1a1d7a3
EZ
27682012-05-12 Eli Zaretskii <eliz@gnu.org>
2769
2770 * lisp.mk (lisp): Add newcomment.elc.
2771
3fe7cdc8
GM
27722012-05-12 Glenn Morris <rgm@gnu.org>
2773
2774 * Makefile.in (MKDIR_P): New, set by configure.
2775 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2776
53f7d2c0
PE
27772012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2778
2779 Remove unused function hourglass_started.
2780 * dispextern.h (hourglass_started):
2781 * w32fns.c (hourglass_started):
2782 * xdisp.c (hourglass_started): Remove.
2783
75aafb17
JB
27842012-05-10 Juanma Barranquero <lekktu@gmail.com>
2785
2786 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2787 Update dependencies.
2788
12959e8e
PE
27892012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2790
97107e2e
PE
2791 * xgselect.c (xg_select): Put maxfds+1 into a var.
2792 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2793
12959e8e
PE
2794 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2795
836d29b3
DA
27962012-05-10 Dave Abrahams <dave@boostpro.com>
2797
2798 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2799 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2800
5cb67954
MA
28012012-05-09 Michael Albinus <michael.albinus@gmx.de>
2802
2803 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2804 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2805 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2806 Initialize xd_registered_buses.
2807
3478ec45
PE
28082012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2809
b263a6b0
PE
2810 Untag more efficiently if USE_LSB_TAG.
2811 This is based on a proposal by YAMAMOTO Mitsuharu in
2812 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2813 For an admittedly artificial (nth 8000 longlist) benchmark on
2814 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2815 Emacs's overall text size by 1%.
2816 * lisp.h (XUNTAG): New macro.
2817 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2818 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2819 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2820 * eval.c (Fautoload):
2821 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2822 * frame.h (XFRAME): Use XUNTAG.
2823
3478ec45
PE
2824 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2825 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2826 Remove unportable assumptions about print widths of types like
2827 dbus_uint32_t.
2828 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2829 intptr_t when converting between pointer and integer, to avoid GCC
2830 warnings about wrong width.
2831
666b903b 28322012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2833
2834 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2835 stack for each reader_thread, instead of defaulting to 8MB
2836 determined by the linker. This avoids failures in creating
2837 subprocesses on Windows 7, see the discussion in this thread:
2838 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2839
b120cc17
JC
28402012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2841
2842 Fix up display of the *Minibuf-0* buffer in the mini window.
2843 * keyboard.c (read_char): Don't clear the echo area if there's no
2844 message to clear.
2845 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2846 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2847
9a4b36f8
MA
28482012-05-07 Michael Albinus <michael.albinus@gmx.de>
2849
2850 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2851 batch mode.
2852
e5f9458f
CY
28532012-05-06 Chong Yidong <cyd@gnu.org>
2854
2855 * lisp.mk (lisp): Update.
2856
eceeb5fc 28572012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2858
2859 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2860
71873e2b
SM
28612012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2862
2863 * data.c (PUT_ERROR): New macro.
2864 (syms_of_data): Use it. Add new error type `user-error'.
2865 * undo.c (user_error): New function.
2866 (Fprimitive_undo): Use it.
2867 * print.c (print_error_message): Adjust print style for `user-error'.
2868 * keyboard.c (user_error): New function.
2869 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2870
ab0fa4e4
PE
28712012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 Do not limit current-time-string to years 1000..9999.
2874 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2875 (Fcurrent_time_string): Support any year that is supported by the
2876 underlying localtime representation. Don't use asctime, as it
2877 has undefined behavior for years outside the range -999..9999.
2878
7ed806a7
PE
28792012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2880
2881 Fix race conditions involving setenv, gmtime, localtime, asctime.
2882 Without this fix, interrupts could mess up code that uses these
2883 nonreentrant functions, since setting TZ invalidates existing
2884 tm_zone or tzname values, and since most of these functions return
2885 pointers to static storage.
2886 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2887 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2888 Grow the critical sections to include not just invoking
2889 localtime/gmtime, but also accessing these functions' results
2890 including their tm_zone values if any, and any related TZ setting.
2891 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2892 so that the struct tm is saved in the critical section.
2893 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2894 motivated by the fact that memory allocation needs to be outside
2895 the critical section.
2896
0c16dfed
DA
28972012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2898
2899 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2900 with RESET_INTERVAL.
2901
2902 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2903 Remove duplicated buffer name initialization.
2904
3f83ace8
JM
29052012-05-02 Jim Meyering <jim@meyering.net>
2906
2907 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2908
c7b8541e
JM
2909 * xfns.c (x_window): Use xstrdup (Bug#11375).
2910
90207a15 29112012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2912
2913 * xdisp.c (pos_visible_p): If already at a newline from the
2914 display string before the 'while' loop, don't walk back the glyphs
2915 from it3.glyph_row. Solves assertion violation when the display
2916 string begins with a newline (egg.el). (Bug#11367)
2917
b593d6a9
AH
29182012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2919
2920 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2921 Move to simple.el.
2922
4737362e
GM
29232012-05-01 Glenn Morris <rgm@gnu.org>
2924
99cf43f9
GM
2925 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2926 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2927 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2928 All were removed before 23.1.
2929
9311dcff
GM
2930 * dispnew.c: Remove HAVE_LIBNCURSES test;
2931 it is always true on relevant platforms.
2932
4d5c6349
GM
2933 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2934 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2935
4737362e
GM
2936 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2937
74dd3a6b
AS
29382012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2939
2940 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2941 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2942 Remove.
2943
13c379ee
PE
29442012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2945
2946 Do not avoid creating empty evaporating overlays (Bug#9642).
2947 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2948 That is, do not delete an evaporating overlay if it becomes
2949 empty after its bounds are adjusted to fit within its buffer.
2950 This fix caused other problems, and I'm reverting it until we get
2951 to the bottom of them.
2952
a8e7d6d7 29532012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2954
2955 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2956
a8e7d6d7 29572012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2958
2959 * xdisp.c (pos_visible_p): If the window start position is beyond
2960 ZV, start the display from buffer beginning. Prevents assertion
2961 violation in init_iterator when the minibuffer window is scrolled
2962 via the scroll bar.
2963
2964 * window.c (window_scroll_pixel_based): Likewise.
2965
a8e7d6d7 29662012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2967
2968 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2969
a8e7d6d7 29702012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2971
2972 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2973 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2974
a8e7d6d7 29752012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2976
b593d6a9
AH
2977 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2978 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2979
1c6900d9
EZ
29802012-04-26 Eli Zaretskii <eliz@gnu.org>
2981
4c3fa1d9
EZ
2982 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2983 display element, check also the underlying string or buffer
2984 character. (Bug#11341)
2985
1c6900d9
EZ
2986 * w32menu.c: Include w32heap.h.
2987 (add_menu_item): If the call to AppendMenuW (via
2988 unicode_append_menu) fails, disable Unicode menus only if we are
2989 running on Windows 9X/Me.
2990
42bf8205
AS
29912012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2992
2993 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2994 (xgetint): Add missing shift for LSB tags.
2995
b1bac16e
MR
29962012-04-24 Martin Rudalics <rudalics@gmx.at>
2997
2998 * keyboard.c (read_char): Don't wipe echo area for select window
2999 events: These might get delayed via `mouse-autoselect-window'
3000 (Bug#11304).
3001
d69621cc
JB
30022012-04-24 Juanma Barranquero <lekktu@gmail.com>
3003
3004 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3005 manipulation of :loaded-from data.
3006
02fd101b
JB
30072012-04-23 Juanma Barranquero <lekktu@gmail.com>
3008
3009 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3010 now a cons (bug#11311).
3011
888bec30
PE
30122012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3013
89a438bd
PE
3014 Do not create empty overlays with the evaporate property (Bug#9642).
3015 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3016 if it becomes empty after its bounds are adjusted to fit within
3017 its buffer. Without this fix, in a nonempty buffer (let ((o
3018 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3019 yields an empty overlay that has the evaporate property, which is
3020 not supposed to happen.
3021
1068fe4d
PE
3022 Fix minor GTK3 problems found by static checking.
3023 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3024 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3025 (struct _EmacsFixedClass, emacs_fixed_get_type):
3026 Move decls here from emacsgtkfixed.h, since they needn't be public.
3027 (emacs_fixed_get_type): Now static.
3028 (emacs_fixed_class_init): Omit unused local.
3029 (emacs_fixed_child_type): Remove; unused.
3030 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3031 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3032 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3033 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3034 (EMACS_FIXED_GET_CLASS): Remove; unused.
3035 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3036
888bec30
PE
3037 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3038 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3039
de85e130
PE
30402012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3041
d0baac98 3042 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3043 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3044 (__malloc_size_t, __malloc_ptrdiff_t):
3045 Remove. All uses removed, replaced by the definiens if needed,
3046 since we can assume C89 or better now.
3047 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3048 (protect_malloc_state, align, get_contiguous_space)
3049 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3050 (malloc_atfork_handler_child, malloc_enable_thread)
3051 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3052 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3053 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3054 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3055 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3056 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3057 Define using prototypes, not old style.
3058 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3059 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3060 (align): Don't assume that signed integer overflow wraps around.
3061 Omit unused local var.
3062 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3063 (_free_internal_nolock, memalign, mallochook, reallochook):
3064 Omit no-longer-needed casts.
3065 (valloc): Use getpagesize, not __getpagesize.
3066 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3067 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3068
de85e130
PE
3069 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3070
dcbf5805
MA
30712012-04-22 Michael Albinus <michael.albinus@gmx.de>
3072
3073 Move functions from C to Lisp. Make non-blocking method calls
3074 the default. Implement further D-Bus standard interfaces.
3075
3076 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3077 (QCdbus_request_name_allow_replacement)
3078 (QCdbus_request_name_replace_existing)
3079 (QCdbus_request_name_do_not_queue)
3080 (QCdbus_request_name_reply_primary_owner)
3081 (QCdbus_request_name_reply_in_queue)
3082 (QCdbus_request_name_reply_exists)
3083 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3084 (QCdbus_registered_serial, QCdbus_registered_method)
3085 (QCdbus_registered_signal): New Lisp objects.
3086 (XD_DEBUG_MESSAGE): Use sizeof.
3087 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3088 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3089 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3090 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3091 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3092 (xd_signature, xd_append_arg): Allow float for integer types.
3093 (xd_get_connection_references): New function.
b593d6a9
AH
3094 (xd_get_connection_address): Rename from xd_initialize.
3095 Return cached address.
dcbf5805
MA
3096 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3097 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3098 level.
3099 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3100 Return number of refcounts.
dcbf5805
MA
3101 (Fdbus_get_unique_name): Make stronger parameter check.
3102 (Fdbus_message_internal): New defun.
3103 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3104 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3105 (Fdbus_send_signal, Fdbus_register_service)
3106 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3107 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3108 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3109 (Vdbus_compiled_version, Vdbus_runtime_version)
3110 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3111 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3112 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3113 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3114 Adapt docstring.
dcbf5805 3115
52828e02
PE
31162012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3117
da05bc4c
PE
3118 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3119 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3120 Do not assume ptrdiff_t is the same width as 'int'.
3121
52828e02
PE
3122 * alloc.c: Handle unusual debugging option combinations.
3123 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3124 since the two debugging options are incompatible.
3125 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3126 is defined.
3127 (mem_init, mem_insert, mem_insert_fixup):
3128 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3129 (NEED_MEM_INSERT): Remove; no longer needed.
3130
f01769f9
LL
31312012-04-22 Leo Liu <sdl.web@gmail.com>
3132
3133 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3134
5790543d
PE
31352012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3136
3137 * sysdep.c [__FreeBSD__]: Minor cleanups.
3138 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3139 Use Emacs indenting style more consistently. Avoid some casts.
3140 Use 'double' consistently rather than mixing 'float' and 'double'.
3141
b91b7e4d
EW
31422012-04-21 Eduard Wiebe <usenet@pusto.de>
3143
b593d6a9
AH
3144 * sysdep.c (list_system_processes, system_process_attributes):
3145 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3146
6114eb15
AS
31472012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3148
3149 * lisp.mk (lisp): Update.
3150
2f38dff7
PE
31512012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3152
3153 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3154 It is never used otherwise.
3155
4ae29f89
SM
31562012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3157
3158 * print.c (print_preprocess): Only check print_depth if print-circle
3159 is nil.
3160 (print_object): Check for cycles even when print-circle is nil and
3161 print-gensym is t, but only check print_depth if print-circle is nil.
3162
f30d612a
CY
31632012-04-20 Chong Yidong <cyd@gnu.org>
3164
3165 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3166 set the status to "failed" and ensure that sentinel is run.
3167
c07a4c0b 31682012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3169
3170 * process.c (Fset_process_inherit_coding_system_flag)
3171 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3172 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3173
c07a4c0b 31742012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3175
3176 * xdisp.c (string_buffer_position_lim): Limit starting position to
3177 BEGV.
3178 (set_cursor_from_row): If called for a mode-line or header-line
3179 row, return zero immediately.
3180 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3181 farther than the first row after the header line, if any.
3182 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3183 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3184
c07a4c0b 31852012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3186
4ae29f89
SM
3187 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3188 (bug#11238).
ad3a2b41 3189
c07a4c0b 31902012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 31912012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3192
3193 configure: new option --enable-gcc-warnings (Bug#11207)
3194 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3195 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3196 (ALL_CFLAGS): Use new macros rather than old.
3197 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3198 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3199 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3200 -Wunused-result, -Wunused-variable. This should go away once
3201 the Emacs and Gnulib regex code is merged.
3202 (xmalloc, xrealloc): Now static.
3203
aba027e8
PE
32042012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3205
3206 * dired.c (Fsystem_groups): Remove unused local.
3207
e5a36063
GM
32082012-04-17 Glenn Morris <rgm@gnu.org>
3209
3210 * dired.c (Fsystem_users): Doc fix.
3211
316411f0
DA
32122012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3213
3214 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3215 (syms_of_dired): Add them.
3216
9426aba4
PE
32172012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3218
b62a57be
PE
3219 Fix minor alloc.c problems found by static checking.
3220 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3221 New extern decls, to avoid calling undeclared functions.
3222 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3223 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3224 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3225 (NEED_MEM_INSERT): New macro.
3226 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3227 Remove one incorrect comment and fix another.
b62a57be 3228
3539f31f
PE
3229 Fix minor ralloc.c problems found by static checking.
3230 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3231 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3232 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3233 (r_alloc_sbrk): Now static.
3234
a041960a
PE
3235 Improve ralloc.c interface checking.
3236 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3237 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3238 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3239 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3240 [REL_ALLOC]: ... to here, to check interface.
3241 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3242 Remove decls. This fixes an "It stinks!".
3243
9426aba4
PE
3244 * alloc.c (which_symbols): Fix alignment issue / type clash.
3245
d55c12ed
AS
32462012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3247
3248 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3249 (struct Lisp_Misc_Any): Likewise.
3250 (struct Lisp_Free): Likewise.
3251 * alloc.c (union aligned_Lisp_Symbol): Define.
3252 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3253 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3254 (union aligned_Lisp_Misc): Define.
3255 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3256 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3257 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3258
b948ce8b
PE
32592012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3260
3261 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3262 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3263 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3264 * s/netbsd.h, s/sol2-6.h:
3265 Remove definition of GC_MARK_STACK, since the default now works.
3266 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3267 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3268 no longer the default.
3269 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3270
35dc09a1 32712012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3272
35dc09a1
GM
3273 * lread.c (lisp_file_lexically_bound_p):
3274 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3275
35dc09a1
GM
32762012-04-14 Eli Zaretskii <eliz@gnu.org>
3277
3278 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3279 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3280
32812012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3282
3283 * nsterm.m (constrainFrameRect): Always constrain when there is only
3284 one screen (Bug#10962).
3285
bcd86815
KB
32862012-04-13 Ken Brown <kbrown@cornell.edu>
3287
3288 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3289
c25df26e
RT
32902012-04-13 Reuben Thomas <rrt@sc3d.org>
3291
3292 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3293
0fc59f1e
DC
32942012-04-11 Daniel Colascione <dancol@dancol.org>
3295
3296 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3297 against is gone. It's better to use vfork now so that when Cygwin
3298 gains a new, working vfork, we use it automatically (bug#10398).
3299
de8c03dc
SM
33002012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3301
3302 * window.c (save_window_save): Obey window-point-insertion-type.
3303
2f097256
GM
33042012-04-11 Glenn Morris <rgm@gnu.org>
3305
3306 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3307
453b951e
SM
33082012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3309
3310 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3311
75f1671a 33122012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3313
3314 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3315 (force_quit_count): New var.
3316 (handle_interrupt): Use it.
3317
2a8ce227
JB
33182012-04-10 Juanma Barranquero <lekktu@gmail.com>
3319
3320 * w32.c (w32_delayed_load): Record the full path of the library
3321 being loaded (bug#10424).
3322
935396c0
GM
33232012-04-09 Glenn Morris <rgm@gnu.org>
3324
05920a43
GM
3325 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3326 not just in the obarray, before snarfing them. (Bug#11036)
3327
935396c0
GM
3328 * Makefile.in ($(leimdir)/leim-list.el):
3329 Pass EMACS rather than BUILT_EMACS.
3330
a18ecafa
TZ
33312012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3332
3333 * process.c (make_process):
3334 * process.h: Add integer `gnutls_handshakes_tried' member to
3335 process struct.
3336
6bbef4e5
JC
3337 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3338 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3339
3340 * gnutls.c (gnutls_log_function2i): Convenience log function.
3341 (emacs_gnutls_read): Use new log functions,
3342 `gnutls_handshakes_tried' process member, and
3343 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3344 attempts per process (connection).
3345
b4d3bc10
CY
33462012-04-09 Chong Yidong <cyd@gnu.org>
3347
3348 * eval.c (Fuser_variable_p, user_variable_p_eh)
3349 (lisp_indirect_variable): Functions deleted.
3350 (Fdefvar): Caller changed.
3351
3352 * callint.c (Finteractive, Fcall_interactively):
3353 * minibuf.c (Fread_variable): Callers changed.
3354
70f4d973
EZ
33552012-04-09 Eli Zaretskii <eliz@gnu.org>
3356
3357 * xdisp.c (set_cursor_from_row): If the display string appears in
3358 the buffer at position that is closer to point than the position
3359 after the display string, display the cursor on the first glyph of
3360 the display string. Fixes cursor display when a 'display' text
3361 property immediately follows invisible text. (Bug#11094)
3362
cb3c2e3e
PE
33632012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3364
3365 composite.c: use 'double' consistently
3366 * composite.c (get_composition_id): Use 'double' consistently
3367 instead of converting 'float' to 'double' and vice versa; this is
3368 easier to understand and avoids a GCC warning.
3369
fd06db5d
GM
33702012-04-09 Glenn Morris <rgm@gnu.org>
3371
50fe702a
GM
3372 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3373 preparation for dumping it with emacs. (Bug#4789)
3374 (leimdir): New variable.
3375 ($(leimdir)/leim-list.el): New rule.
3376 (emacs$(EXEEXT)): Depend on leim-list.el.
3377
fd06db5d
GM
3378 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3379 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3380 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3381
55c131ee
AS
33822012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3383
3384 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3385 proper alignment.
3386
9209588f
JB
33872012-04-07 Juanma Barranquero <lekktu@gmail.com>
3388
3389 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3390 Remove unused local variable.
3391
e3fb2efb
PE
33922012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3393
3394 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3395 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3396 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3397 objects, as mark_maybe_pointer will catch them otherwise.
3398 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3399 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3400
b5385551
PE
34012012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3402
3403 Fix typo that broke non-Windows builds.
3404 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3405
9078ead6
EZ
34062012-04-07 Eli Zaretskii <eliz@gnu.org>
3407
3408 Support building on MS-Windows with libxml2.
3409
3410 * makefile.w32-in (OBJ2): Add xml.$(O).
3411 (GLOBAL_SOURCES): Add xml.c.
3412 ($(BLD)/xml.$(O)): New dependency list.
3413
3414 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3415 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3416 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3417 [!WINDOWSNT]: New macros.
3418 (init_libxml2_functions, libxml2_loaded_p): New functions.
3419 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3420 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3421 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3422 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3423 linked in).
6bbef4e5
JC
3424 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3425 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3426 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3427
3428 * emacs.c: Don't include libxml/parser.h.
3429 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3430 xmlCleanupParser directly.
3431
3432 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3433
3811fdf3
EZ
34342012-04-07 Eli Zaretskii <eliz@gnu.org>
3435
3436 * indent.c (Fvertical_motion): If there is a display string at
3437 point, use it.vpos to compute how many lines to backtrack after
3438 move_it_to point. (Bug#11133)
3439
2f8e16b2
EZ
34402012-04-06 Eli Zaretskii <eliz@gnu.org>
3441
3442 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3443 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3444 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3445 macros related to unification of CJK characters. For the details,
3446 see the discussion following the message here:
3447 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3448
3d439cd1
CY
34492012-04-04 Chong Yidong <cyd@gnu.org>
3450
3451 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3452
8bc53d00
EZ
34532012-04-01 Eli Zaretskii <eliz@gnu.org>
3454
3455 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3456 instead of alloca. (Bug#11138)
3457
3b0512a3
AS
34582012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3459
3460 * w32menu.c (is_simple_dialog): Properly check lisp types.
3461 (Bug#11141)
3462
8427ddd2
EZ
34632012-03-31 Eli Zaretskii <eliz@gnu.org>
3464
979022ef
EZ
3465 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3466 position we get to after a call to move_it_to fails the
3467 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3468 only if we wind up in a string from display property. (Bug#11063)
3469
a6b1c7cc
EZ
3470 * window.c (Fdelete_other_windows_internal): Invalidate the row
3471 and column information about mouse highlight, so that redisplay
3472 restores it after reallocating the glyph matrices. (Bug#7464)
3473
8427ddd2
EZ
3474 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3475 string comes from a `display' text property, use the buffer
3476 position of that property as if we actually saw that position in
3477 the row's glyphs.
697ba24b
EZ
3478 (move_it_by_lines): Remove the assertion that
3479 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3480 violated when there's a before-string at the beginning of a line.
3481 (Bug#11063)
8427ddd2 3482
65a0a738
EZ
34832012-03-30 Eli Zaretskii <eliz@gnu.org>
3484
3485 * xdisp.c (append_space_for_newline): If the default face was
3486 remapped, use the remapped face for the appended newline.
3487 (extend_face_to_end_of_line): Use the remapped default face for
3488 extending the face to the end of the line.
3489 (display_line): Call extend_face_to_end_of_line when the default
3490 face was remapped. (Bug#11068)
3491
581355cc
EZ
34922012-03-29 Eli Zaretskii <eliz@gnu.org>
3493
3494 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3495
e8fc049f
SM
34962012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3497
3498 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3499
4fb9a543
GM
35002012-03-27 Glenn Morris <rgm@gnu.org>
3501
3502 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3503 Doc fixes.
3504
679910f1
KH
35052012-03-26 Kenichi Handa <handa@m17n.org>
3506
3507 * dispextern.h (struct glyph): Fix previous change. Change the
3508 bit length of glyphless.ch to 25 (Bug#11082).
3509
90d49b7f
CY
35102012-03-26 Chong Yidong <cyd@gnu.org>
3511
3512 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3513 (command_loop_1): Use it; inhibit selection update for
3514 handle-select-window too (Bug#8996).
3515
f514f6f0
FP
35162012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3517
e8fc049f 3518 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3519
bf43fa51
KH
35202012-03-25 Kenichi Handa <handa@m17n.org>
3521
3522 * dispextern.h (struct glyph): Change the bit length of
3523 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3524
8a0c01dd
EZ
35252012-03-24 Eli Zaretskii <eliz@gnu.org>
3526
3527 * s/ms-w32.h (tzname): Include time.h before redirecting to
3528 _tzname. Fixes the MSVC build. (Bug#9960)
3529
7d1c3a76
AS
35302012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3531
8ed79523
AS
3532 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3533 characters.
3534
7d1c3a76
AS
3535 * xterm.c (XTread_socket): Only modify handling_signal if
3536 !SYNC_INPUT. (Bug#11080)
3537
e99a9b8b
EZ
35382012-03-23 Eli Zaretskii <eliz@gnu.org>
3539
3540 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3541 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3542 when fetching a multibyte character consumes more bytes than
3543 CHAR_BYTES returns, due to unification of CJK characters in
3544 string_char. (Bug#11073)
3545
5063c0e1
TN
35462012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3547
3548 * process.c (wait_reading_process_output): Handle pty disconnect
3549 by refraining from sending oneself a SIGCHLD (bug#10933).
3550
9f851fbd
CY
35512012-03-22 Chong Yidong <cyd@gnu.org>
3552
3553 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3554
5063c0e1 3555 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3556 Mark string as coming from a prefix property.
3557 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3558 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3559
fb5b8aca
CY
35602012-03-21 Chong Yidong <cyd@gnu.org>
3561
3562 * xfaces.c (Vface_remapping_alist): Doc fix.
3563
62356a1b
EZ
35642012-03-20 Eli Zaretskii <eliz@gnu.org>
3565
3566 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3567 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3568 Doc fixes.
62356a1b 3569
025de85b
CY
35702012-03-20 Chong Yidong <cyd@gnu.org>
3571
3572 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3573 to reflect default non-nil value of redisplay-dont-pause.
3574
4827f94e
KH
35752012-03-19 Kenichi Handa <handa@m17n.org>
3576
3577 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3578 it fit in a valid range (Bug#11003).
3579
e50a24a2
EZ
35802012-03-18 Eli Zaretskii <eliz@gnu.org>
3581
3582 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3583 that is not from display property, accept the row as a "cursor
3584 row" if one of the string's character has a non-nil `cursor'
3585 property. Fixes cursor positioning when there are newlines in
3586 overlay strings, e.g. in icomplete.el. (Bug#11035)
3587
9af5ed87
PE
35882012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3589
3590 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3591
d1f55f16
CY
35922012-03-12 Chong Yidong <cyd@gnu.org>
3593
3594 * eval.c (inhibit_lisp_code): Rename from
3595 inhibit_window_configuration_change_hook; move from window.c.
3596
3597 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3598 * window.c (run_window_configuration_change_hook)
3599 (syms_of_window): Callers changed.
3600
66c5eebd
CY
36012012-03-11 Chong Yidong <cyd@gnu.org>
3602
413df973
CY
3603 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3604
66c5eebd
CY
3605 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3606
1de11f56
CY
36072012-03-10 Chong Yidong <cyd@gnu.org>
3608
3609 * frame.c (other_visible_frames): Don't assume the selected frame
3610 is visible (Bug#10955).
3611
cae07000
SM
36122012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3613
3614 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3615
89c94350
JD
36162012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3617
3618 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3619 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3620 zero (Bug#10954).
3621
999dd333
GM
36222012-03-03 Glenn Morris <rgm@gnu.org>
3623
01a6dcc8 3624 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3625
de0100f2
EZ
36262012-03-02 Eli Zaretskii <eliz@gnu.org>
3627
3628 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3629 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3630 (redisplay_window, next_element_from_string): Fix typos in
3631 comments.
3e441275
EZ
3632 (redisplay_window): Pass to move_it_vertically the margin in
3633 pixels, not in screen lines.
de0100f2 3634
96a72ee9
GM
36352012-03-02 Glenn Morris <rgm@gnu.org>
3636
3637 * buffer.c (buffer-list-update-hook): Doc fix.
3638
312508d7
EZ
36392012-02-29 Eli Zaretskii <eliz@gnu.org>
3640
3641 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3642 push_it before setting up the iterator for the first overlay
3643 string, even if we have an empty string loaded.
3644 (next_overlay_string): If there's an empty string on the iterator
3645 stack, pop the stack. (Bug#10903)
3646
27f3c637
PE
36472012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3648
3649 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3650 Suggested by Stefan Monnier in
3651 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3652 * alloc.c (widen_to_Lisp_Object): New static function.
3653 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3654 and widening them to Lisp_Objects. This would work even if
3655 USE_LSB_TAG is defined and wide integers are used, which might
3656 happen in a future version of Emacs.
3657
3c9dfce6
CY
36582012-02-25 Chong Yidong <cyd@gnu.org>
3659
fa74b241
CY
3660 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3661 Doc fix.
3662
3c9dfce6
CY
3663 * xselect.c (Fx_selection_exists_p): Doc fix.
3664 (x_clipboard_manager_save_all): Print an informative message
3665 before saving to clipboard manager.
3666
9486df08
CY
36672012-02-24 Chong Yidong <cyd@gnu.org>
3668
3669 * keyboard.c (process_special_events): Handle all X selection
3670 requests in kbd_buffer, not just the next one (Bug#8869).
3671
f01d3321
CY
36722012-02-23 Chong Yidong <cyd@gnu.org>
3673
3674 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3675 call when setting menu-bar-lines and tool-bar-lines parameters.
3676 (unwind_create_frame_1): New helper function.
3677
3678 * window.c (inhibit_window_configuration_change_hook): New var.
3679 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3680 (syms_of_window): Initialize it.
f01d3321 3681
86b847b6
CY
36822012-02-22 Chong Yidong <cyd@gnu.org>
3683
3684 * xterm.c (x_draw_image_relief): Add missing type check for
3685 Vtool_bar_button_margin (Bug#10743).
3686
a59225b1
CY
36872012-02-21 Chong Yidong <cyd@gnu.org>
3688
3689 * fileio.c (Vfile_name_handler_alist): Doc fix.
3690
3691 * buffer.c (Fget_file_buffer): Protect against invalid file
3692 handler return value.
3693
310f5bd4
PE
36942012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3695
cb3a28cc
PE
3696 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3697 when computing $valmask.
3698
310f5bd4
PE
3699 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3700 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3701 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3702 It's useless in that case, and it can cause problems on hosts
3703 that allocate halves of EMACS_INT values separately.
3704 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3705 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3706 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3707 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3708 it avoids undefined behavior on hosts where shifting right by more
3709 than the word width has undefined behavior.
3710
2375c96a
CY
37112012-02-19 Chong Yidong <cyd@gnu.org>
3712
3713 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3714 (Funhandled_file_name_directory, Ffile_name_as_directory)
3715 (Fdirectory_file_name, Fexpand_file_name)
3716 (Fsubstitute_in_file_name): Protect against invalid file handler
3717 return values (Bug#10845).
3718
3eb49e71
EZ
37192012-02-18 Eli Zaretskii <eliz@gnu.org>
3720
3721 * .gdbinit (pitx): Fix incorrect references to fields of the
3722 iterator stack.
3723
7b926f3f
CY
37242012-02-17 Chong Yidong <cyd@gnu.org>
3725
3726 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3727
11273115
PE
37282012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3729
3730 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3731 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3732
c3a70e2b
CY
37332012-02-15 Chong Yidong <cyd@gnu.org>
3734
3735 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3736 marked as special. Also, starting docstrings with * is obsolete.
3737
0ca43699
AS
37382012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3739
3740 * gnutls.c (emacs_gnutls_write): Fix last change.
3741
2e8f3c56
LI
37422012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3743
3744 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3745 send_process.
3746
af70074f
SM
37472012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3748
3749 * keymap.c (Fsingle_key_description): Handle char ranges.
3750
95986d52
CY
37512012-02-12 Chong Yidong <cyd@gnu.org>
3752
afd83bd1
CY
3753 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3754 as that creates a dangerous corner case.
3755
95986d52
CY
3756 * window.c (Fdelete_window_internal): Invalidate the mouse
3757 highlight (Bug#9904).
3758
bd7da63e
GM
37592012-02-12 Glenn Morris <rgm@gnu.org>
3760
3761 * xselect.c (Fx_own_selection_internal)
3762 (Fx_get_selection_internal, Fx_disown_selection_internal)
3763 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3764 * nsselect.m (Fx_own_selection_internal)
3765 (Fx_disown_selection_internal, Fx_selection_exists_p)
3766 (Fx_selection_owner_p, Fx_get_selection_internal):
3767 Sync docs and argument specs with the xselect.c versions.
3768
77abcbc2
LI
37692012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3770
3771 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3772
90b671e2
EZ
37732012-02-11 Eli Zaretskii <eliz@gnu.org>
3774
1c0ca0b7
EZ
3775 * w32select.c (Fx_selection_exists_p): Sync doc string and
3776 argument list with xselect.c. (Bug#10783)
3777
3778 * w16select.c (Fx_selection_exists_p): Sync doc string and
3779 argument list with xselect.c. (Bug#10783)
90b671e2 3780
49241268
GM
37812012-02-10 Glenn Morris <rgm@gnu.org>
3782
3783 * fns.c (Fsecure_hash): Doc fix.
3784
f998bbe7 37852012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3786
3787 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3788
0992bd9c
CY
37892012-02-07 Chong Yidong <cyd@gnu.org>
3790
3791 * buffer.c (Fbuffer_local_variables)
3792 (buffer_lisp_local_variables): Handle unbound vars correctly;
3793 don't let Qunbound leak into Lisp.
3794
af008560
GM
37952012-02-07 Glenn Morris <rgm@gnu.org>
3796
dd605cc4
GM
3797 * image.c (Fimagemagick_types): Doc fix.
3798
af008560
GM
3799 * image.c (imagemagick-render-type): Change it from a lisp object
3800 to an integer. Move the doc here from the lisp manual.
3801 Treat all values not equal to 0 the same.
3802
1449fa1d
CY
38032012-02-06 Chong Yidong <cyd@gnu.org>
3804
3805 * doc.c (store_function_docstring): Avoid applying docstring of
3806 alias to base function (Bug#2603).
3807
3723ec07
AS
38082012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3809
3810 * .gdbinit (pp1, pv1): Remove redundant defines.
3811 (pr): Use pp.
3812
79c1cc1e
CY
38132012-02-04 Chong Yidong <cyd@gnu.org>
3814
3815 * nsterm.m: Declare a global (Bug#10694).
3816
d7f29f8e
EZ
38172012-02-04 Eli Zaretskii <eliz@gnu.org>
3818
cae07000
SM
3819 * w32.c (get_emacs_configuration_options):
3820 Include --enable-checking, if specified, in the return value.
d7f29f8e 3821
3b95a6f9
MR
38222012-02-04 Martin Rudalics <rudalics@gmx.at>
3823
3824 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3825 after rounding frame sizes. (Bug#9723)
3826
d6fa96a6
EZ
38272012-02-04 Eli Zaretskii <eliz@gnu.org>
3828
3829 * keyboard.c (adjust_point_for_property): Don't position point
3830 before BEGV. (Bug#10696)
3831
df0b2940
PE
38322012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3833
3834 Handle overflow when computing char display width (Bug#9496).
3835 * character.c (char_width): Return EMACS_INT, not int.
3836 (char_width, c_string_width): Check for overflow when
3837 computing the width; this is possible now that individual
3838 characters can have unbounded width. Problem introduced
3839 by merge from Emacs 23 on 2012-01-19.
3840
6bee44d6
MA
38412012-02-02 Michael Albinus <michael.albinus@gmx.de>
3842
3843 * dbusbind.c (Fdbus_register_method): Mention the return value
3844 :ignore in the docstring.
3845
44f92739
GM
38462012-02-02 Glenn Morris <rgm@gnu.org>
3847
1b9f60cc
GM
3848 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3849
44f92739
GM
3850 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3851 Unconditionally set to t. (Bug#10673)
3852 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3853 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3854 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3855
c5d3843c
KH
38562012-02-02 Kenichi Handa <handa@m17n.org>
3857
3858 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3859 0, do not call append_composite_glyph.
3860
159462d4 38612012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3862
3863 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3864 NULL (Bug#6988).
3865 (x_produce_glyphs): If the component of a composition is a null
3866 string, set it->pixel_width to 1 to avoid zero-width glyph.
3867
78cef877
EZ
38682012-02-01 Eli Zaretskii <eliz@gnu.org>
3869
3870 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3871 first 2 arguments are identical. This makes inserting large
3872 output from a subprocess an order of magnitude faster on
3873 MS-Windows, where all sbrk'ed memory is always contiguous.
3874
97897668
GM
38752012-01-31 Glenn Morris <rgm@gnu.org>
3876
3877 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3878 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3879 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3880
31fd3586
GM
38812012-01-29 Glenn Morris <rgm@gnu.org>
3882
3883 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3884
0e24a8b2
CY
38852012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3886
3887 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3888
cc0adcb0
CY
38892012-01-28 Chong Yidong <cyd@gnu.org>
3890
3891 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3892
acc28cb9
CY
38932012-01-26 Chong Yidong <cyd@gnu.org>
3894
9c69cfb7
CY
3895 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3896
acc28cb9
CY
3897 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3898 repeat counts (Bug#10507).
3899
48da7392
GM
39002012-01-26 Glenn Morris <rgm@gnu.org>
3901
3902 * lread.c (syms_of_lread): Doc fix.
3903
14af5f7f
CY
39042012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3905
3906 * coding.c (encode_designation_at_bol): Change return value to
3907 EMACS_INT.
3908
0b21c100
CY
39092012-01-25 Chong Yidong <cyd@gnu.org>
3910
3911 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3912
3c2907f7
CY
39132012-01-21 Chong Yidong <cyd@gnu.org>
3914
3915 * floatfns.c (Fcopysign): Make the second argument non-optional,
3916 since nil is not allowed anyway.
3917
959ad23f
AS
39182012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3919
3920 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3921 (send_process): Likewise.
3922
34a02f46
MR
39232012-01-19 Martin Rudalics <rudalics@gmx.at>
3924
3925 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3926 (Vwindow_persistent_parameters): Do not use Qstate.
3927 Rewrite doc-strings.
34a02f46 3928
1259009a 39292012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3930
3931 * character.c (char_width): New function.
70d4fdf6
GM
3932 (Fchar_width, c_string_width, lisp_string_width):
3933 Use char_width (Bug#9496).
25ed9e61 3934
6a6ee00d
MR
39352012-01-16 Martin Rudalics <rudalics@gmx.at>
3936
3937 * window.c (Vwindow_persistent_parameters): New variable.
3938 (Fset_window_configuration, save_window_save): Handle persistent
3939 window parameters.
3940
c85efaf7
EZ
39412012-01-14 Eli Zaretskii <eliz@gnu.org>
3942
3943 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3944 thrashing the stack of the thread. (Bug#9087)
3945
5944709e
PE
39462012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3947
3948 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3949
e71f5d99
EZ
39502012-01-11 Eli Zaretskii <eliz@gnu.org>
3951
3952 * xdisp.c (rows_from_pos_range): Handle the case where the
3953 highlight ends on a newline. (Bug#10464)
3954 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3955 he end column for display of highlight that ends on a newline
3956 before a R2L line.
3957
ce316182
GM
39582012-01-11 Glenn Morris <rgm@gnu.org>
3959
3960 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3961 from load-path also when installation-directory is nil. (Bug#10208)
3962
5b43da69
GM
39632012-01-10 Glenn Morris <rgm@gnu.org>
3964
74cc8ff9
GM
3965 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3966
7d8d6e4e
GM
3967 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3968 Update template values to be closer to their typical values these days.
5b43da69 3969
a0db8d43
EZ
39702012-01-09 Eli Zaretskii <eliz@gnu.org>
3971
3972 * xdisp.c (rows_from_pos_range): Accept additional argument
3973 DISP_STRING, and accept any glyph in a row whose object is that
3974 string as eligible for mouse highlight. Fixes mouse highlight of
3975 display strings from overlays. (Bug#10464)
3976
9a0115ab 39772012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3978
b9110d6a 3979 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3980 * fileio.c (auto_saving_dir_umask): New static var.
3981 (Fmake_directory_internal): Use it.
3982 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3983 creating the directory. The old code temporarily assigns
3984 too-generous permissions to the directory.
3985 (do_auto_save_eh): Clear it.
b9110d6a 3986 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3987 that the var is always cleared.
3988
6c1bd3f3
EZ
39892012-01-07 Eli Zaretskii <eliz@gnu.org>
3990
3991 * search.c (scan_buffer): Pass character positions to
3992 know_region_cache, not byte positions. (Bug#6540)
3993
069d2b50
L
39942012-01-07 LynX <_LynX@bk.ru> (tiny change)
3995
3996 * w32.c (sys_rename): Report EXDEV when rename of a directory
3997 fails because the target is on another logical disk. (Bug#10284)
3998
75bf0d33
DB
39992012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4000
4001 * xterm.c (x_embed_request_focus): New function.
4002
4003 * xterm.h: Add prototype.
4004
4005 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4006
1c6e5a32
GM
40072012-01-05 Glenn Morris <rgm@gnu.org>
4008
4009 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4010
651e947e
EZ
40112012-01-01 Eli Zaretskii <eliz@gnu.org>
4012
4013 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4014 Load gnutls_transport_set_lowat only if GnuTLS version is below
4015 2.11.1.
4016 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4017 GnuTLS versions below 2.11.1.
4018
3778cdd8
AL
40192011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4020
4021 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4022 to the doc string advising against its use for altering the way
4023 windows are scrolled.
4024
0e5317f7
KH
40252011-12-28 Kenichi Handa <handa@m17n.org>
4026
4027 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4028 coding-system ASCII compatible only when it does not produce BOM
4029 on encoding (Bug#10383).
4030
93d5ca1f
JD
40312011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4032
4033 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4034 can scroll.
4035 (create_and_show_popup_menu): Always use menu_position_func for
4036 Gtk3 (Bug#10361).
4037
ca22b785
AS
40382011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4039
4040 * callint.c (Fcall_interactively): Don't truncate prompt string.
4041
d048e1e6
EZ
40422011-12-23 Eli Zaretskii <eliz@gnu.org>
4043
4044 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4045 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4046 resumed from there (after widening). (Bug#10360)
d048e1e6 4047
5ccaba1f
JD
40482011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4049
4050 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4051
204ee57f
JD
40522011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4053
b81d40f0
JB
4054 * nsterm.m (x_free_frame_resources):
4055 Release f->output_data.ns->miniimage.
204ee57f
JD
4056 (ns_index_color): Fix indentation. Do not retain
4057 color_table->colors[i].
4058
4059 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4060 before returning.
4061
4062 * nsfns.m (x_set_background_color): Assign return value from
4063 ns_index_color to face-background instead of NSColor*.
4064 (ns_implicitly_set_icon_type): Fix indentation.
4065 Change assignment in for loop to comparison.
4066
4067 * emacs.c (ns_pool): New variable.
4068 (main): Assign ns_pool.
4069 (Fkill_emacs): Call ns_release_autorelease_pool.
4070
4071 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4072 autorelease fdesc, release fdAttrs and tdict.
4073 (ns_get_covering_families): Release charset.
4074 (ns_findfonts): Release NSFontDescriptor created with new.
4075 (ns_uni_to_glyphs): Fix indentation.
4076 (setString): Release attrStr before assigning new value.
4077
c803b2b7
JD
40782011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4079
678f4426
JD
4080 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4081 and NS_IMPL_COCOA.
4082 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4083 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4084
cd394be1 40852011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4086
5fecd5fc
JD
4087 * nsterm.m (ns_term_init): Subscribe for notifications
4088 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4089 to method trackingNotification in EmacsMenu.
4090
4091 * nsmenu.m (trackingMenu): New variable.
3771cb17 4092 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4093 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4094 from Aquamacs (Bug#7030).
678f4426
JD
4095
40962011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4097
c803b2b7
JD
4098 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4099 (symbol_to_nsstring): Fix indentation.
4100 (ns_symbol_to_pb): New function.
cae07000
SM
4101 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4102 (Fns_rotate_cut_buffers_internal): Remove.
4103 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4104 Fns_store_cut_buffer_internal.
4105 (ns_get_foreign_selection, Fx_own_selection_internal)
4106 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4107 (Fns_get_selection_internal, Fns_store_selection_internal):
4108 Use ns_symbol_to_pb and check if return value is nil.
4109 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4110 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4111 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4112 renamed to Sns_store_selection_internal.
4113 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4114 and remove this function.
4115 (ns_handle_selection_clear): Remove, never used.
4116 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4117 here.
4118
e1b01a3a
KB
41192011-12-17 Ken Brown <kbrown@cornell.edu>
4120
4121 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4122 GID is unknown (Bug#10257).
4123
2adb6e85
PE
41242011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4125
4126 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4127 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4128 which caused a build failure on GNU/Linux IA-64. This problem was
4129 introduced by my 2011-10-07 patch.
4130
d1d7b339
JL
41312011-12-15 Juri Linkov <juri@jurta.org>
4132
4133 * image.c (imagemagick_error): New function. (Bug#10112)
4134 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4135 Use `imagemagick_error' where ImageMagick functions return
4136 `MagickFalse'.
4137 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4138 proper order.
4139
100d5755
KH
41402011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4141
4142 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4143 fill background (Bug#8992).
4144
454592a6
MR
41452011-12-13 Martin Rudalics <rudalics@gmx.at>
4146
4147 * window.c (Vwindow_combination_resize)
4148 (Vwindow_combination_limit): Use t instead of non-nil in
4149 doc-strings.
61d4b438
MR
4150 (Vrecenter_redisplay): Add first sentence of doc-string on
4151 separate line.
53524d93 4152 (Frecenter): Fix doc-string typo.
454592a6 4153
3633e3aa
KH
41542011-12-11 Kenichi Handa <handa@m17n.org>
4155
4156 * coding.c (Funencodable_char_position): Pay attention to the
4157 buffer text relocation (Bug#9389).
4158
7b9d523a 41592011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4160
7b9d523a
JD
4161 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4162 gtk_init (Bug#10100).
4163
b73189c6
EZ
41642011-12-10 Eli Zaretskii <eliz@gnu.org>
4165
4166 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4167 IT->string is nil. (Bug#10263)
4168
f7dfe5d6
JD
41692011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4170
83faebb4
JD
4171 * nsterm.h (x_free_frame_resources): Declare.
4172
f7dfe5d6
JD
4173 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4174 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4175
4176 * nsterm.h (ns_get_defaults_value): Declare.
4177
4178 * nsterm.m (ns_default): Call ns_get_defaults_value.
4179
7cd4e72c
EZ
41802011-12-09 Eli Zaretskii <eliz@gnu.org>
4181
4182 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4183 (Bug#10170)
4184
b34d7317
YM
41852011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4186
4187 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4188 that where the value of an _OBJC_* symbol points to is in the .bss
4189 section (Bug#10240).
4190
76470ad1
KH
41912011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4192
4193 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4194 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4195
745fff94
KH
41962011-12-08 Kenichi Handa <handa@m17n.org>
4197
4198 * ftfont.c (get_adstyle_property): Fix previous change
4199 (Bug#10233).
4200
6e44397c
JB
42012011-12-07 Juanma Barranquero <lekktu@gmail.com>
4202
4203 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4204 dirs from the default value of EMACSLOADPATH (bug#10208).
4205
7efa6272
GM
42062011-12-07 Glenn Morris <rgm@gnu.org>
4207
4208 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4209 installation and source directories as well. (Bug#10208)
4210
f6fc4d87
CY
42112011-12-06 Chong Yidong <cyd@gnu.org>
4212
4213 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4214
2bf26180
GM
42152011-12-06 Glenn Morris <rgm@gnu.org>
4216
4217 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4218 as an error, not just -1. (Bug#10217)
4219
3a6ad4f0
CY
42202011-12-05 Chong Yidong <cyd@gnu.org>
4221
4222 * keyboard.c (process_special_events): New function.
4223 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4224
75a3b399
PE
42252011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4226
4227 * coding.c (encode_designation_at_bol): Don't use uninitialized
4228 local variable (Bug#9318).
4229
c3c9e25e
KH
42302011-12-05 Kenichi Handa <handa@m17n.org>
4231
4232 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4233 return Qnil (Bug#8046, Bug#10193).
4234
5eb05ea3
KH
42352011-12-05 Kenichi Handa <handa@m17n.org>
4236
4237 * coding.c (encode_designation_at_bol): New args charbuf_end and
4238 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4239 (coding_set_source): Return how many bytes coding->source was
4240 relocated.
4241 (coding_set_destination): Return how many bytes
4242 coding->destination was relocated.
4243 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4244 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4245
42462011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4247
4248 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4249 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4250 macro (Bug#9318).
4251
42522011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4253
4254 The following changes are to fix Bug#9318.
4255
a79703f5 4256 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4257 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4258 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4259 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4260
7dbda6df
JB
42612011-12-05 Juanma Barranquero <lekktu@gmail.com>
4262
4263 * lisp.h (process_quit_flag): Fix external declaration.
4264
6d5eb5b0
SM
42652011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4266
4267 Don't macro-inline non-performance-critical code.
4268 * eval.c (process_quit_flag): New function.
4269 * lisp.h (QUIT): Use it.
4270
a0c3fad0
JD
42712011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4272
4273 * nsfns.m (get_geometry_from_preferences): New function.
4274 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4275
6c07aac2
AS
42762011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4277
4278 * emacs.c (Qkill_emacs): Define.
4279 (syms_of_emacs): Initialize it.
4280 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4281 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4282 (quit_throw_to_read_char): Add parameter `from_signal'.
4283 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4284 * lisp.h (QUIT): Call Fkill_emacs if requested.
4285
c052ead4
JD
42862011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4287
4288 * widget.c (update_wm_hints): Return if wmshell is null.
4289 (widget_update_wm_size_hints): New function.
4290
4291 * widget.h (widget_update_wm_size_hints): Declare.
4292
4293 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4294 widget_update_wm_size_hints (Bug#10104).
4295
9e49252b
EZ
42962011-12-03 Eli Zaretskii <eliz@gnu.org>
4297
4298 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4299 before a newline, prepare the bidi iterator for consuming the
4300 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4301 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4302
02b16839
JL
43032011-12-02 Juri Linkov <juri@jurta.org>
4304
4305 * search.c (Fword_search_regexp): New Lisp function created from
4306 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4307 (Fword_search_backward, Fword_search_forward)
4308 (Fword_search_backward_lax, Fword_search_forward_lax):
4309 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4310 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4311
0068070e
SM
43122011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4313
4314 * fileio.c (Finsert_file_contents): Move after-change-function call
4315 to before the "handled:" label, since all "goto handled" appear in
4316 cases where the *-change-functions have already been properly called
4317 (bug#10117).
4318
3360a3fc
AS
43192011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4320
4321 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4322 waiting for input. (Bug#10169)
4323
73d6c093
EZ
43242011-11-30 Eli Zaretskii <eliz@gnu.org>
4325
4326 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4327 verifies glyph row's hash code--we have just reallocated the
4328 glyphs, so their contents can be complete garbage. (Bug#10164)
4329
febe6bea
JB
43302011-11-30 Juanma Barranquero <lekktu@gmail.com>
4331
4332 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4333
801a4313
EZ
43342011-11-30 Eli Zaretskii <eliz@gnu.org>
4335
4336 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4337 attributes are tested _before_ calling verify_row_hash, to protect
4338 against GCC re-ordering of the tests. (Bug#10164)
4339
2b56b87e
JD
43402011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4341
4342 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4343
4344 * xterm.c (handle_one_xevent): Only set async_visible and friends
4345 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4346 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4347 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4348
dbf31225
PE
43492011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4350
4351 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4352 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4353 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4354 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4355 All uses changed to use GCPRO1 etc.
4356 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4357 Revert to old implementation (i.e., before 2011-03-11).
4358
1305621b
YM
43592011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4360
4361 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4362 of scroll runs so as to avoid assigning disabled bogus rows and
4363 unnecessary graphics copy operations.
4364
8c9afb46
EZ
43652011-11-27 Eli Zaretskii <eliz@gnu.org>
4366
4367 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4368 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4369 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4370 (malloc, free, realloc, calloc): Redirect to e_* only when
4371 compiling Emacs.
4372
4373 * lisp.h (GCTYPEBITS): Move before first use.
4374 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4375 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4376 this macro definition.
4377
4378 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4379 _MSC_VER.
4380
54e9e3bf
JD
43812011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4382
6d5eb5b0
SM
4383 * gtkutil.c (xg_create_frame_widgets):
4384 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4385 present with Gtk+ 2.0.
4386
83aca1cb
PE
43872011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4388
4389 * fileio.c (Finsert_file_contents): Undo previous change; see
4390 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4391
5b76caa4
PE
43922011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4393
4394 Rename locals to avoid shadowing.
4395 * fileio.c (Finsert_file_contents):
4396 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4397 * process.c (wait_reading_process_output):
4398 Rename inner 'proc' to 'p' to avoid shadowing.
4399 Indent for consistency with usual Emacs style.
4400
8c535114
EZ
44012011-11-25 Eli Zaretskii <eliz@gnu.org>
4402
4403 * xdisp.c (redisplay_window): If cursor row is not fully visible
4404 after recentering, and scroll-conservatively is set to a large
4405 number, scroll window by a few more lines to make the cursor fully
4406 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4407 (start_display): Don't move to the next line if the display should
4408 start at a newline that is part of a display vector or an overlay
4409 string. (Bug#10119)
8c535114 4410
fa4fdb5c
JL
44112011-11-24 Juri Linkov <juri@jurta.org>
4412
4413 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4414 after the `MagickPingImage' call. (Bug#10112)
4415
90ec88df
CY
44162011-11-23 Chong Yidong <cyd@gnu.org>
4417
4418 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4419
56e2e794
MR
44202011-11-23 Martin Rudalics <rudalics@gmx.at>
4421
4422 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4423 making another buffer current. (Bug#10114)
4424
b6e64c41
GM
44252011-11-23 Glenn Morris <rgm@gnu.org>
4426
4427 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4428
6b21de18
CY
44292011-11-23 Chong Yidong <cyd@gnu.org>
4430
4431 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4432 using it (Bug#5984).
4433
b12cd789
EZ
44342011-11-22 Eli Zaretskii <eliz@gnu.org>
4435
4436 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4437 and header-lines, as they don't have one computed for them.
4438 (Bug#10098)
4439
4440 * .gdbinit (prow): Make displayed values more self-explaining.
4441 Add row's hash code.
4442
261b6fd4
LMI
44432011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4444
4445 * process.c (wait_reading_process_output): Fix asynchrounous
4446 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4447 (wait_reading_process_output): Add comment and URL.
261b6fd4 4448
e7cfd277
JD
44492011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4450
4451 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4452
a9b9b7f5
CY
44532011-11-21 Chong Yidong <cyd@gnu.org>
4454
4455 * window.c (Fnext_window, Fprevious_window): Doc fix.
4456
b0d15b4f
SM
44572011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4458
4459 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4460
fe7a3057
JB
44612011-11-20 Juanma Barranquero <lekktu@gmail.com>
4462
4463 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4464
d2999b1a
MR
44652011-11-20 Martin Rudalics <rudalics@gmx.at>
4466
4467 * window.c (Fset_window_combination_limit): Rename argument
4468 STATUS to LIMIT.
4469 (Vwindow_combination_limit): Remove "status" from doc-string.
4470
d5ff9cd0
AS
44712011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4472
4473 * m/ibms390.h: Remove.
4474 * m/ibms390x.h: Don't include "ibms390.h".
4475
a5bb9bd3
SM
44762011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4477
4478 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4479 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4480
cd1181db
JB
44812011-11-20 Juanma Barranquero <lekktu@gmail.com>
4482
4483 * casetab.c (Fset_case_table):
4484 * charset.c (Fcharset_after): Fix typos.
4485
615a3b8d 44862011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4487
17e845af
PE
4488 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4489 Otherwise, valgrind does not work on some platforms.
4490 Problem reported by Andreas Schwab in
6a0bf43d
PE
4491 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4492 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4493 is set, removing the need for VIRT_ADDRESS_VARIES.
4494 (PURE_P): Use a more-efficient implementation that needs just one
4495 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4496 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4497 to 4 (xorl, subq, cmpq, setbe).
4498 * alloc.c (pure): Always extern now, since that's the
4499 VIRT_ADDR_VARIES behavior.
4500 (PURE_POINTER_P): Use a single comparison, not two, for
4501 consistency with the new puresize.h.
4502 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4503 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4504 Remove VIRT_ADDR_VARIES no longer needed.
4505
f8fe6f96
EZ
45062011-11-19 Eli Zaretskii <eliz@gnu.org>
4507
4508 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4509 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4510 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4511 behave as if the cursor position were at the window margin.
4512
4513 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4514 and the cursor position is out of bounds, behave as if the cursor
4515 position were at the window margin. (Bug#10075)
4516
df05a53c
CY
45172011-11-18 Chong Yidong <cyd@gnu.org>
4518
4519 * window.c (Fwindow_combination_limit): Make first argument
4520 non-optional, since it is meaningless for live windows like the
4521 selected window.
61ccba97 4522
2071918e
DA
45232011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4524
4525 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4526
b50a28de
SM
45272011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4528
4529 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4530 (graft_intervals_into_buffer): Simplify.
4531
015137db
EZ
45322011-11-18 Eli Zaretskii <eliz@gnu.org>
4533
4534 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4535 hash values of the two rows.
4536 (copy_row_except_pointers): Preserve the used[] arrays and the
4537 hash values of the two rows. (Bug#10035)
68c95424 4538 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4539
4540 * xdisp.c (row_hash): New function, body extracted from
4541 compute_line_metrics.
4542 (compute_line_metrics): Call row_hash, instead of computing the
4543 hash code inline.
4544
4545 * dispnew.c (verify_row_hash): Call row_hash for computing the
4546 hash code of a row, instead of duplicating code from xdisp.c.
4547
4548 * dispextern.h (row_hash): Add prototype.
4549
a2addb04
TH
45502011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4551
4552 * frame.c (delete_frame): Don't delete the terminal when the last
4553 X frame is closed if emacs is built with GTK toolkit.
4554
df85d315
JB
45552011-11-17 Juanma Barranquero <lekktu@gmail.com>
4556
4557 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4558
a0c2d0ae
MR
45592011-11-17 Martin Rudalics <rudalics@gmx.at>
4560
4561 * window.c (Vwindow_splits): Rename to
4562 Vwindow_combination_resize. Suggested by Juri Linkov.
4563 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4564 of Vwindow_splits.
4565
58179cce
JB
45662011-11-16 Juanma Barranquero <lekktu@gmail.com>
4567
7877f373
JB
4568 * nsfns.m (Fns_font_name):
4569 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4570
b6f67890
MR
45712011-11-16 Martin Rudalics <rudalics@gmx.at>
4572
4573 * window.h (window): Rename slot "nest" to "combination_limit".
4574 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4575 (Fset_window_nest): Rename to Fset_window_combination_limit.
4576 (Vwindow_nest): Rename to Vwindow_combination_limit.
4577 (recombine_windows, make_parent_window, make_window)
4578 (Fsplit_window_internal, saved_window)
4579 (Fset_window_configuration, save_window_save): Rename all
4580 occurrences of window_nest to window_combination_limit.
4581
c7015153
JB
45822011-11-15 Juanma Barranquero <lekktu@gmail.com>
4583
4584 * image.c (imagemagick_load_image): Fix typo.
4585
322ad6ec
EZ
45862011-11-14 Eli Zaretskii <eliz@gnu.org>
4587
4588 * xdisp.c (display_line): Move the call to
4589 highlight_trailing_whitespace before the call to
4590 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4591 faces of all the glyphs to compute ROW's hash value.
4592 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4593
f067b8ec
JB
45942011-11-14 Juanma Barranquero <lekktu@gmail.com>
4595
4596 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4597 just return (bug#10044).
4598
1e5b2111
EZ
45992011-11-12 Eli Zaretskii <eliz@gnu.org>
4600
7ef3cbd5
EZ
4601 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4602 with user-defined heap size. Bump the default size of the temacs
4603 heap to 27MB, to avoid memory warning when running temacs.
4604 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4605
1e5b2111
EZ
4606 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4607 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4608 (verify_row_hash) [XASSERTS]: New function.
4609 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4610 that the hash value of glyph rows is correct.
1e5b2111 4611
89d61221
MR
46122011-11-12 Martin Rudalics <rudalics@gmx.at>
4613
4614 * window.h (window): Remove splits slot.
4615 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4616 (Fdelete_other_windows_internal, make_parent_window)
4617 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4618 (Fset_window_configuration, save_window_save): Don't deal with
4619 split status of windows.
4620 (saved_window): Remove splits slot.
4621 (Vwindow_splits): Rewrite doc-string.
4622
97f18cc8
JD
46232011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4624
4625 * xfns.c (unwind_create_frame):
4626 * nsfns.m (unwind_create_frame):
4627 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4628 Vframe_list (Bug#9999).
4629
22a648b4
DA
46302011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4631
0b381c7e 4632 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4633
659afede
KH
46342011-11-11 Kenichi Handa <handa@m17n.org>
4635
4636 * callproc.c (Fcall_process): Set the member dst_multibyte of
4637 process_coding.
4638
9ac0394b
KH
46392011-11-11 Johan Bockgård <bojohan@gnu.org>
4640
4641 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4642 avoid a crash (bug#9496).
4643
2fbdc249
CY
46442011-11-09 Chong Yidong <cyd@gnu.org>
4645
4646 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4647 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4648
ac6b1f81
PE
46492011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4650
4651 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4652
09db192c
PE
46532011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4654
4655 Avoid some portability problems by eschewing 'extern inline' functions.
4656 The trivial performance wins aren't worth the portability hassles; see
4657 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4658 et seq.
4659 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4660 (window_box_width, window_box_left, window_box_left_offset)
4661 (window_box_right, window_box_right_offset): Undo previous change,
4662 by removing the "extern"s.
4663 * intervals.c (adjust_intervals_for_insertion)
4664 (adjust_intervals_for_deletion): Undo previous change,
4665 making these static again.
4666 (offset_intervals, temp_set_point_both, temp_set_point)
4667 (copy_intervals_to_string): No longer inline.
4668 * xdisp.c (window_text_bottom_y, window_box_width)
4669 (window_box_height, window_box_left_offset)
4670 (window_box_right_offset, window_box_left, window_box_right)
4671 (window_box): No longer inline.
4672
105216ed
CY
46732011-11-08 Chong Yidong <cyd@gnu.org>
4674
4675 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4676 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4677 Signal an error if not a live window.
105216ed
CY
4678 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4679 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4680
ae9e237f
JB
46812011-11-07 Juanma Barranquero <lekktu@gmail.com>
4682
4683 * lisp.h (syms_of_abbrev): Remove declaration.
4684 Reported by CHENG Gao <chenggao@royau.me>.
4685
c7aa8333
EZ
46862011-11-07 Eli Zaretskii <eliz@gnu.org>
4687
4688 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4689 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4690 of temacs in GUI mode.
4691
be7f5545
MR
46922011-11-07 Martin Rudalics <rudalics@gmx.at>
4693
4694 * window.h: Declare delete_all_child_windows instead of
4695 delete_all_subwindows.
4696 * window.c (Fwindow_nest, Fset_window_nest)
4697 (Fset_window_new_total, Fset_window_new_normal)
4698 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4699 (delete_all_subwindows): Rename to delete_all_child_windows.
4700 (Fdelete_other_windows_internal, Fset_window_configuration):
4701 Call delete_all_child_windows instead of delete_all_subwindows.
4702 * frame.c (delete_frame): Call delete_all_child_windows instead
4703 of delete_all_subwindows.
4704
ca78dc43
PE
47052011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4706
4707 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4708 This is also needed for porting to any host where GC_MARK_STACK is
4709 not GC_MAKE_GCPROS_NOOPS.
4710 (which_symbols): Use it.
4711
a0241d01
KH
47122011-11-07 Kenichi Handa <handa@m17n.org>
4713
4714 * coding.c (coding_set_destination): Check coding->src_pos only
4715 when coding->src_object is a buffer (bug#9910).
4716
4717 * process.c (send_process): Set the member src_multibyte of coding
4718 to 0 (bug#9911) when sending a unibyte text.
4719
4720 * callproc.c (Fcall_process): Set the member src_multibyte of
4721 process_coding to 0 (bug#9912).
4722
a64bfdfa 47232011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4724
4725 * xmenu.c (cleanup_widget_value_tree): New function.
4726 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4727 calling free_menubar_widget_value_tree directly (Bug#9830).
4728
cb41b32a
PE
47292011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4730
4731 Fix some portability problems with 'inline'.
4732 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4733 (window_box_width, window_box_left, window_box_left_offset)
4734 (window_box_right, window_box_right_offset): Declare extern.
4735 Otherwise, these inline functions do not conform to C99 and
4736 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4737 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4738 * intervals.c (adjust_intervals_for_insertion)
4739 (adjust_intervals_for_deletion): Now extern, because otherwise the
4740 extern inline functions 'offset_intervals' couldn't refer to it.
4741 (static_offset_intervals): Remove.
4742 (offset_intervals): Rewrite using the old contents of
4743 static_offset_intervals. The old version didn't conform to C99
4744 because an extern inline function contained a reference to an
4745 identifier with static linkage.
4746
b7041366
AS
47472011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4748
4749 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4750 GC.
4751
88a37c4d
EZ
47522011-11-06 Eli Zaretskii <eliz@gnu.org>
4753
4754 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4755 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4756 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4757 return Qleft_to_right.
4758
49745b39
CY
47592011-11-06 Chong Yidong <cyd@gnu.org>
4760
4761 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4762 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4763 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4764 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4765 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4766 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4767 (Fwindow_vscroll): Doc fix.
4768 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4769 argument, since it makes no sense to pass a live window and for
4770 consistency with window-child.
4771
1f05cd82
CS
47722011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4773
4774 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4775 support MSVC.
4776
22610910
JR
47772011-11-05 Jason Rumney <jasonr@gnu.org>
4778
4779 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4780 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4781 fonts (Bug#6029).
4782 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4783 bitwise arithmetic preventing use of unicode-sip and non-truetype
4784 opentype fonts.
4785
a06776b2
EZ
47862011-11-05 Eli Zaretskii <eliz@gnu.org>
4787
3ad924ba
EZ
4788 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4789 "emacs"-only part.
4790
a06776b2
EZ
4791 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4792 initialization code to keep similarity to xfns.c after changes
4793 from 2011-11-05.
4794
c9e7db78
JD
47952011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4796
a97f8f3f
JD
4797 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4798 (unwind_create_frame): New function (Bug#9943).
4799 (Fx_create_frame): Restructure code to be more similar to the one in
4800 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4801 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4802 Move terminal->reference_count++ just before making the frame official
4803 (Bug#9943).
4804
4805 * nsterm.m (x_free_frame_resources): New function.
4806 (x_destroy_window): Move code to x_free_frame_resources.
4807
c9e7db78 4808 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4809 (Fx_create_frame, x_create_tip_frame):
4810 Move terminal->reference_count++ just before making the frame
75f1671a 4811 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4812 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4813
a6fc3b5c
EZ
48142011-11-05 Eli Zaretskii <eliz@gnu.org>
4815
4816 Support MSVC build with newer versions of Visual Studio.
4817 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4818 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4819 nt/gmake.defs.
4820
4821 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4822 which are not supported by MSVC.
4823 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4824 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4825 bitfields.
4826 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4827 types in bitfields.
4828 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4829
4830 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4831
58179cce 48322011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4833
4834 Support MSVC build with newer versions of Visual Studio.
4835 * w32.c: Don't include w32api.h for MSVC.
4836 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4837
4838 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4839 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4840 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4841 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4842 e_* cousins.
4843 (alloca) [_MSC_VER]: Define to _alloca.
4844
4845 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4846
4847 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4848
a58c13ed
EZ
48492011-11-04 Eli Zaretskii <eliz@gnu.org>
4850
4851 * xdisp.c (note_mouse_highlight): If either of
4852 previous/next-single-property-change returns nil, treat that as
4853 the beginning or the end of the buffer. (Bug#9955)
4854
fe0b6370
JD
48552011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4856
a58c13ed 4857 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4858 label is not null (Bug#9951).
4859 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4860 may be NULL.
4861
89bd5ee1
EZ
48622011-11-04 Eli Zaretskii <eliz@gnu.org>
4863
4864 * window.c (Fwindow_body_size): Mention in the doc string that the
4865 return value is in frame's canonical units. (Bug#9949)
4866
84c3edb9
EZ
48672011-11-03 Eli Zaretskii <eliz@gnu.org>
4868
4e2fb5c7
EZ
4869 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4870
84c3edb9 4871 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4872 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4873 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4874
bc17a887
EZ
48752011-11-01 Eli Zaretskii <eliz@gnu.org>
4876
4877 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4878 Don't stop backward scan on the continuation glyph, even though
4879 its CHARPOS is positive.
6d5eb5b0
SM
4880 (mouse_face_from_buffer_pos, note_mouse_highlight):
4881 Rename cover_string to disp_string.
bc17a887 4882
4ee88440
MR
48832011-11-01 Martin Rudalics <rudalics@gmx.at>
4884
4885 * window.c (temp_output_buffer_show): Don't use
4886 Vtemp_buffer_show_specifiers.
4887 (Vtemp_buffer_show_specifiers): Remove unused variable.
4888
c2ff3c02
EZ
48892011-10-30 Eli Zaretskii <eliz@gnu.org>
4890
4891 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4892 past the beginning of the current glyph matrix.
4893
58179cce 48942011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4895
4896 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4897 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4898 HAVE_GTK3 (Bug#9869).
b77a6a7f 4899
3b574623
JD
4900 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4901 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4902
b77a6a7f
JD
4903 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4904
4905 * xterm.c: Declare x_handle_net_wm_state to return int.
4906 (handle_one_xevent): Check if we are iconified but don't have
4907 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4908 (get_current_wm_state): Return non-zero if not hidden,
4909 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4910 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4911 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4912 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4913
196e41e4
PE
49142011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4915
4916 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4917 so that this new function doesn't get optimized away by a
4918 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4919
021f2e1a
AS
49202011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4921
4922 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4923
8b058d44
EZ
49242011-10-29 Eli Zaretskii <eliz@gnu.org>
4925
4926 Fix the `xbytecode' command.
4927 * .gdbinit (xprintbytestr): New command.
b50a28de 4928 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4929 (xbytecode): Print the byte-code string as well.
4930
4452fb80
EZ
49312011-10-29 Kim Storm <storm@cua.dk>
4932
8b058d44
EZ
4933 * alloc.c (which_symbols): New function.
4934
21b72067
AS
49352011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4936
4937 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4938 line. (Bug#9903)
4939
83ed7b5c
GM
49402011-10-29 Glenn Morris <rgm@gnu.org>
4941
4942 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4943 Not clear what it was for, and it causes various bugs. (Bug#9839)
4944
5a7a728b
EZ
49452011-10-28 Eli Zaretskii <eliz@gnu.org>
4946
4947 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4948 possible random value that matches one of those tested as
4949 condition to clear the mouse face.
4950
d3d0842f
CY
49512011-10-28 Chong Yidong <cyd@gnu.org>
4952
4953 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4954
31b39d13
DN
49552011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4956
4957 * window.c (make_window): Initialize phys_cursor_on_p.
4958
9aba6043
SM
49592011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4960
4961 * lisp.h (struct Lisp_Symbol): Update comments.
4962
c20992f4
JB
49632011-10-28 Juanma Barranquero <lekktu@gmail.com>
4964
4965 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4966
db4f02f2
EZ
49672011-10-28 Eli Zaretskii <eliz@gnu.org>
4968
4969 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4970 <oslsachem@gmail.com> for helping to debug this.
4971
4972 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4973 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4974 (g_b_init_get_glyph_outline_w): New static variables.
4975 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4976 (GetGlyphOutlineW_Proc): New typedefs.
4977 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4978 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4979 New functions.
4980 (w32font_open_internal, compute_metrics):
4981 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4982 instead of calling the "wide" APIs directly.
4983
4984 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4985
4986 * w32.h (syms_of_w32font): Add prototype.
4987
87e68db4
JB
49882011-10-27 Juanma Barranquero <lekktu@gmail.com>
4989
4990 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4991 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4992 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4993 (Fmove_to_window_line): Doc fix.
4994
435c1d67
CY
49952011-10-27 Chong Yidong <cyd@gnu.org>
4996
4997 * process.c (make_process): Set gnutls_state to NULL.
4998
4999 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5000 non-NULL, regardless of GNUTLS_INITSTAGE.
5001 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5002 an error. Set process slots as soon as we allocate them.
5003
5004 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5005
9c6c6f49
CY
50062011-10-27 Chong Yidong <cyd@gnu.org>
5007
9aba6043
SM
5008 * gnutls.c (emacs_gnutls_deinit): New function.
5009 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5010 (Fgnutls_deinit, Fgnutls_boot): Use it.
5011
5012 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5013 (deactivate_process): Call emacs_gnutls_deinit.
5014
657d08d3
JB
50152011-10-27 Juanma Barranquero <lekktu@gmail.com>
5016
5017 * image.c (x_create_x_image_and_pixmap):
5018 * w32.c (sys_rename, w32_delayed_load):
5019 * w32font.c (fill_in_logfont):
5020 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5021
5430d399
JB
50222011-10-26 Juanma Barranquero <lekktu@gmail.com>
5023
5024 * w32fns.c (w32_default_color_map): New function,
5025 extracted from Fw32_default_color_map.
a7ef684b 5026 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5027
fe0055fa
PE
50282011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5029
5030 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5031
e6346438
SM
50322011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5033
5034 * keyboard.c (test_undefined): New function (bug#9751).
5035 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5036
e112cc37
ET
50372011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5038
5039 * sysdep.c (init_sys_modes): Fix the check for the controlling
5040 terminal (Bug#6649).
5041
7b5d6677
EZ
50422011-10-20 Eli Zaretskii <eliz@gnu.org>
5043
5044 * dispextern.h (struct bidi_it): New member next_en_type.
5045
5046 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5047 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5048 current character, check also for next_en_type being WEAK_EN.
5049 (bidi_resolve_weak): Don't enter the expensive loop if the current
5050 position is before next_en_pos. Record the bidi type of the first
5051 non-ET, non-BN character we find, in addition to its position.
5052 (bidi_level_of_next_char): Invalidate next_en_type when
5053 next_en_pos is over-stepped.
5054
7da0b018
PE
50552011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5056
5057 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5058 * editfns.c: Rewrite current-time-zone so that it invokes
5059 the equivalent of (format-time-string "%Z") to get the time zone name.
5060 This fixes a bug when the time zone name contains characters that
5061 need converting from the system time locale to Emacs internal format.
5062 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5063 that patch fixed format-time-string to do the conversion, but
5064 I forgot to fix current-time-zone.
5065 (format_time_string): New function, containing most of
5066 what Fformat_time_string used to contain.
5067 (Fformat_time_string): Rewrite in terms of format_time_string.
5068 This doesn't change this function's behavior.
5069 (current-time-zone): Rewrite to use format_time_string.
5070 This fixes the bug reported by Michael Schierl in
5071 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5072 Jason Rumney's 2007-06-07 change worked around this bug, but
5073 didn't fix it.
5074 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5075
8547b010
EZ
50762011-10-19 Eli Zaretskii <eliz@gnu.org>
5077
5078 * xdisp.c (start_display): If the character at POS is displayed
5079 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5080 (try_window_reusing_current_matrix): If a line ends in a display
5081 vector or the next line starts in a display vector, continue
5082 redrawing the window even though the character position of
5083 start_row was reached.
8547b010
EZ
5084 (Bug#9771, part 2)
5085
4e948d15
CY
50862011-10-18 Chong Yidong <cyd@gnu.org>
5087
5088 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5089 with nobreak-char-display too.
5090
4787455f
EZ
50912011-10-18 Eli Zaretskii <eliz@gnu.org>
5092
5093 Fix part 3 of bug#9771.
5094 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5095 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5096 non-neutral characters if the current character is a paragraph
5097 separator (a.k.a. Newline). This avoids running the same
5098 expensive loop twice, once when we consume the preceding newline
5099 and the other time when the line actually needs to be displayed.
5100 Avoid the loop when we see neutrals on the base embedding level
5101 following a character whose directionality is the same as the
5102 paragraph's. This avoids running the expensive loop when a line
5103 ends in a long sequence of neutrals, like control characters.
5104 Add assertion against STRONG_AL type. Slightly rearrange code
5105 that determines the type of a neutral given the first non-neutral
5106 that follows it.
5107 (bidi_level_of_next_char): Set next_en_pos to zero when
5108 invalidating its info.
5109
2c91f553
EZ
51102011-10-17 Eli Zaretskii <eliz@gnu.org>
5111
5112 * xdisp.c (push_display_prop): Determine whether to record string
5113 or buffer position by IT->string, not by IT->method. Allow
5114 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5115 (move_it_vertically_backward): Don't look for character position
5116 immediately after the newline when in a continuation line.
5117 (Bug#9771, part 1)
2c91f553 5118
c7b08b0d
MR
51192011-10-15 Martin Rudalics <rudalics@gmx.at>
5120
5121 * window.c (coordinates_in_window): Rewrite and delabelize
5122 vertical border check. (Bug#5357) (Bug#9618)
5123
6b02f655
SM
51242011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5125
5126 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5127 errors in XSetWindowBorder (bug#9310).
5128
81d40c92
DA
51292011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5130
5131 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5132 avoid crash when xmalloc overrun checking is enabled.
5133
d4172c3b
EZ
51342011-10-13 Eli Zaretskii <eliz@gnu.org>
5135
5136 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5137 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5138 cursor motion with <left> and <right> arrow keys.
5139
5140 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5141 some callers set that themselves.
5142
b00eea75
EZ
51432011-10-12 Eli Zaretskii <eliz@gnu.org>
5144
5145 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5146 display string and the previous row comes from the same string and
5147 is empty. (Bug#9739) (Bug#9738)
5148
8fe012c4
SM
51492011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5150
5151 * doc.c (get_doc_string): Encode file name (bug#9735).
5152
0074aef2
EZ
51532011-10-12 Eli Zaretskii <eliz@gnu.org>
5154
79beb178
EZ
5155 * bidi.c (bidi_level_of_next_char):
5156 * xdisp.c (get_visually_first_element): Remove old incorrect
5157 comments regarding the Unicode Line Separator character.
5158
0074aef2
EZ
5159 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5160
6e4b3fbe
DA
51612011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5162
5163 * alloc.c (Fgc_status): Do not access beyond zombies array
5164 boundary if nzombies > MAX_ZOMBIES.
5165 * alloc.c (dump_zombies): Add missing format specifier.
5166
0324f3af
PE
51672011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5168
b5525cac
PE
5169 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5170 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5171
0324f3af
PE
5172 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5173 Some packages use them to denote characters with modifiers.
5174
e9b5f888
AS
51752011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5176
5177 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5178 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5179 matching a pp-number. Rename parameter var to var1.
5180
127827c0
SM
51812011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5182
5183 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5184
c8fd3bd0
GM
51852011-10-08 Glenn Morris <rgm@gnu.org>
5186
5187 * callint.c (Fcall_interactively): Give a more explicit error for the
5188 'c' case with a non-character input. (Bug#8479)
5189
352ec8ff
EZ
51902011-10-08 Eli Zaretskii <eliz@gnu.org>
5191
03669ccb
EZ
5192 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5193 lines.
7061c986
EZ
5194 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5195 lines that are hscrolled on the left.
03669ccb 5196
352ec8ff
EZ
5197 * dispnew.c (buffer_posn_from_coords): Account for a possible
5198 presence of header-line. (Bug#4426)
5199
a66cfb1c
SM
52002011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5201
6b02f655
SM
5202 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5203 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5204
7c5ee88e
PE
52052011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5206
5207 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5208 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5209 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5210 this makes Emacs dump core during garbage collection on rare
5211 occasions. sizeof is obviously inferior to offsetof here, so
5212 stick with offsetof.
5213 (GC_POINTER_ALIGNMENT): New macro.
5214 (mark_memory): Omit 3rd (offset) arg; caller changed.
5215 Don't assume EMACS_INT alignment is the same as pointer alignment.
5216
df1bbe5b
SM
52172011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5218
5219 * keyboard.c (read_key_sequence_remapped): New var.
5220 (read_key_sequence): Compute remapping in the right buffer.
5221 (command_loop_1): Use read_key_sequence's remapping directly.
5222
51553db6
SM
52232011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5224
32c1fffd
SM
5225 * dired.c (file_name_completion): Don't expand file name.
5226 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5227 before checking file name handler.
5228
51553db6
SM
5229 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5230 they've been requested explicitly (bug#9591).
5231
b6bd1599 52322011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5233
5234 * keymap.c (Fsingle_key_description): Use make_specified_string
5235 instead of build_string to build string from push_key_description.
5236 (Bug#5193)
5237
f701dc2a
PE
52382011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5239
4222c55d
PE
5240 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5241 This fixes a Y2038 bug on 64-bit hosts.
5242 * buffer.c (reset_buffer):
5243 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5244 (Fclear_buffer_auto_save_failure):
5245 Use 0, not -1, to represent an unset failure time, since time_t
5246 might not be signed.
5247
f701dc2a
PE
5248 Remove dependency on glibc malloc internals.
5249 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5250 Move back here from lisp.h, but with their new implementations.
5251 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5252 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5253 * charset.c (charset_table_init): New static var.
5254 (syms_of_charset): Use it instead of xmalloc. This removes a
5255 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5256 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5257 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5258 Move back to alloc.c.
5259 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5260 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5261
9ceebf39
JD
52622011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5263
5264 * nsterm.m (windowDidResize): Call x_set_window_size only when
5265 ns_in_resize is true. Otherwise set pixelwidth/height and
5266 call change_frame_size (Bug#9628).
5267
cb993c58
PE
52682011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5269
3930c88b
PE
5270 Port --enable-checking=all to Fedora 14 x86-64.
5271 * charset.c (syms_of_charset): Also account for glibc malloc's
5272 internal overhead when calculating the initial malloc maximum.
5273
cb993c58
PE
5274 Port --enable-checking=all to Fedora 14 x86.
5275 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5276 Move to lisp.h.
5277 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5278 (overrun_check_realloc, overrun_check_free):
5279 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5280 That way, xmalloc returns a properly-aligned pointer even if
5281 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5282 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5283 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5284 into account when calculating the initial malloc maximum.
5285 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5286 Move here from alloc.c, so that charset.c can use it too.
5287 Properly align; the old code wasn't right for common 32-bit hosts
5288 when configured with --enable-checking=all.
5289 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5290 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5291
31bed486
EZ
52922011-09-29 Eli Zaretskii <eliz@gnu.org>
5293
04c70788 5294 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5295 use EDOM.
5296
fbcaa2f3
EZ
52972011-09-28 Eli Zaretskii <eliz@gnu.org>
5298
5299 * xdisp.c (compute_display_string_end): If there's no display
5300 string at CHARPOS, return -1.
5301
5302 * bidi.c (bidi_fetch_char): When compute_display_string_end
5303 returns a negative value, treat the character as a normal
5304 character not covered by a display string. (Bug#9624)
5305
a239d4e9
JB
53062011-09-28 Juanma Barranquero <lekktu@gmail.com>
5307
5308 * lread.c (Fread_from_string): Fix typo in docstring.
5309
88652fd5
EZ
53102011-09-27 Eli Zaretskii <eliz@gnu.org>
5311
5312 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5313 newline, reseat the iterator instead of bidi-iterating there one
5314 character at a time. (Bug#9610)
32c1fffd
SM
5315 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5316 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5317
ed497dd4
AS
53182011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5319
5320 * lread.c (readevalloop): Use correct code for NBSP.
5321 (read1): Likewise. (Bug#9608)
5322
b2bf61aa
MA
53232011-09-25 Michael Albinus <michael.albinus@gmx.de>
5324
5325 * dbusbind.c (Fdbus_register_signal): When service is not
5326 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5327
32bbb17c
GM
53282011-09-25 Glenn Morris <rgm@gnu.org>
5329
5330 * buffer.c (truncate-lines): Doc fix.
5331
94e0933e
CY
53322011-09-24 Chong Yidong <cyd@stupidchicken.com>
5333
5334 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5335 (Fset_window_next_buffers): Doc fix.
5336
cddde921
GM
53372011-09-24 Glenn Morris <rgm@gnu.org>
5338
5339 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5340
1260aef1
PE
53412011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5342
25b4bfa0
PE
5343 Fix minor problems found by static checking.
5344 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5345 * indent.c (Fvertical_motion): Fix == vs = typo.
5346
e3cbd34b
EZ
53472011-09-24 Eli Zaretskii <eliz@gnu.org>
5348
a66cfb1c
SM
5349 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5350 Default value is now t. Doc fix.
6bf7006f 5351
e3cbd34b 5352 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5353 logic when moving up, not only when moving down. Fix the
e3cbd34b 5354 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5355 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5356
5357 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5358 CHARPOS is covered by a display string which includes newlines.
5359 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5360 is covered by a display string with embedded newlines.
5361
a3de0cbd
MA
53622011-09-24 Michael Albinus <michael.albinus@gmx.de>
5363
5364 * dbusbind.c (Fdbus_register_signal): Add match rule to
5365 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5366 (Fdbus_register_method, Vdbus_registered_objects_table):
5367 Fix docstring.
a3de0cbd 5368
b260039d
JM
53692011-09-24 Jim Meyering <meyering@redhat.com>
5370
32c1fffd 5371 do not ignore write error for any output size
b260039d
JM
5372 The previous change was incomplete.
5373 While it makes emacs --batch detect the vast majority of stdout
5374 write failures, errors were still ignored whenever the output size is
5375 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5376 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5377 && echo FAIL: ignored write error
5378 FAIL: ignored write error
5379 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5380 && echo FAIL: ignored write error
5381 FAIL: ignored write error
5382 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5383
8eca8a7c
AS
53842011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5385
5386 * emacs.c (Fkill_emacs): In noninteractive mode exit
5387 non-successfully if a write error occurred on stdout. (Bug#9574)
5388
3341db62
EZ
53892011-09-21 Eli Zaretskii <eliz@gnu.org>
5390
5391 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5392 the xassert test.
5393
5394 * dispextern.h (struct it): Update the comment documenting what
5395 can it->OBJECT be.
5396
8c203dbf
EZ
53972011-09-20 Eli Zaretskii <eliz@gnu.org>
5398
5399 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5400 a display string, extend search for cursor position to end of row.
5401 (find_row_edges): If the row ends in a newline from a display
5402 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5403 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5404 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5405 non-empty line. Fixes confusing cursor motion with arrow keys at
5406 the beginning of a line that starts with whitespace.
8c203dbf 5407
a4824228
LMI
54082011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5409
5410 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5411 (bug#9493).
5412
33ed493b
CY
54132011-09-18 Chong Yidong <cyd@stupidchicken.com>
5414
5415 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5416 boolean (Bug#9154).
5417
56cd55c8
EZ
54182011-09-18 Eli Zaretskii <eliz@gnu.org>
5419
5420 * xdisp.c (display_line): Record maximum and minimum buffer
5421 positions even if no glyphs were produced (e.g., by a zero-width
5422 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5423 buffer positions that will be removed from the glyph row because
5424 they don't fit.
c02dcedf
EZ
5425 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5426 column is beyond frame width: don't subtract 1 "pixel" when
5427 computing width of the stretch.
3e62b7e0
EZ
5428 (reseat_at_next_visible_line_start): Undo the change made on
5429 2011-09-17 that saved paragraph information and restored it after
5430 the call to `reseat'. (Bug#9545)
56cd55c8 5431
5ed99d36 54322011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5433
5434 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5435 and turn window cursor on if cleared (Bug#9415).
5436
5ed99d36 54372011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5438
5439 * search.c (boyer_moore): Take unibyte characters from pattern
5440 literally. (Bug#9458)
5441
9bade7b2
EZ
54422011-09-18 Eli Zaretskii <eliz@gnu.org>
5443
5444 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5445
e5e9d610
PE
54462011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5447
87e4427a
PE
5448 Fix minor problem found by static checking.
5449 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5450 initialized, to pacify gcc -Wuninitialized.
5451
e5e9d610
PE
5452 * fileio.c: Report proper errno when syscall falls.
5453 (Finsert_file_contents): Save and restore errno,
5454 so that report_file_error outputs the correct diagnostic.
5455 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5456
a1674f0b
EZ
54572011-09-18 Eli Zaretskii <eliz@gnu.org>
5458
5459 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5460
fbfb6dd4
EZ
54612011-09-17 Eli Zaretskii <eliz@gnu.org>
5462
5463 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5464 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5465
bb187662
EZ
54662011-09-17 Eli Zaretskii <eliz@gnu.org>
5467
1137e8b8 5468 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5469 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5470
5471 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5472 (bidi_find_paragraph_start): Search back for paragraph beginning
5473 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5474 (bidi_move_to_visually_next): Only trigger paragraph-related
5475 computations when the last character is a newline or at EOB, not
5476 just any NEUTRAL_B. (Bug#9470)
5477
bb187662
EZ
5478 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5479 truncated lines if point is covered by a display string. (Bug#9524)
5480
2e621251
PE
54812011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5482
5483 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5484 (cons_to_x_long): New function.
5485 (lisp_data_to_selection_data): Use it. Correct the test for
5486 short-versus-long data; it was negated. Break out of vector
5487 loop, for efficiency, when a long datum is discovered.
5488
91a15bc6
SM
54892011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5490
5491 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5492
b41c3a35
EZ
54932011-09-16 Eli Zaretskii <eliz@gnu.org>
5494
5495 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5496 GCC PR/17406) by declaring this function with external scope.
5497
7812ba2d
PE
54982011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5499
5500 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5501 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5502
cf7edc2a
AS
55032011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5504
5505 * editfns.c (Fformat): Correctly handle text properties on "%%".
5506
bd01620e
EZ
55072011-09-15 Eli Zaretskii <eliz@gnu.org>
5508
5509 * xterm.c (x_draw_composite_glyph_string_foreground):
5510 * w32term.c (x_draw_composite_glyph_string_foreground):
5511 * term.c (encode_terminal_code):
5512 * composite.c (composition_update_it, get_composition_id):
5513 * xdisp.c (get_next_display_element)
5514 (fill_composite_glyph_string): Add comments about special meaning
5515 of TAB characters in a composition.
5516
a02719a3
PE
55172011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5518
5519 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5520 This occurs when processing a multibyte format.
5521 Problem reported by Wolfgang Jenker.
a02719a3 5522
72589a3c
JB
55232011-09-15 Johan Bockgård <bojohan@gnu.org>
5524
5525 * xdisp.c (try_cursor_movement): Only check for exact match if
5526 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5527
1c14176c
PE
55282011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5529
5530 Remove unused external symbols.
5531 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5532 * xdisp.c (calc_pixel_width_or_height): Now static.
5533 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5534 * indent.c (check_display_width):
5535 * w32term.c: Fix comment to match code.
5536 * xterm.c, xterm.h (x_catching_errors): Remove.
5537
d2eea5b5
PE
55382011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5539
5540 * xselect.c: Use signed conversions more consistently (Bug#9498).
5541 (selection_data_to_lisp_data): Assume incoming selection data are
5542 signed integers, not unsigned. This is to be consistent with
5543 outgoing selection data, which was modified to use signed integers
5544 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5545 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5546 expects long, not unsigned long.
5547
46888499
EZ
55482011-09-14 Eli Zaretskii <eliz@gnu.org>
5549
5550 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5551 computation of loop end. Reported by Johan Bockgård
5552 <bojohan@gnu.org>.
5553
ef8ef9fb
CY
55542011-09-13 Chong Yidong <cyd@stupidchicken.com>
5555
5556 * frame.c (Fother_visible_frames_p): Function deleted.
5557
fa819fed
EZ
55582011-09-12 Eli Zaretskii <eliz@gnu.org>
5559
5560 * indent.c (compute_motion): Process display vector front to back
5561 rather than the other way around. (Bug#2496)
5562
2ba8e008
SM
55632011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5564
5565 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5566
20f53c69
CY
55672011-09-11 Chong Yidong <cyd@stupidchicken.com>
5568
5569 * minibuf.c (Fread_from_minibuffer): Doc fix.
5570
d562d7a4
EZ
55712011-09-11 Eli Zaretskii <eliz@gnu.org>
5572
5573 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5574 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5575
1c4d7f3d
LMI
55762011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5577
5578 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5579 value for non-existent files.
5580
b885bf36
EZ
55812011-09-11 Eli Zaretskii <eliz@gnu.org>
5582
5583 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5584 set its "size" to -1. This will set the modtime_size field of
5585 the corresponding buffer to -1, which is what
5586 verify-visited-file-modtime expects for files that do not exist.
5587 (Bug#9139)
5588
6612f0bf
PE
55892011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5590
5591 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5592 here ...
5593 * lisp.h: ... from here. push_key_description is no longer
5594 defined in keyboard.c, so its declaration should not be in
5595 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5596 logically belongs with push_key_description.
5597
dfb3f755
PE
55982011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5599
5600 * buffer.h: Include <sys/types.h> instead of <time.h>.
5601 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5602 Problem reported by Herbert J. Skuhra.
5603
3134906c
LMI
56042011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5605
5606 * xml.c (parse_region): Make the parsing work for
5607 non-comment-starting XML files again (bug#9144).
5608
8d903f4e
AS
56092011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5610
5611 * image.c (gif_load): Fix calculation of bottom and right corner.
5612 (Bug#9468)
5613
80ad64f4
EZ
56142011-09-10 Eli Zaretskii <eliz@gnu.org>
5615
5616 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5617 redisplay in small windows.
5618
208a048d
EZ
56192011-09-09 Eli Zaretskii <eliz@gnu.org>
5620
5621 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5622
9b1c252e
MR
56232011-09-08 Martin Rudalics <rudalics@gmx.at>
5624
5625 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5626 Operate on live windows only.
5627
2949f33b
JB
56282011-09-08 Juanma Barranquero <lekktu@gmail.com>
5629
5630 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5631
e08dcafd
EZ
56322011-09-07 Eli Zaretskii <eliz@gnu.org>
5633
5634 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5635 only under bidi iteration.
5636
115b96bd
JD
56372011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5638
5639 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5640
c8199d0f
PE
56412011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5642
5643 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5644 Without this fix, the command to link temacs failed due to an
5645 undefined symbol __builtin_isnan. This is because
5646 /usr/include/iso/math_c99.h #defines isnan(x) to
5647 __builtin_isnan(x), but the bundled gcc, which identifies itself
5648 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5649 a __builtin_isnan.
5650 * floatfns.c (isnan): #undef, and then #define to a clone of
5651 what's in data.c.
5652 (Fisnan): Always define, since it's always available now.
5653 (syms_of_floatfns): Always define isnan at the Lisp level.
5654
e39b275c 56552011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5656
5657 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5658
b2db44d9 56592011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5660
f4af5137 5661 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5662 The previous code assumed that file offsets (off_t values) fit in
5663 EMACS_INT variables, which is not true on typical 32-bit hosts.
5664 The code messed up by falsely reporting buffer overflow in cases
5665 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5666 when "big" contains more than 2**29 bytes, even though this
5667 inserts just one byte and does not overflow the buffer.
5668 (Finsert_file_contents): Store file offsets as off_t
5669 values, not as EMACS_INT values. Check for overflow when
5670 converting between EMACS_INT and off_t. When checking for
5671 buffer overflow or for overlap, take the offsets into account.
5672 Don't use EMACS_INT for small values where int suffices.
5673 When checking for overlap, fix a typo: ZV was used where
5674 ZV_BYTE was intended.
5675 (Fwrite_region): Don't assume off_t fits into 'long'.
5676 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5677
ecfc0a49
MA
56782011-09-05 Michael Albinus <michael.albinus@gmx.de>
5679
5680 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5681
6511acf2 56822011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5683
0999621a 5684 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5685
5686 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5687 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5688 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5689 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5690 (modify_event_symbol): Do not assume that the length of
5691 name_alist_or_stem is safe to alloca and fits in int.
5692 (Fexecute_extended_command): Likewise for function name and binding.
5693 (Frecursion_depth): Wrap around reliably on integer overflow.
5694 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5695 since some callers pass EMACS_INT values.
5696 (Fsingle_key_description): Don't crash if symbol name contains more
5697 than MAX_ALLOCA bytes.
5698 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5699 (get_minibuffer): Arg is now EMACS_INT, not int.
5700 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5701 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5702 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5703
2be7d702
PE
5704 * dbusbind.c (signature_cat): New function.
5705 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5706 Do not overrun buffer; instead, report string overflow.
5707
9d1df220
PE
5708 * dispnew.c (add_window_display_history): Don't overrun buffer.
5709 Truncate instead; this is OK since it's just a log.
5710
33ef5c64
PE
5711 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5712 even if the time zone offset is outlandishly large.
5713 Don't mishandle offset == INT_MIN.
5714
66c6fdd5
PE
5715 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5716 when creating daemon; the previous buffer-overflow check was incorrect.
5717
d749b01b
PE
5718 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5719 which has the guts of the old verror function.
5720
b5cd1905
PE
5721 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5722 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5723
6e1a67fb
PE
5724 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5725 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5726 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5727 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5728 length of string rather than counting it via multiple sprintfs;
5729 that's simpler and more reliable.
c21721cc
PE
5730 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5731 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5732 sprintf, in case result does not fit in int.
5733
c57b67fc
PE
5734 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5735 (fontset_from_font): Print it.
5736
8a401434
PE
5737 * frame.c (tty_frame_count): Now printmax_t, not int.
5738 (make_terminal_frame, set_term_frame_name): Print it.
5739 (x_report_frame_params): In X, window IDs are unsigned long,
5740 not signed long, so print them as unsigned.
5741 (validate_x_resource_name): Check for implausibly long names,
5742 and don't assume name length fits in 'int'.
5743 (x_get_resource_string): Don't blindly alloca invocation name;
5744 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5745 not fit in int.
5746
6e1a67fb
PE
5747 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5748 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5749 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5750
0df02bf3
PE
5751 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5752 Use esprintf, not sprintf, in case result does not fit in int.
5753
48e30793
PE
5754 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5755 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5756 it as a large positive number.
5757 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5758 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5759
a66ff6d8
PE
5760 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5761 in case result does not fit in int.
5762
aca216ff
PE
5763 * print.c (float_to_string): Detect width overflow more reliably.
5764 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5765 buffer overrun. Don't assume list length fits in 'int'. Treat
5766 print length of 0 as 0, not as infinity; to be consistent with other
5767 uses of print length in this function. Don't overflow print length
5768 index. Don't assume hash table size fits in 'long', or that
5769 vectorlike size fits in 'unsigned long'.
5770
31c286f7
PE
5771 * process.c (make_process): Use printmax_t, not int, to format
5772 process-name gensyms.
5773
55e5faa1
PE
5774 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5775
80f2e268
PE
5776 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5777 to avoid potential buffer overrun.
5778
670741ab
PE
5779 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5780 if X resource line is longer than 512 bytes.
5781
b7163a50
PE
5782 * xfns.c (x_window): Make sprintf buffer a bit bigger
5783 to avoid potential buffer overrun.
5784
ae58ff1f
PE
5785 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5786
c43c8a6a
PE
5787 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5788
3f8236f4
PE
57892011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5790
53e9fe90 5791 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5792 Without these, Emacs silently mishandles large integers sometimes.
5793 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5794 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5795
6511acf2
PE
5796 * xdisp.c (try_window_id): Check Emacs fixnum range before
5797 converting to 'int'.
806add1d 5798
6511acf2 5799 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5800 Check that an Emacs fixnum is in range before assigning it to 'int'.
5801 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5802 values converted from Emacs fixnums.
5803 (Frecenter): Don't wrap around a line count if it is out of 'int'
5804 range; instead, treat it as an extreme value.
5805 (Fset_window_configuration, compare_window_configurations):
5806 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5807
6511acf2
PE
5808 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5809 that can exceed INT_MAX. Check that EMACS_INT value is in range
5810 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5811 (match_limit): Don't assume that a fixnum can fit in 'int'.
5812
6511acf2 5813 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5814 exceed INT_MAX.
5815
6511acf2 5816 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5817 (Fvertical_motion): Don't wrap around LINES values that don't fit
5818 in 'int'. Instead, treat them as extreme values. This is good
5819 enough for windows, which can't have more than INT_MAX lines anyway.
5820
fcb901a7
LMI
58212011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5822
0f2f6b6d
LMI
5823 * Require libxml/parser.h to avoid compilation warning.
5824
fcb901a7
LMI
5825 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5826
5827 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5828 since this reportedly can destroy thread storage.
5829
6e20a0d4
CY
58302011-08-30 Chong Yidong <cyd@stupidchicken.com>
5831
5832 * syntax.c (find_defun_start): Update all cache variables if
5833 exiting early (Bug#9401).
5834
148ae00e
EZ
58352011-08-30 Eli Zaretskii <eliz@gnu.org>
5836
f6cfbd8f
EZ
5837 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5838
148ae00e
EZ
5839 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5840 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5841 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5842
5843 * term.c (tty_append_glyph): New function.
5844 (produce_stretch_glyph): Static function and its prototype deleted.
5845
a66cfb1c
SM
5846 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5847 Add prototypes.
148ae00e 5848
c4a07a4c
PE
58492011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5850
5851 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5852 when checking :margin (Bug#9390).
5853 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5854 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5855 so that the name doesn't mislead. All uses changed.
5856
6bc8cd65
JB
58572011-08-28 Johan Bockgård <bojohan@gnu.org>
5858
5859 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5860 set_tty_hooks.
5861
dca4927e
EZ
58622011-08-27 Eli Zaretskii <eliz@gnu.org>
5863
5864 * xdisp.c (move_it_to): Don't bail out early when reaching
5865 position beyond to_charpos, if we are scanning backwards.
5866 (move_it_vertically_backward): When DY == 0, make sure we get to
5867 the first character in the line after the newline.
5868
f2cad773
PE
58692011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5870
5871 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5872 (ccl_driver): Do not generate an out-of-range pointer.
5873 (Fccl_execute_on_string): Remove unnecessary check for
5874 integer overflow, noted by Stefan Monnier in
5875 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5876 Remove a FIXME that didn't need fixing.
5877 Simplify the newly-introduced buffer reallocation code.
5878
0cae2cdb
JB
58792011-08-27 Juanma Barranquero <lekktu@gmail.com>
5880
5881 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5882
5fc295a4 58832011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5884
70c60eb2 5885 Integer and memory overflow issues (Bug#9196).
726e0ab1 5886
d31850da
PE
5887 * doc.c (get_doc_string): Rework so that
5888 get_doc_string_buffer_size is the actual buffer size, rather than
5889 being 1 less than the actual buffer size; this makes xpalloc more
5890 convenient.
5891
a69fbedb
PE
5892 * image.c (x_allocate_bitmap_record, cache_image):
5893 * xselect.c (Fx_register_dnd_atom):
5894 Simplify previous changes by using xpalloc.
5895
fe5c5d37
PE
5896 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5897 since either will do and ptrdiff_t is convenient with xpalloc.
5898
0065d054
PE
5899 * charset.c (charset_table_size)
5900 (struct charset_sort_data.priority): Now ptrdiff_t.
5901 (charset_compare): Don't overflow if priorities differ greatly.
5902 (Fsort_charsets): Don't assume list length fits in int.
5903 Check for size-calculation overflow when allocating sort data.
5904 (syms_of_charset): Allocate an initial charset table that is
5905 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5906
5907 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5908
5909 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5910 The actual value is always <= INT_MAX, and leaving it unsigned made
5911 overflow checking harder.
5912
5913 * dispextern.h (struct glyph_matrix.rows_allocated)
5914 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5915 with xpalloc. The values are still always <= INT_MAX.
5916
5917 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5918
5919 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5920 (SAFE_NALLOCA): New macro.
5921
5922 * region-cache.c (struct boundary.pos, find_cache_boundary)
5923 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5924 (set_cache_region, invalidate_region_cache)
5925 (revalidate_region_cache, know_region_cache, region_cache_forward)
5926 (region_cache_backward, pp_cache):
5927 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5928 so that ptrdiff_t * can be passed to xpalloc.
5929 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5930 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5931 (pp_cache): Don't assume cache_len fits in int.
5932 * region-cache.h: Adjust extern decls to match.
5933
5934 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5935 EMACS_INT, since either will do, for xpalloc.
5936
5937 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5938 (xnmalloc, xnrealloc, xpalloc): New functions.
5939
726e0ab1
PE
5940 * bidi.c (bidi_shelve_header_size): New constant.
5941 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5942 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5943
51f30bc5 5944 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5945 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5946 (overlay_strings):
5947 Don't update size of array until after memory allocation succeeds,
5948 because xmalloc/xrealloc may not return.
0065d054
PE
5949 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5950 now that we have proper integer overflow checking.
5951 (record_overlay_string, overlay_strings): Catch overflows when
5952 calculating size of overlay_str_buf.
726e0ab1 5953
0065d054
PE
5954 * callproc.c (Fcall_process): Check for size overflow when
5955 calculating size of args2.
5956 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5957 Normally we prefer signed values, but sticking with ptrdiff_t would
5958 require adding more-complicated checks.
726e0ab1
PE
5959
5960 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5961 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5962 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5963 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5964
5965 * character.c (Fstring): Check for size-calculation overflow.
5966
5967 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5968 unnecessary integer overflow. Check for size overflow.
5969 (encode_coding_object): Don't update size until xmalloc succeeds.
5970
5971 * composite.c (get_composition_id): Check for overflow in glyph
5972 length calculations.
5973
5974 Integer and memory overflow fixes for display code.
5975 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5976 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5977 (scrolling_window): Check for overflow in size calculations.
5978 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5979 Don't assume glyph table len fits in int.
5980 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5981 (row_table_size): Now ptrdiff_t, not int.
5982 (scrolling_window): Avoid overflow in size calculations.
5983 Don't update size until allocation succeeds.
5984 * fns.c (concat): Check for overflow in size calculations.
5985 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5986 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5987 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5988
5989 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5990 (get_doc_string): Check for size calculation overflow.
5991 Don't update size until allocation succeeds.
5992 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5993 EMACS_INT, where ptrdiff_t will do.
5994 (Fsubstitute_command_keys): Check for string overflow.
5995
5996 * editfns.c (set_time_zone_rule): Don't assume environment length
5997 fits in int.
5998 (message_length): Now ptrdiff_t, not int.
5999 (Fmessage_box): Don't update size until allocation succeeds.
6000 Don't assume message length fits in int.
6001 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6002
0065d054
PE
6003 * emacs.c (main): Do not reallocate argv, since there is a null at
6004 the end that can be overwritten, and this way there's no need to
6005 worry about size-calculation overflow.
6006 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6007
6008 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6009 alloc succeeds.
6010 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6011
6012 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6013 (x_set_scroll_bar_width, x_figure_window_size):
6014 Check for integer overflow.
6015 (x_set_alpha): Do not assume XINT fits in int.
6016
6017 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6018 This is for the members text_lines, text_cols, total_lines, total_cols,
6019 where the system imposes an 'int' limit.
6020
6021 * fringe.c (Fdefine_fringe_bitmap):
6022 Don't update size until alloc works.
6023
6024 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6025 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6026
6027 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6028 Check for size-calculation overflow.
6029 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6030 do, as we prefer signed integers.
6031 (id_to_widget.max_size, id_to_widget.used)
6032 (xg_store_widget_in_map, xg_remove_widget_from_map)
6033 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6034 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6035 Use and return ptrdiff_t, not int.
6036 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6037 * gtkutil.h: Change prototypes to match the above.
6038
6039 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6040 are duplicate now that they've been promoted to lisp.h.
6041 (x_allocate_bitmap_record, x_alloc_image_color)
6042 (make_image_cache, cache_image, xpm_load):
6043 Don't update size until alloc is done.
6044 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6045 (x_detect_edges):
3256efce 6046 Check for size calculation overflow.
726e0ab1
PE
6047 (ct_colors_allocated_max): New constant.
6048 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6049 overflow.
3256efce 6050
726e0ab1
PE
6051 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6052 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6053 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6054 Use ptrdiff_t, not int, to count maps.
6055 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6056 calculations. Don't update size until allocation succeeds.
6057 Redo calculations to avoid overflow.
726e0ab1
PE
6058 * keyboard.h: Change prototypes to match the above.
6059
6060 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6061 to count maps.
6062 (current_minor_maps): Check for size calculation overflow.
6063 * keymap.h: Change prototypes to match the above.
6064
6065 * lread.c (read1, init_obarray): Don't update size until alloc done.
6066
6067 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6068 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6069
726e0ab1
PE
6070 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6071 Now ptrdiff_t, not int.
6072 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6073 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6074
6075 * process.c (Fnetwork_interface_list): Check for overflow
6076 in size calculation.
6077
6078 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6079
6080 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6081 overflow. Don't bother calling xmalloc when xrealloc will do.
6082
6083 * search.c (Freplace_match): Check for size calculation overflow.
6084 (Fset_match_data): Don't assume list lengths fit in 'int'.
6085
6086 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6087 for command line length. Do not attempt to address one before the
6088 beginning of an array, as that's not portable.
6089
6090 * term.c (max_frame_lines): Remove; unused.
6091 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6092 not int.
6093 (encode_terminal_code, calculate_costs): Check for size
6094 calculation overflow.
6095 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6096 table lengths and related sizes. Don't update size until alloc
6097 done. Redo calculations to avoid overflow.
6098 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6099
6100 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6101 subtracting pointers.
6102 (gobble_line): Check for overflow more carefully. Don't update size
6103 until alloc done.
6104
6105 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6106 Don't update size until alloc done.
6107 Redo size calculations to avoid overflow.
6108 Check for size calculation overflow.
0065d054 6109 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6110
6111 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6112 Use ptrdiff_t, not int, for sizes.
6113 (store_mode_line_noprop_char): Don't update size until alloc done.
6114
0065d054
PE
6115 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6116 Use ptrdiff_t, not int, for sizes.
6117 (Finternal_make_lisp_face, cache_face):
6118 Check for size calculation overflow.
6119 (cache_face): Treat size calculation overflows as if they were
6120 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6121
6122 * xfns.c (x_encode_text, x_set_name_internal)
6123 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6124 sizes, since they can exceed INT_MAX in size. Check for size
6125 calculation overflow.
6126
0065d054
PE
6127 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6128 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6129 Don't update size until alloc done.
6130
0065d054 6131 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6132 as sprintf is limited to int lengths.
1d526e2f 6133
252c5ee1
PE
6134 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6135 (X_LONG_MIN): New macros.
864d7ce7
PE
6136 Use them to make the following changes clearer.
6137 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6138 This change doesn't affect the value now, but it may help remind
6139 future maintainers not to raise the value too much later.
6140 (SELECTION_QUANTUM): Remove, replacing with ...
6141 (selection_quantum): ... new function, which avoids overflow.
6142 All uses changed.
6143 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6144 assumption that selection length fits in 'int'.
6145 (x_reply_selection_request, x_handle_selection_request)
6146 (x_get_window_property, receive_incremental_selection)
6147 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6148 (lisp_data_to_selection_data, clean_local_selection_data):
6149 Use ptrdiff_t, not int, to record length of selection.
6150 (x_reply_selection_request, x_get_window_property)
6151 (receive_incremental_selection, x_property_data_to_lisp):
6152 Redo calculations to avoid overflow.
6153 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6154 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6155 something.
6156 (x_get_window_property, receive_incremental_selection)
6157 (lisp_data_to_selection_data, x_property_data_to_lisp):
6158 Check for size-calculation overflow.
6159 (x_get_window_property, receive_incremental_selection)
6160 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6161 Don't store size until memory allocation succeeds.
6162 (x_get_window_property): Plug memory leak on memory exhaustion.
6163 Don't double-block input; malloc is safe here. Don't assume 2**34
6164 - 4 fits in unsigned long. Add an xassert to check
6165 XGetWindowProperty overflow. Be more careful about overflow
6166 calculations, and distinguish size from memory overflow better.
6167 (receive_incremental_selection): When tracing, don't assume
6168 unsigned int is less than INT_MAX.
6169 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6170 harmful) conversions of unsigned short to int.
6171 (lisp_data_to_selection_data): Don't assume that integers
6172 in the range -65535 through -1 fit in an X unsigned short.
6173 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6174 result parameters unless successful. Rely on cons_to_unsigned
6175 to report problems with elements; the old code wasn't right anyway.
6176 (x_check_property_data): Check for int overflow; we cannot use
6177 a wider type due to X limits.
6178 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6179
726e0ab1 6180 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6181
0065d054
PE
6182 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6183 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6184 (x_color_cells): Don't store size until memory allocation succeeds.
6185 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6186 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6187 (x_term_init): Don't assume length fits in int (sprintf is limited
6188 to int size).
bc18e09d 6189
ebfa62c0
PE
6190 Use ptrdiff_t for composition IDs.
6191 * character.c (lisp_string_width):
6192 * composite.c (composition_table_size, n_compositions)
6193 (get_composition_id, composition_gstring_from_id):
6194 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6195 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6196 * window.c (Frecenter):
6197 Use ptrdiff_t, not int, for composition IDs.
6198 * composite.c (get_composition_id): Check for integer overflow.
6199 * composite.h: Adjust prototypes to match the above changes.
6200
d3411f89
PE
6201 Use ptrdiff_t for hash table indexes.
6202 * category.c (hash_get_category_set):
6203 * ccl.c (ccl_driver):
6204 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6205 * coding.c (coding_system_charset_list, detect_coding_system):
6206 * coding.h (struct coding_system.id):
6207 * composite.c (get_composition_id, gstring_lookup_cache):
6208 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6209 * image.c (xpm_get_color_table_h):
6210 * lisp.h (hash_lookup, hash_put):
6211 * minibuf.c (Ftest_completion):
6212 Use ptrdiff_t for hash table indexes, not int (which is too
6213 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6214 32-bit --with-wide-int hosts).
6215
e097a6fa
PE
6216 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6217 Add a FIXME comment about memory leaks.
6218 (syms_of_charset): Don't assume xmalloc returns.
6219
5637687f
PE
6220 Don't assume that stated character widths fit in int.
6221 * character.c (Fchar_width, c_string_width, lisp_string_width):
6222 * character.h (CHAR_WIDTH):
6223 * indent.c (MULTIBYTE_BYTES_WIDTH):
6224 Use sanitize_char_width to avoid undefined and/or bad behavior
6225 with outlandish widths.
a66cfb1c 6226 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6227 now that we have two such functions. All uses changed.
6228 (sanitize_char_width): New inline function.
6229
a2271ba2
PE
6230 Don't assume that tab-width fits in int.
6231 * character.h (sanitize_width): New inline function.
6232 (SANE_TAB_WIDTH): New macro.
6233 (ASCII_CHAR_WIDTH): Use it.
6234 * indent.c (sane_tab_width): Remove. All uses replaced by
6235 SANE_TAB_WIDTH (current_buffer).
6236 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6237
18c52557
PE
6238 * fileio.c: Integer overflow issues with file modes.
6239 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6240
caeeedc1
PE
6241 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6242 Remove unreachable code.
6243 (read_hex, load_charset_map_from_file): Check for integer overflow.
6244
6df6ae42 6245 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6246 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6247 (x_send_scroll_bar_event): Likewise. Check that the size does not
6248 exceed limits imposed by XClientMessageEvent, as well as the usual
6249 ptrdiff_t and size_t limits.
6250
b13995db
PE
6251 * keyboard.c: Overflow, signedness and related fixes.
6252 (make_lispy_movement): Use same integer type in forward decl
6253 that is used in the definition.
6254 (read_key_sequence, keyremap_step):
6255 Change bufsize argument back to int, undoing my 2011-03-30 change.
6256 We prefer signed types, and int is wide enough here.
6257 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6258 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6259 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6260 length, not size_t. Use ptrdiff_t for index, not int.
6261 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6262 possibility of integer overflow.
6263
13464394
PE
6264 Overflow, signedness and related fixes for images.
6265
6266 * dispextern.h (struct it.stack[0].u.image.image_id)
6267 (struct_it.image_id, struct image.id, struct image_cache.size)
6268 (struct image_cache.used, struct image_cache.ref_count):
6269 * gtkutil.c (update_frame_tool_bar):
6270 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6271 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6272 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6273 * nsmenu.m (update_frame_tool_bar):
6274 * xdisp.c (calc_pixel_width_or_height):
6275 * xfns.c (image_cache_refcount):
6276 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6277 on typical 64-bit hosts.
6278
6279 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6280 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6281 Omit unnecessary casts to int.
6282 (parse_image_spec): Check that integers fall into 'int' range
6283 when the callers expect that.
6284 (image_ascent): Redo ascent calculation to avoid int overflow.
6285 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6286 (lookup_image): Remove unnecessary tests.
6287 (xbm_image_p): Locals are now of int, not EMACS_INT,
6288 since parse_image_check makes sure they fit into int.
6289 (png_load, gif_load, svg_load_image):
6290 Prefer int to unsigned where either will do.
6291 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6292 old tiff_error_handler and tiff_warning_handler.
6293 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6294 stack buffer overflows. It uses only the features of vsnprintf
6295 that are common to both POSIX and native Microsoft.
6296 (tiff_error_handler, tiff_warning_handler): Use it.
6297 (tiff_load, gif_load, imagemagick_load_image):
6298 Don't assume :index value fits in 'int'.
6299 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6300 (imagemagick_load_image): Check that crop parameters fit into
6301 the integer types that MagickCropImage accepts. Don't assume
6302 Vimagemagick_render_type has a nonnegative value. Don't assume
6303 size_t fits in 'long'.
6304 (gs_load): Use printmax_t to print the widest integers possible.
6305 Check for integer overflow when computing image height and width.
6306
c11821d4
EZ
63072011-08-26 Eli Zaretskii <eliz@gnu.org>
6308
6309 * xdisp.c (redisplay_window): Don't force window start if point
6310 will be invisible in the resulting window. (Bug#9324)
6311
0c95fcf7
EZ
63122011-08-25 Eli Zaretskii <eliz@gnu.org>
6313
6314 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6315 the display spec is of the form `(space ...)'.
6316 (handle_display_spec): Return the value returned by
6317 handle_single_display_spec, not just 1 or zero.
6318 (handle_single_display_spec): If the display spec is of the form
6319 `(space ...)', and specifies display in the text area, return 2
6320 rather than 1.
fee65a97 6321 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6322 accurately, and prefer exact match for point under bidi.
6323 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6324
6325 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6326 into disp_prop; all users changed.
6327
6328 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6329 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6330 for the text covered by the display property.
6331
e4ed06f1
CY
63322011-08-25 Chong Yidong <cyd@stupidchicken.com>
6333
6334 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6335 Change return value to nil.
6336 (Frecord_buffer): Delete unused function.
6337
f67cdd7f
EZ
63382011-08-24 Eli Zaretskii <eliz@gnu.org>
6339
5980d4c6
EZ
6340 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6341 buffers, return left-to-right.
8610fe8b
EZ
6342 (set_cursor_from_row): Consider candidate row a win if its glyph
6343 represents a newline and point is on that newline. Fixes cursor
6344 positioning on the newline at EOL of R2L text within L2R
6345 paragraph, and vice versa.
6346 (try_cursor_movement): Check continued rows, in addition to
6347 continuation rows. Fixes unwarranted scroll when point enters a
6348 continued line of R2L text within an L2R paragraph, or vice versa.
6349 (cursor_row_p): Consider the case of point being equal to
6350 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6351 from the end of a short line to the beginning of a continued line
6352 of R2L text within L2R paragraph.
6353 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6354 composed characters.
5980d4c6 6355
f67cdd7f
EZ
6356 * bidi.c (bidi_check_type): Use xassert.
6357 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6358 members.
6359
bca633fb
EZ
63602011-08-23 Eli Zaretskii <eliz@gnu.org>
6361
6362 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6363 a character.
6364
4a5885a7
CY
63652011-08-23 Chong Yidong <cyd@stupidchicken.com>
6366
6367 * nsfont.m (ns_otf_to_script): Fix typo.
6368
0902a04e
KH
63692011-08-22 Kenichi Handa <handa@m17n.org>
6370
6371 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6372 extra slot even if the purpose is char-code-property-table.
6373
1a2e6670
EZ
63742011-08-23 Eli Zaretskii <eliz@gnu.org>
6375
8ddde651
EZ
6376 * xdisp.c (redisplay_window): When computing centering_position,
6377 account for the height of the header line. (Bug#8874)
6378
425cc014
EZ
6379 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6380 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6381 candidate is selected by the mouse, and that candidate has a
6382 composed character under the mouse.
6383
1a2e6670
EZ
6384 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6385 coordinates reported by pos-visible-in-window-p for a composed
6386 character in column zero.
6387
8b76d6f8
SM
63882011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6389
6390 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6391
dac347dd
EZ
63922011-08-22 Eli Zaretskii <eliz@gnu.org>
6393
6394 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6395 consider it a hit if to_charpos is anywhere in the range of the
6396 composed buffer positions.
6397
e013fb34
CY
63982011-08-22 Chong Yidong <cyd@stupidchicken.com>
6399
6400 * image.c (gif_load): Don't assume that each subimage has the same
6401 dimensions as the base image. Handle disposal method that is
6402 "undefined" by the gif spec (Bug#9335).
6403
bd1ba3e8
CY
64042011-08-20 Chong Yidong <cyd@stupidchicken.com>
6405
6406 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6407 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6408
54a1215b
EZ
64092011-08-19 Eli Zaretskii <eliz@gnu.org>
6410
823564e5
EZ
6411 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6412 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6413 from an Org mode buffer to a Speedbar frame.
6414
54a1215b
EZ
6415 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6416 a composition, take its buffer position from IT->cmp_it.charpos.
6417 Fixes cursor positioning at the beginning of a line that begins
6418 with a composed character.
6419
9778ebcc
EZ
64202011-08-18 Eli Zaretskii <eliz@gnu.org>
6421
0be6ee06
EZ
6422 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6423 character bidirectional type, use STRONG_L instead. Fixes crashes
6424 in a buffer produced by `describe-categories'.
6425
9778ebcc
EZ
6426 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6427 members before the level stack, so they would be saved and
6428 restored when copying iterator state. Fixes incorrect reordering
6429 around TABs covered by display properties.
6430
156bffbe
AS
64312011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6432
6b02f655 6433 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6434
72ad093b
CY
64352011-08-17 Chong Yidong <cyd@stupidchicken.com>
6436
6437 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6438 (internal_condition_case_2, internal_condition_case_n):
6439 Remove unnecessary aborts (Bug#9081).
72ad093b 6440
35774242
EZ
64412011-08-17 Eli Zaretskii <eliz@gnu.org>
6442
6443 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6444 has no `load' handler, try opening the file locally. (Bug#9311)
6445
db76dd85
KB
64462011-08-16 Ken Brown <kbrown@cornell.edu>
6447
6448 * gmalloc.c: Expand comment.
6449
b215eee5
EZ
64502011-08-16 Eli Zaretskii <eliz@gnu.org>
6451
6452 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6453 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6454
a4579d33
KB
64552011-08-16 Ken Brown <kbrown@cornell.edu>
6456
6457 Fix memory allocation problems in Cygwin build (Bug#9273).
6458
6459 * unexcw.c ( __malloc_initialized): Declare external variable.
6460 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6461
8b76d6f8
SM
6462 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6463 New variables.
a4579d33
KB
6464 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6465 dumped emacs.
6466 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6467 in the static heap.
6468 [CYGWIN] (special_realloc): New function.
6469 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6470 requests to realloc storage in the static heap.
6471
3ebec551
PE
64722011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6473
6474 * bidi.c (bidi_initialize): Remove unused local.
6475
9fd8be00
EZ
64762011-08-15 Eli Zaretskii <eliz@gnu.org>
6477
6b02f655
SM
6478 * bidimirror.h:
6479 * biditype.h: Remove file.
6480 * makefile.w32-in ($(BLD)/bidi.$(O)):
6481 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6482
6483 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6484
6485 * chartab.c: Improve commentary for the uniprop_table API.
6486
32413314
EZ
6487 * bidi.c (bidi_paragraph_init): Support zero value of
6488 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6489 (bidi_initialize): Use uniprop_table instead of including
6490 biditype.h and bidimirror.h.
32413314 6491
9fd8be00
EZ
6492 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6493 coordinates of the iterator when restoring from ppos_it.
6494 (Bug#9296)
6495
5cf2b69b
KH
64962011-08-14 Kenichi Handa <handa@m17n.org>
6497
6498 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6499 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6500
daf17d00
EZ
65012011-08-14 Eli Zaretskii <eliz@gnu.org>
6502
6503 * xdisp.c (move_it_in_display_line_to): Don't invoke
6504 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6505 ppos_it. Fixes vertical cursor motion when line beginning is
6506 covered by an image. (Bug#9296)
6507
08e3161a
JD
65082011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6509
6510 * nsterm.h (ns_run_ascript): Declare.
6511 (NSAPP_DATA2_RUNASSCRIPT): Define.
6512
6513 * nsfns.m (as_script, as_result, as_status): New static variables.
6514 (ns_run_ascript): New function.
5e617bc2 6515 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6516 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6517 the event loop. Get status from as_status (Bug#7276).
6518
6519 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6520 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6521 the event loop (Bug#7276).
6522
a3720aa2
AS
65232011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6524
6525 * gnutls.c (QCgnutls_bootprop_priority)
6526 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6527 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6528 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6529 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6530 (QCgnutls_bootprop_verify_hostname_error)
6531 (QCgnutls_bootprop_callbacks_verify): Rename from
6532 Qgnutls_bootprop_..., all uses changed.
6533
6534 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6535 uses changed.
6536
0a0d27fb
PE
65372011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6538
19d5c50c
PE
6539 * xfaces.c (Qframe_set_background_mode): Now static.
6540 * dispextern.h (Qframe_set_background_mode): Remove decl.
6541
0a0d27fb
PE
6542 * process.c (Fnetwork_interface_info): Declare local only if needed.
6543
377538cb
JD
65442011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6545
6546 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6547 (Fnetwork_interface_list): Allocate in increments of bytes instead
6548 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6549 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6550 sockaddr.
6551 (struct ifflag_def): notrailers is smart on OSX.
6552 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6553 Get hardware address with getifaddrs if available.
6554
08fff70c
EZ
65552011-08-12 Eli Zaretskii <eliz@gnu.org>
6556
6557 * xdisp.c (iterate_out_of_display_property): xassert that
6558 IT->position is set to within IT->object's boundaries. Break from
6559 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6560 when IT->position is set up wrongly due to some bug.
6561 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6562 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6563 entry. Force push_it to save on the stack the current
6564 buffer/string position, to be restored by pop_it. Fix flags in
6565 the iterator structure wrt the object coming from a display
6566 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6567 properties. (Bug#9284)
6568
7be1c708 65692011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6570
7be1c708
CY
6571 * fontset.c (fontset_get_font_group): Add proper type checks.
6572 (Bug#9172)
aac0c6e3 6573
7be1c708 65742011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6575
7be1c708
CY
6576 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6577 and LC_VERSION_MIN_MACOSX.
6578 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6579 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6580
97bb72a6
EZ
65812011-08-08 Eli Zaretskii <eliz@gnu.org>
6582
6583 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6584 no-display-properties-and-no-overlays under bidi display.
6585 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6586 properties and overlays.
97bb72a6 6587
d5617611
CY
65882011-08-08 Chong Yidong <cyd@stupidchicken.com>
6589
37e11a63
CY
6590 * editfns.c (Fset_time_zone_rule): Document relationship with the
6591 setenv function.
6592
d5617611
CY
6593 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6594 the font entity extracted from the cache (Bug#8109).
6595
58872834
CY
65962011-08-07 Chong Yidong <cyd@stupidchicken.com>
6597
6598 * composite.c (autocmp_chars): Don't reset point. That is done by
6599 restore_point_unwind (Bug#5984).
6600
75bfc667
JL
66012011-08-07 Juri Linkov <juri@jurta.org>
6602
6603 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6604 to show the arg `TIME' instead of `TIMEVAL'.
6605
d1410150
EZ
66062011-08-06 Eli Zaretskii <eliz@gnu.org>
6607
6608 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6609 display property strides EOL and includes a newline, as in
6610 longlines-mode. (Bug#9254)
75b771e4
EZ
6611 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6612 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6613
6614 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6615 is non-zero, even if the data buffer is NULL. Fixes a crash in
6616 vertical-motion with longlines-mode. (Bug#9254)
6617
35928349
EZ
66182011-08-05 Eli Zaretskii <eliz@gnu.org>
6619
ec7cc85b
EZ
6620 * bidi.c <bidi_cache_total_alloc>: Now static.
6621 (bidi_initialize): Initialize bidi_cache_total_alloc.
6622
8b76d6f8 6623 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6624 cache. (Bug#9221)
6625
6626 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6627 amount allocated this far in `bidi_cache_total_alloc'.
6628 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6629 non-zero, only free the data buffer without restoring the cache
6630 contents. All callers changed.
6631
6632 * dispextern.h (bidi_unshelve_cache): Update prototype.
6633
6634 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6635 (move_it_in_display_line, move_it_to)
6636 (move_it_vertically_backward, move_it_by_lines): Replace the call
6637 to xfree to an equivalent call to bidi_unshelve_cache.
6638 (move_it_in_display_line_to): Fix logic of returning
412b6358 6639 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6640
e2e2423b
EZ
66412011-08-05 Eli Zaretskii <eliz@gnu.org>
6642
6643 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6644 came from a string character with a `cursor' property. (Bug#9229)
6645
ae9e757a
JD
66462011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6647
6648 * Makefile.in (LIB_PTHREAD): New variable.
6649 (LIBES): Add LIB_PTHREAD (Bug#9216).
6650
6651 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6652 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6653
213bd7f2
AS
66542011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6655
6b02f655 6656 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6657
99aaf75f
JD
66582011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6659
6660 * xterm.c (x_find_topmost_parent): New function.
6661 (x_set_frame_alpha): Find topmost parent window with
6662 x_find_topmost_parent and set the property there also (bug#9181).
6663 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6664
c74e9d86
PE
66652011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6666
6667 * callproc.c (Fcall_process): Avoid vfork clobbering
6668 the local vars buffer, coding_systems, current_dir.
6669
640c8776
SM
66702011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6671
6672 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6673
f26d0e4c
PE
66742011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6675
8a10d76c
PE
6676 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6677 so that it is not optimized away.
6678
f26d0e4c
PE
6679 * xdisp.c (compute_display_string_pos): Remove unused local.
6680
55439c61
EZ
66812011-08-02 Eli Zaretskii <eliz@gnu.org>
6682
6683 Fix slow cursor motion and scrolling in large buffers with
6684 selective display, like Org Mode buffers. (Bug#9218)
6685
6686 * dispextern.h (struct bidi_it): New member disp_prop_p.
6687
6688 * xdisp.c: Remove one-slot cache of display string positions.
6689 (compute_display_string_pos): Accept an additional argument
5e617bc2 6690 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6691 for a display string or property. If found, set DISP_PROP_P
6692 non-zero.
6693
6694 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6695 DISP_PROP_P, and pass it to compute_display_string_pos.
6696 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6697 non-zero. All callers of bidi_fetch_char changed.
6698
fb33fa43
SM
66992011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6700
6701 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6702
b099e063
DM
67032010-12-03 Don March <don@ohspite.net>
6704
6705 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6706 last character M-[char] is translated to ESC [char] (bug#7541).
6707
5cc7f7af
KH
67082011-08-02 Kenichi Handa <handa@m17n.org>
6709
d0fffa3f 6710 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6711
6712 * chartab.c (uniprop_table): Make it non-static.
6713
525d5e6e
EZ
67142011-08-01 Eli Zaretskii <eliz@gnu.org>
6715
6716 * xdisp.c (forward_to_next_line_start): Accept additional argument
6717 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6718 on the newline.
6719 (reseat_at_next_visible_line_start): Use the bidi iterator state
6720 returned by forward_to_next_line_start to restore the state of
6721 it->bidi_it after backing up to previous newline. (Bug#9212)
6722
31011111
AS
67232011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6724
6725 * regex.c (re_comp): Protoize.
6726 (re_exec): Fix return type.
6727 (regexec): Fix type of `ret'. (Bug#9203)
6728
476371c4
PE
67292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6730
e5d76069
PE
6731 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6732 This is needed if max-image-size is a floating-point number.
6733
9a79b20c
AS
67342011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6735
6736 * print.c (print_object): Print empty symbol as ##.
6737
6738 * lread.c (read1): Read ## as empty symbol.
6739
d8c2fa78
AA
67402011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6741
6742 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6743 setting frame foreground color (Bug#9175).
6744 (x_set_background_color): Likewise.
6745
ffe57a7a
AA
6746 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6747 contents (Bug#9176).
6748 (EmacsTooltip -init): Remove bezels and add shadows to
6749 tooltip windows.
6750
bf3492a5
AA
6751 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6752 or scroll bar (Bug#8470).
6753
d55e9c53
AA
6754 * nsfont.m (nsfont_open): Remove assignment to voffset and
6755 unnecessary vars hshink, expand, hd, full_height, min_height.
6756 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6757
6758 * nsterm.h (nsfont_info): Remove voffset field.
6759
d8c2fa78 67602011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6761
6762 Implement strike-through and overline on NextStep (Bug#8863).
6763
6764 * nsfont.m (nsfont_open): Use underline position provided by font,
6765 instead of hard-coded value of 2.
6766 (nsfont_draw): Call ns_draw_text_decoration instead.
6767
6768 * nsterm.h: Add declaration for ns_draw_text_decoration.
6769
6770 * nsterm.m (ns_draw_text_decoration): New function for drawing
6771 underline, overline, and strike-through.
6772 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6773 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6774 accommodate underlining, etc.
4843aac3 6775
4cc60b9b
EZ
67762011-07-28 Eli Zaretskii <eliz@gnu.org>
6777
bc7ece87
EZ
6778 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6779 default.
4cc60b9b 6780
476371c4
PE
67812011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6782
66606eea
PE
6783 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6784 Without this fix, if a signal arrives just after memory fills up,
6785 'malloc' might be invoked reentrantly.
6786
476371c4
PE
6787 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6788 In other words, assume that every image size is allowed, on non-X
6789 hosts. This assumption is probably wrong, but it lets Emacs compile.
6790
f3fcc40d
AS
67912011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6792
6793 * regex.c (re_iswctype): Convert return values to boolean.
6794
350c992f
EZ
67952011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6796
6797 * xdisp.c (compute_display_string_pos): Don't use cached display
6798 string position if the buffer had its restriction changed.
6799 (Bug#9184)
6800
5266b4bb
PE
68012011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6802
6803 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6804
2573a837 68052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6806
41f55ccd 6807 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6808
39e378da
PE
6809 * bidi.c: Integer size and overflow fixes.
6810 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6811 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6812 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6813 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6814 (bidi_find_other_level_edge):
6815 Use ptrdiff_t instead of EMACS_INT where either will do.
6816 This works better on 32-bit hosts configured --with-wide-int.
6817 (bidi_cache_ensure_space): Check for size-calculation overflow.
6818 Use % rather than repeated addition, for better worst-case speed.
6819 Don't set bidi_cache_size until after xrealloc returns, because it
6820 might not return.
6821 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6822 (bidi_cache_ensure_space): Also check that the bidi cache size
6823 does not exceed that of the largest Lisp string or buffer. See Eli
6824 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6825
5e927815
PE
6826 * alloc.c (__malloc_size_t): Remove.
6827 All uses replaced by size_t. See Andreas Schwab's note
6828 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6829
ca4aa935
PE
6830 * image.c: Improve checking for integer overflow.
6831 (check_image_size): Assume that f is nonnull, since
6832 it is always nonnull in practice. This is one less thing to
6833 worry about when checking for integer overflow later.
6834 (x_check_image_size): New function, which checks for integer
6835 overflow issues inside X.
6836 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6837 This removes the need for a memory_full check.
6838 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6839 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6840 (xbm_read_bitmap_data): Change locals back to 'int', since
6841 their values must fit in 'int'.
6842 (xpm_load_image, png_load, tiff_load):
6843 Invoke x_create_x_image_and_pixmap earlier,
6844 to avoid much needless work if the image is too large.
6845 (tiff_load): Treat overly large images as if
6846 x_create_x_image_and_pixmap failed, not as malloc failures.
6847 (gs_load): Use x_check_image_size.
6848
5f8f9cc2
PE
6849 * gtkutil.c: Omit integer casts.
6850 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6851 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6852
5adf60bc
PE
6853 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6854
c8907a93
PE
6855 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6856 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6857 would wrongly return t on a 64-bit host.
6858
e3c25c68
PE
6859 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6860 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6861 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6862 and therefore cause GCC to emit a bogus diagnostic in some cases.
6863
3f791afe
PE
6864 * image.c: Integer signedness and overflow and related fixes.
6865 This is not an exhaustive set of fixes, but it's time to
6866 record what I've got.
6867 (lookup_pixel_color, check_image_size): Remove redundant decls.
6868 (check_image_size): Don't assume that arbitrary EMACS_INT values
6869 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6870 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6871 (tiff_load, imagemagick_load_image):
6872 Check for overflow in size calculations.
6873 (x_create_x_image_and_pixmap): Remove unnecessary test for
6874 xmalloc returning NULL; that can't happen.
6875 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6876 (xpm_color_bucket): Use better integer hashing function.
6877 (xpm_cache_color): Don't possibly over-allocate memory.
6878 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6879 (gif_memory_source):
6880 Use ptrdiff_t, not int or size_t, to record sizes.
6881 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6882 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6883 either works, as we prefer signed integers.
6884 (tiff_read_from_memory, tiff_write_from_memory):
6885 Return tsize_t, not size_t, since that's what the TIFF API wants.
6886 (tiff_read_from_memory): Don't fail simply because the read would
6887 go past EOF; instead, return a short read.
6888 (tiff_load): Omit no-longer-needed casts.
6889 (Fimagemagick_types): Don't assume size fits into 'int'.
6890
3cc5a532
PE
6891 Improve hashing quality when configured --with-wide-int.
6892 * fns.c (hash_string): New function, taken from sxhash_string.
6893 Do not discard information about ASCII character case; this
6894 discarding is no longer needed.
6895 (sxhash-string): Use it. Change sig to match it. Caller changed.
6896 * lisp.h: Declare it.
6897 * lread.c (hash_string): Remove, since we now use fns.c's version.
6898 The fns.c version returns a wider integer if --with-wide-int is
6899 specified, so this should help the quality of the hashing a bit.
6900
b312a492
PE
6901 * emacs.c: Integer overflow minor fix.
6902 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6903 Define only if GNU_LINUX.
6904 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6905
dfd153ae
PE
6906 * dispnew.c: Integer signedness and overflow fixes.
6907 Remove unnecessary forward decls, that were a maintenance hassle.
6908 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6909 All uses changed.
6910 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6911 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6912 (prepare_desired_row, line_draw_cost):
6913 Use int, not unsigned, where either works.
6914 (save_current_matrix, restore_current_matrix):
6915 Use ptrdiff_t, not size_t, where either works.
6916 (init_display): Check for overflow more accurately, and without
6917 relying on undefined behavior.
6918
a81d11a3
PE
6919 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6920 Remove, replacing with the new symbols in lisp.h. All uses changed.
6921 * fileio.c (make_temp_name):
6922 * filelock.c (lock_file_1, lock_file):
6923 * xdisp.c (message_dolog):
6924 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6925 Use pMd etc. instead.
6926 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6927 replacing the pWIDE etc. symbols removed from editfns.c.
6928
3300e6fd
PE
6929 * keyboard.h (num_input_events): Now uintmax_t.
6930 This is (very slightly) less likely to mess up due to wraparound.
6931 All uses changed.
6932
fd05c7e9
PE
6933 * buffer.c: Integer signedness fixes.
6934 (alloc_buffer_text, enlarge_buffer_text):
6935 Use ptrdiff_t rather than size_t when either will do, as we prefer
6936 signed integers.
6937
903fe15d
PE
6938 * alloc.c: Integer signedness and overflow fixes.
6939 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6940 (__malloc_size_t): Default to size_t, not to int.
6941 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6942 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6943 Prefer ptrdiff_t to size_t when either would do, as we prefer
6944 signed integers.
6945 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6946 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6947 Now const. Initialize with values that are in range even if char
6948 is signed.
6949 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6950 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6951 These functions do the right thing with sizes > 2**32.
6952 (check_depth): Now ptrdiff_t, not int.
6953 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6954 Adjust to new way of storing sizes. Check for size overflow bugs
6955 in rest of code.
6956 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6957 slightly wrong anyway, as it missed one instance of
6958 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6959 (refill_memory_reserve): Omit needless cast to size_t.
6960 (mark_object_loop_halt): Mark as externally visible.
6961
ac82cc6a
PE
6962 * xselect.c: Integer signedness and overflow fixes.
6963 (Fx_register_dnd_atom, x_handle_dnd_message):
6964 Use ptrdiff_t, not size_t, since we prefer signed.
6965 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6966 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6967 x_dnd_atoms_size and x_dnd_atoms_length.
6968
c2d1e36d
PE
6969 * doprnt.c: Prefer signed to unsigned when either works.
6970 * eval.c (verror):
6971 * doprnt.c (doprnt):
6972 * lisp.h (doprnt):
6973 * xdisp.c (vmessage):
6974 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6975 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6976 prefer signed arithmetic to avoid comparison confusion.
6977 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6978 but is a bit tricky.
6979
0e926e56
PE
6980 Assume freestanding C89 headers, string.h, stdlib.h.
6981 * data.c, doprnt.c, floatfns.c, print.c:
6982 Include float.h unconditionally.
6983 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6984 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6985 * regex.c: Likewise for stddef.h, string.h.
6986 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6987 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6988 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6989 (STDC_HEADERS): Remove obsolete defines.
6990 * sysdep.c: Include limits.h unconditionally.
6991
9cfdb3ec
PE
6992 Assume support for memcmp, memcpy, memmove, memset.
6993 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6994 * regex.c (memcmp, memcpy):
6995 Remove; we assume C89 now.
6996
6997 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6998 (__malloc_safe_bcopy): Remove; no longer needed.
6999
cf950e6b 7000 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7001 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7002 well either way, and we prefer signed to unsigned.
7003
dbf38e02
LMI
70042011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7005
7006 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7007 closes the connection while we're reading (bug#9182).
7008
d6f0886c 70092011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7010
d6f0886c
JD
7011 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7012 are specified (Bug#9168).
24e0f6b1 7013
2eb1f9e6
PE
70142011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7015
7016 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7017 Found by GCC static checking and --with-wide-int on a 32-bit host.
7018
22381272 70192011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7020
7021 * xdisp.c (compute_display_string_pos): Fix logic of caching
7022 previous display string position. Initialize cached_prev_pos to
7023 -1. Fixes slow-down at the beginning of a buffer.
7024
f25e39b4
EZ
70252011-07-24 Eli Zaretskii <eliz@gnu.org>
7026
7027 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7028 for attrs[LFACE_FONTSET_INDEX].
7029
04c4b52e
PE
70302011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7031
7032 * xml.c (parse_region): Remove unused local
7033 that was recently introduced.
7034
c1734fbd
EZ
70352011-07-23 Eli Zaretskii <eliz@gnu.org>
7036
be18c5a5
EZ
7037 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7038 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7039
c1734fbd
EZ
7040 * xdisp.c (move_it_in_display_line_to): Record the best matching
7041 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7042 exit if none of the characters scanned was an exact match.
7043 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7044 when exact match is impossible due to invisible text, and the
7045 lines are truncated.
7046
a258d627
JD
70472011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7048
7049 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7050 for OSX >= 10.7.
7051
b6d5a689
EZ
70522011-07-22 Eli Zaretskii <eliz@gnu.org>
7053
0f74f785
EZ
7054 Fix a significant slow-down of cursor motion with C-n, C-p,
7055 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7056 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7057 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7058 (next_element_from_buffer): Call compute_stop_pos_backwards to
7059 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7060 base_level_stop.
7061 (reseat): Don't look for prev_stop, as that could mean a very long
7062 run.
7063 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7064 <cached_disp_overlay_modiff>: Cache for last found display string
7065 position.
551918c1 7066 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7067 about the same buffer in the same area of character positions, and
7068 the buffer wasn't changed since the time the display string
7069 position was cached.
551918c1 7070
b2d0c91a
EZ
70712011-07-22 Eli Zaretskii <eliz@gnu.org>
7072
7073 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7074 is an integer, which is important for empty lines. (Bug#9149)
7075
043604ee
CY
70762011-07-22 Chong Yidong <cyd@stupidchicken.com>
7077
7078 * frame.c (Fmodify_frame_parameters): In tty case, update the
7079 default face if necessary (Bug#4238).
7080
da4adb04
CY
70812011-07-21 Chong Yidong <cyd@stupidchicken.com>
7082
7083 * editfns.c (Fstring_to_char): No need to explain what a character
7084 is in the docstring (Bug#6576).
7085
9abd0532
LMI
70862011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7087
7088 * xml.c (parse_region): Make sure we always return a tree.
7089
36881d16
HK
70902011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7091
7092 * xml.c (parse_region): If a document contains only comments,
7093 return that, too.
7094
1e98674d
LMI
70952011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7096
7097 * xml.c (make_dom): Return comments, too.
7098
590bd467
PE
70992011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7100
7101 Port to OpenBSD.
7102 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7103 and the surrounding thread.
7104 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7105 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7106 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7107 timer goes off.
7108 * s/openbsd.h (BROKEN_SIGIO): Define.
7109 * unexelf.c (unexec) [__OpenBSD__]:
7110 Don't update the .mdebug section of the Alpha COFF symbol table.
7111
f41628b2
LMI
71122011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7113
7114 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7115 (bug#8460).
7116
b59b67c5
PE
71172011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7118
15e3a074
PE
7119 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7120 This fixes some race conditions on the permissions of any newly
7121 created file.
7122
41bed37d
PE
7123 * alloc.c (valid_pointer_p): Use pipe, not open.
7124 This fixes some permissions issues when debugging.
7125
b59b67c5
PE
7126 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7127 If fchown fails to set both uid and gid, try to set just gid,
7128 as that is sometimes allowed. Adjust the file's mode to eliminate
7129 setuid or setgid bits that are inappropriate if fchown fails.
7130
925a6be7
SM
71312011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7132
7133 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7134 to compare Lisp_Objects.
7135 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7136 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7137 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7138
52968808
AS
71392011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7140
0a6a104b
AS
7141 * lread.c (read_integer): Unread even EOF character.
7142 (read1): Likewise. Properly record start position of symbol.
7143
52968808
AS
7144 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7145 symbol character follows.
7146
9e381cdd
PE
71472011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7148
7149 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7150 This works around a problem with the previous change to Fcopy_file.
7151 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7152 and without this change, GCC might complain about discarding
7153 fchown's return value.
7154
b5641435
JB
71552011-07-16 Juanma Barranquero <lekktu@gmail.com>
7156
7157 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7158
a8031457
PE
71592011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7160
7161 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7162
dd889327
LMI
71632011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7164
750c33f7
LMI
7165 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7166 it's used from the C level.
7167
dd889327
LMI
7168 * process.c: Use the same condition for POLL_FOR_INPUT in both
7169 keyboard.c and process.c (bug#1858).
7170
87e86684
LM
71712011-07-09 Lawrence Mitchell <wence@gmx.li>
7172
7173 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7174 (Fgnutls_boot): Use it.
7175
64348f40
AS
71762011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7177
7178 * doc.c (Fsubstitute_command_keys): Revert last change.
7179
1d698799
LMI
71802011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7181
f863868c
LMI
7182 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7183 quotes the next character, and doesn't affect other longer
7184 sequences (bug#8935).
7185
1d698799
LMI
7186 * lread.c (syms_of_lread): Clarify that is isn't only
7187 `eval-buffer' and `eval-defun' that's affected by
7188 `lexical-binding' (bug#8460).
7189
aa4b6df6
EZ
71902011-07-15 Eli Zaretskii <eliz@gnu.org>
7191
7192 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7193 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7194
5d856da6
PE
71952011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7196
ad6042bb
PE
7197 Fix minor problems found by static checking.
7198 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7199 (elsz): Now a signed constant, not a size_t var. We prefer signed
7200 types to unsigned, to avoid integer comparison confusion. Without
7201 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7202 "cannot optimize loop, the loop counter may overflow", a symptom
7203 of the confusion.
f00bbb22 7204 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7205 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7206
6468f31c
LMI
72072011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7208
49080b10
LMI
7209 * search.c (Fre_search_backward): Mention `case-fold-search' in
7210 all the re_search_* functions (bug#8138).
7211
6468f31c
LMI
7212 * keyboard.c (Fopen_dribble_file): Document when the file is
7213 closed (bug#8056).
7214
c965adc5
EZ
72152011-07-14 Eli Zaretskii <eliz@gnu.org>
7216
df9733bf
EZ
7217 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7218 bidi_cache_idx.
7219
0bb23927
EZ
7220 Support bidi reordering of display and overlay strings.
7221 * xdisp.c (compute_display_string_pos)
7222 (compute_display_string_end): Accept additional argument STRING.
7223 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7224 (reseat_to_string): Initialize bidi_it->string.s and
7225 bidi_it->string.schars.
7226 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7227 NULL (avoids a crash in bidi_paragraph_init).
7228 Initialize itb.string.lstring.
0bb23927
EZ
7229 (init_iterator): Call bidi_init_it only of a valid
7230 buffer position was specified. Initialize paragraph_embedding to
7231 L2R.
7232 (reseat_to_string): Initialize the bidi iterator.
7233 (display_string): If we need to ignore text properties of
7234 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7235 original value of -1 will not work with bidi.)
7236 (compute_display_string_pos): First arg is now struct
7237 `text_pos *'; all callers changed. Support display properties on
7238 Lisp strings.
7239 (compute_display_string_end): Support display properties on Lisp
7240 strings.
7241 (init_iterator, reseat_1, reseat_to_string): Initialize the
7242 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7243 when iterating on a string not from display properties).
640c8776
SM
7244 (compute_display_string_pos, compute_display_string_end):
7245 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7246 arrow keys.
7247 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7248 base_level_stop; instead, set base_level_stop to BEGV.
7249 Fixes crashes in vertical-motion.
0bb23927
EZ
7250 (next_element_from_buffer): Improve commentary for when
7251 the iterator is before prev_stop.
7252 (init_iterator): Initialize bidi_p from the default value of
7253 bidi-display-reordering, not from buffer-local value. Use the
7254 buffer-local value only if initializing for buffer iteration.
7255 (handle_invisible_prop): Support invisible properties on strings
7256 that are being bidi-reordered.
7257 (set_iterator_to_next): Support bidi reordering of C strings and
7258 Lisp strings.
7259 (next_element_from_string): Support bidi reordering of Lisp
7260 strings.
7261 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7262 (display_string): Support display of R2L glyph rows.
7263 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7264 (init_iterator): Don't initialize it->bidi_p for strings
7265 here.
7266 (reseat_to_string): Initialize it->bidi_p for strings here.
7267 (next_element_from_string, next_element_from_c_string)
7268 (next_element_from_buffer): Add xassert's for correspondence
7269 between IT's object being iterated and it->bidi_it.string
7270 structure.
7271 (face_before_or_after_it_pos): Support bidi iteration.
7272 (next_element_from_c_string): Handle the case of the first string
7273 character that is not the first one in the visual order.
7274 (get_visually_first_element): New function, refactored from common
7275 parts of next_element_from_buffer, next_element_from_string, and
7276 next_element_from_c_string.
7277 (tool_bar_lines_needed, redisplay_tool_bar)
7278 (display_menu_bar): Force left-to-right direction. Add a FIXME
7279 comment for making that be controlled by a user option.
7280 (push_it, pop_it): Save and restore the state of the
7281 bidi iterator. Save and restore the bidi_p flag.
7282 (pop_it): Iterate out of display property for string iteration as
7283 well.
7284 (iterate_out_of_display_property): Support iteration over strings.
7285 (handle_single_display_spec): Set up it->bidi_it for iteration
7286 over a display string, and call bidi_init_it.
7287 (handle_single_display_spec, next_overlay_string)
7288 (get_overlay_strings_1, push_display_prop): Set up the bidi
7289 iterator for displaying display or overlay strings.
7290 (forward_to_next_line_start): Don't use the shortcut if
7291 bidi-iterating.
7292 (back_to_previous_visible_line_start): If handle_display_prop
7293 pushed the iterator stack, restore the internal state of the bidi
7294 iterator by calling bidi_pop_it same number of times.
7295 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7296 and we are bidi-iterating, don't decrement the iterator position;
7297 instead, set the first_elt flag in the bidi iterator, to produce
7298 the same effect.
7299 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7300 (push_display_prop): xassert that we are iterating a buffer.
7301 (push_it, pop_it): Save and restore paragraph_embedding member.
7302 (handle_single_display_spec, next_overlay_string)
7303 (get_overlay_strings_1, reseat_1, reseat_to_string)
7304 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7305 correctly. Don't assume unibyte strings are not bidi-reordered.
7306 (compute_display_string_pos)
7307 (compute_display_string_end): Fix handling the case of C string.
7308 (push_it, pop_it): Save and restore from_disp_prop_p.
7309 (handle_single_display_spec, push_display_prop): Set the
7310 from_disp_prop_p flag.
7311 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7312 (pop_it): Call iterate_out_of_display_property only if we are
7313 popping after iteration over a string that came from a display
7314 property. Fix a typo in popping stretch info. Add an assertion
7315 for verifying that the iterator position is in sync with the bidi
7316 iterator.
7317 (handle_single_display_spec, get_overlay_strings_1)
7318 (push_display_prop): Fix initialization of paragraph direction for
7319 string when that of the parent object is not yet determined.
7320 (reseat_1): Call bidi_init_it to resync the bidi
7321 iterator with IT's position. (Bug#7616)
7322 (find_row_edges): If ROW->start.pos gives position
7323 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7324 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7325 Reset the from_disp_prop_p flag.
7326 (SAVE_IT, RESTORE_IT): New macros.
7327 (pos_visible_p, face_before_or_after_it_pos)
7328 (back_to_previous_visible_line_start)
7329 (move_it_in_display_line_to, move_it_in_display_line)
7330 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7331 (try_scrolling, redisplay_window, display_line): Use them when
7332 saving a temporary copy of the iterator and restoring it back.
7333 (back_to_previous_visible_line_start, reseat_1)
7334 (init_iterator): Empty the bidi cache "stack".
7335 (move_it_in_display_line_to): If iterator ended up at
7336 EOL, but we never saw any buffer positions smaller than
7337 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7338 motion in bidi-reordered lines.
7339 (move_it_in_display_line_to): Record prev_method and prev_pos
7340 immediately before the call to set_iterator_to_next. Fixes cursor
7341 motion in bidi-reordered lines with stretch glyphs and strings
7342 displayed in margins. (Bug#8133) (Bug#8867)
7343 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7344 TO_CHARPOS.
640c8776
SM
7345 (pos_visible_p): Support positions in bidi-reordered lines.
7346 Save and restore bidi cache.
0bb23927
EZ
7347
7348 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7349 (bidi_paragraph_info): Delete unused struct.
7350 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7351 (bidi_cache_start): New variable.
7352 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7353 to zero.
7354 (bidi_cache_fetch_state, bidi_cache_search)
7355 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7356 (bidi_cache_find, bidi_peek_at_next_level)
7357 (bidi_level_of_next_char, bidi_find_other_level_edge)
7358 (bidi_move_to_visually_next): Compare cache index with
7359 bidi_cache_start rather than with zero.
7360 (bidi_fetch_char): Accept new argument STRING; all callers
7361 changed. Support iteration over a string. Support strings with
7362 display properties. Support unibyte strings. Fix the type of
7363 `len' according to what STRING_CHAR_AND_LENGTH expects.
7364 (bidi_paragraph_init, bidi_resolve_explicit_1)
7365 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7366 (bidi_level_of_next_char, bidi_move_to_visually_next):
7367 Support iteration over a string.
0bb23927
EZ
7368 (bidi_set_sor_type, bidi_resolve_explicit_1)
7369 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7370 can now be zero (for strings); special values 0 and -1 were
7371 changed to -1 and -2, respectively.
7372 (bidi_char_at_pos): New function.
7373 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7374 Call it instead of FETCH_MULTIBYTE_CHAR.
7375 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7376 initialized to valid values.
7377 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7378 values.
7379 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7380 the test for valid cached positions. Fix the logic for looking up
7381 the sentinel state in the cache. GCPRO the Lisp string we are
7382 iterating.
7383 (bidi_push_it, bidi_pop_it): New functions.
7384 (bidi_initialize): Initialize the bidi cache start stack pointer.
7385 (bidi_cache_ensure_space): New function, refactored from part of
7386 bidi_cache_iterator_state. Don't assume the required size is just
7387 one BIDI_CACHE_CHUNK away.
7388 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7389 (bidi_count_bytes, bidi_char_at_pos): New functions.
7390 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7391 always valid if bidi_cache_idx is valid.
7392 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7393 is valid if it's going to be used.
7394 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7395 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7396 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7397 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7398 (bidi_find_other_level_edge, bidi_cache_start_stack):
7399 All variables related to cache indices are now EMACS_INT.
c965adc5 7400
0bb23927
EZ
7401 * dispextern.h (struct bidi_string_data): New structure.
7402 (struct bidi_it): New member `string'. Make flag members be 1-bit
7403 fields, and put them last in the struct.
640c8776
SM
7404 (compute_display_string_pos, compute_display_string_end):
7405 Update prototypes.
0bb23927
EZ
7406 (bidi_push_it, bidi_pop_it): Add prototypes.
7407 (struct iterator_stack_entry): New members bidi_p,
7408 paragraph_embedding, and from_disp_prop_p.
7409 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7410 (bidi_shelve_cache, bidi_unshelve_cache):
7411 Declare prototypes.
0bb23927
EZ
7412
7413 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7414 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7415 and vector-like objects.
7416
7417 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7418 cache around display iteration.
7419
7420 * window.c (Fwindow_end, window_scroll_pixel_based)
7421 (displayed_window_lines, Frecenter): Save and restore the bidi
7422 cache around display iteration.
7423
3bbd2265
LMI
74242011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7425
7426 * editfns.c (Fdelete_region): Clarify the use of the named
7427 parameters (bug#6788).
7428
adc47434
MR
74292011-07-14 Martin Rudalics <rudalics@gmx.at>
7430
7431 * indent.c (Fvertical_motion): Set and restore w->pointm when
7432 saving and restoring the window's buffer (Bug#9006).
7433
837c31f8
LMI
74342011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7435
7436 * editfns.c (Fstring_to_char): Clarify just what is returned
7437 (bug#6576). Text by Eli Zaretskii.
7438
ac389d0c
JB
74392011-07-13 Juanma Barranquero <lekktu@gmail.com>
7440
7441 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7442
0be0ce47
EZ
74432011-07-13 Eli Zaretskii <eliz@gnu.org>
7444
7445 * buffer.c (mmap_find): Fix a typo.
7446
cd18e7e3
JB
74472011-07-13 Johan Bockgård <bojohan@gnu.org>
7448
7449 Fix execution of x selection hooks.
7450 * xselect.c (Qx_lost_selection_functions)
7451 (Qx_sent_selection_functions): New vars.
7452 (syms_of_xselect): DEFSYM them.
7453 (x_handle_selection_request): Pass Qx_sent_selection_functions
7454 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7455 (x_handle_selection_clear,x_clear_frame_selections):
7456 Pass Qx_lost_selection_functions rather than
7457 Vx_lost_selection_functions to Frun_hook_with_args.
7458
47ea7f44
PE
74592011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7460
ac389d0c 7461 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7462 The old code sometimes used this field without initializing it.
7463
47ea7f44
PE
7464 * alloc.c (gc_sweep): Don't read past end of array.
7465 In theory, the old code could also have corrupted Emacs internals,
7466 though it'd be very unlikely.
7467
bc985c87
AS
74682011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7469
7470 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7471 argument. (Bug#4026)
bc985c87 7472
0cf34688
LMI
74732011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7474
b3dadd76
LMI
7475 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7476 key" (bug#4257).
7477
0cf34688
LMI
7478 * window.c (Fset_window_start): Doc fix (bug#4199).
7479 (Fset_window_hscroll): Ditto.
7480
270768cd
PE
74812011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7482
077e3dda 7483 Fix minor new problems caught by GCC 4.6.1.
270768cd 7484 * term.c (init_tty): Remove unused local.
490011a6 7485 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7486 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7487 not used otherwise.
270768cd 7488
b1f58454
CY
74892011-07-12 Chong Yidong <cyd@stupidchicken.com>
7490
7491 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7492
22b9578d
LMI
74932011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7494
6e70ab07
LMI
7495 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7496 are the mini-buffer and the echo area (bug#3320).
7497
22b9578d
LMI
7498 * term.c (init_tty): Remove support for supdup, c10 and perq
7499 terminals, which are no longer supported (bug#1482).
7500
8974cc9f
JB
75012011-07-10 Johan Bockgård <bojohan@gnu.org>
7502
7503 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7504
a560d974
JD
75052011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7506
7507 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7508 for non-popups (Bug#3642).
7509
1dae0f0a
AS
75102011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7511
268c2c36 7512 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7513 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7514 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7515 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7516 * data.c (fmod): Likewise.
7517 * dispnew.c (swap_glyphs_in_rows): Likewise.
7518 * emacs.c (memory_warning_signal): Likewise.
7519 * floatfns.c (float_error): Likewise.
7520 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7521 (otf_open, font_otf_capability, generate_otf_features)
7522 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7523 Likewise.
7524 * image.c (pbm_read_file): Likewise.
7525 * indent.c (string_display_width): Likewise.
7526 * intervals.c (check_for_interval, search_for_interval)
7527 (inc_interval_count, count_intervals, root_interval)
7528 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7529 * lread.c (defalias): Likewise.
268c2c36 7530 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7531 * regex.c (set_image_of_range_1, set_image_of_range)
7532 (regex_grow_registers): Likewise.
7533 * sysdep.c (strerror): Likewise.
7534 * termcap.c (valid_filename_p, tprint, main): Likewise.
7535 * tparam.c (main): Likewise.
7536 * unexhp9k800.c (run_time_remap, save_data_space)
7537 (update_file_ptrs, read_header, write_header, calculate_checksum)
7538 (copy_file, copy_rest, display_header): Likewise.
7539 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7540 Likewise.
7541 * xdisp.c (check_it): Likewise.
7542 * xfaces.c (register_color, unregister_color, unregister_colors):
7543 Likewise.
7544 * xfns.c (print_fontset_result): Likewise.
7545 * xrdb.c (member, fatal, main): Likewise.
7546
99033785
PE
75472011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7548
7549 Fix minor problems found by static checking (Bug#9031).
7550 * chartab.c (char_table_set_range, map_sub_char_table):
7551 Remove unused locals.
7552 (uniprop_table): Now static.
7553 * composite.c (_work_char): Remove unused static var.
7554
9cb2ac56
JB
75552011-07-09 Juanma Barranquero <lekktu@gmail.com>
7556
7557 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7558
f25661f0
JD
75592011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7560
7561 * gtkutil.c (qttip_cb): Remove code without function.
7562
8278c4fe
EZ
75632011-07-09 Eli Zaretskii <eliz@gnu.org>
7564
7565 * w32.c (pthread_sigmask): New stub.
7566
1692ae2d 75672011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7568
8a6ebd58 7569 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7570 sigprocmask is portable only for single-threaded applications, and
7571 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7572 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7573 (LIBES): Use it.
7574 * callproc.c (Fcall_process):
7575 * process.c (create_process):
7576 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7577 Use pthread_sigmask, not sigprocmask.
123403e4 7578
1b854618
JD
75792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7580
7581 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7582 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7583 wrong (Bug#8591).
7584
3fe4b549
JD
75852011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7586
0ce7e563
JD
7587 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7588 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7589 (xg_hide_tooltip): Fix comment.
7590
3fe4b549
JD
7591 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7592 in registerServicesMenuSendTypes.
7593 (validRequestorForSendType): Don't check ns_return_types.
7594
7595 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7596 ns_return_type.
7597
5df75e47
JR
75982011-07-08 Jason Rumney <jasonr@gnu.org>
7599
22610910
JR
7600 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7601 SH_SHOW for hidden windows (Bug#5482).
7602
5df75e47
JR
7603 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7604 frame struct members of non-existent frames (Bug#6284).
7605
699c10bd
JD
76062011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7607
4393663b
JD
7608 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7609 variable firstTime not needed on OSX >= 10.6.
7610 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7611 >= 10.5. Use setKnobProportion, setDoubleValue.
7612
7613 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7614 (MAC_OS_X_VERSION_10_5): Define if not defined.
7615 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7616 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7617 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7618
7619 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7620 cString and lossyCString on OSX >= 10.4
7621
58179cce 7622 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7623 sizeToFit on OSX >= 10.2.
7624
7625 * nsimage.m (allocInitFromFile): Don't use deprecated method
7626 bestRepresentationForDevice on OSX >= 10.6.
7627
7628 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7629 to avoid warning.
7630
7631 * emacs.c: Declare unexec_init_emacs_zone.
7632
a63e0781
JD
7633 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7634
699c10bd
JD
7635 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7636
7637 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7638 on svcsMenu (Bug#8842).
7639
7640 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7641 ns_return_types.
7642 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7643
7644 * nsterm.m (QUTF8_STRING): Declare.
7645 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7646 (validRequestorForSendType): Return type is (id).
7647 Change indexOfObjectIdenticalTo to indexOfObject.
7648 Check if we have local selection before returning self (Bug#8842).
7649 (writeSelectionToPasteboard): Put local selection into paste board
7650 if we have a local selection (Bug#8842).
7651 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7652
7653 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7654 (ns_get_local_selection): Declare.
7655
54e10184
LMI
76562011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7657
9888ff71
LMI
7658 * keymap.c (describe_map_tree): Don't insert a double newline at
7659 the end of the buffer (bug#1169) and return whether we inserted
7660 something.
7661
54e10184
LMI
7662 * callint.c (Fcall_interactively): Change "reading args" to
7663 "providing args" to try to clarify what it does (bug#1010).
7664
15fa4783
KH
76652011-07-07 Kenichi Handa <handa@m17n.org>
7666
7667 * composite.c (composition_compute_stop_pos): Ignore a static
7668 composition starting before CHARPOS (Bug#8915).
7669
7670 * xdisp.c (handle_composition_prop): Likewise.
7671
a8815b00
EZ
76722011-07-07 Eli Zaretskii <eliz@gnu.org>
7673
7674 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7675 (Bug#9015)
7676
ef7b981d 76772011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7678
7679 * character.h (unicode_category_t): New enum type.
7680
7681 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7682 (Qchar_code_property_table): New variable.
7683 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7684 (UNIPROP_COMPRESSED_FORM_P): New macros.
7685 (char_table_ascii): Uncompress the compressed values.
7686 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7687 Uncompress the compressed values.
ac389d0c 7688 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7689 (char_table_ref_and_range): Uncompress the compressed values.
7690 (sub_char_table_set): New arg is_uniprop. Callers changed.
7691 Uncompress the compressed values.
7692 (sub_char_table_set_range): Args changed. Callers changed.
7693 (char_table_set_range): Adjuted for the above change.
7694 (map_sub_char_table): Delete args default_val and parent. Add arg
7695 top. Give decoded values to a Lisp function.
640c8776 7696 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7697 values to a Lisp function. Gcpro more variables.
7698 (uniprop_table_uncompress)
7699 (uniprop_decode_value_run_length): New functions.
7700 (uniprop_decoder, uniprop_decoder_count): New variables.
7701 (uniprop_get_decoder, uniprop_encode_value_character)
7702 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7703 New functions.
7704 (uniprop_encoder, uniprop_encoder_count): New variables.
7705 (uniprop_get_encoder, uniprop_table)
7706 (Funicode_property_table_internal, Fget_unicode_property_internal)
7707 (Fput_unicode_property_internal): New functions.
7708 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7709 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7710 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7711 char-code-property-alist.
7712
640c8776 7713 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7714 Vunicode_category_table.
7715
640c8776 7716 * font.c (font_range): Adjust for the change of
c805dec0
KH
7717 Vunicode_category_table.
7718
76b397fb
DN
77192011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7720
7721 * m/iris4d.h: Remove file, move contents ...
7722 * s/irix6-5.h: ... here.
7723
22b4128e
PE
77242011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7725
7726 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7727 * alloc.c (mark_buffer):
7728 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7729 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7730 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7731 This isn't true in general, and it's particularly not true
7732 if Emacs is configured with --with-wide-int.
7733 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7734 New macros, used in the buffer.c change.
7735
869795d6
JD
77362011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7737
7738 * xsettings.c: Use both GConf and GSettings if both are available.
7739 (store_config_changed_event): Add comment.
7740 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7741 (store_tool_bar_style_changed): New functions.
5e617bc2 7742 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7743 (struct xsettings): Move font inside HAVE_XFT.
7744 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7745 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7746 Move inside HAVE_XFT.
640c8776 7747 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7748 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7749 also.
7750 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7751 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7752 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7753 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7754 (parse_settings): Move check for font inside HAVE_XFT.
7755 (read_settings, apply_xft_settings): Add comment.
7756 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7757 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7758 call store_font_name_changed.
7759 (xft_settings_event): Add comment.
7760 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7761 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7762 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7763 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7764 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7765 (xsettings_get_system_font, xsettings_get_system_normal_font):
7766 Add comment.
869795d6 7767
d8ed26bd
PE
77682011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7769
7770 Random fixes. E.g., (random) never returned negative values.
7771 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7772 subseconds part to the entropy, as that's a bit more random.
7773 Prefer signed to unsigned, since the signedness doesn't matter and
7774 in general we prefer signed. When given a limit, use a
7775 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7776 latter isn't right if USE_2_TAGS_FOR_INTS.
7777 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7778 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7779
cabf1cac
SM
77802011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7781
7782 * textprop.c (text_property_stickiness):
7783 Obey Vtext_property_default_nonsticky.
7784 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7785 * w32fns.c (syms_of_w32fns):
7786 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7787
6e9b2be9
PE
77882011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7789
7790 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7791 This is more efficient than Ffile_directory_p and avoids a minor race.
7792
90186c68
LMI
77932011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7794
7c301272
LMI
7795 * buffer.c (Foverlay_put): Say what the return value is
7796 (bug#7835).
7797
c4f2d8d4
LMI
7798 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7799 is a directory before asking whether to use the file name
7800 (bug#7564).
ad637907
LMI
7801 (barf_or_query_if_file_exists): Make the "File is a directory"
7802 error be more correct.
c4f2d8d4 7803
90186c68
LMI
7804 * fns.c (Frequire): Remove the mention of the .gz files, since
7805 that's installation-specific, but keep the mention of
7806 `get-load-suffixes'.
7807
da64016e
PE
78082011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7809
7810 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7811 Report string overflow if the output is too long.
7812
7d47b580
JB
78132011-07-04 Juanma Barranquero <lekktu@gmail.com>
7814
a555cb87
JB
7815 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7816 (syms_of_gnutls): Remove duplicate DEFSYM for
7817 Qgnutls_bootprop_verify_hostname_error, an error for
7818 Qgnutls_bootprop_verify_error (which is no longer used).
7819
7d47b580
JB
7820 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7821 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7822 Also (re)move comments that are misplaced or no longer relevant.
7823
1e49bfab
LMI
78242011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7825
7826 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7827
1485f4c0
CY
78282011-07-03 Chong Yidong <cyd@stupidchicken.com>
7829
7830 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7831 and background color parameters if they have been changed.
7832
a9ab721e
LMI
78332011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7834
7835 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7836
cf7cff57
PE
78372011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7838
2e13213d
PE
7839 * xsettings.c (SYSTEM_FONT): Define only when used.
7840 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7841
cf7cff57
PE
7842 * keymap.c (access_keymap_1): Now static.
7843
7a8e04f7
CY
78442011-07-02 Chong Yidong <cyd@stupidchicken.com>
7845
7846 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7847 leave any prefix arg for the up event (Bug#1586).
7848
61352f62
LMI
78492011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7850
69bb1ef7
LMI
7851 * lread.c (syms_of_lread): Mention single symbols defined by
7852 `defvar' or `defconst' (bug#7154).
7853
61352f62 7854 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7855 (Frequire): Mention get-load-suffixes.
61352f62 7856
28545e04
MR
78572011-07-02 Martin Rudalics <rudalics@gmx.at>
7858
7859 * window.h (window): Remove clone_number slot.
7860 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7861 Remove.
7862 (make_parent_window, make_window, saved_window)
7863 (Fset_window_configuration, save_window_save): Don't deal with
7864 clone numbers.
7865 * buffer.c (Qclone_number): Remove declaration.
7866 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7867
3349e122
SM
78682011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7869
7870 Add multiple inheritance to keymaps.
7871 * keymap.c (Fmake_composed_keymap): New function.
7872 (Fset_keymap_parent): Simplify.
7873 (fix_submap_inheritance): Remove.
7874 (access_keymap_1): New function extracted from access_keymap to handle
7875 embedded parents and handle lists of maps.
7876 (access_keymap): Use it.
7877 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7878 (Fcopy_keymap): Handle embedded parents.
7879 (Fcommand_remapping, define_as_prefix): Simplify.
7880 (Fkey_binding): Simplify.
7881 (syms_of_keymap): Move minibuffer-local-completion-map,
7882 minibuffer-local-filename-completion-map,
7883 minibuffer-local-must-match-map, and
7884 minibuffer-local-filename-must-match-map to Elisp.
7885 (syms_of_keymap): Defsubr make-composed-keymap.
7886 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7887 (parse_menu_item): Trivial simplification.
7888
3279eb87
GM
78892011-07-01 Glenn Morris <rgm@gnu.org>
7890
7891 * Makefile.in (SETTINGS_LIBS): Fix typo.
7892
4550efdf
KI
78932011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7894
7895 * coding.c (Fencode_coding_string): Record the last coding system
7896 used, as the function doc string says (bug#8738).
7897
0949d2b6
JD
78982011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7899
7900 * xsettings.c (store_monospaced_changed): Take new font as arg and
7901 check for change against current_mono_font.
7902 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7903 (emacs_settings_constructor, emacs_settings_get_property)
7904 (emacs_settings_set_property, emacs_settings_class_init)
7905 (emacs_settings_init, gsettings_obj): Remove.
7906 (something_changedCB): New function for HAVE_GSETTINGS.
7907 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7908 with value as argument.
7909 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7910 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7911 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7912 "changed".
7913
7914 * xgselect.c: Add defined (HAVE_GSETTINGS).
7915 (xgselect_initialize): Ditto.
7916
7917 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7918 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7919 xg_select.
7920
bbc6b304
PE
79212011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7922
7923 * eval.c (struct backtrace): Simplify and port the data structure.
7924 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7925 signed bit field, as this assumption is not portable and it makes
7926 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7927 "char debug_on_exit : 1" as this is not portable either; instead,
7928 use the portable "unsigned int debug_on_exit : 1". Remove unused
7929 member evalargs. Remove obsolete comments about cc bombing out.
7930
9851bfc5
JD
79312011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7932
51bb811f 7933 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7934 Let HAVE_GSETTINGS override HAVE_GCONF.
7935 (store_monospaced_changed): New function.
7936 (EMACS_SETTINGS): A new type derived from GObject to handle
7937 GSettings notifications.
7938 (emacs_settings_constructor, emacs_settings_get_property)
7939 (emacs_settings_set_property, emacs_settings_class_init):
7940 New functions.
7941 (gsettings_client, gsettings_obj): New variables.
7942 (GSETTINGS_SCHEMA): New define.
7943 (something_changedCB): Call store_monospaced_changed.
7944 (init_gsettings): New function.
7945 (xsettings_initialize): Call init_gsettings.
7946 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7947 to NULL.
7948
640c8776 7949 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7950 GCONF_CFLAGS/LIBS.
7951
5386012d
MR
79522011-06-29 Martin Rudalics <rudalics@gmx.at>
7953
7954 * window.c (resize_root_window, grow_mini_window)
7955 (shrink_mini_window): Rename Qresize_root_window to
7956 Qwindow_resize_root_window and Qresize_root_window_vertically to
7957 Qwindow_resize_root_window_vertically.
7958
f13e0b08
PE
79592011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7960
7961 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7962
94515237
JB
79632011-06-27 Juanma Barranquero <lekktu@gmail.com>
7964
7965 * makefile.w32-in: Redesign dependencies so they reflect more
7966 clearly which files are directly included by each source file,
7967 and not through other includes.
7968
e43b6e43
MR
79692011-06-27 Martin Rudalics <rudalics@gmx.at>
7970
7971 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7972 (sort_overlays, overlay_strings): When an overlay's clone number
7973 matches the window's clone number process the overlay even if
7974 the overlay's window property doesn't match the current window.
7975
d68443dc
MR
7976 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7977 (Fwindow_hchild): Rename to Fwindow_left_child.
7978 (Fwindow_next): Rename to Fwindow_next_sibling.
7979 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7980 (resize_window_check): Rename to window_resize_check.
7981 (resize_window_apply): Rename to window_resize_apply.
7982 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7983 (Fdelete_other_windows_internal, resize_frame_windows)
7984 (Fsplit_window_internal, Fdelete_window_internal)
7985 (grow_mini_window, shrink_mini_window)
7986 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7987
c7e73be5
JD
79882011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7989
7990 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7991 (emacs_fixed_set_min_size): Remove.
7992 (emacs_fixed_new): Take frame as argument.
7993
7994 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7995 (_EmacsFixedPrivate): Remove minwidth/height.
7996 Add struct frame *f.
7997 (emacs_fixed_init): Initialize priv->f.
7998 (get_parent_class, emacs_fixed_set_min_size): Remove.
7999 (emacs_fixed_new): Set priv->f to argument.
8000 (emacs_fixed_get_preferred_width)
8001 (emacs_fixed_get_preferred_height): Use min_width/height from
8002 frames size_hint to set minimum and natural (Bug#8919).
8003 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8004 and use min_width/height from frames size_hint to set
8005 min_width/height (Bug#8919).
8006
8007 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8008 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8009 Fix indentation.
c7e73be5 8010
cf99dcf8
EZ
80112011-06-26 Eli Zaretskii <eliz@gnu.org>
8012
8013 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8014 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8015 called at ZV.
8016
029529ac
CY
80172011-06-26 Chong Yidong <cyd@stupidchicken.com>
8018
8019 * process.c (wait_reading_process_output): Bypass select if
8020 waiting for a cell while ignoring keyboard input, and input is
8021 pending. Suggested by Jan Djärv (Bug#8869).
8022
7a7ef429
PE
80232011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8024
8025 Use gnulib's dup2 module instead of rolling our own.
8026 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8027
11fdef7d 80282011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8029
8030 * dispnew.c (scrolling_window): Before scrolling, turn off a
8031 mouse-highlight in the window being scrolled.
8032
cd3520a4
JB
80332011-06-24 Juanma Barranquero <lekktu@gmail.com>
8034
8035 Move DEFSYM to lisp.h and use everywhere.
8036
8037 * character.h (DEFSYM): Move declaration...
8038 * lisp.h (DEFSYM): ...here.
8039
8040 * gnutls.c:
8041 * minibuf.c:
8042 * w32menu.c:
8043 * w32proc.c:
8044 * w32select.c: Don't include character.h.
8045
8046 * alloc.c (syms_of_alloc):
8047 * buffer.c (syms_of_buffer):
8048 * bytecode.c (syms_of_bytecode):
8049 * callint.c (syms_of_callint):
8050 * casefiddle.c (syms_of_casefiddle):
8051 * casetab.c (init_casetab_once):
8052 * category.c (init_category_once, syms_of_category):
8053 * ccl.c (syms_of_ccl):
8054 * cmds.c (syms_of_cmds):
8055 * composite.c (syms_of_composite):
8056 * dbusbind.c (syms_of_dbusbind):
8057 * dired.c (syms_of_dired):
8058 * dispnew.c (syms_of_display):
8059 * doc.c (syms_of_doc):
8060 * editfns.c (syms_of_editfns):
8061 * emacs.c (syms_of_emacs):
8062 * eval.c (syms_of_eval):
8063 * fileio.c (syms_of_fileio):
8064 * fns.c (syms_of_fns):
8065 * frame.c (syms_of_frame):
8066 * fringe.c (syms_of_fringe):
8067 * insdel.c (syms_of_insdel):
8068 * keymap.c (syms_of_keymap):
8069 * lread.c (init_obarray, syms_of_lread):
8070 * macros.c (syms_of_macros):
8071 * msdos.c (syms_of_msdos):
8072 * print.c (syms_of_print):
8073 * process.c (syms_of_process):
8074 * search.c (syms_of_search):
8075 * sound.c (syms_of_sound):
8076 * syntax.c (init_syntax_once, syms_of_syntax):
8077 * terminal.c (syms_of_terminal):
8078 * textprop.c (syms_of_textprop):
8079 * undo.c (syms_of_undo):
8080 * w32.c (globals_of_w32):
8081 * window.c (syms_of_window):
8082 * xdisp.c (syms_of_xdisp):
8083 * xfaces.c (syms_of_xfaces):
8084 * xfns.c (syms_of_xfns):
8085 * xmenu.c (syms_of_xmenu):
8086 * xsettings.c (syms_of_xsettings):
8087 * xterm.c (syms_of_xterm): Use DEFSYM.
8088
4228cf16
TZ
80892011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8090
cd3520a4 8091 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8092
7fcccf1e
PE
80932011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8094
7efb4e0e
PE
8095 Integer and buffer overflow fixes (Bug#8873).
8096
ff5844ad
PE
8097 * print.c (printchar, strout): Check for string overflow.
8098 (PRINTPREPARE, printchar, strout):
8099 Don't set size unless allocation succeeds.
8100
90532f02
PE
8101 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8102 for sizes. Check for string overflow more accurately.
8103 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8104
6d84508d
PE
8105 * macros.c: Integer and buffer overflow fixes.
8106 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8107 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8108 Use ptrdiff_t, not int, for sizes.
8109 Don't increment bufsize until after realloc succeeds.
8110 Check for size-calculation overflow.
8111 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8112
437b2cb4
PE
8113 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8114
8b9ac8b4
PE
8115 * lread.c: Integer overflow fixes.
8116 (read_integer): Radix is now EMACS_INT, not int,
8117 to improve quality of diagnostics for out-of-range radices.
8118 Calculate buffer size correctly for out-of-range radices.
8119 (read1): Check for integer overflow in radices, and in
8120 read-circle numbers.
82cb60d3
PE
8121 (read_escape): Avoid int overflow.
8122 (Fload, openp, read_buffer_size, read1)
8123 (substitute_object_recurse, read_vector, read_list, map_obarray):
8124 Use ptrdiff_t, not int, for sizes.
8125 (read1): Use EMACS_INT, not int, for sizes.
20270765 8126 Check for size overflow.
8b9ac8b4 8127
7fcccf1e
PE
8128 * image.c (cache_image): Check for size arithmetic overflow.
8129
bfbbd7e7
PE
8130 * lread.c: Integer overflow issues.
8131 (saved_doc_string_size, saved_doc_string_length)
8132 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8133 Now ptrdiff_t, not int.
8134 (read1): Don't assume doc string length fits in int. Check for
8135 out-of-range doc string lengths.
8136 (read_list): Don't assume file position fits in int.
39019e54 8137 (read_escape): Check for hex character overflow.
bfbbd7e7 8138
4e323265
LL
81392011-06-22 Leo Liu <sdl.web@gmail.com>
8140
8141 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8142 Move to minibuffer.el.
8143
85fece3e
PE
81442011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8145
20b84ce9 8146 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8147 The following patches are for when GLYPH_DEBUG && !XASSERT.
8148 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8149 * dispnew.c (flush_stdout):
8150 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8151 Mark as externally visible.
8152 * dispnew.c (check_window_matrix_pointers): Now static.
8153 * dispnew.c (window_to_frame_vpos):
8154 * xfns.c (unwind_create_frame):
8155 * xterm.c (x_check_font): Remove unused local.
8156 * scroll.c (CHECK_BOUNDS):
8157 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8158 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8159 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8160 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8161 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8162 Now static.
8163 (debug_method_add): Use va_list and vsprintf rather than relying
8164 on undefined behavior with wrong number of arguments.
8165 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8166 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8167 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8168 since we're not interested in debugging glyphs with old libraries.
8169 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8170 GCC 4.6.0's static checking.
8171
0766b489
PE
81722011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8173
31fd4b32
PE
8174 Integer overflow and signedness fixes (Bug#8873).
8175 A few related buffer overrun fixes, too.
8176
b79e8648
PE
8177 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8178
0766b489
PE
8179 * dispextern.h (struct face.stipple):
8180 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8181 (x_bitmap_mask, x_allocate_bitmap_record)
8182 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8183 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8184 (x_create_bitmap_from_xpm_data):
8185 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8186 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8187 (.bitmaps_last):
8188 * xfaces.c (load_pixmap):
8189 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8190 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8191 (.bitmaps_last, struct x_output.icon_bitmap):
8192 Use ptrdiff_t, not int, for bitmap indexes.
8193 (x_allocate_bitmap_record): Check for size overflow.
8194 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8195
b081724f
PE
8196 Use ptrdiff_t, not int, for overlay counts.
8197 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8198 * editfns.c (overlays_around, get_pos_property):
8199 * textprop.c (get_char_property_and_overlay):
8200 * xdisp.c (next_overlay_change, note_mouse_highlight):
8201 * xfaces.c (face_at_buffer_position):
21514da7
PE
8202 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8203 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8204 (Fnext_overlay_change, Fprevious_overlay_change)
8205 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8206 Use ptrdiff_t, not int, for sizes.
21514da7 8207 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8208
3de73e5e
PE
8209 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8210
2606c57b
PE
8211 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8212 (x_session_initialize): Do not assume string length fits in int.
8213
aaafe47a
PE
8214 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8215 This is unlikely, but can occur if DPI is outlandish.
8216
2674ddc8 8217 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8218 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8219
28154962
PE
8220 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8221 * xrdb.c (magic_file_p, search_magic_path):
8222 Omit last arg SUFFIX; it was always 0. All callers changed.
8223 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8224
7de51af5
PE
8225 * xfont.c (xfont_match): Avoid need for strlen.
8226
25ed6cc3
PE
8227 * xfns.c: Don't assume strlen fits in int.
8228 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8229
4eab31dd
PE
8230 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8231 not unsigned long, as we prefer signed integers. All callers changed.
8232 Detect integer overflow in repeat count.
8233 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8234 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8235
171e2a58
PE
8236 * termcap.c: Don't assume sizes fit in int and never overflow.
8237 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8238 (gobble_line): Check for size-calculation overflow.
8239
ad39faca 8240 * minibuf.c (Fread_buffer):
6e5bb2dc 8241 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8242 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8243 Don't assume string length fits in int.
8244
52c61c22 8245 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8246 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8247
b5b8c9e5
PE
8248 * font.c: Don't assume string length fits in int.
8249 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8250 Use ptrdiff_t, not int.
ccd6111c
PE
8251 (font_intern_prop): Don't assume string length fits in int.
8252 Don't assume integer property fits in fixnum.
8253 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8254
882f0d81 8255 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8256 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8257 Reformulate so as not to need the command string.
8258 Invoke gzip -cd rather than gunzip, as it's more portable.
8259 (lock_info_type, lock_file_1, lock_file):
8260 Don't assume pid_t and time_t fit in unsigned long.
8261 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8262 (current_lock_owner): Prefer signed type for sizes.
8263 Use memcpy, not strncpy, where memcpy is what is really wanted.
8264 Don't assume (via atoi) that time_t and pid_t fit in int.
8265 Check for time_t and/or pid_t out of range, e.g., via a network share.
8266 Don't alloca where an auto var works fine.
8267
93f4cf88
PE
8268 * fileio.c: Fix some integer overflow issues.
8269 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8270 Don't assume string length fits in int.
8271 (directory_file_name): Don't assume string length fits in long.
8272 (make_temp_name): Don't assume pid fits in int, or that its print
8273 length is less than 20.
8274
f3e92b69
PE
8275 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8276
1bfdaf10
PE
8277 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8278
35016e9a
PE
8279 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8280
3d1e65a1
PE
8281 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8282 We prefer signed integers, even for size calculations.
8283
0b963a93
PE
8284 * emacs.c: Don't assume string length fits in 'int'.
8285 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8286 (main): Don't invoke strlen when not needed.
8287
573f4b54
PE
8288 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8289 (XD_DEBUG_MESSAGE): Don't waste a byte.
8290
989f33ba
PE
8291 * callproc.c (getenv_internal_1, getenv_internal)
8292 (Fgetenv_internal):
965d34eb
PE
8293 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8294
e4d29b33
PE
8295 * lread.c (invalid_syntax): Omit length argument.
8296 All uses changed. This doesn't fix a bug, but it simplifies the
8297 code away from its former Hollerith-constant appearance, and it's
8298 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8299 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8300
eb49b136
PE
8301 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8302 This didn't break anything, but it didn't help either.
8303 It's confusing to put a bogus integer in a place where the actual
8304 value does not matter.
9f62aeb1 8305 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8306 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8307
15375a22
PE
8308 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8309 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8310 implementation.
b61cc01c
PE
8311 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8312 We prefer signed types, and the value cannot exceed the EMACS_INT
8313 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8314 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8315 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8316 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8317
53b2623d
PE
8318 * indent.c (sane_tab_width): New function.
8319 (current_column, scan_for_column, Findent_to, position_indentation)
8320 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8321 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8322
51cab52b 8323 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8324
f2ed8a70
PE
8325 * lisp.h (lint_assume): New macro.
8326 * composite.c (composition_gstring_put_cache):
8327 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8328
abe80cc6
PE
8329 * editfns.c, insdel.c:
8330 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8331
b02c740e
PE
8332 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8333
ebc96716
PE
8334 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8335
b4e50fa0 8336 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8337 Use much-faster test for byte-length change.
311d5d7c 8338 Don't assume string byte-length fits in 'int'.
a4cf38e4 8339 Check that character arg fits in 'int'.
85461888 8340 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8341
c0c1ee9f
PE
8342 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8343
a498d7f4
PE
8344 * fns.c (concat): Catch string overflow earlier.
8345 Do not rely on integer wraparound.
8346
51cab52b
PE
8347 * dispextern.h (struct it.overlay_strings_charpos)
8348 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8349 * xdisp.c (forward_to_next_line_start)
8350 (back_to_previous_visible_line_start)
8351 (reseat_at_next_visible_line_start, next_element_from_buffer):
8352 Don't arbitrarily truncate the value of 'selective' to int.
8353
76031fad
PE
8354 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8355
5eb55db9
PE
8356 * composite.c: Don't truncate sizes to 'int'.
8357 (composition_gstring_p, composition_reseat_it)
8358 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8359 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8360 not EMACS_UINT, for indexes.
5eb55db9 8361
0703a717
PE
8362 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8363
d6202519
PE
8364 * buffer.c: Include <verify.h>.
8365 (struct sortvec.priority, struct sortstr.priority):
8961a454 8366 Now EMACS_INT, not int.
c20998a7 8367 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8368 (struct sortstr.size, record_overlay_string)
8369 (struct sortstrlist.size, struct sortlist.used):
8370 Don't truncate size to int.
8371 (record_overlay_string): Check for size-calculation overflow.
d6202519 8372 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8373
d5a19415
JM
83742011-06-22 Jim Meyering <meyering@redhat.com>
8375
029529ac 8376 Don't leak an XBM-image-sized buffer
d5a19415
JM
8377 * image.c (xbm_load): Free the image buffer after using it.
8378
a9041e6c
PE
83792011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8380
8381 Port to Sun C.
8382 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8383 that Sun C diagnosed.
8384 * fns.c (secure_hash): Fix pointer signedness issue.
8385 * intervals.c (static_offset_intervals): New function.
8386 (offset_intervals): Use it.
8387
7f3f739f
LL
83882011-06-21 Leo Liu <sdl.web@gmail.com>
8389
8390 * deps.mk (fns.o):
8391 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8392 sha512.h.
8393
8394 * fns.c (secure_hash): Rename from crypto_hash_function and change
8395 the first arg to accept symbols.
5b66d427 8396 (Fsecure_hash): New primitive.
7f3f739f
LL
8397 (syms_of_fns): New symbols.
8398
76147d94
DD
83992011-06-20 Deniz Dogan <deniz@dogan.se>
8400
8401 * process.c (Fset_process_buffer): Clarify return value in
8402 docstring.
8403
7d7d0045
CY
84042011-06-18 Chong Yidong <cyd@stupidchicken.com>
8405
8406 * dispnew.c (add_window_display_history): Use BVAR.
8407
8408 * xdisp.c (debug_method_add): Use BVAR.
8409 (check_window_end, dump_glyph_matrix, dump_glyph)
8410 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8411
8412 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8413 Likewise.
8414
8415 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8416 check till after the cache is created in init_frame_faces.
8417
ff2bc410
SM
84182011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8419
8420 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8421
28177add
PE
84222011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8423
dd3482fe
PE
8424 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8425 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8426 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8427
393d71f3 8428 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8429 * fileio.c (Finsert_file_contents):
8430 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8431 Remove the old (too-loose) buffer overflow checks.
8432 They weren't needed, since make_gap checks for buffer overflow.
8433 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8434 The old code merely checked for Emacs fixnum overflow, and relied
8435 on undefined (wraparound) behavior. The new code avoids undefined
8436 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8437
2e6813b0 8438 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8439 Tune. Don't use wider integers than needed. Don't use alloca.
8440 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8441
599a9e4f
PE
8442 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8443
99561444
PE
8444 * insdel.c, lisp.h (buffer_overflow): New function.
8445 (insert_from_buffer_1, replace_range, replace_range_2):
8446 * insdel.c (make_gap_larger):
8447 * editfns.c (Finsert_char):
8448 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8449
28177add
PE
8450 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8451
e69dafad
PE
84522011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8453
4baa020d 8454 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8455
b1c46f02
PE
8456 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8457 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8458
e69dafad
PE
8459 * fileio.c: Don't assume EMACS_INT fits in off_t.
8460 (emacs_lseek): New static function.
8461 (Finsert_file_contents, Fwrite_region): Use it.
8462 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8463
566684ea
PE
8464 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8465
e6966cd6
PE
8466 * fns.c: Don't overflow int when computing a list length.
8467 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8468 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8469 truncation on 64-bit hosts. Check for QUIT every
8470 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8471 faster and is responsive enough.
8472 (Flength): Report an error instead of overflowing an integer.
8473 (Fsafe_length): Return a float if the value is not representable
8474 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8475 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8476 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8477
dd0b0efb
PE
8478 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8479 (header_size, word_size): New constants.
8480 (allocate_vectorlike): Don't check size overflow here.
8481 (allocate_vector): Check it here instead, since this is the only
8482 caller of allocate_vectorlike that could cause overflow.
8483 Check that the new vector's length is representable as a fixnum.
8484
86fe5cfe
PE
8485 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8486 The previous code was bogus. For example, next_almost_prime (32)
8487 returned 39, which is undesirable as it is a multiple of 3; and
8488 next_almost_prime (24) returned 25, which is a multiple of 5 so
8489 why was the code bothering to check for multiples of 7?
8490
80e88859
PE
8491 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8492
4a2f0ad6
PE
8493 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8494
f66c7cf8
PE
8495 Variadic C functions now count arguments with ptrdiff_t.
8496 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8497 Back then I didn't know that the Emacs coding style prefers signed int.
8498 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8499 were being counted with int, which may truncate counts on 64-bit
8500 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8501 * lisp.h (struct Lisp_Subr.function.aMANY)
8502 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8503 Arg counts are now ptrdiff_t, not size_t.
8504 All variadic functions and their callers changed accordingly.
8505 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8506 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8507 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8508 * callint.c (Fcall_interactively): Check arg count for overflow,
8509 to avoid potential buffer overrun. Use signed char, not 'int',
8510 for 'varies' array, so that we needn't bother to check its size
8511 calculation for overflow.
8512 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8513 * eval.c (apply_lambda):
8514 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8515 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8516 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8517
a1759b76
PE
8518 * callint.c (Fcall_interactively): Don't use index var as event count.
8519
d96be9fc
PE
8520 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8521 * mem-limits.h (SIZE): Remove; no longer used.
8522
a690a978 8523 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8524
578c21e6
PE
8525 Remove unnecessary casts.
8526 * xterm.c (x_term_init):
8527 * xfns.c (x_set_border_pixel):
8528 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8529 These aren't needed now that we assume ANSI C.
8530
96f53c6c
PE
8531 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8532 It's more likely to cause problems (due to unsigned overflow)
8533 than to cure them.
8534
83c77d31
PE
8535 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8536
ee2079f1
PE
8537 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8538
6da65536
PE
8539 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8540
7147c4a4
PE
8541 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8542
193e32d9
PE
8543 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8544
e5533da6
PE
8545 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8546
9910e595
PE
8547 GLYPH_CODE_FACE returns EMACS_INT, not int.
8548 * dispextern.h (merge_faces):
8549 * xfaces.c (merge_faces):
01103c44
PE
8550 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8551 Don't assume EMACS_INT fits in int.
9910e595 8552
2638320e
PE
8553 * character.h (CHAR_VALID_P): Remove unused parameter.
8554 * fontset.c, lisp.h, xdisp.c: All uses changed.
8555
045eb8d9
PE
8556 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8557
c1f134b5
PE
8558 * fns.c (concat): Minor tuning based on overflow analysis.
8559 This doesn't fix any bugs. Use int to hold character, instead
8560 of constantly refetching from Emacs object. Use XFASTINT, not
8561 XINT, for value known to be a character. Don't bother comparing
8562 a single byte to 0400, as it's always less.
8563
395fcb93 8564 * floatfns.c (Fexpt):
327eeec8
PE
8565 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8566
abbd3d23
PE
8567 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8568 for characters.
8569
684a03ef
PE
8570 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8571
0fed43f3
PE
8572 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8573 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8574 incorrectly succeed when S was a string, because 4294967386 was
8575 truncated before it was used.
8576
8fd02eb7
PE
8577 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8578 Otherwise, an out-of-range integer could cause undefined behavior
8579 on a 64-bit host.
8580
f8c86b69
PE
8581 * composite.c: Use int, not EMACS_INT, for characters.
8582 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8583 EMACS_INT, for values that are known to be in character range.
8584 This doesn't fix any bugs but is the usual style inside Emacs and
8585 may generate better code on 32-bit machines.
8586
34206dd2
PE
8587 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8588 This is for reasons similar to the recent CHAR_STRING fix.
8589 * charset.c (Fencode_char): Check that character arg is actually
8590 a character. Pass an int to ENCODE_CHAR.
8591 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8592 wider than 'int', as a compile-time check to prevent future regressions
8593 in this area.
8594
c5958d4c 8595 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8596
8597 Make sure a 64-bit char is never passed to CHAR_STRING.
8598 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8599 by silently ignoring the top 32 bits, allowing some values
8600 that were far too large to be valid characters.
8601 * character.h: Include <verify.h>.
8602 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8603 arguments are no wider than unsigned, as a compile-time check
8604 to prevent future regressions in this area.
8605 * data.c (Faset):
01103c44 8606 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8607 (Fsubst_char_in_region):
8608 * fns.c (concat):
8609 * xdisp.c (decode_mode_spec_coding):
8610 Adjust to CHAR_STRING's new requirement.
8611 * editfns.c (Finsert_char, Fsubst_char_in_region):
8612 * fns.c (concat): Check that character args are actually
8613 characters. Without this test, these functions did the wrong
8614 thing with wildly out-of-range values on 64-bit hosts.
8615
d37ca623
PE
8616 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8617 These casts should not be needed on 32-bit hosts, either.
8618 * keyboard.c (read_char):
8619 * lread.c (Fload): Remove casts to unsigned.
8620
ea204efb
PE
8621 * lisp.h (UNSIGNED_CMP): New macro.
8622 This fixes comparison bugs on 64-bit hosts.
8623 (ASCII_CHAR_P): Use it.
8624 * casefiddle.c (casify_object):
01103c44 8625 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8626 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8627 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8628 * dispextern.h (FACE_FROM_ID):
8629 * keyboard.c (read_char): Use UNSIGNED_CMP.
8630
41cb286c
PE
8631 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8632 not to EMACS_INT, to avoid GCC warning.
8633
4a1b9832
PE
8634 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8635
55daad71
PE
8636 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8637 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8638 isn't needed on 32-bit machines.
8f95c75c 8639
01103c44
PE
8640 * buffer.c (Fgenerate_new_buffer_name):
8641 Use EMACS_INT for count, not int.
0ceccced 8642 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8643
8644 * data.c (Qcompiled_function): Now static.
8645
c6f072e7
PE
8646 * window.c (window_body_lines): Now static.
8647
20ce5912
PE
8648 * image.c (gif_load): Rename local to avoid shadowing.
8649
9c4c5f81
PE
8650 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8651 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8652 * alloc.c (make_save_value): Integer argument is now of type
8653 ptrdiff_t, not int.
8654 (mark_object): Use ptrdiff_t, not int.
8655 * lisp.h (pD): New macro.
8656 * print.c (print_object): Use it.
8657
c0c5c8ae
PE
8658 * alloc.c: Use EMACS_INT, not int, to count objects.
8659 (total_conses, total_markers, total_symbols, total_vector_size)
8660 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8661 (total_free_floats, total_floats, total_free_intervals)
8662 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8663 Now EMACS_INT, not int. All uses changed.
8664 (Fgarbage_collect): Compute overall total using a double, so that
8665 integer overflow is less likely to be a problem. Check for overflow
8666 when converting back to an integer.
5a25e253
PE
8667 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8668 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8669 These were 'int' variables that could overflow on 64-bit hosts;
8670 they were never used, so remove them instead of repairing them.
211a0b2a 8671 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8672 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8673 Previously, this ceilinged at INT_MAX, but that doesn't work on
8674 64-bit machines.
e46bb31a 8675 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8676
c78baabf 8677 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8678 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8679 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8680 when a (possibly-narrower) signed value would do just as well.
8681 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8682
c9d624c6
PE
8683 * alloc.c: Catch some string size overflows that we were missing.
8684 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8685 for convenience in STRING_BYTES_MAX.
8686 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8687 The definition here is exact; the one in lisp.h was approximate.
8688 (allocate_string_data): Check for string overflow. This catches
8689 some instances we weren't catching before. Also, it catches
8690 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8691 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8692 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8693
c9d624c6
PE
8694 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8695 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8696 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8697
353032ce
PE
8698 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8699
2bccce07
PE
8700 * alloc.c (Fmake_string): Check for out-of-range init.
8701
0ac30604
SM
87022011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8703
8704 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8705
c195f2de
JD
87062011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8707
8708 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8709 xg_get_default_scrollbar_width.
8710
8711 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8712 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8713 (style_changed_cb): Call update_theme_scrollbar_width and call
8714 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8715 all frames (Bug#8505).
8716 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8717 Call gtk_window_set_resizable if HAVE_GTK3.
8718 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8719 and height if HAVE_GTK3 (Bug#8505).
8720 (scroll_bar_width_for_theme): New variable.
8721 (update_theme_scrollbar_width): New function.
8722 (xg_get_default_scrollbar_width): Move code to
8723 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8724 (xg_initialize): Call update_theme_scrollbar_width.
8725
8726 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8727
8728 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8729
e10ac9f1
MR
87302011-06-12 Martin Rudalics <rudalics@gmx.at>
8731
8732 * frame.c (make_frame): Call other_buffer_safely instead of
8733 other_buffer.
8734
8735 * window.c (temp_output_buffer_show): Call display_buffer with
8736 second argument Vtemp_buffer_show_specifiers and reset latter
8737 immediately after the call.
8738 (Vtemp_buffer_show_specifiers): New variable.
8739 (auto_window_vscroll_p, next_screen_context_lines)
8740 (Vscroll_preserve_screen_position): Remove leading asterisks from
8741 doc-strings.
8742
2d3c217e 87432011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8744
7b7f97e8 8745 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8746 * buffer.c (Qclone_number): Remove for now, as it's unused.
8747 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8748 (record_buffer): Remove unused local.
8749 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8750 (set_frame_buffer_list): Remove; unused.
8751 * frame.h (other_visible_frames): Remove decl.
8752 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8753 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8754 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8755 if HAVE_GPM.
8756 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8757 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8758 Define only if HAVE_GPM.
8759 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8760 (update_hints_inhibit): Remove; never set. All uses removed.
8761 * widgetprv.h (emacsFrameClassRec): Remove decl.
8762 * window.c (delete_deletable_window): Now returns void, since it
8763 wasn't returning anything.
8764 (compare_window_configurations): Remove unused locals.
8765 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8766 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8767 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8768 the same widths as pointers. This follows up on the 2011-05-06 patch.
8769 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8770 * xterm.h: Likewise.
8771 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8772
1384b89e
JB
87732011-06-12 Juanma Barranquero <lekktu@gmail.com>
8774
8775 * makefile.w32-in: Update dependencies.
8776 (LISP_H): Add lib/intprops.h.
8777
1100a63c
CY
87782011-06-11 Chong Yidong <cyd@stupidchicken.com>
8779
8780 * image.c (gif_load): Add animation frame delay to the metadata.
8781 (syms_of_image): Use DEFSYM. New symbol `delay'.
8782
6198ccd0
MR
87832011-06-11 Martin Rudalics <rudalics@gmx.at>
8784
8785 * window.c (delete_deletable_window): Re-add.
8786 (Fset_window_configuration): Rewrite to handle dead buffers and
8787 consequently deletable windows.
8788 (window_tree, Fwindow_tree): Remove. Supply functionality in
8789 window.el.
8790 (compare_window_configurations): Simplify code.
8791
b6e3633c
AS
87922011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8793
1ab0dee5
AS
8794 * image.c (imagemagick_load_image): Fix type mismatch.
8795 (Fimagemagick_types): Likewise.
8796
b6e3633c
AS
8797 * window.h (replace_buffer_in_windows): Declare.
8798
9397e56f
MR
87992011-06-11 Martin Rudalics <rudalics@gmx.at>
8800
8801 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8802 Qclone_number. Remove external declaration of Qdelete_window.
8803 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8804 code.
640c8776
SM
8805 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8806 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8807 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8808 buffer list implementation.
8809 (other_buffer_safely): New function.
8810 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8811 calls to replace_buffer_in_windows and
8812 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8813 if allowed.
8814 (record_buffer): Inhibit quitting and rewrite using quittable
8815 functions. Run Qbuffer_list_update_hook if allowed.
8816 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8817 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8818 Move switch-to-buffer to window.el.
9397e56f
MR
8819 (bury-buffer): Move to window.el.
8820 (Vbuffer_list_update_hook): New variable.
8821
8822 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8823 section.
8824
8825 * window.h (resize_frame_windows): Move up in code.
8826 (Fwindow_frame): Remove EXFUN.
8827 (replace_buffer_in_all_windows): Remove prototype.
8828 (replace_buffer_in_windows_safely): Add prototype.
8829
8830 * window.c: Declare Qdelete_window static again. Move down
8831 declaration of select_count.
8832 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8833 (Fother_window): Move to window.el.
8834 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8835 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8836 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8837 window.el.
8838 (replace_buffer_in_windows): Implement by calling
8839 Qreplace_buffer_in_windows.
8840 (replace_buffer_in_all_windows): Remove with some functionality
8841 moved into replace_buffer_in_windows_safely.
8842 (replace_buffer_in_windows_safely): New function.
8843 (select_window_norecord, select_frame_norecord): Move in front
8844 of run_window_configuration_change_hook. Remove now obsolete
8845 declarations.
640c8776
SM
8846 (Fset_window_buffer): Rewrite doc-string.
8847 Call Qrecord_window_buffer.
9397e56f
MR
8848 (keys_of_window): Move binding for other-window to window.el.
8849
b50691aa
CY
88502011-06-11 Chong Yidong <cyd@stupidchicken.com>
8851
8852 * dispextern.h (struct image): Replace data member, whose int_val
8853 and ptr_val fields were not used by anything, with a single
8854 lisp_val object.
8855
8856 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8857 (gif_clear_image, gif_load, imagemagick_load_image)
8858 (gs_clear_image, gs_load): Callers changed.
8859
3f754b86
PE
88602011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8861
cca69397
PE
8862 * buffer.h: Include <time.h>, for time_t.
8863 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8864
109e28d0
PE
8865 Fix minor problems found by static checking.
8866
60737f02
PE
8867 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8868
4b66faf3
PE
8869 Make identifiers static if they are not used in other modules.
8870 * data.c (Qcompiled_function, Qframe, Qvector):
8871 * image.c (QimageMagick, Qsvg):
8872 * minibuf.c (Qmetadata):
8873 * window.c (resize_window_check, resize_root_window): Now static.
8874 * window.h (resize_window_check, resize_root_window): Remove decls.
8875
109e28d0
PE
8876 * window.c (window_deletion_count, delete_deletable_window):
8877 Remove; unused.
46a4ce9e
PE
8878 (window_body_lines): Now static.
8879 (Fdelete_other_windows_internal): Mark vars as initialized.
8880 Make sure 'resize_failed' is initialized.
8881 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8882 (resize_window_apply): Remove unused local.
8883 * window.h (delete_deletable_window): Remove decl.
8884
109e28d0 8885 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8886 (imagemagick_load_image): Fix pointer signedness problem by changing
8887 last arg from unsigned char * to char *. All uses changed.
8888 Also, fix a local for similar reasons.
8889 Remove unused locals. Remove locals to avoid shadowing.
8890 (fn_rsvg_handle_free): Remove; unused.
8891 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8892 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8893
3f754b86
PE
8894 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8895
2547adb1
CY
88962011-06-10 Chong Yidong <cyd@stupidchicken.com>
8897
8898 * image.c (gif_load): Fix omitted cast error introduced by
8899 2011-06-06 change.
8900
2c8e37d4
MR
89012011-06-10 Martin Rudalics <rudalics@gmx.at>
8902
8903 * window.h (resize_proportionally, orig_total_lines)
8904 (orig_top_line): Remove from window structure.
8905 (set_window_height, set_window_width, change_window_heights)
8906 (Fdelete_window): Remove prototypes.
8907 (resize_frame_windows): Remove duplicate declaration.
8908
440a42e3
EZ
89092011-06-10 Eli Zaretskii <eliz@gnu.org>
8910
8911 * window.h (resize_frame_windows, resize_window_check)
8912 (delete_deletable_window, resize_root_window)
8913 (resize_frame_windows): Declare prototypes.
8914
8915 * window.c (resize_window_apply): Make definition be "static" to
8916 match the prototype.
8917
562dd5e9
MR
89182011-06-10 Martin Rudalics <rudalics@gmx.at>
8919
8920 * window.c: Remove declarations of Qwindow_size_fixed,
8921 window_min_size_1, window_min_size_2, window_min_size,
8922 size_window, window_fixed_size_p, enlarge_window, delete_window.
8923 Remove static from declaration of Qdelete_window, it's
8924 temporarily needed by Fbury_buffer.
8925 (replace_window): Don't assign orig_top_line and
8926 orig_total_lines.
8927 (Fdelete_window, delete_window): Remove. Window deletion is
8928 handled by window.el.
640c8776
SM
8929 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8930 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8931 (Fdelete_other_windows): Remove. Deleting other windows is
8932 handled by window.el.
8933 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8934 handled in window.el.
8935 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8936 Window minimum sizes are handled in window.el.
8937 (shrink_windows, size_window, set_window_height)
8938 (set_window_width, change_window_heights, window_height)
8939 (window_width, CURBEG, CURSIZE, enlarge_window)
8940 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8941 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8942 handled in window.el.
8943 (make_dummy_parent): Rename to make_parent_window and give it a
8944 second argument horflag.
8945 (make_window): Don't set resize_proportionally any more.
8946 (Fsplit_window): Remove. Windows are split in window.el.
8947 (save_restore_action, save_restore_orig_size)
8948 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8949 Resize mini windows in window.el.
8950 (grow_mini_window, shrink_mini_window): Implement by calling
8951 Qresize_root_window_vertically, resize_window_check and
8952 resize_window_apply.
640c8776
SM
8953 (saved_window, Fset_window_configuration, save_window_save):
8954 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8955 resize_proportionally.
8956 (window_min_height, window_min_width): Move to window.el.
8957 (keys_of_window): Move bindings for delete-other-windows,
8958 split-window, delete-window and enlarge-window to window.el.
8959
8960 * buffer.c: Temporarily extern Qdelete_window.
8961 (Fbury_buffer): Temporarily call Qdelete_window instead of
8962 Fdelete_window (Fbury_buffer will move to window.el soon).
8963
8964 * frame.c (set_menu_bar_lines_1): Remove code handling
8965 orig_top_line and orig_total_lines.
8966
8967 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8968 set_window_height but set heights directly.
8969 (change_frame_size_1): Use resize_frame_windows.
8970
8971 * xdisp.c (init_xdisp): Don't use set_window_height but set
8972 heights directly.
8973
640c8776
SM
8974 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8975 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8976 run_window_configuration_change_hook.
8977
8978 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8979 instead of change_window_heights and run
8980 run_window_configuration_change_hook.
8981
1a13852e
MR
89822011-06-09 Martin Rudalics <rudalics@gmx.at>
8983
8984 * window.c (replace_window): Rename second argument REPLACEMENT to
8985 NEW. New third argument SETFLAG. Rewrite.
8986 (delete_window, make_dummy_parent): Call replace_window with
8987 third argument 1.
8988 (window_list_1): Move down in code.
8989 (run_window_configuration_change_hook): Move set_buffer part
8990 before select_frame_norecord part in order to unwind correctly.
8991 Rename count1 to count.
8992 (recombine_windows, delete_deletable_window, resize_root_window)
8993 (Fdelete_other_windows_internal)
8994 (Frun_window_configuration_change_hook, make_parent_window)
8995 (resize_window_check, resize_window_apply, Fresize_window_apply)
8996 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8997 (Fdelete_window_internal, Fresize_mini_window_internal):
8998 New functions.
1a13852e
MR
8999 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9000
f3d1777e
MR
90012011-06-08 Martin Rudalics <rudalics@gmx.at>
9002
496e208e
MR
9003 * window.h (window): Add some new members to window structure -
9004 normal_lines, normal_cols, new_total, new_normal, clone_number,
9005 splits, nest, prev_buffers, next_buffers.
9006 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9007 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9008
f3d1777e
MR
9009 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9010 Remove.
496e208e
MR
9011 (make_dummy_parent): Set new members of windows structure.
9012 (make_window): Move down in code. Handle new members of window
9013 structure.
9014 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9015 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9016 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9017 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9018 (Fset_window_next_buffers, Fset_window_clone_number):
9019 New functions.
496e208e
MR
9020 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9021 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9022 Doc-string fixes.
9023 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9024 Argument WINDOW can be now internal window too.
9025 (Fwindow_use_time): Move up in code.
9026 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9027 Rewrite doc-string.
9028 (Fset_window_configuration, saved_window)
9029 (Fcurrent_window_configuration, save_window_save): Handle new
9030 members of window structure.
b9e809c2
MR
9031 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9032 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9033 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9034 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9035 Qget_mru_window, Qresize_root_window,
9036 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9037 Qauto_buffer_name; staticpro them.
f3d1777e 9038
abde8f8c
MR
90392011-06-07 Martin Rudalics <rudalics@gmx.at>
9040
9041 * window.c (Fwindow_total_size, Fwindow_left_column)
9042 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9043 (Fwindow_list_1): New functions.
9044 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9045 (Fwindow_width, Fscroll_left, Fscroll_right):
9046 Use window_body_cols instead of window_box_text_cols.
9047 (delete_window, Fset_window_configuration):
9048 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9049 (delete_all_subwindows): Take a window as argument and not a
9050 structure. Rewrite.
190b47e6
MR
9051 (window_loop): Remove handling of GET_LRU_WINDOW and
9052 GET_LARGEST_WINDOW.
9053 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9054
9055 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9056 window_box_text_cols. delete_all_subwindows now takes a
9057 Lisp_Object as argument.
abde8f8c 9058
640c8776
SM
9059 * indent.c (compute_motion, Fcompute_motion):
9060 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9061
fa8a67e6
MR
9062 * frame.c (delete_frame): Call delete_all_subwindows with root
9063 window as argument.
9064
a54e3482
DC
90652011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9066
9067 * fns.c (Fputhash): Document return value.
9068
60002bf5
CY
90692011-06-06 Chong Yidong <cyd@stupidchicken.com>
9070
9071 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9072
0c671da6 90732011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9074
b862a52a 9075 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9076
be44ca6c
PE
9077 Check for overflow when converting integer to cons and back.
9078 * charset.c (Fdefine_charset_internal, Fdecode_char):
9079 Use cons_to_unsigned to catch overflow.
9080 (Fencode_char): Use INTEGER_TO_CONS.
9081 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9082 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9083 * data.c (long_to_cons, cons_to_long): Remove.
9084 (cons_to_unsigned, cons_to_signed): New functions.
9085 These signal an error for invalid or out-of-range values.
9086 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9087 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9088 * font.c (Ffont_variation_glyphs):
9089 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9090 * lisp.h: Include <intprops.h>.
9091 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9092 (cons_to_signed, cons_to_unsigned): New decls.
9093 (long_to_cons, cons_to_long): Remove decls.
9094 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9095 (Fprimitive_undo): Use CONS_TO_INTEGER.
9096 * xfns.c (Fx_window_property): Likewise.
9097 * xselect.c: Include <limits.h>.
9098 (x_own_selection, selection_data_to_lisp_data):
9099 Use INTEGER_TO_CONS.
9100 (x_handle_selection_request, x_handle_selection_clear)
9101 (x_get_foreign_selection, Fx_disown_selection_internal)
9102 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9103 (lisp_data_to_selection_data): Use cons_to_unsigned.
9104 (x_fill_property_data): Use cons_to_signed.
9105 Report values out of range.
9106
d1f3d2af
PE
9107 Check for buffer and string overflow more precisely.
9108 * buffer.h (BUF_BYTES_MAX): New macro.
9109 * lisp.h (STRING_BYTES_MAX): New macro.
9110 * alloc.c (Fmake_string):
9111 * character.c (string_escape_byte8):
9112 * coding.c (coding_alloc_by_realloc):
9113 * doprnt.c (doprnt):
9114 * editfns.c (Fformat):
9115 * eval.c (verror):
9116 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9117 since they may not be the same number.
9118 * editfns.c (Finsert_char):
9119 * fileio.c (Finsert_file_contents):
9120 Likewise for BUF_BYTES_MAX.
9121
dd52fcea
PE
9122 * image.c: Use ptrdiff_t, not int, for sizes.
9123 (slurp_file): Switch from int to ptrdiff_t.
9124 All uses changed.
9125 (slurp_file): Check that file size fits in both size_t (for
9126 malloc) and ptrdiff_t (for sanity and safety).
9127
7f9bbdbb
PE
9128 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9129 if b->modtime has its maximal value.
9130
dfe18f82
PE
9131 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9132
84acfcf0
PE
9133 Don't assume time_t can fit into int.
9134 * buffer.h (struct buffer.modtime): Now time_t, not int.
9135 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9136 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9137
ccd9a01a
PE
9138 Minor fixes for signed vs unsigned integers.
9139 * character.h (MAYBE_UNIFY_CHAR):
9140 * charset.c (maybe_unify_char):
9141 * keyboard.c (read_char, reorder_modifiers):
9142 XINT -> XFASTINT, since the integer must be nonnegative.
9143 * ftfont.c (ftfont_spec_pattern):
9144 * keymap.c (access_keymap, silly_event_symbol_error):
9145 XUINT -> XFASTINT, since the integer must be nonnegative.
9146 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9147 since it makes no difference and we prefer signed.
9148 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9149 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9150 nonnegative.
9151
d6d100dd
SM
91522011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9153
9154 * window.h (Fwindow_frame): Declare.
9155
2b6148e4
PE
91562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9157
9158 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9159 (SPARE_MEMORY): Always define.
9160 (LARGE_REQUEST): Remove.
9161 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9162
f230ecc9
MR
91632011-06-06 Martin Rudalics <rudalics@gmx.at>
9164
727e958e
MR
9165 * lisp.h: Move EXFUNS for Fframe_root_window,
9166 Fframe_first_window and Fset_frame_selected_window to window.h.
9167
9168 * window.h: Move EXFUNS for Fframe_root_window,
9169 Fframe_first_window and Fset_frame_selected_window here from
9170 lisp.h.
9171
9172 * frame.c (Fwindow_frame, Fframe_first_window)
9173 (Fframe_root_window, Fframe_selected_window)
9174 (Fset_frame_selected_window): Move to window.c.
9175 (Factive_minibuffer_window): Move to minibuf.c.
9176 (Fother_visible_frames_p): New function.
9177
9178 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9179
f230ecc9
MR
9180 * window.c (decode_window, decode_any_window): Move up in code.
9181 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9182 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9183 (Fwindow_buffer): Move up and rewrite doc-string.
9184 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9185 (Fwindow_prev): New functions.
727e958e
MR
9186 (Fwindow_frame): Move here from frame.c. Accept any window as
9187 argument.
9188 (Fframe_root_window, Fframe_first_window)
9189 (Fframe_selected_window): Move here from frame.c. Accept frame
9190 or arbitrary window as argument. Update doc-strings.
9191 (Fminibuffer_window): Move up in code.
9192 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9193 (Fset_frame_selected_window): Move here from frame.c.
9194 Marginal rewrite.
727e958e
MR
9195 (Fselected_window, select_window, Fselect_window): Move up in
9196 code. Minor doc-string fixes.
f230ecc9 9197
4d09bcf6
PE
91982011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9199
9200 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9201 Do not assume that spare memory exists; that assumption is valid
9202 only if SYSTEM_MALLOC.
9203 (LARGE_REQUEST): New macro, so that the issue of large requests
9204 is separated from the issue of spare memory.
9205
810928a2
AS
92062011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9207
172418ad
AS
9208 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9209 format. (Bug#8806)
9210
43f862f7
AS
9211 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9212
810928a2
AS
9213 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9214 before statements.
9215
a059fe24
JD
92162011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9217
9218 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9219
9220 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9221
9222 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9223 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9224
989bf368
JB
92252011-06-05 Juanma Barranquero <lekktu@gmail.com>
9226
9227 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9228
4b80f674
CY
92292011-06-04 Chong Yidong <cyd@stupidchicken.com>
9230
9231 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9232 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9233 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9234 New error handlers.
4b80f674
CY
9235 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9236 Obey Vx_select_enable_clipboard_manager. Catch errors in
9237 x_clipboard_manager_save (Bug#8779).
9238 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9239 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9240
99a33b77 92412011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9242
9243 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9244
99a33b77 92452011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9246
9247 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9248 in the current matrix if keep_current_p is non-zero.
9249
8264569d
EZ
92502011-06-04 Eli Zaretskii <eliz@gnu.org>
9251
9252 * bidi.c (bidi_level_of_next_char): Fix last change.
9253
57f97249
EZ
92542011-06-03 Eli Zaretskii <eliz@gnu.org>
9255
fec2107c 9256 Support bidi reordering of text covered by display properties.
57f97249 9257
fec2107c
EZ
9258 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9259 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9260 (bidi_cache_search, bidi_cache_iterator_state)
9261 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9262 (bidi_level_of_next_char, bidi_move_to_visually_next):
9263 Support character positions inside a run of characters covered by a
fec2107c
EZ
9264 display string.
9265 (bidi_paragraph_init, bidi_resolve_explicit_1)
9266 (bidi_level_of_next_char): Call bidi_fetch_char and
9267 bidi_fetch_char_advance instead of FETCH_CHAR and
9268 FETCH_CHAR_ADVANCE.
9269 (bidi_init_it): Initialize new members.
9270 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9271 definitions.
9272 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9273 instead of using explicit *_CHAR codes.
d6d100dd
SM
9274 (bidi_resolve_explicit, bidi_resolve_weak):
9275 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9276 bidirectional text is supported only in multibyte buffers.
9277 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9278 it to initialize the frame_window_p member of struct bidi_it.
9279 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9280 (bidi_resolve_explicit, bidi_resolve_weak)
9281 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9282 bidi_it->nchars is non-positive.
9283 (bidi_level_of_next_char): Don't try to lookup the cache for the
9284 next/previous character if nothing is cached there yet, or if we
9285 were just reseat()'ed to a new position.
c40e2fb2 9286
0e14fe90
EZ
9287 * xdisp.c (set_cursor_from_row): Set start and stop points
9288 according to the row's direction when priming the loop that looks
9289 for the glyph on which to display cursor.
9290 (single_display_spec_intangible_p): Function deleted.
9291 (display_prop_intangible_p): Reimplement to call
9292 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9293 Accept 3 additional arguments needed by handle_display_spec.
9294 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9295 values: lists, `(when COND...)' forms, etc.
9296 (single_display_spec_string_p): Support property values that are
9297 lists with the argument STRING its top-level element.
9298 (display_prop_string_p): Fix the condition for processing a
9299 property that is a list to be consistent with handle_display_spec.
fec2107c 9300 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9301 last portion of handle_display_prop.
9302 (compute_display_string_pos): Accept additional argument
9303 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9304 value of a `display' property is a "replacing spec".
9305 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9306 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9307 the display property, but just return a value indicating whether
9308 the display property will replace the characters it covers.
9309 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9310 frame_window_p members of struct bidi_it.
d6d100dd
SM
9311 (compute_display_string_pos, compute_display_string_end):
9312 New functions.
fec2107c
EZ
9313 (push_it): Accept second argument POSITION, where pop_it should
9314 jump to continue iteration.
9315 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9316
fec2107c
EZ
9317 * keyboard.c (adjust_point_for_property): Adjust the call to
9318 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9319
9320 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9321 (bidi_init_it): Update prototypes.
9322 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9323 (compute_display_string_pos, compute_display_string_end):
9324 Declare prototypes.
fec2107c
EZ
9325 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9326 EMACS_INT.
fc6f18ce 9327
40087514 93282011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9329
57f53182
PE
9330 Malloc failure behavior now depends on size of allocation.
9331 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9332 * lisp.h: Change signatures accordingly.
9333 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9334 All callers changed. (Bug#8762)
9335
9336 * gnutls.c: Use Emacs's memory allocators.
9337 Without this change, the gnutls library would invoke malloc etc.
9338 directly, which causes problems on non-SYNC_INPUT hosts, and which
9339 runs afoul of improving memory_full behavior. (Bug#8761)
9340 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9341 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9342 xfree instead of the default malloc, realloc, free.
9343 (Fgnutls_boot): No need to check for memory allocation failure,
9344 since xmalloc does that for us.
9345
ac32cd99 9346 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9347 * category.c (hash_get_category_set):
9348 * ccl.c (ccl_driver):
9349 * charset.c (Fdefine_charset_internal):
9350 * charset.h (struct charset.hash_index):
9351 * composite.c (get_composition_id, gstring_lookup_cache)
9352 (composition_gstring_put_cache):
9353 * composite.h (struct composition.hash_index):
9354 * dispextern.h (struct image.hash):
9355 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9356 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9357 (hashfn_equal, hashfn_user_defined, make_hash_table)
9358 (maybe_resize_hash_table, hash_lookup, hash_put)
9359 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9360 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9361 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9362 * image.c (make_image, search_image_cache, lookup_image)
9363 (xpm_put_color_table_h):
9364 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9365 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9366 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9367 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9368 * alloc.c (allocate_vectorlike):
9369 Check for overflow in vector size calculations.
9370 * ccl.c (ccl_driver):
9371 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9372 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9373 need to be updated by these changes.
40087514
PE
9374 * fns.c (make_hash_table, maybe_resize_hash_table):
9375 Check for integer overflow with large hash tables.
0de4bb68
PE
9376 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9377 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9378 (SXHASH_REDUCE): New macro.
9379 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9380 Use it instead of discarding useful hash info with large hash values.
9381 (sxhash_float): New function.
9382 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9383 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9384 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9385 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9386 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9387 Adjust signatures to match updated version of code.
9388 (consing_since_gc): Now EMACS_INT, since a single hash table can
9389 use more than INT_MAX bytes.
9390
698d32e2
DN
93912011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9392
9393 Make it possible to build with GCC-4.6+ -O2 -flto.
9394
9395 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9396
fd6fa53f
SM
93972011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9398
9399 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9400 Call minibuffer-inactive-mode.
9401
864db017
JB
94022011-05-31 Juanma Barranquero <lekktu@gmail.com>
9403
9404 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9405 Update dependencies.
9406
2ad0baf4
DN
94072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9408
9409 * data.c (init_data): Remove code for UTS, this system is not
9410 supported anymore.
9411
4fcc2638
DN
94122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9413
9414 Don't force ./temacs to start in terminal mode.
9415
9416 * frame.c (make_initial_frame): Initialize faces in all cases, not
9417 only when CANNOT_DUMP is defined.
9418 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9419
c56e0fd5
DN
94202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9421
9422 * dispnew.c (add_window_display_history): Use const for the string
9423 pointer. Remove declaration, not needed.
9424
333d54da 94252011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9426
55d4c1b2 9427 Use 'inline', not 'INLINE'.
333d54da 9428 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9429 * alloc.c, fontset.c (INLINE): Remove.
9430 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9431 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9432 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9433 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9434 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9435
738db178
DN
94362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9437
9438 Make it possible to run ./temacs.
9439
9440 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9441 syms_of_callproc does the same thing. Remove test for
9442 "initialized", do it in the caller.
9443 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9444
620c53a6
SM
94452011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9446
9447 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9448 (read_minibuf): Use get_minibuffer.
9449 (syms_of_minibuf): Use DEFSYM.
9450 (Qmetadata): New var.
9451 * data.c (Qbuffer): Don't make it static.
9452 (syms_of_data): Use DEFSYM.
9453
e003a292
PE
94542011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9455
9456 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9457 (CCL_CODE_MIN): New macro.
9458
ed008a6d
PE
94592011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9460
3687c2ef
PE
9461 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9462
ed008a6d
PE
9463 * eval.c (Qdebug): Now static.
9464 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9465 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9466 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9467
d66c4c7c
CY
94682011-05-29 Chong Yidong <cyd@stupidchicken.com>
9469
9470 * image.c: Various fixes to ImageMagick code comments.
9471 (Fimagemagick_types): Doc fix.
9472
5fbc2025
PE
94732011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9474
0196f88a
PE
9475 Minor fixes prompted by GCC 4.6.0 warnings.
9476
9477 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9478
5fbc2025
PE
9479 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9480 (x_clipboard_manager_save_all): Move extern decl to ...
9481 * xterm.h: ... here, so that it can be checked for consistency.
9482
1dd3c2d9
CY
94832011-05-29 Chong Yidong <cyd@stupidchicken.com>
9484
9485 * xselect.c (x_clipboard_manager_save_frame)
9486 (x_clipboard_manager_save_all): New functions.
9487 (Fx_clipboard_manager_save): Lisp function deleted.
9488
9489 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9490 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9491
9492 * xterm.h: Update prototype.
9493
5ba6571d
WX
94942011-05-28 William Xu <william.xwl@gmail.com>
9495
9496 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9497 exiting (Bug#8239).
9498
3eaff834
JM
94992011-05-28 Jim Meyering <meyering@redhat.com>
9500
e1900994 9501 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9502 * fns.c (to_uchar): Define.
9503 (crypto_hash_function): Use it to convert some newly-signed
9504 variables to unsigned, to avoid sign-extension bugs. For example,
9505 without this change, (md5 "truc") would evaluate to
9506 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9507 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9508 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9509
0f6990a7
PE
95102011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9511
9512 Integer overflow fixes.
c8a9ca5a 9513
08686060
PE
9514 * dbusbind.c: Serial number integer overflow fixes.
9515 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9516 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9517 to hold a serial number that is too large for a fixnum.
9518 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9519 Check for serial numbers out of range. Decode any serial number
59568bf0 9520 that was so large that it became a float. (Bug#8722)
08686060 9521
2d1fc3c7
PE
9522 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9523 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9524 Use XFASTINT rather than XUINT when numbers are nonnegative.
9525 (xd_append_arg, Fdbus_method_return_internal):
9526 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9527 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9528 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9529 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9530 (Bug#8722)
2d1fc3c7 9531
c8a9ca5a
PE
9532 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9533
519e1d69
PE
9534 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9535
6df6ae42 9536 ccl: Add integer overflow checks.
30569699
PE
9537 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9538 (IN_INT_RANGE): New macros.
9539 (ccl_driver): Use them to check for integer overflow when
9540 decoding a CCL program. Many of the new checks are whether XINT (x)
9541 fits in int; it doesn't always, on 64-bit hosts. The new version
9542 doesn't catch all possible integer overflows, but it's an
847044ea 9543 improvement. (Bug#8719)
30569699 9544
c11285dc
PE
9545 * alloc.c (make_event_array): Use XINT, not XUINT.
9546 There's no need for unsigned here.
9547
fdccd48e
PE
9548 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9549 This follows up to the 2011-05-06 change that substituted uintptr_t
9550 for EMACS_INT. This case wasn't caught back then.
9551
37910ab2
PE
9552 Rework Fformat to avoid integer overflow issues.
9553 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9554 now (part of C89). Include <verify.h>.
9555 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9556 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9557 (Fformat): Avoid the prepass trying to compute sizes; it was only
9558 approximate and thus did not catch overflow reliably. Instead, walk
9559 through the format just once, formatting and computing sizes as we go,
9560 checking for integer overflow at every step, and allocating a larger
9561 buffer as needed. Keep track separately whether the format is
9562 multibyte. Keep only the most-recently calculated precision, rather
9563 than them all. Record whether each argument has been converted to
9564 string. Use EMACS_INT, not int, for byte and char and arg counts.
9565 Support field widths and precisions larger than INT_MAX. Avoid
9566 sprintf's undefined behavior with conversion specifications such as %#d
9567 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9568 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9569 formatting out-of-range floating point numbers with int
9173deec 9570 formats. (Bug#8668)
37910ab2 9571
2e6578fb
PE
9572 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9573
0ae6bdee
PE
9574 * data.c: Avoid integer truncation in expressions involving floats.
9575 * data.c: Include <intprops.h>.
9576 (arith_driver): When there's an integer overflow in an expression
9577 involving floating point, convert the integers to floating point
9578 so that the resulting value does not suffer from catastrophic
9579 integer truncation. For example, on a 64-bit host (* 4
9580 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9581 Do not rely on undefined behavior after integer overflow.
9582
de883a70
PE
9583 merge count_size_as_multibyte, parse_str_to_multibyte
9584 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9585 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9586 Check for integer overflow.
9587 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9588 since it's now a duplicate of the other. This is more of
9589 a character than a buffer op, so better that it's in character.c.
9590 * fns.c, print.c: Adjust to above changes.
9591
2ff916cb
PE
95922011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9593
9594 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9595
f1b54466
PE
95962011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9597
fb1ac845
PE
9598 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9599 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9600 (x_clipboard_manager_save): Now static.
9601 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9602
f1b54466
PE
9603 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9604 (crypto_hash_function): Now static.
9605 Fix pointer signedness problems. Avoid unnecessary initializations.
9606
a9f737ee
CY
96072011-05-27 Chong Yidong <cyd@stupidchicken.com>
9608
9609 * termhooks.h (Vselection_alist): Make it terminal-local.
9610
9611 * terminal.c (create_terminal): Initialize it.
9612
9613 * xselect.c: Support for clipboard managers.
9614 (Vselection_alist): Move to termhooks.h as terminal-local var.
9615 (LOCAL_SELECTION): New macro.
9616 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9617 (symbol_to_x_atom): Remove gratuitous arg.
9618 (x_handle_selection_request, lisp_data_to_selection_data)
9619 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9620 (x_own_selection, x_get_local_selection, x_convert_selection):
9621 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9622 (some_frame_on_display): Delete unused function.
9623 (Fx_own_selection_internal, Fx_get_selection_internal)
9624 (Fx_disown_selection_internal, Fx_selection_owner_p)
9625 (Fx_selection_exists_p): New optional frame arg.
9626 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9627 (x_handle_selection_clear): Don't treat other terminals with the
9628 same keyboard specially. Use the terminal-local Vselection_alist.
9629 (x_clear_frame_selections): Use Frun_hook_with_args.
9630
9631 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9632
9633 * xterm.h: Add support for those atoms.
9634
e067f0c1
CY
96352011-05-26 Chong Yidong <cyd@stupidchicken.com>
9636
9637 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9638 (converted_selections, conversion_fail_tag): New global variables.
9639 (x_selection_request_lisp_error): Free the above.
9640 (x_get_local_selection): Remove unnecessary code.
9641 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9642 of converted selections stored in converted_selections.
9643 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9644 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9645 (x_convert_selection): New function.
9646 (x_handle_selection_event): Simplify.
9647 (x_get_foreign_selection): Don't ignore incoming requests while
9648 waiting for an answer; this will fail when we implement
9649 SAVE_TARGETS, and seems unnecessary anyway.
9650 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9651 (Vx_sent_selection_functions): Doc fix.
9652
0f4aebc0
LL
96532011-05-26 Leo Liu <sdl.web@gmail.com>
9654
9655 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9656
e61124cd
YM
96572011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9658
9659 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9660
9661 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9662 for fringe update if it has periodic bitmap.
ac389d0c 9663 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9664 and fringe_bitmap_periodic_p.
9665
9666 * fringe.c (get_fringe_bitmap_data): New function.
9667 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9668 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9669 row. Mark glyph row for fringe update if periodicity changed.
9670
9671 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9672 for fringe update unless it has periodic bitmap.
9673
f16d9837
KH
96742011-05-25 Kenichi Handa <handa@m17n.org>
9675
9676 * xdisp.c (get_next_display_element): Set correct it->face_id for
9677 a static composition.
9678
e1b90ef6
LL
96792011-05-24 Leo Liu <sdl.web@gmail.com>
9680
9681 * deps.mk (fns.o):
9682 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9683
9684 * fns.c (crypto_hash_function, Fsha1): New function.
9685 (Fmd5): Use crypto_hash_function.
9686 (syms_of_fns): Add Ssha1.
9687
7400048f
PE
96882011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9689
9690 * gnutls.c: Remove unused macros.
9691 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9692 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9693 Remove macros that are defined and never used.
9694 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9695
abb71cf4
CY
96962011-05-22 Chong Yidong <cyd@stupidchicken.com>
9697
9698 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9699 (Fx_get_selection_internal): Minor cleanup.
9700 (Fx_own_selection_internal): Rename arguments for consistency with
9701 select.el.
9702
6307db39
PE
97032011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9704
9705 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9706
f3d4e0a4
CY
97072011-05-22 Chong Yidong <cyd@stupidchicken.com>
9708
9709 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9710
4d8ade89
YM
97112011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9712
9713 * dispnew.c (scrolling_window): Don't exclude the case that the
9714 last enabled row in the desired matrix touches the bottom boundary.
9715
32078c8d
GM
97162011-05-21 Glenn Morris <rgm@gnu.org>
9717
9718 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9719 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9720 and add some more files.
32078c8d 9721
7285dc67
EZ
97222011-05-20 Eli Zaretskii <eliz@gnu.org>
9723
9724 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9725 report_file_error introduced by the change from 2011-05-07.
9726
89d1bd22
PE
97272011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9728
9729 * systime.h (Time): Define only if emacs is defined.
9730 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9731 where the include path doesn't have X11/X.h by default. See
9732 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9733
cd394be1 97342011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9735
9736 * composite.c (find_automatic_composition): Fix previous change.
9737
b9704ad9
GM
97382011-05-20 Glenn Morris <rgm@gnu.org>
9739
9740 * lisp.mk: New file, split from Makefile.in.
9741 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9742 (shortlisp): Remove.
9743 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9744
4a720484
GM
97452011-05-19 Glenn Morris <rgm@gnu.org>
9746
9747 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9748 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9749 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9750 (lisp): Set the order to that of loadup.el.
9751 (shortlisp): Make it a copy of $lisp.
9752 (SOME_MACHINE_LISP): Remove.
9753 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9754 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9755
a28d4396
KH
97562011-05-18 Kenichi Handa <handa@m17n.org>
9757
9758 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9759 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9760 (find_automatic_composition): Mostly rewrite for efficiency.
9761
a2b1fa8e
JB
97622011-05-18 Juanma Barranquero <lekktu@gmail.com>
9763
9764 * makefile.w32-in: Update dependencies.
9765
8e1f5610
CS
97662011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9767
9768 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9769 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9770
7025ee00 97712011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9772
cdfa6eab
PE
9773 Fix some integer overflow issues, such as string length overflow.
9774
06d6db33
PE
9775 * insdel.c (count_size_as_multibyte): Check for string overflow.
9776
2b4560a8
PE
9777 * character.c (lisp_string_width): Check for string overflow.
9778 Use EMACS_INT, not int, for string indexes and lengths; in
9779 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9780 the resulting string length overflows an EMACS_INT; instead,
9781 report a string overflow if no precision given. When checking for
9782 precision exhaustion, use a check that cannot possibly have
9783 integer overflow. (Bug#8675)
9784 * character.h (lisp_string_width): Adjust to new signature.
9785
cb93f9be
PE
9786 * alloc.c (string_overflow): New function.
9787 (Fmake_string): Use it. This doesn't change behavior, but saves
9788 a few bytes and will simplify future changes.
9789 * character.c (string_escape_byte8): Likewise.
9790 * lisp.h (string_overflow): New decl.
9791
1a1f3366
PE
9792 Fixups, following up to the user-interface timestamp change.
9793 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9794 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9795 * msdos.c (mouse_get_pos): Likewise.
9796 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9797 * w32gui.h (Time): Define by including "systime.h" rather than by
9798 declaring it ourselves. (Bug#8664)
9799
d4e3e4d3
PE
9800 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9801 * image.c (clear_image_cache): Likewise.
9802
f6a24d19
PE
9803 * term.c (term_mouse_position): Don't assume time_t wraparound.
9804
08dc5ae6
PE
9805 Be more systematic about user-interface timestamps.
9806 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9807 and sometimes 'EMACS_UINT', to represent these timestamps.
9808 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9809 This makes the code easier to follow, and makes it easier to catch
9810 integer overflow bugs such as Bug#8664.
9811 * frame.c (Fmouse_position, Fmouse_pixel_position):
9812 Use Time, not unsigned long, for user-interface timestamps.
9813 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9814 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9815 * keyboard.h (last_event_timestamp): Likewise.
9816 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9817 * menu.h (xmenu_show): Likewise.
9818 * term.c (term_mouse_position): Likewise.
9819 * termhooks.h (struct input_event.timestamp): Likewise.
9820 (struct terminal.mouse_position_hook): Likewise.
9821 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9822 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9823 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9824 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9825 what it was before.
9826 * menu.h, termhooks.h: Include "systime.h", for Time.
9827
8e55734a
PE
9828 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9829 Don't assume that the difference between two unsigned long values
9830 can fit into an integer. At this point, we know button_down_time
9831 <= event->timestamp, so the difference must be nonnegative, so
9832 there's no need to cast the result if double-click-time is
9833 nonnegative, as it should be; check that it's nonnegative, just in
9834 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9835 apart (about 25 days). (Bug#8664)
8e55734a 9836
841f1b75 9837 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9838 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9839
3e26f69c
PE
9840 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9841 that always fit in int. Use a sentinel instead of a counter, to
9842 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9843 * frame.h (struct frame): Use int for menu_bar_items_used
9844 instead of EMACS_INT, since it always fits in int.
3e26f69c 9845
5cc152c0
PE
9846 * menu.c (grow_menu_items): Check for int overflow.
9847
d89eb65e
PE
9848 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9849
5235bd3e
PE
9850 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9851 Before, the code was not consistent. These values cannot exceed
9852 2**31 - 1 so there's no need to make them unsigned.
9853 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9854 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9855 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9856 as modifiers.
9857 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9858
bc827e23
PE
9859 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9860 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9861 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9862 presumably because the widths might not match.
9863
78eb494e
PE
9864 * window.c (size_window): Avoid needless test at loop start.
9865
04f2d78b
CB
98662011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9867
9868 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9869
d2fc7e3d 98702011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9871
9872 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9873
d2fc7e3d 98742011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9875
9876 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9877 `width' to `bar_area_x' and `bar_area_width', respectively.
9878 (x_scroll_run): Take account of fringe background extension.
9879
04f2d78b
CB
9880 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9881 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9882 `bar_area_width', respectively.
9883 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9884 background extension.
9885
79b70037
GM
98862011-05-10 Jim Meyering <meyering@redhat.com>
9887
9888 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9889
2f142cc5
JB
98902011-05-10 Juanma Barranquero <lekktu@gmail.com>
9891
9892 * image.c (Finit_image_library): Return t for built-in image types,
9893 like pbm and xbm. (Bug#8640)
9894
57679c86
AS
98952011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9896
9897 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9898
888c9e86
EZ
98992011-05-07 Eli Zaretskii <eliz@gnu.org>
9900
b0512a1d
EZ
9901 * w32console.c (Fset_screen_color): Doc fix.
9902 (Fget_screen_color): New function.
9903 (syms_of_ntterm): Defsubr it.
9904
7285dc67
EZ
9905 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9906 unlink the temporary file if Fcall_process didn't create it in the
9907 first place.
9908 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9909 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9910 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9911 cue to call_process_cleanup not to close that handle.
9912
4d3fcc8e
BK
99132011-05-07 Ben Key <bkey76@gmail.com>
9914
9915 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9916 one of two shell specific rules, either bootstrap-temacs-CMD or
9917 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9918 to the previous implementation of the bootstrap-temacs rule.
9919 The bootstrap-temacs-CMD rule is similar to the previous
9920 implementation of the bootstrap-temacs rule except that it
9921 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9922 variable.
9923
9924 These changes, along with some changes to nt/configure.bat,
9925 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9926 earlier fix to add support for --cflags and --ldflags options
9927 that include quotes so that it works whether make uses cmd or
9928 sh as the shell.
9929
b4289b64
MA
99302011-05-06 Michael Albinus <michael.albinus@gmx.de>
9931
9932 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9933 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9934 is a constant.
9935 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9936 a string. Handle both cases.
9937 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9938 (Fdbus_register_method): Use Qinvalid_function.
9939
af4c0e28
JB
99402011-05-06 Juanma Barranquero <lekktu@gmail.com>
9941
9942 * makefile.w32-in: Update dependencies.
9943 (LISP_H): Add inttypes.h and stdin.h.
9944 (PROCESS_H): Add unistd.h.
9945
c51453d9
EZ
99462011-05-06 Eli Zaretskii <eliz@gnu.org>
9947
9948 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9949 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9950
8ff0ac3c 99512011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9952
4c4b566b
PE
9953 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9954
aab2b9b5
PE
9955 * term.c (vfatal): Remove stray call to va_end.
9956 It's not needed and the C Standard doesn't allow it here anyway.
9957
c378da0b
PE
9958 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9959 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9960
288b08c7
PE
9961 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9962 bytes.
9963
e3601888
PE
9964 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9965
db6c0e74
PE
9966 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9967
dd5963ea
PE
9968 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9969
88c9450f
PE
9970 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9971
2f9442b8
PE
9972 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9973
c032b5f8
PE
9974 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9975 * charset.c (Fdefine_charset_internal): Don't initialize
9976 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9977 32-bit int (Bug#8600).
a108c10b
PE
9978
9979 * lread.c (read_integer): Be more consistent with string-to-number.
9980 Use string_to_number to do the actual conversion; this avoids
9981 rounding errors and fixes some other screwups. Without this fix,
9982 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9983 (digit_to_number): Move earlier, for benefit of read_integer.
9984 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9985 not a digit in any supported base. (Bug#8602)
a108c10b 9986
ad5f9eea
PE
9987 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9988
aec1708a
PE
9989 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9990 to match comment at start of function. This also removes a
9991 GCC warning about overflow in a 32+64-bit port.
9992
47be4ab5
PE
9993 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9994
371cac43
PE
9995 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9996 Reported by Stefan Monnier in
9997 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9998 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9999 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10000
d01a7826
PE
10001 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10002 (EMACS_UINTPTR): Likewise, with uintptr_t.
10003
7fd47d5c
PE
10004 * lisp.h: Prefer 64-bit EMACS_INT if available.
10005 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10006 on 32-bit hosts that have 64-bit int, so that they can access
10007 large files.
122b0c86
PE
10008 However, temporarily disable this change unless the temporary
10009 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10010
8727937b
PE
10011 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10012
8ac068ac
PE
10013 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10014 This removes an assumption that EMACS_INT and long are the same
10015 width as pointers. The assumption is true for Emacs porting targets
10016 now, but we want to make other targets possible.
10017 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10018 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10019 In the rest of the code, change types of integers that hold casted
10020 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10021 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10022 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10023 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10024 No need to cast type when ORing.
10025 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10026 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10027 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10028 assume EMACS_INT is the same width as char *.
10029 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10030 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10031 Remove no-longer-needed casts.
10032 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10033 (xg_tool_bar_help_callback, xg_make_tool_item):
10034 Use EMACS_INTPTR to hold an integer
10035 that will be cast to void *; this can avoid a GCC warning
10036 if EMACS_INT is not the same width as void *.
10037 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10038 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10039 (current_message_1, set_message_1):
10040 Use a local to convert to proper width without a cast.
10041 * xmenu.c (dialog_selection_callback): Likewise.
10042
ede49d71
PE
10043 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10044 Also, don't assume VALBITS / RAND_BITS is less than 5,
10045 and don't rely on undefined behavior when shifting a 1 left into
10046 the sign bit.
10047 * lisp.h (get_random): Change signature to match.
10048
2f30ecd0
PE
10049 * lread.c (hash_string): Use size_t, not int, for hash computation.
10050 Normally we prefer signed values; but hashing is special, because
10051 it's better to use unsigned division on hash table sizes so that
10052 the remainder is nonnegative. Also, size_t is the natural width
10053 for hashing into memory. The previous code used 'int', which doesn't
10054 retain enough info to hash well into very large tables.
10055 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10056
2a866e7b
PE
10057 * dbusbind.c: Don't possibly lose pointer info when converting.
10058 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10059 Use XPNTR rather than XHASH, so that the high-order bits of
10060 the pointer aren't lost when converting through void *.
10061
51639eac
PE
10062 * eval.c (Fautoload): Don't double-shift a pointer.
10063
92394119
PE
10064 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10065
dbdb9a7c
JB
100662011-05-06 Juanma Barranquero <lekktu@gmail.com>
10067
10068 * gnutls.c (DEF_GNUTLS_FN):
10069 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10070
db7a0b4f
AS
100712011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10072
10073 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10074 marker. (Bug#8610)
10075
cd394be1 100762011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10077
10078 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10079 New version that can reserve upto 2GB of heap space.
10080
f7ff1b0f 100812011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10082
10083 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10084
639c109b
TZ
100852011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10086
10087 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10088 `gnutls_certificate_set_x509_key_file'.
10089
d2127135
JB
100902011-05-05 Juanma Barranquero <lekktu@gmail.com>
10091
10092 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10093 Update dependencies.
10094
e968f4f3
JB
100952011-05-04 Juanma Barranquero <lekktu@gmail.com>
10096
10097 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10098 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10099 Remove unused parameter `fildes'.
10100 * process.c (read_process_output, send_process): Don't pass it.
10101
84d358f0
JB
101022011-05-04 Juanma Barranquero <lekktu@gmail.com>
10103
10104 Fix previous change: the library cache is defined in w32.c.
10105 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10106 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10107
0898ca10
JB
101082011-05-04 Juanma Barranquero <lekktu@gmail.com>
10109
10110 Implement dynamic loading of GnuTLS on Windows.
10111
10112 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10113 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10114 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10115 Declare.
10116
10117 * gnutls.c (Qgnutls_dll): Define.
10118 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10119 (gnutls_*): Declare function pointers.
10120 (init_gnutls_functions): New function to initialize function pointers.
10121 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10122 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10123 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10124 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10125 (emacs_gnutls_write, emacs_gnutls_read)
10126 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10127 (Fgnutls_available_p): New function.
10128 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10129 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10130 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10131
10132 * image.c: Include w32.h.
10133 (Vimage_type_cache): Delete.
10134 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10135 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10136 (w32_delayed_load): Move to w32.c.
10137
10138 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10139
10140 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10141 (w32_delayed_load): Move from image.c. When loading a library, record
10142 its filename in the :loaded-from property of the library id.
10143 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10144 Initialize and staticpro them.
10145 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10146
10147 * process.c: Include lisp.h before w32.h, not after.
10148 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10149 instead of gnutls_record_check_pending.
10150
10151 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10152
ff4de4aa
TZ
101532011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10154
10155 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10156 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10157 as passed in.
10158
abe95abb
JD
101592011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10160
10161 * xterm.c (x_set_frame_alpha): Do not set property on anything
10162 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10163
e16e55d4
JB
101642011-05-02 Juanma Barranquero <lekktu@gmail.com>
10165
10166 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10167
bafcf6a5
JB
101682011-05-02 Juanma Barranquero <lekktu@gmail.com>
10169
10170 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10171 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10172 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10173 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10174 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10175 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10176 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10177 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10178 (Qgnutls_bootprop_callbacks_verify): Make static.
10179
e7a6747f
AS
101802011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10181
19ed11ba
AS
10182 * callproc.c: Indentation fixup.
10183
e7a6747f 10184 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10185 (wait_for_termination, interruptible_wait_for_termination):
10186 Move after wait_for_termination_1.
e7a6747f 10187
1ef14cb4
LMI
101882011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10189
10190 * sysdep.c (interruptible_wait_for_termination): New function
10191 which is like wait_for_termination, but allows keyboard
10192 interruptions.
10193
10194 * callproc.c (Fcall_process): Add (:file "file") as an option for
10195 the STDOUT buffer.
10196 (Fcall_process_region): Ditto.
10197
330d880c
EZ
101982011-04-30 Eli Zaretskii <eliz@gnu.org>
10199
8db90b73
EZ
10200 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10201 rather than `XVECTOR (FOO)->size'.
10202
330d880c
EZ
10203 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10204 inttypes.h, as a gnulib replacement is used if it not available in
10205 system headers.
10206
15cbd324
EZ
102072011-04-21 Eli Zaretskii <eliz@gnu.org>
10208
10209 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10210 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10211 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10212
10213 * coding.c (coding_alloc_by_realloc): Error out if destination
10214 will grow beyond MOST_POSITIVE_FIXNUM.
10215 (decode_coding_emacs_mule): Abort if there isn't enough place in
10216 charbuf for the composition carryover bytes. Reserve an extra
10217 space for up to 2 characters produced in a loop.
10218 (decode_coding_iso_2022): Abort if there isn't enough place in
10219 charbuf for the composition carryover bytes.
10220
102212011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10222
ae940cca
EZ
10223 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10224 aborting when %lld or %lll format is passed.
10225 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10226 %llo or %llx format is passed. (Bug#8545)
10227
03ab8921
EZ
10228 * window.c (window_scroll_line_based): Use a marker instead of
10229 simple variables to record original value of point. (Bug#7952)
10230
afda1437
EZ
10231 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10232 produced by %s or %c overflows available buffer space. (Bug#8545)
10233
f76dee0c
PE
102342011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10235
10236 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10237 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10238
fdc5744d
JB
102392011-04-28 Juanma Barranquero <lekktu@gmail.com>
10240
10241 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10242
638f053a
JB
102432011-04-28 Juanma Barranquero <lekktu@gmail.com>
10244
10245 * keyboard.c (Qdelayed_warnings_hook): Define.
10246 (command_loop_1): Run `delayed-warnings-hook'
10247 if Vdelayed_warnings_list is non-nil.
10248 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10249 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10250
d178f871
EZ
102512011-04-28 Eli Zaretskii <eliz@gnu.org>
10252
10253 * doprnt.c (doprnt): Don't return value smaller than the buffer
10254 size if the message was truncated. (Bug#8545).
10255
b124fd93
JB
102562011-04-28 Juanma Barranquero <lekktu@gmail.com>
10257
10258 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10259 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10260
e810457d
PE
102612011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10262
10263 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10264
ea51cceb
JB
102652011-04-27 Juanma Barranquero <lekktu@gmail.com>
10266
10267 * makefile.w32-in: Update dependencies.
10268
94dcfacf
EZ
102692011-04-27 Eli Zaretskii <eliz@gnu.org>
10270
10271 Improve `doprnt' and its usage. (Bug#8545)
10272 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10273 `format_end'. Remove support for %l as a conversion specifier.
10274 Don't use xrealloc. Improve diagnostics when the %l size modifier
10275 is used. Update the commentary.
10276
10277 * eval.c (verror): Simplify calculation of size_t.
10278
10279 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10280 messages.
10281
f61f41d7
PE
102822011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10283
10284 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10285 change.
10286
96fb4434
PE
102872011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10288
10289 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10290 This makes this file independent of the recent pseudovector change.
10291
671875da 102922011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10293
69e9b5a3
PE
10294 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10295
b5f869a7 10296 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10297 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10298 Remove unused local.
c8926152 10299 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10300
841a1577 10301 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10302 GCC 4.6.0 optimizes based on type-based alias analysis.
10303 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10304 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10305 != &v->size, and therefore "v->size = 1; b->size = 2; return
10306 v->size;" must therefore return 1. This assumption is incorrect
10307 for Emacs, since it type-puns struct Lisp_Vector * with many other
10308 types. To fix this problem, this patch adds a new type struct
f904488f 10309 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10310 and pseudovectors, and helps optimizing compilers not get fooled
10311 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10312 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10313 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10314 the size member.
eab3844f
PE
10315 (XSETPVECTYPE): Rewrite in terms of new macro.
10316 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10317 This is a bit clearer, and further avoids the possibility of
10318 undesirable aliasing.
10319 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10320 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10321 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10322 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10323 (ASIZE): Now uses header.size rather than size.
10324 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10325 to avoid the hassle of writing XVECTOR (foo)->header.size.
10326 (struct vectorlike_header): New type.
eab3844f
PE
10327 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10328 object, to help avoid aliasing.
10329 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10330 (SUBRP): Likewise, since Lisp_Subr is a special case.
10331 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10332 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10333 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10334 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10335 changed to be "header.size" and "header.next".
10336 * buffer.h (struct buffer): Likewise.
10337 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10338 * frame.h (struct frame): Likewise.
10339 * process.h (struct Lisp_Process): Likewise.
10340 * termhooks.h (struct terminal): Likewise.
10341 * window.c (struct save_window_data, struct saved_window): Likewise.
10342 * window.h (struct window): Likewise.
10343 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10344 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10345 * buffer.c (init_buffer_once): Likewise.
10346 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10347 special case.
10348 * process.c (Fformat_network_address): Use local var for size,
10349 for brevity.
10350
0df1eac5
PE
10351 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10352
847ab9d1 10353 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10354 * data.c (atof): Remove decl; no longer used or needed.
10355 (digit_to_number): Move to lread.c.
10356 (Fstring_to_number): Use new string_to_number function, to be
10357 consistent with how the Lisp reader treats infinities and NaNs.
10358 Do not assume that floating-point numbers represent EMACS_INT
10359 without losing information; this is not true on most 64-bit hosts.
10360 Avoid double-rounding errors, by insisting on integers when
10361 parsing non-base-10 numbers, as the documentation specifies.
10362 * lisp.h (string_to_number): New decl, replacing ...
10363 (isfloat_string): Remove.
bc0a5c13 10364 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10365 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10366 appears to have been a coding error. Similarly, do not accept
10367 strings like +-1e0 as floating point numbers. Do not report
10368 overflow for integer overflows unless the base is not 10 which
10369 means we have no simple and reliable way to continue.
10370 Break out the floating-point parsing into a new
10371 function string_to_number, so that Fstring_to_number parses
10372 floating point numbers consistently with the Lisp reader.
04f2d78b 10373 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10374 (E_CHAR, EXP_INT): Remove, replacing with ...
10375 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10376 (string_to_number): New function, replacing isfloat_string.
10377 This function checks for valid syntax and produces the resulting
10378 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10379 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10380 so that overflow for non-base-10 numbers is reported only when
10381 there's no portable and simple way to convert to floating point.
452f4150 10382
67769ffc
PE
10383 * textprop.c (set_text_properties_1): Rewrite for clarity,
10384 and to avoid GCC warning about integer overflow.
10385
c20db43f
PE
10386 * intervals.h (struct interval): Use EMACS_INT for members
10387 where EMACS_UINT might cause problems. See
10388 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10389 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10390 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10391 All uses changed.
37aa2f85
PE
10392 (offset_intervals): Tell GCC not to worry about length overflow
10393 when negating a negative length.
c20db43f 10394
2538aa2f
PE
10395 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10396 (overrun_check_free): Likewise.
10397
f2d3008d
PE
10398 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10399 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10400 word size.
10401
ec8df744
PE
10402 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10403 (gnutls_make_error): Rename local to avoid shadowing.
10404 (gnutls_emacs_global_deinit): ifdef out; not used.
10405 (Fgnutls_boot): Use const for pointer to readonly storage.
10406 Comment out unused local. Fix pointer signedness problems.
10407
640ee02d
PE
10408 * lread.c (openp): Don't stuff size_t into an 'int'.
10409 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10410 about possible signed overflow.
10411
6048fb2a
PE
10412 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10413 (GDK_KEY_g): Don't define if already defined.
10414 (xg_prepare_tooltip): Avoid pointer signedness problem.
10415 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10416
fa3c87e1
PE
10417 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10418 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10419
2172544b
PE
10420 * xfns.c (Fx_window_property): Simplify a bit,
10421 to make a bit faster and to avoid GCC 4.6.0 warning.
10422 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10423
9b821a21
PE
10424 * fns.c (internal_equal): Don't assume size_t fits in int.
10425
3c616cfa
PE
10426 * alloc.c (compact_small_strings): Tighten assertion a little.
10427
c2982e87
PE
10428 Replace pEd with more-general pI, and fix some printf arg casts.
10429 * lisp.h (pI): New macro, generalizing old pEd macro to other
10430 conversion specifiers. For example, use "...%"pI"d..." rather
10431 than "...%"pEd"...".
10432 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10433 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10434 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10435 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10436 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10437 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10438 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10439 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10440 64-bit hosts.
10441 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10442 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10443 * print.c (safe_debug_print, print_object): Likewise.
10444 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10445 to int.
6f04d126
PE
10446 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10447 avoiding the 0 flag, which is not portable.
c2982e87
PE
10448 * process.c (Fmake_network_process): Use pI to avoid cast.
10449 * region-cache.c (pp_cache): Likewise.
10450 * xdisp.c (decode_mode_spec): Likewise.
10451 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10452 behavior on 64-bit hosts with printf arg.
6f04d126 10453 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10454 (x_stop_queuing_selection_requests): Likewise.
10455 (x_get_window_property): Don't truncate byte count to an 'int'
10456 when tracing.
0b432f21 10457
5e073ec7
PE
10458 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10459 here, since it parses constructs like leading '-' and spaces,
10460 which are not wanted; and it overflows with large numbers.
10461 Instead, simply match F[0-9]+, which is what is wanted anyway.
10462
36372bf9
PE
10463 * alloc.c: Remove unportable assumptions about struct layout.
10464 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10465 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10466 (allocate_vectorlike, make_pure_vector): Use the new macros,
10467 plus offsetof, to remove unportable assumptions about struct layout.
10468 These assumptions hold on all porting targets that I know of, but
10469 they are not guaranteed, they're easy to remove, and removing them
10470 makes further changes easier.
10471
0b432f21
PE
10472 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10473 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10474 (string_overrun_cookie): Now const. Use initializers that
10475 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10476 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10477 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10478 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10479 multiple of sizeof (EMACS_INT); it need not be, if
10480 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10481 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10482
895009e1
JB
104832011-04-26 Juanma Barranquero <lekktu@gmail.com>
10484
10485 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10486
6a7a1b0b
TZ
104872011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10488
10489 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10490 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10491 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10492
841a1577 104932011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10494
10495 * lisp.h (Qdebug): List symbol.
895009e1 10496 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10497 * keyboard.c (debug-on-event): New variable.
10498 (handle_user_signal): Break into debugger when debug-on-event
10499 matches the current signal symbol.
10500
f2d3ba6f
DN
105012011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10502
10503 * alloc.c (check_sblock, check_string_bytes)
10504 (check_string_free_list): Convert to standard C.
10505
42ce4c63
TZ
105062011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10507
10508 * w32.c (emacs_gnutls_push): Fix typo.
10509
825cd63c
EZ
105102011-04-25 Eli Zaretskii <eliz@gnu.org>
10511
fb11d64d
EZ
10512 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10513 "cast to pointer from integer of different size".
10514
825cd63c
EZ
10515 Improve doprnt and its use in verror. (Bug#8545)
10516 * doprnt.c (doprnt): Document the set of format control sequences
10517 supported by the function. Use SAFE_ALLOCA instead of always
10518 using `alloca'.
10519
10520 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10521 is one byte too soon. Don't use xrealloc; instead xfree and
10522 xmalloc anew.
10523
e061a11b
TZ
105242011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10525
10526 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10527 callbacks stage.
10528
10529 * gnutls.c: Renamed global_initialized to
10530 gnutls_global_initialized. Added internals for the
10531 :verify-hostname-error, :verify-error, and :verify-flags
10532 parameters of `gnutls-boot' and documented those parameters in the
10533 docstring. Start callback support.
9173deec
JB
10534 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10535 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10536 on error. Return error code.
e061a11b
TZ
10537 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10538 (emacs_gnutls_read): Likewise.
10539 (Fgnutls_boot): Return handshake error code.
10540 (emacs_gnutls_handle_error): New function.
10541 (wsaerror_to_errno): Likewise.
10542
10543 * w32.h (emacs_gnutls_pull): Add prototype.
10544 (emacs_gnutls_push): Likewise.
10545
10546 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10547 (emacs_gnutls_push): Likewise.
10548
105492011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10550
10551 * process.c (wait_reading_process_output): Check if GnuTLS
10552 buffered some data internally if no FDs are set for TLS
10553 connections.
10554
10555 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10556 (LIBS): Link to USER_LIBS.
10557 ($(BLD)/gnutls.$(0)): New target.
10558
fa6996bc
EZ
105592011-04-24 Eli Zaretskii <eliz@gnu.org>
10560
eb35682e
EZ
10561 * xdisp.c (handle_single_display_spec): Rename the
10562 display_replaced_before_p argument into display_replaced_p, to
10563 make it consistent with the commentary. Fix typos in the
10564 commentary.
10565
e2ad650c
EZ
10566 * textprop.c (syms_of_textprop): Remove dead code.
10567 (copy_text_properties): Delete obsolete commentary about an
10568 interface that was deleted long ago. Fix typos in the description
10569 of arguments.
10570
1b2de274
EZ
10571 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10572 to changes in oldXMenu/XMenu.h from 2011-04-16.
10573 <menu_help_message, prev_menu_help_message>: Constify.
10574 (IT_menu_make_room): menu->help_text is now `const char **';
10575 adjust.
10576
10577 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10578 to changes in oldXMenu/XMenu.h from 2011-04-16.
10579 (struct XMenu): Declare `help_text' `const char **'.
10580
10581 * xfaces.c <Qunspecified>: Make extern again.
10582
10583 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10584 required by POSIX.
1b2de274 10585
762b15be
EZ
10586 * doc.c (get_doc_string): Improve the format passed to `error'.
10587
10588 * doprnt.c (doprnt): Improve commentary.
10589
10590 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10591
10592 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10593 them with etags.
10594
f1052e5d
EZ
10595 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10596 changes in globals.h immediately force recompilation.
762b15be
EZ
10597 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10598 $(CURDIR)/s/ms-w32.h.
10599 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10600
fa6996bc
EZ
10601 * character.c (Fchar_direction): Function deleted.
10602 (syms_of_character): Don't defsubr it.
10603 <char-direction-table>: Deleted.
10604
e6c3da20
EZ
106052011-04-23 Eli Zaretskii <eliz@gnu.org>
10606
10607 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10608 * doprnt.c: Include limits.h.
10609 (SIZE_MAX): New macro.
04f2d78b
CB
10610 (doprnt): Return a size_t value. 2nd arg is now size_t.
10611 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10612 Improve overflow protection. Support `l' modifier for integer
10613 conversions. Support %l conversion. Don't assume an EMACS_INT
10614 argument for integer conversions and for %c.
10615
10616 * lisp.h (doprnt): Restore prototype.
10617
10618 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10619 $(SRC)/character.h.
10620
10621 * Makefile.in (base_obj): Add back doprnt.o.
10622
10623 * deps.mk (doprnt.o): Add back prerequisites.
10624 (callint.o): Depend on character.h.
10625
10626 * eval.c (internal_lisp_condition_case): Include the handler
10627 representation in the error message.
10628 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10629 when breaking from the loop.
10630
10631 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10632
10633 * callint.c (Fcall_interactively): When displaying error message
10634 about invalid control letter, pass the character's codepoint, not
10635 a pointer to its multibyte form. Improve display of the character
10636 in octal and display also its hex code.
10637
10638 * character.c (char_string): Use %x to display the (unsigned)
10639 codepoint of an invalid character, to avoid displaying a bogus
10640 negative value.
10641
10642 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10643 `error', not SYMBOL_NAME itself.
10644
10645 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10646 character arguments to `error'.
10647
10648 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10649 to `error' in error message about FINAL_CHAR argument. Make sure
10650 FINAL_CHAR is a character, and use %c when it is passed as
10651 argument to `error'.
10652
4ffd0d6b 106532011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10654
10655 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10656
10657 * w32.c: Include <time.h>.
10658 (sys_localtime): New function.
10659
4ffd0d6b 106602011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10661
10662 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10663
4ffd0d6b 10664 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10665
4ffd0d6b 106662011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10667
4ffd0d6b
GM
10668 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10669 zombies (Bug#8467).
aac0c6e3 10670
04c56954
EZ
106712011-04-19 Eli Zaretskii <eliz@gnu.org>
10672
10673 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10674 gl_state.e_property when gl_state.object is Qt.
10675
10676 * insdel.c (make_gap_larger): Remove limitation of buffer size
10677 to <= INT_MAX.
10678
16a43933
CY
106792011-04-18 Chong Yidong <cyd@stupidchicken.com>
10680
10681 * xdisp.c (lookup_glyphless_char_display)
10682 (produce_glyphless_glyph): Handle cons cell entry in
10683 glyphless-char-display.
10684 (Vglyphless_char_display): Document it.
10685
10686 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10687 glyphless-char-display.
10688
4581706e
CY
106892011-04-17 Chong Yidong <cyd@stupidchicken.com>
10690
10691 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10692
10693 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10694
10695 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10696 definition for no-X builds.
10697
4887c6e2 106982011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10699
fd35b6f9
PE
10700 Static checks with GCC 4.6.0 and non-default toolkits.
10701
5c1ccb01
PE
10702 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10703
006c5daa
PE
10704 * process.c (keyboard_bit_set): Define only if SIGIO.
10705 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10706 (send_process): Repair possible setjmp clobbering.
10707
efc736d3
PE
10708 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10709
4e2fe2e6
PE
10710 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10711
f97334a2
PE
10712 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10713
4e75f29d
PE
10714 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10715 Define only if needed.
10716
90efadd1
PE
10717 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10718 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10719 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10720
3c647824
PE
10721 * dispextern.h (struct redisplay_interface): Rename param
10722 to avoid shadowing.
e264f262 10723 * termhooks.h (struct terminal): Likewise.
761383f4 10724 * xterm.c (xembed_send_message): Likewise.
3c647824 10725
b58c5c4a
PE
10726 * insdel.c (make_gap_smaller): Define only if
10727 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10728
cad59032
PE
10729 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10730 it.
10731
c339dc2e
PE
10732 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10733 so that we aren't warned about unused symbols.
10734
91a3e27b
PE
10735 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10736
399c71d3 10737 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10738
8ffc96f5
PE
10739 * xfns.c (x_real_positions): Mark locals as initialized.
10740
eef9bc79
PE
10741 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10742
098db9dd
PE
10743 * xterm.c: Fix problems found by static analysis with other toolkits.
10744 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10745 (x_dispatch_event): Declare static if USE_GTK, and
10746 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10747 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10748 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10749 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10750 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10751
eb18f6cc
PE
10752 * xmenu.c (menu_help_callback): Pointer type fixes.
10753 Use const pointers when pointing at readonly data. Avoid pointer
10754 signedness clashes.
10755 (FALSE): Remove unused macro.
10756 (update_frame_menubar): Remove unused decl.
10757
1fe72bf8
PE
10758 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10759
60d9e1db
PE
10760 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10761 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10762 (single_menu_item): Rename local to avoid shadowing.
10763
39261c26
PE
10764 * keyboard.c (make_lispy_event): Remove unused local var.
10765
018c5e19
PE
10766 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10767 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10768
63d2b86e
PE
10769 * bitmaps: Change bitmaps from unsigned char back to the X11
10770 compatible char. Avoid the old compiler warnings about
10771 out-of-range initializers by using, for example, '\xab' rather
10772 than 0xab.
10773
aefd87e1
PE
10774 * xgselect.c (xgselect_initialize): Check vs interface
10775 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10776
bf501fb9
PE
10777 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10778
e9829fdf
PE
10779 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10780 to read-only memory.
10781
1086c095
PE
10782 * fns.c (vector): Remove; this old hack is no longer needed.
10783
2baccd04 10784 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10785 Remove unused var.
dde42981 10786 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10787
72391843 10788 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10789
436c16df 10790 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10791 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10792 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10793
92bb796d 10794 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10795 (x_term_init): Remove local to avoid shadowing.
92bb796d 10796
764430a3 10797 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10798
10799 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10800 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10801
d1dfb56c
EZ
108022011-04-16 Eli Zaretskii <eliz@gnu.org>
10803
c4354cb4
EZ
10804 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10805
d1dfb56c
EZ
10806 Fix regex.c, syntax.c and friends for buffers > 2GB.
10807 * syntax.h (struct gl_state_s): Declare character position members
10808 EMACS_INT.
10809
10810 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10811
04f2d78b
CB
10812 * textprop.c (verify_interval_modification, interval_of):
10813 Declare arguments EMACS_INT.
d1dfb56c
EZ
10814
10815 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10816 EMACS_INT.
10817
10818 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10819
10820 * indent.c (Fvertical_motion): Local variable it_start is now
10821 EMACS_INT.
10822
10823 * regex.c (re_match, re_match_2, re_match_2_internal)
10824 (bcmp_translate, regcomp, regexec, print_double_string)
10825 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10826 (re_compile_pattern, re_exec): Declare arguments and local
10827 variables `size_t' and `ssize_t' and return values `regoff_t', as
10828 appropriate.
10829 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10830 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10831 <compile_stack_type>: `size' and `avail' are now `size_t'.
10832
10833 * regex.h <regoff_t>: Use ssize_t, not int.
10834 (re_search, re_search_2, re_match, re_match_2): Arguments that
10835 specify buffer/string position and length are now ssize_t and
10836 size_t. Return type is regoff_t.
10837
613052cd
BK
108382011-04-16 Ben Key <bkey76@gmail.com>
10839
10840 * nsfont.m: Fixed bugs in ns_get_family and
10841 ns_descriptor_to_entity that were caused by using free to
10842 deallocate memory blocks that were allocated by xmalloc (via
10843 xstrdup). This caused Emacs to crash when compiled with
10844 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10845 --enable-checking=xmallocoverrun). xfree is now used to
10846 deallocate these memory blocks.
10847
4170f62f 108482011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10849
71b41406
PE
10850 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10851
9587a89d
PE
10852 emacs_write: Accept and return EMACS_INT for sizes.
10853 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10854 et seq.
10855 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10856 Accept and return EMACS_INT.
10857 (emacs_gnutls_write): Return the number of bytes written on
10858 partial writes.
10859 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10860 (emacs_read, emacs_write): Remove check for negative size, as the
10861 Emacs source code has been audited now.
9587a89d
PE
10862 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10863 (emacs_read, emacs_write): Use it.
273a5f82
PE
10864 * process.c (send_process): Adjust to the new signatures of
10865 emacs_write and emacs_gnutls_write. Do not attempt to store
10866 a byte offset into an 'int'; it might overflow.
9587a89d 10867 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10868
3e047f51
PE
10869 * sound.c: Don't assume sizes fit in 'int'.
10870 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10871 Return EMACS_INT, not int.
3e047f51 10872 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10873 Accept EMACS_INT, not int.
10874 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10875 record read return values.
10876
cc39a9db
BK
108772011-04-15 Ben Key <bkey76@gmail.com>
10878
c9d0ec6d
JB
10879 * keyboard.c (Qundefined): Don't declare static since it is used
10880 in nsfns.m.
10881 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10882 static since they are used in nsfont.m.
cc39a9db 10883
6c60eb9f
SM
108842011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10885
10886 * process.c (Qprocessp): Don't declare static.
10887 * lisp.h (Qprocessp): Declare again.
10888
7990b61a
JB
108892011-04-15 Juanma Barranquero <lekktu@gmail.com>
10890
10891 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10892
5d4cb038
PE
108932011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10894
8bd7b830 10895 Improve C-level modularity by making more things 'static'.
cd64ea1d 10896
e3b27b31
PE
10897 Don't publish debugger-only interfaces to other modules.
10898 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10899 (verify_bytepos, count_markers): Move decls to the only modules
10900 that need them.
10901 * region-cache.h (pp_cache): Likewise.
10902 * window.h (check_all_windows): Likewise.
10903 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10904
5d4cb038
PE
10905 * sysdep.c (croak): Now static, if
10906 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10907 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10908
10909 * alloc.c (refill_memory_reserve): Now static if
10910 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10911 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10912
e87b6180
PE
10913 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10914 Define only if USE_LUCID.
10915
ac64929e
PE
10916 * xrdb.c (x_customization_string, x_rm_string): Now static.
10917
6f37259d
PE
10918 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10919 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10920
1683e3ab
PE
10921 * xdisp.c (draw_row_with_mouse_face): Now static.
10922 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10923
de9c2632
PE
10924 * window.h (check_all_windows): Mark externally visible.
10925
2b96acb7
PE
10926 * window.c (window_deletion_count): Now static.
10927
10928 * undo.c: Make symbols static if they're not exported.
10929 (last_undo_buffer, last_boundary_position, pending_boundary):
10930 Now static.
10931
50436f33
PE
10932 * textprop.c (interval_insert_behind_hooks): Now static.
10933 (interval_insert_in_front_hooks): Likewise.
10934
64520e5c
PE
10935 * term.c: Make symbols static if they're not exported.
10936 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10937 (max_frame_lines, tty_set_terminal_modes):
10938 (tty_reset_terminal_modes, tty_turn_off_highlight):
10939 (get_tty_terminal): Now static.
10940 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10941 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10942 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10943 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10944 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10945
1fa53021
PE
10946 * sysdep.c: Make symbols static if they're not exported.
10947 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10948 Now static.
10949 (sigprocmask_set, full_mask): Remove; unused.
10950 (wait_debugging): Mark as visible.
10951 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10952 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10953
d4b43b22
PE
10954 * syntax.c (syntax_temp): Define only if !__GNUC__.
10955
b7c513d0
PE
10956 * sound.c (current_sound_device, current_sound): Now static.
10957
989b29ad
PE
10958 * search.c (searchbufs, searchbuf_head): Now static.
10959
13a55a78
PE
10960 * scroll.c (scroll_cost): Remove; unused.
10961 * dispextern.h (scroll_cost): Remove decl.
10962
de68a1fc
PE
10963 * region-cache.h (pp_cache): Mark as externally visible.
10964
40ccffa6
PE
10965 * process.c: Make symbols static if they're not exported.
10966 (process_tick, update_tick, create_process, chan_process):
10967 (Vprocess_alist, proc_buffered_char, datagram_access):
10968 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10969 (deactivate_process): Mark defn as static, as well as decl.
10970 * lisp.h (create_process): Remove decl.
10971 * process.h (chan_process, Vprocess_alist): Remove decls.
10972
ad64fc97
PE
10973 * print.c: Make symbols static if they're not exported.
10974 (print_depth, new_backquote_output, being_printed, print_buffer):
10975 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10976 (print_interval, print_number_index, initial_stderr_stream):
10977 Now static.
10978 * lisp.h (Fprinc): Remove decl.
10979 (debug_output_compilation_hack): Mark as externally visible.
10980
adddb265
PE
10981 * sysdep.c (croak): Move decl from here to syssignal.h.
10982 * syssignal.h (croak): Put it here, so the API can be checked when
10983 'croak' is called from dissociate_if_controlling_tty.
10984
1717ede2
PE
10985 * minibuf.c: Make symbols static if they're not exported.
10986 (minibuf_save_list, choose_minibuf_frame): Now static.
10987 * lisp.h (choose_minibuf_frame): Remove decl.
10988
fa5fb2bc
PE
10989 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10990
1e3890d1
PE
10991 * lread.c: Make symbols static if they're not exported.
10992 (read_objects, initial_obarray, oblookup_last_bucket_number):
10993 Now static.
10994 (make_symbol): Remove; unused.
10995 * lisp.h (initial_obarray, make_symbol): Remove decls.
10996
8a1414fa
PE
10997 * keyboard.c: Make symbols static if they're not exported.
10998 (single_kboard, recent_keys_index, total_keys, recent_keys):
10999 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11000 (this_single_command_key_start, echoing, last_auto_save):
11001 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11002 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11003 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11004 (Vlispy_mouse_stem, double_click_count):
11005 Now static.
11006 (force_auto_save_soon): Define only if SIGDANGER.
11007 (ignore_mouse_drag_p): Now static if
11008 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11009 (print_help): Remove; unused.
11010 (stop_character, last_timer_event): Mark as externally visible.
11011 * keyboard.h (ignore_mouse_drag_p): Declare only if
11012 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11013 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11014 * lisp.h (echoing): Remove decl.
11015 (force_auto_save_soon): Declare only if SIGDANGER.
11016 * xdisp.c (redisplay_window): Simplify code, to make it more
11017 obvious that ignore_mouse_drag_p is not accessed if !defined
11018 USE_GTK && !defined HAVE_NS.
11019
93ea6e8f
PE
11020 * intervals.c: Make symbols static if they're not exported.
11021 (merge_properties_sticky, merge_interval_right, delete_interval):
11022 Now static.
11023 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11024
77382fcc
PE
11025 * insdel.c: Make symbols static if they're not exported.
11026 However, leave prepare_to_modify_buffer alone. It's never
11027 called from outside this function, but that appears to be a bug.
11028 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11029 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11030 (adjust_after_replace_noundo): Remove; unused.
11031 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11032 (signal_before_change): Remove decls.
77382fcc 11033
9306c32e
PE
11034 * indent.c (val_compute_motion, val_vmotion): Now static.
11035
cd44d2eb
PE
11036 * image.c: Make symbols static if they're not exported.
11037 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11038 if USE_GTK.
11039 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11040 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11041
ad9a7a06
PE
11042 * fringe.c (standard_bitmaps): Now static.
11043 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11044
81626931
PE
11045 * frame.c: Make symbols static if they're not exported.
11046 (x_report_frame_params, make_terminal_frame): Now static.
11047 (get_frame_param): Now static, unless HAVE_NS.
11048 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11049 (x_get_resource_string): Remove; not used.
11050 * frame.h (make_terminal_frame, x_report_frame_params):
11051 (x_get_resource_string); Remove decls.
11052 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11053 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11054
239f9db9
PE
11055 * font.c, fontset.c: Make symbols static if they're not exported.
11056 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11057 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11058 * font.c (font_close_object): Now static.
11059 * font.h (font_close_object): Remove.
11060 * fontset.c (FONTSET_OBJLIST): Remove.
11061 (free_realized_fontset) #if-0 the body, which does nothing.
11062 (face_suitable_for_char_p): #if-0, as it's never called.
11063 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11064 * xfaces.c (face_at_string_position):
11065 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11066 since 0 is always ASCII.
11067
dfcf3579
PE
11068 * fns.c (weak_hash_tables): Now static.
11069
5045092b
PE
11070 * fileio.c: Make symbols static if they're not exported.
11071 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11072 (Vwrite_region_annotation_buffers): Now static.
11073
57a96f5c
PE
11074 * eval.c: Make symbols static if they're not exported.
11075 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11076 * lisp.h (backtrace_list): Remove decl.
11077
35f08c38
PE
11078 * emacs.c: Make symbols static if they're not exported.
11079 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11080 (fatal_error_code, fatal_error_signal_hook, standard_args):
11081 Now static.
11082 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11083 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11084 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11085 * lisp.h (fatal_error_signal_hook): Remove decl.
11086 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11087
f44bd759
PE
11088 * editfns.c: Move a (normally-unused) function to its only use.
11089 * editfns.c, lisp.h (get_operating_system_release): Remove.
11090 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11091 worth the hassle of breaking this out.
11092
b532497d
PE
11093 * xterm.c: Make symbols static if they're not exported.
11094 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11095 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11096 (x_destroy_window, x_delete_display):
11097 Now static.
11098 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11099 (x_mouse_leave): Remove; unused.
11100 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11101 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11102 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11103 Remove decls.
11104 (x_mouse_leave): Declare only if WINDOWSNT.
11105 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11106 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11107 USE_X_TOOLKIT.
11108
1675728f
PE
11109 * ftxfont.c: Make symbols static if they're not exported.
11110 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11111 HAVE_FREETYPE.
11112 * font.h (ftxfont_driver): Likewise.
11113
e4cebfca
PE
11114 * xfns.c: Make symbols static if they're not exported.
11115 (x_last_font_name, x_display_info_for_name):
11116 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11117 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11118 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11119 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11120 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11121 (last_show_tip_args): Now static.
11122 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11123 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11124 (x_screen_planes): Remove; unused.
11125 * dispextern.h (x_screen_planes): Remove decl.
11126
5bf46f05
PE
11127 * dispnew.c: Make symbols static if they're not exported.
11128 * dispextern.h (redraw_garbaged_frames, scrolling):
11129 (increment_row_positions): Remove.
11130 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11131 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11132 Now static.
11133 (redraw_garbaged_frames): Remove; unused.
11134
435f4c28
PE
11135 * xfaces.c: Make symbols static if they're not exported.
11136 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11137 Remove decls.
11138 * xterm.h (defined_color): Remove decls.
11139 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11140 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11141 (menu_face_changed_default, defined_color, free_realized_face):
11142 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11143 (ascii_face_of_lisp_face): Remove; unused.
11144
8524aef3
PE
11145 * xdisp.c: Make symbols static if they're not exported.
11146 * dispextern.h (scratch_glyph_row, window_box_edges):
11147 (glyph_to_pixel_coords, set_cursor_from_row):
11148 (get_next_display_element, set_iterator_to_next):
11149 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11150 (show_mouse_face): Remove decls
11151 * frame.h (message_buf_print): Likewise.
11152 * lisp.h (pop_message, set_message, check_point_in_composition):
11153 Likewise.
11154 * xterm.h (set_vertical_scroll_bar): Likewise.
11155 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11156 (message_buf_print, scratch_glyph_row, displayed_buffer):
11157 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11158 (get_next_display_element, show_mouse_face, window_box_edges):
11159 (frame_to_window_pixel_xy, check_point_in_composition):
11160 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11161 (glyph_to_pixel_coords): Remove; unused.
11162
16390cd2
PE
11163 * dired.c (file_name_completion): Now static.
11164
11165 * dbusbind.c (xd_in_read_queued_messages): Now static.
11166
a25f4dfa
PE
11167 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11168 * data.c (circular_list_error): Remove.
11169
14a9c8df
PE
11170 * commands.h (last_point_position, last_point_position_buffer):
11171 (last_point_position_window): Remove decls.
11172 * keyboard.c: Make these variables static.
11173
04f2d78b
CB
11174 * coding.h (coding, code_convert_region, encode_coding_gap):
11175 Remove decls.
74ab6df5
PE
11176 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11177 (iso_code_class, detect_coding, code_convert_region): Now static.
11178 (encode_coding_gap): Remove; unused.
11179
38dfbee1
PE
11180 * chartab.c (chartab_chars, chartab_bits): Now static.
11181
a2cb4e63
PE
11182 * charset.h (charset_iso_8859_1): Remove decl.
11183 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11184 Now static.
11185
127198fd
PE
11186 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11187 * ccl.c (Vccl_program_table): Now static.
11188 (check_ccl_update): Remove; unused.
11189
d85b608f
PE
11190 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11191 * category.h: ... from here.
11192 * category.c (check_category_table, set_category_set): Now static.
11193
31cd66f3
PE
11194 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11195 * lisp.h: Remove these decls.
11196
c358e587
PE
11197 * buffer.c (buffer_count): Remove unused var.
11198
e78aecca
PE
11199 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11200 so that it's not optimized away.
11201 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11202 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11203 exported only to the debugger.
11204
e192d7d3 11205 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11206 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11207
92470028
PE
11208 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11209 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11210 was inaccessible from Lisp.
11211 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11212 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11213
244ed907
PE
11214 alloc.c: Import and export fewer symbols, and remove unused items.
11215 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11216 is defined.
11217 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11218 it's not optimized away by whole-program optimization.
11219 (message_enable_multibyte, free_misc): Remove.
11220 (catchlist, handlerlist, mark_backtrace):
11221 Declare only if BYTE_MARK_STACK.
11222 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11223 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11224 (message_enable_multibyte): Remove decl.
11225 (free_misc, interval_free_list, float_block, float_block_index):
11226 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11227 (cons_free_list, last_marked_index):
11228 Now static.
11229 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11230 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11231 (mark_backtrace): Define only if BYTE_MARK_STACK.
11232 * xdisp.c (message_enable_multibyte): Now static.
11233
61c2b50e 11234 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11235 This makes it easier for human readers (and static analyzers)
11236 to see whether these variables are used from other modules.
11237 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11238 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11239 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11240 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11241 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11242 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11243 * xmenu.c, xselect.c:
11244 Declare Q* vars static if they are not used in other modules.
11245 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11246 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11247 Remove decls of unexported vars.
11248 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11249
95c82688
PE
11250 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11251
16a97296
PE
11252 Make Emacs functions such as Fatom 'static' by default.
11253 This makes it easier for human readers (and static analyzers)
11254 to see whether these functions can be called from other modules.
11255 DEFUN now defines a static function. To make the function external
11256 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11257 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11258 (Finit_image_library):
16a97296
PE
11259 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11260 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11261 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11262 Remove decls, since these functions are now static.
11263 (Funintern, Fget_internal_run_time): New decls, since these functions
11264 were already external.
95c82688 11265
16a97296
PE
11266 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11267 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11268 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11269 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11270 * keyboard.c, keymap.c, lread.c:
11271 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11272 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11273 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11274 Mark functions with DEFUE instead of DEFUN,
11275 if they are used in other modules.
11276 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11277 decls for now-static functions.
11278 * buffer.h (Fdelete_overlay): Remove decl.
11279 * callproc.c (Fgetenv_internal): Mark as internal.
11280 * composite.c (Fremove_list_of_text_properties): Remove decl.
11281 (Fcomposition_get_gstring): New forward static decl.
11282 * composite.h (Fcomposite_get_gstring): Remove decl.
11283 * dired.c (Ffile_attributes): New forward static decl.
11284 * doc.c (Fdocumntation_property): New forward static decl.
11285 * eval.c (Ffetch_bytecode): New forward static decl.
11286 (Funintern): Remove extern decl; now in .h file where it belongs.
11287 * fileio.c (Fmake_symbolic_link): New forward static decl.
11288 * image.c (Finit_image_library): New forward static decl.
11289 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11290 * intervals.h (Fprevious_property_change):
11291 (Fremove_list_of_text_properties): Remove decls.
11292 * keyboard.c (Fthis_command_keys): Remove decl.
11293 (Fcommand_execute): New forward static decl.
11294 * keymap.c (Flookup_key): New forward static decl.
11295 (Fcopy_keymap): Now static.
11296 * keymap.h (Flookup_key): Remove decl.
11297 * process.c (Fget_process): New forward static decl.
11298 (Fprocess_datagram_address): Mark as internal.
11299 * syntax.c (Fsyntax_table_p): New forward static decl.
11300 (skip_chars): Remove duplicate decl.
11301 * textprop.c (Fprevious_property_change): New forward static decl.
11302 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11303 Now internal.
11304 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11305 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11306
785bbd42
PE
11307 * editfns.c (Fformat): Remove unreachable code.
11308
8b913b57
AS
113092011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11310
11311 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11312 change. (Bug#8496)
11313
a6744a35
EZ
113142011-04-13 Eli Zaretskii <eliz@gnu.org>
11315
11316 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11317 when at ZV. (Bug#8487)
11318
e7974947
AS
113192011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11320
baad03f0
AS
11321 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11322 (Bug#8437)
11323 * keyboard.c (parse_tool_bar_item): Likewise.
11324 * sound.c (sound_cleanup, alsa_close): Likewise.
11325 * termcap.c (tgetent): Likewise.
11326 * xfns.c (x_default_font_parameter): Likewise.
11327 * xsettings.c (read_and_apply_settings): Likewise.
11328
e7974947
AS
11329 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11330 (overrun_check_free): Protoize.
11331
28272684
PE
113322011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11333
11334 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11335 since callers should never pass a negative size.
11336 Change the signature to match that of plain 'read' and 'write'; see
11337 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11338 * lisp.h: Update prototypes of emacs_write and emacs_read.
11339
11997c76
EZ
113402011-04-11 Eli Zaretskii <eliz@gnu.org>
11341
11342 * xdisp.c (redisplay_window): Don't try to determine the character
11343 position of the scroll margin if the window start point w->startp
e896f03c 11344 is outside the buffer's accessible region. (Bug#8468)
11997c76 11345
8a2cbd72
EZ
113462011-04-10 Eli Zaretskii <eliz@gnu.org>
11347
11348 Fix write-region and its subroutines for buffers > 2GB.
11349 * fileio.c (a_write, e_write): Modify declaration of arguments and
11350 local variables to support buffers larger than 2GB.
11351 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11352
11353 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11354 argument, local variables, and return value.
11355
11356 * lisp.h: Update prototypes of emacs_write and emacs_read.
11357
11358 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11359
4073e537 113602011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11361
1ebfdcb6
PE
11362 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11363
b2ded58d
PE
11364 Fix more problems found by GCC 4.6.0's static checks.
11365
7d66342c
PE
11366 * xdisp.c (vmessage): Use a better test for character truncation.
11367
bbf47d44
PE
11368 * charset.c (load_charset_map): <, not <=, for optimization,
11369 and to avoid potential problems with integer overflow.
9248994d 11370 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11371 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11372 * editfns.c (Fformat): Likewise.
1e69125e 11373 * syntax.c (skip_chars): Likewise.
3befa583 11374
e3019616
PE
11375 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11376 This also lets GCC 4.6.0 generate slightly better loop code.
11377
becfa255
PE
11378 * callint.c (Fcall_interactively): <, not <=, for optimization.
11379 (Fcall_interactively): Count the number of arguments produced,
11380 not the number of arguments given. This is simpler and lets GCC
11381 4.6.0 generate slightly better code.
11382
dae0cd48
PE
11383 * ftfont.c: Distingish more carefully between FcChar8 and char.
11384 The previous code passed unsigned char * to a functions like
11385 strlen and xstrcasecmp that expect char *, which does not
11386 conform to the C standard.
11387 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11388 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11389 char * when the C standard requires it.
11390
76032d70
PE
11391 * keyboard.c (read_char): Remove unused var.
11392
eb3f1cc8
PE
11393 * eval.c: Port to Windows vsnprintf (Bug#8435).
11394 Include <limits.h>.
11395 (SIZE_MAX): Define if the headers do not.
11396 (verror): Do not give up if vsnprintf returns a negative count.
11397 Instead, grow the buffer. This ports to Windows vsnprintf, which
11398 does not conform to C99. Problem reported by Eli Zaretskii.
11399 Also, simplify the allocation scheme, by avoiding the need for
11400 calling realloc, and removing the ALLOCATED variable.
11401
70476b54
PE
11402 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11403
12020a9e
PE
11404 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11405 But keep the doprint source code for now, as we might revamp it
11406 and use it again (Bug#8435).
ea6c7ae6
PE
11407 * lisp.h (doprnt): Remove.
11408 * Makefile.in (base_obj): Remove doprnt.o.
11409 * deps.mk (doprnt.o): Remove.
11410
5fdb398c
PE
11411 error: Print 32- and 64-bit integers portably (Bug#8435).
11412 Without this change, on typical 64-bit hosts error ("...%d...", N)
11413 was used to print both 32- and 64-bit integers N, which relied on
11414 undefined behavior.
61bdb816 11415 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11416 * lisp.h (error, verror): Mark as printf-like functions.
11417 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11418 Report overflow in size calculations when allocating printf buffer.
11419 Do not truncate output string at its first null byte.
11420 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11421 Truncate the output at a character boundary, since vsnprintf does not
11422 do that.
11423 * charset.c (check_iso_charset_parameter): Convert internal
11424 character to string before calling 'error', since %c now has the
11425 printf meaning.
11426 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11427 overflow when computing char to be passed to 'error'. Do not
11428 pass Lisp_Object to 'error'; pass the integer instead.
11429 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11430 formatted with plain %d.
11431
b189fa66
PE
11432 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11433
bff87ef0
PE
11434 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11435
7e2cac20
PE
11436 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11437
ce4d90b5
PE
11438 * xterm.c (x_catch_errors): Remove duplicate declaration.
11439
266c9547
PE
11440 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11441
79c49ad2
PE
11442 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11443
368f4090
JM
114442011-04-10 Jim Meyering <meyering@redhat.com>
11445
11446 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11447 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11448 return ssize_t not "int", and use size_t as the buffer length.
11449 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11450 * gnutls.h: Update declarations.
11451 * process.c (read_process_output): Use ssize_t, to match.
11452 (send_process): Likewise.
11453
a32d4040
CY
114542011-04-09 Chong Yidong <cyd@stupidchicken.com>
11455
11456 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11457
8546720e 114582011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11459
04f2d78b
CB
11460 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11461 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11462
8546720e
GM
11463 * xterm.c (handle_one_xevent):
11464 * xmenu.c (create_and_show_popup_menu):
11465 * xselect.c (x_decline_selection_request)
11466 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11467
0a2f5c1a 114682011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11469
11470 Fix some uses of `int' instead of EMACS_INT.
11471 * search.c (string_match_1, fast_string_match)
11472 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11473 (scan_buffer, find_next_newline_no_quit)
11474 (find_before_next_newline, search_command, Freplace_match)
11475 (Fmatch_data): Make some `int' variables be EMACS_INT.
11476
11477 * xdisp.c (display_count_lines): 3rd argument and return value now
11478 EMACS_INT. All callers changed.
11479 (pint2hrstr): Last argument is now EMACS_INT.
11480
11481 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11482 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11483 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11484 (decode_coding_utf_16, decode_coding_emacs_mule)
11485 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11486 (decode_coding_ccl, decode_coding_charset)
11487 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11488 (decode_coding_iso_2022, decode_coding_emacs_mule)
11489 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11490 <char_offset, last_offset>: Declare EMACS_INT.
11491 (encode_coding_utf_8, encode_coding_utf_16)
11492 (encode_coding_emacs_mule, encode_invocation_designation)
11493 (encode_designation_at_bol, encode_coding_iso_2022)
11494 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11495 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11496 Declare EMACS_INT.
11497 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11498 (encode_invocation_designation): Last argument P_NCHARS is now
11499 EMACS_INT.
11500 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11501 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11502
11503 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11504 All users changed.
11505
11506 * ccl.c (Fccl_execute_on_string): Declare some variables
11507 EMACS_INT.
11508
8546720e 115092011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11510
11511 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11512
4e19a977
CS
115132011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11514
11515 * process.c (Fformat_network_address): Doc fix.
11516
87302331
R
115172011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11518
ee7683eb 11519 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11520
cbb59342
CY
115212011-04-08 Chong Yidong <cyd@stupidchicken.com>
11522
11523 * keyboard.c (read_char): Call Lisp function help-form-show,
11524 instead of using internal_with_output_to_temp_buffer.
11525 (Qhelp_form_show): New var.
e0d38eeb 11526 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11527
11528 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11529
11530 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11531
e67a13ab
CY
115322011-04-06 Chong Yidong <cyd@stupidchicken.com>
11533
04f2d78b
CB
11534 * process.c (Flist_processes): Remove to Lisp.
11535 (list_processes_1): Delete.
e67a13ab 11536
973f782d
EZ
115372011-04-06 Eli Zaretskii <eliz@gnu.org>
11538
7c106b1e
EZ
11539 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11540
973f782d
EZ
11541 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11542
41cf7d1a 115432011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11544
ca23cc88
PE
11545 Fix more problems found by GCC 4.6.0's static checks.
11546
f390e2d5
PE
11547 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11548
42eea0d0
PE
11549 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11550
b69769da 11551 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11552
f9541e84
PE
11553 * xdisp.c (vmessage): Mark as a printf-like function.
11554
13841b55
PE
11555 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11556
c136c10f
PE
11557 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11558
5e2d4a30
PE
11559 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11560 printf-like functions.
11561 (tiff_load): Add casts to remove these marks before passing them
11562 to system-supplied API.
11563
583f48b9
PE
11564 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11565
b25d760e
PE
11566 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11567 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11568 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11569 directly, rather than having caller test rule sign. This avoids
11570 some unnecessary tests.
11571 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11572 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11573 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11574
bc7b6697 11575 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11576 (xfont_open): Avoid unnecessary tests.
bc7b6697 11577
27ccc379
PE
11578 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11579
dcd5c89a
PE
11580 * composite.h, composite.c (composition_gstring_put_cache):
11581 Use EMACS_INT, not int, for length.
11582
b13a45c6
PE
11583 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11584 breaking out part of COMPOSITION_DECODE_RULE.
11585 (COMPOSITION_DECODE_RULE): Use it.
11586 * composite.c (get_composition_id): Remove unused local vars,
11587 by using the new macro.
11588
1e792e4d
PE
11589 * textprop.c (set_text_properties_1): Change while to do-while,
11590 since the condition is always true at first.
11591
dc6c6455 11592 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11593 (interval_deletion_adjustment): Return unsigned value.
11594 All uses changed.
dc6c6455 11595
aba7731a
PE
11596 * process.c (list_processes_1, create_pty, read_process_output):
11597 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11598 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11599 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11600 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11601 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11602
fdfc4bf3
PE
11603 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11604
fca8fe46 11605 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11606 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11607
06a0259a 11608 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11609 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11610 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11611
e7b9e80f
PE
11612 * print.c (print_error_message): Avoid int overflow.
11613
56201685
PE
11614 * font.c (font_list_entities): Redo for clarity,
11615 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11616
78834453 11617 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11618 (font_score): Avoid potential overflow in diff calculation.
78834453 11619
0bc0b309 11620 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11621 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11622
e610eaca
PE
11623 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11624
b895abce
PE
11625 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11626 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11627 can always succeed if overflow has undefined behavior.
11628
1f1d9321 11629 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11630 (wordify): Omit three unnecessary tests.
1f1d9321 11631
c59478bc
PE
11632 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11633 All callers changed. This avoids the need for an unused var.
11634
79b73827
PE
11635 * casefiddle.c (casify_region): Remove var that is set but not used.
11636
a4db5dfe
PE
11637 * dired.c (file_name_completion): Remove var that is set but not used.
11638
43aae36e
PE
11639 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11640
2a47c44d 11641 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11642 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11643
a37c69bf
PE
11644 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11645 Check for integer overflow on size calculations.
11646
328ab8e7
PE
11647 * buffer.c (Fprevious_overlay_change): Remove var that is set
11648 but not used.
11649
e5a2a5cb
PE
11650 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11651 Remove vars that are set but not used.
8d84a6eb 11652 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11653 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11654
a60e5f68
PE
11655 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11656
f661cb61 11657 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11658 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11659
f0397f5a
PE
11660 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11661 that are set but not used.
11662
8664db06 11663 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11664 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11665
6abdaa4a
PE
11666 * xselect.c (x_get_local_selection, x_handle_property_notify):
11667 Remove vars that are set but not used.
11668
0ce7538d 11669 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11670 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11671
9ae848fc
PE
11672 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11673 Remove var that is set but not used.
0b918413
PE
11674 (scroll_bar_windows_size): Now size_t, not int.
11675 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11676 Check for overflow.
9ae848fc 11677
a5a62657
PE
11678 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11679 (map_tty_color) [!defined MSDOS]: Likewise.
11680
5c5cdd39
PE
11681 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11682
66ebf983
PE
11683 * coding.c: Remove vars that are set but not used.
11684 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11685 All callers changed.
11686 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11687 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11688 (decode_coding_charset): Remove vars that are set but not used.
11689
1be4d761
PE
11690 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11691 that is set but not used.
11692
47553fa8
PE
11693 * print.c (print_object): Remove var that is set but not used.
11694
1f7196bf 11695 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11696 The gnulib version avoids calling malloc in the usual case,
11697 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11698 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11699 * filelock.c (current_lock_owner): Likewise.
11700 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11701 * sysdep.c: Include allocator.h, careadlinkat.h.
11702 (emacs_no_realloc_allocator): New static constant.
11703 (emacs_readlink): New function.
fdb61804
PE
11704 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11705 ../lib/careadlinkat.h.
d1fdcab7 11706
f84c17c7
SM
117072011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11708
11709 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11710 first non-nil return value).
11711
ef3862ad
JD
117122011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11713
11714 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11715 if not defined (Bug#8403).
11716
376a7006
JB
117172011-04-02 Juanma Barranquero <lekktu@gmail.com>
11718
11719 * xdisp.c (display_count_lines): Remove parameter `start',
11720 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11721 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11722 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11723 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11724 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11725 and thereabouts. All callers changed.
11726 (get_per_char_metric): Remove parameter `f', unused since
11727 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11728
6ca3801d
JM
117292011-04-02 Jim Meyering <meyering@redhat.com>
11730
11731 do not dereference NULL upon failed strdup
11732 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11733 (ns_get_family): Likewise.
11734
d8e2b5ba
JB
117352011-04-02 Juanma Barranquero <lekktu@gmail.com>
11736
11737 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11738
8c74fcbd
JD
117392011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11740
11741 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11742 later (Bug#8403).
11743
7200d79c
SM
117442011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11745
03408648 11746 Add lexical binding.
7200d79c 11747
03408648
SM
11748 * window.c (Ftemp_output_buffer_show): New fun.
11749 (Fsave_window_excursion):
11750 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11751
11752 * lread.c (lisp_file_lexically_bound_p): New function.
11753 (Fload): Bind Qlexical_binding.
11754 (readevalloop): Remove `evalfun' arg.
11755 Bind Qinternal_interpreter_environment.
11756 (Feval_buffer): Bind Qlexical_binding.
11757 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11758 Mark as dynamic.
11759 (syms_of_lread): Declare `lexical-binding'.
11760
11761 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11762
11763 * keyboard.c (eval_dyn): New fun.
11764 (menu_item_eval_property): Use it.
ca105506
SM
11765
11766 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11767
03408648
SM
11768 * fns.c (concat, mapcar1): Accept byte-code-functions.
11769
11770 * eval.c (Fsetq): Handle lexical vars.
11771 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11772 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11773 (FletX, Flet): Obey lexical binding.
11774 (Fcommandp): Handle closures.
11775 (Feval): New `lexical' arg.
11776 (eval_sub): New function extracted from Feval. Use it almost
11777 everywhere where Feval was used. Look up vars in lexical env.
11778 Handle closures.
11779 (Ffunctionp): Move from subr.el.
11780 (Ffuncall): Handle closures.
11781 (apply_lambda): Remove `eval_flags'.
11782 (funcall_lambda): Handle closures and new byte-code-functions.
11783 (Fspecial_variable_p): New function.
11784 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11785 but without exporting it to Lisp.
23aba0ea 11786
23aba0ea 11787 * doc.c (Fdocumentation, store_function_docstring):
03408648 11788 * data.c (Finteractive_form): Handle closures.
23aba0ea 11789
03408648
SM
11790 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11791 interactive spec.
ba83908c 11792
04f2d78b
CB
11793 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11794 New byte-codes.
03408648
SM
11795 (exec_byte_code): New function extracted from Fbyte_code to handle new
11796 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11797
03408648 11798 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11799
03408648 11800 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11801
e2abce01
JB
118022011-03-31 Juanma Barranquero <lekktu@gmail.com>
11803
11804 * xdisp.c (redisplay_internal): Fix prototype.
11805
63696a73 118062011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11807
63696a73 11808 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11809 (try_scrolling): Use it when setting scroll_limit.
11810 Limit scrolling to 100 screen lines.
63696a73
EZ
11811 (redisplay_window): Even when falling back on "recentering",
11812 position point in the window according to scroll-conservatively,
11813 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11814
11815 (try_scrolling): When point is above the window, allow searching
11816 as far as scroll_max, or one screenful, to compute vertical
11817 distance from PT to the scroll margin position. This prevents
11818 try_scrolling from unnecessarily failing when
11819 scroll-conservatively is set to a value slightly larger than the
11820 window height. Clean up the case of PT below the margin at bottom
11821 of window: scroll_max can no longer be INT_MAX. When aggressive
11822 scrolling is in use, don't let point enter the opposite scroll
11823 margin as result of the scroll.
11824 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11825 threshold of 100 lines for never-recentering scrolling.
11826
e4cc2dfc
JB
118272011-03-31 Juanma Barranquero <lekktu@gmail.com>
11828
11829 * dispextern.h (move_it_by_lines):
11830 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11831 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11832 (message_log_check_duplicate): Remove parameters `prev_bol' and
11833 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11834 (redisplay_internal): Remove parameter `preserve_echo_area',
11835 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11836
11837 * indent.c (Fvertical_motion):
11838 * window.c (window_scroll_pixel_based, Frecenter):
11839 Don't pass `need_y_p' to `move_it_by_lines'.
11840
1c470562
SM
118412011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11842
44f230aa
SM
11843 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11844 steal a few bits to be more compact.
11845 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11846 Remove unneeded casts.
11847
1c470562
SM
11848 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11849
888adce9
ZK
118502011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11851
11852 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11853 binding" message (bug#7967).
11854
f838ed7b
PE
118552011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11856
77861b95
PE
11857 Fix more problems found by GCC 4.6.0's static checks.
11858
de6dbc14
PE
11859 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11860 Remove unused local var.
11861
f838ed7b
PE
11862 * editfns.c (Fmessage_box): Remove unused local var.
11863
792c7b2b
PE
11864 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11865 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11866 Omit unused local vars.
c499e557 11867 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11868 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11869 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11870 Omit unused local var.
11871
ba0165e1
PE
11872 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11873 Don't assume string length fits in int.
32ad8845 11874 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11875 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11876
3c59b4c9
PE
11877 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11878 instead of alloca (Bug#8344).
11879
a3eed478 11880 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11881 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11882
eb4d412d
PE
11883 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11884
1658b401
PE
11885 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11886 concerns.
11887
11888 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11889
11890 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11891
9a2c6e05
PE
11892 * keyboard.c (syms_of_keyboard): Use the same style as later
11893 in this function when indexing through an array. This also
11894 works around GCC bug 48267.
11895
03d0a109
PE
11896 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11897
44f730c8
PE
11898 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11899
fe75f926
PE
11900 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11901 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11902
ffa8c828
PE
11903 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11904 This avoids undefined behavior on integer overflow, and is a bit
11905 more convenient anyway since it is compared to a size_t variable.
11906
c5101a77
PE
11907 Variadic C functions now count arguments with size_t, not int.
11908 This avoids an unnecessary limitation on 64-bit machines, which
11909 caused (substring ...) to crash on large vectors (Bug#8344).
11910 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11911 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11912 All variadic functions and their callers changed accordingly.
c5101a77
PE
11913 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11914 * data.c (arith_driver, float_arith_driver): Likewise.
11915 * editfns.c (general_insert_function): Likewise.
11916 * eval.c (struct backtrace.nargs, interactive_p)
11917 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11918 (funcall_lambda, mark_backtrace): Likewise.
11919 * fns.c (concat): Likewise.
11920 * frame.c (x_set_frame_parameters): Likewise.
11921 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11922 0 if not found, not -1. All callers changed.
11923
dd3f25f7
PE
11924 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11925 (stack_copy_size): Now size_t, not int.
11926 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11927
461c2ab9
JB
119282011-03-28 Juanma Barranquero <lekktu@gmail.com>
11929
11930 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11931 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11932 All callers changed.
11933
11934 * lisp.h (multibyte_char_to_unibyte):
11935 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11936 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11937 * character.h (CHAR_TO_BYTE8):
11938 * cmds.c (internal_self_insert):
11939 * editfns.c (general_insert_function):
11940 * keymap.c (push_key_description):
11941 * search.c (Freplace_match):
11942 * xdisp.c (message_dolog, set_message_1): All callers changed.
11943
f6d62986
SM
119442011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11945
11946 * keyboard.c (safe_run_hook_funcall): New function.
11947 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11948 don't set the hook to nil, but remove the offending function instead.
11949 (Qcommand_hook_internal): Remove, unused.
11950 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11951 Vcommand_hook_internal.
11952
11953 * eval.c (enum run_hooks_condition): Remove.
11954 (funcall_nil, funcall_not): New functions.
11955 (run_hook_with_args): Call each function through a `funcall' argument.
11956 Remove `cond' argument, now redundant.
11957 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11958 (Frun_hook_with_args_until_failure): Adjust accordingly.
11959 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11960
1db5b1ad
JB
119612011-03-28 Juanma Barranquero <lekktu@gmail.com>
11962
11963 * dispextern.h (string_buffer_position): Remove declaration.
11964
11965 * print.c (strout): Remove parameter `multibyte', unused since
11966 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11967
11968 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11969 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11970 All callers changed.
11971
11972 * w32.c (_wsa_errlist): Use braces for struct initializers.
11973
11974 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11975 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11976 All callers changed.
11977 (string_buffer_position): Likewise. Also, make static (it's never
11978 used outside xdisp.c).
11979 (cursor_row_p): Remove parameter `w', unused since
11980 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11981 (decode_mode_spec): Remove parameter `precision', introduced during
11982 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11983 All callers changed.
11984
5ffb62aa
JD
119852011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11986
11987 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11988
461c2ab9 119892011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11990
11991 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11992 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11993 (ns_update_auto_hide_menu_bar): New functions.
11994 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11995 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11996 ns_constrain_all_frames.
11997 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11998 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11999
5c380ffb
JD
120002011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12001
12002 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12003
9af30bdf
GM
120042011-03-27 Glenn Morris <rgm@gnu.org>
12005
12006 * syssignal.h: Replace RETSIGTYPE with void.
12007 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12008 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12009 Replace SIGTYPE with void everywhere.
12010 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12011 * s/template.h (SIGTYPE): Remove commented out definition.
12012
e2abce01
JB
120132011-03-26 Eli Zaretskii <eliz@gnu.org>
12014
12015 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12016 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12017
f868cd8a
JB
120182011-03-26 Juanma Barranquero <lekktu@gmail.com>
12019
59eb0929
JB
12020 * w32.c (read_unc_volume): Use parameter `henum', instead of
12021 global variable `wget_enum_handle'.
12022
12023 * keymap.c (describe_vector): Remove parameters `indices' and
12024 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12025 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12026
f868cd8a
JB
12027 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12028
12029 * keyboard.c (timer_check): Remove parameter `do_it_now',
12030 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12031 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12032 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12033
12034 * keyboard.c (read_char):
12035 * w32menu.c (w32_menu_display_help):
12036 * xmenu.c (show_help_event, menu_help_callback):
12037 Adjust calls to `show_help_echo'.
12038
12039 * gtkutil.c (xg_maybe_add_timer):
12040 * keyboard.c (readable_events):
12041 * process.c (wait_reading_process_output):
12042 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12043
12044 * insdel.c (adjust_markers_gap_motion):
12045 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12046 (gap_left, gap_right): Don't call it.
12047
2ecf6fdb
CY
120482011-03-25 Chong Yidong <cyd@stupidchicken.com>
12049
12050 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12051 incurred during fontification.
12052
6b1f9ba4
JB
120532011-03-25 Juanma Barranquero <lekktu@gmail.com>
12054
12055 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12056 (DEFVAR_PER_BUFFER): Don't pass it.
12057
12058 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12059 (scrolling_window): Don't pass it.
12060
0f4a96b5
JB
120612011-03-25 Juanma Barranquero <lekktu@gmail.com>
12062
12063 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12064
12065 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12066 and `suffix'.
12067 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12068 of variables specific to SELinux and computation of `encoded_absname'.
12069
12070 * image.c (XPutPixel): Remove unused variable `height'.
12071
12072 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12073
12074 * unexw32.c (get_section_info): Remove unused variable `section'.
12075
12076 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12077 (system_process_attributes): Remove unused variable `sess'.
12078 (sys_read): Remove unused variable `err'.
12079
12080 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12081 (w32_wnd_proc): Remove unused variable `isdead'.
12082 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12083 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12084 (x_create_tip_frame): Remove unused variable `tem'.
12085
12086 * w32inevt.c (w32_console_read_socket):
12087 Remove unused variable `no_events'.
12088
12089 * w32term.c (x_draw_composite_glyph_string_foreground):
12090 Remove unused variable `width'.
12091
1149507c
JB
120922011-03-24 Juanma Barranquero <lekktu@gmail.com>
12093
12094 * w32term.c (x_set_glyph_string_clipping):
12095 Don't pass uninitialized region to CombineRgn.
12096
9c88f339
JB
120972011-03-23 Juanma Barranquero <lekktu@gmail.com>
12098
12099 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12100 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12101 (Fx_close_connection): Remove unused variable `i'.
12102
12103 * w32font.c (w32font_draw): Return number of glyphs.
12104 (w32font_open_internal): Remove unused variable `i'.
12105 (w32font_driver): Add missing initializer.
12106
12107 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12108 (fill_in_menu): Remove unused variable `items_added'.
12109
12110 * w32term.c (last_mouse_press_frame): Remove static global variable.
12111 (w32_clip_to_row): Remove unused variable `f'.
12112 (x_delete_terminal): Remove unused variable `i'.
12113
12114 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12115 (NOTHING): Remove unused static global variable.
12116 (uniscribe_check_otf): Remove unused variable `table'.
12117 (uniscribe_font_driver): Add missing initializers.
12118
dee091a3
JD
121192011-03-23 Julien Danjou <julien@danjou.info>
12120
12121 * term.c (Fsuspend_tty, Fresume_tty):
12122 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12123 * window.c (temp_output_buffer_show):
12124 * insdel.c (signal_before_change):
12125 * frame.c (Fhandle_switch_frame):
12126 * fileio.c (Fdo_auto_save):
12127 * emacs.c (Fkill_emacs):
12128 * editfns.c (save_excursion_restore):
12129 * cmds.c (internal_self_insert):
12130 * callint.c (Fcall_interactively):
12131 * buffer.c (Fkill_all_local_variables):
12132 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12133 Use Frun_hooks.
0f4a96b5 12134 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12135 unconditionally since it does the check itself.
dee091a3 12136
2c520ab5 121372011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12138
c9c49752
PE
12139 Fix more problems found by GCC 4.5.2's static checks.
12140
8abc3f12
PE
12141 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12142 the first time through the loop, since we know p0 < p1 then.
12143 This also avoids a gcc -Wstrict-overflow warning.
12144
a2d26660
PE
12145 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12146 leading to a memory leak, possible in functions like
12147 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12148 of objects (Bug#8318).
a2d26660 12149
916c72e9
PE
12150 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12151 that could (at least in theory) be that large.
12152
19ab8a18
PE
12153 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12154 This is less likely to overflow, and avoids undefined behavior if
12155 overflow does occur. All callers changed. Use strtoul to scan
12156 for the unsigned long integer.
b7cbbd6f
PE
12157 (pint2hrstr): Simplify and tune code slightly.
12158 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12159
f0641eff
PE
12160 * scroll.c (do_scrolling): Work around GCC bug 48228.
12161 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12162
7f650bb9
PE
12163 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12164 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12165 (validate_x_resource_name): Simplify count usage.
12166 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12167
37dd57d1
PE
12168 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12169 fail (Bug#8306).
81e56e61 12170
699979fc 12171 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12172
401bf9b4
PE
12173 * process.c (Fmake_network_process): Use socklen_t, not int,
12174 where POSIX says socklen_t is required in portable programs.
12175 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12176 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12177 (Fmake_network_process, server_accept_connection):
12178 (wait_reading_process_output, read_process_output):
12179 Likewise.
12180
b93aacde
PE
12181 * process.c: Rename or move locals to avoid shadowing.
12182 (list_processes_1, Fmake_network_process):
12183 (read_process_output_error_handler, exec_sentinel_error_handler):
12184 Rename or move locals.
4dc343ee 12185 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12186 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12187 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12188 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12189 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12190
af8a867c 12191 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12192 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12193 Include tparam.h instead, since it declares them.
af8a867c
PE
12194 * cm.h (PC): Remove extern decl; tparam.h now does this.
12195 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12196 * terminfo.c: Include tparam.h, to check interfaces.
12197 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12198 (tparam): Adjust signature to match interface in tparam.h;
12199 this removes some undefined behavior. Check that outstring and len
12200 are zero, which they always are with Emacs.
12201 * tparam.h (PC, BC, UP): New extern decls.
12202
0248044d 12203 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12204 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12205
8ff096c1 12206 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12207 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12208 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12209 (ftfont_list): Remove unused local.
49eaafba
PE
12210 (get_adstyle_property, ftfont_pattern_entity):
12211 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12212 Rename locals to avoid shadowing.
8ff096c1 12213
e2be39f6
PE
12214 * xfont.c (xfont_list_family): Mark var as initialized.
12215
c9735e30
PE
12216 * xml.c (make_dom): Now static.
12217
8f5201ae
PE
12218 * composite.c (composition_compute_stop_pos): Rename local to
12219 avoid shadowing.
b246f932
PE
12220 (composition_reseat_it): Remove unused locals.
12221 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12222 (composition_update_it): Mark var as initialized.
11b61122
PE
12223 (find_automatic_composition): Mark vars as initialized,
12224 with a FIXME (Bug#8290).
8f5201ae 12225
760fbc2c
PE
12226 character.h: Rename locals to avoid shadowing.
12227 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12228 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12229 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12230 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12231 to avoid shadowing.
12232
ff08eb85
PE
12233 * textprop.c (property_change_between_p): Remove; unused.
12234
fc7bf025
PE
12235 * intervals.c (interval_start_pos): Now static.
12236
235d7abc
PE
12237 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12238
44f230aa
SM
12239 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12240 Rename locals to avoid shadowing.
3e7d6594 12241
50060332
PE
12242 * sound.c (wav_play, au_play, Fplay_sound_internal):
12243 Fix pointer signedness.
d01f234b 12244 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12245 (wav_play): Initialize a variable to 0, to prevent undefined
12246 behavior (Bug#8278).
50060332 12247
c4fc4e30
PE
12248 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12249
918436ed
PE
12250 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12251
c939f91b
PE
12252 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12253 clobbering (Bug#8298).
b9c7f648
PE
12254 * sysdep.c (sys_subshell): Likewise.
12255 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12256
6bd8c144
PE
12257 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12258 This should get cleaned up, so that child_setup has the
12259 same signature on all platforms.
12260
7710357c 12261 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12262 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12263
c59da222
CY
122642011-03-22 Chong Yidong <cyd@stupidchicken.com>
12265
12266 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12267 not to be necessary, and produces flickering.
12268
66b87493
GM
122692011-03-20 Glenn Morris <rgm@gnu.org>
12270
12271 * config.in: Remove file.
12272
45b6f6d5
JB
122732011-03-20 Juanma Barranquero <lekktu@gmail.com>
12274
12275 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12276 are now in src/globals.h.
12277 (syms_of_minibuf): Remove spurious & from previous change.
12278
cd394be1 122792011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12280
12281 * minibuf.c (completing-read-function): New variable.
12282 (completing-read-default): Rename from completing-read.
12283 (completing-read): Call completing-read-function.
12284
b14e3e21
CY
122852011-03-19 Juanma Barranquero <lekktu@gmail.com>
12286
12287 * xfaces.c (Fx_load_color_file):
12288 Read color file from absolute filename (bug#8250).
12289
f2b726e6
JB
122902011-03-19 Juanma Barranquero <lekktu@gmail.com>
12291
12292 * makefile.w32-in: Update dependencies.
12293
09f6ff02
EZ
122942011-03-17 Eli Zaretskii <eliz@gnu.org>
12295
12296 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12297
29a6015a
PE
122982011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12299
a3a6c54e
PE
12300 Fix more problems found by GCC 4.5.2's static checks.
12301
b766f867
PE
12302 * process.c (make_serial_process_unwind, send_process_trap):
12303 (sigchld_handler): Now static.
12304
be02381c
PE
12305 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12306 That way, the code declares only the vars that it needs.
12307 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12308 * s/cygwin.h (PTY_ITERATION): Likewise.
12309 * s/darwin.h (PTY_ITERATION): Likewise.
12310 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12311
57048744
PE
12312 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12313 * process.c (allocate_pty): Don't declare stb unless it's needed.
12314
7914961c 12315 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12316 (CONSTANTLIM): Remove; unused.
12317 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12318 Define only if needed.
7914961c 12319
b3967b18
PE
12320 * unexelf.c (unexec): Name an expression,
12321 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12322 Use a different way to cause a compilation error if anyone uses
12323 n rather than nn, a way that does not involve shadowing.
73366a00 12324 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12325
29a6015a
PE
12326 * deps.mk (unexalpha.o): Remove; unused.
12327
43cfc33e 12328 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12329 * unexec.h: New file.
ce701a33
PE
12330 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12331 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12332 Depend on unexec.h.
12333 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12334 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12335 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12336 Change as necessary to match prototype in unexec.h.
ce701a33 12337
01f44d5a
PE
12338 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12339 shadowing.
4f63c6bb 12340 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12341
a6670b0b
PE
12342 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12343 Rename locals to avoid shadowing.
12344
cef2010d 12345 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12346 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12347
d4d7173a
PE
12348 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12349
f08b802a
PE
12350 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12351 warning when compiling print.c.
12352
3ddb0639
PE
12353 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12354 instead of using an uninitialized var.
5ad03b97 12355 (font_sort_entities): Mark var as initialized.
3ddb0639 12356
170a2692
PE
12357 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12358
e663c700
PE
12359 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12360 pointers to constants.
89bc529a 12361 (font_parse_fcname): Remove unused vars.
7b81e2d0 12362 (font_delete_unmatched): Now static.
ea838e10 12363 (font_get_spec): Remove; unused.
13a547c6
PE
12364 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12365 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12366 Rename or move locals to avoid shadowing.
e663c700 12367
2a80c887 12368 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12369 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12370
1384fa33 12371 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12372 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12373
8b2c52e9
PE
12374 * alloc.c (mark_backtrace): Move decl from here ...
12375 * lisp.h: ... to here, so that it can be checked.
12376
475545b5 12377 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12378 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12379 (lisp_indirect_variable): Name an expression,
12380 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12381 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12382
b1349114 12383 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12384 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12385 Use const pointer when appropriate.
b1349114 12386
a2928364
PE
12387 * lisp.h (get_system_name, get_operating_system_release):
12388 Move decls here, to check interfaces.
12389 * process.c (get_operating_system_release): Move decl to lisp.h.
12390 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12391 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12392 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12393 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12394 (Fformat_time_string, Fencode_time, Finsert_char):
12395 (Ftranslate_region_internal, Fformat):
12396 Rename or remove local vars to avoid shadowing.
9710023e 12397 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12398
a415e694
PE
12399 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12400 avoid shadowing.
12401
8ef4622d
PE
12402 * lisp.h (eassert): Check that the argument compiles, even if
12403 ENABLE_CHECKING is not defined.
12404
946f9a5b
PE
12405 * data.c (Findirect_variable): Name an expression, to avoid
12406 gcc -Wbad-function-cast warning.
112396d6 12407 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12408 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12409 (Fmake_variable_buffer_local, Fmake_local_variable):
12410 Mark variables as initialized.
52746918 12411 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12412
e5aab7e7 12413 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12414 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12415 Rename locals to avoid shadowing.
dff45157
PE
12416 (mark_stack): Move local variables into the #ifdef region where
12417 they're used.
7bc26fdb
PE
12418 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12419 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12420 needed otherwise.
12421 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12422 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12423 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12424
e5aab7e7
PE
12425 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12426 avoids undefined behavior in theory.
12427
4da60324
PE
12428 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12429
88043301
PE
12430 Use functions, not macros, for up- and down-casing (Bug#8254).
12431 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12432 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12433 to use the following functions instead of these macros.
12434 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12435 EMACS_INT, since callers assume the returned value fits in int.
12436 (upcase1): Likewise, for UPCASE_TABLE.
12437 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12438 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12439 the race-condition problem in the old DOWNCASE.
88043301 12440
19ed5445
PE
12441 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12442 Rename locals to avoid shadowing.
12443 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12444 (regex_compile, re_search_2, re_match_2_internal):
12445 Remove unused local vars.
952db0d7
PE
12446 (FREE_VAR): Rewrite so as not to use empty "else",
12447 which gcc can warn about.
da053e48 12448 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12449 (RETALLOC_IF): Define only if needed.
12450 (WORDCHAR_P): Likewise. This one is never needed, but is used
12451 only in a comment talking about a compiler bug, so put inside
12452 the #if 0 of that comment.
12453 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12454 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12455 Remove; unused.
19ed5445 12456
1f3561e4 12457 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12458 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12459 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12460
ded6f8f7
PE
12461 * search.c (simple_search): Remove unused var.
12462
dbd37a95
PE
12463 * dired.c (compile_pattern): Move decl from here ...
12464 * lisp.h: ... to here, so that it can be checked.
12465 (struct re_registers): New forward decl.
12466
7e47afad
PE
12467 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12468
85f24f61
PE
12469 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12470 All uses changed.
12471 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12472 Rename locals to avoid shadowing.
5671df8f 12473 (Fvertical_motion): Mark locals as initialized.
85f24f61 12474
181aa2be 12475 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12476 (casify_region): Mark local as initialized.
181aa2be 12477
930d429c
PE
12478 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12479
7082eac6
PE
12480 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12481 New macros, so that the caller can use some names other than
12482 gcpro1, gcpro2, etc.
12483 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12484 of the new macros.
12485 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12486 argument, for consistency with GCPRO2_VAR, etc: it is now the
12487 prefix of the variable, not the variable itself. All uses
12488 changed.
38b2c076
PE
12489 * dired.c (directory_files_internal, file_name_completion):
12490 Rename locals to avoid shadowing.
12491
15206ed9
PE
12492 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12493 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12494 dired.c's scmp function, had undefined behavior.
12495 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12496 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12497 * buffer.h: ... to here, because these macros use current_buffer,
12498 and the new implementation with inline functions needs to have
12499 current_buffer in scope now, rather than later when the macros
12500 are used.
12501 (downcase, upcase1): New static inline functions.
12502 (DOWNCASE, UPCASE1): Reimplement using these functions.
12503 This avoids undefined behavior in expressions like
12504 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12505 from race conditions in accessing the global variables
12506 case_temp1 and case_temp2.
12507 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12508 * lisp.h (case_temp1, case_temp2): Remove their decls.
12509 * character.h (ASCII_CHAR_P): Move from here ...
12510 * lisp.h: ... to here, so that the inline functions mentioned
12511 above can use them.
12512
4a6bea26
PE
12513 * dired.c (directory_files_internal_unwind): Now static.
12514
f14b7e14
PE
12515 * fileio.c (file_name_as_directory, directory_file_name):
12516 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12517 Now static.
2893f146
PE
12518 (file_name_as_directory): Use const pointers when appropriate.
12519 (Fexpand_file_name): Likewise. In particular, newdir might
12520 point at constant storage, so make it a const pointer.
fd4ead52 12521 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12522 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12523 signedness issues.
f839df0c
PE
12524 (Fset_file_times, Finsert_file_contents, auto_save_error):
12525 Rename locals to avoid shadowing.
f14b7e14 12526
5716756e 12527 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12528 (Ftry_completion, Fall_completions): Rename or remove locals
12529 to avoid shadowing.
5716756e 12530
b4c3046a
PE
12531 * marker.c (bytepos_to_charpos): Remove; unused.
12532
b45db522
PE
12533 * lisp.h (verify_bytepos, count_markers): New decls,
12534 so that gcc does not warn that these functions aren't declared.
12535
85876d07
PE
12536 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12537 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12538 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12539 (copy_text): Remove unused local var.
85876d07 12540
03d78a21 12541 * filelock.c (within_one_second): Now static.
b3dd38ab 12542 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12543
5df8f01b
PE
12544 * buffer.c (fix_overlays_before): Mark locals as initialized.
12545 (fix_start_end_in_overlays): Likewise. This function should be
12546 simplified by using pointers-to-pointers, but that's a different
12547 matter.
b1d876f1 12548 (switch_to_buffer_1): Now static.
8f54f30a
PE
12549 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12550 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12551
a70072c9 12552 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12553 Fix pointer signedness issue.
edced198
PE
12554 (sys_subshell): Mark local as volatile if checking for lint,
12555 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12556 (MAXPATHLEN): Define only if needed.
a70072c9 12557
a0977c44
PE
12558 * process.c (serial_open, serial_configure): Move decls from here ...
12559 * systty.h: ... to here, so that they can be checked.
12560
a884fdcc
PE
12561 * fns.c (get_random, seed_random): Move extern decls from here ...
12562 * lisp.h: ... to here, so that they can be checked.
12563
604efe86 12564 * sysdep.c (reset_io): Now static.
b8950c94 12565 (wait_for_termination_signal): Remove; unused.
604efe86 12566
38fc62d9
PE
12567 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12568 (copy_keymap_item, append_key, push_text_char_description):
12569 Now static.
1004a21a 12570 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12571 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12572 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12573 (describe_map_tree):
12574 Rename locals to avoid shadowing.
38fc62d9 12575
2f2650da
PE
12576 * keyboard.c: Declare functions static if they are not used elsewhere.
12577 (echo_char, echo_dash, cmd_error, top_level_2):
12578 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12579 (read_char, kbd_buffer_get_event, make_lispy_position):
12580 (make_lispy_event, make_lispy_movement, apply_modifiers):
12581 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12582 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12583 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12584 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12585 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12586
a053e86c 12587 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12588 (mark_kboards): Move decl here ...
12589 * alloc.c (mark_kboards): ... from here.
a053e86c 12590
4752793e
PE
12591 * lisp.h (force_auto_save_soon): New decl.
12592
74f10ca7 12593 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12594 (DEFINE_DUMMY_FUNCTION): New macro.
12595 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12596 Use it.
c03cd23f
PE
12597 (main): Add casts to avoid warnings
12598 if GCC considers string literals to be constants.
74f10ca7 12599
022e70d4
PE
12600 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12601
59d6fe83
PE
12602 * dbusbind.c: Pointer signedness fixes.
12603 (xd_signature, xd_append_arg, xd_initialize):
12604 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12605 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12606 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12607 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12608
78320123
PE
12609 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12610 if GCC considers string literals to be constants.
49cebcca 12611 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12612
35ac2a97
SM
126132011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12614
fb103ca9
SM
12615 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12616 (print_preprocess, print_object): New macro to fix last change.
12617
35ac2a97
SM
12618 * print.c (print_preprocess): Don't forget font objects.
12619
62973b41
JB
126202011-03-16 Juanma Barranquero <lekktu@gmail.com>
12621
12622 * emacs.c (USAGE3): Doc fixes.
12623
0e48bb22
AS
126242011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12625
12626 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12627 structure.
12628
7684e57b
JB
126292011-03-14 Juanma Barranquero <lekktu@gmail.com>
12630
12631 * lisp.h (VWindow_system, Qfile_name_history):
12632 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12633 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12634 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12635
12636 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12637 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12638
12639 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12640 * w32console.c (detect_input_pending, read_input_pending)
12641 (encode_terminal_code):
12642 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12643 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12644 (w32_system_caret_y, Qfile_name_history):
12645 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12646 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12647 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12648 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12649 * w32proc.c (Qlocal, report_file_error):
12650 * w32term.c (Vwindow_system, updating_frame):
12651 * w32uniscribe.c (initialized, uniscribe_font_driver):
12652 Remove unneeded extern declarations.
12653
2aa46d6c
CY
126542011-03-14 Chong Yidong <cyd@stupidchicken.com>
12655
c96bbc66 12656 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12657
cffc6f3b
CY
126582011-03-13 Chong Yidong <cyd@stupidchicken.com>
12659
12660 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12661 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12662 These macros can no longer be used for assignment.
12663
44f230aa
SM
12664 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12665 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12666 (record_buffer_markers, fetch_buffer_markers): New functions for
12667 recording and fetching special buffer markers.
12668 (set_buffer_internal_1, set_buffer_temp): Use them.
12669
12670 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12671
12672 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12673
12674 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12675 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12676
12677 * xdisp.c (hscroll_window_tree):
12678 (reconsider_clip_changes): Use PT instead of BUF_PT.
12679
d251f04b
EZ
126802011-03-13 Eli Zaretskii <eliz@gnu.org>
12681
12682 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12683 $(EMACS_ROOT)/lib/intprops.h.
12684
f0c77cd1
PE
126852011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12686
3eca4629
PE
12687 Fix more problems found by GCC 4.5.2's static checks.
12688
7c86ee98
PE
12689 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12690 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12691 (xg_free_frame_widgets): Make it clear that a local variable is
12692 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12693 (gdk_window_get_screen): Make it clear that this macro is needed
12694 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12695 (int_gtk_range_get_value): New function, which avoids a diagnostic
12696 from gcc -Wbad-function-cast.
12697 (xg_set_toolkit_scroll_bar_thumb): Use it.
12698 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12699 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12700 (get_utf8_string, xg_get_file_with_chooser):
12701 Rename locals to avoid shadowing.
12702 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12703
41729b81
PE
12704 * xgselect.c (xg_select): Remove unused var.
12705
f0c77cd1
PE
12706 * image.c (four_corners_best): Mark locals as initialized.
12707 (gif_load): Initialize transparent_p to zero (Bug#8238).
12708 Mark another local as initialized.
ec6cf4c6 12709 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12710
ce0ad53d 12711 * image.c (clear_image_cache): Now static.
d5d5a617 12712 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12713 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12714 (x_edge_detection): Remove unnecessary cast that
12715 gcc -Wbad-function-cast diagnoses.
2037898d 12716 (gif_load): Fix pointer signedness.
6ae141d6
PE
12717 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12718 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12719
33383987 127202011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12721
d32df629
PE
12722 Improve quality of tests for time stamp overflow.
12723 For example, without this patch (encode-time 0 0 0 1 1
12724 1152921504606846976) returns the obviously-bogus value (-948597
12725 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12726 reports time overflow. See
12727 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12728 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12729 * editfns.c: Include limits.h and intprops.h.
12730 (TIME_T_MIN, TIME_T_MAX): New macros.
12731 (time_overflow): Move earlier, to before first use.
12732 (hi_time, lo_time): New functions, for an accurate test for
12733 out-of-range times.
12734 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12735 (Fget_internal_run_time): Don't assume time_t fits in int.
12736 (make_time): Use list2 instead of Fcons twice.
12737 (Fdecode_time): More accurate test for out-of-range times.
12738 (check_tm_member): New function.
12739 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12740 (lisp_time_argument): Don't rely on undefined left-shift and
12741 right-shift behavior when checking for time stamp overflow.
8be6f318 12742
fe31d94c
PE
12743 * editfns.c (time_overflow): New function, refactoring common code.
12744 (Fformat_time_string, Fdecode_time, Fencode_time):
12745 (Fcurrent_time_string): Use it.
12746
8be6f318
PE
12747 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12748 * dired.c (make_time): Move to ...
12749 * editfns.c (make_time): ... here.
12750 * systime.h: Note the move.
12751
09d9db2c 127522011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12753
126bc0dc
YM
12754 * fringe.c (update_window_fringes): Remove unused variables.
12755
c47cbdfd
YM
12756 * unexmacosx.c (copy_data_segment): Also copy __got section.
12757 (Bug#8223)
12758
7ac80be9
EZ
127592011-03-12 Eli Zaretskii <eliz@gnu.org>
12760
c96bbc66 12761 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12762 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12763 Constify `char *' arguments and their references according to
12764 prototypes in tparam.h.
12765
ecb0f94d 12766 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12767
7ac80be9
EZ
12768 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12769 Adapt all references accordingly.
12770
12771 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12772
ef1fd07e
TT
127732011-03-11 Tom Tromey <tromey@redhat.com>
12774
12775 * buffer.c (syms_of_buffer): Remove obsolete comment.
12776
7ef4b50c
EZ
127772011-03-11 Eli Zaretskii <eliz@gnu.org>
12778
12779 * termhooks.h (encode_terminal_code): Declare prototype.
12780
12781 * msdos.c (encode_terminal_code): Don't declare prototype.
12782
12783 * term.c (encode_terminal_code): Now external again, used by
12784 w32console.c and msdos.c.
12785
44f230aa
SM
12786 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12787 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12788
4b1ec863 127892011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12790
1714f52b 12791 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12792
4b1ec863
PE
12793 * fringe.c (update_window_fringes): Mark locals as initialized
12794 (Bug#8227).
12795 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12796
524c7aa6
PE
12797 * alloc.c (mark_fringe_data): Move decl from here ...
12798 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12799 to check its interface.
12800 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12801
a5c0af81 12802 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12803 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12804 (fontset_font): Mark local as initialized.
a9a06e0b 12805 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12806
b4716021
PE
12807 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12808
811e9bac 12809 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12810 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12811 (x_own_selection, Fx_disown_selection_internal): Rename locals
12812 to avoid shadowing.
12813 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12814
7e3ab302
PE
12815 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12816 so that the caller can use some name other than gcpro1.
12817 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12818 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12819 (Fx_backspace_delete_keys_p):
12820 Use them to avoid shadowing, and rename vars to avoid shadowing.
12821 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12822 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12823 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12824 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12825 Remove unused locals.
7e3ab302
PE
12826 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12827 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12828 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12829 macros.
f78faa98 12830
e2b13473
PE
12831 * xterm.h (x_mouse_leave): New decl.
12832
77f23912
PE
12833 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12834 Remove unused functions.
cdf4ba58
PE
12835 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12836 (x_calc_absolute_position): Now static.
7411c686 12837 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12838 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12839 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12840 unless they are used.
38d0b34a
PE
12841 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12842 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12843 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12844 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12845 (x_error_catcher, x_connection_closed, x_error_handler):
12846 (x_error_quitter, xembed_send_message, x_iconify_frame):
12847 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12848 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12849 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12850
44f230aa
SM
12851 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12852 Rename or move locals to avoid shadowing.
6b463e58 12853 (tty_defined_color, merge_face_heights): Now static.
5967d051 12854 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12855 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12856 does not deduce is never used uninitialized.
73719eba
PE
12857 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12858 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12859
426994c3 12860 * terminal.c (store_terminal_param): Now static.
5489860b 12861
032f1620 12862 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12863 (set_frame_menubar): Remove unused local.
d4323972 12864 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12865 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12866 since they might point to immutable storage.
281585b0
PE
12867 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12868 since it's unused otherwise.
032f1620 12869
367c19e5 12870 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12871 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12872 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12873 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12874 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12875 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12876 does not deduce are never used uninitialized.
70739cbe 12877
07b48fa9
PE
12878 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12879
8868a238 12880 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12881 * window.c (window_loop, size_window):
12882 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12883
7e5cf297 12884 * window.c (display_buffer): Now static.
d6550a9f
PE
12885 (size_window): Mark variables that gcc -Wuninitialized
12886 does not deduce are never used uninitialized.
a586633d
PE
12887 * window.h (check_all_windows): New decl, to forestall
12888 gcc -Wmissing-prototypes diagnostic.
5b555da1 12889 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12890
f6095868
PE
12891 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12892 shadowing.
12893 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12894 Include <limits.h>.
12895 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12896 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12897 (load_charset_map): Mark variables that gcc -Wuninitialized
12898 does not deduce are never used uninitialized.
53df7c11 12899 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12900
f38b440c
PE
12901 * coding.c (coding_set_source, coding_set_destination):
12902 Use "else { /* comment */ }" rather than "else /* comment */;"
12903 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12904 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12905 a block, when the outer 'i' will do.
12906 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12907 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12908 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12909 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12910 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12911 Rename locals to avoid shadowing.
12912 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12913 * coding.c (emacs_mule_char, encode_invocation_designation):
12914 Now static, since they're not used elsewhere.
413bb2db 12915 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12916 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12917 (decode_coding_emacs_mule): Mark variables that gcc
12918 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12919 (detect_coding_iso_2022): Initialize a local variable that might
12920 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12921 this initialization is needed. (Bug#8211)
5f58e762
PE
12922 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12923 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12924 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12925 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12926 Remove unused macros.
f38b440c 12927
232b38b9 12928 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12929 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12930 * character.c (string_count_byte8): Likewise.
232b38b9 12931
fb90da1b
PE
12932 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12933 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12934
fb93dbc2
PE
12935 * chartab.c (copy_sub_char_table): Now static, since it's not used
12936 elsewhere.
5c156ace
PE
12937 (sub_char_table_ref_and_range, char_table_ref_and_range):
12938 Rename locals to avoid shadowing.
bbcd0949 12939 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12940
7d3b3862 12941 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12942 (BIDI_BOB): Remove unused macro.
7d3b3862 12943
6be7d3da
PE
12944 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12945 deduce are never used uninitialized.
c2ed9c8b 12946 * term.c (encode_terminal_code): Likewise.
6be7d3da 12947
75f8807f 12948 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12949
50938595
PE
12950 * tparam.h: New file.
12951 * term.c, tparam.h: Include it.
12952 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12953 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12954 Move these decls to tparam.h, and make them agree with what
12955 is actually in tparam.c. The previous trick of using incompatible
12956 decls in different modules does not conform to the C standard.
12957 All callers of tparam changed to use tparam's actual API.
12958 * tparam.c (tparam1, tparam, tgoto):
12959 Use const pointers where appropriate.
12960
fbceeba2
PE
12961 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12962 * cm.h (struct cm): Likewise.
12963 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12964 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12965 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12966 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12967 (turn_on_face, init_tty): Likewise.
12968 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12969
7f3f1250
PE
12970 * term.c (term_mouse_position): Rename local to avoid shadowing.
12971
e6ca6543
PE
12972 * alloc.c (mark_ttys): Move decl from here ...
12973 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12974
c40f8d15
AS
129752011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12976
12977 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12978
cfe0661d
JB
129792011-03-09 Juanma Barranquero <lekktu@gmail.com>
12980
12981 * search.c (compile_pattern_1): Remove argument regp, unused since
12982 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12983 (compile_pattern): Don't pass it.
12984
0afb4571
J
129852011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12986
12987 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12988 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12989 for ! HAVE_GTK3.
12990 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12991
12992 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12993
12994 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12995 gdk_window_get_screen, gdk_window_get_geometry,
12996 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12997 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12998 (xg_get_pixbuf_from_pixmap): New function.
12999 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13000 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13001 Call xg_get_pixbuf_from_pixmap instead of
13002 gdk_pixbuf_get_from_drawable.
13003 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13004 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13005 (xg_check_special_colors): Use GtkStyleContext and its functions
13006 for HAVE_GTK3.
13007 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13008 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13009 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13010 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13011 Call gtk_widget_get_preferred_size.
0afb4571
J
13012 (xg_frame_resized): gdk_window_get_geometry only takes 5
13013 parameters.
44f230aa
SM
13014 (xg_win_to_widget, xg_event_is_for_menubar):
13015 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13016 (xg_set_widget_bg): New function.
13017 (delete_cb): New function.
895009e1 13018 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13019 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13020 (xg_set_background_color): Call xg_set_widget_bg.
13021 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13022 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13023 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13024 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13025 if ! HAVE_GTK3.
13026 (update_frame_tool_bar): Call gtk_widget_hide.
13027 (xg_initialize): Use GDK_KEY_g.
13028
13029 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13030 if ! HAVE_GTK3
13031 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13032
13033 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13034 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13035 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13036
1c2cc4ef
JB
130372011-03-08 Juanma Barranquero <lekktu@gmail.com>
13038
13039 * w32xfns.c (select_palette): Check success of RealizePalette against
13040 GDI_ERROR, not zero.
13041
33383987 13042See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13043
13044;; Local Variables:
13045;; coding: utf-8
aac0c6e3
MR
13046;; End:
13047
2f097256 13048 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13049
13050 This file is part of GNU Emacs.
13051
13052 GNU Emacs is free software: you can redistribute it and/or modify
13053 it under the terms of the GNU General Public License as published by
13054 the Free Software Foundation, either version 3 of the License, or
13055 (at your option) any later version.
13056
13057 GNU Emacs is distributed in the hope that it will be useful,
13058 but WITHOUT ANY WARRANTY; without even the implied warranty of
13059 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13060 GNU General Public License for more details.
13061
13062 You should have received a copy of the GNU General Public License
13063 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.