Move _longjmp, _setjmp from src/s to configure
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0a763bd1
GM
12012-07-30 Glenn Morris <rgm@gnu.org>
2
3 * s/usg5-4-common.h (_longjmp, _setjmp): Let configure set them.
4 * s/irix6-5.h (_longjmp, _setjmp): No more need to undefine.
5
169304bd
AS
62012-07-30 Andreas Schwab <schwab@linux-m68k.org>
7
8 * keymap.c (Fkey_description): Don't remove 0x80 bit from
9 non-single-byte char when adding meta modifier. (Bug#12090)
10
6cd7a139
DA
112012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
12
13 Convert safe_call to use variable number of arguments.
14 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
15 (safe_call2): Fix comment.
16 * lisp.h (safe_call): Adjust prototype.
17 * coding.c (encode_coding_object): Change to use safe_call2.
18 * xfaces.c (merge_face_heights): Change to use safe_call1.
19
d34d6ffc
GM
202012-07-30 Glenn Morris <rgm@gnu.org>
21
7b8a48e4 22 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 23 does that unconditionally. Remove file, which is now empty.
7b8a48e4 24
d34d6ffc
GM
25 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
26 Remove empty files.
27
03a660a6
PE
282012-07-30 Paul Eggert <eggert@cs.ucla.edu>
29
30 Export to GDB most of lisp.h's remaining object-like macros.
31 * lisp.h (min, max): Move earlier, because they're used earlier now.
32 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
33 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
34 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
35 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
36 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
37 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
38 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
39 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
40 Now constants, for GDB. They need not be macros.
41 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
42 Now constants, for GDB, as well as macros, for static initializers.
43 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
44 Move to after the definition of struct Lisp_Char_Table,
45 since the former now needs that type defined.
46 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
47 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
48 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
49 New enums, for gdb_make_enums_visible.
50 (GLYPH_MODE_LINE_FACE): Remove; unused.
51 * alloc.c (STRING_BYTES_MAX): Now a constant, now a macro.
52 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
53 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
54 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
55 enum maxargs, enum MAX_ALLOCA.
56 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
57 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
58 no longer needed, now that they are done in lisp.h.
59
e499d0ee
DA
602012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
61
62 Cleanup string bytes checking.
63 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
64 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
65 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
66 (check_sblock, compact_small_strings): Simplify.
67
d5040d2d
PE
682012-07-29 Paul Eggert <eggert@cs.ucla.edu>
69
70 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
71 These macros are confusing and no longer need to be defined, as
72 the enum values now suffice. All uses replaced with definiens.
73 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
74
7f259ae6
JB
752012-07-29 Juanma Barranquero <lekktu@gmail.com>
76
77 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
78 ($(BLD)/w32console.$(O)): Update dependencies.
79
7e63e0c3
DA
802012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
81
82 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
83 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
84 time. Adjust users.
85 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
86
ffd817eb
JD
872012-07-29 Jan Djärv <jan.h.d@swipnet.se>
88
89 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
90 setting sitelisp (Bug#12010).
91
417a7a0e
EZ
922012-07-29 Eli Zaretskii <eliz@gnu.org>
93
94 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
95
96 * w32heap.c (cache_system_info):
97 * w32.c (sys_rename):
98 * w32proc.c (find_child_console, sys_kill): All users changed.
99
387d4d92
PE
1002012-07-29 Paul Eggert <eggert@cs.ucla.edu>
101
102 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
103
55a6cca6
EZ
1042012-07-29 Eli Zaretskii <eliz@gnu.org>
105
106 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
107
dbcf001c
DA
1082012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
109
110 Cleanup statistics calculation in Fgarbage_collect.
111 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
112 zombies percentage calculation. Simplify elapsed time calculation.
113
e2688e4a
DA
1142012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
115
116 Generalize marker debugging code under MARKER_DEBUG and use eassert.
117 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
118 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
119 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
120 (replace_range, replace_range_2, del_range_2): Change to eassert.
121 * marker.c (byte_char_debug_check): Adjust style.
122
b46a6a83
PE
1232012-07-29 Paul Eggert <eggert@cs.ucla.edu>
124
125 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
126 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
127 long-ago-commented-out code that talks about "WIN32".
128 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
129 All uses changed.
130
e32a5799
PE
1312012-07-28 Paul Eggert <eggert@cs.ucla.edu>
132
133 Use Gnulib stdalign module (Bug#9772, Bug#9960).
134 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
135 Simplify by using alignof.
136 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
137 * lisp.h: Include <stdalign.h>.
138 (GCALIGNMENT): New macro and constant.
139 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
140 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
141 (stdalign): New macro, if not already defined.
142
df81cd29
EZ
1432012-07-28 Eli Zaretskii <eliz@gnu.org>
144
01bd1b0d
EZ
145 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
146 * w32inevt.c: Include w32inevt.h.
147 (w32_read_console_input): New inline function, calls either
148 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
149 w32_console_unicode_input.
150 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
151 (w32_kbd_patch_key, key_event): Use the codepage returned by
152 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
153 (key_event): use uChar.UnicodeChar only if
154 w32_console_unicode_input is non-zero.
155
156 * w32console.c: Include w32heap.h.
157 <w32_console_unicode_input>: New global variable.
158 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
159 family of Windows, zero otherwise.
160
161 * w32inevt.h: Declare w32_console_unicode_input.
162
df81cd29
EZ
163 * xdisp.c (init_iterator): Don't reference tip_frame in a build
164 --without-x. (Bug#11742)
165
c20fdd9e
PE
1662012-07-27 Paul Eggert <eggert@cs.ucla.edu>
167
168 Adjust GDB to reflect pvec_type changes (Bug#12036).
169 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
170 2012-07-04 changes to pseudovector representation. Problem
171 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
172
32770973 1732012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
174
175 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
176 bus address.
177 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
178
3438fe21
EZ
1792012-07-27 Eli Zaretskii <eliz@gnu.org>
180
bcfbc9de
EZ
181 * alloc.c (listn): Fix the order the arguments are consed onto the
182 list.
183
3438fe21
EZ
184 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
185 enumeration constants, as PURE and HEAP are too general, and clash
186 with other headers and sources, such as gmalloc.c and the
187 MS-Windows system headers. All users changed.
188
eeaea515
DA
1892012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
190
191 Revert last save_excursion_save and save_excursion_restore changes.
192 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
193 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
194
073c88c2
DA
1952012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
196
197 Fix recently-introduced typos in Windows port.
198 Reported by Martin Rudalics <rudalics@gmx.at>.
199 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 200 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 201
4706125e
PE
2022012-07-27 Paul Eggert <eggert@cs.ucla.edu>
203
204 Improve GDB symbol export (Bug#12036).
205 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
206 arms of an 'if', not using conditional expressions; otherwise GDB
207 complains about the types in the unevaluated arm when the argument
208 is an integer literal.
209 (xgetint): Simplify expression.
210 * alloc.c (gdb_make_enums_visible): New constant. This ports to
211 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
212 Zaretskii in <http://bugs.gnu.org/12036#13>.
213 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
214 needed now that we have gdb_make_enums_visible.
215 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
216 (enum enum_USE_LSB_TAG):
217 New enum types, packaging up enums that need to be exported to GDB.
218
694b6c97
DA
2192012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
220
221 Utility function to make a list from specified amount of objects.
222 * lisp.h (enum constype): New datatype.
223 (listn): New prototype.
224 * alloc.c (listn): New function.
225 (Fmemory_use_count, syms_of_alloc): Use it.
226 * buffer.c (syms_of_buffer): Likewise.
227 * callint.c (syms_of_callint): Likewise.
228 * charset.c (define_charset_internal): Likewise.
229 * coding.c (syms_of_coding): Likewise.
230 * keymap.c (syms_of_keymap): Likewise.
231 * search.c (syms_of_search): Likewise.
232 * syntax.c (syms_of_syntax): Likewise.
233 * w32.c (init_environment): Likewise.
234 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
235 * xdisp.c (syms_of_xdisp): Likewise.
236 * xfns.c (syms_of_xfns): Likewise.
237
6195f384
DA
2382012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
239
240 Fast save_excursion_save and save_excursion_restore.
241 * lisp.h (struct Lisp_Excursion): New data type.
242 (PVEC_EXCURSION): New pseudovector type.
243 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
244 to deal with it. Adjust comments.
245 (init_marker, attach_marker): New prototype.
246 (unchain_marker): Adjust prototype.
247 * marker.c (attach_marker): Change to global.
248 (init_marker): New function.
249 * alloc.c (Fmake_marker, build_marker): Use it.
250 (build_marker): More easserts.
251 (mark_object): Handle struct Lisp_Excursion.
252 * editfns.c (save_excursion_save, save_excursion_restore):
253 Reimplement to use struct Lisp_Excursion. Add comments.
254
5eceb8fb
PE
2552012-07-26 Paul Eggert <eggert@cs.ucla.edu>
256
257 Fix export of symbols to GDB (Bug#12036).
258 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
259 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
260 emacs.c, as this is a more-suitable home. Had this been done earlier
261 the fix for 12036 would have avoided some of the problems noted in
262 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
263 would have been more obvious.
562157c8
PE
264 * emacs.c: Do not include <verify.h>; no longer needed.
265 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
266 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
267 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
268 Remove; now done in lisp.h.
269 * lisp.h (PUBLISH_TO_GDB): New macro.
270 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
271 (DATA_SEG_BITS): Use it.
272 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
273 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
274 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
275 not be usable in #if. This simplifies things.
276
d6749401
JB
2772012-07-26 Juanma Barranquero <lekktu@gmail.com>
278
279 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
280
1781b9e9
PE
2812012-07-26 Paul Eggert <eggert@cs.ucla.edu>
282
d89518db 283 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
284 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
285 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
286 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
287 Adjust to changes in lisp.h and emacs.c, by using
288 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
289 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
290 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
291 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
292 instead of gdb_valbits.
293 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
294 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
295 instead of gdb_array_mark_flag.
296 (xboolvector): Get size from $->size, not $->header.size.
297 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
298 (xreload, hook-run, hookpost-run): Remove.
299 * emacs.c: Include <verify.h>.
300 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
301 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
302 Remove.
303 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
304 (gdb_USE_LSB_TAG): New enum constants.
305 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
306 Also define these as enum constants, so they're visible to GDB.
307 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
308 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
309 as constants, so they're visible to GDB.
310 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
311 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
312 Now enum constants, not macros, so they're visible to GDB.
313 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
314 more convenient now. All uses changed.
315 (VALMASK) [USE_LSB_TAG]: Also define in this case.
316 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
317
3628596a
DA
3182012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
319
320 Explicitly free restriction data that are not needed anymore.
321 * editfns.c (save_restriction_restore): Free restriction data.
322
7abaf5cc
SM
3232012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
324
325 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
326 add argument, tune behavior, and adjust all callers.
327
71f88e00
PE
3282012-07-25 Paul Eggert <eggert@cs.ucla.edu>
329
330 Use typedef for EMACS_INT, EMACS_UINT.
331 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
332 than macros. This simplifies debugging in the usual case, since
333 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
334 and it allows expressions involving EMACS_INT casts.
335 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
336
57ec3034
JD
3372012-07-25 Jan Djärv <jan.h.d@swipnet.se>
338
339 * nsterm.m (ns_read_socket): Return early if there is a modal
340 window (Bug#12043).
341
8137e7b3
MR
3422012-07-25 Martin Rudalics <rudalics@gmx.at>
343
344 * frame.c (Fredirect_frame_focus): In doc-string don't mention
345 that FOCUS-FRAME can be omitted.
346
04e9897c
DA
3472012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
348
349 Adjust buffer text indirection counters at the end of Fkill_buffer.
350 * buffer.c (Fkill_buffer): Adjust indirection counters when the
351 buffer is definitely dead. This should really fix an issue reported
352 by Christoph Scholtes again. (Bug#12007).
353 (init_buffer_once): Initialize indirection counters of
354 buffer_defaults and buffer_local_symbols (for sanity and safety).
355
8a0484e1
EZ
3562012-07-24 Eli Zaretskii <eliz@gnu.org>
357
358 * xdisp.c (init_iterator): Don't compute dimensions of truncation
359 and continuation glyphs on tooltip frames, leave them at zero.
360 Avoids continued lines in tooltips. (Bug#11832)
361
fa691a83
DA
3622012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
363
364 Simplify copy_overlay.
04e9897c 365 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
366 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
367
436bc8e0
EZ
3682012-07-23 Eli Zaretskii <eliz@gnu.org>
369
370 * print.c (print_object): Don't crash when a frame's name is nil
371 or invalid. (Bug#12025)
372
373 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
374 it signals an error when a tooltip frame is being created.
375
d7a7fda3
DA
3762012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
377
378 Cleanup miscellaneous objects allocation and initialization.
379 * alloc.c (allocate_misc): Change to static. Add argument to
380 specify the subtype. Adjust comment and users.
381 (build_overlay): New function.
382 * buffer.c (copy_overlays, Fmake_overlay): Use it.
383 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
384 (allocate_misc): Remove prototype.
385 (build_overlay): Add prototype.
386
3872012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
388
389 Swap buffer text indirection counters in Fbuffer_swap_text.
390 * buffer.c (Fbuffer_swap_text): Swap indirections too.
391 This avoids crash reported by Christoph Scholtes at
392 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
393
9d7fa573
JD
3942012-07-22 Jan Djärv <jan.h.d@swipnet.se>
395
396 * nsmenu.m (Popdown_data): New struct.
397 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
398 free Popdown_data.
399 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
400 (initWithContentRect): Make imgView and contentView non-static
401 and autorelease them. Also autorelease img and matrix (Bug#12005).
402 (dealloc): Remove (Bug#12005).
403
0dd6d66d
DA
4042012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
405
406 Adjust consing_since_gc when objects are explicitly freed.
407 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
408 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
409 (free_cons, free_misc): Subtract object size from consing_since_gc.
410
d36d71df
DA
4112012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
412
413 Simplify and cleanup markers positioning code.
414 * marker.c (attach_marker): More useful eassert.
415 (live_buffer, set_marker_internal): New function.
416 (Fset_marker, set_marker_restricted): Use set_marker_internal.
417 (set_marker_both, set_marker_restricted_both): Use live_buffer.
418
fb9ea40f
PE
4192012-07-22 Paul Eggert <eggert@cs.ucla.edu>
420
421 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
422 as it's limited by the amount of memory, not by INT_MAX.
423
2d5c5f7d
EZ
4242012-07-21 Eli Zaretskii <eliz@gnu.org>
425
07fb592e
EZ
426 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
427 in special-event-map. See the discussion at
428 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
429 for the reasons.
430
37a9eac8 431 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
432 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
433 Fabrice Popineau <fabrice.popineau@supelec.fr>.
434
c4328746
JD
4352012-07-21 Jan Djärv <jan.h.d@swipnet.se>
436
437 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 438 (conversationIdentifier): Return value is NSInteger.
784051c4 439 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 440
6e5d1c12
CY
4412012-07-21 Chong Yidong <cyd@gnu.org>
442
443 * window.c (decode_any_window): Signal an error if the window is
444 on a dead frame (Bug#11984).
445
9928463d
DA
4462012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
447
448 Add indirection counting to speed up Fkill_buffer.
449 * buffer.h (struct buffer): New member.
450 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
451 (Fmake_indirect_buffer): Set indirection counter to -1, increment
452 base buffer indirection counter.
453 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
454 (Fkill_buffer): Adjust indirection counters as needed, don't walk
455 through buffer list if indirection counter is 0.
456
f8643a6b
DA
4572012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
458
459 Extend the value returned by Fgarbage_collect with heap statistics.
460 * alloc.c (Qheap): New symbol.
461 (syms_of_alloc): DEFSYM it.
462 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
463 (Fmemory_free): Remove.
464 (syms_of_alloc): Don't defsubr it.
465 * buffer.c (Fcompact_buffer): Remove.
466 (syms_of_buffer): Don't defsubr it.
467
dac616ff
DA
4682012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
469
470 Make maybe_gc inline.
471 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
472 * lisp.h (consing_since_gc, gc_relative_threshold)
473 (memory_full_cons_threshold): Revert declaration.
474 (maybe_gc): Remove prototype, define as inline.
475 * alloc.c: Remove old commented-out code.
476 (consing_since_gc, gc_relative_threshold)
477 (memory_full_cons_threshold): Revert to global.
478 (maybe_gc): Remove.
479
d7ea76b4
DA
4802012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
481
482 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
483 * lisp.h (build_unibyte_string): New function.
484 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
485 * sysdep.c, w32fns.c, xfns.c: Use it.
486 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
487 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
488 Adjust users accordingly.
489 * font.h (font_open_by_name): Adjust prototype.
490
765e61e3
DA
4912012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
492
493 Cleanup calls to Fgarbage_collect.
494 * lisp.h (maybe_gc): New prototype.
495 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
496 Remove declarations.
497 * alloc.c (maybe_gc): New function.
498 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
499 Make them static.
500 * bytecode.c (MAYBE_GC): Use maybe_gc.
501 * eval.c (eval_sub, Ffuncall): Likewise.
502 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
503 to avoid dependency from auto-save feature.
504
52b852c7
PE
5052012-07-19 Paul Eggert <eggert@cs.ucla.edu>
506
507 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
508 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
509 'for_each_per_buffer_object_at'.
510 All uses changed. It's better to use upper-case for macros that
511 cannot be implemented as functions, to give the reader a clue
512 that they're special.
513
5db81e33
SM
5142012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
515
516 * alloc.c (Fgarbage_collect): Tweak docstring.
517
5b835e1d
DA
5182012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
519
520 Tweak the value returned from Fgarbage_collect again.
521 * alloc.c (Fgarbage_collect): New return value, as confirmed in
522 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
523 Adjust documentation.
524 (total_vector_bytes): Rename to total_vector_slots, adjust
525 accounting.
526 (total_free_vector_bytes): Rename to total_free_vector_slots,
527 adjust accounting.
528 (Qstring_bytes, Qvector_slots): New symbols.
529 (syms_of_alloc): DEFSYM them.
530
9cd47b72
DA
5312012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
532
533 Buffer compaction primitive which may be used from Lisp.
534 * buffer.c (compact_buffer, Fcompact_buffer): New function.
535 (syms_of_buffer): Register Fcompact_buffer.
536 * alloc.c (Fgarbage_collect): Use compact_buffer.
537 * buffer.h (compact_buffer): New prototype.
538 (struct buffer_text): New member.
539
d17337e5
DA
5402012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
541
542 New macro to iterate over all buffers, miscellaneous cleanups.
543 * lisp.h (all_buffers): Remove declaration.
544 * buffer.h (all_buffers): Add declaration, with comment.
545 (for_each_buffer): New macro.
546 * alloc.c (Fgarbage_collect, mark_object): Use it.
547 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
548 (init_buffer): Likewise.
549 * data.c (Fset_default): Likewise.
550 * coding.c (code_conversion_restore): Remove redundant check
551 for dead buffer.
552 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
553
60cfd278
AS
5542012-07-18 Andreas Schwab <schwab@linux-m68k.org>
555
556 Fix bug that created negative-length intervals.
557 * intervals.c (merge_interval_right, merge_interval_left):
558 Do not zero out this interval if it is absorbed by its children,
559 as this interval's total length doesn't change in that case. See
560 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
561
d06714cb
PE
5622012-07-18 Paul Eggert <eggert@cs.ucla.edu>
563
83713154
PE
564 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
565 when invoking (make-bool-vector N t) and N is a positive
566 multiple of 8 -- the last 8 bits were mistakenly cleared.
567
d06714cb
PE
568 Remove some struct layout assumptions in bool vectors.
569 * alloc.c (bool_header_size): New constant.
570 (header_size, word_size): Move earlier, as they're now used earlier.
571 Use 'word_size' in a few more places, where it's appropriate.
572 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
573 padding before the data member of a bool vector.
574 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
575 than doing the check by hand with an abort ().
576
464d5a5e
SM
5772012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
578
5fbc0409
SM
579 * eval.c (Fdefvar): Don't check constants since we only set the var if
580 it's not yet defined anyway (bug#11904).
581
464d5a5e
SM
582 * lisp.h (last_undo_boundary): Declare new var.
583 * keyboard.c (command_loop_1): Set it.
584 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
585 were auto-added by the command loop (bug#11774).
586
8dc2e44a
AS
5872012-07-18 Andreas Schwab <schwab@linux-m68k.org>
588
589 * w32font.c (Qsymbol): Remove local definition.
590 (syms_of_w32font): Don't DEFSYM it.
591
169925ec
DA
5922012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
593
594 Fix sweep_vectors to handle large bool vectors correctly.
595 * alloc.c (sweep_vectors): Account total_vector_bytes for
596 bool vectors larger than VBLOCK_BYTES_MAX.
597
5fbfb018
CY
5982012-07-18 Chong Yidong <cyd@gnu.org>
599
600 * frame.c (x_set_frame_parameters): Revert bogus change introduced
601 in 2012-05-25 commit by Paul Eggert (Bug#11738).
602
3ab6e069
DA
6032012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
604
605 Return more descriptive data from Fgarbage_collect.
606 Suggested by Stefan Monnier in
607 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
608 * alloc.c (bounded_number): New function.
609 (total_buffers, total_vectors): New variable.
610 (total_string_size): Rename to total_string_bytes, adjust users.
611 (total_vector_size): Rename to total_vector_bytes, adjust users.
612 (sweep_vectors): Account total_vectors and total_vector_bytes.
613 (Fgarbage_collect): New return value. Adjust documentation.
614 (gc_sweep): Account total_buffers.
615 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
616 (VECTOR_SIZE): Remove.
617 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
618 (Qinterval, Qmisc): New symbols.
619 (syms_of_data): Initialize them.
620 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
621 (Qcons, Qbuffer): New declarations.
622
6d02fe5b
PE
6232012-07-17 Paul Eggert <eggert@cs.ucla.edu>
624
625 * alloc.c (Fmemory_free): Account for memory-free's own storage.
626 Round up, not down. Improve doc.
627
b7ffe040
DA
6282012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
629
630 Restore old code in allocate_string_data to avoid Faset breakage.
631 Reported by Julien Danjou <julien@danjou.info> in
632 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
633 * alloc.c (allocate_string_data): Restore old code with minor
634 adjustments, fix comment to explain this subtle issue.
635
4dc7c8d5
SM
6362012-07-17 Eli Zaretskii <eliz@gnu.org>
637
638 Remove FILE_SYSTEM_CASE.
639 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
640
641 * fileio.c (FILE_SYSTEM_CASE): Don't define.
642 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
643 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
644 call-process-region passes it through expand-file-name.
645
646 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
647
6482012-07-17 Andreas Schwab <schwab@linux-m68k.org>
649
650 Fix crash when creating indirect buffer (Bug#11917)
651 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
652 Don't handle unbound variables specially if non-zero.
653 (Fbuffer_local_variables): Pass zero.
654 (clone_per_buffer_values): Pass non-zero.
655
6562012-07-17 Andreas Schwab <schwab@linux-m68k.org>
657
658 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
659 to make the loop interruptible.
660
6612012-07-17 Andreas Schwab <schwab@linux-m68k.org>
662
663 * gnutls.c (emacs_gnutls_handshake): Only retry if
664 GNUTLS_E_INTERRUPTED.
665
cce7fefc
DA
6662012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
667
668 Cleanup and convert miscellaneous checks to eassert.
669 * alloc.c (mark_interval): Fix comment, partially rephrase
670 old comment from intervals.h (see below).
671 * intervals.c (find_interval, adjust_intervals_for_insertion)
672 (delete_interval, adjust_intervals_for_deletion)
673 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
674 Convert to eassert.
675 (adjust_intervals_for_insertion, make_new_interval):
676 Remove obsolete and unused code.
677 * intervals.h (struct interval): Remove obsolete comment.
678 * textprotp.c (erase_properties): Remove unused code.
679 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
680 (Fremove_list_of_text_properties): Convert to eassert.
681
9ea10cc3
CY
6822012-07-17 Chong Yidong <cyd@gnu.org>
683
684 * editfns.c (Finsert_char): Doc fix.
685
3900d5de
DA
6862012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
687
688 Fix previous change to make Fmemory_free always accurate.
689 * alloc.c (make_interval): Update total_free_intervals.
690 (make_float): Likewise for total_free_floats.
691 (free_cons, Fcons): Likewise for total_free_conses.
692 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
693 Likewise for total_free_vector_bytes.
694 (Fmake_symbol): Likewise for total_free_symbols.
695 (bytes_free): Remove.
696
7098646f
DA
6972012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
698
699 Simple free memory accounting feature.
700 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
701 (sweep_vectors): Accumulate size of free vectors.
702 (Fgarbage_collect): Setup bytes_free.
703 (Fmemory_free): New function.
704 (syms_of_alloc): Register it.
705
22657b40
DA
7062012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
707
708 Cleanup overlays checking.
709 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
710 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
711 eassert and OVERLAYP.
712 (sort_overlays): Change to use OVERLAYP.
713
ddfc8813
RK
7142012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
715
716 * editfns.c (Finsert_char): Make it interactive, and make the
717 second arg optional. Copy interactive spec and docstring from
718 ucs-insert.
719
7c26cf3c
PE
7202012-07-17 Paul Eggert <eggert@cs.ucla.edu>
721
722 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
723 Unlike the other wrapped functions, fabs has an unspecified
724 effect on errno.
725
5d127af9
JD
7262012-07-16 Jan Djärv <jan.h.d@swipnet.se>
727
728 * nsterm.m (keyDown): Interpret flags without left/right bits
729 as the left key (Bug#11670).
730
6a0dd1d7
DA
7312012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
732
733 Remove empty and useless init functions.
734 * lisp.h (init_character_once, init_fns, init_image)
735 (init_filelock, init_sound): Remove prototype.
736 * character.c (init_character_once): Remove.
737 * filelock.c (init_filelock): Likewise.
738 * fns.c (init_fns): Likewise.
739 * image.c (init_image): Likewise.
740 * sound.c (init_sound): Likewise.
741 * emacs.c (main): Adjust accordingly.
742
7a6136fd
DA
7432012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
744
745 * gtkutil.h: Tiny cleanups.
746 (use_old_gtk_file_dialog): Remove useless declaration.
747 (xg_uses_old_file_dialog): Add suggested const attribute.
748
ce811ad9
EZ
7492012-07-15 Eli Zaretskii <eliz@gnu.org>
750
751 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
752 (bidi_paragraph_init): Use it to limit search forward for a strong
753 directional character in abnormally large paragraphs full of
754 neutral or weak characters. (Bug#11943)
755
c9adfeaa
SF
7562012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
757
758 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
759 the toolbar (Bug#9451).
760 (xg_make_tool_item): Give the widget event box a transparent
761 background.
762
fff62aa9
DA
7632012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
764
765 Cleanup basic allocation variables and functions.
766 * alloc.c (ignore_warnings, init_intervals, init_float)
767 (init_cons, init_symbol, init_marker): Remove.
768 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
769 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
770 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
771 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
772 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
773 (staticidx, init_alloc_once, init_strings, free_ablock):
774 Remove redundant initialization.
775 * fns.c (init_weak_hash_tables): Remove.
776 * lisp.h (init_weak_hash_tables): Remove prototype.
777
9730daca
DA
7782012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
779
780 Use zero_vector where appropriate.
781 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
782 accordingly.
783 * lisp.h (zero_vector): New declaration.
784 * font.c (null_vector): Remove.
785 (syms_of_font): Remove initialization and staticpro.
786 (font_list_entities, font_find_for_lface): Change to use zero_vector.
787 * keymap.c (Faccessible_keymaps): Likewise.
788
2e2d2a13
LL
7892012-07-15 Leo Liu <sdl.web@gmail.com>
790
791 * fringe.c: Fix typo in comments.
792
cd276f6e
LL
7932012-07-14 Leo Liu <sdl.web@gmail.com>
794
795 * fringe.c: Add a new bitmap exclamation-mark.
796
5a1131d9
EZ
7972012-07-14 Eli Zaretskii <eliz@gnu.org>
798
799 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
800
801 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
802 (HAVE_MENUS): Don't define, defined by editing config.in with
803 msdos/sed2v2.inp.
804 (GMALLOC_INHIBIT_VALLOC): Don't define.
805 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
806
22e983b7
JB
8072012-07-14 Juanma Barranquero <lekktu@gmail.com>
808
809 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
810
5b3f250f
GM
8112012-07-14 Glenn Morris <rgm@gnu.org>
812
813 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
814 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
815 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
816
33d63ff4
GM
8172012-07-13 Glenn Morris <rgm@gnu.org>
818
5b633342
GM
819 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
820
33d63ff4
GM
821 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
822 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
823
b55b9f85
JD
8242012-07-13 Jan Djärv <jan.h.d@swipnet.se>
825
0dc8cf50
JD
826 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
827 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
828 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
829 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
830 where appropriate.
831 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
832 as boolean expression.
833 (x_set_window_size): Remove unused variable toolbar.
834 (ns_get_color_default, ns_mod_to_lisp): Remove.
835 (ns_mouse_position): Remove unused variables xchar and ychar.
836 (ns_compute_glyph_string_overhangs): Remove unused variable face.
837 (ns_set_vertical_scroll_bar): Remove unused variable count.
838 (ns_delete_terminal): Remove unused variable i.
839 (ns_term_init): Remove unused variables r, g and b.
840 (mouseDown): Remove unused variable window.
841 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
842 (initFrameFromEmacs): Remove unused variable vbextra.
843 (mouseEntered): Remove unused variables p and dpyinfo.
844 (mouseExited): Remove unused variables p and r.
845 (ns_define_frame_cursor, ns_clear_frame_area)
846 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
847 (menuDown): Assign [sender tag] to variable and cast the variable.
848
849 * nsterm.h (menuDown): Add id as type to argument sender.
850 (ns_display_info_for_name): Add Lisp_Object argument.
851 (ns_term_init): Add Lisp_Object argument.
852 (ns_map_event_to_object): Add void argument.
853 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
854 prototype with arguments and only declare if __OBJC__.
855 (nxatoms_of_nsselect): Add void argument.
856 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
857 (ns_alloc_autorelease_pool): Add void argument.
858 (ns_release_autorelease_pool): Add void* argument.
859 (ns_get_defaults_value): Add const char* argument.
860
861 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
862 (initFromContents): Use SSDATA where appropriate.
863 (ns_update_menubar): Add braces to ambigous if-else.
864 (initWithTitle): Put () around assignment in if statement.
865 (ns_menu_show): Remove unused variables window and keymap.
866 (update_frame_tool_bar): Remove unused variable selected_p.
867 (initWithContentRect): Remove unused variable this_cmd_name.
868
869 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
870 appropriate.
871 (setXBMColor): Remove unused variable len.
872 (setPixmapData): Put () around assignment in loop statement.
873
874 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
875 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
876 where appropriate.
877 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
878 around assignment in loop statement.
879 (nsfont_open): Remove unused variable i.
880 (nsfont_open): Remove unused variable len.
881 (nsfont_draw): Remove unused variable cs.
882
883 * nsfns.m (x_set_icon_name, ns_set_name_internal)
884 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
885 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
886 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
887 (Fns_font_name, Fns_perform_service)
888 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
889 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
890 (ns_set_name): Remove unused variable view.
891 (x_set_menu_bar_lines): Remove unused variable olines.
892 (x_set_tool_bar_lines): Remove unused variable root_window.
893 (Fns_list_colors): Put () around assignment in while statement.
894 (Fns_perform_service): Remove unused variable len.
895 (Fns_display_usable_bounds): Remove unused variable top.
896 (syms_of_nsfns): Remove unused variable i.
897
b55b9f85
JD
898 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
899 memcpy (Bug#11907).
900
ed9265fc 9012012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
902
903 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
904 and free it with DestroyExceptionInfo (Bug#11558).
905
ef099b57
JB
9062012-07-13 Juanma Barranquero <lekktu@gmail.com>
907
908 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
909 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
910 Set here, not in nt/config.nt.
911
ea814a5d
EZ
9122012-07-13 Eli Zaretskii <eliz@gnu.org>
913
914 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
915 cursor overflow into the last glyph on display line when the right
916 fringe is off. (Bug#11832)
917
1a952767
PE
9182012-07-13 Paul Eggert <eggert@cs.ucla.edu>
919
920 * xdisp.c (produce_special_glyphs): Now static.
921 * dispextern.h (produce_special_glyphs): Remove decl.
922
983188fd
GM
9232012-07-13 Glenn Morris <rgm@gnu.org>
924
32fb4bb6
GM
925 * s/bsd-common, s/cygwin.h: Remove empty files.
926 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
927
983188fd
GM
928 * s/usg5-4-common.h (USG, USG5):
929 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
930 * s/sol2-6.h (SOLARIS2):
931 * s/irix6-5.h (IRIX6_5):
932 * s/hpux10-20.h (USG, USG5, HPUX):
933 * s/gnu-linux.h (USG, GNU_LINUX):
934 * s/freebsd.h (BSD_SYSTEM):
935 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
936 * s/cygwin.h (CYGWIN):
937 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
938 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
939
d1e68667 9402012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
941
942 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 943
6de0e799
GM
9442012-07-13 Glenn Morris <rgm@gnu.org>
945
739ae010
GM
946 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
947
dbee5793
GM
948 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
949
6de0e799
GM
950 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
951 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
952
b82da769
GM
9532012-07-12 Glenn Morris <rgm@gnu.org>
954
4fae5a7a 955 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
956
957 * process.c (init_process_emacs): Rename from init_process.
958 The old name is also the name of a Mach system call.
959 * lisp.h, emacs.c: Update for this name change.
960 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
961 longer needed.
962
5a979817
EZ
9632012-07-12 Eli Zaretskii <eliz@gnu.org>
964
965 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
966 memmove call that removes glyphs covered by the left truncation
967 glyph. Improve commentary.
968 (display_line): Fix display of continuation glyphs on GUI frames
969 when the right fringe is turned off and variable-size fonts are
970 used in the window. Move the code that appends a stretch glyph to
971 produce_special_glyphs, so that it could be used for truncation
972 and continuation glyphs alike.
973 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
974 glyph of a suitably computed width, to align the special glyphs at
975 the window margin. Code moved from display_line. (Bug#11832)
976
3e91a053
GM
9772012-07-12 Glenn Morris <rgm@gnu.org>
978
ba9e4b84
GM
979 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
980
981 * s/gnu-linux.h, s/hpux10-20.h:
982 Do not unconditionally define HAVE_XRMSETDATABASE.
983
3e91a053
GM
984 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
985
b300b1f4
PE
9862012-07-12 Paul Eggert <eggert@cs.ucla.edu>
987
988 Fix typos that broke OS X build.
989 Reported by Randal L. Schwartz in
990 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
991 * nsterm.m (ns_timeout): Add missing local decl.
992 (ns_get_color): snprintf -> sprintf, to fix typo.
993
6e777848
GM
9942012-07-12 Glenn Morris <rgm@gnu.org>
995
3f922c37
GM
996 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
997 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
998 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
999 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1000
0ab7b23a
GM
1001 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1002 Move PTY_OPEN to configure.
1003
6e777848
GM
1004 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1005 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1006 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1007
4a7edc24
DA
10082012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1009
1010 Use empty_unibyte_string where applicable.
1011 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1012 * lread.c (read1): Likewise.
1013 * xsettings.c (syms_of_xsettings): Likewise.
1014
308aab79
GM
10152012-07-12 Glenn Morris <rgm@gnu.org>
1016
42bd1719
GM
1017 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1018 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1019 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1020 * s/hpux10-20.h (RUN_TIME_REMAP):
1021 * s/bsd-common.h (TABDLY): Move to configure.
1022
1023 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1024
1025 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1026
ea0bbd17 1027 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1028 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1029
1030 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1031
308aab79
GM
1032 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1033 * s/template.h: Move NARROWPROTO to configure.
1034
ee1cf5cf
GM
10352012-07-11 Glenn Morris <rgm@gnu.org>
1036
30fe9bf4
GM
1037 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1038 unused since 2011-01-17 change to systty.h.
1039
ee1cf5cf
GM
1040 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1041 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1042 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1043
63e47e07
PE
10442012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1045
1046 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1047
c43fb4c3
GM
10482012-07-11 Glenn Morris <rgm@gnu.org>
1049
1050 * s/darwin.h, s/gnu-linux.h, s/template.h:
1051 Move INTERRUPT_INPUT to configure.
1052
e8df9267
DA
10532012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1054
1055 Minor adjustments to interning code.
1056 * lisp.h (intern, intern_c_string): Redefine as static inline
1057 wrappers for intern_1 and intern_c_string_1, respectively.
1058 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1059 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1060 Vobarray checking.
e8df9267
DA
1061 * font.c (font_intern_prop): Likewise. Adjust comment.
1062 * w32font.c (intern_font_name): Likewise.
1063
34348bd4
AS
10642012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1065
d96a1e0c
AS
1066 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1067
34348bd4
AS
1068 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1069 of Fcar/Fcdr if possible.
1070 * font.c (check_otf_features): Likewise.
1071 * fontset.c (Fnew_fontset): Likewise.
1072 * gnutls.c (Fgnutls_boot): Likewise.
1073 * minibuf.c (read_minibuf): Likewise.
1074 * msdos.c (IT_set_frame_parameters): Likewise.
1075 * xmenu.c (Fx_popup_dialog): Likewise.
1076 * w32menu.c (Fx_popup_dialog): Likewise.
1077
c8add24e
GM
10782012-07-11 Glenn Morris <rgm@gnu.org>
1079
4b575b3c
GM
1080 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1081 since nothing has defined it on these platforms.
1082
09f4e3b0
GM
1083 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1084 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1085
172bedef
GM
1086 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1087 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1088 Move CLASH_DETECTION to configure.
1089
249685df
GM
1090 * s/gnu.h: Remove file, which is now empty.
1091
c8add24e
GM
1092 * s/gnu.h, s/gnu-linux.h:
1093 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1094
b41253a3
JW
10952012-07-11 John Wiegley <johnw@newartisans.com>
1096
1097 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1098 function attribute, so we only use it if it exists in the
1099 compiler.
1100
d923b542
DA
11012012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1102
1103 Avoid call to strlen in fast_c_string_match_ignore_case.
1104 * search.c (fast_c_string_match_ignore_case): Change to use
1105 length argument. Adjust users accordingly.
1106 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1107
5ebbef1d
PE
11082012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1109
bb352260
PE
1110 Assume mkdir, rmdir.
1111 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1112 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1113
57054ddd
PE
1114 Assume rename.
1115 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1116
b747d3f7
PE
1117 Assume perror.
1118 * s/hpux10-20.h (HAVE_PERROR): Remove.
1119 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1120 Remove dummy definition, as this problem was obsolete long ago.
1121
5ebbef1d
PE
1122 Assume strerror.
1123 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1124
984e7f30
DA
11252012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1126
1127 Avoid calls to strlen in font processing functions.
1128 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1129 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1130 users accordingly.
d923b542
DA
1131 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1132 Adjust prototypes.
1133 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1134 Change to return ptrdiff_t.
984e7f30
DA
1135 (xfont_list_pattern, xfont_match): Use length returned by
1136 xfont_decode_coding_xlfd.
1137 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1138
20e94fdd
GM
11392012-07-11 Glenn Morris <rgm@gnu.org>
1140
9d596af3
GM
1141 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1142 Move DONT_REOPEN_PTY to configure.
1143
20e94fdd
GM
1144 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1145 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1146
e99a530f
PE
11472012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1148
22ffb973
PE
1149 Remove "#define unix" that is no longer needed (Bug#11905).
1150 * s/aix4-2.h (unix): Remove; no longer needed.
1151
e9a9ae03
PE
1152 EMACS_TIME simplification (Bug#11875).
1153 This replaces macros (which typically do not work in GDB)
1154 with functions, typedefs and enums, making the code easier to debug.
1155 The functional style also makes code easier to read and maintain.
1156 * systime.h: Include <sys/time.h> on all hosts, not just if
1157 WINDOWSNT, since 'struct timeval' is needed in general.
1158 (EMACS_TIME): Now a typedef, not a macro.
1159 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1160 not macros.
1161 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1162 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1163 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1164 (EMACS_TIME_LE): Now functions, not macros.
1165 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1166 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1167 which are not functions. All uses rewritten to use:
1168 (make_emacs_time): New function.
1169 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1170 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1171 not functions. All uses rewritten to use the following, respectively:
1172 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1173 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1174 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1175 * fileio.c (Fcopy_file):
1176 * xterm.c (XTflash): Get the current time closer to when it's used.
1177 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1178
ffacb126
PE
1179 * bytecode.c (targets): Suppress -Woverride-init warnings.
1180
e99a530f
PE
1181 Simplify by avoiding confusing use of strncpy etc.
1182 * doc.c (Fsnarf_documentation):
1183 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1184 * frame.c (Fmake_terminal_frame):
1185 * gtkutil.c (get_utf8_string):
1186 * lread.c (openp):
1187 * nsmenu.m (ns_update_menubar):
1188 * regex.c (regerror):
1189 Prefer memcpy to strncpy and strncat when either will do.
1190 * fileio.c (Fsubstitute_in_file_name):
1191 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1192 (menu_separator_name_p):
1193 * nsmenu.m (ns_update_menubar):
1194 Prefer memcmp to strncmp when either will do.
1195 * nsterm.m: Include <ftoastr.h>.
1196 (ns_get_color):
1197 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1198 Prefer snprintf to strncpy.
1199 * nsterm.m (ns_term_init):
1200 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1201 * nsterm.m (ns_term_init):
1202 Avoid the need for strncpy, by using build_string or
1203 make_unibyte_string directly. Use dtoastr, not snprintf.
1204 * process.c (Fmake_network_process): Diagnose service names that
1205 are too long, rather than silently truncating them or creating
1206 non-null-terminated names.
1207 (Fnetwork_interface_info): Likewise, for interface names.
1208 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1209 Prefer sprintf to strncat.
1210 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1211 Prefer vsnprintf to vsprintf + strncpy.
1212
c59592b3
GM
12132012-07-10 Glenn Morris <rgm@gnu.org>
1214
1215 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1216 Clarify fallback case.
1217
7d7bbefd
DA
12182012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1219
1220 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1221 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1222 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1223 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1224 where argument type is known to be a Lisp_Cons.
1225
3a4c8000
TT
12262012-07-10 Tom Tromey <tromey@redhat.com>
1227
1228 * bytecode.c (BYTE_CODE_THREADED): New macro.
1229 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1230 (enum byte_code_op): New type.
1231 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1232 (exec_byte_code): Use them. Use token threading when applicable.
1233
2a0213a6
DA
12342012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1235
1236 Optimize pure C strings initialization.
1237 * lisp.h (make_pure_string): Fix prototype.
1238 (build_pure_c_string): New function, defined as static inline. This
1239 provides a better opportunity to optimize away calls to strlen when
1240 the function is called with compile-time constant argument.
1241 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1242 argument, adjust users accordingly. Use build_pure_c_string where
1243 appropriate.
1244 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1245 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1246 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1247
cb1caeaf
DA
12482012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1249
1250 Avoid calls to strlen in miscellaneous functions.
1251 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1252 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1253 * lread.c (openp): Likewise.
1254
c293e30c
DA
12552012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1256
1257 Avoid calls to strlen in path processing functions.
1258 * fileio.c (file_name_as_directory): Add comment. Change to add
1259 srclen argument and return the length of result. Adjust users
1260 accordingly.
1261 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1262 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1263 users accordingly.
1264 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1265
9e059e3f
GM
12662012-07-10 Glenn Morris <rgm@gnu.org>
1267
d02eb359
GM
1268 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1269 Move PENDING_OUTPUT_COUNT definition to configure.
1270
882cf227
GM
1271 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1272 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1273 * s/gnu.h (DATA_START): Move definitions to configure.
1274
af6e839f
GM
1275 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1276 We include usg5-4-common.h, which defines them both.
1277
40289a12
GM
1278 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1279 O_RDONLY already includes it).
1280
9e059e3f
GM
1281 Stop ns builds setting the EMACSLOADPATH environment variable.
1282 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1283 Now it does not set EMACSLOADPATH, just returns the load-path string.
1284 * nsterm.h: Update accordingly.
1285 * lread.c [HAVE_NS]: Include nsterm.h.
1286 (init_lread) [HAVE_NS]: Use ns_load_path.
1287 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1288
7c4e8ec0
GM
12892012-07-09 Glenn Morris <rgm@gnu.org>
1290
d4f600ff
GM
1291 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1292 since the included bsd-common.h does so.
1293
cbb31951
GM
1294 Stop ns builds setting the EMACSPATH environment variable.
1295 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1296 (ns_init_paths): Do not set EMACSPATH.
1297 * nsterm.h (ns_exec_path): Add it.
1298 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1299 Use ns_exec_path.
1300
7c4e8ec0
GM
1301 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1302
26bccfae
PE
13032012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1304
a0bee46f
PE
1305 * process.c (wait_reading_process_output): 'waitchannels' was unset
1306 when read_kbd || !NILP (wait_for_cell); fix this.
1307
5994c183
PE
1308 Add GCC-style 'const' attribute to functions that can use it.
1309 * character.h (char_resolve_modifier_mask):
1310 * keyboard.h (make_ctrl_char):
1311 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1312 (init_character_once, next_almost_prime, init_fns, init_image)
1313 (flush_pending_output, init_sound):
1314 * mem-limits.h (start_of_data):
1315 * menu.h (finish_menu_items):
1316 Add ATTRIBUTE_CONST.
1317 * emacs.c (DEFINE_DUMMY_FUNCTION):
1318 Declare the dummy function with ATTRIBUTE_CONST.
1319 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1320 Add decls with ATTRIBUTE_CONST.
1321
26bccfae
PE
1322 Minor improvements to make_formatted_string.
1323 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1324 where int is good enough, as vsprintf returns an int.
1325 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1326
a8290ec3
DA
13272012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1328
1329 Use make_formatted_string to avoid double length calculation.
1330 * lisp.h (make_formatted_string): New prototype.
1331 * alloc.c (make_formatted_string): New function.
1332 * buffer.c (Fgenerate_new_buffer_name): Use it.
1333 * dbus.c (syms_of_dbusbind): Likewise.
1334 * editfns.c (Fcurrent_time_zone): Likewise.
1335 * filelock.c (get_boot_time): Likewise.
1336 * frame.c (make_terminal_frame, set_term_frame_name)
1337 (x_report_frame_params): Likewise.
1338 * image.c (gs_load): Likewise.
1339 * minibuf.c (get_minibuffer): Likewise.
1340 * msdos.c (dos_set_window_size): Likewise.
1341 * process.c (make_process): Likewise.
1342 * xdisp.c (ensure_echo_area_buffers): Likewise.
1343 * xsettings.c (apply_xft_settings): Likewise.
1344
d01ba2f1
GM
13452012-07-09 Glenn Morris <rgm@gnu.org>
1346
1347 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1348 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1349 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1350 * nsterm.h (ns_etc_directory): Add it.
1351 * callproc.c [HAVE_NS]: Include nsterm.h.
1352 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1353
f1f924b6
DA
13542012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1355
1356 Move marker debugging code under MARKER_DEBUG.
1357 * marker.c (MARKER_DEBUG): Move marker debugging code under
1358 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1359 for bootstrap with --enable-checking (~3x slowdown reported
1360 by Juanma Barranquero <lekktu@gmail.com>).
1361 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1362
ab531b66
PE
13632012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1364
1365 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1366 See <http://bugs.gnu.org/11825#29>.
1367
c4b3bc8a
EZ
13682012-07-08 Eli Zaretskii <eliz@gnu.org>
1369
1370 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1371 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1372 (display_line): Add commentary about displaying truncation glyphs
1373 on GUI frames.
1374 (produce_special_glyphs): Move here from term.c.
1375
1376 * term.c (produce_special_glyphs): Move to xdisp.c.
1377
1378 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1379 section.
c4b3bc8a 1380
b676b881
AS
13812012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1382
f17c5273
AS
1383 * xdisp.c (display_line): Avoid warning about implicit declaration
1384 of FRAME_FONT.
1385
298819b9
AS
1386 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1387
b676b881
AS
1388 * lisp.h: Remove empty conditional.
1389
6045c4fd
PE
13902012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1391
b3350bf9
PE
1392 * lread.c (load_path_check): Now static.
1393
6045c4fd
PE
1394 Fix some minor --with-ns problems found by static checking.
1395 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1396 (x_set_font) [!HAVE_X_WINDOWS]:
1397 * image.c (xpm_load_image) [HAVE_NS]:
1398 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1399 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1400 Remove unused local.
1401 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1402 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1403 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1404 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1405 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1406 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1407 Fix pointer signedness problem.
1408 * xfaces.c (FRAME_X_FONT_TABLE):
1409 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1410
929e7845
GM
14112012-07-07 Glenn Morris <rgm@gnu.org>
1412
1413 * lread.c (load_path_check): New function, split from init_lread.
1414 (init_lread): Reorganize. Motivation:
1415 If EMACSLOADPATH is set, check/warn about that rather than the
1416 defaults, which we are not going to use. Hence we can remove
1417 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1418 Don't warn if site-lisp directories are missing.
1419 If not installed, start from a blank load-path, since
1420 PATH_LOADSEARCH refers to the eventual installation directories.
1421
58dd0aa4
EZ
14222012-07-07 Eli Zaretskii <eliz@gnu.org>
1423
1424 Support truncation and continuation glyphs on GUI frames, when
1425 fringes are disabled. (Bug#11832)
1426 * xdisp.c (init_iterator): Get dimensions of truncation and
1427 continuation glyphs even if on GUI frames. Adjust
1428 it->last_visible_x on GUI frames when the left or right fringes,
1429 or both, are absent.
1430 (start_display, move_it_in_display_line_to): Handle the case of a
1431 GUI frame without a fringe to display continuation or truncation
1432 glyphs.
1433 (insert_left_trunc_glyphs): Support GUI frames: make sure
1434 truncation glyphs overwrite enough glyphs from the current line to
1435 have sufficient space in pixels.
1436 (display_line): Support truncation and continuation glyphs on GUI
1437 frames. If some spare pixels are left on the line after inserting
1438 the truncation glyphs, fill that space with a stretch glyph of a
1439 suitably computed width.
1440
1441 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1442 produce_glyphs, to support GUI sessions.
1443
31571fd7
PE
14442012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1445
5a16b9bc
PE
1446 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1447
f3047c75
PE
1448 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1449
31571fd7
PE
1450 Do not require float-time's arg to fit in time_t (Bug#11825).
1451 This works better on hosts where time_t is unsigned, and where
1452 float-time is applied to the (negative) difference between two times.
1453 * editfns.c (decode_time_components): Last arg is now double *,
1454 not int *, and means to store all the result as a double, without
1455 worrying about whether the seconds part fits in time_t.
1456 All callers changed.
1457 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1458 All callers changed.
1459 (Ffloat_time): Do not fail merely because the specified time falls
1460 outside of time_t range.
1461
4516fbef
GM
14622012-07-07 Glenn Morris <rgm@gnu.org>
1463
1464 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1465 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1466 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1467
07adc2c6
JB
14682012-07-07 Juanma Barranquero <lekktu@gmail.com>
1469
1470 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1471 Update dependencies.
1472
1473 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1474
fd573f31
PE
14752012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1476
fee5959d
PE
1477 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1478 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1479 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1480 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1481 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1482 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1483
fd573f31
PE
1484 * xfont.c (compare_font_names): Redo to omit the need for casts.
1485
ddadbc0e
AS
14862012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1487
fca8d6b6
AS
1488 * xfns.c (Fx_change_window_property): Doc fix.
1489 * w32fns.c (Fx_change_window_property): Doc fix.
1490
ddadbc0e
AS
1491 * w32fns.c (Fx_window_property): Accept the same arguments as the
1492 X Windows version. Doc fix.
1493 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1494
ed9265fc 14952012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1496 Eli Zaretskii <eliz@gnu.org>
1497
1498 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1499 Windows-specific code from nt/config.nt moved here.
1500 Obsolete settings removed.
1501
216ee680
PE
15022012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1503
1504 * process.c: Avoid unnecessary calls to gettime.
1505 (wait_reading_process_output): Don't get the time of day
1506 when gobbling data immediately and not waiting, as there's no need
1507 for it in that case. This removes a FIXME.
1508
bdd091e4
JD
15092012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1510
1511 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1512 is defined (Bug#11768).
1513
9d44f8ce
DA
15142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1515
1516 Fix marker debugging code.
1517 * marker.c (byte_char_debug_check): Do not perform the check
1518 if buffer is not multibyte.
090bd7cb
JB
1519 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1520 Call byte_char_debug_check with correct arguments.
9d44f8ce 1521
90fc4786
DA
15222012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1523
1524 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1525 * marker.c (byte_char_debug_check, count_markers):
1526 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1527 (byte_debug_flag): Remove.
1528 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1529 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1530
7b7ae965
DA
15312012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1532
4e57b342
DA
1533 Avoid code repetition in marker-related functions.
1534 * marker.c (attach_marker): New function.
1535 (Fset_marker, set_marker_restricted, set_marker_both)
1536 (set_marker_restricted_both): Use it.
1537 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1538 Consistently rename charno to charpos.
1539 (marker_position): Add eassert.
1540 (marker_byte_position): Convert to eassert.
1541
15422012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1543
1544 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1545 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1546 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1547
657924ff
DA
15482012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1549
1550 Introduce fast path for the widely used marker operation.
1551 * alloc.c (build_marker): New function.
1552 * lisp.h (build_marker): New prototype.
1553 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1554 * composite.c (autocmp_chars): Likewise.
1555 * editfns.c (buildmark): Remove.
1556 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1557 (save_restriction_save): Use build_marker.
1558 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1559 * window.c (save_window_save): Likewise.
1560
041a49a6
DA
15612012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1562
1563 Do not use Fdelete_overlay in delete_all_overlays
1564 to avoid redundant calls to unchain_overlay.
1565 * buffer.c (drop_overlay): New function.
1566 (delete_all_overlays, Fdelete_overlay): Use it.
1567 * minibuf.c (get_minibuffer): Fix comment.
1568
7dca65a4
PE
15692012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1570
1571 Port to OpenBSD 5.1 amd64.
1572 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1573 This is needed for OpenBSD, and should be harmless on all BSD systems.
1574 Also, include <sys/sysctl.h>, as it should be available on all
1575 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1576 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1577 use p_pid member, not kp_proc.pid.
1578
8eb876e2
GM
15792012-07-06 Glenn Morris <rgm@gnu.org>
1580
1581 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1582
38182d90
PE
15832012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1584
1585 More xmalloc and related cleanup.
1586 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1587 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1588 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1589 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1590 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1591 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1592 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1593 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1594 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1595 * xterm.c:
1596 Omit needless casts involving void * pointers and allocation.
1597 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1598 as the former is more robust if P's type is changed.
1599 Prefer xzalloc to xmalloc + memset 0.
1600 Simplify malloc-or-realloc to realloc.
1601 Don't worry about xmalloc returning a null pointer.
1602 Prefer xstrdup to xmalloc + strcpy.
1603 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1604 growing it.
1605 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1606 alloca of a constant.
1607
6dd5a677
EZ
16082012-07-05 Eli Zaretskii <eliz@gnu.org>
1609
1610 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1611 hscroll is larger than the line width. Fixes long and futile
1612 looping inside extend_face_to_end_of_line (on a TTY) producing
1613 glyphs that are not needed and thrown away.
1614
6b312f0f
DA
16152012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1616
1617 * marker.c (set_marker_restricted_both): Simplify by using
1618 clip_to_bounds.
1619
f520ef9b
PE
16202012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1621
1622 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1623
383b7c95
JD
16242012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1625
1626 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1627 not defined (Bug#11768).
1628 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1629 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1630 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1631 followed by gtk_box_set_homogeneous (Bug#11768).
1632 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1633 (update_theme_scrollbar_width, xg_create_scroll_bar):
1634 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1635 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1636 (is_box_type): New function (Bug#11768).
1637 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1638 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1639 with default display (Bug#11768).
1640
d6e7bf45
EZ
16412012-07-05 Eli Zaretskii <eliz@gnu.org>
1642
1643 * xdisp.c (window_hscroll_limited): New function.
1644 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1645 coordinates when window's hscroll is set to insanely large
1646 values. (Bug#11857)
1647
431391ec
JB
16482012-07-05 Juanma Barranquero <lekktu@gmail.com>
1649
1650 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1651 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1652
23f86fce
DA
16532012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1654
1655 Cleanup xmalloc.
1656 * lisp.h (xzalloc): New prototype. Omit needless casts.
1657 * alloc.c (xzalloc): New function. Omit needless casts.
1658 * charset.c: Omit needless casts. Convert all calls to
1659 xmalloc with following memset to xzalloc.
1660 * dispnew.c: Likewise.
1661 * fringe.c: Likewise.
1662 * image.c: Likewise.
1663 * sound.c: Likewise.
1664 * term.c: Likewise.
1665 * w32fns.c: Likewise.
1666 * w32font.c: Likewise.
1667 * w32term.c: Likewise.
1668 * xfaces.c: Likewise.
1669 * xfns.c: Likewise.
1670 * xterm.c: Likewise.
1671 * atimer.c: Omit needless casts.
1672 * buffer.c: Likewise.
1673 * callproc.c: Likewise.
1674 * ccl.c: Likewise.
1675 * coding.c: Likewise.
1676 * composite.c: Likewise.
1677 * doc.c: Likewise.
1678 * doprnt.c: Likewise.
1679 * editfns.c: Likewise.
1680 * emacs.c: Likewise.
1681 * eval.c: Likewise.
1682 * filelock.c: Likewise.
1683 * fns.c: Likewise.
1684 * gtkutil.c: Likewise.
1685 * keyboard.c: Likewise.
1686 * lisp.h: Likewise.
1687 * lread.c: Likewise.
1688 * minibuf.c: Likewise.
1689 * msdos.c: Likewise.
1690 * print.c: Likewise.
1691 * process.c: Likewise.
1692 * region-cache.c: Likewise.
1693 * search.c: Likewise.
1694 * sysdep.c: Likewise.
1695 * termcap.c: Likewise.
1696 * terminal.c: Likewise.
1697 * tparam.c: Likewise.
1698 * w16select.c: Likewise.
1699 * w32.c: Likewise.
1700 * w32reg.c: Likewise.
1701 * w32select.c: Likewise.
1702 * w32uniscribe.c: Likewise.
1703 * widget.c: Likewise.
1704 * xdisp.c: Likewise.
1705 * xmenu.c: Likewise.
1706 * xrdb.c: Likewise.
1707 * xselect.c: Likewise.
1708
0497dc44
PE
17092012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1710
1711 * fileio.c (time_error_value): Check the right error number.
1712 Problem reported by Troels Nielsen in
1713 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1714
356e7178
PE
17152012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1716
4e71fd89
PE
1717 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1718 This should be fixed in a better way; see Eli Zaretskii in
1719 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1720 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1721
f0941253
PE
1722 * fileio.c (time_error_value): Rename from special_mtime.
1723 The old name's problems were noted by Eli Zaretskii in
1724 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1725
065c9eb4
PE
1726 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1727 This variable's comment says Emacs needs at least one GDB-visible
1728 symbol of type enum pvec_type, to work around GDB problems.
1729 The symbol's value doesn't matter.
1730
356e7178
PE
1731 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1732 that causes compilation to fail on pre-C99 compilers.
1733
ed9265fc 17342012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1735
1736 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1737 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1738
3884d954
DA
17392012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1740
d209e2fb 1741 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1742 headers for buffer_defaults and buffer_local_symbols.
1743 Reported by Juanma Barranquero <lekktu@gmail.com>.
1744
ee28be33
SM
17452012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1746
1747 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1748 * lisp.h (enum pvec_type): Use fewer bits.
1749 (PSEUDOVECTOR_SIZE_BITS): New constant.
1750 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1751 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1752 change in pvec_type.
1753 (PSEUDOVECTOR_TYPEP): New macro.
1754 (TYPED_PSEUDOVECTORP): Use it.
1755 * fns.c (internal_equal): Adapt code to extract pvectype.
1756 * emacs.c (gdb_pvec_type): Update type.
1757 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1758 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1759 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1760 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1761 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1762 abusing vector->header.next.nbytes.
1763 (live_vector_p): Use PVEC_TYPE.
1764 (mark_object): Adapt code to extract pvectype. Use switch.
1765
c7f2cd7f
PE
17662012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1767
1768 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1769 Tighten new eassert a bit.
1770
8ce70ed2
DA
17712012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1772
1773 Fix compilation with --enable-gcc-warnings and -O1
1774 optimization level.
1775 * doprnt.c (doprnt): Change type of tem to int, initialize
1776 to avoid compiler warning. Add eassert.
1777 * search.c (simple_search): Initialize match_byte to avoid
1778 compiler warning. Add eassert.
1779
dea7f1e5
PE
17802012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1781
24a212eb
PE
1782 Avoid weird behavior with large horizontal scrolls.
1783 Without this change, for example, large hscroll values would
1784 mess up Emacs's display on Fedora 15 x86, presumably due to
1785 overflows in int calculations in the display code.
1786 Also, if buffers had long lines, Emacs would freeze.
1787 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1788 (set_window_hscroll): New function, containing the old guts of
1789 Fset_window_hscroll. Return the clipped value.
1790 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1791 This avoids the need to check against PTRDIFF_MAX.
1792
dea7f1e5
PE
1793 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1794
76046526
DA
17952012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1796
1797 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1798
39adff0d
PE
17992012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1800
63807d47
PE
1801 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1802 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1803 since GCC 4.4.6 issues a bogus warning for them.
1804
39adff0d
PE
1805 Fix bugs in file timestamp newness comparisons.
1806 * fileio.c (Ffile_newer_than_file_p):
1807 * lread.c (Fload): Use full timestamp resolution of files,
1808 not just the 1-second resolution, so that files that are only
1809 slightly newer still count as newer.
1810 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1811 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1812
dbeed9a6
PE
18132012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1814
1815 * fileio.c: Improve handling of file time marker. (Bug#11852)
1816 (special_mtime): New function.
1817 (Finsert_file_contents, Fverify_visited_file_modtime):
1818 Use it to set special mtime values consistently.
1819
636334d6
AS
18202012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1821
1822 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1823 marker for non-existing file. (Bug#11852)
1824
e2017fe2
GM
18252012-07-03 Glenn Morris <rgm@gnu.org>
1826
1827 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1828 and did not make it into globals.h).
1829
404dbd37
TT
18302012-07-03 Tom Tromey <tromey@redhat.com>
1831
1832 * window.c (Fset_window_margins, Fset_window_fringes)
1833 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1834 * textprop.c (Fprevious_property_change): No longer static.
1835 * syntax.c (Fsyntax_table_p): No longer static.
1836 * process.c (Fget_process, Fprocess_datagram_address): No longer
1837 static.
1838 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1839 * keyboard.c (Fcommand_execute): No longer static.
1840 Remove EXFUN.
1841 * insdel.c (Fcombine_after_change_execute): No longer static.
1842 * image.c (Finit_image_library): No longer static.
1843 * fileio.c (Fmake_symbolic_link): No longer static.
1844 * eval.c (Ffetch_bytecode): No longer static.
1845 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1846 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1847 No longer static.
404dbd37
TT
1848 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1849 static.
1850 * dired.c (Ffile_attributes): No longer static.
1851 * composite.c (Fcomposition_get_gstring): No longer static.
1852 * callproc.c (Fgetenv_internal): No longer static.
1853
1854 * ccl.h: Remove EXFUNs.
1855 * buffer.h: Remove EXFUNs.
1856 * dispextern.h: Remove EXFUNs.
1857 * intervals.h: Remove EXFUNs.
1858 * fontset.h: Remove EXFUN.
1859 * font.h: Remove EXFUNs.
1860 * dosfns.c (system_process_attributes): Remove EXFUN.
1861 * keymap.h: Remove EXFUNs.
1862 * lisp.h: Remove EXFUNs.
1863 * w32term.h: Remove EXFUNs.
1864 * window.h: Remove EXFUNs.
1865 * xsettings.h: Remove EXFUN.
1866 * xterm.h: Remove EXFUN.
1867
8e4fd1e1
GM
18682012-07-03 Glenn Morris <rgm@gnu.org>
1869
1870 * lisp.h (Frandom): Make it visible to C.
1871 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1872 buffer for invisible buffers. (Bug#1229)
1873
ca95b3eb
DA
18742012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1875
1876 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1877 values which aren't power of 2.
1878 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1879 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1880 accordingly.
1881
7555c33f
SM
18822012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1883
1884 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1885
1886 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1887
d12e8f5a
DA
18882012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1889
1890 * alloc.c (allocate_vector_block): Remove redundant
1891 calls to mallopt if DOUG_LEA_MALLOC is defined.
1892 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1893 avoid calls to mallopt if zero_vector is returned.
1894
296094c3
DA
18952012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1896
1897 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1898 is enabled, avoid dereferencing NULL current_sblock if
1899 running undumped.
1900
36429c89
DA
19012012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1902
1903 Cleanup basic buffer management.
1904 * buffer.h (struct buffer): Change layout to use generic vector
1905 marking code. Fix some comments. Change type of 'clip_changed'
1906 to bitfield. Remove unused #ifndef old.
1907 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1908 (GET_OVERLAYS_AT): Fix indentation.
1909 (for_each_per_buffer_object_at): New macro.
1910 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1911 (Fbuffer_local_variables): Use it.
1912 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1913 * alloc.c (allocate_buffer): Adjust to match new layout of
1914 struct buffer. Fix comment.
1915 (mark_overlay): New function.
1916 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1917 Lisp area of struct buffer.
1918 (mark_object): Use it. Adjust marking of misc objects
1919 and related comments.
1920
3b3e4cac
PE
19212012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1922
1923 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1924 wrapper that is not needed because the wrapped code is a no-op (zero
1925 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1926 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1927
cf5c0175
DA
19282012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1929
1930 * alloc.c (mark_buffer): Simplify. Remove prototype.
1931 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1932 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1933 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1934 redundant calls to mark_vectorlike for bool vectors.
1935
ca26824c
GM
19362012-06-30 Glenn Morris <rgm@gnu.org>
1937
2e4c5312
GM
1938 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1939
ca26824c
GM
1940 * epaths.in (PATH_SITELOADSEARCH): New.
1941 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1942 This is rather than relying on --enable-locallisppath elements
1943 having "site-lisp" in their names. (Bug#10208#25, 11658)
1944
0d23c240
EZ
19452012-06-30 Eli Zaretskii <eliz@gnu.org>
1946
c9240d7a
EZ
1947 * w32proc.c (sys_select): Accept and ignore one more argument.
1948
1949 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1950
0d23c240 1951 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1952 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1953
1954 * sysdep.c: Don't include dos.h and dosfns.h.
1955
1956 * process.c (sys_select):
1957 * msdos.c (sys_select): Accept one more argument and ignore it.
1958
1959 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1960 adapt data types and code to that.
1961
1962 * dosfns.c:
1963 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1964 which clashes with the gnulib function of the same name.
1965
af5a5a98
AS
19662012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1967
c5e4379c
AS
1968 * font.c (font_style_to_value, font_style_symbolic)
1969 (font_prop_validate_style): Add type checks for values in
1970 font_style_table.
1971
af5a5a98
AS
1972 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1973 argument.
1974 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1975 uses.
1976
8d38f461
EZ
19772012-06-29 Eli Zaretskii <eliz@gnu.org>
1978
2e5a6631
EZ
1979 * xdisp.c (try_window_id): Undo last change.
1980
8d38f461
EZ
1981 * w32.c (getwd): Adjust commentary about startup_dir.
1982 (init_environment): Always call sys_access, even in non-MSVC
1983 builds. Don't chdir to the directory of the Emacs executable.
1984 This undoes code from 1997 which was justified by the need to
1985 "avoid conflicts when removing and renaming directories". But its
1986 downside was that every relative file name was being interpreted
1987 relative to the directory of the Emacs executable, which can never
1988 be TRT. In particular, it broke sys_access when called with
1989 relative file names.
1990 (sys_access): Map GetLastError to errno.
1991
2af3565e
DA
19922012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1993
1994 * window.h (struct window): Change type of 'fringes_outside_margins'
1995 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1996 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1997 Adjust comment.
1998 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1999 to ptrdiff_t.
2000
c8d3a25c 20012012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2002
c8d3a25c
GM
2003 * gnutls.c (emacs_gnutls_handshake):
2004 Add QUIT to make the loop interruptible.
57570cd3 2005
c8d3a25c 20062012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2007
c8d3a25c
GM
2008 * charset.c (init_charset): Make lack of etc/charsets fatal.
2009
3e984ee8
DA
20102012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2011
2012 * editfns.c (region_limit): Fix type mismatch.
2013
ef884f23
DA
20142012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2015
2016 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2017 undefined. Convert from xassert to eassert.
2018 * nsmenu.m: Convert from xassert to eassert.
2019 * nsterm.m: Likewise.
2020
7d7e0027
SM
20212012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2022
2023 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2024
aa754e6a
PE
20252012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2026
2027 Avoid integer overflow on scroll-left and scroll-right.
2028 * window.c (HSCROLL_MAX): New macro.
2029 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2030 overflow when requested scroll falls outside ptrdiff_t range.
2031
80b00b08
DA
20322012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2033
2034 * window.h (struct window): Change type of 'hscroll',
2035 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2036 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2037 Adjust users accordingly.
2038 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2039 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2040 from EMACS_INT to ptrdiff_t.
2041 (make_window): Omit redundant initialization.
2042
62b2bcf6
JB
20432012-06-28 Juanma Barranquero <lekktu@gmail.com>
2044
2045 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2046
45942c7d
DA
20472012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2048
2049 * window.h (struct window): Change type of 'use_time' and
2050 'sequence_number' from Lisp_Object to int.
2051 * frame.c (make_frame): Adjust users accordingly.
2052 * print.c (print_object): Likewise.
2053 * window.c (select_window, Fwindow_use_time, make_parent_window)
2054 (make_window): Likewise.
2055
e509cfa6
DA
20562012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2057
2058 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2059 enabled with --enable-checking=[all,glyphs] configure option.
2060 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2061 adjust comments accordingly.
2062 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2063 undefined, adjust comments accordingly.
2064 * image.c: Likewise.
2065 * scroll.c: Likewise.
2066 * w32fns.c: Likewise.
2067 * w32term.c: Likewise.
2068 * xdisp.c: Likewise.
2069 * xfaces.c: Likewise.
2070 * xfns.c: Likewise.
2071 * xterm.c: Likewise.
2072
a54e2c05
DA
20732012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2074
2075 Generalize run-time debugging checks.
2076 * dispextern.h (XASSERTS): Remove.
2077 * fontset.c (xassert): Remove.
2078 Convert from xassert to eassert.
2079 * alloc.c: Convert from xassert to eassert.
2080 * bidi.c: Likewise.
2081 * dispnew.c: Likewise.
2082 * fns.c: Likewise.
2083 * fringe.c: Likewise.
2084 * ftfont.c: Likewise.
2085 * gtkutil.c: Likewise.
2086 * image.c: Likewise.
2087 * keyboard.c: Likewise.
2088 * menu.c: Likewise.
2089 * process.c: Likewise.
2090 * scroll.c: Likewise.
2091 * sound.c: Likewise.
2092 * term.c: Likewise.
2093 * w32console.c: Likewise.
2094 * w32fns.c: Likewise.
2095 * w32term.c: Likewise.
2096 * window.c: Likewise.
2097 * xdisp.c: Likewise.
2098 * xfaces.c: Likewise.
2099 * xfns.c: Likewise.
2100 * xselect.c: Likewise.
2101 * xterm.c: Likewise.
2102
1ec4b7b2
SM
21032012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2104
2105 * fns.c (maybe_resize_hash_table): Output message when growing the
2106 purify-hashtable.
2107
2014308a
DA
21082012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2109
2110 * alloc.c (allocate_string_data): Remove dead code.
2111 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2112 avoid GCC warning about unused macro.
2113
246155eb
DA
21142012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2115
2116 * alloc.c (allocate_string): Omit intervals initialization.
2117 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2118 as in make_pure_string and make_pure_c_string.
2119
43184b7b
DA
21202012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2121
d209e2fb 2122 * alloc.c (allocate_string): Fix last change.
43184b7b 2123
3fe6dd74
DA
21242012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2125
d209e2fb 2126 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2127 to memset, add explicit initialization where appropriate.
2128
1ba6038a
GM
21292012-06-27 Glenn Morris <rgm@gnu.org>
2130
2131 * lisp.mk (lisp): Remove paths.elc.
2132
c89926a5
CY
21332012-06-27 Chong Yidong <cyd@gnu.org>
2134
2135 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2136
ed6b3510
JW
21372012-06-26 John Wiegley <johnw@newartisans.com>
2138
1ec4b7b2 2139 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2140 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2141
ed6b3510
JW
2142 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2143 when building with Clang.
2144
8edd4a2b
SM
21452012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2146
2147 * eval.c (Fapply): Allow calling it with a single argument.
2148
f6f62d1b
EZ
21492012-06-26 Eli Zaretskii <eliz@gnu.org>
2150
2151 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2152 _stricmp and _strnicmp.
2153 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2154
62efea5e
DA
21552012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2156
2157 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2158 allocated window.
2159 (allocate_process): Likewise for new process.
8edd4a2b 2160 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2161 (allocate_frame): Likewise.
2162 * frame.c (make_frame): Omit redundant initialization.
2163 * window.c (make_parent_window): Use memset.
2164 (make_window): Omit redundant initialization.
2165 * process.c (make_process): Omit redundant initialization.
2166 * terminal.c (create_terminal): Likewise.
2167
42997f4d
DA
21682012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2169
2170 * term.c (delete_tty): Remove redundant call to memset.
2171
1130ecfc
DA
21722012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2173
2174 * alloc.c: Remove build_string.
2175 * lisp.h: Define build_string as static inline. This provides
2176 a better opportunity to optimize away calls to strlen when the
2177 function is called with compile-time constant argument.
2178 * image.c (imagemagick_error): Convert to build_string.
2179 * w32proc.c (sys_spawnve): Likewise.
2180 * xterm.c (x_term_init): Likewise.
2181
cf38a720
PE
21822012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2183
99027bdd
PE
2184 Use sprintf return value instead of invoking strlen on result.
2185 In the old days this wasn't portable, since some sprintf
2186 implementations returned char *. But they died out years ago and
2187 Emacs already assumes sprintf returns int.
2188 Similarly for float_to_string.
2189 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2190 * ccl.c (ccl_driver):
2191 * character.c (string_escape_byte8):
2192 * data.c (Fnumber_to_string):
2193 * doprnt.c (doprnt):
2194 * print.c (print_object):
2195 * xdisp.c (message_dolog):
2196 * xfns.c (syms_of_xfns):
2197 Use sprintf or float_to_string result to avoid need to call strlen.
2198 * data.c (Fnumber_to_string):
2199 Use make_unibyte_string, since the string must be ASCII.
2200 * lisp.h, print.c (float_to_string): Now returns int length.
2201 * term.c (produce_glyphless_glyph):
2202 Use sprintf result rather than recomputing it.
2203
cf38a720
PE
2204 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2205 * Makefile.in (ALL_CFLAGS):
2206 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2207 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2208
3511c784
DA
22092012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2210
0a08eb21 2211 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2212 strcasecmp if available.
2213 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2214
fb7da12e
AS
22152012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2216
2217 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2218 Avoid comma operator.
2219 * menu.c (push_submenu_start, push_submenu_end)
2220 (push_left_right_boundary, push_menu_pane): Likewise.
2221 * msdos.c (dos_rawgetc): Likewise.
2222
afa2ffd8
DA
22232012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2224
2225 * xfns.c (xic_create_fontsetname): Remove redundant calls
2226 to memset.
2227
b3b4476b
PE
22282012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2229
4495ff38
PE
2230 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2231 sprintf already null-terminates its output.
2232
b3b4476b
PE
2233 * xfns.c (x_window): Remove redundant cast.
2234
b00876c9
DA
22352012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2236
2237 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2238 `const char *' to `char *' to avoid compiler warning.
2239
d188e26b
PE
22402012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2241
885d1d74
PE
2242 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2243 instead of truncating it to 63 (admittedly a generous limit).
2244
d188e26b
PE
2245 * process.c: Fix spelling and caps in comments.
2246
e2f560b1
DN
22472012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2248
e86db54b 2249 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2250 * sysdep.c (setpgrp): Remove definition, not used in this file.
2251
7583a3a1
JB
22522012-06-24 Juanma Barranquero <lekktu@gmail.com>
2253
2254 * makefile.w32-in: Update dependencies.
2255
696056c2
EZ
22562012-06-24 Eli Zaretskii <eliz@gnu.org>
2257
2258 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2259 (SYSTIME_H): Add nt/inc/sys/time.h.
2260
2261 * systime.h [WINDOWSNT]: Include sys/time.h.
2262
2263 * s/ms-w32.h (struct timespec): Definition moved from
2264 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2265
845ca893
PE
22662012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2267
2268 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2269 * buffer.h (buffer_slot_type_mismatch):
2270 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2271 * eval.c (unwind_to_catch):
2272 * image.c (my_png_error, my_error_exit):
2273 * keyboard.c (quit_throw_to_read_char, user_error)
2274 (Fexit_recursive_edit, Fabort_recursive_edit):
2275 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2276 (wrong_type_argument, buffer_overflow, __executable_start)
2277 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2278 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2279 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2280 (fatal):
2281 (child_setup) [!DOS_NT]:
2282 * lread.c (end_of_file_error, invalid_syntax):
2283 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2284 * puresize.h (pure_write_error):
2285 * search.c (matcher_overflow):
2286 * sound.c (sound_perror, alsa_sound_perror):
2287 * sysdep.c, syssignal.h (croak):
2288 * term.c (maybe_fatal, vfatal):
2289 * textprop.c (text_read_only):
2290 * undo.c (user_error):
2291 * unexmacosx.c (unexec_error):
2292 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2293 Use _Noreturn rather than NO_RETURN.
2294 No need for separate decl merely because of _Noreturn.
2295 * sound.c (sound_warning, parse_sound):
2296 Remove unnecessary forward decls.
2297
f1dd8073
PE
22982012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2299
2300 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2301 * lisp.h (WAIT_READING_MAX): New macro.
2302 * dispnew.c (Fsleep_for, sit_for):
2303 * keyboard.c (kbd_buffer_get_event):
2304 * process.c (Faccept_process_output):
2305 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2306 This improves on the previous patch, which introduced a bug
2307 when time_t is unsigned and as wide as intmax_t.
2308 See <http://bugs.gnu.org/9000#51>.
2309
b82c1755
EZ
23102012-06-23 Eli Zaretskii <eliz@gnu.org>
2311
2312 * dispnew.c (sit_for, Fsleep_for):
2313 * keyboard.c (kbd_buffer_get_event):
2314 * process.c (Faccept_process_output): Avoid compiler warnings when
2315 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2316
ca300656
JB
23172012-06-23 Juanma Barranquero <lekktu@gmail.com>
2318
049ec95b
JB
2319 * makefile.w32-in: Update dependencies.
2320
ca300656
JB
2321 * w32.c (ltime): Add return type and declare static.
2322 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2323
db7b8d06
PE
23242012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2325
2326 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2327 Privately reported by Herbert J. Skuhra.
2328 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2329 All uses changed.
2330 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2331 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2332
0bd8297f
EZ
23332012-06-23 Eli Zaretskii <eliz@gnu.org>
2334
96512555
EZ
2335 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2336 last argument of make_unibyte_string.
2337
0bd8297f
EZ
2338 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2339 language ID in the event parameters.
2340
2341 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2342 event.code, not the obscure "character set ID".
2343
63def6b6
CY
23442012-06-23 Chong Yidong <cyd@gnu.org>
2345
2346 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2347
e8a02204
EZ
23482012-06-23 Eli Zaretskii <eliz@gnu.org>
2349
388cdec0
EZ
2350 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2351 * w32.c (fdutimens): New function.
2352
2353 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2354
2355 * s/ms-w32.h (pselect): Redirect to sys_select.
2356
2357 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2358
e8a02204
EZ
2359 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2360 in the logic of incrementing and decrementing the value of
2361 use_relocatable_buffers.
2362
d054f3fb
PE
23632012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2364
2365 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2366 Privately reported by Herbert J. Skuhra.
2367 [__FreeBSD__]: Remove "*/" typo after "#include".
2368 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2369 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2370 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2371 Don't assume EMACS_TIME and struct timeval are the same type.
2372
d35af63c
PE
23732012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2374
2375 Support higher-resolution time stamps (Bug#9000).
2376 The time stamps are only nanosecond-resolution at the C level,
2377 since that's the best that any real-world system supports now.
2378 But they are picosecond-resolution at the Lisp level, as that's
2379 easy, and leaves room for future OS improvements.
2380
2381 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2382 (LIBES): Use it.
2383
2384 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2385 Don't get current time unless it's needed.
2386
2387 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2388 now provides it if it's absent.
2389 (start_atimer): Port to higher-res time stamps.
2390 Check for time stamp overflow. Don't get current time more
2391 often than is needed.
2392
2393 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2394 Include systime.h, not time.h.
2395 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2396
2397 * dired.c: Include stat-time.h.
2398 (Ffile-attributes): File times now have higher resolution.
2399
2400 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2401 (struct image): Timestamp now has higher resolution.
2402
2403 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2404 has at least microseconds now. All uses removed.
2405 (update_frame, update_single_window, update_window, update_frame_1)
2406 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2407
2408 * editfns.c (time_overflow): Now extern.
2409 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2410 (float-time, Fformat_time_string, Fcurrent_time_string)
2411 (Fcurrent_time_zone): Accept and generate higher-resolution
2412 time stamps.
2413 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2414 (decode_time_components, lisp_seconds_argument): New functions.
2415 (make_time): Now static.
2416 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2417 Report an error if the time is invalid, rather than having the caller
2418 do that.
2419
2420 * fileio.c: Include <stat-time.h>
2421 (Fcopy_file): Copy higher-resolution time stamps.
2422 Prefer to set the time stamp via a file descriptor if that works.
2423 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2424 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2425 (Fvisited_file_modtime, Fset_visited_file_modtime):
2426 Support higher-resolution time stamps.
2427
2428 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2429
2430 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2431
2432 * image.c (prepare_image_for_display, clear_image_cache)
2433 (lookup_image): Port to higer-resolution time stamps.
2434
2435 * keyboard.c (start_polling, bind_polling_period):
2436 Check for time stamp overflow.
2437 (read_char, kbd_buffer_get_event, timer_start_idle)
2438 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2439 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2440 Port to higher-resolution time stamps. Do not assume time_t is signed.
2441 (decode_timer): New function. Timers are now vectors of length 9,
2442 not 8, to accommodate the picosecond component.
2443 (timer_check_2): Use it.
2444
2445 * nsterm.m (select_timeout, timeval_subtract): Remove.
2446 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2447 as they're a bit more accurate and handle overflow better.
2448 (ns_select): Change prototype to be compatible with pselect.
2449 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2450 * nsterm.h (ns_select): Adjust prototype.
2451
2452 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2453 us-resolution time stamps.
2454 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2455
2456 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2457
2458 * lisp.h (time_overflow): New decl.
2459 (wait_reading_process_output): First arg is now intmax_t, not int,
2460 to accommodate larger waits.
2461
2462 * process.h (struct Lisp_Process.read_output_delay):
2463 Now counts nanoseconds, not microseconds.
2464 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2465 EMACS_HAS_USECS.
2466 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2467 (wait_reading_process_output):
2468 Port to ns-resolution time stamps.
2469 (Faccept_process_output, wait_reading_process_output):
2470 Check for time stamp overflow. Do not assume time_t is signed.
2471 (select_wrapper): Remove; we now use pselect.
2472 (Fprocess_attributes): Now generates ns-resolution time stamps.
2473
2474 * sysdep.c: Include utimens.h. Don't include utime.h
2475 or worry about struct utimbuf; gnulib does that for us now.
2476 (gettimeofday): Remove; gnulib provides a substitute.
2477 (make_timeval): New function.
2478 (set_file_times): Now sets ns-resolution time stamps.
2479 New arg FD; all uses changed.
2480 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2481 (system_process_attributes):
2482 Now returns ns-resolution time stamp. All uses changed.
2483 Check for time stamp overflow.
2484
2485 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2486 provides a substitute now.
2487
2488 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2489 since it guarantees struct timespec.
2490 (EMACS_TIME): Now struct timespec, so that we can support
2491 ns-resolution time stamps.
2492 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2493 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2494 (EMACS_USECS): Remove.
2495 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2496 so multiply the arg by 1000 before storing it.
2497 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2498 New macros.
2499 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2500 Port to ns-resolution time stamps.
2501 (EMACS_TIME_NEG_P): Remove; replaced by....
2502 (EMACS_TIME_SIGN): New macro.
2503 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2504 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2505 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2506 (make_timeval, make_lisp_time, decode_time_components): New decls.
2507 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2508 that it mishandled time_t overflow. You can't compare by subtracting!
2509 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2510 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2511
2512 * term.c: Include <sys/time.h>.
2513 (timeval_to_Time): New function, for proper overflow wraparound.
2514 (term_mouse_position, term_mouse_click): Use it.
2515
2516 * undo.c (record_first_change): Support higher-resolution time stamps
2517 in the undo buffer.
2518 (Fprimitive_undo): Use them when restoring time stamps.
2519
2520 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2521 (w32_get_internal_run_time):
2522 Port to higher-resolution Emacs time stamps.
2523 (ltime): Now accepts single 64-bit integer, as that's more convenient
2524 for callers.
2525
2526 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2527
2528 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2529 for compatibility with pselect. Support ns-resolution time stamps.
2530
2531 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2532
2533 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2534 Check for time stamp overflow, and support ns-resolution time stamps.
2535
2536 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2537 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2538 (timeval_subtract): Remove; no longer needed.
2539 (XTflash, XTring_bell, x_wait_for_event):
2540 Port to ns-resolution time stamps. Don't assume time_t is signed.
2541
b6a92dfe
CY
25422012-06-22 Chong Yidong <cyd@gnu.org>
2543
2544 * xdisp.c (x_consider_frame_title): Revert last change.
2545
d251c37c
EZ
25462012-06-22 Eli Zaretskii <eliz@gnu.org>
2547
2548 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2549 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2550 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2551 staticidx goes up to 1597 out of 1600 = 0x640.)
2552
f10deafb
PE
25532012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2554
2555 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2556 Otherwise, the umask might be mistakenly 0 while handling input signals.
2557
ec6de1e2
SM
25582012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2559
2560 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2561
28be1ada
DA
25622012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2563
2564 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2565 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2566 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2567 access to `contents' member of Lisp_Vector objects with AREF and ASET
2568 where appropriate.
2569
c6bf3022
CY
25702012-06-19 Chong Yidong <cyd@gnu.org>
2571
2572 * frame.c (delete_frame): When selecting a frame on a different
2573 text terminal, do not alter the terminal's top-frame.
2574
2575 * xdisp.c (format_mode_line_unwind_data): Record the target
2576 frame's selected window and its terminal's top-frame.
2577 (unwind_format_mode_line): Restore them.
2578 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2579 Callers changed.
2580 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2581 since tty frames can be explicitly named.
2582 (prepare_menu_bars): Likewise.
2583
2584 * term.c (Ftty_top_frame): New function.
2585
defd4196
PE
25862012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2587
2588 Port byte-code-meter to modern targets.
2589 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2590 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2591 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2592 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2593 (METER_1, METER_2): Simplify.
2594
1053a871
SM
25952012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2596
2597 * data.c (Fdefalias): Return `symbol' (bug#11686).
2598
b7e8d081
MR
25992012-06-18 Martin Rudalics <rudalics@gmx.at>
2600
2601 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2602 gets killed during executing of this function (Bug#11665).
2603 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2604 (Vkill_buffer_query_functions): In doc-string say that functions
2605 run by this hook should not change the current buffer.
2606
7ea2b339
PE
26072012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2608
2609 Fix recently-introduced process.c problems found by static checking.
2610 * process.c (write_queue_push, write_queue_pop, send_process):
2611 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2612 (write_queue_pop): Fix pointer signedness problem.
2613 (send_process): Remove unused local.
2614
96a313a1
CY
26152012-06-17 Chong Yidong <cyd@gnu.org>
2616
2617 * xdisp.c (redisplay_internal): No need to redisplay terminal
2618 frames that are not on top.
2619
20ca2e94
TN
26202012-06-17 Troels Nielsen <bn.troels@gmail.com>
2621
2622 * process.c (make_process): Initialize write_queue.
2623 (write_queue_push, write_queue_pop): New functions.
2624 (send_process): Use them to maintain correct ordering of process
2625 writes (Bug#10815).
2626
9a900ca9
PE
26272012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2628
310fbfa8
PE
2629 * lisp.h (eassert): Assume C89 or later.
2630 This removes the need for CHECK.
2631 (CHECK): Remove. Its comments about always evaluating its
2632 argument were confusing, as 'eassert' typically does not evaluate
2633 its argument.
2634
27bb1ca4
PE
2635 * coding.c (produce_chars): Use ptrdiff_t, not int.
2636
9a900ca9
PE
2637 * xterm.c (x_draw_underwave): Check for integer overflow.
2638 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2639
41b7f8bc 26402012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2641
2642 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2643 referenced (Bug#11583).
2644
9b0e3eba
AA
26452012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2646
2647 Implement wave-style variant of underlining.
2648 * dispextern.h (face_underline_type): New enum.
2649 (face): Add field for underline type.
2650 * nsterm.m (ns_draw_underwave): New function.
2651 (ns_draw_text_decoration): Use it.
2652 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2653 New functions.
2654 (x_draw_glyph_string): Use them.
2655 * xfaces.c (Qline, Qwave): New Lisp objects.
2656 (check_lface_attrs, merge_face_ref)
1053a871
SM
2657 (Finternal_set_lisp_face_attribute, realize_x_face):
2658 Handle wave-style underline face attributes.
9b0e3eba
AA
2659 * xterm.c (x_draw_underwave): New function.
2660 (x_draw_glyph_string): Use it.
2661
0fb52f11
JB
26622012-06-16 Juanma Barranquero <lekktu@gmail.com>
2663
2664 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2665 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2666 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2667 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2668 ($(BLD)/w32select.$(O)): Update dependencies.
2669
e5560ff7
AS
26702012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2671
2672 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2673 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2674 * character.c (_fetch_multibyte_char_p): Remove.
2675 * alloc.c: Include "character.h" before "buffer.h".
2676 * bidi.c: Likewise.
2677 * buffer.c: Likewise.
2678 * bytecode.c: Likewise.
2679 * callint.c: Likewise.
2680 * callproc.c: Likewise.
2681 * casefiddle.c: Likewise.
2682 * casetab.c: Likewise.
2683 * category.c: Likewise.
2684 * cmds.c: Likewise.
2685 * coding.c: Likewise.
2686 * composite.c: Likewise.
2687 * dired.c: Likewise.
2688 * dispnew.c: Likewise.
2689 * doc.c: Likewise.
2690 * dosfns.c: Likewise.
2691 * editfns.c: Likewise.
2692 * emacs.c: Likewise.
2693 * fileio.c: Likewise.
2694 * filelock.c: Likewise.
2695 * font.c: Likewise.
2696 * fontset.c: Likewise.
2697 * fringe.c: Likewise.
2698 * indent.c: Likewise.
2699 * insdel.c: Likewise.
2700 * intervals.c: Likewise.
2701 * keyboard.c: Likewise.
2702 * keymap.c: Likewise.
2703 * lread.c: Likewise.
2704 * macros.c: Likewise.
2705 * marker.c: Likewise.
2706 * minibuf.c: Likewise.
2707 * nsfns.m: Likewise.
2708 * nsmenu.m: Likewise.
2709 * print.c: Likewise.
2710 * process.c: Likewise.
2711 * regex.c: Likewise.
2712 * region-cache.c: Likewise.
2713 * search.c: Likewise.
2714 * syntax.c: Likewise.
2715 * term.c: Likewise.
2716 * textprop.c: Likewise.
2717 * undo.c: Likewise.
2718 * unexsol.c: Likewise.
2719 * w16select.c: Likewise.
2720 * w32fns.c: Likewise.
2721 * w32menu.c: Likewise.
2722 * window.c: Likewise.
2723 * xdisp.c: Likewise.
2724 * xfns.c: Likewise.
2725 * xmenu.c: Likewise.
2726 * xml.c: Likewise.
2727 * xselect.c: Likewise.
2728
2f07e6af
EZ
27292012-06-16 Eli Zaretskii <eliz@gnu.org>
2730
1053a871
SM
2731 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2732 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2733 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2734 row.
2735 (handle_face_prop): Use chunk-relative overlay string index when
2736 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2737 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2738 the rightmost. (Bug#11720)
2f07e6af 2739
29b83cec
AS
27402012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2741
2742 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2743 (CATEGORY_MEMBER): Enforce 1/0 value.
2744 * category.c (_temp_category_set): Remove.
2745
4c5501e9
EZ
27462012-06-16 Eli Zaretskii <eliz@gnu.org>
2747
2748 * window.c (Fdelete_other_windows_internal)
2749 (Fdelete_window_internal): Don't access frame's mouse highlight
2750 info of the initial frame. (Bug#11677)
2751
2b570124
PE
27522012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2753
e93864f9
PE
2754 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2755 Assume USE_2_TAGS_FOR_INTS.
2756 (xreload): Adjust $tagmask width to match recent lisp.h change.
2757
2b570124
PE
2758 Simplify lisp.h in minor ways that should not affect code.
2759 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2760 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2761 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2762 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2763 (INTTYPEBITS): New macro, for clarity.
2764 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2765 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2766 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2767 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2768 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2769
81755f69
JB
27702012-06-13 Juanma Barranquero <lekktu@gmail.com>
2771
2772 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2773
16192a57
GM
27742012-06-13 Glenn Morris <rgm@gnu.org>
2775
2776 * s/bsd-common.h (BSD4_3):
2777 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2778
646b5f55
AS
27792012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2780
2781 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2782 instead of union.
2783 (XLI, XIL): Define.
1053a871
SM
2784 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2785 Use them.
2786 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2787 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2788 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2789 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2790 * frame.c (delete_frame): Remove outdated comment.
2791 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2792 USE_LISP_UNION_TYPE.
2793 (Fw32_unregister_hot_key): Likewise.
2794 (Fw32_toggle_lock_key): Likewise.
2795 * w32menu.c (add_menu_item): Likewise.
2796 (w32_menu_display_help): Use XIL instead of checking
2797 USE_LISP_UNION_TYPE.
2798 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2799 (init_heap): Likewise.
2800 * w32term.c (w32_read_socket): Update comment.
2801
1d3823c9
GM
28022012-06-13 Glenn Morris <rgm@gnu.org>
2803
c62ff706
GM
2804 * s/usg5-4-common.h, src/s/unixware.h:
2805 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2806
1d3823c9
GM
2807 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2808
bfe3e0a2
PE
28092012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2810
2811 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2812 * alloc.c (make_number) [!defined make_number]:
2813 Remove, as lisp.h always defines this now.
2814 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2815 (roundup_size): Verify that it is a power of 2.
2816 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2817 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2818 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2819 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2820 USE_LSB_TAG now is always defined to be either 0 or 1.
2821 All uses changed.
2822 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2823 code works fine either way, and efficiency is not a concern here,
2824 as the union type is for debugging, not for production.
2825 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2826 Use an inline function on all platforms when using the union type,
2827 since this is simpler and 'static inline' can be used portably
2828 within Emacs now.
2829 (LISP_INITIALLY_ZERO): New macro.
2830 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2831 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2832
45fa9c0f
GM
28332012-06-12 Glenn Morris <rgm@gnu.org>
2834
b4492cba
GM
2835 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2836
2837 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2838
45fa9c0f
GM
2839 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2840 Move BROKEN_SIGIO to configure.
2841
2842 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2843 Move NO_TERMIO to configure.
2844
0e25d334
CY
28452012-06-12 Chong Yidong <cyd@gnu.org>
2846
2847 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2848 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2849 MagickExportImagePixels is undefined.
2850
43682bb6
PE
28512012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2852
2853 * image.c (imagemagick_load_image): Remove unused label.
2854
a9be7d2b
GM
28552012-06-11 Glenn Morris <rgm@gnu.org>
2856
2857 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2858 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2859 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2860 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2861
3017f87f
SM
28622012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2863
2864 * alloc.c (make_byte_code): New function.
2865 (Fmake_byte_code): Use it. Don't purify here.
2866 * lread.c (read1): Use it as well to avoid extra allocation.
2867
1b9b4cf4
CY
28682012-06-11 Chong Yidong <cyd@gnu.org>
2869
2870 * image.c (imagemagick_load_image): Implement transparency.
2871
95988fcf
AS
28722012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2873
2874 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2875 account for preceding backslashes. (Bug#11663)
2876
cd4eb164
CY
28772012-06-09 Chong Yidong <cyd@gnu.org>
2878
2879 * term.c: Support italics in capable terminals (Bug#9652).
2880 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2881 (turn_on_face): Output using TS_enter_italic_mode if available.
2882 Don't handle unused blinking and alt-charset cases.
2883 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2884 and tty_alt_charset_p cases.
2885 (tty_capable_p, init_tty): Support italics.
2886
2887 * termchar.h (struct tty_display_info): Add field for italics.
2888 Remove unused blink field.
2889
2890 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2891 Handle slant.
2892
2893 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2894 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2895 tty_alt_charset_p. Add tty_italic_p.
2896
ff88beb8
MA
28972012-06-09 Michael Albinus <michael.albinus@gmx.de>
2898
2899 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2900 dbus_type_is_basic if available.
2901 (xd_extract_signed, xd_extract_unsigned): Rename from
2902 extract_signed and extract_unsigned, respectively. Adapt callers.
2903
44286096
CY
29042012-06-09 Chong Yidong <cyd@gnu.org>
2905
1682701f
CY
2906 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2907
44286096
CY
2908 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2909 case (Bug#9752).
2910
d86feb17
PE
29112012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2912
2913 * xdisp.c (vmessage): Treat frame message as multibyte.
2914 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2915 would generate the diagnostic "Making \302\247 buffer-local while
2916 let-bound!".
2917
d5c20fe8
EZ
29182012-06-08 Eli Zaretskii <eliz@gnu.org>
2919
2920 * dispnew.c (showing_window_margins_p): Undo last change, which
2921 was done due to an inadvertent commit.
2922 (adjust_frame_glyphs_for_frame_redisplay): Do call
2923 showing_window_margins_p.
2924
513749ee
SM
29252012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2926
2927 * eval.c (Fmake_var_non_special): New primitive.
2928 (syms_of_eval): Defsubr it.
2929 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2930
d4a8f5c1
JB
29312012-06-08 Juanma Barranquero <lekktu@gmail.com>
2932
2933 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2934 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2935
8bbbc977
EZ
29362012-06-08 Eli Zaretskii <eliz@gnu.org>
2937
2938 * alloc.c (allocate_vectorlike): Fix last change.
2939
f3372c87
DA
29402012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2941
2942 Block-based vector allocation of small vectors.
2943 * lisp.h (struct vectorlike_header): New field `nbytes',
2944 adjust comment accordingly.
2945 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2946 to denote vector blocks. Adjust users (live_vector_p,
2947 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2948 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2949 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2950 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2951 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2952 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2953 (roundup_size): New constant.
2954 (struct vector_block): New data type.
2955 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2956 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2957 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2958 (sweep_vectors): New functions.
2959 (allocate_vectorlike): Return `zero_vector' as the only vector of
2960 0 items. Allocate new vector from block if vector size is less than
2961 or equal to VBLOCK_BYTES_MAX.
2962 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2963 (init_alloc_once): Add call to init_vectors.
2964
4f18a4ed
SM
29652012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2966
2967 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2968
86f158bc
PE
29692012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2970
2971 * doprnt.c (doprnt): Truncate multibyte char correctly.
2972 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2973 would mishandle a string argument "Xc" if X was a multibyte
2974 character of length 2: it would truncate after X's first byte
2975 rather than including all of X.
2976
c5cfcbe0
CY
29772012-06-06 Chong Yidong <cyd@gnu.org>
2978
2979 * buffer.c (word_wrap): Doc fix.
2980
c05cf390
PE
29812012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2982
2983 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2984
0c3461de
GM
29852012-06-03 Glenn Morris <rgm@gnu.org>
2986
2987 * xdisp.c (tool-bar-style): Doc fix.
2988
c71232db
UM
29892012-06-03 Ulrich Müller <ulm@gentoo.org>
2990
2991 * Makefile.in (PAXCTL): Define.
2992 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2993 binary via PaX flags if the paxctl utility is available.
2994 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2995 Restore PaX flags to their default. (Bug#11398)
2996
383f7350
CY
29972012-06-03 Chong Yidong <cyd@gnu.org>
2998
2999 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3000 buffer (Bug#11226).
3001
5f2c76c6
CY
30022012-06-03 Chong Yidong <cyd@gnu.org>
3003
3004 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3005 (note_mode_line_or_margin_highlight): If there is no help echo,
3006 use mode-line-default-help-echo. Handle the case where the mouse
3007 position is past the end of the mode line string.
3008
3009 * buffer.c (buffer_local_value_1): New function, split from
3010 Fbuffer_local_value; can return Qunbound.
3011 (Fbuffer_local_value): Use it.
3012 (Vmode_line_format): Docstring tweaks.
3013
773d47f6
PE
30142012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3015
3016 * sysdep.c (system_process_attributes): Improve comment.
3017
f2d6a3df
SM
30182012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3019
3020 * keyboard.c: Export real-this-command to Elisp.
3021 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3022 and DEFVAR it. Update all users.
3023
63810350
PE
30242012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3025
7bd5c1f4
PE
3026 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3027
63810350
PE
3028 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3029 Convert pctcpu and pctmem to Lisp float properly.
3030 Let the compiler fold better, as 100.0/0x8000 is exact.
3031
a2821611
AS
30322012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3033
3034 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3035 cons_block.
3036
5fceba1d
PE
30372012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3038
3039 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3040
c98ff5dd
DA
30412012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3042
3043 For a 'struct window', replace some Lisp_Object fields to
3044 bitfields where appropriate, remove unused fields.
3045 * window.h (struct window): Remove unused 'last_mark_x' and
3046 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3047 change it's type from Lisp_Object to bitfield.
3048 Change type of 'force_start', 'optional_new_start',
3049 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3050 fields from Lisp_Object to bitfield. Adjust users accordingly.
3051
ca34e0be
PE
30522012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3053
3054 Pacify gcc -Wdouble-precision when using Xaw.
3055 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3056 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3057 Use 'float' consistently, rather than 'float' in most places
3058 and 'double' in a couple of places.
3059
efc00ab1 30602012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3061
3062 * xdisp.c (handle_stop): Detect whether we have overlay strings
3063 loaded by testing it->current.overlay_string_index to be
3064 non-negative, instead of checking whether n_overlay_strings is
3065 positive. (Bug#11587)
3066
efc00ab1 30672012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3068
3069 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3070
3071 * doc.c (Fsubstitute_command_keys): Doc fix.
3072
efc00ab1 30732012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3074
3075 * search.c (search_buffer): Remove calls to
3076 r_alloc_inhibit_buffer_relocation, as it is now called by
3077 maybe_unify_char, which was the cause of relocation of buffer text
3078 in bug#11519.
3079
efc00ab1 30802012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3081
3082 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3083 for the duration of call to load_charset, to avoid problems with
3084 callers of maybe_unify_char that access buffer text through C
3085 pointers.
3086
3087 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3088 decrement the inhibition flag, instead of just setting or
3089 resetting it.
3090
ba93a187
PE
30912012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3092
3093 Remove obsolete '#define static' cruft.
3094 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3095 This #undef was "temporary" in 2000; it is no longer needed
3096 now that '#define static' has gone away.
3097 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3098 (gray_bitmap_bits): Remove; no longer needed.
3099 All uses replaced with definiens.
3100 * xterm.c: Include "bitmaps/gray.xbm".
3101
9e4bf381
PE
31022012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3103
3104 Clean up __executable_start, monstartup when --enable-profiling.
3105 The following changes affect the code only when profiling.
3106 * dispnew.c (__executable_start): Rename from safe_bcopy.
3107 Define only on platforms that need it.
3108 * emacs.c: Include <sys/gmon.h> when profiling.
3109 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3110 (__executable_start): Remove decl, since lisp.h does it now.
3111 (safe_bcopy): Remove decl; no longer has that name.
3112 (main): Coalesce #if into single bit of code, for simplicity.
3113 Cast pointers to uintptr_t, since standard libraries want integers
3114 and not pointers.
3115 * lisp.h (__executable_start): New decl.
3116
32d72c2f
GM
31172012-05-31 Glenn Morris <rgm@gnu.org>
3118
3119 * image.c (Fimagemagick_types): Doc fix.
3120
baac5bc7
JM
31212012-05-30 Jim Meyering <meyering@redhat.com>
3122
3123 * callproc.c (Fcall_process_region): Include directory component
3124 in mkstemp error message (Bug#11586).
3125
72cb32cf
PE
31262012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3127
3128 * alloc.c, lisp.h (make_pure_vector): Now static.
3129
61b108cc
SM
31302012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3131
3132 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3133 Move to byte-run.el.
3134 (Fautoload): Do the hash-doc more carefully.
3135 * data.c (Fdefalias): Purify definition, except for keymaps.
3136 (Qdefun): Move from eval.c.
3137 * lisp.h (Qdefun): Remove.
3138 * lread.c (read1): Tiny simplification.
3139
471fe23d
TN
31402012-05-29 Troels Nielsen <bn.troels@gmail.com>
3141
934f3f58 3142 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3143 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3144 Bug#9642, but explicitly check that the buffer the overlay would
3145 be moved to is live and rearrange lines to make sure that errors
3146 will not put the overlay in an inconsistent state.
3147 (Fdelete_overlay): Cosmetics.
3148
85d0efd1
EZ
31492012-05-28 Eli Zaretskii <eliz@gnu.org>
3150
3151 * w32term.c (my_bring_window_to_top): New function.
3152 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3153 could be different from the original one.
3154 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3155 (Bug#11513)
3156
3157 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3158 by calling BringWindowToTop.
3159
3160 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3161 (WM_EMACS_END): Increase by one.
3162
da92a98c
PE
31632012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3164
3165 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3166 This avoids undefined behavior that might cause the eassert
3167 to not catch an out-of-range value.
3168
74d1f848
JB
31692012-05-28 Juanma Barranquero <lekktu@gmail.com>
3170
3171 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3172 Update dependencies.
3173
9e1a06fc
EZ
31742012-05-27 Eli Zaretskii <eliz@gnu.org>
3175
3176 * bidi.c (bidi_mirror_char): Fix last change.
3177
f3dd7312
AS
31782012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3179
3180 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3181 when referring to sectname field in printf format.
3182
81899c91
PE
31832012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3184
57b81a9f
PE
3185 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3186 Only r_alloc_inhibit_buffer_relocation needed to be added;
3187 the others were already declared.
3188
81899c91
PE
3189 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3190 before checking whether it's out of range. Put the check inside
3191 eassert. See
3192 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3193
33017faf 31942012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3195
3196 * callproc.c (Fcall_process): Restore a line that was accidentally
3197 commented out in the 2011-02-13 change (bug#11547).
3198
33017faf 31992012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3200
3201 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3202 defined on ralloc.c.
3203
3204 * buffer.c [REL_ALLOC]: Remove prototypes of
3205 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3206 they are now on lisp.h.
3207
3208 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3209
3210 * search.c (search_buffer): Use it to inhibit relocation of buffer
3211 text while re_search_2 is doing its job, because re_search_2 is
3212 passed C pointers to buffer text. (Bug#11519)
3213
23415acf
EZ
3214 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3215 Update value to 24.
3216
44e27368
EZ
3217 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3218 state after an additional call to move_it_in_display_line_to, keep
3219 the values of it->max_ascent and it->max_descent found for the
3220 entire line.
3221 (pos_visible_p): Revert the comparison against bottom_y to what it
3222 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3223 (Bug#11464)
3224
c1892f11
PE
32252012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3226
3227 Fix coding-related core dumps with gcc -ftrapv.
3228 The code was computing A - B, where A and B are pointers, and B is
3229 random garbage. This can lead to core dumps on platforms that
3230 have special pointer registers, and it also leads to core dumps on
3231 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3232 A - B only when B is initialized properly.
3233 * coding.c (coding_set_source, coding_set_destination): Return void.
3234 (coding_change_source, coding_change_destinations): New functions,
3235 with the old behaviors of coding_set_source and coding_set_destination.
3236 All callers that need an offset changed to use these new functions.
3237
eb7afdad
GM
32382012-05-26 Glenn Morris <rgm@gnu.org>
3239
3240 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3241
f12fdf02
EZ
32422012-05-26 Eli Zaretskii <eliz@gnu.org>
3243
53a63be6 3244 Extend mouse support on W32 text-mode console.
61b108cc
SM
3245 * xdisp.c (draw_row_with_mouse_face):
3246 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3247
eb3f6f01 3248 * w32console.c: Include window.h.
61b108cc
SM
3249 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3250 New functions.
eb3f6f01
EZ
3251 (initialize_w32_display): Initialize mouse-highlight data.
3252
53a63be6
EZ
3253 * w32inevt.c: Include termchar.h and window.h.
3254 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3255 moves, call note_mouse_highlight. If help_echo changed, call
3256 gen_help_event to produce help-echo message in the echo area.
3257 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3258 highlight info.
3259
4cfd81f6
PE
32602012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3261
3262 * lread.c (read1): Simplify slightly to avoid an overflow warning
3263 with GCC 4.7.0 on x86-64.
3264
4446092a
EZ
32652012-05-26 Eli Zaretskii <eliz@gnu.org>
3266
3267 * bidi.c (bidi_mirror_char): Revert last change: an int is
3268 definitely wide enough here.
3269
42b2a986 32702012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3271
42b2a986 3272 Fix integer width and related bugs (Bug#9874).
eb106a49 3273 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3274 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3275 (string_bytes, check_sblock, allocate_string_data):
3276 (compact_small_strings, Fmake_bool_vector, make_string)
3277 (make_unibyte_string, make_multibyte_string)
3278 (make_string_from_bytes, make_specified_string)
3279 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3280 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3281 (mark_vectorlike):
3282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3283 (allocate_pseudovector):
3284 Use int, not EMACS_INT, where int is wide enough.
3285 (inhibit_garbage_collection, Fgarbage_collect):
3286 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3287 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3288 int might not be wide enough.
3289 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3290 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3291 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3292 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3293 (bidi_level_of_next_char, bidi_move_to_visually_next):
3294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3295 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3296 (Fkill_buffer, Fset_buffer_major_mode)
3297 (advance_to_char_boundary, Fbuffer_swap_text)
3298 (Fset_buffer_multibyte, overlays_at, overlays_in)
3299 (overlay_touches_p, struct sortvec, record_overlay_string)
3300 (overlay_strings, recenter_overlay_lists)
3301 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3302 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3303 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3304 (Foverlay_recenter, last_overlay_modification_hooks_used)
3305 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3307 (validate_region): Omit unnecessary test for b <= e,
3308 since that's guaranteed by the previous test.
d311d28c
PE
3309 (adjust_overlays_for_delete): Avoid pos + length overflow.
3310 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3311 (report_overlay_modification):
3312 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3313 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3314 Omit pointer cast, which isn't needed anyway, and doesn't work
3315 after the EMACS_INT -> ptrdiff_t change.
02481186 3316 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3317 * buffer.h: Adjust decls to match defn changes elsewhere.
3318 (struct buffer_text, struct buffer):
3319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3320 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3321 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3322 not int, to avoid needless 32-bit limit on 64-bit hosts.
3323 (exec_byte_code): Use tighter memory-full test, one that checks
3324 for alloca overflow. Don't compute the address of the object just
3325 before an array, as that's not portable. Use EMACS_INT, not
3326 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3327 * callint.c (Fcall_interactively):
3328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3329 * callproc.c (call_process_kill, Fcall_process):
3330 Don't assume pid_t fits into an Emacs fixnum.
3331 (call_process_cleanup, Fcall_process, child_setup):
3332 Don't assume pid_t fits into int.
3333 (call_process_cleanup, Fcall_process, delete_temp_file)
3334 (Fcall_process_region):
3335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3336 (Fcall_process): Simplify handling of volatile integers.
3337 Use int, not EMACS_INT, where int will do.
3338 * casefiddle.c (casify_object, casify_region, operate_on_word)
3339 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3341 (casify_object): Avoid integer overflow when overallocating buffer.
3342 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3343 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3344 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3345 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3346 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3347 integers are now checked earlier. All uses replaced with XINT.
3348 (ccl_driver):
3349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3350 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3351 (ccl_driver, Fregister_code_conversion_map):
3352 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3353 (resolve_symbol_ccl_program): Check that vector header is in range.
3354 Always copy the vector, so that we can check its contents reliably
3355 now rather than having to recheck each instruction as it's being
3356 executed. Check that vector words fit in 'int'.
3357 (ccl_get_compiled_code, Fregister_ccl_program)
3358 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3359 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3360 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3361 contents are in range.
3362 (Fccl_execute_on_string): Check that status is in range.
3363 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3364 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3365 Accept and return EMACS_INT, not int, because callers can pass values
3366 out of 'int' range.
3367 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3368 (multibyte_chars_in_text, parse_str_as_multibyte)
3369 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3370 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3371 (string_escape_byte8, Fget_byte):
3372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3373 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3374 avoid mishandling large integers.
3375 * character.h: Adjust decls to match defn changes elsewhere.
3376 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3377 (Ffind_charset_region):
3378 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3379 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3380 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3381 Don't assume fixnum fits in int.
d311d28c
PE
3382 (load_charset_map_from_vector, Fmap_charset_chars):
3383 Remove now-unnecessary CHECK_NATNUMs.
3384 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3385 Don't rely on undefined behavior with signed left shift overflow.
3386 Don't assume unsigned int fits into fixnum, or that fixnum fits
3387 into unsigned int. Don't require max_code to be a valid fixnum;
3388 that's not true for gb10830 4-byte on a 32-bit host. Allow
3389 invalid_code to be a cons, for the same reason. Require code_offset
3390 to be a character. Avoid int overflow if max_char is close
3391 to INT_MAX.
3392 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3393 this is intended anyway and avoids some undefined behavior.
3394 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3395 INDEX_TO_CODE_POINT, as that's what it expects.
3396 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3397 * charset.h (DECODE_CHAR): Return int, not unsigned;
3398 this is what was intended anyway, and it avoids undefined behavior.
3399 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3400 integer-overflow issues.
3401 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3402 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3403 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3404 * chartab.c (Fmake_char_table, Fset_char_table_range)
3405 (uniprop_get_decoder, uniprop_get_encoder):
3406 Don't assume fixnum fits in int.
3407 * cmds.c (move_point): New function, that does the gist of
3408 Fforward_char and Fbackward_char, but does so while checking
3409 for integer overflow more accurately.
c96e5d6a 3410 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3411 (Fforward_line, Fend_of_line, internal_self_insert)
3412 (internal_self_insert):
3413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3414 Fix a FIXME, by checking for integer overflow when calculating
3415 target_clm and actual_clm.
3416 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3417 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3418 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3419 (coding_alloc_by_making_gap, alloc_destination)
3420 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3421 (encode_coding_utf_16, detect_coding_emacs_mule)
3422 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3423 (detect_coding_iso_2022, decode_coding_iso_2022)
3424 (encode_invocation_designation, encode_designation_at_bol)
3425 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3426 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3427 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3428 (encode_coding_ccl, encode_coding_raw_text)
3429 (detect_coding_charset, decode_coding_charset)
3430 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3431 (produce_composition, produce_charset, produce_annotation)
3432 (decode_coding, handle_composition_annotation)
3433 (handle_charset_annotation, consume_chars, decode_coding_gap)
3434 (decode_coding_object, encode_coding_object, detect_coding_system)
3435 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3436 (code_convert_region, code_convert_string)
8f50130c
PE
3437 (Fdefine_coding_system_internal)
3438 (coding_set_source, coding_set_destination):
d311d28c
PE
3439 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3440 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3441 (Fdefine_coding_system_internal):
3442 Don't assume fixnums fit in int.
3443 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3444 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3445 (Funencodable_char_position, Fcheck_coding_systems_region)
3446 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3448 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3449 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3450 Don't access memory outside of the args array.
d311d28c 3451 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3452 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3453 result of ENCODE_CHAR.
d311d28c
PE
3454 * coding.h: Adjust decls to match defn changes elsewhere.
3455 (struct coding_system):
3456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3457 * composite.c (get_composition_id, find_composition)
3458 (run_composition_function, update_compositions)
3459 (compose_text, composition_gstring_put_cache)
3460 (composition_gstring_p, composition_gstring_width)
3461 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3462 (composition_compute_stop_pos, composition_reseat_it)
3463 (composition_update_it, struct position_record)
3464 (find_automatic_composition, composition_adjust_point)
3465 (Fcomposition_get_gstring, Ffind_composition_internal):
3466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3467 (update_compositions):
3468 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3469 * composite.h: Adjust decls to match defn changes elsewhere.
3470 (struct composition):
3471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3472 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3473 Do not attempt to compute the address of the object just before a
3474 buffer; this is not portable.
3475 (Faref, Faset):
3476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3477 (Faset): Use int, not EMACS_INT, where int is wide enough.
3478 (Fstring_to_number): Don't assume fixnums fit in int.
3479 (Frem): Don't assume arg is nonnegative.
3480 * dbusbind.c (xd_append_arg): Check for integers out of range.
3481 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3482 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3483 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3484 (xd_get_connection_references): Return ptrdiff_t, not int.
3485 All uses changed.
3486 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3487 (xd_read_message_1):
3488 Use int, not unsigned, where the dbus API uses int.
3489 (Fdbus_message_internal): Don't overflow mtype.
3490 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3491 * dired.c (directory_files_internal, file_name_completion, scmp)
3492 (file_name_completion_stat):
3493 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3494 (file_name_completion): Don't overflow matchcount.
3495 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3496 * dispextern.h: Adjust decls to match defn changes elsewhere.
3497 (struct text_pos, struct glyph, struct bidi_saved_info)
3498 (struct bidi_string_data, struct bidi_it, struct composition_it)
3499 (struct it):
3500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3501 (struct display_pos, struct composition_it, struct it):
3502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3503 * dispnew.c (increment_matrix_positions)
3504 (increment_row_positions, mode_line_string)
3505 (marginal_area_string):
3506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3507 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3509 (duration_to_sec_usec): New function, to check for overflow better.
3510 (Fsleep_for, sit_for): Use it.
3511 * doc.c (get_doc_string, store_function_docstring):
3512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3513 (get_doc_string, Fsnarf_documentation):
3514 Use int, not EMACS_INT, where int is wide enough.
3515 (get_doc_string):
3516 Use SAFE_ALLOCA, not alloca.
3517 Check for overflow when converting EMACS_INT to off_t.
3518 * doprnt.c (doprnt):
3519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3520 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3521 Don't assume uid_t fits into fixnum.
3522 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3523 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3524 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3525 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3526 (general_insert_function)
3527 (Finsert_char, make_buffer_string, make_buffer_string_both)
3528 (update_buffer_properties, Fbuffer_substring)
3529 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3530 (Fsubst_char_in_region, check_translation)
3531 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3532 (transpose_markers, Ftranspose_regions):
3533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3534 (clip_to_bounds): Move to lisp.h as an inline function).
3535 (Fconstrain_to_field): Don't assume integers are nonnegative.
3536 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3537 (Fsubst_char_in_region, Fsave_restriction):
3538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3539 (Femacs_pid): Don't assume pid_t fits into fixnum.
3540 (lo_time): Use int, not EMACS_INT, when int suffices.
3541 (lisp_time_argument): Check for usec out of range.
3542 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3543 (Fuser_login_name, Fuser_full_name): Signal an error
3544 if a uid argument is out of range, rather than relying on
3545 undefined behavior.
c8d5c857
PE
3546 (Fformat_time_string): Remove now-unnecessary check.
3547 lisp_time_argument checks for out-of-range usec now.
243e0530 3548 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3549 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3550 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3551 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3552 (init_cmdargs, Fdump_emacs):
3553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3554 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3555 the bottom (typically) 32 bits of the fixnum.
3556 * eval.c (specpdl_size, call_debugger):
3557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3558 (when_entered_debugger, Fbacktrace_debug):
3559 Don't assume fixnum can fit in int.
3560 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3561 the object just before a buffer; this is not portable.
3562 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3563 (grow_specpdl, unbind_to):
3564 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3565 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3566 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3567 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3568 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3569 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3570 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3571 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3572 (a_write, e_write):
3573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3574 (Fcopy_file, non_regular_nbytes, read_non_regular)
3575 (Finsert_file_contents):
3576 Use int, not EMACS_INT, where int is wide enough.
3577 (READ_BUF_SIZE): Verify that it fits in int.
3578 (Finsert_file_contents): Check that counts are in proper range,
3579 rather than assuming fixnums fit into ptrdiff_t etc.
3580 Don't assume fixnums fit into int.
125b3835 3581 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3582 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3583 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3584 (string_char_to_byte, string_byte_to_char)
3585 (string_make_multibyte, string_to_multibyte)
3586 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3587 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3588 (substring_both, Fdelete, internal_equal, Ffillarray)
3589 (Fclear_string, mapcar1)
3590 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3591 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3592 (larger_vector, make_hash_table, maybe_resize_hash_table)
3593 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3594 (Fmaphash, secure_hash):
3595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3596 (concat): Check for string index and length overflow.
3597 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3598 (Frequire):
3599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3600 (larger_vector): New API (vec, incr_min, size_max) replaces old
3601 one (vec, new_size, init). This catches size overflow.
3602 INIT was removed because it was always Qnil.
3603 All callers changed.
3604 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3605 the upper bound on a hash table index size.
3606 (make_hash_table, maybe_resize_hash_table): Use it.
3607 (secure_hash): Computer start_byte and end_byte only after
3608 they're known to be in ptrdiff_t range.
3609 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3610 (Ffont_get_glyphs, Ffont_at):
3611 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3612 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3613 (Flist_fonts, Fopen_font):
3614 Don't assume fixnum can fit in int.
3615 (check_gstring): Don't assume index can fit in int.
3616 (font_match_p): Check that fixnum is a character, not a nonnegative
3617 fixnum, since the later code needs to stuff it into an int.
3618 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3619 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3620 conversion overflow issues.
3621 (Fopen_font): Check for integer out of range.
3622 (Ffont_get_glyphs): Don't assume index can fit in int.
3623 * font.h: Adjust decls to match defn changes elsewhere.
3624 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3625 integer overflow.
3626 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3627 printmax_t, where ptrdiff_t is wide enough.
3628 (Finternal_char_font):
3629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3630 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3631 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3632 (Fset_frame_position, x_set_frame_parameters)
3633 (x_set_line_spacing, x_set_border_width)
3634 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3635 Check that fixnums are in proper range for system types.
3636 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3637 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3638 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3639 Use SAFE_ALLOCA_LISP, not alloca.
3640 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3641 intptr_t is wide enough.
3642 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3643 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3644 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3645 Check for fixnum out of range.
3646 * ftfont.c (ftfont_list): Don't assume index fits in int.
3647 Check that fixnums are in proper range for system types.
3648 (ftfont_shape_by_flt):
3649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3650 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3652 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3653 Check that fixnums are in proper range for system types.
3654 * gnutls.h: Adjust decls to match defn changes elsewhere.
3655 * gtkutil.c (xg_dialog_run):
3656 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3657 (update_frame_tool_bar):
3658 Check that fixnums are in proper range for system types.
3659 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3660 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3661 * indent.c (last_known_column, last_known_column_point):
3662 (current_column_bol_cache):
3663 (skip_invisible, current_column, check_display_width):
3664 (check_display_width, scan_for_column, current_column_1)
3665 (Findent_to, Fcurrent_indentation, position_indentation)
3666 (indented_beyond_p, Fmove_to_column, compute_motion):
3667 (Fcompute_motion, Fvertical_motion):
3668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3669 (last_known_column_modified): Use EMACS_INT, not int.
3670 (check_display_width):
3671 (Fcompute_motion):
3672 Check that fixnums and floats are in proper range for system types.
3673 (compute_motion): Don't assume index or fixnum fits in int.
3674 (compute_motion, Fcompute_motion):
3675 Use int, not EMACS_INT, when it is wide enough.
3676 (vmotion): Omit local var start_hpos that is always 0; that way
3677 we don't need to worry about overflow in expressions involving it.
3678 * indent.h: Adjust decls to match defn changes elsewhere.
3679 (struct position):
3680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3681 Use int, not EMACS_INT, where int is wide enough.
3682 Remove unused members ovstring_chars_done and tab_offset;
3683 all uses removed.
3684 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3685 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3686 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3687 (make_gap, copy_text, insert, insert_and_inherit)
3688 (insert_before_markers, insert_before_markers_and_inherit)
3689 (insert_1, count_combining_before, count_combining_after)
3690 (insert_1_both, insert_from_string)
3691 (insert_from_string_before_markers, insert_from_string_1)
3692 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3693 (adjust_after_replace, adjust_after_insert, replace_range)
3694 (replace_range_2, del_range, del_range_1, del_range_byte)
3695 (del_range_both, del_range_2, modify_region)
3696 (prepare_to_modify_buffer, signal_before_change)
3697 (signal_after_change, Fcombine_after_change_execute):
3698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3699 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3700 (balance_an_interval, split_interval_right, split_interval_left)
3701 (find_interval, next_interval, update_interval)
3702 (adjust_intervals_for_insertion, delete_node, delete_interval)
3703 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3704 (static_offset_intervals, offset_intervals)
3705 (merge_interval_right, merge_interval_left, make_new_interval)
3706 (graft_intervals_into_buffer, temp_set_point_both)
3707 (temp_set_point, set_point, adjust_for_invis_intang)
3708 (set_point_both, move_if_not_intangible, get_property_and_range)
3709 (get_local_map, copy_intervals, copy_intervals_to_string)
3710 (compare_string_intervals, set_intervals_multibyte_1):
3711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3712 * intervals.h: Adjust decls to match defn changes elsewhere.
3713 (struct interval):
3714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3715 * keyboard.c (this_command_key_count, this_single_command_key_start)
3716 (before_command_key_count, before_command_echo_length, echo_now)
3717 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3718 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3719 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3720 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3722 (last_non_minibuf_size, last_point_position, echo_truncate)
3723 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3724 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3725 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3726 (stuff_buffered_input):
3727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3728 (last_auto_save, command_loop_1, read_char):
3729 Use EMACS_INT, not int, to avoid integer overflow.
3730 (record_char): Avoid overflow in total_keys computation.
3731 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3732 * keyboard.h: Adjust decls to match defn changes elsewhere.
3733 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3734 (Fkey_description, Fdescribe_vector, Flookup_key):
3735 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3736 (click_position): New function, to check that positions are in range.
3737 (Fcurrent_active_maps):
3738 (describe_command):
3739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3740 (Faccessible_keymaps, Fkey_description):
3741 (preferred_sequence_p):
3742 Don't assume fixnum can fit into int.
3743 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3744 Check for integer overflow in size calculations.
3745 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3746 avoid mishandling large integers.
3747 * lisp.h: Adjust decls to match defn changes elsewhere.
3748 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3749 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3750 (struct Lisp_Marker):
3751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3752 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3753 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3754 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3755 All callers changed.
3756 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3757 Assume the arg has valid form, since it always does.
3758 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3759 unsigned integer system type.
3760 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3761 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3763 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3764 (duration_to_sec_usec): New decl.
3765 * lread.c (read_from_string_index, read_from_string_index_byte)
3766 (read_from_string_limit, readchar, unreadchar, openp)
3767 (read_internal_start, read1, oblookup):
3768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3769 (Fload, readevalloop, Feval_buffer, Feval_region):
3770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3771 (openp): Check for out-of-range argument to 'access'.
3772 (read1): Use int, not EMACS_INT, where int is wide enough.
3773 Don't assume fixnum fits into int.
6efdadfd 3774 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3775 (read_filtered_event): Use duration_to_sec_usec
3776 to do proper overflow checking on durations.
d311d28c
PE
3777 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3778 in size calculation.
3779 (Fexecute_kbd_macro):
3780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3781 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3782 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3783 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3784 (set_marker_both, set_marker_restricted_both, marker_position)
3785 (marker_byte_position, Fbuffer_has_markers_at):
3786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3787 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3788 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3789 It now merely ensures that the menu is large enough, without
3790 necessarily growing it, as this avoids some integer overflow issues.
3791 All callers changed.
3792 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3793 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3794 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3795 Use SAFE_ALLOCA_LISP, not alloca.
3796 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3797 to EMACS_INT. Check that fixnums are in proper range for system types.
3798 * minibuf.c (minibuf_prompt_width, string_to_object)
3799 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3800 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3802 (get_minibuffer, read_minibuf_unwind):
3803 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3804 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3805 this simplifies overflow checking. All callers changed.
3806 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3807 (Ftest_completion):
3808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3809 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3810 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3811 Check that fixnums are in proper range for system types.
3812 (Fx_create_frame, Fx_show_tip):
3813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3814 * nsfont.m (ns_findfonts, nsfont_list_family):
3815 Don't assume fixnum fits in long.
3816 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3818 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3819 wide enough.
17fdb222 3820 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3822 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3823 (PRINTDECLARE, PRINTPREPARE):
3824 (strout, print_string):
3825 (print, print_preprocess, print_check_string_charset_prop)
3826 (print_object):
3827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3828 (PRINTDECLARE):
3829 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3830 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3831 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3832 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3833 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3834 (print_error_message): Use SAFE_ALLOCA, not alloca.
3835 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3836 (print_depth, new_backquote_output, print_number_index):
3837 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3838 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3839 (Fset_process_window_size, Fformat_network_address)
3840 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3841 (sigchld_handler):
d311d28c 3842 Check that fixnums are in proper range for system types.
d44287d4 3843 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3844 Check for process-ids out of pid_t range rather than relying on
3845 undefined behavior.
e4d81efc 3846 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3847 (Fformat_network_address, read_process_output, send_process)
3848 (Fprocess_send_region, status_notify):
3849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3850 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3851 (wait_reading_process_output, read_process_output, exec_sentinel):
3852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3853 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3854 (Faccept_process_output): Use duration_to_sec_usec to do proper
3855 overflow checking on durations.
dde14581
PE
3856 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3857 Don't assume pid_t fits in int.
02481186
PE
3858 * process.h (struct Lisp_Process): Members tick and update_tick
3859 are now of type EMACS_INT, not int.
b62b53e8
PE
3860 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3861 configured --with-wide-int.
d311d28c
PE
3862 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3863 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3864 * search.c (looking_at_1, string_match_1):
3865 (fast_string_match, fast_c_string_match_ignore_case)
3866 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3867 (scan_newline, find_before_next_newline, search_command)
3868 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3869 (set_search_regs, wordify):
3870 (Freplace_match):
3871 (Fmatch_data):
3872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3873 (string_match_1, search_buffer, set_search_regs):
3874 (Fmatch_data):
3875 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3876 (wordify): Check for overflow in size calculation.
3877 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3878 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3879 Check that fixnums are in proper range for system types.
3880 * sound.c (struct sound_device)
3881 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3883 (Fplay_sound_internal):
3884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3885 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3886 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3887 (Fparse_partial_sexp):
3888 Don't assume fixnums can fit in int.
3889 (struct lisp_parse_state, find_start_pos, find_start_value)
3890 (find_start_value_byte, find_start_begv)
3891 (update_syntax_table, char_quoted, dec_bytepos)
3892 (find_defun_start, prev_char_comend_first, back_comment):
3893 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3894 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3896 (Finternal_describe_syntax_value): Check that match_lisp is a
3897 character, not an integer, since the code stuffs it into int.
3898 (scan_words, scan_sexps_forward):
3899 Check that fixnums are in proper range for system types.
3900 (Fforward_word):
3901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3902 (scan_sexps_forward):
3903 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3904 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3905 * syntax.h: Adjust decls to match defn changes elsewhere.
3906 (struct gl_state_s):
3907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3908 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3909 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3910 * sysdep.c (wait_for_termination_1, wait_for_termination)
3911 (interruptible_wait_for_termination, mkdir):
3912 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3913 (emacs_read, emacs_write):
3914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3915 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3916 and double all fit in int.
d311d28c
PE
3917 * term.c (set_tty_color_mode):
3918 Check that fixnums are in proper range for system types.
3919 * termhooks.h (struct input_event):
3920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3921 * textprop.c (validate_interval_range, interval_of)
3922 (Fadd_text_properties, set_text_properties_1)
3923 (Fremove_text_properties, Fremove_list_of_text_properties)
3924 (Ftext_property_any, Ftext_property_not_all)
3925 (copy_text_properties, text_property_list, extend_property_ranges)
3926 (verify_interval_modification):
3927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3928 (Fnext_single_char_property_change)
3929 (Fprevious_single_char_property_change):
3930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3931 (copy_text_properties):
3932 Check for integer overflow in index calculation.
d311d28c
PE
3933 * undo.c (last_boundary_position, record_point, record_insert)
3934 (record_delete, record_marker_adjustment, record_change)
3935 (record_property_change):
3936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3937 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3938 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3939 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3940 (Fx_hide_tip, Fx_file_dialog):
3941 * w32menu.c (set_frame_menubar):
3942 Use ptrdiff_t, not int, for consistency with rest of code.
3943 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3944 (select_window, Fdelete_other_windows_internal)
3945 (window_scroll_pixel_based, window_scroll_line_based)
3946 (Frecenter, Fset_window_configuration):
3947 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3948 (Fset_window_hscroll, run_window_configuration_change_hook)
3949 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3950 (Fscroll_other_window, Frecenter):
d311d28c
PE
3951 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3952 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3953 Don't assume fixnum fits in int.
3954 (Fset_window_scroll_bars):
3955 Check that fixnums are in proper range for system types.
3956 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3957 (string_pos, c_string_pos, number_of_chars, init_iterator)
3958 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3959 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3960 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3961 (face_before_or_after_it_pos, handle_invisible_prop)
3962 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3963 (display_prop_intangible_p, string_buffer_position_lim)
3964 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3965 (get_overlay_strings_1, get_overlay_strings)
3966 (iterate_out_of_display_property, forward_to_next_line_start)
3967 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3968 (get_next_display_element, set_iterator_to_next)
3969 (get_visually_first_element, compute_stop_pos_backwards)
3970 (handle_stop_backwards, next_element_from_buffer)
3971 (move_it_in_display_line_to, move_it_in_display_line)
3972 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3973 (add_to_log, message_dolog, message_log_check_duplicate)
3974 (message2, message2_nolog, message3, message3_nolog
3975 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3976 (current_message_1, truncate_echo_area, truncate_message_1)
3977 (set_message, set_message_1, store_mode_line_noprop)
3978 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3979 (text_outside_line_unchanged_p, check_point_in_composition)
3980 (reconsider_clip_changes)
3981 (redisplay_internal, set_cursor_from_row, try_scrolling)
3982 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3983 (redisplay_window, find_last_unchanged_at_beg_row)
3984 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3985 (trailing_whitespace_p, find_row_edges, display_line)
3986 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3987 (display_mode_element, store_mode_line_string)
3988 (pint2str, pint2hrstr, decode_mode_spec)
3989 (display_count_lines, display_string, draw_glyphs)
3990 (x_produce_glyphs, x_insert_glyphs)
3991 (rows_from_pos_range, mouse_face_from_buffer_pos)
3992 (fast_find_string_pos, mouse_face_from_string_pos)
3993 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3994 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3995 (safe_call, init_from_display_pos, handle_fontified_prop)
3996 (handle_single_display_spec, load_overlay_strings)
3997 (with_echo_area_buffer, setup_echo_area_for_printing)
3998 (display_echo_area, echo_area_display)
3999 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4000 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4001 (redisplay_window, dump_glyph_row, display_mode_line)
4002 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4003 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4004 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4005 (handle_single_display_spec, build_desired_tool_bar_string)
4006 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4007 (get_specified_cursor_type):
4008 Check that fixnums are in proper range for system types.
4009 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4010 (Flookup_image_map):
4011 Don't assume fixnums fit in int.
4012 (compare_overlay_entries):
4013 Avoid mishandling comparisons due to subtraction overflow.
4014 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4015 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4016 (handle_tool_bar_click):
4017 Use int, not unsigned, since we prefer signed and the signedness
4018 doesn't matter here.
4019 (get_next_display_element, next_element_from_display_vector):
4020 Use int, not EMACS_INT, when int is wide enough.
4021 (start_hourglass): Use duration_to_sec_usec to do proper
4022 overflow checking on durations.
4023 * xfaces.c (Fbitmap_spec_p):
4024 Check that fixnums are in proper range for system types.
4025 (compare_fonts_by_sort_order):
4026 Avoid mishandling comparisons due to subtraction overflow.
4027 (Fx_family_fonts, realize_basic_faces):
4028 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4029 (Fx_family_fonts):
4030 Don't assume fixnum fits in int.
4031 Use SAFE_ALLOCA_LISP, not alloca.
4032 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4033 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4034 (face_at_buffer_position, face_for_overlay_string)
4035 (face_at_string_position):
4036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4037 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4038 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4039 (Fx_show_tip):
4040 Check that fixnums are in proper range for system types.
4041 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4042 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4044 (Fx_change_window_property): Don't assume fixnums fit in int.
4045 * xfont.c (xfont_chars_supported):
4046 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4047 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4048 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4049 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4050 * xml.c (parse_region):
4051 * xrdb.c (magic_file_p):
4052 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4053 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4054 (x_get_local_selection, x_reply_selection_request)
4055 (x_handle_selection_request, wait_for_property_change):
4056 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4057 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4058 short is wide enough.
4059 (x_send_client_event): Don't assume fixnum fits in int.
4060 * xterm.c (x_x_to_emacs_modifiers):
4061 Don't assume EMACS_INT overflows nicely into int.
4062 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4063 may come from Lisp.
4064 (handle_one_xevent): NATNUMP can eval its arg twice.
4065 (x_connection_closed):
4066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4067 * xterm.h: Adjust decls to match defn changes elsewhere.
4068 (struct scroll_bar): Use struct vectorlike_header
4069 rather than rolling our own approximation.
4070 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4071
c6574eb5
GM
40722012-05-25 Glenn Morris <rgm@gnu.org>
4073
4074 * lisp.mk (lisp): Update for more files being compiled now.
4075
e8d32c7e
SM
40762012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4077
48def666
SM
4078 * lread.c: Remove `read_pure' which makes no difference.
4079 (read_pure): Remove var.
4080 (unreadpure): Remove function.
4081 (readevalloop): Don't call read_list with -1 flag.
4082 (read1, read_vector): Don't test read_pure any more.
4083 (read_list): Simplify.
4084
e8d32c7e
SM
4085 * fileio.c, character.h: Minor style tweaks.
4086
4b2addb7
DA
40872012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4088
4089 * window.h (clip_changed): Remove useless declaration.
4090
584461b2
JB
40912012-05-22 Juanma Barranquero <lekktu@gmail.com>
4092
4093 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4094 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4095
34374650
PE
40962012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4097
4098 Remove src/m/*.
4099 This directory predates autoconf and is no longer needed nowadays.
4100 Move its few remaining bits of functionality to where they're needed.
4101 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4102 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4103 * m/template.h: Remove.
4104 * Makefile.in (M_FILE): Remove. All uses removed.
4105 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4106 * lisp.h (USE_LSB_TAG):
4107 * mem-limits.h (EXCEEDS_LISP_PTR):
4108 Use VAL_MAX, not VALBITS, in #if.
4109 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4110 (EMACS_UINT): Define unconditionally now.
4111 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4112 (BITS_PER_EMACS_INT): New constants, replacing
4113 what used to be in config.h, but not useful in #if.
4114 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4115 define them any more.
4116 (VAL_MAX): New macro.
4117 (VALMASK): Use it.
4118 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4119 BITS_PER_EMACS_INT, in #if.
4120 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4121 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4122 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4123 * s/ms-w32.h (DATA_START):
4124 Move here from removed file m/intel386.h.
4125 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4126 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4127
261cb4bb
PE
41282012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4129
4130 Assume C89 or later.
4131 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4132 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4133 (xrealloc):
4134 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4135 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4136 * textprop.c, tparam.c (NULL): Remove.
4137 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4138 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4139 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4140 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4141 * xterm.c (input_signal_count): Assume volatile works.
4142
ff23cd9f
KB
41432012-05-21 Ken Brown <kbrown@cornell.edu>
4144
4145 * xgselect.c (xg_select): Fix first argument in call to 'select'
4146 (bug#11508).
4147
1b170bc6
KB
41482012-05-20 Ken Brown <kbrown@cornell.edu>
4149
4150 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4151 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4152
b2f4d39f
KB
41532012-05-19 Ken Brown <kbrown@cornell.edu>
4154
4155 * xfns.c (x_in_use): Remove `static' qualifier.
4156 * xterm.h (x_in_use): Declare.
4157 * xgselect.c: Include xterm.h.
4158 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4159 and `display_arg' (bug#9754).
4160
003fdae2
PE
41612012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4162
9232a6d9
PE
4163 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4164
003fdae2
PE
4165 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4166 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4167
784b56e2
EZ
41682012-05-18 Eli Zaretskii <eliz@gnu.org>
4169
4170 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4171
4172 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4173 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4174
4175 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4176 reference to image_cache->refcount.
4177 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4178
a0a79cde
JL
41792012-05-17 Juri Linkov <juri@jurta.org>
4180
4181 * search.c (Fword_search_regexp, Fword_search_backward)
4182 (Fword_search_forward, Fword_search_backward_lax)
4183 (Fword_search_forward_lax): Move functions to isearch.el
4184 (bug#10145, bug#11381).
4185
b0572523
PE
41862012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4187
4188 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4189
9660f5fc
SM
41902012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4191
4192 * lread.c (init_obarray): Declare Qt and Qnil as special.
4193
4374de83
GM
41942012-05-14 Glenn Morris <rgm@gnu.org>
4195
4196 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4197 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4198
dc44c39a
PE
41992012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4200
078c97cb
PE
4201 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4202
dc44c39a
PE
4203 * unexaix.c: Port to more-recent AIX compilers.
4204 (report_error, report_error_1, make_hdr, copy_sym)
4205 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4206 Make arguments const char *, not char *, to avoid violations of C
4207 standard and to fix some AIX warnings reported by Gilles Pion.
4208
e18afed7 42092012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4210
4211 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4212 already have overlays loaded.
4213 (handle_single_display_spec): Before returning without displaying
4214 fringe bitmap, synchronize the bidi iterator with the main display
4215 iterator, by calling iterate_out_of_display_property.
4216 (iterate_out_of_display_property): Detect buffer iteration by
4217 testing that it->string is a Lisp string.
4218 (get_next_display_element): When the current object is exhausted,
4219 and there's something on it->stack, call set_iterator_to_next to
4220 proceed with what's on the stack, instead of returning zero.
4221 (set_iterator_to_next): If called at the end of a Lisp string,
4222 proceed to consider_string_end without incrementing string
4223 position. Don't increment display vector index past the end of
4224 the display vector. (Bug#11417)
c8fb9dc6
EZ
4225 (pos_visible_p): Don't report a position visible when move_it_to
4226 stopped at the last line of window, which happens to be scanned
4227 backwards by the bidi iteration. (Bug#11464)
ac268e67 4228
e18afed7 42292012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4230
4231 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4232 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4233 are on a TTY, and thus unable to display on the fringes.
4234 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4235 so we need to signal to the caller that this is a "replacing"
4236 display spec. This fixes display when the spec is invalid or we
4237 are on a TTY.
4238
e18afed7 42392012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4240
4241 * unexaix.c (make_hdr): Fix typo in prototype.
4242 This bug broke the build on AIX. Problem reported by Gilles Pion.
4243
9d0a235a
MA
42442012-05-14 Michael Albinus <michael.albinus@gmx.de>
4245
4246 * keyboard.c (kbd_buffer_get_event): Read special events also in
4247 batch mode. (Bug#11415)
4248
9e6b06ed
GM
42492012-05-12 Glenn Morris <rgm@gnu.org>
4250
4251 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4252
c1a1d7a3
EZ
42532012-05-12 Eli Zaretskii <eliz@gnu.org>
4254
4255 * lisp.mk (lisp): Add newcomment.elc.
4256
3fe7cdc8
GM
42572012-05-12 Glenn Morris <rgm@gnu.org>
4258
4259 * Makefile.in (MKDIR_P): New, set by configure.
4260 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4261
53f7d2c0
PE
42622012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4263
4264 Remove unused function hourglass_started.
4265 * dispextern.h (hourglass_started):
4266 * w32fns.c (hourglass_started):
4267 * xdisp.c (hourglass_started): Remove.
4268
75aafb17
JB
42692012-05-10 Juanma Barranquero <lekktu@gmail.com>
4270
4271 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4272 Update dependencies.
4273
12959e8e
PE
42742012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4275
97107e2e
PE
4276 * xgselect.c (xg_select): Put maxfds+1 into a var.
4277 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4278
12959e8e
PE
4279 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4280
836d29b3
DA
42812012-05-10 Dave Abrahams <dave@boostpro.com>
4282
4283 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4284 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4285
5cb67954
MA
42862012-05-09 Michael Albinus <michael.albinus@gmx.de>
4287
4288 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4289 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4290 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4291 Initialize xd_registered_buses.
4292
3478ec45
PE
42932012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4294
b263a6b0
PE
4295 Untag more efficiently if USE_LSB_TAG.
4296 This is based on a proposal by YAMAMOTO Mitsuharu in
4297 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4298 For an admittedly artificial (nth 8000 longlist) benchmark on
4299 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4300 Emacs's overall text size by 1%.
4301 * lisp.h (XUNTAG): New macro.
4302 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4303 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4304 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4305 * eval.c (Fautoload):
4306 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4307 * frame.h (XFRAME): Use XUNTAG.
4308
3478ec45
PE
4309 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4310 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4311 Remove unportable assumptions about print widths of types like
4312 dbus_uint32_t.
4313 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4314 intptr_t when converting between pointer and integer, to avoid GCC
4315 warnings about wrong width.
4316
666b903b 43172012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4318
4319 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4320 stack for each reader_thread, instead of defaulting to 8MB
4321 determined by the linker. This avoids failures in creating
4322 subprocesses on Windows 7, see the discussion in this thread:
4323 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4324
b120cc17
JC
43252012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4326
4327 Fix up display of the *Minibuf-0* buffer in the mini window.
4328 * keyboard.c (read_char): Don't clear the echo area if there's no
4329 message to clear.
4330 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4331 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4332
9a4b36f8
MA
43332012-05-07 Michael Albinus <michael.albinus@gmx.de>
4334
4335 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4336 batch mode.
4337
e5f9458f
CY
43382012-05-06 Chong Yidong <cyd@gnu.org>
4339
4340 * lisp.mk (lisp): Update.
4341
eceeb5fc 43422012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4343
4344 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4345
71873e2b
SM
43462012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4347
4348 * data.c (PUT_ERROR): New macro.
4349 (syms_of_data): Use it. Add new error type `user-error'.
4350 * undo.c (user_error): New function.
4351 (Fprimitive_undo): Use it.
4352 * print.c (print_error_message): Adjust print style for `user-error'.
4353 * keyboard.c (user_error): New function.
4354 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4355
ab0fa4e4
PE
43562012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4357
4358 Do not limit current-time-string to years 1000..9999.
4359 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4360 (Fcurrent_time_string): Support any year that is supported by the
4361 underlying localtime representation. Don't use asctime, as it
4362 has undefined behavior for years outside the range -999..9999.
4363
7ed806a7
PE
43642012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4365
4366 Fix race conditions involving setenv, gmtime, localtime, asctime.
4367 Without this fix, interrupts could mess up code that uses these
4368 nonreentrant functions, since setting TZ invalidates existing
4369 tm_zone or tzname values, and since most of these functions return
4370 pointers to static storage.
4371 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4372 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4373 Grow the critical sections to include not just invoking
4374 localtime/gmtime, but also accessing these functions' results
4375 including their tm_zone values if any, and any related TZ setting.
4376 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4377 so that the struct tm is saved in the critical section.
4378 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4379 motivated by the fact that memory allocation needs to be outside
4380 the critical section.
4381
0c16dfed
DA
43822012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4383
4384 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4385 with RESET_INTERVAL.
4386
4387 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4388 Remove duplicated buffer name initialization.
4389
3f83ace8
JM
43902012-05-02 Jim Meyering <jim@meyering.net>
4391
4392 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4393
c7b8541e
JM
4394 * xfns.c (x_window): Use xstrdup (Bug#11375).
4395
90207a15 43962012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4397
4398 * xdisp.c (pos_visible_p): If already at a newline from the
4399 display string before the 'while' loop, don't walk back the glyphs
4400 from it3.glyph_row. Solves assertion violation when the display
4401 string begins with a newline (egg.el). (Bug#11367)
4402
b593d6a9
AH
44032012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4404
4405 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4406 Move to simple.el.
4407
4737362e
GM
44082012-05-01 Glenn Morris <rgm@gnu.org>
4409
99cf43f9
GM
4410 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4411 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4412 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4413 All were removed before 23.1.
4414
9311dcff
GM
4415 * dispnew.c: Remove HAVE_LIBNCURSES test;
4416 it is always true on relevant platforms.
4417
4d5c6349
GM
4418 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4419 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4420
4737362e
GM
4421 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4422
74dd3a6b
AS
44232012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4424
4425 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4426 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4427 Remove.
4428
13c379ee
PE
44292012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4430
4431 Do not avoid creating empty evaporating overlays (Bug#9642).
4432 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4433 That is, do not delete an evaporating overlay if it becomes
4434 empty after its bounds are adjusted to fit within its buffer.
4435 This fix caused other problems, and I'm reverting it until we get
4436 to the bottom of them.
4437
a8e7d6d7 44382012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4439
4440 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4441
a8e7d6d7 44422012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4443
4444 * xdisp.c (pos_visible_p): If the window start position is beyond
4445 ZV, start the display from buffer beginning. Prevents assertion
4446 violation in init_iterator when the minibuffer window is scrolled
4447 via the scroll bar.
4448
4449 * window.c (window_scroll_pixel_based): Likewise.
4450
a8e7d6d7 44512012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4452
4453 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4454
a8e7d6d7 44552012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4456
4457 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4458 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4459
a8e7d6d7 44602012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4461
b593d6a9
AH
4462 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4463 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4464
1c6900d9
EZ
44652012-04-26 Eli Zaretskii <eliz@gnu.org>
4466
4c3fa1d9
EZ
4467 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4468 display element, check also the underlying string or buffer
4469 character. (Bug#11341)
4470
1c6900d9
EZ
4471 * w32menu.c: Include w32heap.h.
4472 (add_menu_item): If the call to AppendMenuW (via
4473 unicode_append_menu) fails, disable Unicode menus only if we are
4474 running on Windows 9X/Me.
4475
42bf8205
AS
44762012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4477
4478 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4479 (xgetint): Add missing shift for LSB tags.
4480
b1bac16e
MR
44812012-04-24 Martin Rudalics <rudalics@gmx.at>
4482
4483 * keyboard.c (read_char): Don't wipe echo area for select window
4484 events: These might get delayed via `mouse-autoselect-window'
4485 (Bug#11304).
4486
d69621cc
JB
44872012-04-24 Juanma Barranquero <lekktu@gmail.com>
4488
4489 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4490 manipulation of :loaded-from data.
4491
02fd101b
JB
44922012-04-23 Juanma Barranquero <lekktu@gmail.com>
4493
4494 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4495 now a cons (bug#11311).
4496
888bec30
PE
44972012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4498
89a438bd
PE
4499 Do not create empty overlays with the evaporate property (Bug#9642).
4500 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4501 if it becomes empty after its bounds are adjusted to fit within
4502 its buffer. Without this fix, in a nonempty buffer (let ((o
4503 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4504 yields an empty overlay that has the evaporate property, which is
4505 not supposed to happen.
4506
1068fe4d
PE
4507 Fix minor GTK3 problems found by static checking.
4508 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4509 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4510 (struct _EmacsFixedClass, emacs_fixed_get_type):
4511 Move decls here from emacsgtkfixed.h, since they needn't be public.
4512 (emacs_fixed_get_type): Now static.
4513 (emacs_fixed_class_init): Omit unused local.
4514 (emacs_fixed_child_type): Remove; unused.
4515 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4516 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4517 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4518 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4519 (EMACS_FIXED_GET_CLASS): Remove; unused.
4520 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4521
888bec30
PE
4522 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4523 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4524
de85e130
PE
45252012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4526
d0baac98 4527 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4528 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4529 (__malloc_size_t, __malloc_ptrdiff_t):
4530 Remove. All uses removed, replaced by the definiens if needed,
4531 since we can assume C89 or better now.
4532 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4533 (protect_malloc_state, align, get_contiguous_space)
4534 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4535 (malloc_atfork_handler_child, malloc_enable_thread)
4536 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4537 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4538 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4539 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4540 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4541 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4542 Define using prototypes, not old style.
4543 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4544 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4545 (align): Don't assume that signed integer overflow wraps around.
4546 Omit unused local var.
4547 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4548 (_free_internal_nolock, memalign, mallochook, reallochook):
4549 Omit no-longer-needed casts.
4550 (valloc): Use getpagesize, not __getpagesize.
4551 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4552 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4553
de85e130
PE
4554 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4555
dcbf5805
MA
45562012-04-22 Michael Albinus <michael.albinus@gmx.de>
4557
4558 Move functions from C to Lisp. Make non-blocking method calls
4559 the default. Implement further D-Bus standard interfaces.
4560
4561 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4562 (QCdbus_request_name_allow_replacement)
4563 (QCdbus_request_name_replace_existing)
4564 (QCdbus_request_name_do_not_queue)
4565 (QCdbus_request_name_reply_primary_owner)
4566 (QCdbus_request_name_reply_in_queue)
4567 (QCdbus_request_name_reply_exists)
4568 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4569 (QCdbus_registered_serial, QCdbus_registered_method)
4570 (QCdbus_registered_signal): New Lisp objects.
4571 (XD_DEBUG_MESSAGE): Use sizeof.
4572 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4573 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4574 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4575 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4576 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4577 (xd_signature, xd_append_arg): Allow float for integer types.
4578 (xd_get_connection_references): New function.
b593d6a9
AH
4579 (xd_get_connection_address): Rename from xd_initialize.
4580 Return cached address.
dcbf5805
MA
4581 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4582 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4583 level.
4584 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4585 Return number of refcounts.
dcbf5805
MA
4586 (Fdbus_get_unique_name): Make stronger parameter check.
4587 (Fdbus_message_internal): New defun.
4588 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4589 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4590 (Fdbus_send_signal, Fdbus_register_service)
4591 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4592 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4593 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4594 (Vdbus_compiled_version, Vdbus_runtime_version)
4595 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4596 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4597 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4598 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4599 Adapt docstring.
dcbf5805 4600
52828e02
PE
46012012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4602
da05bc4c
PE
4603 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4604 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4605 Do not assume ptrdiff_t is the same width as 'int'.
4606
52828e02
PE
4607 * alloc.c: Handle unusual debugging option combinations.
4608 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4609 since the two debugging options are incompatible.
4610 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4611 is defined.
4612 (mem_init, mem_insert, mem_insert_fixup):
4613 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4614 (NEED_MEM_INSERT): Remove; no longer needed.
4615
f01769f9
LL
46162012-04-22 Leo Liu <sdl.web@gmail.com>
4617
4618 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4619
5790543d
PE
46202012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4621
4622 * sysdep.c [__FreeBSD__]: Minor cleanups.
4623 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4624 Use Emacs indenting style more consistently. Avoid some casts.
4625 Use 'double' consistently rather than mixing 'float' and 'double'.
4626
b91b7e4d
EW
46272012-04-21 Eduard Wiebe <usenet@pusto.de>
4628
b593d6a9
AH
4629 * sysdep.c (list_system_processes, system_process_attributes):
4630 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4631
6114eb15
AS
46322012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4633
4634 * lisp.mk (lisp): Update.
4635
2f38dff7
PE
46362012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4637
4638 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4639 It is never used otherwise.
4640
4ae29f89
SM
46412012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4642
4643 * print.c (print_preprocess): Only check print_depth if print-circle
4644 is nil.
4645 (print_object): Check for cycles even when print-circle is nil and
4646 print-gensym is t, but only check print_depth if print-circle is nil.
4647
f30d612a
CY
46482012-04-20 Chong Yidong <cyd@gnu.org>
4649
4650 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4651 set the status to "failed" and ensure that sentinel is run.
4652
c07a4c0b 46532012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4654
4655 * process.c (Fset_process_inherit_coding_system_flag)
4656 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4657 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4658
c07a4c0b 46592012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4660
4661 * xdisp.c (string_buffer_position_lim): Limit starting position to
4662 BEGV.
4663 (set_cursor_from_row): If called for a mode-line or header-line
4664 row, return zero immediately.
4665 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4666 farther than the first row after the header line, if any.
4667 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4668 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4669
c07a4c0b 46702012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4671
4ae29f89
SM
4672 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4673 (bug#11238).
ad3a2b41 4674
c07a4c0b 46752012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 46762012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4677
4678 configure: new option --enable-gcc-warnings (Bug#11207)
4679 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4680 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4681 (ALL_CFLAGS): Use new macros rather than old.
4682 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4683 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4684 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4685 -Wunused-result, -Wunused-variable. This should go away once
4686 the Emacs and Gnulib regex code is merged.
4687 (xmalloc, xrealloc): Now static.
4688
aba027e8
PE
46892012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4690
4691 * dired.c (Fsystem_groups): Remove unused local.
4692
e5a36063
GM
46932012-04-17 Glenn Morris <rgm@gnu.org>
4694
4695 * dired.c (Fsystem_users): Doc fix.
4696
316411f0
DA
46972012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4698
4699 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4700 (syms_of_dired): Add them.
4701
9426aba4
PE
47022012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4703
b62a57be
PE
4704 Fix minor alloc.c problems found by static checking.
4705 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4706 New extern decls, to avoid calling undeclared functions.
4707 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4708 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4709 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4710 (NEED_MEM_INSERT): New macro.
4711 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4712 Remove one incorrect comment and fix another.
b62a57be 4713
3539f31f
PE
4714 Fix minor ralloc.c problems found by static checking.
4715 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4716 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4717 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4718 (r_alloc_sbrk): Now static.
4719
a041960a
PE
4720 Improve ralloc.c interface checking.
4721 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4722 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4723 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4724 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4725 [REL_ALLOC]: ... to here, to check interface.
4726 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4727 Remove decls. This fixes an "It stinks!".
4728
9426aba4
PE
4729 * alloc.c (which_symbols): Fix alignment issue / type clash.
4730
d55c12ed
AS
47312012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4732
4733 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4734 (struct Lisp_Misc_Any): Likewise.
4735 (struct Lisp_Free): Likewise.
4736 * alloc.c (union aligned_Lisp_Symbol): Define.
4737 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4738 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4739 (union aligned_Lisp_Misc): Define.
4740 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4741 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4742 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4743
b948ce8b
PE
47442012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4745
4746 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4747 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4748 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4749 * s/netbsd.h, s/sol2-6.h:
4750 Remove definition of GC_MARK_STACK, since the default now works.
4751 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4752 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4753 no longer the default.
4754 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4755
35dc09a1 47562012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4757
35dc09a1
GM
4758 * lread.c (lisp_file_lexically_bound_p):
4759 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4760
35dc09a1
GM
47612012-04-14 Eli Zaretskii <eliz@gnu.org>
4762
4763 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4764 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4765
47662012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4767
4768 * nsterm.m (constrainFrameRect): Always constrain when there is only
4769 one screen (Bug#10962).
4770
bcd86815
KB
47712012-04-13 Ken Brown <kbrown@cornell.edu>
4772
4773 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4774
c25df26e
RT
47752012-04-13 Reuben Thomas <rrt@sc3d.org>
4776
4777 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4778
0fc59f1e
DC
47792012-04-11 Daniel Colascione <dancol@dancol.org>
4780
4781 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4782 against is gone. It's better to use vfork now so that when Cygwin
4783 gains a new, working vfork, we use it automatically (bug#10398).
4784
de8c03dc
SM
47852012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4786
4787 * window.c (save_window_save): Obey window-point-insertion-type.
4788
2f097256
GM
47892012-04-11 Glenn Morris <rgm@gnu.org>
4790
4791 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4792
453b951e
SM
47932012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4794
4795 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4796
75f1671a 47972012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4798
4799 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4800 (force_quit_count): New var.
4801 (handle_interrupt): Use it.
4802
2a8ce227
JB
48032012-04-10 Juanma Barranquero <lekktu@gmail.com>
4804
4805 * w32.c (w32_delayed_load): Record the full path of the library
4806 being loaded (bug#10424).
4807
935396c0
GM
48082012-04-09 Glenn Morris <rgm@gnu.org>
4809
05920a43
GM
4810 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4811 not just in the obarray, before snarfing them. (Bug#11036)
4812
935396c0
GM
4813 * Makefile.in ($(leimdir)/leim-list.el):
4814 Pass EMACS rather than BUILT_EMACS.
4815
a18ecafa
TZ
48162012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4817
4818 * process.c (make_process):
4819 * process.h: Add integer `gnutls_handshakes_tried' member to
4820 process struct.
4821
6bbef4e5
JC
4822 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4823 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4824
4825 * gnutls.c (gnutls_log_function2i): Convenience log function.
4826 (emacs_gnutls_read): Use new log functions,
4827 `gnutls_handshakes_tried' process member, and
4828 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4829 attempts per process (connection).
4830
b4d3bc10
CY
48312012-04-09 Chong Yidong <cyd@gnu.org>
4832
4833 * eval.c (Fuser_variable_p, user_variable_p_eh)
4834 (lisp_indirect_variable): Functions deleted.
4835 (Fdefvar): Caller changed.
4836
4837 * callint.c (Finteractive, Fcall_interactively):
4838 * minibuf.c (Fread_variable): Callers changed.
4839
70f4d973
EZ
48402012-04-09 Eli Zaretskii <eliz@gnu.org>
4841
4842 * xdisp.c (set_cursor_from_row): If the display string appears in
4843 the buffer at position that is closer to point than the position
4844 after the display string, display the cursor on the first glyph of
4845 the display string. Fixes cursor display when a 'display' text
4846 property immediately follows invisible text. (Bug#11094)
4847
cb3c2e3e
PE
48482012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4849
4850 composite.c: use 'double' consistently
4851 * composite.c (get_composition_id): Use 'double' consistently
4852 instead of converting 'float' to 'double' and vice versa; this is
4853 easier to understand and avoids a GCC warning.
4854
fd06db5d
GM
48552012-04-09 Glenn Morris <rgm@gnu.org>
4856
50fe702a
GM
4857 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4858 preparation for dumping it with emacs. (Bug#4789)
4859 (leimdir): New variable.
4860 ($(leimdir)/leim-list.el): New rule.
4861 (emacs$(EXEEXT)): Depend on leim-list.el.
4862
fd06db5d
GM
4863 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4864 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4865 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4866
55c131ee
AS
48672012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4868
4869 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4870 proper alignment.
4871
9209588f
JB
48722012-04-07 Juanma Barranquero <lekktu@gmail.com>
4873
4874 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4875 Remove unused local variable.
4876
e3fb2efb
PE
48772012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4878
4879 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4880 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4881 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4882 objects, as mark_maybe_pointer will catch them otherwise.
4883 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4884 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4885
b5385551
PE
48862012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4887
4888 Fix typo that broke non-Windows builds.
4889 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4890
9078ead6
EZ
48912012-04-07 Eli Zaretskii <eliz@gnu.org>
4892
4893 Support building on MS-Windows with libxml2.
4894
4895 * makefile.w32-in (OBJ2): Add xml.$(O).
4896 (GLOBAL_SOURCES): Add xml.c.
4897 ($(BLD)/xml.$(O)): New dependency list.
4898
4899 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4900 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4901 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4902 [!WINDOWSNT]: New macros.
4903 (init_libxml2_functions, libxml2_loaded_p): New functions.
4904 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4905 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4906 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4907 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4908 linked in).
6bbef4e5
JC
4909 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4910 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4911 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4912
4913 * emacs.c: Don't include libxml/parser.h.
4914 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4915 xmlCleanupParser directly.
4916
4917 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4918
3811fdf3
EZ
49192012-04-07 Eli Zaretskii <eliz@gnu.org>
4920
4921 * indent.c (Fvertical_motion): If there is a display string at
4922 point, use it.vpos to compute how many lines to backtrack after
4923 move_it_to point. (Bug#11133)
4924
2f8e16b2
EZ
49252012-04-06 Eli Zaretskii <eliz@gnu.org>
4926
4927 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4928 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4929 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4930 macros related to unification of CJK characters. For the details,
4931 see the discussion following the message here:
4932 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4933
3d439cd1
CY
49342012-04-04 Chong Yidong <cyd@gnu.org>
4935
4936 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4937
8bc53d00
EZ
49382012-04-01 Eli Zaretskii <eliz@gnu.org>
4939
4940 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4941 instead of alloca. (Bug#11138)
4942
3b0512a3
AS
49432012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4944
4945 * w32menu.c (is_simple_dialog): Properly check lisp types.
4946 (Bug#11141)
4947
8427ddd2
EZ
49482012-03-31 Eli Zaretskii <eliz@gnu.org>
4949
979022ef
EZ
4950 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4951 position we get to after a call to move_it_to fails the
4952 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4953 only if we wind up in a string from display property. (Bug#11063)
4954
a6b1c7cc
EZ
4955 * window.c (Fdelete_other_windows_internal): Invalidate the row
4956 and column information about mouse highlight, so that redisplay
4957 restores it after reallocating the glyph matrices. (Bug#7464)
4958
8427ddd2
EZ
4959 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4960 string comes from a `display' text property, use the buffer
4961 position of that property as if we actually saw that position in
4962 the row's glyphs.
697ba24b
EZ
4963 (move_it_by_lines): Remove the assertion that
4964 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4965 violated when there's a before-string at the beginning of a line.
4966 (Bug#11063)
8427ddd2 4967
65a0a738
EZ
49682012-03-30 Eli Zaretskii <eliz@gnu.org>
4969
4970 * xdisp.c (append_space_for_newline): If the default face was
4971 remapped, use the remapped face for the appended newline.
4972 (extend_face_to_end_of_line): Use the remapped default face for
4973 extending the face to the end of the line.
4974 (display_line): Call extend_face_to_end_of_line when the default
4975 face was remapped. (Bug#11068)
4976
581355cc
EZ
49772012-03-29 Eli Zaretskii <eliz@gnu.org>
4978
4979 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4980
e8fc049f
SM
49812012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4982
4983 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4984
4fb9a543
GM
49852012-03-27 Glenn Morris <rgm@gnu.org>
4986
4987 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4988 Doc fixes.
4989
679910f1
KH
49902012-03-26 Kenichi Handa <handa@m17n.org>
4991
4992 * dispextern.h (struct glyph): Fix previous change. Change the
4993 bit length of glyphless.ch to 25 (Bug#11082).
4994
90d49b7f
CY
49952012-03-26 Chong Yidong <cyd@gnu.org>
4996
4997 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4998 (command_loop_1): Use it; inhibit selection update for
4999 handle-select-window too (Bug#8996).
5000
f514f6f0
FP
50012012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5002
e8fc049f 5003 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5004
bf43fa51
KH
50052012-03-25 Kenichi Handa <handa@m17n.org>
5006
5007 * dispextern.h (struct glyph): Change the bit length of
5008 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5009
8a0c01dd
EZ
50102012-03-24 Eli Zaretskii <eliz@gnu.org>
5011
5012 * s/ms-w32.h (tzname): Include time.h before redirecting to
5013 _tzname. Fixes the MSVC build. (Bug#9960)
5014
7d1c3a76
AS
50152012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5016
8ed79523
AS
5017 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5018 characters.
5019
7d1c3a76
AS
5020 * xterm.c (XTread_socket): Only modify handling_signal if
5021 !SYNC_INPUT. (Bug#11080)
5022
e99a9b8b
EZ
50232012-03-23 Eli Zaretskii <eliz@gnu.org>
5024
5025 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5026 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5027 when fetching a multibyte character consumes more bytes than
5028 CHAR_BYTES returns, due to unification of CJK characters in
5029 string_char. (Bug#11073)
5030
5063c0e1
TN
50312012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5032
5033 * process.c (wait_reading_process_output): Handle pty disconnect
5034 by refraining from sending oneself a SIGCHLD (bug#10933).
5035
9f851fbd
CY
50362012-03-22 Chong Yidong <cyd@gnu.org>
5037
5038 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5039
5063c0e1 5040 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5041 Mark string as coming from a prefix property.
5042 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5043 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5044
fb5b8aca
CY
50452012-03-21 Chong Yidong <cyd@gnu.org>
5046
5047 * xfaces.c (Vface_remapping_alist): Doc fix.
5048
62356a1b
EZ
50492012-03-20 Eli Zaretskii <eliz@gnu.org>
5050
5051 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5052 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5053 Doc fixes.
62356a1b 5054
025de85b
CY
50552012-03-20 Chong Yidong <cyd@gnu.org>
5056
5057 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5058 to reflect default non-nil value of redisplay-dont-pause.
5059
4827f94e
KH
50602012-03-19 Kenichi Handa <handa@m17n.org>
5061
5062 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5063 it fit in a valid range (Bug#11003).
5064
e50a24a2
EZ
50652012-03-18 Eli Zaretskii <eliz@gnu.org>
5066
5067 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5068 that is not from display property, accept the row as a "cursor
5069 row" if one of the string's character has a non-nil `cursor'
5070 property. Fixes cursor positioning when there are newlines in
5071 overlay strings, e.g. in icomplete.el. (Bug#11035)
5072
9af5ed87
PE
50732012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5074
5075 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5076
d1f55f16
CY
50772012-03-12 Chong Yidong <cyd@gnu.org>
5078
5079 * eval.c (inhibit_lisp_code): Rename from
5080 inhibit_window_configuration_change_hook; move from window.c.
5081
5082 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5083 * window.c (run_window_configuration_change_hook)
5084 (syms_of_window): Callers changed.
5085
66c5eebd
CY
50862012-03-11 Chong Yidong <cyd@gnu.org>
5087
413df973
CY
5088 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5089
66c5eebd
CY
5090 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5091
1de11f56
CY
50922012-03-10 Chong Yidong <cyd@gnu.org>
5093
5094 * frame.c (other_visible_frames): Don't assume the selected frame
5095 is visible (Bug#10955).
5096
cae07000
SM
50972012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5098
5099 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5100
89c94350
JD
51012012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5102
5103 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5104 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5105 zero (Bug#10954).
5106
999dd333
GM
51072012-03-03 Glenn Morris <rgm@gnu.org>
5108
01a6dcc8 5109 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5110
de0100f2
EZ
51112012-03-02 Eli Zaretskii <eliz@gnu.org>
5112
5113 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5114 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5115 (redisplay_window, next_element_from_string): Fix typos in
5116 comments.
3e441275
EZ
5117 (redisplay_window): Pass to move_it_vertically the margin in
5118 pixels, not in screen lines.
de0100f2 5119
96a72ee9
GM
51202012-03-02 Glenn Morris <rgm@gnu.org>
5121
5122 * buffer.c (buffer-list-update-hook): Doc fix.
5123
312508d7
EZ
51242012-02-29 Eli Zaretskii <eliz@gnu.org>
5125
5126 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5127 push_it before setting up the iterator for the first overlay
5128 string, even if we have an empty string loaded.
5129 (next_overlay_string): If there's an empty string on the iterator
5130 stack, pop the stack. (Bug#10903)
5131
27f3c637
PE
51322012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5133
5134 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5135 Suggested by Stefan Monnier in
5136 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5137 * alloc.c (widen_to_Lisp_Object): New static function.
5138 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5139 and widening them to Lisp_Objects. This would work even if
5140 USE_LSB_TAG is defined and wide integers are used, which might
5141 happen in a future version of Emacs.
5142
3c9dfce6
CY
51432012-02-25 Chong Yidong <cyd@gnu.org>
5144
fa74b241
CY
5145 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5146 Doc fix.
5147
3c9dfce6
CY
5148 * xselect.c (Fx_selection_exists_p): Doc fix.
5149 (x_clipboard_manager_save_all): Print an informative message
5150 before saving to clipboard manager.
5151
9486df08
CY
51522012-02-24 Chong Yidong <cyd@gnu.org>
5153
5154 * keyboard.c (process_special_events): Handle all X selection
5155 requests in kbd_buffer, not just the next one (Bug#8869).
5156
f01d3321
CY
51572012-02-23 Chong Yidong <cyd@gnu.org>
5158
5159 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5160 call when setting menu-bar-lines and tool-bar-lines parameters.
5161 (unwind_create_frame_1): New helper function.
5162
5163 * window.c (inhibit_window_configuration_change_hook): New var.
5164 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5165 (syms_of_window): Initialize it.
f01d3321 5166
86b847b6
CY
51672012-02-22 Chong Yidong <cyd@gnu.org>
5168
5169 * xterm.c (x_draw_image_relief): Add missing type check for
5170 Vtool_bar_button_margin (Bug#10743).
5171
a59225b1
CY
51722012-02-21 Chong Yidong <cyd@gnu.org>
5173
5174 * fileio.c (Vfile_name_handler_alist): Doc fix.
5175
5176 * buffer.c (Fget_file_buffer): Protect against invalid file
5177 handler return value.
5178
310f5bd4
PE
51792012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5180
cb3a28cc
PE
5181 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5182 when computing $valmask.
5183
310f5bd4
PE
5184 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5185 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5186 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5187 It's useless in that case, and it can cause problems on hosts
5188 that allocate halves of EMACS_INT values separately.
5189 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5190 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5191 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5192 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5193 it avoids undefined behavior on hosts where shifting right by more
5194 than the word width has undefined behavior.
5195
2375c96a
CY
51962012-02-19 Chong Yidong <cyd@gnu.org>
5197
5198 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5199 (Funhandled_file_name_directory, Ffile_name_as_directory)
5200 (Fdirectory_file_name, Fexpand_file_name)
5201 (Fsubstitute_in_file_name): Protect against invalid file handler
5202 return values (Bug#10845).
5203
3eb49e71
EZ
52042012-02-18 Eli Zaretskii <eliz@gnu.org>
5205
5206 * .gdbinit (pitx): Fix incorrect references to fields of the
5207 iterator stack.
5208
7b926f3f
CY
52092012-02-17 Chong Yidong <cyd@gnu.org>
5210
5211 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5212
11273115
PE
52132012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5214
5215 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5216 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5217
c3a70e2b
CY
52182012-02-15 Chong Yidong <cyd@gnu.org>
5219
5220 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5221 marked as special. Also, starting docstrings with * is obsolete.
5222
0ca43699
AS
52232012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5224
5225 * gnutls.c (emacs_gnutls_write): Fix last change.
5226
2e8f3c56
LI
52272012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5228
5229 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5230 send_process.
5231
af70074f
SM
52322012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5233
5234 * keymap.c (Fsingle_key_description): Handle char ranges.
5235
95986d52
CY
52362012-02-12 Chong Yidong <cyd@gnu.org>
5237
afd83bd1
CY
5238 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5239 as that creates a dangerous corner case.
5240
95986d52
CY
5241 * window.c (Fdelete_window_internal): Invalidate the mouse
5242 highlight (Bug#9904).
5243
bd7da63e
GM
52442012-02-12 Glenn Morris <rgm@gnu.org>
5245
5246 * xselect.c (Fx_own_selection_internal)
5247 (Fx_get_selection_internal, Fx_disown_selection_internal)
5248 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5249 * nsselect.m (Fx_own_selection_internal)
5250 (Fx_disown_selection_internal, Fx_selection_exists_p)
5251 (Fx_selection_owner_p, Fx_get_selection_internal):
5252 Sync docs and argument specs with the xselect.c versions.
5253
77abcbc2
LI
52542012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5255
5256 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5257
90b671e2
EZ
52582012-02-11 Eli Zaretskii <eliz@gnu.org>
5259
1c0ca0b7
EZ
5260 * w32select.c (Fx_selection_exists_p): Sync doc string and
5261 argument list with xselect.c. (Bug#10783)
5262
5263 * w16select.c (Fx_selection_exists_p): Sync doc string and
5264 argument list with xselect.c. (Bug#10783)
90b671e2 5265
49241268
GM
52662012-02-10 Glenn Morris <rgm@gnu.org>
5267
5268 * fns.c (Fsecure_hash): Doc fix.
5269
f998bbe7 52702012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5271
5272 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5273
0992bd9c
CY
52742012-02-07 Chong Yidong <cyd@gnu.org>
5275
5276 * buffer.c (Fbuffer_local_variables)
5277 (buffer_lisp_local_variables): Handle unbound vars correctly;
5278 don't let Qunbound leak into Lisp.
5279
af008560
GM
52802012-02-07 Glenn Morris <rgm@gnu.org>
5281
dd605cc4
GM
5282 * image.c (Fimagemagick_types): Doc fix.
5283
af008560
GM
5284 * image.c (imagemagick-render-type): Change it from a lisp object
5285 to an integer. Move the doc here from the lisp manual.
5286 Treat all values not equal to 0 the same.
5287
1449fa1d
CY
52882012-02-06 Chong Yidong <cyd@gnu.org>
5289
5290 * doc.c (store_function_docstring): Avoid applying docstring of
5291 alias to base function (Bug#2603).
5292
3723ec07
AS
52932012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5294
5295 * .gdbinit (pp1, pv1): Remove redundant defines.
5296 (pr): Use pp.
5297
79c1cc1e
CY
52982012-02-04 Chong Yidong <cyd@gnu.org>
5299
5300 * nsterm.m: Declare a global (Bug#10694).
5301
d7f29f8e
EZ
53022012-02-04 Eli Zaretskii <eliz@gnu.org>
5303
cae07000
SM
5304 * w32.c (get_emacs_configuration_options):
5305 Include --enable-checking, if specified, in the return value.
d7f29f8e 5306
3b95a6f9
MR
53072012-02-04 Martin Rudalics <rudalics@gmx.at>
5308
5309 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5310 after rounding frame sizes. (Bug#9723)
5311
d6fa96a6
EZ
53122012-02-04 Eli Zaretskii <eliz@gnu.org>
5313
5314 * keyboard.c (adjust_point_for_property): Don't position point
5315 before BEGV. (Bug#10696)
5316
df0b2940
PE
53172012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5318
5319 Handle overflow when computing char display width (Bug#9496).
5320 * character.c (char_width): Return EMACS_INT, not int.
5321 (char_width, c_string_width): Check for overflow when
5322 computing the width; this is possible now that individual
5323 characters can have unbounded width. Problem introduced
5324 by merge from Emacs 23 on 2012-01-19.
5325
6bee44d6
MA
53262012-02-02 Michael Albinus <michael.albinus@gmx.de>
5327
5328 * dbusbind.c (Fdbus_register_method): Mention the return value
5329 :ignore in the docstring.
5330
44f92739
GM
53312012-02-02 Glenn Morris <rgm@gnu.org>
5332
1b9f60cc
GM
5333 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5334
44f92739
GM
5335 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5336 Unconditionally set to t. (Bug#10673)
5337 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5338 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5339 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5340
c5d3843c
KH
53412012-02-02 Kenichi Handa <handa@m17n.org>
5342
5343 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5344 0, do not call append_composite_glyph.
5345
159462d4 53462012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5347
5348 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5349 NULL (Bug#6988).
5350 (x_produce_glyphs): If the component of a composition is a null
5351 string, set it->pixel_width to 1 to avoid zero-width glyph.
5352
78cef877
EZ
53532012-02-01 Eli Zaretskii <eliz@gnu.org>
5354
5355 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5356 first 2 arguments are identical. This makes inserting large
5357 output from a subprocess an order of magnitude faster on
5358 MS-Windows, where all sbrk'ed memory is always contiguous.
5359
97897668
GM
53602012-01-31 Glenn Morris <rgm@gnu.org>
5361
5362 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5363 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5364 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5365
31fd3586
GM
53662012-01-29 Glenn Morris <rgm@gnu.org>
5367
5368 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5369
0e24a8b2
CY
53702012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5371
5372 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5373
cc0adcb0
CY
53742012-01-28 Chong Yidong <cyd@gnu.org>
5375
5376 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5377
acc28cb9
CY
53782012-01-26 Chong Yidong <cyd@gnu.org>
5379
9c69cfb7
CY
5380 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5381
acc28cb9
CY
5382 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5383 repeat counts (Bug#10507).
5384
48da7392
GM
53852012-01-26 Glenn Morris <rgm@gnu.org>
5386
5387 * lread.c (syms_of_lread): Doc fix.
5388
14af5f7f
CY
53892012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5390
5391 * coding.c (encode_designation_at_bol): Change return value to
5392 EMACS_INT.
5393
0b21c100
CY
53942012-01-25 Chong Yidong <cyd@gnu.org>
5395
5396 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5397
3c2907f7
CY
53982012-01-21 Chong Yidong <cyd@gnu.org>
5399
5400 * floatfns.c (Fcopysign): Make the second argument non-optional,
5401 since nil is not allowed anyway.
5402
959ad23f
AS
54032012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5404
5405 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5406 (send_process): Likewise.
5407
34a02f46
MR
54082012-01-19 Martin Rudalics <rudalics@gmx.at>
5409
5410 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5411 (Vwindow_persistent_parameters): Do not use Qstate.
5412 Rewrite doc-strings.
34a02f46 5413
1259009a 54142012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5415
5416 * character.c (char_width): New function.
70d4fdf6
GM
5417 (Fchar_width, c_string_width, lisp_string_width):
5418 Use char_width (Bug#9496).
25ed9e61 5419
6a6ee00d
MR
54202012-01-16 Martin Rudalics <rudalics@gmx.at>
5421
5422 * window.c (Vwindow_persistent_parameters): New variable.
5423 (Fset_window_configuration, save_window_save): Handle persistent
5424 window parameters.
5425
c85efaf7
EZ
54262012-01-14 Eli Zaretskii <eliz@gnu.org>
5427
5428 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5429 thrashing the stack of the thread. (Bug#9087)
5430
5944709e
PE
54312012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5432
5433 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5434
e71f5d99
EZ
54352012-01-11 Eli Zaretskii <eliz@gnu.org>
5436
5437 * xdisp.c (rows_from_pos_range): Handle the case where the
5438 highlight ends on a newline. (Bug#10464)
5439 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5440 he end column for display of highlight that ends on a newline
5441 before a R2L line.
5442
ce316182
GM
54432012-01-11 Glenn Morris <rgm@gnu.org>
5444
5445 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5446 from load-path also when installation-directory is nil. (Bug#10208)
5447
5b43da69
GM
54482012-01-10 Glenn Morris <rgm@gnu.org>
5449
74cc8ff9
GM
5450 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5451
7d8d6e4e
GM
5452 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5453 Update template values to be closer to their typical values these days.
5b43da69 5454
a0db8d43
EZ
54552012-01-09 Eli Zaretskii <eliz@gnu.org>
5456
5457 * xdisp.c (rows_from_pos_range): Accept additional argument
5458 DISP_STRING, and accept any glyph in a row whose object is that
5459 string as eligible for mouse highlight. Fixes mouse highlight of
5460 display strings from overlays. (Bug#10464)
5461
9a0115ab 54622012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5463
b9110d6a 5464 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5465 * fileio.c (auto_saving_dir_umask): New static var.
5466 (Fmake_directory_internal): Use it.
5467 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5468 creating the directory. The old code temporarily assigns
5469 too-generous permissions to the directory.
5470 (do_auto_save_eh): Clear it.
b9110d6a 5471 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5472 that the var is always cleared.
5473
6c1bd3f3
EZ
54742012-01-07 Eli Zaretskii <eliz@gnu.org>
5475
5476 * search.c (scan_buffer): Pass character positions to
5477 know_region_cache, not byte positions. (Bug#6540)
5478
069d2b50
L
54792012-01-07 LynX <_LynX@bk.ru> (tiny change)
5480
5481 * w32.c (sys_rename): Report EXDEV when rename of a directory
5482 fails because the target is on another logical disk. (Bug#10284)
5483
75bf0d33
DB
54842012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5485
5486 * xterm.c (x_embed_request_focus): New function.
5487
5488 * xterm.h: Add prototype.
5489
5490 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5491
1c6e5a32
GM
54922012-01-05 Glenn Morris <rgm@gnu.org>
5493
5494 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5495
651e947e
EZ
54962012-01-01 Eli Zaretskii <eliz@gnu.org>
5497
5498 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5499 Load gnutls_transport_set_lowat only if GnuTLS version is below
5500 2.11.1.
5501 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5502 GnuTLS versions below 2.11.1.
5503
3778cdd8
AL
55042011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5505
5506 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5507 to the doc string advising against its use for altering the way
5508 windows are scrolled.
5509
0e5317f7
KH
55102011-12-28 Kenichi Handa <handa@m17n.org>
5511
5512 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5513 coding-system ASCII compatible only when it does not produce BOM
5514 on encoding (Bug#10383).
5515
93d5ca1f
JD
55162011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5517
5518 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5519 can scroll.
5520 (create_and_show_popup_menu): Always use menu_position_func for
5521 Gtk3 (Bug#10361).
5522
ca22b785
AS
55232011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5524
5525 * callint.c (Fcall_interactively): Don't truncate prompt string.
5526
d048e1e6
EZ
55272011-12-23 Eli Zaretskii <eliz@gnu.org>
5528
5529 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5530 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5531 resumed from there (after widening). (Bug#10360)
d048e1e6 5532
5ccaba1f
JD
55332011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5534
5535 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5536
204ee57f
JD
55372011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5538
b81d40f0
JB
5539 * nsterm.m (x_free_frame_resources):
5540 Release f->output_data.ns->miniimage.
204ee57f
JD
5541 (ns_index_color): Fix indentation. Do not retain
5542 color_table->colors[i].
5543
5544 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5545 before returning.
5546
5547 * nsfns.m (x_set_background_color): Assign return value from
5548 ns_index_color to face-background instead of NSColor*.
5549 (ns_implicitly_set_icon_type): Fix indentation.
5550 Change assignment in for loop to comparison.
5551
5552 * emacs.c (ns_pool): New variable.
5553 (main): Assign ns_pool.
5554 (Fkill_emacs): Call ns_release_autorelease_pool.
5555
5556 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5557 autorelease fdesc, release fdAttrs and tdict.
5558 (ns_get_covering_families): Release charset.
5559 (ns_findfonts): Release NSFontDescriptor created with new.
5560 (ns_uni_to_glyphs): Fix indentation.
5561 (setString): Release attrStr before assigning new value.
5562
c803b2b7
JD
55632011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5564
678f4426
JD
5565 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5566 and NS_IMPL_COCOA.
5567 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5568 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5569
cd394be1 55702011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5571
5fecd5fc
JD
5572 * nsterm.m (ns_term_init): Subscribe for notifications
5573 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5574 to method trackingNotification in EmacsMenu.
5575
5576 * nsmenu.m (trackingMenu): New variable.
3771cb17 5577 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5578 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5579 from Aquamacs (Bug#7030).
678f4426
JD
5580
55812011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5582
c803b2b7
JD
5583 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5584 (symbol_to_nsstring): Fix indentation.
5585 (ns_symbol_to_pb): New function.
cae07000
SM
5586 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5587 (Fns_rotate_cut_buffers_internal): Remove.
5588 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5589 Fns_store_cut_buffer_internal.
5590 (ns_get_foreign_selection, Fx_own_selection_internal)
5591 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5592 (Fns_get_selection_internal, Fns_store_selection_internal):
5593 Use ns_symbol_to_pb and check if return value is nil.
5594 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5595 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5596 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5597 renamed to Sns_store_selection_internal.
5598 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5599 and remove this function.
5600 (ns_handle_selection_clear): Remove, never used.
5601 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5602 here.
5603
e1b01a3a
KB
56042011-12-17 Ken Brown <kbrown@cornell.edu>
5605
5606 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5607 GID is unknown (Bug#10257).
5608
2adb6e85
PE
56092011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5610
5611 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5612 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5613 which caused a build failure on GNU/Linux IA-64. This problem was
5614 introduced by my 2011-10-07 patch.
5615
d1d7b339
JL
56162011-12-15 Juri Linkov <juri@jurta.org>
5617
5618 * image.c (imagemagick_error): New function. (Bug#10112)
5619 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5620 Use `imagemagick_error' where ImageMagick functions return
5621 `MagickFalse'.
5622 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5623 proper order.
5624
100d5755
KH
56252011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5626
5627 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5628 fill background (Bug#8992).
5629
454592a6
MR
56302011-12-13 Martin Rudalics <rudalics@gmx.at>
5631
5632 * window.c (Vwindow_combination_resize)
5633 (Vwindow_combination_limit): Use t instead of non-nil in
5634 doc-strings.
61d4b438
MR
5635 (Vrecenter_redisplay): Add first sentence of doc-string on
5636 separate line.
53524d93 5637 (Frecenter): Fix doc-string typo.
454592a6 5638
3633e3aa
KH
56392011-12-11 Kenichi Handa <handa@m17n.org>
5640
5641 * coding.c (Funencodable_char_position): Pay attention to the
5642 buffer text relocation (Bug#9389).
5643
7b9d523a 56442011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5645
7b9d523a
JD
5646 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5647 gtk_init (Bug#10100).
5648
b73189c6
EZ
56492011-12-10 Eli Zaretskii <eliz@gnu.org>
5650
5651 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5652 IT->string is nil. (Bug#10263)
5653
f7dfe5d6
JD
56542011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5655
83faebb4
JD
5656 * nsterm.h (x_free_frame_resources): Declare.
5657
f7dfe5d6
JD
5658 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5659 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5660
5661 * nsterm.h (ns_get_defaults_value): Declare.
5662
5663 * nsterm.m (ns_default): Call ns_get_defaults_value.
5664
7cd4e72c
EZ
56652011-12-09 Eli Zaretskii <eliz@gnu.org>
5666
5667 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5668 (Bug#10170)
5669
b34d7317
YM
56702011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5671
5672 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5673 that where the value of an _OBJC_* symbol points to is in the .bss
5674 section (Bug#10240).
5675
76470ad1
KH
56762011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5677
5678 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5679 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5680
745fff94
KH
56812011-12-08 Kenichi Handa <handa@m17n.org>
5682
5683 * ftfont.c (get_adstyle_property): Fix previous change
5684 (Bug#10233).
5685
6e44397c
JB
56862011-12-07 Juanma Barranquero <lekktu@gmail.com>
5687
5688 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5689 dirs from the default value of EMACSLOADPATH (bug#10208).
5690
7efa6272
GM
56912011-12-07 Glenn Morris <rgm@gnu.org>
5692
5693 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5694 installation and source directories as well. (Bug#10208)
5695
f6fc4d87
CY
56962011-12-06 Chong Yidong <cyd@gnu.org>
5697
5698 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5699
2bf26180
GM
57002011-12-06 Glenn Morris <rgm@gnu.org>
5701
5702 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5703 as an error, not just -1. (Bug#10217)
5704
3a6ad4f0
CY
57052011-12-05 Chong Yidong <cyd@gnu.org>
5706
5707 * keyboard.c (process_special_events): New function.
5708 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5709
75a3b399
PE
57102011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5711
5712 * coding.c (encode_designation_at_bol): Don't use uninitialized
5713 local variable (Bug#9318).
5714
c3c9e25e
KH
57152011-12-05 Kenichi Handa <handa@m17n.org>
5716
5717 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5718 return Qnil (Bug#8046, Bug#10193).
5719
5eb05ea3
KH
57202011-12-05 Kenichi Handa <handa@m17n.org>
5721
5722 * coding.c (encode_designation_at_bol): New args charbuf_end and
5723 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5724 (coding_set_source): Return how many bytes coding->source was
5725 relocated.
5726 (coding_set_destination): Return how many bytes
5727 coding->destination was relocated.
5728 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5729 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5730
57312011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5732
5733 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5734 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5735 macro (Bug#9318).
5736
57372011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5738
5739 The following changes are to fix Bug#9318.
5740
a79703f5 5741 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5742 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5743 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5744 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5745
7dbda6df
JB
57462011-12-05 Juanma Barranquero <lekktu@gmail.com>
5747
5748 * lisp.h (process_quit_flag): Fix external declaration.
5749
6d5eb5b0
SM
57502011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5751
5752 Don't macro-inline non-performance-critical code.
5753 * eval.c (process_quit_flag): New function.
5754 * lisp.h (QUIT): Use it.
5755
a0c3fad0
JD
57562011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5757
5758 * nsfns.m (get_geometry_from_preferences): New function.
5759 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5760
6c07aac2
AS
57612011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5762
5763 * emacs.c (Qkill_emacs): Define.
5764 (syms_of_emacs): Initialize it.
5765 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5766 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5767 (quit_throw_to_read_char): Add parameter `from_signal'.
5768 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5769 * lisp.h (QUIT): Call Fkill_emacs if requested.
5770
c052ead4
JD
57712011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5772
5773 * widget.c (update_wm_hints): Return if wmshell is null.
5774 (widget_update_wm_size_hints): New function.
5775
5776 * widget.h (widget_update_wm_size_hints): Declare.
5777
5778 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5779 widget_update_wm_size_hints (Bug#10104).
5780
9e49252b
EZ
57812011-12-03 Eli Zaretskii <eliz@gnu.org>
5782
5783 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5784 before a newline, prepare the bidi iterator for consuming the
5785 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5786 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5787
02b16839
JL
57882011-12-02 Juri Linkov <juri@jurta.org>
5789
5790 * search.c (Fword_search_regexp): New Lisp function created from
5791 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5792 (Fword_search_backward, Fword_search_forward)
5793 (Fword_search_backward_lax, Fword_search_forward_lax):
5794 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5795 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5796
0068070e
SM
57972011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5798
5799 * fileio.c (Finsert_file_contents): Move after-change-function call
5800 to before the "handled:" label, since all "goto handled" appear in
5801 cases where the *-change-functions have already been properly called
5802 (bug#10117).
5803
3360a3fc
AS
58042011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5805
5806 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5807 waiting for input. (Bug#10169)
5808
73d6c093
EZ
58092011-11-30 Eli Zaretskii <eliz@gnu.org>
5810
5811 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5812 verifies glyph row's hash code--we have just reallocated the
5813 glyphs, so their contents can be complete garbage. (Bug#10164)
5814
febe6bea
JB
58152011-11-30 Juanma Barranquero <lekktu@gmail.com>
5816
5817 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5818
801a4313
EZ
58192011-11-30 Eli Zaretskii <eliz@gnu.org>
5820
5821 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5822 attributes are tested _before_ calling verify_row_hash, to protect
5823 against GCC re-ordering of the tests. (Bug#10164)
5824
2b56b87e
JD
58252011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5826
5827 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5828
5829 * xterm.c (handle_one_xevent): Only set async_visible and friends
5830 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5831 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5832 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5833
dbf31225
PE
58342011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5835
5836 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5837 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5838 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5839 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5840 All uses changed to use GCPRO1 etc.
5841 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5842 Revert to old implementation (i.e., before 2011-03-11).
5843
1305621b
YM
58442011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5845
5846 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5847 of scroll runs so as to avoid assigning disabled bogus rows and
5848 unnecessary graphics copy operations.
5849
8c9afb46
EZ
58502011-11-27 Eli Zaretskii <eliz@gnu.org>
5851
5852 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5853 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5854 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5855 (malloc, free, realloc, calloc): Redirect to e_* only when
5856 compiling Emacs.
5857
5858 * lisp.h (GCTYPEBITS): Move before first use.
5859 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5860 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5861 this macro definition.
5862
5863 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5864 _MSC_VER.
5865
54e9e3bf
JD
58662011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5867
6d5eb5b0
SM
5868 * gtkutil.c (xg_create_frame_widgets):
5869 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5870 present with Gtk+ 2.0.
5871
83aca1cb
PE
58722011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5873
5874 * fileio.c (Finsert_file_contents): Undo previous change; see
5875 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5876
5b76caa4
PE
58772011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5878
5879 Rename locals to avoid shadowing.
5880 * fileio.c (Finsert_file_contents):
5881 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5882 * process.c (wait_reading_process_output):
5883 Rename inner 'proc' to 'p' to avoid shadowing.
5884 Indent for consistency with usual Emacs style.
5885
8c535114
EZ
58862011-11-25 Eli Zaretskii <eliz@gnu.org>
5887
5888 * xdisp.c (redisplay_window): If cursor row is not fully visible
5889 after recentering, and scroll-conservatively is set to a large
5890 number, scroll window by a few more lines to make the cursor fully
5891 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5892 (start_display): Don't move to the next line if the display should
5893 start at a newline that is part of a display vector or an overlay
5894 string. (Bug#10119)
8c535114 5895
fa4fdb5c
JL
58962011-11-24 Juri Linkov <juri@jurta.org>
5897
5898 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5899 after the `MagickPingImage' call. (Bug#10112)
5900
90ec88df
CY
59012011-11-23 Chong Yidong <cyd@gnu.org>
5902
5903 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5904
56e2e794
MR
59052011-11-23 Martin Rudalics <rudalics@gmx.at>
5906
5907 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5908 making another buffer current. (Bug#10114)
5909
b6e64c41
GM
59102011-11-23 Glenn Morris <rgm@gnu.org>
5911
5912 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5913
6b21de18
CY
59142011-11-23 Chong Yidong <cyd@gnu.org>
5915
5916 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5917 using it (Bug#5984).
5918
b12cd789
EZ
59192011-11-22 Eli Zaretskii <eliz@gnu.org>
5920
5921 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5922 and header-lines, as they don't have one computed for them.
5923 (Bug#10098)
5924
5925 * .gdbinit (prow): Make displayed values more self-explaining.
5926 Add row's hash code.
5927
261b6fd4
LMI
59282011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5929
5930 * process.c (wait_reading_process_output): Fix asynchrounous
5931 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5932 (wait_reading_process_output): Add comment and URL.
261b6fd4 5933
e7cfd277
JD
59342011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5935
5936 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5937
a9b9b7f5
CY
59382011-11-21 Chong Yidong <cyd@gnu.org>
5939
5940 * window.c (Fnext_window, Fprevious_window): Doc fix.
5941
b0d15b4f
SM
59422011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5943
5944 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5945
fe7a3057
JB
59462011-11-20 Juanma Barranquero <lekktu@gmail.com>
5947
5948 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5949
d2999b1a
MR
59502011-11-20 Martin Rudalics <rudalics@gmx.at>
5951
5952 * window.c (Fset_window_combination_limit): Rename argument
5953 STATUS to LIMIT.
5954 (Vwindow_combination_limit): Remove "status" from doc-string.
5955
d5ff9cd0
AS
59562011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5957
5958 * m/ibms390.h: Remove.
5959 * m/ibms390x.h: Don't include "ibms390.h".
5960
a5bb9bd3
SM
59612011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5962
5963 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5964 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5965
cd1181db
JB
59662011-11-20 Juanma Barranquero <lekktu@gmail.com>
5967
5968 * casetab.c (Fset_case_table):
5969 * charset.c (Fcharset_after): Fix typos.
5970
615a3b8d 59712011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5972
17e845af
PE
5973 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5974 Otherwise, valgrind does not work on some platforms.
5975 Problem reported by Andreas Schwab in
6a0bf43d
PE
5976 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5977 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5978 is set, removing the need for VIRT_ADDRESS_VARIES.
5979 (PURE_P): Use a more-efficient implementation that needs just one
5980 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5981 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5982 to 4 (xorl, subq, cmpq, setbe).
5983 * alloc.c (pure): Always extern now, since that's the
5984 VIRT_ADDR_VARIES behavior.
5985 (PURE_POINTER_P): Use a single comparison, not two, for
5986 consistency with the new puresize.h.
5987 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5988 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5989 Remove VIRT_ADDR_VARIES no longer needed.
5990
f8fe6f96
EZ
59912011-11-19 Eli Zaretskii <eliz@gnu.org>
5992
5993 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5994 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5995 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5996 behave as if the cursor position were at the window margin.
5997
5998 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5999 and the cursor position is out of bounds, behave as if the cursor
6000 position were at the window margin. (Bug#10075)
6001
df05a53c
CY
60022011-11-18 Chong Yidong <cyd@gnu.org>
6003
6004 * window.c (Fwindow_combination_limit): Make first argument
6005 non-optional, since it is meaningless for live windows like the
6006 selected window.
61ccba97 6007
2071918e
DA
60082011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6009
6010 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6011
b50a28de
SM
60122011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6013
6014 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6015 (graft_intervals_into_buffer): Simplify.
6016
015137db
EZ
60172011-11-18 Eli Zaretskii <eliz@gnu.org>
6018
6019 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6020 hash values of the two rows.
6021 (copy_row_except_pointers): Preserve the used[] arrays and the
6022 hash values of the two rows. (Bug#10035)
68c95424 6023 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6024
6025 * xdisp.c (row_hash): New function, body extracted from
6026 compute_line_metrics.
6027 (compute_line_metrics): Call row_hash, instead of computing the
6028 hash code inline.
6029
6030 * dispnew.c (verify_row_hash): Call row_hash for computing the
6031 hash code of a row, instead of duplicating code from xdisp.c.
6032
6033 * dispextern.h (row_hash): Add prototype.
6034
a2addb04
TH
60352011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6036
6037 * frame.c (delete_frame): Don't delete the terminal when the last
6038 X frame is closed if emacs is built with GTK toolkit.
6039
df85d315
JB
60402011-11-17 Juanma Barranquero <lekktu@gmail.com>
6041
6042 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6043
a0c2d0ae
MR
60442011-11-17 Martin Rudalics <rudalics@gmx.at>
6045
6046 * window.c (Vwindow_splits): Rename to
6047 Vwindow_combination_resize. Suggested by Juri Linkov.
6048 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6049 of Vwindow_splits.
6050
58179cce
JB
60512011-11-16 Juanma Barranquero <lekktu@gmail.com>
6052
7877f373
JB
6053 * nsfns.m (Fns_font_name):
6054 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6055
b6f67890
MR
60562011-11-16 Martin Rudalics <rudalics@gmx.at>
6057
6058 * window.h (window): Rename slot "nest" to "combination_limit".
6059 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6060 (Fset_window_nest): Rename to Fset_window_combination_limit.
6061 (Vwindow_nest): Rename to Vwindow_combination_limit.
6062 (recombine_windows, make_parent_window, make_window)
6063 (Fsplit_window_internal, saved_window)
6064 (Fset_window_configuration, save_window_save): Rename all
6065 occurrences of window_nest to window_combination_limit.
6066
c7015153
JB
60672011-11-15 Juanma Barranquero <lekktu@gmail.com>
6068
6069 * image.c (imagemagick_load_image): Fix typo.
6070
322ad6ec
EZ
60712011-11-14 Eli Zaretskii <eliz@gnu.org>
6072
6073 * xdisp.c (display_line): Move the call to
6074 highlight_trailing_whitespace before the call to
6075 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6076 faces of all the glyphs to compute ROW's hash value.
6077 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6078
f067b8ec
JB
60792011-11-14 Juanma Barranquero <lekktu@gmail.com>
6080
6081 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6082 just return (bug#10044).
6083
1e5b2111
EZ
60842011-11-12 Eli Zaretskii <eliz@gnu.org>
6085
7ef3cbd5
EZ
6086 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6087 with user-defined heap size. Bump the default size of the temacs
6088 heap to 27MB, to avoid memory warning when running temacs.
6089 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6090
1e5b2111
EZ
6091 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6092 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6093 (verify_row_hash) [XASSERTS]: New function.
6094 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6095 that the hash value of glyph rows is correct.
1e5b2111 6096
89d61221
MR
60972011-11-12 Martin Rudalics <rudalics@gmx.at>
6098
6099 * window.h (window): Remove splits slot.
6100 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6101 (Fdelete_other_windows_internal, make_parent_window)
6102 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6103 (Fset_window_configuration, save_window_save): Don't deal with
6104 split status of windows.
6105 (saved_window): Remove splits slot.
6106 (Vwindow_splits): Rewrite doc-string.
6107
97f18cc8
JD
61082011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6109
6110 * xfns.c (unwind_create_frame):
6111 * nsfns.m (unwind_create_frame):
6112 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6113 Vframe_list (Bug#9999).
6114
22a648b4
DA
61152011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6116
0b381c7e 6117 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6118
659afede
KH
61192011-11-11 Kenichi Handa <handa@m17n.org>
6120
6121 * callproc.c (Fcall_process): Set the member dst_multibyte of
6122 process_coding.
6123
9ac0394b
KH
61242011-11-11 Johan Bockgård <bojohan@gnu.org>
6125
6126 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6127 avoid a crash (bug#9496).
6128
2fbdc249
CY
61292011-11-09 Chong Yidong <cyd@gnu.org>
6130
6131 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6132 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6133
ac6b1f81
PE
61342011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6135
6136 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6137
09db192c
PE
61382011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6139
6140 Avoid some portability problems by eschewing 'extern inline' functions.
6141 The trivial performance wins aren't worth the portability hassles; see
6142 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6143 et seq.
6144 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6145 (window_box_width, window_box_left, window_box_left_offset)
6146 (window_box_right, window_box_right_offset): Undo previous change,
6147 by removing the "extern"s.
6148 * intervals.c (adjust_intervals_for_insertion)
6149 (adjust_intervals_for_deletion): Undo previous change,
6150 making these static again.
6151 (offset_intervals, temp_set_point_both, temp_set_point)
6152 (copy_intervals_to_string): No longer inline.
6153 * xdisp.c (window_text_bottom_y, window_box_width)
6154 (window_box_height, window_box_left_offset)
6155 (window_box_right_offset, window_box_left, window_box_right)
6156 (window_box): No longer inline.
6157
105216ed
CY
61582011-11-08 Chong Yidong <cyd@gnu.org>
6159
6160 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6161 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6162 Signal an error if not a live window.
105216ed
CY
6163 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6164 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6165
ae9e237f
JB
61662011-11-07 Juanma Barranquero <lekktu@gmail.com>
6167
6168 * lisp.h (syms_of_abbrev): Remove declaration.
6169 Reported by CHENG Gao <chenggao@royau.me>.
6170
c7aa8333
EZ
61712011-11-07 Eli Zaretskii <eliz@gnu.org>
6172
6173 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6174 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6175 of temacs in GUI mode.
6176
be7f5545
MR
61772011-11-07 Martin Rudalics <rudalics@gmx.at>
6178
6179 * window.h: Declare delete_all_child_windows instead of
6180 delete_all_subwindows.
6181 * window.c (Fwindow_nest, Fset_window_nest)
6182 (Fset_window_new_total, Fset_window_new_normal)
6183 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6184 (delete_all_subwindows): Rename to delete_all_child_windows.
6185 (Fdelete_other_windows_internal, Fset_window_configuration):
6186 Call delete_all_child_windows instead of delete_all_subwindows.
6187 * frame.c (delete_frame): Call delete_all_child_windows instead
6188 of delete_all_subwindows.
6189
ca78dc43
PE
61902011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6191
6192 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6193 This is also needed for porting to any host where GC_MARK_STACK is
6194 not GC_MAKE_GCPROS_NOOPS.
6195 (which_symbols): Use it.
6196
a0241d01
KH
61972011-11-07 Kenichi Handa <handa@m17n.org>
6198
6199 * coding.c (coding_set_destination): Check coding->src_pos only
6200 when coding->src_object is a buffer (bug#9910).
6201
6202 * process.c (send_process): Set the member src_multibyte of coding
6203 to 0 (bug#9911) when sending a unibyte text.
6204
6205 * callproc.c (Fcall_process): Set the member src_multibyte of
6206 process_coding to 0 (bug#9912).
6207
a64bfdfa 62082011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6209
6210 * xmenu.c (cleanup_widget_value_tree): New function.
6211 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6212 calling free_menubar_widget_value_tree directly (Bug#9830).
6213
cb41b32a
PE
62142011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6215
6216 Fix some portability problems with 'inline'.
6217 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6218 (window_box_width, window_box_left, window_box_left_offset)
6219 (window_box_right, window_box_right_offset): Declare extern.
6220 Otherwise, these inline functions do not conform to C99 and
6221 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6222 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6223 * intervals.c (adjust_intervals_for_insertion)
6224 (adjust_intervals_for_deletion): Now extern, because otherwise the
6225 extern inline functions 'offset_intervals' couldn't refer to it.
6226 (static_offset_intervals): Remove.
6227 (offset_intervals): Rewrite using the old contents of
6228 static_offset_intervals. The old version didn't conform to C99
6229 because an extern inline function contained a reference to an
6230 identifier with static linkage.
6231
b7041366
AS
62322011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6233
6234 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6235 GC.
6236
88a37c4d
EZ
62372011-11-06 Eli Zaretskii <eliz@gnu.org>
6238
6239 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6240 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6241 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6242 return Qleft_to_right.
6243
49745b39
CY
62442011-11-06 Chong Yidong <cyd@gnu.org>
6245
6246 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6247 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6248 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6249 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6250 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6251 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6252 (Fwindow_vscroll): Doc fix.
6253 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6254 argument, since it makes no sense to pass a live window and for
6255 consistency with window-child.
6256
1f05cd82
CS
62572011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6258
6259 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6260 support MSVC.
6261
22610910
JR
62622011-11-05 Jason Rumney <jasonr@gnu.org>
6263
6264 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6265 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6266 fonts (Bug#6029).
6267 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6268 bitwise arithmetic preventing use of unicode-sip and non-truetype
6269 opentype fonts.
6270
a06776b2
EZ
62712011-11-05 Eli Zaretskii <eliz@gnu.org>
6272
3ad924ba
EZ
6273 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6274 "emacs"-only part.
6275
a06776b2
EZ
6276 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6277 initialization code to keep similarity to xfns.c after changes
6278 from 2011-11-05.
6279
c9e7db78
JD
62802011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6281
a97f8f3f
JD
6282 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6283 (unwind_create_frame): New function (Bug#9943).
6284 (Fx_create_frame): Restructure code to be more similar to the one in
6285 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6286 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6287 Move terminal->reference_count++ just before making the frame official
6288 (Bug#9943).
6289
6290 * nsterm.m (x_free_frame_resources): New function.
6291 (x_destroy_window): Move code to x_free_frame_resources.
6292
c9e7db78 6293 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6294 (Fx_create_frame, x_create_tip_frame):
6295 Move terminal->reference_count++ just before making the frame
75f1671a 6296 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6297 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6298
a6fc3b5c
EZ
62992011-11-05 Eli Zaretskii <eliz@gnu.org>
6300
6301 Support MSVC build with newer versions of Visual Studio.
6302 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6303 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6304 nt/gmake.defs.
6305
6306 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6307 which are not supported by MSVC.
6308 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6309 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6310 bitfields.
6311 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6312 types in bitfields.
6313 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6314
6315 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6316
58179cce 63172011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6318
6319 Support MSVC build with newer versions of Visual Studio.
6320 * w32.c: Don't include w32api.h for MSVC.
6321 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6322
6323 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6324 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6325 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6326 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6327 e_* cousins.
6328 (alloca) [_MSC_VER]: Define to _alloca.
6329
6330 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6331
6332 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6333
a58c13ed
EZ
63342011-11-04 Eli Zaretskii <eliz@gnu.org>
6335
6336 * xdisp.c (note_mouse_highlight): If either of
6337 previous/next-single-property-change returns nil, treat that as
6338 the beginning or the end of the buffer. (Bug#9955)
6339
fe0b6370
JD
63402011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6341
a58c13ed 6342 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6343 label is not null (Bug#9951).
6344 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6345 may be NULL.
6346
89bd5ee1
EZ
63472011-11-04 Eli Zaretskii <eliz@gnu.org>
6348
6349 * window.c (Fwindow_body_size): Mention in the doc string that the
6350 return value is in frame's canonical units. (Bug#9949)
6351
84c3edb9
EZ
63522011-11-03 Eli Zaretskii <eliz@gnu.org>
6353
4e2fb5c7
EZ
6354 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6355
84c3edb9 6356 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6357 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6358 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6359
bc17a887
EZ
63602011-11-01 Eli Zaretskii <eliz@gnu.org>
6361
6362 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6363 Don't stop backward scan on the continuation glyph, even though
6364 its CHARPOS is positive.
6d5eb5b0
SM
6365 (mouse_face_from_buffer_pos, note_mouse_highlight):
6366 Rename cover_string to disp_string.
bc17a887 6367
4ee88440
MR
63682011-11-01 Martin Rudalics <rudalics@gmx.at>
6369
6370 * window.c (temp_output_buffer_show): Don't use
6371 Vtemp_buffer_show_specifiers.
6372 (Vtemp_buffer_show_specifiers): Remove unused variable.
6373
c2ff3c02
EZ
63742011-10-30 Eli Zaretskii <eliz@gnu.org>
6375
6376 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6377 past the beginning of the current glyph matrix.
6378
58179cce 63792011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6380
6381 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6382 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6383 HAVE_GTK3 (Bug#9869).
b77a6a7f 6384
3b574623
JD
6385 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6386 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6387
b77a6a7f
JD
6388 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6389
6390 * xterm.c: Declare x_handle_net_wm_state to return int.
6391 (handle_one_xevent): Check if we are iconified but don't have
6392 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6393 (get_current_wm_state): Return non-zero if not hidden,
6394 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6395 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6396 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6397 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6398
196e41e4
PE
63992011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6400
6401 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6402 so that this new function doesn't get optimized away by a
6403 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6404
021f2e1a
AS
64052011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6406
6407 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6408
8b058d44
EZ
64092011-10-29 Eli Zaretskii <eliz@gnu.org>
6410
6411 Fix the `xbytecode' command.
6412 * .gdbinit (xprintbytestr): New command.
b50a28de 6413 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6414 (xbytecode): Print the byte-code string as well.
6415
4452fb80
EZ
64162011-10-29 Kim Storm <storm@cua.dk>
6417
8b058d44
EZ
6418 * alloc.c (which_symbols): New function.
6419
21b72067
AS
64202011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6421
6422 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6423 line. (Bug#9903)
6424
83ed7b5c
GM
64252011-10-29 Glenn Morris <rgm@gnu.org>
6426
6427 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6428 Not clear what it was for, and it causes various bugs. (Bug#9839)
6429
5a7a728b
EZ
64302011-10-28 Eli Zaretskii <eliz@gnu.org>
6431
6432 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6433 possible random value that matches one of those tested as
6434 condition to clear the mouse face.
6435
d3d0842f
CY
64362011-10-28 Chong Yidong <cyd@gnu.org>
6437
6438 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6439
31b39d13
DN
64402011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6441
6442 * window.c (make_window): Initialize phys_cursor_on_p.
6443
9aba6043
SM
64442011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6445
6446 * lisp.h (struct Lisp_Symbol): Update comments.
6447
c20992f4
JB
64482011-10-28 Juanma Barranquero <lekktu@gmail.com>
6449
6450 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6451
db4f02f2
EZ
64522011-10-28 Eli Zaretskii <eliz@gnu.org>
6453
6454 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6455 <oslsachem@gmail.com> for helping to debug this.
6456
6457 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6458 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6459 (g_b_init_get_glyph_outline_w): New static variables.
6460 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6461 (GetGlyphOutlineW_Proc): New typedefs.
6462 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6463 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6464 New functions.
6465 (w32font_open_internal, compute_metrics):
6466 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6467 instead of calling the "wide" APIs directly.
6468
6469 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6470
6471 * w32.h (syms_of_w32font): Add prototype.
6472
87e68db4
JB
64732011-10-27 Juanma Barranquero <lekktu@gmail.com>
6474
6475 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6476 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6477 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6478 (Fmove_to_window_line): Doc fix.
6479
435c1d67
CY
64802011-10-27 Chong Yidong <cyd@gnu.org>
6481
6482 * process.c (make_process): Set gnutls_state to NULL.
6483
6484 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6485 non-NULL, regardless of GNUTLS_INITSTAGE.
6486 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6487 an error. Set process slots as soon as we allocate them.
6488
6489 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6490
9c6c6f49
CY
64912011-10-27 Chong Yidong <cyd@gnu.org>
6492
9aba6043
SM
6493 * gnutls.c (emacs_gnutls_deinit): New function.
6494 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6495 (Fgnutls_deinit, Fgnutls_boot): Use it.
6496
6497 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6498 (deactivate_process): Call emacs_gnutls_deinit.
6499
657d08d3
JB
65002011-10-27 Juanma Barranquero <lekktu@gmail.com>
6501
6502 * image.c (x_create_x_image_and_pixmap):
6503 * w32.c (sys_rename, w32_delayed_load):
6504 * w32font.c (fill_in_logfont):
6505 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6506
5430d399
JB
65072011-10-26 Juanma Barranquero <lekktu@gmail.com>
6508
6509 * w32fns.c (w32_default_color_map): New function,
6510 extracted from Fw32_default_color_map.
a7ef684b 6511 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6512
fe0055fa
PE
65132011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6514
6515 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6516
e6346438
SM
65172011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6518
6519 * keyboard.c (test_undefined): New function (bug#9751).
6520 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6521
e112cc37
ET
65222011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6523
6524 * sysdep.c (init_sys_modes): Fix the check for the controlling
6525 terminal (Bug#6649).
6526
7b5d6677
EZ
65272011-10-20 Eli Zaretskii <eliz@gnu.org>
6528
6529 * dispextern.h (struct bidi_it): New member next_en_type.
6530
6531 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6532 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6533 current character, check also for next_en_type being WEAK_EN.
6534 (bidi_resolve_weak): Don't enter the expensive loop if the current
6535 position is before next_en_pos. Record the bidi type of the first
6536 non-ET, non-BN character we find, in addition to its position.
6537 (bidi_level_of_next_char): Invalidate next_en_type when
6538 next_en_pos is over-stepped.
6539
7da0b018
PE
65402011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6541
6542 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6543 * editfns.c: Rewrite current-time-zone so that it invokes
6544 the equivalent of (format-time-string "%Z") to get the time zone name.
6545 This fixes a bug when the time zone name contains characters that
6546 need converting from the system time locale to Emacs internal format.
6547 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6548 that patch fixed format-time-string to do the conversion, but
6549 I forgot to fix current-time-zone.
6550 (format_time_string): New function, containing most of
6551 what Fformat_time_string used to contain.
6552 (Fformat_time_string): Rewrite in terms of format_time_string.
6553 This doesn't change this function's behavior.
6554 (current-time-zone): Rewrite to use format_time_string.
6555 This fixes the bug reported by Michael Schierl in
6556 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6557 Jason Rumney's 2007-06-07 change worked around this bug, but
6558 didn't fix it.
6559 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6560
8547b010
EZ
65612011-10-19 Eli Zaretskii <eliz@gnu.org>
6562
6563 * xdisp.c (start_display): If the character at POS is displayed
6564 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6565 (try_window_reusing_current_matrix): If a line ends in a display
6566 vector or the next line starts in a display vector, continue
6567 redrawing the window even though the character position of
6568 start_row was reached.
8547b010
EZ
6569 (Bug#9771, part 2)
6570
4e948d15
CY
65712011-10-18 Chong Yidong <cyd@gnu.org>
6572
6573 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6574 with nobreak-char-display too.
6575
4787455f
EZ
65762011-10-18 Eli Zaretskii <eliz@gnu.org>
6577
6578 Fix part 3 of bug#9771.
6579 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6580 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6581 non-neutral characters if the current character is a paragraph
6582 separator (a.k.a. Newline). This avoids running the same
6583 expensive loop twice, once when we consume the preceding newline
6584 and the other time when the line actually needs to be displayed.
6585 Avoid the loop when we see neutrals on the base embedding level
6586 following a character whose directionality is the same as the
6587 paragraph's. This avoids running the expensive loop when a line
6588 ends in a long sequence of neutrals, like control characters.
6589 Add assertion against STRONG_AL type. Slightly rearrange code
6590 that determines the type of a neutral given the first non-neutral
6591 that follows it.
6592 (bidi_level_of_next_char): Set next_en_pos to zero when
6593 invalidating its info.
6594
2c91f553
EZ
65952011-10-17 Eli Zaretskii <eliz@gnu.org>
6596
6597 * xdisp.c (push_display_prop): Determine whether to record string
6598 or buffer position by IT->string, not by IT->method. Allow
6599 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6600 (move_it_vertically_backward): Don't look for character position
6601 immediately after the newline when in a continuation line.
6602 (Bug#9771, part 1)
2c91f553 6603
c7b08b0d
MR
66042011-10-15 Martin Rudalics <rudalics@gmx.at>
6605
6606 * window.c (coordinates_in_window): Rewrite and delabelize
6607 vertical border check. (Bug#5357) (Bug#9618)
6608
6b02f655
SM
66092011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6610
6611 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6612 errors in XSetWindowBorder (bug#9310).
6613
81d40c92
DA
66142011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6615
6616 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6617 avoid crash when xmalloc overrun checking is enabled.
6618
d4172c3b
EZ
66192011-10-13 Eli Zaretskii <eliz@gnu.org>
6620
6621 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6622 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6623 cursor motion with <left> and <right> arrow keys.
6624
6625 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6626 some callers set that themselves.
6627
b00eea75
EZ
66282011-10-12 Eli Zaretskii <eliz@gnu.org>
6629
6630 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6631 display string and the previous row comes from the same string and
6632 is empty. (Bug#9739) (Bug#9738)
6633
8fe012c4
SM
66342011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6635
6636 * doc.c (get_doc_string): Encode file name (bug#9735).
6637
0074aef2
EZ
66382011-10-12 Eli Zaretskii <eliz@gnu.org>
6639
79beb178
EZ
6640 * bidi.c (bidi_level_of_next_char):
6641 * xdisp.c (get_visually_first_element): Remove old incorrect
6642 comments regarding the Unicode Line Separator character.
6643
0074aef2
EZ
6644 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6645
6e4b3fbe
DA
66462011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6647
6648 * alloc.c (Fgc_status): Do not access beyond zombies array
6649 boundary if nzombies > MAX_ZOMBIES.
6650 * alloc.c (dump_zombies): Add missing format specifier.
6651
0324f3af
PE
66522011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6653
b5525cac
PE
6654 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6655 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6656
0324f3af
PE
6657 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6658 Some packages use them to denote characters with modifiers.
6659
e9b5f888
AS
66602011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6661
6662 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6663 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6664 matching a pp-number. Rename parameter var to var1.
6665
127827c0
SM
66662011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6667
6668 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6669
c8fd3bd0
GM
66702011-10-08 Glenn Morris <rgm@gnu.org>
6671
6672 * callint.c (Fcall_interactively): Give a more explicit error for the
6673 'c' case with a non-character input. (Bug#8479)
6674
352ec8ff
EZ
66752011-10-08 Eli Zaretskii <eliz@gnu.org>
6676
03669ccb
EZ
6677 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6678 lines.
7061c986
EZ
6679 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6680 lines that are hscrolled on the left.
03669ccb 6681
352ec8ff
EZ
6682 * dispnew.c (buffer_posn_from_coords): Account for a possible
6683 presence of header-line. (Bug#4426)
6684
a66cfb1c
SM
66852011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6686
6b02f655
SM
6687 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6688 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6689
7c5ee88e
PE
66902011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6691
6692 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6693 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6694 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6695 this makes Emacs dump core during garbage collection on rare
6696 occasions. sizeof is obviously inferior to offsetof here, so
6697 stick with offsetof.
6698 (GC_POINTER_ALIGNMENT): New macro.
6699 (mark_memory): Omit 3rd (offset) arg; caller changed.
6700 Don't assume EMACS_INT alignment is the same as pointer alignment.
6701
df1bbe5b
SM
67022011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6703
6704 * keyboard.c (read_key_sequence_remapped): New var.
6705 (read_key_sequence): Compute remapping in the right buffer.
6706 (command_loop_1): Use read_key_sequence's remapping directly.
6707
51553db6
SM
67082011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6709
32c1fffd
SM
6710 * dired.c (file_name_completion): Don't expand file name.
6711 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6712 before checking file name handler.
6713
51553db6
SM
6714 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6715 they've been requested explicitly (bug#9591).
6716
b6bd1599 67172011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6718
6719 * keymap.c (Fsingle_key_description): Use make_specified_string
6720 instead of build_string to build string from push_key_description.
6721 (Bug#5193)
6722
f701dc2a
PE
67232011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6724
4222c55d
PE
6725 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6726 This fixes a Y2038 bug on 64-bit hosts.
6727 * buffer.c (reset_buffer):
6728 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6729 (Fclear_buffer_auto_save_failure):
6730 Use 0, not -1, to represent an unset failure time, since time_t
6731 might not be signed.
6732
f701dc2a
PE
6733 Remove dependency on glibc malloc internals.
6734 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6735 Move back here from lisp.h, but with their new implementations.
6736 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6737 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6738 * charset.c (charset_table_init): New static var.
6739 (syms_of_charset): Use it instead of xmalloc. This removes a
6740 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6741 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6742 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6743 Move back to alloc.c.
6744 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6745 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6746
9ceebf39
JD
67472011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6748
6749 * nsterm.m (windowDidResize): Call x_set_window_size only when
6750 ns_in_resize is true. Otherwise set pixelwidth/height and
6751 call change_frame_size (Bug#9628).
6752
cb993c58
PE
67532011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6754
3930c88b
PE
6755 Port --enable-checking=all to Fedora 14 x86-64.
6756 * charset.c (syms_of_charset): Also account for glibc malloc's
6757 internal overhead when calculating the initial malloc maximum.
6758
cb993c58
PE
6759 Port --enable-checking=all to Fedora 14 x86.
6760 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6761 Move to lisp.h.
6762 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6763 (overrun_check_realloc, overrun_check_free):
6764 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6765 That way, xmalloc returns a properly-aligned pointer even if
6766 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6767 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6768 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6769 into account when calculating the initial malloc maximum.
6770 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6771 Move here from alloc.c, so that charset.c can use it too.
6772 Properly align; the old code wasn't right for common 32-bit hosts
6773 when configured with --enable-checking=all.
6774 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6775 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6776
31bed486
EZ
67772011-09-29 Eli Zaretskii <eliz@gnu.org>
6778
04c70788 6779 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6780 use EDOM.
6781
fbcaa2f3
EZ
67822011-09-28 Eli Zaretskii <eliz@gnu.org>
6783
6784 * xdisp.c (compute_display_string_end): If there's no display
6785 string at CHARPOS, return -1.
6786
6787 * bidi.c (bidi_fetch_char): When compute_display_string_end
6788 returns a negative value, treat the character as a normal
6789 character not covered by a display string. (Bug#9624)
6790
a239d4e9
JB
67912011-09-28 Juanma Barranquero <lekktu@gmail.com>
6792
6793 * lread.c (Fread_from_string): Fix typo in docstring.
6794
88652fd5
EZ
67952011-09-27 Eli Zaretskii <eliz@gnu.org>
6796
6797 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6798 newline, reseat the iterator instead of bidi-iterating there one
6799 character at a time. (Bug#9610)
32c1fffd
SM
6800 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6801 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6802
ed497dd4
AS
68032011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6804
6805 * lread.c (readevalloop): Use correct code for NBSP.
6806 (read1): Likewise. (Bug#9608)
6807
b2bf61aa
MA
68082011-09-25 Michael Albinus <michael.albinus@gmx.de>
6809
6810 * dbusbind.c (Fdbus_register_signal): When service is not
6811 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6812
32bbb17c
GM
68132011-09-25 Glenn Morris <rgm@gnu.org>
6814
6815 * buffer.c (truncate-lines): Doc fix.
6816
94e0933e
CY
68172011-09-24 Chong Yidong <cyd@stupidchicken.com>
6818
6819 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6820 (Fset_window_next_buffers): Doc fix.
6821
cddde921
GM
68222011-09-24 Glenn Morris <rgm@gnu.org>
6823
6824 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6825
1260aef1
PE
68262011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6827
25b4bfa0
PE
6828 Fix minor problems found by static checking.
6829 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6830 * indent.c (Fvertical_motion): Fix == vs = typo.
6831
e3cbd34b
EZ
68322011-09-24 Eli Zaretskii <eliz@gnu.org>
6833
a66cfb1c
SM
6834 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6835 Default value is now t. Doc fix.
6bf7006f 6836
e3cbd34b 6837 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6838 logic when moving up, not only when moving down. Fix the
e3cbd34b 6839 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6840 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6841
6842 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6843 CHARPOS is covered by a display string which includes newlines.
6844 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6845 is covered by a display string with embedded newlines.
6846
a3de0cbd
MA
68472011-09-24 Michael Albinus <michael.albinus@gmx.de>
6848
6849 * dbusbind.c (Fdbus_register_signal): Add match rule to
6850 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6851 (Fdbus_register_method, Vdbus_registered_objects_table):
6852 Fix docstring.
a3de0cbd 6853
b260039d
JM
68542011-09-24 Jim Meyering <meyering@redhat.com>
6855
32c1fffd 6856 do not ignore write error for any output size
b260039d
JM
6857 The previous change was incomplete.
6858 While it makes emacs --batch detect the vast majority of stdout
6859 write failures, errors were still ignored whenever the output size is
6860 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6861 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6862 && echo FAIL: ignored write error
6863 FAIL: ignored write error
6864 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6865 && echo FAIL: ignored write error
6866 FAIL: ignored write error
6867 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6868
8eca8a7c
AS
68692011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6870
6871 * emacs.c (Fkill_emacs): In noninteractive mode exit
6872 non-successfully if a write error occurred on stdout. (Bug#9574)
6873
3341db62
EZ
68742011-09-21 Eli Zaretskii <eliz@gnu.org>
6875
6876 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6877 the xassert test.
6878
6879 * dispextern.h (struct it): Update the comment documenting what
6880 can it->OBJECT be.
6881
8c203dbf
EZ
68822011-09-20 Eli Zaretskii <eliz@gnu.org>
6883
6884 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6885 a display string, extend search for cursor position to end of row.
6886 (find_row_edges): If the row ends in a newline from a display
6887 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6888 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6889 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6890 non-empty line. Fixes confusing cursor motion with arrow keys at
6891 the beginning of a line that starts with whitespace.
8c203dbf 6892
a4824228
LMI
68932011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6894
6895 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6896 (bug#9493).
6897
33ed493b
CY
68982011-09-18 Chong Yidong <cyd@stupidchicken.com>
6899
6900 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6901 boolean (Bug#9154).
6902
56cd55c8
EZ
69032011-09-18 Eli Zaretskii <eliz@gnu.org>
6904
6905 * xdisp.c (display_line): Record maximum and minimum buffer
6906 positions even if no glyphs were produced (e.g., by a zero-width
6907 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6908 buffer positions that will be removed from the glyph row because
6909 they don't fit.
c02dcedf
EZ
6910 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6911 column is beyond frame width: don't subtract 1 "pixel" when
6912 computing width of the stretch.
3e62b7e0
EZ
6913 (reseat_at_next_visible_line_start): Undo the change made on
6914 2011-09-17 that saved paragraph information and restored it after
6915 the call to `reseat'. (Bug#9545)
56cd55c8 6916
5ed99d36 69172011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6918
6919 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6920 and turn window cursor on if cleared (Bug#9415).
6921
5ed99d36 69222011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6923
6924 * search.c (boyer_moore): Take unibyte characters from pattern
6925 literally. (Bug#9458)
6926
9bade7b2
EZ
69272011-09-18 Eli Zaretskii <eliz@gnu.org>
6928
6929 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6930
e5e9d610
PE
69312011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6932
87e4427a
PE
6933 Fix minor problem found by static checking.
6934 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6935 initialized, to pacify gcc -Wuninitialized.
6936
e5e9d610
PE
6937 * fileio.c: Report proper errno when syscall falls.
6938 (Finsert_file_contents): Save and restore errno,
6939 so that report_file_error outputs the correct diagnostic.
6940 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6941
a1674f0b
EZ
69422011-09-18 Eli Zaretskii <eliz@gnu.org>
6943
6944 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6945
fbfb6dd4
EZ
69462011-09-17 Eli Zaretskii <eliz@gnu.org>
6947
6948 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6949 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6950
bb187662
EZ
69512011-09-17 Eli Zaretskii <eliz@gnu.org>
6952
1137e8b8 6953 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6954 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6955
6956 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6957 (bidi_find_paragraph_start): Search back for paragraph beginning
6958 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6959 (bidi_move_to_visually_next): Only trigger paragraph-related
6960 computations when the last character is a newline or at EOB, not
6961 just any NEUTRAL_B. (Bug#9470)
6962
bb187662
EZ
6963 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6964 truncated lines if point is covered by a display string. (Bug#9524)
6965
2e621251
PE
69662011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6967
6968 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6969 (cons_to_x_long): New function.
6970 (lisp_data_to_selection_data): Use it. Correct the test for
6971 short-versus-long data; it was negated. Break out of vector
6972 loop, for efficiency, when a long datum is discovered.
6973
91a15bc6
SM
69742011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6975
6976 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6977
b41c3a35
EZ
69782011-09-16 Eli Zaretskii <eliz@gnu.org>
6979
6980 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6981 GCC PR/17406) by declaring this function with external scope.
6982
7812ba2d
PE
69832011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6984
6985 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6986 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6987
cf7edc2a
AS
69882011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6989
6990 * editfns.c (Fformat): Correctly handle text properties on "%%".
6991
bd01620e
EZ
69922011-09-15 Eli Zaretskii <eliz@gnu.org>
6993
6994 * xterm.c (x_draw_composite_glyph_string_foreground):
6995 * w32term.c (x_draw_composite_glyph_string_foreground):
6996 * term.c (encode_terminal_code):
6997 * composite.c (composition_update_it, get_composition_id):
6998 * xdisp.c (get_next_display_element)
6999 (fill_composite_glyph_string): Add comments about special meaning
7000 of TAB characters in a composition.
7001
a02719a3
PE
70022011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7003
7004 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7005 This occurs when processing a multibyte format.
7006 Problem reported by Wolfgang Jenker.
a02719a3 7007
72589a3c
JB
70082011-09-15 Johan Bockgård <bojohan@gnu.org>
7009
7010 * xdisp.c (try_cursor_movement): Only check for exact match if
7011 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7012
1c14176c
PE
70132011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7014
7015 Remove unused external symbols.
7016 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7017 * xdisp.c (calc_pixel_width_or_height): Now static.
7018 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7019 * indent.c (check_display_width):
7020 * w32term.c: Fix comment to match code.
7021 * xterm.c, xterm.h (x_catching_errors): Remove.
7022
d2eea5b5
PE
70232011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7024
7025 * xselect.c: Use signed conversions more consistently (Bug#9498).
7026 (selection_data_to_lisp_data): Assume incoming selection data are
7027 signed integers, not unsigned. This is to be consistent with
7028 outgoing selection data, which was modified to use signed integers
7029 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7030 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7031 expects long, not unsigned long.
7032
46888499
EZ
70332011-09-14 Eli Zaretskii <eliz@gnu.org>
7034
7035 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7036 computation of loop end. Reported by Johan Bockgård
7037 <bojohan@gnu.org>.
7038
ef8ef9fb
CY
70392011-09-13 Chong Yidong <cyd@stupidchicken.com>
7040
7041 * frame.c (Fother_visible_frames_p): Function deleted.
7042
fa819fed
EZ
70432011-09-12 Eli Zaretskii <eliz@gnu.org>
7044
7045 * indent.c (compute_motion): Process display vector front to back
7046 rather than the other way around. (Bug#2496)
7047
2ba8e008
SM
70482011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7049
7050 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7051
20f53c69
CY
70522011-09-11 Chong Yidong <cyd@stupidchicken.com>
7053
7054 * minibuf.c (Fread_from_minibuffer): Doc fix.
7055
d562d7a4
EZ
70562011-09-11 Eli Zaretskii <eliz@gnu.org>
7057
7058 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7059 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7060
1c4d7f3d
LMI
70612011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7062
7063 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7064 value for non-existent files.
7065
b885bf36
EZ
70662011-09-11 Eli Zaretskii <eliz@gnu.org>
7067
7068 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7069 set its "size" to -1. This will set the modtime_size field of
7070 the corresponding buffer to -1, which is what
7071 verify-visited-file-modtime expects for files that do not exist.
7072 (Bug#9139)
7073
6612f0bf
PE
70742011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7075
7076 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7077 here ...
7078 * lisp.h: ... from here. push_key_description is no longer
7079 defined in keyboard.c, so its declaration should not be in
7080 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7081 logically belongs with push_key_description.
7082
dfb3f755
PE
70832011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7084
7085 * buffer.h: Include <sys/types.h> instead of <time.h>.
7086 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7087 Problem reported by Herbert J. Skuhra.
7088
3134906c
LMI
70892011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7090
7091 * xml.c (parse_region): Make the parsing work for
7092 non-comment-starting XML files again (bug#9144).
7093
8d903f4e
AS
70942011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7095
7096 * image.c (gif_load): Fix calculation of bottom and right corner.
7097 (Bug#9468)
7098
80ad64f4
EZ
70992011-09-10 Eli Zaretskii <eliz@gnu.org>
7100
7101 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7102 redisplay in small windows.
7103
208a048d
EZ
71042011-09-09 Eli Zaretskii <eliz@gnu.org>
7105
7106 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7107
9b1c252e
MR
71082011-09-08 Martin Rudalics <rudalics@gmx.at>
7109
7110 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7111 Operate on live windows only.
7112
2949f33b
JB
71132011-09-08 Juanma Barranquero <lekktu@gmail.com>
7114
7115 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7116
e08dcafd
EZ
71172011-09-07 Eli Zaretskii <eliz@gnu.org>
7118
7119 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7120 only under bidi iteration.
7121
115b96bd
JD
71222011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7123
7124 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7125
c8199d0f
PE
71262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7127
7128 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7129 Without this fix, the command to link temacs failed due to an
7130 undefined symbol __builtin_isnan. This is because
7131 /usr/include/iso/math_c99.h #defines isnan(x) to
7132 __builtin_isnan(x), but the bundled gcc, which identifies itself
7133 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7134 a __builtin_isnan.
7135 * floatfns.c (isnan): #undef, and then #define to a clone of
7136 what's in data.c.
7137 (Fisnan): Always define, since it's always available now.
7138 (syms_of_floatfns): Always define isnan at the Lisp level.
7139
e39b275c 71402011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7141
7142 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7143
b2db44d9 71442011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7145
f4af5137 7146 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7147 The previous code assumed that file offsets (off_t values) fit in
7148 EMACS_INT variables, which is not true on typical 32-bit hosts.
7149 The code messed up by falsely reporting buffer overflow in cases
7150 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7151 when "big" contains more than 2**29 bytes, even though this
7152 inserts just one byte and does not overflow the buffer.
7153 (Finsert_file_contents): Store file offsets as off_t
7154 values, not as EMACS_INT values. Check for overflow when
7155 converting between EMACS_INT and off_t. When checking for
7156 buffer overflow or for overlap, take the offsets into account.
7157 Don't use EMACS_INT for small values where int suffices.
7158 When checking for overlap, fix a typo: ZV was used where
7159 ZV_BYTE was intended.
7160 (Fwrite_region): Don't assume off_t fits into 'long'.
7161 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7162
ecfc0a49
MA
71632011-09-05 Michael Albinus <michael.albinus@gmx.de>
7164
7165 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7166
6511acf2 71672011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7168
0999621a 7169 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7170
7171 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7172 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7173 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7174 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7175 (modify_event_symbol): Do not assume that the length of
7176 name_alist_or_stem is safe to alloca and fits in int.
7177 (Fexecute_extended_command): Likewise for function name and binding.
7178 (Frecursion_depth): Wrap around reliably on integer overflow.
7179 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7180 since some callers pass EMACS_INT values.
7181 (Fsingle_key_description): Don't crash if symbol name contains more
7182 than MAX_ALLOCA bytes.
7183 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7184 (get_minibuffer): Arg is now EMACS_INT, not int.
7185 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7186 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7187 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7188
2be7d702
PE
7189 * dbusbind.c (signature_cat): New function.
7190 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7191 Do not overrun buffer; instead, report string overflow.
7192
9d1df220
PE
7193 * dispnew.c (add_window_display_history): Don't overrun buffer.
7194 Truncate instead; this is OK since it's just a log.
7195
33ef5c64
PE
7196 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7197 even if the time zone offset is outlandishly large.
7198 Don't mishandle offset == INT_MIN.
7199
66c6fdd5
PE
7200 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7201 when creating daemon; the previous buffer-overflow check was incorrect.
7202
d749b01b
PE
7203 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7204 which has the guts of the old verror function.
7205
b5cd1905
PE
7206 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7207 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7208
6e1a67fb
PE
7209 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7210 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7211 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7212 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7213 length of string rather than counting it via multiple sprintfs;
7214 that's simpler and more reliable.
c21721cc
PE
7215 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7216 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7217 sprintf, in case result does not fit in int.
7218
c57b67fc
PE
7219 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7220 (fontset_from_font): Print it.
7221
8a401434
PE
7222 * frame.c (tty_frame_count): Now printmax_t, not int.
7223 (make_terminal_frame, set_term_frame_name): Print it.
7224 (x_report_frame_params): In X, window IDs are unsigned long,
7225 not signed long, so print them as unsigned.
7226 (validate_x_resource_name): Check for implausibly long names,
7227 and don't assume name length fits in 'int'.
7228 (x_get_resource_string): Don't blindly alloca invocation name;
7229 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7230 not fit in int.
7231
6e1a67fb
PE
7232 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7233 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7234 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7235
0df02bf3
PE
7236 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7237 Use esprintf, not sprintf, in case result does not fit in int.
7238
48e30793
PE
7239 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7240 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7241 it as a large positive number.
7242 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7243 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7244
a66ff6d8
PE
7245 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7246 in case result does not fit in int.
7247
aca216ff
PE
7248 * print.c (float_to_string): Detect width overflow more reliably.
7249 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7250 buffer overrun. Don't assume list length fits in 'int'. Treat
7251 print length of 0 as 0, not as infinity; to be consistent with other
7252 uses of print length in this function. Don't overflow print length
7253 index. Don't assume hash table size fits in 'long', or that
7254 vectorlike size fits in 'unsigned long'.
7255
31c286f7
PE
7256 * process.c (make_process): Use printmax_t, not int, to format
7257 process-name gensyms.
7258
55e5faa1
PE
7259 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7260
80f2e268
PE
7261 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7262 to avoid potential buffer overrun.
7263
670741ab
PE
7264 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7265 if X resource line is longer than 512 bytes.
7266
b7163a50
PE
7267 * xfns.c (x_window): Make sprintf buffer a bit bigger
7268 to avoid potential buffer overrun.
7269
ae58ff1f
PE
7270 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7271
c43c8a6a
PE
7272 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7273
3f8236f4
PE
72742011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7275
53e9fe90 7276 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7277 Without these, Emacs silently mishandles large integers sometimes.
7278 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7279 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7280
6511acf2
PE
7281 * xdisp.c (try_window_id): Check Emacs fixnum range before
7282 converting to 'int'.
806add1d 7283
6511acf2 7284 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7285 Check that an Emacs fixnum is in range before assigning it to 'int'.
7286 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7287 values converted from Emacs fixnums.
7288 (Frecenter): Don't wrap around a line count if it is out of 'int'
7289 range; instead, treat it as an extreme value.
7290 (Fset_window_configuration, compare_window_configurations):
7291 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7292
6511acf2
PE
7293 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7294 that can exceed INT_MAX. Check that EMACS_INT value is in range
7295 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7296 (match_limit): Don't assume that a fixnum can fit in 'int'.
7297
6511acf2 7298 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7299 exceed INT_MAX.
7300
6511acf2 7301 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7302 (Fvertical_motion): Don't wrap around LINES values that don't fit
7303 in 'int'. Instead, treat them as extreme values. This is good
7304 enough for windows, which can't have more than INT_MAX lines anyway.
7305
fcb901a7
LMI
73062011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7307
0f2f6b6d
LMI
7308 * Require libxml/parser.h to avoid compilation warning.
7309
fcb901a7
LMI
7310 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7311
7312 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7313 since this reportedly can destroy thread storage.
7314
6e20a0d4
CY
73152011-08-30 Chong Yidong <cyd@stupidchicken.com>
7316
7317 * syntax.c (find_defun_start): Update all cache variables if
7318 exiting early (Bug#9401).
7319
148ae00e
EZ
73202011-08-30 Eli Zaretskii <eliz@gnu.org>
7321
f6cfbd8f
EZ
7322 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7323
148ae00e
EZ
7324 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7325 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7326 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7327
7328 * term.c (tty_append_glyph): New function.
7329 (produce_stretch_glyph): Static function and its prototype deleted.
7330
a66cfb1c
SM
7331 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7332 Add prototypes.
148ae00e 7333
c4a07a4c
PE
73342011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7335
7336 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7337 when checking :margin (Bug#9390).
7338 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7339 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7340 so that the name doesn't mislead. All uses changed.
7341
6bc8cd65
JB
73422011-08-28 Johan Bockgård <bojohan@gnu.org>
7343
7344 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7345 set_tty_hooks.
7346
dca4927e
EZ
73472011-08-27 Eli Zaretskii <eliz@gnu.org>
7348
7349 * xdisp.c (move_it_to): Don't bail out early when reaching
7350 position beyond to_charpos, if we are scanning backwards.
7351 (move_it_vertically_backward): When DY == 0, make sure we get to
7352 the first character in the line after the newline.
7353
f2cad773
PE
73542011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7355
7356 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7357 (ccl_driver): Do not generate an out-of-range pointer.
7358 (Fccl_execute_on_string): Remove unnecessary check for
7359 integer overflow, noted by Stefan Monnier in
7360 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7361 Remove a FIXME that didn't need fixing.
7362 Simplify the newly-introduced buffer reallocation code.
7363
0cae2cdb
JB
73642011-08-27 Juanma Barranquero <lekktu@gmail.com>
7365
7366 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7367
5fc295a4 73682011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7369
70c60eb2 7370 Integer and memory overflow issues (Bug#9196).
726e0ab1 7371
d31850da
PE
7372 * doc.c (get_doc_string): Rework so that
7373 get_doc_string_buffer_size is the actual buffer size, rather than
7374 being 1 less than the actual buffer size; this makes xpalloc more
7375 convenient.
7376
a69fbedb
PE
7377 * image.c (x_allocate_bitmap_record, cache_image):
7378 * xselect.c (Fx_register_dnd_atom):
7379 Simplify previous changes by using xpalloc.
7380
fe5c5d37
PE
7381 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7382 since either will do and ptrdiff_t is convenient with xpalloc.
7383
0065d054
PE
7384 * charset.c (charset_table_size)
7385 (struct charset_sort_data.priority): Now ptrdiff_t.
7386 (charset_compare): Don't overflow if priorities differ greatly.
7387 (Fsort_charsets): Don't assume list length fits in int.
7388 Check for size-calculation overflow when allocating sort data.
7389 (syms_of_charset): Allocate an initial charset table that is
7390 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7391
7392 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7393
7394 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7395 The actual value is always <= INT_MAX, and leaving it unsigned made
7396 overflow checking harder.
7397
7398 * dispextern.h (struct glyph_matrix.rows_allocated)
7399 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7400 with xpalloc. The values are still always <= INT_MAX.
7401
7402 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7403
7404 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7405 (SAFE_NALLOCA): New macro.
7406
7407 * region-cache.c (struct boundary.pos, find_cache_boundary)
7408 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7409 (set_cache_region, invalidate_region_cache)
7410 (revalidate_region_cache, know_region_cache, region_cache_forward)
7411 (region_cache_backward, pp_cache):
7412 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7413 so that ptrdiff_t * can be passed to xpalloc.
7414 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7415 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7416 (pp_cache): Don't assume cache_len fits in int.
7417 * region-cache.h: Adjust extern decls to match.
7418
7419 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7420 EMACS_INT, since either will do, for xpalloc.
7421
7422 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7423 (xnmalloc, xnrealloc, xpalloc): New functions.
7424
726e0ab1
PE
7425 * bidi.c (bidi_shelve_header_size): New constant.
7426 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7427 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7428
51f30bc5 7429 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7430 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7431 (overlay_strings):
7432 Don't update size of array until after memory allocation succeeds,
7433 because xmalloc/xrealloc may not return.
0065d054
PE
7434 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7435 now that we have proper integer overflow checking.
7436 (record_overlay_string, overlay_strings): Catch overflows when
7437 calculating size of overlay_str_buf.
726e0ab1 7438
0065d054
PE
7439 * callproc.c (Fcall_process): Check for size overflow when
7440 calculating size of args2.
7441 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7442 Normally we prefer signed values, but sticking with ptrdiff_t would
7443 require adding more-complicated checks.
726e0ab1
PE
7444
7445 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7446 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7447 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7448 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7449
7450 * character.c (Fstring): Check for size-calculation overflow.
7451
7452 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7453 unnecessary integer overflow. Check for size overflow.
7454 (encode_coding_object): Don't update size until xmalloc succeeds.
7455
7456 * composite.c (get_composition_id): Check for overflow in glyph
7457 length calculations.
7458
7459 Integer and memory overflow fixes for display code.
7460 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7461 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7462 (scrolling_window): Check for overflow in size calculations.
7463 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7464 Don't assume glyph table len fits in int.
7465 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7466 (row_table_size): Now ptrdiff_t, not int.
7467 (scrolling_window): Avoid overflow in size calculations.
7468 Don't update size until allocation succeeds.
7469 * fns.c (concat): Check for overflow in size calculations.
7470 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7471 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7472 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7473
7474 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7475 (get_doc_string): Check for size calculation overflow.
7476 Don't update size until allocation succeeds.
7477 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7478 EMACS_INT, where ptrdiff_t will do.
7479 (Fsubstitute_command_keys): Check for string overflow.
7480
7481 * editfns.c (set_time_zone_rule): Don't assume environment length
7482 fits in int.
7483 (message_length): Now ptrdiff_t, not int.
7484 (Fmessage_box): Don't update size until allocation succeeds.
7485 Don't assume message length fits in int.
7486 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7487
0065d054
PE
7488 * emacs.c (main): Do not reallocate argv, since there is a null at
7489 the end that can be overwritten, and this way there's no need to
7490 worry about size-calculation overflow.
7491 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7492
7493 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7494 alloc succeeds.
7495 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7496
7497 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7498 (x_set_scroll_bar_width, x_figure_window_size):
7499 Check for integer overflow.
7500 (x_set_alpha): Do not assume XINT fits in int.
7501
7502 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7503 This is for the members text_lines, text_cols, total_lines, total_cols,
7504 where the system imposes an 'int' limit.
7505
7506 * fringe.c (Fdefine_fringe_bitmap):
7507 Don't update size until alloc works.
7508
7509 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7510 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7511
7512 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7513 Check for size-calculation overflow.
7514 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7515 do, as we prefer signed integers.
7516 (id_to_widget.max_size, id_to_widget.used)
7517 (xg_store_widget_in_map, xg_remove_widget_from_map)
7518 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7519 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7520 Use and return ptrdiff_t, not int.
7521 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7522 * gtkutil.h: Change prototypes to match the above.
7523
7524 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7525 are duplicate now that they've been promoted to lisp.h.
7526 (x_allocate_bitmap_record, x_alloc_image_color)
7527 (make_image_cache, cache_image, xpm_load):
7528 Don't update size until alloc is done.
7529 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7530 (x_detect_edges):
3256efce 7531 Check for size calculation overflow.
726e0ab1
PE
7532 (ct_colors_allocated_max): New constant.
7533 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7534 overflow.
3256efce 7535
726e0ab1
PE
7536 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7537 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7538 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7539 Use ptrdiff_t, not int, to count maps.
7540 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7541 calculations. Don't update size until allocation succeeds.
7542 Redo calculations to avoid overflow.
726e0ab1
PE
7543 * keyboard.h: Change prototypes to match the above.
7544
7545 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7546 to count maps.
7547 (current_minor_maps): Check for size calculation overflow.
7548 * keymap.h: Change prototypes to match the above.
7549
7550 * lread.c (read1, init_obarray): Don't update size until alloc done.
7551
7552 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7553 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7554
726e0ab1
PE
7555 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7556 Now ptrdiff_t, not int.
7557 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7558 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7559
7560 * process.c (Fnetwork_interface_list): Check for overflow
7561 in size calculation.
7562
7563 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7564
7565 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7566 overflow. Don't bother calling xmalloc when xrealloc will do.
7567
7568 * search.c (Freplace_match): Check for size calculation overflow.
7569 (Fset_match_data): Don't assume list lengths fit in 'int'.
7570
7571 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7572 for command line length. Do not attempt to address one before the
7573 beginning of an array, as that's not portable.
7574
7575 * term.c (max_frame_lines): Remove; unused.
7576 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7577 not int.
7578 (encode_terminal_code, calculate_costs): Check for size
7579 calculation overflow.
7580 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7581 table lengths and related sizes. Don't update size until alloc
7582 done. Redo calculations to avoid overflow.
7583 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7584
7585 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7586 subtracting pointers.
7587 (gobble_line): Check for overflow more carefully. Don't update size
7588 until alloc done.
7589
7590 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7591 Don't update size until alloc done.
7592 Redo size calculations to avoid overflow.
7593 Check for size calculation overflow.
0065d054 7594 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7595
7596 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7597 Use ptrdiff_t, not int, for sizes.
7598 (store_mode_line_noprop_char): Don't update size until alloc done.
7599
0065d054
PE
7600 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7601 Use ptrdiff_t, not int, for sizes.
7602 (Finternal_make_lisp_face, cache_face):
7603 Check for size calculation overflow.
7604 (cache_face): Treat size calculation overflows as if they were
7605 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7606
7607 * xfns.c (x_encode_text, x_set_name_internal)
7608 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7609 sizes, since they can exceed INT_MAX in size. Check for size
7610 calculation overflow.
7611
0065d054
PE
7612 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7613 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7614 Don't update size until alloc done.
7615
0065d054 7616 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7617 as sprintf is limited to int lengths.
1d526e2f 7618
252c5ee1
PE
7619 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7620 (X_LONG_MIN): New macros.
864d7ce7
PE
7621 Use them to make the following changes clearer.
7622 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7623 This change doesn't affect the value now, but it may help remind
7624 future maintainers not to raise the value too much later.
7625 (SELECTION_QUANTUM): Remove, replacing with ...
7626 (selection_quantum): ... new function, which avoids overflow.
7627 All uses changed.
7628 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7629 assumption that selection length fits in 'int'.
7630 (x_reply_selection_request, x_handle_selection_request)
7631 (x_get_window_property, receive_incremental_selection)
7632 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7633 (lisp_data_to_selection_data, clean_local_selection_data):
7634 Use ptrdiff_t, not int, to record length of selection.
7635 (x_reply_selection_request, x_get_window_property)
7636 (receive_incremental_selection, x_property_data_to_lisp):
7637 Redo calculations to avoid overflow.
7638 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7639 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7640 something.
7641 (x_get_window_property, receive_incremental_selection)
7642 (lisp_data_to_selection_data, x_property_data_to_lisp):
7643 Check for size-calculation overflow.
7644 (x_get_window_property, receive_incremental_selection)
7645 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7646 Don't store size until memory allocation succeeds.
7647 (x_get_window_property): Plug memory leak on memory exhaustion.
7648 Don't double-block input; malloc is safe here. Don't assume 2**34
7649 - 4 fits in unsigned long. Add an xassert to check
7650 XGetWindowProperty overflow. Be more careful about overflow
7651 calculations, and distinguish size from memory overflow better.
7652 (receive_incremental_selection): When tracing, don't assume
7653 unsigned int is less than INT_MAX.
7654 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7655 harmful) conversions of unsigned short to int.
7656 (lisp_data_to_selection_data): Don't assume that integers
7657 in the range -65535 through -1 fit in an X unsigned short.
7658 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7659 result parameters unless successful. Rely on cons_to_unsigned
7660 to report problems with elements; the old code wasn't right anyway.
7661 (x_check_property_data): Check for int overflow; we cannot use
7662 a wider type due to X limits.
7663 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7664
726e0ab1 7665 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7666
0065d054
PE
7667 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7668 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7669 (x_color_cells): Don't store size until memory allocation succeeds.
7670 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7671 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7672 (x_term_init): Don't assume length fits in int (sprintf is limited
7673 to int size).
bc18e09d 7674
ebfa62c0
PE
7675 Use ptrdiff_t for composition IDs.
7676 * character.c (lisp_string_width):
7677 * composite.c (composition_table_size, n_compositions)
7678 (get_composition_id, composition_gstring_from_id):
7679 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7680 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7681 * window.c (Frecenter):
7682 Use ptrdiff_t, not int, for composition IDs.
7683 * composite.c (get_composition_id): Check for integer overflow.
7684 * composite.h: Adjust prototypes to match the above changes.
7685
d3411f89
PE
7686 Use ptrdiff_t for hash table indexes.
7687 * category.c (hash_get_category_set):
7688 * ccl.c (ccl_driver):
7689 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7690 * coding.c (coding_system_charset_list, detect_coding_system):
7691 * coding.h (struct coding_system.id):
7692 * composite.c (get_composition_id, gstring_lookup_cache):
7693 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7694 * image.c (xpm_get_color_table_h):
7695 * lisp.h (hash_lookup, hash_put):
7696 * minibuf.c (Ftest_completion):
7697 Use ptrdiff_t for hash table indexes, not int (which is too
7698 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7699 32-bit --with-wide-int hosts).
7700
e097a6fa
PE
7701 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7702 Add a FIXME comment about memory leaks.
7703 (syms_of_charset): Don't assume xmalloc returns.
7704
5637687f
PE
7705 Don't assume that stated character widths fit in int.
7706 * character.c (Fchar_width, c_string_width, lisp_string_width):
7707 * character.h (CHAR_WIDTH):
7708 * indent.c (MULTIBYTE_BYTES_WIDTH):
7709 Use sanitize_char_width to avoid undefined and/or bad behavior
7710 with outlandish widths.
a66cfb1c 7711 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7712 now that we have two such functions. All uses changed.
7713 (sanitize_char_width): New inline function.
7714
a2271ba2
PE
7715 Don't assume that tab-width fits in int.
7716 * character.h (sanitize_width): New inline function.
7717 (SANE_TAB_WIDTH): New macro.
7718 (ASCII_CHAR_WIDTH): Use it.
7719 * indent.c (sane_tab_width): Remove. All uses replaced by
7720 SANE_TAB_WIDTH (current_buffer).
7721 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7722
18c52557
PE
7723 * fileio.c: Integer overflow issues with file modes.
7724 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7725
caeeedc1
PE
7726 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7727 Remove unreachable code.
7728 (read_hex, load_charset_map_from_file): Check for integer overflow.
7729
6df6ae42 7730 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7731 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7732 (x_send_scroll_bar_event): Likewise. Check that the size does not
7733 exceed limits imposed by XClientMessageEvent, as well as the usual
7734 ptrdiff_t and size_t limits.
7735
b13995db
PE
7736 * keyboard.c: Overflow, signedness and related fixes.
7737 (make_lispy_movement): Use same integer type in forward decl
7738 that is used in the definition.
7739 (read_key_sequence, keyremap_step):
7740 Change bufsize argument back to int, undoing my 2011-03-30 change.
7741 We prefer signed types, and int is wide enough here.
7742 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7743 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7744 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7745 length, not size_t. Use ptrdiff_t for index, not int.
7746 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7747 possibility of integer overflow.
7748
13464394
PE
7749 Overflow, signedness and related fixes for images.
7750
7751 * dispextern.h (struct it.stack[0].u.image.image_id)
7752 (struct_it.image_id, struct image.id, struct image_cache.size)
7753 (struct image_cache.used, struct image_cache.ref_count):
7754 * gtkutil.c (update_frame_tool_bar):
7755 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7756 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7757 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7758 * nsmenu.m (update_frame_tool_bar):
7759 * xdisp.c (calc_pixel_width_or_height):
7760 * xfns.c (image_cache_refcount):
7761 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7762 on typical 64-bit hosts.
7763
7764 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7765 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7766 Omit unnecessary casts to int.
7767 (parse_image_spec): Check that integers fall into 'int' range
7768 when the callers expect that.
7769 (image_ascent): Redo ascent calculation to avoid int overflow.
7770 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7771 (lookup_image): Remove unnecessary tests.
7772 (xbm_image_p): Locals are now of int, not EMACS_INT,
7773 since parse_image_check makes sure they fit into int.
7774 (png_load, gif_load, svg_load_image):
7775 Prefer int to unsigned where either will do.
7776 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7777 old tiff_error_handler and tiff_warning_handler.
7778 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7779 stack buffer overflows. It uses only the features of vsnprintf
7780 that are common to both POSIX and native Microsoft.
7781 (tiff_error_handler, tiff_warning_handler): Use it.
7782 (tiff_load, gif_load, imagemagick_load_image):
7783 Don't assume :index value fits in 'int'.
7784 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7785 (imagemagick_load_image): Check that crop parameters fit into
7786 the integer types that MagickCropImage accepts. Don't assume
7787 Vimagemagick_render_type has a nonnegative value. Don't assume
7788 size_t fits in 'long'.
7789 (gs_load): Use printmax_t to print the widest integers possible.
7790 Check for integer overflow when computing image height and width.
7791
c11821d4
EZ
77922011-08-26 Eli Zaretskii <eliz@gnu.org>
7793
7794 * xdisp.c (redisplay_window): Don't force window start if point
7795 will be invisible in the resulting window. (Bug#9324)
7796
0c95fcf7
EZ
77972011-08-25 Eli Zaretskii <eliz@gnu.org>
7798
7799 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7800 the display spec is of the form `(space ...)'.
7801 (handle_display_spec): Return the value returned by
7802 handle_single_display_spec, not just 1 or zero.
7803 (handle_single_display_spec): If the display spec is of the form
7804 `(space ...)', and specifies display in the text area, return 2
7805 rather than 1.
fee65a97 7806 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7807 accurately, and prefer exact match for point under bidi.
7808 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7809
7810 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7811 into disp_prop; all users changed.
7812
7813 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7814 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7815 for the text covered by the display property.
7816
e4ed06f1
CY
78172011-08-25 Chong Yidong <cyd@stupidchicken.com>
7818
7819 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7820 Change return value to nil.
7821 (Frecord_buffer): Delete unused function.
7822
f67cdd7f
EZ
78232011-08-24 Eli Zaretskii <eliz@gnu.org>
7824
5980d4c6
EZ
7825 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7826 buffers, return left-to-right.
8610fe8b
EZ
7827 (set_cursor_from_row): Consider candidate row a win if its glyph
7828 represents a newline and point is on that newline. Fixes cursor
7829 positioning on the newline at EOL of R2L text within L2R
7830 paragraph, and vice versa.
7831 (try_cursor_movement): Check continued rows, in addition to
7832 continuation rows. Fixes unwarranted scroll when point enters a
7833 continued line of R2L text within an L2R paragraph, or vice versa.
7834 (cursor_row_p): Consider the case of point being equal to
7835 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7836 from the end of a short line to the beginning of a continued line
7837 of R2L text within L2R paragraph.
7838 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7839 composed characters.
5980d4c6 7840
f67cdd7f
EZ
7841 * bidi.c (bidi_check_type): Use xassert.
7842 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7843 members.
7844
bca633fb
EZ
78452011-08-23 Eli Zaretskii <eliz@gnu.org>
7846
7847 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7848 a character.
7849
4a5885a7
CY
78502011-08-23 Chong Yidong <cyd@stupidchicken.com>
7851
7852 * nsfont.m (ns_otf_to_script): Fix typo.
7853
0902a04e
KH
78542011-08-22 Kenichi Handa <handa@m17n.org>
7855
7856 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7857 extra slot even if the purpose is char-code-property-table.
7858
1a2e6670
EZ
78592011-08-23 Eli Zaretskii <eliz@gnu.org>
7860
8ddde651
EZ
7861 * xdisp.c (redisplay_window): When computing centering_position,
7862 account for the height of the header line. (Bug#8874)
7863
425cc014
EZ
7864 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7865 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7866 candidate is selected by the mouse, and that candidate has a
7867 composed character under the mouse.
7868
1a2e6670
EZ
7869 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7870 coordinates reported by pos-visible-in-window-p for a composed
7871 character in column zero.
7872
8b76d6f8
SM
78732011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7874
7875 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7876
dac347dd
EZ
78772011-08-22 Eli Zaretskii <eliz@gnu.org>
7878
7879 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7880 consider it a hit if to_charpos is anywhere in the range of the
7881 composed buffer positions.
7882
e013fb34
CY
78832011-08-22 Chong Yidong <cyd@stupidchicken.com>
7884
7885 * image.c (gif_load): Don't assume that each subimage has the same
7886 dimensions as the base image. Handle disposal method that is
7887 "undefined" by the gif spec (Bug#9335).
7888
bd1ba3e8
CY
78892011-08-20 Chong Yidong <cyd@stupidchicken.com>
7890
7891 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7892 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7893
54a1215b
EZ
78942011-08-19 Eli Zaretskii <eliz@gnu.org>
7895
823564e5
EZ
7896 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7897 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7898 from an Org mode buffer to a Speedbar frame.
7899
54a1215b
EZ
7900 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7901 a composition, take its buffer position from IT->cmp_it.charpos.
7902 Fixes cursor positioning at the beginning of a line that begins
7903 with a composed character.
7904
9778ebcc
EZ
79052011-08-18 Eli Zaretskii <eliz@gnu.org>
7906
0be6ee06
EZ
7907 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7908 character bidirectional type, use STRONG_L instead. Fixes crashes
7909 in a buffer produced by `describe-categories'.
7910
9778ebcc
EZ
7911 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7912 members before the level stack, so they would be saved and
7913 restored when copying iterator state. Fixes incorrect reordering
7914 around TABs covered by display properties.
7915
156bffbe
AS
79162011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7917
6b02f655 7918 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7919
72ad093b
CY
79202011-08-17 Chong Yidong <cyd@stupidchicken.com>
7921
7922 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7923 (internal_condition_case_2, internal_condition_case_n):
7924 Remove unnecessary aborts (Bug#9081).
72ad093b 7925
35774242
EZ
79262011-08-17 Eli Zaretskii <eliz@gnu.org>
7927
7928 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7929 has no `load' handler, try opening the file locally. (Bug#9311)
7930
db76dd85
KB
79312011-08-16 Ken Brown <kbrown@cornell.edu>
7932
7933 * gmalloc.c: Expand comment.
7934
b215eee5
EZ
79352011-08-16 Eli Zaretskii <eliz@gnu.org>
7936
7937 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7938 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7939
a4579d33
KB
79402011-08-16 Ken Brown <kbrown@cornell.edu>
7941
7942 Fix memory allocation problems in Cygwin build (Bug#9273).
7943
7944 * unexcw.c ( __malloc_initialized): Declare external variable.
7945 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7946
8b76d6f8
SM
7947 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7948 New variables.
a4579d33
KB
7949 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7950 dumped emacs.
7951 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7952 in the static heap.
7953 [CYGWIN] (special_realloc): New function.
7954 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7955 requests to realloc storage in the static heap.
7956
3ebec551
PE
79572011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7958
7959 * bidi.c (bidi_initialize): Remove unused local.
7960
9fd8be00
EZ
79612011-08-15 Eli Zaretskii <eliz@gnu.org>
7962
6b02f655
SM
7963 * bidimirror.h:
7964 * biditype.h: Remove file.
7965 * makefile.w32-in ($(BLD)/bidi.$(O)):
7966 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7967
7968 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7969
7970 * chartab.c: Improve commentary for the uniprop_table API.
7971
32413314
EZ
7972 * bidi.c (bidi_paragraph_init): Support zero value of
7973 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7974 (bidi_initialize): Use uniprop_table instead of including
7975 biditype.h and bidimirror.h.
32413314 7976
9fd8be00
EZ
7977 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7978 coordinates of the iterator when restoring from ppos_it.
7979 (Bug#9296)
7980
5cf2b69b
KH
79812011-08-14 Kenichi Handa <handa@m17n.org>
7982
7983 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7984 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7985
daf17d00
EZ
79862011-08-14 Eli Zaretskii <eliz@gnu.org>
7987
7988 * xdisp.c (move_it_in_display_line_to): Don't invoke
7989 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7990 ppos_it. Fixes vertical cursor motion when line beginning is
7991 covered by an image. (Bug#9296)
7992
08e3161a
JD
79932011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7994
7995 * nsterm.h (ns_run_ascript): Declare.
7996 (NSAPP_DATA2_RUNASSCRIPT): Define.
7997
7998 * nsfns.m (as_script, as_result, as_status): New static variables.
7999 (ns_run_ascript): New function.
5e617bc2 8000 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8001 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8002 the event loop. Get status from as_status (Bug#7276).
8003
8004 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8005 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8006 the event loop (Bug#7276).
8007
a3720aa2
AS
80082011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8009
8010 * gnutls.c (QCgnutls_bootprop_priority)
8011 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8012 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8013 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8014 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8015 (QCgnutls_bootprop_verify_hostname_error)
8016 (QCgnutls_bootprop_callbacks_verify): Rename from
8017 Qgnutls_bootprop_..., all uses changed.
8018
8019 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8020 uses changed.
8021
0a0d27fb
PE
80222011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8023
19d5c50c
PE
8024 * xfaces.c (Qframe_set_background_mode): Now static.
8025 * dispextern.h (Qframe_set_background_mode): Remove decl.
8026
0a0d27fb
PE
8027 * process.c (Fnetwork_interface_info): Declare local only if needed.
8028
377538cb
JD
80292011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8030
8031 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8032 (Fnetwork_interface_list): Allocate in increments of bytes instead
8033 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8034 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8035 sockaddr.
8036 (struct ifflag_def): notrailers is smart on OSX.
8037 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8038 Get hardware address with getifaddrs if available.
8039
08fff70c
EZ
80402011-08-12 Eli Zaretskii <eliz@gnu.org>
8041
8042 * xdisp.c (iterate_out_of_display_property): xassert that
8043 IT->position is set to within IT->object's boundaries. Break from
8044 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8045 when IT->position is set up wrongly due to some bug.
8046 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8047 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8048 entry. Force push_it to save on the stack the current
8049 buffer/string position, to be restored by pop_it. Fix flags in
8050 the iterator structure wrt the object coming from a display
8051 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8052 properties. (Bug#9284)
8053
7be1c708 80542011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8055
7be1c708
CY
8056 * fontset.c (fontset_get_font_group): Add proper type checks.
8057 (Bug#9172)
aac0c6e3 8058
7be1c708 80592011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8060
7be1c708
CY
8061 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8062 and LC_VERSION_MIN_MACOSX.
8063 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8064 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8065
97bb72a6
EZ
80662011-08-08 Eli Zaretskii <eliz@gnu.org>
8067
8068 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8069 no-display-properties-and-no-overlays under bidi display.
8070 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8071 properties and overlays.
97bb72a6 8072
d5617611
CY
80732011-08-08 Chong Yidong <cyd@stupidchicken.com>
8074
37e11a63
CY
8075 * editfns.c (Fset_time_zone_rule): Document relationship with the
8076 setenv function.
8077
d5617611
CY
8078 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8079 the font entity extracted from the cache (Bug#8109).
8080
58872834
CY
80812011-08-07 Chong Yidong <cyd@stupidchicken.com>
8082
8083 * composite.c (autocmp_chars): Don't reset point. That is done by
8084 restore_point_unwind (Bug#5984).
8085
75bfc667
JL
80862011-08-07 Juri Linkov <juri@jurta.org>
8087
8088 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8089 to show the arg `TIME' instead of `TIMEVAL'.
8090
d1410150
EZ
80912011-08-06 Eli Zaretskii <eliz@gnu.org>
8092
8093 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8094 display property strides EOL and includes a newline, as in
8095 longlines-mode. (Bug#9254)
75b771e4
EZ
8096 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8097 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8098
8099 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8100 is non-zero, even if the data buffer is NULL. Fixes a crash in
8101 vertical-motion with longlines-mode. (Bug#9254)
8102
35928349
EZ
81032011-08-05 Eli Zaretskii <eliz@gnu.org>
8104
ec7cc85b
EZ
8105 * bidi.c <bidi_cache_total_alloc>: Now static.
8106 (bidi_initialize): Initialize bidi_cache_total_alloc.
8107
8b76d6f8 8108 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8109 cache. (Bug#9221)
8110
8111 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8112 amount allocated this far in `bidi_cache_total_alloc'.
8113 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8114 non-zero, only free the data buffer without restoring the cache
8115 contents. All callers changed.
8116
8117 * dispextern.h (bidi_unshelve_cache): Update prototype.
8118
8119 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8120 (move_it_in_display_line, move_it_to)
8121 (move_it_vertically_backward, move_it_by_lines): Replace the call
8122 to xfree to an equivalent call to bidi_unshelve_cache.
8123 (move_it_in_display_line_to): Fix logic of returning
412b6358 8124 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8125
e2e2423b
EZ
81262011-08-05 Eli Zaretskii <eliz@gnu.org>
8127
8128 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8129 came from a string character with a `cursor' property. (Bug#9229)
8130
ae9e757a
JD
81312011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8132
8133 * Makefile.in (LIB_PTHREAD): New variable.
8134 (LIBES): Add LIB_PTHREAD (Bug#9216).
8135
8136 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8137 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8138
213bd7f2
AS
81392011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8140
6b02f655 8141 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8142
99aaf75f
JD
81432011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8144
8145 * xterm.c (x_find_topmost_parent): New function.
8146 (x_set_frame_alpha): Find topmost parent window with
8147 x_find_topmost_parent and set the property there also (bug#9181).
8148 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8149
c74e9d86
PE
81502011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8151
8152 * callproc.c (Fcall_process): Avoid vfork clobbering
8153 the local vars buffer, coding_systems, current_dir.
8154
640c8776
SM
81552011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8156
8157 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8158
f26d0e4c
PE
81592011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8160
8a10d76c
PE
8161 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8162 so that it is not optimized away.
8163
f26d0e4c
PE
8164 * xdisp.c (compute_display_string_pos): Remove unused local.
8165
55439c61
EZ
81662011-08-02 Eli Zaretskii <eliz@gnu.org>
8167
8168 Fix slow cursor motion and scrolling in large buffers with
8169 selective display, like Org Mode buffers. (Bug#9218)
8170
8171 * dispextern.h (struct bidi_it): New member disp_prop_p.
8172
8173 * xdisp.c: Remove one-slot cache of display string positions.
8174 (compute_display_string_pos): Accept an additional argument
5e617bc2 8175 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8176 for a display string or property. If found, set DISP_PROP_P
8177 non-zero.
8178
8179 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8180 DISP_PROP_P, and pass it to compute_display_string_pos.
8181 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8182 non-zero. All callers of bidi_fetch_char changed.
8183
fb33fa43
SM
81842011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8185
8186 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8187
b099e063
DM
81882010-12-03 Don March <don@ohspite.net>
8189
8190 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8191 last character M-[char] is translated to ESC [char] (bug#7541).
8192
5cc7f7af
KH
81932011-08-02 Kenichi Handa <handa@m17n.org>
8194
d0fffa3f 8195 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8196
8197 * chartab.c (uniprop_table): Make it non-static.
8198
525d5e6e
EZ
81992011-08-01 Eli Zaretskii <eliz@gnu.org>
8200
8201 * xdisp.c (forward_to_next_line_start): Accept additional argument
8202 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8203 on the newline.
8204 (reseat_at_next_visible_line_start): Use the bidi iterator state
8205 returned by forward_to_next_line_start to restore the state of
8206 it->bidi_it after backing up to previous newline. (Bug#9212)
8207
31011111
AS
82082011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8209
8210 * regex.c (re_comp): Protoize.
8211 (re_exec): Fix return type.
8212 (regexec): Fix type of `ret'. (Bug#9203)
8213
476371c4
PE
82142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8215
e5d76069
PE
8216 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8217 This is needed if max-image-size is a floating-point number.
8218
9a79b20c
AS
82192011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8220
8221 * print.c (print_object): Print empty symbol as ##.
8222
8223 * lread.c (read1): Read ## as empty symbol.
8224
d8c2fa78
AA
82252011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8226
8227 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8228 setting frame foreground color (Bug#9175).
8229 (x_set_background_color): Likewise.
8230
ffe57a7a
AA
8231 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8232 contents (Bug#9176).
8233 (EmacsTooltip -init): Remove bezels and add shadows to
8234 tooltip windows.
8235
bf3492a5
AA
8236 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8237 or scroll bar (Bug#8470).
8238
d55e9c53
AA
8239 * nsfont.m (nsfont_open): Remove assignment to voffset and
8240 unnecessary vars hshink, expand, hd, full_height, min_height.
8241 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8242
8243 * nsterm.h (nsfont_info): Remove voffset field.
8244
d8c2fa78 82452011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8246
8247 Implement strike-through and overline on NextStep (Bug#8863).
8248
8249 * nsfont.m (nsfont_open): Use underline position provided by font,
8250 instead of hard-coded value of 2.
8251 (nsfont_draw): Call ns_draw_text_decoration instead.
8252
8253 * nsterm.h: Add declaration for ns_draw_text_decoration.
8254
8255 * nsterm.m (ns_draw_text_decoration): New function for drawing
8256 underline, overline, and strike-through.
8257 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8258 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8259 accommodate underlining, etc.
4843aac3 8260
4cc60b9b
EZ
82612011-07-28 Eli Zaretskii <eliz@gnu.org>
8262
bc7ece87
EZ
8263 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8264 default.
4cc60b9b 8265
476371c4
PE
82662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8267
66606eea
PE
8268 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8269 Without this fix, if a signal arrives just after memory fills up,
8270 'malloc' might be invoked reentrantly.
8271
476371c4
PE
8272 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8273 In other words, assume that every image size is allowed, on non-X
8274 hosts. This assumption is probably wrong, but it lets Emacs compile.
8275
f3fcc40d
AS
82762011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8277
8278 * regex.c (re_iswctype): Convert return values to boolean.
8279
350c992f
EZ
82802011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8281
8282 * xdisp.c (compute_display_string_pos): Don't use cached display
8283 string position if the buffer had its restriction changed.
8284 (Bug#9184)
8285
5266b4bb
PE
82862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8287
8288 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8289
2573a837 82902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8291
41f55ccd 8292 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8293
39e378da
PE
8294 * bidi.c: Integer size and overflow fixes.
8295 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8296 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8297 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8298 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8299 (bidi_find_other_level_edge):
8300 Use ptrdiff_t instead of EMACS_INT where either will do.
8301 This works better on 32-bit hosts configured --with-wide-int.
8302 (bidi_cache_ensure_space): Check for size-calculation overflow.
8303 Use % rather than repeated addition, for better worst-case speed.
8304 Don't set bidi_cache_size until after xrealloc returns, because it
8305 might not return.
8306 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8307 (bidi_cache_ensure_space): Also check that the bidi cache size
8308 does not exceed that of the largest Lisp string or buffer. See Eli
8309 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8310
5e927815
PE
8311 * alloc.c (__malloc_size_t): Remove.
8312 All uses replaced by size_t. See Andreas Schwab's note
8313 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8314
ca4aa935
PE
8315 * image.c: Improve checking for integer overflow.
8316 (check_image_size): Assume that f is nonnull, since
8317 it is always nonnull in practice. This is one less thing to
8318 worry about when checking for integer overflow later.
8319 (x_check_image_size): New function, which checks for integer
8320 overflow issues inside X.
8321 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8322 This removes the need for a memory_full check.
8323 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8324 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8325 (xbm_read_bitmap_data): Change locals back to 'int', since
8326 their values must fit in 'int'.
8327 (xpm_load_image, png_load, tiff_load):
8328 Invoke x_create_x_image_and_pixmap earlier,
8329 to avoid much needless work if the image is too large.
8330 (tiff_load): Treat overly large images as if
8331 x_create_x_image_and_pixmap failed, not as malloc failures.
8332 (gs_load): Use x_check_image_size.
8333
5f8f9cc2
PE
8334 * gtkutil.c: Omit integer casts.
8335 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8336 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8337
5adf60bc
PE
8338 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8339
c8907a93
PE
8340 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8341 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8342 would wrongly return t on a 64-bit host.
8343
e3c25c68
PE
8344 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8345 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8346 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8347 and therefore cause GCC to emit a bogus diagnostic in some cases.
8348
3f791afe
PE
8349 * image.c: Integer signedness and overflow and related fixes.
8350 This is not an exhaustive set of fixes, but it's time to
8351 record what I've got.
8352 (lookup_pixel_color, check_image_size): Remove redundant decls.
8353 (check_image_size): Don't assume that arbitrary EMACS_INT values
8354 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8355 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8356 (tiff_load, imagemagick_load_image):
8357 Check for overflow in size calculations.
8358 (x_create_x_image_and_pixmap): Remove unnecessary test for
8359 xmalloc returning NULL; that can't happen.
8360 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8361 (xpm_color_bucket): Use better integer hashing function.
8362 (xpm_cache_color): Don't possibly over-allocate memory.
8363 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8364 (gif_memory_source):
8365 Use ptrdiff_t, not int or size_t, to record sizes.
8366 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8367 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8368 either works, as we prefer signed integers.
8369 (tiff_read_from_memory, tiff_write_from_memory):
8370 Return tsize_t, not size_t, since that's what the TIFF API wants.
8371 (tiff_read_from_memory): Don't fail simply because the read would
8372 go past EOF; instead, return a short read.
8373 (tiff_load): Omit no-longer-needed casts.
8374 (Fimagemagick_types): Don't assume size fits into 'int'.
8375
3cc5a532
PE
8376 Improve hashing quality when configured --with-wide-int.
8377 * fns.c (hash_string): New function, taken from sxhash_string.
8378 Do not discard information about ASCII character case; this
8379 discarding is no longer needed.
8380 (sxhash-string): Use it. Change sig to match it. Caller changed.
8381 * lisp.h: Declare it.
8382 * lread.c (hash_string): Remove, since we now use fns.c's version.
8383 The fns.c version returns a wider integer if --with-wide-int is
8384 specified, so this should help the quality of the hashing a bit.
8385
b312a492
PE
8386 * emacs.c: Integer overflow minor fix.
8387 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8388 Define only if GNU_LINUX.
8389 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8390
dfd153ae
PE
8391 * dispnew.c: Integer signedness and overflow fixes.
8392 Remove unnecessary forward decls, that were a maintenance hassle.
8393 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8394 All uses changed.
8395 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8396 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8397 (prepare_desired_row, line_draw_cost):
8398 Use int, not unsigned, where either works.
8399 (save_current_matrix, restore_current_matrix):
8400 Use ptrdiff_t, not size_t, where either works.
8401 (init_display): Check for overflow more accurately, and without
8402 relying on undefined behavior.
8403
a81d11a3
PE
8404 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8405 Remove, replacing with the new symbols in lisp.h. All uses changed.
8406 * fileio.c (make_temp_name):
8407 * filelock.c (lock_file_1, lock_file):
8408 * xdisp.c (message_dolog):
8409 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8410 Use pMd etc. instead.
8411 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8412 replacing the pWIDE etc. symbols removed from editfns.c.
8413
3300e6fd
PE
8414 * keyboard.h (num_input_events): Now uintmax_t.
8415 This is (very slightly) less likely to mess up due to wraparound.
8416 All uses changed.
8417
fd05c7e9
PE
8418 * buffer.c: Integer signedness fixes.
8419 (alloc_buffer_text, enlarge_buffer_text):
8420 Use ptrdiff_t rather than size_t when either will do, as we prefer
8421 signed integers.
8422
903fe15d
PE
8423 * alloc.c: Integer signedness and overflow fixes.
8424 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8425 (__malloc_size_t): Default to size_t, not to int.
8426 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8427 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8428 Prefer ptrdiff_t to size_t when either would do, as we prefer
8429 signed integers.
8430 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8431 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8432 Now const. Initialize with values that are in range even if char
8433 is signed.
8434 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8435 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8436 These functions do the right thing with sizes > 2**32.
8437 (check_depth): Now ptrdiff_t, not int.
8438 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8439 Adjust to new way of storing sizes. Check for size overflow bugs
8440 in rest of code.
8441 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8442 slightly wrong anyway, as it missed one instance of
8443 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8444 (refill_memory_reserve): Omit needless cast to size_t.
8445 (mark_object_loop_halt): Mark as externally visible.
8446
ac82cc6a
PE
8447 * xselect.c: Integer signedness and overflow fixes.
8448 (Fx_register_dnd_atom, x_handle_dnd_message):
8449 Use ptrdiff_t, not size_t, since we prefer signed.
8450 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8451 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8452 x_dnd_atoms_size and x_dnd_atoms_length.
8453
c2d1e36d
PE
8454 * doprnt.c: Prefer signed to unsigned when either works.
8455 * eval.c (verror):
8456 * doprnt.c (doprnt):
8457 * lisp.h (doprnt):
8458 * xdisp.c (vmessage):
8459 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8460 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8461 prefer signed arithmetic to avoid comparison confusion.
8462 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8463 but is a bit tricky.
8464
0e926e56
PE
8465 Assume freestanding C89 headers, string.h, stdlib.h.
8466 * data.c, doprnt.c, floatfns.c, print.c:
8467 Include float.h unconditionally.
8468 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8469 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8470 * regex.c: Likewise for stddef.h, string.h.
8471 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8472 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8473 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8474 (STDC_HEADERS): Remove obsolete defines.
8475 * sysdep.c: Include limits.h unconditionally.
8476
9cfdb3ec
PE
8477 Assume support for memcmp, memcpy, memmove, memset.
8478 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8479 * regex.c (memcmp, memcpy):
8480 Remove; we assume C89 now.
8481
8482 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8483 (__malloc_safe_bcopy): Remove; no longer needed.
8484
cf950e6b 8485 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8486 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8487 well either way, and we prefer signed to unsigned.
8488
dbf38e02
LMI
84892011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8490
8491 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8492 closes the connection while we're reading (bug#9182).
8493
d6f0886c 84942011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8495
d6f0886c
JD
8496 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8497 are specified (Bug#9168).
24e0f6b1 8498
2eb1f9e6
PE
84992011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8500
8501 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8502 Found by GCC static checking and --with-wide-int on a 32-bit host.
8503
22381272 85042011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8505
8506 * xdisp.c (compute_display_string_pos): Fix logic of caching
8507 previous display string position. Initialize cached_prev_pos to
8508 -1. Fixes slow-down at the beginning of a buffer.
8509
f25e39b4
EZ
85102011-07-24 Eli Zaretskii <eliz@gnu.org>
8511
8512 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8513 for attrs[LFACE_FONTSET_INDEX].
8514
04c4b52e
PE
85152011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8516
8517 * xml.c (parse_region): Remove unused local
8518 that was recently introduced.
8519
c1734fbd
EZ
85202011-07-23 Eli Zaretskii <eliz@gnu.org>
8521
be18c5a5
EZ
8522 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8523 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8524
c1734fbd
EZ
8525 * xdisp.c (move_it_in_display_line_to): Record the best matching
8526 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8527 exit if none of the characters scanned was an exact match.
8528 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8529 when exact match is impossible due to invisible text, and the
8530 lines are truncated.
8531
a258d627
JD
85322011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8533
8534 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8535 for OSX >= 10.7.
8536
b6d5a689
EZ
85372011-07-22 Eli Zaretskii <eliz@gnu.org>
8538
0f74f785
EZ
8539 Fix a significant slow-down of cursor motion with C-n, C-p,
8540 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8541 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8542 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8543 (next_element_from_buffer): Call compute_stop_pos_backwards to
8544 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8545 base_level_stop.
8546 (reseat): Don't look for prev_stop, as that could mean a very long
8547 run.
8548 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8549 <cached_disp_overlay_modiff>: Cache for last found display string
8550 position.
551918c1 8551 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8552 about the same buffer in the same area of character positions, and
8553 the buffer wasn't changed since the time the display string
8554 position was cached.
551918c1 8555
b2d0c91a
EZ
85562011-07-22 Eli Zaretskii <eliz@gnu.org>
8557
8558 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8559 is an integer, which is important for empty lines. (Bug#9149)
8560
043604ee
CY
85612011-07-22 Chong Yidong <cyd@stupidchicken.com>
8562
8563 * frame.c (Fmodify_frame_parameters): In tty case, update the
8564 default face if necessary (Bug#4238).
8565
da4adb04
CY
85662011-07-21 Chong Yidong <cyd@stupidchicken.com>
8567
8568 * editfns.c (Fstring_to_char): No need to explain what a character
8569 is in the docstring (Bug#6576).
8570
9abd0532
LMI
85712011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8572
8573 * xml.c (parse_region): Make sure we always return a tree.
8574
36881d16
HK
85752011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8576
8577 * xml.c (parse_region): If a document contains only comments,
8578 return that, too.
8579
1e98674d
LMI
85802011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8581
8582 * xml.c (make_dom): Return comments, too.
8583
590bd467
PE
85842011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8585
8586 Port to OpenBSD.
8587 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8588 and the surrounding thread.
8589 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8590 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8591 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8592 timer goes off.
8593 * s/openbsd.h (BROKEN_SIGIO): Define.
8594 * unexelf.c (unexec) [__OpenBSD__]:
8595 Don't update the .mdebug section of the Alpha COFF symbol table.
8596
f41628b2
LMI
85972011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8598
8599 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8600 (bug#8460).
8601
b59b67c5
PE
86022011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8603
15e3a074
PE
8604 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8605 This fixes some race conditions on the permissions of any newly
8606 created file.
8607
41bed37d
PE
8608 * alloc.c (valid_pointer_p): Use pipe, not open.
8609 This fixes some permissions issues when debugging.
8610
b59b67c5
PE
8611 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8612 If fchown fails to set both uid and gid, try to set just gid,
8613 as that is sometimes allowed. Adjust the file's mode to eliminate
8614 setuid or setgid bits that are inappropriate if fchown fails.
8615
925a6be7
SM
86162011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8617
8618 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8619 to compare Lisp_Objects.
8620 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8621 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8622 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8623
52968808
AS
86242011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8625
0a6a104b
AS
8626 * lread.c (read_integer): Unread even EOF character.
8627 (read1): Likewise. Properly record start position of symbol.
8628
52968808
AS
8629 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8630 symbol character follows.
8631
9e381cdd
PE
86322011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8633
8634 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8635 This works around a problem with the previous change to Fcopy_file.
8636 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8637 and without this change, GCC might complain about discarding
8638 fchown's return value.
8639
b5641435
JB
86402011-07-16 Juanma Barranquero <lekktu@gmail.com>
8641
8642 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8643
a8031457
PE
86442011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8645
8646 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8647
dd889327
LMI
86482011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8649
750c33f7
LMI
8650 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8651 it's used from the C level.
8652
dd889327
LMI
8653 * process.c: Use the same condition for POLL_FOR_INPUT in both
8654 keyboard.c and process.c (bug#1858).
8655
87e86684
LM
86562011-07-09 Lawrence Mitchell <wence@gmx.li>
8657
8658 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8659 (Fgnutls_boot): Use it.
8660
64348f40
AS
86612011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8662
8663 * doc.c (Fsubstitute_command_keys): Revert last change.
8664
1d698799
LMI
86652011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8666
f863868c
LMI
8667 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8668 quotes the next character, and doesn't affect other longer
8669 sequences (bug#8935).
8670
1d698799
LMI
8671 * lread.c (syms_of_lread): Clarify that is isn't only
8672 `eval-buffer' and `eval-defun' that's affected by
8673 `lexical-binding' (bug#8460).
8674
aa4b6df6
EZ
86752011-07-15 Eli Zaretskii <eliz@gnu.org>
8676
8677 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8678 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8679
5d856da6
PE
86802011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8681
ad6042bb
PE
8682 Fix minor problems found by static checking.
8683 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8684 (elsz): Now a signed constant, not a size_t var. We prefer signed
8685 types to unsigned, to avoid integer comparison confusion. Without
8686 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8687 "cannot optimize loop, the loop counter may overflow", a symptom
8688 of the confusion.
f00bbb22 8689 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8690 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8691
6468f31c
LMI
86922011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8693
49080b10
LMI
8694 * search.c (Fre_search_backward): Mention `case-fold-search' in
8695 all the re_search_* functions (bug#8138).
8696
6468f31c
LMI
8697 * keyboard.c (Fopen_dribble_file): Document when the file is
8698 closed (bug#8056).
8699
c965adc5
EZ
87002011-07-14 Eli Zaretskii <eliz@gnu.org>
8701
df9733bf
EZ
8702 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8703 bidi_cache_idx.
8704
0bb23927
EZ
8705 Support bidi reordering of display and overlay strings.
8706 * xdisp.c (compute_display_string_pos)
8707 (compute_display_string_end): Accept additional argument STRING.
8708 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8709 (reseat_to_string): Initialize bidi_it->string.s and
8710 bidi_it->string.schars.
8711 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8712 NULL (avoids a crash in bidi_paragraph_init).
8713 Initialize itb.string.lstring.
0bb23927
EZ
8714 (init_iterator): Call bidi_init_it only of a valid
8715 buffer position was specified. Initialize paragraph_embedding to
8716 L2R.
8717 (reseat_to_string): Initialize the bidi iterator.
8718 (display_string): If we need to ignore text properties of
8719 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8720 original value of -1 will not work with bidi.)
8721 (compute_display_string_pos): First arg is now struct
8722 `text_pos *'; all callers changed. Support display properties on
8723 Lisp strings.
8724 (compute_display_string_end): Support display properties on Lisp
8725 strings.
8726 (init_iterator, reseat_1, reseat_to_string): Initialize the
8727 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8728 when iterating on a string not from display properties).
640c8776
SM
8729 (compute_display_string_pos, compute_display_string_end):
8730 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8731 arrow keys.
8732 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8733 base_level_stop; instead, set base_level_stop to BEGV.
8734 Fixes crashes in vertical-motion.
0bb23927
EZ
8735 (next_element_from_buffer): Improve commentary for when
8736 the iterator is before prev_stop.
8737 (init_iterator): Initialize bidi_p from the default value of
8738 bidi-display-reordering, not from buffer-local value. Use the
8739 buffer-local value only if initializing for buffer iteration.
8740 (handle_invisible_prop): Support invisible properties on strings
8741 that are being bidi-reordered.
8742 (set_iterator_to_next): Support bidi reordering of C strings and
8743 Lisp strings.
8744 (next_element_from_string): Support bidi reordering of Lisp
8745 strings.
8746 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8747 (display_string): Support display of R2L glyph rows.
8748 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8749 (init_iterator): Don't initialize it->bidi_p for strings
8750 here.
8751 (reseat_to_string): Initialize it->bidi_p for strings here.
8752 (next_element_from_string, next_element_from_c_string)
8753 (next_element_from_buffer): Add xassert's for correspondence
8754 between IT's object being iterated and it->bidi_it.string
8755 structure.
8756 (face_before_or_after_it_pos): Support bidi iteration.
8757 (next_element_from_c_string): Handle the case of the first string
8758 character that is not the first one in the visual order.
8759 (get_visually_first_element): New function, refactored from common
8760 parts of next_element_from_buffer, next_element_from_string, and
8761 next_element_from_c_string.
8762 (tool_bar_lines_needed, redisplay_tool_bar)
8763 (display_menu_bar): Force left-to-right direction. Add a FIXME
8764 comment for making that be controlled by a user option.
8765 (push_it, pop_it): Save and restore the state of the
8766 bidi iterator. Save and restore the bidi_p flag.
8767 (pop_it): Iterate out of display property for string iteration as
8768 well.
8769 (iterate_out_of_display_property): Support iteration over strings.
8770 (handle_single_display_spec): Set up it->bidi_it for iteration
8771 over a display string, and call bidi_init_it.
8772 (handle_single_display_spec, next_overlay_string)
8773 (get_overlay_strings_1, push_display_prop): Set up the bidi
8774 iterator for displaying display or overlay strings.
8775 (forward_to_next_line_start): Don't use the shortcut if
8776 bidi-iterating.
8777 (back_to_previous_visible_line_start): If handle_display_prop
8778 pushed the iterator stack, restore the internal state of the bidi
8779 iterator by calling bidi_pop_it same number of times.
8780 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8781 and we are bidi-iterating, don't decrement the iterator position;
8782 instead, set the first_elt flag in the bidi iterator, to produce
8783 the same effect.
8784 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8785 (push_display_prop): xassert that we are iterating a buffer.
8786 (push_it, pop_it): Save and restore paragraph_embedding member.
8787 (handle_single_display_spec, next_overlay_string)
8788 (get_overlay_strings_1, reseat_1, reseat_to_string)
8789 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8790 correctly. Don't assume unibyte strings are not bidi-reordered.
8791 (compute_display_string_pos)
8792 (compute_display_string_end): Fix handling the case of C string.
8793 (push_it, pop_it): Save and restore from_disp_prop_p.
8794 (handle_single_display_spec, push_display_prop): Set the
8795 from_disp_prop_p flag.
8796 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8797 (pop_it): Call iterate_out_of_display_property only if we are
8798 popping after iteration over a string that came from a display
8799 property. Fix a typo in popping stretch info. Add an assertion
8800 for verifying that the iterator position is in sync with the bidi
8801 iterator.
8802 (handle_single_display_spec, get_overlay_strings_1)
8803 (push_display_prop): Fix initialization of paragraph direction for
8804 string when that of the parent object is not yet determined.
8805 (reseat_1): Call bidi_init_it to resync the bidi
8806 iterator with IT's position. (Bug#7616)
8807 (find_row_edges): If ROW->start.pos gives position
8808 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8809 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8810 Reset the from_disp_prop_p flag.
8811 (SAVE_IT, RESTORE_IT): New macros.
8812 (pos_visible_p, face_before_or_after_it_pos)
8813 (back_to_previous_visible_line_start)
8814 (move_it_in_display_line_to, move_it_in_display_line)
8815 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8816 (try_scrolling, redisplay_window, display_line): Use them when
8817 saving a temporary copy of the iterator and restoring it back.
8818 (back_to_previous_visible_line_start, reseat_1)
8819 (init_iterator): Empty the bidi cache "stack".
8820 (move_it_in_display_line_to): If iterator ended up at
8821 EOL, but we never saw any buffer positions smaller than
8822 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8823 motion in bidi-reordered lines.
8824 (move_it_in_display_line_to): Record prev_method and prev_pos
8825 immediately before the call to set_iterator_to_next. Fixes cursor
8826 motion in bidi-reordered lines with stretch glyphs and strings
8827 displayed in margins. (Bug#8133) (Bug#8867)
8828 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8829 TO_CHARPOS.
640c8776
SM
8830 (pos_visible_p): Support positions in bidi-reordered lines.
8831 Save and restore bidi cache.
0bb23927
EZ
8832
8833 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8834 (bidi_paragraph_info): Delete unused struct.
8835 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8836 (bidi_cache_start): New variable.
8837 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8838 to zero.
8839 (bidi_cache_fetch_state, bidi_cache_search)
8840 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8841 (bidi_cache_find, bidi_peek_at_next_level)
8842 (bidi_level_of_next_char, bidi_find_other_level_edge)
8843 (bidi_move_to_visually_next): Compare cache index with
8844 bidi_cache_start rather than with zero.
8845 (bidi_fetch_char): Accept new argument STRING; all callers
8846 changed. Support iteration over a string. Support strings with
8847 display properties. Support unibyte strings. Fix the type of
8848 `len' according to what STRING_CHAR_AND_LENGTH expects.
8849 (bidi_paragraph_init, bidi_resolve_explicit_1)
8850 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8851 (bidi_level_of_next_char, bidi_move_to_visually_next):
8852 Support iteration over a string.
0bb23927
EZ
8853 (bidi_set_sor_type, bidi_resolve_explicit_1)
8854 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8855 can now be zero (for strings); special values 0 and -1 were
8856 changed to -1 and -2, respectively.
8857 (bidi_char_at_pos): New function.
8858 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8859 Call it instead of FETCH_MULTIBYTE_CHAR.
8860 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8861 initialized to valid values.
8862 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8863 values.
8864 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8865 the test for valid cached positions. Fix the logic for looking up
8866 the sentinel state in the cache. GCPRO the Lisp string we are
8867 iterating.
8868 (bidi_push_it, bidi_pop_it): New functions.
8869 (bidi_initialize): Initialize the bidi cache start stack pointer.
8870 (bidi_cache_ensure_space): New function, refactored from part of
8871 bidi_cache_iterator_state. Don't assume the required size is just
8872 one BIDI_CACHE_CHUNK away.
8873 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8874 (bidi_count_bytes, bidi_char_at_pos): New functions.
8875 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8876 always valid if bidi_cache_idx is valid.
8877 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8878 is valid if it's going to be used.
8879 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8880 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8881 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8882 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8883 (bidi_find_other_level_edge, bidi_cache_start_stack):
8884 All variables related to cache indices are now EMACS_INT.
c965adc5 8885
0bb23927
EZ
8886 * dispextern.h (struct bidi_string_data): New structure.
8887 (struct bidi_it): New member `string'. Make flag members be 1-bit
8888 fields, and put them last in the struct.
640c8776
SM
8889 (compute_display_string_pos, compute_display_string_end):
8890 Update prototypes.
0bb23927
EZ
8891 (bidi_push_it, bidi_pop_it): Add prototypes.
8892 (struct iterator_stack_entry): New members bidi_p,
8893 paragraph_embedding, and from_disp_prop_p.
8894 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8895 (bidi_shelve_cache, bidi_unshelve_cache):
8896 Declare prototypes.
0bb23927
EZ
8897
8898 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8899 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8900 and vector-like objects.
8901
8902 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8903 cache around display iteration.
8904
8905 * window.c (Fwindow_end, window_scroll_pixel_based)
8906 (displayed_window_lines, Frecenter): Save and restore the bidi
8907 cache around display iteration.
8908
3bbd2265
LMI
89092011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8910
8911 * editfns.c (Fdelete_region): Clarify the use of the named
8912 parameters (bug#6788).
8913
adc47434
MR
89142011-07-14 Martin Rudalics <rudalics@gmx.at>
8915
8916 * indent.c (Fvertical_motion): Set and restore w->pointm when
8917 saving and restoring the window's buffer (Bug#9006).
8918
837c31f8
LMI
89192011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8920
8921 * editfns.c (Fstring_to_char): Clarify just what is returned
8922 (bug#6576). Text by Eli Zaretskii.
8923
ac389d0c
JB
89242011-07-13 Juanma Barranquero <lekktu@gmail.com>
8925
8926 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8927
0be0ce47
EZ
89282011-07-13 Eli Zaretskii <eliz@gnu.org>
8929
8930 * buffer.c (mmap_find): Fix a typo.
8931
cd18e7e3
JB
89322011-07-13 Johan Bockgård <bojohan@gnu.org>
8933
8934 Fix execution of x selection hooks.
8935 * xselect.c (Qx_lost_selection_functions)
8936 (Qx_sent_selection_functions): New vars.
8937 (syms_of_xselect): DEFSYM them.
8938 (x_handle_selection_request): Pass Qx_sent_selection_functions
8939 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8940 (x_handle_selection_clear,x_clear_frame_selections):
8941 Pass Qx_lost_selection_functions rather than
8942 Vx_lost_selection_functions to Frun_hook_with_args.
8943
47ea7f44
PE
89442011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8945
ac389d0c 8946 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8947 The old code sometimes used this field without initializing it.
8948
47ea7f44
PE
8949 * alloc.c (gc_sweep): Don't read past end of array.
8950 In theory, the old code could also have corrupted Emacs internals,
8951 though it'd be very unlikely.
8952
bc985c87
AS
89532011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8954
8955 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8956 argument. (Bug#4026)
bc985c87 8957
0cf34688
LMI
89582011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8959
b3dadd76
LMI
8960 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8961 key" (bug#4257).
8962
0cf34688
LMI
8963 * window.c (Fset_window_start): Doc fix (bug#4199).
8964 (Fset_window_hscroll): Ditto.
8965
270768cd
PE
89662011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8967
077e3dda 8968 Fix minor new problems caught by GCC 4.6.1.
270768cd 8969 * term.c (init_tty): Remove unused local.
490011a6 8970 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8971 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8972 not used otherwise.
270768cd 8973
b1f58454
CY
89742011-07-12 Chong Yidong <cyd@stupidchicken.com>
8975
8976 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8977
22b9578d
LMI
89782011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8979
6e70ab07
LMI
8980 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8981 are the mini-buffer and the echo area (bug#3320).
8982
22b9578d
LMI
8983 * term.c (init_tty): Remove support for supdup, c10 and perq
8984 terminals, which are no longer supported (bug#1482).
8985
8974cc9f
JB
89862011-07-10 Johan Bockgård <bojohan@gnu.org>
8987
8988 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8989
a560d974
JD
89902011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8991
8992 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8993 for non-popups (Bug#3642).
8994
1dae0f0a
AS
89952011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8996
268c2c36 8997 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8998 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8999 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9000 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9001 * data.c (fmod): Likewise.
9002 * dispnew.c (swap_glyphs_in_rows): Likewise.
9003 * emacs.c (memory_warning_signal): Likewise.
9004 * floatfns.c (float_error): Likewise.
9005 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9006 (otf_open, font_otf_capability, generate_otf_features)
9007 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9008 Likewise.
9009 * image.c (pbm_read_file): Likewise.
9010 * indent.c (string_display_width): Likewise.
9011 * intervals.c (check_for_interval, search_for_interval)
9012 (inc_interval_count, count_intervals, root_interval)
9013 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9014 * lread.c (defalias): Likewise.
268c2c36 9015 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9016 * regex.c (set_image_of_range_1, set_image_of_range)
9017 (regex_grow_registers): Likewise.
9018 * sysdep.c (strerror): Likewise.
9019 * termcap.c (valid_filename_p, tprint, main): Likewise.
9020 * tparam.c (main): Likewise.
9021 * unexhp9k800.c (run_time_remap, save_data_space)
9022 (update_file_ptrs, read_header, write_header, calculate_checksum)
9023 (copy_file, copy_rest, display_header): Likewise.
9024 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9025 Likewise.
9026 * xdisp.c (check_it): Likewise.
9027 * xfaces.c (register_color, unregister_color, unregister_colors):
9028 Likewise.
9029 * xfns.c (print_fontset_result): Likewise.
9030 * xrdb.c (member, fatal, main): Likewise.
9031
99033785
PE
90322011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9033
9034 Fix minor problems found by static checking (Bug#9031).
9035 * chartab.c (char_table_set_range, map_sub_char_table):
9036 Remove unused locals.
9037 (uniprop_table): Now static.
9038 * composite.c (_work_char): Remove unused static var.
9039
9cb2ac56
JB
90402011-07-09 Juanma Barranquero <lekktu@gmail.com>
9041
9042 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9043
f25661f0
JD
90442011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9045
9046 * gtkutil.c (qttip_cb): Remove code without function.
9047
8278c4fe
EZ
90482011-07-09 Eli Zaretskii <eliz@gnu.org>
9049
9050 * w32.c (pthread_sigmask): New stub.
9051
1692ae2d 90522011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9053
8a6ebd58 9054 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9055 sigprocmask is portable only for single-threaded applications, and
9056 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9057 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9058 (LIBES): Use it.
9059 * callproc.c (Fcall_process):
9060 * process.c (create_process):
9061 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9062 Use pthread_sigmask, not sigprocmask.
123403e4 9063
1b854618
JD
90642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9065
9066 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9067 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9068 wrong (Bug#8591).
9069
3fe4b549
JD
90702011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9071
0ce7e563
JD
9072 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9073 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9074 (xg_hide_tooltip): Fix comment.
9075
3fe4b549
JD
9076 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9077 in registerServicesMenuSendTypes.
9078 (validRequestorForSendType): Don't check ns_return_types.
9079
9080 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9081 ns_return_type.
9082
5df75e47
JR
90832011-07-08 Jason Rumney <jasonr@gnu.org>
9084
22610910
JR
9085 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9086 SH_SHOW for hidden windows (Bug#5482).
9087
5df75e47
JR
9088 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9089 frame struct members of non-existent frames (Bug#6284).
9090
699c10bd
JD
90912011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9092
4393663b
JD
9093 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9094 variable firstTime not needed on OSX >= 10.6.
9095 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9096 >= 10.5. Use setKnobProportion, setDoubleValue.
9097
9098 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9099 (MAC_OS_X_VERSION_10_5): Define if not defined.
9100 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9101 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9102 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9103
9104 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9105 cString and lossyCString on OSX >= 10.4.
4393663b 9106
58179cce 9107 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9108 sizeToFit on OSX >= 10.2.
9109
9110 * nsimage.m (allocInitFromFile): Don't use deprecated method
9111 bestRepresentationForDevice on OSX >= 10.6.
9112
9113 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9114 to avoid warning.
9115
9116 * emacs.c: Declare unexec_init_emacs_zone.
9117
a63e0781
JD
9118 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9119
699c10bd
JD
9120 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9121
9122 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9123 on svcsMenu (Bug#8842).
9124
9125 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9126 ns_return_types.
9127 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9128
9129 * nsterm.m (QUTF8_STRING): Declare.
9130 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9131 (validRequestorForSendType): Return type is (id).
9132 Change indexOfObjectIdenticalTo to indexOfObject.
9133 Check if we have local selection before returning self (Bug#8842).
9134 (writeSelectionToPasteboard): Put local selection into paste board
9135 if we have a local selection (Bug#8842).
9136 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9137
9138 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9139 (ns_get_local_selection): Declare.
9140
54e10184
LMI
91412011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9142
9888ff71
LMI
9143 * keymap.c (describe_map_tree): Don't insert a double newline at
9144 the end of the buffer (bug#1169) and return whether we inserted
9145 something.
9146
54e10184
LMI
9147 * callint.c (Fcall_interactively): Change "reading args" to
9148 "providing args" to try to clarify what it does (bug#1010).
9149
15fa4783
KH
91502011-07-07 Kenichi Handa <handa@m17n.org>
9151
9152 * composite.c (composition_compute_stop_pos): Ignore a static
9153 composition starting before CHARPOS (Bug#8915).
9154
9155 * xdisp.c (handle_composition_prop): Likewise.
9156
a8815b00
EZ
91572011-07-07 Eli Zaretskii <eliz@gnu.org>
9158
9159 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9160 (Bug#9015)
9161
ef7b981d 91622011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9163
9164 * character.h (unicode_category_t): New enum type.
9165
9166 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9167 (Qchar_code_property_table): New variable.
9168 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9169 (UNIPROP_COMPRESSED_FORM_P): New macros.
9170 (char_table_ascii): Uncompress the compressed values.
9171 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9172 Uncompress the compressed values.
ac389d0c 9173 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9174 (char_table_ref_and_range): Uncompress the compressed values.
9175 (sub_char_table_set): New arg is_uniprop. Callers changed.
9176 Uncompress the compressed values.
9177 (sub_char_table_set_range): Args changed. Callers changed.
9178 (char_table_set_range): Adjuted for the above change.
9179 (map_sub_char_table): Delete args default_val and parent. Add arg
9180 top. Give decoded values to a Lisp function.
640c8776 9181 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9182 values to a Lisp function. Gcpro more variables.
9183 (uniprop_table_uncompress)
9184 (uniprop_decode_value_run_length): New functions.
9185 (uniprop_decoder, uniprop_decoder_count): New variables.
9186 (uniprop_get_decoder, uniprop_encode_value_character)
9187 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9188 New functions.
9189 (uniprop_encoder, uniprop_encoder_count): New variables.
9190 (uniprop_get_encoder, uniprop_table)
9191 (Funicode_property_table_internal, Fget_unicode_property_internal)
9192 (Fput_unicode_property_internal): New functions.
9193 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9194 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9195 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9196 char-code-property-alist.
9197
640c8776 9198 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9199 Vunicode_category_table.
9200
640c8776 9201 * font.c (font_range): Adjust for the change of
c805dec0
KH
9202 Vunicode_category_table.
9203
76b397fb
DN
92042011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9205
9206 * m/iris4d.h: Remove file, move contents ...
9207 * s/irix6-5.h: ... here.
9208
22b4128e
PE
92092011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9210
9211 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9212 * alloc.c (mark_buffer):
9213 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9214 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9215 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9216 This isn't true in general, and it's particularly not true
9217 if Emacs is configured with --with-wide-int.
9218 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9219 New macros, used in the buffer.c change.
9220
869795d6
JD
92212011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9222
9223 * xsettings.c: Use both GConf and GSettings if both are available.
9224 (store_config_changed_event): Add comment.
9225 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9226 (store_tool_bar_style_changed): New functions.
5e617bc2 9227 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9228 (struct xsettings): Move font inside HAVE_XFT.
9229 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9230 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9231 Move inside HAVE_XFT.
640c8776 9232 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9233 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9234 also.
9235 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9236 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9237 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9238 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9239 (parse_settings): Move check for font inside HAVE_XFT.
9240 (read_settings, apply_xft_settings): Add comment.
9241 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9242 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9243 call store_font_name_changed.
9244 (xft_settings_event): Add comment.
9245 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9246 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9247 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9248 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9249 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9250 (xsettings_get_system_font, xsettings_get_system_normal_font):
9251 Add comment.
869795d6 9252
d8ed26bd
PE
92532011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9254
9255 Random fixes. E.g., (random) never returned negative values.
9256 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9257 subseconds part to the entropy, as that's a bit more random.
9258 Prefer signed to unsigned, since the signedness doesn't matter and
9259 in general we prefer signed. When given a limit, use a
9260 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9261 latter isn't right if USE_2_TAGS_FOR_INTS.
9262 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9263 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9264
cabf1cac
SM
92652011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9266
9267 * textprop.c (text_property_stickiness):
9268 Obey Vtext_property_default_nonsticky.
9269 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9270 * w32fns.c (syms_of_w32fns):
9271 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9272
6e9b2be9
PE
92732011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9274
9275 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9276 This is more efficient than Ffile_directory_p and avoids a minor race.
9277
90186c68
LMI
92782011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9279
7c301272
LMI
9280 * buffer.c (Foverlay_put): Say what the return value is
9281 (bug#7835).
9282
c4f2d8d4
LMI
9283 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9284 is a directory before asking whether to use the file name
9285 (bug#7564).
ad637907
LMI
9286 (barf_or_query_if_file_exists): Make the "File is a directory"
9287 error be more correct.
c4f2d8d4 9288
90186c68
LMI
9289 * fns.c (Frequire): Remove the mention of the .gz files, since
9290 that's installation-specific, but keep the mention of
9291 `get-load-suffixes'.
9292
da64016e
PE
92932011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9294
9295 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9296 Report string overflow if the output is too long.
9297
7d47b580
JB
92982011-07-04 Juanma Barranquero <lekktu@gmail.com>
9299
a555cb87
JB
9300 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9301 (syms_of_gnutls): Remove duplicate DEFSYM for
9302 Qgnutls_bootprop_verify_hostname_error, an error for
9303 Qgnutls_bootprop_verify_error (which is no longer used).
9304
7d47b580
JB
9305 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9306 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9307 Also (re)move comments that are misplaced or no longer relevant.
9308
1e49bfab
LMI
93092011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9310
9311 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9312
1485f4c0
CY
93132011-07-03 Chong Yidong <cyd@stupidchicken.com>
9314
9315 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9316 and background color parameters if they have been changed.
9317
a9ab721e
LMI
93182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9319
9320 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9321
cf7cff57
PE
93222011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9323
2e13213d
PE
9324 * xsettings.c (SYSTEM_FONT): Define only when used.
9325 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9326
cf7cff57
PE
9327 * keymap.c (access_keymap_1): Now static.
9328
7a8e04f7
CY
93292011-07-02 Chong Yidong <cyd@stupidchicken.com>
9330
9331 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9332 leave any prefix arg for the up event (Bug#1586).
9333
61352f62
LMI
93342011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9335
69bb1ef7
LMI
9336 * lread.c (syms_of_lread): Mention single symbols defined by
9337 `defvar' or `defconst' (bug#7154).
9338
61352f62 9339 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9340 (Frequire): Mention get-load-suffixes.
61352f62 9341
28545e04
MR
93422011-07-02 Martin Rudalics <rudalics@gmx.at>
9343
9344 * window.h (window): Remove clone_number slot.
9345 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9346 Remove.
9347 (make_parent_window, make_window, saved_window)
9348 (Fset_window_configuration, save_window_save): Don't deal with
9349 clone numbers.
9350 * buffer.c (Qclone_number): Remove declaration.
9351 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9352
3349e122
SM
93532011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9354
9355 Add multiple inheritance to keymaps.
9356 * keymap.c (Fmake_composed_keymap): New function.
9357 (Fset_keymap_parent): Simplify.
9358 (fix_submap_inheritance): Remove.
9359 (access_keymap_1): New function extracted from access_keymap to handle
9360 embedded parents and handle lists of maps.
9361 (access_keymap): Use it.
9362 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9363 (Fcopy_keymap): Handle embedded parents.
9364 (Fcommand_remapping, define_as_prefix): Simplify.
9365 (Fkey_binding): Simplify.
9366 (syms_of_keymap): Move minibuffer-local-completion-map,
9367 minibuffer-local-filename-completion-map,
9368 minibuffer-local-must-match-map, and
9369 minibuffer-local-filename-must-match-map to Elisp.
9370 (syms_of_keymap): Defsubr make-composed-keymap.
9371 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9372 (parse_menu_item): Trivial simplification.
9373
3279eb87
GM
93742011-07-01 Glenn Morris <rgm@gnu.org>
9375
9376 * Makefile.in (SETTINGS_LIBS): Fix typo.
9377
4550efdf
KI
93782011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9379
9380 * coding.c (Fencode_coding_string): Record the last coding system
9381 used, as the function doc string says (bug#8738).
9382
0949d2b6
JD
93832011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9384
9385 * xsettings.c (store_monospaced_changed): Take new font as arg and
9386 check for change against current_mono_font.
9387 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9388 (emacs_settings_constructor, emacs_settings_get_property)
9389 (emacs_settings_set_property, emacs_settings_class_init)
9390 (emacs_settings_init, gsettings_obj): Remove.
9391 (something_changedCB): New function for HAVE_GSETTINGS.
9392 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9393 with value as argument.
9394 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9395 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9396 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9397 "changed".
9398
9399 * xgselect.c: Add defined (HAVE_GSETTINGS).
9400 (xgselect_initialize): Ditto.
9401
9402 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9403 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9404 xg_select.
9405
bbc6b304
PE
94062011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9407
9408 * eval.c (struct backtrace): Simplify and port the data structure.
9409 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9410 signed bit field, as this assumption is not portable and it makes
9411 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9412 "char debug_on_exit : 1" as this is not portable either; instead,
9413 use the portable "unsigned int debug_on_exit : 1". Remove unused
9414 member evalargs. Remove obsolete comments about cc bombing out.
9415
9851bfc5
JD
94162011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9417
51bb811f 9418 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9419 Let HAVE_GSETTINGS override HAVE_GCONF.
9420 (store_monospaced_changed): New function.
9421 (EMACS_SETTINGS): A new type derived from GObject to handle
9422 GSettings notifications.
9423 (emacs_settings_constructor, emacs_settings_get_property)
9424 (emacs_settings_set_property, emacs_settings_class_init):
9425 New functions.
9426 (gsettings_client, gsettings_obj): New variables.
9427 (GSETTINGS_SCHEMA): New define.
9428 (something_changedCB): Call store_monospaced_changed.
9429 (init_gsettings): New function.
9430 (xsettings_initialize): Call init_gsettings.
9431 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9432 to NULL.
9433
640c8776 9434 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9435 GCONF_CFLAGS/LIBS.
9436
5386012d
MR
94372011-06-29 Martin Rudalics <rudalics@gmx.at>
9438
9439 * window.c (resize_root_window, grow_mini_window)
9440 (shrink_mini_window): Rename Qresize_root_window to
9441 Qwindow_resize_root_window and Qresize_root_window_vertically to
9442 Qwindow_resize_root_window_vertically.
9443
f13e0b08
PE
94442011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9445
9446 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9447
94515237
JB
94482011-06-27 Juanma Barranquero <lekktu@gmail.com>
9449
9450 * makefile.w32-in: Redesign dependencies so they reflect more
9451 clearly which files are directly included by each source file,
9452 and not through other includes.
9453
e43b6e43
MR
94542011-06-27 Martin Rudalics <rudalics@gmx.at>
9455
9456 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9457 (sort_overlays, overlay_strings): When an overlay's clone number
9458 matches the window's clone number process the overlay even if
9459 the overlay's window property doesn't match the current window.
9460
d68443dc
MR
9461 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9462 (Fwindow_hchild): Rename to Fwindow_left_child.
9463 (Fwindow_next): Rename to Fwindow_next_sibling.
9464 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9465 (resize_window_check): Rename to window_resize_check.
9466 (resize_window_apply): Rename to window_resize_apply.
9467 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9468 (Fdelete_other_windows_internal, resize_frame_windows)
9469 (Fsplit_window_internal, Fdelete_window_internal)
9470 (grow_mini_window, shrink_mini_window)
9471 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9472
c7e73be5
JD
94732011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9474
9475 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9476 (emacs_fixed_set_min_size): Remove.
9477 (emacs_fixed_new): Take frame as argument.
9478
9479 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9480 (_EmacsFixedPrivate): Remove minwidth/height.
9481 Add struct frame *f.
9482 (emacs_fixed_init): Initialize priv->f.
9483 (get_parent_class, emacs_fixed_set_min_size): Remove.
9484 (emacs_fixed_new): Set priv->f to argument.
9485 (emacs_fixed_get_preferred_width)
9486 (emacs_fixed_get_preferred_height): Use min_width/height from
9487 frames size_hint to set minimum and natural (Bug#8919).
9488 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9489 and use min_width/height from frames size_hint to set
9490 min_width/height (Bug#8919).
9491
9492 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9493 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9494 Fix indentation.
c7e73be5 9495
cf99dcf8
EZ
94962011-06-26 Eli Zaretskii <eliz@gnu.org>
9497
9498 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9499 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9500 called at ZV.
9501
029529ac
CY
95022011-06-26 Chong Yidong <cyd@stupidchicken.com>
9503
9504 * process.c (wait_reading_process_output): Bypass select if
9505 waiting for a cell while ignoring keyboard input, and input is
9506 pending. Suggested by Jan Djärv (Bug#8869).
9507
7a7ef429
PE
95082011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9509
9510 Use gnulib's dup2 module instead of rolling our own.
9511 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9512
11fdef7d 95132011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9514
9515 * dispnew.c (scrolling_window): Before scrolling, turn off a
9516 mouse-highlight in the window being scrolled.
9517
cd3520a4
JB
95182011-06-24 Juanma Barranquero <lekktu@gmail.com>
9519
9520 Move DEFSYM to lisp.h and use everywhere.
9521
9522 * character.h (DEFSYM): Move declaration...
9523 * lisp.h (DEFSYM): ...here.
9524
9525 * gnutls.c:
9526 * minibuf.c:
9527 * w32menu.c:
9528 * w32proc.c:
9529 * w32select.c: Don't include character.h.
9530
9531 * alloc.c (syms_of_alloc):
9532 * buffer.c (syms_of_buffer):
9533 * bytecode.c (syms_of_bytecode):
9534 * callint.c (syms_of_callint):
9535 * casefiddle.c (syms_of_casefiddle):
9536 * casetab.c (init_casetab_once):
9537 * category.c (init_category_once, syms_of_category):
9538 * ccl.c (syms_of_ccl):
9539 * cmds.c (syms_of_cmds):
9540 * composite.c (syms_of_composite):
9541 * dbusbind.c (syms_of_dbusbind):
9542 * dired.c (syms_of_dired):
9543 * dispnew.c (syms_of_display):
9544 * doc.c (syms_of_doc):
9545 * editfns.c (syms_of_editfns):
9546 * emacs.c (syms_of_emacs):
9547 * eval.c (syms_of_eval):
9548 * fileio.c (syms_of_fileio):
9549 * fns.c (syms_of_fns):
9550 * frame.c (syms_of_frame):
9551 * fringe.c (syms_of_fringe):
9552 * insdel.c (syms_of_insdel):
9553 * keymap.c (syms_of_keymap):
9554 * lread.c (init_obarray, syms_of_lread):
9555 * macros.c (syms_of_macros):
9556 * msdos.c (syms_of_msdos):
9557 * print.c (syms_of_print):
9558 * process.c (syms_of_process):
9559 * search.c (syms_of_search):
9560 * sound.c (syms_of_sound):
9561 * syntax.c (init_syntax_once, syms_of_syntax):
9562 * terminal.c (syms_of_terminal):
9563 * textprop.c (syms_of_textprop):
9564 * undo.c (syms_of_undo):
9565 * w32.c (globals_of_w32):
9566 * window.c (syms_of_window):
9567 * xdisp.c (syms_of_xdisp):
9568 * xfaces.c (syms_of_xfaces):
9569 * xfns.c (syms_of_xfns):
9570 * xmenu.c (syms_of_xmenu):
9571 * xsettings.c (syms_of_xsettings):
9572 * xterm.c (syms_of_xterm): Use DEFSYM.
9573
4228cf16
TZ
95742011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9575
cd3520a4 9576 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9577
7fcccf1e
PE
95782011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9579
7efb4e0e
PE
9580 Integer and buffer overflow fixes (Bug#8873).
9581
ff5844ad
PE
9582 * print.c (printchar, strout): Check for string overflow.
9583 (PRINTPREPARE, printchar, strout):
9584 Don't set size unless allocation succeeds.
9585
90532f02
PE
9586 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9587 for sizes. Check for string overflow more accurately.
9588 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9589
6d84508d
PE
9590 * macros.c: Integer and buffer overflow fixes.
9591 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9592 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9593 Use ptrdiff_t, not int, for sizes.
9594 Don't increment bufsize until after realloc succeeds.
9595 Check for size-calculation overflow.
9596 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9597
437b2cb4
PE
9598 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9599
8b9ac8b4
PE
9600 * lread.c: Integer overflow fixes.
9601 (read_integer): Radix is now EMACS_INT, not int,
9602 to improve quality of diagnostics for out-of-range radices.
9603 Calculate buffer size correctly for out-of-range radices.
9604 (read1): Check for integer overflow in radices, and in
9605 read-circle numbers.
82cb60d3
PE
9606 (read_escape): Avoid int overflow.
9607 (Fload, openp, read_buffer_size, read1)
9608 (substitute_object_recurse, read_vector, read_list, map_obarray):
9609 Use ptrdiff_t, not int, for sizes.
9610 (read1): Use EMACS_INT, not int, for sizes.
20270765 9611 Check for size overflow.
8b9ac8b4 9612
7fcccf1e
PE
9613 * image.c (cache_image): Check for size arithmetic overflow.
9614
bfbbd7e7
PE
9615 * lread.c: Integer overflow issues.
9616 (saved_doc_string_size, saved_doc_string_length)
9617 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9618 Now ptrdiff_t, not int.
9619 (read1): Don't assume doc string length fits in int. Check for
9620 out-of-range doc string lengths.
9621 (read_list): Don't assume file position fits in int.
39019e54 9622 (read_escape): Check for hex character overflow.
bfbbd7e7 9623
4e323265
LL
96242011-06-22 Leo Liu <sdl.web@gmail.com>
9625
9626 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9627 Move to minibuffer.el.
9628
85fece3e
PE
96292011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9630
20b84ce9 9631 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9632 The following patches are for when GLYPH_DEBUG && !XASSERT.
9633 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9634 * dispnew.c (flush_stdout):
9635 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9636 Mark as externally visible.
9637 * dispnew.c (check_window_matrix_pointers): Now static.
9638 * dispnew.c (window_to_frame_vpos):
9639 * xfns.c (unwind_create_frame):
9640 * xterm.c (x_check_font): Remove unused local.
9641 * scroll.c (CHECK_BOUNDS):
9642 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9643 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9644 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9645 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9646 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9647 Now static.
9648 (debug_method_add): Use va_list and vsprintf rather than relying
9649 on undefined behavior with wrong number of arguments.
9650 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9651 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9652 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9653 since we're not interested in debugging glyphs with old libraries.
9654 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9655 GCC 4.6.0's static checking.
9656
0766b489
PE
96572011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9658
31fd4b32
PE
9659 Integer overflow and signedness fixes (Bug#8873).
9660 A few related buffer overrun fixes, too.
9661
b79e8648
PE
9662 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9663
0766b489
PE
9664 * dispextern.h (struct face.stipple):
9665 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9666 (x_bitmap_mask, x_allocate_bitmap_record)
9667 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9668 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9669 (x_create_bitmap_from_xpm_data):
9670 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9671 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9672 (.bitmaps_last):
9673 * xfaces.c (load_pixmap):
9674 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9675 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9676 (.bitmaps_last, struct x_output.icon_bitmap):
9677 Use ptrdiff_t, not int, for bitmap indexes.
9678 (x_allocate_bitmap_record): Check for size overflow.
9679 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9680
b081724f
PE
9681 Use ptrdiff_t, not int, for overlay counts.
9682 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9683 * editfns.c (overlays_around, get_pos_property):
9684 * textprop.c (get_char_property_and_overlay):
9685 * xdisp.c (next_overlay_change, note_mouse_highlight):
9686 * xfaces.c (face_at_buffer_position):
21514da7
PE
9687 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9688 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9689 (Fnext_overlay_change, Fprevious_overlay_change)
9690 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9691 Use ptrdiff_t, not int, for sizes.
21514da7 9692 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9693
3de73e5e
PE
9694 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9695
2606c57b
PE
9696 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9697 (x_session_initialize): Do not assume string length fits in int.
9698
aaafe47a
PE
9699 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9700 This is unlikely, but can occur if DPI is outlandish.
9701
2674ddc8 9702 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9703 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9704
28154962
PE
9705 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9706 * xrdb.c (magic_file_p, search_magic_path):
9707 Omit last arg SUFFIX; it was always 0. All callers changed.
9708 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9709
7de51af5
PE
9710 * xfont.c (xfont_match): Avoid need for strlen.
9711
25ed6cc3
PE
9712 * xfns.c: Don't assume strlen fits in int.
9713 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9714
4eab31dd
PE
9715 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9716 not unsigned long, as we prefer signed integers. All callers changed.
9717 Detect integer overflow in repeat count.
9718 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9719 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9720
171e2a58
PE
9721 * termcap.c: Don't assume sizes fit in int and never overflow.
9722 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9723 (gobble_line): Check for size-calculation overflow.
9724
ad39faca 9725 * minibuf.c (Fread_buffer):
6e5bb2dc 9726 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9727 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9728 Don't assume string length fits in int.
9729
52c61c22 9730 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9731 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9732
b5b8c9e5
PE
9733 * font.c: Don't assume string length fits in int.
9734 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9735 Use ptrdiff_t, not int.
ccd6111c
PE
9736 (font_intern_prop): Don't assume string length fits in int.
9737 Don't assume integer property fits in fixnum.
9738 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9739
882f0d81 9740 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9741 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9742 Reformulate so as not to need the command string.
9743 Invoke gzip -cd rather than gunzip, as it's more portable.
9744 (lock_info_type, lock_file_1, lock_file):
9745 Don't assume pid_t and time_t fit in unsigned long.
9746 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9747 (current_lock_owner): Prefer signed type for sizes.
9748 Use memcpy, not strncpy, where memcpy is what is really wanted.
9749 Don't assume (via atoi) that time_t and pid_t fit in int.
9750 Check for time_t and/or pid_t out of range, e.g., via a network share.
9751 Don't alloca where an auto var works fine.
9752
93f4cf88
PE
9753 * fileio.c: Fix some integer overflow issues.
9754 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9755 Don't assume string length fits in int.
9756 (directory_file_name): Don't assume string length fits in long.
9757 (make_temp_name): Don't assume pid fits in int, or that its print
9758 length is less than 20.
9759
f3e92b69
PE
9760 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9761
1bfdaf10
PE
9762 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9763
35016e9a
PE
9764 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9765
3d1e65a1
PE
9766 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9767 We prefer signed integers, even for size calculations.
9768
0b963a93
PE
9769 * emacs.c: Don't assume string length fits in 'int'.
9770 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9771 (main): Don't invoke strlen when not needed.
9772
573f4b54
PE
9773 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9774 (XD_DEBUG_MESSAGE): Don't waste a byte.
9775
989f33ba
PE
9776 * callproc.c (getenv_internal_1, getenv_internal)
9777 (Fgetenv_internal):
965d34eb
PE
9778 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9779
e4d29b33
PE
9780 * lread.c (invalid_syntax): Omit length argument.
9781 All uses changed. This doesn't fix a bug, but it simplifies the
9782 code away from its former Hollerith-constant appearance, and it's
9783 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9784 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9785
eb49b136
PE
9786 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9787 This didn't break anything, but it didn't help either.
9788 It's confusing to put a bogus integer in a place where the actual
9789 value does not matter.
9f62aeb1 9790 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9791 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9792
15375a22
PE
9793 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9794 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9795 implementation.
b61cc01c
PE
9796 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9797 We prefer signed types, and the value cannot exceed the EMACS_INT
9798 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9799 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9800 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9801 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9802
53b2623d
PE
9803 * indent.c (sane_tab_width): New function.
9804 (current_column, scan_for_column, Findent_to, position_indentation)
9805 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9806 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9807
51cab52b 9808 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9809
f2ed8a70
PE
9810 * lisp.h (lint_assume): New macro.
9811 * composite.c (composition_gstring_put_cache):
9812 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9813
abe80cc6
PE
9814 * editfns.c, insdel.c:
9815 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9816
b02c740e
PE
9817 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9818
ebc96716
PE
9819 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9820
b4e50fa0 9821 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9822 Use much-faster test for byte-length change.
311d5d7c 9823 Don't assume string byte-length fits in 'int'.
a4cf38e4 9824 Check that character arg fits in 'int'.
85461888 9825 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9826
c0c1ee9f
PE
9827 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9828
a498d7f4
PE
9829 * fns.c (concat): Catch string overflow earlier.
9830 Do not rely on integer wraparound.
9831
51cab52b
PE
9832 * dispextern.h (struct it.overlay_strings_charpos)
9833 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9834 * xdisp.c (forward_to_next_line_start)
9835 (back_to_previous_visible_line_start)
9836 (reseat_at_next_visible_line_start, next_element_from_buffer):
9837 Don't arbitrarily truncate the value of 'selective' to int.
9838
76031fad
PE
9839 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9840
5eb55db9
PE
9841 * composite.c: Don't truncate sizes to 'int'.
9842 (composition_gstring_p, composition_reseat_it)
9843 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9844 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9845 not EMACS_UINT, for indexes.
5eb55db9 9846
0703a717
PE
9847 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9848
d6202519
PE
9849 * buffer.c: Include <verify.h>.
9850 (struct sortvec.priority, struct sortstr.priority):
8961a454 9851 Now EMACS_INT, not int.
c20998a7 9852 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9853 (struct sortstr.size, record_overlay_string)
9854 (struct sortstrlist.size, struct sortlist.used):
9855 Don't truncate size to int.
9856 (record_overlay_string): Check for size-calculation overflow.
d6202519 9857 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9858
d5a19415
JM
98592011-06-22 Jim Meyering <meyering@redhat.com>
9860
029529ac 9861 Don't leak an XBM-image-sized buffer
d5a19415
JM
9862 * image.c (xbm_load): Free the image buffer after using it.
9863
a9041e6c
PE
98642011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9865
9866 Port to Sun C.
9867 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9868 that Sun C diagnosed.
9869 * fns.c (secure_hash): Fix pointer signedness issue.
9870 * intervals.c (static_offset_intervals): New function.
9871 (offset_intervals): Use it.
9872
7f3f739f
LL
98732011-06-21 Leo Liu <sdl.web@gmail.com>
9874
9875 * deps.mk (fns.o):
9876 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9877 sha512.h.
9878
9879 * fns.c (secure_hash): Rename from crypto_hash_function and change
9880 the first arg to accept symbols.
5b66d427 9881 (Fsecure_hash): New primitive.
7f3f739f
LL
9882 (syms_of_fns): New symbols.
9883
76147d94
DD
98842011-06-20 Deniz Dogan <deniz@dogan.se>
9885
9886 * process.c (Fset_process_buffer): Clarify return value in
9887 docstring.
9888
7d7d0045
CY
98892011-06-18 Chong Yidong <cyd@stupidchicken.com>
9890
9891 * dispnew.c (add_window_display_history): Use BVAR.
9892
9893 * xdisp.c (debug_method_add): Use BVAR.
9894 (check_window_end, dump_glyph_matrix, dump_glyph)
9895 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9896
9897 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9898 Likewise.
9899
9900 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9901 check till after the cache is created in init_frame_faces.
9902
ff2bc410
SM
99032011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9904
9905 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9906
28177add
PE
99072011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9908
dd3482fe
PE
9909 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9910 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9911 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9912
393d71f3 9913 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9914 * fileio.c (Finsert_file_contents):
9915 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9916 Remove the old (too-loose) buffer overflow checks.
9917 They weren't needed, since make_gap checks for buffer overflow.
9918 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9919 The old code merely checked for Emacs fixnum overflow, and relied
9920 on undefined (wraparound) behavior. The new code avoids undefined
9921 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9922
2e6813b0 9923 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9924 Tune. Don't use wider integers than needed. Don't use alloca.
9925 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9926
599a9e4f
PE
9927 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9928
99561444
PE
9929 * insdel.c, lisp.h (buffer_overflow): New function.
9930 (insert_from_buffer_1, replace_range, replace_range_2):
9931 * insdel.c (make_gap_larger):
9932 * editfns.c (Finsert_char):
9933 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9934
28177add
PE
9935 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9936
e69dafad
PE
99372011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9938
4baa020d 9939 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9940
b1c46f02
PE
9941 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9942 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9943
e69dafad
PE
9944 * fileio.c: Don't assume EMACS_INT fits in off_t.
9945 (emacs_lseek): New static function.
9946 (Finsert_file_contents, Fwrite_region): Use it.
9947 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9948
566684ea
PE
9949 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9950
e6966cd6
PE
9951 * fns.c: Don't overflow int when computing a list length.
9952 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9953 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9954 truncation on 64-bit hosts. Check for QUIT every
9955 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9956 faster and is responsive enough.
9957 (Flength): Report an error instead of overflowing an integer.
9958 (Fsafe_length): Return a float if the value is not representable
9959 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9960 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9961 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9962
dd0b0efb
PE
9963 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9964 (header_size, word_size): New constants.
9965 (allocate_vectorlike): Don't check size overflow here.
9966 (allocate_vector): Check it here instead, since this is the only
9967 caller of allocate_vectorlike that could cause overflow.
9968 Check that the new vector's length is representable as a fixnum.
9969
86fe5cfe
PE
9970 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9971 The previous code was bogus. For example, next_almost_prime (32)
9972 returned 39, which is undesirable as it is a multiple of 3; and
9973 next_almost_prime (24) returned 25, which is a multiple of 5 so
9974 why was the code bothering to check for multiples of 7?
9975
80e88859
PE
9976 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9977
4a2f0ad6
PE
9978 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9979
f66c7cf8
PE
9980 Variadic C functions now count arguments with ptrdiff_t.
9981 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9982 Back then I didn't know that the Emacs coding style prefers signed int.
9983 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9984 were being counted with int, which may truncate counts on 64-bit
9985 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9986 * lisp.h (struct Lisp_Subr.function.aMANY)
9987 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9988 Arg counts are now ptrdiff_t, not size_t.
9989 All variadic functions and their callers changed accordingly.
9990 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9991 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9992 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9993 * callint.c (Fcall_interactively): Check arg count for overflow,
9994 to avoid potential buffer overrun. Use signed char, not 'int',
9995 for 'varies' array, so that we needn't bother to check its size
9996 calculation for overflow.
9997 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9998 * eval.c (apply_lambda):
9999 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10000 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10001 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10002
a1759b76
PE
10003 * callint.c (Fcall_interactively): Don't use index var as event count.
10004
d96be9fc
PE
10005 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10006 * mem-limits.h (SIZE): Remove; no longer used.
10007
a690a978 10008 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10009
578c21e6
PE
10010 Remove unnecessary casts.
10011 * xterm.c (x_term_init):
10012 * xfns.c (x_set_border_pixel):
10013 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10014 These aren't needed now that we assume ANSI C.
10015
96f53c6c
PE
10016 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10017 It's more likely to cause problems (due to unsigned overflow)
10018 than to cure them.
10019
83c77d31
PE
10020 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10021
ee2079f1
PE
10022 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10023
6da65536
PE
10024 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10025
7147c4a4
PE
10026 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10027
193e32d9
PE
10028 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10029
e5533da6
PE
10030 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10031
9910e595
PE
10032 GLYPH_CODE_FACE returns EMACS_INT, not int.
10033 * dispextern.h (merge_faces):
10034 * xfaces.c (merge_faces):
01103c44
PE
10035 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10036 Don't assume EMACS_INT fits in int.
9910e595 10037
2638320e
PE
10038 * character.h (CHAR_VALID_P): Remove unused parameter.
10039 * fontset.c, lisp.h, xdisp.c: All uses changed.
10040
045eb8d9
PE
10041 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10042
c1f134b5
PE
10043 * fns.c (concat): Minor tuning based on overflow analysis.
10044 This doesn't fix any bugs. Use int to hold character, instead
10045 of constantly refetching from Emacs object. Use XFASTINT, not
10046 XINT, for value known to be a character. Don't bother comparing
10047 a single byte to 0400, as it's always less.
10048
395fcb93 10049 * floatfns.c (Fexpt):
327eeec8
PE
10050 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10051
abbd3d23
PE
10052 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10053 for characters.
10054
684a03ef
PE
10055 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10056
0fed43f3
PE
10057 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10058 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10059 incorrectly succeed when S was a string, because 4294967386 was
10060 truncated before it was used.
10061
8fd02eb7
PE
10062 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10063 Otherwise, an out-of-range integer could cause undefined behavior
10064 on a 64-bit host.
10065
f8c86b69
PE
10066 * composite.c: Use int, not EMACS_INT, for characters.
10067 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10068 EMACS_INT, for values that are known to be in character range.
10069 This doesn't fix any bugs but is the usual style inside Emacs and
10070 may generate better code on 32-bit machines.
10071
34206dd2
PE
10072 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10073 This is for reasons similar to the recent CHAR_STRING fix.
10074 * charset.c (Fencode_char): Check that character arg is actually
10075 a character. Pass an int to ENCODE_CHAR.
10076 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10077 wider than 'int', as a compile-time check to prevent future regressions
10078 in this area.
10079
c5958d4c 10080 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10081
10082 Make sure a 64-bit char is never passed to CHAR_STRING.
10083 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10084 by silently ignoring the top 32 bits, allowing some values
10085 that were far too large to be valid characters.
10086 * character.h: Include <verify.h>.
10087 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10088 arguments are no wider than unsigned, as a compile-time check
10089 to prevent future regressions in this area.
10090 * data.c (Faset):
01103c44 10091 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10092 (Fsubst_char_in_region):
10093 * fns.c (concat):
10094 * xdisp.c (decode_mode_spec_coding):
10095 Adjust to CHAR_STRING's new requirement.
10096 * editfns.c (Finsert_char, Fsubst_char_in_region):
10097 * fns.c (concat): Check that character args are actually
10098 characters. Without this test, these functions did the wrong
10099 thing with wildly out-of-range values on 64-bit hosts.
10100
d37ca623
PE
10101 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10102 These casts should not be needed on 32-bit hosts, either.
10103 * keyboard.c (read_char):
10104 * lread.c (Fload): Remove casts to unsigned.
10105
ea204efb
PE
10106 * lisp.h (UNSIGNED_CMP): New macro.
10107 This fixes comparison bugs on 64-bit hosts.
10108 (ASCII_CHAR_P): Use it.
10109 * casefiddle.c (casify_object):
01103c44 10110 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10111 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10112 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10113 * dispextern.h (FACE_FROM_ID):
10114 * keyboard.c (read_char): Use UNSIGNED_CMP.
10115
41cb286c
PE
10116 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10117 not to EMACS_INT, to avoid GCC warning.
10118
4a1b9832
PE
10119 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10120
55daad71
PE
10121 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10122 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10123 isn't needed on 32-bit machines.
8f95c75c 10124
01103c44
PE
10125 * buffer.c (Fgenerate_new_buffer_name):
10126 Use EMACS_INT for count, not int.
0ceccced 10127 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10128
10129 * data.c (Qcompiled_function): Now static.
10130
c6f072e7
PE
10131 * window.c (window_body_lines): Now static.
10132
20ce5912
PE
10133 * image.c (gif_load): Rename local to avoid shadowing.
10134
9c4c5f81
PE
10135 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10136 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10137 * alloc.c (make_save_value): Integer argument is now of type
10138 ptrdiff_t, not int.
10139 (mark_object): Use ptrdiff_t, not int.
10140 * lisp.h (pD): New macro.
10141 * print.c (print_object): Use it.
10142
c0c5c8ae
PE
10143 * alloc.c: Use EMACS_INT, not int, to count objects.
10144 (total_conses, total_markers, total_symbols, total_vector_size)
10145 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10146 (total_free_floats, total_floats, total_free_intervals)
10147 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10148 Now EMACS_INT, not int. All uses changed.
10149 (Fgarbage_collect): Compute overall total using a double, so that
10150 integer overflow is less likely to be a problem. Check for overflow
10151 when converting back to an integer.
5a25e253
PE
10152 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10153 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10154 These were 'int' variables that could overflow on 64-bit hosts;
10155 they were never used, so remove them instead of repairing them.
211a0b2a 10156 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10157 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10158 Previously, this ceilinged at INT_MAX, but that doesn't work on
10159 64-bit machines.
e46bb31a 10160 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10161
c78baabf 10162 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10163 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10164 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10165 when a (possibly-narrower) signed value would do just as well.
10166 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10167
c9d624c6
PE
10168 * alloc.c: Catch some string size overflows that we were missing.
10169 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10170 for convenience in STRING_BYTES_MAX.
10171 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10172 The definition here is exact; the one in lisp.h was approximate.
10173 (allocate_string_data): Check for string overflow. This catches
10174 some instances we weren't catching before. Also, it catches
10175 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10176 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10177 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10178
c9d624c6
PE
10179 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10180 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10181 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10182
353032ce
PE
10183 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10184
2bccce07
PE
10185 * alloc.c (Fmake_string): Check for out-of-range init.
10186
0ac30604
SM
101872011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10188
10189 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10190
c195f2de
JD
101912011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10192
10193 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10194 xg_get_default_scrollbar_width.
10195
10196 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10197 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10198 (style_changed_cb): Call update_theme_scrollbar_width and call
10199 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10200 all frames (Bug#8505).
10201 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10202 Call gtk_window_set_resizable if HAVE_GTK3.
10203 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10204 and height if HAVE_GTK3 (Bug#8505).
10205 (scroll_bar_width_for_theme): New variable.
10206 (update_theme_scrollbar_width): New function.
10207 (xg_get_default_scrollbar_width): Move code to
10208 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10209 (xg_initialize): Call update_theme_scrollbar_width.
10210
10211 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10212
10213 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10214
e10ac9f1
MR
102152011-06-12 Martin Rudalics <rudalics@gmx.at>
10216
10217 * frame.c (make_frame): Call other_buffer_safely instead of
10218 other_buffer.
10219
10220 * window.c (temp_output_buffer_show): Call display_buffer with
10221 second argument Vtemp_buffer_show_specifiers and reset latter
10222 immediately after the call.
10223 (Vtemp_buffer_show_specifiers): New variable.
10224 (auto_window_vscroll_p, next_screen_context_lines)
10225 (Vscroll_preserve_screen_position): Remove leading asterisks from
10226 doc-strings.
10227
2d3c217e 102282011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10229
7b7f97e8 10230 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10231 * buffer.c (Qclone_number): Remove for now, as it's unused.
10232 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10233 (record_buffer): Remove unused local.
10234 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10235 (set_frame_buffer_list): Remove; unused.
10236 * frame.h (other_visible_frames): Remove decl.
10237 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10238 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10239 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10240 if HAVE_GPM.
10241 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10242 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10243 Define only if HAVE_GPM.
10244 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10245 (update_hints_inhibit): Remove; never set. All uses removed.
10246 * widgetprv.h (emacsFrameClassRec): Remove decl.
10247 * window.c (delete_deletable_window): Now returns void, since it
10248 wasn't returning anything.
10249 (compare_window_configurations): Remove unused locals.
10250 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10251 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10252 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10253 the same widths as pointers. This follows up on the 2011-05-06 patch.
10254 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10255 * xterm.h: Likewise.
10256 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10257
1384b89e
JB
102582011-06-12 Juanma Barranquero <lekktu@gmail.com>
10259
10260 * makefile.w32-in: Update dependencies.
10261 (LISP_H): Add lib/intprops.h.
10262
1100a63c
CY
102632011-06-11 Chong Yidong <cyd@stupidchicken.com>
10264
10265 * image.c (gif_load): Add animation frame delay to the metadata.
10266 (syms_of_image): Use DEFSYM. New symbol `delay'.
10267
6198ccd0
MR
102682011-06-11 Martin Rudalics <rudalics@gmx.at>
10269
10270 * window.c (delete_deletable_window): Re-add.
10271 (Fset_window_configuration): Rewrite to handle dead buffers and
10272 consequently deletable windows.
10273 (window_tree, Fwindow_tree): Remove. Supply functionality in
10274 window.el.
10275 (compare_window_configurations): Simplify code.
10276
b6e3633c
AS
102772011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10278
1ab0dee5
AS
10279 * image.c (imagemagick_load_image): Fix type mismatch.
10280 (Fimagemagick_types): Likewise.
10281
b6e3633c
AS
10282 * window.h (replace_buffer_in_windows): Declare.
10283
9397e56f
MR
102842011-06-11 Martin Rudalics <rudalics@gmx.at>
10285
10286 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10287 Qclone_number. Remove external declaration of Qdelete_window.
10288 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10289 code.
640c8776
SM
10290 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10291 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10292 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10293 buffer list implementation.
10294 (other_buffer_safely): New function.
10295 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10296 calls to replace_buffer_in_windows and
10297 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10298 if allowed.
10299 (record_buffer): Inhibit quitting and rewrite using quittable
10300 functions. Run Qbuffer_list_update_hook if allowed.
10301 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10302 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10303 Move switch-to-buffer to window.el.
9397e56f
MR
10304 (bury-buffer): Move to window.el.
10305 (Vbuffer_list_update_hook): New variable.
10306
10307 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10308 section.
10309
10310 * window.h (resize_frame_windows): Move up in code.
10311 (Fwindow_frame): Remove EXFUN.
10312 (replace_buffer_in_all_windows): Remove prototype.
10313 (replace_buffer_in_windows_safely): Add prototype.
10314
10315 * window.c: Declare Qdelete_window static again. Move down
10316 declaration of select_count.
10317 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10318 (Fother_window): Move to window.el.
10319 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10320 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10321 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10322 window.el.
10323 (replace_buffer_in_windows): Implement by calling
10324 Qreplace_buffer_in_windows.
10325 (replace_buffer_in_all_windows): Remove with some functionality
10326 moved into replace_buffer_in_windows_safely.
10327 (replace_buffer_in_windows_safely): New function.
10328 (select_window_norecord, select_frame_norecord): Move in front
10329 of run_window_configuration_change_hook. Remove now obsolete
10330 declarations.
640c8776
SM
10331 (Fset_window_buffer): Rewrite doc-string.
10332 Call Qrecord_window_buffer.
9397e56f
MR
10333 (keys_of_window): Move binding for other-window to window.el.
10334
b50691aa
CY
103352011-06-11 Chong Yidong <cyd@stupidchicken.com>
10336
10337 * dispextern.h (struct image): Replace data member, whose int_val
10338 and ptr_val fields were not used by anything, with a single
10339 lisp_val object.
10340
10341 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10342 (gif_clear_image, gif_load, imagemagick_load_image)
10343 (gs_clear_image, gs_load): Callers changed.
10344
3f754b86
PE
103452011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10346
cca69397
PE
10347 * buffer.h: Include <time.h>, for time_t.
10348 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10349
109e28d0
PE
10350 Fix minor problems found by static checking.
10351
60737f02
PE
10352 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10353
4b66faf3
PE
10354 Make identifiers static if they are not used in other modules.
10355 * data.c (Qcompiled_function, Qframe, Qvector):
10356 * image.c (QimageMagick, Qsvg):
10357 * minibuf.c (Qmetadata):
10358 * window.c (resize_window_check, resize_root_window): Now static.
10359 * window.h (resize_window_check, resize_root_window): Remove decls.
10360
109e28d0
PE
10361 * window.c (window_deletion_count, delete_deletable_window):
10362 Remove; unused.
46a4ce9e
PE
10363 (window_body_lines): Now static.
10364 (Fdelete_other_windows_internal): Mark vars as initialized.
10365 Make sure 'resize_failed' is initialized.
10366 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10367 (resize_window_apply): Remove unused local.
10368 * window.h (delete_deletable_window): Remove decl.
10369
109e28d0 10370 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10371 (imagemagick_load_image): Fix pointer signedness problem by changing
10372 last arg from unsigned char * to char *. All uses changed.
10373 Also, fix a local for similar reasons.
10374 Remove unused locals. Remove locals to avoid shadowing.
10375 (fn_rsvg_handle_free): Remove; unused.
10376 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10377 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10378
3f754b86
PE
10379 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10380
2547adb1
CY
103812011-06-10 Chong Yidong <cyd@stupidchicken.com>
10382
10383 * image.c (gif_load): Fix omitted cast error introduced by
10384 2011-06-06 change.
10385
2c8e37d4
MR
103862011-06-10 Martin Rudalics <rudalics@gmx.at>
10387
10388 * window.h (resize_proportionally, orig_total_lines)
10389 (orig_top_line): Remove from window structure.
10390 (set_window_height, set_window_width, change_window_heights)
10391 (Fdelete_window): Remove prototypes.
10392 (resize_frame_windows): Remove duplicate declaration.
10393
440a42e3
EZ
103942011-06-10 Eli Zaretskii <eliz@gnu.org>
10395
10396 * window.h (resize_frame_windows, resize_window_check)
10397 (delete_deletable_window, resize_root_window)
10398 (resize_frame_windows): Declare prototypes.
10399
10400 * window.c (resize_window_apply): Make definition be "static" to
10401 match the prototype.
10402
562dd5e9
MR
104032011-06-10 Martin Rudalics <rudalics@gmx.at>
10404
10405 * window.c: Remove declarations of Qwindow_size_fixed,
10406 window_min_size_1, window_min_size_2, window_min_size,
10407 size_window, window_fixed_size_p, enlarge_window, delete_window.
10408 Remove static from declaration of Qdelete_window, it's
10409 temporarily needed by Fbury_buffer.
10410 (replace_window): Don't assign orig_top_line and
10411 orig_total_lines.
10412 (Fdelete_window, delete_window): Remove. Window deletion is
10413 handled by window.el.
640c8776
SM
10414 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10415 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10416 (Fdelete_other_windows): Remove. Deleting other windows is
10417 handled by window.el.
10418 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10419 handled in window.el.
10420 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10421 Window minimum sizes are handled in window.el.
10422 (shrink_windows, size_window, set_window_height)
10423 (set_window_width, change_window_heights, window_height)
10424 (window_width, CURBEG, CURSIZE, enlarge_window)
10425 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10426 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10427 handled in window.el.
10428 (make_dummy_parent): Rename to make_parent_window and give it a
10429 second argument horflag.
10430 (make_window): Don't set resize_proportionally any more.
10431 (Fsplit_window): Remove. Windows are split in window.el.
10432 (save_restore_action, save_restore_orig_size)
10433 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10434 Resize mini windows in window.el.
10435 (grow_mini_window, shrink_mini_window): Implement by calling
10436 Qresize_root_window_vertically, resize_window_check and
10437 resize_window_apply.
640c8776
SM
10438 (saved_window, Fset_window_configuration, save_window_save):
10439 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10440 resize_proportionally.
10441 (window_min_height, window_min_width): Move to window.el.
10442 (keys_of_window): Move bindings for delete-other-windows,
10443 split-window, delete-window and enlarge-window to window.el.
10444
10445 * buffer.c: Temporarily extern Qdelete_window.
10446 (Fbury_buffer): Temporarily call Qdelete_window instead of
10447 Fdelete_window (Fbury_buffer will move to window.el soon).
10448
10449 * frame.c (set_menu_bar_lines_1): Remove code handling
10450 orig_top_line and orig_total_lines.
10451
10452 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10453 set_window_height but set heights directly.
10454 (change_frame_size_1): Use resize_frame_windows.
10455
10456 * xdisp.c (init_xdisp): Don't use set_window_height but set
10457 heights directly.
10458
640c8776
SM
10459 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10460 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10461 run_window_configuration_change_hook.
10462
10463 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10464 instead of change_window_heights and run
10465 run_window_configuration_change_hook.
10466
1a13852e
MR
104672011-06-09 Martin Rudalics <rudalics@gmx.at>
10468
10469 * window.c (replace_window): Rename second argument REPLACEMENT to
10470 NEW. New third argument SETFLAG. Rewrite.
10471 (delete_window, make_dummy_parent): Call replace_window with
10472 third argument 1.
10473 (window_list_1): Move down in code.
10474 (run_window_configuration_change_hook): Move set_buffer part
10475 before select_frame_norecord part in order to unwind correctly.
10476 Rename count1 to count.
10477 (recombine_windows, delete_deletable_window, resize_root_window)
10478 (Fdelete_other_windows_internal)
10479 (Frun_window_configuration_change_hook, make_parent_window)
10480 (resize_window_check, resize_window_apply, Fresize_window_apply)
10481 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10482 (Fdelete_window_internal, Fresize_mini_window_internal):
10483 New functions.
1a13852e
MR
10484 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10485
f3d1777e
MR
104862011-06-08 Martin Rudalics <rudalics@gmx.at>
10487
496e208e
MR
10488 * window.h (window): Add some new members to window structure -
10489 normal_lines, normal_cols, new_total, new_normal, clone_number,
10490 splits, nest, prev_buffers, next_buffers.
10491 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10492 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10493
f3d1777e
MR
10494 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10495 Remove.
496e208e
MR
10496 (make_dummy_parent): Set new members of windows structure.
10497 (make_window): Move down in code. Handle new members of window
10498 structure.
10499 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10500 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10501 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10502 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10503 (Fset_window_next_buffers, Fset_window_clone_number):
10504 New functions.
496e208e
MR
10505 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10506 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10507 Doc-string fixes.
10508 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10509 Argument WINDOW can be now internal window too.
10510 (Fwindow_use_time): Move up in code.
10511 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10512 Rewrite doc-string.
10513 (Fset_window_configuration, saved_window)
10514 (Fcurrent_window_configuration, save_window_save): Handle new
10515 members of window structure.
b9e809c2
MR
10516 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10517 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10518 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10519 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10520 Qget_mru_window, Qresize_root_window,
10521 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10522 Qauto_buffer_name; staticpro them.
f3d1777e 10523
abde8f8c
MR
105242011-06-07 Martin Rudalics <rudalics@gmx.at>
10525
10526 * window.c (Fwindow_total_size, Fwindow_left_column)
10527 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10528 (Fwindow_list_1): New functions.
10529 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10530 (Fwindow_width, Fscroll_left, Fscroll_right):
10531 Use window_body_cols instead of window_box_text_cols.
10532 (delete_window, Fset_window_configuration):
10533 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10534 (delete_all_subwindows): Take a window as argument and not a
10535 structure. Rewrite.
190b47e6
MR
10536 (window_loop): Remove handling of GET_LRU_WINDOW and
10537 GET_LARGEST_WINDOW.
10538 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10539
10540 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10541 window_box_text_cols. delete_all_subwindows now takes a
10542 Lisp_Object as argument.
abde8f8c 10543
640c8776
SM
10544 * indent.c (compute_motion, Fcompute_motion):
10545 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10546
fa8a67e6
MR
10547 * frame.c (delete_frame): Call delete_all_subwindows with root
10548 window as argument.
10549
a54e3482
DC
105502011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10551
10552 * fns.c (Fputhash): Document return value.
10553
60002bf5
CY
105542011-06-06 Chong Yidong <cyd@stupidchicken.com>
10555
10556 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10557
0c671da6 105582011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10559
b862a52a 10560 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10561
be44ca6c
PE
10562 Check for overflow when converting integer to cons and back.
10563 * charset.c (Fdefine_charset_internal, Fdecode_char):
10564 Use cons_to_unsigned to catch overflow.
10565 (Fencode_char): Use INTEGER_TO_CONS.
10566 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10567 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10568 * data.c (long_to_cons, cons_to_long): Remove.
10569 (cons_to_unsigned, cons_to_signed): New functions.
10570 These signal an error for invalid or out-of-range values.
10571 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10572 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10573 * font.c (Ffont_variation_glyphs):
10574 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10575 * lisp.h: Include <intprops.h>.
10576 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10577 (cons_to_signed, cons_to_unsigned): New decls.
10578 (long_to_cons, cons_to_long): Remove decls.
10579 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10580 (Fprimitive_undo): Use CONS_TO_INTEGER.
10581 * xfns.c (Fx_window_property): Likewise.
10582 * xselect.c: Include <limits.h>.
10583 (x_own_selection, selection_data_to_lisp_data):
10584 Use INTEGER_TO_CONS.
10585 (x_handle_selection_request, x_handle_selection_clear)
10586 (x_get_foreign_selection, Fx_disown_selection_internal)
10587 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10588 (lisp_data_to_selection_data): Use cons_to_unsigned.
10589 (x_fill_property_data): Use cons_to_signed.
10590 Report values out of range.
10591
d1f3d2af
PE
10592 Check for buffer and string overflow more precisely.
10593 * buffer.h (BUF_BYTES_MAX): New macro.
10594 * lisp.h (STRING_BYTES_MAX): New macro.
10595 * alloc.c (Fmake_string):
10596 * character.c (string_escape_byte8):
10597 * coding.c (coding_alloc_by_realloc):
10598 * doprnt.c (doprnt):
10599 * editfns.c (Fformat):
10600 * eval.c (verror):
10601 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10602 since they may not be the same number.
10603 * editfns.c (Finsert_char):
10604 * fileio.c (Finsert_file_contents):
10605 Likewise for BUF_BYTES_MAX.
10606
dd52fcea
PE
10607 * image.c: Use ptrdiff_t, not int, for sizes.
10608 (slurp_file): Switch from int to ptrdiff_t.
10609 All uses changed.
10610 (slurp_file): Check that file size fits in both size_t (for
10611 malloc) and ptrdiff_t (for sanity and safety).
10612
7f9bbdbb
PE
10613 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10614 if b->modtime has its maximal value.
10615
dfe18f82
PE
10616 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10617
84acfcf0
PE
10618 Don't assume time_t can fit into int.
10619 * buffer.h (struct buffer.modtime): Now time_t, not int.
10620 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10621 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10622
ccd9a01a
PE
10623 Minor fixes for signed vs unsigned integers.
10624 * character.h (MAYBE_UNIFY_CHAR):
10625 * charset.c (maybe_unify_char):
10626 * keyboard.c (read_char, reorder_modifiers):
10627 XINT -> XFASTINT, since the integer must be nonnegative.
10628 * ftfont.c (ftfont_spec_pattern):
10629 * keymap.c (access_keymap, silly_event_symbol_error):
10630 XUINT -> XFASTINT, since the integer must be nonnegative.
10631 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10632 since it makes no difference and we prefer signed.
10633 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10634 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10635 nonnegative.
10636
d6d100dd
SM
106372011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10638
10639 * window.h (Fwindow_frame): Declare.
10640
2b6148e4
PE
106412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10642
10643 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10644 (SPARE_MEMORY): Always define.
10645 (LARGE_REQUEST): Remove.
10646 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10647
f230ecc9
MR
106482011-06-06 Martin Rudalics <rudalics@gmx.at>
10649
727e958e
MR
10650 * lisp.h: Move EXFUNS for Fframe_root_window,
10651 Fframe_first_window and Fset_frame_selected_window to window.h.
10652
10653 * window.h: Move EXFUNS for Fframe_root_window,
10654 Fframe_first_window and Fset_frame_selected_window here from
10655 lisp.h.
10656
10657 * frame.c (Fwindow_frame, Fframe_first_window)
10658 (Fframe_root_window, Fframe_selected_window)
10659 (Fset_frame_selected_window): Move to window.c.
10660 (Factive_minibuffer_window): Move to minibuf.c.
10661 (Fother_visible_frames_p): New function.
10662
10663 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10664
f230ecc9
MR
10665 * window.c (decode_window, decode_any_window): Move up in code.
10666 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10667 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10668 (Fwindow_buffer): Move up and rewrite doc-string.
10669 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10670 (Fwindow_prev): New functions.
727e958e
MR
10671 (Fwindow_frame): Move here from frame.c. Accept any window as
10672 argument.
10673 (Fframe_root_window, Fframe_first_window)
10674 (Fframe_selected_window): Move here from frame.c. Accept frame
10675 or arbitrary window as argument. Update doc-strings.
10676 (Fminibuffer_window): Move up in code.
10677 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10678 (Fset_frame_selected_window): Move here from frame.c.
10679 Marginal rewrite.
727e958e
MR
10680 (Fselected_window, select_window, Fselect_window): Move up in
10681 code. Minor doc-string fixes.
f230ecc9 10682
4d09bcf6
PE
106832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10684
10685 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10686 Do not assume that spare memory exists; that assumption is valid
10687 only if SYSTEM_MALLOC.
10688 (LARGE_REQUEST): New macro, so that the issue of large requests
10689 is separated from the issue of spare memory.
10690
810928a2
AS
106912011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10692
172418ad
AS
10693 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10694 format. (Bug#8806)
10695
43f862f7
AS
10696 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10697
810928a2
AS
10698 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10699 before statements.
10700
a059fe24
JD
107012011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10702
10703 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10704
10705 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10706
10707 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10708 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10709
989bf368
JB
107102011-06-05 Juanma Barranquero <lekktu@gmail.com>
10711
10712 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10713
4b80f674
CY
107142011-06-04 Chong Yidong <cyd@stupidchicken.com>
10715
10716 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10717 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10718 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10719 New error handlers.
4b80f674
CY
10720 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10721 Obey Vx_select_enable_clipboard_manager. Catch errors in
10722 x_clipboard_manager_save (Bug#8779).
10723 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10724 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10725
99a33b77 107262011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10727
10728 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10729
99a33b77 107302011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10731
10732 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10733 in the current matrix if keep_current_p is non-zero.
10734
8264569d
EZ
107352011-06-04 Eli Zaretskii <eliz@gnu.org>
10736
10737 * bidi.c (bidi_level_of_next_char): Fix last change.
10738
57f97249
EZ
107392011-06-03 Eli Zaretskii <eliz@gnu.org>
10740
fec2107c 10741 Support bidi reordering of text covered by display properties.
57f97249 10742
fec2107c
EZ
10743 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10744 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10745 (bidi_cache_search, bidi_cache_iterator_state)
10746 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10747 (bidi_level_of_next_char, bidi_move_to_visually_next):
10748 Support character positions inside a run of characters covered by a
fec2107c
EZ
10749 display string.
10750 (bidi_paragraph_init, bidi_resolve_explicit_1)
10751 (bidi_level_of_next_char): Call bidi_fetch_char and
10752 bidi_fetch_char_advance instead of FETCH_CHAR and
10753 FETCH_CHAR_ADVANCE.
10754 (bidi_init_it): Initialize new members.
10755 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10756 definitions.
10757 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10758 instead of using explicit *_CHAR codes.
d6d100dd
SM
10759 (bidi_resolve_explicit, bidi_resolve_weak):
10760 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10761 bidirectional text is supported only in multibyte buffers.
10762 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10763 it to initialize the frame_window_p member of struct bidi_it.
10764 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10765 (bidi_resolve_explicit, bidi_resolve_weak)
10766 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10767 bidi_it->nchars is non-positive.
10768 (bidi_level_of_next_char): Don't try to lookup the cache for the
10769 next/previous character if nothing is cached there yet, or if we
10770 were just reseat()'ed to a new position.
c40e2fb2 10771
0e14fe90
EZ
10772 * xdisp.c (set_cursor_from_row): Set start and stop points
10773 according to the row's direction when priming the loop that looks
10774 for the glyph on which to display cursor.
10775 (single_display_spec_intangible_p): Function deleted.
10776 (display_prop_intangible_p): Reimplement to call
10777 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10778 Accept 3 additional arguments needed by handle_display_spec.
10779 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10780 values: lists, `(when COND...)' forms, etc.
10781 (single_display_spec_string_p): Support property values that are
10782 lists with the argument STRING its top-level element.
10783 (display_prop_string_p): Fix the condition for processing a
10784 property that is a list to be consistent with handle_display_spec.
fec2107c 10785 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10786 last portion of handle_display_prop.
10787 (compute_display_string_pos): Accept additional argument
10788 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10789 value of a `display' property is a "replacing spec".
10790 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10791 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10792 the display property, but just return a value indicating whether
10793 the display property will replace the characters it covers.
10794 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10795 frame_window_p members of struct bidi_it.
d6d100dd
SM
10796 (compute_display_string_pos, compute_display_string_end):
10797 New functions.
fec2107c
EZ
10798 (push_it): Accept second argument POSITION, where pop_it should
10799 jump to continue iteration.
10800 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10801
fec2107c
EZ
10802 * keyboard.c (adjust_point_for_property): Adjust the call to
10803 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10804
10805 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10806 (bidi_init_it): Update prototypes.
10807 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10808 (compute_display_string_pos, compute_display_string_end):
10809 Declare prototypes.
fec2107c
EZ
10810 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10811 EMACS_INT.
fc6f18ce 10812
40087514 108132011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10814
57f53182
PE
10815 Malloc failure behavior now depends on size of allocation.
10816 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10817 * lisp.h: Change signatures accordingly.
10818 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10819 All callers changed. (Bug#8762)
10820
10821 * gnutls.c: Use Emacs's memory allocators.
10822 Without this change, the gnutls library would invoke malloc etc.
10823 directly, which causes problems on non-SYNC_INPUT hosts, and which
10824 runs afoul of improving memory_full behavior. (Bug#8761)
10825 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10826 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10827 xfree instead of the default malloc, realloc, free.
10828 (Fgnutls_boot): No need to check for memory allocation failure,
10829 since xmalloc does that for us.
10830
ac32cd99 10831 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10832 * category.c (hash_get_category_set):
10833 * ccl.c (ccl_driver):
10834 * charset.c (Fdefine_charset_internal):
10835 * charset.h (struct charset.hash_index):
10836 * composite.c (get_composition_id, gstring_lookup_cache)
10837 (composition_gstring_put_cache):
10838 * composite.h (struct composition.hash_index):
10839 * dispextern.h (struct image.hash):
10840 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10841 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10842 (hashfn_equal, hashfn_user_defined, make_hash_table)
10843 (maybe_resize_hash_table, hash_lookup, hash_put)
10844 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10845 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10846 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10847 * image.c (make_image, search_image_cache, lookup_image)
10848 (xpm_put_color_table_h):
10849 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10850 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10851 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10852 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10853 * alloc.c (allocate_vectorlike):
10854 Check for overflow in vector size calculations.
10855 * ccl.c (ccl_driver):
10856 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10857 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10858 need to be updated by these changes.
40087514
PE
10859 * fns.c (make_hash_table, maybe_resize_hash_table):
10860 Check for integer overflow with large hash tables.
0de4bb68
PE
10861 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10862 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10863 (SXHASH_REDUCE): New macro.
10864 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10865 Use it instead of discarding useful hash info with large hash values.
10866 (sxhash_float): New function.
10867 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10868 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10869 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10870 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10871 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10872 Adjust signatures to match updated version of code.
10873 (consing_since_gc): Now EMACS_INT, since a single hash table can
10874 use more than INT_MAX bytes.
10875
698d32e2
DN
108762011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10877
10878 Make it possible to build with GCC-4.6+ -O2 -flto.
10879
10880 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10881
fd6fa53f
SM
108822011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10883
10884 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10885 Call minibuffer-inactive-mode.
10886
864db017
JB
108872011-05-31 Juanma Barranquero <lekktu@gmail.com>
10888
10889 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10890 Update dependencies.
10891
2ad0baf4
DN
108922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10893
10894 * data.c (init_data): Remove code for UTS, this system is not
10895 supported anymore.
10896
4fcc2638
DN
108972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10898
10899 Don't force ./temacs to start in terminal mode.
10900
10901 * frame.c (make_initial_frame): Initialize faces in all cases, not
10902 only when CANNOT_DUMP is defined.
10903 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10904
c56e0fd5
DN
109052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10906
10907 * dispnew.c (add_window_display_history): Use const for the string
10908 pointer. Remove declaration, not needed.
10909
333d54da 109102011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10911
55d4c1b2 10912 Use 'inline', not 'INLINE'.
333d54da 10913 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10914 * alloc.c, fontset.c (INLINE): Remove.
10915 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10916 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10917 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10918 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10919 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10920
738db178
DN
109212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10922
10923 Make it possible to run ./temacs.
10924
10925 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10926 syms_of_callproc does the same thing. Remove test for
10927 "initialized", do it in the caller.
10928 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10929
620c53a6
SM
109302011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10931
10932 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10933 (read_minibuf): Use get_minibuffer.
10934 (syms_of_minibuf): Use DEFSYM.
10935 (Qmetadata): New var.
10936 * data.c (Qbuffer): Don't make it static.
10937 (syms_of_data): Use DEFSYM.
10938
e003a292
PE
109392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10940
10941 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10942 (CCL_CODE_MIN): New macro.
10943
ed008a6d
PE
109442011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10945
3687c2ef
PE
10946 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10947
ed008a6d
PE
10948 * eval.c (Qdebug): Now static.
10949 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10950 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10951 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10952
d66c4c7c
CY
109532011-05-29 Chong Yidong <cyd@stupidchicken.com>
10954
10955 * image.c: Various fixes to ImageMagick code comments.
10956 (Fimagemagick_types): Doc fix.
10957
5fbc2025
PE
109582011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10959
0196f88a
PE
10960 Minor fixes prompted by GCC 4.6.0 warnings.
10961
10962 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10963
5fbc2025
PE
10964 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10965 (x_clipboard_manager_save_all): Move extern decl to ...
10966 * xterm.h: ... here, so that it can be checked for consistency.
10967
1dd3c2d9
CY
109682011-05-29 Chong Yidong <cyd@stupidchicken.com>
10969
10970 * xselect.c (x_clipboard_manager_save_frame)
10971 (x_clipboard_manager_save_all): New functions.
10972 (Fx_clipboard_manager_save): Lisp function deleted.
10973
10974 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10975 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10976
10977 * xterm.h: Update prototype.
10978
5ba6571d
WX
109792011-05-28 William Xu <william.xwl@gmail.com>
10980
10981 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10982 exiting (Bug#8239).
10983
3eaff834
JM
109842011-05-28 Jim Meyering <meyering@redhat.com>
10985
e1900994 10986 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10987 * fns.c (to_uchar): Define.
10988 (crypto_hash_function): Use it to convert some newly-signed
10989 variables to unsigned, to avoid sign-extension bugs. For example,
10990 without this change, (md5 "truc") would evaluate to
10991 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10992 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10993 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10994
0f6990a7
PE
109952011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10996
10997 Integer overflow fixes.
c8a9ca5a 10998
08686060
PE
10999 * dbusbind.c: Serial number integer overflow fixes.
11000 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11001 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11002 to hold a serial number that is too large for a fixnum.
11003 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11004 Check for serial numbers out of range. Decode any serial number
59568bf0 11005 that was so large that it became a float. (Bug#8722)
08686060 11006
2d1fc3c7
PE
11007 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11008 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11009 Use XFASTINT rather than XUINT when numbers are nonnegative.
11010 (xd_append_arg, Fdbus_method_return_internal):
11011 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11012 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11013 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11014 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11015 (Bug#8722)
2d1fc3c7 11016
c8a9ca5a
PE
11017 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11018
519e1d69
PE
11019 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11020
6df6ae42 11021 ccl: Add integer overflow checks.
30569699
PE
11022 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11023 (IN_INT_RANGE): New macros.
11024 (ccl_driver): Use them to check for integer overflow when
11025 decoding a CCL program. Many of the new checks are whether XINT (x)
11026 fits in int; it doesn't always, on 64-bit hosts. The new version
11027 doesn't catch all possible integer overflows, but it's an
847044ea 11028 improvement. (Bug#8719)
30569699 11029
c11285dc
PE
11030 * alloc.c (make_event_array): Use XINT, not XUINT.
11031 There's no need for unsigned here.
11032
fdccd48e
PE
11033 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11034 This follows up to the 2011-05-06 change that substituted uintptr_t
11035 for EMACS_INT. This case wasn't caught back then.
11036
37910ab2
PE
11037 Rework Fformat to avoid integer overflow issues.
11038 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11039 now (part of C89). Include <verify.h>.
11040 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11041 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11042 (Fformat): Avoid the prepass trying to compute sizes; it was only
11043 approximate and thus did not catch overflow reliably. Instead, walk
11044 through the format just once, formatting and computing sizes as we go,
11045 checking for integer overflow at every step, and allocating a larger
11046 buffer as needed. Keep track separately whether the format is
11047 multibyte. Keep only the most-recently calculated precision, rather
11048 than them all. Record whether each argument has been converted to
11049 string. Use EMACS_INT, not int, for byte and char and arg counts.
11050 Support field widths and precisions larger than INT_MAX. Avoid
11051 sprintf's undefined behavior with conversion specifications such as %#d
11052 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11053 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11054 formatting out-of-range floating point numbers with int
9173deec 11055 formats. (Bug#8668)
37910ab2 11056
2e6578fb
PE
11057 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11058
0ae6bdee
PE
11059 * data.c: Avoid integer truncation in expressions involving floats.
11060 * data.c: Include <intprops.h>.
11061 (arith_driver): When there's an integer overflow in an expression
11062 involving floating point, convert the integers to floating point
11063 so that the resulting value does not suffer from catastrophic
11064 integer truncation. For example, on a 64-bit host (* 4
11065 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11066 Do not rely on undefined behavior after integer overflow.
11067
de883a70
PE
11068 merge count_size_as_multibyte, parse_str_to_multibyte
11069 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11070 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11071 Check for integer overflow.
11072 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11073 since it's now a duplicate of the other. This is more of
11074 a character than a buffer op, so better that it's in character.c.
11075 * fns.c, print.c: Adjust to above changes.
11076
2ff916cb
PE
110772011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11078
11079 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11080
f1b54466
PE
110812011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11082
fb1ac845
PE
11083 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11084 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11085 (x_clipboard_manager_save): Now static.
11086 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11087
f1b54466
PE
11088 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11089 (crypto_hash_function): Now static.
11090 Fix pointer signedness problems. Avoid unnecessary initializations.
11091
a9f737ee
CY
110922011-05-27 Chong Yidong <cyd@stupidchicken.com>
11093
11094 * termhooks.h (Vselection_alist): Make it terminal-local.
11095
11096 * terminal.c (create_terminal): Initialize it.
11097
11098 * xselect.c: Support for clipboard managers.
11099 (Vselection_alist): Move to termhooks.h as terminal-local var.
11100 (LOCAL_SELECTION): New macro.
11101 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11102 (symbol_to_x_atom): Remove gratuitous arg.
11103 (x_handle_selection_request, lisp_data_to_selection_data)
11104 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11105 (x_own_selection, x_get_local_selection, x_convert_selection):
11106 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11107 (some_frame_on_display): Delete unused function.
11108 (Fx_own_selection_internal, Fx_get_selection_internal)
11109 (Fx_disown_selection_internal, Fx_selection_owner_p)
11110 (Fx_selection_exists_p): New optional frame arg.
11111 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11112 (x_handle_selection_clear): Don't treat other terminals with the
11113 same keyboard specially. Use the terminal-local Vselection_alist.
11114 (x_clear_frame_selections): Use Frun_hook_with_args.
11115
11116 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11117
11118 * xterm.h: Add support for those atoms.
11119
e067f0c1
CY
111202011-05-26 Chong Yidong <cyd@stupidchicken.com>
11121
11122 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11123 (converted_selections, conversion_fail_tag): New global variables.
11124 (x_selection_request_lisp_error): Free the above.
11125 (x_get_local_selection): Remove unnecessary code.
11126 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11127 of converted selections stored in converted_selections.
11128 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11129 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11130 (x_convert_selection): New function.
11131 (x_handle_selection_event): Simplify.
11132 (x_get_foreign_selection): Don't ignore incoming requests while
11133 waiting for an answer; this will fail when we implement
11134 SAVE_TARGETS, and seems unnecessary anyway.
11135 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11136 (Vx_sent_selection_functions): Doc fix.
11137
0f4aebc0
LL
111382011-05-26 Leo Liu <sdl.web@gmail.com>
11139
11140 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11141
e61124cd
YM
111422011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11143
11144 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11145
11146 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11147 for fringe update if it has periodic bitmap.
ac389d0c 11148 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11149 and fringe_bitmap_periodic_p.
11150
11151 * fringe.c (get_fringe_bitmap_data): New function.
11152 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11153 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11154 row. Mark glyph row for fringe update if periodicity changed.
11155
11156 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11157 for fringe update unless it has periodic bitmap.
11158
f16d9837
KH
111592011-05-25 Kenichi Handa <handa@m17n.org>
11160
11161 * xdisp.c (get_next_display_element): Set correct it->face_id for
11162 a static composition.
11163
e1b90ef6
LL
111642011-05-24 Leo Liu <sdl.web@gmail.com>
11165
11166 * deps.mk (fns.o):
11167 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11168
11169 * fns.c (crypto_hash_function, Fsha1): New function.
11170 (Fmd5): Use crypto_hash_function.
11171 (syms_of_fns): Add Ssha1.
11172
7400048f
PE
111732011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11174
11175 * gnutls.c: Remove unused macros.
11176 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11177 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11178 Remove macros that are defined and never used.
11179 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11180
abb71cf4
CY
111812011-05-22 Chong Yidong <cyd@stupidchicken.com>
11182
11183 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11184 (Fx_get_selection_internal): Minor cleanup.
11185 (Fx_own_selection_internal): Rename arguments for consistency with
11186 select.el.
11187
6307db39
PE
111882011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11189
11190 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11191
f3d4e0a4
CY
111922011-05-22 Chong Yidong <cyd@stupidchicken.com>
11193
11194 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11195
4d8ade89
YM
111962011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11197
11198 * dispnew.c (scrolling_window): Don't exclude the case that the
11199 last enabled row in the desired matrix touches the bottom boundary.
11200
32078c8d
GM
112012011-05-21 Glenn Morris <rgm@gnu.org>
11202
11203 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11204 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11205 and add some more files.
32078c8d 11206
7285dc67
EZ
112072011-05-20 Eli Zaretskii <eliz@gnu.org>
11208
11209 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11210 report_file_error introduced by the change from 2011-05-07.
11211
89d1bd22
PE
112122011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11213
11214 * systime.h (Time): Define only if emacs is defined.
11215 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11216 where the include path doesn't have X11/X.h by default. See
11217 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11218
cd394be1 112192011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11220
11221 * composite.c (find_automatic_composition): Fix previous change.
11222
b9704ad9
GM
112232011-05-20 Glenn Morris <rgm@gnu.org>
11224
11225 * lisp.mk: New file, split from Makefile.in.
11226 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11227 (shortlisp): Remove.
11228 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11229
4a720484
GM
112302011-05-19 Glenn Morris <rgm@gnu.org>
11231
11232 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11233 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11234 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11235 (lisp): Set the order to that of loadup.el.
11236 (shortlisp): Make it a copy of $lisp.
11237 (SOME_MACHINE_LISP): Remove.
11238 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11239 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11240
a28d4396
KH
112412011-05-18 Kenichi Handa <handa@m17n.org>
11242
11243 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11244 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11245 (find_automatic_composition): Mostly rewrite for efficiency.
11246
a2b1fa8e
JB
112472011-05-18 Juanma Barranquero <lekktu@gmail.com>
11248
11249 * makefile.w32-in: Update dependencies.
11250
8e1f5610
CS
112512011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11252
11253 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11254 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11255
7025ee00 112562011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11257
cdfa6eab
PE
11258 Fix some integer overflow issues, such as string length overflow.
11259
06d6db33
PE
11260 * insdel.c (count_size_as_multibyte): Check for string overflow.
11261
2b4560a8
PE
11262 * character.c (lisp_string_width): Check for string overflow.
11263 Use EMACS_INT, not int, for string indexes and lengths; in
11264 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11265 the resulting string length overflows an EMACS_INT; instead,
11266 report a string overflow if no precision given. When checking for
11267 precision exhaustion, use a check that cannot possibly have
11268 integer overflow. (Bug#8675)
11269 * character.h (lisp_string_width): Adjust to new signature.
11270
cb93f9be
PE
11271 * alloc.c (string_overflow): New function.
11272 (Fmake_string): Use it. This doesn't change behavior, but saves
11273 a few bytes and will simplify future changes.
11274 * character.c (string_escape_byte8): Likewise.
11275 * lisp.h (string_overflow): New decl.
11276
1a1f3366
PE
11277 Fixups, following up to the user-interface timestamp change.
11278 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11279 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11280 * msdos.c (mouse_get_pos): Likewise.
11281 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11282 * w32gui.h (Time): Define by including "systime.h" rather than by
11283 declaring it ourselves. (Bug#8664)
11284
d4e3e4d3
PE
11285 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11286 * image.c (clear_image_cache): Likewise.
11287
f6a24d19
PE
11288 * term.c (term_mouse_position): Don't assume time_t wraparound.
11289
08dc5ae6
PE
11290 Be more systematic about user-interface timestamps.
11291 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11292 and sometimes 'EMACS_UINT', to represent these timestamps.
11293 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11294 This makes the code easier to follow, and makes it easier to catch
11295 integer overflow bugs such as Bug#8664.
11296 * frame.c (Fmouse_position, Fmouse_pixel_position):
11297 Use Time, not unsigned long, for user-interface timestamps.
11298 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11299 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11300 * keyboard.h (last_event_timestamp): Likewise.
11301 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11302 * menu.h (xmenu_show): Likewise.
11303 * term.c (term_mouse_position): Likewise.
11304 * termhooks.h (struct input_event.timestamp): Likewise.
11305 (struct terminal.mouse_position_hook): Likewise.
11306 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11307 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11308 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11309 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11310 what it was before.
11311 * menu.h, termhooks.h: Include "systime.h", for Time.
11312
8e55734a
PE
11313 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11314 Don't assume that the difference between two unsigned long values
11315 can fit into an integer. At this point, we know button_down_time
11316 <= event->timestamp, so the difference must be nonnegative, so
11317 there's no need to cast the result if double-click-time is
11318 nonnegative, as it should be; check that it's nonnegative, just in
11319 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11320 apart (about 25 days). (Bug#8664)
8e55734a 11321
841f1b75 11322 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11323 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11324
3e26f69c
PE
11325 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11326 that always fit in int. Use a sentinel instead of a counter, to
11327 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11328 * frame.h (struct frame): Use int for menu_bar_items_used
11329 instead of EMACS_INT, since it always fits in int.
3e26f69c 11330
5cc152c0
PE
11331 * menu.c (grow_menu_items): Check for int overflow.
11332
d89eb65e
PE
11333 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11334
5235bd3e
PE
11335 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11336 Before, the code was not consistent. These values cannot exceed
11337 2**31 - 1 so there's no need to make them unsigned.
11338 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11339 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11340 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11341 as modifiers.
11342 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11343
bc827e23
PE
11344 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11345 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11346 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11347 presumably because the widths might not match.
11348
78eb494e
PE
11349 * window.c (size_window): Avoid needless test at loop start.
11350
04f2d78b
CB
113512011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11352
11353 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11354
d2fc7e3d 113552011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11356
11357 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11358
d2fc7e3d 113592011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11360
11361 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11362 `width' to `bar_area_x' and `bar_area_width', respectively.
11363 (x_scroll_run): Take account of fringe background extension.
11364
04f2d78b
CB
11365 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11366 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11367 `bar_area_width', respectively.
11368 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11369 background extension.
11370
79b70037
GM
113712011-05-10 Jim Meyering <meyering@redhat.com>
11372
11373 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11374
2f142cc5
JB
113752011-05-10 Juanma Barranquero <lekktu@gmail.com>
11376
11377 * image.c (Finit_image_library): Return t for built-in image types,
11378 like pbm and xbm. (Bug#8640)
11379
57679c86
AS
113802011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11381
11382 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11383
888c9e86
EZ
113842011-05-07 Eli Zaretskii <eliz@gnu.org>
11385
b0512a1d
EZ
11386 * w32console.c (Fset_screen_color): Doc fix.
11387 (Fget_screen_color): New function.
11388 (syms_of_ntterm): Defsubr it.
11389
7285dc67
EZ
11390 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11391 unlink the temporary file if Fcall_process didn't create it in the
11392 first place.
11393 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11394 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11395 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11396 cue to call_process_cleanup not to close that handle.
11397
4d3fcc8e
BK
113982011-05-07 Ben Key <bkey76@gmail.com>
11399
11400 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11401 one of two shell specific rules, either bootstrap-temacs-CMD or
11402 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11403 to the previous implementation of the bootstrap-temacs rule.
11404 The bootstrap-temacs-CMD rule is similar to the previous
11405 implementation of the bootstrap-temacs rule except that it
11406 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11407 variable.
11408
11409 These changes, along with some changes to nt/configure.bat,
11410 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11411 earlier fix to add support for --cflags and --ldflags options
11412 that include quotes so that it works whether make uses cmd or
11413 sh as the shell.
11414
b4289b64
MA
114152011-05-06 Michael Albinus <michael.albinus@gmx.de>
11416
11417 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11418 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11419 is a constant.
11420 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11421 a string. Handle both cases.
11422 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11423 (Fdbus_register_method): Use Qinvalid_function.
11424
af4c0e28
JB
114252011-05-06 Juanma Barranquero <lekktu@gmail.com>
11426
11427 * makefile.w32-in: Update dependencies.
11428 (LISP_H): Add inttypes.h and stdin.h.
11429 (PROCESS_H): Add unistd.h.
11430
c51453d9
EZ
114312011-05-06 Eli Zaretskii <eliz@gnu.org>
11432
11433 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11434 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11435
8ff0ac3c 114362011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11437
4c4b566b
PE
11438 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11439
aab2b9b5
PE
11440 * term.c (vfatal): Remove stray call to va_end.
11441 It's not needed and the C Standard doesn't allow it here anyway.
11442
c378da0b
PE
11443 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11444 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11445
288b08c7
PE
11446 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11447 bytes.
11448
e3601888
PE
11449 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11450
db6c0e74
PE
11451 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11452
dd5963ea
PE
11453 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11454
88c9450f
PE
11455 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11456
2f9442b8
PE
11457 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11458
c032b5f8
PE
11459 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11460 * charset.c (Fdefine_charset_internal): Don't initialize
11461 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11462 32-bit int (Bug#8600).
a108c10b
PE
11463
11464 * lread.c (read_integer): Be more consistent with string-to-number.
11465 Use string_to_number to do the actual conversion; this avoids
11466 rounding errors and fixes some other screwups. Without this fix,
11467 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11468 (digit_to_number): Move earlier, for benefit of read_integer.
11469 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11470 not a digit in any supported base. (Bug#8602)
a108c10b 11471
ad5f9eea
PE
11472 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11473
aec1708a
PE
11474 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11475 to match comment at start of function. This also removes a
11476 GCC warning about overflow in a 32+64-bit port.
11477
47be4ab5
PE
11478 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11479
371cac43
PE
11480 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11481 Reported by Stefan Monnier in
11482 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11483 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11484 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11485
d01a7826
PE
11486 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11487 (EMACS_UINTPTR): Likewise, with uintptr_t.
11488
7fd47d5c
PE
11489 * lisp.h: Prefer 64-bit EMACS_INT if available.
11490 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11491 on 32-bit hosts that have 64-bit int, so that they can access
11492 large files.
122b0c86
PE
11493 However, temporarily disable this change unless the temporary
11494 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11495
8727937b
PE
11496 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11497
8ac068ac
PE
11498 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11499 This removes an assumption that EMACS_INT and long are the same
11500 width as pointers. The assumption is true for Emacs porting targets
11501 now, but we want to make other targets possible.
11502 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11503 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11504 In the rest of the code, change types of integers that hold casted
11505 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11506 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11507 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11508 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11509 No need to cast type when ORing.
11510 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11511 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11512 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11513 assume EMACS_INT is the same width as char *.
11514 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11515 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11516 Remove no-longer-needed casts.
11517 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11518 (xg_tool_bar_help_callback, xg_make_tool_item):
11519 Use EMACS_INTPTR to hold an integer
11520 that will be cast to void *; this can avoid a GCC warning
11521 if EMACS_INT is not the same width as void *.
11522 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11523 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11524 (current_message_1, set_message_1):
11525 Use a local to convert to proper width without a cast.
11526 * xmenu.c (dialog_selection_callback): Likewise.
11527
ede49d71
PE
11528 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11529 Also, don't assume VALBITS / RAND_BITS is less than 5,
11530 and don't rely on undefined behavior when shifting a 1 left into
11531 the sign bit.
11532 * lisp.h (get_random): Change signature to match.
11533
2f30ecd0
PE
11534 * lread.c (hash_string): Use size_t, not int, for hash computation.
11535 Normally we prefer signed values; but hashing is special, because
11536 it's better to use unsigned division on hash table sizes so that
11537 the remainder is nonnegative. Also, size_t is the natural width
11538 for hashing into memory. The previous code used 'int', which doesn't
11539 retain enough info to hash well into very large tables.
11540 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11541
2a866e7b
PE
11542 * dbusbind.c: Don't possibly lose pointer info when converting.
11543 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11544 Use XPNTR rather than XHASH, so that the high-order bits of
11545 the pointer aren't lost when converting through void *.
11546
51639eac
PE
11547 * eval.c (Fautoload): Don't double-shift a pointer.
11548
92394119
PE
11549 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11550
dbdb9a7c
JB
115512011-05-06 Juanma Barranquero <lekktu@gmail.com>
11552
11553 * gnutls.c (DEF_GNUTLS_FN):
11554 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11555
db7a0b4f
AS
115562011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11557
11558 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11559 marker. (Bug#8610)
11560
cd394be1 115612011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11562
11563 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11564 New version that can reserve upto 2GB of heap space.
11565
f7ff1b0f 115662011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11567
11568 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11569
639c109b
TZ
115702011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11571
11572 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11573 `gnutls_certificate_set_x509_key_file'.
11574
d2127135
JB
115752011-05-05 Juanma Barranquero <lekktu@gmail.com>
11576
11577 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11578 Update dependencies.
11579
e968f4f3
JB
115802011-05-04 Juanma Barranquero <lekktu@gmail.com>
11581
11582 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11583 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11584 Remove unused parameter `fildes'.
11585 * process.c (read_process_output, send_process): Don't pass it.
11586
84d358f0
JB
115872011-05-04 Juanma Barranquero <lekktu@gmail.com>
11588
11589 Fix previous change: the library cache is defined in w32.c.
11590 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11591 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11592
0898ca10
JB
115932011-05-04 Juanma Barranquero <lekktu@gmail.com>
11594
11595 Implement dynamic loading of GnuTLS on Windows.
11596
11597 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11598 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11599 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11600 Declare.
11601
11602 * gnutls.c (Qgnutls_dll): Define.
11603 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11604 (gnutls_*): Declare function pointers.
11605 (init_gnutls_functions): New function to initialize function pointers.
11606 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11607 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11608 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11609 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11610 (emacs_gnutls_write, emacs_gnutls_read)
11611 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11612 (Fgnutls_available_p): New function.
11613 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11614 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11615 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11616
11617 * image.c: Include w32.h.
11618 (Vimage_type_cache): Delete.
11619 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11620 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11621 (w32_delayed_load): Move to w32.c.
11622
11623 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11624
11625 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11626 (w32_delayed_load): Move from image.c. When loading a library, record
11627 its filename in the :loaded-from property of the library id.
11628 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11629 Initialize and staticpro them.
11630 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11631
11632 * process.c: Include lisp.h before w32.h, not after.
11633 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11634 instead of gnutls_record_check_pending.
11635
11636 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11637
ff4de4aa
TZ
116382011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11639
11640 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11641 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11642 as passed in.
11643
abe95abb
JD
116442011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11645
11646 * xterm.c (x_set_frame_alpha): Do not set property on anything
11647 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11648
e16e55d4
JB
116492011-05-02 Juanma Barranquero <lekktu@gmail.com>
11650
11651 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11652
bafcf6a5
JB
116532011-05-02 Juanma Barranquero <lekktu@gmail.com>
11654
11655 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11656 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11657 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11658 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11659 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11660 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11661 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11662 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11663 (Qgnutls_bootprop_callbacks_verify): Make static.
11664
e7a6747f
AS
116652011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11666
19ed11ba
AS
11667 * callproc.c: Indentation fixup.
11668
e7a6747f 11669 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11670 (wait_for_termination, interruptible_wait_for_termination):
11671 Move after wait_for_termination_1.
e7a6747f 11672
1ef14cb4
LMI
116732011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11674
11675 * sysdep.c (interruptible_wait_for_termination): New function
11676 which is like wait_for_termination, but allows keyboard
11677 interruptions.
11678
11679 * callproc.c (Fcall_process): Add (:file "file") as an option for
11680 the STDOUT buffer.
11681 (Fcall_process_region): Ditto.
11682
330d880c
EZ
116832011-04-30 Eli Zaretskii <eliz@gnu.org>
11684
8db90b73
EZ
11685 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11686 rather than `XVECTOR (FOO)->size'.
11687
330d880c
EZ
11688 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11689 inttypes.h, as a gnulib replacement is used if it not available in
11690 system headers.
11691
15cbd324
EZ
116922011-04-21 Eli Zaretskii <eliz@gnu.org>
11693
11694 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11695 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11696 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11697
11698 * coding.c (coding_alloc_by_realloc): Error out if destination
11699 will grow beyond MOST_POSITIVE_FIXNUM.
11700 (decode_coding_emacs_mule): Abort if there isn't enough place in
11701 charbuf for the composition carryover bytes. Reserve an extra
11702 space for up to 2 characters produced in a loop.
11703 (decode_coding_iso_2022): Abort if there isn't enough place in
11704 charbuf for the composition carryover bytes.
11705
117062011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11707
ae940cca
EZ
11708 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11709 aborting when %lld or %lll format is passed.
11710 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11711 %llo or %llx format is passed. (Bug#8545)
11712
03ab8921
EZ
11713 * window.c (window_scroll_line_based): Use a marker instead of
11714 simple variables to record original value of point. (Bug#7952)
11715
afda1437
EZ
11716 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11717 produced by %s or %c overflows available buffer space. (Bug#8545)
11718
f76dee0c
PE
117192011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11720
11721 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11722 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11723
fdc5744d
JB
117242011-04-28 Juanma Barranquero <lekktu@gmail.com>
11725
11726 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11727
638f053a
JB
117282011-04-28 Juanma Barranquero <lekktu@gmail.com>
11729
11730 * keyboard.c (Qdelayed_warnings_hook): Define.
11731 (command_loop_1): Run `delayed-warnings-hook'
11732 if Vdelayed_warnings_list is non-nil.
11733 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11734 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11735
d178f871
EZ
117362011-04-28 Eli Zaretskii <eliz@gnu.org>
11737
11738 * doprnt.c (doprnt): Don't return value smaller than the buffer
11739 size if the message was truncated. (Bug#8545).
11740
b124fd93
JB
117412011-04-28 Juanma Barranquero <lekktu@gmail.com>
11742
11743 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11744 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11745
e810457d
PE
117462011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11747
11748 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11749
ea51cceb
JB
117502011-04-27 Juanma Barranquero <lekktu@gmail.com>
11751
11752 * makefile.w32-in: Update dependencies.
11753
94dcfacf
EZ
117542011-04-27 Eli Zaretskii <eliz@gnu.org>
11755
11756 Improve `doprnt' and its usage. (Bug#8545)
11757 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11758 `format_end'. Remove support for %l as a conversion specifier.
11759 Don't use xrealloc. Improve diagnostics when the %l size modifier
11760 is used. Update the commentary.
11761
11762 * eval.c (verror): Simplify calculation of size_t.
11763
11764 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11765 messages.
11766
f61f41d7
PE
117672011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11768
11769 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11770 change.
11771
96fb4434
PE
117722011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11773
11774 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11775 This makes this file independent of the recent pseudovector change.
11776
671875da 117772011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11778
69e9b5a3
PE
11779 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11780
b5f869a7 11781 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11782 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11783 Remove unused local.
c8926152 11784 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11785
841a1577 11786 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11787 GCC 4.6.0 optimizes based on type-based alias analysis.
11788 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11789 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11790 != &v->size, and therefore "v->size = 1; b->size = 2; return
11791 v->size;" must therefore return 1. This assumption is incorrect
11792 for Emacs, since it type-puns struct Lisp_Vector * with many other
11793 types. To fix this problem, this patch adds a new type struct
f904488f 11794 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11795 and pseudovectors, and helps optimizing compilers not get fooled
11796 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11797 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11798 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11799 the size member.
eab3844f
PE
11800 (XSETPVECTYPE): Rewrite in terms of new macro.
11801 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11802 This is a bit clearer, and further avoids the possibility of
11803 undesirable aliasing.
11804 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11805 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11806 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11807 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11808 (ASIZE): Now uses header.size rather than size.
11809 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11810 to avoid the hassle of writing XVECTOR (foo)->header.size.
11811 (struct vectorlike_header): New type.
eab3844f
PE
11812 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11813 object, to help avoid aliasing.
11814 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11815 (SUBRP): Likewise, since Lisp_Subr is a special case.
11816 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11817 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11818 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11819 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11820 changed to be "header.size" and "header.next".
11821 * buffer.h (struct buffer): Likewise.
11822 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11823 * frame.h (struct frame): Likewise.
11824 * process.h (struct Lisp_Process): Likewise.
11825 * termhooks.h (struct terminal): Likewise.
11826 * window.c (struct save_window_data, struct saved_window): Likewise.
11827 * window.h (struct window): Likewise.
11828 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11829 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11830 * buffer.c (init_buffer_once): Likewise.
11831 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11832 special case.
11833 * process.c (Fformat_network_address): Use local var for size,
11834 for brevity.
11835
0df1eac5
PE
11836 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11837
847ab9d1 11838 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11839 * data.c (atof): Remove decl; no longer used or needed.
11840 (digit_to_number): Move to lread.c.
11841 (Fstring_to_number): Use new string_to_number function, to be
11842 consistent with how the Lisp reader treats infinities and NaNs.
11843 Do not assume that floating-point numbers represent EMACS_INT
11844 without losing information; this is not true on most 64-bit hosts.
11845 Avoid double-rounding errors, by insisting on integers when
11846 parsing non-base-10 numbers, as the documentation specifies.
11847 * lisp.h (string_to_number): New decl, replacing ...
11848 (isfloat_string): Remove.
bc0a5c13 11849 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11850 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11851 appears to have been a coding error. Similarly, do not accept
11852 strings like +-1e0 as floating point numbers. Do not report
11853 overflow for integer overflows unless the base is not 10 which
11854 means we have no simple and reliable way to continue.
11855 Break out the floating-point parsing into a new
11856 function string_to_number, so that Fstring_to_number parses
11857 floating point numbers consistently with the Lisp reader.
04f2d78b 11858 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11859 (E_CHAR, EXP_INT): Remove, replacing with ...
11860 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11861 (string_to_number): New function, replacing isfloat_string.
11862 This function checks for valid syntax and produces the resulting
11863 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11864 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11865 so that overflow for non-base-10 numbers is reported only when
11866 there's no portable and simple way to convert to floating point.
452f4150 11867
67769ffc
PE
11868 * textprop.c (set_text_properties_1): Rewrite for clarity,
11869 and to avoid GCC warning about integer overflow.
11870
c20db43f
PE
11871 * intervals.h (struct interval): Use EMACS_INT for members
11872 where EMACS_UINT might cause problems. See
11873 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11874 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11875 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11876 All uses changed.
37aa2f85
PE
11877 (offset_intervals): Tell GCC not to worry about length overflow
11878 when negating a negative length.
c20db43f 11879
2538aa2f
PE
11880 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11881 (overrun_check_free): Likewise.
11882
f2d3008d
PE
11883 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11884 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11885 word size.
11886
ec8df744
PE
11887 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11888 (gnutls_make_error): Rename local to avoid shadowing.
11889 (gnutls_emacs_global_deinit): ifdef out; not used.
11890 (Fgnutls_boot): Use const for pointer to readonly storage.
11891 Comment out unused local. Fix pointer signedness problems.
11892
640ee02d
PE
11893 * lread.c (openp): Don't stuff size_t into an 'int'.
11894 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11895 about possible signed overflow.
11896
6048fb2a
PE
11897 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11898 (GDK_KEY_g): Don't define if already defined.
11899 (xg_prepare_tooltip): Avoid pointer signedness problem.
11900 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11901
fa3c87e1
PE
11902 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11903 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11904
2172544b
PE
11905 * xfns.c (Fx_window_property): Simplify a bit,
11906 to make a bit faster and to avoid GCC 4.6.0 warning.
11907 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11908
9b821a21
PE
11909 * fns.c (internal_equal): Don't assume size_t fits in int.
11910
3c616cfa
PE
11911 * alloc.c (compact_small_strings): Tighten assertion a little.
11912
c2982e87
PE
11913 Replace pEd with more-general pI, and fix some printf arg casts.
11914 * lisp.h (pI): New macro, generalizing old pEd macro to other
11915 conversion specifiers. For example, use "...%"pI"d..." rather
11916 than "...%"pEd"...".
11917 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11918 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11919 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11920 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11921 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11922 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11923 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11924 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11925 64-bit hosts.
11926 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11927 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11928 * print.c (safe_debug_print, print_object): Likewise.
11929 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11930 to int.
6f04d126
PE
11931 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11932 avoiding the 0 flag, which is not portable.
c2982e87
PE
11933 * process.c (Fmake_network_process): Use pI to avoid cast.
11934 * region-cache.c (pp_cache): Likewise.
11935 * xdisp.c (decode_mode_spec): Likewise.
11936 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11937 behavior on 64-bit hosts with printf arg.
6f04d126 11938 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11939 (x_stop_queuing_selection_requests): Likewise.
11940 (x_get_window_property): Don't truncate byte count to an 'int'
11941 when tracing.
0b432f21 11942
5e073ec7
PE
11943 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11944 here, since it parses constructs like leading '-' and spaces,
11945 which are not wanted; and it overflows with large numbers.
11946 Instead, simply match F[0-9]+, which is what is wanted anyway.
11947
36372bf9
PE
11948 * alloc.c: Remove unportable assumptions about struct layout.
11949 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11950 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11951 (allocate_vectorlike, make_pure_vector): Use the new macros,
11952 plus offsetof, to remove unportable assumptions about struct layout.
11953 These assumptions hold on all porting targets that I know of, but
11954 they are not guaranteed, they're easy to remove, and removing them
11955 makes further changes easier.
11956
0b432f21
PE
11957 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11958 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11959 (string_overrun_cookie): Now const. Use initializers that
11960 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11961 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11962 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11963 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11964 multiple of sizeof (EMACS_INT); it need not be, if
11965 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11966 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11967
895009e1
JB
119682011-04-26 Juanma Barranquero <lekktu@gmail.com>
11969
11970 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11971
6a7a1b0b
TZ
119722011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11973
11974 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11975 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11976 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11977
841a1577 119782011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11979
11980 * lisp.h (Qdebug): List symbol.
895009e1 11981 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11982 * keyboard.c (debug-on-event): New variable.
11983 (handle_user_signal): Break into debugger when debug-on-event
11984 matches the current signal symbol.
11985
f2d3ba6f
DN
119862011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11987
11988 * alloc.c (check_sblock, check_string_bytes)
11989 (check_string_free_list): Convert to standard C.
11990
42ce4c63
TZ
119912011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11992
11993 * w32.c (emacs_gnutls_push): Fix typo.
11994
825cd63c
EZ
119952011-04-25 Eli Zaretskii <eliz@gnu.org>
11996
fb11d64d
EZ
11997 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11998 "cast to pointer from integer of different size".
11999
825cd63c
EZ
12000 Improve doprnt and its use in verror. (Bug#8545)
12001 * doprnt.c (doprnt): Document the set of format control sequences
12002 supported by the function. Use SAFE_ALLOCA instead of always
12003 using `alloca'.
12004
12005 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12006 is one byte too soon. Don't use xrealloc; instead xfree and
12007 xmalloc anew.
12008
e061a11b
TZ
120092011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12010
12011 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12012 callbacks stage.
12013
12014 * gnutls.c: Renamed global_initialized to
12015 gnutls_global_initialized. Added internals for the
12016 :verify-hostname-error, :verify-error, and :verify-flags
12017 parameters of `gnutls-boot' and documented those parameters in the
12018 docstring. Start callback support.
9173deec
JB
12019 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12020 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12021 on error. Return error code.
e061a11b
TZ
12022 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12023 (emacs_gnutls_read): Likewise.
12024 (Fgnutls_boot): Return handshake error code.
12025 (emacs_gnutls_handle_error): New function.
12026 (wsaerror_to_errno): Likewise.
12027
12028 * w32.h (emacs_gnutls_pull): Add prototype.
12029 (emacs_gnutls_push): Likewise.
12030
12031 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12032 (emacs_gnutls_push): Likewise.
12033
120342011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12035
12036 * process.c (wait_reading_process_output): Check if GnuTLS
12037 buffered some data internally if no FDs are set for TLS
12038 connections.
12039
12040 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12041 (LIBS): Link to USER_LIBS.
12042 ($(BLD)/gnutls.$(0)): New target.
12043
fa6996bc
EZ
120442011-04-24 Eli Zaretskii <eliz@gnu.org>
12045
eb35682e
EZ
12046 * xdisp.c (handle_single_display_spec): Rename the
12047 display_replaced_before_p argument into display_replaced_p, to
12048 make it consistent with the commentary. Fix typos in the
12049 commentary.
12050
e2ad650c
EZ
12051 * textprop.c (syms_of_textprop): Remove dead code.
12052 (copy_text_properties): Delete obsolete commentary about an
12053 interface that was deleted long ago. Fix typos in the description
12054 of arguments.
12055
1b2de274
EZ
12056 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12057 to changes in oldXMenu/XMenu.h from 2011-04-16.
12058 <menu_help_message, prev_menu_help_message>: Constify.
12059 (IT_menu_make_room): menu->help_text is now `const char **';
12060 adjust.
12061
12062 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12063 to changes in oldXMenu/XMenu.h from 2011-04-16.
12064 (struct XMenu): Declare `help_text' `const char **'.
12065
12066 * xfaces.c <Qunspecified>: Make extern again.
12067
12068 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12069 required by POSIX.
1b2de274 12070
762b15be
EZ
12071 * doc.c (get_doc_string): Improve the format passed to `error'.
12072
12073 * doprnt.c (doprnt): Improve commentary.
12074
12075 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12076
12077 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12078 them with etags.
12079
f1052e5d
EZ
12080 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12081 changes in globals.h immediately force recompilation.
762b15be
EZ
12082 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12083 $(CURDIR)/s/ms-w32.h.
12084 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12085
fa6996bc
EZ
12086 * character.c (Fchar_direction): Function deleted.
12087 (syms_of_character): Don't defsubr it.
12088 <char-direction-table>: Deleted.
12089
e6c3da20
EZ
120902011-04-23 Eli Zaretskii <eliz@gnu.org>
12091
12092 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12093 * doprnt.c: Include limits.h.
12094 (SIZE_MAX): New macro.
04f2d78b
CB
12095 (doprnt): Return a size_t value. 2nd arg is now size_t.
12096 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12097 Improve overflow protection. Support `l' modifier for integer
12098 conversions. Support %l conversion. Don't assume an EMACS_INT
12099 argument for integer conversions and for %c.
12100
12101 * lisp.h (doprnt): Restore prototype.
12102
12103 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12104 $(SRC)/character.h.
12105
12106 * Makefile.in (base_obj): Add back doprnt.o.
12107
12108 * deps.mk (doprnt.o): Add back prerequisites.
12109 (callint.o): Depend on character.h.
12110
12111 * eval.c (internal_lisp_condition_case): Include the handler
12112 representation in the error message.
12113 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12114 when breaking from the loop.
12115
12116 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12117
12118 * callint.c (Fcall_interactively): When displaying error message
12119 about invalid control letter, pass the character's codepoint, not
12120 a pointer to its multibyte form. Improve display of the character
12121 in octal and display also its hex code.
12122
12123 * character.c (char_string): Use %x to display the (unsigned)
12124 codepoint of an invalid character, to avoid displaying a bogus
12125 negative value.
12126
12127 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12128 `error', not SYMBOL_NAME itself.
12129
12130 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12131 character arguments to `error'.
12132
12133 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12134 to `error' in error message about FINAL_CHAR argument. Make sure
12135 FINAL_CHAR is a character, and use %c when it is passed as
12136 argument to `error'.
12137
4ffd0d6b 121382011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12139
12140 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12141
12142 * w32.c: Include <time.h>.
12143 (sys_localtime): New function.
12144
4ffd0d6b 121452011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12146
12147 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12148
4ffd0d6b 12149 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12150
4ffd0d6b 121512011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12152
4ffd0d6b
GM
12153 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12154 zombies (Bug#8467).
aac0c6e3 12155
04c56954
EZ
121562011-04-19 Eli Zaretskii <eliz@gnu.org>
12157
12158 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12159 gl_state.e_property when gl_state.object is Qt.
12160
12161 * insdel.c (make_gap_larger): Remove limitation of buffer size
12162 to <= INT_MAX.
12163
16a43933
CY
121642011-04-18 Chong Yidong <cyd@stupidchicken.com>
12165
12166 * xdisp.c (lookup_glyphless_char_display)
12167 (produce_glyphless_glyph): Handle cons cell entry in
12168 glyphless-char-display.
12169 (Vglyphless_char_display): Document it.
12170
12171 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12172 glyphless-char-display.
12173
4581706e
CY
121742011-04-17 Chong Yidong <cyd@stupidchicken.com>
12175
12176 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12177
12178 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12179
12180 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12181 definition for no-X builds.
12182
4887c6e2 121832011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12184
fd35b6f9
PE
12185 Static checks with GCC 4.6.0 and non-default toolkits.
12186
5c1ccb01
PE
12187 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12188
006c5daa
PE
12189 * process.c (keyboard_bit_set): Define only if SIGIO.
12190 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12191 (send_process): Repair possible setjmp clobbering.
12192
efc736d3
PE
12193 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12194
4e2fe2e6
PE
12195 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12196
f97334a2
PE
12197 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12198
4e75f29d
PE
12199 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12200 Define only if needed.
12201
90efadd1
PE
12202 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12203 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12204 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12205
3c647824
PE
12206 * dispextern.h (struct redisplay_interface): Rename param
12207 to avoid shadowing.
e264f262 12208 * termhooks.h (struct terminal): Likewise.
761383f4 12209 * xterm.c (xembed_send_message): Likewise.
3c647824 12210
b58c5c4a
PE
12211 * insdel.c (make_gap_smaller): Define only if
12212 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12213
cad59032
PE
12214 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12215 it.
12216
c339dc2e
PE
12217 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12218 so that we aren't warned about unused symbols.
12219
91a3e27b
PE
12220 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12221
399c71d3 12222 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12223
8ffc96f5
PE
12224 * xfns.c (x_real_positions): Mark locals as initialized.
12225
eef9bc79
PE
12226 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12227
098db9dd
PE
12228 * xterm.c: Fix problems found by static analysis with other toolkits.
12229 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12230 (x_dispatch_event): Declare static if USE_GTK, and
12231 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12232 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12233 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12234 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12235 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12236
eb18f6cc
PE
12237 * xmenu.c (menu_help_callback): Pointer type fixes.
12238 Use const pointers when pointing at readonly data. Avoid pointer
12239 signedness clashes.
12240 (FALSE): Remove unused macro.
12241 (update_frame_menubar): Remove unused decl.
12242
1fe72bf8
PE
12243 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12244
60d9e1db
PE
12245 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12246 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12247 (single_menu_item): Rename local to avoid shadowing.
12248
39261c26
PE
12249 * keyboard.c (make_lispy_event): Remove unused local var.
12250
018c5e19
PE
12251 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12252 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12253
63d2b86e
PE
12254 * bitmaps: Change bitmaps from unsigned char back to the X11
12255 compatible char. Avoid the old compiler warnings about
12256 out-of-range initializers by using, for example, '\xab' rather
12257 than 0xab.
12258
aefd87e1
PE
12259 * xgselect.c (xgselect_initialize): Check vs interface
12260 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12261
bf501fb9
PE
12262 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12263
e9829fdf
PE
12264 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12265 to read-only memory.
12266
1086c095
PE
12267 * fns.c (vector): Remove; this old hack is no longer needed.
12268
2baccd04 12269 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12270 Remove unused var.
dde42981 12271 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12272
72391843 12273 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12274
436c16df 12275 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12276 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12277 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12278
92bb796d 12279 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12280 (x_term_init): Remove local to avoid shadowing.
92bb796d 12281
764430a3 12282 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12283
12284 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12285 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12286
d1dfb56c
EZ
122872011-04-16 Eli Zaretskii <eliz@gnu.org>
12288
c4354cb4
EZ
12289 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12290
d1dfb56c
EZ
12291 Fix regex.c, syntax.c and friends for buffers > 2GB.
12292 * syntax.h (struct gl_state_s): Declare character position members
12293 EMACS_INT.
12294
12295 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12296
04f2d78b
CB
12297 * textprop.c (verify_interval_modification, interval_of):
12298 Declare arguments EMACS_INT.
d1dfb56c
EZ
12299
12300 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12301 EMACS_INT.
12302
12303 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12304
12305 * indent.c (Fvertical_motion): Local variable it_start is now
12306 EMACS_INT.
12307
12308 * regex.c (re_match, re_match_2, re_match_2_internal)
12309 (bcmp_translate, regcomp, regexec, print_double_string)
12310 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12311 (re_compile_pattern, re_exec): Declare arguments and local
12312 variables `size_t' and `ssize_t' and return values `regoff_t', as
12313 appropriate.
12314 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12315 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12316 <compile_stack_type>: `size' and `avail' are now `size_t'.
12317
12318 * regex.h <regoff_t>: Use ssize_t, not int.
12319 (re_search, re_search_2, re_match, re_match_2): Arguments that
12320 specify buffer/string position and length are now ssize_t and
12321 size_t. Return type is regoff_t.
12322
613052cd
BK
123232011-04-16 Ben Key <bkey76@gmail.com>
12324
12325 * nsfont.m: Fixed bugs in ns_get_family and
12326 ns_descriptor_to_entity that were caused by using free to
12327 deallocate memory blocks that were allocated by xmalloc (via
12328 xstrdup). This caused Emacs to crash when compiled with
12329 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12330 --enable-checking=xmallocoverrun). xfree is now used to
12331 deallocate these memory blocks.
12332
4170f62f 123332011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12334
71b41406
PE
12335 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12336
9587a89d
PE
12337 emacs_write: Accept and return EMACS_INT for sizes.
12338 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12339 et seq.
12340 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12341 Accept and return EMACS_INT.
12342 (emacs_gnutls_write): Return the number of bytes written on
12343 partial writes.
12344 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12345 (emacs_read, emacs_write): Remove check for negative size, as the
12346 Emacs source code has been audited now.
9587a89d
PE
12347 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12348 (emacs_read, emacs_write): Use it.
273a5f82
PE
12349 * process.c (send_process): Adjust to the new signatures of
12350 emacs_write and emacs_gnutls_write. Do not attempt to store
12351 a byte offset into an 'int'; it might overflow.
9587a89d 12352 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12353
3e047f51
PE
12354 * sound.c: Don't assume sizes fit in 'int'.
12355 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12356 Return EMACS_INT, not int.
3e047f51 12357 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12358 Accept EMACS_INT, not int.
12359 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12360 record read return values.
12361
cc39a9db
BK
123622011-04-15 Ben Key <bkey76@gmail.com>
12363
c9d0ec6d
JB
12364 * keyboard.c (Qundefined): Don't declare static since it is used
12365 in nsfns.m.
12366 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12367 static since they are used in nsfont.m.
cc39a9db 12368
6c60eb9f
SM
123692011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12370
12371 * process.c (Qprocessp): Don't declare static.
12372 * lisp.h (Qprocessp): Declare again.
12373
7990b61a
JB
123742011-04-15 Juanma Barranquero <lekktu@gmail.com>
12375
12376 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12377
5d4cb038
PE
123782011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12379
8bd7b830 12380 Improve C-level modularity by making more things 'static'.
cd64ea1d 12381
e3b27b31
PE
12382 Don't publish debugger-only interfaces to other modules.
12383 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12384 (verify_bytepos, count_markers): Move decls to the only modules
12385 that need them.
12386 * region-cache.h (pp_cache): Likewise.
12387 * window.h (check_all_windows): Likewise.
12388 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12389
5d4cb038
PE
12390 * sysdep.c (croak): Now static, if
12391 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12392 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12393
12394 * alloc.c (refill_memory_reserve): Now static if
12395 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12396 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12397
e87b6180
PE
12398 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12399 Define only if USE_LUCID.
12400
ac64929e
PE
12401 * xrdb.c (x_customization_string, x_rm_string): Now static.
12402
6f37259d
PE
12403 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12404 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12405
1683e3ab
PE
12406 * xdisp.c (draw_row_with_mouse_face): Now static.
12407 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12408
de9c2632
PE
12409 * window.h (check_all_windows): Mark externally visible.
12410
2b96acb7
PE
12411 * window.c (window_deletion_count): Now static.
12412
12413 * undo.c: Make symbols static if they're not exported.
12414 (last_undo_buffer, last_boundary_position, pending_boundary):
12415 Now static.
12416
50436f33
PE
12417 * textprop.c (interval_insert_behind_hooks): Now static.
12418 (interval_insert_in_front_hooks): Likewise.
12419
64520e5c
PE
12420 * term.c: Make symbols static if they're not exported.
12421 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12422 (max_frame_lines, tty_set_terminal_modes):
12423 (tty_reset_terminal_modes, tty_turn_off_highlight):
12424 (get_tty_terminal): Now static.
12425 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12426 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12427 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12428 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12429 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12430
1fa53021
PE
12431 * sysdep.c: Make symbols static if they're not exported.
12432 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12433 Now static.
12434 (sigprocmask_set, full_mask): Remove; unused.
12435 (wait_debugging): Mark as visible.
12436 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12437 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12438
d4b43b22
PE
12439 * syntax.c (syntax_temp): Define only if !__GNUC__.
12440
b7c513d0
PE
12441 * sound.c (current_sound_device, current_sound): Now static.
12442
989b29ad
PE
12443 * search.c (searchbufs, searchbuf_head): Now static.
12444
13a55a78
PE
12445 * scroll.c (scroll_cost): Remove; unused.
12446 * dispextern.h (scroll_cost): Remove decl.
12447
de68a1fc
PE
12448 * region-cache.h (pp_cache): Mark as externally visible.
12449
40ccffa6
PE
12450 * process.c: Make symbols static if they're not exported.
12451 (process_tick, update_tick, create_process, chan_process):
12452 (Vprocess_alist, proc_buffered_char, datagram_access):
12453 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12454 (deactivate_process): Mark defn as static, as well as decl.
12455 * lisp.h (create_process): Remove decl.
12456 * process.h (chan_process, Vprocess_alist): Remove decls.
12457
ad64fc97
PE
12458 * print.c: Make symbols static if they're not exported.
12459 (print_depth, new_backquote_output, being_printed, print_buffer):
12460 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12461 (print_interval, print_number_index, initial_stderr_stream):
12462 Now static.
12463 * lisp.h (Fprinc): Remove decl.
12464 (debug_output_compilation_hack): Mark as externally visible.
12465
adddb265
PE
12466 * sysdep.c (croak): Move decl from here to syssignal.h.
12467 * syssignal.h (croak): Put it here, so the API can be checked when
12468 'croak' is called from dissociate_if_controlling_tty.
12469
1717ede2
PE
12470 * minibuf.c: Make symbols static if they're not exported.
12471 (minibuf_save_list, choose_minibuf_frame): Now static.
12472 * lisp.h (choose_minibuf_frame): Remove decl.
12473
fa5fb2bc
PE
12474 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12475
1e3890d1
PE
12476 * lread.c: Make symbols static if they're not exported.
12477 (read_objects, initial_obarray, oblookup_last_bucket_number):
12478 Now static.
12479 (make_symbol): Remove; unused.
12480 * lisp.h (initial_obarray, make_symbol): Remove decls.
12481
8a1414fa
PE
12482 * keyboard.c: Make symbols static if they're not exported.
12483 (single_kboard, recent_keys_index, total_keys, recent_keys):
12484 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12485 (this_single_command_key_start, echoing, last_auto_save):
12486 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12487 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12488 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12489 (Vlispy_mouse_stem, double_click_count):
12490 Now static.
12491 (force_auto_save_soon): Define only if SIGDANGER.
12492 (ignore_mouse_drag_p): Now static if
12493 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12494 (print_help): Remove; unused.
12495 (stop_character, last_timer_event): Mark as externally visible.
12496 * keyboard.h (ignore_mouse_drag_p): Declare only if
12497 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12498 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12499 * lisp.h (echoing): Remove decl.
12500 (force_auto_save_soon): Declare only if SIGDANGER.
12501 * xdisp.c (redisplay_window): Simplify code, to make it more
12502 obvious that ignore_mouse_drag_p is not accessed if !defined
12503 USE_GTK && !defined HAVE_NS.
12504
93ea6e8f
PE
12505 * intervals.c: Make symbols static if they're not exported.
12506 (merge_properties_sticky, merge_interval_right, delete_interval):
12507 Now static.
12508 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12509
77382fcc
PE
12510 * insdel.c: Make symbols static if they're not exported.
12511 However, leave prepare_to_modify_buffer alone. It's never
12512 called from outside this function, but that appears to be a bug.
12513 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12514 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12515 (adjust_after_replace_noundo): Remove; unused.
12516 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12517 (signal_before_change): Remove decls.
77382fcc 12518
9306c32e
PE
12519 * indent.c (val_compute_motion, val_vmotion): Now static.
12520
cd44d2eb
PE
12521 * image.c: Make symbols static if they're not exported.
12522 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12523 if USE_GTK.
12524 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12525 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12526
ad9a7a06
PE
12527 * fringe.c (standard_bitmaps): Now static.
12528 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12529
81626931
PE
12530 * frame.c: Make symbols static if they're not exported.
12531 (x_report_frame_params, make_terminal_frame): Now static.
12532 (get_frame_param): Now static, unless HAVE_NS.
12533 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12534 (x_get_resource_string): Remove; not used.
12535 * frame.h (make_terminal_frame, x_report_frame_params):
12536 (x_get_resource_string); Remove decls.
12537 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12538 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12539
239f9db9
PE
12540 * font.c, fontset.c: Make symbols static if they're not exported.
12541 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12542 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12543 * font.c (font_close_object): Now static.
12544 * font.h (font_close_object): Remove.
12545 * fontset.c (FONTSET_OBJLIST): Remove.
12546 (free_realized_fontset) #if-0 the body, which does nothing.
12547 (face_suitable_for_char_p): #if-0, as it's never called.
12548 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12549 * xfaces.c (face_at_string_position):
12550 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12551 since 0 is always ASCII.
12552
dfcf3579
PE
12553 * fns.c (weak_hash_tables): Now static.
12554
5045092b
PE
12555 * fileio.c: Make symbols static if they're not exported.
12556 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12557 (Vwrite_region_annotation_buffers): Now static.
12558
57a96f5c
PE
12559 * eval.c: Make symbols static if they're not exported.
12560 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12561 * lisp.h (backtrace_list): Remove decl.
12562
35f08c38
PE
12563 * emacs.c: Make symbols static if they're not exported.
12564 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12565 (fatal_error_code, fatal_error_signal_hook, standard_args):
12566 Now static.
12567 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12568 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12569 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12570 * lisp.h (fatal_error_signal_hook): Remove decl.
12571 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12572
f44bd759
PE
12573 * editfns.c: Move a (normally-unused) function to its only use.
12574 * editfns.c, lisp.h (get_operating_system_release): Remove.
12575 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12576 worth the hassle of breaking this out.
12577
b532497d
PE
12578 * xterm.c: Make symbols static if they're not exported.
12579 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12580 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12581 (x_destroy_window, x_delete_display):
12582 Now static.
12583 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12584 (x_mouse_leave): Remove; unused.
12585 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12586 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12587 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12588 Remove decls.
12589 (x_mouse_leave): Declare only if WINDOWSNT.
12590 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12591 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12592 USE_X_TOOLKIT.
12593
1675728f
PE
12594 * ftxfont.c: Make symbols static if they're not exported.
12595 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12596 HAVE_FREETYPE.
12597 * font.h (ftxfont_driver): Likewise.
12598
e4cebfca
PE
12599 * xfns.c: Make symbols static if they're not exported.
12600 (x_last_font_name, x_display_info_for_name):
12601 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12602 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12603 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12604 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12605 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12606 (last_show_tip_args): Now static.
12607 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12608 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12609 (x_screen_planes): Remove; unused.
12610 * dispextern.h (x_screen_planes): Remove decl.
12611
5bf46f05
PE
12612 * dispnew.c: Make symbols static if they're not exported.
12613 * dispextern.h (redraw_garbaged_frames, scrolling):
12614 (increment_row_positions): Remove.
12615 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12616 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12617 Now static.
12618 (redraw_garbaged_frames): Remove; unused.
12619
435f4c28
PE
12620 * xfaces.c: Make symbols static if they're not exported.
12621 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12622 Remove decls.
12623 * xterm.h (defined_color): Remove decls.
12624 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12625 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12626 (menu_face_changed_default, defined_color, free_realized_face):
12627 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12628 (ascii_face_of_lisp_face): Remove; unused.
12629
8524aef3
PE
12630 * xdisp.c: Make symbols static if they're not exported.
12631 * dispextern.h (scratch_glyph_row, window_box_edges):
12632 (glyph_to_pixel_coords, set_cursor_from_row):
12633 (get_next_display_element, set_iterator_to_next):
12634 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12635 (show_mouse_face): Remove decls
12636 * frame.h (message_buf_print): Likewise.
12637 * lisp.h (pop_message, set_message, check_point_in_composition):
12638 Likewise.
12639 * xterm.h (set_vertical_scroll_bar): Likewise.
12640 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12641 (message_buf_print, scratch_glyph_row, displayed_buffer):
12642 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12643 (get_next_display_element, show_mouse_face, window_box_edges):
12644 (frame_to_window_pixel_xy, check_point_in_composition):
12645 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12646 (glyph_to_pixel_coords): Remove; unused.
12647
16390cd2
PE
12648 * dired.c (file_name_completion): Now static.
12649
12650 * dbusbind.c (xd_in_read_queued_messages): Now static.
12651
a25f4dfa
PE
12652 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12653 * data.c (circular_list_error): Remove.
12654
14a9c8df
PE
12655 * commands.h (last_point_position, last_point_position_buffer):
12656 (last_point_position_window): Remove decls.
12657 * keyboard.c: Make these variables static.
12658
04f2d78b
CB
12659 * coding.h (coding, code_convert_region, encode_coding_gap):
12660 Remove decls.
74ab6df5
PE
12661 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12662 (iso_code_class, detect_coding, code_convert_region): Now static.
12663 (encode_coding_gap): Remove; unused.
12664
38dfbee1
PE
12665 * chartab.c (chartab_chars, chartab_bits): Now static.
12666
a2cb4e63
PE
12667 * charset.h (charset_iso_8859_1): Remove decl.
12668 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12669 Now static.
12670
127198fd
PE
12671 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12672 * ccl.c (Vccl_program_table): Now static.
12673 (check_ccl_update): Remove; unused.
12674
d85b608f
PE
12675 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12676 * category.h: ... from here.
12677 * category.c (check_category_table, set_category_set): Now static.
12678
31cd66f3
PE
12679 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12680 * lisp.h: Remove these decls.
12681
c358e587
PE
12682 * buffer.c (buffer_count): Remove unused var.
12683
e78aecca
PE
12684 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12685 so that it's not optimized away.
12686 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12687 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12688 exported only to the debugger.
12689
e192d7d3 12690 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12691 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12692
92470028
PE
12693 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12694 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12695 was inaccessible from Lisp.
12696 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12697 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12698
244ed907
PE
12699 alloc.c: Import and export fewer symbols, and remove unused items.
12700 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12701 is defined.
12702 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12703 it's not optimized away by whole-program optimization.
12704 (message_enable_multibyte, free_misc): Remove.
12705 (catchlist, handlerlist, mark_backtrace):
12706 Declare only if BYTE_MARK_STACK.
12707 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12708 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12709 (message_enable_multibyte): Remove decl.
12710 (free_misc, interval_free_list, float_block, float_block_index):
12711 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12712 (cons_free_list, last_marked_index):
12713 Now static.
12714 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12715 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12716 (mark_backtrace): Define only if BYTE_MARK_STACK.
12717 * xdisp.c (message_enable_multibyte): Now static.
12718
61c2b50e 12719 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12720 This makes it easier for human readers (and static analyzers)
12721 to see whether these variables are used from other modules.
12722 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12723 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12724 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12725 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12726 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12727 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12728 * xmenu.c, xselect.c:
12729 Declare Q* vars static if they are not used in other modules.
12730 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12731 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12732 Remove decls of unexported vars.
12733 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12734
95c82688
PE
12735 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12736
16a97296
PE
12737 Make Emacs functions such as Fatom 'static' by default.
12738 This makes it easier for human readers (and static analyzers)
12739 to see whether these functions can be called from other modules.
12740 DEFUN now defines a static function. To make the function external
12741 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12742 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12743 (Finit_image_library):
16a97296
PE
12744 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12745 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12746 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12747 Remove decls, since these functions are now static.
12748 (Funintern, Fget_internal_run_time): New decls, since these functions
12749 were already external.
95c82688 12750
16a97296
PE
12751 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12752 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12753 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12754 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12755 * keyboard.c, keymap.c, lread.c:
12756 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12757 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12758 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12759 Mark functions with DEFUE instead of DEFUN,
12760 if they are used in other modules.
12761 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12762 decls for now-static functions.
12763 * buffer.h (Fdelete_overlay): Remove decl.
12764 * callproc.c (Fgetenv_internal): Mark as internal.
12765 * composite.c (Fremove_list_of_text_properties): Remove decl.
12766 (Fcomposition_get_gstring): New forward static decl.
12767 * composite.h (Fcomposite_get_gstring): Remove decl.
12768 * dired.c (Ffile_attributes): New forward static decl.
12769 * doc.c (Fdocumntation_property): New forward static decl.
12770 * eval.c (Ffetch_bytecode): New forward static decl.
12771 (Funintern): Remove extern decl; now in .h file where it belongs.
12772 * fileio.c (Fmake_symbolic_link): New forward static decl.
12773 * image.c (Finit_image_library): New forward static decl.
12774 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12775 * intervals.h (Fprevious_property_change):
12776 (Fremove_list_of_text_properties): Remove decls.
12777 * keyboard.c (Fthis_command_keys): Remove decl.
12778 (Fcommand_execute): New forward static decl.
12779 * keymap.c (Flookup_key): New forward static decl.
12780 (Fcopy_keymap): Now static.
12781 * keymap.h (Flookup_key): Remove decl.
12782 * process.c (Fget_process): New forward static decl.
12783 (Fprocess_datagram_address): Mark as internal.
12784 * syntax.c (Fsyntax_table_p): New forward static decl.
12785 (skip_chars): Remove duplicate decl.
12786 * textprop.c (Fprevious_property_change): New forward static decl.
12787 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12788 Now internal.
12789 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12790 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12791
785bbd42
PE
12792 * editfns.c (Fformat): Remove unreachable code.
12793
8b913b57
AS
127942011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12795
12796 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12797 change. (Bug#8496)
12798
a6744a35
EZ
127992011-04-13 Eli Zaretskii <eliz@gnu.org>
12800
12801 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12802 when at ZV. (Bug#8487)
12803
e7974947
AS
128042011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12805
baad03f0
AS
12806 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12807 (Bug#8437)
12808 * keyboard.c (parse_tool_bar_item): Likewise.
12809 * sound.c (sound_cleanup, alsa_close): Likewise.
12810 * termcap.c (tgetent): Likewise.
12811 * xfns.c (x_default_font_parameter): Likewise.
12812 * xsettings.c (read_and_apply_settings): Likewise.
12813
e7974947
AS
12814 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12815 (overrun_check_free): Protoize.
12816
28272684
PE
128172011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12818
12819 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12820 since callers should never pass a negative size.
12821 Change the signature to match that of plain 'read' and 'write'; see
12822 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12823 * lisp.h: Update prototypes of emacs_write and emacs_read.
12824
11997c76
EZ
128252011-04-11 Eli Zaretskii <eliz@gnu.org>
12826
12827 * xdisp.c (redisplay_window): Don't try to determine the character
12828 position of the scroll margin if the window start point w->startp
e896f03c 12829 is outside the buffer's accessible region. (Bug#8468)
11997c76 12830
8a2cbd72
EZ
128312011-04-10 Eli Zaretskii <eliz@gnu.org>
12832
12833 Fix write-region and its subroutines for buffers > 2GB.
12834 * fileio.c (a_write, e_write): Modify declaration of arguments and
12835 local variables to support buffers larger than 2GB.
12836 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12837
12838 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12839 argument, local variables, and return value.
12840
12841 * lisp.h: Update prototypes of emacs_write and emacs_read.
12842
12843 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12844
4073e537 128452011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12846
1ebfdcb6
PE
12847 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12848
b2ded58d
PE
12849 Fix more problems found by GCC 4.6.0's static checks.
12850
7d66342c
PE
12851 * xdisp.c (vmessage): Use a better test for character truncation.
12852
bbf47d44
PE
12853 * charset.c (load_charset_map): <, not <=, for optimization,
12854 and to avoid potential problems with integer overflow.
9248994d 12855 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12856 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12857 * editfns.c (Fformat): Likewise.
1e69125e 12858 * syntax.c (skip_chars): Likewise.
3befa583 12859
e3019616
PE
12860 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12861 This also lets GCC 4.6.0 generate slightly better loop code.
12862
becfa255
PE
12863 * callint.c (Fcall_interactively): <, not <=, for optimization.
12864 (Fcall_interactively): Count the number of arguments produced,
12865 not the number of arguments given. This is simpler and lets GCC
12866 4.6.0 generate slightly better code.
12867
dae0cd48
PE
12868 * ftfont.c: Distingish more carefully between FcChar8 and char.
12869 The previous code passed unsigned char * to a functions like
12870 strlen and xstrcasecmp that expect char *, which does not
12871 conform to the C standard.
12872 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12873 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12874 char * when the C standard requires it.
12875
76032d70
PE
12876 * keyboard.c (read_char): Remove unused var.
12877
eb3f1cc8
PE
12878 * eval.c: Port to Windows vsnprintf (Bug#8435).
12879 Include <limits.h>.
12880 (SIZE_MAX): Define if the headers do not.
12881 (verror): Do not give up if vsnprintf returns a negative count.
12882 Instead, grow the buffer. This ports to Windows vsnprintf, which
12883 does not conform to C99. Problem reported by Eli Zaretskii.
12884 Also, simplify the allocation scheme, by avoiding the need for
12885 calling realloc, and removing the ALLOCATED variable.
12886
70476b54
PE
12887 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12888
12020a9e
PE
12889 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12890 But keep the doprint source code for now, as we might revamp it
12891 and use it again (Bug#8435).
ea6c7ae6
PE
12892 * lisp.h (doprnt): Remove.
12893 * Makefile.in (base_obj): Remove doprnt.o.
12894 * deps.mk (doprnt.o): Remove.
12895
5fdb398c
PE
12896 error: Print 32- and 64-bit integers portably (Bug#8435).
12897 Without this change, on typical 64-bit hosts error ("...%d...", N)
12898 was used to print both 32- and 64-bit integers N, which relied on
12899 undefined behavior.
61bdb816 12900 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12901 * lisp.h (error, verror): Mark as printf-like functions.
12902 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12903 Report overflow in size calculations when allocating printf buffer.
12904 Do not truncate output string at its first null byte.
12905 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12906 Truncate the output at a character boundary, since vsnprintf does not
12907 do that.
12908 * charset.c (check_iso_charset_parameter): Convert internal
12909 character to string before calling 'error', since %c now has the
12910 printf meaning.
12911 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12912 overflow when computing char to be passed to 'error'. Do not
12913 pass Lisp_Object to 'error'; pass the integer instead.
12914 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12915 formatted with plain %d.
12916
b189fa66
PE
12917 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12918
bff87ef0
PE
12919 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12920
7e2cac20
PE
12921 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12922
ce4d90b5
PE
12923 * xterm.c (x_catch_errors): Remove duplicate declaration.
12924
266c9547
PE
12925 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12926
79c49ad2
PE
12927 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12928
368f4090
JM
129292011-04-10 Jim Meyering <meyering@redhat.com>
12930
12931 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12932 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12933 return ssize_t not "int", and use size_t as the buffer length.
12934 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12935 * gnutls.h: Update declarations.
12936 * process.c (read_process_output): Use ssize_t, to match.
12937 (send_process): Likewise.
12938
a32d4040
CY
129392011-04-09 Chong Yidong <cyd@stupidchicken.com>
12940
12941 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12942
8546720e 129432011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12944
04f2d78b
CB
12945 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12946 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12947
8546720e
GM
12948 * xterm.c (handle_one_xevent):
12949 * xmenu.c (create_and_show_popup_menu):
12950 * xselect.c (x_decline_selection_request)
12951 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12952
0a2f5c1a 129532011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12954
12955 Fix some uses of `int' instead of EMACS_INT.
12956 * search.c (string_match_1, fast_string_match)
12957 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12958 (scan_buffer, find_next_newline_no_quit)
12959 (find_before_next_newline, search_command, Freplace_match)
12960 (Fmatch_data): Make some `int' variables be EMACS_INT.
12961
12962 * xdisp.c (display_count_lines): 3rd argument and return value now
12963 EMACS_INT. All callers changed.
12964 (pint2hrstr): Last argument is now EMACS_INT.
12965
12966 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12967 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12968 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12969 (decode_coding_utf_16, decode_coding_emacs_mule)
12970 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12971 (decode_coding_ccl, decode_coding_charset)
12972 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12973 (decode_coding_iso_2022, decode_coding_emacs_mule)
12974 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12975 <char_offset, last_offset>: Declare EMACS_INT.
12976 (encode_coding_utf_8, encode_coding_utf_16)
12977 (encode_coding_emacs_mule, encode_invocation_designation)
12978 (encode_designation_at_bol, encode_coding_iso_2022)
12979 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12980 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12981 Declare EMACS_INT.
12982 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12983 (encode_invocation_designation): Last argument P_NCHARS is now
12984 EMACS_INT.
12985 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12986 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12987
12988 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12989 All users changed.
12990
12991 * ccl.c (Fccl_execute_on_string): Declare some variables
12992 EMACS_INT.
12993
8546720e 129942011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12995
12996 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12997
4e19a977
CS
129982011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12999
13000 * process.c (Fformat_network_address): Doc fix.
13001
87302331
R
130022011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13003
ee7683eb 13004 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13005
cbb59342
CY
130062011-04-08 Chong Yidong <cyd@stupidchicken.com>
13007
13008 * keyboard.c (read_char): Call Lisp function help-form-show,
13009 instead of using internal_with_output_to_temp_buffer.
13010 (Qhelp_form_show): New var.
e0d38eeb 13011 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13012
13013 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13014
13015 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13016
e67a13ab
CY
130172011-04-06 Chong Yidong <cyd@stupidchicken.com>
13018
04f2d78b
CB
13019 * process.c (Flist_processes): Remove to Lisp.
13020 (list_processes_1): Delete.
e67a13ab 13021
973f782d
EZ
130222011-04-06 Eli Zaretskii <eliz@gnu.org>
13023
7c106b1e
EZ
13024 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13025
973f782d
EZ
13026 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13027
41cf7d1a 130282011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13029
ca23cc88
PE
13030 Fix more problems found by GCC 4.6.0's static checks.
13031
f390e2d5
PE
13032 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13033
42eea0d0
PE
13034 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13035
b69769da 13036 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13037
f9541e84
PE
13038 * xdisp.c (vmessage): Mark as a printf-like function.
13039
13841b55
PE
13040 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13041
c136c10f
PE
13042 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13043
5e2d4a30
PE
13044 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13045 printf-like functions.
13046 (tiff_load): Add casts to remove these marks before passing them
13047 to system-supplied API.
13048
583f48b9
PE
13049 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13050
b25d760e
PE
13051 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13052 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13053 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13054 directly, rather than having caller test rule sign. This avoids
13055 some unnecessary tests.
13056 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13057 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13058 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13059
bc7b6697 13060 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13061 (xfont_open): Avoid unnecessary tests.
bc7b6697 13062
27ccc379
PE
13063 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13064
dcd5c89a
PE
13065 * composite.h, composite.c (composition_gstring_put_cache):
13066 Use EMACS_INT, not int, for length.
13067
b13a45c6
PE
13068 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13069 breaking out part of COMPOSITION_DECODE_RULE.
13070 (COMPOSITION_DECODE_RULE): Use it.
13071 * composite.c (get_composition_id): Remove unused local vars,
13072 by using the new macro.
13073
1e792e4d
PE
13074 * textprop.c (set_text_properties_1): Change while to do-while,
13075 since the condition is always true at first.
13076
dc6c6455 13077 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13078 (interval_deletion_adjustment): Return unsigned value.
13079 All uses changed.
dc6c6455 13080
aba7731a
PE
13081 * process.c (list_processes_1, create_pty, read_process_output):
13082 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13083 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13084 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13085 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13086 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13087
fdfc4bf3
PE
13088 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13089
fca8fe46 13090 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13091 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13092
06a0259a 13093 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13094 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13095 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13096
e7b9e80f
PE
13097 * print.c (print_error_message): Avoid int overflow.
13098
56201685
PE
13099 * font.c (font_list_entities): Redo for clarity,
13100 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13101
78834453 13102 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13103 (font_score): Avoid potential overflow in diff calculation.
78834453 13104
0bc0b309 13105 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13106 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13107
e610eaca
PE
13108 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13109
b895abce
PE
13110 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13111 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13112 can always succeed if overflow has undefined behavior.
13113
1f1d9321 13114 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13115 (wordify): Omit three unnecessary tests.
1f1d9321 13116
c59478bc
PE
13117 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13118 All callers changed. This avoids the need for an unused var.
13119
79b73827
PE
13120 * casefiddle.c (casify_region): Remove var that is set but not used.
13121
a4db5dfe
PE
13122 * dired.c (file_name_completion): Remove var that is set but not used.
13123
43aae36e
PE
13124 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13125
2a47c44d 13126 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13127 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13128
a37c69bf
PE
13129 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13130 Check for integer overflow on size calculations.
13131
328ab8e7
PE
13132 * buffer.c (Fprevious_overlay_change): Remove var that is set
13133 but not used.
13134
e5a2a5cb
PE
13135 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13136 Remove vars that are set but not used.
8d84a6eb 13137 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13138 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13139
a60e5f68
PE
13140 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13141
f661cb61 13142 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13143 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13144
f0397f5a
PE
13145 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13146 that are set but not used.
13147
8664db06 13148 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13149 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13150
6abdaa4a
PE
13151 * xselect.c (x_get_local_selection, x_handle_property_notify):
13152 Remove vars that are set but not used.
13153
0ce7538d 13154 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13155 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13156
9ae848fc
PE
13157 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13158 Remove var that is set but not used.
0b918413
PE
13159 (scroll_bar_windows_size): Now size_t, not int.
13160 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13161 Check for overflow.
9ae848fc 13162
a5a62657
PE
13163 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13164 (map_tty_color) [!defined MSDOS]: Likewise.
13165
5c5cdd39
PE
13166 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13167
66ebf983
PE
13168 * coding.c: Remove vars that are set but not used.
13169 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13170 All callers changed.
13171 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13172 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13173 (decode_coding_charset): Remove vars that are set but not used.
13174
1be4d761
PE
13175 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13176 that is set but not used.
13177
47553fa8
PE
13178 * print.c (print_object): Remove var that is set but not used.
13179
1f7196bf 13180 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13181 The gnulib version avoids calling malloc in the usual case,
13182 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13183 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13184 * filelock.c (current_lock_owner): Likewise.
13185 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13186 * sysdep.c: Include allocator.h, careadlinkat.h.
13187 (emacs_no_realloc_allocator): New static constant.
13188 (emacs_readlink): New function.
fdb61804
PE
13189 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13190 ../lib/careadlinkat.h.
d1fdcab7 13191
f84c17c7
SM
131922011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13193
13194 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13195 first non-nil return value).
13196
ef3862ad
JD
131972011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13198
13199 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13200 if not defined (Bug#8403).
13201
376a7006
JB
132022011-04-02 Juanma Barranquero <lekktu@gmail.com>
13203
13204 * xdisp.c (display_count_lines): Remove parameter `start',
13205 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13206 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13207 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13208 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13209 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13210 and thereabouts. All callers changed.
13211 (get_per_char_metric): Remove parameter `f', unused since
13212 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13213
6ca3801d
JM
132142011-04-02 Jim Meyering <meyering@redhat.com>
13215
13216 do not dereference NULL upon failed strdup
13217 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13218 (ns_get_family): Likewise.
13219
d8e2b5ba
JB
132202011-04-02 Juanma Barranquero <lekktu@gmail.com>
13221
13222 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13223
8c74fcbd
JD
132242011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13225
13226 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13227 later (Bug#8403).
13228
7200d79c
SM
132292011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13230
03408648 13231 Add lexical binding.
7200d79c 13232
03408648
SM
13233 * window.c (Ftemp_output_buffer_show): New fun.
13234 (Fsave_window_excursion):
13235 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13236
13237 * lread.c (lisp_file_lexically_bound_p): New function.
13238 (Fload): Bind Qlexical_binding.
13239 (readevalloop): Remove `evalfun' arg.
13240 Bind Qinternal_interpreter_environment.
13241 (Feval_buffer): Bind Qlexical_binding.
13242 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13243 Mark as dynamic.
13244 (syms_of_lread): Declare `lexical-binding'.
13245
13246 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13247
13248 * keyboard.c (eval_dyn): New fun.
13249 (menu_item_eval_property): Use it.
ca105506
SM
13250
13251 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13252
03408648
SM
13253 * fns.c (concat, mapcar1): Accept byte-code-functions.
13254
13255 * eval.c (Fsetq): Handle lexical vars.
13256 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13257 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13258 (FletX, Flet): Obey lexical binding.
13259 (Fcommandp): Handle closures.
13260 (Feval): New `lexical' arg.
13261 (eval_sub): New function extracted from Feval. Use it almost
13262 everywhere where Feval was used. Look up vars in lexical env.
13263 Handle closures.
13264 (Ffunctionp): Move from subr.el.
13265 (Ffuncall): Handle closures.
13266 (apply_lambda): Remove `eval_flags'.
13267 (funcall_lambda): Handle closures and new byte-code-functions.
13268 (Fspecial_variable_p): New function.
13269 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13270 but without exporting it to Lisp.
23aba0ea 13271
23aba0ea 13272 * doc.c (Fdocumentation, store_function_docstring):
03408648 13273 * data.c (Finteractive_form): Handle closures.
23aba0ea 13274
03408648
SM
13275 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13276 interactive spec.
ba83908c 13277
04f2d78b
CB
13278 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13279 New byte-codes.
03408648
SM
13280 (exec_byte_code): New function extracted from Fbyte_code to handle new
13281 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13282
03408648 13283 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13284
03408648 13285 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13286
e2abce01
JB
132872011-03-31 Juanma Barranquero <lekktu@gmail.com>
13288
13289 * xdisp.c (redisplay_internal): Fix prototype.
13290
63696a73 132912011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13292
63696a73 13293 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13294 (try_scrolling): Use it when setting scroll_limit.
13295 Limit scrolling to 100 screen lines.
63696a73
EZ
13296 (redisplay_window): Even when falling back on "recentering",
13297 position point in the window according to scroll-conservatively,
13298 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13299
13300 (try_scrolling): When point is above the window, allow searching
13301 as far as scroll_max, or one screenful, to compute vertical
13302 distance from PT to the scroll margin position. This prevents
13303 try_scrolling from unnecessarily failing when
13304 scroll-conservatively is set to a value slightly larger than the
13305 window height. Clean up the case of PT below the margin at bottom
13306 of window: scroll_max can no longer be INT_MAX. When aggressive
13307 scrolling is in use, don't let point enter the opposite scroll
13308 margin as result of the scroll.
13309 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13310 threshold of 100 lines for never-recentering scrolling.
13311
e4cc2dfc
JB
133122011-03-31 Juanma Barranquero <lekktu@gmail.com>
13313
13314 * dispextern.h (move_it_by_lines):
13315 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13316 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13317 (message_log_check_duplicate): Remove parameters `prev_bol' and
13318 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13319 (redisplay_internal): Remove parameter `preserve_echo_area',
13320 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13321
13322 * indent.c (Fvertical_motion):
13323 * window.c (window_scroll_pixel_based, Frecenter):
13324 Don't pass `need_y_p' to `move_it_by_lines'.
13325
1c470562
SM
133262011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13327
44f230aa
SM
13328 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13329 steal a few bits to be more compact.
13330 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13331 Remove unneeded casts.
13332
1c470562
SM
13333 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13334
888adce9
ZK
133352011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13336
13337 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13338 binding" message (bug#7967).
13339
f838ed7b
PE
133402011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13341
77861b95
PE
13342 Fix more problems found by GCC 4.6.0's static checks.
13343
de6dbc14
PE
13344 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13345 Remove unused local var.
13346
f838ed7b
PE
13347 * editfns.c (Fmessage_box): Remove unused local var.
13348
792c7b2b
PE
13349 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13350 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13351 Omit unused local vars.
c499e557 13352 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13353 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13354 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13355 Omit unused local var.
13356
ba0165e1
PE
13357 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13358 Don't assume string length fits in int.
32ad8845 13359 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13360 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13361
3c59b4c9
PE
13362 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13363 instead of alloca (Bug#8344).
13364
a3eed478 13365 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13366 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13367
eb4d412d
PE
13368 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13369
1658b401
PE
13370 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13371 concerns.
13372
13373 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13374
13375 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13376
9a2c6e05
PE
13377 * keyboard.c (syms_of_keyboard): Use the same style as later
13378 in this function when indexing through an array. This also
13379 works around GCC bug 48267.
13380
03d0a109
PE
13381 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13382
44f730c8
PE
13383 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13384
fe75f926
PE
13385 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13386 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13387
ffa8c828
PE
13388 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13389 This avoids undefined behavior on integer overflow, and is a bit
13390 more convenient anyway since it is compared to a size_t variable.
13391
c5101a77
PE
13392 Variadic C functions now count arguments with size_t, not int.
13393 This avoids an unnecessary limitation on 64-bit machines, which
13394 caused (substring ...) to crash on large vectors (Bug#8344).
13395 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13396 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13397 All variadic functions and their callers changed accordingly.
c5101a77
PE
13398 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13399 * data.c (arith_driver, float_arith_driver): Likewise.
13400 * editfns.c (general_insert_function): Likewise.
13401 * eval.c (struct backtrace.nargs, interactive_p)
13402 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13403 (funcall_lambda, mark_backtrace): Likewise.
13404 * fns.c (concat): Likewise.
13405 * frame.c (x_set_frame_parameters): Likewise.
13406 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13407 0 if not found, not -1. All callers changed.
13408
dd3f25f7
PE
13409 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13410 (stack_copy_size): Now size_t, not int.
13411 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13412
461c2ab9
JB
134132011-03-28 Juanma Barranquero <lekktu@gmail.com>
13414
13415 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13416 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13417 All callers changed.
13418
13419 * lisp.h (multibyte_char_to_unibyte):
13420 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13421 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13422 * character.h (CHAR_TO_BYTE8):
13423 * cmds.c (internal_self_insert):
13424 * editfns.c (general_insert_function):
13425 * keymap.c (push_key_description):
13426 * search.c (Freplace_match):
13427 * xdisp.c (message_dolog, set_message_1): All callers changed.
13428
f6d62986
SM
134292011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13430
13431 * keyboard.c (safe_run_hook_funcall): New function.
13432 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13433 don't set the hook to nil, but remove the offending function instead.
13434 (Qcommand_hook_internal): Remove, unused.
13435 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13436 Vcommand_hook_internal.
13437
13438 * eval.c (enum run_hooks_condition): Remove.
13439 (funcall_nil, funcall_not): New functions.
13440 (run_hook_with_args): Call each function through a `funcall' argument.
13441 Remove `cond' argument, now redundant.
13442 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13443 (Frun_hook_with_args_until_failure): Adjust accordingly.
13444 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13445
1db5b1ad
JB
134462011-03-28 Juanma Barranquero <lekktu@gmail.com>
13447
13448 * dispextern.h (string_buffer_position): Remove declaration.
13449
13450 * print.c (strout): Remove parameter `multibyte', unused since
13451 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13452
13453 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13454 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13455 All callers changed.
13456
13457 * w32.c (_wsa_errlist): Use braces for struct initializers.
13458
13459 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13460 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13461 All callers changed.
13462 (string_buffer_position): Likewise. Also, make static (it's never
13463 used outside xdisp.c).
13464 (cursor_row_p): Remove parameter `w', unused since
13465 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13466 (decode_mode_spec): Remove parameter `precision', introduced during
13467 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13468 All callers changed.
13469
5ffb62aa
JD
134702011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13471
13472 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13473
461c2ab9 134742011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13475
13476 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13477 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13478 (ns_update_auto_hide_menu_bar): New functions.
13479 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13480 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13481 ns_constrain_all_frames.
13482 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13483 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13484
5c380ffb
JD
134852011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13486
13487 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13488
9af30bdf
GM
134892011-03-27 Glenn Morris <rgm@gnu.org>
13490
13491 * syssignal.h: Replace RETSIGTYPE with void.
13492 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13493 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13494 Replace SIGTYPE with void everywhere.
13495 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13496 * s/template.h (SIGTYPE): Remove commented out definition.
13497
e2abce01
JB
134982011-03-26 Eli Zaretskii <eliz@gnu.org>
13499
13500 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13501 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13502
f868cd8a
JB
135032011-03-26 Juanma Barranquero <lekktu@gmail.com>
13504
59eb0929
JB
13505 * w32.c (read_unc_volume): Use parameter `henum', instead of
13506 global variable `wget_enum_handle'.
13507
13508 * keymap.c (describe_vector): Remove parameters `indices' and
13509 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13510 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13511
f868cd8a
JB
13512 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13513
13514 * keyboard.c (timer_check): Remove parameter `do_it_now',
13515 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13516 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13517 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13518
13519 * keyboard.c (read_char):
13520 * w32menu.c (w32_menu_display_help):
13521 * xmenu.c (show_help_event, menu_help_callback):
13522 Adjust calls to `show_help_echo'.
13523
13524 * gtkutil.c (xg_maybe_add_timer):
13525 * keyboard.c (readable_events):
13526 * process.c (wait_reading_process_output):
13527 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13528
13529 * insdel.c (adjust_markers_gap_motion):
13530 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13531 (gap_left, gap_right): Don't call it.
13532
2ecf6fdb
CY
135332011-03-25 Chong Yidong <cyd@stupidchicken.com>
13534
13535 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13536 incurred during fontification.
13537
6b1f9ba4
JB
135382011-03-25 Juanma Barranquero <lekktu@gmail.com>
13539
13540 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13541 (DEFVAR_PER_BUFFER): Don't pass it.
13542
13543 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13544 (scrolling_window): Don't pass it.
13545
0f4a96b5
JB
135462011-03-25 Juanma Barranquero <lekktu@gmail.com>
13547
13548 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13549
13550 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13551 and `suffix'.
13552 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13553 of variables specific to SELinux and computation of `encoded_absname'.
13554
13555 * image.c (XPutPixel): Remove unused variable `height'.
13556
13557 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13558
13559 * unexw32.c (get_section_info): Remove unused variable `section'.
13560
13561 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13562 (system_process_attributes): Remove unused variable `sess'.
13563 (sys_read): Remove unused variable `err'.
13564
13565 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13566 (w32_wnd_proc): Remove unused variable `isdead'.
13567 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13568 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13569 (x_create_tip_frame): Remove unused variable `tem'.
13570
13571 * w32inevt.c (w32_console_read_socket):
13572 Remove unused variable `no_events'.
13573
13574 * w32term.c (x_draw_composite_glyph_string_foreground):
13575 Remove unused variable `width'.
13576
1149507c
JB
135772011-03-24 Juanma Barranquero <lekktu@gmail.com>
13578
13579 * w32term.c (x_set_glyph_string_clipping):
13580 Don't pass uninitialized region to CombineRgn.
13581
9c88f339
JB
135822011-03-23 Juanma Barranquero <lekktu@gmail.com>
13583
13584 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13585 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13586 (Fx_close_connection): Remove unused variable `i'.
13587
13588 * w32font.c (w32font_draw): Return number of glyphs.
13589 (w32font_open_internal): Remove unused variable `i'.
13590 (w32font_driver): Add missing initializer.
13591
13592 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13593 (fill_in_menu): Remove unused variable `items_added'.
13594
13595 * w32term.c (last_mouse_press_frame): Remove static global variable.
13596 (w32_clip_to_row): Remove unused variable `f'.
13597 (x_delete_terminal): Remove unused variable `i'.
13598
13599 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13600 (NOTHING): Remove unused static global variable.
13601 (uniscribe_check_otf): Remove unused variable `table'.
13602 (uniscribe_font_driver): Add missing initializers.
13603
dee091a3
JD
136042011-03-23 Julien Danjou <julien@danjou.info>
13605
13606 * term.c (Fsuspend_tty, Fresume_tty):
13607 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13608 * window.c (temp_output_buffer_show):
13609 * insdel.c (signal_before_change):
13610 * frame.c (Fhandle_switch_frame):
13611 * fileio.c (Fdo_auto_save):
13612 * emacs.c (Fkill_emacs):
13613 * editfns.c (save_excursion_restore):
13614 * cmds.c (internal_self_insert):
13615 * callint.c (Fcall_interactively):
13616 * buffer.c (Fkill_all_local_variables):
13617 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13618 Use Frun_hooks.
0f4a96b5 13619 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13620 unconditionally since it does the check itself.
dee091a3 13621
2c520ab5 136222011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13623
c9c49752
PE
13624 Fix more problems found by GCC 4.5.2's static checks.
13625
8abc3f12
PE
13626 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13627 the first time through the loop, since we know p0 < p1 then.
13628 This also avoids a gcc -Wstrict-overflow warning.
13629
a2d26660
PE
13630 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13631 leading to a memory leak, possible in functions like
13632 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13633 of objects (Bug#8318).
a2d26660 13634
916c72e9
PE
13635 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13636 that could (at least in theory) be that large.
13637
19ab8a18
PE
13638 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13639 This is less likely to overflow, and avoids undefined behavior if
13640 overflow does occur. All callers changed. Use strtoul to scan
13641 for the unsigned long integer.
b7cbbd6f
PE
13642 (pint2hrstr): Simplify and tune code slightly.
13643 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13644
f0641eff
PE
13645 * scroll.c (do_scrolling): Work around GCC bug 48228.
13646 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13647
7f650bb9
PE
13648 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13649 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13650 (validate_x_resource_name): Simplify count usage.
13651 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13652
37dd57d1
PE
13653 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13654 fail (Bug#8306).
81e56e61 13655
699979fc 13656 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13657
401bf9b4
PE
13658 * process.c (Fmake_network_process): Use socklen_t, not int,
13659 where POSIX says socklen_t is required in portable programs.
13660 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13661 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13662 (Fmake_network_process, server_accept_connection):
13663 (wait_reading_process_output, read_process_output):
13664 Likewise.
13665
b93aacde
PE
13666 * process.c: Rename or move locals to avoid shadowing.
13667 (list_processes_1, Fmake_network_process):
13668 (read_process_output_error_handler, exec_sentinel_error_handler):
13669 Rename or move locals.
4dc343ee 13670 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13671 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13672 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13673 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13674 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13675
af8a867c 13676 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13677 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13678 Include tparam.h instead, since it declares them.
af8a867c
PE
13679 * cm.h (PC): Remove extern decl; tparam.h now does this.
13680 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13681 * terminfo.c: Include tparam.h, to check interfaces.
13682 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13683 (tparam): Adjust signature to match interface in tparam.h;
13684 this removes some undefined behavior. Check that outstring and len
13685 are zero, which they always are with Emacs.
13686 * tparam.h (PC, BC, UP): New extern decls.
13687
0248044d 13688 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13689 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13690
8ff096c1 13691 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13692 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13693 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13694 (ftfont_list): Remove unused local.
49eaafba
PE
13695 (get_adstyle_property, ftfont_pattern_entity):
13696 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13697 Rename locals to avoid shadowing.
8ff096c1 13698
e2be39f6
PE
13699 * xfont.c (xfont_list_family): Mark var as initialized.
13700
c9735e30
PE
13701 * xml.c (make_dom): Now static.
13702
8f5201ae
PE
13703 * composite.c (composition_compute_stop_pos): Rename local to
13704 avoid shadowing.
b246f932
PE
13705 (composition_reseat_it): Remove unused locals.
13706 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13707 (composition_update_it): Mark var as initialized.
11b61122
PE
13708 (find_automatic_composition): Mark vars as initialized,
13709 with a FIXME (Bug#8290).
8f5201ae 13710
760fbc2c
PE
13711 character.h: Rename locals to avoid shadowing.
13712 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13713 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13714 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13715 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13716 to avoid shadowing.
13717
ff08eb85
PE
13718 * textprop.c (property_change_between_p): Remove; unused.
13719
fc7bf025
PE
13720 * intervals.c (interval_start_pos): Now static.
13721
235d7abc
PE
13722 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13723
44f230aa
SM
13724 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13725 Rename locals to avoid shadowing.
3e7d6594 13726
50060332
PE
13727 * sound.c (wav_play, au_play, Fplay_sound_internal):
13728 Fix pointer signedness.
d01f234b 13729 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13730 (wav_play): Initialize a variable to 0, to prevent undefined
13731 behavior (Bug#8278).
50060332 13732
c4fc4e30
PE
13733 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13734
918436ed
PE
13735 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13736
c939f91b
PE
13737 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13738 clobbering (Bug#8298).
b9c7f648
PE
13739 * sysdep.c (sys_subshell): Likewise.
13740 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13741
6bd8c144
PE
13742 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13743 This should get cleaned up, so that child_setup has the
13744 same signature on all platforms.
13745
7710357c 13746 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13747 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13748
c59da222
CY
137492011-03-22 Chong Yidong <cyd@stupidchicken.com>
13750
13751 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13752 not to be necessary, and produces flickering.
13753
66b87493
GM
137542011-03-20 Glenn Morris <rgm@gnu.org>
13755
13756 * config.in: Remove file.
13757
45b6f6d5
JB
137582011-03-20 Juanma Barranquero <lekktu@gmail.com>
13759
13760 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13761 are now in src/globals.h.
13762 (syms_of_minibuf): Remove spurious & from previous change.
13763
cd394be1 137642011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13765
13766 * minibuf.c (completing-read-function): New variable.
13767 (completing-read-default): Rename from completing-read.
13768 (completing-read): Call completing-read-function.
13769
b14e3e21
CY
137702011-03-19 Juanma Barranquero <lekktu@gmail.com>
13771
13772 * xfaces.c (Fx_load_color_file):
13773 Read color file from absolute filename (bug#8250).
13774
f2b726e6
JB
137752011-03-19 Juanma Barranquero <lekktu@gmail.com>
13776
13777 * makefile.w32-in: Update dependencies.
13778
09f6ff02
EZ
137792011-03-17 Eli Zaretskii <eliz@gnu.org>
13780
13781 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13782
29a6015a
PE
137832011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13784
a3a6c54e
PE
13785 Fix more problems found by GCC 4.5.2's static checks.
13786
b766f867
PE
13787 * process.c (make_serial_process_unwind, send_process_trap):
13788 (sigchld_handler): Now static.
13789
be02381c
PE
13790 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13791 That way, the code declares only the vars that it needs.
13792 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13793 * s/cygwin.h (PTY_ITERATION): Likewise.
13794 * s/darwin.h (PTY_ITERATION): Likewise.
13795 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13796
57048744
PE
13797 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13798 * process.c (allocate_pty): Don't declare stb unless it's needed.
13799
7914961c 13800 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13801 (CONSTANTLIM): Remove; unused.
13802 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13803 Define only if needed.
7914961c 13804
b3967b18
PE
13805 * unexelf.c (unexec): Name an expression,
13806 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13807 Use a different way to cause a compilation error if anyone uses
13808 n rather than nn, a way that does not involve shadowing.
73366a00 13809 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13810
29a6015a
PE
13811 * deps.mk (unexalpha.o): Remove; unused.
13812
43cfc33e 13813 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13814 * unexec.h: New file.
ce701a33
PE
13815 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13816 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13817 Depend on unexec.h.
13818 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13819 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13820 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13821 Change as necessary to match prototype in unexec.h.
ce701a33 13822
01f44d5a
PE
13823 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13824 shadowing.
4f63c6bb 13825 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13826
a6670b0b
PE
13827 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13828 Rename locals to avoid shadowing.
13829
cef2010d 13830 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13831 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13832
d4d7173a
PE
13833 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13834
f08b802a
PE
13835 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13836 warning when compiling print.c.
13837
3ddb0639
PE
13838 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13839 instead of using an uninitialized var.
5ad03b97 13840 (font_sort_entities): Mark var as initialized.
3ddb0639 13841
170a2692
PE
13842 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13843
e663c700
PE
13844 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13845 pointers to constants.
89bc529a 13846 (font_parse_fcname): Remove unused vars.
7b81e2d0 13847 (font_delete_unmatched): Now static.
ea838e10 13848 (font_get_spec): Remove; unused.
13a547c6
PE
13849 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13850 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13851 Rename or move locals to avoid shadowing.
e663c700 13852
2a80c887 13853 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13854 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13855
1384fa33 13856 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13857 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13858
8b2c52e9
PE
13859 * alloc.c (mark_backtrace): Move decl from here ...
13860 * lisp.h: ... to here, so that it can be checked.
13861
475545b5 13862 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13863 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13864 (lisp_indirect_variable): Name an expression,
13865 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13866 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13867
b1349114 13868 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13869 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13870 Use const pointer when appropriate.
b1349114 13871
a2928364
PE
13872 * lisp.h (get_system_name, get_operating_system_release):
13873 Move decls here, to check interfaces.
13874 * process.c (get_operating_system_release): Move decl to lisp.h.
13875 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13876 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13877 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13878 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13879 (Fformat_time_string, Fencode_time, Finsert_char):
13880 (Ftranslate_region_internal, Fformat):
13881 Rename or remove local vars to avoid shadowing.
9710023e 13882 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13883
a415e694
PE
13884 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13885 avoid shadowing.
13886
8ef4622d
PE
13887 * lisp.h (eassert): Check that the argument compiles, even if
13888 ENABLE_CHECKING is not defined.
13889
946f9a5b
PE
13890 * data.c (Findirect_variable): Name an expression, to avoid
13891 gcc -Wbad-function-cast warning.
112396d6 13892 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13893 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13894 (Fmake_variable_buffer_local, Fmake_local_variable):
13895 Mark variables as initialized.
52746918 13896 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13897
e5aab7e7 13898 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13899 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13900 Rename locals to avoid shadowing.
dff45157
PE
13901 (mark_stack): Move local variables into the #ifdef region where
13902 they're used.
7bc26fdb
PE
13903 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13904 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13905 needed otherwise.
13906 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13907 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13908 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13909
e5aab7e7
PE
13910 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13911 avoids undefined behavior in theory.
13912
4da60324
PE
13913 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13914
88043301
PE
13915 Use functions, not macros, for up- and down-casing (Bug#8254).
13916 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13917 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13918 to use the following functions instead of these macros.
13919 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13920 EMACS_INT, since callers assume the returned value fits in int.
13921 (upcase1): Likewise, for UPCASE_TABLE.
13922 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13923 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13924 the race-condition problem in the old DOWNCASE.
88043301 13925
19ed5445
PE
13926 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13927 Rename locals to avoid shadowing.
13928 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13929 (regex_compile, re_search_2, re_match_2_internal):
13930 Remove unused local vars.
952db0d7
PE
13931 (FREE_VAR): Rewrite so as not to use empty "else",
13932 which gcc can warn about.
da053e48 13933 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13934 (RETALLOC_IF): Define only if needed.
13935 (WORDCHAR_P): Likewise. This one is never needed, but is used
13936 only in a comment talking about a compiler bug, so put inside
13937 the #if 0 of that comment.
13938 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13939 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13940 Remove; unused.
19ed5445 13941
1f3561e4 13942 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13943 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13944 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13945
ded6f8f7
PE
13946 * search.c (simple_search): Remove unused var.
13947
dbd37a95
PE
13948 * dired.c (compile_pattern): Move decl from here ...
13949 * lisp.h: ... to here, so that it can be checked.
13950 (struct re_registers): New forward decl.
13951
7e47afad
PE
13952 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13953
85f24f61
PE
13954 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13955 All uses changed.
13956 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13957 Rename locals to avoid shadowing.
5671df8f 13958 (Fvertical_motion): Mark locals as initialized.
85f24f61 13959
181aa2be 13960 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13961 (casify_region): Mark local as initialized.
181aa2be 13962
930d429c
PE
13963 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13964
7082eac6
PE
13965 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13966 New macros, so that the caller can use some names other than
13967 gcpro1, gcpro2, etc.
13968 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13969 of the new macros.
13970 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13971 argument, for consistency with GCPRO2_VAR, etc: it is now the
13972 prefix of the variable, not the variable itself. All uses
13973 changed.
38b2c076
PE
13974 * dired.c (directory_files_internal, file_name_completion):
13975 Rename locals to avoid shadowing.
13976
15206ed9
PE
13977 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13978 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13979 dired.c's scmp function, had undefined behavior.
13980 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13981 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13982 * buffer.h: ... to here, because these macros use current_buffer,
13983 and the new implementation with inline functions needs to have
13984 current_buffer in scope now, rather than later when the macros
13985 are used.
13986 (downcase, upcase1): New static inline functions.
13987 (DOWNCASE, UPCASE1): Reimplement using these functions.
13988 This avoids undefined behavior in expressions like
13989 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13990 from race conditions in accessing the global variables
13991 case_temp1 and case_temp2.
13992 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13993 * lisp.h (case_temp1, case_temp2): Remove their decls.
13994 * character.h (ASCII_CHAR_P): Move from here ...
13995 * lisp.h: ... to here, so that the inline functions mentioned
13996 above can use them.
13997
4a6bea26
PE
13998 * dired.c (directory_files_internal_unwind): Now static.
13999
f14b7e14
PE
14000 * fileio.c (file_name_as_directory, directory_file_name):
14001 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14002 Now static.
2893f146
PE
14003 (file_name_as_directory): Use const pointers when appropriate.
14004 (Fexpand_file_name): Likewise. In particular, newdir might
14005 point at constant storage, so make it a const pointer.
fd4ead52 14006 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14007 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14008 signedness issues.
f839df0c
PE
14009 (Fset_file_times, Finsert_file_contents, auto_save_error):
14010 Rename locals to avoid shadowing.
f14b7e14 14011
5716756e 14012 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14013 (Ftry_completion, Fall_completions): Rename or remove locals
14014 to avoid shadowing.
5716756e 14015
b4c3046a
PE
14016 * marker.c (bytepos_to_charpos): Remove; unused.
14017
b45db522
PE
14018 * lisp.h (verify_bytepos, count_markers): New decls,
14019 so that gcc does not warn that these functions aren't declared.
14020
85876d07
PE
14021 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14022 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14023 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14024 (copy_text): Remove unused local var.
85876d07 14025
03d78a21 14026 * filelock.c (within_one_second): Now static.
b3dd38ab 14027 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14028
5df8f01b
PE
14029 * buffer.c (fix_overlays_before): Mark locals as initialized.
14030 (fix_start_end_in_overlays): Likewise. This function should be
14031 simplified by using pointers-to-pointers, but that's a different
14032 matter.
b1d876f1 14033 (switch_to_buffer_1): Now static.
8f54f30a
PE
14034 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14035 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14036
a70072c9 14037 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14038 Fix pointer signedness issue.
edced198
PE
14039 (sys_subshell): Mark local as volatile if checking for lint,
14040 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14041 (MAXPATHLEN): Define only if needed.
a70072c9 14042
a0977c44
PE
14043 * process.c (serial_open, serial_configure): Move decls from here ...
14044 * systty.h: ... to here, so that they can be checked.
14045
a884fdcc
PE
14046 * fns.c (get_random, seed_random): Move extern decls from here ...
14047 * lisp.h: ... to here, so that they can be checked.
14048
604efe86 14049 * sysdep.c (reset_io): Now static.
b8950c94 14050 (wait_for_termination_signal): Remove; unused.
604efe86 14051
38fc62d9
PE
14052 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14053 (copy_keymap_item, append_key, push_text_char_description):
14054 Now static.
1004a21a 14055 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14056 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14057 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14058 (describe_map_tree):
14059 Rename locals to avoid shadowing.
38fc62d9 14060
2f2650da
PE
14061 * keyboard.c: Declare functions static if they are not used elsewhere.
14062 (echo_char, echo_dash, cmd_error, top_level_2):
14063 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14064 (read_char, kbd_buffer_get_event, make_lispy_position):
14065 (make_lispy_event, make_lispy_movement, apply_modifiers):
14066 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14067 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14068 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14069 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14070 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14071
a053e86c 14072 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14073 (mark_kboards): Move decl here ...
14074 * alloc.c (mark_kboards): ... from here.
a053e86c 14075
4752793e
PE
14076 * lisp.h (force_auto_save_soon): New decl.
14077
74f10ca7 14078 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14079 (DEFINE_DUMMY_FUNCTION): New macro.
14080 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14081 Use it.
c03cd23f
PE
14082 (main): Add casts to avoid warnings
14083 if GCC considers string literals to be constants.
74f10ca7 14084
022e70d4
PE
14085 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14086
59d6fe83
PE
14087 * dbusbind.c: Pointer signedness fixes.
14088 (xd_signature, xd_append_arg, xd_initialize):
14089 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14090 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14091 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14092 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14093
78320123
PE
14094 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14095 if GCC considers string literals to be constants.
49cebcca 14096 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14097
35ac2a97
SM
140982011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14099
fb103ca9
SM
14100 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14101 (print_preprocess, print_object): New macro to fix last change.
14102
35ac2a97
SM
14103 * print.c (print_preprocess): Don't forget font objects.
14104
62973b41
JB
141052011-03-16 Juanma Barranquero <lekktu@gmail.com>
14106
14107 * emacs.c (USAGE3): Doc fixes.
14108
0e48bb22
AS
141092011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14110
14111 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14112 structure.
14113
7684e57b
JB
141142011-03-14 Juanma Barranquero <lekktu@gmail.com>
14115
14116 * lisp.h (VWindow_system, Qfile_name_history):
14117 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14118 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14119 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14120
14121 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14122 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14123
14124 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14125 * w32console.c (detect_input_pending, read_input_pending)
14126 (encode_terminal_code):
14127 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14128 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14129 (w32_system_caret_y, Qfile_name_history):
14130 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14131 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14132 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14133 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14134 * w32proc.c (Qlocal, report_file_error):
14135 * w32term.c (Vwindow_system, updating_frame):
14136 * w32uniscribe.c (initialized, uniscribe_font_driver):
14137 Remove unneeded extern declarations.
14138
2aa46d6c
CY
141392011-03-14 Chong Yidong <cyd@stupidchicken.com>
14140
c96bbc66 14141 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14142
cffc6f3b
CY
141432011-03-13 Chong Yidong <cyd@stupidchicken.com>
14144
14145 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14146 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14147 These macros can no longer be used for assignment.
14148
44f230aa
SM
14149 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14150 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14151 (record_buffer_markers, fetch_buffer_markers): New functions for
14152 recording and fetching special buffer markers.
14153 (set_buffer_internal_1, set_buffer_temp): Use them.
14154
14155 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14156
14157 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14158
14159 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14160 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14161
14162 * xdisp.c (hscroll_window_tree):
14163 (reconsider_clip_changes): Use PT instead of BUF_PT.
14164
d251f04b
EZ
141652011-03-13 Eli Zaretskii <eliz@gnu.org>
14166
14167 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14168 $(EMACS_ROOT)/lib/intprops.h.
14169
f0c77cd1
PE
141702011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14171
3eca4629
PE
14172 Fix more problems found by GCC 4.5.2's static checks.
14173
7c86ee98
PE
14174 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14175 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14176 (xg_free_frame_widgets): Make it clear that a local variable is
14177 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14178 (gdk_window_get_screen): Make it clear that this macro is needed
14179 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14180 (int_gtk_range_get_value): New function, which avoids a diagnostic
14181 from gcc -Wbad-function-cast.
14182 (xg_set_toolkit_scroll_bar_thumb): Use it.
14183 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14184 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14185 (get_utf8_string, xg_get_file_with_chooser):
14186 Rename locals to avoid shadowing.
14187 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14188
41729b81
PE
14189 * xgselect.c (xg_select): Remove unused var.
14190
f0c77cd1
PE
14191 * image.c (four_corners_best): Mark locals as initialized.
14192 (gif_load): Initialize transparent_p to zero (Bug#8238).
14193 Mark another local as initialized.
ec6cf4c6 14194 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14195
ce0ad53d 14196 * image.c (clear_image_cache): Now static.
d5d5a617 14197 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14198 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14199 (x_edge_detection): Remove unnecessary cast that
14200 gcc -Wbad-function-cast diagnoses.
2037898d 14201 (gif_load): Fix pointer signedness.
6ae141d6
PE
14202 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14203 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14204
33383987 142052011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14206
d32df629
PE
14207 Improve quality of tests for time stamp overflow.
14208 For example, without this patch (encode-time 0 0 0 1 1
14209 1152921504606846976) returns the obviously-bogus value (-948597
14210 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14211 reports time overflow. See
14212 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14213 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14214 * editfns.c: Include limits.h and intprops.h.
14215 (TIME_T_MIN, TIME_T_MAX): New macros.
14216 (time_overflow): Move earlier, to before first use.
14217 (hi_time, lo_time): New functions, for an accurate test for
14218 out-of-range times.
14219 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14220 (Fget_internal_run_time): Don't assume time_t fits in int.
14221 (make_time): Use list2 instead of Fcons twice.
14222 (Fdecode_time): More accurate test for out-of-range times.
14223 (check_tm_member): New function.
14224 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14225 (lisp_time_argument): Don't rely on undefined left-shift and
14226 right-shift behavior when checking for time stamp overflow.
8be6f318 14227
fe31d94c
PE
14228 * editfns.c (time_overflow): New function, refactoring common code.
14229 (Fformat_time_string, Fdecode_time, Fencode_time):
14230 (Fcurrent_time_string): Use it.
14231
8be6f318
PE
14232 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14233 * dired.c (make_time): Move to ...
14234 * editfns.c (make_time): ... here.
14235 * systime.h: Note the move.
14236
09d9db2c 142372011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14238
126bc0dc
YM
14239 * fringe.c (update_window_fringes): Remove unused variables.
14240
c47cbdfd
YM
14241 * unexmacosx.c (copy_data_segment): Also copy __got section.
14242 (Bug#8223)
14243
7ac80be9
EZ
142442011-03-12 Eli Zaretskii <eliz@gnu.org>
14245
c96bbc66 14246 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14247 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14248 Constify `char *' arguments and their references according to
14249 prototypes in tparam.h.
14250
ecb0f94d 14251 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14252
7ac80be9
EZ
14253 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14254 Adapt all references accordingly.
14255
14256 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14257
ef1fd07e
TT
142582011-03-11 Tom Tromey <tromey@redhat.com>
14259
14260 * buffer.c (syms_of_buffer): Remove obsolete comment.
14261
7ef4b50c
EZ
142622011-03-11 Eli Zaretskii <eliz@gnu.org>
14263
14264 * termhooks.h (encode_terminal_code): Declare prototype.
14265
14266 * msdos.c (encode_terminal_code): Don't declare prototype.
14267
14268 * term.c (encode_terminal_code): Now external again, used by
14269 w32console.c and msdos.c.
14270
44f230aa
SM
14271 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14272 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14273
4b1ec863 142742011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14275
1714f52b 14276 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14277
4b1ec863
PE
14278 * fringe.c (update_window_fringes): Mark locals as initialized
14279 (Bug#8227).
14280 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14281
524c7aa6
PE
14282 * alloc.c (mark_fringe_data): Move decl from here ...
14283 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14284 to check its interface.
14285 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14286
a5c0af81 14287 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14288 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14289 (fontset_font): Mark local as initialized.
a9a06e0b 14290 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14291
b4716021
PE
14292 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14293
811e9bac 14294 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14295 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14296 (x_own_selection, Fx_disown_selection_internal): Rename locals
14297 to avoid shadowing.
14298 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14299
7e3ab302
PE
14300 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14301 so that the caller can use some name other than gcpro1.
14302 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14303 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14304 (Fx_backspace_delete_keys_p):
14305 Use them to avoid shadowing, and rename vars to avoid shadowing.
14306 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14307 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14308 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14309 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14310 Remove unused locals.
7e3ab302
PE
14311 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14312 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14313 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14314 macros.
f78faa98 14315
e2b13473
PE
14316 * xterm.h (x_mouse_leave): New decl.
14317
77f23912
PE
14318 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14319 Remove unused functions.
cdf4ba58
PE
14320 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14321 (x_calc_absolute_position): Now static.
7411c686 14322 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14323 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14324 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14325 unless they are used.
38d0b34a
PE
14326 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14327 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14328 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14329 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14330 (x_error_catcher, x_connection_closed, x_error_handler):
14331 (x_error_quitter, xembed_send_message, x_iconify_frame):
14332 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14333 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14334 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14335
44f230aa
SM
14336 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14337 Rename or move locals to avoid shadowing.
6b463e58 14338 (tty_defined_color, merge_face_heights): Now static.
5967d051 14339 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14340 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14341 does not deduce is never used uninitialized.
73719eba
PE
14342 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14343 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14344
426994c3 14345 * terminal.c (store_terminal_param): Now static.
5489860b 14346
032f1620 14347 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14348 (set_frame_menubar): Remove unused local.
d4323972 14349 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14350 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14351 since they might point to immutable storage.
281585b0
PE
14352 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14353 since it's unused otherwise.
032f1620 14354
367c19e5 14355 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14356 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14357 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14358 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14359 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14360 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14361 does not deduce are never used uninitialized.
70739cbe 14362
07b48fa9
PE
14363 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14364
8868a238 14365 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14366 * window.c (window_loop, size_window):
14367 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14368
7e5cf297 14369 * window.c (display_buffer): Now static.
d6550a9f
PE
14370 (size_window): Mark variables that gcc -Wuninitialized
14371 does not deduce are never used uninitialized.
a586633d
PE
14372 * window.h (check_all_windows): New decl, to forestall
14373 gcc -Wmissing-prototypes diagnostic.
5b555da1 14374 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14375
f6095868
PE
14376 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14377 shadowing.
14378 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14379 Include <limits.h>.
14380 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14381 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14382 (load_charset_map): Mark variables that gcc -Wuninitialized
14383 does not deduce are never used uninitialized.
53df7c11 14384 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14385
f38b440c
PE
14386 * coding.c (coding_set_source, coding_set_destination):
14387 Use "else { /* comment */ }" rather than "else /* comment */;"
14388 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14389 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14390 a block, when the outer 'i' will do.
14391 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14392 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14393 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14394 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14395 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14396 Rename locals to avoid shadowing.
14397 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14398 * coding.c (emacs_mule_char, encode_invocation_designation):
14399 Now static, since they're not used elsewhere.
413bb2db 14400 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14401 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14402 (decode_coding_emacs_mule): Mark variables that gcc
14403 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14404 (detect_coding_iso_2022): Initialize a local variable that might
14405 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14406 this initialization is needed. (Bug#8211)
5f58e762
PE
14407 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14408 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14409 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14410 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14411 Remove unused macros.
f38b440c 14412
232b38b9 14413 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14414 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14415 * character.c (string_count_byte8): Likewise.
232b38b9 14416
fb90da1b
PE
14417 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14418 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14419
fb93dbc2
PE
14420 * chartab.c (copy_sub_char_table): Now static, since it's not used
14421 elsewhere.
5c156ace
PE
14422 (sub_char_table_ref_and_range, char_table_ref_and_range):
14423 Rename locals to avoid shadowing.
bbcd0949 14424 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14425
7d3b3862 14426 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14427 (BIDI_BOB): Remove unused macro.
7d3b3862 14428
6be7d3da
PE
14429 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14430 deduce are never used uninitialized.
c2ed9c8b 14431 * term.c (encode_terminal_code): Likewise.
6be7d3da 14432
75f8807f 14433 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14434
50938595
PE
14435 * tparam.h: New file.
14436 * term.c, tparam.h: Include it.
14437 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14438 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14439 Move these decls to tparam.h, and make them agree with what
14440 is actually in tparam.c. The previous trick of using incompatible
14441 decls in different modules does not conform to the C standard.
14442 All callers of tparam changed to use tparam's actual API.
14443 * tparam.c (tparam1, tparam, tgoto):
14444 Use const pointers where appropriate.
14445
fbceeba2
PE
14446 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14447 * cm.h (struct cm): Likewise.
14448 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14449 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14450 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14451 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14452 (turn_on_face, init_tty): Likewise.
14453 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14454
7f3f1250
PE
14455 * term.c (term_mouse_position): Rename local to avoid shadowing.
14456
e6ca6543
PE
14457 * alloc.c (mark_ttys): Move decl from here ...
14458 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14459
c40f8d15
AS
144602011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14461
14462 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14463
cfe0661d
JB
144642011-03-09 Juanma Barranquero <lekktu@gmail.com>
14465
14466 * search.c (compile_pattern_1): Remove argument regp, unused since
14467 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14468 (compile_pattern): Don't pass it.
14469
0afb4571
J
144702011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14471
14472 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14473 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14474 for ! HAVE_GTK3.
14475 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14476
14477 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14478
14479 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14480 gdk_window_get_screen, gdk_window_get_geometry,
14481 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14482 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14483 (xg_get_pixbuf_from_pixmap): New function.
14484 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14485 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14486 Call xg_get_pixbuf_from_pixmap instead of
14487 gdk_pixbuf_get_from_drawable.
14488 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14489 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14490 (xg_check_special_colors): Use GtkStyleContext and its functions
14491 for HAVE_GTK3.
14492 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14493 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14494 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14495 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14496 Call gtk_widget_get_preferred_size.
0afb4571
J
14497 (xg_frame_resized): gdk_window_get_geometry only takes 5
14498 parameters.
44f230aa
SM
14499 (xg_win_to_widget, xg_event_is_for_menubar):
14500 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14501 (xg_set_widget_bg): New function.
14502 (delete_cb): New function.
895009e1 14503 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14504 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14505 (xg_set_background_color): Call xg_set_widget_bg.
14506 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14507 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14508 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14509 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14510 if ! HAVE_GTK3.
14511 (update_frame_tool_bar): Call gtk_widget_hide.
14512 (xg_initialize): Use GDK_KEY_g.
14513
14514 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14515 if ! HAVE_GTK3
14516 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14517
14518 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14519 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14520 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14521
1c2cc4ef
JB
145222011-03-08 Juanma Barranquero <lekktu@gmail.com>
14523
14524 * w32xfns.c (select_palette): Check success of RealizePalette against
14525 GDI_ERROR, not zero.
14526
33383987 14527See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14528
14529;; Local Variables:
14530;; coding: utf-8
aac0c6e3
MR
14531;; End:
14532
2f097256 14533 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14534
14535 This file is part of GNU Emacs.
14536
14537 GNU Emacs is free software: you can redistribute it and/or modify
14538 it under the terms of the GNU General Public License as published by
14539 the Free Software Foundation, either version 3 of the License, or
14540 (at your option) any later version.
14541
14542 GNU Emacs is distributed in the hope that it will be useful,
14543 but WITHOUT ANY WARRANTY; without even the implied warranty of
14544 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14545 GNU General Public License for more details.
14546
14547 You should have received a copy of the GNU General Public License
14548 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.